Question: Why does Cuda rand_normal does not support F16 datatype?

Hello everybody!
I was testing my LoRA ports of some of the Candle transformers to candle-lora, specifically the Llama example, when I ran into this error:
thread 'main' panicked at /home/ubuntu/candle-lora/candle-lora/src/lib.rs:49:18:
called `Result::unwrap()` on an `Err` value: Cuda(UnsupportedDtype { dtype: F16, op: "rand_normal" })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I see that the error is  Cuda(UnsupportedDtype { dtype: F16, op: "rand_normal" }), which seems to me that Cuda+rand_normal+F16 does not work. Is this true?
To reproduce, please clone candle-lora and run the following:
cargo run --package candle-lora-transformers --example llama --features cuda
Of course, the Candle example of Llama (which mine is directly based upon), works:
cargo run --package candle-examples --example llama --features cuda
Please note that my LoRA Llama example runs as expected without Cuda, and the error only occurs with Cuda. The datatype is (and should be) F16 here, as I have verified.
Is this possibly related to the init::DEFAULT_KAIMING_NORMAL usage here?

https://github.com/EricLBuehler/candle-lora/blob/7f0c22575aac48a04240240d46d02f2f3ecef298/candle-lora/src/loralinear.rs#L49

If it is, what datatypes work with DEFAULT_KAIMING_NORMAL?
My 2 questions are:

What datatypes work with DEFAULT_KAIMING_NORMAL in Cuda?
Otherwise, if the datatypes are not the problem, how can I fix this?

I would really appreciate any help!

I am going to close this, as I found the source of the error:

https://github.com/huggingface/candle/blob/392a00a147c26ebe70c6484d72223d02ada6a72a/candle-core/src/cuda_backend.rs#L331


Better usage documentation

I'm currently using this for a project, and I'm wondering if you guys have this on any type of package manager? I've tried looking around and couldn't actually find much for Mint / Ubuntu (The ones I care about). Is there anyway that there can be documentation on this / Cmake installation instructions?

I'm running Ubuntu, so eventually there will be .deb packages... There hasn't been much discussion yet about when we are starting to make binary packages for different Ubuntu versions... I would assume that there will be binary packages around the first official release.

I tried building .deb file with following scripts:
debian/control:
Source: zlib-ng
Maintainer: Mika Lindqvist<EMAIL_ADDRESS>Section: misc
Priority: optional
Standards-Version: 3.9.2
Build-Depends: debhelper (>= 9)

Package: zlib-ng
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Next Generation compression library based on zlib.

debian/rules:
#!/usr/bin/make -f
%:
        dh $@

override_dh_auto_configure:
        ./configure --prefix=/usr --includedir=\${prefix}/include --sysconfdir=/etc --localstatedir=/var --libdir=\${prefix}/lib/x86_64-linux-gnu

There is some other files under the debian subdirectory too, but I made a separate zip file, so I can reuse the files with any source zip file.

I think the idea is to use cpack since we already have cmake

We don't have cpack support in the build tree yet... using dh was minimalistic approach as it only requires the flags to configure...

Since package managers vary, the instructions will also vary. CPack has been added in #1556. I have created a PR to add instructions to the readme #1579.


PEP8 compliant

Ensure all .py files are compliant with PEP8. Specifically in regards to maximum line length for documentation.

[x] network.py

[x] analysis.py

[x] util.py

[x] api.py

[x] init__.py

[x] tests/test_network.py

[x] tests/test_network_api.py

resolved in PR #60


Dlab 1415

added name tag for images on gcp, now billing report there contains images
changed Name tag for images on azure, as images had tag value that didn`t represent image name


Variables in CSS styles editor

Hi, is it possible to use Grafana dashboard variables in CSS styles editor? If not, It would be a nice-to-have feature.

@evenckus Dashboard variables are not supported in the CSS Styles Editor.
I am curious, what do you want to use variables for?

@mikhail-vl Having variables support in CSS Styles Editor would let us customize the background colors or any other style properties. For example, we have query variables that use custom datasources from different brands, so it would be nice to have an option to change the styling based on what branding each datasource has.


ISPN-6175 Server throwing warning about wrong eviction configuration

https://issues.jboss.org/browse/ISPN-6175

Pushed, thanks


Wrong method name in the sentence.

[Enter feedback here]
DbSet<TEntity>.Add was used instead of DbSet<TEntity>.Remove in the sentence. See attached screenshot below.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23f8db8b-8ee6-86c9-7cb2-b5802214ec13
Version Independent ID: b959839c-684e-5d60-650e-0af17c971c79
Content: Basic SaveChanges - EF Core
Content Source: entity-framework/core/saving/basic.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

Duplicate of #4362

Already fixed, needs to be pushed live.


Testing macos-11 runner

That worked but it's probably not on M1, is it?

Nope. I thought it was at first.


Deployment

Deployment
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website using the URL
THEN I can access my website from any browser

Deployed the site utilizing Github.
URL for the new site: https://nickdavis07.github.io/prework-study-guide/


Rework ghr alias to include gh run subcommands

test drive copilot workspace - ask it to rework-ghr - mostly correct but missing removal of ghr => gh reference which is now unused.
Related to #1
Reworks the ghr alias in zsh/compat_fish/gh.zsh to expand into gh run and its subcommands, enhancing the command-line interface for GitHub CLI users.

Introduces new aliases for gh run subcommands: Adds aliases ghrl for gh run list, ghrv for gh run view, ghrr for gh run rerun, ghrc for gh run cancel, ghrd for gh run delete, ghrw for gh run watch, and ghrdl for gh run download. This allows for quicker and more intuitive access to common gh run operations directly from the terminal.
Maintains existing functionality: The update preserves the existing aliases and commands for other gh functionalities, ensuring that the addition of new gh run subcommand aliases does not disrupt the current user experience.

For more details, open the Copilot Workspace session.

Removes the unused ghr alias for gh reference from zsh/compat_fish/gh.zsh as requested in the task.

For more details, open the Copilot Workspace session.


HostPortOverride does not support use with full nodes

Note: This issue only focuses on cosmos chain nodes.
Overview
When HostPortOverride is set in the chain config, the chain must be run with no full nodes. Additionally, the port(s) are only exposed on the first validator node.
Because only one process can bind to a single host port, the explicit port exposures defined in HostPortOverride are only applied to the first validator. This is enforced by only applying the override to nodes with Index == 0:
https://github.com/strangelove-ventures/interchaintest/blob/c8b741617cd8da95d4377c938c411c452490d16f/chain/cosmos/chain_node.go#L1062-L1072
However, because cosmosChain.Validators[0].Index and cosmosChain.FullNodes[0].Index are both 0, a chain with port overrides will not start when NumFullNodes > 0 (the 0th full node and 0th validator cannot both bind to the override port).
Reproduction
Attempt to start a chain with non-empty HostPortOverride map and at least one Full Node:
one := 1
cf := interchaintest.NewBuiltinChainFactory(zaptest.NewLogger(t), []*interchaintest.ChainSpec{
	{
		Name:    "gaia",
		Version: "v15.2.0",
		ChainConfig: ibc.ChainConfig{
			HostPortOverride: map[int]int{8080: 8080}, // <--- attempting to expose port 8080
		},
		NumFullNodes: &one, // <--- default value, one full node alongside the validators
	},
})

Error: failed to start chain gaia-2: failed to generate port bindings: listen tcp <IP_ADDRESS>:8080: bind: address already in use
Note that the port binding conflict is from starting the validator with port 8080 exposed, and then attempting to start the full node with port 8080 exposed. It isn't from an already-running process bound to port 8080 😄
Current Workaround
The current workaround for the above problem is to only run validator nodes (no full nodes) by setting NumFullNodes to zero. When there are no full nodes, there are not conflicts in the bound ports of the chain nodes so the chain starts without problem.
Proposed Solution
Simple Fix
To allow Full nodes to run alongside validators while still allowing the first validator to have custom (explicit) port(s) exposed, update the existing condition to check that the node is a validator in addition to having Index == 0:
tn.Validator && tn.Index == 0 && chainCfg.HostPortOverride != nil

This should be backwards compatible because:

a chain must have a validator to run
no current implementation using the HostPortOverride map works with full nodes & a validator

I've opened a PR with this change: https://github.com/strangelove-ventures/interchaintest/pull/1090
Improved DevX
Leverage the currently used random host port assignment for user-defined ports by adding a config value that is a list of port ids that look like <port>/<protocol>. This, coupled with a new utility function for finding host addresses by port id would allow exposing arbitrary ports on all nodes (multiple validators & full nodes).
This can be implemented by injecting the user-defined port ids into the usingPorts map here: https://github.com/strangelove-ventures/interchaintest/blob/c8b741617cd8da95d4377c938c411c452490d16f/chain/cosmos/chain_node.go#L1057
Example: Ethermint chains run Ethereum JSON-RPC APIs on port 8545. This port could be exposed, and the endpoint used, by adding a new config property & a helper func to get the host address:
chainConfig := ibc.ChainConfig{
	// chain config details here...
	ExposeAdditionalPorts: []string{"8545/tcp"}
}
// ...
// get address for the exposed ports on a node
fullNode0EvmUrl := chain.FullNodes[0].GetHostAddress(ctx, "8545/tcp")
validator0EvmUrl := chain.Validators[0].GetHostAddress(ctx, "8545/tcp")

The benefit of a new implementation like this is that we can expose ports on all validators and full nodes, instead of only the first validator.
Let me know if this should be a separate feature request ticket---I'd be happy to create it.

@pirtleshell  Thanks! The improved Dev UX should be in its own PR since it's a feat rather than a fix.

thanks @Reecepbcups. sounds good, i will open a feature request ticket

opened an issue referencing the feature request here.
thanks for the fast merge @Reecepbcups 🎉 appreciate this great testing framework y'all have going here 🙏


Improve user friendly-ness with LLM help?

Just tried out datasette for the first time against my claude export history and it's great.
However for now techies, perhaps a cool feature might be to accept text input and to connect datasette to an llm and for the llm to generate the sql that datasette could run against. This can have the benefit of helping a new user get up to speed with sql and to be able to query data in natural language too.

Yes, absolutely! I've been trying this out in plugins so far:

https://github.com/datasette/datasette-query-assistant


Align pandas objects with named indexes

closes https://github.com/xray/xray/issues/664.
What's new & docs forthcoming

Look very nice to me!

@shoyer updated, docs & what's new added, and green

Thanks!


preprocess:rename idle state

Dears,
I'm trying to run a simple test with one of my fasta. But, in the step preprocess:rename never ends (11 hours of execution without progress).
the log:
Launching `https://github.com/EBI-Metagenomics/emg-viral-pipeline` [shrivelled_cantor] DSL2 - revision: aaf02d636a [v1.1]

Profile: local,singularity

Current User: valensan
Nextflow-version: 23.04.1
Starting time: 15-04-2023 06:51 UTC
Workdir location:
  /scratch/project_2007362/sandro/HeP_samples/6_tax_profile/phage/HeP-1003_tmp
Databases location:
  nextflow-autodownload-databases

Dev ViPhOG database: v3
Dev Meta database: v2

Only run annotation: false

[-        ] process > download_pprmeta:pprmetaGet    -
[-        ] process > download_virsorter_db:virso... -
[-        ] process > download_virfinder_db:virfi... -
[-        ] process > download_model_meta:metaGetDB  -
[-        ] process > download_viphog_db:viphogGetDB -
[-        ] process > download_ncbi_db:ncbiGetDB     -
[-        ] process > download_checkv_db:checkvGetDB -
[-        ] process > preprocess:rename              -
[-        ] process > preprocess:length_filtering    -
[-        ] process > detect:virsorter               -
[-        ] process > detect:virfinder               -
[-        ] process > detect:pprmeta                 -
[-        ] process > detect:parse                   -
[-        ] process > postprocess:restore            -
[-        ] process > annotate:prodigal              -
[-        ] process > annotate:hmmscan_viphogs       -
[-        ] process > annotate:hmm_postprocessing    -

[skipped  ] process > download_pprmeta:pprmetaGet    [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_virsorter_db:virso... [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_virfinder_db:virfi... [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_model_meta:metaGetDB  [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_viphog_db:viphogGetDB [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_ncbi_db:ncbiGetDB     [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_checkv_db:checkvGetDB [100%] 1 of 1, stored: 1 ✔
[-        ] process > preprocess:rename              [  0%] 0 of 1
[-        ] process > preprocess:length_filtering    -
[-        ] process > detect:virsorter               -
[-        ] process > detect:virfinder               -
[-        ] process > detect:pprmeta                 -
[-        ] process > detect:parse                   -
[-        ] process > postprocess:restore            -
[-        ] process > annotate:prodigal              -
[-        ] process > annotate:hmmscan_viphogs       -
[-        ] process > annotate:hmm_postprocessing    -
[-        ] process > annotate:ratio_evalue          -
[-        ] process > annotate:annotation            -
[-        ] process > annotate:plot_contig_map       -
[-        ] process > annotate:assign                -
[-        ] process > annotate:checkV                -
[-        ] process > annotate:write_gff             -
[-        ] process > plot:generate_krona_table      -
[-        ] process > plot:krona                     -
[-        ] process > plot:generate_sankey_table     -
[-        ] process > plot:sankey                    -
[skipping] Stored process > download_virsorter_db:virsorterGetDB
[skipping] Stored process > download_model_meta:metaGetDB
[skipping] Stored process > download_virfinder_db:virfinderGetDB
[skipping] Stored process > download_viphog_db:viphogGetDB
[skipping] Stored process > download_ncbi_db:ncbiGetDB
[skipping] Stored process > download_checkv_db:checkvGetDB
[skipping] Stored process > download_pprmeta:pprmetaGet

executor >  local (1)
[skipped  ] process > download_pprmeta:pprmetaGet    [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_virsorter_db:virso... [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_virfinder_db:virfi... [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_model_meta:metaGetDB  [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_viphog_db:viphogGetDB [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_ncbi_db:ncbiGetDB     [100%] 1 of 1, stored: 1 ✔
[skipped  ] process > download_checkv_db:checkvGetDB [100%] 1 of 1, stored: 1 ✔
[7c/d224ad] process > preprocess:rename (1)          [  0%] 0 of 1
[-        ] process > preprocess:length_filtering    -
[-        ] process > detect:virsorter               -
[-        ] process > detect:virfinder               -
[-        ] process > detect:pprmeta                 -
[-        ] process > detect:parse                   -
[-        ] process > postprocess:restore            -
[-        ] process > annotate:prodigal              -
[-        ] process > annotate:hmmscan_viphogs       -
[-        ] process > annotate:hmm_postprocessing    -
[-        ] process > annotate:ratio_evalue          -
[-        ] process > annotate:annotation            -
[-        ] process > annotate:plot_contig_map       -
[-        ] process > annotate:assign                -
[-        ] process > annotate:checkV                -
[-        ] process > annotate:write_gff             -
[-        ] process > plot:generate_krona_table      -
[-        ] process > plot:krona                     -
[-        ] process > plot:generate_sankey_table     -
[-        ] process > plot:sankey                    -
[skipping] Stored process > download_virsorter_db:virsorterGetDB
[skipping] Stored process > download_model_meta:metaGetDB
[skipping] Stored process > download_virfinder_db:virfinderGetDB
[skipping] Stored process > download_viphog_db:viphogGetDB
[skipping] Stored process > download_ncbi_db:ncbiGetDB
[skipping] Stored process > download_checkv_db:checkvGetDB
[skipping] Stored process > download_pprmeta:pprmetaGet
slurmstepd: error: *** JOB 17698767 ON r06c28 CANCELLED AT 2023-07-07T04:26:41 DUE TO TIME LIMIT ***

Additionally, I looked into .command.err and .command.log there is almost no output just:
INFO:    Convert SIF file to sandbox...

what could I do?
thanks in advance

Hi @Sanrrone
That is seems to be a problem with your singularity setup. Can you try with Docker instead?
Cheers

Hi!,
unfortunately I am under a HPC so I cannot use Docker.

Hi @Sanrrone!
Ah, but when you are on a HPC please use the available job scheduler, e.g. if it is SLURM:
-profile slurm,singularity

I think you used local which will run all processes on the current node you are (probably the login node, where no calculations should run).
Besides, on some HPCs there are latency issues. If this still happens, please let us know and we can maybe give some further guidance.

Hi,
I'm using local but inside a slurm job just to test it.
if I use the slurm profile I got:
sbatch: error: AssocMaxSubmitJobLimit which is a missconfiguration in the profile. How can I edit the slurm profile?

So you submit the whole pipeline run command as a SLURM job? Hm, should also work I think.
To edit the Nextflow SLURM profile, you could clone the GitHub repository and edit the nextflow.config file (there is a SLURM part, https://github.com/EBI-Metagenomics/emg-viral-pipeline/blob/master/nextflow.config#L99). Then, run the pipeline via specifying the nextflow run virify.nf ...
There is also a way to inject an additional configuration via the -c flag that can overwrite pipeline defaults. But maybe it's easier to first try the other way.

Hi,
I used the slurm profile with the local virify.nf with no success, still the process doesn't finish.
N E X T F L O W  ~  version 23.04.1
Launching `/scratch/project_2007362/software/emg-viral-pipeline/virify.nf` [nice_planck] DSL2 - revision: 20ab8a0de7

Profile: slurm,singularity

Current User: valensan
Nextflow-version: 23.04.1
Starting time: 15-04-2023 06:51 UTC
Workdir location:
  /scratch/project_2007362/sandro/HeP_samples/6_tax_profile/phage/HeP-1003_tmp
Databases location:
  nextflow-autodownload-databases

Dev ViPhOG database: v3
Dev Meta database: v2

Only run annotation: false

[-        ] process > preprocess:rename           -
[-        ] process > preprocess:length_filtering -
[-        ] process > detect:virsorter            -
[-        ] process > detect:virfinder            -
[-        ] process > detect:pprmeta              -
[-        ] process > detect:parse                -
[-        ] process > postprocess:restore         -
[-        ] process > annotate:prodigal           -
[-        ] process > annotate:hmmscan_viphogs    -
[-        ] process > annotate:hmm_postprocessing -
[-        ] process > annotate:ratio_evalue       -
[-        ] process > annotate:annotation         -
[-        ] process > annotate:plot_contig_map    -

[-        ] process > preprocess:rename           -
[-        ] process > preprocess:length_filtering -
[-        ] process > detect:virsorter            -
[-        ] process > detect:virfinder            -
[-        ] process > detect:pprmeta              -
[-        ] process > detect:parse                -
[-        ] process > postprocess:restore         -
[-        ] process > annotate:prodigal           -
[-        ] process > annotate:hmmscan_viphogs    -
[-        ] process > annotate:hmm_postprocessing -
[-        ] process > annotate:ratio_evalue       -
[-        ] process > annotate:annotation         -
[-        ] process > annotate:plot_contig_map    -
[-        ] process > annotate:assign             -
[-        ] process > annotate:checkV             -
[-        ] process > annotate:write_gff          -
[-        ] process > plot:generate_krona_table   -
[-        ] process > plot:krona                  -
[-        ] process > plot:generate_sankey_table  -
[-        ] process > plot:sankey                 -

executor >  slurm (1)
[df/c2eed8] process > preprocess:rename (1)       [  0%] 0 of 1
[-        ] process > preprocess:length_filtering -
[-        ] process > detect:virsorter            -
[-        ] process > detect:virfinder            -
[-        ] process > detect:pprmeta              -
[-        ] process > detect:parse                -
[-        ] process > postprocess:restore         -
[-        ] process > annotate:prodigal           -
[-        ] process > annotate:hmmscan_viphogs    -
[-        ] process > annotate:hmm_postprocessing -
[-        ] process > annotate:ratio_evalue       -
[-        ] process > annotate:annotation         -
[-        ] process > annotate:plot_contig_map    -
[-        ] process > annotate:assign             -
[-        ] process > annotate:checkV             -
[-        ] process > annotate:write_gff          -
[-        ] process > plot:generate_krona_table   -
[-        ] process > plot:krona                  -
[-        ] process > plot:generate_sankey_table  -
[-        ] process > plot:sankey                 -

executor >  slurm (1)
[df/c2eed8] process > preprocess:rename (1)       [  0%] 0 of 1
[-        ] process > preprocess:length_filtering -
[-        ] process > detect:virsorter            -
[-        ] process > detect:virfinder            -
[-        ] process > detect:pprmeta              -
[-        ] process > detect:parse                -
[-        ] process > postprocess:restore         -
[-        ] process > annotate:prodigal           -
[-        ] process > annotate:hmmscan_viphogs    -
[-        ] process > annotate:hmm_postprocessing -
[-        ] process > annotate:ratio_evalue       -
[-        ] process > annotate:annotation         -
[-        ] process > annotate:plot_contig_map    -
[-        ] process > annotate:assign             -
[-        ] process > annotate:checkV             -
[-        ] process > annotate:write_gff          -
[-        ] process > plot:generate_krona_table   -
[-        ] process > plot:krona                  -
[-        ] process > plot:generate_sankey_table  -
[-        ] process > plot:sankey                 -

the strange thing is I have no log about it so I cannot track the issue at all.

Ok, this is indeed strange.
Can you run other Nextflow pipelines (e.g. try smt from https://nf-co.re/)? I want to figure out if this is a specific problem with VIRify or a general problem with your architecture and Nextflow installation.

I tried to run viroprofiler, and yes, Also with an error but this time related with singularity:
-[ViroProfiler] Pipeline completed with errors-

[-        ] process > VIROPROFILER:SETUP:DB_CHECKV   -
[-        ] process > VIROPROFILER:SETUP:DB_VIBRANT  -
[-        ] process > VIROPROFILER:SETUP:DB_VIRSO... -
[-        ] process > VIROPROFILER:SETUP:DB_DRAM     -
[-        ] process > VIROPROFILER:SETUP:DB_IPHOP    -
[-        ] process > VIROPROFILER:SETUP:DB_VREFSEQ  -
Pulling Singularity image docker://denglab/viroprofiler-virsorter2:v0.2.5 [cache /scratch/project_2007362/software/singularity/cache/denglab-viroprofiler-virsorter2-v0.2.5.img]
Pulling Singularity image docker://denglab/viroprofiler-geneannot:v0.2 [cache /scratch/project_2007362/software/singularity/cache/denglab-viroprofiler-geneannot-v0.2.img]
Pulling Singularity image docker://denglab/viroprofiler-vibrant:v0.2 [cache /scratch/project_2007362/software/singularity/cache/denglab-viroprofiler-vibrant-v0.2.img]
Pulling Singularity image docker://denglab/viroprofiler-host:v0.1 [cache /scratch/project_2007362/software/singularity/cache/denglab-viroprofiler-host-v0.1.img]
Pulling Singularity image docker://denglab/viroprofiler-base:v0.2 [cache /scratch/project_2007362/software/singularity/cache/denglab-viroprofiler-base-v0.2.img]

ERROR ~ Error executing process > 'VIROPROFILER:SETUP:DB_VIRSORTER2'
Caused by:
  Failed to pull singularity image
  command: singularity pull  --name denglab-viroprofiler-virsorter2-v0.2.5.img.pulling.1689159264399 docker://denglab/viroprofiler-virsorter2:v0.2.5 > /dev/null
  status : 255
  message:
    INFO:    Converting OCI blobs to SIF format
    WARNING: 'nodev' mount option set on /scratch, it could be a source of failure during build process
    INFO:    Starting build...
    Getting image source signatures
    Copying blob sha256:7a6db449b51b92eac5c81cdbd82917785343f1664b2be57b22337b0a40c5b29d
    Copying blob sha256:b51904ca3834848d576e609bab4b382028643e662db724a58edb9401f9af220c
    Copying blob sha256:16f76cf3882a90e2e7969b03b7d0147c189cfb3966d14800091466f2d5fc0a51
    Copying blob sha256:377cc88d7c7e949460cc24d07979f2e428f2482e0b360d72860ff1df404208e0
    Copying blob sha256:7a15ae76cb488a6adde55d23dfd5571c57bf02206168b7795f7b473b1dc7c218
    Copying blob sha256:d0e88a31bdb313b5fab1a325bc79ad5c487cb722dbf65b1561fd4810ebd7b717
    Copying blob sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1
    Copying blob sha256:301aa5df7f62dcf710fc30e41d585887f918992bc71dba116c7edc267a3c3422
    Copying blob sha256:26142b6b2c1ea5de9b7566a9862ea2e9beb02b1a059295cd221ec89c75aac1e8
    Copying blob sha256:a7c07239fd155305c23fdbe3cb67838b8d57e0d5922d01b643ec5da4dbf7c7d7
    Copying blob sha256:a540153f7d72ad59b0b5d01a2425f0a8aa59bcd9fe6d0784aaeb43301f903aff
    Copying blob sha256:c0f68707fa83ac4d248c81ac27d1dd5d378fed88ddf1e6edb8d9fb1f549d75bd
    Copying blob sha256:66cbca5e11012c5b367f8b2cf18f81ec91b1780abcc9a34ba008a4ecb197f3a4
    Copying config sha256:ef836e11d9dcca820a285d003fb8af9a8e7051282bd5158c1eaa645da4ba00b7
    Writing manifest to image destination
    Storing signatures
    FATAL:   While making image from oci registry: error fetching image to cache: while building SIF from layers: conveyor failed to get: Error initializing source oci:/scratch/project_2007362/software/singularity/cache/cache/blob:88d200bb0a32556fa99b4af044d0224b2ddf3c25d05fe56976067b5eaab5eb60: EOF

but at least in this case I have the error to do some tracking.
What do you think?

Maybe smt is wrong with the singularity image that was pulled and converted for VIRify, causing the latency issue.
Can you remove the singularity images that were already stored for VIRify, and then run the pipeline again with -profile local,singularity and also define --cores 1 --max_cores 1. You can use some small test FASTA as input. By that, the pipeline should go through each process step by step and pull the images. Once all the images are stored, you can run the full pipeline.

Hi,
Still the same error, after a clean installation, and using the parameters you specified. I also think something is wrong with the archiquecture of the HPC. But, how can I figure out it?

Hm, do you have some admin to ask for help?
Sometimes, on HPC with Singularity, it also helps to specify some environment variables, see here:
export SINGULARITY_TMPDIR=/path/to/some/singularity_tmpdir

E.g. see the discussion here: https://github.com/nextflow-io/nextflow/issues/2786
Or see here https://www.nextflow.io/docs/latest/config.html#config-singularity and scroll down to
Environment variables
Can you try another pipeline I am heavily involved (maybe I then know better what's going on if it also fails or works): https://github.com/replikation/poreCov
nextflow run replikation/poreCov -profile test_fastq,slurm,singularity -r 1.8.3 --update

It might be that you have to define some additional parameters based on your infrastructure. Per default, the pipeline will store downloaded singularity images to a folder ./singularity and also intermediate files to .work.
I would be curious if this runs or you get again an error (e.g. the same as for viroprofiler.

Hi,
I always use the cache dir env variable (its a good practice). Also I tried the new software to test. I got some errors but they are different:
the run code
export SINGULARITY_CACHEDIR="/scratch/sandro/HeP_samples/6_tax_profile/phage/tmpfolder"
nextflow run replikation/poreCov -profile "test_fastq,local,singularity" -r 1.8.3 --max-cores 16 --update --cachedir $SINGULARITY_CACHEDIR

N E X T F L O W  ~  version 23.04.1
Launching `https://github.com/replikation/poreCov` [magical_torvalds] DSL2 - revision: b86c57c384 [1.8.3]

________________________________________________________________________________

poreCov | A Nextflow SARS-CoV-2 workflow for nanopore data

  Latest available poreCov release: 1.8.3
  If neccessary update via: nextflow pull replikation/poreCov
________________________________________________________________________________
 Using 4/16 CPU threads per process for a local run [--max_cores]

WARNING: Singularity image building sometimes fails!
Multiple resumes (-resume) and --max_cores 1 --cores 1 for local execution might help.

Warning: Running --update might not be poreCov compatible!
Found latest pangolin container, using: nanozoo/pangolin-v4:4.3--1.21
Found latest nextclade2 container, using: nanozoo/nextclade2:2.14.0--2023-06-16

.
Profile:             test_fastq,local,singularity
Current User:        valensan
Nextflow-version:    23.04.1
poreCov-version:     1.8.3

Pathing:
Workdir location [-work-Dir]:
    /scratch/project_2007362/sandro/HeP_samples/6_tax_profile/phage/work/nextflow-poreCov-valensan
Output dir [--output]:
    results
Databases location [--databases]:
    /scratch/project_2007362/software/singularity/cache
Singularity cache dir [--cachedir]:
    /scratch/project_2007362/software/singularity/cache
______________________________________
Parameters:
Medaka model:         r941_min_hac_g507 [--medaka_model]
Min depth nucleotide: 20 [--min_depth]
Latest Pangolin/Nextclade?: true [--update]
CPUs to use:          4 [--cores]
Memory in GB:         12 [--memory]
______________________________________

Primerscheme:        V1200 [--primerV]
Min read-length set to: 400 [--minLength]
Max read-length set to: 1500 [--maxLength]
______________________________________

RKI output for german DESH upload:
Output stored at:      results/4.RKI-summary
Min Identity to NC_045512.2: 0.90 [--seq_threshold]
Min Depth used:        20 [--min_depth]
   Min Depth should be 20 or more for RKI upload
Proportion cutoff N:   0.05 [--n_threshold]
______________________________________

[-        ] process > get_nanopore_fastq -

[-        ] process > get_nanopore_fastq             -
[-        ] process > read_qc_wf:nanoplot            -
[-        ] process > filter_fastq_by_length         -
[-        ] process > read_classification_wf:down... -
[-        ] process > read_classification_wf:kraken2 -
[-        ] process > read_classification_wf:krona   -
[-        ] process > artic_ncov_wf:artic_medaka     -
[-        ] process > artic_ncov_wf:covarplot        -
[-        ] process > determine_lineage_wf:pangolin  -
[-        ] process > determine_mutations_wf:next... -
[-        ] process > genome_quality_wf:president    -
[-        ] process > genome_quality_wf:seqrs        -
[-        ] process > rki_report_wf:rki_report       -
[-        ] process > align_to_reference             -
[-        ] process > create_summary_report_wf:ge... -
[-        ] process > create_summary_report_wf:pl... -
[-        ] process > create_summary_report_wf:su... -

executor >  local (2)
[49/7cd4aa] process > get_nanopore_fastq             [  0%] 0 of 1
[-        ] process > read_qc_wf:nanoplot            -
[-        ] process > filter_fastq_by_length         -
[b5/1e2c57] process > read_classification_wf:down... [  0%] 0 of 1
[-        ] process > read_classification_wf:kraken2 -
[-        ] process > read_classification_wf:krona   -
[-        ] process > artic_ncov_wf:artic_medaka     -
[-        ] process > artic_ncov_wf:covarplot        -
[-        ] process > determine_lineage_wf:pangolin  -
[-        ] process > determine_mutations_wf:next... -
[-        ] process > genome_quality_wf:president    -
[-        ] process > genome_quality_wf:seqrs        -
[-        ] process > rki_report_wf:rki_report       -
[-        ] process > align_to_reference             -
[-        ] process > create_summary_report_wf:ge... -
[-        ] process > create_summary_report_wf:pl... -
[-        ] process > create_summary_report_wf:su... -

executor >  local (3)
[49/7cd4aa] process > get_nanopore_fastq             [100%] 1 of 1, failed: 1 ✔
[-        ] process > read_qc_wf:nanoplot            -
[-        ] process > filter_fastq_by_length         -
[43/c564d7] process > read_classification_wf:down... [ 50%] 1 of 2, failed: 1...
[-        ] process > read_classification_wf:kraken2 -
[-        ] process > read_classification_wf:krona   -
[-        ] process > artic_ncov_wf:artic_medaka     -
[-        ] process > artic_ncov_wf:covarplot        -
[-        ] process > determine_lineage_wf:pangolin  -
[-        ] process > determine_mutations_wf:next... -
[-        ] process > genome_quality_wf:president    -
[-        ] process > genome_quality_wf:seqrs        -
[-        ] process > rki_report_wf:rki_report       -
[-        ] process > align_to_reference             -
[-        ] process > create_summary_report_wf:ge... -
[-        ] process > create_summary_report_wf:pl... -
[-        ] process > create_summary_report_wf:su... -
Not enough reads in all samples, please investigate results/1.Read_quality
Could not generate any genomes, please check your reads results/1.Read_quality
[49/7cd4aa] NOTE: Process `get_nanopore_fastq` terminated with an error exit status (255) -- Error is ignored
[b5/1e2c57] NOTE: Process `read_classification_wf:download_database_kraken2` terminated with an error exit status (255) -- Execution is retried (1)

executor >  local (4)
[49/7cd4aa] process > get_nanopore_fastq             [100%] 1 of 1, failed: 1 ✔
[-        ] process > read_qc_wf:nanoplot            -
[-        ] process > filter_fastq_by_length         -
[43/c564d7] process > read_classification_wf:down... [ 50%] 1 of 2, failed: 1...
[-        ] process > read_classification_wf:kraken2 -
[-        ] process > read_classification_wf:krona   -
[-        ] process > artic_ncov_wf:artic_medaka     -
[-        ] process > artic_ncov_wf:covarplot        -
[-        ] process > determine_lineage_wf:pangolin  -
[-        ] process > determine_mutations_wf:next... -
[-        ] process > genome_quality_wf:president    -
[-        ] process > genome_quality_wf:seqrs        -
[-        ] process > rki_report_wf:rki_report       -
[-        ] process > align_to_reference             -
[4f/832cc7] process > create_summary_report_wf:ge... [100%] 1 of 1, failed: 1 ✔
[-        ] process > create_summary_report_wf:pl... -
[-        ] process > create_summary_report_wf:su... -
Not enough reads in all samples, please investigate results/1.Read_quality
Could not generate any genomes, please check your reads results/1.Read_quality
[49/7cd4aa] NOTE: Process `get_nanopore_fastq` terminated with an error exit status (255) -- Error is ignored
[b5/1e2c57] NOTE: Process `read_classification_wf:download_database_kraken2` terminated with an error exit status (255) -- Execution is retried (1)
[4f/832cc7] NOTE: Process `create_summary_report_wf:get_variants_classification` terminated with an error exit status (255) -- Error is ignored
slurmstepd: error: *** JOB 17855474 ON r02c22 CANCELLED AT 2023-07-17T13:44:54 DUE TO TIME LIMIT ***

in this case I give the run 30min (which doesn't end).
at least the there are tracking files and it doesn't seems an singularity error.


Error internally processing HTML for testing: Expecting an object with a field named type but instead got: undefined

I got the following error in a new test:
    This test failed because it threw an exception: "Error: Ran into a `Debug.crash` in module `Html.Inert`

    This was caused by the `case` expression between lines 19 and 24.
    One of the branches ended with a crash and the following value got through:

        Err "Expecting an object with a field named `type` at _.children[1].children[0].children[5].children[0].children[0].children[1].children[0].children[1].children[0].children[0].children[1].children[0]._1.node but instead got: undefined"

    The message provided by the code author is:

        Error internally processing HTML for testing - please report this error message as a bug: Expecting an object with a field named `type` at _.children[1].children[0].children[5].children[0].children[0].children[1].children[0].children[1].children[0].children[0].children[1].children[0]._1.node but instead got: undefined"

What info is useful for debugging this?

I am finding an element with findAll [ ... ] >> Query.first ... there are three nodes that match the findAll, but if I do Query.index 1 or 2 instead of first or index 0, then it complains that it doesn't find any matches.
If I use first, then I try to simulate an event on the found node, and get the error in the original post.

Hmm. Seems like some edge case in the decoder, perhaps. Does this view you're testing contain a lazy or keyed view?

no lazy, but it does contain keyed views, though I think the keyed views are all within a node that's below the ones selected here...

Someone else reported this issue on Slack the other day: https://elmlang.slackarchive.io/general/page-46/ts-1496746323110540
A SSCCE would be extremely appreciated here

I'm assuming it is something to do with the exact setup of view that you have

I originally thought this maybe had to do with simulating an event or finding the node to simulate on; but it turns out this error happens for use after that particular event is processed; so the problem seems to be in some HTML that appears after we expand a collapsed section.  That section does include Keyed, so maybe it's related to that.
(Sorry, no time for SSCCE yet)

no lazy, but it does contain keyed views, though I think the keyed views are all within a node that's below the ones selected here...

We actually use elm-sortable-table in that view, which uses lazy.

So this fails because of this structure.
{ ctor: '_Tuple2',
  _0: '8168233',
  _1:
   { type: 'thunk',
     func: { [Function: wrapper] arity: 3, func: [Function] },
     args:
      [ [Object],
        [Function: _evancz$elm_sortable_table$Table$simpleRowAttrs],
        [Object] ],
     thunk: [Function],
     node: undefined } }

This node is created here https://github.com/evancz/elm-sortable-table/blob/master/src/Table.elm#L431.
The easiest solution is to change the native code in this module:
var _eeue56$elm_html_test$Native_HtmlAsJson = (function() {
  function forceThunks(vNode) {
+    if (
+     typeof vNode !== "undefined" && vNode.ctor === "_Tuple2" && !vNode.node
+   ) {
+     vNode._1 = forceThunks(vNode._1);
    }
    if (typeof vNode !== "undefined" && vNode.type === "thunk" && !vNode.node) {
      vNode.node = vNode.thunk.apply(vNode.thunk, vNode.args);
    }
    if (typeof vNode !== "undefined" && typeof vNode.children !== "undefined") {
      vNode.children = vNode.children.map(forceThunks);
    }
    return vNode;
  }

  return {
    toJson: function(html) {
      return forceThunks(html);
    },
    eventDecoder: function(event) {
      return event.decoder;
    },
    taggerFunction: function(tagger) {
      return tagger;
    }
  };
})();

sorry prettier formatted that code.

vNodes for keyed children are tuples?  If that's how it's supposed to be, then I think the suggested code looks good.

Yep, they are meant to be tuples: https://github.com/elm-lang/virtual-dom/blob/master/src/Native/VirtualDom.js#L852
I would prefer we had this represented correctly in elm-html-in-elm: https://github.com/eeue56/elm-html-in-elm/blob/master/src/ElmHtml/InternalTypes.elm#L277
I think it would be better to store the key as well as the evaluated child

@eeue56 I can make a PR, if you want me to?


[Feature request/Bug report?]: A setting to enable pen mode by default on iPad.

Currently, when I open a fresh instance of excalidraw, I first have to tap the screen with a pen in order to even see the button to "enable pen mode".
Normally it's not a problem, but when you open an existing document where the last used tool was a pen, my intuition is to start drawing with the pen immediately BUT my hand that rests on the screen immediately registers as a pen stroke.
A setting that would enable pen mode by default on ipad would make it perfect.
I'm using excalidraw in conjunction with obsidian, so a startup flag perhaps would make sense?
So far I'm LOVING it, thank you for all the great work. I have nothing but praise for you ❤

I wouldn't recommend detecting device type and auto enabling based on that for the simple reason that there are many other devices beyond iPads, and also detecting iPads is not that trivial as one would hope so... the ways to detect continually change with new versions of iPads being released, so such a code would require constant attention.
I am planing to spend some time with pen mode this weekend. My idea is to detect the pen already when you use click the toolbar with the pen. Perhaps that would improve the experience for you.
My own current routine is to touch the screen with the pen when the "Selection tool" is still active and then click the freedraw icon. This avoids the unintended line I sometimes create by placing my palm on the screen.

I am working on this PR (#4943) to resolve this issue.

@zsviczian ad your PR, I'm not against detecting on tool change, but maybe we should do that on top of current canvas detection? But, neither solution will solve the issue @huntedman is facing. The only solution that comes to mind is preserving penMode across sessions.

@zsviczian #4943 is a really clever workaround! It does solve the issue of having to do 3 clicks in order to start drawing!
But this part makes me wonder:

Without penDetected the pen-lock button will not be displayed
Saving penDetected and penMode would mean that we shouldn't move penDetected to DeviceType context after all...

This behaviour seems more what I had in mind. When you open a drawing that was previously in penMode, it's automatically in penMode and the unlock button is also displayed.
On a slightly unrelated note, I noticed you released obsidian-excalidraw-plugin 1.6.20 Congrats 🥳 !
I'm a big fan of your work, and yesterdays update made me wonder, is there a way to set penMode and penDetected on by default in excalidraw? Perhaps by front-matter?
Forgive me, for I don't know how you instantiate excalidraw and what flags are available, but my intended behaviour with the pen would be similar to "zen mode on by default" setting.
(Also let me know if this is discussion is off topic from the core excalidraw.)

My IDEAL solution with the pen would be similar to "zen mode on by default" setting in obsidian-excalidraw-plugin.

This has crossed my mind as well.
But maybe the solution is to save penMode and penDetected with state. That would also be required to enable penMode by default similar to zenMode.
The point is, that DeviceType already holds information if the device is a mobile device, and if it has a touch screen. pen would logically fit this. But penMode is more like zen mode, view mode... which are app states.
I'll do another PR that will keep penDetected in appState, but will save it, it only takes few minutes, since there are not many changes required. Then We can try both and see which feels more natural.

@dwelle #4955 feels more user friendly. The only drawback is penDetected remains in appState. However it also makes sense that it is in penState, since you can expect that next time the user uses the device she/he will still have a pen.
@huntedman, I think #4955 does exactly what you were looking for. I can use this to add an option to Obsidian-Excalidraw to enable penMode by default in the plugin...

Closed via #4955


Serious XSS issue in subcircuit/newCircuit name

serious XSS security vulnerability exists in subcircuit name
If successfully exploited attacker can steal your cookie and make malicious request from victims browser
To Reproduce
Steps to reproduce the behavior:
1.launch simulator
2. Click on new Circuit +
3. Give this subcirccuit a name as {subcktname}
for example a payload would be sbckt
4. Ctrl+S
See the error
5.Now logout
6.launch the created project in preview mode as any other user or as guest/non-authenticated user
7. Again see the alert(1) script is executed
Expected behavior
all the user input must be validated and escaped for the dangerous cross-sitite scripting attack vectors
#note this attack not only affects the user who created the project but also all other who open the project.
Screenshots

Desktop (please complete the following information):

OS:any
Browser[ tested on chrome,should be replicable to other browser like Firefox ]

Additional context
My exploited  project .url https://circuitverse.org/users/5423/projects/15040
open the url and a alert script will only show in your browser I did bnot made it malicious but it can be made .
https://github.com/CircuitVerse/CircuitVerse/issues/248
Are you working on this issue :Yes

There is an existing sanitization mechanism for inputs in the circuit editor. I couldn't figure out how to utilize that existing function to prevent XSS in the circuit names. You can try using that existing function or maybe introduce a completely new sanitation mechanism and replace the parts that use the existing one. I just wanted to share my experience with this issue :)

I am thinking of using some thing like dom_purify

You might check this out as well: https://github.com/rails/rails-html-sanitizer
It is native to Ruby on Rails

okk I will look into this

@satu0king Here, Do we require to allow to users to use ></& in the circuit and project names?
If not then we can directly strip any occurrence of these(or html tags) and the resultant string should be xss-safe.

Yes, except for project/assignment description everything else has to be HTML free.


[Bug]

Describe the bug
Following "Get the tools" manual on https://dev.azure.com connect to feed for universal packages
Installed Azure CLI 2.12.1
Executing
az extension add --name azure-devops

leads to:
ValidationError: An error occurred. Pip failed with status code 1. Use --debug for more information.

using --debug:
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)'),)': /s/files.pythonhosted.org/packages/fa/f5/9e315fe8cb985b0ce052b34bcb767883dc739f46fadb62f05a7e6d6eedbe/msrest-0.6.19-py2.py3-none-any.whl?X-OpenDNS-Session=_5a804d1f0658404e01091220e9ba0a08acdb9270fc52_z5JN3SA9_
  Starting new HTTPS connection (6): files.pythonhosted.org.x.5a804d1f0658404e01091220e9ba0a08acdb.9270fc52.id.opendns.com:443

full log attached
To Reproduce
Azure Cli Version: 2.12.1
Azure-Devops extension version:
azure_devops-0.18.0-py2.py3-none-any.whl (thats what its trying to install
Steps to reproduce the behavior:

no login required
just install latest cli on clean machine and try to install extension
I was able to replicate it on 4 different windows 10.1803 machines

Expected behavior
Getting package installed
Debug logs
Attached
azure-devops.log

Same issue here as well.

I also see this issue, cannot figure out how to resolve or how to fix my environment

fixed by perl certification


Fixed a bug and added a feature to reload config automatically.

Feature: reloading config when:

reload a saved session

update config file

Merged, thank you!

Love this! I use project launch every day, and reloading the launch window after there's a change to .projectlaunch.json is huge!


Discover NVRs

The system should be able to discover and identify NVRs. The format for the return of NVR data would be something like (pulled out of my hat):
{
    "cameras": [
       {
        "ip": "<IP_ADDRESS>",
        "mac_address": "FF:FF:FF:FF:FF:FF",
        "lan_http_port": 80,
        "lan_rtsp_port": 554,
        "jpg_path": "Streaming/Channels/1/picture",
        "h264_path": "h264/ch1/main/av_stream"
    }
],
"nvrs": [
    {
        "ip": "<IP_ADDRESS>",
        "mac_address": "AF:AF:AF:AF:AF:AF",
        "lan_http_port": 80,
        "lan_rtsp_port": 554,
        "channels": [
            {
                "id": 0,
                "jpg_path": "Streaming/Channels/0",
                "h264_path": "h264/ch0"
            },
            {
                "id": 1,
                "jpg_path": "Streaming/Channels/1",
                "h264_path": "h264/ch1"
            }
          ]
        }
     ]
  }

Good.
 I'll be suggesting
generalising DVRs/NVRs/Encoders as I think they're pretty simliar.
Arguably, cameras could be included in there as well as they too have
channels ... then we have:
"/Devices"
Nice work Dan.
M
On 2 September 2015 at 12:43, scandox<EMAIL_ADDRESS>wrote:

The system should be able to discover and identify NVRs. The format for
the return of NVR data would be something like (pulled out of my hat):
{
"cameras": [
{
"ip": "<IP_ADDRESS>",
"mac_address": "FF:FF:FF:FF:FF:FF",
"lan_http_port": 80,
"lan_rtsp_port": 554,
"jpg_path": "Streaming/Channels/1/picture",
"h264_path": "h264/ch1/main/av_stream"
}
],
"nvrs": [
{
"ip": "<IP_ADDRESS>",
"mac_address": "FF:FF:FF:FF:FF:FF",
"lan_http_port": 80,
"lan_rtsp_port": 554,
"channels": [
{
"id": 0,
"jpg_path": "Streaming/Channels/0",
"h264_path": "h264/ch0"
},
{
"id": 1,
"jpg_path": "Streaming/Channels/1",
"h264_path": "h264/ch1"
}
]
}
]
}
—
Reply to this email directly or view it on GitHub
https://github.com/evercam/evercam-discovery-java/issues/30.

--
Marco Herbst
Evercam.io http://www.evercam.io/ - Cameras Unleashed
Mobile: +353 86 196 0451
Skype: marco.a.herbst


A relative URL

Salam,
Ok? Can I send it to CocoaControls?

awesome! Yeah, this is perfect, thanks a lot


Clarified that the 3d models are cloned by default

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Problems, solutions and additional files

It would be nice to have .pdf files of problems, solutions, original result protocols and other complementary files with the results of all competitions.

A standardized format for file names would probably be useful. For example efo22v3kke for physics 2021/22 lõppvoor gümnaasium Estonian problems.


fix(range): fix the wrong range with min or max given

Summary
fixes #4626
This PR fixes the bug where connectRange set the wrong range when min or max was given.
If you look at lines like this, connectRange assumes there is only one value per operator (It's getting the first item from the array). However, in getWidgetSearchParameters, it adds refinements for min and max bound if given. After that, it again adds the bound from uiState.
It's reproduced in controlled mode (by calling setUiState).
Result
It should fixes the reproduction from #4626
The fixed example: https://codesandbox.io/s/confident-pasteur-ocls6?file=/src/app.js

Wait, if the one from uiState is out of the bound, then it should keep things in the bound. I will add a new test and update the PR next week.

Wait, if the one from uiState is out of the bound, then it should keep things in the bound. I will add a new test and update the PR next week.

This is indeed correct, but I'm not sure which one of the two should be taken as the source of truth. In theory there's nothing wrong with an out-of-bounds refinement, but then more of the connector is wrong.

This is indeed correct, but I'm not sure which one of the two should be taken as the source of truth. In theory there's nothing wrong with an out-of-bounds refinement, but then more of the connector is wrong.

This is indeed correct, but I'm not sure which one of the two should be taken as the source of truth. In theory there's nothing wrong with an out-of-bounds refinement, but then more of the connector is wrong.

Hmm I thought the min, max bound given to the widget should be the source of truth. In the latest change https://github.com/algolia/instantsearch.js/pull/4627/commits/404d29d95b22a765bb196dc649093a39d4dd124e, the out-of-bound refinements are capped with the bound.
What do you think?

This is indeed correct, but I'm not sure which one of the two should be taken as the source of truth. In theory there's nothing wrong with an out-of-bounds refinement, but then more of the connector is wrong.

Hmm I thought the min, max bound given to the widget should be the source of truth. In the latest change https://github.com/algolia/instantsearch.js/pull/4627/commits/404d29d95b22a765bb196dc649093a39d4dd124e, the out-of-bound refinements are capped with the bound.
What do you think?

this makes sense I think, although you'll need to change the initial test to make sense

this makes sense I think, although you'll need to change the initial test to make sense

this makes sense I think, although you'll need to change the initial test to make sense

can you tell me what about the initial test needs to change?

this makes sense I think, although you'll need to change the initial test to make sense

can you tell me what about the initial test needs to change?

change is good, but I don't know what the first test is meant to assert

It might be unclear to you.
      const widget = makeWidget({
        attribute: 'price',
        min: 0,
        max: 500,
      });

      const actual = widget.getWidgetSearchParameters!(helper.state, {
        uiState: {
          range: {
            price: '0:400',
          },
        },
      });

      console.log(actual.numericRefinements.price['<=']);

Before this PR, it used to print [400, 500], instead of [400].


Fix crash on rejecting orphans

Updated for rejection bugs.
The code was interchangeably using xyz_character_id or char_id to refer to both eve_character.id and eve_character.character_id, which led to the original bug the previous PR was supposed to fix and then the subsequent bugs that this one fixes. Hey Django, this is why we don't write tools that assign functionality to name mangling when collision is possible.


A few bug fix and a little text strip

Fixed the "can not consider(or whatever) float like an int" bug. Also added strip to the text so that there are no '\n\t   ' etc.

Thanks, @Ehsan1997!


[refactor] build on top of golang.org/x/tools/go/analysis

So far we've implemented our lint rules manually - and a frontend to match.
The analysis package implements numerous checkers that serve as great examples - and ways to run them (and custom ones) via the analysis/multichecker and analysis/singlechecker packages.
Instead of rolling our own, we should attempt to use this interface.

Working on this in chrsm/go-analysis

It looks like we'll need to write a tiny frontend similar to analysis/multichecker to support our yaml-based config format. This shouldn't be too challenging, as all cmd/openlynt does is parse the yaml and run ast.Inspect.

after the refactor we can follow the example at https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/govet.go if we ever want to submit a PR for integration with golangci-lint

:+1: it'd be pretty awesome to get ours in there!


[PrintAsObjC] Use of imported generics require the full definition.

I'm not sure why this didn't occur to me in 8282160d: of course if you see a generic type with arguments, you need to see the @interface for that type in order to supply the arguments. Maybe I was thinking the generated interface would automatically import anything the module itself imports, but that hasn't ever been true.
rdar://problem/28738008

@swift-ci Please smoke test Linux platform

@swift-ci Please test macOS platform

@DougGregor, mind reviewing this to make sure I'm not making a terrible mistake?

Yeah, this looks good.


Passing arguments into pad_op by reference

There appears to be an ABI mismatch between gcc7 and clang that, in case of functor::Pad<Eigen::half, 3>, results in the pad value being passed incorrectly (we see the correct value of 0 in pad_op.cc, which is compiled with gcc, and a random incorrect value in pad_op.h, which is compiled with clang).
This PR switches functor::Pad to taking all arguments by reference, which works around the problem.
It also adds float16 to tested data types for pad_op_test (the problem was not noticed for a long time because pad_op_test was not testing float16).

@ekuznetsov139 , can we go ahead and merge this PR?


Deploying in private IP space

Been trying out MUP and it's worked great so far, using a machine that has access to the internet. I'm now trying to get it to work on a machine that is in a private IP space.
Obviously when doing mup setup I need an internet connection to get node and such installed. But when just doing a mup deploy to a private space, it gets stuck on the last step: Invoking deployment process.
I'm assuming this step is backing up the old app, copying over the new bundle, and running npm setup. However, does any of this require an internet connection? Or is it module/package dependent? I've run mup deploy to the machine while in public space. Moved it to the private space, and tried to update it by running mup deploy again with no luck.
Anyone have ideas or suggestions!

Hi,
I have the same problem, I can not update my server with mup unless get it
internet access that is a security issue in my client organization. Is
there any way to update meteor apps with mup without internet connection?
spetially in deployment process.
On Wed, Aug 19, 2015 at 6:20 PM, loken<EMAIL_ADDRESS>wrote:

Been trying out MUP and it's worked great so far, using a machine that has
access to the internet. I'm now trying to get it to work on a machine that
is in a private IP space.
Obviously when doing mup setup I need an internet connection to get node
and such installed. But when just doing a mup deploy to a private space,
it gets stuck on the last step: Invoking deployment process.
I'm assuming this step is backing up the old app, copying over the new
bundle, and running npm setup. However, does any of this require an
internet connection? Or is it module/package dependent? I've run mup
deploy to the machine while in public space. Moved it to the private
space, and tried to update it by running mup deploy again with no luck.
Anyone have ideas or suggestions!
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/608.

--
Sincerely yours
Babak Niknia
Next Generation Solutions Co.
Chief R&D Manager
www.NEGSO.com

+1


subscription cancellation specs

Changes Unknown when pulling 5218fe1e945d2243ed934a38a9ef85b3c5750c82 on subscription-delete-specs into ** on feature.ak-champaign-sync**.

@eyko I'm merging this


Refactor block type restriction underscore output to nil

This patch replaces underscore output types in block restrictions with nil (empty) for methods where the result of the yielded block is irrelevant and unused. Underscore should be used where the result type is not specified but the value is actually used.
See #10931
This had previously been a part of #10929

I wonder if it would break things to explicit the Nil return type when that's the intention (e.g., each)

Nil and empty should be semantically equivalent here. We could use Nil, it's just more characters.

right, but given that the semantics are somewhat not entirely there, maybe it makes sense to be explicit for once

Let's discuss the intended semantics in #10931
I just opened this PR to not loose the these parts of #10929. It should have been a draft from the beginning, to wait for a definitive decision in #10931.


Validation Failed - invalid annotations

I did this commit: https://github.com/timja-org/codingstyle/pull/6/commits/f7793800117788a91cf81402c605faad304ffb43
and in the server log I have:
We probably need to log the annotation as well?
org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/timja-org/codingstyle/check-runs {"message":"Validation Failed","errors":[{"resource":"CheckRun","code":"invalid","field":"annotations"}],"documentation_url":"https://docs.github.com/rest/reference/checks#create-a-check-run"}
	at org.kohsuke.github.GitHubClient.interpretApiError(GitHubClient.java:493)
	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:421)
	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:364)
	at org.kohsuke.github.Requester.fetch(Requester.java:74)
	at org.kohsuke.github.GHCheckRunBuilder.create(GHCheckRunBuilder.java:137)
	at io.jenkins.plugins.checks.github.GitHubChecksPublisher.publish(GitHubChecksPublisher.java:61)
	at io.jenkins.plugins.analysis.core.steps.WarningChecksPublisher.publishChecks(WarningChecksPublisher.java:55)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:725)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
	at java.util.concurrent.FutureTask.run(FutureTask.java)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/timja-org/codingstyle/check-runs
	at org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.getInputStream(ObsoleteUrlFactory.java:488)
	at org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$DelegatingHttpsURLConnection.getInputStream(ObsoleteUrlFactory.java:1201)
	at org.kohsuke.github.GitHubHttpUrlConnectionClient$HttpURLConnectionResponseInfo.bodyStream(GitHubHttpUrlConnectionClient.java:197)
	at org.kohsuke.github.GitHubResponse$ResponseInfo.getBodyAsString(GitHubResponse.java:321)
	at org.kohsuke.github.GitHubResponse.parseBody(GitHubResponse.java:86)
	at org.kohsuke.github.Requester.lambda$fetch$1(Requester.java:74)
	at org.kohsuke.github.GitHubClient.createResponse(GitHubClient.java:462)
	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:413)
	... 17 more

I added logging and this is the failure:
WARNING: Failed Publishing GitHub checks: ChecksDetails{name='SpotBugs', status=COMPLETED, detailsURL='http://localhost:8085/jenkins/job/timja-org/job/codingstyle/job/PR-6/11/', startedAt=null, conclusion=FAILURE, completedAt=null, output=ChecksOutput{title='2 new issues.', summary='## 2 issues in total:
- ### 2 new issues
- ### 0 outstanding issues
- ### 2 delta issues
- ### 0 fixed issues', text='## Total Issue Statistics:
* Error: 0
* High: 1
* Normal: 0
* Low: 1
## New Issue Statistics:
* Error: 0
* High: 1
* Normal: 0
* Low: 1
## Delta Issue Statistics:
* Error: 0
* High: 1
* Normal: 0
* Low: 1
', annotations=[ChecksAnnotation{path='src/main/java/edu/hm/hafner/util/PathUtil.java', startLine=127, endLine=130, annotationLevel=WARNING, message='HIGH:
base must be non-null but is marked as nullable', startColumn=0, endColumn=0, title='NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE', rawDetails='
 This parameter is always used in a way that requires it to be non-null, but the parameter is explicitly annotated as being Nullable. Either the use of the parameter or the annotation is wrong.
'}, ChecksAnnotation{path='src/main/java/edu/hm/hafner/util/StringContainsUtils.java', startLine=60, endLine=60, annotationLevel=WARNING, message='LOW:
Comparison of String parameter using == or != in edu.hm.hafner.util.StringContainsUtils.issuesHere(float, float, float, String, String, float, float, float, float, float, float, float)', startColumn=0, endColumn=0, title='ES_COMPARING_PARAMETER_STRING_WITH_EQ', rawDetails='
This code compares a java.lang.String parameter for reference equality using the == or != operators. Requiring callers to pass only String constants or interned strings to a method is unnecessarily fragile, and rarely leads to measurable performance gains. Consider using the equals(Object) method instead.
'}], images=[]}, actions=[]}

it seems the problem is startLine=127, endLine=130 and startColumn=0, endColumn=0.
The start line is different from end line while start column and end column are the provided (although as 0).
We may need more strong validation: when start line and end line are not the same, remove the column field

Instead of being careful in consumers when constructing annotations, maybe we should also check this issue and when it happens, arise an exception early before sending it to GitHub?

possibly but github could also change that, I think we should have better error reporting when it happens.

Logged the checks parameters when exceptions happen


Changing screen's transform doesn't update the wallpaper

https://github.com/user-attachments/assets/fd3fedf7-5469-4723-a248-48aff9ad254c
When the screen is rotated, the wallpaper does not rotate. If the command is executed again, the wallpaper rotates as expected

Will this be fixed/support provided?

MRs welcome

MRs welcome

ok if i find the time then sure

MRs welcome

Will start working on this today hopefully.

@soufhehe @vaxerski fixed in #224

@vaxerski can be closed now unless you need this guys input on the changes

Thanks ! It works :)

WOOHOO my first real contribution to an open source project that isn't mine


Discrete Hill python notebook

I can't seem to replicate your results in the game notebook. Is your ipython notebook output for that outdated? or is there something subtle going on? I simply ran your game python notebook, but it doesn't seem to learn at all. I haven't seriously studied your code, so some help is appreciated in debugging

Hi David,
I am sorry I commit that example by mistake, it is not supported :( I did it long time ago and I do not remember what it was doing. Sorry I could not be more helpful.
Szymon


[Relay][Dyn] Dynamic full operator

The dynamic version of the full operator
@mbrookhart @zhiics Let me know if you have any suggestions

Thanks @electriclilies @mbrookhart


Feature/build profile

Changelog: (Fix): When using Docker: only pass a build profile if it has been explicitly specified
By default the ´´´default´´´ profile has been used if no build profile was given while creating the ´´´ConanMultiPackager´´´ for Docker. This causes Conan to always be run with a build profile, which is different to how it is run when not using Docker. Conan also behaves differently for some use cases when a build profile is given.
This pull request also strips down the build profile text passed to the Docker container via environment variables to a bare minimum. The reason for this is explained in the commit message (this change can also be reverted if I missed something)
Issue #595

[x ] Refer to the issue that supports this Pull Request.
[x ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x ] I've read the Contributing guide.
[ x] I've followed the PEP8 style guides for Python code.

Codecov Report

Merging #604 (34c149c) into develop (28ae68d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #604   +/-   ##
========================================
  Coverage    78.60%   78.60%
========================================
  Files           43       43
  Lines         5290     5291    +1
========================================
+ Hits          4158     4159    +1
  Misses        1132     1132

Impacted Files
Coverage Δ

cpt/packager.py
87.16% <100.00%> (+0.05%)
:arrow_up:

cpt/profiles.py
91.37% <100.00%> (-0.15%)
:arrow_down:

cpt/ci_manager.py
92.46% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


formatting issue

The code display below does not show the label color.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60570327-bcb7-45db-f38c-6cf446989bb0
Version Independent ID: d7d5f481-5725-e801-4e48-038a11da5d5a
Content: CMFCRibbonButton Class
Content Source: docs/mfc/reference/cmfcribbonbutton-class.md
Product: visual-cpp
Technology: cpp-mfc
GitHub Login: @mikeblome
Microsoft Alias: mblome

@songxia233
Thanks for reporting this. The fix should appear tomorrow.
In the future, you are welcome to make trivial fixes like this one yourself. To make it a little easier to follow, we also made a video demo of fixing a typo and submitting a pull request. We review all PRs and usually get them approved within a day or two, with occasional exceptions.


how to make a share link?

when I click the shared link icon, I have met the same error as #112 , after made the js change according to the issue, I have encounter another error:

Hi @HaoLiuHust, Which remote are you using?

Hi @HaoLiuHust, Which remote are you using?

ceph


feat: add Google Analytics

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[ ] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[ ] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.
[ ] I have added necessary documentation (if appropriate)

Description
Add Google Analytics
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

This should be fine!! @ORKO06 Have u tested if the stream is working well?


Connect-sposervice is slow

When running connect-sposervice with credentials stored in a variable its taking almost 2 minutes to connect.

Hello @roggyuk
How are you?
Even though, here, we are limited to documentation issues and fixes, I tested and connected in a couple of seconds, the best in your scenario would be to update to the latest version of the module and/or open a support ticket from your tenant.
Hope this information helps you!
@yogkumgit


feat: expose port 8200 for vault access

Closing in preferring of leveraging vault CLI for access in secure manner


Support for building/pushing images with multiple tags

Orb version
0.1.3
What happened
The orb commands don't support multiple tags. For example, to use the azure-acr/build-and-push-image command to create an image with 3 tags, you need to use three different steps.
Expected behaviour
It should be possible to build and push an image with multiple tags with one command.
The docker orb used by this ACR orb has since been updated to support multiple tags (see https://github.com/CircleCI-Public/docker-orb/issues/36), so this should be a case of simply bumping the version of the docker orb.
I've raised a PR to do this: https://github.com/CircleCI-Public/azure-acr-orb/pull/8

@jonadaly Closing this issue as you have since resolved it with https://github.com/CircleCI-Public/azure-acr-orb/pull/8 🙏


chore: automated PR to update VHDVersion for 202311.07.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202311.07.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.007%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2243

Relevant Lines:
2839

💛  - Coveralls


feat: update the recommended policy

Description of changes:
AWS has deprecated the old policy in favor of the V2. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/auth-and-access-control-cw.html#managed-policies-cloudwatch-CloudWatchFullAccessV2 for more details.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test


Add debian bookworm packages

Please add the following dependency to the rosdep database.
Package name:
TODO
Package Upstream Source:
TODO link to source repository
Purpose of using this:
TODO Replace. This dependency is being used for this reason. This is why I think it's valuable to be added to the rosdep database.
Distro packaging links:
Links to Distribution Packages

Debian: https://packages.debian.org/

REQUIRED

Ubuntu: https://packages.ubuntu.com/

REQUIRED

Fedora: https://packages.fedoraproject.org/

IF AVAILABLE

Arch: https://www.archlinux.org/packages/

IF AVAILABLE

Gentoo: https://packages.gentoo.org/

IF AVAILABLE

macOS: https://formulae.brew.sh/

IF AVAILABLE

Alpine: https://pkgs.alpinelinux.org/packages

IF AVAILABLE

NixOS/nixpkgs: https://search.nixos.org/packages

OPTIONAL

openSUSE: https://software.opensuse.org/package/

IF AVAILABLE

Please Add This Package to be indexed in the rosdistro.
ROSDISTRO NAME
The source is here:
http://sourcecode_url
Checks

[ ] All packages have a declared license in the package.xml
[ ] This repository has a LICENSE file
[ ] This package is expected to build on the submitted rosdistro

@mosfet80 can you please fill out the pull request template with some basic details and intent. Since the changes are all updates to existing keys it's not an impossible review but it is made more challenging by the lack of information in the PR description.


Question about tokenizing table values

Hi,
I'm currently testing my implementation of TapasTokenizer (in the Transformers library, each model has a corresponding tokenizer that can be used to prepare data for the model). When testing on a batch of SQA data (from the dev set), I spotted a misalignment, namely there's a column with values such as 1.0, 2.0, ... In the original implementation, 1.0 is tokenized into ["1", "."].
In my implementation, this is tokenized into ["1", ".", "0"]. Any reason why this is the case? Here's the table:

And here are the tokens + ids of the original implementation (left) and those of my implementation (right):
[CLS] 101 [CLS] 101
what 2054 what 2054
tracks 3162 tracks 3162
appear 3711 appear 3711
on 2006 on 2006
the 1996 the 1996
album 2201 album 2201
life 2166 life 2166
goes 3632 goes 3632
on 2006 on 2006
( 1006 ( 1006
tr 19817 tr 19817
##ae 6679 ##ae 6679
album 2201 album 2201
) 1007 ) 1007
? 1029 ? 1029
[SEP] 102 [SEP] 102
[EMPTY] 1 [EMPTY] 1
title 2516 title 2516
producers 6443 producers 6443
guest 4113 guest 4113
performers 9567 performers 9567
length 3091 length 3091
1 1015 1 1015
. 1012 . 1012
throw 5466 0 1014 ===> misalignment starts here
away 2185 throw 5466
##s 2015 away 2185
maj 16686 ##s 2015
& 1004 maj 16686
so 2061 & 1004
##sa 3736 so 2061
gorilla 23526 ##sa 3736
zoe 11199 gorilla 23526
& 1004 zoe 11199
yun 22854 & 1004
##g 2290 yun 22854
jo 8183 ##g 2290
##c 2278 jo 8183
3 1017 ##c 2278
: 1024 3 1017
11 2340 : 1024
2 1016 11 2340
. 1012 2 1016
i 1045 . 1012
' 1005 0 1014
m 1049 i 1045
a 1037 ' 1005
gangs 18542 m 1049
##ta 2696 a 1037
drew 3881 gangs 18542
[EMPTY] 1 ##ta 2696
4 1018 drew 3881
: 1024 [EMPTY] 1
16 2385 4 1018
3 1017 : 1024
. 1012 16 2385
life 2166 3 1017
(and so on)

FYI: I'm reading in the table as a Pandas dataframe before tokenizing.

There are certainly many ways to do tokenization and we wanted to be consistent with BERT.
Therefore we are relying on the bert tokenization code:
from official.nlp.bert import tokenization

self._basic_tokenizer = tokenization.BasicTokenizer(do_lower_case=True)
self._wp_tokenizer = tokenization.FullTokenizer(vocab_file=vocab_file, do_lower_case=True)

  def tokenize(self, text):
    if text_utils.format_text(text) == constants.EMPTY_TEXT:
      return [Token(_EMPTY, _EMPTY)]
    tokens = []
    for token in self._basic_tokenizer.tokenize(text):
      for piece in self._wp_tokenizer.tokenize(token):
        tokens.append(Token(token, piece))
    return tokens

I understand the Bert tokenizer purposefully doesn't split on punctuation within a word.
So, I think, it would split 1.0 into ["1.0"] but 1. into ["1", "."].
I think this is WAI from our side.
So, I assume your tokenizer is implemented to split on every punctuation mark and that's what the discrepancy is coming from?


Register

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/53760
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 78bfb9d3562ef42d0e5ee602a6ee5ad93178e963
git push origin v0.1.0


Bug: when you use on mobile , you can't see the login register button if you haven't  logged in.

What happened?
a bug affecting mobile users where the login and register buttons are not visible to users who are not already logged in. This bug impacts user accessibility and functionality of the website or application on mobile devices, potentially preventing new users from registering or existing users from logging in. The task would involve diagnosing and fixing the UI/UX issues to ensure that these essential buttons are visible and accessible on all mobile devices.
Add screenshots
With pr , on development
What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Hi @Adeesh-bode the bug has already been raised so this is duplicate.


Add support to openshift provisioning module to create base entities to support gatling benchmark and dataset scripts

Description
Add support to openshift provisioning module to create base entities to support gatling benchmark and dataset scripts

Similar to minikube module we need to have support to create the needed service account enabled client, test-realm and users to start a benchmark against the Openshift cluster based Keycloak instance.
Akin to the above point, we also need to be able to deploy dataset module to the Openshift cluster based Keycloak instance and create needed datasets for various entities.

Discussion
No response
Motivation
No response
Details
The question I have for this particular feature request is along the lines of implementation for gatlinguser task from minikube/Taskfile.yaml
Do we want to create these tasks under the common/Taskfile.yml ? That way we can simply modify the gatlinguser to pick up the KC_HOSTNAME_SUFFIX from the .env file to be under a conditional if block to only run the varied version of the below bash command when the KC_HOSTNAME_SUFFIX variable exists in the context.
Suggested Change:
- >
  bash -c '
  if [ "{{.KC_HOSTNAME_SUFFIX}}" != "" ];
    then ../keycloak-cli/keycloak/bin/kcadm.sh config credentials --server https://keycloak.{{.KC_HOSTNAME_SUFFIX}}/ --realm master --user admin --password admin;
    else ../keycloak-cli/keycloak/bin/kcadm.sh config credentials --server https://keycloak.{{.IP}}.nip.io/ --realm master --user admin --password admin;
  fi'

For the dataset module, I believe there would be no changes needed, but would need some testing to make sure we don't hit any runtime issues.

+1 for moving over the dataset tasks to the common taskfile.
I suppose we might need the Keycloak URL in several places soon, so you might want to add an environment variable that carries the whole URL of Keycloak to avoid duplicating the logic in several places. If this involves too much refactoring, feel free to push forward the refactoring.


feat(trace.py): toggle Epsagon in runtime

:tada: This PR is included in version 1.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add table for compability support / hot reloading / what we support

[kind/Documentation]

What did you find missing in the documentation?
We should have a table that shows what versions of OpenShift we support as well as what languages support hot reloading.
For example, if the user has Python 2.7, does it work with the latest image?
If they use 3.0, do you use the latest, what image do you use?
What is the relevance of it?
Needed for new users.

/assign @boczkowska

seems like a duplicate of https://github.com/openshift/odo/issues/2093

closing


organizeImports does not merge value and type imports

🔍 Search Terms
organizeImports type
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
Merge value and type imports into one import.
📃 Motivating Example
If I have the following code
import { CascadeFunction } from "@rcompat/async/cascade";
import cascade from "@rcompat/async/cascade";

And I run organizeImports, then it will be merged into
import cascade, { CascadeFunction } from "@rcompat/async/cascade";

However, if I have
import type { CascadeFunction } from "@rcompat/async/cascade";
import cascade from "@rcompat/async/cascade";

Running organizeImports will do nothing, although I would expect it to merge the imports into
import cascade, { type CascadeFunction } from "@rcompat/async/cascade";

💻 Use Cases

What do you want to use this for?
Keeping imports clean.
What shortcomings exist with current approaches?
Imports may be doubled, and I might not notice it despite running organizeImports.
What workarounds are you using in the meantime?
Merge manually if I notice it.

Note that these merge when they're fully equivalent, e.g.
import { type CascadeFunction } from "@rcompat/async/cascade";
import cascade from "@rcompat/async/cascade";

As @RyanCavanaugh points out, they merge when fully equivalent. I believe this suggestion should be rejected, because it would introduce lossy behavior.
Imagine in that example, starting with:
import type { CascadeFunction } from "@rcompat/async/cascade";

In that case, no runtime import is generated. But then say you add a single runtime import (perhaps temporarily autoimported during a refactor), and this suggestion were implemented:
import cascade, { type CascadeFunction } from "@rcompat/async/cascade";

Now, on second thought, remove that new import. The result still contains an empty runtime import, instead of the original intentional type import:
import { type CascadeFunction } from "@rcompat/async/cascade";

Note that the above is not equivalent, and couldn't be automatically converted back to an import type, because sometimes you want a runtime import (for impure modules), and sometimes you don't, so it needs to preserve the import as written.

@rwe thank you for the explanation. While this is a fair enough reason to not accept this suggestion, it was not at all clear to me that
import type { a } from "b"; and
import { type a } from "b";
are not semantically equivalent. The way I read it, and the way I assume most people would read it, is that having type outside of braces is equivalent to writing type in front of the individual imports inside the braces, in case it's all type imports. I.e., that the former allows only for type imports, while the latter one allows combining value and type import, and as such, in case there are no value imports inside the braces, is equivalent to the former.


Handle single manager reload by having workers reconnect

Related to moby #33346
In a cluster with one manager if that manager node is rebooted or daemon is restarted the manager node gets isolated from the gossip cluster. This is because in the single manager case its the one bootstrapping the gossip when other worker nodes connect to it. When that node restarts the libnetwork agent has no other node info to bootstrap the gossip.
Change in this PR is to have the workers try reconnecting to the bootstrapping manager periodically. This uses the already available reconnect logic which was originally added for the worker node, ie: if a worker node is isolated in the gossip cluster because of lets say network congestion when it thaws it will connect to the previously connected nodes to rebuild its gossip state. Normally this won't kick in when a node intentionally leaves the cluster which will be case in this scenario. This change is to treat it similar to gossip disconnect scenario so that the worker nodes can retry.
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

Discussed yesterday with @sanimej and we concluded that at the moment this logic is the safest approach.
At the moment the delegate does not distinguish if a node is leaving explicitly as a result of a node leave or it just crashed and became unresponsive. For this reason the behavior now for the managers would be to retry them no matter what for 24h. Without this logic it is possible that a rapid reboot of the 3 managers, will let them create a new gossip cluster by themselves completely isolated by the rest of the workers.
@thaJeztah just FYI as a follow up of our previous discussion. This means that after this change you will see that logs for 24h (every 1s for the manager IPs)
LGTM, would be ideal to handle the explicit leave with no retry but this change a part from some log spam won't affect functionality

Unrelated to this PR. But I think retry every second is a bit too aggressive. That can be changed and also rate-limit the log message to one in every few mins or so. Will make that change in a separate PR.

LGTM


Telemetry: New feature parameters for BDI and BGE

Adding new integer feature parameters Data_CountBDIRowsLast30 and Data_CountBGERowsLast30
Critical Changes
Changes
Telemetry Enhancements
NPSP Feature Telemetry collects feature and usage metrics when customers use our products. We use this information to understand the level of usage and adoption of various NPSP features. No personally identifiable information is collected through NPSP Feature Telemetry. We've added the following to NPSP Feature Telemetry:

Count of Batch Gift Entry batches within the last 30 days.
Count of NPSP Data Import records created within the last 30 days.

Issues Closed
New Metadata
Telemetry Enhancements
FeatureParameterInteger:

Data_CountBDIRowsLast30
Data_CountBGERowsLast30

Deleted Metadata

**lurch: attach W-033417

**lurch: attach W-033189

Tracking W-033417

**lurch: attach W-033189

Tracking W-033189


p2p remove time.Sleep from tests

Motivation
fix flacky tests in p2p addrBook
Changes
remove time.Sleep from test
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

there are also a lot of them in bookcheck_test.go

bors try

bors try

bors merge

bors merge


Feature/istio proxy add additional volumes

Please provide a description of this PR:
We can use accessLogFile to specify the file address for the proxy access log, including istio-proxy sidecar or other gateways.
But the problem is the istio-proxy container is setting readOnlyRootFilesystem: true.
And sometimes, the user want to set the time to CST format, the have to mount the timezone file in the running host.
So this PR modify the values_types.proto and the charts, provide the ability to mount the volumes to the istio-proxy sidecar and gateway.
For Example:
  accessLogFile: /accesslog/access.log
  values:
    global:
      proxy:
        volumes:
        - name: istio-accesslog
          emptyDir: {}
        - name: timezone
          hostPath:
            path: "/usr/share/zoneinfo/Asia/Shanghai"
        volumeMounts:
        - name: istio-accesslog
          mountPath: /accesslog
        - name: timezone
          mountPath: "/etc/localtime"

Please check any characteristics that apply to this pull request.

[] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

donot we have [sidecar.istio.io/userVolume] and sidecar.istio.io/userVolumeMount

These are annotations setting in the pod, if i use these annotations, that means i have to modify every deployment to mount a volume to the istio-proxy sidecar container.
With this pr, I can make it normalized to every istio-proxy container, including sidecar container, and gateway container.
Because accessLogFile  is effective for all the gateways and sidecars，if i change the accessLogFile  to write the access log to the normal file without mounting a volume, the gateway will failed to start because of readOnlyRootFilesystem: true

For accesslog, if you really want to dump it, you should use OTel provider.
In that case, I'm -1 for this now.

For accesslog, if you really want to dump it, you should use OTel provider. In that case, I'm -1 for this now.

I think make it optional for the user maybe more user-friendly.

there're few options:

fork the chart
use custom injection template
support sidecar.istio.io/userVolume in gateway-injection-template

Another way forward would be to support a more opinionated timezone property, rather than exposing generic and arbitrary mounts, and letting templating build the timezone mount based on the desired timezone.
Either way, I also am against adding arbitrary custom mounts to the chart, just to support custom local TZs.
Supporting custom local TZs is a reasonable feature by itself though.

For accesslog, if you really want to dump it, you should use OTel provider. In that case, I'm -1 for this now.

Why ?
Using a file involves a os.Write - possibly to an SSD local disk. Using OTel involves protobuf marshalling and TCP.
In case of network errors or overload - the local file can retry sending for days. With OTel sending to a remote
machine - there is a memory limit on how much can be buffered and retried.
There are good use cases for OTel for logging - but there are very good cases to write to a file and let otel
collector read the file and send it.

I generally agree that setting TZ should be a feature by itself, not hacked by mounting volumes.
But at the same time, we do have options to mount volumes in istiod, and I don't see anything unreasonable
for the mesh owner to mount volumes in the sidecar as well, and logs are a pretty strong use case IMO.
We have a lot of complex code around certificate mounting as well.
I am not against a clean mechanism to allow volumes and mounts for sidecar - and eventually deprecating
all the add-hoc volume mounting.

One more point - the use of annotations to mount volumes and do other things is very important and useful in many use cases, and it may work here as well.
But we may have a strong use case to allow the mesh admin to control the volumes ( and other things ) and perhaps
disable the use of annotations. They can do this via validation webhooks or OPA. Just because we have ability to do
something and there are use cases for it - doesn't mean it should be allowed in security-oriented prod environments.
In terms of alternative solutions: one idea which may be more useful is to just use a separate webhooks to inject volumes.
It doesn't have to be Istio specific either - it seems to be a general problem, both the access log and timezones file
could be injected in all containers, not only sidecars. There are many other use cases for that - like injecting certs or bootstrap files into proxyless applications, etc. Not everything has to go in a single overcomplex injection template.

For accesslog, if you really want to dump it, you should use OTel provider. In that case, I'm -1 for this now.

Why ?
Using a file involves a os.Write - possibly to an SSD local disk. Using OTel involves protobuf marshalling and TCP. In case of network errors or overload - the local file can retry sending for days. With OTel sending to a remote machine - there is a memory limit on how much can be buffered and retried.
There are good use cases for OTel for logging - but there are very good cases to write to a file and let otel collector read the file and send it.

I agree with you point, on the other hand, fluentd/OTel-collect filelog receiver is enough for most use cases.

For timezone, there's a discussion on upstream https://github.com/envoyproxy/envoy/issues/23260.

On Fri, Mar 8, 2024 at 7:00 PM zirain @.***> wrote:

For accesslog, if you really want to dump it, you should use OTel
provider. In that case, I'm -1 for this now.
Why ?
Using a file involves a os.Write - possibly to an SSD local disk. Using
OTel involves protobuf marshalling and TCP. In case of network errors or
overload - the local file can retry sending for days. With OTel sending to
a remote machine - there is a memory limit on how much can be buffered and
retried.
There are good use cases for OTel for logging - but there are very good
cases to write to a file and let otel collector read the file and send it.
I agree with you point, on the other hand, fluentd/OTel-collect filelog
receiver is enough for most use cases.

Agree, sending over OTLP is enough for most use cases. Just like writing to
stderr - which is what we are doing now.
Yet we do support configuring a different file for the logs - and it seems
reasonable for the file to be on a volume,
and 'enough for most use cases' does not mean 'best for all use cases'.
Istio is pretty critical component and used in production systems where
different tradeoffs may be needed, and
the current default (stderr combined with a k8s node log collector) is very
close to what this PR is proposing, which
is just adjusting the volume used from the default file used for stderr.
In any case - I am still agreeing that we should probably not merge this PR
if we can find an istio-neutral
alternative. This is not an Istio specific problem - both timezone and log
volume customization apply to
the application too ( they generate logs and use TZ ) - and it should be
handled consistently for all Pods and containers
I don't think Istio should continue to diverge and have separate, unique
behavior/features.
Message ID: @.***>

I am curious about the config meshConfig.accessLogFile.If I change the accessLogFile to the normal file, not stdout or  stderr, the ingressgateway and egressgateway and istio sidecar can not start because of readOnlyRootFilesystem is setting true by default.
Since offering the accessLogFile option for the user to change the log file, why not provide the capability for the user to mount some additionl voluem avoid readOnlyRootFilesystem?

accessLogFile being a file and not just a bool is primarily for VMs (IMO)
On Sun, Mar 10, 2024 at 8:40 PM wuzhuoquan @.***> wrote:

I am curious about the config meshConfig.accessLogFile.If I change the
accessLogFile to the normal file, not stdout or stderr, the ingressgateway
and egressgateway and istio sidecar can not start because of
readOnlyRootFilesystem is setting true by default.
Since offering the accessLogFile option for the user to change the log
file, why not provide the capability for the user to mount some additionl
voluem avoid readOnlyRootFilesystem?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/49782#issuecomment-1987581488, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMW3IPKMBM2Z3IKI4LYXURRTAVCNFSM6AAAAABEKSY32SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGU4DCNBYHA
.
You are receiving this because your review was requested.Message ID:
@.***>

I generally agree that setting TZ should be a feature by itself, not hacked by mounting volumes.
But at the same time, we do have options to mount volumes in istiod, and I don't see anything unreasonable for the mesh owner to mount volumes in the sidecar as well, and logs are a pretty strong use case IMO. We have a lot of complex code around certificate mounting as well.
I am not against a clean mechanism to allow volumes and mounts for sidecar - and eventually deprecating all the add-hoc volume mounting.

+1 - in our charts I would be OK with either a fully generic and overridable set of volume mounts which we used for everything OR a fixed set of non-overridable or extendable volume mounts.
I just absolutely do not want both at the same time :D


#![forbid(rustdoc::broken_intra_doc_links)]

Safer this way.

This should probably wait for https://github.com/bevyengine/bevy/pull/10011 and then use workspace lints.

On board with this, but swap it to a warn and do it at the workspace level like WrongShoe said :)

swap it to a warn

It is warn by default. So when I run cargo doc, it just prints a warning which is too easy to overlook.

CI will already fail on doc warnings, no need to forbid it

Let's leave it as is then.