Create VPNs from 6dg <-> MP

User Story
The LAA are migrating the CCMS EBS component of EBS directly from 3rd party hosting with 6dg to the Modernisation Platform.
The following VPNs are required:

6dg Range
6dg Env
MP VPC

<IP_ADDRESS>/16
dev
laa-development

<IP_ADDRESS>/16
uat
laa-test

<IP_ADDRESS>/16
stage
laa-preproduction

<IP_ADDRESS>/16
prod
laa-prodduction

Configuration of these should mirror the existing VPN configuration from 6dg to LAA LZ here - https://github.com/ministryofjustice/laa-ccms-shared/blob/master/shared-infrastructure/terraform-all-envs/vpn.tf
These VPNs are temporary for migration purposes only, as such should be created to our TGW rather than the PTTP TGW
User Type(s)

Value

Questions / Assumptions / Hypothesis

Definition of done

[ ] readme has been updated
[ ] user docs have been updated
[ ] another team member has reviewed
[ ] tests are green
[ ] UR test OR added to continual research plan

Reference
How to write good user stories

https://github.com/ministryofjustice/modernisation-platform/pull/2505

Initial code created, awaiting further details from 6dg

Closing this as an alternative approach for traffic between MP and 6DG is being explored. The VPNs have been created on our side.


posix: implement fattach() and fdetach()

This is part of the See https://github.com/zephyrproject-rtos/zephyr/issues/51211 (RFC https://github.com/zephyrproject-rtos/zephyr/issues/51211).
fattach() and fdetach() are required as part of _XOPEN_STREAMS Option Group.
For more information, please refer to https://pubs.opengroup.org/onlinepubs/9699919799/functions/fattach.html
Fixes #66973
Fixes #66974

I add the fact that they are implement but will fail with ENOSYS because they are more likely a placeholder.


downloaded audio but not video?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.11.18. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.11.18

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

I'm a new user, and even though i checked the --help, the bug is probably me. :)
I tried to download a video from Utube by entering (in a Windows cmd window) after downloading the youtube-dl.exe from your website today:
C:>youtube-dl http://www.youtube.com/watch?v=eJRKiweYxgM
I ended up with a file:
thai life-eJRKiweYxgM.mp4
which only has the soundtrack, when I play it with VLC, but no video.
I'm attaching a zip of it to this ticket.
thai life-eJRKiweYxgM.zip
I'd be very grateful for any assistance.
Alex Bronstein
<EMAIL_ADDRESS>
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.11.18
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

here is the verbose log:
C:\p\tools>youtube-dl --version
2016.11.18
C:\p\tools>youtube -v http://www.youtube.com/watch?v=eJRKiweYxgM
'youtube' is not recognized as an internal or external command,
operable program or batch file.
C:\p\tools>youtube-dl -v http://www.youtube.com/watch?v=eJRKiweYxgM
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.youtube.com/watch?v=eJRKiweYxgM']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.11.18
[debug] Python version 3.4.4 - Windows-XP-5.1.2600-SP3
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] eJRKiweYxgM: Downloading webpage
[youtube] eJRKiweYxgM: Downloading video info webpage
[youtube] eJRKiweYxgM: Extracting video information
WARNING: unable to extract uploader nickname
[youtube] eJRKiweYxgM: Downloading MPD manifest
[debug] Invoking downloader on 'https://r5---sn-gphvo-ua8e.googlevideo.com/video
playback?ratebypass=yes&itag=18&id=o-ACBMF8_RM-R-N108VL2n1JpU-4WVly_2tC4ujgcZT04
v&lmt=1393852148982197&signature=780C53D169FDDEF9ABA5F116E0795FF6923ACE34.0AAE4F
BA309FB203039D695FCF3D943533A672B1&dur=94.969&initcwndbps=18426250&key=yt6&ip=95
.86.119.20&pl=24&expire=1479430888&mv=m&mt=1479409140&ms=au&mm=31&mn=sn-gphvo-ua
8e&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2C
ms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&source=youtube&ip
bits=0&mime=video%2Fmp4&upn=gnMYtWCM_tU&requiressl=yes'
[download] thai life-eJRKiweYxgM.mp4 has already been downloaded
[download] 100% of 4.09MiB

Sorry, I had forgotten to delete the previous output of your program, hence the ".mp4 already exists". Here is a log when starting from scratch:
C:\p\tools>youtube-dl -v http://www.youtube.com/watch?v=eJRKiweYxgM
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.youtube.com/watch?v=eJRKiweYxgM']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.11.18
[debug] Python version 3.4.4 - Windows-XP-5.1.2600-SP3
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] eJRKiweYxgM: Downloading webpage
[youtube] eJRKiweYxgM: Downloading video info webpage
[youtube] eJRKiweYxgM: Extracting video information
WARNING: unable to extract uploader nickname
[youtube] eJRKiweYxgM: Downloading MPD manifest
[debug] Invoking downloader on 'https://r5---sn-gphvo-ua8e.googlevideo.com/video
playback?lmt=1393852148982197&ms=au&source=youtube&dur=94.969&mv=m&pl=24&ip=95.8
6.119.20&requiressl=yes&id=o-AC0dndsRUGK2v1Hp6xo2m7J60UrSEGWgqLh3prd3h6kL&key=yt
6&signature=DB7F278A00597EA59FDED77737B6B51C2AEA1AA0.ABA5523BB3F00CB86F5AA38C56A
DE7797651F2F8&mm=31&mn=sn-gphvo-ua8e&itag=18&mt=1479409444&mime=video%2Fmp4&upn=
w5ew7Wylh2I&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cm
m%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&expire=1
479431178&initcwndbps=18907500&ratebypass=yes&ipbits=0'
[download] Destination: thai life-eJRKiweYxgM.mp4
[download] 100% of 4.09MiB in 00:11

Your zipped file plays fine with latest VLC. Most likely your VLC is outdated.

Thanks much. DUK (dumb user on keyboard) as i expected... :)
YAB
On Thu, Nov 17, 2016 at 9:13 PM, Sergey M<EMAIL_ADDRESS>wrote:

Your zipped file plays fine with latest VLC. Most likely your VLC is
outdated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rg3/youtube-dl/issues/11218#issuecomment-261339928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWcLcetGE5r7eHbvajbgKrESjPZqjpTBks5q_Kc-gaJpZM4K1rVQ
.


the height of div container is required?

It is great that install this script is easy, and the performance of the scale is perfect.
My question: I must set the height of the div container, or the image won't be displayed.
Is there a bug or I got some error?
Thanks.

Hi, the point of the library is to scale an image according to its container. If the container has no height it is then normal that nothing is display. If you want the height to be relative to the height of the image, chance is that you don't need this library and simply have to replace the container by the image.
I'm closing this issue. Feel free to reopen and explain your case in more depth if I missed something.


✨ feat: added blob utilities (#604)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #604 (32de491) into main (fcce113) will decrease coverage by 3.58%.
The diff coverage is n/a.

:exclamation: Current head 32de491 differs from pull request most recent head be56aef. Consider uploading reports for the commit be56aef to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   85.77%   82.20%   -3.58%
==========================================
  Files         219       12     -207
  Lines        2376      236    -2140
==========================================
- Hits         2038      194    -1844
+ Misses        338       42     -296

see 207 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


tests/eas/hmp_parity: Add descriptions for tests

The hmp parity tests don't have descriptions and are very cryptic for those that have no previous experience with EAS.  Add a simple description.

:heart: thanks!


Main bc owl mainnet 3

(optional) to update the hot wallet in order to minimize execution time:
cargo run -- --data-dir zingolib/src/wallet/disk/testing/examples/mainnet/hhcclaltpcckcsslpcnetblr/latest/
to run a basic hot test:
cargo nextest run --run-ignored=all mainnet_latest_send_to_self_orchard_hot

test only PR

mainnet tests
separated assert_fee_and_record into helpers
numerous micro refactors

Please change from initial letter on each token of the seed phrase to the initial tokens in the seed.. maybe 2 or 3.
Please use the default import syntax that code actions enforce on files.

not within the scope of this PR

Please change from initial letter on each token of the seed phrase to the initial tokens in the seed.. maybe 2 or 3.
Please use the default import syntax that code actions enforce on files.

not within the scope of this PR

Yeah, I am fine with these issues being addressed in another PR.  That could be a cleaner flow.


Update to v3

Updates the Quickstart to the latest Auth0.OidcClient.UWP package v3.1.2
This also:

requires the minimum SDK target is updated to Windows 10 Fall Creators Edition
updates the UWP package to 6.2.9
includes a demo temporary key for less friction

I believe this fixes #13


MH-12819: change extract-text encoding profile for better OCR results…

… when using digital documents.
The extract-text encoding profile was originally used for grainy slides/document cameras (see https://groups.google.com/a/opencast.org/forum/#!searchin/users/mh-12819|sort:date/users/xAcxeUFAhSM/0c71zxXRCQAJ). As such, the encoding profile produces miserable results for PDFs, powerpoint slides and the like when those video streams are sourced via HDMI.
This PR proposes a different encoding profile for OCR images which produces better results for digital documents.

@slampunk, can we redirect this to r/6.x?

Hi @lkiesow sorry for the delay. I've redirected the PR to r/6.x

Thanks → merged


Update TeXstudio to 2.12.8

It has moved from sourceforge downloads to github.

After making all changes to the cask:

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

Duplicate of https://github.com/caskroom/homebrew-cask/pull/44459
Thanks for the PR nonetheless!


Split images and add CI script to run e2e in-cluster

This PR:

splits the runtime and e2e tests image
embeds kubectl into the e2e tests image where it is required (and was previously; this removes the mount hack)
adds ci script to run e2e's on remote cluster (for Prow)

# Requires
- [ ] #33
- [ ] #35
- [ ] #37

/test all

/retest

@zimnx this is ready to be reviewed.
(Let Tide merge it when you're tagging it. I'll switch the required jobs on the repo when it has the tags.)

Thanks!
/lgtm


All fortify issues are not reflecting in DefectDojo

Bug description
I am uploading the XML report exported from Fortify SCA 19.10 and 17.20 to DefectDojo. Instead of showing all the vulnerabilities from each category,  DefectDojo is showing one vulnerability from each category.
Steps to reproduce
Steps to reproduce the behavior:
1.For a product navigate to Findings tab and click on import scan results.
2.Fill up the required details and choose scan type as Fortify Scan and upload the xml file generated by fortify
3.After successful upload, one can see DefectDojo is showing one vulnerability from each fortify  scan category instead of showing all vulnerabilities from all category.
XML was generated by using below command.
ReportGenerator -format XML -template "DefaultReportDefinition.xml" -f "C:\Demo\SourceCode\WebGoat-Legacy\WebGoat_Fortify_DefaultReportDefinition.xml" -source  "C:\Demo\SourceCode\WebGoat-Legacy\webgoat6-cli.fpr"
Please note for other -template types like DeveloperWorkbook.xml or OWASP2013.xml , while uploading the xml files in DefectDojo, Server Error (500) is coming.
Expected behavior
DefectDojo must show all the fortify reported vulnerabilites.
Deployment method (select with an X)

[x] Docker

Environment information

Operating System: [e.g. Ubuntu 18.04]
files.zip

Sample scan files (optional)
Attached

Hello @amrityam .
It seems that this parser was done for that "defaultReportDefinition" report which doesn't have all the details.
The structure is quite strange actually: it gives counts for a given type of vulnerability and then gives a couple of random files concerned, but not all:
                    <GroupingSection count="4">
                        <groupTitle>Command Injection</groupTitle>

(...)
                        <Issue iid="2390CF7C0D738E2BE2F968716E8C1539" ruleID="1C7A212C-7723-452B-97D5-4D94EC85829E">
                            <Category>Command Injection</Category>

(...)
                            <Primary>
                                <FileName>WSDLScanning.java</FileName>
                                <FilePath>src/main/java/org/owasp/webgoat/lessons/WSDLScanning.java</FilePath>
(...)
                            </Primary>
                            <Source>
                            <FileName>ParameterParser.java</FileName>

When in the developer workbook report we can see that not only WSDLScanning.java is touched but also Exec.java:

Command Injection
(...)

WSDLScanning.java
src/main/java/org/owasp/webgoat/lessons/WSDLScanning.java
                        <Issue iid="1EE43C8EBD079E2A1595DC2E202F0C99" ruleID="5760613C-9AF8-41EF-8431-66B6FBD4717A">
                            <Category>Command Injection</Category>
(...)
                            <Primary>
                                <FileName>Exec.java</FileName>

For more details, I think we should adapt the parser for those other formats and also get at least detailed information for each filename :
What is does now is aggregate vulns on title + sev + cwe_id, ignoring the file name, and then putting the last filename found in the category into "file_path"
The filename should be part of the aggregation so that we have at least one finding for each filename.
Still we wouldn't have all the findings because there might be sometimes several of the same type in the same file (at different line number) but I think this is a good compromise
To go further, we could also count the number of occurences so that one can verify that all the vuln are here. The field nb_occurences was added in that PR https://github.com/DefectDojo/django-DefectDojo/pull/1540 and will be merged to dev soon hopefully.
The fortify code is here: dojo/tools/fortify/parser.py is someone feels like it :)

@ptrovatelli , yes we should track all the occurrences of the vulnerabilities reported by Fortify.Hope this will be fixed soon.

@ptrovatelli And DeveloperWorkbook.xml gives more detail information like source to sink.It should be supported by DefectDojo.

there are also new fields for source/sink information in that PR #1540 . What was done on checkmarx scanner could be applied to fortify as well: two scanners

one aggregated on type of vuln/ file_path
one detailed with source/sink detailed information

My notes on creating a Fortify XML report might be useful as well.
Creating Fortify XML Reports for Import to Defect Dojo
A Fortify XML file is created from the fortify .fpr file
Note a .fpr file is a .zip file with a collection of files in it.
The reportgenerator utility can be used to generate an XML file from the FPR file:
C:\Program Files\HPE_Security\Fortify_SCA_and_Apps_17.20\bin\ReportGenerator.bat -format XML -f fortify_v18.20.1046.xml -source fortify_v18.20.1046.fpr
The above method will get you just one representative issue from each type of issue (<GroupingSection>) .
In order to import all issues you need to jump through a couple of hoops
cd %FORTIFY_HOME%/Core/config/reports
Copy the DefaultReportDefinition.xml to DefaultReportDefinitionAllIssues.xml
Change
<IssueListing limit="1" listing="true">
To:
<IssueListing limit="-1" listing="true">
Change:
<Refinement>[fortify priority order]:critical OR [fortify priority order]:high</Refinement>
To:
<Refinement/>
The reportgenerator utility can be used to generate an XML file from the FPR file, specifying the new template file:
C:\Program Files\HPE_Security\Fortify_SCA_and_Apps_17.20\bin\ReportGenerator.bat -template DefaultReportDefinitionAllIssues.xml -format XML -f fortify_v18.20.1046.xml -source fortify_v18.20.1046.fpr

Also note that there are templates in the %FORTIFY_HOME%/Core/config/reports directory that make the reports quite different. The sections / headings have different names so the parser would not recognize the sections.

Also I don't know if Fortify will mark items in the report as false positive. I am pretty sure the parser would not notice if it did. I know that checkmarx does include in the XML report if the issue has been marked as false positive but the parser doesn't notice.

I know that checkmarx does include in the XML report if the issue has been marked as false positive but the parser doesn't notice.

haha exactly! noticed that a couple of days ago; will commit the fix in the next few days for checkmarx because I didn't find a way to exclude false positive when exporting with checkmarx plugin for jenkins.

Just want to add to this.
First off thanks @dougmcdorman for the post and the notes. Helped me out a lot. (limit=-1, genius)
Secondly I wanted to suggest a change to the fortify parser and the data as it's displayed in Defect Dojo. Rather than having each groupTitle as a single Finding with a collection of horribly formatted LineStarts and FileNames in the description, we create a single Finding for each issue (as redundant as that may feel) given that a finding in DefectDojo has a single file name and line number associated with it.
Is that something other Fortify users would like to see?

haha exactly! noticed that a couple of days ago; will commit the fix in the next few days for checkmarx because I didn't find a way to exclude false positive when exporting with checkmarx plugin for jenkins.

Sorry, off topic for this issue. But as far as I can tell the Checkmarx API does not allow you to exclude false positives either. You can do it in GUI but that doesn't help in this case. Hopefully Checkmarx will fix that someday but I won't hold my breath.

@amrityam would you know if PR https://github.com/DefectDojo/django-DefectDojo/pull/1706 would help your cause?


reShareUpdate API tests failing in reva master

https://drone.cernbox.cern.ch/cs3org/reva/7313/13/6
runsh: Total unexpected failed scenarios throughout the test run:
apiShareReshareToShares3/reShareUpdate.feature:152
apiShareReshareToShares3/reShareUpdate.feature:153

  Scenario Outline: After losing share permissions user can still delete a previously reshared share              # /drone/src/tmp/testrunner/tests/acceptance/features/apiShareReshareToShares3/reShareUpdate.feature:137
    Given using OCS API version "<ocs_api_version>"                                                               # FeatureContext::usingOcsApiVersion()
    And user "Alice" has created folder "/TMP"                                                                    # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/TMP" with user "Brian" with permissions "share,create,update,read"       # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/TMP" offered by user "Alice"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Brian" has shared folder "Shares/TMP" with user "Carol" with permissions "share,create,update,read" # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Carol" has accepted share "/TMP" offered by user "Brian"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Alice" has updated the last share of "Alice" with                                                   # FeatureContext::userHasUpdatedTheLastShareOfWith()
      | permissions | create,update,read |
    When user "Brian" deletes the last share using the sharing API                                                # FeatureContext::userDeletesLastShareUsingTheSharingApi()
    Then the OCS status code should be "<ocs_status_code>"                                                        # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                                      # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And user "Carol" should not have any received shares                                                          # FeatureContext::userShouldNotHaveAnyReceivedShares()

    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
        OCS status code is not any of the expected values 100 got 996
        Failed asserting that an array contains '996'.
      | 2               | 200             |
        OCS status code is not any of the expected values 200 got 996
        Failed asserting that an array contains '996'.

After the API test code changes in core PR https://github.com/owncloud/core/pull/40114 these are failing in reva.
They are passing in oCIS (I will find a CI example of that...)
I will add them to expected failures for now, because it will be good to get the benefit of the core API test code changes running in reva CI.
ToDo:

[x] find oCIS examples of these test scenarios running
[ ] understand why they fail now in reva when they used to pass
[ ] decide what to do next

Interestingly enough it doesn't fail on the resharing branch: https://github.com/cs3org/reva/pull/2877
It is up to date with master, so some changes in there seem to fix it.

Looking closer into it I would strongly suggest that the reason why it passed before is https://github.com/owncloud/core/issues/40093
When user "Brian" deletes the last share using the sharing API

This "last share" was probably some other share and resulted in success. I cannot say which one though.
But I can say for sure that it wasn't possible to delete a share without the share permission. I added that functionality in https://github.com/cs3org/reva/pull/2877

Note: these scenarios are in oCIS expected-failures:
#### [500 status code on update share](https://github.com/owncloud/ocis/issues/2011)

- [apiShareReshareToShares3/reShareUpdate.feature:152](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareReshareToShares3/reShareUpdate.feature#L152)
- [apiShareReshareToShares3/reShareUpdate.feature:153](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareReshareToShares3/reShareUpdate.feature#L153)

They are linked to a different oCIS issue that no longer seems relevant.
An example CI run is:
https://drone.owncloud.com/owncloud/ocis/12263/44/7
  Scenario Outline: After losing share permissions user can still delete a previously reshared share              # /srv/app/testrunner/tests/acceptance/features/apiShareReshareToShares3/reShareUpdate.feature:137
    Given using OCS API version "<ocs_api_version>"                                                               # FeatureContext::usingOcsApiVersion()
    And user "Alice" has created folder "/TMP"                                                                    # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/TMP" with user "Brian" with permissions "share,create,update,read"       # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/TMP" offered by user "Alice"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Brian" has shared folder "Shares/TMP" with user "Carol" with permissions "share,create,update,read" # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Carol" has accepted share "/TMP" offered by user "Brian"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Alice" has updated the last share of "Alice" with                                                   # FeatureContext::userHasUpdatedTheLastShareOfWith()
      | permissions | create,update,read |
    When user "Brian" deletes the last share using the sharing API                                                # FeatureContext::userDeletesLastShareUsingTheSharingApi()
    Then the OCS status code should be "<ocs_status_code>"                                                        # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                                      # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And user "Carol" should not have any received shares                                                          # FeatureContext::userShouldNotHaveAnyReceivedShares()
    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
        OCS status code is not any of the expected values 100 got 996
        Failed asserting that an array contains '996'.
      | 2               | 200             |
        OCS status code is not any of the expected values 200 got 996
        Failed asserting that an array contains '996'.

So this does fail in the same way on oCIS.
I will write-up an oCIS issue tomorrow with better details and example curl commands. Then we can link everything to that, and discuss what the behavior should be.

The line numbers failing in reva master branch are now:
#### [reShareUpdate API tests failing in reva](https://github.com/cs3org/reva/issues/2916)

- [coreApiShareReshareToShares3/reShareUpdate.feature:158](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareReshareToShares3/reShareUpdate.feature#L158)
- [coreApiShareReshareToShares3/reShareUpdate.feature:157](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareReshareToShares3/reShareUpdate.feature#L157)

The test scenarios pass in the edge branch. For example:
https://drone.owncloud.com/cs3org/reva/1406/22/7
  Scenario Outline: After losing share permissions user can still delete a previously reshared share              # /drone/src/tmp/testrunner/tests/acceptance/features/coreApiShareReshareToShares3/reShareUpdate.feature:142
    Given using OCS API version "<ocs_api_version>"                                                               # FeatureContext::usingOcsApiVersion()
    And user "Alice" has created folder "/TMP"                                                                    # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/TMP" with user "Brian" with permissions "share,create,update,read"       # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/TMP" offered by user "Alice"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Brian" has shared folder "Shares/TMP" with user "Carol" with permissions "share,create,update,read" # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Carol" has accepted share "/TMP" offered by user "Brian"                                            # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Alice" has updated the last share of "Alice" with                                                   # FeatureContext::userHasUpdatedTheLastShareOfWith()
      | permissions | create,update,read |
    When user "Brian" deletes the last share using the sharing API                                                # FeatureContext::userDeletesLastShareUsingTheSharingApi()
    Then the OCS status code should be "<ocs_status_code>"                                                        # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                                      # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And user "Carol" should not have any received shares                                                          # FeatureContext::userShouldNotHaveAnyReceivedShares()
    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
      | 2               | 200             |

I will leave this issue open, because it is linked from the expected-failures files in reva master. But I will unassign myself.


Reduce intrusiveness of make clean

Rework make clean as discussed in #3. Now we only delete our build files
and delete all empty subdirectories of $(OBJDIR), $(DEPDIR) and
$(BINDIR). We also delete all empty parent directories of $(OBJDIR),
$(DEPDIR) and $(BINDIR) recursively.
Closes #3

Closing this since merging #5 will already fix #3.


EHRbase's Docker image should be tested more thoroughly/automatically

Background
Our CI pipeline builds EHRbase from scratch. After that it starts EHRbase server from the packaged .jar and runs all Robot Integration tests against it. At the end a Docker image is deployed to DockerHub registry. This Docker image is not tested by us in an automated manner. It is (if at all) tested by users in the field.
Since the "Docker way" of using EHRbase seems to be the most popular we should test it's Docker image more thoroughly, regularly, in an automated fashion.
Acceptance Criteria

[ ] All Robot integration tests executed against EHRbase running in Docker
[ ] New tests ensure that Docker ENVs set during container start up work correctly
[ ] Docker image is tested before it is deployed to DockerHub

Definition of Done

[ ] Output has been reviewed or presented and has been approved
[ ] Documentation has been updated (Sphinx, Javadoc, Guidelines, etc.) if applicable

One possible option is to use features provided by DockerHub itself, see related issue.

I am interested in how this can be achieved.
Especially how you test the docker image with a supporting service like postgres. Currently, I'm running some tests for FLAT compositions by bringing up EHRbase and the supporting services via docker-compose and running these tests within docker-compose. However, I had to install docker-compose on the VM that is doing the testing (Jenkins), and sometimes it's not very reliable at bringing down the containers. Also, I had to make sure that the EHRbase instance was ready before running the tests by using wait-for-it. If the Robot Framework has any better automation tools for this, I'll be stealing that. Thank you.

@sidharthramesh  docker-compose is an option. You can make Robot start the containers and/or start docker-compose and let it wait for the containers reliably by creating your on keywords (see examples) on top of docker.py. check out this example where I use docker logs to wait for a specific string in the log of the db container.


Request/Response with Reactive

Hi
I'm loving the AsObservable(), from there I can make really powerful coordination of messages like grouping and doing stuff to each group. However, is there a way to do Request/Respoonse using the same pattern?
Example:
bus.AsObservable<Car>() gives me an Observable of cars that need service. I then group them by brand using .GroupBy(c => c.Brand). Finally I subscribe to each group to perform the service using the appropriate service provider. This much I have achieved.
However, if the car owner cant pay for the service, I want to Respond to whoever was requesting the service.
Is this even doable?
Thanks!

So, with MassTransit 3, you really should be using a receive endpoint, and connecting to that endpoint using the .Observer() method, as shown below. This will give you the full message context, including the all-important ConsumeContext, which has the methods you need to respond.
In this case you pass an observer, which you could create with Observable.

So I should not implement IRequestClient?

@phatboyg did you mean to paste some code (you wrote "as shown below").
However, I now have a class called CarWash which takes an IBus in it´s constructor. This class then starts to subscribe to messages of type PerformServiceRequest using bus.AsObservableContext. Is this the right way to go about it?
I suppose I will then create an IRequestClient<PerformServiceRequest, PerformServiceResponse> to call it with? What happens if CarWash responds with something other than a PerformServiceResponse?
Thanks!

The commit referenced has some unit tests I wrote thinking about the problem.

Im sorry @phatboyg I'm not seing anything in there about Request/Response?

Yes, you use the request/response client from the originator (not the Rx code).
And you need to subscribe the Rx code to the ConsumeContext, not just , and use the Respond method to send the response back to the originator.

Im not sure I'm following. Does the ConsumeContext have a property on which I can call AsObservableContext?

First, don't use Bus.AsObservable -- it's not the right way to do things.
You should subscribe your observer as shown in this code right here: https://github.com/MassTransit/MassTransit/blob/eb281b22784e33c7cd07cd60bb7c228ec7808d95/src/MassTransit.Reactive.Tests/Factory_Specs.cs#L82
Then, you'll have the ConsumeContext<> in the Rx logic and be able to use it to reply.

I think I understand. Instead of getting an observable off the bus, I create an ObservableObserver and can then pass that into my class, and it may subscribe to it?

It works now! FYI I didn't have the ObservableObserver in my version of the NuGet package so I used a Subject instead (basically the same thing).
Thanks!

Great, glad to hear you are working through it!

Shouldn't this be closed, @johnknoop?


Etherscan.io's "Write Contract" Function Doesn't Work

When attempting to use the "Write Contract" function on etherscan.io, the page fails to connect to "MetaMask".

This looks like an injection timing issue, and I suspect is the same issue as #3. I suspect the solution will be to switch to innerText based injection.


feat: Error boundaries

https://github.com/aidenybai/million-react/issues/6

FYI, preact implements a useErrorBoundary to catch error during rendering: https://preactjs.com/guide/v10/hooks/#useerrorboundary
https://github.com/preactjs/preact/blob/0406941612c12f1056e9f1f00c62030c591dd085/hooks/src/index.js#L319
However, preact still implements it based on componentDidCatch.
It is possible to implement a similar solution, but it won't be a drop-in replacement for react.

I did a very basic PoC that adds componentDidCatch to class components from errors caught on render.
I'm not sure if adding a useErrorBoundary hook makes sense for Million?


add tests for primitive parameters

#1089

@arvuce22 I have added some tests for constraint-driven parameterization of the primitives. Not sure how to verify that the generated primitives adhere to the provided inputs?

@arvuce22 can you review it?


I want to validate atleast one alphabates in EditText input

Use the @Length and @Pattern annotation.


Arrangement and execution of the meeting (issue #218 related)

The goal is to conduct a meeting covering basic usage and operations on objects from ODESystem class.

Issue can be closed


ScopeDoctorGroup check fails when no commands or paths given

I was porting from ScopeDoctorCheck to ScopeDoctorGroup, and didn't correctly name things:
apiVersion: scope.github.com/v1alpha
kind: ScopeDoctorGroup
metadata:
  name: github
spec:
  description: Check GitHub is configured
  needs:
    - homebrew
  actions:
    - description: GitHub CLI authentication
      name: cli
      check:
        commands: github-cli.sh check
      fix:
        target: github-cli.sh fix

    - description: GitHub SSH authentication
      name: ssh
      check:
        target: github-ssh.sh check

I was surprised to see the check as failing, when it probably shouldn't have been even run if there wasn't anything to check 🤔

Maybe we need some schema validation / error checking?

It could be done where it would fail parsing YAML, but I don't think that's what we want. Adding an extra field shouldn't case an error in my mind, but a warning. I think this aligns with your other issue more generally having scema validation w/ warnings when something doesn't line up correctly.


Need help parsing and getting Request Response Schema

I need to Parse Swagger in Java to get list of all api and the respective Request Response.
I am able to get all the api's present but unable to get valid Request Response.
I tried to generate the same using swagger.getDefinitions() From the models, but its not correct and doesn't work for the Array structures within the payload.
I heard Swagger Codegen might be appropriate for getting schema but couldn't find any examples to do so.
Is there a way in which I can get the Payloads too ?

Hi,  what do you mean by but unable to get valid Request Response? Maybe if you have an example of what you have and what you expect to get, I can have a clearer picture. 👍

employeeSwagger.txt
Attached the sample swagger I am trying to parse
The Online Swagger editor produces follows sample response :
[ { "account": [ { "description": "string", "href": "string", "id": "string", "name": "string" } ], "contactMedium": [ { "characteristic": { "city": "string", "country": "string", "emailAddress": "string", "faxNumber": "string", "phoneNumber": "string", "postCode": "string", "stateOrProvince": "string" }, "experience": { "Duration": 0, "Time": "2018-06-07T16:46:22.000Z" }, "preferred": true, "type": "string" } ], "experience": { "Duration": 0, "Time": "2018-06-07T16:46:22.000Z" }, "id": "string", "name": "string", "status": "string" } ]
The response I am able to parse is follows
[ { "account": [ { "description": "", "href": "", "id": "", "name": "" } ], "contactMedium": [ { "preferred": false, "type": "" } ], "id": "", "name": "", "status": "" } ]
I am not able to create JSON node (which are instances of "io.swagger.models.properties.RefProperty")
Follows is the short snippet of code where I am using Swagger Java Parser.
Swagger swagger = new SwaggerParser().read(filePath);
Map<String, Model> models = swagger.getDefinitions();
A loop to iterate over the operations parsed, follows is the code to generate Response Schema
Map<String, Property> schemaMap = model.getProperties();
for (Map.Entry<String, Property> entrySchemaProperty : schemaMap.entrySet()) {
      //check for instanceof Property and accordingly create JSON recursively
}
The problem in above is I know that Property is of type RefProperty, But I am not able to get any model for the same to create equivalent JSON node for eg Duration node in the above.

@InCh01, I added this test https://github.com/swagger-api/swagger-parser/blob/Issue-731-OAS2/modules/swagger-parser/src/test/java/io/swagger/parser/SwaggerParserTest.java#L57-L65
I found the RefProperty inside Definitions -> Employee -> Properties -> Account -> Items -> AccountRef not sure if that answers your question.

Hi Grace,
Thank you for responding.
No I have no problem with the 'account' node as it is an array.
The problem lies with nodes that are not Array. Like Duration, Characteristic, Experience.

If I understand correctly what you want is to get the response examples as the editor does?

Yes, I need to get the response like the editor does.


Alternate for fzf: Bubbletea, beautiful TUI Framework

https://github.com/charmbracelet
https://github.com/charmbracelet/bubbletea
I like the bubbles and lipgloss styles that they have, you can see many in the readme.md

This is written in go and it's an library for go. Not for Python


docs(filtering): add [ to special characters

Description
Hi 👋🏻,
thanks for providing this awesome library.
When I send a query containing an [, I experience the following error.
 UNHANDLED EXCEPTION (TraceId=2f9adeb5-7185-4468-92b3-c538884d2834) WAS CAUGHT: bad character input: '/' at 89. expected ']'
   at Gridify.GridifyExtensions.ApplyFiltering[T](IQueryable`1 query, String filter, IGridifyMapper`1 mapper)
         at Gridify.EntityFramework.GridifyExtensions.GridifyQueryableAsync[T](IQueryable`1 query, IGridifyQuery gridifyQuery, IGridifyMapper`1 mapper, CancellationToken token)
         at Gridify.EntityFramework.GridifyExtensions.GridifyAsync[T](IQueryable`1 query, IGridifyQuery gridifyQuery, CancellationToken token, IGridifyMapper`1 mapper)

When I escape the [ with \ the query works as expected and no error is thrown.
I think [ is a special character, because it is used to allow Indexes.
That's why it should be escaped.
Therefore, I updated the documentation, accordingly using the following Regex: /([(),|]|\[|\/i)/g
I am happy, if you find this contribution useful.
Cheers
Gregor
Type of change

[x] Documentation
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have performed a self-review of my code
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have made corresponding changes to the documentation
[ ] I have commented my code, particularly in hard-to-understand areas
[x] New and existing unit tests pass locally with my changes

Hi @GregOnNet,
First thank you again for your contribution but this was a bug and I fixed it in v2.9.1


Test the GC optimization of Tinygo 0.27

Why do you need it?
We've built many wasm go plugins through Tinygo 0.25 and we want to upgrade to Tinygo 0.27 which does some GC optimizations and it also provides a new gc option: -gc=precise seems to be more faster than -gc=conservative.
How could it be?

Write a wasm plugin to frequently create & release multiple objects
Build different plugins with Tinygo 0.25 and 0.27 (with different gc options)
Deploy different plugins to Higress
Start the benchmark test and observe the cpu&memory metrics of Higress

Other related information
https://github.com/tinygo-org/tinygo/releases

Hi, I have an idea for this task, but don't know how to test the wasm plugin in higress, can you give some help tips

https://higress.io/zh-cn/docs/plugins/custom
https://higress.io/zh-cn/docs/user/wasm-go
@Fkbqf FYI

please assign me

https://higress.io/zh-cn/docs/plugins/custom https://higress.io/zh-cn/docs/user/wasm-go
@Fkbqf FYI


Cleanup/CI

[x] Applied cargo fmt
[x] Applied cargo clippy
[x] Added CircleCI. You will need to  activate it on your profile.

A few remaining Clippy suggestions.

Don't name structs with the name of the module:

warning: item name ends with its containing module's name. You can always call `BaseConfig` as `config::Base`
  --> src/config.rs:19:1
   |
19 | / pub struct BaseConfig {
20 | |     pub frontends: HashMap<String, FrontendConfig>,
21 | |     pub backends: HashMap<String, BackendPool>,
22 | |     pub stats: Stats,
23 | |     pub passthrough: Option<Passthrough>,
24 | | }
   | |_^
   |
   = note: `-W clippy::module-name-repetitions` implied by `-W clippy::pedantic`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

and
warning: item name starts with its containing module's name
  --> src/stats.rs:24:1
   |
24 | / pub struct StatsApi {
25 | |     stats: Arc<RwLock<Stats>>,
26 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

If your enum is called ReadError all fields inside are errors, so it is kind of redundant to have Error in the enum fields.

warning: All variants have the same postfix: `Error`
  --> src/config.rs:57:1
   |
57 | / pub enum ReadError {
58 | |     IOError(IOError),
59 | |     ParseError(Vec<toml::de::Error>),
60 | |     DecodeError(toml::de::Error),
61 | | }
   | |_^
   |
   = note: `-W clippy::pub-enum-variant-names` implied by `-W clippy::pedantic`
   = help: remove the postfixes and use full paths to the variants instead of glob imports
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#pub_enum_variant_names

it seems that tokio::prelude is unused here:

warning: unused import: `tokio::prelude`
  --> src/proxy/mod.rs:11:5
   |
11 | use tokio::prelude::*;
   |     ^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Hope it helps @bparli

Hi @naomijub, thank you for the helpful PR!
I had been wanting to try out github actions but as you noticed I never got around to it. Since you have circleci ready lets go with that.  I did notice the test step is failing with os error 1 though.  I wonder if we need to run that job on a circleci VM instead of a container?
Rest of the changes make sense and lgtm

I did not notice this 🤔. But some of the errors that are still there are due to some failing clippy actions and some test that failed. I will take a look and commit again

@bparli running on VM "worked". However, we got this error that I am not sure what caused it:
thread 'tokio-runtime-worker-0' panicked at 'attempted to leave type `std::mem::ManuallyDrop<internal::SealedBag>` uninitialized, which is invalid', /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/mem/mod.rs:658:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Do you have any ideas? It seems that all tests passed 🤔

Interestingly enough, I was only able to reproduce it after upgrading to Rust 1.48 (from 1.46).  I had to upgrade couple tests dependencies and then fix the tests.  I went ahead and upgraded to tokio 1 as well.
Its fixed for me now locally, should hopefully make your circleci job happy now @naomijub

Now it seems to pass!
Also, I noticed the build has the following warnings:
warning: value assigned to `servers_dist` is never read
  --> src/proxy/backend.rs:82:13
   |
82 |         let mut servers_dist = None;
   |             ^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_assignments)]` on by default
   = help: maybe it is overwritten before being read?

warning: constant is never used: `ETHERNET_HEADER_LEN`
  --> src/passthrough/utils.rs:18:1
   |
18 | pub const ETHERNET_HEADER_LEN: usize = 14;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: constant is never used: `TCP_HEADER_LEN`
  --> src/passthrough/utils.rs:20:1
   |
20 | pub const TCP_HEADER_LEN: usize = 32;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function is never used: `find_local_addr`
  --> src/passthrough/utils.rs:22:8
   |
22 | pub fn find_local_addr() -> Option<Ipv4Addr> {
   |        ^^^^^^^^^^^^^^^

warning: function is never used: `build_dummy_ip`
  --> src/passthrough/utils.rs:37:8
   |
37 | pub fn build_dummy_ip(
   |        ^^^^^^^^^^^^^^

warning: function is never used: `build_dummy_eth`
  --> src/passthrough/utils.rs:80:8
   |
80 | pub fn build_dummy_eth(
   |        ^^^^^^^^^^^^^^^

warning: unused `std::result::Result` that must be used
   --> src/passthrough/backend.rs:168:13
    |
168 |             sock.shutdown(std::net::Shutdown::Both);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: this `Result` may be an `Err` variant, which should be handled

warning: unused `std::result::Result` that must be used
   --> src/passthrough/backend.rs:171:13
    |
171 |             sock.shutdown(std::net::Shutdown::Both);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this `Result` may be an `Err` variant, which should be handled

warning: 8 warnings emitted

The ones with std::result::Result are pretty easy to fix, the others I guess are related to cfg(test)? if this is the case they could be marked with #[cfg(test)] or we could add docs

Nice!
I agree most of that output can be addressed, although a couple look like false positives.  I'll draft a quick PR for that
This PR looks gtg to me.  I'll go ahead and merge it unless there is anything else you'd like to address @naomijub?

@bparli Looks perfect! Thanks!


fpga_admissionwebhook: add orchestrated mode

In orchestrated mode the webhook parses requested resources and to translates
them to a container's ENV variables to let CRI hooks to program the FPGA with
requested bitstreams before starting the container.

Codecov Report

Merging #35 into master will increase coverage by 1.76%.
The diff coverage is 88.49%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   77.47%   79.23%   +1.76%
==========================================
  Files           5        5
  Lines         506      602      +96
==========================================
+ Hits          392      477      +85
- Misses        107      116       +9
- Partials        7        9       +2

Impacted Files
Coverage Δ

cmd/fpga_admissionwebhook/fpga_admissionwebhook.go
76.88% <88.49%> (+8.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbc22b...86ec6cf. Read the comment docs.

Extended webhook-deploy.sh to support preprogrammed and orchestrated modes of the webhook.

On Wed, Jun 27, 2018 at 10:47 AM, Ed Bartosh<EMAIL_ADDRESS>wrote:

In cmd/fpga_admissionwebhook/fpga_admissionwebhook_test.go
https://github.com/intel/intel-device-plugins-for-kubernetes/pull/35#discussion_r198395199:

}{

{

	input:       "intel.com/fpga-arria10",

	expectedErr: true,

},

{

	input:       "intel.com/fpga-unknown",

	expectedErr: true,

},

{

	input:       "example.com/fpga-something",

	expectedErr: true,

},

{

	input:       "intel.com/fpga-arria10-nlb0",

	interfaceID: "ce48969398f05f33946d560708be108a",

it's hard to understand which part is device and which is af. Can we have
it like this "intel.com/fpga-arria10/nlb0" or similar?

About resource names... I tried to use slashes instead of dashes first, but
k8s refused to accept such specs:
The Pod "test-pod-2" is invalid:
* spec.containers[0].resources.limits[intel.com/fpga/arria10/nlb0]: Invalid
value: "intel.com/fpga/arria10/nlb0": a qualified name must consist of
alphanumeric characters, '-', '_' or '.', and must start and end with an
alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex
used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an
optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

in theory, nothing prevents us to use fpga.intel.com/arria10/xxxx

in theory, nothing prevents us to use fpga.intel.com/arria10/xxxx

You mean fpga.intel.com/arria10-xxxx?


Backing

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Is your feature request related to a problem?
Thanks for integration!
I have dashboards with a lot of elements
It’s really hard to detect turned on entities fast
Colored circles is not enough visually noticeable.
Describe the solution you'd like
Could you please add option to change all background instead of circle
or how to do it using card-mod?
Describe alternatives you've considered
No response
Additional context
No response

You can do change the ha-card background colour using card mod however this leads to a mildly irritating 'flicker' effect whenever you reload a view due to the browser rerunning the card mod code on top of the base mushroom card code.


Unable to get packages from source

Following the first few steps in the readme ends me up with this error.
https://github.com/rust-lang/rustc-serialize/issues/89
I think the fix for right now is to make piston use 0.3.7

Looks like a better fix is to:
mkdir .cargo && echo 'paths = ["/home/username/rustc-serialize"]' > .cargo/config

In your project directory, then cd $HOME and
git clone git@github.com:rust-lang/rustc-serialize.git

and then go back to your project and cargo build.

@snowe2010 Thanks for posting a work around! rustc-serialize seems to be updated now so that's why I guess you closed it.


FTP Uploads Hang.

Hello,
On my new PufferPanel installation, when I try to FTP into my server, uploading files is very glitchy. It tries to upload more than one of each file and it takes hours to upload like 10 files. I have 1 Gbps network so this shouldn't be so slow. I'm using the latest version of PufferPanel, and I'm kind of new to this.
Please let me know of any logs you would like to provide.

Known issue with other people's installs. Im not going to look into this because we are getting close to releasing 0.8.0 which will solve most of these problems. Sorry about the troubles though, hopefully we can get these fixes out soon.

Thanks @DaneEveritt! How long till 0.8.0?

No idea, but hopefully not too long.

Could changing the GSD active FTP ranges in config.json work?

*PassiveFTP and what about changing this or should I try config.json first?

You can try commenting out the pasvPortRangeStart and pasvPortRangeEnd (or just remove them) and see if that fixes anything.

I commented them out with two //, no luck. I then tested it, and tried disabling SSL. No luck. Should I possibly try PassiveFTP?

If there is no solution, could you point me to a temporary solution until 0.8.0 is realized? I'm having a few clients of my business test out PufferPanel, nothing for production use, I just wanted them to see how it was going to work.

Unfortunately there is nothing that I can think of to fix it temporarily. The entire setup of GSD is kind of ugly when it comes to FTP, so your guess is as good as mine.

Okay, I really need 0.8.0, and fast. Please if you could push the next update quickly, I might be able to donate some cash.

Have you tried using a different FTP client?

@DaneEveritt Yes. I've tried cyber duck, FileZilla, and webFTP.

@DaneEveritt I would like a response even if it is your clueless...

Looks like you have a network issue possibly. I have no idea what else it could be, and frankly asking over and over isn't going to really do anything because I'm not about to spend forever trying to diagnose an issue that is already fixed in future versions.
Error: Connection timed out after 20 seconds of inactivity
Error: File transfer failed

Make sure that your firewall is setup correctly to allow connections, other than that I have no idea.

Could I get a timeframe for the future update? I don't want to spend hours recoding the GSD myself only to find that the next version will be here in days @DaneEveritt

Putting ETAs in software that is in a beta state is just not something we
like to do. We could release it next month, we could release it in 6. If
you really want it now, take the time to fix it.
Or run the completely undocumented and unstable builds.
On Fri, Apr 3, 2015, 5:32 PM Dylan Seidt<EMAIL_ADDRESS>wrote:

Could I get a timeframe for the future update? I don't want to spend hours
recoding the GSD myself only to find that the next version will be here in
days @DaneEveritt https://github.com/DaneEveritt
—
Reply to this email directly or view it on GitHub
https://github.com/PufferPanel/PufferPanel/issues/484#issuecomment-89438793
.


uploadSmallFile in ingestion.py fails with file open error

Expected Behaviour
uploadSmallFile function should work correctly when ingesting data using .json file
Actual Behaviour
It fails with file not found error. This happens in the following code within the function
if type(data) == str:
            if '.json' in data:
                with open(Path(path),'r') as f:
                    data = json.load(f)

It fails because it is trying to open file at path instead it should try to open the file passed in data (if it is a .json file), for e.g. as follows:
if type(data) == str:
            if '.json' in data:
                with open(Path(data),'r') as f:
                    data = json.load(f)

Reproduce Scenario (including but not limited to)
NA
Steps to Reproduce
ingestor = ingestion.DataIngestion()
ingestor.uploadSmallFile(batch_id,dataSetId, filename,"./files/profiles.json")
ingestor.uploadSmallFileFinish(batch_id, "COMPLETE")
Platform and Version
NA
Sample Code that illustrates the problem
ingestor = ingestion.DataIngestion()
ingestor.uploadSmallFile(batch_id,dataSetId, filename,"./files/profiles.json")
ingestor.uploadSmallFileFinish(batch_id, "COMPLETE")
Logs taken while reproducing problem
NA

Thanks for this report. @samujob
Sorry for typo.
We will try to fix it in the next release.
I hope you are not stuck, it would be possible to load the JSON in the python environment and send the data directly via this function.


ci/editorconfig: Do not check .git

After recent editorconfig Docker image bump, the action started checking .git/config.

Wouldn't it be better to use the latest version but configure it properly ?

How it's going here ?

I did not have time for deeper diagnosis but updating the action to HEAD seems to fix it as well.


'type' object is not subscriptable

The exception can be fixed by replacing 'dict' to 'Dict'
 from typing import Optional, Sequence, Union ... def openai_completion(     prompts: Union[str, Sequence[str], Sequence[dict[str, str]], dict[str, str]],
-->
 from typing import Optional, Sequence, Union, Dict ... def openai_completion(     prompts: Union[str, Sequence[str], Sequence[Dict[str, str]], Dict[str, str]],

Hi,
Thanks for your interest! Sorry, we weren't super clear about the python version. But we're using Python 3.10 as the default in our experiments.
Python 3.9 introduced typing with the builtin types, e.g., see this
We'll clarify this further when we release the code for training, and make sure we have a setup.py or equivalent config file then.


Missing  in the devices table

@mep253 Can you see if you can fix?

Hi @simonmorley, this seems to be fixed already. This issue can be closed.


feature: Per-column search

API TBC.

What do you think of a bit different layout: split existing search field that the right side will be the select to choose scope? Access to it will be a bit longer, but I think design will stay more clean.

I like the idea, @studiowizjo!
We would need an indicator to show if any searches are active then though, since we would support simultaneous multiple columns search.

Hmm, they could be comma separated in select (something like this: https://mdbootstrap.com/docs/standard/extended/multiselect/) or maybe use similar layout to new filter indicators?

Hi, I would prefer not to have a select input involved here, you can use filters to implement a column select search field already. This PR is purely for people who want searchable at the top of their columns, which is not possible with filters atm.

Hi @danharrin, appology for throwing question on post from 2022. I am implementing search as shown above and have not found any details for specifying "local searcsh" attributes similar to globallySearchAttributesUsing that is available on Global Search.
I have BlogPosts resource and Blog Model which has  GlobalScope configured on it in order to limit/isolate records per user.  Resource Table View works fine and table View is showing records just fine.
But when I try to use Search and query is executed, that's where it breaks apart. Below is just close similar representation what I have, use case is slightly different but you can get the point.
I have Model Scope:
protected static function booted()
{
    static::addGlobalScope('author', function ($query) {
        // Limit what can be seen by the user to only their own posts
        $query->leftJoin('promoted_posts', 'blog_posts.author_id', '=', 'promoted_posts.author_id')
        ->select('blog_posts.*')
        ->where('blog_posts.author_id', auth()->user()->author_id)
        ->addSelect(DB::raw("CASE WHEN promoted_posts.author_id IS NOT NULL THEN 'Yes' ELSE NULL END AS promoted"));
    });
}

Query above works perfectly fine for listing records in Table View, as well filtering ?tableSortColumn=post_name&tableSortDirection=asc  and other columns. But, .... when search kicks in and adds extra parameter to query, that's where it falls apart.

Now, how do I override  addGlobalScope('author') scope with maybe a custom Builder scope that can execute desired query?
Is that even supported?
I am using Filament 3.1.x and haven't found anything but globalSearchResults in docs.

Update:
I've figure it out. research and research and persistance :). Override query search by setting blog_posts.post_name in query. This does "extend" existing Scoped model.

use Filament\Tables\Columns\TextColumn;
use Illuminate\Database\Eloquent\Builder;

TextColumn::make('post_name')
    ->searchable(query: function (Builder $query, string $search): Builder {
        return $query
            ->where('blog_posts.post_name', 'like', "%{$search}%");
    })

    ```

Thanks @danharrin for creating such a great tool!


CronJob is in batch/v1beta1 not batch/v1

Modifies k8s_types.rs to have CronJob under version v1beta1 instead of v1.
Fixes #32

CronJob in k8s_types.rs is defined as under the v1 batch api, but it does not exist in this version. It exists under v1beta1 and is not in v1.
This has the effect that if you specify .with_child(k8s_types::batch::v1::CronJob, ...) on your operator config then you get no events at all being processed, the operator appears to hang and do nothing. (which may perhaps be a separate bug?)

This operator config now processes events as expected:
    let operator_config = OperatorConfig::new(OPERATOR_NAME, PARENT_TYPE)
        .with_child(k8s_types::batch::v1beta1::CronJob, ChildConfig::replace());

Thanks a lot for fixing this!


Consider supporting gopack

What are your thoughts on adding support for gopack as well?

We'll review non godep option sometime in the future as things like this and this come to a conclusion.
Thanks!


Improve testability of the lib

Alright, this migrates danger-proselint to danger-prose - and also does a lot of the work around understanding what testing should look like for a plugin.

:+1:


Updated intro tokens

Removed Nuero from intro as being one of the key utility tokens of Origintrail, as this may confuse readers, Nuero is covered more later.

Thanks hot!


Adds API Docs Tooling

Uses github.com/elastic/crd-ref-docs to generate API docs.
Fixes #965
Signed-off-by: danehans<EMAIL_ADDRESS>

I'm not 100% happy with the generated output, but this can serve as a starting point for the API docs.

Codecov Report

Merging #980 (fc37c57) into main (7639637) will decrease coverage by 0.07%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   62.19%   62.12%   -0.07%
==========================================
  Files          55       55
  Lines        8779     8779
==========================================
- Hits         5460     5454       -6
- Misses       2951     2955       +4
- Partials      368      370       +2

Impacted Files
Coverage Δ

internal/provider/kubernetes/helpers.go
81.08% <0.00%> (-0.68%)
:arrow_down:

internal/provider/kubernetes/controller.go
49.77% <0.00%> (-0.57%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thanks for building this the code looks fine, SGTM here's another tool https://github.com/ahmetb/gen-crd-api-reference-docs that seems to be used by upstream https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/api-docs/generate.sh to generate api docs

I tried with that last night, almost completed.

here's another tool https://github.com/ahmetb/gen-crd-api-reference-docs that seems to be used by upstream https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/api-docs/generate.sh to generate api docs

@arkodg I looked at ^ tool first but settled on crd-reference-documentation-generator since it seemed better supported and for these reasons. Although the generator is fast, I'm not too impressed by the outcome and I still don't understand why the generator is having issues with the HeaderMatch type.

here's another tool https://github.com/ahmetb/gen-crd-api-reference-docs that seems to be used by upstream https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/api-docs/generate.sh to generate api docs

@arkodg I looked at ^ tool first but settled on crd-reference-documentation-generator since it seemed better supported and for these reasons. Although the generator is fast, I'm not too impressed by the outcome and I still don't understand why the generator is having issues with the HeaderMatch type.

SGTM thanks for explaining, the lint error is due to https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md051---link-fragments-should-be-valid
and it looks like there should be a valid title for headermatch which doesnt exist

FYI, https://github.com/ahmetb/gen-crd-api-reference-docs generate a bad output when using type like map[LogComponent]LogLevel

@zirain thanks for the information. The lint issue with this PR is due to the HeaderMatch struct which is not a map.

send a PR with my work on api  doc https://github.com/envoyproxy/gateway/pull/996

/doc

this part is better!


Can't play RTSP in demo app

Sorry for the question, but I tried to load an RTSP stream and it was expected to work.
The URL is: rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov
I tried the Native VideoView vs MediaPlayer-Extended view functionality, and it should work with the native VideoView (I have already tested it), but seems it not work.
I think that the library it's ok, but in the demo don't work.

Unfortunately RTSP is not supported. #65

I was talking about the native Android VideoView in the Demo app. I know that is not supported, but if a person starts the app, and try with an RTSP URL it should work only the VideoView.
Anyway, I can make a Pull request if you allow me to do that! Best regards!

Oh sorry, I missed that. Sure, you're welcome to open a PR!


[v8] Max in flight flag

Description of the Change
Add the max-in-flight flag to all the commands

LGTM


Implement import-granularity guessing

This renames our MergeBehavior to ImportGranularity as rustfmt has it as the purpose of them are basically the same. ImportGranularity::Preserve currently has no specific purpose for us as we don't have an organize imports assist yet, so it currently acts the same as ImportGranularity::Item.
We now try to guess the import style on a per file basis and fall back to the user granularity setting if the file has no specific style yet or where it is ambiguous. This can be turned off by setting import.enforceGranularity to true.
Closes https://github.com/rust-analyzer/rust-analyzer/issues/8870

Hm, yeah, I think it’s somewhat tricky to define what we actually want here...
I think generally I want to strongly follow defaults (so merging). But if I open someone else’s project, and add import to some existing file, I want it to be consistent.
So perhaps the correct behavior here is “don’t create inconsistent file”? Ie, even if setting day “full”, but the current file uses “none”, we should honor the file rather than the setting?
And then maybe separately have “force” setting to disable the guessing logic?

So perhaps the correct behavior here is “don’t create inconsistent file”? Ie, even if setting day “full”, but the current file uses “none”, we should honor the file rather than the setting?

The problem with this then is that you won't ever get the full/crate logic in new files until you manually merge imports such that the file has a nested import. The other way around would at least work, that is user setting is none/item but the file has full/crate style.

Why? It seems like if there’s only one import, it’s not inconsistent with
any strategy, so any strategy works?
On Tuesday, 18 May 2021, Lukas Wirth @.***> wrote:

So perhaps the correct behavior here is “don’t create inconsistent file”?
Ie, even if setting day “full”, but the current file uses “none”, we should
honor the file rather than the setting?
The problem with this then is that you won't ever get the full/crate logic
in new files until you manually merge imports such that the file has a
nested import. The other way around would at least work, that is user
setting is none/item but the file has full/crate style.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/pull/8873#issuecomment-843446001,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3M6CPFVW3UJES2GQQ5DTOKZCJANCNFSM45DBLZHA
.

Oh I guess I misunderstood you, since you said in that case we should honor the file I thought you meant it as we should fall back to one import per item like the file is using. Forget what I said then that seems like a good approach.

Ah ye now I see my misunderstanding, my mindest was locked into the simple heuristic I got going here which wouldn't always work with that approach. 👍

Turns out getting this right can be quite tricky. Got a basic implementation now but haven't gotten to creating tests yet(nor checked whether this actually works yet).

Alright, the heuristic should be implemented now with some tests, kept crate as the default behavior instead as well now. Happy to take up some more test cases, couldn't come up with more myself currently.

Looks good to me!
Might be a good idea to manually check a couple of crates in the wild, to see if we miss something obvious.


Decision Server Console references updateDSRConfigurations.sh script

https://github.com/ODMDev/odm-ondocker/blob/6e54884ad67cbc5a2d709c620b45e5c874ac0b89/decisionserver/decisionserverconsole/script/run.sh#L20
In the script folder for Decision ServerConsole there  is shell script   updateDSCConfigurations.sh
decisionserver/decisionserverconsole/script/updateDSCConfigurations.sh
however the run.sh script itself references updateDSRConfigurations.sh  instead.

Fixed in the vnext-release branch. Will be available on the next release.


Can't connect to HTPPS Nginx reverse proxy serving a Meteor app

I'm trying to connect to my Meteor backend. When connecting via https, I sometimes get this BufferOverflowException:
Exception in thread "Thread-7" java.nio.BufferOverflowException
      at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:363)
      at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:342)
      at sun.nio.ch.IOUtil.write(IOUtil.java:60)
      at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:471)
      at org.java_websocket.SSLSocketChannel2.close(SSLSocketChannel2.java:270)
      at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:453)
      at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:472)
      at org.java_websocket.WebSocketImpl.eot(WebSocketImpl.java:509)
      at org.java_websocket.client.WebSocketClient.interruptableRun(WebSocketClient.java:249)
      at org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:188)
      at java.lang.Thread.run(Thread.java:745)

When the overflow doesn't happen, I can't connect to the server anyways. I get this .CLOSED message:
{msg=closed, reason=, code=-1, remote=true}
I analyzed the handshake with Wireshark and got this: https://drive.google.com/file/d/0B9cfrkkW62eIWHlzY2oyU0k5cDA/view?usp=sharing
I see the client gets the certificate, but then it doesn't respond with the handshake continuation, it sends a Hello again, and therefore the server resets the connection. I believe this is why the overflow happens, when the timing is right, the client tries to read from an empty socket.
But I'm obviously grasping at straws here, any help would be greatly appreciated. I can contribute with code if somebody pushes me in the right direction.
This is (some relevant part) of my nginx config, but I really doubt it'll do any difference:
# Load Balancing
upstream upstream {
    server <IP_ADDRESS>:3001;
    keepalive 64;
}

# HTTPS
server {
    listen 443 ssl http2;

    ssl_protocols TLSv1.2;
    ssl_ciphers 'EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH';
    ssl_prefer_server_ciphers on;
    ssl_session_cache shared:SSL:2m;
    ssl_dhparam /etc/ssl/certs/dhparam.pem;
    ssl_stapling on;
    ssl_stapling_verify on;
    resolver <IP_ADDRESS> <IP_ADDRESS> valid=300s;
    resolver_timeout 5s;
    add_header Strict-Transport-Security "max-age=63072000; includeSubdomains; preload";
    add_header Public-Key-Pins 'pin-sha256="xxx"; pin-sha256="xxx"; max-age=10';
    ssl_certificate cert.pem;
    ssl_certificate_key key.pem;

    server_name server.com;

    # Proxy Meteor app running locally
    location ^~ / {
        proxy_redirect off;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_set_header Host $http_host;
        proxy_set_header X-NginX-Proxy true;
        proxy_set_header Upgrade websocket;
        proxy_set_header Connection Upgrade;
        proxy_http_version 1.1;
        proxy_pass http://upstream;
    }
}

Yaeah same here

Hello @acib708 and @kirkmicz
do you still have this issue with the latest version?
Greetings
marci4

I got this same error and it seems to be happening cause my cert was expired (but using version 1.3.0). Maybe the same for you guys?

@h3adache the latest version is 1.3.4
Is this still an issue then?

Hi @marci4 it doesn't throw the BufferOverflow anymore but it doesn't give the correct error. It simply disconnects.
The error message is actually swallowed by an exception block that only calls engine.eot()
The linked source above is different because integrated wss support was added. It's L 232/233 in the 1.3.4 code.
The actual exception message is correct it seems:
PKIX path validation failed: java.security.cert.CertPathValidatorException: timestamp check failed

Hello @h3adache,
well at least the error should be displayed and then disconnect.
Opening a seperat issue for this!
Greetings
marci4

Hello @h3adache,
just an update for you.
SSLException will now also call onError ( see #516 )
Closing this issue!
Greetings
marci4


Redefine protocol compilation

Currently, the compiler consolidates a protocol along with all the protocol implementations into an es6 module. This is to make sure that all implementations of a protocol are loaded when a protocol is used.
The problem is that this makes compilation less flexible because the protocol and the implementations have to be available when compilation occurs. This makes it harder to do things such as compile only the code that has changed
This issue is do two things:

[ ] Separate the compilation of a protocol from its implementations. Protocols themselves should still be compiled as es6 modules. Protocol implementations should be compiled in place in whatever module they are defined in.
[ ] Define a way to load compiled JavaScript so that all protocol implementations are ready when a protocol is used.

A possible strategy would be to:

Make each protocol implementation a module
Have the protocol dynamically load an implementation when called.

The biggest problem is the last item. In ES2015, you can only import at the top level scope. It's possible to use System.import, but then that would add a dependency on System.js. It's also possible to change to using the commonjs module system which I think would allow for this. It should not be hard to change to that


handle data alignment in bp_me_axil converters

This modifies bp_me_axil_client|master to add support for sub-data-width requests. This is more of a concern when used for outgoing requests from BP. AXIL expects the data to be placed in the correct byte location and the write strobe to match. BlackParrot top-levels already pack the data correctly, but currently the write strobe is always placed in the least significant bits. On the client side, all possible write masks need to be considered to generate the size of the outbound (to BP) bedrock message. This only really matters for sub-data-width modifications to DRAM or for 32-bit registers that are still located at 32b-aligned addresses.

needs testing before merge


replace FileError with DomError

FileError is deprecated.

Looks fine. I just need to run the tests to make sure everything still works.

All the tests pass but some of the changes you made were actually to generated files. Anything that ends with *-built.js is a file generated by the build. Can you fix this?

Yes.


Investigate ANR percentage count in ANR overview plot

ANR percentage count appears to be incorrect in some cases. Needs looking into.

This issue happened because of other unrelated issues (500 Internal Server Error).


AKCORE-8: Integration tests for Kafka consumer groups in Java (DO NOT MERGE)

About
This PR houses Java code for integration tests of Kafka consumer groups which are already present as PlaintextConsumerTest.scala. The plan is to later reuse this code for Kafka Share Consumers.
Note - The TODOs and the comments are kept inline with what is found in PlaintextConsumerTest.scala

Noticed some Disallowed import [ImportControl] failures in build, looking into it

Took an initial look and left some comments. I am not sure what we are trying to achieve here i.e. Porting existing consumer tests or writing integration tests for share consumer. If former then why, if latter then we should be having tests as per share consumer API itself.

Hi @apoorvmittal10 , since PlaintextConsumerDupTest is the main integration test for KafkaConsumer, hence we need something similar for share groups. However, that test is in Scala. So the question is, could we make a roughly equivalent integration test in Java using pre-existing infrastructure? We don't want to write new code for starting and stopping brokers, for example.
So, in order to test the conversion, I have just converted the tests from Scala to Java for consumer groups. Later on, instead of calling createConsumer which creates the kafka consumer, we will replace it with createShareConsumer which creates share consumers. I did not do that right now because the functionalities that are covered by these tests may not exist so far, hence I won't be able to test whether my conversion was correct or not
cc - @AndrewJSchofield


[build-script-impl] Call the XCTest build_script.py on all platforms

What's in this pull request?
Following up on https://github.com/apple/swift/pull/2137 and https://github.com/apple/swift-corelibs-xctest/pull/97, XCTest's own build script has gotten the capability of performing build and test actions on Darwin as well, so build-script-impl can now delegate to it there, reducing the amount of platform-specific logic here.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Bravo!
apple/swift CI doesn't actually test this XCTest code path--this is the very reason @briancroom made the changes in https://github.com/apple/swift-corelibs-xctest/pull/97--so asking @siwft-ci to test wouldn't provide much benefit here. Still, I guess it couldn't hurt! I'll wait to see a test run before merging.

@swift-ci Please test and merge


Support custom database port through environment DATABASE_PORT env var

Based on example from https://github.com/elixir-ecto/ecto

I have never used elixir, so please double check this is correct.

Well done. Thanks!


CognitoCachingAnonymousCredentialsProvider::GetCredentialsFromCognito() unnecessarily needs account id

Confirm by changing [ ] to [x] below to ensure that it's a bug:

[d ] I've gone though Developer Guide and API reference
[ d] I've searched for previous similar issues and didn't find any solution

Describe the bug
NOTE: this does not happen for the same authentication flow with the .net sdk.
Attempt to use classes derived from Aws::Auth::PersistentCognitoIdentityProvider and Aws::Auth::CognitoCachingAuthenticatedCredentialsProvider without an account id.
There is no way to specify no account id.
FetchCredentialsFromCognito() in CognitoCachingCredentialsProvider.cpp always calls getIdRequest.SetAccountId(accountId);
If accountId is empty, the GetId() call will fail.
Note that AccountId on the underlying REST API is NOT required:
https://docs.aws.amazon.com/cognitoidentity/latest/APIReference/API_GetId.html
SDK version number
Latest, i.e. 1.8.39
Platform/OS/Hardware/Device
Not particularly relevant, but Windows 10
To Reproduce (observed behavior)
See above.
Expected behavior
The c++ SDK should handle the situation the same as the .net SDK.  I.E. there should be a way of specifying no account id.  In this case, the .net SDK checks for a null account id.  Since the c++ SDK uses Aws::String, null is not an option.  However, since the specification for the AccountId in the REST API is "\d+", an empty string would be sufficient to indicate no account id.
In other words, replace:
        GetIdRequest getIdRequest;
        getIdRequest.SetAccountId(accountId);

with:
		GetIdRequest getIdRequest;
		if (!accountId.empty())
		{
			getIdRequest.SetAccountId(accountId);
		}

There is a similar argument to be made for the logins parameter where again, the .net SDK checks the length of the logins array and does not marshal the array if empty.
Fortunately, it is possible to override the GetCredentialsFromCognito() function from CognitoCachingAuthenticatedCredentialsProvider and implement the above change.  However, that is not a good long term solution should anything else in CognitoCachingAuthenticatedCredentialsProvider change.

We are having the same issue with providing an (unnecessary) accountId to the credentials provider - not ideal to distribute account id in our C++ apps, and different from all other SDKs.
Is there any progress on getting this into a new SDK release?
Thanks, Rob.

Correct me if I'm missing something , but the call does require an Identity Id, all that code is trying to do is finding it when it is not provided and using account id to do so. So it's not that accountId is required but that it can be used to fetch the identityId.
So in short, if both the identityId and account Id are both missing, the call should fail right?

Correct me if I'm missing something , but the call does require an Identity Id, all that code is trying to do is finding it when it is not provided and using account id to do so. So it's not that accountId is required but that it can be used to fetch the identityId.
So in short, if both the identityId and account Id are both missing, the call should fail right?

Yes, that's correct, but not the issue here.  We were finding that even when the identity id was provided, that the account id had also to be provided (unnecessarily), and would fail if not.

I concur with @robertmchardy that this is an unnecessary parameter for this use case.

Ok sorry for the confusion I do see the problem.
The root cause is on the cognito's service API . As you say, the getId call will fail if an unacceptable AccountId is part of it, even if the idetity-pool-id is provided, but this happens from the API level.
Having said that, yea the workaround seems valid and way faster than trying to get the service team to fix the model so I'll give it a try.
Thanks for clarifying.

Looks like this may have been fixed in https://github.com/aws/aws-sdk-cpp/commit/b21be81543755fe2d28f4f9d14800992c01ca583

yea, the proposed solution has been added to the SDK, thanks for the info and push to getting this done!


mobile: compile out unavailable builder functions

Title: Unavailable engine builder functions should be compiled out
Description:
Currently it's possible to compile out HTTP/3 and admin interface support from Envoy Mobile, however the engine builder APIs are still available, which could possibly lead to crashes if those features are attempted to be used.
Instead, we should compile out those builder functions, making it harder to misuse.
Relevant Links: Discussion in https://github.com/envoyproxy/envoy/pull/25352#issuecomment-1416502976

cc @alyssawilk


add PUT method to rest-xml protocol

I have tested this method with upload file to S3, and I get error (Code: SignatureDoesNotMatch, Message: The request signature we calculated does not match the signature you provided. Check your key and signing method.)
However, I don't see why signature is wrong, signing is working for GET requests. Error response has CanonicalRequest and StringToSign, canonical request matches with calculated value in request_signers.lua, but string to sign has different hash for canonical request.
Do you see what's wrong?

Ok, so there's definitely a difference between S3 and some other services. Take GameLift as an example. The signatureversion for GameLift says "v4":
https://github.com/britzl/aws-sdk-lua/blob/master/apis/gamelift-2015-10-01.normal.json#L10
While for S3 signatureversion it says "s3":
https://github.com/britzl/aws-sdk-lua/blob/master/apis/s3-2006-03-01.normal.json#L12
The Javascript SDK has all of the signing implementations here:
https://github.com/aws/aws-sdk-js/blob/master/lib/signers/s3.js
There is likely something wrong here:
https://github.com/britzl/aws-sdk-lua/blob/master/aws-sdk/core/request_signer.lua#L182-L185
Compare the Javascript version with the Lua version and see if you can find the problem!

It's probably also a good idea to put the code for each signing implementation into separate Lua modules.

I tried to find difference with ruby and js libraries, but I couldn't. Although I was checking v4.js because I saw a test for s3 service: https://github.com/aws/aws-sdk-js/blob/master/lib/signers/v4.js#L182
However, I have given up with this and wrote a ruby script using aws API, and I call ruby script from lua. I have more experience in ruby and I get it working right now, I don't have that lua script anymore.


Add support for CArray

CArray should add better support for manipulating images of floats/doubles in contrast to dealing with Bufs of integers.
Maybe use multi sub to keep support for both if that will work with is native.

Changed from Blob to CArray in v0.0.4 with 0db1874f64. Chose not to also support Blob. Will reconsider/add if a reason to do so is ever discovered.


[v5] Invoke callback as single object arg

Merge sendBack and receive with other properties on InvokeCallback type.
const callbackLogic = fromCallback(({ input, system, self, sendBack, receive }) => { ... });

Previously
const callbackLogic = fromCallback((sendBack, receive, { input, self, system }) => { ... });

From discussion: https://discord.com/channels/795785288994652170/1133419826111578112/1133503134245859329

Thanks, this looks great! While waiting for @Andarist's feedback, can you write a changeset?
yarn changeset and follow the instructions (minor for xstate)

Could you sync this with next? There are merge conflicts here now (sorry about that!)

Should be good now. Thanks for the heads up.


button text in No repository detected call out overflowed

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  1.93.0
OS Version:  macos

Steps to Reproduce:

Please open an issue on GitLens since that who contributes this button


fix reconciliation ci error on controller restart

Description
This PR fixes #236. On rule addition, we want to check if target address asg exists and report an error if not. On deletion we don't care about this since the related rules must have been cleaned up on asg deletion. A check for deletion or not is added before reporting error.
Changes

Add a parameter and check on building and converting Azure rules, so that asg not found will not report an error on rule deletion.

/nephe-test-e2e-kind /nephe-test-e2e-eks /nephe-test-e2e-aks


there is language options?

there is language options?

I found a solution to modify the vfp_core.js in dist directory.
You can just search and modify the error message with you want, i.e. Chinese Version.

You can overwrite variable "resources" (defined at /src/utils/validators.js).
Example of overwriting a "fieldIsRequired" message:
import VueFormGenerator from 'vue-form-generator'

VueFormGenerator.validators.resources.fieldIsRequired = 'My message'


Rehydrating immutable Map with a top-level reducer

I'm having some trouble getting this persistence working with the basic delayed hydration recipe from redux-persist. I'm having my app delay loading until hydration is finished but my store ends up with only the initialState rather than whatever was persisted. I've got code similar to the following:
import { createStore, compose } from 'redux'
import { persistStore, autoRehydrate } from 'redux-persist-immutable'
import reducer from '../reducers'

const store = compose(autoRehydrate())(createStore)(reducer)

export default class AppProvider extends Component {
  constructor() {
    super()
    this.state = { rehydrated: false }
  }
  componentWillMount(){
    persistStore(store, {}, () => {
      this.setState({ rehydrated: true })
    })
  }
  render() {
    if(!this.state.rehydrated){
      return
Loading...

    }
    return (
      <Provider store={store}>
        <App />
      </Provider>
    )
  }
}

ReactDOM.render(
  <AppProvider />,
  document.getElementById('app')
);

which is basically the exact recipe from redux-immutable. The persistence is working, as I'm seeing the following when pulling from the console:
localStorage
Storage {reduxPersist:games: ""[\"~#iL\",[[\"~#iM\",[\"hero\",\"forestcraft\",\"villain\",\"forestcraft\",\"result\",\"won\"]]]]"", reduxPersist:hero: ""[\"~#'\",\"forestcraft\"]"", reduxPersist:result: ""[\"~#'\",null]"", reduxPersist:villain: ""[\"~#'\",null]"", length: 4}

However this state never ends up in the store. My suspicion is because I only have a single root reducer rather than something built with combineReducers that something is going wrong, but I'm having trouble debugging it. Maybe I'm just doing something wrong?
P.S. My apologies if this isn't the right place to ask for help, but I wasn't sure where best to go.

Figured it out - if initialState isn't set with the keys the reducers expect to work with, rehydration won't load them. My mistake obviously, not something to be handled here.


ryujinx: 1.0.5160 -> 1.0.5320

Motivation for this change
Wanted to check out the latest version
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Looks like #97803 already updated this to a newer version.


Log reports "Received invalid command"

Alarmo Version
v1.8.1
HA Version
2021.12.0
Bug description
Log reporting invalid command, but everything seems to work anyway
Steps to reproduce

Update to 2021.12.0
Check log

Relevant log output
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/connection.py:89
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 11:35:02 (3 occurrences)
Last logged: 11:35:02

[140690784364768] Received invalid command: alarmo_updated
[140690784364768] Received invalid command: alarmo/entities
[140690784364768] Received invalid command: alarmo/config

This occurs when you restart HA and refresh the page before Alarmo is loaded.
Unfortunately there is no way for me to avoid this problem (caused by HA internally), but it is safe to ignore.

I think to have this issue because in the log I found this:
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/connection.py:89
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 09:44:59 (1 occurrences)
Last logged: 09:44:59
[139877262948528] Received invalid command: alarmo_config_updated

Could I ignore it ?
Thanks.