Fix tests and lint; Update .gitignore

Tests do not run for me. Fail with
><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Downloading VS Code 1.88.1 from https://update.code.visualstudio.com/1.88.1/win32-archive/stable
Failed to get VS Code archive location
Failed to run tests

Trying the same URL in the browser yields 404 Not found HTTP error.

The above issue is from the original repo and relates only to Windows.
Can you pull a fix, run npm ci, and rerun tests?

Test suite fails intermittently on consecutive runs.
But the failing test is always branchDidChange should be called with branchNameFromGit. Which is weird when it happens in the title tests.
 *  Executing task: npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Downloading VS Code 1.88.1 from https://update.code.visualstudio.com/1.88.1/win32-x64-archive/stable
Downloading VS Code [==============================] 100%
Downloaded VS Code into C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1

Downloaded VS Code into C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1

[main 2024-04-30T18:05:29.913Z] Error: Error mutex already exists
    at dt.W (C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1\resources\app\out\vs\code\electron-main\main.js:110:68581)
[main 2024-04-30T18:05:29.916Z] update#setState disabled
[main 2024-04-30T18:05:29.916Z] update#ctor - updates are disabled by the environment
Started initializing default profile extensions in extensions installation folder. file:///c%3A/Users/anrdaemon/Documents/.github/branch-in-window-title/.vscode-test/extensions
Started local extension host with pid 13192.
Completed initializing default profile extensions in extensions installation folder. file:///c%3A/Users/anrdaemon/Documents/.github/branch-in-window-title/.vscode-test/extensions
Loading development extension at c:\Users\anrdaemon\Documents\.github\branch-in-window-title

  Branch Detector Integration Test Suite
    From project root path
      ✔ branchDidChange should be called with branchNameFromGit (65ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      ✔ branchDidChange should be called with branchNameFromGit (67ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    ✔ updateTitle should append branch information to title
    ✔ updateTitle should prepend branch information to title
    ✔ updateTitle should remove branch information from title if branch is undefined
    ✔ updateTitle should not call set title operation if the title is unchanged
    ✔ updateTitle should not alter the title if template does not match
  13 passing (237ms)
[main 2024-04-30T18:05:34.706Z] Extension host with pid 13192 exited with code: 0, signal: unknown.
Exit code:   0
Done

 *  Terminal will be reused by tasks, press any key to close it.

 *  Executing task: npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-04-30T18:07:00.365Z] Error: Error mutex already exists
    at dt.W (C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1\resources\app\out\vs\code\electron-main\main.js:110:68581)
[main 2024-04-30T18:07:00.368Z] update#setState disabled
[main 2024-04-30T18:07:00.368Z] update#ctor - updates are disabled by the environment
Started local extension host with pid 14120.
Loading development extension at c:\Users\anrdaemon\Documents\.github\branch-in-window-title

  Branch Detector Integration Test Suite
    From project root path
      ✔ branchDidChange should be called with branchNameFromGit (77ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      1) branchDidChange should be called with branchNameFromGit
      ✔ branchDidChange should be called with branchNameFromGit (149ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    ✔ updateTitle should append branch information to title
    2) branchDidChange should be called with branchNameFromGit
    ✔ updateTitle should prepend branch information to title
    ✔ updateTitle should remove branch information from title if branch is undefined
    ✔ updateTitle should not call set title operation if the title is unchanged
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: A branch is detected
stack trace: AssertionError [ERR_ASSERTION]: A branch is detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:49:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: No branch detected
stack trace: AssertionError [ERR_ASSERTION]: No branch detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:56:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: No branch detected
stack trace: AssertionError [ERR_ASSERTION]: No branch detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:64:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    ✔ updateTitle should not alter the title if template does not match
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: No branch detected
stack trace: AssertionError [ERR_ASSERTION]: No branch detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:96:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: A branch is detected
stack trace: AssertionError [ERR_ASSERTION]: A branch is detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:81:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: No branch detected
stack trace: AssertionError [ERR_ASSERTION]: No branch detected
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:88:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
  13 passing (2s)
  2 failing
  1) Branch Detector Integration Test Suite
       From project root path
         branchDidChange should be called with branchNameFromGit:
     Error: done() called multiple times in test <Branch Detector Integration Test Suite From project root path branchDidChange should be called with branchNameFromGit> of file c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:42:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99

  2) Branch Detector Integration Test Suite
       From project sub folder path
         branchDidChange should be called with branchNameFromGit:
     Error: done() called multiple times in test <Branch Detector Integration Test Suite From project sub folder path branchDidChange should be called with branchNameFromGit> of file c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:74:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99

Error: 2 tests failed.
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\index.js:25:27
        at done (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\node_modules\mocha\lib\mocha.js:1058:7)
[main 2024-04-30T18:07:05.849Z] Extension host with pid 14120 exited with code: 0, signal: unknown.
Exit code:   1
Failed to run tests

 *  The terminal process "C:\Programs\Cygwin\bin\bash.exe '-i', '-c', 'npm run test'" terminated with exit code: 1.
 *  Terminal will be reused by tasks, press any key to close it.

 *  Executing task: npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-04-30T18:07:25.914Z] Error: Error mutex already exists
    at dt.W (C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1\resources\app\out\vs\code\electron-main\main.js:110:68581)
[main 2024-04-30T18:07:25.917Z] update#setState disabled
[main 2024-04-30T18:07:25.917Z] update#ctor - updates are disabled by the environment
Started local extension host with pid 15356.
Loading development extension at c:\Users\anrdaemon\Documents\.github\branch-in-window-title

  Branch Detector Integration Test Suite
    From project root path
      ✔ branchDidChange should be called with branchNameFromGit (87ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      ✔ branchDidChange should be called with branchNameFromGit (81ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    ✔ updateTitle should append branch information to title
    ✔ updateTitle should prepend branch information to title
    1) branchDidChange should be called with branchNameFromGit
    ✔ updateTitle should remove branch information from title if branch is undefined
    ✔ updateTitle should not call set title operation if the title is unchanged
    ✔ updateTitle should not alter the title if template does not match
Error: 1 tests failed.
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\index.js:25:27
        at done (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\node_modules\mocha\lib\mocha.js:1058:7)
  13 passing (360ms)
  1 failing
  1) Branch Detector Integration Test Suite
       From project root path
         branchDidChange should be called with branchNameFromGit:
     Error: done() called multiple times in test <Branch Detector Integration Test Suite From project root path branchDidChange should be called with branchNameFromGit> of file c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\test\suite\branchDetector.test.js:42:17
        at BranchDetector.callIfChanged (c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:36:13)
        at c:\Users\anrdaemon\Documents\.github\branch-in-window-title\out\branchDetector.js:18:99
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[main 2024-04-30T18:07:29.166Z] Extension host with pid 15356 exited with code: 0, signal: unknown.
Exit code:   1
Failed to run tests

 *  The terminal process "C:\Programs\Cygwin\bin\bash.exe '-i', '-c', 'npm run test'" terminated with exit code: 1.
 *  Terminal will be reused by tasks, press any key to close it.

 *  Executing task: npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-04-30T18:07:57.216Z] Error: Error mutex already exists
    at dt.W (C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1\resources\app\out\vs\code\electron-main\main.js:110:68581)
[main 2024-04-30T18:07:57.219Z] update#setState disabled
[main 2024-04-30T18:07:57.219Z] update#ctor - updates are disabled by the environment
Started local extension host with pid 14400.
Loading development extension at c:\Users\anrdaemon\Documents\.github\branch-in-window-title

  Branch Detector Integration Test Suite
    From project root path
      ✔ branchDidChange should be called with branchNameFromGit (72ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      ✔ branchDidChange should be called with branchNameFromGit (72ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    ✔ updateTitle should append branch information to title
    ✔ updateTitle should prepend branch information to title
    ✔ updateTitle should remove branch information from title if branch is undefined
    ✔ updateTitle should not call set title operation if the title is unchanged
    ✔ updateTitle should not alter the title if template does not match
  13 passing (283ms)
[main 2024-04-30T18:08:00.288Z] Extension host with pid 14400 exited with code: 0, signal: unknown.
Exit code:   0
Done

 *  Terminal will be reused by tasks, press any key to close it.

 *  Executing task: npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-04-30T18:09:25.232Z] Error: Error mutex already exists
    at dt.W (C:\Users\anrdaemon\Documents\.github\branch-in-window-title\.vscode-test\vscode-win32-x64-archive-1.88.1\resources\app\out\vs\code\electron-main\main.js:110:68581)
[main 2024-04-30T18:09:25.235Z] update#setState disabled
[main 2024-04-30T18:09:25.235Z] update#ctor - updates are disabled by the environment
Loading development extension at c:\Users\anrdaemon\Documents\.github\branch-in-window-title
Started local extension host with pid 14820.

  Branch Detector Integration Test Suite
    From project root path
      ✔ branchDidChange should be called with branchNameFromGit (71ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      ✔ branchDidChange should be called with branchNameFromGit (71ms)
      ✔ branchDidChange should be called with mocked git branch name
      ✔ branchDidChange should be called with undefined when mocked git branch is undefined
      ✔ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    ✔ updateTitle should append branch information to title
    ✔ updateTitle should prepend branch information to title
    ✔ updateTitle should remove branch information from title if branch is undefined
    ✔ updateTitle should not call set title operation if the title is unchanged
    ✔ updateTitle should not alter the title if template does not match
  13 passing (264ms)
[main 2024-04-30T18:09:28.555Z] Extension host with pid 14820 exited with code: 0, signal: unknown.
Exit code:   0
Done

 *  Terminal will be reused by tasks, press any key to close it.

I couldn't reproduce it on my Windows machine, here are 4 consecutive runs:
st@stk /cygdrive/d/work/vscode-branch-in-window-title-my-fork
$ npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in D:\work\vscode-branch-in-window-title-my-fork\.vscode-
test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-05-01T08:04:23.547Z] update#setState disabled
[main 2024-05-01T08:04:23.548Z] update#ctor - updates are disabled by the enviro
nment
Started local extension host with pid 9116.
Loading development extension at d:\work\vscode-branch-in-window-title-my-fork

  Branch Detector Integration Test Suite
    From project root path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch i
s undefined
      √ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch i
s undefined
      √ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    √ updateTitle should append branch information to title
    √ updateTitle should prepend branch information to title
    √ updateTitle should remove branch information from title if branch is undef
ined
    √ updateTitle should not call set title operation if the title is unchanged
    √ updateTitle should not alter the title if template does not match
  13 passing (105ms)
[main 2024-05-01T08:04:27.284Z] Extension host with pid 9116 exited with code: 0
, signal: unknown.
Exit code:   0
Done

st@stk /cygdrive/d/work/vscode-branch-in-window-title-my-fork
$ npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in D:\work\vscode-branch-in-window-title-my-fork\.vscode-
test\vscode-win32-x64-archive-1.88.1. Skipping download

[main 2024-05-01T08:04:36.895Z] update#setState disabled
[main 2024-05-01T08:04:36.896Z] update#ctor - updates are disabled by the enviro
nment
Started local extension host with pid 3944.
Loading development extension at d:\work\vscode-branch-in-window-title-my-fork

  Branch Detector Integration Test Suite
    From project root path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch i
s undefined
      √ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch i
s undefined
      √ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    √ updateTitle should append branch information to title
    √ updateTitle should prepend branch information to title
    √ updateTitle should remove branch information from title if branch is undef
ined
    √ updateTitle should not call set title operation if the title is unchanged
    √ updateTitle should not alter the title if template does not match
  13 passing (114ms)
[main 2024-05-01T08:04:38.155Z] Extension host with pid 3944 exited with code: 0
, signal: unknown.
Exit code:   0
Done

st@stk /cygdrive/d/work/vscode-branch-in-window-title-my-fork
$ npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in D:\work\vscode-branch-in-window-title-my-fork\.vscode-test\vscode-w
in32-x64-archive-1.88.1. Skipping download

[main 2024-05-01T08:04:58.596Z] update#setState disabled
[main 2024-05-01T08:04:58.597Z] update#ctor - updates are disabled by the environment
Started local extension host with pid 3128.
Loading development extension at d:\work\vscode-branch-in-window-title-my-fork

  Branch Detector Integration Test Suite
    From project root path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch is undefined
      √ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch is undefined
      √ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    √ updateTitle should append branch information to title
    √ updateTitle should prepend branch information to title
    √ updateTitle should remove branch information from title if branch is undefined
    √ updateTitle should not call set title operation if the title is unchanged
    √ updateTitle should not alter the title if template does not match
  13 passing (113ms)
[main 2024-05-01T08:04:59.863Z] Extension host with pid 3128 exited with code: 0, signal: unk
nown.
Exit code:   0
Done

st@stk /cygdrive/d/work/vscode-branch-in-window-title-my-fork
$ npm run test

><EMAIL_ADDRESS>pretest
> npm run compile && npm run lint

><EMAIL_ADDRESS>compile
> tsc -p ./

><EMAIL_ADDRESS>lint
> eslint src --ext ts

><EMAIL_ADDRESS>test
> node ./out/test/runTest.js

Found existing install in D:\work\vscode-branch-in-window-title-my-fork\.vscode-test\vscode-w
in32-x64-archive-1.88.1. Skipping download

[main 2024-05-01T08:05:29.454Z] update#setState disabled
[main 2024-05-01T08:05:29.455Z] update#ctor - updates are disabled by the environment
Started local extension host with pid 5080.
Loading development extension at d:\work\vscode-branch-in-window-title-my-fork

  Branch Detector Integration Test Suite
    From project root path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch is undefined
      √ branchDidChange should be called with undefined when exception is thrown
    From project sub folder path
      √ branchDidChange should be called with branchNameFromGit
      √ branchDidChange should be called with mocked git branch name
      √ branchDidChange should be called with undefined when mocked git branch is undefined
      √ branchDidChange should be called with undefined when error is thrown
  Title Updater Test Suite
    √ updateTitle should append branch information to title
    √ updateTitle should prepend branch information to title
    √ updateTitle should remove branch information from title if branch is undefined
    √ updateTitle should not call set title operation if the title is unchanged
    √ updateTitle should not alter the title if template does not match
  13 passing (116ms)
[main 2024-05-01T08:05:30.725Z] Extension host with pid 5080 exited with code: 0, signal: unk
nown.
Exit code:   0
Done

I'm not sure if that will help, you can try to remove out/ tests folder manually and run npm run test again so it will regenerate fresh out/, maybe there's some cache from old tests.

I did a full cleanup. Will try updating node and see if it'd help.

I think I've found a workaround.

Part of the answer was in the https://stackoverflow.com/questions/47252219/event-based-unit-tests-fail-with-done-called-multiple-times
As far as I understand it, the very first branchDetector() call creates a disposable, which is still running through the rest of the testing suite, calling update callback over and over again. Explicitly disposing it in the success callback cleans the area up.

Interesting, what node --version do you use? Mine is 18.16.0, maybe it occurs only on lower node versions.

$ node --version
v18.15.0

Though I distinctly remember running 18.20 installer to completion…
Rechecked with 18.20 now, same issue remains if I commend out detector disposing.

I see, thanks for testing it out, then less likely related to node version.


Checkboxes aren't converted properly

Application/script

Version: v0.6.6

Describe the bug
At the moment checkboxes are converted to * ☐ after Zim's markdown export (this script seems not to alter them), but they actually should be converted to - [ ] to be rendered properly and be clickable in Obsidian. And * ☑ checked off checkboxes should be formatted to - [x].
Zim has 3 states of checkboxes that Obsidian isn't supporting:
[x] cross (note that this checkbox marks dismissed, or whatever you call them, checkboxes, while checked off checkboxes are written as [*] in Zim, so don't confuse it with checked off checkboxes in Obsidian, which are written as `- [x]`
[>] arrow right
[<] arrow left

Since Obsidian will still render checkboxes with a letter or sign between the square brackets (like - [c] or - [>]) as an actionable checkbox, but in this case only the checkbox itself will be filled and the appropriate text won't be crossed out, as it would be the case with a - [x] checkbox, I still suggest converting those checkboxes as follows:
* ☒ cross should be converted to - [c] (because x is already taken and X might lead to confusion)
* ▷ arrow right should be converted to - [>]
* ◁ arrow left should be converted to - [<]
Execution environment (please complete the following information):

Python Version: Python 3.11.2
OS: Ubuntu 23.04

This is how Zim's markdown export looks like:
* ☐ Unchecked
* ☑ Checked
* ☒ Cross-checked
* ▷ Arrow right
* ◁ Arrow left

To replace with:
- [ ] Unchecked
- [*] Checked
- [c] Cross-checked
- [>] Arrow right
- [<] Arrow left

The replacements can be done in various ways.
My suggestion:
checkboxes = {
                 '* ☐' : '- [ ]',
                 '* ☑' : '- [*]',
                 '* ☒' : '- [c]',
                 '* ▷' : '- [>]',
                 '* ◁' : '- [<]',
                  }

for c in checkboxes:
    if line.startswith(c):
        line = f'{checkboxes[c]}{line[3:]}'

Right. I fixed the comment, sorry. However, the code is correct as you can see.
I would really like to encourage you to learn Python. As you can see, It's a language made for text processing.
The changes for v0.8.0 are a 10-minutes-job, and the code is a beginner's exercise.
I implemented the change using the test driven development method:
First I prepared the test files, so the specification was set. Then I implemented the algorithm, and running the test script, I made sure that it works.

I would really like to encourage you to learn Python. As you can see, It's a language made for text processing.

I already have too much going on right now, so learning Python, even on a basic level, would worsen the situation even more. Although I could imagine learning it in the near future, if time will permit.
There are still issues with those checkboxes:

If checkboxes are indented, then conversion fails, see:

[ ] checkboxes aren't converted properly when indented
	[ ] example
		[ ] another example

In this example, the second and third checkbox won't be converted properly. Might be connected to https://github.com/peter88213/zim2obsidian/issues/11

Zim's markdown export adds a new line before and after each line with a checkbox, except between consecutive checkboxes, see the following:

==== Header 3 ====
[ ] before this line a new line will be created
[ ] example
[ ] after this line a new line will be created

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
[ ] before and after this line a new line will be created

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
	[ ] and before this indented checkbox, a new line will be created before and after this line

In order not to get confused, we have to strictly distinguish between what Zim can (and cannot) export and the function of the zim2obsidian postprocessor.
As you can see from the code, the postprocessor only converts checkboxes at the beginning of lines that are preceded by a bullet. This is the way it is with Zim's to-do lists. At the moment I just don't see any sense in having several checkboxes on one line, or indented checkboxes, but who wants to can of course extend the post-processor's behavior at will.
I haven't yet tried whether Obsidian lets you indent lines with tabs at all; Markdown, as I mentioned, doesn't provide for that. It's also not my style to write that way.
If Zim allows more formatting options than standard Markdown, it's just not fair to call it a bug of the conversion if everything doesn't transfer one-to-one to Obsidian.

I haven't yet tried whether Obsidian lets you indent lines with tabs at all; Markdown, as I mentioned, doesn't provide for that. It's also not my style to write that way.

It does:

Written in Markdown in Obsidian:
- [ ] example
	- [x] example
		- [ ] example

As you can see from the code, the postprocessor only converts checkboxes at the beginning of lines that are preceded by a bullet. This is the way it is with Zim's to-do lists. At the moment I just don't see any sense in having several checkboxes on one line, or indented checkboxes, but who wants to can of course extend the post-processor's behavior at will.

So I assume the proper way would be to report those issues in Zim?

So I assume the proper way would be to report those issues in Zim?

In Zim, feature requestsd should only be reported under "Issues" if you have finished code to offer for solution.
If you want formatting converted that works in both Zim and Obsidian, but doesn't transfer via standard Markdown, the correct approach would be @pschwede's. Perhaps someone will be found to further develop his script. The difficulty I see with this is that he has not included any copyright or licensing information. One could consider his code as "public domain", but there is no such thing under German law (I guess, he's German).
What you can definitely do is post your requirements for his script as Issues. But be polite: call it a bug only if the program crashes or makes complete nonsense. If something you want is not converted, call it "missing feature".

But be polite: call it a bug only if the program crashes or makes complete nonsense. If something you want is not converted, call it "missing feature".

Wasn't aware that writing feedback in a bug report could be perceived as impolite, if you take the current issue as an example. That was not my intention. I was looking at it more from a point of view of efficiency, having everything related in one place.

If you want formatting converted that works in both Zim and Obsidian, but doesn't transfer via standard Markdown, the correct approach would be @pschwede's.

Your awesome script already does nearly a perfect job. Only the issues with indentations and the checkboxes are left and we are good to go. So in this situation, switching to another approach would be counterintuitive. And the elegance of your approach is already unmatched.

Well, as we know now, Indentiations with tab characters cannot transferred via Markdown.
Tabs are not part of the Markdown specification. So there's no point in asking for tab support in Zim's Markdown export.
What I could imagine would be a "dirty hack". One could edit the original Zim notebook with a preprocessor and replace all tab characters with a special code. Then export with Zim and post-process with zim2obsidian. Then at the very end, have the special codes in the Markdown files replaced with tab characters again.
The necessary scripts could easily be generated by modifying zim2obsidian functions.

In continuation of this issue regarding the appearance of new empty lines:
Currently, Zim's markdown export adds new empty lines before and after already present text lines starting with checkboxes, numbered and unnumbered lists. Take this Zim source as example describing where new lines will appear:
==== Header 3 ====
[ ] before this line a new line will be created
[ ] example
[ ] after this line a new line will be created

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
[ ] before and after this line a new line will be created

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
	[ ] and before this indented checkbox, a new line will be created before and after this line

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
1. before and after this line a new line will be created

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
* before and after this line a new line will be created

Do you think that this should be reported upstream in Zim or maybe there could be also a hackish solution to it, like done with indentations?

I think this is because in Markdown a line break is represented by a blank line.
Bullet points are the exception, but checkboxes don't count as bullet points in Markdown.
If you indent checkboxes in Zim so that there is no bullet at the beginning of the line, the Markdown exporter will correctly insert a blank line.
Whatever way you want to solve this, it is not an issue for Zim.

I guess, Zim's Markdown exporter inserts the bullet points only before checkboxes at the beginning of a line, in order to generate a Markdown To-Do-List.
Processing multi-level check lists turns out to be a complicated task. At the moment, there is probably nothing left to do but rework manually.

Bad news, but let's see what time will bring. Maybe somebody else has an idea.
Thanks for the work you've already done!


Pick/Drillpick returns wrong (polygon) entity

I have an example where the wrong polygon out of the two on the screen gets picked.
This happens on/off, and more often in some areas than others when clicking.
In the example I randomize the colour of the picked entity.
If you can't recreate the issue from my sandcastle please watch my gif and see where I am clicking. Don't move the initial camera position as it occurs more often at close-to-ground camera angles.
Gif of issue in the example sandcastle
Sandcastle example
Browser: Firefox and Edge
Operating System: Windows 11

Thanks for the report @matvey-tk.
Your example works if you change it slightly so that the last object in the picked list is selected. This is because sometime a single object is returned, and sometimes both objects are.
I think this is a duplicate of https://github.com/CesiumGS/cesium/issues/9753. I'll close this issue to keep the discussion in one place.

@ggetz all fine if it's a duplicate, I'll be rooting for a fix!
To clarify. This was just an example and in real data there are lots of cases with multiple entity overlaps, I can't just grab the bottom of the drill result instead of the top. It'll end up selecting the wrong thing even more often!


Add accessibilityLabel parameter to Text

There are many cases where one wants a screenreader to read out something different from the visual text. The most common case is when the visual text is an abbreviation. The screenreader should then read out the full text. This is achievable now, but it's tedious:
new Semantics(label: fullText,
   child: new ExcludeSemantics(
     child: new Text(abbreviation)
  )
)

We should add an accessibilityLabel parameter to Text that has the same effect.

/cc @jonahwilliams @goderbauer


added final screen

this is not what i was looking for. I wanted a counter option with respect to the quests given a person can skip it, work on it or complete it. With each completed quest, their chance of getting a good ending increases


Publish a Resolved Manifest

Ko should support publishing a resolved manifest in an image alongside the released images.
Ideally, this functionality would support a custom base-image (or maybe directory structure) and a location in that image to put the resolved manifest.
This should allow users to publish Helm3 compatible OCI chart images, and GCP Marketplace App Packages if the right deployer was used.

Can you describe what you mean by "resolved manifest"?
This seems possible today with ko resolve, see the Relevance to Release Management section in the README.

Sure, I do mean storing the results of ko resolve in a container next to the other containers that were generated by resolve. This would allow ko to be "atomic".
Since the resolved YAML is in a container, you can easily tag it, manage ACLs with the other images, and allow other containers to be built from it e.g. a Helm chart or GKE App Package which is basically a home-rolled version of the operator pattern.

Closing this in favor of: https://github.com/google/ko/issues/128 as that would suit out needs equally well


fix(module-tools): do not do stringify define internally

Summary
To align with the behavior on document and most other tools' define convention.
Related Links

Checklist

[x] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

!canary


Stop uploading code coverage from non-pull request CI runs

We only care about code coverage in PRs so let's save some CI time and stop doing this for non-pull request CI pipelines.

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on code_coverage_ci at 56.845%

Totals

Change from base Build<PHONE_NUMBER>1:
56.8%

Covered Lines:
11880

Relevant Lines:
19869

💛  - Coveralls

It seems this broke coverage reports on pull requests. I guess we need to upload coverage results on pushes to master so pull requests targeting master have a baseline for comparison.


Added google translation extension

#364
Added google translate extension.

Your code is missing a '{', so add it. The issue might be caused by the JSON file format. Additionally, make the tool description shorter.

Can you assign the issue #364 .


Sync tables generate duplicated cartodb_id index - Take II

Closes https://github.com/CartoDB/cartodb/issues/6031

@juanignaciosl CR again please. Now the query planner seems to be happy with it :)

:+1: other than precedence suggestion.


deep learning and matrix calculus

ceras is a deep learning engine in C++20;
matrix is a 2D matrix lib in C++20.

make a pr on it

@phoebe-leong I have created a pr, please kindly review it.


Custom naming convention with the Accelerator

I am deploying a landing zone in production on 7/6 and would like to get custom naming in place before we go live. Is this something I can do within Accelerator? If not, do you have a suggestion how I might be able to do it still leveraging the accelerator?
I want the customer to use the accelerator during app migrations but we need to figure out the custom naming.
Any help would be appreciated

Hey @bradcart1971,
Thanks for reaching out. If you want to use custom naming then I suggest looking at the ALZ-Bicep project to deploy Azure landing zones.
This project allows you to specify custom naming for all objects/resource is that you wish to deploy.
Custom naming isn't possible in the Portal Experience Accelerator today.
Thanks
Jack


Lock node image to 8

Latest node image (10.12.0) is incompatible with<EMAIL_ADDRESS>dep - lock to node 8 image until it's updated
Looks like<EMAIL_ADDRESS>fixes it so probably not a hard one.
Error message:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "10.12.0"

Goog works @zorfling! Thanks!


Hubble-ui now supports imagePullSecrets

Currently there is no way to specify pull secrets for the hubble ui deployment.
Hubble-ui now supports imagePullSecrets being passed in

test-me-please

retest-1.20-4.9


Allow grouping specifiers in -f

Requested in #5242. For example I use bestvideo[height<=?1080][width<=?1920][ext!=?webm]/best[height<=?1080][width<=?1920],bestaudio, which can be written now as (bestvideo[ext!=?webm]/best)[height<=?1080][width<=?1920],bestaudio.
Since I thought that using regexes would be hard, I decided to use tokenize.tokenize to split the spec in strings and operators (it also checks if there are missing brackets or parenthesis). I admit that the implementation is a bit ugly, so we may want to rethink it or clean it (maybe moving it to utils.py), but it works. The filters (everything inside []) is still processed with the same regexes, because it's simpler and I haven't thought of an alternative implementation.
@haasn your string (bestvideo[tbr<13000][height>720]/bestvideo[tbr<13000][fps>30])+(bestaudio[ext=webm]/bestaudio) seems to be parsed correctly, but I'd like to verify it works as expected.

I didn't quite look into the code, but looks like it breaks downloading at all when there are no video/audio-only formats.
python -m youtube_dl M2mST8OFUNo --youtube-skip-dash-manifest -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'M2mST8OFUNo', u'--youtube-skip-dash-manifest', u'-v']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2015.06.25
[debug] Git HEAD: b86b58c
[debug] Python version 2.7.9 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-71608-ga924b83, ffprobe N-71608-ga924b83, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] M2mST8OFUNo: Downloading webpage
[youtube] M2mST8OFUNo: Downloading video info webpage
[youtube] M2mST8OFUNo: Extracting video information
[youtube] M2mST8OFUNo: Downloading formats manifest
ERROR: requested format not available
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.py", line 667, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "youtube_dl\YoutubeDL.py", line 713, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "youtube_dl\YoutubeDL.py", line 1271, in process_video_result
    expected=True)
ExtractorError: requested format not available

python -m youtube_dl M2mST8OFUNo --youtube-skip-dash-manifest -v -F
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'M2mST8OFUNo', u'--youtube-skip-dash-manifest', u'-v', u'-F']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2015.06.25
[debug] Git HEAD: b86b58c
[debug] Python version 2.7.9 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-71608-ga924b83, ffprobe N-71608-ga924b83, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] M2mST8OFUNo: Downloading webpage
[youtube] M2mST8OFUNo: Downloading video info webpage
[youtube] M2mST8OFUNo: Extracting video information
[youtube] M2mST8OFUNo: Downloading formats manifest
[info] Available formats for M2mST8OFUNo:
format code  extension  resolution note
151          mp4        72p        HLS
132          mp4        240p       HLS
92           mp4        240p       HLS
93           mp4        360p       HLS
94           mp4        480p       HLS  (best)

With latest git it does work as usual:
python -m youtube_dl  M2mST8OFUNo --youtube-skip-dash-manifest -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'M2mST8OFUNo', u'--youtube-skip-dash-manifest', u'-v']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2015.06.25
[debug] Git HEAD: 9d0b581
[debug] Python version 2.7.9 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-71608-ga924b83, ffprobe N-71608-ga924b83, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] M2mST8OFUNo: Downloading webpage
[youtube] M2mST8OFUNo: Downloading video info webpage
[youtube] M2mST8OFUNo: Extracting video information
[youtube] M2mST8OFUNo: Downloading formats manifest
[debug] Invoking downloader on u'https://manifest.googlevideo.com/api/manifest/h
ls_playlist/id/M2mST8OFUNo.1/itag/94/source/yt_live_broadcast/requiressl/yes/rat
ebypass/yes/live/1/cmbypass/yes/gir/yes/dg_shard/TTJtU1Q4T0ZVTm8uMQ.94/hls_chunk
_host/r3---sn-ug5onuxaxjvh-v8ce.googlevideo.com/playlist_type/DVR/pmbypass/yes/g
cr/ru/mm/32/mn/sn-ug5onuxaxjvh-v8ce/ms/lv/mv/m/pl/22/dover/2/upn/fmfVUCnQAJ4/fex
p/901816,916633,9407141,9408142,9408211,9408255,9408420,9408710,9408938,9409180,
9412773,9413503,9414764,9414871,9416126,9416179,9416359,952640/rcc/1/sver/3/mt/1
435679826/ip/PRIVATE/ipbits/0/expire/1435701466/sparams/ip,ipbits,expire,i
d,itag,source,requiressl,ratebypass,live,cmbypass,gir,dg_shard,hls_chunk_host,pl
aylist_type,pmbypass,gcr,mm,mn,ms,mv,pl/signature/302E78F3164A257D4B70EC3D1D4DE4
951342CE77.77AC5112142EEC7F6C102B583C08995033EA6B4C/key/dg_yt0/playlist/index.m3
u8'
[download] Destination: Brooks Falls - Katmai National Park, Alaska powered by E
XPLORE.org-M2mST8OFUNo.mp4
ffmpeg version N-71608-ga924b83 Copyright (c) 2000-2015 the FFmpeg developers
  built with gcc 4.9.2 (GCC)
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-av
isynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enab
le-iconv --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --
enable-libdcadec --enable-libfreetype --enable-libgme --enable-libgsm --enable-l
ibilbc --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enab
le-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-librtmp --en
able-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --ena
ble-libtwolame --enable-libvidstab --enable-libvo-aacenc --enable-libvo-amrwbenc
 --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enabl
e-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-lzma --ena
ble-decklink --enable-zlib
  libavutil      54. 23.101 / 54. 23.101
  libavcodec     56. 35.101 / 56. 35.101
  libavformat    56. 30.100 / 56. 30.100
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 14.100 /  5. 14.100
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  1.100 /  1.  1.100
  libpostproc    53.  3.100 / 53.  3.100
Input #0, hls,applehttp, from 'https://manifest.googlevideo.com/api/manifest/hls
_playlist/id/M2mST8OFUNo.1/itag/94/source/yt_live_broadcast/requiressl/yes/rateb
ypass/yes/live/1/cmbypass/yes/gir/yes/dg_shard/TTJtU1Q4T0ZVTm8uMQ.94/hls_chunk_h
ost/r3---sn-ug5onuxaxjvh-v8ce.googlevideo.com/playlist_type/DVR/pmbypass/yes/gcr
/ru/mm/32/mn/sn-ug5onuxaxjvh-v8ce/ms/lv/mv/m/pl/22/dover/2/upn/fmfVUCnQAJ4/fexp/
901816,916633,9407141,9408142,9408211,9408255,9408420,9408710,9408938,9409180,94
12773,9413503,9414764,9414871,9416126,9416179,9416359,952640/rcc/1/sver/3/mt/143
5679826/ip/PRIVATE/ipbits/0/expire/1435701466/sparams/ip,ipbits,expire,id,
itag,source,requiressl,ratebypass,live,cmbypass,gir,dg_shard,hls_chunk_host,play
list_type,pmbypass,gcr,mm,mn,ms,mv,pl/signature/302E78F3164A257D4B70EC3D1D4DE495
1342CE77.77AC5112142EEC7F6C102B583C08995033EA6B4C/key/dg_yt0/playlist/index.m3u8
':
  Duration: N/A, start: 38.114000, bitrate: N/A
  Program 0
    Metadata:
      variant_bitrate : 0
    Stream #0:0: Video: h264 (Main) ([27][0][0][0] / 0x001B), yuv420p, 854x480 [
SAR 1:1 DAR 427:240], 30 fps, 30 tbr, 90k tbn, 60 tbc
    Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, flt
p, 127 kb/s
[mp4 @<PHONE_NUMBER>e53900] Codec for stream 0 does not use global headers but cont
ainer format requires global headers
[mp4 @<PHONE_NUMBER>e53900] Codec for stream 1 does not use global headers but cont
ainer format requires global headers
Output #0, mp4, to 'Brooks Falls - Katmai National Park, Alaska powered by EXPLO
RE.org-M2mST8OFUNo.mp4.part':
  Metadata:
    encoder         : Lavf56.30.100
    Stream #0:0: Video: h264 ([33][0][0][0] / 0x0021), yuv420p, 854x480 [SAR 1:1
 DAR 427:240], q=2-31, 30 fps, 30 tbr, 90k tbn, 90k tbc
    Stream #0:1: Audio: aac ([64][0][0][0] / 0x0040), 48000 Hz, stereo, 127 kb/s

Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
frame=  148 fps=108 q=-1.0 size=     736kB time=00:00:05.03 bitrate=1198.6kbits/
frame=  296 fps=100 q=-1.0 size=    1476kB time=00:00:10.02 bitrate=1206.3kbits/
frame=  444 fps= 54 q=-1.0 size=    2213kB time=00:00:15.03 bitrate=1205.8kbits/
frame=  592 fps= 61 q=-1.0 size=    2952kB time=00:00:20.02 bitrate=1207.5kbits/
frame=  740 fps= 45 q=-1.0 size=    3690kB time=00:00:25.02 bitrate=1208.1kbits/
s
ERROR: Interrupted by user

It should be fixed with https://github.com/jaimeMF/youtube-dl/commit/cf2ac6df6896dac4d23918867bb86fac1e1088d9. The code is not pretty, feel free to criticize all you want.

Is this going to be merged soon, and could it please incorporate #5581?

LGTM. Good job.
The only thing to do is to update the docs.

Thanks for the suggestions, updating the docs was in my TODO list.

Is this going to be merged soon, and could it please incorporate #5581?

I'll try to take a closer look into your PR after we merge this and adjust it.

Is this ready for merge or there is still something to do?

I fixed all the issues you found, I think there's nothing else to add. I'll merge if you find it OK.

Ok, go for it.

Actually, there are still some ill-handled cases, though admittedly rather nonsensical:

-f '/'
-f 'bestvideo+bestvideo+bestvideo', -f '(bestvideo+bestvideo)+bestvideo'
-f 'bestvideo+bestvideo' (downloads fine, but merging gives an ffmpeg error message)
-f 'bestvideo+(bestvideo,bestvideo+bestvideo)' (as above; what does it even mean anyway?)
-f 'bestvideo+(bestvideo,bestvideo)' (as above)
-f '(bestvideo,bestvideo)+bestvideo' (as above)

-f '/'

Fixed in d96d604e5311628ece0234733dbbfe73a58c8d18

-f 'bestvideo+bestvideo+bestvideo', -f '(bestvideo+bestvideo)+bestvideo'

With the old version I get ValueError: too many values to unpack, it's equally unfriendly in both.

-f 'bestvideo+bestvideo' (downloads fine, but merging gives an ffmpeg error message)

Same error in both versions, nothing new.

-f 'bestvideo+(bestvideo,bestvideo+bestvideo)'

It's equivalent (bestvideo+bestvideo),(bestvideo+bestvideo+bestvideo), it fails as the above.
The other two examples are the same.
You should open new issues so that we can keep track of them.


Only migrate Simple and ReversibleUp in Migrator.run()

I was just bit by the issue in #863 when using both up and down migrations, and this seemed like an easy fix. I'm not 100% sold on this initial way of solving it, so I'm very open for suggestions.

First glance this looks fine as a fix.. However, this looks like it conflicts with https://github.com/launchbadge/sqlx/pull/1061 but this fix looks like its missing in #1061.
@zshell31, you mentioned you tested reversing migrations – am I correct in thinking that #863 is fixed in a different way in your PR?

Unfortunately I tested reversing migrations only using sqlx-cli. I've just added the fix into my PR and retested the macro.

Just my 2cents. I experimented the same issue then I just provide a quick workaround waiting for this fix for people who need to find a solution.
let mut migrator = sqlx::migrate!();
        let migrations: Vec<Migration> = migrator
            .migrations
            .iter()
            .filter(|m| matches!(m.migration_type, MigrationType::ReversibleUp))
            .cloned()
            .collect();
        migrator.migrations = Cow::from(migrations);
        migrator.run(&db_pool).await?;

This is fixed in #1030.


Autoplay ignores rtl #197

A simple condition on this.props.rtl to choose between adding or subtracting to determine the next slide.

Thanks @ranbena  for PR


various behaviour observed while creating folder with @name.conflictBehaviour "OneDrive for Business"

@ankit-ankuagrawal: Thanks for reporting this. As mentioned in our release notes we don't support the @name.conflictBehavior attribute for ODB yet.


MUSCLEBAN acquisition with code greater than 0x03

Dear all, I can acquire data from muscleban with this scripts, only for channel 0 and 1. When I try to acquire channel 2 or greater, always give me the same error
---> 16     device.start(device.frequency, code, 16)
17     device.loop()  # calls device.onRawFrame until it returns True
18     device.stop()
RuntimeError: Invalid operation on current device state (code 15).

Dear ilatasaied,
Could you tell me, code-wise, how are you calling the exampleAcquisition function in the three cases (only for channel 0, only for channel 1 and only for channel 2) ?
Thank you!

I test before with "opensignals" and I can acquire 8 channels of Muscleban, but with python it's not possible to acquire all muscleban channels.
I attach you and Jupyter notebook
01 one device acquisition.zip

Dear ilatasaied,
This script is mainly prepared to work with biosignalsplux devices. To use muscleban fully with this script you have to perform a few changes. Below, you can see a working example of those changes:
`def getSources(activeChannels, resolution):
sources = []
if 1 in activeChannels:
    src = plux.Source()
    src.port = 1
    src.nBits = resolution
    src.chMask = 1
    sources.append(src)
    activeChannels.remove(1)

if len(activeChannels) > 0:
    src = plux.Source()
    src.port = 2
    src.nBits = resolution
    src.chMask = sum(2 ** (np.array([chn - 2 for chn in activeChannels])))
    sources.append(src)

return sources

#second Accelerometer channel
activeChannels = [3]
#three magnetometer channels
#activeChannels = [5, 6, 7]
resolution = 16
sources = getSources(activeChannels, resolution)
exampleAcquisition("BTH58:8E:81:A2:4A:53", 5, 1000, sources)`
Hope this information can be helpful for you!

Thanks, it runs!


some monitors only seem to allow input switching when the PC is on the active input

I have two Dell U2412M monitors and a Dell E2417H. All three are connected to my PC via Displayport.
I can use swmon to change their inputs away from my PC (e.g., I can do swmon switch -m 2 vga1 to switch to VGA). However, once I do so, the monitor never shows up in swmon list nor can I change the input back via swmon switch; I have to use the front panel to change the input back. Once I change the active input back to Displayport, swmon is able to detect and control the monitor again.
As far as it seems, at least these two models of Dell monitors (and probably others of similar vintage?) only appear to respond to DDC on the active input, and ignore it on inactive inputs. My presumption is that this is a monitor firmware issue and that there's probably nothing that can be done about this in swmon, but is possibly worthy of a documentation note.

We probably need a database, similar to https://github.com/ddccontrol/ddccontrol-db, except license compatible (their database is GPL) and more focused (don't need all the options). Also, something more friendly to the Serde data model than XML :P?


add and link libcurl

Hmmm somebody said they need vcpkg to link libcurl directly instead of using curl. So here is an example how to implement that. (https://github.com/microsoft/vcpkg-tool/pull/1043)

Don't quite understand why recv is unavailable in linux CI.

I think assuming libcurl.so will work is 'safe' on *nix?
My main concern with this is accidentally embedding 'which OpenSSL are you using' assumptions into our binaries, but we should be able to use the system's bundled libcurl.so as a firewall for this.

(That is to say, on Windows, static link libcurl and use schannel backend, and rip out all the WinHTTP stuff. On non-Windows, use the system's libcurl.so. Then we can statically link the real Azure Storage SDKs to get sane uploads of >5TB. Does that seem reasonable to you?)

@BillyONeal: Feel free to edit. I just made this PR to enable others who want to explorer this way. Probably just replace option(VCPKG_DEPENDENCY_EXTERNAL_LIBCURL "Use an external version of the libcurl library" OFF) with a platform dependent ON/OFF.  use schannel backend don't know the option for it but it is probably in the portfile of curl somewhere.

Does that seem reasonable to you?

hmm maybe? I honestly have no clue what you are talking about. As I said, I just made this PR to enable others.


Where can I see the runtime of each set of parameters?

After I finished executing the benchmark, I attempted to view the time spent on each query, but the resulting file contained two that were not what I needed：
”LDBC SNB results. json“ contains aggregated information of different query results, and I am not aware of the results of each query.
”LDBC-SNB results_ Log. csv "displays the time used for each query, but the reference information it provides still does not include the content of a specific query, it only includes the statement type of the query.

If I want to know which query parameter and how long does the query statement take to run, how should I proceed?

I don't think we save the parameter - runtime combinations because it would result in excess disk IO.
@GLaDAP knows the internals of the more about the internals of the benchmark, so adding him to cc.

Okay, thank you for your answer. I have added code logging in the implementation section myself


Add command options for Start and End of Transaction query

Add command options for Start and End of Transaction query.
-s VALUE      index of transaction to start on for the export.  Default start is 0
-e VALUE      index of transaction to end on for the export.   Default end is 999999

Added in v0.3.0


Positioning vs. setuptools-py2cfg

How is this project better than setuptools-py2cfg?
What are the reasons to choose one tool over the other?
https://pypi.org/project/setuptools-py2cfg --> https://github.com/gvalkov/setuptools-py2cfg

Hi there.
No idea, honestly! I wasn't aware of that project when I wrote this tool for my own uses 9 months ago. :)


Update fields emitted

This series updates the Standards-Version field version, and switches from the Built-Using to the Static-Built-Using field, following the migration done in the dh-golang package.

Thank you!


Application error

Dev:

lib/utils.ts (12:20) @ countGraphemeForTwitter

  10 |
  11 | export const countGraphemeForTwitter = (str: string) => {
> 12 |   const segmenter = new Intl.Segmenter('ja', { granularity: 'grapheme' });
     |                    ^
  13 |   const partition = devideString(str);
  14 |
  15 |   return partition.reduce((count: number, text: string): number => {

Production:

TypeError: Intl.Segmenter is not a constructor
    NextJS 11
        I
        G
        Eo
        xi
        bs
        gs
        vs
        as
        ls
        S
        T
[framework-4556c45dd113b893.js:1:71883](http://always.voring.me/_next/static/chunks/framework-4556c45dd113b893.js)
TypeError: Intl.Segmenter is not a constructor
    NextJS 11
[main-ef9379c68abd1065.js:1:8788](http://always.voring.me/_next/static/chunks/main-ef9379c68abd1065.js)
    NextJS 13
A client-side exception has occurred, see here for more info: https://nextjs.org/docs/messages/client-side-exception-occurred [main-ef9379c68abd1065.js:1:8805](http://always.voring.me/_next/static/chunks/main-ef9379c68abd1065.js)
Uncaught Error: Minified React error #423; visit https://reactjs.org/docs/error-decoder.html?invariant=423 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    NextJS 8
[framework-4556c45dd113b893.js:1:121812](http://always.voring.me/_next/static/chunks/framework-4556c45dd113b893.js)
    NextJS 6
        xi
        bs
        gs
        vs
        as
        ls
    ls self-hosted:1162
    NextJS 2

Probably due to a low version of Node.js.
I think that setting the Node.js version to 18 or higher will solve the problem.

My NodeJS version is 18.4.0 though.

The error seems to be caused because Intl.Segmenter is not implemented in Firefox.
Fixed in ebfb8c7f3d8f109c3dbb6dc6575d7e0c73dbfca2 and 8a1827da1b7af68bc453c6505dd58a3bde3a16e5.


WIP Looking For Brittle Tests WIP

Removed rspec-retry on this branch to give more insight into what is happening in the logs and let us look for brittle tests.
The goal isn't to merge this branch but to have a branch without spec-retry on it and to run the GitHub actions rspec workflows to look for test issues.

I think we can close this now. Most of the flaky specs have been addressed I believe.


IE Suport

arrow function and spread operator need transform

It is explicitly documented in README.md.  Use Version 2 or transpile base64.ts yourself

It is explicitly documented in README.md.  Use Version 2 or transpile base64.ts yourself


Complete F# support ?

Will ASP.NET 5 have complete F# support (old postings like "http://blog.alxandr.me/2014/11/23/f-in-asp-net-5-the-good-the-bad-and-the-really-ugly/" seems to indicate problems) ?

@bluemmc there are no plans for the initial release to support any languages aside from C#. However, after the initial release we do plan to invest in support for other languages. In the meantime we're certainly not trying to explicitly block any other languages from working, but we're also not doing any work to make it any easier.

That's a real shame. Where is the upvote button?

I would recommend using the issue at https://github.com/dotnet/cli/issues/586 to track this, and it looks like maybe there's some stuff available to play around with. This issue here is no longer relevant because DNX is going away and we use .NET CLI for compilation.


Server mode, Laravel + model data

How do you I render any columns that use Model data that isn't directly pulled from the database?

Do you mean custom mutators on the model?

Yes, or any extra methods for that matter. $model->getSomething()

Do you mean custom mutators on the model that generate derivative attributes?

Do you mean custom mutators on the model that generate derivative attributes?

Do you mean custom mutators on the model that generate derivative attributes?

Do you mean custom mutators on the model that generate derivative attributes?

Yes, any of those.

Well, If I remember correctly custom mutators are attached by laravel to the query results. Any other data would have to be manually parsed by you before you return the results.


MAUI support

Will this support MAUI?

Rephrasing :D : do you plan to support MAUI?

Yes, but I think it will not be so soon. (At least MAUI stable version released)

How about progress on this issue?

How about progress on this issue?

not much, the mlkit library is not quite available in MAUI at this moment

The Maui support is ready.
However, please be noticed that Maui is still quite unstable.


Rule Request: writable.update() should always return a value

Motivation
If you use the .update(...) method on a writable store and don't explicitly return a value the store will be set to undefined. That might be on purpose, but I'm willing to bet that more often than not it's accidental.
Description
The rule should look for .update() calls that match the signature of writable.update() and ensure that all code paths return some value. Doesn't have to the be the original value or anything specific, I just think being able to require the usage of return <thing>; to make it really explicit that a value is being set would be useful and prevent errors.
Examples
<script>
const store = writable(false);

// ✓ GOOD
store.update(($store) => true);

store.update(($store) => {
    return true;
});

store.update(($store) => {
    if(foo) {
        // ...
        return bar;
    }

    return true;
});

// ✗ BAD
store.update(($store) => {
    // ...
});

store.update(($store) => {
    if(foo) {
        // ...
        return bar;
    }
});
</script>

Additional comments
No response

Thank you for posting rule suggestion!
That rule sounds good to me!


ExcludeFromSourceBuild->ExcludeFromSourceOnlyBuild

Part of the .NET 8 -> .NET 9 control update

@nohwnd @dotnet/source-build-internal PTAL


Clarify a common exception to default licensing

Description This is the no 1 reason to use another license sometimes, IMO

Looks quite sensible, and I seem to remember we've actually licensed some project according to this exception(?).


Different default features for crate binary and library

Problem
I have a crate that is both a library and a binary. I want to be able to specify a default set of features for users of the library and the binary. For instance, people who write mycrate = "*" in their Cargo.toml get a small set of features (and fast compilation times), but when typing cargo install mycrate they get most or all of the features enabled.
This is currently not possible, due to the single [features] default = […] field in Cargo.toml.
Proposed Solution
The [lib] and [[bin]] sections already have a required-features = […] field. I propose we also add a default-features = […] field that, if present, will override the default field in [features]:
[package]
name = "mycrate"

[[bin]]
# Make most features opt-out for users of the binary
default-features = ["features", "that", "binary", "users", "often", "want"]

[lib]
default-features = [] # Make all features opt-in for users of the library

[[test]]
# We don't set `default-features` here, so the same features from `[features] default` are used

[features]
# default features for any target that hasn't set `default-features` (tests, examples and benches):
default = ["foo", "bar"]

Notes
No response

Thanks for the issue report.
RFC 3374 should cover the cargo install use case. This also looks like a duplicate of https://github.com/rust-lang/cargo/issues/10409.

Close in favour of #10409. Thanks.

Thank you!


[dv, spi_host] Re-implementing command.CSAAT <-> CSB check

Plus a bit of cleanup for unused variables and a warning from a VSEQ

@rswarbrick - I believe I've addressed all your comments now. Please Let me know if there's anything I've missed!

@rswarbrick I believe I've addressed all your feedback in my latest commit. I had to refactor one of the checks to make it a function of sys_clk instead of spi_clk.
I've regressed the changes heavily and didn't see any fallout. Let's wait and see what CI says :)

I'm trying to respond to your comment https://github.com/lowRISC/opentitan/pull/24057#discussion_r1718326833
But for some reason I don't get a "reply" button.
It is a design enable output, the one that determines when CSB is active. Would you suggest to model cio_csb_en_o instead and check the predicted vs actual value, and then only carry on with behavior if predicted cio_csb_en_o is set?
Not many TBs do that kind of check, but it may be valuable. Although this enable signal is used to control the pads in the top-level and is tested there.
In any case, if a check like this is worthwhile to add I suggest to make it part of a different PR.


Release: cf-table fixes, hero update

Table fixes, hero update and some maintenance items (node upgrade and git merge driver).
@Scotchester

:+1:


LocationTracking.spec.js process teardown/leak warning

Narrowed down to LocationTracking.spec.js
PASS  app/views/__tests__/LocationTracking.spec.js
  ✓ renders correctly (67ms)

  console.log app/views/LocationTracking.js:133
    Can't find crossed paths

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        2.755s, estimated 4s
Ran all test suites matching /locationtracking/i.

Watch Usage: Press w to show more.A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --runInBand --detectOpenHandles to find leaks.

Something is not doing async or teardown correctly.

Not necessarily easy, but a good issue for someone new wanting to join the dev team.

I can take a look at this one? I am a QA by trade, so would be interested in looking at this one

@lewisPrescott707  - All yours. Note that a lot has happened to the codebase in the last month, so verify the issue still exists.

Been looking at this for a little while now and can't find the issue. Running --detectOpenHandles doesn't return anything.
Found this, could we add --forceExit like suggested?
Jest Issue

I'd prefer not to add a "hammer" solution.. vs trying to identify/mock each dependency and use jest.useFakeTimers() etc.
Note that since #749 we care more about tests working in Main.js and the sub components in main/*, as LocationTracking.js will be removed soon enough.

@lewisPrescott707 could you add some tests around the components in main/* and see if this issue still shows?
the recent component separation may help us isolate the problem to a specific view and dependency.

If the warning doesn't show anymore, we can commit those tests and close this

Found the specific dependency causing the leak, adding tests for main/ helped me isolate it!! Thanks @tstirrat

Found the specific dependency causing the leak, by adding tests for main/, they helped me isolate it!! Thanks @tstirrat

Great work, thanks!


issue with MediaFoundationEncoder.EncodeToMp3

I am using MediaFoundationEncoder.EncodeToMp3 to convert a wave file to a Mp3 file, mp3 file was generated successfully, but it is not able to play back.
I also tried NAudio.Lame with success, mp3 file size was doubled and mp3 file was able to play back.
Anyone can help?
MediaFoundationApi.Startup();
using (var reader = new WaveFileReader(sourceFile))
{
MediaFoundationEncoder.EncodeToMp3(reader, desFile);
}
========================Lame================
using (WaveFileReader wavReader = new WaveFileReader(f))
using (WaveStream pcm = WaveFormatConversionStream.CreatePcmStream(wavReader))
using (LameMP3FileWriter fileWriter = new LameMP3FileWriter(targetFile, pcm.WaveFormat, LAMEPreset.VBR_90))
{
pcm.CopyTo(fileWriter);
}

I am having an encoding as mp3 as well. Trying to trim as a wav then convert back to mp3
controller
`[HttpPost(Name = "SliceMp3")]
public async Task Post(IFormFile file)
{
        var filePath = Path.GetTempFileName();
        var fileOutPath = Path.GetTempFileName();

        using (var stream = System.IO.File.Create(filePath))
        {
            // The formFile is the method parameter which type is IFormFile
            // Saves the files to the local file system using a file name generated by the app.
            await file.CopyToAsync(stream);

        }

        WavFileUtils.TrimWavMp3(filePath, fileOutPath, new TimeSpan(1), new TimeSpan(2));

        var memoryStream = new MemoryStream();
        using (var stream = System.IO.File.OpenRead(fileOutPath))
        {
            await stream.CopyToAsync(memoryStream);
        }

        return File(memoryStream, "audio/mp3", "myfile.mp3");
    }`

    `public static void TrimWavMp3(string path, string outPath, TimeSpan cutFromStart, TimeSpan cutFromEnd)
    {
        var wavFilePath = Path.GetTempFileName();
        var trimmedFilePath = Path.GetTempFileName();

        //Convert to wav
        using var readerMp3ToWav = new MediaFoundationReader(path);
        WaveFileWriter.CreateWaveFile(wavFilePath, readerMp3ToWav);

        //Trim
        TrimWavFile(wavFilePath, trimmedFilePath, cutFromStart, cutFromEnd);

        //Convert back
        using var readerWavToMp3 = new WaveFileReader(trimmedFilePath);
        MediaFoundationEncoder.EncodeToMp3(readerWavToMp3, outPath);

    }`

I get back System.ArgumentException: Was not able to create a sink writer for this file extension


charmrun: fix syntax error in mpi win

Fixes #2674.
Followup from #2394.
Could be cherry-picked to 6.10.

Followup from #2394.
Could be cherry-picked to 6.10.

#2394 is not part of 6.10 so the problem does not exist on that branch.


[Request] Support for Storage Overhaul

Before suggesting a mod please

[X] I have already tested myself that the modded storages I want to suggest don't work as a part of Create moving contraption, even with More Mounted Storages installed
[X] Storages I want to suggest don't require power of any kind to function
[X] Storages I want to suggest are not multiblock structures
[X] Main function of storages I want to suggest is to store items, and they don't do any kind of items processing over time

URL
https://www.curseforge.com/minecraft/mc-mods/storage-overhaul
Additional info
Thanks for considering it!

I wasn't thinking and I guess this does have multiblock structures with double chests.  Not sure if that would be an issue.

Double chest are fine. I will look into this mod before the next release


Suggestion to change modman install name

Extension name is now magento if installing via modman
This is dangerous because too common, and doesnt describe the contents
See the example below
Suggestion:
This should be something like Adyen_magento

Hi Sean,
I understand the issue. We will look into this.
Regards,
Rik
Adyen


Keyvault stops working after adding a newer version of active-directory starter

Environment
Spring boot starter:
key vault spring boot starter
active directory spring boot starter
OS Type: Linux
Java version: 1.8
Summary
Keyvault is not called and properties are not loaded.
Reproduce steps
Use these Versions
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-secrets-spring-boot-starter</artifactId>
<version>2.1.8</version>
</dependency>

<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-active-directory-spring-boot-starter</artifactId>
<version>2.3.3</version>
</dependency>

Expected Results
Spring should have loaded the keys from the key vault.
Actual Results

Using the same version, 2.3.3, keyvault connects fine.

hi @mukeshgulia, we have migrated the repo to https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring, could you submit your issue there? it will ask you for more issue details. thanks

hi @mukeshgulia,azure-keyvault-secrets-spring-boot-starter:2.1.8 and azure-active-directory-spring-boot-starter:2.3.3 both refer to azure-spring-boot, but they refer to different versions of azure-spring-boot.This has led to dependency conflicts. It is suggested that you replace azure-keyvault-secrets-spring-boot-starter:2.1.8 with version 2.3.3 to resolve dependency conflicts.

closing the issue


the synset.txt in  pretrained resnext-101 model is wrong

the synset.txt in resnext is wrong order. i generate a new synset.txt by using the train.lst

@mli @tornadomeet

@terrychenism could your check it, which you trained the  model:resnext-101?

Thanks @li-haoran  I use imagenet'15 label to train resnext-101, different from resnet-101 which use imagenet'12 label.  I will update the synset.txt quickly.
@piiswrong @tornadomeet @mli Do we need to retrain the resnext model, 1. match the torch result and use image io api, 2. match resnet label

@terrychenism  i suggest update the synset.txt in http://data.mxnet.io/models/imagenet/resnext first, because the current resnext-101 model is ok.
but a model with more accurate result and  the same synset.txt  is welcome if have time and resource。

Yes, the synset.txt has been updated.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


feat: Add creation code printing in traces

This is needed for https://github.com/foundry-rs/foundry/issues/8906

It seems that I missed the 0.7.5 release by an hour :laughing: Do you have a plan to release 0.7.6 that would include changes from this PR?

doing rn


Create keyword container/UI on Campaign Edit page

Need to capture tags on the campaign (ext. We can use some kind tag library to make the experience better (like use known existing tags for auto-completion).
NOT to be as complex as StackOverflow, but that kind of idea. (from #35)

This seems interesting. I'd like to work this.

@bluechrometouch sounds good, assigning you now. Before starting on this, can you find a few samples/links of what you're thinking of?
The keywords can be stored in a new field on the Campaign entity class.

jQuery Tag-it appears to be a commonly used and supported tagging framework.
The source page has an autocomplete example. There would need to be JSON source list.
https://github.com/aehlke/tag-it
More Samples
http://webspirited.com/tagit/

Guys, I had already started this a week ago. My changes somehow got blown away, probably with all of that merge mess I was mired in. Anyway, you should see a reference to the "bootstrap-tagsinput" library within the bower.json file, which I added. I had created a textbox on the Campaign edit page which was tagged with the appropriate class for the tags helper. I found this library to be good in that it integrates with the bootstrap styles we're currently using.
My idea for this was to have it store the tags to a related table with an n-to-n relationship with Campaigns. This way, we could search and filter by tags, as well as easily update them as needed.

Good thing I haven't worked on this as I was waiting for the top response.

Can I pick this one up? @tonysurma @stevejgordon

@naeemsarfraz - I'd say this is up for grabs.

So this is what I think this will look like:
Campaign list

Campaign detail

How I plan to tackle this:

[ ] Add a single field on the campaign edit screen to capture tags
[ ] Use this plugin
[ ] Persist the tags in a single field on the Campaigns table, comma-separated?
[ ] Include tags in the Search campaigns function

I'm going to add a single field to capture this and use

This looks good @naeemsarfraz - Sorry for the lack of response! Sounds like a good approach. I tend to pipe "|" separate strings when I store combined data in the db.
If we later add searching for this I wonder if actually storing each tag in the db somewhere might be better? We can then link events to tags to easily find any events with a specific tag? Otherwise I guess we're looking at whether the tags field contains a value which might get a bit slow.
Also, if we had a unique store of all tag values we could do an autocomplete.
I'll defer to your judgement on implementing it but I think we need to keep both searching/filtering and autocomplete in mind as possible future enhancements.

Hey @stevejgordon, I'll write up some thoughts around which direction I take this but I'm in agreement with you about the general approach.
A quick question, are we referring to these as tags or keywords?

I think tags is better personally.

Hi @naeemsarfraz - Just checking in to see if this is something you're still able to work on?


Enhance Google Analytics

Research effort needed to determine the feasibility of this enhancement.
We would like increased resolution over traffic flow within the application. We are not sure whether this is possible, given our single-view implementation.
1.) Behavior Flow diagrams. These describe user's interactions with various screens and provides drop-off rates at each interaction. Here is an example from a website that I manage:

2.) Per-view metrics. These show pageviews as well as time-per-page, but I'd like to collect them per view if possible. Here is another example from the same site:

event triggers:
Nearest neighbor
2d image export
bacterial sequences (SNPs) vs HIV or other viruses (TN93 distances) [Distance Metric]

event trigger:
search


Delayed identity cleanup on operator restart

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
On operator start up, all identities are marked as alive irrespective of whether an identity has the delete annotation
https://github.com/cilium/cilium/blob/bb6decf7c7e2e31da91cc94e7d2c050a2d937048/operator/identitygc/crd_gc.go#L52
The delete annotation is added on an identity in https://github.com/cilium/cilium/blob/bb6decf7c7e2e31da91cc94e7d2c050a2d937048/operator/identitygc/crd_gc.go#L125
As the default heartbeat timeout is 30 minutes, an identity that was marked for deletion with an annotation is marked alive on operator start up and delays the cleanup by 30 minutes.
I think an identity with the deletion annotation should not marked alive again. Is there an issue with this?.
Cilium Version
1.12
Kernel Version
not applicable
Kubernetes Version
1.27
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The larger problem that this causes is every time the operator restarts, identity GC is delayed again by at least the ID timeout value (30 mins default). The operator will restart it loses leader election due to k8s api calls failing. If this happens often enough, say once per hour, then the operator GC logic keeps delaying the GC of identities further and further in the future which allows identities to accumulate until the policy maps fill up.

@dlapcevic @aojea Is this addressed with https://github.com/cilium/cilium/issues/27752, if so can you open this and reassign to yourself.
If this needs to be handled separately, can you open so others can take a look?. Thanks!

Yes, this will be addressed with https://github.com/cilium/cilium/issues/27752.
The plan is to immediately clean up unused Cilium Identities. They will anyway be cleaned up when operator starts.

/assign @dlapcevic

@dlapcevic Is this issue addressed?. Can we mark it as fixed or reopen if there is pending work?

https://github.com/cilium/cilium/issues/34740


Manifest missing elastic-apm-agent-1.7.0.jar

Describe the bug
Manifest missing elastic-apm-agent-1.7.0.jar
To Reproduce
Steps to reproduce the behavior:

Download the APM agent from http://search.maven.org/#search|ga|1|a%3Aelastic-apm-agent

Start your application with the javaagent flag

java -javaagent:/path/to/elastic-apm-agent-1.7.0.jar
-Delastic.apm.service_name=my-application
-Delastic.apm.server_url=http://localhost:8200
-Delastic.apm.secret_token=
-Delastic.apm.application_packages=org.example
-jar my-application.jar

See error
Error opening zip file or JAR manifest missing : /path/to/elastic-apm-agent-1.7.0.jar
Error occurred during initialization of VM
agent library failed to init: instrument

Expected behavior
Agent status says me that all is ok

Closing as this has been answered at https://discuss.elastic.co/t/error-opening-zip-file-or-jar-manifest-missing-elastic-apm-agent-1-7-0-jar/192991.


Master to Live

Docs Build status updates of commit cffabba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-RetentionCompliancePolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-server/New-SPEnterpriseSearchMetadataMapping.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/New-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Version increment, dep update

Coverage remained the same at 82.371% when pulling b72377663c2cc5df1ccee4f021d31b265484d076 on kapilt:next-15 into 3bb5663b647fbfd3c9f5af8ba0ce1c3800f1a03c on capitalone:master.


Make all public classes of CSP visible for user extension modules

Closes #363

Going to try a new approach to get this working for mac and linux and leave Windows extension node visibility as a TO-DO.


Roll up Swift 4 & Xcode 9 changes

Xcode + language settings
Explicit @objc
Updated String APIs
Docs

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@31a7a4e). Click here to learn what that means.
The diff coverage is 60%.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   97.98%
=========================================
  Files             ?       12
  Lines             ?      944
  Branches          ?        0
=========================================
  Hits              ?      925
  Misses            ?       19
  Partials          ?        0

Impacted Files
Coverage Δ

Sources/Helpers.swift
92.63% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a7a4e...1734651. Read the comment docs.


Update to latest SDL 2.0.12

**Is your feature request related to a problem? Just to keep dependencies up to date
Describe the solution you'd like
Just update
Describe alternatives you've considered
Remain as it is
OS and backend
Windows, linux and osx

Is there any reason why we should update? We use only SDL2 for our test apps (and we'd like to move to GLFW) and unless there are issues that an update would fix I'd rather we didn't (just in case we do create problems).

No reason, i like the idea to move to glfw, we can close it then.
Thanks


Unused varibles in GraphQL query/mutation should report error

According to GraphQL specification unused variables means invalid query (mutation): https://spec.graphql.org/June2018/#sec-All-Variables-Used
Currently, this produce error in runtime, not in code generation time.
Solution probably should be resolved in plugin https://graphql-code-generator.com/docs/plugins/typescript-operations
For example, code generation with apollo tool report this like error.
Thanks a lot

PRs are welcome!

I'm not sure if it's codegen's job to do validation like that. That sounds more like something that should be handled by a library like graphql-inspector.

Other mistakes like missing variable, duplicate variable are detected (I don't really know by which part of project).

I agree with @danielrearden . This kind of validation seems out of codegen's scope. You should already make sure your operations are good before code generation step by yourself using a tool like graphql inspector.

I agree with @ardatan here. Closing.


in mem storage: got rid of the namespace indirection

Looks better in this screenshot, but I will flamegraph and test this a little further on linux

Some further testing, with no `variables`, i.e actually hitting the change! Not that much difference... With the newly added bench scenario.
But if I grow the namespaces to a 1000...

Then it's a regression!
Now, that's all still on MacOS, I'll test these more rigorously on Linux next...

Also... if a "tree" (namespace 1 -> * Limits -> 1 Counter) seem to be faster... how would storing these in a BTreeMap work our... 🤔

Well much... better. Anyways, Imma stop here and run all these on Linux and flamegraph some of these, but some of this would absolutely apply to our distributed storage /cc @chirino

Did some more and, by now, relatively extensive testing... having the Limits comparable and store AtomicExpiringValue in a BTreeMap is giving the best results in most of the cases. When you have Limits with many (in the 100s) of  Conditions, performance degrades. Still need to look into that further... But here is the callstack for Hash based vs Cmp based when searching for the Counters:
Hash based: HashMap<Namespace, HashMap<Limit, AtomicExpiringValue>>

Cmp based: BTreeMap<Limit, AtomicExpiringValue>

Giving us this kind of results:
Memory/check_rate_limited_and_update/10 namespaces with 50 limits each with 10 conditions and 0 vari...
                        time:   [253.02 µs 254.21 µs 255.86 µs]
                        change: [-9.1814% -8.4315% -7.7729%] (p = 0.00 < 0.05)
                        Performance has improved.

Zooming out...
Right now the worst offender tho, is not where we are looking for, in which ever storage version here btw:

RateLimiter::counters_that_applies spends all its time clone() the Limits (and composing parts) to then re-clone again and map into Counters... I'll have a look at that next.

🛑 This cannot be merged! ⚠
As of today we use the JSON serialized form of Limits to look counters up in Redis... It is highly unlikely that switching from >HashMaps for our Limit field to BTreeMap would preserve the order we obtained in our own sorting functions.

I'll break the format anyways with more PRs coming… which is why we are releasing Limitador v2, with that in mind, maybe we are ok merging this?


anchor doesn't support Solana CLI Version 1.15.2(latest)

error:function _zn14solana_program4vote5state9votestate11deserialize17he5005e2fd6c7f858e stack offset of 6344 exceeded max offset of 4096 by 2248 bytes, please minimize large stack variables
works fine for previous builds of Solana.

There's nothing we can really do about this until the 1.15 solana-program crate (not the CLI) becomes stable and we release a version supporting that. The 1.15 solana cli / solana-program bumps the rust version used by their custom compiler from 1.60 to probably the latest rust version, 1.67 or something.


How to specify visible gpu in full sft/lora sft?

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
Hi~
I have 8 GPUs in one single node. I tried to specify GPUs but failed when using examples/full_multi_gpu/single_node.sh and examples/lora_multi_gpu/single_node.sh to fine-tune llama2.

full sft: examples/full_multi_gpu/single_node.sh

Command: CUDA_VISIBLE_DEVICES=4,5,6,7 bash single_node.sh
Result: GPU 0-3 was used

lora sft: examples/lora_multi_gpu/single_node.sh

I noticed there is a CUDA_VISIBLE_DEVICES setting in scripts, so I changed the first line of the script: CUDA_VISIBLE_DEVICES=4,5,6,7 accelerate launch \
Command: bash single_node.sh
Result: GPU 0-3 was used
Thanks for your help.
Expected behavior
No response
System Info
No response
Others
No response

use deepspeed --include "localhost:0,1,2,3" in full_multi_gpu/single_node.sh

use deepspeed --include "localhost:0,1,2,3" in full_multi_gpu/single_node.sh

Thanks for your reply!
Is the setting in lora_multi_gpu/single_node.sh right if I need to specify the last 4 GPUs for lora sft? CUDA_VISIBLE_DEVICES=4,5,6,7 accelerate launch \

It should be right


HTML/CPBKGB22/Personal/Current/V_2015_03_03 -ve balance

HTML/CPBKGB22/Personal/Current/V_2015_03_03 balance doesn't detect negative balances properly. This appears on statements in the format £12.34-.
There is probably a similar problem with HTML/CPBKGB22/Personal/Current/V_2011_05_07. This appears differently, however (using OD code?).
HTML/CPBKGB22/Personal/Savings/V_2011_05_07 and HTML/CPBKGB22/Personal/Savings/V_2015_03_03 inherit, so will be fixed with the rest. Probably worth extending the tests for these too, though.

So far as I know, fixed for all HTML/CPBKGB22/Personal The Co-operative Bank statements.
I'm a little concerned about OD vs DR, but perhaps I imagined the former.


Accessibility issue with the layers menu

Describe the bug
As a physically disabled user and developer I have an accessibility issue with the overlay menu (in the top right corner of the map). The menu automatically closes when I move the mouse 'wrongly'. I don't know what is exactly causing the menu to close. I use assistive technology (speech recognition) to control the mouse pointer, thus it's not so easy to move the pointer smootly. Can I somewhere change the JS to make the menu stay open until I explicitly close it (e. g. by clicking outside)?
To Reproduce
Hower mouse over overlay menu to open it. Move mouse. At some stage, the menu will close by itself.
Expected behavior
Menu should stay open until manually closed.
System Information
Webapp frontend on Chrome.

I think you're referring to L.Control.Layers, detailed in its own tutorial.
Developers using Leaflet can set the collapsed option of L.Control.Layers to control the behaviour. In particular, something like...
var layersControl = L.control.layers(
  baseLayers,
  overlayLayers,
  { collapsed: false }
);

...will make the layers control "stay on" forever. Developers are always free to use a different method of displaying layer switchers using plugins.
Having a third behaviour for the collapsable layers control (clicking outside instead of just hovering outside) is interesting. Maybe you might want to create a separate feature request for that, keeping in mind the new information explained here?
In regards to accessibility, please keep in mind that the default collapsible L.Control.Layers can be navigated via keyboard: tab-focus on the collapsed layers control, then enter, then tab-focus on the set of radio boxes or on the checkboxes. While I would agree that adding an invisible buffer around the controls to prevent mouseouts and help with inaccurate clicks would be nice, it would make the behaviour of some plugins (toolbars, etc) inconsistent (and since the controls are navigable via keyboard, I think it's not urgent to spend effort on that).


Support maxParallelExecutionsPerInstance property in host.json

While I understand how BatchSize/NewBatchThreshold work together, my concern is that their semantic is too tricky, and that we’ll constantly need to explain how it works. In particular, the fact the max parallel execution is the sum of BatchSize and NewBatchThreshold is very counter intuitive.
I’d like to propose an alternate model that would make things much clearer to users. The primary flag that users should care about is maxParallelExecutionsPerInstance. Arguably, it’s the only one that we should expose. The way it works is that we keep starting new parallel executions until we have that number running. The fact that internally we might start them in batches is more of an implementation detail that probably doesn’t affect things all that much. If we have reasonable batch defaults, then it’s pretty irrelevant to the user.

Anything we do here would be done in the core SDK, so I think this suggestion should be moved there.

https://github.com/Azure/azure-webjobs-sdk/issues/747