Fix Issue 24165 - Failed readf leaves File in inconsistent state

Previously, a failed call to readf resulted in multiple copies of the
same LockingTextReader being destroyed. Since LockingTextReader's
destructor calls ungetc on the last-read character, this caused that
character to appear multiple times in subsequent reads from the File.
This change ensures that the destructor in question is only run once by
making LockingTextReader a reference-counted type.
Ideally, to avoid unnecessary overhead, this issue would have been fixed
by making LockingTextReader non-copyable. However, non-copyable ranges
are poorly-supported by Phobos, and this approach would have required
extensive changes to several other modules, including changes to the
interfaces of some public symbols.

Given that LockingTextWriter is used mainly for performance, this is going to remove some of the benefits of it, for something that happens very rarely.
Don't we just need to ensure that only one legit instance is valid at a time? What about adding a copy constructor that hollows out the original?

Whoops, my bad, this affects LockingTextReader, not Writer.

What about adding a copy constructor that hollows out the original?

Seems like this could break code that currently works (e.g., anything that makes a copy and then calls .front on the original). Maybe we can get away with it in practice though.

The question is, what is intended to be supported? Typically with input-only ranges (not forward ranges), only one instance should be used. Not preventing copying on input ranges was a design mistake, but we have to live with it now.
even if you don't hollow it out, what about removing the character to put back so it's not put back twice? That also seems like a kludge as well.

even if you don't hollow it out, what about removing the character to put back so it's not put back twice?

Isn't that functionally the same as hollowing it out?
I guess I could add a bool original flag that gets set to false on copy, and only call ungetc if the flag is true. I'll give it a try locally and amend the PR if it works.

Actually never mind, LockingTextReader is public, which means we absolutely cannot assume that code using it follows input range best practices and only ever uses one instance at a time. If it were internal to Phobos we could maybe get away with a kludge, but for a public API, we have to code defensively.

Attempted the hollow-out approach anyway and it turns out that replacing LockingTextWriter's postblit with a copy ctor is not going to be an option—it requires doing the same to File, which in turn breaks all kinds of stuff.

Another idea -- since File is a refcounted type anyway, can we stuff the char in there? Still doesn't help the performance, but at least we don't have the overhead of allocating another refcounted impl.

Another idea -- upon creation of the LockingTextReader, store a bool in the File impl that indicates whether the ungtc has been called once. Then on destruction, if the hasChar is true, only do ungetc if that hasn't been done yet.

Another idea -- upon creation of the LockingTextReader, store a bool in the File impl that indicates whether the ungtc has been called once. Then on destruction, if the hasChar is true, only do ungetc if that hasn't been done yet.

Couldn't something like this work @pbackus ?

The problem with that suggestion is that it calls ungetc on the destruction of the first instance, not the last instance. Which means that if you copy the reader while hasChar == true, destroy the copy, and then continue reading from the original, the character will be duplicated.
If that sounds unrealistic, keep in mind that passing by value creates and destroys a copy. For example, a function like the following would trigger the failure mode described above:
// Note: takes range by value
void enforceNonEmpty(Range)(Range range)
if (isInputRange!Range)
{
    enforce(!r.empty, "Expected non-empty range");
}

Now, maybe our official position is that such code is not supported—if you copy a range, and then read from the original, you get what you get and there are no guarantees, even if you never read from the copy. But that seems like unnecessarily hostile API design to me.

The problem with that suggestion is that it calls ungetc on the destruction of the first instance, not the last instance.

We can have 3 states:

we have no char in the buffer
we have a char in our buffer, and the next char has not been fetched before
we have a char in our buffer, and the stream has had a char put back into it from a copy of LockingTextReader.

We already have a hasChar in the LockingFileReader. That covers whether there is a char in the buffer or not.
We need a second boolean, which can be stored in the main File refcounted struct, which is set to true when ungetc is called. Then we can cover this situation fine.
What I'm trying to avoid is yet another allocation for something that could easily be short-lived. We already have the pointer stored in the private File _f, and we have to go through that anyway to access the FILE *. So there is no "extra cost" by storing another state boolean in that Impl struct.
You can even encapsulate this functionality in 2 new private functions inside the File: ungetcIfNotDone(char) and getcAlreadyHadChar() or something like that.
I think this works, but I haven't tried it out or thought of all the details. The main goal should be to avoid putting back data that was never on the stream in the first place. Even if this is at the expense of "just don't do that" type warnings, fine. The secondary goal is to try and avoid reading data that isn't there. I think we can do both, without resorting to an extra indirection and an extra allocation.


[5.5] LengthAwarePaginator - fix in return type

This is wrong

See https://github.com/laravel/framework/pull/20899


Use File.createTempFile for writing temporary Webdriver-executable

Windows-specific bug.
You should use Temp.createTempFile, because current implementation suffers from correct location. Users might have a different location for their temporary files:
https://github.com/ldaume/headless-chrome/blob/975227ab02ad9fc7ebef5e33704db03dc944d80a/src/main/java/software/reinvent/headless/chrome/HeadlessDriver.java#L46

;) I will close the door behind me


OCPBUGS-42660: relax validation on delete and if failureDomains not configured

Description:

Do not block deletion of finalizers due to spec validation
For vSphere, do not enforce empty provider spec workspace if failure domains are not configured in cpms

/test e2e-vsphere-operator
/test e2e-vsphere-multi-zone-operator

/test e2e-vsphere-operator
/test e2e-vsphere-multi-zone-operator

/label qe-approved

/test unit

/lgtm

/assign @damdo

/retest

/test unit

/test unit

/lgtm

/retest-required

/retest-required

/test e2e-aws-ovn-etcd-scaling

/test /e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-etcd-scaling

I think the etcd scaling failure is unrelated to this change as that runs on AWS only.
We might want to chat with the etcd folks about that one.

/test ?

/test e2e-vsphere-ovn-etcd-scaling

I think the etcd scaling failure is unrelated to this change as that runs on AWS only.
We might want to chat with the etcd folks about that one.

yeah, i'll start a thread with them

@rvanderp3  I already did here, it seems like it is a known issue they are trying to fix: https://redhat-internal.slack.com/archives/C027U68LP/p1730229820314459

/skip

@rvanderp3 let me know if you want to wait for https://github.com/openshift/cluster-kube-storage-version-migrator-operator/pull/118 to merge or if we should override that scaling job

@rvanderp3 let me know if you want to wait for openshift/cluster-kube-storage-version-migrator-operator#118 to merge or if we should override that scaling job

I'm fine with overriding.  It would be good to get this in sooner rather than later i think.

/override ci/prow/e2e-aws-ovn-etcd-scaling

/cherrypick release-4.17 release-4.16


Split/Dual circles in Landscape mode

Is your feature request related to a problem? Please describe.
8vim's advantage diminishes completely(at least for me) when typing in landscape mode. In landscape I can use two fingers to reach far away letters in regular keyboards. Using only a single thumb is too slow.
Describe the solution you'd like
You have two thumbs. Take advantage of it when typing in landscape. Use the wasted area. Right circle has levels 1 to 2. Left has 3 to 4.
Describe alternatives you've considered
Maybe 8vim can act as a master keyboard aed have an option to autotoggle another keyboard in landscape. But that would kinda defeat the purpose of using 8vim.

Hi, there is a PR, #347 to improve the current landscape mode. It's not perfect yet, but it's an improvement.
I like your idea for a dual-circle approach.

We might have two thumbs but most folks don't have the dexterity to precisely manipulate the 2 thumbs together. You guys can experiment, but I don't have much confidence in the idea.
You can also try having the number/symbol pad on one side and the xboard view on the other.
My personal favourite idea for landscape is to have the keyboard to one side of the screen and rest of the area be text editing area, your thumb will move exactly like in portrait so no extra training needed.

I was literally just coming here to make this exact suggestion. The enormous amount of wasted space is an obvious UX Design no-no.
The best way to handle this IMO is also the simplest. Let the user decide.
I'm not sure why you think people lack the dexterity to use two fingers simultaneously. We manage to blind type with all ten fingers on hardware keyboards plenty fast. Perhaps you're right, but I don't understand the logic. Maybe I'm just more naturally dextrous than most..? I doubt that, though.
I believe it's more a matter of practice and muscle memory. I've nearly hit the ceiling for typing speed xith 8vim already, doing the same with another finger would be trivial. I get bogged down often due to switching between the xboard and symbol pad and almost never use the text edit board because it often ends up taking too much extra time than just using Android's native features. To be fair, I don't think two or more xboards would work as well with a small phone screen and thumbs as it would for a larger tablet screen where you'd likely be using index fingers.
Still, I'm almost certain it would result in faster keying for those who want to put in the effort practicing - which, given the unique nature of this keyboard, is already a given for new users. Auto spacing may have to be turned off with two, as well. Text editing would be nice, but, it at most saves 2 button taps and 2 view switches when used like that. It'd be nice to have on the main screen - but can't be used simutaneously like a second board could.
Keyboard height needs to be adjustable. My device has a 16:10 aspect ratio, so 8vim is still gobbling up >50% of my tablet's screen real estate.
User should have the option to set height, font size, and UI Scale (or icon scale) to any arbitrary value on a per-orientation basis. An easy, albeit less user-friendly, way of temporarily providing all of these features is by adding support for Tasker and allowing Tasker to set any of these internal variables. This has the benefit of saving you a lot of time coding and allowing the user total freedom. Popout mode would be great, too.
Allow for multiple (2-3, though ideally any arbitrary quantity is best) xboards to be side by side, including standard numpad/symbol board, clipboard, and text selection/editing board. My tablet has enough blank space for around 4 boards to be here simultaneously, more if I could reduce the height.
I would absolutely use two xboards - to start, I'd simply take the 2nd & 4th letter from each section and assign them to the second xboard. On the default English layout, this would be like this on one side:
.\'  ¦  q/?
 c\d ¦ b/r
-----------
 h/l ¦ u\m
,/@  ¦  w\!

and this on the other side:
z\g  ¦  p/x
 t\s ¦ y/a
-----------
 i/e ¦ o\n
j/k  ¦  v\f

Obviously, the layouts would likely need significant alterations to be made optimal.
In the center, between these two, I'd love a tabbed text editor, clipboard view, and symbol/numpad. Maybe set the empty two characters of each board to the capital versions of that board. Point is, lot of room for highly personalized keyboards.
I would also remove the sidebar icons entirely, I'm not very fond of them - even on my phone, they'd be better off smaller, and on top instead of the side. Settings button is unnecessary, emoji keyboard swapping is too annoying to use, tab/next personally never gets used, and clipboard/text editor could easily be merged into symbol board. Sidebar wastes far too much space for such little functionality and every function it offers could be consolidated for a better UX.
As it stands, I use about 20% of the total area of the 8vim xboard, with about 2 inches of excess height and 2 inches excess width, while the sidebar icons and needless whitespace consumes an additional 2 inches of the total width, and over 60% of the total width beyond the functional section of the board is whitespace - what a waste!
I can think of many other possibilities for what to do with all that empty space. At a bare minimum, I'd really love to shorten this thing by about 50%. How about some widgets? What about a Tasks list polled from the calendar, or a small notepad for working with separate chunks of text? A webview for quickly looking up info without having to app switch? Don't extend the keyboard to the full width of the device when it's going to waste soo much screen real estate. Or use a resizable popup.
I'm looking forward to seeing where this goes. Thanks to all of you for all your hard work on such a neat tool! 🥇

Has there been any progress on this? Is this a feature anyone else is interested in seeing?

@atlasveldine kind of. On the new version, you can popup out 8VIM and place it anywhere you like it


Object Required - Runtime error 424

I keep getting an error in Excel 2013 with  the code below. Can't seem to figure out a solution, have tried several different solutions to no avail.
Sub Submit()
    Dim excelRange As Range
    Dim Entries As New Collection
    Dim Entry As New Dictionary
    Dim row As Long

    Set excelRange = Cells(1, 1).CurrentRegion

    For row = 2 To excelRange.Rows.Count
        Set Entry = New Dictionary
        Entry("stakeholder") = Cells(row, 1)
        Entry("subject") = Cells(row, 2)
        Entry("initialEngagement") = Cells(row, 3)
        Entry("type") = Cells(row, 4)
        Entry("frequency") = Cells(row, 5)
        Entry("startDate") = Cells(row, 6)
        Entry("EndDate") = Cells(row, 7)

        Entries.Add Entry

    Next row

    Dim Obj As New Dictionary
    Set Obj("entries") = Entries

    Debug.Print jsonConverter.ConvertToJson(Obj, Whitespace:=2)

End Sub

Solved. Needed to add the .bas file to the VBA imports.

i think I have the same error, can you help me and tell me which .bas file did you added?

i think I have the same error, can you help me and tell me which .bas file did you added?

It's on the ReadMe, easy to miss near the bottom:
Installation

Download the latest release
Import JsonConverter.bas into your project (Open VBA Editor, Alt + F11; File > Import File)
Add Dictionary reference/class
For Windows-only, include a reference to "Microsoft Scripting Runtime"
For Windows and Mac, include VBA-Dictionary

Thanks :-)


Allow AbstractArray inputs when constructing ITensor

This generalizes ITensor constructor calls to allow more general AbstractArrays, such as views:
julia> i = Index(2)
(dim=2|id=80)

julia> A = randn(3, 3)
3×3 Matrix{Float64}:
  1.09161     -2.57016   -0.179175
  0.00337991   0.645025   0.620601
 -0.360845    -1.05635    0.280979

julia> T = itensor(@view(A[1:2, 1:2]), i', i)
ITensor ord=2 (dim=2|id=80)' (dim=2|id=80)
Dense{Float64, Base.ReshapedArray{Float64, 1, SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, Tuple{Base.MultiplicativeInverses.SignedMultiplicativeInverse{Int64}}}}

julia> @show T;
T = ITensor ord=2
Dim 1: (dim=2|id=80)'
Dim 2: (dim=2|id=80)
Dense{Float64, Base.ReshapedArray{Float64, 1, SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, Tuple{Base.MultiplicativeInverses.SignedMultiplicativeInverse{Int64}}}}
 2×2
 1.09161033355609      -2.5701619590506115
 0.003379905603743644   0.6450248941156372

julia> T[1, 1] = 11
11

julia> @show T;
T = ITensor ord=2
Dim 1: (dim=2|id=80)'
Dim 2: (dim=2|id=80)
Dense{Float64, Base.ReshapedArray{Float64, 1, SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, Tuple{Base.MultiplicativeInverses.SignedMultiplicativeInverse{Int64}}}}
 2×2
 11.0                   -2.5701619590506115
  0.003379905603743644   0.6450248941156372

julia> @show A;
A = [11.0 -2.5701619590506115 -0.17917503341437718; 0.003379905603743644 0.6450248941156372 0.6206013238978528; -0.36084534734340146 -1.056352020463183 0.2809788842059119]

It also fixes a subtle dispatch bug where if an Index collection was input into an ITensor constructor with an abstract element type like:
ITensor(randn(2), Index[Index([QN() => 2])])

or
ITensor(randn(2), Any[Index([QN() => 2])])

it was creating a Dense tensor instead of a BlockSparse tensor. Now it does the correct thing:
julia> ITensor(randn(2), Index[Index([QN() => 2])])
ITensor ord=1
(dim=2|id=254) <Out>
 1: QN() => 2
BlockSparse{Float64, Vector{Float64}, 1}

Codecov Report

Merging #737 (5c56024) into main (e80e3a4) will decrease coverage by 2.34%.
The diff coverage is 95.00%.

:exclamation: Current head 5c56024 differs from pull request most recent head 7d855c1. Consider uploading reports for the commit 7d855c1 to get more accurate results

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   76.53%   74.18%   -2.35%
==========================================
  Files          84       84
  Lines        9666     8233    -1433
==========================================
- Hits         7398     6108    -1290
+ Misses       2268     2125     -143

Impacted Files
Coverage Δ

src/qn/qnitensor.jl
84.90% <ø> (-0.17%)
:arrow_down:

src/indexset.jl
75.09% <94.11%> (-2.35%)
:arrow_down:

src/itensor.jl
84.02% <100.00%> (-1.29%)
:arrow_down:

src/NDTensors/octavian.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/NDTensors/similar.jl
33.33% <0.00%> (-30.31%)
:arrow_down:

src/NDTensors/dims.jl
42.85% <0.00%> (-28.58%)
:arrow_down:

src/NDTensors/empty.jl
51.68% <0.00%> (-25.56%)
:arrow_down:

src/broadcast.jl
60.16% <0.00%> (-25.21%)
:arrow_down:

src/qn/qnindexset.jl
86.66% <0.00%> (-13.34%)
:arrow_down:

src/NDTensors/tensorstorage.jl
66.66% <0.00%> (-10.08%)
:arrow_down:

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80e3a4...7d855c1. Read the comment docs.


Improve viewing album with slippy photo

Summary
Slippy photo displays photos with fixed dimensions. Next and prev photo supported by arrow keys

Test plan
Yes, map options

Coverage remained the same at 95.073% when pulling 4d531483437417a10a78ab9273d3869428a4462a on slippy-photo into<PHONE_NUMBER>1f336961bad60e302028c311c93763 on master.


Remove NextPolicyClass concept

Use an iterator of the policy vector

Moving to the backlog as there's not a good design approach to replace the NextPolicy abstraction

Closing this issue, we will keep the NextPolicyClass abstraction


[XLSX] Add mergeCells reader

Add possibility to read MergeCells metadata from XLSX sheet data xml.

Hi, can you add a test please?

@Slamdunk tests arrived!

@Slamdunk it is seems that need your attention
[2024-09-19T18:32:25.169Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2467s.', code='throttled')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2.1.0/dist/codecov' failed with exit code 255

Thank you but 3.x branch has been EOLed


[DatePicker] textFieldStyle prop doesn't work

<DatePicker
  hintText="From"
  textFieldStyle={{
     color: '#ffffff',
  }}
/>

In right side, DatePicker is filled with date.
I provide white color inline-css to DatePicker through textFieldStyle prop but TextField in datepicker never changed.

Try:       inputStyle={{color: 'white'}}

@mbrookes Perfect!

Same applied for the AutoComplete.. hopefully documentation gets updated

still not updated


Hue bridge "not configured"

Describe the bug
I've been using these nodes for a long time now. Since a few days I get a "not configured" message at the bottom of the Hue bridge node and the motion sensor node (maybe more nodes have this, didn't try them all). I tried to delete the configuration of the hue bridge and make a new one. Searching for a bridge works, and after selecting it also generating an API key works without problems. But after saving the config and publishing the node, it still says "not configured".
Flow to Reproduce
[{"id":"13adca38.15f556","type":"hue-bridge-node","z":"444774fd.bb442c","name":"Hue Bridge","bridge":"27cac910.b087a6","autoupdates":true,"skipglobalevents":false,"x":2130,"y":1840,"wires":[[]]},{"id":"27cac910.b087a6","type":"hue-bridge","z":"","name":"Philips hue","bridge":"<IP_ADDRESS>","key":"<deleted key>","interval":"3000","disableupdates":false}]

Expected behavior
I expect working nodes after configuring the hue bridge node.
Screenshots

Please complete the following information:

NodeRED version: v1.0.4
NodeJS version: I don't know where to find it.
Device running NodeRED: Home Assistant NodeRED addon on Intel NUC Virtualbox VM.

Additional context
No additional context.

Fixed in the latest version


New $baselineAlign and $calcuateOffsetFromEdge

calcuateOffsetFromEdge (bool) - Calculate Offset referring to the edges of the image (default false).
baselineAlign (bool) - Align the text font with the baseline. (default true).

'baselineAlign' => true (default)

'baselineAlign' => false

        'xOffset' => 50,
        'yOffset' => 50,
        'calcuateOffsetFromEdge' => true,
        'baselineAlign' => false

I'm optimizing the "text" function, fixing problem #212
I believe it will also improve the problem #165

Fantastic work! Thanks for taking the time to improve things.


Incorrect encoding detected in ./downstream/asr/char.dict, please rebuild the dataset

Hi,
Could you please help on how can I fix this error? I have installed all the dependencies including flashlight on condo environment successfully. But I keep getting this error.
I appreciate if you can share your idea on this error with me.
Traceback (most recent call last):
  File "/home/ai-labs/Desktop/ASR/fairseq/fairseq/data/dictionary.py", line 236, in add_from_file
    self.add_from_file(fd)
  File "/home/ai-labs/Desktop/ASR/fairseq/fairseq/data/dictionary.py", line 246, in add_from_file
    lines = f.readlines()
  File "/home/ai-labs/.conda/envs/asr3/lib/python3.7/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 64: invalid start byte

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "run_downstream.py", line 203, in <module>
    main()
  File "run_downstream.py", line 198, in main
    runner = Runner(args, config)
  File "/home/ai-labs/Desktop/ASR/s3prl/s3prl/downstream/runner.py", line 52, in __init__
    self.downstream = self._get_downstream()
  File "/home/ai-labs/Desktop/ASR/s3prl/s3prl/downstream/runner.py", line 133, in _get_downstream
    **vars(self.args)
  File "/home/ai-labs/Desktop/ASR/s3prl/s3prl/downstream/asr/expert.py", line 82, in __init__
    self.dictionary = Dictionary.load(self.datarc.get("dict_path", str(Path(__file__).parent / "char.dict")))
  File "/home/ai-labs/Desktop/ASR/fairseq/fairseq/data/dictionary.py", line 225, in load
    d.add_from_file(f)
  File "/home/ai-labs/Desktop/ASR/fairseq/fairseq/data/dictionary.py", line 242, in add_from_file
    "rebuild the dataset".format(f)
Exception: Incorrect encoding detected in ./downstream/asr/char.dict, please rebuild the dataset

I still have this error. Anyone can help please???

Any help on this pleaseeee>?

Could you try to re-install fairseq with fairseq@git+https://github.com//pytorch/fairseq.git@b5a039c292facba9c73f59ff34621ec131d82341#egg=fairseq

I find the latest master occasionally remove the fairseq dependency information, might lead you to install the latest fairseq which might not be compatible.

@leo19941227 thanks for replying on this issue.
When I do git clone https://github.com//pytorch/fairseq.git@b5a039c292facba9c73f59ff34621ec131d82341#egg=fairseq
It raises remote: Not Found error.
Could you give me the step by step of which branch you want me to check out?
Thanks for taking the time.

Oh, just check out the b5a039c292facba9c73f59ff34621ec131d82341  commit, and maybe run the pip install -e ./ again.

I can't find a branch name with the one you specified.
Is that what you mean?
git clone https://github.com/facebookresearch/fairseq.git
git checkout -b @b5a039c292facba9c73f59ff34621ec131d82341#egg=fairseq
Thanks again.

git checkout b5a039c292facba9c73f59ff34621ec131d82341

@leo19941227 thanks so much. I did try to checkout this branch and reinstall the fairseq. But the error still persist.
Is there anything else that I can check?
Again, thanks for taking the time, I appreciate it.

Hmm... I still can not reproduce.
Did you try the solutions on other places? (like https://stackoverflow.com/questions/38518023/unicodedecodeerror-utf8-codec-cant-decode-byte-0x80-in-position-3131-invali)
I guess this might be an env-specific issue.


Azure Backup Version 2019-05-13  addition

New api version 2019-05-13 for ProtectedItems_Get,ProtectedItems_CreateOrUpdate,RecoveryPoints_List,RecoveryPoints_Get,Restores_Trigger, BackupJobs_List, BackupProtectedItems_List and version 2017-07-01 for ProtectionPolicies_CreateOrUpdate
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

@SanjayHukumRana , could you take a look at those errors from the checks?

Hi @Renhe<EMAIL_ADDRESS>I have updated the PR multiple times but unable to understand this failure.
Can you please thrown some light on this like where it this picking incompatible values and how to fix it?
($.paths[\"/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig\"].patch.operationId)"\n}\nProcess() cancelled due to exception : '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n{\n  "Channel": "fatal",\n  "Text": "swagger-document/compose - FAILED"\n},\n{\n  "Channel": "fatal",\n  "Text": "Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n)."\n}\n(node:5399) UnhandledPromiseRejectionWarning: Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n    at Merge (/home/vsts/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist/lib/source-map/merging.js:58:11)\n    at Merge<EMAIL_ADDRESS>Thanks.
From: Renhe Li<EMAIL_ADDRESS>Sent: 29 September 2019 08:53
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Sanjay Rana<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Azure Backup Version 2019-05-13 addition (#7345)
@SanjayHukumRanahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSanjayHukumRana&data=02|01|rsanjay%40microsoft.com|7ff98e74b2be41dbae7e08d7448c64a3|72f988bf86f141af91ab2d7cd011db47|1|0|637053242082404010&sdata=4ORhi3kzwNajOPVXezNtW2HcE9htYSAGZw1oTR9L4wg%3D&reserved=0 , could you take a look at those errors from the checks?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7345%3Femail_source%3Dnotifications%26email_token%3DALCW2DB4OYQKUN7QZLAORCLQMANS5A5CNFSM4I3F7ZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73HDVY%23issuecomment-536244695&data=02|01|rsanjay%40microsoft.com|7ff98e74b2be41dbae7e08d7448c64a3|72f988bf86f141af91ab2d7cd011db47|1|0|637053242082404010&sdata=zfOD3YXEeL1jbDRcoWSCaBcnunnE4G5jHw7e8SK8cDs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALCW2DFTN5NTWWYDN64HSZ3QMANS5ANCNFSM4I3F7ZJA&data=02|01|rsanjay%40microsoft.com|7ff98e74b2be41dbae7e08d7448c64a3|72f988bf86f141af91ab2d7cd011db47|1|0|637053242082413997&sdata=yoNwubBqoVKyGQj6ofwa%2F39qZXNz5qwjUo0kpSKOlA8%3D&reserved=0.

Hi Renhe Li,
I have updated the PR multiple times but unable to understand this failure in lintdiff.
Can you please thrown some light on this like where it this picking incompatible values and how to fix it?
($.paths[\"/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig\"].patch.operationId)"\n}\nProcess() cancelled due to exception : '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n{\n  "Channel": "fatal",\n  "Text": "swagger-document/compose - FAILED"\n},\n{\n  "Channel": "fatal",\n  "Text": "Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n)."\n}\n(node:5399) UnhandledPromiseRejectionWarning: Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n    at Merge (/home/vsts/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist/lib/source-map/merging.js:58:11)\n    at Merge<EMAIL_ADDRESS>Thanks.

I added ARMReviewMeetingRequired to track the conversation with John Gossman and Mark Simms. Once direction is resolved with them, I'll review the changes as the PR could change drastically.

John Gossman approved the full deprecation of the api version.


Improve asserts in wagtail.

These improvements were based on flake8-assertive, which compiled an extensive
list of patterns to replace with more precise assertions. This should make
the error messages better in case of failures.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.org/en/latest/contributing/index.html and check the following:

Do the tests still pass? (https://docs.wagtail.org/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For front-end changes: Did you test on all of Wagtail’s supported environments?

Please list the exact browser and operating system versions you tested.
Please list which assistive technologies you tested.

For new features: Has the documentation been updated accordingly?

Note: we should add flake8-assertive as an additional depenency to
https://github.com/wagtail/wagtail/blob/main/.pre-commit-config.yaml#L15
    hooks:
      - id: flake8
    additional_dependencies:
      - flake8-assertive

after this is merged

Note: we should add flake8-assertive as an additional dependency to
https://github.com/wagtail/wagtail/blob/main/.pre-commit-config.yaml#L15
    hooks:
      - id: flake8
    additional_dependencies:
      - flake8-assertive

after this is merged

Good. This one fixes all of the warnings :)

Merged in a0ef2477a68f2deb83cdc9a0bb709cb644be028b. Thank you @atombrella


Towards #2709 - Allow port instead of portIndex for health checks

Improved health check documentation
Replaced JInt with scala Int in HealthCheck case class
Automatically add "portIndex": 0 when necessary to preserve backwards compatibility

Only minor comments. Looks good! :+1:
Please address and :ship:

@aquamatthias I hopefully addressed all your concerns in an additional commit. I can squash our two commits if you are happy (I would like to preserve Evans to give him credit where it's due).

Thanks! LGTM please squash and merge.

It is squashed! :)  We will not squash Evans patch.

Looks good. Thanks!


Cargo.toml: allow users to specify tls implementation

We allow the user to choose between the default
native-tls and rustls TLS implementations for the
reqwest dependency. The default behaviour remains
activating the previously used, default native-tls implementation, thus not breaking any clients.
Closes #11.

Hey @lpotthast would it be possible to get a review on these two open PRs?

@lpotthast I'm interest too

Tanks for the PR! Looking at the current feature declarations in https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml, a few questions came to mind:

The newest reqwest update introduced more default features. We should probably add them back manually. What are your thoughts? (see: https://github.com/seanmonstar/reqwest/compare/v0.11.27...v0.12.0#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542)
There does not seem to be a "rustls" feature (anymore), activating "rustls-tls" should be sufficient.
If we provide "default-tls", we should probably name the second feature "rustls-tls", to match the schema and to closely match reqwests feature names.

Thanks for the review! I opened https://github.com/lpotthast/axum-keycloak-auth/pull/19 as a preceding PR to update reqwest.

...

Done.

...

Done.

...

Done.

Looks good! Thanks for the quick changes.


[DOCs]  Run ARA Using Docker

The document  Run ARA Using Docker doesn't exist on github. we got a 404 http Error page.

Exist in 3.1.1 but not after


Integrate the catalog with the Calcite planner

This PR is currently a draft. The PR has grown too large to review and will be split into smaller PRs. This one will stay open to run the tests, but reviews should occur for the smaller PRs.
Prior PRs added the catalog (table metadata) foundations, and an improved set of table functions. This PR brings it all together:

Validates the MSQ INSERT and REPLACE statements against the catalog

Clustering, partitioning and other table details can be set in the catalog instead of the SQL statement
Catalog types are loosely enforced for MSQ. (More work is needed to precisely enforce types.)
The catalog can create a "sealed" table: only columns defined in the catalog can be used in MSQ.

Allows defining external tables and partial external tables (AKA "connections") in the catalog, then fill in the remaining details at runtime via a table function.
Allows parameters (including array parameters) to work with MSQ queries
Extends the PARTITION BY clause to accept string literals for the time partitioning
Extends MSQ to give the planner control over the type of the emitted segment columns
MSQ ITs to validate the new "ad-hoc" table functions
Documentation

To allow all the above to work:

Validation for MSQ statements moves out of the handers into a Druid-specific version of the SQL validator.
Druid-specific Calcite operator to represent a Druid ingest.
The catalog API is passed into the Druid planner (which required changes in the many tests that set up the planner).
The catalog can now be enabled in the Broker to allow the planner to interact with the Druid table metadata extension.
Many new tests to verify the catalog integration and improved MSQ statement validation.
Improved catalog type parsing in anticipation of supporting complex types.
Factored out the "per run" items from the planner into a planner toolbox, leaving just the "per session" items in the planner.
Resource shuttle now handles "partial table functions" for items defined in the catalog.

Release note
This PR introduces the full catalog functionality. See the documentation files for the details. In this version, the catalog is an extension: you must enable the catalog extension to use the catalog. Enabling the extension creates an additional table in your metadata database. We consider the catalog to be experimental, and the metadata table schema is subject to change.
Table functions, introduced in a prior PR, are production ready and independent of the catalog. "Partial table functions" (define some of the properties in the catalog, some in SQL) are new in this PR and are experimental, along with the catalog itself.
Hints to reviewers
Much of this PR is doc files, test code and minor cleanup. The core changes (those that could break a running system if done wrong) are:

extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/*
sql/src/main/*

The real core of this PR is sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: the place where we moved the former ad-hoc INSERT and REPLACE validation to instead run within the SQL validator.
No runtime code was changed: all the non-trivial changes are in the SQL planner.

This PR has:

[X] been self-reviewed.
[X] added documentation for new or modified features or behaviors.
[X] a release note entry in the PR description.
[X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Split out many changes into separate PRs, and merged the result. Reduced the file count from 217 to 139. Still big, but not quite so big.

This PR contains pom.xml file fixes that also appear in another PR. Feel free to ignore those files here.

@paul-rogers , this PR https://github.com/apache/druid/pull/14023 moved some things around, including 	docs/multi-stage-query/reference.md so that may be the cause of some merge conflicts.


Issue with module outputs

Config
I have a config which is similar to the one below:
main.tf
module "ecs_service" {
  source      = "./_ecs"
  task_cpu    = module.configs.result["ECS_TASK_CPU"]
  task_memory = module.configs.result["ECS_TASK_RAM"]
}

module "configs" {
  source    = "./_config"
  base_path = "./config/"
  files = [
    "config.base.json"
  ]
}

_ecs/main.tf
variable "task_cpu" {
  default = 256
}

variable "task_memory" {
  default = 512
}

resource "aws_ecs_task_definition" "task" {
  family                   = "task"
  requires_compatibilities = ["FARGATE"]
  network_mode             = "awsvpc"
  cpu                      = var.task_cpu
  memory                   = var.task_memory
  container_definitions = jsonencode([{
    name      = "container"
    image     = "alpine:latest"
    essential = true
  }])
}

resource "aws_ecs_service" "service" {
  name                               = "service"
  task_definition                    = aws_ecs_task_definition.task.arn
  cluster                            = "ecs"
  platform_version                   = "LATEST"
  launch_type                        = "FARGATE"
  propagate_tags                     = "TASK_DEFINITION"
  desired_count                      = 1
  deployment_maximum_percent         = 100
  deployment_minimum_healthy_percent = 0
}

_config/main.tf
variable "files" {
  type = list(string)
}

variable "base_path" {
}

variable "base_object" {
  default = {}
}

locals {
  searched_files = flatten([for v in var.files : sort(fileset(var.base_path, v))])
  loaded_files   = [for v in local.searched_files : jsondecode(file("${var.base_path}/${v}"))]
}

output "result" {
  value = merge(concat([var.base_object], local.loaded_files)...)
}

config/config.base.json
{
  "ECS_TASK_CPU": 256,
  "ECS_TASK_RAM": 512
}

Error
Running terraform plan works fine:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.ecs_service.aws_ecs_service.service will be created
  + resource "aws_ecs_service" "service" {
      + cluster                            = "ecs"
      + deployment_maximum_percent         = 100
      + deployment_minimum_healthy_percent = 0
      + desired_count                      = 1
      + enable_ecs_managed_tags            = false
      + enable_execute_command             = false
      + iam_role                           = (known after apply)
      + id                                 = (known after apply)
      + launch_type                        = "FARGATE"
      + name                               = "service"
      + platform_version                   = "LATEST"
      + propagate_tags                     = "TASK_DEFINITION"
      + scheduling_strategy                = "REPLICA"
      + tags_all                           = (known after apply)
      + task_definition                    = (known after apply)
      + wait_for_steady_state              = false
    }

  # module.ecs_service.aws_ecs_task_definition.task will be created
  + resource "aws_ecs_task_definition" "task" {
      + arn                      = (known after apply)
      + container_definitions    = jsonencode(
            [
              + {
                  + essential = true
                  + image     = "alpine:latest"
                  + name      = "container"
                },
            ]
        )
      + cpu                      = "256"
      + family                   = "task"
      + id                       = (known after apply)
      + memory                   = "512"
      + network_mode             = "awsvpc"
      + requires_compatibilities = [
          + "FARGATE",
        ]
      + revision                 = (known after apply)
      + skip_destroy             = false
      + tags_all                 = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Task CPU and Memory are ok in the above terraform plan, which should be the values used for infracost computation.
However infracost breakdown --path=. outputs zero costs:
Evaluating Terraform directory at .
  ✔ Downloading Terraform modules
  ✔ Evaluating Terraform directory
  ✔ Retrieving cloud prices to calculate costs

Project: .

 Name  Monthly Qty  Unit  Monthly Cost

 OVERALL TOTAL                   $0.00
──────────────────────────────────
2 cloud resources were detected:
∙ 1 was estimated
∙ 1 was free, rerun with --show-skipped to see details

@tim775 reproducible error from our slack thread.
Thanks for taking a look at this.

We can't use absolute paths due to CI/local machines.
I'll wait for your resolotion 😄

@rmgpinto Thanks for the awesome test case, that made all the difference in being able to track this down.  The fix will go live in the next release, which should be in the middle of next week.


[WIP] feat: join clauses

ref: #26
Implemented the join clause.
I will implement tests later.

Thanks @kiibo382 ! Great to have you as a contributor!
I would be fine to merge this (with a couple of quick tests, would be great, let me know if you need a hand — we're using https://github.com/mitsuhiko/insta so it should be very easy once you're familiar with it).
I'm less confident on the semantics of joins than other parts of the language, and obviously it's a really important part of SQL. There's been some discussion on discord. I would suggest we merge something and then keep iterating. One immediate choice is whether we have:
employees
right_join payroll

or
employees
join side:right payroll

...probably defaulting to inner. The advantage of this is it lets us add more types later, like equi / semi / anti joins, without increasing the number of keywords.
I'd be fine with either at the moment — your call. (But I hope it's OK to say that we may change it later based on consensus)

Ah, you already added tests, faster than I could comment :)
I will merge this and we can iterate further at your discretion

Thank you!

I'm less confident on the semantics of joins than other parts of the language, and obviously it's a really important part of SQL. There's been some discussion on discord. I would suggest we merge something and then keep iterating. One immediate choice is whether we have:

Let's discuss it in discord!


favicon for uwlswd pages

uwlib-mig and uwlib-cams pages use favicons (see webviews/images) obtained from Wikimedia Commons (with open/CCZero licenses). Add favicon for use in UWLSWD HTML.

📰 THIS JUST IN...
RDF logo in the public domain??? See Wikimedia Commons > File:Rdf logo.svg > Licensing
(Needs further investigation...)

See also:

W3C Semantic Web Logos and Policies
W3C RDF Resource Description Framework Icons -- looks as if the triple icon seen at the Wikimedia Commons link above has been deprecated by the W3C in favor of the new cube designs at link above

Looking at the policies for the W3C Semantic Web Logo, I believe we would be allowed to use something like this:
<link href="https://www.w3.org/Icons/SW/sw-cube.png" alt="W3C Semantic Web Logo" rel="icon" type="image/png">

I propose sticking with the CAMS favicon, which is from Wikimedia Commons and was published without any restrictions, to avoid needing to 1) observe any attribution requirements for W3C icons and 2) determine whether we would be, by using the W3C icon, asserting that our data meets certain requirements.

<link rel="icon" type="image/png"
                        href="https://uwlib-cams.github.io/webviews/images/book.png"/>


Make it so you can rename RobloxPlayerBeta and still be recognized by Bloxstrap

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
It's for shaders to work with the website

Don't mind the username my sister named it.

https://bloxshade.com


No new page between part & section

When there’s text between a part and a section header,  the section shouldn’t start on a new page.

Idem for section & subsection


Windows tests failing when downloading canvaskit zip file

See: https://ci.chromium.org/ui/p/flutter/builders/try/Windows build_tests_2_3/22426/overview
per @jason-simmons a dart archive package upgrade should fix this.

cc: @jonahwilliams

Fixed via https://github.com/flutter/flutter/pull/106157


The 'w' example on the github page is wrong..

[This is related to #10, but github doesn't allow me to reopen closed tickets.]
The "improved" output given for w is wrong, same issue as in the ticket #11. (The division vs multiplication problem.)
Just keeping this ticket here so the very first example people see can be fixed when #11 is fixed as well!

Should be fixed now.  This was actually just an issue with me sucking at copy/pasting :(


Allow basic authentication with preshared key

LFMerge needs to be able to authenticate to us with a preshared secret. This would effectively give it admin permissions.

per a conversation with Robin we're not going to do this. Instead we're just going to just create an admin in the system and that's what LFMerge uses to authenticate.


Add formula for doas.rb

The test I wrote doesn't work and I'm not sure why, but otherwise this should at least build and install doas.


APEX 21.2 -  Font APEX Icon "fa-rss-square" is empty (?)

Hi Jari,
I can't believe it - the "fa-rss-square" has an empty icon in APEX 21.2...
I searched over a hour because I thougt it has to do with translation...
I use "fa-feed" now...

I'm using APEX 21.2.5 and instance IMAGE_PRIFIX points to CDN https://static.oracle.com/cdn/apex/21.2.4/
There is that icon. You can check from my blog that it's displayed correctly.
https://cloud.jaris.fi/ords/r/jaris/blog/home
What is your exact APEX version you use?

When check your blog and using browser developer tools, I can see that you also have icon fa-rss-square.
Could your problem be e.g. browser cache? Try clear cache and see if it helps.

I'm at 21.2.5 too - Free Autonomous Transaction Database @OracleCloud...
Very interesting, if I look at my blog with dev tools I see fa-feed 😉
If I will find the error I'll post it here ...

Yes, now icon in right hand column is that fa-feed as you have changed it. But when I did inspect element using browser developer tools and changes class back to fa-rss-square, I can see correct icon.
From that I think you should have that icon.


Metadata API token

Description & motivation

Pre-release docs
Is this change related to an unreleased version of dbt?

[X] No: please ensure the base branch is current

Checklist
If you added new pages (delete if not applicable):

[X] The page has been added to website/sidebars.js
[X] The new page has a unique filename

@barryaron this is looking good to me! I added a couple of comments/questions. One other thing - it looks like website/package-lock.json was changed, but none of the dependencies for this website have actually changed! Can you revert that change before merging this?


Make map_from_arrays and map_from_pairs generic

This PR makes the map_from_arrays and map_from_pairs accept values that can be turned into an iterator. This avoids additional allocations required to have a slice when calling these functions.

Should be good now 👍

Not sure why the clippy started complaining about the lifetimes in binary.rs and list.rs, fixed that by removing those lifetimes.

Thanks for the PR! Do you maybe have a benchmark how much this saves?

Thanks for the PR! Do you maybe have a benchmark how much this saves?

Thanks for asking because I have no idea why, but this PR is 10x slower 😀, I'll have to investigate...

@evnu I figured it out but now the "correct" implementation is a breaking change. It comes down to &(A, B) vs (&A, &B). When I make the iterator type (&A, &B), the performance is the same but I can't pass &a where let a: Vec<(A, B)> anymore, which is a breaking change. For now I'm going to close this PR as there is no increased performance benefit and then it doesn't justify a breaking change I think.


⚠ Bofrost.de has degraded performance

In 1efaabc, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1557 ms

Resolved: Bofrost.de performance has improved in 757b6d0.


Update volume naming for rbd, pv and pvc to NAMESPACE-PVCNAME-ShortUUID

This update provides a more human readable naming convention for the RBD volume, PV and PVC.
Inspired from the netapp-trident provisionner volume naming.

Can you give an example of the name before and the name after the change? So we can explain it when we make the PR upstream?
Also, are you aware of any tests that this change would break because of the different name?

Old naming
RBD Volume : kubernetes-dynamic-pvc-a8bbf77b-a555-11e8-b000-fe0a7058380b
PVC : infra-graphite      graphite-volume-claim           Bound     pvc-a8b25adf-a555-11e8-95c1-005056a363e3               1Ti        RWO            rbd            23d
PV : pvc-a8b25adf-a555-11e8-95c1-005056a363e3               1Ti        RWO            Delete           Bound      infra-graphite/graphite-volume-claim             rbd                      23d
New naming
RBD Volume :  graphite-volume-claim-a5021f84
PVC : infra-graphite              graphite-volume-claim                Bound     infra-graphite-graphite-volume-claim-a5021f84                      1Ti        RWO            rbd            1h
PV : infra-graphite-graphite-volume-claim-a5021f84                      1Ti        RWO            Delete           Bound      infra-graphite/graphite-volume-claim                         rbd                      1h
Beside the short uuid which is created in the provision function, all other variables used comes from the k8s volume object. If something not allowed by k8s is used it should be rejected before trying to create the volume in ceph and the related k8s entry. A really long namespace + pvc name could be tested if it goes further than the allowed limit (if there is one), but in that case the PVC will never be bound as the char limit was reached and the volume cannot be created.


Run bot stats commands in #Discord-Stats channel daily

Would like to run the following commands daily at midnight EST in #Discord-Stats channel:
<>totalusers
<>activeusers
<>totalmessages
<>messagemin

Should this be synced to metabase as well?

@kauffj this data is avaible in a mysql database FYI

@filipnyquist Can we get the role bot on the wunderbot server?  Then we can setup access to the mysql database.
I'm still looking forward to your new bot and maybe a stats module when the time comes :)

@tzarebczan i´ll move over the bot to the wunderbot server, want mysql db to be there or any other place? Yes, i also look forward to it, home the whole next week so great things to come ;)

what's the progress on this?
Should I take a look myself?

We added the SQL database to metabase, so we have the data available. A single dashboard was created, we'll look into more.
I don't think we need to run this is in Discord anymore since we have the data available.


tel: links get crawled

Despite beeing blacklisted in checkIfCrawlable tel links get crawled.
tested via
$crawler = new \Arachnid\Crawler('https://www.handyflash.de/', 3);
$crawler->traverse();

in the apache accesslog a hit like
www.handyflash.de:443 213.XXX.YYY.ZZZ - - [10/Jun/2016:12:24:42 +0200] "GET /tel:+4923199778877 HTTP/1.1" 404 37312 "-" "Symfony2 BrowserKit" 0

is recorded

This bug is solved now,
verified in this test https://github.com/codeguy/arachnid/blob/master/tests/src/CrawlerTest.php#L381

@zrashwani I don't have time to maintain this project. Would you like me to transfer ownership of it to you?

@codeguy yes, I am planning to continue maintaining the project, so please transfer ownership to me


[REVIEW] FayasNoushad

GitHub Profile Link
https://github.com/FayasNoushad

Hey @FayasNoushad nice profile.
I've made a PR https://github.com/FayasNoushad/FayasNoushad/pull/2
Otherwise I would recommend to remove the GitHub Badge in the "My Accounts" section due we are allready on your Github Profile.

Hey @FayasNoushad nice profile.
I've made a PR FayasNoushad/FayasNoushad#2
Otherwise I would recommend to remove the GitHub Badge in the "My Accounts" section due we are allready on your Github Profile.

Done ✅, and thanks for your pull request.

Wow, @FayasNoushad, amazing profile; I loved it! 🥳🎉
I've made a pull request for some minor improvements. 🙂
Thanks for sharing your profile with the community! 😄

@FayasNoushad Hey dude you have a amazing profile i really like it plz go ahead

Wow, @FayasNoushad, amazing profile; I loved it!
I've made a pull request for some minor improvements.
Thanks for sharing your profile with the community!

Done

Things added/changed:
I've made Pull request  for Minor improvements in the README.md file.
All the changes are shown in the Git diff. If you have any questions/comments, let me know. 🙂

@FayasNoushad
Things added/changed:
I've made Pull request  for Minor improvements in the README.md file.
All the changes are shown in the Git diff. If you have any questions/comments, let me know.

Merged 👍

Your profile looks amazing! I love it! Surely a lot of people like it. 😄🥳🎉

Your profile looks amazing! I love it! Surely a lot of people like it.

Thanks 😊

@FayasNoushad
Awesome work! I liked the profile a lot! It'll be great when it's reviewed in a live stream. Great work! 😄🥳🎉

@FayasNoushad
Awesome work! I liked the profile a lot! It'll be great when it's reviewed in a live stream. Great work!

Hmm

Requested Changes 😉

[ ] I don't think having bullet points on the right and text on the center is good for readability (IMO it looks weird)
[ ] Link the links like google maps, using <a target="_blank"> to make it open on a new tab

Feedback

[x] Pretty cool that you link almost everything ❤
[x] I personally love it for being sophisticated, minimal, and informative
[x] You are using all GitHub settings wisely 🤩

Copy This Checklist Paste It Into An Comment Then Keep It Updated With Your Workflow. I will update mine once I see your checklist is updated 😃

I really love how you have centered things at the beginning of the Readme.md.
Instead of saying my accounts you could replace it with Connect with me

Looks great, some thoughts

Really concise GitHub profile
Very commit heavy, suggest doing code reviews as well
Maybe a photo/banner would be a bit more creative

Review live stream https://www.youtube.com/watch?v=NxxJ_5nyG9E


Add a user-facing documentation home page, for installing and configuring

Currently there is some developer documentation on GitHub, and MCR documentation on docs.mirantis.com

https://github.com/Mirantis/cri-dockerd/#build-and-install

https://docs.mirantis.com/mcr/20.10/single/#use-mcr-with-kubernetes

But there is no information for Docker Engine users, how install a cri-dockerd package and configure crictl.
One could use GitHub Pages for this home page, perhaps ?
Ideally it should have a vanity domain like cri-dockerd.io
Like:

https://containerd.io
https://cri-o.io

It was just fyi.

GitHub will have to do.


scitools-docs.github.io is broken

The documentation build for the latest code in the main GitHub repository at https://scitools-docs.github.io/iris/master/index.html is broken

If I understand right, then #2981 may address this ?

Confirmed. Last commit on https://github.com/scitools-docs/iris was 19 hours ago, suggesting this is now fixed! 🎉


pass channels to overlays with three arguments

just to add more flexibility to overlays, allow overlays to ask for channels as their first argument.

I think this feature can deprecate the overlays builder. Since
Any function with a channels: final: prev: passed to channels.overlays = [];` now is effectively is at par in capabilities of the current overlaysBuilder.

I think passing pkgs was done for the motive of accessing foreign channels, not foreign architectures (which wouldn't btw make a terrible lot of sense for building overlays).

Closing this, I think its a bit to "magical" to include for a overlaysBuilder argument


Set color and other attributes of Nodes and Edges

How can i set the color and other atributes of Nodes and Edges (I'm trying to use msagl directly from html/javascript) and is there a list of implemented attributes?

Please see example at renderer-svg-no-parser

There is no list of implemented attributes yet, sorry. I will add it to the docs. It is not difficult to add attributes supported by the SVG renderer.
For completeness I am adding the code that creates the attributes in renderer-svg-no-parser.
`import {RendererSvg} from '@msagl/renderer-svg'
import {Node, Graph, Edge} from '@msagl/core'
import { DrawingEdge, Color, StyleEnum, ShapeEnum } from '@msagl/drawing'
import { DrawingNode } from '@msagl/drawing'
const viewer = document.getElementById('viewer')
const svgRenderer = new RendererSvg(viewer)
svgRenderer.layoutEditingEnabled = false
const graph = createGraph()
svgRenderer.setGraph(graph)
function createGraph(): Graph {
//First we create a Graph object
const graph = new Graph()
// add some nodes and edges to the graph.
// add a node with id 'b'
const b = new Node('b')
graph.addNode(b)
// add a node with id 'c'
//create a drawing attribute for node b
const b_d = new DrawingNode(b)
b_d.color = Color.Green
// take care of the filling
b_d.fillColor = Color.Yellow
b_d.styles.push(StyleEnum.filled)
b_d.labelfontcolor = Color.Blue
const c = new Node('c')
const c_d = new DrawingNode(c)
c_d.labelfontcolor = Color.Cyan
// by default the node geometry is a rectangle with smoothened corners,
// but we can change the geometry by using, CurveFactory.mkCircle, CurveFactory.mkEllipse, CurveFactory.mkPolygon,etc
// Or, alternatively we can use Shape attribute to change the shape of the node.
// Here we change the shape of the node to diamond
c_d.shape = ShapeEnum.diamond
graph.addNode(c)
// create edge from b to c
const bc = new Edge(b, c)
// set the bc drawing edge attributes
const bc_d = new DrawingEdge(bc, true)
bc_d.color = Color.Red
// bc_d.width = 6 // is not supported in the svg renderer currently
bc_d.penwidth = 0.1
// bc_d.fillColor = Color.Green // not supported in the svg renderer currently
bc_d.styles.push(StyleEnum.dashed)
const obc = new Edge(b, c) // another edge from b to c
// set the obc drawing edge attributes
const obc_d = new DrawingEdge(obc, true)
obc_d.color = Color.Blue
obc_d.penwidth = 1
obc_d.styles.push(StyleEnum.dotted)
return graph
}`


Spectrum Dex Provider Integration (WIP)

I wanted to commit the code I currently have for integrating Spectrum, to reduce duplicated effort & allow collaboration. 🚀

Initial Spectrum Implementation with on-chain pool identification & swap order support logic. 🤝

Notes:

I've created a decimalToFractionalImproved method in hope to reduce the coupled dependencies of mathjs when ported from their SDK (Untested).
estimatedGive, estimatedReceive & priceImpactPercent need calculation logic implementing.

Important:
Spectrum uses the plutus v2, inline datum feature, if we use this on any v1 implementation it makes it impossible to retrieve the assets, I've left this out of the payToContract for this reason, just an idea but it might be worth us splitting out the method on this to limit risk.

We also need to add Spectrum into the available DEXs in the Dexter class

I have intentionally left out the code to switch between supporting an inline datum for Spectrum, or not for other DEXS.
We will need a reliable way of switching the payToContract to support an inline datum but only for Spectrum.
transaction.providerData.tx.payToContract(payToAddress.address, { inline: payToAddress.datum as Datum }, payment);

Closing as Spectrum was taken care in another PR


Can not use it for VIM 7.4

Error detected while processing BufEnter Auto commands for "*":
E884: Function name cannot contain a colon: indentdetector:hook(1, 3)
Press ENTER or type command to continue

Problems happened on this version of Mac Vim:
:version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun  7 2015 09:10:33)
MacOS X (unix) version
Included patches: 1-712
Compiled by<EMAIL_ADDRESS>Huge version with MacVim GUI.  Features included (+) or not (-):

And has no problem on this version:
:version
VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Nov  5 2014 21:00:28)
Compiled by<EMAIL_ADDRESS>Normal version without GUI.  Features included (+) or not (-):

Thx for your feedback. It seems that I made a stupid mistake when renaming functions : )
Now I fixed it, try it.  still feedback to me if there is any problem.


fluentvalidation.aspnetcore 8.4.0 taking too long to install at Visual Studio 2017(15.9.13)

System Details

FluentValidation.Aspnetcore version: 8.4.0

Issue Description
I am trying to install nuget package  FluentValidation.Aspnetcore version: 8.4.0 in visual studio 2017 (15.9.3).
I am using Microsoft.AspnetCore is 2.2
Installing Microsoft.AspNetCore.Cryptography.Internal 2.1.0.
Installing Microsoft.AspNetCore.DataProtection.Abstractions 2.1.0.
Installing Microsoft.Extensions.Hosting.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Hosting.Server.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Authentication.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Authorization 2.1.0.
Installing Microsoft.Net.Http.Headers 2.1.0.
Installing Microsoft.AspNetCore.WebUtilities 2.1.0.
Installing Microsoft.Extensions.Configuration.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Hosting.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Authentication.Core 2.1.0.
Installing Microsoft.AspNetCore.Authorization.Policy 2.1.0.
Installing Microsoft.AspNetCore.Routing 2.1.0.
Installing Microsoft.AspNetCore.Mvc.Abstractions 2.1.0.
Installing Microsoft.AspNetCore.Http.Extensions 2.1.0.
Installing FluentValidation.DependencyInjectionExtensions 8.5.0-preview2.
and nothing get installed at this point its going to stuck .
kindly guide me i am stuck from few days but not get any solution.

Hi, I’m not really sure what you’re asking for help with? If you have a problem with FluentValidation itself then I can help with that, but if you’re having issues connecting to nuget then there’s not really anything I can do to help I’m afraid.
Maybe try running some network diagnostics to see if that gives you a clue? You could also try downloading the packages manually and add them to the local nuget cache if you continue to have connectivity problems.

Also maybe try explicitly specifying the 8.4.0 version when installing the package, from the log it looks like you’re trying to pull 8.5 preview2.

Thanks alot for your quick reply.
Yes i have tried all version for aspnetcore they got stuck not they showing installing....
but when i install simple fluentvalidation 8.4.0 it get installed.
i sent message like might possible i got help and my issue got resolved. thanks

As I said before, I can't help you with nuget connectivity issues I'm afraid as that's not something I have control over - this isn't a problem with the packages themselves, it's most likely a network related problem at your end.
I'd still suggest you try what I said previously and download & install the packages manually if you're not able to find the cause. Also might be worth trying to install via VS2019, or via the dotnet cli to see if that makes any difference.


Remove Custom schema by clicking that small delete button and try to switch the config. getting warning with 'unsaved changes'

fixed in #167

fixed in #167


Add tests for CLI

Fixes #1746
How to test
yarn bootstrap -- --core
yarn test:cli
yarn bootstrap -- --reset --core
nvm use 4
yarn test:cli

[x] Add fixtures for all supported project types
[x] Automatically update CRA/CRNA fixtures before each test
[x] Support node v4 (see #1466)
[ ] Run node v4 and v6 tests on CI (help needed, see below)
[x] Use snapshots
[ ] Add smoke tests for start-storybook (depends on https://github.com/storybooks/storybook/pull/1790)
[x] Integrate tests for CLI into CLI for tests

Speaking of node 4/6 testing on CI, the trick is that we should bootstrap with node 8 (as it's the version we support for contributing), and then run tests with an older version. I tried to use some docker images with nvm, but had no success in that (see for instance https://circleci.com/gh/storybooks/storybook/9091).

Why do we have to test on older node versions?

How about because node 4 is maintained until April 2018?

I think the rest can be addressed in separate PRs


Typo in app.py

Thanks for the app!
Id like to ask you, to check this please:
at app.py, line 100:
            params = (password + "\n" + password + "\n").encode()

But params is not referenced later in the code. Changing params to input_param solves this.

Wow, nice catch!

Wow, nice catch!


Low speeds on a 3080ti

Hello,
Firstly thank you for sharing a very clear implementation of your work! It is great!
For some reason, my training is very slow and I was wondering if I must include something in the training command to achieve speeds as fast as the ones you show. Right now, it has been more than 15 minutes and I am on itteration 460 only, with a PSNR of 24.92 and the loading bar says 2%.
I am on Windows 10 with a 3080ti gpu. I followed the instructions for downloading and installing the packages in the conda environment as specified.
Any help is appreciated, thank you!

fixed: just had to install the latests pytorch but wrapped in CUDA by doing
`
conda install pytorch torchvision torchaudio cudatoolkit=11.3 -c pytorch
`
might be worth updating the instructions for that

Hi，I am running on windows 10,3060, using your command but still in very low speed......


Add configuration option for RegExp for Redirect Channel

I have the following problem:
Sometimes we have larger incidents in our ticketssystem that we want to chat about.
Therefore I want to add emails from our ticketsystem to the chatroom that is corresponding with the ticket number.
Our ticketsystem creates emails with the subject tag "[Orgname#0123456789] subject"
Mattermail will forward an email with such an subject neither to the channel #0123456789 nor to "Orgname#0123456789" as it excpects a "[#" in the subject.
I could fork mattermail and remove the "[" from the check. I already saw that at least one forked mattermail for just a similar reason. But then my fork will be not benefit from further updates.
Therefore my request:
Could you make the RegExp a variable that can be editied in the config file?
If I am correct it is just this line in your code:
https://github.com/rodcorsi/mattermail/blob/master/mmail/mattermail.go#L425

Hi @CmdrMichael !
You can set NoRedirectChannel: false, this option will disable redirect email by the subject.
https://github.com/rodcorsi/mattermail/blob/master/mmail/mattermail.go#L283

Hi @rodcorsi,
yes, but I want the redirection.
For longer incidents, we want to create seperate chatrooms. Then we have everything documented in a single chat room.
My plan was, to create an email address like<EMAIL_ADDRESS>and CC every email from the ticketsystem to the chat.
Then we would have emails with subject [ticket#123] sent to chatroom #123 and emails with subject [ticket#456] sent to chatroom #456.
The current redirection does not work, it expects the "#" directly after the "[".

I understand your problem but I don't like the idea of putting regex inside a json as configuration because it is not easy to test and need to use escape chars.
In your example [ticket#123]. #123 is the channel and ticket is the team?

I think this commit solve this issue


Merged Vertices Issue

Hey, I'm trying to extract some models from games and I'm having some issues with the morphs. So I used your tool to get the assets into Unity so I could export them from there in hopes of getting not exploded morphs, which let me say thank you so much because it does work for that.
However I'm running into a different problem. When I actually view the morphs on the model itself, the vertices are merged where they shouldn't. Probably from auto merging just because they're close. Mostly on the mouth. I tried to fix this directly in Unity, but to no avail.
I guess I was kind of wondering does this program automatically join vertices on its own? If so, how can I make it not do that? Or if any of you could help me in getting it to stop doing that when importing to Unity if thats Unity's fault. Thanks!

Hi. No ripper doesn't merge vertices. However internally, depending on the version, Unity represent vertices in different way. Since ripper export assets for 2017.3 it has to convert one format into another. Your problem may be connected with this conversion but I can't say for sure let alone fix this problem without sample file.

Alright. I've attached a sample below if you wouldn't mind looking into it.
sample.zip

I checked the file you uploaded and I don't understand what your problem is about. Every morph in exported prefab works fine. I don't know how you got such effect as on your OP picture.

I'm not sure either, perhaps its my unity or the program I used to import the FBX. What version of Unity do you use?

2017.3
So you check blend shapes not in Unity but in some other software?

No, I don't think I check it at all and I have tried various programs but same result so not sure. I'm also not well versed in the actual program for Unity either. So perhaps its checked automatically. But I was trying to search for that, and couldn't find anything.
Sorry to bring this up again since my response was so late.

I mean exported assets works only in Unity. If you use some 3rd party tools to view or converts assets then I can't help you. Ask developers of that tools.

Nah, I'm putting it through Unity first then tryna export as FBX.

That is what I tell you. Ask the developer of this FBX exporter to help you since Unity asset works fine.


Add a license

Could you please add a license file to the repository so people can tell under what terms the code can be used? The MIT license would be a nice choice, if possible. Thanks!

license granted!

Thanks!


CDS Hooks Services Version

Are there any thoughts on how to advertise/handle the CDS Hooks service version?
This could be handled as part of the service discovery -- e.g. include the version as an attribute in the cds-services payload.
{
  "services": [
    {
      "hook": "patient-view",
      "title": "Static CDS Service Example",
      "description": "An example of a CDS service that returns a static set of cards",
      "id": "static-patient-greeter",
      "cds-hooks-version": "1.0.0"
    }
  ]
}

@bkaney - Can you elaborate on why you think this would be valuable?
For instance, we don't define this today with SMART apps. If a CDS Service is offered as software as a service (SaaS), and every company I've talked to is working under this model, then I'm not sure why version needs to be exposed.
If the CDS Service provider wants to explicitly version its services, this would be best put in the id field.
For instance, in your above example the CDS Service would be available at https://example.com/static-patient-greeter. So, when you version it to 2.0 it's still at the same URL. If your intention is to allow the EHR to make a purposeful decision to move to 2.0 then you'd want the URL to change too. So, the id could be static-patient-greeter-2.0 making the URL https://example.com/static-patient-greeter-2.0
Thoughts?

I see the confusion. It's not about the cds service version, it's the CDS Hooks version the service conforms to. My example is misleading, so I updated it.

I agree that the version of CDS Hooks is relevant. However wouldn't that also potentially impact the fields/etc in the discovery endpoint?  Do you see mixing versions of cds hooks (ie 2 services, 1 with hooks v1 and another with hooks v2)? If not, perhaps it should at the same level as "services". This should probably also align with how to represent the FHIR version that the service supports - #3.

Some options I can imagine:

The CDS Service definition returned from the Discovery call contains the CDS Hooks specification version supported
Every call made by the EHR contains the CDS Hooks specification version. This allows the CDS Service to respond accordingly (for instance, perhaps the Discovery response flexes to only return CDS Services that can handle the particular CDS Hooks specification version in use).

Furthermore, I'll echo @olbrich's suggestion of a new JSON field or HTTP header are both options to communicate the specification version.
My proposal is that we do not address this today. We only need to address this once we introduce a new version of the CDS Hooks specification in which the CDS Service needs to change its behavior based upon the specification version in use. If we introduce a new specification version that contains breaking or other changes which necessitate its communication, we can simply add this per the above options. The absence of this version information just means we're dealing with pre-specification versions in which this information doesn't matter (eg, 1.0).
If the community is OK with this proposal, we'd close this issue and simply re-open it if we end up needing to address this due to a future specification change.

I'll disagree that we don't need to address this today as Stanson Health's solution is already providing multiple versions in production. The reality that the movement of the standard is rather slow, resulting in either un-official versions (which I have 2 of now) or extension needs which get augmented over time both on the caller and service ends. For example, the change from patient and encounter in the main request to being part of the context was a significantly breaking change - I realize the spec isn't official yet, but not allowing early implementations (and thereby multiple versions) leads to a chicken and the egg problem. At the moment URL differences are used, in part to allow easy movement by the EMR from one version to the next with minimal support by the service as well as supporting 'custom' versions on a one-off basis.
With respect to every call containing the Hooks specification, I believe this still should require the version(s) supported shown in the discovery or via some other mechanism. Ideally that would be coupled with the specification details in some form, such that an implementer could access those details and build their interface to the service without additional documentation.
As mentioned above, this and the FHIR version (which we certainly have 2 standards and both in production to various degrees) should be implemented similarly.
Ultimately I don't think this is a particularly hard issue to solve, and I really don't see it as controversial - unless the standard is a dead-end, there will be multiple versions.

FWIW, since the return of the discover call is also subject to variations across CDS Hooks versions, I'd opt to expose the version as an HTTP Header.

I just want to add here that we are also now affected by this. We have released code where user is at the top level. However, user has now been moved to the context. Yet there is no version or any kind of differentiator we can include to allow the CDS Service to determine whether the payload has this change or not, (short of looking to see where the user is).
So adding myself also on the list of affected parties requesting some capability on this front.


Investigate slow tests

A few tests, e.g. descriptors for a trajectory, are very slow, so we should check if they can be simplified, while retaining the same utility.

For reference, one example on my laptop:
226.07s call     tests/test_descriptors_cli.py::test_traj
66.50s call     tests/test_phonons_cli.py::test_plot
63.05s call     tests/test_train_cli.py::test_fine_tune
22.88s call     tests/test_eos_cli.py::test_minimising_all
20.36s call     tests/test_correlator.py::test_md_correlations
12.99s call     tests/test_md_cli.py::test_seed
12.53s call     tests/test_phonons_cli.py::test_bands
10.89s call     tests/test_geom_opt.py::test_str_optimizer
10.45s call     tests/test_eos_cli.py::test_eos
9.44s call     tests/test_eos.py::test_calc_eos
9.29s call     tests/test_eos_cli.py::test_writing_structs
8.80s call     tests/test_train_cli.py::test_train
8.75s call     tests/test_phonons_cli.py::test_bands_simple
8.57s call     tests/test_md.py::test_minimize_every
8.38s call     tests/test_eos_cli.py::test_setting_lattice

So out of 950s, around half is due to the slowest five tests, with almost a a quarter is from tests/test_descriptors_cli.py::test_traj alone

(tests/test_descriptors_cli.py::test_traj appears to have been resolved by #244)

ok for descriptors the summary seems to misbehave when more than one frame is present
head -n 20 descriptors_summary.yml
command: janus descriptors
inputs:
  calc:
    arch: mace_mp
    calc_kwargs:
      model: ../models/ft_medium.5.model
    device: cuda
    model_path: null
    read_kwargs: {}
  calc_per_element: false
  invariants_only: true
  log: descriptors.log
  struct:
  - !!python/object:ase.atoms.Atoms
    _calc: &id001 !!python/object:mace.calculators.mace.MACECalculator
      _directory: .
      atoms: null
      charges_key: Qs
      device: !!python/object/apply:torch.device
      - cuda

ok issue is caused by this
https://github.com/stfc/janus-core/blob/b45d5fdcea3fe5f1df176d0ae2f1621dd9be8027/janus_core/cli/descriptors.py#L144
I suspect is a left over from refactoring... since single point seems to use a different strategy... using the same here... brings back the speed

ok for descriptors the summary seems to misbehave when more than one frame is present
head -n 20 descriptors_summary.yml
command: janus descriptors
inputs:
  calc:
    arch: mace_mp
    calc_kwargs:
      model: ../models/ft_medium.5.model
    device: cuda
    model_path: null
    read_kwargs: {}
  calc_per_element: false
  invariants_only: true
  log: descriptors.log
  struct:
  - !!python/object:ase.atoms.Atoms
    _calc: &id001 !!python/object:mace.calculators.mace.MACECalculator
      _directory: .
      atoms: null
      charges_key: Qs
      device: !!python/object/apply:torch.device
      - cuda

That's what #244 should have fixed. Has it not?
So struct is added to inputs in the line you linked, but thensave_struct_calc should clean it up, so we don't have to do it for each calc individually

is this still active?

tests/test_descriptors_cli.py::test_traj is fixed, which was the biggest concern, and an actual bug.
I'm still hoping to reduce the time of the slowest e.g. tests/test_phonons_cli.py::test_plot and tests/test_train_cli.py::test_fine_tune a little if possible at some point, but they're a lower priority, as I'm not sure how much they can be sped up without losing functionality.


HTTP Server Options

I'm facing an issue using aws-serverless-express with my application. Because of new node versions, http request headers are limited to 8KB, and I need more than this. According to the Node documentation, I'm able to increase this limit by passing an options object to the http createServer method, with the "maxHeaderSize" property, but aws-serverless-express won't let me do this, as It's createServer method doesn't expect an options object.

check serverless-http as suggested in #271

check serverless-http as suggested in #271

I'm doing some tests with serverless-http and It's working nicely, but I can't figure out why aws-serverless-express won't let us to pass an options object to Node's http server. Wouldn't it be interesting to leave this option free for the user to define?


Rework segmented SDO handling

Currently can_message_t has a char array, large enough to hold a segmented data string. This isn't ideal.
The data of a CAN message should always be 8 byte. The segmented data should be stored elsewhere.

Needs further testing before closing.


fix(tablecard): fix isExpanded console error and improve dashboard docs

Summary

summary_here

Change List (commits, features, bugs, etc)

doc(Dashboard): improve the dashboard story documentation on how to extend
doc(Card): improve the Card story documentation on how to build a custom card
fix(TableCard): stop the console error on isExpanded
fix(CardRenderer): check that setupCard exists before calling

Related Issues

Closes IBM/carbon-addons-iot-react#622

Acceptance Test (how to verify the PR)

Verify that all the Card and Dashboard stories work correctly

Error with Card story with custom content

:tada: This PR is included in version 1.98.2 :tada:
The release is available on:

npm package (@release-1.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


asap-docking | enable multipose scoring

Right now our scoring infrastructure only takes single poses for scoring, but it would be nice to add multipose scoring as well.

One of the challenges here is that the Score method has implemented methods i.e. from_score_and_docking_result which return a single score value. However, now that I've written the DockingResult object to include multiple poses in #1009, these Score methods will need to return a list of Score values, which will have to be expanded in all of the functions that use that function.

@hmacdope and I discussed this and we decided that the amount of time / number of lines of code it would take to do option 2 or 3 for a minimal, mostly aesthetic gain isn't worth it. Since most people (and downstream tools) aren't going to care that much about keeping results for multiple poses, and Ben and I can finagle the results just fine from option 1. The only trick is that we'll need to re-write the write_docking_results function so as not to overwrite the different pose results.


Modify threshold to 2MB

This issue is related to #3115 in order to low down a little bit the performance threshold use in Insomia UI to 2MB
Resolves #3115

posting agreement with https://github.com/Kong/insomnia/issues/3115#issuecomment-802726762
The solution seems to me not to be to change it to another value but rather to make it configurable.

Yes, I thought it was change it to another value. Now it's seems more reasonable to do it.
What are your thoughts on this @dimitropoulos? Can we include it as a preference option? Do we want to have a .dot file?

@Warkanlock definitely would want it to be a preference option (and not a dotfile).

Closed as stale.


writing a mysql query

In the family table, I want to paginate a list of the family names and their longest DNA sequence lengths (in descending order of length) where only families that have DNA sequence lengths greater than 1,000,000 are included. Give a query that will return the 9th page when there are 15 results per page. (hint: we need the family accession ID, family name, and the maximum length in the results)
What are the necessary columns? I can't figure it out.

Hi, thanks for reaching out to Rfam. I'd be happy to help you with this request. Could you let me know what you've tried and why you need this data? Maybe there is an easier way to get it. Thanks!

This is for the purpose of an assignment. Here is the question:-
Paginate a list of the family names and their longest DNA sequence lengths (in descending order of length) where only families that have DNA sequence lengths greater than 1,000,000 are included. Give a query that will return the 9th page when there are 15 results per page.
(hint: we need the family accession ID, family name, and the maximum length in the results)
I couldn't figure out the columns in the family table.

I suggest you look a bit at the family table. The first entry starts with:
RF00001	5S_rRNA	1302	5S ribosomal RNA

I suspect your teacher is interested in the first two columns. Good luck with your assignment!


Occasional BAD ACCESS when accessing Results through subscript

I am oftentimes having a BAD ACCESS when accessing an array of Results by subscript. Before accessing the index I make sure, that the count is greater than 0 but that seems to be always the case, that's why it I don't get an array out of bounds exception. It happened on different objects already and most recently on a query that I sorted by an attribute like so:
let users = realm.objects(ManagedUser.self).sorted("loggedInAt", ascending: false)
if users.count == 0 { return nil }
let user = users[0] // crashes right here

Edit: Apparently this also happens when I leave out the sorting, which means sorting has no effect on this behavior.
This is on an in-memory realm that's being created in my test suite and I'm currently on RealmSwift 0.92.2. Please let me know if you need further information or if I'm doing something wrong/ this is a known problem.
Thank you!

Hi @flipchen, could you try with the latest version of Realm (0.92.4)? We've fixed some issues with Results.count which may be causing this.
Also, please make sure that you're only linking your ManagedUser class to your application target, and not to your test target.
Finally, if this issue persists even after updating Realm and making sure you're only linking your model to your application target, I'd encourage you to write a failing unit test in ResultsTests.swift.

Hey @jpsim, thanks for the quick reply! I updated to 0.92.4 which didn't change anything.
I'm not sure how to build the project without linking all the classes, that are used in the tests to the test target. I read that there are ways to pass all the classes on to the test target, but that doesn't work in my project and doesn't seem to work in a newly created project, where I basically only have one class to test.
Can you enlighten me as to why this is necessary or how I can achieve not having to link application classes against my test target?

@flipchen it should be sufficient to just import AppName in your test files and declare your classes as public class.

I tried that and struggle with a couple of segmentation faults. The test target complains now, that it doesn't know about the frameworks I added through the bridging-header file. Does that mean I have to link the exact same libraries from the app target to the test target as well? There are one or two I added manually to the project, not through cocoapods.

You'll only need to link the libraries to the test target if you plan on using them directly in the test target.

I am seeing something similar to this. I was testing Realm with the iOS Swift example and doing
a large add every second and a deleteAll every 10 seconds and can crash it by doing the table view delete action:
2015-06-01 16:27:55.413 TableView[4917:3747447] *** Terminating app due to uncaught exception 'RLMException', reason: 'Index is out of bounds.'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010a740c65 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x000000010c2aebb7 objc_exception_throw + 45
	2   Realm                               0x000000010a286e10 -[RLMResults objectAtIndex:] + 366
	3   RealmSwift                          0x000000010a4d30d4 _TFC10RealmSwift7Resultsg9subscriptFSiQ_ + 68
	4   TableView                           0x000000010a177ce5 _TFC9TableView19TableViewController9tableViewfS0_FTCSo11UITableView18commitEditingStyleOSC27UITableViewCellEditingStyle17forRowAtIndexPathCSo11NSIndexPath_T_ + 357

The background add is the same as in TableView demo, except adding 10000 objects. It
gets run every second with dispatch_after on a private queue. The background delete is:
    let realm = Realm()
    realm.write {
      realm.deleteAll()
    }

I'll have a look if I can get a failing test case for this. I think in my case this
might require an interaction with table view (can queued UI actions get between the
update to the RLMArray and the reloadData notification?).

@joamaki the issue there is that UIKit doesn't necessary dispatch events synchronously, so the table view itself can get out of sync with the underlying datasource momentarily (which is almost certainly what's happening in the example you shared). It's not a realm-specific issue, but the safest thing to do in scenarios where you're relying on data from a UI-driven action is verify that that data is still valid when it's handed over to you -- in this case, that would mean verifying that the index selected is still in bounds before attempting to subscript the results.

@segiddins thanks, that's what I thought as well. Verifying the index works.

I'm not sure that is normal to check the index in method cellForRowAtIndexPath. I'm facing the same issue and only since I switched to Realm. Step to reproduce : use a WS search and type something that give 10 results, then add a lot of characters that you know will give you a 0 result and play with the tableview at the same time : it will crash


[Feature Request] Add download button on Season page

I have a few shows that I've added locally but are mkv's so they can't be played. The client shows an error message, but never gives me an opportunity to download the file. So it would be nice if in the episode selection page, there was a button for downloading!

All my files (a lot xD) are MKV and play fine, the problem must be in one of the codecs, either audio, video, or both, try re-coding them to x264+AAC, that codec combo works for most browsers.
Appart from that, yeah, it's a good idea to have the download button option available!

Ah you're right about that. It's DTS audio.
Nonetheless the option would be nice!

Cool feature, added it :)

wow youre fast!


Issue with streaming android 14 one ui 6

So whenever the start stream button is pressed confirmation dialogue appears more than one if you fail to press it then the stream stops on the viewers end but theres no way for you to tell if its stopped since according to android you are still streaming. The dialogue also reappears when the device is rotated and will disappear and stop the stream if you rotate back without confirming.

This is probably discords fault but it occurs on all versions ive tried regardless of how old. Hope someone here can at least tell me why. Maybe even fix it.


Support for Multiple Inboxes with Separate Credentials in MailPit

I'm regularly encountering issues with managing multiple email accounts in different contexts, different projects. Currently, MailPit only supports a single inbox, which makes it difficult to separate and manage multiple project and work as a team.
I would love to see a feature in MailPit that supports multiple inboxes with separate smtp credentials. This would allow users to add, manage, and switch between different email accounts seamlessly.
Proposed feature details:
Add new account: Allow users to add new email accounts to MailPit by providing the necessary credentials. These credentials should be stored and associated with the corresponding inbox.
Switch between inboxes: A simple and  UI element (such as a dropdown or side menu) should be present to allow users to switch between their various inboxes with a single click.
Separate settings for each inbox: Each inbox should have its own settings/preferences. This allows each account to be customized according to its purpose and usage.
Refer: Mailtrap email testing feature
Please let me know if there are any plans to implement such a feature. Thank you for your consideration.

Hi @deepakplay. Simply put, no, this is not planning (please see #86). Whilst such a feature would be awesome, it would require a complete rewrite of most of the logic in Mailpit in order to handle multiple accounts, each with their own mailbox, routing, and permissions, not to mention administration, password resets etc.
It sounds to me like you should just be using something like Mailtrap which already exists (it's just not locally hosted and costs money).


Improve Tooltip Compatibility for Touch Devices

Enhance the compatibility of tooltips for touch devices. Consider customizing or finding a touch-friendly tooltip library to improve the user experience.

Interested to do  this work

assigned  @Shanayshah44 , do star the repo.