White bar at bottom of my WEB-APP

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
After adding viewport-fit=cover to the meta tags the white bar moved from the status bar to the bottom.
Expected behavior:
No white bar at the bottom
Steps to reproduce:
Create an ionic app and use it as a webapp with safari.
Related code:
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover">
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">

Other information:
I only found fixes for nativ app using cordova or ionic, but I only use the framework as a webapp and I could not find a fix for that.

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub or https://stackblitz.com that demonstrates the issue you are having?
I tried copy/pasting your related code into the index.html into one of my sample test applications and saw no negative effect in Safari or Chrome.
Thanks for using Ionic!

Thanks for your answer.
I created a fresh Ionic App using ionic start myApp sidemenu. Then I added the code to the index.html and deployed it to a webserver.
After adding the webapp to the HomeScreen of my iPhone it clearly shows a white bar at the bottom of the page.
Additionally changed statusbarPadding from false to true and back, but the white bar is always there.

I would say this is directly related to this https://stackoverflow.com/questions/46232812/cordova-app-not-displaying-correctly-on-iphone-x-simulator/46232813#46232813. This problem will occur on all phones besides the iPhone X if you apply viewport-fit=cover". There is a pull request for this https://github.com/apache/cordova-plugin-statusbar/pull/85.

I'm not using an iPhone X.
Additionally I'm not using Cordova, I only use this as a WebApp (Safari) without anything native..
More Info: Sometimes I can 'scroll' the white bar down a bit and it goes up again slowly.. Not sure if this helps...

Hello all! Thank you for all the feedback! Several people here are currently looking into several iOS11 and iPhone X related issues. I will be sure to update this issue when we have more information.
Thank you for using Ionic

Thanks Apple!
/s
Guess I'll develop leaving the extra top padding until a fix is developed for Apple inexplicably changing their crap

Hello all! Could you make sure you have the items described in the following blog post applied to your applications and let me know if you are still having this issue?
http://blog.ionic.io/ios-11-checklist/

@kensodemann Thanks for the link. We were facing a similar issue, but the white bar was on top of the screen. After adding viewport-fit=cover the problem was fixed.

Still doesn't work for me.. I'm not using cordova and all these cordova patches don't work for WebApps.

I ended up working around the issue by adding the viewport-fit=cover as previously indicated AND by adjusting the bottom of my main div (which is #app) with the following CSS:
#app {
    position: absolute;
    top: 0;
    right: 0;
    left: 0;
    bottom: 0;
    bottom: calc(0px - constant(safe-area-inset-top));
}

This is article was helpful in discovering the solution:
https://medium.com/@pixelthing/welcome-to-notch-chat-a2206a7c3254
It's a hack to be sure and may not work for everyone.
I discovered my body tag was more or less spanning the full height of the window when the viewport tag was modified appropriately (I'm using height: 100% on my html and body tags). But in my app there is a main div (#app) which also takes up 100% height and has the actual content, does the scrolling, etc. It was this div that would not go to 100% no matter what I tried until I used the calc above.
I also found that the safe-area-inset-bottom constant evaluated to zero, as did the ones on the sides. I guess since the viewport tag fixes the safe area on top, that is the only one that resolves to an actual value. So the final CSS uses the safe-area-inset-top and extends my main div bottom by that amount.
YMMV.

Where did you place this div? I don't have that.. I'm using the standard ionic side menu theme..

I believe this is addressed in https://github.com/apache/cordova-plugin-statusbar/pull/87. That PR has been merged, but not released by Apache yet. Until then, you can remove the plugin and then install the plugin directly from the repo to get the fix in your project: cordova plugin add https://github.com/apache/cordova-plugin-statusbar.git.
Also remember to add viewport-fit=cover to your meta tag in index.html

@kensodemann I've tested the above PR, https://github.com/apache/cordova-plugin-statusbar/pull/87, on an Ionic 1 1.3.1 project on Iphone 7 running iOS 11 and all seems to be working as expected.

The short answer to the question from @modsfabio is that I'm not using standard Ionic and I'm not using Cordova either. Our company has a custom versions of both technologies. Thus I needed a solution that works on plain HTML in a plain WKWebView. As I said, YMMV.

I want to make sure I understand where we are at with this, so here is an attempt at a summary:

this is only an issue now for people running their apps as web-apps / PWAs, and thus are not using any cordova plugins
this is only an issue on iOS 11 devices
for someone running the app natively, the combination of things blogged about, including the plugin changes worked

Does that sound right? I want to make sure we are working on the correct issues here as we try to solve this.

Yes, exaclty!

I tried duplicating this using<EMAIL_ADDRESS>and the tabs starter on several different iOS 11 devices and was unable to reproduce this issue. Could you please post a sample application via GitHub that duplicates this issue? Also, some screenshots showing the issue may prove very helpful.

Hi there! I just installed the latest nightly<EMAIL_ADDRESS>in a test app, and all appears to work well for me.
ionic start myApp tabs

cd myApp

npm i<EMAIL_ADDRESS>
npm run build --prod

cd www && httpster

From there, I open the iPhoneX simulator, navigate to localhost:3333 and get this.

So I think we can call this fixed?

You have to save the App to your homescreen to make it working as a WebApp.
In installed<EMAIL_ADDRESS>and tested it using the sidemenu example.
Here are my results:
Everything at default:

(looks ok, but I want the app behind the statusbar)
I changed
<meta name="apple-mobile-web-app-status-bar-style" content="black">
to
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
It looks like this now (doesn't matter if config 'statusbarPadding' is true or false):

(the padding does not apply correctly, the sidemenu looks broken and on the bottom is a white bar. You can't see the bar here in github bcause it's white, just open the screenshot on a black background.

I can verify that using a test app I have. Both cases using nightly build with only diff being value of meta name="apple-mobile-web-app-status-bar-style"

I'm wondering if this is iOS bug 🤔
In a known, ionic app, or a single index.html, the black-translucent seems to be cutting the size of things....

here both html and body tags are set to fill the entire screen

Same issue here, I'm using ionic and I've just upgraded to ionic 3.7.1, cordova-ios 4.5.2, as well as updated cordova-plugin-status to latest, added viewport-fit=cover, there's always a white bottom bar in my app

@qiluo please provide more information.

Is this in a cordova app?
ionic info output?

hi, @mhartington
ionic info threw error on my side, maybe it's another bug
TypeError: Cannot read property 'toLowerCase' of undefined
    at ary.sort (/usr/local/lib/node_modules/ionic/dist/commands/info.js:24:66)
    at Array.sort (native)
    at splitInfo (/usr/local/lib/node_modules/ionic/dist/commands/info.js:24:18)
....

To your question

Yes it's a Cordova app
I'm on Ionic 3.7.1, cordova-ios 4.5.2, ionic-cli 3.13.0, OSX 10.12.6, Xcode 9, the testing device is iPhone 7P running iOS 11.0.3

k, @qiluo can you please provide a sample app to test against?

@mhartington, sorry, I've tried to provide a simple sample to reproduce the issue, not succeeded.
I also tried latest master branch of ionic, the issue still exists in my real app.
In my app, I got a tabbed layout, there's white bar on the bottom, and I got full screen modal page, there's white bar on the bottom. I've tried several potential solution, the white bar still on my every screen.
I'm thinking about if there's any dirty code not cleaned while I doing upgrade. I would keep looking into the issue, any update will let you know, thanks.

I have the same issue, any update?

@qiluo I have the same issue

@lovelyelfpop, I did a complete clean (removed node_module dir, rm cordova-ios and added again) and make sure ionic (3.8.0), ionic-cli (3.15.2), cordova-ios (4.5.3), cordova-cli (7.1.0) on latest version, the problem's just gone :)

I've done all this, and still have while space between my ion-content and the ion-header sections.

I think i have this problem worked out. I've blogged about it here:
https://medium.com/@damian_t/fixing-ios-11-web-apps-apple-mobile-web-app-capable-e5ed1a8c66e0
The problem is using viewport-fit=cover if the web app was added to the home screen (see screenshot in blog link). The solution is to conditionally remove the viewport-fit=cover property by adding this to your index.html:
if (window.navigator.standalone) {
            document.querySelector('meta[name=viewport]').setAttribute('content', 'width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no');

This isn't optimal on an iPhone X but it's a lot better than an unusable UI.

I encountered a similar issue building a web app with header bar and footer icon navigation bar. Maybe this can help you:
In the <head>:
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
<meta name="viewport" content="viewport-fit=cover, width=device-width, initial-scale=1.0">

CSS of html and body, this trick removed the white bar at the bottom:
html, body {
	max-width: 100%;
	overflow-x: hidden;

	min-height: 100%;
	min-height: calc(100% + constant(safe-area-inset-top));
	min-height: calc(100% + env(safe-area-inset-top));
}

Note: In my option it seems like a bug not having the full 100% height when using viewport-fit=cover. So, maybe it will be different in future iOS safari versions
CSS of top header:
.MobileHeader {
	padding-top: 0;
	padding-top: constant(safe-area-inset-top);
	padding-top: env(safe-area-inset-top);

	// ...
}

CSS of bottom navbar (fixed at bottom using Bulma css framework navbar is-fixed-bottom classes):
.MobileNavigation {
	padding-bottom: 0;
	padding-bottom: constant(safe-area-inset-bottom);
	padding-bottom: env(safe-area-inset-bottom);

	// ...
}

Tested on iPhone X and iPhone 6s (iOS 11.4.1)

Be sure to test your solutions against early iOS versions (<11.2), there seems to be some inconsistencies across these versions.


[WIP] Add guides as more thorough documentation on Engines

Due to the number of questions/requests for documentation that have been received through various channels, I figured it would be good to have some more thorough documentation on Engines than what is available in the README.
I realize that we want to be careful about codifying the experimental parts of this addon, but I think a large portion of the features are ready to begin adoption and lots of developers would like to use them so it makes sense to have some more thorough reading available.
My goals for this guide are that it will:

Evolve with the addon,
Provide insight into not just "how to do something" but "why things are done the way they are",
Give a central reference point for information that is currently scattered throughout issues, rfcs, slack convos, etc., and
Allow easier adoption of Engines for users new to some advanced Ember concepts

In it's current structure, the guide reads like a tutorial and explains concepts and ideas along the way. I think this format makes the most sense to encourage developers to get a holistic view of what Engines involve rather than picking up bits and pieces as they need them.
Note: this is still a work-in-progress, but I want to get some feedback about the format and content ahead of time.

@trentmwillis Thanks for getting this started! The content here is really solid 💯
At this point, my only hesitation is where to put all this good content. My inclination is to set up a jekyll site for this repo.

My inclination is to set up a jekyll site for this repo.

We could do that. I had wondered if maybe we should do something like FastBoot, but since Engines are still very much beta (alpha?) software, I was thinking maybe just an in-repo guide similar to Glimmer would suffice.
I'll leave the decision up to you. I plan to finish fleshing out the content here this weekend.

Merged via ba5ea264c1ec4c69a714d3e038cb0cd6217efec9
@trentmwillis Sorry for letting this sit, and thanks again for the great work :shipit:
I'll talk over goals for a docs site with the rest of the core team.


Change PER_THREAD_DEFAULT_STREAM to CUDF_USE_PER_THREAD_DEFAULT_STREAM

Closes #256.
CUDF is changing PER_THREAD_DEFAULT_STREAM to CUDF_USE_PER_THREAD_DEFAULT_STREAM.
This changes spark-rapids-jni to follow suit.
We need to wait for CUDF PR: https://github.com/rapidsai/cudf/pull/10877 to go in before merging this.

build


Understanding path operations on LocalVfs

I'm trying to replace a custom MPP path implementation by korio and my test suite uncovered quite some details I can't really understand. I hope it's appropriate to ask these questions here to gain understanding for the workings of korio. For the start, I have two basic questions:

The LocalVfs["/"].pathInfo.isAbsolute() returns false for me. Running Paths.get("/").isAbsolute() returns true. Is there a documentation about the differences in determining absolute paths?
Paths.get("/tmp/./test/..").getParent() returns /tmp/./test, i.e. it does only consider path components for parenting. But with LocalVfs["/tmp/./test/.."].parent I already get the normalized result, i.e. LocalVfs[""]. Is there a way to get the path parent without normalization apart from trying things like vfsFile.pathInfo.parts().dropLast(1).joinToString("/") (which didn't work for me either)? For me, auto-normalization is quite unexpected, especially for relative paths.

Vfs and VfsFile work differently than Paths. In the end they work like nodes in a filesystem that it is not required to be an actual local filesystem.
Alternatively you can use PathInfo instead, manipulate those inline instances, then use rootLocalVfs with the PathInfo when required. VfsFile is usually not that strict and might perform normalizations and other unexpected stuff if for example you are dealing with mountable filesystems and suff like t hat

Many thanks for the explanation. It's clearer now.


Issue with utf8 files

Hi,
I have issues that are related to UTF8 typescript files.
The file in UTF8:
/**
 * @file filename
 */

will be validated as // tslint : (jsdoc-format) client/tslinterror.ts[2, 1]: asterisks in jsdoc must be aligned.
/**
  * @file filename
  */

is validated without errors (incorrect)
Any suggestions for a correct fix?  see issue (#299) .
Please find attached debug info.  startPosition is 1 incase of UTF8.

@mwe is this still an issue on the latest tslint?


Development: Add hand-in early with continue and reload page e2e exam tests

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Description

With this PR we add new e2e exam participation tests, the test the following cases:

Hand in early, but then decide to continue instead and change the submission text
Reload the exam page in the middle of the exam and check if the content of the text exercise is still correct
Reload the exam result page and check if all the content is still the same

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Codecov Report

Merging #6293 (8c32912) into develop (0e34616) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6293   +/-   ##
==========================================
  Coverage      80.30%   80.30%
  Complexity     12902    12902
==========================================
  Files           2289     2289
  Lines          88746    88746
  Branches       13111    13111
==========================================
  Hits           71270    71270
  Misses          9726     9726
  Partials        7750     7750

Flag
Coverage Δ

client
76.49% <ø> (ø)

server
84.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e34616...8c32912. Read the comment docs.


ext: nffs: fix SLIST_REMOVE macro

The SLIST_REMOVE macro has a risk
When there is no elm in the queus pointed by head,
it will get uncontrollable results.
When this happens, you should do nothing and quit the macro.
Signed-off-by: Findlay Feng<EMAIL_ADDRESS>

Codecov Report

Merging #9388 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9388   +/-   ##
=======================================
  Coverage   52.58%   52.58%
=======================================
  Files         201      201
  Lines       25351    25351
  Branches     5304     5304
=======================================
  Hits        13331    13331
  Misses       9921     9921
  Partials     2099     2099

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2e598...04dd05d. Read the comment docs.

@findlayfeng please send the PR against this repo: https://github.com/apache/mynewt-nffs


[Bug] Client Using >4Gb Memory During Migration

When migrating to FoundryVTT v10 and up, from previous versions, the migration method causes crashing due to not limiting the maximum amount of memory that the JavaScript can use during migration. On Chrome this will lead to a error code: out of memory to come up after migration a larger campaign (this might be due to larger high resolution assets being used I do not know yet).
Steps to Replicate:

Create a world with a lot of assets (in my case it was about 4 Gb of data).
Open up browser as GM.
Watch Memory rise.
Profit???

The highest I saw was 20 Gb, however it at one point restarted and it seems that it has started the migration again after waiting fro about an hour. This may be fixed in fe38b4f8c7822a42833fd7d27de6b219fea4443d, however I have not tested this nor do I know how to yet.

I can clearly see that the migration script is running though when I look at the dev console:

The highest I saw was 20 Gb, however it at one point restarted and it seems that it has started the migration again after waiting fro about an hour. This may be fixed in fe38b4f, however I have not tested this nor do I know how to yet.

Also here is a picture of 20Gb just for the laughs:

At least I thought it was funny.

It finally finished, and everything seems to work. However, for the average user who has only about 16-8Gb of ram, this may be an issue.

Lastly I wanted to say, thank you all for creating this project my group and I definitely had a lot of fun playing using this module!

I was poking around a bit at the docs and wanted to ask if it would be possible to use this updateAll method on the game.actor class from line 21 in migration.js.
If so it seems that scenes, items, messages, and macros have this same method of updateAll due to them being inherited from WorldCollection. So this may be one way to handle this a bit cleaner.
I am by no means a javascript developer. So, I apologize if this is dumb.

While there are definitely better ways to run the migration, you really shouldn't be importing entire compendium into your sidebar

That is super fair and makes sense. I will tell the DM to stop doing this asap.


Update manifests/t/Tencent/QQ/<IP_ADDRESS>924/Tencent.QQ.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

Needs Attention

[Policy] reset feedback

[Policy] Needs-Attention

@wingetbot run


build directory is not deleted using east clean when it is not named build

Describe the bug
When using the --build-dir flag, the build directory will not be deleted on a subsequent call to east clean unless it is called exactly build which  defeats the purpose of the --build-dir flag.
Firmware/Software Version
0.6.2
To Reproduce
Steps to reproduce the behavior. Example using hello world sample:
cd zephyr/samples/hello_world
# board does not matterr
east build -b nrf52840dk_nrf52840 --build-dir build_52dk
# observe a folder named build_52dk was created
ls

east clean
# observe the folder named build_52dk is still there
ls

To implement this I would have to save some kind of data in the ~/.local/share/east folder to keep track of where build folders of previous builds are stored.
So I would need a mapping between:

folder path where build command was called and
path to the build folder that was created at build call.

This is a one to many relationship, as it is valid to do:
east build
east build --build-dir my_build_dir

(Should calling east clean on this same path clear both (all) build folders or just the last one?)

Also, if we were thinking that having a east clean --all (clear all build folders in the project repository) would be useful.
In that case there should be some relationship between project and above mentioned mappings.
Otherwise you would write east clean --all and it would wipe all build folders that you ever created with east.
@TjazVracko what do you think about above, there are probably some mistakes in the logic.

I think you should add the metadata to each project (like west does in .west).
east clean should remove all build folders in the current directory.
east clean --all should clean all build folders in this project - I think you can limit yourself to only the project folder. Keeping track of all samples in nrf/zephyr/... is overkill.


PDFObjectNotFound

Sorry, I can’t understand what this error is and why it comes out? When I sign it a second time, some files are signed normally, others are not.
def sign(self):         self.sign_step = True         p12 = load_pkcs12(open(self.cert_path, "rb").read(),  bytes(self.password, encoding="utf-8"))         formed_file = self.pdf_file         self.draw()         images = convert_from_path(os.path.join(settings.BASE_DIR, "cer", "sign_pdfs", str(self.user.id) + ".pdf"), 600)         images[0].save(os.path.join(settings.BASE_DIR, "cer", "sign_pngs", str(self.user.id) + ".png"), "PNG")         pdf_bytes = open(formed_file.name, "rb").read()         dct = self.dct
    signature = pdf.cms.sign(pdf_bytes, dct,
                             p12.get_privatekey().to_cryptography_key(),
                             p12.get_certificate().to_cryptography(),
                             [],
                             'sha256'
                             )
    with io.BytesIO() as f:
        f.write(pdf_bytes)
        f.write(signature)
        signed_pdf = f.getvalue()
    copy = open(str(formed_file.name), 'wb')
    copy.write(signed_pdf)
    copy.close()
    self.instance.save_signed(self.step)
    return formed_file

Traceback (most recent call last):
File "D:\test_projects\mrs25\venv\lib\site-packages\django\core\handlers\exception.py", line 34, in inner
response = get_response(request)
File "D:\test_projects\mrs25\venv\lib\site-packages\django\core\handlers\base.py", line 126, in _get_response
response = self.process_exception_by_middleware(e, request)
File "D:\test_projects\mrs25\venv\lib\site-packages\django\core\handlers\base.py", line 124, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "D:\test_projects\mrs25\venv\lib\site-packages\django\views\decorators\csrf.py", line 54, in wrapped_view
return view_func(*args, **kwargs)
File "D:\test_projects\mrs25\venv\lib\site-packages\django\views\generic\base.py", line 68, in view
return self.dispatch(request, *args, **kwargs)
File "D:\test_projects\mrs25\venv\lib\site-packages\rest_framework\views.py", line 495, in dispatch
response = self.handle_exception(exc)
File "D:\test_projects\mrs25\venv\lib\site-packages\rest_framework\views.py", line 455, in handle_exception
self.raise_uncaught_exception(exc)
File "D:\test_projects\mrs25\venv\lib\site-packages\rest_framework\views.py", line 492, in dispatch
response = handler(request, *args, **kwargs)
File "D:\test_projects\mrs25\scores\views\decanats.py", line 66, in post
f = self.get_sign_method()
File "D:\test_projects\mrs25\scores\views\decanats.py", line 59, in get_sign_method
return pdfworker.sign()
File "D:\test_projects\mrs25\scores\helpers.py", line 377, in sign
'sha256'
File "D:\test_projects\mrs25\venv\lib\site-packages\endesive\pdf\cms.py", line 377, in sign
return cls.sign(datau, udct, key, cert, othercerts, algomd, hsm)
File "D:\test_projects\mrs25\venv\lib\site-packages\endesive\pdf\cms.py", line 350, in sign
pdfdata2 = self.makepdf(datau, dct, zeros)
File "D:\test_projects\mrs25\venv\lib\site-packages\endesive\pdf\cms.py", line 296, in makepdf
infodata = self.getdata(pdfdata1, info, prev, document)
File "D:\test_projects\mrs25\venv\lib\site-packages\endesive\pdf\cms.py", line 111, in getdata
obj = document.getobj(objid)
File "D:\test_projects\mrs25\venv\lib\site-packages\pdfminer\pdfdocument.py", line 706, in getobj
raise PDFObjectNotFound(objid)
pdfminer.pdftypes.PDFObjectNotFound: 17

pdf! = pdf, different files have different structure and some of them are not supported by version smaller than 1.5.0, eg. linearized or with packed references
New version is now able to handle much more pdf files than the previous ones

Yes it worked, but I get the following message in Adobe Acrobat:
Error during signature verification.
Acrobat error.
Bad parameter.
my code hasn't changed much
`@property
def dct(self) -> dict:
if self.step == 2:
return {
'sigflags': 3,
'sigpage': self.page_number,
'contact': bytes(self.contact),
'location': self.location,
'signingdate': self.pdf_time(),
'sigpage': self.page_number,
'sigbutton': True,
'signature_img': os.path.join(settings.BASE_DIR, 'cer', 'sign_pngs', str(self.user.id) + '.png'),
'signaturebox': self.coords,
'reason': self.reason
}
return {
'sigflags': 3,
'sigpage': self.page_number,
'contact': self.contact,
'location': self.location,
'signingdate': self.pdf_time(),
'reason': self.reason
}
@property
def pdf_file(self) -> io.BufferedWriter:
    if not self.pdf:
        if self.step == 1:
            self.pdf = self.formed()
        else:
            self.pdf = self.download()
    return self.pdf

def sign(self):
    self.sign_step = True

    # try:
    # p12 = load_pkcs12(open(self.cert_path, 'rb').read(), bytes(self.password, encoding='utf-8'))
    p12pk, p12pc, p12oc = load_key_and_certificates(open(self.cert_path, 'rb').read(),
                                                    bytes(self.password, 'utf-8'), backends.default_backend())
    # except:
    #     raise ValueError('Пароль не верный')
    formed_file = self.pdf_file
    self.draw()
    images = convert_from_path(os.path.join(settings.BASE_DIR, 'cer', 'sign_pdfs', str(self.user.id) + '.pdf'), 600)
    images[0].save(os.path.join(settings.BASE_DIR, 'cer', 'sign_pngs', str(self.user.id) + '.png'), 'PNG')
    pdf_bytes = open(formed_file.name, 'rb+').read()
    dct = self.dct

    signature = pdf.cms.sign(pdf_bytes, dct,
                             p12pk, p12pc, p12oc,
                             'sha256'
                             )
    with io.BytesIO() as f:
        f.write(pdf_bytes)
        f.write(signature)
        signed_pdf = f.getvalue()
    copy = open(str(formed_file.name), 'wb')
    copy.write(signed_pdf)
    copy.close()
    self.instance.save_signed(self.step)
    return formed_file`

strings are everywhere, not bytes:
'contact': bytes(self.contact)
If possible, show me your pdf after signing. Nothing helps me with the answer from the attached program.

I realized what the problem is. I tried to sign the file not today. I understand that it is impossible to indicate today's date?

632_Лобачев Андрей Александрович_Монтаж, эксплуатация и ремонт технологического обор_экзамен (5).pdf
just in case I attach the file

Change the date format in the signingdate field to:
date.strftime ('D:% Y% m% d% H% M% S + 00 \ '00 ' ')

Signature found
Signature covers whole document
Name<EMAIL_ADDRESS>.....
Certificate cannot be verified without signing time
Certificate valid at signing time: Fri Apr 24 19:45:54 CEST 2020
Signature verified
Certificate is not self-signed
Certificate cannot be verified without signing time
pdf signed by my certificate
Certificate valid at signing time
Certificate valid at signing time: Tue Apr 21 02:08:40 CEST 2020
Signature verified
Certificate is not self-signed
kwi 24, 2020 8:41:44 PM org.apache.pdfbox.examples.signature.cert.CertificateVerifier verifyCertificate
INFO: Certification chain verified successfully
kwi 24, 2020 8:41:44 PM org.apache.pdfbox.examples.signature.cert.CertificateVerifier checkRevocations

I realized what the problem is.
  I tried to sign the file not today. I understand that I should indicate only today's date?

The signing time must be from the UTC zone, not local time. Otherwise, the document may be signed in the future.

Thanks


Added code to check if a given graph is bipartite or not in python.

Hey @rudrakshi99 @tarun26091999
I have added the code for the bipartite graph in the python folder for the issue-95.
Please check this pull request.

#95


Kill Audio doesn't work

The Kill Audio button in the lower left hand of the screen doesn't seem to work.
Expected behavior was: Any audio file being played back would stop when pressing Kill Audio.

This also works for me locally. Any error in the Chrome Dev Tools console?
Audio is played via the HTML5 audio API which was available to me by default by using Electron. http://electron.atom.io/

I expect once we fix #5 this will follow suit.

Indeed it did.


Fix error in documentation for Docker labels

Hello,
Here is a fix in the documentation for an error I had spotted when working on a Docker Swarm project lastly.
Cheers

@vdemeester easy one I guess.


double-beep: Blacklist keto\Wbuzz(?:\Wreviews)?

double-beep requests the blacklist of the keyword keto\W*buzz(?:\W*reviews)?. See the MS search here and the Stack Exchange search here.

keto\W*buzz(?:\W*reviews)? has been seen in 23 true positives, 0 false positives, and 0 NAAs.

The reviews should perhaps have the final s optional but I'll fix that up separately.
Sent with GitHawk

!!/approve
Sent with GitHawk

!!/approve
Sorry for the noise, looks like Github won't let me merge this on mobile but trying anyway.

Approved by Olivia in Charcoal HQ


Stopped working since February

Hey!
First of all thanks for this fantastic app I have been using it for almost 2 years and it's great :)
Just letting you know if I'm the only one with this issue, I have been using the tool as a cronjob from Kubernetes everything has worked as expected since February started to fail, and it looks like something related to the way we auth on Datadog, I only have those traces failing when authenticate.
datadog_backup backup --debug
I, [2023-04-04T11:15:44.659689 #68]  INFO -- : Starting diffs on 10 threads
/usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/core.rb:119:in `with_200': Request failed with error ["403", {"status"=>"error", "code"=>403, "errors"=>["Forbidden"], "statuspage"=>"http://status.datadoghq.eu", "twitter"=>"http://twitter.com/datadogops"<EMAIL_ADDRESS>(RuntimeError)
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/core.rb:57:in `get_all'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/dashboards.rb:6:in `all_boards'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/dashboards.rb:25:in `backup'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/cli.rb:28:in `each'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/cli.rb:28:in `backup'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/lib/datadog_backup/cli.rb:139:in `run!'
	from /usr/local/bundle/gems/datadog_backup-1.1.3/bin/datadog_backup:94:in `<top (required)>'
	from /usr/local/bundle/bin/datadog_backup:25:in `load'
	from /usr/local/bundle/bin/datadog_backup:25:in `<main>'

I was using the 1.1.3 version so I decided to update to the stable version(3.2.1) and occurs the same:
datadog_backup backup --debug
I, [2023-04-04T10:57:41.261480 #14]  INFO -- : Starting diffs on 10 threads
D, [2023-04-04T10:57:41.261839 #14] DEBUG -- request: GET https://api.datadoghq.eu/api/v1/dashboard
D, [2023-04-04T10:57:41.261868 #14] DEBUG -- request: DD-API-KEY:[REDACTED]
Traceback (most recent call last):
	19: from /usr/local/bundle/bin/datadog_backup:23:in `<main>'
	18: from /usr/local/bundle/bin/datadog_backup:23:in `load'
	17: from /usr/local/bundle/gems/datadog_backup-3.2.1/bin/datadog_backup:92:in `<top (required)>'
	16: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/cli.rb:89:in `run!'
	15: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/cli.rb:28:in `backup'
	14: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/cli.rb:28:in `each'
	13: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/dashboards.rb:12:in `backup'
	12: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/dashboards.rb:7:in `all'
	11: from /usr/local/bundle/gems/datadog_backup-3.2.1/lib/datadog_backup/resources.rb:60:in `get_all'
	10: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/connection.rb:200:in `get'
	 9: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/connection.rb:444:in `run_request'
	 8: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/rack_builder.rb:153:in `build_response'
	 7: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/middleware.rb:17:in `call'
	 6: from /usr/local/bundle/gems/faraday-retry-2.1.0/lib/faraday/retry/middleware.rb:149:in `call'
	 5: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/response/logger.rb:23:in `call'
	 4: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/middleware.rb:17:in `call'
	 3: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/middleware.rb:17:in `call'
	 2: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/response.rb:42:in `on_complete'
	 1: from /usr/local/bundle/gems/faraday-2.7.4/lib/faraday/middleware.rb:18:in `block in call'
/usr/local/bundle/gems/faraday-2.7.4/lib/faraday/response/raise_error.rb:20:in `on_complete': the server responded with status 403 (Faraday::ForbiddenError)

I did not modify any credentials or rotate them so that's why I'm asking if you know something related to this problem 😄
Meanwhile, I have opened a ticket to datadog to see if they made some changes.

After some manual fixes and some app keys deprecated I have found that the issue was with the app key that was deleted manually and with a new app key and API key everything worked again as expected, sorry for the noise!
Closing the issue since everything works as expected 😄


Provide Agent user to Agent MSI

What does this PR do?
Provides the Agent user to the Agent MSI. Agent User will typically come from the registry, where the Installer stores it.
Motivation
custom Agent user/domain controller support
https://datadoghq.atlassian.net/browse/WINA-822
Describe how to test/QA your changes
N/A, E2E test TestAgentInstallWithAgentUser installs the Installer with a custom user and checks that the Installer installs the Agent with the same user
Possible Drawbacks / Trade-offs
Additional Notes

no changelog, unreleased feature

/merge


feat: add flashpoint dataset

This PR adds the flashpoint dataset from Sun et al., 2020. This closes #20.
Regarding the size of the dataset: the paper states they collected values for 10575 unique compounds, but they do not include the DIPPR data in their released dataset as it is proprietary. Their dataset includes 14696 datapoints, but these include datapoints with the same SMILES string. After SMILES deduplication, we end up with 9878 datapoints.

Thank you, looks very good! 😃


Implement index conditional match in output elasticsearch

Like described here:
https://www.elastic.co/guide/en/beats/filebeat/current/elasticsearch-output.html#_indices
Filebeat support the ability to split in different index depending, as a sample, to a field match (field 'message' in the example).
In your module this condition is not supported.
From templates/filebeat5.yml.erb (@100-102):
  <%- if @filebeat_config['output']['elasticsearch']['index'] != nil -%>
  index: "<%= @filebeat_config['output']['elasticsearch']['index'] %>"
  <%- end -%>

the support for an array 'indices' containing for each index a condition could be implemented.

Fixed in #97
Thanks again @cristianocasella


WIP: Add a test case and fix for transcribing markers over a single audio AAF file

Codecov Report

Merging #1259 (f1a2d7a) into main (ebd15cd) will increase coverage by 0.05%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   86.10%   86.15%   +0.05%
==========================================
  Files         196      196
  Lines       19671    19682      +11
  Branches     2308     2308
==========================================
+ Hits        16937    16958      +21
+ Misses       2173     2162      -11
- Partials      561      562       +1

Flag
Coverage Δ

py-unittests
86.15% <86.66%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...elineio_contrib/adapters/tests/test_aaf_adapter.py
97.81% <75.00%> (-0.27%)
:arrow_down:

...neio_contrib/adapters/advanced_authoring_format.py
81.01% <100.00%> (+0.81%)
:arrow_up:

src/opentimelineio/errorStatus.cpp
44.44% <0.00%> (+3.70%)
:arrow_up:

...pentimelineio-bindings/otio_errorStatusHandler.cpp
70.37% <0.00%> (+5.55%)
:arrow_up:

src/opentimelineio/clip.cpp
80.55% <0.00%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd15cd...f1a2d7a. Read the comment docs.


fix(HLS): Fix support for mixed AES-128/NONE decryption

fixes https://github.com/shaka-project/shaka-player/issues/4846

@joeyparrish can you review it? Thanks!


What
Fixes the cloudfoundry destroy pipeline so that manual removals are not necessary.

Set the force_destroy option in dev environments to the cloud foundry s3 buckets.

How to review
A successful log file of a full destroy can be seen here and here.
Ensure you are happy with the protection of non-dev buckets.

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Can we add an explicit bucket_force_destroy = false for prod envs, please? Just in case we default to true in the future.

Done.


[Feature]: Use torch tensor to save sparse index

Goals
To streamline the index managemen by unifying the index types (to torch csr tensor) and the save & load functions.
Trade-off
The current .npz format from scipy is advantageous for its compression with minimal disk usage. Transition from  scipy .npz format to the pytorch .pt comes with larger disk occupation and faster loading speed.
We will provide an option to choose between the .npz and .pt formats.

We have decided to continue using the scipy .npz format for storing sparse indices. While we utilize torch sparse tensors for inner product operations, storing sparse indices in this format presents two significant issues:

It requires approximately 4x storage space than the .npz format, likely due to the use of int64 for indices and float32 for values.
It lacks a built-in row slicing function, making custom implementations too slow for practical use.


Stale data in COVID-19 US Tracking Report template app

The COVID-19 US Tracking Report template app is set to retrieve its data from these two CSV files:

covid_confirmed_usafacts.csv (usafactsstatic.blob.core.windows.net)
covid_deaths_usafacts.csv (usafactsstatic.blob.core.windows.net)

These CSV files were originally maintained and published by USAFacts.org, but the versions hosted at the links above are copies of those original files, and have NOT been updated since August 16th, 2021, so this template app is now populated with extremely stale data.
However, the USAFacts.org website still keeps its original copies of these files updated with the latest COVID-19 data, so the only change necessary to make this template app work again is to replace the CSV file links in Power Query with these ones:

covid_confirmed_usafacts.csv (static.usafacts.org)
covid_deaths_usafacts.csv (static.usafacts.org)

This zip archive contains two files: Cases.m and Deaths.m

Cases & Deaths.zip

Replace the Cases M query with the code in the Cases.m file, and replace the Deaths M query with the code in the Deaths.m file, and the COVID-19 US Tracking Report template app will have the latest data again. I have made the necessary changes to my local copy of the COVID-19 US Tracking Report, so if you'd rather just use my copy of the PBIX or PBIT file to update the template app, just let me know.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1eccadf-bff1-8010-6eab-f8e357aa35fc
Version Independent ID: f789d447-2bc7-5cf1-5633-e73b45957f70
Content: Connect to the COVID-19 US tracking report - Power BI
Content Source: powerbi-docs/connect-data/service-connect-to-covid-19-tracking.md
Service: powerbi
Sub-service: powerbi-template-apps
GitHub Login: @paulinbar
Microsoft Alias: painbar

Hi @JamesDBartlett3, well, coming up on a year ago I forwarded your suggestion and offer to the app developer, but never heard back, so I am going to close this issue now. Sorry that they didn't take you up on it. Thanks for taking the time in any event.

@paulinbar How can I get in touch with the app developer?


Cannot get list of CONFIRMED transactions via RPC (getTransactions)

Background
Closed channel between two nodes. Close is complete. Logs suggest the transaction was inserted correctly. Block explorer shows the transaction as it reaches its required confirmations (3)
GetTransaction RPC response shows 0 confirmation, and no blockhash.
#1422 suggests this issue is similar to that issue, however in that case it was unconfirmed transaction.
The LNDs use neutrino and the transaction in question has reached the required confirmations.
Your environment

version of lnd --- 0.5.0 beta with neutrino on testnet
which operating system (uname -a on *Nix) --- iOS
version of btcd, bitcoind, or other backend  -- btcd

Steps to reproduce
Close channel. Observe responses received from GetTransactions
It will show zero confirmations even when the transaction is entirely confirmed
Expected behaviour
GetTransaction to reflect confirmations and blockhash accurately
Actual behaviour
Neither confirmation nor block hash is available
LOG
2019-01-04 18:01:01.009 [INF] LNWL: Inserting unconfirmed transaction e24894006a22b5cf89182fcf4e30d9939ae99f1d787ade9dadf2b89ccd2b9907
2019-01-04 18:01:01.540 [INF] HSWC: Removing channel link with ChannelID(33eed972dd732056122a1391b3a94ec1a121f796621bda3cdae9d7e961d8e780)
2019-01-04 18:01:01.541 [INF] PEER: Waiting for confirmation of cooperative close of ChannelPoint(80e7d861e9d7e9da3cda1b6296f721a1c14ea9b391132a12562073dd72d9ee33:0) with txid: e24894006a22b5cf89182fcf4e30d9939ae99f1d787ade9dadf2b89ccd2b9907
2019-01-04 18:01:01.543 [INF] NTFN: New confirmations subscription: txid=e24894006a22b5cf89182fcf4e30d9939ae99f1d787ade9dadf2b89ccd2b9907, numconfs=1, height_hint=1450920

Update:
Remote node shows accurate current status of the tx in question - including the correct number of confirmations, block hash etc.
Originating node (i.e. node that initiated the channel open) however does not show any of those details - shows 0 for number of confirmations, and block hash is blank

Does this persist if you update to 0.5.1? A number of bugs related to transaction display with neutrino were fixed since then.

Guess its about time for me to update ..i have been holding off in the event update caused other issues. Brb with an update.


GraphNode does not organize children properly when child node is hidden

Godot version:
3.1.1 stable
OS/device including version:
arch linux
Issue description:
The GraphNode type of node doesn't become smaller after a child of its is hidden
Steps to reproduce:

Create a graphnode
Add as many label nodes that say "test" as needed to make the graph node expand due to nodes under it needing more space than exists
Hide any one of the label nodes

Minimal reproduction project:

Not sure if this is a bug. When you enable slot for that child, it stays visible regardless of the child visibility. Either we should hide slots or this behavior is correct.


fixed redis issue

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/jaredwray/keyv/blob/main/CODE_OF_CONDUCT.md
[ ] Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix for #385

What is the current behavior? (You can also link to an open issue here)
NA

What is the new behavior (if this is a feature change)?
NA

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
NO

Other information:

@jaredwray for test we need to run redis in cluster mode. I tried running redis in cluster mode but it is not working. The mode runs but I am not able to connect from outside. When I researched it says that we need static ip...


Remove mcrypt require line in composer.json

It's already in the suggest section, and it's not strictly required (for instance, if you're not doing assertion encryption).

https://github.com/onelogin/php-saml/blob/master/composer.json#L24


docs: remove an extra set of brackets from the select ... from

Looks like the right syntax is (select foo from (x -> y) ( -> y))
from the example use in js_of_ocaml/compiler

Thanks


Configurable masking token, perf improvements, refactoring.

This change:

Does some additional refactoring of the secret masking code (in support of a future move to consume the updated masker from a separate library). Mostly this changed entailed having LoggedSecretMasker derive from SecretMasker rather than wrapping an instance of this class.
Added a configurable preferred redaction token to the ReplacementPosition class (now simple renamed to Replacement).  For secret values, we retain the existing default redaction string ***. For regexes that have no explicit rule information (an id and friendly name, together which comprise a moniker), we use the string +++. This change will allow users to easily search for logs looking for evidence of automatically redacted secrets. These secrets either should have been protected as secured variables OR there is an upstream leak of the secret in a script/dependency, etc.
For patterns that explicitly declare a rule moniker, the redaction token consists of the opaque id, friendly name and hash of the redacted secret. This data will be persisted to telemetry to allow secure correlation of redacted secrets with evidence of exposure in other locations.
I have added some preliminary telemetry in a naive way. Looking for feedback/refinements of this.
Renamed some items to communicate that they originate with the 1ES scan project, not CredScan.
Expanded unit testing. The updated secret masker namespace now has >90% code coverage.

public ISecretMasker Clone()

I can't find the use of secret masker clones in the code, does this utilization exist? One difference now between the legacy masker and the current is that the legacy masker doesn't retain elapsed masking time on clone. Is that an issue?

Refers to: src/Agent.Sdk/SecretMasking/LegacyLoggedSecretMasker.cs:134 in a95cc17. [](commit_id = a95cc17bd0854a2b5eba17e48b6a180932a5c557, deletion_comment = False)

@merlynomsft


My FGA acting weird ever since the new update

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1675
Describe the bug
I choose Skadi as prefered servant but sometimes it avoid choosing skadi and somtimes went to "Confirm Support Setup"
Video
https://user-images.githubusercontent.com/106092048/169840862-1fdfbdca-b09f-4bfc-a2b5-edd5b099567c.mp4
Device model
Samsung Galaxy A50
Android version
11
Screen size
1080×2340
RAM
6GB

Might have to do with the append skill update. Have to wait for the app to get updated.

try not selecting the skill levels, it worked for me, at least untill the new update it should do the trick

Fixed in latest version


Failed to install az cli with apt-get

As of last night, the az cli is failing to install for me through apt-get. I'm follow the instructions here:
echo "deb [arch=amd64] https://apt-mo.trafficmanager.net/repos/azure-cli/ wheezy main" | sudo tee /etc/apt/sources.list.d/azure-cli.list
sudo apt-key adv --keyserver apt-mo.trafficmanager.net --recv-keys 417A0893
sudo apt-get install apt-transport-https
sudo apt-get update && sudo apt-get install azure-cli

It's failing at the last step:
<removing most of the log>
Hit http://security.ubuntu.com trusty-security/main amd64 Packages
Hit http://security.ubuntu.com trusty-security/universe amd64 Packages
Err https://apt-mo.trafficmanager.net wheezy/main amd64 Packages
  gnutls_handshake() failed: Handshake failed
Ign https://apt-mo.trafficmanager.net wheezy/main Translation-en_US
Hit http://security.ubuntu.com trusty-security/main Translation-en
Ign https://apt-mo.trafficmanager.net wheezy/main Translation-en
Hit http://security.ubuntu.com trusty-security/universe Translation-en
W: Failed to fetch https://apt-mo.trafficmanager.net/repos/azure-cli/dists/wheezy/main/binary-amd64/Packages  gnutls_handshake() failed: Handshake failed

E: Some index files failed to download. They have been ignored, or old ones used instead.

I reproduced this on a clean Ubuntu 14.04 VM
NOTE: It succeeds if I do curl -L https://aka.ms/InstallAzureCli | bash, but we using the cli in some automation scenarios and I believe that script requires interaction, correct? Can I pass it parameters so that it doesn't prompt me?

@EricJizbaMSFT I'm taking a look.
As a work around, you can download the .deb file straight from blob storage.
https://azurecliprod.blob.core.windows.net/repos/azure-cli_0.2.4-1_all.deb
Install with:
sudo dpkg -i azure-cli_0.2.4-1_all.deb

This has been fixed. An update was pushed server-side. Thanks for the bug report.

Thanks for the fix! I verified it's working for me now


Fade out the yellow background for a warning cell but keep the icon

When the warning cell class is added, attach a fade out for the yellow background but keep the icon. This is similar to what we did for the successful save.
When loading the cells and they go into that state, keep the icon only.
This will need the classes to be split so the background and cell can be attached individually.

Changing the behaviour of this so no longer required.


ERROR hostByName TTN Abort called

Host esp8266-0c3131 WiFi Connected to Pe de Tamarindo on IP=<IP_ADDRESS>
Local UDP port=1700
Connection successful
Gateway ID: 600194FFFF0C3131, Listening at SF9 on 903.90 Mhz.
Setup:: ERROR hostByName TTN
Abort called

Does anyone know how to solve this and connect?
Ty

The system cannot get the ip address of your TTN server. What address did you specify for the ttnserver in the ESP-sc-gway.h file?

#define _TTNSERVER "ttn-router-brazil", the same in TTN panel.

I do not think that is a full domain name. Is has to be a hostname including a domain like the example in my code or a fully qualified IP address. The DNS server will never find that host on the internet.
Maarten

brazil.thethings.network seems to be the host to look for

It worked!

Now i have an TNN ip, but still in this line, the TTN panel is not showing as connected.

Anyone have any ideas?

Thanks


Collapse all Group by default and add functionality of nested grouping

Describe the feature request
There are two functionalities :

Add a functionality to collapse a group either at UI level or at each group level, something like this ui.collapsed-by-default or group.collapsed-by-default

Add a functionality to have nested groups. I have many groups that can come under a top-level group. For example, I have a Host Jenkins Operations Centre which I want to make as a parent group and then I have three different servers which will have many endpoints. So, the flow will be one parent group can be there (maybe without endpoint) and inside that many groups can reside.

Why do you personally want this feature to be implemented?
Two reasons:

I want to use this at an Enterprise level
I can see many open issues more or less related to same functionality

How long have you been using this project?
3 months
Additional information
Comment even If you are not willing to add this :)

@TwiN , looks like lots of users are requesting this feature, could you pls provide an update on this...

Hi
Or maybe separate subpages for each group When you click on a group you get navigated to another context (subpage) on the url.
When you create a check you can specify the parent group name. (The group name can be a Context of url)
name: k8s
url: http://k8s-cluster:8080/health
group: core <-------
interval: 1m
conditions:
"[STATUS] == 200"
"[BODY].status == UP"
name: ns1
parent: core
name: ns2
parent: core
So url. Http://gatus.local/core. Will show all childs. ns1 and ns2

Seems to be a partial duplicate to https://github.com/TwiN/gatus/issues/416 !?


Add localforagedown

localforagedown is a abstract-leveldown compliant store created by me. It uses localForage as it storage backend (which uses following driver in sequence: IndexedDB, WebSQL, localStorage)

@vweevers


Feature Request: Option for case sensitivity

The default option for case sensitivity in path-to-regexp is false and I couldn't find an option to set it from a new Vue router instance.  I'm trying to redirect some old paths in a project to new ones, and some of these new paths are just capitalized versions of the old, like /all-stores to /All-Stores but this causes an infinite redirect loop with the current setting.

Hello! URIs are case insensitive (even if servers can handle them differently), so there's no reason to add an option to allow creating case sensitive routes to vue-router. It'll make things confusing and allow people to create routes that are wrong.

Although schemes are case-
insensitive, the canonical form is lowercase and documents that
specify schemes must do so with lowercase letters.

(https://tools.ietf.org/html/rfc3986#section-3.1)

Hey @posva The specification you posted there is only talking about the scheme (http, ftp, ws, etc...) According to the rfc spec the scheme and host are case insensitive, but the path portion of the URI is supposed to be case sensitive.
From https://tools.ietf.org/html/rfc3986#section-<IP_ADDRESS>

For all URIs, the hexadecimal digits within a percent-encoding
triplet (e.g., "%3a" versus "%3A") are case-insensitive and therefore
should be normalized to use uppercase letters for the digits A-F.
When a URI uses components of the generic syntax, the component
syntax equivalence rules always apply; namely, that the scheme and
host are case-insensitive and therefore should be normalized to
lowercase.  For example, the URI HTTP://www.EXAMPLE.com/ is
equivalent to http://www.example.com/.  The other generic syntax
components are assumed to be case-sensitive unless specifically
defined otherwise by the scheme.

According to that the scheme, host and the hexidecimal parts of the path are case insensitive, but all other components should be case sensitive.

but all other components should be case sensitive.

Sorry, but there is no such statement in the RFC.

That link above (https://tools.ietf.org/html/rfc3986#section-<IP_ADDRESS>) does say the other components are assumed to be case-sensitive.

The other generic syntax
components are assumed to be case-sensitive unless specifically
defined otherwise by the scheme (see Section 6.2.3).

And Section 6.2.3 (https://tools.ietf.org/html/rfc3986#section-6.2.3) has no mention of the path, so we can assume it to be case sensitive.

I see that statement in the RFC...
And nothing in the HTTP 1.1 RFC (https://tools.ietf.org/html/rfc7230#section-2.7) states otherwise, so it seems to me that the path should be case sensitive.
GoogleBot also treats paths as case sensitive so there's some accepted industry practices as well.

assumed to be isn't equivalent of required to be(or should be).
Case sensitivity for urls is generally decided by implementations as of today.

So if you are saying that assumed to be is not the same as required to be and should be decided by the implementation. Then it seems to make more sense to allow the developers to decide if they want their URIs to be case sensitive or insensitive, not the library's.

Case sensitivity for urls is generally decided by implementations

I would think this reasoning is exactly why case sensitivity in urls should be an option in the vue router.
That way the implementation can decide if urls should be case sensitive.
IMHO the application using the framework is the implementation and should make implemenation decisions.  As the framework, vue should empower the application to make these types of decisions.

Well, PRs are always welcome.

Paths should not be case sensitive but they can. On the other hand, query params like ?query=Hello are always case sensitive.
I overlooked the first thing and thought they couldn't, sorry for that. Makes sense to support it, indeed.
About the implementation: an SPA is half of the implementation, the other half being the server. If a user activates the case-sensitive paths, he also needs to make sure the server treats them correspondingly. But I'm pretty sure that's the default behaviour. For instance, Google cares about it while Stack Overflow doesn't.
If you want to submit a PR, you need to add an option like caseSensitive or a pathToRegexpOptions that can contain other attributes like strict (looks like the only one that is useful too) to the RouteConfig type https://github.com/vuejs/vue-router/blob/dev/flow/declarations.js#L32 and then pass it down until getRouteRegex. I think the caseSensitive option looks better. Hope it helps.

Thanks, i will work on a PR

Submitted PR #1215


Multibinding with Converter handles Enum Value as AvaloniaProperty.UnsetValue

Describe the bug
Using this converter
	class SelectIconConverter : ADC.IMultiValueConverter 	{ 		public object? Convert(IList<object?> values, Type targetType, object? parameter, CultureInfo culture) 		{ 			if (values.Count != 3) return null; 			if (values[0] is not bool IsToggled) return null; 			if (values[1] is not Icon Untoggled) return null; 			if (values[2] is not Icon Toggled) return null; 			return IsToggled ? Toggled : Untoggled; 		} 	}
and the enum Icon the Multibinding handles a valid enum value as an Unset Value.

Code is in Avalonia.Data.Multibinding
To Reproduce
Make a multiconverter, which takes a bool and two Enum Values to select from.
Pass this Converter to an Property by Code.
Expected behavior
obj is not UnsetValue, so it should return obj an not FallbackValue
Avalonia version
11.0.10
OS
Windows
Additional context
No response

file a minimum sample to reproduce please. Thanks.

In my Test Project everything works fine. Also, the so Value to return gets set to the calced obj.
There are other Problems but not for this issue, so I close this ticket.
Anyway thanks.


Add WebTransport

w3c draft here https://www.w3.org/TR/webtransport/
0x01d1
related: https://github.com/multiformats/multiaddr/pull/126

@Stebalien pinging for review (I can't add as reviewer)

Thanks!

NOTE: this is a draft. if we need to move it, we can.


Change logo

Proposing changing the logo to this more descriptive image:

Proposing changing the logo to this more descriptive image:

LGTM

LGTM

Thank you, @yakkomajuri

Thank you, @yakkomajuri


[boost-modular-build-helper] Fix boost build gcc macos

Describe the pull request
Allows boost to be built by GCC on MacOS. I changes to behaviour of boost-modular-build-helper to send gcc as being the compiler when using GCC as compilier instead of hardcoding clang.

What does your PR fix?
Fixes #22380

Which triplets are supported/not supported? Have you updated the CI baseline?
x64-osx, No

Does your PR follow the maintainer guide?

Yes

@yurybura I'm tagging you here since we were already in contact while discussing the issue

I marked it as ready, since I'm able to install boost-system and link to it to create an executable on MacOS using only GCC.

Seems like there are error with rtabmap:x64-windows, but this is completely unrelated to my pull request.

The baseline issue would be fixed by https://github.com/microsoft/vcpkg/pull/22534, please ignore it.

Thanks!


Custom tag - testing

@samaybar - have you tested the behavior with timeSeries and type overrides?

@samaybar - feel free to close this once you are happy.


refactor: simplify handler interface type

Current dependencies on/for this PR:

main

PR #80   👈

This comment was auto-generated by Graphite.


Fixed message routing mode in Py client

Motivation
It's not currently possible to configure message routing mode from Python API.

Merged in branch-2.0 at af96b8a358d10fd61827fb10bb8db64610949487


not such file in directory

python dnapi.py -h
python2: can't open file 'dnapi.py': [Errno 2] No such file or directory

Hello,
DNApi is not automatically imported into the PATH environment variable. In order to find it and use it as a standalone, you have to navigate to the folder it was extracted.
If you are using DIANA-mAP standalone you have to provide that folder in the "path_dnapi" variable of the "diana_map_config.r" file.
If you are using the docker version, DNApi is located in the home/progs/DNApi folder of the docker image and the "diana_map_config.r" is already updated for you.
Thank you for using DIANA-mAP, let me know if you have any other issues.
Regards,
Thanos


Update FileEntry.cs

Some VHD image file names may include "colon" so ":" char and as it is known the filesystem will not allow it and so it must be removed.

/azp run

Thanks again for your reports. Just merged my version #89.


[wise-old-man] Competition reminder and display

Currently, competitions one WOM count XP gained after the first snapshot after it starts. This can be problematic if a user forgets to set a baseline before actually starting to compete (see this).
While discussing automation possibilities for this, it was mentioned that the plugin could notify the user if they're in a competition but haven't got a baseline set. The plugin should probably try to do it for them, but it really should be visible what's going on, and it should tell them if it goes wrong so they can fix it before they log out and submit their first chunk of competition xp.
And since it would be tracking some competition stuff, being able to display competition information to the user (maybe on and overlay) would be nice to see in the plugin, so a user could track maybe their total gains (vs reported gains) and a mini leaderboard (top X and the player's pos, or something)
Discord convo for reference here.

Semi-implemented at 53624073e56a79a942df074fb442d447eb1c5631


Order choices by vote count in results

This also has a side-effect of increasing the performance since we're not performing a count query for each choice, but instead an aggregate query.

Closing (will re-open), had to change something on Heroku.


fix(customize) sets permissions in line with Kong install

When using the customize feature, anything installed will be owned by root. This updates the files to be identically owned as the original Kong installed plugins.
Here's after a customize run (the readme example), installing 2 plugins:
s$ docker run -it --rm kong_custom /bin/bash
bash-5.1$ cd /usr/local/share/lua/5.1/kong/plugins
bash-5.1$ ls -la
total 172
drwxr-xr-x    1 1000     1000          4096 Nov 16 12:25 .
drwxr-xr-x    1 1000     1000          4096 Nov 13 05:49 ..
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 acl
drwxr-xr-x    4 1000     1000          4096 Nov 13 05:49 acme
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 aws-lambda
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 azure-functions
-rw-r--r--    1 1000     1000          1288 Sep 28 18:54 base_plugin.lua
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 basic-auth
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 bot-detection
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 correlation-id
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 cors
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 datadog
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 file-log
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 grpc-gateway
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 grpc-web
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 hmac-auth
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 http-log
drwxr-xr-x    2 root     root          4096 Nov 16 12:25 http-to-https
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 ip-restriction
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 jwt
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 key-auth
drwxr-xr-x    2 root     root          4096 Nov 16 12:25 kong-upstream-jwt
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 ldap-auth
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 log-serializers
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 loggly
drwxr-xr-x    4 1000     1000          4096 Nov 13 05:49 oauth2
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 post-function
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 pre-function
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 prometheus
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 proxy-cache
drwxr-xr-x    4 1000     1000          4096 Nov 13 05:49 rate-limiting
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 request-size-limiting
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 request-termination
drwxr-xr-x    3 1000     1000          4096 Nov 13 05:49 request-transformer
drwxr-xr-x    4 1000     1000          4096 Nov 13 05:49 response-ratelimiting
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 response-transformer
drwxr-xr-x    4 1000     1000          4096 Nov 13 05:49 session
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 statsd
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 syslog
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 tcp-log
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 udp-log
drwxr-xr-x    2 1000     1000          4096 Nov 13 05:49 zipkin
bash-5.1$

Hey @Tieske. Is this change still needed? How does it relate to https://github.com/Kong/docker-kong/pull/546? Can one or both be closed if no longer required?

needs updating after https://github.com/Kong/docker-kong/pull/632 gets merged

Closing this due to lack of activity. Please re-open if needed.

This is still needed. It's just that #632 has been a moving target, so that needs fixing first


We forked this package and have fixed many bugs

This project seems abandoned, so we forked it and did the following:

Updated to the recent HighlightJS 11.8 (was 9.18). A lot of bugs were fixed by this.
Improved the API by adding Language class in addition to Mode to better mimic the original HighlightJS classes.
Improved the porting script so it is easier to understand.
Described the process here: https://medium.com/akvelon/how-we-ported-highlightjs-to-dart-82b107415fbd

The new package is published as:

https://pub.dev/packages/highlighting
https://pub.dev/packages/flutter_highlighting

We intend to maintain our fork.
See the migration guide: https://github.com/akvelon/dart-highlighting/blob/main/doc/migrating.md
(Posting this here as there seems to be no other way to inform the users of the package who are in need of changes.)

@pd4d10 this would be awesome!
For pub.dev, please add<EMAIL_ADDRESS>as admin of the two packages on pub.dev. I can see that they are published as 'Unverified publisher'. This means that it may be easier to do the reverse: I can add your pub.dev email as admin of my publisher, and you can transfer the packages there. If it is easier for you, please drop your email to me at my email above.
Regarding GitHub, we would rather maintain our own fork because we have a history there. What we can do in this repository is write in the README.md an encouragement to migrate and all the new links. For that, please make me an admin (or whatever it is called on GitHub).

OK. My employer would want it under their https://github.com/akvelon organization. Please transfer it there.

My employer would want it under their https://github.com/akvelon organization

OK. Personally, I prefer it to be maintained by the community, but I also fully understand your request, if these work were done during the time working for the company.
Please give me some time to consider it.
Anyway, thanks very much for your work to improve it!

@pd4d10 can you add me on LinkedIn? https://www.linkedin.com/in/alexey-inkin-784b7371/
Communication seems to take long otherwise.
This is just to keep in touch because I no longer work for Akvelon.

@alexeyinkin Now that you are no longer working for Akvelon, can you update us about the status of flutter_highlighting? Is there a commitment to maintain it (by who)?

In Akvelon, @nausharipov is now in charge of Flutter. If anyone knows the roadmap, it is him.

Would you adopt this PR?
https://github.com/git-touch/highlight.dart/pull/50

@busslina, yes. Thank you. I've replied here: https://github.com/akvelon/dart-highlighting/issues/74#issuecomment-1836018619

A year later, the fork appears to be abandoned 🫤


Homebrew formula for kalibrate-hackrf

Instead of https://github.com/scateu/kalibrate-hackrf/blob/master/INSTALL.homebrew manual instruction steps, why not submit a formula to homebrew-core so installation is simple as brew install kalibrate-hackrf?
I started one here: https://github.com/rxseger/homebrew-hackrf/blob/master/kalibrate-hackrf.rb - it is not in the main homebrew-core repo, so it has to be tapped:
brew tap rxseger/homebrew-hackrf
brew install kalibrate-hackrf

also it uses https://github.com/rxseger/kalibrate-hackrf instead of https://github.com/scateu/kalibrate-hackrf primarily for https://github.com/scateu/kalibrate-hackrf/pull/8, but this could be changed.
And it doesn't fully follow the homebrew formula cookbook rules yet. The main blocker seems to kalibrate-hackrf would need a "stable release", e.g. a version tag, instead of only the git development 'master' branch:

Stable versions
Formulae in the core repository must have a stable version tagged by the upstream project. Tarballs are preferred to git checkouts, and tarballs should include the version in the filename whenever possible.
Software that only provides a development/beta, tagged version should be put in homebrew/devel-only. We don’t accept software without a tagged version because they regularly break due to upstream changes; we can’t provide bottles for them; and we don’t have an automatic update mechanism for head-only formulae which makes them very quickly outdated.

would you be willing to make an official "release" of kalibrate-hackrf for this purpose?

Hi Robert,
It's a great pleasure to see that this project works for you. But I am
currently some kind of busy, and there is not enough time for me to
submit a pull request for homebrew-core repo or do other kind of
maintainance work.
I have added you as a collaborator of this project. You can push your
changes directly into this repo, and do what you need to make this project
more useful for other people.
Thanks.
--
Wang Kang

Thanks scateu! I'll see what I can do.

@scateu trying to push changes from my fork to here but I'm getting access denied, can you check:
kalibrate-hackrf $ git remote -v | grep origin
origin	git@github.com:scateu/kalibrate-hackrf (push)
origin	git@github.com:scateu/kalibrate-hackrf (fetch)
kalibrate-hackrf $ git push -u origin master
ERROR: Permission to scateu/kalibrate-hackrf.git denied to rxseger.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Collaborators
Push access to the repository
 @rxseger
 Robert X. Seger
 Awaiting rxseger's response

It seems that you have to confirm my invitation at some where.

Got it, cheers! Pushed my changes

Issues to resolve before publishing 1.0:

[x] https://github.com/scateu/kalibrate-hackrf/pull/12 - add documentation (done)
[ ] https://github.com/scateu/kalibrate-hackrf/issues/6 - calibration error


Fix icon imports in authentication

Closes #  Github issue #324
Description
Fix icon imports in authetication
Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

Additional Information

LGTM! Thank you :)


Disconnection not working with InstantLogin HOC

Conflicts in Instantlogin HOC which are preventing when user wants to disconnect

https://github.com/NilsonKr/DHub/pull/33


Histogram Scale doesn't recover following overexposure / washout

Per Chris, if you saturate the image while adjusting the camera parameters, the histogram fails to recover from the saturation when displayed image recovers from saturation.

This was likely fixed a long time ago.  It does not do this now.


Allow vscode:// URLs inside tooltips/hovers

I'm trying to write an extension that generates documentation for functions with specific annotations. The documentation is displayed in the VS Code hover tooltips, and contains links to metrics relevant to that specific function. So far it works if the links are regular http:/https: links to an external application that renders the metrics. However, we want to go a step further and use vscode: links so that extension itself can intercept the links and open the metrics in a dedicated viewer that we'll include with the extension.
Unfortunately, it appears that vscode: links are simply not rendered in the hover tooltips. If I create a Markdown file with such a link and open the Preview, everything works. But the exact same content inside of a hover will refuse to make the link clickable. I notice the same behavior regardless of whether the hover content is provided by my extension or when I write it myself in a custom doc comment attached to the function. I can only assume this is done out of caution from a security perspective, although I believe there isn't much risk at least in allowing links to an extension when the hover content is provided by that very same extension.
Is there a way to make such links clickable that I'm unaware of, or could you maybe suggest an alternate way I might achieve the desired functionality? If this is not currently possible, would you consider implementing this in VS Code?
Please see the following issue if you would like more context on the extension we're working on: https://github.com/autometrics-dev/vscode-autometrics/issues/20
Thanks!

Oh, I have found that a HoverProvider can set isTrusted on MarkdownString objects which then allows me to use command: URLs inside the tooltip. It's definitely a step closer to where I want to be, although I haven't figured out yet if/how I can pass arguments to the command, because that's still necessary for our use case.
vscode: URLs still appear unusable even with isTrusted, which is a little bit unfortunate, because at least that would allow me to pass deep links relatively easily. But maybe I will still figure out how to do that with command: URLs :)

Hah, the baseUri property on MarkdownString allows me to work around the limitation by setting it to vscode://fiberplane.autometrics. Then I just use a relative path in my tooltip content and it bypasses the limitation. I'm not sure sure if this is by design, so I will leave this issue open to hear if it's safe to rely on this.
There is also something peculiar about how the URI arrives in my UriHandler, because for example, the URI vscode://fiberplane.autometrics/graph?... is parsed into a vscode.Uri object, where I would expect the path property to be /graph and uri.query to contain the ?... part. But instead path is /graph?.... Nothing I cannot work around in my code, just thought I'd mention it.

You should be able to do it this way:
[fire command](command:myextension.sayHello?["me"])

where the args are in a JSON formatted array after a ? after the command.
So for me, I did:
const md = new vscode.MarkdownString('[fire command](command:myextension.sayHello?["me"])');
md.isTrusted = { enabledCommands: ['myextension.sayHello']};

and the command basically did:
vscode.commands.registerCommand('myextension.sayHello', (args) => {
  vscode.window.showInformationMessage(`Hello ${args}!`);
});

To which I got:

@TylerLeonhardt Thanks! I wouldn't have guessed that syntax :)
One issue I should note is that I tried using md.isTrusted = { enabledCommands: ['autometrics.graph.open']}; but if I do that the tooltip will not appear at all. But using md.isTrusted = true does work, so at least I'm unblocked, but it's still curious, and there's no feedback as to why it would be blocked.

Also, if someone else stumbles upon this thread: Don't forget to call encodeURIComponent() on your JSON array of args, otherwise it will still silently fail if there's special characters in your args.

@mjbvz can you answer the part about isTrusted not working right?

@arendjr Can you please provide a minimal code example where it's not working

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Why use parallels over HyperKit

Could the Parallels team update the readme with a list of benefits and maybe even drawbacks to using parallels over docker desktop/macos built in hyperkit virtualization?

Here's why: https://github.com/docker/roadmap/issues/7

@wrobelda could you please summarise? I've read most of the entire thread but can't see where it mentions either VM solution.

Stock Docker on macOS has severe performance issues, especially around networking stack.

Thanks; and Parallels improves upon this, specifically?

Thanks; and Parallels improves upon this, specifically?

Well, Parallels is the most performant hypervisor available for macOS, with little overhead in any performance aspect.

I'm pleased to hear this since recently investing in it. Thank you


Fixed Issue #229

Addeed Examples from Readme to Optax-101.ipynb to Fix Issue #229

Hey @Warlord-K - I am working on getting this rendered so I can take a look at it.
In the mean time, do you think you could format the JSON so that it matches the original format? This will ensure the diff is clean and will help me see what has changed.

Hey @Warlord-K - I am working on getting this rendered so I can take a look at it.
In the mean time, do you think you could format the JSON so that it matches the original format? This will ensure the diff is clean and will help me see what has changed.

Okay I will try to fix it

hey @Warlord-K @rosshemsley, happy to hop in and help with this one if this is still relevant

@amosyou : yes please  , it would be great if you can take over so we can get it merged 🙌🏼

@fabianp sorry this is my first time contributing to open source, should I make these changes and push to @Warlord-K 's fork or should I do it in mine?

Better to create a new branch in your repo and push there. You usually don't have permissions to push to other people's forks

I created a new PR #726, wasn't sure how to add my commits from my fork to this existing PR

closing in favor of https://github.com/google-deepmind/optax/pull/726


Incorrect player spawns for Y7S4 replays

Describe the bug
Hey there, sorry to keep bothering.
All my replays from Y7S4 currently produce incorrect spawns / roles for some rounds.
I am running on your most recent commit on main (d934da6).
For the affected rounds, the spawn is filled for all players. For the attackers, it's their actual spawn, for the defenders though, it's the same spawn for all:
  "teams": [
    {
      "name": "YOUR TEAM",
      "score": 1,
      "won": true,
      "winCondition": "DISABLED_DEFUSER",
      "role": "ATTACK"
    },
    {
      "name": "OPPONENTS",
      "score": 2,
      "won": false,
      "role": "ATTACK"
    }
  ],
  "players": [
    {
      "id":<PHONE_NUMBER>492722120,
      "profileID": "fa94e165-6328-4a9b-8581-81735ffaba27",
      "username": "Knoblauch.SOOS",
      "teamIndex": 0,
      "heroName":<PHONE_NUMBER>81,
      "alliance": 0,
      "roleImage":<PHONE_NUMBER>42,
      "roleName": "WARDEN",
      "rolePortrait":<PHONE_NUMBER>68,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>8034145238,
      "profileID": "b65a0d8d-b676-4d02-9eee-e9c3756d942b",
      "username": "Oliver124",
      "teamIndex": 0,
      "heroName":<PHONE_NUMBER>20,
      "alliance": 0,
      "roleImage":<PHONE_NUMBER>76,
      "roleName": "KAID",
      "rolePortrait":<PHONE_NUMBER>06,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>850206533,
      "profileID": "2198c78f-fdb5-4494-93a3-2da39b5f1dc0",
      "username": "KTKrueger",
      "teamIndex": 0,
      "heroName": 423855893,
      "alliance": 0,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "KAPKAN",
      "rolePortrait":<PHONE_NUMBER>2,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>960069847,
      "profileID": "bf597fa6-ca43-4ceb-9fd3-644aacf6fb99",
      "username": "Vanille.SOOS",
      "teamIndex": 0,
      "heroName": 350237839,
      "alliance": 0,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "ROOK",
      "rolePortrait":<PHONE_NUMBER>7,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>5649856136,
      "profileID": "f1080efc-58a1-4c15-aaad-f2ca8fad21a7",
      "username": "Chili.SOOS",
      "teamIndex": 0,
      "heroName": 423855917,
      "alliance": 0,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "CASTLE",
      "rolePortrait":<PHONE_NUMBER>6,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>330991033,
      "profileID": "e3b1a612-81c3-4b80-9c3d-2e7c9fbbde2c",
      "username": "natalieczka",
      "teamIndex": 1,
      "alliance": 0,
      "spawn": "River Docks"
    },
    {
      "id":<PHONE_NUMBER>0445550787,
      "profileID": "0023824a-ea2b-483b-a5dd-e8fa8e4e09b2",
      "username": "GOATMysterion",
      "teamIndex": 1,
      "alliance": 0,
      "spawn": "River Docks"
    },
    {
      "id":<PHONE_NUMBER>279472193,
      "profileID": "b96de89b-8624-405d-af5c-22a5bb4a9ea2",
      "username": "LuluTwentyFaces",
      "teamIndex": 1,
      "alliance": 0,
      "spawn": "Park"
    },
    {
      "id":<PHONE_NUMBER>4621837973,
      "profileID": "cbf919f7-0ef8-4435-b5df-cbc8f4b0ded1",
      "username": "You296",
      "teamIndex": 1,
      "alliance": 0,
      "spawn": "Christmas Market"
    },
    {
      "id":<PHONE_NUMBER>8522065878,
      "profileID": "dc16e35d-fd9b-41ca-aa2e-5c1d5e9a4840",
      "username": "Sniper07Paul",
      "teamIndex": 1,
      "alliance": 0,
      "spawn": "RANDOM"
    }
  ],

As a byproduct, this also results in wrong team roles since you are deriving them from the spawn:
https://github.com/redraskal/r6-dissect/blob/d934da6b67341a5ddaa16914977ccad1c37f3c52/dissect/player.go#L77-L82
To Reproduce
Steps to reproduce the behavior:

Use the replay files I already sent you via email
Parse rounds 3 or 4 of those files
See how you get ATTACK role for both teams and inconsistent spawns

Expected behavior
Empty spawns for defenders and no duplicate team roles.
Additional context
I don't have any Y8S1 replays yet, so can't check with those.
For Y7S4, I can confirm though that all replays I have produce this issue. I also tested with some replays of SI '23.
Also, it seems like the issue only pops up after the first role swap, i.e. the first few rounds of a match are usually fine.

Hmm role swap was what I figured would cause this. I'll look into it today

Can confirm the same issue occurs for Y8S1 replays.

Adding to this:
The logic here:
https://github.com/redraskal/r6-dissect/blob/d934da6b67341a5ddaa16914977ccad1c37f3c52/dissect/player.go#L77-L82
Probably doesn't work for Y8S1 replays, I'm getting spawns for defenders too that correspond to the objective site (i.e. 2F Master Bedroom, 2F Office). They are only set for some defenders though, not all. The attackers are correct:
  "teams": [
    {
      "name": "YOUR TEAM",
      "score": 0,
      "won": false,
      "role": "ATTACK"
    },
    {
      "name": "OPPONENTS",
      "score": 1,
      "won": true,
      "winCondition": "TIME",
      "role": "DEFENSE"
    }
  ],
  "players": [
    {
      "id":<PHONE_NUMBER>716045712,
      "profileID": "eb68b1db-0aec-4c1d-bf96-0d548db88c91",
      "username": "andony._.",
      "teamIndex": 1,
      "heroName":<PHONE_NUMBER>5,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>92,
      "roleName": "ALIBI",
      "rolePortrait":<PHONE_NUMBER>84,
      "spawn": "2F Master Bedroom, 2F Office"
    },
    {
      "id":<PHONE_NUMBER>224685073,
      "profileID": "27a3ea4a-73db-4a3d-afba-b62273df6947",
      "username": "escortbaby.",
      "teamIndex": 1,
      "heroName":<PHONE_NUMBER>06,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>39,
      "roleName": "ARUNI",
      "rolePortrait":<PHONE_NUMBER>65,
      "spawn": "2F Master Bedroom, 2F Office"
    },
    {
      "id":<PHONE_NUMBER>685859181,
      "profileID": "34e60dda-0389-47b9-ad81-7b1ea191528b",
      "username": "QWERTUSZ",
      "teamIndex": 1,
      "heroName": 423855917,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "CASTLE",
      "rolePortrait":<PHONE_NUMBER>6,
      "spawn": "2F Master Bedroom, 2F Office"
    },
    {
      "id":<PHONE_NUMBER>795460895,
      "profileID": "45a8fc6f-f325-4239-b78f-bcbc20ba3eef",
      "username": "MilusANevem",
      "teamIndex": 1,
      "heroName":<PHONE_NUMBER>0,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>9,
      "roleName": "ELA",
      "rolePortrait":<PHONE_NUMBER>3
    },
    {
      "id":<PHONE_NUMBER>130398684,
      "profileID": "bb43cb21-f128-4c5d-a3ed-470958a62b62",
      "username": "Du-Simulant.",
      "teamIndex": 1,
      "heroName": 423855857,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "MUTE",
      "rolePortrait":<PHONE_NUMBER>4,
      "spawn": "2F Master Bedroom, 2F Office"
    },
    {
      "id":<PHONE_NUMBER>3785102634,
      "profileID": "fa94e165-6328-4a9b-8581-81735ffaba27",
      "username": "Knoblauch.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>360922830,
      "profileID": "584c0cb8-3c04-4453-8a75-048acc44807c",
      "username": "Metaxa.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>7154839291,
      "profileID": "f1080efc-58a1-4c15-aaad-f2ca8fad21a7",
      "username": "Chili.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>1495581310,
      "profileID": "1fec87fe-209f-4554-b3c5-9a1065fa3262",
      "username": "Erdnuss.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>6015324208,
      "profileID": "bf597fa6-ca43-4ceb-9fd3-644aacf6fb99",
      "username": "Vanille.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    }
  ],

To make it even harder for you, the next round has no spawns set for defenders:
  "teams": [
    {
      "name": "YOUR TEAM",
      "score": 1,
      "won": false,
      "role": "ATTACK"
    },
    {
      "name": "OPPONENTS",
      "score": 1,
      "won": false,
      "role": "DEFENSE"
    }
  ],
  "players": [
    {
      "id":<PHONE_NUMBER>716045712,
      "profileID": "eb68b1db-0aec-4c1d-bf96-0d548db88c91",
      "username": "andony._.",
      "teamIndex": 1,
      "heroName":<PHONE_NUMBER>36,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>01,
      "roleName": "AZAMI",
      "rolePortrait":<PHONE_NUMBER>64
    },
    {
      "id":<PHONE_NUMBER>224685073,
      "profileID": "27a3ea4a-73db-4a3d-afba-b62273df6947",
      "username": "escortbaby.",
      "teamIndex": 1,
      "heroName": 350237835,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "DOC",
      "rolePortrait":<PHONE_NUMBER>5
    },
    {
      "id":<PHONE_NUMBER>130398684,
      "profileID": "bb43cb21-f128-4c5d-a3ed-470958a62b62",
      "username": "Du-Simulant.",
      "teamIndex": 1,
      "heroName": 423855857,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "MUTE",
      "rolePortrait":<PHONE_NUMBER>4
    },
    {
      "id":<PHONE_NUMBER>795460895,
      "profileID": "45a8fc6f-f325-4239-b78f-bcbc20ba3eef",
      "username": "MilusANevem",
      "teamIndex": 1,
      "heroName": 350237879,
      "alliance": 4,
      "roleImage":<PHONE_NUMBER>,
      "roleName": "BANDIT",
      "rolePortrait":<PHONE_NUMBER>4
    },
    {
      "id":<PHONE_NUMBER>3785102634,
      "profileID": "fa94e165-6328-4a9b-8581-81735ffaba27",
      "username": "Knoblauch.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>360922830,
      "profileID": "584c0cb8-3c04-4453-8a75-048acc44807c",
      "username": "Metaxa.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>7154839291,
      "profileID": "f1080efc-58a1-4c15-aaad-f2ca8fad21a7",
      "username": "Chili.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    },
    {
      "id":<PHONE_NUMBER>1495581310,
      "profileID": "1fec87fe-209f-4554-b3c5-9a1065fa3262",
      "username": "Erdnuss.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Campfire"
    },
    {
      "id":<PHONE_NUMBER>6015324208,
      "profileID": "bf597fa6-ca43-4ceb-9fd3-644aacf6fb99",
      "username": "Vanille.SOOS",
      "teamIndex": 0,
      "alliance": 0,
      "spawn": "Cliffside"
    }
  ],

Again, if required, I can provide you with the replay files, just let me know.

Looking through some Y8 replays today for this issue

I ended up finding how to fetch the op picks. If I don't find a direct way to fetch alliance for all players, I will just assign the role based on the ops.

I ended up finding how to fetch the op picks. If I don't find a direct way to fetch alliance for all players, I will just assign the role based on the ops.

I think i'll ditch the alliance field and expand upon the operators

That's a good idea.
I never used the alliance field anyways, I wasn't sure how it differed from role .

That's a good idea.
I never used the alliance field anyways, I wasn't sure how it differed from role .

I don’t know either- just did not want to omit data. Probably good to avoid relying on player data from the file header since Ubisoft often changes the format.

The issues with spawns are:

Defense site may be missing
Defense spawns are set to an attacking spawn

May need to look in a different part of the file for defense spawns. I'm not sure why the defense site can be missing

I removed invalid spawns on defense in #41. Defense spawns will be looked into later on.

Going to close this and make an issue for the missing defense site and defense spawns

Going to close this and make an issue for the missing defense site and defense spawns

As long as we have consistent defense sites, we can just set the defender spawns to the defender site, right?

Going to close this and make an issue for the missing defense site and defense spawns

As long as we have consistent defense sites, we can just set the defender spawns to the defender site, right?

Yes, although I think the specific room would be nice. It seems redundant to include the site twice.

Well if that's possible, then yeah sure, some additional info is always nice. 😄


chore: promote heylo to version 0.0.2

this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

heylo
Changes in version 0.0.2
Chores

release 0.0.2 (jenkins-x-bot)
add variables (jenkins-x-bot)

Other Changes
These commits did not use Conventional Commits formatted messages:

Update app.py (Khairul Anwar)

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kulll: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
288a8397f5ba00cde7942b2fde9d518905caf0cd
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Add flag volumeMode and deprecate block-volume for virtctl image-upload

What this PR does / why we need it:
Add volumeMode and deprecate block-volume for virtctl image-upload.
'block-volume'  is not a proper name for volumeMode and it's possible to mislead users as it shows in #4707, hence change it to more native name 'volue-mode' as it's easy to understand what it does.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4707
Special notes for your reviewer:
Release note:

A new flag 'volume-mode' is added as a replacement of 'block-volume' for the PVC volumeMode in virtctl image-upload, the flag 'block-volume' is deprecated now.

Maybe just making the description on the flag more clear could be enough.

My opinion is the flag '--block-volume' is not self-explaining, it takes time to figure out what it's doing.

My opinion is the flag '--block-volume' is not self-explaining, it takes time to figure out what it's doing.

Works for me :+1:

/test pull-kubevirt-e2e-k8s-1.17

@gouyang please improve your pr message and commit message. I could not understand from it that you are deprecating and option of virtctl.
This change requires a release note.
There may be users with scripts that have --block-volume=true. We cannot break them without proper notice. At this stage, you should emit a warning, but accept the old command line, too. In 6-12 months you can make it an error.

@dankenigsberg PTAL, I made the changes accordingly.

@dankenigsberg I tried to put it into a function like [1], it's quite similar with by using the variable volMode. Not sure whether I did it well. A drawback of this approach is that the flag is not validated immediately [2], because of this, I intend to use the variable volMode thought the name is not good, maybe a variable name like specVolumeMode?
[1] https://gist.github.com/gouyang/62eaa8c432805246a6b7e6ad760bf4a4
[2]
./virtctl image-upload dv rhel6 --size=10Gi --image-path=./cirros.img --storage-class=nfs --volume-mode=test --access-mode=ReadWriteOnce --insecure
Using existing PVC default/rhel6
Waiting for PVC rhel6 upload pod to be ready...
timed out waiting for the condition

Sorry, @gouyang, the context of (your gist)[https://gist.github.com/gouyang/62eaa8c432805246a6b7e6ad760bf4a4] is not enough for me to understand the problem your report, nor why more variables are needed.
I believe that one can call
volumeMode, err = normalizeVolumeMode(volumeMode, blockVolume)

quite early, and thereafter use only volumeMode.

@dankenigsberg Updated the gist https://gist.github.com/gouyang/62eaa8c432805246a6b7e6ad760bf4a4

dankenigsberg Updated the gist https://gist.github.com/gouyang/62eaa8c432805246a6b7e6ad760bf4a4

My suggestion is that you call volumeMode, err = normalizeVolumeMode(volumeMode, blockVolume) in parseArgs.

@dankenigsberg I've been thinking about it before and I don't like to put a function into parseArgs.  I write it in another way without using function or new variables, https://gist.github.com/gouyang/2a377e4c9eeb1ac4ded96ccf75674905, does it look good?

Reviewing via gist is not comfortable. Can we avoid it?
I don't understand why you resent the idea of a helper function. Please explain why, or ask someone other than me to review this PR.

Reviewing via gist is not comfortable. Can we avoid it?
Sorry to bother you so much and thank you for the patience!
I pushed the commit here.

I don't understand why you resent the idea of a helper function. Please explain why, or ask someone other than me to review this PR.
Put a helper function into parseArgs looks not so good to me because function is not an arg.

/test pull-kubevirt-e2e-k8s-cnao-1.19

/test pull-kubevirt-e2e-k8s-cnao-1.19

@rmohr PTAL

@rmohr PTAL


⚠ Bofrost.lu has degraded performance

In 6bc4161, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2202 ms

Resolved: Bofrost.lu performance has improved in 4fbfcbc after 21 minutes.


ARROW-12832: [JS] Write benchmarks in TypeScript

[ ] actually load the sources by default

Can we merge this?

Since this pull request is part of https://github.com/apache/arrow/pull/10362 and @trxcllnt approved that one already, I think this can be merged as well.