Update til::bitmap to use dynamic_bitset<> + libpopcnt

This commit replaces std::vector<bool> with dynamic_bitset<> by
@pinam45 (https://github.com/pinam45/dynamic_bitset) and with
libpopcnt for high-performance bit counting by @kimwalisch
(https://github.com/kimwalisch/libpopcnt).

[x] In support of performance, incremental rendering, and Terminal
"not speed enough" as well as my sanity relative to
std::vector<bool>
[x] Tests updated and passed.
[x] LICENSE, NOTICE, and provenance files updated.
[x] I'm a core contributor. I discussed it with @DHowett-MSFT and
cleared the licensing checks before pulling this in.

Details std::vector<bool> provided by the Microsoft VC Runtime is
incapable of a great many things. Many of the methods you come to expect
off of std::vector<T> that are dutifully presented through the bool
variant will spontaneously fail at some future date because it decides
you allocated, resized, or manipulated the vector<bool> specialization
in an unsupported manner. Half of the methods will straight up not work
for filling/resizing in bulk. And you will tear your hair out as it will
somehow magically forget the assignment of half the bits you gave it
part way through an iteration then assert out and die.
As such, to preserve my sanity, I searched for an alternative. I came
across the self-contained header-only library dynamic_bitset by
@pinam45 which appears to do as much of boost::dynamic_bitset as I
wanted, but without including 400kg of boost libraries. It also has a
nifty optional dependency on libpopcnt by @kimwalisch that will use
processor-specific extensions for rapidly counting bits. @DHowett-MSFT
and I briefly discussed how nice popcnt would have been on
std::vector<bool> last week... and now we can have it. (To be fair, I
don't believe I'm using it yet... but we'll be able to easily dial in
til::bitmap soon and not worry about a performance hit if we do have
to walk bits and count them thanks to libpopcnt.)
This PR specifically focuses on swapping the dependencies out and
ingesting the new libraries. We'll further tune til::bitmap in future
pulls as necessary.
Validation

[x] Ran the automated tests for bitmap.
[x] Ran the terminal manually and it looks fine still.

@msftbot merge this in 1 hour

@DHowett-MSFT (just in case you didn't consider https://github.com/RoaringBitmap/CRoaring which does popcnt stuff internally as well and seems a way more battle-test than https://github.com/pinam45/dynamic_bitset )


我在cmake的时候遇到了问题

_pointnet2.c:22:24: fatal error: pyconfig.h: 没有那个文件或目录
compilation terminated.
Traceback (most recent call last):
File "/usr/lib/python3.6/distutils/unixccompiler.py", line 118, in _compile
extra_postargs)
File "/usr/lib/python3.6/distutils/ccompiler.py", line 909, in spawn
spawn(cmd, dry_run=self.dry_run)
File "/usr/lib/python3.6/distutils/spawn.py", line 36, in spawn
_spawn_posix(cmd, search_path, dry_run=dry_run)
File "/usr/lib/python3.6/distutils/spawn.py", line 159, in _spawn_posix
% (cmd, exit_status))
distutils.errors.DistutilsExecError: command 'x86_64-linux-gnu-gcc' failed with exit status 1
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/xu/.local/lib/python3.6/site-packages/cffi/ffiplatform.py", line 51, in _build
dist.run_command('build_ext')
File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "/usr/lib/python3.6/distutils/command/build_ext.py", line 339, in run
self.build_extensions()
File "/usr/lib/python3.6/distutils/command/build_ext.py", line 448, in build_extensions
self._build_extensions_serial()
File "/usr/lib/python3.6/distutils/command/build_ext.py", line 473, in _build_extensions_serial
self.build_extension(ext)
File "/usr/lib/python3.6/distutils/command/build_ext.py", line 533, in build_extension
depends=ext.depends)
File "/usr/lib/python3.6/distutils/ccompiler.py", line 574, in compile
self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)
File "/usr/lib/python3.6/distutils/unixccompiler.py", line 120, in _compile
raise CompileError(msg)
distutils.errors.CompileError: command 'x86_64-linux-gnu-gcc' failed with exit status 1
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/media/xu/BAF5-9BE9/0_Experiment/0_ex/Relation-Shape-CNN-master/utils/build_ffi.py", line 54, in
build(args)
File "/media/xu/BAF5-9BE9/0_Experiment/0_ex/Relation-Shape-CNN-master/utils/build_ffi.py", line 42, in build
ffi.build()
File "/home/xu/.local/lib/python3.6/site-packages/torch/utils/ffi/init.py", line 184, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/home/xu/.local/lib/python3.6/site-packages/torch/utils/ffi/init.py", line 108, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/home/xu/.local/lib/python3.6/site-packages/cffi/api.py", line 723, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/home/xu/.local/lib/python3.6/site-packages/cffi/recompiler.py", line 1527, in recompile
compiler_verbose, debug)
File "/home/xu/.local/lib/python3.6/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/home/xu/.local/lib/python3.6/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.VerificationError: CompileError: command 'x86_64-linux-gnu-gcc' failed with exit status 1
CMakeFiles/pointnet2_ext.dir/build.make:67: recipe for target '../utils/_ext/pointnet2/_pointnet2.so' failed
make[2]: *** [../utils/_ext/pointnet2/_pointnet2.so] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/pointnet2_ext.dir/all' failed
make[1]: *** [CMakeFiles/pointnet2_ext.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
使用您的代码报错缺少文件，请问该如何解决

It seems that something is wrong with your python environment. Maybe you need to install anaconda3 and configure it as your python environment.


Versioning of a Git dependency is confusing

[build-dependencies]
ctest = { git = "https://github.com/alexcrichton/ctest" }

When I run cargo build, the corresponding console output from cargo looks like
   Compiling ctest v0.1.0 (https://github.com/alexcrichton/ctest#a6becb6d)

Here, v0.1.0 does not serve as a proper semantic version of the referenced Git repository because the author could be committing arbitrary changes to the repo between their "releases." Practically speaking, the author isn't likely to update the semver for each and every commit. So the meat of the above console output is in the a6becb6d part, except it doesn't look like so at all.
The output format should better be changed to something like
Compiling ctest a6becb6d (https://github.com/alexcrichton/ctest)

so as to emphasize the fact that there's no fixed "v0.1.0" in the referenced repo (of course, when the build dependency doesn't have the tag=... option.)
Ideally we should invent a better way of displaying how a particular revision was chosen by Cargo.toml and possibly Cargo.lock but that's another topic.

For me, the main issue is that showing a sha isn't all that meaningful to the user but showing the version (assuming the repo isn't living at HEAD with a fixed version) at least provides some context.
So we could do:

Show branch or tag if set
Show version otherwise

As that is all meaningful but the inconsistency isn't great either.
Overall, I wonder if this would be worth the time and energy to hash out what to show, change cargo to get it to work, and write the tests.
I'm going to nominate this for closing.

Agree on closing, especially for consistency.

With a second, I'm going ahead.
If there is a reason we should reconsider this, let us know!


fix(PeriphDrivers,Examples): Update MXC_I2C_RevX_SlaveAsyncHandler's to support I2C loopback examples at higher speeds

One of our FAE's was inquiring about why the I2C examples did not work at higher speeds. After some digging I discovered we mishandled some of the interrupts in the MXC_I2C_RevX_SlaveAsyncHandler functions, particularly the DONE interrupt. This PR updates those handler functions to prevent them from hanging the I2C Loopback examples at higher speeds and removes the comments in the examples stating the highest speed the examples can run at is 100kHz.

This PR's changes are captured in #719.


Add circleci

Adds circleci for testing
Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

  Generated by :no_entry_sign: Danger

not a clue how, my laptop has a merge conflict with itself ... now just waiting for lint to run, seems to be stuck for some reason


OutputFixingParser problem?

  I was following the example on using the Structured output and then using a fixing parser if its not validated correctly.  for some reason it doesn't appear to be resubmitting my context with the prompt so the response comes back as nonsense compared to what I was asking.
`parser = Langchain::OutputParsers::StructuredOutputParser.from_json_schema(get_json_schema)
llm = Langchain::LLM::OpenAI.new(
  api_key: Rails.application.credentials[:openai_key],
  default_options: {
    chat_completion_model_name: 'gpt-3.5-turbo-16k'
  }
)

llm_response = llm.chat(
  prompt: prompt.format(identity:, format_instructions: parser.get_format_instructions,
                        alteration:),
  context: context.to_json
)

fix_parser = Langchain::OutputParsers::OutputFixingParser.from_llm(
  llm:,
  parser:
)`

I don't see a way to add the context in the fixing parser.  am I going about this the wrong way?
Any help would be greatly appreciated.

@skryking I would put a debugger here and look at what actually gets sent to the LLM.
The default prompt that's used to have the LLM try and fix the invalid response is this one: https://github.com/andreibondarev/langchainrb/blob/main/lib/langchain/output_parsers/prompts/naive_fix_prompt.yaml
If it's missing the context, like you said, I would try (re-)creating your own prompt, inspired by the naive fix prompt above, and pass it directly when the initializing:
fix_parser = Langchain::OutputParsers::OutputFixingParser.from_llm(
  llm:,
  parser:,
  prompt: ... # <= here
)

@andreibondarev Hey thanks, that worked out well.  I was able to stick the needed context into the prompt, and it sent a correctly formatted response that made sense.

@skryking Great... closing this issue for now!


Ghost files after stashing

For me, when I stash some files it keeps them in the directory as "ghosts", with no ability to either modify, save or delete them. Windows complains that I do not have any permissions to the files. Even checking the ACL of the files is not possible.
Only after rebooting the computer do the files finally disappear.
My system:

Windows 10
git 2.18.0.windows.1

Hi @saulimus. Thanks for opening this issue, wasn't aware of this since I'm a Linux user. I'll check it.

Hey @saulimus. Sorry for the delay. I updated the extension and now the majority of files are now displayed without the use of temp files, images still using this method but the library in charge for that has been updated so this issue will be much less annoying (and with faster response). Would you tell me if it works for you?


Selection layer

Changes the way how annotations are made. Previously, the user would manually place blobs on an image to annotate blobs. Now the user selects already detected blobs and assigns them a class. This has the advantage that it is "cleaner" in the sense that really the centroids of the blobs are now selected and not just some point inside a blob where the user clicks. Also it's much easier to annotate blobs in 3D this way.

Codecov Report

Merging #2 (c27b1eb) into master (11f4dae) will decrease coverage by 2.13%.
The diff coverage is 1.63%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   23.58%   21.45%   -2.14%
==========================================
  Files           6        8       +2
  Lines         301      331      +30
==========================================
  Hits           71       71
- Misses        230      260      +30

Impacted Files
Coverage Δ

..._blob_detection/measure_distance_points_objects.py
0.00% <0.00%> (ø)

napari_blob_detection/random_points_mask.py
0.00% <0.00%> (ø)

napari_blob_detection/svm.py
26.41% <0.00%> (+0.48%)
:arrow_up:

napari_blob_detection/_dock_widget.py
25.26% <3.33%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f4dae...c27b1eb. Read the comment docs.


[Request] Update examples/jenkins-kubernetes-plugin-with-build-cache with ephemeral volume usage

I came here from your comments on the https://issues.jenkins.io/browse/JENKINS-42422 issue.
I also read that Provisioner Controller is deprecated in favor of the Ephemeral Volumes.
But I am recently entering the Jenkins using Kubernetes world, and I am struggling to understand more or less how everything is tied.
I have seen the example jenkins-kubernetes-plugin-with-build-cache which still make use of the provisioner. Could be possible to update that example (or create a new one) with the usage of the releaser along with the ephemeral volumes?

Hey @lucasvc - thanks for the interest in this little project! I just removed all mentions of that deprecated provisioner from the docs, and updated all examples for native k8s ephemeral volumes. Check it out of it works and let me know if you find anything I missed! It is still there in the code though.


[Google Sign In] JS Library throwing an error all of a sudden

Summary
We are using the https://accounts.google.com/gsi/client JS Client to render a Login With Google Button on our user interface.
We have been using this successfully for a very long time, all of a sudden a few days ago (around 27th July) the Google Button is not rendering with the following stack trace:
ERROR Error
    at _.$e (client:128:335)
    at new rp (client:227:3)
    at aq (client:246:34)
    at No (client:244:246)
    at Object.Oo [as renderButton] (client:216:62)
    at Pe.renderButton (main.b0501b3ff036f102.js:1:4820)
    at e.renderButton (866.e8e180033653210f.js:1:1040)
    at set googleClientId [as googleClientId] (866.e8e180033653210f.js:1:681)
    at wa (main.b0501b3ff036f102.js:1:652227)
    at xs (main.b0501b3ff036f102.js:1:653110)

Trying to look around it seems that I am not the only person experiencing this issue:
https://stackoverflow.com/questions/76796549/google-login-ui-crashing
This is happening also on multiple environments across my business.
Looks like removing the width property from the google.accounts.id.renderButton seems to fix it
e.g. issue:
    google.accounts.id.renderButton(buttonElement, {
      type: 'standard',
      theme: 'outline',
      size: 'large',
      width: '195',
      locale: 'en-us',
    });

Fixed:
    google.accounts.id.renderButton(buttonElement, {
      type: 'standard',
      theme: 'outline',
      size: 'large',
      locale: 'en-us',
    });

Browser(s)/Version(s)
All
Expected Behavior
Login with Google button should render
Actual Behavior
Login with Google button does not render
Steps to Reproduce
https://stackblitz.com/edit/stackblitz-starters-poqtnt?file=src%2Fmain.ts

I have also reported this issue at https://github.com/googlesamples/google-services/issues/581 last week where the button won't render if you have set a width. The configurator also has the same issue. Other people have the same issue. Removing the width property will resolve the issue.

put 'px' after 195
google.accounts.id.renderButton(buttonElement, {
type: 'standard',
theme: 'outline',
size: 'large',
width: '195px',
locale: 'en-us',
});

put 'px' after 195 google.accounts.id.renderButton(buttonElement, { type: 'standard', theme: 'outline', size: 'large', width: '195px', locale: 'en-us', });

The doc said to use something like width: '400' https://developers.google.com/identity/gsi/web/reference/js-reference#width and it has always work until several days ago. Other people got it to work even without the 'px'. If they updated the api, they should have at least update the doc and the configurator.

Have the same problem and if I add px to the width it works again.

Same here, error started to happen on July 25 2023 on my side. Adding the px fixed it

This happen to us at work, using the debugger from Chrome, we found that theres a condition on that requires number type to the width so currently if you remove the '' sigle quotes the button is renders

@jcteo

btw https://accounts.google.com/gsi/client can return different client.js - with and without width value conversion

maybe this is the cause of the confusion


Tutorial 6.Routing: Need to import HeroDetailComponent

In Tutorial 6. Routing - Create AppComponent section, it says

The app still runs and still displays heroes.

but it doesn't work.
It seems the sample code ( app/app.module.ts (v1) ) lacks HeroDetailComponent .

closed by #2137


Always return a promise, even when no tokens to send to device.

I discovered this type mismatch when converting this code to Typescript.

I'm currently working on an update which will remove this line. I'll close this for now.

Thanks, @nicolasgarnier!


Is this some sort of joke?

https://github.com/zendframework/zend-http/blob/b382c6e068a2d9c87b7cf0dfe78c6dd19e4ff197/src/Response.php#L24

@unfunco
Help is always welcome and also criticism. But please try to make your request reasonable. (see also: Code Manifesto)

Sure, why not? We are not against good laugh after all.

@unfunco yes


🔧 enable ansi in cmd

The Windows Console did not support ANSI escape sequences, nor did Microsoft provide any method to enable them.
But in 2016, Microsoft released the Windows 10 version 1511 update which unexpectedly implemented support for ANSI escape sequences, over two decades after the debut of Windows NT.
Windows Console Host used by Command Prompt support for character escape codes used by terminal-based software for Unix-like systems. This is not the default behavior and must be enabled programmatically with the Win32 API via SetConsoleMode(handle, ENABLE_VIRTUAL_TERMINAL_PROCESSING)
Before

After

That's on uvicorn. You just need to install colorama, and it will be colored.

At the expense of colorama, this is an additional addiction that can be dispensed with. Also no matter what ASGI server we are using (gunicorn, Hypercorn, daphne, uWSGI, uvicorn), ansi escape will always be enabled.

FastAPI shouldn't touch os related behaviours, this should be dealt with by servers. For example how uvicorn detects that it's on windows and doesn't run uvloop.


Serverside checks

theres some validation on client side, but no syntax checks on the server. things like password length / checking if email provided is actually an email

closing this one out - we already have checks for username & password length as well as an alphanumeric check for username on the server as well as client. as for email, i think i'd like to leave it as is in case users want to make an account but don't want to use their real email address.


Fix internal flaky test

Task/Issue URL: https://app.asana.com/0/488551667048375/1207766557111776/f
Description
Fixes flaky test
Steps to test this PR
Feature 1

[ ] tests are green
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4738  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @cmonfortep and the rest of your teammates on  Graphite


call "image tile preview" by right click in explorer

suggestion from https://github.com/ayatough/vscode-image-tile-viewer/issues/29#issue-1103070069

this is duplicated with #20
I missed...


Issues with incentives gauge appearing on the frontend since days

Pool 1470
-No APR showing (API returns 0 as value)

@jonator

Data service issue


RLOS on image service fails with "calculation cancelled" message

From @BobBooth on March 1, 2017 19:42
I have added an image service of elevation data to my map.
(data at: http://navigator.state.or.us/arcgis/services  /Framework/Elevation_DEM_10)
I can run the Military Tools Add-In LLOS tool against it and it works (two points separated by 10,000 meters).
When I run the Military Tools Add-In RLOS against it (default values 1000 m distance, 2m height), I get a message box titled "Calculation cancelled" which says "Results not calculated. Check Input parameters and try again."

Expected Behavior
I would expect the tool to use the elevation data as it would a local layer. The LLOS tool does.
Steps to Reproduce (for bugs)
Add image service of elevation data. (data at: http://navigator.state.or.us/arcgis/services  /Framework/Elevation_DEM_10)
Open LLOS tab. Add two points 10,000 meters apart. Accept defaults, click OK, get correct results.
Open RLOS tab. Add single point (in my case, near the midpoint of the previous two). Accept defaults. Click OK, get error message.
Your Environment
ArcMap 10.4.1
Military Tools Add-in  build 1228
(03-01-2017_1228)
Copied from original issue: Esri/military-tools-desktop-addins#8

From @kgonzago on March 2, 2017 14:37
@csmoore can you look into this when convenient?

From @csmoore on March 2, 2017 14:55
I was able to repro this - the bug is here (needs to also check for ImageServiceLayer)

@topowright - that was the one I saw the problem with. I think @csmoore reproduced it with an east coast DEM image service.

@csmoore can you share the service that you tested against?

@topowright - the service seems to be running. I had a user connection to it in ArcMap and it is displaying.

I have tried to bring that same service up in a browser with no luck. Can you copy the link one more time. Also, check and see if you get the same result in a browser?

http://navigator.state.or.us/ArcGIS/services

Looks like their server (Apache) is rejecting simple web connections to it, even though it is available through an ArcGIS Server connection in ArcMap.

I am able to get the service to open in ArcMap, but not is a browser. Not sure if that is an issue.
I am seeing the same issue you are.
The tool should throw the error on both the LLOS and RLOS if the underline projection is the reason; however, it does not. I think we should test against a image service that is projected and see if we get the same results.  This is something that we would have to stand up because I do not know of a service that is already shared this way.
State Plane Coordinate System (SPCS) is not a projection (also known as SPC, State Plane, and State).
I might be off on this one, but I think this is why the problem is happening. The problem should be resolved with RLOS returning information about the service not being in the correct projection.

@NatalieCampos I would like you help on this.

The original bug that caused the tool to abort has been addressed in #188 ,
I tested this with a service covering a smaller area at: https://nationalsecurity.esri.com/portal/home/item.html?id=7cf1f1dd0a6f4858a6ffacd3d2f7d0d0
The larger issue of the tool taking an extremely long time to complete for a service covering a large area and/or higher resolution is still an issue (I'll open a new one once the bug part is verified). To mitigate , or at least warn the user about this, a warning was added when using an image service: "The selected input surface layer is an Image Service and make take a long time to process. Do you wish to continue?"

@csmoore would it be possible to only process the visiblity in memory at the image display resolution rather then the source resolution.  Similar to how the raster functions work.

When using an image service, the following dialog is thrown. However, there are some slight spelling errors.  @csmoore can you please fix then and reassign to me?

FYI @csmoore
https://github.com/Esri/visibility-addin-dotnet/blob/693a0f5f4aaa7bb63d8e5d2d0db659a96c571345/source/Visibility/VisibilityLibrary/Properties/Resources.resx

@NatalieCampos @ACueva - sorry about that :grimacing: - typo fixed in next build

type has been fixed.  warning is as below.
https://nationalsecurity.esri.com/portal/home/

The following caution was added to the "Using Radial Line of Sight" Xmetal topic.  Closing this issue.

The use of a global or large area extent image service will result in excessive processing  time.  It is recommended to use a local dataset or a small area extent image service.

@csmoore I get the warning for LLOS.  I am unsure whether the warning was necessary for LLOS as all the issues related to the processing time and image services were with RLOS. I tested LLOS with the test image service on the national security portal and it ran real quick.  So is this warning necessary for LLOS?

It probably isn't needed for the ArcMap LLOS (which uses a different method and seems to be faster) - it can be removed there if you like (that was the "may take a long time" part) - also hopefully it is not still misspelled

@csmoore no it isnt misspeeled anymore... sorry i used the old screen grab.  Can we remove the warning for LLOS?  I feel like if the warning is unneeded meaning that the use of an image services for LLOS isnt slow... then lets not have it. I think it could cause the user to be hesitant about  using the tool.

Doing some more testing in ArcMap with this with a larger dataset and LOS over a larger area -
http://www.arcgis.com/home/item.html?id=58a541efc59545e6b7137f961d7de883  - and I think the warning is still appropriate/advisable (it took 5 mins for me, over not a huge area) - but let me know if you still feel strongly about removing this warning.

@csmoore agreed.  Closing issue


mention Microsoft.AspNetCore.WebSockets package needed

The documentation could mention that in order to be able to call UseWebSockets, we need to install the package Microsoft.AspNetCore.WebSockets.

@pablocar80 Can you please provide a link to the doc you're referring to?

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/websockets?view=aspnetcore-2.2

@pablocar80  that's an advanced topic and we don't list every include needed. At least in Visual Studio, that's trivial to add.

@Rick-Anderson pages often include the namespace that is needed to add, and this one doesn't. It's trivial to add a reference only after you know which reference you need to add. Visual Studio 2019 won't automatically resolve the reference for UseWebSocket() in NET Standard projects.
Here is an example of a help page that includes the namespace at the top:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.http.isession?view=aspnetcore-2.2

That's an API page - a reference doc, different type of doc.
Can you PR and add that?

Can you create an issue from the doc page? That will connect the doc to the issue. Go to the bottom of the page and select the Content feedback issue.


on webhook, setting commit status is not working anymore

something got lost along the way

we need the e2e test to check it was updated too

I tried this but was not able to reproduce 🤔
worked fine for pull_request and push both

i can reproduce the issue and i think i figured out, I am getting this payload on push :
{
  "ref": "refs/heads/pac-e2e-test-qmc26",
  "before": "42d0bf6a82fdf5ce77a2ba5832a3f2f531faa964",
  "after": "0000000000000000000000000000000000000000",
  "repository": {
[..]
 "head_commit": null
}

but we try to get the SHA  head_commit so we fail from https://github.com/openshift-pipelines/pipelines-as-code/blob/main/pkg/provider/github/events.go#L173-L175
we should get it from GetBefore() as fallback

i have a fix on the way,


fix: execution_time was not getting passed in from plan

How about this spot:https://github.com/TobikoData/sqlmesh/blob/8e237207b546f30d06366495a39ffa0b5ecced36/sqlmesh/schedulers/airflow/plan.py#L133

Also I think we need to pass it here as well: https://github.com/TobikoData/sqlmesh/blob/8e237207b546f30d06366495a39ffa0b5ecced36/sqlmesh/schedulers/airflow/plan.py#L116


Check for nullptr when locking

We need to check if the mutex pointer is actually pointing to something before using it, such that calling SCOPED_MUTEX_LOCK doesn't crash.

I understand this change save the crash, but I'm not sure this is what we should do. Because this change allows us to write something like below.
Ptr<ProxyMutex> mutex = nullptr;
// long long line...
SCOPED_MUTEX_LOCK(lock, mutex, this_ethread());

If I look at the SCOPED_MUTEX_LOCK, I assume the mutex is acquired in this scope, but actually, it's not.
IMO, I think we should make sure nullptr is not given by release assert instead of nullptr check.

In that case, there are no unlocked mutexes when the continuation is called. There are cases where having no mutex is desirable, for instance all of the data is static and locking is only overhead. How should that be done?

There are cases where having no mutex is desirable

I think we should have another macro for the use cases. This is scoped mutex lock.

Cherry picked to the 9.0.x branch.


[stable/odoo] Allow to pass arbitrary envs to Odoo

What this PR does / why we need it:
This PR allows to pass arbitrary env to Odoo.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

Thank you very much for your PR, @mcanevet. I left a small comment there, otherwise it looks good to me.

Sorry for the late response, @mcanevet. Thank you for taking your time doing this.
Please, add a comment to the values.yaml as I requested on the previous response. And don't forget to sign the DCO too.
Thanks again!

Hi, @mcanevet, happy new year. I'm pinging you just in case you want to continue with this PR.

Thanks for the update, @mcanevet. The CI is failing some checks:
The Chart version needs a bump to 12.1.0
Old chart version: 12.0.5
New chart version: 11.2.0
Error linting charts: Error processing charts
------------------------------------------------------------------------------------------------------------------------
 ✖ odoo => (version: "11.2.0", path: "stable/odoo") > Chart version not ok. Needs a version bump!

Link: https://circleci.com/gh/helm/charts/117867?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
And you also have two commits incorrectly signed off, here's how you can fix it: https://github.com/helm/charts/pull/18581/checks?check_run_id=386602351

DCO is still missing, please follow the following steps to fix it: https://github.com/helm/charts/pull/18581/checks?check_run_id=386695726

Hi @mcanevet ,
You still need to sign you commit for the PR to pass the tests.


Multiple StatsRelay daemons behind LVS

Hey Jack,
Thanks for releasing statsrelay, this is a great tool! I'd like to run multiple statsrelay daemons behind a simple UDP load balancer with LVS in roundrobin mode and was wondering would the statsrelay daemons be able to share the same hash table? Would they each send the same metrics to the same backend server or would they each maintain their own hash table?
Thanks!
Dave

Dave,
That exactly my use case.  Provided that you invoke statsrelay with the same list of hash ring members in the same order on each machine you will get identical behavior from each daemon.  So no matter what daemon handles the stat it will always go back to the same StatsD.
Jack

@jjneely you might want to put a version of what you wrote above in the readme.

Thanks Jack, this is exactly what I've been searching for. I'm going to run a few tests today to see how far I can push it and will report back with some results.
This may be unrelated but If I configure statsrelay with 2 backend hosts say A and B, and A goes offline. What happens to the metrics which were meant to go to A? Are they'd queued up or would they be directed to the next backend host B?

Benchmarks / feedback would be fantastic.  I've had fairly reasonable performance with 200,000 metrics/sec at one statsrelay daemon using a load generator:
https://github.com/octo/statsd-tg
The UDP protocol that StatsD uses is specifically designed not to have any feedback.  So just using that protocol statsrelay can't tell if the statsd daemon its talking to is alive.  (Nagios steps in here for me.)  StatsD does have a TCP port for some administrative commands -- but I imagine the best use of that port is to monitor the process from remote (or in this case statsrelay).  That should be its own issue I think as that code hasn't been written yet.
In short, the current code base can't tell if the StatsD daemons are alive and will just continue to sent traffic in their direction.

Issue #2 created.

Jack - my apologies for the late reply, unfortunately I was sidetracked with work and studies just as I was really getting into testing this. Thanks for the heads up about statsd-tg, works great. I've run into a few small issues with our tests but will send feedback as soon as I can trust our test results :)

Excellent! I look forward to your feedback.

Ok so far the tests we're running are looking great. I'm running multiple statsrelay daemons behind an LVS load balancer. The statsrelay daemons are each running with the same options, eg.
statsrelay -bind=<IP_ADDRESS> -port=12001 -verbose -prefix=statsrelayX <IP_ADDRESS>:12000 <IP_ADDRESS>:12000

On the statsd servers (statsd1/<IP_ADDRESS> and statsd2/<IP_ADDRESS>) I can confirm metrics are going to both, and they are both not receiving the same metric namespaces - brilliant :)
One thing I have noticed however is that the distribution of metrics to each backend statsd server is not what I expected, most likely because I am still trying to get my head around how consistent hashing works. Would running statsrelay with the options above distribute say 50% of metrics to statsd1 and the other 50% to statsd2? From my tests I'm seeing roughly 20% of metrics hit statsd1 and the remaining 80% hit statsd2.
How would I run statsrelay to allow a 50/50 split in metrics the the backend statsd hosts?
Thanks!

By very carefully choosing the hostnames of the statsd locations is the only way to get an even balance across 2 statsd daemons.
The hash ring works by setting up a ring buffer with 64k (or some other power of 2) number of slots.  The host/port is hashed to figure out where on the ring they live.  When a metric name comes in, that name is also hashed to find where it would fall in the ring buffer.  Then the algorithm finds the closest slot with a host/port and the metric is sent to that host.
So most likely the two slots that represent the hosts in the hash ring are fairly close together which gives you an uneven distribution.  The more statsd hosts you have in the ring the more even the distribution will be.
I run several statsrelay daemons under LVS and the ring includes 18 statsd daemons.  At last check I'm doing about 500,000 statsd metrics per second with room to spare.  Although, I haven't looked closely at how even the distribution is...I normally track the CPU usage of the nodejs code.

Thanks Jack much appreciated. I managed to get an almost event balance by altering the hostnames a bit as you mentioned.
At the moment I'm running 6 statsrelay daemons across 2 servers, each doing about 45000 metrics a second (270k/sec total). I'm a bit confused about the numbers reported by the statsProcessed metric statsrelay reports - I'm seeing about figures of 2.3-2.8 million for statsProcessed. Is that total metrics processed per minute?

StatsRelay sends a counter metric into Statsd to report metrics processed.  If your Statsd flush interval is set to 60 seconds then that's probably right.  You are seeing metrics processed per minute.  This is what I do in Graphite:
alias(sum(1min.statsd.prod.statsrelay.graphite*.statsProcessed.rate), "Metrics Processed Per Second")

Ah Ok that makes sense - thanks for clearing that up :)
Here are my final test results & info.
Test environment:

Fired off some test metrics using statsd-tg (https://github.com/octo/statsd-tg) with the following options:
statsd-tg -d <IP_ADDRESS> -D 12000 -T 2 -s 0 -c 4000 -t 0 -g 400

I'm making use of 2 load balancers, a Citrix NetScaler and using LVS on RHEL 7. Metrics first hit the NetScaler which evenly distributes metrics to 2 RHEL 7 servers (server 1 & 2). The VS on the NetScaler is configured as roundrobin / sessionless / persistence:none.
The LVS configuration of server 1 & 2 is (server 1):
ipvsadm -A -u <IP_ADDRESS>:12000 -s rr -o
ipvsadm -a -u <IP_ADDRESS>:12000 -r <IP_ADDRESS>:12001 -m
ipvsadm -a -u <IP_ADDRESS>:12000 -r <IP_ADDRESS>:12002 -m
ipvsadm -a -u <IP_ADDRESS>:12000 -r <IP_ADDRESS>:12003 -m

Metrics are evenly passed to 3 statsrelay daemons using roundrobin on ports 12001/2/3 UDP.
There are 3 statsrelay daemons running with the following options (server 1):
statsrelay -bind=<IP_ADDRESS> -port=12001 -prefix="server1.statsrelay1" <IP_ADDRESS>:12000:100 <IP_ADDRESS>:12000:400
statsrelay -bind=<IP_ADDRESS> -port=12002 -prefix="server1.statsrelay2" <IP_ADDRESS>:12000:100 <IP_ADDRESS>:12000:400
statsrelay -bind=<IP_ADDRESS> -port=12003 -prefix="server1.statsrelay3" <IP_ADDRESS>:12000:100 <IP_ADDRESS>:12000:400

I tested a few different instance values with specifying the statsd hosts and eventually settled on :100 and :400. This seemed to give me the closest to a 50/50 distribution of metrics, more 40/60 but that's good enough for me.
For the statsd servers (server 3 & 4) I'm running statsdnet (https://github.com/lukevenediger/statsd.net).
The statsrelay servers (server 2 & 3) are VM's running RHEL 7 with 4Gb memory and 4 CPU's. The statsd servers (server 3 & 4) are running Win Server 2012 R2 Std with 4Gb memory and 2 CPU's.
Combined metrics processed p/sec by both server 2 & 3 (all statsrelay daemons): 270k/s (135k/s each)
Avg metrics processed p/sec by each statsrelay daemon: 45k/s
Load Avg for statsrelay servers: 2-2.5 (memory usage is so low it's not worth mentioning)
I'm also using CollectD to report some basic UDP stats for LVS on the statsrelay servers (the ipvs module is awesome btw) and can see an average of about 3000 UDP InDatagrams/sec and 200 UDP InErrors/sec reported. Am still investigating the cause of this and not sure yet if this is something I should be really worried about.
All in all statsrelay is doing a great job, thanks again Jack :)

One thing I forgot to mention is that while there is no built in fault tolerance with statsrelay I put together a basic bash script which I run every 10 minutes to check if the statsd hosts are up. If one of them is down and stops responding then it kills all statsrelay processes and fires them up again leaving out the failed statsd host so that it does not attempt to send metrics to it. So far this works but definitely an area which could be improved in many ways.

Out of curiosity, whats the advantage of running multiple stats-relay boxes on a single server ?

I do have up to 300k metrics/sec on single statsrelay with my load tests inside AWS. Statsite can handle ~700k metrics per second.
We are starting to use it with kubernetes after some improvements and architecture looks like this:

And can some older overview based on EC2 instances:

I should use some of these awesome diagrams for the actual documentation!  Thanks!
300k/s matches my own benchmarks.  I've run it hotter, but the UDP drop starts to become unmanageable, and that's what I'd like to avoid.  I have pondered a re-write in C which could handle more throughput (similar to statsite), but not quite gotten around to my next set of Statsd scaling.

it was a year ago when i evaluate idea of relaying statsd to central place and take down CPU usage from EC2 instances, improve percentile/histogram calculation and simpler maintenance.
I think 200k-300k is high enough, because in most statsrelay will exist on single instance/k8s Pod with single app and i think 99% of cases will generate in most ten of thousand's metrics per second and there statsrelay is perfect. Multiple statsrelays and only couple statsites/telegraf's at the end.
Main feature we need now is buffering on memory or/and disk with backfill when remote recover. It is discussed here https://github.com/jjneely/statsrelay/issues/2.
I think maybe soon when i get some spare time i will try to make new series of tests.


Feature Request: Eufy doorbell button service

Hey,
It would be nice to have (I'm not sure if it's possible) a service to trigger a doorbell press event on the device itself.
Scenario:
A generic button is connected to HA.
On a button press it will trigger the doorbell service,
and the outcome should be as I pressed the original doorbell button.
Currently I can change the state of the 'doorbell_ringing_sensor' to True, and trigger the doorbell event automations,
but I would like to also receive a notification in the eufy app and to get the homebase ring.
I'm not sure it's possible.. And if not, maybe at least adding a service for the homebase ring is possible?
Thanks

First is definitely not possible :-)
Second, do you have a feature in homebase ring? i didn't know that, as i own 2c cameras, no doorbell

yes, the homebase can act like a Chime

A dorbell press can even trigger the my Echo dot (and echo show with a video)

Homebase can act like a chime, but there is no action (button) to initiate a chime.
i checked the middleware if this is supported and there is nothing about it here: https://github.com/bropat/eufy-security-ws
Please open a new issue there if this is doable

Thanks!


add CommandV3

fix this issues: https://github.com/go-chat-bot/bot/issues/46

my plugin file: https://github.com/pyinx/plugins/blob/master/cmd/cmd.go
Screenshot

@pyinx thanks for the PR! Can you please add a unit test which test this new command?


Automated Package Upgrade

:tada: This PR is included in version 2.2.102 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Max context length exceeded in __rpc_call(method="generate_questions")

{'error': {'code': -32603, 'message': 'BadRequestError(\'Error code: 400 - {\\\'error\\\': {\\\'message\\\': "This model\\\'s maximum context length is 16385 tokens. However, you requested 16583 tokens (16083 in the messages, 500 in the completion). Please reduce the length of the messages or completion.", \\\'type\\\': \\\'invalid_request_error\\\', \\\'param\\\': \\\'messages\\\', \\\'code\\\': \\\'context_length_exceeded\\\'}}\')'}, 'jsonrpc': '2.0'}

So this happens if you have training data chunks that are too large and consume the entire context window.
Try to do vn.get_training_data() and then sort by the string length of the content.
You may need some alternate strategies to break up the training data into smaller chunks.
If you'd prefer not to do that, another alternative is to use your own OpenAI API Key and send it to the new GPT-4-Turbo with 128k context, which should be able to accept these larger chunks.
https://vanna.ai/docs/snowflake-openai-standard-vannadb.html


Loading/Pushing a frontViewController during app startup issues - race with Storyboard?

Hi
I have an app which uses storyboards, from which the SWRevelViewController is setup with a side menu, so this loads automatically upon launch.
By default CategoriesViewController loads as the front ViewController.
I'm then trying to handle push notifications, using the code below within appdelegate. This should load a new VC (EventViewController) into the navigation stack so it shows.
`
/* Using storyboards, so get main storyboard and reference VC from there */
 UIStoryboard *mainStoryboard = [UIStoryboard storyboardWithName:@"Main" bundle: nil];

    EventViewController *vc = (EventViewController*)[mainStoryboard instantiateViewControllerWithIdentifier:@"EventVC"];
    CategoriesViewController *catsVC = [mainStoryboard instantiateViewControllerWithIdentifier:@"CatsVC"];

    vc.ilid = ilid;

    SWRevealViewController *controller = (SWRevealViewController*)self.window.rootViewController;

    UINavigationController *navController = [[UINavigationController alloc] initWithRootViewController:catsVC];
    [navController setViewControllers:@[catsVC,vc] animated:NO];

    [controller pushFrontViewController:navController animated:NO];

`
The idea here is that our main (catsVC) controller is loaded, then the eventsViewController (vc) is loaded, so we can navigate back correctly if we wish.
This works great if the above code is triggered while the app is in the foreground or background.
However, if we run the above code within application didFinishLaunchingWithOptions  (ie responding to a push notification when the app is not running anywhere), the EventViewController never shows.
There are no errors so I am wondering if there is a race condition between the above code, and the storyboard, so the above loads first, then the storyboard is loading the CategoriesViewController so we can't see what's happening?
Any tips on getting the above code working for all scenarios (foreground, background and not running)
Many thanks

I have confirmed this is a race condition, because if I add a delay around the pushFrontViewController code as follows:
`      int64_t delayInSeconds = 3.0;
dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, delayInSeconds * NSEC_PER_SEC);
dispatch_after(popTime, dispatch_get_main_queue(), ^(void){
NSLog(@"Loading vc now ");
[controller pushFrontViewController:navController animated:NO];
});
        }

`
This works fine. So, how can I make this work without the forced delay?

Hi, i used you code in this way
`UIStoryboard *main = [UIStoryboard storyboardWithName:@"Main" bundle: nil];
MyViewController *viewController = (MyViewController *)[main instantiateViewControllerWithIdentifier:@"ComentariosViewController"];
SWRevealViewController *controller = (SWRevealViewController *)self.window.rootViewController;
UINavigationController *navController = [[UINavigationController alloc] initWithRootViewController:viewController];
[navController setViewControllers:@[viewController] animated:YES];
[controller pushFrontViewController:navController animated:YES];`
And it works for me, but i can not go back. Do you know how to do? How call popViewController?

There is only one controller in the navigation controller's stack! Why do you want to pop?

i'll try to explain: when i receive a push notification, i want to open (push in root navigation controller) a particular view controller, then, i want to go back to de previous opened view controller.

When you receive a notification, you push a controller with SW. Do the same when you want to open again the previous one:
In your controller, when you finish the job:
[self.revealViewController pushFrontViewController: previousController animated:YES];

but the thing is the view controller i open with the notification is not a reveal view controller
This is my main view controller (a reveal view controller type)

This is the second view controller, the one i open with the notification, is not a reveal view controller. (just a normal view controller)

When i open the 2nd view controller with the notification, i can not go back to the first view controller. That is my problem.

Yes you push the second view controller with SW then this second view controller has a property revealViewController. When you want to open the main view controller, just do:
[self.revealViewController pushFrontViewController: mainController animated:YES];

Ok, i'm not sure if that is the behavior i want. Is not logic with the behavior of my app. I need something like popViewController to return to the previous view controller opened by the user. I understand with the method you describe me, mainController it has to be a fixed view controller defined by me. That is what i do not want.
But, trying something like passing in mainController the topViewController like this
- (UIViewController *) topMostController {
    UIViewController *topController = [UIApplication sharedApplication].keyWindow.rootViewController;
    while (topController.presentedViewController) {
        topController = topController.presentedViewController;
    }
    return topController;
}

Then calling it by your method
[self.revealViewController pushFrontViewController:topController animated:YES];
Im getting an uncaught exception.
Uncaught exception: adding a root view controller <SWRevealViewController: 0x14d022a00> as a child of view controller:<SWRevealViewController: 0x14d022a00>
Sorry for my english, i hope you understand!

What is the class of topController? Use NSLog

Yes, i don't know why but the class is always (and is the reason why the error) SWRevealViewController

Yes, that is what i want. But i am coming to realize that is not possible without some "workaround", right?

like i said, i "worked around". Instead of open the 2nd view controller by the push, i open the 1st, and do a segue to the 2nd by passing all i need. In this way i can go back normaly with the backbuttonitem. Thanks for the help!

Is not the best solución bit is close enough

Si, I think it's a good solution. I not understood the question very well at the beginning. I thought when you received a notification you wanted to display a front view controller and then you wanted to display the front view controller on which was the user before. It is not a worked around. Well done!

You could just add a test to know if the user is already in this first view controller and if it is the case just push the second view controller with self.navigationController

yes but i don't know how since i always get SWRevealViewController as a class of all view controllers... plus i don't know how to identifier every view controller because all identifiers appears null.

You can use this (see the tutorial : https://www.raywenderlich.com/117471/state-restoration-tutorial) or you can check the class of revealViewController.frontViewController.topViewController (with cast)

how do implement the 2nd option in appDelegate?
Because i tried:
SWRevealViewController *controller = (SWRevealViewController *)self.window.rootViewController;
Then try
controller.frontViewController.topViewController
But topViewController does not exists in frontViewController

SWRevealViewController *revealController = (SWRevealViewController *)self.window.rootViewController;
UINavigationController *nc = (UINavigationController *) revealController.frontViewController;
UIViewController *topController = nc.topViewController;
if ([topController isKindOfClass: [YourClass class]])
....
I am withy computer but it is something like this!

Yes, that is right and helpfull! thanks very much!

@quetool  HI I am also facing same issue.I see above all messages all but I unable to achieve that. same scenario what you have faced.Finally what you did please help me

@bintu1234 what is your problem exactly?

@quetool  Thanks for the replay.I am using SWRevealViewController every thing is working fine.Now when i tap on Local notification i want to redirect to specific page. When i use below code in didReceiveLocalNotification it is working but there is no back button.
UIStoryboard *main = [UIStoryboard storyboardWithName:@"Main" bundle: nil];         ASNMessageChat *viewController = (ASNMessageChat *)[main instantiateViewControllerWithIdentifier:@"ChatView"];         SWRevealViewController *controller = (SWRevealViewController *)self.window.rootViewController;         UINavigationController *navController1 = [[UINavigationController alloc] initWithRootViewController:viewController];         [navController1 setViewControllers:@[viewController] animated:YES];        [controller pushFrontViewController: navController1 animated:YES];
And one more thing is My destination is ASNMessageChat But it is not the Rear or Front for SWRevealViewController How to achieve this.

What i did was a "workaround".
With the notification I open my main view controller (just like you do) at the same time i set a BOOL property of that view controller to YES.
If this property is setted to YES (because im coming from the notification), what i do is a segue to the view controller i wanted in the first place.
Now, this is not the behavior i was searching, but for the moment it works for me. I have planned to find a better solution in the future.

Ok.If you find better solution Please try to notify me.Thank you


Addition of Sub-navigation & Breadcrumbs

Please NOTE - This pull request builds upon https://github.com/m-lab/m-lab.github.io/pull/14 and should be merged in after that PR.
It includes the addition of the sub-navigation & breadcrumbs to the site's conversion.  A preview of this functionality can be seen on my [staging site] (http://andrew-m-lab.github.io/)  Below are additional notes for the items completed with this pull request:

[x] Addition of sub-navigation for the about and visualizations sub-pages.  In order to edit or add new sub-navigations, one can simply edit hierarchy in the _data/header-footer-content.yml file.  If adding a new sub-navigation for an existing landing page the sub-navigation's title will need to equate to the key on an individual landing page's breadcrumb front-matter value.
[x] Addition of breadcrumbs for all landing and sub-pages.

This does NOT include the breadcrumbs for the observatory page.  This will be added once https://github.com/m-lab/m-lab.github.io/pull/15 is merged as there is a dependency there.
This does NOT include the breadcrumbs for the blog pages.  This will be added once the blog layout and pages are completed.

[x] Also, minor fix for several page <title> tags so that they match what is on the current site.

LGTM @shredtechular


Link option

@KulikovNikita, this PR changes 58 files and named "Link options", what's happening here?

@KulikovNikita  - i assume this is not needed and we can close this PR?


host_details: fix 500 instead of 404 when no matching host

The issue was: we should have used get_object_or_404 instead of
Host.objects.get because the latter throws error 500 when specific
host cannot be found.
Additionally changed one test's name so that it's discovered by the test
runner.

:+1: to merge, but how did we wind up in this situation?  Aren't hosts chosen from a drop-down (which should be guaranteed to be in the DB)?

@gvwilson probably someone accessed some old link or something.

Hm - can you please have a look at the server logs and see who was on the system and what they might have tried? I doubt anyone would have bookmarked a particular organization's link, and typing in the name manually seems unlikely too.


Caching build artifacts?

I'm using the build pack to compile a binary API that has over 40 go dependencies, each push seems to do got get every dependency on every build. Is caching of $GOPATH between builds an option? Is there something I need to configure?

What dep tool are you using?

If you open a support ticket, include the app name, and grant access to the app I can get a bunch more info w/o having to ask you here.

Hi @freeformz, we are using the buildpack in combination with Go modules as well, but caching doesn't seem to work. We are using Go version 1.11.5.

@edwardmp Can you open a support ticket, detail what isn't happening, provide access to the application, and ask them to assign the ticket to me?
I can use the build logs and some internal tools to look at the BUILD cache (which should contain Go's cache) to see what is going on.
Thanks!


It would be nice to be able to define charsets for columns like this:

It would be nice to be able to define charsets for columns like this:

#[Entity]
class User
{
    #[Column(type: 'primary')]
    private int $id;

    #[Column(type: 'string', name: 'username', charset: 'latin1', collation: 'latin1_bin')]
    private string $email;
}

Originally posted by @ardabeyazoglu in https://github.com/cycle/orm/discussions/370

There can be columns with different charsets for both performance reasons and limitations. For example you cant index 255 char utf8mb4 column, but you could do it with latin1. Email is a good example

I think it possible using custom typecast handler. It won't work with migration generator but in PHP you will always work with UTF-8

Php is not problem here anyway. But people who create schemas and migrations using the orm, might need it to prevent manual tricks.

The actual implementation of annotation is here: https://github.com/cycle/annotated/blob/3.x/src/Annotation/Column.php
Should I create another issue there as well or you manage anything related from here ?


Update DG SCXML lib to be callable from Scala.

@Brijeshrpatel9 has proven this out.

@Brijeshrpatel9 can you send a pull request with the needed serializable changes ?

The library is now callable from Scala. It does not (yet) work through Spark.


cargo publish --dry-run doesn't fail on invalid keywords

Problem
First of all, thanks for maintaining cargo! I'm a very happy user.
I've noticed a case where cargo publish --dry-run completes successfully, but cargo publish will fail (for crates.io, and likely for other indices running the same stack).
In particular: if the keywords field contains an entry longer than 20 characters, crates.io will reject it. However, --dry-run reports no issue with such a keyword.
For example, the following keywords set will cause a publish failure:
keywords = ["til", "today-i-learned", "static-site-generator"]

...because the last member (static-site-generator) is 21 characters long.
The error message returned by crates.io suggests that a 20 character long keyword would also fail:
error: failed to publish to registry at https://crates.io/

Caused by:
  the remote server responded with an error (status 400 Bad Request): "static-site-generator" is an invalid keyword (keywords must have less than 20 characters)

Steps

Create a new crate and fill in the metadata
Add a keywords member that's longer than 20 chars
Run cargo publish --dry-run and observe that it succeeds
Run cargo publish and observe that it fails

Possible Solution(s)
Two possible solutions come to mind:

More invasive: change cargo publish --dry-run's behavior so that these overlength keywords cause a failure with an appropriate error message. This would potentially cause overly eager error messages against other indices (i.e. other than crates.io), if those indices support longer keywords.

This could be made less intrusive by checking whether the index being published/dry-run against is a third-party one.

Less invasive: emit a warning instead of a non-fatal error when the keyword is too long for crates.io. This will prevent unexpected breakage against other indices, while still providing more of a heads up to users.

There are probably other solutions, however!
Notes
No other notes.
Version
cargo 1.79.0 (ffa9cf99a 2024-06-03)
release: 1.79.0
commit-hash: ffa9cf99a594e59032757403d4c780b46dc2c43a
commit-date: 2024-06-03
host: x86_64-unknown-linux-gnu
libgit2: 1.7.2 (sys:0.18.3 vendored)
libcurl: 8.6.0-DEV (sys:0.4.72+curl-8.6.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Ubuntu 22.4.0 (jammy) [64-bit]

Thank you for the report! This seems to be a duplicate of #2098, #3662, #4300, #4377, #14249, so closing in favor of those.

Note that the limitations are set by a single registry (crates.io), while Cargo needs to support different registries.

Note that the limitations are set by a single registry (crates.io), while Cargo needs to support different registries.

Yep, that makes sense -- I think the idea marked (2) above would address that case, or (1) provided that --dry-run can be made aware of the registry URL (which I think it should be, since it's part of the same publish subcommand).
(And thank you for triaging! Based on the set that's closed/still open, it seems like https://github.com/rust-lang/cargo/issues/4377 is the most immediately relevant to this piece of metadata.)


About SCFAs.

Hi @mortonjt
What format should I enter if I want to analyze SCFAs data in qiime?  I tried to convert the form to biom and then to qza and encountered the following error

Hi, this looks like a biom format error. It may help to produce a minimal
example and reproduce the error that to_dataframe throws (and post on the
biom_format issue tracker)
On Thu, Dec 28, 2023 at 10:00 PM orange-3711 @.***>
wrote:

Hi @mortonjt https://github.com/mortonjt
What format should I enter if I want to analyze SCFAs data in qiime? I
tried to convert the form to biom and then to qza and encountered the
following error
image.png (view on web)
https://github.com/biocore/songbird/assets/117793353/d8377ec1-866d-4945-8af1-b39dc2f42856 image.png
(view on web)
https://github.com/biocore/songbird/assets/117793353/d5b82400-8bd5-4adb-9604-515138343a4e
—
Reply to this email directly, view it on GitHub
https://github.com/biocore/songbird/issues/170, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA75VXPZIYXGWOZI36AIGADYLYW27AVCNFSM6AAAAABBGEONYKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TSMBRG43TCNY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Can you fix this server's protocol?

Ogar-master.zip
I love this split behavior.
But it doesn't work my client,
So i request you.
please fix only once.

Protocol is already works as expected.

@Barbosik It's not MultiOgar.
Your MultiOgar Server fixed all protocol, so it works my client perfectly.
But This Ogar fixed some protocol.
So it doesn't work my client.
i don't want to fix for official agar client,
i want to fix protocol 5.
but i don't know how to fix protocol.
so i request you.

You need to fix your client to support standard protocol


Externalize samples testing infrastructure

This change replaces UserGuideSamplesRunner with an external library
called sample-check. Sample discovery, execution, and normalization
is delegated to this library, with some custom normalizers remaining
in the Gradle codebase.
Samples output has become co-located with the sample code. Samples tests
must be run with Java 8+.
Summary of changes:

Moved samples output alongside sample projects
Removed UserGuideSamplesRunner
Creating new OutputNormalizers
Use GradleSamplesRunner and new normalizers for UserGuideSamplesIntegrationTest

You will also be interested in https://github.com/gradle/exemplar/, which is to be shared publicly after some polishing.
Context
Once this is complete, we can convert docbook passthrough <sample>s to asciidoc syntax, which will allow the user manual to support switchable Groovy/Kotlin snippets, as well as be much faster and eliminate a bunch of custom stuff we're doing for docs processing/testing.
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

This is great, looking forward to using this for the native samples.


Update ThreatModel to include Rollback Attack

The current threat model does not account for rollback attack, please include it.
Additionally it would be great if you can make sure that all threats mentioned in the tuf-spec are also incorporated into the Notary Project's threat model

Added rollback attack as part of https://github.com/notaryproject/specifications/pull/285


fixed  href in post_author template

Link to author profile wasn't working (refer to meta.telescopeapp.org to see broken link). Just corrected it to match with the post_avatars template, which was working.
P.S. If anyone can explain what was going on I'd like it because I still don't really understand

Thanks, I'll merge it in manually :)


Create a navigation on the mainPage

Bootstrap5 should be used for consistency across design

Hey, I've created this nav in my fork, I think that it still needs some work and review (padding, and the menu options, particularly I think that the help section could be a dropdown to communication links as right now it just goes to the comms wiki).
I'll address content and footer in their respective issues

@lilyx13,
Sure. Please open up a pull request and tag it with a [WIP] to state that it is a work-in-progress so that we can review and work on it simultaneously.


Update flyway-core to 7.8.1

Updates org.flywaydb:flyway-core from 6.5.7 to 7.8.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: library-update, semver-major

CI fails. A simple bump is not enough.


Handle failures - Raise failure events (failures in channel selection…

… and customer profiler)
Service tests

This PR was successfully deployed to production by CircleCI build 16 at 2016-12-15 14:48 GMT.


Switch host to static C++ runtime library

Interesting. We do have /MTd (not /MDd which would be multithreaded DLL...)

I bet it is some third party libraries that want CRT as DLL.

https://github.com/Microsoft/RTVS/commit/47a5094efbcf5ae54100e2f719fb938fd0c7afbd


Updating the TypeScript compiler

This should provide better error messages

Coverage remained the same at 100.0% when pulling dd9de0b2645aa36f9d0b6a9e79000f6d79701297 on better-errors into 11b2d3795c7352b362e56bbad903e3510ea3f7ef on master.


Update unary backward docs

Ticket
Link to Github Issue #14983
Problem description
Update docs for unary backward ops
What's changed
Updated docs for the binary backward ops :
Checklist

[x] All Post commit CI

can you update the commits with issue number ?


sections-schema is not reactive

Reproduction
https://formkit.link/03343c84732d1e7e4e1d0e2844c4f112
Describe the bug
The sections-schema parameter does not support dynamic change
Environment
• OS: mac
• Browser  103.0.5060.134 (arm64)
• Version latest

The schemas themselves are reactive, but changing the schema is not. This would require re-parsing and re-compiling the schema, which we don't want to do. However you can use conditions in your schema to achieve the same results.


Fix preview subcommand when package has dashes on its name

Hey there, when trying to run wrangler preview on version  0.1.0 installed with cargo
1.35.0-nightly (0e35bd8af 2019-03-13) it will break with the following
error:
wrangler preview
🌀 Compiling your project to WebAssembly...
[INFO]: 🎯  Checking for the Wasm target...
[INFO]: 🌀  Compiling to Wasm...
warning: unused manifest key: package.author
    Finished release [optimized] target(s) in 0.10s
[INFO]: ⬇  Installing wasm-bindgen...
[INFO]: Optional fields missing from Cargo.toml: 'description', 'repository', and 'license'. These are not necessary, but recommended
[INFO]: ✨   Done in 0.25s
[INFO]: 📦   Your wasm pkg is ready to publish at ./pkg.
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }

because the package name generated by wrangler generate is called wasm-worker and on pkg folder only wasm_worker.js can be found.
To better show the user what failed I also put a context to show what happened.
The fix probably is not ideal, let me know if I can make it better.

hey @jaysonsantos ! this is great- and fixes #36 ! if you have a second i believe this is failing on cargo fmt- you can run and commit --amend, or i can take it over for you if you'd like. thanks so much for this contribution. i'm happy to cut a point release to get this fix in :)

Hi, my bad, I just did an amend to the last commit.

no worries @jaysonsantos ! i hadn't documented that we were enforcing cargo fmt on CI~ i'll make sure to do that. thank you so much for contributing!!

What do you think about having something like pre-commit?


Jenkins slave is not managed by ansible

More Jenkins slaves will be needed in the future (see #32). To ease the expansion, ansible-role-jenkins-slave should be created.

@mitsururike is the issue resolved?

yes, we have https://github.com/reallyenglish/ansible-role-jenkins-slave.


Runtime error on Retrieve Predictions (Timeout)

Describe the bug
After connecting local storage and performing sync or connecting ml-backend and performing Retrieve Predictions, a timeout occurs.
To Reproduce
Steps to reproduce the behavior:

go cloud Storage
add local storage
press button sync storage
In progress -> The problem occurs after about 90 seconds(Runtime Error - Gateway TimeOut)
-> Still working on the backend.

after connecting ML-backend
In project, Press buttton "Retrieve Predictions".
The frontend gets blocked while ml-backend is running. The problem occurs after about 90 seconds(Runtime Error - Gateway TimeOut).
Still working on the ml-backend.

Screenshots
Environment (please complete the following information):

OS: windows10
Label Studio Version: 1.13.0

Additional context
I tried modifying the config values of nginx(proxy setting), but it didn't work.
I think a timeout occurred on the frontend.
Please help me.

Please check this:
https://labelstud.io/guide/troubleshooting#Label-Studio-default-timeout-settings-for-ML-server-requests

@makseq
Yes. I checked that page.
I changed ML_TIMEOUT_PREDICT from 100 to 1000. But It doesn't worked.
And the change in ML_TIMEOUT_PREDICT value in ML_server that you mentioned seems to be unrelated to the timeout that occurs when syncing storage.
In my case, the same timeout occurs when exporting a task.
I set the harakiri value(at uwsgi.ini) to 0, but it still doesn't occur timeout.


Derive attestation key and use it to attest to generated witness ID

This PR adds applet support for deriving a stable ID attestation key, and using it to create a simple attestation for witness IDs.
Needs transparency-dev/armored-witness-os#207
Example attestation:
ArmoredWitness ID attestation v1
90CC4E61D7A1162E
0
DEV:ArmoredWitness-withered-bush+3cc2d876+AcZNklun5fEn9VcsYgCDefdb4pDBd35qY70RfLGmsr2D

— DEV:AW-ID-Attestation-90CC4E61D7A1162E TLWjNc98n9Vk+I9mlfUDgfSBpjkgEb/44yOKOvQFjzNk3en1xXRLrQp7iKivpI5eqdBwNhXlrKDAY6HEFlr2jE0a6gM=

Happy with the key name, or should it just be AW-<serial> or similar?

Happy with the key name, or should it just be AW-<serial> or similar?

Key name is fine with me. I don't think we need to be terse.


Discordant ZVM versions

With the latest version the version shown with zvm -v is v0.1.7, whereas in the cli help and in the user agent of the download request in the Install function the version is v0.1.6.

Oops, that is certainly a mistake on my end. We'll update with the next version. Try reinstalling the compiled 0.1.7 release. I believe I updated the binaries without a fix late last night?

@antlanc7 This issue was just addressed in v0.2.0 https://github.com/tristanisham/zvm/releases/tag/v0.2.0


Re-render of Panorama results in blank screen

Hi,
I've found an issue with Panorama when I tried to update lat/lon after user click.
I wanted to center place where user clicked.
If you change lat/long (stored in widget state) nothing happens (Panorama is not updated) so I added key to the widget.
If you add key to the widget and change it to force re-render when new lat/lon is set, blank/white screen is rendered instead of texture (but panorama works, onTap functions are called properly and you can 'rotate' view).
Strange thing is that's an issue only for small images.
When you get blank screen and then replace image then everything works again.
It looks like some kind of race condition because eg small images load faster.
I prepared demo which shows the problem (I use aves fork because it has fixed lat/lon initialization but the problem is visible also with panorama_viewer https://github.com/zesage/panorama/compare/master...deckerst:aves_panorama:aves )
Link to example which shows the problem: https://github.com/dstudzinski/flutter_empty_project/blob/panorama_white_screen/lib/main.dart

When you start app with all checkboxes unselected nothing happens when you click somewhere on panorama,
when you select first checkbox to generate new key, panorama is moved to center place which was clicked,
when you select second checkbox to use small image and click somewhere you will get blank screen,
when you select third checkbox and click somewhere (you can click on blank screen as Panorama works anyway) panorama image will be rotated/moved after click but dummy image blinks for brief moment.

Small image is a rescaled version of big image (only resolution was changed in Preview app for Mac).
I started to learn Dart and Flutter recently so I don't know how to fix it yet but I'm willing to help with it.

Hey. The same problem with panorama zooming. I have added a mouse scroll listener and when I change the scale of the widget it displays a blank screen.
@dstudzinski Haven't found any solution?


DrugType issues

There are two issues:

DrugType has to be capitalized before storing into phenopacket/sending off to validation. E.g. PRESCRIPTION instead of Prescription.
Clearing DrugType must remove the drugType field from the enclosing phenopacket element

Fixed, drug type is gone from the json.


0.25 release not giving accurate responses/garbled.

Issues
After going through the conversation interface and playing with different sayings/settings I'm concluding that with the implementation of the premade categories, that this release does not output accurate responses. Even after enabling training examples in settings, changing a response to something basic, it is not hitting the correct response.
Here is an example

Though it may give the response it will combine small talk with order categories, and skips slots.
It was never doing this or showed this much inaccuracy on the other releases, and I followed just as my script says until I was trying different ways to get better responses.
Source for response 1:
[
  {
    "docId": "J4IN9msBO0wEFMRBIjJ1",
    "category": "default",
    "project": "pizzabot break",
    "model": "default_63d7b018-fc9b-8403-3a0f-b7d2b3f1184d",
    "keywords": [
      {
        "start": 0,
        "end": 13,
        "value": {
          "value": "green peppers"
        },
        "confidence": 0.9282175311184978,
        "extractor": "ner_crf",
        "keyword": "toppings"
      },
      {
        "start": 18,
        "end": 30,
        "value": {
          "value": "black olives"
        },
        "confidence": 0.9571153609361837,
        "extractor": "ner_crf",
        "keyword": "toppings"
      }
    ],
    "action": {
      "name": "get order",
      "confidence": 0.9417749643325806
    },
    "action_ranking": [
      {
        "name": "get order",
        "confidence": 0.9417749643325806
      },
      {
        "name": "Marriage Proposal",
        "confidence": 0.1569221019744873
      },
      {
        "name": "By my Friend",
        "confidence": 0.07690344750881195
      },
      {
        "name": "Busy",
        "confidence": 0.07660019397735596
      },
      {
        "name": "Who Am I",
        "confidence": 0.06425304710865021
      },
      {
        "name": "You Suck",
        "confidence": 0.05246582254767418
      },
      {
        "name": "Capabilities",
        "confidence": 0.038409192115068436
      },
      {
        "name": "You're Welcome",
        "confidence": 0.023119542747735977
      },
      {
        "name": "order status",
        "confidence": 0
      },
      {
        "name": "Agree",
        "confidence": 0
      }
    ],
    "elapsed_time_ms": 45,
    "categoryScore": 0.964789628982544
  },
  {
    "docId": "J4IN9msBO0wEFMRBIjJ1",
    "category": "pizzabot break_modifiers",
    "project": "pizzabot break",
    "model": "pizzabot break_modifiers",
    "keywords": [],
    "action": {
      "name": "",
      "confidence": 0
    },
    "action_ranking": [],
    "elapsed_time_ms": 50,
    "categoryScore": 0
  }
]

Source after saying "I would like a pizza".

Did you download a release or pull from Master? Which release?
release 0.25
What operating system are you running?
10 Pro
Are you running locally or in the cloud?
local
Which browser are you using?
FF

Can you tell us where in the picture it goes wrong? I can't tell what isn't correct. What your script says should happen vs what is happening?

So when I Said, green peppers and black olives, it wouldn't say "I have a green peppers, black olive pizza" it would just say the fallback. I had to redo the training several times, and change the response. I checked handlebars etc so it wasn't the response being wrong it just would shoot out inaccurate responses. It seems it was always throwing out "small talk" responses more than anything whenever I asked something. This behavior wasn't happening on any other releases really..

Fixed in later versions.


Fixes uvcdat logging issue, fixes uglify issue, fixes regenerator iss…

…ue. Removes console.log statement

Coverage remained the same at 60.471% when pulling 43e9ba75f673092126bedee55a33f0045736b5d4 on James-Crean:fix_install_issues into 6ea15277ee670669aed1387ec63b2847822812c0 on UV-CDAT:master.


creator_id not found in projectdata model

Creator ID was added in API release 2.10, are we able to have a release to cater for this?

Also happy to wait for the release next week first

Yup. Coming in next release.
https://github.com/umccr-illumina/libica/blob/ec9e5ce82e3eef66910eaf407604706b64354677/libica/openapi/v2/model/data_details.py#L144

Fixed by #84


substitute: init at 0

Similar to the colocated substituteAll script and derivation, this
PR adds nix-level support for substitute directly.  This is useful,
for instance, to be able to easily make tweaks to patch files for an
existing derivation's existing patch files.
Motivation for this change
Couldn't easily tweak an existing patchfile in an existing derivation.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @worldofpeace

Any thoughts on this?

@matthewbauer Any chance you can take a quick look at this?

or maybe @FRidh even?  :)

Anyone can take a look and/or merge this?

Hi @virusdave, sorry for the delay. I can try to take a look at this later today.
Can you give me a code example of how I could use this, or where this could be useful as a builder funciton?

We'd also need to document the builder function along with what's in setup.sh, this is a problem we already have for subsituteAll  #65252, it draws a lot of confusion.

I am going to go ahead and merge this as is since it is something I had wished existed a few times already. The point about documentation is fair, but since the author hasn't addressed the concerns in over 2 years I don't think that is going to happen. We can address documentation for this and substituteAll at a later date.


Windows CPAL Panic

Describe the bug
When attempting to play a song, a the song does not play and nothing seems to happen. Running the gui from the console, one can see a panic message as soon as the playback is requested.
Panic
thread 'cpal_wasapi_out' panicked at 'index out of bounds: the len is 1 but the index is 1', psst-core\src\audio\source.rs:70:13
stack backtrace:
   0:     0x7ff67c6ee27f - <unknown>
   1:     0x7ff67c70745a - <unknown>
   2:     0x7ff67c6e6398 - <unknown>
   3:     0x7ff67c6f0b56 - <unknown>
   4:     0x7ff67c6f0535 - <unknown>
   5:     0x7ff67c6f11b5 - <unknown>
   6:     0x7ff67c6f0d9b - <unknown>
   7:     0x7ff67c6eeba7 - <unknown>
   8:     0x7ff67c6f0cf9 - <unknown>
   9:     0x7ff67c731810 - <unknown>
  10:     0x7ff67c7317d7 - <unknown>
  11:     0x7ff67c4a11dd - <unknown>
  12:     0x7ff67c4535f0 - <unknown>
  13:     0x7ff67c5e4405 - <unknown>
  14:     0x7ff67c460adb - <unknown>
  15:     0x7ff67c49ae36 - <unknown>
  16:     0x7ff67c6f4cbc - <unknown>
  17:     0x7ffcb46e7034 - BaseThreadInitThunk
  18:     0x7ffcb4ca2651 - RtlUserThreadStart

Environment

OS:

Edition:	Windows 10 Enterprise
Version:	21H2
OS build:	19044.1503
Experience:	Windows Feature Experience Pack 120.2212.3030.0

Version: https://nightly.link/jpochyla/psst/actions/runs/1748008154/Psst.exe.zip

Hi, your audio output has only one channel (mono), and Psst is doing only very rudimentary channel mapping. Either way, I doubt you actually want to listen to music on mono. Is your setup indeed limited in this way, or is the output selection logic wrong?

My audio output is not mono. The output logic most probably is selecting the wrong output format.


[fix] loading after completed lazy loading and restored visit

Description
There is a problem with loading after lazy loading is completed and then visit restored. The frames that have completed lazy loading do not execute their loading processes. This problem occurs during visit restoration because the status information indicating that lazy loading has already been completed is not being fully restored. To reproduce this successfully, we need to set #hasBeenLoaded to true when connecting to the frame.
// src/core/frames/frame_controller.js

connect() {
  if (!this.#connected) {
    this.#connected = true
    if (this.loadingStyle == FrameLoadingStyle.lazy) {
      if (this.complete) {
        this.#hasBeenLoaded = true
      } else {
        this.appearanceObserver.start()
      }

Before this PR

After this PR

Relations
Closes https://github.com/hotwired/turbo/issues/886

@seanpdoyle could you review this PR?

This is PR is fixing a few pretty grim issues for us as well.
I tested the code locally and all seems sorted.
We spoke about it on https://github.com/avo-hq/avo/issues/2607.
@jorgemanrubia would you be able to have a quick look over this?
We can chip in and further test/troubleshoot/write some code.
Thank you!


My capstone project

I personalize the content of this page with a topic that is different than the one in the original design.
I follow these design guidelines, including:
The pages should look almost identical to the original design. Small adjustments like text or image changes are acceptable.
-Links
The home page link in the menu to the about page.
The logo in the header links to the home page.
Mobile menu
When the user clicks (or taps) the hamburger button on the header, the mobile menu appears over the page.
There are no guidelines for the mobile menu in the docs, but you should implement it so it is consistent with the design (colors, typography, spacings, etc.).
The mobile menu should have a close (X) button that closes the menu.
Dynamic page

The section "Featured speakers" is created dynamically in JavaScript.
I used a JavaScript variable with the data about the speakers and use it when the page loads to create the HTML for this section dynamically.
Original design idea by Cindy Shin in Behance.
Project documentation
A five minutes Loom video is attached to the Readme based on how this project was built.
Record a video describing your project.
Create a good README and pull request description.

Hi @oyelakinG9,
Status: Approved ✔
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Releases to PyPi

The current version in PyPi is flashtext 2.7, which was Released: Feb 16, 2018
There has been quite a few improvements and fixes since then, are you planning on releasing a new version soon?

👍

Hi @vi3k6i5, thanks for this impressive tool! Are you planning to release soon a new version on PyPi and Conda?


Use sbt-sonatype bundle release to speed up publishing

This resolves #58 in principle but despite changing the sbt-sonatype version to 3.4 libraryDependencies still shows 2.6 and the sonatypePublishToBundle key is not found. I am completely baffled. Any ideas?
Also unclear how to test this.

https://github.com/olafurpg/sbt-ci-release/blob/master/build.sbt#L29

hell

There's a new version already. Investigating.


Add org-log-into-drawer

Partially resolve #455

The test shows the behavior I deduced from the org mode docs, so could you give me some pointers as to what is not working yet?

Sure. First off: do you know how to reproduce this in emacs? I was able to set the org-log-into-drawer variable, but to actually do logs on a TODO-state change, I had to C-u C-c C-t, not just a C-c C-t (which is the equivalent of our cit). So at least I wasn't able to log everytime I do a simple TODO-state change, that's something we should discuss. Perhaps add something like ucit or uct :thinking:
The other thing is, that for some reason the TODO-state doesn't actually change with your PR. It stays at TODO, but should change to DONE. That's why you get the same log twice, when it should actually be something like
'  - State "DONE" from "TODO" [' .. Date.now():to_string() .. ']',
'  - State "" from "DONE" [' .. Date.now():to_string() .. ']',

And I am only able to get a log into LOGBOOK when there is a timestamp on that headline. Emacs also logs on plain headlines. I guess you were going for habits here?

From reproducing in emacs, our current behavior matches that in emacs. For non-repeating TODO, nothing is logged, for repeating it is logged and for repeating with org-log-into-drawer set, it logs into the given drawer. For non-repeating, the state is changed, for repeating it is not, just as in emacs.

@Jesse-Bakker thanks for the clarification, the thing I was missing was how the repeating date actually affects the expected behavior :+1:

@Jesse-Bakker thanks for the clarification, the thing I was missing was how the repeating date actually affects the expected behavior :+1:

No problem. I think it would be nice to actually have a comparative test suite that does the same operations in both neovim and emacs and compares the results. I might look into this a little bit "soon"(tm)

YES, I also thought about that recently. There probably is a test suite that the orgmode/emacs team uses. Ideally we take that and can use it as a measure of feature-completeness as well.


Official elasticsearch image unable to start

Expected behavior
After pulling an image, starting it from "My Images" should work.
Actual behavior
Does not
Information about the Issue
I'm following steps from elasticsearch (https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) and trying to make it work with kitematic
Steps to reproduce the behavior

docker pull docker.elastic.co/elasticsearch/elasticsearch:5.2.2
In kitematic, go to new container, then "My Images". Click create on the elasticsearch container.
Get error "(HTTP code 404) no such image - No such image: docker.elastic.co/elasticsearch:5.2.2"

It looks like Elasticsearch is forcing you to download from their remote registry, which seems broken. Doing docker pull elasticsearch:5.2.2 works perfectly for me.
Open a ticket with them.


Bug: Sublists are not rendered correctly

Imagine the following list:
* a
  * b
  * c
* d

Which markdown renders as:

a

b
c

d

However the markdown python module seems to render it as a flat list:

a
b
c
d

This is no matter if I use the plugin sane_lists or not ...
#!/usr/bin/env python
import markdown as md

markdown = """
# list

* a
  * b
  * c
* d

"""

_MD_EXTENTIONS = [
    'tables',
    #'sane_lists',
]
html = md.markdown(markdown, extensions=_MD_EXTENTIONS)
print(html)

list

a

b

c

d

I'm using Ubtunu 20.04
python --version
Python 3.8.10

pip freeze
importlib-metadata==4.11.2
Markdown==3.3.6
pkg_resources==0.0.0
zipp==3.7.0

You need to indent sublists four space.

Ok, thanks, that helped. :)
I'd still consider this a bug, however.
The "solution" seems more like a workaround to me.

As far as Python Markdown is concerned, this is not a bug. I'll link you to the maintainer's official response: https://github.com/Python-Markdown/markdown/issues/1204#issuecomment-992499686.
Keep in mind that Python Markdown is an old-school parser, and is not a CommonMark parser. This behavior is unlikely to change.

I see.
Thanks again. :)
Well I think I can live with that solution. ;)