Bug in Pykinect function NuiImageGetColorPixelCoordinatesFromDepthPixel

I was trying to get the function
NuiImageGetColorPixelCoordinatesFromDepthPixel
which is here,
https://github.com/Microsoft/PTVS/blob/master/Python/Product/PyKinect/PyKinect/pykinect/nui/_interop.py
line 192 to work in PyKinect and it kept throwing the error "byref(x)" is not defined. I found this page about the issue
http://pytools.codeplex.com/workitem/1078
and it said to change byref(x) and byref(y) to ctypes.byref(x) and ctypes.byref(y) in _interop.py and when I did this the function worked fine so I think it might be a bug.
If you look at line 186 in _interop.py you can see ctypes.byref(res) being used there.
Hope this is helpful :)

That certainly looks like a bug.
We don't get to bugs in our sample libraries very often, but if someone brings a pull request then we'll happily merge it.

Hi @tjwhale, is this bug still open. I am a newcomer and would like to contribute.

@rv404674 it looks like it is. I got it to work locally by making the change I suggested so I think if you make a pull request it should get accepted. Worth testing first of course. Good luck.

hey @TjWhale , i have opened a PR for the same. Can you please take a look when you get some time. Thanks. :)

Thanks everyone. I merged https://github.com/Microsoft/PTVS/pull/4747.


Social preview images

Hi there,
I can’t quite figure out how to define social thumbnails/preview pictures using this theme. Any clue?
Thanks!

@theletterf Did you find a solution? even I'm trying to figure out the same.

Thats sad.
I also tried referring to terminal.css framework and its GitHub.
Still no luck 😢😭

To generate a social media thumbnail, you need to add an image parameter to the page's front.
Here's an example:
+++
date = "2016-11-05T21:05:33+05:30"
title = "About"
image = "arizona-us.jpg"
+++

To generate a social media thumbnail, you need to add an image parameter to the page's front.
Here's an example:
+++
date = "2016-11-05T21:05:33+05:30"
title = "About"
image = "arizona-us.jpg"
+++


Bump min Python to 3.9

[x] Closes #1116
[x] Tests added
[x] Release note added (or unnecessary)

The idea is that before the 0.10 release, we

git reset --hard <first commit in this PR> and then git rebase main this branch
re-create the “pre-commit autofixes” commit or let pre-commit handle that
maybe fix up some things that got less pretty, e.g.

wrap braces arount this type: https://github.com/scverse/anndata/blob/b746b978f5bcaaeb412d5db2d91f5b66ee0c5768/anndata/_core/index.py#L41-L47
manually switch from cabc.??? to from collections.abc import ???

profitmerge

pre-commit.ci autofix

I've merged a version of this PR closer to the set of changes from when I reviewed last week. I did include a few more of the rules you added here.
Could you open an issue for follow up?
From time spent investigating these changes:

"ICN" I would actually like to go a little further than this rule set goes, and be able to define our own import patterns. I think this would be useful when dealing with all the libraries that define a sparse or linalg module. I would also like to have rules that make import from anndata in the tests more like how we recommend people use them, so it's easier to copy and past code out of the tests into a repl or notebook.
"SIM", I think I'm against this one. Some things it made better, some things it made worse. I think these should be almost always better.
For the things around typing, I'm a little curious about them. I think I'd like to have type checking actually run before doing too much here though.


[IMPAC-463] No KPIs data when changing to multi-organisation w/ shared dhb

@cesar-tonnoir when KPIs array is the same (has same id's) for a different organization's dashboard (multiple data source dashboard), track by kpi.id prevents KPI directive
controllers from detecting change and reloading.. Took me a while to find this difference between the widgets and the KPIs load architecture! Please review :beers:

fix conflict on Changelog.md


fix: correct typo in spanner_interleave_on_delete_cascade keyword

Fixes #98

[*] Tests pass
[*] Appropriate changes to README are included in PR

Note: The failure is a unrelated flake.
=========================== short test summary info ============================
FAILED test/test_suite.py::NumericTest_spanner+spanner::test_render_literal_numeric_asfloat
=========== 1 failed, 132 passed, 156 skipped in 1220.38s (0:20:20) ============


Syntax error on postgresql backslash command

A book on PostgreSQL contains the following example code where the backslash command is causing sqlint to fail. I'm not experienced enough in SQL to say if this error is appropriate or not but PostgreSQL runs it fine.
BEGIN;

CREATE TABLE factbook (
  year int,
  date date,
  shares text,
  trades text,
  dollars text
);

\copy factbook FROM 'factbook.csv' WITH delimiter '\t' null ''

ALTER TABLE factbook
  ALTER shares
   TYPE bigint
  USING replace(shares, ',', '')::bigint,

  ALTER trades
   TYPE bigint
  USING replace(shares, ',', '')::bigint,

  ALTER dollars
   TYPE bigint
  USING substring(replace(dollars, ',', '') from 2)::numeric;

COMMIT;

12:1:ERROR syntax error at or near "\"

\copy and other commands beginning \ are internal commands available inside psql but are not proper SQL commands. The behaviour here is therefore correct, in my view -- I wouldn't want to add a special case for the backslash commands, then, given that they couldn't be executed via a PostgreSQL client library.


Make Sure ScholarSphere is configured for background jobs

It seems like the jobs are being run inline.
We need these jobs to be run in the background so the system seems more responsive.
?? How do we tell if this is complete??
Disable resque, run the upload, wait and see not thumbs generate, enable resque and see thumbs?

Jobs will be run inline in development and test, but will use Resque in production.


Precompiled binaries missing for alertmanager 0.17.0 on prometheus.io

Thanks for pointing this out. There seems to be permissions issues for releasing the binaries, I hope to have this resolved soon.


Add a getter and property for the editor distraction-free mode

The distraction-free setter method was renamed for consistency.
Test this change
Create a new editor plugin, add the following script to it:
tool
extends EditorPlugin

func _enter_tree():
	print(get_editor_interface().distraction_free_mode)
	get_editor_interface().distraction_free_mode = false

Enable the distraction-free mode by clicking the button in the top-right corner of the editor. Then disable and enable the plugin repatedly and look at the console output.

Would be cool if the getter part was ported for 3.2 as well.

Thanks!

Cherry-picked for 3.2.2.


Nuget includes are not seen

When a project uses nuget package e.g boost or GSL the includes are not seen:
It's a bug in 2.0
x.cpp(1): error: 'boost/optional.hpp' file not found [clang-diagnostic-error]
#include <boost/optional.hpp>
         ^

xo.cpp(1): error: 'boost/asio/io_service.hpp' file not found [clang-diagnostic-error]
#include "boost/asio/io_service.hpp"

x.cpp(4): error: 'gsl/gsl_assert' file not found [clang-diagnostic-error]
#include <gsl/gsl_assert>
         ^

The workaround for this is to add paths to add nuget pacckage "include" subdir as argument for  parameter -I to clang compiler flags.

We never tested projects with Nuget dependencies.
We'll have to investigate to see how the work with MSBuild property-sheets and VS projects.
Thanks for the suggestion !

This issue was fixed in version 2.4 released today.
Thanks for you feedback 👍


Utilize Muli-Stage Build feature of Dockerfile

Using newly introduced Multi-Stage Build feature we can remove the bin directory and corresponding second Dockerfile. A single Dockerfile will be sufficient for both building and packaging a minimal image. This will simplify the release process.

We need to wait until Docker 17.06 is released which will be a stable version of Docker. Before that, the support for multi-build won't be available in DockerHub for automated builds.

It might be good to created the multi-stage Dockerfile in advance in a branch for quick merging once 17.06 is released. Is there a way to specify with Docker to use different versions of a Dockerfile based on the local system's Docker version?

It might be good to created the multi-stage Dockerfile in advance in a branch for quick merging once 17.06 is released.

That's a possibility. I will perhaps create a branch locally to test this. This one is not just about updating the Dockerfile, but some other changes would be needed to streamline the build process with the new setup.

Is there a way to specify with Docker to use different versions of a Dockerfile based on the local system's Docker version?

Yes, you can specify a file name to be used as the Dockerfile during build. Before multi-stage build support, people used to have multiple Dockerfiles and some shell script to put things together, known as builder pattern. The next stable Docker release being less than two weeks away, I would rather not go the old route.

Waiting the support to arrive to DockerHub as per https://github.com/docker/hub-feedback/issues/1039 before we can commit such changes.


FLPATH-43: Create and use custom Exception classes for throwables

This PR introduces custom exceptions that wrap uncheck Java exceptions.
Affected modules are: workflow-service, workflow-engine, and notification-service.

sqaush all commits into 1


Set manual integration to True for source control.

Purpose
Set source control manual integration to true to limit to manual integration, and prevent need to set up Azure and GitHub webhook authorization.
Does this introduce a breaking change?
[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

Functions are deployed.
Functions to not automatically update when new commits are made to the repository.

Other Information
See documentation at https://docs.microsoft.com/en-us/rest/api/appservice/WebApps/GetSourceControl for more on source control settings.

@brandonh-msft I did have a different experience.  When isManualIntegration set to false I would continually receive a "Repository 'UpdateSiteSourceControl' operation failed with Microsoft.Web.Hosting.SourceControls.OAuthException: GitHub GetRepository: Bad credentials" error message.
If I'm correctly understanding the doc at https://docs.microsoft.com/en-us/rest/api/appservice/WebApps/GetSourceControl#sitesourcecontrol, setting to false would enable a webhook into the GitHub repo to allow automatic deployments to the function when there is a commit to the repo. Setting up the webhook requires a the user to (at least once) manually establish the authentication between Azure and GitHub.  I believe that is why I was receiving the "Bad credentials" error (when isManualIntegration was set to false), as I had not previously established authentication between Azure and https://github.com/Azure-Samples/durable-functions-producer-consumer.
Additionally, when looking at the deployment log for both the producer and consumer functions, I see a message about the triggers being synced.

sweet - and good catch. Thanks for the contrib.


Bug? Managed Installs list appears in random order

On the Managed Software tab (tab_munki) of the Client Detail page, the list of Managed Installs appears to have no particular order... I've noticed this in the past, but never paid much attention to it. Now my list of items has grown large enough for this to be a minor issue when scanning for a particular item on that particular machine.
Would it be possible to order Managed Installs in alpha order by "Display Name"?

Fixed with #211


Korean calendar of 2021 is not working

It's the first trading date for the Korean exchange, but the calendar said it's not a trading date.

Fixed via https://github.com/quantopian/trading_calendars/pull/207

Fixed via https://github.com/quantopian/trading_calendars/pull/207


Lightweight Command Line Linux In The Gallery?

Could we have a lightweight Linux image that can run in UTM SE eg on an iPad?
There are lots of things I can't do on iPad OS this would enable.
I don't need a GUI so a command line build would do fine.
I do need a proper package installation capability.
Also this would need to be save-able.

There is already an Arch Linux machine in the gallery and a Debian 10.4 Custom i3. Which one fits you the best? All of them are command line and the Debian 10.4 Custom i3 has a console.

Thank you. The one that successfully got me to a command line was Arch Linux. However, trying to run pacman -S python got me a 404. In fact any pacman -S attempt to install anything gives me the same result.
I would've preferred the Debian route but I can't get to a command line when it starts.

Actually fixed the pacman issue with pacman -Syy - to update its list of packages.

Thanks for the pointer to Debian 10.4, it helps but some programs are working in my existing workflows better with Ubuntu. Would a minimal Ubuntu Server version also be possible?

Thanks for the pointer to Debian 10.4, it helps but some programs are working in my existing workflows better with Ubuntu. Would a minimal Ubuntu Server version also be possible?

Yes. If the .iso you have is Ubuntu Server 22.04, then there is an Ubuntu 22.04 and 14.04 guide in the UTM Gallery

I would've preferred the Debian route but I can't get to a command line when it starts.

I have read the documentation of Debian, the operating system prompts you to first choose whether you want to use Option or Command as the $Mod key. The $Mod key stands for the modifier key, which is the same thing as the  Command key. The Command can be used with the Space key to open the Spotlight menu. The prompt is shown only when the config file does not exist at ~/.i3/ or ~/.config/i3/.
The virtual machine template has it set to Command or Option. Try pressing them to see which one is the modifier key. After the modifier key has been set you can press Modifier+D to open the application startup dmenu. With dmenu you can then open a terminal or text editor to read or modify the configuration file.
In the configuration file, you can add key binds to open applications with this format:
bindsym $Mod+<key> <command> <arguments>

So to open Firefox with the Debian site by pressing Modifier+F, you can do this:
bindsym $Mod+F exec firefox www.debian.org

You will have to restart the window system for the new configuration file to take changes:
- $ i3 restart

[!TIP]
You can set the restart command to a key bind can save a lot of time during configuration:

bindsym $Mod+<key> restart

For more information about setting up i3, check their documentation.
Hope this helps!

I recently tried using antiX linux distro (I checked antiX-23.1-Base 32bit with lightweight gui) on my ipad in UTM SE and while it was still very slow I definitely worked better than other linux distros from utm gallery (and also better than reactos) so perhaps you might want to try that. I also wanted to try freedos but I had problems with setting it up. Perhaps this antiX (or something similar with very lightweight gui) or maybe freedos (if anyone is able to set it up) could be added to offical utm gallery so we have there something that works faster on iOS with UTM SE?

or maybe freedos (if anyone can set it up)

This is a guide for macOS, but I hope you can figure it out.
Create a new virtual machine and choose Emulation. It is gonna be slow because we chose emulation. Choose your .iso file in the Boot iso path. Set about 100 megabytes to the main drive. That is enough to run DOS. Then, set anywhere about 512 megabytes of memory. Choose Open VM settings after creation.
Add a new drive. Set it to a floppy drive, and save all of the changes. Adjust the order of the drives so that the floppy is in the bottom, the CD-ROM is at the top, and the main hard drive is in the middle.
When booted, press 1 or Enter. Then, choose the run fdisk option. If it asks if you want to use FAT32, choose yes. Choose option 1 for the primary disk partition. Then, choose yes. (the partition you install FreeDOS onto must be active so it boots.)
Boot from the CD, and run SETUP. Format the drive if asked to, and continue the setup. I provided an existing UTM template so you don't have to do this yourself. I don't have a FreeDOS .iso, but I made the template on iPad mini 6.
FreeDOS.zip

@MartinPacker If you can make a lightweight Linux virtual machine, you can then ask to submit it to the gallery.
I found out that you can contribute to the gallery. It was explained in https://github.com/utmapp/UTM/issues/3807 .


[BUG]: The specified module '\ps_modules\Sanitizer' was not loaded because no valid module file was found in any module directory

Task name
Windows machine file copy
Task version
1.227.0
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows Server 2019
Task log
System.Management.Automation.RemoteException: The specified module '\ps_modules\Sanitizer' was not loaded because no valid module file was found in any module directory.
System.Management.Automation.RemoteException: The term 'Write-VstsTaskError' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
System.Management.Automation.RemoteException: The specified module '\ps_modules\Sanitizer' was not loaded because no valid module file was found in any module directory.
System.Management.Automation.RemoteException: The term 'Write-VstsTaskError' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PowerShell script completed with 4 errors.

Relevant log output
The specified module '\ps_modules\Sanitizer' was not loaded because no valid module file was found in any module directory

Aditional info
This error appeared over night since we automatically took the new sanitizer change.

Hi @JordanMaclachlan-RLG. Thank you for this issue, we're already working on its solution.
If you have access to your self-hosted agent, may I ask you to share some details.
Can you please go to the agent folder -> _worker -> _tasks
Usually the path looks like this: C:\agent\_work\_tasks
And then, can you achieve the WindowsMachineFileCopy_731004d4-1d66-4f70-8c05-638018b22210 folder and share it here.
This folder contains source code for the WindowsMachineFileCopy tasks and it would help us a lot.

@JordanMaclachlan-RLG can you also share the link of failing pipeline, so we can investigate it further.
The format should be like this:
https://dev.azure.com/{organization}/{project}/_build/results?buildId={id}&view=results

Hey, @JordanMaclachlan-RLG thank you so much for the help.
Your archive was really useful.
I would like to ask you to share the full pipeline log of your first run, where you faced the issue.
You can download it here:

If you are concerned about safety, you can send it on my Microsoft email<EMAIL_ADDRESS>

This should be he first failure log. We are extensively using this task in 100s of pipelines so this failure really knocked us. Would you have a possible timescale for a fix? this will determine if we need need to wrote our own task or wait.  I will let you know if i get the go ahead to send the pipeline.
Attempt1.zip

Hey @JordanMaclachlan-RLG thank you so much for sharing these details.
I can't say how much time it will take, but I hope to fix it in the next few days.

Hi @JordanMaclachlan-RLG if possible, can you try to clear the task cache from "C:\agent_work_tasks.....", once clear 1.227.0, the agents should be able to automatically pick task version 1.226.1 (which was the previous working version).
if you're using Microsoft-hosted agent, the agents will automatically pick version 1.226.1.

Morning, i see  the sanitizer import is still there in main? is this not going to throw the same issues? or have you just re published the previous version?
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/WindowsMachineFileCopyV1/WindowsMachineFileCopy.ps1
Jordan

Morning, i see the sanitizer import is still there in main? is this not going to throw the same issues? or have you just re published the previous version?
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/WindowsMachineFileCopyV1/WindowsMachineFileCopy.ps1
Jordan

Hi GM, we had reverted back the task version on last Friday from the backend, for Microsoft hosted agent it was able to auto pick the reverted version (ie 1.226.1), but for self-hosted agent users, there is some manual procedure to follow in order for agents to pick the reverted version(1.226.1).
The manual procedure is to clear the 1.227.0 task cache/folder within the agent folder. once it's cleared the agent will be able to pick 1.226.1(working fine)

Looking at the code in 1.226 on our servers its also including Sanitiser?  Version 1.225 is the one that doesn't include these modules. Would it not be better to revert back to 1.225?
Jordan

This issue is now resolved.
V228.1 will be containing the fix, which will be out by tomorrow to all the regions.
Feel free to reopen this issue if needed.


wifi won't work

I have a m1 Mac mini and no matter what I do the Internet wont work. I've tried changing settings I've used cms. but cause its windows 11 Im trying to run I can't even get out of setup menu

Please see the bottom of the UTM gallery page for Windows 11.


Release 1.0.1

Should this be 1.0.1 or 1.1.0?
I don't understand why build_minimal fails, same command works locally.
$ cargo +nightly build -Zminimal-versions --all-features

duplicate of https://github.com/CosmWasm/cw-utils/pull/4


Get rid of two labels

https://theappsmith.slack.com/archives/C04P60V0VQE/p1707308259360009

According to me this should be prioritized


Token limit aware templating

Different sections of a prompt template are unaware of the number of tokens other sections are using. When combined, the size of a final prompt can easily blow past input token limits.  A means for setting limits on the size of different sections of a prompt template would help developers allocate tokens to more important parts of the template while creating a final template that stays within an allowable token range.

this especially can show up when using {{recall}} - because the recalll is embedded in the prompt you can't check how big the thing is before you decide if it should be included.

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


storeのテスト

storeのテストを追加した。

Codecov Report

Merging #32 (dc5ebe2) into main (620aac5) will decrease coverage by 1.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   74.46%   73.33%   -1.14%
==========================================
  Files           3        4       +1
  Lines          94      105      +11
==========================================
+ Hits           70       77       +7
- Misses         13       15       +2
- Partials       11       13       +2

Impacted Files
Coverage Δ

store/gomap/workspace.go
63.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620aac5...dc5ebe2. Read the comment docs.


Issue with webpack_require with style-loader/css-loader

Operating System: Arch
Node Version: 8.9.4
Yarn NPM Version: 1.3.2
webpack Version: 4.0.1
webpack-serve Version: 0.1.5

This issue is for a:

[x] bug
[ ] feature request
[ ] modification request

Code
CLI Command
  $ webpack-serve --config webpack.config.js

webpack.config.js
const webpack = require('webpack');
const path = require('path');
const history = require('connect-history-api-fallback');
const convert = require('koa-connect');

module.exports = {
    mode: 'development',
    resolve: {
        extensions: ['.js', '.jsx', '.json']
    },
    entry: [
        'webpack-hot-middleware/client',
        path.resolve(__dirname, 'src/index.js')
    ],
    serve: {
        content: ['./src'],
        open: true,
        port: 3000,
        hot: {
            hot: true
        },
        add: (app, middleware, options) => {
            app.use(convert(history()));
        }
    },
    plugins: [
        new webpack.HotModuleReplacementPlugin()
    ],
    module: {
        rules: [
            {
                test: /\.jsx?$/,
                exclude: /node_modules/,
                use: {
                    loader: 'babel-loader',
                    options: {
                        cacheDirectory: true,
                        presets: [
                            'react',
                            'stage-1',
                            'env'
                        ],
                        plugins: [
                            'react-hot-loader/babel'
                        ]
                    }
                }
            },
            {
                test: /\.css$/,
                loader: ['style-loader', 'css-loader']
            }
        ]
    }
};

Note: Every dependency is at their latest version as of 03/02/2018.
Expected Behavior
App doesn't crash, and imports the desired 'css' styles.
Actual Behavior
App crashes, and throws the following error:
styles.css:21 Uncaught SyntaxError: missing ) after argument list
    at Object../src/styles/main.css (bundle.js:18412)
    at __webpack_require__ (bundle.js:1399)
    at fn (bundle.js:781)
    at Object.eval (App.js:23)
    at eval (App.js:67)
    at Object../src/App.js (bundle.js:16446)
    at __webpack_require__ (bundle.js:1399)
    at fn (bundle.js:781)
    at eval (index.js:9)
    at Object../src/index.js (bundle.js:18293)

Digging deeper it seems to be related with HMR when using webpack_require.
I went ahead and tested this webpack configuration using webpack-dev-server and everything seems to be ok. This is the configuration I used for it:
    devServer: {
        contentBase: './src',
        historyApiFallback: true,
        hot: true,
        open: true,
        port: 3000
    }

I also tried this with a larger codebase, and found that this piece of code that I use for Redux and HMR was also throwing me errors:
    if (module.hot) {
        module.hot.accept('../reducers/index', () =>
            store.replaceReducer(require('../reducers/index').default)
        );
    }

Again, it seems related to requiring things.
How Do We Reproduce?
Feel free to use this gist as a starting point:
https://gist.github.com/JMSantos94/c61833bcc716e338e2729bcc7fccbd59
Do let me know if you need more information!
Hope it is just not me missing a variable or something in the configuration :laughing:

Thanks for the issue 🍺  The first thing that stands out to me is that you don't have to (and shouldn't with webpack-serve) define the new webpack.HotModuleReplacementPlugin().
Other than that, this looks more like an issue with webpack itself and not webpack serve. You can note that webpack-serve doesn't even appear in the stack trace. Was there something about the error that made you think it was this module's cause versus webpack proper?

Thanks to you for the hard work! :beers:
You were right, it was simply a silly mistake on my end, new webpack.HotModuleReplacementPlugin() was the one giving me the error. I assumed the error related to webpack-serve, because this particular configuration was not giving me issues with webpack-dev-server.
I will go ahead and close this issue! :smile:


Support incrimentaRasa 3.X and normal Rasa

Mostly dealt with payload upgrade and async modifications. Test before committed.
Also type inside setup.py

Also Rasa 3.0 does not exist, only 3.1 and up does...


[Bugfix] Resolve the type erase caused by loading Nacos data

Describe what this PR does / why we need it

Fix type erasure issues
Format code

Does this pull request fix one issue?
fixed #1162

👍 I will review it later

Maybe the json or xml has the same problems.

Maybe the json or xml has the same problems.

I've verified.It works well.


[wip] revamp entire metrics

Co-authored-by: Teddy Koker<EMAIL_ADDRESS>
What does this PR do?
Deletes metrics
Fixes #3877
Before submitting

[X] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[X] Did you write any new necessary tests?
[X] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Always 💯
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @ananyahjha93! Thanks for updating this PR.

 If you want a single function to compute your metric value:
acc = Accuracy()

for batch in dataloader:
    step_acc_val = acc(preds, target)

@ananyahjha93 the functional API does none of these things. It's just batch in, Value out and I really would keep these (same reason why python has finctionals of their loss functions).

Hi guys, I just install the pytorch-lightning package with the latest version in master, but found out that the metrics.functional was gone and the metrics were almost empty.
Is that true for the moment due to the revamping?
Would you recommend a usable version as of now? Thanks


Added scrollbar and more options in typeahead

Fixes #519 Medication/inventory typeahead issues
Changes proposed in this pull request:

Typeahead now displays a maximum  of 10 options by adding limit in typeahead.js. Adding more than 10 appears to make the acceptance tests timeout
Typeahead now has a maximum height of 110px and displays a vertical scrollbar

Example

cc @HospitalRun/core-maintainers

@cmwebby - thanks for the PR!  Quick question - instead of limiting to 10 can we have it be unlimited with the scrollbar?  Maybe 10 is good enough, but just curious what you found.

@jkleinsc Firstly can I apologise for making then closing a like a million pull requests! I don't normally work this way!
I think it certainly could be made to be unlimited but I think there may be a couple of issues with this:

The main issue is whenever I tried adding a number more than 10 it made all the acceptance tests timeout. I couldn't spot the reason why it did this so I just stuck with 10.
e.g

not ok 74 PhantomJS 2.1 - Acceptance | medication: returning medication
---
actual: >
null
message: >
Test timed out
Log: |

If there are too many results say more than 50 it would probably just be quicker and easier for the user to just to type a few more characters in than searching all the possible results using the scroll bar.

If you have any ideas of why it would make the tests fail I am happy to go back and increae the limit.

@jkleinsc Ignore my previous comment for some reason the tests are passing now with more than 10. I have set a limit of 500, but it can be set to more if you want.

@cmwebby Looks good to me.  I just tested it with a large dataset and the typeahead had no problems loading 500 suggestions, so I think we will stick with that.  Thanks for the PR!


Install Hangs For Open Shell (Start Menu) and Shell (Expanded Context Menu) (multi-install)

Description
When I check Open Shell (Start Menu) and Shell (Expanded Context Menu) and tap install the PowerShell window focuses up and displays a blue bar at the top (not the usual text updates) and then proceeds (as far as I can see) to do nothing.
I have closed the util, and tried again, same problem.
If this is a repeat issue I totally understand immediate closure and relating to existing.
The tool itself feels unclear on updating Chocolatey / Winget ... so I looked them up online (details in Additional context) and have updated.
Once both were updated this ran just fine, will add second update to indicate this.
Reproduction Steps
This is reproducable.
Steps to reproduce the behavior:

Go to 'Install'
Select 'Open Shell (Start Menu)' and 'Shell (Expanded Context Menu)'
Tap 'Install'
PowerShell cmd window hangs as per pictured update.

Expected Behavior
I expected the Utilities to install, I'm assuming that the blue floating update thing might have something to do with it ... because: new.
But I dunno.
Screenshots

Additional context
Pertinent Information
Win Util
Chocolatey - Updated from Chocolatey v1.2.1 to Chocolatey v2.1.0
WinGet - Updated to (or from ... unclear) 1.21.1573.0
Win 11
Version - 22H2
OS Build - 22621.1992
Experience - Windows Feature Experience Pack 1000.22644.1000.0
Notes
I am on the Windows Insider Program (I know, I cuffed up ... I can't leave all my setup/apps/etc) and for whatever reason the Security Updates Only tweak in your tool unfortunately doesn't seem to stop it pushing feature stuff.

Chocolatey Already Installed
**********************
Windows PowerShell transcript end
End time:<PHONE_NUMBER>1434
********************** ```

Fix
Updating Chocolatey and Winget, seems to have fixed this. 👍

Notes
Actually, one thing that the log didn't show that was prior to the update, on startup, it checks for choco and wg, and was finding both, acknowledging their install, but was saying that "Winget failed to install" after the check.
====Chris Titus Tech=====
=====Windows Toolbox=====
Checking if Chocolatey is Installed...
Chocolatey Already Installed
Checking if Winget is Installed...
Winget Already Installed
===========================================
--      Winget failed to install        ---
===========================================

Perhaps the low version of one or the other package manager has affected this.


Run npx @open-cells/create-app don't work as expected

First of all, thanks for the great work to the team behind this framework.
I have tried both options of the template offered in the CLI and both result in only the copy of the package.json and index.html in the created folder.
Here is the log of my terminal:
Open Cells create-app scaffolder
Make the web with Open Cells!

√ What kind of application would you like to scaffold? » Open Cells example webapp using Lit and Typescript
√ What is the name of your application? ... test-open-cells

./
├── test-open-cells\index.html
└── test-open-cells\package.json

√ Do you want to write this file structure to disk? » Yes
√ Do you want to overwrite<EMAIL_ADDRESS>» Yes for all files
Writing..... done
You are all set up now!

To go into the application directory, run:
  cd test-open-cells

Then run:
  npm install
  npm run serve

If you want to rerun this exact same generator you can do so by executing:
npm init create-app --destinationPath D:\projects\test-open-cells --type exampleWebapp --name test-open-cells --writeToDisk true

Thank you very much for opening the issue and for your time. We are working to resolve it.

@open-cells/create-app version 1.0.2 has been released which resolves this issue

@open-cells/create-app version 1.0.2 has been released which resolves this issue


Fix inconsistent StreamField ValidationError nesting

Fixes #7086. As per https://github.com/wagtail/wagtail/issues/7086#issuecomment-826945031, ensure that .as_data() is consistently called when telepath-packing ErrorList objects (so that we preserve any embedded ValidationError objects instead of casting them to strings), and introduce an explicit ValidationError class on the client side to make mismatches more obvious (and for future extensibility in case we need to attach more fancy logic to ValidationError).
Also add tests for setError, and fix rendering of StreamBlock non-field errors (selector to clear old errors was incorrect, and jest apparently doesn't support innerText).

Merged (with print fix) in 1061caa5eff53f450520284b618e615fc2a809c8 (main) and 498fcbd6cabad21868f94aeda7207c6e60ce2ae7 (stable/2.13.x).


Angular remote in React as host in latest version 18

Do we have any working repo with compatability with latest version like React as host angular as remote.

Right now it works on React 17, I would try upgrading to 18 and seeing if it still works, if not I'd check the differences between the versions. If it doesn't work, you can find the difference and apply a patch on 18 to get it working.
The upgrade guide lays out a few of the migrations necessary, but you might not have any issues if you upgrade and apply those migrations
https://react.dev/blog/2022/03/08/react-18-upgrade-guide
It would be nice to have different versions of each framework interacting with each other. Right now it's React 17, Angular 13.2, and Vue 3, and they all use webpack as the build system. I think the goal would be to know which versions of Angular, React and Vue are compatible with each other, find the differences between the ones that aren't, and write patches for each case, but I would try upgrading and seeing if it works first.

I did some patch work it’s working good, can you suggest on the route part, it’s better to maintain in the host or its good to maintain in the remote?

Both for sure. Like if I had a host application with pages specific to itself, you would have routes there, and any remote application that's then loaded would have it's own set of routes relative to where it's being loaded from the host. There's no examples in this project but I found this project for react which uses react router to do that which can be applied to the hosts and remotes here. https://github.com/nebarf/module-federation-react-router-dom

I really thankful to you


cmd/trace: surprising Threads "InSyscall" count

What version of Go are you using (go version)?
$ go1.9 version
go version go1.9.2 darwin/amd64
$ go-tip version
go version devel +1ac8846984 Fri Nov 3 14:06:21 2017 +0000 darwin/amd64

Does this issue reproduce with the latest release?
The problem is new in tip; go1.9.2 looks fine.
What operating system and processor architecture are you using (go env)?
First seen on linux/amd64 with GOMAXPROCS=36, somewhat reproduced on darwin/amd64 with GOMAXPROCS=8.
What did you do?
I took an execution trace of a server running with Go tip (1ac8846984) and compared it to one running go1.9.2. I looked at the "Threads" ribbon near the top of the window.
What did you expect to see?
With go1.9.2, the Threads ribbon shows a very small number of threads in syscall, usually one or two. This makes sense to me: the server handles data over the network so likely has a thread sitting in epoll_wait and occasionally has threads reading and writing to sockets.
What did you see instead?
The Threads ribbon hovers around 37 instead of around 1. My server runs with GOMAXPROCS=36.
I checked /debug/pprof/goroutines?debug=1 and ...?debug=2 to see if there really were more goroutines unexpectedly sitting in syscalls but did not find any.
I've produced a similar behavior on my laptop via go test net -trace=/tmp/trace && go tool trace /tmp/trace. With go1.9.2 it shows 1 thread in syscall, but on tip it shows 4 threads in syscall.

Here's my server with go1.9.2 (linux/amd64, GOMAXPROCS=36):

And my server with tip—note the thick layer of periwinkle in the Threads ribbon:

Here's go test net with go1.9.2 (darwin/amd64, GOMAXPROCS=8):

And go test net with tip:

It seems it is related to runtime changes in managing timerproc. For InSyscall stats, three trace events types are involved. GoSysBlock, GoInSyscall, and GoSysExit. The first two increment the counter, and the GoSysExit decrements the counter.
from Tip:

> go test -cpu 4 -run TestTCPServer -trace /tmp/tip.trace
> go tool trace -d /tmp/tip.trace | grep Sys | grep -v SysCall
376494 GoSysBlock p=3 g=50 off=36115
409851 GoSysBlock p=2 g=34 off=23368
583289 GoSysExit p=1000003 g=34 off=413 g=34 seq=4 ts=173541978068605
594011 GoSysBlock p=0 g=34 off=431
637888 GoSysExit p=1000003 g=34 off=439 g=34 seq=6 ts=0
639079 GoSysBlock p=0 g=34 off=451
692212 GoSysBlock p=3 g=10 off=36153
1127209 GoSysBlock p=0 g=18 off=493
1176512 GoSysExit p=1000003 g=18 off=23689 g=18 seq=6 ts=173541978100972
1200027 GoSysBlock p=2 g=18 off=23707
1591916 GoSysExit p=1000003 g=18 off=12903 g=18 seq=8 ts=173541978123637
1596370 GoSysBlock p=1 g=18 off=12921
18744873 GoSysBlock p=3 g=162 off=40858
34934913 GoSysExit p=1000003 g=162 off=40869 g=162 seq=4 ts=0

On the other hand, the same trace generated with Go1.9, and read with the trace tool on tip shows fewer relevant events.

586130 GoSysBlock p=2 g=10 off=18647
783157 GoSysBlock p=3 g=8 off=27763
787317 GoSysExit p=1000003 g=8 off=27772 g=8 seq=6 ts=0
25363425 GoSysBlock p=1 g=110 off=13369
28141938 GoSysExit p=1000003 g=110 off=13380 g=110 seq=4 ts=0

Looking more carefully about what these goroutine 10 and 34 (whose GoSysBlock events were never paired with GoSysExit events) from the tip trace revealed:
they are both runtime.timerproc goroutines.
I vaguely remember there were runtime changes related to timer management this cycle.
@aclements may fill in more details.

I vaguely remember there were runtime changes related to timer management this cycle.
@aclements may fill in more details.

Yes. In Go 1.10, there are per-P timer queues as well as a per-P timerproc goroutine CL 34784. That's almost certainly the cause of this.
The impact on visualization is a bit unfortunate (and probably worth mentioning in the release notes). Is this actually causing problems, though?

That would explain it, thanks!

Is this actually causing problems, though?

The problem I've seen from it is that it makes the visualization less clear. In Go 1.9 and earlier, it was easy to see where a program was saturating the CPU, since there was an indicator (the purple thread ribbon) that would max out at close to 100% of its range.
Based on CL 34784, it looks like the ribbon is reflecting reality—but for my uses it's mostly noise now.
I was also surprised that I couldn't match up the extra threads to goroutines waiting for syscalls in /debug/pprof/goroutine since they count as system goroutines. The visualization now includes a prominent contribution from a set of goroutines that are very hard to track down.

Interesting. I wonder if we should be hiding or distinguishing threads that are in a system call on behalf of a system goroutine.

Is there anything else to do for this issue?

Closing.

Thanks @hyangah . With devel +2873605 Wed Dec 6 15:50:04 2017 +0000, this is much better. On the first "View trace" link, there's still a large number of Threads that initially show up as InSyscall, which decreases as more data points are processed.
Below, see the periwinkle band in the Threads ribbon, starting off thick at 0–12ms, waning at 20ms, and close to the expected size around 40ms.

Does the execution trace include the required data at startup or is it only written out as the syscalls return, and does that mean that a timer has to trigger on each P before the Threads ribbon will exclude the timer threads?

Thanks! That's obviously a bug. The tracer processes the sorted event list sequentially, and the GoCreate-GoSysBlock event pairs for pre-existing goroutines are processed before GoStart events that set up the goroutine state (https://go.googlesource.com/go/+/master/src/cmd/trace/trace.go#400).
So, the heuristics of cl/81315 doesn't work for the preexisting goroutines.
Moreover, GoCreate events (emitted for each goroutine that preexisted when tracing starts) include two stack info (one is where the goroutine is stopped, another is where the GoCreate event logging occurred https://go.googlesource.com/go/+/master/src/runtime/trace.go#214). The later one is less interesting but somehow, the parsed event's stack field is filled that uninteresting one.
Anyhow, the information is there for use. I am reopening this issue hoping that it can be addressed soon.

@hyangah CL 83595 PS 8 fixes this for me, thanks!


Window in Marathon medbay blocks table

Just remove all the windows in this room, they're dumb.

agreed i hate windows in treatment rooms i usually break or deconstruct them

Anybody else deconstruct the center wall too? ✋

Marathon med has some other quirks like a single private patient room all the way at the bottom of med, as well as a whole psychiatric ward with a mre vendor and sec elements

@Emisse did you fix it

Entire medbay was remapped here so this is fixed.


Replication task processor bugfixes

Use mutableStateBuilder.GetNextEventID rather than managing event ID on
the history builder for generation of replication tasks.  Managing the
next event ID on history builder does not account for buffered events
and will cause incorrect next event ID set on the replication task.
Fixed missing metric scope definition for replication queue processor.

Coverage increased (+0.04%) to 63.504% when pulling d35011706ce753afecd6086f3395e5241513925e on samarabbas:xdc-bugfixes into 314d222071e8fcae72275092364ef68fbed5e7e6 on uber:master.


ImportError: No module named 'engine'

I can install it fine, but when I try to import it from a py file I get this error.
I'm running OS X 10.10, if that's any help
Thanks,
Meorge

I am running windows and I get this error

I got the same behavior with linux

Same error with windows 64bit and python3

No solution?

A lot of errors with python 3 are corrected by @westonpace patches : see https://github.com/westonpace/pyttsx

Can you merge them into your repo please? Thanks!

https://github.com/westonpace/pyttsx
solves all problem...

Still getting the same errors and when trying to fixed I get
ImportError: No module named 'drivers'
I thought it was a error in this package being py 2.7 instead of 3.0


drachtio not binding to specific address

if I launch drachtio with --address or put an address in the admin tag of the configs, drachtio-server still binds to <IP_ADDRESS>
[root@geo-drachtio ~]# /usr/local/servers/drachtio-server/bin/drachtio --version
v0.8.3-4-g8fe175fb0

if I use a different port, it reads that parameter, but the IP address it doesn't take, it always bind to <IP_ADDRESS>
the entry in the config file
<IP_ADDRESS>
or if I do it on the command line "drachtio --address <IP_ADDRESS>"

thanks for finding this.  Can you retest with the above commit and close the issue if this fixes for you?

that fixed it.
thank you :)


[ES] Version messages related #1025

Update version messages as requested in #1025

This is great @edwinallenz, thank you!   @erickgnavar could you review this one too when you have a chance?

Thank you @edwinallenz and @erickgnavar 👍


Update packaging

I added a pyproject.toml both to stay relatively current with python build practices, and to make it slightly easier to use pip. I've gone with Poetry as the non-conda environment manager, although I don't have much personal experience beyond checking that this README works.
I'm including instructions to build from source in the template README so developers can get onto developing straight away in a clean, new environment. For conda, I chose to get them to just install from devtools/conda-envs/test_env.yaml and docs/requirements.yaml, which guarantees that they stay current with CI. For pip / Poetry, it sources from pyproject.toml, and I've got tests in CI to make sure that the build from source instructions work.
Preview at https://github.com/lilyminium/test_mda_conda_nortd

Hello @lilyminium! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file {{cookiecutter.repo_name}}/setup.py:

Line 46:80: E501 line too long (82 > 79 characters)

I really don't think we should be going down the poetry side of things. Do we really need to do this? Can't we just stick with pypi and conda?

For conda, I chose to get them to just install from devtools/conda-envs/test_env.yaml and docs/requirements.yaml,

Can we not squash these down to a single file? It's a bit of a pain for devs to have to update many files

I really don't think we should be going down the poetry side of things. Do we really need to do this? Can't we just stick with pypi and conda?

I just don't really want to learn to use virtualenv, but want people to use virtual environments even with pip. Poetry seems to do things very simply.

Can we not squash these down to a single file? It's a bit of a pain for devs to have to update many files

the test_env file is just dependencies needed to install/run tests on the package; the docs/requirements is just dependencies needed to build docs. For RTD and general environment hygiene reasons I'd rather keep them separate. On RTD especially, MDA's had repeated problems with the build timing out trying to resolve too many dependencies.

For now here are the main reasons I really would like to stick to pypa:

As you mention in the PR text itself, we don't have much experience with poetry. If we need to handle changes, fixes, etc... we'll need to have a build system we know very well as the base thing. We know pypa too well. I get that virtualenv is bad, but it's a known bad thing.

Upstream doesn't offer poetry support, it might work but we don't test it. I would much prefer aligning kits to what we do upstream right now.

Our expertise in DevOps is in the pypa ecosystem, for better or for worse, once we get folks to do automated releases etc... being able to use pipx, etc..  is just easier for now

Can we not squash these down to a single file? It's a bit of a pain for devs to have to update many files

the test_env file is just dependencies needed to install/run tests on the package; the docs/requirements is just dependencies needed to build docs. For RTD and general environment hygiene reasons I'd rather keep them separate. On RTD especially, MDA's had repeated problems with the build timing out trying to resolve too many dependencies.

Is this more of an us problem though? Do we expect kits to have the same dependency hell that we walk?
In any case we might need to write a script that just generates these yaml files on the fly or at least checks that they are consistent with core requirements set somewhere else. Otherwise the maintenance burden gets too high for folks that have never dealt with these things.

Is this more of an us problem though? Do we expect kits to have the same dependency hell that we walk?

In any case we might need to write a script that just generates these yaml files on the fly or at least checks that they are consistent with core requirements set somewhere else. Otherwise the maintenance burden gets too high for folks that have never dealt with these things.

From a basic user perspective, just using this library, I'd definitely prefer just having a single environment.yaml. If I were installing into a preexisting environment I could be annoyed if optional dependencies clash (e.g. if someone is pinning to a too-low sphinx to avoid updating docs) and I had to fix things myself. So there are pros and cons to each approach.

Is this more of an us problem though? Do we expect kits to have the same dependency hell that we walk?

In any case we might need to write a script that just generates these yaml files on the fly or at least checks that they are consistent with core requirements set somewhere else. Otherwise the maintenance burden gets too high for folks that have never dealt with these things.

From a basic user perspective, just using this library, I'd definitely prefer just having a single environment.yaml. If I were installing into a preexisting environment I could be annoyed if optional dependencies clash (e.g. if someone is pinning to a too-low sphinx to avoid updating docs) and I had to fix things myself. So there are pros and cons to each approach.
Edit: and for different people -- easier for the developers to have a single file, not necessarily easier for users

Yeah that's fair - how about we raise this as an issue for now and we can think of at least a CI way to check that deps match across multiple yaml files? I think it should just require a bit of pyaml hackery but that's a future problem thing i.e. it shouldn't block this PR

@IAlibay thoughts on the current pyproject.toml without peotry?

@IAlibay I think I addressed your comments :)


How to add text on stream?

I need add current time on stream

Hi, @ngoloc10796.
Adding text over the video is not in the main goals of this project.
You can achieve that by post-producing the video server-side.


Unexpected comma in title

Similar to #286, I continue to see a comma in the title of pages of my Gatsby app and seems to only be a problem if there's an expression in the title. A reproduction of this issue can be seen in the following branch.
https://github.com/corydeppen/gatsby-8655-example/tree/react-helmet-comma

I am seeing both stray commas (,), as well as html comments (<!-- -->).
I've worked around it by using the titleTemplate feature, which completely removed our need to do interpolation.

@corydeppen This problem seems to have been fixed a long time ago see pr #351. Merged in to the master by @jamsea, The major problem here is that there has not been a new release/npm/maintenance for about a year (#391).  So you are probably using the latest version from npm from before the possible fix was merged to the master...
Could you possibly create a test against the master?
fyi @tmbtech @cwelch5
Also possible issue template requesting used version?

Any updates? I'm still experiencing this issue.
<EMAIL_ADDRESS>  version "5.2.0"
  resolved "https://registry.yarnpkg.com/react-helmet/-/react-helmet-5.2.0.tgz#a81811df21313a6d55c5f058c4aeba5d6f3d97a7"
  integrity sha1-qBgR3yExOm1VxfBYxK66XW89l6c=
  dependencies:
    deep-equal "^1.0.1"
    object-assign "^4.1.1"
    prop-types "^15.5.4"
    react-side-effect "^1.1.0"

Code:
<Helmet {...helmet}>
   <title>{username + " - " + ujian} Ujian</title>
</Helmet>

result:
<title>i16011 - AIF000000, Ujian</title>

Also still encountering this with latest version. Minimal repro is a handful of lines:
import React from "react";
import ReactDOM from "react-dom";
import Helmet from "react-helmet";

function App() {
  const string = "string";
  return (
    <div>
      <Helmet titleTemplate="%s - template">
        <title>'{string}' not string</title>
      </Helmet>
      butts
    </div>
  );
}

https://nbolv.codesandbox.io/
https://codesandbox.io/s/nbolv

Nevermind! I hunted it down. master appears to have a fix—but hasn't been backported to 5.2.1. Opened a PR.

As a temp solution, replacing <title> contents with a single string seems to solve the problem:
<Helmet>
    <title>{`${summary.name} collection`}</title>
</Helmet>

If this has been solved, why has it not been resolved....?
If this has not been solved, why not?

I had updated the version to  6.1.0 and the issue is resolved


Gray screen of death on release apk

My app works fine in debug mode, but when I run it in release mode it goes into gray screen of death and only following logs are visible.
[ +553 ms] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[        ] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[        ] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[        ] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[   +1 ms] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[        ] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
[        ] I/flutter ( 3598): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'

did you ever find a solution to this?  I'm having the same issue (it appears) in my apps release mode.

did you ever find a solution to this?  I'm having the same issue (it appears) in my apps release mode.

The problem is from Flutter layout. If you are getting a layout red error in debug, that will turn into a gray screen in production.

so what is the solution?


isFeatureEnabled now returns true if multivariant flag

:bulb: Motivation and Context
By doing https://github.com/PostHog/posthog-android/pull/41 I noticed that isFeatureEnabled is also wrong.
I also noticed that the iOS SDK never returns false if a flag has a false value.
https://github.com/PostHog/posthog-ios/blob/9298825fe26899a58b976d400254e0b050daa578/PostHog/Classes/PHGPostHog.m#L317
Is it a bug on the iOS SDK I believe, right?
:green_heart: How did you test it?
:pencil: Checklist

[X] I reviewed the submitted code.
[X] I added tests to verify the changes.
[ ] I updated the docs if needed.
[X] No breaking change or entry added to the changelog.

Actually, I am a bit confused, the decide API does not return the disabled feature flags.
By disabled I mean this:

so if the flag is within the response payload, it is enabled, always, then the iOS implementation is correct.
Should isFeatureEnabled return false if the flag is within the payload but its value is false? on iOS this is never the case, it will always return true.
The older version of the Android SDK does what this PR is aiming to do.
@neilkakkar mind explaining?

Decide returns all enabled flags, correct.
But just because a flag is enabled doesn't mean that the API will always return true. For example, if you have a filter on Country = X on the flag, the API will return false if you're outside country X.
Same for, say, if the rollout % is not 100%.

Should isFeatureEnabled return false if the flag is within the payload but its value is false?

Correct, and nice finding!


tracing(consensus-engine): trace on new payload & downgrade canonicalizing log

Add trace on new payload

Codecov Report

Merging #1944 (fa2cb4a) into main (8e4e5e0) will decrease coverage by 57.52%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1944       +/-   ##
===========================================
- Coverage   73.13%   15.62%   -57.52%
===========================================
  Files         424      424
  Lines       51860    51880       +20
===========================================
- Hits        37930     8107    -29823
- Misses      13930    43773    +29843

Flag
Coverage Δ

integration-tests
15.62% <0.00%> (-3.85%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/consensus/beacon/src/engine/mod.rs
0.00% <0.00%> (-97.15%)
:arrow_down:

... and 315 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


How to bind ion-autocomplete from cordova-sqlite db or from server

Hi,
I'm trying to bind the autocomplete items from Cordova-SQLite database in my ionic app. In items-method I have the code to fetch the data from SQLite db, insert items to an array and then pass it to the items array. But the process is not waiting for the data to be prepared from SQLite and returns a null array. Hence resulting autocomplete not to show any items.
Here is my sample code.
$scope.getEmployeeItems = function (query) {
if (query) {
var selectEmployeeQuery = "SELECT * FROM Employee";
$cordovaSQLite.execute(db, selectEmployeeQuery, []).then(function (res) {
alert(res.rows.length);
if (res.rows.length > 0) {
var EmployeeData = [];
for (var i = 0; i < res.rows.length; i++) {
... Code to loop through and insert to an array...
EmployeeData .push(employee);
}
return {
items: EmployeeData
};
}
}, function (err) {
alert('Error - ' + JSON.stringify(err));
});
}
return { items: [] };
}
Is anywhere i'm going wrong? Else please provide me a solution how to bind autocomplete from SQLite. Thank you

Hi @rintuzi123,
sorry for my late reply but I was in vacations. The problem is that you do not return the promise of the SQLite call. You need to change the code such that you return a promise which then returns the array. Maybe this will work but I did not test it:
                    $scope.getEmployeeItems = function (query) {
                        if (query) {
                            var selectEmployeeQuery = "SELECT * FROM Employee";
                            return $cordovaSQLite.execute(db, selectEmployeeQuery, []).then(function (res) {
                                alert(res.rows.length);
                                if (res.rows.length > 0) {
                                    var EmployeeData = [];
                                    for (var i = 0; i < res.rows.length; i++) {
                                    ... Code to loop through and insert to an array...
                                        EmployeeData .push(employee);
                                    }
                                    return {
                                        items: EmployeeData
                                    };
                                }
                            }, function (err) {
                                alert('Error - ' + JSON.stringify(err));
                            });
                        }
                        return { items: [] };
                    }

Could you please try that and come back to me if it worked?
Thanks and regards,
Guy

Thanks for your rply Guy. Now I updated ionic to v1.2.4. ion-autocomplete not working in this version of ionic. I was previously using ionic v1.1.0 and It was working fine. But now in v1.2.4, it's not working. Is it not compatible with v1.2.4 or I'm doing wrong somewhere? Plz help how to make it work. Thank you!!

Hi @rintuzi123,
well as you see in the compatibility table in the readme the component is not tested on the 1.2.* version. There is already an issue there #141. So please downgrade to a compatible version and try again or you need to wait till I test it with the new version. But other people are using it with the 1.2.* version and it runs properly. Can you please add the error to the #141 issue?
Thanks and regards,
Guy

Hi @rintuzi123,
please check this comment here: https://github.com/guylabs/ion-autocomplete/issues/141#issuecomment-180766484
And please add the error to the #141 issue if you still have problems running it with 1.2.4.
Thanks and regards,
Guy

Hi Guy. Previously I was using phonegap build to build the apk, but now I'm porting my app to be built using Ionic CLI, for which I'm modifying my code again from scratch, due to which I missed some references to ion-autocomplete. Now, it works fine.
Can you tell me how to disable or make readonly the ion-autocomplete.
Thank you for your time...

@rintuzi123 What do you mean by disable or make readonly?

On clicking the textbox it's popping up the ion-autocomplete enabling us to search for items and select. But in my app I have one page having ion-autocomplete and the same page is used for view-only purpose, So, I need to make all the controls readonly or disabled. How to do that for ion-autocomplete?

Hi @rintuzi123,
what you can do is that you set the input where you define the ion-autocomplete directive to readonly and then set the manage-externally="true" such that the onClick method is not called when the user clicks on the input field.
Does this workout for you?
Thanks and regards,
Guy

Hi @guylabs,
I couldn't get you. Can you provide any sample code?
Thanks...

Hi @rintuzi123,
I mean something like this:
<input ion-autocomplete readonly="readonly" manage-externally="true" ... />

I omitted most config options in the example above.
Thanks and regards,
Guy

Hi,
as there was no activity for some weeks I will close the issue. If there is still something you can add a comment and reopen it.
I hope it works now.
Thanks and regards,
Guy

Hi @guylabs. In reference to this comment.
I was also having trouble with cordovaSQLite and this plugin and I stumbled across this issue. I tried your code, but it did not work for me. I'm posting my solution in hopes that it will help someone:
<input ion-autocomplete type="text" readonly="readonly" autocomplete="off" placeholder="Choose brand" items-method="getBrandByQuery(query)" max-selected-items="1" item-view-value-key="BrandName" item-value-key="BrandId" items-method-value-key="items" />

$scope.getBrandByQuery = function (query) {
        var sqlQuery = "SELECT BrandId, BrandName FROM Brands WHERE BrandName like '%" + query + "%'";
        console.log("controller : getBrandByQuery() : sqlQuery : " + sqlQuery);
        var d = $q.defer();
        $cordovaSQLite.execute(db, sqlQuery, []).then(function (res) {
            if (res.rows.length > 0) {
                $scope.brandSearchResult = [];
                for (var i = 0; i < res.rows.length; i++) {
                    console.log("sessionCtrl : getShishaBrandByQuery() : queryResults : " + res.rows.item(i).BrandId + " " + res.rows.item(i).BrandName);
                    $scope.brandSearchResult.push({ BrandId: res.rows.item(i).BrandId, BrandName: res.rows.item(i).BrandName });
                }
                d.resolve({ items: $scope.brandSearchResult });
            } else {
                console.log("sessionCtrl : getBrandByQuery() : No results found");
                d.resolve( { items: [] } );
            }
        }, function (err) {
            console.error(err);
        });
        return d.promise;
    };

Thank you!

Hi @inchcrest,
thanks a lot for your contribution! I do not have experience with the cordovaSQLite service but with a promise of a deferred object it will always work. Nice!
Thanks and regards,
Guy

Hey @inchcrest I'm trying to implement your code but I get this error:

Controller 'ngModel', required by directive 'ionAutocomplete', can't be found!

Of course i've installed the lib with bower, included the js and css in index.html, added the dependency in the angular.module..

 I've just missed binding the model...


Add missing documentation

Summary

Quality Checklist

[ ] New features are fully tested (No matter how much Coverage Karma you have)
[ ] [v0.2 onward] New features are included in the documentation
[ ] [v0.2 onward] Breaking changes are documented with clear instructions of what

Coverage Karma

[ ] If your PR decreases test coverage, do you feel you have built enough Coverage Karma* to justify it?

*Coverage Karma can be earned by disproportionally increasing test coverage in the rest of your contributions.
It's an honesty policy - you keep count of your own.

Codecov Report

Merging #33 (7948607) into main (a261bc6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   94.69%   94.69%
=======================================
  Files           3        3
  Lines         245      245
=======================================
  Hits          232      232
  Misses         13       13

Impacted Files
Coverage Δ

conventional_commits/check_semantic_version.py
93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a261bc6...7948607. Read the comment docs.


Displaying broken characters in console

VSCode Version: 1.17.0
OS Version: Win10 x64

Steps to Reproduce:

msbuild

(Code Page 950)

If I change the codepage to CP437, VC++ will output english message and everything works fine

duplicated https://github.com/Microsoft/vscode/issues/35969

Closing as a duplicate of #35969


should we consider the impact of  using undo_log on the behavior of DB?

I think there is a preformance loss of db server by inserting,selecting,and deleting the undo log data when handling a large of business data, and cause extra hard disk space occupation temporary.So there should be a guidance or a warning or sth to remind users to know the impact and do some db optimization such as tablespace design and  more hard disk space application before using FESCAR,or do some optimization for FESCAR by desinging other ways to record undo log data.

Yes.you are right.there should be a guidance to let user know what's the requirement for running of fescar.and we'll consider your suggestion.


Cargo wrote a circular dependency to crates index on cargo publish

See https://github.com/rust-lang/crates.io-index/commit/89e90c19adfdc3ba19946b939fc5880bf568afba for the resulting commit.
The actual repo doesn't have this circular dependency in its Cargo.toml.

Replicated through the following steps:

Increment minor version number of crate in Cargo.toml
Commit, push, and cargo publish
Discover that the crate is now dependent on itself twice: https://github.com/rust-lang/crates.io-index/commit/1e3865e52f2ffe95a169781668410f09525f49ad

A few more examples from IRC:
https://github.com/rust-lang/crates.io-index/commit/acc71e3c3d26ad4bb1eaa7b3328e272ad2b45d63
https://github.com/rust-lang/crates.io-index/commit/b8e3b3ec17c50751b48a23abf7c7c9f83b4f1e34

Likely related to rust-lang/crates.io#653.

I rolled back the deploy, so it should be fixed in the live site. Triaging the index now.

Me too: https://github.com/rust-lang/crates.io-index/commit/930fb19a34ce9854374cd3634ea51a9998aa384a

The first bad index commit is https://github.com/rust-lang/crates.io-index/commit/edaaa4b26c2839decce640f743dc9baeed499edb
The last bad index commit is https://github.com/rust-lang/crates.io-index/commit/d34b8b7007497508b3068b1a6537cfccbc801393

Before deploying crates.io today, it was running the code at 2772cbc. I deployed 1e02ca3 at 2017/03/29 12:14:47 -0400, which is when the bad index commits started happening, so the problem is somewhere in between there.
Going to work on fixing the files in the index before fixing the code though.

Crates and versions affected:
d34b8b7 Updating crate ethabi#1.0.3
1d8a77b Updating crate newton#0.3.2
930fb19 Updating crate serde_roundtrip_derive#0.1.1
717471e Updating crate gauc#0.2.0
b8e3b3e Updating crate git-workarea#2.0.1
caae577 Updating crate serde_roundtrip_derive#0.1.0
1e3865e Updating crate finite-fields#0.10.1
89e90c1 Updating crate finite-fields#0.10.0
8e46e86 Updating crate mediumvec#1.0.0
38c6da0 Updating crate pretty_assertions#0.1.1
f4b7009 Updating crate thrussh#0.10.0
a5e2d3f Updating crate sovrin-client#0.1.0-19
bd9e9fe Updating crate lichen#0.1.0
acc71e3 Updating crate ethabi#1.0.2
4197c7f Updating crate easybench#0.1.1
923da31 Updating crate devicemapper#0.4.1
4f1b80b Updating crate gleam#0.4.2
e97a115 Updating crate u256#0.1.0
edaaa4b Updating crate rustbreak#1.2.0

Note that crates.io's database was not affected, so the dependencies listed for these crates on crates.io is correct

The following crates don't have any dependencies so their index files aren't affected by this bug:

mediumvec#1.0.0
easybench#0.1.1
u256#0.1.0
lichen#0.1.0

I have pushed https://github.com/rust-lang/crates.io-index/commit/9917d828acd2e091c9e87bba0e300d9199e3fd13 that should fix all the affected crate versions.
Please let me know if there are any remaining issues from this. Thank you all for your patience, and I'm sorry for the inconvenience.

Thanks @carols10cents ! Works for me.

Thanks!

Thanks for the fix @carols10cents! Sounds like this is handled so I'm going to close.


Synchronize complexfunc.h with the Halide PR

Note to self: merge is pending a fix to the "multiply a negation" issue.


Add a scrollable embed system

TODO: Refactor all modules currently in use to new system:

[ ] Karma
[ ] Tagging


Heroku demo is broken

Hi, the Heroku demo at http://react-shadow.herokuapp.com/ is currently HTTP 503.

Thanks @rjoonas I'm currently over my quota for Heroku – will resume on 1st Nov.
Either I need to split some out into other accounts, or put my hand in my pocket and pay for a hobbyist plan 👍


Strip Replies Not Working As Expected

Hi!
First off, amazing piece of software! It's been a joy to implement and work with!
We only ran into one bug and it involves stripping the replies from an incoming email. I know this can be a complicated task, but it doesn't seem to be working when we have Strip Replies on an API Route selected:

Is there are some attempted regex solutions here: https://stackoverflow.com/questions/278788/parse-email-content-from-quoted-reply. Maybe if there was a way to attempt to remove it and pass it as another parameter for error checking?
Thanks again for making Postal! It really is a joy to work with!

Presuming the strip replies functionality is being triggered in your case, do your messages match any of the formats listed in https://github.com/atech/postal/blob/master/lib/postal/reply_separator.rb ?

@willpower232 thanks for the response! I realized I was looking at the HTML email and not the plain body. This is not a bug, it's working as expected!


Create Player Attack Sounds

Allows the player to play a selected sound at the start of the player attack animation. This can can be changed, adjusted in volume, muted for a specific duration, enabled for incoming attacks, and completely muted while not tabbed into the game.

Your build is failing because your plugin file doesn't meet the naming requirements. See here for more information.

Closing due to inactivity. Feel free to re-open this PR if you fix the build issues.


Style/signup

https://www.loom.com/share/871cf0a1a1f043d3a50b9a4f554c21a4
Description
I created a new branch to include better responsiveness on the Signup.js form.  It seems there was a media query that made the pictures super big under 880 px width.   I converted that to look better and also removed unnecessary styling to be more concise for future developers.
Contributors
@danielaescutia07
Fixes # (issue)
responsiveness for the Signup.js page and removed unnecessary styling.
Type of change
Please delete options that are not relevant.

[x ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[x ] This change requires a documentation update

Checklist:

[ x] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[x ] I have removed unnecessary comments/console logs from my code
[x ] I have made corresponding changes to the documentation if necessary (optional)
[x ] My changes generate no new warnings
[x ] I have checked my code and corrected any misspellings
[x ] No duplicate code left within changed files
[x ] Size of pull request kept to a minimum
[x ] Pull request description clearly describes changes made & motivations for said changes

Definitely a needed change! Looks great!


Language standardisation of 2019

We're going to go off this sheet and the text should just be in master for all platforms.
https://docs.google.com/spreadsheets/d/1DmXFCIFhDRjRg60ENQo_cSHVjjW7qUzWMVtjOZzkysQ/edit#gid=1527876900
Summation of text changes
On the first page

[x] Change 13 to 16
[x] Add to the tick box, "Read more about our Privacy Policy here. [https://www.raspberrypi.org/privacy/]"

On the second page

[ ] Change the attend questions and answers

[x] Change the 3rd gender option

[ ] Make the phone hint<PHONE_NUMBER>

Confirmation Page

[ ] Change in to at

Note
Since there's several changes it's hard to review this stuff without all the different issues merged. So this will need a review once done by Conor to make sure he has not messed up, assuming he can kick it up locally.

PR : https://github.com/CoderDojo/coolest-platform/pull/132

Phone number hint still needs to be changed doesn't it?


Add capability to use blake2_256_digest alone for validation and fix typo

This adds the ability for uploaders to use blake2_256_digest alone as a valid digest on publishing artifacts and fix a typo in the testing which was errantly passing due to the nature of "sdist" != None being logically equivalent to "sdist" != "bdist_wheel" which is the intended test.  Documentation updated to match.

Whoops, forgot to run the lint after my doc update.  Will be updating shortly

Hey Jeff, thanks for the PR. Could you maybe add some detail about why uploaders would prefer to use blake2_256_digest instead?
Since our upload API is not standardized but sort of a de-facto standard, I'm generally hesitant to make changes here, but since this is a fully backwards-compatible change, I think we could add it if there was reasonable motivation for it.

Looked like an unintentional miss given the surrounding code, so it felt
like a reasonable low-impact first code change to warehouse.  I would
likely find it just as helpful to have a comment on why its support doesn't
match the other hash types if it was intentionally left out as I found it
while doing some diving prior to an attempt at PEP 658.  So I took it as
simply one of the many implementation/documentation gaps that I could also
use as a small but substantive change to test parts of my development setup
prior to potentially doing more substantial PRs in the future.
On Mon, May 1, 2023 at 10:11 AM Dustin Ingram @.***>
wrote:

Hey Jeff, thanks for the PR. Could you maybe add some detail about why
uploaders would prefer to use blake2_256_digest instead?
Since our upload API is not standardized but sort of a de-facto standard,
I'm generally hesitant to make changes here, but since this is a fully
backwards-compatible change, I think we could add it if there was
reasonable motivation for it.
—
Reply to this email directly, view it on GitHub
https://github.com/pypi/warehouse/pull/13528#issuecomment-1529965586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYCRPJKOR6UY5H7NRL4YWLXD7VCPANCNFSM6AAAAAAXNBGKFM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Cleanup SCF debug info

Move extra SCF information (max verbose) into its own sub-dict due to potential overlap with main SCF info (fermi energy vs fermi_energy) if all dictionary keys eventually normalised.

Are the "debug information" Fermi energy and the calculated/reported Fermi energy two different pieces of information? I see they are reported to different precision in the test data.
I also see that the test data has debug information for one SCF step but not the next, is that typical?
How nicely does this interact with finite-basis corrections, which add on a few mini-SCFs for each "main" singlepoint SCF? Are they another dict item?

The debug fermi and the final fermi should be the same (but to different precision), but sometimes I think it might make multiple iterations and potentially backtrack in the solver in more complex cases.
You're right, the debug info is attached to the wrong cycle.
Not sure on the mini-scfs, at the moment, this should be general for most SCFs (though it really depends how much we expect someone to want to extract the debug info here, it's only available on verbosity >3 i.e. Phil. This is reasonably low priority, hence the separation from main SCF info)


Revert "chore: update buildkit to master@9d84cdcda004"

This reverts #6428 :cry:
Since updating, we've seen increased CI failures from:

Lots of timeouts while running tests, with gaps in the logs that may indicate a potential deadlock
https://github.com/dagger/dagger/issues/6452 (though this mayy be unrelated)

I'll investigate, and follow-up/

😢 let me know if there's anything related to engine or cli!


selenium.common.exceptions.ElementNotVisibleException: Message: element not visible

>>> Login with your credential
>>> Downloading course: git-in-depth
Retrieving: git-in-depth/Git_In-Depth/Introduction
Traceback (most recent call last):
  File "frontendmasters-dl.py", line 24, in <module>
    downloader()
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "frontendmasters-dl.py", line 17, in downloader
    spider.download(course, high_resolution, video_per_video)
  File "/Users/andrepadez/Downloads/frontendmasters-dl/extractor/spider.py", line 55, in download
    course_downloadbale = self._get_downloadable_links(course_detailed_list, high_resolution, video_per_video)
  File "/Users/andrepadez/Downloads/frontendmasters-dl/extractor/spider.py", line 181, in _get_downloadable_links
    resolution_button.click()
  File "/usr/local/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 80, in click
    self._execute(Command.CLICK_ELEMENT)
  File "/usr/local/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 628, in _execute
    return self._parent.execute(command, params)
  File "/usr/local/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 314, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotVisibleException: Message: element not visible
  (Session info: headless chrome=67.0.3396.87)
  (Driver info: chromedriver=2.40.565386 (45a059dc425e08165f9a10324bd1380cc13ca363),platform=Mac OS X 10.13.5 x86_64)

this happens when flag --high-resolution is on

I believe your PR just fixed this issue. Thanks @andrepadez.

Really happy to help :)

Thanks for the PR the current script is so troublesome and I'm thinking to start from scratch again by using APIs instead.

oh, i was actually thinking of doing a bit more work on it, just trying to find someone with python skills to help me out

😅 i do not have a subscription and i do not have a planed date for it yet, and i plan to write the "new" script using JS instead.


When onServerSearch is enabled, there is no way to make a way to avoid many requests

Hi,
When onServerSearch is enabled, there is no way to make the function wait for example few ms to not make many requests while the user is typing, nor a minimum number of char to fire the search.
For example to search for :
test2022 the script will fire 8 requests to search for the word, while if we have a waiting time until the user finish typing, it will fire only one search request.
Hope I could explain the problem well enough :)

@stefchrif I will add a property to configure the waiting time. Thanks for the suggestion.

@stefchrif this issue has been fixed by @Venkataramanan21 in the release v1.0.35


feat(demo) improve server data demo

Replaced "query" only demo with "query + mutation" demo.
Also introduced trpc to demonstrate how server loader prefetch would look like using trpc caller.

Superseded by

https://github.com/hi-ogawa/vite-plugins/pull/31

However, trpc caller to achieve "uniform" treatment on ssr prefetch and client fetch is very intersting, so just leave it as POC PR.


FileNotFoundError: [WinError 2] The system cannot find the file specified

Computer Info

OS Windows 11
Python 3.10.2
tzk version 0.1.4
git version 2.35.1.windows.2
node v16.13.2

Details
I get the error found below whenever I run tzk init or tzk convert.
I tried updating all dependencies found in the documentation.
I tried uninstalling all dependencies and reinstalling.
I am out of ideas, so I am posting here in hopes someone knows what I am doing wrong.
Error
C:\Users\JiN\wiki>tzk init
tzk: Creating new tzk_config.py...
tzk: Creating new package.json...
tzk: Installing npm packages from package.json...
Traceback (most recent call last):
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\Scripts\tzk.exe\__main__.py", line 7, in <module>
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\site-packages\tzk\__main__.py", line 424, in launch
    args._cls().execute(args)
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\site-packages\tzk\__main__.py", line 157, in execute
    tw.install(args.wiki_name, args.tiddlywiki_version_spec, args.author)
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\site-packages\tzk\tw.py", line 192, in install
    _init_npm(wiki_name, tw_version_spec, author)
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\site-packages\tzk\tw.py", line 100, in _init_npm
    subprocess.check_call(("npm", "install"))
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 364, in check_call
    retcode = call(*popenargs, **kwargs)
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 345, in call
    with Popen(*popenargs, **kwargs) as p:
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 966, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1435, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

As a work around I installed TZK using WSL.

  File "C:\Users\JiN\AppData\Local\Programs\Python\Python310\lib\site-packages\tzk\tw.py", line 100, in _init_npm
    subprocess.check_call(("npm", "install"))
...
FileNotFoundError: [WinError 2] The system cannot find the file specified

It sounds like npm isn't on your $PATH – are you sure you ran npm --version as suggested in the documentation to check that it was installed? It's possible you might need to reboot your computer after installing to get your environment variables fully updated.
If you run where.exe npm, what's the output?

npm version:
8.4.1
where.exe npm output:
C:\Program Files\nodejs\npm
C:\Program Files\nodejs\npm.cmd
C:\Users\JiN\AppData\Roaming\npm\npm
C:\Users\JiN\AppData\Roaming\npm\npm.cmd

I hacked around a bit and got tzk init and tzk listen to complete.
I don't know python, so to be honest I am not sure, what the code I added does exactly.
But, I traced the first error back to, line 17 of tw.py,  "return subprocess.check_output(("npm", "bin"), text=True).strip()".
After Googling that exact line of code on StackOverflow, I found someone who mention adding `shell=True'.
So I added `shell=True' to all the subprocesses, one at a time watching the error log.
This fixed most issues, but the whoami() function was finding "masterpc\jin" and the backslash was making the 'package.json' invalid. So, I just hardcoded jin.
Full tw.py with changes.
https://gist.github.com/Jestdie/6e526858f517a5ea4974cbe2c05ca8b3

I'm guessing you somehow have your environment set up so that npm is only on the path when you're in a shell, and not on the rest of your PC – I'm not familiar enough with this part of Windows to explain exactly how that would have gotten set up, but I know it's possible (for instance, maybe it could be set up within the shell initialization file?).
shell=True can introduce security vulnerabilities, so it's not a good idea to add as a matter of course – but here you should be pretty much fine since the command to be run is hard-coded (someone could still add an alias for npm in your shell initialization file that did something nasty, but if they had access to do that, they presumably could just as well change your PATH and shell=True would be a moot point).
As for the whoami() part, you should be able to put it back to the original implementation now that you have init completed, since you'll now have an author configured within your tzk_config.py.
On Sat, Feb 5, 2022, at 15:59, Jestdie wrote:

I hacked around a bit and got tzk init and tzk listen to complete.
I don't know python, so to be honest I am not sure, what the code I added does exactly.
But, I traced the first error back to, line 17 of tw.py, "return subprocess.check_output(("npm", "bin"), text=True).strip()".
After Googling that exact line of code on StackOverflow, I found someone who mention adding `shell=True'.
So I added `shell=True' to all the subprocesses, one at a time watching the error log.
This fixed most issues, but the whoami() function was finding "masterpc\jin" and the backslash was making the 'package.json' invalid. So, I just hardcoded jin.
Full tw.py with changes.
https://gist.github.com/Jestdie/6e526858f517a5ea4974cbe2c05ca8b3
—
Reply to this email directly, view it on GitHub https://github.com/sobjornstad/tzk/issues/2#issuecomment-1030706189, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARUZRVYFY4X23PZQEVDFMDUZWMVDANCNFSM5NTPHSFA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>

I think this is related to the way subprocess works on windows, which expects an executable, or more specifically a "Win32 application". When I run the following in the python interpreter (launched from powershell or cmd):
>>> subprocess.run(("C:\\Program Files\\nodejs\\npm", "bin"))

I get:
OSError: [WinError 193] %1 is not a valid Win32 application

However, if I use run npm help npm using (Win+R) it opens the help page, so it's not a path issue. Additionally the following command is successful when run in the python interpreter:
>>> subprocess.check_output(("node", "--version"))

And node and npm are in the same folder on my computer.
Solutions
I haven't been able to figure out a solution that doesn't involve editing the tw.py file but there seems to a couple of ways to do it:
shell=True works but comes with security concerns as @sobjornstad said. It's also possible to use ("pwsh", "-c") as the first two commands, but I'm guessing that has the same security issues? (I don't actually know)
subprocess.check_output(("npm", "bin"), shell=True)

Alternatively, using npm.cmd instead of npm, as in:
return  subprocess.check_output(("npm.cmd", "bin"), text=True).strip()

However you then need to adjust the tiddlywiki init command, so it becomes:
subprocess.check_call(("npx.cmd", "tiddlywiki", "--init", "tzk"))

There are a few other things you need to change to get this all working well on windows without shell=True. I think using WSL is probably the easiest way to do this without having to change a bunch of things.

Curious, how exactly did you install npm that this isn't working for you?

I installed the "OpenJS.NodeJS" package using winget. The problem seems common though, I found a lot of people asking online about the same error, mostly the answer/solution they found was to use shell=True.
I edited a version of tw.py that works on my Windows machine without using shell=True.

I just noticed this:

However, if I use run npm help npm using (Win+R) it opens the help page, so it's not a path issue.

The Run dialog also uses a registry key called “App Paths” in addition to the system path, so this is not a good way to test if something is on your PATH. Does it also work from cmd?

I'm about to head out for a holiday weekend here, but I can try to play around with this on my Windows machine next week and see if I can reproduce the issue.

It works from both cmd and powershell, and the installation folder is in the path. Plus, even when I referenced the exact path, I got that OSError. I'll admit to not understanding the underlying mechanics of that.

Same issue two years later - sent an email but haven't tried fix(es) proposed above
Confirmed npm installed and on $PATH (Windows Environment Variables)


New home page design

Gorgeous.

@frechg, do you disagree with any of the Hound comments? If you do we can configure Hound in another PR.

This looks awesome! Great job, :+1:

@salbertson no the Hound comments are good.

do it


[Feature Req] Option to read flash and download read data

Since now all features of esptool.py are implemented (or being implemented?), I would really like to see an option to image/backup the flash of an ESP.
Either the entire flash, or sections of it.
It would be extremely nice if it was possible to read the partition info and thus allow for downloading named sections like app0, the file system area, etc. with bonus points to have the esp-web-tools manifest included.
But just imaging/cloning of a device would already be a great feature to have.

esptool.js is meant to be a full featured port of esptool.py. esptool.js is one of the many libraries used by ESP Web Tools.
The goal of ESP Web Tools is still to empower firmware authors to offer an easy way to their users to install and manage devices.
What you're looking for sounds like something that can be made with esptool.js but falls out of scope for ESP Web Tools.

OK, I get it that it may be out of (the intended) scope of the tool.
But maybe a suggested use case can persuade you to consider?
For example for helping to debug cases where flash parameters are not working and people may not be experienced enough to install and run esptool.py?
Or to backup a unit to test some other firmware?

I think that sounds like it should be done by another tool powered by esptool.js. I don't want to add feature creep to ESP Web Tools. Every extra feature might confuse the user and end up in not ending up with running your firmware.


attempt to fix #114, but it's not working...

so to fix #114 :
I tried to do the inference keeping the batch always the same size B,T
but this is not resolving the issue.
unfortunately I can't spare time to keep looking at this tonight (until maybe very late), so I'm keeping this unresolved for now.
I suspect there is something wrong with kernel5, we did not check it properly when we merged, blinded by the speed it offered sigh.

If there is a bug with kernel5, I don't really understand how we're lucking out that test_gpt2.cu reports no issues, and the logits and the loss (the output of the forward pass) match expected values.

I attempted to test according to the commits in this PR, but I still encountered 'an illegal memory access was encountered.'
[System]
Device 0: NVIDIA GeForce GTX 1650 Ti
enable_tf32: 0
[GPT-2]
max_seq_len: 1024
vocab_size: 50257
num_layers: 12
num_heads: 12
channels: 768
num_parameters: 124439808
train dataset num_batches: 74
val dataset num_batches: 8
batch size: 4
sequence length: 1024
val_num_batches: 10
num_activations:<PHONE_NUMBER>
val loss 4.517293
step 0: train loss 4.367856 (took 12696.786693 ms)
step 1: train loss 4.406481 (took 12592.453470 ms)
step 2: train loss 4.484837 (took 12581.640492 ms)
step 3: train loss 4.345325 (took 12785.257593 ms)
step 4: train loss 4.043289 (took 12699.167329 ms)
step 5: train loss 4.229304 (took 12977.969745 ms)
step 6: train loss 4.174998 (took 13413.872346 ms)
step 7: train loss 4.207466 (took 13131.313881 ms)
step 8: train loss 4.127153 (took 13543.845417 ms)
step 9: train loss 4.220581 (took 13296.718636 ms)
val loss 4.517293
step 10: train loss 4.345143 (took 13550.681370 ms)
step 11: train loss 4.245717 (took 13489.289869 ms)
step 12: train loss 4.160386 (took 13409.223163 ms)
step 13: train loss 3.989360 (took 13403.222145 ms)
step 14: train loss 4.305948 (took 13426.626539 ms)
step 15: train loss 4.340422 (took 13489.533329 ms)
step 16: train loss 4.304480 (took 13612.480865 ms)
step 17: train loss 4.424025 (took 13379.971251 ms)
step 18: train loss 4.314513 (took 13098.182640 ms)
step 19: train loss 4.287313 (took 13259.752212 ms)
val loss 4.517293
[CUDA ERROR] at file train_gpt2.cu:1241:
an illegal memory access was encountered

@karpathy
OK, so if I comment out enough stuff, so that we don't run the validation part, and immediately jump into generation with a fixed T=64, compute-sanitizer actually does report some error:
========= Invalid __global__ read of size 4 bytes
=========     at encoder_forward_kernel2(float *, int *, float *, float *, int, int, int)+0x410 in train_gpt2.cu:89
=========     by thread (0,0,0) in block (930,0,0)

========= Invalid __global__ read of size 4 bytes
=========     at encoder_forward_kernel2(float *, int *, float *, float *, int, int, int)+0x410 in train_gpt2.cu:89
=========     by thread (1,0,0) in block (930,0,0)
=========     Address 0x7f4676000004 is out of bounds
=========     and is 522 190 853 bytes after the nearest allocation at 0x7f4656600000 of size 8 388 608 bytes

@karpathy
I think it's a padding problem, see #122