Server 2008 SP2

This article says it is supported but when I attempt to install Mobility Services on a 2008 SP2 server it says "unsupported." I need to know what the actual truth is here. Please let me know. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1a3829f2-aa5b-37e9-f188-211529fe741e
Version Independent ID: 3955f9e4-eb90-8aae-37e8-bbf1215334e7
Content: Migrate on-premises Windows Server 2008 servers to Azure with Azure Site Recovery
Content Source: articles/site-recovery/migrate-tutorial-windows-server-2008.md
Service: site-recovery
GitHub Login: @bsiva
Microsoft Alias: bsiva

@crshovrd41 Hi, can you confirm that you're trying to install Mobility service on WS 2008 R2 with latest updates (Standard, Enterprise, Datacenter). Also can you check that VSS service is running. thx

Hey, thanks for the reply. I was attempting on 2008 SP2 per the article.
Above it clearly states this is supported on 2008 SP2, which I don’t
believe is actually the case. Can you please confirm?
On Wed, Sep 26, 2018 at 02:27 Rayne Wiselman<EMAIL_ADDRESS>wrote:

@crshovrd41 https://github.com/crshovrd41 Hi, can you confirm that
you're trying to install Mobility service on WS 2008 R2 with latest updates
(Standard, Enterprise, Datacenter). Also can you check that VSS service is
running. thx
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/15620#issuecomment-424648515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiEr-m8KeRmKTpA5RtK5X3F7lrQ3SWeGks5ue0iQgaJpZM4W5Y8l
.

--
Sent from your iPhone

@crshovrd41 Hi. It's supported on WS 2008 R2 (Standard, Enterprise, Datacenter) running the latest updates.
The VSS service should be running, and the version of the Mobility service you're installing is <IP_ADDRESS> onwards.

That makes sense why it doesn’t work. However, have you reviewed the
documentation in question? It specifically states Server 2008 SP2 in the
matrix. IMHO, I would recommend editing the documentation so as to not have
to have this conversation again.
On Wed, Sep 26, 2018 at 05:57 Rayne Wiselman<EMAIL_ADDRESS>wrote:

@crshovrd41 https://github.com/crshovrd41 Hi. It's supported on WS 2008
R2 (Standard, Enterprise, Datacenter) running the latest updates.
The VSS service should be running, and the version of the Mobility service
you're installing is <IP_ADDRESS> onwards.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/15620#issuecomment-424705050,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiEr-pRJgj_w2TIp43CPWbp9SGa7wMboks5ue3m9gaJpZM4W5Y8l
.

--
Sent from your iPhone

@crshovrd41 Can you let me know what was missing in your configuration so I can capture it in the article? thx

All I’m asking is for someone to please fix the documentation to be
accurate. Cool?
On Wed, Sep 26, 2018 at 06:07 Rayne Wiselman<EMAIL_ADDRESS>wrote:

@crshovrd41 https://github.com/crshovrd41 Can you let me know what was
missing in your configuration so I can capture it in the article? thx
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/15620#issuecomment-424708189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiEr-h966_mj96ujOF_akxaOdsT2ADsUks5ue3wpgaJpZM4W5Y8l
.

--
Sent from your iPhone

@crshovrd41 Absolutely. I'm trying to figure out what needs fixing in the article. The info in there is accurate, but I'd like to figure out what isn't clear based on your feedback. Thanks!

Please review the screen shot I uploaded. The link is in the content section at the top of this issue.

@crshovrd41 The screenshot info is accurate. Windows Server 2008 SP2 - 32 bit and 64 bit(IA-32 and x86-64) (Standard, Enterprise, Datacenter) supported for migration of VMware VMs to Azure.

OS should be running the latest updates for it.
Mobility service version should be <IP_ADDRESS> or later. Latest version is available in the portal, or latest update is here - https://support.microsoft.com/en-us/help/4460079/update-rollup-28-for-azure-site-recovery
There are a number of other limitations and requirements that are documented in https://docs.microsoft.com/en-us/azure/site-recovery/migrate-tutorial-windows-server-2008#limitations-and-known-issues

If these prerequisites are OK and install isn't working, can you let me know, and I'll follow up with the engineering team. Thx

@rayne-wiselman Fantastic! I will try with the newest installer again and let you know. Thank you!

@crshovrd41 Yes, let me know. In the meantime I'll sharpen up the text in that article so that the prereqs are a bit clearer.

@rayne-wiselman This part: "The servers being migrated should have .NET Framework 3.5 Service Pack 1 for the mobility service to work." I just attempted to install it per the update rollup 28 link and it said it required 4.6.2 or higher. I'm still working on the rest of the install.

Instructions for installing the Mobility service manually are here - https://docs.microsoft.com/en-us/azure/site-recovery/vmware-azure-install-mobility-service#install-mobility-service-manually-by-using-the-gui.

@rayne-wiselman Are you saying I'm doing something wrong by getting prompted to install .NET 4.6.2 when the article clearly states 3.5 SP1? I'm confused.

@crshovrd41 No, just providing an alternative option. Re the .NET version requirement I'm checking with the team now

@rayne-wiselman Got it! Thanks! So, I installed .NET 4.6 but it still requires 4.6.2, which apparently is not supported on Server 2008 SP2... Any thoughts?

@crshovrd41 Hhm, at this stage I'll have to wait for response from the engineering team. I'll get back to you as soon as I get that.

@rayne-wiselman Thanks! Will await a reply!

Hey @rayne-wiselman any updates from the team? Thanks!

@crshovrd41 There shouldn't be a requirement for this.
Can we check the process through again so that we can identify where our content isn't working for you..
Firstly, are you migrating VMware VMs or physical servers?

Hi! It’s failing when pushing the MARS agent. v19 requires .NET 4.6.2 which
isn’t supported on Server 2008 SP2. I tried the manual install after the
push failed and that’s how I found out.
I’m migrating from VMware btw.
On Tue, Oct 2, 2018 at 01:58 Rayne Wiselman<EMAIL_ADDRESS>wrote:

@crshovrd41 https://github.com/crshovrd41 There shouldn't be a
requirement for this.
Can we check the process through again so that we can identify where our
content isn't working for you..
Firstly, are you migrating VMware VMs or physical servers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/15620#issuecomment-426200420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiEr-lANB1HXiOwPZOc9eg4qWz1JeUFvks5ugyrSgaJpZM4W5Y8l
.

--
Sent from your iPhone

@rayne-wiselman - My mistake, I meant the Mobility Service. Tough to keep all these names in order. Yes, I've followed everything and all my other servers are working fine with the service. Again, I attempted to install the Mobility service manually and it tells me I need .NET 4.6.2, which, according to MS, is NOT supported on 2008 SP2.
Thanks!

Do you already have the configuration server set up? Is it the Mobility push install that’s failing. If so can you send me the screenshot so I can pass that on. Thanks!
From: crshovrd41<EMAIL_ADDRESS>Sent: Tuesday, October 2, 2018 7:48 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Rayne Wiselman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Server 2008 SP2 (#15620)
@rayne-wiselmanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frayne-wiselman&data=02|01|raynew%40microsoft.com|8b7cd898d5ed456c7e7c08d62886c722|72f988bf86f141af91ab2d7cd011db47|1|0|636740956663183472&sdata=jC%2FgAZXxmed3K%2BwL5OKxYUuR17IAbP35xPSa26fKXmM%3D&reserved=0 - My mistake, I meant the Mobility Service. Tough to keep all these names in order. Yes, I've followed everything and all my other servers are working fine with the service. Again, I attempted to install the Mobility service manually and it tells me I need .NET 4.6.2, which, according to MS, is NOT supported on 2008 SP2.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F15620%23issuecomment-426346834&data=02|01|raynew%40microsoft.com|8b7cd898d5ed456c7e7c08d62886c722|72f988bf86f141af91ab2d7cd011db47|1|0|636740956663193481&sdata=TVsaHdMeLBvzAQfBqQR%2FHaOZoijrcy2au2r3ztH7wuk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD2-iKpVcAFq4vJO9J-PTxZviMRQkwZAks5ug5iogaJpZM4W5Y8l&data=02|01|raynew%40microsoft.com|8b7cd898d5ed456c7e7c08d62886c722|72f988bf86f141af91ab2d7cd011db47|1|0|636740956663203490&sdata=y4t29hfqKbPCGSDDPwQCVe13x5J93GKhhjl47Z3HLTQ%3D&reserved=0.

(insert text here)[https://github.com/MicrosoftDocs/azure-docs/issues/14537]

(https://github.com/MicrosoftDocs/azure-docs/issues/14537)[hello]

@rayne-wiselman - I decided to upgrade my servers to 2012 R2. Unfortunately, nothing worked. I recommend someone go back through and test this for Server 2008 SP2 as following the exact steps didn't work. It failed pushing the mobility service. Then, when I attempted to manually install it, it said I needed .NET 4.6.2, which is not supported on Server 2008 SP2.

@crshovrd41 Thanks. I'll pass this input onto the appropriate team.

@crshovrd41 - I apologize for the trouble and for the back and forth. We have validated that this process works. I would like to request that we setup a conf call between you and the engineering team to try and work through the issues you've run into. We'll be able to make progress getting you unblocked faster that way. Please let me know if I can setup a Skype call for us and I'll set that up for early next week. I'm at<EMAIL_ADDRESS>

@crshovrd41 - checking back on this. I'd much appreciate it if you could help us work this out


Currency conversion showing only 1 icon

When using the currency conversion function it will only show a single icon.

Hello,
Looks like the links are not preserved when you clone the repo. The USD currency flag is a symbolic link to US flag.
Looks like git converted USD.svg to a file containting US.svg.
On my computer I am developing locally so it works.
Probably you can confirm this if you copy the US flag to USD currency and restart the launcher.
Also the flags with "time" command should work because they are not symlinks.
cp ~/.local/share/ulauncher/extensions/com.github.tchar.ulauncher-albert-calculate-anything/images/flags/US.svg \
~/.local/share/ulauncher/extensions/com.github.tchar.ulauncher-albert-calculate-anything/images/flags/USD.svg

Now for this to be solved there are 2 ways I guess:

create copies of all currency flags instead of symlink
resolve the symlink problem with git

Give me an hour or two shouldn't be that hard to fix

Hello again @Laar3
So I found the issue. If you clone the repo directly to ulauncher extensions through git clone, it works perfectly.
For some reason when you install the extension through ulauncher it doesn't do normal git clone and just copies the contents of the file (in case of symlinks it is the name of the linked file), so you end up with normal text files.
#3 fixes this, please confirm that after you update the extension currency flags are showing.

Hello again @Laar3
So I found the issue. If you clone the repo directly to ulauncher extensions through git clone, it works perfectly.
For some reason when you install the extension through ulauncher it doesn't do normal git clone and just copies the contents of the file (in case of symlinks it is the name of the linked file), so you end up with normal text files.
#3 fixes this, please confirm that after you update the extension currency flags are showing.

ive updated but now the currency conversion doesnt do anything at all (all other functions work though) after this i tried removing the extension and manually git cloneing to the .local/share/ulauncher/extensions and the currency conversion still wouldnt work

forgot to upload an image

@Laar3
I should create a logger indipendently from ulauncher because it is not enough as the project grew in size.
All right that's a different issue. Now to figure this out I need you to give me some logs.
Before doing that you can check the cache of the extension.
It should be in ~/.cache/extension_calculate_anything/ and normally you can find 2 files there. One of them should be called currency_data.json. Can you open that file and confirm the contents with me?
I suspect that the last update timestamp is relatively new and the exchange rates are empty.
If the file is too big you can use this snippet to get the info from currency_data.json
python -c "import os,json;f=open(os.path.expanduser('~/.cache/extension_calculate_anything/currency_data.json'));d=json.loads(f.read());f.close();p=d.get('provider');t=d.get('last_update_timestamp');c=d.get('exchange_rates');print('provider={},timestamp={},currencies={}'.format(p, t, len(c) if c is not None else None))"

Normally by deleting the file and restarting ulauncher it should work.
However I would really appreciate it if you provided some logging output so that I can find out what went wrong before deleting the file. In order to do so close ulauncher and open it in dev mode with no extensions
ulauncher --no-extensions --dev -v |& grep calculate-anything

Open a new terminal and type the VERBOSE command you see above. Alternatively you can find this command under the extension's preferences when you open ulauncher in dev mode. Should look like this
VERBOSE=1 ULAUNCHER_WS_API=ws://<IP_ADDRESS>:5054/com.github.brpaz.ulauncher-docsearch PYTHONPATH=/usr/lib/python3/dist-packages /usr/bin/python3 ~/.local/share/ulauncher/extensions/com.github.brpaz.ulauncher-docsearch/main.py

Redirect the log to a file by adding 2>&1 | tee ~/ulauncher-calculate-anything.log. So the final command should look like this.
VERBOSE=1 ULAUNCHER_WS_API=ws://<IP_ADDRESS>:5054/com.github.tchar.ulauncher-albert-calculate-anything PYTHONPATH=/usr/lib/python3/dist-packages /usr/bin/python3 ~/.local/share/ulauncher/extensions/com.github.tchar.ulauncher-albert-calculate-anything/main.py 2>&1 | tee ~/ulauncher-calculate-anything.log

You should see some logs in your terminal.
Type the currency conversion and then close the terminal and post the logs over here.
Thanks for taking the time to help me resolve this.


Inconsistency in the merged Basic Widgets Overview page

A couple of things I noticed since the Basic Widgets Overview page and the Material Design Catalog page merged:

There are still two separate links for Basic widgets and Material design catalog in the left navigation pointing to the same page, but there is only the Basic widgets overview link in the main content area of the homepage. See the screenshot below.

To address the above inconsistency, maybe we can keep the material design catalog link but point it to the material design section in the merged page?
The images for the material design components take a lot more space now in the merged page. Do they need to be this large? It's now a little hard to see the text below the images when they are so large.
Do we still want to call the merged page "Basic Widgets Overview"? How about simply calling it "Widgets Overview"?

@Hixie @qchong

@Hixie Not sure why the material design catalog needs to be merged into the basic widgets page. IMHO, these can exist separately. This solves the problem of helping developers who want to quickly find which material design API to use without having to dig through the API docs (or scrolling all the way to the bottom of the current 'basic widgets' page).
'Basic widgets' (excluding the merged material design section) consists of information that belongs in the API docs. To make this page more helpful, consider adding code snippets to illustrate how the layout, painting, scrolling etc. APIs are used, along with some best practices.

P1 got lost because we had two pages. They didn't understand that there were two parts to the documentation. We figured that it's easier if there's just one document that points people to the dartdocs for each of the most useful widgets. That way if you find the doc, you don't get stuck there.

To address your other point, we're gutting the 'Basic widgets' part and pointing to the dartdocs instead. There's already a page with sample code, that's the intro-widgets page.

Thanks for making these changes. It looks good to me. Let's see if that helps in the afternoon's study session.

Changes have landed. Sorry about the breakage earlier, I'm editing blind. :-)

Let me know if you spot anything else that needs fixing. I plan to try to add diagrams to the earlier stuff on that page as well, FWIW. Dunno if I'll be done in the next hour.


Factor out get_transactions_csv API method for retrieving raw CSV data

This simply separates the logic for retrieving the CSV transactions data from
the logic for parsing it as a Pandas DataFrame.  This allows users to retrieve
the raw transaction data without depending on Pandas.

I also added support for retrieving investment transactions, and for retrieving JSON transaction data, which includes some additional information not present in the CSV data.

Would you mind merging master and pushing, as the check should now be resolved on master? And once that little chunk of duplicated code is gone, I'll merge this and everyone can enjoy your fine work!

Done.  Pretty much all of the direct calls to self.post and self.get (that don't currently check the status at all) could be replaced by request_and_check, but I figured I'd leave such a change up to you.

Great, thank you, merged and released to pypi as 1.12 :)


Swagger

Codecov Report

Merging #95 (f41d86d) into main (c2ee090) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   98.58%   98.57%   -0.01%
==========================================
  Files           5        4       -1
  Lines         282      281       -1
==========================================
- Hits          278      277       -1
  Misses          4        4

Impacted Files
Coverage Δ

service/__init__.py
84.00% <100.00%> (ø)

service/models.py
100.00% <100.00%> (ø)

service/routes.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ee090...f41d86d. Read the comment docs.

IBM Cloud toolchain: Delivery Pipeline deployed recommendations to prod, including commit 11ceb40e349343bf1e4be669e4fd1fabe1b6f672


Problem with sqlx.In query - postgres: malformed record literal

This is the error I'm getting:
        <*pq.Error | 0xc8200e0a20>: {
            Severity: "ERROR",
            Code: "22P02",
            Message: "malformed record literal: \"700000000001\"",
            Detail: "Missing left parenthesis.",
            Hint: "",
            Position: "",
            InternalPosition: "",
            InternalQuery: "",
            Where: "",
            Schema: "",
            Table: "",
            Column: "",
            DataTypeName: "",
            Constraint: "",
            File: "rowtypes.c",
            Line: "156",
            Routine: "record_in",
        }

With this code:
var accounts = []int64{700000000001,<PHONE_NUMBER>02,<PHONE_NUMBER>03,<PHONE_NUMBER>04,<PHONE_NUMBER>05}
var orgID = 1
var bid = 1

query, args, err := sqlx.In(`UPDATE accounts SET org_id = ?, bid = ? WHERE accounts IN (?);`, orgID, bid, accounts)
if err != nil { /* handle error */ }
query = db.Rebind(query)
result, err := tx.Exec(query, args...)
if err != nil {
   // error above is thrown
}

stdout print of the query + args generated from In():
query="UPDATE accounts SET org_id = ?, bid = ? WHERE accounts IN (?, ?, ?, ?, ?);"
args="[1 1<PHONE_NUMBER>01<PHONE_NUMBER>02<PHONE_NUMBER>03<PHONE_NUMBER>04<PHONE_NUMBER>05]"

stdout print of the rebound query:
query="UPDATE accounts SET org_id = $1, bid = $2 WHERE accounts IN ($3, $4, $5, $6, $7);"

That all looks good to me.  Here's the description of the table accounts:
describe accounts
+-------------+--------------------------+----------------------------------------------------+
| Column      | Type                     | Modifiers                                          |
|-------------+--------------------------+----------------------------------------------------|
| id          | bigint                   | not null default nextval('accounts_seq'::regclass) |
| org_id      | integer                  |                                                    |
| bid         | integer                  |                                                    |
| assigned_at | timestamp with time zone |                                                    |
+-------------+--------------------------+----------------------------------------------------+

Ah, nevermind, there was a typo in the query: s/accounts/id/


Localisation: Adding Tamil language translation keys.

Hello All, I'm adding the Tamil language translation keys to Kofta. Thanks.

I've added a new file: kofta/public/locales/ta/translation.json and edited the kofta/src/app/components/LanguageSelector.tsx file.


onTouchListener Not Working

Using setOntouchListener on SubLimePicker Class.

Could you please provide more information about what isn't working. Can you also include:

reason for setting an OnTouchListener on SublimePicker.
stacktrace in case of a crash
code that is supposed to be working

I'm using the picker in nested Scroll View nd can't scroll when scrolling in the white area in radial time picker.

Can you guide me on how to do that

nd onTouch is not even called. I thought of passing the event to Nested Scroll View.

RadialTimePickerView sets its own OnTouchListener: Link
And it captures all touch events by returing true: Link
To solve your problem, RadialTimePickerView's onTouch(MotionEvent) will have conditionally return false. The condition will be this:
private int getDegreesFromXY(float x, float y) {
    final double hypotenuse = Math.sqrt(
            (y - mYCenter) * (y - mYCenter) + (x - mXCenter) * (x - mXCenter));

    // Basic check if we're outside the range of the disk
    if (hypotenuse > mCircleRadius[HOURS]) {

        // If we are outside the range of the disk && action == MotionEvent.ACTION_DOWN,
        // return `false` from `onTouch(MotionEvent)`.
        return -1;
    }
    ....
    ....
}

This may just be the beginning of a solution, and additional changes may be required. But, you can definitely give it a try.

@vikramkakkar I tried it before raising the issue itself. Making it return false in each and every case also wouldn't help. Plz Reply ASAP.


Use realistic file paths in file scopes

This PR is the start of getting rid of package names in file scopes, with the intention of using more realistic file paths for the app being compiled. This hopefully solves (or helps to solve) a bunch of issues with file resolution and file chunk naming.
Fixes #462
Fixes #631

Looks good to me and does solve the file path problem. We should verify that this doesn't regress the fix for #427.

@graup Thanks for reminding me about #427. I think it's possible this change could affect it. Thinking we should potentially make the filenames look absolute by prefixing with a /. That should hopefully stop any kind of automatic path processing from occurring as mentioned in the original issue. Will update this soon.

@graup Looking to merge this soon. Happy with how it changes the rollup output? Seems cleaner to me but does make the custom asset file name test/docs a bit strange.

@graup Looking to merge this soon. Happy with how it changes the rollup output? Seems cleaner to me but does make the custom asset file name test/docs a bit strange.

It does but I'm fine with that. That's optional anyway, no big deal if users don't get that. It works fine with the default setting too.


Request to move repo under NW Userland

Hi @johansatge,
I'm part of a GitHub org called NW Utils. I'm trying to consolidate NW tooling so it's easier to find useful projects and give much needed life to stagnant ones. I also think this would be a great opportunity to exchange ideas and learn new things. Let me know what you think and if you’d be willing to.
Best Regards
Ayushman

@johansatge I realise I closed this too soon, apologies! By moving the repo under the organisation, it becomes easier for people to find and maintain.


[Question]: What is the plan for current Spring Vulnerability

Hi,
We are updating all our Spring boot application to Spring boot version 2.6.6 for the current cve-2022-22965 vulnerability. Please let us know when Mirakl-Hyperwallet-Connector will be updated so that we can plan the update in our code base.
Thanks & Regards,
Sathesh S.

Hi @satheshsoundar,
We are planning on upgrading Spring Boot version 2.6.6 within this month. We are working on it.
Thanks,
Carlos B.

You have now available the release 4.8.0 with the Spring Boot version 2.6.6 and the fix for the vulnerability  https://tanzu.vmware.com/security/cve-2022-22965.
Regards,
Carlos B.


fix #97

fix #97

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   56.82%   56.82%
=======================================
  Files           9        9
  Lines        1362     1362
=======================================
  Hits          774      774
  Misses        492      492
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf5d41...5a6156a. Read the comment docs.


Signed types

While working on #554 / #772 I realised that most of the work I was doing was adding signed integer support to the language so that the casts and printing make sense. My cast implementation is only a few lines of code. As int casts and signed ints are related but different things I decided to split this parts into a new MR.
Opening this now to get some feedback on the approach. So far it seems to work quite well with only minor modifications to  clang struct tests.
Example:
$ sudo bpftrace -e 'kr:sock_recvmsg { @=sum(-11); }'

@: -22

$ sudo bpftrace -e  'BEGIN { @[10]=-10; @[0]=10; @[5]=0; @[-10]=100; exit() }'

@[10]: -10
@[5]: 0
@[0]: 10
@[-10]: 100

Add signed types
bpftrace currently has a somewhat confusing mix of signed and unsinged
integers throughout the codebase. As an example, we can assign a
negative as map value but the printer will see it as unsigned[1].
This change introduces signed integer types by adding a new is_signed
attribute to the SizedType which is implemented throughout the
codebase with the exception of the trace point parser, which will be
done in a future version.
With this change all integer literals are signed by default as negative
numbers are already supported. If there is a need for 64 bits unsigned
ints it should be easy to add.
This does not try to be smart about signed and unsigned binops, instead
if prints a warning if the types do not match on both sides. I did not
want to introduce additional complexity without having a good reason to
do so.
[1]
sudo bpftrace_stable -e  'BEGIN { @[10]=-10; @[0]=10; @[5]=0; @[-10]=100; exit() }'

Program
 BEGIN
  =
   map: @
    int: 10
   int: -10
[..]
    call: exit

@[5]: 0
@[0]: 10
@[-10]: 100
@[10]:<PHONE_NUMBER>3709551606

Should there be any changes noticeable by the users with this PR?

Should there be any changes noticeable by the users with this PR?

My goals is not to break the current tools in the repo nor having to do massive changes on tests.
The biggest one will be the maps I think. Negative values will now be printed correctly (as long as knows it's signed, which requires some cast magic atm). The binops have changed a bit too, but only when both sides are signed, which is only possible with structs as all builtins are still unsigned.
I'm working on an update that adds some more tests around binops and signs, I'm trying to copy C as much as possible but it's a bit tricky. Hoping to have it done in an hour.

Just pushed v2. Changes
v1 -> v2

- Make it possible to print warnings during semantic analysis. Warnings
are not fatal but could lead to unexpected behaviour.
- Semantic analysis of binops. I've tried to follow what C does but send
out warning instead of doing type casting which keeps the complexity
lower.
- Extend the test framework to make it possible to test for WARNING
output
- Implement a few binop tests

I also diffed all existing tools https://gist.github.com/fbs/2517bbde7c069b15c8eb43e5d7976016 .
The biggest issues I've found atm:
map key typing:
 sudo /vagrant/tools/capable.bt
Argument mismatch for @cap: trying to access with arguments: [unsigned int64]
	when map expects arguments: [int64]

Not sure how to handle this one yet.
And comparison of two signed numbers now returns -1 instead of 1 as the return type of comparison is lsign & rsign . I think that changing it to unsigned is best here
sudo bpftrace -e 'BEGIN { $x = 1 < 2; printf("%d\n", $x); }'
Attaching 1 probe...
-1

@mmarchini I think I got all the basics now. There is still stuff that is missing and the semantic analyser could do with some improvement still (e.g. doesn't catch unsigned int < 0). But the diff is already big enough and I don't want to keep adding in stuff.
I've added the tests that seem important to me. I can't come up with any additional tests but if there are any you want added I can. All tests pass and the only changes in tools are in runqlat, which now sign extends instead of zero extends as expected.
The only thing I'm not that happy with is how MapKeys are handled but I think of  a better way atm.  I think it is good enough for a first version.

I'll probably merge this by the end of Friday if there's no objections.
cc @ajor @danobi let me know if you want me to hold this until you review it.

Cool! I'll take a stab at cleaning up the commit history a bit (no code changes). The current one was kept "incremental" to make reviewing easier. Let me know when you're ready to merge so I can push it into this branch.
cleanup wip: https://github.com/fbs/bpftrace/commits/signed_types_final

Thanks for the reviews @danobi & @mmarchini
Found a bug after rebasing onto master. Error: Unsupport signed division for DAG: on nsecs/1000 caused by expr_ = do_signed ? b_.CreateSDiv(lhs, rhs) : b_.CreateUDiv(lhs, rhs);. I'll revert it to UDiv. Not sure if we should emit a warning. I'll create a follow up ticket for integer literals

Not sure if we should emit a warning.

I think the warning is good. The one you added LGTM.

@danobi the squash merge seems to have used the "opening" message from this PR instead of the messages squashed. Was this intended? if it was accidental I could revert and readd if history should be preserved.  I'll revert that commit. Can you put up a PR with the same changes? Then we can merge back in.

6613a140a6b46b4 is the revert

Remerged in #905


Correction request

At step : Join the database on the secondary of the second availability group
In case of manual seeding when we are configuring a Distributed AG from SQL 2017 to SQL 2019, then we have to restore the db with NO RECOVERY option on both forwarder and its secondary instance.
At present in the article its not mentioned that we have to create the db on both nodes of the forwarder

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab92d64a-bdc3-67a0-60f8-c551b85ead4b
Version Independent ID: e8ed4dfb-c487-e663-e77f-f205415319e4
Content: Configure a distributed availability group - SQL Server Always On
Content Source: docs/database-engine/availability-groups/windows/configure-distributed-availability-groups.md
Service: sql
Sub-service: availability-groups
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@romil-gupta -- thank you for your clear feedback.
@tarynpratt -- please look into this issue.

Hi @romil-gupta, thanks so much for your feedback, our apologies for the long delay as we processed a large number of back Issues. I've processed a change and it should be live later this week. I'll go ahead and close out this Git Issue but please feel free to comment should you need anything further.
thanks again, hope you have a good day, bye
#reassign:tarynpratt
#please-close


Fix:Should be prohibited refundAddress call refund function

should be prohibited refundAddress call refund

I'm not sure the blacklist solves the issue :(
If owner mints 100, transfers them all to owner2, then owner2 refunds.
owner2 receives 10eth and owner receives 100 nfts.
And they can keep repeating.
We just merged in a PR to tackle this issue here:
https://github.com/exo-digital-labs/ERC721R/pull/9
Happy to hear your thoughts.


unknown Method xsdbool

Method unknown.   xsdbool
This method is unknown and it is not possible to activate... Do you know what it refers to ?
  method _escape.
    output = htmlspecialchars(
      input = text
      ent_html401 = abap_true
      ent_noquotes = allow_quotes
      ent_quotes = xsdbool( allow_quotes is initial ) ).
  endmethod.

xsdbool is a built in function from v740sp08, guess in this case you can replace it with boolc

Okay, everything's fine.
v740sp04.
thank you


For not found use intermediateTransitionTo to keep the URL the same [PREP-154]

Use intermediateTransitionTo so that the URL stays the same when an invalid URL is accessed.
Current behavior:

Visiting a broken link from an outside source: keeps the URL that you're visiting
Typing in a broken link: keeps the URL that you're visiting
Visiting a broken link from within the application: reaches an error state from within ember, and updates the window location using a bit of a hacky method.

Future desired behavior:
Visiting a broken link from within the application shows the URL that the link was leading to in the error bar. This is very much not straight forward to accomplish from within ember as most of the URL logic is based on models, and errors are thrown before a "bad" url is ever actually reached.  Maybe with "replaceWith" or "replaceState" - but I had no luck with that yet...
ticket for this issue: https://openscience.atlassian.net/browse/PREP-159
this issue ticket: https://openscience.atlassian.net/browse/PREP-154

Superseded by https://github.com/CenterForOpenScience/ember-preprints/pull/152, due to a small bug, where /preprints/discover/not_really-a-url would have the page not show anything, maybe due to how intermediateTransition interacts with {{outlet}} ??


just a question, why 32767 and 0.01, what are they for?

https://github.com/keithito/tacotron/blob/08989cc3553b3a916a31f565e4f20e34bf19172f/util/audio.py#L15

This code is converting the floating-point output of the model to 16-bit values to be saved as a
wav file. 32767 is the maximum value for a 16-bit signed integer (2^15 - 1). The 0.01 prevents
division by zero in case the output is silence.


Update env var and public key for regional builds

The regional builds use a different public key for signing verification, so we need to update that.
Also renaming NEW_BUILD_MODE to REGIONAL_BUILD_MODE across the board.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/unhold

/lgtm


Unavailable to create subscription on topic when the system get including ElasticAPM

Contact Details
<EMAIL_ADDRESS>Version
8.x (develop, pre-release)
On which operating system(s) are you experiencing the issue?
Windows
Using which broker(s) did you encounter the issue?
Azure Service Bus
What are the steps required to reproduce the issue?
1. Config the Elastic APM and run in your app

        public static WebApplicationBuilder AddInfrastructureElasticApm(this WebApplicationBuilder builder)
        {
            builder.Host.UseElasticApm(new HttpDiagnosticsSubscriber(),
                new AspNetCoreDiagnosticSubscriber(),
                new EfCoreDiagnosticsSubscriber(),
                new SqlClientDiagnosticSubscriber(),
                new ElasticsearchDiagnosticsSubscriber(),
                new GrpcClientDiagnosticSubscriber(),
                new AzureMessagingServiceBusDiagnosticsSubscriber(),
                new MicrosoftAzureServiceBusDiagnosticsSubscriber(),
                new AzureBlobStorageDiagnosticsSubscriber(),
                new AzureQueueStorageDiagnosticsSubscriber(),
                new AzureFileShareStorageDiagnosticsSubscriber(),
                new AzureCosmosDbDiagnosticsSubscriber(),
                new MongoDbDiagnosticsSubscriber());

            return builder;
        }

2. Config a simple subscription endpoint
```cs
    public static WebApplicationBuilder AddInfrastructureServiceBus(this WebApplicationBuilder builder)
    {
        var options = builder.Configuration.GetSection("MassTransit").Get<MassTransitV2Options>();
        builder.Services.AddMassTransit(e =>
        {
            e.AddConsumer<NewReportConsumer>();

            e.UsingAzureServiceBus((context, y) =>
            {
                y.Host(contractOptions.ConnectionString);

                y.Message<NewReportEvent>(e =>
                {
                    e.SetEntityName(contractOptions.Subscriptions[2].TopicName);
                });

                y.SubscriptionEndpoint<NewReportEvent>(contractOptions.SubscriptionName,
                    t =>
                    {
                        t.ConfigureConsumer<NewReportConsumer>(context);
                    });
            });
        });

        return builder;
    }

Config Serilog

Trying to config Serilog to flow out the log on DEBUG Level.

Start Application and wait for errors

### What is the expected behavior?

I expect new subscription was on the topic.

### What actually happened?

The topic was created successfully, but failed to create new subscription:

```text
2023-12-19T18:07:43.4458008+07:00 Debug [] MassTransit - Endpoint Faulted: sb://dc-iris-uat-test.servicebus.windows.net/iris-microservices-isbd-data-changes-localhost/Subscriptions/iris-microservices-portfolio-localhost
MassTransit.ServiceBusConnectionException: ReceiveTransport faulted: sb://dc-iris-uat-test.servicebus.windows.net/iris-microservices-isbd-data-changes-localhost/Subscriptions/iris-microservices-portfolio-localhost
 ---> System.ArgumentException: An item with the same key has already been added. Key: error.type
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)

Related log output, including any exceptions
2023-12-19T18:07:43.4458008+07:00 Debug [] MassTransit - Endpoint Faulted: sb://dc-iris-uat-test.servicebus.windows.net/iris-microservices-isbd-data-changes-localhost/Subscriptions/iris-microservices-portfolio-localhost
MassTransit.ServiceBusConnectionException: ReceiveTransport faulted: sb://dc-iris-uat-test.servicebus.windows.net/iris-microservices-isbd-data-changes-localhost/Subscriptions/iris-microservices-portfolio-localhost
 ---> System.ArgumentException: An item with the same key has already been added. Key: error.type
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.AddRange(IEnumerable`1 collection)
   at System.Collections.Generic.Dictionary`2..ctor(IEnumerable`1 collection, IEqualityComparer`1 comparer)
   at System.Collections.Generic.Dictionary`2..ctor(IEnumerable`1 collection)
   at Elastic.Apm.OpenTelemetry.ElasticActivityListener.UpdateSpan(Activity activity, Span span)
   at Elastic.Apm.OpenTelemetry.ElasticActivityListener.<get_ActivityStopped>b__21_0(Activity activity)
   at System.Diagnostics.ActivitySource.<>c.<NotifyActivityStop>b__25_0(ActivityListener listener, Object obj)
   at System.Diagnostics.SynchronizedList`1.EnumWithAction(Action`2 action, Object arg)
   at System.Diagnostics.ActivitySource.NotifyActivityStop(Activity activity)
   at System.Diagnostics.Activity.Stop()
   at System.Diagnostics.Activity.Dispose()
   at Azure.Core.Pipeline.DiagnosticScope.ActivityAdapter.Dispose()
   at Azure.Core.Pipeline.DiagnosticScope.Dispose()
   at Azure.Core.Pipeline.RequestActivityPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RedirectPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.HttpPipeline.SendRequestAsync(Request request, CancellationToken cancellationToken)
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.SendHttpRequestAsync(Request request, CancellationToken cancellationToken)
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.GetEntityAsync(String entityPath, String query, Boolean enrich, CancellationToken cancellationToken)
   at Azure.Messaging.ServiceBus.Administration.ServiceBusAdministrationClient.GetSubscriptionAsync(String topicName, String subscriptionName, CancellationToken cancellationToken)
   at MassTransit.AzureServiceBusTransport.ServiceBusConnectionContext.<>c__DisplayClass22_0.<<GetSubscriptionAsync>b__0>d.MoveNext() in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Contexts/ServiceBusConnectionContext.cs:line 320
--- End of stack trace from previous location ---
   at MassTransit.AzureServiceBusTransport.ServiceBusConnectionContext.RunOperation[T](Func`1 operation) in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Contexts/ServiceBusConnectionContext.cs:line 367
   at MassTransit.AzureServiceBusTransport.ServiceBusConnectionContext.CreateTopicSubscription(CreateSubscriptionOptions createSubscriptionOptions, CreateRuleOptions rule, RuleFilter filter) in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Contexts/ServiceBusConnectionContext.cs:line 144
   at MassTransit.AzureServiceBusTransport.Middleware.ConfigureServiceBusTopologyFilter`1.ConfigureTopology(ConnectionContext context) in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Middleware/ConfigureServiceBusTopologyFilter.cs:line 71
   at MassTransit.AzureServiceBusTransport.Middleware.ConfigureServiceBusTopologyFilter`1.<>c__DisplayClass8_0.<<ConfigureTopology>b__0>d.MoveNext() in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Middleware/ConfigureServiceBusTopologyFilter.cs:line 53
--- End of stack trace from previous location ---
   at MassTransit.PipeExtensions.OneTimeSetup[T](PipeContext context, Func`2 setupMethod, PayloadFactory`1 payloadFactory) in /_/src/MassTransit.Abstractions/Middleware/PipeExtensions.cs:line 106
   at MassTransit.AzureServiceBusTransport.Middleware.ConfigureServiceBusTopologyFilter`1.ConfigureTopology(NamespaceContext context) in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Middleware/ConfigureServiceBusTopologyFilter.cs:line 51
   at MassTransit.AzureServiceBusTransport.Middleware.ConfigureServiceBusTopologyFilter`1.Send(ClientContext context, IPipe`1 next) in /_/src/Transports/MassTransit.Azure.ServiceBus.Core/AzureServiceBusTransport/Middleware/ConfigureServiceBusTopologyFilter.cs:line 30
   at MassTransit.Agents.PipeContextSupervisor`1.Send(IPipe`1 pipe, CancellationToken cancellationToken) in /_/src/MassTransit/Agents/PipeContextSupervisor.cs:line 55
   at MassTransit.Agents.PipeContextSupervisor`1.Send(IPipe`1 pipe, CancellationToken cancellationToken) in /_/src/MassTransit/Agents/PipeContextSupervisor.cs:line 61
   at MassTransit.Agents.PipeContextSupervisor`1.Send(IPipe`1 pipe, CancellationToken cancellationToken) in /_/src/MassTransit/Agents/PipeContextSupervisor.cs:line 67
   at MassTransit.Transports.ReceiveTransport`1.ReceiveTransportAgent.RunTransport() in /_/src/MassTransit/Transports/ReceiveTransport.cs:line 195
   --- End of inner exception stack trace ---

Link to repository that demonstrates/reproduces the issue
No response

The key error.type does not exist anywhere in the MassTransit code base, not sure why this happens but it seems to be an issue with Elastic APM.


AFC repeater values from custom post type returned as a number not text

Is this a support or usage question? Please post to StackOverflow using the Timber tag
Expected behavior

To see the list of text from the repeaters and not how many items are in the repeater.
Actual behavior

Just shows the total number of items in the repeater, it does display the title which is good.
Steps to reproduce behavior

https://gist.github.com/JakeHenshall/32f583b03a0df0de2ad324068e2bb8b9
What version of WordPress, PHP and Timber are you using?

WordPress 4.9.2, PHP 7.1.8, Timber 1.6.0
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)

Via Composer/Packagist

Did you initialize Timber in functions.php?
new Timber\Timber();

If you don’t initialize Timber, it will not register the proper filters for ACF and load the value directly from the database and you won’t have any values in your repeater field.
Related issues: #1351, #1527

@gchtr Yes I have added new Timber\Timber(); to my functions.php file.
Do I need to loop through the repeater to display the text / type fields. If I var_dump($context['changelog']); it has all of the correct text that I need.
I can add my functions.php file to the gist.
Thanks Jake.

I have run into this many times. How are you defining the ACF fields - through the GUI or using PHP?  Are you reusing a meta key for the ACF field that was used for something else previously?

@chrisgherbert I'm just using the plugin to create the fields, if i var dump they are all there.

@JakeHenshall Have you used the meta keys ('type' or 'changes') for any other custom fields?

@chrisgherbert No there is only 2 ACF (Changelog -> Type / Changes) & (Documentation)

@JakeHenshall What do you get when you search the post meta table for all instances of those keys?  SELECT * FROM wp_postmeta WHERE meta_key = 'type' and SELECT * FROM wp_postmeta WHERE meta_key = 'changes'
Are they all items that are using the ACF fields that you've set up, or is there some other thing using those keys as well?

The database seems to be saving the value twice not sure why it is doing this though?!

@JakeHenshall it's been a while but…
Assuming you're $context['changelog'] query contains posts, the change variable in your twig template contains each individual post, right? So change.changes is an array containing your repeater field values. You need to call change.get_field('changes') to retrieve the repeater. Then you can loop over the changes in your twig template.
{% for change in changelog %}
    <h1>{{ change.title }}</h1>
    {{ change.type }}

    {% for repeater_field· in change.get_field('changes') %}
      {{ repeater_field.value1 }}
      {{ repeater_field.value2 }}
      {{ repeater_field.value3 }}
    {% endfor %}
{% endfor %}

Issue is from a while ago. The solution provided should provide a fix for this. If you still run into this issue, please open a new ticket with a code example.


How to use this library with Spring cloud functions and aws serverless containers

Hi,
The example given in the library documentation is of a simple lambda with core java . However we have few lambdas created out of Spring cloud functions and AWS serverless containers .
Please see information on the same here.
These lambda handlers have single line code to proxy the request response.   And for spring cloud functions, lambda handlers are given by spring .  In such cases , how can the library be used to capture metrics and traces ?

Hi @swagsb,
Looking at the sample code, this should work fundamentally:
public class StreamLambdaHandler implements RequestStreamHandler {
    private static SpringLambdaContainerHandler<AwsProxyRequest, AwsProxyResponse> handler;
    static {
        try {
            handler = SpringLambdaContainerHandler.getAwsProxyHandler(PetStoreSpringAppConfig.class);
        } catch (ContainerInitializationException e) {
            // if we fail here. We re-throw the exception to force another cold start
            e.printStackTrace();
            throw new RuntimeException("Could not initialize Spring framework", e);
        }
    }

    @Override
    public void handleRequest(InputStream inputStream, OutputStream outputStream, Context context)
            throws IOException {
       DDLambda dd = new DDLambda(context);  //Records enhanced execution metrics
       handler.proxyStream(inputStream, outputStream, context);
    }
}

You could then construct a singleton class to hold DDLambda dd, and then retrieve a reference to dd from within your Spring application whenever you need it.
I haven't confirmed support for extracting X-Ray trace headers from an InputStream, so you might have difficulty instrumenting any REST requests that might be made from within your Spring app. If that's a priority for you, let me know and I can add a feature request.


feat(css-prop): adds support for objects in template literals

This adds support for transforming a template string literal that contains an object of style values

hey nice job man, left two comments 👍


Bug: Contributors page throws 404

Describe the bug
When clicking on “Contributors” it shows a 404 error
Steps to reproduce

Click on the navbar option “contributos”
Get a 404 error

Hi @wickathou - thanks for raising the issue! Can you give abit more detail on where you hit the 404 exactly? Was it in a repo insights page like this?

If so, can you share which repo it was?

Oh sorry! no it's on the homepage
https://opensauced.pizza/contributors > Click on Get started
It leads to this path https://opensauced.pizza/app.opensauced.pizza/start which is the one throwing the 404


Publish Events on Step & Task Completions

Expected Behavior
Have more knowledge of what happened in the PipelineRun or TaskRuns
Actual Behavior
There are only Succeeded or Failed events for whole Pipeline or Conditions for TaskRun/PipelineRun.
Additional Info
As the containers in the pod run in parallel and they are all starting at the same time and ending in arbitrary times, it can be hard to debug what went. Publishing events on when tasks finished can be useful to users.

/assign khrm

We do publish some events today, but only in case of errors and afaik only for Tasks and Pipelines. There may be some standard events published for containers.
We do have start and stop times of everything in the status, so with that it is possible to build a timeline of execution - perhaps displaying the timeline is something that it would be nice to integrate into the CLI and/or the dashboard. Would this be sufficient for your use case?

I noticed no events are generated when a tekton resource is created/deleted. Is this planned ? We need this for the VSCode and IntelliJ stuff we are working on in order to refresh the tree

I noticed no events are generated when a tekton resource is created/deleted. Is this planned ?

@jeffmaury do you mean kubernetes events or CloudEvents? Either way I think we could add this but I don't think we have a plan atm.

The Keptn project wants to work on a joint definition of these events. See issue in Keptn: https://github.com/tektoncd/pipeline/issues/742

@bobcatfish I would like to get started on this issue as it is marked as a good-first issue, any pointers to get started.

FYI - there are some changes happening being considered about when a pipeline is considered as "complete": #1749 and #2094 .
@mustafaakin is this issue about emitting kubernetes events?
I'm going to work on having cloud events sent (optionally) upon pipeline/taskrun life-cycle events, but I think that is a separate issue.

@afrittoli Thanks, so should I pick up another issue :)

/reopen

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

/remove-livecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten


"This seems to be a pre-built javascript file" when loading via Webpack

WARNING in /Projects/sentry/~/raven-js/dist/raven.js
Critical dependencies:
1:478-485 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ /Projects/sentry/~/raven-js/dist/raven.js 1:478-485

It appears that #464, while fixing the version + Browserify issues, now causes Webpack to throw a warning when loading Raven.js.

Hi!
I'm having this warning again with Raven 3.4.0, both minified and unminified versions.

any updates here?


Add missing config value

Add a missing config value that prevented auto placeholder detection from working

:eyes: @AtlantaJones whoops again!


behavior_planning_container dies while driving straight.

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Hi team,
I'm currently running Autowar with Carla using bridge implementation here, and I found a situation that the behavior_planning_container diles while driving straight, and it makes the ego vehicle stop before reaching the goal.
Here's the video of the situation: [rviz]
In the video, the vehicle drive well, but it suddenly stops at 0:30.
I also checked a corresponding [launch.log] file and I could find the error as below:
...
1721395398.4731574 [component_container_mt-75] terminate called after throwing an instance of 'rclcpp::exceptions::RCLError'
1721395398.4732425 [component_container_mt-75]   what():  failed to add guard condition to wait set: guard condition implementation is invalid, at ./src/rcl/guard_condition.c:172, at ./src/rcl/wait.c:460
1721395398.4733043 [component_container_mt-75] *** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1721395398" if you are using GNU date ***
1721395398.4819667 [component_container_mt-75] PC: @                0x0 (unknown)
1721395398.4821553 [component_container_mt-75] *** SIGABRT (@0x3e80000136d) received by PID 4973 (TID 0x7fc3933da640) from PID 4973; stack trace: ***
1721395398.4822626 [component_container_mt-75]     @     0x7fc304040a86 google::(anonymous namespace)::FailureSignalHandler()
1721395398.4823201 [component_container_mt-75]     @     0x7fc39d27b520 (unknown)
1721395398.4841051 [component_container_mt-75]     @     0x7fc39d2cf9fc pthread_kill
1721395398.4870968 [component_container_mt-75]     @     0x7fc39d27b476 raise
1721395398.4893513 [component_container_mt-75]     @     0x7fc39d2617f3 abort
1721395398.4922843 [component_container_mt-75]     @     0x7fc39d524b9e (unknown)
1721395398.4951425 [component_container_mt-75]     @     0x7fc39d53020c (unknown)
1721395398.4973755 [component_container_mt-75]     @     0x7fc39d530277 std::terminate()
1721395398.4996758 [component_container_mt-75]     @     0x7fc39d5301fe std::rethrow_exception()
1721395398.5018551 [component_container_mt-75]     @     0x7fc39d7cf119 rclcpp::exceptions::throw_from_rcl_error()
1721395398.5039811 [component_container_mt-75]     @     0x7fc39d7d2e9c rclcpp::detail::add_guard_condition_to_rcl_wait_set()
1721395398.5060802 [component_container_mt-75]     @     0x7fc39d7e55d7 (unknown)
1721395398.5080755 [component_container_mt-75]     @     0x7fc39d7d2685 rclcpp::Executor::wait_for_work()
1721395398.5100472 [component_container_mt-75]     @     0x7fc39d7d53c3 rclcpp::Executor::get_next_executable()
1721395398.5119836 [component_container_mt-75]     @     0x7fc39d7dc252 rclcpp::executors::MultiThreadedExecutor::run()
1721395398.5138829 [component_container_mt-75]     @     0x7fc39d55e253 (unknown)
1721395398.5156958 [component_container_mt-75]     @     0x7fc39d2cdac3 (unknown)
1721395398.5174739 [component_container_mt-75]     @     0x7fc39d35f850 (unknown)
1721395398.5193157 [component_container_mt-75]     @                0x0 (unknown)
1721395398.6333418 [ERROR] [component_container_mt-75]: process has died [pid 4973, exit code -6, cmd '/opt/ros/humble/lib/rclcpp_components/component_container_mt --ros-args -r __node:=behavior_planning_container -r __ns:=/planning/scenario_planning/lane_driving/behavior_planning -p use_sim_time:=True -p wheel_radius:=0.383 -p wheel_width:=0.235 -p wheel_base:=2.79 -p wheel_tread:=1.64 -p front_overhang:=1.0 -p rear_overhang:=1.1 -p left_overhang:=0.128 -p right_overhang:=0.128 -p vehicle_height:=2.5 -p max_steer_angle:=0.7'].

Expected behavior
I hope the ego vehicle to reach to the destination.
Actual behavior
But the vehicle stops in the middle of the road, and does not move at all.
Steps to reproduce
Here's the ros2bag file: [ros2bag]
I used the lane2let map here, and the initial/goal point as below (excerpted from launch.log file):
# Initial pose
x: 120.057753,
y: -8.898988,
z: 0.034443
qx: -0.000467,
qy: -0.000028,
qz: -0.007445,
qw: 0.999972
# Goal pose
x: 209.993347,
y: -9.808371,
z: 0.275307
qx: 0.000000,
qy: 0.000000,
qz: -0.007468,
qw: 0.999972

Versions

autoware.universe: 7877192cb5700c1db15109dcd959785fc381951d
Carla: 0.9.15

Possible causes
No response
Additional context
No response

Unfortunatelly, your logs just show the main thread crashed at a random place. Most likely the root cause of the crash comes from another crash.
If you are able to reproduce the issue, could you try to catch it with gdb? You just need to recompile with -CMAKE_BUILD_TYPE=RelWithDebInfo and add launch-prefix='gnome-terminal -- gdb -ex=r --args' at the end of <node_container ...> in the behavior_planning.launch.xml. When the program crashes in the new terminal, GDB should automatically switch to the problematic thread and you should be able to get a backtrace with bt

I have not been able to reproduce the issue with the bag.
I was also unable to use the map you shared. Are you using a custom map_config.yaml  ?

Sorry for late reply @VRichardJP, @maxime-clem.. I was busy for other tasks..
For @VRichardJP,
Actually, I failed to reproduce the issue..
I tried to compile Autoware with the option -DCMAKE_BUILD_TYPE=RelWithDebInfo and added launch-prefix='gnome-terminal -- gdb -ex=run --args at the end of <node_container ...> in the behavior_planning.launch.xml, I checked the gnome-terminal is loaded, but I could not debug it more as I failed to reproduce.
For @maxime-clem,
Sorry for providing little information.
Here are the map files and map_projector_info.yaml I used: [.osm] [.pcd] [map_projector_info.yaml]
I'm really sorry for delayed response, and thank you for the answers.


Several changes

Added Driver.SoftReset method.
Fixed BeginRebuildingRoutes,  StopRebuildingRoutes and RebuildNodeRoutes methods to use the correct commands. Without this change the option passed in BeginRebuildingRoutes is ignored.
Fixed typo in RebuildRoutesDone event.

@marcus-j-davies  done. Thanks!


Handle browser-specific manifest when bumping version

A version script should ensure manifest-chrome.json, manifest-firefox.json and manifest.json version keys gets bumped too.
Or is there a way to specify files to change while bumping version?

A node script could also allow us to drop rename and improve cross-OS compatibility. Using shx could also help with that.

Need to check for shx and web-ext too, to improve ×OSes compatibility.
And maybe a simple Node script could help lighten package.json scripts?


add cluster reg ability to create secrets on stage and production App…

…Studio
Signed-off-by: Chris Ahl<EMAIL_ADDRESS>Part of https://issues.redhat.com/browse/CMCS-50

/assign @Michkov @sbose78


What is the best way to do propensity score matching?

Should I use a two-step process like this?
causal = CausalModel(Y, D, X)
causal.est_propensity_s()
ps = causal.propensity['fitted']

causal2 = CausalModel(Y, D, ps)
causal2.est_via_matching(bias_adj=True)
print(causal2.estimates)

Hah! Never thought about using it this way but this should work. Another way is simply to stratify the sample and use the blocking estimator. The stratification is based on the estimated propensity score (so every block contains units with similar p scores), and the blocking estimator estimates and aggregates the within-bin treatment effects properly. Often when people say propensity score matching they really mean this approach!

I guess you are right. Testing with your simulated data, my strategy leads to very poor results . Thanks for your kindness. Best.


fix: 🐛 Fix issue on not loading gcloud

Fixed issue on not loading gcloud. Error on name variable declaration
Included items
The correct name variable is _appConfig and not appConfig

@ladeirarodolfo, if you have a high degree of confidence that a small change like this will fix a bug and have no side effects, no need to request a review.


How to call multi dialogs from LUISDialog i.e. calling AzureAuthDialog as a child

we are trying to connect Microsoft Graph therefore we need to authenticate to access Office 365 . Therefore we are using Authbot package.
We have a LuisIntent method to read the excel file in Office 365, so we are trying to do this from LUISDialog
await context.Forward(new AzureAuthDialog(AuthSettings.Scopes), this.ResumeAfterAuth, message, CancellationToken.None);
but we are getting Stack is empty error. Therefore we tried below code as well
var authDialog = new AzureAuthDialog(AuthSettings.Scopes);
var loop = authDialog.Loop();
context.Call(loop, async (ctx, arg) => ctx.Wait(MessageReceived));
when we do this , LuisIntent method is not invoking the AzureAuthDialog and subsequent call to LuisIntent Method is invoking the AzureAuthDialog. How do we invoke AzureAuthDialog in very first call.

If you want to have authentication occur before calls to LUIS, it might make more sense to have a root dialog that calls the authentication dialog if necessary otherwise it forwards the message to a child LUIS dialog.

@willportnoy
Basically , bot conservation sequence is as below.
General conversion like introduction , feature enquiry etc., does not need the authentication .
Office 365 specific conversion is initiated by user with bot like requesting tolist worksheet in workbook then we need a authdialog to shoot up.  Any code snippet or example will help.

Just out of curiosity, when forwarding to the AzureAuthDialog are you using a LuisIntent method with the following signature?
[LuisIntent("Authenticate")] public async Task Authenticate(IDialogContext context, IAwaitable<IMessageActivity> activity, LuisResult luisResult)
Because that is how we have done it, and it works perfectly.

Further to my comment above, luisintent methods can either be
public async Task ShowMenu(IDialogContext context, LuisResult luisResult)
or
public async Task Authenticate(IDialogContext context, IAwaitable<IMessageActivity> activity, LuisResult luisResult)
It's not documented very well, but the second type is much easier to work with because you always have access to the original MessageActivity, which is required to create the ResumptionCookie in AuthBot.

To be precise , this is what we are doing

[LuisIntent("GenerateSummaryChart")]
public async Task IReport(IDialogContext context,LuisResult result)
{
//Assume this is a query for OneDrive so let's get an access token
if (string.IsNullOrEmpty(await context.GetAccessToken(AuthSettings.Scopes)))
{
var authDialog = new AzureAuthDialog(AuthSettings.Scopes);
            var loop = authDialog.Loop();

            context.Call(loop, async (ctx, arg) => ctx.Wait(MessageReceived));

        }

....
}
@duckwaffle , what is your working solution. do you have any github repo to check the working code.

To be precise , this is what we are doing

[LuisIntent("GenerateSummaryChart")]
public async Task IReport(IDialogContext context,LuisResult result)
{
//Assume this is a query for OneDrive so let's get an access token
if (string.IsNullOrEmpty(await context.GetAccessToken(AuthSettings.Scopes)))
{
var authDialog = new AzureAuthDialog(AuthSettings.Scopes);
            var loop = authDialog.Loop();

            context.Call(loop, async (ctx, arg) => ctx.Wait(MessageReceived));

        }

....
}
@duckwaffle , what is your working solution. do you have any github repo to check the working code.

@sameerinfodb You can change the signature of your LuisIntent method to include the original IMessageActivity, and then use the azureauthdialog like so:
[LuisIntent("Authenticate")] public async Task Authenticate(IDialogContext context, IAwaitable<IMessageActivity> activity, LuisResult luisResult) { var message = await activity; if (string.IsNullOrWhiteSpace(await context.GetAccessToken(AuthSettings.Scopes))) { await context.Forward(new MultiChannelAuthDialog(AuthSettings.Scopes), ResumeAfterAuth, message, CancellationToken.None); } else await context.PostAsync("You are already logged in."); context.Wait(MessageReceived); } }
Obviously, this example is just for a standalone "Authenticate" LuisIntent, I find it easier to handle user authentication in its own intent (getting the user to type "Sign in" or "Login" or something like that), instead of trying to make logging part of the process of doing an authenticated action, but thats just our design decision. The project we are using this in is closed source, so I cant link you to a repo unfortunately, but happy to help if you're still stuck.

Thank you @duckwaffle , will try this approach and will update the comment.

This suggestion works for me , thanks you#duckwaffle


ionic 3

hello,
I'm not sure if you are actively working on your project but I tried to use your code and the documentation is no longer valid b/c ionic has evolved.
Typically things like "ionic state restore" no longer work.
Anyway, I'm still trying to get it to work, have you tried it with ionic 3?

Hi !
See my response on the Ionic Forum : https://forum.ionicframework.com/t/ionicitude-package-wikitude-ionic/51968/8?u=tazaf


DL-52: update README.md to reflect current status of the project

check https://github.com/sijie/incubator-distributedlog/tree/sijie/update_readme for how does the latest README.md look like

@leighst can you ship this? I'd like to push the new README file.

@leighst @franckcuny @mgodave can any of you take a look at this? I'd like to get the README updated and then I will sync the twitter github repo with this one.


Decorator doesn't capture test classMethods

Expected behaviour: Decorating a test class should make all calls to boto3 mocked by moto
Resulting behaviour: ConnectionError raised
import boto3, os, logging, moto
from unittest import TestCase

@moto.mock_sns
class MockDoesntCapturesClassMethod(TestCase):
    @classmethod
    def setUpClass(cls):
        cls.sns_client = boto3.client("sns")
        sns_topic_arn = cls.sns_client.create_topic(Name="SNSTopic")['TopicArn']
        super(MockDoesntCapturesClassMethod, cls).setUpClass()

    def test_run(self):
        pass

Traceback
Traceback (most recent call last):
  File "/Users/dev4/Developer/xxx.co/webapp/xxx/xxx/services/tests/tests_usermanagement/test_moto_bug.py", line 9, in setUpClass
    sns_topic_arn = cls.sns_client.create_topic(Name="SNSTopic")['TopicArn']
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/client.py", line 312, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/client.py", line 592, in _make_api_call
    operation_model, request_dict)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/endpoint.py", line 141, in make_request
    return self._send_request(request_dict, operation_model)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/endpoint.py", line 170, in _send_request
    success_response, exception):
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/endpoint.py", line 249, in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 251, in __call__
    caught_exception)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 269, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 317, in __call__
    caught_exception)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 223, in __call__
    attempt_number, caught_exception)
  File "/Users/dev4/Developer/xxx.co/lib/python2.7/site-packages/botocore/retryhandler.py", line 359, in _check_caught_exception
    raise caught_exception
ConnectionError: Connection refused: POST https://sns.us-east-2.amazonaws.com/

The mock when used on a class skips class methods, am not sure if we can safely undo that without breaking an untold number of peoples code.
https://github.com/spulec/moto/blob/master/moto/core/models.py#L88-L90
@JackDanger Opinions?


Epic: Provide binary code scans

Situation
FindSecurityBugs can scan java class files - means binaries.
Currently we cannot use these kind of tools because we only support source code uploads
Wanted
We want to provide binary uploads and provide these information to dedicated products
Solution

create concept
define syntax format for configuration
more...

It should be possible to upload byte code/binary code for the code scan module.
Furthermore, there should be a new module for malware analysis. The reason, malware analysis requires different settings and will produce a very different report. However, both code scan and malware analysis require the ability to upload binary files.

With #1098 we will have a data section inside SecHub configuration model which gives us the possiblity to define and use source and also binary  content via different scanTypes on same configuration (so only one upload).
With #1154 we provide the upload to server side via REST
With #1155 we provide the upload mechanism by client

We have done all issues about this, so close the epic.


Latency during GcpCredentialRecorder loading

Hello,
I have a latency of 3s during the startup of my quarkus application. This is related to the fact that the projectId is empty, so there is an attempt to retrieve the projectId by an http call from an internal google url with a timeout of 3s.
__  ____  __  _____   ___  __ ____  ______
--/ __ \/ / / / _ | / _ \/ //_/ / / / __/
-/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2022-07-28 11:18:33,334 CONFIG [com.goo.api.cli.htt.HttpTransport] (main) -------------- REQUEST  --------------
GET http://metadata.google.internal/computeMetadata/v1/project/project-id
Accept-Encoding: gzip
User-Agent: Google-HTTP-Java-Client/1.41.8 (gzip)
metadata-flavor: Google

2022-07-28 11:18:33,335 CONFIG [com.goo.api.cli.htt.HttpTransport] (main) curl -v --compressed -H 'Accept-Encoding: gzip' -H 'User-Agent: Google-HTTP-Java-Client/1.41.8 (gzip)' -H 'metadata-flavor: Google' -- 'http://metadata.google.internal/computeMetadata/v1/project/project-id'
2022-07-28 11:18:36,453 DEBUG [io.net.cha.DefaultChannelId] (Thread-1) -Dio.netty.processId: 124158 (auto-detected)

I can get the value of the projectId using a spring-cloud-server config, but the problem is that the quarkus-google-cloud-pubsub extension's recorder is executed before the "spring-cloud-server" extension's, Suddenly there is a NPE when starting the application because the attribute value is null (https://github.com/quarkiverse/quarkus-google-cloud-services/blob/1.2.0/common/runtime/src/main/java/io/quarkiverse/googlecloudservices/common/GcpCredentialRecorder.java#L17).
quarkus:
  ...
  spring-cloud-config:
    enabled: true
    url: http://localhost:8888

  google:
    cloud:
      project-id: ${my-spring-cloud-config.gcp.projectid}

2022-07-28 14:14:14,052 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile dev): java.lang.NullPointerException: Cannot invoke "java.util.Optional.isEmpty()" because "bootstrapConfig.projectId" is null
	at io.quarkiverse.googlecloudservices.common.GcpCredentialRecorder.configure(GcpCredentialRecorder.java:17)
	at io.quarkus.deployment.steps.CommonBuildSteps$configure370655783.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.CommonBuildSteps$configure370655783.deploy(Unknown Source)
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:108)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)

If I put the projectid hard in the conf, it works fine.
Is it possible to get this extension to load after the config has been fully loaded? Or is there a workaround that I haven't thought of?
I used quarkus 2.11.1.RELEASE and quarkus-google-cloud-services 1.2.0.
Regards.

@lucaspouzac due to this extension providing a config source for secret manager, it needs to be loaded earlier (at the special boostraping phase). And the projectId is a critical configuration that is used everywhere.
There isn't an easy way to solves this, if I make the gcp extension loads after spring cloud config, someone may ask the opposite, to order gcp extension after for an other use case.
I strongly suggest loading the projectId from an env variable instead.

Thanks for your quick feedback @loicmathieu !
My use case is only sending message in gcp-pubsub.
What is surprising is that I noticed this because I did not set the properties in the application.yaml, which caused the http call (http://metadata.google.internal/computeMetadata/v1 /project/project-id) with the timeout at 3s (and therefore no recovery of the projectId), but the application works correctly. In my case, I don't need the projectId to be set at that level.
Couldn't we activate or not this call via the configuration according to the use cases?

Couldn't we activate or not this call via the configuration according to the use cases?

I was about to suggest that so I totally agree.


Split requirements for building RTD docs

We want to have a separate file requirements/docs.txt which contains the dependencies required for building RTD docs only.
Example: If a virtual environment is created and packges are installed from requirements/docs.txt only and then if the docs are build (located at readthedocs/docs/) with make html command, It should succeed.
This is discussed in PR #5100

@humitos
I researched on this issue a bit.
We need to take some design decisions on this.
Turns out that these two lines will go through all the requirements mentioned in INSTALLED_APPS and will raise an error if the app is not found.
https://github.com/rtfd/readthedocs.org/blob/86bfdffaee2a6a5143f6c7c75af2600817101ce1/docs/conf.py#L18-L19
That's the reason, make html command raises ModuleNotFoundError error for the apps starting with celery, dj_pagination, taggit and so on.
Also if these two lines are commented out, this line
https://github.com/rtfd/readthedocs.org/blob/86bfdffaee2a6a5143f6c7c75af2600817101ce1/docs/doc_extensions.py#L18
raises an django.core.exceptions.AppRegistryNotReady error which is legit as django.setup() is required to load the apps.
Another thing is that we can use somethings like this:
import django

Also, doc_extensions.py uses some setting variables from settings which are not accessible without django.setup()

This is still valid I think.

@humitos
Is this actionable or should we close it for now?


Campaign Character Swapping

Describe the feature you'd like to see added
So this was a thing in some old trainers, but even if you go through the trouble of making them work nowadays, they are very unstable (very prone to crashing) and for example if you swap in Merc characters like Hunk or Wesker they do not have a knife. It would be very amazing if a way to swap characters, similar to the skin swapping option we have right now existed. Especially with the stability and quality of life of this project.

I would personally love to see this feature get implemented! I already have a save where I'm playing as Krauser, but being able to play as the other Mercenaries characters would be super cool.

I'm gonna bump this issue again since I'm very interested in seeing this feature be implemented. Always wanted to play Hunk in the campaign.
Any chance of possibly getting this in the trainer section? @emoose

As far as I know there's issues with playing as other characters, like weirdness with some melee like Krauser's arm or Wesker's punch, and some characters cannot use certain weapons. I don't have the full list but HUNK can only use the custom TMP, Wesker can use everything except the rocket launchers... If you try the game crashes. So a fix for this would be nice?


feat: make data-state more explicit

Description

fixes https://github.com/radix-ui/primitives/issues/602
ref https://github.com/radix-ui/primitives/discussions/560#discussioncomment-3115606

Reading the comments from the discussion, I made the date-state more explicit by adding the name of the radix component. This feature will help the namespace of data-state be more clean.
I think leaving the data-state as a legacy and adding data-[component]-state will be good for now. For next major update, we can drop the support for the data-state.
If the maintainers agree on this approach, I can update all the storybook examples to new data-state representation as well. Please, any feedback is appreciated!!!

This looks like the best solution for the problem. Keeping the simple DX from data-state plus olving the problem.


Always use CSS-Vars | remove $css-vars variable

Currently, CSS vars can be turned off using a SASS variable.
There's no real need to disable CSS vars. In some cases, component styling might benefit from using CSS-Vars anyway.

You are right, the main reason to turn off was about ie11 but with the only Vue 3 version we can enable it and remove the version without them


Plugin Activation

The syntax highlighting only works, if vim is configured to use 256 colors. I think this should be reflected in the README.

how is this configuration done ? can't seem to find a working explanation.


Nuxt gives "Cannot get /" after installing "redirect-ssl" it into AWS nuxt project

Dear all
I am not sure if this issue is related to this module or with my configuration.
I am building project where i want to forcefully redirect non SSL links to SSL links.
Nuxt gives "Cannot get /" after installing and using this "redirect-ssl" it into AWS nuxt project
https://prnt.sc/xqsc05
Notes :

SSL is configured with port 443 and nuxt project is working fine on https without this redirect-ssl module
I want to forcefully redirect all non SSL routes to SSL (HTTPS)

Any suggestion or help please ?

Found solution.

Found solution.


Front: add codespaces button

As I've added the gitpod button in !1662 in a new card, I've also added the codespaces button.
I think that this PR could also close this issue.

Yes it can close this one


Fix up test infrastructure

Coverage decreased (-0.1%) to 97.531% when pulling 33d250538e243ed06b0ac686972c0a7fad4c703a on CyberiaResurrection:OrchestraTests into 502ab487dfda65ee2fa42e7606b07fc1cdc5ea7b on Algo-Web:master.


pixrem: Unit cannot be used for conversion, so 16px is used.

How do I silent this warning? I'm currently using Gatsby and find no where to disable this warning. I get that is not possible to calculate rem before vp rendering.
Thanks in advance.

pixrem does not print this message. It just adds a warning to postcss Result instance. Which runner are you using?

Still looking for a solution to this problem

@iamvdo I got the same issue. I'm using postcss-loader which runs postcss-cssnext which in turn runs pixrem. Do you know how to silent only the pixrem warning about the 16px default?
In my use case, I have the root font-size, set to either a percentage value or view width but the 16px default is perfect as fallback. Unfortunately, the warning output is useless, With so many warnings that I don't care about, I won't notice if there is warning that I actually care about.

@nodox @dotnetCarpenter You should use something like https://github.com/postcss/postcss-reporter to blacklist messages from a specific plugin

@Kentoss I dropped cssnext and choose only the postcss plugins I needed. Pixrem was not one of them.


Update lib/carousel.js for mobile offset

This is needed for the case that the viewport on mobile is too small to see the full frame of the slider, as a result a small offset is added during animation so that when the user gets to the last item in the slider it is fully visible

Merging for consumption and testing


Retrieve access token from AAD B2C

Is your feature request related to a problem? Please describe.
I am using custom authentication with AAD B2C, and would like to retrieve the access token without using a second authentication request, and then use the token as authentication towards an API.
Describe the solution you'd like
I noticed a similar issue #591 where there's a request for supporting a hydbrid flow. It seems that the response type is hard coded, and if I was able to define the response type I imagine that I would be able to retrieve the access token in a GetRoles function as a workaround, similar to whats mentioned at https://github.com/Azure/static-web-apps/issues/429#issuecomment-942805564.
Preferably it would be great if the access token was automatically added to API function request headers, similarly to a token store as mentioned in #483. Alternatively I would like the token to be set on the client principle as another way to access it.
Describe alternatives you've considered

I have tried to defineresponse_type in loginParameterNames to retrieve the access token, but with no luck as it appears it is hard coded.
I have tried to retrive the access token in a GetRoles function as described in Create a function for assigning roles, but it does not seem to be included in my case.
I have considered using MSAL to retrieve the access token, but it does not seem to be possible without a second authentication interaction for the user.

Currently it seems that my best approach is to use custom authentication with MSAL.js to handle this scenario.
Any possible solution or tips on workarounds is greatly appreciated.

Same here!

@anthonychu @simonaco @mkarmark @miwebst Can someone please address the issue?

Same issue here.
React SPA App
B2C issuing client tokens
Calling APIs behind integrated API Management (with SWA/APIManagement integration)
APIs need access tokens with client data for authorization and data access security (and end-to-end tracing)
@jon-a-nygaard , did you find a workaround or go custom MSAL based approach?

Same issue here.
React SPA App B2C issuing client tokens Calling APIs behind integrated API Management (with SWA/APIManagement integration) Backend APIs need valid access tokens with client data for authorization and data access security (and end-to-end tracing)
@jon-a-nygaard , did you find a workaround or go custom MSAL based approach?

We went with custom MSAL instead of the built in integration


numpy.std() results differ with and without numba

Hello,
I'm using numba-0.59.1 installed via pip, on a fedora 39 system with python3-3.12.3-2.fc39.x86_64 and python3-numpy-1.24.4-2.fc39.x86_64.
I get different results with vs without @numba.njit in the following:
import numba
import numpy

@numba.njit
def std_jit(X):
    y = numpy.std(X)
    return(y)

def std_nojit(X):
    y = numpy.std(X)
    return(y)

rng = numpy.random.default_rng()
X = rng.random(10000)
y1 = std_nojit(X)
y2 = std_jit(X)
if y1 != y2:
    print("numba and noNumba: KO")
else:
    print("OK")

Running this I get:
$ python test.py
numba and noNumba: KO

I expected to get identical results with and without numba.

@ntm what about with np.isclose?  Is this just a float comparison issue?

@brendancol  you are right, with this toy example math.isclose() says they're close enough.
But that depends on the data. For example if you generate X as float32's with X = rng.random(10000, dtype=numpy.float32), math.isclose(y1,y2) isn't happy anymore. I noticed this while numba-izing my code because the downstream results were (signficantly) different.
It doesn't help that numpy.std() accepts a dtype= keyword, allowing to use an accumulator of high precision than the data, but this keyword isn't recognized by the numba std(). I guess if numba's std() accepted dtype= all would be OK. So maybe this issue is actually a request to add dtype= to std()? Should I rename the issue?

Thanks, that looks like an interesting read.
As I said, my initial issue came from numba vs no-numba discrepancies working with float32 data, where the numba std() result isn't even "close" (looking at relative error with math.isclose()) to the numpy std(). Bit digging more, it seems the numba version is actually close to the numpy std(dtype=np.float64) version! Suggesting that among the discrepant results, the nyumba version was more correct... I've now side-stepped the issues by moving the data to float64's, results look good.
Thanks again, closing this.


Applicants can search status by applicant ID

Once the application status feature is operational, it would be helpful for applicants to be able to come back to CiviForm to search by their applicant ID to see the status of their program applications.
Review application status.pdf
Describe the solution you'd like
A simple search on the CiviForm Home Page by applicant ID. The result would show minimal information (just program and status). The applicant would need to login to see their past application data.
Screenshots attached.

Would go well with the ability to email guest accounts.

Would require additional research to see about the actual user need for this feature.

@msprenke Could you draft a possible design for this one, based on CiviForm's northstar future? To include:
Search by Applicant ID / Application ID
Display: Status; Link to program details; Date application was last modified
Requirement for Fresh Bucks Public Enrollment


Revert "Exclude self from unseen parties list in SyncPoller"

Reverts jpmorganchase/tessera#688

Codecov Report

Merging #706 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
- Coverage     99.49%   99.49%   -0.01%
+ Complexity     1867     1865       -2
============================================
  Files           285      285
  Lines          5552     5545       -7
  Branches        278      278
============================================
- Hits           5524     5517       -7
  Misses            5        5
  Partials         23       23

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com/quorum/tessera/sync/SyncPoller.java
100% <100%> (ø)
9 <2> (-2)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a63623...13d49c3. Read the comment docs.

Linked issue: https://github.com/jpmorganchase/tessera/issues/725


filesystem: support btrfs/xfs

Usual default is ext4 which doesn't support reflinks. Would be great to make it easy to choose (or maybe default to) a different system.
Probably needs block-based storage (e.g. AWS EBS & formatting).

related https://github.com/iterative/cml/issues/561#issuecomment-871019350

I don't follow, can't you build an image using a different FS? Yes, the fs needs to support reflinks for DVC to take advantage, setting this up makes sense to me on long-lived systems to reduce disk space consumed, but does this make sense for a cml runner use where the main feature is the ephemeral aspect of the training instance?

For a CML runner, no this isn't a requirement. But that's not the use case we are talking about here. In DVC, we would like to be able to start a (potentially long-lived) machine and run a lot of DVC experiments on that machine that will all share a common cache and would benefit from being able to reflink to/from that common cache, in which case, yes, having access to standardized images that use btrfs/xfs instead of ext4 is an important.

Yes, if you're willing to build custom images and use the same disk for both operating system and data. We already support this scenario.

If we (on the DVC side) need to figure out how to make our own default images for each (aws/gcs/etc) platform then we can do that, but this is still something I would expect to be provided by TPI

I guess we have really enjoyed how independent each of these tools are and I could see how dvc exp and TPI's task could work together, I'm missing the iterative vision for this is really trying to accomplish.
IMO this is reaching beyond what a "terraform provider" should try and do. If I was to set up a long-lived instance for a Data Scientist I would probably use the regular aws/gcp terraform provider and configure it with something like ansible and they can use a remote connection with vscode.
I guess having these premade images would be nice and then having an additional data disk that you keep past the life of the instance which you can mount to another machine later could be nice, but keeping large EBS disks can get pretty pricey over the long term.

I guess we have really enjoyed how independent each of these tools are and I could see how dvc exp and TPI's task could work together, I'm missing the iterative vision for this is really trying to accomplish.

This does not necessarily have to be provided by iterative_task.

IMO this is reaching beyond what a "terraform provider" should try and do. If I was to set up a long-lived instance for a Data Scientist I would probably use the regular aws/gcp terraform provider and configure it with something like ansible and they can use a remote connection with vscode.

This is also more along the lines of what the DVC team was thinking, but with terraform-provider-iterative defining the cloud agnostic way of provisioning standardized machines across aws/gcp/etc (i.e. using iterative_machine strictly for machine provisioning, startup and teardown, but doing everything else separately from terraform)

I think this can be wrapped up as a feature for mounting cache/persistent volumes. Doesn't quite enable what was described by @pmrowla but is a step in that direction.


multi-gpu nsight reports seem broken

For example from this build: https://buildkite.com/clima/climaatmos-ci/builds/21401#0192def8-fe3a-4986-b3ea-5942e6b9a090
With the error message:

Executable not found in current directory or standard search paths

I see this from a quick google search, so it could be from nsight, (the job doesn't seem to be running either)

There is a typo in the command and we fixed it, but got a new error here: https://buildkite.com/clima/climaatmos-ci/builds/21406#0192dfa0-46ed-4324-bd09-d2ef59aefe52


Timeout not working with infinite existential rules

While working on issue 53, I noticed that the reasoner timeout is not always respected. This setup, which uses existential rules to create an infinite set of facts, does not terminate even with the reasoning timeout set.
(I wrapped it in an executor simply to terminate after the timeout shoud have occured.)

This is an issue of VLog.
I see that the timeout is ony considered while running the Skolem chase.


⚠ Bofrost.at has degraded performance

In 9da66c5, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 861 ms

Resolved: Bofrost.at performance has improved in ed48a81 after 8 minutes.


Improved standardization of phone numbers

When looking at the list of people who I texted the most, I noticed something seemed off. I realized that a lot of my text messages weren't getting accredited to the right person (and were instead being marked as having an "Unknown" sender/ recipient) because punctuation wasn't being stripped correctly.
I looked into it a little bit and the issue was that some of the phone numbers in my iMessage backup include non-breakable spaces (unicode character 160) instead of the regular space (32). These spaces therefore weren't being subbed out by the regex correctly. In this pull request, I fixed this issue and rolled up all of the phone number standardization into a single function.

I had a lot of fun playing with this by the way, very cool! 😀

Awesome to hear Sasha!  This is definitely a project I'm passionate about, so I'm happy to hack away at anything you want to work on with it :)


Add support for backgroundSize property

This makes it possible to dynamically scale icons.

Is it really a good idea to add each css property after another. How many CSS properies does exists? Wouldn't it be easier and more pragmatic to use the cssClass option and style everything in CSS rather than in JS?

Makes sense, but that would make it a breaking change I guess?
I just added this one because I have a specific use case for this property and it's a simple non-breaking change. If other have use cases for different CSS properties it might be worth the breaking change though.

@brechtpm why would it be a breaking change? I don't think he wants to remove the existing options. From what I understand (and agree with), he just wants to use cssClass instead of having a ton of new CSS properties.

Right, the already supported properties can stay part of the API while adding cssClass, which would retain backwards compatibility.
When using the cssClass approach though, I'd expect my CSS to be the source of truth for styling my markers. The current API though does support a couple of styling properties (for example textSize and backgroundPosition), which would overrule the CSS. So further down the line I'd probably choose to refactor this to only support styling through CSS. That's the breaking change I was thinking of.

Yes I see what you mean, but for now I'd only deprecate it and maybe remove it in the far far future.

@brechtpm from what I understand cssClass should work fine for you. Going to close this as we have a solution. Please let me know in case I've missed anything!


Button click and mouse leave

If you hold the left mouse button on the touchspin buttons ('+' and '-' or the vertical buttons) and then drag the mouse pointer off the button area, the value of the input will keep increasing (or decreasing), even when you stop pressing the mouse.
The best solution I can think to solve this of is to add a "ng-mouseleave=vm.stopSpin()" into every button tag on the directive html. This way the value will stop changing when you leave the button area.

Fixed in 1.4.5.
The solution was exactly what you described.


LUCENE-10098: add note/link to GermanAnalyzer for decompounding nouns.

We can't do this out of box with the analyzer, due to incompatible
licenses. But we can make it easy on the user to do this, by linking to
repo that has sample code, documentation, and the required data files.

I think this is a good addition.
As owner of the linked repository, I tried to get some more details on the licenses, but it is impossible to include both files needed into Lucene. The dictionary is derived work (done by myself), but the original dictionary is LGPL.
Maybe we should add another sentence to explain that the decompounding requires data files which are incompatible to ASF requirements.

+1 to Backport (if still possible for 8.10).

Thanks @uschindler . I added a phrase about the data files having licenses incompatible with Apache 2.0. I also moved to 8.11 (copying the 8.11 section from branch_8x, it was missing in main).


Use minimum and maximum value of an integer property to determine java type long

Use the minimum and maximum properties as a hint to the java type of an integer.
Given the simple json object below we can infer that the type will be a long because the minimum value is to small.
{
  "type" : "object",
  "properties" : {
    "longProperty" : {
      "type" : "integer",
      "minimum": -2147483649
    }
  }
}

resolves #375

Excellent, thanks. Are we missing a json file here?

No worries, just added it now as it was missed from previous commit. Guess CI can be kicked off again now.

A very thorough change, thanks! Could you squash these two commits into one please and I'll merge.

@joelittlejohn I have squashed into one commit and CI is green. Ready for you to merge when you're ready

Brilliant, thanks!!