CEL causes build failure with --config=clang

Title: CEL causes build failure with --config=clang
Description:
The issue is similar to the previous GCC one, https://github.com/envoyproxy/envoy/commit/bd1dca3cf366bc5287295de73e4354d2f5d1f1d9 (https://github.com/envoyproxy/envoy/pull/31456) causes CEL-related components and extensions fail to build with --config=clang. It also affects non-contrib Envoy build.
ERROR: /build/bazel_root/base/external/com_google_cel_cpp/runtime/internal/BUILD:104:11: Compiling runtime/internal/errors.cc failed: (Exit 1): clang-14 failed: error executing command (from target @com_google_cel_cpp//runtime/internal:errors) /opt/llvm/bin/clang-14 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' ... (remaining 32 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/com_google_cel_cpp/runtime/internal/errors.cc:14:
In file included from external/com_google_cel_cpp/runtime/internal/errors.h:22:
In file included from external/com_google_cel_cpp/base/values/map_value.h:34:
external/com_google_cel_cpp/base/memory.h:92:7: error: no matching function for call to 'operator delete'
      ::operator delete(static_cast<void*>(p), n * sizeof(T),
      ^~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/new:155:6: note: candidate function not viable: no known conversion from 'unsigned long' to 'std::align_val_t' for 2nd argument
void operator delete(void*, std::align_val_t, const std::nothrow_t&)
     ^
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/new:153:6: note: candidate function not viable: requires 2 arguments, but 3 were provided
void operator delete(void*, std::align_val_t)
     ^
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/new:144:6: note: candidate function not viable: requires 2 arguments, but 3 were provided
void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT
     ^
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/new:180:13: note: candidate function not viable: requires 2 arguments, but 3 were provided
inline void operator delete  (void*, void*) _GLIBCXX_USE_NOEXCEPT { }
            ^
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/new:130:6: note: candidate function not viable: requires 1 argument, but 3 were provided
void operator delete(void*) _GLIBCXX_USE_NOEXCEPT
     ^
1 error generated.

The CI gives a green light since it only checks build against --config=libc++. Maybe we have to check --config=clang and --config=gcc build in the CI.
Repro steps:
Apply the following patch,
diff --git a/ci/do_ci.sh b/ci/do_ci.sh
index 1c04c42502..fb5b7dafa5 100755
--- a/ci/do_ci.sh
+++ b/ci/do_ci.sh
@@ -544,10 +544,10 @@ case $CI_TARGET in
         # This doesn't go into CI but is available for developer convenience.
         echo "bazel fastbuild build with tests..."
         echo "Building..."
-        bazel_envoy_binary_build fastbuild
-        echo "Testing ${TEST_TARGETS[*]}"
-        bazel test "${BAZEL_BUILD_OPTIONS[@]}" \
-              -c fastbuild "${TEST_TARGETS[@]}"
+        # We will pass the clang with libc++ build.
+        bazel build --config=libc++ -c fastbuild //source/extensions/filters/common/expr:evaluator_lib
+        # But we will fail in the following clang with libstdc++ build.
+        bazel build --config=clang -c fastbuild //source/extensions/filters/common/expr:evaluator_lib
         ;;

     dev.contrib)

and
./ci/run_envoy_docker.sh './ci/do_ci.sh dev'

Relevant Links:
#31760, #31856
CC @kyessenov @phlax

Actually I think #31894 will solve the issue but the PR has been dropped.

cc @ravenblackx


Fix: fix cairo-rs dependency after main branch rebase

On the January 4th, @Eikix rebased the open-dust cairo-rs fork, cairo-foundry branch.
It appears it broke the build process of the repository cairo-foundry.
@ptisserand offered to try and debug it.

Build issues appears when switching revisions:
-source = "git+https://github.com/onlydustxyz/cairo-rs?branch=cairo-foundry#c066cfac5f1f484841dd3abf5cb48b1e93a04b0e"
+source = "git+https://github.com/onlydustxyz/cairo-rs?branch=cairo-foundry#903950f23cb3670dd30f759d5f6cb8f60ce28d1a"

For the record, cairo-rs previous cairo-foundry branch commit was based on https://github.com/lambdaclass/cairo-rs/tree/b99f77f65156394b7e4a7c1dd52839e28f45ccbf
Here are the modifications done between b99f77f65156394b7e4a7c1dd52839e28f45ccbf and c066cfac5f1f484841dd3abf5cb48b1e93a04b0e:

Logs between cairo-rs main and cairo-foundry branch
Differences between cairo-rs main and cairo-foundry branch


Topic "Descriptor for Applications, Components, and Libraries" - sap.ui.component.create doesn't exist

The documentation topic "Descriptor for Applications, Components, and Libraries" mentions several times sap.ui.component.create but that API doesn't exist (or has never existed).
OpenUI5 Version
Since 1.61.0
URL (minimal example if possible):
https://openui5nightly.hana.ondemand.com/#/topic/be0cf40f61184b358b5faedaec98b2da
What is the expected result?
Documentation improvement.
At least the above API should be replaced by Component.create whereas Component is the required module via sap.ui.define or .require.
The factory function sap.ui.component has been deprecated since 1.56.

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Niya

Descriptor for Applications, Components, and Libraries has been adapted. Parts of the description related to the manifest property also had been outdated, as well as some notes regarding the now deprecated sap.ui.component API.


OPSEXP-1357 Add helm-install action

OPSEXP-1357

this should be reverted and the usage of https://github.com/azure/setup-helm suggested instead


'claim_people_path' not written

This action should let a user claim a Person record if it is not connected to a User.
The goal is to let Users add a Person without requiring that human to be signed up, then let the human claim the Person profile later.

Taking the importance of the goal, I think the proper method would be to email an admin with that person's email address, and have them send a selfie with a hand-written note with some specific verification information. (What do you love about Wichita? etc.)
It would be a manual process of verification from Admin's but I think it would work.

We could tie in some social networking accounts as well. If we know their Facebook or Twitter account, we can use a login dialog to verify them. We could also do a simple email verification. Thoughts?

We need to have non-public information to verify with, but whatever that is I'm for it.

Not really a thing anymore


RequestRateLimiter functionality -  possible conflict with a redis

Hi,
After the Gateway migration, the following situation occurred with the use of the RequestRateLimiter functionality:
Migration to: spring-boot: 2.3.4.RELEASE / spring-cloud: Hoxton.SR8.
I use an internal cache to implement a business rule, a simple example below, the problem comes while reading from cache.
At this point of get() the flow is interrupted.
public class TesteFilter implements GlobalFilter {

    @Autowired  private RedisTemplate<String, String> redisTemplate;

    @Override
    public Mono<Void> filter(ServerWebExchange exchange, GatewayFilterChain chain) {
        String value = redisTemplate.opsForValue().get("product");  // problem occurs here when using RequestRateLimiter
		 ...
        return chain.filter(exchange);
    }
}

If I remove the configuration below RequestRateLimite, the cache and application will work perfectly again:
- name: RequestRateLimiter
  args:
	redis-rate-limiter.replenishRate: 150
	redis-rate-limiter.burstCapacity: 165

Before migration with the same settings, the internal cache works perfectly: spring-boot: 2.2.8.RELEASE / spring-cloud: Hoxton.SR5

What problem? Can you please provide an error or stack trace?

No log is output.
When the flow enters the get method, it no longer leaves.
And the next requests no longer reach this Filter.
Removing the RequestRateLimit configuration, the cache's get method starts to work correctly.

Are you using the reactive redis template?

No. I am using spring-boot-starter-data-redis.
I couldn't get it to work using reactive redis template.
the same situation occurs: https://github.com/spring-cloud/spring-cloud-gateway/issues/1118
You would have a simple example of reactive redis template use in a filter class.
Congratulations on the excellent work on the Spring Cloud.
Thanks.

Using blocking redis will not work. You must use the reactive version

We moved to the reactive redis it worked perfect.
Thank you.


js.scoped() crashes compiler

This issue was originally filed by<EMAIL_ADDRESS>
I get a message in the Dart Editor that says the compiler is crashing. I was able to narrow it down to the js.scoped() function. This was working before until I updated today.
OS: Ubuntu 13.04
Dart Editor version 0.5.20_r24275
Dart SDK version <IP_ADDRESS>_r24275
Code:
<!DOCTYPE html>
<html>
  <body>
    <script type="application/dart">
      import 'package:js/js.dart' as js;
      void main() {
        js.scoped((){});
      }
    </script>
    <script src="packages/browser/dart.js"></script>
  </body>
</html>
Error:
--- 27-Jun-2013 10:08:46 PM Running pub deploy ... ---
Pub deploy failed, [1] Finding entrypoints...
Copying   web/                             → deploy/
Compiling web/out/test.html.dart           → deploy/out/test.html.dart.js
packages/js/js.dart:993:62: Warning: Using "MirrorSystem.getName" may result in larger output.
    String member = symbol is String ? symbol : MirrorSystem.getName(symbol);
                                                             ^^^^^^^
Compiling web/out/test.html.dart           → deploy/out/test.html.dart
packages/js/js.dart:993:62: Warning: Using "MirrorSystem.getName" may result in larger output.
    String member = symbol is String ? symbol : MirrorSystem.getName(symbol);
                                                             ^^^^^^^
web/out/test.html.dart:1:1: Error: The compiler crashed when compiling this element.
// Auto-generated from test.html.
The compiler is broken.
When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.
The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.
Please include the following information:
* the name and version of your operating system,
* the Dart SDK build number (build number could not be determined), and
* the entire message you see here (including the full stack trace
  below as well as the source location above).
Codegen work list is closed.
#0      CodegenEnqueuer.internalAddToWorkList (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:479:7)
#1      Enqueuer.addToWorkList (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:75:26)
#2      Enqueuer.processInstantiatedClassMember.processInstantiatedClassMember (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:152:29)
#3      BaseClassElementX.forEachMember.<anonymous closure> (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1076:47)
#4      LinkEntry.forEach (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart:77:8)
#5      ClassElementX.forEachLocalMember (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1153:35)
#6      BaseClassElementX.forEachMember (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1076:38)
#7      Enqueuer.processInstantiatedClass (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:114:37)
#8      Enqueuer.checkNoEnqueuedInvokedInstanceMethods.<anonymous closure> (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:107:35)
#9      CompilerTask.measure (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/compiler.dart:847:37)
#10     Enqueuer.checkNoEnqueuedInvokedInstanceMethods (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:102:17)
#11     Compiler.processQueue (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/compiler.dart:628:55)
#12     Compiler.runCompiler (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/compiler.dart:577:17)
#13     Compiler.run (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/compiler.dart:386:18)
#14     Compiler.run (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/compiler.dart:401:7)
#15     Compiler.run (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart:161:29)
#16     compile (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/compiler/compiler.dart:16:15)
#17     compile.<anonymous closure> (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/pub/lib/src/dart.dart:24:28)
#18     Future.Future.sync (dart:async/future.dart:10:31)
#19     compile (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/pub/lib/src/dart.dart:17:14)
#20     DeployCommand.onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///mnt/data/b/build/slave/dart-editor-linux-trunk/build/dart/sdk/lib/_internal/pub/lib/src/command_deploy.dart:41:30)
#21     _ThenFuture._zonedSendValue (dart:async/future_impl.dart:355:24)
#22     _TransformFuture._sendValue.<anonymous closure> (dart:async/future_impl.dart:332:48)
#23     _ZoneBase._runInZone (dart:async/zone.dart:70:17)
#24     _ZoneBase._runUnguarded (dart:async/zone.dart:98:22)
#25     _ZoneBase.executeCallback (dart:async/zone.dart:56:23)
#26     _TransformFuture._sendValue (dart:async/future_impl.dart:332:26)
#27     _FutureImpl._setValue (dart:async/future_impl.dart:185:26)
#28     _FutureImpl._setOrChainValue (dart:async/future_impl.dart:320:16)
#29     _ThenFuture._zonedSendValue (dart:async/future_impl.dart:361:21)
#30     _TransformFuture._sendValue.<anonymous closure> (dart:async/future_impl.dart:332:48)
#31     _ZoneBase._runInZone (dart:async/zone.dart:70:17)
#32     _ZoneBase._runUnguarded (dart:async/zone.dart:98:22)
#33     _ZoneBase.executeCallback (dart:async/zone.dart:56:23)
#34     _TransformFuture._sendValue (dart:async/future_impl.dart:332:26)
#35     _FutureImpl._addListener.<anonymous closure> (dart:async/future_impl.dart:239:30)
#36     _ZoneBase._runInZone (dart:async/zone.dart:78:19)
#37     _ZoneBase._runGuarded (dart:async/zone.dart:95:22)
#38     _ZoneBase.runAsync.<anonymous closure> (dart:async/zone.dart:104:18)
#39     _asyncRunCallback._asyncRunCallback (dart:async/event_loop.dart:9:15)
#40     _createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:8:13)

This issue has been moved to dart-lang/pub#587.


Couldn't find edgemesh-agent work on edge node

kubectl get nodes
NAME           STATUS     ROLES                  AGE     VERSION
edge           NotReady   agent,edge             2d16h   v1.21.4-kubeedge-v1.9.2-kubesphere-2-43300038e
k3s-master     Ready      control-plane,master   3d18h   v1.21.5+k3s2
edge-node-01   Ready      agent,edge             33h     v1.21.4-kubeedge-v1.9.2
[root@VM-12-11-centos ~]# kubectl get pod -A
NAMESPACE              NAME                                         READY   STATUS        RESTARTS   AGE
default                echo-edge                                    1/1     Terminating   0          47h
kubeedge           edgemesh-agent-6czj4                         1/1     Running       0          33h
default                nginx-daemonset-gfdbj                        1/1     Running       0          21h
journalctl -u k3s -f
"Couldn't find node internal ip annotation or label on node edge"
"Couldn't find node hostname annotation or label on node edge"
Couldn't find node internal ip annotation or label on node edge-node-01"
Couldn't find node hostname annotation or label on node edge-node-01"

edgemesh-agent is a daemonSet，you can focus on this daemenset's desires.
Maybe it's a problem caused by node taint tolerance.


error

2024-07-02 10:27:58 | INFO     | 74 - Detected 1 sessions | 0 proxies
2024-07-02 10:27:58 | INFO     | 351 - asd | Wait 15s before session start
2024-07-02 10:28:14 | ERROR    | 133 - asd | !Unknown error while getting Access Token: 403, message='Forbidden', url=URL('https://api-gw-tg.memefi.club/graphql')

ahh with proxy thats working
damn =
if i dont want to use proxy why they blocking my ip ? =\

just tell me please .
this bot also do the tasks ? or only taps ?

no, it just taps


Zed REPL (almond) seems to hang?

I have installed almond for scala 3.3.3 globally following this guide https://almond.sh/docs/install-advanced.html#creating-an-almond-launcher-and-installing-it-newer-launcher
in Zed with the Scala extension when I try to evaluate a line with Zed's built in REPL it permenantly hangs without evaluating anything (I know the kernel works in jupyter-lab), and with jps -mLV I can see the kernel process zed started

Do you think it's related to the metals extension somehow? I know very little here, but I wonder if this is a problem also without this extension?


[Minion] In ConvertToRawIndexTaskExecutor, change the uploaded file name to segment name

Instead of hardcoded file name, use segment name so that if we decompress the tar file from controller, we can get a directory with segment name
Also add logs if no column get converted. (We still need to upload the segment to update the segment ZK metadata)

Codecov Report

Merging #1758 into master will decrease coverage by 0.12%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
- Coverage   68.12%   67.99%   -0.13%
==========================================
  Files         834      834
  Lines       40538    40549      +11
  Branches     5335     5337       +2
==========================================
- Hits        27616    27573      -43
- Misses      11072    11114      +42
- Partials     1850     1862      +12

Impacted Files
Coverage Δ

...minion/executor/ConvertToRawIndexTaskExecutor.java
75.67% <100%> (+2.94%)
:arrow_up:

.../linkedin/pinot/core/minion/RawIndexConverter.java
60.97% <58.33%> (-0.36%)
:arrow_down:

...om/linkedin/pinot/client/PinotClientException.java
33.33% <0%> (-33.34%)
:arrow_down:

...in/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
:arrow_down:

...inot/broker/servlet/PinotClientRequestServlet.java
48.78% <0%> (-14.64%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
68.88% <0%> (-13.34%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
60% <0%> (-11.43%)
:arrow_down:

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
:arrow_down:

...riter/impl/FixedByteSingleValueMultiColWriter.java
85.41% <0%> (-6.25%)
:arrow_down:

.../linkedin/pinot/transport/common/SegmentIdSet.java
51.28% <0%> (-5.13%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70de36e...b61c422. Read the comment docs.


Issue with scanning repositories using git-all-secrets

When I am trying to scan all the repositories in our organization, facing the below issue:

$sudo docker run -it -v ~/.ssh/id_rsa abhartiya/tools_gitallsecrets -token=mytoken -org=myorg -scanPrivateReposOnly
.........
.........
Warning: Permanently added 'github.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@         WARNING: UNPROTECTED PRIVATE KEY FILE!          @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
Permissions 0755 for '/root/.ssh/id_rsa' are too open.
It is recommended that your private key files are NOT accessible by others.
This private key will be ignored.
key_load_private_type: bad permissions
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
panic: exit status 128
goroutine 462 [running]:
main.gitclone(0xc420435b60, 0x2c, 0xc4201fb6a0, 0x1e, 0xc420540a10)
/data/main.go:75 +0x387
main.executeclone.func1.1()
/data/main.go:106 +0x4e
main.enqueueJob.func1(0xc42083d590)
/data/main.go:45 +0x27
created by main.enqueueJob
/data/main.go:47 +0x6a

All the files in .ssh folder has 600 permission.
Can you suggest anything to solve this issue? If you can post a video in youtube for this, that will be a great help for everyone. Thank you.

By just looking at the command you pasted above, it doesn't look like you are passing the SSH key correctly by mounting the volume - sudo docker run -it -v ~/.ssh/id_rsa abhartiya/tools_gitallsecrets -token=mytoken -org=myorg -scanPrivateReposOnly.
Please read the documentation as I have given plenty of examples on how to do this. Feel free to open this again if you still have issues.


Enable AS Tabular Server mode

Added option to Install AS different server modes, this enables installation in Tabular mode.
https://msdn.microsoft.com/en-gb/library/hh231722.aspx

Hi @matt2005, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@matt2005, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

AppVeyor error appears to be unrelated to pull request

It is required that you provide adequate test coverage for the code you change. Contribution Guidelines -Adding test coverage for DSC resources

If there is no update of the pull request within 7 days, we will close the pull request.  After that, if you have an update, feel free to reopen the pull request or a new pull request.

Closing because the pull request has not been updated or feedback given for 21 days.  Once you update the code, please feel free to reopen the pull request.  Thanks, Travis.


Error: [CM6][simple-embeds] Using a deprecated package: "@codemirror/rangeset"

This error message shows on the console on startup.
There's also this link in the details, among other things: https://discuss.codemirror.net/t/release-0-20-0/4302
I have the newest Obsidian Insider version, so it's probably related to their recent CodeMirror migration. They have this guide.

+1

+another

Same!

Please just like the issue if you have no information to contribute. It's annoying to get notifications with no actual content.

that’s all i have: an error message on the developer screen, and it’s alarming to see without context other than that several plugins report the identical error—all w/out further info
-L.W. Brown
via 8s+

On Aug 29, 2022, at 09:31, NomarCub @.***> wrote:

Please just like the issue if you have no information to contribute. It's annoying to get notifications with no actual content.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Which other plugins @lwb52? Did you make issues for those? Would you link them here? It'd help track them and could potentially help different developers find a common solution.

Sorry, been busy. Thanks for reporting. I'll try to figure out an alternative soon.
Or if anyone feels like taking a look, go for it.

For anyone planning a PR, the guide I linked from the Obsidian devs is probably the best place to start with the CodeMirror changes.
I also found this commit in the official sample plugin, that does the migration there, in a simpler environment: https://github.com/obsidianmd/obsidian-sample-plugin/commit/b46f6c93228713d3dd98c9aa1ad2645c4bb916b0

This error is caused by:
import { RangeSetBuilder } from "@codemirror/rangeset";

RangeSetBuilder should be imported from @codemirror/state in CodeMirror 6.
So the solution is to change @codemirror/rangeset to @codemirror/state.

Thanks to @NomarCub for fixing this!


more extensive readme - project needs

Add project needs by skillset to the readme.  Don't forget about non-technical users such as designers, testers, and copywriters.

Covering the design needs in my latest pull request. @colinxfleming do you think the ReadMe properly describes the 'project needs' for developers?

As we get closer to MVP I think we're going to spend more and more time testing and drafting directions. We've started to attract some nontechnical interest. My current thinking is to revisit in mid to late May and develop a testing plan/start a CM-led instructions manual team to write up things in the wiki.

(Backlogging since we're not actively working on it.)

Remixed to reflect readme changes in #356. Need to flesh out nontechnical help.


Acceptance Criteria Not Mapped to AzureDevOps

Trying to Migrate my project from Jira to AzureDevOps, but Accept Criteria not mapped in AzureDevOps.  I've try to add this in the field but it didn't work.

Can you please help me on this.
Thanks!!

itry using this and its working
{
"source": "Acceptance Criteria",
"source-type": "name",
"target": "Microsoft.VSTS.Common.AcceptanceCriteria"
}
but when I see my logs I have an error.  but the Acceptance Criteria is now migrated to azureDevOps. hmmm...

This is resolved


Add Ryan's aboutus and PPP

Codecov Report

Merging #11 (c8aa021) into master (593608e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593608e...c8aa021. Read the comment docs.

@ryanwalterlee need to add your part of the user guide too

The user guide part, I only did the image, which is already there. I however changed the other image to suit our app. Let me know if there's any part I missed.


fixes Multimap.withSortedSet().map() for incomparable values

see #1466

Codecov Report

Merging #1865 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #1865      +/-   ##
===========================================
+ Coverage      98.1%   98.1%   +<.01%
- Complexity     4983    4986       +3
===========================================
  Files            88      88
  Lines         11359   11361       +2
  Branches       1498    1498
===========================================
+ Hits          11144   11146       +2
  Misses          113     113
  Partials        102     102

Impacted Files
Coverage Δ
Complexity Δ

...in/java/javaslang/collection/AbstractMultimap.java
95.5% <100%> (+0.05%)
118 <4> (+3)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25699ab...bd22734. Read the comment docs.

Thank you, it looks great!


[V4] Collapse using card component

Hi,
Fix for https://github.com/twbs/bootstrap/issues/18375
But with this PR Collapse plugin is now dependent of cards, So if you're ok with that I'll work on how to remove this dependency.
A preview from the result :

Could you update the Accordion in js/tests/visual/modal.html too please?

But with this PR Collapse plugin is now dependent of cards, So if you're ok with that

Yeah, that's fine. We can leave removing the dependency to a future pull request.
CC: @mdo for review

Done for the modal.html collapse.
Thank you for your feedbacks

Overlaps with #17159.

I did changes :+1:

Since the merge of #17159 by @mdo I rebased my PR.

This is why I created a class .card-collapse .
With .card-collapse :

With .card-block :

/CC @cvrebert @mdo

Hey @Johann-S, I missed this completely. Can you update this PR to resolve the conflicts? Would love to get this merged :). I'd also ask that you use the changes I made in #20870 so we can avoid the addition of .card-collapse entirely.

Sure I'll work on it !

Thank you @mdo for what you've done on #20870.
And it's done I've made the changes 👍

Do we need to silence these Hound errors or is there something else we need to change?

Oh wait, sorry missed the file that's in—we're working on that elsewhere I think. Cool!

I think @mdo you forget this PR in the v4 Alpha 5 Ship list (https://github.com/twbs/bootstrap/issues/20630) or I'm wrong ?


how to modify in order to pull the latest version of the galaxy roles

right now I see that all the roles were downloaded and committed to this repository, but I would like to use the latest versions to benefit from bug fixes and so on
sorry I'm very new to Ansible so I don't know how to do this on my own yet.. but I've tried many Laravel playbooks and so far yours is the most current that works on the latest Ubuntu and frankly it's the only one that's worked so far for me so kudos to you for sharing it!

Well most roles can just be updated / replaced. That is what I have been doing until recently. Only when there are customized parts you will need to merge changes like in a git merge. Thanks for letting me know you like the efforts made and either good luck with Stedding or do join Anstead.


Setting POLOLENDER_APIKEY via "heroku config:set" command is ingesting key/secret values improperly

While following the instructions for setting up poloLender in Heroku, I attempted to set my environmental variable using the following command:
heroku config:set POLOLENDER_APIKEY={\"key\":\"MYKEY\",\"secret\":\"MYSECRET\"}
This resulted in the following output, which suggested that only the "secret" value was ingested (no "key" value):
Setting POLOLENDER_APIKEY, POLOLENDER_APIKEY and restarting ⬢ rocky-atoll-57901... done, v17 POLOLENDER_APIKEY: "secret":"MYSECRET"
Sure enough, "heroku config" shows only the "secret" value. This issue causes app deployment to fail.

@sunweiyang , could you let me know the heroku config:set command you are using and its output?
Please just replace with * characters from the key and secrete and copy+paste.

Here are my heroku config:set and heroku config commands. I've obfuscated my own key and secret values.
You'll notice that I have only ETH listed in my POLOLENDER_LENDMAX and POLOLENDER_MINRATE environment variables. That's because when I try to have both BTC and ETH, the same thing happens; only the last key-value pair gets set.
$ heroku config:set POLOLENDER_APIKEY={\"key\":\"*******************\",\"secret\":\"*******************\"} Setting POLOLENDER_APIKEY, POLOLENDER_APIKEY and restarting ⬢ rocky-atoll-57901... done, v17 POLOLENDER_APIKEY: "secret":"*******************" $ heroku config === rocky-atoll-57901 Config Vars PAPERTRAIL_API_TOKEN:      ******************* POLOLENDER_APIKEY:         "secret":"*******************" POLOLENDER_LENDMAX:        {"ETH":"#"} POLOLENDER_MINRATE:        {"ETH":"#"} POLOLENDER_REPORTINTERVAL: 30 POLOLENDER_STARTBALANCE:   {"#"} POLOLENDER_STARTTIME:      2017-05-24T10:17:00+07:00

it looks that on Ubuntu you have to use this format
heroku config:set POLOLENDER_APIKEY='{"key":"----","secret":"-----"}'

For those who may have similar errors, you can setup the config vars through the Heroku website, the last tab when you browse your app on Heroku lets you edit the config vars and it restarts the app automatically to apply the new values.


Fix squashing in CentOS

Docker-squash requires docker_py >= 1.7.2, so "easy_install -q --user docker_py==1.6.0 docker-squash==1.0.0rc6" resolves to install latest docker_py version which requires new setuptools with environment markers support. So this command success in CentOS only with latest rh-python35.
Also updated to use latest docker-squash.
@hhorak @bparees Please test. This PR is same as sclorg/mariadb-container#9

[test]

Only to note, thermostat does not have tests yet (hack/build.sh: line 87: test/run: No such file or directory). That is why tests are failing :-)

ah, right. we should have at least some sanity tests though, like checking the SCL binary is found, returning help, ... at least something for the beginning.. so I created #6.
Anyway, LGTM for now.


Integration in fast pyspark pipeline

See wip at https://github.com/LAION-AI/CommonCrawlS3Bench
Idea

Read CC from S3 using pyspark on AWS
Should be tested to be optimal
Keep the code as minimal as possible
have a clean pip package for reproducibility (example https://github.com/rom1504/python-template)
support subsampling to a small part of CC for testing

now wip at https://github.com/mlfoundations/spark-commoncrawl


Improve Input Parameter Prompt Clarity and User-Friendliness

Hello! I've been using hoard-rs to manage my frequently used commands, and I appreciate the convenience it offers. However, I've noticed that the current prompt for input parameters can be a bit confusing, especially when dealing with complex commands. I'd like to suggest a more user-friendly approach to prompting for parameters.
Current Prompt Example:
echo "My name is #first #named parameter! and I live at #city. ##Did! I #tell you!! my name, #first?"
Provide first parameter
   >

Suggested Improved Prompt:
echo "My name is #first #named parameter! and I live at #city. ##Did! I #tell you!! my name, #first?"
Provide #first
>
Provide #named parameter!
>
Provide #city
>

Explanation:
The proposed change involves asking for each parameter with its corresponding name in the prompt. This approach should make it much clearer and easier for users to understand which parameter they are being prompted for. By providing a direct reference to the parameter name, users can more accurately identify the data they need to input. This enhancement can significantly enhance the user experience and reduce confusion, particularly when dealing with complex commands.
Thank you for considering this suggestion. I believe it will improve the overall usability of hoard-rs and make it even more user-friendly for both new and experienced users.
Additional Notes:

This change could potentially improve user satisfaction and reduce the learning curve when working with the tool.
Providing descriptive parameter names in the prompt aligns with user expectations and is consistent with modern command-line interfaces.

Hey!
That's a great suggestion and an obvious improvement in UX :)
Will work on this sooner than later

Apparently i never closed this, but UX is definitely improved on this. Thanks again!


Review normalization of package and extra names

Ref: https://packaging.python.org/en/latest/specifications/name-normalization:
import re

def normalize(name):
    return re.sub(r"[-_.]+", "-", name).lower()

Note that this is not a big deal on fractal-server side, but it is creating some issues in the fractal-tasks-core for defining extras (ref https://github.com/python-poetry/poetry/issues/6819 and https://github.com/fractal-analytics-platform/fractal-tasks-core/pull/390#issuecomment-1578188213). Thus it's better to also make the right decision on the fractal-server side.

This came up here:
https://github.com/fmi-basel/cellpose_2d3d_merging/blob/main/pyproject.toml
With the packaging
# Project metadata (see https://peps.python.org/pep-0621)
[project]
name = "cellpose-2D3D-merging"
version = "0.0.1"
description = "Cellpose based segmentation combining 2D and 3D segmentation"
readme = "README.md"
license = { text = "BSD-3-Clause" }
authors = [
    { name = "Franziska Moos", email =<EMAIL_ADDRESS>},
]

# Required Python version and dependencies
requires-python = ">=3.8"
dependencies = [
    "fractal-tasks-core==0.14.1",
    "anndata",
    "cellpose",
    "dask",
    "numpy",
    "pandas",
    "zarr",
    "pydantic",
    "scikit-image==0.20.0",
]

# Optional dependencies (e.g. for `pip install -e ".[dev]"`, see
# https://peps.python.org/pep-0621/#dependencies-optional-dependencies)
[project.optional-dependencies]
dev = ["devtools", "pytest", "requests", "build", "jsonschema"]

# Build options (see https://peps.python.org/pep-0517)
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[tool.setuptools.packages.find]
where = ["src"]
include = ["cellpose_2d3d_merging"]

# Always include the __FRACTAL_MANIFEST__.json file in the package
[tool.setuptools.package-data]
"*" = ["__FRACTAL_MANIFEST__.json"]

Quick fix: do not use capital letters in project name, that is go from
[project]
name = "cellpose-2D3D-merging"
...

to
[project]
name = "cellpose-2d3d-merging"
...

Meanwhile we'll improve on this, based on https://packaging.python.org/en/latest/specifications/pyproject-toml/#name ("Tools SHOULD normalize this name, as soon as it is read for internal consistency.") and https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization (which defines how to normalize a name).

Hello @tcompa , we did switch to lower case, but we still got the same error and I see the folder created for the task virtualenv is still with the upper case letters. We are sure we used the correct wheel (we removed the previous one and the timestamp in the web interface is also from today). There might be more places affected than just the project name.
We are now trying to remove the upper case letters from all the occurrences of the module name.

I think we found the mistake on our side actually. But we anyway removed any occurrence of upper case letters from everywhere. Thank you.

I think we found the mistake on our side actually. But we anyway removed any occurrence of upper case letters from everywhere. Thank you.

Good to hear.
For the record, I had just created https://github.com/tcompa/example-fractal-server-issue-736. This package can be successfully collected, as in:

A slight variation, where I just change the name in pyproject.toml into something with capital letters (e.g. package-NAME) leads to a failure in task collection.


Default profile to line feature

Hi
I don't know if this is the correct place to post this, but is there a way to get the elevation profile to be produced by default based on a line feature within the map and disable the ability to retrieve a profile based on a drawn line?
Thanks
Mark

the sketched line geometry is passed along to be used to generate an elevation profile here.
it'd be up to you to define a hardcoded line feature of your own instead.  you can find an example of programmatically created graphics below.
https://developers.arcgis.com/javascript/3/jssamples/toolbar_edit.html

We should add an option that allows you to hide the draw tool to the configuration panel. I'll do that for the next release. For now you can paste the following css into the 'Custom Css' box on the Theme tab in the configuration panel to hide the draw tool.
.icon-draw{display:none}
You can also setup the app so a line is selected by default using the options on the 'Custom Url Parameter' tab to define a url parm that lets you select the feature to show on startup.  In this example I setup a url param called name and pointed it to the name field in the trails feature layer. Then I append the trail name I want to display to the app url like this:
http://www.arcgis.com/apps/Profile/index.html?appid=fac840867e5c41699ce73ac94fccf169&name=Loowit trail

Thank you - that really helps.
I dont suppose there is an easy way to add a logo to the app is there?

@MarkCooperSDC  you'd need to download and host the app locally and add a logo. Where would you want the logo to display?


Correct config variable in summary

Referring to wrong variable
As seen here:
https://github.com/TeachBooks/Macaulays_method/actions/runs/9549717740
copy is used but it received the label (default value used)
Should be fixed now

https://github.com/TeachBooks/Macaulays_method/actions/runs/9564121791 this shows it working now

@severinbratus , you can merge as soon as you agree


Update Australia holidays

Proposed change

Update Australia holidays (according to official sources).
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

335 of 335 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10966

Relevant Lines:
10966

💛  - Coveralls

Kings birthday is on September 23rd in Western Australia (WA) this in 2024.
https://www.wa.gov.au/service/employment/workplace-agreements/public-holidays-western-australia

Kings birthday is on September 23rd in Western Australia (WA) in 2024. https://www.wa.gov.au/service/employment/workplace-agreements/public-holidays-western-australia

Thanks for reporting this, I've created a new issue based on your comment.


Fix syntax highlighting

Hi,
I noticed that some of the text was hidden and I corrected the missing syntax highlighting.

Thank you @ggallon 🙏


Implement pydocstyle

https://github.com/PyCQA/pydocstyle

@aleccool213: This would be great; go ahead and submit a PR. I'd like to see a #noqa type functionality though.

see #340


Unexpected type after concatenate_datasets

Describe the bug
I am trying to concatenate two Dataset using concatenate_datasets but it turns out that after concatenation the features are casted from torch.Tensor to list.
It then leads to a weird tensors when trying to convert it to a DataLoader. However, if I use each Dataset separately everything behave as expected.
Steps to reproduce the bug
>>> featurized_teacher
Dataset({
    features: ['t_labels', 't_input_ids', 't_token_type_ids', 't_attention_mask'],
    num_rows: 502
})
>>> for f in featurized_teacher.features:
     print(featurized_teacher[f].shape)
torch.Size([502])
torch.Size([502, 300])
torch.Size([502, 300])
torch.Size([502, 300])

>>> featurized_student
Dataset({
    features: ['s_features', 's_labels'],
    num_rows: 502
})
>>> for f in featurized_student.features:
     print(featurized_student[f].shape)
torch.Size([502, 64])
torch.Size([502])

The shapes seem alright to me. Then the results after concatenation are as follow:
>>> concat_dataset = datasets.concatenate_datasets([featurized_student, featurized_teacher], axis=1)
>>> type(concat_dataset["t_labels"])
<class 'list'>

One would expect to obtain the same type as the one before concatenation.
Am I doing something wrong here? Any idea on how to fix this unexpected behavior?
Environment info

datasets version: 1.9.0
Platform: macOS-10.14.6-x86_64-i386-64bit
Python version: 3.9.5
PyArrow version: 3.0.0

Hi @JulesBelveze, thanks for your question.
Note that Hugging Face datasets internally store their data in Apache Arrow format.
However, when accessing dataset columns, by default they are returned as native Python objects (lists in this case).
If you would like their columns to be returned in a more suitable format for your use case (torch arrays), you can use the method set_format():
dataset.set_fomat(type="torch")

You have detailed information in our docs:

Using a Dataset with PyTorch/Tensorflow
Dataset.set_format()

Thanks @albertvillanova it indeed did the job 😃
Thanks for your answer!


Filtering returned attributes

Objective
Provide a way for users to filter what fields are returned to the user without the user needing to use jq, for example.
Acceptance Criteria

The user can specify field names and only fields matching those names are returned in the object

Related to newrelic/newrelic-client-go#159

Duplicate of #44


Problem with UISideMenuNavigationControllerDelegate

I have read the guidelines for contributing and I understand:
Issue Description
error when try to call function from delegate
func sideMenuWillAppear(menu: UISideMenuNavigationController, animated: Bool) {
print("menu appear")
}
func sideMenuDidAppear(menu: UISideMenuNavigationController, animated: Bool) {
    print("menu appear")
}

func sideMenuWillDisappear(menu: UISideMenuNavigationController, animated: Bool) {
    print("menu dissappear")
}

func sideMenuDidDisappear(menu: UISideMenuNavigationController, animated: Bool) {
    print("menu dissappear")
}

the Xcode 9 show this error
Method 'sideMenuWillAppear(menu:animated:)' with Objective-C selector 'sideMenuWillAppearWithMenu:animated:' conflicts with method 'sideMenuWillAppear(menu:animated:)' from superclass 'UIViewController' with the same Objective-C selector

@risalgue I don't have any issues with the example project. If your project is objective-C, you likely need to add @objc to the UISideMenuNavigationControllerDelegate for it to work.

I have the same, or at least a similar problem. I can't reproduce what exactly is leading to this problem, maybe it is a configuration problem related to Objective-C integration. I can get rid of the problem when I remove the default protocol implementation in the UIViewController extension. To be honest, to me it seems that forcing a global default implementation does not follow best practices anyways, even though it alleviates the necessity of providing such implementations oneself. Another issue is overriding those implementations in a Swift extension, which according to Apple is not recommended or supported, as can be seen here:

Extensions can add new functionality to a type, but they cannot override existing functionality.

@bompf thanks for your thorough investigation.
One of my goals with this library is to keep things as 'Swifty' as possible, or put another way, to not make concessions in order to support Objective-C.
For example, Objective-C does not allow for default values in function parameters, so multiple method signatures would need to be defined to support the same functionality in Objective-C. Additionally, optional methods in protocols are only supported in Objective-C and requires the additional declaration of @objc (which has other implications as well).
Ideally, I would like to remove all @objc references from the project entirely. This is admittedly a personal choice as Objective-C is the future of development with Apple products.
The need to override an extension seems like an unlikely scenario, but I do understand your point. Generally I find the current solution adequate but not ideal as it seems to not follow best practices. I'd rather have the extension than not so that developers don't have to adhere to all of the protocol's methods.
I'm open to other ideas if you have them.

I have the same error but couldn't solve it. Xcode 9 with Swift 4... Any suggestion?

@risalgue @bompf @palla89 can any of you provide additional insight on your project setup? I have multiple projects that range from objective-C to swift to a mix, and none of them return this error that @risalgue specified. Does this have to do with multiple inheritance?

Hello @jonkykong,
I have an Objective-C and Swift project, even though my main view controller which hosts the side menu in particular is a pure Swift class and descends directly from UIViewController. I will investigate more into why this issue exists in my project setup as soon as I find the time.

Hi, I solved this problem the 'ugly way' because of a deadline, commenting from line 17 to 23 in UISideMenuNavigationController.swift
// This makes adherance to the protocol optional:
extension UIViewController {
    func sideMenuWillAppear(menu: UISideMenuNavigationController, animated: Bool) {}
    func sideMenuDidAppear(menu: UISideMenuNavigationController, animated: Bool) {}
    func sideMenuWillDisappear(menu: UISideMenuNavigationController, animated: Bool) {}
    func sideMenuDidDisappear(menu: UISideMenuNavigationController, animated: Bool) {}
}

@palla89 any idea why you were getting these errors in the first place?

I Solved this problem to like palla89
Comenting the extension of UIViewController, because when adding extensions to my class, it conflicts with UIViewController Method

I can not override these functions either

it can be because my project is compile with swift 3.2 ?

I've converted the entire project to swift 4, so I think the issue is related to this, especially considering that I was using SideMenu without any warning or error on Swift 3.
I didn't investigate deeply about this problem ^^'


Accessibility of the website

In this project kindly consider the below issues:

Please change the title of the project to explain well about the purpose of the project
Great indentation maintained in the project implementation because it improved your code's professional appearance

I think I have found an issue with movement animation.
:arrow_right_hook:  https://github.com/KUBAHO3/My-Portfolio/commit/76512fe99dd7a8f41565b6a4f30e968f3c989970?diff=unified#r102373425


Support Additional CLI Publish at Release

As a post-step to a release of a full revision of the azureml sdk, a new CLI wheel is published. This new wheel takes a dependency on the new version of the azureml sdk that has just been published.
This cli wheel is then uploaded to a blob storage location.
The existing AML pipelines already have Powershell scripts for this, just need to migrate and integrate.

Pretty sure this isn't needed any more.  We'll Open a new issue if it is.


Need instructions for installing sec_downloader

The import statement for sec_downloader in the "How to use" section will not work because instructions for installing sec_downloader is not provided. This results in
ModuleNotFoundError: No module named 'sec_downloader'

Two ways to handle this:
Either add pip install sec_downloader in the README file's "Getting Started" section.
(or)
Add a line with sec-downloader = "^0.2.3" in pyproject.toml's [tool.poetry.dependencies] instead of just adding it in dev dependencies. This will make sure that the import statement will work with just pip install sec-ai

Meant to open issue here: https://github.com/alphanome-ai/sec-parser/issues/25


Adding a input validator middleware to validate users responses #20

@Aryainguz as discussed in issue #20 , added a middleware do validate answers for all the questions. If the responses does not contain expected values, I am using express-session and connect-flash to send a flash send a flash message on the questions.ejs page and the questions.ejs page rerenders.
This is how the error message looks like:

Please not this comment: https://github.com/Aryainguz/Euphoria-Check-PERMA-Meter-Express/issues/20#issuecomment-1873261472
For this PR, I have considered the affirmative value of "Do you feel a sense of purpose and direction in your life?" as "6" itself. Please let me know if this needs to be changed.

Hey @poseidontor great work but please do another PR after syncing the current project as changes has been made

@Aryainguz I have rebased the PR. It's in sync with the new changes now.


Newlines in formatted message prevents forwarding to syslog

We recently ran into a subtle issue with this appender: while we could see the messages we created using it in the journal, they were not being forwarded to the syslog socket, where as all other journal messages (i.e. ones created by other components) were being forwarded.
This is a problem if you use rsyslog to forward messages to a centralized log server, as these messages are not being forwarded.
After some debugging, we found that the problem was that our ConversionPattern contained the %n character, i.e. we had something like this:
log4j.appender.journal.layout.ConversionPattern=[myid:%X{myid}] %-5p [%t:%C{1}@%L] - %m%n%throwable
The resulting log message looks good in the forwarder, but if you use strace on systemd-journal to see what the message looks like when it is sent to the journal using something like the following command:
strace -ff -s 1000 -e 'recvmsg' -p pgrep systemd-journal`
you will find that the message buffer it receives from the forwarder looks quite strange:
recvmsg(4, {msg_name=0x7fff48b8a750, msg_namelen=128->0, msg_iov=[{iov_base="MESSAGE\n\254\0\0\0\0\0\0\0[myid:] INFO [NIOServerCxn.Factory:<IP_ADDRESS>/<IP_ADDRESS>:2181:NIOServerCnxn@1056] - Closed socket connection for client /<IP_ADDRESS>:42590 (no session established for client)\n\nPRIORITY=6\n...
Notice that instead of MESSAGE=, we see MESSAGE\n\254\0\0\0\0\0\0\0, and there is also an extra newline in there...
It turns out that is intended(!) behavior of the sd_journal_send function..  If it encounters a newline in the message, it does some odd processing:
https://github.com/systemd/systemd/blob/master/src/journal/journal-send.c#L238
                        /* Already includes a newline? Bummer, then                          * let's write the variable name, then a                          * newline, then the size (64bit LE), followed                          * by the data and a final newline */
Because the string is no longer formatted as 'MESSAGE=...' something further down in the journal decides not to forward the message to syslog.
Note that this is also (kind of) documented in the sd_journal_send man page (https://www.freedesktop.org/software/systemd/man/sd_journal_print.html)
'Note that log messages written using this function are generally not expected to end in a new-line character.'
The fix is relatively straightforward - don't put %n in your format string!  But it seems like given this limitation, the appender should do something like this:
args.add(buildRenderedMessage(event).replace("\n", ""));
So as to avoid the issue.   If you like, I can submit a PR with some changes along this line.
Thanks for listening!

Actually keeping newlines (think of stacktraces!) in the log messages is an important feature for me.
I’m also not sure if your analysis is entirely correct.
Please note that the sd_journal_send man page just talks about a newlines at the end:

Note that log messages written using this function are generally not expected to end in a new-line character.

It’s probably worth to open an issue at systemd and clarify if the "odd processing" is intended.


Adding operations to the "middle" of a GroupProcedure

We have a case in our app where we're using a GroupProcedure for a bundle of processing that always starts and ends the same way, but has some variability in the middle. The way we've been handling this has mostly been working:

In the group's initializer, create the Start and End operations. Make End dependent on Start. Call super with those two operations.
Add a MoreWorkObserver to Start that may, in will(finish:withErrors:), create a new Middle procedure, and call start.produce(operation: middle). (Each Middle thus created also gets a MoreWorkObserver, so this may continue to chain.)
The group overrides groupWillAdd(child:), and makes End dependent upon each new Middle procedure.

Sometimes—not often—this crashes because the End operation has started to execute at the point where we're trying to add a new dependency. I assume that this is because there's some asynchrony between the point where produce is called, and the point where the group hears about the new operation. Enough that that the Middle can finish finishing, and End starts up.
Is there a better way (read: safe, but still idiomatic) to implement this pattern?
One alternative I've considered, but which seems pretty heavyweight, would be to make this two nested groups: the inner group would have Start, and any Middle procedures it produced, while the outer group would contain the inner group and End. (I'm presuming that the way that GroupProcedure handles adding dependencies on its internal CanFinishGroup doesn't suffer from the race I'm running into here.)
Another alternative might be to move the code from the MoreWorkObserver to the group's child(_:willFinishWithError:), and add the dependency to End and enqueue the new procedure directly, rather than going roundabout through produce(operation:). That seems safely synchronous, at the cost of more directly coupling the group to the operations it contains.

Hi @sixten this is a great question.
Okay, so.... your approach is an interesting one. If I was doing this, I would just override child(_:willFinishWithError:) and use this to add a new child and add additional dependencies.
But your method, is effectively doing the same thing, as produce() adds the new operation to the receiver's queue - which is the group's queue in this case. So the question is, why isn't it working reliably 100% of the time?
Would you be able to share your observer code? You should have something which is a bit like this, I think:
class MoreWorkObserver: ProcedureObserver {

    var finalDependency: Procedure?

    func will(finish procedure: Procedure, with: Error?, pendingFinish: PendingFinishEvent) {
        // Business logic to determine whether to add a new procedure
        guard shouldAddNewProcedure() else { return }

        // Create a new procedure
        let newMiddle = MiddleProcedure()
        finalDependency?.addDependency(newMiddle)
       newMiddle.addObserver(MoreWorkObserver())

       // Produce new procedure using the pending finish event
       // This guarantees that the new operation is produced before the receiver finishes.
      procedure.produce(operation: newMiddle, before: pendingFinish)
    }
}

Take a look at the PR which added the internal event queue: https://github.com/ProcedureKit/ProcedureKit/pull/668 this usage case is an example.

Now all of this is a little tricky, we've got a custom observer, which sort of recursively does some business logic and then decided whether to add a new procedure (of the same type) and then it has to handle all of the "boilerplate" to keep all of the dependencies in order. Surely there is a better way?
What about using a RepeatProcedure? It would work something like this:
class StartMiddleEndGroup: GroupProcedure {
   init() {
        let start = StartProcedure()
        let middle = RepeatProcedure {
             guard shouldAddNewProcedure() else { return nil }
             return Middle()
        }
        middle.addDependency(start)
        let end = EndProcedure()
        end.addDependency(middle)
        super.init(operations: [start, middle, end])
   }
}

Depending on the logic for figuring out whether you have a new Middle() or not just needs to be expressed as either:

a () -> Middle? closure (as in this example above)
or, an Iterator with Middle associated element type.

Then RepeatProcedure will essentially do all of the housekeeping for you. It will schedule a new instance of your procedure, execute it, and keep itself alive until the iterator runs out.
This makes your code so much easier to read and understand, as your EndProcedure just depends on the RepeatProcedure.

Tackling the first part first: the gist of the observer matches what you've sketched, with a couple of differences:

The code in the production app does its evaluation and production in a Core Data performAndWait block. But I've also tried moving the call to produce outside of the block (in case the calling queue was significant) and seen the same failure.
I'm not currently passing the PendingFinishEvent to produce (I think the code was written before that parameter was introduced?). This may be my entire problem?
Your version adds the dependency to End before calling produce, which seems certain to prevent the issue I'm seeing. Our code does that in the group's groupWillAdd(child:) method. (In principle, there's no reason why the Middle operations should know anything about End.)

I'll be back for the design questions, but first let's see whether my problem is actually a really silly bug in my code!
  // MoreWorkObserver, somewhat simplified
  func will(finish procedure: Procedure, withErrors errors: [Error], pendingFinish: PendingFinishEvent) {
    guard !procedure.isCancelled && !procedure.failed else { return }
    guard let op = procedure as? Middle else { return }

    var nextOperation: Procedure?
    op.managedObjectContext.performAndWait {
      // ... check some stuff, set nextOperation or not ...
    }

    if let nextOperation = nextOperation {
      try! procedure.produce(operation: nextOperation)
    }
  }

  // StartMiddleEndGroup
  override func groupWillAdd(child: Operation) {
    if child is Middle {
      end.addDependency(child)
    }
    super.groupWillAdd(child: child)
  }

Hi @sixten yeah, I would definitely update this to pass through the pendingFinish parameter to the produce call - that may fix the issue.
I think adding the dependency via groupWillAdd(child:) is okay...

@swiftlyfalling - any thoughts on this?

Well, I'm cautiously optimistic that changing how we're calling produce(operation:) has fixed the proximate cause of our issue. (It's never been something we can 100% reliably reproduce, but we haven't seen it since making that change.)
As far as using a RepeatProcedure as a way to implement the logic of adding an uncertain number of Middle operations: that's definitely an interesting idea. The one potential issue I see is that our logic for figuring out whether there's another Middle depends on the response from the previous one (or, in the initial case, the Start). That's the primary reason we're using the will-finish event now. It doesn't seem like there's a ready way for the logic in the RepeatProcedure to see the outcome of the previous iteration.

Hi @sixten - well good to hear that using the pendingEvent property has likely fixed the race condition. 👍

Deciding whether to continue repeating based on a result of the previous operation, is certainly possible. RepeatProcedure can be initialized using anything conforming to IteratorProtocol. So it would certainly be possible to create your own iterator:
protocol Repeatable {

    /// Determines whether or not a subsequent instance of the
    /// receiver should be executed.
    ///
    /// - Returns: a Bool, true to indicate that another instance should be executed.
    func shouldRepeat() -> Bool
}

struct RepeatableIterator<Element: Repeatable>: IteratorProtocol {

    private var iterator: AnyIterator<Element>
    private var latest: Element?

    init<I: IteratorProtocol>(_ base: I) where I.Element == Element {
        iterator = AnyIterator(base)
    }

    mutating func next() -> Element? {
        if let latest = latest {
            guard latest.shouldRepeat() else { return nil }
        }
        latest = iterator.next()
        return latest
    }
}

It's important to make sure that the implementation of shouldRepeat() is thread safe.
Indeed support for this protocol actually already exists in ProcedureKit although I have marked it as deprecated in a bid to reduce the API surface area - see: https://github.com/ProcedureKit/ProcedureKit/blob/04e33cb83dc158ea926ded602a4f072d8cb24346/Sources/ProcedureKit/Repeat.swift#L329

Gonna close this as resolved now.


vm/cc/TestObjectCompare is failing consistently under asan runs

After the recent move to OSThread vm/cc/TestObjectCompare is failing consistently under asan runs, this needs to be investigated.

3e7212e194490c52a775570464c21b0d80df952a


Vertical Connection from nodes (like a Flow Chart)

Hi @jerosoler,
First of all, Thank you for this amazing library.
I am using input/output point at the top/bottom of nodes and trying to make a flow chart with vertical connection as shown in below image.

I have overwritten the createCurvature() function by taking the reference from #20. But it is not resolving my problem. now the flow is showing like this

Could you please suggest any solution so that vertical connection can be used?
Thanks in Advance.

It's in comment: https://github.com/jerosoler/Drawflow/issues/20#issuecomment-801265399
    editor.createCurvature = function(start_pos_x, start_pos_y, end_pos_x, end_pos_y, curvature_value) {
        var center_y = ((end_pos_y - start_pos_y)/2)+start_pos_y;
      return ' M ' + start_pos_x + ' ' + start_pos_y + ' L '+ start_pos_x +' ' +  center_y  + ' L ' + end_pos_x + ' ' +  center_y  + ' L ' + end_pos_x + ' ' + end_pos_y;
    }

Thanks a lot @jerosoler. This function solved my problem.


Add push of docker image to ghcr.io

Yes, looks good to me. I'd say merge it and lets try to run it for some repo (e.g. api) by, branching and chaning the action there from 'v4'  to the git hash of this commit.
If it works, we can tag this as 'v5.0.0' :)


Android: Volume next story buttons take you to first unread, not next unread

See https://getsatisfaction.com/newsblur/topics/volume-button-next-button-takes-you-to-first-unread-not-next. The user is correct, it should use your current position is go to the next unread in the down/forward direction before it tries the up/backwards direction.

In #653 we said the volume key navigation should tie into the same navigation as the next/prev overlay. Is that not what this is doing?

So the Next Unread button is also probably doing the same thing. Try this: find a site with 10 unreads, tap on the 5th unread. The Next Unread button should take you to stories in this order: 6, 7, 8, 9, 10, 4, 3, 2, 1.

Huh.  That is how I originally had it implemented, but I changed it to the current behaviour after getting feedback that it was wrong, IIRC.  I can pretty easily change it back, though this will probably be pretty confusing for users who have experienced the current behaviour for over a year.  Thoughts?

Yeah, check it on the web. It should work that way. Any negative feedback I'd be happy to handle.

Sounds good.  I'll tweak it back in the next round of changes.


Could not determine the dependencies of task

Expected behaviour
tests should run
Actual behaviour
gradlew command fails
Steps to reproduce
I ran ./gradlew productionDebugExecuteScreenshotTests -Precord
and I am getting multiple errors concerning incompatible library versions like androidx.appcompat:appcompat. e.g.

Dependency path 'app:unspecified' --> 'com.google.android.material:material:1.0.0' --> 'androidx.appcompat:appcompat:1.0.0'
Dependency path 'app:unspecified' --> 'com.karumi:shot-android:5.4.0' --> 'com.facebook.testing.screenshot:core:0.13.0' --> 'androidx.appcompat:appcompat:1.1.0'
Dependency path 'app:unspecified' --> 'com.karumi:shot-android:5.4.0' --> 'androidx.compose.ui:ui-test-junit4:1.0.0-alpha07' --> 'androidx.compose.ui:ui-test:1.0.0-alpha07' --> 'androidx.compose.ui:ui:1.0.0-alpha07' --> 'androidx.appcompat:appcompat:1.3.0-alpha01'

Am I missing something?
Version of the library
5.4.0

gradlew dependencies error log

What went wrong:
Execution failed for task ':app:dependencies'.

In project 'app' a resolved Google Play services library dependency depends on another at an exact version (e.g. "[1.2.0
]", but isn't being resolved to that version. Behavior exhibited by the library will be unknown.

Dependency failing: androidx.fragment:fragment-ktx:1.2.0 -><EMAIL_ADDRESS>but fragment version was
1.3.0-alpha07.

Hi guys, this must be a gradle version issue.
Can you tell me which is the minimum gradle version you support??
I couldn't find it anywhere

As you can see in the examples, the minimum gradle version we are using is 6.7.  However, I'm not sure if your issue is related to Gradle 🤔

As you can see in the examples, the minimum gradle version we are using is 6.7.  However, I'm not sure if your issue is related to Gradle 🤔


Issue with running IDocumentSessions in the background of an ASP.NET

I've been running this plugin on a web app which now runs some tasks in the background via Quartz.Net.
The tasks' dependencies are injected from our IoC container, and one the dependencies is a IDocumentSession.
Since these tasks run in the background there is no http context, and opening a session crashes with the following stack trace:
System.NullReferenceException: Object reference not set to an instance of an object.
at Glimpse.AspNet.AspNetFrameworkProvider.get_HttpRequestStore()
at Glimpse.Core.Framework.Factory.<>c__DisplayClass2.b__1()
at Glimpse.RavenDb.Profiler.PointOnTimeline(String message) in c:\Projects\Glimpse.RavenDb\Glimpse.RavenDb\Profiler.cs:line 107
at Glimpse.RavenDb.Profiler.TrackSession(InMemoryDocumentSessionOperations session) in c:\Projects\Glimpse.RavenDb\Glimpse.RavenDb\Profiler.cs:line 86
at Raven.Client.DocumentStoreBase.AfterSessionCreated(InMemoryDocumentSessionOperations session)
at Raven.Client.Document.DocumentStore.AfterSessionCreated(InMemoryDocumentSessionOperations session)
at Raven.Client.Document.DocumentStore.OpenSession(OpenSessionOptions options)
at Raven.Client.Document.DocumentStore.OpenSession()
My expectation would be for glimpse to be "mute" when running outside of an http request, and I'd very much would like to avoid having to set another document store with no profiling just for the background tasks.
Is this a bug? Is there a way to avoid this and keep the profiler set up?

I'm facing this issue on Glimpse.MVC4 too, but not good solution found yet. Below are my environment:

ASP MVC4, NHibernate, Autofac, Glimpse MVC4, Glimpse NHibernate
Per request lifescope for web request
Problem occurs on background services that are initialized once from Global.asax

Due to this issue, I decided to initialize a separate DocumentStore object for my background jobs.


Linux Client Issues Across Most Modern OSes

Prerequisites

[x] Can you reproduce? - Yes
[x] Are you running the latest version of SoftEtherVPN? -Yes (version 4.36 released in 06/2021 from softether.org)

SoftEther version:
Component: [Client]
Operating system: [Linux]
Architecture: [64 bit]
Description
[Description of the bug]
Expected behavior:
The VPN Client connects to the server, gets an IP address with dhclient, and allows network access and internet access.
Actual behavior:
The VPN client connects to the server and gets an IP address with dhclient but cannot communicate on the LAN segment or the Internet.
Steps to reproduce

Download and make the VPN client and start it as root. then use vpncmd to configure a connection
Connect to the VPN server and ensure to run AccountList to see that it's Connected
Run sudo dhclient vpn_adaptername to obtain an IP address from the DHCP server and run ip a to verify it has one
Try to connect to a website such as https://ipv6-test.com/ and either only see your current ISP address or not connect at all
Try to ping the virtual hub address (in my case <IP_ADDRESS>) and get nothing

Maybe I'll pull down the absolute latest code client and/or server from Github and test it out. I understand not having internet access, but not being able to communicate on the virtual network segment when it has an assigned IP address from SecureNAT is very strange.

UPDATE: I just tested this with the latest code for both Client and Server in my home and still the same issue occurs.

sorry, this issue tracker is for 5.X versions.
can you try please building from source (this repo) ?
softether.org is SoftEtherVPN Stable edition, it is different beast.

@chipitsine as you can see in my Update above, I have also tired the the latest code from this branch. It has the exact same issue sadly.

UPDATE: It seems Ubuntu 20.04 LTS on kernel 5.8 works with Client and Server from the repository (5.0.2-0). It just took some time to set itself up. After 2 minutes IPv4 and IPv6 seem to be working. (I tested IPv6 which is globally routed and IPv4 on a LAN device).

Since your external IP unchanged after VPN is connected, it is a routing issue unrelated to softether. You didn't add the default route.

Since your external IP unchanged after VPN is connected, it is a routing issue unrelated to softether. You didn't add the default route.

Yeah I know, I'm not too worried about the defualt route for internet traffic. My goal is to have a "Virtual LAN" between IoT devices and VPS machines.
But on my Linux laptop I would like to know how to setup the static route to send data through the VPN. I can get IPv6 to work on network that does not have native IPv6 but IPv4 is still the original IP.

If you are asking a question, state it clearly instead of speaking as if softether has a bug.

Well at first when I originaly made this issue, I couldn't communicate with the network (LAN) that I was connecting to at all when using the SoftEther vpnclient. But on Ubuntu 20.04 LTS with Kernel 5.8 it works with no issue. I need to re-test Manjaro, Fedora and my Ubuntu 20.04 with kernel 5.10 to rule out if it's a kernel issue. At first I thought it was SoftEther but now i'm starting to think it could be kernel or network stack related.
I'm sorry if it sounded like a SE bug, I thought it was at first, but after doing some testing it might be somthing on the Linux side. I made this issue to get input/feedback if anyone else was expreicing the same thing.

Close since it's not a bug. Leave comments if you found new evidence.


Less verbose readme.

Would be good to have a more clean README.md.
Currently we are using a big project as example and it turns README into a verbose documentation.

Also would be nice to reduce the technical details much as possible.
The idea is to focus on usage only. To be clean and concise.

https://github.com/nodeshift/license-reporter/commit/232f3aa74cbbe44fdce9ff2d4c3e682e8806d47d


bug:L2Block.fromFields() is not reconstructing the object (aztec.js)

I'm trying to store the block in a DB and then serve it over an API. But when I retrieve the stored (JSON)data from the DB and send over an API I can't reconstruct the L2Block-object from the data. I know there are to/fromString and to/fromBuffer, but I want to make the data stored in DB queryable.
When trying to use fromFields with the JSON-data it works, but the object is not fully reconstructed. Also, the necessary types are not exported so that I can reconstruct the object.
I've reproduced it here. But the gist of it is this....
import { L2Block } from<EMAIL_ADDRESS>// ... receiving `block`
  const jsonString = JSON.stringify(block, null, 2);
  const recreatedObj = L2Block.fromFields(JSON.parse(jsonString) as L2Block);
  logger.info(`Fields: ${JSON.stringify(recreatedObj, null, 2)}`);
  // below line produces an error
  logger.info(`Fields: ${recreatedObj.hash()}`);
// ...

...produces this...
TypeError: this.header.hash is not a function
    at L2Block.hash (/usr/main/node_modules/@aztec/circuit-types/src/l2_block.ts:139:24)
    at Object.store (/usr/main/services/explorer-api/src/database/models/block.ts:36:30)
    at onBlock (/usr/main/services/explorer-api/src/event-handler/on-block.ts:6:17)
    ...

When trying to reconstruct the obj required for fromFields I get stuck at not being able to import AppendOnlyTreeSnapshot for re-creation. It seems to be plenty of more classes that's not able to import.

Hello @FilipHarald, we've decided to just remove the function as it's non-essential. Please use toBuffer and fromBuffer methods when you need block serialization. Thank you for reporting


Not working (when placed within div)

hi, can u be a bit more specific and provide: input, expected output and actual output
thanks

Presumably they're expecting:

**test**

**test**

to come out as

test

test

instead of

**test**

test

this would be in conflict with the specification

close as won't fix?

i'd wait to see if @prnvrna wants to comment

I also have this problem.
This is the example actually ( I am not sure those specs you refer to ):
http://spec.commonmark.org/0.23/#example-108 & http://spec.commonmark.org/0.23/#example-123
http://spec.commonmark.org/dingus/?text=
`
markdown

test1
test2

`
This parses the markdown inside the div.

+1 ; In my case I was trying this:

![Factory Reset](/img/hardware/socket-reset.png "Factory Reset")

The images were not being processed; from example 108 it seems this markdown should be

I found a solution to this by accident!!! 👍
I just added a trailing forward slash to the opening div tag and it worked. I had been trying everything.
Here is an example of the code i have used successfully:

##  title
blah blah blah

note the trailing slash at the end of the opening div tag. All the content then rendered correctly, no matter how complicated i made it.
This fixes example 108 for me.

Parsedown isn't fully compatible to CommonMark (yet), see README.md for details. Parsedown (still) mostly focuses on the original Markdown specification, in which this is invalid. Please note that the original Markdown reference parser never met its own specs, that's the reason why CommonMark exists. However, you can achieve this by using Parsedown Extra:

**test**

**test**

Outputs as of Parsedown Extra's demo:

test

test


5 hub create/HUB_VERBOSE=1 hub create

Same problem here, also in BigSur

This is a known issue, workaround here: https://github.com/github/hub/issues/2655#issuecomment-735836048

Closing as duplicate of the referenced issue


Add TypeScript definitions

New Feature / Enhancement Checklist

[x] I am not disclosing a vulnerability.
[x] I am not just asking a question.
[x] I have searched through existing issues.

Current Limitation

Type declaration comments are stripped out by Babel.
Feature / Enhancement Description

Add TypeScript definition files as outlined in Creating .d.ts Files from .js files in the TypeScript documentation.
Example Use Case

Add type definitions to lib/ directory.
Update build step in package.json with && tsc.
Definitions will be included when publishing the package.
Rejoice.

Alternatives / Workarounds

No alternatives or workarounds exist.
3rd Party References

There is no @types/parse-server-api-mail-adapter package.

🎉 This pull request has been released in version 3.1.0


How to restrict admin for non admin user

Hi,
I'm trying to to restrict non Administrator user but not working,
`    public function handle($request, Closure $next, $guard = null)
{
if(Auth::check()){
if (Auth::user()->isAdmin()){
return redirect('/admin');
}
}
    return $next($request);
}

}`

@Monilal what do you mean non-administrator user, it is restricted in our package - you're probably doing something outside of our package logic.

Like I have 3 user roles Administrator, User, Operator. if user role is Administrator than its can redirect to locathost:8080/admin otherwise its redirect to locathost:8080/home page, actually I'm trying to do only  Administrator can access /admin URL. How can I do it.

This question is outside of our package functionality, it's in Laravel code, we don't provide such support.

thank you


[PL-56710]: SMP 0.20.0 RN

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: SMP 0.20.0 RN
Jira/GitHub Issue numbers (if any): PL-56710
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d4c38e498964506d149524--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d54b66c74a1c9eaaee5410--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d54bb22870b19d021c0236--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d560412d0c7bd1ec8818e4--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d56f79c74a1cc019ee18ae--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d57009f28d94bf45f12959--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d57287824c64bd6e5612bb--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d572eeb075bdc3b264239c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d589cf51e7a4df68d09ff0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d5acf0f28d9406e3f1293c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d5b7160a1b850083f7c159--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d676bc8e21169a46d431ba--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d676f993eedb98e981b6f5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d69a2274bd9db1210c196a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d6c6397698c3d7fe47ef11--harness-developer.netlify.app


cert-manager is crashing when applying new certificate

Sometimes when applying new certificate I am getting the following error and cert-manager cannot recover or even restart:
cert-manager-f7f8bf74d-q7bqm cert-manager E1030 15:09:16.626127       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
cert-manager-f7f8bf74d-q7bqm cert-manager goroutine 208 [running]:
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/runtime.logPanic(0x18b8dc0, 0x2b738c0)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/runtime/runtime.go:74 +0xa3
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/runtime/runtime.go:48 +0x82
cert-manager-f7f8bf74d-q7bqm cert-manager panic(0x18b8dc0, 0x2b738c0)
cert-manager-f7f8bf74d-q7bqm cert-manager 	GOROOT/src/runtime/panic.go:679 +0x1b2
cert-manager-f7f8bf74d-q7bqm cert-manager github.com/jetstack/cert-manager/pkg/controller/clusterissuers.(*controller).issuersForSecret(0xc000392780, 0xc002e98780, 0x1ee6240, 0xc002e98780, 0x1eb9860, 0xc001966fc0, 0x170e)
cert-manager-f7f8bf74d-q7bqm cert-manager 	pkg/controller/clusterissuers/checks.go:42 +0x254
cert-manager-f7f8bf74d-q7bqm cert-manager github.com/jetstack/cert-manager/pkg/controller/clusterissuers.(*controller).secretDeleted(0xc000392780, 0x1ae7760, 0xc002e98780)
cert-manager-f7f8bf74d-q7bqm cert-manager 	pkg/controller/clusterissuers/controller.go:113 +0xe1
cert-manager-f7f8bf74d-q7bqm cert-manager github.com/jetstack/cert-manager/pkg/controller.(*BlockingEventHandler).OnAdd(0xc00000ebd0, 0x1ae7760, 0xc002e98780)
cert-manager-f7f8bf74d-q7bqm cert-manager 	pkg/controller/util.go:131 +0x3d
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/client-go/tools/cache.(*processorListener).run.func1.1(0x0, 0x1afdd67, 0x1)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_client_go/tools/cache/shared_informer.go:658 +0x218
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/wait.ExponentialBackoff(0x989680, 0x3ff0000000000000, 0x3fb999999999999a, 0x5, 0x0, 0xc0015d6dd8, 0x0, 0xc0005c75f8)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:292 +0x51
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/client-go/tools/cache.(*processorListener).run.func1()
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_client_go/tools/cache/shared_informer.go:652 +0x79
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc0005c7740)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:152 +0x5e
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc0015d6f40, 0xdf8475800, 0x0, 0x42d801, 0xc0015c25a0)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:153 +0xf8
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/wait.Until(...)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:88
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/client-go/tools/cache.(*processorListener).run(0xc000392880)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_client_go/tools/cache/shared_informer.go:650 +0x9b
cert-manager-f7f8bf74d-q7bqm cert-manager k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1(0xc000121170, 0xc00150fd90)
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:71 +0x59
cert-manager-f7f8bf74d-q7bqm cert-manager created by k8s.io/apimachinery/pkg/util/wait.(*Group).Start
cert-manager-f7f8bf74d-q7bqm cert-manager 	external/io_k8s_apimachinery/pkg/util/wait/wait.go:69 +0x62
cert-manager-f7f8bf74d-q7bqm cert-manager panic: runtime error: invalid memory address or nil pointer dereference [recovered]
cert-manager-f7f8bf74d-q7bqm cert-manager 	panic: runtime error: invalid memory address or nil pointer dereference
cert-manager-f7f8bf74d-q7bqm cert-manager [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x16d9944]

Environment details::

Kubernetes version 1.14
cert-manager version (e.g. v0.11.0):

/kind bug
After I recreated the Vault issuer I'm using everything is back to normal.
Is there anyway I can be sure what caused the error?

Thanks for bringing this up, we are not checking for a pointer.
/assign
/milestone v0.12

Can you provide more context to your setup? I'm trying to replicate the bug locally.

I had issuer and clusterissuer deployed (both had VaultVerified status):
apiVersion: cert-manager.io/v1alpha2
kind: ClusterIssuer
metadata:
  name: vault-staging-clusterissuer
  namespace: cert-manager
spec:
  vault:
    path: pki_int/sign/ivan-test-dot-com
    server: https://vault.kubernetes.ivan-test.com
    auth:
      appRole:
        path: approle
        roleId: "<role_id>"
        secretRef:
          name: approle-secret
          key: secretId

apiVersion: cert-manager.io/v1alpha2
kind: Issuer
metadata:
  name: vault-staging-issuer
  namespace: cert-manager
spec:
  vault:
    path: pki_int/sign/ivan-test-dot-com
    server: https://vault.kubernetes.ivan-test.com
    auth:
      appRole:
        path: approle
        roleId: "<role_id>"
        secretRef:
          name: approle-secret
          key: secretId

and certificate like this one:
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
  name: cert-ivan-test
  namespace: cert-manager
spec:
  secretName: cert-ivan-test-tls
  issuerRef:
    name: vault-staging-issuer
  commonName: blah.ivan-test.com
  dnsNames:
  - blah.ivan-test.com

I'm using old Vault version 0.10.1.

I had issuer and clusterissuer deployed (both had VaultVerified status):
apiVersion: cert-manager.io/v1alpha2
kind: ClusterIssuer
metadata:
  name: vault-staging-clusterissuer
  namespace: cert-manager
spec:
  vault:
    path: pki_int/sign/ivan-test-dot-com
    server: https://vault.kubernetes.ivan-test.com
    auth:
      appRole:
        path: approle
        roleId: "<role_id>"
        secretRef:
          name: approle-secret
          key: secretId

apiVersion: cert-manager.io/v1alpha2
kind: Issuer
metadata:
  name: vault-staging-issuer
  namespace: cert-manager
spec:
  vault:
    path: pki_int/sign/ivan-test-dot-com
    server: https://vault.kubernetes.ivan-test.com
    auth:
      appRole:
        path: approle
        roleId: "<role_id>"
        secretRef:
          name: approle-secret
          key: secretId

and certificate like this one:
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
  name: cert-ivan-test
  namespace: cert-manager
spec:
  secretName: cert-ivan-test-tls
  issuerRef:
    name: vault-staging-issuer
  commonName: blah.ivan-test.com
  dnsNames:
  - blah.ivan-test.com

I'm using old Vault version 0.10.1.

Thanks, can you also paste your commands here as well?

@KadenLNelson I was just applying the manifest file with a certificate. Other important thing to mention is that it was not a constant error. Sometimes appears, sometimes does not.

I'm experiencing the same problem, on Vault 1.1.3, with an identical stack trace on failure.
In my case, I do not have any Issuers, only a ClusterIssuer (just in case that helps rule out some potential causes).

Quick follow-up.
I swapped over to using an Issuer to create the certificate instead of a ClusterIssuer and the problem went away, so it's definitely not a configuration problem with the PKI role in Vault.

https://github.com/jetstack/cert-manager/pull/2316 Looks like this pull request fixes the issue. Can you see if you can replicate this on tag: canary?

@KadenLNelson I had to install it by templating out the Helm chart and re-applying the YAML until the webhook went up, but I can confirm that the problem persists.
I'm attempting to create a certificate in the consul namespace, and I'm seeing this error in the CertificateRequest, specifically:
apiVersion: cert-manager.io/v1alpha2
  kind: CertificateRequest
  metadata:
    annotations:
      cert-manager.io/certificate-name: test-cert
      cert-manager.io/private-key-secret-name: test-cert
    generation: 1
    name: test-cert-2088831866
    namespace: consul
    ownerReferences:
    - apiVersion: cert-manager.io/v1alpha2
      blockOwnerDeletion: true
      controller: true
      kind: Certificate
      name: test-cert
      uid: d18e1864-04a6-11ea-b546-123b4b7971c0
    resourceVersion: "18207952"
    selfLink: /apis/cert-manager.io/v1alpha2/namespaces/consul/certificaterequests/test-cert-2088831866
  spec:
    csr: <redacted>
    issuerRef:
      kind: ClusterIssuer
      name: vault-issuer
  status:
    conditions:
    - lastTransitionTime: "2019-11-11T17:15:13Z"
      message: 'Required secret resource not found: secret "cert-manager-vault-approle"
        not found'
      reason: Pending
      status: "False"
      type: Ready

Here's the certificate definition.
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
  name: test-cert
  namespace: consul
spec:
  secretName: test-cert
  issuerRef:
    name: vault-issuer
    kind: ClusterIssuer
  commonName: test.service.consul
  dnsNames:
    - test.default.svc.cluster.local

More information:
When I switch the namespace of the test-cert entry to cert-manager, it successfully issues the certificate and loads it into the secret. At this point, I'd say it's definitely some sort of permissions issue.

Fixed by #2316


Logback does not work with über-JAR

When creating a Jar with the logback dependency and then running this Jar I get this error:
LF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.

During a casual run, this works without any issues.
Replicated on both: 1.2.0 and 2.0.0
Scala version: 2.13.8
Sbt version: 1.4.9
Logback version: 1.4.4
org.slf4j.slf4j-api version: 2.0.3
Related stackoverflow issue: https://stackoverflow.com/questions/73727791/sbt-assembly-logback-does-not-work-with-über-jar (not mine)
What's more I'm pretty sure it worked as expected before slf4j upgrade to version 2.x.x.

Closing as migrating
  case PathList("META-INF", _*) => MergeStrategy.discard

to
case PathList("META-INF", xs@_*) =>
  (xs map {_.toLowerCase}) match {
    case "services" :: xs =>
      MergeStrategy.filterDistinctLines
    case _ => MergeStrategy.discard
  }

helped


Add escape_value function

In some cases, it might be useful to call escape_value as a simple function without instantiating a TeamcityServiceMessages object.
e.g.:
In [1]: from teamcity.messages import escape_value

In [2]: escape_value("That's some text in [square brackets] and |vertical bars|\n")
Out[2]: "That|'s some text in [square brackets|] and ||vertical bars|||n"

This is useful to me, because I have some bash code that emits TeamCity messages and I would like to be able to reuse this Python code to do the escaping. With this, I can change the code from:
teamcity_escape() {
  echo "$@" | python -c 'import sys; from teamcity.messages import TeamcityServiceMessages; tc = TeamcityServiceMessages(); print(tc.escapeValue(sys.stdin.read()))'
}

to:
teamcity_escape() {
  echo "$@" | python -c 'import sys; from teamcity.messages import escape_value; print(tc.escape_value(sys.stdin.read()))'
}

Note that I provide a escapeValue function to be consistent with the camelCased names that this module uses, but I also provided escape_value as an alias because that is more Pythonic and compliant with PEP-8.
Cc: @sudarkoff, @aconrad, @0x9900

Thanks! Looks good.
Could you rename escapeValue global function to escape_value? We certainly don't need both of them and PEP8 likes escape_value

Could you rename escapeValue global function to escape_value?

Done.
I also added a test for the function in 065cafe.

Thank you!


Fix a small bug of extract path from full http request path

When testing, I found there is a bug of extract path from a full http request path. This is a fix for it.

This is a very small fix. As CI passed, I'll merge it directly


Don't short-circuit on stop when restarting

Resolves https://github.com/dblock/guard-rack/issues/28.
Assume that there is syntactically valid code that is modified not to be syntactically valid. On save the restart method would run stop and then start but start would fail because of the invalid syntax.
Fixing the invalid syntax would again call restart which would call stop which would fail because the previous start invocation failed. This would short-circuit restart into failing.
(I think) the expected behavior is that restart should attempt to stop, then attempt to start, and then return success or failure based on whether or not spawn has succeeded and not on whether or not stop has succeeded. This PR does that.

This makes sense! Needs tests and an entry in CHANGELOG, please?

I no longer use this library. You're welcome to incorporate this change if you'd like, or not.


Fix/issue414

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.2%) to 88.619%

Totals

Change from base Build<PHONE_NUMBER>:
-2.2%

Covered Lines:
5999

Relevant Lines:
6654

💛  - Coveralls