Problem with MQTT connection

I am attempting to use Homie on a Wemos D1 mini.  On my work computer (Mac) I installed the latest Arduino IDE and all the required libraries for Homie 2.0.0. Everything compiles but with some warnings (or "notes"). The LightOnOff program compiles and downloads ok and I can configure it via the web interface. It then works correctly, connecting to wifi and MQTT server.
So, I decide to continue working at home on a similar Mac running the same version of MacOS. I installed the latest Arduino IDE, libraries etc. All looks good until the Wemos attempts to connect to the MQTT server and just hangs.
I've checked that all libraries are the same version on each machine. I've taken the same Wemos D1 to work and installed the LightOnOff program, taken it back home and it works. I can't find the difference between the two systems.
Is there more detailed logging info I could enable to see why the MQTT connection is hanging?
Last message on the serial port is "Attempting to connect to MQTT..."

Update:  it works ok if I use an IP address rather than a domain name for the MQTT server name.
Does this point to a problem with ESP AsyncTCP? or lower level?

That's not really enough to go off by. We need to know if you were using a different network? Different location? The difference between the 2 tests ( the one that worked and the one that didn't)

Different network and different location. Same configuration.  Only difference was that code compiled/loaded on one system doesn't work (ie MQTT connection hangs) in either place, and code compiled/loaded on the other system works in both places.  I've compared all library versions and they are the same.  So now I'm in the process of installing Platformio.

Same Arduino core version ?
Verry intresting.

More info:  the call to WiFi.hostByName(host, remote_addr) in ESPAsyncTCP fails, so the connect call returns false.  Also, in a small test prog I tested name resolution using the ESP8266WiFi connect call and it worked ok.

try an EspAsyncTCP example from https://github.com/me-no-dev/ESPAsyncTCP and see if your getting the same problem, try just connecting to website or something. if your still getting an issue then it might be a problem with EspAsyncTCP, in which you'll need to raise the issue there.

any activity? will close soon.


WIP Functions

Checklist

Issue number for this PR: #nnn (required)
Docs included?: (yes/no; required for all API/functional changes)
Test units included?: (yes/no; required)
In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

Appreciate the review, I'll jump on these after addressing the Firebase SDK stuff.

@davideast addressed your review and updated against master.


Is it possible to open the file even if it is read only?

If the file is read only I can see it on the tree but I cannot open it. Is there a way to do it?

Hello @RogerioDosSantos,
You can use my patch https://github.com/scrooloose/nerdtree/pull/576 in order to fix it.

:+1:


Improve test coverage and refactor some tests

Refactor Authentication Request tests.
Refactor Logout Request tests.
Refactor Logout Response tests.

:+1:

Thanks bro


Custom model download location

Good day!
Is it possible to have custom download location for the models? I don't have enough space to download the base model on my C drive and I wanted to download it on my other drives instead.
Thanks!

Found it, you just have to set cache_dir in the method from_pretrained(...) from transformers library


HDDS-8109. Seperate Ratis and EC MisReplication Handling

What changes were proposed in this pull request?
Push down the sendReplicateCommands from MisReplicationHandler into subclasses so that we can have different implementations for Ratis and EC.
Change implementation for Ratis to allow using all sources.
https://issues.apache.org/jira/browse/HDDS-8109
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4718760757

Looks good apart from the one comment I had above. If you fix that it should be good to commit.

Looks like TestRatisMisReplicationHandler becomes flaky with this change, will fix.

Passed 100/100 with 4c0d351dd14da1c0ecb473690a1a3201d3818d76.

Thanks @sodonnel for the review.


CIVDT-1678: Content updates

Section 2 error messages have been updated on the spreadsheet. Could this also be updated

The changes to the pages on bullet point 4 of the story hasn't been done
https://docs.google.com/presentation/d/16ybp2FPRZfvZvO4JKMKwmgAQxNfw7NF407RiDjASgPI/edit#slide=id.gb85ebc79ee_0_167
I assume this will need to be done for all 3 same pages (both, vat, duty)

Seems like bullet 5 has also been missed
https://docs.google.com/presentation/d/1CLkTjo5HU519Lc1bVYUbl1zvjjzDcporNOiGj9RDzn8/edit#slide=id.ge8a7fbf6ac_0_101

there are now separate subtasks for the bullets mentioned above, this PR is ready for review again

Section 2 error messages have been updated on the spreadsheet. Could this also be updated

Completed and approved


Members page don't work

There is an app:
https://openexchange.intersystems.com/package/Dynamic-SQL-to-Dynamic-Object
and his author's page looks like that:
https://openexchange.intersystems.com/user/David Crawford/9hr3OE02TC6A0DfkrWQHNLRyE
same for the app:
https://openexchange.intersystems.com/package/Cogs-JSON-Class
Author looks like that:
https://openexchange.intersystems.com/user/Sean Connelly/j9s3l7hFYu8HQ124vN0oTX5iumc

Done


add tagged docker image with releases

Ticket
Link to Github Issue
Problem description
Github releases only have a tag, but no docker image is associated
Build and push a docker image for each release
What's changed
Added step that builds docker image.
Successfully builds a dev docker image
Checklist

[ ] Post commit CI passes Not Required
[ ] Model regression CI testing passes (if applicable) Not Required
[ ] New/Existing tests provide coverage for changes https://github.com/tenstorrent/tt-metal/actions/runs/9672004658 (note that this pipeline only has commented out sections of code for the workflow to pass. The section to note is the new 'create-docker-image' step at the end which builds docker images.

We can't build ARM images on our machines, right? We need actual ARM hardware?

@tt-rkim  It is possible to try out cross compilation. Docker buildx does provide the ability to build ARM images via QEMU though building the image will require a bit more work making sure tagging and using the right base image works,
if that's something we want to prioritize

Nah was just curious for future work
Good to know we can easily use qemu to build


Additional details on console while running via command line using tags

Expected behavior
When running gauge specs via command line, we heavily use specs execution based on tags. It would be really nice to have all specifications enlisted on the console before the executions starts. A message on the console like "The following specifications from the directory '\specs' matched the tag: 'ABC, xyz'." would help me understand what specifications are lined up for executions.
Actual behavior
The feature is currently not available
Gauge version
Gauge version: 0.4.0

Plugins
-------
html-report (2.1.0)
java (0.4.0)

Also I think when running multiple specifications in a single execution, we should give info on the console after each spec execution whether it has passed/failed/skipped so that we do not have to wait untill the end of entire execution to look at the summary for detailed information.

Hi @kbangur, We do think it adds value to list out all specs that are ready for execution after applying filters.
Regarding the point on showing spec execution status after every spec, currently we try to convey it by marking steps as red/green based on status. Here is a sample of console execution report in verbose mode.
Do you still think we need to show the spec status after execution? If so, do you have any ideas on how it would look better?

@kbangur : Apart from seeing it on console, there is another option to see the specifications getting filtered based on tags. Spectacle, can be used for static analysis(without having to run the specs).

@kbangur and @apoorvam - regarding the request for having a pass/fail note in the console after each spec when multiple specs are being run:   My Gauge automation suite runs are through TeamCity (no color in the build logs) and runs typically have a couple hundred specs and take a while to run to completion.  Therefore, being able to easily see in the in-process run what was passing and failing was a really nice thing to have.
A solution we came up with - that has worked really well for us - was to add a log message to ScenarioExecutionHooks -> AfterSpec that prints out a pass/fail message.  (Note that 'skipped' hasn't been taken into consideration here.)    Copy/Pasting the console output - in our case this is in the TeamCity build log - into a text editor, from an in-progress run and finding failing specs, getting a general idea of pass/fail rates, etc is quick and easy.
@AfterSpec
    public void AfterGaugeSpec(ExecutionContext context) {
        if (context.getCurrentSpecification().getIsFailing()) {
            System.out.println("Spec complete - Failed : " + context.getCurrentSpecification().getName());
        } else {
            System.out.println("Spec complete - Passed : " + context.getCurrentSpecification().getName());
        }
}

That works like charm @ocary . Thank you for sharing such a simple solution :) I was just hoping this as a build in Gauge feature rather than handling it in an explicit way. Things get really difficult to read on the console with high number of executions in a single build and the Console never telling you where the execution reached!
Thanks once again :)


Cant boot without pressing spacebar and select boot with injected kext

hello, I downloaded the mojave from playstore
-created the usb
-installed clover with v4982 bacause newer versions do not show the options to select with the 64 at the end
-replaced the EFI in the usb with the hac mini EFI
-installed macos
-generated the smbios
-mounted efi with clover configrator and copied the efi folder from the usb drive to my efi in the hardrive
-reboot and it wont boot unless I press space bar and select the option- boot with injected kext..
everything is working 100% no issue, the nuc boots really fast into macos but I cant get it to boot without my intervention and thats really annoying
---HELP

Can you try resetting your NVRAM? If you don't know how, temporarily use v2.0 which comes with OC that has an option to reset NVRAM.

ok will try with v2.0 and come back

lol nvm, installed 2.0 direct to my hard drive, rebooted and it came straight to macos .. so happy now.. thanks man

Please note v2.0 is still beta. Please submit a report here: https://github.com/osy86/HaC-Mini/issues/44

oks


typo in line reference page

Topic
I was in my class teaching and I noticed tat there was a small typo on the line reference page. In the code example it says that the shown example indicated 3 stroke sizes, but it is actually showing three stroke colors. I'm unsure which ne is the desired result, but I wanted to bring it up to you all.

Yes it should say stroke colors in this case.


Update Composer dependencies (2024-05-22-00-19)

Visual regression test passed!
View the visual regression test report


Add support to reuse saved search query

Why not, there is simply an API call to retrieve all search queries saved and found the one with the matching name

Actually, this is not needed as you can always write#{My Search Query Name} in the search query


'required' parameter ignored in bulk person enrichment

When trying to use the required parameter in bulk person enrichment, it seems that it ends up being ignored. When calling directly the endpoint (e.g. with Postman) using the same request, it seems to work so the issue doesn't appear to come from the API.
One of the request being built:
{'metadata': {'key': '1'}, 'params': {'first_name': ['...'], 'last_name': ['...'], 'email': ['...'], 'min_likelihood': 6, 'required': 'work_email'}}

However, I'm getting back a 200 status code with a record that does not have a work_email field (null value)
I'm using version 1.1.3

@Layvier just tested and noticed that required works at the top level of requests but not at the individual level, we will get a fix out to support it.

Thank you, I can confirm it works now 🙌


Setting final style at non-fill animation kickoff sometimes causes frame draw

See this demo- https://samthor.github.io/web-animations-issues/setfinalstyle.html
Click in the top, white area to cause a delay (~250ms) and then an animation starts. Sometimes, not always, the final position of the animation is shown for a single frame. Click a few times.
In pseudocode, the way to trigger this is-
var finalValue = 'transform(100px, 100px)';
var player = box.animate([{transform: 'none'}, {transform: finalValue}], 2500);
box.style.transform = finalValue;

This is as per the suggestion in web-animations-js#41: the final value should be set initially, not as part of the finish callback.
The issue doesn't affect Chrome (even when the polyfill is forced); it has just appeared on Firefox (Mac, 40.0.3) and Safari 8.0.8 (10600.8.9). Safari is easier to trigger.

Note that one fix is actually to do this-
window.requestAnimationFrame(function() {
  box.style.transform = finalValue;
});

As discussed with the WA team, this whole issue could be because browsers are incorrectly doing a layout before any scheduled requestAnimationFrame calls (which the .animate triggers too). So by delaying the final value set, we overcome that.

http://jsfiddle.net/y21y89dz/

One workaround that we discussed would be to apply animated styles in element.animate() since we can't rely on RAF intercepting the rendered style with the animated style.

One workaround that we discussed would be to apply animated styles in element.animate() since we can't rely on RAF intercepting the rendered style with the animated style.

We're going to have to do this (make invalidateEffects call tick directly), unless there are any better ideas.

@samthor What is the issue you're seeing in Firefox?

@birtles It's the issue that @dstockwell identified in his jsfiddle link.

@samthor I can't tell from that fiddle what the problem is.

In 45.0 on Mac, try focusing and unfocusing the window containing the jsfiddle. Do this a few times, and you'll see a flash of red, which should never happen (since rAF should be called before anything is drawn).
In 44.0.2 (the version I had before updating to check if it wasn't fixed), the effect seemed to be more obvious.

Why should rAF be called before anything is drawn? It happens at the start of the next frame after painting the first (red) frame.

@birtles in the processing model (https://html.spec.whatwg.org/multipage/webappapis.html#processing-model-8) there should not be an opportunity to interleave other callbacks between running animation frame callbacks and updating the rendering.

Oh, I thought you were talking about the initial flash of red (which is permitted, even expected, per spec). I didn't notice the other flashing until I resize the window.

Filed Mozilla bug 1255650 for this: https://bugzilla.mozilla.org/show_bug.cgi?id=1255650


When using allowOverlap prop the onLayoutsChanged event is not fired when dragging of an item ends

Issue: When using allowOverlap prop the onLayoutsChanged event is not fired onDragStop.
I have made a sandbox showing the issue. Watch the counters above the grid and move the items to see the issue when items are dragged. This is not affecting resizing of items.

Expected behaviour:
Each time and item is dragged:

 onDragStop counter increases by 1 ✅

 onLayoutChanged counter increases by 1 ❌

 onResizeStop Counter remains the same ✅

Each time an item is resized:

 onResizeStop counter is increased by 1 ✅

 onLayoutChanged counter is increased by 1 ✅

 onDragStop counter remains the same ✅

Example of issue: https://rb7fq.csb.app/
Sandbox of issue: https://codesandbox.io/s/exciting-brahmagupta-rb7fq

I noticed this issue too. It's also noticeable in the Allow Overlap demo out-of-the-box; note how the layouts display does not update: https://react-grid-layout.github.io/react-grid-layout/examples/19-allow-overlap.html

Just realised this is a duplicate of #1564.
Leaving open for now just in case the examples and sandbox are of use, but anyone reading this might want to follow the other issue too.

I wonder if when allowOverlap is enabled it doesn't make a copy of the layout as it would when it applies compaction and collision rules, so it ends up directly mutating the layout.
E.g. this line inside the onDrag method:
https://github.com/react-grid-layout/react-grid-layout/blob/a707cf77735c0531d23524059e9e0ea7d4e5ded0/lib/ReactGridLayout.jsx#L307-L312
It looks like the compact() method creates a new array, but when we have allowOverlap it just returns the original layout object.
My hunch is that when it comes to this line in the onLayoutMaybeChanged method...
https://github.com/react-grid-layout/react-grid-layout/blob/a707cf77735c0531d23524059e9e0ea7d4e5ded0/lib/ReactGridLayout.jsx#L368-L374
oldLayout will already be equal to newLayout, so no onLayoutChange is fired.

Thanks, this is now fixed.

Hey @STRML , I've given your latest change a go on my local project and I'm still seeing the bug in the following situations:

when you change position of item that does not collide/overlap with another item, onLayoutChanged does not fire.
when you move item to overlap another item, onLayoutChanged fires intermittently
when moving overlapping items around ontop of eachother so that they remain touching, onLayoutChanged does not fire.

Just to make sure my Grid props are correct, here's what I've got it set to:

@woollsta We haven't done a new release yet so unless you're getting it from git, we wouldn't have the fix yet.

Yep it's using the one from git. Specifically my fork of this repo as I needed to modify the package.json to make it build after being fetched by yarn:
https://github.com/woollsta/react-grid-layout


[Event Request] Codeunit 103 Cust. Entry-Edit - OnRunOnAftrerCustLedgEntryLockTable

Hi Team,
In codeunit 103 we need possibility to replace and avoid using standard code with our own. Having event with handling in the  procedure OnRun, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnRunOnAftrerCustLedgEntryLockTable(var Rec: Record "Cust. Ledger Entry"; var isHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add driveclaw.ino to ArduinoLibrary

This is an example for driving 4 motors using an MPU6050 on a hand. After reading analog values from the MPU6050, if the values reach a specific threshold (such as moving the hand to the left) then the corresponding motor will move left. If the values do not reach any threshold, then no motors will run.

@TheAnton205 hey, can you please add some description!

@TheAnton205 hey, can you please add some description!

My apologies, updated!

@TheAnton205 You have been added to the contributors table! Wohoo ✨✨✨

@all-contributors please add @TheAnton205 for code

Please do star the repo!

@TheAnton205  Please do star the repo!

@TheAnton205 Please do star the repo!

of course!


Update string escapes

Description
Add syntax highlighting for upcoming import and $(...) string interpolation syntax. The string interpolation highlighting also highlights everything inside the parens as normal Roc expressions!
Also cleans up some string escapes that aren't actually supported in Roc. 😄
Checklist

[x] The commits use the Conventional Commits format

Thank you @rtfeldman!
The new version - 1.2.0 - will be available soon on the Marketplace and on the OVSX


[Feature Fix] Refine the warning message about not supportting rendering

Purpose & Change
Change the warning message when dealing with non-supported file type
Old:
No renderer could be found for the file type requested.
New:
Viewing of this file type within the OSF is not currently supported. Please download the file to view.
Resolve https://github.com/CenterForOpenScience/osf.io/issues/3907
Side Effect
None
Other related issues
The similar vague error message: No exporter could be found for the file type requested. It may also need change.

@icereval Here is a simple PR  and ready to be merged!

There should be no mention of the "OSF" or any OSF-related code in MFR; it is a standalone service.
Instead, OSF-specific messages should be handled in the OSF. Please revise the approach.


lower case all the keys in arguements to spec factories

There's some inconsistency, so we may aswell lower case everything. For example the Analysis spec factory wants a CouchUrl, the DataProcessing one wants a CouchURL. I don't think the mixed case adds anything other than a source of inconsisTencY.

@ticoann @ericvaandering shall we close this one?


Use a dp metric to measure the radius value of MDNavigationItemIcon

Looks not okay on android

Expected

https://github.com/kivymd/KivyMD/blob/cfe5aac30f50708c6208c8b33b0ef1aa390721e8/kivymd/uix/navigationbar/navigationbar.kv#L62
Proposed fix
radius: [dp(16),]

Yes, most likely a typo


Allow POST requests

Now the requests can only be GET.
In #21 we are removing the /all endpoint that was the only place mentioning POST requests.
We should probably say that POST requests are allowed everywhere since query strings can become very long for non-trivial filters (also mentioning @rartino who I think is supportive)

I'm appending here a sentence from the text removed in #21 that can be adapted and reused:
The general entry listing endpoint MUST accept both GET and a
POST-type requests, with provided POST-type URL query parameters
overriding duplicate URL query parameters provided as GET URL
query parameters.

Should we add this to the 1.0 milestone?

Are you really sure the POST is needed? Two observations on that:

according to the HTTP semantics, POST modifies the content, and apparently OPTiMaDe is far from that at the moment

length considerations: in HTTP specs GET has no length limit defined. Some web-servers have a default limit of 8KB, in practice reportedly it's safe to use up to 2000 chars. Anyway whatever complex GET-request would fit (please, correct me if I'm wrong)

While I'm not in favor of allowing POST per se (as @blokhin remarked, POST is reserved for database modifications), there are various restrictions on the length of GET request string. 2000 chars might seem a lot, but complex queries on nested property names easily approach it (to illustrate, a "simple" example from the specs is already 260 chars long).

Is there a reference on that POST "modifies the content" / "is for database modifications"?
The defining sentence of POST in RFC 7231 is "The POST method requests that the target resource process the representation enclosed in the request according to the resource's own specific semantics." It goes on to list examples, some of which modifies data, but the very first example "Providing a block of data, such as the fields entered into an HTML form, to a data-handling process;" Isn't what we are doing more or less exactly providing a "block of data" (including, e.g., a massive filter) to a "data-handling process"?
This is in difference to PUT, which says: "The PUT method requests that the state of the target resource be created or replaced with the state defined by the representation enclosed in the request message payload."
In my opinion we should just say that the API implementation MUST support that any URL query parameter may instead be provided via POST instead. I don't see why it would be difficult to support in implementations, and it avoids arbitrary length limitations.

Oh, my perception of POST/PUT was formed by now-obsolete RFC 2616 (obsoleted by RFC 7231, mentioned by @rartino).
In the light of this, I agree that we may allow using GET and POST interchangeably.

I'm appending here a sentence from the text removed in #21 that can be adapted and reused:
The general entry listing endpoint MUST accept both GET and a
POST-type requests, with provided POST-type URL query parameters
overriding duplicate URL query parameters provided as GET URL
query parameters.

I would be definitely against "MUST" since it puts extra (duplicate!) effort on implementer. Let's not succumb to creeping featurism!

I'm appending here a sentence from the text removed in #21 that can be adapted and reused:
The general entry listing endpoint MUST accept both GET and a
POST-type requests, with provided POST-type URL query parameters
overriding duplicate URL query parameters provided as GET URL
query parameters.

My understating of the REST is that POST is usually supposed to modify the resource
(see RFC 7321, section "POST"). Now this does not, as I understad, forbid using POST for queries, just would take up a function point...

@sauliusg Your point about POST vs GET was discussed upthread. The RFC you link lists example uses of POST and one of those examples is similar to ours.
If we don't put MUST we can just as well not mention this in the specification. I don't see anything in the specification right now that prevents me from serving POST if I want to.
The extra work to serve identically formed GET and POST requests is truly minimal in all web frameworks I've used. The only thing one needs to do is to stuff the POST fields into the same data structure that one put the GET url parameters in.
Isn't it nice to have a standardized way to submit arbitrarily-length filter strings?

Isn't it nice to have a standardized way to submit arbitrarily-length filter strings?

Yes, this would be a very good feature.

If we don't put MUST we can just as well not mention this in the specification. I don't see anything in the specification right now that prevents me from serving POST if I want to.

Yes, we should not put a MUST. Probably MAY.

Your point about POST vs GET was discussed upthread. The RFC you link lists example uses of POST and one of those examples is similar to ours.

Sorry, I've overloked the reference but yes, its essentially the same how understand the situation.
So in a few words:

we can specify the use POST for sending queries;

POST would circumvent the existing QS length limitations;

We can send filter strings using GET and POST equally well;

We can encode queries in any other formats (but of course the bloated ones like JSON will be little suited for GET+QS); but whether we want/need/can suppot them is a separate orthogonal issue (#267)

My opinion: I'm supportive of allowing both POST and GET, and for now use the same syntax between the two, whatever the syntax is (so both for the client and the server, it's just a matter of deciding which method to use)

If we don't put MUST we can just as well not mention this in the specification. I don't see anything in the specification right now that prevents me from serving POST if I want to.

Yes, we should not put a MUST. Probably MAY.

If we decide to make POST support OPTIONAL, it becomes a feature a client cannot rely upon. I mean if I was to implement an "universal" OPTIMADE client (or anything skyscanner-like), I would not use POST as only a subset of providers support it. Instead, I would still use GET and would have to cater to its possible shortcomings. In short, I believe that all OPTIONAL convenience features are actually not that convenient.

My opinion: I'm supportive of allowing both POST and GET, and for now use the same syntax between the two, whatever the syntax is (so both for the client and the server, it's just a matter of deciding which method to use)

Could I ask which content type would be preferable for the POST request? usage example

The default application/x-www-form-urlencoded where you can use the same string that you would use for the GET requests, or
the very common application/json format which we also use heavily for the OPTIMADE API (of course for the fields you can use the same syntax), or
both or,
basically any of them including support for eg. XML?

With application/x-www-form-urlencoded we would retain the existing protocol completely, with just your web framework delivering parameters in a POST dictionary instead of a GET dictionary, so I think it makes the most sense to use as the primary supported format.
Support for other submission formats can of course be discussed, just as we have support for other custom response formats. In fact, I think it would be great to put in the specification that you are allowed to accept things like application/vnd.optimade-_exmpl_+json as your provider-specific json-based format and application/vnd.optimade-_exmpl_+xml, etc. If a specific format becomes popular, we can then standardize it to be the meaning of, e.g., application/json.
We need to register application/vnd.optimade, though. Perhaps we should do that?

Could I ask which content type would be preferable for the POST request? usage example

The following are widely used, and easily supported:

application/x-www-form-urlencoded
multipart/form-data

We need to register application/vnd.optimade, though. Perhaps we should do that?

I don't see the need to do that. We can reuse already existing carrier formats, and I can't think of any feature in OPTIMADE that would push us to invent OPTIMADE-specific request format.

We need to register application/vnd.optimade, though. Perhaps we should do that?

I don't see the need to do that. We can reuse already existing carrier formats, and I can't think of any feature in OPTIMADE that would push us to invent OPTIMADE-specific request format.

Did you not understand my examples? How do you propose to handle provider-specific POST formats without risking collision with formats that we standardize at a later point?

With application/x-www-form-urlencoded we would retain the existing protocol completely, with just your web framework delivering parameters in a POST dictionary instead of a GET dictionary, so I think it makes the most sense to use as the primary supported format.

I would be in favour of application/x-www-form-urlencoded for exactly the same reason.

I don't see the need to do that. We can reuse already existing carrier formats, and I can't think of any feature in OPTIMADE that would push us to invent OPTIMADE-specific request format.

Did you not understand my examples? How do you propose to handle provider-specific POST formats without risking collision with formats that we standardize at a later point?

As said, I can't think of any reason of inventing application/vnd.optimade POST format. But maybe I'm just shortsighted.

@merkys

As said, I can't think of any reason of inventing application/vnd.optimade POST format. But maybe I'm just shortsighted.

Let me try to spell out my example as clearly as possible.
First, look at the similar situation with the response_format parameter. We agreed that if anyone invents their own response format, they should prefix it with their database prefix. The reason is that: Let's say I invent my own HDF5 format and make it available as response_format=hdf5. What if OPTIMADE later standardizes an official HDF5 format that is subtly different? Then users of my database will be confused over what they get with response_format=hdf5. So, I am instead supposed to call my own version of the format response_format=_exmpl_hdf5 so we avoid this possible future collision.
Now, onto the case with submission formats.
@fekad above suggests he wants to do POST with JSON-encoded data. Let's say he implements his own JSON representation of the OPTIMADE submission data and applies it to POSTs done as application/json. What if OPTIMADE later standardizes on a subtly differently organized JSON format for the submissions of type application/json? Now users will be similarly confused over which variant of these JSON formats they are supposed to POST to @fekad's database. So, we want him to name his own JSON POST format differently, e.g., "_exmpl_json".
However, one is not allowed to just make up media formats, so he really should not use something like application/_exmpl_json. So, how should @fekad represent this database-specific JSON POST format? My suggestion is that if we register application/vnd.optimade, he could do something like application/vnd.optimade-_exmpl_+json (or maybe using some other degree of freedom allowed for custom media formats, e.g., media type parameters)
Does this make it more clear what use an application/vnd.optimade media type could have?


Fixed Contact Form on Mobile

Added some Flexbox columns to control the layout on mobile.

@FantasticMrHurst Please provide screenshots (web page) of what you did comparing before and after changes.


Rpc endpoint returns an unexpected result

There are some cases that https://rpc.ata.network rpc endpoint returns an unexpected result.
Case 1:
Querying the workspaces, proposals, user balance info, the results are different if we query twice sometimes, it seems one of the node doesn't have the entire storages and return an incomplete result.
Case 2:
Querying eth_getBlockByHash and eth_getBlockByNumber json rpc api, the block info response contains a null value of totalDifficulty, which is not described in the api documents. In the documents, totalDifficulty: QUANTITY - integer of the total difficulty of the chain until this block.

linked case2 discussion thread: https://github.com/automata-network/geode/pull/133


initialBinding does not work with namedRoutes

class SplashPage extends StatelessWidget {   @override   Widget build(context) {     return BaseView(       child: FutureBuilder(         future: Get.find<AppController>().loading(),         builder: (_, snapshot) {           if (!snapshot.hasData)             return Center(               child: CircularProgressIndicator(),             );           return Container();         },       ),     );   } } class InitialBinding implements Bindings {   @override   void dependencies() {     Get.put(AppController());   } }

I don't think you need Bindings or FutureBuilder for what you're doing, you could just do that:
on your AppController:
bool hasData = false;
onInit() => loading();
loading()async{
final data = await Api.call();
hasData = true;
update();
}
GetBuilder(
init: AppController(),
builder: (snapshot) {
if (!snapshot.hasData)
return Center(
child: CircularProgressIndicator(),
);
return Container();
},
),

With this way of doing the Controller you have to extend the GetController, correct?

With this way of doing the Controller you have to extend the GetController, correct?

Yes,  extending GetController will cause the event declared in "onInit" to be called when the controller enters memory.


WIP: Open Feign must support multiple interface inheritance

WIP Notice
I am currently working on this feature request across multiple repositories, so this this will be updated multiple times. Once finished, this notice will be removed. As soon as this notice gets removed, there will be a PR for spring-cloud-openfeign.
Problem
The current problem with OpenFeign is that one cannot inherit from multiple interfaces. And while the current contract,, i.e. single inheritance of annotated interfaces, should be supported in a backward compatitble way, I see no reason why one should prevent the user to inherit from multiple interfaces or marker interfaces even, and recursively so.
Describe the solution you'd like
Feign client interfaces should support multi-level, multiple inheritance.
Describe alternatives you've considered
There are no alternatives unless you come up with a better solution to the problem.
Additional context
I am currently working on a PR for the open feign project to incorporate such measures, meaning that the Contract.BaseContract functionality will be extended so that the IMO artificial restriction on inheritance will be removed altogether.
This will require no changes to spring-cloud except for updating the openfeign dependency.

Thanks, @silkentrance. We will need to see what happens with the issue and PR in Feign core first. Please comment here once the PR has been merged there.

@OlgaMaciaszek Thank you for the reply. I was already convinced that due to the ongoing pandemic, all work had been cancelled.

No, @silkentrance we just have a small team maintaining a big number of projects. The OpenFeign team is independent from us, though, so first let's see what happens with the changes you've submitted in that repo.


Why does Renderer#resize not use super to access AbstractRenderer#resize?

I wonder why we are using the following in Renderer#resize:
AbstractRenderer.prototype.resize.call(this, screenWidth, screenHeight);

Why can't we simplify it as:
super.resize(screenWidth, screenHeight);

Is this related to a bug in ES6 or what? Since I come from Java, this looks like an anti-pattern.

I agree, that should be super.resize, while these two things express the same functionality, the super call is more clear and concise.
This was introduced 5 years ago by @englercj here https://github.com/pixijs/pixi.js/commit/5ebc77bd68dd59c8e96e2db04d130cc459793739
I'm guessing it was added before we fully converted to ES6 and that's the ES5 way to do super calls.

Yeah that was way before we converted to ES6 when there was no such thing as super :)

Is not it more interesting from a performance point of view to use call rather than super?
I made test here and it the difference are very huge.
https://jsbench.me/jdjxrdszul/1

Code is always transpiled down to es5, super is never called natively.

@djmisterjon The link you've given says that super is actually faster.

hum interesting what browser you use, i use Vivaldi based on chromium.
i get 1,2 billion ops/s for call and only 17 million for super.

I use Firefox (latest) on Ubuntu 19.04. I have a 3rd generation quad-core i7, so I think its slower than your computer - only 34M ops/s.

@djmisterjon
thanks for this, for me too , it look like fireFox are more slow for this case , but yes super  run more fast than call with mozilla engine !
tested from AMD Ryzen 7 2700X


Hi there

Hey, i just now discovered this project and must say it looks very peomising. I am coming from an indicatif background and must say that kdam seems superior is some aspects. However i have a few questions:

Does kdam support async? Especially tokio (I am working on an asynchronous download function and this was not really possible with indicatif since MultiBar could not work properly in a Multithread enviroment.
Can i color the bars themselves? While the progress design is quite nice i do not like only having black and white.

About Tokio
kdam doesn't provide an async API. Tokio runtimes can use synchronous API. See example.
About Multiple Bars And Multi-threading
kdam takes a different approach from indicatif for printing multiple bars. indicatif uses MultiBar on the other hand kdam uses absolute positioning method. When update method is called kdam acquires a global static lock from lock module, prints the progress bar and releases the lock. There is also one caveat of this approach that on completion cursor is always restored to its original position.
Progress bars could be printed at different positions in the terminal by specifying position. Progress bars on multiple threads also work fine. See example.
Text can be also printed at a specific position using eprint_at! macro. See example.
About Colours
Currently, only animated portion of bar could be coloured. This is because the original tqdm has such a thing when using colour argument. See example.
In the future kdam will support bar templating and colours can be applied to individual components. Meanwhile RichProgress can be an alternative. See example.

Many thanks for the detailed explaination, kdam sound amazing.
I assume the only reason its relatively unpopular is because of indicatifs fame?
I would love to move to kdam with our projects, however i see a little issue arising: You say that your only dependency is "terminal-size". However terminal-size seams to not support *BSD. Does this affect kdam? Have there ben any BSD tests? Many thanks in advance

No tests have been made for BSD. But kdam should work on BSD because teminal-size uses rustix which are bindings to POSIX-ish APIs and rustix eventually supports BSD.


Branch policies not exported

In the source project, I've set a default branch policy, protecting the default branch of each repository.
This policy didn't make it to the imported project.
Also, build validation policies on repository branches are not exported. The corresponding pipelines are, but not the policies that should trigger them.

@wscherphof Branch policies will not be exported.


Add definition for Entities.md

Instead of defining authorities, controlled vocabularies, etc. we decided to define entities more broadly.

Addresses https://github.com/LD4/entity_metadata_management/issues/15

@vitustang @eslao @NancyJean @greeve can you take a look at this definition of entities to make sure I've have covered our previous discussions?

Looks good to me. One possible addition is to add, in parentheses, after "An entity is any resource" (a thing or a concept) to forestall the question of "what is a resource"

I agree with @vitustang. I noticed a grammatical issue that needs attention. There is an errant the in the second sentence of the definition. Or you could remove the phrasing "what are sometimes referred to" this way:

Entities include, but are not limited to, authorities, controlled vocabulary terms, or real world objects (RWOs) in library, archives, and museum domains.

@vitustang and @greeve I've updated the definition based on your feedback. Could one of you review and approve the change if there are no further changes needed?


[RFC] Discrepancies in [evaluation/prediction]_loop

Proposed refactor

There is a subtle difference in the way that methods are created within the evaluation loop and prediction loop as below.

on_run_start in prediction_loop.py
on_run_start in evaluation_loop.py

The hook is not called through function (only in prediction_loop.py).

_on_predict_model_eval in prediction_loop.py
As reference _on_evaluation_model_eval in evaluation_loop.py

The hooks called for testing and validation are different, and the way the variables are set at that time slightly different.

_evaluation_epoch_end in evaluation_loop.py
_on_evaluation_epoch_end in evaluation_loop.py

Motivation

For readability, it may be better to make the prediction loop methods with the same granularity as the evaluation method.

For consistency and readability

For consistency and readability

Pitch

As below.

Before
def on_run_start(self) -> None:  # type: ignore[override]
    """Calls ``_on_predict_start`` hook."""
    self._on_predict_start()

After
def on_run_start(self) -> None:  # type: ignore[override]
    """Calls the ``_on_predict_model_eval``, ``_on_predict_start`` and ``_on_predict_epoch_start``
    hooks."""
    self._on_predict_model_eval()
    self.trainer.lightning_module.zero_grad()
    self._on_predict_start()
    self._on_predict_epoch_start()

As below.

Before
def _on_predict_model_eval(self) -> None:
    """Calls ``on_predict_model_eval`` hook."""
    model_ref = self.trainer.lightning_module
    model_ref.on_predict_model_eval()

After
def _on_predict_model_eval(self) -> None:
    """Calls ``on_predict_model_eval`` hook."""
    model_ref._call_lightning_module_hook("on_predict_model_eval")

As below.

Before
if self.trainer.testing:
    self.trainer._call_callback_hooks("on_test_epoch_start", *args, **kwargs)
    self.trainer._call_lightning_module_hook("on_test_epoch_start", *args, **kwargs)
else:
    self.trainer._call_callback_hooks("on_validation_epoch_start", *args, **kwargs)
    self.trainer._call_lightning_module_hook("on_validation_epoch_start", *args, **kwargs)

After
stage = "test" if self.trainer.testing or "validation"
self.trainer._call_callback_hooks(f"on_{stage}_epoch_start", *args, **kwargs)
self.trainer._call_lightning_module_hook(f"on_{stage}_epoch_start", *args, **kwargs)

Additional context
The impact is very limited.
If this refactor makes sense, I will work on this.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

Hi @ti-ginkgo! Thanks for the critical eye.
You can go ahead and open 3 separate PRs for these 3 separate things!


Don't overwrite flannel config if it exists

This change made it convenient for me to tweak the automatically generated flannel config file for testing purposes. Overwriting the file on every startup does not seem necessary, if this breaks something else, I have not run into it.
re: #538

Thanks for submitting this PR! I think we need to overwrite the flannel config by default tho, since it depends on parameters used to start k3s which may change. This functionality should probably be provided as a flag (maybe flannel-conf), where if the flag is defined we would use that file instead of creating our own flannel conf.

It may make more sense as a flag, but when I looked into it, the flannel config that gets written out just comes from a string constant. So there does not seem to be any logic that requires it to be changed dynamically. I will look into making it a flag though, since that preserves the existing behavior.

The file is templated, the line strings.Replace(netJSON, "%CIDR%", config.AgentConfig.ClusterCIDR.String(), -1) is replacing the %CIDR% part of the config file with a value that can be passed through flags.


Seeking advice for introducing support for additionalProperties.

@tlivings thanks again for enjoi!
On a project right now and we have a need for additionalProperties.  What would be your preferred way to see this implemented?

cc @byarger

@tlivings I took the liberty of proposing an approach in #15.  Let me know what you'd like me to change.

Fixed in v2.2.2 using your branch fixes @jsdevel !


Error type refactoring

Some small changes with OpResult that result in slightly less ceremony around error handling in the ops module.
In part, this was an exercise in type manipulation in Rust, but I think the results are pleasing in a small way.

Thanks for this, when looking at the ExitError code as it stands now, I noticed that we are leaking the internals to the users.
So instead of exposing the error code, I opted for making the struct entirely private and only going through constructor methods, in https://github.com/target/lorri/pull/199.
I think I included most of your changes here, except for the err helper function. I credited you in the first commit message.


Become comrades with fellow library maintainers

https://github.com/leolin310148/ShortcutBadger
Projects seem very similar. On the off-chance you weren't aware of each other, just wanted to point it out :)
cc: @arturogutierrez @ffgiraldez @leolin310148 @MajeurAndroid @evgeniysharafan

I didn't know! Thanks for pointing it out, and yes, the projects are very similar, even seems forks!

should be great to add all those launcher badges


Add conditions evaluation operation.

Previously condition evaluation would happen on Operation level.
However due to bug discovered in NSOperation we cannot safely manipulate NSOperation.isReady.
Therefore we have to wrap condition evalutor into operation and make it dependency for main operation.
Evaluation errors are then passed back to main operation before its execution.
Relevant discussions:

danthorpe/Operations#175
Kabal#51

So I found that the problem was in NSOperation.isReady. My guess is NSOperation has some inconsistency in its logic and it does not always consult subclass regarding operation readiness. Operation does not start after shifting into Ready state as a result.
This PR only manipulates isExecuting and isFinished states. isReady is entirely managed by NSOperation via dependencies mechanism which works fine.
That's why conditions evaluator is wrapped in operation. Conditions Evaluation operation now waits for all dependencies from conditions to finish before running evaluator. Operation has dependency set for evaluator's operation.
operation -> evaluator -> dependencies from conditions
OPOperation.internalErrors is filled up with errors just before evaluation operation finishes execution.
This allows OPOperation to start naturally like before and gracefully handle errors coming from conditions. willEnqueue is not used anymore and is a no-op.
This change should have no impact on apps using Operative. However, it's BIG. I wrote two stress tests to make sure that there is no crash or stale operation. I manually checked if conditions work properly, location condition from Example app works just fine, evaluation happens after permission alert, just like before.
I would appreciate a lot of testing before we merge.

Don't rush to merge, I am still adding tests and checking mutual exclusivity as it seems that conditions have to be mutually exclusive too in order to run in sequence for mutually exclusive operations.

@pronebird Wow. Lots of changes. I'm concerned about the idea of completely deviating from the state logic of Advanced NSOperations, although it has been mentioned in discussions elsewhere that Operative is not intended to necessarily directly reflect Apples implementation. @Kabal thoughts?
FWIW, I pulled https://github.com/inspace-io/INSOperationsKit and built up a test case identical to what you are testing (dependency chain + mutual exclusivity). I can fire off and complete a test with 500 - 5000 operations (50,000 took forever to getting the ball rolling so I stopped it, seemed excessive although there was nothing leading me to believe that it wouldn't successfully complete). The logic around state and readiness within INSOperationsKit seems to be pretty much identical to Advanced NSOperations...
I do think it is clear as you stated here https://github.com/Kabal/Operative/pull/43#issuecomment-209141873 that we should be pulling the KVO -will... -did... calls out of the sync lock.

@colinmcardell
I've been trying to fix that for entire week to make sure I commit as less changes as possible without any success. This is the last resort for me.
I made a stripped down version of OPOperation with test case that reproduces the same problem we have in Operative and Operations:
https://github.com/pronebird/NSOperationReproducingRaceCondition.
Also, I was able to reproduce the same problem in Earthquakes app:
https://gist.github.com/pronebird/6ccf4e67030f5fdffe65c941c736181c
I don't think the problem is on our side, I think something is fundamentally broken inside of NSOperation that prevents us from overriding isReady.
Please do not merge this PR yet, I have to solve mutual exclusivity issue. Apparently evaluator operation should be mutually exclusive too when using mutual exclusivity on operations... WIP.
But good to speak about this change sooner than later.

It's not elegant, but I need it working. I hope that you two can help to polish it, rethink or merge. Last part was to make sure that condition evaluation operation does not run before previous mutually exclusive op. I've implemented this by adding dependency between previous op and evaluator. This is a small bit of change in ExclusivityController.


Animation issue with entering new Session URL while another session is opened

When entering a new session URL in the address bar, if there already was a session loaded, the new session would not animate properly, throwing an animation error. The User Gate pops up and toolbar layout is messed up. Basically User cannot enter a new session URL while another session is already loaded in the same tab.

fixed


Remove the ec2-net-utils package

Description of changes:
I've encountered an issue when using Packer with the following AMI filter: amzn2-ami-hvm-*
The above filter allows users to use the "full" Amazon Linux 2 AMI (not the minimal AMI, or EKS optimized AMI).
The problem is that the full AM2 AMI contains the ec2-net-utils package. This package contains scripts to automatically create route table entries, which interferes with Pod networking. In my tests, the ec2-net-utils package would create route entries in the "Local" Route Table to direct Pod traffic to an incorrect interface. We want the CNI to take care of setting up the route entries, and this package conflicts with that.
The default AMI filter "amzn2-ami-minimal-hvm-*" and also the EKS optimized AMIs don't contain the ec2-net-utils package, so it's clearly not required for the Worker Nodes to function correctly.
This Pull Request will check to see if the ec2-net-utils package is installed, and if yes, it removes it. I've tested that Packer completes the build successfully with the change included. I've launched some Worker Nodes to verify that the package is successfully removed by checking /var/log/yum.log, and also by running yum list installed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I've added a 1 line code commit now.
If you'd like me to be more descriptive, let me know and I'll be happy to do so. If you want, I can include the full paragraph explanation above if you think that level of detail would be important in the commit. Otherwise, for now, I've just added the 1 line explanation.

@Kausheel thanks for adding this :) This package wasted a lot of time while debugging issue with our image few months ago. It never came to my mind that we can check if it's installed and then remove it like this.

I've added a 1 line code commit now.
If you'd like me to be more descriptive, let me know and I'll be happy to do so. If you want, I can include the full paragraph explanation above if you think that level of detail would be important in the commit. Otherwise, for now, I've just added the 1 line explanation.

@Kausheel We are currently debating over an effort to bring back the ec2-net-utils into the ami. Could you recollect the issues that you observed back then? We would like to make sure we are covering those issues in the tests.


Adding writeups for GPIO, I2C, SPI.

Hi @jordanrh1, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jordan Rhee). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Project Id naming update

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

LGTM


Plugin detection not working

When Qt5 Gui module is used is mandatory to deploy the platform plugins usually contained in:
/plugins/platforms
those should be deployed in /usr/plugins/platforms/

@azubieta please show me a log first. Of course those plugins are deployed when the gui module is detected.

See https://github.com/TheAssassin/linuxdeploy-plugin-qt/blob/master/src/main.cpp#L142.

Logs here https://pastebin.com/etyfUqKb
This only happens in my local system, not in travis-ci.
https://travis-ci.org/azubieta/appimage-metadata-extractor/builds/395880498#L3541

As you can see, the list of found plugins is empty. Therefore, I changed the title, as this is not a problem with the gui plugin's deployment code, but with the plugin detection.
I've added some really verbose debug logging to the relevant code. Please re-run linuxdeploy with DEBUG=1 in your environment, and provide the log.


WARNING: The following directories listed in your path were found to be non-existent

(diffusers) zerocool@DESKTOP-IFR8E96:~/github/diffusers/examples/dreambooth$ ./my_training_press.sh
The following values were not passed to `accelerate launch` and had defaults used instead:
        `--num_cpu_threads_per_process` was set to `12` to improve out-of-box performance
To avoid this warning pass in values for each of the problematic parameters or run `accelerate config`.
WARNING:root:Blocksparse is not available: the current GPU does not expose Tensor cores

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
For effortless bug reporting copy-paste your error into this form: https://docs.google.com/forms/d/e/1FAIpQLScPB8emS3Thkp66nvqwmjTEgxp8Y9ufuWTzFyr9kJ5AoI47dQ/viewform?usp=sf_link
================================================================================
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/paths.py:86: UserWarning: /home/zerocool/anaconda3/envs/diffusers did not contain libcudart.so as expected! Searching further paths...
  warn(
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/paths.py:98: UserWarning: /usr/lib/wsl/lib: did not contain libcudart.so as expected! Searching further paths...
  warn(
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/paths.py:20: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('CompVis/stable-diffusion-v1-4')}
  warn(
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 6.1
CUDA SETUP: Detected CUDA version 117
CUDA SETUP: Loading binary /home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/libbitsandbytes_cuda117_nocublaslt.so...
Caching latents:  18%|██████████▋                                                  | 1771/10110 [06:46<31:51,  4.36it/s]

Can i ignore these warnings?

Yes, you can ignore these. In the newest version, these warnings are only displayed if the CUIDA setup runs on an error.

Yes, you can ignore these. In the newest version, these warnings are only displayed if the CUIDA setup runs on an error.

Ok, thx!


Contributing

There are two main changes:

Adds a Contributing section to the docs (closes #158 )
Updates Examples in docs using Sphinx gallery (closes #284)
Rework TimeSamples class to facilitate the use of an array of time signals (without HDF5 file). Until now, one would have had to set all attributes (data, numchannels, numsamples and sample_freq). Now, only data and sample_freq is required to inject custom array data.

And several small changes and enhancements

Adds doctest with PyTest to test small code snippets in docstrings (included in CI)
fixes a bug with integrate function when PowerSpectra.ind_high=-1
restructure, clean up and speed up all example scripts
updates the TimeSamples docsting
include all examples in an example gallery
clean-up gitignore

The examples are executed at every documentation build. With the current changes, this takes less then a minute:
computation time summary:
    - ../../examples/wind_tunnel_examples/example_airfoil_in_open_jet_time_domain_methods.py:       17.80 sec   0.0 MB
    - ../../examples/moving_sources_examples/example_rotating_point_source.py:                      17.08 sec   0.0 MB
    - ../../examples/introductory_examples/example_3D_beamforming.py:                                6.93 sec   0.0 MB
    - ../../examples/wind_tunnel_examples/example_airfoil_in_open_jet_freq_domain_methods.py:        6.46 sec   0.0 MB
    - ../../examples/wind_tunnel_examples/example_airfoil_in_open_jet_cmf.py:                        3.76 sec   0.0 MB
    - ../../examples/wind_tunnel_examples/example_airfoil_in_open_jet_steering_vectors.py:           2.52 sec   0.0 MB
    - ../../examples/io_and_signal_processing_examples/example_sample_splitter_bufferhandling.py:    1.31 sec   0.0 MB
    - ../../examples/io_and_signal_processing_examples/example_filter.py:                            1.25 sec   0.0 MB
    - ../../examples/wind_tunnel_examples/example_sectors_and_integration.py:                        0.73 sec   0.0 MB
    - ../../examples/introductory_examples/example_basic_beamforming.py:                             0.60 sec   0.0 MB
    - ../../examples/tools/example_evaluate.py:                                                      0.54 sec   0.0 MB
    - ../../examples/introductory_examples/example_three_sources.py:                                 0.46 sec   0.0 MB
    - ../../examples/io_and_signal_processing_examples/example_sample_splitter_multithreading.py:    0.29 sec   0.0 MB
    - ../../examples/tools/example_tools.py:                                                         0.23 sec   0.0 MB
    - ../../examples/io_and_signal_processing_examples/example_power_spectra_import.py:              0.14 sec   0.0 MB

Example Gallery now looks like this:

The extended information for how to contribute should also be linked in contributing.md


Fix memory leak in CanvasImageRenderer

...when rendering a VectorLayer with renderMode: 'image'.
Added tests to CanvasImageLayerRenderer for this issue.
Fixes #7954

[x] This pull request addresses an issue that has been marked with the 'Pull request accepted' label & I have added the link to that issue.
[x] It contains one or more small, incremental, logically separate commits, with no merge commits.
[x] I have used clear commit messages.
[x] Existing tests pass for me locally & I have added or updated tests for new or changed functionality.

Thanks for the fixes @erinc-petrode.


New package: REopt v0.12.3

Registering package: REopt
Repository: https://github.com/NREL/REopt.jl
Created by: @NLaws
Version: v0.12.3
Commit: c66ec77784cd2cc12aa856c8823ed9294a5e7547
Reviewed by: @NLaws
Reference: https://github.com/NREL/REopt.jl/commit/c66ec77784cd2cc12aa856c8823ed9294a5e7547#commitcomment-64746636

Auto merge failed because:
Package name similar to 2 existing packages.\n  1. Similar to NLopt. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Normalized visual distance 2.37 is at or below cutoff of 2.50.\n  2. Similar to Ipopt. Damerau-Levenshtein distance 2 is at or below cutoff of 2."
I don't see why we can't have a new package called REopt? (Plus this name has been registered for many years as part of a patent).

I would like this PR manually merged because the only auto-failing component is two similar names.

Thanks @giordano!


BasicMapTool properties does not exist

I'm using VS 2015 Professional with ArcGIS Pro SDK 2; building the BasicMapTool project returns errors for OverlayControlCanResize and OverlayControlPositionRatio, says the name does not exist in the current context.  These are not properties of the OverlayControl....
    public BasicMapTool() : base() {
        this.OverlayControlID = "BasicMapTool_BasicEmbeddableControl";

        //Embeddable control can be resized
       OverlayControlCanResize = true;
       // //Specify ratio of 0 to 1 to place the control
       OverlayControlPositionRatio = new System.Windows.Point(0, 0); //top left
    }

greetings @rdan461 👋
i'm pretty much the only one keeping an eye on this repo right now, and i haven't written any C# in many years.
because of this, my best suggestion is for you to ask your question on Geonet in the ArcGIS Pro SDK community or perhaps https://github.com/Esri/arcgis-pro-sdk.

Thanks for the info.
Rich Daniels
GIS Product Support Coordinator & CAFM/IRIS Support
ITD, WSDOT
(360) 705-7654
From: john gravois<EMAIL_ADDRESS>Sent: Tuesday, May 08, 2018 4:11 PM
To: Esri/contributing<EMAIL_ADDRESS>Cc: Daniels, Richard<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Esri/contributing] BasicMapTool properties does not exist (#22)
greetings @rdan461https://github.com/rdan461 👋
i'm pretty much the only one keeping an eye on this repo right now, and i haven't written any C# in many years.
because of this, my best suggestion is for you to ask your question on Geonet in the ArcGIS Pro SDKhttps://community.esri.com/groups/arcgis-pro-sdk community or perhaps https://github.com/Esri/arcgis-pro-sdk.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Esri/contributing/issues/22#issuecomment-387570806, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVnedWYxXFt_FTvtHuFht4-4TpMM9lLaks5twiYVgaJpZM4T3chK.


Feature/weather

Thanks @chuwy - have left some comments to go through

Closing this now we have a draft branch (releases/r64).


Updated Twitter Logo

Updated twitter logo to x.com logo

I have updated previous Twiiter svg file to new x.com svg files.

This is my first contribution to open source world.
Thank you !
Happy coding !

LGTM.
It seems like the twitter.png file is not used anywhere in this project and that's why I think that you also delete it.

I have deleted the unused twiiter.png and make a new pull request


Rename package

I think it might be good to rename this package to typescript-fsa or fsa-typescript or something along those lines. This library can technically be used with any FSA compliant flux implementation, or even something else. For example I am currently using it in a cycle.js project.
On top of this, the redux dependency probably isn't necessary. We could reimplement the ReduxAction type in this library and be fairly certain that the API won't change as FSA is a pretty concrete interface at this point in time.
Also if you haven't seen it, should take a look at https://github.com/UrbanDoor/typed-fsa. Seems there are similar goals for both of these projects. Though I prefer this library's isType check over that other library's isAction check for narrowing, as there is no need to declare the payload again.
Thanks for all the hard work!

Thanks for your input and thanks for sharing typed-fsa, I haven't seen it before.
You are right in that Redux dependency is not really needed, though I've planned to include some utilities for building reducers which might depend on Redux. There's already a module with helpers for redux-saga. However, this module is not imported from index.ts and redux-saga is listed as optional dependency.
In general I like the idea of decoupling from Redux, but that means that we'd have to publish helpers as separate packages, like typescript-fsa-redux-saga. Still, I guess this should be done anyway.

Admittedly I wasn't thinking about the saga aspect when I was first opened this issue 😄. Though it doesn't change my gut instinct.
At the very least I think it would be good to remove the redux dependency and reimplement the base Action interface. We could discuss possible options for helpers.

Just released<EMAIL_ADDRESS>

Very cool, will try it out this weekend.

I migrated to new package and my app seems to be working well. I think we can close this one out. Nice work!


Update Questions for Image license lecture

For the first question, here is the hint you are presented with if you get the answer wrong

That doesn't seem helpful at all for beginners.
Here is a better hint that directs users to rewatch the part of the video where the answer is discussed.
### --feedback--

Review the video starting at the 12 second mark where the answer was discussed,

Make sure to update the feedback in all places.
Also, for the last question, the answer is currently set to all of the above.
But the video never mentioned anything about search engine filters or creating your own images.
So that last question needs to be updated so it better aligns with the video
## --text--

How can you find images that you are allowed to use?

## --answers--

Search for images on Google and use them freely.

### --feedback--

Review the end of the video where this was discussed.

---

Use websites like Pixabay or Unsplash.

---

Use any image from social media as long as you give credit.

### --feedback--

Review the end of the video where this was discussed.

---

You can use any image as long as it's not watermarked.

### --feedback--

Review the end of the video where this was discussed.

## --video-solution--

2

Here is the file you need to update
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/25-front-end-development/lecture-working-with-media/6716823876aa22a68ba3e2ec.md

This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
Happy coding


Change espresso core to an api dependency.

Else this leads to unresovled references in the IDE as Espresso is part of the public api, for example in:
fun click(location: GeneralLocation = GeneralLocation.VISIBLE_CENTER)

in BaseActions

Hey @PaulWoitaschek thanks for your idea. However if you required this functionality I would recommend to add espresso core dependency in to your project then expose it from library.


Should/could the fog be moving slightly on the start screen?

It moves exactly the same way as on the game screen

Ok, I couldn't perceive any movement but whatever, closing then.


fix: resolve imports in registry content

I'm not sure what will be broken, but all tests are passed.
Fixes #76

@weizhenye It looks good. Thanks for your contribution :tada:. It will be released as a canary version first.
Please write if everything works correctly so that we will release it as a full version.

@MartynasZilinskas I have written a rollup plugin using scss-bundle and it works fine in my private project.


feat: no longer needs to restart

Implemented the reload config feature, now there is no need to reload whole UI after change configs.

Was it the Gradio version bump that allowed this to work now? I vaguely remember trying to do something similar to this on the older Gradio version.

Was it the Gradio version bump that allowed this to work now? I vaguely remember trying to do something similar to this on the older Gradio version.

Don't quite know this, but at this version of A1111, it seems work fine

import typing isn't needed in Python 3.10.6, the required version for A1111.

I intended to mark None-able param as typing.Optional, but anyway it works fine now

I've been doing some more testing and I sometimes get this JSON read error when creating a new preset. Can't figure out what's causing it, what do you think?
Traceback (most recent call last):
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\gradio\routes.py", line 399, in run_predict
    output = await app.get_blocks().process_api(
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\gradio\blocks.py", line 1299, in process_api
    result = await self.call_function(
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\gradio\blocks.py", line 1022, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "C:\Stuff\AI\Stable Diffusion\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "C:\Stuff\AI\Stable Diffusion\extensions\Config-Presets\scripts\config_presets.py", line 632, in <lambda>
    fn=lambda: self.reload_config_presets_dropdown(config_preset_dropdown),
  File "C:\Stuff\AI\Stable Diffusion\extensions\Config-Presets\scripts\config_presets.py", line 701, in reload_config_presets_dropdown
    self.txt2img_config_presets = load_txt2img_config_file()
  File "C:\Stuff\AI\Stable Diffusion\extensions\Config-Presets\scripts\config_presets.py", line 156, in load_txt2img_config_file
    txt2img_config_presets = json.load(file)
  File "C:\Users\Zyin\AppData\Local\Programs\Python\Python310\lib\json\__init__.py", line 293, in load
    return loads(fp.read(),
  File "C:\Users\Zyin\AppData\Local\Programs\Python\Python310\lib\json\__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "C:\Users\Zyin\AppData\Local\Programs\Python\Python310\lib\json\decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\Zyin\AppData\Local\Programs\Python\Python310\lib\json\decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

It seems that the json file it loads doesn't exist, maybe should dig in to clarify the new preset creating procedure
Could you find a minimal steps to reproduce this error?

I couldn't consistently reproduce the error. Seems to just happen sometimes.

I'm going to focus on PR #41 since it's a much more elegant solution to this problem and seems to work 100% of the time.

Closing this PR since I merged the other one into main.


Issue 284

This fixes #284.

Its on top of function widget branch. Will create another branch shortly on master to merge trigger widget separately.


Keep the player valid after playing completion

@brentvatne @isair
If we keep the player valid (mMediaPlayerValid == true), we can seek to start position and replay the video after playing completion.

@isair - not sure what the best thing to do here is, your call!

Been swamped for a while now, I'm going to have to take a detailed look later at these Android related PRs to ensure nothing is getting broken. Can't verify these changes with one look as I'm not an Android developer at all; just read some documentations here and there to put our implementation together.
The proposed change here may cause a problem with the progress updating code here. If that's the case removing if (mMediaPlayerValid) from seekTo might be a better idea to enable seeking after completion.

Thanks for your review, @isair


Teensy 4 timeslice 5 ms

With scope I noticed that Teensy 3* threads have 10 ms timeslice, but Teensy 4 has 5 ms timeslice?
I think the problem is that GPT ISR will fire twice unless you have
asm volatile ("dsb");
at the end of the isr.
static void __attribute((naked, noinline)) gpt1_isr() {
GPT1_SR |= GPT_SR_OF1;  // clear set bit
__asm volatile("dsb");
__asm volatile("b context_switch");
}

Thanks for catching that. It's a subtle bug. I have commited your suggested fix.


[AWS] PostGres to AWS database migrate

Investigate AWS RDS to host database + Beanstalk to host webapp vs. running it all under one EC2 instance.
Deliverables:

Short writeup in docs/ that overviews set up of both methods. Bullet points are sufficient, commands are necessary.
Branch with working webapp referencing the RDS database

Descoped for now


HAProxy ssl goaccess

Hello,
I want to ask about using goaccess and haproxy with ssl. I am using Apache and HAProxy on one host.
I have HAProxy with ssl termination and Apache on one machine and I want to show server stats via https. HAProxy has combined format of certificate (key and crt files in one file). Is it possible to implement? I compiled goaccess with openssl.
Thanks

Hello, it does sound doable. Have you tried pointing goaccess to your haproxy access log? Please take a look at the man page  for some basic examples.


sending non-string objects through the yaml file

Hi, i would like to send in complex non-string payload in my post request. Specifically, I want to create a list of lists in my chat_history and send that through my post request. Here is what that looks like
name: 'my Tests'
prompts:
  - 'file://../model/prompts/*.txt'
providers:
  - id: 'http://localhost:5000/api/query_no_stream'
    config:
      method: 'POST'
      headers:
        'Content-Type': 'application/json'
      body:
        question: "{{question}}"
        chat_history:
        conversation_id: empty
        scenario: my_scenario
      responseParser: 'json.answer'
tests:
  - vars:
      question: What's the eather like?
      chat_history:
        - - 'hi'
          - 'hello'
        - - 'how are you'
          - 'I am good'
      reference: No ref

However, when i do this, the server receives the chat_history as {'[object Object]': None} instead of the nested lists. I know you use nunjucks as the templating engine. I tried using {{chat_history | dump}} but that tends to send the whole thing as a string instead of nested lists.
What's the easiest way to accomplish what I'm trying to achieve?

@rishimalhotra2 take a look at https://www.promptfoo.dev/docs/configuration/chat/ and let us know if it doesn't solve your issue.

#1274 introduces a fix for this behavior, making it possible to nest objects in the request.


deserializing from R into a struct

Discovered this yesterday. Wrote an impl method like so:
For a lot of simple structs, we can deserialize from an R list object directly into that struct. This is very handy if we want to be able to accept R objects like lists instead of having to create external pointers to structs
use extendr_api::prelude::*;
use extendr_api::deserializer::from_robj;

use ast_grep_config::SerializableRule;
pub fn new_rule(pattern: Robj) -> SerializableRule {
    let r: SerializableRule = from_robj(&pattern).unwrap();
    r
}

I've also made another discovery: https://extendr.github.io/extendr/extendr_macros/derive.IntoRobj.html
I believe it does the same thing, where each field is extracted using dollar and a conversion is performed.
This should be renamed to IntoList or IntoRList.


Updating to new toolset compiler.

Version 2.6.0-rdonly-ref-62106-01
Now includes:

support for stackallocated spans and
escape analysis to make sure spans that refer to local data do not outlive the referenced data.

The corresponding VSIX is at
https://dotnet.myget.org/feed/roslyn/package/vsix/0b48e25b-9903-4d8b-ad39-d4cca196e3c7/<IP_ADDRESS>10601

@VSadov,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@stephentoub @jaredpar - FYI

It's marked as WIP. Does that mean we should wait to merge?

We have found some issues in IDE scenarios (around stackalloc, so maybe not too impactful on you). I will switch this to a newer build once we have fixes.
No need to merge this just yet.
It is awesome that it is passing though :)

Mac build timed out. Is there a way to retest?

test this please

This is what I do
git rebase -i HEAD~1
// reword commit message
git push -f

😆

@benaadams -  ;)  ok.    There is nothing in this change that is mac-specific...

I think this can be merged now

@VSadov why does Microsoft.NETCore.Compilers.2.6.0-rdonly-ref-62106-01 still require 1.1 runtime to run?

@pakrym - Not aure. This is a standard build produced by the the build lab. Dependencies are the same as in other Roslyn branches. Our branch is fairly up-to-date with master - about a week or so.

I don't think it has this commit: https://github.com/dotnet/roslyn/commit/c758f3e891d6610f1f378ac626ab2e2d737587cc
Requiring 1.1 forces us to install runtime just to be able to consume compiler and some infrastructure difficulties.

@VSadov how hard would it be to rebase on master including that commit?

@pakrym - SDK2.0 was merged to master very recently. We will pick it when we merge from master next time. I can do it sometime this week.
I would not mix it with this update though. Two major changes (features + dependencies) at once could be hard to diagnose if something goes wrong.

I see, OK, we'll try to work with this version of package.

I will make it a priority to merge from master.
It will still take some time to merge/build and test whether it is usable for everyday development.


YouTube failed with error 0

Error message: The requested resouce cannot be found! Please make sure your input parameters are correct!
Query string: action=display&bridge=Youtube&s=jessica+world&pa=&duration_min=0&duration_max=300&_cache_timeout=180&format=Atom
Version: git.master.cb488d9
I don't know if this is the same with #875. I get this error sometimes on all bridges that I use.

Thanks for opening this issue!
#875 was recently fixed via #880, please check if your problem was solved by that. It shouldn't, but you can try anyway.
Your error message is returned from one of the core functions of RSS-Bridge, responsible for downloading data from the internet: https://github.com/RSS-Bridge/rss-bridge/blob/b4b5340b7ee22a6d7098c70794532ed8864fad81/lib/contents.php#L50-L54
The error message is returned if the server didn't respond with "200 OK". So, either the server responded with  a different error code, or it didn't respond at all (no connection).

I get this error sometimes on all bridges that I use.

This could indicate connection issues on your server. Can you log the error codes and header data for those situations? These parameters are especially interesting: https://github.com/RSS-Bridge/rss-bridge/blob/b4b5340b7ee22a6d7098c70794532ed8864fad81/lib/contents.php#L35-L36

I've added some additional debug messages to master to track down this issue. Please use that version with debug mode enabled on your server and see if you get log entries that may be of help. See the commit diff for more information.

I'm probably getting this because of unstable connection. The problem is I keep getting feed entries titled "Bridge returned error 0! (17832)". Feed readers have the function to notify the user if the feed is unreachable. These additional entries are redundant and annoying.
Debug log:
2018/10/28 12:45:58 [error] 12122#12122: *2260 FastCGI sent in stderr: "PHP message: /home/user/git/rss-bridge/bridges/TwitterBridge.php:110 class <no-class>->getSimpleHTMLDOM - Reading contents from "https://twitter.com/sicafeed"
PHP message: /home/user/git/rss-bridge/bridges/TwitterBridge.php:110 class <no-class>->getSimpleHTMLDOM - Cant't download https://twitter.com/sicafeed cUrl error: Could not resolve host: twitter.com (6)
PHP message: /home/user/git/rss-bridge/bridges/TwitterBridge.php:110 class <no-class>->getSimpleHTMLDOM - Response header:
PHP message: HttpException: The requested resouce cannot be found!
Please make sure your input parameters are correct! in /home/user/git/rss-bridge/lib/error.php:3
Stack trace:
#0 /home/user/git/rss-bridge/lib/contents.php(70): returnError('The requested r...', 0)
#1 /home/user/git/rss-bridge/lib/contents.php(86): getContents('https://twitter...', '', Array)
#2 /home/user/git/rss-bridge/bridges/TwitterBridge.php(110): getSimpleHTMLDOM('https://twitter...')
#3 /home/user/git/rss-bridge/index.php(256): TwitterBridge->collectData()
#4 {main}" while reading response header from upstream, client: <IP_ADDRESS>, server: rss-bridge.server.lan, request: "GET /?action=display&bridge=Twitter&u=sicafeed&norep=on&noretweet=on&nopic=on&_cache_timeout=180&format=Atom HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm/php-fpm.sock:", host: "rss-bridge.server.lan"

The problem is I keep getting feed entries titled "Bridge returned error 0! (17832)".

This was recently discussed in #814 and added via #841. The idea is to notify users where feed readers don't display (or hide) error messages. Right now this feature cannot be turned off.

Feed readers have the function to notify the user if the feed is unreachable. These additional entries are redundant and annoying.

Some do, some don't. I see how this can be irritating in feed readers that do support it. We need an option to disable it.

Fixed by #994.


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/Mirakurun ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Sorry for late. thank you!


FR: hope to add a option: don't automatically add yaml to canvas note

@doit132 , thanks for the feedback. I am not too familiar with canvas notes, but it may be that they are not supposed to be linted in the first place. Could you provide a sample canvas file?

I have set the shortcut key: ctrl+s to linter the file
The configuration of Linter is shown in the following figure

Animation demonstration

environment

Obsidian SandBox Vault
Obsidian v1.3.5
Win11 22H2

That seems a bit tricky since it looks like it is treating the canvas reference as an actual file. I can probably set something up where if the currently active file is a canvas file then the Linter will not run for the current file. However is that what you are looking for @doit132 ?

That seems a bit tricky since it looks like it is treating the canvas reference as an actual file. I can probably set something up where if the currently active file is a canvas file then the Linter will not run for the current file. However is that what you are looking for @doit132 ?

I just hope to not automatically insert yaml, but other functions of Linter should not be affected

So would the following make sense:

an option to disable inserting YAML Attributes when the active file is a canvas file?
This would still allow the inserting of YAML Attributes when editing the markdown file referenced directly

Yes
An option to disable inserting YAML Attributes in canvas file but other functions of Linter should not be affected in canvas file.
All function of linter should be continuely affected in normal markdown file.

Gotcha. I will think about this and see how things work out around adding it. I currently have several things I have slated to work on so if it does get implemented by me, it may take some time. However I am definitely open to PRs in the meantime.

ok thanks

I came across this issue with the same problem, except you shouldn't lint .canvas at all - they're json! But it looks like this was fixed by #865. so the issues is likely good to close?

@lomky , I am not entirely sure on that. The issue is that the active file when you are on a canvas file can be a markdown file if I recall. So if you are actively editing a markdown file from a canvas file, I believe the Linter still runs against that one file's contents (not the canvas')

Ah, I see my misunderstanding.
When I test in my vault, an inset markdown note is indeed not being Linted after being edited, however neither is the canvas file being linted in its place any longer. So the problem is half-fixed!
So the remaining request is something like:

with Linter set to Lint on File Change
with a Canvas Note Foo.canvas that has an included Markdown note Baz.md
when you edit Baz.md directly through Foo.canvas and then click out
Expected: Linter should be run against that markdown file
Actual: Linter does not activate

Yes?

@lomky , right now it is running against the markdown file if my memery serves (at least for ctrl+s). For the changing of the active file, I am not sure.
But this request wants the Linter to not add frontmatter content when linting from a canvas file.


Game crashes when i enter a song that has a cutscene script.

Describe your bug here.
if a song has a cutscene script, it crashes. it only happens on psych 0.7.3.
heres the script:
function onStartCountdown()
    if not allowEnd and not seenCutscene then
        startVideo('cutscene1');
        allowEnd = true;
        return Function_Stop;
    end
    return Function_Continue;
end
video is in mp4 and 1280x720 resolution
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Nope.

nvw i figured it out

can u pls tell me what did you do to solve?

just changed from 0.7.2 to 0.6.3


Reorganize workspaces related to training

This issue proposes to keep command line tools related to training in one workspace and put the description under the workspace (like prepare).
Why
For many light users, the primary concern would be how to get started on tokenization using Vibrato. So, I think the top-level readme should keep an easy description.
The description of 3. Training in Section Basic usage is for advanced users because to understand this, it is necessary to know the configuration of dictionary files in the MeCab format.
Also, maintaining multiple workspaces increases the costs of updating dependencies in Cargo.toml.
Solution
We keep the command line tools train, dictgen, evaluate, and split in one workspace (such as named train) and write the usage in the readme under this workspace.
Benefits

Descriptions related to training are maintained in a single document, allowing for leading only advanced users there.
Fewer workspaces can be maintained, resulting in avoiding redundant update costs of Cargo.toml.

@vbkaisetsu What do you think about this proposal?

Note: My first priority is to keep an easy description in the top-level readme for many light users. Maintaining several command line tools in a single workspace is the second priority. Thus, another solution is to maintain documents for advanced users in a second-level directory (such as named doc).

I agree with moving some commands under train.


Show edge weight reduction in cell label

This PR allows aggregation functions to return for every edge a newly calculated edge weight. If the new weight is different from the old one (the one defined as the edge's label), the new weight is shown and the old one is striked-through.
An example is shown below:

A new parameter _weight is used to indicate which outgoing edge shall get which new edge weight assigned. More details are defined in the documentation for aggregation functions.
If no new weight is defined, the old edge weight is shown. If no edge weight is defined but a new one was returned, the new edge weight is not shown. Thus, an old edge weight must be present in order to show the new weight.
The following template supports the new functionality:
Issue_104_template.zip
Closes #104.

Does this update require to change the templates?

Unfortunately, yes. The aggregation functions must be updated for that.
As I already adapted the aggregation functions for local testing, I will try to update the templates. You @Mq89 can have a look afterwards to review my changes.


Trim keywords of keyword metadata

It's not super-critical that we do this, since parsers are supposed to trim the tokens of these strings, but why send the bytes? :smile:
[@]mairaw seemed to be making these consistent over in dotnet/docs, so I wondered if you'd like to do it globally over here. If not, please close this.

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@scottaddie DAH! ... here I go breaking things again! :grinning:
I may have surfaced a CI bug :beetle:.

An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report.

@guardrex Gauntlet does complain about the spaces, so it's a great change. Thank you for taking the time to do this!

taking the time

var colonSplit = line.Split(":");
var keywordList = colonSplit[1].Split(',').Select(keyword => keyword.Trim()).ToArray();
outputLines.Add("keywords: " + string.Join(",", keywordList));

... no prob ... it took about 2 seconds (well ... 2 sec + 5 minutes). I got mad scripts! :grinning:


MINOR: use monotonic clock for replica fetcher DelayedItem

Switches the replica fetcher to use a monotonic clock to calculate delays.
In doing so an unnecessary time conversion was removed the replica fetcher hot path. This is a small but significant (2.2%) cost when testing clusters with high replica counts when throttling has engaged (see attached profile).

ok to test

Same test failed in both jobs:

kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

Seems unrelated, but will retest just in case.

retest this please

Unrelated flaky test:

org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta]

ok to test

I updated the PR to use Time everywhere that's required. Note that I did not switch the fetcher tests to use MockTime as it appears they are timing dependent and may depend on AbstractFetcherThread's use of await, so I would want to make the change carefully.

retest this please

@ijuma can this be merged?

ok to test

@lbradstreet Compile errors:

12:38:04 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/tools/src/main/java/org/apache/kafka/tools/PushHttpMetricsReporter.java:29: error: SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package
12:38:04 import org.apache.kafka.common.utils.SystemTime;
12:38:04                                     ^
12:38:04 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/tools/src/main/java/org/apache/kafka/trogdor/workload/SustainedConnectionWorker.java:33: error: SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package
12:38:04 import org.apache.kafka.common.utils.SystemTime;
12:38:04                                     ^
12:38:04 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/tools/src/main/java/org/apache/kafka/trogdor/workload/SustainedConnectionWorker.java:63: error: SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package
12:38:04     private static final SystemTime SYSTEM_TIME = new SystemTime();
12:38:04                          ^
12:38:04 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/tools/src/main/java/org/apache/kafka/tools/PushHttpMetricsReporter.java:98: error: SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package
12:38:04         time = new SystemTime();
12:38:04                    ^
12:38:04 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/tools/src/main/java/org/apache/kafka/trogdor/workload/SustainedConnectionWorker.java:63: error: SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package
12:38:04     private static final SystemTime SYSTEM_TIME = new SystemTime();

@ijuma thanks, I probably should have merged in before asking.

@ijuma the updated PR should compile OK. I removed the change to make SystemTime package private as it seems to be used in other tooling now.

ok to test

retest this please

ok to test

retest this please

EmbeddedKafkaCluster created by Stream UT uses MockTime to create KafkaServer(
https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java#L81) so the check of delayed item gets impacted by MockTime.

EmbeddedKafkaCluster created by Stream UT uses MockTime to create KafkaServer(
https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java#L81) so the check of delayed item gets impacted by MockTime.

@chia7712 thanks, nice catch. That does make things trickier.


Fixed "use of a keyword is invalid" problem on Edge browser

Fix for issue #938

Hi @johnwason: Thanks for the pull request.
Before accepting your pull request, we would need the CLA form accepted. You can find more information in CONTRIBUTING.md.
The full CLA is available here.
When you get a chance, please review the CLA and complete the CLA Acceptance Form. If you have any questions, please just let me know.

Unfortunately that agreement is too broad for me to sign.  You can reproduce the problem by loading the bridge.js under edge and the problem will appear on load.

Unfortunately that agreement is too broad for me to sign.

Okay, no problem.


CMake integration

Good evening @aregtech and @biwiki.
I'd like to present  new progress on CMake integration to areg-sdk.
Summery of new features and improvements:

Comments added to few instructions for clarification.

Some configuration settings have modified for better syntactical improvement.

Examples (01 to 09) is now compiled and linked by CMake.

examples  10_locsvc through 17_winchat (plus 00_helloservice) has different structure than others, therefore they need different method other than what had been implemented right now in examples/CMakeLists.txt.

one of such difference is having multiple executables in a single example.

Next PR will include rest of example support.
To compile and test the output, I  used following commands at root of areg-sdk :
$ cmake CMakeLists.txt -Bbuild

$ cd build
$ make -j 4

As our previous discussion, right now all examples output is still included in build directory along with mcrouter.out.
Which after decision  been made on  output directory of executables, we could modify CMake configuration as needed easily.
As always, open to any changes / modification. :)

Absolutely :)

I resolved (answered) requested modifications.
Please let me know if I misunderstood the problem or question.