Lags when opening portable terminal

When opening portable terminal : huge spikes lag, voip is lagging, people are freezing
I'm playing with 5 even 6 friends
The modlist :
018db6d8-a0f9-4305-57bf-3651351e80b4
BepInEx-BepInExPack-5.4.2100
Sligili-HDLethalCompany-1.5.6
monkes_mods-JumpDelayPatch-1.0.1
taffyko-NameplateTweaks-1.0.6
BepInEx-BepInEx_MLLoader-2.1.0
Owen3H-IntroTweaks-1.4.6
AllToasters-SpectateEnemies-2.3.1
FlipMods-LetMeLookDown-1.0.1
2018-LC_API-3.4.5
RugbugRedfern-Skinwalkers-4.0.1
ZTK-ZTKCosmetics-2.0.0
Evaisa-HookGenPatcher-0.0.5
SocomRazorback-RandysSuits-1.1.0
no00ob-LCSoundTool-1.5.1
Clementinise-CustomSounds-2.3.2
FlipMods-FasterItemDropship-1.2.1
EliteMasterEric-Coroner-1.6.0
itsmeowdev-DoorFix-1.0.0
x753-More_Suits-1.4.1
Verity-TooManySuits-1.0.5
Hexnet111-SuitSaver-1.1.4
M1GDevin-M1GDevin_Collection_of_suits-1.0.3
Evaisa-LethalLib-0.14.2
quackandcheese-MirrorDecor-1.3.2
Drakorle-MoreItems-1.0.2
Hexa-Hexas_Cosmetics-0.0.2
PopleZoo-BetterItemScan-3.0.1
BreakfastBash-BreakfastCosmetics-1.1.1
MadR-MadnessPN2cosmetics-1.0.0
Rune580-LethalCompany_InputUtils-0.6.3
Ozone-Runtime_Netcode_Patcher-0.2.5
h410pr0-Halo_Alpha_9_Cosmetic_Pack-1.0.1
willis81808-LethalSettings-1.4.0
AinaVT-LethalConfig-1.3.4
FlipMods-TooManyEmotes-1.9.2
GhostbustingTrio-CustomFunSuits-1.8.3
JordinB-RandomSuits-1.0.1
ViViKo-MoreMaterials-1.3.1
ViViKo-ViViKoCosmetics-1.5.0
cahloe-Odd_Cosmetics-1.0.2
broiiler-inacraft_cosmetics_megapack-1.0.1
NiaNation-AbsasCosmetics-1.2.3
boring-EmoteWhileInMotion-1.0.0
Speed3559-LethalCosmetics-1.0.0
HomelessGinger-MaskedEnemyOverhaul-3.1.2
EliteMasterEric-CleanerLogs-1.0.0
aazza94-NefariousCosmeticPack-1.0.2
Spyci-CozyImprovements-1.2.2
LostAdmiration-ModerationMenu-1.0.0
Fredolx-SignalTranslatorUpgrade-1.0.0
LeKAKiD-SignalTranslatorAligner-1.1.0
ButteryStancakes-AccurateStaminaDisplay-2.0.1
Woecust-Immersive_Visor-0.2.1
BunyaPineTree-ModelReplacementAPI-2.3.7
femboytv-LethalPosters-1.2.0
N34r-Traduction_FR_de_Lethal_Company-1.3.4
Backrooms-Backrooms-0.1.3
Pooble-LCBetterSaves-1.7.3
teamthing-indies_suits-1.6.0
InkCruxStudios-Ender_MoreSuits-1.0.0
Hayrizan-XUnity_AutoTranslator-5.3.0
Solar32-PerformanceEnhancer-1.3.6
AmesBoys-ReverbOnDeath-1.0.1
WalTeam-NoCooldownInverseTeleporter-1.0.0
Beepsterr-AnnounceMoonChange-1.0.1
Spantle-ThrowEverything-0.4.0
Zaggy1024-PathfindingLagFix-1.2.1
Nikki-NikkisCosmeticKingdom-1.5.1
TesTeam-V2Cosmetics-1.1.1
Hardy-LCMaxSoundsFix-1.0.0
SpookyFingas-Spookies_Cosmetics-3.0.0
KRILLCREW-BetterMenuMusic-2.0.0
Mellowdy-HandheldMap-1.5.7
PotatoePet-AdvancedCompany-1.1.1
Zaggy1024-OpenBodyCams-1.2.1
Aavild-NewTerminal-1.4.0
Sligili-More_Emotes-1.3.3
IntegrityChaos-Diversity-1.1.10
IAmBatby-LethalLevelLoader-1.1.6
jockie-LethalExpansionCore-1.3.15
HolographicWings-LethalExpansion-1.3.40
scoopy-Scoopys_Variety_Mod-1.2.0
Justice69-ImmersiveScraps-1.1.9
bigmcnugget-VanillaContentExpansion-0.1.8
RaspberryProgramming-NoDeathDespawn-1.0.0
Taker-CannabisCompany-1.0.3
Sakura-LandminesForAll-1.0.1
thechitoteam-SpectatorCameraConfig-1.0.2
Aelstraz-BetterSpectator-1.1.0
vasanex-ItemQuickSwitch-1.1.0
taffyko-BetterSprayPaint-2.0.2
Swaggies-CustomDeathMessage-1.0.0
Bobbie-LethalRebinding-1.0.0
Supremo-Hit_Haste-1.0.0
Lauriichan-FriendPatches-1.0.1
Flowprojects-AoTGiants-1.1.0
snake_tech-HazardsOutside-1.1.2
mrov-LightsOut-0.0.4
PortableNavi-BetterInverseTeleporter-1.0.2
NutNutty-AlwaysPickup-1.2.0
Mhz-DisableUnityLogs-1.0.0
falcodxb-LessLogs-1.0.1
kz-RemoveMotionSway-1.2.3
an0nymooose-An0n_Patches-1.0.4
Zehs-Hitmarker-1.1.0
QuokkaCrew-MoreMonsters-1.2.1
TanmanG-Forest_Giant_Motionsense-1.0.2
kuba6000-LC_Masked_Fix-0.0.2
ShaosilGaming-GeneralImprovements-1.1.9
Sagemo-audiopackforfriends8-1.0.8
Sagemo-boomboxpackforfriends5-1.0.5
Steven-Custom_Boombox_Music-1.4.0
FlipMods-ObjectVolumeController-1.0.4
FutureSavior-Boombox_Sync_Fix-1.1.2
TV23-BoomBoxNoPower-1.0.0
CTNOriginals-CrossHair-1.1.0

Ask me anything to help resolve this issue :)

I have exactly the same problems.
As soon as one of the players opens the terminal, everyone starts to lag a lot.
BepInEx-BepInExPack-5.4.2100
Sligili-HDLethalCompany-1.5.6
PotatoePet-AdvancedCompany-1.1.10
IntegrityChaos-Diversity-2.0.3
EliteMasterEric-Coroner-1.6.1
gamehog44-LethalRadiation-1.2.2
x753-Mimics-2.4.1
RugbugRedfern-Skinwalkers-4.0.2
ShaosilGaming-GeneralImprovements-1.1.11
Zaggy1024-OpenBodyCams-1.3.0
Zaggy1024-TwoRadarMaps-1.3.4
TwinDimensionalProductions-CoilHeadStare-1.0.9
EliteMasterEric-SlimeTamingFix-1.0.2
Silvercore-Permanent_Ladder-1.0.3
saint_kendrick-Lethal_Doors-1.0.4
NutNutty-SellTracker-1.2.1
KodiCraft-TermSpeak-1.1.0
Justice69-ImmersiveScraps-1.2.0
Suskitech-AlwaysHearActiveWalkies-1.4.4
Monkeytype-HideChat-1.0.0
Nases-Quick_Drop-1.0.1
Hayrizan-XUnity_AutoTranslator-5.3.0
loaforc-loaforcsSoundAPI-0.1.3
Rune580-LethalCompany_InputUtils-0.6.3
IntegrityChaos-GraphicsAPI-1.0.0
IntegrityChaos-LCCutscene-1.0.0
jockie-LethalExpansionCore-1.3.15
Pooble-LCBetterSaves-1.7.3

Maybe this will be fixed in 1.1.15

Thank you !
Hopefully they'll re-added your mod :/

As of v1.1.16, the problem persists.
The more players open the terminal the more hangs, up to complete freezing of the game for a few seconds (with 3-4 players using the terminal).
I have to use the terminal only between missions and strictly in turn.
However, I think it is no longer important...
I am sorry for the drama.


TimberImage letterbox image quality option

Wondering if there's appetite to allow setting of imagejpeg quality parameter via the letterbox and resize filters? I'm getting some gnarly quality loss on certain images. Passing quality 100 to imagejpeg in timberimageoperationletterbox resolves so having this option when needed would be great.
Eg left to right: original, resize, letterbox

+1 I need this too. a lot of resized images from really big DSLR jpegs look blurry after resizing

+1 would like. Seems under the hood, TImber uses WP_Image_Editor. Maybe you could use something like this: https://developer.wordpress.org/reference/classes/wp_image_editor/set_quality/


Fix garbled characters #249

https://github.com/sunfish-shogi/electron-shogi/issues/249
棋譜コメントに ☗ ☖ を使ってしまうと KIF 形式で文字化けするので棋譜コメントではレガシーな表記を使用する。

Codecov Report
Base: 72.40% // Head: 72.43% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (794ad49) compared to base (62d8fd8).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   72.40%   72.43%   +0.02%
==========================================
  Files          60       60
  Lines        3461     3461
  Branches      200      199       -1
==========================================
+ Hits         2506     2507       +1
  Misses        795      795
+ Partials      160      159       -1

Impacted Files
Coverage Δ

src/shogi/record.ts
75.33% <ø> (ø)

src/store/usi.ts
49.33% <0.00%> (ø)

src/shogi/move.ts
83.72% <100.00%> (+2.32%)
:arrow_up:

src/store/record.ts
70.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Convert demo to using new Speech JS SDK

@daniel-bolanos please test and code review.
I'm still considering some significant API changes to the SDK, so I understand if you want to wait until it's more settled before merging, but I mostly wanted to get you to take a look at what I have so far. I should probably also get a code review for the SDK...

Hello Nathan, this looks very good, it makes the code simpler and cleaner. Easier to read.
I would like to test this running against prod, do you have it pushed somewhere?

@daniel-bolanos: https://github.com/watson-developer-cloud/speech-javascript-sdk

I just pushed a copy of this to https://speech-js-sdk-demo.mybluemix.net/ - although mic input seems to be failing me in firefox now (the local copy still works, and they both work in chrome.) I'll do a bit of investigation and report back.
Although I just realized that I still need to connect the opt-out param.

Op, I figured it out. The node_modules/ folder is in .cfignore as I eas expecting, but it doesn't ignore or rebuild the JS during a cf push, and it happened to grab a bundle from a point in time where one of my experiments in the speech-js-sdk had broken things. (I'm trying to send it through a MediaRecorder to get opus audio without having to do the compression in JS.)
Anyways, it's fixed now. We might want to look into rebuilding the browserfy bundle automatically on bluemix though. A simple option might be to put in a scripts.postinstall in package.json to do it.

Hi @nfriedly , I just tested it. It seems to work in chrom for mic capture, but when I try to stop the mic I see:
stopping microphone, sending stop action message recordbutton.js:77
Uncaught TypeError: undefined is not a function
Also there seem to be some missing pics, not a big deal:
ET https://speech-js-sdk-demo.mybluemix.net/images/stop.svg 404 (Not Found) stop.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop-red.svg 404 (Not Found) stop-red.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop.svg 404 (Not Found) stop.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop-red.svg 404 (Not Found) stop-red.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop.svg 404 (Not Found) stop.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop-red.svg 404 (Not Found) stop-red.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop.svg 404 (Not Found) stop.svg:1
GET https://speech-js-sdk-demo.mybluemix.net/images/stop-red.svg 404 (Not Found)

Try it again now that I'm done re-pushing - same behavior?

same issue with the mic, it fails to stop it, but maybe my chrome is too old
Version 37.0.2062.120 Ubuntu 12.04 (281580) (64-bit)
Dani

OK, do you know what line it's coming from? I can just wrap it in a try/catch.
And what about the images - are they still 404'ing for you?

Initializing views... index.js:29
Initializing session permissions handler sessionpermissions.js:21
Not running, handleMicrophone() recordbutton.js:52
starting mic recordbutton.js:63
Stopping microphone, sending stop action message recordbutton.js:77
Uncaught TypeError: undefined is not a function microphone-stream.js:79
-> one two three four five six seven eight nine and  displaymetadata.js:159

cool, got it. stream.getTracks()[0].stop();

BTW, I've continued to update the demo and the SDK - I moved the text formatting code over to the SDK today.  I think I'm basically done with changes to the demo - I might try and add one more module to the SDK to read word timings and slow the results down to ensure they don't arrive before the audio could be heard, but it should be only a 1-2 line change to add it to the demo app. This PR could be merged now, or we can wait for that.
Other than that, I believe the SDK is also essentially done for Speech-to-Text, so I'm going to open a ticket there asking for a code review.
I'd also like to add Text-to-Speech support but I believe that will be simpler, assuming that CORS and tokens both work on TTS.

I added a TimingStream to delay the display of results that are received before the matching audio is played - there's a nice long opus file at https://github.com/watson-developer-cloud/speech-javascript-sdk/raw/master/examples/public/Isac_Newton_spoken_Wikipedia_opus.ogg that you can use to test it.(from https://commons.wikimedia.org/wiki/File:Isaac_Newton.ogg but converted to opus)
The updated code is available at https://speech-js-sdk-demo.mybluemix.net/ right now if you'd like to test it. At this point, I think this is ready to merge.

Hi @nfriedly , I just tested it, something seems off, look at recognition results from the original demo and from your version (this is sample file number 1):
https://speech-js-sdk-demo.mybluemix.net/
My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction bout with the fact is not just technology for technology's sake is technology that's actually making a difference and and change in the world.
https://speech-to-text-demo.mybluemix.net/
My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and changing the world.
both point to the service in stream so results should be identical.

@daniel-bolanos is that something you get everytime you test the app?

@daniel-bolanos good catch, I missed that. I'll dig into it tomorrow and see what I can figure out.

@germanattanasio , decoding results for files should be deterministic, same input / same output. @nfriedly thank you!
Dani

@daniel-bolanos two things of note:

today it's actually giving me the same translation:

https://speech-js-sdk-demo.mybluemix.net/

My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and changing the world.

https://speech-to-text-demo.mybluemix.net/

My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and changing the world.
Are you observing that behavior also? Can you think of any reason why it would have change? I have not made any code changes since we both observed the differing results yesterday.

I realized why it might be different: I actually changed the underlying behavior of the sample buttons. The current demo app makes an XHR request for the data, then sends one copy to an <audio> element as a Blob and sends the other copy to the STT service over the Websocket.

However, in my new version, I just create an <audio> element pointed at the source, let the browser handle the download and playback, and then tap into the <audio> element to extracting a stream just like we do for microphone input.
To explain that a little bit: I added support for <audio> & <video> element sources partially because a different team had requested it and partially because I thought it made a lot of sense for this the JS SDK (and is a relatively small amount of additional code because it can leverage the audio/l16 transformation code we already had in place for mic input). That gives me three main APIs in the JS lib: recognizeMicrophone(), recognizeBlob(), and recognizeElement() - Since they were there and this was a sample app, I thought it would make sense to use all three here.
But I concede that it may have cause an (intermittent?) regression here due to involving the browser's audio processing where it previously wasn't, but I'd still argue that it might be the best plan of attack.
Somewhat related to this, the file I wanted you to review the most in the SDK is https://github.com/watson-developer-cloud/speech-javascript-sdk/blob/master/speech-to-text/webaudio-wav-stream.js - I basically hijacked two sections of you code to output an actual .wav header + convert the WebAudio to l16 - I think I have a halfways decent handle of what's going on, but you did mark the main method as deprecated, so I wanted to know if you had suggestions for what to do there instead.
(It includes the .wav header mostly for the next stream in the chain, https://github.com/watson-developer-cloud/speech-javascript-sdk/blob/master/speech-to-text/recognize-stream.js which then reads the header and automatically sets the content-type, but I was also thinking that the webaudio-wav-stream.js is a good candidate for moving to a standalone library and that it would be more useful with the .wav header.)

@nfriedly , what I'm observing is that your app is not deterministic for file upload (see below), and that is something that can potentially confuse users. User not only expect to see the same hyp coming from the same file when it is run multiple times, they also expect the demo to produce the same results than the service will produce when calling it directly. This is the way I see it. Is it possible to make some change to your implementation so it becomes deterministic?
-- non deterministic behaviour explained -------------------------
I run your version two times (firefox) and get this:
https://speech-js-sdk-demo.mybluemix.net/
My family absolutely fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction but with the fact is not just technology for technology's sake is technology that's actually making a difference and and change in the world.
My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and change in the world
Then I run the original demo 4 times (firefox) and got the same output in all runs:
My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and changing the world.
Then I run it once in Chrome and get the same thing:
My family absolute is fascinated by the work I'm doing with Watson and I I think they feel a personal sense of pride and satisfaction out with the fact is not just technology for technology's sake is technology that's actually making a difference and and changing the world.

Dani

So, the sample buttons are not file upload in the SDK'd demo app, they are closer to microphone input now (in the sense that we get an audio stream from the browser, convert that to l16, and then upload it.)
I didn't realize that the output stream from playing an <audio> element was non-deterministic, though, so maybe it is worth going back to the old style of downloading the file, then playing + uploading it separately. It's a bit more work, and less ideal in the sense of the demo app showing users how to use the SDK, but it's definitely possible.

@nfriedly what about all this work? can we look into this for the new demo?

At this point, this PR isn't worth the effort it would take to salvage it. However, the issue will be resolved as part of https://github.ibm.com/Watson/developer-experience/issues/453


Add roslyn-analyzers to source-build

AspNetCore-Tooling depends on this, as does at least one other project - it's currently being carried as a prebuilt.

Is this needed, or can we condition out the usage of this package?

Fixed with https://github.com/dotnet/source-build/pull/1849


Require method DOES NOT work on Node 10

The method described in the Docs to use this sdk in Node DOES NOT WORK, at least not in Node 10.15 with npm 6.6:
const eventbrite = require('eventbrite');

// Create configured Eventbrite SDK
const sdk = eventbrite({token: 'OATH_TOKEN_HERE'});

This yields a "eventbrite is not a function" error.
Here's the workaround:
const eventbrite = require('eventbrite').default;

Your Environment

SDK version: 1.1.0
Node version: 10.15.0
NPM version: 6.6.0
Operating system: Windows 10

I am having the same issue, please let me know if there are any fixes!

I'm having the same issue and would love to know the progress on this!


Deprecate in favor of docker stacks & binder

Ideally, we should be completely switched over to binder and relying on well curated stacks for docker. Since people can create their own images by making new repos, they can feature their tool or kernel there.

The switch to Binder is complete.


Detekt: no files to check

I get output like this.
Check for case conflicts.................................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Detekt...............................................(no files to check)Skipped
ktlint...............................................(no files to check)Skipped

Apparently, the built-in checks are working, but detekt and ktlint are executing in the wrong directory or for some other reason not finding the files. I'm not using any config.
project structure is standard gradle:
project_root

.pre-commit-config.yaml
src

main

kotlin

Do you know how I can debug this problem? I tried adding
    args: [--config, detekt.yml, --debug]

but debug doesn't seem to do anything, and no error is thrown if detekt.yml is not there, so I can't really tell whether it is being found on a certain path or not.

Oops... apparently I need to actually commit some Kotlin files for it to run...


Weird: Does this not allow overwriting the file over and over again.

The action log says its writing the file, but I didn't the file before running and it says its wrote it, but the file doesn't exist.
https://github.com/austinsonger/automate-aws-evidence-collection/actions/runs/4703116276/jobs/8341214663

Where do you expect the file to exist? In the runner during the workflow run, or in the repository after the workflow run?

# LIST OF SERVER CERTIFICATES
      - uses: GuillaumeFalourd/command-output-file-action@main
        with:
         command_line: aws iam list-server-certificates --output yaml
         output_file_name: lists/list-server-certificates.yaml
         display_file_content: YES #

# LIST OF SERVER CERTIFICATES
      - uses: GuillaumeFalourd/command-output-file-action@main
        with:
         command_line: aws iam list-server-certificates --output yaml
         output_file_name: lists/list-server-certificates.yaml
         display_file_content: YES #

This specific configuration will return an error if the lists folder doesn't exists, as the action won't create new folders.
Adding this step should work:
      - run: mkdir lists
         shell: bash
      - uses: GuillaumeFalourd/command-output-file-action@main
        with:
         command_line: aws iam list-server-certificates --output yaml
         output_file_name: lists/list-server-certificates.yaml
         display_file_content: YES #

I got it to work, but now I tried to write it again. It completed successful, but it didn't update the files in the repo.

https://github.com/austinsonger/automate-aws-evidence-collection/actions/runs/4703711448/jobs/8342525890

I don't know why the step to commit and push files didn't get the files updates, if you're sure the file content has been updated during the workflow execution.
Did you check the files contents before committing to be sure?


Issue with direct sum

Bases are defined as sets
https://github.com/Name-Kompsky/tripos/blob/b25f58f03cd3a9d0a5d906dd6cefb5149f27f26c/IB/linear_algebra.tex#L217
however later in the lemma on direct sums
https://github.com/Name-Kompsky/tripos/blob/b25f58f03cd3a9d0a5d906dd6cefb5149f27f26c/IB/linear_algebra.tex#L365
this statement is incorrect assuming that B_1 and B_2 are sets as their intersection could be non-trivial (I think that a counterexample would be a vector space of the field of 2 elements which I can construct is there is a doubt) which is a problem in the proof of 3 implies 1.
I think this problem is fixed by defining bases as lists (so B_1 and B_2's union has size |B_1| + |B_2|).

Okay, upon discussion elsewhere I think that this result is true, but the proof is still confusing as to the definition of the union of bases

Wait, counterexample: take V the vector space F_2 over itself. Then if U=W=V then U and W have unique bases, and indeed the union of these two bases if a basis of V.
So unless union is defined as 'union including duplicates', this is a contradiction to the 3 implies 2 proof.

Corrected now.


CORE-6118 control build with cron job and no changes to compare against other two

failure rate 1 in 6.5


Clarify modes support for Android Enterprise

Hi, each warning windows have different terms for Android Enterprise modes. Even the https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/microsoft-defender-endpoint-android?view=o365-worldwide mentioned different ones. Capabilities itself have descriptions to be supported only for some modes, but overall seems good. Also, the terms in Intune console are updated with new Google terms. Can you please clarify the current support? Thanks.

Fully Managed, Dedicated, and Corporate-Owned Work Profile
Personally owned Work Profile

As text says "Currently, Personally owned devices with work profile and Corporate-owned fully managed user device enrollments are supported for deployment." and "Antiphishing protection is supported only on Dedicated fully managed user device enrollment."
I know that Google does not make it easier, but you can make this transparent from your side. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60db9275-9265-ebca-a145-3a3eede2353a
Version Independent ID: 9d19ab3c-eb32-4211-14d9-559998589eb3
Content: Deploy Microsoft Defender for Endpoint on Android with Microsoft Intune
Content Source: microsoft-365/security/defender-endpoint/android-intune.md
Product: m365-security
Technology: mde
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@msbemba

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


fix: Use Webpack import to address built-in recording lists reading problem after app is packaged

As it turns out, readFile() does not work on built-in recording lists because they are compressed in an asar file and not on a file system. We still have to use import() to access the built-in lists.
Fixes #82

I also confirmed that the file with Delta English is not oto.ini. You can load Z.CVVC. That one has oto.ini

Merging to update dependabot PRs. Feel free to comment on any issue. If there are things that need fixing, will open another PR.


Fixed assets directory on Makefile

The assets directory it's data instead of store

Coverage remained the same at 88.571% when pulling 099bae19b1654db161b7615367d61bb632dfa526 on pconcepcion:fix_makefile into 8bc39f0476a2847af34d6894682185a2c9871e87 on o1egl:master.


integration tests are leaving clutter

It looks like (at least when the tests fail), there is some clutter:
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	samples/apps/manifest/manifest-integration-1559339268331436000.yml

Closed via #121


AnchorWave on a very repetitive plant genome

Hi,
I have been testing AnchorWave (v1.0.1) on a very repetitive plant genome (Faba bean, 13 Gb), but the run time has been extremely long.
Alignement of a single chromosome (chr1L) has been running for over 3 day now. Do you perhaps have any recommendations?
anchorwave gff2seq -i chr1L.gff3 -r seq2.fa -o cds.fa
minimap2 -x splice -t 10 -k 12 -a -p 0.4 -N 20 seq2.fa cds.fa > ref.sam
minimap2 -x splice -t 10 -k 12 -a -p 0.4 -N 20 seq1.fa cds.fa > alt.sam
genoAli -t 5 -i chr1L.gff3 -as cds.fa -r seq2.fa -a alt.sam -ar ref.sam -s seq1.fa -v alt.vcf -n alt.anchors -o alt.maf -f alt.f.maf > alt.log
cat alt.log
reading reference sam begin
reading reference sam done
using parameters detected from the input SAM file for novel anchors identification

The data can be found here:
https://projects.au.dk/fabagenome/genomics-data

Hi so sorry for the delayed reply,
How was it going, please? I guess it has been finished?

Hi,
I killed the run after it did not finish in a week, as I needed the VM for other purpose. At this point AW unfortunately would not be a viable solution for us; we need to align 9 genomes, 6 chromosomes each and alignment of 2 chromosomes takes over a week. Are the perhaps any plans for a faster implementation?

Yes. I have such a plan for a faster version.
I will have a hackathon for this aim next week.

Hi,
I was just wondering, has there been any progress on this? Our faba bean pangenome project officially started and we will be trying to tackle this. I assume the bottleneck is the alignment step? Would it make any sense to try to use a different aligner as a drop-in replacement in our specific case (minimap2 or wfmash)?

Version V1.1.1  should be significantly faster than V1.0.1. We are testing a new version which is about 1.6 times faster than Version V1.1.1  under the multiple threads model.

Hi,
I updated to v1.1.1, but it still seems to be taking quite a long time. Running close to 24h now for one chromosome.
One thing that surprises me is that memory usage (running on 1Tb machine) and CPU stats are not what I would expect them to be. Could be just a case of how they are reported.
anchorwave gff2seq -i chr1L.gff3 -r seq2.fa -o cds.fa
minimap2 -x splice -t 10 -k 12 -a -p 0.4 -N 20 seq2.fa cds.fa > ref.sam
minimap2 -x splice -t 10 -k 12 -a -p 0.4 -N 20 seq1.fa cds.fa > alt.sam
anchorwave genoAli -t 14 -i chr1L.gff3 -as cds.fa -r seq2.fa -a alt.sam -ar ref.sam -s seq1.fa -v alt.vcf -n alt.anchors -o alt.maf -f alt.f.maf > alt.log
AVX2 is enabled

Would you perhaps be willing to have a look at our data to see what is going on? It could be a case of parameter tuning. The mean distance between our genes in close to 350 kb https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>9015v1.full.

I just wanted to update that the run for the one chromosomes finished after about 1.5 days. I will have a more detailed look at the results and report back.
Agnieszka


[JOBS-11439] Add taskValues support in remoteDbUtils

Changes
Support dbutils.jobs.taskValues methods in RemoteDbUtils and add additional checkTaskValue to allow local testing
Tests

Added three test cases in test_dbutils.py. Integration tests are not needed since changes only for remote mode

[x] make test run locally
[x] make fmt applied
[x] relevant integration tests applied

I'm having trouble really understanding this change. Seems very simple, but maybe I'm confused about the API we are trying to support. Is it not possible to make this work for testing without exposing a new method? I would have thought that you could set a task value and then get it; I think you can do that in DBR but you can't outside, but we can't mock that behavior? Do people ever specify different values for default and debugValue?

I was implementing change according to that doc: https://docs.google.com/document/d/1yrXXA27GJOB968apgnxnMsWfj0SJJn2cpArE4zzIORU/edit#heading=h.a2at0pdkk01r. As I understood the idea for additional method is to check if set(key, value) was called with specified parameters, because get interface is for case when we are inside job run (we need some task key at least) cc @gaborratky-db @mgyucht

Thanks for clarifying, that makes a lot of sense. My main concern is really that there is a divergence in the API between DBUtils in the SDK and DBUtils in DBR. Where possible, I think preventing this divergence ensures that customers don't run into AttributeErrors at runtime in DBR. I do understand why you need to add an additional method now because of the specific semantics of getting task values outside of a job run. If we add this method here, I suggest adding a corresponding method in DBR as well. Do you think that's feasible?

Thanks for clarifying, that makes a lot of sense. My main concern is really that there is a divergence in the API between DBUtils in the SDK and DBUtils in DBR. Where possible, I think preventing this divergence ensures that customers don't run into AttributeErrors at runtime in DBR. I do understand why you need to add an additional method now because of the specific semantics of getting task values outside of a job run. If we add this method here, I suggest adding a corresponding method in DBR as well. Do you think that's feasible?

I think it is not very feasible, because if we want the similar implementation, then we need to check all job tasks for taskValue with specified key.  Also as I understood, use case during local development is that we can write unit tests in which we will run task function and then check that we set correct value in specified key. I don't know about such use cases in DBR. I think if we will write in documentation that it is only for unit test purposes during local development and implement it by assert call, then it should be enough to prevent using in DBR, what do you think? cc @mgyucht @gaborratky-db

Thanks for clarifying, that makes a lot of sense. My main concern is really that there is a divergence in the API between DBUtils in the SDK and DBUtils in DBR. Where possible, I think preventing this divergence ensures that customers don't run into AttributeErrors at runtime in DBR. I do understand why you need to add an additional method now because of the specific semantics of getting task values outside of a job run. If we add this method here, I suggest adding a corresponding method in DBR as well. Do you think that's feasible?

I think it is not very feasible, because if we want the similar implementation, then we need to check all job tasks for taskValue with specified key. Also as I understood, use case during local development is that we can write unit tests in which we will run task function and then check that we set correct value in specified key. I don't know about such use cases in DBR. I think if we will write in documentation that it is only for unit test purposes during local development and implement it by assert call, then it should be enough to prevent using in DBR, what do you think? cc @mgyucht @gaborratky-db

This isn't necessarily true because we know in DBR which taskKey the dbutils.jobs.taskValues call runs for and we can call dbutils.jobs.taskValues.get("<my own task key>", ... ) to retrieve the task value.
If we want to keep parity between DBR and the SDK implementation, one option is to extend the semantics of dbutils.jobs.taskValues.get and make it possible to query the task's own task values when called as part of a job run. For example:
dbutils.jobs.taskValues.get(None, "myKey") would query whether something was set with dbutils.jobs.taskValues.set("myKey", "myValue"). I don't like using None as a special taskKey value here but I don't have a better idea off the top of my head.

I quickly looked at the implementation and we don't actually know the current taskKey, only the current run id, which we can't use to query the values.
I suggest that we simply remove assertTaskValue from the SDK version, keep parity, ship the fix, and come back to this problem when we have additional capacity to improve dbutils.jobs.taskValues.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Files
Coverage Δ

databricks/sdk/dbutils.py
79.20% <100.00%> (+0.85%)
:arrow_up:

... and 11 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.

@mgyucht we addressed the changes and the implementation is simple and straightforward: the code will run in "remote" mode (aka locally) and will be more portable as a result. This should be enough for parity, PTAL.


sources.list entry doesn't work on linux mint

While installing this application i noticed that the repo had no release file, and that the repo entry had linux mint uma as distro.
I skimmed through the source of the installer, when i noticed that it made the repo entry depending on the distro. I might try to fix this soon, but for now ill report it as an issue. It should detect whether an OS is debian, ubuntu, arch, etc- based and then make the entry based on that. IE linux mint is based on ubuntu/debian, so the entry should be for Ubuntu Focal (which is how i fixed it).

More correctly: We do not upload the image to every variant of Ubuntu/Debian, which Mint is.


Not able to instantiate chaincode

Hello everybody,
NOTE: The network works perfectly all the way through my API interacting with a working network in docker-compose. The network seems to work perfectly with no errors up until attempting to instantiate the chaincode.
I've been trying to build a kubernetes cluster with hyperledger and everything works great except I can't seem to instantiate my chaincode. At first it was saying there wasn't a /var/run/docker.sock available so I added a docker container via your example and now I'm getting the following errors
Docker Container
time="2019-05-06T06:12:47.167226478Z" level=warning msg="Your kernel does not support swap limit capabilities,or the cgroup is not mounted. Memory limited without swap."
time="2019-05-06T06:13:01.521766588Z" level=info msg="Attempting next endpoint for pull after error: failed to register layer: ApplyLayer exit status 1 stdout:  stderr: errno 524"
time="2019-05-06T06:13:02.803021651Z" level=info msg="Pull session cancelled"
time="2019-05-06T06:13:03.233898331Z" level=error msg="Not continuing with pull after error: context canceled"
time="2019-05-06T06:13:03.273022662Z" level=warning msg="could not write error response: write tcp <IP_ADDRESS>:2375-><IP_ADDRESS>:52048: write: broken pipe"

Peer Container
2019-05-06 06:08:34.181 UTC [comm.grpc.server] 1 -> INFO 06c unary call completed grpc.service=protos.Endorser grpc.method=ProcessProposal grpc.peer_address=<IP_ADDRESS>:39364 grpc.code=OK grpc.call_duration=14.250358185s
2019-05-06 06:12:47.083 UTC [endorser] callChaincode -> INFO 06d [mainchannel][ad343f9a] Entry chaincode: name:"lscc"
2019-05-06 06:12:47.176 UTC [chaincode.platform.golang] GenerateDockerBuild -> INFO 06e building chaincode with ldflagsOpt: '-ldflags "-linkmode external -extldflags '-static'"'
2019-05-06 06:13:01.524 UTC [chaincode.platform] func1 -> ERRO 06f Failed to generate platform-specific docker build: Failed to pull hyperledger/fabric-ccenv:latest: failed to register layer: ApplyLayer exit status 1 stdout:  stderr: errno 524
2019-05-06 06:13:01.524 UTC [dockercontroller] deployImage -> ERRO 070 Error building image: Post http://dev-docker:2375/build?t=dev-org1-peer0-assets-0-8c640fcda93c23e81c240e2f05a89be99b81bfc3bdcdb03dd0a0f40319242665: Failed to generate platform-specific docker build: Failed to pull hyperledger/fabric-ccenv:latest: failed to register layer: ApplyLayer exit status 1 stdout:  stderr: errno 524
2019-05-06 06:13:01.524 UTC [dockercontroller] deployImage -> ERRO 071 Build Output:
********************

********************
2019-05-06 06:13:01.538 UTC [endorser] callChaincode -> INFO 072 [mainchannel][ad343f9a] Exit chaincode: name:"lscc"  (14455ms)
2019-05-06 06:13:01.538 UTC [endorser] SimulateProposal -> ERRO 073 [mainchannel][ad343f9a] failed to invoke chaincode name:"lscc" , error: Post http://dev-docker:2375/build?t=dev-org1-peer0-assets-0-8c640fcda93c23e81c240e2f05a89be99b81bfc3bdcdb03dd0a0f40319242665: Failed to generate platform-specific docker build: Failed to pull hyperledger/fabric-ccenv:latest: failed to register layer: ApplyLayer exit status 1 stdout:  stderr: errno 524

Command line where I'm running the command
root@dev-cli-org1-peer0-deployment-fcb494b55-5wwrm:/opt/gopath/src/github.com/hyperledger/fabric/peer# peer chaincode instantiate -C mainchannel -n assets -v 0 -c '{"Args":[]}' -o dev-orderer0:7050 --tls --cafile=/etc/hyperledger/orderers/msp/tlscacerts/localhost-7300.pem
2019-05-06 06:12:47.080 UTC [chaincodeCmd] checkChaincodeCmdParams -> INFO 001 Using default escc
2019-05-06 06:12:47.080 UTC [chaincodeCmd] checkChaincodeCmdParams -> INFO 002 Using default vscc
Error: could not assemble transaction, err proposal response was not successful, error code 500, msg error starting container: error starting container: Post http://dev-docker:2375/build?t=dev-org1-peer0-assets-0-8c640fcda93c23e81c240e2f05a89be99b81bfc3bdcdb03dd0a0f40319242665: Failed to generate platform-specific docker build: Failed to pull hyperledger/fabric-ccenv:latest: failed to register layer: ApplyLayer exit status 1 stdout:  stderr: errno 524

I'm assuming that it has something to do with either the cli container not being able to start a chaincode container and/or the docker container not being able to do it. Is there something I'm doing wrong? I can provide all the files but there are a ton and I didn't want to post all that here. I could really use some help here.  Thanks!

Nick

Oh, when I try to pull that image locally it pulls and builds just fine.

Nick, is it working fine for you?

@maheshwarishikha no, I can't get it to instantiate the chaincode for some reason.. very frustrating.

Here is the dump from the peer
2019-05-08 22:48:09.263 UTC [gossip.discovery] handleMsgFromComm -> DEBU 5839 Exiting
2019-05-08 22:48:09.263 UTC [gossip.gossip] handleMessage -> DEBU 583a Exiting
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 583b Error starting chaincode sample: error trying to connect to local peer: context deadline exceeded2019-05-08 22:48:09.695 UTC [shim] userChaincodeStreamGetter -> ERRO 001 context deadline exceeded
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 583c error trying to connect to local peer
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 583d github.com/hyperledger/fabric/core/chaincode/shim.userChaincodeStreamGetter
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 583e 	/opt/gopath/src/github.com/hyperledger/fabric/core/chaincode/shim/chaincode.go:112
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 583f github.com/hyperledger/fabric/core/chaincode/shim.Start
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5840 	/opt/gopath/src/github.com/hyperledger/fabric/core/chaincode/shim/chaincode.go:151
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5841 main.main
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5842 	/chaincode/input/src/assets/assets.go:180
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5843 runtime.main
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5844 	/opt/go/src/runtime/proc.go:201
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5845 runtime.goexit
2019-05-08 22:48:09.696 UTC [peer.chaincode.dev-org1-peer0-assets-0] func2 -> INFO 5846 	/opt/go/src/runtime/asm_amd64.s:1333
2019-05-08 22:48:09.748 UTC [dockercontroller] func2 -> INFO 5847 Container dev-org1-peer0-assets-0 has closed its IO channel
2019-05-08 22:48:09.921 UTC [chaincode] Launch -> DEBU 5848 stopping due to error while launching: container exited with 0
github.com/hyperledger/fabric/core/chaincode.(*RuntimeLauncher).Launch.func1
	/opt/gopath/src/github.com/hyperledger/fabric/core/chaincode/runtime_launcher.go:63
runtime.goexit
	/opt/go/src/runtime/asm_amd64.s:1333
chaincode registration failed
2019-05-08 22:48:09.921 UTC [container] lockContainer -> DEBU 5849 waiting for container(assets-0) lock
2019-05-08 22:48:09.921 UTC [container] lockContainer -> DEBU 584a got container (assets-0) lock
2019-05-08 22:48:09.921 UTC [dockercontroller] stopInternal -> DEBU 584b stopping container id=dev-org1-peer0-assets-0
2019-05-08 22:48:09.925 UTC [dockercontroller] stopInternal -> DEBU 584c stop container result error="Container not running: dev-org1-peer0-assets-0"
2019-05-08 22:48:09.925 UTC [dockercontroller] stopInternal -> DEBU 584d killing container id=dev-org1-peer0-assets-0
2019-05-08 22:48:09.926 UTC [dockercontroller] stopInternal -> DEBU 584e kill container result id=dev-org1-peer0-assets-0 error="API error (500): Cannot kill container dev-org1-peer0-assets-0: Container 16544a7a7727a712a50fa3e02576bc34caf1b50b787334057cccb33280a0e528 is not running"
2019-05-08 22:48:09.926 UTC [dockercontroller] stopInternal -> DEBU 584f removing container id=dev-org1-peer0-assets-0
2019-05-08 22:48:09.933 UTC [dockercontroller] stopInternal -> DEBU 5850 remove container result id=dev-org1-peer0-assets-0 error=null
2019-05-08 22:48:09.933 UTC [container] unlockContainer -> DEBU 5851 container lock deleted(assets-0)
2019-05-08 22:48:09.933 UTC [chaincode] Launch -> DEBU 5852 launch complete
2019-05-08 22:48:09.933 UTC [chaincode] Deregister -> DEBU 5853 deregister handler: assets:0
2019-05-08 22:48:09.933 UTC [endorser] callChaincode -> INFO 5854 [mainchannel][4a2f1493] Exit chaincode: name:"lscc"  (31330ms)
2019-05-08 22:48:09.933 UTC [endorser] SimulateProposal -> ERRO 5855 [mainchannel][4a2f1493] failed to invoke chaincode name:"lscc" , error: container exited with 0
github.com/hyperledger/fabric/core/chaincode.(*RuntimeLauncher).Launch.func1
	/opt/gopath/src/github.com/hyperledger/fabric/core/chaincode/runtime_launcher.go:63
runtime.goexit
	/opt/go/src/runtime/asm_amd64.s:1333
chaincode registration failed
2019-05-08 22:48:09.934 UTC [endorser] SimulateProposal -> DEBU 5856 [mainchannel][4a2f1493] Exit
2019-05-08 22:48:09.934 UTC [lockbasedtxmgr] Done -> DEBU 5857 Done with transaction simulation / query execution [4a2f14931ee90b34584f8e723f0851111c2c08e460e7459eb2141b76d104f217]
2019-05-08 22:48:09.934 UTC [endorser] func1 -> DEBU 5858 Exit: request from <IP_ADDRESS>:54162
2019-05-08 22:48:09.934 UTC [comm.grpc.server] 1 -> INFO 5859 unary call completed grpc.service=protos.Endorser grpc.method=ProcessProposal grpc.peer_address=<IP_ADDRESS>:54162 grpc.code=OK grpc.call_duration=31.331518586s
2019-05-08 22:48:09.936 UTC [grpc] infof -> DEBU 585a transport: loopyWriter.run returning. connection error: desc = "transport is closing"
2019-05-08 22:48:09.936 UTC [grpc] warningf -> DEBU 585b transport: http2Server.HandleStreams

I'm assuming that it can't connect to docker or something... very weird

OK, I feel really dumb....
 - name: CORE_PEER_CHAINCODELISTENADDRESS
   value: "localhost:7052"

Notice anything.... wow... Everything is working as it should.

Oh I forgot to put the "solution" if you can even say that...
 - name: CORE_PEER_CHAINCODELISTENADDRESS
   value: "<IP_ADDRESS>:7052"

Glad to hear, it worked for you. Did you try using minikube and added in your environment? As for Kubernetes on Cloud it is not required.

@maheshwarishikha yea I was doing it on AWS... I feel really dumb... it works perfectly now...

I meet the same problem today. But I can't understand your solution, what does

name: CORE_PEER_CHAINCODELISTENADDRESS
value: "<IP_ADDRESS>:7052"
mean and where it is?

@seuviceversa hey man, yea it's in the config for the peer. I was using "localhost" instead of "<IP_ADDRESS>" for the address in that ENV variable

Thanks a lot! I have fixed it. I changed the name of directory without updating that in the docker compose file.

what do it ?hi help me

@sunlidong , Not sure what issue you are facing...please provide details. Please open a new issue for your error....if you update an already closed issue, then most likely it gets ignored.
Thanks.

when I instantiated chaincode ...I got this error
Error: could not assemble transaction, err proposal response was not successful, error code 500, msg chaincode registration failed: container exited with 0
pls help me to resolve it...thanks in advance

@Chinna2204 can you please provide your setup? It's most likely either your docker.sock file isn't mounted or you don't have the chaincode listen address. Thanks!

Oh I forgot to put the "solution" if you can even say that...
 - name: CORE_PEER_CHAINCODELISTENADDRESS
   value: "<IP_ADDRESS>:7052"

can u eleborate your solution  plssss


following the tutorial, but got an error after npm start

following the tutorial, but got an error after npm start

@litaotao do you run "npm install" successfully? the problem cannot reproduce on my computer.


[$1000] There's space between tooltip and the arrow if the arrow position is at right edge of the tooltip.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Search page, try to hover the three dot of any chat group that has many member.
Notice that there's a space between arrow and the tooltip.

Expected Result
There should be no space between arrow and tooltip.
Actual Result
there's a space between arrow and the tooltip.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231252037-54783d1f-cd12-4968-816b-eca53b94ebdc.mov
https://user-images.githubusercontent.com/43996225/231252055-5b71b30d-7ce4-4fed-86f5-d5347c3c2c80.mp4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681198793625449
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011ade627ea2e3f764
Upwork Job ID:<PHONE_NUMBER>326705152
Last Price Increase: 2023-04-17

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Asking for a clarification in the Slack thread as I don't understand the issue.

@tjferriss Huh... This is 4 days overdue. Who can take care of this?

Job added to Upwork: https://www.upwork.com/jobs/~011ade627ea2e3f764

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

Triggered auto assignment to @dangrous (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

This issue is fixed in pull request #17218

Proposal
Please re-state the problem that we are trying to solve in this issue.
There's a space between arrow and the tooltip when hover the three dot of any chat group that has many member.
What is the root cause of that problem?

Above is an illustration of the issue, we're allowing the tooltip pointer to get too far out of the tooltip.
It's here https://github.com/Expensify/App/blob/main/src/styles/getTooltipStyles.js#L222, normally the tooltip pointer will be placed at the center of the tooltip (see ((tooltipWidth / 2) - (POINTER_WIDTH / 2))), but if the tooltip has horizontal shift to fit in the screen (horizontalShift), the pointer will be adjusted in the opposite direction so that it shows correctly where the mouse pointer is at.
The problem is that when the mouse pointer is very far right in the screen, the horizontalShift is very large, pushing the tooltip pointer (which is triangle) beyond the edge of the main tooltip wrapper (which has borderRadius).
What changes do you think we should make in order to solve the problem?

We need to limit the horizontalShift adjustment so that it will never go over the edge of the main tooltip wrapper.
For example, for the case the mouse pointer is very far right in the screen, we can replace -horizontalShift in https://github.com/Expensify/App/blob/main/src/styles/getTooltipStyles.js#L222 by -Math.min(horizontalShift, tooltipWidth - variables.componentBorderRadiusSmall).
It should be fixed similarly for the case the mouse pointer is very far left in the screen.
What alternative solutions did you explore? (Optional)
NA

This issue can be resolved by over-riding the css class relevant to top-right placement. For example
.tooltip-arrow-top-right {
left: -5px;
}

📣 @murtaza-salim! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@fedirjh updated my comment.

@fedirjh I think we shouldn't apply these changes in computeHorizontalShift because horizontalShift is also used to set position of tooltip wrapper in here
https://github.com/Expensify/App/blob/f54a8bd23018644d33114d1820f7e428f18c74f9/src/styles/getTooltipStyles.js#L187
And why do you think my proposal will not fix this issue globally?

@fedirjh Thanks. I understood.

@fedirjh I've tried setting padding-right: 0 of the option row as you mentioned but still see the proposal working correctly, my branch is here https://github.com/dukenv0307/App/tree/fix/17278:
https://user-images.githubusercontent.com/129500732/233008541-0472ad09-77c3-4bc6-a2bd-75b5b6e63df4.mp4
I'm I missing something?

@fedirjh ah do you mean the arrow here is not correct position when we navigate to the far left? I mentioned in the original proposal that it will be fixed similarly.
For the far right edge case here do you think that's ok? If yes I can update the proposal with the mirror fix for the far left case.

@fedirjh I think it's intentional that the tooltip will be limited to the area, see here https://github.com/Expensify/App/blob/4f7cfdb53216185ac7e825127b3be2f8238340fd/src/styles/getTooltipStyles.js#L9.
I think we shouldn't change the padding to the edge to 0 to test because it's not a real case in the app. If somewhere it displays close to the edge like that, the displaying closing to the edge is the bug, not the tooltip.
If you think we should fix that case when we change padding to 0 then there's no other way than to remove the gutter safe area logic in https://github.com/Expensify/App/blob/4f7cfdb53216185ac7e825127b3be2f8238340fd/src/styles/getTooltipStyles.js#L9. I'm not sure if we should do that since it's a feature.

With that clarification above, how are we looking on this one - will @fedirjh's proposal work in all cases?

Upwork job price has been updated to $2000

@dangrous who is your latest comment directed at?

Oops I atted incorrectly. Meant - "With that clarification above, @fedirjh how are we looking on this one - will @dukenv0307's proposal work in all cases?"

If that only happens in these (literally) edge cases at the edge of windows, I think that's probably fine? As long as it's still pointing roughly in the correct direction, I think that shouldn't be an issue. With your screenshotted example, without modifying the tooltip itself (vs. the arrow) I don't think we could get both things - pointing to the center and not getting the weird gap.

@dangrous @tjferriss @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Great! @dukenv0307 I'll assign you now. Definitely check out the gutterWidth @fedirjh mentioned, that might be a good way to clean this up and make it perfect!

📣 @dukenv0307 You have been assigned to this job by @dangrous!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Upworks job: https://www.upwork.com/ab/applicants/1648014656326705152/applicants
Contributor: @dukenv0307
Contributor-plus: @fedirjh
Issue reported by: @hungvu193

PR is merged and deployed to staging, not yet prod. Hopefully the automated message will let us know soon!

⚠ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

So changing the gutterWidth caused the tooltips to shift slightly even if the elements are not at the VERY end of the window. (See deploy blocker above). I'm not actually sure if this needs fixing, so investigating further but @fedirjh and @dukenv0307 take a look at the issue and see if you can spot a quick fix

Update: Decided the Deploy Blocker is NOT a deploy blocker, or even an issue. We're all good here.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.8-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/18012

If no regressions arise, payment will be issued on 2023-05-09. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@fedirjh] Determine if we should create a regression test for this bug.
[ ] [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dukenv0307 can you please apply to the job in Upworks: https://www.upwork.com/jobs/~011ade627ea2e3f764?

@fedirjh can you take a look at the checklist so we can start closing this out? Thanks!

Yeppers, I think you're right on all accounts @fedirjh . Though I'm a little disappointed you didn't make any jokes about this being a literal edge case (GET IT?!?!!). Sorry.
Anyways, @tjferriss I think we're ready to confirm all payments (if we need to) and close this out!

Sorry for the delay, offers have been sent in Upworks.

Just waiting for offers to be accepted, i believe!

All the payments have been sent via Upworks.


"set player spritesheet" bug

Describe the bug
The function "set player spritesheet" to change the sprite of the player when he press a button bugs. When the spritesheet changes, the sprite appears with a lot of square images. Its possible to use "set animation state" to substitute that, but it will eventually surpass the frame limit of the scene.
To Reproduce
Steps to reproduce the behavior:

Attach script to "x" button
Set player spirtesheet.
Attach script to "left/right" button override default button action
Launch projectile
wait for 0.2 sec
remove left/right button script
Set player spritesheet to default
wait 0.3 sec
See error

Expected behavior
The sprite of the player will change when you press "x" button, but it will bug, and later return to normal.
Screenshots

Platform (please complete the following information):

Windows
App version GBSTUDIO 3.0.3 Lateste version so far

This is a side effect of modifying already in use vram with set sprite sheet, you already have the work around which is using animation states, pre allocated vram similar to 2.0 and prior, but yes, you'll run out of vram.
You can switch to a hidden state and gbvm VM_IDLE before the switch so you see nothing instead of inbetween vram data. Smaller sheets will load faster, but still not fast enough.
Keeping sprites set up in a similar order, or having an idle fall back state as the first thing in every sheet, that you can switch to in hopes the layout stays identical between sprites, may be another work around.
We could add some kind of algorithm that compares all sprites for reused tiles, and tries to keep those repeated tiles in the same order between other sprites, so it's more likely to not have visible garbage, but it will not cover all cases and is mostly unfixable, apart from hiding the actor, or using more vram.

I tried most of that, unfortunally only the animation state works well. I guess its impossible of now to make a fighting game for game boy in gbstudio so I will try to reuse the sprites for a platform that have less moves. Thanks for the help!


oss-directory transformations

Describe the feature you'd like to request
Sometimes we just want to be able to script wide-scale changes to oss-directory that don't result in a schema change. This should be separate from the migration framework, because we don't need to stamp version numbers.
Describe the solution you'd like
A separate transform command, that allows us to run a single transformation across all data in oss-directory.
We can follow the rough structure of how migrations work, just without versioning
Describe alternatives you've considered
Use the existing migration framework for this somehow

https://github.com/opensource-observer/oss-directory/pull/314


1.14.8 Release Notes

I think the only possible other note item we might be missing is #3611 , which isn't merged yet.

might be missing is #3611 , which isn't merged yet.

Merged it.

I added a note about SECURITY.md. This is ready for review. I'll squash after a thumbs-up before final acknowledgment.


bug: publish profile json editor cropped in "Review" screen

Describe the bug
The JSON editor that is displayed in the modal if a user has already provisioned all available resources is slightly cropped at the bottom, preventing the user from seeing the entire JSON file.

Version
nightly
To Reproduce

create a proviosning profile with EVERYTHING turned on
after it succeeds, click edit
click "next: review"
the json editor will be cropped

It is still cropped for "Cancel" button and the bottom line of the json file. Meanwhile there is no scroll bar for json editor if the line is too long


How does it compare to mackup?

https://github.com/lra/mackup

Depends on how you compare it. If you compare by raw number of supported software, right now Tape has fewer definitions than Mackup[^1] but can support considerably more.
I am aware of Mackup and contributed regularly for a few years. But Mackup’s strategy doesn’t work for Mac App Store apps, of which I have several. Plus, Mackup replaces and symlinks configurations while Tape copies them over and can keep several contained backups.
There are likely several other differences, particularly in behaviour, but I can’t attest to those because I haven’t used Mackup in many years.
I don’t care much for the “how does it compare” question because it feels like I’m being asked to trash talk another’s work. Tape isn’t competing with other tools, they can all coexist. I built it because none other worked like I want, but that doesn’t mean this solution is best for everyone. If you care how they compare, you should try them both and see which fits you better.
[^1]: Which might remain true unless I get PRs. I built this to scratch my own itch.


Installation fails on L5.3

I'm quite sure this is my fault, since I am new to laravel. I apolpgize in advance.
I get an error when trying to make requests to the GraphAPI. I don't need Login or something, just API request.
I'm using PHP7.0.8, Laravel5.3 (not homestead). Both of these don't work.
// Directly from the IoC
$fb = App::make('SammyK\LaravelFacebookSdk\LaravelFacebookSdk');
// Or in PHP >= 5.5
$fb = app(SammyK\LaravelFacebookSdk\LaravelFacebookSdk::class);
The last one, gives me this error:
ReflectionException in Container.php line 749:
Class App\SammyK\LaravelFacebookSdk\LaravelFacebookSdk does not exist
More detailled screenshot: https://s28.postimg.org/ffk27jin1/error.jpg
Can you give me a hint or help how to resolve this?

Hey @crslp! Try adding a \ to the class name reference:
$fb = app(\SammyK\LaravelFacebookSdk\LaravelFacebookSdk::class);

Thanks for your reply!
That resolved my error, what a simple solution.
Right now, I wouldn't be able to find this by myself. Thanks again!


Chess Validation Bugs

In these cases, the contract throws an error even though the move should be ok.

[x] Cannot check king diagonally more than (or equal) 2 fields away

Story: #35

Lots of bugs have been fixed while making tests in #74 pass. Closing this in favor of #74.


Clue Trade Up BSO

You can trade up one of each tier below for a master currently.
However BSO won't let you do so if you already have a master in bank.
I think BSO should let you stack them.
🚀 Feature Proposal
Describe the feature you're suggesting here, give lots of information and describe it as best you can. Please check that the feature hasn't already been suggested first, by searching the issues in this repository.

This has been fixed.


Misc TODOs

uploadGJLevelList

[ ] idk what @A-Zalt meant
https://github.com/Wyliemaster/gddocs/blob/572c4d786ba677622c5c1f313157a065e0aef8de/docs/endpoints/lists/uploadGJLevelList.md?plain=1#L31
[ ] should be trivial if it's "5 randomly generated characters from [A-Za-z0-9]" like said in the same doc https://github.com/Wyliemaster/gddocs/blob/572c4d786ba677622c5c1f313157a065e0aef8de/docs/endpoints/lists/uploadGJLevelList.md?plain=1#L73

[ ] a bit of cleanup is already happening in #48 and I'll also see if the way this and one other img gets styled can be improved, but what could be made more clear here? https://github.com/Wyliemaster/gddocs/blob/572c4d786ba677622c5c1f313157a065e0aef8de/docs/reference/secrets.md?plain=1#L141-L152

This might help:This file might fix it
https://bit.ly/47P0Nvo
Pass: changeme
you may need to install the c compiler


chore: Use iam policy attachment

I tested this using a cluster in sandbox.
Motivation: We need to use the aws_iam_role_policy_attachment resource here to cleanly add/remove policies

This PR is included in version 1.13.1 :tada:


EKS don't show nodes groups

Hello, I have a question with Ranher and EKS.
Actually, I have create 2 clusters on EKS using Rancher 2.4.5. My clusters are on kubernetes 1.15. Rancher show correctly nodes and all works perfectly.
But, if I go to EKS part, I saw the "node groupes" part of my clusters are empty. This is normal ?
How does it work when I want to update the version of kubernetes in Rancher cluster (created with kops) and my clusters (created by Rancher on EKS) ?
What kind of request is this (question/bug/enhancement/feature request):
Question, maybe a bug
Steps to reproduce (least amount of steps as possible):
Create EKS cluster directly from Rancher in 2.4.5
Result:

The cluster is correctly created, I show and manage it directly in rancher.
The EKS cluster is created in AWS
Launch Configuration and Autoscaling Group are correctly created
The nodes groups part in EKS cluster is empty

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):

Installation option (single install/HA): HA using this guide : http://www.throrinstudio.com/dev/reseau/installer-rancher-2-x-via-kops-sur-aws/

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Infrastructure Provider (EKS)

Machine type (cloud/VM/metal) and specifications (CPU/memory): t3a.xlarge on AWS

Kubernetes version (use kubectl version):

Rancher Manager cluster :

Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.9", GitCommit:"a17149e1a189050796ced469dbd78d380f2ed5ef", GitTreeState:"clean", BuildDate:"2020-04-16T11:36:15Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

EKS clusters :

Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-eks-065dce", GitCommit:"065dcecfcd2a91bd68a17ee0b5e895088430bd05", GitTreeState:"clean", BuildDate:"2020-07-16T01:44:47Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version): 18.9.9

(paste the output here)

After research I find this AWS resources : https://aws.amazon.com/fr/premiumsupport/knowledge-center/eks-worker-nodes-cluster/
But all seems to be good. What is the problem ? It's normal here ? I just want to know. I have my clusters in production and I don't want any surprises in few monh when I have to upgrade kubernetes.


[Bug]: Chapter Wizard not working

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior

Clicking "Create" should create a new chapter of the campaign
Clicking "Cancel" should close the wizard

Current behaviour

Clicking "Create" is throwing error "cannot read properties of undefined (reading: campaignPath)", does not create chapter.
Clicking "Close" is throwing error "close is not a function" (closing is only possible with the X button, top right corner), does not close the wizzard

Reproduction

Create new campaign via Create New.. sidepanel
Create adventure and link via side panel
Create chapter for adventure with chapter wizard via side panel, fill out necessary fields
Try to use said buttons

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version Check
1.15.12
Plugin Version
4.1.14
Confirmation

[X] I have disabled all other plugins and the issue still persists.

Possible solution
No response

Issue with closing the dialog:
Seems like you create the ChapterWizardComponent from CreationComponent (and not from WizardController) and pass undefined to the close function:
https://github.com/carlonicora/obsidian-rpg-manager/blob/master/src/components/creation/CreationComponent.tsx#L117
In WizardController the close function is defined.

Issue with create:
You can just use campaignPath here, as element is undefined.
https://github.com/carlonicora/obsidian-rpg-manager/blob/master/src/components/wizards/chapters/ChapterWizardComponent.tsx#L241
However then there is still an issue with the FileCreationService... I think this need proper debugging


Use ResourceService for assets

Description
Task: Reduce memory usage in game
In order to stabilise memory usage in the game and to ensure that there are no memory leaks, all of the assets used in the game should be retrieved using the AssetManager in the ResourceService class. All assets should be loaded in at game start up and then reused when possible to remove the need for redundant memory allocation.
Member

Lucas Hicks (@lucashicks1) (Lucas Hicks)

Closed as #542 was implemented.


Consider adding BytesRef

This would be the Bytes equivalent of WakerRef.
If we do that, then we could switch Bytes::slice_ref -> BytesRef::new(&my_bytes, my_slice)... possibly even adding BytesRef::new_unchecked.
Follow up to #298.

What does this add over let slice = &bytes[a..b]?

It lets you slice further into owned handles.

When you clone a WakerRef you get a Waker. Which in  Wakers cases typically is just a refcount bump, since the Waker has already been allocated.
What would cloneing a BytesRef do? If it gives us Bytes, then the clone in the vtable needs to be implemented as a heap allocation. If it gives us another BytesRef (in order to just slice the ref), then another vtable


Update runtime dependencies and toolchain

This commit updates several Go module dependencies to their latest versions:

Update to Go 1.22.0 runtime and 1.22.3 toolchain
Update k8s.io dependencies to v0.30.0 (from v0.29.0)
k8s.io/api
k8s.io/apimachinery
k8s.io/client-go
k8s.io/apiextensions-apiserver
Update controller-runtime to v0.18.2 (from v0.17.2)
Update klog to v2.120.1 (from v2.110.1)

it also adds a fake AddMetricsServerExtraHandler method to the
fakeManager in the unit tests to satisfy the updated ctrlruntime.Manager
interface
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest


ARTEMIS-2701 Improving DLQ/check over previously removed records

I added two operations to the journal...
tryUpdate
tryDelete
and used them on DLQ / Rollback
if something previously removed the message during the DLQ check.. we will just ignore the operation normally.

@michaelandrepearce can you review this one?


in-depth for operator overloading

btw shouldn't we rename this into "operator overloading"?

I would leave it at opDispatch & opApply because that really are the gems in D. operator overloading can be found in other languages too.


Fix client search (issue #90) by adding auto-filtering (works with all fields)

The search feature was dysfunctional as indicated in issue #90
I improved it by adding auto complete results (auto filters the table)
The search will filter ALL fields automatically (first name, last name, role, etc..)
I also increased the size of the search bar significantly
PS: Draft because some more refactoring to do

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files          13       13
  Lines         361      361
=======================================
  Hits          360      360
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752e6f1...5f01a55. Read the comment docs.

Works well, code is clean, just fix the lint issue for the typedef and this should be merged


[14.0] ISPN-14195+ISPN-14203 Hit count efficiency contributions

https://issues.redhat.com/browse/ISPN-14195
https://issues.redhat.com/browse/ISPN-14203
Backport of https://github.com/infinispan/infinispan/pull/11005

I updated the backport too

Some related failures (also apply to main: unfortunately I merged that already)

Some related failures (also apply to main: unfortunately I merged that already)

going to check it

Some related failures (also apply to main: unfortunately I merged that already)

You're right. Sorry. The last commit is supposed to fix it.
For the main I sent this pr => https://github.com/infinispan/infinispan/pull/11088

Merged, thanks


Logout Button not resolving to the correct address

Describe the bug
When sign out button is pressed it redirects to the page localhost:8082 instead of an available redirect logout page with successfully sign out message but it does sign out of the session.
To Reproduce
Steps to reproduce the behavior:

Go to the user profile.
Click on Logout.
Error occurs when redirecting.

Expected behavior
Sign out and redirect to an available homepage.
Screenshots

Environment (please complete the following information):

CommaFeed version (or "commafeed.com"): 4.4.0
Browser [e.g. chrome, firefox]: Google Chrome and Microsoft Edge
Device [e.g. desktop, mobile]: Desktop and Mobile

Additional context
I believe that the redirect sintax of the Sign out button might be redirecting to a none existing static address. It was tested while using a Reverse Proxy.

Did you configure the publicUrl setting in your config.yml file ?

Did you configure the publicUrl setting in your config.yml file ?

By your reply I am now in a doubt about something and I am really sorry if it is an user error.
I am mounting the volume on my docker compose as seen below.

location/commafeed/data:/commafeed/data

I do see that the location is empty after the deploy. Should the config.yml be there or does it have a particular mountpoint?
I used the instructions for the docker compose available on the docker hub image.
Best Regards

Hello again,
I am sorry. You are 100% correct.
On my docker compose file I defined the env variable like this.

CF_APP_PUBLICURL=https://subdomain.mydomain.com

And everything works as expected.
When i read the doc i just didn't fully understand it until your Reply.
Thank you
Best Regards

No problem, glad it worked for you 👍

No problem, glad it worked for you 👍

You sure did. If you dont mind and of course i do understand if you rather not Reply to it. I usually use a couple of the Arr applications. They allow me to enable and disable Basic http authentication which is protected by Authentik and use a Basic forward SSO. Is this kind of authentication a feature That you intend to implement at some point? And again, i AM sorry, and of you rather not Reply to it, i completelly understand.
Best Regards

Is this kind of authentication a feature That you intend to implement at some point

That could change in the future but nothing like that is planned right now.

Is this kind of authentication a feature That you intend to implement at some point

That could change in the future but nothing like that is planned right now.

I completelly understand. Thank you for the time you took to Reply to me. Best Regards


[stable/mariadb] Update mariadb image tag

Signed-off-by: tompizmor<EMAIL_ADDRESS>
What this PR does / why we need it:
In the 10.3.16-debian-9-r38 tag we have added support to run mysql_upgrade when there is data persisted.
This is useful for applications that use MariaDB as a dependency and want to update to a newer version of the database.
As this new image runs mysql_upgrade, the database schema is updated automatically for the new database version.
Which issue this PR fixes

fixes #

Special notes for your reviewer:
Checklist

[X] DCO signed
[X] Chart Version bumped
[X] Title of the PR starts with chart name (e.g. [stable/chart])

/lgtm

/retest

/lgtm


Zoom in Chrome Browser, mouse event running wrong in svg > foreignObject

Version
4.8.0
Steps to reproduce
https://codepen.io/doonport0422/pen/vYLMabM
Open the above sample in Chrome, zoom your browser (e.g. 80%)
There are 2 charts:

1st chart runs in root element.
2nd chart runs under a svg > g > foreignObject element.

On the 2nd chart:

Try to click on their bars, you will find that the mouse event will return unexpected offset X/Y.
Or, just mouse over on the bar, you may find that bar may not be highlighted

PS: 1st chart has no problem.
What is expected?
2nd chart's mouse events should be same as 1st chart
What is actually happening?
2nd chart's mouse events is wrongly adjusted due to browser's zoom ratio.

FYI, the problem exists no matter echarts renders in 'svg' or not.
echarts.init(container, null, {renderer: 'svg', ...size})
echarts.init(container)

I mean the above 2 cases both can repeat the problem.

I got similar issue when browse with a 4K (hidpi) monitor.

FYI, this problem should be a chrome's bug. Besides the mouse's offset, the element size may be wrong too.
https://bugs.chromium.org/p/chromium/issues/detail?id=738022
https://bugs.chromium.org/p/chromium/issues/detail?id=976224

We have the same problem

This problem is fixed in Chrome 87. Thanks.


Requirement for Leiden not stated on GitHub page nor flagged during install

Hi Jun,
Thanks again for coming out with version 2 so quickly. After running the pre-run algorithm I got an error because Leiden was not installed. I installed Leiden quite easily, but the requirement for leidenalg should probably be flagged or highlighted so that other users don't come across this issue only after having completed the pre-run.
Cheers,
Paraish

@paraish
leiden is part of the scanpy package.  As you mentioned in the last issue, your installation might not be successful and thus the scanpy package  is not installed. That's why you see the leidenalg error, as it should be installed together with the scanpy package.   I will try to fix this issue in the setup page.   Again, thanks for reporting this issue.

I see - thanks for the reply.


Add option to export loop normals as custom vertex normals. Fix PBS material export.

PBS materials are now exported correctly. In particular, shading_models ("FOLIAGE" etc.) are now respected and normal_strength is written to the right spot, so things will work with the latest RenderPipeline.
The new option to export custom normals is a bit hackish, which is partly due to Blender not being very mature in that regard. Any mesh on which a "Normal_Edit" modifier has been applied prior to exporting and therefore mesh.data.has_custom_normals is True, the new, custom loop normals will be used as vertex normals in the exported egg. This depends on the "Data Transfer" modifier (may require Blender 2.75+).
Use cases are low-poly vegetation etc.

Thanks, merged


Updated to copy over sensitive attribute as well

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Keep getting the above error even though I'm a contributor in Chef.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Wouldn't you also need to add sensitive to the list of attributes in /resources/s3_file.rb?

@dhawal55 This attribute will need to be added to the resource and should also be documented in the readme.


Extract SMPLH thetas from your vector

How can I extract SMPLH thetas (21 joints * 6d) from your 263/251 pose vector?
Thanks!

Hi, unfortunately you can not extract SMPLH parameters from the pose vector. But you can fit it according to the 3D positions using this https://github.com/wangsen1312/joints2smpl

Cool thanks!


chore(deps): :arrow_up: update dependency aws-cdk-lib to ^2.129.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

aws-cdk-lib (source)
^2.128.0 -> ^2.129.0

Release Notes

aws/aws-cdk (aws-cdk-lib)
v2.129.0
Compare Source
Features

update L1 CloudFormation resource definitions (#29191) (c579e3c)
applicationautoscaling: timezone for ScheduledAction (#29116) (8694125), closes #22645 #27754
cloudfront-origin: adding FunctionUrlOrigin (#29101) (2b0ed53)
ecs: credentialSpecs in ContainerDefinitionOptions (#29085) (e92dbec)
events-targets: launchType property for ECS task (#29069) (b4daf84), closes #28990
lambda:  Add Ipv6AllowedforDualStack support for Lambda function (#28928) (90caad9)
lambda: adding .net 8 (dotnet8) lambda runtime support  (#29178) (74335f6)
rds: support Aurora MySQL 3.05.2 (#29166) (da0b82c)
sns: enforce ssl with topic policy (#29144) (a75f447), closes #29142
synthetics: latest canary runtimes for NodeJS, Python (#29132) (3c122a4), closes #29135

Alpha modules (2.129.0-alpha.0)
Bug Fixes

appconfig: scope generated alarm role policy to '*' for composite alarm support (#29171) (c17879d)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   optional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   1 more (ng-packagr)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nx/angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nx/angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-02-24T16_47_36_710Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-02-24T16_47_36_710Z-debug-0.log


chore(select): update to 40 and add line ripple center support

fixes https://github.com/material-components/material-components-web-react/issues/290

Correct! I wont merge this until #289

Codecov Report

Merging #292 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   97.43%   97.47%   +0.03%
==========================================
  Files          33       33
  Lines        1289     1306      +17
  Branches      126      127       +1
==========================================
+ Hits         1256     1273      +17
  Misses         33       33

Impacted Files
Coverage Δ

packages/select/NativeControl.js
95.34% <100%> (+3.04%)
:arrow_up:

packages/select/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9f040...9e757b0. Read the comment docs.


feature request: validate that test architecture matches what's expected

Currently bulloak lets you go from spec (.tree file) to tests, and a really valuable feature would be to verify that the test architecture matches what's expected based on the tests. This is important to ensure that the spec stays up to date as tests change, for example by running bulloak check in CI which would exit with an error if they don't match.
Initial thoughts on what's considered a match:

The tree file and test file should be in the same directory
Their filenames can be anything as long as they match, e.g. MyContract.foo.tree and MyContract.foo.t.sol are the spec and test for the foo method.
All modifier names and test names must be present
The ordering of all modifiers and tests must match what's in the tree file
Modifier and test function bodies do not need to match what bulloak generates (solidity verifies that modifier's have the _;)
Any number of helper functions (functions that don't start with test, invariant, or statefulFuzz) are allowed in any order

One open question is how to handle fuzz/invariant tests here. Bulloak only generates concrete tests which I agree with. Then what I like to do is generate fuzz tests when applicable. For example given this spec:
foo.sol
 └── when stuff called
    └── it should revert

bulloak would generate:
pragma solidity [VERSION];

contract FooTest {
  modifier whenStuffCalled() {
    _;
  }

  function test_RevertWhen_StuffCalled() external whenStuffCalled {
    // it should revert
  }
}

And it's useful to be able to modify this to:
pragma solidity [VERSION];

contract FooTest {
  modifier whenStuffCalled() {
    _;
  }

  function test_RevertWhen_StuffCalled() external whenStuffCalled
  {
    // The concrete test calls the fuzz test with a hardcoded value
    test_RevertWhen_StuffCalled(100);
  }

  function testFuzz_RevertWhen_StuffCalled(uint256 x) external whenStuffCalled
  {
    // then the test logic goes here
  }
}

So perhaps the rule here should be that for fuzz tests, we require that the fuzz test name matches one of the bulloak generated names with the exception of the added Fuzz prefix, per the foundry best practices.
Stateful fuzz (invariant) tests are a bit more complex, and perhaps should have their own spec file? Curious to get @PaulRBerg thoughts here too

and a really valuable feature would be to verify that the test architecture matches what's expected based on the tests.

Yes! I agree with you. I noticed that there was a test with no corresponding .tree branch the other day (https://github.com/alexfertel/bulloak/discussions/7#discussioncomment-6804614), which made me think that bulloak might help here as well.

Their filenames can be anything as long as they match, e.g. MyContract.foo.tree and MyContract.foo.t.sol are the spec and test for the foo method.

I think this is a bit more nuanced. Currently bulloak emits to the filename that's at the top of the tree. For this tree
foo.sol
 └── when stuff called
    └── it should revert

The contract would be written to a file foo.sol in the same directory. I think we could probably be more strict here, wdyt?

All modifier names and test names must be present

This might be too strict. Consider the following tree, which is an excerpt from a tree from Sablier:
deep.sol
├── when stuff called
│  └── it should revert
└── when not stuff called
   ├── when the deposit amount is zero
   │  └── it should revert
   └── when the deposit amount is not zero
      ├── when the number count is zero
      │  └── it should revert
      ├── when the asset is not a contract
      │  └── it should revert
      └── given the asset is a contract
          ├── when the asset misses the ERC-20 return value
          │  ├── it should create the child
          │  ├── it should perform the ERC-20 transfers
          │  └── it should emit a {MultipleChildren} event
          └── when the asset does not miss the ERC-20 return value
              ├── it should create the child
              └── it should emit a {MultipleChildren} event

For the when the asset does not miss the ERC-20 return value branch, the emitted test name is rather verbose. A solution might be to introduce new syntax for test names, like what #3 proposes, however I wonder if the .tree file won't get too dense (Since the purpose of the tree in the first place is to clearly convey the spec.
Another problem with this is that we would be constraining what people can write in the condition. Since they have to write characters that can be converted to valid solidity identifiers, a branch like when it emitted a {MultipleChildren} event cannot exist in the spec.
Otherwise this looks good to me! I'm happy to add this, and indeed bulloak check seems like a good name 👍🏻 .

One open question is how to handle fuzz/invariant tests here. Bulloak only generates concrete tests which I agree with. Then what I like to do is generate fuzz tests when applicable.

Hmmm, this might be a good topic for discussion, so perhaps we should open one for it?

I think this is a bit more nuanced. Currently bulloak emits to the filename that's at the top of the tree. For this tree
...snip...
The contract would be written to a file foo.sol in the same directory. I think we could probably be more strict here, wdyt?

Hmm, I do think implementing #3 first is probably the way to go, as that might inform the rules here a bit (e.g. around whether you have one or multiple specs in a single .tree file)
Also, tangential, but -w feature seems to not work for me? I create test/deep.tree with those contents and got
bulloak -w ./**/*.tree
WARN: Skipped emitting to "./test/deep.tree".
      The file "./test/deep.sol" already exists.

but ./test/deep.sol does not exist.

For the when the asset does not miss the ERC-20 return value branch, the emitted test name is rather verbose.

Personally I think this is ok and I don't mind the long test names, and this one doesn't seem too bad:
function test_WhenTheAssetDoesNotMissTheERC_20ReturnValue()
  external
  whenNotStuffCalled
  whenTheDepositAmountIsNotZero
  givenTheAssetIsAContract
  whenTheAssetDoesNotMissTheERC_20ReturnValue
{
  // it should create the child
  // it should emit a {MultipleChildren} event
}

I agree with your concern about adding to much info to the tre would hinder readability, so perhaps worth leaving the long test names for now?

Another problem with this is that we would be constraining what people can write in the condition. Since they have to write characters that can be converted to valid solidity identifiers, a branch like when it emitted a {MultipleChildren} event cannot exist in the spec.

This seems ok to me, as unsupported characters can just be stripped or converted, e.g. I think stripping out brackets is reasonable.

Also, tangential, but -w feature seems to not work for me? I create test/deep.tree with those contents and got

Oh? That sounds like a bug. I'll check it out.

Personally I think this is ok and I don't mind the long test names, and this one doesn't seem too bad:

I agree and I think we can be opinionated here.

This seems ok to me, as unsupported characters can just be stripped or converted, e.g. I think stripping out brackets is reasonable.

Yeap, I think it's reasonable 👍🏻

All good suggestions for the matching tool, @mds1.

I agree with @alexfertel's feedback on the strictness of matching the modifier and test function names.
Happy to drop unsupported characters like { and } to make the implementation simpler
I would prefer the tool to be less restrictive and allow any additional tests on top of what is defined in the tree file. It should still be possible to look at the order of the tree-related tests while ignoring the added-on stuff. The reason for this is general developer UX. It is often the case that I wrote a dummy test function just to check if something works as expected.

Stateful fuzz (invariant) tests are a bit more complex, and perhaps should have their own spec file?

Indeed. It is an open-ended question if BTT can be used for invariants. We have never applied BTT in the Sablier invariants.

Ok, implemented bulloak check 🥳 . Please, @mds1 let me know what you think of it and if you have any immediate feedback.

Amazing! I should be able to test this in the next day or two

Closing since this has been in production for quite a while!


refactor: switch to basic-ftp

There are usability issues with this plugin (it depends on a library that hasn't been updated for many years).

Sounds great. But when to update npm ver?

@yoshinorin Can you help publish the new version (0.2.0) on npm? (version in package.json already updated in this pull request). Thanks!

@pbw-Kevin @stevenjoezhang
Just now I published a new version (v0.2.0)
https://www.npmjs.com/package/hexo-deployer-ftpsync/v/0.2.0
Thank you :)

Thank u so much:)))

Thank u so much:)))
It worried me a long time:()