Update Castle.Windsor.Extensions.DependencyInjection to support .NET8

This Pull Request contains also all modification by Alessandro Giorgetti already made in PR #664 related to issue #646
This Pull Request aim to give Castle.Windsor.Extensions.DependencyInjection full support to .NET 8 new DI model with keyed service. The reason of this Fork was the inability to upgrade ours production code to .NET 8 due to internal error in Castle.Windsor. This problem happens especially with Microsoft Orleans 8 and sometimes code running on Kestrel 8.

Modified code to support KeyedService in .NET 8. All basic test from framework passes, also this pr contains some other tests that idenfy some problem that occurred in our production code
Scope management: Orleans 8 changed how it resolves grains so we always got a null Root Scope. This happens because the Root Scope is marked with AsyncLocal, but Orleans uses thread differently so that AsyncLocal is always null.
We introduced a modification in base Castle.Windsor to allow for IHandler to return the current kernel object. While this is somewhat an Hack, it was the only way for us to find the correct root scope when that AsyncLocal is null. This Hack can be avoided if we always use one single instance container, but this is a too restrictive situation.

We actually start using this code in our production code, because without these modification we have as only option to use Orleans 8 to entirely remove Castle.Windsor from our project (An extemely big work) so this code, starting from today, is running in our solution.
Feel free to ask any information or require modification in code if you feel that something is wrong.
Thanks.

Seems there is related issue
https://github.com/Finbuckle/Finbuckle.MultiTenant/issues/786
Finbuckle multi tenancy + CW as DI container (initially 5.1.2, migration to 6.0.0 do not help)

The project uses Windsor 6.0, and after configuring orleans client 8.0, it prompts "This service descriptor is keyed." Your service provider may not support key services

This pull request introduced keyed registration only in .NET 8, please confirm that your project targets .NET 8.

Lots of time passed, is there anyone that can comment/reject/accept this Pull Request?

Lots of time passed, is there anyone that can comment/reject/accept this Pull Request?

Yeah, what's taking so long? We're running into the same issues here, this PR fixes that..

From what I know, keyed service provider was introduced in ASP.NET core in .NET 8 and it is not present in previous version. I can be wrong but I was forced to add that directive because code does not compile in .NET 6 (have not tried with 7)

It was released along with .NET 8, but doesn't require .NET 8.
Microsoft.Extensions.DependencyInjection 8.0.0 is supported on multiple frameworks. I've used MS DI with keyed services on .NET Framework just fine. You should just need to update the NuGet package to 8.0.0 in your .NET 6 project and it should compile.

Perfect, I'll modify the branch as soon as possible. This will force people using castle on .NET 6 to update to version 8 of the DI package but I think that this can be just fine.

If someone used the version locally compiled, I've pushed a fix that makes impossible to use Microsoft Orleans 8.1.0, the error derived on how the basic Microsoft Dependency injection works with multiple registration of the same NON keyed service.
Update the test suite, tests are now green, Microsoft.Orleans 8.1.0 works.

@jklawrence I do not know if any maintainer is checking this PR. I can do the modification you requested, but this will force people using version 8.0.0 of dependency injection even if they use .NET 6 framework. I do not see any problem but I'd like some maintainer have last word on it.

If you are interested, I've updated the PR adding a fix that correctly restore the correct use of IsDefault(). In previous version of the adapter all services registered through the adapter with Microsoft DI services registered componente with the IsDefault() (Due to a different rule in resolution). That actually make not possible to correctly use the IsDefault() anymore. Fixed.

.NET 6 goes out of support tomorrow and Windsor does not yet properly support .NET 8.  What still needs to be done to get this PR over the finish line and get .NET 8 support?


[DOC] add anchor to documentation

Description
Add anchor to documentation
part of https://github.com/inmanta/lsm/issues/414
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Merged into branches master in 5fbf3624425a385490306accd3d92d2876753453

Processing #4309.


this is a test PR to see what build errors are left

to be closed after test.  will not merge.

GitHub issues have been created for HTML syntax warnings:
az webpubsub - https://github.com/Azure/azure-cli/issues/27054
az ams - https://github.com/Azure/azure-cli/issues/27055
az mariadb - https://github.com/Azure/azure-cli/issues/27056
az mysql - https://github.com/Azure/azure-cli/issues/27057
az postgres - https://github.com/Azure/azure-cli/issues/27058


Add missing highlights to object names

Event and Job objects did not have the same highlighting as other headings, which caused me some visual confusion.

Actually the job object section seems to be a repeat of some info from the earlier Job class section. Am I missing something or are they describing the same thing?


Deprecation/Removal of support for third-party devices?

https://learn.microsoft.com/en-us/windows/whats-new/deprecated-features

The page linked here is not in the mixed reality repository.  Please open bug/issue on the source page


0.5.0.beta2 not on rubygems

README says to use gem 'jsonapi-utils', '0.5.0.beta2' but beta2 is not yet released to rubygems. Only beta1 is available.

Sorry, @anothermh, it was my fault to let it go to the README. I still did not tag and release this new version of the gem because changes in the PR #27 will be packed along with the current changes on master. For now I'm going to fix the README, but v0.5.0.beta2 might be released soon. Thanks!


Deploy Checklist: Expensify.cash 2021-06-03

Release Version: 1.0.63-0
Compare Changes: https://github.com/Expensify/Expensify.cash/compare/production...staging
This release contains changes from the following pull requests:

[ ] https://github.com/Expensify/Expensify.cash/pull/3256
[x] https://github.com/Expensify/Expensify.cash/pull/3284
[ ] https://github.com/Expensify/Expensify.cash/pull/3285
[x] https://github.com/Expensify/Expensify.cash/pull/3333
[x] https://github.com/Expensify/Expensify.cash/pull/3351
[x] https://github.com/Expensify/Expensify.cash/pull/3352
[x] https://github.com/Expensify/Expensify.cash/pull/3353
[x] https://github.com/Expensify/Expensify.cash/pull/3361

cc @Expensify/applauseleads

Starting QA 🚀

Regression is finished!
1 issue found today.

https://github.com/Expensify/Expensify.cash/issues/3385

PRs are finished too:
1 comment added

https://github.com/Expensify/Expensify.cash/pull/3285#issuecomment-855161523

https://github.com/Expensify/Expensify.cash/pull/3256 is internal QA, I thought I had tagged you earlier please let me know if this was tested so I can check it off (my apologies for the delay). CC @jasperhuangg @Julesssss @tylerkaraszewski

Hey @jasperhuangg, is this testable internally on staging?

Starting QA 🚀

Regression is finished!
No issues found today.
PRs are finished too.
No comments added.
Thanks!

Fix for https://github.com/Expensify/Expensify.cash/pull/3285#issuecomment-855161523 here -> https://github.com/Expensify/Expensify.cash/issues/3101. Checking it off

Okay, looks like https://github.com/Expensify/Expensify.cash/pull/3256 may actually have been a failure, but it is hidden behind a beta so doesn't need to be a deploy blocker. Checking it off and running the prod deploy now.

:shipit:


Prevent node from marking itself as malicious

Motivation
The ATX handler should not create malfeasance proofs against the node itself. In case we have a bug somewhere that would publish 2 ATXs in a single epoch fail validation, but do not mark yourself as malicious
Merge after #5484
Description
Closes #5363
The handler is now aware which NodeIDs are managed by itself and is lenient when encountering issues of its own ATXs. This means it will fail their validation (thereby not publishing them) but not create a malfeasance proof against itself.
Test Plan

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


did you open source for all code?

i found estimator is just a binary executable file, does this open sourced?

All the code are released as opensource.
estimator  is automatically generated by python https://github.com/microsoft/qlib/blob/main/setup.py#L100
The source code is here

thanks.
This is a masterpiece!!!


Inherit Styles from the Body Element

Challenge Inherit Styles from the Body Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; rv:46.0) Gecko/20100101 Firefox/46.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

hello world

@abinayams1010 Please use the Help chat room for getting challenge related help. Happy Coding!

body { background-color: green; color: green; }
read carefully & slow
i had the same problem but i read it again
to figure out it's my mistake


Watermarks are opaque and not semi-transparent on FireFox 49.0.1

Link to PDF file (or attach file here):
tst-wmark.pdf
Configuration:

FF 49.0.1
Operating system and its version: OSX 10.9.5
PDF.js version: 1.6.219 on https://mozilla.github.io/pdf.js/web/viewer.html. I have seen the same opaque watermarks on 1.5.188 and 1.4.20.
Is an extension: No - can be seen on PDFjs viewer demo on github

Steps to reproduce the problem:

Use the attached PDF file and open it in FF 49.0.1 and you will see opaque watermarks.
Open the same file on FF 48.0.2 (or Chrome 53 or Safari 9.1.2 and you will see semi-transparent watermark as expected. Same semi-transparent watermark can be seen with Adobe Reader too.

No errors were reported by PDF.js however. So I assume something changed in FF 49.0 that causes this issue.

Closing as duplicate of issue #7674 (the upstream bug will be fixed in Firefox 50).


Fix typo

Hello,
In this pull request, I have corrected a few minor typos.
Remember to update the 'About' section!
The current text contains a few minor typos: mathemtical should be corrected to mathematical, Distinguisehed to Distinguished and interdicplinary to interdisciplinary.
Thank you for making this awesome list of theoretical computer science topics!
Best regards,
melody

Thanks!

Thanks!

I'm glad I could help!
Make sure to update the About section.
Best wishes for a wonderful day!


MWPW-160726

Resolves : MWPW-160726

Codecov Report
Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (e4e440a) to head (3432e4e).

Files with missing lines
Patch %
Lines

acrobat/blocks/verb-widget/verb-widget.js
18.18%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #869      +/-   ##
==========================================
- Coverage   84.75%   84.70%   -0.06%
==========================================
  Files          48       48
  Lines        6114     6120       +6
==========================================
+ Hits         5182     5184       +2
- Misses        932      936       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


syscall instruction results in endless error loop

When we hit a syscall instruction, we get an endless loop of errors. They are unhelpful, as they are "Unknown error" because, in my infinite wisdom, I never tested for the error number (See #12), but if we want to move away from the ruthlessly stolen idea from MORROS, where we have an api folder and we call that from an external program, then we are to implement a syscall. From my initial web exploration, it seems to function similarly to an interrupt, although I need to find more information on this topic. However, it should not result in an endless loop of errors since this shows it's not being executed properly.

closed in favor of #14


Removing the emoji bricks the app

https://github.com/T8RIN/ImageToolbox/assets/86906143/6de52eaa-17b6-4fad-8c77-2d86c0dc1716
The only solution is to wipe its data.
Reopening, killing the task, clearing cache and restarting device is useless

Intersting, i will check it 🐸

Fixed


Revert "chore: update some code"

Reverts alibaba/spring-ai-alibaba#1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


importing geosnap (KeyError: 'states'?)

I forked geosnap and install the develop version and everything went smooth, but when I try to import it, I get this:

Is there a way to fix this? Do I need to change something in the data.py?

Instead of a screenshot can you paste the traceback between 3 backtics?

Sure, sorry about that:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
~\AppData\Local\Continuum\anaconda3\lib\site-packages\quilt\nodes.py in __getattr__(self, name)
     97             try:
---> 98                 return self[name]
     99             except KeyError:

~\AppData\Local\Continuum\anaconda3\lib\site-packages\quilt\nodes.py in __getitem__(self, name)
    128     def __getitem__(self, name):
--> 129         return self._children[name]
    130

KeyError: 'states'

During handling of the above exception, another exception occurred:

AttributeError                            Traceback (most recent call last)
<ipython-input-1-ff6b1fcf64ae> in <module>()
----> 1 import geosnap

~\Desktop\geosnap\geosnap\__init__.py in <module>()
     30
     31 from . import analyze
---> 32 from . import data
     33 from . import util
     34 from .data import metros

~\Desktop\geosnap\geosnap\data\__init__.py in <module>()
----> 1 from .data import Community, metros, read_ltdb, read_ncdb, dictionary, db

~\Desktop\geosnap\geosnap\data\data.py in <module>()
     50 dictionary = pd.read_csv(os.path.join(_package_directory, "variables.csv"))
     51
---> 52 states = census.states()
     53 counties = census.counties()
     54 tracts = census.tracts_2010

~\AppData\Local\Continuum\anaconda3\lib\site-packages\quilt\nodes.py in __getattr__(self, name)
     98                 return self[name]
     99             except KeyError:
--> 100                 raise AttributeError
    101
    102     def __setattr__(self, name, value):

AttributeError:

I think this is the same as #69. The quilt package needs to be rebuilt on your machine

Cool, thank you! Indeed, after running this:
pip install --upgrade quilt
quilt install spatialucr/census

and overwriting whenever asked, I managed to import geosnap. Thanks!


explode() expects parameter 2 to be string, object given

Hi there, its a nice package I tried for my Laravel 5.6 project.
I has been working good at local machine but when I tried it live, it was giving this error upon clicking the Run All Checks button on UI page.
explode() expects parameter 2 to be string, object given {"exception":"[object] (ErrorException(code: 0): explode() expects parameter 2 to be string, object given at /home/user/public_html/vendor/sarfraznawaz2005/servermonitor/src/Senders/BaseSender.php:26)

Can you please tell what notification_channel you are using ?
Also what output do you get in dd call if you use following code in packages/sarfraznawaz2005/ServerMonitor/src/Senders/BaseSender.php:
    public function getClassName($namespace)
    {
        try {

            $path = explode('\\', $namespace);
        } catch (\Exception $e) {
            dd($namespace);
        }

        return array_pop($path);
    }


import.cypher - district nodes use CREATE rather than MERGE

Hello, after re-running the sync/parse/import process I noticed that Congressional district nodes are recreated on each import.  Looking at the import.cypher script, it looks like district nodes have a hard CREATE:
// Create District nodes
LOAD CSV WITH HEADERS
FROM 'https://github.com/legis-graph/legis-graph/blob/master/outputs/cb_2014_districts.csv?raw=true' AS line
CREATE (d:District)
SET d.state = line.state,
    d.district = line.district,
    d.wkt = line.polygon
WITH d,line
MATCH (l:Legislator) WHERE l.state = line.state AND l.district = line.district
MERGE (l)-[:REPRESENTS]->(d);

I'll see if I can figure out a MERGE but as I'm a total Cypher newb, I could use some guidance on optimal syntax here.

I've merged PR #10 into gregoryfoster/legis-graph master branch.


create an asset that combines all four orientations into one

then I can use one filter for all four and reduce work to one pass, also reduces amount of images to be loaded

works quite nicely


1 Click deposit of USDC using squidrouter/axelar.

Me and @lsaether have discussed creating a 1 click deposit solution in the app where the user can route tokens from eth chains like ethereum, polygon, kava etc onto moonbeam as USDC.wh then transfer the USDC.wh onto zeitgeist using XCM. All in "one click".
The first step uses the Squid Router SDK to route tokens from one of the supported chains onto moonbeam. This we have got working quite well.
But for the next step I need some assistance. Im not sure about the best way to do this XCM transaction from moonbeam to zeitgeist.

How do users that doesnt have any GLMR on moonbeam pay fees? Can we set up the XCM transaction so that the user can pay fees with some of the USDC.wh they just transfered?
Can we use the Call Permit Precompile and pay fees with a zeigeist owned account?

Acala also offers some options for bridging from Ethereum and you can pay fees with any asset from there

https://buildwithsygma.com/


List of things that need to be done

[ ] create a unit test
[ ] update the example project
[ ] more async methods and synchronous
[x] ToDo for me: Unscrewing what i recently did
[x] Nuget packaging figured out
[ ] DOCUMENTATION!!!!!!!!

Documentation would also be nice

I edited that in, thanks for reminding me, I started on that but it'll be difficult with how much there is to document

My first time contributing to an open source project so please forgive me if I break any etiquette.
I've run ReSharper to find issues in the solution and attached the results.  I'd like to contribute getting these issues resolved & any other issues that can be later found.
Code Issues in 'RedditSharp'.txt

all the enum stuff is fine, and since this is a DLL a lot of it's errors are going to be bad, also it asking for you to use "var" is not general coding style, it's complaining a lot about stuff that can't be changed, so most of those are non-issues, in fact, most of those issues are ignorable

Thanks.
I think, if acceptable, would be to create a pull for the namespaces.  Specifically, the DateTimeExtensions.
The lead at my office is pretty particular on certain things.  Variable declaration being one of those things he drives in to our skulls.  This is our reference: https://msdn.microsoft.com/en-us/library/ff926074.aspx
Thanks again.  :+1:

I generally perfer to avoid the var declaration to make clear what object is being passed around and why it's being passed around when it's declared, as not everyone uses visual studio or monodevelop

Tried committing my branch but keep getting 403s.  :(

Needs to be on your own fork, sorry, only a few have access to commit directly (I don't)

I got it!  Pull request submitted.
Thanks for your patience and assistance.


Content issue - "Show the local weather" challenge.

Earlier this year, google made the following statement:

"Chrome has public intent to deprecate powerful features like geolocation on non-secure origins, and we hope that others will follow.
Starting with Chrome 50, Chrome no longer supports obtaining the user’s location using the HTML5 Geolocation API from pages delivered by non-secure connections. This means that the page that’s making the Geolocation API call must be served from a secure context such as HTTPS."

Between google blocking it, and adblocking extensions (wildly used by many people) blocking geolocation calls from external services like freegeoip.net. Should this assignment be reassessed?
I personally will be skipping this task, but if we're asking others to create a piece for their portfolio which has the potential to not work on their potential employer's website, then should a replacement task be implemented?
P.S.
Apologies for not using the forum, I felt that this was a discussion that was more apt for the repo itself.

"Geolocation API removed from unsecured origins in Chrome 50"
Source: https://developers.google.com/web/updates/2016/04/geolocation-on-secure-contexts-only

We could replace this but there are many ways around this and this is actually a perfect opportunity to show students one of the many difficulties of designing apps for the web. That is we will get incompatibility issues. For example you could degrade gracefully by telling users whose browser does not support navigator.geolocation to enter a zip code and country instead.
In saying so, it is possible other browsers will adopt secure connections only for navigator.geolocation which will render this exercise broken in its current state so something must be changed.

navigator.geolocation was never useful because everytime we run app browser asks confirmation.   There are other ways around.  I used ip-api.com to get user's coordinates.  Here is my project :- http://mayankpratap.github.io/local-weather-app/

Just a little "bump" here to say that THE TEXT OF THIS PROJECT SHOULD BE ALTERED ASAP. As it stands, the syllabus first teaches you about navigator.geolocation, then drops you into this project with the comment, "We recommend using the Open Weather API." The student is left to bang their head over the problem before finding that the two can't work together, and it seems a bit silly to set them up for failure and then wait for them to find the answer here, or in the forum, or on Gitter (where everyone else gets tired of explaining it several hundred times per day).
Just to be clear, the problem is:

navigator.geolocation only works over https
openweather.org doesn't (for free)

Many suggest, and even the example pen shows, getting location by IP. I feel like this is not best practice, especially in a mobile-first age, because of these kinds of issues.
There is a solution that is functional and (comparitively) elegant.

Add https to your codepen URL. Make sure you share the URL that way, and maybe put an error alert in prompting the user to do so in case anybody gets hold of an http version
Use navigator.geolocation
Use Forecast.io. They work over https, they're free, and--best part--they have a matching set of gorgeous, animated icons!

As far as I know, this issue and its solutions have been known for over a month. Meanwhile, dozens of campers per day plow into it. I move that the wording of the page be changed IMMEDIATELY, at least to make people aware of the problem. I also move that a note be added to the geolocation checkpoint to mention that it won't work, in Chrome, without https.

I think the FCC folks are leaving "We recommend using the Open Weather API" in place just to give everyone completing this assignment a little taste of "real world challenges" :-).
I hit up against the same problem a few weeks ago and ended up just looking for another weather API that would give me HTTPS access for free.  I found wunderground.com as a result and it works fine.
That being said, I am left wondering why a simple change to the text on this challenge has been left untouched for so long.

FYI Forecast.io (or Dark Sky as they seem to be known now) doesn't appear to work anymore. They don't allow CORS, so I keep getting this error: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access.

I'll have an SSL proxy up before the end of the day for OpenWeatherMap. I'm happy to let others use this proxy and put it in the instructions for this challenge.

Use https://weather.millergeek.xyz/ instead of http://openweathermap.org/ Is just an SSL proxy

It's understandable that FCC wants people to experience the "this doesn't work, I wonder why" phenomenon about api interfaces.  But it is also important to get information that allows one to complete a task successfully and the wording of the challenge should be changed to say, "find a weather api" instead of suggesting using one that is known not to work.  I think that would provide a more positive experience.

@greaneym No one is arguing that the challenge shouldn't be updated.  That's why this Issue shows "Open" and "confirmed".  It's on the list of things that need to be fixed.

Hi, it was fixed on 24 August in commit fbf962f211d3a9227ada485c666d813f54c580af to the staging branch. Not sure why it has not made it to the live site though. I just checked the challenge page and it still is displaying the old text.

CodePen is going to be going ALL https in the coming month or so.
Which will be breaking this pen and exercise completely (https://www.freecodecamp.com/challenges/show-the-local-weather),  since open weather map has SSL as a paid feature http://openweathermap.org/price (for shame, really!)
Wondering if there's anything I can do to help out here.

I was able to get the city name from https://ipapi.co/json/, I used it inside pen and it is working!
curl https://ipapi.co/json/

Confirmed @tholman's comment.. the example codepen is broken. Obviously we can glean what needs to be done for the task but the example is unnecessary at this point, especially regarding the rule of not copying any code.


Snapshot removal from secondary storage with Ceph primary v4.15

ISSUE TYPE

Bug Report

COMPONENT NAME
Snapshot cleanup

CLOUDSTACK VERSION

4.15

CONFIGURATION
KVM with Ceph primary storage / NFS secondary storage
snapshot.backup.to.secondary set to true
OS / ENVIRONMENT
N/A
SUMMARY
The snapshot clean-up job does not try and remove snapshot from secondary storage, was working on version 4.13
STEPS TO REPRODUCE
Configure environment with Ceph Primary and standard NFS secondary storage.
Enable snapshot.backup.to.secondary.
Setup a scheduled volume snapshot. After flagged for deletion, many days after the snapshots still exist on the secondary storage.
I believe the issue also happens if a manual snapshot is taken and deleted.
EXPECTED RESULTS
Snapshot to be removed from secondary storage

ACTUAL RESULTS
Snapshot remains and is not removed.

ping @GabrielBrascher @wido, can you please have a look

Thanks for opening this issue @edward-stpierre. I reproduced the same issue and I plan to take a deeper look at it.

Thanks @GabrielBrascher are you planning to raise a PR?

Ping @GabrielBrascher - any update on this?

@rhtyd so far it still on the backlog. I hope to get some attention at this soon.

Alright @GabrielBrascher if you're unable to work on it, let's move to next milestone

@GabrielBrascher are you planning it for milestone 4.16 (accidentally added it)

Fixed by https://github.com/apache/cloudstack/pull/5130


Input and layer randomizations should be active only for learning function not for evaluation function

I think these randomizations (such as input_noise, input_dropout, hidden_dropout) are always active.
They should be disabled for evaluation functions since they are only needed for training.
This may be related to this issue mentioned here in the mailing list: https://groups.google.com/forum/#!topic/theanets/8dgkupBdugY

Thanks for filing this! It's an interesting issue.
On the one hand, dropout and noise shouldn't be active in a "production" model, since they will only hurt performance. On the other hand, if dropout and noise are removed from the loss for validation data, then the loss computed on validation data won't be comparable to the loss computed on training data. What about other regularizers that are currently active for both validation and training data (e.g. weight_l2)? Should those be disabled as well on the validation dataset?
Also, the technical task of implementing this could require a bit of an interface change. That's not so terrible, but it will require a bit of thought.

I am aware of some implementations that does remove the randomizations for the evaluation function in both validation and test time. I think this is most probably the right way to go. I think other regularizations should also be removed during validation and test time, since the cost function for training is irrelevant for testing. What matters is the performance which is measured by the appropriate part of the cost function, be it cross-entropy, least squares cost etc.
If random dropout is used to train the network, they usually multiply the activations of the nodes with p where p is the training dropout rate for that node. This is to match the mean value of that activation for training and test time (I think). For input dropout, no multiplication is needed since the mean of the inputs are assumed to be zero.

This actually turned out to be a bit easier than I'd thought! I will close this for now, please reopen if you notice anything is suspicious.


[Storage] Consistencies across samples - TS and JS

This is a followup PR to mainly update/add the JS samples based on the final version of Typescript samples from this PR https://github.com/Azure/azure-sdk-for-js/pull/4058.
(And some minor simplifications to TS samples)

Tested all the samples that are being updated. Everything works fine. ☀

Thanks for making all those updates, looks great!


Refresh token was not included in request data.

By default, if you're using JWT and Token Blacklist, the Logout view tries to find the Refresh token in the request body. However, if I am using HttpOnly cookie, my Refresh token wouldn't be in the request body.
It can be fixed by changing:
if 'rest_framework_simplejwt.token_blacklist' in settings.INSTALLED_APPS:
                # add refresh token to blacklist
                try:
                    token = RefreshToken(request.get['refresh'])

to
if 'rest_framework_simplejwt.token_blacklist' in settings.INSTALLED_APPS:
                # add refresh token to blacklist
                try:
                    token = RefreshToken(request.COOKIES['refresh_token'])

But it is quite cumbersome to define my own view for one line of change. Please consider making this change to the codebase.

Slightly related: #191 you can find some middleware via the code mentioned there that will do that. I agree that it should be added, though.

You should further be using the JWT_AUTH_REFRESH_COOKIE setting to decide which cookie to grab:
if 'rest_framework_simplejwt.token_blacklist' in settings.INSTALLED_APPS:
      # add refresh token to blacklist
      try:
          refresh_cookie = getattr(settings, 'JWT_AUTH_REFRESH_COOKIE', 'refresh_token')
          token = RefreshToken(request.COOKIES[refresh_cookie])

Could you please write where I should put this code?pleaaaas=)


Parameters count for the optimized network

Thank you for your excellent work! After optimizing the network to tensorrt, how can we obtain the number of parameters in the network?

I don't know whether there's an API call in TensorRT library for checking that.  Maybe you could raise the question on NVIDIA Developer Forum instead.

@jkjung-avt thank you! I have raised the question on the NVIDIA Developer Forum. From your experience, do you think it is possible? I have not seen existing questions related to it.

From your experience, do you think it is possible?

Certainly.  For example, when you call TensorRT library to load an engine to do inference, it needs to deserialize the model and load all parameters to GPU memory.  I think it a matter of whether NVIDIA has made such an API public.

Thank you! Would it be possible for you to look into such an API? I looked for the API over here but do not quite understand if there is some function available or not. I also tried to check all methods for the trt_yolo object on which we call detect method, but none of them seems to be able to count parameters.
If such an API is not available, could you suggest some ways to manually count the number of parameters in Python?

If you don't find anything in TensorRT API, just try to get an answer from NVIDIA Developer Forum.  I don't have any better answer...


Some additions to reduce the dataload

Thanks! Going to merge it.

New NuGet package with these changes is now online as version Q42.HueApi <IP_ADDRESS>


Improve error handling in EspHttpConnection::read (Issue #235)

See issue for further information.
https://github.com/esp-rs/esp-idf-svc/issues/235#issuecomment-1463590779

I added conditional compilation to the workaround


performance problem: logger.*(lambda) are not inlined

Problem
The logger.info/debug/error/etc. calls that take a lambda should be inlined.
Otherwise we replace the creation of one object (e.g. a StringBuilder) with the creation of another object (the lambda instance), which in time will put unnecessary pressure on the garbage collector.
Decompile a class that has logger.*(lambda) calls to see the problem. The procyon decompiler works ok for this case, though sometimes it chokes on Kotlin compiled bytecode.
I wanted to fix this myself and create a pull request, but these calls are inside an interface (KLogger) and functions inside interfaces cannot be inlined. This probably means that fixing this issue will result in breaking the existing API. Since it's your call if you want to break the backwards compatibility (and in what way), I didn't do it.
Idea for solution
Here is an idea for the solution:
import org.slf4j.Logger
import org.slf4j.LoggerFactory

fun main(args: Array<String>) {
    App().sayHi("World")
}

class App {

    companion object {
        private val logger = KInlineLogger.create()
    }

    fun sayHi(name: String) {
        logger.info { "Hello $name!" }
    }
}

class KInlineLogger private constructor(val wrappedLogger: Logger): Logger by wrappedLogger  {

    companion object {
        private val kInlineLoggerFqn = KInlineLogger::class.java.name

        fun create(): KInlineLogger {
            return KInlineLogger(
                    LoggerFactory.getLogger(
                            findLoggerName()
                    )
            )
        }

        private fun findLoggerName(): String {
            val exception = Exception()

            return exception.stackTrace
                    .map { it.className }
                    .filter { it != kInlineLoggerFqn }       // exclude self
                    .filter { !it.endsWith("\$Companion") }  // exclude self companion & any other companions (if the KInlineLogger is declared inside a companion object)
                    .first()
        }
    }

    inline fun info(messageBlock: () -> Any) {
        if (wrappedLogger.isInfoEnabled) {
            wrappedLogger.info(messageBlock.invoke().toString())
        }
    }

}

The App.sayHi method compiles to:
public final void sayHi(@NotNull final String name) {
    Intrinsics.checkParameterIsNotNull((Object)name, "name");
    final KInlineLogger this_$iv = App.Companion.getLogger();
    if (this_$iv.getWrappedLogger().isInfoEnabled()) {
        this_$iv.getWrappedLogger().info(("Hello " + name + "!").toString());
    }
}

Which is how we would optimize it manually.
Without inlining the info method though, a lambda instance is created (to capture the name):
public final void sayHi(@NotNull final String name) {
    Intrinsics.checkParameterIsNotNull((Object)name, "name");
    App.Companion.getLogger().info((Function0<?>)new App$sayHi.App$sayHi$1(name));
}

Notice how the lambda is instantiated, creating an unnecessary object, that the garbage collector has to clean.
A new object will be created for each log statement that needs to capture some variables.
In addition to this the call to the constructor and the dispatch to lambda.invoke is not free. It probably takes very little time, but it's unnecessary.

Thanks for your report. It was like that before, the main problem is with LocationAwareLogger - inlined methods cause it to show incorrect line numbers on the log messages. I hope in the future labmda expresssion will be optimized to create such overhead. let me know what you think about that.

If anyone is interested, I combined code from this and Anko to make a really trimmed down logger that:

Drops location-aware support and inlines everything
Drops the slf4j dependency and just uses android.util.Log
Adds an optional enabled: Boolean param to the Logger class (the one that your companion object will extend) to disable/enable logging on a class-by-class basis. If omitted it'll just default to whatever's defined in the logging file.
Destroys several of the nice abstractions and crams everything into one file, because I'm a terrible person.
Drops the tests because I'm lazy. Planning to re-add at some point.

Currently living here, might split it out into a separate lib at some point.


feat(bin): add --migrate flag

Resolves #75

Codecov Report
Base: 60.12% // Head: 60.12% // No change to project coverage :thumbsup:

Coverage data is based on head (da1a606) compared to base (e4072c4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   60.12%   60.12%
=======================================
  Files          50       50
  Lines        6819     6819
  Branches       53       53
=======================================
  Hits         4100     4100
  Misses       2679     2679
  Partials       40       40

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add sticky nav header to scroll to specific sections

Since we're using a long SPA, it would be nice if there were an easier way to navigate to a specific section. One possible solution is to use a sticky navbar, which allows for one-click scrolling to the section of interest.

@mhseiden what is SPA? Sticky navbar in the app sounds fine.

Ah, SPA == Single Page App.

The current navbar doesn't have the sections in it. Would we replace it? or have a second sub-navbar?


Map UDP source addr to Kubernetes pod

What does this PR do?
Map UDP source addr to Kubernetes pod entity ID, with the intent of having dogstatsd automatically enrich tags without requiring explicit entity ID tagging.
Motivation
Gain enriched tags without requiring all clients to use supported statsd client libraries and flags.

(closing an old, draft PR -- please re-open if this is still in progress)


Babel plugin fails if the component is a property

Codesandbox to replicate the issue
Given a file exporting two components
export default {CompA, CompB}

If referencing the component directly it'll all work as expected
import {CompA} from "./components";

const App = () => <CompA css={{background:"yellow"}}/>

But if referencing the component by property
import Comps from "./components";

const App = () => <Comps.CompA css={{background:"yellow"}}/>

You'll get the error Comps not defined.

I have the same issue.
Does somebody have any info about this issue?


Support for call and call with param

Dear Authors,
I need support for call and callwithparams, can you please let me know when this is planned.  Also what is the blocker on this, want to understand why the support was not added?
Regards,
Pratik Parikh

Wrong repository this needed to be open in vertx-mysql-postgresql-client


API errors handling changes

Remove models package
Use AbortWithJSON
Small cleanup as well

config.yml update needed to configmock.yml too (I think that causes failed test)

@maxUo


Interactive transactions

Hi, thanks for the awesome tool !
I use interactive transactions, which are not supported by prismock atm.
I currently use a dirty workaround :
Object.assign(await generatePrismock(), {
   $transaction(fn: any) {
      return fn(undefined);
   },
});

Do you think you could add this natively in prismock ? It would be great.
Thanks !

Added in v1.8.0


test: harden sample tests a bit

Fixes #426
Fixes #427
I suspect there are some return promise vs async shenanigans afoot here.

@JustinBeckwith it's so hard to delete your cuddly-named branches 🐨


Flutter UI freezes with webview_flutter and progressindicator on iOS

Details
On running the following apps with iOS release build, the screen gets stuck frequently during scrolling WebView or transitioning the Widget contains WebView by MaterialRoute. Also, as shown in the attached screenshot below, GPU usage makes peaks during the screen freezing.
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() => runApp(MaterialApp(
    showPerformanceOverlay: true,
    home: Scaffold(
      body: Stack(children: <Widget>[
        WebView(initialUrl: "https://flutter.dev"),
        Center(child: CircularProgressIndicator()),
      ]),
    )));

Test environment

iPod touch with system iOS 10.3.1
iPhone 8 with system iOS 12.3.1

Logs
nothing.
flutter doctor -v
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel unknown, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F132, locale ja-JP)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Community Edition (version 2019.1.3)
[✓] VS Code (version 1.35.1)
[✓] Connected device (1 available)

Tested and confirmed on iOS 12+ XS and XR.

same on iOS 12 with iPhone XS, iPhone 6+, iPad mini, iPhone XR.
does someone have workaround to solve this problem?

Hi @YukiOya , I tried to replicate this issue on iOS simulator (13.3) with latest Flutter dev channel (1.20.0-0.0.pre) and latest version of webview_flutter, but didn't see any freeze in UI. I was able to scroll down and up properly and screen was rendered as expected.
35244.mov.zip
I tested this on release mode.

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.2 19C57, locale en-US)
    • Flutter version 1.20.0-0.0.pre at /Users/deeptibelsare/Documents/Fluttersdk/flutter
    • Framework revision d9653445f4 (8 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/deeptibelsare/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/deeptibelsare/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/deeptibelsare/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.9.3

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

code sample
return MaterialApp(
      showPerformanceOverlay: true,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
        home: Scaffold(
          body: Stack(children: <Widget>[
            WebView(initialUrl: "https://flutter.dev"),
            Center(child: CircularProgressIndicator()),
          ]),
        ));

Can you please confirm if you still see this issue on latest Flutter and webview_flutter plugin ?

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


attributes in AccessiblePeer should all use setAttributeToElement

From #893 @zepumph pointed out that it would be better if all attributes used the function that was made for this for consistency.

Took a look at this and I am now questioning the decision. There are three places outside of setATtributeToElement that set an attribute. Two were straight forward, but the third is in AccessiblePeer.setVisible
        for ( var i = 0; i < this.topLevelElements.length; i++ ) {
          var element = this.topLevelElements[ i ];
          if ( visible ) {
            element.removeAttribute( 'hidden' );
          }
          else {
            element.setAttribute( 'hidden', '' );
          }
        }

It is nice to be able to apply hidden to attributes in a loop without having to go through the "name" of the element like AccessiblePeer.CONTAINER_PARENT.

On the other hand, this is exactly where we would want to use the asProperty option so we don't have to do element.setAttribute( 'hidden', '' );

Done in the above commits. For setVisible I added an element option to setAttributeToElement to set the attribute directly to the desired element rather than looking up by name.
I considered replacing this entirely with the elementName option, but that would have required using getElementByName at every usage of setElementToAttribute so I decided against it.
Local tests are passing, closing this issue.


Revert "BP-761: Validation exception when sort by or sort direction are empty in the request."

Should we revert enigmatry/entry-building-blocks#57?
Issue
Non-nullable reference fields are marked as Required by default.
Issue was suppressed on projects by setting the SuppressImplicitRequiredAttributeForNonNullableReferenceTypes = true
This suppress was not added to Blueprint template.
Request:
/Users?PageNumber=1&PageSize=20&SortBy=emailAddress&SortDirection=
[PublicAPI]
public class Request : PagedRequest<Response.Item>
{
    public string? Name { get; set; }
}

Error:
{
    "title": "One or more validation errors occurred.",
    "status": 400,
    "traceId": "00-22b69d3187027b178a5caff39b13172c-87bf17a84c5c6f2b-00",
    "errors": {
        "SortDirection": [
            "The SortDirection field is required."
        ]
    }
}

Exception occurs when query params in HTTP request contains empty/missing value sortBy/sortDirection.
Option 1: Make SortBy and SortDirection nullable fields.
Introduced by: enigmatry/entry-building-blocks#57
Potential breaking changes?
After packages are updated in a project, if SortBy or SortDirection are used directly in code e.g. var isPriceWithVatSort = request.SortBy.Equals("unitPriceWithVat") -> this would lead to compile time warning CS8602	Dereference of a possibly null reference
Option 2: SuppressImplicitRequiredAttributeForNonNullableReferenceTypes = true
Testing behavior of model validation and model binding on a example:
[PublicAPI]
public class Request : PagedRequest<Response.Item>
{
   // public string Name { get; set; } = String.Empty;
    public string? Name { get; set; } = String.Empty;
    public string? Email { get; set; } = String.Empty;
}

False (default): Non-nullable reference fields are marked as Required by default.
For request /Users?Name=&PageNumber=1&PageSize=20
public string Name { get; set; } = String.Empty;  => Validation error 400: Name is required
public string? Name { get; set; }  => OK: Model binding will set Name = null
public string? Name { get; set; } = String.Empty; => OK: Model binding will set Name = null (!?)
public string? Email { get; set; } = String.Empty; => OK: Model binding will set Email = "";
True: This required behavior is suppressed
For request /Users?Name=&PageNumber=1&PageSize=20
public string Name { get; set; } = String.Empty;  => OK: Model binding will set Name = null (!!? seems hazardous)
public string? Name { get; set; }  => OK: Model binding will set Name = null
public string? Name { get; set; } = String.Empty; => OK: Model binding will set Name = null (!?)
public string? Email { get; set; } = String.Empty; => OK: Model binding will set Email = "";

Should we revert #57?
Issue
Non-nullable reference fields are marked as Required by default.
Issue was suppressed on projects by setting the SuppressImplicitRequiredAttributeForNonNullableReferenceTypes = true
This suppress was not added to Blueprint template.
Request:
/Users?PageNumber=1&PageSize=20&SortBy=emailAddress&SortDirection=
[PublicAPI]
public class Request : PagedRequest<Response.Item>
{
    public string? Name { get; set; }
}

Error:
{
    "title": "One or more validation errors occurred.",
    "status": 400,
    "traceId": "00-22b69d3187027b178a5caff39b13172c-87bf17a84c5c6f2b-00",
    "errors": {
        "SortDirection": [
            "The SortDirection field is required."
        ]
    }
}

Exception occurs when query params in HTTP request contains empty/missing value sortBy/sortDirection.
Option 1: Make SortBy and SortDirection nullable fields.
Introduced by: #57
Potential breaking changes?
After packages are updated in a project, if SortBy or SortDirection are used directly in code e.g. var isPriceWithVatSort = request.SortBy.Equals("unitPriceWithVat") -> this would lead to compile time warning CS8602 Dereference of a possibly null reference
Option 2: SuppressImplicitRequiredAttributeForNonNullableReferenceTypes = true
Testing behavior of model validation and model binding on a example:
[PublicAPI]
public class Request : PagedRequest<Response.Item>
{
   // public string Name { get; set; } = String.Empty;
    public string? Name { get; set; } = String.Empty;
    public string? Email { get; set; } = String.Empty;
}

False (default): Non-nullable reference fields are marked as Required by default.
For request /Users?Name=&PageNumber=1&PageSize=20
public string Name { get; set; } = String.Empty; => Validation error 400: Name is required public string? Name { get; set; }  => OK: Model binding will set Name = null public string? Name { get; set; } = String.Empty; => OK: Model binding will set Name = null (!?) public string? Email { get; set; } = String.Empty; => OK: Model binding will set Email = "";
True: This required behavior is suppressed
For request /Users?Name=&PageNumber=1&PageSize=20
public string Name { get; set; } = String.Empty; => OK: Model binding will set Name = null (!!? seems hazardous) public string? Name { get; set; }  => OK: Model binding will set Name = null public string? Name { get; set; } = String.Empty; => OK: Model binding will set Name = null (!?) public string? Email { get; set; } = String.Empty; => OK: Model binding will set Email = "";

In my view this is not a breaking change and it should not be reverted.
Paging request can come without SortBy and SortDirection and model binding would set these fields to null?
We just made it visible now, i.e. that these fields can be null.


Make environmental limits increase more

Currently environmental limits are still broken in about an hour even around level 10.
Let’s shoot for 30 minutes at level one with a 10 stat, and 12 hours at level 60 with a 20 stat. It should fluctuate by about 10 minutes either way at level 1 based on the stat (5-18) and by maybe 2 hours around level 60.
Also add any new coefficients to the "game-config" collection in firebase.

Created (way) more advanced limit algorithm. Like, using at least 9th grade math.
Also added to game-config collection in firebase


Provide a tutorial on how to revert to default Firefox

Hello!
I am excited to try ArcFox, but I am weary to try it in its current state in case I do not like it/of bugs. I would greatly appreciate a tutorial on how to reset Firefox to its settings prior to undergoing to ArcFox treatment.
Thanks!

Nice idea!! gonna do it asap. meanwhile you can basically do the process backwards. just remove userchrome.css and than remove the extension. that's it :)

@wannafedora TYSM!!

@LuanderFarias Hi. I was the “ghost” in this issue. I see that my pull request was added to the documentation! Thanks!


search no longer working > 26.1

Hi,
When we upgrade from 26.1 to any of the later versions, our search never returns any results (continually swirls and never errors).
I presume this is to do with the versioned search, which is something we definitely would like, but the straight upgrade seems to break our search.  We use docs only and have 3 areas similar to those below:
  require.resolve("@easyops-cn/docusaurus-search-local"),
  {
    hashed: true,
    docsRouteBasePath: ["docs1","docs2","docs3"],
    docsDir: ["docs1","docs2","docs3"],

To enable versioning or is there a breaking change?  I can't see anything in the documentation about why upgrading beyond 26.1 would cause the issue.

Are you using versioned docs at the same time besides using multiple docs dir?

It will help more if you can share your relevant config options of  @docusaurus/plugin-content-docs, or docs in @docusaurus/preset-classic.

yes, using versioned docs for two of our docs folders and one isn't.  Hopefully, the below helps:
plugins: [     [       '@docusaurus/plugin-content-docs',       {         id: 'main',         path: 'main',         routeBasePath: 'main',         sidebarPath: require.resolve('./sidebars.js'),         includeCurrentVersion: true,         editUrl: 'https://github.com/blah/',         versions: {           '2.8': {             banner: 'none',             path: '2.8',           },           '2.9': {             banner: 'none',             path: '2.9',           },         }       },     ],     [       '@docusaurus/plugin-content-docs',       {         id: 'secondary',         path: 'secondary',         routeBasePath: 'secondary',         sidebarPath: require.resolve('./sidebars.js'),         includeCurrentVersion: true,         editUrl: 'https://github.com/blah2/',         versions: {           '7.3': {             banner: 'none',             path: '7.3',           },           '7.4': {             banner: 'none',             path: '7.4'           }         }       },     ],     [       '@docusaurus/plugin-content-docs',       {         id: 'support',         path: 'support',         routeBasePath: 'support',         sidebarPath: require.resolve('./sidebars.js')       },     ],     [       require.resolve("@easyops-cn/docusaurus-search-local"),       {         hashed: true,         docsRouteBasePath: ["main","secondary","support"],         docsDir: ["main","secondary","support"],       },

This may be related #211

Ah ok thanks, looks similar.

I think this is also fixed by #228


device-manager: Drop workarounds

What this PR does / why we need it:
Drop some workarounds that should no longer be necessary.
Release note:
NONE

/retest

/retest-required

/retest

/approve


Hello World in JAVA

Hi, thanks for the effort but a program in java has already been accepted. You can try out any new language which you don't know much about!


Setting validation result in ValidateData() to FIXED breaks validationResults.IsValid

I'm using the functionality documented here to mark fields as fixed when validated together. Later on I wanted to use validationResults.IsValid in my validation logic, but this is not working as I expected as it gives me false when there are two fixed fields and otherwise everything is valid.
What needs to be solved?
validationResults.IsValid should give me true when everything is valid and *FIXED*

How do you want it solved?
An extension method AddModelFix on validationResults that makes sure ModelValidationState is set to Valid maybe? This would also need ValidationAppSI  to not filter away Valid results.
Alternative solutions
My current workaround to detect if form is valid or not
            if (validationResults
                .Any(a => a.Value.ValidationState == ModelValidationState.Invalid &&
                            !a.Value.Errors.All(a => a.ErrorMessage.StartsWith("*FIXED*"))))
                return; // the form is invalid

It might be wise to hold off on this one. The solution around *FIXED* seems sub-optimal, and we might want to find a better (read: automatic) solution for this problem in the future. App-frontend should track where each validation message came from, and remove validation messages if subsequent requests for the same validation does not produce the same error. Alternatively, we should allow triggers for validations on multiple fields to run at once.

This has been fixed with new validation interfaces and the validatitonSource concept that replaces *FIXED*


Create reverse_words_in_string.cpp

Added solution of famous leetcode problem no. 557 (Reverse words in String)Added solution of famous leetcode problem no. 597 (Reverse words in String)

Good job man.


useProxy macro failing with vite

Using:

vite
vite-plugin-babel-macros

Source:
import { useProxy } from "valtio/macro"
import { state } from "../state"

const Navigation = () => {
  // const snap = useSnapshot(state)
  useProxy(state)

Error:
1:53:23 PM [vite] Internal server error: (project)/web/site/components/Navigation.tsx: valtio/macro: Cannot read property '0' of undefined Learn more: https://www.npmjs.com/package/valtio
  Plugin: babel-macros
  File: (project)/web/site/components/Navigation.tsx
      at NodePath._getKey ((project)/node_modules/@babel/traverse/lib/path/family.js:296:25)
      at NodePath.get ((project)/node_modules/@babel/traverse/lib/path/family.js:288:17)
      at NodePath._getPattern ((project)/node_modules/@babel/traverse/lib/path/family.js:328:21)
      at NodePath.get ((project)/node_modules/@babel/traverse/lib/path/family.js:290:17)
      at (project)/node_modules/valtio/macro.js:37:114
      at Array.forEach (<anonymous>)
      at macro ((project)/node_modules/valtio/macro.js:33:88)
      at macroWrapper ((project)/node_modules/babel-plugin-macros/dist/index.js:57:12)
      at applyMacros ((project)/node_modules/babel-plugin-macros/dist/index.js:226:14)
      at ImportDeclaration ((project)/node_modules/babel-plugin-macros/dist/index.js:110:28)

Thanks for reporting. I never used vite other than quick start, but probably, there are some incompatibilities that we could fix on our end.
@Aslemammad Would you be interested in looking into this?

Wait, are we sure if this is vite only issue? @naturalethic Can you try to reproduce the issue with codesandbox?

Works fine here https://codesandbox.io/s/eloquent-herschel-ig44g

thanks. so, it's vite only issue.
you could use vite on codesandbox container, but you can just share the repro in github or something.

I did not mention I'm using Typescript, which may be the issue, rather than vite.

To sum up, the current useProxy macro is only for babel.
If I get it right, to support esbuild, it will be a completely new feature.

To sum up, the current useProxy macro is only for babel.
If I get it right, to support esbuild, it will be a completely new feature.

@dai-shi I can work on this, what are the plans/instructions?

@Aslemammad I guess you would first need to learn typed-macro (or find some alternatives).


sslh: invalid configuration options

Describe the bug
The nixos configuration under services.sslh always produces invalid configuration files. The
Steps To Reproduce
Steps to reproduce the behavior:

add services.sslh.enable = true to your configuration.nix
activate the system

Expected behavior
sslh runs with no error.
Actual behavior
sslh warns that the options "verbose" and "timeout" are unknown.
Additional context
The options "verbose" and "timeout" should be of type int but are defined as bool and string. When executed, sslh ignores the invalid options
Notify maintainers
@nagy @pennae @SuperSandro2000 @symphorien
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.23, NixOS, 23.05 (Stoat), 23.05.20230408.d9f759f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - nixpkgs: `/nix/store/qyyw6dd6lqlhz3cqap31d071cbyh34bf-source`

Please test https://github.com/NixOS/nixpkgs/pull/225602


WIP Add support for julia Project.toml files

Fixes #486.
Very WIP right now.
@NHDaly would be great if you could take a look at this. I did this without a local system to try anything out, i.e. I don't have a docker setup or anything like that. So taking this further is kind of involved for me... But maybe we can jointly somehow bring this over the finishing line?

I managed to get everything running locally on my Mac, so I can actually debug things now. I'll ping folks again once I have a working version for a review.

@KristofferC, quick question: I want to add the ability here to decide what julia version to use, based on the content of the Project.toml. When I look at the docs it seems to me that it would be good enough to look for a julia entry in the [compat] section and just decide based on that. Is that correct, or should I look at something more sophisticated? In particular, I'm slightly confused whether I first need to somehow resolve the julia name in some dependency section before I can look at the [compat] section? Or can I just ignore the entire rest of the .toml file? Thanks!
I guess if at some point Manifest.toml also supports pinning a julia version, then we would have to extend the logic to also look in there, but for now we can ignore that, right?

When I look at the docs it seems to me that it would be good enough to look for a julia entry in the [compat] section and just decide based on that

Yes, that should be enough. However, the compatibility is given in "semver format" (https://julialang.github.io/Pkg.jl/v1/compatibility/#Version-specifier-format-1) so you need to translate that to actual versions. The way Pkg does this is via:
julia> Pkg.Types.semver_spec("1.0")
VersionSpec("1.0.0-1")

and from there you are unfortunately hitting internals of the package manager. We should extract all the semver stuff into its own module and document it.

I guess if at some point Manifest.toml also supports pinning a julia version, then we would have to extend the logic to also look in there, but for now we can ignore that, right?

Yes, Manifest does not record julia version right now so

@KristofferC, cool thanks! We won't be able to use any julia code for handling of these semver format strings, unfortunately, since we need to process them to figure out which julia version to install, which also implies that no julia version is around at that point. So we'll have to handle that in Python.
There is a toml parser for Python, but now I'm wondering whether there might also be a python semver package that could help us with this. The format julia is using there is not julia specific, or is it?

I have one question about overall design, that I think is mostly for the core maintainers of this repo here: the JuliaBuildPack now has a lot of if statements that handle the pre-julia 1.0 case and the post julia 1.0 case. Overall this makes the code kind of messy. An alternative would be to split these out into two different classes: have one LegacyJuliaBuildPack for julia pre 1.0 and one JuliaBuildPack for everything ever since.
I'm starting to think that that would make more sense: the code would be cleaner, we could leave the legacy version alone and it would just continue to work while we add features to the version that works with the non-prerelease versions of julia. I think this last point is important: if we mix these two cases into one class, then whenever someone is adding features, they need to make sure that it works with a julia version that is potentially no longer supported etc.
@betatim, any thoughts?

@betatim, oh, and one more question: right now the get_build_scripts function downloads and installs julia. Which version of julia gets installed depends on the content of the REQUIRE/Project.toml file in the repo. Should that code then live in get_build_scripts, or should it actually be in get_assemble_scripts?

Short answer on just one question:

An alternative would be to split these out into two different classes: have one LegacyJuliaBuildPack for julia pre 1.0 and one JuliaBuildPack for everything ever since.

I think I like the idea. We'd have to be a bit careful to make sure they don't both trigger and how to organise the inheritance tree. My quick fire thought is to make a Julia1point0 and a EarlyJulia class that each deal with the specifics. Then use these two from within JuliaBuildPack which remains the only one inside the inheritance structure of build packs. More like composition than inheritance maybe.
More out loud thought: detect() would decide which actual Julia class to use, instantiate it and store it in self._actual. Other methods then become proxies/forwarders:
def detect(self):
    if julia_one_detected:
        self._actual = Julia1point0()
    else:
        self._actual = EarlyJulia()

def foo(self, *args):
    return self._actual.foo(*args)

def blah(self, arg1):
    return self._actual.blah(arg1)

(Better names all around would be needed 😀)

I think https://github.com/jupyter/repo2docker/pull/595 at this point is clearly better, so I'm going to close this one here.


forwardRef to NavigationItem

PR includes

[x] Bug Fix

Related issues

Resolve #1139

/canary

/canary

/canary


[util] Re-add TRAHA Global config

Although not likely, it is possible the game could come back (either officially or through private servers)
If we maintain an archive of all old and dead games, then they can be brought back to life with DXVK taking care of compatibility. Especially old games can benefit from DXVK even on Windows (we use it by default in Deus Ex Randomizer).
If the game is brought back through unofficial means, it could become legally difficult to explain why we added back their config code for an unofficial release. But if we decide to be an archive and keep these configs forever, then there's no legal concern because we're just acting as an archive/historical reserve.
discussion here https://github.com/doitsujin/dxvk/commit/855b2746b61ad944759ae9e31bbb4ad7562e6912#commitcomment-140395860

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

well if it was revived in the future it might not have anticheat anymore (officially if they don't want to pay for the licensing? or unofficially obviously a private server could exclude it)

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

Why was it present as a per-game config then?

Because it could run with dxvk on Linux.

Exactly.
It could stll run, the game technically still exists and as I said, there are other means to make it work.
It a few lines of text, what's the downsides of keeping something possibly useful?

I don't really see a point to do this based on a what-if scenario. If the game ever gets revived in one way or another we can talk about it, but for the time being it's deadweight that we literally cannot test.


Add audit log messages on document delete

Signed-off-by: Nikolay Maslarski<EMAIL_ADDRESS>

Coverage increased (+0.04%) to 93.123% when pulling 24211c2ea477dba35e8b5e2900517a9a43673e41 on nmaslarski:master into 6fbec05b1d22761114b56904c7c7d17c7186a256 on cloudfoundry-incubator:master.


Add low-level debugging hints

I've had some issues where the Pixel Kit was misbehaving, i.e. spontaneously rebooting or ending up at the red "network error" screen, and it's really hard to tell what's going on in such a case.
I've since found out that there's text console output available through the USB serial connection, and I've used TeraTerm successfully to access that. (Serial connection at 115200 bps, 8 bits, no parity, 1 stop bit.) Would it make sense to document this as a hint for technically inclined users? It could help with making more informative bug reports when things go wrong.

Hey, @klausw !
This is an awesome point! I am actually writing a troubleshooting/FAQ mostly targeting educators, facilitators and technically inclined people and your suggestion goes straight to the top of the list.
I'll post the link here once is published!


subwoofer not working

acidanthera/AppleALC did it but has headphone noises. Can you bring it to voodoHda?
https://github.com/acidanthera/AppleALC/commit/d6a71e3a70aaf9331d25aaa2756dee77e38aa331

Talk to the Devs
https://www.insanelymac.com/forum/topic/314406-voodoohda-295/


Implement one-shot MAC and cipher

Description
Implement one-shot hash, MAC and cipher APIs introduced in PSA Crypto API 1.0 beta1 (ARMmbed/mbed-crypto#17).
Resolves #3258
Additional comments
Any additional information that could be of interest
Todos

[x] Tests
[ ] Changelog updated

The same tests are modified with #3386 and needs to rebase this PR after it is merged.

Rebased and updated the cipher tests to use output buffer size macros introduced in #3386.

The MAC functions are separated into #4316

Forward-port in #4739

The forward-port has been approved.


Alternative product formats

The alternative product formats support the following:

Use default values defined on case-classes when fields are missing from json
Omit empty arrays and objects when serializing fields with default values
Allow property renaming
Override formats per field
Allow advanced customizations

The formats can be obtained by using formatN instead of jsonFormatN
It supersedes my previous pull request #56

What is the status? Can this be merged?

I guess it can.
We'll merge it when we cut the next minor release, which will hopefully be soon.

Any time plan for this one? Would be great to have.

I would really, really like this functionality too. I have a lot of custom JsonFormat definitions that are 95% boilerplate, but with a small amount of special handling for a minority of properties.

What's the status on this PR? Would be very interested in having this. Anything I can do to help?

+1

I guess this one missed the 1.3.2 boat. :(

Could this be broken out into a tiny separate library, or does it need to live in the spray.json namespace? :)

There is a problem with the way this is implemented:
If the case class contains "additional fields" (i.e. some inner case class, a lazy val etc.), then the automatic field names don't work.
Normally that would mean using the "jsonFormat" method and specifying fields names manually but I can't find such a method for this alternative product format.
I've fixed it in our project by getting a TypeTag for P in ProductFormatImpl, getting the names of the constructor parameters from that tag and then filtering the declaredFields by name. This should eliminate one reason for the formatN-methods not working:
val tpe = ru.typeOf[P]
def termsOnly(s:ru.Symbol) = if(s.isTerm) Some(s.asTerm) else None

...

// list all case class constructor parameters
val constructor = tpe.members
   .filter(_.isMethod).map(_.asMethod).find(_.isConstructor).toSeq
val constructorParams = constructor
   .flatMap(_.paramss.head).flatMap(termsOnly)

// Filter declared fields based on constructor param names
val fields = runtimeClass.getDeclaredFields
   .filter(field => constructorParams.exists(_.name.toString == field.getName))

There's probably a nice way of doing even more of the work with just the TypeTag, but this works for me for now.

Nice improvement, +1 for getting this merged.

+1 for sane optional values

+1, would be really helpfull

+1

Any idea if this is still on the table? It's open for more than 2 years now.

+1, this would be helpful

+1, when this will be merged?

Hi there, I recently gained rights to maintain this repository and release etc from @sirthias.
Will try to get on top of issues and PRs soon. This one was waiting a long time, but hope we can get it in perhaps now :)

+1 for merging this in...

+1 for merging

please release this 👍

@ktoso I see you started merging in some of the newer PRs. That's great news! Do you have any idea when you will be able to look at this one?

No updates on this?

any progress on this ?

Can this get merged?

+1

Please do merge!

+1

Please merge!

+1

+1

I'm in need of the feature and I just went through all the history (from 2013) and now I'm arrive at the end of this one and I feel like hanging at the end of one of game of throne book!
So @jrudolph  you asked @rditerwich and I can guess he said there are other priorities but maybe you can just let us know if there's any plan about this one?


Create TowerUser SSO role for Viewer plus AssumeRole

Given that the AWS sandbox account is being deprecated, we want to provide a Viewer role to Nextflow users so they can access a secret in Secrets Manager (for configuring Nextflow Tower) and an S3 bucket (for storing workflow output files). This role also provides the ability to assume other roles (sts:AssumeRole) such that it can assume the roles defined here, which grant access to specific resources.

We're sticking with Viewer for now.


Validation failing for ACLED Pakistan data

Returns a 502 gateway error: 502 validation link
Data itself is parseable: original data link

Simpler version also failing: https://beta.proxy.hxlstandard.org/data/validate?url=https%3A%2F%2Fdocs.google.com%2Fspreadsheets%2Fd%2F1NPkAr6ELyV0TC_vnXD63P0Rkk6tkTETeg-HnZLQZhdA%2Fedit%23gid%3D1371949984

@danmihaila @alexandru-m-g
Validating this dataset is timing out because of spell check. With nearly 42,000 rows, it's finding a lot of spelling outliers in the #group column, and taking a lot of time to try to find corrections.
I suggest that we make the spellcheck rule more restrictive, and apply it only to hashtags that we know are likely to have highly repetitive values, e.g. #sector, #subsector, #adm+name, #modality, #beneficiary, #org.

Deployed to beta. Beta Proxy test link is now working, and wiki page updated.

Confirmed working in beta by direct POST:
$ time curl -X POST --data-urlencode "url=https://data.humdata.org/hxlproxy/data.csv?url=https%3A%2F%2Fapi.acleddata.com%2Facled%2Fread.csv%3Flimit%3D0%26iso%3D586&name=ACLEDHXL&tagger-match-all=on&tagger-02-header=iso&tagger-02-tag=%23country%2Bcode&tagger-03-header=event_id_cnty&tagger-03-tag=%23event%2Bcode&tagger-05-header=event_date&tagger-05-tag=%23date%2Boccurred+&tagger-08-header=event_type&tagger-08-tag=%23event%2Btype&tagger-09-header=actor1&tagger-09-tag=%23group%2Bname%2Bfirst&tagger-10-header=assoc_actor_1&tagger-10-tag=%23group%2Bname%2Bfirst%2Bassoc&tagger-12-header=actor2&tagger-12-tag=%23group%2Bname%2Bsecond&tagger-13-header=assoc_actor_2&tagger-13-tag=%23group%2Bname%2Bsecond%2Bassoc&tagger-16-header=region&tagger-16-tag=%23region%2Bname&tagger-17-header=country&tagger-17-tag=%23country%2Bname&tagger-18-header=admin1&tagger-18-tag=%23adm1%2Bname&tagger-19-header=admin2&tagger-19-tag=%23adm2%2Bname&tagger-20-header=admin3&tagger-20-tag=%23adm3%2Bname&tagger-21-header=location&tagger-21-tag=%23loc%2Bname&tagger-22-header=latitude&tagger-22-tag=%23geo%2Blat&tagger-23-header=longitude&tagger-23-tag=%23geo%2Blon&tagger-25-header=source&tagger-25-tag=%23meta%2Bsource&tagger-27-header=notes&tagger-27-tag=%23description&tagger-28-header=fatalities&tagger-28-tag=%23affected%2Bkilled&header-row=1" https://beta.proxy.hxlstandard.org/actions/validate
{
    "validator": "libhxl-python",
    "timestamp": "2018-05-29T18:35:12.564633",
    "is_valid": true,
    "stats": {
        "info": 0,
        "warning": 0,
        "error": 0,
        "total": 0
    },
    "issues": []
}
real	0m41.674s
user	0m0.041s
sys	0m0.020s

I agree that we need to have better rules

Confirmed that it was actually a timeout issue upstream, in gunicorn. Fixed in #232


Fix ITAB_DUPLICATE_KEY when using hashed table

Closes #58

Nice fix, thanks !
Could you pls add a UT for it.

done


Travis tests are broken

The Travis tests are broken for a while. Need to check why.
@pascalgrimaud @ruddell if any of you guys have some spare time please help me with this

Updated node to see if it fixes the issues. But I guess build was broken even before the node version issue

@deepu105 : I can improve the Travis build here. Just assign it to me, and I will do that

@pascalgrimaud thanks a lot

I'm starting to have a look on this.
But in Travis, we have this message:
ERROR!  I support only JHipster versions greater than >=4.10...
            If you want to use Entity Audit with an older JHipster version, download a previous version that supports the required JHipster version.

Before going further, is this module compatible with JHipster 5 ?

I need to find time to make it compatible
On Wed, 18 Jul 2018, 8:43 pm Pascal Grimaud<EMAIL_ADDRESS>wrote:

I saw this ticket #86
https://github.com/hipster-labs/generator-jhipster-entity-audit/issues/86
So it's not compatible yet, that's why Travis failed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hipster-labs/generator-jhipster-entity-audit/issues/98#issuecomment-406034247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDlFwIVqGo_aDRSYH8t8T-brDH0lCofks5uH4HcgaJpZM4U-1_6
.


Splitting big calendar files into multiples files.

I've added Estonia by merging #134, you may have to solve this tiny conflict before I can merge your PR.

Rebased.


clean up repo links on homepage and README

Fixes #509.

Ping @pjz.

You got build.py changes in your link cleanup.

@pjz Yeah, that's because I was trying to view the changes locally before committing. make docserve is failing in the same way (#511) with or without the changes on this PR.


Browsers requests default browser setting on every launch

Describe the bug
I have the following setup on my machine:

System default browser is Finicky
There are about 20 URL patterns specified in the Finicky config that should always open in a specific browser
The default browser in Finicky is set to Browsers

The net impact here is that those 20 URLs always bypass Browsers and open in Chrome, and anything else I click will open Browsers and prompt me where to go.
The problem is that since the system default is set to Finicky, Browsers prompts me on every URL click to set it as the default.
Expected behavior
Once I've told Browsers not to set itself as default once, it should not continue to ask
System:

OS: macOS Ventura 13.4.1(c)

I see there's a rules section in the config.json file but it's not clear to me what that does or how I'd use it: does that functionality replace Finicky in my scenario? Could I build regex patterns that automatically direct certain URLs to certain browsers here? If so, I could probably streamline my setup and also work around this issue at the same time.

I will eventually plan to add a GUI for settings, but yep you found the settings file can do some things already.
There is some documentation at https://github.com/Browsers-software/browsers/pull/34
I didn't pick regex for the syntax, but kind of glob-like patterns. I would be interested to get some feedback if that covers the need for you or not.
The easiest way to find the profile id is from the cache file. Or if you re-order the browser, then the id is also visible in the config file.

I'll look into that! I could share a [sanitized] version of my finicky.js if you think that would help you as a more experienced reader say if the rules functionality replicates what I'm doing.
In the meantime, is there a way to block Browsers from continuing to prompt to be set as default? That also handles the issue perfectly.

OK, I took some time today and converted all my regular expression browser rules to your glob format. It worked great for my basic use cases, which is just intercepting a bunch of root and sub domains and directing them to my "work" browser config. I could see situations where the regular expressions would be more powerful if you wanted more fine-grained control over these patterns (e.g. "open this Google doc in Chrome and this one in Safari) but those are probably edge cases.
A quick proper doc for this would be super helpful, even though it's just JSON and pretty clear from your PR.  That PR comment is about 90% of the way to being product-ready doc IMO, though it has a few minor errors that stop it from being used directly (missing commas, comments disallowed, some more examples)
As a result I've changed my default browser to Browsers and pulled Finicky out of the mix entirely. I still think better control over the default browser prompt would be worth adding to Browsers but it is no longer a specific problem I have.
Now, we just need to figure out how to get the menu to exit more easily when it loses focus and this is a perfect solution!

Hmm. I definitely didn't intend it to request default on every launch. Thanks for reporting it.

Should be fixed in 0.4.1


Fixed typo

It is Userlist::Push.relationships instead of Userlist::Push.relationship

Thank you!


Why do we need to evaluate the actor_critic model twice?

I'm sorry if I'm missing something obvious.
What is the reason we have to evaluate the model twice, i.e. once when we call actor_critic.act(...)
(here) and a second time  when we call actor_critic.evaluate(...) (here).
(I so far have only looked at A2C)
I understand that the computation graph isn't saved in the current implementation from when we call act. But couldn't we just save values,action_log_probs and dist_entropy in a list of Variables when we call act?
Thanks for your help (and the implementation)!

See the beginning of the discussion here: https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/issues/15
tl;dr: It's just more efficient to do it this way on GPU since we can use batched computations for the backward pass.

Ah great, thanks for the fast reply and sorry I missed that!


Set up .eslintrc.json to provide consistent code styling

Move eslintConfig into .eslintrc.json to provide rules for consistent code styling. Add .eslintignore to prevent linting of node_modules and .vscode config folders.
Closes #6

Hi @cbeard87 , thanks for the PR. Since @Simply007 is enjoying summer somewhere far away, I kindly asked @Enngage for a review :)

Thanks @petrsvihlik! @Enngage I kept the default config pretty minimal, but tried to follow Vue CLI's stylistic conventions as closely as possible.

@Enngage When I ran the linter locally the majority of the files were affected, especially the Vue components. This indent config option was actually suggested by @Simply007 in the original issue. The intended goal was for Vue template blocks to default to 4 space indents, while preserving 2 space indents in the script blocks and throughout the rest of the codebase.
I'll get the rule for single quotations added in. I didn't add it initially because I wasn't sure what the preferred setting was just by looking through the files.
As for running the linter and pushing up the resulting fixes, I was actually thinking about automating it and running the linter in a git hook. That way, all pushes to the repo will come through with uniform formatting. Thoughts?

@cbeard87 & @Enngage, let's go ahead with those proposed changes and update the formatting of the files to pass linting as part of this PR.

Hi @cbeard87 , do you have enough information from us to proceed with the changes?

@petrsvihlik Yes! Apologies, I've been keeping pretty busy at the day job. I'll get those changes made this weekend and revise the PR.

@cbeard87 thanks, awesome! looking forward to it :)

@petrsvihlik & @Enngage I've revised the PR with the discussed updates. Please note that as linting is now set up to run as part of the precommit process, all of the .vue and .js files were autocorrected during this commit.

lgtm. thank you @cbeard87 !


viewNameToFilename generates invalid filename

When using FORESTDB_STORAGE my views aren't being created properly.
Replacing the "/" by ":" doesn't seem to work well when the application's storage is pointing to an SDCard.
Is ":" a valid character for filenames in fat32 cards?
Just for clarity I'm reproducing the function that generates the filename for a given view.
private static String viewNameToFileName(String viewName) throws CouchbaseLiteException {
        if(!viewName.startsWith(".") && viewName.indexOf(":") <= 0) {
            viewName = isWindows()?escapeViewNameWindows(viewName):viewName.replaceAll("/", ":");
            return viewName + "." + "viewindex";
        } else {
            throw new CouchbaseLiteException(495);
        }
    }

I'm using:
compile 'com.couchbase.lite:couchbase-lite-android:0.0.0-660'
compile 'com.couchbase.lite:couchbase-lite-android-forestdb:0.0.0-660'

Just need to rename isWindows to isExternalDrive and check to see if we are on the SD card, at which point we can assume FAT32. Eventually, we probably want to do more robust FS checking as other formats may come along later.

Nice work,
thanks for the migration code.

Fixed in couchbase-lite-java-forestdb. PR: https://github.com/couchbaselabs/couchbase-lite-java-forestdb/pull/53


ATM-dateTimePicker Returns an error on Custom input template

I am using ADM-dateTimePicker and I here is my code to make a date picker:
 <adm-dtp ng-model='date5' full-data='date_details' options='{dtpType: "date&time", calType: "jalali", format: "YYYY/MM/DD-hh:mm", default: "today", multiple:false, freezeInput:true }'>
        <input type='text' ng-model='date5' dtp-input />
        <button dtp-toggle > Open calendar </button>
    </adm-dtp>

But, when I click on the Open calendar button, it returns:

TypeError: Cannot set property 'location' of undefined

What is the problem?

Hi Mohammad,
I test your code in this PLUNKER.
Everything is fine!
Please provide a plunker sample of error you got.

Hello @MeTe-30
Yes! You are right, there was a problem in my own codes.
Thank you so much for your fast reply.
Great :+1:

mokhlesim


Don't start tomcat as a REST consumer.

Removed SpringBootApplication and CommandLineRunner from Application class. So it does not start a tomcat instance on its own.
When I tried to run a REST service provider (locally) and a consumer based on this example I found out that this consumer example also tries to start a tomcat instance. That lead to an "address already in use" exception. Apart from that it seems to be unnecessary for a consumer to start tomcat on its own.
Therefor, I removed this part from the Application class.

That would only be a problem if your two apps shared a classpath. If you use the project here it isn't an issue so I don't think we want this change in the guide particularly. Maybe we should add a note to the README saying that to launch the application when Tomcat is on the classpath you need to set webEnvironment=false in the SpringApplication.

This example by itself doesn't run Tomcat:
/\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v1.3.3.RELEASE)

2016-02-26 10:15:17.065  INFO 83719 --- [           main] hello.Application                        : Starting Application on retina with PID 83719 (/Users/gturnquist/src/spring-guides/gs-consuming-rest/complete/target/classes started by gturnquist in /Users/gturnquist/src/spring-guides/gs-consuming-rest/complete)
2016-02-26 10:15:17.068  INFO 83719 --- [           main] hello.Application                        : No active profile set, falling back to default profiles: default
2016-02-26 10:15:17.101  INFO 83719 --- [           main] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@1c9597cd: startup date [Fri Feb 26 10:15:17 CST 2016]; root of context hierarchy
2016-02-26 10:15:17.568  INFO 83719 --- [           main] o.s.j.e.a.AnnotationMBeanExporter        : Registering beans for JMX exposure on startup
2016-02-26 10:15:17.944  INFO 83719 --- [           main] hello.Application                        : Quote{type='success', value=Value{id=8, quote='I don't worry about my code scaling. Boot allows the developer to peel back the layers and customize when it's appropriate while keeping the conventions that just work.'}}
2016-02-26 10:15:17.945  INFO 83719 --- [           main] hello.Application                        : Started Application in 1.168 seconds (JVM running for 9.125)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.349 s
[INFO] Finished at: 2016-02-26T10:15:17-06:00
[INFO] Final Memory: 34M/335M
[INFO] ------------------------------------------------------------------------
2016-02-26 10:15:18.062  INFO 83719 --- [       Thread-1] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@1c9597cd: startup date [Fri Feb 26 10:15:17 CST 2016]; root of context hierarchy
2016-02-26 10:15:18.064  INFO 83719 --- [       Thread-1] o.s.j.e.a.AnnotationMBeanExporter        : Unregistering JMX-exposed beans on shutdown

I'm not sure how to word such a warning. If you run this app with Tomcat, then you risk a collision with another Tomcat? That is true for every guide.

Thank you for your feedback.
In my case I created two separate projects (one service and one consumer) and ran into the "address already in use" issue. I didn't set or change anything regarding the classpath or tomcat in particular.
When testing the example consumer with my changes in place it worked exaclty as described - so I thought this would not be necessary and removed it. Or is there something I am missing here?
If the current state is the expected and intended behaviour, you can of course close this PR.

it worked exaclty as described

I don't think it can have worked as described - if you remove the main method there is nothing to launch any more. Take a look at your classpath again: you have a different set of libraries than this sample if your app is starting Tomcat.

If you open gs-consuming-rest (with no edits) inside your IDE, you should
find this set of dependencies:
[image: Inline image 1]
You'll notice, there is no spring-boot-starter-web and no Tomcat, so it
can't start a Tomcat server. You had to have altered the build file to make
it start doing that.
On Fri, Feb 26, 2016 at 11:03 AM, Dave Syer<EMAIL_ADDRESS>wrote:

it worked exaclty as described
I don't think it can have worked as described - if you remove the main
method there is nothing to launch any more. Take a look at your classpath
again: you have a different set of libraries than this sample if your app
is starting Tomcat.
—
Reply to this email directly or view it on GitHub
https://github.com/spring-guides/gs-consuming-rest/pull/17#issuecomment-189373381
.

--
Greg Turnquist | Senior Software Engineer | Pivotal
Mobile: +1<PHONE_NUMBER> | twitter/github/skype: gregturn |
<EMAIL_ADDRESS>Pivotal.io http://www.pivotal.io

There is a main method and following the instructions on how to run it using the Gradle wrapper it seems to work:
[duelle : gs-consuming-rest]$ git remote -v
origin	git@github.com:duelle/gs-consuming-rest.git (fetch)
origin	git@github.com:duelle/gs-consuming-rest.git (push)

[duelle : gs-consuming-rest]$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean

[duelle : gs-consuming-rest]$ cd complete/

[duelle : complete]$ ./gradlew clean build
:clean
:compileJava
:processResources UP-TO-DATE
:classes
:findMainClass
:jar
:bootRepackage
:assemble
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:build

BUILD SUCCESSFUL

Total time: 5.203 secs

[duelle : complete]$ java -jar build/libs/gs-consuming-rest-0.1.0.jar
18:09:11.514 [main] DEBUG o.s.web.client.RestTemplate - Created GET request for "http://gturnquist-quoters.cfapps.io/api/random"
18:09:11.561 [main] DEBUG o.s.web.client.RestTemplate - Setting request Accept header to [application/json, application/*+json]
18:09:11.800 [main] DEBUG o.s.web.client.RestTemplate - GET request for "http://gturnquist-quoters.cfapps.io/api/random" resulted in 200 (OK)
18:09:11.802 [main] DEBUG o.s.web.client.RestTemplate - Reading [class hello.Quote] as "application/json;charset=UTF-8" using [org.springframework.http.converter.json.MappingJackson2HttpMessageConverter@dcdf5d7]
18:09:11.822 [main] INFO  hello.Application - Quote{type='success', value=Value{id=12, quote='@springboot with @springframework is pure productivity! Who said in #java one has to write double the code than in other langs? #newFavLib'}}

[duelle : complete]$

As I already stated, I didn't change any configurations, classpaths etc. and just thought I could help preventing others from running into the same "issue" I had when running this example with a local service.

Ok, now I can't reproduce my "issue" anymore.
Sorry for the confusion guys and thanks again for your fast replies and patience!

No problem at all. Thanks for your interest and for trying to help others.


FIX: Fix MNE-C

This should first expose the error in #4452. Will add a fix once we decide how best to fix it.

Codecov Report

Merging #4458 into master will decrease coverage by 37.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4458       +/-   ##
===========================================
- Coverage    82.7%   45.24%   -37.46%
===========================================
  Files         349      349
  Lines       64808    64808
  Branches    10023    10023
===========================================
- Hits        53598    29324    -24274
- Misses       8429    32959    +24530
+ Partials     2781     2525      -256

Okay, MNE-C has been restored. We have two failures: the one reported in #4452, and an additional one for dipole fitting that I will also fix here. (I don't experience the dipole-fitting problem on master locally but I can try to fix it anyway).

good. let's fix this before the release

CIs are happy, I'm going to merge since our tests on master are deficient without this.