Package conflict

Hi,
Thanks for sharing the code for A*NET. While installing packages like torchdrug it is resulting in different types of errors. There is a conflict for the packages. Could you please specify the version for each of these packages.
Thanks

Hi. Thanks for interest in this project. The version specifications can be found in requirements.txt.

Hi,
Thanks for your response. The conflicts were resolved when I used the latest PyTorch. However, it leads to a Torchdrug error for missing header file namely, SparseTensorUtils.h under ATen. In recent  PyTorch this file has been moved to ATen/native. I have requested a pull after committing these changes. Please approve if that works.

Hi @JuliaGast
I have forked the official torchdrug implementation and updated the paths to ATen/native. The committed repository is available at https://github.com/anilakash/torchdrug

Hi @anilakash
I have problems when setting up the environment.
I guess it is because of the version mismatch between those packages.
May I get the version list of your packages?
Thanks a lot!

Hi @anilakash I have problems when setting up the environment. I guess it is because of the version mismatch between those packages.
May I get the version list of your packages? Thanks a lot!

Hi @Cranooooooo,
Thanks for the query. Could you please confirm the specific package. On the other hand, you can try to install other packages as suggested in the original repository and install torchdrug from here https://github.com/anilakash/torchdrug . This works for me. Good luck.

Hi @anilakash , words don't allow me to thank you enough for your help with your fork.
For whomever struggling with something similar (in CUDA12.4, Pytorch 2.40) find here a short bash script that worked for me:

conda create -n astar python==3.10 -y
conda activate astar; conda clean -a -y; pip cache purge
pip install numpy==1.26.4
pip install torch==2.4.0 torchvision==0.19.0 torchaudio==2.4.0 --index-url https://download.pytorch.org/whl/cu124
pip install torch-scatter torch-sparse -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
pip install torch-cluster -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
pip install pyg-lib -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
echo "Now go and thank this brother git@github.com:anilakash/torchdrug.git"
git clone git@github.com:anilakash/torchdrug.git
cd torchdrug
pip install -r requirements.txt
python setup.py install
cd ..; rm -rf ./torchdrug

pip install ogb
pip install easydict
pip install PyYAML
pip install easydict

Hi Adri,
Many thanks for kind words. Happy to contribute.
On Mon, Nov 4, 2024 at 2:18 PM Adri @.***> wrote:

Hi @anilakash https://github.com/anilakash , words don't allow me to
thank you enough for your help with your fork.
For whomever struggling with something similar (in CUDA12.4, Pytorch 2.40)
find here a short bash script that worked for me:
conda create -n astar python==3.10 -y
conda activate astar; conda clean -a -y; pip cache purge
pip install numpy==1.26.4
pip install torch==2.4.0 torchvision==0.19.0 torchaudio==2.4.0 --index-url https://download.pytorch.org/whl/cu124
pip install torch-scatter torch-sparse -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
pip install torch-cluster -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
pip install pyg-lib -f https://data.pyg.org/whl/torch-2.4.0+cu124.html
echo "Now go and thank this brother @.:anilakash/torchdrug.git"
git clone @.:anilakash/torchdrug.git
cd torchdrug
pip install -r requirements.txt
python setup.py install
cd ..; rm -rf ./torchdrug
pip install ogb
pip install easydict
pip install PyYAML
pip install easydict
—
Reply to this email directly, view it on GitHub
https://github.com/DeepGraphLearning/AStarNet/issues/3#issuecomment-2454838671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7HDFWAQSP7NUJNMMEZQL3Z6564ZAVCNFSM6AAAAABRELR4TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUHAZTQNRXGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks & Regards,
Akash Anil, Ph.D.
Research Associate,
Computer Science and Informatics
Cardiff University, Wales, UK https://sites.google.com/site/akashanil2601/

“You don’t have to be great to start, but you have to start to be great.” –
Zig Ziglar


External resource

ExternalResource component, building on top of (and originally part of) the changes in #967. Uploaded here to be the basis for continuing work on external resources.

Closing as this work migrated to #1028.


help: Document stream notifications mobile feature.

Documents how to set default notifications for all streams and single streams.

Screenshots and screen captures:

https://zulip.com/help/stream-notifications

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Automated tests.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Links.

@alya This PR is ready for you.

Hm, I think the "Mobile" for the default notifications section should explain how to change the settings from within the mobile app (which you can do under Settings > Notifications).

Oh, I missed the Stream notifications setting somehow. I fixed the default notifications section and updated the screenshot in the PR description.

Thanks! I think we should clarify what that toggle actually controls, which I believe is just stream notifications for mobile. So maybe something like:

Toggle Stream notifications to configure mobile push notifications for stream messages.

Thanks! I think we should clarify what that toggle actually controls, which I believe is just stream notifications for mobile. So maybe something like:

Toggle Stream notifications to configure mobile push notifications for stream messages.

Yes, good point! I updated the PR/screenshot.

Works for me, thanks! @timabbott over to you.

Merged, thanks @drrosa!


Something went wrong installing the "sharp" module on gatsby

So, i just uninstalled my node.js version 10 and installed the current one node.js version 12 and went back to my gatsby project to run the gatsby develop and i got this error
success open and validate gatsby-configs - 0.141 s
Something went wrong installing the "sharp" module
The module '\?\C:\Users\Jaybee\Desktop\Projects\IamJude\node_modules\sharp\build\Release\sharp.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 64. This version of Node.js requires
NODE_MODULE_VERSION 72. Please try re-compiling or re-installing
the module (for instance, using npm rebuild or npm install).

Ensure the version of Node.js used at install time matches that used at runtime
Consult the installation documentation at https://sharp.pixelplumbing.com/en/stable/install/
Search for this error at https://github.com/lovell/sharp/issues

⠋ load plugins
I have done npm install and as well updated my gatsby cli but same error, please can i get help on this.
OS: windows 10
node.js version: 12.8.1
npm version: 6.10.2
Tried this #1747 already but didn't work for me

Native modules must be re-installed after a major upgrade of Node.js. Running npm rebuild (as suggested in the error message) usually fixes this.

Native modules must be re-installed after a major upgrade of Node.js. Running npm rebuild (as suggested in the error message) usually fixes this.

This worked
Thanks

I had the same issue after major Node upgrade (to v10.16.3) on my Windows build server. I ran npm rebuild as suggested in the error message. Now i get this error message instead:
Something went wrong installing the "sharp" module

The specified procedure could not be found.
\\?\C:\Build\WebbDev\node_modules\sharp\build\Release\sharp.node

- Remove the "node_modules/sharp" directory, run "npm install" and look for errors
- Consult the installation documentation at https://sharp.pixelplumbing.com/en/stable/install/
- Search for this error at https://github.com/lovell/sharp/issues

I can locate the sharp.node file in the file explorer.  I've tried to remove node_modules/sharp and the whole node_modules directory and then npm install again, same error. I've downgraded to Node v9.11.2 (the one I had before), same error. It works fine on my development environment.
I would be very happy for any ideas on this!


Additionally, even when I disable the http2 feature, the server still handles HTTP/2 requests. I don't think it should behave this way.

          Additionally, even when I disable the `http2` feature, the server still handles HTTP/2 requests. I don't think it should behave this way.

Originally posted by @TheAwiteb in https://github.com/salvo-rs/salvo/issues/851#issuecomment-2274456183

These features may cause http2 to be automatically enabled.

Yes I see, do you think changing this is better? because maybe I want my server only support one protocol,
We already emit a compile error if no one of those are enabled
https://github.com/salvo-rs/salvo/blob/affa8cca48cb98aedeec6767f02373bc1ffa4c5e/crates/core/src/server.rs#L7-L10

If all these protocols are disabled, what services are you providing?

If all these protocols are disabled, what services are you providing?

Not all, I only want http2 or only http3, or both together. Do you understand me? Meaning I don't want to support http1 for example,  now the server owner is forced to support http1 while they doesn't want to.
This is a breaking change, so we can implement it in the stable release.

Your words confuse me. The code here means that as long as you have a feature enabled, there will be no compilation error.
 #[cfg(not(any(feature = "http1", feature = "http2", feature = "quinn")))]
 compile_error!(
     "You have enabled `server` feature, it requires at least one of the following features: http1, http2, quinn."
 );

I mean there is no fear of not enabling one of them. Now if I want to support only http2 I can't and I want to.

I have no problem with the issue, and there is no reason why I would not want to support a particular protocol. But surely there is someone who wants to support only http1 or only http2. If you do not see this as the case, you can close the issue.

What I mean is that you only need to make sure that one feature is turned on, and there will be no compilation errors. Compilation errors will only be reported when any protocol is not supported.


--tidy-config and --analyzer-config clang-tidy:take-config-from-directory=true does not work

Still not fixed and can be reproduced in the same way. https://github.com/Ericsson/codechecker/issues/1798
Another way to reproduce is a using --analyzer-config clang-tidy:take-config-from-directory=true. Still the same bug
It is a very serious issue. In clang-tidy it is very canonical to use .clang-tidy file. A lot of teams can't migrate to your solution because this is a really frustrating problem.
Could you give me some workaround or put fix in the 6.16.0? Thank you
Version: 6.15.0

I tried to fix it by myself but I can't find --tidy-config inside analyzers folder

This is the place where this option is registered:
https://github.com/Ericsson/codechecker/blob/75ef0ec24f9ef0f3ae6cd0e3fc57d04ab1114c21/analyzer/codechecker_analyzer/cmd/analyze.py#L373-L381
And this is the place where we use it:
https://github.com/Ericsson/codechecker/blob/75ef0ec24f9ef0f3ae6cd0e3fc57d04ab1114c21/analyzer/codechecker_analyzer/analyzers/clangtidy/analyzer.py#L348-L362

This is the place where this option is registered:
https://github.com/Ericsson/codechecker/blob/75ef0ec24f9ef0f3ae6cd0e3fc57d04ab1114c21/analyzer/codechecker_analyzer/cmd/analyze.py#L373-L381
And this is the place where we use it:
https://github.com/Ericsson/codechecker/blob/75ef0ec24f9ef0f3ae6cd0e3fc57d04ab1114c21/analyzer/codechecker_analyzer/analyzers/clangtidy/analyzer.py#L348-L362

I think this issue is fixed in #3203.


Add attachments on WP8.1

Hi,
first of all, thanks for your efforts on this project.
Since WP8.1 does support email with attachments (via EmailMessage and EmailManager), I wonder if you can update the library and add support for attachments on WinPhone.
Regards,
Michele Noberasco

Not sure I understand the issue as the plugin provides support for WP 8.1 attachments.  Have a look at the WinPhoneRT sample.

Hi,
I did have a look at the WinPhoneRT sample, effectively the implementation is the one I'm looking for. However, I find myself unable to use it.
Context: I'm linking your library from a Xamarin Forms project (iOS, WP8.1 and Android). For some reason, when I fetch your library from NuGet, the WP8.1 project gets linked to the WinPhone variant of your library (where attachments are not available) instead of the WinPhoneRT variant. Do you have any idea why this happens, and what can I do to fix it?
Regards,
Michele


Store ci-flow preferences/opt-out in GH issue

Pitch
https://github.com/pytorch/pytorch/issues/24422 seems like efficient and easy to implement mechanism of storing per-user/label configuration
Perhaps similar mechanism would be useful to allow user to opt-in(and later opt-out) of CI flow and specify flows they want to run for them by default.
Say I often work on distributed tests, so I would like to add @malfet: ci-flow/distributed to the tracking issue and it will automatically add above-mnetioned label to all my PRs
Say I want to opt-out of ci-flow, then I can add my GH account name and nothing after it (or prefix it with - ) to opt-out

love the idea!


Feat/media

Uploading/getting files to/from ipfs.

all comments addressed here https://github.com/mintterteam/mintter/commit/54d5cfc587b7e415ecfd02682984e0ef412c9ec2


404 and client crashes after a few seconds after connect

"When I use my own localtunnel server it shows "404". But when I use the default localtunnel.me it works perfectly.
Also i noticed. If i access my LT server, i'm able to access http://my-lt-server.example.com:47777/api/status but http://my-lt-server.example.com:47777/api/tunnels/[tunnel-id]/status will return a Not Found page.
I just found out after running tunnel from my dev machine.
lt --host http://my-lt-server.example.com:47777 --port 80
It crashes after a few seconds. But it doesnt show any error. Is there a way to find the error?"

I have the same problem.
I tried as a dependency and it doesn't show errors either.

same issue here

same issue here

same

Same issue for me as well

Likely your server doesn't have high TCP ports open on the firewall for the tunnel connections. Start the server with debug enabled to see more info:
DEBUG=* node -r esm bin/server --host http://myhosthere.com --port xxxx

After running this:
DEBUG=* node -r esm bin/server --port 9000 --domain <sub.domain.tld>
Got this
  koa-router defined route HEAD,GET /api/status +0ms
  koa-router defined route HEAD,GET /api/tunnels/:id/status +3ms
  koa:application use dispatch +0ms
  koa:application use allowedMethods +0ms
  koa:application use - +1ms
  koa:application use - +0ms
  localtunnel server listening on port: 9000 +0ms
  koa-router GET / +0ms
  koa-router test /api/status /^\/api\/status(?:\/(?=$))?$/i +0ms
  koa-router test /api/tunnels/:id/status /^\/api\/tunnels\/((?:[^\/]+?))\/status(?:\/(?=$))?$/i +1ms
  localtunnel:server making new client with id spotty-chipmunk-40 +0ms
  lt:TunnelAgent[spotty-chipmunk-40] tcp server listening on port: 42659 +0ms
  lt:ClientManager removing client: spotty-chipmunk-40 +0ms
  lt:TunnelAgent[spotty-chipmunk-40] closed tcp socket +1s
  lt:TunnelAgent[spotty-chipmunk-40] closed tcp socket +0ms

Thanks for the suggestion. It seems the host server is behind the firewall and the lt client was not able to connect to the lt server created randomly port.

Hello! Anyone found the solution to this problem?


[$500] Workspace - "Hmm it's not here" error appears briefly when enabling workflows

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468674&group_by=cases:section_id&group_order=asc&group_id=283225
Issue reported by: Applause - Internal Team
Action Performed:

Log in with a new expensifail account
Create a workspace
Navigate to Workspace settings - More features
Enable workflows

Expected Result:
I shouldn't be getting any errors
Actual Result:
"Hmm it's not here" error appears briefly when enabling workflows for the first time
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/d1051e55-a18f-4b02-9ca4-14176d26f3e7
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f589bc2448420016
Upwork Job ID:<PHONE_NUMBER>069042688
Last Price Increase: 2024-04-10
Automatic offers:

hungvu193 | Reviewer | 0
ZhenjaHorbach | Contributor | 0

Hey! How can I re-enable workflow once I enabled it?

Proposal
Please re-state the problem that we are trying to solve in this issue.

Workspace - "Hmm it's not here" error appears briefly when enabling workflows

What is the root cause of that problem?

Right after calling EnablePolicyWorkflows, we navigate to workflow pages, and in here, we call OpenPolicyWorkflowsPage. There is the case BE handles OpenPolicyWorkflowsPage as areWorkflowEnabled: false because EnablePolicyWorkflows is not successfully, that leads to areWorkflowEnabled is set to false after the OpenPolicyWorkflowsPage is called succesfully.
So, the shouldShowNotFoundPage in here will be true, and the Not here page is displayed.

What changes do you think we should make in order to solve the problem?

We can resolve the conflict between these API by updating this to:

API.write(WRITE_COMMANDS.ENABLE_POLICY_WORKFLOWS, parameters, onyxData, {
        getConflictingRequests: (persistedRequests) => {
            const conflictingCommands = [READ_COMMANDS.OPEN_POLICY_WORKFLOWS_PAGE] as string[];
            return persistedRequests.filter((request) => conflictingCommands.includes(request.command));
        },
        handleConflictingRequest: () => Onyx.update(onyxData?.successData ?? []),
        shouldIncludeCurrentRequest: false,
    });

What alternative solutions did you explore? (Optional)

NA

Hey! How can I re-enable workflow once I enabled it?
Screen.Recording.2024-04-04.at.10.05.49.mov

Do you mean to open more features ? And then turn workflows off and on ?)

 Thank you.

I'm not able to reproduce on latest main, can you still reproduce? @ZhenjaHorbach
https://github.com/Expensify/App/assets/16502320/18888c6c-a11e-472c-abee-6986a3a28fa9

Like this right?
https://github.com/Expensify/App/assets/16502320/02f2dc25-6b76-46be-aaa5-96d7a1cd335b

I believe I could reproduce this issue without creating a new workspace while reviewing your proposal, however I can't reproduce it now. Can you give it a try and let me know? Thank you 😄

Proposal
Please re-state the problem that we are trying to solve in this issue.

Workspace - "Hmm it's not here" error appears briefly when enabling workflows

What is the root cause of that problem?

Given these below steps:

We click to create new workspace, API CreateWorkspace is called. (If done, it will return areWorkflowsEnabled: false)
When the above API is in progress, open "More feature" screen then toggle "Workflows" feature, API EnablePolicyWorkflows is called. (If done, it will return areWorkflowsEnabled: false).
If the API EnablePolicyWorkflows is done before CreateWorkspace, areWorkflowsEnabled will be false finally. So, the shouldShowNotFoundPage in here will be true, and the Not here page is displayed.

What changes do you think we should make in order to solve the problem?

We can make sure before we toggle any feature (Workflows, categories, taxes, ...), there is no persistent request.
To do it, we can display the loading indicator when there is any persistent request, by updating this to:

    persistedRequests: {
        key: ONYXKEYS.PERSISTED_REQUESTS
    }

and this to:
    const shouldShowFullScreenLoadingIndicator =
        (props.isLoadingReportData !== false && (!Object.entries(props.policy ?? {}).length || !props.policy?.id)) ||
        (!isEmpty(props.persistedRequests) && !wasPersistedRequestsEmpty.current);

and add the useEffect to this:
    const wasPersistedRequestsEmpty = useRef(false);
    useEffect(() => {
        if (isEmpty(props.persistedRequests) && !wasPersistedRequestsEmpty.current) {
            wasPersistedRequestsEmpty.current = true;
        }
    }, [props.persistedRequests]);

What alternative solutions did you explore? (Optional)

NA

@ZhenjaHorbach's alternative solution looks good to me.
Thanks @nkdengineer, I think using persistedRequests is a little  over-engineering for this case since we only needed pendingFields itself.
👀 🎀 👀  C+ reviewed

🎀👀🎀  C+ reviewed

@hungvu193 In the read API, for example OpenMoreFeaturePage, we do not have pendingFields. So the bug still appears if we just check if the policy has pendingField or not

@hungvu193 In the read API, for example OpenMoreFeaturePage, we do not have pendingFields. So the bug still appears if we just check if the policy has pendingField or not

Can you reproduce it? I tested it with all the features today and I can't seem to reproduce with pendingFields solution.

@hungvu193

You are correct, I am unable to reproduce this bug anymore.
I updated my alternative proposal to fix this issue "Workspace - "Hmm it's not here" error appears briefly when enabling workflows". With the solution using "pendingField" and "persistentRequest", the infinite loading indicator will be displayed in offline mode

Again I can reproduce the issue while reviewing 2 proposals, however I can't reproduce now 😂 , so It will make more times to review this alternative proposal
One note for @ZhenjaHorbach, your solution worked but it will always show loading indicator even when we enabled the feature in offline mode.

@hungvu193 are you still confident in the proposal you chose? Or should I wait for the discussion to complete?

@hungvu193 are you still confident in the proposal you chose? Or should I wait for the discussion to complete?

Yeah, please wait for the discussion. I'll take a look this weekend.

@ZhenjaHorbach @nkdengineer Please confirm if you guys still can reproduce this issue on latest main. Thank you 🙇

Same as @ZhenjaHorbach. I can reproduce this bug in staging as well.

@hungvu193 I updated my alternative proposal to add the explanation about the solution

I'm really confused, the reproduction steps doesn't work for me, I can't really reproduce the issue right now.
Is there any specific step to reproduce this one?

I'm really confused, the reproduction steps doesn't work for me, I can't really reproduce the issue right now. Is there any specific step to reproduce this one?

The main thing is to create a new workspace Enable any feature and just wait some time) It always reproduce for me)

ok I can reproduce now by reseting cache, logout, login again and do the following steps like you suggested 👍

@hungvu193 You need to do these steps quickly: Create new workspace => open more feature page => toggle workflows feature

Thanks everyone. After some testing, I'm still align with @ZhenjaHorbach alternative solution here, I don't think we need to navigate user to another screen when they don't have access to the page.
All yours @puneetlath.

@hungvu193 My proposal only navigate user to more-feature page if they turn off workflows feature in another device. In the case of this bug, it works well

@hungvu193  Do you have any feedback about my alternative solution?

Also, I tested the solution using "pendingFields" and I see that In the case the network is slow, the loading indicator is displayed for a long time (> 10s), though we can use the optimistic data in this case
https://github.com/Expensify/App/assets/161821005/981dd020-7eed-4e6f-a3e0-9d933429fdb9

@hungvu193 Do you have any feedback about my alternative solution?

Your solution didn't work for this case:

Open 2 tabs
Open workflows in the first tab. Disabled it on the second tab.
Reload the first tab.

Test evidence
https://github.com/Expensify/App/assets/16502320/55d510da-8b0d-431a-9ce0-b6f976c1773c

Also with that approach, we will navigate user to another screen if they're already in that screen and PolicyFeature is disabled. As I said above, I don't think that's good idea. Given that information, I'm still align with @ZhenjaHorbach. But please wait for @puneetlath opinion as well. Thank you.

@hungvu193 I see that in your above video, the 1st and 2nd tabs have 2 different workspace. Below is the correct video when we open 2 similar workspaces in 2 tabs:
https://github.com/Expensify/App/assets/161821005/21afffa9-010b-48e9-9eb4-a068599c2cb4

I see that in your above video, the 1st and 2nd tabs have 2 different workspace. Below is the correct video when we open 2 similar workspaces in 2 tabs:
Screen.Recording.2024-04-06.at.22.49.50.mov

I see. I updated the evidence in my comment. I still expect if user don't have accept, they will see NotFoundPage instead of moving them to MoreFeaturePage.  Anyway, that's just my thought, let's wait for final decision 🙇

@hungvu193 Thanks for your feedback. Let's wait for the final decision from the internal team. Also, I created a draft PR to make sure you implement my solution properly.

FYI: We already had the same logic in Report page:
https://github.com/Expensify/App/blob/f1502291a14d4e15e04249b241109f146bdb512f/src/pages/home/ReportScreen.tsx#L477

@hungvu193 I the regression with the selected proposal:

Open 2 tabs. 1st tab opens more feature page. 2nd tab open workflows page
Turn off the "workflows" option in 1st tab

Expected: 2nd tab will display "Hmm It's not here" page
Actual: 2nd tab displays the workflow page
Evidence:

https://github.com/Expensify/App/assets/161821005/1801c273-8ba9-43b4-8d5d-9a0974ada0e8

Just summarizing for @puneetlath:

Currently, there are two solutions, both of which address the issue, but they come with drawbacks:

The solution endorsed by C+: Upon creating a new workspace and enabling the "workflows" feature, there's a prolonged loading time (~10s) before the workflow page appears.

Another approach: If a user accesses the workflow page on device 1, then on device 2, disables the "workflows" feature, the user on device 1 will be redirected to the "more features" page. In other word, user is just navigated to more-feature page in case user are accessing the workflows page, then the workflows feature is turned off in other device

To be fair, let me write a summary (Thanks @nkdengineer for writing it out, I've should write it earlier).
Summary:
Testcase:

Enable and disable workflow from another tabs.
Enable, disable workflow in offline mode.
Enable workflow after creating workspace.

Contributor proposals:
@ZhenjaHorbach: (https://github.com/Expensify/App/issues/39443#issuecomment-2034110128)

Main proposal: Using an useEffect to check if there's a change with props.policy?.pendingFields?[.[props.featureName] then calculate if user has the permission. This approach is straightforward, worked fine and passed all 3 test cases.
Alternative proposal: Update the logic of shouldShowFullScreenLoadingIndicator, if there's a pending update policy action, we should show LoadingIndicator. This approach also worked and passed all testcases however it will show a LoadingIndicator every time we try to enable the workflow.

@nkdengineer: (https://github.com/Expensify/App/issues/39443#issuecomment-2036576413)

Main proposal: Using persistedRequested to calculate the logic, feels a little over-engineering to me, also was removed by the author.
Alternative proposal: Using wasPageVisible ref to update the logic of shouldShowNotFoundPage, this wasPageVisible value will be updated to true right after the children component was rendered, thus wasPageVisible will never be false once child component was rendered, so this condition was added to navigate the user to MoreFeaturePage once page was renderer and user turned off the Workflow from another tabs (account, device..).

    if(!PolicyUtils.isPolicyFeatureEnabled(props.policy, props.featureName)){
        Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(props.policyID))
    }

This approach passed 2nd and 3rd test case, but with the first test case, it will navigate user to MoreFeaturePage instead of showing NotFoundPage.
C+ selection:
I'm aligned with @ZhenjaHorbach's solution, which aims to fix the RCA. Initially, my first thought was that I didn't want to see a little blinking right after enabling the Workflow. Therefore, I think having a LoadingIndicator would be better. However, upon further consideration, I realize we can still keep it as it is right now, so his main solution would be okay.
And finally, Thank you both for getting involve and helping me to reproduce this issue. I appreciate your efforts.
Have a great weekend everyone! 🙇

@hungvu193

FYI, the main solution here has a regression. Steps to reproduce:

In tab 1, go offline then open workflows page
In tab 2, go offline then open more-feature page
In tab 2, turn off "workflows" feature
Actual: Observe that in tab1, the "workflow" still displays - Expected: The "Hmm It 's not here" page displays

Evidence:

https://github.com/Expensify/App/assets/161821005/5ab2d621-825f-47e9-aebc-5c9db4065456

@ZhenjaHorbach

Actually, you are describing very specific cases )

It is not a specific case. It is one of the test cases mentioned here

@hungvu193 I updated my proposal with new solution, that will fix the RCA. Based on the RCA, the bug also appears with the "Workflow" option in WorkspaceInitialPage, where that option is disappeared for a while (What changes do you think we should make in order to solve the problem section)

Do you have any feedback about my comment here?

Great discussion. Not an easy decision. After thinking about it, I also prefer @ZhenjaHorbach's solution. I don't really love the idea of adding the new Onyx key if we can do without it.

@puneetlath As you can see, the bug does not only appear on workflows page, but also the workspace initial page: The "Workflows" option disappears for a while:
https://github.com/Expensify/App/assets/161821005/98f9a5fb-806d-4593-8d1f-9001525ee25a

@ZhenjaHorbach Yeah. Please cover this case in your PR. Anyway, your proposal looks good

@hungvu193 friendly reminder on the checklist so that we can pay in a couple days.

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/37902
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37902/files#r1586990316
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug.

This is new feature and we're still developing it so I don't think we need regression test for this one.

All paid. Thanks y'all!


MSFT_ADReplicationSite: Fixing Description parameter evaluation

Pull Request (PR) description
Fix for correct evaluation of Description parameter in Test-TargetResource of MSFT_ADReplicationSite resource. When no description was defined, the test incorrectly evaluated as $false every time.
This Pull Request (PR) fixes the following issues
Fixes #534
Task list

[X] Added an entry under the Unreleased section in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in resource directory README.md.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[X] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Hi @MartinVokurek, thanks for spotting this and raising the PR. Could you add an additional integration test for an ADReplicationSite without a description property to prove this?

Hi,
I can try, it might take some time though.
Martin
Od: Simon Heather<EMAIL_ADDRESS>Odesláno: úterý 7. ledna 2020 12:18
Komu: dsccommunity/ActiveDirectoryDsc<EMAIL_ADDRESS>Kopie: Martin Vokurek<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Předmět: Re: [dsccommunity/ActiveDirectoryDsc] MSFT_ADReplicationSite: Fixing Description parameter evaluation (#535)
Hi @MartinVokurekhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMartinVokurek&data=02|01||aea7a68dd27c4b41279a08d793634da2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637139927015048203&sdata=2%2BfuNo6NXGy6%2FDa5m3U%2BHMlyeyjQZcJefK6BY3A8ONk%3D&reserved=0, thanks for spotting this and raising the PR. Could you add an additional integration test for an ADReplicationSite without a description property to prove this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdsccommunity%2FActiveDirectoryDsc%2Fpull%2F535%3Femail_source%3Dnotifications%26email_token%3DAESCU5SO6E5V7GE4FUWGXYDQ4RQHXA5CNFSM4KDWEC6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIIRPOQ%23issuecomment-571545530&data=02|01||aea7a68dd27c4b41279a08d793634da2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637139927015058208&sdata=ZP3ESTKWG6Ln8R2%2B5b3wXjCuhVwEJEz4fhkyVS9InlI%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAESCU5VCRPU6SAHVV2CSYETQ4RQHXANCNFSM4KDWEC6A&data=02|01||aea7a68dd27c4b41279a08d793634da2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637139927015068219&sdata=4kLlpPUB%2FpZ%2FagO6p%2B0GS%2BaQxyqgwKz1aa3pyGA9fu4%3D&reserved=0.

It should just be a simple copy and paste of the current integration test then remove the description.

Ok, the integration tests are nicely readable, so it was really simple to add the scenario. Hopefully the way I did it makes sense.

We are currently working on a new integration/deployment process for the DSC community resources. Hopefully this will be completed in the next few days, and we can then publish a new release, which will include this update.


CUDA memory issue

Hello,
First off: Great work with this project, it is exceptionally cleanly written and structured imo!
It is nice to see that there is a tutorial, the full code on github with clean and working instructions. (It is working using the CPU for me) :)
Is there a way to make pytorch reserve less RAM?
In another post someone talked about a active variable in the session which seems to use too much memory:
https://discuss.pytorch.org/t/how-does-reserved-in-total-by-pytorch-work/70172/2
Could this be the case? (I am not an Python expert)
Here's the issue:
\DeepLabv3FineTuning-master> python main.py --data-directory CrackForest --exp_directory CFExp --epochs 1
Epoch 1/1

  0%|                                                                                | 0/24 [00:05<?, ?it/s]
Traceback (most recent call last):
  File "main.py", line 66, in <module>
    main()
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "main.py", line 53, in main
    _ = train_model(model,
  File "C:\Users\gdurm\Downloads\DeepLabv3FineTuning-master\DeepLabv3FineTuning-master\trainer.py", line 49, in train_model
    outputs = model(inputs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torchvision\models\segmentation\_utils.py", line 19, in forward
    features = self.backbone(x)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torchvision\models\_utils.py", line 63, in forward
    x = module(x)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\container.py", line 119, in forward
    input = module(input)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torchvision\models\resnet.py", line 133, in forward
    out = self.bn3(out)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\modules\batchnorm.py", line 135, in forward
    return F.batch_norm(
  File "C:\tools\Anaconda3\envs\deeplabfinetuning\lib\site-packages\torch\nn\functional.py", line 2146, in batch_norm
    return torch.batch_norm(
RuntimeError: CUDA out of memory. Tried to allocate 38.00 MiB (GPU 0; 2.00 GiB total capacity; 1.05 GiB already allocated; 11.44 MiB free; 1.10 GiB reserved in total by PyTorch)```

Hi, would a 8 GB GPU be sufficient?


The helptext generator doesn't work properly for the list view

The built-in shortcuts shows up twice in some cases.
Rather than fix the old implementation we should rewrite the code to use generic_inputhandler() + generate_helptext() from curses_helper.

This can be reproduced by opening a list view that makes use of the view yaml & view json shortcuts. Reopen the same view again and those entries will be duplicated.

This is fixed in 6ef3c8354c6ce3c80a437b373d9e62c92aab5e55 in the systempath branch.

The systempath branch has now been merged.


chore: update workflow references

This PR:

fixes release notes generation for newly-created release-* branches

Not valid anymore


Webgl2 performance issues

When using the plugin with the WebGL2 fallback on weaker hardware, performance seems to fall off a cliff. The performance is completely fine when using WebGPU or running natively on the same hardware. Examples:

On my more-than-five-years-old 32GB machine with a 8GB 1070 it's absolutely fine in both scenarios
On the relatively new 16GB laptop with a 4GB mobile 3050 that I also have in my household it runs at maybe 5 seconds per frame (note, not FPS but SPF)
I have another report of unknown-but-weaker-than-1070 hardware where it runs "very badly"

In all cases switching to the regular Windows build fixes the problem, and in the laptop I case I tried with WebGPU build in Chrome and that worked nicely.
Not using any lights doesn't save the performance, the problem occurs as soon as the plugin is loaded, which means it can't be easily "fixed" by making it a setting in a menu or automatically turning lighting of if the numbers are too bad. Making it possible to dynamically turn the effects of the plugin on/off would be useful for implementing that kind of solution.

Thanks for the write up!
WebGL2 will inherently perform worse, as there are quite a few limitations we have to workaround. That being said, we should still aim for it to perform reasonably.


TestExtractTarOverwrite: fails when running as root

I cloned the rkt git repository in /var/tmp/rkt, compiled and run the unit test TestExtractTarOverwrite as root. It fails with the following:
ok          github.com/coreos/rkt/common        1.012s        coverage: 39.2% of statements
ok          github.com/coreos/rkt/common/cgroup        1.011s        coverage: 8.9% of statements
ok          github.com/coreos/rkt/pkg/fileutil        1.010s        coverage: 35.1% of statements
ok          github.com/coreos/rkt/pkg/keystore        1.291s        coverage: 60.9% of statements
ok          github.com/coreos/rkt/pkg/lock        1.010s        coverage: 77.2% of statements
ok          github.com/coreos/rkt/pkg/set        1.008s        coverage: 100.0% of statements
--- FAIL: TestExtractTarOverwrite (1.02s)
tar_test.go:620: unexpected error: Expected file "folder01/file02" not in files
FAIL

/cc @dgonyeo

Found that error when trying to run the functional tests inside rkt as a part of testing building rkt-in-rkt.


No support for RPI-63FS

🐛 Describe the bug
安裝完成輸入密碼後，家裡共11個設備出現了10個，缺的這台RPI-63FS發現目前沒支援，希望能加入支援設備清單🍻
Environment Information
HA 2023.9.1

Shouldn't be unsupported as long as it's a regular air conditioner.
I don't really have time to look into it in the near future, sorry. Let's keep the issue open.

You have two devices using the same name 主臥, rename one of them so that all the devices have unique names should work.


Automated cherry pick of #3153: [batch/job] Fix parallelism restoration after partial admission.

Cherry pick of #3153 on release-0.8.
#3153: [batch/job] Fix parallelism restoration after partial admission.
For details on the cherry pick process, see the cherry pick requests page.
Fix restoring parallelism on eviction for partially admitted batch/Jobs.

The conflict was triggered by the movement of job webhook integration tests. (mot relevant to the PR)

The conflict was triggered by the movement of job webhook integration tests. (mot relevant to the PR)

Thanks.
/hold cancel

/lgtm

/kind bug


Remove devctl gen kubeconfig command

See https://gigantic.slack.com/archives/C0251MXL5/p1662378839834409
Backrground: we implemented opsctl login and want this to be the only way we access workload clusters.

got done


Setup/Add cold dev sever

Checklist

[ ] ~I run yarn run webpack:build:main: the project builds without errors.~
[ ] ~I run yarn lint: the project builds without code style warnings.~
[ ] ~I updated the documentation and models.~
[ ] ~I tested the changes and all related features on the test server https://artemistest.ase.in.tum.de.~
[ ] ~I added (end-to-end) test cases for the new functionality.~

Motivation and Context
The HMR for Angular is not working correctly for us. Instead of replacing single chunks, it always reloads the page.
I did some investigation following up @maximilianmeier but found no solution.
As a compromise I have created a new script that sets the hot & inline params of the webpack dev server to false. This way the page has to be manually reloaded - as the HMR is not working, it is a better approach imo.
Description

New script start-cold in package.json
Added checking for hot parameter in webpack.dev.js

Steps for Testing

Start client with start-cold
Change a file
Modules should recompile but page should not reload
Reload the page and the change should be visible

Screenshots

Have you tried https://github.com/angular/angular-cli/wiki/stories-configure-hmr ?
It is indeed quite annoying we don't have HMR

I don't think it's compatible with our webpack setup, @maximilianmeier had the suspicion that hmr is not working for us because of the way we structure our modules.


build: delete unused script

:tada: This PR is included in version 0.1.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Database reconnect not effective immediately within same operation

Description
When MySQL goes down, the OpenNebula is able to reconnect again. Unfrotunately, while the successful reconnect is manifested in the log, the served API call during which the reconnect happens still fails. At the end, whole pool of (default) 50 connections has to first reconnect to serve future calls.
Example: ( while true; do oneuser list; done ) | nl
    66	[one.userpool.info] User couldn't be authenticated, aborting call.    # <----- MySQL is down
    67	[one.userpool.info] User couldn't be authenticated, aborting call.
    68	[one.userpool.info] User couldn't be authenticated, aborting call.
    69	[one.userpool.info] User couldn't be authenticated, aborting call.
    70	[one.userpool.info] User couldn't be authenticated, aborting call.    # <----- MySQL is running
    71	[one.userpool.info] User couldn't be authenticated, aborting call.
    72	[one.userpool.info] User couldn't be authenticated, aborting call.
    73	[one.userpool.info] User couldn't be authenticated, aborting call.
    74	[one.userpool.info] User couldn't be authenticated, aborting call.
    75	[one.userpool.info] User couldn't be authenticated, aborting call.
    76	[one.userpool.info] User couldn't be authenticated, aborting call.
    77	[one.userpool.info] User couldn't be authenticated, aborting call.
    78	[one.userpool.info] User couldn't be authenticated, aborting call.
    79	[one.userpool.info] User couldn't be authenticated, aborting call.
    80	[one.userpool.info] User couldn't be authenticated, aborting call.
    81	[one.userpool.info] User couldn't be authenticated, aborting call.
    82	[one.userpool.info] User couldn't be authenticated, aborting call.
    83	[one.userpool.info] User couldn't be authenticated, aborting call.
    84	[one.userpool.info] User couldn't be authenticated, aborting call.
    85	[one.userpool.info] User couldn't be authenticated, aborting call.
    86	[one.userpool.info] User couldn't be authenticated, aborting call.
    87	[one.userpool.info] User couldn't be authenticated, aborting call.
    88	[one.userpool.info] User couldn't be authenticated, aborting call.
    89	[one.userpool.info] User couldn't be authenticated, aborting call.
    90	[one.userpool.info] User couldn't be authenticated, aborting call.
    91	[one.userpool.info] User couldn't be authenticated, aborting call.
    92	[one.userpool.info] User couldn't be authenticated, aborting call.
    93	[one.userpool.info] User couldn't be authenticated, aborting call.
    94	[one.userpool.info] User couldn't be authenticated, aborting call.
    95	[one.userpool.info] User couldn't be authenticated, aborting call.
    96	[one.userpool.info] User couldn't be authenticated, aborting call.
    97	[one.userpool.info] User couldn't be authenticated, aborting call.
    98	[one.userpool.info] User couldn't be authenticated, aborting call.
    99	[one.userpool.info] User couldn't be authenticated, aborting call.
   100	[one.userpool.info] User couldn't be authenticated, aborting call.
   101	[one.userpool.info] User couldn't be authenticated, aborting call.
   102	[one.userpool.info] User couldn't be authenticated, aborting call.
   103	[one.userpool.info] User couldn't be authenticated, aborting call.
   104	[one.userpool.info] User couldn't be authenticated, aborting call.
   105	[one.userpool.info] User couldn't be authenticated, aborting call.
   106	[one.userpool.info] User couldn't be authenticated, aborting call.
   107	[one.userpool.info] User couldn't be authenticated, aborting call.
   108	[one.userpool.info] User couldn't be authenticated, aborting call.
   109	[one.userpool.info] User couldn't be authenticated, aborting call.
   110	[one.userpool.info] User couldn't be authenticated, aborting call.
   111	[one.userpool.info] User couldn't be authenticated, aborting call.
   112	[one.userpool.info] User couldn't be authenticated, aborting call.
   113	[one.userpool.info] User couldn't be authenticated, aborting call.
   114	[one.userpool.info] User couldn't be authenticated, aborting call.
   115	[one.userpool.info] User couldn't be authenticated, aborting call.
   116	[one.userpool.info] User couldn't be authenticated, aborting call.
   117	[one.userpool.info] User couldn't be authenticated, aborting call.
   118	[one.userpool.info] User couldn't be authenticated, aborting call.
   119	[one.userpool.info] User couldn't be authenticated, aborting call.
   120	[one.userpool.info] User couldn't be authenticated, aborting call.
# <----- after ~50 failed API calls OpenNebula starts working ----->
   121	  ID NAME                                                        GROUP    AUTH            VMS     MEMORY        CPU

All individual failed userpool.info calls are acompanied with MySQL server has gone away... Reconnected. message, but the operation fails on authentication error. Part of log for last calls around (from above) line 118:
Fri Sep 18 12:28:38 2020 [Z0][AuM][E]: Auth Error: Authentication driver 'default' not available
Fri Sep 18 12:28:38 2020 [Z0][ReM][D]: Req:400 UID:-1 IP:<IP_ADDRESS> one.userpool.info invoked
Fri Sep 18 12:28:38 2020 [Z0][ReM][E]: Req:400 UID:- one.userpool.info result FAILURE [one.userpool.info] User couldn't be authenticated, aborting call.
Fri Sep 18 12:28:39 2020 [Z0][ONE][E]: MySQL connection error 2006 : MySQL server has gone away... Reconnected.
Fri Sep 18 12:28:39 2020 [Z0][AuM][D]: Message received: AUTHENTICATE FAILURE 418 Authentication driver 'default' not available

Fri Sep 18 12:28:39 2020 [Z0][AuM][E]: Auth Error: Authentication driver 'default' not available
Fri Sep 18 12:28:39 2020 [Z0][ReM][D]: Req:3152 UID:-1 IP:<IP_ADDRESS> one.userpool.info invoked
Fri Sep 18 12:28:39 2020 [Z0][ReM][E]: Req:3152 UID:- one.userpool.info result FAILURE [one.userpool.info] User couldn't be authenticated, aborting call.
Fri Sep 18 12:28:39 2020 [Z0][ONE][E]: MySQL connection error 2006 : MySQL server has gone away... Reconnected.
Fri Sep 18 12:28:39 2020 [Z0][AuM][D]: Message received: AUTHENTICATE FAILURE 419 Authentication driver 'default' not available

Fri Sep 18 12:28:39 2020 [Z0][AuM][E]: Auth Error: Authentication driver 'default' not available
Fri Sep 18 12:28:39 2020 [Z0][ReM][D]: Req:8784 UID:-1 IP:<IP_ADDRESS> one.userpool.info invoked
Fri Sep 18 12:28:39 2020 [Z0][ReM][E]: Req:8784 UID:- one.userpool.info result FAILURE [one.userpool.info] User couldn't be authenticated, aborting call.
Fri Sep 18 12:28:39 2020 [Z0][ReM][D]: Req:3728 UID:2 IP:<IP_ADDRESS> one.userpool.info invoked
Fri Sep 18 12:28:39 2020 [Z0][ReM][D]: Req:3728 UID:2 one.userpool.info result SUCCESS, "<USER_POOL><USER><ID..."
Fri Sep 18 12:28:40 2020 [Z0][ReM][D]: Req:2976 UID:2 IP:<IP_ADDRESS> one.userpool.info invoked
Fri Sep 18 12:28:40 2020 [Z0][ReM][D]: Req:2976 UID:2 one.userpool.info result SUCCESS, "<USER_POOL><USER><ID..."
Fri Sep 18 12:28:40 2020 [Z0][ReM][D]: Req:9408 UID:2 IP:<IP_ADDRESS> one.userpool.info invoked

Note: PostgreSQL probably affected as well (???)
To Reproduce

Stop MySQL
give it some time
Start MySQL
OpenNebula doesn't work immediately, it takes some time to restore the operation

Expected behavior
OpenNebula works immediately when database is back.
Details

Affected Component: Core
Version: 5.12.3

Additional context
Add any other context about the problem here.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Solved for both MySQL and PostgreSQL
PRs for merge:

https://github.com/OpenNebula/one-ee/pull/304 - one-ee merge to one-5.12 and master
https://github.com/OpenNebula/docs/pull/1311 - merge to one-5.12-maintanance


protobuf generate method name questions

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.5

when use protobuf serialization， method in proto file will translate to lowercase start method name， why do that ？
// proto
service DemoService {
  rpc SayHello (HelloRequest) returns (HelloReply) {}
}
// generated java code
public interface IDemoService {

static Class<?> clazz = init();

    org.apache.dubbo.demo.HelloReply sayHello(org.apache.dubbo.demo.HelloRequest request);

    CompletableFuture<org.apache.dubbo.demo.HelloReply> sayHelloAsync(org.apache.dubbo.demo.HelloRequest request);
}
}

results
It will make other language like golang call java provider harder，in golang，lowerCaseFirst method means private。Just use original methodName is ok？

anyone give some advice? or directly prs?

Try it with the latest version, if you still have problems, you can reopen the issues


Parser error for infix methods with type parameter.

From @durban on February 4, 2016 12:15
The code below produces this message:
[warn] Scalariform parser error for .../GenericOperator.scala: Expected token SEMI but got Token(LBRACKET,[,83,[)

The error seems to be caused by the C() ?[Int] 7 expression; without the [Int], there is no error.
object GenericOperator {

  case class C() {
    def ?[A](a: A): A = a
  }

  C() ?[Int] 7
}

Copied from original issue: daniel-trinh/scalariform#111

This actually happens with any infix method.

This happens also with non-symbolic operators that take a type parameter. To me it happens for:
BinaryCodec decode[List[Int]] bytes

If I write this with dot and parenthesis then the error disappear.

Any update on this?

I got this error because of a mistype
Expected token SEMI but got Token(MATCH,match,759,match)
I started the pattern matching like this
val brand match{
instead of
val brand = resJs match{

Ping on this - has there been any resolution to this? We get hit by this in several places, and don't know where to start looking. There is mention of a workaround in some of the referenced issues, but no pointer to the actual workaround?

Hello,
I got a similar error message (as reported in #217) with scalastyle:
Expected token SEMI but got Token(ARROW,=>,639,=>)

On the following block:
fields
      .map { field =>
        // [...]
        val matchResult = be(expected(field.getName)).apply(field.get(left)
        matchResult.copy(
          // [...]
          midSentenceNegatedFailureMessageArgs = matchResult.midSentenceNegatedFailureMessageArgs :+ field.getName,
        )
      }

I fixed it by removing the trailing comma at the end of the copy call.

had similiar issue as @AlexisBRENON ended up being a trailing comma for me as well after man hours of hair pulling. Thank you for that post

For anyone finding this and also looking for a description of the workaround: the number in the error message is the character position of the error. So if you flatten the code and jump to that position you will see where the error occurs (i.e. position 83 in the error in the issue description).


Foreground Binding in DataTemplate not updated after theme change

Describe the bug

When setting a new theme (Dark/Light), Foreground Bindings within a DataTemplate for a ContentControl (like a Button) aren't immediately refreshing.  Yet once we mouse over the button and move off of it, they are correct from that point on.  This needs to be fixed so they update immediately because DataTemplate-embedded elements like Paths used for glyphs must bind their Fill/Stroke as needed to the current foreground.
Steps to reproduce the bug

Steps to reproduce the behavior:

Put this code in a Window's XAML content:

<Button>
    <Button.ContentTemplate>
        <DataTemplate>
            <StackPanel>
                <Rectangle Width="16" Height="16" Fill="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=Foreground, Mode=OneWay}" />
                <TextBlock Text="Not updated" Foreground="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=Foreground, Mode=OneWay}" />
                <TextBlock Text="Updated" />
            </StackPanel>
        </DataTemplate>
    </Button.ContentTemplate>
</Button>
<Button Content="Click me" Click="Button_Click" />

Add this code-behind:

private void Button_Click(object sender, RoutedEventArgs e) {
	((FrameworkElement)this.Content).RequestedTheme = ElementTheme.Dark;
}

I'm assuming your app starts in Light theme.  If not, add RequestedTheme="Light" to your application.

Run the app and observe the left button's Rectangle/TextBlocks all use a black brush.

Click the right button ("Click me") to toggle to Dark theme.  Observe that only the left button's bottom TextBlock's foreground updated.

Hover the mouse over the left button and move it out of the button.  Observe that now the Rectangle/TextBlocks all properly use a white brush.

Expected behavior

It shouldn't be necessary to hover over the button in step 6 to get it to update the brushes synced up to the new theme properly.  All 3 controls in the DataTemplate should have their foreground updated properly after step 5.
Screenshots

Before:

After step 5:

After step 6:

Version Info

NuGet package version:

Microsoft.WinUI 3.0.0-preview4.210210.4 - Couldn't text preview5 yet due to a bug.

Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Foreground is a propogating property.  This means that the actual value of Button.Foreground in the property system is null, however the system treats this property in a special way and when it sees null it interprets that as the value of the nearest ancestor which has a non-null value.  I suspect what is happening is that the propagation logic is somehow missing this binding, which seems like a bug.  I think you could work around this by directly setting the foreground property on your button, either by setting it to a theme resource or binding it to one of its ancestors.

@MikeHillberg to make sure I'm not making stuff up about the propogating property.

@StephenLPeters - Even if I change my Button in the XAML to this, there is no change in behavior for the Foreground bindings within the DataTemplate:
<Button Foreground="{ThemeResource ButtonForegroundThemeBrush}">

We really need this bug resolved since some Path-based icons in buttons will use Strokes and others will use Fill, and they must bind to the foreground color somehow.  This works fine until a theme change occurs, and which time they aren't refreshing themselves properly until forced via something like a Button state change.  Then they work fine from that point on again.  I'm showing the bug with a Rectangle in the sample above, but in a real usage scenario, Path would be used for an icon.
Somewhat related and coming from a WPF background, I miss the ability to set the various TextElement attached properties (Foreground, FontFamily, FontSize, FontWeight, etc.) at any level in the XAML hierarchy (like on panels) and know it would inherit down properly.  In UWP/WinUI, those properties only seem to only be supported on Control, which is limiting in cases like this one where in WPF, I would have bound the Path.Fill/Stroke to the Path's TextElement.Forground instead.

I see the binding updating correctly when in a ControlTemplate, but not when in a DataTemplate. The same issue repros in system XAML.
Until this is fixed, you can use a workaround like this, which switches to an ElementName binding with an intermediate UserControl:
                    <UserControl x:Name="bindSrc">
                        <StackPanel>
                            <Rectangle Width="16" Height="16" Fill="{Binding ElementName=bindSrc, Path=Foreground, Mode=OneWay}" />
                            <TextBlock Text="Now updates!" Foreground="{Binding ElementName=bindSrc, Path=Foreground, Mode=OneWay}" />
                            <TextBlock Text="Updated" />
                        </StackPanel>
                    </UserControl>


Error: ...no extension able to load the configuration for "knp_doctrine_behaviors"

Following error occurs when use "knp_doctrine_behaviors" in config.yml file.
...no extension able to load the configuration for "knp_doctrine_behaviors" ...
error resolves with "doctrine_behaviors".

the same. Symfony 2.6.3. strange earlier work well

did you register the bundle accordingly?

Now all is ok. I have updated doctrine/orm


[Snyk] Upgrade @popperjs/core from 2.11.6 to 2.11.7

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @popperjs/core from 2.11.6 to 2.11.7.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2023-03-24.

Release notes

Package name: @popperjs/core

2.11.7 - 2023-03-24Bug Fixes

fix: Use correct window to get the devicePixelRatio #2229

2.11.6 - 2022-08-11

    from @popperjs/core GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


evaluate glide for vendor

Many CoreOS projects are already using glide for its vendoring: torus, dex, clair, etcd-play, dbtester, etc..
And other projects as well:

https://github.com/Masterminds/glide/issues/300 (Kubernetes)
https://github.com/coreos/docs/issues/775

From my personal experience:
Pros.

works well with go tip (godep doesn't work with go tip, failing to parse go version string)
feels easier to update (edit glide.lock and glide install)

Cons.

still early in development
test files are included in vendor (seems like this will be fixed soon)
in the meantime, repo size with glide could be bloated

Almost every contributor to etcd had trouble with godep when introducing a new dependency, if I remember correctly. It might be worth trying out.
/cc @xiang90 @heyitsanthony
What do you think?

To remove test files, and non-code files form vendored deps: https://github.com/sgotti/glide-vc

Cool. Will check that out. Thanks!

Got it to work, but glide doesn't work well with symlinks. On Linux, writing symlinks back to root directory works ln -s cmd/vendor/ . && ./build, but not sure if we want to do that.
For future reference:
##################################################
# converting Godeps to glide
cd $GOPATH/src/github.com/coreos/etcd/
mv cmd/Godeps .
rm -rf cmd/vendor
mv cmd/ ./.cmd

glide init

glide update --strip-vendor --strip-vcs --update-vendored
glide vc --only-code --no-tests

mv ./.cmd ./cmd
mv glide.lock ./cmd
mv glide.yaml ./cmd
mv vendor/ ./cmd

##################################################
# update gRPC dependency
vim $GOPATH/src/github.com/coreos/etcd/cmd/glide.yaml
# change version to:
# e78224b060cf3215247b7be455f80ea22e469b66

cd $GOPATH/src/github.com/coreos/etcd/
./scripts/updatedep.sh
# OR
./scripts/updatedep.sh github.com/dustin/go-humanize

##################################################

#!/usr/bin/env bash

# A script for updating godep dependencies for the vendored directory /cmd/
# without pulling in etcd itself as a dependency.

if ! [[ "$0" =~ "scripts/updatedep.sh" ]]; then
	echo "must be run from repository root"
	exit 255
fi

GLIDE_ROOT="${GOPATH}/src/github.com/Masterminds/glide"
GLIDE_SHA="23f6a9d8e774f597faabae8b58b8c6020b3f79ef"
go get -u github.com/Masterminds/glide

pushd "${GLIDE_ROOT}"
	git reset --hard "${GLIDE_SHA}"
	echo "installing glide"
	go install
popd
echo "installed glide"

rm -rf vendor
mv cmd/glide.lock glide.lock
mv cmd/glide.yaml glide.yaml
mv cmd/vendor vendor

if [ -n "$1" ]; then
	echo "glide update on $(echo $1)"
	glide update --strip-vendor --strip-vcs --update-vendored $1
else
	echo "glide update on *"
	glide update --strip-vendor --strip-vcs --update-vendored
fi;

echo "removing test files"
glide vc --only-code --no-tests

mv glide.lock ./cmd
mv glide.yaml ./cmd
mv vendor ./cmd

echo "Done!"

##################################################

Yeah, symlinks will screw glide up, a lot. You'll need to avoid that if possible.

Folks... if there is a problem with symlinks it's a bug. We should fix that on Glide.
Note, I write glide so I'm happy to help get any symlink bugs fixed.

@mattfarina Thanks! I will give another try sometime next month. And keep you updated.

@mattfarina I reported the issue that etcd is facing here https://github.com/Masterminds/glide/issues/546
Thanks!

Closing via https://github.com/coreos/etcd/pull/6163.
If anybody is interested, this is the commands that I used:
# converting Godeps to glide
cd $GOPATH/src/github.com/coreos/etcd
rm -rf ./vendor
rm -rf ./cmd/vendor

# temporarily move directory
mv ./cmd/Godeps .
mv ./cmd ..

# initialize with glide
glide create

# remove legacy Godep directory
rm -rf ./Godeps

# into vendor directory
glide --verbose update --delete --strip-vendor --strip-vcs --update-vendored --skip-test
glide vc --only-code --no-tests

# move back cmd, vendor directories
mv ../cmd ./cmd
mv ./vendor ./cmd/

# glide doesn't play well with symlink
# need to recreate symlink that was created by godep
rm -f $GOPATH/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd
ln -s ../../../../ cmd/vendor/github.com/coreos/etcd
readlink $GOPATH/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd

# to update dependencies
vim glide.yaml
# edit git SHA
./scripts/updatedep.sh

# to add dependency to vendor
./scripts/updatedep.sh github.com/klauspost/reedsolomon#9b772b54b3bf0be1eec083c9669766a56332559a

This all looks great but I have one question. Why does the vendor directory not live at the top directory of etcd.git?
The build script is such that it can only grab the vendor directory when you choose to build cmd/ (e.g. building etcd and etcdctl yourself.) I use the client library in client/ extensively, and it can't benefit from the vendored dependencies in cmd/. Instead, i have to make them available manually in my workspace.

@joshk0 that's the exact reason. the etcd team doesn't want the client library to pull use the vendor directories within etcd since it's a library.

But isn't there a specific version of each dependency that the library modules are designed to work with? Or should I assume that the latest released version of each one should work? What's the convention here?

@joshk0 cf. https://github.com/coreos/etcd/issues/4913 if you're interested in the discussion around putting vendor in the repo root. Things break.


It doesn't work at all

Unity 2018.3.4f1
No plugins

Ok. It doesn't work on classes marked as [Serializable] and on scripts that have [CustomEditor] even with base.OnInspectorGUI() and DrawDefaultInspector()

Unity is too bad with these serializations shit

It is implemented by replacing the default Unity Inspector. This means that if you have any custom editors, NaughtyAttributes will not work with them. All of your custom editors and property drawers are not affected in any way
Okay :(

@dbrizov No way to workaround this?


docker build fails

docker-compose build --no-cache fails to build due to numpy=0.1.17 issues (more info here).
Fix seems to be, in Dockerfile: RUN CFLAGS='-std=c99' pip3 install . --no-binary numpy -t $PACKAGE_PREFIX -U
Alternative solution is to force an earlier numpy version (e.g. 0.1.16).
Happy to make a PR if either option looks good to you.

sorry @phloem7 I've seen the notification.
we need to add CFLAGS="--std=c99" in the env to overpass this.
ref: https://github.com/numpy/numpy/issues/14147

thanks for the issue @phloem7 I'll fix this

closed by d24ec71284ab


Fix typos

Found via codespell -S ./static -L nam

Looks good to me 👍

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


I'm sorry if I'm rude but, how about transferring this rbczmq project to @Seluxit ?

Hello @methodmissing
I'm kojix2, a contributor to IRuby (Ruby kernel from the Jupyter project.)
IRuby support rbczmq. But we are now discussing whether IRuby should stop supporting rbczmq, because it has stopped updating. No new release and people stop using it. It is sad that the project is suspended.
But, I found that rbczmq continues to be maintained in the following repositories by @AndreasBomholtz and @tsvetomir-ivanov.  (@Seluxit )
https://github.com/Seluxit/rbczmq
I'm sorry if I'm rude but, how about transferring this rbczmq project to @Seluxit ?
I mean I will be happy if a new version of the rbczmq Gem is released.
Thank you.

Replied in https://github.com/SciRuby/iruby/issues/259#issuecomment-548786448

Thank you for your comment. I will close this issue in about a week.

@neumanrq @seluxit @methodmissing Guys, thanks fo your effort, but the last part is not in Ruby spirit. Let's not stumble upon administrative issues, the procedure is simple:

the new maintainers (@Seluxit?) will rename their fork to czmqrb (or whatever) and start version numbers from the same point
the old maintainers (@methodmissing?) will place the deprecation announcements with pointers to the new gem/repo in README, gemspec, wherever applicable
the users (@costa) will happily install the new gem at their own risk and get on with it

FYI, my workaround — thankfully, I use this only for specs — is downgrading to Ruby 2.2(!) and using gem 'rbczmq', '~> 1.7'. It's a pity that a solid piece of integration software lags behind for Ruby.


[feature request] Logging level for C++ lib

How can I set the logging level of the C++ code lower?
I would like to not see:
src/operator/././../common/utils.h:416: Optimizer with lazy_update = True detected. Be aware that lazy update is different from standard update, and may lead to different empirical results. See https://mxnet.incubator.apache.org/api/python/optimization/optimization.html for more details

[22:47:34] src/nnvm/legacy_json_util.cc:209: Loading symbol saved by previous version v0.8.0. Attempting to upgrade...
[22:47:34] src/nnvm/legacy_json_util.cc:217: Symbol successfully upgraded!
[22:47:37] src/operator/nn/./cudnn/./cudnn_algoreg-inl.h:107: Running performance tests to find the best convolution algorithm, this can take a while... (setting env variable MXNET_CUDNN_AUTOTUNE_DEFAULT to 0 to disable)

[22:46:59] src/io/iter_image_recordio_2.cc:170: ImageRecordIOParser2: ./data/caltech.rec, use 4 threads for decoding..

@cjolivier01 Any idea how to set the logging level?
Also could you please add labels-
C++, Question

Please post your question on https://discuss.mxnet.io/

It is actually not possible, please add Feature Request flag

This seems to be related to MXNet backend feature request where there is a need to control logging level of runtime. @nswamy, in an effort to better label issues, could you please update labels on this one: add "Backend" and remove "C++" labels? Thank you!


Run tests for merging main to feature/azure spring cloud 4.0 branch

As title.

API changes have been detected in com.azure:azure-security-keyvault-keys. You can review API changes here

/azp run java - spring - tests


Add some coverage to BaseService + export directly

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 00dbf53416a7ce824c5ef5d99379e7ba97ebb904


java - a generic method to check a JTextComponent is empty or not

Thank you sir, deployed here: https://onelinerhub.com/java/check_if_jtextcomponent_is_empty


multiple files install with scoop?

Hi
Can we install multiple files with scoop? for example
scoop install aria2 sublimation
or can we install from the folder? for example
scoop install /myfolder/*.json
this way I'll upload all the json files

Can we install multiple files with scoop?

Sure, scoop install aria2 sublimation should work fine :slightly_smiling_face:

or can we install from the folder?

That works too (if your shell expands the glob), but I'd recommend using the bucket approach to benefit from update checks.

it can be tedious to load long files like this one by one.

You are using PowerShell so could always fall back to something like this:
Get-ChildItem | ForEach-Object { Invoke-Expression "scoop install $($_.BaseName)" }

would you consider adding this as the default feature ? @r15ch13


SIP: CloudEvents HTTP for spin SDK

Signed-off-by: Jiaxiao Zhou<EMAIL_ADDRESS>

Related to #394

I have restricted the scope of this SIP to only implement spin SDK that adapts CloudEvents http binding, per our discussion at the community meeting. @radu-matei @lann

Some interestings future SIPs are

generic and portable CloudEvents component
adapter component
Kafka trigger

@Mossaka I did a small write-up for my thoughts around CloudEvents in Spin in https://github.com/fermyon/spin/issues/394#issuecomment-1122839325, let me know what you think.

I will update the SIP to reflect on the discussion on #394 .
In particular, the implementation of CloudEvetns "feature" is quiet large, and I want to break it down to several small SIPs.


Initial Spec

This implements some initial spec to work through the hooks model.
The spec text here is based to the source phase imports proposal specification, performing a new diff on top of that. More spec text than is needed is included while we work through the integration points.
This currently implements:

Converting the HostGetModuleSourceName hook into a HostGetModuleSourceRecord hook.
Support for dynamic import of a module source, using an instance check and the new host call. In addition a new error is thrown if the realms do not match, and this seems like it sets a good precedent for future concepts of compartments matching. This came together relatively simply in the model.
Implementation of GetModuleSource for a Source Text Module Record, which also includes now an explicit [[ModuleSource]] slot to cache this on cyclic module records, now that we actually have a valid implementation.
Support for a new ModuleSource builtin object extending abstract module source
Spec machinery for AbstractModuleSource.prototype.metadata, adapted from the previous AbstractModuleSource.imports and exports. This was easier to implement since we do not have exports metadata at all at compile time, while this information is easily available before linking for all concrete cyclic module records. I also added topLevelAwait to this metadata as that was also easy to provide as well.

One slightly weird thing about the hooks model is that HostGetModuleSourceRecord applies to BOTH the local ModuleSource and other types of module source, so there's wording saying "if it's a ModuleSource, it must conform to the abstract operation for ModuleSource that uses the [[SourceTextModuleRecord]] internal slot". I think that gets us the right flexibility but feedback ensuring clarify here would be very welcome.
Hopefully this forms a good initial skeleton of the hook model further feedback and discussion.
Rendered Spec: https://guybedford.github.io/proposal-module-instance-imports/build/

@nicolo-ribaudo I think this spec text is finally ready, I'd be really grateful if you could review when you have a moment.


CB-9270 Upscale operation was not functioning

The setHostName method was introduced but was semantically incorrect:
it took the first group's first instance's hostname in any case.
As it turned out, setting the hostname on GCP's Instance object is not
necessary.
Manually tested repair and working fine without this.

@bergerdenes I have a different proposal that does not break FreeIPA creation https://github.com/hortonworks/cloudbreak/pull/9359


prioritizesVideoDevices

@dylancom, I added optional prioritizesVideoDevices property (https://developer.apple.com/documentation/avkit/avroutepickerview/3182882-prioritizesvideodevices?language=objc) to prioritise video airplay icon over audio.

@serge-sky Thanks for your contribution!


Remove unnecessary clearing of std::error_code in lsvast

:notebook_with_decorative_cover: Description

Problem:

std::error_code value is cleared explicitly unncessarily. It is not
necessary since the call to std::filesystem::is_regular_file in the
case above when the path is a directory already clears the
std::error_code in the case of no errors.

Solution:

Do not clear the std::error_code explicitly.

:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

@tobim

We can safely merge this I think.


No module named 'custom_nodes.DTGlobalVariables' error

I always get an error when loading
init.py", line 3, in
from custom_nodes.DTGlobalVariables import variables
ModuleNotFoundError: No module named 'custom_nodes.DTGlobalVariables'

It shouldn't be importing like that, there, it's not a valid path. maybe if \custom_nodes\ was on PATH but still.
To work around it the cheep and dirty way for anyone lookin' is to edit the init.py and chance
from custom_nodes.DTGlobalVariables import variables to
from . import variables

It's not working.
Traceback (most recent call last):
  File "D:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1735, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\DTAIComfyVariables\__init__.py", line 3, in <module>
    from . import variablesvariables
ImportError: cannot import name 'variablesvariables' from 'DTAIComfyVariables' (D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\DTAIComfyVariables\__init__.py)

Cannot import D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\DTAIComfyVariables module for custom nodes: cannot import name 'variablesvariables' from 'DTAIComfyVariables' (D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\DTAIComfyVariables\__init__.py)

The error is cleared by making the following change to line 3:
- from custom_nodes.DTGlobalVariables import variables
+ from custom_nodes.DTAIComfyVariables import variables

However, the nodes themselves are not displayed on the field. They are available in the menu, they are available in the search, but selecting them adds nothing.


Added GH Actions workflow to replaced AppVeyor script

This PR addresses issue #87 to move the AppVeyor script to GH Actions.
Issue:
The _unittest_common_usage_errors test fails on the Windows 2019 runner. It appears to be a problem with the test. Logs can be found here. The runner has been commented out of the workflow file until this is resolved.

Same issue here, see PyCyphal


Add RealEstateCore alignment

This is our copy of the alignment file stored at https://github.com/RealEstateCore/rec/blob/master/alignments/BrickSchema.rdf . The alignment was co-developed by members of the REC team and Brick team and may change over time. This is a vetted first cut

@jbkoh the alignment here is the produce of several rounds of communication with the REC folks. Its a fairly minimal alignment, but let me know what you think and if you think we missed anything

@gtfierro Thanks for this integration. It looks very useful. We could come up with actual apps with it later as a showcase of how Brick can work with other ontologies for data integration. Of course, the apps alone will be super useful too!
I will take a deeper look tomorrow, but some questions/suggestions at a glimpse.

Some questions to understand the alignment. I will pick a snippet as an example:

brick:Boiler owl:equivalentClass [ owl:intersectionOf ( rec-core:Device [ a owl:Class,
                            owl:Restriction ;
                        owl:hasValue rec-device:Boiler ;
                        owl:onProperty rec-device:hasDeviceFunctionType ] ) ] .

- I looked at REC, but they don't have `rec-device:Boiler`. Are we creating classes for representing `DeviceFunctionType`? Shouldn't REC define those terms on their side as well? Are they going to do it? Otherwise, it doesn't make sense to use their namespace.
- I see that we use Boiler for both Device and DeviceFunctionType at the same time even though they are under different namespaces. Their names are equivalent, which means that there are overlapping concepts that we did not clarify between Equipment and DeviceFunctionType. Could you explain why such differentiation is necessary?

Take the above as my questions. I strongly believe you and REC team got across those issues.

I would like to put the REC generation part into a separate script outside generate_brick.py.  We will have other integrations in the future and cannot put all of them into the single file.

It'd be useful to have a couple of example queries in alignments/rec/README.md to show how Brick/REC integration is useful.

I looked at REC, but they don't have rec-device:Boiler. Are we creating classes for representing DeviceFunctionType? Shouldn't REC define those terms on their side as well? Are they going to do it? Otherwise, it doesn't make sense to use their namespace.

It's defined here; it may not be in the latest documentation online but it is part of REC and I expect it will be published on their documentation page soon. We aren't creating classes other than the anonymous owl:Restriction classes. Does that address your other questions here?

I see that we use Boiler for both Device and DeviceFunctionType at the same time even though they are under different namespaces. Their names are equivalent, which means that there are overlapping concepts that we did not clarify between Equipment and DeviceFunctionType. Could you explain why such differentiation is necessary?

This is because of how REC models equipment. A rec-device:Boiler is a DeviceFunctionType, not an equipment. A rec-core:Device is a broad class for many points/equipment in REC. They differentiate between different pieces of equipment in terms of their function. Hence, the equivalency here

I would like to put the REC generation part into a separate script outside generate_brick.py. We will have other integrations in the future and cannot put all of them into the single file.

This is already the case. I haven't merged them into Brick.ttl because its not clear we want the alignments in the base distribution by default. I'd rather merge the alignments in now and figure out how to package it up later

It'd be useful to have a couple of example queries in alignments/rec/README.md to show how Brick/REC integration is useful.

A great idea, and maybe the subject of a future PR? We'd need models that cross both ontologies, which is in the pipeline, but not immediately ready. Having the alignment done is the first step

This is because of how REC models equipment. A rec-device:Boiler is a DeviceFunctionType, not an equipment. A rec-core:Device is a broad class for many points/equipment in REC. They differentiate between different pieces of equipment in terms of their function. Hence, the equivalency here

rec-core:Device is defined as "A thing made or adapted for a particular purpose, specifically a piece of electronic equipment". It reads as Boiler should be an instance or a subclass of Device, which has BoilingFunction or BoilerFunction. I have no control over their design, but this will cause a lot of confusion later.
Another example: they give an example subclass of Device as Sensor too. The current names for Boiler are like Sensor hasDeviceFunction Sensor.

A great idea, and maybe the subject of a future PR? We'd need models that cross both ontologies, which is in the pipeline, but not immediately ready. Having the alignment done is the first step

Though I can imagine that this is going to be useful, I'd rather have a general procedure to understand the use cases first before accepting anything in our core repo. However, I also have no strong opinion on generally hosting any ontology integrations if you are thinking in that way.

rec-core:Device is defined as "A thing made or adapted for a particular purpose, specifically a piece of electronic equipment". It reads as Boiler should be an instance or a subclass of Device, which has BoilingFunction or BoilerFunction. I have no control over their design, but this will cause a lot of confusion later.

You should take it up with the REC folks if you really have issues with it, but keep in mind that their model just has a different perspective on these systems than we do. The intuition isn't too bad though: A Brick Boiler is equivalent to a REC Device whose function is that of a boiler. I don't think there's a simpler way of encoding that equivalence than what I have here.

Though I can imagine that this is going to be useful, I'd rather have a general procedure to understand the use cases first before accepting anything in our core repo. However, I also have no strong opinion on generally hosting any ontology integrations if you are thinking in that way.

Are you arguing that including an example is a prerequisite for including ontology integrations in the repo? I agree they're important, and we will definitely add them, but I want to get the alignment merged first. Developing the examples will take time.

You should take it up with the REC folks if you really have issues with it, but keep in mind that their model just has a different perspective on these systems than we do. The intuition isn't too bad though: A Brick Boiler is equivalent to a REC Device whose function is that of a boiler. I don't think there's a simpler way of encoding that equivalence than what I have here.

I thought you hinted them at using Brick Boiler as DeviceFunction there. If rec:Boiler is a rec:Device, we can simply add
brick:Boiler rdfs:subClassOf rec:Boiler

Or, more aggressively, though we have to check whether there are conflicting properties or not,
brick:Boiler owl:equivalentClass rec:Boiler

Anyway, if you don't have any control over their vocabulary, please don't bother. I am fine with the current one.

Are you arguing that including an example is a prerequisite for including ontology integrations in the repo? I agree they're important, and we will definitely add them, but I want to get the alignment merged first. Developing the examples will take time.

I could easily agree on your PR, but why is this so urgent?

Correct: if they had direct class corollaries then the mapping would be much more direct. This is the case for some of the classes in the mapping, but not in the case of devices.
I'm trying to get this merged  (a) as a show of solidarity with the REC folks putting their own mapping up, and (b) because I want to move on to other tasks that can potentially build off of this. Keeping this PR open achieves neither of these things

okay, I am fine with this PR.

Thanks! It's definitely important to include examples of REC + Brick together. I hope to assemble some in the coming months

@jbkoh can you hit "Approve" on the PR when you get a chance? It doesn't complete the Travis merge tests until that's done, I think


[Not an Issue] Compilation of Sites that work/might work with CarStream

I have unlimited data so I've been using plex with my own server.  I'm thinking we should compile a list of websites we can bookmark to use along with CarStream. Here is a site that might work. Haven't tried it yet.
http://yifymovies.tv/

i use https://yifymovies.org/ with CarStream and it works perfectly ! try it out .


rds: DBCluster writeConnectionSecret missing fields

Similar to the issue reported and fixed here: https://github.com/upbound/provider-aws/issues/442
The RDS Cluster resource does not write the username or port field to the connection secret by default and is no configurable via publishConnectionDetails.
What happened?
Connection secret gets written with only these fields:
attribute.master_password
endpoint
reader_endpoint
How can we reproduce it?
Create an RDS cluster resource (and cluster instances) and check the connection secret.
What environment did it happen in?

Universal Crossplane Version: v1.11.0
Provider Version: v0.29
Cloud provider or hardware configuration: AWS m6i.xlarge nodes
Kubernetes version (use kubectl version): v1.24.8-eks-ffeb93d
Kubernetes distribution (e.g. Tectonic, GKE, OpenShift): EKS
OS (e.g. from /etc/os-release): Amazon Linux 2
Kernel (e.g. uname -a): N/A

good starting point is the following commit for aws_db_instance: https://github.com/upbound/provider-aws/commit/a36dba4765886009d7ca259529af1be76645540e to add a contribution ;)

Fix: https://github.com/upbound/provider-aws/pull/703


Progressive Web App

Is your feature request related to a problem? Please describe.
I use that app to use my vim on browser and sometimes I must use Ctrl+W but browser wants to close the page in that situation.
Describe the solution you'd like
Adding PWA feature will allow us to send this key binding.
Additional context
Here how we can do it;
It seems simple

As a workaround, you can install one of these web extensions: Better ctrl-w or Disable keyboard shortcuts.


nand flash ,when bad block at 0 or 1,littlefs don't work

// can't relocate superblock, filesystem is now frozen
if (lfs_pair_cmp(dir->pair, (const lfs_block_t[2]){0, 1}) == 0) {
LFS_WARN("Superblock 0x%"PRIx32" has become unwritable",
dir->pair[1]);
return LFS_ERR_NOSPC;
}

Hi zbqxyz,
I have a same or similar problem and  yes, if problem is in 0,1 block then fails with LFS_ERR_NOSPC that is clear, if it is a bug or not I can't say.
Yesterday I started work on "Flash driver"  but I'm hanging there, on same problem as you, but I found that block isn't really damage, I will try to explain: raw writen data are matching with read data. But problem comes from CRC computation.
Here is my setup:
Flash_Erase_WHOLE_Chip();

	if(lfs_mount(&lfs, &cfg) != LFS_ERR_OK)
	{
		if(lfs_format(&lfs, &cfg) != LFS_ERR_OK)
		{
			__asm("nop"); // serious problem there ...
		}
	}

when chip is erased I'm not able to mount (of course) and flash need to be formated, but then fails on: LFS_ERR_NOSPC (traced). When I read raw data from Flash mem after failed lfs_format then I saw that address 0x00 contains value 0, rest of them was OK. Then I expected problem in driver, one dummy byte more is transfered during read process. As a solution I read one byte more (shifted first byte out), then I was able to sucessfully format Flash chip. After suceesfull format process was expected perfect function of "fs_mount"  but it failed again (CRC computation ).
When flash was formated coretly and Flash_Erase_WHOLE_Chip() was comented out. then I removed "read extra dummy byte" from flash and then I was able to mount the flash ...
I just started to find out this problem then I can't say something exact but tomorrow I will check if "lfs_format" giving right data to driver becasue all bytes in buffer from (lfs_format seems to be shifted to right side  byr one byte.
Please checkif is it also your problem....

Hi zbqxyz,
I have a same or similar problem and yes, if problem is in 0,1 block then fails with LFS_ERR_NOSPC that is clear, if it is a bug or not I can't say.
Yesterday I started work on "Flash driver" but I'm hanging there, on same problem as you, but I found that block isn't really damage, I will try to explain: raw writen data are matching with read data. But problem comes from CRC computation.
Here is my setup:
Flash_Erase_WHOLE_Chip();

	if(lfs_mount(&lfs, &cfg) != LFS_ERR_OK)
	{
		if(lfs_format(&lfs, &cfg) != LFS_ERR_OK)
		{
			__asm("nop"); // serious problem there ...
		}
	}

when chip is erased I'm not able to mount (of course) and flash need to be formated, but then fails on: LFS_ERR_NOSPC (traced). When I read raw data from Flash mem after failed lfs_format then I saw that address 0x00 contains value 0, rest of them was OK. Then I expected problem in driver, one dummy byte more is transfered during read process. As a solution I read one byte more (shifted first byte out), then I was able to sucessfully format Flash chip. After suceesfull format process was expected perfect function of "fs_mount" but it failed again (CRC computation ).
When flash was formated coretly and Flash_Erase_WHOLE_Chip() was comented out. then I removed "read extra dummy byte" from flash and then I was able to mount the flash ...
I just started to find out this problem then I can't say something exact but tomorrow I will check if "lfs_format" giving right data to driver becasue all bytes in buffer from (lfs_format seems to be shifted to right side byr one byte.
Please checkif is it also your problem....

It should be a driver problem, you try to detach the littlefs, test whether the driver block read and write correct

Hi,

It should be a driver problem, you try to detach the littlefs, test whether the driver block read and write correct

Yes, that was driver, I didn't believe it was broken littleFS. The problem was crazy DMA - the DMA transfer request was hanging and then read the first "dummy" byte immediatelly after the stream was enabled. But that is happen only if another DMA transfer has beed made before... Also it never happened when I debugged by stepping, then all blocks were Written&Read correctly when I stepped the memory driver.  - Thank you STM32F4 with SPI and DMA2 for nice spend 4 hours 😄  -
Anyway thank you ...
Maybe we should delete my previous post becouse it has nothing to do with the issue opened by you.

nand flash ,when bad block at 0 or 1,littlefs don't work

I also encountered this problem and it seems to be done that way by design. If you look at the badblocks test (test_badblocks.toml) right in the first test, bad blocks are evaluated one by one and the first 2 are skipped.
This makes me wonder... what would happen if during a normal use the first or the second block would be corrupted?

nand flash ,when bad block at 0 or 1,littlefs don't work

I also encountered this problem and it seems to be done that way by design. If you look at the badblocks test (test_badblocks.toml) right in the first test, bad blocks are evaluated one by one and the first 2 are skipped.
for (lfs_block_t badblock = 2; badblock < LFS_BLOCK_COUNT; badblock++) {
This makes me wonder... what would happen if during a normal use the first or the second block would be corrupted?

i test when bad block at 0/1,relocate block return below err
// can't relocate superblock, filesystem is now frozen
if (lfs_pair_cmp(dir->pair, (const lfs_block_t[2]){0, 1}) == 0) {
LFS_WARN("Superblock 0x%"PRIx32" has become unwritable",
dir->pair[1]);
return LFS_ERR_NOSPC;
}