Feature request: Render the text of the references inline

EDIT: I just saw your recommendation to use page preview and hover editor to enable this functionality. I think that’s a great workaround, and it definitely reduces the need for this feature. But I still think this would be useful. The text of the reference contains the all-important reason for the connection between the pages. Having all of that info immediately available and visible, so you can scan through it, would make a big difference in the user experience. Right now you have to click on the SNW reference count, then hover over each reference in turn. That isn't a bad experience, but it's just not quite as good as, for example, the backlinks section, or Roam's inline reference view (probably the inspiration for the plugin). Finally, this would radically improve the experience on mobile, which doesn't have hover editor.
ORIGINAL POST:
First of all, I want to thank you so much for making this plugin!!
Honestly, this is one of the best plugins I have (and I’ve tried out over one hundred). In fact, I think the devs should incorporate this functionality natively because it is so important to the goal of surfacing connections.
Also, I saw you were involved with Roam42, which means you made the most useful plugins I had when I used Roam. And then you made this plugin, which helped convince me to switch from Roam to obsidian! So thanks very much, I really appreciate your work :).
Anyway, on to my actual message.
I'm sure you've thought of this already, but it would be amazing to be able to see the text of the references inline.
This plugin gets me halfway there in terms of surfacing new connections and helping me to find / revisit helpful info. But when the list merely shows the file name, I get some info from that, but to really see what the connection is about I need to read the block. And to do that, I have to click on each link individually, which is tedious. And so in practice I end up not doing that.
This problem is exacerbated when the reference is from a daily note. Because in that case the file name is merely a date, which provides very little context as to what the connecting idea actually is.
I know that adding the text of each reference could potentially clutter things, but that can be mitigated. For example, it could potentially be set up to only show the references' text when the user clicks on a button. Perhaps one button per reference if you want to toggle it for just that reference, and also an "expand / collapse all" button at the top.
Thank you so much, again, for all the amazing work. I can't wait to see where this plugin goes!

I completely agree with you. I will see if I can solve this, but the issue is that Obsidian treats embeds as something unique. I am passing the block from the page to the standard "markdown rendering" API, however, Obsidian returns everything but the block embeds as rendered text.
But I agree and will keep an eye on how to solve this, if possible.
Very thankful for your writing this detailed description and also beta testing. Keep the feedback coming. This plugin is the hardest I have ever developed. It looks simple on the surface, but obsidian's internals for this kind of thing is hard to navigate.

Of course! I think this plugin is honestly one of the best I've used. I also find it to be extremely fast and completely stable. I think there are a ton of people who would find it to be really useful, so I personally would advocate releasing it through the community plugin marketplace. I think it would not only be super useful for others, but would also show people how powerful some of the "Roam-like" features are. I've noticed that there seems to be a contingent of people who perhaps are more used to traditional markdown or notetaking apps, and who seem to object to most block-based or metadata based features, but I suspect they've just never seen something like this.
In terms of stability, I actively use over 50 plugins, and have not had any interference or other issues. So I really don't see a downside to wider release.
Of course that's just my humble opinion, and more than anything I'm just personally thrilled this exists!!

Separately, it looks like you did this with a hover view!! And it is awesome!
Two small thoughts regarding this feature.

I would enlarge the hover popup and reduce the text size so you can see more links and more context.
This is more of a feature request, and I'm sure it's not trivial at all. But it would be incredible to be able to filter the references using something like the search feature in the backlinks pane. I have a lot of thoughts about what this search would ideally look like, and I can share those if you're interested. But the tldr version is that any search would be great, but ideally it would be possible to search based on

File path
Page metadata (like tags, links, text etc anywhere on the page of the linking reference).
Block text and tags (tags and text present in the block that made the link)

Also more of a feature request, but it would be awesome to be able to see more context for each reference. Basically, making it more like the backlinks pane would be fantastic. I wonder if there is a way to access a view like that through the API itself?

Let me know if you'd like me to break these out into separate issues/feature requests, btw.
Finally, I don't mean to be demanding by providing all this feedback, just mentioning it since you asked :)
Overall, I really think this is such an incredible plugin, and thanks again for making it. It really is incredible.

On a personal note, I'm curious about your opinion about Roam vs Obsidian. I know this isn't exactly the ideal forum, but not sure where else I'd ask you.
If you worked on Roam42, you obviously have a ton of experience with both.
I started with Roam, and eventually migrated to Obsidian because of the plugin ecosystem and dataview in particular. Plus the userbase and pace of development just seemed to be stronger and improving (whereas Roam's seemed to be declining).
My biggest concern with Obsidian however is that it seems like:

The devs are not inclined to replicate the markdown file contents in a database
They also don't seem super inclined to enhance "block" oriented features (like better transclusion, block references like in this plugin, etc)
The first point means that, despite the existence of Dataview, it's hard to really query and modify the notes programmatically or structurally or using code because the index is limited and the ground truth is not in a structured database, but rather in messy markdown files

I suppose overall there is a level of polish and even extensibility (ironically, because Obsidian's plugin ecosystem is SO much better, but nonetheless it seems that the database infrastructure that Roam has makes more things possible) that Roam has and that I assumed Obsidian would replicate eventually. But now I'm not so sure.
Also frankly I'm concerned about funding, although with 2 devs it seems fairly sustainable. But overall they'll just have FAR fewer resources than Roam when they offer the main product for free.
Of course, there are plenty of wonderful things about Obsidian, and its text-based nature. But those are some of my concerns.
But basically, just curious to get your opinion. As a plugin developer for both, which tool do you think has the potential to be more powerful? Is Roam's plugin system likely to improve? Which tool do you prefer and why?
No pressure to answer any of this btw, just curious!

First, thanks for the praise. We need it. We have put days and days into this and of course its a hobby project. It is one of those things if you knew the upfront cost you wouldn't do, but once you are so deep, there is no turning around. We will release to broad testing audience soon. But we have a few more "low hanging fruit" bugs to fix.
Regarding your ideas, they are great. would you mind submitting individual issues as feature request. This will help us keep up a dialogue and I can track the FR to completion. Love the idea of integrated search. Also been playing with the idea of the size of the hover control. FYI: we intentionally made everything very CSS controllable, so you can really tweak it to your own needs. But it might be nice to put together some working CSS examples that create different effects.
Regarding Roam and Obisidan. All your concerns are valid, but I think things have improved. Obsidian has hired a few devs and already in last month we are seeing a faster rate of updates/fixes. I had the same concern, but now I don't.  Regarding db to markdown, I know the dataview developer is planning in the near future to make dataview queries render to markdown so that people are not dependent on dataview plugin if they want to export content or move away.  Not sure if this addresses your concern.
Feel free to ping me as well on Discord. Really appreciate your testing SNW.

Ah specifically when I mentioned the advantage of a database I was not referring to that making it more or less exportable. I absolutely love dataview and use it all the time, and it absolutely would cover that use case. Not to mention that obsidian is naturally exported since it just lives in markdown files.
What I meant by Roam maybe getting an advantage from being based upon a database is that it likely makes it far easier to enable certain features (either natively or through plugins). For example, better outlining tools, plugins like Smartblocks, native block references, and editable transclusions are certainly theoretically possible in obsidian. And some of those features will probably eventually be added. But it seems to be a lot harder when you're working with markdown files instead of structured data in a database. At least I assume so - I haven't actually gone through the Obsidian API, so I don't know what kind of data structures they give you.
So I guess I should stop here and ask you since you're obviously familiar with the Obsidian API and whatever indexing they do:
Is it harder to read and write note data in obsidian? What about for queries that treat the notes as blocks in an outline (or graph)? As in, not in page level units but rather in block level units (each paragraph, list item, etc).
As I understand it, at least some info doesn't seem to be available in the index. Like the text of a block, except for lists and tasks. Or at least dataview doesn't expose it. And I assume whatever index is available doesn't enable writes.
Maybe I'm assuming incorrectly though? Like if there is an abstraction layer over the notes that basically stores them in a data structure that enables reads and also writes that are synced to the note?

So two things:

I'm not surprised to hear that markdown is more complex to work with than a DB. I guess I was hoping that the Ovsidian API exposed an abstraction layer that handled retrieving the markdown contents with a structured API, handling the edge cases internally. And I thought it unlikely but possible that maybe they even exposed that same abstraction for writes to make it completely seamless for devs. If they did that, I think it would eliminate the disadvantage of not having a DB, except possibly performance considerations.

But sounds like this is not something they have right now? If not that's a little unfortunate. How much harder have you found it to develop for obsidian vs roam?
I also wonder if it would be worth pushing for a data structure or abstraction later like the one I just described. If it would simplify development, it seems like it would really neatly remove all the complexity of dealing with markdown, making file system storage exclusively a benefit.
Finally, it seemed like you closed this ticket saying that you weren't going to tackle it at the moment. But it's already done isn't it? I added two other feature requests but this one was about going from the previous UI that just showed a file and line number for each reference to one that showed the actual text itself for each reference. And that appears to be implemented.
Did you interpret this FR differently?

Regarding this incident, yes its resolved it open since we had a few other things going on in our conversation.
Obsidian has an API that does keep a current cache of most of the interesting things in the markdown, but not everything. It isn't easy to pull from the API as well. The API isn't as easy to work with as with other api's. Roam was easier for some things, but also really hard for some things.
The Obsidian API is actually great to work with for most things, just this block ref count is a unique take on working with markdown. For this a real database would be much easier to work with.
Another challenge of Obsidian is there is an editor and a preview mode, which are both different technologies. So for the counter, we have to repeat the logic twice and in a different format.
I really like your other recommendations for this plugin. I am thinking about how to incorporate them. One issue that comes up in my mind is to avoid repeating what is built in. For example, I can create expanding previews of inline block references. However the hover control with a mouse over the preview renders a hover window with the entire document that can be scrolled. So this is the desired functionality, but chaining together a few features to get to the results. The amount of code and testing verses using something that already we have is what I weigh out.
I would rather spend my time I think on unique features of SNW and tap into existing features.

All makes sense. I hope the obsidian developers prioritize making the API even more convenient and robust, since so much of the functionality is from plugins.
And absolutely no pressure at all to implement any of the FR's if they are too tough or just not your priority. I wanted to give you my feedback since you've made this awesome tool. But I will be thrilled to see any functionality you deliver. And in fact if you have ideas for things that are novel, that sounds awesome!
I guess one small thought, and again, please ignore if it's not useful. But while some of the functionality in the FR's I opened already exists (and I agree is lower priority as a result), it currently isn't easy to see inbound references for things other than pages. Just to throw that out there
But anyway can't wait to see what you end up making!
If you have a backlog of feature ideas I'd be super curious to see it btw. Not in the sense of wondering when things will be implemented but rather to just see what ideas you have. I could see this going in a few interesting directions. I guess my overall conception for it is that it makes it easier to get more "peripheral vision" around the notes.
In the sense that when reading a text file you have no connection to other notes. In a hypertext document you see outbound links one hop away. In obsidian without plugins you have one hop in each direction in the note. Plus the graph view, which adds quite a bit more, but which also has its own limitations (no context for where the links are coming from in particular).
This plugin adds additional peripheral information in two ways:

It shows one hop links to more entities within the note. Yes they would've been in backlinks but seeing the links while reading the note, and also seeing where specifically they go, is useful.
The numbers show some indication about which sections, notes, etc are highly cited.
Finally, and most uniquely, in my opinion, it shows you notes more than one hop away by showing you notes that also linked to the same note or section that you linked to. So you see notes that are indirectly connected. Which I think is a really interesting concept and one that is surprisingly unexplored.

One other plugin also surfaces these indirectly connected notes, but it is super opinionated and requires extensive use of tags in a particular way, which makes it not useful for me at the moment. But it did make me think, so that alone was cool. Anyway in case you find it interesting yourself, the plugin is called "Tag Navigator," formerly "Cross reference navigation."
As an aside, I've been wondering about how to go further with this theme. One thought I have is to feed all of my notes into OpenAI's GPT-3 so that I can then use natural language semantic queries to surface connections that I'd likely miss otherwise. But have not yet gotten around to that. I'm actually shocked that this is not really a thing yet.


JS call to re-enter Kiosk Mode ?

I have asked a specific custom Android from my vendor.   Scenario is :

Kiosk Mode.   perfect   nav bar / status bar /  notification panel not showing AT ALL. PERFECT

in my web/cordova app,  I press a button to exit Kiosk Mode.   I do things like settings,  ....

when I come back to my app,  the kiosk mode is not there anymore.

Is there a KioskPlugin.enterKioskMode() call ?   thanks.  would this be a big deal to add ?  thanks.

Sorry, this is not possible - kiosk mode needs the application to be started as launcher. The kiosk exit call allows to start usual launcher as standard app. Switching which app is launcher is possible only from system apps. (rooted devices, manufacturer signing necessary)


Disable nautilus autoopening folders when sth is mounted

run as a simple user
              # gsettings set org.gnome.desktop.media-handling automount-open false

working on it

working on it

done :)


[BUG] crc and snc don't use the same routes-controller image

snc uses quay.io/crcont/routes-controller:${image_tag}
https://github.com/crc-org/snc/blob/4ada0a93e0e3de2b0fbd328ef43096c7563a7ed9/createdisk.sh#L79-L80
crc uses quay.io/crcont/routes-controller:latest
https://github.com/crc-org/crc/blob/32916615274dab8064a7a99b1de7fb4a063dff22/pkg/crc/machine/start.go#L835-L844
Not sure which one should be changed, the easiest would be to tag quay.io/crcont/routes-controller:${image_tag} as latest when pulling it in snc, but I'm not sure crictl supports setting tags.

I suspect because of this inconsistency crc pulls the routes-controller image at cluster creation.

If the cached image is still the latest one, it's not very important,

inconsistencies like this can lead to hard to track issues. we can't assume these are both pointing to 'latest'. It would be better to use a tag that is identical on both ends.

In case of openshift preset we should use the image tag as openshift_version since we are now building it for each openshift release and for podman preset we should use the latest tag.

This is fixed by https://github.com/crc-org/snc/commit/fe6a6d2ddb68e16942810644173b87b4cc95765a
/close


Facing problem After creating rds with snapshot.

After terraform apply with snapshot, when I am doing terraform plan for second time its giving below error

module.rds_xyz.module.db.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'

Note: I am passing username and password blank, as I am restoring it

Without parameter it will not accept it

@sagar-babar Thanks for raising this issue.
In Terraform 0.11 it is not possible to make arguments optional based on whether it is restoring or creating a database, so you have to pass a password always (it can be random one for the restoration).


Update prototyping_tools.md

Adding in download for XD file

@dlevineBC, it looks like the download attribute in the link tag gets stripped out automatically by GitHub's Markdown parser. I've tried the following suggestions from Stack Overflow on my fork to see if I could get that functionality working:

id="raw-url" in the <a> tag, like what GitHub uses on their Download buttons for files
download and target="_blank" in the <a> tag
type="application/octet-stream" in the <a> tag

All of those get stripped out by the parser, likely by design.
I will merge this as the download attribute does no harm and shows the intent.


Coloring Does Not Support Regular Expression Operation?

It seems that it does not support coloring the regular expression in any language? Here is my code in python:
import re

re.match(r'[\s\S]+\([0-9]{1,2}\.?[0-9]{0,2}-?[0-9]{0,2}\.?[0-9]{0,2}\)[\s\S]*Effective:[\s\S]*', str)

And here is how it looks:

Here is what it supposed to look like in Pycharm theme Material NightowlL:

I tried with other langugage or theme in Carbon but none of them work.
Is it possible for Carbon to support coloring regular expression in the future?

Hey @Williams-Ren — the coloring for each these is up to the specific Codemirror theme authors. Please take it up with the maintainers of those packages, of push a PR with a fix for this yourself. Thanks! 🙂


Add a default value to the parseValue to prevent wrong truthy checks

@jane-rose
If that fix is ok, I will release a new version.
After that we can experiment with the "hiding lines" problem.


github-merge: Always include repo_from in the merge commit message

This adds clarity if a repository is pushed to a new location where the numeric ids have a different meaning or are missing altogether.

Before:

https://github.com/bitcoin-core/gui/commit/83c715415a8886e3e46ef375e042f13d8165dabd

After:

https://github.com/bitcoin-core/gui/commit/cfec4a1dad2181a5471b04f8a7b77ab64293fb13

Code review but untested ACK 3811ce103cff9c0bcda9b26de04c4004d2c231ed

Merged the PR with itself and it worked, so tested ACK now.


Provide a possibility to download old-orthography Russian plays in new orthography

We now start to feature Russian plays in old orthography, the first one being Artsybashev's »Revnost'«. We also just released a Python package which does the conversion: prereform2modern.
@DanilSko suggested to have a cron job that once a day converts the original TEI of old-orthography plays to an additional version in new orthography and make it available through our API. (Doing this on-the-fly when requested will probably be far too costly).
(As inspiration, Deutsches Textarchiv (@cthomasdta) also provides "normalised" (= modernised) text output, e.g. here (see file header for details).)

I have the following questions:

How do we identify documents using the old orthography? Since pre-reform Russian does not seem to have it's own language code, we cannot use the xml:lang attribute.
Would it be safe to pass an entire TEI document to prereform2modern for transliteration or would each text node have to be transliterated separately?

I think, we better create a transliterated version whenever a document changes using a trigger instead of running a cronjob.
It would also be very helpful if the translit command line script provided by prereform2modern would accept a file path as an argument and would return the transliterated document as output. Given that the library is already capable of adding markup that would be a logical next step.

Re 1. True, missing lang code for pre-reform Russian is a problem. A simple solution would be to look for deprecated letters like "ѣ" in the documents. Just did a grep on all files and it works. 😊 Yet it would probably be better to add markup so we can intrinsically tell apart an original xml file from a converted one.
Re 2. I think it's possible to pass an entire TEI doc through the converter. (@DanilSko @nevmenandr?)
Re 3. Agree with the trigger upon changes instead of cronjob.

Yes, store this kind of info properly where it belongs in the teiHeader. I already wanted to warn you that the header in the example file you used is not best practice in any sense.

Thanks for the heads-up, Christian. Then the question would be how to store the info in case of a play in pre-reform orthography next to the general languade code in the root element (<TEI xml:lang="rus">).
(RusDraCor example file in TEI here.)

Sure you could customise @xml:lang and use a #pointer? But maybe I miss your point, will have to check again next week and look at your example. No work to be done outside in the green on a mobile phone...


Custom build fails with npm 3

Cause of the introduction of a flat dependency hierarchy the path of jsdoc has changed.
The problem occurs in tasks/generate-info.js:17.
var jsdoc = path.join(__dirname, '..', 'node_modules', '.bin', 'jsdoc');

needs to be changed to
var jsdoc = path.join(__dirname, '..', '..', '.bin', 'jsdoc');

to work correctly with npm3.
Error message:
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: spawn /Users/mlegenhausen/dev/werk85/dk-navigator-app/node_modules/openlayers/node_modules/.bin/jsdoc ENOENT
    at exports._errnoException (util.js:849:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at doNTCallback2 (node.js:430:9)
    at process._tickCallback (node.js:344:17)

Thanks for the report @mlegenhausen.  Let me know if the change in #4347 resolves the issue for you.  If you have a package.json with openlayers as a dependency, you should be able to test it out by updating your dependency (temporarily) to look like this:
  "openlayers": "git://github.com/tschaub/ol3.git#dc0e37b7823f200c674fb8d5934fd23eba9d2340"

Does this version already contain the fix for node 4? Got the same error as in #4163

@mlegenhausen - the fixes are in separate branches.  So the commit referenced above should work with npm@3 but node < 4.  When I get that merged, I'll rebase the node-four branch so it will contain both fixes.


Update es.json

Hi Tasshack! Apologies for the inconvenience. I realized I mistakenly tried to create a pull request to the main branch. I've updated the Spanish JSON file with more accurate language and am now creating a pull request to the development branch. Thanks for your understanding!

Ok, sorry, as soon as I have it back I'll make a new pull request


Add a note about addon usage

This could have saved me an hour of debugging. It's easy to fall into this trap because if you install this addon using the standard ember install ember-cli-node-assets, it gets added to devDependencies.

Thanks @paulcwatts! In general I think this is a weak point in the overall education around how addons work in the ecosystem, and the fact that ember install silently makes this choice for you doesn't help 🙂


SSL connection Failure

I ran a open connect server on ubuntu. TCP port is 443. when I want to connect to VPN with android open connect App, I get :
-SSL connection failure: the operation timed out
-Failed to open HTTPS connection to server IP
-Error obtaining cookie
-VPN terminated with errors
also I don't have access to internet when I connect to server with windows AnyConnect application. (it connects but have no Internet)

I'm tired, please refer to other issues and google it.
Sorry.

If you solve it, you can leave solution here, so that others can know if they happen to meet the same problem.


App stuck

Launching the app right after the install:

Launching the app after closing the app:

Can you record a log and send it to<EMAIL_ADDRESS>

How do I record a log?

Using MatLog or LogFox, for example

I have the same issue. For me I'm using micro g and no google services. Perhaps this app depends on them? Seeing some errors in LogFox related to micro g. Can you confirmbylu are also using micro g, Rafee-M?

My bad, forgot to send the log file. But yes I have removed gms and am using microg at the moment

I don't think microG manages or even creates the phenotype database. Сlosing for now. You can reopen the issue if I'm wrong.

I've sent the relevant logs to<EMAIL_ADDRESS>As this issue seems to be occuring on more than one device I feel like it's a bug connected to the absence of GMS

Thanks, @Rafee-M! I looked at the log and I think it's impossible to get this to work on MicroG and others like it

Thanks, @Rafee-M! I looked at the log and I think it's impossible to get this to work on MicroG and others like it

I have the same issue on A15 aosp ( Gapps build )
Using Kernel SU


Added AuthInterface implementation for the User.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Yiisoft\Auth\AuthInterface implementation for the User class to use it in Auth middleware.
I'm not sure on naming and having default authUrl predefined.
P.S. Will add tests as soon you give the green light.

https://github.com/yiisoft/yii-web/issues/275#issuecomment-666676216?

I've looked through that issue, but thought it concerns only cookie and session.
If User will be moved to Auth it will also make the auth package to depend on cookie and session packages.
I think User is more specific for yii framework and not overall community as a separate package. I'm not sure on usability of User outside the framework. User implementation is usually strongly coupled to database entity or the code in other frameworks or frameworkless applications, so I see little value in having it there.
What about AccessCheckerInterface in User class in that case?
If the decision will be made to move it to auth package, this can also be moved with it as it is in the same folder.

Would that make AutoLoginMiddleware duplicate functionality?
Should we do something about User::loginByAccessToken() then?

Would that make AutoLoginMiddleware duplicate functionality?
Should we do something about User::loginByAccessToken() then?

I'm not sure how this is supposed to duplicate AutLoginMiddleware functionality. This is AuthInterface functionality for Auth middleware that will be used on route or group of routes to ensure that the user is already logged in based purely on session. AutoLoginMiddleware on the other hand logs in user even if the session is expired based on some cookie. I don't see anything in common.
User::loginByAccessToken must be removed from the User in my opinion. We can have another IdentityInterface implementation and middleware specific for that. And we can have another AuthInterface implementation specifically for that, as it will be used mainly to authenticate API requests and not general user.

Alright. Does it make sense to do point 2 in this pull request?

No, I've drafted all things needed for that in separate issue #304. There are a couple of packages that need to be refined for that (not only yii-web).

👍


Why models perform worse on the 60% identity split LBA dataset than on the 30% split?

Hi,
Thank you for the amazing work!
I am curious about the results in table 8. Why most models (other than GNN) perform dramatically worse in the 60% identity split than in the 30% identity split? Intuitively, the task with 60% split should be easier and achieve better performance as there is more similarity between protein sequences.

Hi, Thank you for the amazing work! I am curious about the results in table 8. Why most models (other than GNN) perform dramatically worse in the 60% identity split than in the 30% identity split? Intuitively, the task with 60% split should be easier and achieve better performance as there is more similarity between protein sequences.

I agree with your theoretical guess. However, not only atom3d but also some other following studies show the similiar phenomenon. For instance, the table below is copied from Multi-Scale Representation Learning on Proteins


Add personalization

Personalization is a simple word that hides a very complex feature. There are many things behind personalization.
First of all, personalization means user identification. It is necessary to know at the time of the search who is doing the query. This does not pass a unique identifier given by the client/integration.
Once we know the user, we need to be able to classify him. This is done thanks to the data available in the index.  And the latest queries/click/views from the user.
Finally, we have to be able to filter/rank in the best possible way so that there is the least need for configuration to start using the feature.

I will close this issue in favor of our public roadmap.
I invite everyone interested in this feature to upvote it on the roadmap.


ui: fix computer diagram css margin that blocks down arrow

Problem: Down arrow key of the vertical scroll bar in the VM deployment wizard does not work.
Root Cause: The computer diagram on the right side in the VM deployment wizard spills its margin on the left causing the arrow key to be blocked.
Solution: Fix the background-position to get the correct position than margin-left for the zone-panel. With the fix, the left size arrow keys and vertical scrollbars are no longer under the diagram image and press-able now.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
Before the fix, as seen from dev tools:

The layout as seen in dev tools after the fix:

Hi @rhtyd,
I think this is already fixed in #3183
We also added some code in response to questions/suggestions from others. Can you look over #3183 and merge?

I double checked this, and the down arrow is also not clickable with #3183. So this is no duplicate  @rhtyd

Thanks @DennisKonrad

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2636

LGTM

Whohoo - finally :)


Azure Functions: Create New Project doesn't show option for Python 3.10.x when choosing V2 Model

Extension Version: Azure Functions v1.9.0
Platform and Operating System: MacOS Ventura 13.1
VS Code Version: 1.74.3
When I try to create a new project to use the Python Programming Model v2, the versions to select from are 3.6 - 3.9

Steps to Recreate:

Activate Command Palette
Select Azure Functions: Create New Project
Select Browse: Choose Test Folder
Python (Programming Model V2)
Select Manually Enter Python Interpreter or Full Path
Paste the path to your Python 3.10.4 environment

This will ship with our next release. It was added in this PR (thanks for the contribution!) https://github.com/microsoft/vscode-azurefunctions/pull/3511


Documentation issue

controller.addChunk(chunk);
Controller have no method called "addChunk" as written in documentation

After looking into code I think the chunk functionality is not implemented fully you cant access chunk stream because that variable is private , the best I was able to do is access normal StreamController object and make use of it( Means sending whole image data again ) instead of chunks


Spike: Integrate Safari browser checks to our e2e testing

Background
On Friday April 24th we had a spike in support escalations due to the application being completely broken in Safari. This caused that all patients using iphones were not able to check their test results. Root cause was code introduced in the app 3 days prior that was not compatible with Safari.
Action requested
Include e2e testing of our application flows using Safari. This toolkit seems to be the way to implement this.
Acceptance Criteria
Add the new cypress toolkit and include checks to ensure that the applications runs in safari. This should become part of the current workflow triggered in the PR pipelines.
If the usage of the toolkit seems not possible then report back the findings to the team.
Additional context
Ideally we would like to run all 9 specs in safari but if the lift is too much then being able to check that the app renders in safari should suffice for this first round of implementation.

@alismx branch with their attempts at getting webkit to run in CI: https://github.com/CDCgov/prime-simplereport/pull/5675
my branch with my attempts to getting it working:  https://github.com/CDCgov/prime-simplereport/pull/5637
Both are using cypress 10. Alis recommended we wait until webkit support is no longer considered "experimental" by cypress

Notes:
Look into whether WebKit support is experimental (is there another version of Cypress where it would work? seems like there's later versions we haven't tried yet)
If not, let's backtrack and explore other options for testing Safari in our e2e
Potentially blocked by folks with M1 chips not being able to run locally

Ticket, when completed, will make our life easier to test this: https://app.zenhub.com/workspaces/devsecops-63d830363b26890016306a3f/issues/gh/cdcgov/prime-simplereport/5819

Running e2e tests in Safari and Chrome would increase odds of flaky tests failing. We should look into and fix flaky e2e tests before increasing the amount of times we're running them in one check.


Segmentation network configuration

Hi, I was reading the code and tried to find this part of the paper in the code but I couldn't.

I guess that it was changed in the code but I'm not completely sure about it.

Hi @eduardovp97
I'm stuck on this figure, can you explain me what you understood about the steps used please?
or provide me with a shema to understand.
thank you

If I'm not mistaken, the lines with ResConv are the ones related to the channels per edge (input channels x output channels)  and the lines with MeshPool describe a pooling operation that will be done until the mesh has the specified number of edges.

thank you for your answer.
I think what you are looking for is in the options/base_options.py file in #network params.

Actually, I think that info is in scripts/coseg_seg/train.sh or scripts/human_seg/train.sh. However, the numbers don't match with the ones in the image and my guess is that they were changed but I'm not sure.

Hi,
In general the code is more reliable than this table (and there is a typo in the table).
The convolutions listed in the Table look correct since:
https://github.com/ranahanocka/MeshCNN/blob/15b83cc6a4db968baf6cf595df78995a9c2dcee3/scripts/human_seg/train.sh#L9
So the first convolutional layer goes from # of input features (which is 5), and then to 32. And then second layer goes from 32 to 64, and so on. These are residual conv blocks with skip connections.
The pooling is a typo (I think it was copied from the another table in the paper which used MeshCNN for classification). Anyway, what is in the code is correct:
https://github.com/ranahanocka/MeshCNN/blob/15b83cc6a4db968baf6cf595df78995a9c2dcee3/scripts/human_seg/train.sh#L11


"Horgești", "Bazga", "Galeri", "Mărăscu", "Răcătău-Răzeși", "Răcătău de Jos", "Recea", "Sohodor" are villages in "Horgești" common, "BACĂU" county

Description : When user is typing the villages in the search bar, the locations should appear in the dropdown menu correctly spelled and with localities information (as in Law nr. 2 din 16 februarie 1968)
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing.
After every step delete the text you typed from the search bar.

Steps 1: Click on the search bar and write "Horgești"
Expected result: In the drop down menu you find "Horgești, Bacău"

Steps 2: Click on the search bar and write "Bazga"
Expected result: In the drop down menu you find "Bazga, Bacău (Horgești)"

Steps 4: Click on the search bar and write "Mărăscu"
Expected result: In the drop down menu you find "Mărăscu, Bacău (Horgești)"

Steps 6: Click on the search bar and write "Răcătău de Jos"
Expected result: In the drop down menu you find "Răcătău de Jos, Bacău (Horgești)"

Steps 8: Click on the search bar and write "Sohodor"
Expected result: In the drop down menu you find "Sohodor, Bacău (Horgești)"


Add Multiple or Custom Enzymes

Description of feature
Is it possible to run a search with multiple enzymes, or to add a custom enzyme (in this case with the appropriate cleaving locations expected for a 2-enzyme digestion?)
If it helps, the digestions I'm interested in running are Trypsin + Asp-N and Trypsin + Glu-C.
Thanks!

@jackrogan this is not supported. Yet, we will give priority for next release. Can you let me know which dataset do you have in mind that can help us to test.

Yes, it is a bit complicated. In theory, we need to model any order of enzymes and add an option to allow for simultaneous application. While e.g. Comet supports this, many other search engines do not.
We could probably release a Comet-only version of this feature earlier than a general one.

I know already that when I'm using enzymes different that Trypsin, I need to enable only Comet, this is already happening because, examples Trypsin/P doesn't work properly with multi search engine.
As you said similar approach can be followed for multiple enzymes, only allow Comet when multiple enzymes is needed.

I know already that when I'm using enzymes different that Trypsin, I need to enable only Comet, this is already happening because, examples Trypsin/P doesn't work properly with multi search engine.
As you said similar approach can be followed for multiple enzymes, only allow Comet when multiple enzymes is needed.

Trypsin/P should work. Please open another issue for this.


Support emitDecoratorMetadata

some typescript and node framework (like nestjs) use emitDecoratorMetadata , but esbuild not support it, and @anatine/esbuild-decorators plugin can solve it .
but esbuild's transform api not support plugin,some can change the api to use build?
like the follow code
async function transpile(code, filename, options = {}) {
    const ext = path.extname(filename);

    const loaders = getLoaders(options);

    const builded = await build({
        ...commonOptions,
        platform: 'node',
        ...options,
        ...{
            loader: loaders,
            bundle: true,
            stdin: {
                sourcefile: filename,
                contents: code,
                resolveDir: path.dirname(filename),
                loader: loaders[ext],
            },
            external: [...externals, ...(options.external ?? [])],
            write: false,
            plugins: [
                ...(options.plugins ?? []),
                esbuildDecorators({ tsconfig: options.tsconfig ?? undefined }),
            ],
        },
    });
    return builded.outputFiles.map((f) => f.text).join('\n');
}

any progress of this?

any progress of this?

If you really need this, you can switch to ts-node for now. the setup be like
.swcrc
{
  "$schema": "https://json.schemastore.org/swcrc",
  "sourceMaps": true,
  "module": {
    "type": "es6"
  },
  "jsc": {
    "target": "es2022",
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "dynamicImport": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    },
    "keepClassNames": true
  },
  "minify": false,
  "exclude": ["\\.test\\.ts$"]
}

tsconfig.json
{
  "ts-node": {
    "transpileOnly": true,
    "swc": true,
    "esm": true,
    "files": true,
    "experimentalSpecifierResolution": "node"
  }
}

then invoke
pnpm node --loader ts-node/esm --watch src/main.ts

If you encouter some ts-node+swc problem, check this patch
<EMAIL_ADDRESS>diff --git a/dist/transpilers/swc.js b/dist/transpilers/swc.js
index c334bd3b18b292c3f865639dca4080ff3dfe53e8..26c37e4b45177554f4a79e311775dab3e9085a59 100644
--- a/dist/transpilers/swc.js
+++ b/dist/transpilers/swc.js
@@ -167,7 +167,7 @@ function createSwcOptions(compilerOptions, nodeModuleEmitKind, swcInstance, swcD
                         : {}),
                 }
                 : undefined,
-            swcrc: false,
+            swcrc: true,
             jsc: {
                 externalHelpers: importHelpers,
                 parser: {

The living example https://github.com/wenerme/wode/blob/main/server.mk#L15
When building with esbuild, you can enable the plugin for this like https://github.com/wenerme/wode/blob/main/apps/server/src/app/scripts/bundle.esbuild.ts

can ts-node support node V20?

it can not works,
node:internal/process/esm_loader:34
internalBinding('errors').triggerUncaughtException(
^
Error: ERR_PACKAGE_PATH_NOT_EXPORTED /Users/tianyingchun/Documents/coding/dress/dress-srv/node_modules/@semic/common/node_modules/date-fns/ ./_lib/cloneObject/index.js<EMAIL_ADDRESS>

can ts-node support node V20?

Yes

ERR_PACKAGE_PATH_NOT_EXPORTED

you should check the import path

I'd like to reserve Issues for those interested in contributing, and discussions constructive towards addressing the issue (e.g. implementing fixes or features). Please discuss workarounds elsewhere.

@wenerme:

Is it possible to some how enable the tsc for this like thomaschaaf/esbuild-plugin-tsc ?

This is already answered above:

However, this will require TypeScript to be a dependency, and add a bottleneck to transformation, which defeats the point of using esbuild (and this entire module).

FYI, esbuild just shipped decorators support. Can't wait to test it out with tsx soon.

Is it that same thing as this issue? I've personally never used decorators so I'm not sure.
As I understand, what shipped in terms of tsconfig.json is support for experimentalDecorators (JS spec), rather than emitDecoratorMetadata (TS spec), which is what this thread is about.

I published the esbuild v0.21 upgrade in tsx 4.10.0-rc.1 through the development repo (sponsors only). Holding official release for a few weeks since it's still seems to require further testing.

Is it that same thing as this issue? I've personally never used decorators so I'm not sure.
As I understand, what shipped in terms of tsconfig.json is support for experimentalDecorators (JS spec), rather than emitDecoratorMetadata (TS spec), which is what this thread is about.
I published the esbuild v0.21 upgrade in tsx 4.10.0-rc.1 through the development repo (sponsors only). Holding official release for a few weeks since it's still seems to require further testing.

Should be the same thing, I tested it with the snippet which is what NestJS uses and it works well.

Do you know why there are two different configs if they're the same thing? Seems like they map to different behaviors.
From TypeScript's announcement:

This new decorators proposal is not compatible with --emitDecoratorMetadata, and it does not allow decorating parameters. Future ECMAScript proposals may be able to help bridge that gap.

Do you know why there are two different configs if they're the same thing? Seems like they map to different behaviors.
From TypeScript's announcement:

This new decorators proposal is not compatible with --emitDecoratorMetadata, and it does not allow decorating parameters. Future ECMAScript proposals may be able to help bridge that gap.

This is a problem that Typescript implemented their own decorators first when tc39 was still figuring out the final spec in JS.
And because of that, evanw had to research into multiple decorators implementation which he tests all of them here to ensure his current implementation sticks as close as to the tc39 one. https://github.com/evanw/decorator-tests

That, I understand. But what I'm trying to figure out is if this thread could actually be closed soon.
This issue is specifically about emitDecoratorMetadata. And it seems like what was released in esbuild is support for JS decorators (experimentalDecorators), which you claim is the same thing, but TypeScript seems to claim it's not?

That, I understand. But what I'm trying to figure out is if this thread could actually be closed soon.
This issue is specifically about emitDecoratorMetadata. And it seems like what was released in esbuild is support for JS decorators (experimentalDecorators), which you claim is the same thing, but TypeScript seems to claim it's not?

Oh from what I understand:
The previous esbuild version couldn't understand the decorators syntax in TS and hence didn't emit the decorator functions in the JS output. Hence, breaks NestJS or TypeORM runtime functionalities.
With this new release, it now parses the decorators and emits ___decorators() in the JS output which allows NestJS and TypeORM to work well.
Also, the current NodeJS runtime with the latest V8 still doesn't recognise decorators syntax yet as tc39 spec for decorators hasn't been implemented in V8 yet AFAIK which is why rebuild have to parse @decorator() and emit them as ___decorators() so that it can be evaluated at runtime.

I see, thanks for elaborating.
So given this issue is specifically about emitDecoratorMetadata, and not about JS decorators, NestJS, or TypeORM support, it sounds this this is a tangental conversation. Going to hide it to keep the conversation easier to follow for those interested in tackling emitDecoratorMetadata support.

Wait a sec, I think it's related as mentioned in https://github.com/evanw/esbuild/releases/tag/v0.21.0:

The only difference is esbuild's implementation is following the latest tc39 spec whereas typescript 5's emitDecoratorsMetadata is currently outdated.

Yes, it's related in terms of the succession of the feature, but they're different specs so it doesn't solve the reported issue.
Note, this issue is for TypeScript's emitDecoratorMetadata—not for decorators in the general sense—which has support for annotating with type data: https://www.typescriptlang.org/tsconfig/#emitDecoratorMetadata
As you can see from TS's compiled output, it relays type information, which JS decorators don't have access to:
__decorate([
    LogMethod,
    __metadata("design:type", Function),
    __metadata("design:paramtypes", [Number]),
    __metadata("design:returntype", void 0)
], Demo.prototype, "foo", null);

Confirmed in esbuild's playground that it doesn't do this.
Anyway, this is not constructive towards closing this issue which is why I hid it. If you want to talk about this further, please open a thread in https://github.com/pvtnbr/tsx/discussions


Uncaught Error: Class 'Raven_Client' not found

I recenty got this error after upgrading our composer. Did the original Sentry package got updated where the Raven_Client got deprecated or so?
PHP Fatal error:  Uncaught Error: Class 'Raven_Client' not found in /api/vendor/sentry/sentry-laravel/src/Sentry/SentryLaravel/SentryLaravel.php:18 Stack trace: #0 /api/vendor/sentry/sentry-laravel/src/Sentry/SentryLaravel/SentryLaravelServiceProvider.php(101): Sentry\SentryLaravel\SentryLaravel::getClient(Array) #1 /api/vendor/laravel/framework/src/Illuminate/Container/Container.php(776): Sentry\SentryLaravel\SentryLaravelServiceProvider->Sentry\SentryLaravel\{closure}(Object(Illuminate\Foundation\Application), Array) #2 /api/vendor/laravel/framework/src/Illuminate/Container/Container.php(658): Illuminate\Container\Container->build(Object(Closure)) #3 /api/vendor/laravel/framework/src/Illuminate/Container/Container.php(609): Illuminate\Container\Container->resolve('sentry', Array) #4 /api/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(759): Illuminate\Container\Container->make('sentry', Array) #5 /api/vendor/sentry/sentry-laravel/src/Sentry/SentryLaravel/SentryLaravel.php on line 18

Yes, the 1.0 release of the Laravel integration uses the 2.0 version of the Sentry PHP SDK.
It's a complete overhaul and changes a lot. It should however be relatively straight forward assuming you we're doing some custom context and sending your own exceptions.
The upside of the 2.0 PHP SDK is that no matter if Laravel or Symfony or plain PHP (or another language even) the functions and ways you interact with the client are all called the same / used the same.
A few links that can get you started:

https://docs.sentry.io/platforms/php/laravel/
https://docs.sentry.io/error-reporting/capturing/?platform=php

I had the same error, bumped the version to 1.0 as per the documentation.
I changed the configuration file and everything seems to be OK.
However, the captureException method does not report to Sentry.
"php artisan sentry:test"successfully generates an event, but I cannot verify anywhere that it has been received.
Any ideas why?

Yes, the 1.0 release of the Laravel integration is a breaking change because it uses the 2.0 version of the Sentry PHP SDK.

@stayallive , you must be kidding us. What you did (to break an official version that has been stable for almost 3 years) is against any versioning management best practice. Furthermore, your breaking change was against the official Composer guideline. I really don't get how come your change has passed through a revision process, but whatever ...
If any other engineer hits this problem, here is your solution. Simply change:
    "require": {
        "sentry/sentry-laravel": "0.8.0"
    },

to
    "require-dev": {
        "sentry/sentry-laravel": "dev-master#3deb3b26a0608b653284388e13531530205a786a"
    },

0.8.0

What you did (to break an official version that has been stable for almost 3 years) is against any versioning management best practice. Furthermore, your breaking change was against the official Composer guideline.

To what guidelines are you referring to? Composer tries to follow Semantic versioning, and basically all Composer constraints use that spec (or subset of it). Furthermore, they even recently joined the SemVer team: https://github.com/semver/semver/issues/495.
If you read through the SemVer spec, point 8 says that any kind of breakage is allowed (only) between major versions, and point 4 says that any 0.x version is to be considered unstable, and API changes are to be expected.
This was a major version increase, and furthermore starting from an unstable one.
Lastly, I invite you to be more kind toward the maintainer, which is devoting his free time to work on this package.

@vitanivanov that is odd, running php artisan sentry:test should output something like this:
[sentry] Client DSN discovered!
[sentry] Generating test event
[sentry] Sending test event
[sentry] Event sent with ID: somelongidiremovedhere

This event should show up in your dashboard for the project you have configured the DSN for on Sentry.io. You can paste the event ID (from your own output) in the search bar to jump straight to the issue which should state "This is a test exception sent from the Sentry Laravel SDK.".

@vitanivanov that is odd, running php artisan sentry:test should output something like this:
[sentry] Client DSN discovered!
[sentry] Generating test event
[sentry] Sending test event
[sentry] Event sent with ID: somelongidiremovedhere

This event should show up in your dashboard for the project you have configured the DSN for on Sentry.io. You can paste the event ID (from your own output) in the search bar to jump straight to the issue which should state "This is a test exception sent from the Sentry Laravel SDK.".

There seems to be something heavily environment/configuration dependent in the new version.
I did presumably all the required steps, and was still unable to get the errors in Sentry, even though the sentry:test artisan command seemed successfully executed.
This was fixed when adding a cacert in php.in, but exceptions were still not received by Sentry.

I agree with @mdzhokanov, my apps just broke. I undestand that it's a breaking change but it's not easy to go back. I'm trying to go bck to 1.0.0 version and still not working.
Again, I understand that it is a breaking change; but, a breaking change should not be so difficult to rollback.

Probably why you are having trouble going back is because you are trying to go back to 1.0 which is actually the new version we just released (which has the breaking change).
If you go back to 0.11.0 you should be all set and back to how it was before 👍
The breaking change is happening on the bump from 0.11.0 to 1.0.0.

Worked! Thanks

Just to make a few things clear:

I undestand that it's a breaking change but it's not easy to go back. I'm trying to go bck to 1.0.0 version and still not working.
Again, I understand that it is a breaking change; but, a breaking change should not be so difficult to rollback.

Since breaking changes should only happen between major versions (this is what is written in the Semver specs as said by @Jean85), the only way your app broke is because you deliberately upgraded the Composer constraints from something like ^0.x to ^1.0, which means that you should be aware that being a new major version things will likely break (otherwise it wouldn't be a major version bump) and this is valid for any library following these specs. To revert back, obviously, you have to downgrade to the previous release (0.x) so I don't really understand why you said that you were trying to go back to 1.0 which was the version you were at in that moment

I strongly recommend mentioning somewhere in the install / support documentation that the curl.cainfo configuration option in php.ini is mandatory for the out-of-the-box client that sentry-laravel uses

This may be a good point indeed for a note in the documentation, please note that some systems are already pointing to the correct CA bundle path and some not.

you must be kidding us. What you did (to break an official version that has been stable for almost 3 years) is against any versioning management best practice. Furthermore, your breaking change was against the official Composer guideline.

@mdzhokanov actually I don't want to start a discussion about this because I believe we all agree it would not be useful to anyone, but as explained by @Jean85 any kind of breaking change is allowed between 0.x releases and between major versions bump, so what you said is totally incorrect and I strongly recommend you to read the specs before starting such rant against a person that is devoting his free time to the community. Also I remember everyone that if constraints are set correctly in your composer.json then Composer will never upgrade libraries between major version bumps, so this is something that you must do deliberately and in turn this means that if you know the Semver specs then you know that doing this will likely result in more work from your side since BC breaks are expected

Just to make a few things clear:

I undestand that it's a breaking change but it's not easy to go back. I'm trying to go bck to 1.0.0 version and still not working.
Again, I understand that it is a breaking change; but, a breaking change should not be so difficult to rollback.

Since breaking changes should only happen between major versions (this is what is written in the Semver specs as said by @Jean85), the only way your app broke is because you deliberately upgraded the Composer constraints from something like ^0.x to ^1.0, which means that you should be aware that being a new major version things will likely break (otherwise it wouldn't be a major version bump) and this is valid for any library following these specs. To revert back, obviously, you have to downgrade to the previous release (0.x) so I don't really understand why you said that you were trying to go back to 1.0 which was the version you were at in that moment

I strongly recommend mentioning somewhere in the install / support documentation that the curl.cainfo configuration option in php.ini is mandatory for the out-of-the-box client that sentry-laravel uses

This may be a good point indeed for a note in the documentation, please note that some systems are already pointing to the correct CA bundle path and some not.

you must be kidding us. What you did (to break an official version that has been stable for almost 3 years) is against any versioning management best practice. Furthermore, your breaking change was against the official Composer guideline.

@mdzhokanov actually I don't want to start a discussion about this because I believe we all agree it would not be useful to anyone, but as explained by @Jean85 any kind of breaking change is allowed between 0.x releases and between major versions bump, so what you said is totally incorrect and I strongly recommend you to read the specs before starting such rant against a person that is devoting his free time to the community. Also I remember everyone that if constraints are set correctly in your composer.json then Composer will never upgrade libraries between major version bumps, so this is something that you must do deliberately and in turn this means that if you know the Semver specs then you know that doing this will likely result in more work from your side since BC breaks are expected

The version in composer.json was "^0.8.0".
However, for some reason, when updating, sentry/sentry got updated from 1.2 to 2.0,

As you can see here it's not possible that Composer would have updated the version. I've also just tried the following that confirms this:
docker run --rm --interactive --tty --volume $PWD:/app composer require sentry/sentry-laravel:"^0.8.0"

This in a empty folder will install sentry/sentry-laravel 0.8.0 and sentry/sentry 1.10.0 (at the time of writing)
Let's now do composer update
docker run --rm --interactive --tty --volume $PWD:/app composer update

This results into the message Nothing to install or update and versions of both libraries are still like the first run. This is not to say I don't trust what you're saying, but that for sure something else must have happened to cause such a bump and so it's not really fault of @stayallive. Said this I don't want to start a war on who is right :wink:

It took me approximately 8 hours of debugging the sentry/sentry package to realize that the events were sent but were not received because of the lack of valid SSL certificate.
In version 0.8 such a thing was not necessary, so this is a hidden dependency when upgrading from 0.8.0 to 1.0

It used to work in 1.x because that version was shipping with a (non-updated btw) CA bundle that was used by default. I don't know if an exception is thrown in case the SSL check fails (and then it gets catched by our error handler which in turn will fail to report for this reason) but if that's the case maybe it would be better to just leave it throwing and let the user see it instead of failing silently. WDYT?

I understand that breaking changes are inevitable, but from a user perspective you need an upgrade guideline. Take Laravel for example: https://laravel.com/docs/5.8/upgrade

We have such guide here.

As you can see here it's not possible that Composer would have updated the version. I've also just tried the following that confirms this:
docker run --rm --interactive --tty --volume $PWD:/app composer require sentry/sentry-laravel:"^0.8.0"

This in a empty folder will install sentry/sentry-laravel 0.8.0 and sentry/sentry 1.10.0 (at the time of writing)
Let's now do composer update
docker run --rm --interactive --tty --volume $PWD:/app composer update

This results into the message Nothing to install or update and versions of both libraries are still like the first run. This is not to say I don't trust what you're saying, but that for sure something else must have happened to cause such a bump and so it's not really fault of @stayallive. Said this I don't want to start a war on who is right 😉
I suspect a transitive dependency issue - something else must have been updated which forced the sentry/sentry  update to 2.0. Probably a Laravel package? I suggest verifying it with the default packages required for Laravel 5.5.

It used to work in 1.x because that version was shipping with a (non-updated btw) CA bundle that was used by default. I don't know if an exception is thrown in case the SSL check fails (and then it gets catched by our error handler which in turn will fail to report for this reason) but if that's the case maybe it would be better to just leave it throwing and let the user see it instead of failing silently. WDYT?
The easiest way to check it is this:

Remove the ca cert reference from the php.ini of the PHP CLI.
Execute "php artisan sentry:test"
An event will be generated - it will have an ID and everything, but it will not be received by Sentry.
People testing on local dev environments will be affected by a silent failure and will be puzzled like me for hours. I suggest either throwing an exception or logging an error somewhere.

We have such guide here.
I linked the Laravel upgrade guide, because I recently did the procedure for 5.1 to 5.5 and it was quite straightforward. Instead of listing all the changes, I suggest a more user-friendly approach - what I need to change and where.

but all I really needed was a step "add a valid ssl certificate in your php.ini file", which would have saved 8 hours for me.

This seems an issue with the transport layer, which is not our, but it's Curl. I'll dig into that.

The Curl transport should've blown up with an exception: https://github.com/php-http/curl-client/blob/master/src/Client.php#L142-L143

Since we're catching all exceptions (even while handling another error) we have the classic case of the dog biting its own tail because each error will fail to be reported and the user will know nothing about the problem because it's "silenced". We should investigate whether we can catch such exceptions (e.g. network exceptions) and throw them letting the app blow up like it would normally do so that the developer knows that something gone wrong

For you guys having problems with Sentry going from 0.8.0 directly to 1.0.0, go back to 0.11.0 as mentioned by @stayallive.
We have multiple deployments daily and when we reverted back to 0.8.0 (as we had before the issue) we still got the exception above. Why we never got upgraded to 0.11.0 in the first place still amazes me... Probably due to how we initially set up Sentry, following the Official Sentry Documentation for Laravel.

We figured out why this is happening and where we wen't wrong, so here is the solution for downgrading problems.
Because of incorrect version constraints on sentry/sentry-laravel version 0.8 and lower it allows for sentry/sentry version 2.0 to be installed (which has the breaking changes) but sentry-laravel below version 1.0 is not compatible.
The constraint on version 0.8 of the Laravel integration was to require sentry/sentry:>=1.7.0 this also includes 2.0 (visualized), in 0.9 we switched to the correct constraint of sentry/sentry:^1.9.0 (visualized).
So to fix install sentry/sentry-laravel of at least version 0.9, but better ofcourse being the latest 0.11 release which correctly only installs 1.x of the PHP SDK.
So if you are still on 0.8 of the Laravel integration and or trying to downgrade to 0.8 (or lower) you will still install the 2.0 of the PHP SDK.
We will work on getting hotfixes out for the older versions fixing the constraints!

I am closing this since all the hotfixes are out all the way back to 0.3 (please upgrade!) so downgrading results in going back to 1.x of the base SDK and only 1.x of the Laravel integration will pull in 2.x of the base SDK as it should.
Thank you all for the reports and information!


SLL LabVIEW Code Compare Tool for git - Refresh Button distorted

[ ] Branch refresh button is distorted

LV2020 64bit

Based on initial investigation, it seems to occur only in @Sairam0496 pc and works fine in other pc's with same LabVIEW version. And the cause could be that though the Refresh boolean button text is disabled, it is getting enabled and causing the distortion. So, to be on the safer side the boolean text can be removed.
Additional note: @Sairam0496 has enabled multiple advanced LabVIEW properties via LabVIEW.ini which we suspect might cause the issue.


Fix typo in appledoc tag name

Prevents from "Unknown command tag name 'disscussion'; did you mean 'discussion'?" warning

Thanks! :smile:


Customize SelectionPrompt selected choice color

Currently the highlight color for the selected choice in SelectionPrompt and MultiSelectionPrompt is always blue and can result in visibility problems on black backgrounds:

Can now be changed by using .HighlightColor(Color.Red) for example making it easier to see and more customizable:

Example in context:
fruit = AnsiConsole.Prompt(
        new SelectionPrompt<string>()
            .Title("Ok, but if you could only choose [green]one[/]?")
            .AddChoices(favorites)
            .HighlightColor(Color.Red));

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@NickWingate Great idea. Could we change this to accept a style instead, i.e. HightlightStyle? That way we're not limited to only colors.

@NickWingate Great idea. Could we change this to accept a style instead, i.e. HightlightStyle? That way we're not limited to only colors.

Changed HighlightColor to HighlightStyle, didn't think of that thanks!

Changed HighlightColor to HighlightStyle, didn't think of that thanks!

Merged! Thank you for your contribution. Much appreciated! 👍

Merged! Thank you for your contribution. Much appreciated! 👍


Fix #137

Change "-1" with "None".
Fixed the print issue.
print " Battery: %s" % v.battery
Battery: Battery voltage: 11.997, current: None, level: None

thanks @maruina, @hamishwillee code looks fine, can you make sure problems discussed on #137 are fixed?

I ran some tests and it does work as promised and addresses #137. The docs need some work as discussed, but I can create a patch for that as soon as you've merged.

hey @hamishwillee can you share your test script with us, I'm going to have @tcr3dr help check this

All I did was add the following line to the (vehicle_state)[http://python.dronekit.io/examples/vehicle_state.html#source-code] source code near the other parameters:
print " Battery: %s" % v.battery

Then I ran the script at various states in the running code.
Of course I first had to set up a local test build, which I did as per our google doc on this topic and copy in the changes in the file for init.py (might have been easier to sync to the official branch)

:+1: thanks guys this is great


Unable to redirect to sites with non-UTF8 characters in URL

This issue was raised as a 'what if' scenario.
System is unable to redirect to - http://例え.テスト/メインページ
There may potentially be an issue with the way Redis is storing its data, possibly a bad charset? Otherwise we need to convert whatever the user sends in to an IDN compliant value for the Redis DB.
For some reason when copying the URl from the address bar of different browsers you get different results:
Chrome - http://例え.テスト/メインページ
Firefox - http://例え.テスト/メインページ
Safari - http://例え.テスト/メインページ
Taking any of these URLs and pasting them back into the address bar of any of the browsers takes you to the correct site.
Clicking on the link to the target within the PID service's admin pages (regardless of which of the URLs is saved) brings you to the correct target page.
Trying to get to the target via the PID service's redirect fails in Firefox and Safari (except for the idn compatible version of the URL from Chrome) but succeeds in Chrome and IE (for any of the URL versions)

Note that this Markdown document did not consider the Firefox and Safari versions of the URL to be a hyperlink!


Speed S3 query on startup

Currently I have both a local filesystem blobstore as well as s3 as a backup. When the service starts up it is querying to see if files exist in s3. However I have no files that start with 'packed' and iterating all 400k sha224 blobs takes FOREVER.
S3 does not have 'folders' only prefixes and so we can query all files from the packed "directory" by adding the s3Storage.dirPrefix to our query.
With this change my server now starts up instantly.

Thanks for the contribution!


fix: Macro not replaced for provider docs

:tada: This PR is included in version 2.1.1-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ECR images are not deleted

On delete stack, ECR image is not deleted. So images are stacked on each new deployment

This isn't something in the scope of this construct. There is an aws-cdk rfc for this.


improve GTM healthcheck

Although the GTM healthcheck works, attempting to connect using Curl yields
db_gtm_1_1            | 1:2717890304:2017-05-14 14:12:56.185 UTC -FATAL:  Expecting a startup message, but received G
db_gtm_1_1            | LOCATION:  GTM_ThreadMain, main.c:1098

Improve healthcheck to check only for port being open.

Planning this for the next round of work on Postgres-XL Docker; my logs are filling up with errors which are not errors. ;)

Done in 03f823d.

As noted in #29, the fix for this wasn't sufficient. Further discussion is continued in that issue.


pytorchltr fails to install on python 3.11

pytorchltr fails to install on Python 3.11 with an error message as below.
It seems this is due to an incompatibility of Python 3.11 with an old version of cython. The same error also happens in other packages, for instance, https://github.com/aio-libs/aiohttp/issues/6600
I tried to build the package manually from source with new dependencies and Python 3.11, and this worked.
Could you update the packages on pypi so that it is compatible with Python 3.11?
   clang -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -I/private/var/folders/_k/g4dqk3gd5svd86l4c4fw2ds00000gn/T/pip-build-env-lj0oeimo/overlay/lib/python3.11/site-packages/numpy/core/include -I/Users/akreuzer/virtualenvs/test4/include<EMAIL_ADDRESS>-c pytorchltr/datasets/svmrank/parser/svmrank_parser.c -o build/temp.macosx-14-arm64-cpython-311/pytorchltr/datasets/svmrank/parser/svmrank_parser.o
      pytorchltr/datasets/svmrank/parser/svmrank_parser.c:220:12: fatal error: 'longintrepr.h' file not found
        #include "longintrepr.h"
                 ^~~~~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1

Maybe a workaround is using a venv with Python 3.10 or a docker container while the fix is not ready.


How to build and launch autogenu-jupyter example?

Hi, @mayataka.
Thanks for your contribution.
I want to run your source, therefore I wonder let me know how to build and launch autogenu-jupyter example.

Hi @Geonhee-LEE,
All procedures, ie.g., code generations, compilations, and simulations are run through Jupyter notebook or Jpyter lab.
First please launch Jupyter notebook or Jupyter lab.
Then open an .ipynb example file (e.g., cartpole.ipynb).
By running the cells of the notebook, the above procedure will be executed.


Upsert users who are authenticated but not stored in the user table

Summary
This adds a get_current_user_and_upsert dependable that is also a dependent that relies on the get_current_user dependable that already existed (Am I the only one confused by this terminology?). Essentially all of this dependency magic turns into a middleware chain where:

First the get_current_user dependency runs as it does today. That means any internal deployments that have injected their own authentication middleware that overrides this dependency will still work exactly as it does today.
Next on the chain is the get_current_user_and_upsert function which will do a simple upsert to insert the user into the DJ metadata users table, if it does not already exist (based on the username)

Below describes what will happen in a few of the typical auth scenarios:
Scenario 1: Basic Auth (no change)

When a user goes through the basic auth signup flow, the user is inserted into the DJ metadata users table.
When the user logs in, they're authenticated and the encrypted cookie is stored
On authenticated requests, the cookie is processed by the backend and the user is retrieved from the users table
The get_current_user_and_upsert is essentially a no-op since the user already exists in the users table

Scenario 2: Google OAuth (no change)

A user signs in with google through the google oauth flow
If it's the user's first time, they're inserted into the users table
An encrypted cookie is stored on the client
On authenticated requests, the cookie is processed by the backend and the user is retrieved from the users table
The get_current_user_and_upsert is essentially a no-op since the user already exists in the users table

Scenario 3: get_current_user override to use custom auth managed by an external system (only setup impacted by this PR)

get_current_user returns a User object instantiated from data retrieved from some system external to DJ
get_current_user_and_upsert runs to guarantee the user is stored in the DJ deployments users table

It's true that in Scenario 3, the internal logic in the get_current_user override should handle the upsert on it's own, but there's no guarantee of that since the User instance could simply be constructed in memory based on the propagated user identity and never saved to the database. This PR makes it so that custom auth implementations never have to concern themselves with making sure they save the user to the DJ metadata database, the open source logic will automatically handle that, guaranteeing that we always have a DJ user entity to tie things to in the system.
Test Plan
Added some tests and tested it in the local docker environment

[ ] PR has an associated issue: #
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan
Shouldn't effect existing deployments nor require any changes

Would you consider copying your PR summary to some dev doc page?

@agorajek good suggestion, I added a section at the end of the Authentication page.

Related to PR #1096


demo.sh fails at shuffling with segmentation fault

The demo.sh fails on a virtual Linux Mint 17.1 (based on Ubuntu 14.04) on VirtualBox (with 4GB ram).
...
Merging cooccurrence files: processed 60666466 lines.

SHUFFLING COOCCURRENCES
array size: 255013683
Shuffling by chunks: processed 0 lines../demo.sh: line 55:  2613 Segmentation fault
$BUILDDIR/shuffle -memory $MEMORY -verbose $VERBOSE < $COOCCURRENCE_FILE > $COOCCURRENCE_SHUF_FILE

Thanks for reporting these. Will try to reproduce.

I also get this error on virtual xubuntu 14.04 in addition to the compiler warnings. Linux Mint 17.1 on VirtualBox compiles with no warning.
FYI actually I'm a Windows user and thankfully I managed to compile and execute glove on cygwin (on Windows 10) without any problems.

Sorry for the slow reply. Meant to respond to this earlier after merging https://github.com/stanfordnlp/GloVe/pull/3. Do you mind trying this again and seeing if you get a segmentation fault? Perhaps if you do you could try running with valgrind --tool=memcheck $BUILDDIR/shuffle ... and paste the result?

I'm going to assume this was solved by our memory pull request fixes. Please reopen if you are able to reproduce on the most recent version.

Sorry for late feedback. I use virtualbox 5.0.10, windows 10 as host, LinuxMint 17.1 (2 GB RAM, gcc version: 4.8) as guest. I just downloaded the latest version as zip and extracted. This is the my terminal output:
harun@harun-mint ~/Desktop/GloVe-master $ make
mkdir -p build
gcc src/glove.c -o build/glove -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/shuffle.c -o build/shuffle -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/cooccur.c -o build/cooccur -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/vocab_count.c -o build/vocab_count -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
harun@harun-mint ~/Desktop/GloVe-master $ ./demo.sh
mkdir -p build
gcc src/glove.c -o build/glove -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/shuffle.c -o build/shuffle -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/cooccur.c -o build/cooccur -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/vocab_count.c -o build/vocab_count -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
--2015-11-22 14:24:24--  http://mattmahoney.net/dc/text8.zip
Resolving mattmahoney.net (mattmahoney.net)... <IP_ADDRESS>
Connecting to mattmahoney.net (mattmahoney.net)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 31344016 (30M) [application/zip]
Saving to: ‘text8.zip’

100%[======================================>] 31.344.016   678KB/s   in 60s

2015-11-22 14:25:25 (508 KB/s) - ‘text8.zip’ saved [31344016/31344016]

Archive:  text8.zip
  inflating: text8
BUILDING VOCABULARY
Processed 17005207 tokens.
Counted 253854 unique words.
Truncating vocabulary at min count 5.
Using vocabulary of size 71290.

COUNTING COOCCURRENCES
window size: 15
context: symmetric
max product: 13752509
overflow length: 38028356
Reading vocab from file "vocab.txt"...loaded 71290 words.
Building lookup table...table contains 94990279 elements.
Processing token: 15100000./demo.sh: line 55:  2710 Killed                  $BUILDDIR/cooccur -memory $MEMORY -vocab-file $VOCAB_FILE -verbose $VERBOSE -window-size $WINDOW_SIZE < $CORPUS > $COOCCURRENCE_FILE

I increase the main memory to 4 GB and retry:
harun@harun-mint ~/Desktop/GloVe-master $ ./demo.sh
mkdir -p build
gcc src/glove.c -o build/glove -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/shuffle.c -o build/shuffle -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/cooccur.c -o build/cooccur -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
gcc src/vocab_count.c -o build/vocab_count -lm -pthread -Ofast -march=native -funroll-loops -Wno-unused-result
BUILDING VOCABULARY
Processed 17005207 tokens.
Counted 253854 unique words.
Truncating vocabulary at min count 5.
Using vocabulary of size 71290.

COUNTING COOCCURRENCES
window size: 15
context: symmetric
max product: 13752509
overflow length: 38028356
Reading vocab from file "vocab.txt"...loaded 71290 words.
Building lookup table...table contains 94990279 elements.
Processed 17005206 tokens.
Writing cooccurrences to disk.........2 files in total.
Merging cooccurrence files: processed 60666466 lines.

SHUFFLING COOCCURRENCES
array size: 255013683
Shuffling by chunks: processed 0 lines../demo.sh: line 55:  2294 Segmentation fault      $BUILDDIR/shuffle -memory $MEMORY -verbose $VERBOSE < $COOCCURRENCE_FILE > $COOCCURRENCE_SHUF_FILE

Hi, Did you manage to solve the problem? I have the same issue with segmentation fault. Thanks!

@asnatm I'm currently working on a separate segfault issue in build/glove in https://github.com/stanfordnlp/GloVe/issues/14. Can you clarify the circumstances under which you're getting the segfault (i.e. in glove.cpp or shuffle.cpp, and using which corpus).

I'm getting the segfault when running the demo script. At the shuffling by chunks step (shuffle.cpp)  I'm using my own corpus. A small one only 23405 words in vocab. thanks!

I understand that you may not be able to share the corpus. But it's pretty difficult for me to help if I can't reproduce locally. Could you try cutting the corpus size in half repeatedly until you don't get the problem any more, and then sending me the smallest such corpus, perhaps with words substituted out for numbers representing their indices?

Hi,
This is a link to the corpus
https://www.dropbox.com/s/vqa6ogtxipy2lvz/myCorpus.txt?dl=0   (too large to
attach) .Is the format ok?
I'll do the exercise you suggested and send you the smallest corpus I still
got the problem.
Highly appreciated,
Thanks,
Asi
On Tue, Feb 16, 2016 at 6:54 AM, Russell Stewart<EMAIL_ADDRESS>wrote:

I understand that you may not be able to share the corpus. But it's pretty
difficult for me to help if I can't reproduce locally. Could you try
cutting the corpus size in half repeatedly until you don't get the problem
any more, and then sending me the smallest such corpus, perhaps with words
substituted out for numbers representing their indices?
—
Reply to this email directly or view it on GitHub
https://github.com/stanfordnlp/GloVe/issues/6#issuecomment-184518457.

Hi,
I solved it. I didn't have enough memory.... sorry
Thanks,
Asi
On Tue, Feb 16, 2016 at 10:00 AM, Asi Messica<EMAIL_ADDRESS>wrote:

Hi,
This is a link to the corpus
https://www.dropbox.com/s/vqa6ogtxipy2lvz/myCorpus.txt?dl=0   (too large
to attach) .Is the format ok?
I'll do the exercise you suggested and send you the smallest corpus I
still got the problem.
Highly appreciated,
Thanks,
Asi
On Tue, Feb 16, 2016 at 6:54 AM, Russell Stewart<EMAIL_ADDRESS>
wrote:

I understand that you may not be able to share the corpus. But it's
pretty difficult for me to help if I can't reproduce locally. Could you try
cutting the corpus size in half repeatedly until you don't get the problem
any more, and then sending me the smallest such corpus, perhaps with words
substituted out for numbers representing their indices?
—
Reply to this email directly or view it on GitHub
https://github.com/stanfordnlp/GloVe/issues/6#issuecomment-184518457.

Might sound stupid, but for me, it helped just restarting the computer :snail:

Hi all.
I faced up with some problem.
The problem is the memory you can adjust processing memory according to your computer memory.

bummer
On Sun, Oct 6, 2019 at 11:22 PM hashem yousefi<EMAIL_ADDRESS>wrote:

Hi all.
I faced up with some problem.
The problem is the memory you can adjust processing memory according to
your computer memory.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/stanfordnlp/GloVe/issues/6?email_source=notifications&email_token=AAIFEMIVNF22GQJ5AUWIDCLQNLIRNA5CNFSM4BTOWYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPETMI#issuecomment-538855857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIFEMPNEIXKU2DHOMK6DC3QNLIRNANCNFSM4BTOWYAA
.


added swc-blueprint logo to readme and web homepage

I added two images to the webisite:

the logo, displayed on the home page
an example project tree, displayed near the top of the specification
Below I show these in light/dark modes:


logical

when component mount.. onChange handler fire automatically

@ArinMovsesian I'll check it out.

same here +1


[Bug]: New created object get confused with open and close displayed

New created object get confused with open and close displayed
Reproduce

Create an object.
Create a field inside the object.
Play with the open and close button of the object, something there is wrong, it's display text when it shouldn't and vise versa.

https://github.com/omriLugasi/rhino-tools-simple-json-editor/pull/15


CompletionProvider not be triggered

This maybe a dev-question, I am developing a VS Code extension of css intellisense in .vue file with languages.registerCompletionItemProvider, and the trigger character is '-', But it does not work at all, and I did some test to make sure it the problem is happened with volar, the extension of vue, But i still need to know which step may change the behavior of triggering the completion provider
All I know is:

Only when the volar is enable, it doesn't work, otherwise it works normally in the .vue file.
Only does not work in the .vue file, in other files it works normally even volar enable.
the completion provider totally not be triggered by typing '-'，if use any other trigger word instead, it works normally.
use Ctrl+Space to manually trigger the Intellisense, the provider was triggered normally.

Trigger characters that are also word-characters don't count as word characters. That's because quick suggest comes into play here. It's likely that volar defines a custom word definition for .vue-files and that that word definition includes the - character


i get no tooltip for elements in array

Hello, I'm trying to create tooltips for an array of elements, but i don't get any. What am i doing wrong?

	{
		messages && messages.map(m => (

					<xmp data-for="message" data-tip={formatDate(m.created, true)} data-iscapture="true">{m.content}</xmp>

			))
	}

<ReactTooltip
	id="message"
	place="top"
	effect="solid"
	type="dark"
	multiline={true}
/>

I'm not entirely sure what you're trying to do, but I think you need to add something to the RealTooltip tag, it can't be self closing:
Something like this:
<ReactTooltip
	id="message"
	place="top"
	effect="solid"
	type="dark"
	multiline={true}
>

 test tooltip

</ReactTooltip>

@Ginso and anyone facing this problem:
If your data, ie: messages is dynamically loaded from an external request, react-tooltip will not know about them, so you need to rebuild it.
Using hooks, for your specific case:
import ReactTooltip from "react-tooltip";

useEffect(() => {
    ReactTooltip.rebuild();
  }, [messages]);

This will allow react-tooltip to pick up the new elements


FATAL: trying to delete zfs pool or filesystem? WTF?

Saw this in my weekly run output, so opening an issue as directed.
/sbin/zfs snapshot -r<EMAIL_ADDRESS>... DONE
/sbin/zfs snapshot -r<EMAIL_ADDRESS>... DONE
NOTE: No action will be performed on<EMAIL_ADDRESS>Scrub is running on pool.
NOTE: No action will be performed on<EMAIL_ADDRESS>Scrub is running on pool.
FATAL: trying to delete zfs pool or filesystem? WTF?
  This is bug, we definitely don't want that.
  Please report it to https://github.com/graudeejs/zfSnap/issues
  Don't panic, nothing was deleted :)

I'm not really sure what went wrong, or what additional information I should provide, so please let me know how I can help.

Closing, as this seems to be resolved in the 2.x codebase.
---Alex


GetDesc() is not working as intended.

I get the kick message above if theres a description of my ban using this script:
`local Trello = require(script.Trello.Main)
local MainBoard = Trello:GetBoardByName("MyGameBanList")
local Banned = MainBoard:GetListByName('Banned')
function checkBanned(Player)
local isBanned = Banned:GetCardByName(tostring(Player.Name))
if isBanned then
local reason = isBanned:GetDesc()
if reason == nil or reason == "" then
Player:Kick("You have been banned from this game. No reason written.")
else
Player:Kick("You have been banned from this game. Reason:"..reason)
end
end
end
-- Check for players yet to come
game:GetService('Players').PlayerAdded:Connect(checkBanned)
-- Check for players that already arrived
for _,p in pairs(game:GetService('Players'):GetPlayers()) do
checkBanned(p)
end
while true do
wait("25")
for _,pp in pairs(game:GetService('Players'):GetPlayers()) do
checkBanned(pp)
end
end
print("All set!")`

After analyzing your code, it appears that the problem does not originate on the API, but rather, in the Kick() method.
This is because the kick message in the screenshot does not even show a kick reason, despite the fact that your script does include it.

When i delete my self from banned list i dont get kicked but when i add my self to list without a reason
kick message is this: You have been banned from this game. No reason written.
but when i add a description it gives the kick message you saw in screen shot

Use elseif not reason == nil or reason == "" then kick("kick message"..reason)

Fixed

Closing issue as this has been fixed.


Strange behavior when asserting an output signal

I have some code which reads:
    xer_ov_o = dut.o.xer_ov.data
# ...
    comb += Assert(xer_ov_o == dut.i.xer_ov)

This assertion always fails when I run the formal check.  However, if I change the above assertion to:
    comb += Assert(dut.o.xer_ov.data == dut.i.xer_ov)

then the assertion works!  (If it helps, dut.o.xer_ov.data is a Signal(2).)
I'm not sure why this should be an issue; both dut.o.xer_ov.data and xer_ov_o should refer to the same Python object.  Why should this be an issue?
Thanks.

Disregard this issue; I had a small typo which got past two code reviews, but as Murphy's Law applies, I just found it after opening the ticket.  :/


IDAM - Role-Based Access Control

Placeholder - M
RBAC will be needed for the Data Curator UI, so that only curators can access that functionality

Closing, as this was a placeholder card for grant forecasting purposes.


[Android] Fix filepicker crash issue.

This patch is to fix the filepicker crash issue on some customized ROMs.
In some ROMs, "/sdcard/Pictures" was removed, verify this directory
before create image file.
BUG=XWALK-3983
(cherry picked from commit 52ab32b1fd637e6652d9250c290b904621f035ca)

@lincsoon Please merge this patch to crosswalk-14, thanks.


Popover is popping under on server status page

Issue: https://github.com/intel-hpdd/GUI/issues/4
On the Configuration > Servers > Add More Servers
The popup that lists the desired hostnames to add was showing up behind other elements.

Changed the .popover css z-index value to correct the stack order for the element.

Signed-off-by: Peter Robinson<EMAIL_ADDRESS>

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   94.74%   94.74%
=======================================
  Files         315      315
  Lines        4204     4204
  Branches      513      513
=======================================
  Hits         3983     3983
  Misses        198      198
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a7cf5...b437507. Read the comment docs.