Godot 4.1.2 crashes when upgrading a project made on 3.X in MacOS

Godot version
v4.1.2.stable.official [399c9dc39]
System information
MacOS 14.0 (23A344), Apple M1 Max
Issue description
Hello, I have recently decided to upgrade my project to 4.X, from 3.5.3, where it worked without any issues. It's a fairly large project, with tons of code and assets. When trying to upgrade the project, Godot crashes without any kind of error, in MacOS.
I've attached the MacOS error log (mac-error.txt), and the output of running Godot with the --verbose command (godot-verbose.txt):

godot-verbose.txt
mac-error.txt

Please note that this does not happen with an empty project, but it happens with my existing game. Also, I have tried to upgrade before to Godot 4.0, and the upgrade worked back then, so this error appears to be introduced with 4.1.
Steps to reproduce
Here is what happens, step by step:

I open Godot 4.1.2, and I click on my project.
I get the "Selected project was created in 3.X, and needs to be converted" modal. I click "Convert Full Project".
I get the "This option will perform full project conversion" modal. I click OK.
A new Godot window, with the "Made with Godot" splash screen appears for a moment, then disappears.
I click on my project again, this time the full Godot Editor opens, with a loading bar that says "(Re)Importing assets" at 0%.
Godot engine crashes, with no progress in the loading bar. I get the "Godot quit unexpectedly" MacOS error modal.

Minimal reproduction project
Since this does not happen with a fresh project, and since I don't know what causes the crash, I do not know how to provide an MVP. My project is pretty big, and I don't feel comfortable sharing the whole thing.

Just tested, and this issue does not exist in Godot 4.0.4, and it still exists in Godot 4.2 dev 6.

Alright, tested every version between 4.0.4 and 4.1.2, and it appears that this crash was introduced in 4.1-dev3. All 4.X versions before it work, and all versions after crash.

One last comment, opening 4.1.2 after upgrading the project via 4.0.4 works fine, it appears that the issue only affects the upgrade process.


UI testing infrastructure

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Possible Solution

Need to integrate UI testing using https://github.com/cypress-io/cypress or similar framwork.
Context

Currently we have some limited amount of tests for CVAT UI. It leads to regressions which affects our community and customers.

several tests were already integrated


[Algorithm] Improve LBFGS performance

When running the benchmark for the MadNLP paper, I noticed the performance of MadNLP's LBFGS was behind Ipopt's LBFGS. Investigating it further, I noticed that:

LBFGS was not taking into account the fixed variables when present;
LBFGS was not scaling the constraints properly when calling jtprod!;
a check was missing to discard the update if the vectors sk or yk are null (leading to NaN in the algorithm and ugly failures).
LBFGS matrix was not initialized properly at iteration 1.

This PR fixes all these issues. In addition, we made the following changes

reset the LBFGS matrix if too many updates are skipped (similar behavior as in Ipopt) ;
add new options to the algorithm (sigma_min, sigma_max, init_value)
add Gilbert & Lemaréchal rule to initialize the LBFGS matrix at the first iteration.

With all these changes, we improve by a significant margin the robustness and the performance of the LBFGS algorithm. Comparing the performance with Ipopt's LBFGS on the CUTEst benchmark (instances with less than 1,000 variables), we get the following performance profile (in term of number of iterations):

Codecov Report
Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (9a4ce89) 73.21% compared to head (11dab23) 69.37%.
Report is 9 commits behind head on master.

Files
Patch %
Lines

lib/MadNLPHSL/src/ma77.jl
0.00%
18 Missing :warning:

lib/MadNLPHSL/src/ma86.jl
0.00%
16 Missing :warning:

lib/MadNLPHSL/src/ma97.jl
0.00%
8 Missing :warning:

src/quasi_newton.jl
88.63%
5 Missing :warning:

lib/MadNLPHSL/src/ma27.jl
0.00%
3 Missing :warning:

lib/MadNLPHSL/src/ma57.jl
0.00%
3 Missing :warning:

src/IPM/kernels.jl
97.22%
1 Missing :warning:

src/IPM/solver.jl
75.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   73.21%   69.37%   -3.84%
==========================================
  Files          41       40       -1
  Lines        4756     4542     -214
==========================================
- Hits         3482     3151     -331
- Misses       1274     1391     +117

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I used the script in MadNLPBenchmarks.jl: https://github.com/MadNLP/MadNLPBenchmark.jl/blob/main/cutest/lbfgs/benchmark.jl
If you want, I could include it in the local benchmark directory as well.
Long term, do you think we should keep the benchmark directory in MadNLP, or should we move all the benchmarks into MadNLPBenchmarks.jl?

@frapac indeed it would be better to separate the benchmark script in MadNLPBenchmark.jl. No need to include it here. Looks good to merge


Auto retry after database deadlock

Rationale
Although best avoided deadlocks happen, and the correct thing to do is retry.  Here is a simple retry strategy to automatically retry GET requests that deadlock (probably not as common as POST, but it can happen).

I had this floating around, what do you guys think?


About versions in this repository

master - commits that will be included in the next major release (breaking changes)
next - commits that will be included in the next minor or patch release

Most PRs should be made to master, unless you know it is a breaking change.

Should it be unless you know it is ** NOT ** a breaking change.?

I think those are slight outdated, currently master points v6, stable is for v5.x. (next is unused anymore)


Bug: Arrow keys UI element flashing

When navigating the page via the arrow keys, various UI element start flashing as if they're being selected.
I find this is very annoying when navigating the page.
https://github.com/user-attachments/assets/976885f0-3167-40b9-9b09-6348891d7648

Hmm, I think this is a vanilla issue that Scribble somehow triggers. I'll see if I can fix it!


Does activation also happen when a profile changes from "entered" to "Existing" status?

Issue in ./help/destinations/ui/activate-batch-profile-destinations.md
Can we clarify in the docs when a profile goes from "entered" to "Existing" segment status - is a record activated? Or is a record only activated when a user goes from null to "entered"?
"If the segmentMembership.status field is selected, exported files include Active members in the initial full snapshot and Active and Expired members in subsequent incremental exports."
"If the segmentMembership.status field is not selected, exported files include only Active members in the initial full snapshot and in subsequent incremental exports."

Thank you for submitting this issue. We will review the documentation and make the necessary updates as quickly as possible. Tracking internally in PLAT-137525.


Either fix or clarify hardcoded namespace in secrets sync

https://github.com/nre-learning/syringe/blob/master/scheduler/secrets.go#L14

This was implemented as a config option in https://github.com/nre-learning/syringe/pull/151


Not turning lights off properly

Sometimes when I turn off the light from home assistant, the fan dims to like 2%. But does not turn off the light. This never happens from the official app.

I have noticed the same. To switch off I send dim-level zero, but I suspect there might be a seperate switch off command.
This means to set up capturing of bluetooth communication between app and fjäråskupan, something like here https://support.honeywellaidc.com/s/article/How-to-capture-Bluetooth-traffic-from-and-to-an-Android-Device
Will do sometime when I have the time for it...

Maybe you can find the right command here?
https://github.com/elupus/fjaraskupan/blob/master/src/fjaraskupan/__init__.py

I have noticed the same. To switch off I send dim-level zero, but I suspect there might be a seperate switch off command. This means to set up capturing of bluetooth communication between app and fjäråskupan, something like here https://support.honeywellaidc.com/s/article/How-to-capture-Bluetooth-traffic-from-and-to-an-Android-Device Will do sometime when I have the time for it...

Maybe you can find the right command here:
https://github.com/elupus/fjaraskupan/blob/master/src/fjaraskupan/__init__.py

@jacobhallgren Try this, seems to work! I'm using a toggle command for to switch off the light and I think it will not have any sideeffects where it turns the light on when it shouldn't.

@leifmariposa Is it not possible to send a off command? Sometimes the pi misses a command and HA think that the light/fan is off when it's not. Is it possible to make ha force refresh and poll the state of the hob?

Haven't found any off command, therefore the toggle command. After every command sent there is a delay and then the state is read to update HA.

@leifmariposa Ok, So the "original" app sends a toggle command for on /off? Yes but can I somehow trigger that update via a call or so from HA? Since it gets it wrong sometimes.

Yes! If you install button-card in HACS, then you could add a custom button card that calls the fan light service, like this:
type: custom:button-card
name: Toggle fan light
tap_action:
action: call-service
service: shell_command.set_kitchen_fan_light
service_data:
value: 0
This will toggle the light on/off. If you change the value to something other than zero, it will be set to that value.
If you have any other control for the fan light, e. g. a slider, it will be updated after a little while after that you have called the service.
Just a thought, if it gets it wrong sometimes maybe the raspberry pi isn't close enough to the fan? Mine is about three meters away and I rearly have communication problems.

@leifmariposa Ok, I wanna update the status without doing anything to the light. How can I do that? "just read the status" The pi is close to it. Like 2 meters.


Truncate doesn't seem to work

I may have broke this.

I realized that this commit wasn't carried over to the epic branch. I tried copying the code in the last 3 commits, but it still doesn't seem to work.

I had a sloppy fallthrough branch in a switch. Should be good now!


Set a convention for docstrings

I suggest either the Google Python style or the sphinx convention
Also see PEP257 docstring convention.
Once we agree on a convention, we should update: https://github.com/neuropoly/ivado-medical-imaging/blob/master/CONTRIBUTING.md#developing

I do have a slight preference for the Google Python style.


Integrate the programs shutdown feature.

Integrate the "shutdown of programs" and "install the not installed programs during opening the programs" features.

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Open calculator
You: OPEN CALCULATOR
Dragonfire: CALCULATOR NOT FOUND! DO YOU WANT TO INSTALL?
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Yes
You: YES
Dragonfire: I WON'T INSTALL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: open files
You: OPEN FILES
Dragonfire: FILE MANAGER
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: close files
You: CLOSE FILES
Dragonfire: FILE MANAGER CLOSED
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: open camera
You: OPEN CAMERA
Dragonfire: CAMERA NOT FOUND! DO YOU WANT TO INSTALL?
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: yes
You: YES
Dragonfire: CHOOSE ONE OF FOLLOWING:
KAMOSO
SNAP-PHOTOBOOTH
CHEESE

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: 1
You: 1
Dragonfire: PLEASE REPEAT!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Dragonfire: WELL, MAYBE ...
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: KAMOSO
You: KAMOSO
Dragonfire: PLEASE REPEAT!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Dragonfire: THE MONKEY! HE'S A WHEEL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: open camera
You: OPEN CAMERA
Dragonfire: PLEASE REPEAT!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Dragonfire: CAMERA NOT FOUND! DO YOU WANT TO INSTALL?
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

yes
You: YES
Dragonfire: CHOOSE ONE OF FOLLOWING:
KAMOSO
SNAP-PHOTOBOOTH
CHEESE

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: KAMOSO
You: KAMOSO
Dragonfire: PLEASE REPEAT!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Dragonfire: THE MONKEY! HE'S A WHEEL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Above is the conversation dump of my tests for this PR.
Seems like something is broken. I sat "Open calculator" and give answer "Yes" but she says: "I WON'T INSTALL!".
When I say "Open camera" and "Yes" she says:
Dragonfire: CHOOSE ONE OF FOLLOWING:
KAMOSO
SNAP-PHOTOBOOTH
CHEESE

and even though I answer as "1" or "KAMOSO" she says "PLEASE REPEAT!". First of all it should not even happen. Why is she asking for me to choose an application? She should try to install all of the alternatives automatically. Only one or two will be available in the package repository of the distro. For sure this feature is completely broken, please fix it and update your PR.
By changing it to return userin.say(userin.execute(cmds, "LibreOffice Writer", user_answering)) or return userin.say(userin.execute(cmds, "Web Browser", False, 0, is_kill)) you made it overly complex. Sometimes you are passing is_kill parameter and sometimes not, that's not OK. Also if it's a keyword argument pass it like is_kill=is_kill for the sake of readability.
cmds = [["konsole", "--command=sudo apt install " + com], ["gnome-terminal", "--command=sudo apt install " + com]] is not the way of doing this. There are cases that binary executable name in the PATH does not match to the package name. You should specifically define the package name for the each program that Dragonfire supports. Also use apt-get install instead of apt install for backward compatibility. Before Ubuntu 16.04 there was no such thing as apt.

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

You: YES
Dragonfire: INSTALLING CALCULATOR...
Dragonfire: CALCULATOR HAS BEEN INSTALLED
Dragonfire: OPENING CALCULATOR
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

You: CLOSE THE CALCULATOR
Dragonfire: CALCULATOR HAS BEEN CLOSED
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Here is the conversation dump of the current state of your PR:
Enter your command: hey
You: HEY
Dragonfire: SIR, TELL ME YOUR WISH.

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Yes
You: YES
Dragonfire: OKAY, I WON'T INSTALL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: file manager
You: FILE MANAGER
Dragonfire: OUCH!

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: yes
You: YES
Dragonfire: INSTALLING WILL START, PLEASE ENTER YOUR ROOT PASSWORD.
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Dragonfire: INSTALLING WILL START, PLEASE ENTER YOUR ROOT PASSWORD.
  She should have start to install calculator after I say "Yes" and with lower case input "yes" she said "INSTALLING WILL START, PLEASE ENTER YOUR ROOT PASSWORD." but nothing happened.
On the other hand, I moved some of the commands like "File manager", "Software center", "Office suite" to outside of the block that checks for verbs like "Open, Run, Start" for fixing the commands to match with the examples given in README.md. But you have reverted back my changes so it's not OK.
Why are you passing a dictionary if the shell command is exactly the same in each distro?:
cmds = [{'distro': 'KDE neon', 'name': ["sensible-browser", wikipage.url]}, {'distro': 'Linux Mint', 'name': ["sensible-browser", wikipage.url]}, {'distro': 'Ubuntu', 'name': ["sensible-browser", wikipage.url]}, {'distro': 'elementary OS', 'name': ["sensible-browser", wikipage.url]}]
cmds = [{'distro': 'KDE neon', 'name': ["echo"]}, {'distro': 'Linux Mint', 'name': ["echo"]}, {'distro': 'Ubuntu', 'name': ["echo"]}, {'distro': 'elementary OS', 'name': ["echo"]}]
cmds = [{'distro': 'KDE neon', 'name': [" "]}, {'distro': 'Linux Mint', 'name': [" "]}, {'distro': 'Ubuntu', 'name': [" "]}, {'distro': 'elementary OS', 'name': [" "]}]

You did not met the condition that I stated on my previous comment:

By changing it to return userin.say(userin.execute(cmds, "LibreOffice Writer", user_answering)) or return userin.say(userin.execute(cmds, "Web Browser", False, 0, is_kill)) you made it overly complex. Sometimes you are passing is_kill parameter and sometimes not, that's not OK. Also if it's a keyword argument pass it like is_kill=is_kill for the sake of readability.

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Yes
You: YES
Dragonfire: INSTALLING CALCULATOR...

______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Open files
You: OPEN FILES
Dragonfire: OKAY, I WON'T INSTALL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Also you messed up some built-in commands that are not starting with Open verb:
Enter your command: Open files
You: OPEN FILES
Dragonfire: FILE MANAGER
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Close files
You: CLOSE FILES
Dragonfire: FILE MANAGER HAS BEEN CLOSED
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: Close browser
You: CLOSE BROWSER
Dragonfire: WEB BROWSER IS NOT OPEN!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: photo editor
You: PHOTO EDITOR
Dragonfire: TWENTY-SIX MINUTES.
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: photoshop
You: PHOTOSHOP
Dragonfire: THE MONKEY! HE'S A WHEEL!
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: gimp
You: GIMP
Dragonfire: WE'RE IN THE SUB. UNHARMED.
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: open gimp
You: OPEN GIMP
Dragonfire: THE PHOTO EDITOR SOFTWARE
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

Enter your command: close gimp
You: CLOSE GIMP
Dragonfire: THE PHOTO EDITOR SOFTWARE HAS BEEN CLOSED
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________

This change is wrong.
It does not seem correct to use string operations approach in here:
if "install**" in msg:
    msg = msg.replace("install**", "")
    program_name = name[1].replace("apt-get install ", "")

Installation cannot be canceled but can fail:
self.say("Installation Cancelled!")

Is exist what? if is_exist: Bad variable name choice.
You should investigate the possible solutions in python-apt package.
Closing the programs seems partially work. I tried to close the browser and it does not work.
Still I don't understand why do you push to different feature additions in a single PR.
If you are defining a long array or a long dictionary use multiple lines. Not like this:
cmds = [{'distro': 'KDE neon', 'name': ['korganizer']}, {'distro': 'elementary OS', 'name': ['maya-calendar']}, {'distro': 'Ubuntu', 'name': ['orage']}, {'distro': 'Linux Mint', 'name': ['gnome-calendar']}]

gksudo is not avaiable in KDE environment. For KDE there is kdesu but it's not in PATH so you should symlink with sudo ln -s /usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu /usr/bin/kdesu. python-apt might have a better solution than using gksudo or kdesu.

Into this file: https://github.com/DragonComputer/Dragonfire/pull/107/files#diff-b101058c230a3453693341927e0b4472 :
cmd(str) object replace with the  cmds(dictionary) object. And under the try/except(starting from line 91) block userin.execute() function is checking the program that is user wants to open is exist, and according the answer, opening program or installing it.
else block it is starting from line 140,  is for closing the programs that are user wants.
into this file: https://github.com/DragonComputer/Dragonfire/pull/107/files#diff-bfed9051c289971a1b77ef0deacd2d18
Realized changes are for to use userin.execute() function return value.
into this: https://github.com/DragonComputer/Dragonfire/pull/107/files#diff-b037cff70e110194387688ac9a8148ad and this files: https://github.com/DragonComputer/Dragonfire/pull/107/files#diff-06a0a7f80f5a8171b61442b361642c99
Realized changes are for to use the first parameter userin.execute() function that is changed into the utilities.py, as dictionary object.
and the other files for the adding requirements that is psutil into the setup.py, install.sh and the other necessary places.

Mister, I did not find the cause of the failure. It looks because of the result of omniscient.py. Have you any idea about that?


[DV] Continue argument parsing

In case one of the arguments is '-h' the parsing of the arguments is
aborted and only PrintHelp() of verilator_sim_ctrl.cc is executed.
Do not abort at this point in order to forward the arguments to the
registered extensions. This allows to execute the respective
PrintHelp() function and print the help message. For example
VerilatorMemUtil needs to parse the arguments in order to print the
help message.
The execution of the simulation is still terminated as exit_app is set
and then evaluated after parsing of the registered extensions.

Yes, the splitting is not ideal, I was thinking about creating a buffer to collect all messages and then do the printing in the end, but that seemed too much trouble :)


[Hub Generated] Review request for Microsoft.Help to add version stable/2023-06-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

This is a stable version of the preview version 2023-01-01-preview. The preview version has been approved and merged into the public repo.

This is a stable version of the preview version 2023-01-01-preview. The preview version has been approved and merged into the public repo.

can you link the preview version pr ?
And is there any new changes between this stable and preview?

This is a stable version of the preview version 2023-01-01-preview. The preview version has been approved and merged into the public repo.

can you link the preview version pr ? And is there any new changes between this stable and preview?

Sure. The preview version is 2023-01-01-preview.  https://github.com/Azure/azure-rest-api-specs/tree/main/specification/help/resource-manager/Microsoft.Help/preview/2023-01-01-preview No breaking changes. Except for some minor change on examples to make it look better and for better SDK generation.

/azp run


How to delete “friends”?

Really cool app so far. Was testing it out, and made a test group with dummy friends. Now I want to actually use the app with real friends, but I can’t seem to delete these dummy friends? I’ve deleted the test group, but the dummy friends remained. Any way of deleting them? Thanks

Update: Figured it out. You have to go to “Balances”, click on the “friend”, and then there’s a delete/bin button in the top right.
You should think about adding a specific section in settings or elsewhere for managing friends, cause that’s not super intuitive. Thanks.

@TaylorJKing thanks for the feedback, i have to work on this local friends a bit, the app is not architectured that way. i'll think about it.

@TaylorJKing thanks for the feedback, i have to work on this local friends a bit, the app is not architectured that way. i'll think about it.

That’s alright, not the end of the world; would just be a nice feature. Using dummy emails for now is fine.

it's actually a problem for splitpro personally, cuz it tries to send email it bounces. so i'm goin to figure out a way soon


Add Monster Spawner changes from 1.18 Experimental Snapshot 2

Mob spawners that spawn mobs that would normally require light level 0 with this mod (e.g skeletons, zombies, cave spiders, creepers, spiders) would be able to spawn those mobs at light level 11 and below to make mob spawners much more of a challenge.
Feature Description

Monster spawners found in structures throughout the world should be able to spawn mobs at a higher light level than 0. As I've found that with this mod, spawners are way too easy to disable as any light at all will stop them from functioning, making them even easier to disable than in vanilla.
To be consistent with 1.18 experimental snapshot 2 mobs spawners should be able to spawn mobs at light level 11 or below to make them much more of an interesting challenge. If this is too hard for some then this could be provided as a config option instead.
Context and Inspiration

This feature was taken/ inspired by the 1.18 experimental snapshots which implemented this change to make mob spawners harder and not too easy as a result of the change to light level 0 for mobs spawning.
I was inspired to suggest this idea, as when encountering mob spawners in my Forge 1.16 modpack with this mod installed, they were just way too easy to disable as they seemed to adhere to the light level 0 rule implemented by this mod which I don't think should be the case.
It changes mob spawners to allow them to spawn hostile mobs at light level 11 and below for consistency with 1.18 experimental snapshot 2. This could also be configurable if desired.
Have you already discussed the feature using the discussion feature?

No, as the links to those pages don't lead anywhere.

Oop, I guess I forgot to enable the discussion feature. That's fine for this suggestion because it looks good.
I was offline for a week and missed that this was changed in 1.18 ex snapshot 2. I'll implement it soon as I'm going to be porting to forge soon as well.


bin/adobe commerce

Issue in ./help/inventory-management/cli.md
Hey guys I've tried the bin/Adobe Commerce command but it does not work. :)

@leslietilling https://github.com/AdobeDocs/commerce-admin.en/commit/5d26560bfefeb91e4a3d6024eebc523a90362f8e
Looks to have introduced many instances of bin/Adobe Commerce across the docs. These need to be reverted to bin/magento.

Fix is here: https://github.com/AdobeDocs/commerce-admin.en/commit/bff07f82bf5853d73f38b751d125ab61c35e8eb4


More info needed on stl atributes

hi.
Can you add more information on what v0,v1,v2 ..represent in this code?
your_mesh.v0, your_mesh.v1, your_mesh.v2
Thanks.

The v0, v1 and v2 are the vectors and they come straight from the STL files.
Simply put, a triangle consists of 3 points and the vectors contain those 3 points. For ease of use you can also use your_mesh.points which reshapes the data into x0, y0, z0, x1, y1, z1, x2, y2, z2
Or you can use your_mesh.x for all of the x coordinates and so on for y and z.

Perhaps this bit of the documentation might help a little: https://numpy-stl.readthedocs.io/en/latest/stl.html#stl.base.BaseMesh


Bugfix/#183 migrate or replace resource server token services, in order to allow authentication to our public api via bearer token in the header

Two different things were done on this branch:

Put the ResourceServerTokenServices to work, so that users can authenticate to our public API via a BEARER Token on the header
Migrated the Public API documentation to the last version called springdoc-openapi-ui (with this 3 dependencies were removed regarding the swagger fox)

This branch was created from the bugfix/#182 branch
closes coatrack#183

@BrunoSilvaATB There is an unresolved merge conflict, could you solve it please?

@ChristophBaierATB regarding all of your suggestions about the OauthUserDetailsService, I will solve it on the branch bugfix/#182.
I will also put as target branch of this PR, the #6 to avoid confusion between both branches, as this branch was created from that one


Dalli::MarshalError is not instrumented like other errors

With dalli 2.7.10 Dalli::MarshalError is logged but is not sent to instrumentation.
Example snippet that correctly receives error notification when memcached is stopped:
> ActiveSupport::Notifications.subscribe(/cache_.+\.active_support/) { |*args| puts "cache event: #{args}" }
...

> Rails.cache.write 'something', 'value'
cache event: ["cache_error.active_support", 2020-04-08 16:02:55 -0300, 2020-04-08 16:02:55 -0300, "702c310eae852f81a822", {:key=>"DalliError", :message=>"No server available"}]
cache event: ["cache_write.active_support", 2020-04-08 16:02:55 -0300, 2020-04-08 16:02:55 -0300, "702c310eae852f81a822", {:key=>"something"}]
=> false

But when the memcached is running and I am trying to cache something non marshallable the error is not instrumented:
> ActiveSupport::Notifications.subscribe(/cache_.+\.active_support/) { |*args| puts "cache event: #{args}" }
...

> Rails.cache.write 'something', -> { 'no marshalling for this one' }
cache event: ["cache_write.active_support", 2020-04-08 16:05:15 -0300, 2020-04-08 16:05:15 -0300, "702c310eae852f81a822", {:key=>"something"}]
=> false

But I can see it in logs:
Marshalling error for key 'dev:something': no _dump_data is defined for class Proc
You are trying to cache a Ruby object which cannot be serialized to memcached.
/Users/bak1an/.rvm/gems/ruby-2.3.6@di/gems/dalli-2.7.10/lib/dalli/server.rb:413:in `dump'
	/Users/bak1an/.rvm/gems/ruby-2.3.6@di/gems/dalli-2.7.10/lib/dalli/server.rb:413:in `serialize'
	/Users/bak1an/.rvm/gems/ruby-2.3.6@di/gems/dalli-2.7.10/lib/dalli/server.rb:285:in `set'
	/Users/bak1an/.rvm/gems/ruby-2.3.6@di/gems/dalli-2.7.10/lib/dalli/server.rb:70:in `request'
	/Users/bak1an/.rvm/gems/ruby-2.3.6@di/gems/dalli-2.7.10/lib/dalli/options.rb:19:in `block in request'
...

Looking at the code I would expect MarshalError to be instrumented just as the other errors, not sure why it is not happening now.

Found the place where MarshalError is consumed - https://github.com/petergoldstein/dalli/blob/master/lib/dalli/server.rb#L71


[Feature][Iceberg] Support merge fragmented files when sink

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Support merge fragmented files when sink
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@hailin0 please assign it to me.


Get the first IP from X-Forwarded-For list

Fixes #88

Coverage remained the same at 97.409% when pulling a0f7ab9deaa362f9418d040f60b2d564021e9980 on bugfix/x-forwarded-for into 23cb1649a094f1497db57873f8f7660e188105ef on master.

@marcosbarbero
Can you please add a test in DefaultRateLimitKeyGeneratorTest like the testKeyOriginBehindProxy that has multiple values in the "X-Forwarded-For" header?

@lchayoun here you go


Alexlovelltroy/build improvements

Adding build automation from the work I did for smd that leads to better version reporting, multiarch containers, and native packages

We should probably also update the README with build instructions using goreleaser (e.g. setting the env vars).

Commenting here for posterity: .Arm64 was introduced in Goreleaser v2.4 so at least that Goreleaser version is required (see: https://goreleaser.com/customization/templates/#single-artifact-extra-fields).
Otherwise one will get the following error:
  ⨯ release failed after 2m34s               error=template: failed to apply "dist/bss_{{ .Os }}_{{ if eq .Arch \"amd64\" }}{{ .Arch }}_{{ .Amd64 }}{{ else if eq .Arch \"arm64\" }}{{ .Arch }}_{{ .Arm64 }}{{ else }}{{ .Arch }}{{ end }}/boot-script-service": map has no entry for key "Arm64"


New eigenvector gradient regularization scheme

Motivated by https://github.com/facebookresearch/fmmax/issues/105, a new regularization scheme.

Updates the regularization scheme to use an eps value which depends upon the range of eigenvalues.
Adds some documentation which references approaches that various papers have used.
Adds tests which compare gradients to those computed by jnp.linalg.eigh, which is differentiable "out of the box". The tests include matrices with shifted and scaled eigenvalues, which would fail with the previous regularization scheme.

@elinorbgr could you test this?
@smartalecH good to get your eyes on this also

So, I have not done extensive testing (and doing so would likely require me to retune all my optimizer hyperparameters), but from the light testing I've done, this new scheme (including the latest commit) does seem to behave quite well on my setup, possibly even better than what I was getting before by setting $\epsilon = 10^{-20}$ :+1: .


Fixed exception on windows when contention happens in file cache

Catch exception that happens in file cache on Windows when two or more processes attempt to write the same file that is already open by some other process, and therefore cannot be written because it is locked (that's how files work on Windows).
Fixed #2777 .

New contributor declaration

[x] I am not making a trivial change, such as fixing a typo in a comment.

[x] I have written a PR description following these
rules.

[x] I have run pre-commit run --from-ref origin/main --to-ref HEAD.

Select one of the following.

[ ] I have added tests.

/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests

[x] This PR does not need a test because all unit tests test this functionality when run with xdist.

Select one of the following.

[x] I have not added any lit tests.
[ ] The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)

While this patch fixes the main source of PermissionError exceptions in FileCacheManager.put function I now see rare occurrences of PermissionError when Triton code tries to read files from the cache. They are possibly unrelated to this particular fix and happened previously too, just much less frequently.
I've converted PR to a draft while I continue to investigate and look for a complete fix of xdist tests on windows.

Merged as a part of #3075.


Confirmation of Delete popup has a typo.

Currently, the delete confirmation window has the word project hardcoded. The popup also is not shown when deleting a project or a file. The objective is to have one popup module that can be called by any other component. So make the description(project, file, workflow, execution) a variable.

fixed by PR #1580


Fixed compilation error regarding a lack of std:: before usize::MAX

On Windows 10, trying to create a TUI application but I get a compilation error in v0.10.0 as follows:
PS C:\Users\JT\Documents\Rust Projects\tui> cargo run
Compiling tui v0.10.0
error[E0599]: no associated item named MAX found for type usize in the current scope
--> C:\Users\JT.cargo\registry\src\github.com-1ecc6299db9ec823\tui-0.10.0\src\buffer.rs:266:47
|
266 |         self.set_stringn(x, y, string, usize::MAX, style);
|                                               ^^^ associated item not found in usize
help: you are looking for the module in std, not the primitive type
|
266 |         self.set_stringn(x, y, string, std::usize::MAX, style);
|
so I changed the source and tested my fork as a local crate and it passes.

Could you precise the version of rustc you are using ? tui requires 1.44+ from 0.10.0. I made this clearer in #346.

That was the issue. Turns out I was running rustc 1.41.0. Just updated to 1.45.1 and it works. Thank you for your help! :)


is smoothscroll available for JFXListView?

Hi is smoothscroll available for JFXListView?

Hi, no it's only available for ScrollPane yet. Feel free to add your own contribution to JFoenix.
Regards,


Fixes for WSUB Handling

This PR fixes the WSUB handling for non 2-moment cases. This was exposed in L181 runs (see https://github.com/GEOS-ESM/GEOSgcm/issues/540) because the new WSUB file used in Moist is L72 only.
Note: This does NOT fix the issue that 2moment cannot be run at anything other than L72 (or anywhere but NCCS). That is something @dbarahon will need to fix in Moist.

This seems to be zero-diff for BACM_1M (I think only 2moment uses the WSUB file anyway).


Sendgrid option doesn't accept valid keys

Some keys are in the format SG.something.-something-xxx which are not valid hostnames and fail Pydantic validation

Probably need to pass the key through urllib.parse.unquote like we did with the AWS keys (and other secrets), though it will require the user to convert it on the way in.

Will also need to address TAKAHE_MEDIA_BACKEND with the same changes, when using the access key + secret key in the URL it also hits a validation error when special chars are used

The AWS media backend should already accept url encoded input. Not sure I documented that though.
Functionally, the inputs should always be encoded.

I kinda wonder if these URL strings are the best way to load these config values. Asking everyone to urlencode all the inputs is a hassle, and may be a constant headache.
I can make a script to convert input strings, but that seems like a bit of a crazy hack compared to passing values in using more environment variables.

The URL strings are handy up until a point, but we did start out with just separate TAKAHE_SENDGRID_KEY env vars and stuff. Need to think about it.

@tabletcorry Ahh url encoding ended up fixing my deployment, but the env variable was being passed in dynamically so encoding that may not be an option for folk who use an automated pipeline.
In my opinion, we should keep most of the validation in (as it works for 95% of usecases) but add in additional setup env variables to control specifics (like TAKAHE_SENDGRID_KEY).


how to train？？

first you need to make your DIY_dataset using main_create_training_set.py, then run train.py to train.

but the origin codes have some problems, maybe you could wait for my codes later. I'll upload them to  this repository later.


https://github.com/openmaptiles/maptiler-basic-gl-style/releases/download/v1.9/v1.9.zip

https://github.com/openmaptiles/maptiler-basic-gl-style/commit/26b0b9124c4b1df59d413d9bba0ed1566d4199d5

@Queens666 can you please stop "spamming" in the Leaflet Repo?


Fix a typo in README

I wasn't keen on the comment, so I just committed something like this that is slightly more clarifying. Thanks!


chore: v1

Just wanted to see the diff for this PR. Closing, but will keep the branch for history :)


Update linter rules for better extensibility

Sometimes VS Code automatically adds imports, but instead of doing importing from foo, it will import from @salesforce/retail-react-app/node_modules/foo, which is not something that we want. I added a linter rule to catch this. It's in the monorepo root because it only impacts the monorepo. (If anyone has a way to make VS Code not do this, I'd also appreciate that as a solution!)

The rule to map replace relative imports with @salesforce/retail-react-app imports also only impacts monorepo development, so I moved that rule to the monorepo root as well. This also fixes npm run lint for generated projects that don't use extensibility. It was previously broken because the eslint plugin was specified as a dev dependency in pwa-kit-dev, and therefore wasn't installed in generated projects.

Description

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

Paste this in any JS file:

import {useIntl} from '@salesforce/retail-react-app/node_modules/react-intl/index'

Linter should report an error!

Generate a new project with create-mobify-app-dev.js that does not use extensibility.

Executing npm run lint in the generated file should work.

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Everything looks fine an dandy, but there are some lint errors that are in the freshly generated project. Do you mind seeing what is going on there before merging.

Fixed!

With respect to your question about how you might disabled vscode form auto inserting imports, this might be the ticket.

That disables auto imports entirely. Auto imports work fine in 99% of places, so I don't want to do that. It's just inside packages/template-retail-react-app that they're weird.

Although think the rule that you created is a sane default. Do we have the option of adding more descriptive text to say that ignoring this rule will result in extensibility being broken?

Sadly, nope. But the rule is an error, so we'll never pass CI with bad imports, and it's auto-fixable, so we'll never have to think about the what/why.


Automated cherry pick of #3957: fix: 修复rds普通后台下账号权限问题

Cherry pick of #3957 on release/2.13.
#3957: fix: 修复rds普通后台下账号权限问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@e88cb21). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #3964   +/-   ##
==============================================
  Coverage                ?   6.94%
==============================================
  Files                   ?     505
  Lines                   ?   84971
  Branches                ?       0
==============================================
  Hits                    ?    5905
  Misses                  ?   78565
  Partials                ?     501

Flag
Coverage Δ

#aFlag
6.94% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/dbinstance_accounts.go
2.41% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88cb21...3fb33f9. Read the comment docs.

/approve
/lgtm


Validating EURO phone numbers

Hi sir,
Can you please tell me how I can validate a European phone number ?
(in other words... can you please add a regular expression for this, like you did for euro_date ?)
Some test data (for Belgium)
+32 ppp xx xx xx (mobile number in Belgium, always 3 digits for the provider)
+32 a xxx xx xx ( land number with one digit for the area)
+32 aa xx xx xx ( land number,  with 2 digits for the area)
this algorithm covers almost all possibilities in Europe
Thanks in advance for your reply,
Kind regards,
Johnny Driesen

Can you submit a PR yourself?
You simply have to look at the validation-rule.js file and just add a switch case. That would be great if you could.

OK.... Will give it a try this weekend, and will keep you posted.
Grtz,
Johnny

I will push a new revision soon for a small fix, then I started looking at the Regex you provided. This seems like a Regex for internal phone number, not really specific to Europe and it seems very loose since it's only checking for last numbers to be between 6 and 14.
I could maybe add this as phone_international, but is it really what you want, is it strong enough?

Since I add to push a new revision for another fix, I added as well the Regular Expression pattern that is mentioned in your article to create the new phone_international validation. It is now part of the latest version 1.5.4, be sure to update the package.
On another note, you wanted to know how to add a regex. You can use Regex directly with Angular-Validation see this Wiki - Regular Expression Pattern


⚠ Bofrost.es has degraded performance

In 65fe14c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1433 ms

Resolved: Bofrost.es performance has improved in c76baeb after 8 minutes.


Can't build on Linux

Error:
mkdir -p ./bin
cd lib/cglm && cmake . -DCGLM_STATIC=ON && make
/bin/sh: 1: cmake: not found
make: *** [Makefile:28: libs] Error 127

I tried to run make command, every time I get this error above.

Maybe I don't have cmake and that causes the error, but I would like you to mention that cmake is required in order to build this project.

This is definitely just cmake missing.

Error:
make[3]: Leaving directory '/home/jan/Tmp/minecraft-weekend/lib/cglm'
[100%] Built target cglm
make[2]: Leaving directory '/home/jan/Tmp/minecraft-weekend/lib/cglm'
make[1]: Leaving directory '/home/jan/Tmp/minecraft-weekend/lib/cglm'
cd lib/glad && clang -o src/glad.o -Iinclude -c src/glad.c
/bin/sh: 1: clang: not found
make: *** [Makefile:29: libs] Error 127

Yes, I got more errors ... I need clang also.

After installing cmake and clang, the project builds.

You could have installed build-essential by your package manager (like apt) or something.


feat: Migrate Notion source to Connector V2 structure

@mr-unstructured would you mind looking at this and seeing if this makes sense to add to your PR?
https://github.com/Unstructured-IO/unstructured-ingest/pull/166
Thank you!

@potter-potter Could you take another look? I've fixed what we talked about this afternoon. Please find attached the files you asked me (download, index and partition)
Archive.zip

Was this fix moved over as well, I want to make sure we don't lose that as part of this migration: https://github.com/Unstructured-IO/unstructured-ingest/pull/171

Was this fix moved over as well, I want to make sure we don't lose that as part of this migration: #171

Yup! Checked twice, it's here

Check if https://github.com/Unstructured-IO/unstructured-ingest/pull/186 is relevant for this PR

Can we also fold in this fix into this PR? https://github.com/Unstructured-IO/unstructured-ingest/pull/186

Can we also fold in this fix into this PR? #186

This was already in my async implementation from last friday

@rbiseck3 what happened to the original author? Is this still being worked on?

@hardchor Yes. Still being worked on. Different developer. Coming soon.

Please look at these PRs as well and potentially fold them in:
https://github.com/Unstructured-IO/unstructured-ingest/pull/208
https://github.com/Unstructured-IO/unstructured-ingest/pull/186


Websocket data compression

Hey,
I am using ratchet 0.3.6 and wanted to know if it supports permessage-deflate extension, I could find this only for 0.4?
If yes how do I  enable it?

This is currently open in a PR in the underlying library. It's not available at all in 0.3 but if you're using 0.4 you could pull in the branch of the PR to use it.

Hey just one more thing, what is the tentative timeline to  release a stable version of 0.4?

0.4 is considered stable, just not released yet. My day job has been tying me down but with 2 weeks of vacation coming up I plan on updating the website documentation and releasing 0.4

Cool. Thanks


Multiple typo fixes

Corrected for some typos I found while working through the exercises. Both in "./koans" and "./koans-solved".

Why the closing?

@phoe I thought I'd create a new pull-request because I screwed up with google-CLA.

I think it's enough for you to sign the CLA, amend your commit, and force-push your branch - the CLA check should then be repeated.

Which is absolutely right!


Request to update version of the mod for 1.8.9 to 1.3.7

1.8.9 Has one of the biggest download amounts for this mod, and I think one last update so that we can use this mod while using shaders would be greatly helpful to all players using this mod. Thank you.

Are you sure shaders don't work for this version? I thought that in versions 1.12.2 and less it worked with shaders without any special compatibility.
Regardless I don't have the time to be updating versions this old. It's not a version of Forge I'm familiar with modding. Also, of course the older versions have the biggest download counts, it's because they've been around the longest - doesn't mean they're still getting high volumes of downloads (and I highly doubt this for 1.8).


Update scala-compiler, scala-library, ... to 2.12.14

Updates

org.scala-lang:scala-compiler
org.scala-lang:scala-library
org.scala-lang:scala-reflect

from 2.12.13 to 2.12.14.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang" } ]

labels: library-update, semver-patch

CI failed because silencer hadn't been published for 2.12.14 yet

oh, we need to bump the silencer version, I think?


New data structure to support combined ARG Query

Can we please look at adding an additional column to support "combined" compliant and non-compliant queries.
@erjosito is aware of the ask :)

@fskelly I have modified the Excel, the checklists and the script, it would be great if you could have a look...


Create a document and/or a template repository to create actions with composite run steps

Example: https://github.com/reviewdog/action-golangci-lint/pull/46
We already have a docker based action template (https://github.com/reviewdog/action-template), but composite run based action is better in terms of speed, cache, build environment, non-linux platform support, etc...
If it's easy to install/build a static analysis tool without relying on Docker, composite run actions should be better.
e.g.

Tools with static single binary release (golangci-lint, etc...).
Node tools (eslint, etc...)

👀 Can I contribute this also for pip tool? reviewdog/action-yamllint


Add ClrGenericParameter

Contributes to #408

QueryInterface returns E_NOINTERFACE for IID_IMetaDataImport2 on .NET Framework. Using IID_IMetaDataImport as a workaround, since IMetaDataImport2 is available since .NET Framework 2.0.

I need to call QueryInterface on IMetaDataImport with IID_IMetaDataImport2 to get IMetaDataImport2, which isn't possible with the current CallableCOMWrapper implementation. Shall I just use IID_IMetaDataImport based on the fact that the two interfaces are the same (since .NET Framework 2.0)?

Sure.  Or change CallableCOMWrapper to expose what it should, whichever you think is better or more efficient for you.  CallableCOMWrapper is intentionally marked public and should support what you are trying to do, but don't feel you need to fix it.


NoSuchMethodError in FileUpload Method

Issue Type
TODO:
Place an x in one of the [ ].

[x ] Bug
[ ] Enhancement / Feature request
[ ] Question
[ ] Documentation

Description
TODO:
(Describe your issue here)
I have a Problem using the SDK with the WebAPI.
When I call the fileUpload Method i receive a "NoSuchMethodError".
Inside the RequestformBuilder Class inside the MultipartBody.Builder the RequestBody.create has the wrong signature.
It calls RequestBody.create(FILEDATA, MEDIATYPE) where it shoud be RequestBody.create(MEDIATYPE, FILEDATA)

(only for a bug report)
TODO:
If this is a bug report, filling out the following details about bugs will help us solve your issue sooner.
The issue is reproducible in:

Module Version: TODO: 1.0.7
JDK Version: TODO: openjdk version "11.0.6" 2020-01-14
OS Version etc: TODO: if the issue happens only with specific OS

The expected result is:
TODO: File Upload
The actual result is:
TODO: NoSuchMethodError
Requirements (place an x in each of the [ ])
TODO:

[x ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x ] I've read and agree to the Code of Conduct.
[x ] I've searched for any related issues and avoided creating a duplicate issue.

This library is compatible with okhttp 4.x. If your app has to use okhttp 3.x for some reason, you cannot use this library in the project.

@martinhug As I as a maintainer of this project don't have any further actions to take, please allow me to close this issue. Please consider upgrading okhttp from 3.14.7 to the latest (4.x).


CAN NOT VALIDATE NON ZERO KEY SIGNED MESSAGES

The latest version of the SDM backend is unable to validate tags created with non zero keys and NFC Developer App. I was able to get validation working by rolling back code to Sep 2022 commit. So it is suggesting that the issue was introduced in commits after Sep 2022.

Hello,
thanks for your issue and sorry for late reply. We are working on synchronizing the demo app with the recent sdm-backend open source version. For now, the workaround is as you've previously suggested - reverting back to the code from Sep 2022 commit.


sys: bumped to 0.6.0

Goal
Bump to 0.6.0.
Approach

Bump version.
Fix gem build warnings.

Coverage remained the same at 100.0% when pulling 01a01ff6e3025430f1c78270c996a38da5231d40 on bump-0.6.0 into 18a5ca7dcfbdab65b2f17ba5da6a2599c0f49ecd on master.


Faster equality comparison on ascending.js

Faster, and logic, equality comparison on ascending.js.

As with #59, this fails for Date objects and other objects that implement valueOf for comparison. In the future, please run the tests before submitting a pull request. Thank you!


Convert Saleor to TS

Fixes #862
TODO:

[ ] extract-text-webpack-plugin is still in RC

Codecov Report

:exclamation: No coverage uploaded for pull request head (typescript@c469817).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613a90b...c469817. Read the comment docs.

Let's discuss!

I'm not sure amount of code should be an argument here. The biggest gains of having TS would be of course around refactoring and simplified code review process thanks to types inference. I would be against having the strict types policy for now tho at the same time.

To counter that argument TypeScript has nothing to do with being single-page and it would help us avoid many problems. We're going to have more and more front-end code as more views are planned to convert to React (checkout is next). Having worked with properly-annotated third-party code I see great value in static checks. They are helpful when writing code but where they really shine is working with code written by someone else. Eslint will not be able to help us here and I find TypeScript much cleaner than Flow. Flow shares the same entry level problem.

As for the difficulty I also thing that being able to point people to single document for TypeScript is immensely better than having to list all of the babel plugins we use (effectively making the language we use a Mirumee-favored JavaScript).

I agree with pros mentioned by @patrys. However I'm still not 100% convinced that switching to TS is a good idea. Getting used to TypeScript and it's ecosystem takes some time, even if we'd provide all the configuration and tools along with Saleor. I'm thinking about people who don't have experience with TS but want to change something in frontend code. They may encounter difficulties with some aspects of TS that are not present in JS like types, interfaces, problems with libraries without types etc. As for Babel - you don't have to necessarily understand how each plugin works to get it running and be able to do some changes.

One of the problems I'm trying to solve is having better QA for front-end code. I only see two paths here: Flow and TypeScript.

That's why I would choose TS in a typical single page app. If we decided on rewriting most of our views to JS then I'd consider TS, now we have barely one view plus one component in another one.

Ok so the downside we see is potentially having to deal with types? With implicit "any" types should only become visible once you make an error calling a strictly typed function though.
Food for thought: GraphQL is way more advanced than TypeScript, do we think it will hinder adoption?


[Docs]: Update Google Sheets datasource reference for restricted access

Problem Statement
When the access is allowed to only selected sheets, the users cannot insert data into the sheets that are not accessible. The reference document does not specify the information on restricted access.
Use Cases / User query reference
Add the information for restricted access.
Audio/Video Recording
No response
Product Requirements Document
No response
Other Relevant Links
https://theappsmith.slack.com/archives/C0341RERY4R/p1715781493294259
Checklist

[X] Reviewed existing documentation to ensure this request is not duplicated.
[X] Attached relevant media or supporting materials like links to the PRD, feature recordings, Slack or Discord links, and any other relevant resources.

done - https://docs.appsmith.com/connect-data/reference/querying-google-sheets#insert-one


Added Eye Calculator

Fixes Issue🛠
Closes #1423
Description👨💻

An Eye Power Calculator is a valuable tool for anyone needing to determine the strength of their prescription lenses. By inputting the diopter values from their lens prescription, users can quickly and accurately calculate the eye power required for their corrective lenses. This tool is especially useful for verifying prescription accuracy before purchasing glasses or contact lenses, ensuring that the lenses will provide the correct vision correction. Additionally, it helps individuals understand the extent of their vision correction needs, promoting better eye health awareness. The Eye Power Calculator offers a user-friendly and efficient solution, making it accessible for anyone to use at any time, whether at home or on the go. Its simplicity and accuracy make it an essential resource for both optometrists and individuals who wear corrective lenses, providing a convenient and reliable method to determine the necessary lens power for optimal vision.
Type of Change📄

[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project

Screenshots/GIF📷

You are just adding the power and showing. Instead, add two dropdowns and put some required power values from which user can choose and then based on that, you can show which lens power would be required for both the eyes @SHANMUGAPRIYA-1

Are you working or Should I close this PR @SHANMUGAPRIYA-1

Yes, I am working.
On Sat, Jul 6, 2024, 4:11 AM Rakesh Roshan @.***> wrote:

Are you working or Should I close this PR @SHANMUGAPRIYA-1
https://github.com/SHANMUGAPRIYA-1
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/CalcDiverse/pull/1513#issuecomment-2211478799,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5MWOJ7A7PF6YSBUR5Z2MXLZK4OJFAVCNFSM6AAAAABKEC55S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGQ3TQNZZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sir i had made changes to this project
On Sat, Jul 6, 2024 at 8:26 AM SHANMUGAPRIYA M CCE <
@.***> wrote:

Yes, I am working.
On Sat, Jul 6, 2024, 4:11 AM Rakesh Roshan @.***>
wrote:

Are you working or Should I close this PR @SHANMUGAPRIYA-1
https://github.com/SHANMUGAPRIYA-1
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/CalcDiverse/pull/1513#issuecomment-2211478799,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5MWOJ7A7PF6YSBUR5Z2MXLZK4OJFAVCNFSM6AAAAABKEC55S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGQ3TQNZZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Jammy support

One of the main reasons for moving the DBUS_SESSION_BUS_ADDRESS variable, and suggesting an "if" clause, is that the Jinja gets rendered prior to any requirements of the states, and gets evaluated in the current environment before state execution. At runtime, Jammy does not come with dbus-x11, and by extension, dbus-launch. This renders the set dbus_address jinja to dbus-launch: command not found, even though it is to be installed.
To fix this, a few changes were made which still set the value on both versions, but it is only used on Focal. If the states are run on Jammy, then a temporary script is created to execute the commands which require an appropriate DBUS environment variable. The states create an autostart shortcut, executes it on reboot, then moves the autostart shortcut out of the autostart folder. This will enable the user to make modifications as they wish, without the original customization being forced every time.

I'm going to have to take a deeper look into the dbus stuff, probably can merge this soonish into the existing branch.
Not super thrilled with having to work around dbus, perhaps there's a better approach with Jammy. I'll do some research.

Typically, I would use the following:
- onlyif:
  - fun: cmd.run
    cmd: export DBUS_SESSION_BUS_ADDRESS=$(dbus-launch | grep DBUS_SESSION_BUS_ADDRESS | cut -d= -f2-)
    shell: /bin/bash
    python_shell: True
    runas: {{ user }}

Then add the requirement for dbus-x11 to the state, but for some reason this is always returning as False because Python cannot seem to find the command export in this context.
The error can be observed by changing python_shell to False.
I'm still looking into that error, but these states are the best workaround I can find for now. I'll let you know when I figure out the cause.

I've come up with a more graceful solution, but my VMs have crashed and it's late. I need to run a full test to make sure it works, but I can pinpoint the proper DBUS address without additional commands.
I'll share the rest in the morning.

Nice @digitalsleuth I'll review this tonight and get it merged in, I'll be fixing the bulk extractor package soon.


Volume created in Node with memory pressure

What steps did you take and what happened:
I have a cluster with 1 master and 2 worker nodes. One of the workers is reporting MemoryPressure condition.
When I deploy a new Pod with an ephemeral volume backed by OpenEBS LVM-localpv, the volume is sometimes created in the Node under memory pressure. Once the volume (PV) is created in one of these Nodes, the scheduler fails to schedule the Pod since the node where the volume is is not eligible due the the memory problem. The situation remains indefinitely.
Pod volume definition:
volumes:
  - ephemeral:
      volumeClaimTemplate:
        metadata:
          creationTimestamp: null
        spec:
          accessModes:
          - ReadWriteOnce
          resources:
            requests:
              storage: 10G
          storageClassName: openebs-locallvm
          volumeMode: Filesystem
    name: k1234

Event describing the Pod scheduling problem:
0/3 nodes are available: 1 Insufficient memory, 1 node(s) had taint {[node-role.kubernetes.io/master](http://node-role.kubernetes.io/master): }, that the pod didn't tolerate, 1 node(s) had volume node affinity conflict.

What did you expect to happen:
I expected the volume to always be created in a "healthy" Node, not one reporting a condition, where the Pod can't be scheduled afterwards.
Environment:

LVM Driver version: 0.8.3
Kubernetes version: 1.21.10
Cloud provider or hardware configuration: baremetal
OS: Ubuntu 20.04

This behavior was due to using volumeBindingMode: Immediate instead of volumeBindingMode: WaitForFirstConsumer by mistake. Once I changed it in the StorageClass, the problem disappeared.
/close


NCC in CCM is not correctly computed

While investigating #447, I noticed a potential error in the xsl file, but I'm not 100% sure it is an error or not because I'm not very good with xsl.
Actually this error has no impact to solve #447 because the number it find is the correct one even though the calculation is wrong. There was another error somewhere else.
Basically, NCC is meant to be the number of connected components (of the graph where methods are the nodes and are connected according to some criteria). See for example https://www.geeksforgeeks.org/connected-components-in-an-undirected-graph/ to understand how to count them. It is not the number of nodes.
NCC is the xsl is defined like this, and it seems to count the number of nodes:
<xsl:variable name="ncc" select="count(distinct-values($edges/edge/method/text()))"/>

Furthermore it counts them incorrectly because the name of the method is used and some methods have the same name in some of the test classes... I will create another issue for that problem because it pertains to other metrics I think. actually it doesn't seem to be the case.

@paulodamaso/z please, pay attention to this issue

@victornoel Could you please fix the title? It is just related to NCC right?

@paulodamaso yes sorry, it was in not is :)

@victornoel Thank you!

@0crat in

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

The job #449 assigned to @hdouss/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@victornoel it is actually calculating the number of nodes having an edge. And yes, it is completely erroneous.

@0crat refuse will have to wait too much for #437 and its puzzles..

@0crat refuse will have to wait too much for #437 and its puzzles.. (here)

@HDouss The user @hdouss/z resigned from #449, please stop working. Reason for job resignation: Order was cancelled

@0crat refuse will have to wait too much for #437 and its puzzles.. (here)

@HDouss Job refused in 0 hours - no penalty, see §6

The job #449 assigned to @dfrau32/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@dfrau32/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

The user @dfrau32/z resigned from #449, please stop working. Reason for job resignation: It is older than 10 days, see §8

The job #449 assigned to @vzurauskas/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@paulodamaso If I understand correctly, the Graph interface was created in order to do calculations like the one required here because graphs are better handled in Java than XSL, correct? If so, would it make sense to rewrite CCM metric in Java instead of fixing this calculation in the XSL?

@0crat wait for clarification.

@vzurauskas Yes, it makes sense, let's use java to make these calculations that need graphs

@victornoel https://github.com/yegor256/jpeek/pull/477 was merged and todos created, can this be closed now?

@vzurauskas thx!

@vzurauskas/z resigned from #449, since the job is not in scope anymore

@paulodamaso Zerocrat resigned me, but should have asked for quality review and paid me after that.

@0crat status

@0crat status (here)

@paulodamaso This is what I know about this job in C7JGJ00DP, as in §32:

The job #449 is not in scope
Job footprint (restricted area)

@0crat in

@0crat status

@0crat status (here)

@vzurauskas This is what I know about this job in C7JGJ00DP, as in §32:

The job #449 is not in scope
Job footprint (restricted area)

@paulodamaso The ticket is still stuck.

@paulodamaso ping

@victornoel 2 puzzles #481, #482 are still not solved.

@paulodamaso ping

@0crat quality good

@0crat quality good (here)

@paulodamaso There is no quality review for #449, no performer

@victornoel 2 puzzles #511, #512 are still not solved.


Task/support for cron jobs

In this PR:

Added new tables for cron jobs and their variables and environment variables.
Added a new database struct and function for the CRUD operations.
Added a new struct to execute CRUD operations and schedule jobs using the tokio-cron-scheduler crate.
Added new endpoints for the CRUD operations.
Added a new cron subcommand with the coresponding CRUD subcomands.
Refactored existing code to resolve some bugs.

Found a bug when deleting a pipeline, where the cron jobs database entries are deleted but the scheduled jobs aren't so there are logged errors about the pipeline not being found. The scheduled jobs should be cleared as well.

Found a bug when deleting a pipeline, where the cron jobs database entries are deleted but the scheduled jobs aren't so there are logged errors about the pipeline not being found. The scheduled jobs should be cleared as well.

This was a false positive.


Simplify some of the code in handleRootPolicy

Read each commit for more details.

@gparvin could you please review this? The one thing I'm unsure about is the last commit. Perhaps it's an undocumented edge-case?

I can't think of an undocumented edge case here.  If we find it we'll be sure to update the changes and include some better comments.
/lgtm


Fix lshkit for newer logging format

Hi @benfred thank you. For some weird reason travis failed.

Anyways, it was fine when merged into the master, thank you!


BR/MX admin need to to be able to edit content not created by them

We'll need to add these permissions to BR/MX admin roles:

[ ] Campaign: Edit any content
[ ] Static content: Edit any content

keep in mind though, that Brazil admins should only have access to Brazilian Portuguese fields and Mexico admins should only have access to Mexican Spanish fields from @blisteringherb's comment on #4934:
"I'm thinking that putting in a hook_menu_alter for node/%/edit that triggers the add translation chain if the allowed translation hasn't yet been created for that node and if it already exists it will send the user to node/%/edit/es-mx so they never actually get to the edit screen for the non-allowed translations.
For instance if a user with the Brazil admin role tries to visit node/36/edit, they'll be redirected to node/36/edit/pt-br if the translation already exists, and if not they'll go to node/57/edit/add/en/pt-br.  The other languages in the upper right corner of the node edit screen will be hidden except for those that they're allowed to see, and they won't have access to the translate tab."
note: whether or not they need access to Home: Edit any content is dependent on the decision made in #4968

Just to clarify/update after talking w/ Fantini
The problem this issue needs to solve is how the URL redirects when you click 'Edit' as a regional admin. Fields are already hidden on the node edit page due to this PR: https://github.com/DoSomething/phoenix/pull/5004

Mapping the URL's will be based on the variables soon to be created in this PR:
https://github.com/DoSomething/phoenix/pull/5050#discussion-diff-39051771


Rename package

Although there is no any consideration about support on porting map from 1.6.2/1.6.4 to 1.7.10 with FrogCraft included, it is still a question whether the package name should use FrogCraft or not.
Before final decision I will ask the original author(s).
Will change from frogcraftrewrite to frogcraftrebirth in order to keep everything the same.

Closed via c30b4d0f1f841b13c036457d62e6dff6833499f7


Fabric 1.21

the mod looks interesting though rn it only seems to have 1.21 for forge would love to see a fabric version on that version

Not planned. I believe neoforge will solve the loader split and I want to help it to.


Crash when trying to play during load

There's a long (1-5 seconds) of lag for my whole computer when I load a song. If I try to play the song during this time (using the key I bound to play) the program has about a 50% chance of not playing the song and a 50% chance of crashing.

The long load times should be fixed as of 3.2.9


Mirror Summary

[x] Mirror issues along with the repo #1876
[ ] Mirror new-created wiki when repositories migrated #2309
[x] Reverse mirroring, from Gitea to remote Github/Gitlab/Gitea and etc. #3480
[ ] Mirror repositories could not be readonly and Allow to push commits manually #7609
[ ] Mirror an entire github organization into gitea organization #8424
[ ] Mirror Topics #14590
[ ] Mirror Docs

I searched for "Mirror" on https://docs.gitea.io, and I didn't see much describing how mirrors run;
e.g. what happens automatically (git pull, git prune from the origin codebase?)
and what must be updated by a manual process (issues, wiki pages).
Someone visiting gitea.com as an end user will probably need a summary page
of the purpose and mechanisms of mirror repositories.
Maybe a paragraph on the "import repository" page could help people learn more.

Is https://github.com/go-gitea/gitea/issues/3480 a duplicate issue to https://github.com/go-gitea/gitea/issues/7609?

@kdumontnu I think it's not the same. #3480 means a reverse mirror, #7609 means a mirror repository could be not readonly.

I searched for "Mirror" on https://docs.gitea.io, and I didn't see much describing how mirrors run;
e.g. what happens automatically (git pull, git prune from the origin codebase?)
and what must be updated by a manual process (issues, wiki pages).
Someone visiting gitea.com as an end user will probably need a summary page
of the purpose and mechanisms of mirror repositories.
Maybe a paragraph on the "import repository" page could help people learn more.

Yes, mirror docs is also needed.

@lunny thx, but the syntax is very confusing then. You say "Reverse mirroring #7609" above, but "#3480 means reverse mirror".
Do you mean then: "Enable pushing to Gitea repo configured as secondary mirror #7609"?
And "Enable Gitea as primary in mirror configuration #3480"?
We can use consistent diction for mirrors as "primary (push)" and "secondary (pull)"

Also, I added a bounty to #3480 if you can add the following:
[![Bountysource](https://api.bountysource.com/badge/issue?issue_id=54827645)](https://www.bountysource.com/issues/54827645-ability-to-automatically-push-to-remote-mirror-repository)

Enable Gitea as primary in mirror configuration #3480

@lunny thx, but the syntax is very confusing then. You say "Reverse mirroring #7609" above, but "#3480 means reverse mirror".
Do you mean then: "Enable pushing to Gitea repo configured as secondary mirror #7609"?
And "Enable Gitea as primary in mirror configuration #3480"?
We can use consistent diction for mirrors as "primary (push)" and "secondary (pull)"
Also, I added a bounty to #3480 if you can add the following:
[![Bountysource](https://api.bountysource.com/badge/issue?issue_id=54827645)](https://www.bountysource.com/issues/54827645-ability-to-automatically-push-to-remote-mirror-repository)

Enable Gitea as primary in mirror configuration #3480

Thanks, I have updated the issue content. I haven't followed your advise because I think primary and secondary is still confusing. Please let me know if you think it's still confusing. :)

Option to "protect" mirrors (dont sync if it will drop commits or is a completly new history)

suggest add gitee.com support, from  #15945

@a1012112796 wrong summary issue :)
Do you mean  #8689?

I would suggest in addition to the issue #3480 to add the ability to only push certain branch, tags, etc.

see also #18220

ability to only push certain branch, tags, etc

I order to prevent deleted or force-pushed commits from appearing in the GitHub Activity(and again), it would be nice to have some threshold on commit age when scheduled push mirror is enabled. Like once per a day push the only commits (tags, etc.), which older than 8 hours, for example.


Fair share during admission

What type of PR is this?

What this PR does / why we need it:
Implements the concept of a "fair share" for a ClusterQueue or a ClusterQueue with an additional workload as defined in #1773:
For a given resource r provided by a ClusterQueue or cohort c, we calculate T_r as the total
requests consumed by the Workloads for that resource in that CQ or cohort, independent of the
flavor, that are above the nominal quota. The value for a resource is the ratio of T_r and the
total nominal quotas, or lendingLimits if defined, in the hierarchy of the parent of C.

The value for the CQ or cohort is the maximum among the values for each resource,
divided by the weight, if defined.

The fair share value is used for sorting the heads of the ClusterQueues during admission.
Which issue(s) this PR fixes:

Part of #1714
Special notes for your reviewer:
There is no API for this feature in this PR. That's because we don't want to release this behavior standalone, but accompany it with preemption support, which will come in a subsequent PR.
For reviewers convenience, I roughly divided the PR in 3 commits:

Keeping stats for a ClusterQueue and cohort about total usage per resource and shareable resources.
Calculate the share value for a ClusterQueue with or without a new workload
Admission sorting + tests.

Does this PR introduce a user-facing change?

NONE

/hold
for #1773

@alculquicondor Is this ready for the review?

Yes :)

Ack

I'm reviewing now.

Thank you!
/lgtm

It looks like a flaky test. Opened #1943

/retest


  I'm blocked by 381 still on recompilation so I'm not 100% sure, but SQRTSD si definitely the major missing semantic.

Ok! If you uncover other individual missing instruction semantics that block you, then you are welcome to file them as issues in the Remill project. We know there are many yet to implement, but are typically addressing them as the needs arise.

Fixed in https://github.com/trailofbits/remill/commit/8c8986a07e51970d668aad3f50c4b774e2ca6ac1

Will do, thanks!  Going to give this another go with the update shortly.


operator: only GC identity keys of its own cluster

Ref: #16805
Signed-off-by: ArthurChiao<EMAIL_ADDRESS>

test-me-please

I note that all of the Jenkins-based CI runs were successful (except test-gke), while the GHA-based CI runs were not successful. @ArthurChiao would you mind rebasing once more so we can evaluate whether the GHA-based actions were just flaky at the time or whether they were potentially revealing a real issue with the PR?

Rebasing should fix the current AKS error. Not sure for the rest. We do still have lots of flakes in GitHub workflows.

test-me-please

Thanks, I'll look at this tomorrow @jrajahalme


Support configured APIs for embedding and LLM models

Users of the library may want to embed with an existing API (perhaps an internal one). We could allow configuration of "models" that are setup by the user via the UI (Settings page?) and stored in some way (env variables?).
We need to define the necessary variables:

name
description
URL
API key

We would probably need a "CustomAPI" provider that accepts the user variables and enables submitting requests and returning the responses. How do we add flexibility for parsing responses?
We would also want the list of models that shows up in dropdowns to show the custom model, likely handled with new code in the models/ lib

If we integrate LiteLLM as discussed in #14 we could look at using:
https://litellm.vercel.app/docs/providers/custom_openai_proxy

@enjalot I'm the litellm maintainer - let me know if we can help/if you have any feature requests/issues

It would be good to make it easy to utilize llamafile which offers an OpenAI-compatible chat API
https://github.com/Mozilla-Ocho/llamafile/blob/main/README.md#json-api-quickstart

done!


Training completed on custom data, detects only the upper part of lanes

Detection result / GT

In configs/clrnet/clr_resnet18_culane.py, I have changed the image size values like this to match with my custom dataset.
ori_img_w = 1920
ori_img_h = 1080
img_w = 800
img_h = 320
Also in clrnet/datasets/culane.py, line 97, I have changed the ys value to match the height of my dataset.
ys = np.arange(270, 1080, 10) / self.cfg.ori_img_h
So I'm assuming two possibilites.

While reading annotations, it has only read the upper portion of it.
The test & inference outputs the upper portion of the lanes.

It would be nice to know if there are additional variables to be modified.
Thank you.

Solved the issue by resizing the images and labels corresponding to culane dataset.

I met the same problem. If use configs/clrnet/clr_dla34_culane.py, change sample_y, ori_img_w, ori_img_h, 根据自己的数据集


How to solve this CUDA problem?

Hi @LiyaoTang;
How to solve this problem?
tensorflow/python/client/session.py", line 1374, in _extend_graph
tf_session.ExtendSession(self._session)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation gpu_0/model/resnet_backbone/res1_input_conv/L2Loss: {{node gpu_0/model/resnet_backbone/res1_input_conv/L2Loss}}was explicitly assigned to /device:GPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0, /job:localhost/replica:0/task:0/device:XLA_GPU:0, /job:localhost/replica:0/task:0/device:XLA_GPU:1 ]. Make sure the device specification refers to a valid device.
[[gpu_0/model/resnet_backbone/res1_input_conv/L2Loss]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 105, in
trainer.train()
File "/export/home/hanxiaobing/Documents/PlaneNet_PlaneRCNN/DGCNN_PointNet2/SensatUrban/contrastBoundary/tensorflow_sensaturban/utils/trainer.py", line 91, in train
sess.run(tf.global_variables_initializer())
File "/export/home/hanxiaobing/anaconda3/envs/cbl/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 950, in run
run_metadata_ptr)
File "/export/home/hanxiaobing/anaconda3/envs/cbl/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1173, in _run
feed_dict_tensor, options, run_metadata)
File "/export/home/hanxiaobing/anaconda3/envs/cbl/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1350, in _do_run
run_metadata)
File "/export/home/hanxiaobing/anaconda3/envs/cbl/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1370, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation gpu_0/model/resnet_backbone/res1_input_conv/L2Loss: node gpu_0/model/resnet_backbone/res1_input_conv/L2Loss (defined at /export/home/hanxiaobing/Documents/PlaneNet_PlaneRCNN/DGCNN_PointNet2/SensatUrban/contrastBoundary/tensorflow_sensaturban/models/basic_operators.py:128) was explicitly assigned to /device:GPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0, /job:localhost/replica:0/task:0/device:XLA_GPU:0, /job:localhost/replica:0/task:0/device:XLA_GPU:1 ]. Make sure the device specification refers to a valid device.
[[gpu_0/model/resnet_backbone/res1_input_conv/L2Loss]]
Errors may have originated from an input operation.
Input Source operations connected to node gpu_0/model/resnet_backbone/res1_input_conv/L2Loss:
model/resnet_backbone/res1_input_conv/weights/read (defined at /export/home/hanxiaobing/Documents/PlaneNet_PlaneRCNN/DGCNN_PointNet2/SensatUrban/contrastBoundary/tensorflow_sensaturban/models/basic_operators.py:96)

gpu_0/model/resnet_backbone/res1_input_conv/L2Loss: {{node gpu_0/model/resnet_backbone/res1_input_conv/L2Loss}}was explicitly assigned to /device:GPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0,
This line means that the code assumes there is one GPU, but there is only CPU available. Please check your nvidia-smi output to ensure the GPU is available.

@LiyaoTang
OK. Thanks.
How and where to revise the GPU device ID?  The default GPU device IDs are 0 and 1.


enable usage of javascript console methods

@gliechtenstein This lets you do simple JavaScript debugging using console, the output will appear in the Android console. This works for debugging both the code in parser as well as any JS used in template tags.

Finally merged! Thanks! Just managed to get the iOS version to work as well here https://github.com/Jasonette/JASONETTE-iOS/commit/89eccb11615c0488f160930bdbfef56ac711a6dc


fix: consolidate naming on Llama Deploy

Consolidate the naming of the project to LlamaDeploy.

coverage: 73.723%. remained the same
when pulling 04b48e1648d756a589f04d3248763e95d0da094b on massi/naming
into 35e1fa239575b97e75943f5acbf18d181385615c on main.


Status of issues

Do any of these open issues need work? Has work on them been begun on the next branch? I'm currently familiarising myself with the codebase, and could tackle one or two if that would help.

@jan-hudec This is the issue I was talking about. We could use it for discussion, for lack of anything better. :)

I'll update them over next couple of days and also try to create some milestones to give them some priorities.

Basically the #7 is a somewhat obsolete dump of ideas and #10 and #17 should be done on next. I'll sort the rest out and try to update them with up-to-date design ideas.
Unfortunately Github can't associate a commit with issue in a way that would allow tracking not just whether it's implemented anywhere, but also whether it already made it to a release, so I am reluctant to close the ones on next already.

Okay, sounds fair.
Maybe worth creating PRs for some of these issues (and leaving them open for a long time), so you can get the tracking?

@alexreg, how much knowledge do you have of macros or of syntex?
While I spent quite a bit of time already investigating what CLDR has to offer and reading documentation of chrono (for #18), I have not used macros yet and I have not used syntex—both of which will be needed for translation support (#19).

Decent knowledge. I wrote a procedural macro (pre–macros 1.1) for error templating, so I know my way around at least.
I'm also somewhat familiar with chrono, though by no means an expert. CLDR I know very little indeed about. There seems to already be a crate for it though.
Should I have a go at #18 or #19 soon, then?

@jan-hudec I should have a bit of time over the coming days. Will tackle #18 maybe, unless you'd like otherwise...

@alexreg The cldr crate was actually intended for #10, but all it does is contain JSON version of the raw CLDR data, with no API, and in a way that is totally impractical, because cargo does not have any support for distributing resource files. So I created the generator in next:scripts/extract_cldr instead.
Regarding #18, I've already been thinking about it, but am not yet sure about the exact interface, so it would certainly help to discuss it. I'll write my current design for it in #18 in a couple of minutes.
Regarding #19 I am even less sure about the design, so some more planning would help there too. I'll write more thoughts there as well.

@alexreg, OK, I've added design notes and some open questions in #18 and #19.

@alexreg, are you taking a stab at #18 as you said? I'll start with #20 then, where the convenience wrapper methods will be provided.

Yep, having a go! Cheers.

@alexreg, any progress?

@jan-hudec Nothing worth reporting yet. My apologies, I've been flooded with work.

@alexreg, meanwhile I wrote first version of translate-storage, which will be used for implementing the macros for #19 and then I implemented month and day names in the data. I decided instead of rewriting the data set to allow multiple levels, I will simply allow parametric enum variants. 3 bytes worth of parameters should be enough — calendar, width and number for the calendar items and 3 letters of code for the currencies. And the skeleton patterns will be in one string with some separator, because we have to scan them every time anyway.