Contribute a vmware controller

We want to contribute a controller for provisioning VMs over VSphere API.
Please advise how to proceed.
Open questions so far:

Level of quality
Branch or fork
How to handle third party libraries added to oscm

That's great! You are welcome to contribute.
Please sign and submit the CLAs as described here: https://github.com/servicecatalog/development#contributions and proceed the steps.
Regarding open questions:

Level of quality
Following is required:

All source code is formatted (required templates will be shared)
All source compiles in OSCM main build (target All.BUILD)
Separate test projects according OSCM project layout

Branch or fork
Feel free to fork the OSCM repository. All contributions, fixes or new features are targeted to separate branches in OSCM. We'll provide you the respective branch in OSCM. Once you're done with coding and testing, above requirements are met and you are keen for merging your source, the only thing you need to do is to create a pull request from comparing your fork with this OSCM branch. Please see https://help.github.com/articles/using-pull-requests/ for sending pull request.

How to handle third party libraries added to oscm?
OSCM is published with Apache 2.0 license and any of it's content including the third party must be complaint. Before introducing new third party, please first checkout what's already used in OSCM. If you're still going for adding third party, please state it. Try searching the needed  on central Maven and check for Apache license.

Great idea @uspecht!
A VMWare controller will be a perfect extension for OSCM, which already supports provisioning Amazon EC2 virtual machines and OpenStack instances.
I am curious about the use cases you want to support with the VMWare controller. Could you describe them?

Create VM from existing template
When a subscription is created a virtual machine is cloned from a template.
The installed operating system of the template can be any Windows or Linux.
The template can have up to four network adapters associated to it.
The service parameters of this subscription determine the available resources of that virtual machine.
The following virtual machine resources can be configured:
- Amount of memory
- Size of system disk space
- Number and size of additional disks
- Number of CPUs
- The network adapters
- The network configuration (DHCP or manual) for each NIC
The following operating system features can be configured:
- Windows Domain Join or Workgroup creation
- Local Windows administrator password
- Linux root user password
- Custom script execution, once after the VM has been created

The subscription creation can be paused after the VM is cloned and configured.
That pause can be used by administrators to finalize the VM creation (installing Virusscanner, register Windows, ...).
The provisioning is continued by the administrator after he has done his work on the VM.

Modify VM
Memory, disk space and the number of CPUs can be modified by changing the subscription configuration

Delete VM
The VM is deleted when the subscription is terminated

4 Service Operations
We would support standard operations on VMs:

Start
Stop
Restart

Hello @uspecht,
we found that the intended functionality you have described for the VMWare controller is a good extension for the IaaS scenarios OSCM can support.
Since the OSCM is an open source project with enterprise quality,  we want to do additional work for the VMWare controller, like internationalization(OSCM supports different locales, English, German, Japanese and is extensible), more integration tests to ensure quality, etc.
Therefore a new Issue is raised by @mdehn.
Can you say in which business domain you plan to use OSCM with VMware controller?
Do you already know the OSCM Forum? You are welcome to register and share your questions and ideas.


3D EnVar Benchmark for Azure

Description
Provide a benchmark application for multi-node Azure performance testing.  We originally considered a NRT fv3-gfs c768 Hofx application but I don't think the Azure team will be satisfied with this.  They want something that requires multiple nodes to run but I ran that application on a single AWS node with 24 cores/tasks and it only takes a few minutes.  So, only a few core hours.  We want something that requires a few hundred core hours so we can produce a meaningful multi-node performance benchmark.
Though this is motivated by Azure benchmarking, we can define it and package it in a systematic way using release 1.0.0 of the code and container so it can be easily reproduced on other systems for profiling purposes.
Requirements

a well-defined 3D EnVar FV3-GFS or FV3-GEOS benchmark, including config files and input files that work with release 1.0.0 of fv3-bundle

Acceptance Criteria (Definition of Done)

The benchmark runs on multiple nodes on Azure
The benchmark input files are conveniently packaged and organized for easy deployment on other systems

Dependencies
See attached

Strange - this seems to have been created twice - closing this one


Release/1.2.0

add support for global contexts
update travis
set emitter status when event store not instantiated

Coverage decreased (-2.3%) to 76.878% when pulling dc89ff2c82bb40d27963804335840fb924022372 on release/1.2.0 into 5c52820c3aef3d687d921e606a83de1597a7063a on master.


bug: Accordion donot close on clicking on arrow

Hey, I recently learned about Daisy UI and tried to implement a simple accordion, and it went smooth but there is a small problem all the accordion examples on the website proerply works for me but the accordion donot close when clicking back on the arrow? It only closes if I click on the other accordion item

This is how an accordion should work. As you see, it says Click to open this one and close others
You can of course change the value of the radio input using JS if you want a different behavior, but since it is working with radio inputs, this is the expected behavior. when we choose a radio input, it gets enabled until we choose another one. clicking it again wont turn it off.
You might also want to use collapse instead (which is independent with each item)


added support for enhance column feature

Please help review the code and not merge for current now. There still need more test on function and performance.

This feature much like HybridColumns, we can refer to setHybridColumns in BasicUpdater.java for the implementation.


test: check that newly created operations are visible

card: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=&pane=issue&itemId=61490241

@BCerki
I believe your test e2e/workflows/bceidbusiness/industry_user_admin.spec.ts: line 187 is failing due to incorrect ButtonText...awaiting "View Details" but, shows should be "Start Registration"
 const brianna = await row.getByRole("link", {
      name: ButtonText.VIEW_DETAILS,
    });

@BCerki
As mentioned in PR #1634, the test.yaml file needs some changes so to get your failed reports successfully uploaded.
  e2e-tests:
    name: 🧪 e2e tests ${{ matrix.project }}
    needs:
      - backend-docker-build
      - nx-docker-build-registration
      - install-dev-tools
    runs-on: ubuntu-latest
    timeout-minutes: 60
    strategy:
      fail-fast: false
      matrix:
        include:
          - project: chromium
            os: ubuntu-latest
            cache_dir: ~/.cache/ms-playwright
          - project: firefox
            os: ubuntu-latest
            cache_dir: ~/.cache/ms-playwright
          - project: webkit
            os: macos-12
            cache_dir: ~/Library/Caches/ms-playwright
    steps:
      - uses: actions/checkout@v4

      - name: 🎁 setup dev env
        uses: ./.github/actions/dev-env-setup

      - name: 🎁 setup local app
        uses: ./.github/actions/local-app-run
        with:
          django_secret_key: ${{ env.DJANGO_SECRET_KEY }}
          keycloak_client_id: ${{ env.KEYCLOAK_CLIENT_ID }}
          keycloak_client_secret: ${{ env.KEYCLOAK_CLIENT_SECRET }}
          nextauth_secret: ${{ env.NEXTAUTH_SECRET }}
      - name: ⚡ cache Playwright binaries
        uses: actions/cache@v4
        id: playwright-cache
        with:
          path: ${{ matrix.cache_dir }}
          key: ${{ runner.os }}-${{ matrix.project }}-playwright-registration

      - name: 📥 install Playwright ${{ matrix.project }}
        if: steps.playwright-cache.outputs.cache-hit != 'true'
        run: npx playwright install --with-deps ${{ matrix.project }}
        working-directory: ./bciers/apps/registration

      - name: 🎭 Run Playwright Tests
        run: |
          npx happo-e2e -- npx playwright test --project=${{ matrix.project }} bciers/apps/registration/e2e/*
        env:
          API_URL: http://<IP_ADDRESS>:8000/api/
          DB_USER: postgres
          DB_NAME: registration
          DB_PORT: 5432
          DB_HOST: localhost
          E2E_BASEURL: http://localhost:3000/
          E2E_CAS_USER: ${{ secrets.E2E_CAS_USER }}
          E2E_CAS_USER_GUID: ${{ secrets.E2E_CAS_USER_GUID }}
          E2E_CAS_USER_PASSWORD: ${{ secrets.E2E_CAS_USER_PASSWORD}}
          E2E_CAS_ADMIN_STORAGE: ${{ secrets.E2E_CAS_ADMIN_STORAGE}}
          E2E_CAS_ANALYST_STORAGE: ${{ secrets.E2E_CAS_ANALYST_STORAGE}}
          E2E_CAS_PENDING_STORAGE: ${{ secrets.E2E_CAS_PENDING_STORAGE}}
          E2E_INDUSTRY_USER_ADMIN: bc-cas-dev
          E2E_INDUSTRY_USER_ADMIN_GUID: ${{ secrets.E2E_INDUSTRY_USER_ADMIN_GUID }}
          E2E_INDUSTRY_USER_ADMIN_PASSWORD: ${{ secrets.E2E_INDUSTRY_USER_ADMIN_PASSWORD }}
          E2E_INDUSTRY_USER_ADMIN_STORAGE: ${{ secrets.E2E_INDUSTRY_USER_ADMIN_STORAGE}}
          E2E_INDUSTRY_USER: bc-cas-dev-secondary
          E2E_INDUSTRY_USER_GUID: ${{ secrets.E2E_INDUSTRY_USER_GUID }}
          E2E_INDUSTRY_USER_PASSWORD: ${{ secrets.E2E_INDUSTRY_USER_PASSWORD }}
          E2E_INDUSTRY_USER_STORAGE: ${{ secrets.E2E_INDUSTRY_USER_STORAGE}}
          E2E_NEW_USER: bc-cas-dev-three
          E2E_NEW_USER_GUID: ${{ secrets.E2E_NEW_USER_GUID }}
          E2E_NEW_USER_PASSWORD: ${{ secrets.E2E_NEW_USER_PASSWORD }}
          E2E_NEW_USER_STORAGE: ${{ secrets.E2E_NEW_USER_STORAGE}}
          HAPPO_API_KEY: ${{ secrets.HAPPO_API_KEY }}
          HAPPO_API_SECRET: ${{ secrets.HAPPO_API_SECRET }}
          HAPPO_NONCE: ${{ github.sha }}
          SMTP_CONNECTION_STRING: smtp://@localhost:1025
        working-directory: ./bciers/apps/registration
      - name: 💾 save ${{ matrix.project }} report artifact
        # prefer to upload the report only in case of test failure
        if: failure()
        uses: actions/upload-artifact@v4
        with:
          # Store all of the reports separately by reconfiguring the report name
          name: blob-report-${{ matrix.project }}
          path: bciers/blob-report
          retention-days: 1
  # Merge the e2e blob reports to one HTML report
  e2e-report:
    name: 📊 e2e report artifact
    runs-on: ubuntu-latest
    needs: [e2e-tests]
    if: ${{ always() && contains(needs.*.result, 'failure') }}
    steps:
      - name: Download blob reports from GitHub Actions Artifacts
        uses: actions/download-artifact@v4
        with:
          path: all-blob-reports
          pattern: blob-report-chromium #blob-report-*
          merge-multiple: true

      - name: Merge into HTML Report
        run: npx playwright merge-reports --reporter html ./all-blob-reports

      - name: Upload HTML report
        uses: actions/upload-artifact@v4
        with:
          name: playwright-report
          path: playwright-report
          retention-days: 14
  # Ensure the e2e tests and e2e report completed successfully
  e2e:
    if: ${{ always() }}
    runs-on: ubuntu-latest
    needs: [e2e-tests]
    steps:
      - run: exit 1
        if: >-
          ${{
               contains(needs.*.result, 'failure')
            || contains(needs.*.result, 'cancelled')
            || contains(needs.*.result, 'skipped')
          }}

@BCerki
I believe your test e2e/workflows/bceidbusiness/industry_user_admin.spec.ts: line 187 is failing due to incorrect ButtonText...awaiting "View Details" but, shows "Start Registration"
 const brianna = await row.getByRole("link", {
      name: ButtonText.VIEW_DETAILS,
    });

Thank you for this! I think I figured out what's happening. The operation isn't successfully submitting (we can see it didn't go through in this happo shot:
)
So it's "Start Registration" instead of "View Details" because the operation was never submitted, and that's why this test is failing. We have an assertion to check that submission is working but it's not failing so there must be something off about it: await operationPage.successfulSubmissionIsVisible();.


Git Error: an unknown git error occurred; code=NotFound (-3)

I'm getting an unhelpful error in this CI run that I can't pinpoint to the actual problem: https://github.com/knurling-rs/app-template/pull/46/checks?check_run_id=1971245356
Any ideas as to what might be causing this? Locally it all seems to work fine, even with detached HEAD.

Hi there, I commented on the PR of yours.
TL;DR: checkout our github workflow config, that was also causing issues.

@jonas-schievink I've added an e2e test to be able to verify this behaviour when using cargo-generate on ci runs.
However, as you can see the runs where all successful, could it be that there is an issue in the template repo that you folks are using?

cargo-generate is incompatible with overwriting git connection protocol
if you have this in your ~/.gitconfig:
[url<EMAIL_ADDRESS>    insteadOf = https://github.com/

comment it out.

will close this one, and promote #325 to the tracking issue.


chore: Add basic GitHub Workflows

Description
Add some basic GitHub Workflows that are automatically executed on pull
requests (copied from trifinger_simulation).  The following checks are
added:

git.yml: Checks if there are any "fixup!" or "squash!" commits.  To avoid that they are accidentally merged (they should be manually squashed before merging).
pr_todo_checks.yml: Checks if any "TODO" or "FIXME" comments are added.  The idea is that they should usually be resolved before merging the PR (especially FIXMEs, TODOs might be okay to add, that's why there are separate checks for them).
lint.yml: Run linters on the code.  For now, only black is used to ensure all code is formatted correctly.  I'd like to add more checks here in the future (e.g. flake8, mypy) but for this, currently existing warnings should first be resolved.

Let me know of what you think about these checks.  These checks are all rather generic, so if you like them, we could add them to all repos.
By default GitHub will only warn about failing checks.  It is possible to mark some as "required", then merging of the PR will be blocked if the check fails.
How I Tested
They should already run on this pull request, the results should be displayed below the discussion.

I just noticed that this PR is still around.  If I remember correctly, we decided that these checks are only required on the core packages, so I am closing this here.


refactor(system): abstract basic CommonStore and migrate scheduler cache

First step of https://github.com/kubewharf/godel-scheduler/issues/45

any comments on this ? @yuey002 @lzlaa

/lgtm

/lgtm


bug: Lazy window backdrop distorts colors with notermguicolors

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.9.5
Operating system/version
MacOS 13.6.6
Describe the bug
With notermguicolors, the new Lazy window backdrop distorts the colors and makes it unclear that it's a backdrop.
Steps To Reproduce
Run :Lazy with notermguicolors and a colorscheme that uses cterm colors, like "pablo".
Expected Behavior
I would expect this feature to be disabled when notermguicolors is set, because blending the colors isn't straightforward when users use cterm colors 0-15 as their primary colors.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

require("lazy").setup({}, {
  root = root .. "/plugins",
})

vim.o.termguicolors = false
vim.cmd.colorscheme("pablo")

FWIW, I resolved this issue by setting ui.backdrop to 100 in my init.lua:
require('lazy').setup('plugins', {
  ui = {
    backdrop = 100,
  },
  -- <snip> --
})

For convenience, here are images from reproducing this behavior:
Normal view:

After :Lazy:

The text in the background turned mostly green, but no less vibrant, which is why it's hard to identify as a backdrop.


[WIP] Replace moment

🎉
This PR will replace moment from peer dependency of the project #61
I have moved all moment specific usages to the utils, used for persian pickers.
But now persian pickers are broken, @alitaheri I need your input on that
Also we need to update typings and move utils to the separate npm package.
Feel free to discuss all things you have found here.

Awesome! 👍
I'll take a look at it later :)

@dmtrKovalenko Please don't replace the formatting functions. Jalaali needs other formatters to work. I mean: for Gregorian its YYYY but for Jalali its jYYYY. please revert back to using explicit functions like getYearText

@alitaheri Maybe we can match format strings in persian utils from 'jYYYY' -> 'YYYY', because it would be helpful to have common formatting method for both date-fns and moment

@cherniavskii @alitaheri
I have finished probably all logic for date-fns injection. I will return back not generic formatting (via functions) for persian pickers tommorrow, so can you please review this PR so we will release it this week.
Thank you 🎉

@alitaheri I have returned back all text formatting methods. And as far I understand have fixed all issues and finish with the feature at all. If you have any concerns let me a shout :)
So what we will do with persian pickers next?
All you need - its just import moment utils, extend them and override all displayed methods.

@cherniavskii
I want to merge this PR, test a bit new functionality and create a new release. (rc-1)
We will add support of localization at all and integrate persian pickers in the next release, so do you have any additional questions?


Add resizeObserverEntry as a parameter to  evaluate()

Hi there, nice directive!
I have quite a few use cases where I need to know the actual dimensions of a resized element. Right now, I need re-query the DOM for this.$root.clientWidth and/or this.$root.clientHeight.
A better solution would be to pass the ResizeObserverEntry reference directly to the evaluate callback. I had a look at how Alpinejs is doing this in x-on and implemented the same logic for x-resize. Now I can easily access the entry like this:

 console.log(resizeObserverEntry);">

What do you think?

This is a nice addition! Do you have some example code I could add to the documentation?

Glad that you like it!
Actually, the console.log()-code above would be the most basic example I could think of. I am using this for example to dynamically adjust the font size for some elements.
A less useful but maybe easier to grasp example would be to just change the background color of an element based on it's width:

 {
    width = resizeObserverEntry.contentRect.width
  }"
  :style="{
    'background-color': width < 500 ? 'cornflowerblue' : 'rebeccapurple'
  }">
  My background color will change depending on my width ✨

If the above example seems too useless, here is one for fluid font size:

 {
    width = resizeObserverEntry.contentRect.width
  }"
  :style="{
    'font-size': `${Math.min(maxFontSize, Math.max(minFontSize, width * 0.05))}px`
  }">
  The font-size of this element will adjust based on its width

I like those, thanks. I will use this for the documentation and a simple demo file.

Hey! Any idea when you will be able to release this? :)

I've already tagged a release a few days ago.

Ooops, missed that 😅


Add Nudg.it v 1.1

Adding a new cask

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the token reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download nudgit is error-free.
[x] brew cask style --fix nudgit left no offenses.
[x] brew cask install nudgit worked successfully.
[x] brew cask uninstall nudgit worked successfully.

Thank you for the contribution. It needed some fixes, so they were made in efee24a20868d46618639490d2899c5bc23946de. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


WebXRHand doesn't efficiently obtain hand poses

The WebXR hand tracking API explainer recommends using fillPoses and fillJointRadii as a way of reducing the number of javascript objects created per-frame while updating tracked hand models:
https://github.com/immersive-web/webxr-hand-input/blob/main/explainer.md#efficiently-obtaining-hand-poses
WebXRHand still uses the inefficient method:
https://github.com/BabylonJS/Babylon.js/blob/3a9e1322b453881b59407a511fe4705fe2cd59b9/src/XR/features/WebXRHandTracking.ts#L347
In order for BabylonNative to maintain support, we will want to get https://github.com/BabylonJS/BabylonNative/issues/773 closed first.

Hi @rgerd - will you be implementing this? Should I assign you?

Yes I'm working on it now. Thanks!


Load different styles for different section?

I am making a small plugin that let's you style sections, is it possible with kirki to load style settings for each section individually? each section has a unique id and i want users to select the section they want to style and its style settings are saved and if they switch to another section they can style that?
Thank you in advance.

No, this feature is not available out of the box in Kirki and in fact even the current styling option will be removed from v4.0 because it gets abused by theme authors in ways that make the customizer unusable, ugly and completely violating accessibility.
If a theme author wants to style the customizer they can write their own CSS and enqueue it 👍


XAmzContentSHA256Mismatch when putting objects in dotnet core app

I'm trying to test the following code in a dotnet core v1.1.1 app:
var putRequest = new PutObjectRequest();
putRequest.BucketName = "samplebucket";
putRequest.Key = "this-is-a-test.txt";
putRequest.ContentBody = "this is a test";

var putResponse = await _s3Client.PutObjectAsync(putRequest);

I've also tried various combinations of the TransferUtility class but the result is always a XAmzContentSHA256Mismatch error. I'm using the AWSSDK.S3: <IP_ADDRESS> version of .net client.
I can successfully list, create, delete buckets but I have problems in putting objects. I also tried switching the signature versions of the s3 client from version 2 to version 4 with no luck.
I should also note that I'm testing against a local Ceph S3 endpoint running Jewel. Is there a known incompatibility issue here?

Do you only encounter errors when using Ceph S3 endpoint? Does your application work against public S3?

It does work against s3.amazonaws.com, so I suppose it's not technically an issue for this repository. Any more insight would be helpful as this is probably an issue with my local Ceph docker container. Using this btw: https://github.com/ceph/ceph-docker/tree/master/ceph-releases/jewel/ubuntu/14.04/demo.

You're right, this question does seem to be more appropriate for the Ceph repo, as they would have the required expertise to advise about this error.
Resolving. Feel free to re-open if your investigation leads to an issue with the AWS SDK for .NET.


OOP school library: add basic UI

Project requirements
In this PR I made the basic UI, following the video constraints.

All the UI was created in the app.rb file and is called by the run() method.
The App class is called by the method main in the main.rb file.

Thank you so much for your feedback @AmaduKamara .


Updated node-gir structure added in linting for js, basic folder structure, build step, package json, etc...

Hey Tim,
Added some structure to assist with deving.  I can set up a basic header file as well in an include folder as well if you want.

Closing, as its been years.


Missing WWW-Authenticate on missing Authorisation with a BearerToken ResourceProtector

When protecting a resource as follow :
require_oauth = ResourceProtector()
require_oauth.register_token_validator(BearerTokenValidator(OAuth2Token, realm='https://AUTH_SERVICE_URL/token'))

@require_oauth()
def home(request):
    return HttpResponse('Authenticated')

I expect a request without an "Authorisation" header to return a 401 response with a "WWW-Authenticate" header per https://tools.ietf.org/html/rfc6750#section-3
Currently, the header is not present in the response.
Authlib version 0.15.2

So as far as I understand, the authlib.oauth2.rfc6749.resource_protector.ResourceProtector has a validate_request method that is called in authlib.integrations.django_oauth2.ResourceProtector in the acquire_token method.
The validate_request method raises a authlib.oauth2.rfc6749.errors.MissingAuthorizationError which does not set the WWW-Authenticate header
Yet the authlib.oauth2.rfc6750.validator.BearerTokenValidator has a request_invalid to be implemented by subclasses.
Shouldn't this be used instead so that different kind of token could validate the request themselves and report errors on their own terms ?
On the other hand, if I send an invalid token, authlib.rfc6750.errors.InvalidTokenError does set the WWW-Authenticate header in its get_headers method.

Could you at least explain why you consider it not being a bug ? The RFC is pretty clear. Not a book, a oneliner would be fine.

@ldng it was fixed by https://github.com/lepture/authlib/commit/62d942e62eefc76397498d0e880bb4198ec9ff22
Check the message above your comment:

lepture closed this in 62d942e

Wow, I missed the hash, apologies ! Many thanks, I need the fix.


parseQuery: Return either a query or an error

This fixes https://github.com/kyleconroy/sqlc/issues/174 and https://github.com/kyleconroy/sqlc/issues/176.
parseQuery used to return a nil query and a nil error, however the code relies on the assumption that the query is always valid if the error is not nil (as explained here).
This assumption gets correct with this change. parseQuery returns either a query or and error. There's no return nil, nil anymore.

Done, the error messages are uniformly again now.


Video links for Instruction Videos

Thank you for releasing the Instruction data
However, when I see the paths of the videos, I am not sure how to translate it to any downloadable links such as Youtube ID, e.g.
000051_000100/1066673749.mp4, 000001_000050/1066685371.mp4, ...
Could you please help?

These videos are sourced from WebVid, originally from ShutterStock (with visible watermarks). So you can either download them from ShutterStock, or some volunteering work as here.

thank you @shepnerd very much!


amplify import auth does not add an OAuth entry to the amplifyconfiguration.json

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.17.4
Amplify CLI Version
5.3.0
What operating system are you using?
Mac oS
Amplify Categories
auth
Amplify Commands
add
Describe the bug
When going through the process using amplify import auth to import an existing Cognito pool, the section OAuth with the WebDomain is missing and Amplify.Auth.signInWithWebUI fails (because WebDomain is nil).
Expected behavior
The amplifyconfiguration.json should contain and Auth.Default.OAuth.Webdomain section like so:
{
    "UserAgent": "aws-amplify-cli/2.0",
    "Version": "1.0",
    "auth": {
        "plugins": {
            "awsCognitoAuthPlugin": {
                "UserAgent": "aws-amplify/cli",
                "Version": "0.1.0",
                "IdentityManager": {
                    "Default": {}
                },
                "CredentialsProvider": {
                    "CognitoIdentity": {
                        "Default": {
                            "PoolId": "xxx",
                            "Region": "xxx"
                        }
                    }
                },
                "CognitoUserPool": {
                    "Default": {
                        "PoolId": "xxx",
                        "AppClientId": "xxx",
                        "AppClientSecret": "xxx",
                        "Region": "xxx"
                    }
                },
                "Auth": {
                    "Default": {
                        "OAuth": {
                            "WebDomain": "xxxx.amazoncognito.com",
                            "AppClientId": "xxx",
                            "AppClientSecret": "xxx",
                            "SignInRedirectURI": "xxx",
                            "SignOutRedirectURI": "xxx",
                            "Scopes": [
                                "phone",
                                "email",
                                "openid",
                                "profile",
                                "aws.cognito.signin.user.admin"
                            ]
                        },
                        "authenticationFlowType": "USER_SRP_AUTH"
                    }
                }
            }
        }
    }
}

Reproduction steps

Start a clean project
Add a previously existing Cognito pool using
amplify import auth

check the resulting amplifyconfiguration.json.
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
Here's the amplifyconfiguration.json that was created after I went through the process:
{
    "UserAgent": "aws-amplify-cli/2.0",
    "Version": "1.0",
    "auth": {
        "plugins": {
            "awsCognitoAuthPlugin": {
                "UserAgent": "aws-amplify/cli",
                "Version": "0.1.0",
                "IdentityManager": {
                    "Default": {}
                },
                "CredentialsProvider": {
                    "CognitoIdentity": {
                        "Default": {
                            "PoolId": "***",
                            "Region": "***"
                        }
                    }
                },
                "CognitoUserPool": {
                    "Default": {
                        "PoolId": "***",
                        "AppClientId": "***",
                        "Region": "***"
                    }
                },
                "Auth": {
                    "Default": {
                        "authenticationFlowType": "USER_SRP_AUTH"
                    }
                }
            }
        }
    }
    ```

@Bersaelor I was able to import a user pool with OAuth configured and the values were populated in the amplifyconfiguration.json file. Can you provide more details on what options you selected during the amplify import auth walkthrough? Also, was the imported user pool configured using Amplify CLI or was it configured external to the CLI?

The pool was external to Amplify, as it was shared with a larger Cloudformation setup, that was created outside of Amplify.

@josefaidt This is happening to me too. Doing amplify import auth doesn't include the google oauth client id in the aws-exports.js file, it only includes the oauth domain:
    "oauth": {
        "domain": "xxx.auth.us-west-2.amazoncognito.com"
    },

Hey @david-wb would you mind filing a new bug report for this occurrence?


Parquet reader handle_timestamp function is slow in broker load

Describe the bug
Broker load is slower than before this pull
(Support 64 bit timestamp in from_unixtime (#3069))
To Reproduce
date column type in table
3 broker load jobs from parquet files concurrently
load time：
before this pull：1m30s
after this pull：4m15s

@HangyuanLiu

#3300


state of this crate?

hello! I want to use the crate for an experimental project, but not sure the state of the crate. I'm wondering is there a roadmap for this crate, so that everyone can know the current state of this project？

I can also contribute something if there's a need :)

Thanks. This project is currently maintained and won't be abandoned.
I work on this project(and the ch32-rs org) in my spare time.

ch58x-hal is at an early alpha stage with common tasks available(at least BLE works)

This crate is not production ready and all the APIs will be changed
This crate is OK for any hobby project and experiment with Rust Embedded

Since CH57x/CH58x/CH59x shares almost the same peripherals, this will also be the template of ch57x-hal/ch59x-hal

They might be merged into one crate
ch58x-hal might be directly renamed to ch5xble-hal or something similar

Any contribution is welcomed.

that's cool! How can I involve myself contributing the project? Is there a contribution guide or something like it?


Close cursor in ContentUtils.queryList(...)

Added missing cursor closing in ContentUtils.queryList(...) method.

Sorry. Somehow I managed to pull request all changes from 1.8.0 to 2.0.0.


Doubt/Help;Bug;Suggestion

很抱歉我不太懂英语所以没有搜索issue但是我看到最新的open issue和我的3很像。我只是想把想法告诉你，但是不太会提交issue见谅。
I'm sorry I don't know much English so I didn't search for issue but I see that the latest issue is very similar to my 3. I just want to tell you the idea, but not very good at submitting issues sorry.

我认为这个排版比较乱开了空白但是被关闭只能出此下策
I think this typography is rather messed up opening the blanks but being shut down is the only way out

1.修改时区，但是界面多个地方显示的还是0时区，比如维护。
2.使用webhook作为通知，我找不到相关文档介绍json的参数  比如 heartbeatJSON 和 monitorJSON  只有示例的一个name。另外建议不要使用 hint 作为提示 会无法复制。
3.通知会把所有状态通知，希望可以设置 失败或者成功 或者特征符合才通知 而不是默认每次都通知。
4.对应http关键词匹配，建议增加匹配类型。比如多个关键词 分组匹配 以及 or/and/! 之类的语义。当然能支持正则更好。也可以解析XML作为部分固定关键词监控或者 区域dom监控 文本截取范围监控。

change the time zone, but the interface still shows 0 time zone in many places, such as maintenance.

use webhook as notification, I can't find any documentation about json parameters such as heartbeatJSON and monitorJSON, only a name for example, and I suggest not to use hint as hint, it won't be able to be copied. 3. notification will notify all statuses, I hope to set failure or success or feature match to be notified, instead of default to notify every time.

notification will notify all statuses, I hope it can be set to notify only when failure or success or feature match instead of default notification every time.

For http keyword matching, it is suggested to increase the matching type. Such as multiple keywords, group matching, and or/and/! or/and/! Of course, it's better to support regularization. You can also parse XML as part of the fixed keyword monitoring or regional dom monitoring text interception range monitoring.

Translated with www.DeepL.com/Translator (free version)

First of all:
Please only open one issue per issue, otherwise this is even harder to handle, as this leads to zombie issues.
Currently, this issue is very likely not going to lead anywhere because it is not focused on any issue.
Regarding the issues you mentioned:

Please post an annotated screenshot of what you are referring to. (From the translation it is not clear to me what you mean)
a slightly improved documentation was merged in https://github.com/louislam/uptime-kuma/pull/3636 and will be released in the v2 milestone. If this updated doc is not clear: how would you document this?
https://github.com/louislam/uptime-kuma/issues/3585

multiple keywords This was orginally attempted in https://github.com/louislam/uptime-kuma/pull/518, but that attempt failed. Maybe https://github.com/louislam/uptime-kuma/pull/3919 will result in such a feature. Currently, you will need to use monitor groups to get such a result
group matching Are you refering to monitor groups?
or/and/! or/and/! Please refer to the issues linked to https://github.com/louislam/uptime-kuma/pull/1236
Of course, it's better to support regularization Unclear what you mean by regularization Please open an issue in which you explain how this should work exactly and what features would be important
You can also parse XML as part of the fixed keyword monitoring Please open an issue in which you explain how this should work exactly and what xml-features would be important
regional dom monitoring text interception range monitoring likely https://changedetection.io/ is a better fit

For all the above issues the same holds true: we are a community driven project => here is our contribution guide: https://github.com/louislam/uptime-kuma/blob/5b6522a54edad9737fccf195f9eaa25c6fb9d0f6/CONTRIBUTING.md

謝謝你的建議，一般來說，我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的，提交時不應刪除該格式。
如果你找到相關建議，可以在該建議點一下讚(👍)，以增加該建議的關注度。如有補充，可以在該建議留言。

英文實在不行的話，只寫中文也可以。因為中英同時出現反而更亂。
參考這個: https://github.com/louislam/uptime-kuma/issues/4172

謝謝你的建議，一般來說，我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的，提交時不應刪除該格式。
如果你找到相關建議，可以在該建議點一下讚(👍)，以增加該建議的關注度。如有補充，可以在該建議留言。

抱歉问个题外话 你是国人吗 我看你在香港 这样的话我就可以用正常语气交流发布issue 而不用模拟倒装句这里的英语习惯语法
感觉自己有点傻 机翻了半天作者原来是国人看得懂中文哈哈 不过也有点激动有一种他乡遇故知的感觉 在这里看到中文回复有点亲切

是的，香港人。雖然不會寫簡體中文，也不懂說普通話，但看得懂。

Regarding 2, I can't get https://github.com/louislam/uptime-kuma/pull/3636 to show up

This PR will be included in the next release (see the v2.0-milestone for further details)


Menu bar alt+Letter accelerator keys no longer work

Issue Type: Bug
I am no longer able to press Alt+Letter to activate a menubar menu dropdown. Menu items are still selectable with a mouse.
I have validated this with the latest Insiders build, vscode v1.25.1, and the latest preview of SqlOps Studio.
I have tried with all extensions disabled and on Windows 10 as well as Windows Server 2016. Alt+Letter menu mnemonics are also enabled with no effect.
The Windows Server 2016 test was done with a straight install of vscode 1.25.1 with no additional extensions.
 Today things seem to be working properly. It must be some weird environmental thing causing this issue -- on multiple machines. ☹


Strict null: missing a case for arrays

TypeScript Version:  3.7.x-dev.201xxxxx
Search Terms:
strict null array
Code
const someStringArray: string[] = [];
const someString = someStringArray.filter(_ => false)[0];

console.log(someString.length);

Expected behavior:
someString is string | undefined
Actual behavior:
someString is string

Simpler repro:
const someStringArray: string[] = [];
const someString = someStringArray[100];

console.log(someString.length);

This is a duplicate of #15661 (and #13778). This behavior is by design.

This means TS is loosing type information:
IS
function something(index: number): boolean {
    const item = foo[index];

    return item && item.pinned;
}

MUST BE
function something(index: number): boolean | undefined {
    const item = foo[index];

    return item && item.pinned;
}

Yes, that is true. But again: this is intentional, it's by design. Otherwise nearly every array-access needs to be checked for undefined, and the TypeScript team did not consider this acceptable. Also TypeScript does not aim to provide a sound type-system (non-goal 3).
There's the open issue #13778 to introduce a compiler-option to change this behavior.


OOP-School-Libary: Unit Tests

In This Pull Request
@Rachelwebdev and  @jodavid444  implemented the following

Add unit tests for all the methods in all the classes:🛠
[x] Book
[x] Person
[x] Student
[x] Teacher
[x] Classroom
[x] Rental
All classes implementing the Decorator design pattern

Thank you for spending quality time reviewing and approving our project, keep up the good work @rloterh


Unnecessary reslicing on ranged slice for BCE

https://github.com/gorgonia/vecf64/blob/6314d1b6cefc75ece7e9b787afabac009c892b1e/arith.go#L8-L10
Since the loop in L10 ranges over a, there is no need to reslice a in L8 to force a bound check on a. Although no instruction is generated for L8 (at least not in optimized mode, where I have checked), perhaps it may be a good idea to not have this and similar lines lingering in the source? If so, you may also want to update README.md to say it is b = b[:len(a)] that is critical.
(Just to be clear, yes, the reslice of b in L9 is indeed critical for BCE. I am only talking about L8 here.)

Hm, so Go's BCE has gotten much smarter. Will update. Thanks


(Page) Idea Sandbox Page

Help Wanted
I need to make Idea Sandbox page to contain all of creative idea from students, it is required to :

Contain Searchbar, filter by something, create idea button
Fetch all idea from the database (for temporary use dummy data)
Show all idea but only 10 - 15 idea with pagination per page? so it will boost the performance
Continue from num 2, when the idea clicked it will show the details page (i'll explain details page later, lets focus to idea sandbox)

ini assign aja ke aku
ntar pake react-query buat data fetching, sekalian aku pasangin error boundary sama suspense

Oke boleh pake react-query aja soalnya lebih optimal ya buat cachingnya


always trigger DC power supply update when changing between charge an…

…d discharge

This fixes a bug when e.g. switching from -5000W to +5000W in hack_bpt mode


inferring system includes

For projects that use #include <someInclude.h> rather than #include "someInclude.h" for non-system includes, cppclean will print
filename:line: 'Func' not found in any directly #included header

The logic is found in ast.py here. (If there is < then it is a system include). It looks like whether a include is system or not is used in find_warnings.py here. Removing this logic (making all includes non-system includes) removes the false positive described above but introduces a new false positive:
filename:line: unable to find 'cmath'

This may be obvious but can you help me understand why system includes aren't being checked in the same way?
Assuming system includes do need to be differentiated, a solution to the above problem is to have users distinguish system includes on the cppclean call (e.g., using -I for system includes and -i for non-system includes.). It would then be a simple check in ast.py for whether a given include is in one of those sets of paths. If it is in neither, system could be assumed.
I am happy to submit a pull request if desired.
A practical example can be found from cloning SCRIMMAGE here and running the following:
cppclean -I src/proto_conversions/ProtoConversions.cpp

Perhaps it doesn't check the system includes for simplicity. It avoids requiring the user to specify the system include paths.
I wonder if the proposed solution would break backward compatibility.

It would. What do you think about keeping the existing functionality as is but let users use the new logic by specifying -Is for system includes and -In for non-system includes. The logic would be

if the file is found in the includes specified by -Is (-In) then it is a system include (not a system include)
all other cases use the old logic

@esquires I think that sounds reasonable.

This is closed by #110.


Nuget Package?

Is there an updated Nuget package for this? Thanks!

Paging @JamesDriscoll who originally contributed the error log implementation for PostgreSQL.


Refactor to AndroidX

Fix #146. TODO:

[x] Rename to com.takisoft.preferencex;
[x] BUG: Scrollbars in SeekbarPreference?

Continuing discussion in #171, I think it's best to rename this repo with redirection and keep the old code in another branch. Also I'd like to change version scheme if you don't mind (see https://github.com/Gericop/Android-Support-Preference-V7-Fix/commit/2549217012264c3a3f8554633dde24f3c103a12b).

@Gericop Ready to merge.

@Gericop Ready to merge.

Going to test it thoroughly and hopefully release it tomorrow to bintray.

Any updates?

 First it launched the app which crashed due to "missing MyApplication" class (wtf? it's there...) and now it just wouldn't recognize the project as an Android one anymore...

At least the bintray repo is set up at https://bintray.com/takisoft/android.

Awesome! You should try clean project + invalidate cache and restart. 🤣

I found one error so far: the applicationId was set to com.takisoft.preferencefix in the gradle file instead of com.takisoft.preferencex.demo. Changing it and cleaning the project helped 😅

Well, on API 15 and 17 (so probably below API 21) the SeekBarPreference has bad padding.

API 15
API 17

Hmm yeah I didn't test API <19. 😅

Well, found the other "easter egg":
This is how the SeekBar is aligned with the title:
android:paddingStart="@dimen/preference_seekbar_padding_start"
android:paddingEnd="@dimen/preference_seekbar_padding_end"

which just doesn't work, the paddings in the emulator are symmetrical instead of being 0dp on the left and 22dp on the right. How to fix it? Add the paddingLeft and paddingRight attributes too:
android:paddingStart="@dimen/preference_seekbar_padding_start"
android:paddingLeft="@dimen/preference_seekbar_padding_start"
android:paddingEnd="@dimen/preference_seekbar_padding_end"
android:paddingRight="@dimen/preference_seekbar_padding_end"

Now the SeekBar is aligned with the text above it. And where's the fun, you might ask. Well:

Redundant attribute paddingLeft; already defining paddingStart with targetSdkVersion 28.
Redundant attribute paddingRight; already defining paddingEnd with targetSdkVersion 28.

Reported it: https://issuetracker.google.com/issues/111405638

Also, committed a patch to the AOSP to fix this in AndroidX:
https://android-review.googlesource.com/c/platform/frameworks/support/+/717258

Huh nice. I'm guessing that not even Google cares about Android 4.x any more.
BTW how do you contribute to AOSP?

Yeah, I get that Android 4.x is pretty old but if they officially support it by setting the minSdk to 14 then they should test everything at least once...
Check out the Submitting Pathes guide for details about how to contribute to AOSP.

Thanks! Seems pretty complicated...

Redundant attribute paddingLeft; already defining paddingStart with targetSdkVersion 28.
Redundant attribute paddingRight; already defining paddingEnd with targetSdkVersion 28.

I think that's just a warning. You can suppress it using tools:ignore="RtlHardcoded". Is there anything else that's holding this release back? I just tested it on API 19 and it seems to work fine.

Looks good! I'm already starting to use it in my own project. Kudos to you!

Meanwhile it became available on jcenter, so you don't need to specify the repo URL separately.

@Mygod Funny thing is, I reported the issue about the SeekBarPreference's bad paddings, the assigned guy asks for a sample project, but I just cannot reproduce it on API 17 in a new project. Tried to strip the sample project in this lib so that it would look like the one in the new project and it reproduces the issue... WTF? 😅 I just don't understand...

Oh wow. So found the single attribute that decides whether it produces the error or not: android:supportsRtl in the manifest. If it's set to true, the paddings are good on API 17 (API 15 still looks bad) but if it's false (defaults to that), the paddingStart and paddingEnd attributes are not interpreted on pre-Lollipop devices.

No need in my opinion as the lib contains the fixed layout files, and as soon as the patch gets reviewed and merged (and released ofc), I'll remove them.

Sounds good.

@Gericop @Mygod Hi, thanks a lot for this lib, helped me a lot in my projects. However, after updating to androidx, all of my settings fragment got additional margin from the left (As seen in this screenshot: https://user-images.githubusercontent.com/5181621/42691091-fdd97c6c-86a6-11e8-891f-a2460035e182.png)
Is there any way to disable it? Tried to @null icon / etc but it didn't work.

That's because the new design reserves the icon space automatically so if you set an icon on one or more preferences, it wouldn't look awkward. That being said, you can turn it off by setting the app:iconSpaceReserved to false on every preference in the XML.

@Gericop Thanks, will test it out. The next thing i noticed, is that onSharedPreferenceChanged is not getting called at all. Its inflated by replacing FrameLayout with fragment from parent activity.

Btw, #132 still occures in alpha01

@feelfreelinux What do you mean onSharedPreferenceChanged is not getting called? It works in the sample app.

@Gericop Oh, my fault. During AndroidX refactor, I accidentally removed onResume override where I was setting onSharedPreferenceChanged. Thanks a lot.

It seems like the icon (and the space for it) is handled differently in the category layout than in a preference, and thus it does not work. I'll file a bug with Google and provide a bug fix in this lib until it gets resolved officially.

@adrcotfas @feelfreelinux Reopened the #132 issue. Also, published v1.0.0-alpha2 that contains the bug fix for this problem.


Allow multiple Prefer values & avoid count on plurality=singular

Thanks, I'll review it this evening!

I restructured these commits for cleaner git history and merged them.


Enable fullscreen API

Is there a way to enable the fullscreen API for the qbrt shell?
i e a user loads Youtube into a qbrt shell, accesses a video, clicks the "fullscreen" button and receives a fullscreen representation of the video?
I remember back in the Xulrunner days you had to set a preference (in prefs.js) for that.
However, that no longer seems to work. Or perhaps I'm just not remembering the correct preference (I tried setting full-screen-api.enabled to true and full-screen-api.approval-required to false).
Setting window.fullScreen to true from a chrome privileged scope isn't always an option, so enabling the requestFullscreen API would be highly appreciated.

Thanks.
Strangely, updates to the prefs.js profile file aren't properly propagated in my build.
Even deleting the profile folder inside the user directory didn't fix this. Some weird monkey business, albeit one I'm quite certain I can figure out.
Anyhow. I then explicitly set full-screen-api.enabled to true from within the shell's main.js and can confirm that this does indeed work.

qbrt copies its application files (including prefs.js) into the Firefox installation dir after it installs Firefox into the dist/ dir. If you make changes to qbrt's app files, you need to node ./bin/install-xulapp.js afterward to get qbrt to re-copy those files. (Warning: that script is internal and unstable, so it's likely to change.)

Ah. Ok. Didn't know that.
I assumed it was using its own set of prefs stored inside the user directory, like XULRunner applications of yonder.
In any case, I added something to your other ticket.
Unless you want a very specific implementation, this should be a "low hanging fruit".

Hmm, it still works for me with a local application and a recent version of Firefox. I added pref("full-screen-api.enabled", true); to the defaults/preferences/prefs.js file, ensured the file got copied into the right part of the dist/ directory via node ./bin/install-xulapp.js, and then added document.documentElement.requestFullscreen(); to examples/hello-world-html/app.js. Running that app then caused it to enter fullscreen mode.

Yep.
Just tried that. I can confirm that actually works.
It seems the issue comes down to an implementation detail of my app (which uses mozbrowser for its views).
Well. No biggies. I'll fix that eventually.
 Adding require() to my internal fork yesterday afternoon stoked a fire in me. :cat: :dog:


python310Packages.css-inline: 0.10.0 -> 0.10.1

https://github.com/Stranger6667/css-inline/releases/tag/python-v0.10.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239337 run on x86_64-linux 1

4 packages built:

python310Packages.css-inline
python310Packages.css-inline.dist
python311Packages.css-inline
python311Packages.css-inline.dist


Local

Changelog

Add
Fix
Update

Reviewed by
@developer_github_id
Linked issue
#issue_number

I guess this PR is created as a mistake.


Run by line: no way to stop execution

Testing #133903
Should we have a stop button to stop execution?
Also continue execution does not respect breakpoints? Is this expected?
Bonus idea: the other actions in the toolbar do not make much sense while you are running, do they? Should we customise the toolbar a bit more while the user is running?

To stop execution we have the interrupt button on the left.


Collection should sort on fetch

Is it possible to have a collection auto sort itself when it is fetched? I.E. if I define a comparator on the collection and fetch is called, can I have that sort post fetch?

I just ran into this myself after spending some time trying to figure out why passing the comparator option to a collection wasn't doing anything. I think the problem some people have with this is two-fold:

There is no mention on how to order data in the documentation (search for "order" or "orderBy")
Confusion is further increased when you search for "sort" which leads to the Backbone method of the same name, implying that it's the only way to sort data with Bookshelf

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again


Power Run show error message when shutting down Windows

Environment
Windows build number: [20161.1000]
PowerToys version: 0.19
PowerToy module for which you are reporting the bug (if applicable): Power Run

Steps to reproduce

Set Power Run to Turn on
Shutdown the Windows

Expected behavior
not showing error

Actual behavior
Showing Error

Screenshots
Sorry no screenshot because it's too fast

Dupe of 2820?
Kind of hard to determine with as little information provided here.

tracked in #2820.  We think we have the app_error.png fixed but not the actual underling crash


Microsoft SQL Server - can't log in

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
Can't login into MSSQL.
I use login sa, add new user uptimekuma and uptimekuma1 with right to read database with password: "password" but can't login into MSSQL. When using SSMS i can log in so login and password are ok. What could be wrong?
Connection string:
Server=<IP_ADDRESS>,1434;Database=[DATABASENAME]; User Id=uptimekuma1;Password=[password];Encrypt=true;TrustServerCertificate=Yes;Connection Timeout=30
SELECT TOP (1000) [Name]
,[VersionMajor]
,[VersionMinor]
,[VersionBuild]
,[VersionRevision]
,[DeploymentName]
,[DeploymentManifest]
FROM [DATABASENAME].[Launcher].[InstalledProducts]
📝 Error Message(s) or Log
SSMS logs from SQL:
Message
Login failed for user 'uptimekuma1'. Reason: Password did not match that for the login provided. [CLIENT: <IP_ADDRESS>]
Message
Login failed for user 'uptimekuma'. Reason: Password did not match that for the login provided. [CLIENT: <IP_ADDRESS>]
Uptimekuma logs:
[MONITOR] WARN: Monitor #2 'SQL': Failing: Login failed for user 'uptimekuma1'. | Interval: 60 seconds | Type: sqlserver | Down Count: 0 | Resend Interval: 0
🐻 Uptime-Kuma Version
YARN_VERSION=1.22.19
💻 Operating System and Arch
Docker on Ubuntu 22.04
🌐 Browser
firefox 114.0.2 (64 bity)
🐋 Docker Version
Standalone 24.0.2
🟩 NodeJS Version
No response

If there are whitespace/non-asci characters in your password, could you try removing them?
Can you log in locally using the same credentials?

If there are whitespace/non-asci characters in your password, could you try removing them?

i use password as: password and still fail.

Can you log in locally using the same credentials?

yes, as i say i log in using SQL Server Management Studio (SSMS)
something is happening in uptime kuma that change wording of password

Are you certain that password is your password?
when I try
sudo docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=password" -p 1433:1433 mcr.microsoft.com/mssql/server:2022-latest
I get:
2023-07-06 12:01:19.86 spid51s     ERROR: Unable to set system administrator password: Password validation failed. The password does not meet SQL Server password policy requirements because it is not complex enough. The password must be at least 8 characters long and contain characters from three of the following four sets: Uppercase letters, Lowercase letters, Base 10 digits, and Symbols..

I'm billion % certain. 💯
mate i have already administrative password for admin (SA) and i add new user (second login) uptimekuma and (third login) uptimekuma1 and i set their password using SSMS and password is "password".
As i sayed i can successfully login into my MSSQL using SSMS using uptimekuma as login and password as password. Only UptimeKuma can't handle that and MSSQL logs says that password is wrong. I also try hard password first but because of that bug i try easy one. Login using SA (admin user) doesn't work. IDK why. I think that's bug in formatting connection string but don't know where it it.

@filipdot I don't seem to be able to reproduce this issue using the following steps:

Run:sudo docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=abcABC123_" -p 1433:1433 mcr.microsoft.com/mssql/server:2022-latest

Enter container with:sudo docker exec -it <container_name> "bash"

Login to MSSQL with:/opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P "abcABC123_"

Create a new database and list all databases withCREATE DATABASE TestDB;
SELECT Name from sys.databases;
GO

That then returnsName
--------------------------------------------------------------------------------------------------------------------------------
master
tempdb
model
msdb
TestDB

Then I create a new MSSQL monitor in Uptime Kuma with the following config:
Connection stringServer=localhost,1433;Database=TestDB;User Id=SA;Password=abcABC123_;Encrypt=false;TrustServerCertificate=Yes;Connection Timeout=20000

QuerySELECT getdate();

This all completes successfully and the monitor is marked as up. Is there any key differences you can spot between how I have tested this and how you run your system?

Server properties in Docker on Ubuntu 1804:

I test my credentials using SSMS Microsoft SQL Server Management Studio where i add new user over "sa" with name "uptimekuma".
Using SSMS i can connect and make query and get response

In uptimekuma connection string look like this:
Server=<IP_ADDRESS>,1434;Database=[DATABASENAME ]; User Id=uptimekuma;Password=[password];Encrypt=true;TrustServerCertificate=Yes;Connection Timeout=30
query:
SELECT TOP (1000) [Name]
,[VersionMajor]
,[VersionMinor]
,[VersionBuild]
,[VersionRevision]
,[DeploymentName]
,[DeploymentManifest]
FROM [DATABASENAME ].[InsLauncher].[InstalledProducts]
and it fails

don't know why, don't know what is special in my case.
In SSMS in logs i see that is something with password maching but i change it befor that try to "password" and still.

UPDATE:
new string:
Server=<IP_ADDRESS>,1434;Database=[DATABASENAME ]; User Id=uptimekuma;Password=password;Encrypt=true;TrustServerCertificate=Yes;Connection Timeout=30
And it work.
[ and ] next to password in Password make it wrong.
Now it's up.
Thank you for forcing me to do another check and poke it around.


Initialization mail sent for verified users (console)

Describe the bug
Email verified is checked, and email is sent to the user
To Reproduce

Users > New
Enter Details
Check "Email verified"
Create
Check inbox

Expected behavior
As indicated in the info box: no email
Screenshots
If applicable, add screenshots to help explain your problem.

@mffap this is correct, because the user has to set a password
we already work on a solution, that an administrator is able to set an initial password
@peintnermax can you tell more about the timeline of the fix?

But then the text in the infobox is not correct. This should be consistent with the behavior of the application.

yes thats correct. the text is wrong

Does this fix the problem for now? #2920

It solves only the wording.
I'm still not clear on the process, though. Why does the user has to "finish initialization"? Whats the benefit of that step then? Is this explained in the manual?

We also need a code if the user needs to set a password, so no one else can set a password for this user.
But de message is still wrong, because on init user the mail is for two things, email verification and password setting.
So we need a possibility to set an initial password and the message should be something like if the email is already verified and a password is set, the user will not receive an email.

I've added the capability to set a password. Would this wording be correct?

this is the PR #2920

no it is still the same wording for me, this message says that if I check the checkbox for email verified, that I get no email. but this is only correct in combination with the initial password. or does the message change, when i haven't checked the box for "set initial password"?


Project Description & Outline Wiki

Create the Wiki page according to the project document shared by @uskudarli and notes from the meeting with @uskudarli held in CMPE @ Feb 19, 2019

A wiki page for the project description as being created


fix: allow duplicate slice names

Description
Allow duplicate slice names, mainly so we can easily "Create slices for all values" without worrying about existing slice names. This was decided during a discussion on ZEN-282.
(Note: we probably need a way to disambiguate slices with the same name in the chart editor … maybe by including the folder name as well)
References
fix ZEN-399
(Note: this is a duplicate of my previous PR #531 which was created from a fork. CI tests kept failing because Github Action secrets are not accessible if the PR is from a fork)

Hi @zaidsheikh is this ready for review?

I need to push one more commit to fix an issue with charts (they currently assume slice names are unique, so only one slice is shown even if multiple slices with the same name are selected).

Ah ok sounds good, thank you!


Improve explanation in Pattern Matching lesson

What really helped me understand how pattern matching in Elixir/Erlang work is to compare the '=' operator to the equals sign in algebra. I would phrase the introductory sentence in the section like so. What do you think?
Are you ready for a curveball? In Elixir, the = operator is actually a match operator, comparable to the equals sign in algebra. If you think about it, writing x = x + 1 is fundamentally wrong in algebra, so Elixir does not let you do it. Instead, writing = makes Elixir match the value of variables on the left-hand side with values on the right-hand side. Let's take a look:
(and so on, maybe smaller changes to the examples but I would put that in the Pull Request)

Are you ready for a curveball might not translate very well. I don't know if I like the algebraic comparison. Thoughts @doomspork? I totally agree that we need some overall refinement especially from the perspective of new people diving in, but worry about getting too dense too early myself.

@ybur-yug, Are you ready for a curveball is already a part of the original lesson and is translated as well. So I don't think there will be any issues related to translations.
Thanks, @holsky, this is definitely a good idea!
In my opinion, the algebraic comparison is actually one of the simplest way to explain how does this work. I'd suggest something like the following:
Are you ready for a curveball? In Elixir, the = operator is actually a match operator, comparable to the equals sign in algebra. Writing it turns the whole expression into an equation and makes Elixir match the values on the left hand with the values on the right hand. If the match succeeds, it returns the value of the equation. Otherwise, it throws an error. Let's take a look:
What do you think?
I'm ready to propose a PR with these changes and I'd also prepare the Russian translation if you find this a good idea.

@nscyclone that sounds great, please open a PR

Didn't have time to look before, but looks good :)


Did some code improvements to CARBON-14957

Hi @pulasthi7,
Do we still need this fix? If so, would you please attend to fix the merge conflicts?


Replace DllImport with LibraryImport in SMA 2

PR Summary

Since LibraryImport is designed for more efficient code, refactoring was done to exclude auxiliary allocations.
The standard SpanMashaller is used for parameter marshalling, which excludes fixed, pinned and unsafe code.
Of the three branches of code, two are dead code because GetDosDevice() is only called if PSDrive.DriveType == DriveType.Network
New test is added for the case (network psdrive).
To test:

Create new DOS device under Administrator

subst g: \\localhost\c$\tmp

Run pwsh under Administrator and Get-PSDrive

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Contributes to #18553.


[gardenlet] Switch Shoot care controller to controller-runtime

How to categorize this PR?

/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Refactor the Shoot care controller to controller-runtime.
The other two controllers (migration, main) were already refactored separately (ref #7062 and #7082).
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:

Add documentation
Add integration test based on envtest (if not already present)
Switch controller to controller-runtime

This PR is very similar to parts of #6836.
/cc @shafeeqes @ary1992
Release note:

NONE

/test pull-gardener-e2e-kind

/assign

/lgtm

/lgtm

/hold
let's merge https://github.com/gardener/gardener/pull/7108 first

Awesome! Let's go 🚀
/lgtm
/approve
/unhold

/test pull-gardener-e2e-kind


customize the quick pallet

[x] I agree to follow the Code of Conduct that this project adheres to.
[ x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

i'd like to customize this quick pallet, now it will always popup the same diagram
Describe the solution you'd like
maybe we can drag and drop the diagram from and to the pallet

any suggestion, maybe i can contribute the code

This is something that my organisation is looking to be able to do too. We use BPMN symbols, so would like to be able to customise the pop-up to show only these options.

Please only comment when adding additional information. Me too and +1s just create comment noise. Instead, thumbs up the original request.


CMP: add support for requesting certReqTemplate using genm/genp

This pull request adds the ability to retrieve a certificate request template in the CMP client, following the guidelines outlined in section 4.3.3 of RFC 9483.
To request the certificate request template, the CMP client can send a genm message with the -infotype certReqTemplate option. The server will respond with a genp message containing the CertTemplate and optionally the keySpec, using the
id-it-certReqTemplate. The client can then save the CertTemplate and KeySpec in a specified file using the -template and -keyspec parameters, respectively.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

CI is relevant

I closed it by mistake, I will reopen the pull  request.
I will move it to draft mode to fix all the CI issues.

Ping for OTC review

@t8m would it help for the OTC review of this PR if @rajeev-0 spends some effort to split this ~800 lines of code+doc
into two PRs, where the first one focuses on the more general OSSL_CMP_ATAV / OSSL_CRMF_ATTRIBUTETYPEANDVALUE additions, which amount to about 300 lines?

Thank you @t8m for the review.

@DDvO generally speaking, yes, I find smaller PRS easier to review, and would appreciate the split

24 hours has passed since 'approval: done' was set, but as this PR has been  updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

@DDvO generally speaking, yes, I find smaller PRS easier to review, and would appreciate the split

Yep, we will consider this in future PRs of (at least) similar size.

Merged to master - thanks @rajeev-0 for the contribution and @t8m for the OTC review.

I do appreciate 🙏

Requesting help in this regard.

BTW, essentially the same template-based approach for specifying CSR contents meanwhile has been defined also for EST:
https://datatracker.ietf.org/doc/html/draft-ietf-lamps-rfc7030-csrattrs#section-3.3


Domoticz only shows "loading..."

Issue description
Plugin shows loading... why accessing it through the Domoticz UI. While in non-verbose/debugmode, the logfile says: (Zigbee2MQTT) Joining new devices is disabled on the zigbee bridge
This is strange, since the permit_join option in the the configuration.yaml is set to: true
Even when I manuall publish the command to put it back to 'true', it will display in the log as 'disabled' as soon as I load the 'zigbee2mqtt' tab within the Domoticz UI.
Additional information
Zigbee2MQTT version: 1.13.0-dev
Python version: 2.7.16
Domoticz version: 4.11670
Plugin version: 0.2.0
Logs record when I open the zigbee2mqqt tab within Domoticz UI
2020-05-22 23:01:18.005 Status: (Zigbee2MQTT) Initialized version 0.2.0
2020-05-22 23:01:18.004 Status: (Zigbee2MQTT) Entering work loop.
2020-05-22 23:01:28.055 (Zigbee2MQTT) MqttClient::ping
2020-05-22 23:01:38.027 (Zigbee2MQTT) MqttClient::ping
2020-05-22 23:01:48.056 (Zigbee2MQTT) MqttClient::ping
2020-05-22 23:01:50.764 (Zigbee2MQTT) New request: [4] bridge_getstatus({})
2020-05-22 23:01:50.764 (Zigbee2MQTT) MqttClient::publish zigbee2mqtt/bridge/config/permit_join ()
2020-05-22 23:01:50.815 (Zigbee2MQTT) MQTT message: zigbee2mqtt/bridge/config/permit_join
2020-05-22 23:01:51.116 (Zigbee2MQTT) MQTT message: zigbee2mqtt/bridge/config {'version': '1.13.0-dev', 'commit': 'ad9421a', 'coordinator': {'type': 'zStack12', 'meta': {'transportrev': 2, 'product': 0, 'majorrel': 2, 'minorrel': 6, 'maintrel': 3, 'revision': 20190608}}, 'log_level': 'info', 'permit_join': False}
2020-05-22 23:01:51.119 (Zigbee2MQTT) Zigbee2mqtt log level is info
2020-05-22 23:01:51.119 (Zigbee2MQTT) Joining new devices is disabled on the zigbee bridge
2020-05-22 23:01:58.031 (Zigbee2MQTT) MqttClient::ping

Could you please enable debug mode and see what's in the log

Could you please enable debug mode and see what's in the log

Well, above log is with debug mode enabled/true. I have to say, my (only) zigbee device, an Ikea G10 light, works fine and is controlled by domoticz.

Probably something is wrong with MQTT connection then. Do you receive realtime updates on other Domoticz pages?

Probably something is wrong with MQTT connection then. Do you receive realtime updates on other Domoticz pages?
Yes, I do. I for instance have created a function to slowly dim the Zigbee light by creating a for-next loop that sets as many needed new light level steps in a given interval. In the GUI of domoticz, I see the dimmer switch stepping nicely through the given values when the script tells it to do so.


Wrong URL for external package cross-reference

Describe the bug
A cross reference to torch.utils.data.DataLoader is rendered with incorrect links.

Here, torch points to https://pytorch.org/docs/1.10.1/data.html#module-torch.utils.data. data and DataLoader point to correct URLs.
I opened up the objects.inv file provided by PyTorch with Inventory.parse_sphinx and found that it does not have entries for torch and torch.utils. In such a case, I think torch should not point to anything like how torch.utils is not linked to anything.
To Reproduce
# test.py
import torch.utils.data

class MyDataLoader(torch.utils.data.DataLoader):
    pass

<!-- docs/index.md -->
::: test.MyDataLoader

# mkdocs.yml
site_name: Test

theme:
  name: material

plugins:
  - mkdocstrings:
      handlers:
        python:
          import:
            - https://pytorch.org/docs/1.10.1/objects.inv

nav:
  - Home: index.md

System:

mkdocstrings-python version: 0.7.1
Python version: 3.9.12
OS: MacOS

Hi @jaywonchung, sorry for the late reply and thank you for the report. I'll eventually get time to investigate and fix this issue :)


Redesigning landing page

Is your feature request related to a problem? Please describe.
I feel that there is too text on the landing page. With animated websites used nowadays, that much text in one go is too much for a user. Especially new ones.
Describe the solution you'd like
I would like to redesign the landing page:

Add animations, make different sections
Reduce texts, improve font size and combination

Current landing page:

Hi @Anushkam09,
Thank you for your suggestion! I agree that improving the landing page's design and reducing text could enhance the user experience. I'd love to see how you can make the page more engaging with animations and a better layout. Looking forward to your redesign!

@Anushkam09
Hello! It's been more than 3 days since this issue was assigned. If you’re still working on it, please provide an update. Otherwise, I will need to remove you from the assignment to free it up for others to take over. Thank you!

i can work on the landing page. assign it to me

@EfrataAron any updates?

@notsoocool check your discord, im trying to reach you

i have gone through the project structure and im working on the landing page. @notsoocool

Sure @EfrataAro, and sorry, I was busy which is why I didn’t see your message on Discord.


[SPARK-29026][SQL] Improve error message in schemaFor in trait without companion object constructor

What changes were proposed in this pull request?

For trait without companion object constructor, currently the method to get constructor parameters constructParams in ScalaReflection will throw exception.

scala.ScalaReflectionException: <none> is not a term
	at scala.reflect.api.Symbols$SymbolApi.asTerm(Symbols.scala:211)
	at scala.reflect.api.Symbols$SymbolApi.asTerm$(Symbols.scala:211)
	at scala.reflect.internal.Symbols$SymbolContextApiImpl.asTerm(Symbols.scala:106)
	at org.apache.spark.sql.catalyst.ScalaReflection.getCompanionConstructor(ScalaReflection.scala:909)
	at org.apache.spark.sql.catalyst.ScalaReflection.constructParams(ScalaReflection.scala:914)
	at org.apache.spark.sql.catalyst.ScalaReflection.constructParams$(ScalaReflection.scala:912)
	at org.apache.spark.sql.catalyst.ScalaReflection$.constructParams(ScalaReflection.scala:47)
	at org.apache.spark.sql.catalyst.ScalaReflection.getConstructorParameters(ScalaReflection.scala:890)
	at org.apache.spark.sql.catalyst.ScalaReflection.getConstructorParameters$(ScalaReflection.scala:886)
	at org.apache.spark.sql.catalyst.ScalaReflection$.getConstructorParameters(ScalaReflection.scala:47)

Instead this PR would throw exception:

Unable to find constructor for type [XXX]. This could happen if [XXX] is an interface or a trait without companion object constructor
UnsupportedOperationException:

In the normal usage of ExpressionEncoder, this can happen if the type is interface extending scala.Product. Also, since this is a protected method, this could have been other arbitrary types without constructor.
Why are the changes needed?

The error message <none> is not a term isn't helpful for users to understand the problem.

Does this PR introduce any user-facing change?

The exception would be thrown instead of runtime exception from the scala.ScalaReflectionException.

How was this patch tested?

Added a unit test to illustrate the type where expression encoder will fail and trigger the proposed error message.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #110374 has started for PR 25736 at commit ee24c7a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15361/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15363/
Test PASSed.

Test build #110376 has started for PR 25736 at commit c78cd01.

Test build #110374 has finished for PR 25736 at commit ee24c7a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
        s\"This could happen if $

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110374/
Test FAILed.

Test build #110376 has finished for PR 25736 at commit c78cd01.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110376/
Test FAILed.

cc @JoshRosen

whoops sorry missed the patch here https://github.com/apache/spark/pull/23062 that caused differing behavior from our local fork. Will make an update

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15370/
Test PASSed.

This should be good now.

Test build #110383 has started for PR 25736 at commit 897f737.

Seems fine to me

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15372/
Test PASSed.

Test build #110384 has started for PR 25736 at commit 0f2c94e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15373/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15379/
Test PASSed.

Merged build finished. Test PASSed.

Test build #110391 has started for PR 25736 at commit 88de1e3.

Test build #110392 has started for PR 25736 at commit 47a9da5.

Test build #110395 has started for PR 25736 at commit 8ad3769.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15383/
Test PASSed.

Test build #110396 has started for PR 25736 at commit 722a090.

Test build #110383 has finished for PR 25736 at commit 897f737.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110383/
Test PASSed.

Test build #110384 has finished for PR 25736 at commit 0f2c94e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110384/
Test PASSed.

Test build #110395 has finished for PR 25736 at commit 8ad3769.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #110391 has finished for PR 25736 at commit 88de1e3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #110396 has finished for PR 25736 at commit 722a090.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #110392 has finished for PR 25736 at commit 47a9da5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110395/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110396/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110391/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110392/
Test FAILed.

retest this please

let me leave it to @JoshRosen

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15389/
Test PASSed.

Test build #110405 has started for PR 25736 at commit 722a090.

Test build #110405 has finished for PR 25736 at commit 722a090.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110405/
Test PASSed.

Merged to master.


23.x.x.x firmware

Hi
There is a new firmware <IP_ADDRESS>. obtainable from http://upg.cloudlinks.cn/upg/23/00/npcupg_<IP_ADDRESS>.bin.
Could anyone explain how you extract DES KEY?

Usually you can get the DES key by inspecting the npc file in the JFFS partition. So you need to

download the new firmware
extract the JFFS partition and mount it (use this tool and adjust the signatur check to not fail the script completely - maybe an option would be helpful here to skip the signature check before extracting)
open the npc file using a hex editor
search for some prefix of other DES keys (like 9c ae)
check the found results if the signature calculation works with on of the search results

I did this for the new version. So it is already supported in the version I provided in my PR. I guess you can close this issue now.
And I hope @zzerrg will merge all the new stuff soon. But looking at the other issues, there's nothing happening so far.

Thank you @ohinckel  for sharing the knowledgeand for update. Happy new year!

Unfortunately it’s not working due to sig verification fails, also tried with key ending with 00.

I have a new cam with a new firmware <IP_ADDRESS>:
# cat version.txt
<IP_ADDRESS>
P4_platform = 5987
P4_public = 5990
Release - Thu Dec  7 01:07:50 UTC 2017
#

Maybe one of you know:

why does it have not 23.xx.xx.xx instead of 22.xx.xx.xx (like my other older cams have) - obviously it seems to be a different camera having another wifi connector (cable to the front case with IR LEDs)
where can I get the original firmware since I'm only able to fetch an older one <IP_ADDRESS>

@Ohinckel - All my cameras that I ordered 2018 have this version, however just make a new firmware and enable telnet repack with same key and there will be difference.

@vilasevic Yes, I tried to use qemu-arm just to debug compiled code:
#!/bin/sh
ROOT=/var/lib/lxd/containers/buildroot/rootfs
qemu-system-arm -M versatilepb \
    -m 64M -nographic \
    -kernel output/images/zImage \
    -chardev stdio,mux=on,id=char0 \
    -mon chardev=char0,mode=readline,default \
    -serial chardev:char0 \
    -drive file=output/images/rootfs.ext2,if=scsi,format=raw \
    -net nic,model=smc91c111 -net user,tftp=${ROOT}/home/dev/buildroot/foobar \
    -append "root=/dev/sda console=ttyAMA0,115200" \
   -drive if=sd,index=1,media=disk,format=raw,file=./sdcard-1g.bin \
    $@

Hello,
I know that it's quite old but if it can help, this was my situation and how i've flashed the firmware.
My camera is a Floureon, uboot blocked (cannot flash from it). I tried several things to flash the firmware from sdcard, but it don't work. So i found a workaround.
### WARNING : if you have no other way to flash the firmware (like me), you can brick your camera if the flashing process fail, use at your own risks !! #####
Error i got when trying to update from sdcard :
== BEGIN LOG ==
fgStartCheckUpdatePack start!
fgStartCheckUpdatePack: dwFoundPackOption = 0
timecnt over!vLEDCtlThStop Exit!

You need a working serial acces to camera (i used a FT232 USB to serial adapter)

Download the firmware. For me it was : http://sratest201905.2cu.co/upg/21/00/npcupg_<IP_ADDRESS>.bin
./gm_app_fw.py -f ./npcupg_<IP_ADDRESS>.bin -u (you get app_<IP_ADDRESS>.jffs and upg_<IP_ADDRESS>.elf)
Using jefferson jffs2 extract tool (https://github.com/sviehb/jefferson) : ./jefferson app_<IP_ADDRESS>.jffs -d outdir
Edit what you want in the filesystem. I suggest to add telnetd in dhcp.script, i've also added a custom script just in case

#!/bin/sh

# udhcpc script edited by Tim Riker<EMAIL_ADDRESS>
[ -z "$1" ] && echo "Error: should be called from udhcpc" && exit 1

# CUSTOM
/usr/sbin/telnetd &
/rom/custom_script.sh &

Rebuild the image : mkfs.jffs2 -r outdir -o app_<IP_ADDRESS>_PATCHED.jffs
Copy the image on a micro sdcard, put it in the camera slot
Connect using serial, mount the sdcard if it's not already mounted : mount /dev/mmcblk0p1 /mnt/disc1
Flash the firmware directly in mtd4 : # /gm/tools/flashcp /mnt/disc1/app_<IP_ADDRESS>_PATCHED.jffs /dev/mtd4 -v
Reboot and enjoy


Circuit_to_instruction converter missing classical register for conditional gates

Information

Qiskit Terra version: master@c59caac
Python version: 3.7
Operating system: Linux

What is the current behavior?
From https://travis-ci.com/github/Qiskit/qiskit-terra/jobs/358424742#L3190 , in some cases, the transpiler is generating conditional gates without the clbits on which they are conditioned. This was noticed in (but not necessarily caused by) code added in #4622 ( https://github.com/Qiskit/qiskit-terra/pull/4622/files#diff-dd64919667465e6a3c40b2a4ed00f8e5R117 ) when building instructions from circuits with conditional gates.
Steps to reproduce the problem
Transpile the QASM from the below stack trace at optimization_level=3 targeting FakeJohannesburg.
======================================================================
ERROR: runTest (hypothesis.stateful.QCircuitMachine.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Qiskit/qiskit-terra/test/randomized/test_transpiler_equivalence.py", line 230, in equivalent_transpile
    xpiled_qc = transpile(self.qc, backend=backend, optimization_level=opt_level)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/compiler/transpile.py", line 214, in transpile
    circuits = parallel_map(_transpile_circuit, list(zip(circuits, transpile_args)))
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/tools/parallel.py", line 106, in parallel_map
    return [task(values[0], *task_args, **task_kwargs)]
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/compiler/transpile.py", line 312, in _transpile_circuit
    output_name=transpile_config['output_name'])
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/passmanager.py", line 214, in run
    return self._run_single_circuit(circuits, output_name, callback)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/passmanager.py", line 277, in _run_single_circuit
    result = running_passmanager.run(circuit, output_name=output_name, callback=callback)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/runningpassmanager.py", line 115, in run
    dag = self._do_pass(pass_, dag, passset.options)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/runningpassmanager.py", line 145, in _do_pass
    dag = self._run_this_pass(pass_, dag)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/runningpassmanager.py", line 157, in _run_this_pass
    new_dag = pass_.run(dag)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/transpiler/passes/optimization/consolidate_blocks.py", line 128, in run
    unitary = UnitaryGate(Operator(subcirc))  # simulates the circuit
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/quantum_info/operators/operator.py", line 86, in __init__
    self._data = self._init_instruction(data).data
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/quantum_info/operators/operator.py", line 490, in _init_instruction
    instruction = instruction.to_instruction()
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/circuit/quantumcircuit.py", line 819, in to_instruction
    return circuit_to_instruction(self, parameter_map)
  File "/home/travis/build/Qiskit/qiskit-terra/qiskit/converters/circuit_to_instruction.py", line 119, in circuit_to_instruction
    if reg.size == c.size:
UnboundLocalError: local variable 'c' referenced before assignment

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/stateful.py", line 393, in runTest
    run_state_machine_as_test(state_machine_class)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/stateful.py", line 75, in run_state_machine_as_test
    def run_state_machine_as_test(state_machine_factory, *, settings=None):
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/internal/reflection.py", line 652, in accept
    return func(*bound.args, **bound.kwargs)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/stateful.py", line 200, in run_state_machine_as_test
    run_state_machine(state_machine_factory)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/stateful.py", line 92, in run_state_machine
    @given(st.data())
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/hypothesis/core.py", line 1141, in wrapped_test
    raise the_error_hypothesis_found
  File "/home/travis/build/Qiskit/qiskit-terra/test/randomized/test_transpiler_equivalence.py", line 234, in equivalent_transpile
    raise RuntimeError(failed_qasm) from e
RuntimeError: Exception caught during transpilation of circuit:
OPENQASM 2.0;
include "qelib1.inc";
qreg q3110[12];
qreg q3157[2];
creg c95[5];
creg c96[2];
creg c97[5];
creg c98[5];
u2(-24.508971,1.5216458) q3110[6];
cz q3110[8],q3110[7];
u2(-17.363907,-22.934491) q3110[9];
rz(-8.7083803) q3110[4];
reset q3110[7];
cy q3110[10],q3110[3];
measure q3110[4] -> c95[0];
cz q3110[3],q3110[11];
h q3110[0];
u2(-9.6786822,2.9792195) q3110[1];
cu3(-12.105011,-7.0180632,-18.792019) q3110[5],q3110[0];
u3(28.464436,-11.005153,-3.6969371) q3110[9];
cu3(23.569199,4.5776732,-2.6956357) q3110[9],q3110[0];
rz(-11.654972) q3110[8];
u3(16.36128,25.832861,28.922542) q3110[1];
cswap q3110[9],q3110[4],q3110[3];
measure q3110[4] -> c96[0];
ch q3110[6],q3110[7];
x q3110[4];
barrier q3110[7];
ccx q3110[1],q3110[9],q3110[10];
cu3(21.612624,-18.30063,1.3315713) q3110[1],q3110[7];
cy q3110[7],q3110[10];
cy q3110[11],q3110[10];
measure q3110[6] -> c97[4];
swap q3157[0],q3110[6];
rzz(22.30788) q3110[11],q3110[6];
if(c97==13) cu3(-13.732855,-10.110604,29.464678) q3110[8],q3157[0];
ccx q3110[10],q3110[9],q3110[7];
if(c97==25) u3(9.6297074,22.387267,26.921443) q3110[2];
if(c97==8) sdg q3110[3];
rx(-7.769637) q3110[3];
ccx q3110[0],q3157[1],q3110[7];

What is the expected behavior?
Suggested solutions

The minimal code which seems to reproduce the bug is,
OPENQASM 2.0;
include "qelib1.inc";
qreg q1[2];
creg c1[1];

if(c1==1) cx q1[0], q1[1];

During transpilation the dag seems to become invalid, when running _check_condition over nodes, in consolidate_blocks. It seems consolidate_blocks relies on being able to create and simulate a circuit with a classical condition but no classical register.
A workaround would be for circuit_to_instruction to change,
if condition: -> if condition and instruction.num_clbits > 0:
although it seems strange for circuit_to_instruction to have to check both conditions.

@kdk @ewinston The following diff seems to take care of the problem and passes all the auto-tests. If this seems like a reasonable approach, let me know and I'll do a PR.
--- a/qiskit/transpiler/passes/optimization/consolidate_blocks.py
+++ b/qiskit/transpiler/passes/optimization/consolidate_blocks.py
@@ -16,7 +16,7 @@

 """Replace each block of consecutive gates by a single Unitary node."""

-from qiskit.circuit import QuantumRegister, QuantumCircuit
+from qiskit.circuit import QuantumRegister, ClassicalRegister, QuantumCircuit
 from qiskit.dagcircuit import DAGCircuit
 from qiskit.quantum_info.operators import Operator
 from qiskit.quantum_info.synthesis import TwoQubitBasisDecomposer
@@ -112,12 +112,19 @@ class ConsolidateBlocks(TransformationPass):
             else:
                 # find the qubits involved in this block
                 block_qargs = set()
+                block_cargs = set()
                 for nd in block:
                     block_qargs |= set(nd.qargs)
+                    if nd.condition:
+                        block_cargs |= set(nd.condition[0])
                 # convert block to a sub-circuit, then simulate unitary and add
-                block_width = len(block_qargs)
-                q = QuantumRegister(block_width)
-                subcirc = QuantumCircuit(q)
+                q = QuantumRegister(len(block_qargs))
+                # if condition in node, add clbits to circuit
+                if len(block_cargs) > 0:
+                    c = ClassicalRegister(len(block_cargs))
+                    subcirc = QuantumCircuit(q, c)
+                else:
+                    subcirc = QuantumCircuit(q)
                 block_index_map = self._block_qargs_to_indices(block_qargs,
                                                                global_index_map)
                 basis_count = 0

Thanks @enavarro51 . I agree that looks like a reasonable fix. Can you add a test and open a PR?

Will do. Is a reno required?

Will do. Is a reno required?

Since this fixes a bug from a previous release, a reno would be great.


app.nit services to set the size and alignment of labels

Intro services to customize the size and alignment of text views. Only labels are supported on all platforms but Android also supports customizing text buttons. The behaviour on each platform varies a bit according to the available features. The goal is always to have the behaviour that is more natural on the platform instead of having the same exact look on each platform. Sticking to the recommended values should produce more consistent results, but using other values can create interesting effects.
For example, on Android and Linux, the text size is locked to a small/medium/large, but on iOS the size can be set to any variations relative to the default font size. On all platforms, 0.5 should result in a small font, 1.0 the default/medium size and 1.5 the large size. On iOS, other values will result in different text sizes.
I've used the same logic as Text::justify to set the alignment with a single float parameter.

+1

+1