Extract page count, Timing for tika/pdf/thumbnail generation, Improve error handling and logging in PDFFileItemWriter

Sorry for the mess - needed to PR the integration branch because there was conflicts to resolve.
Separated branches can be found at KHP-Informatics repo.

No worries - lets catch up Thurs to talk about the other issues you raised
Sent from Yahoo Mail on Android
On Mon, 14 Nov, 2016 at 17:01, Kenneth<EMAIL_ADDRESS>wrote:
Sorry for the mess - needed to PR the integration branch because there was conflicts to resolve.
Separated branches can be found at KHP-Informatics repo.
You can view, comment on, or merge this pull request online at:
https://github.com/RichJackson/turbo-laser/pull/23
Commit Summary

#6 Refactor metadata extraction code in TikaDocumentItemProcessor
#6 Extract page count from Tika metadata
#6 Skeleton to extract page count from TIFF using MetadataItemProcessor
#6 Use ImageMagick identify to get page count for TIFF
#4 Timing for Tika, PDF output and thumbnail output
Include metadataItemProcessor in list of ItemHandlers
Merge branches '20161026-ft-6-num-pages' and '20161107-ft-4-logging' into 20161107-integration
#7 Improve error handling and logging in PDFFileItemWriter
Merge branch '20161111-fix-7-pdfitemwriter-error' into 20161107-integration

File Changes

A src/integration-test/resources/metadata.properties (3)
M src/main/java/uk/ac/kcl/itemHandlers/ItemHandlers.java (8)
M src/main/java/uk/ac/kcl/itemHandlers/PDFFileItemWriter.java (16)
M src/main/java/uk/ac/kcl/itemHandlers/ThumbnailFileItemWriter.java (9)
A src/main/java/uk/ac/kcl/itemProcessors/MetadataItemProcessor.java (119)
M src/main/java/uk/ac/kcl/itemProcessors/TikaDocumentItemProcessor.java (73)

Patch Links:

https://github.com/RichJackson/turbo-laser/pull/23.patch
https://github.com/RichJackson/turbo-laser/pull/23.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Just reviewed the code for this. Looks good, but can you write a test to verify?

Test is included in the latest PR #31 because the branches have diverged during the past few months.


Job Launcher - Routing protocol - get fees cost estimation

Description
Job launcher should show the fees for creating an escrow on each network.
Then the user can choose the network or let the routing protocol choose based on this and other indicators.
Motivation
Users should be able to know why the routing protocol chooses a network or another and also let them make the decision.
Implementation details
Create an endpoint to server the cost values.
Calculation: [current avg gas price] * [gas cost of launching the escrow]

ACCEPTANCE CRITERIA:

The integrated  endpoint provide  real-time fee updates.
Ensure that the system dynamically fetches and updates the current average gas price in real-time for accurate fee calculations in order to for the users to see up-to-date information when making decisions.
Update relevant documentation to include the new details


Modified logging behavior to default to stderr and moved prints to logs

Also made progress bar optional.

Hi Duncan,

Sorry it's taken me a week to look at your pull request. I have been on travel and just got back this past weekend.

I tried running your pull request with a logfile defined and for me it creates a log file but nothing is written to it. I tried both in the demo notebook as well as a standalone script and both failed to write to the log. I am using python 3.6. Does it write to a log to for you?

You changed the 'tokens_proba' and 'tag_text_proba' to write to the logger. Thats ok, but I think it is still nice to have a print option for display in the notebook demo with the NER example. I think this could be easily fixed to accommodate that.


seems a reference is missing the "sub"

"$ref": "./network.json#/definitions/Resource"
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
[ ] The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

Hi @Pacort, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (pacort). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Closing the PR as the change looks incorrect.


Can't resolve 'swiper_angular' on ng build

Swiper Version: v6.5.0 (sha1-TKIkO0T8zvR+4oGZN3ZmYH2MUUE=)
Platform/Target and Browser Versions: CI/CD (Azure Devops pipeline, nodejs v12 docker image) and macOS 10.15.7.
Angular version: v9.1.12

What You Did

We've implemented the Swiper module in our application
Added SwiperModule to our app.module.ts
Imported SwiperCore from swiper/core in the component that is consuming the swiper component

Expected Behavior
When we're developing the app locally using Angular-cli's ng serve everything works perfectly!
When we run ng build we expect the app to build as well.
Actual Behavior
We get the following errors (both locally and in azure devops pipeline):
ERROR in ./node_modules/swiper/angular/swiper_angular.ngfactory.js
Module not found: Error: Can't resolve 'swiper_angular' in '/Users/username/repo/node_modules/swiper/angular'
ERROR in ./src/components/swipeable-boxes/swipeable-boxes.component.ngfactory.js
Module not found: Error: Can't resolve 'swiper_angular' in '/Users/username/repo/src/components/swipeable-boxes'
ERROR in ./src/app/app.module.ngfactory.js
Module not found: Error: Can't resolve 'swiper_angular' in '/Users/username/repo/src/app'

Do you have any pointers what the cause of this might be and how to fix it? Willing to help and work on a fix, but unsure why this happens in the first place.

Is it happened only on ci build?

No, unfortunately it also happens on my machine when running ng build

Can you share specs of your pc ?
Is it happens only on prod build ?
Could you reproduce the bug on public repo ?

I have encounter the same issue.
I used this link as reference.
https://medium.com/@tanya/angular-library-module-not-found-error-527445d44019
And In tsconfig.json, add this, maybe it works.
  "angularCompilerOptions": {
    "paths": {
      "swiper_angular": ["node_modules/swiper/angular"]
    }
  }

Can you share specs of your pc ?
Is it happens only on prod build ?
Could you reproduce the bug on public repo ?

@vltansky

What kinds of pc-specs would you like to know? I don't think pc-specs are relevant to the issue as this error occurs both on my machine and in azure devops (which off course has completely different specs).
Yes, this only happens when running ng build --prod. The error does not occur when running ng build (apologies for not mentioning this earlier)
I will try to reproduce it in a isolated repo
The article that @komura-c mentioned might be a pointer https://medium.com/@tanya/angular-library-module-not-found-error-527445d44019
Are there minimum requirements for the versions on typescript and/or angular that I missed?

@komura-c Thank you for the comment! It definitely sounds like the same issue. I hoped your fix would work, but unfortunately it did not change anything in our repository. Do you use a custom angular.json?

@yoeran
All good.
I've changed nothing special in angular.json. spa project.
It seems internal typescript error of module imports.
https://www.typescriptlang.org/docs/handbook/module-resolution.html#relative-vs-non-relative-module-imports
And In tsconfig.json, using paths, you also need to add baseurl.
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "swiper_angular": ["node_modules/swiper/angular"]
    }
  }

I hope you can fix it soon.

I've been digging deep and have a couple of findings:

It turns out enableIvy was set to false for our project (in the angularCompilerOptions in tsconfig.json). This triggers the error as mentioned before (even more verbose). You can see it reproduced in this repository: https://github.com/yoeran/swiper-reproduce-issue. Run npm run build to see the error (I'll add a snippet at the bottom of this comment, called "Error with enableIvy set to false")
After removing the enableIvy:false property from our tsconfig.json (default of enableIvy is true). We no longer have the error, however, we do get another error when building the app. This I have not been able to reproduce in an isolated repository. I'll add this error to this comment as well.

I did find a workaround, which meant installing<EMAIL_ADDRESS>and<EMAIL_ADDRESS>This works fine for our current status. However it would be nice to be able to just use swiper and not the redundant (deprecated?) ngx-swiper-wrapper.
Error 1: When enableIvy is set to false (see linked repo to reproduce this)
ERROR in ./node_modules/swiper/angular/swiper_angular.ngfactory.js
Module not found: Error: Can't resolve 'swiper_angular' in '/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/angular'
resolve 'swiper_angular' in '/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/angular'
  Parsed request is a module
  using description file: /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/angular/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      looking for modules in /Users/yluteij/Code/SwiperBugReproduce
        using description file: /Users/yluteij/Code/SwiperBugReproduce/package.json (relative path: .)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/yluteij/Code/SwiperBugReproduce/package.json (relative path: ./swiper_angular)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular.ts doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular.tsx doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular.js doesn't exist
            as directory
              /Users/yluteij/Code/SwiperBugReproduce/swiper_angular doesn't exist
      /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/angular/node_modules doesn't exist or is not a directory
      /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/node_modules doesn't exist or is not a directory
      /Users/yluteij/Code/SwiperBugReproduce/node_modules/node_modules doesn't exist or is not a directory
      /Users/yluteij/Code/node_modules doesn't exist or is not a directory
      /Users/yluteij/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/yluteij/Code/SwiperBugReproduce/node_modules
        using description file: /Users/yluteij/Code/SwiperBugReproduce/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/yluteij/Code/SwiperBugReproduce/package.json (relative path: ./node_modules/swiper_angular)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.ts doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.tsx doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.js doesn't exist
            as directory
              /Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular doesn't exist
[/Users/yluteij/Code/SwiperBugReproduce/swiper_angular]
[/Users/yluteij/Code/SwiperBugReproduce/swiper_angular.ts]
[/Users/yluteij/Code/SwiperBugReproduce/swiper_angular.tsx]
[/Users/yluteij/Code/SwiperBugReproduce/swiper_angular.mjs]
[/Users/yluteij/Code/SwiperBugReproduce/swiper_angular.js]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/angular/node_modules]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper/node_modules]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/node_modules]
[/Users/yluteij/Code/node_modules]
[/Users/yluteij/node_modules]
[/Users/node_modules]
[/node_modules]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.ts]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.tsx]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.mjs]
[/Users/yluteij/Code/SwiperBugReproduce/node_modules/swiper_angular.js]
 @ ./node_modules/swiper/angular/swiper_angular.ngfactory.js 8:0-37 10:36-51 10:384-399 10:401-416 31:239-257 32:59-77
 @ ./src/app/app.component.ngfactory.js
 @ ./src/app/app.module.ngfactory.js
 @ ./src/main.ts
 @ multi ./src/main.ts

Error 2: When enableIvy is removed (thus enableIvy defaults to true)
Compiling swiper_angular : module as esm5
Warning: Invalid constructor parameter decorator in /__w/12/s/node_modules/swiper/angular/fesm2015/swiper_angular.js:
 () => [
    { type: TemplateRef }
]
Error: getInternalNameOfClass() called on a non-ES5 class: expected SwiperSlideDirective to have an inner class declaration
    at Esm5ReflectionHost.getInternalNameOfClass (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/host/esm5_host.js:88:23)
    at DelegatingReflectionHost.getInternalNameOfClass (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/host/delegating_host.js:89:34)
    at extractDirectiveMetadata (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/annotations/src/directive.js:237:69)
    at DirectiveDecoratorHandler.analyze (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/annotations/src/directive.js:80:35)
    at NgccTraitCompiler.TraitCompiler.analyzeTrait (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:345:40)
    at analyze (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:297:58)
    at _loop_1 (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:319:21)
    at NgccTraitCompiler.TraitCompiler.analyzeClass (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:325:35)
    at NgccTraitCompiler.analyzeFile (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/analysis/ngcc_trait_compiler.js:47:26)
    at DecorationAnalyzer.analyzeProgram (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:134:39)
An unhandled exception occurred: NGCC failed.

Hi everyone, i've been working on this issue and I resolved it doing this in tsconfig.ts
"compilerOptions": {
  "baseUrl": "./",
    "paths": {
      "swiper_angular": ["../node_modules/swiper/angular"]
    }
}

Note the "../" in "swiper_angular": ["../node_modules/swiper/angular"], this is required cause that path is relative to the baseUrl, and node_modules is out of "./".
Hope it helps

@lechediaz for me "swiper_angular" path worked only without ../. Angular v8

Hello guys!
Same error here, in angular 7. "swiper_angular": ["../node_modules/swiper/angular"] didn't worked for me =/

Related issue, after updating swiper from 6 to 7, Jest fails to test
I do not have any problems with serve or build
 FAIL   deals  apps/deals/src/app/pages/deal/deal-page.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'swiper_angular' from 'src/app/pages/deal/deal-page.component.spec.ts'

       9 | import { MarkdownModule } from 'ngx-markdown';
      10 | import { EventReplayer } from 'preboot';
    > 11 | import { SwiperModule } from 'swiper/angular';
         | ^
      12 |
      13 | import { GeneralHelper } from<EMAIL_ADDRESS>      14 | import * as routerActions from<EMAIL_ADDRESS>
      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (src/app/pages/deal/deal-page.component.spec.ts:11:1)

Related issue, after updating swiper from 6 to 7, Jest fails to test
I do not have any problems with serve or build
In Swiper 6, i do not have any problems
 FAIL   deals  apps/deals/src/app/pages/deal/deal-page.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'swiper_angular' from 'src/app/pages/deal/deal-page.component.spec.ts'

       9 | import { MarkdownModule } from 'ngx-markdown';
      10 | import { EventReplayer } from 'preboot';
    > 11 | import { SwiperModule } from 'swiper/angular';
         | ^
      12 |
      13 | import { GeneralHelper } from<EMAIL_ADDRESS>      14 | import * as routerActions from<EMAIL_ADDRESS>
      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (src/app/pages/deal/deal-page.component.spec.ts:11:1)

Same issue here.

Related issue, after updating swiper from 6 to 7, Jest fails to test I do not have any problems with serve or build In Swiper 6, i do not have any problems
 FAIL   deals  apps/deals/src/app/pages/deal/deal-page.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'swiper_angular' from 'src/app/pages/deal/deal-page.component.spec.ts'

       9 | import { MarkdownModule } from 'ngx-markdown';
      10 | import { EventReplayer } from 'preboot';
    > 11 | import { SwiperModule } from 'swiper/angular';
         | ^
      12 |
      13 | import { GeneralHelper } from<EMAIL_ADDRESS>      14 | import * as routerActions from<EMAIL_ADDRESS>
      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (src/app/pages/deal/deal-page.component.spec.ts:11:1)

Can you share repo? So this error happens only in testing, while build, serve and prod build works fine?

Yes, only while testing, building, serving works fine
i can try and share a repo at the end of next week, if really needed.

Related issue, after updating swiper from 6 to 7, Jest fails to test I do not have any problems with serve or build In Swiper 6, i do not have any problems
 FAIL   deals  apps/deals/src/app/pages/deal/deal-page.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'swiper_angular' from 'src/app/pages/deal/deal-page.component.spec.ts'

       9 | import { MarkdownModule } from 'ngx-markdown';
      10 | import { EventReplayer } from 'preboot';
    > 11 | import { SwiperModule } from 'swiper/angular';
         | ^
      12 |
      13 | import { GeneralHelper } from<EMAIL_ADDRESS>      14 | import * as routerActions from<EMAIL_ADDRESS>
      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (src/app/pages/deal/deal-page.component.spec.ts:11:1)

@BeckmannM @rickvandermeij-aanzee Can you share repo? So this error happens only in testing, while build, serve and prod build works fine?

Yes, only while testing.
I can provide a repo at the end if next week, if its really necessary?

Same error as above, except for swiper/react using latest Jest.

Same error as above, except for swiper/react using latest Jest. I am able to build, serve, and lint without error, just fails in jest testing:
Test suite failed to run

    Cannot find module 'swiper/react' from 'src/components/VideoGallery/VideoGallery.component.tsx'

Was able to resolve this for myself.
in tsconfig.json:
{
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "swiper/react": ["../node_modules/swiper/react"],
    },
}

and where I am importing Swiper and the css:
import { Swiper, SwiperSlide } from "swiper/react";
import "swiper/swiper-bundle.min.css";

Same error as above, except for swiper/react using latest Jest. I am able to build, serve, and lint without error, just fails in jest testing:
Test suite failed to run

    Cannot find module 'swiper/react' from 'src/components/VideoGallery/VideoGallery.component.tsx'

My workaround for tests was to import directly from node_modules directory.  Example:
import { SwiperSlide } from '../../../node_modules/swiper/react'

Can confirm also happening with vuejs vue-test-utils/vue-jest.

hello everybody!
I get worked solution with latest version of Swiper (8.0.7 for now)
to fix tests, i update moduleNameMapper and transformIgnorePatterns in jest.config.js
{
  ...,
  moduleNameMapper: {
    swiper_angular: "<rootDir>/node_modules/swiper",
  },
  transformIgnorePatterns: [
    `node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))`,
  ],
}

i create repo for this, so you can check it here: https://github.com/olegshilov/swiper-angular-jest
and successful tests job:  https://github.com/olegshilov/swiper-angular-jest/actions/runs/2075808546

@dusiromulo did you manage to solve the problem? I'm having the exact same issue.
@rickvandermeij-aanzee could you solve this issue?

I get the same error than @rickvandermeij-aanzee:
FAIL   default-store  apps/default-store/src/app/app.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'swiper_angular' from '../../libs/shared/src/lib/shared.module.ts'

    Require stack:
      C:/Users/RamirE2/projects/frontend/libs/shared/src/lib/shared.module.ts
      C:/Users/RamirE2/projects/frontend/libs/shared/src/index.ts
      src/app/app.component.ts
      src/app/app.component.spec.ts

      4 | import { MatSnackBarModule } from '@angular/material/snack-bar';
      5 | import { MatSelectModule } from '@angular/material/select';
    > 6 | import { SwiperModule } from 'swiper/angular';
        | ^
      7 | import { RouterModule } from '@angular/router';
      8 | import { ErrorComponent } from './error/error.component';
      9 | import { SoldtoModalComponent } from './soldto-modal/soldto-modal.component';

      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (../../libs/shared/src/lib/shared.module.ts:6:1)

And when I apply the solution provided by @dusiromulo:
jest.config.js:
moduleNameMapper: { '^swiper_angular$': '<rootDir>../../node_modules/swiper/angular', }

I get:
FAIL   default-store  apps/default-store/src/app/app.component.spec.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    C:\Users\RamirE2\projects\frontend\node_modules\swiper\swiper.esm.js:13
    export { default as Swiper, default } from './core/core.js';
    ^^^^^^

    SyntaxError: Unexpected token 'export'

      at Runtime.createScriptFromCode (../../node_modules/jest-runtime/build/index.js:1728:14)
      at ../../node_modules/swiper/angular/bundles/swiper_angular.umd.js:2:139
      at Object.<anonymous> (../../node_modules/swiper/angular/bundles/swiper_angular.umd.js:5:2)

Thank you very much.

I've been digging deep and have a couple of findings:

It turns out enableIvy was set to false for our project (in the angularCompilerOptions in tsconfig.json). This triggers the error as mentioned before (even more verbose). You can see it reproduced in this repository: https://github.com/yoeran/swiper-reproduce-issue. Run npm run build to see the error (I'll add a snippet at the bottom of this comment, called "Error with enableIvy set to false")
After removing the enableIvy:false property from our tsconfig.json (default of enableIvy is true). We no longer have the error, however, we do get another error when building the app. This I have not been able to reproduce in an isolated repository. I'll add this error to this comment as well.

I did find a workaround, which meant installing<EMAIL_ADDRESS>and<EMAIL_ADDRESS>This works fine for our current status. However it would be nice to be able to just use swiper and not the redundant (deprecated?) ngx-swiper-wrapper.
Error 1: When enableIvy is set to false (see linked repo to reproduce this)
ERROR in ./node_modules/swiper/angular/swiper_angular.ngfactory.js
Module not found: Error: Can't resolve 'swiper_angular' in '/Users/username/Code/SwiperBugReproduce/node_modules/swiper/angular'
resolve 'swiper_angular' in '/Users/username/Code/SwiperBugReproduce/node_modules/swiper/angular'
  Parsed request is a module
  using description file: /Users/username/Code/SwiperBugReproduce/node_modules/swiper/angular/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      looking for modules in /Users/username/Code/SwiperBugReproduce
        using description file: /Users/username/Code/SwiperBugReproduce/package.json (relative path: .)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/username/Code/SwiperBugReproduce/package.json (relative path: ./swiper_angular)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/swiper_angular doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/swiper_angular.ts doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/swiper_angular.tsx doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/swiper_angular.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/swiper_angular.js doesn't exist
            as directory
              /Users/username/Code/SwiperBugReproduce/swiper_angular doesn't exist
      /Users/username/Code/SwiperBugReproduce/node_modules/swiper/angular/node_modules doesn't exist or is not a directory
      /Users/username/Code/SwiperBugReproduce/node_modules/swiper/node_modules doesn't exist or is not a directory
      /Users/username/Code/SwiperBugReproduce/node_modules/node_modules doesn't exist or is not a directory
      /Users/username/Code/node_modules doesn't exist or is not a directory
      /Users/username/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/username/Code/SwiperBugReproduce/node_modules
        using description file: /Users/username/Code/SwiperBugReproduce/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/username/Code/SwiperBugReproduce/package.json (relative path: ./node_modules/swiper_angular)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.ts doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.tsx doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.js doesn't exist
            as directory
              /Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular doesn't exist
[/Users/username/Code/SwiperBugReproduce/swiper_angular]
[/Users/username/Code/SwiperBugReproduce/swiper_angular.ts]
[/Users/username/Code/SwiperBugReproduce/swiper_angular.tsx]
[/Users/username/Code/SwiperBugReproduce/swiper_angular.mjs]
[/Users/username/Code/SwiperBugReproduce/swiper_angular.js]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper/angular/node_modules]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper/node_modules]
[/Users/username/Code/SwiperBugReproduce/node_modules/node_modules]
[/Users/username/Code/node_modules]
[/Users/username/node_modules]
[/Users/node_modules]
[/node_modules]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.ts]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.tsx]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.mjs]
[/Users/username/Code/SwiperBugReproduce/node_modules/swiper_angular.js]
 @ ./node_modules/swiper/angular/swiper_angular.ngfactory.js 8:0-37 10:36-51 10:384-399 10:401-416 31:239-257 32:59-77
 @ ./src/app/app.component.ngfactory.js
 @ ./src/app/app.module.ngfactory.js
 @ ./src/main.ts
 @ multi ./src/main.ts

Error 2: When enableIvy is removed (thus enableIvy defaults to true)
Compiling swiper_angular : module as esm5
Warning: Invalid constructor parameter decorator in /__w/12/s/node_modules/swiper/angular/fesm2015/swiper_angular.js:
 () => [
    { type: TemplateRef }
]
Error: getInternalNameOfClass() called on a non-ES5 class: expected SwiperSlideDirective to have an inner class declaration
    at Esm5ReflectionHost.getInternalNameOfClass (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/host/esm5_host.js:88:23)
    at DelegatingReflectionHost.getInternalNameOfClass (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/host/delegating_host.js:89:34)
    at extractDirectiveMetadata (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/annotations/src/directive.js:237:69)
    at DirectiveDecoratorHandler.analyze (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/annotations/src/directive.js:80:35)
    at NgccTraitCompiler.TraitCompiler.analyzeTrait (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:345:40)
    at analyze (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:297:58)
    at _loop_1 (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:319:21)
    at NgccTraitCompiler.TraitCompiler.analyzeClass (/__w/12/s/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:325:35)
    at NgccTraitCompiler.analyzeFile (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/analysis/ngcc_trait_compiler.js:47:26)
    at DecorationAnalyzer.analyzeProgram (/__w/12/s/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:134:39)
An unhandled exception occurred: NGCC failed.

Yes, it works now!
Thanks @olegshilov! The key part was the option inside jest.config.js:
transformIgnorePatterns: [     'node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))\', ]

I also can't get it to work with Jest. I have made a repo reproducing my setup in the hopes that someone can help.
https://github.com/snowfrogdev/swiper-angular-nx-jest

I was having a similar problem and solved it adding these lines to jest.config
 moduleNameMapper: {
    '^swiper_angular$': 'node_modules/swiper/angular/bundles/swiper_angular.umd.js',
    },
  transformIgnorePatterns: ['node_modules/(?!swiper|ssr-window|dom7)'],

and downgrading swiper from 8.1.4 to 7.4.1
Hope this can help someone else :)

I was having a similar problem and solved it adding these lines to jest.config
 moduleNameMapper: {
    '^swiper_angular$': 'node_modules/swiper/angular/bundles/swiper_angular.umd.js',
    },
  transformIgnorePatterns: ['node_modules/(?!swiper|ssr-window|dom7)'],

and downgrading swiper from 8.1.4 to 7.4.1
Hope this can help someone else :)

try
moduleNameMapper: {
    swiper_angular: 'node_modules/swiper',
  },
  transformIgnorePatterns: [
    `node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))`,
  ],

with swiper 8.

This does not work for me. This works intead:
moduleNameMapper: {
    swiper_angular: 'node_modules/swiper/angular/esm2020/swiper_angular.mjs',
},
transformIgnorePatterns: [
  `node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))`,
],

I can't get this to work. If I add
moduleNameMapper: {
    swiper_angular: 'node_modules/swiper',
  },
  transformIgnorePatterns: [
    `node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))`,
  ],

I get TypeError: Cannot read properties of undefined (reading 'ngModule')

Anyone got any ideas?

@nevius please share reproduction repository

I can't get this to work. If I add
moduleNameMapper: {
    swiper_angular: 'node_modules/swiper',
  },
  transformIgnorePatterns: [
    `node_modules/(?!(@angular|@testing-library|swiper|ssr-window|dom7))`,
  ],

I get TypeError: Cannot read properties of undefined (reading 'ngModule')

Anyone got any ideas?

/* eslint-disable */
// Modules throwing error "Jest encountered an unexpected token"
const esModules = ['@angular', 'tslib', 'rxjs', 'swiper'];

export default {
  extensionsToTreatAsEsm: ['.ts'],
  moduleFileExtensions: ['ts', 'html', 'js', 'json', 'mjs'],
  displayName: 'xxxx',
  preset: '../../jest.preset.js',
  setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
  globals: {
    'ts-jest': {
      tsconfig: '<rootDir>/tsconfig.spec.json',
      stringifyContentPathRegex: '\\.(html|svg)$',
      useESM: true,
    },
  },
  coverageDirectory: '../../coverage/apps/xxxx',
  transform: {
    '^.+\\.(ts|mjs|js|html)$': 'jest-preset-angular',
  },
  moduleNameMapper: {
    swiper_angular: 'node_modules/swiper/angular/esm2020/swiper_angular.mjs',
  },
  transformIgnorePatterns: [
    //'node_modules/(?!.*\\.mjs$)',
    `<rootDir>/node_modules/(?!.*\\.mjs$|${esModules.join('|')})`,
  ],
  snapshotSerializers: [
    'jest-preset-angular/build/serializers/no-ng-attributes',
    'jest-preset-angular/build/serializers/ng-snapshot',
    'jest-preset-angular/build/serializers/html-comment',
  ],
};

This worked well for me.

I'm using NX (workspaces). Can be related with it?

I have a fix for this. Add this task to your postinstall (package.json):
"postinstall": "cp -R ./node_modules/swiper/angular ./node_modules/swiper_angular"

New Swiper v9 doesn't have Angular components anymore, it is recommended to use new Swiper Web Components instead.


Provide .MSIX installation packages in /releases.

What feature or improvement do you think would benefit Files?
As https://github.com/microsoft/winget-pkgs/issues/150390#issuecomment-2068318185 demonstrates, these are technically available for the stable version, but incredibly difficult to locate. That should be remediated when that issue is closed, but it doesn't apply to https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273528233, for which solely an interactive .AppInstaller file is provided.
Requirements
I don't quite understand the purpose of this section, but there are no evident dependencies.
Files Version
https://github.com/files-community/Files/releases/tag/v3.6 per https://github.com/files-community/Files/releases/latest
Comments
https://github.com/PolyMC/PolyMC/issues/1601#issue-1877941253 provides additional rationale.

Thanks for the feedback, They already have a URL for both stable and preview and only need the version number updated. The issue I had wasn't with the URL and the current issue with adding it is likely on Winget side https://github.com/microsoft/winget-pkgs/pull/150504#issuecomment-2271593794

We don’t offer standalone MSIX packages because they require specific dependencies to be installed beforehand, and we can’t provide the support needed for any confusion this might cause. However, you can access the MSIX file for the preview version here
https://cdn.files.community/files/preview/Files.Package_<IP_ADDRESS>_Preview_Test/Files.Package_<IP_ADDRESS>_x64_arm64_Preview.msixbundle.

They have both URLs for offline installs and Winget can install the dependencies. Right now there an issue with Winget installing them https://github.com/microsoft/winget-pkgs/pull/150504#issuecomment-2271593794 last time it was install VClibs

There has only been one case of the issue there having and it was report by the user it was on there side https://github.com/files-community/Files/issues/15162

https://github.com/files-community/Files/issues/15973#issuecomment-2273672086

@Josh65-2201, so you would suggest that I revert https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273660318, I expect?

I assume you mean not to use https://files.community/appinstallers/Files.preview.appinstaller, if so yes.
When there made we can probably have the files community bot update the URL when there a new update for that version

https://github.com/files-community/Files/issues/15973#issuecomment-2273691466

@Josh65-2201, that's not what I meant. I should have been more clear by not using a double-negative. To rephrase: despite https://github.com/files-community/Files/issues/15973#issuecomment-2273648537, do you suggest that I use the MSIX package you've linked as the installer URI for the request? If so, why?

App installers files don't work according to them https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273528233 and the one I link is the same as format as stable is working.
The URL I gave is also is what used everywhere else and will be staying, it was discussed at some point that preview may get it own separate installer like stable one and the app installer URL won't be there if it happens

@RokeJulianLockhart Files is now available to download on Winget


Update Unity Asset store version

The code that is available on the Unity Asset Store was last updated in October. There's several things that can are fixed since then such as #57

:( i know thats why i made it so you can update from the preferences... I'm downloading a copy of 4.x right now ... will publish an update none the less.

Just tried the "Force update" button in a fresh project and it doesn't actually update the plugin.

Did you get a notification of a new version? Was there any errors in the log file?
I just tested locally, the only issue i had was that i had to manually refresh the CS file in unity for it to recognize the file change.

I have a slight fix to having to refresh in 2.42 (which ill be uploading once I'm finished my pass on it today)

Updated plugin to latest (https://github.com/dotBunny/VSCode/commit/e60b22dcb8e56505f05974a647b65fb2fb305498)
Turned on "Output Messages to Console" and got this when trying "Force Update"
[VSCode] Error getting response stream (Write: The authentication or decryption has failed.): SendFailure
UnityEngine.Debug:Log(Object)
dotBunny.Unity.VSCode:CheckForUpdate() (at Assets/VSCode/Plugins/Editor/VSCode.cs:331)
dotBunny.Unity.VSCode:VSCodePreferencesItem() (at Assets/VSCode/Plugins/Editor/VSCode.cs:589)
UnityEditor.HostView:OnGUI()

and
ArgumentOutOfRangeException: startIndex + length > this.length
Parameter name: length
System.String.Substring (Int32 startIndex, Int32 length) (at /Users/builduser/buildslave/mono-runtime-and-classlibs/build/mcs/class/corlib/System/String.cs:356)
dotBunny.Unity.VSCode.CheckForUpdate () (at Assets/VSCode/Plugins/Editor/VSCode.cs:343)
dotBunny.Unity.VSCode.VSCodePreferencesItem () (at Assets/VSCode/Plugins/Editor/VSCode.cs:589)
UnityEditor.PreferencesWindow.OnGUI () (at C:/buildslave/unity/build/Editor/Mono/PreferencesWindow/PreferencesWindow.cs:288)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono-runtime-and-classlibs/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono-runtime-and-classlibs/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:232)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at /Users/builduser/buildslave/mono-runtime-and-classlibs/build/mcs/class/corlib/System.Reflection/MethodBase.cs:115)
UnityEditor.HostView.Invoke (System.String methodName, System.Object obj) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:187)
UnityEditor.HostView.Invoke (System.String methodName) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:180)
UnityEditor.HostView.OnGUI () (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:76)

The top message says that the HTTPS was not able to secure itself ... that seems really strange.
 When the first thing happens I should have stopped the update function (thats fixed in the upcoming update)

Submitted update for review by UAS

Thanks!


Add impressum

User Story
As a:
USer
I want:
Information about legal information from geli.
so that:
I know who is responsible for geli
Acceptance criteria:

[ ] impressum added
[ ] availability in every supported language

Additional info:

#550


Fix/changed inline @file

Description
I noticed an open issue and found the "bug". Not sure if it was intentional to reset the entire input for changing one file. This fix allows for no resetting when changing files.  Here's the issue for reference #2310
Checklist

[x] The base branch of this PR is dev, rather than main
[ ] The relevant docs, if any, have been updated or created

Screenshots

Testing
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change. ]

thanks!


Component: Twitter Embed block (informs DS)

Scope & build twitter embed block (@todo link to issue in design-system & ca-design-system-gutenberg-blocks)

Demonstrate side by side 2-col layout with News Block + Twitter block
Or build as a pattern

We are using the default Twitter embed block.
It needs new styling.
Not sure we can edit the number of posts returned but can look into that.

Updates
Trying to include "tweet-limit" to default WP embed block. It's not accepting any url params (yet)
Note: It's using oembed.

Alternatively, does regular embed block work.

https://wordpress.org/support/article/embeds/

Don't need the Twitter block or the Embed block. The configuration options are available if you edit the markup.
Using the custom HTML Block with this code works to configure the twitter.
Tweets by BCCInfo_dca

Updated with the final account & reviewed by Adam.
Just needs tweets now.
Assigning back to @wrendo for validating that DCC will add an initial tweet so it appears on the homepage. It will be empty for now.
(Dev site uses another Twitter account for testing that timeline works.)


Update README with instructions to create React bundle

I actually noticed this is in the pre_build.sh script. It did not work for me, though. Time allowing maybe this PR should fix that instead.


Issues with saving payments info: 2 copies saved, not saved as default

Environment Details
Spartacus: latest develop
Browser: Chrome 73.0.3683.86
OS: Mac Os
Happens on: http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/electronics-spa/en/USD/
Steps to Reproduce
Add items to cart
Proceed to checkout
During checkout, click on "Set as default" for payments
Go to MyAccount -> Payment Details -> There are 2 copies of that payment info
Add more items to cart
Proceed to checkout
During checkout, add a new payment. Click on "Set as default"
Go to MyAccount -> Payment Details -> The new payment is NOT set as default

I can't reproduce first issue, second confirmed

Mapping I got on https://dev-com-19.accdemo.b2c.ydev.hybris.com:9002/rest/v2/electronics-spa/users/current/carts/00000246/payment/sop/request?responseUrl=sampleUrl&lang=en&curr=USD
  "entry" : [ {
         "key" : "hybris_billTo_country",
         "value" : "billTo_country"
      }, {
         "key" : "hybris_card_expiration_year",
         "value" : "card_expirationYear"
      }, {
         "key" : "hybris_combined_expiry_date",
         "value" : "false"
      }, {
         "key" : "hybris_sop_decision",
         "value" : "decision"
      }, {
         "key" : "hybris_card_expiry_date",
         "value" : "card_expirationDate"
      }, {
         "key" : "hybris_card_expiration_month",
         "value" : "card_expirationMonth"
      }, {
         "key" : "hybris_billTo_street1",
         "value" : "billTo_street1"
      }, {
         "key" : "hybris_sop_card_number",
         "value" : "card_accountNumber"
      }, {
         "key" : "hybris_sop_uses_public_signature",
         "value" : "true"
      }, {
         "key" : "hybris_card_cvn",
         "value" : "card_cvNumber"
      }, {
         "key" : "hybris_billTo_lastname",
         "value" : "billTo_lastName"
      }, {
         "key" : "hybris_sop_subscriptionID",
         "value" : "paySubscriptionCreateReply_subscriptionID"
      }, {
         "key" : "hybris_billTo_firstname",
         "value" : "billTo_firstName"
      }, {
         "key" : "hybris_sop_amount",
         "value" : "amount"
      }, {
         "key" : "hybris_sop_currency",
         "value" : ""
      }, {
         "key" : "hybris_card_type",
         "value" : "card_cardType"
      }, {
         "key" : "hybris_sop_reason_code",
         "value" : "reasonCode"
      }, {
         "key" : "hybris_sop_public_signature",
         "value" : "paySubscriptionCreateReply_subscriptionIDPublicSignature"
      }, {
         "key" : "hybris_separator_expiry_date",
         "value" : ""
      }, {
         "key" : "hybris_account_holder_name",
         "value" : "mockup_account_holder"
      }, {
         "key" : "hybris_card_number",
         "value" : "card_accountNumber"
      }, {
         "key" : "hybris_billTo_phone_number",
         "value" : ""
      }, {
         "key" : "hybris_billTo_city",
         "value" : "billTo_city"
      }, {
         "key" : "hybris_billTo_region",
         "value" : ""
      }, {
         "key" : "hybris_billTo_postalcode",
         "value" : "billTo_postalCode"
      } ]

There is no default payment position, I don't know how to apply it to request.

Looks like OCC can't do default payment because of use of SOP request, I just saw a chat between OCC guys. so using a second request is all we can do for the moment.

There is defaultPayment flag in SopPaymentDetailsWsDTO. So, when SPA sends the second request /{cartId}/payment/sop/response, this flag is passed to backend.
I tested this ticket on my local. The create payment details needs to send 2 requests, which may take several seconds to finish. So, I click the button, and I didn't see the response, then I click again. In the "My account", I can see 2 copies of the payment info. So, I think, we should disable the button until the requests complete to prevent the double click.
For the second issue, in occ-checkout-payment.adapter.ts, add this line (line 65):
fromPaymentProvider['defaultPayment'] =paymentDetails.defaultPayment;

after this fromPaymentProvider['savePaymentInfo'] = true;

Tested on dev19. Works now.


Add Wuerstchen Model

What does this PR do?
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.

#1


Set metrics port in deployment to default for openshift-routes

See default in options - https://github.com/cert-manager/openshift-routes/blob/d7a6e49a1f89a3aee36b59638bdd5f6164b4a74a/internal/cmd/app/options/options.go#L127C19-L127C23

Thanks for catching this mismatch!
/lgtm


option to fill missing forecasts with other values

We need a way to penalize missing forecasts to fully support trials and other operational evaluations.
One implementation could look like this:

Reports get a parameter like missing_forecasts = 'ignore'|'clearsky'|0. Needs to be exposed on dashboard too.
missing_forecasts is passed to preprocessing.process_forecast_observations, along with the report start and end.
Before the call the resample_and_align, if missing_forecasts != 'ignore': fx_series_filled = fill_values(forecast, fx_series, missing_forecasts, start, end). forecast metadata, start, end determines the full DatetimeIndex. If we don't want to support fill with clearsky then this could just be a call to reindex and fillna. Repeat for reference forecast. Store some information about number of filled points in validation_results dictionary.
resample_and_align remains unchanged (I think) and excludes forecast values for which observations are missing/flagged.

Seems too doable so I'm afraid I'm missing something.

Probabilistic and event forecasts will need some kind of fill too.
For event forecasts, I suggest fill with all 0/False or 1/True (depending on the data type where the fill occurs). Which value to choose might depend on the situation. For rare events you might want to fill with 1 for a bigger missing penalty.
The strategy for probabilistic forecasts might depend on exactly what you're evaluating.
For a ProbabilisticForecast(axis='x'), maybe 100% probability in the smallest variable value (presumably but not necessarily 0); and for a ProbabilisticForecast(axis='y'), maybe 0 for all percentiles.
For a ProbabilisticForecastConstantValue(axis='x'), maybe always 0%; and for ProbabilisticForecastConstantValue(axis='y') always 0.

@awig

@wholmgren
Working on this now. I think the plan for the deterministic forecasts sounds good. Event forecasts seems pretty straightforward as well. I'm not sure I understand the proposition on the probabilistic forecasts.
Some questions/thoughts:

Order of Operations I'm thinking applying the forecast fillin after the observation validation apply_validation. I don't think it should matter either way but let me know if you have thoughts.

Reference Forecasts If there is a reference, I assume we should apply the same fill method? Should any logic be done to make sure they are filled for the same timestamps with the same values but

What fill types to support let me know how much you want to stick with pandas terminology with name and action:

'fill_forward' (pandas ffill/pad) - propagate forward in time the last valid value until next valid value
'back_fill' (pandas bfill/backfill) - fill backward in time the next valid value until last valid value
'ignore' - drop missing values, similar to exclude used for quality flags right now
'clearsky' - fill with corresponding clearsky from pvlib
 (string or float) - fill all missing values with static numeric value (typically 0)

I can focus on all the others and skip clearsky to the end and decide to incorporate it in case   there are problems.

EventForecast why not let the same fill methods apply except clearsky and restrict numeric values to only be 0 or 1?

ProbabilisticForecast/ProbabilisticForecastConstantValue not following on your ideas. I would think apply the same as above, except clearsky. I'm certain I'm missing something.

Work plan

deterministic
event
probabilistic

Order of Operations I'm thinking applying the forecast fillin after the observation validation apply_validation. I don't think it should matter either way but let me know if you have thoughts.

I agree that I don't think it matters.

Reference Forecasts If there is a reference, I assume we should apply the same fill method? Should any logic be done to make sure they are filled for the same timestamps with the same values but

Yeah, I think it makes sense to apply the same fill method to the reference forecast. Maybe there are cases where you wouldn't want to do that, but I don't think we can make it an option without a lot of work.

What fill types to support let me know how much you want to stick with pandas terminology with name and action:
'fill_forward' (pandas ffill/pad) - propagate forward in time the last valid value until next valid value
'back_fill' (pandas bfill/backfill) - fill backward in time the next valid value until last valid value
'ignore' - drop missing values, similar to exclude used for quality flags right now
'clearsky' - fill with corresponding clearsky from pvlib
(string or float) - fill all missing values with static numeric value (typically 0)

I can focus on all the others and skip clearsky to the end and decide to incorporate it in case there are problems.

I don't have much preference for 'ffillvsfill_forward` at this layer of the code. I don't think backfill makes sense in a forecasting scenario. Perhaps 'ignore' should be 'drop' for clarity? Let's skip clear sky for now, but make sure the design is extensible enough to support it later.

EventForecast why not let the same fill methods apply except clearsky and restrict numeric values to only be 0 or 1?

That's fine with me.

ProbabilisticForecast/ProbabilisticForecastConstantValue not following on your ideas. I would think apply the same as above, except clearsky. I'm certain I'm missing something.

Yes for fill forward, ignore/drop. For fill with float for ProbabilisticForecastConstantValue, it's the same at a low level (it's just a float), but the meaning of the float is different depending on the axis, so the defaults are up for debate. For ProbabilisticForecast you have to worry about filling one or more (or always all?) of the constituent ProbabilisticForecastConstantValue. One might argue that if any elements of a ProbabilisticForecast at a given time are missing then all elements at that time must be replaced. We could also just not support the fill with float option for probabilistic forecast types.

Perhaps 'ignore' should be 'drop' for clarity?

Sounds good to me

so the defaults are up for debate.

I see, where should the defaults be set in metrics or in the reports?

One might argue that if any elements of a ProbabilisticForecast at a given time are missing then all elements at that time must be replaced.

I guess there could be another option for ProbabilisticForecast that would fill in between quantiles (say linear for simplicity between the closest quantiles). But that seems error prone and more difficult if multiple missing for multiple quantiles. But, that makes me think of other options.

average : I don't really like to but what about fill with average, obviously tailored to get certain statistical properties for normal distributions.

interpolation : maybe just linear or spline

What do you think would be useful and what kind of phenomenon are we targeting: short sporadic missing values or wanting to compare forecasts where one has large gaps compared to the other or just that the resolution of one forecast doesn't match the other?

where should the defaults be set in metrics or in the reports?

Good question. Maybe let's leave it for the reports or dashboard.
As for probabilistic forecasts, I am leaning more towards only allowing fill forward and drop. I had some similar thoughts to yours but thought it would be too much processing to explain to a user.

Great. I've started working on getting the fills working in their own function preprocessing.apply_fill first and then figure out where to check for the forecast type and integrate into preprocessing.process_forecast_observations.

Oh, and on the forward fill, if the data is missing prior to the start timestamp I was going to fill with the default. I'll try adding it to the report but we can replace it if desired.

Preference if missing_forecast in ReportParameters has a default or not? If so, whcih should it be?

@wholmgren Just want to confirm for drop for ProbabilisticForecast that we need to drop across "columns"/quantiles.  For now, the fill forward method should we do the same fill applies across "columns"/quantiles, right now i'm not doing this.  What do you think?

For drop, if any value in a ProbabilisticForecast is missing then all values should be dropped at that time. I think it should be safe to apply fill forward on a column by column basis.

For drop, if any value in a ProbabilisticForecast is missing then all values should be dropped at that time. I think it should be safe to apply fill forward on a column by column basis.

Sounds good. Thanks

Do you mind how if the PreprocessingResult for ProbabilisticForecast reports per ProbabilisticForecastConstantValue or just overall?  Right now I'm just working on reporting the overall total of fills/drops

It the input forecast type is ProbabilisticForecast then ok to report total
rather than separating by the constituent constant values.
On Thu, Jun 25, 2020 at 4:45 PM Adam Wigington<EMAIL_ADDRESS>wrote:

Do you mind how if the PreprocessingResult for ProbabilisticForecast
reports per ProbabilisticForecastConstantValue or just overall? Right now
I'm just working on reporting the overall total of fills/drops
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SolarArbiter/solarforecastarbiter-core/issues/423#issuecomment-649871275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBOERZDCFTITSSLJ7YF57TRYPORVANCNFSM4MRKKMJA
.


Inconsistent repos and versions

I kept noticing that in the current repo, which is the official one, it tagged as version 0.3.5. package.json reports the same version.
However, when I install this plugin with npm, it installs version 0.3.7. It turns out @charca has publishing permissions at npm, so the version we're installing is Charca/backgrid-paginator@master.
This is really confusing. The differential commits should have been merged in here, or the repo URL should have been updated at NPM, and either way, version 0.3.7 should be tagged.
What should we do? I'm willing to help, so if you're willing to give me contributor access in here or npm, I can sort things out to restore consistency across repos and package managers.

cc @charca

Hey @amenadiel, I've just updated the repo to match the version on my fork (that is currently published on npm), and pushed the tags to keep it consistent. New releases of the npm packages will be published from this repo going forward to avoid confusion. Sorry for the trouble there, totally my fault.


Complete branching steps for Rancher 2.9 for GKE Operator

Tasks

[x] change the rancher-version annotation to catalog.cattle.io/rancher-version: '>= 2.9.0-0 < 2.10.0-0' while adding charts to dev-v2.9 branch. We do this so we can add patches to a  particular Rancher minor version, in this case, it would be the Rancher 2.9 line.
[x] must have a new chart inside the rancher/charts repository that has a version 104.0.0+upX.Y.Z instead of 103.x.x+upX.Y.Z.
[ ] testing

PR's

[ ] https://github.com/rancher/charts/pull/3337/

Validated as fixed on build: v2.9-12467fadeb539d35a249702dc0933bd84a166433-head using fresh install setup and upgraded setup from 2.8.1 > 2.9-head
GKE operator p0 scenarios are passed and version installed is rancher-gke-operator:104.0.0+up1.3.0-rc1


need to quickly find the file that is being edited in Navigator/Project from SQL editor

Is your feature request related to a problem? Please describe.
From the SQL Editor, the "Show In" (Alt+shift+w) feature is missing comparing to Text/Java Editor in Eclipse.  It is important because we often need to find the right click on the file in the Project or Navigator  panel to perform tasks like "team", "copy" ...
Describe the solution you'd like
Right click menu contain "Show In" option,  in "Show In"  have Project, Navigator sub options.
Describe alternatives you've considered
manually search for files in the list.
Additional context
Please see standard Eclipse:

Link with editor option (Ctrl+Shift + ,) is already implemented for Database Navigator and Projects panel


Add generic glossary-like page structure

CAN's learn page has a glossary-like page structure which might be useful as a generic template. Specifically, a simple page with vertical navigation menu, where clicking each menu item would scroll to its corresponding section of the page.

We can implement this when someone asks for it.


Custom loss

Codecov Report

Merging #122 (9de56a8) into v0.4.0 (ddbe5a2) will decrease coverage by 0.43%.
The diff coverage is 30.13%.

@@            Coverage Diff             @@
##           v0.4.0     #122      +/-   ##
==========================================
- Coverage   90.41%   89.97%   -0.44%
==========================================
  Files          17       17
  Lines        2670     3692    +1022
==========================================
+ Hits         2414     3322     +908
- Misses        256      370     +114

Impacted Files
Coverage Δ

neurodiffeq/solvers.py
79.29% <30.13%> (-8.34%)
:arrow_down:

neurodiffeq/generators.py
95.75% <0.00%> (-0.29%)
:arrow_down:

neurodiffeq/networks.py
88.88% <0.00%> (+0.31%)
:arrow_up:

neurodiffeq/conditions.py
95.30% <0.00%> (+1.96%)
:arrow_up:

neurodiffeq/monitors.py
92.44% <0.00%> (+2.12%)
:arrow_up:

neurodiffeq/callbacks.py
97.88% <0.00%> (+4.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbe5a2...9de56a8. Read the comment docs.


Day Planner only check on daily notes.

Hi there!
I have one vault to manage my personal and work/projects life. Currently I'm separating a daily note for both of them...
on versions before v0.70 I had a command to display the planner on a custom note.
I would like to have this behaviour or some enhancement to select a custom note to check for the schedule. Or better, if I could add some metadata to different notes, so the planner automatically watch all those notes. That would be the best!!
Thanks!
I saw a linked issue

#200

I have periodic notes for my personal use, but also maintaining a different "daily" note for my work/project.
I cannot use only one daily note because privacy issues on the company I work, so i cannot sync that data...

The attach planner to current note was extremely useful.
I have several templates that have scripts like this:
<%*  app.commands.executeCommandById('obsidian-day-planner:app:link-day-planner-to-note') %>

The attach planner to current note was extremely useful. I have several templates that have scripts like this: <%* app.commands.executeCommandById('obsidian-day-planner:app:link-day-planner-to-note') %>

To clarify, Is there currently no way to create a template that automatically associates the "Day planner insert planner heading at cursor" with it?

How about making it work (at least the day timeline) on any note that has a day planner section?
How would this work for you guys?

@lukemt which note would show up in the timeline view when you left that note? whichever note was last viewed that had a day planner header in it? there is also the ability to go 'forward' and 'back' through the daily notes using navigation arrows above the timeline. What would those do?

@JosephBrooksbank Yes the last viewed note.
I think the navigation would need to be disabled.
Another question would be if the now-line should be visible when we don't know if it's today's note.
Finally, what about notifications?
Maybe a combination of what I suggested and a command would be ideal plus possibly a button in the timeline header to make the current note the day note

Hello, @makkuro-kuroe, please update and re-check. Make sure the Dataview plugin is installed. Now scheduled tasks are gathered all across the vault.


Block content not rendering

Version 0.5.0, ruby 2.6.3p62, Mac, iTerm
1] pry(main)> print TTY::Box.frame "Hello world!"
┌────────────┐
│Hello world!│
└────────────┘
=> nil
[2] pry(main)> print TTY::Box.frame do
[2] pry(main)*   "Hello world!"
[2] pry(main)* end
┌─┐
└─┘
=> nil

Hi Nigel,
Unfortunately, I don't think this is an issue with the gem. There is something weird going on with blocks and print call in Ruby. If you change your example from multiline block syntax to, single line, then it will work fine.
print TTY::Box.frame { "Hello World!" }
┌────────────┐
│Hello World!│
└────────────┘
=> nil

So you need to be mindful of this, as you have already realised in your second comment. Ruby is weird and wonderful like this. 😉

That is super weird. Perhaps you could update your example in the readme?


opscode-pushy-server 1.* and Chef-server >= 12.10 do not work oob

After install, you'll receive the following error anytime a pushy API is hit:
2016-11-09 18:21:19.923 [error] <0.279.0> Webmachine error at path "/organizations/delivery/pushy/node_states" : {throw,{error,{conn_failed,{error,closed}}},[{pushy_http_common,fetch_authenticated,2,[{file,"src/pushy_http_common.erl"},{line,44}]},{pushy_org,fetch_org_id,1,[{file,"src/pushy_org.erl"},{line,38}]},{pushy_object,fetch_org_id,1,[{file,"src/pushy_object.erl"},{line,45}]},{pushy_wm_base,verify_request_signature,2,[{file,"src/pushy_wm_base.erl"},{line,157}]},{pushy_wm_base,is_authorized,2,[{file,"src/pushy_wm_base.erl"},{line,135}]},{webmachine_resource,resource_call,3,[{file,"src/webmachine_..."},...]},...]}
This was caused by TLS and cipher suite changes on the Chef server, and pushy servers http client libraries can no longer make requests to the Chef server with the new defaults added via this commit:
https://github.com/chef/chef-server/commit/ec8a5e25646ef278f74c37adb0a3054bc256003d
To validate this was the problem, on a chef-server 12.10 machine I ensured push server failed ( knife node status returned a http status code 500, and pushy server logs showed the above)
I set the following in my chef-server.rb:
 nginx['ssl_protocols'] = "TLSv1 TLSv1.1 TLSv1.2"
nginx['ssl_ciphers'] = "ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-DSS-AES128-GCM-SHA256:kEDH+AESGCM:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA:ECDHE-ECDSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-DSS-AES128-SHA256:DHE-RSA-AES256-SHA256:DHE-DSS-AES256-SHA:DHE-RSA-AES256-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128-SHA:AES256-SHA:AES:CAMELLIA:DES-CBC3-SHA:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!PSK:!aECDH:!EDH-DSS-DES-CBC3-SHA:!EDH-RSA-DES-CBC3-SHA:!KRB5-DES-CBC3-SHA"
and reconfigured chef server.
knife node status now returns the correct results.

I apologize for any pain updating the cipher suite has caused. chef/chef-server/pull/1007 was merged yesterday addressed some compatibility with AWS Classic ELBs by adding AES256-GCM-SHA384 back into the cipher suite. It is possible this change will also address this issue by preventing the problem from arising, however this will need to be verified with either a version of chef-server from the current channel or the next release.

Also, it is possible limiting TLS to v1.2 in server may have been too restrictive for pushy with pushy's current configuration.
/cc @chef/server-team

@andy-dufour Thank you for reporting the issue. We will try reproducing this with push-jobs-server2, since issues with push-jobs-server1 will not be fixed.


Return Result<T, E> from trait methods

Currently, error handling is implemented the way it is in pgx, which is by panicing and catching the panic at the transaction boundary. This is good at the interface with postgres, but for a higher level API, using the standard rust Result method of error handling is generally more ergonomic. This because interfaces signal fallibility and it allows using the standard machinery for handling and converting errors.
struct HelloWorldFdw{ url: String }

impl ForeignDataWrapper for HelloWorldFdw {
    fn new(options: &HashMap<String, String>) -> Self {
        Self {
            url: require_option("url", options).unwrap()
        }
    }
}

Here, fn new is fallible, but nothing signals its fallibility to the casual reader or implementer.
require_option diverges, so the unwrap is safe (actually require_option could return String instead of Option<String>, because if it would be None, it would panic through report_error).
If new returned Result<Self, WrappersError>, this could be rewritten as, for example:
struct HelloWorldFdw{ url: String }

impl ForeignDataWrapper for HelloWorldFdw {
    fn new(options: &HashMap<String, String>) -> Result<Self, WrappersError> {
        Ok(Self {
            url: require_option("url", options)?
        })
    }
}

Where require_option() returns a Result<String, WrappersError>, with the error being a WrappersError::OptionNameNotFound(String), with the string representing the option name. It is now clear that fn new is fallible, and require_option is actually just options.get(<name>).ok_or(WrappersError::OptionNameNotFound(<name>))
Of course other errors could also be returned from new(). I imagine WrappersError to look something like:
enum WrappersError {
    OptionNameNotFound(String),
    ColumnNameNotFound(String),
    InvalidDataType(String),
    // ... etc
    Other(Box<dyn Error>),
}

impl WrappersError {
    fn error_code(&self) -> PgSqlErrorCode {
        match self {
            OptionNameNotFound(_) => PgSqlErrorCode::ERROR_CODE_FDW_OPTION_NAME_NOT_FOUND
        }
    }
}

impl Display for WrappersError{ /*...*/}

In FdwState, errors would be converted to the panic-y kind:
match Wrapper::new(options) {
    Err(e) => report_error(e.error_code(), &e.to_string()),
    Ok(wrapper) => wrapper,
}

I'd be happy to make a PR implementing this by the way.

Implemented in #144


Server-side access control is not updated when a new view is added

Describe the bug
In an application with access control (from start.vaadin.com), the server-side access control rules are not applied immediately when a new view is added. This leads to being redirected to /login if you try to navigate to a recently added public view if you are not logged in. The view can be accessed without being logged in after restarting the server.
Expected-behavior
Expected that the server-side access control settings are updated immediately when a new view is added.
Reproduction

Create an application on start.vaadin.com with access control for a /foo view and no access control for a/bar view.
Launch in dev mode
Copy views/bar.tsx into views/baz.tsx
Navigate to the new view from the new menu entry
Reload the page and observe that you're redirected to the login page.
Restart the server
Repeat steps 4 and 5 and observe that the view is still rendered after the reload

System Info
Vaadin 24.5.2

Probably worked in 24.4 by triggering a redeploy.

The key is getting RouteUtil.isRouteAllowed() behavior right.

An easy solution could be reading the json every time in dev mode.


Remove redundant time format

The dotted_short_date format has no dots and is only used in one place
so there's no point adding it to Time::FORMATS.

LGTM

+1


Custom Background Upload Issue

When the user upload an image, delete it, and upload the same picture again, it won't work.

Not a big bug. Closed


Use MySQL

Tests pass locally. I'm working on setting up Docker for development and Travis builds.

Looks good.
I'm going to go in and tweak all of the big integers to integers and fix travis.

LGTM


Implement basic active monitoring algorithm

These scripts will be residing in each vm , so this count variable tells us
the total number of requests processed by that particular vm.
On Nov 18, 2017 12:42 PM, "Anshul"<EMAIL_ADDRESS>wrote:

@AnshulMalik commented on this pull request.
In Monitor/1.py
https://github.com/kaushikSarma/VM-Load-balancing/pull/8#discussion_r151831782
:

@route('/stats',method = 'GET')
def process():

global count

Not these requests @rewanth1997 https://github.com/rewanth1997, this is
the monitoring request, we should count the requests sent to each vm at
load balancing site.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kaushikSarma/VM-Load-balancing/pull/8#pullrequestreview-77609919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVT-GlI_5ttH25lOjCcsnQVEA59mEz4gks5s3oNogaJpZM4Qh108
.

The stats requests, not the actual requests that clients are making, so the load balancer will be the one who will maintain this count.


Add 100% coverage to message_flags.js

Testing plan:
GIFs or screenshots:

These are really nice, @YashRE42!  After you address my one comment above, this LGTM.

I'm assuming you'll debug the CI failure.

Fixed the CI failure.

Can you reply to my inline comment?

I posted a couple quick questions about mocking patterns, but otherwise this lgtm.

@YashRE42 This is looking good!  I think if you can change the ui mock to be an override, this will be ready to merge.

Ended up removing the mock entirely and changed an earlier one to use override as well.

Merged, thanks @YashRE42!


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-extensions/eventing-writers
/assign knative-extensions/eventing-writers
Produced by: knative-extensions/knobots/actions/update-deps

/hold cancel
as #418 merged


"urls", "unused", "idents" are deprecated by cssnano

webpack + css-loader 0.16.0 makes cssnano print these warnings:
The unused option is deprecated. Please use options.discardUnused instead.
The urls option is deprecated. Please use options.normalizeUrl instead.
The idents option is deprecated. Please use options.mergeIdents instead.

This is a duplicate of https://github.com/webpack/css-loader/issues/126. I've already sent a PR updating the options. :smile:

Thanks @ben-eb!


[doc] Add topic load latency metrics documentation

Add topic_load_times
Move the managed ledger cache and connection metrics under the broker metrics section

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[ ] no-need-doc
(Please explain why)

[x] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

@codelipenghui would you like to invite an engineer to review this PR from the technical perspective? Then writers can review it from the technical writing perspective, thanks.
@momo-jun could you please help review this PR after the technical review? Thanks

@codelipenghui I've renamed your PR based on the PR Naming Guidelines, please follow it, thanks


Let upgrade this to support api too, instead of web only with the likes of jwt, passport, sanctum etc.

As long as you use Auth::attempt, the login will be captured, being Passport or Sanctum.


Support parsing categorical (dictionary-encoded) columns from ipc arrow format

Closes #7
This adds dependency on libarrow (conda install -c conda-forge=0.5.*).
The IPC parser API is changed to reflect new convention in mapd.  The schema and the payload is now in separate memory buffers.  The schema is expected to be in a CPU memory.  The payload is in GPU memory.
In addition, the buildscript is changed to pin libgdf_cffi version to libgdf version.

From the prior discussion in https://github.com/gpuopenanalytics/pygdf/issues/1, I am wondering it it would make packaging and testing much simpler to develop the Arrow GPU integration within the main Arrow codebase. Otherwise you may risk duplicating logic or missing other opportunities for code sharing (or generalizing the code that is already there in libarrow). Let me know how I can help -- I also have an NVIDIA graphics card and CUDA installed so I should be able to help with testing and debugging.

I think we are likely to contribute some of this work back to Arrow once it is settled, but right now we're still iterating on how the IPC handshake should look with MapD, and generally experimenting with changes up and down the stack.    Once the approach is a little more figured out, we can definitely move some of this to Arrow.

Makes sense. I've been following the commits both here and in MapD and it seems likely that there will soon be a need to share more code between MapD and pygdf, and one simple way would be as a leaf libarrow_gpu library. This also makes it easier for the rest of us to test Arrow CPU changes against your work to make sure that something doesn't get accidentally broken =) It would be great to see a community-standard Arrow-on-GPU solution for C and C++ users and to work together on maintaining shared build / packaging / CI.
Note that there is no problem at all with experimental development inside the Arrow codebase so long as you don't break the build on master. I would rather see you all earning karma in the project so that you can be voted in sooner as committers. I'm not going to delay merging Arrow patches so long as the build isn't broken and there is some consensus amongst yourselves that the changes look good.


Added INSTALLING.md for packagecloud

Adds some details around installing from packagecloud.  #1074 .

Thanks for this! I fixed a small typo, and turned an issue ref into a hyperlink.


add a new column ValenceElectrons  to data.csv

please add a column ValenceElectrons to data.csv.
so that the column stores  the number of valence electrons each element have.

you can calculate the number of valence electrons using the GroupBlock column which already is in data.csv :

Hello, i have added valenece Electron column in data.csv


Add vllm awq loading logic

Description
Adding vLLM awq load logic.
We use an environment variable to get the group size.  This is because within ipex-llm, we cannot get the quantization config.
1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

[ ] N/A
[ ] Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
[ ] Application test
[ ] Document test
[ ] ...

5. New dependencies

[ ] New Python dependencies
- Dependency1
- Dependency2
- ...
[ ] New Java/Scala dependencies and their license
- Dependency1 and license1
- Dependency2 and license2
- ...

https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/10592729621


Update ISSUE_TEMPLATE.md

Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@cody3337 There is no description in your Pull Request, and you have not signed your commit(s). Please read the contribution guide before submitting your work.
Also, I will close this as the change is not correct. The spelling is the correct spelling of the word. Your change changes it to the US variant. Please see the definition provided by Oxford Dictionary: https://en.oxforddictionaries.com/definition/behaviour
If you'd like to join our Slack community to see other areas where you could make an impacting change, please see the docs

Derek: close

Derek close

Derek add label: invalid

Thanks Burton


Make better Error notifications when usingen SomeOf()

I met the Error "AssertionError: Assertion Failed" and I could not really find out what went wrong, due to the nature of SomeOf.
Here are some exemplary Codes that will fail:
seq=[
 iaa.SomeOf((0,2)),[
      iaa.AdditiveGaussianNoise(loc=0,scale=(0.0,0.05*255),per_channel=0.5),
      iaa.Add((-10,10),per_channel=0.5),
      iaa.AddToHueAndSaturation((-20,20))]]

seq = iaa.Sequential(seq)

In my opinion it is hard to see why there is an error, cause the code can be exeucted correctly, till the last step.
seq=[
 iaa.SomeOf(2),[
      iaa.AdditiveGaussianNoise(loc=0,scale=(0.0,0.05*255),per_channel=0.5),
      iaa.Add((-10,10),per_channel=0.5),
      iaa.AddToHueAndSaturation((-20,20))]]

seq = iaa.Sequential(seq)

Here it is a little bit clearer what the problem is, the SomeOf Function was closed too early, hence the correct code should be:
seq=[
 iaa.SomeOf((0,2),[
      iaa.AdditiveGaussianNoise(loc=0,scale=(0.0,0.05*255),per_channel=0.5),
      iaa.Add((-10,10),per_channel=0.5),
      iaa.AddToHueAndSaturation((-20,20))])]

seq = iaa.Sequential(seq)

Is there the possibility to have a better error mesage for SomeOf,something like "Missing augmenter?" which would indicate, that the someOf Function is not used correctly, instead of an AssertionError?

Yes, there are quite some places in the code where there are no proper error messages. That can then be a bit difficult to debug, though the stacktrace should usually give an indication about where it failed.
In these cases it did not fail in SomeOf, as that augmenter can handle getting no child augmenters. It fails at iaa.Sequential(seq) as that augmenter verifies that all entries in the list that it gets are Augmenter instances, but in your failing examples one of them is again a list.
Btw, in your specific example you can skip the seq = iaa.Sequential(seq) case as SomeOf already contains all augmenters that you are using.

PR #387 added descriptive error messages to all assert statement in the library.


Allow no email/password for device authentication

If you don't fill the email/password field with any string that isn't empty when you want to authenticate with device auth, it will error; even though the email and password field is unused for device auth authentication.

I'll fix this in my next commit coming later today with alot of improvements
I overlooked this bc I usually just leave the email/password field always filled.


Add Auto-Generated Documentation

Add something like Read The Docs to auto-generate docs
Bonus: Clean up docstrings so things aren't a mess

Hello,
I have begun working on this as a small personal project in order to gain more experience with Read The Docs. If you're interested in my help or seeing what I have accomplished on this so far, please let me know.

Awesome, thanks so much! This was on my to-do list for things I wanted to get done before officially releasing the library, which I'd hoped to do in the next 1-3 weeks, so I was considering doing a rough MVP myself - any idea how hard this is/how long this might take you?  I have basically all of the text and sample code from the demo Jupyter notebook (assuming that's what you wanted to use for the documentation) up on Read the Docs. They just require some cleanup. At the moment, there are some remnants from the Jupyter notebook (things like {.cell .markdown}) that I need to go through and edit out. I haven't really modified the docs at all besides some formatting, but I plan to go through and edit some of the longer paragraphs for conciseness. Also, it's still all on one page at the moment, but the left-side navbar allows you to jump between the different headings. Adding the interactive graphs from the notebook and such might require a bit more time. Let me know if you'd like the link to what I have so far, and you can give me any feedback you like. I'm currently using Markdown with Myst-Parser to convert it to HTML.

Oh, working but somewhat messy is completely fine by me, that all sounds
great! I'd love a link to what you have so far. Thanks a lot for the help :)
On Fri, 13 Jan 2023 at 23:28, Josh B @.***> wrote:

I guess it depends on how clean and feature-filled you want the docs to
be. I have basically all of the text and sample code from the demo Jupyter
notebook (assuming that's what you wanted to use for the documentation) up
on Read the Docs. They just require some cleanup. At the moment, there are
some remnants from the Jupyter notebook (things like {.cell .markdown})
that I need to go through and edit out. I haven't really modified the docs
at all besides some formatting, but I plan to go through and edit some of
the longer paragraphs for conciseness. Also, it's still all on one page at
the moment, but the left-side navbar allows you to jump between the
different headings. Adding the interactive graphs from the notebook and
such might require a bit more time. Let me know if you'd like the link to
what I have so far, and you can give me any feedback you like. I'm
currently using Markdown with Myst-Parser to convert it to HTML.
—
Reply to this email directly, view it on GitHub
https://github.com/neelnanda-io/TransformerLens/issues/132#issuecomment-1382582355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPNKJK2PXC5LQ44FHKTLDWSHQLRANCNFSM6AAAAAATLKJ4W4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Here's a link. https://transformerlens-jdbowma.readthedocs.io/en/latest/index.html
Hopefully this is somewhere along the lines of what you were looking for. It should be really simple to add more docs.

Thanks! How hard is it to auto generate docs from the docstring in the
code? I like having an abridged version of the tutorial as the docs (which
you basically have at the moment), but also want to have a reference for
what functions do (idk how much work it is to generate that, or how much
the code would need to be editing to get reasonable doc strings).
I'm generally interested in ways to auto-generate docs from the code or
demos, so that the docs don't get super stale over time.
On Sat, 14 Jan 2023 at 01:45, Josh B @.***> wrote:

Here's a link.
https://transformerlens-jdbowma.readthedocs.io/en/latest/index.html
Hopefully this is somewhere along the lines of what you were looking for.
It should be really simple to add more docs.
—
Reply to this email directly, view it on GitHub
https://github.com/neelnanda-io/TransformerLens/issues/132#issuecomment-1382628273,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPNKPBORKZSWPU4CTPCODWSIAMTANCNFSM6AAAAAATLKJ4W4
.
You are receiving this because you authored the thread.Message ID:
@.***>

My bad for the late response.
I haven't totally looked into that yet, I'll see if I can figure it out. I'll let you know if I am able to do that. This should be fairly easy to do as the auto-generation of docs is basically the purpose of Read the Docs, but from what I understand it needs to have markdown files to display the text, so at some level, you'd probably need to generate markdown from the docstrings. Again, I could be wrong so I'll check it out later tonight to see how simple this would be.
Again, apologies for the delay.

https://sphinx-rtd-tutorial.readthedocs.io/en/latest/build-the-docs.html#generating-documentation-from-docstrings
I believe this is the answer to our problem right here. Shouldn't be difficult at all to get that up and running.

@jdbowma you're right that this should make autogenerating docs easy. It would be good to create a PR, although you're branch might be a little diverged (24 commits behind main). Would you be able to rebase and submit a PR? I can help if needed.

@neelnanda-io  I've made a branch with autogenerating documentation.
You can preview it here: https://jbloomaus.github.io/TransformerLens/
and the code here: https://github.com/jbloomAus/TransformerLens/tree/sphinx-documenation
Stuff I've done:

Set up a sphinx documentation with extensions to read docstrings nicely and work off markdown files
Set up a github action to compile the documentation and then automatically generate.
It's possibly to automatically see the documentation regenerate as you develop.

Stuff I haven't done but is possible:

automatically including all the .ipynb files.
added a nice logo/graphics/images/favicon anywhere

I'd love your thoughts. I think a logo/images/a little more work on the docs might be justified. Don't want to decide the logo for you though.
@jdbowma sorry I didn't wait. Plenty to do if you want to help though!


[VL] Decouple Spark's memory manager from Gluten's memory target API

Within this patch, interface TaskMemoryTarget will be removed, then the memory target API, including the common decorator implementations will no longer directly rely on any of Spark's API.
By doing this we could have opportunity to replace Spark's memory manager with our own implementation within minimum effort. So far the patch is just code refactor in advance of the further actions.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3291_time.csv
log/native_master_09_26_2023_dffd4a993_time.csv
difference
percentage

q1
43.63
43.11
-0.521
98.81%

q2
25.01
24.77
-0.236
99.05%

q3
37.46
37.78
0.320
100.85%

q4
41.41
41.79
0.376
100.91%

q5
70.26
70.23
-0.026
99.96%

q6
6.57
6.52
-0.050
99.24%

q7
85.96
86.01
0.048
100.06%

q8
79.22
79.93
0.710
100.90%

q9
118.14
115.79
-2.346
98.01%

q10
48.68
46.51
-2.164
95.55%

q11
19.27
19.54
0.278
101.44%

q12
22.60
24.04
1.440
106.37%

q13
50.18
50.28
0.109
100.22%

q14
13.70
14.27
0.565
104.12%

q15
29.74
27.99
-1.745
94.13%

q16
15.78
15.97
0.186
101.18%

q17
121.82
120.66
-1.167
99.04%

q18
161.74
163.74
2.000
101.24%

q19
12.24
12.08
-0.163
98.67%

q20
33.19
27.57
-5.619
83.07%

q21
247.43
239.19
-8.241
96.67%

q22
15.68
15.34
-0.343
97.81%

total
1299.71
1283.12
-16.591
98.72%

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_master_09_27_2023_time.csv
log/native_master_09_26_2023_dffd4a993_time.csv
difference
percentage

q1
43.84
43.11
-0.725
98.35%

q2
24.25
24.77
0.518
102.14%

q3
37.31
37.78
0.469
101.26%

q4
41.10
41.79
0.689
101.68%

q5
70.67
70.23
-0.436
99.38%

q6
7.07
6.52
-0.555
92.15%

q7
83.62
86.01
2.395
102.86%

q8
82.10
79.93
-2.172
97.35%

q9
116.36
115.79
-0.570
99.51%

q10
46.38
46.51
0.135
100.29%

q11
18.95
19.54
0.595
103.14%

q12
25.24
24.04
-1.200
95.25%

q13
50.58
50.28
-0.296
99.41%

q14
16.28
14.27
-2.013
87.64%

q15
27.18
27.99
0.814
103.00%

q16
16.28
15.97
-0.305
98.13%

q17
120.13
120.66
0.525
100.44%

q18
161.84
163.74
1.906
101.18%

q19
12.16
12.08
-0.078
99.36%

q20
28.31
27.57
-0.742
97.38%

q21
239.00
239.19
0.195
100.08%

q22
15.72
15.34
-0.383
97.56%

total
1284.35
1283.12
-1.234
99.90%


hv.Table date formatting for pd.Timestamp

Hi,
I have a pd.Dataframe with Timestamp objects as entries for some rows,
and would like to display them in timestamp format (eg. '2019-04-01') rather than as integers.
hv.Table automatically recognizes the object type and gives the appropriate formatting this way:

But, if I do some transformation (in order to have a table whose row contains a stat entry), the table formats the Timestamp object as integer (dt.datetime object).

Here is my current dimension formatter setting:

Is there something I'm missing here?
Thank you!

I'm not sure about the question at hand but in general it's much easier to have a look and see where the issue lies if you post a copy-pastable Minimal Working Example :)

Sorry about that! Here is the simplified version:
cols = ['mean', 'std', 'min', 'argmin', 'max', 'argmax']
data = np.array([[376.737, 8.163, 347.322, pd.Timestamp('2019-04-26 00:00:00'),
        391.104, pd.Timestamp('2019-04-03 00:00:00')]])
df = pd.DataFrame(data, columns=cols)
display(df)
display(hv.Table(df)) # formating works

## I would like to have each stat as a rowitem
## Formating doesn't work
data = df.T.reset_index().values
display(data)
hv.Table(data, 'stat', 'value')

Ah yes. This code: https://github.com/pyviz/holoviews/blob/65136173014124b41cee00f5a0fee82acdc78f7f/holoviews/plotting/bokeh/tabular.py#L91 ff. looks like it enforces one dtype for the entire column.


Rebind SshFeed workaround

@bostko what is this to work around? I presume it's for the rebind errors reported in https://issues.apache.org/jira/browse/BROOKLYN-453? Based on the fixes in https://github.com/apache/brooklyn-server/pull/598, do we need the changes you've done here? If not, can you close this PR please?

No we do not need this PR since we have #598 .


Cannot send email verification (no templates found)

Hello,
I already tried MailWhale on docker. Signup failed and no any email verifications sent.
The error from logs :
[ERROR] failed to send user verification to<EMAIL_ADDRESS>open templates/user_verification.tpl.html: no such file or directory
please advise and thank you

Hi, thanks for bringing this up. Please set env: prod in config.yml, that's going to fix the problem. I'll adapt the README.

Okay sorry, I think this won't help. I'll adjust the Docker build.


Remove ReferencePolicy in favor of ReferenceGrant before v0.6.0 release

We left this in place in v0.5.0 for a more seamless transition to the renamed resource. We need to remove this in v0.6.0 (x-ref #1201, #1205).

/remove-lifecycle stale


Installation fails on OSX with "signature not found in transparency log"

Step 1: Downloading: chainloop-cli-0.9.0-darwin-arm64.tar.gz
Done...

Step 1.2: Verifying checksum
Checksum OK

Step 1.3: Verifying signature
Error: signature not found in transparency log
main.go:74: error during command execution: signature not found in transparency log

Cosign version:
GitVersion:    2.0.2
GitCommit:     871448050b924a7946ebe47678f23aae09ef432d
GitTreeState:  "clean"
BuildDate:     2023-04-24T17:31:42Z
GoVersion:     go1.20.3
Compiler:      gc
Platform:      darwin/arm64

For the record, this is not an OSX issue but instead that we were not signing the artifacts with cosign 2.x which by default sends entries to rekor.
Chainloop v0.9.1 onwards will contain an entry in the transparent log

chainloop, docs, integration-demo repositories updated and the installation on OSX works now for 0.9.1


Select seems to remembering state

From last (1.5.2) update Select component seems to be working a little bit different. It seems to remembering chosen value even if it is rerendered . I believe none of option should be selected if component is mounting (if selectedIndex is not set), as it was working before. Please take at look at example from CodeSandbox:
https://codesandbox.io/s/xpq5z85vpq

U r showing hiding the component, why is that not supposed to remember state?

can you check if this was fine in 1.5.1?

Nope, none of those versions have Select/TextField components working different.

Yup, you're right, I didn't noticed that. So it looks like it's issue more for preact, not preact-material-components. I'm closing this issue, thanks for investigation :)

I might not recall this correctly but this might actually be a browser thing


Prevent console window from displaying

This turned out to be a very simple fix.  All I had to do was rename the file from fileSearch.py to fileSearch.pyw.
By using a .pyw extension, you indicate to Python that you want the script to run as a GUI application, and it should not open a console window.

Renamed file.