console.tron.log is undefined

ERROR:
12-03 13:42:38.396 18257-18276/? E/ReactNativeJS: TypeError: undefined is not an object (evaluating 'console.tron.log')
12-03 13:42:38.436 18257-18277/? E/AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
    Process: com.myapp, PID: 18257
    com.facebook.react.common.JavascriptException: TypeError: undefined is not an object (evaluating 'console.tron.log'), stack:
    <unknown>@1413:472
    <unknown>@714:290
    <unknown>@722:741
    onPress@1282:1566
    touchableHandlePress@214:2247
    touchableHandlePress@-1
    _performSideEffectsForTransition@205:9659
    _performSideEffectsForTransition@-1
    _receiveSignal@205:8341
    _receiveSignal@-1
    touchableHandleResponderRelease@205:5629
    touchableHandleResponderRelease@-1
    b@89:1197
    k@89:1340
    C@89:1394
    N@89:1692
    A@89:2482
    forEach@-1
    z@89:2282
    <unknown>@89:13914
    _e@89:88659
    Ne@89:13582
    Ue@89:13755
    receiveTouches@89:14547
    value@24:3685
    <unknown>@24:841
    value@24:2939
    value@24:813
    value@-1

        at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:71)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:371)
        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:150)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:26)
        at android.os.Looper.loop(Looper.java:145)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:225)
        at java.lang.Thread.run(Thread.java:818)

package.json

{
  "name": "myapp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios",
    "start": "react-native start",
    "test": "jest",
    "clean": "rm -rf $TMPDIR/react-* && watchman watch-del-all && npm cache clean --force",
    "clean:android": "cd android/ && ./gradlew clean && cd .. && react-native run-android",
    "newclear": "rm -rf $TMPDIR/react-* && watchman watch-del-all && rm -rf ios/build && rm -rf node_modules/ && npm cache clean --force && npm i",
    "test:watch": "jest --watch",
    "updateSnapshot": "jest --updateSnapshot",
    "coverage": "jest --coverage && open coverage/lcov-report/index.html || xdg-open coverage/lcov-report/index.html",
    "android:build": "cd android && ./gradlew assembleRelease",
    "android:install": "cd android && ./gradlew assembleRelease && ./gradlew installRelease",
    "android:hockeyapp": "cd android && ./gradlew assembleRelease && puck -submit=auto app/build/outputs/apk/app-release.apk",
    "android:devices": "$ANDROID_HOME/platform-tools/adb devices",
    "android:logcat": "$ANDROID_HOME/platform-tools/adb logcat *:S ReactNative:V ReactNativeJS:V",
    "android:shake": "$ANDROID_HOME/platform-tools/adb devices | grep '\\t' | awk '{print $1}' | sed 's/\\s//g' | xargs -I {} $ANDROID_HOME/platform-tools/adb -s {} shell input keyevent 82",
    "storybook": "storybook start -p 7007",
    "lint": "standard --verbose | snazzy && eslint .",
    "lintdiff": "git diff --name-only --cached --relative | grep '\\.js$' | xargs standard | snazzy",
    "fixcode": "standard --fix",
    "git-hook": "npm run lint -s && npm run test -s",
    "eslint-check": "eslint --print-config App/Containers/TimelineScreen/index.js | eslint-config-prettier-check"
  },
  "dependencies": {
    "@react-native-community/geolocation": "^2.0.2",
    "apisauce": "^1.1.1",
    "format-json": "^1.0.3",
    "identity-obj-proxy": "^3.0.0",
    "lodash": "^4.17.11",
    "prop-types": "^15.6.1",
    "querystringify": "2.1.0",
    "ramda": "^0.26.1",
    "react": "16.8.1",
    "react-native": "0.61.3",
    "react-native-animatable": "^1.3.2",
    "react-native-config": "^0.11.7",
    "react-native-elements": "^1.1.0",
    "react-native-gesture-handler": "1.5.0",
    "react-native-i18n": "2.0.14",
    "react-native-permissions": "^2.0.4",
    "react-native-vector-icons": "^6.6.0",
    "react-native-video": "^5.0.2",
    "react-navigation": "3.11.0",
    "react-navigation-redux-helpers": "^3.0.2",
    "react-redux": "^6.0.0",
    "redux": "^4.0.0",
    "redux-saga": "^1.0.0",
    "reduxsauce": "1.0.1",
    "seamless-immutable": "^7.1.2"
  },
  "devDependencies": {
    "@babel/core": "^7.5.0",
    "@babel/runtime": "^7.5.0",
    "@react-native-community/eslint-config": "^0.0.3",
    "@storybook/addon-actions": "5.0.11",
    "@storybook/addon-links": "5.0.11",
    "@storybook/addon-storyshots": "^4.1.11",
    "@storybook/addons": "^4.1.11",
    "@storybook/channels": "^4.1.11",
    "@storybook/react-native": "^4.1.11",
    "babel-core": "6.26.3",
    "babel-eslint": "^7.2.3",
    "babel-jest": "^24.1.0",
    "babel-plugin-ignite-ignore-reactotron": "^0.3.0",
    "babel-preset-env": "^1.6.1",
    "babel-preset-react-native": "^4.0.1",
    "enzyme": "^3.2.0",
    "enzyme-adapter-react-16": "^1.1.0",
    "eslint-config-airbnb": "^18.0.1",
    "eslint-config-babel": "^9.0.0",
    "eslint-config-prettier": "^6.3.0",
    "eslint-plugin-babel": "^5.3.0",
    "eslint-plugin-flowtype": "^4.3.0",
    "eslint-plugin-import": "^2.18.2",
    "eslint-plugin-jsx-a11y": "^6.2.3",
    "eslint-plugin-prettier": "^3.1.0",
    "eslint-plugin-react": "^7.14.3",
    "eslint-plugin-standard": "^4.0.1",
    "eslint-plugin-unicorn": "^11.0.1",
    "ignite-andross": "^4.1.0",
    "ignite-animatable": "1.0.2",
    "ignite-i18n": "1.2.0",
    "ignite-standard": "1.0.0",
    "jest": "^24.1.0",
    "metro-react-native-babel-preset": "^0.51.1",
    "mockery": "^2.1.0",
    "prettier": "^1.18.2",
    "prettier-eslint": "^9.0.0",
    "react-devtools-core": "3.6.0",
    "react-dom": "16.7.0",
    "react-test-renderer": "16.8.1",
    "reactotron-react-native": "^2.1.0",
    "reactotron-redux": "^2.1.0",
    "reactotron-redux-saga": "^3.0.0",
    "snazzy": "^8.0.0",
    "standard": "10.0.2"
  },
  "jest": {
    "preset": "react-native",
    "testMatch": [
      "<rootDir>/Tests/**/*.js",
      "**/?(*.)(spec|test).js?(x)"
    ],
    "testPathIgnorePatterns": [
      "/node_modules/",
      "<rootDir>/Tests/Setup.js"
    ],
    "moduleNameMapper": {
      "^.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "identity-obj-proxy"
    },
    "transform": {
      "^.+\\.(js)$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
    },
    "setupFiles": [
      "<rootDir>/Tests/Setup"
    ]
  },
  "config": {},
  "standard": {
    "parser": "babel-eslint",
    "globals": [
      "describe",
      "test",
      "jest",
      "expect",
      "fetch",
      "navigator",
      "__DEV__",
      "XMLHttpRequest",
      "FormData",
      "React$Element"
    ]
  }
}

I deployed app usign "npm run android:install" to my physical device and i get the error.
I think Reactotron dependencies should be in prod dependencies. What do you think?

I commented out bold sections. And it worked.
App/Redux/ScreenTrackingMiddleware.js
import { NavigationActions } from 'react-navigation'
// gets the current screen from navigation state
const getCurrentRouteName = (navigationState) => {
  if (!navigationState) {
    return null
  }
  const route = navigationState.routes[navigationState.index]
  // dive into nested navigators
  if (route.routes) {
    return getCurrentRouteName(route)
  }
  return route.routeName
}

const screenTracking = ({ getState }) => next => (action) => {
  if (
    action.type !== NavigationActions.NAVIGATE &&
    action.type !== NavigationActions.BACK
  ) {
    return next(action)
  }

  const currentScreen = getCurrentRouteName(getState().nav)
  const result = next(action)
  const nextScreen = getCurrentRouteName(getState().nav)
  if (nextScreen !== currentScreen) {
    try {
      **console.tron.log(`NAVIGATING ${currentScreen} to ${nextScreen}`)**
      // Example: Analytics.trackEvent('user_navigation', {currentScreen, nextScreen})
    } catch (e) {
      **console.tron.log(e)**
    }
  }
  return result
}

export default screenTracking

there is a plugin for it. Ignite shouldnt require any extra plugin.
https://github.com/infinitered/babel-plugin-ignite-ignore-reactotron

This only affects the ignite-andross boilerplate.  The babel plugin has not been updated since 2017 so I don't think it will work.
You can see how ignite-bowser prevents Reactotron crashes in prod in reactotron.ts#L22-L48. Doing something similar in your app will help.
This should be added to the boilerplate if anyone has time for a pull request.

@tayfunyasar Reactotron is purposely excluded from running in production by default because it provides access to behind the scenes information, which if someone discovered in your production app could be harmful to your business (for example, they might be able to bypass payment requirements to access premium content or delete data from your database bypassing user type checks). If you want to run Reactotron in production you need to set that up manually.

Thats why i got this error when i run app in debug mode on my real device. Thanks for details.

To solve this problem easily my suggestion is, search in your project for "console.tron.log" and add if condition to check either your project is in DEV mode or not. You can do this simply by using  "DEV && console.tron.log()"
Thanks

I am using ignite-bowser in my project, but ran into this same problem yesterday after making my first release bundle. Like you said, @ruddell , I see the code in reactotron.ts#L22-L48, but it doesn't seem be mocking out the console.tron.log properly, as it still crashes and I see this message using adb logcat *:S ReactNative:V ReactNativeJS:V:
01-05 17:57:55.658 21146 21197 E ReactNativeJS: TypeError: undefined is not an object (evaluating 'console.tron.log')
The only solution that seems to work is by prefixing each use like so:
if (__DEV__) console.tron.log('test')
Any ideas why the mocked tron if !__DEV__ is not working?


update swap related description before installation

xref https://github.com/kubernetes/kubeadm/issues/2563#issuecomment-1696074991

can we just say "swap is condotionally supported. please read more here..." and link to some external page?

Probably link to https://kubernetes.io/blog/2023/08/24/swap-linux-beta/.

can we just say "swap is condotionally supported. please read more here..." and link to some external page?

Probably link to https://kubernetes.io/blog/2023/08/24/swap-linux-beta/.

+1
let's see if sig docs agree

Thanks.
/lgtm
/approve


Using iprint = 0 negatively influences the performance

Using the function fmin_cobyla the iprint variable influences the performance non-trivially. Putting iprint to 0 reduces the performance by a factor of 100x. Whereas iprint is 1,2,3 perform in line. (1 being the fastest due to less printing)

Unfortunately, I cannot provide my current setup. However, I think we have fixed it. In src/cobyla.rs line 523  should be an if statement around the println!. Now the current_block is not set and the loop isn't broken if iprint is set to 0.

Sorry, I am not sure to understand your fix. Could you copy it here?

`if nfvals >= maxfun
&& nfvals > 0 as libc::c_int as libc::c_long {
// && iprint > 0 as libc::c_int as libc::c_long{
                status = -(2 as libc::c_int);
                if iprint > 0 as libc::c_int as libc::c_long{

                println!(
                    "Return from subroutine COBYLA because {:?}.\n",
                    cobyla_reason(status),
                );
            };
                current_block =<PHONE_NUMBER>707412946;
                break;`

` if nfvals >= maxfun
&& nfvals > 0 as libc::c_int as libc::c_long {
                status = -(2 as libc::c_int);
                if iprint > 0 as libc::c_int as libc::c_long{

                println!(
                    "Return from subroutine COBYLA because {:?}.\n",
                    cobyla_reason(status),
                );
            };
                current_block =<PHONE_NUMBER>707412946;
                break;`

Hmmm... If there is a bug it seems to come from the original code (the iprint>0 condition is tested with the others)
a) original c code : https://github.com/relf/cobyla/blob/f83fcff8d899c2b8252cbe33127fd82c7f1221e3/cobyla/cobyla.c#L478
b) rust code from c2rust: https://github.com/relf/cobyla/blob/f83fcff8d899c2b8252cbe33127fd82c7f1221e3/cobyla/cobyla.rs#L466
c) edited rust code: https://github.com/relf/cobyla/blob/f83fcff8d899c2b8252cbe33127fd82c7f1221e3/src/cobyla.rs#L521
I agree that your fix is relevant as changing the verbosity should not change the logic like the status setting. On your test case if iprintf is set to zero, the algorithm still terminates? What is the value of the status then?

My bad! I've finally found, I've introduced this bug in the commit #409d753 😔 Maybe a leftover for a test/debug session... Do not remember. The original code did not test iprint at all at this point.
I will issue a release with your fix.
Thanks for the good catch!

Just to notice that the bug is present at another line:
https://github.com/relf/cobyla/blob/f83fcff8d899c2b8252cbe33127fd82c7f1221e3/src/cobyla.rs#L1617
The C code includes itself at some point, hence the duplication in the Rust code.


Fix zypper errors

root@devbox-image-tools-docker-builder:~/image-opensuse# make build
find patches -name '*~' -delete || true
docker build -t ocs-distrib-opensuse:13.2 .
Sending build context to Docker daemon 181.2 kB
Sending build context to Docker daemon
Step 0 : FROM armbuild/opensuse-disk:13.2
 ---> aad7f655c6dd
Step 1 : MAINTAINER Online Labs<EMAIL_ADDRESS>(@online_en)
 ---> Using cache
 ---> 09d9ddf6d01f
Step 2 : ENV OCS_BASE_IMAGE armbuild/ocs-distrib-opensuse:13.2
 ---> Using cache
 ---> 31cb8ee35c00
Step 3 : RUN zypper rm -y kernel-default kernel-firmware
 ---> Using cache
 ---> 1d052ded0560
Step 4 : RUN zypper rm -y libmozjs-17_0 bluez cracklib-dict-full
 ---> Using cache
 ---> 9d173ba68641
Step 5 : RUN zypper -v refresh  && zypper --non-interactive update  && zypper --non-interactive install     bc     curl     shunit2     socat     sudo     tmux     vim     wget
 ---> Running in 8dbaae41f913
Verbosity: 1
Initializing Target
Specified repositories:
Checking whether to refresh metadata for openSUSE-13.2-repo-oss
Retrieving: content [done]
Retrieving: media [done]
Retrieving repository 'openSUSE-13.2-repo-oss' metadata [.Retrieving: content [..done]
Retrieving: media [done]
Retrieving: media [done]
Retrieving: content.asc [done]
Retrieving: content.key [done]
Retrieving: content [done]
  Repository:       openSUSE-13.2-repo-oss
  Key Name:         openSUSE Project Signing Key<EMAIL_ADDRESS>  Key Fingerprint:  22C07BA5 34178CD0 2EFE22AA B88B2FD4 3DBDC284
  Key Created:      Mon May  5 10:37:40 2014
  Key Expires:      Thu May  2 10:37:40 2024
  Rpm Name:         gpg-pubkey-3dbdc284-53674dd4
Retrieving: app-icons.tar.gz [..done]
Retrieving: appdata.xml.gz [done]
Retrieving: packages.DU.gz [done]
Retrieving: packages.en.gz [..done]
Retrieving: packages.gz [done]
done]
Checking whether to refresh metadata for openSUSE-13.2-repo-update
Retrieving: repomd.xml [done]
Retrieving repository 'openSUSE-13.2-repo-update' metadata [.Retrieving: repomd.xml [done]
Retrieving: repomd.xml.asc [done]
Retrieving: repomd.xml.key [done]
Retrieving: repomd.xml [done]
  Repository:       openSUSE-13.2-repo-update
  Key Name:         openSUSE Project Signing Key<EMAIL_ADDRESS>  Key Fingerprint:  22C07BA5 34178CD0 2EFE22AA B88B2FD4 3DBDC284
  Key Created:      Mon May  5 10:37:40 2014
  Key Expires:      Thu May  2 10:37:40 2024
  Rpm Name:         gpg-pubkey-3dbdc284-53674dd4
Retrieving: 20b441127c822fd3af35323e3f3887227aa53f504680685fed90b18428f01bec-app-icons.tar.gz [..done]
Retrieving: b72471d7c46d4568db5a84403748fa148ec2a71ad3d850b4256a0ebd979ee237-appdata.xml.gz [done]
Retrieving: 35d317d161be0b55d097276d664f559fa1ba749638c2a28b9a05dca70d08c6df-updateinfo.xml.gz [..done]
Retrieving: 5afc6cb78c11733eb7ae0cd9dfefc5a37fba3d6530ec285484cf419be9bc7e84-suseinfo.xml.gz [done]
Retrieving: 3b9cc4ae1d1a70790de4ded4414c9276b788e2f5786d3426ec712587dc563658-primary.xml.gz [....done (1.3 MiB/s)]
Retrieving: d2e0c7257181326fefa5e00e523d1124635388466ef3aa3a7cbaf1063a3980c7-deltainfo.xml.gz [done]
done]
All repositories have been refreshed.
Retrieving repository 'openSUSE-13.2-repo-oss' metadata [...done]
Retrieving repository 'openSUSE-13.2-repo-update' metadata [.....done]
Loading repository data...
Reading installed packages...

The following NEW package is going to be installed:
  bundle-lang-common-ar

The following package is going to be upgraded:
  dirmngr

1 package to upgrade, 1 new.
Overall download size: 335.3 KiB. Already cached: 0 B  After the operation, additional 725.0 KiB will be used.
Continue? [y/n/? shows all options] (y): y
Retrieving package bundle-lang-common-ar-13.2-3.3.1.noarch (1/2), 159.3 KiB (725.0 KiB unpacked)
Media source 'http://download.opensuse.org/ports/armv7hl/distribution/13.2/repo/oss/' does not contain the desired medium

Abort, retry, ignore? [a/r/i/? shows all options] (a): a
Problem occured during or after installation or removal of packages:
Installation aborted by user

Please see the above error message for a hint.
2015/02/11 16:55:35 The command [/bin/sh -c zypper -v refresh  && zypper --non-interactive update  && zypper --non-interactive install     bc     curl     shunit2     socat     sudo     tmux     vim     wget] returned a non-zero code: 4
docker-rules.mk:84: recipe for target '.docker-container.built' failed
make: *** [.docker-container.built] Error 1
root@devbox-image-tools-docker-builder:~/image-opensuse#

This is solved now, thanks to the refresh of the armhf base image I think.

cool :palm_tree:


Misc Firefox UI glitches (icon wrong, SHARE ACCESS text wraps)

Share access wraps by default. Probably fixed by moving to toast. Probably caused by font selection and overly restrictive width on tag.
When logged in, the browser icon is still grey.

@iislucas both of these seem to be fixed, I'm closing the issue.


Don't corrupt drawing when rotating

Previously there was a race condition when updating the size of the GLSurface.
Now we explicitly update the size of the surface to match what we expect.

Yay!  lgtm


Builds (especially release builds) are difficult to reproduce

Description of problem
I am trying to build a complete kata release from source (basically the content that kata project itself builds for its own binary releases). Ideally to do the builds I would have access to the complete sources used in a release tar for each project. Unfortunately some projects are git cloned during the build process and to make things more difficult they do not checkout a specific tag or even commit so they are very hard or impossible to replicate.
Expected result
Each project has a single distribution tar with all required static dependencies included or at least has the tars for the required static dependencies available for each release.

Hi @bryteise - Could you enumerate the projects that are causing problems? We use dep vendoring for golang, and everything else is supposed to be using either the master versions database:

https://github.com/kata-containers/runtime/blob/93197ddcc3723e676d373959071b67385283f712/versions.yaml

... Or the tests versions database:

https://github.com/kata-containers/runtime/blob/93197ddcc3723e676d373959071b67385283f712/versions.yaml

@jodh-intel First I think that I just had changed some things in Clear Linux's build system and had made a mistake in my expectations with the vendoring used in 1.8.2. So this bug is invalid with respect to the go release tars though this repo is difficult for me to make use of for figuring out how to package kata.
So I am going to try my hand at packaging kata from a different angle. First the https://katacontainers.io/software/ site, it has a broken link for the get the software pointing to https://git.katacontainers.io/cgit. Okay that's fine, I know the github repo obviously so I'll see what instructions exist for install via https://github.com/kata-containers/documentation/blob/master/Developer-Guide.md#initial-setup.
Since I need to build offline I grab the 1.8.2 release source tar for runtime and proceed on my merry way, success. Similarly I can build proxy and shim (this is where I somehow got stuck trying to use the packaging mechanism instructions for some reason and the reason for the bug).
I see some mention of initrd vs image. Clear Linux has been using https://github.com/kata-containers/agent/ releases up until this point rather than creating our own and I think this image's only real purpose is hosting the agent. So rather than trying to do a dance to build up an initrd and maybe have to patch runtime config I just fall back to the current method (should we change this?).
I'm skipping the kernel as we update that as part of a different process and it is really just the extra patch anyway.
Finally we get to qemu, the kata qemu-lite branch referenced in the documentation is very old. I know there have been multiple iterations on what to do here over the years so I'd like to try and adopt an approach that is both performant and maintained. The documentation doesn't really give me any ideas here though unfortunately. This repo has references to the stale qemu-lite branch and nemu. I have seen mention of using upstream qemu with patch(es) as well. For now I'm ignoring this and am just going to continue to use the old qemu-lite but an update to this section would be most welcome I think.

Thanks for writing this up @bryteise.
The issue with the katacontainers.io website
We no longer manage this site. The original source used to be https://github.com/kata-containers/www.katacontainers.io, but I believe it is currently generated from https://github.com/jimmytipit/kata-netlify-refresh.
We have requested that OSF move the content in that repo back to https://github.com/kata-containers/www.katacontainers.io.
Using a rootfs image or an initrd image
I put this together to compare the two:
https://github.com/kata-containers/documentation/wiki/Kata-images
TL;DR - initrd is much faster, but less flexible.
*emu's
Yeah, cough.. an embarrasment of riches :smile:

This repo has references to the stale qemu-lite branch and nemu.

Can you point to where you're seeing this?

an update to this section would be most welcome I think.

Again, if you could provide a pointer, we'll try to get this tidied up.
/cc @egernst.

A quick update - the source for https://katacontainers.io/ is now (back) in https://github.com/kata-containers/www.katacontainers.io :smile:

This repo has references to the stale qemu-lite branch and nemu.
Can you point to where you're seeing this?
So I had thought I saw mention of nemu but I must have been paying attention to another document somewhere else. I was referring to this.
That uses this qemu-lite-2.11.0 branch which hasn't been updated since December of last year. Maybe that's right but it isn't something I'm going to trust at first glance.

Reading over the qemu configuration in that section, as a non-expert in qemu, I am left to try and see if I can reasonably merge the generated configuration from the kata-containers/packaging/scripts/configure-hypervisor.sh or just keep the two different qemu's around in the distro. Then I see things like this which point to upstream qemu needing to be patched anyway but that isn't mentioned in the developer guide. Given that the first recommendation is using a 2.11.0 fork I don't have high hopes for myself to be able to make something reasonable.


Allow to parse any extra oembed parameter via ExtraOpts

Hey,
we started to use this library in prod now and saw that a lot of the big services use way more parameters than the 4 specified by the offizial oembed definition. Examples are e.g. autoplay used by many video services or dnt to avoid tracking.
Because the list of available parameters is vendor specific and according to the oembed spec, sending unknown parameters should be ignored by the provider I decided to implement this with a simple map[string]string and concatenate the url with &key=value pairs.
What do you think of this? I currently use my fork for our codebase and it's working fine for us.
Felix

Hi Felix!
Thank you for the PR, very appreciate this.
This is a very good addition, but Im wondering whether this have to be a map.. if a services accepts an array of some key, then those keys have to be repeated. For example:
/?a[]=1&a[]=2&a[]=3

But map won't allow us to do this.
I think better idea is to use net/url and then work with params like this:
params := url.Values{}
params.Add("q", "some long string")
params.Add("q", "another long string")
// then we can get raw string using params.Encode()

so those ExtraOpts can be this url.Values{} type, and it's probably better to switch to this type when we build an url. Benefits:

support for multiple params with the same name
correct encoding/escaping out of the box

What do you say?

I agree on your points, using url.Values sounds like a good improvement to me.
I will update this PR at the weekend :)

This is an example which I assembled now:
https://play.golang.org/p/JidUh8b_QYQ

Added support for extra opts: https://github.com/dyatlov/go-oembed/commit/a57c85b3b37c0375d869f298387d9bcf5bb437c7
Closing this PR


Enable customisation of playlist name

First attempt for review. I struggled a bit with PureCSS having fewer options than I'm used to so the input is wider than ideal on large screens.
I can also only test up to the point of starting the Spotify API auth handshake as I still don't have the callback working.

Also, given that you're merging more stuff (awesome and thank you!) that I haven't had time to deeply test myself, I'm switching the base branch of the repo to dev. That'll make it so you can keep merging, but I don't have to worry about deploying a whole host of changes at once if I just want to add in a lineup and deploy support of it straight away

Also, given that you're merging more stuff (awesome and thank you!) that I haven't had time to deeply test myself, I'm switching the base branch of the repo to dev. That'll make it so you can keep merging, but I don't have to worry about deploying a whole host of changes at once if I just want to add in a lineup and deploy support of it straight away. Can you retarget this branch to dev when you make the above changes please

Thanks for considering the changes and taking the time to review! Re-targetted against dev now.

One thing I haven't tested is the code inside the null check path. If you'd like I can try deleting the relevant key out of Redis to check it handles correct - run out of time for today, have to get down to NOS :-)

Nah no need to test that low level, looks good. Thanks!

Made a few tweaks around the layout and wording but this and other changes merged to dev are now deployed on master and live! Thanks for the great contributions

Great stuff, thank you for deploying. I got a bit sidetracked but have plans for some more lineups / PRs over the next couple weeks


Enhanced statistics

Enhanced pilot statistics

total nautical miles flown
total passengers flown
total cargo flown
total fuel usage
total earnings (airline, not personal)
total expenses
unique airports visited
unique countries visited

Perhaps the ability to drill down per aircraft type per user, see how many miles User X has flown in an A320, how many passengers they've flown in a 208, etc.
Airport statistics

total flights
total passengers
total freight
total fuel purchased

Airframe statistics (per tail number)

nautical miles flown
hours flown
passengers flown
freight flown
fuel used

The latter could expand into a maintenance module later down the road, where aircraft must have annual / 100hr inspections, perhaps even SMOH times on engines
Maybe monthly versions of the above items for graphing / trending / reporting?

Just some thoughts/notes for me:

Have a generic stats collection class:

abstract class Stats {
  public $statName;  // Hold the stat name
  abstract function calculate(User $user): Stat;

  public function runCalculation(User $user) {
    // run the calculate() method
    $stat = $this->calculate($user);

    // sanity checks, insert into DB
  }
}

And a model/enum:
public class IntervalEnum {
  // minute, hourly, daily, monthly, yearly
}

public class Stat extends Model {
  public $fillable = ['name', 'interval-type', 'interval-time', 'value'];
}

Impl:
class TotalFlights extends Stats {
  public $statName = 'total-flights';

  public function calculate(User $user): Stat {
    $stat = new Stat(['interval-type' => IntervalEnum::$daily, 'interval-time' = Carbon::today()]);
    // calc..
    $stat->value = $user->total_flights;  // dumb... but return some kind of value

    return $stat;
  }
}

more pilot statistics?
Top pilots landing rating (Gs forces or vertical speed?)
Top pilots hours
Top pilots flights


ERROR - STM32: no file stm32l4xx_hal.h found when compiling

Terms

[X] Checked the existing issues and discussions to see if my issue had not already been reported;
[X] Read the best practice and checked if my bug was not one of the common bugs documented in the Wiki;
[X] Updated my Python virtual environment with rye sync;

Describe the issue
When trying to build any project file (ex. hands_on_main_app), the console gives me several errors :
``../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory.`
I searched in all my LELEC210X files, and indeed, the required header file doesn't exist.
Analysis and what I've tried:

I already had the same problem two weeks ago (when I was on dual-boot linux, now I am on windows so the OS isn't the problem), and I solved it by copying the __stm32l4xx_hal file that existed in another project (ex: it worked with hands_on_mcu so the file was created in this project). However, this time the file doesn't exist at all in my LELEC210X folder (I used search methods).

Two other members of my group had the same problem. For one, it was solved by regenerating the code of the ioc file. However, it didn't work for two of us.

I tried to erase the project, connect the mcu board, recreate the project, clean it, regenerate the code with the .ioc file, the build the project, but it didn't work.

Command or program
make -j8 all
Issue Type
Error when running an command
What is your platform?
Windows
Other platform
No response
Relevant error output
arm-none-eabi-gcc "../Core/Src/adc.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/adc.d" -MT"Core/Src/adc.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/adc.o"
arm-none-eabi-gcc "../Core/Src/adc_dblbuf.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/adc_dblbuf.d" -MT"Core/Src/adc_dblbuf.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/adc_dblbuf.o"
arm-none-eabi-gcc "../Core/Src/arm_absmax_q15.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/arm_absmax_q15.d" -MT"Core/Src/arm_absmax_q15.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/arm_absmax_q15.o"
arm-none-eabi-gcc "../Core/Src/dma.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/dma.d" -MT"Core/Src/dma.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/dma.o"
arm-none-eabi-gcc "../Core/Src/eval_radio.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/eval_radio.d" -MT"Core/Src/eval_radio.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/eval_radio.o"
arm-none-eabi-gcc "../Core/Src/gpio.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/gpio.d" -MT"Core/Src/gpio.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/gpio.o"
arm-none-eabi-gcc "../Core/Src/main.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/main.d" -MT"Core/Src/main.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/main.o"
arm-none-eabi-gcc "../Core/Src/packet.c" -mcpu=cortex-m4 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32L4A6xx -c -I../Drivers/CMSIS/Include -I../Core/Inc -I../Drivers/CMSIS/Device/ST/STM32L4xx/Include -I../Drivers/STM32L4xx_HAL_Driver/Inc -I../Drivers/STM32L4xx_HAL_Driver/Inc/Legacy -I"C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/packet.d" -MT"Core/Src/packet.o" --specs=nano.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/packet.o"
In file included from ../Core/Inc/dma.h:28,
                 from ../Core/Src/dma.c:21:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
In file included from ../Core/Inc/adc_dblbuf.h:4,
                 from ../Core/Src/eval_radio.c:5:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
compilation terminated.
In file included from ../Core/Inc/adc.h:28,
                 from ../Core/Src/adc.c:21:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
In file included from ../Core/Src/main.c:21:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
In file included from ../Core/Inc/gpio.h:28,
                 from ../Core/Src/gpio.c:21:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
compilation terminated.
In file included from ../Core/Inc/adc_dblbuf.h:4,
                 from ../Core/Src/adc_dblbuf.c:1:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
In file included from ../Core/Src/arm_absmax_q15.c:30:
C:/Users/marti/OneDrive/Documents/Ecole/EPL/M1/Q1/LELEC2102-Project_Embedded_system/LELEC210X/mcu/hands_on_main_app/ARM_CMSIS/CMSIS/DSP/Include/arm_math.h:390:10: fatal error: cmsis_compiler.h: No such file or directory
  390 | #include "cmsis_compiler.h"
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Core/Src/subdir.mk:76: Core/Src/adc.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Core/Src/subdir.mk:76: Core/Src/dma.o] Error 1
make: *** [Core/Src/subdir.mk:76: Core/Src/gpio.o] Error 1
make: *** [Core/Src/subdir.mk:76: Core/Src/main.o] Error 1
make: *** [Core/Src/subdir.mk:76: Core/Src/eval_radio.o] Error 1
make: *** [Core/Src/subdir.mk:76: Core/Src/arm_absmax_q15.o] Error 1
make: *** [Core/Src/subdir.mk:76: Core/Src/adc_dblbuf.o] Error 1
In file included from ../Core/Src/packet.c:8:
../Core/Inc/main.h:31:10: fatal error: stm32l4xx_hal.h: No such file or directory
   31 | #include "stm32l4xx_hal.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Core/Src/subdir.mk:76: Core/Src/packet.o] Error 1
"make -j8 all" terminated with exit code 2. Build might be incomplete.

13:37:47 Build Failed. 17 errors, 0 warnings. (took 780ms)

Screenshots
No response
Additional information
No response
Recommended fix or suggestions
No response

Hi,
I suspect you do not have the required drivers in the project which should normally be fixed by regenerating the code, just to be sure :

Do you have the following structure in STM32 Cube IDE, with the "Drivers" folder missing? If present (but you have the compilation error you mention), right click on it and delete it. Also, go to this folder via the file explorer and delete the "Drivers" folder if it is present there.
Then regenerate the code by :

Double-clicking on the .ioc
On the top bar, between "Search" and "Run", do "Project > Generate Code".

Do you still have the error now?

Duplicate of #33

Thank you for your answers.
The problem was that some updates of the STM32 software were not done, so generating the code did not produce any file at all, which caused the error.
After installing the updates (it took some time), "generate code" indeed created the recquired file for compiling.


Fix gradle init when there is a pom and the --dsl kotlin is set

Fix gradle init when there is a pom and the --dsl kotlin is set
Expected Behavior
When you do a gradle init --dsl kotlin on a project where there is a pom.xml, it should generate a gradle.build.kts with gradle-dsl instead of gradle.build with groovy dsl.

@eskatos is this easy or really difficult to implement? I suspect the latter, in which case I assume we should tackle this post Kotlin DSL 1.0. Do you have any info here?

It's definitely more involved than the regular init templates but nothing impossible. It's not lined up for Kotlin DSL 1.0 though. A PR from the community would be very welcome.
But, what is also reported above is that the --dsl option is silently ignored. We should fail saying that generating Kotlin DSL scripts from a Maven build isn't supported instead.

https://github.com/gradle/gradle/issues/3493 is the original issue about supporting conversion of Maven builds to Gradle Kotlin DSL.
I just opened https://github.com/gradle/gradle/pull/5331 to at least fail with a reasonable error message until this is implemented.
Closing this one as duplicate.


add 404 error page

With the move to the new organization and upcoming page
reorganization, a proper 404 "page not found" error page is
helpful.
The main advantage is that it includes the navigation
sidebar, so even if a specific page is not available, visitors
can quickly find what they're looking for.

You can see this exact same 404 page live on my fork:
https://stadicus.github.io/raspibolt-remote/xxxxxxxx-not-found.html


AssertionError: Tried to resolve a name to a reference that was unknown to the frame

Hi folks! Thanks for shipping a new release with fantastic type annotations - very much looking forward to that. :)
I've just tried upgrading, but I'm running in the following regression on the way:
repro.jinja2
{% set output %}
    {% for x in [1,2,3] %}
        hello
    {% endfor %}
{% endset %}
{{ output }}

j2 repro.jinja2 (Jinja 2.11.3)

        hello
        hello
        hello

j2 repro.jinja2 (Jinja 3.0.0)

Traceback (most recent call last):
  File "/home/user/venv/bin/j2", line 8, in
    sys.exit(main())
  File "/home/user/venv/lib/python3.9/site-packages/j2cli/cli.py", line 202, in main
    output = render_command(
  File "/home/user/venv/lib/python3.9/site-packages/j2cli/cli.py", line 186, in render_command
    result = renderer.render(args.template, context)
  File "/home/user/venv/lib/python3.9/site-packages/j2cli/cli.py", line 85, in render
    return self._env \
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/environment.py", line 996, in get_template
    return self._load_template(name, globals)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/environment.py", line 957, in _load_template
    template = self.loader.load(self, name, self.make_globals(globals))
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/loaders.py", line 137, in load
    code = environment.compile(source, name, filename)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/environment.py", line 749, in compile
    source = self._generate(source, name, filename, defer_init=defer_init)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/environment.py", line 677, in _generate
    return generate(  # type: ignore
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/compiler.py", line 116, in generate
    generator.visit(node)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/visitor.py", line 40, in visit
    return f(node, *args, **kwargs)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/compiler.py", line 887, in visit_Template
    self.blockvisit(node.body, frame)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/compiler.py", line 448, in blockvisit
    self.visit(node, frame)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/visitor.py", line 40, in visit
    return f(node, *args, **kwargs)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/compiler.py", line 1581, in visit_AssignBlock
    self.pop_assign_tracking(frame)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/compiler.py", line 812, in pop_assign_tracking
    ref = frame.symbols.ref(name)
  File "/home/user/venv/lib/python3.9/site-packages/jinja2/idtracking.py", line 80, in ref
    raise AssertionError(
AssertionError: Tried to resolve a name to a reference that was unknown to the frame ('x')

I've skimmed the Changelog, but couldn't identify anything that may point me in the right direction. The traceback is a bit above my head. Please let me know if I can help with anything else! 😃
Edit: Workaround
It's possible to convince Jinja2 that everything is ok by first defining the inner loop variable:
{% set x = None %}
{% set output %}
    {% for x in [1,2,3] %}
        hello
    {% endfor %}
{% endset %}
{{ output }}

Environment:

Python version: Python 3.9.4
Jinja version: 3.0.0

@amy-lei want to take a look at this one?

I ran into the same error.
Template segment in question:
  {%- set example_tags_colored -%}
<p>
  {%- for color in ('info', 'success', 'warning', 'danger') %}
  {{ render_tag(color, class='color-{}'.format(color)) }}
  {%- endfor %}
</p>
  {%- endset %}


Publish 7.5-20220608002841+0000

Publish 7.5-20220608002841+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Thanks for reminding me!
It's done now.


Building of Facilities not working.

It sends the command to the server, planet_id and the correct id for the RF (14), but it doesn't build it.
It works with Buildings and Ships, but not for Facilities?
ogame.build(planet_id, Buildings['RoboticsFactory'])
Seems Facilities is ignore, but should be grouped together with Buildings when building.

change line 384 to:
if building_id not in constants.Buildings.values() and building_id not in constants.Facilities.values():
change line 418 to:
if object_id in constants.Buildings.values() or object_id in constants.Facilities.values():


Implement additional cli views for the API client tool

Bring the Turbinia API client cli tool to feature parity with the existing turbiniactl tool.
Specifically, we need to port the --workers and --statistics views.

We might need or want to include some of the other filters like --days --user too.


Enhance docs to clarify end signal value handling in "complex" cases

#105 documents end signal value handling in simple cases, but some stream methods behaviour on end signal value is not obvious, so I open the issue for discussion on those.
Open questions:

does generate treat return (not yield) value from generator as end signal value?
what happens with stream1 end signal value in concat?
does map apply f on end signal value?
does constant replace end signal value with the constant?
does scan include end signal value in the computation or emits it unchanged or discards or it can be influenced?
does flatMap emit end signal at all? if so - which or computed in what way?
same for concatMap and ap
does timestamp decorate the end signal value the same way as it does normal values?
is the tap handler invoked for end signal value?
can filter filter out the end signal value?
same for distinct, distinctBy, slice, take, skip, takeWhile, skipWhile, during
should endSignal stream value in until be taken as end signal value for the result stream?
how does reduce treat the end signal value?
is it OK that drain emits the end signal value in the returned Promise?
how does combine work on end signal values?
same for lift, sample, sampleWith, zip, join, await, throttle, debounce, delay
does the stream from switch emit end signal value of the current stream?

I will try check by myself when I find a spare minute, but for some there is a need to specify the behaviour upfront to verify if they behave ok.
In addition to that should it be mentioned explicitly that some operations (e.g. startWith) do not influence end signal value?

Ok. I have already investigated most of the questions, but need to agree on the wording. My picks in square brackets:

Is it fine to use 'end signal value' as the term for end signal value :)? [yes]
Should it be explicitely stated that end signal value is null? [yes]
If so should it be null or void 0 in the docs? [null - but really unsure]
Should it be explicitely stated that an operation does not touch end signal value? [yes]
If so should it be mentioned for operations that create infinite streams? [no]

For now the changes will be only to the docs. I feel that there is a need to have them unit tested, but will not find time for this shortly. I'll document the current state so if anything does not behave as expected it will be a good point to fix it. Expect the commits soon.

Hey @maciasello, this is really great.  I'll try to answer some of the questions.  Starting with the 3 most recent:

Is it fine to use 'end signal value' as the term for end signal value :)?

Yes.

Should it be explicitely stated that end signal value is null?

Typically, it will be undefined.  We could potentially make a blanket statement that unless otherwise noted, the end signal value will be undefined.  That could be shown as -a--b--|in stream diagrams, which is a nice visual distinction with your idea of showing-a--b--|x|` when the end value is something other than undefined.

If so should it be null or void 0 in the docs? [null - but really unsure]

undefined rather than null.

Should it be explicitely stated that an operation does not touch end signal value? [yes]

Another option would be to make a similar blanket statement: unless specified, an operation will not change the end signal value.

If so should it be mentioned for operations that create infinite streams? [no]

Right, by definition, an infinite stream has no end value.  No need to specify, though another blanket statement to that effect seems perfectly reasonable.

For now the changes will be only to the docs. I feel that there is a need to have them unit tested

Great, yes, I agree the docs are a good place to start.

We decided to deprecate the end value.  It turned out not to be composable in many situations, including common ones like take.  The end value is always undefined in @most/core and will follow suit in most 2.0.
Please feel free to reopen if there's more to discuss or there's an approach to end values that may solve the composability issues.


[MS Teams] Node.js: Sign-in Card link not working in Teams

In Node.js bots, running in Teams, the Sign-in button / link is not working.  Works on other channels.
Using sample: node/cards-RichCards

Hey Richard,
do you have any update regarding this issue? I can confirm that signin button still doesn't work in Teams, however works in test chat on dev.botrframework.com.
Thanks.

Has there been any news on this?  It doesn't work for C# bot either.

We filed a bug on this.  The button action "signin" is not supported in teams.  If you change the button type to "postUrl" (which in effect is what signin does anyway), you can get the Signin card to work.

thanks for the update @RichMoeMSFT

I can't seem to find postUrl in reference documentation (https://docs.botframework.com/en-us/node/builder/chat-reference/modules/botbuilder_d.html) or code (https://github.com/Microsoft/BotBuilder/search?utf8=✓&q=postUrl&type=)
Am I missing something or are you referring to openUrl?

My bad, yes openUrl.  Fixed above as well.

@RichMoeMSFT, I tested openUrl in MS Teams Desktop and it works fine.

But i have checked in MS Teams Mobile app(ios) i just sends a "sent a card" response, and in android device is a blank response.

for anyone that comes across this post, I have a simple implementation for both Node and C# in #4768

I still get this error with personal chat. Apart from testing in team, is there a way to either fix or hack around for now?

It seems my domain was yet in the valid domains


fix(curriculum): make expected result format in instructions and tests match

Unifies instructions and tests to require calculating representation for n.
Changes sample solution to return integer instead of string.
Previously challenge calculated, in the background, representation of numbers up to 20 (inclusive), I've changed that to individual tests. Doesn't that make too many tests?
Partially related to #40896.
Tested on local fork.

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #40763

Hey @gikf, we have a chat server where we discuss things if you want to join.

@moT01 :+1:  I'm there, but with quite different username - sanity


Extended healthcheck

By popular request, we should extend the health endpoint to report any kind of potential failure.

During a discussion it was decided that the performance impact of doing the extended health check properly is not worth the effort.
Doing this in a lightweight fashion is duplicating the information already gathered in the /metrics endpoint and the logs.
Instead it is recommended to use the provided JSON logging facility to produce a named pipe to a program which will monitor and produce the health check reporting in a dynamic fashion specific to each deployment. We found that something which is symptomatic of a problem in a blockchain with three users is valid behaviour in a blockchain with a thousand. As such, the /health endpoint is going to return one value only for the time being.


no one can see my cosmetics

i downloaded this mod for one reason, to show off my cosmetics. but people think im crazy or lieing so if you can, fix or add this feature.

this is not a bug, it says client-sided only witch means you can only see it


length gives wrong answer on Categorical values

This should give 3 but it gives 1.
length(RLEVector(CategoricalArray(['a', 'a', 'b']))) # 1

I see the issue. It seems that CategoricalArray is not an Array and CategoricalVector is not a Vector
CategoricalVector <: Vector # false
So the RleVector constructor thinks it has been given a scalar and makes an RleVector with one thing in it, that CategoricalArray.  I think this means that RleVectors can't support CatigoricalArrays without a lot of special-case code. I don't know when I'd have time to make those changes, but I'd be happy to consider a PR.

Why use Vector in the signature instead of AbstractVector?


bug when switch between landscape and portrait in ios 11

I downloaded and run the example but in ios 11 it has bug when i switch between landscape and portrait like this
https://ibb.co/jPc5um
https://ibb.co/fPew0R

I've noticed the same problem in iOS 12. Scrolling the window seems to help.


Missing 'export' keyword in blog tutorial

A small correction regarding the export of a type

This PR isn't adding anything except for your name to contributors.yml, so I think it can be closed now?

@red17electro This PR isn't adding anything except for your name to contributors.yml, so I think it can be closed now?

Looks like the typo was already fixed in previous commits. Sure, let's close it.


Zl/arccell to arcswap

[ ] builds off Cargo/lib changes from @drunkirishcoder's https://github.com/williamofockham/NetBricks/pull/71. Merge that first and I can rebase accordingly.

Removes the need for crossbeam for now, as arccell was deprecated due to issues: crossbeam-rs/crossbeam#160 --- and move to arcswap lib: https://docs.rs/arc-swap/0.3.11/arc_swap/index.html.

Closing in favor of https://github.comcast.com/occam/board/issues/160.


GetPathsToDelete returns wrong type for DeleteFiles

According to the readme I should be able to delete like this:
params := services.NewDeleteParams()
params.Aql = utils.Aql{
	ItemsFind: query,
}
params.Recursive = true

pathsToDelete, err := rtManager.GetPathsToDelete(params)
rtManager.DeleteFiles(deleteItems)

But instead I have to convert the type coming from GetPathsToDelete like so:
params := services.NewDeleteParams()
params.Aql = utils.Aql{
	ItemsFind: query,
}
params.Recursive = true

pathsToDelete, err := rtManager.GetPathsToDelete(params)
deleteItems := make([]services.DeleteItem, len(pathsToDelete))
for i, item := range pathsToDelete {
	deleteItems[i] = item
}
rtManager.DeleteFiles(deleteItems)

Hi @elliott-davis,
Thanks for pointing this out.
We have removed the redundant DeleteItem interface, so the conversion will no longer be needed.
This change should be included in our next release, and we'd appreciate your feedback for it.


Bug: Invalid highlight color: '15'

RTFM Checklist

[X] I have searched exisiting issues / discussions
[X] I have read the Wiki including the Advanced section
[X] I have read man fzf / I am well versed in shell fzf

Operating system
Mac
Shell
zsh
Neovim version (nvim --version)
NVIM v0.10.2
Fzf version (fzf --version)
0.57.0 (brew)
Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))
--bind "alt-enter:execute(open {})+accept" --bind "ctrl-i:up" --bind "ctrl-j:down" --color=light
Is the problem reproducible with mini.sh?

[ ] My issue is reproducible with mini.sh
[X] My issue IS NOT reproducible with mini.sh
[ ] I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration
fzflua = require('fzf-lua')
fzflua.setup({
  defaults={file_icons = false, previewer = false,
    winopts = {
      preview = {
        delay = 0,
      },
    },
  },
  grep = {
    actions = { ["ctrl-e"] = { fn = require"fzf-lua".actions.file_sel_to_qf, prefix = "select-all" }}
  },
  live_grep = {
    actions = { ["ctrl-e"] = { fn = require"fzf-lua".actions.file_sel_to_qf, prefix = "select-all" }}
  },
  files = {
    actions = { ["ctrl-e"] = { fn = require"fzf-lua".actions.file_sel_to_qf, prefix = "select-all" }}
  },
})

Describe the bug / steps to reproduce
When executing :FzfLua files, i get this error:
Error executing Lua callback: ~/.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/core.lua:245: ~/.loca
l/share/nvim/plugged/fzf-lua/lua/fzf-lua/win.lua:539: Invalid highlight color: '15'
stack traceback:
        [builtin#36]: at 0x0101221070
        ~/.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/core.lua:245: in function <~/.local/share/nv
im/plugged/fzf-lua/lua/fzf-lua/core.lua:223>
        ~/.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/cmd.lua:35: in function 'run_command'
        ~/.local/share/nvim/plugged/fzf-lua/plugin/fzf-lua.lua:12: in function <~/.local/share/n
vim/plugged/fzf-lua/plugin/fzf-lua.lua:11>

This started appearing after upgrade to most recent version, and in particular, is caused by this commit: https://github.com/ibhagwan/fzf-lua/commit/f07f0d310c12cbd62ab48148cd760cfa606e8117.
If i add scrollbar = "float" to winopts.preview table in the fzf-lua config, the problem is gone.

Can you use :FzfLua highlights and follow FzfLuaScrollBorderFull (if hl is linked, follow to the the definition) and let me know what’s the fg/bg for the group?

@vitvly, should be fixed with https://github.com/ibhagwan/fzf-lua/commit/1511da02661654caeb1bca9a1871e2b7731f5836 - let me know?

@ibhagwan unfortunately, doesn't seem to work - has no effect on the behaviours described above.

@ibhagwan unfortunately, doesn't seem to work - has no effect on the behaviours described above.

Alright, so can you tell me what's the highlight you're getting for FzfLuaScrollBorderFull as the issue lies there.
Use float to get fzf-lua working and use :FzfLua highlights to explore and let me know the fg/bg and I'll fix it.

With the most recent code, i still cannot run :FzfLua highlights, it throws the same Invalid highlight color: '15' error, even with scrollbar="float". Is there another way for me to fetch the highlight groups?

With the most recent code, i still cannot run :FzfLua highlights, it throws the same Invalid highlight color: '15' error, even with scrollbar="float". Is there another way for me to fetch the highlight groups?

Can you show me the exception line of code? with float it should never get to the code that failed in the OP.
You can proabably also workaround this by setting :colorscheme default but then we won't know which hl group is causing the issue :-)
Which colorscheme are you using?

@vitvly, I believe I found the exact source, you don't have termguicolors enabled - https://github.com/ibhagwan/fzf-lua/commit/304253e4c637fd5fc92cbc50707993130615808a should solve the issue.
Please reopen this issue if it doesn't.


send extrinsics without waiting for finalization

In order to send a high frequency of xt we need a non-blocking way to send extrinsics.
caveat: It's not enough to return after the "ready" msg. The problem is that the nonce needs to increase before the xt is included and the nonce is updated on-chain

helpful debugging with txpool: add ltxpool=debug to node launch

The following upstream PR should fix this:
https://github.com/paritytech/substrate/commit/9e52443bfc5cd3e204351f8872aeca83a304a3cf
We'll need to upgrade...


support browser exclude ("node-module": false)

copied over from: https://github.com/facebook/react-native/issues/2202
hopefully it'll get more love here :)
{
  "browser": {
    "some-module": false,
    "./some-file": false
  }
}

in browserify / webpack require('node-module') for an excluded module returns an empty object {}

breaking test and a possible implementation: https://github.com/facebook/node-haste/compare/master...mvayngrib:exclude
not sure it's the best way to implement it, but if it looks good to you, i can make a PR

A lot of packages published on npm use this pattern to tell bundlers how to pack the browser version. Happy to see it supported in React Native.

Hey! Cool!
Good to see you are still hammering away on better module support, it's much needed =)
I also implemented browser exclude in my pull request here:
https://github.com/facebook/node-haste/pull/46
Do you mind checking which one is better / provide some feedback?
Also, I am having A LOT of trouble creating a test that shims a package (actual-empty-file)
It would be great if you have some pointers for me, I feel like I tried everything already, probably looking over something obvious...

@vespakoen awesome! I haven't really had time to work on this other than copy my PRs over from react-native, glad to see you're still on it


ncp: Add support for fetching MAC counters.

This change adds several new Spinel counter properties and a new
CAP_COUNTERS capability. These can be used by the host to fetch
the counter values for debugging purposes.
This commit also addresses a few style issues.
This is OpenThread side of the work for issue #199

Please don't merge until I've confirmed that this functionality is behaving correctly with the associated support for wpantund (coming shortly).

Ok, I've added support for this to wpantund and confirmed that it appears to be working:
wpanctl:utun6> get
...
NCP:Counter:RX_ERR_BAD_FCS = 0x00
NCP:Counter:RX_ERR_EMPTY = 0x00
NCP:Counter:RX_ERR_NVLD_SADDR = 0x00
NCP:Counter:RX_ERR_OTHER = 0x00
NCP:Counter:RX_ERR_SECURITY = 0x00
NCP:Counter:RX_ERR_UKWN_NBR = 0x00
NCP:Counter:RX_PKT_BEACON = 0x00
NCP:Counter:RX_PKT_BEACON_REQ = 0x00
NCP:Counter:RX_PKT_DATA = 0x00
NCP:Counter:RX_PKT_DATA_POLL = 0x00
NCP:Counter:RX_PKT_FILT_DA = 0x00
NCP:Counter:RX_PKT_FILT_WL = 0x00
NCP:Counter:RX_PKT_OTHER = 0x00
NCP:Counter:RX_PKT_TOTAL = 0x00
NCP:Counter:TX_ERR_CCA = 0x00
NCP:Counter:TX_PKT_ACKED = 0x00
NCP:Counter:TX_PKT_ACK_REQ = 0x00
NCP:Counter:TX_PKT_BEACON = 0x00
NCP:Counter:TX_PKT_BEACON_REQ = 0x10
NCP:Counter:TX_PKT_DATA = 0x07
NCP:Counter:TX_PKT_DATA_POLL = 0x00
NCP:Counter:TX_PKT_NO_ACK_REQ = 0x17
NCP:Counter:TX_PKT_OTHER = 0x00
NCP:Counter:TX_PKT_RETRY = 0x00
NCP:Counter:TX_PKT_TOTAL = 0x17

We can go ahead and merge this when the review is complete and travis passes.

I've already merged support for this into wpantund.

LGTM 👍


Issue#16: Ability to add audience as array of strings

Ability to add audience as array of strings

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Umamaheswararao Meka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[REQ] Change Zeus x27 skin category

As you can see in CS2 itself, the Zeus x27 is not in the Pistol category. I wonder if it would be more interesting to leave it in its own category, like in CS2, Equipment/Utilities?

It's some kind of a pistol.


Update Pages “index”

Automatically generated by Netlify CMS

👷 Deploy Preview for nervous-engelbart-a15395 processing.
🔨 Explore the source changes: 678d8f2fcb2080533aa6f02a1a7f70c74a2ace02
🔍 Inspect the deploy log: https://app.netlify.com/sites/nervous-engelbart-a15395/deploys/61a407cbc9c8c800078a808a


Feature Request: float labels

It will be nice to have something like this
link
What do you think?

I think Semantic-UI not interested on UX design, it cant include all Animations and Effects !!
Semantic-UI is for UI, and include just the important and must useful things, @jlukic working hard to fix bugs and enhancing Docs.
you can find cool things in the web, just google, example:
http://tympanus.net/Development/TextInputEffects/index2.html
and use theme with SUI.
As I said, I think that what SUI is.
PS: Im sorry for my bad english language, but you catch the idea.

This isn't in the scope of the project. Please make specific suggestions for new types of user interface components or specific feature enhancements to existing components. If you would like to share interesting links to discuss use our chat room.

+1 http://bradfrost.com/blog/post/float-label-pattern/


Redirect to correct urls

Fixes #3569 .
Fix redirect for

[x] Caltech
[x] Omniglot
[x] CelebA
[x] WIDERFace

For google drive in the case of CelebA and WIDERFace it simply redirects to www.drive.google.com/<url>/edit instead of www.drive.google.com/<url>
I have modified the file id and added /edit to it. Hope it works.

Feel free to merge this. I have fixed the lint and changes look fine from my side :smile:

No worries @pmeier .
I will revert changes and try to fix datasets.utils.download_file_from_google_drive() to accept /edit route too.

I will [...] try to fix datasets.utils.download_file_from_google_drive() to accept /edit route too.

Since datasets.utils.download_file_from_google_drive() builds the correct URL from the ID, maybe we can simply add it there.

I had second thought on adding /edit
If the dataset owner removes access and makes it read-only (no access to /edit) then it might cause future problems.
So let's play safe and avoid it!

@oke-aditya Thanks for looking into that!

If the dataset owner removes edit access and makes it read-only (no access to /edit) then it might cause future problems.

I didn't know that! Is there documentation that describes this, i.e. the /edit postfix in case the file is hosted as read-only?

So let's play safe and avoid it!

Completely agree.

Hey @pmeier  I did look a little if /edit would mean edit access. Actually no, it does not mean it.
I will show an example here.
Here is file on Gdrive
Link1 = https://drive.google.com/drive/folders/1rb8fyciuy-uYIPoK2D_wKtaJBGLDxiuH?usp=sharing
Link2 = https://drive.google.com/drive/folders/1rb8fyciuy-uYIPoK2D_wKtaJBGLDxiuH/edit
Link3 = https://drive.google.com/drive/folders/1rb8fyciuy-uYIPoK2D_wKtaJBGLDxiuH/view
Link4 = https://drive.google.com/drive/folders/1rb8fyciuy-uYIPoK2D_wKtaJBGLDxiuH
Try opening all the links in incognito / private windows (it is completely safe the photo in it is Ubuntu Wallpaper permissive license).
Link1 and Link4 would open and work file. But Link2 and Link3 won't. So it always safer to redirect to link4 which is base url.

@oke-aditya Awesome, thanks a lot for the investigation!


Added libraries for easier setup

Lol way to get +87k lines of code in someones elses project :DDD

LOL!

The easier way to fix this would be to just add the .vcxproj files to the gitignore so not everyone is uploading their custom directories.

I used VS macros for directories so it should work on every PC

Yes im not adding these to my project, sorry. If someone needs help setting up the libraries they can ask, but theres no reason to include them here as well.
As Zeroeh said, adding .vcxproj files to gitignore might be best.


End tag  is not required

I was previously on v1.5.5 via NuGET and attempting to call HtmlDocument.Load on properly formed XML was giving me an exception. There's a ... tag in the document that I'm deserializing, and it contains a fair number of properly formatted ... tags. Each one of these causes a parse error of "EndTagNotRequired". This seems to be something that other people have encountered as well. Updating to the latest (v.1.6.5 on NuGET) has not resolved the problem.
For reference, the page that I'm deserializing is https://archiveofourown.org/works/search. If you would like to see the code that I'm using to repro this error, it can be found here (the specific function is HtmlUtils.ParseHtmlDocument).
I love this library a whole lot, and a proper fix or workaround for this would be amazing in terms of allowing me to continue using this! Thank you so much!!

Hello @ahlec ,
Thank you for reporting. I will for sure look at it.
Best Regards,
Jonathan

Hello @ahlec
The v1.6.6 has been released.
We changed the behavior how option tag was handled. Please let me know if you find any issue.
Best Regards,
Jonathan

Help us to support this library: Donate

Thank you so much!! The speed and the response is VERY appreciated! Thank you for all of your hard work!


Crash when call EasyHub.dismiss() immediately after EasyHub.showHub()

Demo code
EasyHub.showHub();
await EasyHub.dismiss();

Crash:
Exception has occurred.
NoSuchMethodError (NoSuchMethodError: The method 'pop' was called on null.
Receiver: null
Tried calling: pop(Closure: () => Null))

EasyHub.showHub();
await doSomethings();
await EasyHub.dismiss();

The reason why I need to call EasyHub.dismiss() immediately after EasyHub.showHub() is that sometimes the doSomethings() return very fast in current run loop.


[SPARK-21845] [SQL] Make codegen fallback of expressions configurable

What changes were proposed in this pull request?
We should make codegen fallback of expressions configurable. So far, it is always on. We might hide it when our codegen have compilation bugs. Thus, we should also disable the codegen fallback when running test cases.
How was this patch tested?
Added test cases

Test build #81377 has started for PR 19119 at commit b96da49.

Test build #81377 has finished for PR 19119 at commit b96da49.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81377/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #81383 has started for PR 19119 at commit b96da49.

Test build #81383 has finished for PR 19119 at commit b96da49.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81383/
Test PASSed.

Hi, @gatorsmile .
Could you trigger Maven build, too?

Sure

retest this please

Test build #81398 has started for PR 19119 at commit b96da49.

Test build #81398 has finished for PR 19119 at commit b96da49.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81398/
Test PASSed.

Thanks! Merging to master.


New SMS flow -> use SMS gateway / rpi

We should stop using twilio and use a real SMS gateway to send SMS, since too many problems with sending SMS's over Twilio. (UAE doesnt work etc)

more info about UAE sms's for twilio:
https://www.twilio.com/guidelines/ae/sms

see #389

Closing this issue since there is no phone verification anymore used inside the app.


KMZ loads fine, onFeatureClick callback sometimes brings null features

Summary
Loading KMZ works perfectly but onFeatureClick callback, sometimes brings null property.
same kmz with same feature all the time, sometimes it says that property is null.
actually,
if (!feature.hasProperties()){
                        Log.e(TAG,"no properties.");
                    }

triggers
Environment details

Device (ARM based)
android 8.1
com.google.maps.android:android-maps-utils:1.3.3

Steps to reproduce
seems kinda random.thats why i cant debug it
Code example
  mLayerListener = new GeoJsonLayer.GeoJsonOnFeatureClickListener() {
            @Override
            public void onFeatureClick(Feature feature) {
               Log.e(TAG,feature.getProperty("description");
            }
 }
 mLayer = new KmlLayer(getMap(), *a file stream*, baseActivity);
 mLayer.addLayerToMap();
 mLayer.setOnFeatureClickListener(mLayerListener);

Are you able to share the .kmz file to help us repro this?

https://drive.google.com/file/d/1Yiyn0U2ztmUt0BAm-jN-Qph6ysqWskDn/view?usp=drivesdk

In order to reproduce, load it, check the feature, clear the map, remount kml, recheck feature.
Repaet

i also implemented an asynctask for rendering (constructor) and it has the same result...
randomly i get no property
(Caching issue?)

Seems like the issue is that the KMLLayer does not deterministically add KMLFeatures in the same order. Since your KMZ file contains overlapping polygons, this presents as an issue wherein tapping on the same region clicks different polygons (depending on which polygon was added last in an overlapping region). You can validate this by checking out the KML demo in the demo app on my branch chris/fix/742.

Any ideas? Imma also build library from scratch in order to find something

good evening and sorry for the delayed answer.
No i do not have control over the kml. Sorry


Move to the smaller, cargo-team maintained home crate

Can you elaborate a bit what problem is solved by using this dependency instead of dirs?

The dirs crate is a relatively big dependency that has been abandoned in the past for a simple function that is now maintained by the cargo team. It also now inherits an MPL-licensed dependency, which is not allowed in certain environments.

Fair enough. Thanks and merged!


Infer resource kinds from support annotations

I thought this might be a good feature to have while using the library. Android support annotations provide similar functionality to the kind annotation parameter so instead of duplicating the info, this change-set enables looking at the support annotation (which people should be using anyways) and setting kind to resource type if the support annotation used is one of the @Res types.
The one additional special case is the @ColorInt annotation. Which this also checks for and sets kind to COLOR if it's used.
What are your thoughts?

Aside from @ColorInt, how would this work for other kinds? Definitely get the appeal of @ColorInt, but I feel like the others wouldn't really make sense to reuse.
public class A {

    @StyledAttr(R.styleable.BarberView_stripeWidth)
    @DimenRes
    int stripeWidth;    // The IDE will now think this is a resId but code will use it as the evaluated dimen value?

}

This is only avoiding duplicating info between a Kind.RES_ID annotation parameter and a @Res support annotation.
// Case A
@StyledAttr(R.styleable.BarberView_stripeWidth)
@DimenRes // IDE uses this but barber doesn't
int stripeWidthResId; // resolves to.a.getInt
// Case B
@StyledAttr(value = R.styleable.BarberView_stripeWidth, kind = Kind.RES_ID)
@DimenRes
int stripeWidthResId; // resolves to a.getResourceId

Without the changes case A is broken (even though it semantically makes sense) and you have to add the explicit Kind.RES_ID parameter as in case B to get it to work with Barber.
With the changes, Case A and Case B are equivalent. Barber infers that since the int is annotated with an @DimenRes annotation that the user intends it to be a resourceId and resolves to that case.

Ahhhh I see what you mean now. In that case, yeah this looks good. I'm to think if there's any case where they might want a non-@_Res annotation for a resource ID, but none coming to me right now. One favor to ask though, would you mind rebasing and opening a PR against the z/resolvedattr branch? That's kind of acting as the develop branch right now

Rebased

This PR is still pointing to master, you'll have to close this and open a separate one pointing to the branch I mentioned to merge into that one.

oh sorry... will do.


fixes/enhancements in webhook action and spy plugin

fix webhook default host
fix generated actions by spy plugin
add 6h/12h/1d watcher repeat interval in spy plugin
set query index before body in spy plugin

Thanks @fbaligand

Nice to see you appreciate !

Absolutely, we're thankful and proud to have you as part of the project :)


Refactor teams to match reorg.

Reorganize handbook documentation to match reorg of June, 2023.


MAF-006: [LOW] Scripts are loaded from external third party

The application includes the load of external scripts from a third-party.
Technical description:
Including third-party scripts, such as those from Cloudflare, can pose security risks if the scripts are compromised. It is essential to ensure the integrity of these scripts and monitor for any changes.
Note that the integrity attribute and anonymous crossorigin have already been configured in the original code snippet, which helps protect against malicious attacks by verifying the integrity of the downloaded scripts. However, further improvements can be made by configuring a more comprehensive Content-Security-Policy (CSP) and generating a unique nonce value for each request to include in the script tags. These enhancements will provide additional layers of security for your web application.
Impact:
External scripts can be a vector for introducing malicious code if compromised, potentially leading to site-wide security breaches.
Recommendation:

[ ] Ideally, host critical scripts locally to minimize the attack surface by maintaining control over the files within your own infrastructure.
[ ] Implement a Content Security Policy (CSP) to restrict the sources of external scripts.
[ ] Generate a unique nonce value for each request and include it in the nonce attribute of the script tags. This helps prevent unauthorized script execution by ensuring that only scripts with the correct nonce value are executed.

By implementing these improvements and best practices, you can enhance the security of your application when including third-party scripts from Cloudflare or other sources.

#2259 was an attempt to fix some of this. The only third party scripts are cocoon and selectize, which I couldn't get working any other way, but it must be possible.


⚠ Bofrost.lu has degraded performance

In cb922d7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1145 ms

Resolved: Bofrost.lu performance has improved in c639954.


update all.json

Site
Urlscan

activatedappserver.live
https://urlscan.io/result/3ca71cfd-0265-42ce-8c52-74d522e337c4/dom/

app.webauthsaccess.com
https://urlscan.io/result/b0874415-a925-41a1-9cee-f68dea7f43c1/dom/

bridge.smartblockprotocol.com
https://urlscan.io/result/737511a2-6326-4e62-bd39-ae2cc96c029a/dom/

eheroapp.feibanana.com.br
https://urlscan.io/result/d6427d6b-c1ed-47e2-b13f-0cae51199ae1/dom/

securewalletconnect.comassets.xyz
https://urlscan.io/result/cb97d83e-2b93-426a-8d33-c97eed472cd6/dom/

smartcointechsolution.xyz
https://urlscan.io/result/5bf6fa7f-a806-4ccb-9f8b-1dd9e91a8cf0/

syncvalidate.net
https://urlscan.io/result/b3438e2c-d909-403c-ac87-32ccc8683532/dom/

trustwalletsupport.ml
https://urlscan.io/result/8ea2453d-b6b1-41e5-9c4e-089a10fc458e/dom/

walletconnectsyncr.netlify.app
https://urlscan.io/result/8e2c8fca-cac2-455d-b9cb-563f44063d67/dom/

webcollabland.com
https://urlscan.io/result/c086d63f-b30b-4c93-a52e-c8030c2aca3e/dom/

not blocking top-level com.br since not sure how it works, probably will block other non-malicious sites as well?

review ready!


Create a .dxf Input Module

In order to simplify the process for users importing obstacles, there should be a module for utilizing .dxf files. This would allow users to draw or trace a map in LibreCad (or OpenCAD) and easily import it for use within VIPRA.

module has been added


Fixed several more typos in userguide

I don't think any of these will be controversial.  But if you want me to split up the changes, I can.

Thanks!


Fix Typo in apimachinery README

Thanks for submitting the PR!
However, this needs to go against the main kubernetes repo. Created https://github.com/kubernetes/kubernetes/pull/57404.
/close


Add task to copy necessary extra files over from install medium or possibly NAS

added NAS file copy task...


improved dynamic import doc inside code-splitting

PR #2464 has been open for long time and has undone changes.

@jamesgeorge007 friendly ping

Closing as stale.


KAFKA-5954: Correct Connect REST API system test

@kkonstantine, would appreciate a quick review.
@ijuma, fixed the system tests and verified by running all Connect system tests locally.

+1


welcomeView extension point: Support order

The internal VSCode API to add widget to a welcome view supports providing a desired order:
https://github.com/microsoft/vscode/blob/3db45fbd420ec9860b4a94211e499bb6527c7e52/src/vs/workbench/common/views.ts#L85-L88
This is not exposed for extensions it seems:
https://github.com/microsoft/vscode/blob/b9bb22d1ba99fc29e4a30d95ff5baffa98bd1969/src/vs/workbench/contrib/welcomeViews/common/viewsWelcomeExtensionPoint.ts#L17-L23
At Google, having this would allow us to convert some patches to properly using the extension API. Would you be open to adding that? I would be happy to send a PR if you agree this should be exposed.

I actually just found there is already a "secret" way to do this:
https://github.com/microsoft/vscode/blob/277ffee01fdcf7fbb235ecfb40798bc3fd2fc128/src/vs/workbench/contrib/welcomeViews/common/viewsWelcomeContribution.ts#L69
I did not find any docs on this, but it seems using a group like
  "group": "some_group@<some order>"

Let's you define an order. I will use that for now. Please consider documenting this somewhere.


chore(Data/Matrix): reverse import order of Data.Matrix.Basis and LinearAlgebra.Matrix.Trace

Previously, the definition of Matrix.stdBasisMatrix depended on the definition (and many properties of) the trace of a matrix. I think that dependency should be reversed, since stdBasisMatrix is otherwise a much less heavy definition, import-wise.
This was spotted while adding assert_not_exists statements to #18964.

bors merge

since stdBasisMatrix is otherwise a much less heavy definition, import-wise.

Arguably both stdBasisMatrix and Matrix.trace are lightweight-enough definitions that they could be put in Data/Matrix/Basic.lean if desired! I'd claim the problem here is that Mathlib.LinearAlgebra.Matrix.Trace has very heavy imports, perhaps suggesting that Matrix.trace itself should be moved to Mathlib.Data.Matrix.Trace.


[BUG] Type error in AzureDataFactory-AzureMLExecutePipelineActivityTypeProperties-mlPipelineParameters

API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/6bab1a8cc4ea7b5368da89f2a00f15027392e703/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json#L7639
API Spec version
2018-06-01
Describe the bug
Original customer issue: https://github.com/Azure/azure-sdk-for-net/issues/45401
It's possible that the response value contains object type instead of string.
The x-ms-format should be dfe-key-object-value-pairs
Expected behavior
"x-ms-format": "dfe-key-object-value-pairs"
Actual behavior
"x-ms-format": "dfe-key-value-pairs"
Reproduction Steps
Call GetDataFactoryPipeline on a Pipeline with AzureMLExecutePipelineActivity that contains expression parameter
Environment
No response

@wanyang7 Please help take a look, thanks.


Publish on MavenCentral

Hi,
JCenter will shut down on May 1st.
Could you please publish this library on mavenCentral to remains usable in gradle?
https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
Thanks

Hi!
sure, will do as soon as I have a few time :-) thanks for notifying!

I found this PR on the ReLinker repo, which shows the migration from jcenter to MavenCentral, so I put it here for reference, in case it helps with the migration.
https://github.com/KeepSafe/ReLinker/pull/81

Hi again!
I've checked that the dependency is still available for download through jcenter(), so users won't be affected (yet) until February 2022. I'll start migrating it in the meanwhile.
Thanks for the reminders! :slightly_smiling_face:

Hey @voghDev,
Any news on this? Can I somehow help?
Thanks

@voghDev this is may last dependency that is not on MavenCentral, can I somehow help on this? 🙂

Sure!
I haven't had time to start working on this. Do you know any reliable blog post or various blog posts where the process is described? so once I start with it, I have accurate information to read and get some background before performing the task.
Thank you!

Hi,
Here are two blog posts that guide through the migration to Maven Central.
https://getstream.io/blog/publishing-libraries-to-mavencentral-2021/
https://proandroiddev.com/publishing-your-first-android-library-to-mavencentral-be2c51330b88
And in case you need it, here are more helping material.
https://www.marcogomiero.com/posts/2021/move-libray-jcenter-to-maven/
https://www.adyen.com/blog/migration-from-jcenter-to-maven-central
https://blog.sonatype.com/what-publishers-need-to-know-about-migrating-from-jcenter-/-bintray-to-the-central-repository
https://chris.banes.dev/publishing-to-maven-central/
https://jeroenmols.com/blog/2021/03/24/migrate-artifacts-mavencentral/
Hope it helps.
Thanks

It seems this library published in JitPack.

I would prefer to have this library published on MavenCentral, since it's the default repo in Android Studio, and some teams may have restrictions that don't allow them to add libraries from jitpack.

@voghDev any news on this? This is my last dependency that is not available on MavenCentral, so it would be very nice to completely remove jcenter 🙂 thanks

Hi @4brunu !
I've been struggling with this for weeks, but haven't been able to publish the library. It is almost done, all the steps are completed, but the gradle script that executes the publishing is not recognizing Android classes and some annotations. That's what I need to solve to complete the publishing. Sorry for the delay!

Thanks for your work and thanks for the feedback 🙂

Hi @voghDev, do you have any news on this? 🙂 thanks

Hi @voghDev any news on this? really need this library on mavenCentral, thanks

Hello, you can use it with jitpack
allprojects {
		repositories {
			...
			maven { url 'https://jitpack.io' }
		}
	}

dependencies {
	        implementation 'com.github.voghDev:PdfViewPager:1.1.2'
	}


Replace yiq contrast by wcag official algorithm

Following @mdo PR for color update : https://github.com/twbs/bootstrap/pull/22836
Many thanks for the color contrast mixin which check the font color according to the background for badges only at time. But yiq is not the official wcag and doesn't give the same result on some colors (e.g with blue #527edb yiq set text color to white where official wcag lum set it to black.
I propose a SCSS adaptation of the HTMLCS JS solution. Need to add a dependency to sass-math-pow.
I hope this solution will be helpfull. Let me know

you should update our shrinkwrap because you added a new dependency with npm run maintenance-shrinkwrap

Yes I've seen it. I will update till 1hour

No problem I've many coffee :-)

LGTM but I'm not a SASS expert. @mdo et al, feel free to merge if this looks kosher to you.

Would be nice to have @mixin color-yiq() be a function that returns a value instead of printing a css declaration so we could use it in Sass variables.

yes, that's my final idea, evolve that mixin to create a generic one that return a comparison between two colors. Or add in parameter output colors

Need to add a dependency to sass-math-pow.

Not a fan of the dependency here. Is there another solution we could try? And if this changes what is output on our components, we'll need to revisit more things.

if this changes what is output on our components, we'll need to revisit more things

I believe functionally the output is the same, just that it flips between light and dark text at a better calculated threshold which matches up with WCAG 2's requirements.

Yeah, I mean visually as much as the compiled code :).

Visually it'll be the same, except at the point just on the cusp between where light or dark would be better. There, it'll flip at a slightly earlier/later point, so yes for certain background colors it will be visually different.

I understand and agree that adding a sass dependency is not fun. For @mdo the solution could be to Copy/paste source code directly in bootstrap utilities, because I don't think that pow expression will change in the time.
For visual consistence, would be possible to add optionnal input like :
color-yiq($color, $chalenging-color-list, $light-fallback, $dark-fallback) {
Where $color will be the font or background color to check against an ordered color in $chalenging-color-list, and if none are valid then return light or dark fallback ?
for each $color in $chalenging-color-list -> check if ratio is valid, return the first valid color
if none have been return, check if light or dark fallback is better

One alternative to the extra dependency would be to use the experimental functions feature in node-sass.
const sass = require('sass')

const functions = {
  pow(base, exponent) {
    const result = Math.pow(base.getValue(), exponent.getValue())
    return new sass.types.Number(result)
  }
}

Would need some additional documentation for ruby-sass and other variants.

Hi, any news about this PR? I can update it if needed

Hello, do you have news about this issue? We would like to use WCAG contrast for color-yiq function. We tried to play with the treshold, but as it ia not the same function we can't have something perfect.

Hello,
I use it in Boosted (that's why I create this PR) But wonder that one will go into the core soon.

@Lausselloic: can you fetch upstream and rebase?

I'm afraid we can't do this. This will make bootstrap not buildable with anything else than node-sass and it will require everyone to adapt their build with this custom config.


Custom adapters with knockout.

Hello, can you please help me. Can i bind custom dataAdapter or some else with knockout? Thanks.

It's definitely possible, I'd recommend looking around on Stack Overflow or the mailing list to see how others have done it.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Shortcuts on SMD Pads

I tried Linegrinder for the first time, and it looks handy. Especially the manual drill touchdown is a very clever feature.
I used Eagle and the PCB Milling ULP before but switched now to KiCad with the need for Gcode generation.
I encounter issues with SMD pads that are shortcuts in the code.
Gerber View:

Generated GCode:

I noticed some touchdowns I have no idea why it is generated.
Overlayed Gcode with Gerber showing the shortcuts:

I tried to change some settings in LineGrinder to workaround the issue without luck.
Also, I tried the Kicad Gerber Export with and without X2 Format enabled.
carrier-ac-wifi_gerber_gcode.zip

The dots that look like pad touchdowns appear to be artifacts of the copper pour or copper fill on your PCB. They appear even with pad touchdowns disabled. There are many complex gerber operations going on in a copper pour - including the erasure of lines already drawn (gerber can do that) and it appears to be confusing LineGrinder. The isolation algorythm is always an approximation and rounding errors could leave little dots. The copper pour is not needed for isolations PCB's anyways and the conversion will execute much, much faster without it.
As for the shortcuts (the broken traces). This is clearly a problem but I cannot easily diagnose this because of all the copper fill complexity in the gerber file. Can you please generate a .gbr file without the copper fill and if the problem still exists post the new file here and I will work on it.

I removed the fill, and the "deformed pads" remain. The SMD shortcut is gone, but some are still on the two left connectors. BTW: I just noticed that the manual drill dot is missing there, these are thru hole pads.
The layout is different from the version from yesterday as I did not version it properly.

Gerber (not functional), including the KiCad 7 PCB in case you would like to tinker around yourself:
gerber-test-linegrinder-test-not-functional.zip

The SMD pad issue is definitely a bug - a quite tricky one. I can reproduce it and am working on it. It might take a few more days.

A fix for this bug has now been released in version 03.02. You can clone the source and compile it yourself or download the already compiled 03.02 binary from the website at http://www.ofitselfso.com/LineGrinder/LineGrinder.php
I have tested it on the files you sent and it seems to cure all of the SMD shortcut problems you observed. Thank you very much for you comprehensive and detailed bug report.
Please do let me know if this new release fixes the issue for you.

You are right; the original problem is fixed, but a new one surfaced with default settings:

When increasing the "IsoCutWidth" to 0,4mm (~0,015 inch) it looks okay:

The issue with enabling "IsoPadTouchDownsWanted" and the ignored rectangular pads remains not matter of the cut width:

The lack of pad touchdowns on the SMD pads is caused by the fact that they are Macros not simple apertures. The Gerber spec only has a few primitive objects - circle, oval, rectangle etc as apertures. These are "flashed" to produce a pad. More complex objects such as a rectangle with rounded corners (an SMD pad) is created by flashing multiple smaller primitive objects (four circles for the corners and then some rectangles to fill in the sides). Because they are composed of multiple objects, macros do not really have an consistent center point onto which a pad touchdown could be placed. I know the center of the SMD pad looks obvious to the eye but in the code the actual Macro origin could be pretty much anywhere and the primitives offset from that. Also there are rotations and transparencies to consider. The upshot is that it is very difficult to calculate the center of a macro in the general case and it essentially means finding the center of an area of a complex arbitrary number of graphical objects.
If a touchdown is needed on an object derived from a macro then simply placing a smaller simple hidden circular pad on or under it should generate a pad touchdown in the code and leave the Gerber traces unchanged. If this is not satisfactory please tell me a bit more about your specific use case and I will see what I can do.
The little gap is a tricky one. I have traced it down in the code and it is derived from rounding errors. LineGrinder maps all of the Gerber objects onto a grid and grids are essentially integer based. This means means things like radiuses of circles etc get rounded to the nearest grid point (like pixels on a screen). The gap is due to the grid you are using not being fine enough - LineGrinder simply does not see an intersection between the circle primitive and vector line part of the SMD macro at that point on the grid.
Fortunately this has an easy fix. Look at the top of the Settings tab. Change the "isoplot points per mm" to about 150 it is probably at the default of 78 now. This increases the number of points on the grid and essentially everything is mapped at a finer resolution reducing the rounding errors. There are some issues in here - you can change the "isoplot points per mm" setting and just open the Gerber file. However, if you change from inches to mm (or back) you need to drop and recreate your File Managers before opening the file. This awkwardness is actually Issue #2 and that whole mechanism will be cleaned up eventually.

I can confirm setting "isoplot points per mm" to 150 solves the issue.
Regarding the touchdowns, I changed the pad type to the one that works.
Thx for your quick support and detailed explanations.


input the same text but output different

Thanks for you work, and when I synthesize audio with the same text, I found that the outputs sound a little different, so I checked the inference from session.run and found that the same input leader to different output. Do you know why that happen?

I donot know what do you mean. You should run python synthesize.py --text_list <your corpus file> --name <your model name>. If sentence in  is different, the synthesized voice is different.


Balanced Parenthesis - Stack

🚀 Feature
Balanced Parenthesis problem in C++. Also suggest a separate section for stack based problems.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Balanced Parenthesis problem is an interesting problem of stack.
Pitch
Will help understand the stack data structure

Please assign me this

@shraddhavp Please assign this to me in Java

I want to do this in c++

I would like to solve this in Java, please assign

I would like to work on this in Python #1801

@shraddhavp Please assign this to me in Java

any updates @YASH01009 ?

@shraddhavp will do it soon, in a day

I can work on this issue in Java please assign.

I can work on this issue in Java please assign.

@shraddhavp @YASH01009 @pranjalshinde @Rishikeshrajrxl  can i work on this?

@shraddhavp @YASH01009 @pranjalshinde @Rishikeshrajrxl  can i work on this?