Fixed issue #4391; podman info --format '{{ json . }}'

JSON Go template format now recognized through the info action.
Fixes issue #4391

/approve

/ok-to-test

@slimjim2234 our ci requires that commits be signed.  Please do git commit --amend -s and then repush.
Although I prefer the style you're using in cmd/podman/info.go for the switch, gofmt doesn't.  Please do 'gofmt -s -w cmd/podman/info.go` and readd that, or just remove the added tabs.

Gofmt is not going to pass.  I think we are using at least golang 1.12 or 1.13, so your gofmt might be out of date.

could you add a test?

could you add a test?

What kind of test?  I have committed a small and simple test validating the "{{ json . }}" format usage.

@slimjim2234 Thanks
Other then the question to @baude LGTM

The logic for detecting whether a template is in use looks a bit weird to
me - hold off merging for a bit so I can take a closer look.
On Sun, Nov 3, 2019, 05:40 Daniel J Walsh<EMAIL_ADDRESS>wrote:

@slimjim2234 https://github.com/slimjim2234 Thanks
Other then the question to @baude https://github.com/baude LGTM
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/4408?email_source=notifications&email_token=AB3AOCAZVEA6S3R6TWUVTG3QR2MBLA5CNFSM4JHVODHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5POMA#issuecomment-549123888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCHHJYKJ5BAZYIHVKETQR2MBLANCNFSM4JHVODHA
.

@mheon Any progress?  @slimjim2234 Any chance of getting a test?

Code LGTM

/lgtm


Add ecs license check

Q
A

Branch?
master

Bug fix?
no

New feature?
no

Thank you, Michał! 🎉


nitrate dust

After doing some wiki research for a new source of nitrate dust, I would recommend a drying basin recipe of beetroot soup to nitrate dust.

I assume you need this for gunpowder. Let's also make gunpowder take a little less of this.

added beetroot soup to nitrate recipe for rustic drying basin. cheers!


Update index.md

adding mentor to LiveHD projects

@sakshi15108 I applied the suggested changes myself (including a few other minor changes). All good.


fix README version

update to npm install<EMAIL_ADDRESS>

Hi @tomByrer , thanks for catching this :) would you able to update commit message to make consistency between history?

@kwonoj Like that?

Not sure where 'that' exactly points, we use convention https://github.com/ReactiveX/RxJS/blob/master/CONTRIBUTING.md#commit-message-format, so it'll be looks like
docs(README): awesome update for readme
if there's related issue you can refer it in detail, but for this there isn't so you don't need to attach it.

nm you fix it

Hey @tomByrer, I want to thank you for your effort to contribute and apologize if you found the process frustrating. We try to keep our commit messages to an expected format because we use some automation to analyze them and use them for various purposes (mostly for changelog generation).
Again, my apologies if your experience with this PR put a sour taste in your mouth, and I sincerely hope to see more contributions from you in the future.


Explore usage of asio-grpc library

Explore usage of asio-grpc library
This could help simplifying the code and hopefully improving the performance too

Heya, I am the author of asio-grpc. Is there anything I can help you with here? Do you need any information regarding the library?

Hey @Tradias, thanks a lot for asking! As you can see, this issue is a reminder for a future research work using your library.
Currently we use asio::awaitable as C++ coroutine awaitable type and we have some code wrapping the async gRPC API into coroutines. However, such mapping occurs at the application level and just for our specific RPCs, while using asio-grpc it would happen inside the library at the infrastructure level and so we could get rid of some code not so . Moreover, your idea to wrap asio::execution_context around grpc::CompletionQueue seems really interesting to improve our threading model.
I will be back to you asking for some help when we will start working on this.

Fyi, I have started to work on a pull request that shows what code simplification and correctness asio-grpc would bring.

Fyi, I have started to work on a pull request that shows what code simplification and correctness asio-grpc would bring.

Thanks a lot, @Tradias! Looking forward to see your PR, please let me know if you have questions or any issue with our code.

Looks like this is done now :).

Closed by #326


[Chat][Feature] Send Message Status

Purpose

Introducing a MessageSendStatus to all messages. Icon will be shown beside each messages to indicate their current status to user.
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[ ] Tested for background mode
[ ] Unit Tests Included
[ ] UI Automated Tests Included

How to Test

Open...
Click on...

What to Check
Verify that the following are valid

...

Other Information

merged separate


[tools] update tools schema

Proposed changes
Issue Number: close #xxx
Update tpcds tools table customer_demographics's bucket column as its primary key column, avoid performance issue from data skew.

run buildall


Add clean.ps1 and clean.sh

#10463

That looks helpful. How about cmd? We have cmd for most other common commands.

Took your suggestion @Tratcher

Another now-standard timeout of the build. Merging since issue can't be related to these three new files.


Activity Logs

Activity Logs data under History section is empty for me. I use the dashboard for about 2 weeks. It is same from the first day.

I'm guessing you can see the activities in the Fitbit app (Today -> Exercise Days ->Week/Month)? There's probably something weird going on with Fitbit's servers.
I've heard people report the opposite, where they can see exercises on this web dashboard but not on the app. Nobody has any idea what's going on but hopefully Fitbit is looking into it.

Hey Jlai! I am also not able to see the activities in the Fitbit app (Today -> Exercise Days ->Week/Month). Wait and will see what will happen. Thanks! Have a great day!


remove accidentially commit pycache

The mlflow/pycache/init.cpython-36.pyc was accidentally commited in #39. We remove it to keep repo clean

Thanks @0wu, this LGTM!


Allowed to create models with incorrect Usage.

Pre Req - Have azure-openai-model-provider configured.
Steps to reproduce the problem:

Create a model with provider as azure-openai-model-provider, target model as dall-e-3 and usage as LLM

Model gets created successfully.
Expected Behavior:

We should not be allowed to choose incorrect usage when creating models. UI should not be showing usages that are not supported by the selected target model.

Even when we are allowed to do this from UI , server should have failed to create a model with incorrect usage.

we arent going to validate this.
Closing this issue


crash: violates the constraint of type

https://github.com/VerifyTests/Verify/actions/runs/6254973775/job/16983521929
will look into is more and add details as i find them.
[FTL] GenericArguments[0], 'System.DateTimeOffset', on 'T MaxInteger[T](System.Collections.Generic.IEnumerable`1[T])' violates the constraint of type 'T'.
System.ArgumentException: GenericArguments[0], 'System.DateTimeOffset', on 'T MaxInteger[T](System.Collections.Generic.IEnumerable`1[T])' violates the constraint of type 'T'.
 ---> System.Security.VerificationException: Method System.Linq.Enumerable.MaxInteger: type argument 'System.DateTimeOffset' violates the constraint of type parameter 'T'.
   at System.RuntimeMethodHandle.GetStubIfNeeded(RuntimeMethodHandleInternal method, RuntimeType declaringType, RuntimeType[] methodInstantiation)
   at System.Reflection.RuntimeMethodInfo.MakeGenericMethod(Type[] methodInstantiation)
   --- End of inner exception stack trace ---
   at System.RuntimeType.ValidateGenericArguments(MemberInfo definition, RuntimeType[] genericArguments, Exception e)
   at System.Reflection.RuntimeMethodInfo.MakeGenericMethod(Type[] methodInstantiation)
   at AutoMapper.TypeDetails.<>c__DisplayClass28_1.<BuildPublicNoArgExtensionMethods>b__10(MethodInfo extensionMethod)
   at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext()
   at System.Linq.Enumerable.ConcatIterator`1.MoveNext()
   at System.Linq.Enumerable.SelectManyIterator[TSource,TCollection,TResult](IEnumerable`1 source, Func`2 collectionSelector, Func`3 resultSelector)+MoveNext()
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.HashSet`1.UnionWith(IEnumerable`1 other)
   at System.Linq.Enumerable.UnionIterator`1.FillSet()
   at System.Linq.Enumerable.UnionIterator`1.ToArray()
   at AutoMapper.TypeDetails.BuildPublicNoArgExtensionMethods(IEnumerable`1 sourceExtensionMethodSearch)
   at AutoMapper.TypeDetails..ctor(Type type, ProfileMap config)
   at AutoMapper.ProfileMap.TypeDetailsFactory(Type type)
   at AutoMapper.Internal.LockingConcurrentDictionary`2.<>c__DisplayClass2_1.<.ctor>b__1()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at AutoMapper.Internal.LockingConcurrentDictionary`2.GetOrAdd(TKey key)
   at AutoMapper.ProfileMap.CreateTypeDetails(Type type)
   at AutoMapper.Configuration.Conventions.NameSplitMember.MapDestinationPropertyToSource(ProfileMap options, TypeDetails sourceType, Type destType, Type destMemberType, String nameToSearch, LinkedList`1 resolvers, IMemberConfiguration parent, Boolean isReverseMap)
   at AutoMapper.Configuration.Conventions.MemberConfiguration.MapDestinationPropertyToSource(ProfileMap options, TypeDetails sourceType, Type destType, Type destMemberType, String nameToSearch, LinkedList`1 resolvers, Boolean isReverseMap)
   at AutoMapper.ProfileMap.MapDestinationPropertyToSource(TypeDetails sourceTypeInfo, Type destType, Type destMemberType, String destMemberInfo, LinkedList`1 members, Boolean reverseNamingConventions)
   at AutoMapper.TypeMapFactory.CreateTypeMap(Type sourceType, Type destinationType, ProfileMap options, Boolean isReverseMap)
   at AutoMapper.ProfileMap.BuildTypeMap(IConfigurationProvider configurationProvider, ITypeMapConfiguration config)
   at AutoMapper.ProfileMap.Register(IConfigurationProvider configurationProvider)
   at AutoMapper.MapperConfiguration.Seal()
   at AutoMapper.MapperConfiguration..ctor(MapperConfigurationExpression configurationExpression)
   at AutoMapper.MapperConfiguration..ctor(Action`1 configure)
   at GitReleaseManager.Core.AutoMapperConfiguration.Configure() in /_/src/GitReleaseManager.Core/AutoMapperConfiguration.cs:line 13
   at GitReleaseManager.Cli.Program.RegisterServices(BaseSubOptions options) in /_/src/GitReleaseManager.Cli/Program.cs:line 78
   at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
   at GitReleaseManager.Cli.Program.Main(String[] args) in /_/src/GitReleaseManager.Cli/Program.cs:line 34

seems an update to the current of automapper should fix it https://github.com/AutoMapper/AutoMapper/issues/4163

@SimonCropp hmm, this is an interesting one...
We recently ignored a Dependabot PR to update AutoMapper:
https://github.com/GitTools/GitReleaseManager/pull/509
Since it isn't compatible with the current projects target frameworks.
I would need to dig in and figure out exactly what would be required to get that update in.
What exactly is it that it is falling up on?

Same happening for me. It's failing to export the release notes (with and without tagName). Downgrading to 0.14.0 works.

I upgraded AutoMapper to the latest release and this had the following consequences:

I had to upgrade netstandard2.0 to netstandard2.1 in GitReleaseManager.Core.csproj which has the side effect of dropping compatibility with net48
The fact that GRM Core is no longer compatible with net48 means that I had to drop net48 in GitReleaseManager.Cli.csproj
I also had to drop net48 from the three testing projects

If loosing compatibility with net48 is not desirable, maybe we could look into my previous suggestion of pinning the .NET SDK to version 6. However, I don't see this as a long term solution because sooner of later we'll want to upgrade the SDK. Otherwise, maybe we could look into switching to an alternative mapping nuget package?
@gep13 I'm more than willing to investigate further and to submit a PR but I need some direction. Do you think dropping net48 is acceptable? If not, should I investigate pinning the SDK or should I search for an alternative to AutoMapper?

I went ahead and installed .NET 6 SDK on my machine and to my surprise the problem went away! I didn't even have to pin the SDK or change anything else. It seems like the root of the problem is that only .NET 7 was installed on my machine.
Here's what dotnet --info says:

Notice that 6.0.416 is now listed, that wasn't the case until earlier this morning.
As far as I'm concerned, this is an acceptable solution which allows me to move forward. I don't think any other changes are necessary.

Same here.
GHA Runner logs, if required: https://github.com/mkevenaar/php_print_ipp/actions/runs/6811642874/job/18522396621#step:10:93

Myself and @AdmiringWorm met today to discuss this, and what we thought would be the course of action.  We have come up with a plan that we think will work, but we are also happy to take some feedback if folks think there are other things to discuss...
Long story short, we still want to have both a .NET Global Tool version, and a Chocolatey package version of GitReleaseManager.  Given the requirement to update to the latest version of AutoMapper, this means that we lose support for .NET Standard 2.0, and instead need to use at least .NET Standard 2.1.  If we do that, we can no longer use .NET Framework 4.8.  And it we do that, we lose the ability to create an application that will work directly on Windows via the Chocolatey package.
So, having said all of that, here is the plan...
Switch the projects to target the following:

Projet
Target Frameworks

Cli
net6.0

Tool
net6.0 and net7.0

Core
net6.0 and net7.0

The Cli project will then switch to creating a Standalone Application, which will. then be bundled into the Chocolatey Package, and be deployed from there.  To allow this to work as expected, the nuspec file will be updated to remove the dependency on the .NET 4.8 package.
The release notes will need to be updated to make this change clear, to ensure that everyone is aware of the change.

Quick update: I'm experiencing this problem again on my machine despite the fact that installing .NET6 seemed to have fixed the problem a few days ago.
This highlights the fact that the only long term solution is what is being implemented in PR #545.


[Feature Request]: Beam version compatibility (Python and Java versions should match)

What would you like to happen?
Currently, when launching the Python expansion from Java we always install the latest Python SDK irrespective of the Java version. This is error prone. We should be installing a Python version that match the current Java version instead.
Issue Priority
Priority: 2
Issue Component
Component: cross-language

Note that however we solve this, it would be nice to not break development environments (e.g. perhaps the previous version is good enough unless otherwise specified).

Part of the issue is that the development environment will keep changing whenever a new version of Beam Python SDK is released (even for the same pipeline Java SDK version).

Added this to 2.42.0 milestone since this could result in significant future breakages for some users.

This looks like it's resolved. Marking as closed.


feat: change metrics service port to 8000

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Change metrics service listen port to 8000.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #964 (985fb44) into main (c6b7ab9) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   42.33%   42.38%   +0.05%
==========================================
  Files         116      116
  Lines        8783     8783
==========================================
+ Hits         3718     3723       +5
+ Misses       4597     4591       -6
- Partials      468      469       +1

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
42.38% <0.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


How to get parent url?

Wondering if react-router exposes a way to programmatically traverse the route tree, in my specific use case I want to get the parent of my current route.
Is this doable now? Was thinking the Navigation mixin would be a nice place to add something like this, I could take a stab.

You should be able to do that with State#getRoutes.


All key work on system lock

Please fix the issue all keys work when hyprlock I am not set bindl means I do not add the l flag but the key is working
This problem is on only hyprlock-git not in hyprlock
https://github.com/hyprwm/hyprlock/assets/57872034/97c09877-6a5d-4d1a-a109-53610085fa14

you mean keybinds? iirc that's fixed in hyprland-git. It has nothing to do with hyprlock

Yes all keybinds work when system lock why

I am add video please see video you can understand

switch to hyprland git, it's fixed there

Ok

Thanks now working


Pipeline Manager issue Megathread

Here, I want to make a thread that allows for mentions of other issues and consolidation of small things that need fixing

It currently appears that #including a .glsl file that has nothing inside results in a failure to #include it

DAXA_SHADER_INCLUDE_DIR is a really annoying thing for anyone dealing with CMake stuff. I will try to remove it later
How?
Use Daxa's CMake to just copy the absolute include path, adding it as a ".root_paths" by default, INTERNALLY.
Note: Keep consideration for users wanting to package their app with CPack

Define DAXA_SHADER_STAGE inside shaders, with "standard" IDs that represent each stage, since it makes sense to have

Pipeline related (not the manager)
ShaderBinary should be named ShaderByteCode and contain a span to u32, instead of an owning vector


[New Snap] Solana by Solflare

Checklist
All items in the list below needs to be satisfied.

[x] Is the Snap repository publicly accessible and linked in this ticket? https://github.com/solflare-wallet/solflare-snap/
[x] Is the Snap distributed on npm and linked in this ticket?
[x] Has an audit been performed and the audit report attached or linked in this issue?
[x] Is a complete list of discovered vulnerabilities from the audit documented in this issue?
[x] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[x] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

Audit report: https___s3-us-west-2.amazonaws.com_secure.notion-static.com_756f8728-8620-4dae-931c-f2d77192a530_solflare-wallet-snaps-audit-2023-08.pdf

On npm: https://www.npmjs.com/package/@solflare-wallet/solana-snap

The following findings apply to the combined 3 snaps:

sollare‑snap@792fcb2a253c572677271044ece061daae81ce41
sui‑snap@39740383fd11174a406a1a27e15c92f277d00779
aptos‑snap@36145bb8f4963eb02cff26a549ac348a34d8cb3

List of findings:
4.1 Dapp May Force a Sign Approval Dialog Without Showing the Message to Be Signed Major
Fixed in: https://github.com/solflare-wallet/solflare-snap/commit/95370989eaf7a010099b17edf283d9bf34017a82
4.2 CtrlChar/Markdown Injection in renderSignTransaction , renderSignAllTransactions Major
See above commit
4.3 Insufficient Input Validation deriveKeyPair() Medium
Fixed in https://github.com/solflare-wallet/solflare-snap/commit/2f169346089a5b944db18d6430d5efe78d5346ff
4.4 Dapp May Suppress User Confirmation on Request to Extract Pubkey; May Extract Any Net‑Key Medium
This is intentional by design.
4.5 Production Builds Allow Development and Localhost Origins; Snap Does Not Enforce Transport Security Medium
Since the Snap now requires confirmation for any signing, the risk of this issue is lower.
The rest of the issues cited in the audit report are minor and not required to be fixed.

4.6 Misleading HTML Entity and Function Name getPrivkey
4.7 Use of Outdated snap.config.json Instead of snap.config.js
4.8 Inconsistent or Blank Fields in package.json
4.9 Consider Using @metamask/detect‑provider
4.10 Consider Preixing RPC Calls With solana_* , sui_* , aptos_*
4.11 Consider Moving to TypeScript

Corresponding PR: https://github.com/MetaMask/snaps-registry/pull/76


Evaluate content_block in view_content so it's possible to use view helpers in content block.

Sometimes you want to use view helpers like link_to or even another Component inside of content block of the story.

Awesome. Thanks for the contribution. 🎉


No link to log samples

It says there is a link to Azure Firewall log samples. The page it sends you to does not have any log query samples.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 473dce1d-d1ab-ba5f-0762-d7a69be35f28
Version Independent ID: 0da2f916-720b-ce8d-3caf-d2bb91503184
Content: Monitor Azure Firewall logs and metrics
Content Source: articles/firewall/firewall-diagnostics.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thanks for the feedback! I have assigned the issue to the content author to investigate this and update the document as appropriate.

Old text removed
#please-close


[Bug] [Cron] Parse corn expression error

close #13840

It's true that validating a cron expression depends on wether an exception occur is not precise, however, we can still narrow the search，according to the method comment, an IllegalArgumentException is thrown if expression is wrong, so catch IllegalArgumentException rather than Exception is a better idea.
/**
 * Parse string with cron expression.
 *
 * @param expression - cron expression, never null
 * @return Cron instance, corresponding to cron expression received
 * @throws java.lang.IllegalArgumentException if expression does not match cron definition
 */
public Cron parse(final String expression) {
    ......
}

It's true that validating a cron expression depends on wether an exception occur is not precise, however, we can still narrow the search，according to the method comment, an IllegalArgumentException is thrown if expression is wrong, so catch IllegalArgumentException rather than Exception is a better idea.
/**
 * Parse string with cron expression.
 *
 * @param expression - cron expression, never null
 * @return Cron instance, corresponding to cron expression received
 * @throws java.lang.IllegalArgumentException if expression does not match cron definition
 */
public Cron parse(final String expression) {
    ......
}

Thanks for your advice, updated

Codecov Report

Merging #13841 (5c35e9e) into dev (8f3a23d) will decrease coverage by 0.22%.
The diff coverage is 11.68%.

:exclamation: Current head 5c35e9e differs from pull request most recent head 3944085. Consider uploading reports for the commit 3944085 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13841      +/-   ##
============================================
- Coverage     39.14%   38.92%   -0.22%
+ Complexity     4467     4454      -13
============================================
  Files          1155     1157       +2
  Lines         42288    42371      +83
  Branches       4761     4773      +12
============================================
- Hits          16553    16494      -59
- Misses        23924    24061     +137
- Partials       1811     1816       +5

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/alert/AlertServer.java
0.00% <0.00%> (ø)

...hinscheduler/alert/metrics/AlertServerMetrics.java
0.00% <ø> (ø)

...phinscheduler/alert/plugin/AlertPluginManager.java
2.43% <0.00%> (ø)

...inscheduler/alert/registry/AlertHeartbeatTask.java
0.00% <0.00%> (ø)

...nscheduler/alert/registry/AlertRegistryClient.java
0.00% <0.00%> (ø)

...phinscheduler/alert/rpc/AlertRequestProcessor.java
0.00% <0.00%> (ø)

...che/dolphinscheduler/alert/rpc/AlertRpcServer.java
0.00% <0.00%> (ø)

...er/api/service/impl/MetricsCleanUpServiceImpl.java
14.28% <0.00%> (ø)

...api/service/impl/ProcessDefinitionServiceImpl.java
35.09% <0.00%> (ø)

...e/dolphinscheduler/common/constants/Constants.java
75.00% <ø> (ø)

... and 44 more

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support for different image builders

Is your enhancement related to a problem? Please describe
Long term there may be multiple image builder containers, or versions of each. Containers may want to indicate which builder they prefer or maybe have a minimum requirement.
Describe the solution you'd like
We need to understand the long term tagging strategy/evolution [1] of the image builder, how containers might indicate their requirements [2], and come up with a plan for how we'd support this in the tools, ideally without any new cognitive load on the user (i.e. no new UI or prompts, it just does the right thing).
[1] https://github.com/osbuild/bootc-image-builder/issues/111
[2] https://github.com/CentOS/centos-bootc/pull/453
Describe alternatives you've considered
No response
Additional context
No response

BTW every time someone says "image" I usually make them clarify "disk image" or "container image"...this one should definitely say "disk image".

Good point :), updated

RHEL image builder has now been added :) https://github.com/containers/podman-desktop-extension-bootc/issues/428

Can we close this since RHEL image builder has been added? Or should we still keep this open for "custom" image builders?

Yup, we should close.


[comments] scroll to and flash the location of a comment when clicked

we need an affordance on a comment to jump to the anchor location of the thread, and highlight it in a distinct way when attention is on the comment thread

ran into this again today in a larger document - very annoying!

I can't replicate this now. I did add a 'selected' color affordance to better indicate to the user which thread is selected in the document.


Can't really get the new release update

I believe this is a new issue because the latest tagged release (v0.20.0) was just released 10 hours ago.
This happens when I tried to do go get -u command and it happens on Windows and Linux (Debian).
These messages will appear if I want to update quic-go to the latest release
go get all: module github.com/lucas-clemente/quic-go@upgrade found (v0.20.0), but does not contain package github.com/lucas-clemente/quic-go/quictrace
go get all: module github.com/lucas-clemente/quic-go@upgrade found (v0.20.0), but does not contain package github.com/lucas-clemente/quic-go/quictrace/pb

Not sure about the error message here. Support for quic-trace was removed in https://github.com/lucas-clemente/quic-go/pull/2913.

I did go clean -cache, go clean -testcache, go clean -modcache just to make sure and then go mod tidy, it downloaded the quic-go v0.19.3 just fine — but after that, I did a go get -u all and the same message appeared.
go get all: module github.com/lucas-clemente/quic-go@upgrade found (v0.20.0), but does not contain package github.com/lucas-clemente/quic-go/quictrace
go get all: module github.com/lucas-clemente/quic-go@upgrade found (v0.20.0), but does not contain package github.com/lucas-clemente/quic-go/quictrace/pb

It's the same when I tried to go get -u quic-go v0.20.0 on a fresh vps server.
Not sure either if I'm missing something here.

That shouldn't happen. quictrace was completely removed from quic-go in the commit I mentioned above.
You can try replacing the version number in go.mod manually, and then running go mod tidy.


Modal onHidden and observeChanges clash

We create a modal like this:
$(selector).modal({onHidden: this.unmount, observeChanges: true}).modal('show');

However, when user clicks close (or clicks the dimmer), both modal and dimmer get hidden properly, also removing screenHeight(), e.g. height style from the body.
Then onHidden callback fires, which in our case clears the modal content. This triggers observeChanges on already hidden modal and sets screenHeight() to the body again, breaking our page layout.
Desired behaviour: observeChanges should be removed when modal gets hidden (before onHidden callback fires).
We use semantic 2.2.1.

Can you create a test case to show refresh causing incorrect page stylings?


timeouts: updates, corrections, clarifications

https://deploy-preview-319--zealous-shirley-0f56b3.netlify.app/docs/architecture/timeouts/

/restest

/retest

/cc openshift/test-platform

obrigado
/lgtm


Extensions

I made some extensions. I don't know if you want them, but thought I would make a pull request in case you did. Feel free to reject this if you don't like the extensions, or if you don't have time or desire to look at the changes.
Here is a summary:
The public interface is much the same.
I added

put_id_in_title setting, which is used in set_note_id. If false the id is not added to the title (default is true)
Added another id scheme, namely the Luhdmann scheme that I use. This has notes numbered 1,2,3 and sub notes with letters 1a,1b,1c, and sub sub notes with numbers again 1a1, 1a2, etc.
Added the contains function. This merely returns true if the given file is within the note_path directory. Useful for creating a sub section of the markdown ftplugin.
Added then removed a show_tags() function. As your wiki pointed out: :ltag does this, I did not realise. I leaned another thing, thank you.
ZkNew now optionally accepts an id. This means nothing with the current id scheme, but with the Luhdmann scheme this is the parent id to use.

Obviously this apparently small public interface change required some internal shuffling. The main one being that there is a new submodule zettelkasten.id which holds the id schemes.
One significant change I am not sure about is in 'zettelkasten.set_note_id`. I see that there was provision for an error if the note already exists. But it looked like it would never happen, so I made it explicit.
Having done that it means that this function does not really do what it says in the documentation.

Hi Duncan!
Thanks a lot for these changes! I think this would actually be a great use case for extending this plugin and building a new one on top. If you convert this to a plugin of your own that depends on this one, I'd be happy to link to it from the README to make it easy to discover.
If there are things that you would require from this plugin for you changes to work, I'd be happy to merge those.

Ok, great. I think we can close this pull request then.
I have created an issue to discuss the possible extensions and their design: #23
I will make a pull request specifically for that when your happy with the plans.


IWW Issue #27, November 17th 2020

This pull request is for gathering links for the November 17th issue of the Immersive Web Weekly newsletter for the W3C Immersive Web Community Group.
If you have a link to a news article, event, artwork, or project that is directly related to the immersive web then we welcome your help!
To submit a link comment below using this template:
title: Example title of link
url: https://example.com/
author: Alice Smith
content: A short description of what is at the link and why it's related to the immersive web

Please keep in mind that comments here and all submitted links are public!
We keep each issue pretty short so we won't immediately use every submission but we keep track of them all and they may appear in a later issue.
Deadline
IWW goes out each Tuesday morning Pacific time.
Trevor will edit each issue on the Monday before (in this case that Monday is November 16th) so submissions after that will roll over for use in future issues.
If you need editorial support then email @TrevorFSmith<EMAIL_ADDRESS>

title: Create WebXR Voxels
url: https://www.youtube.com/watch?v=rDMLVdFtnYo&feature=youtu.be
author: Daniel Esteban
authorLink: https://twitter.com/DaniGatunes/
content: >
https://twitter.com/DaniGatunes/status/1326146950320824320

title: Oculus Go Wasn't Designed For Black Hair
url: https://twitter.com/ozm/status/1326568694869336065
author: Arwa Michelle Mboya
content: One designer's approach to widening VR's reach.

title: Oculus Go Wasn't Designed For Black Hair
url: https://twitter.com/ozm/status/1326568694869336065
author: Arwa Michelle Mboya
content: One designer's approach to widening VR's reach.

As far as I know there are 0 headsets that is designed for black hair, unless you count Google Cardboard. The recommended design doesn't work for Afros. I've been asked this few times. Great article never the less.

title: Babylon.js 4.2: Simplicity Reimagined
url:https://babylonjs.medium.com/babylon-js-4-2-simplicity-reimagined-965f88d0fad
author: Babylon.js
content: The latest evolution of the Babylon Platform, the amazingly simple Babylon.js 4.2 has new tooling as well as WebXR hand interaction module.

title: AIGA design has a Hubs space for their 2020 design show
url: https://twitter.com/kentbye/status/1327380861658951680
author: Kent Bye (need to track down the space creators, too)


Fix hub.yml indentation.

Fixes an indentation issue in the hub.yml which is preventing the policy to be published in the policy hub.

I think you have to go ahead and do another release


Fix numbering in multilevel lists

When we have a multilevel list where there is a bulleted list nested inside a numbered list, the numbers skip. See example below from learn_encodeLinks_principles.html. Can we make it so that the numbers don't skip when there is a nested list?

I made it work using css counter. This may have ramifications for screen readers, we'll have to test that.
I spent some time on this and figured out that the rendering you see here above is actually a bug in Firefox. Other browsers should render it correctly.
Normally this would not be a problem, but because LEDMO is outputting divs and then styling them as lists, rather than using the html elements of ul and ol, this bug has emerged (our use of divs as list, especially numbered and nested, is probably very rare).

I went through a couple of pages on my screen reader this morning and found that it didn't read any of our lists. I wonder if that is because we are using div rather than ul or ol.

Did it completely ignore them or did it create nonsensical output, or did it treat them as just as a bunch of text.

It just read the text without indicating that it was in a list.

I think we'll add this to it, it'll be in the next build. Can you take a look at it at that point and see if there is a difference?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/list_role

Yeah, I'll take a look. Do you know why we're using divs rather than ul/ol?

Yes (I asked Martin), it has something to do with the TEI encoding needs. In this case TEI xml allows for p tags to include lists. HTML does not allow this. Work would have to be done to change the built HTMTL,  the XML encoding, or both. It's a larger discussion I think, but an important one.

Ah, I see.

@pszpak @martindholmes the aria @roles worked, the screen reader is picking up lists correctly now. Thanks!


Attempt To Fix CSS/Less Errors

none is not a valid value for margin/padding.
Less appears to interpret the / in rgb(<red> <green> <blue> / <alpha>) as a math expression, so I converted the relevant rules to use Less functions.

I will merge these changes into the v9userHandling branch ( another odd name for way more stuff in there).
Thanks for the contribution.


WIP QR Decomposition

@tbetcke I followed the structure of the LU decomposition (though I've only implemented for f64 currently), and I added a solve_qr function to LapackData that uses dgels as that seems to be the default way to do LLS with LAPACK.

Does that make sense? I still need to add some tests, do you have a suggestion for a library that does testing for such procedures well?

Should I also add the various options (QL, LQ,RQ)?

Thanks for the suggestions @jedbrown. I've used 100ULPs instead of machine error as I saw that has been used elsewhere in the repository.
@tbetcke I plan to now add the pivoted QR decomposition and then write a generic macro for implementing everything for the different scalar types. I assume I'll also need to delete some functions and tests, adjust the trait, function names, etc, but would need to discuss first.
PS: I wanted to note, I saw a strange memory issue several times while trying to run the tests, but it appears to have been caused ny VSCode trying to run multiple tests at the same time (running via cargo test raised no such issues), but I attach it
here just in case.

I had an error in my matrix-comparing macro so all my tests were passing regardless, fixed now.
As far as I can tell LAPACK only returns a thin Q with orthonormal columns (am I wrong?), so those tests are failing.
my attempt at using the qr decomposition (the full rank) and solving by duplicating one of the DGELS branches in rust (by calling underlying lapack subroutines) is also failing, I don't know why - until I figure it out no point trying to figure out the pivoted version of that as it is very similar.
comparing by ULP doesn't seem to be adequate here (I had to increase to 10k to pass a clearly unitary matrix as such)

I don't follow what you mean about LAPACK returning a "thin $Q$". It returns elementary reflectors encoded as the lower triangular part plus scaling tau. This representation contains the data of a full (square, orthogonal) $Q$, but uses less storage than naive storage of a "thin $Q$". You can apply it and you can extract any desired columns.

I understand as much. I use DORGQR to obtain the aforementioned "thin", or "reduced" $Q$ (also noted $Q_1$, which is an $m\times n$ matrix with orthonormal columns. Hence my $Q_1^TQ_1=I$ test passes, but $Q_1Q_1^T=I$ doesn't.
I also used DORMQR($I_{m\times m}$) which should return for my case $QI=Q$, but that passes neither orthonormality check. When trying $Q^TQ$ expecting to get $I$, I get $I+S$ where $S_{ij}=S_{ji}$ and $S_{ii}=0$. $QQ^T$ returns a symmetric matrix.
If I should be getting the whole $Q$, I guess I'm still making some error in the way I call Lapack, likely DORMQR specifically.

I would reduce by taking a QR factorization of a 2x1 matrix. It sounds like the second column of your $QI$ is not orthogonal, which sounds like a calling problem.
julia> using LinearAlgebra

julia> Q, R = qr([1;2])
LinearAlgebra.QRCompactWY{Float64, Matrix{Float64}, Matrix{Float64}}
Q factor:
2×2 LinearAlgebra.QRCompactWYQ{Float64, Matrix{Float64}, Matrix{Float64}}:
 -0.447214  -0.894427
 -0.894427   0.447214
R factor:
1×1 Matrix{Float64}:
 -2.23606797749979

julia> Q * Q' - I
2×2 Matrix{Float64}:
 -2.22045e-16  -1.11022e-16
 -1.11022e-16   0.0

@tbetcke As discussed I've removed the pivoted bits to be added in a separate pull request. I've also left out implementing an owning version of into_lapack.
Otherwise this all works now and can be merged.

@mscroggs I don't think this is failing due to anything I did as I haven't touched MPI stuff. I do however get the following error locally (I've ignored it since my work is exclusively on the Algorithms crate):
error[E0425]: cannot find value `MPI_UNWEIGHTED` in crate `mpi_sys`
   --> sparse/src/ghost_communicator.rs:108:26
    |
108 |                 mpi_sys::MPI_UNWEIGHTED,
    |                          ^^^^^^^^^^^^^^ not found in `mpi_sys`

Am I doing something wrong?

@mscroggs I don't think this is failing due to anything I did as I haven't touched MPI stuff. I do however get the following error locally (I've ignored it since my work is exclusively on the Algorithms crate):
error[E0425]: cannot find value `MPI_UNWEIGHTED` in crate `mpi_sys`
   --> sparse/src/ghost_communicator.rs:108:26
    |
108 |                 mpi_sys::MPI_UNWEIGHTED,
    |                          ^^^^^^^^^^^^^^ not found in `mpi_sys`

Am I doing something wrong?

There's an open issue for this (#20). The fix has been merged into rsmpi, so a fix will be here soon

@mscroggs I don't think this is failing due to anything I did as I haven't touched MPI stuff. I do however get the following error locally (I've ignored it since my work is exclusively on the Algorithms crate):
error[E0425]: cannot find value `MPI_UNWEIGHTED` in crate `mpi_sys`
   --> sparse/src/ghost_communicator.rs:108:26
    |
108 |                 mpi_sys::MPI_UNWEIGHTED,
    |                          ^^^^^^^^^^^^^^ not found in `mpi_sys`

Am I doing something wrong?

There's an open issue for this (#20). The fix has been merged into rsmpi, so a fix will be here soon

Fix is now merged, so if you pull the latest version it should hopefully now run with openmpi

@peshence Are you happy for me to merge this now?

@tbetcke ideally should be peer reviewed, but otherwise yes


Create _discord.cutedog5695.json

Requirements

[ ] You have completed your website.
[ ] The website is reachable.
[ ] The CNAME record doesn't contain https:// or /.
[ ] There is sufficient information at the owner field.

Description

Link to Website

?


Clarification and Reorganization of High-Level Categories in miairr/data_elements

In the miairr/data_elements.rst, we mention having six high-level categories: Study and subject, sample collection, sample processing and sequencing, raw sequences, processing of sequence data, and processed AIRR sequences. However, the table only presents five levels:

1/study
1/subject
1/diagnosis and intervention
2/sample
3/process (cell)
3/process (nucleic acid)
3/process (nucleic acid [pcr])
3/process (sequencing)
4/data (raw reads)
5/process (computational)
5/data (processed sequence)

At first, it look like 5/data (processed sequence) should be 6/data (processed sequence), but looking at the TSV-file I see that 5/data (processed sequence) is all about registering the V(D)J germline reference database, which aligns it with 5/process (computational) as it is relevant for the software registered in Software tools and version numbers.
Is splitting the table in miairr/data_elements.rst into sections corresponding to each high-level category possible? This will prevent endless scrolling and make the grouping more clear. And we can explain the occult and enigmatic 6th level.

From the call:

DataProcessing.germline_database should be x-airr.subset: process (computational)
Enable Rearrangement (x-airr.set: 6) row generation in MiAIRR TSV (in conf.py).
Correct MiAIRR figure to move "V(D)J germline reference database" to set 5.


Make Dialog Boxes always stay top

Fixed. The dialogs will stay on top of the ChessForge window but will be hidden when other apps are moved over.


Use path file instead of sitecustomize.py

Summary
Use a path file (.pth) instead of sitecustomize.py for configuring path in emphemeral virtualenvs, overlaying the ephemeral venv on top of the base .venv.
sitecustomize.py is a module in the python installation and as such a unique resource - homebrew pythons on macos already install such a file and thus uv's sitecustomize.py, placed in the ephemeral env, did not have any effect.
I don't find any documentation explicitly saying that addsitedir is valid in .pth files but from trial it seems to be - and there is the precedent of the existing _virtualenv.pth _virtualenv.py pair that do nontrivial operations.
Test Plan

Testing on ephemeral venv, resolving to base venv including editable install in base: done (py3.7, 3.12)
Testing on homebrew python/macos: done (py3.11)
tests: run_editable

Fixes #7152

Cross-linking in case this becomes a problem

https://github.com/python/cpython/issues/77102


Re-license to the MIT License

This PR will change the license of skinview3d from GPLv3 to the MIT License.
The upstream (earthiverse/3D-Minecraft-Skin-Viewer) has already been re-licensed to the MIT License. In order to re-license this repository, we need contributors' consents.
List of contributors:

@yushijinhun
@Hacksore
@g-plane

If you are one of the contributors and you approve of the re-licensing, please reply to this PR with the words of: "I permit the license of my contributions to skinview3d to be changed to the MIT License."
Once all the contributors have agreed, this PR will be merged and the license of skinview3d will be changed to the MIT License.

I permit the license of my contributions to skinview3d to be changed to the MIT License.

I permit the license of my contributions to skinview3d to be changed to the MIT License.

I permit the license of my contributions to skinview3d to be changed to the MIT License.


Command buffer aborted error with iOS 12.1 & Xcode 10.1

I just updated Xcode to 10.1 and my iPad to iOS 12.1. I now get the following error when running my app from Xcode that I did not see before
Execution of the command buffer was aborted due to an error during execution. Insufficient Permission (to submit GPU work from background) (IOAF code 6)

The app seems to run fine despite this.

@MarkCallow
I'm not seeing this anywhere...even with Xcode 10.1 and iPad 12.1.
Are you able to replicate the error reliably?

Okay. I'm going to close this issue for now. If it returns and we can figure out how to replicate it...reopen this issue and provide more context information if you can.


When uploading DIA-NN report.tsv: param\parameterized.py:337: DtypeWarning: Columns (2) have mixed types

Describe the bug
When uploading a DIA-NN report.tsv file the following error is displayed in the terminal:

param\parameterized.py:337: DtypeWarning: Columns (2) have mixed types.Specify dtype option on import or set low_memory=False.

The error shown in the browser is the following:

The columns necessary for further analysis cannot be extracted from the first experimental file. Please check the data uploading instructions for a particular software tool.

From my own testing of working with DIA-NN output (version 1.8) with pandas setting low_memory=False fixes the problem.
To Reproduce
Steps to reproduce the behavior:

Enter the path to a DIA-NN output file
See that the sample names are parsed correctly
Click Upload
See error

Expected behavior
No error
Desktop (please complete the following information):

Installation Type: Windows Installer
OS: Windows 10
Version 0.0.8

Hello,
Thanks a lot for the submission of the bug!
What you see in the terminal is just a warning that doesn't have any influence on the work of the tool. The error shown in the GUI tells that the program can't extract the columns that should be used for further analysis and visualization. All columns that should be present in the DIA-NN output are mentioned in the GUI and in the manual (Protein.Ids, Modified.Sequence, Run). You may also check our test file for the DIA-NN.
If you have all above-mentioned columns in the report.tsv file and still get the same error message, I would be glad if you could share with us the whole file or even part of it (several rows together with the names of the columns).
If you still have any other questions, I'm happy to help! 😀
Best
Jane

Hi there and thanks for the help! My report.tsv definitely contains these columns you mention. In fact it contains even more columns than your DIA-NN test data file:
{'First.Protein.Description',
 'Lib.PG.Q.Value',
 'Lib.PTM.Site.Confidence',
 'Ms1.Translated',
 'PEP',
 'PTM.Informative',
 'PTM.Localising',
 'PTM.Q.Value',
 'PTM.Site.Confidence',
 'PTM.Specific'}

These columns are found inside my report.tsv but not in your file. Maybe that is where the problem is coming from? It could be that DIA-NN 1.8 introduced some new columns, I guess. I'll also see if I can prepare a dummy .tsv file to showcase the problem.

Thanks a lot for your answer! No, new columns shouldn't be a problem. I would be really thankful for a small example file to reproduce the bug that will help us to solve it. 🙏

I have created a minimal example which shows the problem: minimal_report.zip

Thanks a lot for sending your file! I've checked it and the issue is that in the Protein.Ids column you need to have the Uniprot unique entry identifier, e.g. P01308 for the human insulin protein. As I mentioned before, you may always look at the example file. Unique Protein.Ids are needed to combine the user experimental data in AlphaMap with the earlier mined Uniprot data. We'll add more detailed information about the content of these columns in the instructions for the supported proteomics software tools to prevent any user's confusion.

In connection to this case when Protein.Ids does not contain valid IDs, is there any specific rationale for using Protein.Ids and not Protein.Group? Protein.Ids normally contains all mapped proteins, while Protein.Group - the proteins inferred with a maximum parsimony algorithm.

Initially our idea of AlphaMap was to visualize proteomics data on the peptide level without making any assumptions with regard to protein inference. The protein grouping strategies between software tools vary and if individual peptides are of interest you might miss important information on possible parental proteins/genes (btw. the hover info shows all protein ids that a peptide can be mapped to).
That being said, I understand that it might be misleading for the more 'protein focussed' people to have a peptide shown for proteins that are not included in the assigned protein group. We will think about this again - maybe we can introduce a parameter for users to choose whether to show a peptide for all 'Protein.Ids' or only the 'Protein.Group' accessions.

Oh, makes sense, thank you for the explanation!

Thanks a lot for sending your file! I've checked it and the issue is that in the Protein.Ids column you need to have the Uniprot unique entry identifier, e.g. P01308 for the human insulin protein. As I mentioned before, you may always look at the example file. Unique Protein.Ids are needed to combine the user experimental data in AlphaMap with the earlier mined Uniprot data. We'll add more detailed information about the content of these columns in the instructions for the supported proteomics software tools to prevent any user's confusion.

That makes sense, thank you for having a look. I used a custom fasta for my search and I guess this the reason why the Uniprot IDs were not included in the report. I'll close my bug report then.


Add NBS recording and playback roles

This PR adds roles for NBS recording and playback. These can be used  for tuning localisation and vision

maybe the folder could be called data


fix(ios): mitigate media memory usage

:tada: This PR is included in version 4.1.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Only download that one KafkaSource CRD

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>
Changes

as per title

/kind

Fixes #

Release Note

Docs

/hold
until https://github.com/knative-sandbox/eventing-kafka/pull/971/files

/unhold


Assorted bug fixes for 0.8

Fix incorrect mixer filter generation.
Fix incorrect comparison/FQDN expansion of mesh default gateway ("mesh").
Do not generate listeners for non TCP protocols
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d51c67a275f4d82ab70709af17c1238579a7a9b9
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d51c67a275f4d82ab70709af17c1238579a7a9b9
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
e9c792c90cbb239198b36f27da47944ceae34343
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e9c792c90cbb239198b36f27da47944ceae34343
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
e9c792c90cbb239198b36f27da47944ceae34343
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

Are you going to cherrypick this to the release branch? https://github.com/istio/istio/commits/release-0.8


Organize Posts By Subject Area

Create consistent subject areas for each of your posts

Rename "Categories" to "Subjects"


[Table] After deleting some rows, the next rows become/stay selected

I asked on StackOverflow, I created a Webpack Bin and asked on Gitter.
Problem description
I have a table with TextFields
When I drop some rows in my table, the next rows become/stay selected.
my state I have selectedStudents and tableData. The selectedStudents are all selected index in my table.
When I click on delete button.. the follow code remove all rows in my tableData and all values in selectedStudents.
Link to minimal working code that reproduces the issue
Webpack Bin
Versions

Material-UI: ^0.17.1
React: ^15.4.2
Browser:  Chrome Version 56.0.2924.87 (64-bit)

I confirm the issue:
Somehow the 1st selected index stays always selected after the deletion, despite the selected state being empty array.

Try to re-render the whole <TableBody> component when the rows inside of it are changed should walk around this issue.
In Table/TableBody.js file (line 127 - line 143), it says the selected property will have any effects on the rows only when the TableBody component will mount or the allRowsSelected property is changed.

Hi @BigMurry I tried, but not work....

@Ridermansb,
You can force a re-render of the <TableBody/> component, by providing it a key value that only gets changed when you delete an item. Taking the idea from here: http://stackoverflow.com/a/21750576 and combining it with an internal state value, I've managed to get this to work:
this.state = {
...
// tableBodyRenderKey is used to force a complete re-render of the <TableBody/> component
// when items are removed from the table. This is necessary because <TableBody/> maintains an
// internal selection of items and has to be re-mounted when those items are removed.
// Following the advice from here: https://github.com/callemall/material-ui/issues/6496
// and here: http://stackoverflow.com/a/21750576

tableBodyRenderKey: 0
}

When removing items, just be sure to increment the key value to force react to re-render the component:
onRemove() {
...
this.setState({tableBodyRenderKey: tableBodyRenderKey+1})
}

and in your render() method:
<TableBody key={tableBodyRenderKey} ... />

It looks like you store the selected indexes in selectedStudents array. When you click "delete" you also need to remove those indexes from the selectedStudents array.

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.


fix library name in docs ('cuvs' not 'pycuvs')

The Python library is distributed as conda package cuvs, but the installation docs say pycuvs. This fixes that.
Looked for other uses like this:
git grep -i pycuvs

Didn't find any.

/merge


Add status conditions to Shim status

Describe your changes
Implement status conditions in Shim status to reflect readiness based on node provisioning status.
Issue ticket number and link
https://github.com/spinkube/runtime-class-manager/blob/c65f3562aabfca4681c034f09afd4d5a513ee732/internal/controller/shim_controller.go#L192
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
I tested the changes with the following distributions:

[ ] Kind
[ ] MiniKube
[ ] MicroK8s
[ ] Rancher RKE2
[ ] Azure AKS
[ ] GCP GKE (Ubuntu nodes)
[ ] AWS EKS (AmazonLinux2 nodes)
[ ] AWS EKS (Ubuntu nodes)
[ ] Digital Ocean Kubernetes

@voigt @0xE282B0, Could you give feedback on whether this PR meets the intention expressed in the TODO?

Hey @tillknuesting,
Awesome that you are contributing!
We're currently on a conference marathon, but we'll have a look later 😁

Hey @tillknuesting,
Thank you for the PR and tackling the issue.
Apart from the implementation, a significant part of the issue is investigating the different possible states and under which conditions they occur. IMO, there are at least three states:

ready (...)
pending (jobs are scheduled/running; not all finished)
failed (at least one job wasn't successful / got stuck?)

Other states may be reasonable as well.


Knative support for Functions

Similar to KEDA, can Function run on Knative?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cbf4053-0a3d-a803-3e0d-8cf28db358e8
Version Independent ID: 782efd9c-beea-249c-f8e8-4ee4389bfb07
Content: Azure Functions on Kubernetes with KEDA
Content Source: articles/azure-functions/functions-kubernetes-keda.md
Service: azure-functions
GitHub Login: @jeffhollan
Microsoft Alias: jehollan

@pisees Looks like you already found you answer but for others coming across this, Azure Function containers are like any other application. You can set them up for Event Delivery like you would for others.


Start mysql server on macOS

When working on #52, start mysql server always fails, so I disable run CI on macOS.
https://github.com/zigcc/zig-cookbook/actions/runs/8203449593/job/22436210107
<EMAIL_ADDRESS>-e "CREATE USER '$USER'@'localhost' IDENTIFIED BY ''"
Warning: n: [Warning] Using a password on the command line interface can be insecure.
<EMAIL_ADDRESS>-e "GRANT ALL PRIVILEGES ON *.* TO '$USER'@'localhost'"
mysqladmin: connect to server at 'localhost' failed
<EMAIL_ADDRESS>-e "FLUSH PRIVILEGES"
error: 'Access denied for user 'root'@'localhost' (using password: YES)'
<EMAIL_ADDRESS>-proot password '123'
node:child_process:965
    throw err;
    ^

Error: Command failed<EMAIL_ADDRESS>-proot password '123'
    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at run (/Users/runner/work/zig-cookbook/zig-cookbook/.github/ci.js:14:3)
    at Object.<anonymous> (/Users/runner/work/zig-cookbook/zig-cookbook/.github/ci.js:40:1)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Module._load (node:internal/modules/cjs/loader:[101](https://github.com/zigcc/zig-cookbook/actions/runs/8203449593/job/22436210107#step:6:102)3:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) {
  status: 1,
  signal: null,

https://github.com/zigcc/zig-cookbook/pull/55/checks PTAL.


accelerate test fails with 'Namespace' object has no attribute 'use_cpu'

System Info
- `Accelerate` version: 0.14.0
- Platform: Linux-5.15.0-1026-aws-x86_64-with-glibc2.35
- Python version: 3.10.6
- Numpy version: 1.23.5
- PyTorch version (GPU?): 1.13.0+cu117 (False)
- `Accelerate` default config:
        - compute_environment: AMAZON_SAGEMAKER
        - distributed_type: NO
        - mixed_precision: FP16
        - use_cpu: False
        - ec2_instance_type: ml.t3.2xlarge
        - iam_role_name: AmazonSageMaker-ExecutionRole
        - image_uri: None
        - profile: None
        - region: us-east-1
        - num_machines: 1
        - gpu_ids: all
        - base_job_name: accelerate-sagemaker-1
        - pytorch_version: 1.10.2
        - transformers_version: 4.17.0
        - py_version: py38
        - sagemaker_inputs_file: None
        - sagemaker_metrics_file:

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction

Start AWS EC2 ubuntu 22.04 instance (4vCPU, 16 ram)
Install accelerate
Configure accelerate to use SageMaker
Run accelerate test --config_file ~/.cache/huggingface/accelerate/default_config.yaml

Immediately breaks with the following error:
Running:  accelerate-launch --config_file=/home/ubuntu/.cache/huggingface/accelerate/default_config.yaml /home/ubuntu/.local/lib/python3.10/site-packages/accelerate/test_utils/scripts/test_script.py
stderr: Traceback (most recent call last):
stderr:   File "/home/ubuntu/.local/bin/accelerate-launch", line 8, in <module>
stderr:     sys.exit(main())
stderr:   File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1075, in main
stderr:     launch_command(args)
stderr:   File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1036, in launch_command
stderr:     if args.use_cpu and args.num_processes > 1:
stderr: AttributeError: 'Namespace' object has no attribute 'use_cpu'
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/test.py", line 52, in test_command
    result = execute_subprocess_async(cmd, env=os.environ.copy())
  File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/test_utils/testing.py", line 328, in execute_subprocess_async
    raise RuntimeError(
RuntimeError: 'accelerate-launch --config_file=/home/ubuntu/.cache/huggingface/accelerate/default_config.yaml /home/ubuntu/.local/lib/python3.10/site-packages/accelerate/test_utils/scripts/test_script.py' failed with returncode 1

The combined stderr from workers follows:
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/accelerate-launch", line 8, in <module>
    sys.exit(main())
  File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1075, in main
    launch_command(args)
  File "/home/ubuntu/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1036, in launch_command
    if args.use_cpu and args.num_processes > 1:
AttributeError: 'Namespace' object has no attribute 'use_cpu'

Expected behavior
I expect it to run test, or at least tell me that my SageMaker instance has no GPU. I am not expecting it to break at level of reading the config. Maybe I forgot to execute some steps? Or improper configuration?

Hi @PaulKovalov, could you try again installing from github? i.e.:
pip install git+https://github.com/huggingface/accelerate

And potentially also could you copy the entire contents of your default_config.yaml file as well?

I am also dealing with the same bug while running accelerate launch.
My config file (created by interactive cli):
base_job_name: accelerate-sagemaker-1
compute_environment: AMAZON_SAGEMAKER
distributed_type: 'NO'
dynamo_backend: 'NO'
ec2_instance_type: ml.t3.2xlarge
gpu_ids: all
iam_role_name: accelerate_sagemaker_execution_role
image_uri: null
mixed_precision: 'no'
num_machines: 1
profile: default
py_version: py38
pytorch_version: 1.10.2
region: eu-central-1
sagemaker_inputs_file: null
sagemaker_metrics_file: null
transformers_version: 4.17.0
use_cpu: false

Error message:
accelerate test --config_file .accelerate-config.yaml

Running:  accelerate-launch --config_file=.accelerate-config.yaml /Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/test_utils/scripts/test_script.py
stderr: Traceback (most recent call last):
stderr:   File "/Users/patricks/Workspace/comikizer/.venv/bin/accelerate-launch", line 8, in <module>
stderr:     sys.exit(main())
stderr:   File "/Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1110, in main
stderr:     launch_command(args)
stderr:   File "/Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1071, in launch_command
stderr:     if args.use_cpu and args.num_processes > 1:
stderr: AttributeError: 'Namespace' object has no attribute 'use_cpu'
Traceback (most recent call last):
  File "/Users/patricks/Workspace/comikizer/.venv/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/commands/test.py", line 52, in test_command
    result = execute_subprocess_async(cmd, env=os.environ.copy())
  File "/Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/test_utils/testing.py", line 328, in execute_subprocess_async
    raise RuntimeError(
RuntimeError: 'accelerate-launch --config_file=.accelerate-config.yaml /Users/patricks/Workspace/comikizer/.venv/lib/python3.10/site-packages/accelerate/test_utils/scripts/test_script.py' failed with returncode 1

Accelerate: 0.15.0
Python: 3.10

This seems to be the same as https://github.com/huggingface/accelerate/issues/980#issuecomment-1386618169

Thanks @muellerzr same issue here https://github.com/huggingface/accelerate/issues/980


Correcting icon paths

Looks like there are a lot of icon paths that are outdated and point to icons from the old theme (which no longer exist)
This PR is intended to correct those paths so they now point to existing icons.
Don't merge yet.
I'm still poking around to see if I can find more icons that are broken
Closes #337.

@BelleNottelling still working on this?

@evrifaessa It's still on my list, but I have someone visiting this week so I likely won't be working on it during that time

I had a quick look through and can't see any icons that you have missed. I'm not saying there definitely aren't any, but there aren't any anywhere obvious. :)

Rebased. Feel free to review and merge whenever

@BelleNottelling I think this PR reintroduces some files we've removed while dropping the Forum module.

Should be fine after the forum files files are removed.

Fixed. Thought I told git to drop those files on the rebase, but I guess not


CLI options now override env vars

In testing restic, I had an env variable RESTIC_REPOSITORY that was my "main" or "real" backup location, but then I ran restic --repo /other/repo/for/testing init and it still tried to use the value in RESTIC_REPOSITORY. This change re-prioritizes CLI flags over env vars, which in my opinion, is more intuitive.
I hope it's on the right track, I noticed that the parseEnvironment() function didn't use any of its parameters and I didn't see why it needed to happen outside of the init().
Let me know if you need anything in the way of testing this.

Current coverage is 52.97% (diff: 100%)

Merging #718 into master will increase coverage by 0.19%

@@             master       #718   diff @@
==========================================
  Files            91         91
  Lines          7242       7243     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3822       3837    +15
+ Misses         2870       2851    -19
- Partials        550        555     +5

Powered by Codecov. Last update 04846b1...a394b67

Oh, that's really embarrassing. Thanks for raising this issue. The order should obviously be command-line params before environment.
This change however breaks restic: The environment is never considered. The struct globalOptions is filled by parseEnvironment(), but the flag definitions seem to reset the values to the default values specified in the call to StringVarP(). With parseEnvironment() in the PersistentPreRunE hook, it is run after init(), but before any command code is run.
So, for a proper fix I suggest removing RESTIC_REPOSITORY from parseEnvironment() and changing the line defining the --repo flag as follows:
	f.StringVarP(&globalOptions.PasswordFile, "password-file", "p", os.Getenv("RESTIC_REPOSITORY"), "read the repository password from a file")

That should fix it. Would you like to the change?

Oops, I thought I took care of that too, but after I re-exported the env variable I didn't hit [return] to run the restic command and check; so you're right. Now I'm embarrassed :smile:
Pushed another commit.


Suggestion: ID profile

It would be interesting if the tool collected the profile id on instagram, as it is an identifier that does not change, even changing the username.

I'm sorry for being late at respond, I will try to add it you can use
Instagram Finder  provides an easy way for developers and designers to get Instagram account numeric ID by username.

I'm sorry for being late at respond, I will try to add it you can use
Instagram Finder  provides an easy way for developers and designers to get Instagram account numeric ID by username.


Panel (FM6126) DCYH-P2-6464-1515-VP seems to overlay second and fourth section with first and third

Hi,
I have following panel:

DCHY-P2-6464-1515-VP

with layout:

https://github.com/esden/led-panel-docs/tree/master/DCHY-P2-6464-1515-VP

Using a NODEMCU ESP32 Dev KIT connecting following pins on the HUB 75 E:

R1: 25

B1: 27

R2: 14

B2: 13

A: 23

C: 5

CLK: 16

OE: 15

G1: 26

GND

G2: 12

E: 32

B: 19

D: 17

LAT: 4

GND

After flashing the display and the clock works but the display seems to not order the 4 section properly and overdraws them.
(Will try to attach a picture of this).
Seems positioning is wrong or the panel runs in 32 row mode?
Any pointers to what might be the issue?
Thanks, Trant

Do not mind the actual wifi connection error. That works, but the picture shows nicely that the top part of the wifi symbol is positioned in the first segment and not the second.
Hope this helps.
Thanks, Trant

Hi Trant! It's possibly a wiring problem, is it possible to follow this scheme here ->
https://github.com/jnthas/clockwise/blob/gh-pages/static/images/display_esp32_wiring_bb.png

The board I got off aliexpress does this too. They have their own github which is somewhat annoying if I cant use the default web flasher. https://github.com/sjh007/hub75-64-64 - would be good if this was able to be compiled for that board too without me having to install a whole development environment.


Update libfmt to a tagged release with complex support

While adding fft operators to bland (to support #54)  I  need to add at least some comlpex number support. The first thing I added was a repr() operator to just print out values because there's some complication going to numpy...
I had to update libfmt to a recent commit because complex support was added in Mar 13 (https://github.com/fmtlib/fmt/issues/1467, commit: https://github.com/fmtlib/fmt/commit/73f2b344b2033b609ebde341650c88bfffe3af82#diff-f82ce183442c6e77ea3fe297e25d5393cc13067caeb951a36923cbdba0c5a36f)
Now we're just pointing to some random commit since then. When they tag a release upgrade the content we fetch to the released version.

11.0 seems to be tagged with that commit. I tested 11.0.2 and it works with no issues, but produces a lot of compiler warnings about unreachable loops. That's not such a big deal, but going to leave this alone until I can fineness

11.0 seems to be tagged with that commit. I tested 11.0.2 and it works with no issues, but produces a lot of compiler warnings about unreachable loops. That's not such a big deal, but going to leave this alone until I can fineness


iOS gets Error code: 402 when reading data from monitorCharacteristic()

[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: BleError (Error code: 402, ATT error code: 2, iOS error code: null, Android error code: null, reason: Reading is not permitted., internal message: null, device ID: 48E32FDC-BC25-0B46-AC03-549FD00B26B8, service UUID: ce060030-43e5-11e4-916c-0800200c9a66, characteristic UUID: ce060039-43e5-11e4-916c-0800200c9a66, descriptor UUID: null)
Android works with no errors but iOS throws this when data is received in the listen() from monitorCharacteristic steam.

looks like this already has an answer in #549

The characteristic you're trying to read does not support reading, only notifications. Use .monitor() and listen to the stream.

unable to reproduce on iOS 15.0.1 or 15.7.1. seems like it may be limited to iOS 16 in some way.
it seems like there is also precedent for iOS doing weird stuff from version to version given that a fork (https://github.com/davejlin/flutter_ble_lib_ios_15) seems to have been created by someone who needed iOS 15 support

I have now tested this with an iPhone 13 Pro on 16.0.0 and an iPhone 12 Pro on 16.0.2 and found the same issue on both further enforcing the idea this is an iOS 16 specific issue. I'll change the title to reflect this.


fix(line-card-range): remove datasource range from editor render of linecard

Summary
The TimeSeries cards in the dashboard editor were incorrectly looking at the the dataSource.range prop for the timeRange on a TimeSeries card.
Change List (commits, features, bugs, etc)
Remove the timeRange prop definition from the TimeSeriesCard render in the dashboard editor
Acceptance Test (how to verify the PR)
Go to the DashboardEditor With initial values story and see that the TimeSeriesCard is properly set to thisWeek and the time range picker in the cardEditor is pre-populated.

:tada: This PR is included in version 2.141.0-next.34 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.141.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support initial value for optional key

I have:
extension Defaults.Keys {
	static let refreshInterval = Key<TimeInterval?>("refreshInterval")
}

And I would like to specify an initial value, meaning one that is used before any value is set. This is different from default, which is used whenever the value is nil, which would not work here as it would make it impossible to set the value to nil, which is the whole point of making the value optional.
What I'm thinking:
extension Defaults.Keys {
	static let refreshInterval = Key<TimeInterval?>("refreshInterval", initialValue: 3600)
}

The problem is that there's no good way to differentiate whether a key unset or nil.

object(forKey:) returns nil whether it's unset or set to nil.
suite.dictionaryRepresentation().keys.contains(key) returns nil whether it's unset or set to nil.
suite.persistentDomain(forName:).keys.contains(key) would work, but we only have the suite instance, not the suite name. And the suite instance doesn't expose the suite name...
CFPreferencesCopyValue returns the true value ignoring the suite.register defaults, but it requires a suite name.

Possible solutions:

Force passing a suiteName parameter too if you want to use initialValue with a non-standard suite. (and use CFPreferencesCopyValue)
Keep track of keys that are set in an internal UserDefaults entry.
Other ideas?

@hank121314 Any opinions on this?

IMO, Although the second solution will be more user friendly, it will create an extra space storage(internal UserDefaults).
I prefer the first one 😄.
So bad we could not retrieve the suite name from suite 😭 .

Yeah, I agree. The most common use-case is to use the standard suite anyway.

Seems like CFPreferencesCopyValue does not work either, at least on macOS 13. Maybe it used to work. So it looks like we'll have to manage the state ourselves.
I'm thinking we can store it in a key called __DEFAULTS__keysThatHaveBeenSet. It would be an array of keys that have been set once.
The init would be:
public convenience init<T>(
	_ key: String,
	initialValue: Value,
	suite: UserDefaults = .standard
) where Value == T? {}


Draft Create Auto Detect .gradle file during Java detection

Is your feature request related to a problem? Please describe.
When running draft create on the following repo, draft prompts for gradle or maven https://github.com/codecov/example-java-gradle
[Draft] --- Detecting Language ---
Use the arrow keys to navigate: ↓ ↑ → ←
? Linguist detected Java, are you using maven or gradle?:
  > gradle
    maven

Mention what platform you want to support the new feature
OSS
Describe the solution you'd like
Draft should detect the *.gradle files in a repository to determine if gradle is used.
Describe alternatives you've considered
A better method for detecting gradle or maven could be used. The build files are the best way I could determine.
Additional context
(none)

@msftph Thanks for raising this request. Are you requesting for draft to detect the languages looking at the files like *.gradle or pom.xml and auto assume without asking the user for confirmation?  for ex: ````are you using maven or Gradle ? ``` part. If that's the case, we can actually do it, but I need to consult with my team if that's okay.
if file contains pom.xml then
 language = maven
else if file contains *.gradle then
   if a folder contains gradle/wrapper and it is not empty then
      language = gradlew
   else
      language = gradle
else
  "ask the user to select" ?

Yes. #228 , #223 and this issue are all similar requests. The idea to default the selection would be the best approach if you can't suppress the message.


update Google Pay API JavaScript URL and object reference URL

Documentation changes only.
Google API changed its JavaScript URL in May 2018.
Update link to Google Pay API Web object reference documentation.
Google Pay API reference documentation documents the structure of the object passed to loadPaymentData() as "PaymentDataRequest" not "Payment Data Request"; change documentation mentions to match.

Thanks!


[report-converter] Sparse parser

Sparse report converter tool for parsing Sparse output of kernel sources

sparse creates multi-line error messages, but this report-converter here does not parse those correctly. Please rework that.

sparse creates multi-line error messages, but this report-converter here does not parse those correctly. Please rework that.

@bulwahn @csordasmarton  So should we include that multi-line messages with the message of the original file? Because those lines to have a path,line and column number?

@bulwahn @csordasmarton  So should we include that multi-line messages with the message of the original file? Because those lines to have a path,line and column number?

Well, sparse has a very special syntax for its output... it would be best to just repair the sparse output to be more like clang-analyzer or clang-tidy, but for the time being, you need understand which lines belong to previous warning line and when a new warning line starts. You can have a look at Argert's implementation (he got that right).

Well, sparse has a very special syntax for its output... it would be best to just repair the sparse output to be more like clang-analyzer or clang-tidy, but for the time being, you need understand which lines belong to previous warning line and when a new warning line starts. You can have a look at Argert's implementation (he got that right).

@csordasmarton @bulwahn I think I have made the required changes to recognize the multi-line comments Kindly have a look and let me know if any modifications are required?

@csordasmarton @bulwahn I think I have made the required changes to recognize the multi-line comments Kindly have a look and let me know if any modifications are required?

@csordasmarton Apologies for changing the approved code of the Parser. I noticed a bug while re-writing the test cases and hence decided to fix it. Kindly have a look at the modified code

It is "its converter", not "it's converter" in the commit message header of the third commit.

Review is done; I will start testing...

@csordasmarton Kindly have a look 😄

@csordasmarton removing this and the above-mentioned regex was actually creating a separate sample.h.plist file and not appending it to sample.c. Nevertheless, I have modified the code to not include the files/sample.c: note: in included file: line in the output

@csordasmarton I think the current code solves the issues discussed above by us. Kindly have a look and let me know what you think

@csordasmarton I have made the changes suggested by you! Kindly have a look😄


Investigate methods for mfem and axom co-development

We should look at using an mfem submodule (without the cmake add_subdirectory!) or the spack dev environment for co-development of mfem inline with Serac. This should be optional so users don't have to worry about this process.

This came up again so it should get bumped to the top of the priority list.

Exploring MFEM as a submodule identified an issue that will be fixed by https://github.com/mfem/mfem/pull/1986


Registering new ciphers

So I don't know if I'm doing something wrong or if I'm encountering a bug. I'm trying to register a new cipher like so:
static char XCHACHA20_CIPHER_NAME[] = "xchacha20poly1305";
static const CipherDescriptor XChaCha20Descriptor = {
	XCHACHA20_CIPHER_NAME,
	&alloc_cipher,
	&free_cipher,
	&clone_cipher,
	&cipher_get_legacy,
	&get_page_size,
	&get_reserved_size,
	&get_salt,
	&generate_key,
	&encrypt_page,
	&decrypt_page
};
static const CipherParams XChaCha20Params[] = {
	{nullptr, 0, 0, 0, 0},
};

(This uses my project's crypto library for the project I'm working on, hence the cipher for uniformity.) However, whether I put the & before the functions or not, I still get SQLITE_ERROR when calling sqlite3mc_register_cipher. All of the functions match the function signatures and from what I can tell I'm doing everything right according to how other ciphers are registered, but if this isn't a bug, am I doing something I shouldn't be doing?

So I don't know if I'm doing something wrong or if I'm encountering a bug.

Yes and yes. It's a bug in your code.

I'm trying to register a new cipher like so:
static char XCHACHA20_CIPHER_NAME[] = "xchacha20poly1305";
static const CipherDescriptor XChaCha20Descriptor = {
	XCHACHA20_CIPHER_NAME,
	&alloc_cipher,
	&free_cipher,
	&clone_cipher,
	&cipher_get_legacy,
	&get_page_size,
	&get_reserved_size,
	&get_salt,
	&generate_key,
	&encrypt_page,
	&decrypt_page
};

This should work, but using ampersands (&) here is not necessary, but does no harm either.
Have you ever inspected a single cipher scheme implementation of SQLite3 Multiple Ciphers? You should. It could make your life easier.

static const CipherParams XChaCha20Params[] = {
	{nullptr, 0, 0, 0, 0},
};

This is wrong.
Again: Have you ever inspected a single cipher scheme implementation of SQLite3 Multiple Ciphers? You should. Really.
Read the code and try to understand what's going on. Or do it in the same way as it is done there.

[...] and from what I can tell I'm doing everything right according to how other ciphers are registered, but if this isn't a bug,

I can assure you that it isn't a bug in SQLite3 Multiple Ciphers.

am I doing something I shouldn't be doing?

Yes.

Have you ever inspected a single cipher scheme implementation of SQLite3 Multiple Ciphers? You should. It could make your life easier.

Yes, I have. Several times, in fact.

This is wrong.
Again: Have you ever inspected a single cipher scheme implementation of SQLite3 Multiple Ciphers? You should. Really.
Read the code and try to understand what's going on. Or do it in the same way as it is done there.

There's no need to be condescending about it. Regardless, I have indeed tried to do exactly what is done internally, but for whatever reason, if I do:
static const CipherParams XChaCha20Params[] = {
	{"", 0, 0, 0, 0},
};

My compiler complains and says it can't cast const char[1] to char*. So using nullptr was the only way I could think of to fix that problem. It's the same reason I do the name string explicitly: the struct takes a char* as the cipher name, which means you can't use string literals, in C++ anyway. In the C code you use macros and somehow this is able to get around that particular problem (or maybe it's compiling it in C mode).

Regardless, I have indeed tried to do exactly what is done internally,

Using nullptr instead of an empty string "" is not exactly the same as done in the cipher implementations. There the macro CIPHER_PARAMS_SENTINEL is used to mark the end of the list of configuration parameters. And the macro uses an empty string for the parameter name, not a nullptr.

but for whatever reason, if I do:
static const CipherParams XChaCha20Params[] = {
	{"", 0, 0, 0, 0},
};

My compiler complains and says it can't cast const char[1] to char*.

Which compiler do you use? Which compiler options do you use?
During development SQLite3 Multiple Ciphers is compiled with various compilers, and the code compiles without problems.
BTW, I'm not condescending, when I tell you to carefully inspect the existing code. The details matter. If you look closely you will detect that the CipherParams structures are not allocated with the const attribute. And that has a reason, namely that the values are modifiable. Remove the const attribute, and the code should compile without error.
You may complain that the dynamic cipher scheme feature is not well documented. And you are right. However, originally the component was never meant to be extended by dynamic cipher schemes. It can well be that there are minor issues requiring small adjustments to the code.

So using nullptr was the only way I could think of to fix that problem.

It's not the only possible solution. Using casts would be another option.

It's the same reason I do the name string explicitly: the struct takes a char* as the cipher name, which means you can't use string literals, in C++ anyway.

SQLite3 Multiple Ciphers consists of C code, not C++. You have to compile it in C mode

In the C code you use macros and somehow this is able to get around that particular problem (or maybe it's compiling it in C mode).

Yes, it is C code and I would recommend to compile in C mode.
Or you adjust the code to be compilable in C++ mode. You are free to do that.

Which compiler do you use? Which compiler options do you use?
During development SQLite3 Multiple Ciphers is compiled with various compilers, and the code compiles without problems.

I am using MSVC 2022 in C++20 mode. The code that calls into SQLite3MC is C++ code. Removing the const qualifier does not actually resolve the compiler error. We are also compiling in non-permissive mode (/permissive-) since the project is cross-platform.

SQLite3 Multiple Ciphers consists of C code, not C++. You have to compile it in C mode

I'm pretty sure that's what happens. This is a bug in my C++ code, though. If I c-style cast it to char* I obviously get a nasty crash at run-time. Does SQLite3MC ever modify these strings? If not it might be better to make them const.

So I managed to hack it with std::string`, ironically enough. It works, I suppose. Not the solution I would like, but Idk what else to try other than to maybe move the cipher registration code into a C file.

Aaaaaand I just realized that didn't solve it. Sigh.

Okay,, I've resolved this problem, thank you fro the help :)

@ethindp FYI:

The signature of GenerateKey will change in the next version. The parameter BtShared* pBt will be removed from the parameter list. The parameter cipherSalt will point to a 16-byte buffer containing the key salt or will be a NULL pointer. If cipherSalt equals NULL or parameter rekey equals 1, new random key salt must be generated.
The type of the m_name member of the CipherParams struct will change from char* to const char*. That is, you will hopefully not be forced any more to jump through hoops to avoid compile time problems with C++.

The next version of SQLite is expected next week. A new version of SQLite3 Multiple Ciphers will be released shortly thereafter (probably 1-3 days later).

@utelle Thank you for the heads up. I did try implementing rekeying/salting support but I was getting very strange crashes (sigsegv) even though I'm pretty sure my boundaries were correct. Specifically, I was encrypting data + 24.. (len - reserved). So I've temporarily just switched pack to encrypting the entire page without a salt. I'm not necessarily happy with it because it lowers the entropy of the keys, even with my use of HKDF, so I'm hoping to replace HKDF with Argon2 or something (but need to nail the salt problem first). I'll wait though until this next update since the work I'm doing isn't super critical and wait since I don't have any users of encrypted DB support quite yet.


feat: add foundation for design system

This pull request adds the first base design tokens for the clada design system.
Following are included:

Introduction doc
Colors
Gradients
Spacing

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(cli): add argument to specify filename

Add argument:
    -n, --filename NAME sets and overrides the filename

Example:
rpaste -n filename-on-server.txt awesome.txt

closes #82

I could also add to the README that rustypaste 0.15.0 is required for this argument to work. If the server is <0.15.0, the filename will not be overriden.


Several bugs are detected by SAST tools

Hi guys!
Static analysis tools detected a some potential weakness in your project

1

QXlsx/WebServer/recurse.hpp in line 526: Access of moved variable 'prev'.

2

This errors are classified as CWE-457. It might cause undefined behavior
QXlsx/header/xlsxchart_p.h in line 38: Not all members of a class are initialized inside the constructor. Consider inspecting: type, axisPos, axisId, crossAx.
QXlsx/source/xlsxchart.cpp in line 17: Not all members of a class are initialized inside the constructor. Consider inspecting: sheet, legendPos, legendOverlay, majorGridlinesEnabled, minorGridlinesEnabled.

3

QXlsx/source/xlsxzipreader.cpp in line 57: An excessive check can be simplified. The '||' operator is surrounded by opposite expressions 'fi.isFile' and '!fi.isFile'.
This error is classified as CWE-571

4

QXlsx/source/xlsxstyles.cppin lines 618 and 621: The conditional expressions of the 'if' statements situated alongside each other are identical.

5

QXlsx/source/xlsxworksheet.cpp: The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 796, 812.
It is strange code

6

QXlsx/source/xlsxworksheet.cpp in 1411 There are identical sub-expressions '!(d->MoodFooter.isNull())' to the left and to the right of the '||' operator.

Also static analysis tools reported several minor issues which might be good to fix

1

QXlsx/source/xlsxdrawinganchor.cpp in line 665
The '!xIn_w.isEmpty()' condition was already verified in line 664.
QXlsx/source/xlsxdrawinganchor.cpp  in line 875
The '!xIn_w.isEmpty()' condition was already verified in line 874.
This checks are not required. It is error that classified as CWE-571.

2

File: QXlsx/QXlsx/source/xlsxconditionalformatting.cpp
Line 188: Expression 'type >= Highlight_LessThan' is always true.
Line 203: Expression 'type >= Highlight_ContainsText' is always true.
Line 247: Expression 'type >= Highlight_Top' is always true.
Line 255: Expression 'type >= Highlight_AboveAverage' is always true.
Line 257: Expression 'type <= Highlight_BelowStdDev3' is always true.
It is possible wrong logic

3

QXlsx/source/xlsxworksheet.cpp in line 2439: The 'cellType' variable was assigned the same value.

4

QXlsx/source/xlsxrelationships.cpp:72: It is odd that the body of 'worksheetRelationships' function is fully equivalent to the body of 'documentRelationships' function.

5

QXlsx/source/xlsxdocpropscore.cpp:104: Two similar code fragments were found. Perhaps, this is a typo and 'cp' variable should be used instead of 'dc'.

6

QXlsx/source/xlsxworkbook.cpp:546: The code contains the collection of similar blocks. Check items 'writeEndElement', 'writeEndElement', 'writeEndDocument' in lines 546, 548, 549.

Dear @ProjectMutilation
Thanks for reporting.
I'll register this issue.


Invoice/Parcel signing

The signing needs to be implemented on bindles and parcels.

Was this closed by #76?

I need to revisit the parcels to see if anything does need to be signed given our re-architecture. Then we have to actually implement the signing in the CLI and server.

Oh! I just saw #89, which covers the remaining tasks. So I will close this one.


In production, it breaks build

I'm using react-stockcharts as a dependency and after initial devel tests, I tried to build a production package for my app. Howerver, using react-stockcharts seems to break production build:
ERROR in 0.2029fa2a064de68e00ef.chunk.js from UglifyJs
Invalid assignment [0.2029fa2a064de68e00ef.chunk.js:34188,80]
This happens only of I include stockcharts to my project (and only on production build phase). Does react-stockcharts use es6 features, who are known to break the UglifyJS minification process? Any ideas on that?

OK, andwering my own question: it seems that the d3fc-rebind package depends on legacy uglifyjs package, so even if someone changes the minifying process to use uglify-es/UglifyJS3, errors still come up. I'm leaving this open, in case the project owner wants to comment something on this, before closing it.

I see. thanks for the details. I suppose removing the dependency to d3fc-rebind would solve this problem.

Hi, I am still having this issue with stockcharts version "0.7.0-beta.13" are you planning to fix this soon?

Removed usage of d3fc-rebind and published a 0.7.0-beta.14 can you try if this fixes the problem?

You fixed it.  Thanks so much!

perfect thanks for confirming


How to incorporate unit testing

Hi there, any suggestions on how we override the requires_auth decorator in order to run unit testing? Thanks

I had the same issue, and mocked with a "passthrough" :
mocker.patch("fastapi_microsoft_identity.auth_service.requires_auth", lambda x: x)

auth_module = sys.modules["fastapi_microsoft_identity"]
importlib.reload(auth_module)


Add ignoreNull property

Closes #595

Current coverage is 96.09%

Merging #642 into master will increase coverage by +0.88% as of 02cae9f

@@            master    #642   diff @@
======================================
  Files           85      86     +1
  Stmts         2550    2535    -15
  Branches       323     317     -6
  Methods          0       0
======================================
+ Hit           2428    2436     +8
+ Partial         32      28     -4
+ Missed          90      71    -19

Review entire Coverage Diff as of 02cae9f

Powered by Codecov. Updated on successful CI builds.

2 oks from #643


[GEMMA] from_hugging_face not setting share_embedding_table to True leading to incapacity to load Gemma

Gemma requires shared_embedding_table to be True but coming from from_hugging_face doesn't set this parameter.

@mfuntowicz Thanks for your contribution to TRT-LLM, we'll take a look this change firstly.

Opening an internal MR for that.

Hi @mfuntowicz , thanks for your contribution, we've merged your changes into our internal code base and will upstream to main branch next week

Hi @mfuntowicz , the main branch has been updated with your changes integrated, thanks a lot for your contribution.
I'm closing this PR, please let us know if there are any questions. Thanks.