Add parameter to allow user to set bottom bar backgrond color along w…

There was an issue reported where user was not able to see bottom bar button when background color was white. So i have added parameter to let user specify the background and button color.

@krishnajithapa thanks for your PR.
I think that the changes should be present in ChewieController if they are not overridden in Chewie by the user.
In other words, ChewieController should hold immutable Color properties related to this PR, and they should be used in MaterialControls as well as MaterialDesktopControls. If those two classes specify an optional custom color value, then use those values, otherwise fallback to the controller.
Chewie, PlayerWithControls, and AdaptiveControls should funnel the user-defined optional Color properties into MaterialControls and MaterialDesktopControls`.


Move temporary Swarming task directory on Windows

I'm running into path length limits on Windows when I attempt to add a CIPD package: https://chromium-swarm.appspot.com/user/task/2fbf2050bd91b510
In that example, the temporary Swarming task directory is c:\users\chrome~1\appdata\local\temp\1\isolated_runbx9xjw.
Could we shorten this to something like c:\b\t_bx9xjw ?

cc @vadimsht

fs.extend() should be called in the corresponding cipd.py code, if relevant.
I'll make a separate CL to reduce isolated_runXXX to irXXX, which will save 10 characters (OMG!).

@erock2112 do you want to keep it open as to migrate the temporary directory to always be under the bot directory? I came to think it's a good idea anyhow.

I haven't had a chance to test it out, but those 10 characters might not have done it all.  In general, I think it'd be great to use /b/tmp/abc123 instead of the current long path.

That was not enough, will shave off another 12 characters.

I also did this for the cipd side, but it hasn't been deployed yet: https://github.com/luci/luci-go/commit/e1a0627cdf3f8ea84b56f8b104524246ec6214e2


usage information missing for Create Completions, Create Edits and Create Embeddings responses

In June, usage info was added to several API responses.
The API Reference documentation was updated in three places:

Create Completions
Create Edits
Create Embeddings

However, this data is missing from the OpenAPI specification.
Can this please be added?
@schnerd do you know if this is likely to be added soon?
Thank you

Just added this – published in openai-node 3.0.1

Thank you @schnerd, having usage info is great 👏


[BUG]  Incorrect command in mempool space install

Describe the bug
Chown command is executed, but it should be chmod
sudo chown 600 /home/mempool/mempool/backend/mempool-config.json
should be
sudo chmod 600 /home/mempool/mempool/backend/mempool-config.json
Location in guide
https://raspibolt.org/guide/bonus/bitcoin/mempool.html

Thanks @visskiss! Would you be interested to write a PR for the the issues you've idenitifed?
There are also issues #918 and #919 that concerns the Mempool guide. We could maybe do one PR that fixes the four issues at once maybe.. wdyt?

Yes, happy to assist. Do you want me to branch off master and then organize a pull request or do you have some other system (git flow?).

Yes, happy to assist.

Thanks a lot! :)

Do you want me to branch off master and then organize a pull request or do you have some other system (git flow?).

I don't think we'be been using git flow so far.. but I'll let @Stadicus answer you on this though as I'm very inexperienced with git.


Return Early Pattern for Functions

Challenge Name

Issue Description

Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

What exactly is the issue? Please share more information.
The issue tracker is for reporting bugs only. Please use the help chat room or try looking through the forum for help with a specific challenge.
Happy Coding.


Thread.java:745 when adding user with metacharacter

Description
java.lang.Thread.run(Thread.java:745) when running pex against user with underscore in name
/pex user jaykob_lussier group set Member
[Insert description of issue here]
Detailed Information
Is available here

Do you get the same error when you enter the username within quotation marks?
/pex user "jaykob_lussier" group set Member

I did, yes.  This may be a non-issue, however.  I just had to bounce my
server for another issue, and when we came back up this issue was no longer
occurring.  I was having to work on a several plugins to setup some
configurations, so it's possible that I encountered a problem after
reloading one of them and it all went downhill from there.
The two things I unsuccessfully attempted when it was a problem, however,
were to enter the name as "jaykob_lussier" and "jaykob_lussier".  Not sure
if you can escape a control character from the mc command line, but it was
worth a try I suppose.
Thanks for looking at this.  Not sure if it's worth investing time into
since it's working now.  I can certainly just upload additional data later
if it happens again.
On Sun, Jan 18, 2015 at 2:15 AM, Stormbow<EMAIL_ADDRESS>wrote:

Do you get the same error when you enter the username within quotation
marks?
/pex user "jaykob_lussier" group set Member
—
Reply to this email directly or view it on GitHub
https://github.com/PEXPlugins/PermissionsEx/issues/1862#issuecomment-70398966
.

I have the same problem and it throws an exception, the user is Baron_PAPIMAFIA, 15 chars and underscored sign. He was on a timed group on previous version and with this version it expired and now have problems.
http://pastebin.com/bpyzg3gj
and
[15:18:00] [Server thread/INFO]: Alphabravo9 issued server command: /pex user "Baron_PAPIMAFIA" group set Usuario
[15:18:00] [Server thread/INFO]: Héroe
[15:18:01] [pool-13-thread-1/WARN]: java.io.IOException: Server returned HTTP response code: 400 for URL: https://api.github.com/gists
[15:18:01] [pool-13-thread-1/WARN]: 	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1626)
[15:18:01] [pool-13-thread-1/WARN]: 	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
[15:18:01] [pool-13-thread-1/WARN]: 	at ru.tehkode.permissions.bukkit.ErrorReport.gistText(ErrorReport.java:120)
[15:18:01] [pool-13-thread-1/WARN]: 	at ru.tehkode.permissions.bukkit.ErrorReport$Builder.build(ErrorReport.java:372)
[15:18:01] [pool-13-thread-1/WARN]: 	at ru.tehkode.permissions.bukkit.ErrorReport.withException(ErrorReport.java:328)
[15:18:01] [pool-13-thread-1/WARN]: 	at ru.tehkode.permissions.bukkit.ErrorReport$2.run(ErrorReport.java:193)
[15:18:01] [pool-13-thread-1/WARN]: 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
[15:18:01] [pool-13-thread-1/WARN]: 	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
[15:18:01] [pool-13-thread-1/WARN]: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[15:18:01] [pool-13-thread-1/WARN]: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[15:18:01] [pool-13-thread-1/WARN]: 	at java.lang.Thread.run(Thread.java:745)

Not been able to get any actual stacktraces from users due to the fact that the commands system has issues. Not really worth the time to invest in a system that is going to be trashed anyway.


Use existing connection if specified in config

The changes in #266 break sneakers if you are specifying a :connection in your config. This PR should fix it. I added a test against a private method, which I normally wouldn't do, but it seemed like the expedient way to test the bug.

I believe #322 addresses the same problem, please take a look.

Duplicate of #322.


Stop vendoring packages

The current implementation of Setuptools has its dependencies (separately for setuptools and pkg_resources) vendored into the package. The project implemented this approach because of the bootstrapping problem.
Bootstrapping Problem
Setuptools extended distutils, which was designed to sit at the root of a packaging system and presumed to be present and without any dependencies. Over time, Setuptools superseded distutils but inherited these constraints. In particular, when a system integrator wishes to build a system from sources, it requires a directed acyclic graph (DAG) of both build-time and runtime dependencies. As a result, Setuptools cannot depend on any package that uses Setuptools to build (or whose dependencies require Setuptools to build). This bootstrapping problem includes Setuptools itself, as it requires itself to build.
Vendoring
As the ecosystem grew more complex, with standards-based implementations (such as packaging) appearing as third-party packages and not available in the standard library, Setuptools found itself requiring dependencies, but because of the bootstrapping problem, Setuptools adopted a vendoring strategy (copying the packages directly into the project) as a means of requiring that functionality.
However, this approach creates constraints and complications to the project:

Not all packages can be vendored.

If the other package has vendored dependencies, those may not work in a vendored context.
Some packages have global state or modify global state or have interfaces that are reliant on the package layout (incl. pkg_resources, importlib_metadata, packaging), leading to unexpected failures when loaded in a global context.

Refactoring functionality out of the library is difficult if not impossible due to the constraints above. In particular, this project would like to move pkg_resources into a separate package, but even though pkg_resources has no dependency on setuptools to run, it still must vendor its own dependencies (is this true?).
When vendoring a package, it often is required to be rewritten to accommodate vendoring. Any absolute imports must be replaced by relative imports.
Because vendoring is a second-class approach to dependency management (and unsustainable in the general case), it often requires specialized tooling to manage the dependencies and this management can often fall in conflict with the first-class tools.
When vendoring dependencies, it's the responsibility of the hosting package to re-write imports to point to the vendored copies, creating non-standard usage with sometimes unclear semantics.
Due to the constraints above, adding a new dependency can be an onerous process, requiring extra care and testing that may break in downstream environments whose workflows aren't proven.
Because vendored dependencies are in fact de-facto satisfied, the project cannot and should not declare those dependencies as other projects do. Therefore, it's not possible to inspect the dependencies readily as one would with standard declarations.
Because vendored dependencies are effectively pinned, they create impedance and require manual intervention or extra, non-standard tooling to manage the evolution of those dependencies, defaulting to a practice of erosion.

Because they're pinned, it's more difficult to discern if a particular dependency is pinned for a known good reason or simply because of the vendoring.

The readme for vendoring talks only about how the project is used for pip only and provides no guidance on how to use it.
I guess you're proposing that I reverse-engineer the usage from pip's usage and then try to apply that to this project. I guess I can give that a try.

In pradysung/vendoring#37, I learned that the vendoring project is uninterested in supporting the complexity of Setuptools, so if Setuptools were to adopt vendoring, it would need to at the very least provide its own orchestration of invoking vendoring across multiple configurations, which is barely preferable and in some ways more duplicative to the current vendoring technique. Moreover, other issues like pradyunsg/vendoring#38 suggest that vendoring requires supplying default values even for basic operation, so that would bring extra cruft that would need to be copied across multiple configs. At some point, I might consider forking vendoring to satisfy some of these needs, but for now, as long as vendoring is needed, Setuptools can continue to use its own technique.

I would really love to see making unbundling easier without making bootstrap very hard. That said, as a distro packager I don't need it "perfect" from pure pip standpoint.
One possibility that I think might be worth exploring is trying to make a subset of setuptools needed for bootstrap work with smaller number of vendored dependencies, possibly via gracefully handling missing packages and running with limited functionality without them. I think we could at least avoid more-itertools and ordered-set this way.

Honestly, I don't see this happening anymore, given that every subsequent release of setuptools adds more vendoring, and it literally takes hours to make setuptools work unvendored. On top of this, patched pyproject_validator basically made including new versions of setuptools in Gentoo impossible.

I'm sorry, nevermind, I can't even read package names right.

Hi @mgorny I am sorry the latest vendored packages affect Gentoo.
Regarding validate_pyproject specifically, it is working as a "code-generator" for validator, much like protobuffers would do, instead of vendoring the entire JSON schema library.
Is this approach still problematic? Would it help if I move the validate_pyproject out of the _vendor directory to make the distinction better?
What are the approach you guys use when dealing with projects that use generators?

The directory doesn't matter much for us, we just mangle all the references to use the external package.
As for generators, we prefer to rebuild everything. I don't know whether this is the case here but normally we assume that e.g. updated dependencies (like cython) could result in different output, possibly fixing some bugs that might have been present in the original generated version.

Thank you very much for the information @mgorny. Let's see how we can solve this.
Currently there is a command for re-generating the files from validate-pyproject together with the commands to install the vendored dependencies.
I could also create a separated script for generating the files, does that help?
(This script however is going to require Python dependencies, so I guess in the end it would create a dependency cycle... Having the files directly in the repository are a way to break this cycle)
Do you have other suggestion?

If you don't mind bearing with me for a while more, could we please take a step back and verify whether I'm understanding things correctly? IIUC:

_validate_pyproject is a package generated by validate_pyproject with help of fastjsonschema. The exact contents of _validate_pyproject depend on these two packages and can change if they are updated.
_validate_pyproject doesn't have any setuptools-specific content, i.e. if another project used validate_pyproject, it would get the same result. Therefore, it is possible to share the code between multiple packages.

If both points are correct, then I think the best long-term solution would be to actually split validate_pyproject into two packages installable via pypi: one with the generator, and the other with the generated content. Then setuptools could use the regular kind of vendoring that we're prepared for. It won't be ideal but we can look into the problem of regenerating it separately. Bonus points if you could use flit as the build system for it since it's the only build system that doesn't come with a dozen of cyclic deps.
If that's a bit much, I think moving _validate_pyproject out of _vendor would also help us after all. Out unbundling logic is pretty much two regexps and while I suppose we could hack it around to exclude _validate_pyproject, it would be much easier if we didn't have to.
I'm sorry about my attitude yesterday.

Thank you very much for the input @mgorny.

_validate_pyproject is a package generated by validate_pyproject with help of fastjsonschema. The exact contents of _validate_pyproject depend on these two packages and can change if they are updated.

Precisely. The way fastjsonschema works is to compile JSON schema files into Python code[^1]. validate-pyproject adds some structure to this compilation for pyproject.toml + it hosts general schemas that cover PEP 518/621.

_validate_pyproject doesn't have any setuptools-specific content, i.e. if another project used validate_pyproject, it would get the same result.

This is more or less what happens. The idea for validate-pyproject is to be general and host only the models for PEP 518/621. However it is also designed to allow third-party plugins to define models for the [tool.<...>] tables. Therefore you can share the logic between multiple packages, but it is also extendable.
Currently, validate-pyproject is hosting some JSON Schema files for setuptools, but the general idea is to move them to the setuptools repository in the mid-term, so contributors/maintainers can change the way they want [tool.setuptools] to be [^2].
Regarding the proposed solutions, I think both could work. My preference however would be the second approach (because of the mid-term vision of moving the tool-specific specs to setuptools). If that is fine with you I can go ahead and start working in this plan (I will just ask a bit of patience because I am still working on some issues regarding PEP 621 support).
[^1]: You can still run things directly without ever having to save the Python file to the disk, but you are basically eval-ing the generated string.
[^2]: While I was working on bringing support for PEP 621 into setuptools, I just decided to leave the schemas in validate-pyproject for simplicity. But my goal is not to have validate-pyproject to be the gatekeep of how setuptools wants to evolve its configuration (it is too much overhead for everyone).

Thanks for the explanation. If the end goal is for setuptools to host the schemas, then let's focus on the second option indeed. It'd still be nice to able to easily regen the resulting data but I don't think that's a priority, i.e. something to put on the "far TODO".

In https://github.com/pypa/setuptools/issues/4455#issuecomment-2203461914, I've been thinking maybe there's a better way to vendor dependencies that's far less intrusive and doesn't require re-writing the vendored packages. I'm exploring that now.

For the record, one risk I see is that if the user has an incompatible version of the dependency installed, setuptools would use it rather than the "vendored" fallback — but perhaps there's a smart way of avoiding that.

For the record, one risk I see is that if the user has an incompatible version of the dependency installed, setuptools would use it rather than the "vendored" fallback — but perhaps there's a smart way of avoiding that.

Good point. On one hand, I was thinking that concern is to be addressed the same way it is for any other application or library - that is, declare the best estimate of what dependencies are compatible, put the onus on the user to supply compatible packages (when things break). There are two problems with that way of thinking:

Setuptools is often in a unique situation of being applied to very old packages and environments. A user could easily get a old version of Setuptools that (now) could depend on a very much newer incompatible dependency.
Users have limited control over what packages are resolved by pip or whatever package builder is employed. IIRC, there's no way to apply constraints to pip for build dependencies.

One way to mitigate this concern could be to (a) require that dependencies follow semver, (b) proactively pin against breaking changes, and (c) lean on the dependencies to yank any unexpected breakages that violate semver.
I would like to pursue a world where vendored dependencies are used rarely and there's little to no dependence on their stability. In other words, I'd like for Setuptools to "work at head" of the Python ecosystem (unless explicitly indicated otherwise).

In #4457, I'm pleased to say I have an initial proof of concept that applies the concept and is largely working. There are some mypy tests failing, but I'm confident those can be fixed or ignored. Thusfar, I've only partially applied the changes. I plan to continue to pursue the approach and replace the pkg_resources dependencies as well, do some cleanup, and address any emergent issues. I won't be rushing out any releases with this change, but I'm optimistic that a future without heavy reliance on vendored packages is possible.

Oh, one more thing just occurred to me. Some of the setuptools dependencies already avoid the bootstrap problem by using flit_core. This means that they can be built and installed without setuptools, and therefore do not pose a bootstrap problem.

Note that if you would install them with pip, you still need setuptools first.

I can see the underlying error in the traceback.

canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

That's been reported in #4483. I'll be very interested to learn if it's feasible to work around it by upgrading the dependencies (or removing the offending old versions).

The tests run against whatever's in the target distro (Ubuntu 20.04 in this case). At least, not the shared system-wide stuff, usually. I can apply the workaround of the [core] extra for now.

Thanks! Long-term, I'm hoping that setuptools can declare it's actual dependencies, but the problem is probably one of the hardest ones in the Python ecosystem (https://github.com/pypa/packaging-problems/issues/342).


Python inline parameters won't work for Python<3.6

Thanks so much for the awesome extension.
I found a bug for Python inline parameters.
In src/python/pythonHelper.ts#L12, f-strings are used to format strings.
https://github.com/RobertOstermann/vscode-inline-parameters/blob/44fae04770b30327e9d950f01a352135d8533eed/src/python/pythonHelper.ts#L12
However, this feature was introduced in Python 3.6. If the default Python configured in the environment is Python2 or <3.6, the Python features of this extension will not work properly. Specifically, it will have the following error,
[2022-04-11 20:41:00.818] [exthost] [error] Error: Command failed: python /home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.1/out/src/python/helpers/main.py /home/luis/test/test.py
  File "/home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.1/out/src/python/helpers/main.py", line 17
    expression_line = f"expression line: {node.func.lineno}"

As a solution for this, I think you should choose the appropriate Python version in the program (because most computers have both Python3 and Python2 installed).
One of the simplest solutions is to specify the use of Python3 directly in src/python/pythonHelper.ts#L12, but this still cannot ensure that Python>=3.6.
const command = `python ${context.extensionPath}/out/src/python/helpers/main.py ${fsPath}`; // Before
const command = `python3 ${context.extensionPath}/out/src/python/helpers/main.py ${fsPath}`; // After

@l1997i  I do not work in Python much and did not realize that using the f-strings would only work with versions of Python >= 3.6. Thanks for making me aware of that! I have added a fix in commit ffbc5a0, which hopefully solves the problem by using string concatenation with the + operator instead of using f-strings.
I have also added a inline-parameters.python.executablePath setting that allows you to change that command to use python3 instead of the default python.
I have published version 1.1.2. please try that version and let me know if the program now works with Python2 or Python3 versions earlier than 3.6

Still doesn't work. I've set inline-parameters.python.executablePath to python3, but the output says it still runs on Python2.7, which will cause 'Num' object has no attribute 'end_lineno' error.
Traceback (most recent call last):
  File "/home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.2/out/src/python/helpers/main.py", line 39, in <module>
    main()
  File "/home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.2/out/src/python/helpers/main.py", line 10, in main
    analyzer.visit(tree)
  File "/usr/lib/python2.7/ast.py", line 241, in visit
    return visitor(node)
  File "/usr/lib/python2.7/ast.py", line 249, in generic_visit
    self.visit(item)
  File "/usr/lib/python2.7/ast.py", line 241, in visit
    return visitor(node)
  File "/usr/lib/python2.7/ast.py", line 251, in generic_visit
    self.visit(value)
  File "/usr/lib/python2.7/ast.py", line 241, in visit
    return visitor(node)
  File "/home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.2/out/src/python/helpers/main.py", line 21, in visit_Call
    argument_end_line = "argument end line: " + str(argument.end_lineno)
AttributeError: 'Num' object has no attribute 'end_lineno'

By the way, I also manually run the command using Python3,
python3 /home/luis/.vscode-server/extensions/robertostermann.inline-parameters-extended-1.1.2/out/src/python/helpers/main.py /home/luis/test/test.py

it works,
expression line: 4 | expression character: 0 | argument start line: 4 | argument start character: 4 | argument end line: 4 | argument end character: 5
expression line: 4 | expression character: 0 | argument start line: 4 | argument start character: 7 | argument end line: 4 | argument end character: 8
NEW EXPRESSION

I've fix this and make a pull request https://github.com/RobertOstermann/vscode-inline-parameters/pull/5.

@l1997i Did you reload your VSCode window after changing the Python path environment variable? I think it should work after reload and I can add a popup to let users know that.

@l1997i Did you reload your VSCode window after changing the Python path environment variable? I think it should work after reload and I can add a popup to let users know that.

@RobertOstermann Yes, I have. I even reopen the VS Code.

Ok, I have published version 1.1.3 with changes from 4daccfc that should allow Python 2.7 to work with this extension. I also added the Python command that is being run in the inline-parameters-extended output tab. That might show that python3 is being run correctly? If not I am not sure why it is not respecting the setting, but I looked at your PR #5 and like the idea of using the ms-python extension setting for the python path. I will get that merged and push out a new version with those changes.

@l1997i  I have merged your changes and slightly altered them in 078dbe7 to allow for the configured path to take priority when it is set. I published version 1.1.4 with those changes. Let me know if that fixes all the bugs you were seeing.

All bug fixed! Thanks so much!


Tester feedback: something
(ETC_success)

Question ID
email to court success screen

Variable sought
ETC_success

Package version
playground

Form
docassemble.playground4PPO:ppo_and_proposed_order.yml

Details:
In LHI, the "Identifying Information" attachment comes out as part of the Petition rather than as a separate download. In the Docassemble version, it comes out separately.
Unless this is an intentional change, I think we should do the same here.

LHI version--Email to Court Cover Sheet with Petition.pdf


bugfix for varying ASN via DNS lookup, contrib update

Coverage remained the same at 100.0% when pulling 62a98b2ca4b018e880b72052f0caa993a14fb243 on dev into 7f8213076b2140a43807d57beefba98f7cdf0953 on master.

Coverage remained the same at 100.0% when pulling 62a98b2ca4b018e880b72052f0caa993a14fb243 on dev into 7f8213076b2140a43807d57beefba98f7cdf0953 on master.

Coverage remained the same at 100.0% when pulling 62a98b2ca4b018e880b72052f0caa993a14fb243 on dev into 7f8213076b2140a43807d57beefba98f7cdf0953 on master.


Markdown cells don't get rendered and an error 'No renderer found for "text/markdown" a' is shown

Environment data

VS Code version: 1.61.0-insider & stable 1.60
Jupyter Extension version (available under the Extensions sidebar): v2021.9.1001208778 (insider) & v2021.8.2041215044 (stable)
Python Extension version (available under the Extensions sidebar): v2021.10.1210725981-dev (insider) & v2021.10.1200408502-dev (stable)
OS (Windows | Mac | Linux distro) and version: Ubuntu 18.04
Python and/or Anaconda version: Python 3.8.3, Anaconda 2020.07
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A & virtualenv
Jupyter server running: Local & Remote

Expected behaviour
Markdown rendered properly.
Actual behaviour
Markdown cells don't get rendered and an error 'No renderer found for "text/markdown" a' is shown.

Steps to reproduce:
No matter whether I "Add markdown cell" or turn a code cell into markdown, the result is the same. I've been using notebooks on VS Code since March on two different computers with totally different setups (one Windows and the other one Linux) and I can't remember ever seeing the markdown cells rendered properly during this time on either one. I've only got this error since the beginning.
Logs

Please note: Markdown rendering is supported in VS Code core (not an extension).

Have you disabled VS Code's built-in markdown extension? Search @builtin markdown in the extension view to check this

That did it, Markdown Language Features was disabled. I did search the command palette and settings with "markdown", but couldn't find anything relevant. Good to know this "@builtin" key word. Thanks.


Change Streaming to a more idiomatic response

Since responses will be automatically disposed with this signature, this allows a more direct experience to a Response which can be worked with, rather than modified inside this function only.

Half-baked thought: what if Client were a wrapper around Request[F] => Stream[F, Response[F]] and get rid of DisposableResponse[F] entirely?

I love it! Guarantees termination everywhere. All that changes are how we use the stream semantics. Which makes it extremely easy to explain to newcomers what each function makes available.

This has been superseded by #2102, but I like the streaming signature.


Add Montreal event

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Hey @mattj-io, please sign your commit with a DCO Signed-off-by: Your Name <your email> and thereby agree to the https://developercertificate.org/

Done


Roll engine cc115500b9cb..309d078b597d (1 commits)

https://github.com/flutter/engine/compare/cc115500b9cb...309d078b597d
git log cc115500b9cb2b27d59627f202e6cd6bb87f49fc..309d078b597d3a38fe9bcef8d8bae7b56487e8eb --no-merges --oneline
309d078b5 Roll src/third_party/skia e25b4472cdd9..176da0bb8a10 (10 commits) (flutter/engine#8422)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Deploying a UWP project needs to be done from a NTFS formatted drive

Description
Going through the tutorial to create a UWP app. I'm an experienced developer, but mostly for UI-less services so coding isn't an issue. Just trying to learn something new. Anyways, no problem following the basic steps to create the app and get used to XAML. However, while the code would build just fine, I could not get it to run locally. After checking to make sure my machine was indeed set to developer-mode and still getting error when trying to deploy:
Expected result
Application builds and runs
Actual result
"Error DEP0700 : Registration of the app failed (0x80073CFD)"
Root cause
Turns out, this situation was caused not by VS configuration, but by location of the source project. The project needs to be on a NTFS formatted drive in order to deploy - a footnote that I cannot find anywhere in the requirements for writing a UWP app. Once I moved the project folder to my OS drive, the application was able build and run successfully.
Change requested
I think it would be great if this issue would have a KB article, and linked to this page in a troubleshooting section. That, or just highlight the NTFS requirement somewhere on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b088cce-5638-75f8-e42f-a235287cb22c
Version Independent ID: a36f877f-0fe4-ac36-883f-27a8ec098611
Content: Create a Universal Windows Platform (UWP) App with Visual Studio and C#
Content Source: docs/get-started/csharp/tutorial-uwp.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@Reynolds-Beta Thanks for letting us know; we'll take this under consideration and report back.

Thanks!
Jeff Reynolds
206.979.4047

From: Terry G. Lee<EMAIL_ADDRESS>Sent: Tuesday, June 4, 2019 9:43:42 AM
To: MicrosoftDocs/visualstudio-docs
Cc: Jeff; Mention
Subject: Re: [MicrosoftDocs/visualstudio-docs] Deploying a UWP project needs to be done from a NTFS formatted drive (#3359)
@Reynolds-Betahttps://github.com/Reynolds-Beta Thanks for letting us know; we'll take this under consideration and report back.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/visualstudio-docs/issues/3359?email_source=notifications&email_token=AKTB7K23MUK5FSIGCWZSCX3PY2LT5A5CNFSM4HSCZ3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5FNVI#issuecomment-498751189, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKTB7K45JJHLGOOLNXCOQ33PY2LT5ANCNFSM4HSCZ3RQ.

Hi @Reynolds-Beta, I added a note on the page that highlights the importance of this requirement. You should see it under step #3, when you are creating the new project. Closing out this issue.


Mechanical Designer Club Short Introductory Session

Session Name
MechD Short Online Introduction
Abstract
How do we design practical parts/ components? How do we know if the parts will look good?
CAD software allow us to create and visualise our designs in a virtual environment, before 3D printing or fabricating the models.
Interested to learn more? MechD club provides beginner to intermediate workshops for SolidWorks and Fusion360, as well as CAD related events and certifications.
Student Organisation organising this session
Mechanical Designer Club
Event Format
Virtual on MS Teams (link will be sent to registered participants).
Session intent (what to expect)

Introduction to MechD
Brief explanation of CAD and how the software enables good design practices
Past MechD events
Upcoming MechD events
EXCO roles and responsibilities for those interested in taking on leadership opportunities
Q&A

Session details
Date: 16 September 2021
Time: 9.00pm to 10.00pm
Up to 50 participants online, can be adjusted for larger capacity.
Speakers/Workshop facilitators
Brendan Ong, President
Akshaya Maddula, Vice President
Artiaga Samantha, Treasurer
Joshua Lim, Secretary
Chew Yoong Hao, SolidWorks Programme Director
Keane Hi, Fusion360 Programme Director
Claudia Lai, Publicity Director
Sign up link(if any)
https://forms.office.com/Pages/ResponsePage.aspx?id=drd2NJDpck-5UGJImDFiPRLkhYYN7CJBlLXVXUDbKexURUhSUkFRQ1RVUlgyQ1o1VklEQzdPRkVUQy4u
Logistical details / Budget Needed
No budget required.
<EMAIL_ADDRESS>

Dear @robobdo  Your event has been approved by the school admin.
Wishing you a smooth and successful event!


Sld parser potential issue with OpenLayers parser

Question
Hey. I think I found an issue when working with Sld and OpenLayers parsers. Sld parses fill-opacity to fillOpacity field:
case 'fill-opacity':
          fillSymbolizer.fillOpacity = parseFloat(value);
          break;

However later on opacity field is also set:
if (!fillSymbolizer.color) {
      fillSymbolizer.opacity = 0;
    }

I also found out that in OpenLayers parser, when creating Polygon symbolizer from Fill symbolizer, opacity field is used, which won't work because the opacity will be null because the color is set, therefor the color will always be solid:
 getOlPolygonSymbolizerFromFillSymbolizer(symbolizer: FillSymbolizer): OlStyleFill {
    let fill = symbolizer.color ? new this.OlStyleFillConstructor({
      color: (symbolizer.opacity !== null && symbolizer.opacity !== undefined) ?
        OlStyleUtil.getRgbaColor(symbolizer.color, symbolizer.opacity) : symbolizer.color
    }) : null;

Am I correct in thinking that this is not right? If this is an issue, is it an issue of Sld or OpenLayers parser?

Hey @Eullar,
thanks for the report.

Actually you could arguee, that an opacity without a fillcolor does not make sence, but I think you're right and we should not modify this. Maybe you could open a PR with a (failing) test that contains the input and expected output?

I think you're also right about the OLParser. Would be nice if you could open an issue here. And same as for the bug here. An PR with a failing test for the input and expected output would be very helpful.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

I think I figured out the problem you're having. I noticed that when I ran this, the SDK harness was outputting "PASS". This means it's running tests in the SDK harness instead of acting as an SDK harness, which led me to find the culprit:
You need the following code in your test file:
func TestMain(m *testing.M) {
	ptest.Main(m)
}

To give a short version of why, the SDK harness is actually executing the exact binary that the code is originally executed from. Normally in our files we have a call in beam.Init to check if it's the SDK harness or user code, and if the binary is run as the SDK harness it behaves differently.
To get the same thing working for our tests, we need to replace TestMain with ptest.Main, otherwise it will try to execute all the tests before we can run beam.Init. ptest.Main handles that for us by calling beam.Init before deferring to the normal TestMain behavior. This means any kind of integration test we write for the Go SDK needs to call that snippet, or something equivalent, because we absolutely need beam.Init to get called before going to the normal test framework logic, otherwise SDK harnesses built for those integration tests will attempt to run tests instead of actually act as an SDK harness.

Retest this please

Re-pinging the tests since everything in the repo has changed since this was last tested.

R: @lostluck @youngoli
CC: @jrmccluskey

FYI Go Portable failed with the new test. Looking at the code now for any insights I can provide.
--- FAIL: TestJDBCIO_BasicReadWrite (8.57s)
panic: 	tried cross-language for beam:transform:org.apache.beam:schemaio_jdbc_write:v1 against localhost:9000 and failed
	expanding external transform
	expanding transform with ExpansionRequest: components:{pcollections:{key:"n2" value:{unique_name:"n2" coder_id:"c0@nhyUeOslCm" is_bounded:BOUNDED windowing_strategy_id:"w0@nhyUeOslCm"}} windowing_strategies:{key:"w0@nhyUeOslCm" value:{window_fn:{urn:"beam:window_fn:global_windows:v1"} merge_status:NON_MERGING window_coder_id:"c1@nhyUeOslCm" trigger:{default:{}} accumulation_mode:DISCARDING output_time:END_OF_WINDOW closing_behavior:EMIT_IF_NONEMPTY OnTimeBehavior:FIRE_IF_NONEMPTY environment_id:"go"}} coders:{key:"c0@nhyUeOslCm" value:{spec:{urn:"beam:coder:row:v1" payload:"\n\r\n\x07role_id\x1a\x02\x10\x03\x12$abc5e222-ab8f-4f6f-800a-a58bb0f45675"}}} coders:{key:"c1@nhyUeOslCm" value:{spec:{urn:"beam:coder:global_window:v1"}}} environments:{key:"go" value:{}}} transform:{unique_name:"External" spec:{urn:"beam:transform:org.apache.beam:schemaio_jdbc_write:v1" payload:"\nX\n\x0e\n\x08location\x1a\x02\x10\x07\n\x0c\n\x06config\x1a\x02\x10\t\n\x12\n\ndataSchema\x1a\x04\x08\x01\x10\t\x12$853bc92e-cc52-429e-bf30-f534bebcedce\x12`\x03\x01\x04\x05rolesV\n\x02\xf0\x03\x15org.postgresql.Driver*jdbc:postgresql://localhost:56085/postjdbc\x07newuser\x08password"} inputs:{key:"i0" value:"n2"} environment_id:"go"} namespace:"nhyUeOslCm"
expansion failed
	caused by:
rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:9000: connect: connection refused" [recovered]
	panic: 	tried cross-language for beam:transform:org.apache.beam:schemaio_jdbc_write:v1 against localhost:9000 and failed
	expanding external transform
	expanding transform with ExpansionRequest: components:{pcollections:{key:"n2" value:{unique_name:"n2" coder_id:"c0@nhyUeOslCm" is_bounded:BOUNDED windowing_strategy_id:"w0@nhyUeOslCm"}} windowing_strategies:{key:"w0@nhyUeOslCm" value:{window_fn:{urn:"beam:window_fn:global_windows:v1"} merge_status:NON_MERGING window_coder_id:"c1@nhyUeOslCm" trigger:{default:{}} accumulation_mode:DISCARDING output_time:END_OF_WINDOW closing_behavior:EMIT_IF_NONEMPTY OnTimeBehavior:FIRE_IF_NONEMPTY environment_id:"go"}} coders:{key:"c0@nhyUeOslCm" value:{spec:{urn:"beam:coder:row:v1" payload:"\n\r\n\x07role_id\x1a\x02\x10\x03\x12$abc5e222-ab8f-4f6f-800a-a58bb0f45675"}}} coders:{key:"c1@nhyUeOslCm" value:{spec:{urn:"beam:coder:global_window:v1"}}} environments:{key:"go" value:{}}} transform:{unique_name:"External" spec:{urn:"beam:transform:org.apache.beam:schemaio_jdbc_write:v1" payload:"\nX\n\x0e\n\x08location\x1a\x02\x10\x07\n\x0c\n\x06config\x1a\x02\x10\t\n\x12\n\ndataSchema\x1a\x04\x08\x01\x10\t\x12$853bc92e-cc52-429e-bf30-f534bebcedce\x12`\x03\x01\x04\x05rolesV\n\x02\xf0\x03\x15org.postgresql.Driver*jdbc:postgresql://localhost:56085/postjdbc\x07newuser\x08password"} inputs:{key:"i0" value:"n2"} environment_id:"go"} namespace:"nhyUeOslCm"
expansion failed
	caused by:
rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:9000: connect: connection refused"

goroutine 13 [running]:
testing.tRunner.func1.2(0xe57340, 0xc0000acb80)
	/home/jenkins/sdk/go1.16.12/src/testing/testing.go:1143 +0x332
testing.tRunner.func1(0xc000102c00)
	/home/jenkins/sdk/go1.16.12/src/testing/testing.go:1146 +0x4b6
panic(0xe57340, 0xc0000acb80)
	/home/jenkins/sdk/go1.16.12/src/runtime/panic.go:965 +0x1b9
github.com/apache/beam/sdks/v2/go/pkg/beam.CrossLanguage(0xc000454ca0, 0xc0000b82d0, 0xfa2085, 0x35, 0xc000182240, 0xbc, 0xbc, 0x7ffee806128c, 0xe, 0xc0006b3b38, ...)
	/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/go/pkg/beam/xlang.go:162 +0x1f7
github.com/apache/beam/sdks/v2/go/pkg/beam/io/xlang/jdbcio.Write(0xc000454c80, 0xc0000b82d0, 0x7ffee806128c, 0xe, 0xf74220, 0x5, 0xf84670, 0x15, 0xc00055a840, 0x2a, ...)
	/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go:129 +0x4c7
github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/jdbc.writeRows(0xc000454be0, 0xc0000b82d0, 0x7ffee806128c, 0xe, 0xf74220, 0x5, 0xf84670, 0x15, 0xc00055a840, 0x2a, ...)
	/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/go/test/integration/io/xlang/jdbc/jdbc.go:39 +0x1be
github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/jdbc.WritePipeline(0x7ffee806128c, 0xe, 0xf74220, 0x5, 0xf84670, 0x15, 0xc00055a840, 0x2a, 0xf76805, 0x7, ...)
	/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/go/test/integration/io/xlang/jdbc/jdbc.go:49 +0x20d
github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/jdbc.TestJDBCIO_BasicReadWrite(0xc000102c00)
	/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/go/test/integration/io/xlang/jdbc/jdbc_test.go:105 +0x227
testing.tRunner(0xc000102c00, 0xfb8480)
	/home/jenkins/sdk/go1.16.12/src/testing/testing.go:1193 +0xef
created by testing.(*T).Run
	/home/jenkins/sdk/go1.16.12/src/testing/testing.go:1238 +0x2b3
FAIL	github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/jdbc	8.597s

Run Go Flink ValidatesRunner


Only start download, if there is a different version then installed

I added to the main tasks: when: oracle_java_version_installed != oracle_java_version_string
So the download/installation would only start if the installed version does not matches the intended version.
I also had some Warnings  in Ansible, so I fixed them all.
May I also suggest to add a task that find the lastest Update version of a JDK release? So this could then automatically fill in things like oracle_java_rpm_filename, oracle_java_rpm_url, oracle_java_version_string depending on which oracle_java_version is set.

I also added a new default value for RedHat oracle_java_latest, if changed to oracle_java_latest: true the find_latest.yml will be included in order to overwrite oracle_java_rpm_filename, oracle_java_rpm_url, oracle_java_update_string (only for jdk8, e.g. 192), oracle_java_version_string

@peshay this role used to have the logic to get the latest version only for this logic to get deprecated and stop working as it should.
I really appreciate the PR but I'm not keen in merging this logic to this role again.
if you want to do a new PR up to 99025d176c11cc72c72f442c36831d88dc2bfb2, I'll merge asap.

I separate the change in a new Pull Request. Regarding downloading latest version of jdk for RedHat RPM:
As far as I understood the role, currently it will get the latest for Debian systems, but only the one defined version in the defaults for RedHat. Wouldn't it be better to have the same behaviour for both distributions?
If the role should still work like it's working now, then my change wouldn't change that, because if someone wants the new behaviour to get the latest JDK update version, he could change oracle_java_latest to true


[MM-48979,MM-49181,MM-49208,MM-49218,MM-49220,MM-49225]: fixes on Acknowledgements

Summary

Makes post priority selection instant in the UI
Adds 'request for acknowledgements' tooltip in ACK icon
Doesn't show acknowledge button to sender
Shows ACK button in search results, mentions, saved and pinned posts
Adds give feedback button on post priority picker
Adds analytics about post priority
Doesn't show priority and ACK on deleted posts

Ticket Link
https://mattermost.atlassian.net/browse/MM-48978
https://mattermost.atlassian.net/browse/MM-49181
https://mattermost.atlassian.net/browse/MM-49208
https://mattermost.atlassian.net/browse/MM-49218
https://mattermost.atlassian.net/browse/MM-49220
https://mattermost.atlassian.net/browse/MM-49225
Release Note
NONE

@koox00 in the test server, I don't see acknowledgements as an option. Is there something we need to enable on the test server?

@koox00 in the test server, I don't see acknowledgements as an option. Is there something we need to enable on the test server?

@matthewbirtch I just wanted to showcase the feedback link on free tier. acknowledgements are behind professional license, let me upgrade the server, we can always downgrade

When ack is not enabled in the workspace(free plans), the popover now seems really wide. I wonder if we should consider moving the 'Give feedback' button in this case? This is not a big deal, but wanted to ask. Actually, I wonder if we just hide the 'Give feedback' for this case because the feedback form asks questions about acknowledgement and would be irrelevant to these users on free plans. cc @esethna

@matthewbirtch the feedback form should be different when on free plan, I agree though

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

/e2e-test MM_ENV="MM_FEATUREFLAGS_POSTPRIORITY=true"

Triggering E2E testing with options:
&map[MM_ENV:MM_FEATUREFLAGS_POSTPRIORITY=true]

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

Thanks @koox00
Tested, looks good to merge.
Verified:
Makes post priority selection instant in the UI ✅
Adds 'request for acknowledgements' tooltip in ACK icon ✅
Doesn't show acknowledge button to sender, shows check mark with 0 count, non-actionable ✅
Shows ACK button in search results, mentions, saved and pinned posts ✅
Adds give feedback button on post priority picker ✅
Adds analytics about post priority ✅
Doesn't show priority and ACK on deleted posts ✅
E2E report - no PR related failures

/update-master

/update-branch

Error trying to update the PR.
Please do it manually.

/update-branch

/update-branch

/update-branch

Cherry pick is scheduled.

/cherry-pick cloud

Cherry pick is scheduled.


checkpoint also QAT for resuming

What does this PR do?

Fixes #6457
Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
[ ] Did you list all the breaking changes introduced by this pull request?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@ananthsub what is your suggestion on the restoring order - callback vs Model?
@edenafek as there is not clear consensus, shall we move it to 1.5?

Hey @carmocca,
I moved the logic from the BaseFinetuning Callback on on_fit_start, so I think it should be fine.
Best,
T.C

@ananthsub what is your suggestion on the restoring order - callback vs Model?


Exclude files in .gitignore

I ended up scrapping the _files module pulled in from black because I ran into a number of issues:

There is a lot of code which is specific to black and not applicable to ssort.
.gitignore files outside of the root are ignored as you mentioned in #45
Only a single project root is allowed.
Symbolic links can't be resolved outside the project root.
And, generally, there was a lot of complexity which was unnecessary for just this single feature.

The new _files implementation I put together solves all the above issues.

This looks good.  It might be worth upstreaming the changes to black (and other tools) once we're happy with them here.


Update the sample script for windows agent.

@LGDoor,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Implement call activity props

Closes #55

Missing job configuration as section

Should we really move CMMN as a target to the new panel? We do not support CMMN anymore.

CMMN is still documented though: https://docs.camunda.org/manual/latest/reference/bpmn20/subprocesses/call-activity/#create-a-case-instance

Should we really move CMMN as a target to the new panel?

Double checked with PM. We keep it.


RichTextFX flickering

Seeing a weird issue when editting documents that are longer (around 60-70 lines) where all actions such as mouse clicks or typing cause the cursor and or sections of text to flicker and dissapear.

Finding this hard to reproduce.

Closing this until I can reproduce it.


Rakefile: Add and enable parallel_spec by default

This should speed up tests a lot.

All green, pls merge @bobapple


Some questions

Hi,
Thanks for sharing such good project.
I have some questions:

You say:
⚠ If you use intersecting linear constraints, you may get problems because the intersection point needs to be integral. There is no such thing as a feasibility tolerance as in Mixed Integer Programming-solvers.
it means cp-sat solver can't solve a general linear programming? Sorry I can't understand what the problems in intersecting linear constraints.
About Circuit/Tour-Constraints, I think this is specialize for sub-tour problem, but when I want to add AddCircuit(), would the number of arcs grow exponentially? I didn't use this method, so I'm confusing this part, is there any refference examples ?
I think the Array operations part is not clear explain, is there any more source to study?

Looking forward to your reply, thank you.
Zhe.

Hey Zhe,
I am happy it is already useful, before it is completed (I am only writing it on the side, aiming to finish it in around another year).

If you have the constraints $x=y$ and $x-1=-y$, the only feasible solution will be the intersection of the two implied lines at $x=0.5, y=0.5$. This is fine with linear programming, but not with CP-SAT. CP-SAT would tell you that there is no solution available. So, if one tries to simulate continuous variables (that are commonly necessary), you have to make sure not to have such constraints (that are common in some areas). However, CP-SAT should still have a similar performance if you don't have these problems as an LP-solver is part of its portfolio (though, it is probably not as good as Gurobi).
I don't fully understand. Sub-tours don't need special constraints as you can just enforce that every vertex has to be entered and left. Could you elaborate your question, please? (Haven't used this constraints, neither. Gurobi is usually better for tour constraints.)
You can check out the documentation https://google.github.io/or-tools/python/ortools/sat/python/cp_model.html I will look into the text next time I find the time and try to make it easier.

Best,
Dominik
PS: If you have any idea on how to write things better/easier, feel free to submit a pull request or just write your idea here in the comments.


transport-native-epoll 4.1.79-Final does not include OSGI processor directive fix

Expected behavior
https://mvnrepository.com/artifact/io.netty/netty-transport-native-epoll/4.1.79.Final contains an artifact
https://repo1.maven.org/maven2/io/netty/netty-transport-native-epoll/4.1.79.Final/netty-transport-native-epoll-4.1.79.Final-linux-aarch64.jar
As fixed in https://github.com/netty/netty/pull/12498
Actual behavior
https://mvnrepository.com/artifact/io.netty/netty-transport-native-epoll/4.1.79.Final contains an artifact
https://repo1.maven.org/maven2/io/netty/netty-transport-native-epoll/4.1.79.Final/netty-transport-native-epoll-4.1.79.Final-linux-aarch_64.jar (Note the _ included between aarch and 64)
Steps to reproduce
Examine artifacts at https://mvnrepository.com/artifact/io.netty/netty-transport-native-epoll/4.1.79.Final
Minimal yet complete reproducer code (or URL to code)
N/A
Netty version
4.1.79-Final
JVM version (e.g. java -version)
N/A
OS version (e.g. uname -a)
N/A

The processor directive is correct in the MANIFEST.MF. Isn't that what matters?

I guess I don't fully understand what is happening under the hood, but shouldn't something like the following be added like was added in netty-tcnative? https://github.com/netty/netty-tcnative/pull/733/commits/97e1e0e66f5b2ae640dbc8c622bc1fd02a8a94ac
                <!-- In OSGi specification, the alias of x86_32 is x86... -->
                <condition property="nativeCode.processor" value="x86">
                  <equals arg1="${os.detected.arch}" arg2="x86_32" />
                </condition>
                <!-- ... and aarch_64 is aarch64 -->
                <condition property="nativeCode.processor" value="aarch64" else="${os.detected.arch}">
                  <equals arg1="${os.detected.arch}" arg2="aarch_64" />
                </condition>

Again, I don't really know how this works, but the resolver (Coursier) on my system is trying to resolve https://repo.maven.apache.org/maven2/io/netty/netty-transport-native-epoll/4.1.79.Final/netty-transport-native-epoll-4.1.79.Final-linux-aarch64.jar and it cannot be found. However, if I add an _ between aarch and 64 I can manually find the jar... this might not be a problem with this project I figured I would double check since I'd been following the tc-native fix. tc-native 2.0.54-Final actually also has an artifact with an _ published so maybe that is not the problem...

Maybe raise the issue with the OSGi project, because we don't really have the expertise in Netty to tell what part is wrong.

As far as OSGi is concerned, this line is correct and that's all that's required for dependency resolution at runtime in an OSGi container, regardless of the name of the containing jar file.
I don't know Coursier and how it resolves what it has to resolve, but it seems that here is where you state what the jar file name will be, whilst here is where you define the values for the aarch64 maven properties.
So my suggestion is: study which info Coursier relies on in order to look up files while "resolving".


apply the extra settings from gofumpt

This PR enables the extra settings of gofumpt, allowing developers to worry even less about formatting, because the linter will do it for them!
important
Please do not merge this before reviewing and merging:

#1906
#1907
#1925

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

@adizere if I understood your comments correctly, I'm going to go ahead and close this too.
But please know that gofumpt is indeed enabled on master.


Error with Draft.js

Hi,
I'm having an error that makes Draft.js not working correctly with Next.js.
Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
 (client) "true" data-editor="7qif3" data-offset-k
 (server) "true" data-editor="rgtv" data-offset-ke

The code is
import React from 'react'
import {Editor, CompositeDecorator, EditorState} from 'draft-js';
import ReactCSSTransitionGroup from 'react-addons-css-transition-group' // ES6

export default class extends React.Component {

  // static async getInitialProps () {
  //   const res = await axios.get('http://api.football-data.org/v1/competitions/426/leagueTable');
  //   return {data: res.data}
  // }

  constructor(props) {
    super(props)

    const compositeDecorator = new CompositeDecorator([
      {
        strategy: handleStrategy,
        component: HandleSpan,
      }
      ]);

    this.state = {editorState: EditorState.createEmpty(compositeDecorator)};

    this.onChange = (editorState) => this.setState({editorState});

  }

  render () {
    return (

		<Editor editorState={this.state.editorState} onChange={this.onChange} />

    );
  }
}

      const HANDLE_REGEX = /[\w]+\?\?/g;
      const HASHTAG_REGEX = /\#[\w\u0590-\u05ff]+/g;

      function handleStrategy(contentBlock, callback, contentState) {
        findWithRegex(HANDLE_REGEX, contentBlock, callback);
      }

      function findWithRegex(regex, contentBlock, callback) {
        const text = contentBlock.getText();
        let matchArr, start;
        while ((matchArr = regex.exec(text)) !== null) {
          start = matchArr.index;
          callback(start, start + matchArr[0].length);
        }
      }

        const HandleSpan = (props) => {
        return (

        <ReactCSSTransitionGroup
          transitionName="example"
          transitionEnterTimeout={500}
          data-offset-key={props.offsetKey}
            style={styles.hashtag}
                transitionAppear={true}
      transitionAppearTimeout={500}

          transitionLeaveTimeout={300}>

            {props.children}
        </ReactCSSTransitionGroup>

        );
      };

      const styles = {
        root: {
          fontFamily: '\'Helvetica\', sans-serif',
          padding: 20,
          width: 600,
        },
        editor: {
          border: '1px solid #ddd',
          cursor: 'text',
          fontSize: 16,
          minHeight: 40,
          padding: 10,
        },
        button: {
          marginTop: 10,
          textAlign: 'center',
        },
        handle: {
          color: 'rgba(98, 177, 254, 1.0)',
          direction: 'ltr',
          unicodeBidi: 'bidi-override',
        },
        hashtag: {
          color: 'rgba(95, 184, 138, 1.0)',
          transform:'translate(30px, 2px)',
          transition:'1s all'
        },
      };

Thanks

Try adding an editorKey="editor" prop. I use draft in a project with next and don't receive any errors.

The solution @knipferrc presents will work on the next draft-js release since the editorKey pr got merged in march while the last version is from january https://github.com/facebook/draft-js/pull/796
An easy solution until that happens is to add a editor boolean variable to your state starting as false and turning it to true on componentDidMount. Then on render you only render the <Editor> if this.state.editor is true

Thanks all for helping.
@ellyish please re-open if you still didn't find a workaround.

This is my component:
import React, { Component } from 'react'
import { Editor, EditorState } from "draft-js";

export default class CHEditor extends Component {
  state = { editorState: EditorState.createEmpty() }

  onChange = editorState => this.setState(editorState)

  render() {
    return (
      <Editor
        editorKey="editor"
        onChange={editorState => this.onChange(editorState)}
        editorState={this.state.editorState}
        placeholder="Simple editor"
      />
    )
  }
}

and I'm still getting same error:
Warning: Prop data-offset-key did not match. Server: "c2j7b-0-0" Client: "60n2f-0-0"

@arefaslani, try with this example:
https://github.com/facebook/draft-js/tree/master/examples/draft-0-10-0/universal
Basically create the Editor with createWithContent(emptyContentState).
I tried this quickly and didn't get the error.
impronunciable's solution (scroll up) also works to only render the Editor component after componentDidMount.

@rolfnl in your example you explicitely pass a key to your empty block. This doesn't solve the problem of rendering arbitrary content serverside (and I think it doesn't matter if you provide an editorKey prop when you hardcode the block's key)
However this seems not to be a solution to render content on the server without getting a mismatch (and an error because the client tries to load the wrong keypath from the tree via getUpdatedSelectionState())
Or am I missing something?


Revert change of moving kpi_target from facades, and ser default MP config in CoreConfig

Pull Request Description:
MP run is decided based on initialized target_kpi.
CoreConfig holds a default MP config anyway to allow MP execution if desired.
Checklist before requesting a review:

[x] I set the appropriate labels on the pull request.
[x] I have added/updated the release note draft (if necessary).
[x] I have updated the documentation to reflect my changes (if necessary).
[x] All function and files are well documented.
[x] All function and classes have type hints.
[x] There is a licenses in all file.
[x] The function and variable names are informative.
[x] I have checked for code duplications.
[x] I have added new unittest (if necessary).

Don't forget to update tutorials and accuracy runner, please.


Redirect Password Reset to Reportstream website, not the app

Problem statement
The ReportStream website now allows self-service password reset. However, as an external user, when I reset my password it redirects me back to the Okta app interface instead of the ReportStream website. This is poor user experience and could be confusing to some users.
What you need to know

After finishing the password reset flow, I am redirected back to reportstream.okta.com, but I should be redirected back to reportstream.cdc.gov.
...

Acceptance criteria

[ ] Self-service password reset flow for all user types redirects back to ReportStream.cdc.gov at the end of the process instead of ReportStream.Okta.com

This may not be needed anymore. Checking with Joseph if my work is correct.

It required a URI redirection in the email template.
Private Zenhub Image
I went ahead and changed it. Joseph checked. Closing.


Fix #568

Coverage decreased (-0.07%) to 92.217% when pulling ecda68ca687931c1b82171f7f1a98f707fc09cfc on fix into ad8c6070b98ee2362e9d6b7c5bf387bae6c72f2a on master.


[Feature] catalog 以后可以支持tdengine吗？

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
No response
Use case
No response
Related issues
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

use jdbc catalog

use jdbc catalog

执行create catalog
如果写 jdbc:TAOS-RS://ip.. 会报不支持的jdbc类型；
如果写 jbbc: ${其他}://..  比如mysql/clickhouse ，虽然catalog可以创建成功，但是swtich catalog&show databases就无法执行了。
我的url与class是:
"driver_url" = "taos-jdbcdriver-2.0.39-dist.jar",
"driver_class" = "com.taosdata.jdbc.rs.RestfulDriver"
或者
"driver_url" = "mysql-connector-java-8.0.25.jar",
"driver_class" = "com.mysql.cj.jdbc.Driver"
依赖包同时放到了lib与jdbc_drivers文件夹下
所以我是哪个步骤有问题?
谢谢。

There are some problems, but it's just a simple adaptation.

but it's just a simple adaptation.
Will it be perfect in the future?
thanks

There are some problems, but it's just a simple adaptation.

Will it be perfect in the future?
thanks

Will not support in near future.
We are trying to make catalog pluggable, after that, it will be more easy to connect to other catalog

ok ，thank you very much！

Will not support in near future. We are trying to make catalog pluggable, after that, it will be more easy to connect to other catalog

ok, thank you very much !


The here macro to materialize a source file position slows down compilation

I'm working on instrumentation for the compiler to attribute compilation time to compilation of particular file/line/method/implicits/macros.
I've used this tool to analyse the compilation of https://github.com/guardian/frontend, which is a relatively large application that uses Play and ScalaTest.
One thing that stood out is that 1.5% of compilation time is attributed to the expansion of the here macro in ScalaTest, which is implemented by genPosition.
https://github.com/scalatest/scalatest/blob/a7673db180bf14e757d476fb06df4aa17948e1a8/scalactic-macro/src/main/scala/org/scalactic/source/PositionMacro.scala#L35-L63
It might be possible to reduce the cost of this macro, by reducing the number of calls to newTermName and avoiding generating a big nested select that must be typechecked to find the Position class.
Here's a more direct way to generate a call to scala.Symbol.apply, for instance.
scala> def impl(c: Context): c.Tree = { import c.universe._; Apply(typeOf[Symbol.type].decl(TermName("apply")), Literal(Constant("blah")))}; def m: Any = macro impl
<console>:28: warning: method Apply in trait Trees is deprecated (since 2.10.1): use q"$sym(..$args)" instead
       def impl(c: Context): c.Tree = { import c.universe._; Apply(typeOf[Symbol.type].decl(TermName("apply")), Literal(Constant("blah")))}; def m: Any = macro impl
                                                             ^
impl: (c: scala.reflect.macros.blackbox.Context)c.Tree
defined term macro m: Any

scala> m
res1: Any = 'blah

@retronym Thanks for the idea (and the pretty diagram). I've assigned this to Chee Seng.

I'm looking more closely for the bottleneck. So far, I noticed this stack trace:
"ForkJoinPool-11-worker-1" #25 daemon prio=5 os_prio=31 tid=0x00007fc9783fb000 nid=0xa617 runnable [0x000070000597a000]
   java.lang.Thread.State: RUNNABLE
	at java.lang.Throwable.fillInStackTrace(Native Method)
	at java.lang.Throwable.fillInStackTrace(Throwable.java:783)
	- locked <0x000000078b8b89d8> (a java.lang.ClassNotFoundException)
	at java.lang.Throwable.<init>(Throwable.java:287)
	at java.lang.Exception.<init>(Exception.java:84)
	at java.lang.ReflectiveOperationException.<init>(ReflectiveOperationException.java:75)
	at java.lang.ClassNotFoundException.<init>(ClassNotFoundException.java:82)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	- locked <0x00000006c385e8a0> (a java.lang.Object)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
	- locked <0x00000006c3858e18> (a java.lang.Object)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
	- locked <0x000000078b269ce0> (a scala.reflect.internal.util.ScalaClassLoader$URLClassLoader)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.util.ResourceBundle$Control.newBundle(ResourceBundle.java:2649)
	at java.util.ResourceBundle.loadBundle(ResourceBundle.java:1510)
	at java.util.ResourceBundle.findBundle(ResourceBundle.java:1474)
	at java.util.ResourceBundle.findBundle(ResourceBundle.java:1428)
	at java.util.ResourceBundle.findBundle(ResourceBundle.java:1428)
	at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1370)
	at java.util.ResourceBundle.getBundle(ResourceBundle.java:782)
	at org.scalactic.Resources$.resourceBundle$lzycompute(Resources.scala:8)
	- locked <0x000000078b8b81f0> (a org.scalactic.Resources$)
	at org.scalactic.Resources$.resourceBundle(Resources.scala:8)
	at org.scalactic.Resources$.pleaseDefineScalacticFillFilePathnameEnvVar(Resources.scala:256)
	at org.scalactic.source.PositionMacro$.genPosition(PositionMacro.scala:58)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at scala.reflect.macros.runtime.JavaReflectionRuntimes$JavaReflectionResolvers.$anonfun$resolveJavaReflectionRuntime$4(JavaReflectionRuntimes.scala:34)
	at scala.reflect.macros.runtime.JavaReflectionRuntimes$JavaReflectionResolvers$$Lambda$1522/318026163.apply(Unknown Source)
	at scala.tools.nsc.typechecker.Macros.macroExpandWithRuntime(Macros.scala:811)
	at scala.tools.nsc.typechecker.Macros.macroExpandWithRuntime$(Macros.scala:787)

I've come back to looking at this.
I've found some inefficiencies in compiler that can reduce the overhead of macro calls a little: https://github.com/retronym/scala/tree/topic/macro-opt
After that, I'm measuring the benefit of having this macro use lower-level APIs to generate the tree.
I'm measuring all this with https://github.com/scala/compiler-benchmark/pull/92 and
  269  for V in eb6ce1a; do sbt 'set scalaVersion in compilation := "2.12.9-bin-'$V'-SNAPSHOT"' 'prof hot<EMAIL_ADDRESS>-f1 -wi 4 -i 5 -pextraArgs=-Ystop-after:typer|-Ycache-macro-class-loader:always'; done
  270  for V in eb6ce1a; do sbt 'set scalaVersion in compilation := "2.12.9-bin-'$V'-SNAPSHOT"' 'hot<EMAIL_ADDRESS>-f1 -wi 4 -i 5 -pextraArgs=-Ystop-after:typer|-Ycache-macro-class-loader:always'; done

Scala Version
Macro Version
Performance (ms)
Relative performance

Baseline
Baseline
401ms
1x

https://github.com/retronym/scala/pull/47
Baseline
262ms
1.91x

https://github.com/retronym/scala/pull/47
Custom
137ms
2.92x

@retronym The improvements seems very significant!  I wonder if the low level classes are available in 2.10?  If not we may need to generate the Position source based on Scala version where old scala version that doesn't support it will use the old way but newer scala version shall use the new one, the change will still binary compatible with 2.12.8, right?

@cheeseng The API moved around between 2.10 and 2.11.
This implementation uses a small source compatibility hack to compile against 2.10-2.12.
https://github.com/retronym/scalactic-sandbox/blob/master/src/main/scala/org/scalactic/source/PositionMacro.scala
Alternatively, your suggestion to make Scala version dependent source files would work.

I have proposed the compiler changes for 2.12.9: https://github.com/scalatest/scalatest/issues/1418#issuecomment-495543079

@cheeseng Another change that I forgot to recommend is to make the implementation of the here macro in _2.12 and _2.13 versions of Scalatest accept a scala.reflect.macros.blackbox.Context. This tells the compiler that the macro does not require the expanded expression to have a type more specific than the return type of the macro def itself, and it also tells implicit search that the macro need not be expanded during the implicit search itself, it only need by expanded after an implicit is decided upon.

@retronym Noted with thanks, I am eager to try to get this into 3.1.x, asap.

@cheeseng This is all in 3.1, I'll close this ticket now. Thanks!

(You might want to update the Milestone and other labels)


Initial content

Pull requests:

https://github.com/Senzing/governor-postgresql-transaction-id/pull/2


[⭐FR] Allow backup/restore of ONLY video side

Describe your suggested feature
I sometimes want to only back up my anime related side of the app, but currently I am only able to backup both anime and manga related stuff for each option presented. This makes things inconvenient when I want to have a fresh start on the app without the manga list.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

I think a better title would be: "Separate Anime and Manga Libraries when Creating Backup"
I hope this gets implemented in the future.

In the issue #1575 one of the devs added this feature to the 'fix it' milestone, which is a good sign


docs(agent): add new hub options RBK-201

https://s.armory.io/YEuORpPX
RBK-201

Adds new connection options for hub
Adds callout at the top of the table for saying don't use clouddriver in .6+
Removes the badges for v .3 and .4

Since we aren't merging this until 0.6.0 is out, I will also make the following changes in this PR:

Remove the note about the helm install not installing a stable image
Moving the helm install to the primary tab so that it's displayed first. (Currently the manual kubectl install is displayed first since it installs a stable release)

Alternatively, we can remove the manual install completely if we want.
FYI @danielGz


Modus Data Table - Pagination - Add more configurations

Config 1: The user should be able to choose either text buttons or arrows for previous and next page selection options
Config 2: The user should be able to choose any page number which is not visible on the component, by clicking the ellipsis icon
example:

The use case for the text button:

We have a PR for the page dropdown configuration but the code needs a rework, we will prioritize when other development features are completed from the backlog


Can it be closed when an item selected?

When i use the single mode, I wan't it to be closed when item selected? Is there something I missed?

It is closed when you click an item.

Sorry, my problem is:
               clickedItem = angular.copy( item );
               console.log(1, clickedItem);
                if ( clickedItem !== null ) {
                    console.log(2, clickedItem);
                    $timeout( function() {
                        console.log(3, clickedItem);
                        delete clickedItem[ $scope.indexProperty ];
                        delete clickedItem[ $scope.spacingProperty ];
                        $scope.onItemClick( { data: clickedItem } );
                        clickedItem = null;
                    }, 0 );
                }

1 Object
vendor.js:747 2 Object
vendor.js:745 1 Object
vendor.js:747 2 Object
vendor.js:749 3 Object
vendor.js:749 3 null
vendor.js:102 TypeError: Cannot convert undefined or null to object
    at vendor.js:750
    at vendor.js:138
    at e (vendor.js:40)
    at vendor.js:44

weird

Sorry..
But my problem is:
When I clicke an item, something will process twice! and it cause an error
clickedItem = angular.copy( item );
if ( clickedItem !== null ) {
$timeout( function() {
delete clickedItem[ $scope.indexProperty ];
delete clickedItem[ $scope.spacingProperty ];
$scope.onItemClick( { data: clickedItem } );
clickedItem = null;
}, 0 );
}

Can you try to replicate the problem on Plunker or JsFiddler?

Sorry, there is no problem on JsFiddler, there must be someting wrong in my code, but i can't figure it out...
Thank you...resolved

@hxlniada what was a problem? I've faced it too.

@terales I didn't resolve it.. I write a multi-select by myself, based on angular bootstrap...

Hi @hxlniada , @terales ,
I don't know what's wrong, but it would be helpful if you can replicate the problem on JsFiddler or Plunker.

Sorry, I can't run angular 1.3 in jsFiddle: http://jsfiddle.net/0k8udanr/2/

I guess you can try using angular 1.2.
Load the framework from the first dropdown on the top left.

NO luck with 1.2 as with 1.3 :(
http://jsfiddle.net/0k8udanr/4/

Hi @terales ,
I did not see anything in your example.. This is what I saw:

Yep, as I wrote 3 days ago I can't run angular in jsFiddle. You suggested to try angular 1.2, but there was no luck too.

Hi @terales ,
No wonder I saw nothing. Please read JsFiddler documentation on how to load JS frameworks / libraries.
http://doc.jsfiddle.net/basic/introduction.html

I've set up a demo on Plunker: http://plnkr.co/edit/eQIYAPFEmx36veG9TsGx
I'll try to reproduce bug on this weekend.

Having the same error as @hxlniada but what I have noticed is that i get the error 'Cannot convert undefined or null to object' (line isteven-multi-select.js:442) when running on local machine but when deployed live the error disappears.


Error when using the family filter with vase-0.4.1

Dear David,
First - thank you for your program vase - it's great !
With the current version (0.4.1) the files attached raise an error, when executing the following command:
vase -i test.vcf --de_novo -o test --ped test.ped
The error message is:
  File "/home/aschmidt/.local/bin/vase", line 1385, in <module>
   vase_runner.run()
  File "/home/aschmidt/.local/lib/python3.7/site-packages/vase/vase_runner.py", line 298, in run
   self.process_record(vase_record)
  File "/home/aschmidt/.local/lib/python3.7/site-packages/vase/vase_runner.py", line 361, in process_record
    record, dom_filter_alleles, filter_csq)
  File "/home/aschmidt/.local/lib/python3.7/site-packages/vase/family_filter.py", line 1189, in process_record
    sv.annotate_record(self.report_file, self.annot_fields)
  File "/home/aschmidt/.local/lib/python3.7/site-packages/vase/family_filter.py", line 1340, in annotate_record
    self.segregant.record.info[k] = v
  File "pysam/libcbcf.pyx", line 2586, in pysam.libcbcf.VariantRecordInfo.__setitem__
  File "pysam/libcbcf.pyx", line 689, in pysam.libcbcf.bcf_info_set_value
  File "pysam/libcbcf.pyx", line 585, in pysam.libcbcf.bcf_check_values
TypeError: values expected to be 4-tuple, given len=7
When using vase-0.2.4 no error occured.
I attached an extra .txt extension to both files, otherwise I was not able to upload them. Can you reproduce this error?
test.ped.txt
test.vcf.txt
Best regards
Axel

Hi Axel,
Thank you for raising this issue and I'm glad you like vase.
I think I can see what's causing this problem. The issue seems to be specific to multiallelic variants either when there are no VEP annotations in the VCF input or if the VEP consequence is an 'intergenic_variant'. A quick workaround would be to restrict to biallelic variants (e.g. vase --max_alt 1 ...) but I will try and get a fix out ASAP.
Best
Dave

Hi Axel,
This issue should be fixed in the main branch now.
There is a small issue with your input file. Because it does not have any INFO headers this causes an issue with pysam not knowing how to handle the INFO fields when trying to output the record, so I have attached a version with dummy INFO fields that should allow you to confirm the fix at your end once you've updated vase.
Dave
test_with_info_headers.vcf.gz

Hi Dave,
I just updated vase and tried it - it works well without any issues now.
Thank you,
Axel


Warning when import uses ../ too many times

Hey,
I use aliases provided by webpack:
https://webpack.js.org/configuration/resolve/#resolvealias
there is such a structure:
folder1/folder2/../folder6/a.js
folder1/utils/ajax.js

In a.js there is such a code:
import { notifyDevelopers } from '../../../../../utils/ajax'

using alias this code can be simplified to:
import { notifyDevelopers } from 'utils/ajax'

Can I create a rule that forbids making a path that is larger than ../../ ?
I found similar issues:
https://github.com/benmosher/eslint-plugin-import/issues/776
https://github.com/benmosher/eslint-plugin-import/issues/471
But https://github.com/benmosher/eslint-plugin-import/issues/471 doesn't solve my problem

This already exists; see https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-useless-path-segments.md.
This won't (and shouldn't) take aliases into account, however, you'll have to build a custom rule for that.

Thx, found a way to create a rule:
{
  "rules": {
    "no-restricted-imports": [
      "error",
      {
        "patterns": ["../../../*"]
      }
    ]
  }
}

That will only catch 3+ levels, but that does work.


merge package template from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   84.61%   84.61%
=======================================
  Files           1        1
  Lines          13       13
=======================================
  Hits           11       11
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1440c89...da2c9ad. Read the comment docs.


Failing pipelines

Describe the bug
Pipelines are not passing
To Reproduce
Go to https://travis-ci.org/mercadopago/dx-php and see it for yourself
Expected behavior
Pipelines passing
Screenshots

Last successfull build: 2 years ago
Server (please complete the following information):
TravisCI servers
Additional context
Need to fix as it's the official SDK

@ahoulgrave we are working to update our test suites.

Thanks @joelibaceta
Currently you have dev dependencies (https://github.com/mercadopago/dx-php/blob/90846e51fff6f59214555b5c77f8f54876e76a50/composer.json#L24) that requires php 7.1 https://packagist.org/packages/phpunit/phpunit#7.2.7
so the pipelines will never pass unless you require this same version

@ahoulgrave we changed this to "phpunit/phpunit": "^5",

Still a lot of errors, i will make a PR when i have time

.travis.yml is targeting PHP 5.3 and 5.5, those should be removed and 7.1, 7.2 and 7.3 added.
I'd make a PR with this tiny changes but I guess @ahoulgrave is going to include it already in his PR. Otherwise, I'd happy to make it.

According to the readme:
The SDK supports PHP 5.6 or major

Also check https://github.com/mercadopago/dx-php/blob/0e2967e907829913aab5c1ebd34af399e5ee695e/composer.json#L24
According to readme, php 5.5 is not supported, you'll get an error installing dependencies under php 5.5
So the pipelines should work at least for all versions >= 5.6

Also, the output from phpunit 5 is:
....E.E.E..EFF.E.E....ERRRR.ERRRREIIIIIII

So lots of errors to fix

@joelibaceta Can you create a PR please?

https://github.com/mercadopago/dx-php/pull/114

Solved in https://github.com/mercadopago/dx-php/pull/114

@joelibaceta thanks!


Link org to session

This feels redundant because a Session is linked to an Account that always has an organisation linked to it. This is checked when logging in during the verifyPublisherKeyOrganisation function. If anything does not exist, the client can not log in (we should check if that is really the case though, that code is copied from the automatic-submission-service).
Since you did not give any motivation here on the PR, is there anything else you are trying to achieve?

This feels redundant because a Session is linked to an Account that always has an organisation linked to it. This is checked when logging in during the verifyPublisherKeyOrganisation function. If anything does not exist, the client can not log in (we should check if that is really the case though, that code is copied from the automatic-submission-service). Since you did not give any motivation here on the PR, is there anything else you are trying to achieve/protect against?

A more fine grained approach is better; if things change, the session can be deleted for that particular instance. Furthermore, once we allow writing stuff to graphs, mu-auth makes sure only the specific graph gets updated

But this is not more fine grained. A session has exactly one account and an account has exactly one organisation. Adding the organisation to the session is just duplicated information and one more triple to lose track of. If some vendor needs to manage multiple organisations, we should just make more accounts, right?


Bazel - TS2307: Cannot find module 'redux' or its corresponding type declarations.

bazel build fail do to inability to resolve redux.

Updated yarn add -D @bazel/typescript and typescript libraries and build succeed. Strange.

And it seems that i can't name the rule target redux as it somehow interferes with ... somewhat ???
Getting an error:
INFO: Invocation ID: 6bc45ad1-5ab8-477a-828d-8b0683afcca3
INFO: Analyzed target //apps/front/src/store/src/lib/redux:redux (1 packages loaded, 8 targets configured).
INFO: Found 1 target...
INFO: Writing explanation of rebuilds to 'bazel-explain.txt'
ERROR: /home/dzintars/code/github.com/dzintars/prime/apps/front/src/store/src/lib/redux/BUILD.bazel:5:11: Compiling TypeScript (devmode) //apps/front/src/stor
e/src/lib/redux:redux failed (Exit 1)
apps/front/src/store/src/lib/redux/src/createReducer.ts:1:44 - error TS2307: Cannot find module 'redux' or its corresponding type declarations.

1 import { Reducer, ReducersMapObject } from 'redux'
                                             ~~~~~~~
apps/front/src/store/src/lib/redux/src/createStore.ts:1:70 - error TS2307: Cannot find module 'redux' or its corresponding type declarations.

1 import {combineReducers, createStore, applyMiddleware, Reducer} from 'redux'
                                                                       ~~~~~~~

Target //apps/front/src/store/src/lib/redux:redux failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.287s, Critical Path: 0.18s
INFO: 0 processes.
FAILED: Build did NOT complete successfully

[Process exited 1]

As soon as rename the target to reduxy as example, the build is successful again.


Implement Stage 1 of cloud-init data generation

This includes switching from flexvolume-based cloud-init specs to annotations.

This change is

+1, after fixing disccussed nits with Piotr

Reviewed 28 of 28 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 28 of 28 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

docs/volumes.md, line 45 at r1 (raw file):

> The target element controls the bus / device under which the disk is exposed to the guest OS. The dev attribute indicates the "logical" device name. The actual device name specified is not guaranteed to map to the device name in the guest OS. Treat it as a device ordering hint

4. Attached disks are visible by the OS inside VM as hard disk devices `/dev/vdb`, `/dev/vdc` and so on. As said above there is no fixed behaviour form device names as well as regarding to the order on PCI bus.

It's not introduced there, so it's not blocking this PR, but i'm noting there that i don't quite understand second sentence in this point. Probably there should be s/form/for/.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable


strace 4.17

Signed-off-by: Bob W. Hogg<EMAIL_ADDRESS>Contributing to homebrew-extra:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[x] Have you built your formula locally prior to submission with brew install <formula>?

Thanks, Bob!


Bug: The add_handler API from logger was removed

Expected Behaviour
In version 2.4.0 adding a handler to the log was easy. I would expect adding a handler to my log to be as simple as addHandler.
Current Behaviour
Method doesn't exist

Code snippet
logger = logging.Logger()
logger.addHandler(additional_handler)

But that API was removed on version 2.15.0. I depend on it to be able to log to cloudwatch and other places. I was reading the changelog but could not find any reference to this.
the only way around of this is to mess with the internals:
logger._logger.addHandler(additional_handler)

### Possible Solution

Semver would dictate that the public API doesn't change with a minor version upgrade. Did I miss something something regarding this breaking change? Is there another workaround?

### Steps to Reproduce

Above

### Powertools for AWS Lambda (Python) version

latest

### AWS Lambda function runtime

3.10

### Packaging format used

PyPi

### Debugging logs

_No response_

Apologies, closing, cannot reproduce it again.

Apologies, closing, cannot reproduce it again.

Hey @alexandreczg - did you get a runtime error or was a static checker error saying the method doesn't exist?
The former would be a regression tho I can't reproduce it either. If it's the latter, we can address that with a PR to implement it and proxy it to _logger.addHandler so mypy is happy.
This is the change I made that would cause the latter but not the former (tested with a stream handler + file log handler now).
Please let us know ;)
PS: No need to apologise, better safe than sorry and we appreciate your time flagging it very much!!
https://github.com/awslabs/aws-lambda-powertools-python/pull/2334

Hey @heitorlessa, thank your for addressing this, commendable your dedication!
It was a typing error actually, not runtime. I use pyright/pylance (vscode). I freaked out since it had been a long hours day and when I was about to push my code I start getting that error. Couldn't really understand it since it had been working. I regressed to version 2.4.0 (it was my last stable version) but quickly realized that I had implemented the new batch partial processor (SQS). So, I went back to 2.16.0 and magically the linting error went way... I'm not sure what or how it all happened, but when I introspected the logger class, I couldn't find the addHandler method.
I'll keep your and this thread updated if something is to change now that I have pushed my code to AWS and using latest layer. 🤞

@heitorlessa , okay in version 2.16.1 the issue is back

@heitorlessa , okay in version 2.16.1 the issue is back

That's the piece I mentioned it's expected -- does it fail if you run it?
Pyright (what Pylance uses) can't infer through the object proxy so it believes it doesn't exist. At runtime, it works.
If you can confirm it works, feel free to make a PR adding a "addHandler" method that call self._logger.addHandler so Pylance will be happy in the next release - more than happy to accommodate that ;)

Hi @heitorlessa, I can confirm it works. I will look into how I can open a PR to fix the linting. Another note, unrelated but would like your eyes on the batch_processor. I don't think it is working as it should:

It is doing records: List[Dict] = event.get("Records", []) but catching any AttributeError that comes from that line. I don't believe this will ever catch anything. BAsically, I'm passing any event to it, and it's just going into the:
with processor(records, record_handler, context):
        processor.process()

with an empty list of records which of course returns:
{'batchItemFailures': []}

I don't think this is supposed to happen. Please, correct me if I am wrong. I will create a new bug ticket if needed for tracking purposes.

hey @alexandreczg - we included the addHandler as part of an emergency release we had to make, so v2.16.2 (or Layer v34) will make Pylance happy; there'll surely be many opportunities for contribution.
on Batch, please create an issue describing your intended outcome. The reason we're defensively catching AttributeError is that some customers don't pass the event like you are (expected usage) - if they pass a list of records this will fail with an AttributeError, therefore raising a more helpful error on why that's the case.
As to {'batchItemFailures': []}, this is expected when you don't have any error. Batch will include message IDs that failed to be processed. If you throw any exception in your record handler function, you'll see this populated.
An empty {'batchItemFailures': []} means: "Entire batch processed successfully, please delete all messages".
from aws_lambda_powertools.utilities.batch import (
    AsyncBatchProcessor,
    EventType,
    async_process_partial_response,
)
from aws_lambda_powertools.utilities.data_classes.sqs_event import SQSRecord
from aws_lambda_powertools.utilities.typing import LambdaContext

processor = AsyncBatchProcessor(event_type=EventType.SQS)

async def async_record_handler(record: SQSRecord):
    ...

def lambda_handler(event, context: LambdaContext):
    records = event.get("Records", [])

    # This will fail because `records` is no longer a Dict
    return async_process_partial_response(
        event=records, record_handler=async_record_handler, processor=processor, context=context
    )

@heitorlessa thank your for the quick around on this 🙇


September 2018 meetup

[x]  Speaker: @adamgiese
[x]  Sponsor: Cloudflare
[x]  Confirm venue
[x]  Meetup post
[x]  Blog post
[x]  Tweet
[ ]  Order pizza
[ ]  Record stats
[ ]  Invoice sponsor

@DrewML, here's the pizza order:
From East Side Pies Rosewood<PHONE_NUMBER>:
2 pepperoni
1 pepperoni and mushroom
1 margherita
1 spinach, mushroom, green bell pepper, black olive, and basil
all double cut
plates and napkins for 50
deliver at 7:15pm to 200 W Cesar Chavez St #300 (3rd floor)

Reimbursement rules from Cloudflare
Cloudflare slides

🍕 order has been placed


VM Start/stop Issue

Am using following API to start automatically in scheduler,
compute_client.virtual_machines.start(group,vmName)
async_vm_start.wait()
Most of the time auto start not working will take a long time to start.
I comment that async_vm_start.wait()  and tried,was given fast response.
Need to know why this function used during VM Start?

Hi @indumathymk
If you don't need to wait for this to start, you can pass polling=False as parameter, that will exist immediately. If you really need to be sure it started, you have to wait....
Note that the best place to discuss this matter is inside the main repo:
https://github.com/Azure/azure-sdk-for-python


Consideration of world based inventories

I see you've put it into EssentialCmds, but I don't know if it belongs in an "essentials" plugin - is it going to be well used? Gut feeling says no, but I'd like input.
We could write an "Extra" plugin that contains less used things - so non-essential stuff can go into there. We could put it in anyway.
Worth thinking about.

ProjectInventories has this feature, but I put it in EssentialCmds as it offered world commands, and wanted the world feature to be complete. Since we have a world module ourselves, it's worth thinking about it.

I've thought about this: right now, I'd like to focus on other features - considering the inventory problems we have encountered.
If we put this in, we'll look at this either towards the end of the 1.0 cycle or for 1.1. I feel there is a lot more that is important right now.

I don't think we should add this. It's a specialist feature that most servers won't likely use, and I think something like Project Inventories can do a much better job on this, as that is it's only focus. EssentialCmds has a lot of issues with this IIRC.


Fatal error: Class 'Pantheon\TerminusPancakes\Apps\PancakesApp' not found

Fatal error: Class 'Pantheon\TerminusPancakes\Apps\PancakesApp' not found in ~/.terminus/plugins/terminus-pancakes/src/Apps/HeidiSql.php on line 8

System specs:
Terminus 1.0.0-beta.1

PHP 7.1.0 (cli) (built: Jan  7 2017 22:40:10) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies

Composer version 1.3.0 2016-12-24 00:47:03

@uberhacker can you confirm this? I never duplicated it but I believe I fixed it.

For now i forced include the Dependency App. We can probably switch to using better autoloading for the "Apps" but the important thing is it's working for me again.

@uberhacker can you try the lastest commit? I was able to duplicate & fix it for now

See #16 and #18


[RFC] Remove removeStream() method, use removeReadStream/removeWriteStream instead

The removeStream() acts as a shortcut to essentially call both removeReadStream() and removeWriteStream() in one go. It's unclear how much value this method actually provides and it looks like this has attracted some low quality code in the past. As such, I'm filing this PR as an RFC to see if it makes sense to drop this unneeded method.
Refs #110

Seems logical. reactphp/stream and reactphp/zmq will require updating.

Seems logical. reactphp/stream and reactphp/zmq will require updating.

Yep, here's the first PR https://github.com/reactphp/stream/pull/121 :shipit:

Hi!
About:

Seems logical. reactphp/stream and reactphp/zmq will require updating.

Here my PR to update reactphp/zmq#53