Different components based on user role

So this is a case that i arrived upon and i wanted to consult with you guys on it.
Say i have different roles for the users of the site, and the homepage for each role is different.
For example, if i enter the site as a "Teacher" then my '/' route will point to a list of classes that i teach
If i enter as a student, my '/' route will point to a list of grades that i have...
How would you do that kind of login?
I was thinking on 2 options:

Playing around with the routes.js file
Inside the main page component, return different component based on the role.

Bonus question: Has anyone played around with splitting the code into different bundles? I mean, have a "teacher" and "student" bundles, both having a third shared resource file but each of them only has the code that relates to them.... somehow....

Here are two active PRs pertaining to code splitting:
https://github.com/reactGo/reactGo/pull/823
https://github.com/reactGo/reactGo/pull/841
The way it's set up is that it's splitted on routes, so I'm not sure how to serve different bundles for the same routes, but is probably possible as long as you can differentiate it somehow. The manifest.json file contains all bundles.

Thanks for the PR's i'll definitely look into them!
Regarding the different options, i also lean more towards option 2 as it seems that routes.js doesnt really need to concern itself too much with roles and users.
The code for the student parts will be available when logged in as a teacher but dont think its that bad.


x/tools/go/loader: data race in tests

https://storage.googleapis.com/go-build-log/449ef379/linux-amd64-race_bbcd4378.log
package nosuchpkg is not in std (/workdir/go/src/nosuchpkg)
package nosuchpkg is not in std (/workdir/go/src/nosuchpkg)
open /workdir/gopath/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
open /workdir/gopath/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
/workdir/gopath/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
/workdir/gopath/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
	/go/src/c (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath'))
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
	/go/src/c (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath'))
/go/src/b/x.go:1:21: could not import c (/go/src/c/x.go:1:8: expected 'IDENT', found 'EOF')
/go/src/c/x.go:1:20: expected operand, found 'EOF'
cannot find package "two/three" in any of:
	/go/src/two/three (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath')
cannot find package "http" in any of:
	/go/src/vendor/http (vendor tree)
	/go/src/http (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath')
/go/src/c/x.go:1:31: cannot convert false (untyped bool constant) to type int
==================
WARNING: DATA RACE
Write at 0x00c00007c288 by goroutine 1882:
  go/types.NewChecker()
      /workdir/go/src/go/types/check.go:240 +0xfd
  golang.org/x/tools/go/loader.(*importer).newPackageInfo()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:1053 +0x836
  golang.org/x/tools/go/loader.(*importer).load()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:961 +0xa4
  golang.org/x/tools/go/loader.(*importer).startLoad.func1()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:949 +0x45

Previous write at 0x00c00007c288 by goroutine 1888:
  go/types.NewChecker()
      /workdir/go/src/go/types/check.go:240 +0xfd
  golang.org/x/tools/go/loader.(*importer).newPackageInfo()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:1053 +0x836
  golang.org/x/tools/go/loader.(*importer).load()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:961 +0xa4
  golang.org/x/tools/go/loader.(*importer).startLoad.func1()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:949 +0x45

Goroutine 1882 (running) created at:
  golang.org/x/tools/go/loader.(*importer).startLoad()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:948 +0x329
  golang.org/x/tools/go/loader.(*importer).importAll()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:897 +0x53d
  golang.org/x/tools/go/loader.(*importer).addFiles()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:992 +0x127
  golang.org/x/tools/go/loader.(*importer).load()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:968 +0x199
  golang.org/x/tools/go/loader.(*importer).startLoad.func1()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:949 +0x45

Goroutine 1888 (finished) created at:
  golang.org/x/tools/go/loader.(*importer).startLoad()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:948 +0x329
  golang.org/x/tools/go/loader.(*importer).importAll()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:897 +0x53d
  golang.org/x/tools/go/loader.(*importer).addFiles()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:992 +0x127
  golang.org/x/tools/go/loader.(*importer).load()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:968 +0x199
  golang.org/x/tools/go/loader.(*importer).startLoad.func1()
      /workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:949 +0x45
==================
--- FAIL: TestLoad1 (4.03s)
    testing.go:1465: race detected during execution of test
--- FAIL: TestLoad2 (4.14s)
    testing.go:1465: race detected during execution of test
FAIL
FAIL	golang.org/x/tools/go/loader	20.833s

Yeah, I had the same thought. But I can't reproduce it locally with 1.20, or tip, or tip from Jun 23. I just noticed that https://go.dev/cl/508437 is also failing in -race even though the change is benign. I've asked the runtime folks.

Possibly related: https://go.dev/cl/505676

This is actually resulting from https://go.dev/cl/507975, where NewChecker(...pkg...) was updated to mutate pkg.
As @prattmic pointed out in chat, importer.newPackageInfo calls NewChecker concurrently with types.Unsafe.
There are probably two bugs here: go/loader should not call NewChecker with types.Unsafe, but also we should probably not mutate pkg in NewChecker.  Certainly the checker owns the package, but lets defer mutation until type-checking actually begins.

Well spotted. NewChecker should have an internal comment stating that it may be called with types.Unsafe, and that it should not mutate pkg until CheckFiles (which is never called for Unsafe). And CheckFiles should either return immediately or panic if pkg==Unsafe.

Yes, I'll fix.


Materialize css redesign

There is still a bug. When picking a date it doesn't set it correctly and it ends up being null or previous value.


Line 1 column 1 error

I have this issue retrieving tweets from user DrOakley1689.

Unfortunately, it looks like that specific account is one that, for one of multiple reasons, Twitter doesn't allow you to scrape.
You can reproduce the issue with this simple script that uses the twint library directly.
import twint

username = "@DrOakley1689"
c = twint.Config()
c.Username = username

twint.run.Search(c)

Sorry, I've tried three more accounts and get the same error.

Similarly to what you are seeing, I was able to reproduce the issue with a number of other accounts, and have not been able to find an account that doesn't generate the error.
It looks like it's an issue with the twint scrapping library and that other folks are experiencing it, as referenced in this issue (https://github.com/twintproject/twint/issues/915).
Once the twint team fixes the issue, this script should start working correctly.

I followed the directions to uninstall and re-install twint (https://github.com/twintproject/twint/issues/915#issuecomment-716196991),
and am now getting this error.

Sorry for the delay.  Twitter appears to be making it more difficult for scraping tools to collect information.  I think it's likely that they will continue to make it difficult moving forward.
If I were to port this script to use the Twitter API, which you can access by applying for a Twitter App, would you still find it useful?

Thank you for replying. I wouldn't, because I have deactivated my Twitter account and wouldn't open a new account.


Python3 support

Revamp sandboxing approach to support python 3.9 (until now our sandboxing method has limited us to python 2.7).

(This issue only applies to the Grist hosted service - grist-core itself can run with python 3.9)

New documents on hosted Grist are now python 3.9. Existing documents can be switched to python 3 (if you are willing to make any fixes to formulas that might be needed) using an "engine" setting in document settings.
Grist-core itself can be configured to run with a range of python versions.

We have documented Python 3 support here: https://support.getgrist.com/python/ - including how to switch an existing document from Python 2 to Python 3, and fixes for common formula differences. There will be more work to do to assist migrations. Closing this roadmap issue now that Python 3 is supported and documented.


Availability of resources in DR

I can't find anything in the ASR documentation regarding the availability of resources in the target datacenter during a disaster.
For example, say I have 300 VMs using ASR from Central Canada to Eastern Canada regions.  I have RI's for the VMs in Central Canada.  I have ASR for each of these VMs replicating them to Eastern Canada.
As an RI and ASR customer with VMs in Central Canada, what assurance (if any) do we have that capacity will be available to us in Eastern Canada during a Central Canada disaster?
If there is no assurance that compute capacity will be available to ASR customers:

What's the point of ASR?  We'll all be down.
How do we obtain reassurance that compute capacity will actually be available to ASR customers during a disaster?

We employ ASR specifically to mitigate risk of regional disaster.  Your documentation should address the availability of capacity during a disaster, and the impact ASR customers may experience.
Please update this documentation to address this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c714cc40-47f5-fb3c-51e0-f504c38ec937
Version Independent ID: 15da2499-61eb-ec11-53be-7d006cdd4b38
Content: Set up disaster recovery for Azure VMs to a secondary Azure region with Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-tutorial-enable-replication.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@JohnDelisle Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Is there any update on this question? I too have concerns over the capacity available during an Azure region outage, and this may have a large impact on design of our disaster recovery.

I have found that the "Common Questions" article has a note that addresses this concern:

The Site Recovery team works with the Azure capacity management team to plan sufficient infrastructure capacity, and to help ensure that VMs protected by Site Recovery for will successfully be deployed target region when failover is initiated.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


[Bug] Showing Unreadable Text Instead of Displaying Images in Response Pane

When making API requests intended to retrieve images, the response in the request pane is displaying unreadable text instead of rendering the image

Related PR on image rendering: https://github.com/usebruno/bruno/pull/480

Fixed in 4b297f3

Closing this. Please re-open if needed.

This issue still persist if request is post with json body

This issue still persist if request is post with json body. mode is image, but image is not shown

Yeah, currently the Image preview does a separate GET request to the URL and does not show the original image response. I want to tackle this in the next week or something, but we currently already a lot of PR's open. Can you create a new issue for this? Maybe with an example request?


Disable HSTS when HTTPS_METHOD=noredirect

First, thanks to @palamccc for reporting this in #453.
When using HTTP_METHOD=noredirect, the user is essentially saying "don't automatically redirect my users from HTTP to HTTPS, however, users that end up at the HTTPS site are still being sent the HSTS header, which forces the client to redirect all HTTP requests to HTTPS.  My feeling is that HSTS should be removed when HTTPS_METHOD=noredirect.
I have implemented the change in this PR and added tests to cover the normal HSTS behavior and the noredirect behavior (after sifting through the bats docs for an hour before stumbling on refute_output :) ).
I've also expanded the documentation on HTTPS_METHOD as suggested in #446

Thanks @kamermans!


kube-inject support for debug images

Add a flag --debug for kube-inject so the resulting injected proxy and init use the debug baseline image.

Partialy fixed in istio/manager#702 for alpha, moving to beta to add the flag.

Issue moved to istio/galley #13 via ZenHub

Subscribe


Adds the concept of a presentation submission to VPs

Adds the concept of a presentation submission to the VPV1Unsigned type and its correlated buildVPV1Unsigned function. This is in support of the presentation-exchange spec presentation submissions.

This PR won't build until there's a valid context hosted for the presentation-exchange submission. There's an issue on this, which I'm following and will update this PR if needed based on that.

Until they get the context sorted out we could use an inline context like this:
{
  "@version": 1.1,
  "PresentationSubmission": {
    "@id": "https://www.w3.org/2018/credentials/#VerifiablePresentation",
    "@context": {
      "@version": 1.1,
      "presentation_submission": {
        "@id": "https://identity.foundation/presentation-exchange/#presentation-submissions",
        "@type": "@json"
      }
    }
  }
}

Closing in favor of https://github.com/affinityproject/affinidi-core-sdk/pull/49 due to GH action secret issues


use json.loads for debug

leader_get returns a stringified list. So the set operations fail, and the log currently looks like:
unit-contrail-controller-0: 08:02:16 ERROR unit.contrail-controller/0.juju-log there are a dead controllers that are in the list: set([u'"', u'.', u'1', u'0', u'3', u'5', u'9', u'8', u'[', u']'])

This patch fixes that.
On a related note, why does leader_elected use ips = get_controller_ips(), when all 3 other functions which set ips use ips = json_loads(leader_get("controller_ips"), dict())? Is that a possible bug?

than you.


Environment keys cleanup

No functional changes, just a small cleanup of #61

Coverage remained the same at 100.0% when pulling 9db678dd8dacefe5efd11bb3e01f2d8d0d7fde6c on environment-keys-cleanup into b1d18becad230d47868474cf369d6bdd436887b0 on develop.


Use wss protocol for HTTPS conections

Signed-off-by: Frank Jogeleit<EMAIL_ADDRESS>What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:
Use WSS as Websocket Protocol for Secrute Connections (HTTPS).
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from fjogeleit after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 66d7acbc95538cd562c9a80ff2ef25e934fe8bc6

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Replace lock-based queues with MoodyCamel’s lock-free queue

In particular, the queues in the RPC layer: See https://github.com/dcrankshaw/clipper/blob/high-perf-clipper/src/libclipper/include/clipper/rpc_service.hpp, https://github.com/dcrankshaw/clipper/blob/high-perf-clipper/src/libclipper/src/rpc_service.cpp)

Fixed by #380


fix: autompletion not working in demo

fix #223
The language lexer in monaco-editor treats yaml's word as a string type.
https://github.com/microsoft/monaco-editor/blob/main/src/basic-languages/yaml/yaml.ts#L99
And the monaco-editor does not enable quick suggestions for string type by default.
https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestInlineCompletions.ts#L134
So we should set quickSuggestions.strings to true to enable autocompletion, similar to what vscode-yaml does.
https://github.com/redhat-developer/vscode-yaml/blob/main/package.json#L233

@remcohaszing cc

Thanks! This works great, but it only fixes it for the demo. The issue is about the monaco-editor-webpack-plugin examples.
Could you apply these changes to the other examples too?

@remcohaszing Of course. I have done.

Thanks!


fix(gateway): ignore DNS64 IP addresses

Many parts of the Internet, especially cloud services, utilize NAT64 & DNS64 to deal with the IPv4 exhaustion problem. In such an environment, AAAA queries for an IPv4-only domain are answered with synthesized IPv6 addresses from the 0064:ff9b/96 subnet. See RFC6147 for details. For these synthesized addresses to be routable, a NAT64 gateway needs to be present too.
Within connlib, we already implement IP translation (i.e. NAT64) according to RFC6145 because we resolve all DNS queries for DNS resources locally on the client before we establish a connection to the gateway. As a result, a client might send IPv6 traffic but the domain the client is trying to reach only resolves to IPv4 on the gateway. At this point, the gateway needs to translate the packets.
If a domain has IPv6 records (even if they are DNS64 records), we currently don't perform any translation across IP versions and simply assign each proxy IP to a resolved one.
As a result, IPv6 traffic within firezone completely breaks in case the sysadmin that set up the gateway didn't also set up a NAT64 gateway next to the DNS64 resolver. It turns out, making this mistake is quite easy. Our AWS staging environment has this problem. One option would be to blame the user and just not do anything about this. Another option is what we do in this PR: Ignore all DNS64 records during DNS resolution on the gateway.
Connlib already implements NAT64 and therefore gracefully handles the case where a domain resolves only to IPv4 addresses. Thus, making use of those DNS64 records only causes problems in case the environment of the gateway is not set up correctly. Ignoring them on the other hand allows things to work smoothly.
The only downside here is that the NAT64 implementation of connlib is not yet battle-tested compared to an external NAT64 gateway. Thus one might argue that fixing the environment might be the better option. However, unless we re-design firezone and remove NAT64 from connlib entirely, we need to implement it correctly anyway for the case where there is no DNS64 resolver on in the gateway's environment. Plus, there is always the option of making this behaviour configurable if desired.

This seems like a good idea but feels a bit scary, like it could cause issues for edge cases we haven't imagined yet. Will try to do a bit more research here.
For fixing the AWS issue specifically, it looks like it's trivial to disable DNS64 for a subnet which I think would fix the problem in AWS.

You can enable or disable DNS64 on a subnet using the modify-subnet-attribute using the AWS CLI or with the VPC console by selecting a subnet and choosing Actions > Edit subnet settings.

This seems like a good idea but feels a bit scary

Yeah the question is, do we want to put that burden on our users or fix it in the code?
Technically, it is their responsibility to set up the environment correctly :man_shrugging:

For fixing the AWS issue specifically, it looks like it's trivial to disable DNS64 for a subnet which I think would fix the problem in AWS.

You can enable or disable DNS64 on a subnet using the modify-subnet-attribute using the AWS CLI or with the VPC console by selecting a subnet and choosing Actions > Edit subnet settings.

I can look into making a terraform change instead to fix our env. Additionally, we can a log to the gateway if we detect DNS64 addresses?

Additionally, we can a log to the gateway if we detect DNS64 addresses?

I opted for something a bit more general: Emit a warning if an IP appears to be dead yet we are actively trying to use it: https://github.com/firezone/firezone/pull/5482

Closing this in favor of https://github.com/firezone/firezone/pull/5483 or https://github.com/firezone/firezone/pull/5484.


Update tensorflow in base image requirements

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python 3.8 PostCommit

Run Python 3.9 PostCommit

Run Python 3.10 PostCommit

Run Python 3.8 Postcommit

Run Python Portable PreCommit

looks like all tests passed, so I merged given your LGTM.


Crash on capture in IDXGISwapChain::Present()

Hi,
Whenever I capture I get a bad_alloc exception. Here's the callstack:
KernelBase.dll!7693a6f2()	Unknown
[Frames below may be incorrect and/or missing, no symbols loaded for KernelBase.dll]
[External Code]
renderdoc.dll!WrappedID3D11Device::Serialise_InitialState(ResourceId resid, ID3D11DeviceChild * res) Line 1787	C++
renderdoc.dll!D3D11ResourceManager::Serialise_InitialState(ResourceId id, ID3D11DeviceChild * res) Line 110	C++
renderdoc.dll!ResourceManager<ID3D11DeviceChild *,ID3D11DeviceChild *,D3D11ResourceRecord>::InsertInitialContentsChunks(Serialiser * fileSerialiser) Line 1039	C++
renderdoc.dll!WrappedID3D11Device::EndFrameCapture(void * dev, void * wnd) Line 3011	C++
renderdoc.dll!RenderDoc::EndFrameCapture(void * dev, void * wnd) Line 502	C++
renderdoc.dll!WrappedID3D11Device::Present(WrappedIDXGISwapChain4 * swap, unsigned int SyncInterval, unsigned int Flags) Line 3366	C++
renderdoc.dll!WrappedIDXGISwapChain4::Present(unsigned int SyncInterval, unsigned int Flags) Line 491	C++

Am I doing something wrong or is this a bug?

That function is responsible in large part for the peak CPU memory usage in RenderDoc, at the end of a capture when reading back all resource contents at the start of the frame (e.g. textures that weren't shadowed offline and render target contents).
From the last frame of the callstack, it looks like you're running in 32-bit mode? If that's the case my guess would be that you're genuinely just running out of memory. Which means that you're not doing something wrong, but it's not really a bug either.
There are no easy wins if that is the case - it's pretty much a matter of running with less memory usage (in this case particularly GPU memory, but obviously if you have a way of reducing your CPU memory footprint then that will help allow for more overhead). Or of course, running in 64-bit is preferred :smile:.

Thanks for the quick response! You're right - turns out my absurdly high shadowmap resolution was the culprit! I bumped it up as a test and forgot to reset it.

Yep, that would do it :). Glad you got it sorted.


appleseed.python blenderseed work.

Added MurmurHash to foundation and compute_mesh_signature (from appleseed.maya)

useful to generate mesh filenames, auto-instancing and possibly other use cases.

Added missing transform related methods to appleseed.python

Fixed and rebased


Uses offline version of Draw.io by default?

The feature list for the VSCode Draw.io plugin states:

Uses an offline version of Draw.io by default.

Is this also true of this Jetbrains plugin?

yes. @hediet, the author of the VSCode plugin implemented it the same way for the intellij plugin

cool!

plugin description updated


fix link of modeling.py

retry fix link of modeling.py by hori-ryota · Pull Request #17 · google-research/bigbird

@manzilz :eyes:

thanks!


[Unity] Adding VS Code and flexibility

Reasons for making this change:
Added support to VS Code cache directory. A lot of developers are starting to use VS Code as their editor of choice because of its lightweight and seamless support on both Windows and Mac (which is the usual mix in Unity development teams nowadays).
The second commit reflects on different development practices for Unity projects in which the project directory is not the root one, but a subdirectory inside it along with other directory for doc and raw files.
Links to documentation supporting these rule changes:

The workspace setting file is located under the .vscode folder in your root folder.

https://code.visualstudio.com/docs/getstarted/settings

Closing this out due to inactivity and outstanding review feedback


deploy package

test on local

run: npm i -g vsce
run: vsce package
run: code --install-extension vscode-qlik-0.0.1.vsix

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to display ContentDialog backdrop/smoke over custom TitleBar

As in title. Current result is this.  https://imgur.com/HKuIZ4E
How to dispay it over custom titlebar? Till preview 3 all was ok.

I think you can't, it seems to be a bug. Are you targeting Win11 exclusively or do you need backwards compatibility to Win10? In W11 you should switch from the old SetTitleBar() method to the new AppWindow system. Here is a snippet of my app that might help you:
public AppWindow AW { get; set; }
public bool IsCustomizationSupported { get; set; } = false;
public MainWindow()
{
	InitializeComponent();
	IsCustomizationSupported = AppWindowTitleBar.IsCustomizationSupported();

	if (IsCustomizationSupported)
	{
		AW = GetAppWindowForCurrentWindow();
		AW.TitleBar.ExtendsContentIntoTitleBar = true;
		CustomDragRegion.Height = 22;
		AW.Title = "ConTeXt IDE";
		//AW.Closing += AW_Closing;
		//AW.SetIcon(Path.Combine(Package.Current.InstalledLocation.Path, @"Assets/", @"SquareLogo.png"));
	}
	else
	{
		CustomDragRegion.BackgroundTransition = null;
		CustomDragRegion.Background = null;
		ExtendsContentIntoTitleBar = true;
		CustomDragRegion.Height = 28;
		SetTitleBar(CustomDragRegion);
		Title = "ConTeXt IDE";
	}
}

private AppWindow GetAppWindowForCurrentWindow()
{
	IntPtr hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this);
	WindowId myWndId = Microsoft.UI.Win32Interop.GetWindowIdFromWindow(hWnd);
	return AppWindow.GetFromWindowId(myWndId);
}

This way, at least in W11 (where IsCustomizationSupported is true) the smoke does work in the Titlebar.

@pratikone and @bpulliam is this possible today?

I'm experiencing this as well on my app using Windows App SDK V1.0 @StephenLPeters @gabbybilka
With my custom title bar and showing a ContentDialog, the entire window is blocked by the ContentDialog except for the Min, Max, and Close window buttons of the title bar.
This is not the expected behavior of the ContentDialog as it is expected to block the caption buttons as well (as seen in apps such as the Win 11 Notepad)

this is not possible today unfortunately because of the way custom titlebar is implemented. we could try to make it work, maybe ? marking it as a bug .

App sdk 1.1  stable. Still not fixed.   I was using this style to completely  hide defailt titlebar and make my own.

Style

var child = VisualTreeHelper.GetChild(parent, 0);

It actually have to be:
var child = VisualTreeHelper.GetChild(parent, 2);

The third element is the smokeLayerBackground

Taking advantage of the CommunityToolkit.WinUI.UI.Behaviors.BehaviorBase class
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Media;
using Microsoft.UI.Xaml.Shapes;

/// <summary>
/// Make ContentDialog's SmokeLayerBackground dsiplay over custom titleBar
/// </summary>
public class ContentDialogBehavior : CommunityToolkit.WinUI.UI.Behaviors.BehaviorBase<FrameworkElement>
{
    /// <inheritdoc/>
    protected override void OnAssociatedObjectLoaded()
    {
        DependencyObject parent = VisualTreeHelper.GetParent(AssociatedObject);
        DependencyObject child = VisualTreeHelper.GetChild(parent, 2);
        Rectangle smokeLayerBackground = (Rectangle)child;

        smokeLayerBackground.Margin = new Thickness(0);
        smokeLayerBackground.RegisterPropertyChangedCallback(FrameworkElement.MarginProperty, OnMarginChanged);
    }

    private static void OnMarginChanged(DependencyObject sender, DependencyProperty property)
    {
        if (property == FrameworkElement.MarginProperty)
        {
            sender.ClearValue(property);
        }
    }
}

just add this to your project, and add xaml in your ContentDialog like below
<ContentDialog ...>
    <mxi:Interaction.Behaviors>
        <shcb:ContentDialogBehavior/>
    </mxi:Interaction.Behaviors>
</ContentDialog>

Works fine for me.

I just set titlebar container height to 0 when call contentdialog. I like the last solution,  but how make it work if I create dialog code behind?

ContentDialog dialog = new();
...
Microsoft.Xaml.Interactivity.Interaction.SetBehaviors(dialog ,new BehaviorCollection(){new ContentDialogBehavior()});

Tested, and works.

You are my hero.

```cs
var child = VisualTreeHelper.GetChild(parent, 0);

It actually has to be:
var child = VisualTreeHelper.GetChild(parent, 2);

The third element is the smokeLayerBackground

VisualTreeHelper.GetChild(parent, 2); - Catastrophic failture
VisualTreeHelper.GetChild(parent, 1); - Smoke null
VisualTreeHelper.GetChild(parent, 0); - Actually works but need to test

```cs
var child = VisualTreeHelper.GetChild(parent, 0);

It actually has to be:
var child = VisualTreeHelper.GetChild(parent, 2);

The third element is the smokeLayerBackground

VisualTreeHelper.GetChild(parent, 2); - Catastrophic failture VisualTreeHelper.GetChild(parent, 1); - Smoke null VisualTreeHelper.GetChild(parent, 0); - Actually works but need to test

That‘s wierd.

You can set a breakpoint and inspect the parent.Children

```cs
var child = VisualTreeHelper.GetChild(parent, 0);

It actually has to be:
var child = VisualTreeHelper.GetChild(parent, 2);

The third element is the smokeLayerBackground

VisualTreeHelper.GetChild(parent, 2); - Catastrophic failture VisualTreeHelper.GetChild(parent, 1); - Smoke null VisualTreeHelper.GetChild(parent, 0); - Actually works but need to test

It cound be my issue, cause my dialog is modified from a UserContol template.

Well... Just use GetChildrenCount and a for loop to test all elements
using CommunityToolkit.WinUI.UI.Behaviors;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Media;
using Microsoft.UI.Xaml.Shapes;

/// <summary>
/// Make ContentDialog's SmokeLayerBackground dsiplay over custom titleBar
/// </summary>
public class ContentDialogBehavior : BehaviorBase<FrameworkElement>
{
    /// <inheritdoc/>
    protected override void OnAssociatedObjectLoaded()
    {
        DependencyObject parent = VisualTreeHelper.GetParent(AssociatedObject);

        for (int i = 0; i < VisualTreeHelper.GetChildrenCount(parent); i++)
        {
            DependencyObject current = VisualTreeHelper.GetChild(parent, i);
            if (current is Rectangle { Name: "SmokeLayerBackground" } background)
            {
                background.Margin = new Thickness(0);
                background.RegisterPropertyChangedCallback(FrameworkElement.MarginProperty, OnMarginChanged);
                break;
            }
        }
    }

    private static void OnMarginChanged(DependencyObject sender, DependencyProperty property)
    {
        if (property == FrameworkElement.MarginProperty)
        {
            sender.ClearValue(property);
        }
    }
}

@pratikone This should totally work now.

@Lightczx I don't know if the C# version works. The C++ version works 100% of the time, so the C# should work. If it doesn't then C# does something different to C++, and I don't know why.

@Lightczx I don't know if the C# version works. The C++ version works 100% of the time, so the C# should work. If it doesn't then C# does something different to C++, and I don't know why.

My dialog isn't created by code, and it's initialized by XAML parser.
I think it's the only difference.

Ran into this today as well, it is quite annoying. The whole point of a modal dialog is to prevent any input, but due to this issue the main menu is still clickable:

I too am still running into this. Windows App SDK 1.2.230217.4 for Windows 10.0.19041.0 on .NET 6.

Fixed using the approach mentioned above.
dialog.Loaded += OnLoaded;

void OnLoaded(object sender, RoutedEventArgs e)
{
    // Set the Theme

    dialog.RequestedTheme = ThemeHelper.ActualTheme;

    // Fix the smoke layer margin at the title bar

    DependencyObject popupRoot = VisualTreeHelper.GetParent(dialog);

    Rectangle smokeLayer = (Rectangle) VisualTreeHelper.GetChild(popupRoot, 0);
    smokeLayer.Margin = new Thickness(0);
    smokeLayer.RegisterPropertyChangedCallback(
        FrameworkElement.MarginProperty,
        (ss, dp) =>
        {
            if (dp == FrameworkElement.MarginProperty)
            {
                ss.ClearValue(dp);
            }
        });
}

// Show dialog

ContentDialogResult result = await dialog.ShowAsync();

A note for anyone coming across this problem still. The AppWindow titlebar APIs in the Windows App SDK itself to not have this problem. This does mean you need to use version 1.2 or newer of Windows App SDK if you need Windows 10 support. But it is unlikely to break or be problematic, unlike the current fix of looking thru the XAML tree for the smoke effect and patching it.
And as a bonus AppWindow's version of the caption buttons match how Win32 and UWP draw them. I don't know how the XAML team messed up the caption buttons.

I too am still running into this. Windows App SDK 1.2.230217.4 for Windows 10.0.19041.0 on .NET 6.

Fixed using the approach mentioned above.
dialog.Loaded += OnLoaded;

void OnLoaded(object sender, RoutedEventArgs e)
{
    // Set the Theme

    dialog.RequestedTheme = ThemeHelper.ActualTheme;

    // Fix the smoke layer margin at the title bar

    DependencyObject popupRoot = VisualTreeHelper.GetParent(dialog);

    Rectangle smokeLayer = (Rectangle) VisualTreeHelper.GetChild(popupRoot, 0);
    smokeLayer.Margin = new Thickness(0);
    smokeLayer.RegisterPropertyChangedCallback(
        FrameworkElement.MarginProperty,
        (ss, dp) =>
        {
            if (dp == FrameworkElement.MarginProperty)
            {
                ss.ClearValue(dp);
            }
        });
}

// Show dialog

ContentDialogResult result = await dialog.ShowAsync();

Hi, it's not related to this issue, but how do you make your "Back" arrow appear in the title bar? I know that I should change margin of the frame but how?

how do you make your "Back" arrow appear in the title bar? I know that I should change margin of the frame but how?

Hi, @Pietro228 I'm assuming you have already set ExtendContentIntoTitleBar to true,
place this peice of code in any Resources where can be applied to your NavigationView
<Thickness x:Key="NavigationViewContentMargin">0,44,0,0</Thickness>

The top margin should be consisent with you visual title bar height

it is fixed now with winappsdk 1.4 release. I overhauled the custom titlebar implementation and implemented so that content dialog works naturally with it. (no top offset)


run npm build during assemble?

the SCL image does this, https://github.com/sclorg/s2i-nodejs-container/blob/master/8/s2i/bin/assemble#L81-L88
I'm not sure how i feel about it.  I suppose it is a nice feature, especially for those that are using typescript/babel/etc.....   I think currently the only way to do that now, is to have a postinstall script in the package.json that runs the build

I think it's better than requiring a postinstall script, which isn't very intuitive and requires documentaiton.


react 在组件内部缺少 "t" 声明

react 在组件内部缺少声明
例: react-i18next
import { useTranslation } from 'react-i18next';
在组件内部使用钩子声明 t
const { t } = useTranslation();
期望该脚本在组件内部能把 t 的声明加上

这个不建议内置。因为当初考虑到能够兼容更多的i18n库。我这里是希望开发者中间封装一层i18n做兼容处理的。
以你这种情况为例，我说下怎么处理。

src目录下创建一个i18n.js

import { useTranslation } from 'react-i18next';
const { t } = useTranslation();
export default t;

在需要用t函数的jsx文件里引入i18n.js

import t from 'i18n';

webpack配置下路径别名(其他打包工具同理)

const path = require('path')
module.exports = {
  resolve: {
    alias: {
      'i18n': path.resolve(__dirname, './src/i18n'), // 前提是src和webpack在同级目录下
    }
  },
}

项目中就可以正确解析import t from 'i18n';。用的时候直接引入就行了

我这里有类似的例子。这是这个项目不需要额外配置别名。但是思路是一样的。即把t函数封装出来

import { useTranslation } from 'react-i18next';
const { t } = useTranslation();
export default t;

这种方式试过

嗯，我忘了它是个钩子。我后面加个配置吧

支持了。使用自定义配置吧
module.exports = {
  rules: {
    jsx: {
      importDeclaration: "import { useTranslation } from 'react-i18next';",
      functionSnippets: 'const { t } = useTranslation();', // react函数组件里，全局加代码片段
    },
  },
}

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。


Issues retrieving the correct number of messages.

I am having two separate but possibly related issues when getting messages.
The first issue I'm having is that api.messages.list(roomId=room.id) does not download the default of 50 messages, it downloads all messages. If I set max= that number is ignored.
The second issue is that the number of direct messages downloaded is 50 per person. I can't seem to find a way with this SDK to increase the number of direct messages to get.
Could you help me with these issues?
Here is my code to get the messages.
for room in room_list:
    room_msg_list = api.messages.list(roomId=room.id, max=100)
    messages_dict[room.title] = []
    for msg in room_msg_list:
        messages_dict[room.title].append(msg)

And here is my code to get the direct messages
for dm_room in list_dm_room_list:
    if dm_room.title in people_list:
        dm_room_msg_list = api.messages.list_direct(personEmail=people_dict[dm_room.title]['email'])
        dm_messages_dict[dm_room.title] = []
        messages_list = []
        for msg in dm_room_msg_list:
            dm_messages_dict[dm_room.title].append(msg)

Closing this issue as it is more than three years old.
For Posterity: The SDK API methods that return lists of objects actually return GeneratorContainers as described in the SDK documentation. What is not documented, and the docs could therefore be improved, is that you can slice GeneratorContainers to obtain the desired number of items. For example, api.messages.list(roomId=room.id)[:50]. The max= parameter only sets the maximum number of items the Webex API should return in a single response (i.e. the page size).


MWPW-147867 - [marquee] support RTL for loc

Added an opt in variant support-rtl to the [marquee] block to better support localization.
Text alignment in marquee block used on this page  are not working correctly with RTL geos rollout.
Variation: marquee (split, dark, one-third, xl-button, static-links)
Image and color is used as background.
expected result

actual result

URL: https://main--cc--adobecom.hlx.page/mena_ar/products/illustrator/generative-recolor
Resolves: MWPW-147867
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/marquee/marquee-rtl?martech=off
After: https://rparrish-marquee-rtl--milo--adobecom.hlx.page/drafts/rparrish/marquee/marquee-rtl?martech=off

Doc URLs:

Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/marquee?martech=off
After: https://rparrish-marquee-rtl--milo--adobecom.hlx.page/docs/library/blocks/marquee?martech=off

Testing Notes:
Inspect the DOM and update the <html dir="ltr" /> attribute to <html dir="rtl" /> and verify the marquee copy is aligned.
Doc urls have no support-rtl variants authored so they will still display bad unless added to the block classList.

Although on the feature branch everything looked good, the overlapping issue reappeared on stage.


Create Post Profile component

Create the Post Profile component which should have an “icon” like shape, the username and the user’s role. The component should receive the following parameters: username and user’s role. Please refer to the color palette for the accurate hex code colors.
Component Image:

Color Palette:

Can I take this from here?

Can I attempt this issue?

Hi, I’m Santiago Villarreal Arley, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon Buildathon for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.
Additionally, I’m a Gold Contributor with over 15 merged PRs, showcasing my commitment to open-source development and collaborative problem-solving.
To tackle this issue:
I’ll create a Post Profile component that includes an “icon,” username, and user’s role. The component will accept username and user’s role as props and will use the provided color palette for styling. The design will match the provided example image and be fully responsive.
ETA: 12-48 hours. Feel free to reach out via Telegram.

I would like to work on this issue

May I take this issue on? I'll create a reusable Post Profile component with an icon, username display, and role indicator using a consistent color palette.
Having experience with React component design, I'll ensure proper prop handling and styling while maintaining component reusability

Mind if I try this one?

Can I work on this, please?

Could I try solving this?
As a full-stack developer who has good experience working on frontend projects, I can handle this issue.
I'll design this component, adding the required props, implement a responsive styling and make it available to be used seamlessly in the required section of the app.

Can I take care of this issue?

Could I take on this issue?


Automated cherry pick of #12046

Cherry pick of #12046 on release-7.8.
/cc  @neallred
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 73584e228b394696944f923f5e83888f5cf5106f


server/shadow: Fix alpha pointer message so that it allows pixel with both 'xor' and 'and'

server/shadow: Fix alpha pointer message so that it allows pixel with both 'xor' and 'and'.
Original pointer alpha update message is too specific for x11 implementation.
It doesn't allow pointer alpha mask with both 'xor' color and 'and' mask, e.g.: the 'edit' pointer in windows text box.

Move shadow_client_convert_alpha_pointer_data to x11 implementation as it is specific for x11.
Update message definition to be more generic: to accept 'xor/and' mask directly.
Implementation of subsystem can implement its own way to convert pointer mask data.
Fixed fault handling to free the resource allocated.

@freerdp-bot test

@bmiklautz
Updated PR. We may need to launch test again.

@freerdp-bot test

@realjiangms looks very good to me. Thanks
+1

@freerdp-bot add to whitelist

@realjiangms I've white listed you now. Your pulls get now (re-)built automatically.

@bmiklautz Thanks.
Does it mean that later I can launch test myself by adding a comment with 'freerdp-bot' and 'test'?

@realjiangms the bot should automatically build all of your pull requests as well as if you later commit to an open pull request.

@bmiklautz Can we have this PR merged or we need more reviewer?


Update dependencies

This change updates, in separate commits:

Rubygems included from Gemfile
Ruby version in bundled Dockerfile
Node version used in bundled Dockerfile

Coverage remained the same at 87.186% when pulling 444df03309e80ef4b35f8938beec1ec63d74310d on security/update-dependencies into 16798ce200866be3d2dd0530a370f29ee56a042a on main.


Can't get parallelcluster 2.9 to start any compute nodes

Environment:
Parallelcluster version 2.9.1
Config file was created by a pretty vanilla "pcluster config" command:
[aws]
aws_region_name = us-east-2

[aliases]
ssh = ssh {CFN_USER}@{MASTER_IP} {ARGS}

[global]
cluster_template = default
update_check = true
sanity_check = true

[cluster default]
key_name = mykey
base_os = ubuntu1804
scheduler = slurm
master_instance_type = t3.large
vpc_settings = default
queue_settings = compute

[vpc default]
vpc_id = vpc-XXXXX
master_subnet_id = subnet-XXXXX
compute_subnet_id = subnet-XXXXX
use_public_ips = false

[queue compute]
enable_efa = false
compute_resource_settings = default

[compute_resource default]
instance_type = g4dn.xlarge
max_count = 2

Bug description and how to reproduce:
The cluster seems to create successfully with "pcluster create". However, if I then log into the master node and create some dummy jobs with
sbatch <<EOJOB
#!/bin/bash
echo Hello
EOJOB

it just sits there. /var/log/slurmctld.log prints a slow stream of
[2020-09-28T14:32:15.884] Requeuing JobId=2
[2020-09-28T14:32:15.884] update_node: node compute-dy-g4dnxlarge-1 state set to DOWN
[2020-09-28T14:32:15.900] error: Unable to resolve "compute-dy-g4dnxlarge-1": Unknown host
[2020-09-28T14:32:15.900] error: fwd_tree_thread: can't find address for host compute-dy-g4dnxlarge-1, check slurm.conf
[2020-09-28T14:32:28.805] update_node: node compute-dy-g4dnxlarge-1 reason set to: Scheduler health check failed
[2020-09-28T14:32:28.805] update_node: node compute-dy-g4dnxlarge-1 state set to DOWN
[2020-09-28T14:32:28.824] update_node: node compute-dy-g4dnxlarge-1 reason set to: Scheduler health check failed
[2020-09-28T14:32:28.824] powering down node compute-dy-g4dnxlarge-1
[2020-09-28T14:35:13.948] sched: Allocate JobId=2 NodeList=compute-dy-g4dnxlarge-1 #CPUs=1 Partition=compute
[2020-09-28T14:35:16.115] update_node: node compute-dy-g4dnxlarge-1 reason set to: Failure when resuming nodes
[2020-09-28T14:35:16.115] requeue job JobId=2 due to failure of node compute-dy-g4dnxlarge-1
[2020-09-28T14:35:16.115] Requeuing JobId=2

and nothing happens. The bit about 'Unable to resolve "compute-dy-g4dnxlarge-1": Unknown host' might indicate that there's some sort of Route 53 problem?
There no longer seems to be a  /var/log/jobwatcher or /var/log/sqswatcher log file, so I'm not sure what process is supposed to be doing the autoscaling in 2.9.x and where it writes its logs.

Hi @mark-cresset
Can you check for errors in /var/log/parallelcluster, specifically in slurm_resume and clustermgtd log files? The reason why the cluster could not scale should be pretty clear from slurm_resume log file.
As you could notice with the new version and support for multiple queues and multiple instance types the scaling components have been totally redesigned and the old log files are not there anymore. We are working on fully align the docs to reflect the latest changes.
Francesco

Thanks Francesco!
I was going to start the cluster up again and check those logs (having deleted it when it failed to work), but I now can't get a cluster to start:
pcluster start skbp2 --config parallelcluster/config
ERROR: Could not retrieve CloudFormation stack data. Failed with error: Stack with id parallelcluster-skbp2 does not exist
Any ideas what's going wrong?

Did you stop the cluster with a pcluster stop or you deleted it with a pcluster delete. I believe you deleted it which means you need to recreate it now with a pcluster create and not a pcluster start

Ah, I'm being dumb :). Thanks!

OK, thanks, the slurm_resume log file has the answer: we'd hit a limit on the number of GPU instances, which is why it couldn't scale up. Thanks very much for the support.


⚠ ClamAV has degraded performance

In e9113b2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 64 ms

Resolved: ClamAV performance has improved in e7c14c9.


read api_base from env variable

Add read_config function to read api_base environment when startup.

-- Please reply above this line --
Dear Nasdaq/data-Link-Python,
Thank you for contacting the Nasdaq Data Client Success Team. Your
email is very important to us and we will respond to you within 1 to 2
business days.
To efficiently support your request, please include relevant details
such as the data product/feed you are inquiring about.
Kind regards,
Nasdaq Data Client Success
[1]
Links:
[1] https://www.nasdaq.com/


fix: changed the exit code for info flag

Type:
bugfix
The following has been addressed in the PR:

There is a related issue? NA
Unit or Functional tests are included in the PR NA

Description:
The process.exit code is 1 for the --info flag so it will give a nodejs error format at the end instead of silently exiting.
Changed it to 0

In my opinion 1 is correct as we catch an error, log it and output some info about it. This is not the part where the command succeeds.

Extremely sorry , I made the wrong changes, Just committing  the correct one


Merge in Initial cleanup template

Merge to bring in a lot of new features and refactoring

@jotrick,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


🐛 [backplane-2.6] Prevent deletion of cluster namespace when hostingcluster exists

Fix conflict https://github.com/stolostron/managedcluster-import-controller/pull/406#issuecomment-2456115198
cherrypick https://github.com/stolostron/managedcluster-import-controller/pull/406
issue: https://issues.redhat.com/browse/ACM-15058

/retest

/retest

/test unit

/test e2e

/lgtm


uninstall

BRO HOW DO I GET RID OF IT I DONT WANT IT NO MORE

Just run roblox studio's regular launcher and that'll overwrite it.


this.registry.encode is not a function

TypeError: this.registry.encode is not a function
at SigningStargateClient.signDirect (/Users/suanjie/Documents/Projects/NodeJS/Cosmos/atom_cosmjs/node_modules/@cosmjs_stargate@0.28.13@@cosmjs/stargate/build/signingstargateclient.js:242:43)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async SigningStargateClient.signAndBroadcast (/Users/suanjie/Documents/Projects/NodeJS/Cosmos/atom_cosmjs/node_modules/@cosmjs_stargate@0.28.13@@cosmjs/stargate/build/signingstargateclient.js:167:23)

What did you try to do there? Did you create an instance of SigningStargateClient?

TypeError: this.registry.encode is not a function
at SigningStargateClient.signDirect (/Users/suanjie/Documents/Projects/NodeJS/Cosmos/atom_cosmjs/node_modules/_@cosmjs_stargate@0.28.13@@cosmjs/stargate/build/signingstargateclient.js:242:43)

at processTicksAndRejections (node:internal/process/task_queues:96:5)

at async SigningStargateClient.signAndBroadcast (/Users/suanjie/Documents/Projects/NodeJS/Cosmos/atom_cosmjs/node_modules/_@cosmjs_stargate@0.28.13@@cosmjs/stargate/build/signingstargateclient.js:167:23)

Hi @sajshuai visit the official cosmos page to start a chat with a live agent to report this for review and for further assistance via LIVE CHAT


Kyvol E30 vacuum not avalible since last update

hi,
i cannot connect to my vaccum since the last update form the integration. I tried to configure the vacuum new but it does not run and it cannot find the vacuum (the protocol is on auto, or all version from 1-4). After testing some things, e remembered that i deleted the vaccuum in the cloud....and that was the reason..... After I added the vacuum again and changed the uuid and the local key.... everything is running fine.
but why can't I delete the device in the cloud.? I thought that Tuya local is a cloudfree soloution.
what do you think ?

I cannot influence or explain how Tuya devices interact with the cloud.
I have made no claims that it is possible to remove your devices from the Tuya cloud by using this integration, in fact I have explicitly stated that using this device does not stop your devices from reporting to the cloud.  If you don't want devices that report to the cloud, then Tuya devices are not really a viable solution.


Fix transaction.create() not using keys when given as arguments

Current coverage is 100% (diff: 100%)

Merging #50 into master will not change coverage

@@           master   #50   diff @@
===================================
  Files           7     7
  Lines         105   105
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits          105   105
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update e5c95d3...e9992a8


Create a 0.0.13 release (php 7.3 compat)

The previous release was on June 11th.

https://github.com/Microsoft/tolerant-php-parser/pull/250 fixes a notice in PHP 7.3, which may affect language servers using this. Currently, PHP 7.3 is in the second beta.
There are other minor changes

Done


Error: Cannot find module 'connect-history-api-fallback'

npm-debug.log.txt
Just thought I'd give it a whirl. Received this message:
kb:/web/js/formidable-react-starter
$ npm run dev

><EMAIL_ADDRESS>dev /web/js/formidable-react-starter
> node server/development.js

module.js:442
    throw err;
    ^

Error: Cannot find module 'connect-history-api-fallback'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/web/js/formidable-react-starter/server/development.js:3:26)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node/6.3.1/bin/node" "/usr/local/bin/npm" "run" "dev"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dev: `node server/development.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script 'node server/development.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the formidable-react-app-starter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node server/development.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs formidable-react-app-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls formidable-react-app-starter
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! Please include the following file with any support request:
npm ERR!     /web/js/formidable-react-starter/npm-debug.log
 on master

I'll check it out


Improve manager code coverage

Add Manager close and Allocation timeout unit test.

Codecov Report

Merging #58 into master will increase coverage by 5.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   18.51%   23.55%   +5.03%
==========================================
  Files          16       16
  Lines         675      675
==========================================
+ Hits          125      159      +34
+ Misses        526      490      -36
- Partials       24       26       +2

Impacted Files
Coverage Δ

internal/allocation/allocation_manager.go
76.27% <0%> (+25.42%)
:arrow_up:

internal/allocation/allocation.go
49.09% <0%> (+13.63%)
:arrow_up:

internal/ipnet/ipv4.go
53.57% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21ddc2...a0da01d. Read the comment docs.

@songjiayang #52 has been merged! Hope the conflict wouldn't be too bad for you. We can not live without your tests and love for turn! :) - if you need help, let me know!


feat: add KMS key

Description
This PR introduces as KMS key to encrypt all resources. Use kms_key_id. It is an optional parameter. If not set the standard key from AWS is used.
Verification
None.
Checklist

[x] My code follows the style guidelines of the project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have used pre-commit hook to update the Terraform documentation

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Speed up fermionic mappers by means of an intermediate conversion to majorana operators

What should we add?
From personal experience, the Qubit mapper is super slow. In my research, I found a way to speed things up for Majorana-string mappings eg: Jordan-Wigner, Bravyi-Kitaev, Ternary-tree, and Parity (see the Bonsai algorithm for more details). Some small background on the solution. Fermionic systems can be represented in the Majorana basis as:
\begin{split}
    \mathcal{H}_f &= \sum_{ij}^{N-1} h_{ij} a_i^{\dagger} {a_j} + \sum_{ijkl}^{N-1} h_{ijkl} a_i^{\dagger} a_j^{\dagger} {a_k} {a_l} \\
    &=\sum_{ij}^{2N-1}\mathrm{i} c_{ij} {m_i} {m_j} + \sum_{ijkl}^{2N-1} c_{ijkl} \, {m_i} {m_j} {m_k} {m_l}.
\end{split}

where $h_{ij}, h_{ijkl}, c_{ij}$ and $c_{ijkl}$ are real coefficients. The 2N-Majorana operators are given in terms of linear combinations of the ladder operators:
\begin{gather}
    m_{2 j} \coloneqq a_{j}^\dagger + a_{j},\\ m_{2 j+1} \coloneqq  \mathrm{i} (a_{j}^\dagger - a_{j}).
\end{gather}

The solution is as follows:

Map the Fermionic Hamiltonian to a Majoranic Hamiltonian
For each term in the FermionicOp, one should cache the result somehow of coefficients of the Majoranas resulting from ['+', '+', '-', '-'], ['+', '-', '+', '-'], ['+', '-'], ... etc. The Majoranaic Hamiltonian should then be sorted so that terms add like:

    \{(0,1,2,3):1, (0,3,1,2):2\} \equiv \{(0,1,2,3):3\}

where  $(0,1,2,3) \equiv m_0m_1m_2m_3$ and we use a dictionary as ${\text{majornana operator:coeff}}$. One must account for the anticommutation relations ${m_i,m_j}=\delta_{ij}$ here so
    \{(0,1,2,3):1, (0,1,3,2):2\} \equiv \{(0,1,2,3):0\}

Map the Majoranic Hamiltonian to qubits.
Mapper objects in qiskit like JordanWignerMapper use a PauliTable object to map mode operators to qubits. The object is structured: $[(P_0,P_1), (P_2,P_3), \ldots, (P_{2N-2},P_{2N-1})]$ where the Pauli strings are associated to Majorana operators as $P_i \ leftrightarrow m_i$. Thus one can map each term in the Majoranic Hamiltonian, resulting in a product of 2- or 4-Pauli strings which can be efficiently computed.

I include a graph of the speed comparison. I can also provide code if requested.

Adding a bit of historical context:
Performance of the mappers being sub-par is a known problem. See also #771 and #1289 for related discussions. There is also #1301.
The Bonsai mapper was also discussed before and is briefly referred to by #1289. #1270 is adding a MajoranaOp which will hopefully make an implementation of this mapper fairly straight forward.
That makes this issue/feature request a bit of a duplicate unless you want to rephrase it to explicitly ask for an implementation of the Bonsai mapping algorithm.

Thank you for your response. I have gone through the linked discussions but did not find any discussion related to the proposal I am making. I am not suggesting the implementation of the Bonsai mapper. Rather, I am proposing a speed-up that can be achieved after introducing MajoranaOp in #1270.
My request is for the implementation of QubitMapper that uses a MajoranaModeBasedMapper mapping method instead of the ModeBasedMapper. This will enable efficient mapping of Fermionic operators to qubits through intermediate Majorana operators. The reason for this is that it is much quicker to map the FermionicOp-->MajoranicOp-->SparsePauliOp than to map FermionicOp-->SparsePauliOp.
I have observed a significant speedup with my unoptimized python code, which is not parallelized, but could be (for a 28-qubit chemical Hamiltonian with 220288 terms, qiskit takes ~68s while my method takes ~7s)

Ah thanks for the clarification! That is indeed an interesting proposal :+1:

@diagonal-hamiltonian Do you have a good idea, why the way via Majorana operators is faster? I am wondering if it is due to the integer tuple implementation being more efficient than the string based SparseLabelOp operators. The MajoranaOp I have implemented is also a SparseLabelOp for compatibility reasons, i.e. it uses string labels instead of tuples of int.

@grossardt To be honest, I was quite surprised just how much faster this is as I am not entirely sure why. Initially, I thought the speed-up was from circumventing the Pauli multiplication in SparsePauliOp and reusing the cached coefficients resulting from the fermionic label ['+', '+', '-', '-'], ['+', '-', '+', '-'], ['+', '-'],... products. However, it could likely be from the integer tuple implementation being more efficient than the string based SparseLabelOp operators.

Hello, can you share your work, code? How did you get the speed up?


Filtering on child field using substring

Hello,
When I execute the following SQL which filters documents on a parent field, the query seems to get the correct result.
select $ from Patients WHERE substring($.nameFirst,0,1) ALL = 'd'
However, when I use the following SQL on a child field using substring I do not get any result.
select $ from Patients WHERE substring($.Tumors[*].dateOfDiagnosis,0,4) ALL = '2018'
What am I doing wrong?

@sanjeevbaral substring can only be used with scalar expressions (expressions that evaluate to a single value), and $.Tumors[*].dateOfDiagnosis is an enumerable expression (it evaluates to all the dates of diagnosis).
You could use select $ from Patients WHERE $.Tumors[*].dateOfDiagnosis ALL like '2018%'.

Thanks!


feat(ui/space): var-space component complete

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #176 (6489526) into feat/space (a244364) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           feat/space     #176      +/-   ##
==============================================
- Coverage       96.43%   95.82%   -0.62%
==============================================
  Files             206      209       +3
  Lines            4659     4689      +30
  Branches          969      983      +14
==============================================
  Hits             4493     4493
- Misses            164      194      +30
  Partials            2        2

Impacted Files
Coverage Δ

packages/varlet-ui/src/space/Space.tsx
0.00% <0.00%> (ø)

packages/varlet-ui/src/space/index.ts
0.00% <0.00%> (ø)

packages/varlet-ui/src/space/props.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a244364...6489526. Read the comment docs.

pr我先合了，后续的更新优化继续发refactor到feat/space这个分支下，参与讨论可以在这个pr下面。


Devise rails session ID and first redirection

It turns out that getting the session ID (with session[:session_id]) after login with Devise (authentication gem) (either in session_controller or in after_sign_in_path_for) does not return the same thing before and after redirecting for the first time, after logging-in.
Is anyone able to explain me why ? Is there any way to get the final session ID before redirecting ?

Is anyone can explain me why ?
I'll try. In short:

Devise has nothing to do with it
Warden has something to do with it -  it's setting :renew option on session, after setting user (proxy, spec)
Actual action takes place in in Rake::Session::Abstract[#commit_session](https://github.com/rack/rack/blob/master/lib/rack/session/abstract/id.rb#L332) which updates session_id (by calling destroy_session and set_session implementented in ActionDispatch::Session::CookieStore)

Is there any way to get the final session ID before redirecting ?
Sure it is. Bear in mind that Warden is changing session_id after authentication to prevent session fixation attacks, so in overriden devise controller you should manually change session_id in addition to disabling :renew session option. This will do:

session.options[:id] = session.instance_variable_get(:@by).generate_sid
session.options[:renew] = false

How can we get the new session id after authentication? session.options[:id] shows the old value


Prompt input field is white on white. Android , Brave Browser

After the latest update your live preview site looks great, but the input text is white on white.

Thanks nessy! Can you share a screenshot so I'm sure I can reproduce what you're seeing?

Same as shown in screenshot on Arc Browser Mac desktop, with all updated to latest versions.

Thanks, I wasn't using darkmode by default.  Just fixed and pushed the fix to main!


[ALLUXIO-1836] Worker creates tiered storage files

https://alluxio.atlassian.net/browse/ALLUXIO-1836

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9017/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9018/
Test PASSed.

+1 LGTM

LGTM


Update the game over message

Update the game over message so people know how to play again!

bbkj


Issue#2347

Created as a draft since I need to hande env of cargo_extra_flags. Would love some ci :) hehe

it seems my rebase did sth really wrong..

Usually this happens because you rebased over a stale fetch of upstream's master branch, or you tried to rebase a merge commit. Rebasing a merge commit doesn't make a lot of sense conceptually and git doesn't offer help untangling your request when you try to. You should always rebase up branches with git pull --rebase https://github.com/rust-lang/miri or swap in the ssh URL if you want.
The for-sure way out of this is to interactive rebase over an up-to-date fetch and change all but the top pick to f. That will combine all the commits together, which is what you want anyway.

Please also update the issue title and description to explain what the PR does. :)
It's okay to mention the issue in the PR description, but the PR title should be self-explaining.

Will do!

@saethlin i'm not sure how to reconcile this, i'll close this PR and cherry pick relevant commits to a new PR

The for-sure way out of this is to interactive rebase over an up-to-date fetch and change all but the top pick to f. That will combine all the commits together, which is what you want anyway.

The ultimate way to dig out of a confused rebase is this ^
Whatever cherry-pick workflow you're doing could be done to this PR's' branch too. You'd build a new branch in the state you want then hard-reset this PR's branch to that new branch, and force-push to the PR. GitHub prevents you from reopening a PR if you force-push to it while it's closed though, so you probably don't want to try that.

I tried to rebase (I git pull upstream master in this branch first) but the rebase list option is riddle with commits thats not mine in between, so i'm not sure how to change all f to p except the first one); example is below
pick 56fbbcbf1 detect when pthread_rwlock_t is moved
pick a67607b9e sync methods: pass around places, not pointer-typed operands
pick 59f68710a sync: store extra sync primitive data in a Box<dyn Any> so the type can be kept local
pick 5984313b2 Fetch miri flags from cargo config (relevant commit)
pick f67d10d0c Add tests for fetching flags from from cargo config (relevant commit)
pick 7020cd2ef Add info on setting miriflags in cargo config (relevant commit)
pick 7bebd05cf empty commit to go through bors # empty
pick 65444952b tests/run-make: update to use fs_wrapper # empty
pick 821d97909 Move get_miri_flags to util.rs (mine)
pick a77abd343 Update pseudo-flag and better comments (mine)
pick 08a6d3f1b Fix build warnings of unused (mine)

# Rebase e4cf56ad1..08a6d3f1b onto e4cf56ad1 (11 commands)
#
# Commands:
# p, pick <commit> = use commit
# r, reword <commit> = use commit, but edit the commit message
# e, edit <commit> = use commit, but stop for amending
# s, squash <commit> = use commit, but meld into previous commit
# f, fixup [-C | -c] <commit> = like "squash" but keep only the previous
#                    commit's log message, unless -C is used, in which case
#                    keep only this commit's message; -c is same as -C but
#                    opens the editor
# x, exec <command> = run command (the rest of the line) using shell
# b, break = stop here (continue rebase later with 'git rebase --continue')
# d, drop <commit> = remove commit
# l, label <label> = label current HEAD with a name
# t, reset <label> = reset HEAD to a label
# m, merge [-C <commit> | -c <commit>] <label> [# <oneline>]
#         create a merge commit using the original merge commit's
#         message (or the oneline, if no original merge commit was
#         specified); use -c <commit> to reword the commit message
# u, update-ref <ref> = track a placeholder for the <ref> to be updated
#                       to this position in the new commits. The <ref> is
#                       updated at the end of the rebase
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#

I think the cherry pick option is better for now but it'd be nice to get some help on this.  I only git pull --rebase because I prefer my spaghetti in a bowl.

but the rebase list option is riddle with commits thats not mine in between

Ah sorry. You'll want to reword the commit message on the resultant commit, you can do this by setting the top pick up reword or r or by doing a git commit --amend after the rebase.
I don't know if I'm being helpful, but truly the only way I know out of a scuffed rebase is to rebase more. If you're not comfortable trying N different rebases to see what happens, you'll have trouble getting unstuck from some situations. Maybe that's fine, but I'm a rebase lover.

 I only git pull --rebase because I prefer my spaghetti in a bowl.

but the rebase list option is riddle with commits thats not mine in between

Ah sorry. You'll want to reword the commit message on the resultant commit, you can do this by setting the top pick up reword or r or by doing a git commit --amend after the rebase.
I don't know if I'm being helpful, but truly the only way I know out of a scuffed rebase is to rebase more. If you're not comfortable trying N different rebases to see what happens, you'll have trouble getting unstuck from some situations. Maybe that's fine, but I'm a rebase lover.

i still keep this broken branch on my forkk so i'll keep on rebasing :) tysm


what is this

What is this code for? You are assigning browser "Chrome" and then you are switching over it. What does the TestCategory("Chrome") useful for.
As well, it seems all tests are running in parallel by default. What can I do to disable this nice un-needed feature (at least in my case).
[TestInitialize()]
public void SetupTest()
{
  appURL = "http://www.bing.com/";

  string browser = "Chrome";
  switch(browser)
  {
    case "Chrome":
      driver = new ChromeDriver();
      break;
    case "Firefox":
      driver = new FirefoxDriver();
      break;
    case "IE":
      driver = new InternetExplorerDriver();
      break;
    default:
      driver = new ChromeDriver();
      break;
  }

}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09e51d18-72ec-1ad4-9ae7-8185c8e1dcd6
Version Independent ID: 9f2f0471-d123-8e95-1606-cd811d1ece9a
Content: Perform UI tests with Selenium - Azure Pipelines
Content Source: docs/pipelines/test/continuous-test-selenium.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

Is's selecting the driver based on your browser, so the chrome browser will use a ChromeDriver, an IE browser would use an InternetExplorerDriver.
This lets you test your app on several browsers


[iscsi-targetd] Create ansible roles

This PR is about refactoring the ansible playbooks so make the playbook more modular and reusable via roles. It should now be much easier to integrate these playbooks with larger plays.
This PR also improve the documentation around the ansible playbooks, documenting all the variables.

/cc @wongma7 this PR does not touch the code, please merge when you can.

/lgtm
/area iscsi/targetd


ARM version for Linux and Mac?

ARM support for Linux and Mac?
 I would have to WORK to be a "script kitty".
But I am running Raspberry Pi OS, 64 bit, and a native build would be nice.

Platform

Linux [X]

Hello
This would be possible using nwjs builds from https://github.com/LeonardLaszlo/nw.js-armv7-binaries.
Dont know if these are fully features and work correctly on the Raspberry PI  i have to test them.
Another solution to run nunuStudio on the pi is to use the web version it is pretty much the same as the desktop one and should work without any problem.
Thanks a lot!
Cheers


Frontend translations

How do we deal with translations on the frontend? This affects react-invenio-deposit as well.
How does ILS / react-searchkit do it?

We should be able to attack this point next week in the Invenio Sprint, I will involve you for sure in the discussion!


docs: Add Base Node Troubleshooting Guide for Operators

This PR adds a comprehensive troubleshooting guide for Base node operators to help them diagnose and resolve common issues more efficiently. The guide is added in response to issue #1210.
Changes include:

Created new troubleshooting directory in docs
Added detailed node-operator-troubleshooting.md guide
Updated sidebars.js to include the new guide in navigation

The guide covers:

Common synchronization issues
Performance optimization
Network connectivity problems
Consensus troubleshooting
Diagnostic tools and monitoring
Preventive maintenance

Notes to reviewers
Key areas to review:

Technical accuracy of troubleshooting steps
Completeness of common issues coverage
Integration with existing documentation structure
Clarity and accessibility of instructions
Proper sidebar navigation integration

The guide is written to be easily expandable for future updates based on community feedback.
How has it been tested?

Verified markdown formatting and links
Tested navigation through sidebar integration
Confirmed all code snippets follow proper formatting
Checked documentation build locally
Ensured all internal references are working

Closes #1210

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


[FSDE-8911] Add header component to vue documentation

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/1/. :white_check_mark:

You can check this PRs instance in https://1104c5f93f1e8b5737406204a06eeaae0da84427-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/2/. :white_check_mark:

You can check this PRs instance in https://c571b66187e39f202173fc48d8156a7269858de6-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/3/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/4/. :white_check_mark:

You can check this PRs instance in https://04f15f1d2041497b8c71fbd1793e87507506f6b9-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/5/. :white_check_mark:

You can check this PRs instance in https://c0df6a10ba164868d41d30fd2dc293c1cc571231-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/6/. :white_check_mark:

You can check this PRs instance in https://a645963dd0a8c11296dae67944adcca9efd4247e-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/7/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/8/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/9/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/10/. :white_check_mark:

You can check this PRs instance in https://df720aa09619334aeff1c5c7060ed6ca7b14f2f1-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/11/. :white_check_mark:

You can check this PRs instance in https://e8124127471d70cf56b0143abf555bf5afbe5a58-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

This PR seems to be stalled. @soujanreddy , please resolve conflicts, review the Jira Card associated to it (FSDE-6408 seems to be an Epic, instead of a User Story or a Bug Jira Card) and update it in the PR title if necessary).

@jllr FYI ☝

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/13/. :white_check_mark:

You can check this PRs instance in https://be9036b717118179e12b757affc6980808ea7ae7-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/14/. :white_check_mark:

You can check this PRs instance in https://86ea39b76646df05930dc495694c9ebe6b647236-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/15/. :white_check_mark:

You can check this PRs instance in https://d1d69b6a4b1e0a893eeda32fb7f0875cfab0b53b-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/16/. :white_check_mark:

You can check this PRs instance in https://da5c3a2997292b6853930fb795c2b19a94051c24-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/17/. :white_check_mark:

You can check this PRs instance in https://36bfcf49a7cd2bdb0eb398dd7c43bb67ece7f2c3-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/18/. :white_check_mark:

You can check this PRs instance in https://7b00d5046d8a6cffeb2509d0bef991e57cea250a-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/19/. :white_check_mark:

You can check this PRs instance in https://515ea45bc81c52bd3a26a821c540b4efb5678af7-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/20/. :white_check_mark:

You can check this PRs instance in https://5c415b87a20ddaa5b4be24f4c5453a93b61f7096-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/21/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/23/. :white_check_mark:

You can check this PRs instance in https://6d6fdf1751e83b7df2ed7f4d96c3c5f2070b5cc5-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

You can check this PRs instance in https://21c65dbdbbee49708c8556ea5ea0fafb690d7f2f-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/26/. :white_check_mark:

You can check this PRs instance in https://15421e1b9c961dda7a55afdb6d475b279273922f-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/27/. :white_check_mark:

You can check this PRs instance in https://30907352f69c80230ec9b84e8f4d5d6a831bd0d9-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/28/. :white_check_mark:

You can check this PRs instance in https://59491812f26c5fbd90360a65302d4335cc0d1183-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/29/. :white_check_mark:

You can check this PRs instance in https://e769fc9f4bb4f7f3f86a0df9b251f56321a426dd-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/30/. :white_check_mark:

You can check this PRs instance in https://cec62acc828f17991aff063db3bc3402a016d3de-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-223/31/. :white_check_mark:

You can check this PRs instance in https://b1842f54ed38a0c605e557fbb182be5116a96da6-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-223-ux-chi.kubeodc-test.corp.intranet/ (internal)


Fixing if expression for azure mfa in import extension

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 41.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
26385

Relevant Lines:
57391

💛  - Coveralls


Tag code with tag 1.5 or correspondent

In docker hub need to build a new version of with tag 1.5-72 or 1.4-72 to be used in laradock laradock repository

@gueroverde thanks for notifying me about this. I just created the tag 2.0 for this repo on Github, and I built and triggered builds (2.0-xx) on hub.docker.com now just waiting the queues to get executed, I will update the tags in the Laradock dockerfiles as soon as the builds finishes execution.

@gueroverde I assume you gonna write support for php 7.2 in the laradock repository, and I also assume the support is gonna be in the form of adding a new Dockerfile with thename php-fpm/Dockerfile-72. If that's your plan. Could you please take this approach into consideration.
Instead of a new docker file for each PHP version we can now write a single dockerfile, and add some if-else statements wherever the installation differ between php versions for each tool.
The only reason why I didn't implement that approach in the past is because of the image tag. There was no way to insert it dynamically, however the newer versions of Docker compose does support this  so instead of doing this FROM laradock/php-fpm:1.4-72  we can have something like this FROM laradock/php-fpm:${PHP_VERSION}. Which allows us to define the PHP version in the docker compose file and based on that version w'll execute specific parts of the dockerfile via the if-else statements.
This will have huge benefits for the maintenance fo the files and it helps keeping them consistent.
Kindly let me know what do you think? Best,

i agree with you, Your assumptions are correct, I wanted to do that, but i prefer the way you  propose. and
I'm going to work in favor of it, thank you.
Are you already working on it?
How I can help?
Best regard.

@gueroverde Not really, I'm quiet busy at the moment with private projects, I would love if you can handle this. Best,