GPU Memory Cache not cleared.

I've been running it by installing on machine and running make commands. The model responses are lightning fast compared to transformers pipeline() method. But after few invocations using generate_stream, I observed that memory is full occupied and throwing CUDA OOM.
Model: OpenAssistant/oasst-sft-4-pythia-12b-epoch-3.5
Quantized: yes
GPU: A10G 24GB
OS: EC2 linux
Appreciate some solution or workaround.
Another issue I encountered is that, the input token length limit set to 1000 by default. So if I give some long text as input (some context and a question), getting error
inputs must have less than 1000 tokens. Given: 1013.
I've modified router rust files code to mitigate this validation as a workaround.

But after few invocations using generate_stream, I observed that memory is full occupied and throwing CUDA OOM.

The GPU memory cache is cleared. You might oom because the tensor sizes are dynamic. The batch size, prompt length, decode length can all increase and therefore the memory consumption is not the same for every request.

Another issue I encountered is that, the input token length limit set to 1000 by default

You can use --max-input-length and --max-total-tokens to control the prompt and decode max length. You can also send the truncate parameter to automatically truncate to a fixed length.

Thanks @OlivierDehaene for very quick reply. Much appreciated.

You can use --max-input-length and --max-total-tokens
I'll revert the code and try these parameters

You might oom because the tensor sizes are dynamic. The batch size, prompt length, decode length can all increase and therefore the memory consumption is not the same for every request.
I've been running with pipeline() and face similar issue. So I manually added torch.cuda.empty_cache() and saw memory usage come down after every completion. I thought it is similar issue here.

However after I restart the server and tried same long input multiple times, and the server generated the response without going into OOM. I'll further look into it. This is happening only after few generate requests (like after 100 generate_stream requests).

I think I found a pattern @OlivierDehaene .
If I stop receiving two requests consecutively from generate_stream (the input is long and could generate long output as well), then the subsequent requests are not processing at all and throwing CUDA OOM.

If I stop receiving two requests consecutively from generate_stream (the input is long and could generate long output as well), then the subsequent requests are not processing at all and throwing CUDA OOM.

Yes the requests you stop (by dropping the connection to the server) are not really stopped: they continue processing in the backend (see https://github.com/huggingface/text-generation-inference/pull/202 that will fix this issue). Then when you send new requests, they get added to the batch of currently processing requests (that were dropped but not stopped). It is possible that you don't have enough VRAM to handle this new increased batch size.
You can control the maximum size of the batch size using the --max-batch-size parameter. Setting it to 1 disables the dynamic batching mechanism entirely.


Factor Boosts Increase Without Boosting

This makes getting Sluggish Milestones impossible.
Reproduction Steps
Start new Collapse from attached save.
When the value for boost 20 is reached, regardless of what boost the player is currently on, Factor Boost counter begins to increment from 20. All normal benefits/side effects of the boost counter incrementing occur. Total points for upgrades increase, the target value for the next boost increases. The incrementing continues to occur until a challenge is entered/exited.
ordinalsave.txt

It appears this issue only occurs when autoboost is enabled. Perhaps autoboost is functioning normally but incorrectly evaluating whether a sluggish milestone is possible/how quickly the player can boost?

this is already fixed in released version
you can close this


Warned against using goto

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@KartikSoneji Thank you for  creating this PR.  However, since it was created, the underlying document has changed.  Can you please review and resolve the current merge conflicts?  It could be the changes to the underlying document are so significant that your changes are no longer relevant.  If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.
If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.
Thank you.

Opened new Pull Request: https://github.com/freeCodeCamp/freeCodeCamp/pull/36329


Make compatible with wxPython 3.0

This PR adds compatibility code for running PythonTurtle on Ubuntu 16.04.1 Xenial with python-wxgtk3.0 and Python 2.7.12.
References

wxPython API docs
(partly) related SO question

Awesome! Can you explicitly confirm that you agree to have your code licensed under the MIT license? Feel free to create an AUTHORS file with our names and add it to the PR.

Sure, I agree to my code being licensed under MIT.
Please make sure the application still runs for you. I have not tested the changes under Windows and older versions of Ubuntu.

Ah sorry, I don't want to spend the time testing that. I'm not so
interested in PythonTurtle. If you're moderately sure that it won't break
Windows then that's good enough for me. Let me know.
On Sat, Dec 17, 2016 at 9:51 PM, Peter Bittner<EMAIL_ADDRESS>wrote:

Sure, I agree to my code being licensed under MIT.
Please make sure the application still runs for you. I have not tested the
changes under Windows and older versions of Ubuntu.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cool-RR/PythonTurtle/pull/94#issuecomment-267783127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADdypSAevCH4F-Zu-DhWeS9jdcqY4hcks5rJD0mgaJpZM4LP7yd
.

I'm moderately sure the changes will retain the current behavior, hence not affect Windows. But you never know until you prove it.
Will you package a new version for download from the website?

I accepted the MR, but I won't create a package, sorry. I don't want to spend time doing that. (I've written PythonTurtle like 7 years ago and have little interest in it now.) If you create a package I'll be happy to post it on the website. If this project is to continue, what's really needed is to automate the process of creating installers for Windows and Mac, so if you or anyone else wishes to contribute, that'll be the best area to do so.


Fix the correctness of offsets

The versions of the google.golang.org/grpc/internal/transport package below v1.14.0 do not exist, but they are reported in our offsets.
It also seems like merging #503 has unexpectedly filled in gaps.
The correctness of the offsets need to be addressed.
Originally posted by @MrAlias in https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/503#discussion_r1394463028

Following up here instead of the merged PR - guessing at an offset could be a security risk too. If for example, reading data from a HTTP headers, you could accidentally collect unintended data.


Upgrade GitHub Actions runner to at least 2.300.0 by 2023-01-12

https://github.com/actions/runner/releases/tag/v2.300.0
New release is out, which means we have 30 days to upgrade
Same deal as https://github.com/iree-org/iree/issues/10546

Update was canaried, but rolled back. I turned off the change I think may be responsible for the issue in #11783 and will do another canary now

All production runners are now running 2.300.2


can't build cpr - "Could NOT find CURL (missing: HTTP) (found version "7.80.0")"

I followed the instructions to install cpr.
when I run cmake .. -DCPR_USE_SYSTEM_CURL=ON I get this error:
-- Could NOT find CURL (missing: HTTP) (found version "7.80.0")
-- Could NOT find CURL (missing: HTTP) (found version "7.80.0")
CMake Error at CMakeLists.txt:193 (message):
  Curl not found on this system.  To use the built-in version set
  CPR_USE_SYSTEM_CURL to OFF.

How to Reproduce
$ git clone https://github.com/libcpr/cpr.git
$ cd cpr && mkdir build && cd build
$ cmake .. -DCPR_USE_SYSTEM_CURL=ON
``
OS:

Distributor ID: Ubuntu
Description: Ubuntu 20.04.4 LTS
Release: 20.04
Codename: focal

This is an issue of cpr according to the reproduction steps.


RadioButton example v2

Second try to contribute a Radio Button example.
This example was an answer to a users question on gitter.

@GuillaumeGomez, IMHO this better not be merged until we decide what to do with https://github.com/gtk-rs/gtk/issues/488

@zzeroo Thanks.
Instead recreating PR you can edit PR title and change target branch.

I agree. Quite problematic.

Closing due to inactivity. Don't hesitate to reopen once updated. :)


a endless loop may happens when uart_stm32_fifo_read_visitor .

the type of uint8_t for num_tx may overflow while size can be over 256, if the freq of cpu is relative low and uart baudrate is high, it may be stuck.
Describe the bug

in zephyr/drivers/serial/uart_stm32.c, one of the function uart_stm32_fifo_read_visitor is:
static int uart_stm32_fifo_read_visitor(const struct device *dev, void *rx_data, const int size,
					fifo_read_fn read_fn)
{
	const struct uart_stm32_config *config = dev->config;
	USART_TypeDef *usart = config->usart;
	uint8_t num_rx = 0U;

	while ((size - num_rx > 0) && LL_USART_IsActiveFlag_RXNE(usart)) {
		/* RXNE flag will be cleared upon read from DR|RDR register */

		read_fn(usart, rx_data, num_rx);
		num_rx++;

		/* Clear overrun error flag */
		if (LL_USART_IsActiveFlag_ORE(usart)) {
			LL_USART_ClearFlag_ORE(usart);
			/*
			 * On stm32 F4X, F1X, and F2X, the RXNE flag is affected (cleared) by
			 * the uart_err_check function call (on errors flags clearing)
			 */
		}
	}

	return num_rx;
}

To Reproduce

just use the uart_stm32.
Expected behavior

the dead loop may happens in uart_stm32_fifo_read_visitor.
Impact

dead loop.
Environment (please complete the following information):

OS: Linux
Toolchain: arm-gcc-none-eabi

why the type of  num_rx is uint8_t rather than int (as the return value is int)?


Add a connect 4 game as extension

Connect 4 is a classic two-player connection game in which players take turns dropping colored discs from the top into a vertically suspended grid. The objective of the game is to be the first to form a horizontal, vertical, or diagonal line of four of one's own discs.
Features
Two-Player Mode: Players can take turns to play against each other on the same device.
Score Tracking: Keeps track of wins, losses, and draws for each player.

Already added to this repository #589 #1061. Closing it


wrong step into/over icon color

dap-ui is really good to use, but when I used it recently, I found that the icons of some operations turned gray, making them difficult to read, and I don't know how to change the color of these icons.

It's gray because u can't use it currently. When process stop on breakpoint, it will turn to green

It's gray because u can't use it currently. When process stop on breakpoint, it will turn to green

It doesn't seem that way, I've stopped at the breakpoint now, but the icon is still grey, while I can click on the icon and it also has the correct effect

It's gray because u can't use it currently. When process stop on breakpoint, it will turn to green
oops.. so sorry this is my problem, when i move the focus to dap-repl's window, it does turn blue, but if i keep the cursor on another window, no matter how i click on the icon, it won't turn blue

oops.. so sorry this is my problem, when i move the focus to dap-repl's window, it does turn blue, but if i keep the cursor on another window, no matter how i click on the icon, it won't turn blue

It's gray because u can't use it currently. When process stop on breakpoint, it will turn to green

oops.. so sorry this is my problem, when i move the focus to dap-repl's window, it does turn blue, but if i keep the cursor on another window, no matter how i click on the icon, it won't turn blue

Hmm, weird. Let's wait @rcarriga

Indeed, now that my cursor is on the left side of the dap-console, the icons are gray, and once I switch to the dap-repl window, they immediately turn blue, but by this time the program has stopped at the breakpoint

minimal config
-- ignore default config and plugins
vim.opt.runtimepath:remove(vim.fn.stdpath("config"))
vim.opt.packpath:remove(vim.fn.stdpath("data") .. "/site")
vim.opt.termguicolors = true
vim.opt.laststatus = 0

-- append test directory
local test_dir = "/tmp/nvim-config"
vim.opt.runtimepath:append(vim.fn.expand(test_dir))
vim.opt.packpath:append(vim.fn.expand(test_dir))

-- install packer
local install_path = test_dir .. "/pack/packer/start/packer.nvim"
local install_plugins = false

if vim.fn.empty(vim.fn.glob(install_path)) > 0 then
        vim.cmd("!git clone https://github.com/wbthomason/packer.nvim " .. install_path)
        vim.cmd("packadd packer.nvim")
        install_plugins = true
end

local packer = require("packer")

packer.init({
        package_root = test_dir .. "/pack",
        compile_path = test_dir .. "/plugin/packer_compiled.lua",
})

packer.startup(function(use)
        -- Packer can manage itself
        use("wbthomason/packer.nvim")

        use({ "mfussenegger/nvim-dap" })

        use({
                "rcarriga/nvim-dap-ui",
                requires = "mfussenegger/nvim-dap",
                config = function()
                        local dap = require("dap")
                        dap.adapters.lldb = {
                                type = "executable",
                                command = "/usr/bin/lldb-vscode",
                                name = "lldb",
                        }
                        dap.configurations.cpp = {
                                {
                                        name = "Launch",
                                        type = "lldb",
                                        request = "launch",
                                        program = function()
                                                return vim.fn.input("Path to executable: ", vim.fn.getcwd() .. "/", "file")
                                        end,
                                        cwd = "${workspaceFolder}",
                                        stopOnEntry = false,
                                        args = {},
                                        runInTerminal = true,
                                },
                        }
                        dap.configurations.c = dap.configurations.cpp
                        dap.configurations.rust = dap.configurations.cpp
                        require("dapui").setup({})
                end,
        })

        if install_plugins then
                packer.sync()
        end
end)

vim.cmd([[
command! DapUIToggle lua require("dapui").toggle()
]])

NVIM v0.8.3
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/x86_64-pc-linux-gnu-gcc -march=native -O3 -pipe -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/var/tmp/portage/app-editors/neovim-0.8.3/work/neovim-0.8.3_build/cmake.config -I/var/tmp/portage/app-editors/neovim-0.8.3/work/neovim-0.8.3/src -I/usr/include -I/var/tmp/portage/app-editors/neovim-0.8.3/work/neovim-0.8.3_build/src/nvim/auto -I/var/tmp/portage/app-editors/neovim-0.8.3/work/neovim-0.8.3_build/include
Compiled by portage@localhost

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "/etc/vim/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

I also encountered a similar problem. When I exited Neovim and returned to the command line, I saw the following error messages on the screen:
❯ nvim

Rendering failed: ...ack/packer/start/nvim-dap-ui/lua/dapui/render/canvas.lua:154: Vim:E315: ml_get: 錯誤的 lnum: 2
stack traceback:
...im/site/pack/packer/start/nvim-dap-ui/lua/dapui/util.lua:17: in function <...im/site/pack/packer/start/nvim-dap-ui/lua/dapui/util.lua:16>
[C]: in function 'nvim_buf_set_lines'
...ack/packer/start/nvim-dap-ui/lua/dapui/render/canvas.lua:154: in function 'render_buffer'
.../packer/start/nvim-dap-ui/lua/dapui/elements/watches.lua:70: in function 'render'
.../packer/start/nvim-dap-ui/lua/dapui/elements/watches.lua:24: in function <.../packer/start/nvim-dap-ui/lua/dapui/elements/watches.lua:23>
[C]: in function 'xpcall'
...im/site/pack/packer/start/nvim-dap-ui/lua/dapui/util.lua:16: in function <...im/site/pack/packer/start/nvim-dap-ui/lua/dapui/util.lua:12>%

:version
NVIM v0.8.3
Build type: Release
LuaJIT 2.1.0-beta3
編譯者:brew@Ventura

Features: +acl +iconv +tui
See ":help feature-compile"

        系統 vimrc 設定檔: "$VIM/sysinit.vim"
              $VIM 預設值: "/usr/local/Cellar/neovim/0.8.3/share/nvim"

Run :checkhealth for more info

solved the issue by upgrade to NVIM v0.9.0


content is not center if the viewbox origin is not (0,0)

Bug
When the viewbox's origin is not (0, 0),  and the shape of the svg width/height is not the same as viewbox. The content of the svg is not center (even explictly set preserveAspectRatio='xMidYMid meet')
  <Svg width="300" height="700" viewBox="50 50 100 100" preserveAspectRatio='xMidYMid meet'>
    <Rect x="50" y="50" width="100" height="100" fill="yellow"></Rect>
  </Svg>

Unexpected behavior
the svg content is not centered
Note, this bug seems exists only for native (iOS and Android), if I am using Expo react-native-svg in web platform, it works perfectly.

Did anyone find a workaround for this?

Did anyone find a workaround for this?

I'm just repositioning the svg by containing it in a View component then using transform.


use location for target directory structure

Example:
2019
    Spain
        ....
    Germany
        ....

In progress in branch add-gps.
TODO:

[ ] QA
[ ] Installation instructions of new libraries

Would be better to edit a field in the image. E.g. IPTC keywords

Look at how pyexifinfo is implemented. Should be easy enough to fork and add support for calling  exiftool -iptc:city="some city" "some_photo.jpg". Bonus points for adding a merge request to pyexifinfo with more exiftools support.

https://github.com/johan-andersson01/pyexifinfo


DROOLS-1034 - Kie server test improvement for Oracle RAC

Changes in tests, these tests often failed on Oracle 11gR2 RAC database.
Was merged into master. See: https://github.com/droolsjbpm/droolsjbpm-integration/pull/270

+1
merged into 6.4.x https://github.com/droolsjbpm/droolsjbpm-integration/commit/8f106a98311b34f412d139ddb7392fa754be267f


Add new UV_RUN_FORCE type to uv_run_mode to ensure loop runs even after uv_stop is called

Add new UV_RUN_FORCE type to uv_run_mode to ensure loop runs even after uv_stop is called
Description
This PR introduces a new type UV_RUN_FORCE to the uv_run_mode enum in libuv. This addition aims to address an issue where the loop, after having uv_stop called before invoking uv_run, fails to run as expected due to the stop_flag not being reset appropriately.
Problem
When uv_stop is called before uv_run, the loop's stop_flag is set. If uv_run is called subsequently, it exits immediately without running the loop, and without any error indication, because the stop_flag is not cleared.
Solution
A new UV_RUN_FORCE type has been added to the uv_run_mode enum. When UV_RUN_FORCE is used, the stop_flag will be forcibly cleared, ensuring that the loop runs as expected.
Initially, the approach considered was to reset the stop_flag unconditionally within uv_run. However, this could potentially interfere with existing functionality and logic. To avoid such issues, the new type UV_RUN_FORCE was introduced to provide this functionality explicitly.
Code Changes
The following code changes were made:
// In uv.h or the relevant header file
typedef enum {
  UV_RUN_DEFAULT = 0,
  UV_RUN_ONCE,
  UV_RUN_NOWAIT,
  UV_RUN_FORCE = 1024
} uv_run_mode;

// In core.c or the relevant source file
int uv_run(uv_loop_t *loop, uv_run_mode mode) {
  DWORD timeout;
  int r;
  int can_sleep;

  // Add code
  if (mode & UV_RUN_FORCE) {
    if (loop->stop_flag != 0)
      loop->stop_flag = 0;
    mode &= ~UV_RUN_FORCE;
  }
  // Add code end

  r = uv__loop_alive(loop);
  if (!r)
    uv_update_time(loop);

  // Existing code...
}

Not sure I like the approach.
The others are modes, but the new one is a flag.
It's also only implemented in windows and with no tests...
What use case do you have which requires resuming a stopped loop?

Not sure I like the approach.
The others are modes, but the new one is a flag.
It's also only implemented in windows and with no tests...
What use case do you have which requires resuming a stopped loop?

I understand that my initial implementation might not be the most elegant. My goal is to address the issue where uv_stop might be called inadvertently before the loop starts, ensuring that uv_run can still be executed correctly. The primary purpose of uv_stop is to halt an ongoing uv_loop_t, not to prevent uv_run from starting.
Perhaps my approach is not the best. Another way to handle this could be by adding a function like uv_run_force or adding a parameter to uv_run. This could ensure that the loop runs correctly even if uv_stop was called beforehand.
Alternatively, if adding such a method is not desirable, could we handle the situation where uv_stop is called before uv_run by returning a warning or error to indicate that the loop did not execute correctly?
Thank you for your attention and feedback.

My goal is to address the issue where uv_stop might be called inadvertently before the loop starts, ensuring that uv_run can still be executed correctly. The primary purpose of uv_stop is to halt an ongoing uv_loop_t, not to prevent uv_run from starting.

What is it you are doing which has this (rather odd) case?

My goal is to address the issue where uv_stop might be called inadvertently before the loop starts, ensuring that uv_run can still be executed correctly. The primary purpose of uv_stop is to halt an ongoing uv_loop_t, not to prevent uv_run from starting.

What is it you are doing which has this (rather odd) case?

In my project, I use uv_tcp_t to implement a tcpclient with asynchronous I/O based on libuv. Additionally, it needs to support synchronous functionality, such as the connect method. Because connect and uv_run are not in the same thread, there is a scenario where the user calls the connect method and then immediately calls uv_stop after uv_run. Due to multithreading, uv_run does not execute before uv_stop.
Subsequently, my project has a waitConnectFinish method that waits for the connect to complete, determining success based on the connect callback status. If uv_run does not execute correctly and no error is reported, the connect callback will never be executed. As a result, the user will be stuck in the waitConnectFinish method indefinitely.
I have also considered directly checking the uv_loop_t status, but I feel this approach might not be very user-friendly.
Thank you for your attention and feedback.

I would like to propose a different approach to address the issue. Instead of adding a new enum type, we could add a new method uv_run_force to force the execution of uv_run. This method would look like this:

Because connect and uv_run are not in the same thread, there is a scenario where the user calls the connect method and then immediately calls uv_stop after uv_run. Due to multithreading, uv_run does not execute before uv_stop.

You can't call libuv APIs from different threads. Are you doing that?

Because connect and uv_run are not in the same thread, there is a scenario where the user calls the connect method and then immediately calls uv_stop after uv_run. Due to multithreading, uv_run does not execute before uv_stop.

You can't call libuv APIs from different threads. Are you doing that?

I understand that this might be a multithreading issue. However, uv_run does not raise an exception or return a specific value to indicate this situation. For example, it could return a specific value to signal that uv_run did not execute correctly due to uv_stop being called beforehand.
Thank you for your consideration.

Your code is broken and you seem to be trying to fix it in the wrong place, sorry.
That said, we don't have good documentation on this so we might want to change what we do.
@libuv/collaborators thoughts?

Your code is broken and you seem to be trying to fix it in the wrong place, sorry.
That said, we don't have good documentation on this so we might want to change what we do.
@libuv/collaborators thoughts?

Thank you for the community support. Perhaps my approach focused too much on solving the immediate problem without considering the bigger picture. I hope you can address this issue comprehensively.

That said, we don't have good documentation on this so we might want to change what we do.

@saghul can you summarize what you're asking/proposing here?

We currently don't specify what should happen after uv_stop, as in, will uv_run just continue happily ever after?
Currently it doesn't, which might or might be unexpected.
Given how long the current behavior has existed, I'd be inclined to document it as such, that is, the loop will never in again once uv_stop is called.

It seems a bit awkward to add a new flag for this. In my applications (aka Julia), we just call loop->stop_flag = 0 just before entering the loop (although doing it just after the uv_run returned would also probably be safe). However calling uv_stop from another thread is undefined behavior, so I don't think we should expect to allow that at all.


feat(foundationdb): Initial commit for tracing support

The goal of the PR is to enable some basic tracing capabilities to the foundationdb crate. It is behind a feature not enabled by default.
More tracing operations will be added, once the relevant issue will be fixed

Codecov Report
Base: 82.44% // Head: 82.17% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (77aeea6) compared to base (a77116e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   82.44%   82.17%   -0.28%
==========================================
  Files          26       26
  Lines        5042     5044       +2
==========================================
- Hits         4157     4145      -12
- Misses        885      899      +14

Impacted Files
Coverage Δ

foundationdb/src/database.rs
87.00% <ø> (ø)

foundationdb/src/transaction.rs
88.39% <100.00%> (+0.06%)
:arrow_up:

foundationdb/src/directory/directory_layer.rs
92.32% <0.00%> (-2.03%)
:arrow_down:

foundationdb/src/directory/directory_subspace.rs
90.66% <0.00%> (-1.34%)
:arrow_down:

foundationdb-bindingtester/src/main.rs
88.71% <0.00%> (-1.03%)
:arrow_down:

foundationdb/src/directory/mod.rs
94.85% <0.00%> (+1.47%)
:arrow_up:

foundationdb/src/directory/directory_partition.rs
82.83% <0.00%> (+8.95%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


dll missning in windows

Describe the bug
vcruntime140_1.dll is not included in the latest Windows build.
To run LocalSend, you have to install Microsoft Visual c++ 2015-2022 Redistributable or manually download vcruntime140_1.dll and put it in the LocalSend applicant folder.
To reproduce

Reinstall windows.
Install the latest version of LocalSend.
Open LocalSend.

Expected behavior
Open the applicant.
Screenshots
No response
Desktop (please complete the following information)
Windows 11
Smartphone (please complete the following information)
No response
Additional context
No response

install Microsoft Visual c++ 2015-2022 Redistributable
https://learn.microsoft.com/zh-cn/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022

https://github.com/localsend/localsend/issues/682


contrib: add yocto compatible init script

This has been used on yocto side for quite a while: http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-support/unbound/unbound/0001-contrib-add-yocto-compatible-init-script.patch
Let's add a separate yocto compatible init script that we can maintain, allowing us to drop the patch from openembedded side.
Looks like I cannot add reviewers myself, and I don't know who should review this, I will cc some folks below:
@wcawijngaards @gthess
Thanks.

Thank you for the addition! I have put a mention in the contrib/README file and merged it into the repository.


Feature/canonical pdfs

This addresses #446, releasing us from the clutches of old proposal compatibility. (I wish)
Creating this PR as a draft because I want to test some business logic that I moved around.

This is now ready for review!

Absolutely, I would appreciate your review as well @tymees. Take your time

Alright, I've made changes and brought this branch back up to speed with develop. This is ready for re-review.

Tests now follow the mixin pattern.
generate_pdf() and pdf_template_name() now also reside in the Proposal model.
Addressed comments

Achnowledgements:

Injecting the object into the ProposalAsPDF view manually still isn't ideal, but good enough for now. In the future I might want to move to using a RequestFactory like in the tests.
Plenty of proposal and review logic still resides in the views. But this is a start and we now have better ways to test while moving forward.

Discussion question:

Should we make it so a new PDF can not be saved if a proposal is in a state where it defers to its canonical PDF? This would prevent old proposals from having their holy reference PDFs overwritten.

I've improved the management command with your suggestion, @tymees. Merging now!


GetFilesResponse not fully typed

It would be nice to have more type definition for GetFilesResponse -- particularly for the second and third items in the tuple type.
The SDK docs don't specify that these two items exist; the only place I could find documentation about the response body (third item in the tuple) was the docs on the console.
Environment details

OS: MacOS Ventura 13.4.1
Node.js version: 16.10.0
npm version: 7.24.0
@google-cloud/storage version: 7.0.1

Steps to reproduce

Observe the type definition for GetFilesResponse in node_modules
Note that the second and third items in the tuple type are not fully typed

Hi @jared-jewitt thanks for opening an issue. We are in the process of trying to cleanup a lot of these interfaces that weren't originally typed well / typed at all. Unfortunately, since more strongly typing things is potentially a breaking change this is something we will likely have to wait to release until the next major version.


Add voice input feature

This PR adds a new button called "Start Listening" that allows users to input content into their notes using voice recognition.
When the button is clicked, speech recognition converts the user's spoken words into text, helping them create notes faster.
The feature is implemented using the Web Speech API.

@umesh-chilukuri kindly resolve the merge conflicts and update

#6 is fixed

Add screen recording with implementing feature


Starting to scroll from the bar

Hello,
First of all great library ! That being said, would it be possible to start the process of stretching the bar, as you start scrolling from that bar itself. I hope you get me, now it only works (at least for me) if i start scrolling from what's below my bar, not from the bar itself.
Thanks :)

I'm not sure if I completely understand your issue, but I'll take a guess. Setting userInteractionEnabled to NO on the BLKFlexibleHeightBar instance will allows touches to pass through to your scroll view. Let me know if this fixes it for you!

It does indeed work using userInteractionEnabled set to NO. But the thing is, I actually need the interactions enabled on my bar because I do stuff according to these interactions. Anyway, nothing much you can do I guess. Thanks ;)

You should be able to implement some custom logic for that by subclassing BLKFlexibleHeightBar and doing your own hit tests. It might actually be wise for this functionality to be built in since I imagine many people would like it to behave this way.

implementing that is fair easy:

following this scenario you have a tableview with many rows and you have your custom flexible header.

add top inset equal to your flexibleHeader height to your tableView.
place your custom flexibleHeader below your tableView so CFH can be visible beneath tableView
now when you swipe you finger on CFH you are actually swiping on the tableView

second scenario: you have a custom view in you CFH which contains some buttons  imagine a custom navBar with a back button inside your CFH:

add - (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event to your custom flexibleHeader
implement this way:

if (CGRectContainsPoint(self.navBar.bounds, point))
    {
       targetView targetView = self.navBar;
        // The target view may have its view hierarchy,
        // so call its hitTest method to return the right hit-test view which cause touch forwarded to navBar buttons
        UIView *finalView = [targetView hitTest:point withEvent:event];

        return finalView;
    }
    return [super hitTest:point withEvent:event];


feat: slate void plugins

:tada: This PR is included in version 4.4.0-beta.1 :tada:
The release is available on:

v4.4.0-beta.1
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

v4.4.0
GitHub release

Your semantic-release bot :package::rocket:


Initial Install

Describe the problem
I recently installed tconnectsync on a home linux box running ubuntu 20.04.5 LTS.
The tconnect mobile app is running on IOS 16.0
The tconnect mobile app version is 2.2
I believe that I have everything setup correctly, but when I run tconnectsync --check-login I get an error. Perhaps I have made a very simple error.
Here are the contents of the tconnectsync-check-output.log file:
tconnectsync version 0.8.4
Python version 3.8.10 (default, Jun 22 2022, 20:18:18)
[GCC 9.4.0]
System platform linux
Running checks with time range 2022-09-30 18:52:26.899156 to 2022-10-01 18:52:26.899156
Current time: 2022-10-01 18:52:26.899208
time.tzname: ('CST', 'CDT')
Loading secrets...
TIMEZONE_NAME: America/Chicago
Logging in to t:connect ControlIQ API...
Error occurred querying ControlIQ API for dashboard_summary:
ControlIQ API HTTP 404 response: {"type":"https://tools.ietf.org/html/rfc7231#section-6.5.4","title":"Not Found","status":404,"traceId":"00-2cc1fc7a311a8244b8627885fe080361-80f58b14593c8e45-00"} (HTTP 404)
Querying ControlIQ therapy_timeline...
ControlIQ therapy_timeline:
{'basal': {'algorithmDeliveryEvents': [],
'profileDeliveryEvents': [],
'profileRates': [],
'tempDeliveryEvents': []},
'events': [],
'pumpFeatures': [{'features': {'controlIQ': {'dateTimeFirstDetected': '2022-09-16T16:44:44',
'feature': 1,
'unixTimestamp':<PHONE_NUMBER>}},
'serialNumber': '[PUMP_SERIAL_NUMBER]'}],
'softwareUpdates': [],
'suspensionDeliveryEvents': []}
ControlIQ processed therapy_timeline:
[]
Querying ControlIQ therapy_events...
controliq therapy_events:
{'dataOutOfRange': 0,
'devices': 'T-Slim 4.3 (sn:000172), One-Touch BG Meter',
'dst': 0,
'event': [],
'gapInData': 0,
'noData': 1}
Initializing t:connect WS2 API...
Error occurred querying WS2 API. This is okay so long as you are not using the PUMP_EVENTS or IOB sync features.
HTTPSConnectionPool(host='tconnectws2.tandemdiabetes.com', port=443): Read timed out. (read timeout=10)
Not able to log in to WS2 API, so skipping therapy_timeline_csv
Logging in to t:connect Android API...
 It is working now. I think I might have made a change that needed some time to take effect.


FRotator is pitch, yaw, roll vs pitch, roll, yaw

The FRotator implementation uses the pitch, yaw, roll order instead of pitch, roll and yaw. We need to change this order to fit UE4's API.

I tried to copy the C++ math API as closely as possible. The C++ API uses pitch, yaw, roll. The implementation was copied from https://github.com/EpicGames/UnrealEngine/blob/master/Engine/Source/Runtime/Core/Public/Math/Rotator.h

OK, I said that because it's not the case in blueprint, so it's not an issue sorry.

Yea it certainly threw me off too. But it probably is best to keep to the C++ API.

I agree, that's why I closed the issue. I'm more experienced with blueprint that's why it shocked me ;)
To be honest I prefer the C++ notation


docs(adr-116): modular crypto

Refs #2424

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[x] Updated relevant documentation (docs/ or spec/) and code comments
[x] Title follows the Conventional Commits spec

Many of the advantages of alternate cryptography require more invasive changes to the code base and even the header structure.
For instance to get advantages from BLS-12-381, you also need to be able use aggregated public keys in the commit certificates.
There are wins like a more EVM verification friendly comet that uses keccack and ethsign for signatures that can maybe be done without a hard fork.

I will reopen once this work is restarted.


Deprecate likely()

likely -> initWidget, which is private now
likely works as expected, but warns user about itself deprecation
likely.initiate can accept node and options, or just options as expected

@iamakulov

@iamakulov Done

@iamakulov done

@iamakulov made it just "deprecated". jsdoc annotation is enough actually.

Works great, thanks!


balance data job won't run if update storaged config and replicas at the same time

Please check the FAQ documentation before raising an issue

Describe the bug (required)

Your Environments (required)

OS: uname -a
Commit id (e.g. a3ffc7d8)

version 1.8.0
How To Reproduce(required)
Steps to reproduce the behavior:

create a nebula cluster with 3 storaged nodes,  replica factor is 3
update storaged config static flag and replicas to 9 at the same time
storaged will do a rolling update
at last the storaged pods is 9 and nebula cluster status is ready,  but balance data job not run

Expected behavior
nebula cluster status is ready and data is balanced

Additional context

I can reproduce it, wil fix the issue in v1.8.1.

https://github.com/vesoft-inc/nebula-operator/pull/505


Chown typo?

Hello,
shouldnt it be "run chown -R www-data:www-data pimcore" instead of "run chown -R 1000:1000 pimcore"?

Hi,
inside the container every command will be run as root.
The synched volumes have the ID of the current user. I'm not sure if it's always 1000. But in my case it's 1000.
I just tested it without changing the owner. I think you can ignore the chown command. Or try to set the user directly in the Dockerfile.
But you'll need to give the /var directory the right permissions. Otherwise you'll get the exception that cache files can not be written.


Improve Concept Exercise: Elyses Transformative Enchantments (array-transformations)

The goal of this task is to make sure the Concept Exercise "Elyses Transformative Enchantments" and the Concept array-transformations conform to the latest specification.
The docs can be found here

What are Concept Exercises?
Concept Exercises
Concepts

Additionally you can look at the bird-watcher concept exercise for reference.
The improvement should include changing the introduction.md file of the exercise to contain some minimal information so that the student is able to solve the exercise. For now it is ok to use that same content as introduction.md and about.md for the Concept as well.
Also ensure that

there are good blurbs for the concept and exercise
the tests are declarative (see https://github.com/exercism/javascript/issues/1019 for an example)
each test case is "self-contained" so that the student sees meaningful output from the test runner (no forEach, no helper functions defined in other parts of the test file etc.)

There is no array-transformations concept yet on this track. Does this issue mean that one should be created?

Good point. I didn't notice the folder does not even exist yet. Yes, the concept needs to be created and added to the config.json file.

Can I work on this?

Yes, that would be great! Note that I extended the issue description with some ideas about the introduction that I discussed with DJ but did not write down yet.

The array transformation concept exists now. The following tasks are left:

[ ] Double check/improve the exercise as described above.
[ ] Change the task that currently uses fill to instead teach reverse. Make sure to also adjust the hints, instructions etc.
[ ] Add sort to the concept.
[ ] Copy the concept introduction into the exercise introduction.

I will work on this so we can get the exercise live soon.


Sidebar not showing all slides

I would expect these titles to show up in the sidebar.

But some titles are missing (eg Step 3 Context and Space or Step 4 - Technical) and some empty steps are showing up.

I imagine the weird numbering in the admin will be useful to debugging this

I've fixed that by renumbering.  There's still some weirdness in step 4, it doesn't seem to like the zero-indexed positions, although it isn't clear how the step descriptions get displayed otherwise.

These are the slides that I think have a problem
4.0, 5.0, 6.0, 7.0 have questions but no other x.0 slides do. These slides having titles. Those titles should be shown in a section on the sidebar.
We want to use x.0 for to introduce the user to that section but don’t show questions on those slides.
4.5, 5.6, 7.10 don’t exist but they’re showing in sidebar. Remove these.

Since #21 was done, slides no longer need to start at position 0 inside a step.  Position 0 in a step shows the step title and description.  I've moved any slides at position  0 to position 1 and moved everything else up.
Are you seeing any other slide numbering oddities now?  4.5, 5.6, 7.10 all seem OK now.

@edjw I think we can close, please check


[FIX] Bullet Points

closes #541
What does this PR do?
This PR addresses two things:

The bullet points of the sub-lists
Minor grammar corrections

Thanks all 👍


Check if app is on TestFlight/Google Play Beta

This is a feature request, please let me know whether it's valid for the project or not.

Description
A simply function that returns true if the app has been downloaded through TestFlight or Google Play Beta, e.g. isTesting().
The use-case is that I want to print out errors on screen if it's on TestFlight and Build Configuration === 'Release' but not on production (downloaded from store).

I was recently looking for a way to check this too. It looks like this is a good project to place such functionality.

I wrote this forever ago:  https://github.com/GantMan/react-native-siren
It might be useful.  I haven't updated it in a while.

For those searching for a solution, here is the solution for iOS TestFlight. I am unaware of any google play solution.
In your Xcode workspace, create a file ProdChecker.h
#ifndef prodChecker_h
#define prodChecker_h

#import <React/RCTBridgeModule.h>

@interface ProdChecker : NSObject <RCTBridgeModule>
@end

#endif /* prodChecker_h */

In your Xcode workspace, create a file ProdChecker.m
#import "ProdChecker.h"

@implementation ProdChecker

RCT_EXPORT_MODULE();

RCT_REMAP_METHOD(isTestflight, resolver: (RCTPromiseResolveBlock)resolve
                 rejecter:(RCTPromiseRejectBlock)reject)
{
  NSURL *receiptURL = [[NSBundle mainBundle] appStoreReceiptURL];
  NSString *receiptURLString = [receiptURL path];
  BOOL isRunningTestFlightBeta =  ([receiptURLString<EMAIL_ADDRESS>!= NSNotFound);
  if(isRunningTestFlightBeta) {
    NSString *thingToReturn = @"TESTFLIGHT";
    resolve(thingToReturn);
  } else {
    NSString *thingToReturn = @"PRODUCTION";
    resolve(thingToReturn);
  }
}

@end

Those are the files needed to call the objective-c functions from react native. The function above will determine if the app is on the App Store or on TestFlight.
And now the react-native implementation:
import { NativeModules } from 'react-native';
const ProdChecker = NativeModules.ProdChecker;

RegisterManager.isTestflight().then(val => {
    if(val != "TESTFLIGHT") {
        // app is in production on App Store, not TestFlight
        // execute all production specific code here
    }
})

This way, you'll be able to tell if the app is in production or not.

Bump...

@kirill-konshin I'm not sure what you're expecting from this bump.. you could submit a PR instead.

I expect that 1 year old issue will be brought to your attention :) which could be annoying but that's the best I could do now. If I could do a PR I would do it in a first place  :) unfortunately, I don't know the right solution, especially for Google Play.

Well, that makes two of us :)

sandboxReceipt

the  appStoreReceiptURL of  ad-hoc or dev app also contains '"sandboxReceipt" string, so there is a little falut, refer to the answer https://stackoverflow.com/questions/18282326/how-can-i-detect-if-the-currently-running-app-was-installed-from-the-app-store/18619270

I don't want this module to skew off towards checking all sorts of software things, especially not when others are already doing that work ;-)
https://www.npmjs.com/package/react-native-test-flight

@mikehardy There's still no solution for Google, so that package doesn't help that. Seems like nobody has been able to find even a low-level way to do it with Google, short of querying the Play API for the package and version (whether it's on a production or beta/alpha track).
Personally, I think a reasonable workaround for having modifications in the app based on where it was downloaded is to add a toggle button in the app itself (ie user settings, etc) to manually do whatever the app would do if it were in beta (ie switch to a staging server, etc). If that's not an option then I've also used configuration files that submitted the app for review knowing it was in test mode (such as for credit card transactions, Apple Pay, etc) and then used CodePush to update the config later on into production after it's been approved.

My projects typically have a versioning scheme where alphas and betas have detected ranges in a pattern, so the app simply knows based on it's internal version whether it is alpha or beta, then with a well-defined release system alphas and betas only go out on the right channels? You could also potentially use Firebase remote config, along with code-push etc. Lots of ways to handle it. But none available via this package ;-)

Could the getInstallReferrer function be used for this on Android?

not that I'm aware of. It will just return the name of the system packager if I understand + remember correctly. You can test this by publishing the information from rn-update-apk about the installed package

@robertherber The Google Play Beta version actually is installed through the Play Store app after the user either opts-in to the beta testing or is added to a predefined list of authorized users. There is no separate Testflight-like app for Android.
I'm still convinced the simplest way to handle this (such as for using different APIs) is to have a toggle button somewhere in the app (in a user settings screen?) for internal/test users after they login. Or have some sort of tapping backdoor (ie tap on some text 10 times) similar to how Google Developer mode is enabled on Android phones.

There is one possible way to determine if the app was installed over Google Play Store and a testing track or production build. Or if it was installed directly from a local or CI build. You would need to setup on Google Play Console an upload key and that Google Play Store then changes the certificate when it is uploaded to Google Play console. You can read the certificate in the app itself. See https://github.com/WesBunton/MyCertificates . And by that at least you can check if it is the upload key or the store key. If it is the upload key you can be sure that its not the production or testing track.
I have not tested it directly but will try it out in the future.


Update Linode's svg logo

Deploy preview for landscape ready!
Built with commit 8b4b97dcb80be89fe618f36fd6bdcd3c96fc729b
https://deploy-preview-1641--landscape.netlify.app


docs: remove mentions of ENTERPRISE_CLUSTER_REGISTRATION_ALLOWED_ORGANIZATIONS

The parameter is removed in https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/1573 as it is no longer needed because KFM infers it from the supplied quota configuration

Related to https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/1573#discussion_r1106039906 and needs to be merged only once the upstream PR is merged
/cc @MikeEdgar

@MikeEdgar this is ready for review. It'll also be good to have a new release

Thanks


[ISSUE] Can't even install the container when using 'Unraid'

Describe the bug
Went to install the container for the first time using 'Unraid' and I'm getting an error with the installation.  I have not changed any of the parameters.
To Reproduce
Just trying to install will reproduce the issue

Do this '...'
See error

Expected behavior
I expected the container to install like others.
Screenshots

Configuration
Unraid on a Dell R520
Additional context
Add any other context about the problem here.

Please refer to #94 , specifically https://github.com/mandarons/icloud-drive-docker/issues/94#issuecomment-1265712866
Looks like you need to create config.yaml first and then start the container.

I created config.yaml but container just restarts, no logs or console

I am not sure how else I can help here if there are no logs. :(
I don't have unraid to reproduce the problem. There is also nothing unique about this project. It's just yet another container from docker's perspective.

I am using icloud-drive-docker on Unraid without problems. Seems that you have not mounted the config.yaml corrctly to your container. please read the error output on your screenshot ;)

As mentioned above, you should manually place config.yaml into /mnt/user/appdata/icloud-drive-sync/ before installing app.
@mandarons, maybe it would be more convenient to create sample config.yaml on first launch?

@mikeyvt
change the docker settings from Container Path to Container Variable:
delete the Container Path config that comes in the template and create a Variable config

This issue is still present and not related to the config.yaml.
The container in Unraid with default settings keeps restarting so it's not possible to collect the log if we don't stop it first.
addgroup: gid '100' in use
====================================================
To support this project, please consider sponsoring.
https://github.com/sponsors/mandarons
https://www.buymeacoffee.com/mandarons
====================================================

Using UID as 99, GID as 100 and UMASK as 002...
adduser: unknown group icd
Changing ownership of /app ... This operation may take significantly longer depending on number of files in your local copy of icloud.
chown: unknown user/group icd:icd
su: unknown user icd
addgroup: gid '100' in use

The issue is related to the adduser and addgroup commands.
More specifically, Unraid docker uses a default of UID=99 and GID=100.
Removing GID=100 allows the container to start with a default GID of 1000.

Upgrading to v1.20.0 should fix this problem. Please note the breaking changes as mentioned on https://github.com/mandarons/icloud-drive-docker/releases/tag/v1.20.0.


Update the Web SDK to support the OIDC flow and all redirects (FE)

Created by: @bayegan Nov 08 2021 at 19:25 CET
Last updated: Jul 18 2022 at 11:51 CET
ClickUp ID: IK-1776
Update the UI SDK to support the OIDC flow and all redirects (FE)
What happens when you click the bottom (follow all the redirects):

Commented by: @bayegan Nov 23 2021 at 14:12 CET
Some redirects and URLs that are not working as expected.


AutoForwardingMode parameter missing

Hello,
A new parameter -AutoForwardingMode is available for Set-HostedOutboundSpamFilterPolicy but I don't see any documentation.
This parameter can be used in production ?
It is also available on https://protection.office.com/antispam -> outbound

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6920a144-bebb-2d5a-d328-855e6a4613a4
Version Independent ID: 35937201-f07b-7c3b-42f5-fd923c9adb04
Content: Set-HostedOutboundSpamFilterPolicy (exchange)
Content Source: exchange/exchange-ps/exchange/Set-HostedOutboundSpamFilterPolicy.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@itpro-tips, a similar issue was raised in the regular anti-spam policy content here.
I've been able to determine that the new UI and parameters are available to everyone; however, they won't start doing anything until after September 1st.
I was waiting for confirmation about exactly what the "Automatic: System-controlled" value means.
I'll update the corresponding cmdlet reference topics as well.

Topic updated.
Thanks for the feedback.
Closing.


Drivers should be able to cancel carpools

Use case: Driver creates a carpool, leaves the page, and some time later needs to cancel the carpool. All passengers and potential passengers should be notified.

[ ] UI

[ ] A way for the driver to cancel their carpool
[ ] Confirm that the driver wanted to cancel

[ ] Backend

[ ] Send emails to the riders

From the UX side I'm implementing this with a link that is only visible to the person that created the carpool:

When they click that, they get a confirmation screen:

... but the more I think about this, the more I think I want to add a page to hang these carpool-specific things off of, so I'll probably change this implementation here in a bit.

@iandees I'm adding the feature to email riders when a driver cancels the carpool. Is that OK? (I hope I didn't accidentally duplicate your work)

Nope, not started yet. I was going to put together a more general emailing system using Mailgun, but I'm happy to take whatever you've got.

I just wrote the function to email users on carpool cancel. You can hook it up to whatever service you'd like via env vars.

Sounds good!

Can I get permissions to push a new branch for the PR?

@agdt3 you've been invited as a collaborator.

I'm going to close this because drivers can cancel their carpools. It can definitely be improved, but let's make tickets for that later.


Send invite on direct message

Fixes #1129. Features:

Extends CreateThreadModal to support configuration parameters (ThreadConfig).
Opens up a CreateThreadModal when creating a direct message thread so that the user can choose its initial name.
Sends an invite to the contact when a direct message thread is created.

Sorry this one got a little stale. Let's get it updated, tests passing, and merged!

@andrewxhill I removed the dependency on ThreadConfig in CreateThreadModal and it's no longer exported. This should be ready for further review & merge.

@asutula  CreateThreadModal will send invites once the user submits from that screen. I didn't manually add in the code to send an invite, I connected the button to CreateThreadModal, which handles it for me.

Anything I can do to get this ready for merge?

@asutula can we get this in? I think it's currently broken in the app when you "send a message", since no invite is sent and there is no way to add after the fact. My guess is this is a pretty common entry point to sharing since it's so intuitive.

Yea for sure. @undercase you want to get this thing up to date with master?


Glide 12 Compatibility

This patch adds compatibility with Glide 12. When determining the version the Makefile first checks to see if the project is versioned. If so the GIT_ROOT is calculated using Glide's cache instead of assuming an immediate .git directory.

Current coverage is 26.03% (diff: 100%)

Merging #265 into master will decrease coverage by 0.04%

@@             master       #265   diff @@
==========================================
  Files            39         39
  Lines          2420       2420
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            631        630     -1
- Misses         1721       1722     +1
  Partials         68         68

Powered by Codecov. Last update c962c71...6b7c1d7


Deprecation cop still angry

Using the latest version of everything.
index.less
Use the `atom-text-editor` tag instead of the `editor-colors` class.
Use the `atom-text-editor` tag instead of the `editor` class.
Use the selector `atom-text-editor[mini]` to select mini-editors.

Yep, same here

The same +1

Looks like this was tackled before https://github.com/jesseweed/seti-syntax/pull/31

Ah dang, missed that in the last update. I'll get that in next.

Deprecation errors have been addressed in 0.3.2 update.


Fix valign handling, it should support "middle" according to the doc

Thanks @kevinresol !
Code fixed by changing the 'c' string to 'm'
The type remains 'ctr' as thats the valid XML - "middle" is used as the valign option to match PowerPoint UI.


Lower case 'i' does not work when typing

Type: Bug
lower case 'i' does not show when pressed on either of my keyboards. it does work on all other applications but azure data studio. It also works if I shift-'i' to uppercase. Not sure how this happend or how to fix it. thank you - kevin
Azure Data Studio version: azuredatastudio 1.46.1 (ba29842b81dec01177415e53948ca2168e69c3f8, 2023-10-02T18:14:22.887Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.71GB (5.78GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

azuredatastudio-oracle
Mic
0.1.5

import
Mic
1.5.5

net-6-runtime
Mic
1.1.0

azdata-sanddance
msr
4.1.1

Can you tell me which areas have you encountered this bug? Such as in settings or in Query Editor?

Query editor
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Alex Ma @.>
Sent: Friday, October 27, 2023 2:08:28 PM
To: microsoft/azuredatastudio @.>
Cc: Kevin Spittler @.>; Author @.>
Subject: Re: [microsoft/azuredatastudio] Lower case 'i' does not work when typing (Issue #24797)
STOP!
THIS IS AN EXTERNAL EMAIL
This email was originated outside of the MetroHealth System
Take a 3-second pause and ask yourself the following questions:

Who is sending me this email? Do I know who this is?
Am I expecting this email? Is this out of the ordinary?
Why is there a link in the email? Do I trust this link?

THINK
Before You
Click the Link
Can you tell me which areas have you encountered this bug? Such as in settings or in Query Editor?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/azuredatastudio/issues/24797#issuecomment-1783312538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO3DGUAU5VBLUVZL5ADQJ2TYBP2BZAVCNFSM6AAAAAA6S3KAB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGMYTENJTHA.
You are receiving this because you authored the thread.Message ID: @.***>
MetroHealth’s Mission: Leading the way to a healthier you and a healthier community through service, teaching, discovery, and teamwork. This email and all attachments that may have been included are intended only for the use of the party to whom/which the email is addressed and may contain information that is privileged, confidential, or exempt from disclosure under applicable law. If you are not the addressee or the employee or agent of the intended recipient, you are hereby notified that you are strictly prohibited from printing, storing, disseminating, distributing, or copying this communication. If you have received this notification in error, please contact the Privacy Officer at @.***

@kspittler I wasn't able to reproduce this issue in my environment.  It's possible that i was somehow mapped as a Keyboard Shortcut to a command that is not doing some noticeable action.  You may check the "Keyboard Shortcuts" configuration page available from the Preferences menu.
Otherwise, you could try resetting the application state under [userhomedir]\AppData\Roaming\azuredatastudio, though deleting that cached content would clear out saved connections and other preferences.

Wow! Thank you that worked. It was created to refresh intelisense.
Cheers,
Kevin Spittler, MBA-HCA | Strategic Data Analyst | Institute for H.O.P.E™
<EMAIL_ADDRESS>From: Karl Burtram @.>
Sent: Friday, October 27, 2023 4:30 PM
To: microsoft/azuredatastudio @.>
Cc: Kevin Spittler @.>; Mention @.>
Subject: Re: [microsoft/azuredatastudio] Lower case 'i' does not work when typing (Issue #24797)
STOP!
THIS IS AN EXTERNAL EMAIL
This email was originated outside of the MetroHealth System
Take a 3-second pause and ask yourself the following questions:

Who is sending me this email? Do I know who this is?
Am I expecting this email? Is this out of the ordinary?
Why is there a link in the email? Do I trust this link?
THINK
Before You
Click the Link

@kspittlerhttps://github.com/kspittler I wasn't able to reproduce this issue in my environment. It's possible that i was somehow mapped as a Keyboard Shortcut to a command that is not doing some noticeable action. You may check the "Keyboard Shortcuts" configuration page available from the Preferences menu.
Otherwise, you could try resetting the application state under [userhomedir]\AppData\Roaming\azuredatastudio, though deleting that cached content would clear out saved connections and other preferences.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/azuredatastudio/issues/24797#issuecomment-1783475487, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO3DGUFG7A3K3YLZZ4NSFZ3YBQKUXAVCNFSM6AAAAAA6S3KAB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGQ3TKNBYG4.
You are receiving this because you were mentioned.Message ID: @.***>
MetroHealth’s Mission: Leading the way to a healthier you and a healthier community through service, teaching, discovery, and teamwork. This email and all attachments that may have been included are intended only for the use of the party to whom/which the email is addressed and may contain information that is privileged, confidential, or exempt from disclosure under applicable law. If you are not the addressee or the employee or agent of the intended recipient, you are hereby notified that you are strictly prohibited from printing, storing, disseminating, distributing, or copying this communication. If you have received this notification in error, please contact the Privacy Officer at @.***

Thanks for the confirmation Kevin.
Closing this issue since it is resolved.


Should we add resources to printing masks, ventilators, and other printed devices?

Here’s one.
https://masques-barrieres.afnor.org/home/telechargement?culture=en-GB

No, I don't think so.
It's not a useful category.


fix: New xpath on model serving runtime selection dropdown

The xpath for the Model Serving selection dropdown has changed in the 2.8
Fix for tests:

ODS-2276: Verify RHODS Admins Can Import A Custom Serving Runtime Template By Uploading A YAML file
ODS-2279: Verify RHODS Admins Can Delete A Custom Serving Runtime Template

doesn't the UI requires to select the protocol as well?

doesn't the UI requires to select the protocol as well?

Not on this tests


Bugfix for UpdateDNSRecord

Should address #97.

Looks like this fix worked: https://github.com/cloudflare/cloudflare-go/issues/97#issuecomment-268569747


Add CHP and SteamTurbine defaults logic

See https://github.com/NREL/REopt.jl/pull/142.
TODO
Add test for expected CHP size_class and/or prime_mover based on average heating load and existing boiler production type.

@zolanaj I was thinking since I merged the chp-changes branch already, you could add your test to develop in this PR,

@zolanaj I was thinking since I merged the chp-changes branch already, you could add your test to develop in this PR,

Got it, no worries, working on the test now.


substreams protogen do not respect excludePaths

It seems only substreams build takes it into consideration:
$ substreams protogen
Running: buf generate /var/folders/hy/f_lkgxf91_b7mt3trmxw671w0000gp/T/solana_tokens.tmp.spkg#format=bin

$ substreams build
Running: buf generate /var/folders/hy/f_lkgxf91_b7mt3trmxw671w0000gp/T/solana_tokens.tmp.spkg#format=bin --exclude-path sf/substreams
...

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx


Payload conflicts

Currently you are allowed to have the following:
class Weird(str, int):
    pass

But this causes issues using using instances of this class as both str and int expect the payload to be PyString and PyInt respectively, but the object can only have a single payload.
>>>>> 2 + Weird()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: Unexpected payload for type "Weird"

CPython deals with this by raising an error during class construction time:
>>> class Weird(str, int):
...     pass

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: multiple bases have instance lay-out conflict

I feel we should do a similar thing by detecting when bases have different payloads.
This also comes up in __class__ assignment, the following is CPython behavior:
>>> class A(str): pass
...
>>> class B(int): pass
...
>>> A().__class__ = B
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __class__ assignment: 'B' object layout differs from 'A'

We could probably do something with a TypeId stored in PyClass


Sorting for formatted date

Laravel Version: 5.5.40
Voyager Version: 1.0
PHP Version: 7.1
Database Driver & Version: mysql 14.14

Date entries with format of %d-%m-Y are not treated as dates but string instead whenever sorted on the browse / listing.
I've created a DATE new column via BREAD. Set column to have DATE field and format of dd-mm-yyyy on the listing page.
Having it formatted in yyyy-mm-dd and mm-dd-yyyy get sorted just fine.

If you are not using server side pagination, ordering is done by DataTables.
Its supported date formats depend from browser used but it's usually ISO8601, that's why yyyy-mm-dd works.
If you want other formats to work you'll need to extend DataTables.
I'm not sure if you can do it just adding js or if you'll need to customize the browse view.
You can check it here: https://datatables.net/blog/2014-12-18


SAM-3359

Change Dialog to Clarify Autosubmit feature

Hi @ayersjr , it looks like other commits leaked into this branch. I would recommend starting with a clean git branch based off of sakaiproject/sakai master and then committing directly to that branch.


temporary webstats

So we have something up there, I wonder if we could just include  2 screenshots (like this once the stats are updated at the end of Sept which is usually a good month)
and then update every 6 months or so until we get new stats?

ugh, you know I hate manually updating things that should be automated ;)
More seriously, one major and one minor issue:

Major: The graphs might benefit from slightly longer, more explanatory titles, and will need legends explaining what's counted (and maybe what isn't). I'm happy as usual to edit text, but I don't actually know enough to do an initial draft.
Minor: the x-axis labels look messy. Can they use numerical dates (e.g. 2012-03) or month abbreviations (e.g. Nov 2014) so the lengths are more similar?

I know that's why I asked tentatively ;)
I think I could make better screenshots, they are directly from the graphs generated in the spreadsheets
https://docs.google.com/spreadsheets/d/1tR8Z7MLcikHdBd2LHpHzobB6slIcDDKcbJxHAitBkSg/edit#gid=784354464
I'm not even sure these are the correct ones to use (I think I should be using K-stats, which are  better graphs).
It would mean there were some webstats visible in the next 12-24 months when we are unlikely to be able to automate, and that they are equivalent to  other major model access statistics.
I won't so anything for now,  but it might happen later.... if so I will make it so that all that needs to happen is slotting the new images in every 6 months or so....

I'm not even sure these are the correct ones to use (I think I should be using K-stats, which are better graphs).

I can't help you with that - this is all out of my depth. I'm good for plugging piccies into a web page ...

I'm good for plugging piccies into a web page ...

That all you would need to do...once you have approved the content

well things are moving faster than expected, so lets not bother with this.


[FLINK-36530][state] Fix S3 performance issue with uncompressed state restore

What is the purpose of the change
This is backport of https://github.com/apache/flink/pull/25509.
Flink state restore from S3 is super slow because skip function is consuming ~15 seconds for ~6Mb of data. This operation is called for each and every list state element for CompactCoordinator state (all similar operator list states are effected). The list of this is several thousands during normal operation which ends up in multiple days of restore time.
In this PR the skip going to be called only in case of compression because otherwise a stream is seekable.
Brief change log
Do not call skip operation in case of uncompressed state.
Verifying this change
Manually on cluster + changed unit test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

cc @Zakelly

1.18 is problematic so merging without green azure like we did in https://github.com/apache/flink/pull/25479#issuecomment-2421167188


docs: Deprecate SNS and publish relocation information

This is likely the last commit and release to com.vonage:client and the 7.x branch. It is mainly a cleanup and "FYI" type of release. As such, it contains no actual changes other than deprecation annotations.

Codecov Report

Merging #494 (bccdab9) into main (64e4ea6) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head bccdab9 differs from pull request most recent head b617658. Consider uploading reports for the commit b617658 to get more accurate results

@@            Coverage Diff            @@
##               main     #494   +/-   ##
=========================================
  Coverage     93.95%   93.95%
  Complexity     2592     2592
=========================================
  Files           380      380
  Lines          6521     6521
  Branches        430      430
=========================================
  Hits           6127     6127
  Misses          218      218
  Partials        176      176

Files
Coverage Δ

src/main/java/com/vonage/client/HttpWrapper.java
100.00% <ø> (ø)

src/main/java/com/vonage/client/VonageClient.java
98.88% <ø> (ø)

.../java/com/vonage/client/legacyutils/XmlParser.java
72.72% <ø> (ø)

...in/java/com/vonage/client/legacyutils/XmlUtil.java
72.72% <ø> (ø)

...n/java/com/vonage/client/logging/LoggingUtils.java
93.75% <ø> (ø)

...in/java/com/vonage/client/redact/RedactClient.java
100.00% <ø> (ø)

...n/java/com/vonage/client/redact/RedactRequest.java
85.71% <ø> (ø)

src/main/java/com/vonage/client/sns/SnsClient.java
100.00% <ø> (ø)

...m/vonage/client/sns/request/SnsPublishRequest.java
100.00% <ø> (ø)

...java/com/vonage/client/sns/request/SnsRequest.java
100.00% <ø> (ø)

... and 4 more


How to know if save action succeeded?

I tried to use saveas to save file and it runs without any exception even save failed. Any idea how to know ?

In my development branch, a failure to save will throw an exception. This change will hopefully make it here soon.

And the change is now in the main repository: So if Save / SaveAs does not throw, it succeeded. If it fails, you will get an XLException or Zippy::ZipRuntimeError


wip: adds delete method with repeated filter code

This PR adds a delete method to the EventRepository interface. An implementation of the method is also provided on EventRepositorySqlite.

@CodyTseng I repeated a lot of code here, I will improve it, just wanted to get the PR going. I think the find and delete methods could share the filtering logic and we could extract that into its own function that returns an object like:
{
  innerJoinClauses: [],
  whereClauses: [],
  whereValues: []
}

Hi @CodyTseng, what do you think of this so far?

It seems like the tag filtering condition is ineffective 🤔

Hi @CodyTseng, what do you think of this so far?

It seems like the tag filtering condition is ineffective 🤔

I'll check that out and also provide test cases in this PR.

I'll check that out and also provide test cases in this PR.

No hurry, take your time 🤗


add DolphinTool.exe to dolphin stable now that it uses a not comically out of date version

i made a PR a bit ago to add DolphinTool.exe to beta and dev and i think it should be added to stable too with the new versioning system

Feel free to open a pull request for this :slightly_smiling_face:

Working on this


Update DB to include new SendGrid Node.js libraries

https://www.npmjs.com/org/sendgrid

I do not quite understand this, how can I help? @thinkingserious

Hello @gabrielgene,
We currently pull in data from the old SDK here which is deprecated.
Now we want to pull data on these repos:
https://www.npmjs.com/package/@sendgrid/client
https://www.npmjs.com/package/@sendgrid/contact-importer
https://www.npmjs.com/package/@sendgrid/mail
https://www.npmjs.com/package/@sendgrid/inbound-mail-parser
https://www.npmjs.com/package/@sendgrid/helpers
https://www.npmjs.com/package/@sendgrid/subscription-widget
I hope that helps!
With Best Regards,
Elmer


Import error

Issue
I updated aider in hope to fix my issue in https://github.com/paul-gauthier/aider/issues/995
However after updating Aider I can't start it anymore at all:
❯ aider --sonnet --vim
Traceback (most recent call last):
  File "/home/tom/.local/bin/aider", line 5, in <module>
    from aider.main import main
  File "/home/tom/.local/lib/python3.10/site-packages/aider/main.py", line 12, in <module>
    from aider import __version__, models, utils
ImportError: cannot import name '__version__' from 'aider' (/home/tom/.local/lib/python3.10/site-packages/aider/__init__.py)

Likely an issue on my side, just wanted to have it documented
Version and model info
❯ pip freeze | grep aider
aider==0.2.4
aider-chat==0.47.1

Looks like you accidentally did pip install aider not aider-chat.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Issue #150 : Sidebar bug is resolved.

Manage Members/ Employees can now get highlighted as intended. #150

Codecov Report

Merging #178 (1d4b684) into master (7a71231) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   97.40%   97.40%
=======================================
  Files          20       20
  Lines         501      501
=======================================
  Hits          488      488
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a71231...1d4b684. Read the comment docs.


How to close window by cmd+q on macOS?

Specific Demand
There are few common key strokes on macOS to operate window, cmd+q to quit, cmd+w to close window, I'd like those in dioxus.
Implement Suggestion
Tauri does support those key strokes, so I guess dioxus could support them as well.

This was discussed on discord and resolved with this code:
#![allow(non_snake_case)]
use dioxus::prelude::*;
use dioxus_desktop::{
    tao::menu::{MenuBar, MenuItem},
    use_window, Config, LogicalSize, WindowBuilder,
};

fn main() {
    dioxus_desktop::launch_cfg(
        app,
        Config::new().with_window(
            WindowBuilder::new()
                .with_title("Your app title")
                .with_inner_size(LogicalSize::new(1280, 900))
                .with_menu({
                    let mut menu = MenuBar::new();

                    let mut app_menu = MenuBar::new();
                    app_menu.add_native_item(MenuItem::Minimize);
                    app_menu.add_native_item(MenuItem::Quit);

                    menu.add_submenu("&Dioxus Demo", true, app_menu);
                    menu
                }),
        ),
    );
}


misc/release: staticcheck

Closing this, see my comment here:

https://github.com/perkeep/perkeep/pull/1405#issuecomment-894727096


fix(integration-bundle): locking dependency versions for React package

Related Ticket(s)
Refs #5340
Description
In a recent failed integration bundle test, it was discovered that the
dependency package @babel/runtime was updated, which has a
sub-dependency that may have been causing the build failures. The fix
around this is to set the explicit version that is being used by the
React package.
UPDATE: It was discovered that the specific latest version of
@babel/preset-env was causing issues where the version being passed
was not the correct value, causing a breakage when passed into semver.
This moves the resolution to one patch version back, which appears to
fix the issue. This is in the codesandbox examples used in the integration
bundle tests.
Changelog
Changed

React package.json
csb examples package.json configurations

This PR is waiting on https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/5350 before this can be merged in. The integration build test picked up an actual bug after the initial bug in the test was fixed, which #5350 is addressing.

@jeffchew Looks like the error is still happening.

Yeah, I noticed, and in a different place. I'm going to take a look if I need to adjust another test too.

Closed this in favor of https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/5366. Thank you @kennylam !


Fix for In App notifications on iPhone 4S

This just removes the aspect ratio constraint, and increases the tap area for the close button.

There is a slight difference between what is seen in the web composer and what is seen in the device. Attached are screenshots for your convenience for comparison.

Smaller images are being fitted to full screen rather than staying in original sizing


[api]Removed IsInstitutionAdmin decorator

The API endpoint to get the application details was restricted only for admin users but it is also needed during the login process for non-admin-users which leads to a wrong Forbidden User error.

@andrewsignori-aot Thanks!


Fixed close connection issue with rfxtrx device and update rfxtrx lib

Description:
Fix slow rfxtrx tests.
Related issue (if applicable):  #1480
Slow rfxtrx tests
Checklist:

[x] Local tests with tox run successfully.
[x] TravisCI does not fail. Your PR cannot be merged unless CI is green!
[x] Fork is up to date and was rebased on the dev branch before creating the PR.
[x] Commits have been squashed.
If code communicates with devices:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Perfect! :+1: :dolphin:


Add murmurhash2

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Why we need MurmurHash2?
MurmurHash2 is an outdated hash function, superseded by MurmurHash3 and subsequently by CityHash, xxHash, HighwayHash. Usually there is no reason to use MurmurHash.
It is needed for the cases when you already have MurmurHash in some applications and you want to reproduce it in ClickHouse as is. For example, it is needed to reproduce the behaviour for NGINX a/b testing module: https://nginx.ru/en/docs/http/ngx_http_split_clients_module.html


Pin a different version of nixpkgs

Thanks a lot @CohenCyril . This was exactly what I was looking for!


BSP-dec version asks to update some libraries

Is it intended? It's like it requires .NET 6.0.0. While the normal editor doesn't ask it.

HalfLife.UnifiedSdk.MapDecompiler is based on .net6 platform. I want to update whole project to use .net6. So, yes, its intended. It is possible to downgrade MapDecompiler project, in that case my version would be detached from original repository, and therefore might contain dependency issues (if so). But anyway I plan to update whole project. For that purposes I separate net-update from dev branch, and bsp-dec from net-update

Alright

By the way, it only works with windowsdesktop-runtime-6.0.29-win-x86 installed. Not with x64 version or with .NET SDK.

It was initially made to use x86 arch, and did not worked with x64 systems because of imgui.net wrapper, that requires native library cimgui.dll. I added support of x64 native library, and project could be built in "Any CPU" mode, which will build x64 arch application, but I left x86 architecture to keep compatibility with x86 systems


Describe Function autocomplete for flink

Describe the bug: Currently Describe Function is not autofilled in flink editor , This should be added to flink editor.
reference for Describe function
Syntax : DESCRIBE [catalog_name.][db_name.]table_name
Reference for Describe : https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/sql/describe.html#describe-statements
Steps to reproduce it?
Issue is reproducable in the master branch
Hue version or source?
Latest build from msater branch

It is probably a simple mess-up here https://github.com/cloudera/hue/blob/b682f4b5c6cccd4ca874cd1b88cb83ca23dfcdf9/desktop/libs/notebook/src/notebook/connectors/flink_sql.py#L291

It is probably a simple mess-up here https://github.com/cloudera/hue/blob/b682f4b5c6cccd4ca874cd1b88cb83ca23dfcdf9/desktop/libs/notebook/src/notebook/connectors/flink_sql.py#L291

Where we use the column names instead of the row values :)

Where we use the column names instead of the row values :)


Fix: graphql-modules did not cleanup on subscription end

Closes https://github.com/n1ru4l/envelop/pull/1629
Closes https://github.com/n1ru4l/envelop/issues/1628

One of the tests had wrong assumptions: https://github.com/n1ru4l/envelop/pull/1630/commits/199e645449013157008edf5227274081006f0b7a
This onSubscription -> (onEnd, onError) fixes the problem, nothing to fix in graphql-modules.

Thanks, @n1ru4l !


[test] Workaround an issue with createDirectory on Linux

Apply the same workaround as we did in indexstore-db. We haven't seen
this particular instance fail, but it theoretically has the same issue
here.
rdar://61545973

https://github.com/apple/indexstore-db/pull/81
@swift-ci please test


Implement context.Database.Log for simple SQL logging

Fixes #1199
Very similar to EF6, except the log level can also be set. For example:
context.Database.Log(Console.WriteLine);

or
context.Database.Log(Console.WriteLine, LogLevel.Information);

Only logs command execution for now, since that's all we have an interceptor for so far.
Uses the EventData.ToString() trick to get the same message formatting as we use for ILogger, but all the information is available to customize the output if needed.

/cc @divega

Finally!!

@ErikEJ I realized last night that now we have interceptors we have the stuff in place to finally do this cleanly!

Don't feel like debating things for now. We can revisit later.

Some comments on this feature from my perspective.
Like JimBobSquarePants (quoted by @divega  in #15888) I believe that making the the SQL produced by EF Core is VERY important. An ORM hides the database so well that developers can write poor performing queries, but being able to see the SQL is a great antidote for those that want to learn.
The other great thing about EF Core's SQL output is it is so readable - it looks like something a human would write. That again is VERY important (In EF6 I gave up trying to understand its SQL output because it was so hard to understand).
An aside: Another aspect of EF Core producing very readable SQL is DBA are less negative when they see EF Core SQL. With EF6's SQL output it just confirmed their view that the ORM is rubbish.
The question I have is: now have two ways of getting the SQL code, ILogger and Database.Log, so which one should people use? I suspect that ILogger will be the main use as it so easy, and turned on by default in ASP.NET Core. Which means what does Database.Log provide over ILogger and where would you use it?
As I understand Database.Log provides access to EventData which would provide the actual values of each parameter when EnableSensitiveDataLogging is turned on. This would allow the reconstitution of the SQL with all data in it so you can paste it into SSMS to profile (I did this with ILogger output but there were limitations  - see #15085). Is there anything else I don't know about?
I hope my ramblings are useful in your deliberations.


Synchronize TrackManager::GetAllTracks

Another attempt at "Crash in CaptureViewElement::UpdateLayout()"
(http://b/208768988).
TrackManager::GetAllTracks() is called on the main thread but accesses
TrackManager::all_tracks_ which is modified from the capture thread through
OrbitApp::OnTimer > TimeGraph::ProcessTimer >
TrackManager::GetOrCreateSchedulerTrack > TrackManager::AddTrack.
https://github.com/google/orbit/pull/3164 tried to do something similar but
didn't consider all_tracks_.
Also remove unused TrackManager::GetThreadTracks, which was also not
synchronized correctly.
Bug: http://b/208768988

Did you measure possible performance regressions?

No, is there a simple way you recommend? But I think it doesn't really matter for this change as we need thread safety first.

Did you measure possible performance regressions?

No, is there a simple way you recommend? But I think it doesn't really matter for this change as we need thread safety first.

Yes, for sure. The priority is to NOT crash.
In --devmode you can see average time to Draw and UpdatePrimitives in the last X calls. I'd try to run the same game in similar conditions and take 3/5 screenshots of these stats and compare average times. This not very precise but simply enough to check about not having 10% performance regression for example.

In --devmode you can see average time to Draw and UpdatePrimitives in the last X calls. I'd try to run the same game in similar conditions and take 3/5 screenshots of these stats and compare average times. This not very precise but simply enough to check about not having 10% performance regression for example.

Ah yes, I remember now. I tried this a bit on Trata, I don't see any difference, or at least we are in measurement error territory.


Docs: Create advanced documentation on how to deal with stuck instances

Part of #1678
We should author some advanced user documentation, similar to k8s.io "Tasks" documentation that describes how to deal with "stuck instances".

this is done


Spring Data Jdbc findAll low performance for native application

Hi,
I faced a performance issue with Spring Data Jdbc with native application. It isn't easy to prepare a demo cause I found this issue in the production code. But I will try to explain.
Let's say I have a simple Spring Data repository:
public interface DemoJdbcRepository extends CrudRepository<DemoEntity, Long> {
        @Query("select d.* from demo_table d where d.status in (:statuses)")
        List<DemoEntity> getDemoByStatusId(@Param("statuses") Set<Integer> statuses);
}

In demo_table I have 600,000 records for searched statuses. For Java applications, this method takes an average of 5 sec. When I switched to the native application, this method took more than 100 sec.
I prepared a flame graph for native application:

Could you please explain if it is expected behavior for native? and maybe we can improve the performance of Spring Data somehow

TypeAndPath spending so much time in equals(…) looks suspicious, especially the fact that it's apparently using MethodHandles under the covers. TAP is a Java record, which means that we don't control how it's implemented. I'll forward this to the GraalVM folks.

thanks for the answers!
I have changed TypeAndPath from record to class:
    static class TypeAndPath {

        private final TypeInformation<?> type;
        private final String path;

        private TypeAndPath(TypeInformation<?> type, String path) {
            this.type = type;
            this.path = path;
        }

        public TypeInformation<?> type() {
            return type;
        }

        public String path() {
            return path;
        }

        public static TypeAndPath of(TypeInformation<?> type, String path) {
            return new TypeAndPath(type, path);
        }

        @Override
        public boolean equals(Object o) {
            if (this == o) return true;
            if (o == null || getClass() != o.getClass()) return false;
            TypeAndPath that = (TypeAndPath) o;
            return Objects.equals(type, that.type) && Objects.equals(path, that.path);
        }

        @Override
        public int hashCode() {
            return Objects.hash(type, path);
        }
    }

and run test again (the same condition as in first comment). I see a huge performance increase (from 100sed to 11 sec):

JVM: ~ 5 sec
Native: ~ 100 sec
Native (TypeAndPath as class): ~ 11 sec

I prepared flame graph as well:

Thanks for the input, that's very helpful. Can you clarify whether you saw the original decreased performance on a GraalVM for JDK 17 or 21?

Originally we found it in 17.
Then I tried 21 (I want to try with G1) but results were almost the same

Would you mind giving the latest snapshots (3.1 or 3.2) a try? I've resolved spring-data-commons#2997, which should also solve the bottleneck in EntityCallbackDiscoverer.

Alright, I consider this fixed then for now. We're going to continue investigating how to reduce the overhead introduced by the PersistentPropertyPath creation, but that doesn't seem to particularly affect the native scenario.


feat: type safety time

Hi @rueian  for the issue of type safety i tried fix but not confident for the change can you look into this? Thanks!

Hi @HoganEdwardChu, thank you for the quick PR. However, we can’t break the current API. This have to be done by adding new functions instead of modifying the old ones. cc @SoulPancake

Codecov Report
Patch and project coverage have no change.

Comparison is base (cd8d23d) 97.49% compared to head (6a84cf1) 97.50%.

:exclamation: Current head 6a84cf1 differs from pull request most recent head d126b52. Consider uploading reports for the commit d126b52 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   97.49%   97.50%
=======================================
  Files          69       69
  Lines       29198    29198
=======================================
+ Hits        28468    28469    +1
+ Misses        612      610    -2
- Partials      118      119    +1

see 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Hi @HoganEdwardChu, thank you for the quick PR. However, we can’t break the current API. This have to be done by adding new functions instead of modifying the old ones. cc @SoulPancake

got it you mean add kind like ExSeconds() right?

PxMillisecondsWithType might be too long. I much prefer something like Px. However, I don't know if it is possible.
Another thing is that I don't think modifying hack/cmds/commands.json is a good idea. We will migrate to the new format of commands.json maintained by Redis org one day and such special changes will be lost and hard to notice.

PxMillisecondsWithType might be too long. I much prefer something like Px. However, I don't know if it is possible.
Another thing is that I don't think modifying hack/cmds/commands.json is a good idea. We will migrate to the new format of commands.json maintained by Redis org one day and such special changes will be lost and hard to notice.

Oh... migrating to new format of commands.json... Maybe in this issue, we can modify commands.json and later i think. we can handle it for another way

Maybe in this issue, we can modify commands.json and make functions with type safety

Okay. But instead of introducing a whole new enum block in commands.json, you should add the four type-safe variants to the original expiration block. In that way, I believe it will much easier to notice these special modifications in commands.json one day when we migrate to the new format.

@rueian thanks i apply it

Seems almost done @rueian ... now we can have type-safety functions for ex, pxat ...

Many thanks @HoganEdwardChu !


optee: fix issue with reading DT at low addresses

OP-TEE had a logical bug where it treated small PAs as parts of special memory regions, where in fact those special memory regions were purely virtual and should not be considered at all.
This patch fixes the issue.

LGTM with a small question.
Reviewed-by: Oleksii Moisieiev<EMAIL_ADDRESS>

Closing as another solution was found.


Nullability of TupleN components

According to the documentation on TupleN.get(int), TupleN components may be null. So I put T? as the return type of componentN() operators on Tuple classes. But using them, in my project, I've found that having to check if they are null while knowing they are non-null is generally annoying in Kotlin.
So I suggest TupleN.componentN()s be all made to return a non-null value. And if a component may be null, then users are expected to use TupleN.get(int) instead where it is clearly marked as @Nullable.
What do you think, @sdeleuze?

As another option, we may omit the return type of the componentN() operators. In that case, the return type will be something like T! rather than T or T?, which means the return type is from Java and may be nullable. But Kotlin doesn't enforce null checks.
FYI, required changes are really trivial, but I plan to issue a PR.

Self resolving this issue. I got interactions between Kotlin's generics and nullability wrong. So my pull request for reactor.util.funtion.TupleNs should have set the return type of componentN()s to just T not T?. In that way, TupleN with nullable components work equally well.
And the above comment was wrong. Actually setting the return types to T doesn't actually differ from leaving it out to be inferred. But specifying T explicitly silences IDEs.
So I'll issue another PR. Sorry for the confusion. Closing this issue.


feat: monoidal category structure on coalgebras

Monoidal category structure on coalgebras, using the definitions in Mathlib.RingTheory.Coalgebra.TensorProduct added in #11975

We make a MonoidalCategoryStruct instance using the definitions from #11975, and upgrade this to a MonoidalCategory instance using Monoidal.induced and the forgetful functor to modules. See #11974 and #11975 for more info on these PRs.

[x] depends on: #11961
[x] depends on: #11966
[x] depends on: #11970
[x] depends on: #11972
[x] depends on: #11974
[x] depends on: #11975

Thanks!
bors merge