feat: explore torch.compile on MLP and other ops

WIP
This PR explores the differences using torch.compile on select ops and starte work on reproducible benches

Please also check tensorrt as backend
I am using it for whisper and it's multiple times faster than assisted generation with distil whisper
I think it was around factor 3 with max autotune

closing in favor of similar work to integrate precompiled mlp (tested in this PR) to llama.
Branch here: https://github.com/huggingface/text-generation-inference/tree/llama-fused-compiled-mlp
PR to follow when stable

Hi, I am still interested in the experiments for compilation of layers to tensorrt.
Could you share some insights why you dropped this feature and the possible speed ups ?


Added support for (Magic Home) Zengge Bulb RGBCW

This add support for the (Magic home) Zengge Bulb RGBCW.

Amazon link: https://www.amazon.com/gp/product/B07GGWNQT7

Thanks for the contribution.


Fix typo in README from Uprade to Upgrade

Fix Typo in README.md

Found a typo in the README.md

Linked Issue

Closes #4810

Thank you for fixing this typo @andrewjymoon, will try to merge it ASAP!

Hi @andrewjymoon, could you give us your first name and last name? Then we can add you to our team page: https://pnp.github.io/cli-microsoft365/about/team/

Merged manually, thank you for fixing this! 👏

Hi @andrewjymoon, could you give us your first name and last name? Then we can add you to our team page: https://pnp.github.io/cli-microsoft365/about/team/

My name is Andrew Moon.

Thank you, welcome to the team! https://pnp.github.io/cli-microsoft365/about/team


[FLINK-4671] [table] Table API can not be built

This PR solves problems introduced by FLINK-3929 / 25a622f. Now the plugin is configured globally. All projects that depend on flink-test-utils should build again.
@mxm what do you think?

Looks good! +1 to merge when the tests have passed.


Reset Optimizations drawer selection

Reset Optimizations drawer selection whenever a new recommendation is displayed.
https://issues.redhat.com/browse/COST-3945

/retry


Placeholders in addition to classes

Hello. Would it be possible to add additional file with placeholders only? So, instead
@extend .col-sm-4;
We could use
@extend %col-sm-4;
Why is that? Well, in less you can import file as reference only, however sass [https://github.com/sass/sass/issues/1317](isn't capable of that %28[see also this]%28https://github.com/sass/sass/issues/320%29%29). Currently I have subpage which requires global css file + specific for this page css file. Now if I import bootstrap in both of them, the code is no longer DRY and precious bandwidth is wasted.
Thanks

My fork resolving this problem
https://github.com/vetalstar/bootstrap-grid-placeholders


add rocksdb compile option

Codecov Report

Merging #528 (43ace3f) into main (9730303) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #528   +/-   ##
=====================================
  Coverage   9.41%   9.41%
=====================================
  Files         52      52
  Lines       7283    7283
=====================================
  Hits         686     686
  Misses      6549    6549
  Partials      48      48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9730303...43ace3f. Read the comment docs.


Use 'wait-on' module to wait for docker-compose

I don't really understand why do you waste your time with changes like these though 🤷 it was already working

Some kind of OCD..


Activate/Deactivate @schedule decorator without changing the code to better support testing/development

We ran into a problem with the @schedule decorator when testing/developing/extending a production flow that is using the decorator.
Problem Description
In production, a pipeline (which also uses the '@project'-decorator) runs to retrieve, process, and send data to a data store. For testing and development, the flow is triggered manually and we use 'current.is_production' to avoid compromising the production data store. Nevertheless, it is problematic that all development/test branches of the flow are scheduled. All branches, including the production branch, start processing at the same time, which leads to a large increase in compute load, incurs costs, and blocks the production flow when we hit the resource limits of our AWS Batch compute environment.
Solution
Introduce an additional attribute active= to the @schedule-decorator and an additional CLI argument to overwrite the attribute when calling step-functions create. Valid values are:
Valid values are:

['off', 'never', 'false']: Schedule off if not activated through CLI step creation process
['on', 'always', 'true']: Schedule on if not deactivated through CLI step creation process
'on_production': Schedule activate when using the production branch (@project -decorator)

The default value of this active attribute is always, so this should not introduce any breaking changes.
I created a fork and implemented it.

@mbrner an alternative solution would be to add a cli arg only to step-functions create like step-functions create --ignore-schedule that will have the same effect as if there was no @schedule decorator specified.


Increase Tensorflow min version to 1.14

tensorboard 1.14 is required to take advantage of Pytorch's exp. implementation of summarywriter.
(It wasn't stable yet when I pushed the Pytorch 1.1 initial commit)

LGTM. Are you trying to replace the Distiller TensorBoard logger with the PyTorch implementation?

@guyjacob Not immediately, I need to try it out first. In theory, it seems like the right way to go hence forth.


Staking. Validator list - double scroll

Description
https://github.com/user-attachments/assets/b7b8a725-efe7-46a2-957b-73e665091334
Environment
https://github.com/novasamatech/nova-spektr/commit/b3a381d4e43fe8ca1218e07e785f903d5eda47a4

Isn't reproduced in 1.11.1


Night is not skipped - 1.19.2

Default config.
2 players on the server.
When 1 is sleeping the night is not skipped.
Is there Any specifics I missed ?

Hi,
Do you install last version?

Yes the one from 5 days ago.
Anything I can do to see more logs ?

OK, I'll test my plugin again and try to find the bug.
Perhaps the error is the same one that I fixed in the last update.
I'll try to fix it when I have free time.

And I have one question. Is the player waiting until the night is skipping?

Yup.
Waiting about 5/10s.
From what understand it is supposed to change after 5s.

 When I fixed the bug for release 2.0.2, I created a new bug and didn't check the release for bugs.
Sorry for my stupidity.

Don't worry, thanks for taking care


Have  these environment variables been added to Airflow's Admin > Variables?

https://github.com/kippchicago/silo-airflow/blob/6ef5eda23e6bb1ced3a57fa214d083856359ce7d/dags/aspen_attendance.py#L36-L37
Those variables must be set in Airflow (i.e., the webserver) by going to Admin > Variables and creating two new variables that match those being accessed in the lines above.

Yes! aspen username and password has been added


Toggle todo view and test

I added the todo view toggle functionality with matching spec tests. Also to get this to work probably I had to change the deprecated activationEvents.
This should close #25 and #46, and remove a little of the deprecated warnings.
@jamischarles; if you grant shared git access I will take care of specs and deprecation warnings coming in up to Atoms major bump at the end of the month.

Thanks. Gave you collaborator rights.

Thank you @jamischarles . I will walk through the current issues I see what I can do.

This also closes #46 .


Added DEFECT issue template

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1067
What are the significant changes in functionality due to this change request?
Added DEFECT and Feature issue template

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test qsubs on 51ee9e2 : invalidated by @alfoa
pylint spurious failure?

Job Test qsubs on 51ee9e2 : invalidated by @alfoa

An issue should be referenced. In addition, I do not see the checklist for this PR.

@wangcj05 added issue and checklist

Checklist is satisfied and this PR can be merged now.


[VM-LinuxDiagnostic] Update help for vm diagnostics

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[x] Each command and parameter has a meaningful description.
[x] Each new command has a test.

(see Authoring Command Modules)

@hosungsmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #3308 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3308   +/-   ##
=======================================
  Coverage   70.28%   70.28%
=======================================
  Files         391      391
  Lines       25095    25095
  Branches     3813     3813
=======================================
  Hits        17638    17638
- Misses       6345     6349    +4
+ Partials     1112     1108    -4

Impacted Files
Coverage Δ

...azure-cli-vm/azure/cli/command_modules/vm/_help.py
100% <ø> (ø)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:arrow_up:

...nent/azure/cli/command_modules/component/custom.py
16.23% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
68.61% <0%> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
35.74% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ffc84...5095c92. Read the comment docs.

@yugangw-msft


window is not defined

I use this plugin for my TypeScript Next.js Sanity project and I'm encountering the following issue. Please help me to address it.
package.json
"sanity-plugin-simpler-color-input": "^2.2.1"
Sanity Config File
import { visionTool } from "@sanity/vision";
import { defineConfig, Slug } from "sanity";
import { structureTool } from "sanity/structure";

// Go to https://www.sanity.io/docs/api-versioning to learn how API versioning works
import { apiVersion, dataset, projectId } from "./src/sanity/env";
import { schema } from "./src/sanity/schema";
import { media } from "sanity-plugin-media";
import { dashboardTool } from "@sanity/dashboard";
import { netlifyWidget } from "sanity-plugin-dashboard-widget-netlify";
import { simplerColorInput } from "sanity-plugin-simpler-color-input";

export default defineConfig({
  basePath: "/studio",
  projectId,
  dataset,
  // Add and edit the content schema in the './sanity/schema' folder
  schema,
  document: {
    productionUrl: async (prev, context) => {
      // context includes the client and other details
      const { dataset, document } = context;
      let resource = document._type || "";
      let slug = (document?.slug as Slug)?.current;

      const params = new URLSearchParams();

      params.set("preview", "true");
      params.set("dataset", dataset);

      if (resource === "tour") {
        resource = "feature-tours";
      }

      if (resource === "page") {
        slug = document?.slug as string;
      }

      return `${window.location.origin}/api/preview?resource=${resource}&slug=${slug}`;
    },
  },
  plugins: [
    structureTool(),
    // Vision is a tool that lets you query your content with GROQ in the studio
    // https://www.sanity.io/docs/the-vision-plugin
    visionTool({ defaultApiVersion: apiVersion }),
    media(),
    simplerColorInput({
      defaultColorList: [
        { label: "Dark Blue", value: "#00488E" },
        { label: "Light Blue", value: "#48A1D9" },
        { label: "Yellow", value: "#FFE926" },
        { label: "Orange", value: "#FF6A31" },
        { label: "Custom...", value: "custom" },
      ],
    }),
  ],
});

schema file
import { defineType, defineArrayMember } from "sanity";

/**
 * This is the schema type for block content used in the post document type
 * Importing this type into the studio configuration's `schema` property
 * lets you reuse it in other document types with:
 *  {
 *    name: 'someName',
 *    title: 'Some title',
 *    type: 'blockContent'
 *  }
 */

export default defineType({
  title: "Block Content",
  name: "blockContent",
  type: "array",
  of: [
    defineArrayMember({
      title: "Block",
      type: "block",
      // Styles let you define what blocks can be marked up as. The default
      // set corresponds with HTML tags, but you can set any title or value
      // you want, and decide how you want to deal with it where you want to
      // use your content.
      styles: [{ title: "Normal", value: "normal" }],
      lists: [{ title: "Bullet", value: "bullet" }],
      // Marks let you mark up inline text in the Portable Text Editor
      marks: {
        // Decorators usually describe a single property – e.g. a typographic
        // preference or highlighting
        decorators: [
          { title: "Strong", value: "strong" },
          { title: "Emphasis", value: "em" },
        ],
        // Annotations can be any object structure – e.g. a link or a footnote.
        annotations: [
          {
            title: "URL",
            name: "link",
            type: "object",
            fields: [
              {
                title: "URL",
                name: "href",
                type: "url",
              },
            ],
          },
          {
            type: "textColor",
          },
        ],
      },
    }),
    // You can add additional types here. Note that you can't use
    // primitive types such as 'string' and 'number' in the same array
    // as a block type.
    defineArrayMember({
      type: "image",
      options: { hotspot: true },
      fields: [
        {
          name: "alt",
          type: "string",
          title: "Alternative Text",
        },
      ],
    }),
  ],
});

Error
ReferenceError: window is not defined
at Object.<anonymous> (/opt/build/repo/node_modules/@uiw/react-color-chrome/cjs/EyeDropper.js:11:73)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Module._load (node:internal/modules/cjs/loader:960:12)
at Module.require (node:internal/modules/cjs/loader:1143:19)
at mod.require (/opt/build/repo/node_modules/next/dist/server/require-hook.js:65:28)
at require (node:internal/modules/cjs/helpers:119:18)
at Object.<anonymous> (/opt/build/repo/node_modules/@uiw/react-color-chrome/cjs/index.js:22:19)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
> Build error occurred
Error: Failed to collect page data for /studio/[[...index]]
at /opt/build/repo/node_modules/next/dist/build/utils.js:1268:15 {
type: 'Error'
}

@trangluong96 Sorry it took me a little bit of time to get to this. This is fixed now in v2.2.2!


Validation issue

Hello,
It seems that there are issues in the validation process, as for an example the below returns True
`from personnummer import personnummer
print personnummer.valid('MASKED')`

pip show personnummer
Name: personnummer
Version: 1.0.2
Summary: Validate Swedish social security numbers
Home-page: http://github.com/personnummer/python
License: MIT
Location: /Library/Python/2.7/site-packages
Requires:
Required-by:

Due to sensitive information MASKED was sent to the repo owner in private.

Hi there!
The code currently validate both "personnummer" and "samordningsnummer" which is a temporary type of personnummer used for none-permanent residents in Sweden.
We have been discussing if we should make this a flag (or rather, making turning it of a flag), but haven't decided yet.
The "samordningsnummer" works as this:
The first four digits (year(2), month(2)) is the same as with a standard personnummer, but the day have 60 added to it. So if it is between 61 and 91, it's a samordningsnummer.
Is your requirement that the code ONLY take personnummer or are samordningsnummer a legal value too?

The value that passed the validity test starts with 07077676XX, i.e. Swedish mobile number.
Not sure if that would go under "samordningsnummer" ?
If parsed as an (int) then I presume the leading 0 would be removed leaving us with 7077676XX but still don't see how it would return as valid.

070776-xxxx would parse as someone born 2017 07 16 and then depending on the last 4 digits, it may or may not be validated by the lunh algorithm. If you use a integer value, it will treat it as 07 yes.

Thanks for the clarification.
But how can 070776 be parsed as 2017-07-16? Shouldn't that parse as 2007-07-76?

Sorry, not 2017, 2007 of course, hehe.
The check we do to validate the "date of birth" is basically to check if it is a valid date and if it is not, we try it with -60 on the days to generate a valid day instead of the samordnings addition to the date. So 76 would be seen as 16 in the date test. That means that any value within the ranges of 1-31 and 61-91 (as long as it is a 31 day long month) is a valid number for the day part of the date.

Ok, I see.
So this was pretty much a coincidence that the last four digits passed the lunh alg as well.
Regarding your discussion to add a flag to exclude samordningsnummer, I think that would be a good addition.

Added flag to exclude samordningsnummer. Not released a new version yet.
https://github.com/personnummer/python/commit/e99cfd501ccae921f0034d729242b424de0e086f


Draft: Adding CountVectorizer & TfidfVectorizer

Adding CountVectorizer and TFIDF Vectorizer very similar to SKLearn's implementation. Based on some work currently being done by @polvalente on Nx to potentially add sparse tensor support (see https://github.com/elixir-nx/nx/tree/pv-proof-of-concept-sparse-torchx) , this would definitely benefit from sparse tensors, but for now I plan on proceeding with dense tensors.
Considering these vectorizers operate on text, perhaps they would best be fit for a standalone NLP library (I have begun scaffolding out a bit of one) but they could also very well fit in here in Scholar.Preprocessing. I'm open to suggestions as to where they best belong.
As of now, I only have finished setting up the options, and building a vocab given the options. I will try to wrap up at least the CountVectorizer by tomorrow night.

@acalejos I would propose to keep this in the NLP library for now. For Scholar, we have been focusing on keeping everything implemented with defn and this is plain not possible here. Also, I can see future interest in implementing this in native code for performance, so I am not even sure if this will survive after some iterations :)

@acalejos I would propose to keep this in the NLP library for now. For Scholar, we have been focusing on keeping everything implemented with defn and this is plain not possible here. Also, I can see future interest in implementing this in native code for performance, so I am not even sure if this will survive after some iterations :)

Makes sense. Appreciate the feedback!


cilium install fails with unrecognized arguments on AKS

The cilium install command seems to expect a specific version of the az CLI, but it fails in a non-obvious way:
$ ./cilium install --agent-image=quay.io/cilium/cilium-ci --operator-image=quay.io/cilium/operator-azure-ci --version="latest"
🔮 Auto-detected Kubernetes kind: AKS
✨ Running "AKS" validation checks
❌ Unable to execute "az version --output json --only-show-errors":
 ERROR: az: error: unrecognized arguments: --only-show-errors
usage: az [-h] [--verbose] [--debug]
          [--output {json,jsonc,table,tsv,yaml,none}] [--query JMESPATH]
          {version} ...

❌ Validation test az-binary failed: unable to execute "az version --output json --only-show-errors": exit status 2
ℹ  You can disable the test with --disable-check=az-binary
↩ Rolling back installation...

Error: Unable to install Cilium: validation check for kind "AKS" failed: unable to execute "az version --output json --only-show-errors": exit status 2
$ az version --output json --only-show-errors
az: error: unrecognized arguments: --only-show-errors
usage: az [-h] [--verbose] [--debug] [--output {json,jsonc,table,tsv,yaml,none}] [--query JMESPATH] {version} ...
$ az version
{
  "azure-cli": "2.0.81",
  "azure-cli-core": "2.0.81",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {
    "azure-devops": "0.17.0"
  }
}

My az version is newer than the version used in CI: https://github.com/cilium/cilium-cli/blob/debe45340bb3d136c8fb54c658d498d09ee3178a/.github/workflows/aks.yaml#L49. So I'm guessing the --only-show-errors flag was deprecated :thinking:

--only-show-errors is still documented in az global parameters in the official doc so I'm not sure what's up 😕

Assigning myself to at least try and reproduce.

@pchaigno are you still seeing this issue? I quickly checked with azure-cli 2.28.0 on my machine and the --only-show-errors flag is still present and is documented in az version --help:
% az version --output json --only-show-errors
{
  "azure-cli": "2.28.0",
  "azure-cli-core": "2.28.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "account": "0.2.1"
  }
}
% az version --help

Command
    az version : Show the versions of Azure CLI modules and extensions in JSON format by default or
    format configured by --output.

Arguments

Global Arguments
    --debug            : Increase logging verbosity to show all debug logs.
    --help -h          : Show this help message and exit.
    --only-show-errors : Only show errors, suppressing warnings.
    --output -o        : Output format.  Allowed values: json, jsonc, none, table, tsv, yaml, yamlc.
                         Default: json.
    --query            : JMESPath query string. See http://jmespath.org/ for more information and
                         examples.
    --subscription     : Name or ID of subscription. You can configure the default subscription
                         using `az account set -s NAME_OR_ID`.
    --verbose          : Increase logging verbosity. Use --debug for full debug logs.

For more specific examples, use: az find "az version"

Please let us know how we are doing: https://aka.ms/azureclihats

Might have been a temporary issue with az version 2.0.81 that you were using?

Might have been a temporary issue with az version 2.0.81 that you were using?

I updated as well and not seeing this issue anymore, so I think you're right. Not sure what they messed up in az :shrug:


%  anchor test error: no such command: build-bpf

I am using MAC M1 and I just installed solana and anchor. No idea how to solve this?
I also tried cargo install solana-cargo-build-bpf
but I got error error: could not find solana-cargo-build-bpfin registrycrates-iowith version*``

What is your solana version?

What is your solana version?

solana-cli 1.13.8 (src:43daa379; feat:1775889670)

What's the output of cargo build-bpf --version? I'd also try with latest solana version(1.14.17).

cargo build-bpf --version

cargo build-bpf --version
error: no such command: `build-bpf`

        View all installed commands with `cargo --list`

Also, I installed solana using sh -c "$(curl -sSfL https://release.solana.com/v1.15.2/install)" How can I choose a later version.

You can change the version in the link to whichever version you want. There is also solana-install init <VERSION> command if you already have solana installed.
This seems like a solana installation issue rather than Anchor issue.
Make sure active release of solana is in your $PATH and try using anchor test --arch sbf since build-bpf is getting deprecated anyway.

@acheroncrypto  We need dfinity ICP smart contract developer would you like to join our team?

Now
solana --version
solana-cli 1.15.2 (src:dea65f48; feat:1211687720, client:SolanaLabs)

but I am still facing the same issue.
Also, anchor test --arch sbf yield
error: Found argument '--arch' which wasn't expected, or isn't valid in this context

  If you tried to supply '--arch' as a value rather than a flag, use '-- --arch'

Usage: anchor test [OPTIONS] [ARGS]... [-- <CARGO_ARGS>...]

For more information try '--help'

Any update on this i  still face same problem

Now
solana --version
solana-cli 1.15.2 (src:dea65f48; feat:1211687720, client:SolanaLabs)

but I am still facing the same issue. Also, anchor test --arch sbf yield
error: Found argument '--arch' which wasn't expected, or isn't valid in this context

  If you tried to supply '--arch' as a value rather than a flag, use '-- --arch'

Usage: anchor test [OPTIONS] [ARGS]... [-- <CARGO_ARGS>...]

For more information try '--help'

It seems there was a misunderstanding. The --arch sbf flag you mentioned is not a valid flag for the anchor test command. for the test environment, you can try this command: anchor test -- --arch sbf  If you encounter any further issues or have additional questions, please let me know

Hey guys,
I am having the same issue.
I have recently installed rustc and solana. I wanted to try out anchor but I am facing this issue building basically the empty project after initialization.
solana-cli 1.16.24 (src:00000000; feat:4033350765, client:SolanaLabs)
rustc 1.75.0 (82e1608df 2023-12-21)
0.29.0	(latest, installed, current)
I installed anchor using avm.
Basically when I execute build I get
error: no such command: build-bpf
View all installed commands with cargo --list
Find a package to install build-bpf with `cargo search cargo-build-bpf
I think this is from package solana-cargo-build-bpf which has been yonked.
Can you please assist?
Thanks and best regards

came across this issue and realized the solana-cli was not being loaded in my env correctly. fixed the path and anchor build runs as expected

my solana version is
solana-cli 1.17.25 (src:d0ed878d; feat:3580551090, client:SolanaLabs)
I found solana installer set the follow line to $HOME/.profile
export PATH="$HOME/.local/share/solana/install/active_release/bin:$PATH"

and this file will be run when you login, so you need to relogin or reboot to make the change effective.


No UI present in xcode 12.1

We used your demo project on Xcode 12.1 (iOS)
No Ui present when tap on any option ;- Web-view, direct or other
Please advice me how we will test those SDKs as sandbox env.
Got Message -:
{
"errMsg" : "Unauthorized - No message available",
"currencyCode" : "344",
"payRef" : null,
"transactionTime" : null,
"descriptionStr" : "",
"src" : null,
"ref" : "1",
"amount" : "1",
"ord" : null,
"authId" : null,
"cardHolder" : null,
"prc" : null,
"maskedCardNo" : null,
"successCode" : "1"
}

Dear merchant,
Can you please provide the pay data and other details? Thanks
Best regards,
Simon Kwok
[AsiaPay Logo]http://www.asiapay.com/
AsiaPay Hong Kong
A Unit 1701-05, 17/F, K. Wah Centre,191 Java Road, North Point, Hong Kong
T +852 3173 1910     F +852 2545 3898
http://www.facebook.com/pages/AsiaPay-Limited/131326772028
[http://edm2.asiapay.com/email_signature/linkedin.png]https://www.linkedin.com/company/asiapay-limited/
[http://edm2.asiapay.com/email_signature/twitter.png]https://twitter.com/asiapay
This message is intended only for the personal and confidential use of the designated recipient(s) named above. If you are not the intended recipient of this message you are hereby notified that any review, dissemination, distribution or copying of this message is strictly prohibited. If you have received this message by mistake please let us know by reply e-mail and then delete it from your system; you must not copy this message or attachment or disclose its contents to anyone.
P Please consider the environment before printing this email
From: MadanIweblcue @.>
Sent: Tuesday, May 4, 2021 5:16 PM
To: asiapay-lib/paysdk-ios-demo @.>
Cc: Subscribed @.***>
Subject: [asiapay-lib/paysdk-ios-demo] No UI present in xcode 12.1 (#2)
**** This is an EXTERNAL email. Exercise caution. DO NOT open attachments or click links from unknown senders or unexpected email. ****
We used your demo project on Xcode 12.1 (iOS)
No Ui present when tap on any option ;- Web-view, direct or other
Please advice me how we will test those SDKs as sandbox env.
Got Message -:
{
"errMsg" : "Unauthorized - No message available",
"currencyCode" : "344",
"payRef" : null,
"transactionTime" : null,
"descriptionStr" : "",
"src" : null,
"ref" : "1",
"amount" : "1",
"ord" : null,
"authId" : null,
"cardHolder" : null,
"prc" : null,
"maskedCardNo" : null,
"successCode" : "1"
}
https://user-images.githubusercontent.com/77271632/116982155-146bd980-ace6-11eb-86ab-18f8056aa620.png
https://user-images.githubusercontent.com/77271632/116982814-e89d2380-ace6-11eb-8554-0b1b7a110651.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/asiapay-lib/paysdk-ios-demo/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANQKODOH2O4D23QCHUEA4IDTL63NBANCNFSM44CKPF4Q.

Dear merchant,
We checked and found that merchant ID 88593126 is belonging to production environment but you request is submitting to UAT environment.
Can you please check? Thanks
@.***D7482C.A93F0740]
Best regards,
Simon Kwok
[AsiaPay Logo]http://www.asiapay.com/
AsiaPay Hong Kong
A Unit 1701-05, 17/F, K. Wah Centre,191 Java Road, North Point, Hong Kong
T +852 3173 1910     F +852 2545 3898
http://www.facebook.com/pages/AsiaPay-Limited/131326772028
[http://edm2.asiapay.com/email_signature/linkedin.png]https://www.linkedin.com/company/asiapay-limited/
[http://edm2.asiapay.com/email_signature/twitter.png]https://twitter.com/asiapay
This message is intended only for the personal and confidential use of the designated recipient(s) named above. If you are not the intended recipient of this message you are hereby notified that any review, dissemination, distribution or copying of this message is strictly prohibited. If you have received this message by mistake please let us know by reply e-mail and then delete it from your system; you must not copy this message or attachment or disclose its contents to anyone.
P Please consider the environment before printing this email
From: MadanIweblcue @.>
Sent: Saturday, May 8, 2021 1:58 PM
To: asiapay-lib/paysdk-ios-demo @.>
Cc: AsiaPay - GitHub @.>; Comment @.>
Subject: Re: [asiapay-lib/paysdk-ios-demo] No UI present in xcode 12.1 (#2)
**** This is an EXTERNAL email. Exercise caution. DO NOT open attachments or click links from unknown senders or unexpected email. ****
Hi Simon Kwok
We already share pay data. we used your iOS demo project and we provide screen shot where you can find all details.
Marchant id, ref no etc and SDK_RSA_PublicKey keys ----
also i will provide two one with your demo account and other with we used in our project.

iOS demo -->
SDK_RSA_PublicKey---> MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3hOz7Ekyf9YLDJ
RzUxJSeFfAxjIW/8Kd8v+tKK/Tc+3KyOHADlV7NYtlGDyoH5dCApUGHrxaYbzV6VzhC+kgQIaL7m
jzMXX2uK03QT8Gmcef4C20fUMpy3hrIRH5MR32THNI3IiQG7upkuKhwQSwvEz0PxTeIznCBvSY/7
wgCC6CUhHt+INZYaYpNRiozy39+yHXvgJu4N+I7VQpXJ6b4QjARk6nq6dBlUge4HokZgQzfKL86P
JfzOjIDDKABkbZcZ96AL48E1jvgXlqV0ZA2k81IEVQzJxEiuERcPpSTXzB9H3f8+sx8DWxUO/CDI
iNI+XOt54sBMelPEFQgEjkCQIDAQAB

merchant id -> "1"
CurrencyCode.HKD

Our project setup -->
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzkBPoAyxHkDnG0bWb4+cw6haVyikQ6kh50wSw5AdVuYXi/+eEK5rC2QRWXw5571FBDx4Un+B0rYYDMYvuMIrS6s50aLHsnnBUP4fv/jAi6lfRb3kA4MjBeOjvAuV2TaiXAoieAIB2lnfxLmaVu/AvljG6G/zUp261cPwm2hjN59a6o3y58TfpRHWBm8ouCFNVbPQr9Zb6MhWdzdztpPS5OEjCr2KhJAppxg5X7H2oxihpcuMlVmKQQdFD4R36hHKbYesaVyzUH/CfK6SwvnVS5k5BNSZPkG5a1MwVle5/cGhyoC1zyOpn1pf2C8y5JnzhGVZh4I+Lc4Fh5c37f+QbQIDAQAB

let paySDK = PaySDK.shared
paySDK.delegate = self
paySDK.isBioMetricRequired = false
paySDK.paymentDetails = PayData(channelType: PayChannel.WEBVIEW,

                                envType: EnvType.SANDBOX,

                                amount :"100",

                                payGate: PayGate.PAYDOLLAR,

                                currCode: .HKD,

                                payType: payType.NORMAL_PAYMENT,

                                orderRef: "2018102409220001",

                                payMethod: "VISA",

                                lang: Language.ENGLISH,

                                merchantId: "88593126",  ///88593126. ///88620594 ///UAT MID 88593126

                                remark: "",

                                payRef: "",

                                resultpage: "F",

                                extraData :[:])

 paySDK.process()

 Please we request check  --> paysdk-ios-demo in Xcode 12.1

 and also check my details and provide solution

 We are waiting your feedback

 Thank You

 Madan Kumawat

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/asiapay-lib/paysdk-ios-demo/issues/2#issuecomment-835125168, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANQKODPKGACZJCHLYLQCLMLTMTHG5ANCNFSM44CKPF4Q.

Hi Simon Kwok
My point is No UI present in Xcode 12.1
Whatever we used  production environment or sandbox.
Can you check how we get SDK default UI when we selected PayChannel.WEBVIEW
Please check with your iOS demo also there is nothing happened when i used any channel with sandbox keys (you are provide with demo project and doc also)
We try with all.
My point how we can show select card and add card details ui for processing payments.
we already share the our code with you with different merchantId ids ----> 88620594
merchantId ids ----> 88155155
Please

Hi,
This is not regarding UI or Xcode 12.1.
For getting SDK default UI for PayChannel.WEBVIEW - after the auth call suceess webview call is called and SDK present the UI.
But in your case Auth call is getting failed so you are getting error as "Unauthorised - message".
I suggest you can use the correct SDK_RSA_PublicKey in the paysdk.plist file for the merchant Id and then make a call it will work for sure.
Thanks.

Hi,
Thank you :)
But now we get other error when create archive with SDK
Please look into ....

Hi,
We or any other merchant not get this kind of error till now. We are also not able to reproduce this issue.
But as per the error description, I think you added the framework explicitly as static library not through pod. So I would suggest you can add it through pod or if you want to add it explicitly then must be added in the Embedded Binaries section under the target.
Can u send me the sample project with the issue then we can help you?


Split Puppet module out of plugins repo

RI, are you open to splitting the Puppet module away from the Choria plugins at all?  I found it hard to build and test #300 internally because the root of the Puppet module is not the root of the Git repository.  Normally I would fork something into our corporate Git Lab, patch and test it here, then push to Github fork to create a Pull Request.
For choria-io/mcollective-choria I had to pull just the 'module' subdir into our Git Lab, patch it, test it on a Master with r10k (which broke because all the plugin files had suddenly gone missing), then copy the changes back into a different module that was a true fork of choria-io/mcollective-choria in order to create the PR. I'd also be able to write Puppet Rspec tests for it and separate them from the Ruby plugin code.
Of course if it's just me that has this problem, it might not be worth the effort.

It's a bit of a weird one because primarily this project is a ruby project and thats just how it is, so should I move those into the module - it becomes almost impossible to do the ruby dev correctly.
I can split the module - but then you'll still be faced with having to combine these ruby bits with the module.  Not really a great solution to the problem.
Fwiw I think the federation broker stuff being here is just the wrong place, a new fed broker is under development written in Go and it will get its own module or go into the main mcollective module (which will probably merge with this one)
So I don't know, I'd like to make it easier but with how things are its hard and I know I have some big restructuring coming up with new NATS based network broker + Fed Broker combination in a 'choria' binary, same binary will eventually replace the ruby mcollectived.
This binary is already quite far along so I'd likely hold off doing this till thats ready.  Will keep this one open to remind me

That makes sense. If  this is 90% Ruby Choria and 10% Puppet it's probably not doing work to separate things.  Your Ruby-Fu is better than mine - is it possible to run append some Puppet Rspec tests from inside the module directory? That way if I send any more PRs I'm flying less blind :-)

You could add some normal rspec puppet stuff yes and then add a rake task to run those specifically and also add it as a dependency to the release task.
tbh though, this module should just be init.pp, federation should become a module on its own, will do that soon with the go stuff, so I wouldnt spend too much time on it if I was you :)

OK I'll leave it then.


Development server loses self-signed certificate

Command
serve
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
Angular v16
Description
I have an HTTPS project with a self-signed certificate. If I load the Angular SPA, I accept the certificate in the browser (Chrome). The website now works for a short time. After a few seconds, the browser loses the certificate and you have to accept it again. Lazy modules are not loaded anymore. In the example project you have to reload the page to see the problem.
The following steps have not brought any improvement:

other browser (Firefox, Edge)
esbuild with Vite server and webpack
own self-signed certificate stored

Minimal Reproduction
Github project for reproduction
I have done the following steps:

Installed Angular 16
Update to Angular 17 with the commands:
npx @angular/cli@17 update @angular/core@17 @angular/cli@17
npx @angular/cli@17 update @angular/material@17
SSL activated in the Angular.json

Exception or Error
app-routing.module.ts:73 GET https://localhost:4200/cameras.module-FLNCHSAM.js net::ERR_CERT_AUTHORITY_INVALID
(...)
app-routing.module.ts:73 ERROR TypeError: Failed to fetch dynamically imported module: https://localhost:4200/cameras.module-FLNCHSAM.js

Your Environment
Angular CLI: 17.0.0
Node: 20.9.0
Package Manager: npm 10.1.0
OS: win32 x64

Angular: 17.0.1
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0
@angular-devkit/build-angular   17.0.0
@angular-devkit/core            17.0.0
@angular-devkit/schematics      17.0.0
@angular/cli                    17.0.0
@schematics/angular             17.0.0
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?
Google Chrome Version 119.0.6045.107 (Offizieller Build) (64-Bit)

Hi @Fab1anB, I am unable to replicate this with the reproduction provided.
It's worth mentioning that the Angular CLI is does not create/manage self-signed certificates as these are generated by Vite and Webpack-dev-server.

Thank your for your response @alan-agius4. I gave it another try with the repository I provided. The effect took longer, but I got the same problem after waiting two minutes and pressing F5 (refresh).
The webpack-dev-server dependency of @angular-devkit/build-angular just had minor update ( '4.15.0' to '4.15.1') between Angular16 and Angular17
However if you are sure it has nothing to do with angular-cli then I will open an issue there. I just wondered how both  vite-server and webpack-server create the same problem.

Hi @Fab1anB,
It happens that I left the app running and after 39 minutes I am still not able to replicate the issue. Can you check the expiry of the self signed certificate? I also would suggest that you try to run the app in incognito mode and see if the issue persist.
It is indeed strange the both vite dev-server and webpack-dev-server result on the same broken result, for this case I suspect it's more of a local environment issue.

It looks like you are right @alan-agius4 at least with my MacBook I could not reproduce this issue as well. I will try it again on other computer for some times and close the issue then.
Thank you for your time and effort.

I found the problem. It has nothing to do with angular cli. Google Chrome received an update, where they removed the "allow-insecure-localhost"-flag as of Chrome 119.
As others got the same problem maybe it helps someone when he accidentally comes over this page.
See more here: https://support.google.com/chrome/thread/241869686/allow-insecure-localhost-has-been-removed-as-of-chrome-119?hl=en


convert_nt_to_hf is broken for non-interleaved RoPE

https://github.com/huggingface/nanotron/blob/51ca40bc5e1b1f5dcb55eaeb0b6f86dda03f3979/examples/llama/convert_nanotron_to_hf.py#L34-L39
This code should not be executed if the model uses non-interleaved RoPE.

Hi, you can check #174 too 👀


xWebAppPool should be able to specify Managed Pipeline Mode

I'd like to see a ManagedPipelineMode property on the xWebAppPool resource with values 'Classic' and 'Integrated'.
This could be done by checking the value of the 'managedPipelineMode' property of IIS:\AppPools$Name and setting it accordingly.

Added in #77.


Add F14 Tomcat from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of LuizChacon, to add F14 Tomcat to CKAN.
Please direct questions about this pull request to LuizChacon.

http://pastebin.com/SByaWrQs
Not clear on the firespitter pack distinctions, so went with the full install.

It only needs the FS Core plugin :)


Rename store.js to configureStore.js to prevent conflict

There is an npm moduel called storeJS
If this module is installed, it will create conflict with the store.js in the app folder due to the alias.
import store from 'store';

@howardya, thanks! If you're still in the mood of contributing, please, also rename store to configureStore in every file that requires it, e.g. app/containers/LanguageProvider/tests/index.test.js and in template folder (internals/templates/store.js)

@KarandikarMihir Please see PR #1904. Hope it is fine.

Closing in favor of #1904


[v2] Default values for nested class

If an Astro Class nests another Astro Class, the default has to be defined on the parent class with defaults for each field again. Is this designed this way or a bug?
Example:
Parents = new Mongo.Collection('parents');

Child = Astro.Class.create({
  name: 'Child',
  fields: {
    name: {type: String, default: 'Untitled'},
    age: {type: Number, default: 18}
  }
});

Parent = Astro.Class.create({
  name: 'Parent',
  collection: Parents,
  fields: {
    name: {type: String, default: 'Supa Parent'},
    children: {
      type: Child,
      default() {
        return {name: 'Untitled', age: 18};
      }
    }
  }
});

If the default for children field is removed, the defaults from ChildClass aren't applied. This essentially makes it useless to define defaults in ChildClass itself. I think there are a few edge cases here.
Would like to hear more thoughts on this.

I've tested it and it's working, so you're probably doing something wrong

Here is how it's playing for me:
Parents = new Mongo.Collection('parents');

Child = Astro.Class.create({
  name: 'Child',
  fields: {
    name: {type: String, default: 'Untitled'},
    age: {type: Number, default: 18}
  }
});

Parent = Astro.Class.create({
  name: 'Parent',
  collection: Parents,
  fields: {
    name: {type: String, default: 'Supa Parent'},
    children: {
      type: Child,
      default() {
        return {name: 'Untitled', age: 18};
      }
    }
  }
});

With this, everything works out as expected, defaults applied from Parent Class.
Now with that block removed:
Parents = new Mongo.Collection('parents');

Child = Astro.Class.create({
  name: 'Child',
  fields: {
    name: {type: String, default: 'Untitled'},
    age: {type: Number, default: 18}
  }
});

Parent = Astro.Class.create({
  name: 'Parent',
  collection: Parents,
  fields: {
    name: {type: String, default: 'Supa Parent'},
    children: {
      type: Child
    }
  }
});

I get this:
_class {error: "validation-error", reason: ""children" is required", details: Array[1], message: ""children" is required [validation-error]", errorType: "Meteor.Error"}

Here is the code I used in console to test this out:
var myParent = new Parent();
myParent.save();

The nested field is same as any other field so it requires default value. This haven't changed from 1.0, so that's why it's saying it's required. Astronomy won't put a nested object in there because you may want to leave is undefined or null. What you have to do is:
Parents = new Mongo.Collection('parents');

Child = Astro.Class.create({
  name: 'Child',
  fields: {
    name: {type: String, default: 'Untitled'},
    age: {type: Number, default: 18}
  }
});

Parent = Astro.Class.create({
  name: 'Parent',
  collection: Parents,
  fields: {
    name: {type: String, default: 'Supa Parent'},
    children: {
      type: Child,
      default() { return {}; }
      // OR
      default() { return new Child(); }
    }
  }
});

Thanks, my bad.
I forgot I could do new Child()


Initial code format

Before I start documenting functions using NatSpec format we need to agree on common code style and format. See if you like  an example of IBZx.sol interface format.
Please suggest any style changes you would like. currently those are default

The formatting in IBZx.sol is inconsistent. For some functions "external" is on a newline and for others it's not.

will try again in different branch


fix: address pydantic validation errors during ollama LLM invoke requests

This PR resolves a pydantic validation issue encountered when invoking Ollama’s LLM generation requests, and addresses issue #366
This PR resolves a pydantic validation issue encountered when invoking Ollama’s LLM generation requests. Previously, the format field for GenerateRequest strictly required a literal value of 'json'. When the format field was omitted or passed as an empty string, Pydantic validation failed, producing errors similar to the following:
pydantic_core._pydantic_core.ValidationError: 2 validation errors for GenerateRequest
format.literal['json']
  Input should be 'json' [type=literal_error, input_value='', input_type=str]

format.dict[str,any]
  Input should be a valid dictionary [type=dict_type, input_value='', input_type=str]

By expanding the format union type to include both the empty string '' and 'json' values, the request validation now passes even when format is not explicitly defined or is empty. This change ensures that developers have more flexibility in specifying their request parameters and that the underlying validation does not fail in cases where format is absent or intentionally left blank.
Key Changes:

Updated the format field from Optional[Union[Literal['json'], JsonSchemaValue]] to Optional[Union[Literal['', 'json'], JsonSchemaValue]].
Ensured that requests with an empty format do not cause validation errors.

Thank you for raising this pull request

Thanks so much for the PR! I've fixed it in a few other places as well in https://github.com/ollama/ollama-python/pull/369 for expediency.


add EntryCompletion.Connect

if i`m not mistake, EntryCompetion should have Connect method.

Thanks your p-r. But this fix should be extends of GObject.


Add files via upload

Issue reference:
Proposed changes:
Type of change:
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Additional info (if any):

Wah bhai Bau fast ne
On Sun, 23 Oct 2022 at 15:07, Raj Varsani @.***> wrote:

Merged #246 https://github.com/RajVarsani/html-archives/pull/246 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/RajVarsani/html-archives/pull/246#event-7648055942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXRQLPSC4LXAHY7OWNTOBHLWEUBNBANCNFSM6AAAAAARMG3KEE
.
You are receiving this because you were mentioned.Message ID:
@.***>

hosiyar thai gayo chee
On Sun, 23 Oct 2022 at 15:07, Sajan Pande @.***> wrote:

Wah bhai Bau fast ne
On Sun, 23 Oct 2022 at 15:07, Raj Varsani @.***>
wrote:

Merged #246 https://github.com/RajVarsani/html-archives/pull/246 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/RajVarsani/html-archives/pull/246#event-7648055942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXRQLPSC4LXAHY7OWNTOBHLWEUBNBANCNFSM6AAAAAARMG3KEE
.
You are receiving this because you were mentioned.Message ID:
@.***>


test: fix a flaky test

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

It is a test flakiness not a service end issue, that it uses the current time to calculate the cred valid length, which is wrong.


A Better Name for Blueprints?

I'm assuming you went with "blueprint" to avoid confusion with Unity's own Prefabs, but a blueprint is essentially a prefab for an entity in Unity. So why not call them EntityPrefabs or EntitasPrefabs instead? Seems like a much more intuitive & descriptive title that would let Unity developers quickly grasp their purpose. Just a thought.

I have now discovered that blueprints were actually contributed by @npruehs. Apologizes. I'm something of a newbie here. :$

No offense taken :) The name is actually quite "old", and has been developed by our team a few years ago. You can find more details about the idea here: https://github.com/SlashGames/slash-framework/wiki/Entity-Blueprints
However, with the advent of Unreal's blueprints, which are something completely different, a name change sounds perfectly reasonable!

@npruehs I have no problem with the name blueprint itself or it's similarity to Unreal. Although it's interesting to know you came up with it first.  :) Anyway, it's more about naming consistency within Unity to make it as intuitive as possible for developers. However, this could all just be consider me nick picking.
In any case, I do love the concept behind blueprints. I think anything that helps integrate ECS into the Unity workflow is essential to getting more developers to embrace. So thanks for your contributions!

Entity Templates?  We can use it as a template and add features to the entity itself later.

@WoLfulus My first idea here was to make blueprints more consistent with Unity terminology by changing them to "prefabs". However, I'm now wondering if that might only create possible confusion between Unity prefabs and Entitas prefabs. So maybe using different terms (blueprints/templates vs prefabs) is actually a good thing...

I thought about that, and I know I'd be confused myself with that. That's why I suggested templates instead of prefabs.

Ironically, I now realize I wanted to change the term "component" for the exact opposite reason! D'oh!! In any case I'm thinking maybe we should at least prefix whatever term used with "Entity" e.g. "EntityBlueprint". Or would that just add needless term bloat?

While I love talking about the smallest details and good names, I think blueprint is fine. Maybe it's just me, but I think it's kinda clear what it means, no confusion with Prefabs, no prefix EntityXyz needed. In the end, blueprints are just configuration. It can be json, flatbuffers, or any other data format. For the Unity integration I used a binary format as proof of concept. It can also be used in a pure c# project. I wish blueprints would have a higher priority for me, but atm there are many things happening with Entitas and I think I won't be touching blueprints anytime soon. I hope that's ok.

tbh, I also think "Blueprint" is fine. In fact I prefer it that way.


[Feature] Add ?path= query parameter to improve Deno/importMap compatibility

Hi! Love the project!
I'm really hoping to turf NPM and build system complexity often required for consuming third-party libraries (especially in the front-end). esm.sh really helps with that.
My use case: I'm really interested in the idea of using Deno + esm.sh as a build system for front-end projects.
I'm using an importMap to resolve named dependencies - a feature which I think has a non-zero chance of becoming a future ecmascript standard. It isn't strictly necessary but many existing files use this style so it's useful to try and support it.
import Button from '@mui/material/Button';

With imports.json
{
  "imports": {
    "@mui/material/": "https://esm.sh/<EMAIL_ADDRESS>  }
}

This works fine with Deno. The only problem is that esm.sh detects the Deno UA and (appropriately) I end up building a version for the Deno runtime - not the browser. No problem, I just need to specify ?target=esnext. The only problem now is that in so doing (or adding any query string parameters), imported paths are no longer constructed correctly. @mui/material/Button becomes https://esm.sh/@mui/material@5.3.0/?target=esnextButton
My suggestion would be to simply add support for a ?path query string parameter (or ?subpath?) which would be appended (if specified) to the url path to determine the path of the requested resource.
So
https://esm.sh/@mui/material@5.3.0?target=esnext&path=/Button
would be equivalent to
https://esm.sh/@mui/material@5.3.0/Button?target=esnext

@pauljoey this looks great, i will add this feature asap

added in v65


Being able to remove the table button from the WYSIWYG editor

With an extension you can easily change the button sets used in the WYSIWYG editor.
For example:
const { Component } = Shopware;

Component.override('sw-text-editor', {
    props: {
        buttonConfig: {
            type: Array,
            required: false,
            default() {
                return [
                    {
                        type: 'paragraph',
                        title: this.$tc('sw-text-editor-toolbar.title.format'),
                        icon: 'default-text-editor-style',
                        children: [
                            {
                                type: 'formatBlock',
                                name: this.$tc('sw-text-editor-toolbar.title.paragraph'),
                                value: 'p',
                                tag: 'p'
                            },
                       ]
                    },
                ];
            }
        }
    }
});

However removing the table button isn't that straigthforward since it's not part of the default buttonConfig. When I look at this line and debug it it seems $options is never set making it hard to influence. See:
https://github.com/shopware/platform/blob/3473869ee32449ea74d6b11596ab7dc7bc28eb12/src/Administration/Resources/app/administration/src/app/component/form/sw-text-editor/index.js#L352
Could the table button be moved to the default buttonConfig?

Duplicate


.d.ts, upgrade to Typescript

Could this lib be upgraded to Typescript? We are putting a lot of ;any everywhere and without types we are having a harder time seeing bugs.

You can track the progress of TypeScript support via #27


Updating author

Docs Build status updates of commit ecf0ae4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/device-portal-api-reference.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Remove trailing \n in toml front matter

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Cyril Romain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

FYI, I do accept CLA, not the assistant to access my account.
I'm a GitHub user, just commited with my public email.
Feel free to cherry pick.

@bep wouldn't users add a new line content anyways?

@digitalcraftsman Yes, I think we can close this one. It looks like a preceding newline to me, but that doesn1t matter. @cyrilRomain thanks for the contribution, but I think we'll stick with what we got.

The patch actually removes the trailing empty line inserted inside the toml front matter, when the "hugo new" is called, i.e. right before the closing +++.
IHMA to be consistent with YAML front matter, that newline shoud be removed from toml front matter or added to yaml front matter.


[IMP] Added OS requirements for Debian Wheezy.

OS requirement adaptation for Debian Wheezy... truly better than fuckbuntu... ;)

Sorry, I don't quite follow.

truly better than fuckbuntu... ;)

Mind to elaborate?

@hackebrot I was joking :wink:
Of course I respect all the Ubuntu users and their choice of use a worst debian-like distribution than Debian... Really, I'm joking again. I'm not trying to create any conflict at all :yum:

@ddiazpinto, thank you for your pull request. Until now Ubuntu has done perfectly well. This pull request adds an additional burden of ongoing maintenance to the core contributors. I don't see why we should switch based on a single contributor's personal preference.
One more thing, while it wasn't in the README when you submitted your pull request, we now list our Code of Conduct. This pull request is trolling Ubuntu users, which violates our Code of Conduct.
Please don't troll this project again, I have and will kicked contributors from projects before. I welcome your contributions, even for Debian, but not ones implemented with such negative intent.


typo fixed

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

@Toshik
Could you also remove duplicate it on line 65 ?

@mrbean-bremen @H1Gdev fixed, thanks for heads up


In-app browser doesn't connect wallet with aedictive app

Describe the bug
In-app browser doesn't connect wallet with aedictive app on iphone / android
To Reproduce
Steps to reproduce the behavior:

Go to in-app browser and put into url https://aedictive-dev.aepps.com/
Click on connect wallet button
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: iphone, android

Additional context
reproducible on prod

retested, working properly


Refine access control to strip out data a user shouldn't have.

I have some methods where the results of a request are dependent on the user's role, e.g. anyone with the VIEW_OWN_DETAILS role should only be able to view their own personal/project/workplace details, but anyone with the PROJECT_ADMIN role may view every employee visible with the project(s) they administer. However, PROJECT_ADMIN users should not be allowed to view any other projects.
This is currently not the case: they can view everything that isn't specifically locked down for admin/board access only. Furthermore, the employee's security level is ignored.

I've run into an issue: the test.ldif file gives the users names (e.g. ajensen451), but the database uses a numeric id. The easiest way to reconcile this is map the user IDs in the ldif to the database...which means duplicating users between that and the database.
I think I may need to remove the LDAP completely. It was good for educational purposes, but it just won't work.

For projects, I've settled on allowing unauthorised users to view the ID, security level, and title.


Add the user table to the KPI download

Changes in this PR

add users table download in JSON to /admin

Screenshots of UI changes
Before

After

 Add the user table to the KPI download

@EdwinKruglov can you add this change to the CHANGELOG list for specify and include the #ref to the PR 👍🏼


Added OS check

02_JMod run fix

Tested and working now for Windows10.

@kwahsog merge conflict, due to merging other PRs - sorry about it

@kwahsog Still conflicting.

@kwahsog fixed

@kwahsog Can I please ask you to paste the output of the script, before I merge it, just for posterity reasons. Thanks

@kwahsog : just  ran below:
christoff.smith@ChristoffS-PC MINGW64 /c/projects/jdk9-jigsaw/session-2-jlink/01_JLink (jdk9-jigsaw-fix-2)
$ ./link.sh
*** Removing any existing greetings.jmod ***
*** Creating a module (greetings.jmod) from multiple modules / packages / classes with jlink. ***
*** Enlisting the contents of the module (greetings.jmod) ***
classes/module-info.class
classes/com/greetings/Main.class
classes/org/astro/World.class
*** Currently JMOD files can be used at compile time and link time, but not at run time. ***
*** Read further about JMod files at http://openjdk.java.net/jeps/261#Packaging:-JMOD-files ***

I see master has been fixed. Closing


unable to install saleor on redhat linux, keep getting Building wheel for uwsgi (setup.py) ... error

I created a Python virtual environment with version 3.7.3, and also tested with Python version 3.6.8
then I updated pip
install python -m pip install -U pip
and also install cairocffi and measurement
pip install cairocffi
pip install measurement

but I keep getting the wheel  error when installing saleor with this command:
pip install -r requirements.txt
below is the detailed error log, any ideas what I am missing?
Building wheel for uwsgi (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /home/webroser/virtualenv/saleor/3.7/bin/python3.7_bin -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"'; __file__='"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-mc4lmcjr
       cwd: /tmp/pip-install-1z2lkygu/uwsgi/
  Complete output (38 lines):
  /opt/alt/python37/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'descriptions'
    warnings.warn(msg)
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib
  copying uwsgidecorators.py -> build/lib
  installing to build/bdist.linux-x86_64/wheel
  running install
  using profile: buildconf/default.ini
  detected include path: ['/usr/lib/gcc/x86_64-redhat-linux/4.8.5/include', '/usr/include']
  Patching "bin_name" to properly install_scripts dir
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-install-1z2lkygu/uwsgi/setup.py", line 138, in <module>
      'Programming Language :: Python :: 3.6',
    File "/home/webroser/virtualenv/saleor/3.7/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
      return distutils.core.setup(**attrs)
    File "/opt/alt/python37/lib64/python3.7/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/opt/alt/python37/lib64/python3.7/distutils/dist.py", line 966, in run_commands
      self.run_command(cmd)
    File "/opt/alt/python37/lib64/python3.7/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/webroser/virtualenv/saleor/3.7/lib/python3.7/site-packages/wheel/bdist_wheel.py", line 215, in run
      self.run_command('install')
    File "/opt/alt/python37/lib64/python3.7/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/opt/alt/python37/lib64/python3.7/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/tmp/pip-install-1z2lkygu/uwsgi/setup.py", line 79, in run
      uc.build_uwsgi(conf)
    File "/tmp/pip-install-1z2lkygu/uwsgi/uwsgiconfig.py", line 276, in build_uwsgi
      t.start()
    File "/opt/alt/python37/lib64/python3.7/threading.py", line 847, in start
      _start_new_thread(self._bootstrap, ())
  RuntimeError: can't start new thread
  ----------------------------------------
  ERROR: Failed building wheel for uwsgi
  Running setup.py clean for uwsgi
Failed to build uwsgi
Installing collected packages: uwsgi, weasyprint
    Running setup.py install for uwsgi ... error
    ERROR: Command errored out with exit status 1:
     command: /home/webroser/virtualenv/saleor/3.7/bin/python3.7_bin -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"'; __file__='"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-uwt4a0jj/install-record.txt --single-version-externally-managed --compile --install-headers /home/webroser/virtualenv/saleor/3.7/include/site/python3.7/uwsgi
         cwd: /tmp/pip-install-1z2lkygu/uwsgi/
    Complete output (25 lines):
    /opt/alt/python37/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'descriptions'
      warnings.warn(msg)
    running install
    using profile: buildconf/default.ini
    detected include path: ['/usr/lib/gcc/x86_64-redhat-linux/4.8.5/include', '/usr/include']
    Patching "bin_name" to properly install_scripts dir
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-1z2lkygu/uwsgi/setup.py", line 138, in <module>
        'Programming Language :: Python :: 3.6',
      File "/home/webroser/virtualenv/saleor/3.7/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
        return distutils.core.setup(**attrs)
      File "/opt/alt/python37/lib64/python3.7/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/opt/alt/python37/lib64/python3.7/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/opt/alt/python37/lib64/python3.7/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/tmp/pip-install-1z2lkygu/uwsgi/setup.py", line 79, in run
        uc.build_uwsgi(conf)
      File "/tmp/pip-install-1z2lkygu/uwsgi/uwsgiconfig.py", line 276, in build_uwsgi
        t.start()
      File "/opt/alt/python37/lib64/python3.7/threading.py", line 847, in start
        _start_new_thread(self._bootstrap, ())
    RuntimeError: can't start new thread
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/webroser/virtualenv/saleor/3.7/bin/python3.7_bin -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"'; __file__='"'"'/tmp/pip-install-1z2lkygu/uwsgi/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-uwt4a0jj/install-record.txt --single-version-externally-managed --compile --install-headers /home/webroser/virtualenv/saleor/3.7/include/site/python3.7/uwsgi Check the logs for full command output.

Have you tried installing locally using docker?  Could be a better way to run the same on redhat.


Inheritance breaks Optional

In the following code, foo has an Optional[A] argument and does a check on it to see if is None or defined:
class A:
    pass

def foo(maybe_a: Optional[A]):
    if maybe_a:
        print("maybe_a is defined")

foo(A())

This works, and correctly prints "maybe_a is defined".
However, if class a class B is defined and inherits from A, the exact same code will break at compile time:
class A:
    pass

class B(A):
    pass

def foo(maybe_a: Optional[A]):
    if maybe_a:
        print("maybe_a is defined")

foo(A())

internal.codon:364:16-49: error: '__internal__' object has no method 'class_raw_rtti_ptr' with arguments ()
├─ optional.codon:25:20-53: error: during the realization of opt_ref_bool_rtti(what: Optional[class_ctr[...,...]], T: class_ctr[...,...])
├─ optional.codon:43:16-30: error: during the realization of __has__(self: Optional[A])
├─ test.py:8:5-54: error: during the realization of __bool__(self: Optional[A])
╰─ test.py:11:1-4: error: during the realization of foo(maybe_a: Optional[A])

This breaks also with other types of checks: maybe_a is not None and maybe_a != None

Looks like a bug. Will take a look!


deprecate vagrant cluster providers

We need to move everyone over to the containerized providers. Direct usage of vagrant for development should be deprecated.

It looks like docs/env-providers.md and docs/getting-started.md are a bit out of date.
For the benefit of anybody wondering how to move away from Vagrant. We currently have two providers that can be set using the PROVIDER env var:
export PROVIDER=os-3.9.0-alpha.4
export PROVIDER=k8s-1.9.3

Depending on if you're looking to deploy an OpenShift or pure Kubernetes environment.

in hack/config-default.sh we have: kubeconfig=cluster/vagrant/.kubeconfig
should we change that?

@yuvalif good catch. We should just remove that line. Every provider overrides that with its own value. The "default" value is never used.

Can this be closed @stu-gott ?

It can.


Returns rejected promise promise when config.greed = bad

This library rejects the promise when you set promise config.greed = bad (ref), but the fetch specification states:
The Promise returned from fetch() won't reject on HTTP error status even if the response is a HTTP 404 or 500. Instead, it will resolve normally, and it will only reject on network failure, or if anything prevented the request from completing.

https://github.com/github/fetch#caveats
We should just resolve as normal here.

To be honest, I'm not sure how useful being able to configure bad responses is. greed: 'good' is a feature I use from time to time, and it's also useful to be able to let unmatched requests pass through to native fetch. greed: 'bad' is only there for completeness really. I don't see it as running contrary to the fetch spec though: fetch 'will only reject on network failure, or if anything prevented the request from completing.' So greed: bad kinda equates to the worst case scenario fora fetch request.
I could add the ability to configure the behaviour more precisely e.g greed: {status code}, and will leave this issue open to see if anyone else wants the feature. Personally I think if the developer cares that much about status codes returned by the fetch calls in their test, then they should probably be mocking those calls individually or with some predefined routes.

I decided against using fetch, I was having too much friction trying to mock it out in tests. You make a good point about the network failure, though.


Conflict with firestack

What went wrong:
Execution failed for task ':app:packageAllDebugClassesForMultiDex'.
> java.util.zip.ZipException: duplicate entry: com/google/android/gms/location/places/PlaceReport.class

I suspect that there is a version conflict of the  com.google.android.gms versions used by firestack and google-place-picker, respectively.
firestack: compile 'com.google.android.gms:play-services-base:+'
google-place-picker: com.google.android.gms:play-services-location:8.4.0

#16

see also #10


Schedule Task in ThreadPool

This introduces scheduling of tasks with dependencies to ThreadPool.
Contrary to work items, tasks are only queued for execution after all
their dependencies have completed.

@wally-the-cartographer merge

Merge requested by authorized user cschuet. Merge queue now has a length of 1.


[WIP] stage1/init: leave privileged pods without stage2 mount-ns

Do not merge: still checking if this is the right way to fix https://github.com/coreos/rkt/issues/3272

This PR removes MountFlags property from stage2 apps in pods
running with --insecure-options=paths.
This will leave the service without any properties with a mount-ns
requirement, so that stage2 rootfs can be nicely degraded to a chroot
with full mount propagation.
Fixes: https://github.com/coreos/rkt/issues/3272

@lucab It doesn't seem to work in conjunction with volumes:
Without volumes
$ sudo ./rkt run --stage1-path=`pwd`/stage1-kvm-qemu.aci --insecure-options=image,paths docker://debian:8 --exec /bin/bash -- -c "findmnt -o SOURCE,TARGET,FSTYPE,PROPAGATION"                                                   image: using image from file /home/uqtdettr/workspace/rkt/build-rkt-1.17.0+git/target/bin/stage1-kvm-qemu.aci
image: using image from local store for url docker://debian:8
networking: loading networks from /etc/rkt/net.d
[    1.112499] debian[135]: SOURCE                               TARGET                 FSTYPE   PROPAGATION
[    1.112686] debian[135]: /dev/root[/opt/stage2/debian/rootfs] /                      9p       shared
[    1.112807] debian[135]: devtmpfs[/null]                      |-/dev/null            devtmpfs shared
[    1.112912] debian[135]: devtmpfs[/zero]                      |-/dev/zero            devtmpfs shared
[    1.113070] debian[135]: devtmpfs[/full]                      |-/dev/full            devtmpfs shared
[    1.113172] debian[135]: devtmpfs[/random]                    |-/dev/random          devtmpfs shared
[    1.113277] debian[135]: devtmpfs[/urandom]                   |-/dev/urandom         devtmpfs shared
[    1.113381] debian[135]: devtmpfs[/tty]                       |-/dev/tty             devtmpfs shared
[    1.113494] debian[135]: devtmpfs[/net/tun]                   |-/dev/net/tun         devtmpfs shared
[    1.113601] debian[135]: devtmpfs[/console]                   |-/dev/console         devtmpfs shared
[    1.113714] debian[135]: proc                                 |-/proc                proc     shared
[    1.113840] debian[135]: tmpfs                                |-/dev/shm             tmpfs    shared
[    1.113959] debian[135]: devpts                               |-/dev/pts             devpts   shared
[    1.114095] debian[135]: tmpfs[/systemd/journal]              |-/run/systemd/journal tmpfs    shared
[    1.114219] debian[135]: sysfs                                |-/sys                 sysfs    shared
[    1.114339] debian[135]: proc[/sys/kernel/hostname]           |-/etc/hostname        proc     shared
[    1.114468] debian[135]: tmpfs[/systemd/notify]               `-/run/systemd/notify  tmpfs    shared
[    1.953067] reboot: Restarting system with command '<rkt: obligatory restart>'

With Volumes
$ sudo ./rkt run --stage1-path=`pwd`/stage1-kvm-qemu.aci --volume data,kind=empty,readOnly=false --mount volume=data,target=/data --insecure-options=image,paths docker://debian:8 --exec /bin/bash -- -c "findmnt -o SOURCE,TARGET,FSTYPE,PROPAGATION"
image: using image from file /home/uqtdettr/workspace/rkt/build-rkt-1.17.0+git/target/bin/stage1-kvm-qemu.aci
image: using image from local store for url docker://debian:8
networking: loading networks from /etc/rkt/net.d
[    1.029616] debian[139]: SOURCE                                    TARGET                 FSTYPE   PROPAGATION
[    1.029964] debian[139]: /dev/root[/opt/stage2/debian/rootfs]      /                      9p       shared,slave
[    1.030240] debian[139]: devtmpfs[/null]                           |-/dev/null            devtmpfs shared,slave
[    1.030474] debian[139]: devtmpfs[/zero]                           |-/dev/zero            devtmpfs shared,slave
[    1.030704] debian[139]: devtmpfs[/full]                           |-/dev/full            devtmpfs shared,slave
[    1.030940] debian[139]: devtmpfs[/random]                         |-/dev/random          devtmpfs shared,slave
[    1.031242] debian[139]: devtmpfs[/urandom]                        |-/dev/urandom         devtmpfs shared,slave
[    1.031527] debian[139]: devtmpfs[/tty]                            |-/dev/tty             devtmpfs shared,slave
[    1.031823] debian[139]: devtmpfs[/net/tun]                        |-/dev/net/tun         devtmpfs shared,slave
[    1.032104] debian[139]: devtmpfs[/console]                        |-/dev/console         devtmpfs shared,slave
[    1.032329] debian[139]: proc                                      |-/proc                proc     shared,slave
[    1.032531] debian[139]: tmpfs                                     |-/dev/shm             tmpfs    shared,slave
[    1.032731] debian[139]: devpts                                    |-/dev/pts             devpts   shared,slave
[    1.032931] debian[139]: tmpfs[/systemd/journal]                   |-/run/systemd/journal tmpfs    shared,slave
[    1.033154] debian[139]: sysfs                                     |-/sys                 sysfs    shared,slave
[    1.033355] debian[139]: proc[/sys/kernel/hostname]                |-/etc/hostname        proc     shared,slave
[    1.033556] debian[139]: tmpfs[/systemd/notify]                    |-/run/systemd/notify  tmpfs    shared,slave
[    1.033754] debian[139]: /dev/root[/opt/stage2/debian/rootfs/data] `-/data                9p       shared,slave
[    1.619306] reboot: Restarting system with command '<rkt: obligatory restart>'

@tjdett thanks for testing! Just for clarity: when you say "it doesn't work with volumes", does it mean that it breaks your httpfs2 scenario or that the mount propagation as shown in findmnt is broken?

@lucab as shown in the output above, volumes cause the slave flag to reappear.

However, readOnly=true fixes things:
sudo ./rkt run --stage1-path=`pwd`/stage1-kvm-qemu.aci --volume data,kind=empty,readOnly=true --mount volume=data,target=/data --insecure-options=image,paths docker://debian:8 --exec /bin/bash -- -c "findmnt -o SOURCE,TARGET,FSTYPE,PROPAGATION"                                                           [sudo] password for uqtdettr:                                                                                image: using image from file /home/uqtdettr/workspace/rkt/build-rkt-1.17.0+git/target/bin/stage1-kvm-qemu.aci           image: using image from local store for url docker://debian:8                                                           runtime/cgo: pthread_create failed: Resource temporarily unavailable                                                    networking: loading networks from /etc/rkt/net.d                                                                        [    1.119611] debian[138]: SOURCE                               TARGET                 FSTYPE   PROPAGATION            [    1.120034] debian[138]: /dev/root[/opt/stage2/debian/rootfs] /                      9p       shared
[    1.120312] debian[138]: devtmpfs[/null]                      |-/dev/null            devtmpfs shared
[    1.120576] debian[138]: devtmpfs[/zero]                      |-/dev/zero            devtmpfs shared
[    1.120850] debian[138]: devtmpfs[/full]                      |-/dev/full            devtmpfs shared
[    1.121142] debian[138]: devtmpfs[/random]                    |-/dev/random          devtmpfs shared
[    1.121406] debian[138]: devtmpfs[/urandom]                   |-/dev/urandom         devtmpfs shared
[    1.121672] debian[138]: devtmpfs[/tty]                       |-/dev/tty             devtmpfs shared
[    1.121941] debian[138]: devtmpfs[/net/tun]                   |-/dev/net/tun         devtmpfs shared
[    1.122200] debian[138]: devtmpfs[/console]                   |-/dev/console         devtmpfs shared
[    1.122453] debian[138]: proc                                 |-/proc                proc     shared
[    1.122695] debian[138]: tmpfs                                |-/dev/shm             tmpfs    shared
[    1.122947] debian[138]: devpts                               |-/dev/pts             devpts   shared
[    1.123206] debian[138]: tmpfs[/systemd/journal]              |-/run/systemd/journal tmpfs    shared
[    1.123449] debian[138]: sysfs                                |-/sys                 sysfs    shared
[    1.123688] debian[138]: proc[/sys/kernel/hostname]           |-/etc/hostname        proc     shared
[    1.123947] debian[138]: tmpfs[/systemd/notify]               `-/run/systemd/notify  tmpfs    shared
[    1.670507] reboot: Restarting system with command '<rkt: obligatory restart>'

I've piled a second commit on top of this, which should also fix the volume case. Still, by design, this will not work with a read-only rootfs.
At this point I'm not sure how this should be exposed, so asking for @coreos/rkt-maintainers about some options:

gate the "gracefully degrade to chroot" behind --insecure-options=paths. This "paths" option is now gaining a lot of side-effects, but pathmasking+devicepolicy+mountns are effectively coupled in systemd so this is hard to split
same as above, but only offer this chroot option for KVM. This means that stage2s in coreos flavor still can't propagate mounts between them (see https://github.com/coreos/rkt/issues/3223)
introduce a new insecure option to turn off mount-ns. This increment the number of flags and will have a bizarre semantic, as it will implies most of the semantic of the "paths" option

I'm currently leaning toward option 1 (current PR) or 2, comments are appreciated.

Coming in new to this issue, it seems like a new insecure option to mount MS_SHARED instead of MS_SLAVE might make sense?

@squeed If it were as simple as changing the mount flag, we'd have been done a little while ago. It's stripping the mount namespaces (!) off that's the big deal.
Whatever the flag option the dev team decides on, my vote is for something that makes it clear that you are now one chroot escape from the stage 1. To actually use the propagation you have to ditch seccomp and expose extra capabilities to at least the mounting stage 2. I won't discount that somebody might want to use this with the coreos stage 1, but by the time you're done you're only a little bit safer off than fly. Potentially OK, but only if the person invoking rkt run realises it.

This is making TestAceValidator fail on KVM only, with:
[ 4.949591 ] ace-validator-main[156]: main FAIL
[ 4.950815 ] ace-validator-main[156]: ==> "/db" is not a mount point
[ 4.951668 ] ace-validator-sidekick[144]: sidekick OK

I took a quick look in to why the test is failing.
The ACI validator checks that every volume+mount actually is a mountpoint, even though the text of the spec does not require this. Because we were passing ReadWriteDirectories to the unit on the KVM side, this generated a rw bind-mount in the vm, so the test passed. This change no longer passes that parameter, so the mount directory in the app is no longer a mountpoint, and the validator fails.
We need to change the validator to ensure that a directory is present, not that it is a mountpoint.

I think we should just remove the Validator tests. They are probably beyond the point of being useful for anything.

@jonboulle as you wish, but @squeed was mentioning that they are still useless in catching some regressions. I'd just disable this on kvm for the moment, and then we'll decide what to do with it.

Ping @jonboulle @squeed @s-urbaniak. This should be now ready for review.

@s-urbaniak Your feedback is on spot, with the changes for CRI and appendOptionsList this can be made simpler, but the PR was coded before that and I didn't notice when rebasing. I'll take your commit in here and let CI have another run.

Rebased with @s-urbaniak suggestions, PTAL.


Comments Stream: Paginator Fix

          1 Warning

:warning:
Please provide a linked tracker story for this PR in the description

  Generated by :no_entry_sign: Danger


ErrorException thrown by Dingo Router

I've belatedly upgraded from 0.6 to 0.8, and I've started to get the following error in my logs; this doesn't seem to effect the actual site itself or the api, but it is filling up my logs and causing Clockwork to stop working which is making debugging a pain.
[2015-01-30 10:41:04] local.ERROR: exception 'ErrorException' with message 'call_user_func_array() expects parameter 1 to be a valid callback, no array or string given' in /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Routing/Route.php:109
Stack trace:
#0 [internal function]: Illuminate\Exception\Handler->handleError(2, 'call_user_func_...', '/Users/david/Si...', 109, Array)
#1 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Routing/Route.php(109): call_user_func_array(NULL, Array)
#2 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(1028): Illuminate\Routing\Route->run(Object(Illuminate\Http\Request))
#3 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(996): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#4 /Users/david/Sites/my.site.com/vendor/dingo/api/src/Routing/Router.php(220): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#5 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(775): Dingo\Api\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#6 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(745): Illuminate\Foundation\Application->dispatch(Object(Illuminate\Http\Request))
#7 /Users/david/Sites/my.site.com/app/MyApp/Service/Http/ApiRights.php(66): Illuminate\Foundation\Application->handle(Object(Illuminate\Http\Request), 1, true)
#8 /Users/david/Sites/my.site.com/app/MyApp/Service/Http/ApiLogging.php(69): Logbook\Service\Http\ApiRights->handle(Object(Illuminate\Http\Request), 1, true)
#9 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Session/Middleware.php(72): Logbook\Service\Http\ApiLogging->handle(Object(Illuminate\Http\Request), 1, true)
#10 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Cookie/Queue.php(47): Illuminate\Session\Middleware->handle(Object(Illuminate\Http\Request), 1, true)
#11 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Cookie/Guard.php(51): Illuminate\Cookie\Queue->handle(Object(Illuminate\Http\Request), 1, true)
#12 /Users/david/Sites/my.site.com/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Illuminate\Cookie\Guard->handle(Object(Illuminate\Http\Request), 1, true)
#13 /Users/david/Sites/my.site.com/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(641): Stack\StackedHttpKernel->handle(Object(Illuminate\Http\Request))
#14 /Users/david/Sites/my.site.com/public/index.php(49): Illuminate\Foundation\Application->run()
#15 {main} [] []

I don't fully understand the issue, as I can't see what Dingo could be doing to alter the request, but am pretty sure it's 0.8 related (or at least my implementation of the upgrade). If I comment out $this->replaceBoundRouter() in RoutingServiceProvider everything starts working again; if I remove my additional middleware that doesn't make any difference; if I revert back to 0.6 then the errors stop and Clockwork starts working again. One other thing to note is that this error happens if browsing the site, but not if calling the API. (i.e. I have a website at site.com and an api at site.com/api).
Any idea what could be causing this?

And in case it's relevant, my routes are all of the form:
Route::get('login', 'AuthController@getLogin');

Ah, OK. Apologies. It looks like it was a conflict between Clockwork and Dingo - as part of the upgrade I moved the order of the ServiceProviders around, and as both overwrite routes, that was causing the issue. Moving Clockwork below Dingo in app.php seems to have fixed it again.
I'll now get back to doing work rather than spending hours commenting out code, dumping things to the screen and searching error messages on Google...


perf: extract cold paths in lean_free_small and mark noinline

While staring at the assembly output in https://github.com/leanprover/lean4/pull/555#issuecomment-877315772, I noticed that quite a bit of time on the hot path (deallocating allocation from the current thread's heap) is spent spilling registers, which are not actually used in the hot path, on the stack.

!bench

Not bad! Let's try that for the dual function too.

!bench

!bench

Oh, looks like I completely missed that in the first benchmark, only changes in instruction counts were reported, no actual wall time changes. But that partially seems to be the fault of above-average variance in that run, since changes < 10 stddev are not reported. All in all, it looks like each of the changes sped up every benchmark at least somewhat, with the biggest wins at ~5+5% in unionfind.


CI: Cilium E2E Upgrade: Timed out waiting for datapath updates of FQDN IP information after upgrade

From https://github.com/cilium/cilium/actions/runs/7190938554/job/19584876380
[=] Test [check-log-errors] [67/67]

  [-] Scenario [check-log-errors/no-errors-in-logs]
  Found "2023-12-13T05:22:11.945479031Z level=error msg=\"Timed out waiting for datapath updates of FQDN IP information; returning response\" subsys=daemon" in logs 1 times

  ❌ Found 1 logs matching list of errors that must be investigated:
2023-12-13T05:22:11.945479031Z level=error msg="Timed out waiting for datapath updates of FQDN IP information; returning response" subsys=daemon

Sysdump: cilium-sysdump-5-20231213-052359.7z.zip

Didn't see it in dogfooding hence I closed https://github.com/isovalent/customer-support/issues/557 which looks like the same issue, but still happening in CI.

Filed a PR should help reduce these timeouts significantly. Found a needless regeneration on the FQDN path that caused lock contention.

Hit on Conformance GKE as well after enabling the check for log errors also there: https://github.com/cilium/cilium/actions/runs/7208580138/job/19637888894#step:21:182

Reopening, as hit in the Cilium IPsec upgrade workflow for a PR which includes the commits from https://github.com/cilium/cilium/pull/29865.

PR: https://github.com/cilium/cilium/pull/30012
Link: https://github.com/cilium/cilium/actions/runs/7278734523/job/19833561516

Another hit here.
[=] Test [check-log-errors] [71/71]

  [-] Scenario [check-log-errors/no-errors-in-logs]
  Found "2024-01-02T10:54:30.033766201Z level=error msg=\"Timed out waiting for datapath updates of FQDN IP information; returning response\" subsys=daemon" in logs 1 times

  ❌ Found 1 logs matching list of errors that must be investigated:
2024-01-02T10:54:30.033766201Z level=error msg="Timed out waiting for datapath updates of FQDN IP information; returning response" subsys=daemon

Full logs
Sysdump too big :(

Taking a look.

Aha, the backport to v1.15 hasn't merged yet. Whew.

Taking a look.

Thanks! I kept a local copy of the sysdump, let me know if you want to take a look.

@pippolo84 are these failures on the backport PR that includes this change? GitHub is not making it easy to determine.

@pippolo84 are these failures on the backport PR that includes this change? GitHub is not making it easy to determine.

Yep, the workflow has been triggered by this PR.

Oh, you were looking for your changes from https://github.com/cilium/cilium/pull/29865. Those have been backported in the PR that triggered the workflow, so it seems the issue is still there, unfortunately.

So, some basic analysis:

There are two practically-concurrent requests, for A one.one.one.one. and AAAA one.one.one.one.
The timeout message comes from the second request, in this case, AAAA.
The vast majority of that time is spent waiting for the ipcache to complete

The basic flow
10:54:29.915: Response to A one.one.one.one. is received
10:54:29.921: NameManager is updated; locks released, waiting for ipcache to process v4 addrs. ipcache immediately starts.
10:54:29.923: Response to AAAA is received.
10:54:29.927: NameManager is updated; locks released, waiting for ipcache to process v6 addrs
10:54:29.933: ipcache PolicyMap updates are complete, waiting for proxy (Envoy) updates
10:54:29.946: Proxy updates are complete, ipcache is complete, total duration ~24ms, identity allocation ~1ms, proxy update ~9ms
10:54:29.946: ipcache starts again.
10:54:29.947: DNS response is released for A request. Total time: 32ms
10:54:29.987: ipcache PolicyMap updates are complete, waiting for proxy (Envoy) updates
10:54:30.033: We give up waiting for ipcache, write DNS response back.
10:54:30.037: Proxy updates are complete, ipcache is complete, total duration 93ms, identity allocation ~20ms, proxy update ~50ms, identity allocation 15ms
So, two observations:

Identity allocation randomly takes a long time. I'm assuming this is due to GC pauses / allocation
Envoy can also take a long time.

I don't see any smoking guns; 20ms lost in a trivial map update and 50ms lost waiting for envoy, plus the rest of the FQDN process, put us over 100ms. I'll try and dig in to why this is going wrong.
Next step is to find out why.

Created a gist with a bit more information here: https://gist.github.com/squeed/752d105c569db3eb328de191d37a4ed8
I'll ask around for help.

I did some exploration with @jrajahalme's assistance, and I found that Envoy sometimes just takes 20-30ms to process updates. There are no obvious performance smoking guns.
I would like to consider bumping the timeout to 150ms in CI to see if that gets rid of flakes. All the flakes I saw were timing out in ~103ms, the threshold is 100ms. I think we're just too resource constrained here.

I've seen this error message hit on some v1.14 CI jobs, which does not have my FQDN refactor. So I suspect this has always been an issue. We may wish to consider ignoring this warning. Perhaps it is allowed to log once, but more than that is indicative of an issue. Hard to say; it is literally a threshold matter.

Couldn't users hit this as well? If so, ignoring in CI may not be enough.
FYI, this is still happening a lot in CI and currently preventing us from making some workflows Required.

Users can and do hit this in production, it has been this way for years. We don't have good data, though.
If we want to continue blocking CI, then we can keep this as we figure out how to redesign the Envoy system. Otherwise, we should skip this error message.

Sounds like we may need to allowlist in CI + document.

Sounds like we may need to allowlist in CI + document.

Agreed, I'll take care of that shortly. And figure out how we can improve Envoy.

@squeed Created a PR on cilium-cli  to add this to the list of exceptions. Can I get your confirmation that this is the appropriate way to handle this?

This is also affecting at least Conformance GKE: https://github.com/cilium/cilium/actions/runs/8556001839/job/23444773987.
@squeed If you don't have time to implement the fix, could you unassign yourself and ask for someone else in your team to handle it? :pray:

Filed https://github.com/cilium/cilium/pull/31866 to bump the timeout to 250ms. There have also been a few FQDN performance improvements:

#31454, merged Apr 3
#30897, merged Apr 3

Hopefully this cuts the noise down significantly.

The GKE occurrence above is from April 4. This one as well: https://github.com/cilium/cilium/actions/runs/8558512353/job/23453228166. Both on main. It may have reduced it (?) but it doesn't look like it was enough.

This is still happening on main: https://github.com/cilium/cilium/actions/runs/8690522661/job/23830675920.

Just hit on v1.14 as well: https://github.com/cilium/cilium/actions/runs/8703624933/job/23870214379

Requested backport to v1.15 and v1.14.

Haven't seen this in a long time. Unassigning so that stale-issue GC can take over.


Updated openUI5 1.50.5 version.

Based on api.json
with :

Class
property
methods
constructor
Enum
Interface

Thanks for upgrading the version!
Looks good to me, but could you please run a standard --fix over the openui5.js file to make sure it sticks to the standard code style? That should also make the Travis build pass.
Once this is done, I'm happy to merge the PR.

Hello,
Ok, I used the --fix to clean up the code for Tarvis.

Looks good to me!


Support for replace function

Hello @mad,
I assume that you are using JanusGraph, which is not upgraded to TinkerPop 3.4.0 yet, so Cypher for Gremlin 1.0.0+ will not work there.
Do you need #255 to be merged to Cypher for Gremlin branch that uses TinkerPop 3.3.4?

Hello @dwitry
Thanks, It would be good

Merged to tinkerpop334 branch