[Bug]: Repeat loading the same plugin

Bug
I created 2 plugin groups which are loaded on startup with different delay time. The two groups all contain Quick Explorer. Then Quick Explorer will be loaded twice. It is my mistake to include Quick Explorer in both groups. But it's not good to load the same plugin twice.

Suggestion
Maybe it's better to check the plugins which are loaded on startup and to remove the redundant plugins.
PS: Enable the same group twice by the plugin groups will not load the same plugin again.

Thanks for bringing this to my attention I'll look into it!

Should be fixed in 1.3.0 if not, do let me know!

Fantastic! It works well. By the way I love your design of UI. :+1:

Glad to hear it! 🎉


Update README.md

Closes #57

Updated activities for learners
Didn't give the solutions to the updated activities straight away
Followed a LearnByDoing approach
Added Todos and Micro-Challenge on the activity

Well it seems that we can merge this PR, since we have two approvals! :rocket:

Two things:

U have used arrow function in map. Give a brief mention of it there
Change the stackoverflow link to a link with a suitable name

@Sreejan-22 Since we've already merged this PR, kindly create a second one with these quick changes and we'll get it reviewed ASAP!

Okay

Done with the changes


Added configuration option variable.

Added "make depend", to be run when disabling algorithms and "install_sw" to install only software without docs.

Why is make depend needed?

Because if you disable one or more algorithms you've to run make depend.
For example, if you run manually on a fresh extracted 1.0.2c version something like this
./Configure darwin64-x86_64-cc no-ssl2
at the end it will appear this message
Since you've disabled or enabled at least one algorithm, you need to do
the following before building:

	make depend

I usually use a configuration option to disable algorithms, so I've added it.

Ok, thanks for explanation!
Would be nice if that only runs if the CONFIG_OPTIONS are not a empty string to prevent slow down of normal build, or?

I thought to add the check but I've had some problems with my long options, now solved and added.

Thanks a lot for this PR!

You're welcome.
I'm working on a couple of other PR I'll send you soon.


Update Kitura-CredentialsHTTP tests

Currently, there are warnings:
$ swift test
Compile Swift Module 'CredentialsHTTPTests' (3 sources)
/Users/ipartrid/301/Kitura-CredentialsHTTP/Tests/CredentialsHTTPTests/TestBasic.swift:122:35: warning: 'init(userProfileLoader:realm:)' is deprecated: userProfileLoader has been deprecated from Basic Authentication because of security improvements. Please use VerifyPassword.
        let basicCredentials_v1 = CredentialsHTTPBasic(userProfileLoader: { userId, callback in
                                  ^
/Users/ipartrid/301/Kitura-CredentialsHTTP/Tests/CredentialsHTTPTests/TestDigest.swift:101:32: warning: 'init(userProfileLoader:realm:)' is deprecated: userProfileLoader has been deprecated from Basic Authentication because of security improvements. Please use VerifyPassword.
        let basicCredentials = CredentialsHTTPBasic(userProfileLoader: { userId, callback in
                               ^
Linking ./.build/debug/Kitura-CredentialsHTTPPackageTests.xctest/Contents/MacOS/Kitura-CredentialsHTTPPackageTests

We should fix these.

@gtaban @irar2 tagging interested parties!

Hi Ian - I added those warnings to show our plan to deprecate userProfileLoaded. It currently exists in the Test because we haven't removed the functionality.
How should this be approached?

We should fix the tests so they're not using the deprecated functionality.

I believe the deprecated functions exists still because there are IBM costumers that already are using this plugin and it was decided that we will pull the deprecated functions after a couple of releases, so we wouldn't break any code.
I think while the functionality is there, we should be testing for it, which means testing the deprecated functions.
When functionality is completely disabled from code, then test should be removed.
Thoughts?

OK that makes sense. Do we have tests for the new non-deprecated (replacement) functionality?

Yes they have been added.

Awesome. In that case I'll close this Issue.  Thanks @gtaban !


Join the thread inside UtpWrapper on drop

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)

This PR was created to address this issue: https://github.com/maidsafe/crust/issues/405#issuecomment-169263055

Joining the UtpWrapper thread does not fix it though

You're joining the UtpWrapper thread, but there is more.
When a connection is registered (the UtpWrapper object), the handle is added to the State::connections collection and two new threads are created. As all the communication is done using mpsc::channel, you just need to destroy one end of the channel to force the other end to also close (and the thread will eventually stop). You should update Service::stop to also take care of removing all connections.

Ok, I'll take a look at it. But even if we make sure we join all the threads that are spawned inside the service (and any objects used by it), it still won't solve the problem in #405. Because there are still multiple ways the connection can be broken without the fin packet being sent. For example:

the peer process is killed forcefully (kill - 9 ...)
the peer machine is turned off, disconnected from power socket, physically destroyed, etc...
the network goes down (router failure, power failure, cable being severed somewhere, etc...)
and so on.

In none of this cases has the peer being disconnected chance to send the fin packet.
Anyway, even if this PR does not fix the problem in #405, I thinks it's still useful because I believe joining threads we spawn is something we should always be doing anyway.

I believe joining threads we spawn is something we should always be doing anyway.

To me we should use crossbeam::scope for this and similar things where we can. Just for future anyway

To me we should use crossbeam::scope for this and similar things where we can. Just for future anyway

It seems that crossbeam::scope can only be used locally, inside a function. In this case we would need the crossbeam scope to be a member of a struct. We had a discussion on slack with @ustulation , @canndrew and @afck and the consensus was that crossbeam can't do that.

Yws, if we want more than that there is a scoped threadpool (crates.io) as well which is not function local.  Carrying a joinguard across functions may appear an anti pattern in many ways.

But even if we make sure we join all the threads that are spawned inside the service (and any objects used by it), it still won't solve the problem in #405.

Well, the problem was that we weren't sending the fin packet. It's okay to not receive a fin packet, as the connection will just time out and the other peer will drop the connection anyway (it just takes a little longer).

Ah, I see. So even if the service was terminated gracefully, it still wouldn't send the fin packet, correct? So I guess this PR then fixes it? If it does, let me just add an explicit test case for it and then you can merge it if you think it's ok.

So I guess this PR then fixes it?

Not yet, do the changes I requested. The uTP thread might finish earlier/later. It's a race. If application exist, more likely it won't.

You mean joining the reader / writer threads associated with each connection in State when it is stopped/destroyed?

You mean joining [...]

This would stall the application, you must close the associated channels (by dropping the connections) to request the threads to also exit.

Yeah, but the connections are dropped automatically when the State is dropped, aren't they? So it should be enough to make sure the threads are joined after the connections are dropped, shouldn't it?

Yeah, but the connections are dropped automatically when the State is dropped, aren't they? So it should be enough to make sure the threads are joined after the connections are dropped, shouldn't it?

I'm seeing a deadlock. State joins the read/write threads. Connections aren't dropped (will be dropped later). join never returns, because threads don't finish, because connections weren't dropped.
It's possible to join the threads at other places anyway, so this can be avoided.

That's why I want to join the threads only after the connection are dropped. Yup, it shouldn't be too hard. Have to run now, but will push a fix tomorrow.

Fixed the dangling reader threads. Was caused by a UtpWrapper keeping a copy of output Sender which prevented the corresponding Receiver in the UtpWrapper's thread to be closed.

Can we please wait with merging this one until we have the test_network_utp test in place? I have the test locally passing with this PR, but it also exposes the leaky thread problem. So I tried to apply this PR, but then the test_network_utp test started failing again.

So I tried to apply this PR, but then the test_network_utp test started failing again.

I can investigate this issue. But I believe the problem is not this PR per si, but the crust side of things. Asio has a callback in the write operation, so you can choose to only really stop the service once TCP acknowledges proper delivery. The nodes from the test are like "when you receive a connection, send a message back and when you receive N messages, don't bother waiting for the pending messages to be delivered". Related to https://github.com/maidsafe/crust/issues/431 and how currently the "on-connect" event is delivered (versus the past version of it). This is just my suspicion, I need to properly investigate it.

Can we please wait with merging this one until we have the test_network_utp test in place?

Sure we can wait, I can cherry-pick these commits and test locally to see if the new error is caused by this PR or by some other place.
In general, I think this PR is an improvement and there is nothing wrong with it. But waiting won't cause any trouble.

This branch has conflicts that must be resolved

Please update your work, @madadam.

Fixed the merge conflicts.

Please undo these style changes or @dirvine will make another commit that will force every PR to be rebased again.
😛

If you need help rewriting the commits, take a look into git rebase -i. It's a life-saver in these cases.

I'm just going to apply rustfmt to my changes.

This branch has conflicts that must be resolved

Fixed the conflicts, but some tests are failing. There are also some #[ignore]'d tests which should be checked. I won't be able to maintain this PR anymore as I've been moved to another project. Good luck ;)

Gonna skip the following commits, as I believe they are just noise:

https://github.com/madadam/crust/commit/8e5fd62508270510b06ed83b7c6b7e06b4eceaae
https://github.com/madadam/crust/commit/417420b15f549d01f7a149a6efb8bb96092f7078

Also, continued your work on another PR, just to not having any conflicts with master at all while adding as little noise as possible: https://github.com/maidsafe/crust/pull/475


Stabilize gas costs for mint and transfer endpoints

CHANGELOG:

Changed storage model to pagination model to allow for more stable gas costs when interacting with the mint and transfer entrypoints.
Added an upgrade scheme to safely migrate pre-existing owners to the new scheme
Added a new entrypoint to allow Accounts and Contracts to update their old receipts from the old scheme and receive new receipts for the new mode
Added new session Wasm called migrate.wasm that Accounts can send to update their receipts

Closes #71

Also, the entry point you call on the contract post upgrade install to migrate should write a flag and only allow itself to be run successfully once.

@EdHastingsCasperLabs Added three additional tests, two of which ensure that installation and upgrade with 0 token issuance isn't allowed. Also added a test to ensure the migration entrypoint can't be called post migration

can you provide a few examples in the description of what some sample receipts looks like for a given nft contract?

Is this  issue complete?
Or when will it be completed?
Thanks for the team's efforts


Fix issue #378

Coverage remained the same at 100.0% when pulling 60c8e3de1363cc7ba9ca72b76d709656d730c9bf on issue_378 into 6ac91b21a1fd24dcf5a27d587d0a534e3459ea46 on master.


adding %nbdev_export_and_show and %nbdev_export_internal

here's a couple more, whenever you're ready (o:
Hopefully the changes to clean_exports and remove_hidden make sense - here's what I was thinking;

no flags, except hide, should make a difference to markdown
magic and comment flags should do the same things
flag behavior should be consistent. e.g. #exporti bad mod -> won't get picked up for export export, so it shouldn't be hidden

This all sounds good to me, thanks!


Can't type anything in webpackbin

Hi,
I can't seem to get webpackbin to work. When I go here: http://www.webpackbin.com/ I open up main.js, and I can't enter anything into the text editor - all my keyboard input is ignored.

Here's my browser info:
Version 53.0.2785.143 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
I also tried in Firefox 50.0 with the same problem.

had the same problem with console open...
closing it solved the problem for me

Also happens when window size is too small.

This also seems to happen every time I try to install any module from npm in the "configure." This time downloading 'choo' or 'web-audio-daw' is breaking everything.

See:
https://github.com/cerebral/webpackbin
https://twitter.com/christianalfoni/status/833975318570496000


Is it possible to disable / make smaller, the buttons at the right side?

Title says it all. Is that possible at all with this library? Thanks!

no, Google Maps JS API currently does not support it.


Make this easier to find

When I go to https://github.com/styleguide and click on Primer (HTML and CSS), I get redirected to https://primer.style/. When I click on Style Guide, I get what I wasn't looking for. Why is this so hard to find?

Thank you, that was what I was looking for when I googled "Github CSS style guide".


Remove Note Command and its Test cases

Closes #138
Remove Note Command and its Test cases.
Files removed:

NoteCommand.java
NoteCommandParser.java
NoteCommandTest.java
NoteCommanParserTest.java

Files Updated:

AddressBookParser.java
AddressBookParserTest.java

lgtm


chore: fix make base target

I notice that doc/make base tried to produce docs for the motoko-base test dir too, and complained.
Fixed the base target to only produce doc for motoko-base src dir, not the root dir.
I wonder how this ever worked in the past, especially since it used by our release instructions...

Probably a red-herring. I redefined MOTOKO_BASE incorrectly.


README tests are failing

When running tox some errors are raised from the README.rst file:

This:
>>> output = parse_number("not_a_number")
>>> output
None

should be:
>>> output = parse_number("not_a_number")
>>> output

(removing the None)

This:
>>> parse("two thousand thousand")
2000 1000

should be:
>>> parse("two thousand thousand")
'2000 1000'

And there is a trailing space after 1432524 in >>> parse_number("चौदह लाख बत्तीस हज़ार पाँच सौ चौबीस", language='hi')

Closing as it was fixed in #35 :slightly_smiling_face:


Fixed typo in transpiler README

@googlebot I signed it!

Thanks for the fix!  We don't yet have the process in place for accepting external contributions, so we can only apply the patch for now.


Setup backend data storage for form data

Is this issue still valid for the CIG project, or is it HAR-specific? If it's HAR, can we close this since it's in the info guide?


Watch doesn't seem to work

Hi, I've just downloaded the last release of semantic, everything seems to work fine, but when I launch
gulp watch
and try to change a file, here what happen:
[gulp] Modified: src/site/globals/site.variables

And nothing happen ( no rebuild ). What could the problem be?

Same here :-(
This is the output:
SRC Path Does Not Exist path-to\my-site\site.less
[gulp] Modified: path-to\my-site\site.variables

My custom site folder holds .variables & .overrides files only ...
PS: I'm on Win7, gulp install / theme customization runs fine

@r0b- Are you still having this error? I'm moving on to build tools this week and want to help clarify and lingering bugs.

Sorry but I am not in my country from the time I've opened my issue. I
am traveling for work so I didn't have time and my machine to test it!
I'll let you know in the future, but with the debug I guess it's a
problem caused by docker. Maybe can't read correctly the path or something..
Il 26/01/15 19:41, Jack Lukic ha scritto:

@r0b- https://github.com/r0b- Are you still having this error? I'm
moving on to build tools this week and want to help clarify and
lingering bugs.
—
Reply to this email directly or view it on GitHub
https://github.com/Semantic-Org/Semantic-UI/issues/1476#issuecomment-71513069.

Hi Jack, I'm on vacation and unfortunately will work with the build tools not before March...

I'll close this thread for now, @ me if there's any more evidence.

Watching source files for changes
Change detected in theme config
[09:44:36] Starting 'build'...
Building Semantic
SRC Path Does Not Exist undefined
[gulp] Modified: src/theme.config

same here
[13:53:48] Starting 'build'...
Building Semantic
SRC Path Does Not Exist undefined
[gulp] Modified: src/theme.config

Working for me now... using 1.9.0

The error message
SRC Path Does Not Exist undefined

Should no longer occur when modifying theme.config in latest version.


Qualtrics Integration [master]

Integrate Qualtrics into Spartacus, and make sure it is configurable for the user

Is there a separate board for this?
Where is work detailed?

Is there a separate board for this?
Where is work detailed?

1- yes, it is in the projects directory/page
2- work detailed as in what tickets it needs to be done? If yes, it is in its own board. Small feature that can be done, but other tickets/features were priority, such as finishing infinitescroll e2e / fix e2e tests, helping out code reviewing guestcheckout / configurable endpoints (which is done), etc. All I can say from what I did so far for this ticket is that we have a seamless integration, but I still need to create a injection for customers to be able to enable qualtrics on pages they want. But other than that, everything is done in the qualtrics side as in having it always enabled.

Qualtrics integration done, no longer needed


Add go tooling for setting up localregistry and minikube environment …

Add go tooling for setting up localregistry and minikube environment for testing

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
f118e343900e90ad687bf130aaf2e0dc56df856f
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5ae971b682f8974e920e5baef80980213960f22c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
30f5a874f356d99b0cb9ace739f87692f69104a0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not stale


Intake catalogs

from @jbednar

I can definitely imagine passing an Intake data catalog to a REST service, allowing that service to read the indicated file(s) and process them. That way the service could handle any data source that Intake can. E.g. an Intake catalog can set things up to define a visualization of a given data source, and a REST service could then plot and display what was specified...

Yes, something like that exactly. Presumably then a dataframe would become available on the server, to be downloaded in whichever way tranquilizer handles dataframes (csv, msgpack serialized...)
ds = catalog.walk()[source].get() -> ds = catalog[source]()

(plus you may want to allow for user parameters to be passed in the parenthesis for entries that allow them)

Noted, **kwargs should be easily implemented if not already working.
In the example above I wrote a catalog that referenced a remote source, but the source could also be a file that is expected to be available to server running the process() function. Would the caching capabilities of Intake be appropriate for the use case that "on first reference to a source in a catalog, download the file to a specified format"?

Caching is implemented by downloading the original source files, not by converting to a standard internal format (although we have thought about that too). It should be specified as part of the data source spec, with a cache: entry, since not all remote sources will be have the same caching scheme. From this point of view, I'm not sure how useful caching would be for you.
Another thing to keep in mind in this context, is that tranquilizer could be a server of such specs, rather than a consumer/processor. For example, it could act as a gateway to REST services, producing the equivalent of a YAML block for a set of input parameters. I raise this here, because, for a remote source, it usually makes more sense for the client to access directly rather than to have a server do it and forward the data. The latter case, together with tranquilizer, can make sense when the client doesn't want to install Intake locally, or doesn't have access to credentials that the server does - similar to what the Intake server also does.


Remove ESLint

Is this a bug report?
(write your answer here)

Can you also reproduce the problem with npm 4.x?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

node -v:
npm -v:
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:
Browser and version (if relevant):

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Closed, this issue is no longer valid with the upgrade to create-react-app@2


Linked Resource of LogAnalytics Workspace is not respected if you have access to multiple subscriptions

Describe the bug
If you have multiple subscriptions and deploy the template even though you specify an analytics workspace correctly the workbook is connected to your default subscription. However, the link is created correctly in the workbook as Linked Resource and even the JSON View is pointing to the correct resource
Reproduce
Steps to reproduce the behavior:
Deploy the Workbook to a different subscription and specify an analytics workspace with the correct value for the template
Expected behavior
The workbook is connected to the correct analytics workspace.
Screenshots
If applicable, add screenshots/images to help explain your problem.
Environment- if applicable
no CLI used. Deployed directly from GIT repository
Desktop (please complete the following information if applicable):

OS: Microsoft Windows
Browser Edge
Version

Logs- if applicable

If logs are available, please provide relevant snippets

Additional context
Add any other context about the problem here.

@FrankCRoth Thank you for the feedback. This is currently being reviewed.


[Feature]: More Sophisticated Bounds Handling in Temporal Averaging Operations

Is your feature request related to a problem?
xcdat temporal averaging operations currently bin data by the labelled time point with the weights derived from the difference in the time bounds. This works for most conventional climate data: a timepoint of 2020-01-16 12:00 with bounds of [2020-01-01 00:00, 2020-02-01 00:00] would be given 31 days of weight in January (e.g., in creating an annual average or climatology), which is correct.
There are reasonable instances where this wouldn't work. Imagine pentad data with a time point of 2020-02-02 12:00 with bounds of [2020-01-31 00:00, 2020-02-05 00:00]. This time point should be given one day of weight in January and four days of weight in February. The current algorithm (e.g., for monthly averaging) assigns all five days of weight in February (the labelled time point).
Describe the solution you'd like
Weights should be assigned based on the time period that they fall into. This would mean that a given time point can contribute to averages in more than one time interval
Describe alternatives you've considered
Solutions for the time being would be to update documentation to note that:

Weights are determined from the difference in the bounds
Data is grouped into the labelled time point for averaging operations
If one time point spans across the time intervals that you are averaging into, then weights are not properly assigned
get_time_bounds generally assumes data with frequencies of annual, monthly, daily, or sub-daily (I thought of this while writing this issue)
Perhaps other disclaimers I haven't thought of

Additional context
I'm not sure cdms / cdutil covers this case; it would be helpful to determine what cdutil does.
This seems like it could be challenging issue to address in general and might require a major refactor of the logic use for existing temporal averaging calculations.

I opened up PR #601 to implement the documentation updates suggested in your alternative solution.


How can i read conf file?

eg. redis.conf:

SharpConfig expects a '=' by default, because that's the format of cfg/ini files.
This behavior is implemented here (and in line 244). In order to parse your config, the call should be changed from IndexOf('=') to IndexOfAny(new[] {'=', ' '}).
I may implement this as an optional feature in a future release, but for now, you would have to change the code yourself.


Unclarity and missing troubleshooting for the crucial part of the site about entering "HTTPSampler.domain" value

[Enter feedback here]
Hi,
it's unclear to me which value from the Function App Details you want to add to "HTTPSampler.domain"
Is it  "invoke_url_template": "https://tcf-dev4-mmmatch.azurewebsites.net/api/entermatchmaking_loadtesting"
What is the exact value to add to the "HTTPSampler.domain" ?
Is it "tcf-dev4-mmmatch.azurewebsites.net/api/entermatchmaking_loadtesting" ?
If we run the test and we get "Error Non HTTP response code: java.net.MalformedURLException" What can it be ? How to trouble shoot?
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e6298d0-fb86-ce3f-8f5b-20c2180ae87e
Version Independent ID: c97971f5-e7af-b32c-39ae-0b87c82abde7
Content: Quickstart: Create and run a load test with Azure Load Testing
Content Source: articles/load-testing/quickstart-create-and-run-load-test.md
Service: load-testing
GitHub Login: @ntrogh
Microsoft Alias: nicktrog

Ok, might be we have to lower the "AuthorizationLevel" of that function we want to call.

@BlurmeUnique Thanks for reaching out. Depending on the authorization level, you may need to specify the function key in the HTTP request. If you set anonymous auth level, it should work fine with just the URL. Make sure to not include the https prefix in the script.

#assign: @ntrogh

a) Can you please confirm that we should pass in the "invoke_url_template" value without "https://" ?
b) We are getting this error: "java.net.MalformedURLException,Non HTTP response message: Illegal character found in host: '/'"
We tried using // or \ instead but that doesn't work either unfortunately

Apologies for the confusion. I'll update the docs to make things more clear.
a) For the HTTPSampler.domain value, you put the domain name: tcf-dev4-mmmatch.azurewebsites.net
b) Because the target URL has a sub path, you need to fill in the HTTPSampler.path information: /api/entermatchmaking_loadtesting
That's how the JMeter HTTPRequest sampler expects the information.

Perfect, thank you very much. Works!

Thank you for your feedback! 🙏 I'll now have this issue closed.

#please-close


script for creating the ontonotes dataset

I would like to test deeppavlov NER with the other two languages of the OntoNotes dataset. You only provide the English data as a single file ontonotes_senna.pckl. However, I didn't find any mention in your documents or scripts how you created this file from the original raw Ontonotes data, containing all 3 languages. Is that script available somewhere, so that I could easily extract also the Chinese or Arabic datasets in the correct format for Deeppavlov?

Hello!
You can find the script for parsing OntoNotes here: https://gist.github.com/mu-arkhipov/e06c70259aa6420de15469786cf5b018
Note: it treats each sentence as separate training example.

Hi, thanks, but that script doesn't seem to match at least the raw Ontonotes data I have (v.5.0), where the raw files with NER tags are in a hierarchy like
ontonotes-release-5.0/data/files/data/english/annotations/bn/cnn/00/cnn_0035.name
and contain the tags in this format:
today
Is your script taking as input some other type of files than cnn_0035.name?
So, I'm looking for a script which would read eg. all tagged files under the english (or chinese) main directory, and then create the train, test and valid text files or the pickled dict file as your ontonotes_senna.pckl
Another question, when training a model, in addition to printing out just the total F1 I would also like to output F1 score separately for each tag, similarly to your example on page
http://docs.deeppavlov.ai/en/latest/components/ner.html#ontonotes-ner
I'm using a default config file similar to your
https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/configs/ner/ner_ontonotes.json
What would I need to change to print also the separate F1 scores for each tag?

Not quite sure about the `.name' files. There is no files with such extension in my version of the dataset.


Get surrounding text for search.

Hello!  I am curious about this...when you search on Google for something, you get the results (obviously), and then a little excerpt of the page with the surrounding text.  Is there any mechanism in which to do this in Lunr.js?

Currently, no :disappointed:
This is a very popular request, the trouble is that it is completely incompatible with the current way lunr stores its index of documents and performs searches. As such implementing it is not easy, not to say it is something that will never happen, just that it probably won't be available anytime soon.


[bug] chains use okc to report an error

Link to minimal reproducible example
none
Summary
chains use okc to report an error:

Uncaught Error: Could not find valid provider configuration for chain "OKC".
You may need to add jsonRpcProvider to configureChains with the chain's RPC URLs.

Chains use mainnet, bsc, arbitrum and other functions without error.
<template>

  <w3m-network-button />
  <w3m-connect-button />
  <w3m-account-button />

  <button @click="modal.open()">Open Connect Modal</button>
  <button @click="modal.open({ view: 'Networks' })">Open Network Modal</button>

</template>

List of related npm package versions
{
    "name": "Web3Modal-V3-Vue",
    "private": true,
    "version": "1.0.0",
    "type": "module",
    "scripts": {
        "dev": "vite",
        "build": "vite build",
        "preview": "vite preview"
    },
    "dependencies": {
        "vue": "^3.3.4",
        "@wagmi/core": "^1.4.1",
        "@web3modal/wagmi": "3.0.0-alpha.9",
        "viem": "^1.10.9"
    },
    "devDependencies": {
        "@vitejs/plugin-vue": "^4.2.3",
        "vite": "^4.4.5"
    }
}

We will mention this more clearly in the documentation, but TL;DR is this: when you use defaultWagmiConfig helper you are using our pre-configured wagmi setup. You can see whats included by looking at advanced/custom sections of documentation https://docs.walletconnect.com/2.0/web3modal/v3/vue/about
By default provider (rpc) that we use is WalletConnect one and it doesn't support okc. So you will need to define your own wagmi configuration and add additional provider that supports that chain. Wagmi's documentation on provides should also be usefull.

But there is indeed okc in wagmi core chains.
但是 @wagmi/core/chains 里面确实有 okc 呢

const chains = [mainnet, bsc, okc]
const projectId = ENV.VITE_WALLET_CONNECT_PROJECT_ID

defaultWagmiConfig({ chains, projectId, appName: 'Web3Modal' })
createWeb3Modal({ wagmiConfig, chains, projectId })

Report an error

runtime-core.esm-bundler.js:221 Uncaught Error: Could not find valid provider configuration for chain "OKC".
You may need to add jsonRpcProvider to configureChains with the chain's RPC URLs.

Please tell me how to fix this problem

See "Custom" tab in this section
https://docs.walletconnect.com/2.0/web3modal/v3/react/about#implementation
You need to add a provider in addition to walletConnectProvider that supports okc. Usualy wagmi's publicProvider does the trick.

See "Custom" tab in this section https://docs.walletconnect.com/2.0/web3modal/v3/react/about#implementation
You need to add a provider in addition to walletConnectProvider that supports okc. Usualy wagmi's publicProvider does the trick.

I looked at the custom tabs, but I still can’t write it.
Can you please help me write a demonstration code using okc as an example?

import { createWeb3Modal } from '@web3modal/wagmi/react'
import { walletConnectProvider } from '@web3modal/wagmi'

// Add this <--
import { publicProvider } from 'wagmi/providers/public'

import { WagmiConfig, configureChains, createConfig } from 'wagmi'
import { mainnet } from 'wagmi/chains'
import { CoinbaseWalletConnector } from 'wagmi/connectors/coinbaseWallet'
import { InjectedConnector } from 'wagmi/connectors/injected'
import { WalletConnectConnector } from 'wagmi/connectors/walletConnect'

const projectId = 'YOUR_PROJECT_ID'

const { chains, publicClient } = configureChains([mainnet], [
    walletConnectProvider({ projectId }),
    // Add this <--
    publicProvider()
])

const wagmiConfig = createConfig({
  autoConnect: true,
  connectors: [
    new WalletConnectConnector({ options: { projectId, showQrModal: false } }),
    new InjectedConnector({ options: { shimDisconnect: true } }),
    new CoinbaseWalletConnector({ options: { appName: 'Web3Modal' } })
  ],
  publicClient
})

createWeb3Modal({ wagmiConfig, projectId, chains })

export default function App() {
  return (
    <WagmiConfig config={wagmiConfig}>

    </WagmiConfig>
  )
}

I think something like this will work, but if wagmi's publicProvider doesn't support okc, you'll need to make your own.

web3modal V3 can't run normally using okc
import { createWeb3Modal } from '@web3modal/wagmi/react'
import { walletConnectProvider } from '@web3modal/wagmi'

// Add this <--
import { publicProvider } from 'wagmi/providers/public'

import { WagmiConfig, configureChains, createConfig } from 'wagmi'
import { mainnet, bsc, okc } from 'wagmi/chains'
import { CoinbaseWalletConnector } from 'wagmi/connectors/coinbaseWallet'
import { InjectedConnector } from 'wagmi/connectors/injected'
import { WalletConnectConnector } from 'wagmi/connectors/walletConnect'

const projectId = 'YOUR_PROJECT_ID'

const { chains, publicClient } = configureChains([mainnet, bsc, okc], [
    walletConnectProvider({ projectId }),
    // Add this <--
    publicProvider()
])

const wagmiConfig = createConfig({
  autoConnect: true,
  connectors: [
    new WalletConnectConnector({ options: { projectId, showQrModal: false } }),
    new InjectedConnector({ options: { shimDisconnect: true } }),
    new CoinbaseWalletConnector({ options: { appName: 'Web3Modal' } })
  ],
  publicClient
})

createWeb3Modal({ wagmiConfig, projectId, chains })

function App() {

  return (
    <>

Vite + React

      <WagmiConfig config={wagmiConfig} />
      <w3m-button />
    </>
  )
}

export default App

The above code will not connect bsc and okc when connecting to the wallet.
But after connecting, there will be bsc and okc in the switching network.
Add this specifically adds what code?
Could you please help me improve it?
web3modal V2 can run normally using okc
import { EthereumClient, w3mConnectors, w3mProvider } from '@web3modal/ethereum'
import { configureChains, createConfig } from '@wagmi/core'
import { Web3Modal } from '@web3modal/html'
import { mainnet, bsc, okc } from '@wagmi/core/chains'

const chains = [mainnet, bsc, okc]
const projectId = 'YOUR_PROJECT_ID'

const { publicClient } = configureChains(chains, [w3mProvider({ projectId })])
const wagmiConfig = createConfig({
	autoConnect: true,
	connectors: w3mConnectors({ projectId, chains }),
	publicClient
})
const ethereumClient = new EthereumClient(wagmiConfig, chains)
const web3Modal = new Web3Modal(
	{
		projectId: projectId,
		themeMode: 'dark',
	},
	ethereumClient
)

V2 can run normally using configureChains([mainnet, bsc, okc], [w3mProvider({ projectId })])

@hhun try beta.2 with defaultWagmiConfig, should work

@hhun try beta.2 with defaultWagmiConfig, should work

It can run normally using v3.0.0-beta.2
But, version v3 deletes the two parameters chainImages and tokenImages, and I hope to add these two parameters

Token images are available (please go over v3 docs) https://docs.walletconnect.com/2.0/web3modal/v3/about option for chain images will also be available before 3.0.0 stable release.


[Enhancement] Select Text using {Ctrl/Alt}+Shift+Arrow Key

Description of the problem or steps to reproduce
I was wonder if it could be added that text can be selected by using {Ctrl/Alt}+Shift+{Top/Down/Left/Right}, which will add whole line/a single word to the current selection.
Specifications
You can use micro -version to get the commit hash.
Commit hash: 1856891
OS: Linux 4.19.0-5-amd64 #1 SMP Debian 4.19.37-3 (2019-05-15) x86_64 GNU/Linux
Terminal: Alacritty

In the current version this is working

I cant approve that, this doesnt move the cursor at all, when trying to do so.

I guess your OS has occupied that shortcut and is overwriting it. Maybe check your OS keybindings settings.
Here is a list of the default keybindings. You can bind that command to a different shortcut as well. That would be maybe a good way to confirm my assumption.

Seems to be an issue with my terminal alacritty. Nevermind.


Remove incorrect dependencies in the root package.json

Pull Request Description
Removes dependencies that should not be in the root package.json
Basic testing done with npm run ci-check.
Introduced by the following PRs (in order of being merged):
See blame for more details: https://github.com/enso-org/enso/blame/develop/package.json

#7813
#7656 (oops)
#7881

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

double checked to be extra sure - both npm why and the appropriate package.json still have the expected Playwright dependencies.
As for the other PRs:

GUI opening projects PRs - likely a bad npm i command, for example npm i lint run?
Parser TS bindings - likely an unnecessary npm install of a package that should already be included as part of the npm workspace.


Can't access my API after implementing React ADAL

Hi,
I've implemented react-adal into my solution and it works for securing the application, however, I cannot access any of my API's after it's implemented.  I receive a 401 Unauthorised error.  I've looked at the examples/tutorials and sadly, they don't mention this.  I've seen that you can pass a token with the headers to show that you're logged in but, again, this isn't demonstrated only mentioned.
Here is my code so far.  For the sake of good order, I am working an ASP.NET Core 2.2 application using React with Redux hosted on Azure with AAD for my users.  I can confirm that my application registration for security is in place within Azure.  I've removed sensitive information like my client id and tenant id for obvious reasons.
adalConfig.js
import { AuthenticationContext } from 'react-adal';

export const adalConfig = {
    tenant: '<my-tenant-id>',
    clientId: '<my-client-id>,
    endpoints: {
        api: '<my-client-id>',
    },
    postLogoutRedirectUri: window.location.origin,
    cacheLocation: 'localStorage',
};

export const authContext = new AuthenticationContext(adalConfig);
export const getToken = () => {
    return authContext.getCachedToken(authContext.config.clientId);
};

index.js
import React from "react";
import ReactDOM from "react-dom";
import { Provider } from "react-redux";
import { ConnectedRouter } from "react-router-redux";
import { runWithAdal } from 'react-adal';
import { authContext } from './adalConfig';
import "bootstrap/dist/css/bootstrap.css";
import "./assets/css/site.css";
import { createBrowserHistory } from "history";
import configureStore from "./store/configureStore";
import App from "./App";
import registerServiceWorker from "./registerServiceWorker";

const DO_NOT_LOGIN = false;

runWithAdal(authContext, () => {
    const baseUrl = document.getElementsByTagName("base")[0].getAttribute("href");
    const history = createBrowserHistory({ basename: baseUrl });
    const initialState = window.initialReduxState;
    const store = configureStore(history, initialState);
    const rootElement = document.getElementById("root");

    ReactDOM.render(
        <Provider store={store}>
            <ConnectedRouter history={history}>
                <App />
            </ConnectedRouter>
        </Provider>,
        rootElement
    );
    registerServiceWorker();
})

Startup.cs
I've removed none essential information from this file as it's too long to list everything and not relevant to the question.
namespace Shelly
{
    public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }
        public IConfiguration Configuration { get; }

        public void ConfigureServices(IServiceCollection services)
        {
            //Authenication
           services.AddAuthentication(sharedOptions =>
            {
                sharedOptions.DefaultScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                sharedOptions.DefaultChallengeScheme = OpenIdConnectDefaults.AuthenticationScheme;
            }).AddAzureAd(options => Configuration.Bind("AzureAd", options))
            .AddCookie();

            //MVC
            services.AddMvc(options =>
            {
                var policy = new AuthorizationPolicyBuilder()
                    .RequireAuthenticatedUser()
                    .Build();
                options.Filters.Add(new AuthorizeFilter(policy));
            }).SetCompatibilityVersion(CompatibilityVersion.Version_2_2)
            .AddJsonOptions(options => options.SerializerSettings.ContractResolver = new DefaultContractResolver())
            .AddRazorPagesOptions(options =>
            {
                options.Conventions.AllowAnonymousToFolder("/Account");
            });

            // Add Kendo UI services to the services container
            services.AddKendo();

            // In production, the React files will be served from this directory
            services.AddSpaStaticFiles(configuration =>
            {
                configuration.RootPath = "ClientApp/build";
            });
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseBrowserLink();
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Error");
            }

            app.UseStaticFiles();
            app.UseHttpsRedirection();
            app.UseSpaStaticFiles();

            //Enable ADAL
            app.UseAuthentication();
            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller}/{action=Index}/{id?}");
            });

            app.UseSpa(spa =>
            {
                spa.Options.SourcePath = "ClientApp";

                if (env.IsDevelopment())
                {
                    spa.UseReactDevelopmentServer(npmScript: "start");
                }
            });
        }
    }
}

appsettings.js
As I'm working on my local server at the moment, the App URL is localhost.  The same problem occurs no matter what variation I use for development.
 "AzureAd": {
    "ClientId": "<my-client-id>",
    "Domain": "mycompany.onmicrosoft.com",
    "Instance": "https://login.microsoftonline.com/",
    "TenantId": "<my-tenant-id>",
    "CallbackPath": "/signin-oidc",
    "ClientSecret": "<my-secret>",
    "AppIDURL": "https://localhost:44373/",
    "ConfigView": "MVC"
  }

My solution has a selection of controllers that access an API, when that request is madea 401 error is returned even if you log in.  How can I resolve this issue, it's quite a big deal and renders the ADAL a bit useless.  I think it could be something to do with passing bearer tokens in the header but like I say, I can't find a good example of this, just a note mentioning that it can be done, can someone please clarify this?

export const adalApiFetch = (fetch, url, options) =>
adalFetch(authContext, adalConfig.endpoints.api, fetch, url, options);
use adalApiFetch with your favorite "fetch" in your api call.


[WIP] Automation scripts

this is a bit WIP
adding a manage.py command to create a certificate from the command line.  It is a butchering of ProvisionELB.

When you're ready, please squash this PR down into one or a few commits.

squashed, but screwed up the commit messages.

Can you re-base? This looks good to merge otherwise.

Still can't re-base :-(

Feel free to re-open.


Adding a Verbose Hook

Adding a Verbose Hook, so verbose output wont only be printed, but also handled if chosen to
solution to #5448 (Issue: Get Verbose messages from chain)
Usage:
def handle_verbose(verbose_output, *args, **kwargs):
    print("$$$$$$$ HANDLEING VERBOSE OUTPUT $$$$$$")
    print(verbose_output) # Handle verbose here
    print("$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$", args, kwargs)

worker = LLMChain(prompt=prompt,llm=llm, verbose=verbose, verbose_hook=handle_verbose)
# Verbose messages will be sent to hook

Usefull when you want to include verbose output, for example in a custom debugger gui, logger, or for any other usage.
( I've only changed the on_text event, which includes the final (green) prompt before it is sent to the llm, if you like it you can extend to use in other places. )
Hope you find it useful as I do
Have a good one and all the best!

Sorry we didn't review this earlier, and you can do this with callbacks!

https://python.langchain.com/docs/modules/callbacks/custom_callbacks

https://python.langchain.com/docs/modules/callbacks/custom_callbacks

thanks a lot! looks simple enough, just to make sure this DOES include ALL model output correct?
including code generation, etc
Thanks @efriis all the best! :)


incorrect username and client_id payload given to on_auth_m5 webhook

Environment

VerneMQ Version: 1.12.5
OS: Ubuntu 22.04
Erlang/OTP version (if building from source): 24

Expected behaviour
Webhook documentation mentioned sample expected payload :
{
    "username": "username",
    "mountpoint": "",
    "client_id": "client-id",
    "properties": {
      "p_authentication_data": "QVVUSF9EQVRBMA==",
      "p_authentication_method": "AUTH_METHOD"
    }
}

Actual behaviour
username and client_id value are incorrect when arriving on registered webhook endpoint for on_auth_m5 :
{
    "username": null,
    "mountpoint": "",
    "client_id": "undefined",
    "properties": {
        "p_authentication_data": "<auth_data>",
        "p_authentication_method": "EXTERNAL",
        "p_session_expiry_interval": 3600
    }
}

Is the above behaviour expected ?

@andrewsaputra Thanks, looks wrong, yes.
What username/clientid are you using in the initial register attempt here?

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Hi @ioolkos i'm using standard alphanumeric values with a bit of symbols, e.g. :
username : "home-user"
client_id : "device1#08fe1b11-edb3-4dd6-9d1a-4dcc59d24c4a"

@andrewsaputra
ok, thanks. If the username is not set, it is "nullified", so that seems correct. The ClientID should probably never be undefined here, since Verne will allocate a random ClientID in case you don't provide one. Will check this.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.


 Why is this change necessary?
Currently when the error message on the Sync Api contains a UUID the error message "Malformed UTF-8 characters, possibly incorrectly encoded" is shown. Which is not very helpfull
2. What does this change do, exactly?
Adds the "JSON_INVALID_UTF8_SUBSTITUTE" option to the Sync API Json Response
3. Describe each step to reproduce the issue or behaviour.
For ex: upsert a product, try to link an non existing media entity to it. "Malformed UTF-8 characters, possibly incorrectly encoded" error will be shown.
4. Please link to the relevant issues (if any).
/
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-19835
Please use this issue to track the state of your pull request.


Swiper slides buggy when using Virtual module with vertical scrolling & css mode enabled

Check that this is really a bug

[X] I confirm

Reproduction link
Repo: https://github.com/harshbaz/swiper-svelte-virtual-vertical-css
Stackblitz: https://stackblitz.com/github/harshbaz/swiper-svelte-virtual-vertical-css
(Sorry for no codesandbox link, it doesn't work for some reason)
Bug description
In the reproduction there are three pages:

http://localhost:xxxx/: the root or index page is without any vertical module and how it should behave with virtual module as well. Basically it's a reference to what I'm trying to do with the Virtual module.
http://localhost:xxxx/virtual: /virtual page is with the Virtual module. The data array is first initialised with one element. After the array is updated the swiper modules does not reflect the change. You can check the logs in the console.
http://localhost:xxxx/virtual-key: /virtual-key page is with the Virtual module and Swiper component is wrapped in #key  which reinitialises the component when the data array is updated which at least allows scrolling. After the reinitialization, on some scrolling the slideChange event emits starts emitting continuously with different realIndex values. The from value from virtualData also keeps changing. Here's a video:

https://user-images.githubusercontent.com/106158714/212871846-14c16a73-915e-4c14-b5f3-8e355b0e25f7.mp4
Expected Behavior
There are 2 problems:

Updating the array should append the slides to swiper (on /virtual page)
On scrolling in virtual mode the slideChange event should emit the correct index value.

Actual Behavior
Described above
Swiper version
8.4.5
Platform/Target and Browser Versions
macOS Chrome 109
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

New Swiper v9 doesn't have Svelte components anymore, it is recommended to use new Swiper Web Components instead.


Fixes the CRC32 calculation for FINGERPRINT

Added a golden-standard unit test for fingerprint calculation. The hardcoded expected value on the unit test was calculated using boost's C++ implementation of CRC32. This code was fixed by using CRC_32_ISO_HDLC algorithm on CRC calculation.
This fixes https://github.com/webrtc-rs/webrtc/issues/75

Please run “cargo fmt”


/Imu/data values never change

The values published in /imu/data for the orientation never change or change very slowly. My initial guess is that since /imu/data_raw and /imu/mag are on different nodes now, the Magwick filter can't find matching timestamps for both. Or, that the scale of one of the instruments has been reduced ( and thus the very slow movement).

The problem comes from the l3gd20 gyroscope driver, where the sensitivity is not applied and thus the results are not in udps as expected:
https://github.com/sbrodeur/ros-icreate-bbb/blob/master/src/imu/drivers/l3gd20/l3gd20.c#L667
I think this was commented out to avoid overflows.

The orientation problem is fixed with commit 8a986ce.
We only need to figure out why soft-iron correction doesn't work anymore (and was thus deactivated).

Tested and fixed with commit 4db406b.


fix(ghost_text): safely apply virtual_text highlight

Fix #1565.
Somehow, commit 5a80cd4 introduce a regression where experimental.ghost_text cannot be enabled with a boolean anymore.
This fix check first the type of the ghost_text config before applying the highlight.

LGTM.


Option to hide toolbar button captions

Is your feature request related to a problem? Please describe.
As an user who uses TumblThree in another language than english, it's sometimes disturbing that the toolbar button widths are very different due to longer translations in other languages.
Describe the solution you'd like
There should be an option in the settings to hide the toolbar button captions. If this setting is enabled, only the icons would be shown on the buttons and thus the buttons are all equal width.
Maybe instead of showing no help at all, the caption texts can be shown as a tooltip.
Describe alternatives you've considered
To leave it as it is.
Additional context

As before this one is for first-timers-only. That means that we will only accept a PR for this one from someone who's never contributed to open source before. This one is particularly easy (but don't make that statement make you feel bad if you have a hard time with it, there's more to contributing to open source than changing lines of code, especially if it's your first time). We walk you through it if you need help. :-) Here are the steps to get a PR merged (see also our guide).
There should be an option in the settings to hide the toolbar buttons' caption. If this setting is enabled, only the icons are shown on the buttons and thus the buttons are all equal width.
Additionally, if the option is enabled, a tooltip shall be shown on the buttons. The button captions can be used as texts for the tooltips.

[x] Create a fork of the repository
[x] Clone it to your local disk and create a new branch (e.g. 000-hide-toolbar-button-captions)
[x] Look which class and view is dealing with the toolbar buttons. How can a tooltip be shown on the buttons? What needs to be changed?
[x] Add your solution
[x] Build the app and run it
[x] Check the toolbar in the default/english language. Does it work as expected? Is a tooltip shown for all the buttons on hovering?
[x] Switch the languages in the settings, restart the app and check again.
[x] Commit your changes mentioning "issue #000" somewhere in your commit message title or description
[x] Push your changes to your fork, create a PR, get merged, celebrate??

We are happy to support you if you need help.

Hi could I take on this issue if possible

Hello,
thanks for your interest. Yes, you can work on that issue.
If you have a question or get stuck, feel free to ask.

Thank you for your first contribution and PR to our TumblThree project.
Your PR has been merged and you've been added to our list of contributors.
We would be happy to receive more contributions from you in the future. Maybe you can help us with one or the other issue.


"FĂLTICENI" is listed in the drop-down menu

Description:
When user writes "FĂLTICENI" the location appears in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Type "FĂLTICENI" in the search bar.

Expected results
The location is listed in the drop-down menu as "Oraș FĂLTICENI, SUCEAVA (FĂLTICENI)".


Update Anthropic3ChatOptions.java

The constructor needs to be public so that the options can be correctly copied over to the runtime call.

Will review, thanks.  Note, a better anthropic experience can be found using the Bedrock Converse support that was recently added.

merged in 1453198c5b9b0e1996527747be584ebd7bcc5fd3
sorry it took so long.


fix(action-sheet): show correct cancel button background on dark mode

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: https://github.com/ionic-team/ionic/issues/21082
What is the new behavior?

Added correct css var

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

I am not sure why the cancel button originally defaulted to --button-background-selected. @brandyscarney was this a typo or is there a reason for this?

@liamdebeasi It uses the same as the selected background on purpose since the cancel button isn't the same as the other buttons. In native iOS:


how to add a global component

export const createApp = ViteSSG(
  App,
  { routes },
  (ctx) => {
    Object.values(import.meta.globEager('./modules/*.ts')).map(i => i.install?.(ctx))
  },
)

returned a function instead of an app instance. How to add a global component?

can you share a minimal repro?

I'm so sorry this is a mistake that I post the issue to wrong repo.


PDF Step Text misaligned

Describe the bug
The text of the steps is misaligned for sozialpass pdf

To Reproduce
Steps to reproduce the behavior:

Create a sozialpass card

Expected behavior
Text should be aligned properly

hi @hauf-toni , seems like the pdf-template for sozialpass is misaligned
https://github.com/digitalfabrik/entitlementcard/blob/main/administration/src/project-configs/nuernberg/pdf-template.pdf

@hauf-toni
this part somehow looks a bit misaligned. check the double "nn"

@f1sh1918 I can't really explain where this comes from, but I checked the pdf again and re-exported and uploaded it


[FLINK-29105][k8s] Fix the unstable k8s test 'testAddAndLockShouldNotThrowAlreadyExistExceptionWithSameContents'

What is the purpose of the change
Fix the unstable k8s test testAddAndLockShouldNotThrowAlreadyExistExceptionWithSameContents
Brief change log
Verifying this change

Already covered by the existing UT

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I could reproduce this issue by running about more than 500 times locally. Maybe the FutureUtils.retry run too fast in your machine :)

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

All the failed pipelines are caused by FLINK-29121.
It is unrelated to this PR. Merging now.


Added heap sort algorithm

I need some changes for the commit:

Please use std::vector for your arrays, and use templates as the other files cause the sorting algo's will not be used only on arrays with integers.
If you can make it with Iterators(See merge_sort.h for example) it would be nice, otherwise just make it with vectors and not C-like arrays.

I don't see the added value of using an iterator as the indexes here are used to sort the vector as a binary tree.

Thank you for your contribution. Please read the CONTRIBUTE.md file in order to complete all the steps before making a pr. This time i completed the steps for you.


Change just a specific option

Hi!
Is it possible to change one specific option of the pivotUI without having to overwrite all the existing options?
Thanks

I think you can't. Even when you need to redraw the UI to add new data you have to recreate it, as far as I know.

That's correct, it's all or nothing: the whole thing is rerendered any time any option is changed anyways.


License updates for dependabot/github_actions/nanasess/setup-php-3.3.2

This PR was auto generated by the licensed-ci GitHub Action.
It contains updates to cached github/licensed dependency metadata to be merged into dependabot/github_actions/nanasess/setup-php-3.3.2: (branch, PR).
The licensed-ci action will add comments to this PR with the status of license checks.  Please make any changes needed to fix any status failures on this branch, then merge license updates into your branch.
If updates are unexpected, please check the github/licensed changelog for recent updates.

The licensed-ci GitHub Action updated cached license metadata based on changes to dependabot/github_actions/nanasess/setup-php-3.3.2: (branch, PR).
licensed status result: SUCCEEDED
All status checks succeeded, please merge when ready.
Checking cached dependency records for licensed
....................
20 dependencies checked, 0 errors found.

/cc @jonabc


docker run failed on overlay network since "failed to set link up: transport endpoint is not connected"

docker version:
1.11.2  on ubuntu 14.04
docker network ls:
NETWORK ID          NAME                 DRIVER
6a1fa16db582        bridge               bridge
0aa8655e6fbc        host                 host
35873009d789        multi-host-network   overlay
f9705d542f03        none                 null

uname -a:
Linux c55c4e23c9d714361aa1be6b7a97e7c63-node1 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

When I start container on overlay network, docker daemon return error：
root@c55c4e23c9d714361aa1be6b7a97e7c63-node1:~# docker run -it --net multi-host-network busybox
docker: Error response from daemon: subnet sandbox join failed for "<IP_ADDRESS>/16": vxlan interface creation failed for subnet "<IP_ADDRESS>/16": failed to set link up: transport endpoint is not connected.

And I still can't start the container after restart docker daemon service.
I produce this error many times at 1.11.x, but I don't know how to reproduce this, and how can I workaround this problem without restart host.

@vikstrous I saw you have meet this issue in docker/docker#22486, have you meet it again? and how you workaround it.

Yes. I have seen it on 1.11.2 but probably only once or twice. It might be some kind of race condition. I don't have a workaround other than to restart the machine. @mavenugo @mrjana might be able to provide more info.

@vikstrous use ip link del vx-xxxxx-xxxx and restart docker-daemon can workaround, but why transport endpoint is not connected error occur frequently at 1.11.x docker daemon?

10: ov-000100-35873: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default
    link/ether 2e:95:32:2f:f5:5c brd ff:ff:ff:ff:ff:ff
11: vx-000100-35873: <BROADCAST,MULTICAST> mtu 1500 qdisc noop master ov-000100-35873 state DOWN mode DEFAULT group default
    link/ether 2e:95:32:2f:f5:5c brd ff:ff:ff:ff:ff:ff

It's the ip link result when I meet this error, the vxlan interface has same mac address with the bridge, is it cause the vxlan interface can't be up?

https://github.com/docker/libnetwork/issues/1100

@BSWANG honestly, I don't know exactly what is causing this issue either. I saw it once in @vikstrous testbed and yes restarting the daemon solved the problem. Also thanks for pointing out to the same mac-address used for the bridge and vxlan interface.
@mrjana @sanimej wdyt ?

"same mac-address used for the bridge and vxlan interface"

Yeah same mac-address in bridge and bridge port is not an issue. It's always like that. Bridge inherits the lowest mac-address of one of the bridge-ports because bridge ports themselves don't need their mac. The issue happens because in older kernels when a vxlan interface is created, the socket creation is queued up in a worker thread which actually creates the socket. But this needs to happen before we bring up the link on the vxlan interface. If for some chance, the worker thread hasn't completed the creation of the socket before we did link up then when we do link up the kernel checks if the socket was created and if not it will return ENOTCONN. This was a bug in the kernel which got fixed in later kernels. That is why retrying with a timer fixes the issue.

@mrjana Thanks, I got the root of this issue. 👍


aur vercmp-devel undocumented aur repo arguments

Using 2.0.0rc. vercmp-devel has no documented options. I see in the source that it forwards it's arguments to aur repo which is very useful as it allows aur vercmp-devel --database=custom usage.
I didn't get a whiff of this from the documentation though so I think this would be useful to add.

Good point, we should add something like this to manpage: "all arguments are being forwarded to aur repo, see aur-repo(1) for details".


Completion does not work under JupyterLab?

I managed to make ihaskell work with jupyterlab (I really need the vega support), with current master from github. So that syntax coloring works. But code completion does not. Is it only me (i.e. I messed something), or is it totally unsupported for jupyterlab?
And if so, can someone give some guidance where to start if I would like to add it?

I don't think it's you, I couldn't seem to get it working either. @MMesch might know how to fix this.

I don't have it working either. I never tried to get it working and unfortunately I don't even know where to start out of my head. It might be easy.

I tried this recently and code completion seems to work for me. Please reopen if this is still an issue with the latest version of JupyterLab.


Will you make OBS Bypass?

I'm a fan of your source code, And I'm having trouble adding a hook.

Up for this also ❤


fix that addColumn adding a table_cell node when a table has only one row that consists of table_header nodes

closes #125

This method is not correct for some patterns, so I will close it for now.


Master

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #
What this PR does?
Summary:
Special notes for your reviewer?

sorry


Michael h changes

@daniaki

John recently pushed an update fixing the breaking hail change, so update your branch with the 'update branch' button when you have time.


Merge Uat ke Master 5 July 2017

Optimize query monitoring surat perintah produksi

Coverage remained the same at 65.29% when pulling 5bce4f3b9666c212a91fd127c684bac176aa5cf5 on uat into 51c93c6db0f592c8eab9713cb12c9202e509b51e on master.


Card interaction inconsistencies & bugs

I've had a bit a play with the editor and found a few cases where the card menu / interactions didn't behave as I expected. I've collected them together into one issue, but let me know if I should do this differently.
1. Initial card has no add menu
I already mentioned in #8191 that I can't use tab to get to the editor. Therefore I'm either using the mouse to click or the down arrow.
When I get my cursor to the editor, I can type, but I do not get the card + menu. If I type a character and delete it, or just hit backspace, then the + appears and then jumps down really far!
2. Extra paragraph added above image card
If I use the + menu on a brand new empty line to add an image card, it gets added after the empty paragraph, instead of inline.
This doesn't happen if I drag an image onto the editor. It also doesn't happen if I add an embed card.
I tested this on the previous version of the card selection and had the same problem - it was not the old empty para above and below the cards. It's an extra additional paragraph, or rather the one I'm on doesn't get removed. As far as I can tell this doesn't happen for any other card.
3. No way to delete markdown card
There's a cancel and a save button, but no delete.
4. No way to get cursor after a non-text card
Once you add an image, ember or markdown card etc - any non-text card, it is no longer possible to get the cursor to go after it, to add a new text card.
5. Console error & cards stop working
There is a case where I can no longer add cards and I get the following error in the console:

I don't know what the reproduction case is for this at the moment, it happens after I've added and removed a few cards, when I try to add a new card.
6. Unknown error and cursor not working
Not sure how I got this one, only saw it once.

This was an editor that had a text card and a markdown card. I saw this error appear twice whilst clicking around. I wasn't able to insert my cursor back into the text card with my mouse anymore.
7. Markdown text appears in text card
I also managed to achieve this by pressing the delete button at an opportune moment

Note: Issues 6 & 7 I have only reproduced one time. Issue 5 I get fairly regularly. I will continue to play with the editor over the next few days to try to narrow down reproduction cases for each bug.
Question:
I prefer the new selection over the older version. Not sure what the full plan is, however if I hit backspace or delete with the card selected (I think hard selected - double border), that no longer works at all (before it did it without any obvious selection, which is not good either, obviously :D). Is that the intentional?  I don't know why, but clearly from using some other product I expect the first press of backspace when I'm after the card to hard-select, and the second one to actually delete? This is more of a suggestion than anything.

[ ] 1. Initial card has no add menu
[ ] 2. Extra paragraph added above image card
[ ] 3. No way to delete markdown card
[ ] 4. No way to get cursor after a non-text card
[ ] 5. Console error & cards stop working
[ ] 6. Unknown error and cursor not working
[ ] 7. Markdown text appears in text card

Technical Details
Ghost-Admin: f5fc35f
Browser: Chrome 56

Closing / moving to #8194

should become more clearer when 3. is fixed.

If a card is selected but isn't being edited then pressing enter will create a new paragraph below it.
The default way that mobiledoc works is it has a cursor that sits on the side of the card but it wasn't the greatest in terms of usability.
A potential solution is if the newly created card is the last element in the document then we automatically create a blank paragraph under it so that you can select it (when a card is selected but not in edit mode you can navigate in and out of it using the arrow keys on the keyboard).

@disordinary I think this comment / discussion belongs on #8194?


⚠ Jenkins Plugins Artifactory has degraded performance

In e90ac28, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1569 ms

Resolved: Jenkins Plugins Artifactory performance has improved in dc91187 after 18 minutes.


Local pull request success status testing

Docs Build status updates of commit 4f0ed38:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 4f0ed38:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Running Angular 6 app in VS 2017

Hello! Is it possible to run an Angular 6 app in VS 2017? I'm running 15.8 Preview 3, which has Node.js Tools 1.4.20606.1 Commit Hash:9d5755c0d5f08ad9c5e0051bedb602a3de834d3e. Running an app with VS requires setting a startup file, but an Angular 6 app using angular-cli doesn't have a file like that. I can build and use everything else, so I can just manually call ng serve, but I figured I'd check if it's possible to do through VS itself.
Thank you!

You can try this using the Open Folder support in VS, which supports running npm scripts from the context menu on package.json.
But for additional support we need to make a lot of changes to the project system, which we're considering but will take some time.


[Feature Request] Images functions to help with caching

API to allow:

Check if image already exists in BKTUI (so we can cache stuff instead of getting from the API across game restarts)
Clear all images for a mod (when I'm caching stuff like world/avatar icons, removing all icons to clear the cache might be useful)

I've added QuickMenuAPI.DoesIconExist in 1.2.0-preview2, as for clearing all icons from a mod, I don't think this is something I would implement here as it would be all or nothing, if a path is required to clear a certain part the mod itself might as well do it internally.


configure rubocop to enforce coding style on the project

The patch is huge, but it only configures rubocop rules, and applies them. Also it includes corresponding workflow for Github Actions.
Not all style issues has been fixed. See .rubocop-todo.yml
fixes #54

@simkim, @giallon, could you take a look? I cannot assign reviewers here.


operator hive-operator (1.2.3777-97dd9ae)

Update Hive community operator channel(s) [['alpha']] to 1.2.3777-97dd9ae
/hold

/unhold

/hold

/hold cancel

/merge possible

/merge possible


Add an option to use the repository from the package.json

That would be the canonical repo, so would make sense (at least in my case) to use it as "src.pushRepo".

The default (for git push) is whatever is configured to be the push origin in the local repo (see git remote -v). Also, I think by default the repository.url in package.json should match this (not the other way around).
Apparently, you have a different setup, so you can override src.pushRepo any way you like.
Please let me know if I'm misunderstanding you. Feel free to re-open, but I'm closing it for now.

I normally have that setup too, and most people will. But the git configuration is defined by the local dev and the codebase itself has no input into how the local setup looks. Conversely, the package.json is defined by the codebase and can point to the known canonical repo no matter what the local setup looks like. If I'm publishing to NPM, then I want the tags in the canonical repo.
Take this situation.

git clone (origin URL) repo
cd repo
(Do some work but don't finish)
(Quick! There is a production bug to fix! Let's create a second working directory to deal with it)
cd ..
git clone ./repo repo2 # local clone is faster
cd repo2
(Fix bug quick!)
release-it patch

Now I've pushed the tag to ./repo instead of (origin URL) which is incorrect. If release-it used the package.json value I would have been fine.
Does this make sense?
You also mentioned that I can set src.pushRepo to whatever I want, but hardcoding the value twice in the codebase is not DRY and could cause issues if we move the repo later. What I've done so far is set up a script that reads the value from package.json and then programmatically calls release-it with a generated config.
I raised this improvement so it could be easier for others in the future. But if you see things differently that's cool. Cheers!

Regarding the extra local clone. In the situation you describe, I would stash my work, go to the branch, fix, release, change back to branch I was working in, apply stash.
And, imho the need to change this in two locations (if at all? YAGNI?) doesn't weigh up against creating that script. DRY is great, but not at all costs.

Thanks Lars, I think I just realized that release-it is not for me. Not because you're not implementing this (like I said, I'd already solved it), but because the value I was getting out of using it was already minimal, and it sounds like you're generally not interested in supporting more flexibility in workflows.
To address your two points (just for the sake of offering another perspective - I no longer have a vested interested in this):

Regarding the extra local clone. In the situation you describe, I would stash my work, go to the branch, fix, release, change back to branch I was working in, apply stash.

Yeah that is sometimes better. But it completely ignores the cost of changing branches. On large projects, an initial build after checking out new code can take minutes. Having a second working directory available means you don't incur that cost when switching back to the feature you were working on. It's a valid workflow. The only reason it wouldn't be a valid workflow is that Git now has a feature to share a repo between two working directories. But most people don't know that and will still do the local clone - this is a footgun for them.
Of course this isn't the only case right? I could imagine someone has their own remote fork of the canonical repo. If they do a release locally, tags will be pushed to their fork and not the canonical. I'm sure there are other real world cases that would benefit from a codebase-controlled repo URL.

And, imho the need to change this in two locations (if at all? YAGNI?) doesn't weigh up against creating that script. DRY is great, but not at all costs.

Repos change location all the time - when people switch hosting providers, or when, for example, Node was forked into IO.js, or again when the fork was merged. Offering one place to fix that would remove a potential bug for them.
It's also a bit of hyperbole to call this script "all costs" - it's really trivial to write. Here is one implementation (untested):
if (config.src.pushRepo && config.src.pushRepo.usePackage) {
    config.src.pushRepo = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'), 'utf8').repository.url;
}

It would support config like:
src : {
    pushRepo: { usePackage: true }
}

Anyway, best of luck!


Fixed cart-rule conditions ui

Issue Reference
Fixed cart-rule conditions ui

@shivendra-webkul
Please check the PR again as there are some conflicts in  them. Please resolve them.

@shivendra-webkul
After merging the PR issue realted to UI and response is appearing. Please check the screenshots for reference,
https://prnt.sc/F8SFFmcl20US

Duplicate code added in this PR So I am closing this. Check new PR https://github.com/bagisto/bagisto/pull/9281


Potential problem with scheduling destination folders

Hi,
I think we have a problem with scheduling destination folders.  I have three tmp and three dst folders.  What I see is that the current algorithm is kind of randomizing the order of dst drives in groups of three (the number of provided dst folders in my case).  What it ends up with is that sometimes the last folder from a group of three is the same as the first one from the next group.  As such, this is prone to the collisions during the final copy process.  Yes, that could potentially cause a massive collision, when one of the dst folders/drives is much bigger than the rest of the group.  However, we all should understand that the reason that we are using this software is to simplify all the management tasks.  At the same time, we should also realize that providing adequate resources (same size drives, etc.) is also a part of the same process.  (Actually, I stop plot creation before disks are full, and have a lame computer to trickle plots to top those disks off.  This way, the main plotter runs smoothly.)
Maybe the dst folder assignment should be just a simple round robin selection, where folders that were smaller would at some point drop off from the scheduling list.
Thank you, Jacek

Hey Jacek,
I am do agree that the the selection of the best destination volume could be better optimized. As it currently stands it sort the final drives in ascending order by the number of pending plots on those drives. If that number is equal then it sorts the drive be free space. I think this is the simplest solution for now, unless I misunderstanding your analysis. If the final drive does not have enough space for the final plot then it is removed from consideration in the lines that follow this sorting process.
$sortedVolumes = $ChiaVolumes | Sort-Object -Property @{Expression = {$_.PendingFinalRuns.Count}; Descending = $false},@{Expression = "FreeSpace"; Descending = $True}

Hi Syrius,
My take is that the sorting should be done only based on plot counts (whether already there, or still can fit).  Adding free space sorting, based on sub plot granularity is rather doing harm.  Say that we have three dst folders of size 10 plots each (HD size vary by kbytes or so - irrelevant as far as plots).  When we need to make a choice, we have the following setup: 5, 5, 4 (plots already there, or 5, 5, 6 plots that can fit).  So, we go with the third folder.  The next time we need to chose a folder, we have 5, 5, 5, so we go for a free space, and we get 5.1, 5.2, 5.0 (due to small variation in plot sizes, or HD sizes - negligible, but used to make a selection).  Based on the second sort (free space), we need to again pick up the third folder.  Therefore, we end up with two plots in the row that target the same dst folder.  That is what I see on my box.  And yes, I saw final copy collisions due to that.  Also, I have only 10 phys cores, so I imagine for those that have more, this may be a bigger issue.
If, on the other hand, selection granularity is only based on plot counts (e.g., those 5, 5, 6 followed by 5, 5, 5), we will get a round-robin output that mitigates collisions.
Where this process will be sub-optimal is when people put say three dst drives, and one has much more free plot space (e.g., 10, 10, 20).  Just looking at current plot counts and free space would not be enough, but maybe a table of dst folder targeting would be a better choice (e.g., the normal run would be 1 2 3, 1 2 3, ..., where in this case, we would need to run 1 3 2 3, 1 3 2 3, regardless of plots in and/or free space sorting.
It gets more complicated, when all drives have really different sizes (e.g., 10, 20, 30).  Maybe one way to approach it would be to break the selection into two parts.  We will always do calculations, based on how many plots can still fit.  However, the first phase will be to bring the folder with the highest count to the same level as the rest.  Once we balance them off (if we can, as it would rather be not possible without collisions for something like 10, 20, 100), we go with just the number of plots that can still fit till all disks are full.
Not sure, whether all that makes too much sense, though.
Thank you, Jacek

I do want to to quickly clarify that the PendingFinalRuns property that is sorts by first is the total number of chia processes currently running that have that drive as their final destination.
So for example, if you start a new job with 4 queues (or a total of 4 parallel plotting processes) and 3 final drives. The first run will pick the drive with the most space since all the final drives have 0 chia processes waiting to create a plot on them. So now we have 1 drive that has 1 PendingFinalRuns, and two drives with 0. The next run will first check to see which drive has the lowest number of chia plotting processes associated with it, so in this case it will skip the the drive that the first run picked and chose one the one of the other two drives that have zero chia processes associated with them. Since there are 2, it will pick the one with the most space since it has to decide somehow, which is why I have a 2nd sorting mechanism, if I didn't have this sorting then it would chose the next drive at random. The next run will pick the last of the 3 final drives which has 0 chia processes waiting to create a plot on.
So now each final drive has been chosen once and there are 3 runs each with a different final drive. Now the 4th run starts and it must decided which drive to pick. Each final drive has 1 plot that will be created on it in progress, so it must decided somehow, so it picks the one with the most space (which is probably the same one that the run 1 chose) so it most likely picked the one that is less likely to run into a collision with. Now this gets very complicated if you have LOTS of parallel runs and multiple jobs.

Yes, we fully agree on the first level selection (pending plots), and general concept of the second selection.  So, let's focus on that 4th selection.
If we assume that all drives have exactly the same size (no HD variations), then the logical assumption will be that all have the same amount of free space.  That is what is being done right now.  So, we should expect 1, 2, 3, 1, 2, 3 queue order.
What I am saying is that plot sizes differ (by not much).  So, going along with your sorting, we have 1, 1, 1 (pending plots) already there, and we ask for a free folder space to make the final decision.  However, instead of getting a wash, we get drive preference based on those minute size difference of those plots., Therefore, I saw drive selections 1, 2, 3, 3, 1, 2, what leads to collisions.
Therefore, my take is that it would be better to use a "free plot slots" size, instead of a "free disk size" as the second level selection.

I see! I fully understand what you are saying now. Sorry I can be a bit dense sometimes. Having what you suggested should be doable and I will see if I can implement when I have finished up with some of the other features. I will be sure to add it to the roadmap.

No worries, it was my fault, as I had troubles to properly articulate it.  When I first saw it, I was not really sure why it is happening, so your clarification about the sorting process helped me to zoom in on it.


plotting data in lists (instead of arrays)

Hey there Scott, wondering if there are any technical reasons for using arrays rather than lists for plot data. Is it currently possible to use lists, or is this something you would consider implementing? Wondering because lists have some benefits over arrays in terms of dynamically appending elements which is useful in my case at least :-)
I know that I can use .ToArray().

Hey @Resonanz, right now all functions are written only to support double arrays. To understand why I'll restate your question in a way that makes the answer a bit more obvious: Instead of just supporting double[], why not also support float[], short[], int[], long[], byte[], decimal[], List<double>, etc...
The simple answer is that it's a lot more code (and function overloads) to support, so strictly supporting double[] seemed to be the best compromise.
There is a WinForms demo has a "live data" tab (#163) which shows how to plot incoming data (which I think is from a list that grows as data comes in). You may find this useful if your application does something similar.
Support for genetics (<T>) was discussed at one point (#103) but due to some complicated reasons this wasn't implemented. One exception is SignalConst<T>() which does support plotting of generics. @StendProg did some excellent research on this topic and wrote conclusions here: https://github.com/swharden/ScottPlot/issues/103#issuecomment-522262826


refactor(halo): extracted invitation management into serviceContext from serviceHost

Motivation
Services use Managers to manage data (Service -> Manager).
All spaces are created through DataSpaceManager. On space creation, DataSpaceManager will attach a listener of spaceState to handle delegated invitations.
DataSpaceManager shouldn't have access to InvitationService (Service <- Manager).
Create a class that'll be used by both DataSpaceManager and InvitationService, and that'll manage invitations preventing duplicates.
Details

Created InvitationsManager and pulled the majority of code from InvitationsService there.
Fixed duplicated subscriptions on existingInvitation return (added early return for existing invitations).
Fixed missing subscription for invitations created in loadPersistentInvitations (for _createInvitations updates) and .filter(async (invitation) always returning true.
Reordered operations in cancelInvitation (remove persistent invitation from metadata store first).

LGTM


[Tokens] Raw brand-specific color tokens renaming

Description
Raw color tokens, common or specific to a brand, should have the same prefix in the library. They will be generated this way by the parser that will handle design tokens.
So this issue means that each and every colorBrand* raw token should be named "color*" instead:

colorBrandOrange{100 to 900} → colorOrange{100 to 900}
colorBrandWarmGray{100 to 900} → colorWarmGray{100 to 900}

ℹ Released with version v0.4.0 🚀


正常使用的程序，今天微信扫码不能登录了

🚨 The issue tracker is not for questions 🚨
报错如下，请问是我哪里配置错了么？
https://api.qrserver.com/v1/create-qr-code/?data=https%3A%2F%2Flogin.weixin.qq.com%2Fl%2FQbIALbyCtw%3D%3D
17:35:23 WARN PuppetWeChatBridge onDialog() page.on(dialog) type:type() {
return this._type;
} message:登录失败。
(node:16196) UnhandledPromiseRejectionWarning: Error: type() {
return this._type;
}(登录失败。)
at PuppetWeChat. (D:\webchatBot\wechatBot\node_modules\wechaty\dist\src\wechaty.js:273:44)
at PuppetWeChat.emit (events.js:315:20)
at PuppetWeChat.EventEmitter.emit (domain.js:485:12)
at Bridge. (D:\webchatBot\wechatBot\node_modules\wechaty-puppet-wechat\dist\src\puppet-wechat.js:203:45)
at Bridge.emit (events.js:315:20)
at Bridge.EventEmitter.emit (domain.js:485:12)
at Bridge.onDialog (D:\webchatBot\wechatBot\node_modules\wechaty-puppet-wechat\dist\src\bridge.js:129:14)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:16196) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:16196) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

+1

+1

+1

微信把uos封了

+1

Merge to:

https://github.com/wechaty/puppet-wechat/issues/192

+1

+1


Rename the default gateway environment "Production and Sandbox" to "Default"

Description:
Fix the following in the documentation.
Current default config:
[[apim.gateway.environment]]
name = "Production and Sandbox"

Expected Config:
[[apim.gateway.environment]]
name = "Default"

Related Issues:
https://github.com/wso2/product-apim/issues/10477

This Git issue duplicates the following issues:

https://github.com/wso2/docs-apim/issues/4213
https://github.com/wso2/docs-apim/issues/4212
https://github.com/wso2/docs-apim/issues/3560