CustomInventory capacities are broken

A custom inventory created with archetype CHEST will not accept items inserted into slots greater than ordinal 26 (the max slot in a single-chest), regardless of actual capacity (set via the InventoryDimension property). Futhermore, attempting to create an inventory of this archetype with fewer than 27 slots will result in an IndexOutOfBoundsException upon calling build. Stack trace.
I have replicated this on SpongeForge; however, I have not yet tested on SpongeVanilla. I'll move this issue if necessary.

I sense some hard coded values somewhere...

I'd say it's probably getting tripped up on some validation code within MInecraft or something.

@Faithcaio


allowFullscreen in Figma behaves unpredictably

Bug

Description: When embedding Figma designs, story without allowFullscreen affects story with allowFullscreen: true.

Versions: 5.4.2

Reproduction:
a.  There is no option to the view Figma design in fullscreen, which there should be.

b.
Go to a page without allowFullscreen: https://pocka.github.io/storybook-addon-designs/?path=/story/docs-figma-examples--embed-file. There is an option to the view Figma design in fullscreen, which there shouldn't be.

Thank you for the detailed report even without an issue template (sorry for that I'm a too lazy man :pig2:)!
It seems that the preview component not refreshing properly. I'd like to ship the patch for this in the next patch release.

Thank you for the detailed report even without an issue template (sorry for that I'm a too lazy man :pig2:)!
It seems that the preview component not refreshing properly. I'd like to ship the patch for this in the next patch release.

Thank you for the detailed report even without an issue template (sorry for that I'm a too lazy man 🐖)!
It seems that the preview component not refreshing properly. I'd like to ship the patch for this in the next patch release.

Great to hear and thank you. I would like to give as much information as possible so we will get things done faster! 😃

Thank you for the detailed report even without an issue template (sorry for that I'm a too lazy man 🐖)!
It seems that the preview component not refreshing properly. I'd like to ship the patch for this in the next patch release.

Great to hear and thank you. I would like to give as much information as possible so we will get things done faster! 😃

Fixed in v5.4.3.

Fixed in v5.4.3.


Doesn't work with Angular 9

Hello everyone!
After updating Angular version from 8 to 9 this component started to give me an error in runtime (it compiles correctly).
The error occurs in "ng-simple-slideshow.js" :
setStyles() {
...
this._renderer.removeStyle(this.container.nativeElement, 'background-color');
}
The error is that "this.container" is null
Some help regarding this issue would be more than welcome!
Thank you!!

Can confirm. It is not working from a fresh angular 9 project

I have the same issue (Cannot read property 'nativeElement' of undefined, this.container being null)

When I used the beta version, the error is no longer there, but I don't see anything on the page. When I inspect it, the slideshow element is there but nothing to see visually

When I used the beta version, the error is no longer there, but I don't see anything on the page. When I inspect it, the slideshow element is there but nothing to see visually

Same happens to me!

I am currently using the beta in production, and it's working for me at least (example: https://simply-how.com/getting-started-with-java-11, right panel of the IntelliJ IDEA usage section)

Same issue is happening with me i tried to fix it but it didn't go well .

npm install<EMAIL_ADDRESS>just type this on your terminal .beta version is working for me

When I used the beta version, the error is no longer there, but I don't see anything on the page. When I inspect it, the slideshow element is there but nothing to see visually

Same happens to me!

[imageUrls]="imageSources"
[height]="height"
[minHeight]="minHeight"
[arrowSize]="arrowSize"
[showArrows]="showArrows"
[disableSwiping]="disableSwiping"
[autoPlay]="autoPlay"
[stopAutoPlayOnSlide]="stopAutoPlayOnSlide"
[debug]="debug"
[backgroundSize]="backgroundSize"
[backgroundPosition]="backgroundPosition"
[backgroundRepeat]="backgroundRepeat"
[showDots]="showDots"
[dotColor]="dotColor"
[showCaptions]="showCaptions"
[captionColor]="captionColor"
[captionBackground]="captionBackground"
[lazyLoad]="lazyLoad"
[hideOnNoSlides]="hideOnNoSlides"
[fullscreen]="fullscreen">

ts code :
imageSources: (string | IImage)[] = [
{ url: 'https://cdn.vox-cdn.com/uploads/chorus_image/image/56748793/dbohn_170625_1801_0018.0.0.jpg', caption: 'The first slide', href: '#config' },
{ url: 'https://cdn.vox-cdn.com/uploads/chorus_asset/file/9278671/jbareham_170917_2000_0124.jpg', clickAction: () => alert('custom click function') },
{ url: 'https://cdn.vox-cdn.com/uploads/chorus_image/image/56789263/akrales_170919_1976_0104.0.jpg', caption: 'Apple TV', href: 'https://www.apple.com/' },
'https://cdn.vox-cdn.com/uploads/chorus_image/image/56674755/mr_pb_is_the_best.0.jpg',
{ url: 'assets/kitties.jpg', backgroundSize: 'contain', backgroundPosition: 'center' }
];
height: string = '400px';
minHeight: string;
arrowSize: string = '30px';
showArrows: boolean = true;
disableSwiping: boolean = false;
autoPlay: boolean = true;
autoPlayInterval: number = 3333;
stopAutoPlayOnSlide: boolean = true;
debug: boolean = false;
backgroundSize: string = 'cover';
backgroundPosition: string = 'center center';
backgroundRepeat: string = 'no-repeat';
showDots: boolean = true;
dotColor: string = '#FFF';
showCaptions: boolean = true;
captionColor: string = '#FFF';
captionBackground: string = 'rgba(0, 0, 0, .35)';
lazyLoad: boolean = false;
hideOnNoSlides: boolean = false;
width: string = '100%';
fullscreen: boolean = false;
enableZoom: boolean = false;
enablePan: boolean = false;
noLoop: boolean = false;
dont forget to install and import the necessary packages

I am currently using the beta in production, and it's working for me at least (example: https://simply-how.com/getting-started-with-java-11, right panel of the IntelliJ IDEA usage section)

Would love to see your code along with package.json
I did try to add the beta version and there was no luck.

I have also removed all the entryComponents in my modules after migrating to Angular 9, it might be it for you (they are now deprecated with the new Ivy compiler)

I tried this with a brand new project. Don't have any entryComponents on mine.

package.json:
{
  "...": "...",
  "dependencies": {
    "@angular/animations": "^9.1.2",
    "@angular/cdk": "^9.2.1",
    "@angular/common": "^9.1.2",
    "@angular/compiler": "^9.1.2",
    "@angular/core": "^9.1.2",
    "@angular/forms": "^9.1.2",
    "@angular/material": "^9.2.1",
    "@angular/platform-browser": "^9.1.2",
    "@angular/platform-browser-dynamic": "^9.1.2",
    "@angular/platform-server": "^9.1.2",
    "@angular/router": "^9.1.2",
    "@nguniversal/common": "^9.1.0",
    "@nguniversal/express-engine": "^9.1.0",
    "ng-simple-slideshow": "^1.3.0-beta.11",
    "...": "...",
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.901.1",
    "@angular/cli": "~9.1.1",
    "@angular/compiler-cli": "^9.1.2",
    "@angular/language-service": "^9.1.2",
    "@nguniversal/builders": "^9.1.0",
    "typescript": "~3.8.3",
    "webpack-cli": "^3.1.2"
    "...": "...",
  }
}

app.module.ts & 1 another lazy loaded module where it's being used:
import { SlideshowModule } from "ng-simple-slideshow";
// ...

@NgModule({
  imports: [
    // ...
    SlideshowModule,
    // ...
  ]
})

page.component.ts:
import { MatDialog } from "@angular/material/dialog";
import { IImage } from "ng-simple-slideshow";

// ...
  constructor(
    public dialog: MatDialog,
    // ...
  ) {}

  // ...
  openSlideshow() {
    let images: IImage[];
    // ...

    this.dialog.open<SlideshowComponent, IImage[]>(SlideshowComponent, {
      data: images,
      width: "95vw",
      maxWidth: "100%",
      height: "95vh",
      maxHeight: "100%",
      panelClass: "slideshow-dialog",
    });
  }

slideshow.component.html:
<slideshow
  #slideshow
  [backgroundSize]="'contain'"
  [imageUrls]="images"
></slideshow>

Can't install the beta version on Angular 9.1
npm install<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 but none is installed. You must install peer dependencies yourself.

updating the package to<EMAIL_ADDRESS>worked for me

I have the latest Angular version and still doesn't work for me. I install the beta version and I don't see any error, but I just don't see the slider

Fix it, in my case, was that I didn't have display = block, I had display = flex.
When I changed it, it worked!

Fixed it. For my removing the «position=relative» on slideshow-container resolved the problem


Struggling to compile

Hi Ben,
I'm a bit of a novice at cross compiling using the Pico SDK and have some errors when I try and run cmake on a MacBook as per your article on the PicoW in MagPi125. The one causing most problems is where the SDK must be picking up a link to your version on GitHub 6 lines before the end of the error list. I havn't found where that is embedded yet. Unfortunately your article doesn't give full details - assumes a lot of past knowledge about using the SDK :
(base) MacBook-Pro:build Tony$ cmake .. -G”NMake Makefiles” -DPICO_BOARD=PICO_W -DWIFI_SSID=secret-deleted -DWIFI_PASSWORD=secret-deleted
CMake Error: Could not create named generator ”NMake
Generators

Unix Makefiles               = Generates standard UNIX makefiles.
Ninja                        = Generates build.ninja files.
Ninja Multi-Config           = Generates build-.ninja files.
Watcom WMake                 = Generates Watcom WMake makefiles.
Xcode                        = Generate Xcode project files.
CodeBlocks - Ninja           = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files.
CodeLite - Ninja             = Generates CodeLite project files.
CodeLite - Unix Makefiles    = Generates CodeLite project files.
Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
Kate - Ninja                 = Generates Kate project files.
Kate - Unix Makefiles        = Generates Kate project files.
Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.

CMake Warning:
Ignoring extra path from command line:
"Makefiles”"
(base) MacBook-Pro:build Tony$ make
[  2%] Built target bs2_default
[  3%] Built target bs2_default_padded_checksummed_asm
[  4%] Performing configure step for 'ELF2UF2Build'
CMake Error: The current CMakeCache.txt directory /Users/Tony/RPi_Pico/PicoW/picow_takeover-main/build/elf2uf2/CMakeCache.txt is different than the directory c:/Users/ben/Documents/GitHub/picow_takeover/build/elf2uf2 where CMakeCache.txt was created. This may result in binaries being created in the wrong place. If you are not sure, reedit the CMakeCache.txt
CMake Error: The source "/Users/Tony/RPi_Pico/PicoW/pico-sdk-master/tools/elf2uf2/CMakeLists.txt" does not match the source "C:/Users/ben/Documents/GitHub/pico-sdk/tools/elf2uf2/CMakeLists.txt" used to generate cache.  Re-run cmake with a different source directory.
make[2]: *** [elf2uf2/src/ELF2UF2Build-stamp/ELF2UF2Build-configure] Error 1
make[1]: *** [CMakeFiles/ELF2UF2Build.dir/all] Error 2
make: *** [all] Error 2
(base) MacBook-Pro:build Tony$

I think that the issue is with NMake -- that's a windows program. I don't
have a Mac to test, but I think you want "Unix Makefiles" for Mac OS.
Ben
On Mon, 19 Dec 2022 at 10:37, Tony A @.***> wrote:

Hi Ben,
I'm a bit of a novice at cross compiling using the Pico SDK and have some
errors when I try and run cmake on a MacBook as per your article on the
PicoW in MagPi125. The one causing most problems is where the SDK must be
picking up a link to your version on GitHub 6 lines before the end of the
error list. I havn't found where that is embedded yet. Unfortunately your
article doesn't give full details - assumes a lot of past knowledge about
using the SDK :
(base) MacBook-Pro:build Tony$ cmake .. -G”NMake Makefiles”
-DPICO_BOARD=PICO_W -DWIFI_SSID=secret-deleted
-DWIFI_PASSWORD=secret-deleted
CMake Error: Could not create named generator ”NMake
Generators

Unix Makefiles = Generates standard UNIX makefiles.
Ninja = Generates build.ninja files.
Ninja Multi-Config = Generates build-.ninja files.
Watcom WMake = Generates Watcom WMake makefiles.
Xcode = Generate Xcode project files.
CodeBlocks - Ninja = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles = Generates CodeBlocks project files.
CodeLite - Ninja = Generates CodeLite project files.
CodeLite - Unix Makefiles = Generates CodeLite project files.
Eclipse CDT4 - Ninja = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
Kate - Ninja = Generates Kate project files.
Kate - Unix Makefiles = Generates Kate project files.
Sublime Text 2 - Ninja = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.

CMake Warning:
Ignoring extra path from command line:
"Makefiles”"
(base) MacBook-Pro:build Tony$ make
[ 2%] Built target bs2_default
[ 3%] Built target bs2_default_padded_checksummed_asm
[ 4%] Performing configure step for 'ELF2UF2Build'
CMake Error: The current CMakeCache.txt directory
/Users/Tony/RPi_Pico/PicoW/picow_takeover-main/build/elf2uf2/CMakeCache.txt
is different than the directory
c:/Users/ben/Documents/GitHub/picow_takeover/build/elf2uf2 where
CMakeCache.txt was created. This may result in binaries being created in
the wrong place. If you are not sure, reedit the CMakeCache.txt
CMake Error: The source
"/Users/Tony/RPi_Pico/PicoW/pico-sdk-master/tools/elf2uf2/CMakeLists.txt"
does not match the source
"C:/Users/ben/Documents/GitHub/pico-sdk/tools/elf2uf2/CMakeLists.txt" used
to generate cache. Re-run cmake with a different source directory.
make[2]: *** [elf2uf2/src/ELF2UF2Build-stamp/ELF2UF2Build-configure] Error
1
make[1]: *** [CMakeFiles/ELF2UF2Build.dir/all] Error 2
make: *** [all] Error 2
(base) MacBook-Pro:build Tony$
—
Reply to this email directly, view it on GitHub
https://github.com/benevpi/picow_takeover/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHMR7ACWF7UHRYPVCNUOTOTWOA3FFANCNFSM6AAAAAATDGOH64
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Ben
I solved the source directory problem - I hadn't cloned the repository into my machine - just copied. Have now set the flags to use the Pico SDK on git hub rather than cloning it. I am cloning your repository so I can edit it.
I now get a compilation error that I can't understand:
[cmake] -- Configuring done
[cmake] CMake Error at /usr/local/Cellar/cmake/3.25.1/share/cmake/Modules/ExternalProject.cmake:2475:EVAL:2 (add_custom_command):
[cmake]   Attempt to add a custom rule to output
[cmake]
[cmake]     /Users/Tony/RPi_Pico/PicoW/picow_takeover/https.rule
[cmake]
[cmake]   which already has a custom rule.
[cmake] Call Stack (most recent call first):
[cmake]   /usr/local/Cellar/cmake/3.25.1/share/cmake/Modules/ExternalProject.cmake:2475 (cmake_language)
[cmake]   /usr/local/Cellar/cmake/3.25.1/share/cmake/Modules/ExternalProject.cmake:3165:EVAL:2 (ExternalProject_Add_Step)
[cmake]   /usr/local/Cellar/cmake/3.25.1/share/cmake/Modules/ExternalProject.cmake:3165 (cmake_language)
[cmake]   /usr/local/Cellar/cmake/3.25.1/share/cmake/Modules/ExternalProject.cmake:4185 (_ep_add_download_command)
[cmake]   CMakeLists.txt:23 (ExternalProject_Add)
[cmake]

Any thoughts on this, Ben. Googling the error doesn't give me much help for this particular case. The compiling creates a file in the build directory called https with contents a single line:
cmd=''
Tony

Hi,
That's an error I've not seen before. What exactly have you changed?
Also, have you tried a clean build (i.e. deleting the build directory and
starting again)? I've just realised that I committed the build directory to
github which I shouldn't have done.
Ben
On Thu, 22 Dec 2022 at 18:11, Tony A @.***> wrote:

Any thoughts on this, Ben. Googling the error doesn't give me much help
for this particular case. The compiling creates a file in the build
directory called https with contents a single line:
cmd=''
Tony
—
Reply to this email directly, view it on GitHub
https://github.com/benevpi/picow_takeover/issues/1#issuecomment-1363198140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHMR7AGMA35TPWPL77TO2M3WOSKTVANCNFSM6AAAAAATDGOH64
.
You are receiving this because you commented.Message ID:
@.***>


Feeds engine - Admin dashboard

[ ] create web app with CRA, add material UI, add react router
[ ] login form
[ ] my settings
[ ] users management grid (admin only)
[ ] user management form. no ACL system, just an 'admin' checkmark
[ ] posts management grid (for the 'news feed' only by now)
[ ] post management form.
[ ] file upload (picture field should be sent as base64 data url)
[ ] simple API class working with backend (axios-based)
[ ] jwt auth

@TomasGonzalez please start with UI part

@johnsmith-gooddollar this is not good. i was under the impression adonisjs provides all of this.
lets re-evaluate this. i've examined Strapi js which looks like exactly what we need.

We have done with essentials an all 3 levels (app backend admin)
Tomas have started some work on dashboard
A lot of time was spent
Strapi is another one CMS. You've asked to make custom feed without any cms backend.

Sorry I had to refuse You
We're continue working with the current implementation
ArtJoker guys are starting tomorrow

@sirpy
We have some option of CMS usage at the start, but you asked to make custom feed on ceramic. Now this solution is almost done the there's no reason to switch back
If you're aware the admin dashboard will take some time don't afraid if will be very simple and will use material design framework


[ISSUE #1700] Refactor shenyu-bootstrap release package structure

For #1700

Codecov Report

Merging #1735 (1a6a682) into master (8e41857) will decrease coverage by 0.62%.
The diff coverage is n/a.

:exclamation: Current head 1a6a682 differs from pull request most recent head f5d1b8d. Consider uploading reports for the commit f5d1b8d to get more accurate results

@@             Coverage Diff              @@
##             master    #1735      +/-   ##
============================================
- Coverage     62.98%   62.35%   -0.63%
+ Complexity     2384     2371      -13
============================================
  Files           478      478
  Lines         10238    10238
  Branches       1036     1036
============================================
- Hits           6448     6384      -64
- Misses         3276     3345      +69
+ Partials        514      509       -5

Impacted Files
Coverage Δ

...enyu/client/tars/TarsServiceBeanPostProcessor.java
25.67% <0.00%> (-32.44%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
45.26% <0.00%> (-17.90%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-15.54%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
72.41% <0.00%> (-13.80%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
:arrow_down:

...t/zookeeper/ZookeeperClientRegisterRepository.java
70.90% <0.00%> (-1.82%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e41857...f5d1b8d. Read the comment docs.


[Feature Request] Integrating domain models

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[ ] Consider asking first in a Discussion.

Motivation
Integrating domain models to build multi-agent systems with domain specific models:

[ ] Semiconductor: https://huggingface.co/pentagoniac
[ ] Math: https://x.com/deepseek_ai/status/1811020940480045103?s=46
[ ] Compiler Optimization: https://x.com/aiatmeta/status/1806361623831171318?s=46
[ ] Coder: https://github.com/deepseek-ai/DeepSeek-Coder-V2
[ ] Prover: https://arxiv.org/pdf/2405.14333
[ ] ChartGemma: https://huggingface.co/papers/2407.04172
[ ] SEED-Story: https://huggingface.co/TencentARC/SEED-Story

Solution
No response
Alternatives
No response
Additional context
No response

add new attribute: description for model


Add kpm role

example:
---
- hosts: localhost
  vars:
    kpm_namespace: test
    kpm_packages:
      - name: ant31/rocketchat
        namespace: chat
        state: present
        version: 1.6.3

      - name: ant31/rabbitmq-3nodes

  roles:
    - kubernetes-apps

fixes #204

I need help to either remove the 'pip install' or install 'pip' on all systems


Current riscv gnu toolchain failed on Ubuntu 16.0 due to lacking expat

checking whether to use expat... yes
checking for libexpat... no
configure: error: expat is missing or unusable
Makefile:9095: recipe for target 'configure-gdb' failed
make[2]: *** [configure-gdb] Error 1
make[2]: Leaving directory '/home/ubuntu/projects/picorv32/riscv-gnu-toolchain-rv32i/build/build-gdb-newlib'
Makefile:848: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/ubuntu/projects/picorv32/riscv-gnu-toolchain-rv32i/build/build-gdb-newlib'
Makefile:394: recipe for target 'stamps/build-gdb-newlib' failed
make: *** [stamps/build-gdb-newlib] Error 2

This seems to be a recently added dependency, because I've successfully build earlier toolchains on the same machine in the past.
Fix: installed expat and libexpt1-dev. Not sure if you need to install both of them or if the failure is somehow specific to my Ubuntu installation (which is running on a Vagrant VM.)

Same problem with Ubuntu 18.04, fixed by installing libexpt1-dev.


Fast clic on new zoom buttons

Issue Type
[ ] Question
[X ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Description and/or steps/code to reproduce the problem
Click quickly and repeatedly on the Minus zoom button: in many cases, clicks are not handled as clicks on the zoom-out button, but as clicks on the map => thus zooming in again.
Same issue of course with the Plus zoom button, but less obvious as the consequence is also a zoom-in.
(except this - annoying - issue, those new zoom buttons are quite good)
Environment
Happens both on emulator (with the mouse), and tapping on an actual device.
Version of osmdroid the issue relates to:
6.0.3

Fixed in #1219

@MKergall Feel free to reopen if not solved by #1219.


Iteration optimisation

This is built on top of #104 and #96, and https://github.com/trussed-dev/littlefs2/pull/33
This PR:
Uses the apis added to https://github.com/trussed-dev/littlefs2/pull/33 to improve the skipping that happens each time in read_dir(_files)_next(). I think the operation is likely still $O(n)$ (with n being the number of files in the directory, but it should be much faster.
It also exposes read_dir(_files)_nth syscalls that make it possible to resume iteration at a certain point without having to iterate n time with read_dir(_files)_next, which is a $O(n^2)$ operation

The bug mentioned in https://github.com/trussed-dev/trussed/pull/107 does not affect this PR anyway because the current behaviour of iteration is to consider any filesystem error as the end of the iteration, which means the bug does not change observed behaviour.

In favor of this, needs some conflict fixing.


Add multi-region support for aws_elb

Readonly tests are failing because of the state of the staging account. I couldn't reproduce it on my own setup. I'll still try to diagnose the problem using the logs.

I rebased the commits from my aws_acm_list PR because the functionality on this PR depended on that.

Seems it's finally ready to go. Waiting for the tests to pass and if they do, I'll add tests for the multi-region functionality.


[1/x] add venft contracts to loader

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1654   👈

This comment was auto-generated by Graphite.


Capacitor 4

Will you update this plugin to support Capacitor 4?

Update podfile to version ios 13
Update build.gradle like here Cap 4 update of another plugin
Question: Does standard-version really needs to be a peerDependencies inside the package.json?
Refactor your native decorator

Hey @aparajita,
do you have an updates/progress regarding this? :)
I just saw, that you finished your splash screen plugin.
Thanks for your work!

Now that I finished splash screen I will start working on this one today.

Just released with iCloud Keychain support!


[mgmt] recoverysrevicesbackup release

https://github.com/Azure/sdk-release-request/issues/5133

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/arm-recoveryservicesbackup


Question: wrap hadoop/spark call in ssh

I'm running luigi on a local box without hadoop/spark, and need to execute some hadoop commands/spark jobs on remote cluster. I can ssh to the clusters. Is that possible to do this using the ssh , hadoop, spark module  in luigi? Any examples in the repo? Thanks

I don't think there's existing support for that. The quickest option perhaps - to rsync (or otherwise deploy) your job modules there and then just invoke via ssh?

there's no support but is probably easy to add!

There is something like this for HadoopJarJobTask only, see #900.
It would be nice if we could rework hadoop tasks to use ExternalProgramTask like spark, and then implement some generic run-over-SSH capabilities there.

I feel that a generic run-over-SSH feature is very useful.
For example, now I have a workflow whose data sources are scattered on different clusters: taskA needs to access HDFS files on one cluster A, taskB needs to access Hive tables on another cluster B.
One problem is that now it's not easy to run taskA and taskB in the same workflow. If I start the workflow on cluster A, then taskB can not use hive related tasks/targets in the luigi package. If I start on B, then I can not use HdfsTarget.
Another problem with this is that I need to install luigi on both clusters. Because clusters are managed, I can not install it globally. Instead, I installed it for the accounts that run the pipeline. This means I need to install luigi for diff accounts (testing, staging, prod) on both clusters.
The example is simple and there are certainly ways to overcome the problems using what luigi have (for example, use external command task).  But it's not generic and elegant. If we could have a solution to run all luigi Tasks over SSH, it will be great.
Hope I made the point!

great if you want to put together a PR!


Add SSR helper and server-side variant persistence

Current dependencies on/for this PR:

main

PR #20

PR #21   👈

This comment was auto-generated by Graphite.


sftp disabled by default

Describe the bug
Protocol sftp is disabled by default. This enforces using scp. Described in README:

This role by default deactivates SFTP.

Expected behavior
Today I have read release notes of OpenSSH 8.0 when they say:

The scp protocol is outdated, inflexible and not readily fixed. We
recommend the use of more modern protocols like sftp and rsync for
file transfer instead.

So maybe it would be better to use sftp, rather than scp..

@wojciech-kopras thanks for raising this issue! We definitively should have a look here.
@chris-rock @atomic111 @mcgege @rndmh3ro Somehow I don't really like the idea to have sftp enabled per default, scp is not recommended by openssh, rsync isn't always installed per default (e.g. some minimal images). Any ideas how we can handle that long-term? To keep sftp disabled as users of dev-sec can always switch the according implementation to enable it?

Any ideas how we can handle that long-term? To keep sftp disabled as users of dev-sec can always switch the according implementation to enable it?

I'm really not sure. Having a default (and enabled) way to securely transfer files is a must-have in terms of usabilty in my opinion. On the other hand disabling unused things is more secure.
Since sftp uses ssh to transfer files, sftp is as secure (ignoring potential bugs in the sftp-code) as ssh itself. So I see no real downside in enabling sftp by default.

That is an interesting use case. We should look for standard recommendations from CIS/NIST/BSI. As we always want to make sure that users can tweak their implementation, sftp should be enable-able if required. I could not find a recommendation for disabling scp yet. I think we all agree that plain ftp is never a good idea.

@atomic111 What is your opinion?


The master window in master + stack layout gets changed randomly with a multimonitor setup

There seems to be something that causes the master window in master + stack layout to get swapped on a supposedly inactive monitor
I have 3 monitors and this has happened quite randomly in two different scenarios:

Opening bemenu-run. For example, I open bemenu on the 2nd monitor and the master window suddenly gets swapped on my 3rd monitor
Running hyprctl dispatch focusmonitor with a keybind to cycle from monitor to another

I haven't found a way to replicate this issue and its extremely random

bemenu has Xorg and Wayland backends; are you sure that bemenu is using the Wayland backend?

I'm using the wayland backend. Xwayland doesn't really work too well on my system for some reason (or at least in hyprland).
I'll post some logs when I use hyprland next time around. I can't really daily drive it because it doesn't recover from suspend (it glitches out really badly and is unusable), so I'd have to keep my computer running 24/7, which isn't really doable with the current electricity costs

is this still a thing?

I tested the latest version and couldn't replicate the issue so I'd say that this problem has been fixed.


not working at all

i tested it with this not working
echo "http://testphp.vulnweb.com/artists.php?artist=" | qsreplace "(select(0)from(select(sleep(10)))v)" | jeeves --payload-time 10

Confusing

Gonna leave this closed, if any problems, contact again


[SQL] Add backup storage redundancy optional parameter to MI create cmdlet

Description
Add backup storage redundancy optional parameter to MI create cmdlet
Testing Guide

az sql mi create --resource-group myrg --name azureclitestbsr --location westeurope --admin-user myuser --admin-password myPass --license-type LicenseIncluded --subnet "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/toki/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/ManagedInstance" --capacity 8 --storage 64 --family Gen5 --tier GeneralPurpose --backup-storage-redundancy Local
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

sql

@yonzhan I see that you have selected S176 as milestone. Can you please change it to S175, since we have strict GA deadline for the feature I am adding, and S175 is the only release that is appropriate for us?

@petrajkogit does this PR target for Ignite?

@yonzhan This is not specifically targeted for Ignite, but for GA milestone that matches with dates for Ignite (actually we need to be GA by the end of Septempber, and Ignite is a bit earlier)

@zhoxing-ms  please help with this PR.


ASR: Adding new Resource replication protection intent and its associated PUT and GET call

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@Azure/arm-api-review-board : Please review this. We need this for ignite demo, hence request you to please prioritize

I have raised request for suppressing the error https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/openapi-authoring-automated-guidelines.md#r4010 , as per guidelines defined here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process?anchor=obtaining-suppression

/azp run automation - sdk

/azp run automation - sdk

@ayfathim please help fix the linter error to get this PR qualified to merge.
The response is defined but without a default error response implementation.Consider adding it.'
at specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2018-07-10/service.json:4098

@qianwens : Our service currently does not have the default error response defined in the format that is needed. i have opened a workitem to do this post ignite: https://msazure.visualstudio.com/One/_workitems/edit/8045859/
Let me know, if i can byPass this validation check for now.

@qianwens : Our service currently does not have the default error response defined in the format that is needed. i have opened a workitem to do this post ignite: https://msazure.visualstudio.com/One/_workitems/edit/8045859/
Let me know, if i can byPass this validation check for now.

You need to follow this process to suppress the rule https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@qianwens : I have raised swagger exception for the default error response. And as its ARM signed off, can i proceed ahead with adding the suppression code for default error response?

https://github.com/Azure/openapi-diff/blob/master/docs/rules/1038.md
The "AddedPath" looks like a false positive to me. I have not added any subResource under a resource.
@qianwens : Can you please help me understand, why this is failing?

/azp run automation - sdk

I have added suppression for the "default error response" error, as the ARM team has approved it.

https://github.com/Azure/openapi-diff/blob/master/docs/rules/1038.md
The "AddedPath" looks like a false positive to me. I have not added any subResource under a resource.
@qianwens : Can you please help me understand, why this is failing?

You added new path /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationProtectionIntents/{intentObjectName} to existing path /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}. so that you should add a new API version

[3:56 PM] Ayesha Fathima
it is created by customer....but the call goes to different service "recovery services"................"recovery services" will inform ASR about vault created......and the user can protect a vm inside the vault by point a PUT call, which will create a replication protection intent resource
[3:56 PM] Ayesha Fathima
none of the properties of vault resource is impacted by the new resources being added "replicationProtectionIntent"
Edited[3:59 PM] Ayesha Fathima
its a breaking change for the vault resource.....its independent of it.


handling null height/width case according to aspect ratio

@harshal27 Thanks for the PR. 👍 Can you have a look at the above comments. We can discuss the things if needed.

@vikalpj thanks for the feedback. I'll make the required changes.

@harshal27 Just one more minor comment every thing else looks good.


In README.md instead of hackfest issue we should add hacktoberfest issue badge

Hackfest ended on 3rdApril

Current Badge:

Hacktoberfest is going on so we should change it to hacktoberfest issues:

can i work on this issue ?

Hey we will do this internally. Thank you for pointing it out. You can work on it in the meantime


Add support for Dekorate

https://github.com/dekorateio/dekorate

I think it would be very nice addition

Support for 1.0.1 for starter-project https://github.com/micronaut-projects/micronaut-starter/pull/446

Fixed by https://github.com/micronaut-projects/micronaut-starter/pull/446


[Desktop] Space cannot be entered into TextField inside a ListTile

Duplicate of https://github.com/flutter/flutter/issues/90907. The reason this is being created is because that issue got closed due to a merged PR which solved the issue: https://github.com/flutter/flutter/pull/91129, however this PR was later reverted due to failing tests: https://github.com/flutter/flutter/pull/92544, but now the original issue has been locked by the github bot due to inactivity and so I cannot comment on it.
Not asking for help, just creating attention for the original issue as I unfortunately think that the flutter devs don't know of its existence due to it being closed. Thanks in advance for whoever inevitably fixes the issue.
Reproducible steps copied from the original issue
Steps to Reproduce

flutter create bug
create TextField inside ListTile. Or Copy my main.dart
Run on windows-x64
Try to type "Test Typing wow"

Expected results:
"Test Typing wow"
Actual results:
"TestTypingwow"
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: const Center(
        child: ListTile(
              title: TextField(

              ),
            ),
      ),
    );
  }
}

Hi @PeterNjeim, Thanks for bringing this to notice, I am able to reproduce the issue on stable and the master channel. space key doesn't work with the above code sample also there is some ripple effect in the text field on pressing space key.
Output from the master channel
https://user-images.githubusercontent.com/31410839/151761283-711aed7e-dc92-4367-9add-b374d0186c8e.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.8.1 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (7 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 97.0.4692.99

• No issues found!

[✓] Flutter (Channel master, 2.10.0-1.0.pre.319, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.10.0-1.0.pre.319 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 120d25f786 (3 days ago), 2022-01-28 12:40:06 +0200
    • Engine revision c5ee2e4c35
    • Dart version 2.17.0 (build 2.17.0-66.0.dev)
    • DevTools version 2.10.0-dev.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 97.0.4692.99

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

cc: @justinmc

@maheshmnj @HansMuller
Seme for Android, iOS.

@HansMuller @maheshmnj @PeterNjeim
I have found workaround:
  Widget workaroud() {
    return ListTile(
      title: Shortcuts(
        shortcuts: <ShortcutActivator, Intent>{
          const SingleActivator(LogicalKeyboardKey.space): SpaceKeyIntent(),
        },
        child: Actions(
          actions: {
            SpaceKeyIntent: CallbackAction<SpaceKeyIntent>(
              onInvoke: (SpaceKeyIntent intent) {
                _insertSpaceCharacter();
              },
            ),
          },
          child: TextField(
            controller: widget.controller,
          ),
        ),
      ),
    );
  }

  void _insertSpaceCharacter() {
    final inserted = ' ';
    if (widget.controller != null) {
      final text = widget.controller!.text;
      final selection = widget.controller!.selection;
      final newText =
          text.replaceRange(selection.start, selection.end, inserted);
      widget.controller!.value = TextEditingValue(
        text: newText,
        selection: TextSelection.collapsed(
            offset: selection.baseOffset + inserted.length),
      );
    }
  }

class SpaceKeyIntent extends Intent {}

Seme for Android and iOS with hardware keyboard

Thanks for the info @PeterNjeim, I can confirm it on Android and IOS. This purely looks like a framework issue.
https://user-images.githubusercontent.com/31410839/151975135-37dadd94-b2e7-470b-8ab7-61c6a3b8973e.mov

It seems like we should just re-land the original PR (with changes so it won't cause failures, obv). (Desktop triage)

I believe this should be fixed with https://github.com/flutter/flutter/pull/98469, but let me know if anyone still sees this problem.


why the model size with 32-bit is equal to model with 4-bit

Hi, during training, the parameters in both the trained full-precision model and quantized model are stored in float32 format, and there are limited possible choices of data in the quantized model.
The model size compresses when the quantized model converts the data format to INT during deployment. Also, the parameters of the proposed transform can be removed during deployment.

thank you for your reply.
grad_alpha = (grad_output * (sign * i + (input_q - input) * (1 - i))).sum()
when update alpha,why use (input_q-input)

The (input_q-input) here considers the difference between input_q and input when updating alpha.  That is an optional setting.


update README.md with latest session list

@codegangsta - Just a Reminder to validate and merge this PR

Thanks for updating this! Must have missed the original notification


Update Firefox Nightly 83.0a1.yaml

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

Hmm.  i wonder if there is something changing the binary each download.


fix code example to work

I tried to use the example in the readme but it seems that the release function that you call needs to be the second argument of the callback.

Coverage remained the same at 100.0% when pulling 8724cd36e19da852da9f37fb30295601120c1a6a on martonw:master into 6e846b4803fcd7df7317baedb8ca32ead0d0ccdf on IndigoUnited:master.

Ty


Updated monthly summar example

Switched out March 2018 example for the April 2019 monthly summary
Category

[ ] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

thx @tomresing, appreciated.


Tbox 256 create a decorator for applying utils version enforce after or equal

↪ Pull Request
As discussed for TBEX, allow us to decorate functions with min (and optionally max/exact version dependency).
The proposed PR also itself determines the version of any Tamr version being input into the function, to keep creating code for new functions simple.
Also brings in testing at a logical/standardised error testing level for flexibility in creating new functions (e.g. if output of an unversioned API changes, then version compatibility can be expanded by patching)
✔ PR Todo

[X] Add documentation
[X] Add examples
[X] Ensure you are following the practices in the contributor guide and coding_standards

Use consistent and descriptive name conventions
Uses google-style docstrings
Uses versioned API/client methods only
Avoid global variables
Avoid giant try/catch
Don't use mutable default variables
Use a main() function in your scripts

[X] Added/updated testing for this change (ensure you are testing any changes/new code!)
[X] Update title to link to TBOX issue (i.e. start pull request title with TBOX-xx)
[ ] Approval from first code-reviewer
[ ] Approval from second code-reviewer (only required if a second reviewer has left comments)
[x] Pass all checks

Not sure why this is failing - my local pytest works fine

Do you think project movement could have an example for testing the version? Just a snippet?

I refactored the movement functions to include the pie decorator. As such, any time the movement functions are called the version gets checked.
There is therefore no code that needs to be written when using the movement functions - the version checking comes for free.
I'm not too sure what help a snippet would be over the in-func examples.


Add CI task to build client on iOS / Android targets

After merging #173, I had trouble building rust-rocksdb on iOS and Android targets. There seem to be open issues related to this in the repo.
We should have a CI task to make sure that at least the client code compiles all the iOS / Android rust targets, much like we do for WASM currently.

#653 will take care of Android . I looked into iOS and my (broken) WIP is in https://github.com/dpc/fedimint/tree/cross-compile-mac . I'll get back to it at some point.

Update: we build android targets but it doesn't look like we build iOS targets


[DNM] debugging pipeline failure

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2586935


Request: BER+implicits kernel

It'd be very handy to have a kernel built from the 4.02.1+modular-implicits-ber compiler.
I managed to compile one (kernel.meta-modimp.js) after pinning a few packages, following a procedure similar to https://github.com/andrewray/iocamljs/issues/7#issuecomment-76972955, but it doesn't actually work: it fails with various JavaScript errors, such as
TypeError: IPython.Kernel is not a constructor
TypeError: this.kernel is null

and I'm not sure how best to debug it.

$ opam install iocamljs-kernel js_of_ocaml.2.5 lwt.2.4.5

Then from this repository switch to the metaocaml branch and
$ make min

Thanks for the help!  The working kernel can be found here:
https://github.com/ocamllabs/iocamljs/blob/gh-pages/static/services/kernels/js/kernel.meta-modimp.js


Gilbert Charles.md

title:  "Gilbert Charles"
metadate: "hide"
categories: [ Participant, Github ]
image: "/assets/images/gilbert.jpg"
GILBERT'S STORY

Hello friends and Community Members,
I am Gilbert Charles by names but also friends call me Kane, shortened out from the name Kenyi as It's my birth name.
I am an enthusiastic South Sudanese born in a small Refugee Settlement named Robidire in Adjumani District on 30th November 1998.
Life was good in the beginning with both parents by my  side and everything seemed so beautiful, but then as time went on, I realized I was just a kid by then to know
what really life was. As years past on I came to know I wasn't a citizen of the country I was in, but then as a child I had a lot of questions to ask because I wanted to know what
really happened in the past years before I was born that brought about the taking of refuge in Robidire, Adjumani, Uganda.
As life went on I started to learn and hear from my grand parents how they ran into Uganda and how many suffered, the pains they feel as the memories of their lost ones during the war crosses by.
And when 2008 came, Of course repatriation took place, as it was my first time to step in my fatherland South Sudan, Imagining the sweetness of life and love from the natives.
Enjoyed the moments with the family, Of course Boom 2016 comes and I get myself back in Pagirinya Refugee Settlement in Adjumani. What could I say, didn't know the source of the crisis,
and yeah no power to stop but only had to put down this set of piece to my dear fellow South Sudan seriously.
The piece I titled "LETTER TO THE SOUTH SUDAN SERIOUSLY"
LETTER TO THE SOUTH SUDANESE
Trauma breaks mine heart
The suffering of my people shutters me
The demolition of the Great motherland sharply instills pain in mine heart,
The harmony; The love; The blessings of our for fathers devoured and turned into the hatred; the segregation and tribalism by a twist inflicting crisis.
How long shall we remain Refugees?
When shall we feel the peace of our fatherland?
Broken is mine heart,
I'm torn between tolerance to pain and acceptance to death,
Dear fellow South Sudanese,
I was in quietude merely sweethearted
A cup of poison given to me to set me free in place of a pond of peace,
I was plagued with undue melancholy of the shame of being in quietude,
Let's arise.
My grandparents came into exile as Refugees,
My parents gave birth to me in exile as a Refugee,
For how long should the generation remain I exile as Refugees:
Warib cing wa me ryemo cen man kare acel;
Cause no one is born hating someone,
Together we can our fatherland South Sudan;
Ma badna anihina, bi geheru beledna Junub Al Sudan,
Let's unite to eradicate tribalism to feel the presence of peace;
Ti yi tomorgi 'borik i togbwo'ja na gebeliya a'nyen yi kurundo 'busan na taling,
Together as a Nation;
Together as South Sudan
Egbwe Kolu a'a
Bukku panda yiek nhial
Love without discrimination
Happy South Sudan.
Peace4SouthSudan
The piece above expressed the pain I have deep inside my heart for what is happening to Our country South Sudan, Inspite of what is happening to my Country
South Sudan, I still believe and will always believe that we can all still collect the remaining pieces of our bodies, enrich ourselves and learn to move with a positive hope of transformation.
Besides transformation, technology has knocked on my door, all I need to do is concentrate.

A new story is loading..So this will not be added to the webpage.

I have updated your profile: https://asknet-open-training.github.io/ASKnet-Track-II-participants-stories-Community-Empowerment-2020-2021/Gilbert-Charles/

I've checked all the content, looks like the content in your issue is different from the one currently on your profile.
Is this on purpose? Can you create a merged version? Let me know if you need help.

The actual info is the one in my profile, this was just a demo to help the rest of the members get the point and purpose of the repository.

okay thank you! Then I will close this issue.


Issue when running --qc step

@pieterlukasse commented on Thu Apr 19 2018
I get the following output when running --qc step:
2018-04-19 12:06:10,849 - mrtarget.modules.QC - INFO - checking t-d pairs in evidence data:   8%|8         | 174k/2.12M [00:48<09:01, 3.59k t-d pairs/s]
2018-04-19 12:06:11,033 - mrtarget.modules.QC - INFO - checking t-d pairs in evidence data:   8%|8         | 174k/2.12M [00:48<09:03, 3.58k t-d pairs/s]
2018-04-19 12:06:11,072 - mrtarget.modules.QC - INFO - checking t-d pairs in evidence data:   8%|8         | 174k/2.12M [00:48<09:03, 3.58k t-d pairs/s]
2018-04-19 12:06:11,072 - mrtarget.modules.QC - INFO - no missing annotation found
2018-04-19 12:06:11,098 - __main__ - INFO - it was correctly executed - finished

Notice it only reached 8% and then finished. This is confusing. Did it just skip a large part? Or is the counting wrong?

@ckongEbi commented on Thu Apr 19 2018
@mkarmona is this something you've noticed?

@ckongEbi commented on Tue Jul 10 2018
@mkarmona maybe @afaulconbridge  can help to have a look?

@ElaineMcA commented on Tue Aug 28 2018
I see what you say @pieterlukasse . I already asked @mkarmona and he told me it is counting incorrectly. Thanks for reporting this, we'll add a task to fix this moving forward.

@pieterlukasse commented on Tue Aug 28 2018
Ok, thanks!

@afaulconbridge commented on Thu Oct 04 2018
As part of opentargets/platform#66 I'm re-writing and enlarging our QC processes, mainly so that they happen after every step to identify potential issues sooner. My work-in-progress is at https://github.com/opentargets/data_pipeline/tree/af-qc

This should be addressed as part of release 18.10.2 Closing this ticket, please create a new one if this problem is reproducible in 18.10.2


Increase number and allow easy updates to nominations

Allow 3 nominations per player and allow players to easily update their choices as they see worthy games throughout the season

Implemented. Configure here: https://www.lichess4545.com/admin/tournament/leaguesetting/1/change/


FileNotFoundError: [Errno 2] No such file or directory: 'experiments/cfgs/res152.yml'

FileNotFoundError: [Errno 2] No such file or directory: 'experiments/cfgs/res152.yml'
When I run ./experiments/scripts/test_faster_rcnn.sh 0 coco res152, the bug happen
please help

Hi，I have the same problem with you.Did you resolve it? Thanks!

FileNotFoundError: [Errno 2] No such file or directory: 'experiments/cfgs/res152.yml'
When I run ./experiments/scripts/test_faster_rcnn.sh 0 coco res152, the bug happen
please help

Hi，I have the same problem with you.Did you resolve it? Thanks!

FileNotFoundError: [Errno 2] No such file or directory: 'experiments/cfgs/res152.yml'
When I run ./experiments/scripts/test_faster_rcnn.sh 0 coco res152, the bug happen
please help

Hi，I have the same problem with you.Did you resolve it? Thanks!

First, cp res101.yml res152.yml, change EXP_DIR and SNAPSHOT_PREFIX.
Then, download res152.cpkt.


fix: fix release script in ci

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#281  👈
#280
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


python312Packages.evaluate: 0.4.2 -> 0.4.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.evaluate is: Easily evaluate machine learning models and datasets
meta.homepage for python312Packages.evaluate is: https://huggingface.co/docs/evaluate/index
meta.changelog for python312Packages.evaluate is: https://github.com/huggingface/evaluate/releases/tag/v0.4.3
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.3 with grep in /nix/store/7afp2icq3wnmss0b3y0qv69d9fj5paca-python3.12-evaluate-0.4.3
found 0.4.3 in filename of file in /nix/store/7afp2icq3wnmss0b3y0qv69d9fj5paca-python3.12-evaluate-0.4.3

Rebuild report (if merged into master) (click to expand)

22 total rebuild path(s)

22 package rebuild(s)

First fifty rebuilds by attrpath

libretranslate
openllm
python311Packages.accelerate
python311Packages.argos-translate-files
python311Packages.argostranslate
python311Packages.evaluate
python311Packages.k-diffusion
python311Packages.libretranslate
python311Packages.manifest-ml
python311Packages.peft
python311Packages.stanza
python311Packages.translatehtml
python312Packages.accelerate
python312Packages.argos-translate-files
python312Packages.argostranslate
python312Packages.evaluate
python312Packages.libretranslate
python312Packages.manifest-ml
python312Packages.peft
python312Packages.stanza
python312Packages.translatehtml

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7afp2icq3wnmss0b3y0qv69d9fj5paca-python3.12-evaluate-0.4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.evaluate https://github.com/r-ryantm/nixpkgs/archive/272b51ed0f5ece8adba60eb90fdec86015401f86.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/272b51ed0f5ece8adba60eb90fdec86015401f86#python312Packages.evaluate

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7afp2icq3wnmss0b3y0qv69d9fj5paca-python3.12-evaluate-0.4.3
ls -la /nix/store/7afp2icq3wnmss0b3y0qv69d9fj5paca-python3.12-evaluate-0.4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

40 packages built:

libretranslate (python312Packages.libretranslate)
libretranslate.dist (python312Packages.libretranslate.dist)
openllm
openllm.dist
python311Packages.accelerate
python311Packages.accelerate.dist
python311Packages.argos-translate-files
python311Packages.argos-translate-files.dist
python311Packages.argostranslate
python311Packages.argostranslate.dist
python311Packages.evaluate
python311Packages.evaluate.dist
python311Packages.k-diffusion
python311Packages.k-diffusion.dist
python311Packages.libretranslate
python311Packages.libretranslate.dist
python311Packages.manifest-ml
python311Packages.manifest-ml.dist
python311Packages.peft
python311Packages.peft.dist
python311Packages.stanza
python311Packages.stanza.dist
python311Packages.translatehtml
python311Packages.translatehtml.dist
python312Packages.accelerate
python312Packages.accelerate.dist
python312Packages.argos-translate-files
python312Packages.argos-translate-files.dist
python312Packages.argostranslate
python312Packages.argostranslate.dist
python312Packages.evaluate
python312Packages.evaluate.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.peft
python312Packages.peft.dist
python312Packages.stanza
python312Packages.stanza.dist
python312Packages.translatehtml
python312Packages.translatehtml.dist

Maintainer pings
cc @bcdarwin for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg eval


Docker: Very high memory usage while remuxing (eventually leads to OOM)

Describe the bug
When remuxing a relatively long stream (10+ hours), the docker container appears to hit a 6 GB RAM usage which then leads to an OOM on my home server as it doesn't have any more available memory.
To Reproduce
Steps to reproduce the behavior:

Start capturing a long stream from the start.
Stream ends.
Remux starts (along with VOD and chat download).
Container hits 6 GB memory usage and OOMs.

Expected behavior
Memory usage doesn't explode when remuxing.
Screenshots

Logs
OAuth token, public URL, youtube callback IDs and other possibly PII info has been removed, but I don't know what else could also classify as private info so please let me know if I goofed up.
capture_michimochievee_41650896199_stderr.log
capture_michimochievee_41650896199_stdout.log
chatdump_michimochievee_41650896199_stderr.log
chatdump_michimochievee_41650896199_stdout.log
docker-live-stream-dvr.service.log
download_vod_2272194386_stderr.log
download_vod_2272194386_stdout.log
LiveStreamDVR-2024-10-09.log
LiveStreamDVR-2024-10-10.log
remux_2024-10-10 01-13-39 MichiMochievee - 🔴 ADVENTURING WITH MY SHINY POKEMON! - POKEMON WHITE pt.3  !merch !tts !game !discord !collab [41650896199].ts_stderr.log
remux_2024-10-10 01-13-39 MichiMochievee - 🔴 ADVENTURING WITH MY SHINY POKEMON! - POKEMON WHITE pt.3  !merch !tts !game !discord !collab [41650896199].ts_stdout.log
Server:

OS or Docker: NixOS 24.11.20241004.bc947f5 (Vicuna) / Docker version 27.3.0, build v27.3.0

Additional context
Unsure what else to add, but will reply with more info as necessary.
Unfortunately my current monitoring tools cannot capture the processes inside the container nor their memory usage to figure out what exactly was happening inside it.

Issue seems to be related to either downloading vods or chatlogs, when I triggered both on the same capture that failed, memory usage spiked hard:

Update: the issue happens with any remuxing, be it the capture or the VOD's. This is it remuxing a 10 hour long capture:

Assuming the issue stems from storing entire stdout and stderr in memory unnecessarily (because it gets written to a file anyways):
https://github.com/MrBrax/LiveStreamDVR/blob/34a1d961de184a6ac6fc5f00f4bfc90926c21c21/server/src/Helpers/Execute.ts#L376-L377

that would explain it, i was thinking of looking into this. a bit weird since i'm pretty sure i use a flag to disable file output on stdout

ffmpeg does output quite a bit of stuff on stderr though, might be worth making a flag that disables storing the stdout/stderr for ffmpeg or something similar

it shouldn't be enough for an oom though, unless there's something extremely memory inefficient with string arrays.
besides, the remuxing should be using another method that doesn't store the logging in ram

It is using the Job logging as well, but exec also stores stdout+stderr in memory.
I'm creating a build that disables this in-memory storage of stdout/stderr and will report back with the results (if any). Ended up getting distracted reducing the size of the docker image though 😅

Did a bit of testing on my fork and removing the in memory arrays didn't change anything, the issue seems to be elsewhere.
I'll see if I can get a dump of the process and open it up on chrome to see where all this usage is coming from.

i have never gotten the issue myself, i run it outside docker on a shared vps so ram usage can't be high or else it gets killed. must be something specific to docker

I've enabled a few node flags to create a memory dump once it runs out of memory, so maybe I'll be able to get some more info on this.
Will report back if I find anything.

Well, it definitely seems to be something related to remuxing but I have no idea what. I've removed all .on("data"s from the remuxing path and it still leaks a lot of memory.
I've made a few heapdumps and they all seem to indicate it's native memory that's using this, not the Js side:

Unless if I get a full process dump and even try to figure out where the native memory is at I don't have enough knowledge for it so I'm just giving up for now.
I'll either try to run this outside of docker or make my own version of this tool inspired on yours using another runtime, because node.js seems to be cursed somehow.

Yeah, I've set it up to run outside of docker and still running into the exact same issue with latest commit on master:

Time to reimplement in another runtime I guess.


On Mac OSX Default Key Binding Conflicts with OS Binding

The default open-in-browser on OSX conflicts with the operating systems "Log Out" binding. I've changed it to shift-cmd-B, which works, however I haven't done any digging to find out of that conflicts with anything.
'.platform-darwin atom-workspace atom-text-editor':
  'shift-cmd-B': 'open-in-browser:open'

I'm having the same issue, unfortunately, disabling the keystroke does not allow me to re-toggle it either :/

@Tracol the keybinding can be configured in your local .atom/keymap.cson file. You likely want to add the following to it.
'atom-workspace atom-text-editor':
  'cmd-shift-q': 'open-in-browser:open'

You can change this shortcut to be what you want.
Of course, this doesn't fix the issue. It's just a workaround.


is it possible to set a custom components with child components? [help]

is it possible to set a custom components with child components?
for example:
i need to create a panel like custom component with default one textfield inside of it.

Yes, you would just make the "default" schema for the component to include the nested component you would like to default. The default schema is provided with the static get schema method within the custom component.


memoryview(direct ByteBuffer) has incorrect nbytes field

There appears to be a bug in the nbytes on some systems when using direct byte buffer.  This prevents them from being used with io.readinto
Bug replication
>>> import jpype
>>> import jpype.imports
>>> jpype.startJVM()
>>> from java.nio import ByteBuffer
>>> memoryview(ByteBuffer.allocateDirect(100)).nbytes
25096256

Hi, any plans to make a new release soon? I'm running into what I believe to be this bug when unpickling jpype objects. Causing BufferOverflowException.
File "/opt/project/src/common/stateful_calculations.py", line 41, in get_stored_state_object
  loaded = jpype.pickle.JUnpickler(fd).load()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/code/.venv/lib/python3.11/site-packages/jpype/pickle.py", line 161, in __call__
     return decoder.unpack(args[0])
            ^^^^^^^^^^^^^^^^^^^^^^^
 java.nio.java.nio.BufferOverflowException: java.nio.BufferOverflowException

Also; this print(memoryview(jpype.java.nio.ByteBuffer.allocateDirect(100)).nbytes) outputs some varying  large numbers like 52175792
Thanks for a great library! :slightly_smiling_face:

Until the next release you could just use the a development version as such:
pip install git+https://github.com/jpype-project/jpype

Does that really work? Considering how this library compiles .so files that is distributed along with the package.

Sorry I have been so slow.   I was hoping to get a few things addressed before the next release, but I haven't had much time.   I will try to wrap them up and get out a release this month.


Add HTTP->HTTPS redirect at the LB for licensify-admin.

This already exists in UKCloud (on the licensify_lb nginx) and we need
to preserve the behaviour when migrating to AWS. The HTTPS redirect is
essential in rare cases, because HSTS preload cannot be relied upon
universally.
We add an ALB listener on port 80 with a default rule which serves
redirects to the same URL but with the https protocol. This way we don't
have to allow any HTTP traffic to be forwarded to the backend and we
keep the backend nginx config simple.
While we're there, also remove some superfluous entries from the ingress
ACL for the public LB. (It already allows port 443 from any source, so
it's not helpful to also list the office IP addresses in that rule. This was
copied from whitehall-admin I believe.)

we should check the policy for backend access for non production environment and apply those in a separate PR.

Agreed! :)


What are the "Total unknown tests: 6" in the runTester() routine?

I ran the runTester() routine and it gave this summary output:
Total failed tests:      0
Total unknown tests:     6
Total passed tests:      385
what are the 6 unknown tests?

This is actually a roadrunner issue. The unknown tests come from things like "Get Reaction Rates Ex", which tests the C API method getReactionRatesEx, which isn't exposed to Python hence there is no test for it. I should just add Python stubs for each of the "Ex" tests that automatically pass, there's no reason to make it look like they represent gaps in the coverage.

See https://github.com/sys-bio/roadrunner/issues/299


Pass options to unregister on close

We've run into a problem where we need to pass authorization headers to both register and unregister. This is easy to handle with register and unregister directly, but close doesn't seem to utilize our stored register options. This PR simply changes the RegisterContext.close function to pass this.options to this.unregister().

Hi Ryan,
First of all, thank you for your contributions.  This one in particular is interesting, and we've discussed it previously in Pull Request #153.  Since this.unregister() actually takes different options than register(), we don't want to reuse those options blindly.  As an easy workaround, you can unregister explicitly before calling stop().  If you'd like to convince me otherwise, I'm certainly open to it.
Cheers,
-Will

Hey Will,
Thanks for looking at my PR!
I may be missing something, but it looks like the options sent to RegisterContext.register and RegisterContext.unregister are the same (extraHeaders) except unregister has an optional all setting. It seems that calling RegisterContext.close currently calls RegisterContext.unregister without any options, so it always runs with { all: false }. This should be the case with the method implemented in this PR, unless the end user explicitly adds all: true to his register function.
If consistency is preferred, we can clone this.options and override all to false before passing them. This effectively ensures a valid set of unregister options (At least to the degree that register and unregister themselves ensure a valid set of options) is passed.
Again, maybe I'm missing something. But it seems to me that the only option RegisterContext cares about is extraHeaders and for unregister, all. Maybe an alternative would be to store an extraHeaders property rather than the entire options hash, since that's all it's used for? Maybe then it would make more sense to re-use it for close().
I do understand that an end-user can manually call:
this.unregister(options);
this.close();

But should they have to? They have already supplied their authorization headers, and RegisterContext has already stored them. This also means that instead of relying on the built-in cleanup on window close (in UA: environment.addEventListener('unload', this.stop.bind(this));) they will have to handle it in their own event handler. And I haven't tested this, but if they don't remove UA's handler, might there even then be a race condition?
Just my two cents. :grinning:

So, with the current set of options, it would be okay.  I'm more concerned about adding future options.  If we make this change, any option we add to register has to also work (or be ignored appropriately) for unregister.  It doesn't seem very future proof, especially if there is an easy workaround.

I do understand that an end-user can manually call...But should they have to?

I think so, if we are trading the flexibility of the library for one line of code that not a clear majority of users need.

...might there even then be a race condition?

Race condition between what?  Sending the REGISTER request and closing the WebSocket?  close would call unregister synchronously, so calling it earlier isn't going to cause any race with the connection that wouldn't already be there.  The only other thing I can think of is if calling unregister twice in a row races, which is a separate issue that we would want to patch.

Maybe an alternative would be to store an extraHeaders property rather than the entire options hash, since that's all it's used for?

That's an interesting idea.  If the goal is to reuse specific headers on all registration requests, perhaps we could carry that over.  I'd still want to reference it as a property of the RegistrationContext, rather than reusing the options.  Do we know if extraHeaders would always want to be used in close, or is that something we should make configurable?

Race condition between what?
If UA's on('unload') fires before mine, stop would be called before unregister. I haven't tested this, but I wanted to bring it up as a possible concern.

Do we know if extraHeaders would always want to be used in close, or is that something we should make configurable?

I can't speak for all use-cases, but in ours (authorization headers) we always want to be passing them. I support the idea of making it configurable, if there are supporting use-cases and it's done intuitively.
I could envision something similar to:
register: function(options) {
  this.closeHeaders = options.closeWithHeaders ? options.extraHeaders : [];
  // ...
},

close: function() {
  var options = {
    all: false,
    extraHeaders: this.closeHeaders
  };
  this.unregister(options);
}

What do you think?

@wakamoleguy I can code this up for review and update any associated tests if this looks good to you. Just let me know if you've got a better idea in mind so I can hopefully knock it out in one pass. :grinning:

If UA's on('unload') fires before mine, stop would be called before unregister. I haven't tested this, but I wanted to bring it up as a possible concern.

Oh, right.  I had forgotten that we added that.  Fair point.

I can code this up for review and update any associated tests if this looks good to you.

I think what you've outlined looks good.  Just please make sure that the extraHeaders gets copied into its own array properly (we already do this elsewhere in the file), to avoid messing with people who reuse the same options object for different calls.
Thank you for volunteering, and for putting up with my nitpickiness.


centerCrop and centerAspectCrop not working correctly for vertical images

I'm attempting to center a 1/1 aspect ratio crop as specified here.
For horizontal images, it works correctly. See:

However for vertical images, it doesn't take up the full width:

The code I'm using to generate the crop is as follows:
const crop = centerCrop(
   makeAspectCrop(
      {
         // You don't need to pass a complete crop into
         // makeAspectCrop or centerCrop.
         unit: '%',
         width: 90
      },
      1 / 1,
      image.width,
      image.height
   ),
   image.width,
   image.height
)

Am I doing something wrong, or is this a bug? Thanks in advance!

Hi, change your width from 90 to 100%

Ahhhh of course, makes perfect sense! Thank you.
Unrelated, but how would people feel about me adding a helper function to the library to generate a dataUrl from an image and crop? I made one for myself and it's pretty useful, but had to rework it for % units.


Would it be possible to add compressed JSON codec?

It would provide for grate portability and at the same time would benefit from smaller stored object size.
We are using memcached in many places at the moment and it utilizes similar approach for the string data.

yes you need to implement org.redisson.client.codec.Codec interface


Add doc and tools for using Theia, and doc formatting

Changes:

Added a wrapper around the Theia tool for building a map.
Fixed some issues in the localization docs to make links to other subpages work well with GitHub's markup.
Updated the bumble calibration for sci cam, haz cam, and extrinsics among these and to nav cam. Did not change the nav cam calibration.

I implemented Marina's suggestions (also in many other places) so that the correct paths to the "devel" directory is used.
Sorry this pull request became too big.

I pulled this in myself. I have another pull request to make, and this way staying in the way and was approved.

Once it's been approved by a reviewer it's fine to pull it in yourself. Thanks!


Can't find $ref

After the update to the version 1.0.0-beta.119, the 'lint' throws some fails on valid swagger
output on beta-119
  ]
}< ... 322 more problems hidden > increase with `--max-problems N`
Mova_Swagger_API_Pagamentos.json: validated in 306ms

❌ Validation failed with 6 errors and 416 warnings.
run `openapi lint --generate-ignore-file` to add all problems to the ignore file.

output on 1.0.0-beta.118
 ]
}< ... 322 more problems hidden > increase with `--max-problems N`
.\Mova_Swagger_API_Pagamentos.json: validated in 315ms

Woohoo! Your OpenAPI definition is valid. 🎉
You have 422 warnings.

We are working on the patch.
cc @AntonKozachuk

Resolved for the client in Redocly CLI version 1.1.0-beta.120


Implement Flyouts

What does the pull request do?

Add Flyout implementation as in UWP/WinUI (#5172)
Questions from #5172

Should ContextMenu be deprecated in favor of Flyouts (i.e., ContextFlyout property), as in UWP/WinUI. This would be a breaking change. (personally I'd be in favor of this)
Integration with Native Menus (I'm not including this here as I'm not too familiar with native menus and don't have a way to test them anyway, since they don't work on Windows iirc)
Open question 2: should some (or all) of the popup customization options (like offsets, etc) on Popup be visible through flyout, which differs from WinUI API. I've gotten most of the FlyoutPlacementMode options working, which WinUI has many, so that may make this unnecessary.

Since FlyoutBase is an AvaloniaObject, it itself is really just a more managed Popup. One difference between UWP/WinUI and Avalonia, is WinUI allows you to still name Flyouts (x:Name="Flyout") and target them through their styling system. Since Flyout is not a StyledElement this isn't possible in Avalonia, thus you can't, for example, change the Placement mode in a separate Style entry if using it in a Template.
To Implement/Checklist:

[x] FlyoutBase
[x] Flyout
[x] FlyoutPresenter
[x] Default FlyoutPresenter Style for Fluent Theme
[x] Default FlyoutPresenter Style for Default Theme
[x] Flyout property for Button
[x] MenuFlyout
[x] Tests
[x] Sample page

API differences from WinUI

MenuFlyout uses existing MenuBase logic, and will essentially work like the old content menu, and should ease the transition. MenuFlyoutItem, MenuFlyoutSubitem, MenuFlyoutSeparator were not ported, continue to use MenuItem as usual
FlyoutShowOptions and FlyoutBase.ShowAt(Control, FlyoutShowOptions) was not ported

Breaking Change
ContextMenu property has been marked obsolete in favor of ContextFlyout

Excited to see this come together. When it's ready I'm going to use it to implement #4960 and #4959. I don't think there will be any significant roadblocks after this.

Since Flyout is not a StyledElement this isn't possible in Avalonia

IIRC styling won't be tied to visuals soon-ish. That's required for the flow document port.

Should ContextMenu be deprecated in favor of Flyouts (i.e., ContextFlyout property), as in UWP/WinUI. This would be a breaking change. (personally I'd be in favor of this)

Yes. And it most likely not possible to reuse Flyout logic or MenuFlyoutPresenter styles inside of ContextMenu without another breaking changes.

Integration with Native Menus (I'm not including this here as I'm not too familiar with native menus and don't have a way to test them anyway, since they don't work on Windows iirc)

Yes, it's not required to be implemented now.

Open question 2: should some (or all) of the popup customization options (like offsets, etc) on Popup be visible through flyout, which differs from WinUI API. I've gotten most of the FlyoutPlacementMode options working, which WinUI has many, so that may make this unnecessary.

It can be discussed and implemented later.
Probably it can be done with attached properties to keep API simpler and avoid conflicts with native menus in the future, but there wasn't any agreement AFAIK.

MenuFlyout uses existing MenuBase logic, and will essentially work like the old content menu, and should ease the transition. MenuFlyoutItem, MenuFlyoutSubitem, MenuFlyoutSeparator were not ported, continue to use MenuItem as usual

Is there any plan to implement MenuFlyoutItem, MenuFlyoutSubitem, MenuFlyoutSeparator in Avalalonia in the future?
MenuItem from WPF seems like a better design to me (don't know why Subitem exists in UWP). It seems like this flyout implementation actually hits the sweet spot using good ideas from both WPF and UWP. The only downside it is now is not API compatible with either.

Is there any plan to implement MenuFlyoutItem, MenuFlyoutSubitem, MenuFlyoutSeparator in Avalalonia in the future?

There was issue somewhere with MenuItem improvements. We need at least ToggleMenuItem (it's possible to use toggling menuitem now, but not in convenient way) and RadioMenuitem. And probably these types should not have subitems list property.

There was issue somewhere with MenuItem improvements. We need at least ToggleMenuItem (it's possible to use toggling menuitem now, but not in convenient way) and RadioMenuitem. And probably these types should not have subitems list property.

Oh yes, thanks for reminding me why the 'MenuFlyoutSubitem' exists (So child items are not included with the other menu item types like toggle/radio).
With that in mind it might be better to go the UWP API route (but definitely would prefer 'Flyout' wasn't included in the MenuItem names). That said, it's probably not work a breaking change in names so full UWP design might be best after all.
This might be the other issue: https://github.com/AvaloniaUI/Avalonia/issues/224

@robloo after my comment I was thinking, that someone might actually want to have toggleable menuitem with sub items. In case of toggle buttons it can be like:
root:

feature1 (enable/disable)
feature2 (enable/disable)

feature 2 option (enable/disable)

feature 2 option (enable/disable)

But it's not directly related to Flyout feature, so I think it can be discussed in https://github.com/AvaloniaUI/Avalonia/issues/224 or new discussion later.

@maxkatz6 I've made the changes, if there's something else, or something I forgot, let me know.

Looks good to me, but I want somebody else to review code too.
@AvaloniaUI/core

@MarchingCube

Are concepts like MenuFlyoutItem supposed to be ported eventually too (not in the scope of this PR)?

It was discussed above, and we most likely will extend current MenuItem API instead of porting MenuFlyoutItem API. But it's not settled yet.

@maxkatz6 Thanks, missed that part of the discussion. I wonder if custom items would make implementing menu items hosting interactive content easier. Like I would like to have a structure like:
> root:
- > [MenuItem] Element
- - > [MenuItem] Clear element
- - > [HostedMenuItem] Contains a search box and a list of elements. Clicking on an item closes menu.

@amwx I found one issue with flyouts, which works fine in context menu somehow.
Subitems is not closed as expected on macOS.
https://user-images.githubusercontent.com/3163374/112464833-5e9e8a00-8d3a-11eb-946d-96cf2070e54f.mov

Same issue can be reproduced on Windows with OverlayPopups=True

The checkbox in the Menu Item with Checkbox is also cutoff on the right side. Not sure if that issue was introduced by the new flyout presenter style and its padding.

@maxkatz6 I think I've fixed the subitem issue. I copied some logic from ContextMenu that explicitly closes subitems when closing the original menu/flyout and I can't reproduce it now (at least on Windows w/ overlay popups).

The checkbox in the Menu Item with Checkbox is also cutoff on the right side. Not sure if that issue was introduced by the new flyout presenter style and its padding.

No, that's also occurs in the old context menu, so its an issue in the MenuItem template

@amwx Just wanted to say, I'm really excited to see work being done on these Flyouts :+1:
Also, uh...I figured it might be worth mentioning that I've just reproduced the submenu auto-closing problem a few minutes ago on Kubuntu Linux 20.04 (x64). If a video recording of the problem occurring would be of any use, I can try to get you one.

Also, uh...I figured it might be worth mentioning that I've just reproduced the submenu auto-closing problem a few minutes ago on Kubuntu Linux 20.04 (x64). If a video recording of the problem occurring would be of any use, I can try to get you one.

@Splitwirez  Is it the same problem as above (where the submenu stays open after parent closes)? If different, is this specific to the flyout implementation, or can it be repro'd with existing menus. Yes, a video may help too


Work with Derek to update the Openshift deployment pipeline for dev urls

Describe the task
Work with Derek to update the openshift deployment pipeline for dev urls. Check the example in FOM #475 to set the deployment number in the range 0-49.
Acceptance Criteria

[x] Update the pipeline for FOM

Additional context

Catherine has done the 0-49 supports for FOM pipeline; and the work is merged.
Will close this one.


set up rational for theme gallery additions

In the documentation, we have a dedicated page to show projects that are using our documentation. There are currently 18 projects referenced and building them takes a huge part of the documentation process (so much that we prevent it in the CI).
In recent weeks some extra projects wanted to be added to the list and my fear is that people use it as an advertisement page for their project. For me, this page is more of a list of fancy examples to guide new users in customizing their projects. I'm not sure adding extra vanilla pydata-sphinx-theme is going to help anyone.
What do you think if in this gallery we split the images into 2 lists:

the pydata projects: the theme is initially dedicated to them, they should, by all means, be listed here
the custom one: a list of carefully selected projects that embed interesting customization (extra navbar, map background, translation) to guide the users in the customization process

I would also like to update our documentation to specify that docs referenced in the gallery need to have a "little something" 😄
What do you think?
PS: Of course, early adopters will be kept because we love them very much

Agreed that the gallery is big enough already and we should consider being selective. Another idea is to have one section with screenshots and another that is just a list of links. Like "featured projects" (but without specially separating the pydata ones) and "other projects using the theme"

Also agreed - what about lile 3 marquee project with a preview that are relatively fixed. Then a longer list that is more like "logo + link"


Add support lifecycle, update Choco requirements

Description Of Changes

Update Chocolatey CLI requirements
Added a new page that enumerates the support lifecycle and supported Windows versions
Add a link to MS docs on enabling TLS 1.2 on older operating systems to the troubleshooting page

Motivation and Context
As we get closer to v2.0, we need to update our support info and requirements for the new chocolatey versions.
Testing

[x] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[ ] Minor documentation fix (typos etc.).
[x] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[ ] New documentation page added.
[ ] The change I have made should have a video added, and I have raised an issue for this.

Issue #

Change Checklist

[x] Requires a change to menu structure (top or left hand side)/
[x] Menu structure has been updated

Related Issue
Clickup

@gep13 @pauby
I checked through CLE and Agent pages, and neither of those currently mention required framework versions and so on. Should they? They essentially "inherit" the same supported frameworks and windows versions that CLI does, by virtue of CLI being required to be present before they can be installed or used. So I guess it's not necessary that they mention explicit requirements beyond the minimum Chocolatey versions, but it is a little odd to me that it doesn't really mention much there...

That makes sense to me, aye. 🙂

@ferventcoder I think I got everything updated from what you mentioned, thanks for the review! :3

Marking this as draft as we don't want it merged until closer to the v2 release.


Add NcDescriptor base

inherit all descriptors from NcDescriptor which has a nullable description

Reviewed on the call on the 31st of May 2022.


Fails trying to load the mapping suite

Hi!, I'm trying to load a mapping suite through the following configuration:
{
"branch_or_tag_name":"develop",
"github_repository_url":"https://github.com/OP-TED/ted-rdf-mapping-eforms.git",
"load_test_data":false,
"mapping_suite_package_name":"package_cn_v1.9"
}

Which according to me, points to the following mappings:
https://github.com/OP-TED/ted-rdf-mapping-eforms/tree/develop/mappings/package_cn_v1.9
When I run this it fails, after inspecting the logs I can see:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpl3t63egw/ted-rdf-mapping/mappings'
What else can be checked on?

Fixed in new deployment


Update event-4688.md

Added Windows 10 as a part of the title as this document on  Audit Process Creation feature is for  windows 10.
Per issue#https://github.com/MicrosoftDocs/windows-itpro-docs/issues/10955

@JohanFreelancer9 Please copy review

Learn Build status updates of commit 3870d75:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/auditing/event-4688.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@vinaypamnani-msft Please review and signoff this PR. Thanks