fix gateway with TCP and different bind listeners are not generated c…

Please provide a description of this PR:
Fix https://github.com/istio/istio/issues/43775
A similar issue as https://github.com/istio/istio/pull/43690 but conflict with different protocol.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @shonecyx. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


Enable gofumpt

Description
PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci

adds make tools
fixes make format

Should be merged after #1177 since this also updates to go 1.18

For contributor use:

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #1179 (bae8845) into main (4e79d7a) will increase coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   19.99%   20.70%   +0.71%
==========================================
  Files         199      194       -5
  Lines       25397    25259     -138
==========================================
+ Hits         5079     5231     +152
+ Misses      19392    19069     -323
- Partials      926      959      +33

Impacted Files
Coverage Δ

x/claim/module.go
58.06% <0.00%> (-5.27%)
:arrow_down:

x/pool-incentives/module.go
51.51% <0.00%> (-4.74%)
:arrow_down:

x/gamm/module.go
62.50% <0.00%> (-4.17%)
:arrow_down:

x/epochs/module.go
48.64% <0.00%> (-4.13%)
:arrow_down:

x/mint/module.go
52.63% <0.00%> (-4.13%)
:arrow_down:

x/lockup/module.go
53.33% <0.00%> (-3.49%)
:arrow_down:

x/incentives/module.go
52.17% <0.00%> (-3.39%)
:arrow_down:

x/superfluid/module.go
57.14% <0.00%> (-3.28%)
:arrow_down:

x/gamm/pool-models/balancer/msgs.go
81.08% <0.00%> (-3.13%)
:arrow_down:

x/gamm/keeper/pool.go
64.91% <0.00%> (-3.09%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cac00d...bae8845. Read the comment docs.

None of the changes gofumpt is making seem particularly helpful to me

@alexanderbez if Dev would like fumpt I'll take care of the rest that you've requested here

@alexanderbez changes made :)


feat(v4): add upcoming syntax features

Closes #9

I've rebased your PR onto st4149 branch and added some tests before squash merging locally.
Seems Github wants to add unwanted commits after rebasing it via website.
Due to doing stuff locally, it lost track of your PR being merged, unfortunately.


Invoke-ScriptAnalyzer: An item with the same key has already been added. What is the proper syntax?

I seem to be receiving a rule-less error whenever running PSScriptAnalyzer with default settings against a PowerShell script containing the following code block.
Environment
MacOS 10.15.4
PowerShell 7 LTS for MacOS
PSScriptAnalyzer 1.19.0
Code
$result = Invoke-Command -ComputerName $Computername -Credential $RemotingCred -Authentication Negotiate -ScriptBlock {
    $output=@()
    foreach ($item in $list) {
        $out = [PSCustomObject]@{
                    Property1   = $item.Property1
                    Property2   = $item.Property2
               }
        $output += $out
    }
    return $output
}

Command
Invoke-ScriptAnalyzer -path ./test.ps1

Expected Output
none
Actual Output
Invoke-ScriptAnalyzer: An item with the same key has already been added. Key: output

Question
What is the proper PowerShell syntax to prevent this error from generating? Or, which Rule can I ignore to suppress it? The code executes fine, just for the record :)
Thanks!

Which PSSA version are you using and which version of PowerShell? It does not repro for PSSA 1.19.0 on PS 7 (on Windows but that shouldn't make much of a difference)

Try getting the full error with Get-Error and showing us the stack trace

I've got it in the debugger already, it's happening here: https://github.com/PowerShell/PSScriptAnalyzer/blob/f9661f972883cf0def556ee2afd17fe327d269c2/Rules/UseUsingScopeModifierInNewRunspaces.cs#L220
Fix should be trivial

Actually, my fork didn't have the last 3 commits, this issues was fixed as part of PR #1493 and is effectively a duplicate of #1492

Hello.
This critical bug is causing all my GitHub Actions CI that use PSScriptAnalyzer to hang indefinitely.
See screenshot:

Using the ubuntu-latest runner with fresh PSSA installs from PSGallery every time.
Since this is such a severe bug, when can we expect a point release with the fix?
Thanks

Agreed.

@jantari A hang is unexpected and might be a different issue, can you provide more details please?
For the moment, we suggest to pin the version of PSScriptAnalyzer using the -MaximumVersion 1.18.3 parameter on Install-Module?
What do you think about a 1.19.1 release @JamesWTruher @rjmholt ? If, so then I'd like to have PR #1497 and optionally #1491 considered as well.

I am also seeing this issue, it seems to only affect scripts with hash tables that have duplicates in them. I've pinned to version 1.18.3 and get the error, which breaks my pester tests. like above. I also have tried pinning to 1.91.1 this throws the error still but the pester step in my build finishes without error, sans any testing it would otherwise do....

I am also having this issue.  Suppressing the rule doesn't seem to make any difference.  Is there any information I can provide that might aid in a resolution?

I'm in favour of a 1.19.1 release

Hey, @rjmholt, is there a schedule for a 1.19.1 release, by any chance?

Best to ask @JamesWTruher and @SydneyhSmith

@thomasrayner currently we are targeting a 1.19.1 release in about two weeks (likely the last week in July) however this is truly not a promise/commitment--just a good faith estimate....we are hoping to get another bug fix into this release, and then prioritize the release amongst other commitments

I wanted to say that during some general CI maintenance I switched to using 1.19.1/latest again and my deadlock is not occuring anymore, so appears fixed.
As far as I'm concerned, this can be closed.


Support android-arm64

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

not support by arm64 says in termux (Redmi Note 10S A13 Tiramisu Lineage OS 18 Based Custom Crdroid 9.2 ROM (Root/Unroot)

Duplicate of #304


Lack of Documentation: Response type - AuthenticationError

There is no Information about Response type dimension: AuthenticationError on this page. Could you please update this page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63c3effd-7cc3-f021-358a-adeaf59a0a69
Version Independent ID: 36381f6b-f57b-95a2-67cd-80bffcee238c
Content: Azure Storage metrics in Azure Monitor
Content Source: articles/storage/common/storage-metrics-in-azure-monitor.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@juyama Thanks for your question. We are checking on this and will respond to you soon.

@juyama Can you elaborate more on your query?

@fhryo-msft Are you familiar with this dimension ("AuthenticationError")? It appears to be missing from the list of dimensions for the "ResponseType" filter. I can't seem to find documentation anywhere else about the ResponseType dimension values.

We would like to know all of ResponseType before Classic alerts retired (i.e. next weekend). Some ResourceTypes seem to be included as below.
https://github.com/MicrosoftDocs/azure-docs/issues/33581

Please take response types described in current article as supported ones formally. We continuously improve metrics and new metrics or new dimension values may be added over time. You can ignore unpublished dimension values until we publish them by updating this article.

@juyama Kindly let us know if the above helps or you need further assistance on this issue.

Thank you so much for your explanation. There is no concern.

Thanks @fhryo-msft!


Delegates and Events

Explain delegates and events, crucial for implementing callbacks and event-driven programming.
Tasks:

Implement examples of delegates and events with explanations.
Document Action, Func, and EventHandler usage.
Include examples of event subscription and publishing.

Hi,
if no one work on this issue, I will do it.

Hi @FarzanehMG ,
Thanks for offering to take this on! That would be great if you could work on it. Please feel free to go ahead, and let me know if you have any questions or need any guidance along the way. Looking forward to your contribution!


Added benchmarks for List

Contributes to https://github.com/javaslang/javaslang/issues/725
Included PCollections and Functional Java also
The results are interesting for adding and iterating elements:
Ratios for: [10, 1000, 100000]

Group 'AddAll':
slang_persistent/fjava_persistent      : [1.37, 1.87, 2.14]
slang_persistent/java_mutable          : [1.08, 1.07, 0.81]
slang_persistent/pcollectins_persistent: [0.79, 0.88, 1.14]
slang_persistent/scala_mutable         : [1.02, 1.10, 1.40]
slang_persistent/scala_persistent      : [0.80, 1.05, 1.48]

Group 'Iterate':
slang_persistent/fjava_persistent      : [1.14, 1.01, 1.62]
slang_persistent/java_mutable          : [0.76, 0.39, 0.68]
slang_persistent/pcollectins_persistent: [0.81, 1.01, 1.62]
slang_persistent/scala_mutable         : [1.11, 1.07, 1.57]
slang_persistent/scala_persistent      : [1.08, 1.00, 1.26]

fjava seems to be always slower
Mutable and persistent Scala seem to be slower in most cases
pcollection seems to be faster for a few elements (maybe they're delegating everything to an array for small sizes, will investigate)
ArrayList is always faster for iteration, but often slower for insertion

[Current coverage][cc-pull] is 95.53%

Merging [#1321][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

@@             master      #1321   diff @@
==========================================
  Files            85         85
  Lines          9670       9669     -1
  Methods           0          0
  Messages          0          0
  Branches       1749       1749
==========================================
- Hits           9238       9237     -1
  Misses          313        313
  Partials        119        119

Powered by Codecov. Last updated by [e9ce470...fa7da53][cc-compare]
[cc-base-branch]: https://codecov.io/gh/javaslang/javaslang/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/javaslang/javaslang/compare/e9ce47058f814722e97fff90a307376272f51ab0...fa7da53718670c8076fe42baf2abd38b8e5a33ed
[cc-pull]: https://codecov.io/gh/javaslang/javaslang/pull/1321?src=pr

After some possibly controversial optimizations (@danieldietrich, please don't get mad at me), the add and iterate speeds are surprisingly close to the mutable one:
Ratios for: [10, 100, 1000, 10000]
Group 'AddAll':
slang_persistent/fjava_persistent       : [2.00, 2.20, 1.91, 1.95]
slang_persistent/java_mutable           : [1.50, 1.28, 1.14, 1.21]
slang_persistent/pcollections_persistent: [1.18, 1.17, 0.91, 1.45]
slang_persistent/scala_mutable          : [1.68, 1.56, 1.15, 1.22]
slang_persistent/java_mutable_linked: [1.56, 1.60, 1.22, 1.35]
slang_persistent/scala_persistent       : [1.21, 1.44, 1.08, 1.33]

Ratios for: [10, 100, 1000, 10000]
Group 'Iterate':
slang_persistent/fjava_persistent       : [1.43, 1.48, 1.54, 1.04]
slang_persistent/java_mutable           : [0.91, 0.56, 0.46, 0.43]
slang_persistent/pcollections_persistent: [1.01, 1.00, 1.34, 1.01]
slang_persistent/scala_mutable          : [1.38, 1.08, 0.96, 0.93]
slang_persistent/java_mutable_linked: [1.00, 0.86, 0.89, 1.29]
slang_persistent/scala_persistent       : [1.43, 1.44, 1.21, 0.96]

i.e. slang's List is now almost always faster than pcollections,fjava, and persistent and mutable scala.
It's slightly slower (but very close) to ArrayList and LinkedList.
Please take a look at the commits and tell me what I should keep, split in separate commits or just revert.

The Array optimizations for add and iteration are more evident, i.e.
Before:
Group 'AddAll':
java_mutable/slang_persistent: [5.04, 10.79, 76.37]
Group 'Iterate':
java_mutable/slang_persistent: [4.25, 24.84, 427.45]

after
Group 'AddAll':
java_mutable/slang_persistent: [10.35, 22.46, 109.96]
Group 'Iterate':
java_mutable/slang_persistent: [2.08, 5.09, 9.85]

While add became slightly slower (it's still in the tens of millions per second), iteration via tail became a lot faster.

[Current coverage][cc-pull] is 95.53%

Merging [#1321][cc-pull] into [master][cc-base-branch] will increase coverage by +<.01%

@@             master      #1321   diff @@
==========================================
  Files            85         85
  Lines          9670       9630    -40
  Methods           0          0
  Messages          0          0
  Branches       1749       1752     +3
==========================================
- Hits           9238       9200    -38
+ Misses          313        312     -1
+ Partials        119        118     -1

Powered by Codecov. Last updated by [e9ce470...d2c66ab][cc-compare]
[cc-base-branch]: https://codecov.io/gh/javaslang/javaslang/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/javaslang/javaslang/compare/e9ce47058f814722e97fff90a307376272f51ab0...d2c66ab88642d390bc95477f42ef11e9488891fb
[cc-pull]: https://codecov.io/gh/javaslang/javaslang/pull/1321?src=pr

I think the PR's get too big. We should separate our changes. E.g. first PR: benchmarks, then additional PRs: improved List, improved Array, improved ...


Add tag support

The Nikola developers asked that I add tag support to my theme. Not sure yet how to go about UI part of it though..

This is now resolved. :)


Merge in Repair Pack Feature.

Not sure if the factoriopedia description was done correctly.

This code does not work. Repair packs are item prototypes which means my control stage code has no effect on changing their quality bonuses. I'm pretty sure its impossible to add this feature to repair packs.


Restructure project

Graphalytics will only include core and validation (currently named graphalytics-tests). Each platform in platforms will be a separate repository. Platform configuration files will be extracted from config.
Each platform will also be a separate Maven project, depending on the core project. Once packaged, each platform code will be used by the core code for actual benchmarking. run-benchmark.sh will sill be used for running the benchmark.
Obtaining binaries will work as follows:

compile-benchmark.sh without flags will install core and validation in the local Maven repository.
compile-platform.sh (new script) in each platform to obtain platform binaries.
Configure path for platform binaries in graphalytics.
package-benchmark.sh (new script) to create a redistributable archive of core (validation?) and platforms, as well as run-benchmark.sh and platform-specific prepare-benchmark.sh scripts.

Done. Instead of compile-benchmark.sh we use mvn install for core and mvn package for each platform.


PC-584 PC-514: unique identifier for each referral

closes PC-584 & PC-514 (since they are so similar)
adds a new migration that adds a postgres SERIAL column to the database which assigns a unique referral id to each referral. this is true retroactively, existing referrals will be given a referral id
this referral id is shown at form completion
english:

welsh:

as well as included in emails
english:
Subject: Referral to British Gas successful
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Date: Mon, 22 Jan 2024 14:34:49 -0000
Message-ID: <170593408992.123.6954768841899672035@75d2c0b4dff6>

Hi,

Your reference number is GBIS0000168

Your details have been submitted to British Gas.

...

welsh:
Subject: Cwblhau atgyfeiriad
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Date: Mon, 22 Jan 2024 17:18:23 -0000
Message-ID: <170594390356.123.15128990575147716244@19e53f73ebac>

Shwmae,

Eich rhif cyfeirnod yw GBIS0000166

Mae’ch manylion chi wedi'u cyflwyno i British Gas.

...

this referral id is then exported in the csv

the csv is now ordered by referral id. this is not specified in the ticket, but seemed the most sensible way to order things (previously no ordering was applied)

Only potential concern I can see is security audit complaining about publicly visible serial identifiers. They're not used as inputs anywhere though, so it should be fine? And I think something like GUIDs would be sufficiently user-unfriendly as to not be worth it.


function_call_space removes space also from function definitions

function_call_space When making a method or function call, there MUST NOT be a space between the method or function name and the opening parenthesis.
This fixer removes also space after function name in a function definition, not just a call.

This fixer needs a rename in any case. Although I would love to see a fixer that removes space only from function calls and leaves it in definitions.

This fixer removes also space after function name in a function definition, not just a call.

Could you point to it?

Erm... I took this from the documentation. Do you mean link to this file? https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/1.11/Symfony/CS/Fixer/PSR2/FunctionCallSpaceFixer.php

This fixer removes also space after function name in a function definition, not just a call.

Please point to that part directly. Which line?

Oh, you mean, you cannot reproduce it. Sorry!
test.php:
<?php

function TisMy ($p1)
{
	print $p1;
}

Gets formatted to:
<?php

function TisMy($p1)
{
	print $p1;
}

By:
./php-cs-fixer.phar fix test.php --config-file test.php_cs
Loaded config from "test.php_cs"
   1) /home/janis/bin/phpcsfixer/test.php
Fixed all files in 0.067 seconds, 5.750 MB memory used

Where test.php_cs:
<?php

$finder = Symfony\CS\Finder\DefaultFinder::create()
	->in(__DIR__)
;

return Symfony\CS\Config\Config::create()
	->level(Symfony\CS\FixerInterface::NONE_LEVEL)
	->fixers([
		'function_call_space',
	])
	->finder($finder)
;

Oh, that's what you mean!
You have quoted that line like it was description of fixer

> sdf
asdfafds
asdfasfd
sadfdafs

is all the one quote:

sdf
asdfafds
asdfasfd
sadfdafs

if you want to quote only one line you must put empty one after it, like:
> sdf

asdfafds
asdfasfd
sadfdafs
```

> sdf

asdfafds
asdfasfd
sadfdafs

Done.

ping @keradus this one can be closed :)

Thanks ;)
If the content of first post will be sth like "Closes #1498" then the issue will be automatically closed during merging.

Cool, didn't know, will keep in mind for next time :)


0.7.0 upload unsuccessful "NaN is not a valid double value"

Since updating to 0.7.0 the uploader produces the following error

Uploading to nightscout was unsuccessful. NaN is not a valid double value as per JSON specification. To override this behaviour, use GsonBuilder.serializeSpecialFloatingValues() method.

Effects:

all items other than the SG and PUMP are not being uploaded
most notably the following data is missing:

BG
Bolus
Notifications

What I tried so far

deactivated all upload tasks but SG and Bolus

App has uploaded the content once (out of several tries) but other than that, the error is still prevalent. Also I couldn't reproduce this.

downgraded app to 0.6.1

Error disappears, data is successfully uploaded again

tested on different phone (CAT S40)

Same behaviour, Error still prevalent

Environment

Uploader Version Number: 0.7.0
Android Phone Model: Unihertz Atom
Android Version Number: 8.1
Network Connection: error prevalent both in cellular as well as wifi
Nightscout website version: 0.12.3

This is fixed for the v0.7.1 hotfix version, should be out soon. Use v0.6.1 for now.

Excellent! Thanks a lot for the feedback and your work on this app!!

Released v0.7.1 has a fix for this. Please report if there is still a problem, thanks.


[Doc] Remove unique key from Sync MV

Problem Summary:
Fixes # (issue)
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


The 'play' code doesn't work when there is more than one gifview.

The 'play' code doesn't work when there is more than one gifview.

in windows platform

Solve in 0.4.3. Please check the example.


fix html lang attribute

1. Why is this change necessary?
In case, you use inherited language, the html lang attribute is empty.
2. What does this change do, exactly?

Changed HeaderPageletLoader::getLanguages to load associated locale
Changed base.html.twig to use activeLanguage.locale instead of activeLanguage.translationCode. In case of inherited languages, the translationCode is null, whereas locale stores the inherited locale.

3. Describe each step to reproduce the issue or behaviour.

Create a language, that inherits another language.
Assign the language to your storefront.
Open the storefront in that language.
Check the lang attribute in the html tag.

4. Please link to the relevant issues (if any).

5. Checklist

[X] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change <- I couldn't think of a useful test for this
[X] I have created a changelog file with all necessary information about my changes
[X] I have read the contribution requirements and fulfil them.

copilot:summary
copilot:walkthrough

@shopware/ct-storefront can you take a look here? :eyes:

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-26889
Please use this issue to track the state of your pull request.

Hi @silviokennecke,
thank you for your contribution. 🎉
Just for clarification: The empty lang attribute only happens, when you also inherit the ISO code from the language you are inheriting from? Then I can reproduce it. When you explicitly provide an ISO code it works.

However, with you changes it is the other way around for me. It works when you inherit the ISO code. Then it is shown in the lang attribute. But when you provide an ISO code yourself it is no longer shown. Then it always inherits the ISO code, regardless if it is selected in the admin. Can you also reproduce this?

Hi @tobiasberge ,
Yes, you got right, what the issue is. I’ll try to reproduce the behaviour that you described and then update my PR.

When you explicitly provide an ISO code it works.

Apparently, I cannot set the iso code twice, as translation_code_id is unique (uniq.translation_code_id). It happens quite often, that users have two sales channels that for instance both support de-DE but their snippets are slightly different. Also, if that would be the solution, the inheritance possibility for that field does not make any sense.


copy config.guess from

The original pHash have too old `config.guess' (released in 2008), so it couldn't idenitfy aarch64.
The patch uses automake 1.16 config.guess.

Any chance of this getting merged? It'd help those of us still on older Ruby vers.


TabView inside a ScrollView.

I'm not able to see or scroll (when I try to give a fixed height at here in the ListViewExample) the content when using a TabView inside a ScrollView. How can I achive this feature. Is there any param I need to pass?
TopBarTextExample from ScrollViewsExample;
ListViewExample form ListViewExample;
<ScrollView style={{flex:1}}>
    <ImageSlider images={[
        'http://placeimg.com/640/480/any',
        'http://placeimg.com/640/480/any',
        'http://placeimg.com/640/480/any'
    ]}/>
    <TopBarTextExample/>
</ScrollView>

How to achive TabView inside a ScrollView. In here, I need to fade away the ImageSlider content when scrolling the TopBarTextExample, then again scrolling means should scroll the contents of TopBarTextExample.

@nabeelvalapra I guess it's happening to you on Android (not on iOS).
If that's the case, check #105 for a workaround

@jbrodriguez Yea, the workaround worked. But any Idea on how to make<TabBar> content of <TopBarTextExample> static(floating).

@nabeelvalapra not really, I think I saw a similar question in one of the issues.
Check there or open another issue :)

It's just a React component. Figure out what you'd need to do if you wrote such a component and do the same thing.

same problem :anger: , could not be solved following many issues ..
I reproduced the problem here ,
any solutions ??


Long screenshot

Description of the new feature / enhancement
I want the new feature about long screenshot.
Scenario when this would be used?
There is no long screenshot function in the software. If you want to take long screenshots, you need to use other software.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/3388


[FR/Bug] Copy button for folded codeblocks

Hi! Thanks for developing such a nice plugin!
In Live Preview / Editing View, it seems that the "copy code"-button isn't showing when the codeblock is folded. Is this intentional? Would it be possible to add this?
Folded (with mouse hovering, even though it doesn't show in the image):

Unfolded:

(In reading mode, it shows even when folded)

(Settings):

Hi!
No, I didn't notice it. I will correct it in the next release.

@jobor019 quick question. (Please respond as soon as you can, because I want to release the new version soon.)
If the code block is collapsed:

should the copy code button always be shown on the header, or only when hovered over the header? In reading mode it is only shown when hovered over the header.
if multiple buttons are enabled (delete code, and select code), should they also be displayed, or only the copy button? The select code, and delete code buttons would not make much sense, but the copy button I can understand that it should be displayed.

Hmm, I think it's a good idea to stay consistent, so it should probably only show when hovered just like in the other modes.
For the delete/select code buttons, I don't use either of them so I cannot say, but your intuition make sense to me. I can't really understand why anyone would want to select folded code except for copying it. Again, it's probably a good idea to stay consistent with how you're currently handling this in the other modes

I totally agree with you. I'll also add an option to always display the copy button when the header is collapsed, but by default it will only be displayed when hovered over the header.

Hi @jobor019!
Sorry for the delay. Now it should work as follows:

if code block is collapsed -> only copy button is displayed when you hover over the header
if code block is uncollapsed -> all enabled buttons are displayed in header
there is an additional option where you can enable if the buttons should be displayed (when the code block is uncollapsed) if the   cursor is inside a code block or not

I would be thankful if you could quickly test it and give me a feedback if everything works correctly. You can just overwrite the main.js and styles.css files (create a backup before).

No worries, there's absolutely no rush on my side!
Great work, everything seems to be working exactly as you describe!

Might be worth noting that it seems that all my settings for the plugin were wiped when copying it like that, even after restoring the old files. Obviously not a problem for me since I can just change them back in 5-10 min, but it might be a problem if this is something that happens to all users when you publish the next version of the plugin?

All settings got restored? That's weird. I changed only the settings regarding the buttons. So only those settings should have been restored to default. I will definitely look into it. Thank you very much for your testing and Feedback. Release in 1-2 days.

Available in version 1.2.8


This Coop-Mod is not working anymore

https://drive.google.com/file/d/0B3N5niz28pjJSlZRUk5HZm1pZkk/view?usp=sharing

You can Start a Server.
You can Join.
Its try too sync the Money.
but Streets are not synced.

I never came to implement the synchronization of streets and buildings. That may be why it does not work :)

ah, that make sense

I could not find an easy way to access the necessary building and street information. That's what prevented me from going further. If you have more info about it, maybe you can tell me/us?

http://www.skylineswiki.com/Modding_API
-Last Section

"Interfacing with the Unity Engine
By including the Unity Engine namespace with using UnityEngine; direction, it is possible to access Unity's scripting API. http://docs.unity3d.com/ScriptReference/
Only the API from UnityEngine is available (Editor and others will not be).
It is possible to create GameObjects dynamically, as well as MonoBehaviours and use the standard callback mechanic Unity provides."

Thats the only way in the API too set; get; objects.
Here you can see how you can get the Info of a Building:
https://github.com/lxteo/Cities-Skylines-Extended-Building-Info/blob/master/ExtendedBuildings/ExtendedLoading.cs
And here you can see how you can create streets:
https://github.com/lxteo/Cities-Skylines-Mapper/blob/master/Mapper/RoadMaker.cs

That's pretty neat. Thanks for sharing!

This is another mod adding multiplayer, which appears to work (from videos I've seen): https://github.com/CitiesSkylinesMultiplayer/CSM


Why require PHP 7.2?

PHP 7.2 did not add that much functionality, so I was curious if this package actually needed it, so I installed PHP 7.1 (using your amazing powershell module), replaced the require-dev version constraints with "*", ran composer update, and the PHPUnit tests all ran fine:

I'm not sure we can safely use this library on PHP 7.1: we should include code coverage in tests to be sure that tests touch as many PHP files as possible

I'm not sure we can safely use this library on PHP 7.1: we should include code coverage in tests to be sure that tests touch as many PHP files as possible

Whoops... it's already implemented in this project (I guess I'm maintaining too many open source projects :wink:)


Select Target Twitter Profiles for Tweet Generation

As a user,
I want to select a target public Twitter profile for subject matter,
So that Tailored can source tweets to use as primary points of reference for generating new tweets.
I want to select a target public Twitter profile for style and tone,
So that Tailored can mimic the writing style of the selected profile when generating tweets.
Acceptance Criteria:

User can search for and select a target Twitter profiles.
System retrieves tweets (excludes retweets) from the selected profiles.
System stores selected profile for tweet generation reference.

https://www.notion.so/volumefi/EPIC-06-22-24-Tailored-Twitter-Tweeter-V002-4784202cc6da4485aaa038f4dfa0091e?pvs=4#7b06f19b40bc428aafe430d14807b854

Finished with https://github.com/VolumeFi/tailored-ui/pull/15


Record and propagate events information per lumi to DBS

fixes #7712
Initial attempt to handle event per lumi. Patch contains.

schema change on wmbs - already in master (https://github.com/dmwm/WMCore/pull/7779)
reading from DBS with event information (dbsapi.listFileLumis - should return events information, check with Yuyi about the format) - done
reading from FWJR with event information - already in master branch (https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/FwkJobReport/Report.py#L89)
Update the query to insert event information from 1., 2. - included in this patch
Read events information from updated *_runlumi_map table with correct format - included in this patch
writing to dbs. (using dbsApi.insertBulkBlock call) - done
Writing to ACDC - done (current agent code might be broken.)
Read from ACDC -  done

Still initial version, need to consult with @yuyiguo

 JobAccountant needs to get info into WMBS

Thank you very much Alan. I just didn't want you to look at the buggy code yet. But that is great help. About ACDC it will contain different format if there is event numbers.
Currently,  the run structure in ACDC is following
"runs": [
               {
                   "run_number": 263333,
                   "lumis": [182]
               }
           ],

If contains events it will be something like this.
"runs": [
               {
                   "run_number": 263333,
                   "lumis": [(182, 123)]
               }
           ],

It should be handled either case, when LQ pull down the record. I am not sure whether it will break something in any other places. (I couldn't find the place by just looking at the code, it should be tested thoroughly though).
I think when patch is somewhat ready. (when it passes all unittests), I will do the integration test with and without num_events populated.

test this please

test this please

test this please

test this please

test this please

test this please

I ran all the test including ACDC. It seems working fine. I still couldn't figure out why workqueue test is failing.  There seems to be layers of failure on workqueue with different reason.
@amaltaro, @ericvaandering, Alan, Eric please review.

test this please

test this please


Adds subnetworks for new regions

I failed to add these in an earlier PR (#17).

This change is

Does anything other than TF and the virtual nodes depend on these subnetwork definitions? Is there a migration path to having TF fully manage these itself?

Hmm...  it looks like the field ip_cidr_range is required and cannot be automatically generated:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_subnetwork.html#ip_cidr_range
This may continue to be necessary, or there may be some other strategy that I don't yet know of.


How to build OptimLib into shared library with MSVC compiler under Windows OS?

This is a fantastic C++ optimization library. I have compiled the examples with MSVC compiler and they ran well under Windows OS. I wonder if there is a guide to build OptimLib into windows dynamic link library (dll)?

This is a fantastic C++ optimization library. I have compiled the examples with MSVC compiler and they ran well under Windows OS. I wonder if there is a guide to build OptimLib into windows dynamic link library (dll)?

Can you please explain how you made it to compile using MSVC? Thanks a lot!

I created the following CMakeList.txt You can probably use that as well. Note that I'm using this library with armadillo. So I had previously built openblas and lapack. You can modify the CMakelist.txt to use Eigen instead.
cmake_minimum_required(VERSION 2.8.3)
project(optim)

#================================ set proper directories ============================

#set the module directory
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR}/cmake)

#build the executable in the binary directory on MS Visual Studio
if ( MSVC )
	SET( CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG "${OUTPUT_DIRECTORY}")
	SET( CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE "${OUTPUT_DIRECTORY}")
endif ( MSVC )

#================================ Compiler ========================================

# Turn on C++11
add_definitions(-std=c++11)
add_definitions(-DOPTIM_ENABLE_ARMA_WRAPPERS)

if(NOT CMAKE_BUILD_TYPE)
  set(CMAKE_BUILD_TYPE Release)
endif()

#================================ external packages ========================================
FIND_PACKAGE(Threads REQUIRED)
FIND_PACKAGE(X11)

option(OPTIM_HEADER_ONLY OFF)

#================================ include directories ========================================
set(ARMADILLO_INCLUDE_DIRS          ${CMAKE_SOURCE_DIR}/3rdparty/armadillo/include)

if(OPTIM_HEADER_ONLY)
	set(OPTIM_INCLUDE_DIRS              ${CMAKE_SOURCE_DIR}/header_only_version)
else()
	set(OPTIM_INCLUDE_DIRS              ${CMAKE_SOURCE_DIR}/include)
endif()

include_directories(
  	${OPTIM_INCLUDE_DIRS}
	${ARMADILLO_INCLUDE_DIRS}
)

#================================ executables ========================================
file(GLOB SRC
				"${CMAKE_SOURCE_DIR}/src/constrained/*.cpp"
				"${CMAKE_SOURCE_DIR}/src/line_search/*.cpp"
				"${CMAKE_SOURCE_DIR}/src/unconstrained/*.cpp"
				"${CMAKE_SOURCE_DIR}/src/zeros/*.cpp"
)

add_library(optim SHARED
	 ${SRC}
)

# add_executable(optim
	# ${CMAKE_SOURCE_DIR}/tests/unconstrained/bfgs.cpp
# )

#================================ linking ========================================

if(WIN32)
	set(OPENBLAS_LIBRARIES  	"${CMAKE_SOURCE_DIR}/lib/openblas.lib")  #fast replacement for BLAS
	set(LAPACK_LIBRARIES        "${CMAKE_SOURCE_DIR}/lib/liblapack.lib")

	# if(NOT OPTIM_HEADER_ONLY)
		# set(OPTIM_LIBRARIES        "${CMAKE_SOURCE_DIR}/lib/optim.lib")
	# endif()

endif(WIN32)

target_link_libraries(optim
	${X11_LIBRARIES}
	${CMAKE_THREAD_LIBS_INIT}
	${OPENBLAS_LIBRARIES}
	${LAPACK_LIBRARIES}
	# ${OPTIM_LIBRARIES}
)

It would be great if this library can be used via package managers like vcpkg.


Add support for eth_getTransactionReceipt command

I would like to get a value of "gasUsed" in each transactions at the same time as Blocks and Transactions data exporting.
I think adding support of JSON RPC "eth_getTransactionReceipt" is the best way to get this information, but is it possible to implement to this ETL tool?

Thanks for your reply.
I thank that trasactions.tx_gas and transaction_receipt.gas_used are not same.
https://github.com/ethereum/go-ethereum/issues/1097
So I want support of eth_getTransactionReceipt in this ETL tool.
Sincerely
2018/06/20 0:44、medvedev1088<EMAIL_ADDRESS>
Yes it's possible to add transaction receipts to this tool however request batching can be a bit tricky.
BTW why don't you use transactions.tx_gas. It contains gas used in a transaction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You are right, they are different fields.
Here is how it could be added to export_blocks_job.py:
    def _export_batch(self, batch_start, batch_end):
        blocks_rpc = list(generate_get_block_by_number_json_rpc(batch_start, batch_end, self.export_transactions))
        response = self.ipc_wrapper.make_request(json.dumps(blocks_rpc))

        blocks = [self.block_mapper.json_dict_to_block(response_item['result']) for response_item in response]

        for block in blocks:
            self._export_block(block)

        transactions_hashes = [tx.hash for tx in block.transactions for block in block]
        if export_receipts:
            receipts_rpc = list(generate_get_receipt_by_tx_hash_json_rpc(transactions_hashes))
            response = self.ipc_wrapper.make_request(json.dumps(receipts_rpc))
            export_receipts(response)

@tokusyu please help upvote this feature request https://github.com/ethereum/go-ethereum/issues/17044. It will be much easier to export receipts with this change.

@tokusyu I added support for receipts and logs https://github.com/medvedev1088/ethereum-etl#command-reference. Please help test if you have a chance.
I also uploaded receipts and logs to the public dataset on BigQuery https://medium.com/@medvedev1088/ethereum-blockchain-on-google-bigquery-283fb300f579

Thanks.
I tested it and It worked like a charm.


vieb: Use autoPatchelfHook for 7z binary

Motivation for this change
Fix #133077 .
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Currently, the libexec/vieb/node_modules/7zip-bin/linux/x64/7za seems to be succesfully patched, but Vieb is still unable to install extensions with this change.

how about replacing the faulty 7z-bin by nixpkgs's one ?

@symphorien that could also work, but I'm not really sure how to do that. Do you have any pointers for how to do that?
I'm hesitant to just copy in nixpkgs's 7zip executable into the node_modules/7zip-bin directory since the 7z binary is pulled in as part of the 7zip-bin yarn package, and I'm worried that copying in the executable is fragile.

I'm hesitant to just copy in nixpkgs's 7zip executable into the node_modules/7zip-bin directory

that's exactly what I was thinking about. A symlink would be even better. Can you elaborate how this would be fragile?

I'm worried it's fragile because it seems that I would need to accont for different archs/platforms, and I'm not sure how to test that.
Using the autopatchelf script abstracts away from arch/platform-specific paths. What's the downside to this approach?
In any case, I tried your symlinking suggestion (something like ln -s -f ${p7zip}/bin/7z $out/libexec/vieb/node_modules/7zip-bin/linux/x64/7za) and the resulting 7z binary works fine (on linux/x64). But Vieb is still unable to install extensions (there's still something wrong with it that I need to fix).

Well the thing is, patchelfHook is not the most robust solution either. For example if the node package starts shipping binaries compiled with more recent glibc version that nixos, then the executable will fail at runtime.
Regarding the architecture, anyway the 7z executable from nixpkgs has the right architecture, so even if you replace all executable files named 7z* by a symlink to the store with find, this will be correct.
In the end, as de facto you are maintaining this package, I'll leave the decision to you, but I think using 7z from nixpkgs seems better to me.

Result of nixpkgs-review pr 133151 at 2a6c2b4a run on x86_64-linux 1

1 package built successfully:

vieb

2 suggestions:

warning: build-tools-in-build-inputs
yarn is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:294:7:
    |
294 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^

warning: build-tools-in-build-inputs
rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:294:7:
    |
294 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^

We're already replacing electron with the nixpkgs-built version.  I'd prefer to use p7zip from nixpkgs as well.  And please replace all 7za binaries, these are taking up ten useless megabytes.
Either way, I think we should wait with merging this PR until the extension installation works.

Got it @symphorien , I updated the PR to do what you suggested, thanks for the feedback!
@gebner I'll wait for that update. Is there a PR or issue associated with that?

@gebner , any updates on the electron update that this is blocked on?

I don't think this PR requires an electron update.  I just preferred to wait until the extension installation works in vieb.  But let's just merge this PR, it's a clear improvement over the current state.

Got it, thanks @gebner !


Long discord messages cause crashes

IRC max message length is 512 bytes including PRIVMSG command, etc..
Should probably truncate messages and hastebin the full message

Fixed in da3a0d7e8566e981f8601fe5dce834f378cbe383, but can be improved later as commented in the code


feat(utils): Map data structure with default return

#1001
#1000
#999  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite


[Feature] regardless if the catalog query itself is pre-filtered or not, post-filter its results

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Originally from https://github.com/dbt-labs/dbt-core/issues/9394
If I use a selector with dbt docs generate, I expect only the selected nodes to be returned in the catalog.json
Acceptance criteria

regardless if the catalog query itself is pre-filtered or not, post-filter its results
i.e., dbt docs generate -s a b c tag:one_hundred_models should only include those 103 models within catalog.json, even if there are 2000 models within the project.

I ended up addressing this as part of https://github.com/dbt-labs/dbt-core/issues/9755!
Tests here: https://github.com/dbt-labs/dbt-mantle/blob/main/tests/functional/docs/test_generate.py#L156


Unhandled Exception: Python.Runtime.PythonException: FileNotFoundException : Could not find file

Expected Behavior
Simply Running hello World Example after fresh installation in fresh virtual environment. And Exception occurred. It should run the hello world without any error. As mentioned in the error Exception file not found so it was easier for me to figure out the possible solution. I opened the directory mentioned in the error, there was a png icon file, I converted that file to .ico file with name tiberius.ico and saved in the same directory (resources). Booom it fixed the issue.
I Should have create a PR instead but I don't know where to place the right code for package to copy the ico file along with installation package.
Current Behavior
Unhandled Exception: Python.Runtime.PythonException: FileNotFoundException : Could not find file 'C:\Program Files\Anaconda2\envs\BeeWare\lib\site-packages\toga\resources\tiberius.ico'.
Steps to reproduce

New Virtual Env

helloworld.py sample code from the docs.

python -m helloworld

boom, Error Occured

Your Environment

Python Version 3.6.4

Operating System and Version (select from the following and list the specific version number; if your OS is not listed, list that as well)

[ ] macOS - version:
[ ] Linux - distro:   - version:
[x] Windows 10- version:1803 Build 17134.165
[ ] Other - name:  - version:

Toga Target (the type of app you are trying to generate)

[ ] android
[ ] cocoa
[ ] django
[ ] gtk
[ ] iOS
[ ] tvOS
[ ] watchOS
[x] winforms
[x] win32
[ ] Other (please specify)

Solution
place tiberius.ico file in the resources directory of installation package.

Thanks for the report - I'm fairly certain this is a duplicate of #567. This has been corrected in master, and the fix will be included in 0.3.0.dev10.

the file was missing from my installation

Mine too


False Positive on ActionControllerFlashBeforeRender when redirecting after branch

Redirecting outside of the branch that set the flash is causing a violation when it should not:
e.g.:
def create
  if condition?
    flash[:success] = "Yes!"
  else
    flash[:error] = "No!"
  end

  redirect_to action: 'show'
end

rubocop -V
1.38.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.23.0, running on ruby 2.7.6) [x86_64-darwin21]
  - rubocop-performance 1.15.0
  - rubocop-rails 2.17.2
  - rubocop-rspec 2.14.2

This issue is a dup with #843 and resolved by #844. Please wait for the bug fix release.

Thanks, sorry I missed that this was already reported.


Typo

Describe the issue
estimtor should be estimator
Affected File
ahrs.hpp
Affected Line
24

@jamie-54 can you create a PR for this typo as well as #126?

yea


ENH: stats.median_test: convert output tuple to Bunch

Reference issue
https://github.com/scipy/scipy/issues/16364
https://github.com/scipy/scipy/issues/13118
What does this implement/fix?
https://github.com/scipy/scipy/issues/16364 suggests that all statistical functions that currently return tuples should return Bunch objects. This PR converts the tuple returned by stats.median_test to a Bunch.

OK, done.


Static Fetchers

We have too many "utils" scattered around our code base which encode different ways of fetching a particular model. I think it's time that we introduce static "fetcher" methods:

Model.fetchAll(params)
Model.fetchOne(id, params)

These methods each delegate to the corresponding fetch methods in the store.
This means that:

we don't need a reference to the dataStore to do a fetch. We can do it from the model class, which we can import in whichever module we happen to be in
CropBatch.fetchAll(queryParams)

we could move fetch utils into ArtemisStore where they can be part of the Model api and can be tested as such.
CropBatch.fetchBetween(startDate, endDate)

I only added fetch variants and avoided find variants because we currently don't support filtering records which have already been loaded by query params. I'd like to add support for that as well since that could enable a more sophisticated caching model, partial fetching, and UIs where cached date can be rendered before new data is returned, but that will be more work. This is more to demonstrate a path forward towards those ends than to be an all-encompassing solution.

Going to close this since it's stale and unlikely to be merged.


Go: ergonomics improvement for Variants type

This issue is created for a discussion on improving the variants type in the Go bindgen.
To see how the variants type is generated, please read the head of this https://github.com/bytecodealliance/wit-bindgen/issues/612#issue-1801773199.
A summary of what's being proposed: https://github.com/bytecodealliance/wit-bindgen/issues/612#issuecomment-1644691976

I think a sealed interface as suggested by @lann in https://github.com/bytecodealliance/wit-bindgen/issues/612#issuecomment-1633404434 is my preferred solution to variants. If possible, I'd suggest avoiding setters in favor of concrete assignment (this is similar to how the Go protobuf generation has getters but no setters on oneof types).

https://github.com/bytecodealliance/wit-bindgen/issues/612#issuecomment-1639655039 by @qmuntal points out a potential performance optimization allowed by struct wrappers. It would be worthwhile to (micro-)benchmark the two approaches to get an idea of the potential performance deltas.

For reference, the new log/slog package code using the struct wrapper kind approach is here: https://cs.opensource.google/go/go/+/refs/tags/go1.21rc3:src/log/slog/value.go;l=21.

It would be worthwhile to (micro-)benchmark the two approaches to get an idea of the potential performance deltas.

Disclaimer: please do your own benchmarks, I'm not a users of this project and I can be biased towards a niche use-case.
I did run some benchmarks:

Code: https://play.golang.com/p/uD0J_f5bLJZ
Benchmark code C1: https://play.golang.com/p/TE0SZepwuIR
Benchmark code C2: https://play.golang.com/p/gpKHjQqXVDa

Results:
(c1 == sealed struct, c2 == sealed interface)
goos: windows
goarch: amd64
pkg: gotest
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
                │    c2.txt      │                c1.txt                 │
                │     sec/op     │    sec/op     vs base                 │
AppendInt32-12     213.50n ±  2%   20.64n ±  4%   -90.33% (p=0.000 n=10)
AppendInt64-12     261.00n ±  1%   19.14n ±  1%   -92.66% (p=0.000 n=10)
AppendString-12    606.15n ± 13%   42.88n ±  8%   -92.93% (p=0.000 n=10)
AppendMix-12      1163.50n ±  7%   65.78n ± 13%   -94.35% (p=0.000 n=10)
Access-12           1.292n ± 11%   2.623n ±  9%  +102.98% (p=0.000 n=10)

                │   c2.txt     │                 c1.txt                  │
                │     B/op     │    B/op     vs base                     │
AppendInt32-12    80.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
AppendInt64-12    160.0 ± 0%       0.0 ± 0%  -100.00% (p=0.000 n=10)
AppendString-12   320.0 ± 0%       0.0 ± 0%  -100.00% (p=0.000 n=10)
AppendMix-12      640.0 ± 0%       0.0 ± 0%  -100.00% (p=0.000 n=10)
Access-12         0.000 ± 0%     0.000 ± 0%         ~ (p=1.000 n=10)

                │   c2.txt     │                 c1.txt                  │
                │  allocs/op   │ allocs/op   vs base                     │
AppendInt32-12    20.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
AppendInt64-12    20.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
AppendString-12   20.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
AppendMix-12      60.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
Access-12         0.000 ± 0%     0.000 ± 0%         ~ (p=1.000 n=10)

Highlights:

Sealed struct wins:

No allocations
10 times faster to append to an slice

Sealed interface wins:

2 times faster to access a value via type-switch

Although the sealed interface approach is faster in terms of type-switching, the absolute difference is so small (1n vs 2n) that I don't expect it to compensate the increased GC pressure.

In fairness, we probably should be doing these benchmarks on WebAssembly, not amd64 😅. I also want to caution against being guided too much by benchmarks in designing an ergonomic interface. I am still a fan of the sealed interface, perhaps we could implement both and then perform benchmarks? Ideally with real world examples, too.

Okay so to summarize the discussion so far. We will want to implement both the sealed interface and sealed struct + integer optaimization methods and comapre their real world benchmarks on Wasm.

Turns out that using a sealed struct works fine, and is ABI compatible (at least on TinyGo, and eventually on GOARCH=wasm32) with the Canonical ABI.
Here is an example of various variant and result types in-progress targeting WASI Preview 2: https://github.com/ydnar/wasm-tools-go/tree/main/wasi
I modeled the API after the Go enum pattern, with constructors and getters, but not setters (per @johanbrandhorst’s observation). Variant values are pass-by-value (for ABI compatibility), but can implement a common interface.
Ignoring that the type (new-timestamp) starts with New when translated to Go…
// NewTimestamp represents the variant "wasi:filesystem/types.new-timestamp".
//
// When setting a timestamp, this gives the value to set it to.
type NewTimestamp struct {
        v cm.Variant[uint8, DateTime, struct{}]
}

// NewTimestampNoChange returns a NewTimestamp with variant case "no-change".
func NewTimestampNoChange() NewTimestamp {
        var result NewTimestamp
        cm.Set(&result.v, 0, struct{}{})
        return result
}

// NoChange represents variant case "no-change".
//
// Leave the timestamp set to its previous value.
func (self *NewTimestamp) NoChange() bool {
        return self.v.Is(0)
}

// NewTimestampNow returns a NewTimestamp with variant case "now".
func NewTimestampNow() NewTimestamp {
        var result NewTimestamp
        cm.Set(&result.v, 1, struct{}{})
        return result
}

// Now represents variant case "now".
//
// Leave the timestamp set to its previous value.
func (self *NewTimestamp) Now() bool {
        return self.v.Is(1)
}

// NewTimestampTimestamp returns a NewTimestamp with variant case "timestamp(datetime)".
func NewTimestampTimestamp(v DateTime) NewTimestamp {
        var result NewTimestamp
        cm.Set(&result.v, 2, v)
        return result
}

// Timestamp represents variant case "timestamp(datetime)".
//
// Set the timestamp to the given value.
func (self *NewTimestamp) Timestamp() (DateTime, bool) {
        return cm.Get[DateTime](&self.v, 2)
}


Create agent(v2)

/agents.

Only agents with a graphUrl are displayed.
Enabled to create agents.

/p/:id/canary.

Display the graphUrl initially by fetching it.

@toyamarinyon Could you please look into this when you have time? https://github.com/giselles-ai/giselle/pull/150#issuecomment-2510756207

I don't remember cancelling. I'll re-run it.

@toyamarinyon
After clicking the "Generate" button on the "Text Generator" node, I encountered the error "Error: Node not found."
Am I correct in understanding that this part of the implementation has not yet been completed?

@shige We are creating a separate process to save the data, so until that is done, it will be an error.
I should have written this down first. Sorry.


Value preview for a range with step 0 shows error "Can't convert a range with size zero to a list"

It should say something like "Continuous interval from start to end"

In fact, ranges shouldn't be converted to lists at all.


fix(forms): Better match current forms

The buttons for the stepper component were originally set to match the
upcoming form element design. This brings them back into the present.
I double-checked with Jerry on this to make sure these are where he would go with it as well.

Makes sense to me.


Aggregate rules and refactor rules structure

The rules structure for the Csv-Blueprint project is reorganized in this change, to better differentiate between "Cell Rules" and "Aggregate Rules". With this change, all former rules are moved into a dedicated rules folder, highlighting their specific focus. This structural change improves the readability of the project and facilitates future additions to the cell rules or aggregate rules.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 6 (83.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 95.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/AbstarctRule.php
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
670

Relevant Lines:
703

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 6 (83.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 95.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/AbstarctRule.php
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
670

Relevant Lines:
703

💛  - Coveralls


Serializer should be able to specify serializer class.

Currently, the only way to specify what class to use for when serializing a relationship is to give the renderer the class option with a hash with an entry for each serialized resource.
In fast_jsonapi it is possible to specify that for each relationship in the serializer. Sadly, they have no support for polymorphic relationships and doesn't seem to get support for that anytime soon. That
a: It allows specific different views of the same thing, which allow the database layout to be more decoupled from the jsonapi presentation.
b: For users that doesn't think the default lookup path and naming for serializers are good enough, it allows them to not have to repeat every single serializer every single time they have to serialize something.
c: It allows more than one view of the same type of object in the same serialized response.
So I think it would be extremely nice if it was a feature that was supported.

c: It allows more than one view of the same type of object in the same serialized response.

One issue is that it actually allows more than one view of the exact same object. Which one should be in the response document then?

My spontaneous reaction is, if specified on a relationship, use the serializer. Otherwise use the current logic.
Yes, this means an object could be included multiple times, if it has multiple representations that are different but included different ways. I'm not certain if that is a feature or a problem. I suppose it may make the implementation a bit more complicated, though I haven't checked to verify.
I suppose it also would also allow the inclusion of a parent of a node in a tree structure without having to render all parents.

(and FWIW, I think it should be an error if two candidate serializers produce the same value in the type field in the output).

The rationale behind this choice (one serializer per type) is twofold:

perfs: each object is serialized only once (the resources graph is first traversed, and then all resources are serialized),
clarity: the "serializer defined on relationship" yielded much confusion in AMS as people wouldn't know which serializer was being used and why.

Regarding

a: It allows specific different views of the same thing, which allow the database layout to be more decoupled from the jsonapi presentation.

For that you can have different serializers. You should probably not have different views of the same thing within a given document.

b: For users that doesn't think the default lookup path and naming for serializers are good enough, it allows them to not have to repeat every single serializer every single time they have to serialize something.

One can simply define it once, and possibly write a wrapper (which is what jsonapi-rails does).

c: It allows more than one view of the same type of object in the same serialized response.

That should be avoided IMO.
Sorry for not elaborating more, but I'm quite busy at the moment. Maybe @dawidof has an other opinion?


Allow TypeScript in Snacks (and optional "ext" parameter)

This makes a couple changes in preparation for TypeScript examples. Going through 20 pages for core components, most examples can be shifted to be both JavaScript and strict TypeScript. Some are not compatible as both, and need to be separated as JS examples vs TS examples.
Add parameter to SnackPlayer blocks
Snack defaults a code block to represent a file named App.js. This extension effects how the file is parsed during bundling, and the syntax highlighting it is given in the editor. We allow passing the extension, so that specific examples can specifically target JS vs TS. This directive will later be used to determine how the file is used during linting.
Change default example extension to .tsx
This is needed for Snack to parse an input as TypeScript during bundling and syntax highlighting. Vanilla JS is still allowed, and it seems to create an identical result to before in the snack player.

This is causing an issue, where the Snack loads on first page visit, but not when switching page.

This is causing an issue, where the Snack loads on first page visit, but not when switching page.

This is due to a bug in SnackPlayer. Submitted a fix with https://github.com/expo/snack/pull/361, but added a workaround in the meantime.

https://github.com/expo/snack/pull/361 was deployed, and examples on switching works correctly now without the workaround 👍. Removed the the empty data-snack-code.


Coroutine local variables

Now in Coio, Coroutine is the minimum execution routine. It would be nice if we can have a coroutine_local! macro implementation just like thread_local! in std.
Implementation detail will be discussed later.

Just to note:

If someone accesses to the variable without running Coroutine, it should panic or not? If not, what's the expected behavior?


Fix formatting in pull_request_template.md

There was an unclosed comment in the pull request template under the 'closed' text. This unclosed comment ended up commenting out everything underneath it.

Thank you!


Defect: CMake can't find mpiexec if not in PATH

Avg response time

[X] I have surrounded any code, or log output in codeblock fences
(```) if it occupies more than one line, or in single
backticks if it is short short code

Defect/bug report
With the current master branch (OpenCoarrays 1.8.5) and MPICH 3.1.4, although though [line 27] in the build_opencoarrays.sh script sets the CC and FC environment variables and passes the MPI_C_COMPILER and MPI_Fortran_COMPILER arguments, CMake reports that it can't find mpiexec (despite finding mpif90)) unless mpiexec is in the PATH:
CC="${CC}" FC="${FC}" $CMAKE "${opencoarrays_src_dir}" \
  -DCMAKE_INSTALL_PREFIX="${install_path}" \
  -DMPI_C_COMPILER="${MPICC}" \
  -DMPI_Fortran_COMPILER="${MPIFC}"

The above behavior happens with our default CMake 3.4.0.  I'm investigating whether updating to a newer CMake version would resolve this or whether we simply need to set add the MPICH bin directory to the PATH before the above statement executes (which seems like overkill).   Depending on the outcome of my investigations, I'll either edit the build_opencoarrays.sh script to adjust the PATH before the above statement executes or I'll bump the minimum CMake version number.  I'll also look into bumping the MPICH version number as requested in issue #355.

The title of the issue should start with Defect: followed by a
succinct title.

[ ] I have searched the issues page and mailing list and did
not find any issue matching the one I would like to report
[X] I have included a succinct description of the problem,
including the steps necessary to reproduce it
[X] I have included which version of OpenCoarrays I am working
with, or the output of git describe if working with a cloned
repository rather than an official release
[X] I have included the MPI library name and version I am using
with OpenCoarrays

[ ] name: MPICH version: 3.1.4

[X] I have included the Fortran compiler name and version that I am
using with OpenCoarrays: 7.0.1
[ ] I have included the output of uname -a:
Linux rouson-VirtualBox 4.8.0-22-generic #24-Ubuntu SMP Sat Oct 8 09:15:00 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
[X] I have included the Operating system name and version,
including linux distro: Lunbuntu 16.10
[X] I have included the machine name if I am allowed to do so and
wish to seek help debugging on that particular system (Titan,
Pleiades, Excalibur, Lightening, Mira, etc.): MacBook Pro

Installation/build problem
Please select one from the following top level items (please be sure to fill out all sub-items):

[X] Build/install was attempted with install.sh

[ ] I have attached the install-opencoarrays.log file
after re-running the script with the debug flags -d and
-v turned on (after renaming the log file to have a .txt
extension)

[ ] Build/install was attempted with system package manager like
homebrew (which one?)
[ ] Build/install was attempted with manual/advanced
CMake install

[X] Name and version of the C compiler being used: gcc

[X] Name and version of the Fortran compiler being used: gfortran
[X] Attached/included the output of the configure step with
CMake. (Usually something like cd build && cmake ..):  see above
[ ] Attached/included the output of make VERBOSE=1
[ ] Attached/included the output of ctest --verbose

[X] Other build/install was attempted (please describe): macOS build under way

Compile time or run time error

Please choose one of the first two items

[X] I am experiencing a compile time error (all gfortran ICEs
should be reported to the GFortran bug tracker... You can post
the ICE here too for tracking purposes, with a link to the
GFortran problem report)
[ ] I am experiencing a runtime issue

:sparkles: Optional, but you will receive infinite karma for including this: :sparkles:

[X] I have included a minimally complete verifiable example (MCVE)
that exhibits the problem and suitable for adding to regression
tests: the example is the new patched-trunk-install.sh script.

I've now confirmed this behavior happens with a much more recent version of CMake (3.7.1) and with a slightly older version of gfortran (6.2.0) installed by package management (whereas the gfortran installation in the initial report was installed by the OpenCoarrays installer). This appears to be general and longstanding behavior of CMake.

And similar behavior happens on macOS.  With the following, CMake finds the mpiexec in the PATH rather than the one in the location of the specified compilers:
CC="/Users/rouson/Code/opencoarrays/prerequisites/installations/gcc/trunk/bin/gcc" \
FC="/Users/rouson/Code/opencoarrays/prerequisites/installations/gcc/trunk/bin/gfortran" \
cmake "/Users/rouson/Code/opencoarrays" \
-DCMAKE_INSTALL_PREFIX="/Users/rouson/Code/opencoarrays/prerequisites/installations/" \
-DMPI_C_COMPILER="/Users/rouson/Code/opencoarrays/prerequisites/installations/mpich/3.1.4/bin/mpicc" \
-DMPI_Fortran_COMPILER="/Users/rouson/Code/opencoarrays/prerequisites/installations/mpich/3.1.4/bin/mpif90"

Hi Damian (@rouson),
So is this issue occurring when using install.sh, or with manual invocation of cmake?
If you're manually invoking CMake, perhaps a better thing to try, before jumping to -DMPI_C_COMPILER and -DMPI_Fortran_COMPILER would be setting your MPI_HOME variable in the environment, or ensuring that the MPI you wish to use is first on your PATH.
Unless this is a problem when using install.sh, then I think this can be tagged as an upstream, CMake issue and closed as "won't fix" since the issue surrounds CMake's behavior and our manually invocation can be adjusted accordingly.
If this issue is arising with install.sh then I'll take a look and try to find a better way to tell CMake which MPI implementation to use.

The same behavior occurs when I invoke CMake directly so I think you're correct that this is upstream.  I see that you assigned this issue to yourself so I'll let you close it and mark it as "won't fix."  I'm working on a simple reproducer for CMake.

I have the reproducer now.  I'll report it to Kitware later this morning.

Oh, but it happens when the install.sh script is used as well? In that case we should look into a way to work around this or at least produce more consistent behavior.

also, would you mind sharing your reproducer? That will help me understand the expected vs observed behavior

On second thought, let's keep this open until we have a workaround in place.  I think the workaround, as you suggested, is to put the desired MPI installation in the PATH before invoking CMake.  I'll submit the issue to CMake today and then will submit a pull request with the workaround unless you'd like to do so before I get to it.  It will be a few hours before I get to it.  I'll attach the reproducer to my next comment.

Here's the reproducer that I'll submit to Kitware later today: cmake-issue.zip
And here's the included README file:
CMake Issue Reproducer: MPIEXEC not found even if arguments specify MPI compiler locations
Issue demonstration
To demonstrate the issue, execute the following at the command line in a bash shell:
cd cmake-issue
./cmake-issue.sh

which takes about 6 minutes to run inside a Lubuntu Linux virtual machine given access to all four cores on a 2017 MacBook Pro laptop.  Near the bottom of the output is the message that represents the issue:
-- MPIEXEC=MPIEXEC-NOTFOUND
Sample output
Included in this archive is the output file cmake-issue.log from executing
time ./cmake-issue.sh >& cmake-issue.log

in a bash shell inside a nearly bare Lubuntu Linux virtual machine with GCC 6.2 and CMake 3.5.2 installed.  Previous tests indicate that the same behavior is obtained with CMake 3.4.0 and 3.7.1 and the same behavior is observed on macOS Sierra.

This is now CMake issue 16804.

I'll submit a pull request shortly that contains a commit that works around this CMake issue. I'll attempt to close the pull request via the commit message.

I'll attempt to close the pull request via the commit message.

you mean close the issue via the pull request commit comment, I presume...
Just wondering, what is going to be you're approach? Setting PATH in the script? If you do that, I would recommend restoring the users old PATH after the install finishes, or else people may install it, test it, and then later have path issues... at least until #268 is done.... yeah I have a huge backlog to look  at.  Might find time today.

Perhaps more evidence that I need to adjust the issue/pr templates to make them clearer and more concise:

I'll attempt to close the pull request via the commit message.

It doesn't really matter if the issue is closed through the comment, the most important part is that the commit message mentions the issues. This way a link is produced on the issue page to the commit and a link in the commit is created to the issue page.
One less important, but still useful property of closing via the commit message is that the issue being open indicates that the fix is not on master yet. If you create a commit on a branch closing the issue, the issue gets closed when merged back into master.


angular-meteor 1.3.5 log in

After upgrading to 1.3.5 I got some problems with the current user.
Just after log in I do a state.go and the state is running some subscriptions but as they need the current user in server side to protect the data I got no result.
I need to refresh the page to get the datas which is not very convenient but sometimes it doesn't work...
The tricky part was when the state's controller was loading I printed the current user ID on the client to see what was happening and it was not undefined!
I got no problems at all with 1.3.4

+1

I've experienced a very similar thing. If i do the normal flow, login -> redirect to other page -> and then ask for Meteor.user() or Meteor.userId() it usually works.  But when i'm doing testing on that page where the page gets refreshed a lot, those methods don't work.  I realize I'm just testing...but its not that far fetched that a user would just do a simple refresh on that page, which would break some things.
+1

+1

@ThomsC Can you provide a repository for reproduction?

dunno if the problem is the same, but I've the issue even in tutorial app
$ git clone https://github.com/Urigo/meteor-angular-socially.git
Cloning into 'meteor-angular-socially'...
remote: Counting objects: 1367, done.
remote: Total 1367 (delta 0), reused 0 (delta 0), pack-reused 1367
Receiving objects: 100% (1367/1367), 148.30 KiB | 0 bytes/s, done.
Resolving deltas: 100% (616/616), done.
Checking connectivity... done.
$ cd meteor-angular-socially/
$ git checkout step_20
(...)
$ meteor

Use case:

register
create at least one private party
logout
login (it should redirect you to /parties page)

works perfect. Now update things.
$ meteor update
This project is already at Meteor 1.2.1, the latest release.

Changes to your project's package version selections from updating package versions:

angular                               upgraded from 1.3.1 to 1.3.5
angular-meteor-data                   upgraded from 0.0.8 to 0.1.0
angularui:angular-google-maps         upgraded from 2.2.1 to 2.3.0
pbastowski:angular-babel              upgraded from 1.0.7 to 1.0.9
planettraining:material-design-icons  upgraded from 2.0.0 to 2.1.1
stevezhu:lodash*                      upgraded from 1.0.2 to 3.5.0_3
tmeasday:publish-counts               upgraded from 0.7.2 to 0.7.3

* These packages have been updated to new versions that are not backwards
compatible.

The following top-level dependencies were not updated to the very latest version available:
 * angular:angular-material 0.11.4 (1.0.3 is available)

Newer versions of the following indirect dependencies are available:
 * dburles:mongo-collection-instances 0.3.4 (0.3.5 is available)
 * lai:collection-extensions 0.1.4 (0.2.1_1 is available)
 * nmccready:angular-simple-logger 0.0.4 (0.1.7 is available)
 * stevezhu:lodash 3.5.0_3 (4.0.0 is available)
To update one or more of these packages, pass their names to `meteor update`.

ok, now do the same:

register
create at least one private party
logout
login again (it should redirect you to /parties page)
on /parties page there is NO party at all (even public ones). I could see them only after refresh

From Meteor DDP Monitor (just login at /login page):
calling method login with [object Object] "{"msg":"method","method":"login"," ... } 12:01:53
item added to users collection "{"msg":"added","collection":"users" ... } 12:01:54
subscription ready for undefined "{"msg":"ready","subs":["DE9BvTjeHCtG ... } 12:01:54
updated "{"msg":"updated","methods":["1"]}" 12:01:54
got result for method login "{"msg":"result","id":"1","result" ... } 12:01:54
subscribing to images with  "{"msg":"sub","id":"iLPZzQmwen8XnkPDk ... } 12:01:54
subscribing to users with  "{"msg":"sub","id":"WZ5bneo4WRY25Asxi ... } 12:01:54
subscribing to parties with [object Object],  "{"msg":"sub","id":"FeaHcXrqeXLjd44tK ... } 12:01:54
unsub "{"msg":"unsub","id":"iLPZzQmwen8XnkPDk"}" 12:01:54
unsub "{"msg":"unsub","id":"WZ5bneo4WRY25Asxi"}" 12:01:54
unsub "{"msg":"unsub","id":"FeaHcXrqeXLjd44tK"}" 12:01:54
item added to cfs.images.filerecord collection "{"msg":"added","collection":"cfs.ima ... } 12:01:54
subscription ready for images "{"msg":"ready","subs":["iLPZzQmwen8X ... } 12:01:54
subscription ready for users "{"msg":"ready","subs":["WZ5bneo4WRY2 ... } 12:01:54
item added to counts collection "{"msg":"added","collection":"counts\ ... } 12:01:54
item added to parties collection "{"msg":"added","collection":"parties ... } 12:01:54
subscription ready for parties "{"msg":"ready","subs":["FeaHcXrqeXLj ... } 12:01:54
item removed from cfs.images.filerecord collection "{"msg":"removed","collection":"cfs.i ... } 12:01:54
nosub "{"msg":"nosub","id":"iLPZzQmwen8XnkPDk"}" 12:01:54
nosub "{"msg":"nosub","id":"WZ5bneo4WRY25Asxi"}" 12:01:54
item removed from counts collection "{"msg":"removed","collection":"count ... } 12:01:54
item removed from parties collection "{"msg":"removed","collection":"parti ... } 12:01:54
nosub "{"msg":"nosub","id":"FeaHcXrqeXLjd44tK"}"

What am I discovered is, when you set up timeout (ie. 200ms) on $state.go() at<EMAIL_ADDRESS>it will work correctly...

@ThomsC Could you look into developer tools (Network tab in Chrome) and check websocket connection?
Make a quick scan, check if there is SUB action for proper subscription (exactly the same as you mentioned, that one with this.userId condition.

@kusmierz I think a little workaround for that would be wrapping this.subscribe() in $timeout.
Could you say if it solves a problem?

@kamilkisiela I didn't have to logout and login. I registered, created a private party and it didn't show up. Can you check if register and create a private party works for you (after update).

@ozsay Ok, i'm going to look at it in a moment.

@ozsay Doesn't work.

It looks like in the newer version there are alot of unsub messages to the server. Will check what is going on

@ozsay I'm currently looking into it. I can't work right now because of it :)
Tracker computation of subscription is invalidated and i'm seeking the reason.

@ozsay Subscriptions work fine but only when there is no cursor in helpers.
Something like this won't work.
this.subscribe(...);
this.helpers({
  items() { return Items.find(); }
});

But this will.
this.subscribe(...);

+1 looking forward for solution.
Should I switch back to 0.0.9?

I switched back to 0.0.9 and it works fine
pt., 29.01.2016, 13:18 pacozaa użytkownik<EMAIL_ADDRESS>napisał:

+1 looking forward for solution.
Should I switch back to 0.0.9?
—
Reply to this email directly or view it on GitHub
https://github.com/Urigo/angular-meteor/issues/1108#issuecomment-176727165
.

@kamilkisiela I don't have angular-meteor-data package. so which one I should switch back?

@kusmierz  I follow your instruction
   setTimeout(function(){                $state.go('somestate');              }, 200);
and it works fine!

@kamilkisiela @pacozaa @ThomsC @burock
The issues with socially seems to be fixed with 1.3.6.
Can you test it in your projects to see if any other issues raise?
we haven't published it yet so you'll need to run it locally (I explained it here).
Thanks

<EMAIL_ADDRESS>was released.
Please check and let me know if that fixed the issue.

It is not fixed.
Just after loggin I get no data from any subscriptions. But I can go inside the application.
When I try to go to an other page and check in the resolve if there is a user. This function get call every time. So I can't move in my application. Always redirect me in the loggin page..
function stateChange($rootScope, $state, $stateParams, $meteor, blockSettings, blockMenu) {

        $rootScope.$on('$stateChangeError', function (event, toState, toParams, fromState, fromParams, error) {
            if (error === "AUTH_REQUIRED") {
                console.log('No user');
                $state.go(blockSettings.pageLogin);
            }
        });
    }

I can't share a repo as if it's a company application... Go back to 1.3.4

@ThomsC what version of the angular-meteor-auth package are you using?

also, can you show me your routes file?

I did a meteor update so I had everything to the last version I suppose.
Here is the type of subscription I use juste after loggin which doesn't work with 1.3.6 :
        this.subscribe('userInfo');

        this.helpers({
            userInfo: () => {
                return UsersInfos.findOne({owner_id:Meteor.userId()});
            }
        });

I've juste check the documentation http://www.angular-meteor.com/api/1.3.6/auth
For now I use $auth.requireUser() but maybe I should rewrite it
resolve: {
                    user: ['$auth', '$state', 'blockSettings', function ($auth, $state, blockSettings) {
                        return $auth.requireUser().then(function (user) {
                            if(user){
                                if (!Roles.userIsInRole(Meteor.userId(), ['user', 'sub-user'])){
                                    Meteor.logout();
                                    console.log('user as no rights');
                                    $state.go(blockSettings.pageLogin);
                                }
                                else {
                                    return user;
                                }
                            }
                        });
                    }]
                }

I prefer to use resolve to check if an user has any right instead of doing it in the controller. Is it still possible to do it? Can we still use $auth.requireUser() ?

meteor update is not enough yet because the version is still in beta.
you should do meteor update<EMAIL_ADDRESS>in order to use the new version.
some with angular-meteor-auth - meteor update<EMAIL_ADDRESS>About using un the resolve yes you can still do that and I should add it to the docs - just use $$Auth.$awaitUser
also, please provide your routes file, I think there might be a mistake there

What part exactly are you interested in the routes file?
Because I don't have one config.route.js file I use the John papa guide so I have multiple files.
Ok I'll redo a test with your recommandation.
And what about the subscription ?

I'm interesting in the Login route definition.
the subscription should work, isn't it?

With 1.3.4 the subscription works not with 1.3.6
Here is a part of my route file with the abstract route then every other route use the resolve method I show before.
(function () {
    'use strict';

    angular
        .module('app')
        .config(moduleConfigLayoutDashboard)
        .run(stateChange);

    stateChange.$inject = ['$rootScope', '$state', '$stateParams', '$meteor', 'blockSettings', 'blockMenu'];

    function stateChange($rootScope, $state, $stateParams, $meteor, blockSettings, blockMenu) {

        $rootScope.$on('$stateChangeError', function (event, toState, toParams, fromState, fromParams, error) {
            if (error === "AUTH_REQUIRED") {
                console.log('Utilisateur absent');
                $state.go(blockSettings.pageLogin);
            }
        });
    }

    moduleConfigLayoutDashboard.$inject = ['$stateProvider'];

    function moduleConfigLayoutDashboard($stateProvider) {

        $stateProvider
            .state('dashboard-default.premium', {
                abstract: true,
                views: {
                    sidebarLeft: {
                        templateUrl: 'client/app/Application/blocks/components/menu/menu.ng.html',
                        controller: 'MenuController',
                        controllerAs: 'vm'
                    },
                    toolbar: {
                        templateUrl: 'client/app/Application/blocks/components/toolbar/toolbar.ng.html',
                        controller: 'DefaultToolbarController',
                        controllerAs: 'vm'
                    },
                    sidebarRight: {
                        templateUrl: 'client/app/Application/blocks/components/notifications-panel/notifications-panel.ng.html',
                        controller: 'blockNotificationsPanelController',
                        controllerAs: 'vm'
                    },
                    content: {
                        template: '

'
                    },
                    below: {
                        templateUrl: 'client/app/Application/blocks/layouts/dashboard/dashboard-default/below-content.ng.html'
                    }
                },
                resolve: {
                    user: ['$auth', function($auth) {
                        return $auth.requireUser();
                    }]
                }
            })
            .state('authentification', {
                abstract: true,
                templateUrl: 'client/app/Application/blocks/layouts/authentification/authentification.ng.html'
            });
    };

})();

yes thank you.
let's try to solve one problem at the time.
Can you create a simple reproduction to each problem?:

subscription doesn't work
All routes resolves with $stateChangeError, even when you are logged in
Am I missing a scenario?

@kamilkisiela is your use case works with 1.3.6-beta.1?

Ok I'm sorry when I see this line<EMAIL_ADDRESS>was released. I thought meteor update would be enough but it's not... I was not using the good packages...
No you are not missing a scenario.
But wait probably a noob question but look
meteor update<EMAIL_ADDRESS>=> Errors while upgrading packages:

While selecting package versions:
error: Package names can only contain lowercase ASCII alphanumerics, dash, dot,
or colon, not "@"

...?

can you try going into the .meteor/packages files and change angular to<EMAIL_ADDRESS>

@Urigo I'm going to create repo with reproduction so expect it in a few minutes.

@Urigo
Here's reproduction.
https://github.com/kamilkisiela/angular-meteor-auth-repro/commits/master
Latest commit contains<EMAIL_ADDRESS>and everything work. :+1:
Second latest contains<EMAIL_ADDRESS>and you should see there is a problem with subscription. :-1:
Sorry for the mess but I'm short on time.

ok so here is my list of package
angular                             1.3.6-beta.1  Everything you need to use ...
angular-meteor-auth         0.2.0-beta.1  Angular-Meteor authenticati...

But when I try to test if everything work, all my $state.go() has no effect of routing anymore. so I'm block in the loggin page ... ???
I then type the URL like 'localhost/home' because even if the $state.go()doesn't work meteor as log me. Once the page is loaded I got a blank page, no messages  at all in the console.
So I'm wondering if there is some functions like $auth.requireUser that are obsolete in 1.3.6-beta.1 if so tell me because I need to rewrite everything to test it correctly.

@ThomsC could you try to create a separate simple repo that reproduce that scenario?
I believe that with something like that I can solve it very quickly

Hi,
I did upgrade to 1.3.6 beta, this time my subscriptions don't return anything at all.. They are actually pretty forward classic subscriptions, nothing special.
When I downgrade to 1.3.5, subscriptions work, but first time login there's no data (as what this topic is about), so I have to refresh the page.
When I downgrade to 1.3.4 all works great..
fyi,
thanks
burak.

@Urigo Ok I'll try to do it this week

@burock Can you provide a repo with your issue ?
Thanks

Sure, you can try it here
Thanks

@burock it's a whole application :), can you provide the scenario as well so I could reproduce it?

sure :) , sorry..
On Mon, Feb 15, 2016 at 11:58 AM, Oz Sayag<EMAIL_ADDRESS>wrote:

@burock https://github.com/burock it's a whole application :), can you
provide the scenario as well so I could reproduce it?
—
Reply to this email directly or view it on GitHub
https://github.com/Urigo/angular-meteor/issues/1108#issuecomment-184139955
.

I use<EMAIL_ADDRESS>and $state.go('collectionName'); working without settimeout(). So I think the issue was fixed.
For people who want to try don't use meteor update<EMAIL_ADDRESS>it will occur an error, but
use meteor remove angular then meteor add<EMAIL_ADDRESS>Thank you.

Great.
Angular Meteor 1.3.6 was just released.

Ok..
So I had to rewrite everything in to order to get things work.
I would be nice if you tell everybody somewhere that $auth.requireUser()doesn't work anymore. All my problems came because of that.
Could you also show us how to use this.$awaitUser() in the resolve cause as far as I know $scopecan't be use in the resolve so we can't write something like this `$reactive(this).attach($scope);``
Thanks

@ThomsC Can you see if the API docs is sufficient ? http://www.angular-meteor.com/api/1.3.6/auth
If not, can you tell us what do you think is missing and we will add it to the docs?
Thanks

Yes I checked it that why I asked an exemple on how to verify the user in the resolvepart of a route and not in the controller as it is demonstrate in the documentation

@ThomsC
awaitUser provides the same functionality as requireUser, it returns a promise that resolves when the user is logged in...
Actually it exactly like you used to do it with requireUser:
$stateProvider
    .state({
        template: '<my-component></my-component>',
        resolve: {
          user: ($auth) => {
            return $auth.awaitUser();
          }
        }
    });

Also, you can implement it your self, like in Socially:
https://github.com/Urigo/meteor-angular-socially/blob/master/client/routes.js#L14-L21

@dotansimha
This code doesn't work :

$stateProvider
    .state({
        template: '<my-component></my-component>',
        resolve: {
          user: ($auth) => {
            return $auth.awaitUser();
          }
        }
    });

this code works
currentUser: ($q) => {
                        if (Meteor.userId() == null) {
                            return $q.reject('AUTH_REQUIRED');
                        }
                        else {
                            return $q.resolve();
                        }
                    }

But I was hopping something like

$stateProvider
    .state({
        template: '<my-component></my-component>',
        resolve: {
          user: ($auth) => {
            return $auth.awaitUser().then((user)=>{
            // do some test on the user
            });
          }
        }
    });

Hi everyone and @ThomsC, important note here.


How to restore session from token of cookies

Hello.
I have external login/logout html pages, which create cookie token if user is authenticated, not user data, only token.
I created authenticators/appication.js file which has all needs methods (restore, authenticate, invalidate) and I understand how they should work. Authenticate method do redirect to login external page and invalidate method do redirect to logout external page. Restore method shoul check if cookies has token, then load a user's data.
But I don't understand how can I init restore function in authenticator, if localStorage has only
ember_simple_auth:session -> {"authenticated":{}}

if I change it manually to
ember_simple_auth:session -> {"authenticated":{"authenticator":"authenticator:application"}}

it work fine
How can I set default authenticator if user isn't authenticated? Or what should I do?

Maybe my problem is related. This used to work, maybe it stopped working on Ember 2.10 (I was on 2.9)
My problem:
I'm logged succesfully via Facebook Connect.

Then I refresh my browser.
this.get('session.isAuthenticated') still returns TRUE
but the data doesn't contain the access_token etc anymore:

This is more suited for stackoverflow.com actually.


Added encoding='utf8' parameter

Added encoding='utf8' parameter to the open function located in read_dic function for special characters.
I've had a problem when I tried to classify texts with a translated LIWC Dictionary.
So when I try to parse this sentence "kabul terketmek naber yawru a asit kürtaj yapabilmek." it does not classify the word "kürtaj" because it contains "ü".
I solved this issue by adding the encoding parameter to the open function where it reads .dic file.

Hi, thanks for your interest in this project :) I'm not sure why explicitly specifying the encoding like that would change anything for you unless your default encoding is something other than UTF-8, in which case I'd recommend changing it to UTF-8.
import locale
locale.getpreferredencoding(False)
>>> 'UTF-8'

While admittedly sane, your change only locks users into a tighter assumption about the encoding of their .dic file, so I'm not going to merge it as-is, but I would accept a change adding the encoding and errors parameters from open(...) (with the same defaults, i.e., None) to the read_dic(...) function signature, which would then pass them through to open.

Hi, thanks for your interest in this project :) I'm not sure why explicitly specifying the encoding like that would change anything for you unless your default encoding is something other than UTF-8, in which case I'd recommend changing it to UTF-8.
import locale
locale.getpreferredencoding(False)
>>> 'UTF-8'

While admittedly sane, your change only locks users into a tighter assumption about the encoding of their .dic file, so I'm not going to merge it as-is, but I would accept a change adding the encoding and errors parameters from open(...) (with the same defaults, i.e., None) to the read_dic(...) function signature, which would then pass them through to open.

Thanks for the quick reply, I tried to change my encoding to 'UTF-8' but it didn't solve my problem. And yes, I agree with you about your solution, disabling preferred encoding would be the best solution for your package. So, I'll close this pull request. Thanks again :)

Thanks for the quick reply, I tried to change my encoding to 'UTF-8' but it didn't solve my problem. And yes, I agree with you about your solution, disabling preferred encoding would be the best solution for your package. So, I'll close this pull request. Thanks again :)


Duplicated xws "blacksquadronace"

\data\pilots\galactic-empire\tie-ln-fighter.json line 125
\data\pilots\resistance\t-70-x-wing.json line 99

I could almost swear they weren't in conflict a few days ago. In any case, the solution is to change the t-70 to blacksquadronace-t70xwing


Change test store to raft writer, fix found problems

Change store to raft writer in mvcc test, fix two found problems

The applier command ops should follow input orders
eg:

(1) pessimistic lock one key using forUpdateTs1
(2) pessimistic the same lock using forUpdateTs2

Here the override (2) operation will add one rollback and one put,   but the applier did the prewrite(the put) first and then the rollback(the rollback), this lock will be deleted unintended

The minCommitTs is not encoded into put operation, so after decoding, the value is incorrect

The current make test all passed, maybe we need to port more cases to solid the basic path

@coocood @bobotu PTAL

Good job!
LGTM


feat(dynamic_avoidance): add debug marker for extracted polygon

Description
add a debug marker of the extracted polygon of dynamic avoidance
long ping rectangle covering the dynamic obstacle to avoid.

Tests performed

planning simulator
Effects on system behavior

No behavior change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 Could you approve the PR. Just adding a debug marker and no behavior change

@kosuke55 ping


Problems with the executables (fedora-review)

python3-packit.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/packit/cli/watch_sg_pr.py 644 /usr/bin/python3
python3-packit.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/packit/cli/watch_upstream_release.py 644 /usr/bin/python3

If the script has shebang, then it should be executable script by setting executable bit (and either be in /usr/bin/ or /usr/libexec) or when it does not have executable bit then it should not have shebang.

There is no "main" section in those files, the shebang should go away from both.

(this is a past relict when we used to run the files directly, fedora-review++)


add domain validation(simple domain names)

Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:

[x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Coverage increased (+0.005%) to 74.182% when pulling 2369657f8b0fe043c3eb9b4f3ea87e458d9d1e15 on aryehlev:master into 9e2ea4038020b5c7e3802a21cfa4e3afcfdcd276 on go-playground:master.

@aryehlev I'm hesitant to merge this only because full domain validation is much more complicated than this and don't want to give users a false sense of security.
if a more comprehensive validation can be added I'd be happy to merge.

This is the validation I use since I'd rather let some false negatives than false positives.
But I will try to research a more comprehensive validation and if I don't find one I will close this pr.
Thank you🙏