EnhancementDoris support obs broker load

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@liujinhui1994 Could you provide hadoop-huaweicloud-2.9.x , doris can't update hadoop to 2.9.1 beacuse this hadoop-huaweicloud only provide 2.8.3 in central repo.


lost command prompt window

I was going to select all of command prompt window and my mouse glitched out and closed prompt whatever i won is just lost now, I didn't get a notification. Is it a loss?

Unfortunately I don't know of a way to find won entries on Amazon. :( Did you enter a sendgrid api key? If so check your junk mail folder for an email that contains the winning entries url. Otherwise you might be out of luck, unless someone else has any ideas....

I am not exactly sure if there is a way to do that either.  If you did use the sendgrid option, I had to train Gmail to not put them in the Spam folder.
I think that I will integrate this type of thing into #74 so that the URLs for winning could possibly be stored.  Then when GG is restarted and it has been less than 24 hours since a winner has been found, it will dump out the winning URL before starting to navigate the Giveaway site.
I will put a note in that issue now so that it can be integrated as I work through the DB design.

Well that was pretty annoying so I started using the gg.log feature. I wrote a quick script in "autoit" that should read from the log and if it finds a winner it will open it in notepad "my default for .log".
If want to use this just change path to log in the script. I'm sure you guys will probably end up with better solution though lol.
checkwinner.zip


Add support for Python 3.10

it seems nose doesn't work with Python 3.10

Merged into upstream via squash merge, baking a new minor version with new Django and Python version support specifiers.


Change mask on the fly

Hello. I have the following use case where i need to change a text mask on the fly. Imagine a form with a checkbox named "Is Fractionable" and an input field that should take a numeric value of type:

integer if the "Is Fractionable" is not checked
float with two decimals if the "Is Fractionable" is checked
Can you please give me some hints on how I can accomplish this?

Thank you!

The createNumberMask should do what you want.  You can then toggle the allowDecimal property.
Hope that helps

I'm going to close this now.. but let us know if you need any more help with this.


Plugin "ARouter Helper" is incompatible (supported only in IntelliJ IDEA). 在mac上怎么解决？

Look at here

→ Did you read the doc carefully
→ Did you add annotation above target activity
→ Did you add annotation processor dependence
→ Receive only bugs and suggestions

提 issue 前请看

→ 你是否已经熟读 README ？
→ 你是否在每一个包含页面 or 服务的模块中依赖了 compiler sdk
→ 这里不是答疑的地方，仅接受 bug 和建议，答疑请去答疑群

同样的问题，目前已经对 AS 降级


ARROW-16824: [C++] Migrate VectorKernels to use ExecSpan, split out ChunkedArray execution

This is mostly mechanical refactoring. Since many VectorKernels support being passed in a ChunkedArray, I separated the ExecSpan code path (which does not support chunked arrays) from a separate VectorKernel::exec_chunked function which continues to use the const ExecBatch& input format.
Aggregate (scalar and hash) kernels will have to get refactored in a follow up PR. I was going to try to pack that into this branch but it got to be a little bit too much. I would like to work on ARROW-16757 next anyway which will help a lot with cleaning up a lot of accumulated cruft
I also removed the "scalar" input mode of "cumulative_sum" because the result was ill-defined per a separate discussion.

CI is passing — this Windows thread pool failure is weird though (cc @westonpace). I’m going to start working on the next stage of work but I’ll just stack the work on this PR in a branch while this PR is in review


Alt-key to flip dropdown should flip menu as well?

Testing #148070
This is probably a more generic UX issue, but when I press Alt to flip the dropdown, I cannot flip the entries in the dropdown, only the primary action:

Well, if I was implementing it from scratch I wouldn't have even added the alt action. The menu is far more discoverable. But the alt action was added first a while bad, and now people are used to it, so I kept it so people can still trigger the most common action with a single click. I don't think applying alt to the full dropdown menu would be that useful, do you?


Extract examples from new-style services

Instead of centralizing examples, specify them from within a service.

Warnings

:warning:

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

:warning:

This PR added helper modules in lib/ but not accompanying tests. Generally helper modules should have their own tests.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS

I'll will have a proper look at this one tomorrow

Nice! Thanks for continuing to work on this 😃


dnsperf doesn't reconnect in TCP mode

I am trying to use dnsperf (build on Fedora 24) against CoreDNS.
CoreDNS uses Miek Gieben dns library.
The library has limitation in 128 TCP packets (see listing), after reach that TCP session is closed.
So command
dnsperf -s <IP_ADDRESS> -p 53 -d dns.txt -Q 10000 -l 10 -z
failed with message
Warning: Error: cannot use connection: Connection reset by peer

Yeah, this error isn't currently handled correctly - there is a TODO in the code to fix this, so thanks for logging the issue.
As a workaround you can use the command line flag -Z to set the number of queries dnsperf sends on each connection so as long as this number is less than 128 then you shouldn't hit this issue.


Do we need the Contributor Over Time chart?

Hi, we have generated a chart of contributors over time, which may be helpful to you.
You can referer to:
https://contributor-graph-api.apiseven.com/contributors-svg?chart=contributorOverTime&repo=golang/go

Hi, that's a nice graph, but I don't think we need to put it on the website, repository statistics are better hosted externally (there are many website that will provide various stats given a public repository).

You may want to share this graph on a forum.  See https://golang.org/wiki/Questions.

Hi, that's a nice graph, but I don't think we need to put it on the website. Repository statistics are better hosted externally (there are many websites that will provide various stats given a public repository).

@ALTree @ianlancetaylor Thank you for your reply. I will share this graph on a forum. Haha.


enhance timeout

Use Client timeout instead of a custom timeout during file upload.

Coverage increased (+0.5%) to 47.398% when pulling 79570c0b553430d948c7cd27e820c0f3a940c467 on marcorosa:fix-sharder into 2229055d9faf634526f44477e8192e85425cf9a9 on Storj:develop.


avoid deprecated gtk_widget_size_request()

gtk_widget_size_request has been deprecated since GtkWidget version 3.0.
Avoids compiler warnings like:
wx_backports/wx_gtk_nativewin.cpp: In member function ‘bool xNativeWindow::Create(wxWindow*, wxWindowID, wxNativeWindowHandle)’: wx_backports/wx_gtk_nativewin.cpp:64:5: warning: ‘void gtk_widget_size_request(GtkWidget*, GtkRequisition*)’ is deprecated: Use 'gtk_widget_get_preferred_size' instead [-Wdeprecated-declarations] gtk_widget_size_request(widget, &req);

Travis CI build failed.
Distinction of cases for GTK+ 3 and GTK+ 2 required, will work on this ...

Quoting Travis build:
../../src/wx_backports/wx_gtk_nativewin.cpp: In member function ‘bool wxNativeWindow::Create(wxWindow*, wxWindowID, wxNativeWindowHandle)’:
../../src/wx_backports/wx_gtk_nativewin.cpp:64:53: error: ‘gtk_widget_get_preferred_size’ was not declared in this scope
     gtk_widget_get_preferred_size(widget, NULL, &req);

Per the documentation, the function is GTK+ 3.0 only. wx has compat shims to deal with this that are private, i.e. unavailable for Poedit code. So you either have to use #ifdefs or live with the warning. As the filename indicates, this is backported wx code that isn’t used when compiling with wxGTK 3.1 (which I strongly recommend if using GTK+ 3, as you seem to be), so the latter doesn’t seem unreasonable to me...

Added #ifdef __WXGTK3__

Here is some additional information, why to get rid of the compiler warning.
In Fedora Linux we have wxGTK3 version 3.0.2 at the moment. So, this is what Poedit is compiled with when creating the rpms.
https://apps.fedoraproject.org/packages/wxGTK3
Therefore not wxGTK 3.1 and my PR instead.


Removing old jupyter notebooks

This PR removes old jupyter notebooks that are not used.

Can't run the dash in the HyperParamDashDemo.ipynb notebook. Get the following error:
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-10-5604020065f3> in <module>()
----> 1 app.display_dash()

NameError: name 'app' is not defined

@jcarreira The error you mentioned has been fixed. I think I might have refactored code in cirrus without refactoring it in the notebook. Issue has since been fixed on my local branch. I will include it in this week's PR.


Add structured logging for TraceSendRecv TxSubmission objects

Although this PR is no longer related to #527, it still adds structured logging for TxSubmission at the protocol tracer level. So I've instead changed this back to logging at debug severity.

bors r+


Add Metagov integration management UI

This PR improves the UI for managing Metagov plugins. I'm calling them "integrations" in PolicyKit.
Things to note:

Users that don't have perm metagov.can_edit_metagov_config can see everything (EXCEPT the current config key-values, since they may contain API keys). However, when they try to enable/disable plugins it will be rejected. There's a lot more we could do with this in the future (like allow users to "propose" an action that enables a plugin).
Slack is not included in the dropdown for "Add integrations..." because we need full support for multi-platform comms before we can make this user experience clean (See https://github.com/amyxzhang/policykit/issues/384). Technically we could redirect users to auth Slack here and link the community, but the user would still need to log in and out to access "PolicyKit-for-discord" and "PolicyKit-for-slack." There are also some unhandled issues: (1) policykit hard-codes the oauth flow to redirect to /login, just need to update it to go to /main/settings when installingn to an existing comm, (2) metagov slack auth endpoint performs re-installation to existing community if one exists that already has slack plugin enabled with a matching team_id, which is NOT what we want when installing slack to an existing community. figure out a better workflow.

Really exciting!! This looks good.

one thing I forgot to mention - I'd like to eventually move this out of under the user account drop down, to on the community's home page, say above the feed, or as a dropdown/gear image next to the community's name.


Aggregated exceptions to one factory class

Created factory to throw common math exception as there was too much message duplication, simplified already created messages. (Maybe make sense to create custom math exception to separate it from type validations, and nan checks etc)

[X] Read the contribution guidelines for this project.
[X] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
[X] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

I don't see how this helps but that's just me.
I've experimented with this type of refactoring in the past and I've come to the conclusion that one
should leave the 'throw' statements where they are, this makes reading control flow easier, allows some static analysis tool, and IDEs to be less confused.

Math exceptions are pretty general and are duplicated everywhere. By aggregating them into one generic utill class we will have less code duplication and generified response for client.

Refactoring in the "throw" statement part is still a bad idea IMO. Having an exception factory is a separate issue.

I understand you for already existed clients new exception types can be a problem and regarding factory for now I think it makes sense


Kafka client module changes

We are currently using clonfluent-kafka-go as a module to access Kafka from the logic-core directory.
I tested the functionality to support a consumer group using multiple Kafka consumers, but it didn't work.

Currently, Kafka consumer instances are created and executed by multiple goroutines.
As a result of tracking the goroutine through runtime/trace, Kafka consumers were not executed in parallel.

it seemed to only work for one goroutine.

We will be reimplementing "logic-core/kafkaConsumer" by changing to a sarama that seems to support consumer groups.

This kafka client module seems to only support Apache Kafka.

G24(hot pink bar is kafkaConsumer goroutine)

The number of kafka consumers is 1 application, so it acts as 1 goroutine.
Send indexing request to sensor data in batch processing.

the performance improved by about 7.5 times due to the batch processing.
On the tested computer, Kafka, sensor registration api server, data logic api server, and several other apps are running.
In this state, the data logic server processed 1500 sensor data per second.


fix: iOS camera permission not working

Hello,
Since the migration to the new architecture, the iOS' camera permission doesn't work.
The previous code called in the Podfile of smooth_app is now also called in the app module.
Will fix #3161

Codecov Report

Merging #3191 (e6d20a4) into develop (d5338cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3191   +/-   ##
=======================================
  Coverage     6.17%   6.17%
=======================================
  Files          252     252
  Lines        12495   12495
=======================================
  Hits           772     772
  Misses       11723   11723

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to install everything

so i know its kinda a dumb question but how do i install it? please help me bc i really need this to work lmao

It's alright! After installing python, you can use pip install discord-ext-forms.


Function names renaming reports?

I would like to generate a unmangled:mangled name mapping file specifying what functions Closure minified. Is there a way to generate a renaming report of function names?
If I pass the documented --property-renaming-report flag, I can get a file with property renames:
ABORT:J
ENVIRONMENT_IS_NODE:t
ENVIRONMENT_IS_SHELL:u
ENVIRONMENT_IS_WEB:q
ENVIRONMENT_IS_WORKER:r
ExitStatus:D
HEAP32:M
HEAPU8:L
INITIAL_INITIAL_MEMORY:N
...

and so on.
If I pass the documented --variable_renaming_report flag, I get a similar file with variable renames.
If I pass the undocumented flag --create_renaming_reports=true, that seems to enable both of the above.
If I do --create_source_map output.map, I can get a source map, that does contain the renaming info. However source writing a source map loader to is quite a complicated task, I think I would need to write a JS AST parser to be able to walk the mappings back to the unmapped names.
I wonder if there would exist a flag to achieve function renaming reports already, perhaps I am missing something?

I'm unclear what you are looking for that isn't provided.  For example, what is different from what you would like to see than what is provided by the "variable renaming report".  It might be helpful, if you stated why you wanted the information.

The information that variable renaming report provides seems to be somehow partial. It does not contain all renamed functions or variables, not sure what is the common denominator of what's not there.
That all being said, I ended up going the way of writing an AST parser to extract the information via source maps, so can close this.


The Postgres implementation requires stream IDs to be valid UUID implicitly.

Since we are using uuid-ossp extension in the Postgres adapter here, stream IDs that are not valid UUIDs will not be accepted.
Currently, the API does not enforce that UUID requirement which causes a bit of confusion.
Proposal:
We could relax the requirement and allow users to use the ID of their choice.
@kamy22, could you please share the error you have faced when trying to use a custom stream ID?

Sure, this is the error: error retrieving rows for events: pq: invalid input syntax for type uuid: \"df0b5eb35fc94a9f0c41ec347793659a8304aad6\""

The streamID as UUID is a big limitation because sometimes a hash of something could be a good streamID and it is impossible to use it if the library forces to use only valid UUIDs.

Good point, we should rework it into varchar 👍

I submitted a PR: @m110 @krzysztofreczek https://github.com/ThreeDotsLabs/esja/pull/35/files

Thanks, @kamy22, well done!

Merged


module 'nacl.bindings' has no attribute 'crypto_core_ed25519_add'

I'm getting this error
File "/home/username/.local/lib/python3.8/site-packages/monero/ed25519.py", line 4, in
edwards_add = nacl.bindings.crypto_core_ed25519_add
AttributeError: module 'nacl.bindings' has no attribute 'crypto_core_ed25519_add'

Could you please paste the output of what the command pip freeze outputs?
Or, at least, pip freeze | grep -i nacl?


If user has chain name use it at prejoin screen as username

Use not only ak_adress as a display name
https://github.com/aeternity/jwt-auth/blob/2818bf96da2015c9bdb56f0fdac8f6b732aa62a6/srv/index.js#L72

But it appears already working this way. What could be the problem?

@venimus I found what the issue. It's at jwt-auth repo side. So if user have only one chain name the address will be used.

@venimus I guess that will fix this issue https://github.com/aeternity/jwt-auth/pull/14


rke2 cluster cannot set coredns corefile correctly.

I want to add a nameserver for some domains for my cluster, e.g. I want my coredns corefile to be like below:
.:53 {
        errors
        health
        kubernetes cluster.local in-addr.arpa ip6.arpa {
           pods insecure
           fallthrough in-addr.arpa ip6.arpa
        }
        prometheus :9153
        forward . <IP_ADDRESS>
        cache 30
        loop
        reload
        loadbalance
    }
    example.org:53 { #adding a block here
        errors
        cache 30
        forward . <IP_ADDRESS>
    }

So I set my helm chart values to be like:
 servers:
    - zones:
      - zone: .
      plugins:
      port: 53
      plugins:
      - name: errors
      - name: health
        configBlock: |-
          lameduck 5s
      - name: ready
      - name: kubernetes
        parameters: cluster.local in-addr.arpa ip6.arpa
        configBlock: |-
          pods insecure
          fallthrough in-addr.arpa ip6.arpa
          ttl 30
      - name: prometheus
        parameters: <IP_ADDRESS>:9153
      - name: forward
        parameters: . /etc/resolv.conf
      - name: cache
        parameters: 30
      - name: loop
      - name: reload
      - name: loadbalance
    - zones:
      - zone: example.org
      plugins:
      - name: errors
      - name: forward
        parameters: . <IP_ADDRESS>
      - name: cache
        parameters: 30

And in rke2 cluster, these settings should be put under /var/lib/rancher/rke2/server/manifests/rke2-coredns-config.yaml.
However, these configuration cannot take effect. I wonder if I am doing wrong to set multiple nameservers?

Not sure I understand what you're trying to achieve, you installed the chart but require that the coredns config be on a specific path on the host file system?


Liquibase has problem with multiple classloader Cannot find default log service error

Environment
Liquibase Version:
3.19.0
Liquibase Integration & Version:
3.190
Operating System Type & Version:
Ubuntu 20.04
Infrastructure Type/Provider:
VM
Description
   public static void main(String[] args) {
        try (Connection conn = DriverManager.getConnection(
                "jdbc:postgresql://ha-ds.zextras.test:5432/ha", "ha", "ha")) {

            if (conn != null) {
                System.out.println("Connected to the database!");
            } else {
                System.out.println("Failed to make connection!");
            }
            Map<String, Object> config = new HashMap<>();
            Scope.child(config, () -> {
                Database database = DatabaseFactory
                        .getInstance()
                        .findCorrectDatabaseImplementation(new JdbcConnection(conn));
                try (Liquibase liquibase = new Liquibase("changelog.xml", new ClassLoaderResourceAccessor(), database)) {
                    liquibase.update(new Contexts(), new LabelExpression());
                }
            });
        } catch (SQLException e) {
            System.err.format("SQL State: %s\n%s", e.getSQLState(), e.getMessage());
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

Code causes Cannot find default log service error when run jdk17
liquibase.exception.UnexpectedLiquibaseException: Cannot find default log service
	at liquibase.Scope.getCurrentScope(Scope.java:87)
	at liquibase.Scope.enter(Scope.java:213)
	at liquibase.Scope.child(Scope.java:186)
	at liquibase.Scope.child(Scope.java:179)
	at liquibase.Scope.child(Scope.java:158)
	at org.example.Main.main(Main.java:31)

Steps To Reproduce
Code causes Cannot find default log service error when run jdk17

If there are multiple classloader then this occurs. Can not be reproduced easily.
At line https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/servicelocator/StandardServiceLocator.java#L21
ServiceLoader.load(interfaceType, interfaceType.getClassLoader()) should be also checked

I created Pull request https://github.com/liquibase/liquibase/pull/3820

@sonersivri I can reproduce this issue easily. All you have to do is set up liquibase as a Java-EE war and  pack into EAR Module . Afterward try to deploy into Jboss.

Hi @sonersivri,
We've been trying to reproduce this issue by using code the main method shared in this issue using a custom classloader, but it didn't work.
Environment:
Liquibase Version:
4.19.0

Liquibase Integration & Version:
4.19.0

Operating System Type & Version:
macOS Ventura 13.1

public static void main(String[] args) throws ClassNotFoundException, InstantiationException, IllegalAccessException {
        System.out.println("Liquibase version: " + LiquibaseUtil.getBuildVersion());
//        CustomLoader customLoader = new CustomLoader(Test.class.getClassLoader());
//        Class clas = customLoader.loadClass("liquibase.resource.ClassLoaderResourceAccessor");
//        Object o = clas.newInstance();
        try (Connection conn = DriverManager.getConnection(
                     "jdbc:postgresql://localhost:5438/lbcat", "postgres", "LbRootPass1")) {

            if (conn != null) {
                System.out.println("Connected to the database!");
            } else {
                System.out.println("Failed to make connection!");
            }
            Map<String, Object> config = new HashMap<>();
            Scope.child(config, () -> {
                CustomLoader customLoader2 = new CustomLoader(Test.class.getClassLoader());
                Class clas2 = customLoader2.loadClass("liquibase.database.DatabaseFactory");
                Method main = clas2.getMethod("getInstance", null);
                Object o3 = main.invoke(null, null);

                Database database = ((DatabaseFactory)o3)
                        .findCorrectDatabaseImplementation(new JdbcConnection(conn));

                try (Liquibase liquibase = new Liquibase("changelog-1.xml", new ClassLoaderResourceAccessor(), database)) {
                    liquibase.update(new Contexts(), new LabelExpression());
                }
            });
        } catch (SQLException e) {
            System.err.format("SQL State: %s\n%s", e.getSQLState(), e.getMessage());
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

Custom Classloader code:
public class CustomLoader extends ClassLoader {

    /**
     *Parent ClassLoader is set through the constructor
     */
    public CustomLoader(ClassLoader parent) {
        super(parent);
    }

    /**
     * Loads the class from the file system.
     * @param name
     * Fully Classified name of the class, for example, com.monali.Foo
     */
    private Class getClass(String name) throws ClassNotFoundException {
        String file = name.replace('.', File.separatorChar) + ".class";
        byte[] b = null;
        try {
            // This loads the byte code data from the file
            b = loadClassFileData(file);
            // defineClass is inherited from the ClassLoader class, it converts byte array into a Class.
            Class c = defineClass(name, b, 0, b.length);
            resolveClass(c);
            return c;
        } catch (IOException e) {
            e.printStackTrace();
            return null;
        }
    }

    /**
     * If the class is in com.monali package, we will use CustomLoader classloader otherwise delegate the
     * request to parent classloader.
     * @param name
     * Full class name
     */
    @Override
    public Class loadClass(String name) throws ClassNotFoundException {
        System.out.println("Loading Class '" + name + "'");
        if (name.startsWith("com.monali")) {
            System.out.println("Loading Class using CustomLoader");
            return getClass(name);
        }
        return super.loadClass(name);
    }

    /**
     * Reads the file (.class) into a byte array.
     * @param name Filename
     * @return Byte array read from the file
     * @throws IOException if an exception comes in reading the file
     */
    private byte[] loadClassFileData(String name) throws IOException {
        InputStream stream = getClass().getClassLoader().getResourceAsStream(
                name);
        int size = stream.available();
        byte buff[] = new byte[size];
        DataInputStream in = new DataInputStream(stream);
        in.readFully(buff);
        in.close();
        return buff;
    }
}

But it didn't work, we could see a single classloader is being used. Is there anything you can see wrong in this code I can change to be able to reproduce this issue/test your fix?
On the other hand, I would like to ask you if you (or @Wasalatantri) have any simple webapp code you guys can share with me so that at least I can manually verify the fix you have implemented.
Thanks,
Daniel.


Install documentation precludes adding extensions

The install methods listed on https://docs.microsoft.com/en-us/cli/azure/install-azure-cli say "az component isn't supported" and describe alternate methods of upgrading to the latest CLI.  That's great for the built-in modules but gives customers no way of installing extensions such as the Batch Extensions (https://github.com/Azure/azure-batch-cli-extensions).
Please could you provide documentation on how to install the CLI in such a way that users can run az component update to install extensions?  Thanks!
(I thought pip install azure-cli used to work but now it crashes with an obscure error message.)

@itowlson, for now, install the az using our bash script should provide an installation enable component command. Can you provide the obscure error you hit during your pip install?

By the bash script do you mean curl -L https://aka.ms/InstallAzureCli | bash?  The docs page says "When you install with InstallAzureCli, az component update isn't supported."
Regarding the pip install errors, @ascobie has raised an issue with the details (https://github.com/Azure/azure-cli/issues/3667) as he had much better notes than I did; I'm seeking documentation for an install mechanism that allows customers to add extensions.  If that mechanism is pip install then can we add that to the docs page please?

@itowlson thank you for the feedback. We're currently working on improving the experience of acquisition and extension. Your feedback is valuable to us.

/cc @derekbekoe


PHOENIX-6451 Update joni and jcodings versions

Change-Id: I780f0bc0154aa4be463285029310856acd957ad6

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
15m 49s
master passed

+0
hbaserecompile
16m  4s
HBase recompiled.

+1 :green_heart:
compile
1m 22s
master passed

+1 :green_heart:
javadoc
1m 19s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 13s
the patch passed

+0
hbaserecompile
27m 22s
HBase recompiled.

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 47s
root in the patch failed.

-1 :x:
asflicense
0m 11s
The patch generated 4 ASF License warnings.

33m 22s

Reason
Tests

Failed junit tests
phoenix.hbase.index.write.recovery.TestPerRegionIndexWriteCache

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1202

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 30b23e14a504 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / f4ee13b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
467 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Please rebase on master which fixes the download problem with the tests, so that we can get a proper CI run.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
18m 56s
master passed

+0
hbaserecompile
27m 30s
HBase recompiled.

+1 :green_heart:
compile
1m 55s
master passed

+1 :green_heart:
javadoc
1m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
11m  3s
the patch passed

+0
hbaserecompile
51m  0s
HBase recompiled.

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 39s
the patch passed

_ Other Tests _

-1 :x:
unit
125m 44s
root in the patch failed.

-1 :x:
asflicense
0m 39s
The patch generated 613 ASF License warnings.

182m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1202

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux d0b69adc96d5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 045ff34

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/2/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/2/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
14759 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1202/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Restore support for matching a scenario by its steps' line numbers [WIP]

Description
The Cucumber 4.0 release introduced some regressions in matching scenarios by line numbers other than the exact scenario line. The feature line, tag line, background lines, and step lines all stopped matching their related scenario(s). More context at https://github.com/cucumber/cucumber-ruby/issues/1469
This PR is the first step towards restoring that functionality, and only restores the step lines being matched. Its a bit rough around the edges, but I want to solicit feedback about this approach before sinking more time into it. Thoughts?
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] Tests have been added for any changes to behaviour of the code
[x] New and existing tests are passing locally and on CI
[ ] bundle exec rubocop reports no offenses
[ ] RDoc comments have been updated
[ ] CHANGELOG.md has been updated

It's great to see this moving, thanks for looking into it!

Another thing we should probably watch out for here is to have some test cases for scenario outlines, which may break some of our assumptions about what we need to do to walk through all the relevant child nodes in the AST.

So yes, my first attempt was exactly what you describe above, simply modifying lines and source_lines_for_pickle to include all lines, not just the Scenario line, and a LOT broke. My first impression was the issue is that the Precise#lines is used to both identify a Scenario -- almost as a key or id --, and also to specify a line number for the CLI functionality we're dealing with on here. By adding extra line numbers to it, we're in effect changing its id, and then stuff breaks. I could be off about this exact explanation, but the breakage was enough to dissuade me from trying Plan A.
So that's why I decided to try adding matching_lines and matching_source_lines_for_pickle, and after that everything was green.
That said, I'm going to spend some time exploring other ways of solving this.

Okay, yeah, your suggested approach was much, much better! Closing this in favor of https://github.com/cucumber/cucumber-ruby-core/pull/238


matplotlib: zlabel get cut out of the figure

Describe the bug
I can add zlabel to a 3D plot, but marimo will cut the figure, leaving the zlabel invisible.
Result in marimo (easy to read in the notebook, but some information is missing):

Result of savefig (kind of ugly, but acceptable):

I think the reason is bbox_inches="tight". If can reproduce marimo's result with savefig(…, bbox_inches="tight").
https://github.com/marimo-team/marimo/blob/f996ffb71bddc546d3e769e8c5efc9772b254c5e/marimo/_output/formatters/matplotlib_formatters.py#L39
bbox_inches of matplotlib.figure.Figure.savefig — Matplotlib 3.9.2 documentation:

Bounding box in inches: only the given portion of the figure is saved. If 'tight', try to figure out the tight bbox of the figure.

Could we provide a way to overwrite this bbox_inches="tight"?
Environment
{
  "marimo": "0.9.10",
  "OS": "Windows",
  "OS Version": "10",
  "Processor": "******",
  "Python Version": "3.12.5",
  "Binaries": {
    "Browser": "--",
    "Node": "v20.9.0"
  },
  "Dependencies": {
    "click": "8.1.7",
    "importlib-resources": "missing",
    "jedi": "0.19.1",
    "markdown": "3.7",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.10.2",
    "ruff": "0.6.8",
    "starlette": "0.39.1",
    "tomlkit": "0.13.2",
    "typing-extensions": "missing",
    "uvicorn": "0.30.6",
    "websockets": "12.0"
  },
  "Optional Dependencies": {}
}

Code to reproduce
The above figures are generated from Text annotations in 3D — Matplotlib 3.9.2 documentation + marimo convert. The key line is ax.set_zlabel('Z axis').

Full example on the matplotlib website
import matplotlib.pyplot as plt

ax = plt.figure().add_subplot(projection='3d')

# Demo 1: zdir
zdirs = (None, 'x', 'y', 'z', (1, 1, 0), (1, 1, 1))
xs = (1, 4, 4, 9, 4, 1)
ys = (2, 5, 8, 10, 1, 2)
zs = (10, 3, 8, 9, 1, 8)

for zdir, x, y, z in zip(zdirs, xs, ys, zs):
    label = '(%d, %d, %d), dir=%s' % (x, y, z, zdir)
    ax.text(x, y, z, label, zdir)

# Demo 2: color
ax.text(9, 0, 0, "red", color='red')

# Demo 3: text2D
# Placement 0, 0 would be the bottom left, 1, 1 would be the top right.
ax.text2D(0.05, 0.95, "2D Text", transform=ax.transAxes)

# Tweaking display region and labels
ax.set_xlim(0, 10)
ax.set_ylim(0, 10)
ax.set_zlim(0, 10)
ax.set_xlabel('X axis')
ax.set_ylabel('Y axis')
ax.set_zlabel('Z axis')

plt.show()

hey @YDX-2147483647 , I actually couldn't make this work in Jupyter as well. Were you able to? 🤔
I see some guides online to modify the figure config stack overflow

Thank you for sharing the SO link. 😃

couldn't make this work in Jupyter as well. Were you able to?

I've just tried, and it does not work either.

So it should be a matplotlib issue, and I find https://github.com/matplotlib/matplotlib/issues/28117. I'll close this issue now.


Remove merge times from command line report

With this commit we remove all merge time related metrics from the
command line report as they are not measured anymore since #764.
Relates #764

Thanks for the review! :)


[android] Add Telugu translation (75 million speakers)

Volunteers wanted to translate FrostWire to the Telugu Indian language, preferably native speakers.
This is the file to translate.
https://github.com/frostwire/frostwire/blob/master/android/res/values/strings.xml

On it today.


(build): Need a config to ignore test data

MANIFEST.in file is used only when using the setuptools build system. However as mentioned in the pyproject.toml we are using hatchling build system instead. We can therefore remove this MANIFEST file.
Exclude the ./tests directory from the build step. the source distribution file reduced in size significantly. This speeds up gnatss pip installation speed due to faster downloading, and lesser unzipping.
Solves Issue #220

The point of concern is the large size of the ./tests directory, which causes the gnatss source distribution tar file to be unnecessarily large. In the future we are likely to increase the ./tests directory size significantly by adding additional data files.
`

[SSEC/offshore-geodesy]$ du -sh *
4.0K    LICENSE
0       MANIFEST.in
12K     README.md
844K    docs
4.0K    noxfile.py
4.0K    pyproject.toml
140K    src
15M     tests

[SSEC/offshore-geodesy]$ python -m build
...
[SSEC/offshore-geodesy]$ du -sh dist/*
44K     dist/gnatss-0.1.dev106-py3-none-any.whl
4.7M    dist/gnatss-0.1.dev106.tar.gz
`

After excluding the ./tests directory from the build step, the source distribution file reduced in size significantly. This speeds up gnatss pip installation speed due to faster downloading, and lesser unzipping.
`

[SSEC/offshore-geodesy]$ du -sh *
4.0K    LICENSE
0       MANIFEST.in
12K     README.md
844K    docs
4.0K    noxfile.py
4.0K    pyproject.toml
140K    src
15M     tests
[SSEC/offshore-geodesy]$ python -m build
...
[SSEC/offshore-geodesy]$ du -sh dist/*
44K     dist/gnatss-0.1.dev107-py3-none-any.whl
788K    dist/gnatss-0.1.dev107.tar.gz
`


Fix async function and generator when await/yield is used inside a catch statement with no argument binding

This change hasn't flowed into a product yet so fixing in master.
Thanks, @rhuanjl for pointing out the issue and proposing the fix.


lightweight css animations for new actions entering the log.

while we ponder react-motion in #52, consider a simpler alternative for now :) this PR adds a css fadeIn animation to entries in the actions log.

Would be awesome if you could show a gif of it!

it's quite subtle, doesn't show well (and seems longer) in this gif http://recordit.co/ss6t7FyU7H :|

Nice! What happens when you get down to the bottom and it starts scrolling?

just adds it at the bottom as it already does now, along with the subtle fade. try it, it's really not much :)

I'll defer any visual decisions to @nicinabox to approve

How do we feel about the flash? For reference:

What if we the opposite? Start off actions brighter than usual, then let them “cool down”. Like changing nodes in Chrome inspector.

That's a neat effect too. I think the biggest thing that's lacking with each of these is you don't really see the content move upwards (but these are still an improvement).

i like all 3

Oops, probably wasn't clear on the first one. It's @threepointone's. I just recorded at 30fps and showed scrolling.

Could we append it then animate scrolling to the bottom?

Yeah. Let's replace naïve scrolling with something like https://github.com/alexkuz/additive-animation#usage-example?

Closing, as I don't currently have time to make it better, and scrolling seems to be important for the desired effect. If someone would like to implement it, please do it in https://github.com/gaearon/redux-devtools-log-monitor instead (track https://github.com/gaearon/redux-devtools/pull/132 for discussion).


sqlc: bump version

Fixes https://github.com/lightninglabs/taproot-assets/issues/831.

This PR bumps the etcd dependencies to a newer version, which causes the grpc-gateway/v2 library to be bumped as well, which results in a diff in the *.swagger.json files. I hope that doesn't affect the API generator, otherwise we might need to roll back that change (or update the API generator). We'll know once we merge this PR to main and the nightly API generator job runs.
FYI @jamaljsr.

We'll know once we merge this PR to main and the nightly API generator job runs.

I wasn't aware of that job. Where is it defined please @guggero ?

The code is here: https://github.com/lightninglabs/lightning-api-ng
The actual job is in a private repo, I'll send you the link offline.

Thanks for the heads up @guggero.
I just tested locally and thankfully it doesn't break the build. However, it's no longer detecting the REST Type and Placement for the fields that are in the body of the request messages. It's showing unknown for these fields.

I'll work on a PR to resolve the issue. It shouldn't be too difficult.


Update AggregatedContinuousData Function

This flag is useful, but does not currently catch all aggregated data. It should be updated to look at other fields as well to flag aggregated data.
https://usepa.github.io/TADA/reference/AggregatedContinuousData.html
e.g. Field observation, Activity, Stats attached, qualifier codes

I made some edits to the AggregatedContinuousData flag function. These are the filters used, based on the continuous data template:
cont.data = .data%>%dplyr::filter((ActivityTypeCode=="Field Msr/Obs"&ResultDetectionConditionText=="Reported in Raw Data (attached)")|(ActivityTypeCode=="Field Msr/Obs"&SampleCollectionEquipmentName=="Probe/Sensor"&!is.na(ResultTimeBasis)&!is.na(StatisticalBaseCode)&ResultValueTypeName=="Calculated"))

ActivityTypeCode = Field Msr/Obs + Result Detection Text indicates attachment
OR
ActivityTypeCode = Field Msr/Obs
Sample collection equipment = Probe/Sensor
Result Time Basis is not NA
Statistical Base Code is not NA
ResultValueTypeName is Calculated

Can we close this? Is this line sufficient for catching continuous data?
cont.data = .data%>%dplyr::filter((ActivityTypeCode=="Field Msr/Obs"&ResultDetectionConditionText=="Reported in Raw Data (attached)")|(ActivityTypeCode=="Field Msr/Obs"&SampleCollectionEquipmentName=="Probe/Sensor"&!is.na(ResultTimeBasisText)&!is.na(StatisticalBaseCode)&ResultValueTypeName=="Calculated"))


On-field-click event

Are there any plans to add on-field-click event? There are only 3 types of events (edit, add, delete). I was wondering if it will be possible to handle on click event in future.

Not sure what you are trying to achieve, but I used the labelRenderer to return a link. The first parameter there gives you access to most information that you would need.

How to acheive(edit, add, delete) event? I didn't find that in the introduction.


Use RestProxy for protocol methods

Protocol methods should use RestProxy instead of making the call directly like DynamicRequest did.

Generating RestProxy in PR: https://github.com/Azure/autorest.java/pull/1062


IO corruption on 2.86

Describe the bug
Applying a 'vacuum' to a sqlite database file is enough to corrupt it.  Comparing the pread64() and pwrite64() syscalls between the same command run on ext4 and seaweedfs shows differences, particularly in the last byte of a 1024-byte read.
System Setup
/usr/local/bin/weed master -mdir=/home/weedfs/master -volumePreallocate -volumeSizeLimitMB=30000 -ip <IP_ADDRESS> -peers <IP_ADDRESS>:9333,<IP_ADDRESS>:9333,<IP_ADDRESS>:9333
/usr/local/bin/weed volume -dir=/seaweedfs -mserver=<IP_ADDRESS>:9333,<IP_ADDRESS>:9333,<IP_ADDRESS>:9333 -port=8089 -port.grpc=18089 -ip=<IP_ADDRESS> -max=30000 -index=leveldb -dataCenter=shed
weed mount -filer=<IP_ADDRESS>:8888 -dir=/mnt

OS: archlinux
sqlite: v3.37.0
[mysql2]  # or memsql, tidb
enabled = true
createTable = """
  CREATE TABLE IF NOT EXISTS `%s` (
    dirhash BIGINT,
    name VARCHAR(1000) BINARY,
    directory TEXT BINARY,
    meta LONGBLOB,
    PRIMARY KEY (dirhash, name)
  ) DEFAULT CHARSET=utf8;
"""
hostname = "<IP_ADDRESS>"
port = 3306
username = "weedfiler"
password = "weedfsfiler"
database = "weedfs"              # create or use an existing database
connection_max_idle = 2
connection_max_open = 100
connection_max_lifetime_seconds = 0
interpolateParams = false
# if insert/upsert failing, you can disable upsert or update query syntax to match your RDBMS syntax:
enableUpsert = true
upsertQuery = """INSERT INTO `%s` (dirhash,name,directory,meta) VALUES(?,?,?,?) ON DUPLICATE KEY UPDATE meta = VALUES(meta)"""

Expected behavior
To replicate:

Download this sample SQLIte database and unpack it:
https://www.sqlitetutorial.net/wp-content/uploads/2018/03/chinook.zip
unzip chinook.zip

On weedfs:
$ sqlite3 chinook.db 'vacuum'
$ sqlite3 chinook.db '.tables'
Error: database disk image is malformed

On ext4:
$ sqlite3 chinook.db 'vacuum'
$ sqlite3 chinook.db '.tables'
albums          employees       invoices        playlists
artists         genres          media_types     tracks
customers       invoice_items   playlist_track

If you unpack chinook.db from the zip file on a non-weedfs and a weedfs filesystem and compare the syscall output, you'll see the byte variations:
strace -e pread64,pwrite64,open,fsync,fdatasync -v -xx -s 8192 -- sqlite3 chinook.db 'vacuum' 2>/root/strace-ext4.txt
strace -e pread64,pwrite64,open,fsync,fdatasync -v -xx -s 8192 -- sqlite3 chinook.db 'vacuum' 2>/root/strace-weedfs.txt
diff -u /root/strace-ext4.txt  /root/strace-weedfs.txt

If you perform the operation twice i.e. unzip, vacuum, the corruption is shown to be consistent i.e. no byte-differences shown by cmp:
unzip chinook.zip
cp chinook.db chinook2.db
sqlite3 chinook.db 'vacuum;
sqlite3 chinook2.db 'vacuum;
cmp -l chinook.db chinook2.db

I would expect that comparing the chinook.db between the vacuum performed on ext4 and weedfs should have no byte differences either.

Thanks for the detailed report with clean reproducible steps!
I verified it works well with latest dev version https://github.com/chrislusf/seaweedfs/releases/tag/dev
$ wget https://www.sqlitetutorial.net/wp-content/uploads/2018/03/chinook.zip
--2022-01-23 13:03:04--  https://www.sqlitetutorial.net/wp-content/uploads/2018/03/chinook.zip
Resolving www.sqlitetutorial.net (www.sqlitetutorial.net)... <IP_ADDRESS>
Connecting to www.sqlitetutorial.net (www.sqlitetutorial.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 305596 (298K) [application/zip]
Saving to: ‘chinook.zip’

chinook.zip                   100%[===============================================>] 298.43K   357KB/s    in 0.8s

2022-01-23 13:03:06 (357 KB/s) - ‘chinook.zip’ saved [305596/305596]

fio$ ls
chinook.zip	sample.db
fio$ unzip chinook.zip
Archive:  chinook.zip
  inflating: chinook.db
fio$ ls
chinook.db	chinook.zip	sample.db
fio$ ls  -al
total 2349
drwx------  1 chrislu  staff       0 Jan 22 05:21 .
drwxr-xr-x  1 chrislu  staff       0 Jan 22 20:34 ..
-rw-r--r--  1 chrislu  staff  884736 Nov 29  2015 chinook.db
-rw-r--r--  1 chrislu  staff  305596 Mar 11  2018 chinook.zip
-rw-r--r--  1 chrislu  staff   12288 Jan 23 13:02 sample.db
fio$ sqlite3 chinook.db 'vacuum'
fio$ sqlite3 chinook.db '.tables'
albums          employees       invoices        playlists
artists         genres          media_types     tracks
customers       invoice_items   playlist_track
fio$ ls -al
total 2273
drwx------  1 chrislu  staff       0 Jan 22 05:21 .
drwxr-xr-x  1 chrislu  staff       0 Jan 22 20:34 ..
-rw-r--r--  1 chrislu  staff  845824 Jan 23 13:03 chinook.db
-rw-r--r--  1 chrislu  staff  305596 Mar 11  2018 chinook.zip
-rw-r--r--  1 chrislu  staff   12288 Jan 23 13:02 sample.db

I've previous experienced a similar issue as reported https://github.com/seaweedfs/seaweedfs/issues/3384 but in my experience that happens because Plex will periodically vacuum its SQLite DB.
I tried this sequence with v3.18, to keep it simple with the default configuration:
$ wget https://github.com/seaweedfs/seaweedfs/releases/download/3.18/linux_amd64_full.tar.gz
$ tar -xzf linux_amd64_full.tar.gz
$ ./weed server -dir ./weed-data
$ ./weed filer
$ sudo ./weed mount -dir=/mnt

$ cd /mnt
$ wget https://www.sqlitetutorial.net/wp-content/uploads/2018/03/chinook.zip
$ unzip chinook.zip
$ sqlite3 chinook.db 'vacuum'
$ sqlite3 chinook.db '.tables'
Error: database disk image is malformed

I can't see how your test would have worked.  Did you definitely run it on a SeaweedFS mount?

@nickb937 works well with the dev version. Please help to confirm.

Alright, I just re-built direct from master rather than the download tar-files:
$ git clone https://github.com/seaweedfs/seaweedfs.git
$ cd seaweedfs ; make
$ ~/go/bin/weed server -dir /home/nickb/weed-data
$ ~/go/bin/weed filer
# /home/nickb/go/bin/weed mount -dir=/mnt

nickb@pc:/mnt$ unzip chinook.zip
Archive:  chinook.zip
  inflating: chinook.db
nickb@pc:/mnt$ sqlite3 chinook.db 'vacuum'
nickb@pc:/mnt$ sqlite3 chinook.db '.tables'
Error: database disk image is malformed
nickb@pc:/mnt$

I noticed the problem is only on Linux.

I have compared the contents of pread64/pwrite64 calls between sqlite running on seaweedfs and a different filesystem. From the application perspective they're exactly the same.
I am now trying to produce a small python script that reproduces the problem by copying the IO sequence that sqlite is doing. And viewing the IO patterns in seaweedfs.
The only thing I've noticed is that append mode on seaweedfs acts different to Linux - seek operations don't work on seaweedfs in append mode where they do in Linux, however this mode isn't used by sqlite, and something that the python docs mention that some filesystems will do.

FWIW, Error: database disk image is malformed is exactly the error I see from the Plex logs, part of https://github.com/seaweedfs/seaweedfs/issues/3384

The SQLite VACUUM does the following sequence:

read chinook.db into memory on FD3
write a journal file to disk on FD4
re-write a compacted representation of the database on FD3

Starting from fresh:
unzip chinook.db
strace -f  sqlite3 chinook.db 'vacuum' >v2.strace 2>&1

We can see this sequence marking the beginning of the third state of re-writing to FD3 (around like 4081):
fdatasync(4)                            = 0
openat(AT_FDCWD, "/home/nickb", O_RDONLY|O_CLOEXEC) = 5
fdatasync(5)                            = 0
close(5)                                = 0
pwrite64(4, "\331\325\5\371 \241c\327\0\0\3:", 12, 0) = 12
fdatasync(4)                            = 0
pwrite64(3, "SQLite format 3\0\4\0\1\1\0@  \0\0\0\32\0\0\3:"..., 1024, 0) = 1024
pwrite64(3, "\5\0\0\0\v\3\301\0\0\0\0-\3\373\3\366\3\361\3\353\3\345\3\337\3\331\3\323\3\315\3\307"..., 1024, 1024) = 1024
pwrite64(3, "\r\0\0\0\n\3k\0\3\364\3\343\3\325\3\310\3\273\3\254\3\235\3\216\3z\3k\0\0\0\0"..., 1024, 2048) = 1024
pwrite64(3, "\5\0\0\0\7\3\330\0\0\0\09\3\373\3\366\3\360\3\352\3\344\3\336\3\330\0\0\0\0\0\0"..., 1024, 3072) = 1024
pwrite64(3<EMAIL_ADDRESS>1024, 4096) = 1024

What I've noticed is that none of these pwrite64() calls are modifying the file, despite it being in mode O_RDWR:
unzip chinook.zip
cp chinook.db chinook.db.orig
sqlite3 chinook.db 'vacuum'

cmp chinook.db chinook.db.orig
cmp: EOF on chinook.db after byte 845824, in line 8651

Whereas if you perform the same calls on some other filesystem:
$ cmp chinook.db chinook.db.orig
chinook.db chinook.db.orig differ: byte 28, line 1

Here's a Python script that replicates the problem.  Critical to the replication of the issue is the os.fdatasync() calls and os.ftruncate() and that the file requires to be truncated.  If you comment out either of the fdatasync() calls or or ftruncate() then the test will not fail.
import os
import random

FILESIZE = 4096
FILE = "/mnt/file"

if os.path.exists(FILE):
    os.unlink(FILE)

random.seed(2)
# buff1 must be larger than buff2 so that ftruncate() has to do work
buff1 = bytearray(random.randbytes(FILESIZE + 1024))
buff2 = bytearray(random.randbytes(FILESIZE))
assert buff1 != buff2

fd = os.open(FILE, os.O_RDWR | os.O_CREAT | os.O_NOFOLLOW | os.O_CLOEXEC)

offset = 0
while offset < len(buff1):
    os.pwrite(fd, buff1[offset:offset+1024], offset)
    offset += 1024
os.fdatasync(fd)

offset = 0
while offset < len(buff2):
    os.pwrite(fd, buff2[offset:offset+1024], offset)
    offset += 1024
os.fdatasync(fd)
os.ftruncate(fd, FILESIZE)
os.close(fd)

fd = os.open(FILE, os.O_RDONLY)
data = os.read(fd, len(buff2))
os.close(fd)
assert data == buff2

First write:
I0804 18:58:01.159751 dirty_pages_chunked.go:44 1 memory AddPage [4096, 5120)
I0804 18:58:01.159776 weedfs_file_sync.go:102 doFlush /file fh 0
I0804 18:58:01.159784 upload_pipeline.go:149  uploaderCount 0 ++> 1
I0804 18:58:01.165124 filehandle.go:95 /file existing 0 chunks adds 1 more
I0804 18:58:01.165140 dirty_pages_chunked.go:89 /file saveToStorage 1,05ea52ca24 [0,5120)
I0804 18:58:01.165148 upload_pipeline.go:171  uploaderCount 1 --> 0
I0804 18:58:01.165160 upload_pipeline.go:39 Free sealed chunk:  finished uploading chunk 0
I0804 18:58:01.165168 slot_pool.go:60 --> 0
I0804 18:58:01.165181 weedfs_file_sync.go:151 /file set chunks: 1
I0804 18:58:01.165190 weedfs_file_sync.go:153 /file chunks 0: 1,05ea52ca24 [0,5120)

Second write creates a new chunk, 3,060d51e12c, but file should presumably consist of only 1 chunk:
I0804 18:58:01.165938 weedfs_file_sync.go:102 doFlush /file fh 0
I0804 18:58:01.165945 upload_pipeline.go:149  uploaderCount 0 ++> 1
I0804 18:58:01.166903 filehandle.go:95 /file existing 1 chunks adds 1 more
I0804 18:58:01.166913 dirty_pages_chunked.go:89 /file saveToStorage 3,060d51e12c [0,4096)
I0804 18:58:01.166919 upload_pipeline.go:171  uploaderCount 1 --> 0
I0804 18:58:01.166925 upload_pipeline.go:39 Free sealed chunk:  finished uploading chunk 0
I0804 18:58:01.166934 slot_pool.go:60 --> 0
I0804 18:58:01.166937 weedfs_file_sync.go:151 /file set chunks: 2
I0804 18:58:01.166949 weedfs_file_sync.go:153 /file chunks 0: 1,05ea52ca24 [0,5120)
I0804 18:58:01.166957 weedfs_file_sync.go:153 /file chunks 1: 3,060d51e12c [0,4096)**

os.ftruncate() truncates chunk 1,05ea52ca24, the original data rather than chunk 3,060d51e12c the new data.
I0804 18:58:01.167376 weedfs_attr.go:53 /file setattr set size=4096 chunks=2
I0804 18:58:01.167395 weedfs_attr.go:65 truncated chunk 1,05ea52ca24 from 5120 to 4096

Test Passed for me with latest build from master
version 30GB 3.20 986daecb linux arm

Still seems to break databases where PRGAMA=WAL (e.g. *arr apps)

Still seems to break databases where PRAGMA=WAL (e.g. Sonarr)
[v<IP_ADDRESS>7] code = Corrupt (11), message = System.Data.SQLite.SQLiteException (0x800007EF): database disk image is malformed
database disk image is malformed
  at System.Data.SQLite.SQLite3.Reset (System.Data.SQLite.SQLiteStatement stmt) [0x00088] in <cf516e4846354910b3d60749c894b1bf>:0
  at System.Data.SQLite.SQLite3.Step (System.Data.SQLite.SQLiteStatement stmt) [0x0006e] in <cf516e4846354910b3d60749c894b1bf>:0
  at System.Data.SQLite.SQLiteDataReader.NextResult () [0x00174] in <cf516e4846354910b3d60749c894b1bf>:0
  at System.Data.SQLite.SQLiteDataReader..ctor (System.Data.SQLite.SQLiteCommand cmd, System.Data.CommandBehavior behave) [0x0008e] in <cf516e4846354910b3d60749c894b1bf>:0
  at (wrapper remoting-invoke-with-check) System.Data.SQLite.SQLiteDataReader..ctor(System.Data.SQLite.SQLiteCommand,System.Data.CommandBehavior)
  at System.Data.SQLite.SQLiteCommand.ExecuteReader (System.Data.CommandBehavior behavior) [0x0000c] in <cf516e4846354910b3d60749c894b1bf>:0
  at System.Data.SQLite.SQLiteCommand.ExecuteNonQuery (System.Data.CommandBehavior behavior) [0x00006] in <cf516e4846354910b3d60749c894b1bf>:0
  at System.Data.SQLite.SQLiteCommand.ExecuteNonQuery () [0x00006] in <cf516e4846354910b3d60749c894b1bf>:0
  at Marr.Data.DataMapper.ExecuteNonQuery (System.String sql) [0x0002a] in M:\BuildAgent\work\63739567f01dbcc2\src\Marr.Data\DataMapper.cs:204
  at NzbDrone.Core.Messaging.Commands.CommandRepository.OrphanStarted () [0x00064] in M:\BuildAgent\work\63739567f01dbcc2\src\NzbDrone.Core\Messaging\Commands\CommandRepository.cs:46
  at NzbDrone.Core.Messaging.Commands.CommandQueueManager.Handle (NzbDrone.Core.Lifecycle.ApplicationStartedEvent message) [0x00010] in M:\BuildAgent\work\63739567f01dbcc2\src\NzbDrone.Core\Messaging\Commands\CommandQueueManager.cs:260
  at NzbDrone.Core.Messaging.Events.EventAggregator.PublishEvent[TEvent] (TEvent event) [0x0011a] in M:\BuildAgent\work\63739567f01dbcc2\src\NzbDrone.Core\Messaging\Events\EventAggregator.cs:92

I just had a chance to test it with Plex and its the same error database disk image is malformed. :(

With the 3.25 release, Sonarr has been running a few days without issues for me

Wooot! Awesome, just deployed 3.26 here and Plex is running stable! Thanks tons for fixing this!!!! 👏🏻


Document process to manually delete a cla group

When a PM or Community PM would like to delete a cla group in v2 PCC, a ticket must be filed with support.
https://admin.dev.platform.linuxfoundation.org/apps/cla/overview#id=a0941000002wBzBAAU
CLA Group: testfound12nov
Let's work to figure out the process to manually delete this CLA Group and document it for support desk.

would depend on whether there were signatures for it or if it was a mistake/test

Currently, we need to open a support ticket to delete the CLA group. Is is documented in the public documentation at docs.linuxfoundation.org.


Proposal: @HasRole and @HasPermission annotations

Currently,  resources are protected via authorizers that are created on application startup, e.g. @Pac4JSecurity(authorizers = "foo").
A much more convenient way of doing this would be to have two annotations:
public @interface HasRole {
    String value();
}

public @interface HasPermission {
    String value();
}

So you could have annotations like @HasRole("superuser") or @HasPermission("admin:view").

I will find some time to implement it soon :)

Just wanted to add, now that I better understand pac4j, I think this improvement would be a big step forward towards making the developer experience with pac4j better, especially if it can use the default client to make it as simple as possible to use.
The reasons I believe these annotations are a big improvement are:

Only need to declare the role/permission you want to filter on in one place.

// Set up authorizer in bundle
config.addAuthorizer("canEditUser", new RequireAnyPermissionAuthorizer<>("user:edit"));

// Then, in the resource class -- and this might be the only place we use this...
@Pac4JSecurity(authorizer = "canEditUser" client="form")

-- vs --
@HasPermission("user:edit")

Clarity/less magic. A newcomer needs to know that they have to set up the authorizers in the bundle, and that they need to specify which client to use, and they need to remember to use the name they associated with it in the confi, etc. In short: they need to know more about the internal plumbing of pac4j just to get started.

makes it easier to use fine-grained permissions

The pac4j design is merely driven by the fact it must work for 14 implementations and more. Hence its generic nature and the easy switch between one framework to another.
I understand your point of view, but I'm not so enthusiastic about this syntactic sugar. For me, it's another thing to learn: what happens for example if I encounter this annotation without being authenticated? Does it have the same behavior than the Pac4jSecurity annotation?
Overall, I think there is a balance to find even it seems reasonable to think about this trivial annotations.

In my head, these annotations would have been used in conjunction with a Pac4jSecurity since you still need to specify the clients to be used.
Or maybe they should be a replacement (and thus the clients must be specified next to the authorization rule).
It's true that it can make things a bit more complex to understand (even though simpler to express).
I don't really know what is best, on one hand, it's not really needed to do things this way since pac4j is based on a global configuration approach; on the other hand, it is common to have this kind of annotations for jax-rs related security frameworks and we already started going this way with the Pac4jSecurity and co annotations...

My suggestions come from my view that for a young project like pac4j, anything that helps people have a good experience with it out of the box without having to invest too much first is important to increasing adoption.  A big part of that is making it really, really easy to get started, and gradually engage developers with a richer set of tools as more complex requirements arise.
Both of you are far, far more familiar with this domain than I, so I certainly won't presume that my suggestions are the right way to do this, I just want to encourage you to find ways to help people quickly and painlessly add security to their apps via pac4j.

Sure, it makes sense to have these new annotations. I just wanted to highlight the fact that these additions must be wisely thought.

I won't have the time to tackle that soon, so let's postpone it and release a new version soon before starting to move everything to pac4j v2.

Closing due to inactivity.


Device data file is missing 'temperatureUnit' key, using 'C' as default.

Hello,
I installed smartir and seems to be working fine, but the logging has the following warning message Device data file is missing 'temperatureUnit' key, using 'C' as default.
May I know how to fix it？
Thanks.
Home Assistant version
2024.6.4
SmartIR version
1.17.16
climate:

platform: smartir
name: climate_bedroom1
unique_id: bedroom1_ac
device_code: 9999
controller_data:  remote.zhu_wo_hong_wai_yao_kong_qi
temperature_sensor: sensor.kong_qi_jing_hua_qi_temperature
humidity_sensor: sensor.kong_qi_jing_hua_qi_humidity

homeassistant log warning:
2024-06-22 15:08:48.839 WARNING (MainThread) [custom_components.smartir.climate] Device data file is missing 'temperatureUnit' key, using 'C' as default.
2024-06-22 15:08:48.841 WARNING (MainThread) [custom_components.smartir.climate] Device data file is missing 'temperatureUnit' key, using 'C' as default.

Hello,
the message means what the message says. Consult default device files to see what you need to add ('temperatureUnit'). I have task to document structure of the device files, but hadn't had time to do it yet.

Thanks for your quick response.
Added temperatureUnit to my custom_codes then restart HA。
The warning message disappeared.
Thank you very much!


refact: move env to server

Signed-off-by: Keming<EMAIL_ADDRESS>
fix https://github.com/tensorchord/envd/issues/1045

This requires the new release of the envd-server after merging https://github.com/tensorchord/envd-server/pull/59.

/assign @gaocegege @VoVAllen


fix: GROUP BY queries with offset that crosses a DST boundary fail. (#25082)

This is actually the second fix for
https://github.com/influxdata/influxdb/issues/20238 for when the time zone falls back in autumn.
closes https://github.com/influxdata/influxdb/issues/25078
(cherry picked from commit d60741b5063ce829cf32ca86f4746b16d1c4d31c)
closes https://github.com/influxdata/influxdb/issues/25079

Not to be merged until after 1.11.6 GA

Duplicate of https://github.com/influxdata/influxdb/pull/25240


Document cluster resilience around upgrade

This is a Feature Request

What would you like to be added
Add details about how to maintain resilience for your Kubernetes cluster during an upgrade.
Why is this needed
We have https://kubernetes.io/docs/tasks/administer-cluster/cluster-upgrade/#upgrade-other as a task-oriented guide but it doesn't tell you much about the design considerations and constraints.
For example if you upgrade etcd then a 3-node etc cluster is briefly unable to tolerate some forms of partial outage (the surviving node cannot detect that it is the sole healthy survivor). You could set up a witness / fencing mechanism; a more cloud native approach is to scale it out to 5 nodes, do the upgrade and scale in.
Comments
Aim to cover the mixed version proxy concept; in fact, we could move that page to be a heading in a new page if we add one.
/sig cluster-lifecycle
/sig architecture
/language en
/kind feature

/lifecycle frozen

/triage accepted


Player cant join

服务端版本 LuminolMC Version
1.20.6-DEV-f2a1374
预期的行为 Expected behavior
Player joined
观测到的实际行为 Observed/Actual behavior
Cant join
复现步骤 Steps/models to reproduce
Some players try to join
插件与数据包列表。 Plugin and Datapack List.
[20:37:36 INFO]: Server Plugins (14):
[20:37:36 INFO]: Paper Plugins:
[20:37:36 INFO]:  - CarbonChat, HuskHomes
[20:37:36 INFO]: Bukkit Plugins:
[20:37:36 INFO]:  - AntiPopup, Chunky, floodgate, GSit, LuckPerms, SayanVanish, SkinsRestorer, spark, ViaBackwards, ViaVersion
[20:37:36 INFO]:  voicechat, ZNPCsPlus
更多详细信息。 The more information.
[20:24:46 INFO]: UUID of player roket2338 is 03336a38-33c5-3992-90d8-c404b0d2ce15
[20:24:47 INFO]: com.mojang.authlib.GameProfile@37d523ca[id=03336a38-33c5-3992-90d8-c404b0d2ce15,name=roket2338,properties={}] lost connection: Internal Exception: io.netty.handler.codec.EncoderException: Pipeline has no outbound protocol configured, can't process packet net.minecraft.network.protocol.common.ClientboundKeepAlivePacket@69428ad8
[20:24:57 INFO]: UUID of player roket2338 is 03336a38-33c5-3992-90d8-c404b0d2ce15
[20:24:59 INFO]: com.mojang.authlib.GameProfile@36a24bc4[id=03336a38-33c5-3992-90d8-c404b0d2ce15,name=roket2338,properties={}] lost connection: Internal Exception: io.netty.handler.codec.EncoderException: Pipeline has no outbound protocol configured, can't process packet net.minecraft.network.protocol.common.ClientboundKeepAlivePacket@2360622f

(Server proxy supported 1.21 and backend servers use viaversion)

Could you reproduce it on Folia?I guess it's an issue of the upstream

Fixed in https://github.com/LuminolMC/Luminol/commit/e6027bdfbf5fb4fb52d38064fc5b626757a6557f
You can set alternative_keepalive_handling.enabled to true now.


Removed misleading "i.e it's public domain"

Check this from the CC0 webpage:

Public License Fallback. Should any part of the Waiver for any reason be judged legally invalid or ineffective under applicable law, then the Waiver shall be preserved to the maximum extent permitted taking into account Affirmer's express Statement of Purpose. In addition, to the extent the Waiver is so judged Affirmer hereby grants to each affected person a royalty-free, non transferable, non sublicensable, non exclusive, irrevocable and unconditional license to exercise Affirmer's Copyright and Related Rights in the Work (i) in all territories worldwide, (ii) for the maximum duration provided by applicable law or treaty (including future time extensions), (iii) in any current or future medium and for any number of copies, and (iv) for any purpose whatsoever, including without limitation commercial, advertising or promotional purposes (the "License"). The License shall be deemed effective as of the date CC0 was applied by Affirmer to the Work. Should any part of the License for any reason be judged legally invalid or ineffective under applicable law, such partial invalidity or ineffectiveness shall not invalidate the remainder of the License, and in such case Affirmer hereby affirms that he or she will not (i) exercise any of his or her remaining Copyright and Related Rights in the Work or (ii) assert any associated claims and causes of action with respect to the Work, in either case contrary to Affirmer's express Statement of Purpose.

As you can see, the CC0 license in indeed used in countries which do not have a public domain law Thus, under the laws of those countries, CC0 is a license
Any country which does have public domain law, that country, shall not regard CC0 as a license, as stated by the CC0 page in the part which I had quoted above.

@thenoncoder CC0 is an instrument. It is license only in certain circumstances, and it may happen that for U.S. it doesn't work as a license, so saying that Gratipay is licensed under CC0 in US could be incorrect.


Remove outdated comment from SystemClock

Hi!
This comment looks outdated.

@hpple, thanks for reminding us about that detail. Actually the comment still applies, though the wording needs to be improved indeed: "The precise clock is not enabled by default, since access to it is not garbage free." And also the comment better be situated just above the log4j2.usePreciseClock variable. Would you mind updating your PR to adapt this, please?

@vy
done

@hpple, thanks so much for the contribution and the prompt response! Merging it right away.


Search icon is above text

This is on OSX, Chrome: Version 52.0.2743.82 (64-bit)

@paulbellamy do you mind closing this, as #1716 states the same problem plus a bit more?

#1716 reports two problems. I would rather keep this issue focused and let #1716 deal with the remaining problem only.

@juliusv just reported this to me on slack.

This happens in Chrome >48.


Use return_schema for computed fields

This change provides a way to specify a serialization schema for computed fields (previously, they were treated as Any, which would lead to the FastAPI security problem in pydantic). This is also useful for generating JSON schemas for computed fields.
The pydantic-side PR is https://github.com/pydantic/pydantic/pull/5708 (note that PR depends on https://github.com/pydantic/pydantic/pull/5707, which did not require changes to pydantic-core).

Codecov Report

Merging #595 (e5d6ca4) into main (0d57243) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   94.19%   94.15%   -0.04%
==========================================
  Files          96       96
  Lines       13099    13114      +15
  Branches       24       24
==========================================
+ Hits        12339    12348       +9
- Misses        754      760       +6
  Partials        6        6

Impacted Files
Coverage Δ

pydantic_core/core_schema.py
96.96% <100.00%> (+<0.01%)
:arrow_up:

src/serializers/computed_fields.rs
98.26% <100.00%> (+1.20%)
:arrow_up:

src/serializers/type_serializers/dataclass.rs
97.05% <100.00%> (ø)

src/serializers/type_serializers/model.rs
93.96% <100.00%> (ø)

src/serializers/type_serializers/typed_dict.rs
96.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d57243...e5d6ca4. Read the comment docs.

please review

I'll note that those are only present in PlainSerializerFunctionSerSchema and WrapSerializerFunctionSerSchema.
I think given that relates to SerSchema, where I think there is perhaps a bigger question of how to best handle interaction with more arbitrary serialization, I'll create a separate issue for that before merging this, rather than doing more work here.


No tooltip for download Service Account

Description

Expected result
Should have a tooltip
Actual result

Steps to reproduce

Troubleshooting

The tooltip text should describe that a kubeconfig file can be downloaded.

I can confirm the tooltip is available - thanks!


Fix clientEvents that are causing reconnection attempts

Details
When reorganizing the ReportsScreen client events remained bound to whatever report was passed into the constructor and would throw errors since we are publishing events to a channel we are no longer subscribed to. There's no reason why we should throw an error in this case (which also causes a reconnection attempt). So the solution is to:

Make sure we are referencing the correct reportID in the debounced method
Stop reconnecting for attempts to send events to channels we are not subscribed to - this is not typically an event that we should respond to with reauthentication and is totally expected as subscriptions take time to resolve.

Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157459
Fixes https://github.com/Expensify/Expensify/issues/157266
Tests

Open Expensify.cash to a report and start typing
As another user load up that report and see that the user is typing feature works as expected
Verify no abnormal reconnection attempts are made
Verify that when an attachment is present in the chat it does not flash while you are typing

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

FYI - This message is true ☝ , we were testing some staging stuff and so this PR wont be deployed until the next PR is merged.

Nice!


ARROW-18030: [C++] Bump LZ4 version

Revision: 12d22b35c7d3a995d7e7e917c2a3e25e8ba1a560
Submitted crossbow builds: ursacomputing/crossbow @ lz4-bump-0

Task
Status

test-alpine-linux-cpp

test-build-cpp-fuzz

test-conda-cpp

test-conda-cpp-valgrind

test-debian-10-cpp-amd64

test-debian-10-cpp-i386

test-debian-11-cpp-amd64

test-debian-11-cpp-i386

test-fedora-35-cpp

test-ubuntu-18.04-cpp

test-ubuntu-18.04-cpp-release

test-ubuntu-18.04-cpp-static

test-ubuntu-20.04-cpp

test-ubuntu-20.04-cpp-17

test-ubuntu-20.04-cpp-bundled

test-ubuntu-20.04-cpp-thread-sanitizer

test-ubuntu-22.04-cpp


helm & e2e: add option to enable read affinity for rbd

Describe what this PR does

helm: add option to enable read affinity for rbd
This commit adds --enable-read-affinity flag to
enable read affinity for rbd

e2e: added test to verify read affinity functionality
e2e test case is added to test if read affinity is enabled by
verifying read_from_replica=localize option is passed.

Closes: #3642

/test ci/centos/mini-e2e/k8s-1.26

/test ci/centos/mini-e2e-helm/k8s-1.27

/test ci/centos/mini-e2e/k8s-1.27

/test ci/centos/mini-e2e/k8s-1.28

/test ci/centos/mini-e2e-helm/k8s-1.28

@Rakshith-R,
For the e2e test case - verifying just the presence of the read_from_replica=localize option is enough?

@Rakshith-R, For the e2e test case - verifying just the presence of the read_from_replica=localize option is enough? As the crush location label:value will be in random order.
example - crush_location=zone:east-zone1|region:east or it may be crush_location=region:east|zone:east-zone1. In this case, I'll have to parse thecrush_location value and then verify each label:value individually

It'll be great to parse and verify the key value pairs too.

/test ci/centos/mini-e2e/k8s-1.26

/test ci/centos/mini-e2e/k8s-1.27

/test ci/centos/mini-e2e/k8s-1.28

/test ci/centos/mini-e2e/k8s-1.28

/test ci/centos/mini-e2e-helm/k8s-1.26

/test ci/centos/mini-e2e-helm/k8s-1.27

/test ci/centos/mini-e2e-helm/k8s-1.28

/test ci/centos/mini-e2e-helm/k8s-1.26

/test ci/centos/mini-e2e-helm/k8s-1.27

/test ci/centos/mini-e2e-helm/k8s-1.28

@iPraveenParihar as your changes don't have any impact from the kubernetes version, just run one test to ensure its working as expected.

@iPraveenParihar as your changes don't have any impact from the kubernetes version, just run one test to ensure its working as expected.

😅 oh okay, got it.

/test ci/centos/mini-e2e/k8s-1.28

/test ci/centos/mini-e2e/k8s-1.28

/test ci/centos/mini-e2e/k8s-1.28

@iPraveenParihar linter is still failing

@iPraveenParihar linter is still failing

yea, checking it -   283:3     warning  comment not indented like content  (comments-indentation)
But not able to figure it out
readAffinity:
  # Enable read affinity for RBD volumes. Recommended to
  # set to true if running kernel 5.8 or newer.
  # enabled: false
  # Define which node labels to use as CRUSH location.
  # This should correspond to the values set in the CRUSH map.
  # NOTE: the value here serves as an example
  # crushLocationLabels:
  #  - topology.kubernetes.io/region
  #  - topology.kubernetes.io/zone

If I uncomment the enabled and crushLocationLabels key, lint passes

@Madhu-1 , commenting out enabled key throws lint error
Error:  templates/: template: ceph-csi-rbd/templates/nodeplugin-daemonset.yaml:90:48: executing "ceph-csi-rbd/templates/nodeplugin-daemonset.yaml" at <.Values.readAffinity.enabled>: nil pointer evaluating interface {}.enabled

we can just comment out the crushLocationLabels?

@Madhu-1 , commenting enabled key throws lint error
Error:  templates/: template: ceph-csi-rbd/templates/nodeplugin-daemonset.yaml:90:48: executing "ceph-csi-rbd/templates/nodeplugin-daemonset.yaml" at <.Values.readAffinity.enabled>: nil pointer evaluating interface {}.enabled

we can just comment out the crushLocationLabels?

you can add one more check to ensure that Values.readAffinity is set?

/test ci/centos/mini-e2e-helm/k8s-1.28

@iPraveenParihar you can use https://docs.mergify.com/commands/rebase to rebase, It'll preserve the approvals.

@Mergifyio queue

@mergifyio queue


MIDI FX function help wanted

Is there any function to let me change the whole MIDI notes from major to natural minor?
just like a transposer, or there are any function that can modify all midi event in the midi file?
In my case, I have to modify the midi file while the song/sequence playing.
Thanks in advance.

Nothing like that in AudioKit, you'll have to write it yourself, shouldn't be too difficult.


T35536 renames

This has the renames for all block serialization resources. Is on top of the UI / definition decouple in #164
https://phabricator.endlessm.com/T35536

Making this draft until we release.

@wnbaum is this more or less aligned with your AST PR? What should I do differently to make your life easier?

I just rebased this with main, ready for review. This are the renames on top of #164

@wnbaum is this more or less aligned with your AST PR? What should I do differently to make your life easier?

@manuq Yes, naming conventions look good and I appreciate you putting the classes in the same serialization/ directory as I did.  One thing I changed in my PR was renaming Types.BlockType.EXECUTE to Types.BlockType.STATEMENT and added another type for CONTROL. This is because the way I generate the blocks is by instantiating a scene based on the block_type. Cool if you want to do it here with other renames, but its in my PR as well.

@wnbaum is this more or less aligned with your AST PR? What should I do differently to make your life easier?

@manuq Yes, naming conventions look good and I appreciate you putting the classes in the same serialization/ directory as I did. One thing I changed in my PR was renaming Types.BlockType.EXECUTE to Types.BlockType.STATEMENT and added another type for CONTROL. This is because the way I generate the blocks is by instantiating a scene based on the block_type. Cool if you want to do it here with other renames, but its in my PR as well.

Ah yes, you mentioned it and I then forgot. I will append the block type changes to this PR.

I'll give this a more thorough review after I review your data decoupling PR that this is on top of!

Yes please! This one should be straightforward as it's all renamings. The other one could take more time to review.

My one request is that I don't think block_definition.gd should be in the main plugin folder, and neither should blocks_catalog.gd. I think we should have a folder addons/block_code/datagen with all of the data generation classes in it. That would include category_factory.gd, blocks_catalog.gd, block_definition.gd. Let me know what you think.

OK agreed! It would have been better to do that in #164 but that's already merged. So I'll do it here. Previously I had them inside a model subfolder but then the name changed to "definition". I'll use "generation" instead as you request, which is probably what you'll use in your PR. If you don't mind I will name it code_generation instead of codegen to avoid the abbreviation. I find it a good programming practice.
Also, I would not move category_factory.gd yet because it's UI (the functions return arrays of Block scenes). But feel free to do so in your PR when that is not the case anymore.

Also you can rebase to main if you want, but it doesn't really matter :)

OK done, ready for another review.


Two questions about JSON data provided

I have two questions about the JSON data provided.

What does the key value of Args mean? And I wonder what the other json data that comes in there means.

As far as I know, the key ph means the event type, right? Then, I know that all the data you gave me in json are 'x' type, but I wonder if only 'x' type comes in.

Thank you for your answer :)


Wikipedia page

Hi,
I thought Locust deserves a wikipedia page so I start a draft by myself and try to submit it (first submission on wiki en), but I smashed into a brick wall...
So I need help to improve the quality of article and add more external references (it seems like similar tools' pages were posted on a less restrictive time)
Here's the draft : https://en.wikipedia.org/wiki/Draft:Locust_(software)
Locust owner: feel free to delete this issue and wiki page if it seems irrelevant to you.

I think this is brilliant, and I would love to see a wiki page. Unfortunately wiki-editors are very strict nowadays (keeping a page once it is created is probably easier, like you say). Someone asked on SO just recently about how to cite Locust and its creators, maybe if that gets published we'll have another reference. I'll have a think if I can contribute something more.

@cyberw Thanks I missed this page, but I think the edit will be refused. The starting point of this story is my addition of Locust on
the Web_server_benchmarking page, it was reverted within a minute 😢:  https://en.wikipedia.org/w/index.php?title=Web_server_benchmarking&action=history

That's weird. Although, reading the revert message I think it was not a problem with adding locust overall, just that the link was not in the correct format. (https://en.wikipedia.org/wiki/Wikipedia:External_links#Important_points_to_remember)

Oh thanks, I totally missed the point. I just made a new edit on https://en.wikipedia.org/wiki/Web_server_benchmarking.
Someone already changes Software_load_testing page, but with a direct link it will certainly be reverted, no ?
https://en.wikipedia.org/w/index.php?title=Software_load_testing&action=history

I did that :) lets see what happens...

I wanted to link to the page, but then also add a link to the site (just to have something until the page is actually published)

Maybe we should just remove the entire "Performance measures" section? It doesnt really differentiate locust from other tools...

Feel free to edit the draft, English is (obviously) not my mother tongue and my writing skills are limited.

It seems that the draft was definitely rejected :(

I see that. I guess resubmitting without changes was the wrong way to go. I'm giving it one last shot...

Yes, they are very touchy.
I think it was the final attend, the submission seems blocked. I'll try to create a French page (they are more tolerant)

By the way, I tried to upload Locust logo and screenshot on wikimedia commons (the ones in the github repo), I assumed that they are under MIT licence, but:

Is this licence allows it?
Is everybody is ok with that?
Who's the artists that should be credited (@heyman)?

I've tried a couple times but wikipedia admins are... special. Closing now.

Yes, so sad… I started this issue with so much hope…
Someone else should try it again in some months.
Anyway the French page is online https://fr.wikipedia.org/wiki/Locust_(logiciel). Maybe other non English users could translate it to other languages, it could create a critical mass that will unite the English one?


[FLINK-15640][k8s] Support to set labels for jobmanager and taskmanager pod

What is the purpose of the change
Introduce config options to support to set labels and node-selector for JM/TM pods.

The labels are key/value pairs that will be attached to the JM/TM pod.

Brief change log

Support to set labels

Verifying this change

Unit tests
Manually test in a real cluster

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@TisonKun @zhengcanbin Do you mind to take a look this PR?

Hi, @wangyang0918, this PR introduces two features, how about splitting it into two separate PRs?

@zhengcanbin Thanks for you review. I think your suggestion is on point. I will split this ticket into two separate ones.

@zhengcanbin I have addressed your comments. Could you take a look at your convenience?
@TisonKun Could you also have a final check and help to merge?

@wangyang0918 It would be good to rebase this PR on the latest master and resolve the merge conflicts.

@zhengcanbin Thanks for your review. I have rebased on the master.
@TisonKun Could you please also have a look?


Error while Invoking dapr sidecar

Hi All
I have initialized the dapr for my solution. Then I ran the dapr command to expose the dapr sidecar but it's throw error.
"dapr run --app-id appname--app-port 5000 --dapr--http--port 3500 dotnet run"
Error: {
"errorCode": "ERR_DIRECT_INVOKE",
"message": "invoke API is not ready"
}
Tried enabling the mDNS but no use.

@shubham1172 thank you for your response, It is solved now. the issue is the path from where I am testing the curl command is wrong. After changing the path it's working,


Move jedi CI container spec for bufr from version 12.0.0 to 12.0.1

Summary
This PR moves the version for bufr from 12.0.0 to 12.0.1 in the jedi ci container spec. This is needed to be able to test ioda-converters properly with the latest bufr2ioda.x application.
Testing
Only the CI testing.
Applications affected
JEDI CI testing
Systems affected
JEDI CI test systems (AWS)
Dependencies
None
Issue(s) addressed
Resolves #867
Checklist

[x] This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
[ ] These changes have been tested on the affected systems and applications.
[ ] All dependency PRs/issues have been resolved and this PR can be merged.

I'm making this a draft PR because I want to test it, but it needs to wait until after #866 is merged.

CI will only test this nightly (after being merged) or via workflow dispatch, but that only makes sense after #866 is merged. The change is correct, thanks for that.