Is there a reason (defmethod prng-random-data (num-bytes (prng os-prng)..) does not close the /dev/urandom file?

Stress testing a postmodern enhancement and ran out of file handles. I traced it back to (defmethod prng-random-data (num-bytes (prng os-prng) ..) which opens /dev/urandom and never closes it. Is there a reason for this?

Possibly it's faster to keep a handle rather than opening each time prng-random-data. If that's true, then a close-prng and/or a finalizer are necessary. If that's not true, then we should close the file after reading in the data.
Can you benchmark and see if it makes any difference to keep a handle?

Seems to be a ccl problem because I am not seeing the file connections left open in sbcl or ecl. (All of this is on a linux box). Maybe the following will help the analysis.
I benchmarked the original code with trivial-benchmark:with-timing against a version of the original code wrapping the relevant code in a with-open-file macro. I.E:
  (let ((seq (make-array num-bytes :element-type '(unsigned-byte 8))))
    (unless (slot-boundp prng 'source)
      (with-open-file (stream #P"/dev/urandom" :element-type '(unsigned-byte 8))
        (setf (slot-value prng 'source)
              stream)
        (assert (>= (read-sequence seq (slot-value prng 'source)) num-bytes))))
    seq)

The test simply to run the following 1,000 times: authenticate against a postgresql database using scram-sha256, printing T if there was a valid connection to the database and re-attempting if the authentication was not valid. (I currently have a 0.3% failure rate on authentication, so the second attempts do show up occasionally in a 1,000 attempt run and those do not always get closed even in ecl or sbcl using the original code).
The results were as follows:
CCL
original code
-          SAMPLES  TOTAL      MINIMUM   MAXIMUM   MEDIAN    AVERAGE   DEVIATION
REAL-TIME  1000     272.13715  0.268867  0.541924  0.271101  0.272137  0.014937
RUN-TIME   1000     271.09796  0.267694  0.540449  0.270145  0.271098  0.014806

Resulting in 1010 open files of /dev/urandom. 20 calls later I ran out of file descriptors and could no longer access /dev/urandom without restarting ccl.
with-open-file version
-          SAMPLES  TOTAL      MINIMUM   MAXIMUM   MEDIAN    AVERAGE   DEVIATION
REAL-TIME  1000     270.21777  0.265639  0.538448  0.26821   0.270218  0.022414
RUN-TIME   1000     269.21286  0.26474   0.537334  0.267214  0.269213  0.02238

Resulting in 1 open file of /dev/urandom
ECL
original code
-             SAMPLES  TOTAL        MINIMUM   MAXIMUM   MEDIAN    AVERAGE     DEVIATION
REAL-TIME     1000     366.37       0.349     0.387     0.37      0.36637     0.009237
RUN-TIME      1000     385.273      0.343     0.415     0.401     0.385273    0.025091
BYTES-CONSED  1000<PHONE_NUMBER>2  18765728  20047968  18785344  19207220.0  570324.5

No connections left open to /dev/urandom
with-open-file version
-             SAMPLES  TOTAL        MINIMUM   MAXIMUM   MEDIAN    AVERAGE     DEVIATION
REAL-TIME     1000     367.398      0.349     0.74      0.37      0.367398    0.018773
RUN-TIME      1000     386.502      0.344     0.801     0.401     0.386502    0.030666
BYTES-CONSED  1000<PHONE_NUMBER>0  18769952  38761840  18788048  19249102.0  1042669.8

No connections left open to /dev/urandom
SBCL
original code
-                SAMPLES  TOTAL       MINIMUM   MAXIMUM   MEDIAN    AVERAGE    DEVIATION
REAL-TIME        1000     15.731      0.014     0.031     0.015     0.015731   0.001356
RUN-TIME         1000     13.13       0.012     0.027     0.013     0.01313    0.00132
USER-RUN-TIME    1000     12.702619   0.009133  0.026748  0.012649  0.012703   0.001579
SYSTEM-RUN-TIME  1000     0.430588    0         0.006567  0         0.000431   0.001092
PAGE-FAULTS      1000     0           0         0         0         0          0.0
GC-RUN-TIME      1000     0.155       0         0.005     0         0.000155   0.000764
BYTES-CONSED     1000<PHONE_NUMBER>  7048880   14118336  7059168   7076875.0  315388.22
EVAL-CALLS       1000     0           0         0         0         0          0.0

With four open files to /dev/urandom
with-open-file version
-                SAMPLES  TOTAL       MINIMUM   MAXIMUM   MEDIAN    AVERAGE    DEVIATION
REAL-TIME        1000     15.789      0.014     0.035     0.015     0.015789   0.001696
RUN-TIME         1000     13.166      0.012     0.031     0.013     0.013166   0.001623
USER-RUN-TIME    1000     12.754451   0.007267  0.026978  0.012648  0.012754   0.001631
SYSTEM-RUN-TIME  1000     0.417296    0         0.009881  0         0.000417   0.001118
PAGE-FAULTS      1000     0           0         0         0         0          0.0
GC-RUN-TIME      1000     0.155       0         0.006     0         0.000155   0.00077
BYTES-CONSED     1000<PHONE_NUMBER>  7052688   14118656  7059184   7097963.5  497695.63
EVAL-CALLS       1000     0           0         0         0         0          0.0

with no open files to /dev/urandom

When running the following test:
(let ((crypto:*prng* (crypto:make-prng :os)))
  (time (dotimes (i 1000)
          (crypto:random-data 16))))

I get the following results:
      current version   with-open-file version
SBCL     0.000175          0.023220
CCL      0.000321          0.033609

Opening and closing the file every time is at least 100 times slower.

@sabracrolleton prng-random-data will open a new file handle once for each object you create with make-prng. I assumed that's what you were opening multiple prng objects in your test.  @glv2 seems like a close-prng function would make sense then.

By the way, my with-open-file sample code above does not return random data. So useless for real purpose intended.
@luismbo . Yes, I was opening multiple prng objects in my actual code because I was triggering private thread errors otherwise. Will look back at my benchmark code to make sure that was the case. But I admit that my benchmark code was had too much other stuff going on in the authentication, so the actual time for the random-data method was probably a rounding error. As a result, not a useful answer to your request.

Running corrected code that does generate random data and just the random data function alone, I duplicate glv2's results.
I still need to be able to close the prng if someone is using ccl when they run low on file handles.

I added a finalizer for the os-prng class to close /dev/urandom (commit 36f3685aca747bd61a16b2e051c9fc50c042580d).
@sabracrolleton could you check if it solves your problem?

@glv2 Yes. This seems to solve ccl's problem. Thank You!

@glv2 Thanks for fixing the indentation on os-prng.lisp BTW. 😁


BUG-Variable not available in either the 'gui_instance' or 'main' module when they are in fact in __main__

Description and How to reproduce
My understanding is that you need to have your callbacks and variables in the same scope as where you instantiate the Gui object, OR at __main__ (the file which was called)
But I don't think that's happening. I am trying to instantiate the Gui in a separate file and have the callbacks and variables. imported to another main.py file, alongside the instantiated Gui object (the reason I need to do this is part of a bigger issue which I wont touch now).
Here's a mockup of the code in 3 different files:
callbacks_and_vars.py
from taipy.gui import notify

def test_callback(state):
    notify(state, "I", "Button was pressed")

TEST_VAR = "This is a test text"

gui_instance.py
from taipy.gui import Gui

GUI_OBJ = Gui()

main.py
from gui_instance import GUI_OBJ
from callbacks_and_vars import test_callback, TEST_VAR

GUI_OBJ.add_pages(
    {
        "/":"<|button|label={TEST_VAR}|on_action=test_callback|>"
    }
)
print(__name__)
GUI_OBJ.run()

I get the following output:
__main__
[2024-04-30 11:10:54][Taipy][INFO]  * Server starting on http://<IP_ADDRESS>:5000
WARNING:root:
--- 3 warning(s) were found for page '/'  ---
 - Warning 1: Variable 'TEST_VAR' is not available in either the 'gui_instance' or '__main__' modules.
 - Warning 2: Variable 'TEST_VAR' is not defined (in expression '{TEST_VAR}'):
'types.SimpleNamespace' object has no attribute 'TEST_VAR'
 - Warning 3: button.on_action: test_callback is not a function.
----------------------------------------------

I am particularly suspicious of the warning that says  - Warning 1: Variable 'TEST_VAR' is not available in either the 'gui_instance' or '__main__' modules., because that's not the case, everything is in the __main__ module.
Expected behavior
The GUI file should have the variables in its cope as they are present in __main__
Screenshots

Runtime environment
Please specify relevant indications.

Taipy version: 3.1.0
OS: Windows 11 but running on WSL

Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%
[ ] Create related issue in taipy-doc for documentation and Release Notes if relevant

Hi, for this use case of yours it is important to place everything next to each other so Taipy GUI can handle things properly. If you want to do multi pages, you can visit this section on the doc

Hi @dinhlongviolin1 , this unfortunately doesn't apply for my use case. The code here is a simplification.
The reason I am structuring it like this is because I need to declare the Gui instance before the callback due to me running a bunch of different callbacks in different threads that need the state variable.
I needed that back in Taipy 2.4.0, dont know if there's a better way to do this, I based that from https://docs.taipy.io/en/release-2.1/manuals/gui/callbacks/#long-running-callbacks-in-a-thread
In short, it's something like this:
gui_instance.py
from taipy.gui import Gui

GUI_OBJ = Gui()

callbacks_and_vars.py
from gui_instance import GUI_OBJ
from taipy.gui import notify, get_state_id, invoke_callback

def _test_loop(state):
     # (...) do stuff with state like state.refresh in a loop for a while
    notify(state, "I", "Button was pressed")

def start_test_loop(state_id:str):
    invoke_callback(GUI_OBJ, state_id, _test_loop, args=[])

def test_callback(state):
     loop_thread = threading.Thread(target=start_test_loop, args=[get_state_id(state), daemon=True)
     loop_thread.start()
     # (...) do other things in parallel

TEST_VAR = "This is a test text"

main.py
from gui_instance import GUI_OBJ
from callbacks_and_vars import test_callback, TEST_VAR

GUI_OBJ.add_pages(
    {
        "/":"<|button|label={TEST_VAR}|on_action=test_callback|>"
    }
)
print(__name__)
GUI_OBJ.run()

This is the only way of structuring the files that I can see that avoids a circular import.

But I am importing everything into main.py, so that should work no? Especially because the message says either at __main__ or at where the Gui was declared

Thanks for getting back to me. The thing that I don't really understand is why you need the Gui instance declare before everything else. The state within the Gui won't be there until the application is up. You can declare it and it will be executed later on. If you really want this structure, what I will suggest you trying out is this structure. Let me know if it helps.
gui_instance.py
from taipy.gui import Gui

GUI_OBJ = Gui()

callbacks_and_vars.py
from gui_instance import GUI_OBJ
from taipy.gui import notify, get_state_id, invoke_callback, Markdown

def _test_loop(state):
     # (...) do stuff with state like state.refresh in a loop for a while
    notify(state, "I", "Button was pressed")

def start_test_loop(state_id:str):
    invoke_callback(GUI_OBJ, state_id, _test_loop, args=[])

def test_callback(state):
     loop_thread = threading.Thread(target=start_test_loop, args=[get_state_id(state), daemon=True)
     loop_thread.start()
     # (...) do other things in parallel

TEST_VAR = "This is a test text"

page = Markdown("<|button|label={TEST_VAR}|on_action=test_callback|>")

main.py
from gui_instance import GUI_OBJ
from callbacks_and_vars import page as page1

GUI_OBJ.add_page("page1", page1)
print(__name__)
GUI_OBJ.run()

Hi, I need it for the start_test_loop, it needs the GUI already instantiated.
This structuer of yours is the same as the code as I just wrote in regards to variable scope isn't it? Everything is imported to __main__, but it won't work as everything needs to be in gui_instance, which is where GUI_OBJ is created.
The issue is that the error message that I get is  - Warning 1: Variable 'TEST_VAR' is not available in either the 'gui_instance' or '__main__' modules., so that code should indeed work

If you do it as I did and create a Markdown instance as a page, it will work since it will consider that a moudle of its own. We call that one Page Scopes. Please give it a try.

will do! Thanks

Wow, it worked! Thank you so much for this. Will try it on my bigger application and see how it goes but I am now much more optmist.

@dinhlongviolin1 in that case, however, do all pages need to be declared in the same file? Or can they be declared in different files then imported into main.py? And what about the callbacks, they need to be where exactly? Because youre not importing them into main.py so I imagine it needs to be within the same scope as the Markdown?

Yes, your assumption is correct. All the variables + functions should be included within the same file/module as the Markdown instance. You can add multiple Markdown instances in different files to create a multi page application.

I will close the issue. If you have any problem, you can open a new issue or contact me directly through<EMAIL_ADDRESS>

Hi @dinhlongviolin1, but I think the issue is still not addressed.
Sure we have made the code work for my case but this looks more of a workaround. The warning message states that the variable should be in either gui_instance or in __main__, but the warning does not go away even when the variable is explicitly imported into __main__. So I'd argue that either the message is wrong or the behaviour is not expected. Wouldn't you agree?


Allow producer socket to accept commands

Producers do only one thing now, send game frames over their web socket.
Many producer can connect to a single game room, where room owner can adjust who is player 1 and player 2 from the list of connected users, but at the moment, all producers are sending their game frame and the non-player 1/2 data is being dropped by the app.
Ideally, the app could instruct the producers to produce when needed. If you're a producer but not player 1 and 2, and are on standby, it's not necessary to send game frames at all.
At the very least, a connection-level command could be used to make the connection not send anything.
At a higher level, a producing-level command could let the producer not even do OCR if it's not needed to send anything since no-one is listening.
One more use case for producer to accept commands would be to synchronize a count down between the players.

Sort of done. The producer can accept command now for messages for TTS, and for webRTC to start/stop sharing webcam video feed


CachedOVFDeployer: allow to skip delta disk layer

The snapshot slows down regular clones when using 'rappid cloning' on a
netapp.

@agx I'm curious as to how you're doing rapid cloning. Can you explain what steps you're following that lead up to this?

On Wed, Jan 25, 2017 at 03:16:29PM -0800, J.R. Garcia wrote:

@agx I'm curious as to how you're doing rapid cloning. Can you explain what steps you're following that lead up to this?

We're basically invoking fog-vsphere's vm_clone (via Foreman) and have the VMWare /
Netapp integration do the rest.

@jrgarcia any news on this one?

@jrgarcia thanks for pulling this in. Are there any plans for a new gem release?

I'll put out a new release later today.

@agx I just released 1.11.1 with your changes included.

@jrgarcia  awesome, thanks a lot!


veewee requirements for running on Windows hosts

I couldn't find any explicit documentation for running veewee under Windows. The documentation at https://github.com/jedi4ever/veewee/blob/master/doc/requirements.md and https://github.com/jedi4ever/veewee/blob/master/doc/installation.md is mostly clear to follow, but seems to expect to run under a more unix-y environment then Windows is.
Some pitfalls I discovered while trying to get veewee running:

VirtualBox installation directory it not in the search path after installation, thus veewee fails when trying to remote VirtualBox via the VBoxManage command.Suggestion: document to add C:\Program Files\Oracle\VirtualBox (or whatever the installation path is) to the user search path.
Certain unix-like tools are expected to be available to veewee or the user, the ones I encountered so far:

tar is required for running e.g. veewee vbox export
ssh: after finishing building a box it's suggested to the user to use ssh to login. Or use the command veewee vbox ssh. Either fails if there no prior ssh available in the search path.

Since the available ecosystem is quite diverse for Windows in this regard, there are probably multiple ways to get the proper tools available.
By the comment from installation.md, I built veewee instead of installing as a gem, I also installed Git for Windows which, after manual action is taken, can provide at least the two missing tools I mentioned.
Cygwin is another option. But I've had problems with Cygwin and mixed path in my approach which I want to elaborate quickly: I had a cygwin installation in my search path available, thus the full range of unix tools was available to me (git, tar, ssh). Ruby however is supposed to be installed from http://rubyinstaller.org/ which has no correlation to cygwin per se. When performing the suggested installation, I had an error with bundle install because Windows Ruby and Cygwin Git used different Windows path notions thus couldn't work together. Based on this problem I faced, I found it more predictable to a) don't have cygwin by default in my search path and b) make Git bin\ path available to my search path. But in the end this is yet another personal preference.
Maybe for Windows user not having already set up a proper development environment, some "requirement suggestions" could be given.
(Most of this information is derive from my answer at https://github.com/jedi4ever/veewee/issues/612#issuecomment-15355515 )

What do I need to do to build Linux VM images on a Windows host?

Closing, no longer user either veewee nor windows.


Jumping-bug transitioning from last to first

There's a jumping-bug when transitioning from last to first item in an infinite slider
https://jsfiddle.net/paleite/s5uguo9s/
Steps to reproduce the problem
Click on next item, until you're back at the first item again.
====================================================================
What is the expected behaviour?
The same transition as everywhere else
====================================================================
What is observed behaviour?
Once you go from first to first, there's no initial transition, but then there is, causing the slider to jump
====================================================================
More Details

Which browsers/versions does it happen on?
Chrome 51 Mac
Which jQuery/Slick version are you using?
Slick 1.6
jQuery edge
Did this work before?
Can't tell

@leggomuhgreggo Hey, could I kindly ask you to point me to the duplicate? Thank you :)

Sure, here ya go


Requirement lowering cleanup and accept-invalid fix for @objc protocols

There isn't a whole lot you can actually state in the where clause of an @objc protocol, because there are no associated types. But you can state some invalid things, so make sure they get diagnosed.
While I'm here, clean up RequirementLowering.cpp to make the phase separation between requirement inference and requirement desugaring more explicit.

@swift-ci Please smoke test

https://github.com/apple/swift-driver/pull/1486
@swift-ci Please smoke test macOS

Please smoke test macOS

@swift-ci Please smoke test macOS


fix(controls): remove border, make the control look modern

🚀 What's changed?

remove the boder of controls

Mh... why? Can you give me some image what this change would look like and argue why it's better? 😄

Current:

New:

Style of current controls look "old", it's make me remember about Visual Basic, and does not consistant with other style of vue-flow, new design make it more modern.

Mh... I see. Looks like React Flow has border: none as well so the change seems acceptable :)

Will be released soon (sometime this week) 👍


Replace jquery-datetimepicker with native date input

This removes the jQuery plugin as well as the associated config options. Native input[type=date] does not require a language attribute as it is localized by default, except for the placeholder attribute for which I currently piggy-back the repo.issues.due_date_form localization option.
Implementation should pretty much match GH. Of note is that Safari does not provide a UI for this input type, but I don't think providing one is neccessary and GH did not bother either.
Before:

After:

Something very weird is going on, when I select any date, the date set is always +1 day from what I selected.

Works in my end:

Works fine on GitHub; the issue isn't with native date picker, the date selected and sent to server is fine, but date saved in database is always +1 day.

Weird. I see "2020-05-05" in the POST and on the rendered date afterwards.

Chromium sends
due_date: "2020-05-25T00:00:00.000Z"
And I see May 26 on rendered page.

In database it is set to<PHONE_NUMBER>, that's why. Gitea timezone is +2 for me so 23:59 on 2020-05-25 is indeed 26th of May.

Is this a Chrome bug? I thought type=date should always send yyyy-mm-dd.

MDN says:

Value | A DOMString representing a date in YYYY-MM-DD format, or empty

Chrome 83 does the right thing:

Why is there due_date in your example?

I'm testing it on issue due date, assuming it should behave the same way.

Due date also sends with time info so there is a bug there that is not present on milestone.

Indeed, works fine on milestone. Wonder why due date sends time.

It's wrongly passing the date to the JS Date contructor.

I tried changing it to send yyyy-mm-dd format but the backend rejects that. Definitely a separate issue.

Any more reviews? This is ready from my side.

Need to resolve conflicts @silverwind

Yeah, just noticed that, rebased.


Starting front-end improvements

Edited the Readme doc 😄
Added transition and new styling to button.
Added new elements to login page.

Please let me know if my general convention for adding code is okay? I didn't want to modify too much if you were not okay with that.

All changes updated.


Simplify PDB check

Follow up to https://github.com/giantswarm/kong-app/pull/323#discussion_r1360364945

Love it, thanks a lot! :)


component dependancies

In trying out different combinations of the extras, I found that Controls requires Math. Which makes complete sense, but the error 'null defined for v.x' threw me for a bit.
Is there a way of requiring/registering one component from another?
Alternatively, a note or dependency graph (I haven't tried other combinations) could be helpful.

Great point, thanks! Are you including extras with NPM and extras.controls.registerAll(), or cherry-picking files / directories? In either case there's probably a better way I should set this up..

Tried both options. Though it was an NPM problem for the longest time, so tried just including touch-control.js (the bit I needed for the test at hand) individually. That resulted in a blank scene (I’m pretty sure I referenced it incorrectly).
When I backed up and tried extras.registerAll() everything worked without issue. So I tried just extras.controls.registerAll() and got the error about v.x … and remembered seeing a math component. Added extras.math.registerAll() and was back up and running.

Should be all set on version 1.7.0 – extras.controls.registerAll() will include extras.math too.


HitsGroups could have overlapping frequency spans

Looking at how groups are created (and as concluded in a slack thread) HitsGroups could be improved so that it isn't possible for the frequency-span of groups to overlap.
Currently it is possible because only the last group in the vector of groups is considered when placing a hit, and a group's boundaries expand to express the extremes of its hits. So the following is possible:

The first hit is placed in a group
The second hit is placed in its own group because it does not overlap with the first
Subsequent hits are placed in the second group because they overlap with the group, but ultimately this group expands to overlap with the range of the first

Changing the algorithm to consider all groups, selecting the first overlapping one isn't foolproof because it could just expand the first group to overlap with a subsequent group.
The algorithm could be foolproof if it considers all groups and merges all candidate groups: the hit overlaps boundaries between these groups causing them to form 1.
Alternatively one could double-check the groups before returning them... but that seems less efficient.
It's unfortunately what I wrote some code for
```
for (size_t group_a = 0; group_a < groups.size(); group_a++) {
        size_t group_b = group_a + 1;
        while (group_b < groups.size()) {
            if (groups[group_b].low_index >= groups[group_a].high_index) {
                // group_b starts after group_a
                group_b += 1;
                continue;
            }
            if (groups[group_b].high_index <= groups[group_a].low_index) {
                // group_b ends before group_a
                group_b += 1;
                continue;
            }
            // group_b overlaps with group_a
            groups[group_a].hits.insert(
                groups[group_a].hits.end(),
                groups[group_b].hits.begin(),
                groups[group_b].hits.end()
            );
            groups[group_b].clear();
            groups.erase(groups.begin()+group_b);
            sort(groups[group_a].hits.begin(), groups[group_a].hits.end());
            group_b = group_a + 1;
        }
    }
```

If the merging of multiple candidate groups by a hit is something you're interested in I'm happy to write up the PR.

I think this is only a problem in the deduplication that happens on the GPU. Then it isn't so straightforward to change how we deduplicate.
For the CPU deduplication, I think we avoid this, because when we go through hits we first sort them:
https://github.com/lacker/seticore/blob/master/dedoppler_hit_group.cpp#L43
and sorting will go by the lowest index:
https://github.com/lacker/seticore/blob/master/dedoppler_hit.cpp#L57
which should mean that subsequent hits can never lower the lowest index of a group, because all subsequent hits have a higher lowest index than previous hits.


Bring back csv support

From https://github.com/MoritzR/fints2ledger/releases/tag/1.0.0:

There is no intermediate step anymore where all transactions are written to a csv file. This also means that importing from a csv file or exporting to a csv file is not supported anymore.

Thank you for your rewrite, I'm happy with current progress!
But this is the only breaking change that holds me back from upgrading (and testing), because I have csv export/file creating in my work flow and would like to stick to it if possible.
Is this sth what could get re-added without too much work ? If not I'll need to evaluate and change my current process.

Is this sth what could get re-added without too much work ?

No this is not a problem.
Which of these options would you prefer?

the program writes the transactions to a csv file and then continues with the process of putting them into a ledger journal
the program writes the transactions to a csv file and then exits
whatever idea you have

That's great !
I really liked the --no-csv and --no-ledger flags in the past.
My workflow was to first run fints2ledger --no-ledger to create the csv file, verify it, and then run fints2ledger --no-csv in a second step.

I have added two new flags in version 1.1.0.
They differ a bit from the previous tags but fit better with the current behavior of the app that no csv file is generated when no special flags for that are provided.

Just started to test the new version, but got hold back by #8  (reopened).

Works, I opened https://github.com/MoritzR/fints2ledger/issues/31 for a minor csv issue.

Thanks !!


Implement a new feature- Word Scramble

I would like to work on that issue under JWOC.

@Sneha6003 Can you elaborate what you want to implement?

In this game, letters are shuffled randomly, and you've to find the correct word using those letters within 30 seconds and there is also a hint provided for the user to guess the word.

That's a great idea, but as the website hosts the solvers for the games, can it be done in a way where the user provides the letters and the solver gives possible answers to the given letters?

Everyone if you have not joined the Discord server yet, please do so, as I will be sharing instructions on the solve-it! channel under projects.
Link to the server:
https://discord.gg/bcgZ9RZZ8r


New inspector text tweaks

What's your idea for a cool feature that would help you use OHM better.
This is a summary of feedback on the Inspector text fields and formatting.
Current Inspector

Suggested changes

These are just additional tweaks to existing tags (I'll work to add some more tags to support).
A couple of notes... this rendering suggests removing the field titles and just making the text stand alone. I think it'll work, but this probably needs a review from a visual designer, which I am not!
Here is a schematic of some of the tags used in the mockup above...

This is all achieved in https://github.com/OpenHistoricalMap/issues/issues/176


Can not evalate

Hello, when I tried to reproduce your results by running bash proofsearch.sh, I encountered the following error while initializing Lean-Dojo. My Lean-Dojo version is 1.1.2. Is there anything wrong?
"ExtractData.lean:375:10: error: invalid field 'mergeIntoOuter?', the environment does not contain 'Lean.Elab.ContextInfo.mergeIntoOuter?'
ctx'
has type
ContextInfo
ExtractData.lean:388:10: error: invalid field 'mergeIntoOuter?', the environment does not contain 'Lean.Elab.ContextInfo.mergeIntoOuter?'
ctx
has type
ContextInfo
"

The issue is likely caused by incompatible versions between LeanDojo, mathlib, or Lean. LeanDojo is not always backward compatible since we try to keep up with the latest version of Lean, and Lean itself is not backward compatible. You could re-try with the latest LeanDojo, but you may also have to use the latest version of mathlib (instead of 5a919533f110b7d76410134a237ee374f24eaaad  used by this repo).


Position/Rotation offset for collision shape

As a user, I would like to have an offset for the collision shape (relative to its entity GlobalTransform), so that I don't need to use parent-child hierarchy (with shape being parent) when the origin and orientation of the colision shape doesn't match the origin/orientation of my sprite/mesh.
There could be a BodyOffset { translate: Vec3, rotate: Quat } component.

Another useful feature is the ability to add different sensor collisions to the same entity as children. Right now, Sensor is a body type, so I don't know if you would be able to add it as a child and then add to it some children collisions (it doesn't seem to be really ergonomics anyway).

A small iteration on my design above. I will prbably make the RigidBody component mandatory (And not longer consider the entity as being a dynamic rigid body if the component is not found).
I found out that having RigidBody being an optional component quickly complicates things with this new design. Especially when it comes to handling body/shape removal. And I'm afraid that with this new design, if the RigidBody component is optional, it can lead to some surprising behaviors for the users.
Otherwise to answer you @yaymalaga:

Another useful feature is the ability to add different sensor collisions to the same entity as children. Right now, Sensor is a body type, so I don't know if you would be able to include it as a child and then add to it some children collisions (it doesn't seem to be really ergonomic anyway).

With this design it would be possible to create a sensor with multiple collision shapes.
commands.spawn_bundle(SpriteBundle { .. })
  .insert(RigidBody::Sensor) // <-- Make it a sensor
  .with_children(|children| {
    children.spawn_bundle(CollisionShapeBundle {
          shape: CollisionShape::Sphere { .. },
          transform: Transform { .. },
          ..Default::default()
    });
    children.spawn_bundle(CollisionShapeBundle {
          shape: CollisionShape::Cuboid { .. },
          transform: Transform { .. },
          ..Default::default()
    });
  });

If you want to have both sensor AND a physics body, then you'd have to create both a rigid body AND a sensor. Like this:
commands.spawn_bundle(SpriteBundle { .. })
  .insert(RigidBody::Dynamic) // <-- The rigid bdoy
  .with_children(|children| {
    children.spawn_bundle(CollisionShapeBundle { .. }); // <-- The *physics* collision shape

    children.spawn((
        RigidBody::Sensor, // <-- The sensor
        CollisionShape::Sphere { .. }, // <-- The *sensor* collision shape
        Transfrom { .. },
        GlobalTransform::default()
    ));
  });

I know this design is different from what rapiers does, as rapier put the "sensor" flag on the shape rather than the rigid body. But I personally find this design not-intuitive and I prefer the way Unit/Godot handle it: First, chose between rigid body/sensor, and the attach collision shapes.

@yaymalaga, yes it woud be possible to replicate this code using my implementation. Here is how it would be:
commands.spawn_bundle(SpriteBundle { .. })
  .insert(RigidBody::Dynamic)
  .with_children(|children| {
    children.spawn_bundle(CollisionShapeBundle { // <-- One *physics* collision shape
          shape: CollisionShape::Sphere { .. },
          transform: Transform { .. },
          ..Default::default()
    });
    children.spawn_bundle(CollisionShapeBundle { // <-- Another *physics* collision shape
          shape: CollisionShape::Cuboid { .. },
          transform: Transform { .. },
          ..Default::default()
    });

    children.spawn(RigidBody::Sensor)
       .with_children(|sensor_children| {
             sensor_children.spawn_bundle(CollisionShapeBundle { // <-- One *sensor* collision shape
                  shape: CollisionShape::Sphere { .. },
                  transform: Transform { .. },
                  ..Default::default()
            });
            sensor_children.spawn_bundle(CollisionShapeBundle { // <-- Another *sensor* collision shape
                  shape: CollisionShape::Cuboid { .. },
                  transform: Transform { .. },
                  ..Default::default()
            });
       });
  });

That being said, I actually aggree that it would be more ergonomic to define a "sensor" flag on the collision shape. I created a separated issue for it: #98


Error. Not able connect.

I've just installed plugin and wanted to create a data source, however no matter which method I try (local or remote request mode), I'm getting this ambiguous error.
After looking into grafana's logs I found this entry:
skip committing the transaction because it belongs to a session created in the outer scope
as well as
Applying default URL parsing for this data source type" type=volkovlabs-grapi-datasource url=
Data source URL doesn't specify protocol, so prepending it with http:// in order to make it unambiguous" type=volkovlabs-grapi-datasource url=
where url is not set in both cases

@jsarnowski96 What is your version of Grafana?
I will check this error for the local mode, which does not require it.
The remove mode requires URL and Token to connect as we described in the documentation: https://volkovlabs.io/plugins/volkovlabs-grapi-datasource/configuration/

In remote reuqest mode I tried both public https://grafana-instance domain as well as http://localhost:3000 with service account's token.
DS is being saved everytime, but it is unable to connect to Grafana API.

@mikhail-vl we are using Grafana 10.1.5 version

I might try using Editor-level token, maybe that's the root cause.

@jsarnowski96 We tested on 10.1.5 and it should work as expected in both modes.
Viewer token is enough to connect and display Annotations.

Do you see any errors in the Browser's Console or Network tabs?

@mikhail-vl nothing at all.

taken from DS JSON config:
"routes": [                     {                         "path": "api",                         "method": "GET",                         "reqRole": "Viewer",                         "url": "{{ .JsonData.url }}/api",                         "urlParams": null,                         "headers": [                             {                                 "name": "Authorization",                                 "content": "Bearer {{ .SecureJsonData.token }}"                             }                         ],                         "authType": "",                         "tokenAuth": null,                         "jwtTokenAuth": null,                         "body": null                     }                 ],

@jsarnowski96 When we test Data Source health, we do /api/health and /api/org to retrieve version and organization name.
One of them should be missing, this is why it's failed to do the health check.
Could you check the preview of org and health requests to see what is returned.
    /**
     * Check Health
     */
    const health = await this.api.features.health.get();
    const org = await this.api.features.org.get();

    /**
     * Connected
     */
    if (health?.version && org?.name) {
      return {
        status: DataSourceTestStatus.SUCCESS,
        message: `${Messages.connectedToOrg} ${org.name}. ${Messages.version} ${health.version}`,
      };
    }

@mikhail-vl API requests return correct org ID and OK DB status

Tested on Grafana v11.2.0. Works as expected with remote url and service token with a view access.
Please let us know if the issue still exists for you


Add report card to ecosystem

Add Report card & PDF to the ecosystem page

Please keep this in draft until further notice. The launch has to coordinate with media coverage


bug: layotto didn't set the metadata field in OnTopicEvent API

In https://github.com/mosn/layotto/pull/319 ,Layotto added a metadata field in appcallback.proto and modified the java SDK.
Unfortunately, we forgot to modify the .pb.go file and set this field in layotto runtime

This issue will be assigned to @RayneHwang


set_tblproperties

Adding the SET_TBLPROPERTIES command
DataBricks - https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-ddl-tblproperties.html#set-tblproperties
Athena - https://docs.aws.amazon.com/athena/latest/ug/alter-table-set-tblproperties.html

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

22 of 25 (88.0%)  changed or added relevant lines in 3 files are covered.
36 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.002%) to 87.787%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ast/ddl.rs
3
4
75.0%

src/parser/mod.rs
10
12
83.33%

Files with Coverage Reduction
New Missed Lines
%

src/parser/mod.rs
36
83.23%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
20091

Relevant Lines:
22886

💛  - Coveralls

Thank you @alamb !


When the git repository on storage is changed, the repository modal should also be updated

I saw some issues about "after pushing the git repository to Gitea, the Gitea web still shows the repository is empty" (I can not remember number the issue now ....)
And I meet the same problem today. This problem would be caused by some cases:

An error occurs during the git pushing/receiving
A user replaces the Gitea's empty repository manually

The reason behind the problem is that the repoModal.IsEmpty is out of sync of the real status of the repo.
This PR fixes the problem. When a user is viewing the repository web page, if the repoModal.IsEmpty is true, we check the git repository again to detect whether it is really empty.
This PR was tested on my side, and I can view the non-empty git repository correctly now.
Maybe we should fix more inconsistent data, please help to review and suggest, thank you

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7cc4449). Click here to learn what that means.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##             main   #18088   +/-   ##
=======================================
  Coverage        ?   44.89%
=======================================
  Files           ?      824
  Lines           ?    91575
  Branches        ?        0
=======================================
  Hits            ?    41114
  Misses          ?    43861
  Partials        ?     6600

Impacted Files
Coverage Δ

routers/web/repo/view.go
39.50% <28.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc4449...d3888f8. Read the comment docs.

TBH the IsEmpty flag is deeply broken and should be removed with the UI changed to manage to cope with empty repos.
For example it's possible for a repository to be non-empty by that flag but still 500 because there are no branches  - only tags -or the default branch is non-extant as it has been 0-pushed.

TBH the IsEmpty flag is deeply broken and should be removed with the UI changed to manage to cope with empty repos.

That's very helpful. I added more comments there.

trigger bot


run add platform android

I got this error:
Caught exception:
TypeError: Cannot read property 'indexOf' of undefined
at Object.checkForBower (/home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/lib/utils/bower.js:52:20)
at Object.run (/home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/lib/ionic/add.js:48:14)
at Promise.apply (/home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/node_modules/q/q.js:1078:26)
at Promise.promise.promiseDispatch (/home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/node_modules/q/q.js:741:41)
at /home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/node_modules/q/q.js:1304:14
at flush (/home/emory/node-v5.6.0-linux-x86/lib/node_modules/ionic/node_modules/q/q.js:108:17)
at nextTickCallbackWith0Args (node.js:453:9)
at process._tickCallback (node.js:382:13)
at Function.Module.runMain (module.js:449:11)
at startup (node.js:140:18)

Could you provide me with the output from ionic info from within your project directory? Thanks, this should help in troubleshooting.

Sure, anything.
Your system information:
Cordova CLI: 6.0.0
Ionic Framework Version: 2.0.0-beta.6
Ionic CLI Version: 2.0.0-beta.29
Ionic App Lib Version: 2.0.0-beta.16
OS: Distributor ID:	Ubuntu Description:	Ubuntu 16.04 LTS
Node Version: v5.6.0
I would like to report that I am using ionic build android and it is working fine.

Please update to beta.30. The issue has been resolved in commit 53bcbbbdb902616121bacafd08396b8245dd2f60.

Hi,
I am facing an issue even after updating to latest version of ionic
C:\Users\Ravi\Desktop\ionic\teacher_view>ionic platform add android
Error: Platform android already added.
Caught exception:
undefined
Mind letting us know? https://github.com/driftyco/ionic-cli/issues
C:\Users\Ravi\Desktop\ionic\teacher_view>ionic run android
Running 'run:before' gulp task before run
[14:41:31] Starting 'clean'...
[14:41:31] Finished 'clean' after 46 ms
[14:41:31] Starting 'build'...
[14:41:31] Starting 'sass'...
[14:41:31] Starting 'html'...
[14:41:31] Starting 'fonts'...
[14:41:31] Starting 'scripts'...
[14:41:32] Finished 'scripts' after 107 ms
[14:41:32] Finished 'html' after 114 ms
[14:41:32] Finished 'fonts' after 124 ms
[14:41:33] Finished 'sass' after 1.11 s
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(22,55): Error TS2339: Property 'description' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(23,55): Error TS2339: Property 'max_response_duration_min' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(24,55): Error TS2339: Property 'assigned_on' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(25,55): Error TS2339: Property 'soft_deadline_due' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(26,55): Error TS2339: Property 'hard_deadline_due' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(27,45): Error TS2339: Property 'responses' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/assignment-page/assignment-page.ts(28,55): Error TS2339: Property 'responses' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/class-group/class-group.ts(24,38): Error TS2339: Property 'chapters' does not exist on type '{}'.
TypeScript error: C:/Users/Ravi/Desktop/ionic/teacher_view/app/pages/teacher-home/teacher-home.ts(19,35): Error TS2339: Property 'class_subject' does not exist on type '{}'.
[14:41:47] Finished 'build' after 15 s
[14:41:47] Starting 'run:before'...
[14:41:47] Finished 'run:before' after 11 μs
Running command: "C:\Program Files\nodejs\node.exe" C:\Users\Ravi\Desktop\ionic\teacher_view\hooks\after_prepare\010_add_platform_class.js C:\Users\Ravi\Desktop\ionic\teacher_view
add to body class: platform-android
Error: Android SDK not found. Make sure that it is installed. If it is not at the default location, set the ANDROID_HOME environment variable.
Caught exception:
undefined
Mind letting us know? https://github.com/driftyco/ionic-cli/issues
C:\Users\Ravi\Desktop\ionic\teacher_view>echo %ANDROID_HOME%
C:\Users\Ravi\AppData\Local\Android\sdk
C:\Users\Ravi\Desktop\ionic\teacher_view>ionic info
Your system information:
Cordova CLI: 6.2.0
Gulp version:  CLI version 1.2.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.8
Ionic CLI Version: 2.0.0-beta.31
Ionic App Lib Version: 2.0.0-beta.17
OS:
Node Version: v5.10.1
C:\Users\Ravi\Desktop\ionic\teacher_view>


Accordions lack keyboard navigation

Describe the issue
Accordions lack keyboard navigation. They should be tabbable and pressing enter should expand/collapse like Bootstrap 5 does:
https://pp3uik--run.stackblitz.io/
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Microsoft Edge

This is fixed in Modus Bootstrap v2.


[WIP] Implemented SavedView model

Closes #1758
What's Changed

Screenshots

TODO

[ ] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example App Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Will have tests and documentation included in another PR


emoji counter

we need to see how many times emojis have been pressed

done, but not lined to API


Added optional flag on UpdateRecipients method to enable resend_envelope...

I needed to be able to update a recipient of an envelope and always send an email. I found the parameter required to do this (resend_envelope) in the API docs and have added it as an optional argument to the UpdateRecipients method.
Thanks.

Thanks @peterlord , note we have a SendReminder() method that would do that, but it's separate from updating a recipient (as in your case). Might be a nice thing to have the ability to do that in conjecture with the update as you suggested...

Yes I saw the SendReminder() method but as far as I understand that sends the reminder to all recipients? This change also gives a method of re-sending the email to just one of the recipients. Thanks.

ok, took your change. thanks @peterlord , let me know if you have other questions!

@peterlord , wanted to also personally invite you to our very first developer conference to be held this coming March in San Francisco. this is exactly the opportunity to meet me and other developers in DocuSign and talk shop. And the cost is very low. See all the information here http://momentum.docusign.com/san-francisco/dev-con/?mc=devcon-github


stored procedure nested block management

I'm running flyway command-line 4.2.0 against DB2 9.7 FIXPACK 7 on WINDOWS 64bit.
I tried to migrate just one SQL file containing a dummy procedure definition with nested BEGIN END block.

CREATE PROCEDURE dummy_proc ()
LANGUAGE SQL
BEGIN
    declare var1 TIMESTAMP;

    SELECT CURRENT_TIMESTAMP INTO var1 FROM SYSIBM.DUAL;

    BEGIN
        declare var2 DATE;
        SELECT CURRENT_DATE INTO var2 FROM SYSIBM.DUAL;
    END;
END; -- here I tried with and without the ";" char and also with "@" and --#SET TERMINATOR @ at the beginning

The statement correctly compile by running it on a  DB2 client. So, the result should be the same on flyway.
Instead, the migration failed due to a -104 error. The same applies to every procedure containing nested blocks.

The --#SET TERMINATOR case should now work correctly with the fix for #1690
However without that, nesting is indeed not supported yet.

Ok, thanks for your support.


Feature request: Opentrons anaconda package

overview

Anaconda is the most popular data science python platform https://www.anaconda.com/ , and part of the reason for that is its easy to use GUI virtual environment and package management system.  It would be nice to have the correct opentrons api able to be installed via this system.
current behavior

Currently opentrons does not appear in the anaconda package menu.

steps to reproduce

Open anaconda, click on environments, change the dropdown to ALL, and then type opentrons in the search bar.
expected behavior

Opentrons 1 API and opentrons 2 API should be able to be selected for installation into a virtual environment.

@utimcraig publishing the protocol API is something we'd very much like to do but is not technically feasible until a very large refactor / disentaglement of the current robot software monolith is completed. We'll update this thread when we have actual plans around publishing libraries

@utimcraig Good news, we're intending to publish our API on pypi in our next release. I'll update this ticket again when we've done so; it should be in the next couple of weeks. Thanks for your patience!

Hi @utimcraig, sorry for the lack of update here. We now publish the opentrons package to PyPI. Please see the Anaconda docs for instructions on how to install a PyPI library into Anaconda via pip


Restrict counts to only u8-u64

We don't seem to be gaining much by allowing, say, f64, and it leads to some questionable things like:
total_count = total_count + count.to_u64().unwrap();

Meaningfully handling the case where that doesn't work seems iffy.

This would also prevent people from using i* types, which are not much use since negative counts aren't used (and are semantically questionable, even if they were supported).


Is intentional Having those lifts with the same color, even with different states?

Related PR https://github.com/osrf/romi-dashboard/pull/157

It's not intentional, probably something is lost during the transition to react-components.

I'll grab this one


Added return of canvas element to createCanvas

For parity with p5js
And so the consumer does not need to know implementation details of obtaining a ref to the element
NOTE: not added to q5.min.js as I don't know how the file is minified.

Hi, thanks for the fix!
I just added the change to q5.min.js too.


Add missing space

Just noticed this while borrowing this snippet for my own efforts...

@normesta
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thank you!
#sign-off


Added support for objects as properties

With this change, any object that defines both get() and set() methods that return and accept an animatable value (number or string) can be used as a property for a target.
This is useful as one may want to use custom setters and getters along with the anime library. In my case, I am using a custom reactive library in which observable values provide custom setters and getters in order to emit update events to observers in each animation step.

Hey thank you for the PR, but this is too specific to a single (and rarely used) use case to be incorporated into the core.
Why not use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get instead ?


Clarify timeout method doc comment

Made a clarification to the timeout method on Capture<Inactive> since I spent a lot of time figuring out why the examples kept blocking for what appeared to be indefinitely on macOS.

This is an old PR and I'm not sure it clarifies anything. If you disagree, please update and reopen.


Doesn't autocomplete some deeply nested workspace headers

In my app A, I have a subproject B which is an umbrella framework. This in turns contains a subproject C which is another framework.
#import <C... doesn't autocomplete, yet Xcode picks the header up during compilation with no problem. There are no special search paths set.

The plugin does not alter the full completion list, only they way it is filtered and presented.
Can you check if you get the completion you are expecting when you disable the plugin?
If not, the problem lies withis Xcode itself rather than the plugin (and there is not much we can do).

Yes you are right, it's Xcodes problem really. Sorry for the false alert.

What you can try is to delete DerivedData (iirc there should be an option to do this under Window > Organizer > Projects) and restart Xcode, wait for indexing to finish and see if it gets picked up then.


How can component popover support not html tag

In my project, I used the velocity template and bootstrap framework for my admin management system, the code just like this:

In this picture, when I changed the script tag to div , the popover component works, so I wander if the popover component can support not html tag!

it's because javascript cannot execute/scan html-code inside script-tag.
you need to initialize them by yourself, eg: $(selector).popover(); after handlebar.js (?) parse complete.

Closed thanks to the comment of @anovsiradj


added models for skills collection

Adds Skill model for its API
Adds Skills property on User Object
Reference for its contract

@ankushdharkar I've made suggested changes.
Please check them and lmk your thoughts.

Reverting this PR, as this feature is being built as a stand-alone product, in Skill-tree
https://github.com/Real-Dev-Squad/skill-tree-frontend/
https://github.com/Real-Dev-Squad/skill-tree-backend/


Improvement: short git commit hash for version

Codecov Report

Merging #34 into master will increase coverage by 0.48%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   48.61%   49.09%   +0.48%
==========================================
  Files           4        5       +1
  Lines         216      222       +6
==========================================
+ Hits          105      109       +4
- Misses         99      101       +2
  Partials       12       12

Impacted Files
Coverage Δ

cmd/main.go
0% <0%> (ø)
:arrow_up:

version/version.go
66.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c766e...d36a9da. Read the comment docs.


Fix translate on password edit

Corrigido

Errado

I've prepared a stage to preview changes. Open stage or view logs.

Coverage remained the same at 75.85% when pulling 45bdb9e5d44c23408bc747735a07ac3ef89ff981 on jonatasrancan:master into 3ef469439ee6eb43d23e05dcc7e6680ce5079ef6 on gorails:master.


mate-screensaver build failed

Issue description
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.mate.mate-screensaver.x86_64-linux
mate-screensaver build failed (nixos-unstable)
Steps to reproduce
/etc/nixos/configuration.nix:
services.xserver.desktopManager.mate.enable = true;
then:
sudo nixos-rebuild switch --upgrade
Technical details

system: "x86_64-linux"
host os: Linux 4.14.54, NixOS, 18.09pre145679.dae9cf6106d (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0.4
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

@romildo

I can add to this the error from my local compilation:
gs-theme-manager.o: In function `gs_theme_info_new_from_matemenu_tree_entry':
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:244: undefined reference to `matemenu_tree_entry_get_name'
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:245: undefined reference to `matemenu_tree_entry_get_exec'
gs-theme-manager.o: In function `get_themes_tree':
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:405: undefined reference to `matemenu_tree_lookup'
gs-theme-manager.o: In function `gs_theme_manager_finalize':
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:432: undefined reference to `matemenu_tree_unref'
gs-theme-manager.o: In function `find_info_for_id':
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:277: undefined reference to `matemenu_tree_directory_get_contents'
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:284: undefined reference to `matemenu_tree_item_get_type'
gs-theme-manager.o: In function `make_theme_list':
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:342: undefined reference to `matemenu_tree_directory_get_contents'
/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src/gs-theme-manager.c:346: undefined reference to `matemenu_tree_item_get_type'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:868: mate-screensaver] Error 1
make[3]: Leaving directory '/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src'
make[2]: *** [Makefile:723: all] Error 2
make[2]: Leaving directory '/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1/src'
make[1]: *** [Makefile:536: all-recursive] Error 1
make[1]: Leaving directory '/tmp/nix-build-mate-screensaver-1.20.1.drv-0/mate-screensaver-1.20.1'
make: *** [Makefile:468: all] Error 2
builder for '/nix/store/c5bzj49wigvzskcyza7chhsfkbn0fpwq-mate-screensaver-1.20.1.drv' failed with exit code 2

@romildo Thanks!


Added CC-BY-4.0 License file

Added license file to project root.
This allows GitHub to properly detect the license. This, in turn,
allows GitHub to display the license on the project page and also
allows the project to be included in searches filtered by license.

Cool, thanks


OLS-373: link to Jira issue OLS-505

Description
Added link to Jira issue OLS-505
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-373
Closes #

/retest

/lgtm

/approve


Update start-finalExec

Added a check to see if WHITELIST contains a "-", if it does then parse it as a list of UUIDs rather than normal Usernames

NOTE: It's a crude fix and I am by no means good at bash. I just wanted to give it a shot.

To make it use Mojang's API instead
Change https://playerdb.co/api/player/minecraft/{} to https://api.mojang.com/user/profile/{}
Change '.["data"]["player"] | {"uuid": .id, "name": .username}' to '. | {"uuid": .id, "name": .name}'

The endpoint for Mojang to get Username from UUID is not reversible unlike PlayerDB's, so if you choose Mojang's instead you will need to add a warning to the whitelisting players section explicitly stating that it's either they use Usernames OR UUID's, not both and it NEEDS to be the dashed UUID format in order for it to pass the UUID check(idk any other way).
Wrong:
-e WHITELIST=Notch,ba2828f4f94646599543c41438e6a0e0

Wrong:
-e WHITELIST=Notch,ba2828f4-f946-4659-9543-c41438e6a0e0

Correct:
-e WHITELIST=Notch,Kyleee`

Correct
-e WHITELIST=069a79f4-44e9-4726-a5be-fca90e38aaf5,ba2828f4-f946-4659-9543-c41438e6a0e0

Should be enough of a note to warn users to use the dashed variant if they wish to use uuids.


Can't click gutter/line number to select entire line when line is already active with text cursor

Description
I am unable to click the gutter, where the line numbers are, to select the entire line if that line has the cursor in it. I have to click a different line number first, then click the line I want.
Steps to Reproduce

Place cursor on any line
Click line number for that line to select the whole line

Expected behavior: The whole line is selected.
Actual behavior: Nothing happens
Reproduces how often: Every time
Versions
1.19.0-beta3
macOS 10.12.6
Additional Information
I could not find any guide for starting the Atom Beta in safe mode.

Confirmed, though I'm not sure if this is expected behavior or not.

Looks like this is a regression in v1.19.0.
In v1.18.0 clicking the line number in the gutter selects the entire line and replaces any current cursors with a new cursor at the start of the line after the one clicked on.

I can't reproduce this. When I click a line number the results are exactly the same as in the animation you posted. Can this be closed?

I can reproduce this if I install an old Atom 1.19 beta but not on 1.19 stable so I guess this has been fixed.


Shift animation being too low

Hey, maybe make it so it's more like the 1.8.9 or 1.7.10 animation with the sneaking, because when you shift, it goes too low. This mod is so good though.

I released giz5 1.4.0 with soft shift animation
If you are satisfied with it please close the issue :)
https://github.com/Toshimichi0915/giz5/releases/tag/v1.4.0

Works great, this mod is so good. Thank you!


[Feature Request] Include Spotify Podcasts

I would like to see a podcast category, like you can find in the Spotify Integration entity.

Moved to discussions, raise your votes!


Support set_parallel_chunksize in the OpenMP threading layer

Numba 0.56.0 has chunking capabilities which works great using the default tbb threading layer. The new feature set_parallel_chunksize is beneficial for some work loads allowing better CPU utilization on many-core systems.
This is a feature request to support set_parallel_chunksize for the omp threading layer.

Thanks for opening the request @marioroy, I think this is possible for the OpenMP layer.

I gave omp chunking a try locally. Unfortunately, get_parallel_chunksize returns 0 always. So I tested by setting chunksize explicitly.
 numba/np/ufunc/omppool.cpp
--- numba/np/ufunc/omppool.cpp.orig	2022-07-25 15:15:41.725072600 -0500
+++ numba/np/ufunc/omppool.cpp	2022-07-26 08:28:20.164933908 -0500
@@ -135,6 +135,18 @@
     // but present to force thinking about the scope of validity
     int agreed_nthreads = num_threads;

+    unsigned int chunksize = get_parallel_chunksize();
+    if (chunksize == 0)
+    {
+        chunksize = (size + agreed_nthreads - 1) / agreed_nthreads;
+    }
+
+    // The above get_parallel_chunksize call always returns 0
+    // disregarding set_parallel_chunksize in application code.
+    // Therefore, set val explicitly for testing the omp pragma below.
+    //
+    // chunksize = 1;
+
     if(_DEBUG)
     {
         printf("inner_ndim: %zu\n",inner_ndim);
@@ -163,7 +175,7 @@
         // tell the active thread team about the number of threads
         set_num_threads(agreed_nthreads);

-        #pragma omp for
+        #pragma omp for schedule(dynamic, chunksize)
         for(ptrdiff_t r = 0; r < size; r++)
         {
             memcpy(count_space, dimensions, arg_len * sizeof(size_t));

Numba 0.56.0 Results:
parfor 11.284s omp #pragma omp for
parfor  9.026s omp #pragma omp for schedule(dynamic, chunksize)
parfor  8.736s tbb

There is a shorter benchmark via letter v for the Mandelbrot demonstration.
$ NUMBA_THREADING_LAYER=omp python3 mandel_parfor.py --config app.ini 1080p --num-threads=8
$ NUMBA_THREADING_LAYER=tbb python3 mandel_parfor.py --config app.ini 1080p --num-threads=8
$ python3 mandel_stream.py --config app.ini 1080p --num-threads=8
$ python3 mandel_queue.py --config app.ini 1080p --num-threads=8

press the letter 'v' when the window appears to start the benchmark
press any key to stop the benchmark, letter 'q' to close the window
this particular benchmark stops after reaching 144 levels

The set_parallel_chunksize feature is beneficial, especially for unequal work duration. The test machine contains an AMD Ryzen Threadripper 3270X processor. The queue (IPC via SimpleQueue) and stream (IPC via socket) demonstrations use the multiprocessing or threads module depending on the OS. They were created because thought that tbb and omp were slow when the project was created. I did not realize at the time that work was divided equally among workers.

N_thrs
4
8
16
32
63

omp
43.404
25.140
14.340
8.317
5.996

tbb
35.997
18.852
10.264
6.182
4.356

queue
36.184
19.238
10.481
6.225
5.004

stream
36.026
19.124
10.372
6.048
4.710

Thank you Numba devs! The new set_parallel_chunksize feature works well (tbb layer, not yet omp).
try:
    # Import set_parallel_chunksize if available (Numba 0.56.0).
    from numba import njit, prange, set_parallel_chunksize
except ImportError:
    from numba import njit, prange
    @njit('u4(u4)', nogil=True)
    def set_parallel_chunksize(chunksize):
        return 0


added support for kotlin version inject

Description

Describe the nature of the work / fix

Breaking Changes

PRs should not introduce breaking changes to existing functionality
if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)

0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
0.[x+1].0 Remove deprecated functionality

I have tested my changes on:
ReNative project directly:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

New project:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

Existing Project created with previous version of renative:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

Codecov Report

Merging #722 (87ccc84) into feat/engines-merged (1d35f48) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           feat/engines-merged     #722   +/-   ##
====================================================
  Coverage                20.47%   20.47%
====================================================
  Files                       84       84
  Lines                     5607     5607
  Branches                  1246     1246
====================================================
  Hits                      1148     1148
  Misses                    3340     3340
  Partials                  1119     1119

Flag
Coverage Δ

rnvunittests
20.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d35f48...87ccc84. Read the comment docs.


[TFLite] Optional Debug Tools can only support log in Desktop Computer

Hi TensorFlowers,
The tflite::PrintInterpreterState(interpreter.get()) in minimal.cc can only be used on computer system with desktop. Because it use printf style to output info in optional_debug_tools.cc, not the TFLITE_LOG in minimal_logging the better way supporting more systems. Besides, why not use something like std::stringstream to format info, that seems more general?

Hi @SunAriesCN, please feel free to submit a PR for your suggested changes, we will review it. Thanks!


Add instructions for vSphere HA interoperation

Adds a dedicated "vSphere HA" page
Includes setup instructions for vSphere UI and BOSH Director
Bumps agent_timeout in Resurrector to give vCenter time to detect the failed host
also fixed typo "Intializing"

Signed-off-by: Lyle Franklin<EMAIL_ADDRESS>#127290967

Blocking until the next release of vSphere CPI which include retry logic.

@ljfranklin dont wrap manually, editors know how to do that.

@cppforlife fair enough, fixed.


Wrong background detection when using 16color theme with the Noctu theme

Theme in question: https://github.com/noahfrederick/vim-noctu (works similarly to 16color, by using the terminal's 16 colours).
Although I'm using the dark version of the theme, Lightline's 16color is displaying its light version.
Going through the source, this is the line at fault: https://github.com/itchyny/lightline.vim/blob/master/autoload/lightline/colorscheme.vim#L246 together with, I believe, this setting: https://github.com/noahfrederick/vim-noctu/blob/master/colors/noctu.vim#L19.
Any way to override Lightline's background to the dark version?
Thank you!

What's the value of &background?

Not sure if this is what you're asking, but I have set background=dark in my init script.
I'm not very well versed in Vim and don't have access to my computer right now, but hope that's what you're asking.

:echo &background prints dark, right?

I apologise, I opened this issue just before my holiday. I don't have access to my computer to confirm but I believe that yes, it will echo dark.
I believe that if you simply install the mentioned theme (Noctu) and activate the 16color Lightline theme with background set to dark you will right away notice the issue: Lightline's 16color theme will display its light variant.

This should be fixed for now.


[5.8][BuilderTransform] All if sequences without else should call buildOptional

Cherry-pick of https://github.com/apple/swift/pull/63092

In cases like:
if (...) {
  <body>
} else if (...) {
  <body>
} else if (...) {
  <body>
}

Each branch should end with buildOptional wrapping buildEither because there is no covering unconditional else in the sequence:
var $__builder: <<Type>>

if (...) {
  $__builder = buildOptional(.some(buildEither(...)))
} else {
  if (...) {
    $__builder = buildOptional(.some(buildEither(...)))
  } else {
    if (...) {
      $__builder = buildOptional(.some(buildEither(...)))
    } else {
      $__builder = buildOptional(.none)
    }
  }
}

Resolves: rdar://104345754
(cherry picked from commit 43d83bb461c5db632866c3c51869c947e3e1be45)

Resolves #NNNNN, fix apple/llvm-project#MMMMM.

@swift-ci please test


question

no issue here you may close if need be but this is an awesome extension keep up the good work, but may i ask when it will this be available in the US store for v2? i tried updating via package but says not a trusted app i would love to use the favorite option

Hi, v2.0 should be released on the Microsoft Store today for everyone. There was some holdback on Microsoft's side, sorry for the delay.

I still have no idea how Sideloading works. Every time I try to do it, someone always claims the app is not trusted.


Selection Sort Article

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
I have added an article on Selection Sort in the Resources folder.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1541

Pls, review it @shraddhavp

Pls, review it @shraddhavp


[3.x] C# callback methods with parameters crash randomly

Godot version
3.5.beta.mono (7fcfde9)
System information
Win10
Issue description
My project crashed randomly in 3.5.beta. It happens when engine passes parameters to managed world.
E 0:00:01.113   GDMonoUtils::debug_send_unhandled_exception_error: System.StackOverflowException: The requested operation caused a stack overflow.
  <C++ 错误>      Unhandled exception
  <C++ 源文件>     modules\mono\mono_gd\gd_mono_utils.cpp:422 @ GDMonoUtils::debug_send_unhandled_exception_error()

May related to #53942 since it's commits about boxing/unboxing.
Steps to reproduce
It will randomly crash at starting:
public class Main : Godot.Node2D
{
    public override void _Ready() { }

    public override void _Process(float delta) { } // if remove this line, the project will run fine
}

More obvious case. When pressing any key, it will randomly crash:
public class Main : Godot.Node2D
{
    public override void _UnhandledKeyInput(Godot.InputEventKey ev) { }
}

Minimal reproduction project
No response

#53942 is indeed the cause, I looked a bit more into it and found that I forgot to initialize the params_buffer_size member :disappointed: so I went ahead and opened #56391 to fix it.

#53942 is indeed the cause, I looked a bit more into it and found that I forgot to initialize the params_buffer_size member :disappointed: so I went ahead and opened #56391 to fix it.

Fixed by #56391.


Remove '<,>' from the help menu

What are you trying to accomplish?
Remove '<,>' from the help menu because most of the students seem to be confused by them and include them in the commands
How are you accomplishing it?
Update text
Is there anything reviewers should know?
No

[x] Is it safe to rollback this change if anything goes wrong?

@prairir @amanpatel123

yeah i think this is a fair thing. people are so dumb because its litterally in the message about not including it.


Allow users to upload media to shared albums

Describe the enhancement you'd like
Allow users to upload media to shared albums: For example, if i have a trip/travel with other librephotos users on the same instance, to allow the other users to upload pictures/videos over the trip's Album to make the album "collaborative"
Describe why this will benefit the LibrePhotos
This will make Librephotos more collaborative on collective user activities.
A great and simple integration:

Is it posible to get some feedback on this? This feature would bring librephotos collaborative capabilities to another level. Would be also extremelly useful for families which travel together.

I just started with librephotos and this is the only feature I'm missing.

I played a little with this and I think I got a basic version working.
@derneuere would you be willing to include a simple implementation that only handles adding/showing photos and where not all edge cases are implemented (e.g. if a user is removed from a shared album, their pictures should be removed as well)?

Sure! :)


Connect to the wireless mouse,  the scrolling speed  is very slow when the scroll wheel slides

The mobile phone is connected to the wireless ( or wired ) mouse. The scrolling speed of the list is very slow when the scroll wheel slides. I don't know whether the application layer can adjust it.
my Flutter version: 1.12.13

@wanderingGuy
You seem to be on an obsolete version of Flutter. I recommend to upgrade to latest Stable version 1.22.1 and try again to see if it works as expected.
If problem persists after upgrading, please provide updated flutter doctor -v and a minimal complete reproducible code sample that shows the issue.
Thanks.

@darshankawar When I upgraded the flutter version to 1.22.1, the problem could still reproduce.
Here is my test code：
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';

class TestListPage extends StatefulWidget {
  @override
  _TestListPageState createState() => _TestListPageState();
}

class _TestListPageState extends State<TestListPage> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('List测试'),
      ),
      body: _buildCustomList(),
    );
  }

  //error
  _buildCustomList() {
    return ListView.builder(
      shrinkWrap: true,
      itemBuilder: (BuildContext context, int index) {
        return ListTile(title: Text('index $index'),);
      },
      itemCount: 100,
    );
  }
}

My mouse wheel is spinning fast, but the list slides very slowly, compared to the native app.

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.1, on Mac OS X 10.15.2 19C57, locale zh-Hans-CN)
    • Flutter version 1.22.1 at /Users/wandering/Documents/flutter_1.22.1
    • Framework revision f30b7f4db9 (5 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1
    • Pub download mirror https://dart-pub.byted.org
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/wandering/Documents/android-sdk-macosx
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/wandering/Documents/android-sdk-macosx
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.1

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

I tried to replicate this issue by trying to connect my wireless mouse with iphone, but for some reason, it couldn't detect the mouse, hence I am unable to verify this issue. Keeping this open for further analysis.

I see the same issue with Flutter 2.0.3 for any scrolling widgets on Android devices.
If you use the scroll wheel on a wireless mouse connected to the phone the views scroll really slowly compared to non-Flutter apps.  I also tried using an app to emulate a wireless mouse on a second device with the same results - apps like Chrome scroll much more for similar movements of the 'wheel' (I used this to test: https://play.google.com/store/apps/details?id=io.appground.blek).
flutter doctor - v:
[√] Flutter (Channel stable, 2.0.3, on Microsoft Windows [Version
    10.0.19041.928], locale en-AU)
    • Flutter version 2.0.3 at c:\flutter\flutter
    • Framework revision 4d7946a68d (5 weeks ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\Andy\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b01)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b01)

[√] VS Code (version 1.55.1)
    • VS Code at C:\Users\Andy\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.20.0

[√] Connected device (3 available)
    • Nexus 5 (mobile) • 08322a2b2132209d • android-arm    • Android 6.0.1 (API
      23)
    • Chrome (web)     • chrome           • web-javascript • Google Chrome
      90.0.4430.72
    • Edge (web)       • edge             • web-javascript • Microsoft Edge
      90.0.818.42

same here. thats my problem since flutter beta

Bumping this up as this it is really noticeable making the overall app feel really slow.

i wonder if it is a feature for now 😄

Mouse scrolling is really slow on desktop as well

In the meantime, this does the job on desktop. Don't forget to dispose() your controller
_scrollController.addListener(() {
      ScrollDirection scrollDirection =
          _scrollController.position.userScrollDirection;
      if (scrollDirection != ScrollDirection.idle) {
        double scrollEnd = _scrollController.offset +
            (scrollDirection == ScrollDirection.reverse
                ? EXTRA_SCROLL_SPEED
                : -EXTRA_SCROLL_SPEED);
        scrollEnd = min(_scrollController.position.maxScrollExtent,
            max(_scrollController.position.minScrollExtent, scrollEnd));
        _scrollController.jumpTo(scrollEnd);
      }
    });

any update, waiting for this fix

Any update on this issue for Android?

Any update?

Hi. Any update?

Seems fixed in flutter 3.7.0
Flutter 3.7.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b06b8b2710 (6 days ago) • 2023-01-23 16:55:55 -0800
Engine • revision b24591ed32
Tools • Dart 2.19.0 • DevTools 2.20.1

It's not fixed in Flutter 3.7.3, at least when using a mouse scrollwheel with the Android emulator on Linux. Each mousewheel event scrolls just a few pixels.

OK. Previously this bug had a companion bug which made all flutter desktop apps scroll slow in the list.
Maybe 3.7.0 only fixes that companion bug.

Also it's not just a list view that has the problem. It's anything scrollable, e.g. SingleChildScrollView.

waiting for this bug very long time

Before adding a comment here, please read https://github.com/flutter/flutter/wiki/Issue-hygiene#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs .
Comments like "any update" or "it's been a long time" do not help get the bug fixed. Instead they make the thread harder to read for anyone trying to understand and fix the bug.

Internal bug for huggsy: b/241573125

Flutter (Channel stable, 3.7.6)也是
@Hixie

This appears to be fixed on Flutter Beta 3.15.0-15.1.pre :tada:
Commit in the engine that fixes it https://github.com/flutter/engine/commit/28b8bd5d5d913d6c684df6ac980edc47c4bfc52f

This appears to be fixed.


[Danger] Update danger to 0.6.5 #trivial

Should fix the whole merge'd commit things stuff like

:+1:


MailDataRequired requires MailContent?

Issue Summary
I'm running into a problem with Typescript because it doesn't let me build an email without a content field. Is the MailDataRequired correct?
I never used to send content with my emails. Only substitutions. The content / templates live on your servers.
Code Snippet
export type MailDataRequired = MailData & (
    { text: string } | { html: string } | { templateId: string } | { content: MailContent[] & { 0: MailContent } });

Exception/Log
# paste exception/log here

Technical details:

sendgrid-nodejs version<EMAIL_ADDRESS>

BTW: 6.5.0 doesn't seem to have this weird { 0: MailContent } requirement, but still content is required.

watching this one too. updated my package and now not sure about this

Considering this a duplicate of https://github.com/sendgrid/sendgrid-nodejs/issues/1056, unless I'm mistaken.
#1041 introduced in the 6.5.4 release required one of text, html, or content.  It was later pointed out that templateId by itself should also be allowed. This was fixed as part #1053 but has yet to be released.

@childish-sambino this is still an issue on 6.5.4 the type is defined like this:
type MailDataRequired = MailData & (
  { text: string } | { html: string } | { content: MailContent[] & { 0: MailContent } });

That is making content a required property, is there a reason for that when MailData defines it as a conditional property?  I fixed it by passing:
{...mailData, content: undefined}

#1041 introduced in the 6.5.4 release required one of text, html, or content.

@rodrigomf24 Does mailData not have one of those?

@childish-sambino  no just a templateId and dynamicTemplateData

@rodrigomf24

It was later pointed out that templateId by itself should also be allowed. This was fixed as part #1053 but has yet to be released.

Is this fix released?

I just got version 7.0.0 and I still see this error
TSError: ⨯ Unable to compile TypeScript: src/email-templates/verification-email-template.ts(15,25): error TS2769: No overload matches this call.   Overload 1 of 2, '(data: MailDataRequired, isMultiple?: boolean | undefined, cb?: ((err: Error | ResponseError, result: [ClientResponse, {}]) => void) | undefined): Promise<...>', gave the following error.

If this has changed in 7.0.0, where is latest documentation for the send api please? Can't find much here. @childish-sambino
Thanks.

Yes, this was released in 6.5.5

@childish-sambino What do you think about exporting MailDataRequired from the @sendgrid/mail package as well?

@isaachinman I've no issue with that. If you want to submit a PR I can review it.

@childish-sambino I had a look around, and am unfamiliar with the module approach of export = being taken here. I'm not clear on how this can be expanded without introducing breaking changes.
Happy to help if you can point me in the right direction.

Think this line can just be updated: https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/mail/src/mail.d.ts#L37
Like this maybe:
declare const mail: MailService & { MailService: typeof MailService, MailDataRequired: typeof MailDataRequired };

No, that won't work as MailDataRequired is already a type. The use of declare const makes things slightly complicated.

Then just , MailDataRequired: MailDataRequired };?

No, what I am saying is that literally adds a MailDataRequired attribute to the default export. If you tried out your latest suggestion, you'd get a refers to a value, but is being used as a type error.
I haven't seen any other packages managing types with this sort of module approach, so I can't really offer you any suggestions. You need a way of supporting named exports.
Normally I'd expect to see something like this:
export default mail
export { MailDataRequired }

@isaachinman Think this (hack) should fix it: https://github.com/sendgrid/sendgrid-nodejs/pull/1102

still having the same issue, and proper workaround?

Still same issue with version 7.6.0

Not perfect, but it allows you to go past the error:
// @ts-expect-error: https://github.com/sendgrid/sendgrid-nodejs/issues/1057
await sgMail.sendMultiple(msg);

Was also having this issue with 7.6.0. Had to force compiler to ignore it.

Also having the same issue with version 7.6.1

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

Hello, any workaround for this ? thanks !


"Using a non-POJO as the root object may work, but is discouraged”

We're looking at using Typescript along with Ractive to help bring more structure to our codebase.
Ideally we'd want to use a strongly-typed Typescript object for the data but Ractive throws a warning:

If supplied, options.data should be a plain JavaScript object - using a non-POJO as the root object may work, but is discouraged”

Why is this discouraged?

Ractive only knows about objects and arrays. It isn't aware about the intricacies of your non-POJO object like accessors, private/pseudo-private members, etc.. It may work if Ractive can read, modify or remove properties to it like a POJO.
For non-POJO objects, we recommend reading about Adaptors. It's essentially a translation layer between Ractive and your non-POJO object so you can take advantage of your non-POJO data's features.

Ractive treats the root object as a dictionary, and at certain times may 'reset' it in a way that can blow up if it isn't a pojo. You can set any of the data below the root object as custom classes and you will probably not have any issues unless there are read-only props that get set out other things like that.
It's also not possible to have an adapted root object for many of the same reasons that custom classes are strongly discouraged as root data.


Classifier does not work with non-square face size

When initializing the classifier using
        classifier = Classifier.getInstance(getAssets(), height, width);
giving unequal width and height causes the app to crash when it tries to perform facial recognition. I was wondering why this occurs.

The file is changed now.
But if you want to change input size, you must resize input tensor before inference.
interpreter.resizeInput(0, new int[]{1, height, width, 3});


Computational Details

Hi,
Thanks for creating this project.
I was trying to train this model and wanted to know the configuration details of the machine on which you trained this (GPU type and memory, CPU cores, RAM used, etc). Also, it would be great if you can tell how much time it took for you to train this model.
Thanks a lot.

I trained this model on the machine that has Xeon CPU (4 cores), 32GB RAM, and GTX 1080 GPU. The training time was approximately 6 hours.

Thanks a lot for your help


Blurry text when scrolling

It's much easier to see if you open the GIF in a new tab.
Basically what's happening is whenever I select enough text to scoll the editor (ie the scrollbars are moving), the text becomes blurry and stays that way until I scroll a bit out of its range and then back (guessing this has something to do with tiles).  Both horizontal and vertical scrolling are affected.
Also tested in safe mode.  Windows 10 x64, Atom 1.0.19, though this has been happening for a long time.
/cc @as-cii

Ugh, tiling strikes again.
@50Wliu: thanks for reporting this, I guess all of these headaches will be over as soon as we switch back to a single layer. This is going to happen in a near future, I think.

I can no longer reproduce this on Atom 1.2.0-dev-6495f1a.


Issue when using $unset on updates

I think there is probably an error in how $unset is handled, maybe because it has no value and now we are not doing a find after update so $unset updates are not reactive.
Assemblies.update({ _id: poll.assemblyId }, { $unset: { currentActivePollId: true } });

This piece of code is not reactive using this package, but it is when using cultofcoders one.

You're right, the way this redis-oplog works is by sending the changed fields via redis to the other instances and internally to change listeners. The way the original redis-oplog does things, is by querying the DB for the new doc. I don't use $unset in my app so never faced this.
A solution would be to {$set:{field:undefined}} -- let me play with it a bit and see if I can fix this easily

@pmogollons
I made a change to handle $unset properly, can you pull and try it again?

Still not working, let me create a reproduction so that it can be tested correctly.

Ok, so something else is happening downstream. It worked on my soon.
The reproduction repo will make sure I solve it right, thanks!

@pmogollons
Any news? Is it working now?
As mentioned, it worked on my side

Hi, sorry for the delay. Here is the reproduction in its simplest form. Just a meteor create --react with a few changes and redis-oplog package added.
https://github.com/pmogollons/ro-issue

Thanks @pmogollons, that repo was very helpful indee
So the bug was in observers which failed to see the cleared fields. Pull now pls and try again
Thanks

Awesome, it works now. And the code looks more understandable (not that I do undersand it completly yet) 😂
Ill start testing this in staging and let you know if something else comes out. Thanks!

Thanks - it took a long time to understand the original code, many authors, conflict of approach, dead code etc.
I did my best to clean it up.
The changes are to

Send in the messages list of cleared fields and
Set these fields 'undefined' in redis listener to trigger cleared message in observers to client.


Header values cannot contain semicolons

The header parsing precludes headers with values that have semicolons. The following code will fail header parsing because it tries to split on semicolons before processing the name/value pairs:
boom -h "cookie:foo=1;bar=2" http://example.com

this is fixed in PR #89
@rakyll , could you have a review on let?
thanks


rtlamr2mqtt-addon version is still 1.3.3

The rtlamr2mqtt-addon version has not been updated since 1.3.3.  This appears to cause the addon to not receive updates.

You are absolutely right.
I have to add a way to bump the version when I create a new tag/release.
Thank you for your help!


GRID driver link doesn't point to the latest version

Hi,
Currently the GRID driver link (https://go.microsoft.com/fwlink/?linkid=874272) points to the NVIDIA-Linux-x86_64-460.32.03-grid-azure.run, which is not the latest version(NVIDIA-Linux-x86_64-460.73.01-grid-azure.run) and failed to be installed in RHEL-8.4 NV6 VM. The latest version(NVIDIA-Linux-x86_64-460.73.01-grid-azure.run) can be installed in RHEL-8.4 NV6 VM successfully. And due to this doc it seems that the https://go.microsoft.com/fwlink/?linkid=874272 should point to the latest version. Could anyone please fix that? Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e03790a-1bf9-146d-704b-6816d475064b
Version Independent ID: ad5f6be7-e089-161f-306c-39d10e7ab0a0
Content: Azure N-series GPU driver setup for Linux - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/n-series-driver-setup.md
Service: virtual-machines
GitHub Login: @vikancha-MSFT
Microsoft Alias: vikancha

@yuxisun1217 Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@vikancha-MSFT Can you please check and add your comments on this doc update request as applicable

@yuxisun1217 Thanks for the feedback. We are updating the fwd links. In the mean time you can get the latest driver at https://download.microsoft.com/download/b/d/d/bdd729ee-5003-4427-ace4-a7b9172b2e29/NVIDIA-Linux-x86_64-470.63.01-grid-azure.run

I believe this was resolved but never closed. Feel free to ping me to reopen if the issue still exists. #please-close


perf: optimize the modification of rollout to httproute header

Ⅰ. Describe what this PR does
rollout 对 httproute 的修改存在缺陷，面对 header 的或逻辑并没有支持。
Ⅱ. Does this pull request fix one issue?

是的
Ⅲ. Special notes for reviews

https://github.com/openkruise/rollouts/issues/138

还存在问题，我再看看

Codecov Report

Merging #137 (d9f5779) into master (5807b5b) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   44.66%   44.66%
=======================================
  Files          47       47
  Lines        4865     4865
=======================================
  Hits         2173     2173
  Misses       2335     2335
  Partials      357      357

Flag
Coverage Δ

unittests
44.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/trafficrouting/network/gateway/gateway.go
53.27% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

测试没问题了，镜像地址：registry.cn-hangzhou.aliyuncs.com/zhangqihang/kruise-rollout:v0428-1

这个问题放置好久了哇，我还需要做些什么嘛

测试没问题了，镜像地址：registry.cn-hangzhou.aliyuncs.com/zhangqihang/kruise-rollout:v0428-1

sorry for the delay, we miss the PR, the PR looks generally good, but i don't have time to review it yet. Anyway, you can rebase the master to make the e2e pass

/lgtm

The inspection has not been passed, this pr is too messy, I try to submit a new pr, this one is closed https://github.com/openkruise/rollouts/pull/154

/lgtm

/approve