Passing context_fn to torch.utils.checkpoint results in errors when using torch.compile

In transformer_engine.pytorch.distributed.checkpoint TE passes context_fn to torch.utils.checkpoint.checkpoint even if no context_fn was passed by the user to original function, in which case noop_context_fn is used. It's breaking when we are using torch.compile, for two reasons:

PyTorch is wrapping context_fn in LazyVariableTracker, which results in the error thrown here, as LazyVariableTracker is not checked for in the if chain.
Even if we modify Pytorch to check for LazyVariableTracker e.g. by adding to the if chain

            elif isinstance(ctx, torch._dynamo.variables.LazyVariableTracker) and ctx.value == noop_context_fn:
                context_fn = noop_context_fn

the error is still thrown here, as PyTorch only allows context_fn in combination with torch.compile to be passed when using _experimental_support_context_fn_in_torch_utils_checkpoint config.
Seems like the best option, which doesn't require modifying PyTorch and using experimental config, is to simply not pass context_fn to torch.utils.checkpoint.checkpoint when context_fn is not specified by the user. I confirmed that this solution works with torch.compile without an issue.

@denera Could you look into this?
Also FYI @ptrblck.

Hey @denera, thanks a lot for looking into it. It's useful to know that other context managers also have issues with torch.compile combined with te.checkpoint.
I just wanted to clarify one thing - there is a difference between passing context_fn=noop_context_fn and not passing context_fn at all. This difference comes from the fact that context_fn is not part of kwargs in this check, which means that no context manager is used at all.

@MaciejBalaNV It looks like the line you linked is checking for both 'context_fn' in kwargs and kwargs['context_fn']=noop_context_fn, so passing in context_fn=noop_context_fn here should be exactly equivalent to not passing a context function at all. Am I misunderstanding something there?

The thing is that kwargs can be wrapped in VariableTrackers when using torch.compile. For example that's why we have this check in PyTorch:
            if isinstance(ctx, torch._dynamo.variables.UserFunctionVariable):
                context_fn = ctx.fn

In my experiments, the context_fn was wrapped as LazyVariableTracker. It means that kwargs['context_fn'] wasn't equal to noop_context_fn.


Typing speed test

I would like to add a python script on typing speed test.
Details:
We have to input sentences and it would show the time taken for typing, wpm and accuracy.

i want to work on this

@kaustubhgupta is this issue closed?

Nope, you can start working on this

@kaustubhgupta  ok I will start working on this tomorrow.... Deadline for this?

total 7 days, I will ask for updates on 3rd day

@dhriti987 updates?

it will be finished by day after tomorrow ......  by the way what you suggest I should make UI with Tkinter or pygame or anything else?

Tkinter is a Good option. You can also checkout PyQt5 or if you want to explore completely different framework, then you can check kivy.

I am going with Tkinter...  for sentences should i use text file or another python file?

text file

it's finished

need any changes?

@dhriti987 Make the PR and then only I can review the cord and suggest changed (if needed)

i have just included 10 sentences is it ok?

@kaustubhgupta  review it


[TextField] Correct typo in TypeScript export declaration

@caghand Thank you!

Sure, gladly!  Big fan of this project. :)


ResourceTemplateForm.test: skip tests giving false positives

These are just like the false positives I found for PropertyTemplateOutline.test.  I put "expect(1).toBe(2)" in the blocks with expect statements, and these tests passed.  :-(
I also corrected the misspelling of fulfill and got rid of unused imports.

Coverage decreased (-2.007%) to 75.986% when pulling 8d039d5ffcf3ad1af0fdb9a1e301d90c4cbb5604 on skip-false-positive-tests into d661314a9bd700a0809277cbcb606ea5f3019591 on master.


api feature level: Bump level for peer_add/peer_remove.

Testing plan:
GIFs or screenshots:

I went ahead and merged this to unblock Neil and any folks affected by the test flake.


Why do I get a 404 in access.log ?

Hello,
when I request  in my web browser "/admin/themes/mundana", it works, but in the file /var/log/apache2/access.log, i find this line
...... [03/Apr/2024:13:12:01 +0200] "GET /admin/404 HTTP/1.1" 404 23104 "https://xxxxxx.dd/admin/themes/mundana" "Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0"
This, doesn't happen with the Quark theme. What could I have forgotten

This must be a problem for me, because it doesn't happen on another site with Mundana, installed in a subdomain of the same server.

If i remove custom favicon and logo from the Mundana's admin page, 404 goes away.

It's not unique to mundana, it's the same with Quark whenever I put a custom logo.

How about you open a thread on the official Grav forum, to see what responses you get. This 404 error has more to do with the server configuration (Apache, etc) than the issue.

Yes, i'll do that.

Yes, i'll do that.
But, is it the same on your server ?

Yes, both on local server and online server

Thanks for checking.
Now I know that my server settings are not to blame.


WIP: fixing compilation on Mac

Won't really pass tests until we merge: https://github.com/grafana/beyla/pull/1105

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.10%. Comparing base (74ba237) to head (0cac249).

:exclamation:  There is a different number of reports uploaded between BASE (74ba237) and HEAD (0cac249). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (74ba237)
HEAD (0cac249)

unittests
1
0

k8s-integration-test
1
0

integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1107       +/-   ##
===========================================
- Coverage   81.91%   37.10%   -44.81%
===========================================
  Files         140      139        -1
  Lines       11450    11441        -9
===========================================
- Hits         9379     4245     -5134
- Misses       1548     6765     +5217
+ Partials      523      431       -92

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
37.10% <100.00%> (+0.06%)
:arrow_up:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs: move docs outside of readme

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #192

PR #193   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 18, 8:53 PM: Graphite rebased this pull request as part of a merge.


$ myth analyze  Not working

After installing mythril
when i use command myth, its not working
Traceback (most recent call last):
File "/usr/local/bin/myth", line 5, in
from mythril.interfaces.cli import main
File "/usr/local/lib/python3.9/site-packages/mythril/interfaces/cli.py", line 26, in
from mythril.mythril import (
File "/usr/local/lib/python3.9/site-packages/mythril/mythril/init.py", line 3, in
from .mythril_config import MythrilConfig
File "/usr/local/lib/python3.9/site-packages/mythril/mythril/mythril_config.py", line 14, in
from mythril.ethereum.interface.leveldb.client import EthLevelDB
File "/usr/local/lib/python3.9/site-packages/mythril/ethereum/interface/leveldb/client.py", line 13, in
from mythril.ethereum.interface.leveldb.eth_db import ETH_DB
File "/usr/local/lib/python3.9/site-packages/mythril/ethereum/interface/leveldb/eth_db.py", line 3, in
import plyvel
File "/usr/local/lib/python3.9/site-packages/plyvel/init.py", line 6, in
from ._plyvel import (  # noqa
ImportError: dlopen(/usr/local/lib/python3.9/site-packages/plyvel/_plyvel.cpython-39-darwin.so, 2): Symbol not found: __ZTIN7leveldb10ComparatorE
Referenced from: /usr/local/lib/python3.9/site-packages/plyvel/_plyvel.cpython-39-darwin.so
Expected in: flat namespace
in /usr/local/lib/python3.9/site-packages/plyvel/_plyvel.cpython-39-darwin.so

@norhh Sure thanks!!


Setting default-directory for compilation mode

When I open source files, emacs always automatically sets the current directory to /path/to/crate/src, so after I compile and type M-g n to jump to the first error, I am prompted to enter the appropriate directory, which I must change to /path/to/crate.
To avoid the prompt, I must change the current directory after opening every source file.  Is there any way to get rust-mode to do this automatically?

You can look at https://github.com/kwrooijen/cargo.el , it parses cargo metadata and runs set right root directory for compilation-mode


Fix missing space in cn/sections/projects.yaml

Issue
Fixes #214
Description

Test Evidence

thanks

thanks


Add options to image attribute

Add options to image attribute

🙏🏻
Made one small tweak, but thanks for this!


Timings are off on the first few lines

On the first few lines it seems to rapidly put some of the lines, then hold one line for 30 seconds, after that everything is normal. Notice that these lines happen exactly on the second, which makes it already indicate that it's a bug.
Example:
1
00:00:00,000 --> 00:00:01,000
 Okay.

2
00:00:01,000 --> 00:00:02,000
 Delete a flight plan.

3
00:00:02,000 --> 00:00:03,000
 Autopilot off.

4
00:00:03,000 --> 00:00:04,000
 Altitude 3000.

5
00:00:04,000 --> 00:00:05,000
 Okay.

6
00:00:05,000 --> 00:00:32,500
 Contact surface until aboard.

7
00:00:32,500 --> 00:00:38,500
 ♪♪

8
00:00:38,500 --> 00:00:41,039
 -♪♪

9
00:00:41,039 --> 00:00:43,079
 Who is that?

Which OS are you using?

OS: Windows 11

Hi @JeremyMahieu .
Is there any noise or singing in the file?
Then it might sometimes have a very inaccurate timestamp, like this. (which I've also experienced sometimes).
And from what I've found, using audio files over video files gives better results.
Like #28, it seems to be a problem with the Whisper model itself, not with my Web UI.
So I'll close this soon!

Yeah exactly. This was with an mkv file and using an extrackted audio track gives slightly different timings, but both are innacurate for the first few lines.
The audio starts with some lines and then an intro sequence with music.


THRIFT-3667 C++: Add TLS SNI support to clients

For C++ OpenSSL clients, set the TSocket's requested hostname as the TLS extension "server_name" to support TLS SNI. This reveals the requested hostname within the clear-text TLS request, but supports most TLS-proxy services that support multiple virtual hosts.

committed 937228e030569bf25ceb379c9491426709792701 could you please close the PR

Thanks Roger!


Remove unnecessary database queries

See #111.
The config change is required to have a usable default (also brings the code in line with the documentation which states that 'files' is default).

@andersLAL Thank you for your contribution. This will be available on release 2.3.4


Price doesn't get filled in the Trust wallet / Cipher wallet apps.

When scanning the QR in the Trust wallet & Cipher wallet apps, the price field is not filled in.

After research this seems to be an issue where this library uses "value" and most wallets only support "amount".
Could you create the possibility to use "value" in the QR code instead?

Actual usage of the QR protocol is currently very fractured and gives different and unexpected results based on which wallet the user uses.

Toshi wallet crashes on QR code scan (at time of writing 2018-07-24)

None of the wallets we tried use the value field...

For now I have forked the package here and changed the field called value to amount. If there would be an update in the future to have an option to also support the amount field next to the value field, that would be great!

Seriously I can't find any wallet that can support more than the address and amount field in QR code.
Sending Token is impossible.
Hope someone can shed some light on this issue. TIA

Yeah, there is no source of truth for QR code links, so there is no way to implement proper price field for multiple wallets. Looks like the industry needs someone to stand up, create a standard and gather as many companies around it as possible. Until that – I don't think we can do much.


Conditionally compile error strings in NimBLEUtils

Introducing #define NIMBLEUTILS_NO_STRINGS to conditionally compile error strings saving 8,484 bytes of program memory (with of course less error information as drawback)

I did not test this yet, but generally spoken: I like the idea.

@Jeroen88 LOL, you are crossing out my todo list quickly. This was to be done soon as well, I've just been focused on fixing up more functionality first.
Just a couple comments, looks good otherwise, thanks!

My pleasure!

Should not here CONFIG_BT_NIMBLE_DEBUG from nimconfig.h be used in stead off NIMBLE_ENABLE_DEBUG_TEXT?

I'm actually working on that now, need a better solution for use in IDF, I'll get back to you on this soon.

@Jeroen88 We will need to change option names to these:
CONFIG_NIMBLE_CPP_ENABLE_RETURN_CODE_TEXT
CONFIG_NIMBLE_CPP_ENABLE_GAP_EVENT_CODE_TEXT
CONFIG_NIMBLE_CPP_ENABLE_ADVERTISMENT_TYPE_TEXT

Then in nimconfig.h add:
#define CONFIG_NIMBLE_CPP_ENABLE_RETURN_CODE_TEXT 0
#define CONFIG_NIMBLE_CPP_ENABLE_GAP_EVENT_CODE_TEXT 0
#define CONFIG_NIMBLE_CPP_ENABLE_ADVERTISMENT_TYPE_TEXT 0

Also we will probably need to change the conditional checks to #if instead of #ifdef to test the define value.

Since you're working on it and know exactly what you want, isn't it easier if you do it?

I was working on it in IDF so I thought I'd post what I got here. But sure I'll do it.

Thank you! :)

Done, if it works for you could you close this please?

I checked:
Without return code texts
Sketch uses 547710 bytes (41%) of program storage space. Maximum is 1310720 bytes.
Global variables use 25648 bytes (7%) of dynamic memory, leaving 302032 bytes for local variables. Maximum is 327680 bytes.

With return code texts:
Sketch uses 555430 bytes (42%) of program storage space. Maximum is 1310720 bytes.
Global variables use 25648 bytes (7%) of dynamic memory, leaving 302032 bytes for local variables. Maximum is 327680 bytes.

So 7,720 bytes difference. It is working, thnx!


Fix the navbar links so control-clicking opens them in a new tab

The default behaviour for control-clicking links is to open them in a new tab., but this behaviour is currently broken in FCC's navbar for the Map, Chat and Wiki links when the page is viewed on a larger screen.
(closes #7493)
This change fixes it by checking the event.ctrlKey flag, and if true it allows the default behaviour for the link and does not pull out the side bar.

:sparkles: :sparkles: LGTM. :sparkles: :sparkles:
Tested on Chrome, Firefox & IE on Windows.
Can anyone confirm if this works on Safari, etc. on OSX
/cc @hallaathrad

Hey @george-stepanek
Nice work. One more thing is needed to get this into production.
On OSX, the cmd key is used instead of ctrl so in order to get it to work for both, you'll need to check for the ctrlKey and the metaKey attributes. You can read about it here

Thanks, @BerkeleyTrue, I have amended the commit per your recommendation...

Thanks, @BerkeleyTrue and @hallaathrad, I've just now included that change...


Add CI with Browserstack

@paldepind to have everything here
AFAIK @staltz was made owner of an organization in Browserstack, so he could sent me an invitation link. I then added a bot account (one-time-use-email + some password I saved) to not use my personal account in the CI. I would suggest you too add a Bot user and email me the credentials of it.
Then I changed the browser tests from testem to karma. This is not 100% needed, but karma makes debugging (with or without browserstack) easier.
Other than that you would have to add travis as github app. The rest I can do via PR

@jvanbruegge I've sent you an invitation to the email in your GitHub profile 👍

@paldepind I accidently removed myself from the org, can you add me again?

Sure, no problem :smile: I've sent another invite to the email address in your GitHub profile.

Thanks


4.0.4 contains breaking change to ES6 modules

<EMAIL_ADDRESS>uses ES6 modules in it's main which causes it to throw the following error when run in node:
export default function typeDetect(obj) {
^^^^^^
SyntaxError: Unexpected token export

I assume this was accidental, since it's a massive breaking change in a patch release making chai unusable. You may wish to unpublish 4.0.4.

We'll get this fixed ASAP.

4.0.5 will be released in the next few minutes, which should fix this.


Create a basic test for use in the release process

This adds basic operational tests to ci/test.sh. For each specified stack, it will run appsody test and appsody build to make sure tests can run, and the final OCI image can be built correctly.
Verify behavior:
STACKS_LIST=incubator/java-spring-boot2 ./ci/test.sh

Checklist:

[X] Read the Code of Conduct and Contributing Guidelines.

[X] Followed the commit message guidelines.

N/A Stack adheres to Appsody stack structure.

See #323


Use subclassing of skos:Concept

When working with and defining the use of concepts, define a subclass of skos:Concept to represent the concepts (or enumerations) you need. So instead of just referring to skos:Concept we define a well defined class, making it easier to refer to in an explicit and unambiguous way.
Examples of classes defined as subclasses of skos:Concept:
From Organization Ontology (ORG):
https://www.w3.org/TR/vocab-org/#class-role
From Data Catalog Vocabulary (DCAT):
https://www.w3.org/ns/dcat#Role
From Data Quality Vocabulary (DQV):
https://www.w3.org/TR/vocab-dqv/#dqv:Dimension
https://www.w3.org/TR/vocab-dqv/#dqv:Category

This in addition to having appropriate skos:inScheme, right?


Could not load component list:Error certificate has expired *** Could not merge components ***

I can't install Microsoft.Bot.Components.Recognizers.CLURecognizer. Every time I try to install it throws the error. I tried installing the latest nightlies with no success.
I am using Release 2.1.2, SDK runtime packages 4.12.0
I am using Chrome on Windows.
To Reproduce

Go to the package manager
Search for Microsoft.Bot.Components.Recognizers.CLURecognizer
Try to install
See error

Expected behavior
The package to install

I have the same issue

Thank you for reporting this. This is a known issue and fixed in one of the nightly builds. The latest v2.1.3-nightly.364675.1a93f21 has this fix.

@AlexGrossi Can you please confirm whether the 2.1.3 nightly fixes the issue for you or not?

@AlexGrossi Can you please confirm whether the 2.1.3 nightly fixes the issue for you or not?

I have checked and it is working for me now.

I'm having the same issue. Trying with 2.1.3.

I also get this error when I open the Package Manager:

Or when I cancel the error and try and install packages:

I'm using 2.1.2 with Windows 11. I will update to 2.1.3 and report back...

Thank you for reporting this. This is a known issue and fixed in one of the nightly builds. The latest v2.1.3-nightly.364675.1a93f21 has this fix.

Update to this build fixed the issue for me.

same issue on a nightly build

I am a new user and just installed Bot Framework Composer and it self-updated to v2.1.2 and I'm also getting this error, just opening the Package Manager menu item.

Bad taste in my mouth already

Still having this same issue today on current v2.1.2 meaning I can't easily complete the tutorial at https://learn.microsoft.com/en-us/composer/tutorial-create-weather-bot#add-interruptions-to-the-conversation-flow

Please refer to #9745

Still having this same issue today on current v2.1.2 meaning I can't easily complete the tutorial at https://learn.microsoft.com/en-us/composer/tutorial-create-weather-bot#add-interruptions-to-the-conversation-flow

Same...

hi @nevenamilenkovic02 Any luck?

Closing due to lack of response. If you still need assistance, please comment with the requested information and we can continue.


Tag silo profile URLs in Webmentions

Related to Idno/Known #1097: Webmention avatars are (re-)stored every time
Bridgy's webmentions seem to return as author URL (h-card > p-name) whatever is provided by the user on their silo's profile.
The URL to the user's profile on the silo is also provided, but is not tagged as such (for example).
I would suggest to systematically add a tag (such as silo-url) to the u-url corresponding to the profile on the silo (whether it's the p-name or not).

Just to clear up a little misunderstanding -- p-name is unrelated. It happens to live on the same tag as u-url in the example above but it's not tagging the url as something special. It's just a parsing directive saying that the person's name is the text content of the <a> tag. i.e., in the parsed output, name=["Jeunes Pirates"], and url=["http://www.jeunespirates.fr", "https://twitter.com/jeunespirates"]
In general, I think this is solvable without special-casing Bridgy or adding Bridgy-specific markup. Indieweb-to-indieweb webmentions have the same issue with avatars that might change content while being served from a fixed URL... Our solution should support that use case too.

@paulcmal thanks again for filing! looks like most of the action on this is in idno/Known#1097, and i think kyle addressed your concerns for bridgy specifically...? let me know if not, otherwise i'll close this issue.


Avoid compilation error when using tasty <IP_ADDRESS> due to duplicate Sh…

…ow instance for a -> b

See https://github.com/fpco/stackage/issues/1410

Thanks.

@kim, would you mind releasing a new version with that fix to Hackage?

0.6.4 is available on hackage


“Get 5 cUSD by sharing Valora with  friend!” message displayed on “Send” contact screen page even user logged in with European phone number

Frequency: 100%
Repro on build version: Alfajores Build V1.21.0
Repro on devices: iPhone 12(15), Redmi Note 8 (9.0), Realme 6i (10.0), One Plus 7t (11.0), Google Pixel 2XL(11.0), Redmi Note 8 (10.0), iPhone SE (14.2)
Testing Account: +33 757130733/Recovery Phrase
Pre-condition: Make sure that user should login with European Country phone number & should verified phone number
Repro Steps:’

Launch the application and login with test account
Confirm phone number verification successfully & redirect to “Home” screen
Tap on “Send” button
Observed that
Current Behavior: Users are able to see “Get 5 cUSD by sharing Valora with  friends!” text even user login with European number
Expected Behavior: Users should be able to see “Get 5 cEUR by sharing Valora with  friends!” text as user logged in with European country
Impact: Bad user experience for European users
Attachment: Alfajores_cUSDDisplayedForVerifiedEuropienNumber.mp4

https://valora.testquality.com defect D412.

https://valora.testquality.com defect D415.

https://valora.testquality.com defect D426.

https://valora.testquality.com defect D434.

https://valora.testquality.com defect D435.


Support backslashes in solution paths

Add a test that will fail on forward-slash OSes when reading a
backslash-containing relative path from a solution file.
Regression test for #2022.

@radical Do you mind me taking the core of your change from mono@86adc96 like this? I was hoping to be able to just cherry-pick or merge it but it has mono-only tests that would make that inconvenient.

@rainersigwald go ahead!


Add is it maintained badges

Overview/Summary
Add is it maintained badges
This PR fixes/adds/changes/removes

Fixes AB#25788

Breaking Changes
None
Testing Evidence
Linting will suffice
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.
[ ] Updated the "RELEASE" page with details needed for when this code change is released.

/azp run unit


process.nextTick is not a function

Hi,
I'm trying to get mocha up and running with webpack and I'm running into configuration problems. My config is faily simple and the bundle seems to be getting compiled successfully. However, I'm getting the following error when trying to execute the runner.
Uncaught TypeError: process.nextTick is not a function

/* 7 */
/***/function(module, exports, __webpack_require__) {

    /* WEBPACK VAR INJECTION */(function(process) {
        process.nextTick(function() {
            delete __webpack_require__.c[module.id];
            if (typeof window !== "undefined" && window.mochaPhantomJS)
                mochaPhantomJS.run();
            else
                mocha.run();
        }
        );

        /* WEBPACK VAR INJECTION */
    }
    .call(exports, __webpack_require__(8)))

    /***/
}

Here is my config
module.exports = {
  context: __dirname,
  target: "web",
  entry: {
    tests: [
      "./tests/runner"
    ]
  },
  module: {
    loaders: [
      { test: /\.js?$/, loader: "babel-loader", exclude: /node_modules/ },
      { test: /\.js?$/, loader: "mocha" }
    ]
  },
  node: {
    constants: "empty",
    fs: "empty"
  },
  output: {
    path: "tests/tmp",
    filename: "[name]-bundle.js"
  }
};

So after digging throught the generated file a bit more it looks like process is defined after it is first used. In this case it is pack #9 and it is first used in pack #7.


When copying, include text to path to enable pasting as strings

This is to improve on the situation in #270 .
Since the Windows clipboard is multi-format, copy objects in forms to facilitate pasting (as files) as well as pasting (as text.)
Note this changes how CheckMultiple is used.  The existing code would only copy a single file .  This change allows a single file or directory .  I think this makes sense in general and verified that pasting a directory will copy as expected.

Neat :-) Tried this too, works fine in the left and right pane.
Do you think you could also squeeze a line into the Readme.md? Otherwise an nice feature is unnoticed by the average user, who simply downloads things


IE8 javascript error

I use the latest commercial player. When my website includes flowplayer.hlsjs.min.js, I see an error in IE8. I think it's actually the hls.js problem.

Thank for bringing this up - and taking it to the hls.js bug tracker. As you noticed yourself the problem is caused by hls.js.
I'll probably make a small change in the Flowplayer plugin per se, but there will still be the error(s) triggered by loading hls.js. I know what's causing this, so I propose to coninue 'over there'.
Meanwhile, the error should affect any functionality (or does it for you?) because the effect is that the hlsjs engine is not loaded, and it shouldn't be on IE8.
If you need to be fussy about error messages, you could load flowplayer.hlsjs.min.js in a nasty IE conditional comment precluding IE < 9:
<!--[if gt IE 8]>
<script src="//releases.flowplayer.org/hlsjs/flowplayer.hlsjs.min.js"></script>
<![endif]-->

@nnarhinen - I found a way to prevent default property literals when webpacking:
diff --git a/package.json b/package.json
index 1516a1e..1f09a6a 100644
--- a/package.json
+++ b/package.json
@@ -29,6 +29,7 @@
     "babel-core": "^6.5.1",
     "babel-loader": "^6.2.2",
     "babel-preset-es2015": "^6.5.0",
+    "babel-plugin-transform-es3-property-literals": "^6.8.0",
     "jslint": "^0.9.5",
     "webpack": "^1.12.13"
   },
diff --git a/webpack.config.js b/webpack.config.js
index dd0e099..9e87a60 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -37,9 +37,14 @@ module.exports = {
     flowplayer: 'flowplayer'
   },
   module: {
-    loaders: [
-      { test: /hls\.js/, loader: 'babel', query: { presets: ['es2015'] } }
-    ]
+    loaders: [{
+        test: /hls\.js/,
+        loader: 'babel',
+        query: {
+            plugins: ['transform-es3-property-literals'],
+            presets: ['es2015']
+        }
+    }]
   },
   output: {
     path: path.join(__dirname, 'dist'),

But the next problem is that webpack uses Object.setProperty: https://babeljs.io/docs/usage/caveats/#getters-setters-8-and-below- - any ideas how to circumvent this?

I'm using Rails and I'm adding this lib into the main application.js file using the require command. I found a solution for now just by requiring it as the last require statement. If I don't do that, IE8 will not load the rest of the javascript and the player will not work.

webpack -p actually does the same as https://github.com/flowplayer/flowplayer-hlsjs/issues/31#issuecomment-217632885 - but also doesn't solve the Object.defineProperty conundrum.

This link will help this issue.
https://phabricator.babeljs.io/T7199

@Jinkwon - hm, that's about quoting default etc., that is not a problem anymore.
The persisting problem is that Object.defineProperty which you get all over hls.js, e.g.
Object.defineProperty(exports, "__esModule", {
  value: true
});

That will trigger an IE8 error Object does not support this action because IE8 only accepts DOM objects.

@blacktrash https://github.com/inexorabletash/polyfill/blob/master/es5.js
If that works, maybe

include that in a different flowplayer.hlsjs.ie8.min.js bundle
and/or document that library for people that want to support IE8. (Or then just document wrapping hlsjs <script> tags in a conditional

@nnarhinen - thanks, that works (I tried tons of others, but maybe also the wrong way).
Considering that packing it increases min.js only by 4k, what's the disadvantage to just include it by default? afaics it doesn't override without need?

I'll distribute with packed es5.js by default (Flowplayer supports IE8), and provide flowplayer.hlsjs.es6.min.js for content providers who want to educate their audience to upgrade their browsers ;-)

Thx! Will the commercial files be the same as the public version?

@xpepermint - all files of the plugin are free and public ;-)

Cool! Let me know when I can download the latest version.

Done.
I have decided not offer a separate version without es5.js - can still be done if the need arises, for the moment this feels like overcomplicating maintenance.

Huray!

@xpepermint - unfortunately the polyfill must be removed, see #38, with work around to avoid error reporting.

@blacktrash thanks for the info.

@xpepermint - I tried all promising looking polyfills to no avail, if you stumble upon one which works do not hesitate to share ;-)


One merged sample is recognized as two samples.

Hello,
I have been having a trouble with concatenating a sample file.
My collaborator gave me two different txt files for each, which is SNP and INDEL file.
Therefore, I had to merge two files into one and need to work with several hundreds files.
Anyway, files have a # in the first row and the second row has header information like Hugo_Symbol, Enter_Gene_ID, Center, NCBI_Build, Chromosome, Start_Position, etc.
So what I did using Mac terminal was,

cat 1.INDEL.maf.txt | grep -v '^#' > 1.maf.txt
cat 1.SNP.maf.txt | grep -v '^#' | grep -v "Hugo_Symbol" >> 1.maf.txt

When I load 1.maf.txt into the maftools and draw the figure using oncoplot, it showed as two samples.
Therefore, I further manipulated 1.maf.txt to sort by chromosome to see what happens using a below script.
sort -k 5 1.maf.txt > 1_2.maf.txt
Unfortunately, oncoplot with 1_2.maf.txt gave me a same result, it still recognizes as two samples.
What am I support to do to over come this problem?
Any kind of suggestion should be helpful for me.
Thank you very much in advance!

Did you check the sample IDs in these two files are same?

Thank you very much for your quick response.
There are no sample IDs but "reference_allele" column has two different names (INDEL or SNV).
I have renamed to unify them and now oncoplot works well as I expected.
Thank you again for your help.
I appreciate it.


Space arrowheads

Change arrows to have arrow heads and smooth curves.
Fixes #198

Lovely, thanks!


License Declaration

Is it possible to add the License Declaration for other to use the component?

is allowed


Add a mutex to BoltDB state to prevent lock issues

Per https://www.sqlite.org/src/artifact/c230a7a24?ln=994-1081, POSIX file advisory locks are unsafe to use within a single process if multiple file descriptors are open for the same file. Unfortunately, this has a strong potential to happen for multithreaded usage of libpod, and could result in DB corruption.
To prevent this, wrap all access to BoltDB within a single libpod instance in a mutex to ensure concurrent access cannot occur.

One question otherwise LGTM.

@umohnani8 @baude @wking @vrothberg PTAL

There is good news here - the file locks for containers and pods are managed by c/storage, which ensures that we only have one open file descriptor for each lock at any given time. So we should not need locking changes elsewhere.

bot, retest this please

bot, retest this please

@rh-atomic-bot r+

@rh-atomic-bot retry


Do not hardcode nova cpu_mode

Right now there is no way to allow set libvirt's cpu_mode without side
effects. In order to preserve the current functionality, add host-model
as the nova default, but allow an operator to override if necessary.

retest

retest

retest


[Feature Request] Disable auto-finish

Describe the problem
So I was hoping to use this gem to show the current status of a buffer in progress bar form. I know the maximum size, so this isn't indeterminate.
My problem? If the buffer gets full, the bar finishes, and there's no way to stop it.
I thought of just adding one to total or something, but that would throw the percentage and bar progress off.
How would the new feature work?
I was thinking an auto_finish: false option, which is checked when currently the bar ends if current == total.
Drawbacks
Can you see any potential drawbacks?
Would need to handle cases where current is set to something > total, but that wouldn't be hard.

Hi Mike,
In short, I like your idea. A flag that toggles this behaviour seems most appropriate. I wonder if manual_finish: true would be a better choice to indicate intent. Alternatively, similar to the :clear we could opt for an even shorter option finish: false. Any thoughts?
As for current going over the total value. I'm not sure we would need to worry about it. Once you indicate that you wish to control when the bar finishes it's on you to finish it whenever. You have access to the current value and you know the total. The bar stops progressing visually beyond the allowed size but the various stats will continue. Am I missing something here?


Add support for providing options to CRIU.

In order to do more complex things with checkpointing and restoring of containers it's necessary to have control over where the image files are being saved and whether or not to kill the running process. It's possible more flags will be wanted in the future. Some things probably should always be auto-configured by libcontainer though.
I'd be glad to hear any suggestions for alternate solutions here. This is my first contribution.

Yeah that's probably right, though I was a bit concerned about the inconsistency of having two code paths. Are there other LeaveRunning considerations to think about?

Could you rebase this PR?

Sure, will do

LGTM

LGTM

\o/
On Thu, Apr 23, 2015 at 11:36 AM, Michael Crosby<EMAIL_ADDRESS>wrote:

Merged #543 https://github.com/docker/libcontainer/pull/543.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/libcontainer/pull/543#event-288597695.


Task/refactoring

Codecov Report

Merging #28 into master will increase coverage by 3.44%.
The diff coverage is 43.58%.

@@            Coverage Diff            @@
##           master     #28      +/-   ##
=========================================
+ Coverage   63.75%   67.2%   +3.44%
=========================================
  Files          29      29
  Lines        2668    2494     -174
=========================================
- Hits         1701    1676      -25
+ Misses        967     818     -149

Impacted Files
Coverage Δ

ingest/exporter/exporter.py
100% <ø> (ø)
:arrow_up:

ingest/exporter/ingestexportservice.py
22.8% <0%> (ø)
:arrow_up:

ingest/importer/importer.py
66.08% <0%> (ø)
:arrow_up:

ingest/api/requests_utils.py
100% <100%> (+40%)
:arrow_up:

ingest/api/ingestapi.py
40.83% <40.87%> (+9.37%)
:arrow_up:

ingest/importer/submission.py
78.38% <57.14%> (ø)
:arrow_up:

ingest/template/spreadsheet_builder.py
55.31% <0%> (+1.2%)
:arrow_up:

ingest/template/schema_template.py
90.58% <0%> (+12.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2d58f...2a39592. Read the comment docs.


Replace ASSERT -> OSL_ASSERT and DASSERT -> OSL_DASSERT.

The old macros were from OIIO, namespace polluting, and ASSERT always
aborted the process. The new macros won't conflict with other apps,
and OSL_ASSERT prints error always but only aborts for debug mode,
which discussion concluded was the preferred behavior.
I also policed up the whole set of assertions, and there were many
instances of:

ASSERT that I deemed downgradable to DASSERT.

ASSERT/DASSERT that I deemed entirely unnecessary and deleted.

A few asserts that should always have been OIIO_CHECK_* unit test
macros.

Any objections?

LGTM!


DOCS 2.4 : Eliminate hard coded numbers in links and labels

Eliminates hard coding as well as fixes internal links with the aim of reducing the number of .htaccess rewrite rules for doc.silverstripe.org - I am using gurlchecker to eliminate all such errors with internal links.

arrgghh...


Update templates to changes in the latest hugo version

Fixes #295
+bonus update of copyright date.

I've rebased that and merged it - thank you very much!  I hadn't noticed hugo had moved on...


How to reset /etc/rancher/k3s/k3s.yaml

I would like to regenerate /etc/rancher/k3s/k3s.yaml file as we are migrating to user-specific accounts and I want everyone to lose the admin access.

cc @brandond

Take this with a grain of salt, because I've only checked the code on my phone and I am not too familiar with the code base anyway, but...
According to the code in https://github.com/k3s-io/k3s/blob/master/pkg/daemons/control/deps/deps.go you should be able to just delete the files client-admin.crt and client-admin.key found at /var/lib/rancher/k3s/tls/ and then restart the k3s server. If I understand the code correctly, k3s should treat the absence of the file the same as an (almost) expired certificate, so it should be recreated.

I've given this a bit more thought: Recreating the client certificate may not invalidate the old certificate. You may need to also delete the files client-ca.(crt|key). Please try this on a throwaway-cluster before attempting this in production..

I'm not sure what you mean by "resetting" it. The admin certificate is signed by the cluster CA; if you've given copies of this file to other users in your organization, there is no way to invalidate the admin client certificate embedded in the kubeconfig short of rebuilding the cluster.

OK I see it was a really bad idea.
I have now revoked the certificate from users by force and terror.


Package invalid error in Brave

Package is invalid: CRX_REQUIRED_PROOF_MISSING on Brave Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
OS: MacOS Mojave 10.14.5 (18F132)

What you think is the problem?

@brunolemos not sure about the cause, though I have found good amount of discussion on the same concern with chrome. Suggestion is to install the extension manually. https://www.cnet.com/how-to/how-to-install-chrome-extensions-manually/

I was getting this error with Opera too, but now I just tried with the latest code and it worked!
Can you try again? Thanks.


AccessKey and SecretKey location

Does anybody know where to put access_key and secret_access_key ?? I am getting below error:
{"level":50,"time":1561451711429,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"failure while polling the secrets","v":1}
{"level":50,"time":1561451711429,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","type":"Error","stack":"CredentialsError: Missing credentials in config\n at IncomingMessage.<anonymous> (/app/node_modules/aws-sdk/lib/util.js:865:34)\n at IncomingMessage.emit (events.js:194:15)\n at IncomingMessage.EventEmitter.emit (domain.js:441:20)\n at endReadableNT (_stream_readable.js:1103:12)\n at process._tickCallback (internal/process/next_tick.js:63:19)","message":"Missing credentials in config","retryable":false,"time":"2019-06-25T08:35:11.429Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","retryable":false,"time":"2019-06-25T08:35:11.429Z","code":"CredentialsError"},"msg":"Missing credentials in config","v":1}
{"level":30,"time":1561451721412,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"stopping and removing poller aws-s3-test-inside-k8s_242636","v":1}
{"level":30,"time":1561451721412,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"stopping poller","v":1}
{"level":30,"time":1561451721412,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"spinning up poller {\"id\":\"aws-s3-test-inside-k8s_242636\",\"namespace\":\"default\",\"secretDescriptors\":[{\"backendType\":\"secretsManager\",\"data\":[{\"key\":\"aws-s3-test-inside-k8s\",\"name\":\"aws-s3-test-inside-k8s\"}],\"name\":\"aws-s3-test-inside-k8s\"}],\"ownerReference\":{\"apiVersion\":\"kubernetes-client.io/v1\",\"controller\":true,\"kind\":\"ExternalSecret\",\"name\":\"aws-s3-test-inside-k8s\",\"uid\":\"cef0de83-9702-11e9-a5e5-42010a8000aa\"}}","v":1}
{"level":30,"time":1561451721412,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"starting poller","v":1}
{"level":30,"time":1561451731421,"pid":17,"hostname":"kubernetes-external-secrets-f99689c5d-kml69","msg":"running poll","v":1}
{"level":30,"

Hi @ajaysheoran2323. It looks like it can't find your AWS credentials

Hi @ajaysheoran2323. Can you set them via environment variables? Either locally or via helm?

Hi @ajaysheoran2323. I wanted to follow up to see whether you are still having problems?

Im having this issue as well trying to run on gke, I am seeing this error in the logs:
"failure while polling the secrets {}"
Im not seeing what the actual error is beyond that message
I confirmed these env vars are set in the pod and the creds have access to get my secrets:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY

@ajaysheoran2323 this is actually working for me (i was using an outdated docker image)
set these env vars:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
AWS_REGION
AWS_DEFAULT_REGION
I haven't confirmed but Im pretty sure you need to set AWS_DEFAULT_REGION to point the aws sm client to the region with your secrets. I added AWS_DEFAULT_REGION when troubleshooting with the wrong image and didnt remove it to confirm its necessary

confirmed AWS_DEFAULT_REGION is not necessary


rpidistro-ffmpeg: remove --enable-v4l2-request flag

Problem
When building with latest OE-Core master. Running into bellow issue. After further research issue appears to be similar to
https://github.com/bootlin/libva-v4l2-request/issues/35
| src/libavcodec/hevc-ctrls-v2.h:59:8: error: redefinition of 'struct v4l2_ctrl_hevc_sps'
|    59 | struct v4l2_ctrl_hevc_sps {
|       |        ^~~~~~~~~~~~~~~~~~
| In file included from
/../../../recipe-sysroot/usr/include/linux/videodev2.h:65,
|                  from src/libavcodec/hevc-ctrls-v2.h:14:

Solution
Disable ffmpeg libva-v4l2-request so that master builds and until better investigation can be done to fix issue.

Thanks for this. This looks good. I've triggered the builders and marked the MR for merge.


Adopt a Contributor License Agreement?

This repo doesn't (explicitly) have a contributor license agreement (CLA) incorporated into it. The main question is this: should we have a CLA or refer to an existing one? Or is it unnecessary?
This issue was prompted by a question from the interim governance group. Our inspiration, the BCD governance doc, makes mention of the Mozilla Community Participation Guidelines and Mozilla Commit Access Policy. While the W3C CEPC is an obvious drop-in replacement for the Mozilla CPG, it's not clear whether or what must replace the Commit Access Policy.
I tried looking at other WebDX and W3C project repos (specifically those which are not specifications) for hints on how to handle this and I didn't learn anything useful (or at least, recognizably useful to me).
Here are a few things I know:

The LICENSE.txt file (APL 2.0) creates some CLA-like expectations (e.g., contributors grant a license to use contributions to the project). (As an aside, we should probably promote this file to the top of the repo, so it's more obvious what license we're operating under.)
There's no separate CLA in this repository.
The W3C has a CLA and members of the WebDX have necessarily agreed to it (i.e., it's a condition of membership).

But there are some things which are unclear to me:

Does contributing to this (or any other WebDX) repo cause agreement with the W3C CLA? If so, should we mention that somewhere (e.g., in a CONTRIBUTORS file)?
If the W3C CLA doesn't apply, is the APL-2.0 license sufficient for contributors to understand how their contributions may be used?

NB: I'm not a lawyer. I'm approaching this more from a perspective of procedural familiarity: are we doing things in ways that are usual and typical and have we communicated what we're doing?

@tidoust, @dontcallmedom: Maybe you can provide some pointers-to-docs/guidance/input on this issue?

The W3C Community License Agreement is much more targeted at contributions to specs than at contributions to open source projects. I don't think that we should try to apply it to this repository and require that contributors be WebDX Community Group participants, that would just seem to complicate things for no good reason.
We don't really have specific contributor license agreements for such open source projects in W3C. We usually just rely on the license. That also seems pretty usual to me in open source projects. What about adding a CONTRIBUTING.md file that mentions the license, similar to the one used in Web Platform Tests?

Thanks, @tidoust! That Web Platform Tests example works for me. I'll open a PR in the coming days to move the license file and do something rather like that contributing file.


Clipboard Improvement

[x] It should work on the web the same as native
[x] It should work at app level, not only on for egui
[x] Copypaste seems unmaintaned (at least some dependencies) egui has moved to arboard we should do the same.

Closed by #170 thanks @jawadsh123


Inconsist recurrent and parallel results for RetNet

It seems the recurrent and parallel forward results are quite inconsistent for multiscale retention in the RetNet code. By debugging around for a while, it seems these three lines are quite weird.
A: mask = mask / mask.sum(dim=-1, keepdim=True).sqrt() line 64 in the retnet.py
B: kv = prev_kv * (1 - 1 / scale).view(self.num_heads, 1, 1) + kv / scale.view(self.num_heads, 1, 1) line 108 in the multiscale_retention.py
C: # kv = prev_kv * decay.view(self.num_heads, 1, 1) + kv line 109 in the multiscale_retention.py
If I remove A and B and uncomment C, the recurrent and parallel results become the same. Can you give me some explanation why these are used? Thanks!

I've found the problem is the layernorm eps is too large. If you set it to something like 1e-10 instead of 1e-5, then the scale-invariant nature applies; Otherwise, the result is different for scaling. But I am still confused about B

I've found the problem is the layernorm eps is too large. If you set it to something like 1e-10 instead of 1e-5, then the scale-invariant nature applies; Otherwise, the result is different for scaling.

@YirunKCL Yes, it's caused by the layernorm's eps value. We can set eps to 0 for the parity check and set it to 1e-5 for training.

If setting it to 1e-5 for training, do we need to set it back to 0 when inference/evaluation for consistency?

If setting it to 1e-5 for training, do we need to set it back to 0 when inference/evaluation for consistency?

@YirunKCL The 1e-5 value is fine. It has negligible effects to inference.


scrapper req

✅ New Quote Checklist

[ ] The quote(s) added are in alphabetical order by author's first name and not ❌ duplicates.
[ ] The quote(s) added are about learning a foreign language.
[ ] The sentence attribute does not have inner quotation marks, and is ended with a period.
[ ] Copy pasted the raw JSON quotes.json file to JSONLint and made sure that the modified JSON file is valid.

✅ New Language Checklist

[ ] There is ❌ no assigned issue or pull request for this new language.
[ ] ➕ Added a new JSON object in the server/data/languages.json file.
[ ] Added the voice 🎤 attribute supported by ResponsiveVoice API.
[ ] Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
[ ] Added the romanization attribute for appropriate languages.
[ ] ➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
[ ] Removed duplicates and noted 🗒 them in the Pull Request.
[ ] Increment currentLanguagesCount in client/src/store/index.js
[ ] Add new language in README.md

happy contributing.


Socks5h not supported

When I add args :"--proxy-server=socks5h:xxx". It shows this:
{
error: "net::ERR_NO_SUPPORTED_PROXIES at https://www.xxx.com",
success: false,
etime: 661,
retryCount: 10
}

It's normal when I use socks5.

This looks like a puppeteer error and is probably not related to this library. Does it work with puppeteer itself? Closing it for now, feel free to reopen if I'm wrong.

socks5h is only needed for curl, where socks5 would leak DNS requests
chromium etc only know socks5, which does not leak DNS requests
see also
https://superuser.com/questions/1762341/does-chromium-not-support-socks5h-with-the-h-in-the-end


Locks are not locking as expected

It looks like a big bug in the code.
If I do the following code:
        LockConfiguration configuration = new LockConfiguration("test", Instant.MAX);
        Optional<SimpleLock> lock = provider.lock(configuration);
        assertThat(lock).isPresent();

        provider.clearCache();

        try {
            Optional<SimpleLock> lockAgain = provider.lock(configuration);
            showDB();
            assertThat(lockAgain).isPresent();
        }
        finally {
            lock.get().unlock();
        }

It will perfectly work and make you will like two locks were taken. Note that I clear the cache in between. It simulates two different servers taking the lock.
However, there is a DataIntegrityViolationException under the hood. But it's ignored.
If I look at the code from StorageBasedLockProvider:
protected boolean doLock(LockConfiguration lockConfiguration) {
        String name = lockConfiguration.getName();

        if (!lockRecordRegistry.lockRecordRecentlyCreated(name)) { // false
            // create document in case it does not exist yet
            if (storageAccessor.insertRecord(lockConfiguration)) { // false
                lockRecordRegistry.addLockRecord(name);
                return true;
            }
            lockRecordRegistry.addLockRecord(name); // but still put it in cache
        }

        return storageAccessor.updateRecord(lockConfiguration); // and then update which will perfectly work
    }

I've added comments to see how it goes. I'm pretty sure the code should be:
protected boolean doLock(LockConfiguration lockConfiguration) {
        String name = lockConfiguration.getName();

        if (!lockRecordRegistry.lockRecordRecentlyCreated(name)) {
            // create document in case it does not exist yet
            if (storageAccessor.insertRecord(lockConfiguration)) {
                lockRecordRegistry.addLockRecord(name);
                return true;
            }
            return false;
        }

        return storageAccessor.updateRecord(lockConfiguration);
    }

Hi, thanks for feedback. I have replicated your test and it's working as expected https://github.com/lukas-krecan/ShedLock/commit/d6e1f13cf57542b0c3373f57435fbfe679ebe6eb#diff-2778f8a38de61a6ed46d65809917ab06R27. I suspect you are using incorrectly implemented StorageAccessor. If valid lock record exists, StorageAccessor.updateRecord has to return false end everything should work as expected. I have added documentation, so it should be more clear now. Moreover, if you want to simulate multiple servers, it makes more sense to create multiple lock providers.

Interesting. Let me see why I get different results.

That is surprising. I did a little project reproducing the issue. See here/.

Ok. Got it. It's Instant.MAX that breaks everything. I don't know if it's because of the timestamp database precision or the conversion to timestamp but it must be one or the other. And it overflows which make the update works.

Cool


DMS guide

This new section is under 'Other Topics', for now.
It describe the whole process to migrate am RDS instance, using a combination of both pg_dump and AWS DMS.

https://github.com/ministryofjustice/cloud-platform-user-guide/pull/102/files?short_path=bcee2fe#diff-bcee2fe9fed8e74544abaa5ffb9472ac


[PE-D][Tester D] Formatting Issue in UG

&#124 appears as part of command in UG but it is not actually needed.
This makes the content unclear to the reader.

Labels: type.DocumentationBug severity.Low
original: yitong241/ped#1

Duplicate of #201


Update CONTRIBUTING.md and Branch CI for useful tagging

Issue

Branches can just be whatever they want to be in the repo. Slap a name and it's a branch.
Contributing.md has no information on branch naming conventions.

Solution

Update CONTRIBUTING.md to include branch naming conventions
For example, #10 would have a branch called feature/user-preference

We can also create some workflows to allow Pull Requests to automatically have the correct initial labels

References
Sample for CI:
on:
  pull_request:
    # Sequence of patterns matched against refs/heads
    branches:
      - main
      - 'feature/**'
      - 'releases/**'

Sample referenced from:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#using-filters

This is a good idea. I've tried to do this in the past, but it's felt out of place.

Branch CI pushed to future story


Add support for unicode nicknames

Using XRegExp for adding unicode support to the regex check for valid nicknames in order to resolve #9

I've limited the character set to only letters, numbers, and underscores to avoid abuse and make nicknames typeable on all devices.


tests: add iter-remote-refs test

Test for iter-remote-refs refs was missing (and is currently broken on windows)
Related https://github.com/iterative/dvc/issues/7670

CI failures are related to linting, see #65


Error without controls

Add following code in MobileLauncher.java:
if (true) throw new RuntimeException("ENDE");
below super(....);
this will show:
(Safari)

(Firefox)

The gray line is missing?
The window is shown without close... This is good, but when do you hide close buttons ?
If no close buttons -> don't show a gray line and hide the button area below?

the dialog footer is now ommitted if there are no exceptions to list

style looks correct but why is there no OK button or another button? Usually such dialogs have a button?
Also it's not possible to close the dialog with X because there's no X.
So there must be some logic which disables closing?

Did you change the style as well?
My error dialog now has a red header - which is correct?

Currently the OK button is only shown if the appReady flag is true which in this test case probably doesn't happen.
This was added due to #402

okay, this makes sense!


feat(Accessibility): Add titles, values and landmarks

Add titles to jsbin iframes. Add value to jsbin copy buttons. Add landmark formatting to layout.
Missing accessibility features added. No issue created.

Codecov Report

Merging #203 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   74.78%   74.78%
=======================================
  Files           9        9
  Lines         119      119
  Branches        6        6
=======================================
  Hits           89       89
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be26cf...ebf9cc9. Read the comment docs.


fix: blockcount bug + yarn format

Block Count is confusing, Should be "Consensus Block Height"

Maybe we should just transform count to height since that's what shows up on block explorers and stuff?


This is the same repo as the dark theme

Hi,
First of all thanks alot for your dark theme. I just love it =)
Actually this repository contains the same as the dark theme. Seems like you haven't developed it so far?
You have said, that it should be easy to do, so would be pretty amazing if you could make it or correct the link if its just an error.
thanks ;)

Thank you!
Correct, I have not gotten to this even though it wouldn't take much time. I can get to work on this Wednesday.

I've released the first version of the theme!
Here is the installation link: https://changelog.ceiphr.com/p/VGe2xeU6G3
It definitely needs polishing when compared to the original theme. I think I'll be able to make the necessary tweaks sometime this weekend.
Please feel free to report any significant contrast issues or inconsistencies.


[REQUEST] jellyfin-ani-sync

Project Website
https://github.com/vosmiic/jellyfin-ani-sync
Project Description
Synchronize anime watch status between Jellyfin and anime tracking sites. Was recommended by author of now deprecated plugin AnilistSync

Solved with https://github.com/awesome-jellyfin/awesome-jellyfin/pull/61.


Configure .vscode/settings.json and remove Prettier-related settings

Rationales:

The Prettier extension and Biome conflict in my VS Code environment, causing unpredictable formatting changes.

Adding .vscode/settings.json enforces Biome as the default formatter.

If we adopt Biome, the Prettier extension becomes redundant for .js/.ts files.
The official Svelte repository also uses .vscode/ (e.g., svelte/svelte, svelte/cli).

@xeho91 Is it okay to add .vscode/ to the repository?

@xeho91 Is it okay to add .vscode/ to the repository?

Yes, absolutely!
In fact. This PR made me think if Biome is actually a right choice for this repository. Given that it doesn't support Svelte yet.
We could always switch back once it is supported, and some little slowness on CI caused by Prettier... I believe it would be tolerable.


can't add eks to Lens

I'm facing a problem whith Lens access to eks around 2 months ago. I think I tried a lot of solutions but nothing is working for me.
I'm accessing to eks fine on wsl Ubuntu with AWS credentials.
I Installed the last version of Lens put the kubeconfig file to add eks clusters change the terminal to "wsl.exe" on Lens.
I can do do "kubectl get node" through wsl on powershell
PS C:\Users\Tarik\AppData\Local\Programs\Lens> wsl kubectl get nodes
NAME                                           STATUS   ROLES    AGE   VERSION
**********.compute.internal   Ready        6d   v1.22.9-eks-
**********.compute.internal   Ready        8d   v1.22.9-eks-
**********.compute.internal   Ready        3d   v1.22.9-eks-
Environment:
Windows 10
WSL Ubuntu 20.04.5
Lens 6.2.6
My kubeconfig :
- name: arn:aws:eks:eu-west-1:****************:cluster/test-eks
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - --region
      - eu-west-1
      - eks
      - get-token
      - --cluster-name
      - test-eks
      command: aws
      env:
      - name: AWS_PROFILE
        value: dev
      interactiveMode: IfAvailable
      provideClusterInfo: false

And I have this error "Unknown error has occurred" :

Logs from lens.log
error: [CLUSTER]: Failed to connect to "dmpa-noprod/indus": StatusCodeError: 401 - {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Unauthorized","reason":"Unauthorized","code":401}
debug: Unknown error has occurred {"isError":true,"meta":{"accessible":false,"disconnected":false,"id":"82128060e6d597b391a3c7b2565e7748","name":"dev/test-eks","online":false,"ready":false}}

Have you faced this issue before? how did you solve it ? Thanks in advance for your help.

Better error messages coming with https://github.com/lensapp/lens/pull/6964

I did this workaround,
1. Create a file in windows aws.bat:
    @echo off
    echo.
    wsl aws %*

2.  Put the file in %LOCALAPPDATA%\Programs\Lens\aws.bat
3.   Restart (might not be needed but didn't work for me until I did)

But, it's not worked for me too,
I got this error now :
Unable to locate credentials. You can configure credentials by running "aws configure".

E0117 17:30:35.141792 22008 proxy_server.go:147] Error while proxying request: getting credentials: exec: executable aws failed with exit code 253

getting credentials: exec: executable aws failed with exit code 253

My credentials are already set, I believe that I'm missing something here.
Any Idea ?

Lens would be passing in windows shaped paths as part of the environment. Could that be causing the problem?
If you install the AWS cli on windows itself are you able to use Lens?

Yes I installed aws-cli on windows, but I stil lhave the same issue
PS C:\Users\tarik\AppData\Local\Programs\Lens> aws  configure list --profile dmpa-noprod
      Name                    Value             Type    Location
      ----                    -----             ----    --------
   profile                  dev           manual    --profile
access_key     ****************XXXX shared-credentials-file
secret_key     ****************XXXX shared-credentials-file
    region                eu-west-1      config-file    ~/.aws/config

If you do a aws update-kubeconfig <name> and use the windows specific kubeconfig file it should work.

It does not work when I installed Lens on windows.
I finaly installed Lens on wsl, and it's working fine.
Thanks you


[CELEBORN-1579] Fix the memory leak of result partition

What changes were proposed in this pull request?
Don't register RemoteShuffleResultPartition to partition manager because we don't store resource in TM.
In theory, we could also fix this on the Flink side by no longer registering partitions to the partition manager for remote/cluster partitions, but that will only be released after Flink 2.0 at the soon.
Why are the changes needed?
RemoteShuffleResultPartition will be registered to the partition manager(at setup phase). Since it's a cluster partition(resources are not stored on the Flink TM), Flink does not trigger the resource releasing over TM.
In a session cluster, the partition object is leaked. As a more serious consequence, the failure of the partition to release will result in the idle TM not being reclaimed by the Flink resource manager.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Self tested in a session cluster.

+CC @venkata91

Merged to main(v0.6.0) and branch-0.5(v0.5.2).


Add lint task with similar params to CI

Adds a task to lint as per CI (omitting html output).
bundle exec rake lint
This could be added to our default task, but that's open for discussion.

Does this return the correct exit code upon failure?

You could follow the pattern here https://github.com/alphagov/government-frontend/pull/107

We're changing the workflow for linting in Jenkins, so this looks good to merge.


How to replace simple spread

📖 Documentation
That's what I have in pipe:
state => ({
  ...state,
  element: deleteContentElement(deleteContentSelection)(state.element),
}),

I thought I could use insertAt:
insertAt('element', deleteContentElement(deleteContentSelection)(

But it does not work. So I tried monocle:
Lens.fromProp<EditorState>()('element').modify(
  deleteContentElement(deleteContentSelection),
),

It works, but it's super verbose. Does it mean we should use plain spread?

That's what I have in pipe:

I think it is completely fine

I thought I could use insertAt:

Record functions work well with homogeneous record types. Not really if you are dealing with an heterogeneous "struct"

monocle works, but it's super verbose

Typically if you have a structure that you find yourself accessing/modifying often in your app, you'll have the lens for it ready (e.g. as part of a shared file, declared once), and then reuse them wherever you see fit

Does it mean we should use plain spread?

If the use case is a simple set 1 level deep, I don't see nothing wrong with using spread or Object.assign
Hope this helps. May I also suggest the fp chat slack for questions like this and #973?  (see the #typescript channel in particular)

Thank you for the answer. As for Slack, it’s like black hole because answers are not indexed by search engines. Also, docs are very sparce so I believe it’s ok to ask here.

The reason why I was trying to avoid spread is that it always creates a new object which can lean to unnecessary updates even when prop value has not been changed.

Or I don't know how to do it. That's code I was trying to improve.
// Preserve identity, otherwise it would always create new objects.
// I can't believe there is no fp-ts helper for that.
if (!somethingHasBeenNormalized) return element;
return { ...element, children };


Better explanation in automatic PRs created to merge release branches

Proposed changes:

Better explanation in automatic PRs created to merge release branches (originated from this discussion)

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

Thanks @m-vdb this looks great 😄


Compile Issues

I'm not sure if your still working on this or not but i'm looking to play around with it but can't seem to get it to build.
The common error is this.
error: 'ALARM_2' was not declared in this scope
Any ideas?

Hey, I haven't worked on it in a while. I'll check it out this weekend or early next week.

Hey, @kicker22004 sorry for the wait! Looks like it was some updates to the dependencies that broke some stuff I guess. Latest commit (f53ca78) should compile fine now.
Changes:

Referencing alarm types of the RTC library (like ALARM_2) changed slightly. Idk why it worked previously but needs to be changed now - maybe it was declared differently previously...

ESP ADC channels are also called differently - ADC1_GPIO33_CHANNEL needs to be replaced with ADC1_CHANNEL_5

It compiles fine on my side now - let me know if you still face the bug