Old 0.5.1 script crashing the game (0.6.3)

Describe your problem here.
Psych Engine crashes when it tries to do if curBeat == 96 then 		for i = 0, getProperty('playerStrums.length')-1 do 			setPropertyFromGroup('playerStrums', i, 'texture', 'invisiblenote') 		end
The function plays again at curBeat == 240 and crashes it if the first one is there but not if it's not (is comment or similar).
This worked before on 0.5.1 but now it just doesn't.
Been trying to fix this for 3 hours now and just don't know what to do. the main problem is at setPropertyFromGroup
(I'm mostly new to Lua, so sorry ahead of time)
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No, it's a release build

Lua has changed a lot since 0.5.1 so old scripts might not work anymore or at all

Lua has changed a lot since 0.5.1 so old scripts might not work properly or at all

I know that... which makes it even more confusing when it works when the first one is disabled but not enabled.

I made it work now. Instead of changing the strums to a different texture, I just did this: setProperty('strumLineNotes.visible', false) and true later to make it visible again.


Add quoting to paths for launch command

This fixes vscode-cpptools#4030 where user had ( in their working directory.

I also quoted all the tmp files we create just in case.
Tested on Linux that the files are cleaned up and that the folder path with ( in it works.


Global Configurations checklist

Why?
Users may not know the Pre-requisite configurations to deploy an application.
They might have to keep switching between configuring first application and required global configurations to get things running.
To-do:

Show configuration checklist on app-list until all configs required to configure/deploy an app are provided
Show same checklist in global config
Guide user to app creation flow once required configurations are provided.

UI
https://zpl.io/b6G6NyN

App List
No apps configured + Configs incomplete (for app+chart) > https://zpl.io/aX6EYGx
No apps configured + Configs incomplete (for app) > https://zpl.io/2yKdkJK
No apps configured + Configs complete (for app+chart) > https://zpl.io/2Z640Pl
App configured > Show regular app list
Chart > Deployed list
No charts deployed + Configs incomplete (for app+chart) > https://zpl.io/a7j6eZK
No charts deployed + Configs incomplete (for app) > https://zpl.io/VO6j1Bk
No charts deployed + Configs complete (for app+chart) > https://zpl.io/25Q69G0
Charts deployed > Show regular deployed chart list
Global Config
Configs incomplete (for app+chart) > https://zpl.io/bW6v4Be
Configs incomplete (for app) > https://zpl.io/br9g1mD
Configs complete (for app+chart) > https://zpl.io/blGyl15
App deployed > Hide checklist


Padres replica

In lieu of re-deploying Augur on our own hardware, architect a backup mechanism s.t. the main augur Postgres instance backs up to another instance on our hardware periodically.
Our instance will be read-only.

Many notes on Notion about this (Padres Replica is the ticket). Please see that issue.


Any news here?

@losh11

see discussion on: https://github.com/pooler/electrum-ltc/issues/306#issuecomment-2352659354


Settings window cannot be brought ontop of main Botnak window if Always On Top is enabeled

If Always On Top mode is enabled, opening the settings window from Preferences -> Settings will create the settings window below the main Botnak window, and it cannot be brought ontop

Aha, easy fix, just send the main window to the back after setting all other windows to always on top.
Fixed in next push.

Actually, further re-reading made me realize that you were talking about creating new windows after setting the Always On Top setting.
Either way, still an easy fix, albeit a bit different than what I originally thought.

New title accurately reflects the actual problem, I didn't realize to check with other windows in botnak.


remove Reference section

The top-level Reference section is largely redundant as its content is really out-of-date, and better placed under the component-specific docs.
Therefore I propose REMOVING the Reference section, and doing the following to each page:

Reference Overview

REMOVE
page is very out of date
this information should be under Component docs

Kubeflow Versioning Policies

REMOVE
page is very out of date
the "Kubeflow application matrix" won't be needed after we add a "Releases" section

Dockerfile Locations

REMOVE
page is very out of date
the cost of keeping this page up-to-date in future is not worth it

Katib Reference

MOVE to Components / Katib / API Reference

MPIJob Reference

MOVE to Components / Training Operators (add to existing "MPIJob" page)

Notebook CRD Reference

MOVE to Components / Notebook Servers

PyTorchJob Reference

MOVE to Components / Training Operators (add to existing "PyTorchJob" page)

TFJob Reference

MOVE to Components / Training Operators (add to existing "TFJob" page)

/priority p1

@RFMVasconcelos what are your thoughts?

+1 on this


fix: case sensitivity on full path

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Scroll font size using ctrl+scrollwhell

Hi,
I'm doing some minor improvements for myself and wanted to share them in form of PR:

add Ctrl+Scroll font size changes (which probably addresses #24)
remove flickering of the TreeView control (enabling double-buffering on the control)

This all works great, thanks so much for sharing!
(sorry for slow response, 'been on a business trip past few days).

Hi,
No problem. There is also a bug fixed in the code I've introduced, I'm going to port it back to this branch shortly.

Cool - it seems I originally closed this issue instead of merging it as intended, so I re-opened (and closed #52) and merged (including your font size <= 0 fix).

Great, thanks!


testutils: remove etcdctl dependency

OK, updated so behavior is the same as before.

@tomdee LGTM! squash and merge


Fix CI: remove ForbiddenComplexFuncCallRule

symplify 10.1.3 seems removed ForbiddenComplexFuncCallRule, that cause error :
_PHPStan_ae8980142\Nette\DI\ServiceCreationException: Service (Symplify\PHPStanRules\Rules\ForbiddenComplexFuncCallRule::__construct()): Class 'Symplify\PHPStanRules\Rules\ForbiddenComplexFuncCallRule' not found.

in CI, this PR try to solve it.

@TomasVotruba there is pending Github workflow:
 code_analysis / Rector Expected — Waiting for status to be reported

could you enable it and merge it? Thank you.

Thank you :+1:

@TomasVotruba new tag is needed since rector-src require pinned version of rector/phpstan-rules

Done :+1:


Game not loading

When I test with HTML5 on 1.5 for some reason it gets stuck on loading compared to 1.4.1 which worked fine.
I have tried with and without debug mode enabled but it doesn't do anything.

Same thing here, something's up.
Guessing a 1.5.1 fix might come soon

this might have something to do with it (WHO BROKE ALPHABET!!!!)
@KadeDev: someone broke alphabet on html5 THIS IS WHY WE TEST BEFORE MERGING!!!

also, if anyone asks I'm using the source code to test, not the website.

this might have something to do with it (WHO BROKE ALPHABET!!!!)
@KadeDev: someone broke alphabet on html5 THIS IS WHY WE TEST BEFORE MERGING!!!

I think I know the issue. When I load up alphabet.xml, there are red "&" symbols.

fixed in https://github.com/KadeDev/Kade-Engine/commit/de35797a37acbb4cff43d8c639f74c43a494f0fa

this might have something to do with it (WHO BROKE ALPHABET!!!!)
@KadeDev: someone broke alphabet on html5 THIS IS WHY WE TEST BEFORE MERGING!!!

I think I know the issue. When I load up alphabet.xml, there are red "&" symbols.

Well I discovered the actual issue.


Make it so folks can't submit a stall without checking at least one noms

And free text won't cut it.
AB#71

Closing and merging into https://github.com/keithamoss/demsausage/issues/1855


feat: handle internal links inside md content

Hi Anthony,
with this PR relative links inside your markdown pages like /posts/journey-with-icons will no longer cause a hard redirect. I hope the changes appeal to you.
Also, one single event listener should be more performant (in theory at least).

Thanks!


Update actions to avoid set-output

We use set-output in a few of our actions: build_nilrt.yml, create_release.yml, and validate_linux_rt.yml.
It is planned to be disabled on May 31, 2023: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
We should update them to use the GITHUB_OUTPUT environment file that they recommend as an alternative.
AB#2359405

Update on this, seems less urgent now. They updated their blog to cross out "Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error." and added "Our telemetry shows significant usage of these commands. Given the number of impacted customers we are postponing the removal."
I haven't seen a definitive date on when or if support for set-output will be removed.


Remove 'gilligan' as maintainer

Description of changes
I've distanced myself from the community a while ago anyway but with what has been going on I prefer to remove myself as maintainer explicitly.
Since i haven't made any contributions in a long while there should be 0 practical impact.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you !


Floating point exception when trying to build and compile my keras model  with xla support.

SYSTEM INFO:
UBUNTU 16.04
TENSORFLOW 1.12.0 (compiled from source with XLA support)
KERAS 2.2.4
GPU Nvidia Geforce RTX 2080 Ti
I am trying to build and compile a simple CNN with XLA but I get a floating point exception.
Here's the block of code
`
import keras.backend.tensorflow_backend as bck
config = bck.tf.ConfigProto()
config.graph_options.optimizer_options.global_jit_level = bck.tf.OptimizerOptions.ON_1
bck.set_session(bck.tf.Session(config=config))

model = Sequential()

model.add(Conv2D(32, (3,3),padding="same",input_shape=input_shape))
model.add(Activation('relu'))
model.add(Conv2D(32, (3, 3)))
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.5))

model.add(Conv2D(64, (3, 3)))
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.5))

model.add(Flatten())
model.add(Dense(256))#64
model.add(Activation('relu'))
model.add(Dropout(0.5))
model.add(Dense(34))#num_classes
model.add(Activation('softmax'))

model.compile(loss='categorical_crossentropy', optimizer='SGD',metrics=["accuracy"])

model.summary()
model.get_config()

from keras import callbacks

filename='model_train_new.csv'
csv_log=callbacks.CSVLogger(filename, separator=',', append=False)
filepath="save_xla/Best-weights-my_model-{epoch:03d}-{loss:.4f}-{acc:.4f}.hdf5"

checkpoint = callbacks.ModelCheckpoint(filepath, monitor='loss', verbose=0, save_best_only=False, mode='auto',period=1)

callbacks_list = [csv_log,checkpoint]

hist = model.fit(x, y, batch_size=32,epochs=num_epoch, verbose=1,callbacks=callbacks_list)

I am getting the following Output for this
2019-01-21 16:33:21.512092: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:964] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2019-01-21 16:33:21.512662: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 0 with properties:
name: GeForce RTX 2080 Ti major: 7 minor: 5 memoryClockRate(GHz): 1.65
pciBusID: 0000:02:00.0
totalMemory: 10.73GiB freeMemory: 10.33GiB
2019-01-21 16:33:21.512678: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1511] Adding visible gpu devices: 0
2019-01-21 16:33:24.538253: I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-01-21 16:33:24.538298: I tensorflow/core/common_runtime/gpu/gpu_device.cc:988]      0
2019-01-21 16:33:24.538312: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 0:   N
2019-01-21 16:33:24.538695: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 9966 MB memory) -> physical GPU (device: 0, name: GeForce RTX 2080 Ti, pci bus id: 0000:02:00.0, compute capability: 7.5)

Layer (type)                 Output Shape              Param #
conv2d_1 (Conv2D)            (None, 128, 128, 32)      320

activation_1 (Activation)    (None, 128, 128, 32)      0

conv2d_2 (Conv2D)            (None, 126, 126, 32)      9248

activation_2 (Activation)    (None, 126, 126, 32)      0

max_pooling2d_1 (MaxPooling2 (None, 63, 63, 32)        0

dropout_1 (Dropout)          (None, 63, 63, 32)        0

conv2d_3 (Conv2D)            (None, 61, 61, 64)        18496

activation_3 (Activation)    (None, 61, 61, 64)        0

max_pooling2d_2 (MaxPooling2 (None, 30, 30, 64)        0

dropout_2 (Dropout)          (None, 30, 30, 64)        0

flatten_1 (Flatten)          (None, 57600)             0

dense_1 (Dense)              (None,<PHONE_NUMBER>6

activation_4 (Activation)    (None, 256)               0

dropout_3 (Dropout)          (None, 256)               0

dense_2 (Dense)              (None, 34)                8738

activation_5 (Activation)    (None, 34)                0
Total params: 14,782,658
Trainable params: 14,782,658
Non-trainable params: 0

2019-01-21 16:33:25.223019: I tensorflow/compiler/xla/service/service.cc:149] XLA service 0x7f6f20001130 executing computations on platform CUDA. Devices:
2019-01-21 16:33:25.223063: I tensorflow/compiler/xla/service/service.cc:157]   StreamExecutor device (0): GeForce RTX 2080 Ti, Compute Capability 7.5
Floating point exception (core dumped)
when I remove this part import keras.backend.tensorflow_backend as bck config = bck.tf.ConfigProto() config.graph_options.optimizer_options.global_jit_level = bck.tf.OptimizerOptions.ON_1 bck.set_session(bck.tf.Session(config=config))
everything works fine.

@jlebar Could you please take a look at this issue? Thanks!

Judging from the warning output, it seems you are running with a old version of tensorflow. There was a bug in the detection logic if you are using an old ptxas which was fixed in https://github.com/tensorflow/tensorflow/commit/83ff640fa5026b8bd3cb9c2ceff9e99e8e03823a
This is how I know you are using an old version.
Can you try to run this with tensorflow at head, or a nightly version?

I also have this exact problem, using the newest release of TensorFlow. Without XLA, the network runs at similar speed on an RTX 2080 Ti as it does with XLA on a GTX 1080 Ti.

The newest release means TF 1.12.0 like mentioned above? It is very much possibly that those bugs have been fixed in the meantime. So could you please try with a version compiled from head?

Yes, TF 1.12. I've just finished compiling TF 1.13rc2 (on branch r1.13), and with it, I can run 'tensorflow/examples/tutorials/mnist/mnist_softmax_xla.py' without crashing. The incorrect warning because of ptxas is also gone. But I get a new warning:
2019-02-22 13:33:11.390128: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/nvptx_backend_lib.cc:134] Unknown compute capability (7, 5) .Defaulting to telling LLVM that we're compiling for sm_30

The result of this is faster than without XLA, and it appears to work :) But it is not as fast as expected, maybe compiling for sm_30 is not optimal. This line is probably missing from 1.13rc2:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/nvptx_backend_lib.cc#L126, I'll try master next.

Thanks for trying it out, and pointing out the new warning. We should try to get this line cherry-picked into the next release if it is not too late for that.

On master, the warning is not present, as expected, but its performance on our internal graph of the result is slower than with 1.13rc2. (Still faster than without XLA though :)
I have no idea why yet, or if this is a more general problem or just an artefact of my testing.

@tfboyd re the cherry-pick of 83ff640.
The new warning about sm75 should also be fixed in master.
mnist is such a small thing that we haven't been bothered by its performance in XLA one way or another.  If you have "real" models where XLA is slower, we'd definitely be interested in seeing those.
I think otherwise this bug is closed?

This bug isn't originally mine, so I can't say if it is fixed, but at least for me, 1.13rc2 works.
On the model I'm working on at the moment, XLA itself in master is still faster than not using it, but it is slower than XLA in 1.13rc2 was. But the model is private and I'm not allowed to disclose any details, so I'll try to debug why this is the case on my own, and open a separate ticket should I find out anything.

So the only solution for this is to install TF 1.13 ?

Yes.

Alright then I am closing this issue.
Also is there any wheel file availabe for TF 1.13 with XLA. Compiling 1.12 from source with XLA was a pain and I don't want to go through the same steps again. If anybody has a wheel file plz share!!

I thought that TF version 1.12 already had XLA support linked in by default?
https://github.com/tensorflow/tensorflow/releases/tag/v1.12.0
(under major features and improvements)
The same should be true for every TF release after that.

@akuegel
Oh okay I didn't knew that actually I was working with an older version on a Jetson tx2 and then cross compiled from source for xla support. and then I wanted to use a newer version on my PC so I compiled 1.12 from source without even knowing that it had already xla support by default.


Property of nullable type is not documented as nullable

I'm documenting this code:
export default class X {
	constructor(x) {
		/**
		This is nullable.
		@type {?X}
		*/
		this.x = x
	}
}

The generated documentation looks roughly like:
public x: X
This is nullable.

The ? in front went missing when rendering the documentation --
the rendered documentation makes it look like the member is non-null.

@andy-hanson Now, ESDoc does not support to attributes(nullable, default, etc.) of member property. If following support, can I help you?

IMO, nullables should be a kind of type (like Array<X>) rather than an attribute.
I'm writing a library with many nullable properties, so simply public x: ?X would make for much less clutter.

Thanks for comment. I will consider it.


Guidelines 248: The method used to create a decoy database is specified

Several typos in the description. Here is the corrected text:
"During the peptide identification step, the search engine uses a decoy database to statistically access the quality of the peptide identifications. Multiple methods are available to generate the decoy databases (e.g reverse, random, etc). We recommende to mention the strategy used to generate the decoy database in the main manuscript."

I think the best way to fix all of them is by making a PR. You can do it and we will review it and merge.

OK. Can do. Thanks.


[Excel](shared runtime) add preview docs for shared runtime

Docs Build status updates of commit 4b5bd58:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 4b5bd58:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/images/sso-onedrive-info-excel.png
:white_check_mark:Succeeded

docs/images/sso-onedrive-info-outlook.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/includes/sso-yeoman-project-structure.md
:white_check_mark:Succeeded

docs/outlook/understanding-outlook-add-in-permissions.md
:white_check_mark:Succeeded

docs/quickstarts/sso-quickstart-customize.md
:white_check_mark:Succeeded

docs/quickstarts/sso-quickstart.md
:white_check_mark:Succeeded

docs/reference/manifest/runtime.md
:white_check_mark:Succeeded

docs/reference/manifest/runtimes.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Failed to run Avalonia Demo.MessageBox

hello
I am trying to run the project Avalonia Demo.MessageBox, but I have been unable to run successfully.
The error message is shown below.

I have tried installing the HanumanInstitute through nuget MvvmDialogs; HanumanInstitute MvvmDialogs Avalonia; But it still failed to run
We hope to receive your help. Thank you.
I am using Visual Studio 2022 or Rider 2022.

I tried running it today and found that it can run successfully in Rider2022, without any modifications, which is strange. Thank you for your reply, wish you all the best.

Sometimes you may need to clear bin/obj folders or something to fix bugs


Endpoints secured by scopes instead of roles

I just fixed the integration tests to work, but as they now function a little different the "user" and "admin" naming of methods is not that good anymore. But we can fix that later I guess.

 Scopes instead of roles


#56 implement oxigraph get edition

get_edition() method added in store/metadata/oxigraph/store.py. Mostly self-explanatory, but populating the table_schema.columns might need a bit of finessing - there's almost certainly a better way of doing it (in an ideal world).
SPARQL queries added:

construct_edition_core
construct_edition_table_schema
construct_edition_versions
construct_edition_contact_point
construct_edition_themes (will rename to construct_edition_topics for consistency)
construct_edition_keywords
construct_edition_temporal_coverage

context.json amendments:

    "versions": {
        "@id": "hydra:member",
        "@type": "@id",
        "@container": "@set"
    },
    "versions_url": {
        "@id": "hydra:Collection",
        "@type": "@id"
    },

Tests added - lots of assertions in test_oxigraph_get_edition_returns_valid_structure() - do we need to check all fields?
I can't see where the titles field in schemas.Column is defined in the context, so I've commented it out in the schema model - will reinstate once it's been added to the context.

closed in favour of: https://github.com/GSS-Cogs/idpd-api-poc/pull/127


md_json_writep: return NULL if json_dump_callback() fails

Zeroing in on the JSON file truncation. If a json_t* is corrupted, md_json_writep() will currently just stop and report success with a partially serialized string. This patch returns NULL instead, and changes callers to handle a NULL return value correctly.

Not sure about this one. A "proper" md_json_t should always serialize into a apr_pool_t (or abort via pool abort), or?
The real question is why it fails. My testing on OSX with jansson 2.10 does not show this. Which version do you run?

A "proper" md_json_t should always serialize into a apr_pool_t (or abort via pool abort), or?

Maybe, but I'm running into improper md_json_ts here. :grin: json_dump_callback() isn't guaranteed to succeed; if we want to abort instead of passing NULL back, that would make sense to me too, but we shouldn't continue as if nothing is wrong.

The real question is why it fails. My testing on OSX with jansson 2.10 does not show this. Which version do you run?

Ubuntu 16.04.1's libjansson 2.7. One of the json_ts is having its refcount reduced to zero, which frees it up and leads to a failed serialization.

(Whoops, missed a code path in my first attempt.)


London Burning scrobbling to last.fm

Hello friends!
I am the responsible for London Burning web radio project for 5 years now.
It's an open project with no financial rewards that promote independent artists across the globe.
One of the trademarks of this radio is to highlight undiscovered tunes.
I could not succeed on installing the implementation on www.londonburning.net (wix platform) in order to enable users the scrobble action through the chrome add on.
I wonder if I could have your guidance on this.
Artists, listeners and I would feel really grateful to this assistance.
Best regards,
Nikolas Koukidis
www.londonburning.net
<EMAIL_ADDRESS>

I had a look but I don't think it's possible the way you currently have it setup due to the Marci iframes src being a different domain than the main page (www.londonburning.net.usrfiles.com versus http://www.londonburning.net/). XSS protection won't allow cross site content to be read by javascript.


Long description missing

Long description field missing in the input form from the Service Provider but it is displayed empty when displaying Service Provider page.

Since it does not exist in the Specs. We removed it from the form. We will remove from the display as well.


Adjust body size/offset to reduce collision box

This change adds a private bodyOffset object to AstronautCharacter that stores x and y values used when calling setOffset and setBodySize in the constructor. The offset can be easily adjusted by setting the x and y offset values to fine-tune if necessary.
Closes #41

It looks great, Justin, thanks!
Since this repo is part of my submission for the GitHub Actions Hackaton 2021, I'm going to merge this after the winners are announced (18/12/2021) to avoid any issues.
Sorry for the inconvenience!


Speed up qiskit import by not using pip in version.py

Summary
This commit speeds up the import time of qiskit by removing the pip call
at run time. This call was overkill and slow, since all we really needed
it for was to get the installed versions of the qiskit meta package. We
were also using as a fallback if element.version failed, but that
was potentially misleading. This commit replaces the pip subprocess call
with the pkg_resources stdlib module to query if the metapackage is
installed and if so to grab that version. This is always faster than
subprocess to call pip freeze. That being said the performace at import
will vary based on the number of installed python packages because it
still has to check all the installed packages.
Details and comments

This is the speed up to import qiskit as reported by the benchmarks: https://travis-ci.com/Qiskit/qiskit-terra/jobs/239554234#L1261

Import improvement looks good. For me, this takes qiskit.version from 357 ms down to 28 ms.
Numbers from python -c import\ qiskit && python -X importtime -c import\ qiskit 2> qiskit.log ( without #3156 ):
Before:

qiskit_pipfreeze.log
After:

qiskit_pkgutils.log


Create a button in the frontend which runs the CLI automatically

User story

Our application is currently running in the backend. As such a frontend, where user could see what is going on inside the connector is essential (moreover when we deployed via cloud). Furthermore, we are using CLI for most of the connector's command and it is tedious and not user-friendly.
As a user,  I should be able to see the button in the website where the connector is running  and when I click this button, I should be able to run all the command line in the documentation, accepting policy, contract exchange, creating asset and transferring data without running the command line one by one in the terminal.
Acceptance Criteria

The connector where the user run all the command line in the documentation, accepting policy, contract exchange, creating asset and transferring data without one by one running the command in the CLI.
There should be a button that trigger these command lines in the webpage that host the connector port.
(optional) it is best to receive a pop up box saying the processing is complete.

DoD General Criteria

Feature has been merged into the main branch
Product owner approved features
Developers agreed to release

This is a test ...


[grpc [codegen,core]:x64-windows] build failure

Host Environment

OS: Windows 10
Compiler: Visual Studio 2017

To Reproduce
Steps to reproduce the behavior:
.\vcpkg install install grpc:x64-windows
Failure logs
[1/2] "C:/Program Files/CMake/bin/cmake.exe" -E chdir "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-rel" "C:/Program Files/CMake/bin/cmake.exe" -S "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/src/2180080eb4-87c05d756b.clean" "-DgRPC_ABSL_SYNC_ENABLE=OFF" "-DgRPC_BUILD_CODEGEN=ON" "-DgRPC_INSTALL=ON" "-DgRPC_BUILD_TESTS=OFF" "-DgRPC_STATIC_LINKING=1" "-DgRPC_MSVC_STATIC_RUNTIME=0" "-DgRPC_ZLIB_PROVIDER=package" "-DgRPC_SSL_PROVIDER=package" "-DgRPC_PROTOBUF_PROVIDER=package" "-DgRPC_ABSL_PROVIDER=package" "-DgRPC_UPB_PROVIDER=package" "-DgRPC_RE2_PROVIDER=package" "-DgRPC_PROTOBUF_PACKAGE_TYPE=CONFIG" "-DgRPC_CARES_PROVIDER=package" "-DgRPC_BENCHMARK_PROVIDER=none" "-DgRPC_INSTALL_BINDIR:STRING=bin" "-DgRPC_INSTALL_LIBDIR:STRING=lib" "-DgRPC_INSTALL_INCLUDEDIR:STRING=include" "-DgRPC_INSTALL_CMAKEDIR:STRING=share/grpc" "-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DPROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DCMAKE_MAKE_PROGRAM=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Users/nasreen.mohsin/Documents/Workspace/VE-2308-FactorySmart GDK/vcpkg/packages/grpc_x64-windows"
FAILED: ../CMakeCache.txt
"C:/Program Files/CMake/bin/cmake.exe" -E chdir "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-rel" "C:/Program Files/CMake/bin/cmake.exe" -S "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/src/2180080eb4-87c05d756b.clean" "-DgRPC_ABSL_SYNC_ENABLE=OFF" "-DgRPC_BUILD_CODEGEN=ON" "-DgRPC_INSTALL=ON" "-DgRPC_BUILD_TESTS=OFF" "-DgRPC_STATIC_LINKING=1" "-DgRPC_MSVC_STATIC_RUNTIME=0" "-DgRPC_ZLIB_PROVIDER=package" "-DgRPC_SSL_PROVIDER=package" "-DgRPC_PROTOBUF_PROVIDER=package" "-DgRPC_ABSL_PROVIDER=package" "-DgRPC_UPB_PROVIDER=package" "-DgRPC_RE2_PROVIDER=package" "-DgRPC_PROTOBUF_PACKAGE_TYPE=CONFIG" "-DgRPC_CARES_PROVIDER=package" "-DgRPC_BENCHMARK_PROVIDER=none" "-DgRPC_INSTALL_BINDIR:STRING=bin" "-DgRPC_INSTALL_LIBDIR:STRING=lib" "-DgRPC_INSTALL_INCLUDEDIR:STRING=include" "-DgRPC_INSTALL_CMAKEDIR:STRING=share/grpc" "-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DPROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DCMAKE_MAKE_PROGRAM=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/packages/grpc_x64-windows"
CMake Error: The source directory "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-rel/GDK/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
[2/2] "C:/Program Files/CMake/bin/cmake.exe" -E chdir "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-dbg" "C:/Program Files/CMake/bin/cmake.exe" -S "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/src/2180080eb4-87c05d756b.clean" "-DgRPC_ABSL_SYNC_ENABLE=OFF" "-DgRPC_BUILD_CODEGEN=ON" "-DgRPC_INSTALL=ON" "-DgRPC_BUILD_TESTS=OFF" "-DgRPC_STATIC_LINKING=1" "-DgRPC_MSVC_STATIC_RUNTIME=0" "-DgRPC_ZLIB_PROVIDER=package" "-DgRPC_SSL_PROVIDER=package" "-DgRPC_PROTOBUF_PROVIDER=package" "-DgRPC_ABSL_PROVIDER=package" "-DgRPC_UPB_PROVIDER=package" "-DgRPC_RE2_PROVIDER=package" "-DgRPC_PROTOBUF_PACKAGE_TYPE=CONFIG" "-DgRPC_CARES_PROVIDER=package" "-DgRPC_BENCHMARK_PROVIDER=none" "-DgRPC_INSTALL_BINDIR:STRING=bin" "-DgRPC_INSTALL_LIBDIR:STRING=lib" "-DgRPC_INSTALL_INCLUDEDIR:STRING=include" "-DgRPC_INSTALL_CMAKEDIR:STRING=share/grpc" "-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DPROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DCMAKE_MAKE_PROGRAM=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/packages/grpc_x64-windows/debug"
FAILED: ../../x64-windows-dbg/CMakeCache.txt
"C:/Program Files/CMake/bin/cmake.exe" -E chdir "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-dbg" "C:/Program Files/CMake/bin/cmake.exe" -S "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/src/2180080eb4-87c05d756b.clean" "-DgRPC_ABSL_SYNC_ENABLE=OFF" "-DgRPC_BUILD_CODEGEN=ON" "-DgRPC_INSTALL=ON" "-DgRPC_BUILD_TESTS=OFF" "-DgRPC_STATIC_LINKING=1" "-DgRPC_MSVC_STATIC_RUNTIME=0" "-DgRPC_ZLIB_PROVIDER=package" "-DgRPC_SSL_PROVIDER=package" "-DgRPC_PROTOBUF_PROVIDER=package" "-DgRPC_ABSL_PROVIDER=package" "-DgRPC_UPB_PROVIDER=package" "-DgRPC_RE2_PROVIDER=package" "-DgRPC_PROTOBUF_PACKAGE_TYPE=CONFIG" "-DgRPC_CARES_PROVIDER=package" "-DgRPC_BENCHMARK_PROVIDER=none" "-DgRPC_INSTALL_BINDIR:STRING=bin" "-DgRPC_INSTALL_LIBDIR:STRING=lib" "-DgRPC_INSTALL_INCLUDEDIR:STRING=include" "-DgRPC_INSTALL_CMAKEDIR:STRING=share/grpc" "-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DPROTOBUF_PROTOC_EXECUTABLE="C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe"" "-DCMAKE_MAKE_PROGRAM=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/packages/grpc_x64-windows/debug"
CMake Error: The source directory "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-dbg/GDK/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
ninja: build stopped: subcommand failed.
Additional context
I tried gilt pull and ./vcpkg update..Problem still persits

@nasreenpmohsin Thanks for posting this issue,  looks like protoc.exe doesn't exist。
CMake Error: The source directory "C:/Users/nasreen.mohsin/Documents/Workspace/vcpkg/buildtrees/grpc/x64-windows-dbg/GDK/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe" does not exist.
Could you check if \vcpkg\installed\x64-windows\tools\protobuf\protoc.exe exists? And please also check which files are in \vcpkg\packages\protobuf_x64-windows\tools\protobuf .
And could you Copy libprotobuf.dll.libprotoc.dll under \vcpkg\installed\x64-windows\bin to \vcpkg\installed\x64-windows\tools\protobuf

@nasreenpmohsin Is still work for this issue?

We don't have enough information to solve this issue, unfortunately; if you have any more information to help us solve this, please reopen!


Update TFJob docs with information about monitoring.

Move over the documentation in kubeflow/tf-operator/README.md and
update it for v1alpha2.

Add a what is TFJob section that describes the TFJob

Provide information about the spec
Provide information about exit codes.

Provide stackdriver sections for both the legacy and new Kubernetes
stackdriver.

Add a troubleshooting section.

/assign @kunmingg

/lgtm
Thanks, very detailed docs.

/approve


Dev. guide should provides more details on the yaml file used in the github action.

https://github.com/princomp/princomp.github.io/blob/f5c4931b70ee69f29df37cbb6c06c14e330a5992/source/docs/about/dev_guide.md?plain=1#L655
This should be expanded.

Done with https://github.com/princomp/princomp.github.io/commit/58e3bb553b83bf11f94a57b60e0bcd9c84380afc


Update "read more guides" link target (found at top left of In-Practice examples) - currently directs to github

Update target url to http rather than https


Query:  cinam/randomizer as a dev dependency

I was just wondering if it would be more appropriate for the dev dependency on cinam/randomizer be marked as a main dependency since the main classes type hint Cinam\Randomizer\Randomizer.
Cheers

You can see more information in #9, but cinam/randomizer is only offered as an optional randomizer.  You can leave that parameter out and it will just use built-in random functions instead.


The given data failed to pass validation

I run the command php artisan make:auth.
If you attempt to register a user, I have specially made mistakes in the entry form and get the following message:

Illuminate \ Foundation \ Validation \ ValidationException
The given data failed to pass validation.
\vendor\laravel\framework\src\Illuminate\Foundation\Validation\ValidatesRequests.php
Line 88: throw new ValidationException($validator, $this->buildFailedValidationResponse(

`     *
* @param  \Illuminate\Http\Request  $request
* @param  \Illuminate\Contracts\Validation\Validator  $validator
* @return void
*
* @throws \Illuminate\Foundation\Validation\ValidationException
*/
protected function throwValidationException(Request $request, $validator)
{
throw new ValidationException($validator, $this->buildFailedValidationResponse(
$request, $this->formatValidationErrors($validator)
));
}
/**
 * Create the response for when a request fails validation.
 *
 * @param  \Illuminate\Http\Request  $request
 * @param  array  $errors
 * @return \Illuminate\Http\Response`

Screenshot here
I using Laravel 5.2.31, cleaning install.
In routes.php:
Route::auth();

What was the solution?

Using Auth::routes();

Thanks, unfortunately I have that already.

Hi @BlueTeck , we faced a similar problem and this might be useful to you: https://github.com/GrahamCampbell/Laravel-Exceptions/issues/80#issuecomment-243487005

Doesn't this exception package require you to extend some other exception class?
Maybe a class which in turn extends from Laravels class.
At least that's the case with the packages I've used for this.


ActionMenu span showing an axe violation related to ARIA hidden

When using ActionMenu in a React partial and passing axe scan it is returning an accessibility issue:

ARIA hidden element must not be focusable or contain focusable elements

This is related to span.sentinel and it seems is not related to react partials:

Steps to reproduce

Open the new /issues experience running script/setup-hyperlist-web in codespaces
Scan the page with the top-right corner menu open

Is it possible also scanning the storybook
with the menu open
Discussion: https://github.slack.com/archives/C01L618AEP9/p1686844272093569

@owenniblock this is a blast from the past!

ARIA hidden element must not be focusable or contain focusable elements

Can be reproduced in storybook. (see addons → accessibility → incomplete)
These were introduced in https://github.com/primer/behaviors/pull/52 from Feb, 2022

This change alters the behavior of the focusTrap so that it inserts a sentinel  element before and after the trap area.
This is because from an Accessibility point of view - trapping focus and not having any focusable elements within that focus is bad for screenreader users.

However, this fails aria-hidden-focus rule from axe-core 4.7:  https://dequeuniversity.com/rules/axe/4.7/aria-hidden-focus
I'm not sure what's the right way to proceed here, is our implementation incorrect or should we ignore this specific rule?

I would suggest we can ignore this specific rule because when the focus falls on the sentinel, focus is then passed round to the next focusable element within the focusTrap (if memory serves) so the user's focus passes through to the next visible, focusable element.
Having said that, I would love to get feedback from my peers in the Accessibility Team. I'll post in Slack and see if anyone has opinions 🙂

Interesting, @siddharthkp: one colleague has suggested to try adding role="presentation" to the sentinel elements to see if that makes the axe error go away. If that doesn't work I suggest we can safely ignore this anyway 🙂

+1 to what you said @owenniblock.
I feel like we utilize this pattern a lot across GitHub. To me it seems like a false positive provided by Axe, that we could probably ignore in cases where 'sentinel' is being used. It would be nice if we could adjust the rule for these cases, but I don't think that this issue comes up enough to justify that now 🤔 .
@jezcommits is this issue a blocker for you? If not, I think we could just ignore the violation.

Thanks great! thanks for checking. Knowing that this is not affecting the real user, from our side this is not a blocker. We will ignore the violation the next times 👍🏽

I feel like we utilize this pattern a lot across GitHub. To me it seems like a false positive provided by Axe, that we could probably ignore in cases where 'sentinel' is being used.

Good to know!


Enable overriding variables

To allow default values of variables to be overridden.

Duplicate of https://github.com/thoughtbot/bitters/issues/195


autofocus: false does not allow the keyboard to open

I need to set autofocus to false because I am using it in a form with other text fields and I don't want to focus on tags as it is at the end of the form. However, when I set that to false, when tapping on new tags text field, it comes out of focus immediately and closes the keyboard before user get a chance to type anything.

Not a bug.


Add offered_since, fix sorting, enhance price bounds

Hi :wave:
I originally wanted to just add support for the offeredSince parameter, but stumbled upon a few glaring issues. I can split this up into multiple pull requests if necessary.
Changes:

Price bounds will now use "null" when a bound is absent (None) instead of "0" and "1000000" as is the behavior of the Marktplaats website itself
Price bounds are now excluded from the API call when both parameters are omitted
Changed sort_order to sortOrder. This seemed to be causing an issue with sorting.
Use .value on the SortBy and SortOrder enums when passing them to requests.get. This seemed to be causing an issue with sorting.
The newly added offered_since parameter will add the offeredSince parameter to the API call, to filter on new adverts only.

I am observing some inconsistency with the results; when getting a list of adverts sorted by date, some adverts are missing on some requests, and present on others. This seems to be on Marktplaats' end, and might not even be related to the offeredSince parameter. Any idea what this can be?

Hi, thanks for the PR! It looks good to me. I did open a review with a single comment.
As for the inconsistency with the results: I'm not sure what this is. My best guess would be Marktplaats' recommendation engine shuffling things? This would be somewhat hard to investigate, as the library is in no way official.

Hi, thanks for the PR! It looks good to me. I did open a review with a single comment.

Thanks, I don't see a review/comment though?

Hi, thanks for the PR! It looks good to me. I did open a review with a single comment.

Thanks, I don't see a review/comment though?

Forgot to submit it 😅


Cannot Setup Integration

Repro Steps:

Install TryFi integration in HACS, then restart
Attempt to add integration but receive error "cannot connect"
Log details below:

Logger: homeassistant.util.async_
Source: util/async_.py:131
First occurred: 6:38:46 AM (1 occurrences)
Last logged: 6:38:46 AM
Detected I/O inside the event loop. This is causing stability issues. Please report issue to the custom component author for tryfi doing I/O at custom_components/tryfi/config_flow.py, line 47: tryfi = PyTryFi(username=data[CONF_USERNAME], password=data[CONF_PASSWORD])
I was able to get past the error by changing line 47 to:
tryfi = await hass.async_add_executor_job(PyTryFi, data[CONF_USERNAME], data[CONF_PASSWORD])
With this change, the TryFi integration adds successfully. However, no entity ever ends up populating.
The issue seems to stem from config_flow.py - like the user input doesn't appear to save properly (update interval, then next time I go back to options and it's back to the default of 10 again). I spent an hour investigating, but I'm still pretty new to Home Assistant.
Let me know if I can help. I really appreciate your efforts on this project and on PyTryFi!

From testing out the PyTryFi module, it seems I am able to log in successfully, but the updates do not return any pets or bases (length = 0). So that explains why the HACS integration isn't working for me.
Anyone else having trouble?

@sbabcock23 - First off, I just want to thank you for putting together these projects! I've been wanting to take my pup's TryFi to the next level ever since I got it and was very glad when I learned of your project via HACS.
Q: Are community contributions welcome?
I have a couple PRs just about ready to go.. Brief synopsis:
Problem came down to PiTryFi structuring queries with invalid syntax. I'm not familiar with the method being employed; while very clever, it's also kind of confusing. Therefore, I recommend using the graphql-python/gql client, since it's very straightforward and saves work.
Aside from that, the only other issue is with the HACS integration config_flow.py - need to change to async and adjust user input save.
Please let me know if you have any thoughts. Cheers!

Hi @sans-1 ,
Thanks for your help already on this issue. I'm all for community contributions. I have limited time right now so any help is much appreciated. I haven't used that library for graphql but I'll take a look at it when I can. Feel free to contribute!

I am having the same issue.


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-09-28T19:47:03+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-cni

integ-pilot-multicluster_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-cni

integ-pilot-multicluster_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-pilot-multicluster

integ-ambient_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient

/test integ-pilot-multicluster

/test integ-cni

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-cni

integ-pilot-multicluster_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-pilot-multicluster

integ-ambient_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-cni

integ-pilot-multicluster_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-pilot-multicluster

integ-ambient_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-ambient

integ-telemetry-mc_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-telemetry-mc

integ-ambient_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-ambient

integ-telemetry-mc_istio
189f975c08a6626e7df9214918cf10a37f59aaed
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


FormattedMessage doesn't need to use regular expressions

In order to determine which message format syntax to use in FormattedMessage, this uses a regular expression. This can be simplified by flipping the ordering to check for a parametrized message first before assuming it's a printf-style message.

@jvz I was looking into this. How do you suggest we check for a parametrized message, by doing countArgumentPlaceholders(msg) > 0 ?

@adwsingh, that sounds about right.
I marked you as "assignee" to prevent other contributors to work on it. It's not an obligation.

@adwsingh,
Yes, it is a breaking change to silence Code scanning alert #51: checking for an unescaped {} is much faster than checking for a java.util.Formatter format specifier.
I believe we can change the documentation to state:

The message factory supports the following format specifiers:

those specified by java.text.MessageFormat,
those specified by java.util.Formatter,
{} placeholders (cf. ParameterizedMessage).
Mixing specifier from these 3 categories is not supported.

BTW: The regex we use currently is identical to java.util.Formatter.formatSpecifier used by the JRE, so this does not change anything security-wise.


Check for changelog changes

Current Situation
We tried to check changelog changes in the past, but the GitHub action we used didn't seem to work.
Proposed Actions
I found a working example that we could use as a reference.

I think doing "skip changelog" via labels is inherently flawed.
We really shouldn't give all GitHub users the ability to edit issue labels. The alternative is having project managers (yourself and I) manually manage all "skip changelog" labels for all future PRs. But this could get very tedious as this project grows in size.
This can really only properly be done by validating whether a user has typed "skip changelog" in the PR comments. Which is 100% possible with GitHub's public API, but requires us to create a custom workflow.


DW entry used to be an integer

Discovered via https://mastodon.social/<EMAIL_ADDRESS>
Introduced with Adobe PDF 1.2 --> Adobe 1.7 : integer
ISO 32000-1:2008 : integer
ISO 32000-2:2017 : number but not identified as a change
ISO 32000-2:2020 : number
so fn:BeforeVersion(2.0,integer);fn:SinceVersion(2.0,number)

Actually integer;fn:SinceVersion(2.0,number) works better since integer is a formal subset of number.

Note that this alternate representation is possibly not directly representing the exact words as written in ISO 32000-2...


Add SingleEcuJob

Add dataclasses SingleEcuJob, ProgCode, InputParam, OutputParam, NegOutputParam
Add functions to read them from odx files
Add template to write them into odx files
Add unittests for reading / writing single ECU jobs
Add a single ECU job to the somersault ECU
A DiagLayer exposes inherited Single ECU jobs in the .services property (together with DiagServices)

This required some updates to the list and browse commands to handle this change

Katrin Bauer<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

cool! let's get that merged!


Load scenario from ini file

Should fix: #41

Coverage decreased (-1.04%) to 78.936% when pulling 90456df635b83ac37be5033d96e119f530546d5e on feature/load-map into 6b6a79695e84b79b00d9d30f57a28b612fe267a1 on master.

Coverage decreased (-1.0%) to 77.088% when pulling fa32851fce4806699ba6828e72e145fd0107837b on feature/load-map into 846229488ab051e5265797975731d9cd8ae212ad on master.

Coverage decreased (-1.0%) to 77.088% when pulling 840f47146f6f489d8a505cc11ac1e512dbd8568f on feature/load-map into 4f122ef25d4223050ee718242a3492e03963c67d on master.

Coverage decreased (-1.0%) to 77.056% when pulling 8426f1fdc3f2eb6556747ed43b0e222c18609cf4 on feature/load-map into dfa8b828c94b016577870380a09501516c78d17e on master.

Coverage increased (+0.1%) to 78.175% when pulling 94934489f34ef4e39fe0ea97d04c4d09798e4b9d on feature/load-map into dfa8b828c94b016577870380a09501516c78d17e on master.

Coverage increased (+0.4%) to 78.414% when pulling d182d6812454c399e54e1c7ee770a955f880cbab on feature/load-map into dfa8b828c94b016577870380a09501516c78d17e on master.

Coverage increased (+0.7%) to 78.719% when pulling a941bf4751d3d8681276dd5b3362220610259824 on feature/load-map into dfa8b828c94b016577870380a09501516c78d17e on master.

Coverage increased (+0.7%) to 78.683% when pulling 1bac61f71ce43218ac70f585b7720c2754b2f860 on feature/load-map into dfa8b828c94b016577870380a09501516c78d17e on master.


Delete old synced folder before a new sync

Because a folder could have old files inside, an improvement could be deleting synced folder before redownloading it. This fixes a current issue with the new multi-provider function and the new file naming convention (eg. test.gitlab) that causes duplicated files: the older ones (pre multi-provider) and the new ones (post multi-provider) that are equal.

I changed the logic slightly ...
Instead of deleting the folder, I'm going to delete only the obsolete files, that is, all the other files that have not just been downloaded and created. I've also changed the output of the sync command; I've highlighted the provider name and the action performed (created, deleted) in the same way as the output of init command

@CasvalDOT lgtm!


Update to controller-runtime v0.11.x

For: https://github.ibm.com/symposium/track-and-plan/issues/24285
What's Changed:

controller-runtime moves to v0.11.0
k8s.api moves to v0.23.0
golang version moves to go 1.17

How to Test:

Switch to go 1.17
Check for any gopls messages
run make skaffold-dev

👁


Week 12 Project Assignment Feedback

Please implement request object for parsing HTTP request url/body

Please rewrite view to return ApiResult objects
https://github.com/YYB-SOA/api-cafemap/blob/8d798e29ad90c91cbc348a0441fbe420f9a7e77f/app/application/controller/app.rb#L73-L78
https://github.com/YYB-SOA/api-cafemap/blob/8d798e29ad90c91cbc348a0441fbe420f9a7e77f/app/application/controller/app.rb#L95-L98

Services should return ApiResult objects

Please implement response object and representer object for API response.

Please implement acceptance tests.

Except 5, the issues are solved.
Due to the BADM presentation, We' ll start to work on another repo app tomorrow.

The acceptance test is done


Test Closed Notebook Search

Refs #173726

[x] macOS @DonJayamanne
[ ] linux @sbatten
[x] windows @karrtikr

Complexity: 4
Create Issue

Intro:
Hi! 👋
This has to do with using the search widget to search for notebook content. Like in previous TPIs, the search widget should be able to search fully in open notebooks. However, when a notebook was closed, the search widget always searched the raw source text of the notebook. In the TPI linked above, you could see how opening a search result changed the search result preview's text so that it matches the "rich" version of the text that you view from the notebook editor. With my changes, I'm aiming to show "rich" results before you open the notebooks. These will be limited to only searching notebook INPUTS for now (code and markdown input) when a notebook is closed. This means that it's normal to see extra results appear (or results changing preview text) when you open a notebook (either from a result or not) because opening a notebook triggers another search that should also show results for outputs and rendered content.
DEMO:
https://github.com/microsoft/vscode/assets/31675041/3bac4bba-2a48-4322-bae5-14f2930340e4
Set up:
Enable search.experimental.closedNotebookRichContentResults. Just to be sure that you're in a good state, please also reload the window after you do this.
Testing:
Test that:

searching in closed notebooks shows only matches that are in notebook inputs and not notebook outputs.
searching in closed notebooks shows "rich" content.

For example, you can have a cell that contains the python:
    print('hello')
            print('hello')
        print('hello')

And the search result in the closed notebook should NOT have quotes.
Incorrect:

Correct:

Clicking on a search result should open the document at the appropriate location. Please be aware that this might not always work upon opening the notebook due to this bug. Also, this bug might prevent the current match from being highlighted correctly upon clicking on a search result.
searching in non-notebooks is as expected still.
Please just play around the feature and leave feedback on what you think!

Future work
For the future, I'm planning on improving on these two areas:

Performance of the notebook search (especially in remote scenarios). Issue here
Potentially adding support for searching outputs in closed notebooks.

In this case, possibly facilitating better switch between closed and open notebook search (since filter icon suddenly appears for searching open notebooks, but not closed).

Nice addition, works great.

Works as expected, awesome

Sweet, love how well this worked in my data science workspace.


Crazy vram requirements

I have 24 GB of vram plus an additional 16GB so a total of 40GB of vram and im trying to animate a photo thats a size of 119 x 231. And im getting an OOM error. Any ways to reduce the amount of vram used? I downsized the photo 3 times

The vram usage shouldnt be over 40 GB for an image that small

Nevermind i got it working on a very small image. Having a way to reduce vram would be nice though! :)


all chains the app available on- Hop Protocol safe app - no possibility for the safe connection

Open app on Optimism/Arbitrum - https://app.safe.global/apps/open?safe=oeth:0xf9D445a46D65427550174ec2A49FceFA3dae7f8D&appUrl=https%3A%2F%2Fapp.hop.exchange
Current result: No possibility to connect safe

@kangarang could you fix it?

Disabled the app until this is fixed.


Hosts file editor

Summary of the Pull Request
New utility for managing the hosts file.

PR Checklist

[x] Closes: #20204
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[x] Tests: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[x] New binaries: Added on the required places

[x] JSON for signing for new binaries
[x] WXS for installer for new binaries and localization folder
[x] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

TODO

[ ] UI/UX/Icon
[x] More tests coverage
[x] Module interface
[x] Settings page
[x] Settings:

Startup warning
Additional lines position: top/bottom

[ ] OOBE page
[x] Logging
[ ] Telemetry
[x] Pipelines
[x] Setup
[x] Bug report tool
[ ] User docs

Known issues

[ ] Not opened in foreground when launched from the settings page

Validation Steps Performed

@niels9001 do you have time to help with UI/UX and icon? Not urgent at all 😃
A few questions for the core team:

An utility like this doesn't have a strong dependency with the runner and also the concept of enable/disable but do we still want to have the module interface? I guess we need it for the settings.
What do you have in mind for the environment variables editor?

CC @crutkas  @jaimecbernardo @stefansjfw

I know it is a draft. But I like to give some ux ideas:

Moving sort button between info bars and list.
Adding table headers.

What are the symbols on the second column for?
We can add a setting where to add comments (above the entry or behind).

I know it is a draft. But I like to give some ux ideas:

Moving sort button between info bars and list.
Adding table headers.
Adding a "open settings" button.

Thank you.
UI still needs a lot of improvements.

What about having a "view hosts file" button?

Do you mean a button that opens the hosts file in the default editor?
I think the goal of this tool is to not edit the hosts file manually anymore.

What are the symbols on the second column for?

Ping result.

We can add a setting where to add comments (above the entry or behind).

Comments are in line.

Does it save imidiatly? I don't like souch apps. Maybe a save changes feature would be good to have.

Yes, this is really a nice experience and aligned with PT settings.

We can add a start menu shortcut to make opening easy. This makes the utility available using start menu, start menu's search and PT Run.

Don't think this will be possible if we make the app running under PT runner and PT module interface.
Asked the core team in my previous message what's the ideal solution for this kind of utilities.

What about having a "view hosts file" button?

Do you mean a button that opens the hosts file in the default editor?
I think the goal of this tool is to not edit the hosts file manually anymore.

I don't want to have editing capabilities. But maybe a raw file view is a good addition. Maybe someone has to view the raw content for some reasons. It can be open in the default editor or a second page in the tool that shows the whole file content in a read only edit. (Then you don't have to navigate through the file system.)

@niels9001 do you have time to help with UI/UX and icon? Not urgent at all 😃

Loving this 😁👍. I can definitely help out on the UI, will pick this up next week. Mind if I push directly to this branch?

Suggestion. Have a big warning at the top that can be a setting to turn off?  “Warning! altering this file has direct real world impact of how this computer resolves URLs”
On by default.

@niels9001 do you have time to help with UI/UX and icon? Not urgent at all 😃

Loving this 😁👍. I can definitely help out on the UI, will pick this up next week. Mind if I push directly to this branch?

Yeah, feel free to push directly.
Thank you! 😃

@niels9001 do you have time to help with UI/UX and icon? Not urgent at all 😃

Loving this 😁👍. I can definitely help out on the UI, will pick this up next week. Mind if I push directly to this branch?

Yeah, feel free to push directly. Thank you! 😃

@davidegiacometti I had something like this in mind - thoughts?
Question:

Do we need the enable/disable context menu entries if we have the ToggleSwitch?

@niels9001 looks awesome!

The enable/disable entry is redundant and can be removed.
A pinging indicator would be nice: should also be easy to implement.

@htcfreek

What does the file icon do? Open file or duplicate entry? (Maybe duplicate entry feature makes sense.)

It opens a popup that allows to add extra lines (including editing unparsed ones).
Will add duplicate feature to original issue. Let's add it after v1 release.

Does a infobar about running in non admin mode makes sense. Maybe some people want to open only for viewing.

Still wondering how this app will interact with PT runner. Not really sure if will have a start menu shortcut.
Maybe we can add a normal launch and launch elevated button in PT settings.

Do you saw the ask of @crutkas for the warning that changes are saved immediately.

I have already added a startup warning.

What does the file icon do? Open file or duplicate entry? (Maybe duplicate entry feature makes sense.)
It opens a popup that allows to add extra lines (including editing unparsed ones).
Will add duplicate feature to original issue. Let's add it after v1 release.

@davidegiacometti , @niels9001
To not have misunderstandings: I mean a feature for duplicate an entry and not for duplicate the hosts file. And I don't think that we need an extra PR for this.

Do you saw the ask of @crutkas for the warning that changes are saved immediately.

I have already added a startup warning.

I am not sure if @crutkas not meant an infobar that is always visible. 🤫

@niels9001 very nice! Unfortunately title bar doesn't work anymore after a clean build.
I am on Windows 10 21H2.
The error in System.NullReferenceException: 'Object reference not set to an instance of an object.' since window.TitleBar is null.
Is this supposed to work in Windows 10?
@htcfreek

I suppose duplicate entry will be a context menu action but not sure if really needed since you don't expect to have multiple lines with same address or host.
At the moment is a dialog displayed at startup but we can switch to an always visible message.

Strange thing is that I have been able to see it before the clean build.
Also the WinUI 3 Gallery have a custom title bar.

Part of me wonders if changes should be asap due to the power of this file

What do you have in mind for the environment variables editor?

what I initially had in mind there was to have Settings page with these tools, i.e. buttons to start the tools. I think having those in settings page is accessible enough, just 2,3 clicks away

Can we early decide for the name of the utility?

Just Hosts ? :P

Hosts Editor, Hosts file editor?

Just a small annotation:
We definitely should provide a good description of what it is for the localisation team. Not that we get some weird translations.

@crutkas

The user experience is really nice without a save button but we may consider to add save button or made this behavior a setting if file save is a concern.
I am using Hosts as internal name and PowerToys.Hosts.exe for executable but I would go Hosts File Editor for the end user.
For the warning are we fine with a dialog at starup do you prefer an always visible message?

Yes: continue
No: exit

Sounds good, lets get some user feedback.
I'm fine with exe being that and external name being fuller.  We do that all over :)
drop "Do you wish to continue", change buttons to be "Accept" "Quit" which then infers to continue.

@davidegiacometti
(A small reminder:) Please don't forget bugreport tool and adding the new settings page to the enum in App.xaml.cs of settings project.

@niels9001 do you have other things to do?
I have added fallback to title bar. I'll add progress to ping and remove enable/disable from context menu.

I have found a bug with text not wrapping (may be related to the text inside a stackpanel). Can you take a look?
Can you also create the icon?

Thanks!

@davidegiacometti
Is the text in the eight row (<IP_ADDRESS>) the description or an invalid host name? Wondering about the space between "nas" and "storage". [Maybe we can add a validation check for existing entries in a second step. This makes sense imo as you can edit the file externally.]

@davidegiacometti Is the text in the eight row (<IP_ADDRESS>) the description or an invalid host name? Wondering about the space between "nas" and "storage". [Maybe we can add a validation check for existing entries in a second step. This makes sense imo as you can edit the file externally.]

nas and storage are both valid hosts since you can specify more than one host for a single address.
Validation is already implemented and invalid entries are not displayed as entries in the list.

@davidegiacometti Is the text in the eight row (<IP_ADDRESS>) the description or an invalid host name? Wondering about the space between "nas" and "storage". [Maybe we can add a validation check for existing entries in a second step. This makes sense imo as you can edit the file externally.]

nas and storage are both valid hosts since you can specify more than one host for a single address.

Don't know this.

Validation is already implemented and invalid entries are not displayed as entries in the list.

👍

Does it make sense to format it in the list like this: nas, storage
I don't like that the comment is in the same column. I think we should have a separate one for the comment.

Does it make sense to format it in the list like this: nas, storage

I don't really know.. ATM hosts is a string and they are parsed as they are in the file.
An enhancement could be parse hosts into a list and display them comma separated but how do you expect to display them in add/edit dialog?
Do we really need this or can we keep it simple?

I don't like that the comment is in the same column. I think we should have a separate one for the comment.

I find this solution more compact and not space-wasting.
What you are suggesting makes me wondering about a DataGrid behaviour: https://github.com/microsoft/PowerToys/issues/20204#issuecomment-1238326961
I am up to @niels9001 if he have more suggestions/improvements.

Does it make sense to format it in the list like this: nas, storage

I don't really know.. ATM hosts is a string and they are parsed as they are in the file.
An enhancement could be parse hosts into a list and display them comma separated but how do you expect to display them in add/edit dialog?
Do we really need this or can we keep it simple?

We can keep it simple. Was only an idea.

I don't like that the comment is in the same column. I think we should have a separate one for the comment.

I find this solution more compact and not space-wasting.
What you are suggesting makes me wondering about a DataGrid behaviour: https://github.com/microsoft/PowerToys/issues/20204#issuecomment-1238326961
I am up to @niels9001 if he have more suggestions/improvements.

I see the problem with our current solution that you have to know that the text after the minus is the comment. Not sure if we can expect that users come to this fact by itself.

@robertstefan the add dialog is related to a single entry (line).
You can add multiple hosts for a single address.

Are you asking for a way to add multiple entries without press the "new entry" button again?

@robertstefan the add dialog is related to a single entry (line).
You can add multiple hosts for a single address.

Are you asking for a way to add multiple entries without press the "new entry" button again?

Maybe we could add an csv import or multiline add dialoge in a later version.

Ready for review! 😃
Updated screenshots in the first post.
What's missing here:

Icon
Screenshots in Settings and OOBE (let's wait for review.. It would be nice to put screenshots from Windows 11 but I have only a 13" with a weird scaling)
Anything missing for telemetry?

There is a known issue: when launched from the settings page sometimes is opened in background. Tried several solutions without success 😢 I ask for help 😄
_I think this is expected since the windows in foreground is the settings and the process is started from the runner
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setforegroundwindow#remarks_
I guess the same behaviour will occur with Environment Variables since both uses the same approach.
Please let's focus on ship a v1, will open issues for suggestions and new features (ATM listed here https://github.com/microsoft/PowerToys/issues/20204#issue-1357589645).

I currently am not able to test it (because I'm not ar home), but here are some questions:

How do you launch it?
How do you get the path of the hosts file? Would a setting specifiying the default path be reasonable?
What about a context menu entry for files named hosts?

Thank you @niels9001
Is the preview version needed for bugs or only for the title bar?
I have one concern related to https://github.com/microsoft/PowerToys/pull/19992: do we need to keep WinAppSDK consolidated across the solution? @stefansjfw
TODO: this setup needs to be updated.
Regarding the ping: adding a tooltip to the icon will be enough or still an accessibility bug?
Thank you!

Windows App SDK needs to be consolidated across the solution, since we're using hardlinks to share it amongst the utilities.
@niels9001 is there a release date for winappsdk 1.2? Does it fix the title bar issue only or is it required for your tweaks as well?

Additionally, I see that as part of the Windows App SDK upgrade to 1.2-preview, it also upgraded to a preview version of the Windows SDK. It made the current PR not build in CI as well.
I'd like to understand how vital this is.
Reverting the versions back to the ones needed for WinAppSDK 1.1.5, it looks like this:

The difference I'm seeing seems to be the title bar when compared to 1.2-preview:

(Also it seems there's a missing icon for adding a line? I'm guessing it's something missing in Windows 10? )
I think the update to win app sdk 1.2 should be on a different PR, after it releases.

Thank you @jaimecbernardo
I think failed build was caused by that package. I have opened another issue for System.IO.Abstraction.
Which icon are you referring to?

Thank you @jaimecbernardo I think failed build was caused by that package. I have opened another issue for System.IO.Abstraction.
Which icon are you referring to?

Nevermind the icon, my bad :) It was for the additional commented lines. I thought it was the "rectangle" that is shown when there's no icon, but now I see that it's the actual icon. I thought that button was for something else. That's perfectly fine.

Something I'm seeing here that might be needed here is a way to start Hosts Editor as admin when PowerToys is not running as admin. Perhaps another button in the Settings page to start as Admin, with the warning that it can only write the hosts file if it's started as Admin.
Other than that, seems to be working fine. Thanks a lot for the contribution!

Can you also take a look at the launching issue? https://github.com/microsoft/PowerToys/pull/20462#issuecomment-1264687898

Yeah! Launching from settings will be easier.
Just wondering:

If settings are closed, will hosts editor also be closed?
Hosts editor needs to know the runner PID to wait for the closing event.

Yeah! Launching from settings will be easier. Just wondering:

If settings are closed, will hosts editor also be closed?

I think not.

Hosts editor needs to know the runner PID to wait for the closing event.

Wonder if this can be passed in an argument from Settings 🤔 I think run_settings_window() from runner already passes the powerToysPID as an argument for Settings.

/azp run

Regarding the use of WinAppSDK preview, I can't seem to be able to drag the Hosts File Editor window until I first resize it.
When it's unfocused it looks a bit weird as well, due to the different colors of the title bar buttons:

I can repro issues with the title bar.
Let's wait for @niels9001 confirmation but I agree with downgrade to stable version for now.
I have done some tests and I prefer to keep the launching logic in the module interface.
The main reason is that settings are always running as user even if PT is running elevated and the result is the UAC popup is displayed when you launch the Hosts File Editor from settings.
This solution is working: https://github.com/microsoft/PowerToys/pull/21098/files
Let's wait for the PR review before commit changes.
I am also adding a way to launch Hosts File Editor elevated when PT is running as user (UAC is displayed in that case).
It would be nice to keep the same UX in Environment Variables Editor when available.

Regarding the ping: adding a tooltip to the icon will be enough or still an accessibility bug?

A Dialog would be nice to have I guess - we can leave as is for now :).
@jaimecbernardo @davidegiacometti I have downgraded to the WASDK package for now, we can wait for the stable version and test then! Wonder if that bug is W10 only?

Regarding the ping: adding a tooltip to the icon will be enough or still an accessibility bug?

A Dialog would be nice to have I guess - we can leave as is for now :).

I'm not an accessibility expert but wouldn't a dialogue be annoying?
With a timeout of 4 sec I can ping more than one hosts and many dialogs will be opened.
I think it would be nice if narrator could announce the result of the ping when icon is changed.

@jaimecbernardo @davidegiacometti I have downgraded to the WASDK package for now, we can wait for the stable version and test then! Wonder if that bug is W10 only?

I guess it's W10 bug. Let's wait for stable.
I have pushed changes to settings for launch as admin, fix for focus and many accessibility improvements.

I've added some commits:

Downgrade the Build Tools that were upgraded to a preview version.
Launches as admin by default now.

I've merged main, added winappsdk and PowerToysInterop files so the shared ones are used.
I've also added a commit so that starting from OOBE respects the Launch as Admin setting.

Thank you @jaimecbernardo 🚀

Installer looks good now. Ready to go in.

@davidegiacometti think you should have the privilege of squashing and merging :)

What about having a "view hosts file" button?

Do you mean a button that opens the hosts file in the default editor? I think the goal of this tool is to not edit the hosts file manually anymore.

Just my 2 cents as a random user : I'd still like to have a shortcut to edit the file in the default editor (that would ideally open as administrator). The UI is really nice to add or enable/disable a couple of hosts, but when managing dozens of them sometimes I just want to be able to copy/paste a chunk of text or use column editing to comment out 20 lines at once.
At least this is my current workflow with hostsman, which does have the option to open the hosts file in a text editor.

Great feedback

@crutkas , @nicolus , @davidegiacometti
I know that we had a discussion about multiline input (adding multiple entries at once) in the past. I don't know what the result was. But I can imagine to add a feature for csv/txt file import or something similar.
Let's create the following two issue for feature enhancements:

Add button to open hosts file in default editor as administrator.
Add feature to add/import multiple entries at one step.

@nicolus looks reasonable. Let's add a button for open the file.
@htcfreek already tracked in the issue. I'll the issue for the import.


Fix schema tests

This script uses different env variables from the main jenkins.sh scripts, so it always fails for govuk-content-schemas PRs. This makes the vars the same.

This is a duplicate of https://github.com/alphagov/specialist-frontend/pull/119


21 argument wildcards

Replies added. Not sure I can get to many of these until the weekend. Feel free to play around with them if you want though.

I probably won't have time until the weekend as well, but I'll play around with some of the stuff Saturday or Sunday

I pushed a commit to address the cache removal, though it took away the comments you had on it. I saw no appreciable increase (or decrease) in test run time, though I didn't account for removal/modification of tests.

All right, that's all I got for now. Feel free to look into any of the others ones if you want.


Contrib: Document submodule update process

This adds some contributor documentation on the process I use to update the cargo submodule.
Of course nobody is required to use this process, but I find it works fairly smoothly.

@ehuss: no appropriate reviewer found, use r? to override

@bors r+

:pushpin: Commit 1762b336b7267f272af8bc3f6b3c878f115ec119 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 1762b336b7267f272af8bc3f6b3c878f115ec119 with merge 58c861a5b1ed1cb68fbf67ad591eb668c6cbcb69...

:broken_heart: Test failed - checks-actions

@bors retry
macos failed during fetch smoke test with:
warning: spurious network error (2 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
warning: spurious network error (1 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
error: failed to get `cargo-platform` as a dependency of package `cargo v0.65.0 (/Users/runner/work/cargo/cargo)`

Likely a network issue.

:hourglass: Testing commit 1762b336b7267f272af8bc3f6b3c878f115ec119 with merge 85e79fcc2956cdaf7fe643e1ca3878b977b612e0...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 85e79fcc2956cdaf7fe643e1ca3878b977b612e0 to master...


post: Decreased backend tests

Sharing knowledge about our journal to decrease backend tests.

Plan Error
The default workspace is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again.

Plan Error
The default workspace is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again.

Plan Error
The default workspace is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again.

Plan Error
The default workspace is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again.

Plan Error
The default workspace is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again.


Add support for /withdrawals/crypto endpoint

Added

Support for POST /withdrawals/payment-method endpoint
Support for POST /withdrawals/coinbase-account endpoint
Support for POST /withdrawals/crypto endpoint
Support for GET /payment-methods endpoint
Support for GET /coinbase-accounts endpoint

@dugjason I've forked, updated, and created a new Coinbase Pro gem with your withdrawal methods included:
https://github.com/vertbase/coinbase-pro


Fix Acetyl-CoA Carboxylase Reactions

Main improvements in this PR:
As proposed in #593:

Renames MAM00185c and MAM00185m to "[apocarboxylase]"
Removes ACACB (ENSG00000076555) from GPRs of MAR07672 and MAR07673
Changes the subsystems of MAR07672 and MAR07673 to Fatty acid biosynthesis (even-chain)
Removes MAR04156 for being redundant with MAR07672+MAR07673
Creates new metabolite MAM01422m
Changes MAR04295 to MAM01261m + MAM01422m -> MAM01357m + MAM02444m
Creates new reaction MAR20112: MAM01371m + MAM02046m + MAM01357m -> MAM01285m + MAM02039m + MAM02751m
Creates new reaction MAR20113: MAM00185c <-> MAM00185m

I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch
[X] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

will look into this soon


wordnet (value error)

Hi All,
i am using nltk 3.3 and python 3.6 versions
i am getting valueerror when i tried below code. can some one help me to rectify this error.

Thanks,
raja

Hi @rajarameshmamidi,
The first parameter to synset() should be of the form go.v.21, travel.v.01,dog.n.01 or 'dense.s.03'. You are seeing an error because of incorrect input. For your specific example, try motorcar.n.1.
Also try method synsets, notice the plural s at the end. For example:
>>> from nltk.corpus import wordnet as wn
>>> wn.synsets('motorcar')
[Synset('car.n.01')]

Thank you purificant.... now it's working with above code.

@rajarameshmamidi I see full text of chesterton-thursday.txt in both raw and sentence tokenized forms.
>>> import nltk
>>> text = nltk.corpus.gutenberg.raw('chesterton-thursday.txt')
>>> len(text)
320525

Which is the same as
$ wc --bytes ~/nltk_data/corpora/gutenberg/chesterton-thursday.txt
320525 ~/nltk_data/corpora/gutenberg/chesterton-thursday.txt

But when i try in my IDE... it's not showing all information. i have attached the screenshot of the output.

@rajarameshmamidi have you got all the problems resolved regarding your question?
For more information on the wordnet module, please take a look at http://www.nltk.org/howto/wordnet.html
Thanks @purificant for helping to explain the solutions!
Closing this for now. Feel free to reopen if there's more issues/problems you've find with the wordnet module.


Update to BLAKE3 version 0.3.7

Closes #249

I was able to build this on my platform (x64 Intel Windows / MSVC), I think I need the runners to tell me if it is sane on the other platforms.

Works for me (x86 AMD Linux 5.10.34) :+1:

it seems reasonable to update the blake3 implementation to take advantage of these optimizations.
However, given that we embed a copy of the blake3 implementation in this repo, rather than referencing it via a submodule, it makes it hard to audit updates like this. How can we validate that this source code actually corresponds to some official and trustworthy implementation of blake3?
There's also a more tangible issue, where the msvc build is failing with this patch: https://github.com/Chia-Network/chiapos/pull/251/checks?check_run_id=2645442250#step:8:288
The ARM build failure doesn't seem related to this patch directly though,

it seems reasonable to update the blake3 implementation to take advantage of these optimizations.
However, given that we embed a copy of the blake3 implementation in this repo, rather than referencing it via a submodule, it makes it hard to audit updates like this. How can we validate that this source code actually corresponds to some official and trustworthy implementation of blake3?

It might be better for sure to make it a submodule that would go fetch BLAKE3 at version XYZ in the build process.  That said, you can verify the files match https://github.com/BLAKE3-team/BLAKE3/releases/tag/0.3.7, but that's horrendously manual.

There's also a more tangible issue, where the msvc build is failing with this patch: https://github.com/Chia-Network/chiapos/pull/251/checks?check_run_id=2645442250#step:8:288
The ARM build failure doesn't seem related to this patch directly though,

This is a draft I submitted to see how easy it is / is not to upgrade BLAKE3 in place.  Let me know if you want to me to continue to resolve the MSVC build issue, or if you think making it a submodule that pulls the BLAKE3 repo is better (and I will close this draft PR).


Parsing error on non latin keyboard layout

On Cyrillic alphabets i got error pasing on long class names:
ERROR: Unable to parse samplefile.js: Line 6: Unexpected token ILLEGAL
example:
/**
 * @class НеАнглийскаяРаскладкаВКлассе
 */
class НеАнглийскаяРаскладкаВКлассе  {
    constructor() {
    }

}

I can't reproduce this issue. What version of JSDoc are you running? Also, what operating system are you using?

Latest JSDoc from git master. Windows 7 x64. nodejs 0.12.2
Maybe it's due to the fact that a localized url becomes too long.
(https://en.wikipedia.org/wiki/Uniform_resource_locator#Internationalized_URL)

Can you try running "npm install" to make sure you have the correct version of each submodule?

Оf course. I delete .\node_modules\jsdoc and reinstall with 'npm install git+https://github.com/jsdoc3/jsdoc.git' Bug is still there.
I solved this problem by patching function makeUniqueFilename(filename, str)
String.prototype.toLatinLayout = function(){....}

function makeUniqueFilename(filename, str) {
    filename = filename.toLatinLayout();
    str = str.toLatinLayout();
......
}

but this solution is not good & not for all...


passed params doesn't persist during broadcast it only recieves in start and later its empty

it happens or can recieve only only once in starting and later passed params are empty


Looks linear

Looks-Linear is not necessarily better than the baseline:

fixing the conv bias (higher init to achieve the same std as before) doesn't help either.

and everything underperforms the main branch

Closing PR.
After these tests, convscale can be safely removed. Additionally, #73 took away the ability to transfer weights from small to large models using the current weight transfer methods, so they can be safely removed as well.