Enable parallel script runs

Is your feature request related to a problem? Please describe.
The typical pattern for building packages in a monorepo is to add a "build": "aegir run build" script in the root package.json and add a "build": "aegir build" in each subpackage package.json.
This is slow because the run implementation currently executes scripts for each package sequentially, rather than running in parallel where it can.
Describe the solution you'd like
Enable run to execute in parallel where it can
Additional context

Small comparison:

building libp2p/js-libp2p monorepo takes 1m37s with 26 packages => avg 3.7s per package
building chainsafe/lodestar monorepo (using lerna which executes in parallel where possible) takes 54s with 19 packages => avg 2.8s per package
assuming similar amount of inter-monorepo dependencies and package complexity, with parallel script runs, building js-libp2p would drop to 1m12s, saving 25s per build

This in progress here: https://github.com/ipfs/aegir/pull/1312
It needs some tests adding and I think interleaving the output of different processes got a bit hard to follow so that needs sorting out too.

Resolved with #1312


Show timestamp for pipeline execution duration

This is helpful for debugging and understanding pipeline execution speed. Example output:
Package "grafana":
[RUNNING] "gcr.io/kpt-fn/set-namespace:v0.1"
[PASS] "gcr.io/kpt-fn/set-namespace:v0.1" in 4.2s
[RUNNING] "gcr.io/kpt-fn/set-namespace:v0.1"
[PASS] "gcr.io/kpt-fn/set-namespace:v0.1" in 2.9s
[RUNNING] "gcr.io/kpt-fn/set-namespace:v0.1"
[PASS] "gcr.io/kpt-fn/set-namespace:v0.1" in 2.7s

Successfully executed 3 function(s) in 1 package(s).

@howardjohn This is a backwards breaking change and if it should be done, this has to be an opt-in feature. Do you have an issue filed for this with your use-case mentioned ?

Why is this a breaking change? Its a user-facing unstructured command line output. Are you expecting users to be parsing the result of this?

Unstructured human-consumed output of fn commands is not considered part of the API, so this is not a backwards breaking change (In contrast to https://kpt.dev/book/04-using-functions/03-function-results)

Never mind. This is not a backwards breaking change. But seems like we need to refactor test framework to test this behavior.

I will update the tests soon. Thanks!
On Tue, Aug 17, 2021 at 1:44 PM phani @.***> wrote:

Never mind. This is not a backwards breaking change. But seems like we
need to refactor test framework to test this behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleContainerTools/kpt/pull/2455#issuecomment-900616906,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXO5MOK3XVH3PU2ZZO3T5LCZJANCNFSM5CGN4B6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Really cool addition to the pipeline output.  Thanks for the PR!

OK looks like I got the tests passing. Had to do some regex which didn't feel great but wasn't too complex


layered caching for session stores

This implements CachingSessionStore, which holds two SessionStores. One acts as a frontend cache, while the other asks as the backend persistence store.
Anything that implements SessionStore may be used as either the cache or the store.
We also refactor our Moka implementation as it can now be used for layered caching directly in via CachingSessionStore.

@and-reas-se here's a more concrete look at what I mentioned. I'd love your feedback on this approach.

Looks good overall I think. Cleaner design and more general.
Some thoughts:

The new design doesn't have the ability to cache negative responses anymore. I don't know how often it'd come up in practice, say if there's a cookie with a missing session entry, what would happen? Is there some mechanism that deletes the cookie? Otherwise it could be an extra database hit on each request when that situation happens.
You're awaiting some futures in series that are independent, so they could be polled concurrently. Specifically in delete() and save(). I probably did the same thing in my implementation.
This is essentially a tree structure. The indirection added by async-trait is probably why the compiler isn't complaining about sizes not being known and recursive async functions. Worth noting.

The new design doesn't have the ability to cache negative responses anymore.

Thanks for pointing this out--it wasn't my intention to remove this and I'll admit I completely overlooked this aspect of the implementation.
Perhaps we should be calling cookies.remove in this branch. It's not a perfect solution, I think more ideally we'd have a tombstone marker or similar built into the API, but I think that would at least prevent a well-behaved client from sending spurious cookies.

You're awaiting some futures in series that are independent, so they could be polled concurrently. Specifically in delete() and save().

I've thought a bit about this. I'm not sure if this is more correct, but futures::try_join would bring them together a single future that would be awaited. However, the ordering is not guaranteed as I understand it. I think the more correct approach is e.g. to delete from the store first and then the cache and save to the cache first and then the store.

I suppose SessionStore.save could become save(&self, session_record: Option<&SessionRecord>). It is a breaking change, but I think that does allow stores to decide how they want to handle negative lookups.

@benwis you might be interested in this re your original caching question. Would love any feedback you might have. 🙂

It's a little less cogent than I might like, but I think I've managed to preserve negative caching. I'm certainly open to changing this approach in the future.


Nominate promoting myself to OS X Lt.

:+1: .... if the specs pass :smile:

:+1:

:+1:

:+1:  yay☺

:+1:

@sethvargo @btm @martinisoft as Lt.s, can you please weigh in on this?

:+1: as I agreed in the last IRC meeting too :)

:+1:


Resolves #6212 | Grammar fix + test fix

What's changed, or what was fixed?

grammar update
fixed a failing test

Fixes: #6212
Target Live Date: YYYY-MM-DD

[ ] This has been reviewed and approved by (NAME)
[x] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Enables additional policies for bastion and vault instance pools

What this PR does / why we need it:
Additional IAM policies from the tarmak config were not enabled for vault and bastion instance pools. This PR creates a instance profile to the bastion instance to attach policies to.
Bastion and vault instance pools now attach policies from arns in the config
fixes #519
Bastion and Vault instance pools now support additional policies declared in the config

/assign @simonswine @dippynark

Needs rebasing
/assign @JoshVanL
/unassign @simonswine @dippynark

/unassign
/assign @simonswine

/approve
/lgtm


Introduce IoC container and isolated ApplicationContext to Backstage Backend

Hey, I just made a Pull Request!
Continuation to https://github.com/backstage/backstage/pull/8696
This is the proposal implementation of adding IoC to Backstage by using Inversify. The implementation omits the usage of decorators in favour of manual binding and dependency retrieval to/from the container.
Implementation
Wrapper
Implements a wrapper implementation of ApplicationContext around Inversify IoC container framework. The context is a hierarchical structure consisting of a root container and children contexts, which are their own ApplicationContexts. Each instance holds a reference to an Inversify container which is used as the storage for injectable instances. The container in child context is a descendant of the root (or higher lever, in case of multilevel hierarchies) container, thus having the ability to retrieve dependencies up the hierarchy.
The wrapper provides the following possibilities:

Type safe way to register and retrieve dependencies
Automatic registration of dependencies based on a predefined structure
Hierarchical or isolated contexts depending on desired usage

Exposing injectable dependencies from modules
Aka, constructing a module context.
Injectables and dependencies they depend on are defined as a typed structure called DependencyConfig. The structure consist of:

id = A symbol + type pair. Symbol pointing to the package and interface to be registered. Eg. @backstage/catalog-backend/CatalogInterface. Type being a dummy value enabling casting when handling these injectable
dependencies = An object keyed by a name that want to be passed into the factory, pointing to a dependency id+type pair.
factory = A function accepting an object in the same shape as defined in dependencies, returning an implementation of the service to be registered.

The ApplicationContext implementation accepts an array of DependencyConfigs and automatically registers them into the container on the level of the hierarchy they should reside. The dependencies passed into the factory are retrieved from the container during registration.
Usage
Registering
Exposing possible injectables from individual modules can be done by exporting a collection DependencyConfigs which are then used when instantiating the ApplicationContext. The structure from modules is shown in this PR in a file called moduleContext.ts in the respective packages of the interfaces that are needed to be registered for the first implemented module ('badges'). Ideally injectables should be exported from the packages where the interface is defined, keeping the same dependency structure as actual code paths.
Registering modules with constructed dependency container can be done by calling createModule method on the root application context. This creates a child context, containing a child container and binds/registers the injectables defined in the passed in DependencyConfig collection. This method expects also expects an initialize function that accepts an ApplicationContext, which is called with the constructed child application context.
Replacing individual implementations of injectables can be done on two levels.

Root: Modifying the construction code of the rootContainer. This can be done by modifying the root context, (defined in the PR in rootContext.ts) replacing the desired factory functions.
Module: Modifying the createModule call of the individual module construction glue code (as seen in badges.ts). This can be done by prepending an injectable, with the same id as the one that is wanted to be replaced, and providing a factory function for it. The ApplicationContext construction uses the first injectable of its kind during construction.

Retrieving
Created bound modules receive an application context as the only argument for their main entrypoint. This entrypoint should act as a composition root for the whole module and call the get method of the ctx to retrieve all needed, already constructed dependencies.
It is also possible to enhance the injected container within the context with additional dependencies but that is not advised. It is also possible to pass the ctx around the module as an argument, though that is not good practice as it is an antipattern.
Possibilities
With its current state within this PR the ApplicationContext exposes bare minimum functionality to support modules returning an express router instance. Few modification should be made to add support for other types of modules. This can be done with naming and return type change.
Additional work to introduce a more comprehensive, framework-y, construction structure for Backstage backend modules can be built on top of this implementation if needed.
The implementation is backwards compatible, exposing the same environment shape as previously to an individual module registrations. Though this does change the actual module instances to use ApplicationContext, so individual when individual modules are moved over to be within the IoC container realm will have breaking change on their API (unless a secondary, IoC compatible entrypoint is created for migrated plugin packages).
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

This PR is opened as a draft to expose the implementation proposal at an earlier stage for comments and modifications.
:heavy_check_mark: TBD

[x] Tests
[x] Docs
[x] Error handling
[x] Decide on naming
[x] Make hot reloading of BE to work with app context

I'll let this sit here for a week or so to get more comments before I start a polishing cycle to add tests, docs, error handling etc.

The next iteration of this one is now done and comments are addressed. The description of this PR should now be also updated to match code modified after the latest comment round. I'll mark this as 'Ready for review' for the next round of discussions.

I don't understand why the e2e test is shouting at me.

@Xantier my guess would be a missing dependency. Doesn't seem like we're running lint either to catch that :<

@Xantier my guess would be a missing dependency. Doesn't seem like we're running lint either to catch that :<

Ended up being a wrong build command I used in the new package.
Last round of comments on this before I write changelogs etc?

So @Xantier, if I’ve understood correctly:
if backend uses packstage-a which uses package-b with package-c as dependency, you want to be able to customize the version of package-c from the outside, without changing the other two packages.
Is this correct?

Is this correct?

That is correct yeah.

Is this correct?

That is correct yeah.

ok thanks! 😄
So, let's assume today we introduce some generic IoC capabilities to backstage.
If a bump my backstage application to the latest and greatest backstage with IoC capabilities, would I be able to inject my custom-package-c version, or some rewriting work need to be done to the chain package-a, package-b, package-c before being able to do such customization?

some rewriting work need to be done to the chain package-a, package-b, package-c before being able to do such customization?

This would need to happen. Alternative option would be to introduce breaking changes to public APIs of package-a, b and c. With IoC solution we would be able to introduce these with current (+ additional, IoC approach specific) APIs.

some rewriting work need to be done to the chain package-a, package-b, package-c before being able to do such customization?

This would need to happen. Alternative option would be to introduce breaking changes to public APIs of package-a, b and c. With IoC solution we would be able to introduce these with current (+ additional, IoC approach specific) APIs.

So, since the code of all packages needs to be changed anyway, can't we just restructure the code of the packages to make package-c injectable without introducing all this IoC framework in backstage?

So, since the code of all packages needs to be changed anyway, can't we just restructure the code of the packages to make package-c injectable without introducing all this IoC framework in backstage?

Absolutely we can, nothing is really impossible in software engineering. The considerations here are to try to make the interfaces of package-a and package-b stable and try to avoid breaking changes to them.
Ideally we'd want to avoid modifying those because of one package-c needs to be injected, since we would need to modify them again in few months when package-d needs to be injected as well.
We can achieve this by constructing a generic object to be passed into each individual package. An object that contains every injectable as an optional property, including hierarchical and shared dependencies of course. Which of course looks very much the same as using an IoC container, in this case the container is just an object that needs to be upkept by changing the public API of the package.

You can do this e.g. with dependency injection, or by mimicking the apiRef pattern in the UI.

As far as I can see, these two are the same thing.

So, since the code of all packages needs to be changed anyway, can't we just restructure the code of the packages to make package-c injectable without introducing all this IoC framework in backstage?

Absolutely we can, nothing is really impossible in software engineering. The considerations here are to try to make the interfaces of package-a and package-b stable and try to avoid breaking changes to them.
Ideally we'd want to avoid modifying those because of one package-c needs to be injected, since we would need to modify them again in few months when package-d needs to be injected as well.
We can achieve this by constructing a generic object to be passed into each individual package. An object that contains every injectable as an optional property, including hierarchical and shared dependencies of course. Which of course looks very much the same as using an IoC container, in this case the container is just an object that needs to be upkept by changing the public API of the package.

You can do this e.g. with dependency injection, or by mimicking the apiRef pattern in the UI.

As far as I can see, these two are the same thing.

but if in a few months package-d needs to be injected, you need to modify them again even if the IoC framework in place 😅
Unless you modify ALL the packages upfront, which isn't doable.

but if in a few months package-d needs to be injected, you need to modify them again even if the IoC framework in place

The difference here in my mind is that one modification is to the public API of a package (breaking change), the other one is adding additional possibility to inject an implementation. In both cases the internals of the package needs to be changed

As far as I can see, these two are the same thing.

Well they're quite different in syntax/setup; explicitly passing dependencies vs using an api dependency graph to initialize the dependencies before bootstrapping the rest of the application.
They are the same as much as the suggested IoC is the same thing as dependency injection, however more complex.
I think it makes sense to provide an example of where this currently is necessary today, especially in core packages, with snippets of examples for how this would work vs using traditional dependency injection. We could then try to see if there's the third option of just architecting this better.
I've worked with many large code bases without needing this type of IoC (which definitely adds complexity and makes it harder to reason what's really running). I think this is a very personal (opinionated) choice of methodology. To me, if the same can be achieved by better composability, that would be a lot cleaner, but maybe I'm missing something.


[WIP] CEA Traverser

Overrode hashCode() method for InequalityEventFilters, ANDEventFilters and OREventFilters.
Ordered filters by repetition to make the ordering of BitSets consistent and easily pick the most selective filters when compiling into java code.
Added BitMapTransition class, which represents a transition as a series of BitSets. It contains the isSatisfiedBy method, which decides if a given BitSet triggers the transition.
Added CEATraverser class, which includes the getNextState method, which receives a state and a BitSet and returns a list containing (next black state, next white state). Null is used to indicate that there is no valid next state. This works by transforming Transitions into BitMapTransitions, which are satisfied if and only if a valid BitSet is given. This should be easy to then transform into java code to compile on runtime, but that's not implemented yet.

Closed as the determinization will now be on the fly, thus this is no longer needed.


View controller: Don’t force image loading to be async

Previously, all image loading (even from cache) was forced to be async. The reason behind this was that we were using collection view cells to track what images belong to what component. But since a while back we’re now using component wrappers for that instead, which means that we can now allow some image loading to be synchronous (that’s up to HUBImageLoader).
This heavily reduces image flickering in view that are rapidly reloaded.

@spotify/objc-dev

Current coverage is 93.34% (diff: 100%)

Merging #239 into master will increase coverage by 0.01%

@@             master       #239   diff @@
==========================================
  Files            70         70
  Lines          4964       4962     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           4633       4632     -1
+ Misses          331        330     -1
  Partials          0          0

Powered by Codecov. Last update bfc0bc7...2e1ec44


Update requirements-train.txt

Limit pytorch-lightning version to be less than 2.0.0, as versions from 2.0.0 upwards seem to be incompatible.
Specifically, it breaks when running training script, e.g.:
python train.py --dataset CIFAR10 --base_network norm_ablations_final --experiment_name resnet_56-nomaxout
output:

TypeError: ClassificationLitModel.configure_gradient_clipping() missing 1 required positional argument: 'optimizer_idx'

Hi,
great catch! Thanks a lot! :smile:


New cover page

@nekrut Just saw your commits on master; I'll merge it in here and get it formatted nicely.

Nice, :+1:  Grazie @dannon!


fix: add missing dependency

Newest near-api-js breaks unless I also yarn install buffer. Seems to be related to the borsh dependency, which does not currently include borsh in its deps.

This is the right thing to do! New versions of Webpack, for instance, have stopped including Node polyfills like Buffer by default. Their position is that anything that's destined to run in the browser must supply its own implementation.
This PR fixes #48.


[Card group - default] Change the functional specs to include an optional card border when in a group

User Story

As a [user role below]:
DDS developer

I need to:
have the Card group - default functional specs

so that I can:
so that I can properly code the Card group - default component that meets the Design functions and intent

Additional information

Overview and scope of the engineering work should be included in the linked epic (#5988 )
Design Issue (#5989 )
A 1 px border is added to the card

Acceptance criteria

[ ] Documented Card group - default functional specifications
[ ] Sent and/or presented the specs to Design and Engineering for their review and comments
[ ] Comment is added with link to functional specs

Functional specs are done for this. https://ibm.box.com/s/rpki0q23o6wyrtvx22je74tbfx1xkcsn


Fix 2gp install scripts

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

QA Passes. Merging


Combine two models in tensorflow

I have checkpoints of two different models in tensorflow.
How to combine them both and save them as one model in one checkpoint file and the resulting computation graph looks like the earlier ones were merged?
What I intend to do is -
Load model 1 weights and configuration
Load model 2 weights and configuration

combine model1 and model2 to get model3

save model3

Also the models 1 and 2 have identical graphs (they are CNNs and have same variable names for tensors)

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 30 days with no activity and the awaiting response label was assigned. Is this still an issue?

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!


Problem with ratings in new version

PHP Version
8.2
Shopware Version
<IP_ADDRESS>
Affected area / extension
Platform(Default)
Expected behaviour
I should be able to write a rating that can only be edited by me.
In addition, as a customer I should only be able to leave a review for a product once.
Actual behaviour
I write a review as user A, which user B can edit.
It is also possible to repeatedly submit a review as user.
How to reproduce
User A logs in and writes a review for an article. User B comes to the same page, but the button shows that he has already written a review and can edit it. He is then shown User A's review and can supposedly edit it (but submitting then leads to an error).
Or what can also happen is that after a reload user A is shown again that he can write a rating and can then send another one, the system does not intercept anything (although actually only one rating per user should be possible).

[public] Automated response: This issue is linked to the internal issue  https://shopware.atlassian.net/browse/NEXT-37995 Pending  .
[created from NEXT-37995, comment 489257]

[public] We have not been able to reproduce this behaviour in the latest version of Shopware with the information available. Please create a new ticket with more information if you think this is a general behaviour. Otherwise, please contact our support team or visit the forum.
[created from NEXT-37995, comment 489308]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-37995, comment 525946]


Random verses api

I am trying to call the random verse api and it does not return a thing in the browser

Is this the URL you are using?
https://bible-api.com/?random=verse

yes this one
On Tue, Sep 17, 2024 at 3:28 PM Tim Morgan @.***> wrote:

Is this the URL you are using?
https://bible-api.com/?random=verse
—
Reply to this email directly, view it on GitHub
https://github.com/seven1m/bible_api/issues/107#issuecomment-2355597861,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2L47OMSNB4KJNQJATPEZQLZXAN47AVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGU4TOOBWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

OK, what happens when you use that URL? Do you get an error? Can you include a screenshot?

I will do so actually what it does is this in post man it returns random
verses but in the browser it is not returning anything that is when i put
it in a try and catch it returns the error message
On Wed, 18 Sept 2024, 17:52 Tim Morgan, @.***> wrote:

OK, what happens when you use that URL? Do you get an error? Can you
include a screenshot?
—
Reply to this email directly, view it on GitHub
https://github.com/seven1m/bible_api/issues/107#issuecomment-2358693734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2L47OKAGSLXR2UHPILHEGTZXGHSXAVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGY4TGNZTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Oh, I see the problem. We are not including the CORS header for this endpoint. I will fix this...

This should work for you now!

You have already fixed the CORS problem
On Fri, 20 Sept 2024, 05:31 Tim Morgan, @.***> wrote:

This should work for you now!
—
Reply to this email directly, view it on GitHub
https://github.com/seven1m/bible_api/issues/107#issuecomment-2362586195,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2L47OPUJWIVSPLSPY6ZRPLZXOCG7AVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGU4DMMJZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't understand what you mean. I did indeed fix the CORS problem. Can you verify your original issue is now fixed?

Thank you
Let me verify and i will let you know
On Sun, 22 Sept 2024, 03:42 Tim Morgan, @.***> wrote:

I don't understand what you mean. I did indeed fix the CORS problem. Can
you verify your original issue is now fixed?
—
Reply to this email directly, view it on GitHub
https://github.com/seven1m/bible_api/issues/107#issuecomment-2365381201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2L47OI2B4W4API4QQGM6I3ZXYG6FAVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM4DCMRQGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Templates should work for inner functions

Templates defined in outer function should be visible in annotations of inner functions.
E.g. in the following code snippet, TYPE is not recognized as a type in jsdoc for minus function.
/**
 * @param {TYPE} a
 * @param {TYPE} b
 * @template TYPE
 * @return {TYPE}
 */
function max(a, b)
{
    /**
     * @param {TYPE} a
     * @param {TYPE} b
     * @return {TYPE}
     */
    function minus(a, b)
    {
        return a - b;
    }

    return minus(a, b) < 0 ? b : a;
}

+1
Here's another use case:
I have a generic function and need to refer to the template type "T" within the body:
/**
 * @template T
 * @param {Array<T>} a
 * @return {Array<T>}
 */
let f = function(a) {
  return a.map((/** @type {T} */t) => {
    // (do something to t)
    return t;
  });
}

Without this, inside the map function, 't' is unknown type to the compiler (which may be a separate bug similar to https://github.com/google/closure-compiler/issues/1194 - should I file this too?).
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%250A%2520*%2520%2540template%2520T%250A%2520*%2520%2540param%2520%257BArray%253CT%253E%257D%2520a%250A%2520*%2520%2540return%2520%257BArray%253CT%253E%257D%250A%2520*%252F%250Alet%2520f%2520%253D%2520function(a)%2520%257B%250A%2520%2520return%2520a.map((%252F**%2520%2540type%2520%257BT%257D%2520*%252Ft)%2520%253D%253E%2520%257B%250A%2520%2520%2520%2520%252F%252F%2520(do%2520something%2520to%2520t)%250A%2520%2520%2520%2520return%2520t%253B%250A%2520%2520%257D)%253B%250A%257D%250A%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1


Inside EC2 R4.xlarge results

Tanay and I have been iterating for the last week on why EC2 is failing for us. I manually created an instance identical to the deployed AMI, and explored how things were working:

the volume is actually only 15 gigs, NOT 22 gigs. Also, it is mounted to /dev, and not /, which I am wondering whether the docker container will even see this space.

The image below is from inside an EC2 instance, R4.xlarge, on the same AMI deployed by batch:

the volume the docker container is given is NOT on the entire 22 gigs; it is only given 10 gigs
This image below is from inside an EC2 instance, R4.xlarge, inside the docker container:

note that we have a 10 gig partition, not the full 15 gigs that we expected.

https://forums.aws.amazon.com/thread.jspa?threadID=240596

http://www.projectatomic.io/blog/2016/03/daemon_option_basedevicesize/ soln??


[BUG] after authentication Firestore still return 403 on get_doc() (4.x)

Describe the bug
My code
# Anonymous login
Firebase.Auth.login_anonymous()
await Firebase.Auth.signup_succeeded
# Connect to collection
var collection = Firebase.Firestore.collection("users")
print_debug(collection.auth.idtoken) #to be tested externally
print_debug(collection._base_url + collection._extended_url + collection.collection_name) #to be tested externally
# Get document
var document = await collection.get_doc("1")

Returns
  [Firebase Error] >> Action in error was: 4
  [Firebase Error] >> Missing or insufficient permissions.

Is Firebase set up correctly?
I assume so, because when I use the access token printed out from collection.auth.idtoken in a browser javascript console test, I receive the requested document.
This is what I use in my JS console test:
const accessToken = '[TOKEN_FROM_GODOT_PRINT_DEBUG]'; // Replace with the access token you obtained

// Firestore REST API endpoint for reading a document
const firestoreEndpoint = `https://firestore.googleapis.com/v1/projects/${projectId}/databases/(default)/documents/${collectionPath}/${documentId}`;

// Make the Firestore document read request
fetch(firestoreEndpoint, {
  method: 'GET',
  headers: {
    'Content-Type': 'application/json',
    'Authorization': `Bearer ${accessToken}`,
  },
})
  .then(response => response.json())
  .then(data => {
    // The document data is available in the 'fields' property of the response
    const documentData = data.fields;
    console.log('Document Data:', documentData);
  })

The uri in the second print_debug matches what I am fetching in JS . The auth.idtoken is generated by the godot request.
The only thing that I haven't tried yet is to reduce the number of warning messages I have such as
"[Firebase] >> The value for databaseURL is not configured. If you are not planning to use it, ignore this message."
I would expect that the error wouldn't be 403 if it was missing that URL
To Reproduce
Steps to reproduce the behavior:

Add GodotFirebase 4.x addon to a Godot project
Create .env file an populate it with what is available in your firebase project (this step could be described in more details)
Add the code snippet given above to a script file that you can execute in a scene
Run the scene

Expected behavior
A clear and concise description of what you expected to happen:
"var document = await collection.get_doc("1") should not return an error"
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:
OS: Ubuntu
broswer: Fitefox (?)
Godot: v.4.1
addon branch: 4.x
Additional context
This is my first attempt to run Firestore with Godot, so I might be missing something basic.

Can you show me a pic of your Firestore, like where the document exists and stuff? Don't need to see the url or anything like that, just the inner part, and no contents of the document. I assume since it's just "1" it's not important, but you never know! It is possible also that you do need permissions setup correctly in your Firestore - what do your Firestore rules look like?

Hi @WolfgangSenff , thank you for your quick response. It is just a test database, so I can share some screenshots

My rules are
rules_version = '2';

service cloud.firestore {
  match /databases/{database}/documents {
    match /{document=**} {
    	allow get: if request.auth != null;
    }
  }
}

I am not using "App Check" which is probably the only thing remaining in Frestore that could be missing.
My thinking is that if I can simulate a get through the browser with a token received by Godot, then I should look in Godot.

I can't recall exactly the circumstances, but last I remember, there was an error with that specific rules version with the REST API. But regardless of that, you may want to download our integration tester, found here: https://github.com/GodotNuts/GodotFirebaseTestHarness/tree/4.x (note the branch), and run the Firestore tests. It should help determine what's wrong, though if others were having the same issue, we would definitely have heard about it, so I suspect it's just whatever you have. If that doesn't work, try opening up the rules completely just for a minute to retest.

Oh, obviously with the tester, you have to fill in your own info for the .env file.

So after multiple attempts including with the tester project that you linked to, I found that the problem was using the word "get" instead of "read" in my rules as @WolfgangSenff suggested earlier. Strangely both the firestore rules playground and the js fetch test were able to work with the 'get' rule , but the addon not.
I would close the bug if you are not interested in investigating further.
Thank you very much for the support.

That's pretty weird! I may ask the Firebase team to see if that's a known issue, because we don't do anything with the rules on our side.

In the rules, allow read write is already written not get as in the issue you mentioned


request_id: Allow always setting x-request-id header in response

Description:
Currently non-configurable Envoy behavior is to return x-request-id header in response iff the tracing is forced.
It would be nice to have a configuration option to allow always returning the header in response.
It is especially useful for cross-correlating client-side debug logs with access logs on server side.

I thought we already had an issue on this but I can't quickly find it, +1.


docs: update readme links to website

We can merge this now or wait for https://github.com/yazi-rs/yazi-rs.github.io/pull/16 and update the showcase link as well.

LGTM, thank you!


Restructure readme

This is a draft modify since I make some major modifications on the whole structure and I am not sure if this is better than the version in #80.

Add table of contents.
Separate section for quick start.
Divide Getting start into three sections: Env, Build, and Run.

LGTM. @mssun Could you help to review this documentation? Thanks!

@DemesneGH, I'm okay with the changes. Please squash into one commit and merge. Thanks!

Merged, thanks!


Can't get this to work in self hosted REPL

Following the README  just gets me
TypeError: Cannot read property 'line_chart' of undefined

Also followed Option 2. Opinionated, Complete, Best Way to Setup Atom for Clojure Development with Proto REPL for setting up

OK thanks!


deploying cfcr using deployk8

getting below exception , when deploying  cfcr using deployk8 script.
type: certificate
Fetching info:
Performing request GET 'https://kubo:25555/info':
Performing GET request:
Retry: Get https://kubo:25555/info: Bad Gateway

It seems that you have not configured your bosh director.
Have a look here how to properly set up this step.
Once you are ready, this README file should have all the steps to deploy CFCR
link

@techie20122018
Thanks for pointing out this issue, we added a deprecation notice in our docs for the scripts.
We hope you managed to deploy CFCR, if you run into any other issues with your cluster please open a new issue.


Bump to opendal version 0.45.1

What's Changed
Added

feat(services/vercel_blob): support vercel blob by @hoslo in https://github.com/apache/opendal/pull/4103
feat(bindings/python): add ruff as linter by @asukaminato0721 in https://github.com/apache/opendal/pull/4135
feat(services/hdfs-native): Add capabilities for hdfs-native service by @jihuayu in https://github.com/apache/opendal/pull/4174
feat(services/sqlite): Add list capability supported for sqlite by @jihuayu in https://github.com/apache/opendal/pull/4180
feat(services/azblob): support multi write for azblob by @wcy-fdu in https://github.com/apache/opendal/pull/4181
feat(release): Implement releasing OpenDAL components seperately by @Xuanwo in https://github.com/apache/opendal/pull/4196
feat: object store adapter based on v0.9 by @waynexia in https://github.com/apache/opendal/pull/4233

Changed

refactor(bindings/python): simplify async writer aexit by @suyanhanx in https://github.com/apache/opendal/pull/4128
refactor(service/d1): Add D1Config by @jihuayu in https://github.com/apache/opendal/pull/4129

Fixed

fix: Azdls returns 403 while continuation contains = by @Xuanwo in https://github.com/apache/opendal/pull/4105
fix(bindings/python): missed to call close for the file internally by @zzl221000 in https://github.com/apache/opendal/pull/4122
fix(bindings/python): sync writer exit close raise error by @suyanhanx in https://github.com/apache/opendal/pull/4127
fix(services/chainsafe): fix 423 http status by @hoslo in https://github.com/apache/opendal/pull/4148
fix(services/webdav): Add possibility to answer without response if file isn't exist by @AJIOB in https://github.com/apache/opendal/pull/4170
fix(services/webdav): Recreate root directory if need by @AJIOB in https://github.com/apache/opendal/pull/4173
fix(services/webdav): remove base_dir component by @hoslo in https://github.com/apache/opendal/pull/4231
fix(core): Poll TimeoutLayer::sleep once to make sure timer registered by @Xuanwo in https://github.com/apache/opendal/pull/4230

Docs

docs: add request for add secrets of services by @suyanhanx in https://github.com/apache/opendal/pull/4104
docs(website): announce release v0.45.0 to news by @morristai in https://github.com/apache/opendal/pull/4152
docs(services/gdrive): Update Google Drive capabilities list docs by @jihuayu in https://github.com/apache/opendal/pull/4158
docs: Fix docs build by @Xuanwo in https://github.com/apache/opendal/pull/4162
docs: add docs for Ceph Rados Gateway S3 by @ZhengLin-Li in https://github.com/apache/opendal/pull/4190
docs: Fix typo in core/src/services/http/docs.md by @jbampton in https://github.com/apache/opendal/pull/4226
docs: Fix spelling in Rust files by @jbampton in https://github.com/apache/opendal/pull/4227
docs: fix typo in website/README.md by @jbampton in https://github.com/apache/opendal/pull/4228
docs: fix spelling by @jbampton in https://github.com/apache/opendal/pull/4229
docs: fix spelling; change github to GitHub by @jbampton in https://github.com/apache/opendal/pull/4232
docs: fix typo by @jbampton in https://github.com/apache/opendal/pull/4234
docs: fix typo in bindings/c/CONTRIBUTING.md by @jbampton in https://github.com/apache/opendal/pull/4235
docs: fix spelling in code comments by @jbampton in https://github.com/apache/opendal/pull/4236
docs: fix spelling in CONTRIBUTING by @jbampton in https://github.com/apache/opendal/pull/4237
docs: fix Markdown link in bindings/README.md by @jbampton in https://github.com/apache/opendal/pull/4238
docs: fix links and spelling in Markdown by @jbampton in https://github.com/apache/opendal/pull/4239
docs: fix grammar and spelling in Markdown in examples/rust by @jbampton in https://github.com/apache/opendal/pull/4241
docs: remove unneeded duplicate words from Rust files by @jbampton in https://github.com/apache/opendal/pull/4243

CI

ci: Use old version of seafile mc instead by @Xuanwo in https://github.com/apache/opendal/pull/4107
ci: Refactor workflows layout by @Xuanwo in https://github.com/apache/opendal/pull/4139
ci: Migrate hdfs default setup by @Xuanwo in https://github.com/apache/opendal/pull/4140
ci: Refactor check.sh into check.py to get ready for multi components release by @Xuanwo in https://github.com/apache/opendal/pull/4159
ci: Add test case for hdfs over gcs bucket by @ArmandoZ in https://github.com/apache/opendal/pull/4145
ci: Add hdfs test case for s3 by @ArmandoZ in https://github.com/apache/opendal/pull/4184
ci: Add hdfs test case for azurite by @ArmandoZ in https://github.com/apache/opendal/pull/4185
ci: Add support for releasing all rust packages by @Xuanwo in https://github.com/apache/opendal/pull/4200
ci: Fix dependabot not update by @Xuanwo in https://github.com/apache/opendal/pull/4202
ci: reduce the open pull request limits to 1 by @jbampton in https://github.com/apache/opendal/pull/4225

Chore

chore(deps): bump actions/cache from 3 to 4 by @dependabot in https://github.com/apache/opendal/pull/4118
chore(deps): bump toml from 0.8.8 to 0.8.9 by @dependabot in https://github.com/apache/opendal/pull/4109
chore(deps): bump dav-server from 0.5.7 to 0.5.8 by @dependabot in https://github.com/apache/opendal/pull/4111
chore(deps): bump assert_cmd from 2.0.12 to 2.0.13 by @dependabot in https://github.com/apache/opendal/pull/4112
chore(deps): bump actions/setup-dotnet from 3 to 4 by @dependabot in https://github.com/apache/opendal/pull/4115
chore(deps): bump mongodb from 2.7.1 to 2.8.0 by @dependabot in https://github.com/apache/opendal/pull/4110
chore(deps): bump quick-xml from 0.30.0 to 0.31.0 by @dependabot in https://github.com/apache/opendal/pull/4113
chore: Make every components seperate, remove workspace by @Xuanwo in https://github.com/apache/opendal/pull/4134
chore: Fix build of core by @Xuanwo in https://github.com/apache/opendal/pull/4137
chore: Fix workflow links for opendal by @Xuanwo in https://github.com/apache/opendal/pull/4147
chore(website): Bump download link for 0.45.0 release by @morristai in https://github.com/apache/opendal/pull/4149
chore: Fix name DtraceLayerWrapper by @jayvdb in https://github.com/apache/opendal/pull/4165
chore: Align core version by @Xuanwo in https://github.com/apache/opendal/pull/4197
chore: update benchmark doc by @wcy-fdu in https://github.com/apache/opendal/pull/4201
chore(deps): bump clap from 4.4.18 to 4.5.1 in /bin/oli by @dependabot in https://github.com/apache/opendal/pull/4221
chore(deps): bump serde from 1.0.196 to 1.0.197 in /bin/oay by @dependabot in https://github.com/apache/opendal/pull/4214
chore(deps): bump anyhow from 1.0.79 to 1.0.80 in /bin/ofs by @dependabot in https://github.com/apache/opendal/pull/4209
chore(deps): bump anyhow from 1.0.79 to 1.0.80 in /bin/oli by @dependabot in https://github.com/apache/opendal/pull/4216

New Contributors

@zzl221000 made their first contribution in https://github.com/apache/opendal/pull/4122
@jihuayu made their first contribution in https://github.com/apache/opendal/pull/4129
@asukaminato0721 made their first contribution in https://github.com/apache/opendal/pull/4135
@jayvdb made their first contribution in https://github.com/apache/opendal/pull/4165
@AJIOB made their first contribution in https://github.com/apache/opendal/pull/4170
@ZhengLin-Li made their first contribution in https://github.com/apache/opendal/pull/4190
@waynexia made their first contribution in https://github.com/apache/opendal/pull/4233

To review the most important things of this PR, please using:
git di main **/Cargo.toml **/package.json **/pom.xml


Better esm support

I noticed in https://github.com/zeit/webpack-asset-relocator-loader/pull/27 esm support was added but only in the cases of require = require('esm')(module);.
What doesn't seem to be supported is this.
const _require = require('esm')(module);
const myModule = _require('my-module');

@guybedford any chance you could help on this?

I haven't checked but I don't believe this supports passing the options object to esm either.
For example:
const options = {};
const _require = require('esm')(module, options);
const myModule = _require('my-module');

Wouldn't it make more sense to just replace require('esm') and leave the rest?


Updated quickstart-create-logic-app-with-visual-studio.md

Updated quickstart-create-logic-app-with-visual-studio.md to mention PowerShell window pop-up with screen shot.

@rasavant-ms : Thanks for your contribution! The author, @ecfan, has been notified to review your proposed change.

Is there any tool I can use to make sure that the image satisfies these required constraints -
The image must not exceed 800 pixels in width. Please reshoot image at 100% zoom.
Please make sure there are no extra pixels outside the screenshot borders.
Please use a 2 pixel border with this RYB setting: 195, 195, 195

Looks good, thanks! #sign-off

@rasavant-ms : Thanks for your contribution! The author, @ecfan, has been notified to review your proposed change.

#sign-off


Try not to let HNil.type get into the wild

Alternatively, the sealed trait HNil could be removed, and case object HNil extends HNil changed to case object HNil extends HList, with a type alias type HNil = HNil.type.

Am I dreaming, or has this PR (and some others) mysteriously come back from the dead?

Doesn't making the HNil object private mean you can't match case HNil anymore and you have to case _: HNil?

Yes, that would follow. I'm open to being persuaded that that's not important however ... pattern matching on an HList isn't a particularly common operation. I think that's a big enough change that I'd want to punt to 3.0.0.
@doolse can you make a compelling argument in favour of this change? Otherwise I think I'll close.

Closing for now.


chore: dw-lisbon-go to 0.0.4

chore: Promote dw-lisbon-go to version 0.0.4

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


big size library version with big list of names, places & English words for use in Offline Apps/extension

I would like to use this library in my extension and app, which will be optimized for a good experience after installation and not payload size.
it is not detecting "White House" as a place, and many more cases..
at the end of the day, you need a list of the names and places to work correctly close to 100% of the time.
is there a possibility to have a "Offline version" of this library that can be several Mega bytes  in size. not just the 100 Kilo byte library.

hey Wesam, that's great. Yeah, this is possible using a custom lexicon. You can make it any size you want, and tag 'white house' as a Place, or whatever. You can see the existing known words here
we're working on a new version that lets you compress your own lexicon, like we do internally. It should be ready in a few weeks

Thanks Spencer @spencermountain.
this video is fascinating!
the issue is that according to zipf's law, few words are used so often and so many words are used rarely. and you need to have a list of them all to work correctly 100% of the time, I imagine the perfect complete uncompressed list would be a 1 or few hundred mega bytes in size in memory with JS vm's UTF-16 encoding (16 bits/2 bytes per character).
this is not a problem for my case.
now I gotta make the lists and start testing.

:smile: yeah! zipfs was the whole reason i started this project. It's the best. Our internal wordlist is something like 16,000 words, once the conjugations are all blasted-out and everything. It's still way-smaller than jquery, uncompressed.

would love some help getting it right at the best trade-offs for filesize. Take a peek around and see if there's anything that can be done better. As I said, work's underway to expose our word compression library in the api, so people can throw fat wordlists into the web-browser without busting anything.
you sound like my type of dude!

:+1: for exposing the word compression library in the API.

neato! great compression ratios, and the project its based on are very interesting also.
check out SMAZ maybe there's anything to learn from it.
I would be glad to contribute if I can in any way.

agh, this library is a thing of beauty. Thanks for sharing it. Just getting back from holidays.
so it looks like it compresses common substrings into integers, using a custom mapping. - This is not my expertise - chars are 16 bits each? but you can get 8 bit integers with that Uint8Array thing?
is there a clever way to serialize it for going over the web? json? .. back to a string?

The Uint8Array typed array represents an array of 8-bit unsigned integers (0-255). [0]
Both UTF-8 and UTF-16 are variable length encodings. However, in UTF-8 a character may occupy a minimum of 8 bits, while in UTF-16 character length starts with 16 bits. [1]
UTF-16 uses a minimum of 2 bytes/16 bits. This makes it incompatible with ASCII. [1]
Javascript engines use UCS-2 or UTF-16 internally.  [2]
Yeah, these common substrings were generated by a ruby script from English corpuses and the English Wikipedia, according to the original author in a HackerNews thread.
we can make a better list, I don't think ".com" or "</" etc. are common in English words/text.
compromise only supports English and maybe in the future the Romance Languages, so we can use ASCII
serializing compressed text to json defeats the purpose I believe.
[0] - Uint8Array - MDN
[1] - Difference between UTF-8 and UTF-16? - StackOverflow
[2] - JavaScript’s internal character encoding: UCS-2 or UTF-16?

hey - i've been thinking of another thing I wanted to bounce off you.
A lot of people are using compromise to parse a big document, and then search it for a list of known words - like, here's my huge list of cities, which ones are in this doc..
i wanna build some kind of word index. right now we (i know..) are just looping through each term in the document.

the words change (the index becomes dirty)
we're not matching sub-string, just full-on str===word
it's gotta support multiple-word sequences (like 'toronto raptors')

i was looking at trying to make aho-corisack algorithm per-word, instead of per-character, but couldn't wrap my head around it.
any ideas?

you should try SMAZ with your abbrevs list and see the resulting compression ratios,
why not have an application specific English encoding method like ascii but in place of the terminal characters like ╝ ╟ have the abbrevs list (I know they are 2-3 chars long, that's the point).
i'm sure you are stronger than me in algorithms, i'm not tbh, buti'm thinking about that.

hey, I looked into SMAZ and found the trie-stuff in efrt was more suited to our purposes. @wesamco it's a little rough still, but you can see how it's possible now to ship a big lexicon with more metadata in v11, as a plugin
lemme know if you see anything weird
cheers


Swift Package Manager Support

Hi, can you please add support for Swift Package Manager and include the installations instructions in the .readme?

    add to your dependencies inside package file

.package(url: "https://github.com/contentful/rich-text-renderer.swift", .upToNextMajor(from: "0.4.0")) then to target
               .product(name: "ContentfulRichTextRenderer", package: "rich-text-renderer.swift")


Incorrect input not validated / mishandled

Enter an invalid node-ID and start the transport. The correct behavior is to display an error message. The actual behavior is that nothing appears to happen.

Same problem if the port is not accessible due to lack of permissions.

This seems solved, I hope you agree
@pavel-kirienko

Nice. Let us please only record the stack trace in the messages view; the UI element shown on the screenshot should only contain the error message, that is, str(ex) or repr(ex).
The last error message appears misformatted.


feat: dynamic height checkbox group standardization

Description

Wrapped the CheckboxGroup default component in the React.forwardedRef so that the incoming ref from the parent widget can be hooked up with the CheckboxGroupContainer.
Hooked the BaseWIdget contentRef to the CheckboxGroupContainer component via CheckboxGroup Widget.

Fixes #13049
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: feature/dh-stdzn-checkbox-group

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
app/client/src/selectors/commentsSelectors.ts
83.61 (-1.64)
61.76 (-2.95)
73.33 (0)
88.24 (-2.35)

:green_circle:
app/client/src/widgets/BaseWidget.tsx
80 (0.16)
48.94 (0)
76.47 (0)
79.2 (0.17)

:green_circle:
app/client/src/widgets/CheckboxGroupWidget/component/index.tsx
35 (3.42)
8.89 (0)
0 (0)
41.18 (3.68)

/ok-to-test sha=67bf9c0

cc @vivekverma2312

Completed testing. Moving to Done.


[usecase] Add READ_EXTERNAL_STORAGE permission

Camera, FileReader,FileSystem also need this permission for external storage.
This permission is added default in make_apk.py before.
Failure reason: XWALK-6430 html5 capture api always use camcoder even for images

Impacted tests(approved): new 0, update 3, delete 0
Unit test platform: Crosswalk Project for Android 19.48.497.0
Unit test result summary: pass 2, fail 1, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-6032

LGTM


[Bug] useMoney Hook Error: Incorrect locale provided (hydrogen-react package)

What is the location of your example repository?
No response
Which package or tool is having this issue?
hydrogen-react
What version of that package or tool are you using?
2023.4.4
What version of Remix are you using?
No response
Steps to Reproduce
This happens when using the useMoney hook from hydrogen-react when having a language iso code with more then 2 characters. For example: 'PT_PT', 'PT_BR'.
Meaning that there are possible locales like: PT_PT-PT, PT_PT-BR, PT_ES
So there is a combination of the country iso code (that are always 2 digits) - documentation here - and language iso code (that can be 2 digits - XX - or 5 digits - XX_XX) - documentation here
Expected Behavior
It should take into count that are possible iso codes that have more then two characters.
Actual Behavior
It should take into count that are possible languages iso codes that have more then two characters.
Related issue: [BUG] useMeasurement and useMoney Hooks Error: Incorrect locale information provided #1800

Hello @lordofthecactus and @frehner,
Sorry to ping you but I think you are familiar with this issue.
Thanks,
Daniel

Hi @danf97, thank you for spotting this bug. we'll get a release out with a fix that make sure we stripe out SFAPI specific language strings so that it works with Intl.NumberFormat spec.

we'll get a release out with a fix that make sure we stripe out SFAPI specific language strings

@wizardlyhel does this mean that there will be a change to the language and money codes in the near future?

Not on the storefront API - just within Hydrogen


feat: adds atlantis

Description of the change
atlantis is a app for managing Terraform but, using gitops way.
Benefits
ability to manage terraform using git and github.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


Add aws client

Issue #, if available:
#1573
Description of changes:
AWS Client for snow preflight validation.
Testing (if applicable):
unit testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

All exported package names should have good documentation and documenting non trivial unexported names is strongly encouraged.

/lgtm


Hotfix RetrievalQA Docs: docs: Fix formatting

Newline Characters breaking formatting
Description:
As you can see in the image below, the formatting in the documentation is broken. As far as I can see the two added \n characters are breaking the documentation. Therefore I would propose to remove those

Dependencies:
None
Twitter Handle

epu9byj

Great catch thanks.


RDA fails for non-test datasets

Running skbio.stats.ordination.RDA on an experimental dataset where y.shape is (154, 1369) and x.shape is (154, 1), I get the following error:
ValueError: Shape of passed values is (154, 1), indices imply (153, 1)
which is triggered by:
https://github.com/biocore/scikit-bio/blob/master/skbio/stats/ordination/_redundancy_analysis.py#L211
I haven't figured out why this was causing a problem for my data case but not for the test data; obviously there's a shape mismatch in pc_ids and the biplot_scores which exists before line 211 but where that comes from I don't yet know.
If I regress biplot_scores to biplot_scores = pd.DataFrame(biplot_scores) then I get "correct-looking" results (as in the data are beautifully separated per experimental design), but the module then fails build tests. I started getting my hands dirty in the testing code but got caught up in firefighting at the wetlab bench before I could figure it out. Is there an online version of Legendre & Legendre I can read?

Indeed the problem occurs at the when scores are wrapped up into a pd.DataFrame, i.e.
biplot_scores = pd.DataFrame(biplot_scores,
                          index=x.columns,
                          columns=pc_ids[:biplot_scores.shape[1]])

pc_ids is a list that must define the columns names, but seems to have one element less than the number of columns of biplot_scores. I can't tell which one is correct though.

At line 184, the length of eigenvalues can be less than the number of columns of corr(X, u) (line 210).
To make sure that there is enough ids in pc_ids, we could change
pc_ids = ['RDA%d' % (i+1) for i in range(len(eigenvalues))]
to
pc_ids = ['RDA%d' % (i+1) for i in range(u.shape[0])]
Then lines 185, 191 to 203 and 218 might change accordingly.
185: eigvals = pd.Series(eigenvalues, index=pc_ids[:len(eigenvalues)])
191 to 203
feature_scores = np.hstack((U, U_res)) * scaling_factor
sample_scores = np.hstack((F, F_res)) / scaling_factor

feature_scores = pd.DataFrame(feature_scores,
                              index=feature_ids,
                              columns=pc_ids[:feature_scores.shape[1]])
sample_scores = pd.DataFrame(sample_scores,
                             index=sample_ids,
                             columns=pc_ids[:sample_scores.shape[1]])
# TODO not yet used/displayed
sample_constraints = np.hstack((Z, F_res)) / scaling_factor
sample_constraints = pd.DataFrame(sample_constraints,
                                  index=sample_ids,
                                  columns=pc_ids[:sample_constraints.shape[1]])

218: p_explained = pd.Series(eigenvalues / eigenvalues.sum(), index=pc_ids[:len(eigenvalues)])
What do you think?

@essicolo that should just fix it.
Would you like to push in a small PR + unittests to address this fix?

I would have done it if only I was a git zen master! I already have a pending PR. I just don't know how to create a second fork...

I'd do it, but

I already have a pending PR and don't know how to create a second one.
I'm not sure if residual columns should be named RDA. The R vegan package name them PC.

Awesome.
The way to do it is to create different branches.  Typically, it is a good idea not to have PRs pushed from master, so that you can force master to be up-to-date with the upstream repository.
If you don't have the upstream repo set yet, run
git remote add upstream https://github.com/biocore/scikit-bio

Then you can create use branches identical to the ones on scikit-bio master as follows
git checkout -b rda-fix
git fetch upstream
git reset --hard upstream/master

Finally got it! https://github.com/biocore/scikit-bio/pull/1529


Samba share config and Configurator config differ

I'm experiencing that the config file I can edit with the Configurator is different from that I can edit via the Samba share. The file shown by Configurator is up to date whilst that shown by Samba is the default. Hassio 0.61

Updated to 0.62.1 and issue persists

Browser cache?

The file open in atom has a dash at the end, indicating that there are more than one file open with the same name, in different locations. At least, that's how it works for me.

/move to hassio-addons


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4094

Questions ?
Please refer to the Backport tool documentation


[Enhancement] Make the frontend more user friendly and minimalistic

Issue:
Improve frontend usability and minimalism
Description:
The objective of this task is to enhance the frontend to provide a better user experience by making it more intuitive, user-friendly, and minimalistic. The focus will be on simplifying the design, improving navigation, and optimizing user interactions.
Approach: I will analyze user feedback and research industry best practices to ensure that the changes align with user expectations and industry standards.
i would like to solve this issue , please assign me this issue.

Hello , I am a frontend developer and this issue is quite interesting for me . Kindly assign it.

I am pooja verma and i want to make a significant contribution on the ongoing issues related to the project.kindly assign me this task

Hi there!
As a contributor in GSSoC 24 with a strong command in web design, I'd like to take on this issue. Could you please assign it to me?

@Adi-gitX I have assigned you this issue, please start working on it.

I would like to contribute to this issue Could you please consider assigning this issue to me? I'm committed to dedicating my time and effort to delivering a high-quality design that aligns with the project's goals.
Looking forward to the opportunity to work on this exciting project!

Hii! I would like to work on this issue kindly assign this issue to me


does gibbed just not work anymore?

when i edit a save like giving a weapon, giving money, iridium, skill points it just does not carry over into the game

Then you are not updating your save properly, in whatever way. If you have the game running then try having the game not running when you make your save.

or does gib just not premade saves like the ones from nexus i got some from here https://www.nexusmods.com/borderlands2/mods/14

nope still dont work wether i have the game running or not

[
](url)

wow even editing the skill grade in raw does not work

really think you should update this because nothing works

It's not an issue with the editor, but your usage of it. Sorry, I don't know what your issue is.

This may be late on the reply, but my brother pointed out to me skill points dont work. Looking it up, i learned BL2 has sanity checks on skills. it checks skill points, skill levels, etc. If it sees something out of place, it resets you to a "proper" amount.
it's not that the editor doesn't work (technically, it does) it is simply the itself game keeps re-editing the save during load.


geodesics_static: Refactor the ScatterGeodesicsPlotter into its own file.

🐞 Problem
GeodesicsScatterPlotter class is currently written in the file geodesics_static.py, which should be meant for GeodesicsStaticPlotter.

🎯 Goal
Refactor the code for GeodesicsScatterPlotter into its own file.

💡 Possible solutions

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

I'll be adding a PR for this issue before tomorrow.


request.send() returns a 404 response when it gets an UnknownHostException

Based on the following code this appears to be intentional:
  Response(HttpURLConnection connection) throws IOException
  {
    try
    {
      connection.connect();
      code = connection.getResponseCode();
      headers = parseHeaders(connection);
      stream = isSuccessful() ? connection.getInputStream() : connection.getErrorStream();
    }
    catch (UnknownHostException e)
    {
      code = 404;
      body = Response.EMPTY;
    }
  }

I just burned an hour trying to figure out why my emulator was returning a 404 when it appeared to not be connecting to the server at all. Now I see it was a networking configuration problem and a bizarre design choice working in tandem.
Being unable to resolve a hostname and getting a 404 response are completely different. The method calling send() should be informed in a different way that an UnknownHostException occurred.

First of all thanks for reporting the bug. This has been fixed in master and will be included in the following release. Some comments:

I just burned an hour trying to figure...

Please also include the hours that you did not burn in trying to create the OAuth signatures yourself. The time you spend debugging my lib would be relevant if I worked for you, which is not the case.

a bizarre design choice

"Un-bizzarring" pull requests are welcome. Also, you should reconsider using a library that has a bizzarre design. I suggest you pick another one, or build your own.


ARTEMIS-800: Add + pattern to the MQTT pubsub example

This edits the basic pubsub example showing Artemis can work with MQTT and adds one more use case with a + topic.

The check was aborted. I will reach out to the Apache ActiveMQ maintainers on the mailing list.

Thanks for rerunning the build! The build shows success:


Generated by :no_entry_sign: Danger


Vanguard

Hello, as of today vanguard has been implemented in lol. Are we at risk of being banned if we use this tool?

I'm not aware of vanguard being released on any live servers as of yet. As soon as vanguard is live, parts of this tool will become risky, although they haven't been clear at all in their communication of what is allowed and what isn't.

Is there no way to contact a rioter through a ticket or something? Your application is too good to leave it like this

In the only communication we received, which contains straight up contradictory statements (https://www.riotgames.com/en/DevRel/vanguard-faq), they said they won't be answering any clarifying questions.

They are doing the same thing as with Linux users with the Wine application. It's sad that everything goes like this.


is using someone else's file dh.pem file a good idea?

Using someone else's file, especially in the context of security parameters like Diffie-Hellman (DH) parameters, is generally not recommended for several reasons:

Security Risks: Using parameters that are not generated in a secure environment or that have been shared publicly can pose significant security risks. These parameters could be tampered with or weakened, making them susceptible to cryptographic attacks.
Integrity Issues: You cannot be certain of the integrity of the parameters if they are not generated or audited by a trustworthy source. This uncertainty can compromise the entire security model of your communication system.
Unique Requirements: Different applications may have unique security requirements which predefined parameters might not meet. Customizing these parameters according to the specific security needs of your application is crucial.
Regulatory and Compliance Issues: Depending on the industry and data protection regulations applicable to your organization, using pre-generated or third-party cryptographic materials may not comply with regulatory standards.

Recommendation:
It's best to generate your own DH parameters using a trusted tool like OpenSSL, ensuring they are tailored for your specific application and meet current security standards. Here’s how you can generate DH parameters using the OpenSSL command-line tool:
openssl dhparam -out dhparams.pem 2048


Support deferred components on desktop platform(MacOS/Windows/Linux)

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case

On the desktop side, we want to achieve code dynamic based on different interfaces which rely on the implementation of deferred components, so we can only globally update app. so, we cannot only update a certain part.
We have two different flutter process and two app.so in one application. We want use deferred components to reduce app size by sharing the same compiled file(flutter framework compile separately)

Related:

https://github.com/flutter/flutter/issues/79327.

Proposal
Deferred components was implemented for Android in https://github.com/flutter/flutter/issues/57617. We should support similar functionality on desktop(MacOS/Windows/Linux).

Provider APIs like LoadDartDeferredLibrary and LoadDartDeferredLibraryError and RequestDartDeferredLibrary on embedder.h
Support platform code in shell/platform/(darwin|windows|linux)
Add build tools params to build part aot files.

I just saw the same issue, but I don't think the response from that issue has solved my problem. The implementation of delayed components does not require code push capabilities. We only need to provide relevant APIs, and code push can be implemented by users themselves.

Use case
Deferred components was implemented for Android in #57617. We should support similar functionality on desktop(MacOS/Windows/Linux).

This isn't a use case; a use case would be a problem you are trying to solve, not a suggested solution. What is the use case you are trying to support?

We only need to provide relevant APIs, and code push can be implemented by users themselves.

As it says in the issue referenced, this is not correct. Implementing deferred components does not allow code push updates. They are unrelated functionality.

This isn't a use case; a use case would be a problem you are trying to solve, not a suggested solution. What is the use case you are trying to support?

Thanks for your reply. I have edited the above content again.

As it says in the issue referenced, this is not correct. Implementing deferred components does not allow code push updates. They are unrelated functionality.

Yes. I don't want to implement code push in this issue.

Yes. I don't want to implement code push in this issue.

FYI, deferred components is not a step towards code push. Deferred components must be from the compilation; you cannot "swap out" components with updated code that was compiled separately.
I'm curious to your desktop use case. Deferred components are useful to circumvent mobile limitations such as poor internet connection or limited disk space. These are generally less of a concern for desktop apps. Could you expand on your scenario?

Thanks. Maybe I misunderstood the meaning of deferred components.
Close


[web] Implement more APIs

RtcEngine_enableLocalVideo
RtcEngine_muteAllRemoteVideoStreams
RtcEngine_createDataStream
RtcEngine_sendStreamMessage
RtcEngine_muteLocalVideoStream
RtcEngine_muteRemoteVideoStream
RtcEngineEx_muteAllRemoteVideoStreamsEx
RtcEngineEx_sendStreamMessageEx
RtcEngineEx_createDataStreamEx
RtcEngineEx_muteLocalVideoStreamEx
RtcEngineEx_muteRemoteVideoStreamEx
RtcEngineEventHandler_onStreamMessage
RtcEngineEventHandler_onRemoteVideoStateChanged
RtcEngine_joinChannelWithUserAccount
RtcEngine_joinChannelWithUserAccount
RtcEngine_getUserInfoByUserAccount
RtcEngine_getUserInfoByUid

Examples built:

https://nightly.link/littleGnAl/hoe/actions/runs/8105651738/agora_rtc_engine_android_6.3.0_20240301024308.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8105651738/agora_rtc_engine_ios_6.3.0_20240301023601.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8105651738/agora_rtc_engine_macos_6.3.0_20240301023318.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8105651738/agora_rtc_engine_windows_6.3.0_20240301023110.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8105651738/agora_rtc_engine_web_6.3.0_20240301022824.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/littleGnAl/hoe/actions/runs/8154500979/agora_rtc_engine_web_6.3.0_20240305101200.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/littleGnAl/hoe/actions/runs/8154872054/agora_rtc_engine_android_6.3.0_20240305104955.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8154872054/agora_rtc_engine_ios_6.3.0_20240305104424.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8154872054/agora_rtc_engine_macos_6.3.0_20240305104225.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8154872054/agora_rtc_engine_windows_6.3.0_20240305104149.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8154872054/agora_rtc_engine_web_6.3.0_20240305103837.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/littleGnAl/hoe/actions/runs/8156041701/agora_rtc_engine_android_6.3.0_20240305122358.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8156041701/agora_rtc_engine_ios_6.3.0_20240305122241.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8156041701/agora_rtc_engine_macos_6.3.0_20240305121819.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8156041701/agora_rtc_engine_windows_6.3.0_20240305121753.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8156041701/agora_rtc_engine_web_6.3.0_20240305121547.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/littleGnAl/hoe/actions/runs/8197681235/agora_rtc_engine_android_6.3.0_20240308021539.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8197681235/agora_rtc_engine_ios_6.3.0_20240308021253.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8197681235/agora_rtc_engine_macos_6.3.0_20240308021018.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8197681235/agora_rtc_engine_windows_6.3.0_20240308021029.zip
https://nightly.link/littleGnAl/hoe/actions/runs/8197681235/agora_rtc_engine_web_6.3.0_20240308020749.zip

This comment is commented by bot, do not edit it directly


toolchain: remove includedirs and linkdirs of system path

/usr/{local/,}include and /usr/{local/,}lib are in the default configuration of the compilers and forcing them to be added (before any other includes) conflicts with the project files.

Thanks!


Install problem

My cuda version is 11.7 (checked with command "nvcc --version"), and I run "conda env create -f environment.yaml" to build the environment and run "conda activate detectorfreesfm" without any problem. But when I run "conda activate detectorfreesfm", the system  show the errors below.

I found the cuda version of install torch is 12.1 with command "torch.version.cuda". So is there any advice to solve this problem?

It seems that the installed pytorch version used CUDA 12.1, where the required pytorch version is 1.8.0 and CUDA version is 11.7 in our environment. You can check whether the installed pytorch version is right.

It seems that the installed pytorch version used CUDA 12.1, where the required pytorch version is 1.8.0 and CUDA version is 11.7 in our environment. You can check whether the installed pytorch version is right.

It seems the torch version is changed  after the pytorch-lightning is installed.  The problem is same as this issue "https://github.com/zju3dv/DetectorFreeSfM/issues/38"

It seems that the installed pytorch version used CUDA 12.1, where the required pytorch version is 1.8.0 and CUDA version is 11.7 in our environment. You can check whether the installed pytorch version is right.

It seems the torch version is changed after the pytorch-lightning is installed. The problem is same as this issue "#38"

I think it is weird that pytorch-lightning with version 1.3.5 tries to upgrade pytorch version to 2.3.0, as they are not compatible as shown in official manual. You can have a look at whether the final installed pytorch-lightning version is 1.3.5, as required by repo.


Parameter sets value when value is out of range

Steps to reproduce
from qcodes import Parameter
from qcodes.utils.validators import Numbers

the_value = -10

def set_function(value):
    global the_value
    the_value = value
    print('set {0}'.format(the_value))

def get_function():
    print('get {0}'.format(the_value))
    return the_value

a = Parameter('test', set_cmd=set_function, get_cmd=get_function, vals=Numbers(0, 100), step=5)
a.set(10)
a.get()

Expected behaviour
a.set(10) --> ValueError('-10 is invalid')
a.get() --> -10

Actual behavior
a.set(10) --> ValueError('-5 is invalid')
a.get() --> -5

System
operating system
Windows 10 x64, miniconda v 4.5.4 (venv)
qcodes branch
master
qcodes commit
8970a083c2b582e4d966da082f039fef49f2089a
@dpfranke, @eendebakpt

The problem is that the wrapper validated the end point but does not take into account that the points in between generated by step may not be valid because the parameter is out of bounds for the validator before starting to step.

I believe that this is fixed by #1176. @lucblom Do you have any other ways of triggering this that does not involve both starting from an invalid value and setting a step size

And by the way I disagree slightly on the expected behavior. I would expect it to be
a.get() --> -10
a.set(10) --> a.set(10) --> ValueError('-5 is invalid')
a.get() --> -5
a.get() --> -10

There is nothing in the code that will atempt to set the value to -10 so you should get a ValueError when trying to set the first step which is -5 but before the actual step is performed

@jenshnielsen. Thank you for the quick reply!
We stumbled upon this behavior when using the IVVI. We use validators with a smaller range then the actual voltage limits of the device. We want to protect the user from setting to large values that could potentially damage the connected chip. How the invalid value was initially set is unclear to us.
I only could trigger this when starting from an invalid value and I agree that the expected behavior should be as you described.


Event searching and viewing enhancements

It would be nice to have a page called "my events" that shows what the logged-in user has already volunteered for.  Similarly, maybe the app could show a calendar of all events so that users can search for events by date instead of just by zipcode.  These could even be the same calendar page, and users could filter by "events I've signed up for," "events near me," and "all events."
This is probably something more for 2.0, but when I was clicking around in the app I thought it would be useful.
Possibly labels: "enhancement," "volunteer workflow"

Great points and was thinking similar.  We will likely break down to multiple tasks when we get to working on it.

I'm splitting this down into other tasks now.

Thank you @MisterJames


Add changes to make plugin work on ChartJS V2 & V3

@kurkle Thanks for the review changes have been made


Iter when T: Sync

Would it be possible to add a method that iterates over shared references to each thread's value when T: Sync?

This isn't possible because this would race with other threads adding new values, even if they are Sync.

Ok, makes sense.