[Bug] iOS default pod install fails due to incorrect pod names defined

[REQUIRED] Please fill in the following fields:

Unity editor version: 2022.3.19f1
Firebase Unity SDK version: 10.6.0
Source you installed the SDK: UPM
Problematic Firebase Component: Core
Other Firebase Components in use: All
Additional SDKs you are using: None
Platform you are using the Unity editor on: MacOS
Platform you are targeting: iOS
Scripting Runtime:IL2CPP
Pre-built SDK from the open-source from this repo: https://github.com/GameWorkstore, but I also double checked and downloaded prebuilt from website, and the result is the same.

[REQUIRED] Please describe the issue here:
Simply building from Unity targeting iOS build target in Unity Editor:
iOS framework addition failed due to a CocoaPods installation failure. This will will likely result in an non-functional Xcode project.

After the failure, "pod repo update" was executed and succeeded. "pod install" was then attempted again, and still failed. This may be due to a broken CocoaPods installation. See: https://guides.cocoapods.org/using/troubleshooting.html for potential solutions.

pod install output:

Analyzing dependencies
Adding spec repo `trunk` with CDN `https://cdn.cocoapods.org/`
[!] CocoaPods could not find compatible versions for pod "Firebase/Analytics":
  In Podfile:
    Firebase/Analytics (= 10.15.0)

None of your spec sources contain a spec satisfying the dependency: `Firebase/Analytics (= 10.15.0)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

pod repo update output:

Updating spec repo `trunk`

Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)? Yes
What's the issue repro rate? 100%
What happened? How can we make the problem occur?
On iOS build export.
Recommended Fix
Change how podfile is generated by removing the extra / in the name of the pod names for the FIrebase deps

Come to fine out, it is not actually the versions defined. It is the named entry into the Podfile file itself:
The pod names are incorrectly defined and have an extra / in the names.
for example Firebase/Analytics should be FIrebaseAnalytics etc.
currently broken:
source 'https://cdn.cocoapods.org/'

platform :ios, '12.0'

target 'UnityFramework' do
  pod 'Firebase/Analytics', '10.15.0'
  pod 'Firebase/AppCheck', '10.11.0'
  pod 'Firebase/Auth', '10.15.0'
  pod 'Firebase/Core', '10.15.0'
  pod 'Firebase/Crashlytics', '10.15.0'
  pod 'Firebase/Firestore', '10.15.0'
  pod 'Firebase/Functions', '10.15.0'
  pod 'Firebase/Messaging', '10.15.0'
  pod 'Firebase/RemoteConfig', '10.15.0'
  pod 'Firebase/Storage', '10.15.0'
  pod 'FirebaseInstallations'
end
target 'Unity-iPhone' do
end
use_frameworks! :linkage => :static

recommended fix:
source 'https://cdn.cocoapods.org/'

platform :ios, '12.0'

target 'UnityFramework' do
  pod 'FirebaseAnalytics', '10.15.0'
  pod 'FirebaseAppCheck', '10.11.0'
  pod 'FirebaseAuth', '10.15.0'
  pod 'FirebaseCore', '10.15.0'
  pod 'FirebaseCrashlytics', '10.15.0'
  pod 'FirebaseFirestore', '10.15.0'
  pod 'FirebaseFunctions', '10.15.0'
  pod 'FirebaseMessaging', '10.15.0'
  pod 'FirebaseRemoteConfig', '10.15.0'
  pod 'FirebaseStorage', '10.15.0'
  pod 'FirebaseInstallations'
end
target 'Unity-iPhone' do
end
use_frameworks! :linkage => :static

I noticed that FirebaseInstallations did not have a version, and was missing the / in the name. Prob a bug there as well in the version cmake script.

playing around I also was able to fix this with the / in the name by fixing the Firebase/AppCheck pod version to be the same as the rest: 10.6.0

come to find out not all of my packages were the same version.
Prob need to fix that FirebaseInstallations pod not being named correctly and missing its version tho


example "Hello XDP" run error "Segmentation fault" on centos9 stream and ubuntu 22.04 x86_64

on centos9
[sudo] password for sope:
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BPF program name support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF func support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF global func support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF var and datasec support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF float support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF decl_tag support: true
[2022-09-01T09:49:35Z DEBUG aya::bpf] [FEAT PROBE] BTF type_tag support: false
[2022-09-01T09:49:35Z DEBUG aya::obj::relocation] relocating program myapp function myapp
[2022-09-01T09:49:35Z DEBUG aya::obj::relocation] finished relocating program myapp function myapp
[2022-09-01T09:49:35Z TRACE mio::poll] registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
[2022-09-01T09:49:35Z TRACE mio::poll] registering event source with poller: token=Token(2), interests=READABLE | WRITABLE
[2022-09-01T09:49:35Z TRACE mio::poll] registering event source with poller: token=Token(3), interests=READABLE | WRITABLE
[2022-09-01T09:49:35Z TRACE mio::poll] registering event source with poller: token=Token(4), interests=READABLE | WRITABLE
[2022-09-01T09:49:35Z INFO  myapp] Waiting for Ctrl-C...
Segmentation fault
[sope@centos-stream myapp]$ uname -a
Linux centos-stream 5.14.0-148.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Aug 19 13:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

on ubuntu
       Fresh aya-log-ebpf-macros v0.1.0 (https://github.com/aya-rs/aya?branch=main#906c25ff)
       Fresh aya-log-ebpf v0.1.0 (https://github.com/aya-rs/aya?branch=main#906c25ff)
       Fresh myapp-ebpf v0.1.0 (/home/sope/workspaces/rust/myapp/myapp-ebpf)
    Finished dev [optimized] target(s) in 0.27s
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s
[sudo] password for sope:
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BPF program name support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF func support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF global func support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF var and datasec support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF float support: true
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF decl_tag support: false
[2022-09-01T09:50:22Z DEBUG aya::bpf] [FEAT PROBE] BTF type_tag support: false
[2022-09-01T09:50:22Z DEBUG aya::obj::relocation] relocating program myapp function myapp
[2022-09-01T09:50:22Z DEBUG aya::obj::relocation] finished relocating program myapp function myapp
[2022-09-01T09:50:22Z TRACE mio::poll] registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
[2022-09-01T09:50:22Z TRACE mio::poll] registering event source with poller: token=Token(2), interests=READABLE | WRITABLE
[2022-09-01T09:50:22Z TRACE mio::poll] registering event source with poller: token=Token(3), interests=READABLE | WRITABLE
[2022-09-01T09:50:22Z TRACE mio::poll] registering event source with poller: token=Token(4), interests=READABLE | WRITABLE
[2022-09-01T09:50:22Z INFO  myapp] Waiting for Ctrl-C...
Segmentation fault
sope@sope-vbox:~/workspaces/rust/myapp$ uname -a
Linux sope-vbox 5.15.0-47-generic #51-Ubuntu SMP Thu Aug 11 07:51:15 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Installed an Ubuntu VM and copied over the object file from my local machine.
Works fine on Ubuntu 22.04 as far as I can tell.
dave in 🌐 ubuntu in ~
❯ RUST_LOG=debug sudo ./myapp --iface enp1s0
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:135] [FEAT PROBE] BPF program name support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:138] [FEAT PROBE] BTF support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:142] [FEAT PROBE] BTF func support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:145] [FEAT PROBE] BTF global func support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:151] [FEAT PROBE] BTF var and datasec support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:157] [FEAT PROBE] BTF float support: true
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:160] [FEAT PROBE] BTF decl_tag support: false
10:40:20 [DEBUG] (1) aya::bpf: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/bpf.rs:163] [FEAT PROBE] BTF type_tag support: false
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:270] relocating program myapp function myapp
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:327] relocating call to callee address 64 (relocation)
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:348] callee is memcpy
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:270] relocating program myapp function memcpy
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:363] finished relocating program myapp function memcpy
10:40:20 [DEBUG] (1) aya::obj::relocation: [/home/dave/.cargo/git/checkouts/aya-c55fbc69175ac116/66b4f79/aya/src/obj/relocation.rs:363] finished relocating program myapp function myapp
10:40:20 [INFO] myapp: [myapp/src/main.rs:52] Waiting for Ctrl-C...
10:40:20 [INFO] myapp: [src/main.rs:22] received a packet

dave in 🌐 ubuntu in ~
❯ uname -a
Linux ubuntu 5.15.0-46-generic #49-Ubuntu SMP Thu Aug 4 18:03:25 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

I think to debug this further we'll need to know where the crash is coming from.
If you could add some log statements of println! into main.rs we might be able to see what's happening.
/cc @vadorovsky as if I were a gambler, I'd bet on aya-log :game_die:

@dave-tucker I'm 100% sure that's because we didn't release a new version of aya-log with format hints. So if someone creates a new project with aya-template now, they will end up with:

userspace project using aya-log from crates.io without format hints
eBPF project using aya-log-ebpf from git with format hints

Therefore eBPF program will keep sending fragmented literals with format hints, which are not expected by aya-log in userspace, therefore it's segfaulting.

@shenshouer A temporary fix which works for me is applying the following diff on new projects:
diff --git a/Cargo.toml b/Cargo.toml
index da00d7a..c915314 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,2 +1,5 @@
 [workspace]
 members = ["mkdir", "mkdir-common", "xtask"]
+
+[patch.crates-io]
+aya = { git = "https://github.com/aya-rs/aya", branch = "main", features = ["async_tokio"] }
diff --git a/mkdir/Cargo.toml b/mkdir/Cargo.toml
index 41b9ab5..44429fe 100644
--- a/mkdir/Cargo.toml
+++ b/mkdir/Cargo.toml
@@ -6,7 +6,7 @@ publish = false

 [dependencies]
 aya = { version = ">=0.11", features=["async_tokio"] }
-aya-log = "0.1"
+aya-log = { git = "https://github.com/aya-rs/aya", branch = "main" }
 mkdir-common = { path = "../mkdir-common", features=["user"] }
 anyhow = "1.0.42"
 clap = { version = "3.1", features = ["derive"] }

The proper fix will be making a new release of aya-log ASAP.

@vadorovsky Thank you for your changed, it worke ok now!

New aya-log was released and I can confirm that creating new projects works without patching now.
@shenshouer I would suggest you to re-create project from scratch, I hope you didn't write too much code yet. ;)
Closing. Feel free to re-open if there are any problems.


Register

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/65507
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.1 -m "<description of version>" af5a40c97fa0f0241213bf5ee3d444e52a5e2dd3
git push origin v0.2.1


Rename the project & repo to phoenix_storybook

phoenix_storybook / PhoenixStorybook everywhere

Is this still needed? Considering adding phoenix_storybook to our company's codebase for a new UI design but we also need it to support components across the entire project, not just live view, per #187. Happy to help out if I can

Hey 👋
Sure you can use it on any component, not only live_component (that's why the current project name is misleading)


Adding a new job for Backup Manager

added monit script

added spec with a dummy property, will have to decide on the properties later

added job_properties.sh.erb

added ervice-fabrik-backup-manager_ctl.erb

added settings.yml.erb with a dummy settings value

added syslog_forwarding_conf.erb

@subhankarc : can you pls resolve conflicts.

Changes look fine, @subhankarc Does this PR also contain changes from https://github.com/cloudfoundry-incubator/service-fabrik-boshrelease/pull/92 . If yes, better to keep it separate.
Also better to sync with changes from https://github.com/cloudfoundry-incubator/service-fabrik-boshrelease/pull/90/files by @abh1kg as this change will be merged first.

@muralisc I think you cherry picked apiserver commit for testing and accidentally submitted in this branch. Can you please remove this commit from this PR?

@amitmalav Can you please check why travis build is failing?

@ketakig12 @amitmalav
This is the reason. So the source folders are not yet there on the broker master branch. Hence, build is failing.
Building service-fabrik-backup-manager...
Package 'service-fabrik-backup-manager' has a glob that resolves to an empty file list: service-fabrik-broker/managers/**/*


[FEATURE REQ] Event Hubs support receiver redirect

Background
The Event Hubs service supports redirects for amqp receiver links. When the client creates an amqp receiver link with redirects enabled, the service will respond with an amqp:link:redirect error if it also supports redirects. The error contains the information needed to create a new connection to the service.
The main benefit of receiver redirect is it allows a more direct connection to the host actually sending events to the client which should reduce latency.
API changes
The Event Hub clients responsible for consuming events (e.g. EventHubConsumerClient) should accept a new option to enable redirect that has a default value of false.
Proposal:
  { enableRedirect: true } // new option 'enableRedirect'

Reasoning
It is important to make this option opt-in for 2 reasons:

Currently 1 client creates 1 connection. This changes this assumption to 1 client can create many connections. This has implications since there is a limit to the number of connections that can be open at one time to an Event hub.
By default the SDK speaks AMQP over ports 5671/5672. With redirect enabled, new connections may be made on ports 104xx. Users may need to update their firewall rules to support redirect:
https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-amqp-protocol-guide#amqp-outbound-port-requirements

Details
Redirect walkthrough

User instantiates a consumer client with redirect enabled.
User makes call to receive events (this causes a receiver link to be created using customer-provided credential/host info).
Connection/cbs session/receiver link are created.

The receiver link must have amqp:link:redirect included in the list of desired_capabilities if redirect is enabled.
This must be omitted if redirect is not enabled.

The receiver link recieves a LinkRedirectError.
The SDK parses the hostname/port/address info from the error.
A new amqp connection is created using the hostname/port from the error.
When the cbs session is created, the applicationProperties.name value should be the address extracted from the LinkRedirectError.
The SDK creates the receiver link on the new connection and begins receiving events.

Considerations
It is possible for every receiver link to have different hostname/port/address values from one another in the LinkRedirectError. You may create a new connection for every LinkRedirectError. Optionally, you may use a connection for multiple receiver links if the links share a hostname/port.
Creating a new connection for each redirect is simpler to implement because it is easier to know when the connection should be closed, but does potentially increase connection density.
When to re-use the original connection?
It is possible that the server node used for receiving events can change. When the SDK sees an amqp:connection:forced error from the service, or the connection is closed, then the original connection should be used to create a new receiver link. At this point a new LinkRedirectError should be received and the redirect walkthrough can be followed.
Otherwise, for transient issues the connection created for the link after a LinkRedirectError can be re-used.
Reference
There is a draft PR for the JavaScript SDK that has the basics implemented for this feature.
https://github.com/Azure/azure-sdk-for-js/pull/7782

Ad-hoc task breakdown with back-of-the-envelope estimation:

Write up a (very) short proposal for the changes to the public API to facilitate :  1
Drive consensus across the feature team and with the .NET architect, including time for revisions : 1.5
Prototype against the service to capture redirect flow in a simple context: 1
Implementation and tests: 3


Message alert displays very slow

After my api call i'm setting the error message to messageBar, but it take too long to appear on screen
y is it so ?

me too. even if durationToShow set to 0.

durationToShow: props.durationToShow || 350 is not right.but when i set to 1, displays always very slow

ctrl + T is solve

duration: props.duration || 3000, this statement is wrong(when duration is 0).  the right: duration: props.duration !== 'undefined' ? props.duration : 3000


(FACT-3207) Don't rescue NoMethodError in base resolver

This commit removes the logic to specifically rescue for just NoMethodError.
Instead, since NameError is a superclass of NoMethodError, NoMethodErrors will
be rescued when NameError is rescued and log at the error level instead of the
debug level. By doing this, bugs in resolvers are no longer hidden.
This commit also fixes various bugs in resolvers such as calling methods on nil
objects and requiring/relying gems that may not be installed to resolve facts.

jenkins please test this on all

jenkins please test this on osx12-ARM64

Ah looks like you found another resolver bug. I wonder if this was causing the sporadic macOS 12 issue we were seeing in CI?
17:02:09       [2023-07-12 17:02:09.318190 ] ERROR Facter::Resolvers::Macosx::Mountpoints - Resolving fact mountpoints, but got dlopen(/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/ffi-1.15.5/lib/ffi_c.bundle, 0x0009): tried: '/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/ffi-1.15.5/lib/ffi_c.bundle' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')) - /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/ffi-1.15.5/lib/ffi_c.bundle at <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'

jenkins please test this on osx12-ARM64

jenkins please test this on osx12-ARM64

jenkins please test this on osx12-ARM64

This PR is blocked by PA-5666. This PR cannot be merged until PA-5666 is resolved since it is causing osx12-ARM64 facter builds to fail.

jenkins please test this on all

jenkins please test this on all


Fix e2e-dashboard test script filename.

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-dashboard.sh
22aef939d5f972e70da4c863baf8e86c5eb5415c
link
/test daily-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-dashboard.sh
8f19cd204a055d93e398eaef66de11203adee2de
link
/test daily-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-dashboard.sh
8f19cd204a055d93e398eaef66de11203adee2de
link
/test daily-e2e-dashboard

prow/daily-perf-tests.sh
8f19cd204a055d93e398eaef66de11203adee2de
link
/test daily-perf-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Always show selected values in Combobox

We should always show selected options even when people have search for as part of being clear and concise for our users what is selected in the Combobox.
This is especially important for screen-readers where;

It is not necessarily intuitiv that you need to tab back to chips to get selected options and deselect options
Screen readers should be able to read out how many selected options in the list, such as 2 of 8 etc.

We should maybe update the examples in Figma to reflect this? @Febakke


MSID: 87022 Version: 2 DOI: 2<IP_ADDRESS>5022

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=87022)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/87022/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5022)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/87022/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/87022)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/87022

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/87022

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/87022/v2/87022-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/87022)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from the references.


Add moka-icon-theme

Hello!
It's about time I contributed a new package..
Tested on Ubuntu VM, as usual

Installing this from the pacscript with pacstall -Il in the VM works perfectly. (I even just re-installed it to make sure)
Not sure what the failing check is about, I assume a problem in the environment.

Yeah, the CI has been broken for a while. The develop branch already has the fix in it, but we just need to release 1.6 and it should work again.


License

We need to decide on a license for this version of YACS, because it's not open-source till we have an open source license.

I copied github.com/jeffh/yacs/LICENSE.txt and created our license with that text.

Leaving a comment here to note that the license is in fact the MIT license; it just didn't say so in the text file. This was amended a couple weeks ago.


queryESCore() metrics selection only for csv

Metrics selection using the arguments allm and dMetrics only works with csv output not json.

Not bug but possible future enhancement. Not mandatory.

Created aggregated query engine for dmon. Clossing this issue


SPI IMU support

FXOS8700 and FXAS21002C SPI driver for Zephyr

Added support for FXOS8700 over SPI in the newly created branch -
rddrone-fmuk66-imu
Commit ID: 6883f6a563e41fe9b9239b54f5933c68e08c4688

Made following changes -

Changes to manage chip Select of SPI1 for multiple slaves.
Reset SPI based slaves with RST pin and I2C slaves with CTRLREG1

FXAS21002 slave is working over SPI bus

While enabling fxas21002 device tree changes were made which impacted fxos8700 as well, so verified that both fxos and fxas slaves are working with the current code.

LGTM.


Document the package

Edit R/minimalR.R.
See R Packages: Documenting packages for examples.

Resolved by commit c0ff58470c7f3cab02be0550cf55e7d6e8acc744


Support for PKCE to prevent code injection attacks

PKCE or Proof Key for Code Exchange helps secure OAuth codes during the Authorization Code Grant Flow, this specification was originally written with Public Clients in mind instead of confidential clients, however, in recent years it has become known that PKCE can also help mitigate authorization code injection attacks against resource servers and authorization servers, and is now being recommended as a best practice: https://www.ietf.org/archive/id/draft-ietf-oauth-security-topics-27.html#name-authorization-code-injectio
Implementing PKCE is relatively straight forwards:

The client generates a code_verifier, a random string using the character set [A-Z] / [a-z] / [0-9] / "-" / "." / "_" / "~", with a minimum length of 43 and a maximum length of 128; The client stores this code_verifier in some place it can read following the redirect to the oauth redirect URL.
The client generates a code_challenge using the code_verifier, the algorithm is of S256 uses the following construction: BASE64URL-ENCODE(SHA256(ASCII(code_verifier))), typically S256 is used, but plain is supported as well, in which case the code_verifier and code_challenge are the same (insecure)
The client adds the code_challenge and code_challenge_method as parameters to the authorization endpoint redirect URL.
The user performs login, and is redirected back with a authorization code
The client exchanges the authorization code, but when it does so, it adds the parameter code_verifier which is the code verifier value from step 1, retrieved from storage.
The authorization server checks the access grant's code_challenge against the exchanged code_verifier using the stored code_challenge_method to compare (so the authorization server repeats the steps from 2 but with the code_verifier supplied along with the code to the token endpoint
If they match, you get back an access token, if they don't you get an error response.

PKCE would be really good to see supported in this package given the simplicity of implementation and the additional security it provides to the authorization code when exchanging it for an access token.
It can also be easily enabled or disabled: simply don't generate the code verifier or do.
The "storage" mentioned above for the code_verifier is typically in the server-side session cookie, much like what's done for the state parameter.

Keep open

Keep open.

Keep open.


TinyLlama issue in latest WIP branch

There seems to be an issue with the TinyLlama configs in the latest WIP branch:
⚡ download-docs ~/lit-gpt export repo_id=TinyLlama/TinyLlama-1.1B-intermediate-step-1431k-3T
⚡ download-docs ~/lit-gpt python chat/base.py --checkpoint_dir checkpoints/$repo_id
Traceback (most recent call last):
  File "chat/base.py", line 380, in <module>
    CLI(main)
  File "/teamspace/studios/this_studio/lit-gpt/lit_gpt/utils.py", line 379, in CLI
    return CLI(*args, **kwargs)
  File "/home/zeus/miniconda3/envs/cloudspace/lib/python3.8/site-packages/jsonargparse/_cli.py", line 96, in CLI
    return _run_component(components, cfg_init)
  File "/home/zeus/miniconda3/envs/cloudspace/lib/python3.8/site-packages/jsonargparse/_cli.py", line 193, in _run_component
    return component(**cfg)
  File "/home/zeus/miniconda3/envs/cloudspace/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "chat/base.py", line 140, in main
    config = Config.from_json(checkpoint_dir / "lit_config.json")
  File "/teamspace/studios/this_studio/lit-gpt/lit_gpt/config.py", line 124, in from_json
    return cls(**json_kwargs)
TypeError: __init__() got an unexpected keyword argument 'norm_class_name'
⚡ download-docs ~/lit-gpt

Looks to me like you are trying to load a wip-branch config into the main-branch code

arg yes my bad, sorry!


feat(translation): add Estonian default translation

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Add Estonian default translations.
Related issues/PRs

#3526

Thanks, LGTM 👍


Can't install via NPM (tooltip - 404)

npm install cropper --save
npm ERR! 404 Not Found
npm ERR! 404
npm ERR! 404 'fengyuanchen/tooltip' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it
npm ERR! 404 It was specified as a dependency of 'cropper'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, or http url, or git url.

Maybe you should update your NPM.

Good point, npm v2 and everything works. Thanks.


Support keytab

https://github.com/juicedata/juicefs/issues/3283

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the cla

Codecov Report
Patch coverage has no change and project coverage change: -30.54 :warning:

Comparison is base (a230794) 55.43% compared to head (69e4a13) 24.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3517       +/-   ##
===========================================
- Coverage   55.43%   24.90%   -30.54%
===========================================
  Files         142       24      -118
  Lines       33741    14094    -19647
===========================================
- Hits        18706     3510    -15196
+ Misses      13056    10206     -2850
+ Partials     1979      378     -1601

see 140 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@tangyoupeng
Thanks for the review and for merging


Fix Jokers used by card abilities

fixes #1464

No idea why this has been closed and not merged. Probably by mistake.


Fix for object_store not being present in Datasource metadata

Summary of changes (Bug fix, feature, docs update, ...)

Removes the object_store key from the Datasource metadata to avoid issues when folders are moved etc.
The object store key is now added to the metadata presented to the user by the SearchResults object.

Please check if the PR fulfills these requirements

[x] Closes #709
[x] Closes #723
[x] Tests added and passed if fixing a bug or adding a new feature
[x] All code checks passing - black --line-length 110 run over code, mypy and flake8 not showing any errors
[ ] Documentation and tutorials updated/added
[x] Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
[ ] Added any new requirements to requirements.txt and recipes/meta.yaml

Codecov Report

Merging #725 (cce0977) into devel (fe38ee3) will decrease coverage by 0.03%.
The diff coverage is 22.72%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##            devel     #725      +/-   ##
==========================================
- Coverage   33.56%   33.53%   -0.03%
==========================================
  Files         175      175
  Lines       13877    13913      +36
==========================================
+ Hits         4658     4666       +8
- Misses       9219     9247      +28

Files Changed
Coverage Δ

openghg/dataobjects/_datamanager.py
0.00% <0.00%> (ø)

openghg/retrieve/_search.py
0.00% <0.00%> (ø)

openghg/store/base/_base.py
0.00% <ø> (ø)

openghg/store/base/_datasource.py
0.00% <0.00%> (ø)

tests/dataobjects/test_datamanager.py
99.00% <100.00%> (-1.00%)
:arrow_down:

Looks good. A few small suggestions (but not blockers to being merged)
* I added a small suggested modification to the xfail to make sure we don't forget about putting this back in

* @brendan-m-murphy made a suggestion on the related issue [Fix for object_store not being present in Datasource metadata #725](https://github.com/openghg/openghg/pull/725) "If there is logging info when a datasource is created, we could say what object store the datasource was added to. (E.g. "created in {object_store} object store".)" - may be something useful to add?

OK cool, I've opened https://github.com/openghg/openghg/issues/736 for the Datasource logging idea.


Add all eternalcode released plugins.

https://www.spigotmc.org/resources/-chatformatter-✔-beautify-your-chat-with-hovers-clickable-messages-and-more.102212/
https://www.spigotmc.org/resources/eternalcombat-✔-enchance-your-combat-system-with-eternalcombat.109056/
https://www.spigotmc.org/resources/eternalcore-♾-all-the-most-important-server-functions-in-one.112264/
https://www.spigotmc.org/resources/lobbyheads-✨-decorative-heads-for-your-server-hub.113065/


feat(frontend): support alter rate limit in mv, source, table with source

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support frontend parts for altering rate limit with source, source with table, mv.
Only source, source with table now fully support for ALTER SET STREAMING_RATE_LIMIT TO N. Look at the slt test for more information.
Changes for MV (will be done in a future PR)
For MV, this is not fully supported yet. The reason is that we need specific information to identify an MV besides its name (which alter mv provides). We need the schema, and database as well.
These parameters can be provided from the catalog in meta. Currently, when the MV is in Creating state, it is persisted on the meta side. However, we currently don't propagate it back to frontend, to make it "invisible" until backfill completes.
We can propagate it back to frontend, and update catalog accessors to mask Creating catalogs.
Then we can then access these Creating catalogs in frontend to get the necessary info to alter rate limit.
In this PR, the behaviour of MV being backfilled is to reject the alter rate limit command, and inform the user that its catalog is not found.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
Supports ALTER STREAMING_RATE_LIMIT SET = default | N for source, table with source.
Example:
create table kafka_source (v1 int) with (
  connector = 'kafka',
  topic = 'kafka_source',
  properties.bootstrap.server = 'localhost:29092',
  scan.startup.mode = 'earliest',
  streaming_rate_limit = 0
) FORMAT PLAIN ENCODE JSON

alter table kafka_source set streaming_rate_limit to default;

alter table kafka_source set streaming_rate_limit to 1000;

Bump, please leave a review.

Just found 2 bugs.

Table rate limit does not get altered.
Source rate limit is not applied initially.

Investigating.

Depends on https://github.com/risingwavelabs/risingwave/pull/16472

Ready for review again.


Bumping gradle to version 2.12

Gradle release 2.12 contains some nice new features, most notably the use of ZINC as a Scala compiler which will make turnaround times faster.
Also in this PR:

Remove build-time dependency of whisk.properties
Add Eclipse configuration for code style

Rebased and merges as 606b8b2.


Add language direction

Address issue #557

Nice! but can we have a tag helper or some thing similar to minimize the number line of code need to add to the _Layout, as we might have many _Layout for many themes

Perhaps using TagHelperComponent is the suitable in this case, I will have a try if I can inject the language direction in the html tag in all the layouts

Now it's totally clean, hope you like it 😄


New feature suggestion

Back-end feature solving privacy standard (GDPR) compliance issues.

Wait, what? Etymology for a new feature?
Kindly check and get back to me since I have provided a detailed
explanation as to why this feature is required.
Sauhard Jain

Check out this file: suggested-feature.md

@sauhardjain You have 7 file changes in this PR, please revert the commits which are not related to this task. Please read the instructions carefully, we asked you to create separate branches for each task to avoid such problems!

@sauhardjain I'm sorry, there was some confusion. As @sayamkanwar said, please revert the commits which are not related to this task. I shall review the updates related to this task.

No, so up till those 6 months, the information will be used normally as any
search engine would use for ranking, advertising, etc. But 6 months would
be the time limit post which we’ll get rid of the complete data, and only
retain raw data for ranking web pages. This would ensure compliance with
the GDPR.
Sauhard Jain


name, default and doc for n_components

the documentation of that parameter currently lives in a private function. It should be moved and integrated in the documentation of the main load_confounds function.
Also, the name of that parameter is not explicit enoough.
It is the number of motion components, so it should be called n_motion rather than n_component
The default is currently 0.95 but PCA reduction of motion parameters is not a standard preprocessing strategy. It should be set at 0 by default, i.e. use all the motion regressors.

fixed.


add yonaka-37 on contributors.json

Issue

Description

Checklist

[x] Added contributor object in ascending order in contributors.json
[ ] Github action build passing
[x] No merge conflicts

Looks like there are conflicts @yonaka-37


Module Lua Error

Describe the bug

Error only occurred when I hit Bran to 60. My XP / Rep Bar is maxed and though my UI is working, I don't get the menu option as its the standard Vanilla UI. If I type in /moveui, I can move things around as needed but that's not really the issue.
The issue lies with the menu. When I hit esc, I don't even have the KKthxUI UI layout. Ever since I hit Bran to 60, I've only ever gotten this issue on any character now. I can't seem to fix it, I've re-installed it and still the issue persists.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Honestly, I didn't think there would be an issue maxing out Bran's XP, so I'm not sure why this error occurred. UI has been working splendidly but can't seem to fix this one issue.
Screenshots
If applicable, add screenshots to help explain your problem.

I've attached a screenshot of my lua error, as well as what I see from my end.
World of Warcraft Details:

Game Version: Retail
Patch Version: 11.0.2

Additional context
Add any other context about the problem here.

I just turned off Bran from the XP bar (this was automatic, never manually touched it until now) and the menu bar came back. But I figured that was an odd one and wanted to let you know.

Fixed https://github.com/Kkthnx-Wow/KkthnxUI/commit/63a8650bc02781dd9e7ce4368ad840eb9a5de337


Problem compiling on Mac

Hi,
I am trying to compile the sources on Mac in order to get the "libOpenCvSharpExtern.so" file, and I read the page "Tutorial for Unix" in the wiki.
But when I make I get this error:

[  3%] Building CXX object OpenCvSharpExtern/CMakeFiles/OpenCvSharpExtern.dir/aruco.cpp.o
In file included from /Users/MDesk/downloads/opencvsharp/src/OpenCvSharpExtern/aruco.cpp:1:
In file included from /Users/MDesk/downloads/opencvsharp/src/OpenCvSharpExtern/aruco.h:4:
/Users/MDesk/downloads/opencvsharp/src/OpenCvSharpExtern/include_opencv.h:24:10: fatal error:
'opencv2/aruco.hpp' file not found
#include <opencv2/aruco.hpp>
^
1 error generated.

Did I completely miss something? Where should I get and place those files?
Thank you.

I got the compiling (I had to specify the modules path when compiling OpenCV):

Install the project...
-- Install configuration: ""
-- Installing: /usr/local/lib/libOpenCvSharpExtern.dylib

But I get this error with C#:

System.DllNotFoundException: libOpenCvSharpExtern.so
at (wrapper managed-to-native) OpenCvSharp.NativeMethods:core_Mat_sizeof ()
at OpenCvSharp.NativeMethods.TryPInvoke () [0x0000e] in :0

The file is not found even if I change the extension 'so' to 'dylib' and I place the file in the build folder of the program.
Any idea?

Please see http://www.mono-project.com/docs/advanced/pinvoke/dllmap/
<!-- OpenCvSharpExtern.dll.config -->
<configuration>
  <dllmap dll="OpenCvSharpExtern.dll" target="libOpenCvSharpExtern.dylib" os="osx" />
</configuration>

I have the same error even with the config file, it is not found, this is the complete error output:

libOpenCvSharpExtern.dylib
*** An exception has occurred because of P/Invoke. ***
Please check the following:
(1) OpenCV's DLL files exist in the same directory as the executable file.
(2) Visual C++ Redistributable Package has been installed.
(3) The target platform(x86/x64) of OpenCV's DLL files and OpenCvSharp is the same as your project's.
System.DllNotFoundException: libOpenCvSharpExtern.dylib
at (wrapper managed-to-native) OpenCvSharp.NativeMethods:core_Mat_sizeof ()
at OpenCvSharp.NativeMethods.TryPInvoke () [0x0000e] in :0
Unhandled Exception:
System.TypeInitializationException: The type initializer for 'OpenCvSharp.Mat' threw an exception. ---> System.TypeInitializationException: The type initializer for 'OpenCvSharp.NativeMethods' threw an exception. ---> OpenCvSharp.OpenCvSharpException: libOpenCvSharpExtern.dylib

These are the files in my build folder:

libOpenCvSharpExtern.dylib
OCvTest.exe
OpenCvSharp.Blob.dll
OpenCvSharp.dll
OpenCvSharp.dll.config
OpenCvSharp.Extensions.dll
OpenCvSharp.UserInterface.dll
OpenCvSharpExtern.dll

I appreciate your help.

When you install OpenCV you can install some additional packages "opencv_contib". In order to do this you should use this repository: https://github.com/opencv/opencv_contrib
Then, when you perform cmake on opencv sources, you need to pass additional argument
cmake -DOPENCV_EXTRA_MODULES_PATH=<opencv_contrib>/modules <opencv_source_directory>

I already did that as said in my second post. The problem seems to come from OpenCvSharp, as I did not find how the library is loaded on OSX in the source code.

Any news?


specify version for module managed-instance-group

Hi
I propose to set version for managed-instance-group
I think, that currently, Terraform doesn't allow dynamic value for version (with a variable), so you will have to track new version of this module ...
Thanks !

I had to bump the version to 1.1.8, otherwise LGTM. Thanks


add: deezer

Note that the Deezer brandbook explicitly forbid using the equalizer without the wordmark text, except when the company name will be written below.
Unfortunately I was unable to keep it under 1KiB without sacrificing something, even with xlinks and patterns...
Credits to @matheusagcosta challenging me to shrink it under 1024 B.
Relates to #281, #288.

Magic!


Add ESLint recommended rules

Part of #714
Adds the following ESLint rules:

eslint:recommended
typescript-eslint/recommended
@typescript-eslint/consistent-type-assertions

Ran yarn lint --fix then fixed the unautofixable lints.
Todo:

[ ] Look into explicit-function-return-type

Might leave explicit-function-return-type for later, that one might get a bit gnarly.


feat: add support for import attributes and RegExp modifiers

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

Add support for ES2025 import attributes, and add support for RegExp modifiers.
What changes did you make? (Give an overview)
This PR adds support for ES2025 import attributes and RegExp modifiers.
Related Issues
Related to https://github.com/eslint/eslint/issues/19014
Is there anything you'd like reviewers to focus on?

Thank you for the review!
I didn't notice that. I will test it and fix it 😄

I added test cases to eslint-scope.
However, eslint-scope seems to work fine already, probably because the ImportAttribute node's visitor is not defined, so it doesn't get processed.


decoder: Really fix dict key comparability check

The story continues and we have to finally switch to panic/recover instead of reflect.TypeOf(key).Comparable() to catch improper key types. Please see details in the second commit and in https://github.com/kisielk/og-rek/issues/30#issuecomment-423803200.

ah ha, I was right about something for once :)

Yes, you were right, and I was not quite so. The time has put everything on its place.
Thanks for merging.


Maven Repo not working?

Hi there,
the maven repo at
https://csspeechstorage.blob.core.windows.net/maven/
doesn't seem to work.  ("The specified resource does not exist.")
Could you please check what's wrong here?
Regards,
Christian

It is a URI, and as described in the documentation you enter this URI in Android Studio or Maven as the URI to pull the Maven package from.
You can't just use it as a direct link in the browser.
thx
Wolfgang


NuGet: need to rename all packages

In order to be published on NuGet we need to rename all of the Akkatecture NuGet packages.
I configured our NuGet publish key to look for AfterLutz.* paths, so that might be the easiest solution: just prepend AfterLutz. to the front of each project name.
Related: https://github.com/AfterLutz/Akkatecture/issues/34#issuecomment-1004847924

This approach was changed so that there would be an "AL" suffix added to the original package names. Examples include: Akkatecture.AL and Akkatecture.Clustering.AL.


fix coredump

Commit Message: fix the coredump when stream is nullptr, then return directly instead of still sendMessage
Additional Description: N/A
Testing: MT
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@durd07  Please help to review this change. Thanks.

/assign

/assign-from @envoyproxy/envoy-maintainers

@adisuissa would you mind reassigning this as its not really my area

Also can you add some tests to validate the behavior of the different changes?


Need to regenerate netcdfs in Supplementary Data

There has been a slight change in the way netcdfs from datacube are generated. Basically crs data variable is now called spatial_ref and is marked as a coordinate. This allows output  of xr.open_dataset to be compatible with .geobox property from datacube.
Currently this notebook is failing to display loaded netcdf file
https://github.com/GeoscienceAustralia/dea-notebooks/blob/develop/Frequently_used_code/Opening_GeoTIFFs_NetCDFs.ipynb
Failure is here:
https://github.com/GeoscienceAustralia/dea-notebooks/blob/1112e810c4f6e9908e03d7afdfaae8696ad4aef4/Scripts/dea_plotting.py#L150
Because .geobox property is None. This also means that rgb method can only display geo-registered imagery. I recommend using this method instead datacube.utils.spatial_dims
https://github.com/opendatacube/datacube-core/blob/c2c25d3df437218223b900c1e6deb6f3dce374e4/datacube/utils/math.py#L38-L51

@Kirill888 The intention of that notebook is to demonstrate how any NetCDF file could be loaded and analysed alongside DEA data, so I guess we don't necessarily want to regenerate "nice" compliant NetCDFs (as these won't be what other users want to use).
I think updating rgb to plot datasets that don't have a geobox might be better, and it looks like datacube.utils.spatial_dims is a easy replacement.

Agree that rgb needs fixing, and while the fix is "easy", this function is a recent addition and might not work in some outdated environments.

Yeah OK... do you know by any chance whether it is included in module load dea/20200526 on the NCI?

yes, it would be included in 1.8.0+ for sure


deprecate kubeadm alpha command

xref https://github.com/kubernetes/kubeadm/issues/2292

@daminisatya @onlydole
I create a new child page for the kubeadm manual , but I don’t know how to generate these files located in the https://github.com/kubernetes/website/tree/master/content/en/docs/reference/setup-tools/kubeadm/generated ?
Can you give me some guide ?

Please target this to dev-1.21 branch. The master branch is for 1.20.

Please target this to dev-1.21 branch. The master branch is for 1.20.

@tengqm thanks for your guide.
Close it due to #25935

@tengqm thanks for your guide.
Close it due to #25935


Fix dev build by not overwriting CODY_TESTING env

#468 added a new mechanism to publish logs to a seperate env for test builds. However as part of it it added a new branch that sets process.env.CODY_TESTING to true in development builds which breaks the current assumption that this is only true in test runs.
It's important we don't set this flag in dev builds since it also changes a bunch of other small things in the extension so I’m reverting this here. Not to mention that this was also breaking the changes in #468 as my dev env was now flooded in these errors:
Error logging event Error: error fetching Testing Sourcegraph API: FetchError: request to http://localhost:49300/.api/testLogging failed, reason: connect ECONNREFUSED <IP_ADDRESS>:49300 (http://localhost:49300/.api/testLogging)
    at /Users/philipp/dev/cody/lib/shared/src/sourcegraph-api/graphql/client.ts:523:29
    at processTicksAndRejections (/Users/philipp/dev/cody/lib/internal/process/task_queues.js:96:5)
    at SourcegraphGraphQLAPIClient.sendEventLogRequestToTestingAPI (/Users/philipp/dev/cody/lib/shared/src/sourcegraph-api/graphql/client.ts:398:36) {vslsStack: Array(3), stack: 'Error: error fetching Testing Sourcegraph API…src/sourcegraph-api/graphql/client.ts:398:36)', message: 'error fetching Testing Sourcegraph API: Fetc…00 (http://localhost:49300/.api/testLogging)'}

@akalia25 I don't think that the env overwrite is a necessary branch here anyways, can you confirm that this change makes sense?
Test plan
No more errors in the console when running dev mode

Hey @philipp-spiess, sorry for the confusion here, and thanks for the revert on this.
if (isExtensionModeDevOrTest) {
        process.env.CODY_TESTING = 'true'
    }

The reason for checking isExtensionModeDevOrTest and setting CODY_TESTING was to handle logging events during test runs. I was finding that both dev mode and tests execute in vscode.ExtensionMode.Development, so there was no way to distinguish them. The solution I attempted was to set CODY_TESTING to 'true' when in isExtensionModeDevOrTest, so test events could be logged.
The errors on the dev env were probably because the mock server is not running during regular development mode (which makes sense), so the connection was failing as it was trying to log to the test API.
A potential fix for that error could be to update client.ts to check both CODY_TESTING and the server endpoint URL like:
if (process.env.CODY_TESTING === 'true' && this.config.serverEndpoint === 'http://localhost:49300') then sendEventLogRequestToTestingAPI
However, this would still break the assumption that CODY_TESTING is only true in test runs. 🤔 I'll think of a more refined solution; but if you have any suggestions would love to hear them :)!

@akalia25 Are you refering to unit tests or what type of tests? We can make it so that every unit test has CODY_TESTING set if that would help 🤔

Hey @philipp-spiess, referring to the E2E tests vscode/test/e2e/.... I believe for those CODY_TESTING is already set to True? 🤔 .
I forgot to mention that I also made this change because eventLogger was not being initialized if
config.telemetryLevel === 'off' || isExtensionModeDevOrTest and so every time the tests were ran (isExtensionModeDevOrTest was true) and the eventLogger would not be created.

Hey @philipp-spiess, referring to the E2E tests vscode/test/e2e/.... I believe for those CODY_TESTING is already set to True? 🤔

I would expect that to be the case, yeah. Have you observed something else?

I forgot to mention that I also made this change because eventLogger was not being initialized if
config.telemetryLevel === 'off' || isExtensionModeDevOrTest and so every time the tests were ran (isExtensionModeDevOrTest was true) and the eventLogger would not be created.

That should be fine though because of the early return, no?

if (!eventLogger || !globalAnonymousUserID) {
   return

}

I would expect that to be the case, yeah. Have you observed something else?
All good there!

That should be fine though because of the early return, no?
I believe we would need the event logger to be initialized in order for the events to get sent to the dedicated testing environment. so we would need it to invoke eventLogger.log and not have it return.

So, in summary:

Need the eventLogger to be initialized
Isolate that it is a E2E Test vs. dev mode
Route those events on client.ts to send to sendEventLogRequestToTestingAPI

I forgot to mention that I also made this change because eventLogger was not being initialized if
config.telemetryLevel === 'off' || isExtensionModeDevOrTest and so every time the tests were ran (isExtensionModeDevOrTest was true) and the eventLogger would not be created.

That should be fine though because of the early return, no?

@philipp-spiess, @akalia25's goal in #468 was to test that event logging wasn't broken, by directing the telemetry logs to a sandboxed environment.
In hindsight we're missing clarity on what logs we want to send where. Question for @akalia25 and the analytics team.
Status quo:

Testing (E2E, integration), which we have been dropping
Development, which we have been logging in prod
Real use ↠ also prod, naturally


remove defaulting account in middleware

fixes https://github.com/AugurProject/augur/issues/2750
make sure middleware is using the correct address, UI needs to set it.

Justin's PR works, closing mine


[WIP] PROJQUAY-1370 - set olm.skipRange for upgrades

Issue: https://issues.redhat.com/browse/PROJQUAY-1370
Changelog:
none
Docs:
none
Testing:
confirm upgrade from 3.3.2 to 3.4.0
Details:
indicate upgrades may happen from 3.3.2 to 3.4.0

The issue that originated this PR is already closed. Closing. If needed, please reopen.


Automatic Backups

Just need to write a cron. Need to work out the best way to run these

https://packager.io/documentation/customizing-the-build/#crons

Infact, lets just use Clockwork for this. It allows us to deploy to a lot more places.


Use Mono.Unix for .NET Core runtime

This brings in support for running on Apple Silicon on macOS, as well as iOS, android, maccatalyst, etc.
Fixes #795

Looks like the same change is causing a failure on macOS in IronPython 3 (https://github.com/IronLanguages/ironpython3/pull/1301). I'm guessing it's a big with the package (since it was working with the netstandard version) but unfortunately I don't have access to a mac to try and pinpoint the issue.


[doc] Update HW dashboard urls

Update IP block URLs in the hw dashboard table to remove the /doc suffix. Required to fix 404 problems.

Hi @HU90m, please feel free to ignore if this is already handled in another PR. Thanks!

Hey @moidx, I have some working changes locally to fix this issue. Unfortunately the gen_specboard_html() function is completely dead code since 9eebde0a1c38980799e2d33cd2839b122fa59cc0, the changes are needed a bit further up the file to fix those 404s.
I will open a new PR when I've got the changes in a good state, plus deleting this dead code too. Thanks

Thanks @moidx and @hcallahan-lowrisc , I guess we can close out this PR.
I've opened https://github.com/lowRISC/opentitan/issues/17591 to track this issue.


[PLACEHOLDER] Graceful VS Code extension version handling in the integration (deep-linking) scenario

We need to ensure that the TTK (and other) extension and Kiota extension work smoothly even when one is upgraded to a new version.
We want to follow the Semantic versioning approach.
Open questions:

Define approach for handling the UX consistency across minor versions
Define mechanism to coordinate the release of major versions between both/all teams
Decide how to handle the situation on the client side when the user upgrades one extension to the new major version only. Enforce the upgrade of the second one?

Proposal for the handling (to be completed):

All minor/patch versions in the same major versions shall work end-to-end.

As I mentioned in the other issue, I'm not sure we need to check version installed as VS Code extension always gets updated automatically to the latest version.
What's your proposal here?

Is there anything else we need to do to address this?


Add Bluesky for Jennifer

Hi @jhylin,
I'm working on adding a Bluesky integration for the PyLadies bot and saw that you're also on Bluesky. Please let me know if you agree to add your handle here as well so that the bot can use it to tag you when posting about your posts ☺

Hi Cosima,
Yes, sure thing 🙂, thank you for this.
Jennifer

On 2/11/2024, at 2:17 AM, Cosima Meyer @.***> wrote:
Hi @jhylin https://github.com/jhylin,
I'm working on adding a Bluesky integration for the PyLadies bot and saw that you're also on Bluesky. Please let me know if you agree to add your handle here as well so that the bot can use it to tag you when posting about your posts ☺
You can view, comment on, or merge this pull request online at:
https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66 https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66
Commit Summary
82bfd84 https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66/commits/82bfd8406d2aeb159e27088614adfdcaf2ee3ab9 Add Bluesky for Jennifer
File Changes (1 file https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66/files)
M blogs/jhylin.github.io.json https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66/files#diff-d9262b7f9eccc3a8ecdfdb0660e18138459eda48c918a5315bada2dc33a1b2f7 (3)
Patch Links:
https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66.patch https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66.patch
https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66.diff https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66.diff
—
Reply to this email directly, view it on GitHub https://github.com/cosimameyer/awesome-pyladies-blogs/pull/66, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQ6EN6XCGFEQVLTAOABQLTZ6N5M7AVCNFSM6AAAAABRAIBPF2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDSMBRGY4TQMY.
You are receiving this because you were mentioned.

Awesome, thank you so much!


flutter form builder remove row issue

I use the value of FormBuilderDropdown to add or remove rows when
flutter: Field with attribute 'attribute' already exists. Make sure that two or more fields don't have the
flutter: same attribute name.
flutter: 'package:flutter_form_builder/src/form_builder.dart': Failed assertion: line 64 pos 12:
flutter: '_fieldKeys.containsKey(attribute) == false'
How can I configure to add or delete rows?

Kindly use the latest version where the assertion has been removed.

I am using 3.1.0

which version
On Fri, Jul 12, 2019 at 10:25 PM Danvick Miller<EMAIL_ADDRESS>wrote:

Kindly use the latest version where the assertion has been removed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/danvick/flutter_form_builder/issues/89?email_source=notifications&email_token=AJLR67DXVYC5574HOFV36FDP7CZPNA5CNFSM4H6GH33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2JSYY#issuecomment-510957923,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJLR67HRSIVZFHIG6ICFBBTP7CZPNANCNFSM4H6GH33A
.

--
Shrutika Tatkare | Eiosys Inc.
Tel: +91 22 6464 6561 |<EMAIL_ADDRESS>| http://www.eiosys.com

https://pub.dev/packages/flutter_form_builder#-changelog-tab-

ok. I will try & revert you. thank you.
On Mon, Jul 15, 2019 at 12:19 PM Danvick Miller<EMAIL_ADDRESS>wrote:

https://pub.dev/packages/flutter_form_builder#-changelog-tab-
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/danvick/flutter_form_builder/issues/89?email_source=notifications&email_token=AJLR67HMO46RZC2FZVH4O63P7QMWJA5CNFSM4H6GH33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ422PI#issuecomment-511290685,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJLR67DNUZSKNIWVDHM5OSLP7QMWJANCNFSM4H6GH33A
.

--
Shrutika Tatkare | Eiosys Inc.
Tel: +91 22 6464 6561 |<EMAIL_ADDRESS>| http://www.eiosys.com

It's working. Thank you so much.
On Mon, Jul 15, 2019 at 12:25 PM shrutika tatkare <
<EMAIL_ADDRESS>wrote:

ok. I will try & revert you. thank you.
On Mon, Jul 15, 2019 at 12:19 PM Danvick Miller<EMAIL_ADDRESS>wrote:

https://pub.dev/packages/flutter_form_builder#-changelog-tab-
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/danvick/flutter_form_builder/issues/89?email_source=notifications&email_token=AJLR67HMO46RZC2FZVH4O63P7QMWJA5CNFSM4H6GH33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ422PI#issuecomment-511290685,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJLR67DNUZSKNIWVDHM5OSLP7QMWJANCNFSM4H6GH33A
.

--
Shrutika Tatkare | Eiosys Inc.
Tel: +91 22 6464 6561 |<EMAIL_ADDRESS>| http://www.eiosys.com

--
Shrutika Tatkare | Eiosys Inc.
Tel: +91 22 6464 6561 |<EMAIL_ADDRESS>| http://www.eiosys.com


Wrap badges into links

:clipboard: Description
It'd be nice to have (copy) badges not only as images, but as images in links!
When it's supported (opened) by service.
Actual behavior
Markdown for Cirrus CI AlexWayfer/flame repository:
![Cirrus CI - Base Branch Build Status](https://img.shields.io/cirrus/github/AlexWayfer/flame)

The same for Travis CI: https://travis-ci.org/puma/puma
Circle CI: https://circleci.com/gh/rubocop-hq/rubocop/tree/master
Etc.
Expected behavior
[![Cirrus CI - Base Branch Build Status](https://img.shields.io/cirrus/github/AlexWayfer/flame)](https://cirrus-ci.com/github/AlexWayfer/flame)

Hi @AlexWayfer,
We support links in badges, for example:
https://img.shields.io/cirrus/github/AlexWayfer/flame?link=https://cirrus-ci.com/github/AlexWayfer/flame
Is this what you're looking for?

Hm, sorry. I'm talking about this:

So, I'd like to copy Markdown of badge with link.

If I understand the request correctly, I think it may be a duplicate of #3928

If I understand the request correctly, I think it may be a duplicate of #3928

Thank you, let's try to merge it.


Add Rich Text Support to SolidJS i18n

Describe The Problem To Be Solved
Currently, we can't add links or styled text inside i18n translations in SolidJS. We need a simple way to add components like  or  tags within our translated text, similar to how next-intl does it.
Suggest A Solution
Add a simple t.rich() method that allows mapping custom tags to Solid components:
Example usage:
{
  "message": "Please refer to <guidelines>{name}</guidelines>"
}

const t = useTranslations();

t.rich('message', {
  guidelines: (text) => {text}
  name: "the guidelines"
})

Key features:

Support basic tag mapping
Work with existing SolidJS components
Keep the same simple API as regular translations

This would give us an easy way to add links and formatting to our translations while keeping the code clean and maintainable.

I like the simple concept
Maybe not that rich here is a method on whatever t is
If this could be done as a separate helper I wouldn't really mind
Don't see a way to make this type-safe though
At least not without codegen
So the "maintainable" part is up for debate

Thanks for the feedback @thetarnav
You're right about the implementation concerns. I think we could start simple with just basic runtime validation of the tags and mapping object. No need to overcomplicate things with type safety or codegen at this stage.
The separate helper approach you suggested makes sense too. The main goal is just to enable basic rich text support in translations.

I like the idea of a resolveTags helper. Not being type safe may be a drawback, but not one that should concern us. We should use a callback function that emits a warning in DEV and strips the tags in prod.

This is a must need. Not the best/easiest way to implement it, but some feature is better than no feature

I found a good example which work like next-intl
https://github.com/formatjs/formatjs/blob/57f214332f0a761e3620793b82d70e15cde5e72f/packages/icu-messageformat-parser/parser.ts#L346


Bug 1952238: Report catalog pod termination logs to catalog operator on exit

Description of the change:
This PR sets the terminationMessagePolicy for the registry container in the
catalog pod as FallBackToLogsOnError to report back termination logs from a
catalog pod to the catalog operator
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

/retest

/approve

/retest


Popup Options

Atm, the following options are listed by name.
 const popupEl = new mapbox.Popup({
  offset: popupOffset,
  className: popupClassName
})

There are a good number of other options in the API in the Docs
My problem here is that naming all of them in the marker is going to get a bit excessive.  If I were to merge popupOffset & popupClassName into and popupOptions object this would be a breaking change. :(
What are the implications of spreading an object
const popupEl = new mapbox.Popup({
  offset: popupOffset,
  className: popupClassName,
  ...popupOptions
})

Would something like this be better
namedParams = { offset: popupOffset,  className: popupClassName }
const popupEl = new mapbox.Popup(Object.assign(namedParams, popupOptions))

I think the spread option is fine, but to retain compatibility with crap browsers, it's better to use Object.assign

Just working on it now.  Will pop a PR together.

Released as v7.7.1


[RFC] Deprecate global repository configuration

Since HuPKit v1.2 it's possible to store repository configuration (repository splits mainly) either locally (in the _hubkit branch) or globally in the config.php located with the installed HuPKit installation.
In v1.3 a new feature was (is) added to allow configuring the main-branch, and additional features are planned as well.
Note that the main-branch can only be configured with the local configuration, and the same will apply to new repository configuration as well (with the exception of branch-level configurations).
For HuPKit v1.4 I'd like to propose to deprecate the global repository configuration (not adapter configurations, as tokens cannot be stored within version control 😄 ) and remove global repository configuration completely in v2.0.
This makes the documentation easier to understand and explain and prevents outdated configuration among team members.
Note that it's not required (but recommended) to push the _hubkit configuration branch to the remote central repository, so only keeping this branch locally still works as normal.
Please let me know of any objections, thanks 👍🏼


Communication examples

It would be nice to have a complete example of testing a protocol. UART send and receive would be fairly simple.
This is partially addressed in https://github.com/NathanY3G/rp2040-pio-emulator/issues/123 and https://github.com/NathanY3G/rp2040-pio-emulator/issues/121, but they don't mention how to get data out of the FIFO.
I'm also not sure if the emulator allows the incoming signals to respond to the outputs. It looks like it's only fed the time. This makes it hard to test bidirectional protocols like I2C for 1-Wire.

Hi @kamocat :wave:
Thanks for raising these great points. I will endeavor to add some examples soon - UART is a good suggestion :+1:
For the second point, I believe this could be addressed if the emulator passed additional information into the input_source function / callable. I will give this some more thought instead of making a change now. Do you believe this approach would work for you?

Yes, that is a good approach.

Hi @kamocat 👋
Thanks for raising these great points. I will endeavor to add some examples soon - UART is a good suggestion 👍
For the second point, I believe this could be addressed if the emulator passed additional information into the input_source function / callable. I will give this some more thought instead of making a change now. Do you believe this approach would work for you?

I think changing the input_source method to take the current_state object would likely be the fastest/easiest method... the one consideration would be that it's a breaking change. Can we maybe continue to pass the clock as the first argument, but add a keyword arg if the method supports it? Can either do a try/catch (try to pass it, otherwise fall back to just the clock) or maybe use inspect.getargspec(input_source) to check what keyword args are actually supported by the callable.

Thanks for your input @aaronjamt. Rest assured, I have no plans to make breaking changes... even though this library hasn't made it to version 1.0! I believe we are thinking on similar lines. Before I merge a solution tomain, I will put a reference to my branch on this PR for you both.

In the mean time, the main program could store the state in a global var after every call to emulate, then use that in the input_source method... not ideal of course but until there's a proper solution in place that might be a decent option

The OOP solution is to create a class for the state machine, which is configured up front and then passes the data around. However, this means breaking changes.
The functional programming solution is to use a partial function. This doesn't require any changes to the library and allows the data to be passed via a variable in the for loop.

It was a good suggestion @kamocat :slightly_smiling_face:

After trying a few different ideas, I have implemented a solution on the input-source-signature branch. This avoids any breaking changes by using type hints to support the following signatures.
(int) -> int
(State) -> int

If no type hint is specified then a warning is output but the existing behaviour is preserved i.e. an int is passed to the input_source.

I have an example for the rx fifo where I print out the value and the clock. It uses print(), but maybe you can think of a way to put it on the plot?
import matplotlib.pyplot as plt
import seaborn as sns
from pioemu import clock_cycles_reached, emulate, State
import adafruit_pioasm
from collections import deque

program = adafruit_pioasm.assemble("""
; A crystal oscillator and counter
    set pins, 1
    mov x, ~ x
loop:
    wait 1 pin 0
    set pins, 0
    mov isr, ~ x
    push noblock
    wait 0 pin 0
    set pins, 1
    jmp x-- loop
""")

pin_value_series = []

for _, state in emulate(program, stop_when=clock_cycles_reached(72 + 1)):
    pin_value_series.append((state.clock, state.pin_values & 0x01))
    rx = state.receive_fifo
    if len(rx) > 0:
        print(f'{state.clock}: {rx.pop()}')

x_values = [clock for clock, logic_level in pin_value_series]
y_values = [logic_level for clock, logic_level in pin_value_series]

sns.set_style("darkgrid")
figure = plt.figure(figsize=(16, 1))
plot = sns.lineplot(x=x_values, y=y_values, drawstyle="steps-pre")
plot.set_xlabel("Clock cycles", fontsize = 16)
_ = plot.set_xticks(range(0, x_values[-1]))
plt.tight_layout()
plt.show()

Hi @kamocat. I will take a look after work and see if I can offer up some ideas. The combination of Jupyter and Maplotlib is both powerful and flexible - the limiting factor tends to be the imagination!

I have got some ideas for you @kamocat!

At the moment the clock is internal to the program, consequently each wait instruction executes within a single clock cycle. If the clock was externalised (example below) then you could plot the wait states on the same graph as the clock. If you then added the point in time when the FIFO is loaded then you could have 3 or 4 data series that might make for an interesting plot.

def clock_source(state: State):
    "Provides a clock source with a 50% duty-cycle derived from the PIO clock"
    return state.clock % 8 >= 4

Yes, I think examples would be helpful.
I was thinking of printing the data words left-aligned to the clock edge they were put in the FIFO, but that raises questions about font size and clipping box size that will require tweaking for each example.

I will take a look this weekend for some good examples and get back to you.

Hi @kamocat. Just a quick update to let you know that I have not forgotten! I intended to provide some examples soon.

I have added a new example which enables GTKWave to be used for the visualisation of PIO programs.

Hi Nathan, thank you for the example. It looks like it reads the PIO source from a file and outputs FST? Nice!
I don't have GTKView for Windows at the moment, but it looks like I could either change this to output VCD or add FST to my to-do list for Pulseview 😀

Thanks @kamocat :smiley:
PulseView is a great tool! As you said, it should be possible to adapt the example to output VCD instead. There is also an existing fst2vcd tool which might work. However, if you hit any issues I am happy to try and help :smiley:


Create Docker Images for Docker Hub

I'm in the process of creating docker images for docker hub which will allow the following.

Creation of docker-compose.yml and docker-compose-common-components.yml only, nothing else required.
This would allow tracking of CRCON config files via git, the current install method is to git pull and rebuild which sees docker-compose.yml as being modified.
Allow for switch between latest and test tags easily.
Conforms to other opensource projects.
Can be updated automatically using watchtower.

I've created the repository here: https://hub.docker.com/r/jordantrizz/crcon its not stable yet as I'm testing.
Eventually, it would be good to stop using docker-compose-common-components.yml and have defaults set for all environment variables and then provide methods to override the defaults via docker-compose.yml as there should be no reason to have two separate docker compose files. Just a docker-compose.yml and .env if you wish to.

So right now we already automatically build images on Docker Hub, but only for linux/amd64. It triggers when we push a tag and builds a backend (also used by the supervisor container) image and a frontend image.
The repository (and the tag) for both these images is set in .env so people can substitute whatever repos and version they want if they want to build their own images and upgrade/downgrade easier (it used to be hard coded into the compose files).
I do agree there is room for improvement, any thoughts on https://github.com/MarechJ/hll_rcon_tool/pull/517 ?
That gets us (with github actions) automatically built images for linux/amd64, linux/arm64 and linux/arm32 (I didn't test with others as I think that covers the vast majority of common use cases).
It also changes the redis and postgres image names to be environment variables so they can be changed at will.
At that point I think the only things we have hard coded in the compose files are the server number and redis database number, we could expose those but there is a bit of a balance to strike between how much work it is for people to upgrade (they have to update their .env anytime we add new stuff and confusing users.
I think we could possibly get away with just making the redis database number match the server number (there are 16 databases by default. Right now they're zero indexed but it shouldn't hurt anything to make them the same.
The server number is not exposed in .env but I think we could also move that, the only downside to that I can think of is people putting in stupid values for it, but there's nothing stopping people from doing that in the compose files right now.


Question: "Passed" when I'd expect "Failed"

Hi there, we're just starting to use unimport via pre-commit. I'm getting the following output:
unimport.................................................................Passed
- hook id: unimport
- duration: 1.37s

request at internal/edgeauth/helpers.py:5

This seems confusing to me; I'd expect this to return "Failed" or something and exit uncleanly so that pre-commit (which we're using in CI) would fail.
Here's the pre-commit setup for this check:
repos:
  # ..snipped other repos
  - repo: https://github.com/hakancelik96/unimport
    rev: v0.2.7
    hooks:
      - id: unimport

I'm probably misunderstanding something. From the docs I see a few options like rewriting, etc, but in our case we just pre-commit to report "Failed" if a change would be made.
If it turns out this is a bug in unimport I'm happy to write the PR for it - I just want to make sure I'm not missing something obvious first :)

Hi, thank you but I think this is not a bug, you don't use any arguments in the .pre-commit-config.yaml
If there is unused import in your project, you should use the -r parameter to auto-remove them, as a result, if it finds unused import, it will fail.
-r # auto-remove unused import in your project

If you want to include star imports during refactoring please use --include-star-import  flag.

This feature doesn't work very well in this version, be careful when using

Can you rewrite your .pre-commit-config.yaml conf as below and try?
  - repo: https://github.com/hakancelik96/unimport
    rev: v0.2.7
    hooks:
      - id: unimport
        args: [-r]
        files: "\\.(py)$"

Aha, I see now. Thank you for the quick response! 👍
I see I missed this here:

The hook must exit nonzero on failure or modify files.

the "or modify files" is subtle and now that I understand that, and re-read -r it makes sense.


add href attribute to link paginate

bootstrap
It works poorly if this attribute is not present.
How can I add?

same here

Has anyone have success in making the cursor look like a pointer  here using bootstrap styling if only
a has an href='#'

Same issue, any solution?

One solution is to:

Copy the entire code from here to your project,
Find these three functions getFullLinks, getLimitedLinks, getSimpleLinks (around line 430+)
Inside each of them there's a data const, which is an object
Add href attribute inside those objects like below

const data = {
  attrs: {
    href: "#",
  },
  on: {
    ...
  },
}


Allow to use label checker with milestoned/demilestoned trigger

In our project we would like to have one job to check if labels and milestone are set properly. Unfortunately the milestoned/demilestoned trigger is emitted as issues, not pull request name.
But if event is touching pull request then github.event.issue.pull_request is not null and number could be received from github.event.issue object
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=milestoned#issues
It will be really nice if you could add this functionality to this project (or I may try to do PR if you want).

Hi @Czaki, thanks for suggesting this.  Can you provide an end-to-end example (not the technical "how" but rather an example of the end-to-end workflow you're looking for), to help me understand and evaluate whether it's something we could/should add to the label checker?  Thanks very much 🙏🏻

I have spent more time investigating the problem. The issue trigger is not helpful at all, as it is not visible in pull request check status.  But I found in the documentation of the payload that the milestoned/demilestoned triggers are available:
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=milestoned#pull_request
And I have checked that it works. Even if documentation do not mention it in any place.
Our workflow (state from open PR) looks now:
name: Label and milestone checker
on:
  pull_request:
    types:
      - opened
      - synchronize
      - reopened
      - labeled
      - unlabeled
      - milestoned
      - demilestoned
  merge_group: # to be prepared on merge queue
    types: [checks_requested]

jobs:
  check_labels_and_milestone:
    if: (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ready to merge'))
    name: Check labels and milestone
    runs-on: ubuntu-latest
    steps:
      - name: Check labels
        uses: docker://agilepathway/pull-request-label-checker:latest
        with:
          any_of: bugfix,feature,documentation,performance,enhancement,maintenance
          repo_token: ${{ secrets.GITHUB_TOKEN }}

      - name: Check milestone
        if: github.event.pull_request.milestone == null
        run: |
          echo "Please add a milestone to this PR"
          exit 1

Sorry for the noise. I have opened PR to github docs https://github.com/github/docs/pull/29837


Bug of ag or bug of vim?

My plugin LeaderF encountered an issue, ag can not list files on Windows.
Steps to reproduce:

enter vim
run the below commands::py import subprocess
:py print subprocess.Popen('ag -g "" .', shell=True, stdout=subprocess.PIPE).stdout.read()

no output.(suppose there are some files in current directory)
Expected result:
all the files can be listed just like running ag -g "" . in git-bash.
If purely run the python code, everything works fine.
For example, execute the command  py -2 test.py, test.py is as below:
import subprocess
print ( subprocess.Popen('ag -g "" .', shell=True, stdout=subprocess.PIPE).stdout.read() )

So, I think this probably is a bug of vim.

Have you tried with a different binary than ag?

I have tried rg, it works well.

@JRuiChen  'Ag' does not work for me either.

@Yggdroot

@Yggdroot
enter vim
:py import subprocess
:py print subprocess.Popen('ag -g "" .', shell=True, stdout=subprocess.PIPE).stdout.read()
I have no output either.

The problem i faced is,  in  .vimrc:
let g:Lf_IndexTimeLimit=20
let g:Lf_DefaultExternalTool="ag"
let g:Lf_RootMarkers=['version.txt', 'server', 'client']
Enter vim , the LeaderFile command has no output.   In .LFCache Dir, there is no cache files greater than 0 created.
The i changed .vimrc to:
let g:Lf_IndexTimeLimit=120
let g:Lf_DefaultExternalTool="Ag"
let g:Lf_RootMarkers=['version.txt', 'server', 'client']
Enter vim, LeaderFile works well. And in .LFCache Dir, it has created some caches file greater than 0

@JRuiChen What is the output of echo echo g:Lf_Debug_Cmd? According to my logic, you are not using ag.

@Yggdroot

When g:Lf_DefaultExternalTool="Ag",  there is no output for echo g:Lf_Debug_Cmd. But the command LeaderFile works well for a new directory  .
When  g:Lf_DefaultExternalTool="ag",  there is the output   ag --nocolor --silent -ignore "*.SW?" --ignore "*.bak" -g  "" "C:\pack_tool_chain".  But the command LeaderFile lists no files for a new directory  .
In my vim's command mode, only 'Ag' is valid, 'ag' is not.
So, the two commands LeaderFile and echo g:Lf_Debug_Cmd both use the property g:Lf_DefaultExternalTool,  but Ag is valid for LeaderFile, and ag is valid for  g:Lf_Debug_Cmd.

@JRuiChen let g:Lf_DefaultExternalTool="Ag" is the same as g:Lf_DefaultExternalTool="asdfasfasdf", because in this case g:Lf_DefaultExternalTool does not take effect, LeaderF uses the default index logic.
Available values for g:Lf_DefaultExternalTool are 'rg', 'pt', 'ag', 'find', which are case sensitive.
https://github.com/Yggdroot/LeaderF/blob/a7ac653667fd23e74f8ac290a2796acd1123d299/autoload/leaderf/python/leaderf/fileExpl.py#L207-L367

@Yggdroot
You are right. It is not the prolem of 'Ag' or 'ag'. When 'Ag', it is just using os.walk(dir) to get filelist.

@chrisbra Verified that this must be bug of vim.
import subprocess
print ( subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE).stdout.read() )

Because rg does not work either.
There must be something wrong for windows gvim to process double quote.

Have you checked the various shell options? 'shellquote'  might be relevant (and possibly others as well)

I tried this with ag installed from msys2/mingw64 package manager. Worked fine for me.

shell options do not help.

Per discussion in https://github.com/macvim-dev/macvim/issues/1003 LeaderF should add stdin=subprocess.DEVNULL as an additional component as a proper usage to pass an input stream to a python process. In :help python-input is written, that reading from standard input produces undefined behaviour including a possible crash  (see text below).
							*python-input*
	Input (via sys.stdin, including input() and raw_input()) is not
	supported, and may cause the program to crash.  This should probably be
	fixed.
`

This should go to the leaderf repo, not here, right?

Am 12.12.2020 um 10:34 schrieb Arseny Nasokin<EMAIL_ADDRESS>
Per discussion in macvim-dev/macvim#1003 LeaderF should add stdin=subprocess.DEVNULL as an additional component as a proper usage to pass an input stream to a python process. In :help python-input is written, that reading from standard input produces undefined behaviour including a possible crash (see text below).
  					*python-input*

Input (via sys.stdin, including input() and raw_input()) is not
supported, and may cause the program to crash.  This should probably be
fixed.
`
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

if it's not possible to provide for Python by Vim Core the stable and predictable stdin (like /dev/null), then yes. I think that neovim provides /dev/null as an stdin for plugins.

As per discussion in macvim-dev/macvim#1003 LeaderF should add stdin=subprocess.DEVNULL as an additional component as a proper usage to pass an input stream to a python process. In :help python-input is written, that reading from standard input produces undefined behaviour including a possible crash (see text below).
							*python-input*
	Input (via sys.stdin, including input() and raw_input()) is not
	supported, and may cause the program to crash.  This should probably be
	fixed.
`

Thanks, this works for me.

Actually, I kind of agree with @eirnym. Seems like having a "is not supported, and may cause the program to crash" default seems… dangerous? That sounds like it's easy to trick Vim into undefined behavior which is not great.
From the bug report, this didn't fail when being called in terminal Vim, which I think means the Python script is using the stdin from the terminal, which I think is always not the desired behavior? Seems like providing /dev/null is going to improve compatibility and potential security/random issues.

could you provde a PR for that change then?

I could probably look into this in a few days.


Update link to maven plugin source code

The link to the source code of the gatling maven plugin pointed to https://github.com/gatling/gatling-maven-plugin, which I believe is not current. I've updated the link to point at https://github.com/gatling/gatling-maven instead.

Thanks!


Set text-nowrap for -B- and -N- columns

This PR adds a text-nowrap class to the two columns holding the -B- and -N- text. This avoids text wrapping in some browsers the destroys part of the layout. Attaching two screenshots of before and after:
Before:

After:

Nice, this works on both Firefox and Chrome now


Bump next

📝 Changed routes:

/index.server
/note/[id].server

(view full size)
(view full size)

And 1 other route:

/api/notes

Commit 8f8cee8b02c89543bbe023ad14d47a0b9b42ed5d (https://next-rsc-notes-8r84purbj.vercel.sh).


ADBDEV-2270 6.18.2 sync

Here are some reminders before you submit the pull request

[ ] Add tests for the change
[ ] Document changes
[ ] Communicate in the mailing list if needed
[ ] Pass make installcheck
[ ] Review a PR in return to support the community

1602ef9 has forbidden SharedScan inside subplans. We need to modify test implemented in 3cfbbc20bf296d61961db9eaa21c9cf07011817e. @InnerLife0, please make sure that changes are correct.

@maksm90, @InnerLife0, this PR is ready for review. There are only known issues among failed behave tests only.


shark euler vmfb doesn't have a device qualifier

So if you switched between a vulkan device and cuda device (on nvidia) we try to run the vulkan vmfb.

Didn't see this until now. I have time to fix it today.

Closing, as this is resolved by https://github.com/nod-ai/SHARK/commit/133c1bcaddfd9a507ce9dbe045294eb3751c9adc


MODE-2403 Added a test case to validate that the LIKE operator works correctly and is case-sensitive.

Looks good.


Add Codecov badge

Current coverage is 18.18%

Branch #1 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


[LIG-27] done

Codecov Report

Merging #10 (aeb8fe6) into master (58af05c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   67.35%   67.34%   -0.01%
==========================================
  Files          20       20
  Lines        1547     1562      +15
==========================================
+ Hits         1042     1052      +10
- Misses        505      510       +5

Impacted Files
Coverage Δ

src/stream/src/state.rs
21.95% <0.00%> (-0.55%)
:arrow_down:

src/common/tests/test_kafka.rs
89.65% <0.00%> (-3.21%)
:arrow_down:

src/common/src/kafka.rs
86.36% <0.00%> (-2.01%)
:arrow_down:

src/stream/src/actor.rs
56.68% <0.00%> (-0.38%)
:arrow_down:

src/common/tests/test_mysql.rs
100.00% <0.00%> (ø)

src/stream/tests/test_sinks.rs
99.21% <0.00%> (+0.03%)
:arrow_up:

src/common/src/db.rs
78.57% <0.00%> (+3.57%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update user ikennaokpala details on integration enviroment

This PR Update the ssh key for use ikennaokpala to 4096 bits and also adds this user to the users list.

Thanks @ikennaokpala!

Merge when green.

@mattbostock Thanks