WebSocket reconnection delay when app transitions from background to foreground

Describe the bug
Our clients are experiencing issues with receiving delta changes when transitioning between background and foreground states.
Issue Details:
When the app moves to the background, the WebSocket connection disconnects as expected.
Upon returning to the foreground, the WebSocket reconnection is delayed, taking anywhere from 3 to 5 minutes, sometimes even longer. The reconnection time is inconsistent.
As a result, users are unable to receive the latest data (delta changes) in a timely manner, causing significant problems in real-time data sync.
Key Questions:
What is the expected reconnection time for WebSocket after moving from background to foreground?
What is the minimum duration users should expect to wait for receiving delta changes after resuming from the background?
Is there any configuration from that we can modify the time as per our need?
This delay is negatively impacting user experience in our production app, and we’re seeking guidance on how to resolve this issue.
Steps To Reproduce
Just moved the application to background to foreground.

Expected behavior

The WebSocket connection should resume immediately when the app transitions from background to foreground.
Delta changes should be reflected to users without delay, ensuring real-time data synchronization as soon as the app is active again.

Amplify Framework Version
2.37.0
Amplify Categories
DataStore
Dependency manager
Swift PM
Swift version
5.10
CLI version
12.6
Xcode version
15.3
Relevant log output
<details>
<summary>The application was brought to the foreground on 2024-09-16 18:29:16.658564+0530 . However, the WebSocket connection was not re-established immediately. The first successful connection message was logged at 2024-09-16 18:33:42.039403+0530.

This delay occurred for both:

[WebSocketClient]
[APIAppSyncRealTimeClient]

There was a gap of approximately 4 minutes and 26 seconds between the app being brought to the foreground and the WebSocket connection being re-established.</summary>

2024-09-16 18:29:16.658564+0530 INVFormsApp-mRounds[4508:1327673] [APIAppSyncRealTimeClient] [AppSyncRealTimeClient] Received subscription request id: 722FBAAA-589D-4651-A8C3-11C37C950539, query: {"query":"subscription OnCreateLocation {\n  onCreateLocation {\n    id\n    archivedAt\n    archivedBy\n    constField\n    createdAt\n    createdBy\n    description\n    image\n    isArchived\n    isUnit\n    locationId\n    model\n    name\n    parentId\n    plantsID\n    searchTerm\n    updatedAt\n    wasUnit\n    __typename\n  }\n}"}
2024-09-16 18:29:16.660026+0530 INVFormsApp-mRounds[4508:1327696] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-722FBAAA-589D-4651-A8C3-11C37C950539] Start subscribing
2024-09-16 18:29:16.663505+0530 INVFormsApp-mRounds[4508:1327168] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-D0B1C3F4-A902-4284-8BA2-3A1C30EE1B74] Start subscribing
2024-09-16 18:29:16.663606+0530 INVFormsApp-mRounds[4508:1327715] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-8C96C4C0-24CA-4982-AD16-EB336E5F098E] Start subscribing
*****SYNC onUpdate Subscription of Location connect state is connecting
*****SYNC onDelete Subscription of Location connect state is connecting
2024-09-16 18:29:16.663708+0530 INVFormsApp-mRounds[4508:1327168] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-E672A58E-D9E6-426D-ADCD-302260302F83] Start subscribing
2024-09-16 18:29:16.663778+0530 INVFormsApp-mRounds[4508:1327715] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-4E073E91-19B7-4B6C-9F8D-C20AB8875740] Start subscribing
*****SYNC onCreate Subscription of Assets connect state is connecting
*****SYNC onUpdate Subscription of Assets connect state is connecting
2024-09-16 18:29:16.663810+0530 INVFormsApp-mRounds[4508:1327809] [APIAppSyncRealTimeSubscription] [AppSyncRealTimeSubscription-C6F1C22D-DB60-4E16-AF9C-006A65808963] Start subscribing
*****SYNC onDelete Subscription of Assets connect state is connecting

2024-09-16 18:29:16.693187+0530 INVFormsApp-mRounds[4508:1327674] [connection] nw_read_request_report [C20] Receive failed with error "Software caused connection abort"
2024-09-16 18:29:16.694794+0530 INVFormsApp-mRounds[4508:1327813] [websocket] Read completed with an error Software caused connection abort
2024-09-16 18:29:16.695126+0530 INVFormsApp-mRounds[4508:1327673] [WebSocketClient] [WebSocketClient] read message failed with connection state NSURLSessionTaskState(rawValue: 2), error Error Domain=NSPOSIXErrorDomain Code=53 "Software caused connection abort" UserInfo={NSDescription=Software caused connection abort}
2024-09-16 18:29:16.695159+0530 INVFormsApp-mRounds[4508:1327673] [WebSocketClient] [WebSocketClient] WebSocket connection state is NSURLSessionTaskState(rawValue: 2). Failed to read websocket message
2024-09-16 18:29:16.695406+0530 INVFormsApp-mRounds[4508:1327813] Task <3E164117-104F-424B-8AC6-CAC979954A87>.<1> finished with error [53] Error Domain=NSPOSIXErrorDomain Code=53 "Software caused connection abort" UserInfo={NSDescription=Software caused connection abort, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "LocalWebSocketTask <3E164117-104F-424B-8AC6-CAC979954A87>.<1>"
), _NSURLErrorFailingURLSessionTaskErrorKey=LocalWebSocketTask <3E164117-104F-424B-8AC6-CAC979954A87>.<1>}
2024-09-16 18:29:16.695565+0530 INVFormsApp-mRounds[4508:1327673] [WebSocketClient] [WebSocketClient] URLSession didCompleteWithError: Error Domain=NSPOSIXErrorDomain Code=53 "Software caused connection abort" UserInfo={NSDescription=Software caused connection abort, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "LocalWebSocketTask <3E164117-104F-424B-8AC6-CAC979954A87>.<1>"
), _NSURLErrorFailingURLSessionTaskErrorKey=LocalWebSocketTask <3E164117-104F-424B-8AC6-CAC979954A87>.<1>})
2024-09-16 18:29:16.695677+0530 INVFormsApp-mRounds[4508:1327673] [APIAppSyncRealTimeClient] [AppSyncRealTimeClient] Received websocket event error(AWSPluginsCore.WebSocketClient.Error.connectionLost)
2024-09-16 18:29:16.695702+0530 INVFormsApp-mRounds[4508:1327673] [APIAppSyncRealTimeClient] [AppSyncRealTimeClient] WebSocket error event: connectionLost
2024-09-16 18:29:16.695801+0530 INVFormsApp-mRounds[4508:1327674] [connection] nw_flow_add_write_request [C20 <IP_ADDRESS>:443 failed parent-flow (satisfied (Path is satisfied), interface: en0[802.11], ipv4, dns)] cannot accept write requests
2024-09-16 18:29:16.695844+0530 INVFormsApp-mRounds[4508:1327674] [connection] nw_write_request_report [C20] Send failed with error "Socket is not connected"
2024-09-16 18:29:16.695968+0530 INVFormsApp-mRounds[4508:1327715] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.695969+0530 INVFormsApp-mRounds[4508:1327810] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error2024-09-16 18:29:16.696014+0530 INVFormsApp-mRounds[4508:1327715] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `IssuesLogHistory` error: WebSocketClient connection aborted
 Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.696044+0530 INVFormsApp-mRounds[4508:1327168] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.696075+0530 INVFormsApp-mRounds[4508:1327811] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.697171+0530 INVFormsApp-mRounds[4508:1327810] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `AdhocRoundDetails` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697281+0530 INVFormsApp-mRounds[4508:1327168] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `IssuesList` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697278+0530 INVFormsApp-mRounds[4508:1327811] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `ActionsLogHistory` error: WebSocketClient connection aborted
2024-09-16 18:29:16.696243+0530 INVFormsApp-mRounds[4508:1327814] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.697361+0530 INVFormsApp-mRounds[4508:1327811] [APIRetryableGr2024-09-16 18:29:16.697362+0530 INVFormsApp-mRounds[4508:1327168] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
aphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.697251+0530 INVFormsApp-mRounds[4508:1327715] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.696340+0530 INVFormsApp-mRounds[4508:1327809] [APIRetryableGraphQLSubscriptionOperati2024-09-16 18:29:16.697469+0530 INVFormsApp-mRounds[4508:1327810] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.697480+0530 INVFormsApp-mRounds[4508:1327715] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `RoundDetails` error: WebSocketClient connection aborted
on<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.697436+0530 INVFormsApp-mRounds[4508:1327168] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `ActionsLogHistory` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697502+0530 INVFormsApp-mRounds[4508:1327810] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `Users` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697388+0530 INVFormsApp-mRounds[4508:1327814] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `UserDevices` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697445+0530 INVFormsApp-mRounds[4508:1327811] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `RoundDetails` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697555+0530 INVFormsApp-mRounds[4508:1327715] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.2024-09-16 18:29:16.698201+0530 INVFormsApp-mRounds[4508:1327811] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
698161+0530 INVFormsApp-mRounds[4508:1327715] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `AdhocRoundDetails` error: WebSocketClient connection aborted
2024-09-16 18:29:16.698229+0530 INVFormsApp-mRounds[4508:1327811] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `Plants` error: WebSocketClient connection aborted
2024-09-16 18:29:16.697556+0530 INVFormsApp-mRounds[4508:1327809] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `ActionsLogHistory` error: WebSocketClient connection aborted
2024-09-16 18:29:16.698248+0530 INVFormsApp-mRounds[4508:1327810] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.6976262024-09-16 18:29:16.698361+0530 INVFormsApp-mRounds[4508:1327811] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.698368+0530 INVFormsApp-mRounds[4508:1327715] [APIRetryableGraphQLSubscriptionOperation<MutationSync<AnyModel>>] Failed with subscription request: APIError: WebSocketClient connection aborted
Recovery suggestion: WebSocketClient connection aborted
Caused by:
Error Domain=NSURLErrorDomain Code=-1005 "(null)"
2024-09-16 18:29:16.698294+0530 INVFormsApp-mRounds[4508:1327810] [DataStoreIncomingAsyncSubscriptionEventPublisher] [InitializeSubscription.1] API.subscribe failed for `IssuesList` error: WebSocketClient connection aborted

2024-09-16 18:33:42.039403+0530 INVFormsApp-mRounds[4508:1329741] [WebSocketClient] [WebSocketClient] Websocket connected
2024-09-16 18:33:42.040074+0530 INVFormsApp-mRounds[4508:1329741] [APIAppSyncRealTimeClient] [AppSyncRealTimeClient] Received websocket event connected
2024-09-16 18:33:42.040334+0530 INVFormsApp-mRounds[4508:1329741] [APIAppSyncRealTimeClient] [AppSyncRealTimeClient] WebSocket connected

```
Is this a regression?
Yes
Regression additional context
No response
Platforms
iOS
OS Version
iOS 16.7.10
Device
iPhone X
Specific to simulators
No response
Additional context
No response

Thanks for your report, @Innovation2012. Someone from the team will take a look at this as soon as they can. Until then, can you provide the code snippet for initializing the DataStore?

Hi @vincetran
Thanks for replying and here is the sample DataStore initialing code below:
            let amplifyModels = AmplifyModels()
            let dataStorePlugin = self.prepareAmplifyAWSDatastore(models: amplifyModels)
            awsdataStorePlugin = dataStorePlugin
            let apiStorePlugin = self.prepareAmplifyAPI(models: amplifyModels)
            let authPlugin = self.prepareAWSCognitoAuth()
            self.awsAPIStorePlugin = apiStorePlugin
            try Amplify.add(plugin: apiStorePlugin)
            try Amplify.add(plugin: dataStorePlugin)
            try Amplify.add(plugin: authPlugin)
            try Amplify.add(plugin: AWSS3StoragePlugin())
            let amplifyConfiguration = try AmplifyConfiguration(configurationFile: fileURL)
            try Amplify.configure(amplifyConfiguration)
            Amplify.Logging.logLevel = .verbose
            self.intiateDataSync(completion: completion)

func intiateDataSync(completion: CloudCompletion? = nil) {
        Task {
            do {
                try await Amplify.DataStore.start()
                completion?(.success(()))
            } catch {
                completion?(.failure(error.prepareNSError()))
            }
        }
    }

@Innovation2012 Thanks for provide the sample code.  We'll work on reproducing the issue.


Update Simdem compatible documentation. We can now automatically stand up and tear down clusters - got to document the use of SimDem though!

Re the load testing... I'm working on that too, what you have written so far makes it really easy.


[Python] Update the static bindings, part 2.

There was a file left behind. Apparently also
BreakpointCreateByLocation was missing. Hopefully
placates the bots once and for all.
rdar://problem/44875808

@swift-ci test and merge


.github: add actions to build for multiple arch

To work this PR will require that the following secrets are configured:
DOCKERHUB_USERNAME
DOCKERHUB_TOKEN

@aabadie

@aabadie

Addressed comments and added armv7

It worked ! https://hub.docker.com/repository/docker/aabadie/ota-server/tags?page=1&ordering=last_updated
That's awesome. Thanks @fjmolinas !


Comma First adds unwanted new lines to arrays

Description
when "comma_first" is set to true, new lines are added between elements each time script is run.
this problem occurs only in arrays, objects look fine.
also, if "max_preserve_newlines" is set to 0, this wont happen. but new lines intentionally added are stripped.
Input
The code looked like this before beautification:
a = [
  1,
  2,
  3,
  4,
  5,
 ];

b = {
a: 1,
b: 2
}

Current Output
The code actually looked like this after beautification:
(problem shows itself after second run)
a = [
  1

	, 2

	, 3

	, 4

	, 5
 ];
b = {
	a: 1
	, b: 2
}

Expected Output
The code should have looked like this after beautification:
a = [
    1
    , 2
    , 3
    , 4
    , 5
];

b = {
    a: 1
    , b: 2
}

Environment
Browser User Agent:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Safari/537.36
Language Selected:
Beautify JavaScript
Settings
{
  "indent_size": "4",
  "indent_char": " ",
  "max_preserve_newlines": "1",
  "preserve_newlines": true,
  "keep_array_indentation": true,
  "break_chained_methods": false,
  "indent_scripts": "normal",
  "brace_style": "collapse",
  "space_before_conditional": true,
  "unescape_strings": false,
  "jslint_happy": false,
  "end_with_newline": false,
  "wrap_line_length": "0",
  "indent_inner_html": false,
  "comma_first": true,
  "e4x": true,
  "indent_empty_lines": true,
  "space-in-paren": 1,
  "indent-with-tabs": true
}

thanks, edited the original post

Expected output should be:
a = [ 1 , 2 , 3 , 4 , 5 ];
b = { a: 1 , b: 2 }

Beautifying multiple times results in additional empty lines:
a = [
	1

	, 2

	, 3

	, 4

	, 5

, ];
b = {
	a: 1
	, b: 2
}

@n-can-k
I see you have:
  "keep_array_indentation": true,

If you set that to false, you will get:
a = [
  1
  , 2
  , 3
  , 4
  , 5
 , ];
b = {
	a: 1
	, b: 2
}

Still not quite  what you want, but closer. It also does not indent with tabs in this case. The comma first formatting definitely needs work.

@bitwiseman i'll try to spare some time to see if I can work on it

Hey do you continue to get the same result even after doing:
  "keep_array_indentation": false,
if not please let me know, I can look into it.


Discontinuities in light curve at high f values

When generating transit light curves for planets with extreme flattening values (f roughly >0.6), unexpected and isolated spikes occasionally appear in the output:
import jax
jax.config.update("jax_enable_x64", True)
import jax.numpy as jnp
from squishyplanet import OblateSystem
import matplotlib.pyplot as plt

state = {
    "t_peri" : 0.0,
    "times" : jnp.linspace(0.0, 5, 2000), # units of days
    "a" : 2.0, # units of R_star
    "period" : 10, # units of days
    "projected_effective_r" : 0.1, # units of Rp/Rs
    "ld_u_coeffs":jnp.array([0.3, 0.1]), # u coefficients for a polynomial (here,
    # quadratic u1 and u2) limb darkening law
    "tidally_locked":False,
    "parameterize_with_projected_ellipse":True
}
planet = OblateSystem(**state)

spherical_lc = planet.lightcurve()
oblate_lc = planet.lightcurve({"projected_f" : 0.6})

fig, ax = plt.subplots(nrows=2, sharex=True, figsize=(8, 6))
ax[0].plot(planet.state["times"], spherical_lc, lw=2, label="spherical")
ax[0].plot(planet.state["times"], oblate_lc, lw=1, linestyle="--", label="oblate")
ax[0].set(ylabel="relative flux")
ax[0].legend()
ax[1].plot(planet.state["times"], (spherical_lc - oblate_lc)*1e6)
ax[1].set(xlabel="time [days]", ylabel="difference [ppm]")
fig.subplots_adjust(hspace=0);

These values are likely nonphysical (see Berardo and de Wit 2022), but could still cause problems for users who allow exploration of a wide parameter space.
Many thanks to @CalebLammers for pointing this out! Will try to hunt down the cause, but contributions are welcome.

When working on #17, found some similar spikes and so implemented a fix there. The issue was cartesian_intersection_to_parametric_angle in squishyplanet.engine.parametric_ellipse. Previously, we were solving for this angle numerically, and at high $f$ values it sometimes did not converge. When revisiting it, realized there was actually a pretty simple analytic solution, so implemented that instead.
So, should be all set now! I've modified test_projected_parameterization to test $f$ values up to 0.99, and to look for single isolated spikes. The same code above now produces:

And changing projected_f to 0.99 now produces:


How could I change the title of VLC ?

I used VLC client for playing livestream.com live stream.
How do I change the title to a more meaning text, say the name of a live stream

More informations are available here: #807 #194

Edit config file [[VLCRC] (http://www.videolan.org/support/faq.html)] to change the title.
VLCRC file:
# Change title according to current media
input-title-format=TITLE

You can try : livestreamer -p "vlc --input-title-format Your_title_here" streamurl

Confirmed. Works as expected.
livestreamer "http://livestream.com/[...]" best -p "C:\Program Files\Video\VLC\vlc.exe --input-title-format TITLE"


Automatically Execute koverMergedReport when running tests

What is your use-case and why do you need this feature?
I would like to be able to execute my tests using the standard test command (or specific module's test command e.g. :module:test) and have Kover automatically instrument the tests & generate the reports that are configured.
Most devs are familiar with more common gradle tasks, but not necessarily specific tasks provided by libraries. By automatically running a merged report when multiple test modules are run or a single report if only a single module's tests were run this would simplify many dev's workflows and allow things to work "automagically"
Describe the solution you'd like
Happy to discuss various options on how this might work, but ideally it would run a merged report whenever multiple tests are run if the koverMerged { enabled() } is in the root gradle config. If that is not set then each project's single report would be executed.

Hi,
Since Gradle does not involve changing the behavior of the task when performing an independent task, it was incorrect to generate a merged report for those tasks that were started - in this case, the build cache becomes unstable.
Unfortunately, specified approach is poorly implemented in Gradle and in any case, additional configuration will be needed - either through the transfer of special parameters, or through the creation of custom tasks.

@shanshin Just to make sure I understand the issue you're describing here:

Since Gradle does not involve changing the behavior of the task when performing an independent task, it was incorrect to generate a merged report for those tasks that were started - in this case, the build cache becomes unstable.

The issue is that in the situation where a merged report is requested, but not all module's tests have been run then the merged report task won't know what data to include and what to exclude, correct? This is why we'd need to transfer some sort of parameters between the tasks to modify its behavior?
I'm trying to compare to how the JaCoCo gradle plugin worked where you could attach it to a test task to always generate the report when running test (or another testing command). Whereas for Kover it appears I must run the Kover specific task to generate coverage metrics. So it may just be me not understanding how these two plugins work "under the hood."


react-virtualized-select gitter 404s / no longer active

Hi @bvaughn, the react-virtualized-select gitter link in the CONTRIBUTING.md 404s. Perhaps the file should point to the react-virtualized Slack channel?

This channel never had a Gitter. I probably just accidentally copied that file when setting up the repo. To be honest, I don't think this project requires a support channel. It's tiny. Questions should almost always be directed to react-select or sometimes react-virtualized. 😄 Sorry for the confusion!

Removed reference to Gitter in fbdb83f

Ok cool, agreed.


Licence?

Hi @mhusinsky thanks for adapting this for vl.
I notice there's no licence yet, do you plan to add one?
The original library is MIT, if you want to open source would you consider using that for simplicity?
https://github.com/dotnet/MQTTnet
That's what I usually do when I make VL wrapper libraries.

hey @TobyKLight ,
yes, you are totally right - the lack of a license isn't intended and MIT would fit well.
in general the VL wrapper could be updated to a more recent version of its base library. however, i don't have a lot of ressources at the moment but it is planned for the future.

repo is now under MIT license


[WIP] Report editor - handle tags on entitites

Right now, creating a new report (based on EVM Groups, among others), each tag is available in multiple variants .. say "My Company Tags : Demo" (managed-demo), "VMs.My Company Tags : Demo" (vms.managed-demo) and "Miq Templates.My Company Tags : Demo" (miq_templates.managed-demo). But upon saving, all these variants are changed to the basic variety (managed-demo), losing the entity info.
This PR aims to fix that.
https://bugzilla.redhat.com/show_bug.cgi?id=1193652

@miq-bot add_label WIP

@miq-bot add_label wip

@dclarizio , @h-kataria this is bz1193652 we talked about on trello call..

@miq-bot remove_label wip

Tested in UI, looks good, it shows correct tags in the report editor.


chore(release): Spin v2.2 version bumps

Oops, seeing the following from the Lint Rust job:
...
M	tests/test-components/components/Cargo.lock
Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes

Alas, make update-cargo-locks currently only appears to update files under examples... Do we need to add tests as well?

@vdice Huh. We never used to have to do tests but I guess something changed...

I pushed a commit manually running cargo update -w --offline in tests/test-components/components: https://github.com/fermyon/spin/pull/2260/commits/8f9f5af19e43920585e126934895d4850fb7051a.  We'll see if that suffices for our needs here.


Testing problems

When I use the testing code, I found that you resize the input image and gt in your class DUTS_dataset in Dataset.py as following
self.transform = transforms.Compose(
[RandomFlip(0.5),
RandomCrop(224),
ToTensor()])
Could you check whether this is an error  in your testing code?

I thought that same condition on test and training set is fair, but I think that could be an error if you think that resizing is correct for testing. I'll add an testing transform option. Thanks.


Fix typo on renderOfScreen

Hey @jorge-graca-sky, I noticed that the PR has already been merged before my comment. But there was a typo in the item that should have been fixed as renderOffscreen, not renderOffScreen. Since I can't re-open the PR, could you please open another PR with the corrected fix?

https://github.com/jorge-graca-sky/Lightning/pull/1

Hey @jorge-graca-sky, I noticed that the PR has already been merged before my comment. But there was a typo in the item that should have been fixed as renderOffscreen, not renderOffScreen. Since I can't re-open the PR, could you please open another PR with the corrected fix?

https://github.com/rdkcentral/Lightning/pull/500


Fix Notification to set timer on creation

Close aicers/aice-web#787

I don't think we can put a private link in a public repo. Could you check please?


cli output that fits on mobile

needs fixed-width for those pretty tqdms
probably the work will be in evaluators.base.Evaluator

solved in #223


Missing documentation for v2.ODataModel

The v2.ODataModel misses the following documentation of 'standard features':

callFunction: documentation of mParameters.headers is missing
create: documentation of mParameters.eTag is missing
createEntry: documentation of mParameters.eTag is missing
remove: documentation of mParameters.headers is missing

The functionality behind this is already implemented, yet, it's not part of the official API.
This PR adds these parts to the official API.

Hi @mlenkeit ,
thanks for the contribution, but there is already a bigger change pending (internally) which addresses the same.
BR, Frank

@codeworrior Thanks for the super-quick update. Fine with me, as long as it makes it into the v2.ODataModel. 👍

Maybe I was too fast with closing this PR, I thought I had added all of them, but maybe I mixed this with other methods. I'll double check and add the lines if missing and ensure they are documented.
Thanks again for the contribution.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I talked to an OData v2 colleague. According to him, ETag is not supported for create and createEntry. Tag must always be provided by the server. So the code is wrong, not the documentation :-(
But I'll add the two missing documentation lines for "header", they're not part of the pending change.

Well, assuming that you use the create method for actually creating something. We, for example, use the create method with an upsert semantic (e.g. create if not existent, update otherwise), so we need to be able to pass an ETag. But as long as the headers parameter is documented, we can still manually pass the ETag with the If-Match header.

Closing this PR as its goal has been achieved, partially by a more general JSDoc correction (56855b7b5755db856720e89f51faeee558e82f53), partially due to new insights (see https://github.com/SAP/openui5/pull/1188#issuecomment-255380319 and https://github.com/SAP/openui5/pull/1188#issuecomment-255385099 above)


test_runner: make proxy mgmt port mandatory

Make mgmt port mandatory argument for NeonProxy (and set it for static_proxy) to avoid port collision when tests run in parallel.

Not all of them, but these 2 failures were definitely caused by using 7000 in parallel running tests:

test_password_hack: https://neon-github-public-dev.s3.amazonaws.com/reports/main/release/3480613958/index.html#/testresult/91b6fb0597d37c49
test_proxy_options: https://neon-github-public-dev.s3.amazonaws.com/reports/main/release/3480613958/index.html#/testresult/a56cd520fd70ad42

The error is a bit misleading at first glance (at least for me), it mentions a port from the port distributor and has Error: Address already in use (os error 98) in stderr logs, but these are messages about 2 different ports:

Error: Address already in use (os error 98) is about 7000, it doesn't allow the proxy to start
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=17092) about 17092, because nothing is listening on this port

Probably we should tune _wait_until_ready error message.


correct path to builds

Builds paths changed to end with /container - made those changed to helm build so it will work

:tada: This PR is included in version 0.11.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


✨ added AnimatedLogoCloud

Just curious, is there a reason that you named this Logo Cloud instead of Marquee Slider?


boto3 error

Note: The verbiage expressed here are that of the author and are not representative of State Farm.
Describe the bug
When attempting to import thethingstore there's an import error during the package spinup; it's attempting to import boto3, which does not appear to be in the package requirements.
To Reproduce
Steps to reproduce the behavior:
import thethingstore
Expected behavior
No explosions.

The offending and smelly code resides in src/thingstore/api/data_hash.py; this imports boto3 to reuse the client in typing.


UI issue in downloadable product, download information section.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
MASTER
Issue Description
After creating the downloadable product, there when we add the downloadable product information, there we can see the UI issue appearing.
The information box should be in same line and the add option other information should come below the box.
Preconditions

Admin end should work properly.
Need to create a downloadable product.

Steps to reproduce

Go to Admin -> catalog -> Products -> Create a downloadable product.
Click on Downloadable Information.
There we can see the UI issue.

Expected Result
The Content box should appear in the same line and the add details should appear below the box.
Actual Result
Please check the screenshot for a better understanding of the issue.
Screenshots
https://prnt.sc/j4g2B0yWTde6
Additional context
No response

explained here - https://github.com/bagisto/bagisto/issues/7136#issuecomment-1328025349


Use arrows to move along the value in input field

When I try to edit a value and move inside the input the arrows aren't working.

uh, I think this is a regression from when I added support for pasting! I'll get a fix out soon!


feat(linter): eslint/no-invalid-regexp

Implement ESLint's no-invalid-regexp rule.
To get started, run
just new-rule no-invalid-regexp

Hi. To implement this rule, it seems necessary to implement a parser like @eslint-community/regexpp.
Where is this planned to be implemented?
If it's within this repository, please let me know where in the repository it should be implemented.

Hi. To implement this rule, it seems necessary to implement a parser like @eslint-community/regexpp.
Where is this planned to be implemented? If it's within this repository, please let me know where in the repository it should be implemented.

We don't have a regex parser yet but it's open for contributions by veterans like you! If you are interested in learning Rust by implementing a regex parser, please reach out and I'll guide you. To get you started, we have a small tutorial here where some of the chapters are already translated into Japanese :grin: https://boshen.github.io/javascript-parser-in-rust/ja/

Oh, thank you for the detailed information.
I've also been busy with other things in the past few days, so it might take some time, but I'm thinking of trying to implement a prototype of the Rust rewrite of @eslint-community/regexpp in my repository.
I might propose integrating it somewhere at some point.

To get started, we have a small tutorial here where some of the chapters are already translated into Japanese 😁 https://oxc-project.github.io/javascript-parser-in-rust/ja/

The Japanese version is great! As a native speaker, I might be able to contribute to the translation into Japanese.

Oops, I forgot to mention one thing.
I will try to implement the prototype, but if anyone reading this comment wants to work on this issue,
please don't hesitate to start. If your progress is faster, I will discard my project.
(Just because you've read this comment doesn't mean you need to stop your work.)

Oops, I forgot to mention one thing. I will try to implement the prototype, but if anyone reading this comment wants to work on this issue, please don't hesitate to start. If your progress is faster, I will discard my project. (Just because you've read this comment doesn't mean you need to stop your work.)

No no, we can merge small pieces and collectively iterate on it so no effort is lost. Just send in small PRs. You may wish to try https://graphite.dev for such tasks.

Thank you.
Once I can see a roadmap of the smaller tasks I've broken down, I'll share it again!

You may wish to try https://graphite.dev/ for such tasks.

Oh, there's a tool like this? Thanks for introducing it to me. I didn't know about it, so I'll take a closer look!

Hi, I tried coding a prototype regex parser some time ago in my fork.  It can (afaik correctly) parse all regexes I found in the MDN docs. The main issues are imo the lack of a lexer (which would help with some backslash edge cases and string-vs-literal normalization) and messy output when dealing with unicode.
I temporarily gave up on it due to encountering too many small tedious issues (escaping, spans, output, ...) and then later also starting projects for school. I'd like to continue working on it in around two weeks, once I'll hopefully finish the schoolwork.
Feel free to either pick it up in the meantime or take inspiration for your version. I can clean it up tomorrow and possibly PR it in here.

I see. I didn't know that.
In that case, I'll refrain from implementing the prototype.
Let's prioritize and respect your achievements.
I have a suggestion: since you've made so much progress, why not create a feature branch in this repository for the regex-parser so everyone can collaborate there? And for issues related to this parser, it might be a good idea to leave documentation and address remaining concerns as separate issues. What do you think?
(I haven't looked closely at the Maneren branch, so I'm not sure if it can be integrated into oxc.)
In any case, it might be better not to have too many significant changes in the forked repository and merge them into the feature branch of this repository while sharing issues with everyone.
cc @Boshen

At the very least, since this issue originally pertained to eslint/no-invalid-regexp, I've created a separate issue for the regular expression parser.
I would like to conduct discussions related to the parser here. What do you think?
https://github.com/web-infra-dev/oxc/issues/1164

@nabby27 created a $50.00 reward using Opire
How to earn this reward?
Since this project does not have Opire bot installed yet 😞 you need to go to Opire and claim the rewards through your programmer's dashboard once you have your PR ready 💪

I created this reward to encourage this issue to be resolved as it hasn't received updates in a long time.

I created this reward to encourage this issue to be resolved as it hasn't received updates in a long time.

Is the reward deleted?
Anyway, all work from @leaysgur should be sponsored, I'll sponsor @leaysgur if you turn on github sponsorship 😁
Closed by #5443

Is the reward deleted?

No. You can see it at this link. It's still open because no one has claimed it.
You can still add money to the reward and when @leaysgur claims it we will pay him 😁

Thank you both!
I never thought the day would come when I could earn money from OSS. 🥳
Once this busy weekend is over, I’ll try applying for them.

Paid ✌ Thank you for your contribution! I hope you can enjoy more Opire bounties and earn money by helping the OSS 🤗

Also confirmed. Thank you so much~! 🙌🏻


add converting,initializer list constructors

Change-Id: Iaa03e4448111b44cfc360fe8ed04aacbc745df97

Codecov Report
Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.00%. Comparing base (b7ad75c) to head (cfdf282).

Files with missing lines
Patch %
Lines

...geometric_algebra/detail/size_checked_subrange.hpp
60.00%
2 Missing :warning:

Additional details and impacted files
@@                              Coverage Diff                              @@
##           Iac7a864f864e2ae4cb170fcdc4ca0c7933ca6aff      #41      +/-   ##
=============================================================================
+ Coverage                                      62.38%   64.00%   +1.61%
=============================================================================
  Files                                             18       19       +1
  Lines                                            210      225      +15
  Branches                                           4        5       +1
=============================================================================
+ Hits                                             131      144      +13
- Misses                                            79       81       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added 'pull_file' to the channel interface and to the local channel i…

…mplementation

This is needed if we ever want to get back those stdout/stderr files using channels.


Run.Bat won't execute

Hi... I have downloaded the latest version (2.3.4), extracted to my Desktop, and have selected to run the run.bat file as Administrator, however, it will not run.  The path for the python.exe cannot be located.  See screenshot.  If I "Press any key to continue", the run.bat window only closes.

I previously had the program installed and it worked perfectly, but I had to restore my system to a prior date and, as a result, need to re-install now.
Desktop (please complete the following information):

OS: Windows 11
MOD Version [e.g. 22]: Not sure what this is
MSFS Version, MS Store or Stream:  MSFS 2020 Basic Version from MS Store

Thank you very much for your time and guidance.

Install Python and fix your execution argument path in RUN.BAT. From your screenshot, you're trying to change to a directory on the desktop called "Python39" and then you're trying to run the script (which won't work because it doesn't exist).

Yeah this is annoying. Editing the batch file to properly point to my python directory seems to have fixed it. In my case:
C:\Users\final\anaconda3\python.exe src\app.py


Java integration tests

Use docker-compose junit rule, https://github.com/palantir/docker-compose-rule
Use system-rules to capture stdout, etc, http://stefanbirkner.github.io/system-rules/index.html
See example https://github.com/NLeSC/xenon-cli/blob/master/src/test/java/nl/esciencecenter/xenon/cli/SlurmTest.java
Also mocked web services using http://wiremock.org/docs/junit-rule/
See example https://github.com/3D-e-Chem/knime-kripodb/blob/master/tests/src/java/nl/esciencecenter/e3dchem/kripodb/ws/JavaWsWorkflowTest.java

The Java chapter has been removed because it was too outdated.

Note that we have a running KD project that may add it again, but in updated form. Looking forward to the PR @lyashevska, @bakhshir, @jmaassen, @nielsdrost, et al.(?) 😄


Custom list besides favorites

Description
A list where you can filter out certain roles from the list.
And where you can sort on accounts something like staging or production. (contains "staging")
Option to color account names beside role names

Filtering out roles seems really useful - I'm thinking a "hide this profile" button.
For filtering on accounts... what would you want this to look like? You can use the search box to filter on account id & account name, do you want to be able to save your "filtered search results"?
I'm planning to add more customizations for accounts/apps in general - the same way you can rename, color, & favorite profiles; I'd like to get the same going for accounts.

Hide profile button sounds good.
About filtering, yes either save the search results or adding accounts and or roles to a custom list. (like add to list or create new list.)

@Svdm98 in edit mode, there's a hide profile button now.


update appliance connection

as per https://github.com/MicrosoftDocs/azure-docs/issues/54200

updated to the article: migrations over ER public peering are supported, however public peering is depreciated
why: our customer confused public with private peering. updated the article to reflect that public peering is depreciated
updated to the article: migrations over ER private peering is not supported

@kiwibayer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The issue that's addressed in the PR appears to be addressed in master. We'll close the PR. If there are outstanding issues or questions, the PR can be reopened.


Add link to live website at top of Github page

Next to the git repo description there is a box for a webpage link. Add https://index.ros.org/doc/ros2/
Currently this is not well documented on the README

Good point - done.


Lowering ONNXCustomOp

ONNXCustomOp is lowered to krnl.Call when onnx is converted to krnl.
In the conversion:

Allocate MemRef for the output, using the shape inference of the custom op.
Both outputs and inputs of ONNXCustomOp will become the parameters of krnl.call
Attributes: pass the function_name of custom Op to the functionName of krnl.call. Filter out the attributes for shape inference. Propagate other attributes.

Jenkins Linux amd64 Build #11881 [push] Lowering ONNXCustomOp (#... started at 08:36

Jenkins Linux ppc64le Build #10889 [push] Lowering ONNXCustomOp (#... started at 09:42

Jenkins Linux s390x Build #11894 [push] Lowering ONNXCustomOp (#... passed after 1 hr 34 min

Jenkins Linux ppc64le Build #10889 [push] Lowering ONNXCustomOp (#... passed after 1 hr 55 min


envoy_on_request(request_handle)..."]:9: bad argument #2 to 'httpCall' (table expected, got string)

Bug Description
I'm trying to make simple API call to another service in same cluster in istio mesh environment.

2023-02-02T06:43:08.708795Z error envoy lua script log: [string "function envoy_on_request(request_handle)..."]:9: bad argument #2 to 'httpCall' (table expected, got string)
Thu, Feb 2 2023 2:43:08 pm | 2023-02-02T06:43:08.710302Z warning envoy lua script log: envoy_on_response

    typed_config:
      "@type": "type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua"
      inlineCode: |
       function envoy_on_request(request_handle)
         -- Make an HTTP call to an upstream host with the following headers, body, and timeout.
         request_handle:headers():add("nxl-authorization", "Bearer kava")

          local headers, body = request_handle:httpCall(
          "lua_cluster",
          {
            [":method"] = "POST",
            [":path"] = "/",
            [":authority"] = "nxlpep.nextlabs-cloudaz-control-center.svc.cluster.local"
          },
          "hello world",
          5000)

          if headers[":status"] ~= "200" then
            request_handle:logErr("Auth failed: status=" .. headers[":status"] )
            -- request_handle:respond({[":status"] = headers[":status"]}, response_body  )
            return
          end
       end

Version
**ISTIO**
client version: 1.13.1
control plane version: 1.11.4
data plane version: 1.11.4 (15 proxies)

----------------- KUBECTL -------------
Client Version: v1.23.0
Server Version: v1.20.15-eks-fb459a0

Additional Information
No response

Argument 2 is already in table format, not sure why it is keep complaining
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
name: reporter-lua
namespace: abccompany-center
spec:
workloadSelector:
labels:
app.kubernetes.io/name: abccompany-center-reporter
configPatches:
# The first patch adds the lua filter to the listener/http connection manager

applyTo: HTTP_FILTER
match:
context: SIDECAR_INBOUND
listener:
portNumber: 80
filterChain:
filter:
name: "envoy.filters.network.http_connection_manager"
subFilter:
name: "envoy.filters.http.router"
patch:
operation: INSERT_BEFORE
value:
name: envoy.lua
typed_config:
"@type": "type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua"
inlineCode: |
function envoy_on_request(request_handle)
-- Make an HTTP call to an upstream host with the following headers, body, and timeout.
request_handle:headers():add("nxl-authorization", "Bearer kava")
      local headers, body = request_handle:httpCall(
      "lua_cluster",
      {
        [":method"] = "POST",
        [":path"] = "/",
        [":authority"] = "nxlpep.abccompany-cloudaz-control-center.svc.cluster.local"
      },
      "hello world",
      5000)

      if headers[":status"] ~= "200" then
        request_handle:logErr("Auth failed: status=" .. headers[":status"] )
        -- request_handle:respond({[":status"] = headers[":status"]}, response_body  )
        return
      end
   end

The second patch adds the cluster that is referenced by the lua code
cds match is omitted as a new cluster is being added

applyTo: CLUSTER
match:
context: SIDECAR_OUTBOUND
patch:
operation: ADD
value: # cluster specification
name: "lua_cluster"
type: STRICT_DNS
connect_timeout: 2s
lb_policy: ROUND_ROBIN
load_assignment:
cluster_name: lua_cluster
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
protocol: TCP
address: "nxlpep.abccompany-center.svc.cluster.local"
port_value: 80

This EnvoyFilter configuration is not a problem, it is possible that your new configuration did not take effect.
You can use "curl localhost:15000/config_dump" to see the actual configuration


[SteamCMD] Had to resume downloads because error 0x402

@MalakiLab Reported the following issue/suggestion. https://github.com/dgibbs64/linuxgameservers/issues/157#issuecomment-66148895
Oh and i had to resume the download quite a lot of times, but as i seen, it is a SteamCMD bug. It would be nice if the script could recognize the state 0x402 and try resuming by itself a few times, also detect if is a Success or not. A way i see you could do it is by piping the the SteamCMD stdout into a tmp file and reading the status there.

This feature is not available


draft: clothing and gun

meow meow meow

About the PR
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added fun!
remove: Removed fun!

You should convert this to a draft PR if it's a draft.
Some description of what the goal of both the clothing and gun are would be helpful.

You should convert this to a draft PR if it's a draft.
Some description of what the goal of both the clothing and gun are would be helpful.

this is the pr for civillian clothes

With a gun?

With a gun?

i was just gonna upload them together but now thinking about it. it is best to upload both of them separately.


FEATURE Allow comments in mocha.opt file.

This should enable switching an option off/on with ease by
commenting/uncommenting the option. A sample use case is the need
to enable the --debug-brk option  during debugging but disabling
it otherwise.

@igwejk I don't understand why this is necessary.  If you just need to add --debug-brk, execute:
$ mocha --debug-brk

and it will be merged w/ the rest of your flags defined in mocha.opts.
Can you please explain?

Hi Christopher, that example was just a single use case which is also the simplest.
More generally I could have multiple flags, some of which are useful at one instance but not at a different instance. When I don't find a flag useful (but I expect it to fill my need at some other point in time) I would like to comment it out instead of deleting it completely.
Also, consider that the suggested feature can serve as enabling a means for easily documenting used options.

From: Christopher<EMAIL_ADDRESS>Sent: 24/11/2016 09:28
To<EMAIL_ADDRESS>Cc: Igwe<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [mochajs/mocha] FEATURE Allow comments in mocha.opt file. (#2587)
@igwejkhttps://github.com/igwejk I don't understand why this is necessary. If you just need to add --debug-brk, execute:
$ mocha --debug-brk
and it will be merged w/ the rest of your flags defined in mocha.opts.
Can you please explain?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mochajs/mocha/pull/2587#issuecomment-262717318, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADzYQxYiDxGdAy0Z741NYWpV0uW2JAVsks5rBUqxgaJpZM4K435H.

Here's another use case which I'd unfortunately like to use right now:
--compilers js:babel-register,jsx:babel-register
--check-leaks
# Add `addresses` here for now because https://github.com/webpack/webpack/issues/3173
--globals window,navigator,localStorage,document,addresses

@igwejk any particular reason you closed this? I'd personally still love to see this behaviour, for the same reason @jwalton mentioned.

Nice to know there are others who want this. I'll reopen it by the end of the day. Thanks.
/c @ELLIOTTCABLE , @jwalton

This PR has been reopened via #2870 2870


EAGLE-473: Query error if query string contains "[]"

https://issues.apache.org/jira/browse/EAGLE-473
Fix the bug with an unit test

LGTM.


viz: Disable profiling support for now

Dagger's profiling support is currently poorly tested because Julia's profiler doesn't have an interface that best supports how we want to use the profiler. It also has very high overhead and will either over- or under-report profile stacks for Dagger tasks. I would recommend disabling it or making it opt-in for now.

Thanks for the catch! I haven't worked out how I want to allow customization of the vizualization yet, so I'll just take it out for now.


[Feature request] Add "Minify" and "Clear" buttons

What is the actual behavior?
Currently, GraphQL Playground has only "Prettify" button:

What is the expected behavior?
GraphQL Playground should also has "Minify" and "Clear" buttons:

Clear functionality could be done by graphql-prettier as it's proposed https://github.com/prisma/graphql-playground/issues/999 .

Clear functionality could be done by graphql-prettier as it's proposed here https://github.com/prisma/graphql-playground/issues/999 .


Remove FsTokenPersistence

Closes #5665

Warnings

:warning:
This PR modified the server but none of its tests. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 1131fc34bd2aa8b70780e720b2bdc2e2c2cedbbd


Allow hyperapp compatibility via config file

Summary
Right now I can't find a way to integrate svgr with my workflow (parcel2 building a hyperapp-based website), as there are a couple of missing things:

no way to specify a custom JSX import config via a config file
no way to use the custom JSX import config to specify that we want to use the default import

Test plan
$ cat ~/Projects/KaraKara/browser2/package.json | jq .svgr
{
  "jsxRuntimeImport": {
    "source": "hyperapp-jsx-pragma",
    "defaultSpecifier": "h"
  },
  "icon": true,
  "replace-attr-values": "#4d4d4d=currentColor"
}

$ npx svgr ~/Projects/KaraKara/browser2/src/static/favicon.svg | head -n 5
import h from "hyperapp-jsx-pragma";
const SvgFavicon = (props) => (
...

Done~ (And fixed another couple of tables in the doc while I was there)

Pushed again to "fix" formatting to make the CI tests happy. Apparently prettier doesn't like the tables being formatted correctly, so I reverted that part...

And now with unit tests passing - I think this is ready to merge now?

(Should I be doing anything here? It says "changes approved" but I don't see any merge button or anything...)


Update Shopify Readme

Update Shopify readme to add the receipts sending functionality.

Add development documentation

Update readme with the new structure defined in #70


LoZ Install GRPC

Description

As it is shown in the  fabric/images/base/scripts/common/setup.sh file, when we run it in LoZ ,there is a tip that protobufs wont compile on 390, missing atomic call .Is that mean we can not use it in LoZ ?
Describe How to Reproduce

@xbh2015 @vpaprots is this still an issue for s390x? My understanding is that you have resolved the issue with #2228. I'm going to close this (since it won't be closed automatically) Please reopen if you disagree.


Harder Boards?

How well does this work with harder boards? E.g. wiegleb or diamond41?
I'd love to see unit tests for those :)

I have been refactoring this library to clean it up and make it more useful. I will add unit tests for those boards. Thanks for the idea!

I'm mainly curious because I've written a solver that finds all solutions for arbitrary boards and I'd really like to know how times compare.
Let me know what your findings are!
Regarding optimization: I would recommend using bits to represent and bit operations to modify boards.

So, I tried it. It solved Wiegleb in 190-220 milliseconds. It could not solve Diamond41. I let it run for a minute. Could not find a solution in that time.

You are aware that central hole is not solvable on diamond41 though?

No, I did not check :-(

OK, corrected the position of the initial open hole. It now solves Diamond 41 board in about 400 milliseconds. Thanks!

Wow, that is pretty amazing! Nicely done. I'll see if I can find a few more harder boards. But diamond41 without a resource function is among the hardest I currently have available.

Thank you. What's resource function?


gitignore: add builddir

builddir should be ignored and the old gitignore from ratbagd can be deleted.

Duplicate of #672
TLDR: That should be in your personal .gitignore

Ah, sorry. Missed you removing the old .gitignore, can you leave just that?

Duplicate of #672
TLDR: That should be in your personal .gitignore

Must be the wrong link, the 672 has nothing to do with a gitignore^^
But why should it be in the personal one? The readme explicitly recommends the build dir builddir, so everything in there should be ignored from git.

Yes, sorry. Should be #671.

Yes, sorry. Should be #671.

A thx. But then the complete gitignore should be removed, so you can simply add .gitignore to your gitignore without conflicts. Will update the PR.

No, you add it to ~/.gitignore :grin:.

Sorry, we should only remove ratbagd/.gitignore, not .gitignore.

Sorry, we should only remove ratbagd/.gitignore, not .gitignore.

No both, @bentiss and @whot even mentioned this in #671. Everything that will be changed will be contained in the your build directory, which you should add to your personal .gitignore.

Ah, sorry. My bad.


Adds safety invariants (MIRAI annotations)

Motivation
This PR adds invariants (in the form of MIRAI annotations) that must be maintained by the consensus code in order to guarantee the safety property (i.e no two conflicting blocks can be committed).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

:umbrella: The latest upstream changes (presumably 51a7181ac49798cfe9078b2c85f6d447e16fc06c) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r+

:pushpin: Commit 6cce691 has been approved by t-rasmud

:hourglass: Testing commit 6cce691780325bc3ed8bf4671fc898f2474c036b with merge 02161c8ceaee1f64e777d0adce4bfb5e98508475...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: t-rasmud
Pushing 02161c8ceaee1f64e777d0adce4bfb5e98508475 to master...


Infinite message confirmation with DeliveryTag=0

Here is the code I used.

` if err := pub.Confirm(false); err != nil {
utils.GetLogger().Warning("Publisher confirms not supported:%s", err)
close(confirm) // Confirms not supported, simulate by always nacking
} else {
pub.NotifyPublish(confirm)
}
for{
select {
case confirmed := <-confirm:
if !confirmed.Ack {
if confirmed.DeliveryTag > 0 {
utils.GetLogger().Warning("nack message %d, body: %q", confirmed.DeliveryTag, string(body.ToRawMessage()))
}
}
......
}//end select
}//end for `

If the connection is broken, for example, network is down, there will be infinite confirmation in the confirm channel with deliveryTag is 0. Why these confirmation are coming? Is work as designed? I'm NOT sure. So I raised this issue for discussion and ways to resolve this issue.

Publisher confirms cannot be coming if the network is down but there could be (a limited, and probably short) number of not-yet-processed basic.ack frames buffered in a client.

Right, I think the problem may not come from amqp client lib. I'll check other parts to identify the root cause. And about this issue, I'll close it!


Add multiprocessing for fit generator

Implement fit_generator with python multiprocessing (#2730).
Sorry for the spam, I closed my previous PR by accident...
Anyway, this implementation now passes all the checks on Travis, has improved documentation and unit tests.

Clarification for lazy-evaluated array:

From what I understand, non-picklable object can't be passed to children process easily. This includes lazy evaluated arrays
So for instance, if you define a generator this way:
arr_data = np.random.randint(0,256, (1000, 3, 224, 224))
arr_labels = np.random.randint(0, 2, 1000)
np.savez("data_dummy", **{"data": arr_data, "labels": arr_labels})

arr = np.load("data_dummy.npz") # arr is non picklable

def myGenerator():

    while True:
        X = arr["data"]
        y = arr["labels"]
        yield (X, y)`

Then arr won't be passed correctly to all the children processes and the code will throw an error (typically the generator will return None).
However, if you load arr in memory before defining the generator or if you define your generator as:
def myGenerator():

    while True:
        X = arr["data"]
        y = arr["labels"]
        yield (X, y)

you won't have this issue.

Catch-all: you're right, I don't need the catch-all, it was merely a convenience when debugging.

Overall I think this would break a lot of people's code. For instance it would immediately break the cifar10_cnn.py example we have in Keras. It may well break a large majority of all data generators that are currently in use.
I'll think about it some more.

Sure. In the meantime I could push an example of how to build a generator with multiprocessing (along the line of the gist I posted in the original issue) if you think that is relevant

I'd like something like this. It's not straightforward how to multi-thread fit_generator, evaluate_generator and test_generator from outside without introducing an additional queue.

I think we should consider making it possible to have both the threading and the processing implementation (essentially we just need to change the imports) and have an argument for switching from one to the other (such as pickle_safe, which would default to False for backwards compatibility). How this works should be clearly explained in the documentation.
That way we can benefit from this PR while avoiding breaking everyone's code.

I'm using Celery and it forks processes on workers (it's possible to control this behavior though). When the model are small enough it's possible to have multiple models running on the same GPU. It would maybe break if multiprocessing is enabled by default. +1 to have both threading and multithreading :+1:  .

Cool! I'm guessing it's pretty uncommon to train multiple models on the same GPU though (mostly due to VRAM issues)? Regardless, I would be pretty content with threads, so how about just reintroducing nb_worker with the generator queue?

I have added multiprocessing as an option with the keyword pickle_safe as mentioned above.
Note that I have reintroduced the deprecated flag when using nb_worker > 1 and pickle_safe = False.

Note that I have reintroduced the deprecated flag when using nb_worker > 1 and pickle_safe = False.

Sounds good, it's much better to have a unified API.
LGTM, merging. Thanks for the contribution!

@tdeboissiere thanks for your contribution. Shouldn't we make the pickle_safe limitation clearer in the fit_generator documentation ? I think the example you give above would help a lot. Maybe also warn people that external libraries used for pre-processing may use non-pickable objects.

As of today March 5, 2017, does the most recent keras include this maximized speed of fit_generator (ie. using multiprocessing)? My current version does not seem to have this, as my fit_generator() is still about 4x slower than fit().

Keras 1.2.2 does have this multiprocessing included, but my fit_generator() is still about 4x slower than fit(). Can this be further sped up?


add filtering of arguments

see https://github.com/graphql/composite-schemas-wg/discussions/129

This ties into this discussion: https://github.com/graphql/composite-schemas-wg/discussions/129
Pretending that @internal is a thing I think this should broadly allow you to hide fields or optional args from the client schema. So if there are any transforms library that want to understand or have support for that composition directive, they can use that to hide required args and provide the data somehow to subschemas at runtime too.
But what about a composition that hides a required arg from a subschema? Will this just error at at runtime or do allow this but flag it as a warning at composition time, or block composition?

@smyrick i would think the directive that drops an argument would only be allowed if the argument is optional or if it is paired with another directive that states where the source for the argument should come from (something external, see the discussion there).
And so there are two phases of validation, one that just checks the above, and then another phase of validation that makes sure that the ordering that the subschema ordering that ends up being required in order to fulfill all those arguments is actually possible, i.e. that all of the subschema fields are practically reachable/executable.

So then for the overview document this is actually a good change but we will need to clarify further in the other spec sections what "hiding and argument" entails. 👍🏻


 Changes added:

[x] Remove outputs
[x] Created a simple blog.json with titles document and Removed fetching blogs.zip file
[x] Update description and heading
[x] Update mappings and indexing

this is great thanks saarika!
one minor change: can we provide the output for "querying the dataset" please?

Question @joemcelroy  Would it be safe to delete 2023-07-27-blogs-no-embeddings.json.zip file ?

Question @joemcelroy Would it be safe to delete 2023-07-27-blogs-no-embeddings.json.zip file ?

yes delete please! thanks


[Suggestion] After tapping on on-screen notification it should redirect and open that notification relevance page directly

Dear eSteem team,
I would like to suggest an idea to improve push notification functionality, actually users see notifications on his/her mobile screen first then they tap on that to open that notification only. In current functionality, if a user taps on a reply activity from his/her on-screen notification then instead of opening the reply page the profile page of user goes open hence i would like to suggest that if user tap on a reply or any other notification from his mobile screen notification center then that notification should redirect properly and should open that page only for which notification was related.
First look below video for better understanding..
https://youtu.be/4jM2lJJd_co
Also, see the on-screen notifications:

Thanks
@face2face

I think this has already been reported by harry-height

https://github.com/esteemapp/esteem-mobile/issues/466

@feruzm fixed and distributed for initial testers

Could you please test and close if it okay.
Android Apk Download link: https://install.appcenter.ms/orgs/esteem.app/apps/esteem/distribution_groups/beta_testers
IOS Ipa Download link:
https://install.appcenter.ms/orgs/esteem.app/apps/esteem-1/distribution_groups/beta_testers
Thank you. @face2face-utopian


printf.h should also(only?) import printf_config.h

For me, config file should be imported by printf.h in addition to or instead of printf.c.
For example, printf.h uses PRINTF_ALIAS_STANDARD_FUNCTION_NAMES_SOFT which can't be set by the config file currently.

PRINTF_ALIAS_STANDARD_FUNCTION_NAMES_SOFT ... can't be set by the config file currently.

It can be set using the config file.
But regardless of that - please argue you believe this should be the case, and which of the two options you're suggesting: Support in-addition-to or support instead-of.

It's set to 0 in config here if not defined. And it won't be defined if not included.


Fine tune protocol timeouts

This is a follow up to #1395 and #1427. In the byron reboot and shelley-testnet era we should gather enough data to make sensible data driven decisions for the shelley-mainnet release.

In particular this includes:

timeout while receiving the trailing chunks a multi-chunk message, when the protocol state in which we're receiving the message itself has no timeout


Add ColorTypes 0.11 to compat

Tests pass locally.

Codecov Report

Merging #51 (c2ff860) into master (6dec118) will decrease coverage by 1.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   89.72%   88.05%   -1.68%
==========================================
  Files          12       12
  Lines         545      544       -1
==========================================
- Hits          489      479      -10
- Misses         56       65       +9

Impacted Files
Coverage Δ

src/TiffImages.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/utils.jl
70.37% <0.00%> (-5.56%)
:arrow_down:

src/compression.jl
90.00% <0.00%> (-5.00%)
:arrow_down:

src/layout.jl
86.53% <0.00%> (-1.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dec118...c2ff860. Read the comment docs.

Awesome, thanks!


Deprecated minimatch and graceful-fs

Expected Behaviour
No use of deprecated packages.
No warnings issued regarding use of deprecated packages.
In particular, note that graceful-fs is clearly indicated to be too old for node >= v7.0.
Actual Behaviour
2 warnings for minimatch. 1 for graceful-fs.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

Steps to Reproduce
`npm install grunt-responsive-images'
PC/Mac and Graphics Engine used
N.A.
Grunt Configuration
"devDependencies": {
    "grunt": "^1.0.1",
    "grunt-cli": "^1.2.0",
    "grunt-responsive-images": "^0.1.9"
}

node v7.1.0

It looks like this is an issue with Grunt itself as GRI doesn't depend on these packages directly.
See: https://github.com/gruntjs/grunt/issues/1557 and https://github.com/gruntjs/grunt/issues/1467
The plugin does however have a dependency on an older version of Grunt, so I will update this to a newer version.
Thanks for reporting.

I've released a new version, see if that fixes it?

It looks like this is an issue with Grunt itself

Yikes!
Sorry for wasting your time! No issue here.

Thanks for the feedback.


Fix half the mods not being recognized in Korean and Chinese

As mentioned in #66, it seems that localizations are more or less working. The problem with this is while everything seems to be parsing(that I have checked), a lot of mods are not being recognized. The things that I think is causing this, either there is another problem like #147 where I just need to change a function call, or something else. (I really hope it is just a function call problem).
Currently the status is that the mod is being parsed as the correct value and it's value should fit in the matcher but it is still unrecognized for some reason.
I am testing on this item:
English:
Item Class: Rings
Rarity: Rare
Morbid Whorl
Ruby Ring
--------
Requirements:
Level: 23
--------
Item Level: 39
--------
+27% to Fire Resistance (implicit)
--------
+33 to Accuracy Rating
+35 to Evasion Rating
+13% to Lightning Resistance
38% increased Mana Regeneration Rate

Korean:
아이템 종류: 반지
아이템 희귀도: 희귀
소름 끼치는 나사선
루비 반지
--------
요구사항:
레벨: 23
--------
아이템 레벨: 39
--------
화염 저항 +27% (implicit)
--------
정확도 +33
회피 +35
번개 저항 +13%
마나 재생 속도 38% 증가

This is properly being read from the copy text, and it is finding the correct item in items.ndjson

The permutation generator give:

정확도 +33
정확도 #
정확도 +33
as the possible ones.
The matchers for 정확도 (accuracy rating) are 정확도 +#

Seems like this is either a data parser bug or a error in the permutation generation

ndjson.old has 정확도 # so this is a data parser error probably


On Android Tablet, if screen powers off between rounds, it gets disconnected from session

It's stuck at the end of round screen and won't move on to the next round.

Fixing this required a fun hack: I make the browser think there's a video playing. 💯

After a brief delay, the tablet is eventually able to submit/vote, but when the next leaderboard appears, that player has been dropped from the game.

Tablet isn't able to submit after that point, but can still vote.

I've yet to be able to get a device to disconnect via going to sleep.

Is this fixed?

I cannot reproduce it.

just like 72, I think these are ancient problems that we already fixed, but just to be sure, please check. If we aren't sure, lets move these to QA pipeline to try and reproduce

Should be fixed as of commit 2953101a8264b523298f7dd2afe3828c21fb6ad6. Please confirm.

Unable to reproduce


on ace-bridge change the team access code

on ace-bridge change the team access code

on ace-bridge change the team access code


DOCS-8878: Two new files for APID 2.21.0

@rddheath: for the design-helpful-features-text-editor section, could we also document the already implemented go-to actions? (Go to definition, go to type implementation, go to implementation). It would be great if we can have all helpful editor actions grouped in one section. Maybe not for this PR, but as a future enhancement to the docs?


Error when sending notification of new article

Telegram responded with an error 400 - Bad Request: group chat was upgraded to a supergroup chat
I think for some reason the group ID has changed since testing.

Have you upgraded the group to a supergroup!!

1- Have you upgraded the group to a supergroup!!
2- Have you updated the group ID!

Guess we can close this now. We're receiving notifications fine now.


--web-security=no failure

I opened this issue over here: https://github.com/ariya/phantomjs/issues/14040 because I feel reasonably confident that the issue is with PhantomJS.
However, in case it's not, I was wondering if someone here could take a look?
Thanks.

PhantomJS 2.1.1 fixes this. I explained how to explicitly change the engine at the issue you filed there.


Global settings are saved within job configuration

When a job is modified, the current global slack notifier settings (eg team domain, build server URL) are saved within the job configuration. If the global settings are modified afterwards, the new changes won't propagate to existing jobs until they are next saved.
To reproduce this issue:

Configure a new job with slack notifier integration
Modify the global settings (eg changing the build server URL)
The job will not have the new settings
Re-save the job configuration
New settings are now applied

This issue was originally identified in #124

Contributions are welcome to resolve this issue!  I propose this issue be fixed by removing the global settings from the job entirely and just reference the global configuration.
I don't actively develop this plugin.  I contribute by maintaining pull requests and releases.

Doesn't seem to do it anymore?
  <baseUrl></baseUrl>
      <teamDomain></teamDomain>
      <tokenCredentialId></tokenCredentialId>
      <botUser>false</botUser>
      <room></room>

That's on a job that relies on global config


Bug in the generation of the HartreeFock state for homonuclear molecules.

Information

Qiskit Nature version: 0.2.0
Python version:  3.7
Operating system: macOS Big Sur

What is the current behavior?
Error when creating the initial HF state for the UCCSD ansatz only for homonuclear molecules.
LiH for instance works fine with this code.
Seems like in the hartree_fock.py the code below behaves in an unexpected manner.
        # get the bitstring encoding the Hartree Fock state
        bitstr = hartree_fock_bitstring(num_spin_orbitals, num_particles)

        # encode the bitstring as a `FermionicOp`
        label = ["+" if bit else "I" for bit in bitstr]
        bitstr_op = FermionicOp("".join(label), display_format="dense")

        # map the `FermionicOp` to a qubit operator
        qubit_op: PauliSumOp = qubit_converter.convert_match(bitstr_op)

qubit_op is None which produces an error.
Steps to reproduce the problem
from qiskit_nature.drivers import UnitsType, Molecule
from qiskit_nature.drivers.second_quantization import ElectronicStructureDriverType, ElectronicStructureMoleculeDriver
from qiskit_nature.problems.second_quantization import ElectronicStructureProblem
from qiskit_nature.converters.second_quantization import QubitConverter
from qiskit_nature.mappers.second_quantization import JordanWignerMapper, ParityMapper
from qiskit_nature.transformers.second_quantization.electronic import FreezeCoreTransformer

# molecule

molecule = Molecule(geometry=[['Li', [0., 0., 0.]],
                              ['Li', [0., 0., 2.771]]],
                     charge=0, multiplicity=1)

freezeCoreTransformer = FreezeCoreTransformer(True)
driver = ElectronicStructureMoleculeDriver(molecule, basis='sto3g', driver_type=ElectronicStructureDriverType.PYSCF)
es_problem = ElectronicStructureProblem(driver, transformers=[freezeCoreTransformer])
two_qubit_reduction = True
mapper = ParityMapper()
qubit_converter = QubitConverter(mapper, two_qubit_reduction=two_qubit_reduction, z2symmetry_reduction='auto')

# vqe

from qiskit_nature.algorithms import GroundStateEigensolver
from qiskit import Aer
from qiskit.utils import QuantumInstance
from qiskit.algorithms.optimizers import SLSQP
from qiskit_nature.algorithms import VQEUCCFactory

optimizer = SLSQP(maxiter=10000)
quantum_instance = QuantumInstance(backend = Aer.get_backend('aer_simulator_statevector'))
solver = VQEUCCFactory(quantum_instance,
                           optimizer=optimizer,
                           )
gsc = GroundStateEigensolver(qubit_converter, solver)
result = gsc.solve(es_problem)

# Error
#python3.7/site-packages/qiskit_nature/circuit/library/initial_states/hartree_fock.py", line 57, in __init__
#    qr = QuantumRegister(qubit_op.num_qubits, "q")
#AttributeError: 'NoneType' object has no attribute 'num_qubits'

What is the expected behavior?
Correct HF initial state.
Suggested solutions
Check out the qubit_converter.convert_match method.

Any idea if this is going to get fixed or already was?


Fix fourslash baselines

40e459117aeb0b792a23d6805af884b594dd42c4 was out of date in a way that
didn't register as a conflict.

@amcasey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


https://visionmedia.github.io/superagent/ is showing empty page

There is no content on https://visionmedia.github.io/superagent/

Fixed


Updated spacing and line length

Reduced some lines to a length of less than 80 characters per PSR-2 standards and added spacing for readability between some lines.

No, thanks.

There's a lot of room for improvement regarding PSR-2, but if you say so...


Connects to #350. Data updates signup.

Key Changes:

Added a new "Data Updates Signup" menu item in the "Data Access" top nav link dropdown menu. This new menu item opens a Google Form for anyone to subscribe to MoTrPAC data updates.
Added document titles in the <head> element for a number of pages to improve user navigation experience and Google Analytics tracking.

Looks good to me. Just noting here that the Data Updates Signup drop-down missing from the navbar for logged in consortium users is intended behavior.


Constructed URL has double slash, and is not using defined 'scheme'

swagger: "2.0"
info:
  description: Octocat
  title: Octocat
  version: "1.0.0"
host: api.github.com
schemes:
  - https
basePath: /
produces:
  - application/json
consumes:
  - application/json
paths:
  /octocat:
    get:
      operationId: octocat_get
      summary: OctoCat
      responses:
        '200':
          description: OK
          schema:
            type: string

cc: @TylerLeonhardt

In the generated code :
                var _url = new System.Uri((
                        "http://api.github.com//octocat"
                        ).TrimEnd('?','&'));

It looks like github doesn't like the accidental // in the path.
And... it's not using the scheme from the model .

I am facing this issue as well.
Generated code below has double slash, apart from this, constructed URI is invalid.
                // construct URL
                var _url = new System.Uri((
                        "https://graph.microsoft.com/v1.0//directory"
                        + "?"
                        + Select != null && Select.Length > 0 ? "Select=" + System.Uri.EscapeDataString(System.Linq.Enumerable.Aggregate(Select, (current, each) => current + "," + (string.IsNullOrEmpty(each) ? System.Uri.EscapeDataString(each) : System.String.Empty))) : System.String.Empty
                        + "&"
                        + Expand != null && Expand.Length > 0 ? "Expand=" + System.Uri.EscapeDataString(System.Linq.Enumerable.Aggregate(Expand, (current, each) => current + "," + (string.IsNullOrEmpty(each) ? System.Uri.EscapeDataString(each) : System.String.Empty))) : System.String.Empty
                        ).TrimEnd('?','&'));

Getting below error:
PS D:\workspace\powershell\graph [Subset of Microsoft Graph API]> Invoke-DirectoryDirectoryGetDirectory -select "abc"
Invoke-DirectoryDirectoryGetDirectory : Invalid URI: The format of the URI could not be determined.
At line:1 char:1
+ Invoke-DirectoryDirectoryGetDirectory -select "abc"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Invoke-Director...DirectorySelect], UriFormatException
+ FullyQualifiedErrorId : Sample.API.Cmdlets.InvokeDirectoryDirectoryGetDirectory_DirectoryGetDirectorySelect

I've fixed the scheme and doubleslash problem
(along with a whole bunch of other serialization issues)
update (autorest --reset  and try again)
The authentication problem with github is caused because they error out on requests without a user-agent  header.  Dunno why they do that.

And this is not accurate:
        '200':
          description: OK
          schema:
            type: string

The body is not a string; it's gotta be a stream of some kind. to have the body declared as a string, the content would have to be quoted at the very least.

I haven't yet added the final bits in for stream handling but it's pretty easy.

it's gotta be a stream of some kind

It's custom lol:
(iwr https://api.github.com/octocat).Headers["Content-Type"]
application/octocat-stream

Glad you got it working! Did you make any changes to the swagger.yml?

What that API should be described like.
swagger: "2.0"
info:
  description: Octocat
  title: Octocat
  version: "1.0.0"
host: api.github.com
schemes:
  - https
basePath: /
produces:
  - application/octocat-stream
paths:
  /octocat:
    get:
      operationId: octocat_get
      summary: OctoCat
      parameters:
      - name: user-agent
        in: header
        type: string
        enum: ['nonya']
      responses:
        '200':
          description: OK
          schema:
            type: string
            format: binary

definitions:
  Primitives:
    type: object
    properties:
      a_number:
        type: number
        format: integer

The generator doesn't complete the last few lines for binary yet, but it's only a bit of code:
// in GetOctocat.cs ( line 259 ish)
        private async System.Threading.Tasks.Task onOK(System.Net.Http.HttpResponseMessage responseMessage, System.Threading.Tasks.Task<System.IO.Stream> response)
        {
            using( NoSynchronizationContext )
            {
                // onOK - response for 200 / application/octet-stream
                // (await response) // should be System.IO.Stream
                using( var sr  = new System.IO.StreamReader(await response))  {
                  WriteObject(sr.ReadToEnd());
                }
            }
        }

// in Octocat.cs (line 66ish)
                        case System.Net.HttpStatusCode.OK:
                        {
                            await eventListener.Signal(Sample.API.Runtime.Events.BeforeResponseDispatch, _response); if( eventListener.Token.IsCancellationRequested ) { return; }
                            await onOK(_response,_response.Content.ReadAsStreamAsync());
                            break;
                         }

Great - glad to hear it's easy to fix. I was going to demo this at a meetup in Seattle but I'll pick a different URL for now until AutoRest.PowerShell supports streams better.


Pointer icon setting gets immediately reset on Desktop

Describe the bug
If I set a pointer icon with hoverPointerIcon, the pointer gets immediately reset to the default one:
https://github.com/JetBrains/compose-multiplatform/assets/153802/2fab2fb3-6acd-4e51-9993-869e35fd2fcc
Affected platforms

Desktop

Versions

Kotlin version*: 1.8.21
Compose Multiplatform version*: 1.6.0-dev1369 (but I first noticed it on 1.5.11)
OS version(s)* (required for Desktop and iOS issues): macOS Sonoma 14.2.1
OS architecture (x86 or arm64): arm64
JDK (for desktop issues): latest JBR 17, latest Corretto 17

To Reproduce
// Same effect if you comment out the text composable
Box(Modifier.size(300.dp, 50.dp).background(Color.Gray).pointerHoverIcon(PointerIcon.Hand, true)) {
  Text("This should have a hand icon when hovered", Modifier.align(Alignment.Center))
}

Expected behavior
The chosen pointer icon should remain until the hover ends.

Looks like a reboot made this work again. 🤷

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Updated to use UIViewPropertyAnimator. Works with iOS 11.

Do not merge until after code review and after I get a chance to rewrite the accompanying recipe text.

Superseded


when redirect_http_to_https is false the template gitlab-puppet.rb.erb ignores  ssl_certificate parameter

<% end %><% if @redirect_http_to_https == true -%>
nginx['redirect_http_to_https'] = <%= @redirect_http_to_https %>
nginx['ssl_certificate'] = '<%= @ssl_certificate -%>'
nginx['ssl_certificate_key'] = '<%= @ssl_certificate_key %>'
<% end -%>

This should probably be dependent on the external_url parameter starting with https

+1 and for some context on why: gitlab ci runners with buggy ssl support or out-of-date CA bundles.

Actually, this doesn't look like a puppet-gitlab issue but an issue with how the gitlab::nginx chef recipe interprets the url.

@erik-stephens see the pull request. In nutshell, if you dont "redirect_http_to_https" then you dont deploy ssl certs.
My use case is that I run apache on port 80 so I set "redirect_http_to_https = False" so that nginx doesn't listen on port 80. This causes the erb template to not include ssl certificates. My merge #127 request fixes the logic around this and also includes tests that cover what I believe the logic should be.

@timhughes Looks good to me.  Not sure what I was linking to.

Module transitioned to here:  https://github.com/vshn/puppet-gitlab


DI-237 Update the ADR and associated diagrams

Link to JIRA Ticket

https://nhsd-jira.digital.nhs.uk/browse/DI-237

Description
Update the ADR and associated diagrams to reflect that we are no longer using EventBridge Api Destinations
Type of change
Delete not appropriate

This change requires a documentation update

Another than a few typos looks good 👍


How to properly traverse deserialized data?

Trying to traverse the items_game.txt file for CS:GO.  As an example I'll try to get to "first_valid_class" under "game_info".
I can do it using an older method from reading an old issue:
dynamic itemsG = VdfConvert.Deserialize(itemsGame);

Log.Info(itemsG.Value["game_info"]["first_valid_class"].ToString());

But when I try to use what I think is a new method that you added, meant to be more like json:
Log.Info(itemsG.game_info.first_valid_class.ToString());

It throws an excpetion: "'Gameloop.Vdf.Linq.VProperty' does not contain a definition for 'game_info'".
What am I getting wrong?  It's not clear how to use it from the README file, you use '.Valve' despite nothing in the example being called "Valve".
EDIT: Never mind, all of 5 minutes later and re-read the documentation and saw it says "Value", not "Valve".  It now works.  However on the documentation you state that you skipped the enclosing property name "Steam", but I still have to include "game_info".  What's going on?

When You call VdfConvert.Deserialize(itemsGame), the function returns a VProperty. This VProperty refers to the root element "Steam". You don't need to refer to this in your code since there can only ever be one root property, which you already have.
Your confusion is justified in that the first time you need to use .Value since you have a VProperty. But as you access child elements, the library directly returns their values.
From a technical standpoint, it is fully possible to directly return the value of the root property instead of the property itself. But this has one serious limitation - it would be impossible to find the key name of the root property.
Imagine some use case where you need to know the name of the root element (i.e. "Steam" in the below example):
"Steam"
{
	"SSAVersion"		"3"
	"PrivacyPolicyVersion"		"2"
	"SteamDefaultDialog"		"#app_store"
	"DesktopShortcutCheck"		"0"
	"StartMenuShortcutCheck"		"0"
}

Using the code we have now, you could simply do VdfConvert.Deserialize(vdfData).Key. If we had directly returned a VObject that represented the value of the property, then getting the key name would be impossible.
Coming back to your question, you need to use .Value on the root property since there is no other way to find the .Key if you ever need it. However, for descendants, this will never be a problem since you already know the key name when you access it!
I understand this might sound even more confusing - let me know if I can help clear anything up.

As a final complication, it is actually possible to have the best of both worlds by allowing these all 3 code pieces below to work together:
NOTE: This is not valid code in the current version of the library. It is only a thought experiment !!!
dynamic obj = VdfConvert.Deserialize(vdfData);
Console.WriteLine(obj.Key); // Prints "Steam"
Console.WriteLine(obj.SSAVersion); // Prints "3"
Console.WriteLine(obj.Value.SSAVersion); // Prints "3"

This could be done by making the VProperty type check if a dynamically accesses property is either Key or Value and if not, then to try and access it from the value directly (iff the .Value is a VObject). But I felt this would only lead to more confusion (imagine a case where the value of the property is a VObject that also contains a property with a key named "Key").
Note that JSON doesn't have to deal with this problem at all since properties are not root valid elements. While implementing this library, I had to make a decision and decided on this since I thought it would most closely match the behavior of JSON.NET.

Thank you.  I don't think that was more confusing, it cleared it up for me and I understand it now.


Feature request

At first see https://github.com/facebook/react-native/pull/15046#issuecomment-316272171
Here we have a base64 encoding in native environment and base64 decoding in js environment( and vise versa for sending binary)
This redundant encode/decode take a lot of CPU resources and can be omitted
In https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableMap.java#L21 we only have putString so we cannot transfer binary from native to js or vise versa , I request void putByte(String key, Byte value); method for android and similar method for iOS and JS side

@facebook-github-bot feature


theme issues

I changed theme from dark to light,but where I refresh the page , it rolled back

Issue reviewed, the choice of theme should be cached in the browser. Maybe the localstorage is required.

[ ] Save the choice with local storage
[ ] Read the value if needed

For the better track of the issue, the topic has been moved to #12 . Thank you for your feedback.

#12


Save multiple parent(or level one) records

@nathanvda  First, I really loved your gem :+1:
I was wondering - what if I had no association and would like to save multiple parent records - the add and remove functionalities would all remain the same like it is there in your gem..Is there a room for that too ?

Closed due to inactivity.


Check for authorship presence before attempting match

Resolves the original issue described in #3660.

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5e190c4) 85.85% compared to head (8ba6ba2) 59.90%.
 Consider uploading reports for the commit c3058ea to get more accurate results

Files
Patch %
Lines

app/models/dataset_record/darwin_core/taxon.rb
0.00%
9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #3662       +/-   ##
================================================
- Coverage        85.85%   59.90%   -25.96%
================================================
  Files             2020     1519      -501
  Lines            74447    46209    -28238
================================================
- Hits             63915    27680    -36235
- Misses           10532    18529     +7997

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Thumbnails API Endpoint has degraded performance

In 0ddbc01, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 3222 ms

Resolved: Thumbnails API Endpoint performance has improved in bcc99e5 after 7 minutes.


[minor] fix tajikistan

Coverage remained the same at 90.893% when pulling 49ff36e9888e93c0cedbe6224533a98b5b4b09fc on dictionaries_Tajikistan into 80fa0b031f8508b7cc783db5212303e41a290b75 on develop.


📝 Fix numbering of steps in Adobe XD tutorial

The following issue appears to be an issue with a remote MDX page.
📝 Fix
Page: https://next.carbondesignsystem.com/designing/adobe-xd
Issue: List numbers under "Get the Adobe XD Creative Cloud libraries" all show as 1 after step 2.

Originally posted by @aagonzales in https://github.com/carbon-design-system/carbon-platform/discussions/1270#discussioncomment-3684314

https://github.com/carbon-design-system/carbon-platform/discussions/1270#discussioncomment-3684322

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


change ai analytics

Summary
This will allow to add a provide layer in the analytics in case several plugins are used
Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

not new commit present

By using the AI request and response transformers you will get following logs:
When using same AI provider:
"ai": {     "cohere": {       "instances": [         {           "meta": {             "response_model": "command",             "provider_name": "cohere",             "request_model": "command"           },           "usage": {             "completion_tokens": 33,             "prompt_tokens": 129,             "total_tokens": 162           }         },         {           "meta": {             "response_model": "command",             "provider_name": "cohere",             "request_model": "command"           },           "usage": {             "completion_tokens": 25,             "prompt_tokens": 412,             "total_tokens": 437           }         }       ],       "request_prompt_tokens": 541,       "request_completion_tokens": 58,       "request_total_tokens": 599,       "number_of_instances": 2     }   }
When using different AI providers:
"ai": {     "cohere": {       "instances": [         {           "meta": {             "response_model": "command",             "provider_name": "cohere",             "request_model": "command"           },           "usage": {             "completion_tokens": 130,             "prompt_tokens": 129,             "total_tokens": 259           }         }       ],       "request_prompt_tokens": 129,       "request_completion_tokens": 130,       "request_total_tokens": 259,       "number_of_instances": 1     },     "mistral": {       "instances": [         {           "meta": {             "response_model": "mistral-tiny",             "provider_name": "mistral",             "request_model": "mistral-tiny"           },           "usage": {             "completion_tokens": 171,             "prompt_tokens": 562,             "total_tokens": 733           }         }       ],       "request_prompt_tokens": 562,       "request_completion_tokens": 171,       "request_total_tokens": 733,       "number_of_instances": 1     }   }

Would it be possible to also store the plugin_id for each instance so that the user can point back to where it's being used?

It seems we have resolved all the points. Are we ok to push this PR? @jschmid1
Thanks

@jschmid1  thanks could you please cherry pick and merge to EE? Thanks

@jschmid1 This squashed commit is missing the component in the scope, please watch out next time :)