Round function - Eigen3 issue

Hello Guys,
I have an issue installing EmulationStation on my intel nuc with debian.

In file included from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:9:0:
/home/nuc/EmulationStation/es-core/src/Util.h:18:22: error: ‘float round(float)’ conflicts with a previous declaration
float round(float num);
^
In file included from /usr/include/c++/6/complex:44:0,
from /usr/include/eigen3/Eigen/Core:80,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/nuc/EmulationStation/es-core/src/Renderer.h:7,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:2:
/usr/include/c++/6/cmath:1790:3: note: previous declaration ‘constexpr float std::round(float)’
round(float __x)
^~~~~
/home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp: In function ‘void Renderer::drawRect(float, float, float, float, unsigned int, GLenum, GLenum)’:
/home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:90:24: error: call of overloaded ‘round(float&)’ is ambiguous
drawRect((int)round(x), (int)round(y), (int)round(w), (int)round(h), color, blend_sfactor, blend_dfactor);
^
In file included from /usr/include/features.h:364:0,
from /usr/include/x86_64-linux-gnu/c++/6/bits/os_defines.h:39,
from /usr/include/x86_64-linux-gnu/c++/6/bits/c++config.h:507,
from /usr/include/c++/6/string:38,
from /home/nuc/EmulationStation/es-core/src/platform.h:18,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:1:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:326:1: note: candidate: double round(double)
__MATHCALLX (round,, (Mdouble __x), (const));
^
In file included from /usr/include/c++/6/complex:44:0,
from /usr/include/eigen3/Eigen/Core:80,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/nuc/EmulationStation/es-core/src/Renderer.h:7,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:2:
/usr/include/c++/6/cmath:1794:3: note: candidate: constexpr long double std::round(long double)
round(long double __x)
^~~~~
/usr/include/c++/6/cmath:1790:3: note: candidate: constexpr float std::round(float)
round(float __x)
^~~~~
In file included from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:9:0:
/home/nuc/EmulationStation/es-core/src/Util.h:18:7: note: candidate: float round(float)
float round(float num);
^~~~~
/home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:90:39: error: call of overloaded ‘round(float&)’ is ambiguous
drawRect((int)round(x), (int)round(y), (int)round(w), (int)round(h), color, blend_sfactor, blend_dfactor);
^
In file included from /usr/include/features.h:364:0,
from /usr/include/x86_64-linux-gnu/c++/6/bits/os_defines.h:39,
from /usr/include/x86_64-linux-gnu/c++/6/bits/c++config.h:507,
from /usr/include/c++/6/string:38,
from /home/nuc/EmulationStation/es-core/src/platform.h:18,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:1:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:326:1: note: candidate: double round(double)
__MATHCALLX (round,, (Mdouble __x), (const));
^
In file included from /usr/include/c++/6/complex:44:0,
from /usr/include/eigen3/Eigen/Core:80,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/nuc/EmulationStation/es-core/src/Renderer.h:7,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:2:
/usr/include/c++/6/cmath:1794:3: note: candidate: constexpr long double std::round(long double)
round(long double __x)
^~~~~
/usr/include/c++/6/cmath:1790:3: note: candidate: constexpr float std::round(float)
round(float __x)
^~~~~
In file included from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:9:0:
/home/nuc/EmulationStation/es-core/src/Util.h:18:7: note: candidate: float round(float)
float round(float num);
^~~~~
/home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:90:54: error: call of overloaded ‘round(float&)’ is ambiguous
drawRect((int)round(x), (int)round(y), (int)round(w), (int)round(h), color, blend_sfactor, blend_dfactor);
^
In file included from /usr/include/features.h:364:0,
from /usr/include/x86_64-linux-gnu/c++/6/bits/os_defines.h:39,
from /usr/include/x86_64-linux-gnu/c++/6/bits/c++config.h:507,
from /usr/include/c++/6/string:38,
from /home/nuc/EmulationStation/es-core/src/platform.h:18,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:1:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:326:1: note: candidate: double round(double)
__MATHCALLX (round,, (Mdouble __x), (const));
^
In file included from /usr/include/c++/6/complex:44:0,
from /usr/include/eigen3/Eigen/Core:80,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/nuc/EmulationStation/es-core/src/Renderer.h:7,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:2:
/usr/include/c++/6/cmath:1794:3: note: candidate: constexpr long double std::round(long double)
round(long double __x)
^~~~~
/usr/include/c++/6/cmath:1790:3: note: candidate: constexpr float std::round(float)
round(float __x)
^~~~~
In file included from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:9:0:
/home/nuc/EmulationStation/es-core/src/Util.h:18:7: note: candidate: float round(float)
float round(float num);
^~~~~
/home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:90:69: error: call of overloaded ‘round(float&)’ is ambiguous
drawRect((int)round(x), (int)round(y), (int)round(w), (int)round(h), color, blend_sfactor, blend_dfactor);
^
In file included from /usr/include/features.h:364:0,
from /usr/include/x86_64-linux-gnu/c++/6/bits/os_defines.h:39,
from /usr/include/x86_64-linux-gnu/c++/6/bits/c++config.h:507,
from /usr/include/c++/6/string:38,
from /home/nuc/EmulationStation/es-core/src/platform.h:18,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:1:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:326:1: note: candidate: double round(double)
__MATHCALLX (round,, (Mdouble __x), (const));
^
In file included from /usr/include/c++/6/complex:44:0,
from /usr/include/eigen3/Eigen/Core:80,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/nuc/EmulationStation/es-core/src/Renderer.h:7,
from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:2:
/usr/include/c++/6/cmath:1794:3: note: candidate: constexpr long double std::round(long double)
round(long double __x)
^~~~~
/usr/include/c++/6/cmath:1790:3: note: candidate: constexpr float std::round(float)
round(float __x)
^~~~~
In file included from /home/nuc/EmulationStation/es-core/src/Renderer_draw_gl.cpp:9:0:
/home/nuc/EmulationStation/es-core/src/Util.h:18:7: note: candidate: float round(float)
float round(float num);
^~~~~

It seems there is an issue with the round(float) function and the one from the Eigen3 library.
Any clue ?

Is it the same bug than #692 ?

just built successfully on Debian 9.4 2018-06-17 stretch lxqt using #692 suggestions


ODBC driver missing in Python 3.11 runtime

Description
When I use the pyodbc library to try to use the system ODBC driver to connect to an Azure SQL instance, I get this error:
Result: Failure Exception: OSError: ('01000', "[01000] [unixODBC][Driver Manager]Can't open lib 'ODBC Driver 18 for SQL Server' : file not found (0) (SQLDriverConnect)") ...

Things I've tried
Specifying ODBC Driver 17 in my database connection string instead of 18. Then, I get this error instead:
Result: Failure Exception: OSError: ('01000', "[01000] [unixODBC][Driver Manager]Can't open lib 'ODBC Driver 17 for SQL Server' : file not found (0) (SQLDriverConnect)") ...

SSH'ing into the container via the Azure Portal.

I first looked at /etc/odbcinst.ini, which was empty.
Looking for any directory named *odbc* on the system using find / -type d -name '*odbc*'. msodbcsql17 appeared under docs, but nothing else of import came up.

How I resolved it
I ended up downgrading from Python 3.11 to Python 3.10.
I then SSH'ed into the new container, verified that the Python version was actually downgraded using python --version, and looked at /etc/odbcinst.ini again, and it now contained the following:
[ODBC Driver 17 for SQL Server]
Description=Microsoft ODBC Driver 17 for SQL Server
Driver=/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.10.so.4.1
UsageCount=1

Looks like this was fixed in #973


iptables: Fix <IP_ADDRESS>:NodePort to remote pods

Commit c6888d48780 fixed <IP_ADDRESS>:NodePort redirection by adding an additional
clause to the kube-proxy masquerade bit clearing rule to ensure that kube-proxy
masquerades all traffic with a source IP of <IP_ADDRESS>. This fixes NodePort
redirection to local pods but it can cause problem when running in
encapsulation mode depending on the rp_filter settings of nodes because the
source IP of the traffic will have a source IP equal to any of the node IPs
which are not routable on the overlay. This causes reply traffic to be routed
back via the underlay which the reverse path filter can potentially drop.
Fixes: c6888d48780 ("iptables: Ensure NAT for locally-sourced packets")

This change is

test-me-please

Weird, when setting this up with ginkgo manually, it always succeeds no matter how much I hammer it.

test-me-please

Coverage decreased (-0.01%) to 42.907% when pulling 8bdfa2b4552954754c21ca99ec1d130c5cec42ac on pr/tgraf/fix-node-port-localhost into 2a1c21a119939f9beb9211106b04cef5d2ab8b50 on master.

test-me-please

test-me-please

It passes the recent "testing connectivity via localhost IP" tests, so at minimum doesn't break anything. Would be good to get some real regression tests of cross-node examples of this, but seems OK to me.

I've done that manually with several million requests and couldn't find a way to break it.


move pilosa/internal/public.proto into separate external package

Description
go-pilosa imports pilosa, but also redefines Pilosa protobufs separately.  If we make Pilosa's public proto definitions importable from other packages, we can fix this issue.
Success criteria (What criteria will consider this ticket closeable?)
Public protobuf definitions can be imported from other projects.

We addressed this in go-pilosa, but it still needs to be addressed for pilosa core.

I think we decided not to do this since other languages would still need a separate copy of the .proto file it makes sense for that to be the way in which the API gets shared.


[dfyn-staked-in-vaults] dfyn-staked-in-vaults strategy added

Fixes # .
Changes proposed in this pull request:

new strategy added to check score for dfyn staked in dfyn vaults

Strategy is live: https://snapshot.org/#/strategy/dfyn-staked-in-vaults


Add additional macos shortcuts for going to start/end of line

This adds control-a and control-e as shortcuts for going to start and end of line respectively. This is a common OS-level shortcut in macos, and should be part of text editors.
Fixes Issue #17981

Thank you for contributing! Sorry for not able to provide much help as I'm not familiar with OSX platform.
I think you need to put some of the changes inside #ifdef APPLE_STYLE_KEYS ... #endif block so that it only works on OSX build.
If you need to make changes to the commit, please use git commit --amend so that it overwrites previous commit instead of creating another commit in order to keep the git history clean.

@Noshyaar Are you familiar with this code region? I had a question. I am modifying the KEY_A case, which IIUC was checking for command-a and calling select_all() for all platforms. This confuses me, since I was under the impression that "select all" is done by control-a in windows. What's happening here?

Yes, on Windows it's control+A. I think this line checks if any keys other than control is being held:
if (!k->get_command() || k->get_shift() || k->get_alt()) {

(apparently on other platforms, ctrl keys trigger get_command flag) and it breaks out of the switch. While if only the control key and A are held, it skips the condition and proceeds to select_all.
Not sure what do you mean by test. there's only clang-format check. Make sure to run clang-format before committing, or check the log on Travis for errors and amend the fix. Also there's a simple "unit test", try godot --help.

I am modifying the KEY_A case, which IIUC was checking for command-a and calling select_all() for all platforms. This confuses me, since I was under the impression that "select all" is done by control-a in windows. What's happening here?

On macOS meta == command != control, on other platforms meta != command == control.
See: input_event.h#L178-L192

Could you also let me know how to run the tests? I didn't find any information in the docs.

You can run unit tests with godot --test TEST_NAME but there's no one for input (unfortunately current test coverage is abysmal, and most of existing tests aren't updated for ages).

Thanks @bruvzg .
I've checked this PR on macos. I'd appreciate if you (or someone) could check on a non-macos machine. After that, I think this PR is good to go, unless you have any readability concerns.

Hi @bruvzg @Noshyaar, anything else needed to merge this PR?

Is there still a way to "Select All" then? I'm not familiar with MacOS but this seems like a strange change.

Yes. "command-a" does select all.
On Tue, Apr 10, 2018 at 9:52 PM, Aaron Franke<EMAIL_ADDRESS>wrote:

Is there still a way to "Select All" then? I'm not familiar with MacOS but
this seems like a strange change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/18003#issuecomment-380300909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApVxHq2pjJPoF8vXqDjSnCNfVI-1smWks5tnWHcgaJpZM4TI0ZE
.

https://support.apple.com/en-ca/HT201236
On Tue, Apr 10, 2018 at 10:49 PM, Sherjil Ozair<EMAIL_ADDRESS>wrote:

Yes. "command-a" does select all.
On Tue, Apr 10, 2018 at 9:52 PM, Aaron Franke<EMAIL_ADDRESS>wrote:

Is there still a way to "Select All" then? I'm not familiar with MacOS
but this seems like a strange change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/18003#issuecomment-380300909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApVxHq2pjJPoF8vXqDjSnCNfVI-1smWks5tnWHcgaJpZM4TI0ZE
.

@godotengine What needs to be done to merge this PR?

@sherjilozair The Godot team have lots of PRs to review. All I can say is, be patient, and be sure to check if there are any problems. It'll be faster if the reviewers don't have to request changes.

@reduz This was a very old PR, and there have been changes to this file after that. I can't guarantee that the PR still does what it claims to. Did you or anyone else test this PR on a mac to make sure there are no regressions?

Cherry picked into 3.0.3

@hpvb This one added regressions, which were fixed by two subsequent PRs, but I'm still not sure about the end result. I think it's best to leave it out for now and reevaluate later with all followups.

Ah well I see you cherry-picked the bug fixes too, so I guess we can give it a spin in 3.0.3 :)


Link Nullable from NullMarked.

There already is a reference from Nullable to NullMarked.
(Java 9+ version also needs this edit. Didn't reformat to highlight change.)

Indeed I did feel bad not having a link in this direction. It's only that I think we shouldn't restrict what the meaning of "marked otherwise" can include, because really it could be any annotation that specifies nullness semantics (which might specify @Implies(org.jspecify.nullness.Nullable) but might not).
Maybe the fix is as simple as inserting the word "commonly"/"typically"/"presumably"/etc.?  WDYT.

Indeed I did feel bad not having a link in this direction. It was only for this reason: I think we shouldn't restrict what the meaning of "marked otherwise" can include, because really it could be any annotation that specifies nullness semantics (which might specify @Implies(org.jspecify.nullness.Nullable) but might not).
Maybe the fix is as simple as inserting the word "commonly"/"typically"/"presumably"/etc.? WDYT.

I saw our goal to have minimal Javadoc for the 0.2.0 release. In that release, Nullable is the only option to mark something, right? (NullnessUnspecified won't be included in the release. There is no Implies yet.)
In future releases, we'll need to expand/finalize the Javadoc and can then add other options.
But adding some word (maybe "currently"?) is also fine with me.
Let me know and I'll update and expand to the other copy.

Sorry this reply isn't helping move toward resolution yet :-(

I saw our goal to have minimal Javadoc for the 0.2.0 release. In that release, Nullable is the only option to mark something, right?

I figured we would not want to accidentally imply that using some @NullAlwaysOk or @PolyNull or even @other.Nullable instead is wrong.
(My argument probably means there's a slight problem with the link that goes the other way, too. )
But it's also true that saying "typically with Nullable" or "for example with Nullable" makes readers scratch their heads and look for what else we seem to be hinting at.
Maybe something like
", unless marked otherwise (we provide @Nullable for that purpose)."
I don't know if I love that. Also the more we put here the less readers will know what "these types usages" is referring to in the following sentence, maybe.

I reworded a bit and added (or checker-specific other annotations).
That makes the relationship between the JSpecify annotations clear and highlights that individual checkers might add extra annotations. Is this better?

Thanks, I accept this as a step forward and will keep thinking.


Add level 1 routine sscal

Resolves #264 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines, including the relevant style guides.
[x] Read and understand the Code of Conduct.
[x] Read and understood the licensing terms.
[x] Searched for existing issues and pull requests before submitting this pull request.
[x] Filed an issue (or an issue already existed) prior to submitting this pull request.
[x] Rebased onto latest develop.
[x] Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request adds the initial implementation of @stdlib/blas/base/sscal.  WASM and native glue code not implemented yet.
Related Issues

Does this pull request have any related issues?

This pull request:

resolves #264

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

Sorry it took me so long to get this written.

Awesome, thanks so much for your continued contributions!

Thanks guys for catching my errors.  I'm glad to help.
Looks like I made a mistake also using saxpy as a reference since it's a bit outdated.  I'll keep in mind to use ddot as an example the future.


FPORT: Maven compatibility changes + Adds CompatibilityWarningOptions

Forward port of:

https://github.com/sbt/sbt/pull/2345
https://github.com/sbt/sbt/pull/2407

These need to go in together since librarymanagement has both forward ported already.

We set dependency-management/pom-type to pending in #2478 and now it says it's passing. Maybe this test is kind of flaky since I don't think the change introduced in this PR.


import_scoped_meta_graph() got an unexpected keyword argument 'return_elements'

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow version (use command below): 1.7.0
Python version: 3.6.3
CUDA/cuDNN version: CUDA/9.0

Describe the problem
trans, = tf.train.import_meta_graph('./Model/DehazeNet_model_1gpu.ckpt.meta'                                                            , input_map={'batch:0': X} , return_elements=['clip_by_value:0'])
there raise the error: TypeError: import_scoped_meta_graph() got an unexpected keyword argument 'return_elements'
if the keyword argument 'return_elements' in import_scoped_meta_graph()  has been removed in 1.7.0 ?

I don't think return_elements has ever been supported in import_meta_graph. Are you thinking of import_graph_def?

Nagging Assignee @jart: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Could you provide a stack trace? How was DehazeNet_model_1gpu created?

It has been 22 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 37 days with no activity and the awaiting response label was assigned. Is this still an issue?


Evaluation metric

Hi, can you share the code for evaluating the model on metrics like FID and LPIPS?
Currently I'm using the FID and LPIPS results from ArtFID, but not sure if this matches yours.

Hello, the pre-training weights landscape2art provided by the author are no longer valid, can you help me? Provide that weight. Thank you!


Build config.json for IG for the production deployment to relenvs

Review prod config, PR: https://github.com/SecureApiGateway/secure-api-gateway-ob-uk/pull/336 has disabled the Test Trusted Directory. This configuration is hardcoded, for dev we use an environment variable to control it.
Review if there's a use case for running the test trusted directory with IG in production mode


AttributeError: 'State' object has no attribute 'output_ids_decoded'

Hello.
Thank you for sharing your nice work!
I encountered an issue when I ran this command as follows:
python app.py --model_name_or_path Intel/llava-gemma-2b --load_8bit  --port 8080

Traceback (most recent call last):
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/route_utils.py", line 288, in call_process_api
    output = await app.get_blocks().process_api(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/blocks.py", line 1931, in process_api
    result = await self.call_function(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/blocks.py", line 1516, in call_function
    prediction = await anyio.to_thread.run_sync(  # type: ignore
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2177, in run_sync_in_worker_thread
    return await future
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 859, in run
    result = context.run(func, *args)
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/utils.py", line 826, in wrapper
    response = f(*args, **kwargs)
  File "/SSD2/guest/jdgon/lvlm-interpret/utils_attn.py", line 68, in attn_update_slider
    fn_attention = state.attention_key + '_attn.pt'
AttributeError: 'State' object has no attribute 'attention_key'
Traceback (most recent call last):
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/route_utils.py", line 288, in call_process_api
    output = await app.get_blocks().process_api(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/blocks.py", line 1931, in process_api
    result = await self.call_function(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/blocks.py", line 1516, in call_function
    prediction = await anyio.to_thread.run_sync(  # type: ignore
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2177, in run_sync_in_worker_thread
    return await future
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 859, in run
    result = context.run(func, *args)
  File "/home/guest/.conda/envs/lvlm_inter/lib/python3.10/site-packages/gradio/utils.py", line 826, in wrapper
    response = f(*args, **kwargs)
  File "/SSD2/guest/jdgon/lvlm-interpret/utils_causal_discovery.py", line 46, in causality_update_dropdown
    generated_text = state.output_ids_decoded
AttributeError: 'State' object has no attribute 'output_ids_decoded'

I just uploaded the image and input the text ("Describe this image as detailed as possible")
I'm looking forward to hearing from you as soon
Thank you

Single GPU inference solved it.
Thank you !

I've encountered the same issue. Could you explain what might be causing this and how to resolve it? I'm indeed running the experiment on a single GPU, and I'm still experiencing this problem.

I've encountered the same issue. Could you explain what might be causing this and how to resolve it? I'm indeed running the experiment on a single GPU, and I'm still experiencing this problem.

Hello
At what stage did an error occur?

Thank you for your prompt response. I found that reinstalling the conda environment resolved the issue.
---Original---
From: "Donggon @.>
Date: Thu, Aug 22, 2024 17:59 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [IntelLabs/lvlm-interpret] AttributeError: 'State' object has noattribute 'output_ids_decoded' (Issue #6)
I've encountered the same issue. Could you explain what might be causing this and how to resolve it? I'm indeed running the experiment on a single GPU, and I'm still experiencing this problem.
Hello
At what stage did an error occur?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Thank you for your prompt response. I found that reinstalling the conda environment resolved the issue.
…
---Original--- From: "Donggon @.> Date: Thu, Aug 22, 2024 17:59 PM To: @.>; Cc<EMAIL_ADDRESS>Subject: Re: [IntelLabs/lvlm-interpret] AttributeError: 'State' object has noattribute 'output_ids_decoded' (Issue #6) I've encountered the same issue. Could you explain what might be causing this and how to resolve it? I'm indeed running the experiment on a single GPU, and I'm still experiencing this problem. Hello At what stage did an error occur? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Hi, could you share the information about your environment? Thanks!


stream output miss first text

use the code:
GeminiClient::for_each_async(json_stream, move |response: GeminiResponse| async move {
println!(
"{}",
response.candidates[0].content.parts[0]
.text
.clone()
.unwrap()
.as_str()
);
})
output  miss first text:

this is the aistudio output:

try a lot of example ,the problem continue

Thanks, I'll investigate when I get time over the weekend.

Hi, @xmlandroid, I cannot replicate this in any way. I always see all of the response from the API.
So I can help you further, can you give more techical details on your usage? Please include:

version of crate
whether the 'beta' features are enabled
whether this is using the open API or using Vertex
A more comprehensive listing of the code you are using to fetch/process the response.

I find the problem is when I use serde_json::from_string convert the Value to GeminiResponse the first chunk will return Err not Ok

other  chunk is ok，just the first Gemini return  struct is different ,convert the value to GeminiResponse get Err

By the way, do you have any examples of conversations with pictures?


Underscores are not visible when renaming variables

Does this issue occur when all extensions are disabled?: Yes

Version: 1.74.0
Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91
Date: 2022-12-05T16:47:18.476Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.19.0-26-generic
Sandboxed: No
Steps to Reproduce:

Create a variable with an underscore
Press F2 to rename
Zoom out using Ctrl + -

I'm pretty sure this was working in the previous update.
Screencast from 2023-01-06 13-37-34.webm

I tried bisecting with vscode-bisect and all builds that I tried were suffering from this issue. So I think this might not be a regression after all, though I'm not sure how old the oldest build was that I tried.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

If anyone stumbles upon this, I think this is a duplicate of #53666


GPTJ ran on CUDAExecutionProvider after O4 optimization yields Shape mismatch attempting to re-use buffer

System Info
optimum dev
onnxruntime-gpu 1.14.0

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
it is the only one to fail so kind of weird.
Remove the skipped test https://github.com/huggingface/optimum/blob/463eced7e565546e9b1aa7a1d45939b949b20cc5/tests/onnxruntime/test_optimization.py#L373 and run
pytest tests/onnxruntime/test_optimization.py -k "test_optimization_levels_gpu and gptj" -s

Expected behavior
No error.

Probably related: https://github.com/microsoft/onnxruntime/issues/14582

Fixed with https://github.com/huggingface/optimum/pull/871


How to configurate network bridge

Currently this is not supported, This can be done, but for that I need to port more stuff, feasibility of which is still unknown


Fix stacked avatar is transparent when long press on Android

Details

When long pressing the LHN or search item with stacked avatars, the second avatar will be transparent. This only happens on Android.
Fixed Issues

$ https://github.com/Expensify/App/issues/27396
PROPOSAL: https://github.com/Expensify/App/issues/27396#issuecomment-1719637570
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open the app
In LHN, long press/hold down any chat with multiple/stacked avatars (could be IOU report, policy expense chat, etc.)
Verify the second avatar is not transparent
Open search page
Repeat step 2-3 in the search page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/50919443/708554b0-eb5d-4042-9317-917849aef45c

Mobile Web - Chrome

https://github.com/Expensify/App/assets/50919443/0a515884-8773-4159-80a9-ebc6fa155d54

Mobile Web - Safari

https://github.com/Expensify/App/assets/50919443/43fe6b4f-64b0-4486-ad72-7dc94a9350fa

Desktop

https://github.com/Expensify/App/assets/50919443/5fc3557f-7d67-4cac-827d-fb6abfefcad1

iOS

https://github.com/Expensify/App/assets/50919443/86f367a4-ba6f-4db5-a630-5aa68189d4ae

Android

https://github.com/Expensify/App/assets/50919443/35543d4e-0e2e-45cd-8741-1f5541ce1d49

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/2f9f7278-8161-4832-8501-5d2c48801764

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/af2da896-ccee-4280-a281-87c7ef907f54

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/9f3be748-b87f-4a4b-a70e-07304e0954fc

Desktop
https://github.com/Expensify/App/assets/28352309/28b1e45a-823d-4e1e-8b1a-2fd096800399

iOS
https://github.com/Expensify/App/assets/28352309/94e7e0c6-9ef5-444b-a22f-defaf087d540

Android
https://github.com/Expensify/App/assets/28352309/d458ab50-8067-4191-8d22-bc6b085530cf

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Set cache control headers on asset requests

Fixes #292

!merge

Would this get set on assets served locally (e.g. non-hashed development files)?

No - we serve those via webpack-dev-middleware so we can serve directly from memory


XMLHttpRequest error

I've tested my Sendgrid parameters with Postman: they work fine.
However, in Flutter for web, these generate an XMLHttpRequest error, using the readme example.
Is this related with the fact that my prototype is currently working in localhost?

Hey @yakou32
This is an issue with CORS on browsers.
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
In order to interact with external APIs directly from the browser, you're going to have to make the calls from your own web server.
You could also disable CORS on your browser for testing, however this not feasible for production apps

Can you explain a little more how to solve this problem, I have the same
`Error: XMLHttpRequest error.
dart-sdk/lib/_internal/js_dev_runtime/patch/core_patch.dart 906:28                get current
packages/http/src/browser_client.dart 71:22
dart-sdk/lib/async/zone.dart 1612:54                                              runUnary
dart-sdk/lib/async/future_impl.dart 152:18                                        handleValue
dart-sdk/lib/async/future_impl.dart 704:44                                        handleValueCallback
dart-sdk/lib/async/future_impl.dart 733:13                                        _propagateToListeners
dart-sdk/lib/async/future_impl.dart 530:7                                         [_complete]
dart-sdk/lib/async/stream_pipe.dart 61:11                                         _cancelAndValue
dart-sdk/lib/async/stream.dart 1219:7
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39  dcall
dart-sdk/lib/html/dart2js/html_dart2js.dart 37307:58
at Object.createErrorWithStack (http://localhost:53472/dart_sdk.js:5044:12)
at Object._rethrow (http://localhost:53472/dart_sdk.js:37476:16)
at async._AsyncCallbackEntry.new.callback (http://localhost:53472/dart_sdk.js:37472:13)
at Object._microtaskLoop (http://localhost:53472/dart_sdk.js:37332:13)
at _startMicrotaskLoop (http://localhost:53472/dart_sdk.js:37338:13)
at http://localhost:53472/dart_sdk.js:33109:9`

I'm not a specialist...
In my understanding, this kind of error is caused by the fact that your project is developed locally. Therefore, you are trying to send an email from your localhost. This is restricted by the browsers (CORS).
Actually, I didn't find any solution to solve this, but to test the mail sending feature online. I tried some browser plugin with no success.
It's quite cumbersome for my development process, and I would gladly appreciate any advise to address this kind of issue...

Hey now I found how to remove CORS and debug easily SOLUTION

@dylanshine Pleas help me I still have this issue. I am using the Firebase Hosting to deploy the website and so i tried adding
this code to firebase.json
"headers": [ {
      "source" : "**",
      "headers" : [ {
        "key" : "Access-Control-Allow-Origin",
        "value" : "*"
      } ]
    }]

But nothing works. Any solution?

@kekko7072 Are you still making the request from the Flutter application in the browser?

application

Yes I don't know how to make the differently... What should I use? Functions?
Can you give me an example thank you so much!

@kekko7072, the package listing the auto-generates on Pub.dev makes this library misleading for Flutter Web. Essentially for security reasons, you can't make external requests to outside resources within a browser. What I suggest you do is create a Firebase function that calls the https://docs.sendgrid.com/api-reference/mail-send/mail-send API directly, then within your Flutter Web application, simply invoke that function.

@kekko7072, the package listing that auto-generates on Pub.dev makes this library misleading for Flutter Web. Essentially for security reasons, you can't make external requests to outside resources within a browser. What I suggest you do is create a Firebase function that calls the https://docs.sendgrid.com/api-reference/mail-send/mail-send API directly, then within your Flutter Web application, simply invoke that function.

Thank you so much I created a Firebase Function and invoke it if platform is web and now it works perfectly. I think should be added to the description of the plugin to help the spead. if you want this is my typescript code.
import * as functions from "firebase-functions";

import sgMail = require("@sendgrid/mail");
sgMail.setApiKey("API KEY"
);
exports.request = functions.https.onCall(async (req, context) => {
  sgMail
    .send({
      to: req.to,
      from: req.sender,
      subject: req.subject,
      cc: req.ccList,
      content: [
        {
          type: "text/plain",
          value: req.content,
        },
      ],
    })
    .then(
      (result) => {},
      (err) => {
        throw new functions.https.HttpsError(
          "invalid-argument",
          err.response.body
        );
      }
    );
});

@kekko7072 Make a pull request detailing this in the READ.ME and I'd be more than happy to add it

@kekko7072, the package listing that auto-generates on Pub.dev makes this library misleading for Flutter Web. Essentially for security reasons, you can't make external requests to outside resources within a browser. What I suggest you do is create a Firebase function that calls the https://docs.sendgrid.com/api-reference/mail-send/mail-send API directly, then within your Flutter Web application, simply invoke that function.

Thank you so much I created a Firebase Function and invoke it if platform is web and now it works perfectly. I think should be added to the description of the plugin to help the spead. if you want this is my typescript code:
import * as functions from "firebase-functions";

import sgMail = require("@sendgrid/mail");
sgMail.setApiKey("API KEY"
);
exports.request = functions.https.onCall(async (req, context) => {
  sgMail
    .send({
      to: req.to,
      from: req.sender,
      subject: req.subject,
      cc: req.ccList,
      content: [
        {
          type: "text/plain",
          value: req.content,
        },
      ],
    })
    .then(
      (result) => {},
      (err) => {
        throw new functions.https.HttpsError(
          "invalid-argument",
          err.response.body
        );
      }
    );
});

Hey @yakou32
This is an issue with CORS on browsers. https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
In order to interact with external APIs directly from the browser, you're going to have to make the calls from your own web server.
You could also disable CORS on your browser for testing, however this not feasible for production apps

If everything works fine, when we try from the backend(server). Than why in the whole world, this service is given as a flutter library? When it does not works with frontend? What is the use of this SDK?

It works for ios, android, linux, windows and mac...just not web.

Exactly, then why does it claim to support for WEB(in pub.dev)?
Thanks & Regards,
Mayur Saini,
Software Engineer

From: Dylan Shine @.>
Sent: 08 February 2024 05:11
To: dylanshine/sendgrid_mailer @.>
Cc: Mayur Saini @.>; Comment @.>
Subject: Re: [dylanshine/sendgrid_mailer] XMLHttpRequest error (#7)
It works for ios, android, linux, windows and mac...just not web.
—
Reply to this email directly, view it on GitHubhttps://github.com/dylanshine/sendgrid_mailer/issues/7#issuecomment-1933121263, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5EXDQ7NILKJZMEQJC47MBDYSQGJTAVCNFSM4Z6MCNL2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJTGMYTEMJSGYZQ.
You are receiving this because you commented.Message ID: @.***>


Clean finished threads in Group::Spawner.

This is my attempt to fix #670

I will review this and test it. Thanks for the PR here.

So far I am very happy you patched this, and like what I see. My only concerns are to make sure the test is sufficient to cover all scenarios, which on first glance it seems to be... and wondering if the cleanup at shutdown ought to happen inside the synchronize block or not. I will merge this and make any needed tweaks but otherwise the behavior seems correct.

Some comments on why I had to change shutdown code exactly this way:

removed Queue usage in favor of simple array because there's no inter-thread communication in which Queue is helpful.
extracting join call out of synchronize there were two reasons: 1) there's simply no need in this since @mutex is aimed to guard only @group  destruction. 2) since i used synchronize inside thread too there's a possible deadlock calling join on this thread inside of another synchronize — and even some tests with sleep were failing until I resolved this deadlock.

I thought you might be avoiding mutex deadlocking, understood.

There is a race condition in the test, on rbx

@digitalextremist I can't reproduce it on my computer but I understand how it's possible. Attempted to fix it in #679
Sorry for inattention, I should had write this spec just like the rest in spec/shared/group_examples.rb.

Your #679 PR is perfect. Thank you


License in Swagger UI

Description
License in Swagger UI
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

/approve


Use Redux in React components

Keep state immutable in reducers!
Change the book reducer's default state from an empty array to an array with a few books.
Import Redux Provider and the store in the main component of the React app.
Connect the app to the Redux store.
Make sure that list of books displays books from the Redux store.

Use useSelector to consume the state.

In the React component responsible for adding new books, add functionality for "Add new" button click:

Import Redux useDispatch.
Set the data inputs in the local React state (set title and author)
Takes the inputs from the state and generate a unique id and add them to an object.
Dispatch a corresponding action once the new book object is ready to be submitted to Redux store.

In the React component responsible for removing books, add functionality for the "Remove" button click:

Import Redux useDispatch.
Dispatch a corresponding action

In the React component responsible for categories, add a functionality for "Check status" button click:

Import Redux useDispatch.
Dispatch a corresponding action

Thank you @ahmetbozaci.


fix: keep custom http client with converter

fix https://github.com/supabase/supabase-flutter/issues/271

Great call, I simplified other cases as well.


Formatting of pandas expressions suboptimal for readability

Arguing with the formatting decisions of black may be besides the point, but I am pretty happy with it with the exception of one type of expressions:
        trend = matching_items.groupby(pandas.Grouper(key="ERDAT", freq=timeframe))[
            "KWMENG"
        ].sum()

This is a typical pandas expression where some method calls are chained and fields of the dataframe are selected. Black seems to treat the field selection as a list and indents it on a new line. I think this is counterintuitive and does not improve readability. Is it intentional or a potential enhancement to treat this differently?
Operating system: macOS
Python version:  3.7.0
Black version: '18.9b0'

Let's keep the discussion in #571


'Create data' is running in the CPU

I downloaded the entire NuScenes dataset and am trying to create the data for the package.
When I checked the CPU and the GPU usage the CPU Usage seems very high and the GPU seems to be not used. Further the processing (or training) has been going on about two hours in the time of writing.
Images Uploaded:

CPU Usage
Training Image
GPU Usage

When I checked the CPU and the GPU usage the CPU Usage seems very high and the GPU seems to be not used. Further, the processing (or training) has been going on for about two hours in the time of writing.
Now, it is generating the gt database. All the operations (mainly write files to disk) indeed happens on the CPU. A few hours seems reasonable.

Took 11 hours but it worked...thanks

tbh It mainly depends on the disk speed. It is less than 1 hr on our side


Add onFidesEvent method for an alternative way to subscribe to Fides events

Description Of Changes
This PR adds an onFidesEvent method to the global Fides object that subscribes the callback to Fides events. This is equivalent to calling window.addEventListener(...) yourself, except that the callback receives the FidesEventDetail object instead of a CustomEvent. This is needed for the Google Tag Manager template integration as it doesn't allow usage of APIs like addEventListener and also doesn't support CustomEvent or, really, any other non-primitive type.
See this Slack thread for the rationale.
Code Changes

[x] Add onFidesEvent method to fides.ts and fides-tcf.ts

Steps to Confirm

Load the new fides.js version on a page
Make sure Fides.onFidesEvent is available
Call it with a handler (e.g. console.log), trigger the event and verify that the handler was called

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
[x] Update CHANGELOG.md

Btw, there's an issue with typedoc where adding a @returns tag will remove the description so I opted to keep it instead.


Upgrade to whitenoise 5.0.1 is throwing error #155

Describe the bug
After upgrading to 2019.3.4 which includes https://github.com/latenighttales/alcali/pull/155 whitenoise gets updated to 5.0.1.
When that happens, I see the following error in the alcali logs which eventually produce a 501 and the UI never comes up:
Feb 14 10:18:34 ip-10-3-2-225 alcali: /usr/local/lib/python3.6/site-packages/whitenoise/base.py:116: UserWarning: No directory at: /usr/local/lib/python3.6/site-packages/dist/static/
Feb 14 10:18:34 ip-10-3-2-225 alcali: warnings.warn(u"No directory at: {}".format(root))

To Reproduce
Steps to reproduce the behavior:

Upgrade to 2019.3.4 and watch whitenoise being updated to 5.0.1
Restart alcali
Just try to hit the main page
See error

Expected behavior
UI should come up.
Desktop (please complete the following information):

OS: macOS Mojave
Browser Chrome
Version 79.0.3945.130

Additional context
I've installed alcali from pypi, so I'm not sure if I maybe missing another package to fix this.
I found https://github.com/uktrade/data-hub-api/pull/1157 but this was fixed a long time ago.

this was a tough one.
dist/__init__.py was removed so when packaging the wheel, MANIFEST.in dist directory was ignored.
If you upgrade it should be fine now.


Google compute image

Motivation for this change
This makes NixOS a first-class citizen on the Google Cloud Platform, allowing to integrate with the dynamic features of the platform.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

LGTM except for patchPath stuff

using ./nixos/maintainers/scripts/gce/create-gce.sh to build a gce image fails with:
Adding rules for package /nix/store/p7sm83r55gj4bl55k4pz794dsg6mxrny-extra-udev-rules
Copying /nix/store/p7sm83r55gj4bl55k4pz794dsg6mxrny-extra-udev-rules/etc/udev/rules.d/99-local.rules to /nix/store/llwyl34sl8ncrpxa7f3l49q8bhd98bns-udev-rules/99-local.rules
Adding rules for package /nix/store/0pg85agkcjsz82b36kf4pzd87mm39iic-extra-hwdb-file
Checking that all programs called by relative paths in udev rules exist in /nix/store/rsilqxrxl6vcgd77ry4jd68a5jiwjnaw-systemd-232/lib/udev... OK
Checking that all programs called by absolute paths in udev rules exist... FAIL
/var/run/current-system/sw/bin/sh is called in udev rules but not installed by udev
building path(s) ‘/nix/store/708w74szmavanm8mg69wbyjzcgn2bjaq-initrd’
building path(s) ‘/nix/store/nnq72hiq4kxryj9qi6izw1k2lz0c4csx-unit-google-startup-scripts.service’
building path(s) ‘/nix/store/ic90njrpva2840xf3yjf2k3fayj4v038-unit-script’
building path(s) ‘/nix/store/ivv5qyznk4rc9k6qp1v3ii5qg50bbw9m-unit-script’
building path(s) ‘/nix/store/knq7r3b04lc6jq88gi92a47grxq3niaj-unit-script’
building path(s) ‘/nix/store/ckg4g12gsps10awy3g29mv1c3l654xhk-unit-serial-getty-hvc0.service-disabled’
building path(s) ‘/nix/store/bbqib7f8j403ksr8fxpsg2simv7wv3l1-unit-serial-getty-ttyS0.service-disabled’
builder for ‘/nix/store/fafg91y4w6lm66jlq5r02q0ws8yiz3ay-udev-rules.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/1ga1lv36g7x9mfzwpam79499d511ylaa-etc.drv’: 1 dependencies couldn't be built
building path(s) ‘/nix/store/4cla2f0v95j02rw32abqib4j25vk7zzv-vm-run-stage2’
cannot build derivation ‘/nix/store/9r34z9lgrhxrqqdn7v4fcpbma89cym6l-nixos-system-unnamed-17.09.git.c1ef0ed.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/c8dxf2010n9hs45zzivkyc4qh4cxp9by-google-compute-image.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/c8dxf2010n9hs45zzivkyc4qh4cxp9by-google-compute-image.drv’ failed

How does the google compute engine tool behave when you chose not to allow mutableUsers? Is it possible to disable anything related to creating users in the tool? If so, can we implement that depending on the mutableUsers config option?

How does the google compute engine tool behave when you chose not to allow mutableUsers? Is it possible to disable anything related to creating users in the tool? If so, can we implement that depending on the mutableUsers config option?

Good idea. I could not start the google-accounts-daemon is mutableUsers = false. In that case the nixos configuration would be provisioned through the metadata startup-script and would have to contain the SSH keys.
There is still work to do on this PR but thanks everyone for your feedback. I will let you know when it's ready for another round of review.

Good idea. I could not start the google-accounts-daemon is mutableUsers = false. In that case the nixos configuration would be provisioned through the metadata startup-script and would have to contain the SSH keys.

What do you mean with 'through the metadata startup-script'? I am mostly interested in if this is backwards compatible with nixops.

What do you mean with 'through the metadata startup-script'? I am mostly interested in if this is backwards compatible with nixops.

Okay we need to have a bit of a conversation because right now it breaks backward-compatibility. Potentially I could leave the fetch-ssh-keys service and provide a migration path for future nixops release. Do you know how SSH keys are being provisioned with nixops?

Fixed all the things and left the fetch-ssh-keys daemon for nixops back-compat as both can live side-by-side.
I don't have a clear idea of what to do with the mutableUsers option yet as this module is not really meant to be designed to be configurable in the first place.

Potentially I could leave the fetch-ssh-keys service and provide a migration path for future nixops release. Do you know how SSH keys are being provisioned with nixops?

For EC2 at least, we left two options in place, so that the userdata could be used in two different ways for NixOps and for non-NixOps use cases. It would be nice to converge Google and EC2 behavior, so you can also configure Google Compute machines via userdata.

What's the status of this?

@8573 it's missing a corner-case where mutableUsers = true. Otherwise it's pretty stable.

Okay; I don't understand GCE enough to help, so I'll wait. Thanks!

Alright, the account service is now disabled if users.mutableUsers = false

I think the solution is reasonable right now. Let me know if you hit any issues.


Add ability to default to specific invoice type

Would be nice if we could add the option to default to unified vs LN vs on-chain
requested by @gkrizek

Closed by #556


runtime: fix strict "= VERSION" dependencies for deb pkg

When specifying a "Depends: (= VERSION" match in deb packages, the full
"VERSION" needs to be specified, including any trailing release number.
A more relaxed alternative to this, without knowing the full version
of dependencies, is to specify each dependency as both ">= VERSION" and
"<< VERSION+1".
This fixes a regression introduced in: 63413814
Fixes: #531
Signed-off-by: Marco Vedovati<EMAIL_ADDRESS>

build using this PR: https://dev.azure.com/vmjcarlos/kata-containers/_releaseProgress?_a=release-pipeline-progress&releaseId=78

Source: kata-runtime
Section: devel
Priority: optional
Maintainer: Kata containers team <https://github.com/kata-containers/>
Standards-Version: 3.9.6
Homepage: https://katacontainers.io
Build-Depends: dh-make, git, ca-certificates, execstack, devscripts, debhelper,
               build-essential, dh-autoreconf, make

Package: kata-runtime
Architecture: amd64
Depends: kata-containers-image (>= 1.7.0), kata-containers-image (<< 1.7.1),
         kata-linux-container (>= <IP_ADDRESS>), kata-linux-container (<< <IP_ADDRESS>),
         kata-proxy (>= 1.7.0), kata-proxy (<< 1.7.1),
         kata-shim (>= 1.7.0), kata-shim (<< 1.7.1),
         kata-ksm-throttler(>= 1.7.0), kata-ksm-throttler(<< 1.7.1),
         qemu-lite(>= 2.11.0+git.87517afd72) [amd64], qemu-lite(<< 2.11.1) [amd64],
         qemu-vanilla(>= 2.11.2+git.0982a56a55), qemu-vanilla(<< 2.11.3)
Description:
 An Open Containers Initiative (OCI) "runtime" that launches an Intel VT-x
 secured Kata Containers hypervisor, rather than a standard Linux container.

https://build.opensuse.org/package/rdiff/home:katacontainers:releases:x86_64:alpha/runtime?linkrev=base&rev=18

@marcov - I'm not sure I really understand this. A few questions:

Why is it that we can specify an exact (=) version dependency for rpms but not for debs?
All the runtime dependencies are controlled by us, so why can't we just specify the full release in the dependency (with the trailing release number)?
I'm not sure the logic on this PR is going to be reliable. Looking at https://semver.org/, wouldn't it fail for versions like 1.0.0-beta.2 and 1.0.0-beta+exp.sha.5114f85?

Why is it that we can specify an exact (=) version dependency for rpms but not for debs?

Because the way they handle dependency check is different, and stricter on deb.
With rpm, something like this works:
# zypper in 'kata-runtime=1.7.0'

With deb instead, you need to include the release
# apt-get install kata-runtime=1.7.0-34

All the runtime dependencies are controlled by us, so why can't we just specify the full release in the dependency (with the trailing release number)?

This would be a more logic way to do it. Let's call this PR an RFC-PR :)
That would require quite more work and making sure that runtime package source are generated only after all the other packages. Also, a change in the release number of any other package would force the runtime to be re-generated, too.

I'm not sure the logic on this PR is going to be reliable. Looking at https://semver.org/, wouldn't it fail for versions like 1.0.0-beta.2 and 1.0.0-beta+exp.sha.5114f85?

Good point :flushed:  This can be fixed to only use PATCH leading digits, though.
Note that the "next" version is generated from how we call our kata releases, so:

the trailing +git.... it's not included.
the trailing -rc , -alpha should be handled properly.

@marcov could you please rebase this PR? thanks

Thanks @GabyCT, I've rebased.
@jodh-intel I've thought about this more, and switched to do what you also proposed, i.e. include the release number in the dependency version.
/cc @jcvenegas

/test

/test


Add shell completion

Description
Adds a completion subcommand to grofer, which adds the ability to generate completion scripts for bash, zsh, fish and powershell
Fixes #39
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Checklist:

[X] I have read the contribution guidelines and followed it as far as possible.
[X] I have performed a self-review of my own code (if applicable)
[ ] I have commented my code, particularly in hard-to-understand areas (if applicable)
[X] I have run go fmt on my code (reference)
[ ] I have made corresponding changes to the documentation (if applicable)
[X] My changes generate no new warnings
[ ] Any dependent and pending changes have been merged and published

Done

Looks like its still failing on the license check?

Looks like its still failing on the license check?

For some reason it's still building the previous commit. I'll look into this.

@anihm136 The license check is failing because you seem to have extra white space on line number 8. I'd suggest you copy the license straight from the license checking script in scripts/license_check.py to avoid this weird issue.

Done

@anihm136 This is perfect! I'll wait for @MadhavJivrajani or @metonymic-smokey to approve and merge.


DOC: Make UP006 easier to find

This change makes it easier to understand what UP006 is about. It also makes it easier  to find the rule when you only know the effect, but not the PEP.

These Markdown tables in the README are autogenerated from our format strings in the Rust code and we don't want to change that format string to Use `dict` / `list` instead of `typing.Dict / typing.List` for type annotations since it would make the actual error messages less descriptive.
You are correct to note that the error format strings often aren't easy to understand. However we want to address this by introducing more thorough documentation #1467, rather than hardcoding specific values in our format strings.

Makes sense to me :-) I'm closing this as it's included in #1467. However, #1467 is pretty general. It would be nice to doc a single example rule well and then let the community help with following that example

Yes I agree :) However we firstly have to set up the documentation system ... we haven't done so yet since we're currently focusing on other issues but it's very much on our minds and the roadmap.

Want this to get much better!


Remove registrationId and senderId from sharedPrefs on unregister

I'm suggesting we add the following to PushPlugin.java at line 127.
SharedPreferences sharedPref = getApplicationContext().getSharedPreferences(COM_ADOBE_PHONEGAP_PUSH, Context.MODE_PRIVATE);
SharedPreferences.Editor editor = sharedPref.edit();
editor.remove(REGISTRATION_ID);
editor.remove(SENDER_ID);
editor.commit();

Without this, if you unregister and then initialize, it will return an old registrationId not associated with any instanceId. You'll be in a weird state that the application will think it's registered but it's not. That's due to this logical block on register:
if ("".equals(savedSenderID) && "".equals(savedRegID)) {
  token = InstanceID.getInstance(getApplicationContext()).getToken(senderID, GCM);
}
 // new sender ID, re-register
else if (!savedSenderID.equals(senderID)) {
  token = InstanceID.getInstance(getApplicationContext()).getToken(senderID, GCM);
}
// use the saved one
else {
  token = sharedPref.getString(REGISTRATION_ID, "");
}

I'm adding this to my fork because some strange reason, I'm getting an emtpy string "" for a registrationId upon initialization of the plugin (See #295). Regardless, my work around is to unregister if I didn't receive an actual registrationId and then re-register. However, without the code above, it will just fallback to old, outdated registrationId - in my case an empty string.

@kentmw it's a duplicate of #291 which I'm already working on.

@macdonst, seriously just saw that issue moments after typing all this up...


make mat-step-header header scrollable

Please describe the feature you would like to request.
I would like to see the mat-step-header made scrollable in a similar fashion to mat-tab.  IOf you have multiple steps on a smaller resolution or inside a container with a specific width the steps simply overflow over the edge and would be better if you have a left/right scroll button on either side of the header like the mat-tab
What is the use-case or motivation for this proposal?
I have several apps that use the material stepper (specifically the horizontal stepper) where there are many steps in the flow, the stepper is usually displayed inside a mat-card with a specific width (responsive to difference screen sizes)
On smaller screen sizes where there are more steps than permitted on the screen the step headers simply overflow off the screen
Is there anything else we should know?
This is a screen shot of one example on a large mobile (width: 425px)

The same thing is a P5 here #12166. This feature is pretty important. They have done a GOOD JOB.

Have you found any work around for this @StickNitro ?
I am having around 10 steps and facing same issue !

I found a workaround, add this style to your code
.mat-horizontal-stepper-header-container
{
  overflow: auto;
}
.mat-horizontal-stepper-header
{
  min-width: fit-content;
}

See the working example here: Stackblitz
(In this example I put the CSS code in the main style file. However, in a real project you can put in under to component styles)

I found a workaround, add this style to your code
.mat-horizontal-stepper-header-container
{
  overflow-x: auto;
}
.mat-horizontal-stepper-header
{
  min-width: fit-content;
}

See the working example here: Stackblitz (In this example I put the CSS code in the main style file. However, in a real project you can put in under to component styles)

Only works i think at styles.scss, I've tried at component level even with !importat doesn´t works


Fix typo in NestedGroups doc

This change aims to fix just a typo in the RSpec/NestedGroups document.
See https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecnestedgroups

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Updated documentation.
[ ] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged in config/default.yml to the next major version.

Thanks!


Update pipeline

Codecov Report

Merging #1230 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1230   +/-   ##
======================================
  Coverage    3.85%   3.85%
======================================
  Files          35      35
  Lines       18097   18097
======================================
  Hits          698     698
  Misses      17273   17273
  Partials      126     126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72a290...ea93e2c. Read the comment docs.


Clean up Helm RBAC rules

~Fixes #10883 .~
~As of k8s v1.9, extensions is deprecated in favor of apps.~
~Another k8s issue which explains it better than I can :grin:.~
~This PR fixes the security Helm subchart to allow the istio-security-post-install Job to get/list/watch deployments.apps in addition to the existing deployments.extensions, which has been deprecated.~
As the istio-security-post-install was deleted entirely after this PR was created, I've changed the content to be a general Helm RBAC cleanup.

Considering the strange state of RBAC across all of Istio's charts (look at the Kiali ClusterRole... :confused:), I'm considering rolling a general RBAC cleanup into this PR.
But regardless, yeah, I'll add the apps apiGroup to the other ClusterRoles.

Strange, looks like this job was completely removed with f9223929, but I'll still use this PR to add apps to other rules that only reference the extensions apiGroup.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chrisob
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chrisob
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisob: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8c9bd9f364617265014ef2dfb1ba92d726a33583
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
656e1566755766242cb7db3fc9bf0b43f7508d8e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

does this have a matching master PR?
if these get in, we'll make these changes to the kiali clusterroles defined in the kiali project to keep everything in sync:  https://github.com/kiali/kiali/blob/master/deploy/kubernetes/clusterrole.yaml
I guess we'll need to test these first to make sure this commit doesn't break anything.

@jmazzitelli Apologies, this is my first contrib to Istio, and couldn't find which branch to PR against in the contrib docs.
Should I switch the base to master instead of release-1.1?

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
656e1566755766242cb7db3fc9bf0b43f7508d8e
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
9d4367f3a8430dc5071fd9a7434feb2274b0f53e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d4367f3a8430dc5071fd9a7434feb2274b0f53e
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
9d4367f3a8430dc5071fd9a7434feb2274b0f53e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Should I switch the base to master instead of release-1.1?

@chrisob I'm fairly sure release-1.1 branch has been locked down and only bug-fixes are getting in for high priority issues. I looked at the issue this fixes, and it seems like crashing a pod would be a high priority issue :-) so I wasn't sure if you go the go-ahead by someone to write this directly against the release-1.1 branch on purpose. But for sure at minimum you will want another PR to put this into the master branch. You will need a committer/approver (of which I am not) to give this release-1.1 PR the go ahead to be merged.

@jmazzitelli Indentation fixed, and thanks for the explanation PRs agasint master vs release-1.1.
Related master branch PR is #11486.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
8a845d8e5f35ee801dc2f9927d0be40613cd58f2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2e913745d66354198eee24fd6e4498f661f9b131
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
8a845d8e5f35ee801dc2f9927d0be40613cd58f2
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
8a845d8e5f35ee801dc2f9927d0be40613cd58f2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
6ac2e03464652ecaca53fb1b8983491325dc9705
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5136d5ca9772e25ff8f1df5d97916220bcea1be8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
913cbed5541328fa0b9e07d10f9afe364a69e0a5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisob: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
913cbed5541328fa0b9e07d10f9afe364a69e0a5
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
913cbed5541328fa0b9e07d10f9afe364a69e0a5
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Warning! There is a big PR going in soon that moves all subcharts back into the charts/ directory... that's going to cause a big conflicts to this PR if it gets in first. See https://github.com/istio/istio/pull/11558

@jmazzitelli thanks for the heads up, anybody in particular I should ping (@linsun @costinm maybe?) to expedite reviews of these Helm PRs?

/retest

@chrisob: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ab53c968c46cd7bb56a91f0955acd42a43a286c6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao Now that #11486 is merged, is anything preventing this one from getting in? I'd like to have this merged before #11558 if at all possible.

/LGTM
@ymesika You need to rebase https://github.com/istio/istio/pull/11558 if this gets in first.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chrisob, morvencao
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [morvencao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Looks like I still need an admin to pass the merges-blocked-needs-admin status check :sweat_smile:

ping @wenchenglu


Improve pqcrypt installation in fedora

We need to create virtual environment and install required packages in virtual environment , need to modify fedora_install.sh  and fedora_run.sh accordingly. we can use build.sh and run.sh as reference.

@Anish-M-code could you assign me this issue?

Completed by #19


Import existing branches with .dockstore.yml when registering a workflow

Is your feature request related to a problem? Please describe.
If you add a repo with branches that have a .dockstore.yml in them to Dockstore, the versions do not get read into Dockstore
Describe the solution you'd like
Configuring a GitHub app for a repo with .dockstore.yml in it should create Dockstore versions for all branches/tags with a .dockstore.yml.
Additional context
We're not doing this to avoid an expensive read the whole repo and all its branches operation.
On the other hand if there are .dockstore.yml's in the repo, they should be honored. Especially if you fork an existing repo, there will be no way to retroactively create Dockstore versions for tags, unless you delete and recreate the tags.
I wasn't able to get this working in a brief experiment, but maybe we can do something like this to know which branches to load.
┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-1364
┆Sprint: Backlog
┆Issue Type: Story

Going to wait for user requests