Add substrait tpch round trip tests from sql query

Which issue does this PR close?
I've been investigating and experimenting with federating tpch query plans and sending the federated portion downstream encoded as substrait protos (Side node, is this useful or worth sharing?).   When doing this I discovered the bug in issue #13860 .   CC @alamb @Blizzara as we discussed the PR for that issue, and your input would be appreciated here as well.
In the course of that work, I discovered that there isn't testing coverage for round trip from TPCH query -> logical plan -> substrait -> logical plan.
My understanding of how do this is the following:

generate optimized logical plan from tpch query
encode as substrait
send elsewhere
decode into logical plan
optimize this logical plan as our local table providers are different than the ones where the previous optimization was made

After this the recreated plan should be the same and produce the same result when executed.  This is my understanding from looking at tests for round trip in to substrait for arbitrary queries  from https://github.com/apache/datafusion/blob/main/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L1242-L1266
This has worked for me when federating portions of the plan, and out of curiosity I wanted to know if it works for the entire plan.   It does not work for the entire plan in most cases as these tests show.   In most cases it looks like we need to support more of the LogicalPlan nodes when serializing to substrait.
So, I've added this round trip for all TPCH queries.  I generated the TPCH queries from https://duckdb.org/docs/extensions/tpch.html.   I then generated serialized json schemas which can be loaded into a context with a fake TableProvider.
The other way I could see this happening is to skip optimization before, and compared the unoptimized plan upon deserialization for correctness.   Then optimize and execute.
I've added tests for both paths, but if the unoptimized way is not intended to work, then we can remove those.
If my understanding of how this works is correct, then these tests are probably useful.  If it is not, then I hope that conversation here can help me understand it and I'll improve the tests. 😄
Rationale for this change
More clearly highlight and identify missing features in substrait serialization.
What changes are included in this PR?
tests added
Are these changes tested?
CI will test them
Are there any user-facing changes?
No, just tests.

There are already some tests for TPCH functionality in https://github.com/apache/datafusion/blob/main/datafusion/substrait/tests/cases/consumer_integration.rs, but IMO those are weaker than what you're proposing because they only verify that we can read the TPCH plans that have been generated in https://github.com/substrait-io/consumer-testing/tree/7c1f5f1876f00c2685f722b592dbd00030662d5d/substrait_consumer/testdata/integration/tpch
The full roundtrip you're proposing is more comprehensive and lets us find bugs in both consumer and producer.

In most cases it looks like we need to support more of the LogicalPlan nodes when serializing to substrait.

It looks like your approach has already found some missing features 🐛 🔨

After this the recreated plan should be the same

In many cases plans roundtrip the same, but not necessarily in every case. DataFusion might consume a plan and then emit a plan that is semantically equivalent but has different nodes. For example, all emit kind remaps might be converted into projections. It is a desirable property that plans roundtrip the same, and probably something we can work towards in most cases.

I like the idea, more testing the better! We already have some Substrait TCP testing, but I think that's from "known Substrait" -> DF, so it only tests the consumer, while this would test the producer as well.
I think roughly there should be three levels of "equality":

a plan goes through roundtrip without crashing, but doesn't match equality (this doesn't necessarily mean the result is correct, but it shows that there aren't any totally unsupported LogicalPlan nodes)
"optimized" plan equality - calling optimize on both plans before comparing, like you do.
"unoptimized" plan equality - comparing the plans directly.

I feel like (2) should be "easier" check than (3), though the tests you have here show that some plans would pass unoptimized but not optimized, which confuses me.
Overall, I think (3) is nice to have, but not something I'd spent too much effort for - it doesn't really bring that much benefits to users compared to (2). (2) is nice compared to (1) in that it guarantees a bit more correctness, but in many cases it's unfortunately tough to support even (2) (even in theory, roundtrip isn't lossless, since multiple DF plans may result in the same Substrait plan, and the other way around too).
So I'd suggest splitting the TPCH tests into 4 categories:

those that pass (3)
those that pass (2)
those that pass (1)

maybe eyeballed into a) those that look correct after roundtrip even if the plan doesn't fully match, and b) those that look incorrect, if any

those that fail to convert for the roundtrip

That allows merging the tests, preventing regressions, and tracking needed improvements :)

Haha, looks like @vbarua commented pretty pretty much the same thing while I was writing my own reply! 😄

Thank you @vbarua and @Blizzara for your review and comments!
Yes, I think the existing tests do not go far enough, and I encountered bugs not covered by these tests already, which is why i wrote these.
I did not notice the existing schemas and sql in the benchmarks crate.  I'll look to reuse them.  Should we move them somewhere so that bench and test can access them without referring to each other?
Lastly, is it convention that we would add #[ignore] to the cases that do not pass at the moment, and open those up as we fix bugs?

Lastly, is it convention that we would add #[ignore] to the cases that do not pass at the moment, and open those up as we fix bugs?

I think that is a reasonable approach -- thank you.
Please also leave a link to the relevant github issue in the comments so future readers can find the relevant issue

(I really like the idea of merging the tests, even if they don't all pass, in one PR and then working on fixes to the tests as additional follow on PRs)


v3: setoutput is deprecated

When using py-cov-action/python-coverage-comment-action@v3 in a workflow, the follow warning is reported by Github:
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

In the v2 branch, commit https://github.com/py-cov-action/python-coverage-comment-action/commit/9c01da2f0ddbd0d6350b3d1ec93d7df0e121a21b was added to correct the issue, this appears to be missing in the v3 branch.

Thank you for reporting the problem. This is strange. Actually, this problem was also fixed for v3 in #84 and as far as I can see this problem does not exist in other runs. Is the run showing this message a bit older or is it possibly related to a specific commit in the v3 branch where the fix does not exist yet?

I think I've found and resolved the issue. I was using the actions/download-artifact@v2 and actions/upload-artifact@v2 actions in my coverage job which produced the error above (as well as NodeJS 12 deprecation errors).
I've since updated my workflow to use version 3 of both these actions and I no longer get any errors.


ActionView::Template::Error: couldn't find file 'fullcalendar' with type 'text/css'

View details in Rollbar: https://rollbar.com/trystant/BOW/items/379/

Sprockets::FileNotFound: couldn't find file 'fullcalendar' with type 'text/css'
  File "/Users/msnyon/code/EBWiki/app/assets/stylesheets/application.scss", line 16
  File<EMAIL_ADDRESS>line 64, in resolve!
  File<EMAIL_ADDRESS>line 399, in resolve
  File<EMAIL_ADDRESS>line 207, in process_require_directive
  File<EMAIL_ADDRESS>line 180, in block in process_directives
  File<EMAIL_ADDRESS>line 178, in each
  File<EMAIL_ADDRESS>line 178, in process_directives
  File<EMAIL_ADDRESS>line 83, in _call
  File<EMAIL_ADDRESS>line 68, in call
  File<EMAIL_ADDRESS>line 75, in call_processor
  File<EMAIL_ADDRESS>line 57, in block in call_processors
  File<EMAIL_ADDRESS>line 56, in reverse_each
  File<EMAIL_ADDRESS>line 56, in call_processors
  File<EMAIL_ADDRESS>line 134, in load_from_unloaded
  File<EMAIL_ADDRESS>line 60, in block in load
  File<EMAIL_ADDRESS>line 318, in fetch_asset_from_dependency_cache
  File<EMAIL_ADDRESS>line 44, in load
  File<EMAIL_ADDRESS>line 20, in block in initialize
  File<EMAIL_ADDRESS>line 47, in load
  File<EMAIL_ADDRESS>line 23, in block in call
  File<EMAIL_ADDRESS>line 183, in dfs
  File<EMAIL_ADDRESS>line 24, in call
  File<EMAIL_ADDRESS>line 75, in call_processor
  File<EMAIL_ADDRESS>line 57, in block in call_processors
  File<EMAIL_ADDRESS>line 56, in reverse_each
  File<EMAIL_ADDRESS>line 56, in call_processors
  File<EMAIL_ADDRESS>line 134, in load_from_unloaded
  File<EMAIL_ADDRESS>line 60, in block in load
  File<EMAIL_ADDRESS>line 318, in fetch_asset_from_dependency_cache
  File<EMAIL_ADDRESS>line 44, in load
  File<EMAIL_ADDRESS>line 20, in block in initialize
  File<EMAIL_ADDRESS>line 47, in load
  File<EMAIL_ADDRESS>line 66, in find_asset
  File<EMAIL_ADDRESS>line 92, in []
  File<EMAIL_ADDRESS>line 341, in find_asset
  File<EMAIL_ADDRESS>line 333, in find_debug_asset
  File<EMAIL_ADDRESS>line 216, in block in lookup_debug_asset
  File<EMAIL_ADDRESS>line 229, in block in resolve_asset
  File<EMAIL_ADDRESS>line 228, in each
  File<EMAIL_ADDRESS>line 228, in detect
  File<EMAIL_ADDRESS>line 228, in resolve_asset
  File<EMAIL_ADDRESS>line 215, in lookup_debug_asset
  File<EMAIL_ADDRESS>line 157, in block in stylesheet_link_tag
  File<EMAIL_ADDRESS>line 156, in map
  File<EMAIL_ADDRESS>line 156, in stylesheet_link_tag
  File "/Users/msnyon/code/EBWiki/app/views/layouts/application.html.erb", line 8, in _app_views_layouts_application_html_erb___1282573186304215408_70105302571240
  File<EMAIL_ADDRESS>line 145, in block in render
  File<EMAIL_ADDRESS>line 166, in instrument
  File<EMAIL_ADDRESS>line 333, in instrument
  File<EMAIL_ADDRESS>line 143, in render
  File<EMAIL_ADDRESS>line 66, in render_with_layout
  File<EMAIL_ADDRESS>

This was a development error that can be removed.


restrictedResources only works if not is an array

Describe the bug
When I call create_restricted_data_token only works when restrictedResources is called like and object, not as array.
To Reproduce
This not works:
token_res = Tokens().create_restricted_data_token(restrictedResources=[{
"method": "GET",
"path": "/orders/v0/orders",
"dataElements": ["buyerInfo", "shippingAddress"]
}
])
This works:
token_res = Tokens().create_restricted_data_token(restrictedResources={
"method": "GET",
"path": "/orders/v0/orders",
"dataElements": ["buyerInfo", "shippingAddress"]
}
)
I don't know if it is a documentation mistake o a bug in the api.

Not sure what the mixup is here, but the code you've titled as working isn't working for me, and the code that passes an array as documented works.
res = Tokens().create_restricted_data_token(restrictedResources=[
    {
        "method": "GET",
        "path": "/orders/v0/orders",
        "dataElements": ["buyerInfo", "shippingAddress"]
    }
])
print(res)

@ximo1984 does it work with the code provided?

For me only works when I call without array. Maybe it's because I don't have PII aproved and it's a amazon API Bug.
Thanks for the response.

You shouldn't get any successful response without PII access enabled?

I know, but I have a token response. But later when I try to use this token it doesn't work.

@ximo1984 have you figured out the way to successfully use the token you retrieve?

@gorskim No, I haven't. Sorry.
Maybe it's a bug and it return a token but it doesn't work because I haven't passed PII.

Getting error [{'code': 'InvalidInput', 'message': 'Application do not have access to some or all requested resource', 'details': ''}]
tokens_client = Tokens(credentials=credentials, marketplace=Marketplaces.IN)
tokenres = tokens_client.create_restricted_data_token(restrictedResources=[
     {
         "method": "GET",
         "path": "/orders/v0/orders/406-8719557-7575562",
     }
  ])

but when i pass as the object it works
tokenres = tokens_client.create_restricted_data_token(restrictedResources={
         "method": "GET",
         "path": "/orders/v0/orders/406-8719557-7575562",
     })

Any update ?

No updates, you have to pass PII to call this endpoint. I could not pass PII.


Entitas 1.4.2: Visual Debugging does not work properly at Unity 2017.3.1

@sschmid  It throws me this error when I select the system game object to see the system debugging message and the time of Execute systems all become red.
KeyNotFoundException: The given key was not present in the dictionary.
System.ThrowHelper.ThrowKeyNotFoundException () (at <c95265f74fdf4905bfb0d5a4b652216c>:0)
System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) (at <c95265f74fdf4905bfb0d5a4b652216c>:0)
DesperateDevs.Serialization.Properties.get_Item (System.String key) (at <099e51ab2dc047729b0674a5e3327d54>:0)
DesperateDevs.Serialization.Preferences.get_Item (System.String key) (at <099e51ab2dc047729b0674a5e3327d54>:0)
Entitas.VisualDebugging.Unity.Editor.VisualDebuggingConfig.get_systemWarningThreshold () (at <208de3a2d6014ccb96680dd370edf0de>:0)
Entitas.VisualDebugging.Unity.Editor.DebugSystemsInspector.OnEnable () (at <208de3a2d6014ccb96680dd370edf0de>:0)

I am using Windows 7 + Unity 2017.3.1p2 + Entitas 1.4.2. It is working fine.

Please open the Entitas preferences in Unity once and close it and see if this fixes the issue

@sschmid Still the same error but I have a interesting finding. When u keep Entitas preference window open, the error does not appear anymore and visual debugging works properly. lol

When you open the Preferences, Entitas will automatically add missing keys. Make sure your properties contain these keys
Entitas.VisualDebugging.Unity.Editor.SystemWarningThreshold = 5
Entitas.VisualDebugging.Unity.Editor.DefaultInstanceCreatorFolderPath = Assets/Editor/DefaultInstanceCreator
Entitas.VisualDebugging.Unity.Editor.TypeDrawerFolderPath = Assets/Editor/TypeDrawer

Your error says it couldn't find SystemWarningThreshold

When you open the Preferences, Entitas will automatically add missing keys. Make sure your properties contain these keys

@sschmid Yes. I have those keys included. I uploaded my UnityPreferences.properties for you to check it out.
UnityPreferences.properties.txt

Why is it called UnityPreferences, do you have multiple? If so, what does the button in the Entitas logo say?

Why is it called UnityPreferences, do you have multiple? If so, what does the button in the Entitas logo say?

@sschmid Yup. I have UnityPreferences.properties for Unity and Entitas.properties for Roslyn. I think I selected UnityPreferences.properties properly.

Ok, then I need to try to reproduce.
Maybe as a workaround (just guessing) add those keys also to the roslyn properties, maybe that helps

Maybe as a workaround (just guessing) add those keys also to the roslyn properties, maybe that helps

@sschmid Ya. Problem fixed. after adding those keys to roslyn properties I guess it still read roslyn properties file instead of UnityPreferences properties file.


Advanced load balacing rules

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
 Each instance has its own Traefik instance. All instances are behind a layer 2 load balancer, and all instances run basically the whole set of microservices.
What I want to accomplish it to make Traefik prefer routing to localhost if there's an instance of the service there, otherwise load balance to remote instances.
I can see other benefits of allowing advanced load balacing, such as geo aware failover.

Seems related to #6985


Layouts API refactored by using retrofit

Closes https://github.com/novuhq/novu-java/issues/57

Hi @mayorJAY , Please review this when you find time. Thanks much


Pawns can not do ANY job because of false check to see if they're in a bed

I included a check to see if a pawn was in a bed or not a while ago to ensure that no medical bill could be done outside of one - I've just come across an error where every single bill (not just medical ones) are prevented because we're checking if they're in a bed and they're not.

Fixed. I'm checking for a NullReferenceError and, if there is one, to just continue and ignore the next part of the script...


Initial attempt to pass account ID info as a parameter to service con…

Issue #, if available: #126
Description of changes: Added --aws-account-id config flag to manually pass in account ID. Feature work is being done as part of CARM where we will read account ID information from annotations/metadata/configMap.
Note: I will follow up another PR where I plan to add ability to read from meta-data instead of failing if --aws-acount-id flag is missing.
a483e7384446:aws-controllers-k8s nithmu$ go run services/ecr/cmd/controller/main.go --aws-account-id=123333333333
{"level":"info","ts":1596516989.31037,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":"<IP_ADDRESS>:8080"}
{"level":"info","ts":1596516989.310735,"logger":"setup","msg":"initializing service controller","aws.service":"ecr"}
{"level":"info","ts":1596516989.310842,"logger":"setup","msg":"starting manager","aws.service":"ecr"}
{"level":"info","ts":1596516989.311061,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}
{"level":"info","ts":1596516989.311101,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"repository","source":"kind source: /, Kind="}
{"level":"info","ts":1596516989.5147588,"logger":"controller-runtime.controller","msg":"Starting Controller","controller":"repository"}
{"level":"info","ts":1596516989.514821,"logger":"controller-runtime.controller","msg":"Starting workers","controller":"repository","worker count":1}
print account ID<PHONE_NUMBER>33

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the quick review, @jaypipes. Addressed your comments and the PR is reviewable now :)


Add support for getting external semaphore handles

Add support for exporting semaphore handles on Vulkan.

@expipiplus1 should be good to merge now.


Service dependencies round2

Sorry for the second round of systemd service changes. @sosiouxme and I discussed this a good bit and we've arrived at this pattern of adding WantedBy to the [Install] section being a good way to allow optional dependencies.

LGTM, any reason to delay?

@sosiouxme I think it's good to go.


cmd/fmt: invalid CUE emitted when all fields are commented inside struct

What version of CUE are you using (cue version)?

$ cue version
cue version v0.6.0-alpha.1

go version go1.20.3
      -buildmode exe
       -compiler gc
       -trimpath true
     CGO_ENABLED 0
          GOARCH amd64
            GOOS linux
         GOAMD64 v1

Does this issue reproduce with the latest stable release?
Yes: 0.5.0 also fails.
What did you do?
exec cue vet .:p
exec cue fmt .:p
exec cue vet .:p

-- file.cue --
package p

#X: {a?: int}

foo: #X & {
  // a: 5
}

testscript fmt.txtar
> exec cue vet .:p
> exec cue fmt .:p
> exec cue vet .:p
[stderr]
expected operand, found '&':
    ./file.cue:7:2
[exit status 1]
FAIL: /tmp/testscript743196369/fmt.txtar/script.txtar:3: unexpected command failure
error running fmt.txtar in /tmp/testscript743196369/fmt.txtar

What did you expect to see?
I expected cue fmt to emit valid CUE.
What did you see instead?
The 2nd cue vet fails, indicating that cue fmt emitted invalid CUE.
A quick pass over the Issues in milestone fmt-redesign didn't reveal any already capturing this problem.

@myitcv You might be thinking of #2274, which I also opened. I opened this issue separately, as the triggering setup and invalid CUE emitted both look different to my eyes.
I don't have any insight into the underlying similarity, so of course please close as a dupe or leave as a tracker however best suits the project :-)

Yeah, I also seemed to recall a similar issue, and I think that was the one :)

I simplified the example to:
package p

struct: {} & {
    // This is a comment
}

The output of cue fmt in this case is:
package p

struct: {}
	// my comment
	& {
	}

I narrowed down the issue to the cue parser, which incorrectly associates the comment with the struct node, instead of the rhs struct

Note that this issue is closely related to https://github.com/cue-lang/cue/issues/2567 and https://github.com/cue-lang/cue/issues/2274; it's likely that a fix in cue/format would fix multiple of these reproducers. cc @uhthomas in case you are looking into any of these already.

Building on the @NoamTD's example, this reproducer demonstrates a few facts about the #2423 bug:

in the context of & operation, a comment in an empty list (ex1) is treated similarly to a comment in an empty struct (ex0): both are misplaced, producing invalid cue.
in a simpler context, as values in a top level field, both the empty struct (ex2) and the empty list (ex3) handle the comment correctly.
DebugStr shows that the offending comments are promoted to Doc comments at the binary & operation level, instead of remaining inside the struct or list.

 issue #2423

exec cue vet 2423.cue
exec cue fmt 2423.cue
cmp 2423.cue 2423.got.cue   # shows the misplaced comment in ex0 and ex1
! exec cue vet 2423.cue     # the result of cue fmt fails vet
cmp stderr 2423.stderr

-- 2423.cue --
ex0: {
	v: 10 // ex0: comment after a value
} & {
	// ex0: comment in an empty struct
}

ex1: [
	11, // ex1: comment after a value
] & [
	// ex1: comment in an empty list
	...
]

ex2: {
	// ex2: comment in an empty struct
}

ex3: [
	// ex3: comment in an empty list
]
-- 2423.got.cue --
ex0: {
	v: 10 // ex0: comment after a value
}
	// ex0: comment in an empty struct
	& {
	}

ex1: [
	11, // ex1: comment after a value
]
	// ex1: comment in an empty list
	& [
		...,
	]

ex2: {
	// ex2: comment in an empty struct
}

ex3: [
	// ex3: comment in an empty list
]
-- 2423.stderr --
expected operand, found '&':
    ./2423.cue:5:2
-- end --

DebugStr (with newlines inserted for clarity):
 <[d0// 2423/2423.comment.in.empty.struct.BAD.cue]
ex0: <[d1// ex0: comment in an empty struct] {<[l5// ex0: comment after a value] v: 10>}&{}>>,
ex1: <[d1// ex1: comment in an empty list] [<[l2// ex1: comment after a value] 11>]&[...]>,
ex2: <[d1// ex2: comment in an empty struct] {}>,
ex3: <[d1// ex3: comment in an empty list] []>


CMake fails under Ubuntu 16.04 after allowing LLVM 3.7+

Cmake suddenly fails on my laptop (Ubuntu 16.04) due to LLVM version problems. It seems that following commit is introduced the according change: https://github.com/cmu-db/peloton/commit/712d8193dc38f9c19a2826206662f1964596b523
My LLVM packages are installed via apt. This may be a problem with wrongly linked or missing cmake includes in Ubuntu which the LLVM packages should provide.
Output of Cmake:
$ cmake -DCMAKE_BUILD_TYPE=Release ..                                                               measure/compilation_timing
INFO Using built-in specs.
COLLECT_GCC=/usr/bin/c++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)

Selected compiler gcc 5.4.0
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   system
--   filesystem
--   thread
--   chrono
--   date_time
--   atomic
-- Found gflags  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libgflags.so)
-- Found PROTOBUF Compiler: /usr/bin/protoc
-- Found libevent pthread (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so)
-- Found libevent (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libevent.so)
-- Found jemalloc (include: , library: /usr/lib/x86_64-linux-gnu/libjemalloc.so)
CMake Error at /usr/share/llvm-3.8/cmake/LLVMConfig.cmake:178 (include):
  include could not find load file:

    /usr/share/llvm/cmake/LLVMExports.cmake
Call Stack (most recent call first):
  cmake/Dependencies.cmake:52 (find_package)
  CMakeLists.txt:41 (include)

CMake Error at /usr/share/llvm-3.8/cmake/LLVMConfig.cmake:181 (include):
  include could not find load file:

    /usr/share/llvm/cmake/LLVM-Config.cmake
Call Stack (most recent call first):
  cmake/Dependencies.cmake:52 (find_package)
  CMakeLists.txt:41 (include)

-- Found LLVM 3.8.0
CMake Error at cmake/Dependencies.cmake:57 (llvm_map_components_to_libnames):
  Unknown CMake command "llvm_map_components_to_libnames".
Call Stack (most recent call first):
  CMakeLists.txt:41 (include)

-- Configuring incomplete, errors occurred!

On 2017-12-11 16:30, Marcel Kost wrote:

Cmake suddenly fails on my laptop (Ubuntu 16.04) due to LLVM version
problems. It seems that following commit is introduced the according
change: 712d819
https://github.com/cmu-db/peloton/commit/712d8193dc38f9c19a2826206662f1964596b523
My LLVM packages are installed via apt. This may be a problem with
wrongly linked or missing cmake includes in Ubuntu which the LLVM
packages should provide.

Do you have llvm-3.8-dev installed?
The CMake support for LLVM is in that package.
--
-Chad

llvm-3.8-dev was already installed when the error occurred. I got it to work after installing llvm-3.9 (and -dev) when cmake switched to the higher version. Seems to be a problem with llvm-3.8 in particular here.
 marcel@thinkpad ~/d/p/p/build_release  $ sudo apt install llvm-3.9-dev
[...]  libllvm3.9 llvm-3.9 llvm-3.9-dev llvm-3.9-runtime
 marcel@thinkpad ~/d/p/p/build_release  $ rm -rf *
 marcel@thinkpad ~/d/p/p/build_release  $ cmake -DCMAKE_BUILD_TYPE=Release ..
-- The CXX compiler identification is GNU 5.4.0
-- The C compiler identification is GNU 5.4.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
INFO Using built-in specs.
COLLECT_GCC=/usr/bin/c++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)

Selected compiler gcc 5.4.0
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   system
--   filesystem
--   thread
--   chrono
--   date_time
--   atomic
-- Found GFlags: /usr/include
-- Found gflags  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libgflags.so)
-- Found Protobuf: /usr/lib/x86_64-linux-gnu/libprotobuf.so
-- Found PROTOBUF Compiler: /usr/bin/protoc
-- Found libevent pthread (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so)
-- Found libevent (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libevent.so)
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.11")
-- Found JeMalloc: /usr/lib/x86_64-linux-gnu/libjemalloc.so
-- Found jemalloc (include: , library: /usr/lib/x86_64-linux-gnu/libjemalloc.so)
-- Found LLVM 3.9.1
-- Found PythonInterp: /usr/bin/python (found version "2.7.12")
-- Performing Test COMPILER_SUPPORTS_CXX1Y
-- Performing Test COMPILER_SUPPORTS_CXX1Y - Success
-- Found Git: /usr/bin/git (found version "2.7.4")
--
-- ******************* Peloton Configuration Summary *******************
-- General:
--   Version           :   0.0.5
--   Git               :   4e39dcf
--   System            :   Linux
--   Compiler          :   /usr/bin/c++ (gcc 5.4.0)
--   Release CXX flags :   -O3 -DNDEBUG -std=c++1y -D__PELOTONFILE__='"$(subst /home/marcel/dev/peloton/peloton_cmake_test/,,$(abspath $<))"' -fdiagnostics-color=auto -fPIC -Wall -Wextra -Werror -mcx16 -Wno-invalid-offsetof -march=native -Wno-strict-aliasing
--   Debug CXX flags   :   -g -O0 -ggdb -fno-omit-frame-pointer -fno-optimize-sibling-calls -std=c++1y -D__PELOTONFILE__='"$(subst /home/marcel/dev/peloton/peloton_cmake_test/,,$(abspath $<))"' -fdiagnostics-color=auto -fPIC -Wall -Wextra -Werror -mcx16 -Wno-invalid-offsetof -march=native -Wno-strict-aliasing
--   Build type        :   Release
--
--   BUILD_docs        :   ON
--
-- Dependencies:
--   Linker flags      :
--   Boost             :   Yes (ver. 1.58)
--   glog              :   Yes
--   gflags            :   Yes
--   protobuf          :   Yes (ver. 2.6.1)
--   LLVM              :   Yes (ver. 3.9.1)
--
-- Documentaion:
--   Doxygen           :   /usr/bin/doxygen (1.8.11)
--   config_file       :
--
-- Install:
--   Install path      :   /home/marcel/dev/peloton/peloton_cmake_test/build_release/install
--
-- Configuring done
-- Generating done
-- Build files have been written to: /home/marcel/dev/peloton/peloton_cmake_test/build_release

I will close this issue but leave a note somewhere if someone else runs into the same problem.
@apavlo where should I leave a note? In the building instructions or create a "known problems" page?


Ag Grid DOM elements are not found in test

Expected behaviour
After following the steps on https://www.ag-grid.com/angular-getting-started/, I would expect to write a simple test like this:
describe('AppComponent', () => {
  beforeEach(async(() => {
    TestBed.configureTestingModule({
      imports: [
        AgGridModule.withComponents([]),
      ],
      declarations: [
        AppComponent
      ],
    }).compileComponents();
  }));

  it('should display ag grid', async(() => {
    const fixture = TestBed.createComponent(AppComponent);
    fixture.detectChanges();
    const compiled = fixture.debugElement;
    const outer: DebugElement = compiled.query(By.css('.ag-theme-balham'));
    expect(outer).toBeTruthy();
    const inner: DebugElement = compiled.query(By.css('.ag-root-wrapper'));
    expect(inner).toBeTruthy();
  }));
});

I would expect to be able to select inner, because I can see it in the DOM tree in the browser (in application and while debugging test).
Actual behaviour
The actual behaviour is that inner is null, even though it is displayed in the browser when debugging.
Environment Details
"ag-grid-angular": "^20.0.0",
"ag-grid-community": "^20.0.0",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~1.7.1",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~1.4.2",
"karma-jasmine": "~1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",

Relevant part of your karma.config.js file

Steps to reproduce the behaviour

Follow steps on https://www.ag-grid.com/angular-getting-started/
Run test I have pasted above

This issue is not related to karma-runner, maybe try the site with the code you posted.


Fix examples in README to be Python 3 compatible

Current coverage is 85.83% (diff: 100%)

Merging #33 into master will not change coverage

@@             master        #33   diff @@
==========================================
  Files            15         15
  Lines          1221       1221
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1048       1048
  Misses          173        173
  Partials          0          0

Powered by Codecov. Last update 4a19ce1...71cafaa


Package for FastText library

Add package for FaceBook's library for fast text representation and classification 'FastText'; https://github.com/facebookresearch/fastText
More info; https://fasttext.cc

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


[Move Prover] Support constant vector of addresses

Extended the move-model with AddressArray to support constant vectors of addresses
They can be defined in const A:vector<address> = [...] at the module level and in let A = vector<address>[...] in a function body. This commit supports both cases.
Added some test cases

Motivation
To support constant vector of address
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

Thanks for looking at this! I agree we should not special case more vectors. We should generalize to Vector(Vec<Value>) as Meng is saying, otherwise we hit the problem again with vector[10,11,12] or vector[true, false] etc. Not sure why we introduced ByteVector in the first place, probably because of a misunderstanding what the Move compiler generates here.


Search Menu (Cortana) not appearing

When I click the Start button and begin to type or hit the search/cortana icon, the dialog box does not appear. Let say I hit start, and type Note and hit enter, the Notepad application opens, so the dialog exists, but it is not appearing.
In my configuration, I have 3 screens, all 3 have Left position Taskbar, but all other configurations within TaskbarX is default configuration.
I am using the MS Store version of TaskbarX (<IP_ADDRESS>)
Thank you!
Jeff Kozloff

@kozloffj Sorry, but i don't think this is caused by TaskbarX

To be able to focus on major/current bugs I had to close all issues. The issues section has gotten very messy to a point that I couldn't follow it anymore. Most issues are duplicates, very old or are already fixed/solved. Feel free to reopen this issue if you still have this issue on the latest version of TaskbarX to get my attention. All feature requests have been put in a list here: 💡| Feature requests #870
I hope you understand ❤


Missing a period

The sentence "Access granted to Azure OpenAI in the desired Azure subscription Currently, access to this service is granted only by application. You can apply for access to Azure OpenAI by completing the form at https://aka.ms/oai/access. Open an issue on this repo to contact us if you have an issue." is missing a period between the word "subscription" and "Currently".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9c542f1c-f19a-5eea-9e98-1543a7352038
Version Independent ID: f190ef2f-fe21-7610-6893-a4d9149435ff
Content: Azure OpenAI Service embeddings tutorial - Azure OpenAI
Content Source: articles/ai-services/openai/tutorials/embeddings.md
Service: azure-ai-openai
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@tony-bergelt
Thanks for your feedback! We will investigate and update as appropriate.

@tony-bergelt
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


FFmpeg crash when starting recording

if width and height are not even numbers, FFmpeg crashes
need to generate MP4
no detection of FFmpeg crashes and then no solution to restart

Prerelease version:
ppInk (2).zip

Prerelease version:
ppInk (2).zip


Add Jarvis March in C#.

ToDo

[x] Simplify name of Run-method.
[x] Make the static class Jarvis March non static.
[x] Add Scalar product method to vector.
[x] Make vector a struct.
[x] Make properties of vector readonly.
[x] Overload operators for Vector.
[x] Refactor code and make it simpler.
[x] Override the Equals and the GetHashCode method for Vector.
[x] Discuss stuff.
[x] Improve explanation of IsLeftOf.
[x] Remove redundant operators.
[x] Don't remove points / simplify code.

Thanks for the review @Gustorn ! I will target your reviews in the following days as well :)

I added a ToDoList for this PR.

Thanks for all the work on this guys!


Bower package is missing

Please add this as Bower package
https://bower.io/docs/creating-packages/

...psst! While Bower is maintained, we recommend yarn and webpack for new front-end projects!

Thank you 👍


Add page about built-in types

What
Add page about built-in types
Why
Close #

Something went wrong with PR preview build please check

Preview is available here:http://soroban-docs-pr216.previews.kube001.services.stellar-ops.com/


500 QEMU guest agent is not running while sysprepping

Hi,
I'm trying to deploy a Windows Server 2022 via Cloudbase + Sysprep and it's working fine. However, during the last moments of deployment it appears that the Proxmox provider determines that QEMU Guest agent is not running and exits with an error. Mere seconds after that error the deployment finishes and I can see the QEMU guest agent report data back to the Proxmox gui, and I can ping it from command line.
Is there an option to manually set the timeout, so that the provider will give the machine a chance to finish provisioning before checking QEMU guest agent?

I tried using the deprecated option guest_agent_ready_timeout = 300 but that did not help.

I'm not sure if it matters, but there is a period when the guest agent is running, and the machine reboots. I guess that the provider attempts to detect QEMU guest agent before it comes back online again.

next version will have customized waitings back


The published javadocs are out of date

The published docs seem to have been generated from an older version which doesn't include the table partitions API.

Maybe the automation that updates the docs is broken?

@gubespam Thanks for reporting the issue, I've published the latest docs from current code now.


builder: check if patch was already applied before applying patch

Check if patch was already applied before applying patch. This will allow builder to work even if the kernel already includes the patch.

So you rely on the fact that set -e at the beginning of the script does not apply inside the function?
LGTM if CircleCI is green.

Ah, I missed something. Force-pushed with set +e and patch -f.

Added a kernel config 4.12 to make CI work again. Now the CI passed.

The PR itself is good, however I see that CircleCI (build 106) builds the following versions:
11825624 /tmp/circle-artifacts.jOtleV1/stage1-kvm-1.26.0-linux-4.12.4.aci
10565012 /tmp/circle-artifacts.jOtleV1/stage1-kvm-1.26.0-linux-4.1.38.aci
10938884 /tmp/circle-artifacts.jOtleV1/stage1-kvm-1.26.0-linux-4.4.45.aci
11063794 /tmp/circle-artifacts.jOtleV1/stage1-kvm-1.26.0-linux-4.8.13.aci
11285604 /tmp/circle-artifacts.jOtleV1/stage1-kvm-1.26.0-linux-4.9.9.aci

And the previous build generated the following artifacts:
$ curl -sSL 'https://circleci.com/api/v1.1/project/github/kinvolk/stage1-builder/latest/artifacts?branch=master&filter=successful' \
>   | jq -r .[].path \
>   | sed -e 's/.*\/\([^/]*\)\.aci$/\1/'
stage1-kvm-1.26.0-linux-4.1.38
stage1-kvm-1.26.0-linux-4.10.6
stage1-kvm-1.26.0-linux-4.11.5
stage1-kvm-1.26.0-linux-4.4.45
stage1-kvm-1.26.0-linux-4.8.13
stage1-kvm-1.26.0-linux-4.9.6
stage1-kvm-1.26.0-linux-4.9.9

So kernel 4.9.6 was previously built but not anymore. This is a problem because tcptracer-bpf and gobpf rely on it. See the following links:

kernel versions for tcptracer-bpf
kernel versions for gobpf
discovery URL
ac-discovery meta tags

So, merging this PR would break tcptracer-bpf and gobpf. @schu used to trigger parametric CircleCI builds manually to avoid this issue. But I think it is wrong that tcptracer-bpf and gobpf always use the last version of the stage1-builder builds. We should use something like this:
rkt image fetch --insecure-options=image kinvolk.io/aci/rkt/stage1-kvm:1.23.0,kernelversion=4.9.6,stage1builderversion=1.0

(specifying 3 versions instead of 2: the rkt version, the kernel version, and a version of the stage1builder, so downstream projects would not break on every stage1-builder PR)
And instead of picking the latest CircleCI artifacts, tcptracer-bpf and gobpf should stick to a specific CircleCI build.

@alban Thanks for the explanation. I'm fine with not merging it until we had a new versioning policy.

@schu Pushed a new commit to fix shell style issues.


v.40: mails cannot be stored decrypted (permanently decrypt)

I know issue #25 called for a fix - but users (including me) might want to store their e-mail unencrypted permanently.
Could you please give us a choice in the settings? That would be wonderful.
Features like search do not work without permanent encryption. Also, if the user can read an e-mail (and thus trusts his system) - why not store it permanently?
EDIT: The safe button works after opening the e-mail.

I just realized that you can click the safe button while opening the message.
An option would still be nice, though, so I don't have to click twice all the time for every received message (and sent message).
Also, it would be great if one could store unencrypted sent message copies locally (i.e. the email before it was encrypted).

(somebody might want to make this a feature request and close the issue)

Generally this will result in the email getting saved on the server. Normally a Bad Idea (tm).

Meddington, this is not true when you use POP3.


Update generated source code

Automated PR triggered by new code generation.
Update generated source code
Generated SDK source code using:

Generator version 3.30.0
Specification version 1.0.0-dev0.0.36
Automation (cloudant-sdks) version 1b682fd

This change is already merged in PR https://github.com/IBM/cloudant-java-sdk/pull/127


Switching to Cabal's new project style

From Cabal user guide

Nix-style local builds are a new build system implementation inspired by Nix. The Nix-style local build system is commonly called “new-build” for short after the cabal new-* family of commands that control it. However, those names are only temporary until Nix-style local builds become the default. This is expected to happen soon. For those who do not wish to use the new functionality, the classic project style will not be removed immediately, but these legacy commands will require the usage of the v1- prefix as of Cabal 3.0 and will be removed in a future release. For a future-proof way to use these commands in a script or tutorial that anticipates the possibility of another UI paradigm being devised in the future, there are also v2- prefixed versions that will reference the same functionality until such a point as it is completely removed from Cabal.

So to use current classic project style, append v1- prefix to cabal commands. cabal v1-configure, cabal v1-repl cabal v1-build etc
Since this is being removed in the future, consider switching to new project style soon.

Can you try this out with Haskell Demo and submit a PR.

This is now done. All commands are v2-*.


SE part with colData errow

Thank you so much. I tried again and it works on this step. I had an error that the col numbers are different. Any suggestions? I make the colData <- DataFrame. The DataFrame is the excel sheet with the sample name E16WTc_nPN_peakchr.narrowPeak, and sample type E16, saved as csv.
colData = DataFrame(names = colnames(counts)) what this part should look like?
nrows <- 131417
ncols <- 10
counts <- matrix(runif(nrows * ncols, 1, 1e4), nrows)
countsFile <- counts
peaksFile<- "E16WTc_nPN_peakschr.narrowPeak"
peaksdf <- read.table(peaksFile)
peaks <- makeGRangesFromDataFrame(peaksdf, seqnames = "V1", start.field = "V2", end.field = "V3")
counts <- data.matrix(countsFile)
SE <- SummarizedExperiment(assays = list(counts = counts),
                       rowData = peaks,
                       colData = DataFrame(names = colnames(counts)))

Error in validObject(.Object) :
invalid class “SummarizedExperiment” object:
nb of cols in 'assay' (10) must equal nb of rows in 'colData' (0)

Maybe after the line
countsFile <- counts
add
colnames(countsFile) <- paste0("sample", as.character(1:dim(countsFile)[2])

The error that you are running into is that there aren't column names associated with your simulated counts matrix, but there typically would be with real data.


Missing ServerSocket

https://github.com/jtransc/gdx-backend-jtransc/issues/23

I close it. I open it when starting use JT only. Best way use multi platform supported only. We replace it in game protocol.


Can't call the rosservice

Greetings,cartographer team.I'm a new player in ros.
I found the API in the document can't be use when I installed the program according to the leading.

I install the cartographer twice and the problem never gone.(both 0.2 and 0.3 version).
I just install it and havn't change the launch and .lua.
Thank you,and if you can help I'll be very grateful.
PS:other rosservice is running correctly.

You need to source the setup.bash file, inside the devel folder of the workspace where you built Cartographer.

Thank you very much.I solved it after souce the bash in devel_isolated folder,as I just sourced install_isolated folder before following the document.


Error:   Failed to load resource: net::ERR_FILE_NOT_FOUND

When I open the html file with localhost:3000, I worked well,.
But if I open the index.html file which is in the build file, I have errors.
One is "Access to internal resource at 'file:///C:/manifest.json' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, chrome-untrusted, secure, https." and the others is "Failed to load resource: net::ERR_FILE_NOT_FOUND". -> have four errors....!
How can I fix the errors? Where is the error spot?

I fixed the errors with "." in route. ex) "./image/fff/fff" like that.
But I have the other errors now.

I really don't know how to fix this errors....


Revert "[gitlab-use-module] Use gitlab python module instead of raw h…

…ttp requests (#24070)"
This reverts commit 0ba7f945968854166dd7bb0a6cd01246b476836e. (pr https://github.com/DataDog/datadog-agent/pull/24070)

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Note: we are reverting because this is causing timeouts in jobs that trigger child pipelines.


next/release

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

GitHub release
v1.12.0

Your semantic-release bot :package::rocket:


[All Hosts] (api) Open Browser Window req set

Docs Build status updates of commit 47aecc2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/open-browser-window-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c3f9df1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/open-browser-window-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5884a60:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/open-browser-window-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Persist max-partition-size in a config table and check it hasn't changed on start up

Why is partition-size used in a first place?
Cassandra is perfectly fine with big amount of columns per row (limit is 2B).
If we used only "persistence_id" as partition-key I can't see any disadvantage of that.
Could this "partition-size" be somehow related to old versions of cassandra and is not needed now?
Removing partition-size would simplify logic/code a lot.
Not mentioning we would not have to create special table to keep this single value.

Cassandra performance degrades as a partition gets bigger. Unbounded partitions are a ticking time bomb where your application works for weeks then blows up with OOM errors as entire partitions are brought into memory.
You never  want to get any where near the 2b limit, 10s of millions at most.

On 18 Aug 2015, at 17:22, Krzysiek<EMAIL_ADDRESS>wrote:
Why is partition-size used in a first place?
Cassandra is perfectly fine with big amount of columns per row (limit is 2B).
If we used only "persistence_id" as partition-key I can't see any disadvantage of that.
Could this "partition-size" be somehow related to old versions of cassandra and is not needed now?
Removing partition-size would simplify logic/code a lot.
Not mentioning we would not have to create special table to keep this single value.
—
Reply to this email directly or view it on GitHub.

One thing is that if your actor is going to write 10s millions of events into journal over a week without doing snapshot then something is not right.
Regarding performance actors do mostly writes and rarely read from journal(only on crash - with rebalancing/passivating mode snapshot will be done first to quickly recover). And as I recall(need to check that one later) writes performance is irrelevant to the number of columns for a given row.
Still good point regarding OOM error in cassandra server with loading entire partition into memory.
No argument on that one yet :)

I agree it's not everyone's use case to do many millions but even a couple hundred TPS will lead to 10s of millions of rows in a partition per day.
Also if people snapshot and delete and we don't move partition we have to scan over the tombstones on recovery which badly affects performance of Cassandra reads.
Most Cassandra data modelling is about keeping partitions about the 'right' size

On 18 Aug 2015, at 23:05, Krzysiek<EMAIL_ADDRESS>wrote:
One thing is that if your actor is going to write 10s millions of events into journal over a week without doing snapshot then something is not right.
Regarding performance actors do mostly writes and rarely read from journal(only on crash - with rebalancing/passivating mode snapshot will be done first to quickly recover). And as I recall(need to check that one later) writes performance is irrelevant to the number of columns for a given row.
Still good point regarding OOM error in cassandra server with loading entire partition into memory.
No argument on that one yet :)
—
Reply to this email directly or view it on GitHub.

LGTM, thanks @chbatey.


Skip if the record is the same

skip updating the record if the record is the same as the current ip.

closed with 128ea80


Enable X509_V_FLAG_TRUSTED_FIRST.

Motivation:
Unfortunately, while BoringSSL is mostly a fundamentally fantastic
library, it has inherited OpenSSL's X509 verifier. This verifier has a
number of issues, but its biggest problem is that it's simply not great
at verifying certificates!
Certificate chains are not so much "chains" as they are a single path
through a DAG. There are potentially many possible paths from a leaf
certificate to a set of roots. Some of these paths are not trusted, some
may be. BoringSSL's default verifier does not do a good job in some edge
cases because it prefers to use the intermediates provided by the client
when it could do a better job by using its own trust store.
As an example, consider the following three-certificate "chain":
CA A -- signs -- Intermediate CA B -- signs -- Leaf C
Imagine that CA A now becomes untrusted, either because it was revoked
or (more topically) because it expires. Imagine also that, in the
meantime, Intermediate CA B has become a fully-fledged CA, and has
re-issued its certificate as a self-signed root using the same key and
identifier.
The mistaken resolver may attempt to use as many certificates as
possible from the peer chain. If the peer chain is using the old,
now-replaced intermediate CA, this will cause BoringSSL to get confused:
it will build a chain that chains up to the intermediate CA, find the
old root in the trust store, and then complain that that root is expired
and fail the validation.
Instead, we want to ignore the intermediate CA B altogether! This is
because we now have a trusted root B', and if we use that then we'll
instantly get a valid chain and can move on.
This behaviour is controlled by a flag, X509_V_FLAG_TRUSTED_FIRST.
This flag is set by default in OpenSSL 1.1+. Sadly, it is not set by
default in BoringSSL. This patch resolves that issue.
Note that this issue only affects non-Apple platforms. On Apple
platforms we use the system resolver, which does not have this issue.
Modifications:

Set X509_V_FLAG_TRUSTED_FIRST.
Add a test to verify that flag is set.

Result:
We'll do a better (but still bad) job of building trust chains.

For your information Python's ssl module has been setting the flag by default since 2015. I haven't got a complain yet.


anchor idl init deploys new idl data account and doesn't show Anchor Program IDL at the program address page at the explorers

When I run anchor idl init, this deploys new idl data account. I'm new to the solana and anchor, so I have no idea that this is the right result, but anyway it does deploys the idl account.
At devnet, I used this command.
$ anchor idl init --filepath target/idl/<program_name>.json 5yYKAKV5r62ooXrKZNpxr9Bkk7CTtpyJ8sXD7k2WryUc --provider.cluster devnet

And this command generated this new account, 6MiEUjVXFR4dL12vLQXjft8pa4QBZmWiYmNWaKYA7B1N.
You can find it at the explorer.
I understand that this command is for publishing the anchor idl file to the on-chain, but I can't find the Anchor Program IDL tab at any of those accounts (5yYKAKV5r62ooXrKZNpxr9Bkk7CTtpyJ8sXD7k2WryUc: program account, 6MiEUjVXFR4dL12vLQXjft8pa4QBZmWiYmNWaKYA7B1N: idl data account).
What should I do to show the Anchor IDL file at the explorer? Is this command is not for this?
My version

anchor-cli 0.30.0
solana-cli 1.18.14 (src:d8e08244; feat:4215500110, client:SolanaLabs)

Your IDL has been successfully deployed on-chain, but the Solana explorer doesn't yet support the latest IDL spec.
You can verify this by running:
anchor idl fetch 5yYKAKV5r62ooXrKZNpxr9Bkk7CTtpyJ8sXD7k2WryUc --provider.cluster devnet

It might be worth it to create an issue in the Solana Explorer repo to update Anchor as it's using an ancient version of Anchor (0.23.0):
https://github.com/solana-labs/explorer/blob/06b186421c6d8eb8383e21d72f55f859a3fd7e0c/package.json#L20
Or comment on https://github.com/solana-labs/explorer/issues/316.

Btw @acheroncrypto this is now fixed


.gitattributes missing

Discovered in #3303
Restoring the .gitattributes caused a bunch of tests to start failing -- probably baselines which were checked in since .gitattributes changed. See: https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/x64_debug_prtest/341/
See https://github.com/dilijev/ChakraCore/tree/gitattr for the commit to restore .gitattributes.
/cc @tcare

Note that we need to do this for ChakraFull too.. which is more work since it never had a .gitattribues.

This has caused some CI issues, so I'll fix it now.


I just raised NetDriver up. I don't know if it's worth it.

Much better! The System Console scenario still crashes on exit though.

To be honest I just tested it on the Example project :-)

Haha. I do the same thing, where I only run UI Catalog ;-)


Fix SmartReply build

The bazel file BUILD breaks the download task.
Please see https://github.com/hannesa2/tensorflowExamples/pull/2/checks?check_run_id=2102299637

Hi @hannesa2 ,
The app passes our continuous integration, when SDK and NDK are configured correctly.
# For example, depending on your installation.
# export ANDROID_HOME=$HOME/Android/Sdk
# export ANDROID_NDK_HOME=$HOME/Android/Sdk/ndk/20.0.5594570

./gradlew build

Your change is invalid. Those files you deleted in PR are to build aar optionally with bazel from cc code:
cd app
bazel build libs/cc:smartreply_runtime_aar

The prebuilt aar was downloaded in advance if running gradle build, and it shows a message like:
Download https://storage.googleapis.com/download.tensorflow.org/models/tflite/smartreply/smartreply_runtime_aar.aar.
Please double check from your side. Thank you!

bazel
There is nowhere some words about this pre build.
Apple silicon M1

bazel 4.0.0

Github action (CI)
There is ndk proper installed, mac-latest has it installed out of the box.
Local
after git clean -xdf on current master

Sorry, only this PR makes it work for me
The root cause is the download Gradle task whats to download in directory build but there is already this bazel BUILD file and the task fails

Hi @hannesa2 ,
Just checked. It seems that MacOS has different behavior from our continuous test with Linux. I am looking into this now.

Yes, git on macOS has issues with upper/lowercase

Thank you for the PR! The issue has been fixed in the latest update, which has been validated to work in Linux and MacOS.

Now it's working, thank you


objs to .ysce

Can we have an option to convert a directory of .obj to a .ysce?

I could add it but you can also use the blender addon (interchange_export_addon) and export it to .dia

i'm trying too mod steam engine simulator on steam (just so you know) but the plugin just outputs like 10 bytes an then stops.
Here what i'm doing:

Export assets.ysce from steam engine sim
open blender(4.x) and delete default objects
Import .obj's to blender
export to .dia
compile dia to .ysce

UPDATE: When i select objects the plugin exports 1 object but stops and to 1 object that it exports is full of null bytes

UPDATE: i just needed 3.8 lts


Request ARGONER for ARGON

https://exchange-format.readthedocs.io/en/latest/parameters.html#argon

Hm... this seems to already exist (see the "error_name" property).
Maybe it's a display issue in the exchange docs.
https://github.com/cchdo/params/blob/9d399f21410aad9ee9d696d3216cd8f053f2e675/cchdo/params/_whp_names.py#L2760-L2786

Weird, it is not showing up on read the docs and also giving me an error when trying to convert to CF netCDF

Ah... it's the commit just after the 0.17 release... so this will be in 0.18. https://github.com/cchdo/params/commit/44dafe95b4a0f9ea66b31280d63b73fb68c81d4d

Did you close this? Why am I still getting an undefined param error?

The name is already in the code/database, just not in the published pypi version. If you need to try it out before the published version is updated. Do a pip install git+https://github.com/cchdo/params.git to get the HEAD/prerelease version for testing.

Also a reminder that there is no support for relative uncertainties in CF yet, i.e. the uncertainty parameter must have the same units as the data parameter (so something like ARGON [UMOL/KG] with ARGONER [%] won't work)


Exit with code 1 on greenlet exceptions

Locust exits with code 0 even if an exception in the greenlet occurs. This tiny fix makes it exit with 1 accordingly.

@jnschulze Could you resolve the conflicts and (optionally) add a test case for this?

I was too hasty when merging this. main_greenlet is a gevent.pool.Group instance when running Locust as a master or slave node, and Group doesn't have the exception attribute. I've reverted the merge since the current change causes an exception on shutdown of slave and master nodes.


Memory usage increase while using Vulkan back-end on Android

Describe the bug
I am in the process of upgrading the Filament version in my app from 1.9.25 to 1.24.0, however, I noticed a large memory usage increase in devices running Vulkan as the back-end. I tested every Filament version in between and noticed the increase in version 1.10.4.
Memory usage increases by about 66%

Samsung A10s -> 350 to 580MB
Redmi Note 8 -> 420 to 700MB

To Reproduce
Run application using Vulkan as back-end in both versions 1.10.3 and 1.10.4
Expected behavior
Stable memory usage or a reason for the increase
Smartphone (please complete the following information):

Devices: Samsung A10s (PowerVR 8320) and Redmi Note 8 (Adreno 610)
OS: Android 11

Additional context
The release notes for version 1.10.4 says "Vulkan: performance improvements on Mali."
There are a couple of possible culprits in file VulkanConstants.h
VK_MAX_COMMAND_BUFFERS = 3; increase to 10
VK_MAX_PIPELINE_AGE = 5; increase to 10
Was this increase intentional on Android?
Are there any reports from other users showing the benefits of making these changes?
PowerVR GPU is weak and buggy, but new phones powered by this GPU are still being sold, mostly in Asia and South America, and they represent about 20% of my user base and the crash rate is already too high with the current memory usage.

Thanks for the bug report!  As I recall, those new constant values were based on experimentation with a Pixel 4, it helped performance by reducing the frequency of GPU alloc / free churn.
Another possible culprit is the fact that we changed how we used the vkmemalloc library, which was causing catastrophic slowness on devices such as Mali that have their bufferImageGranularity property set to 1.
We recently upgraded vkmemalloc (#5691) which allowed us to back to using its simpler API.  This became active starting with v1.24.0.
We've made many improvements since the time that we increased those constants.  We should probably re-evaluate what we want for "good" default values.
We should also consider making them configurable after #5556 lands.

ok, thank you. I have had a beta version (with Filament 1.24.0) tested for a week or so, and no issues have been reported, actually, some users reported better performance. I will release it to production to a small subset of users to see if there are any issues. Anyway, it would be great to be able to change those values when creating the engine.

Thanks, I'll keep the bug open to track the work for making these constants configurable.
Out of curiosity, what does your app do?  We're generally interested in what folks are using Filament for.  :)

It is a drum kit simulator called DrumKnee 3D. I ported it from iOS recently.

@pixelflinger this one should be easy, just make some of the stuff in  VulkanConstants.h configurable


wget: 1.21.4 -> 1.24.5

Changelog: https://lists.gnu.org/archive/html/info-gnu/2024-03/msg00002.html
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Build seems to fail on darwin though. Don't have access to a darwin machine to troubleshoot.

@ofborg build wget


Outputs HTML URL of the new release when succeeds

The purpose of this is to be able to provide users with the link to just-generated release notes for human approval.

@gep13 ping :-)

@SzymonPobiega said...
ping :-)

I haven't forgotten about this.  My wife and I had our second child on Friday, so things are a little chaotic just now, but I will definitely look at this as soon as I can.

Congratulations @gep13 ❤  :) No worries, take your time. I have three kids so I know how chaotic it can be

@SzymonPobiega apologies for the delay, thank you for your contribution.

Thanks 🎉


controller: Successive deployments fail after timeout

Error deploying app release: Timed out waiting for deployment completion!

Error deploying app release: validation_error: Cannot create deploy, there is already one in progress for this app.

Logs: https://gist.github.com/anonymous/986405cfdad32a3c95d9

I am also running into this problem I think, when I go to flynn set env each time it returns:
10:37:56.107555 handler.go:52: [Timed out waiting for deployment completion!]
10:38:07.137258 handler.go:52: [Timed out waiting for deployment completion!]
10:38:18.494601 handler.go:52: [Timed out waiting for deployment completion!]
10:38:29.964765 handler.go:52: [Timed out waiting for deployment completion!]
10:38:41.139897 handler.go:52: [Timed out waiting for deployment completion!]

In my debug info log I also have similar lines:
2015-02-04 18:31:33 UTC ERROR:  duplicate key value violates unique constraint "formations_pkey"
2015-02-04 18:31:33 UTC DETAIL:  Key (app_id, release_id)=(e958be71-b3d3-471f-8a43-f84bb802054a, e2e653e4-9638-4211-95b7-0bb27a97822c) already exists.
2015-02-04 18:31:33 UTC STATEMENT:  INSERT INTO formations (app_id, release_id, processes) VALUES ($1, $2, $3) RETURNING created_at, updated_at
2015-02-04 18:31:34 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:34 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:34 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:34 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:34 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:31:34 UTC DETAIL:  Key (job_id, host_id)=(3cf10ac294ca4d898a261763aecca56e, XXX.com) already exists.
2015-02-04 18:31:34 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at
2015-02-04 18:31:34 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:36 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:31:36 UTC DETAIL:  Key (job_id, host_id)=(f799ee10dea2499e8c57152684730171, XXX.com) already exists.
2015-02-04 18:31:36 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at
2015-02-04 18:31:36 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:36 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:31:36 UTC DETAIL:  Key (job_id, host_id)=(e0500b69856a4b2ba3fda25e80c127af, XXX.com) already exists.
2015-02-04 18:31:36 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at
2015-02-04 18:31:37 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:31:37 UTC DETAIL:  Key (job_id, host_id)=(2b3d6e356bbf4e23848769bebac756e5, XXX.com) already exists.
2015-02-04 18:31:37 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:31:39 UTC DETAIL:  Key (job_id, host_id)=(06c959ff9f964f25ba39e5d09e387748, XXX.com) already exists.
2015-02-04 18:31:39 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:39 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:31:40 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:32:44 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:34:32 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:35:23 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:35:44 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:37:01 UTC LOG:  checkpoints are occurring too frequently (26 seconds apart)
2015-02-04 18:37:01 UTC HINT:  Consider increasing the configuration parameter "checkpoint_segments".
2015-02-04 18:37:17 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:37:46 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:37:57 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:38:08 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:38:19 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:38:31 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:39:11 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:39:43 UTC LOG:  loaded library "$libdir/plugins/pgextwlist"
2015-02-04 18:39:44 UTC ERROR:  duplicate key value violates unique constraint "job_cache_pkey"
2015-02-04 18:39:44 UTC DETAIL:  Key (job_id, host_id)=(319285d4f44541fabcaff6f9bb7915b6, XXX.com) already exists.
2015-02-04 18:39:44 UTC STATEMENT:  INSERT INTO job_cache (job_id, host_id, app_id, release_id, process_type, state, meta) VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING created_at, updated_at

Awesome


Ensure all defined TokenTypes are actually used.

I've created some issues for the branch. Those should be treated in other PRs. I'm currently working on updating the branch from master.


add Jonas Ermert Contributor card

Please add Jonas Ermert Contributor card.
Thanks in advance.

Good Job sir


Meetup Suggestion: Bitcoin Maximalists Long Island

Thanks for making a suggestion for a new meetup.
Please note: Only suggest bitcoin-only meetups.
Meetups which promote any coin or token other than Bitcoin are not suitable for listing.
Altcoin's are only mentioned in the context of warnings or lessons learnt for bitcoin.
Required:

Name of Meetup: Bitcoin Maximalists Long Island
Location Of Meetup: Long Island, NY
At least one of the following:

Meetup Page (or similar): https://www.meetup.com/bitcoin-maximalists-long-island/
Telegram Group (or similar):
Website:

Optional

Name of Organiser(s) & Twitter Handle:
Links showing public support: >>>  example
Tweet your commitment

As the organiser of [>>>XXX<<<] Meetup I can confirm that the meetup is bitcoin-only
-The meetup is bitcoin focused.
-'Altcoins' are scams and are not promoted in talks/presentations at our meetups.
#bitcoinonlymeetups @bitcoinonly_

Is the organizer on twitter, are there any tweets or posts about the meetup?


FR: Improve README

I'm creating this issue thread to track improvements to be made to the README.
If you've run into certain things that are unclear or wish were better documented, leave a comment here so I can incorporate it in to the next round of changes.

Add documentation around the fact that we set the initCode for the account on UOs if the account is not deployed. What this means is that the account is always deployed on the first UO you submit for that account

[ ] update the README so that it leverages the new hd-account and private-key utils

update sample code to show how to use a gas manager and fetch gas estimations when using an ethersprovider

[ ] fix the README examples to match the new signatures for creating a smart account provider
[ ] fix the README examples to use rpcClient instead of provider as the parameter in the .connect() lambda function


Use  to close the command results panel

After typing something like :g/pattern/p, VSCode Neovim opens a panel for its results. To close this panel, you have to mouse click the Close Panel button. You can't hit command-W to close the panel and it is a real pain to switch from keystroking to mousing over and clicking exactly where this little button is.
So my modest suggestion is to use the escape key as a keyboard shortcut to close this panel.

One,  requires some kind of keyboard input focus.
Two, you can click anywhere in the main panel.
So I'm just going to close this.


[Linux/BSD] Add dynamically loaded library version checks.

Adds min. version checks (or function availability checks in case there's no API to check version) for the dynamically loaded libraries.
Splits XKBcommon function checks in two (for version 0.5 and 0.8) to support dead key composition on older distros (0.8 is required to decode Unicode key labels only).
Most of the min. versions correspond to Ubuntu 16.04 (the oldest distro on which I was able to build and test Godot 4).

Thanks!


Merge preprod into production

Merge preprod branch into main, to update the Production environment. Approved deployment into Prod.
Also removes mocked ID from Prod.

codeclimate/total-coverage — 63% (-0.2% change) - Expected, as I removed some tests, as they were in there for the MockID, which has been removed now.


Link from evidence summary to confirmation

Added a link that enables the user to move from the summary page to the
confirmation page.

Looks good, merging :+1:


Fix sudden ruff complaint

Short description

Since yesterday, ruff has been complaining about the following:
integreat_cms/core/wsgi.py:43:5: PLC0206 Extracting value from dictionary without calling `.items()`
   |
42 |       # Read config from environment
43 |       for key in environ:
   |  _____^
44 | |         if key.startswith("INTEGREAT_CMS_"):
45 | |             os.environ[key] = environ[key]
   | |__________________________________________^ PLC0206
46 |
47 |       _application = get_wsgi_application()
   |

That code was last touched 3 years ago, so not sure why the sudden complaint, but it is a valid complaint.
Proposed changes

use items() instead of implicitly iterating over / accessing by key

Side effects

oof I hope none
alternative would be to just ignore the ruff error

Resolved issues

Fixes: n/a

Pull Request Review Guidelines

so not sure why the sudden complaint

Looks like this lint was added to ruff 3 weeks ago, so that would explain it: https://github.com/astral-sh/ruff/releases/tag/0.8.0/
Either way, the code looks cleaner this way 👍

Ah, good catch!


Readme: Running section

Apologies if I'm just missing something obvious, but in the "Running" steps in the Readme is it possibly missing a step regarding when and how to build Godot itself?

Sorry for the delay! First, you can use official builds if you don't need ECMAScript.
For more info on that:

Building Godot
Building Godot with the ECMAScript module


less is more - avoid cat to grep something.

Proposed changes
Changed seccomp docs: avoid cat to grep boot config file.
reference: http://porkmail.org/era/unix/award.html

Unreleased project version (optional)

Related issues (optional)

Seems legit.
While you're at it, replace backticks, which are deprecated, with $()


Incompatibility with json4js-native 4.0.5

FIRRTL updated to 4.0.5 today so the 1.6-SNAPSHOT of Treadle is broken.
At this commit: https://github.com/chipsalliance/firrtl/commit/f31416a8b7122ab29b3243c5d35670030e244455
Chiseltest failure on main:

I suspect somewhere around here is the incompatibility with the new major json4s version:
https://github.com/chipsalliance/treadle/blob/master/src/main/scala/treadle/executable/DataStore.scala#L490-L501

Thanks for pointing out!
Fixing.

Thanks for the help Jiuyang! I was looking to see if I could fix it myself, but there's a fair amount of setup and brushing up I'll need to do to get my environment set up to regression test the fix. Chiseltest's main should be back to working as usual once we have a fix in.

strange. treadle test successfully with latest FIRRTL.

I doubt in your classpath, there exists another jackson/json4s, like in chipsalliance/rocket-chip#2968.

I believe even if it's compiling and running successfully with the newest json4s in internal tests, the jar treadle_2.12-1.6-SNAPSHOT.jar is stale and compiled with json4s 3.6 so it needs to be updated to work with the newest FIRRTL jar.

where did you introduced the json4s 3.6? AFAIK that was rocket-chip.

Rocket-chip shouldn't be relevant here.
The facts as far as I understand them:

json4s is introduced in FIRRTL. So when FIRRTL was still on 3.6 that's the last jar compiled for treadle.
Because json4s is a dependency in FIRRTL (which treadle depends on), json4s is not explicitly added as a dependency in Treadle's build.
Treadle makes use of the json4s package here: https://github.com/chipsalliance/treadle/blob/master/src/main/scala/treadle/executable/DataStore.scala#L6-L8
When FIRRTL upgraded to json4s 4.x, the treadle jar's compilation with 3.6 became stale.
It is likely possible to rectify this simply by recompiling and publishing the Treadle jar with a clean project since FIRRTL is now updated to json4s 4.x, this should fetch json4s 4.x and compile against that in treadle.


Lexing fails on [l@l] in fsdoc

This does not verify (F* just crashes):
module AnotherBug

(** [l@l] *)
let rec abc (a:int) : Tot bool = true

But this does (note the space after @ in the fsdoc):
module AnotherBug

(** [l@ l] *)
let rec abc (a:int) : Tot bool = true

Maybe related to/should be linked to #776.

This should be fixed by the removal of fsdoc @nikswamy

Oh, you're planning on removing fsdoc? Is there any replacement?

Yes, the replacement is fstardoc. See PR #1939. Closing.


Fix for NUTCH-2450 by Kenneth McFarland

@kpm1985 ping, trying to close some issues here.

@lewismc Apologies. Where would you like the unit test to be located?

TestURLUtil testGetDomainDame() or additional tests for that test class.

I closed the issue. The code is still labeled "FIXME", I don't want to mess up closing issues @lewismc  and since Eclipse has been being such a frustration issue I am just going to take a break from the time + frustration issues and come back.
I hope that is ok, I have taken notes and will come back with a preemptive strike next time. I'm just not good with pressure right now. Thank you for giving me the direction, the next time I PR it will have more thought because of this.


fix: move type augmentation to separate file to make it easier

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Synapse 0.20.0

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

In the second commit, a colon is missing after the package name.


[fixed] lock in share mode

I need lock in share mode, so . It works in my project

See ticket-10088. Docs, tests, release notes, and support for all backends are needed.

Closing due to inactivity and lack of follow up.


Issue #68

This version is able to produce tuning tables that match the described issue.
I would like this to be tested more widely to ensure consistency with existing operation.
Especially if there are layouts where the tuning constant note is not mapped to a key. I think I was able to keep the existing logic in place but do not have any good test cases to check.

found something wrong, will repost


optimize SerializedPacket copy/move

in file quic_packet_creator.h
change
virtual void OnSerializedPacket(SerializedPacket serialized_packet) = 0 to
virtual void OnSerializedPacket(SerializedPacket& serialized_packet) = 0
can reduce twice copy/move SerializedPacket.
in file quic_packet_creator.cc
  SerializedPacket packet(std::move(packet_));
  ClearPacket();
  RemoveSoftMaxPacketLength();
  delegate_->OnSerializedPacket(packet); //no need more/copy now,

some other interface also need changed (use reference to replace move )

Moves are cheap.  The second move in QuicPacketCreator::OnSerializedPacket() is likely to be optimized away by the compiler.  On the other hand, if QuicPacketCreator::DelegateInterface::OnSerializedPacket() was changed to take SerializedPacket by reference instead of value, then the SerializedPacket object would need to be copied in the last line of QuicConnection::OnSerializedPacket():
SendOrQueuePacket(std::move(serialized_packet));

So the proposed change would unfortunately increase the number of copies.

no any copy increased by my ideal.  I have used this in my projecet, from linux perf
benchmark it can reduce tiny cpu. some the other interface also adjust.
for example
void QuicConnection::SendOrQueuePacket(SerializedPacket& packet) {
  // The caller of this function is responsible for checking CanWrite().
  WritePacket(&packet);
}

//test on vs2022


Incorrect signing of URLs for AWS IoT

First of, I believe this is the underlying issue @FranzBusch stumbled upon here: https://github.com/adam-fowler/mqtt-nio/discussions/24.
The AWSSigner.signedURL() method produces an incorrect signature for authentication with the AWS IoT MQTT WebSocket endpoint using credentials obtained from AWS STS. This results in a 403: Forbidden response from the WebSocket upgrade request and the behavior observed by Franz.
As mentioned in the AWS SignatureV4 documentation, the X-Amz-Security-Token query parameter should only be included in the signature for some services:

For some services, you must include the X-Amz-Security-Token query parameter in the canonical (signed) query string. For other services, you add the X-Amz-Security-Token parameter at the end, after you calculate the signature. For details, see the API reference documentation for that service.

Unfortunately I couldn't find anything about this in the AWS IoT documentation or a list of services which should include it. The official AWS iOS SDK doesn't include the token in the signature for MQTT so I think it should be omitted in this case in Soto as well. In the official SDK, the canonical query string is built here without the security token parameter.
For a quick proof-of-concept, I moved the line adding the X-Amz-Security-Token query parameter right below the computation of signingData.unsignedURL and could connect to MQTT successfully.

Hi @moritzsternemann thanks for finding this. I must say it is a little frustrating but I cannot find a single reference to any specific service requiring the X-Amz-Security-Token parameter not being included in the signature. Just the rather vague text you found in the SigV4 documentation.
I'll go look through the source code of some of the other SDKs to see if I can find anything

@moritzsternemann can you test #454 and set the parameter omitSecurityToken to true

Thanks @adam-fowler! I will try it out tomorrow 👍

@moritzsternemann this is included in v5.5.0 of SotoCore. Update your swift packages and you should have the fix


Updates gulp usage docs to handle async.

Updates several tasks to return async calls to rimraf to ensure proper order of execution.

Hi @joncloud, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@spboyer  please review

This sample code comes from the default template that is/was provided in Visual Studio 2015 at the time of the release. Gulp is not the default bundling task runner in the templates currently, plase see https://github.com/aspnet/Templates .


Upload error

I have a problem with upload method. It allways return NO in my iOS app.
I debugged the code of NMSSH pod and the error is in NMSSHChannel.m file near line code 537.
// Try to send a file via SCP.     struct stat fileinfo;     stat([localPath UTF8String], &fileinfo);     LIBSSH2_CHANNEL *channel = libssh2_scp_send64(self.session.rawSession, [remotePath UTF8String], fileinfo.st_mode & 0644,                                                   (unsigned long)fileinfo.st_size, 0, 0);;
the variable channel is allways NULL. So the next code
        if (channel == NULL) {
                    NMSSHLogError(@"Unable to open SCP session");
                    fclose(local);
                    return NO;
        }

Exit from the upload method.
The thing that I don't understand is why my error is "Unable to open SCP session". Before send a file, I have a session connected and authorized.
        NMSSHSession *session = [NMSSHSession connectToHost:hostFtp
                                               withUsername:usernameFtp];

        if (session.isConnected) {
            [session authenticateByPassword:passwordFtp];

            if (session.isAuthorized) {
                NSLog(@"sendFile - sftp Authentication succeeded");
                [session.sftp connect];
                if(session.isConnected) {
                    NSLog(@"sendFile - sftp Session connected");
                    BOOL success = [session.channel uploadFile:fileName to:directoryFtp];
                    if(success) {
                        NSLog(@"sendFile - sftp Transfer succeded");
                    }
                    else {
                        NSLog(@"sendFile - sftp Transfer failed");
                    }
                    [session disconnect];
                }
            }
            else {
                NSLog(@"sendFile - sftp not authorized");
            }
        }

And the 2 paramenters passed to the uploadFile are fine.
fileName is verified by checking if file really exists, and directoryFtp is something like DIR1/DIR2/DIR3/.
Can someone help me?

You're opening a SFTP session ([session.sftp connect]) and then you're using SCP ([session.channel uploadFile:fileName to:directoryFtp]).
SFTP and SCP are two different protocols. I guess that what you're looking for is:
/**
 Overwrite the contents of a file
 If no file exists, one is created.
 @param localPath File path to read bytes at
 @param path File path to write bytes at
 @returns Write success
 */
- (BOOL)writeFileAtPath:(NSString *)localPath toFileAtPath:(NSString *)path;


copr: vectorize Inet6Ntoa

Signed-off-by: mak<EMAIL_ADDRESS>
PCP #5751
What have you changed?
Add vectorized Inet6Ntoa
What is the type of the changes?
Improvement (a change which is an improvement to an existing feature)
How is the PR tested?
Please select the tests that you ran to verify your changes:

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No. It should not change the behavior.
Does this PR affect tidb-ansible?
No

/run-integration-copr-test copr-test=pr/81

@sre-bot /run-integration-copr-test copr-test=pr/81

@overvenus @5kbpers PTAL, thanks!

Please resolve conflicts.


Release branch compatibility?

I already have an existing bosh-lite director setup based on the warden cf release (v208).
Is cf-release on develop branch(diego) compatible with cf-release in master after executing ./update?
Or should I just setup a brand new bosh-lite running diego?

Hi, @charyorde,
It's not guaranteed that particular commits of cf-release and diego-release will be compatible. For each final version of cf-release, the release notes refer to a corresponding compatible version of diego-release. For example, CF final release v208 is compatible with Diego final release 0.1198.0, and v209 is compatible with Diego final release 0.1209.0.
If you need compatibility for intermediate versions of cf-release, the Diego-CF compatibility repo tracks which versions are successfully promoted through the Diego team's CI pipelines. For the greatest stability, you should take CF/Diego pairs from the rows with 'release_candidate' in the RELEASE_STAGE column, as these also have a definite Diego final release associated to them. For example, as of this writing, Diego final releases 0.1245.0 and 0.1246.0 are compatible with the latest cf-release commit, https://github.com/cloudfoundry/cf-release/commit/211e35ec8cb23d557d0640cb6ab106b34d052003.
You should be perfectly fine to deploy Diego alongside your existing CF bosh-lite deployment, although there may be a few tweaks required to your CF deployment manifest to ensure correct and complete Diego functionality. Please refer to the bosh-lite deployment section of the diego-release README for instructions.
Thanks,
Eric, CF Runtime Diego PM

wow! This is very very useful. Thank you. Now I have a very good understanding of what's going on in that CF release cycle.


Transform services

Hi Luke
Your branch is messed up here - not sure why you have commits from tim in here. Can you see if you can sort out the branch history?
David


[LightGBM] [Warning] Met 'abs(label) < 1', will convert them to '1' in MAPE objective and metric

I'm doing Regeression with MAPE (Mean Absolute Percentage Error) objective and eva_metric.
What is the meaning, of following warning?
[LightGBM] [Warning] Met 'abs(label) < 1', will convert them to '1' in MAPE objective and metric

Thanks for using LightGBM @michael135 !
There are values in your target variable which have an absolute value < 1. MAPE is unstable under such conditions, so LightGBM converts those values to 1.0 before evaluation. This warning is telling you that that's happening.
The code where this rounding happens: https://github.com/microsoft/LightGBM/blob/3e8e24b374fbfe6522e39862a79c81b2bea8b259/src/metric/regression_metric.hpp#L248-L250
To see this instability, consider the following MAPE on a single prediction.

actual
pred
error
MAPE

2.100
2.200
0.100
0.048

2.105
2.200
0.095
0.045

1.100
1.200
0.100
0.091

1.105
1.200
0.095
0.086

0.100
0.200
0.100
1.000

0.105
0.200
0.095
0.905

Rounding to 1 like this also avoids the case where calculating MAPE fails with a divide-by-zero error because the target is exactly 0.
If you want to use MAPE as an evaluation metric and are uncomfortable with the way that LightGBM is using rounding to calculate it in this setting, I recommend altering your target variable to ensure that all the values are > 1 in absolute value.
I think this warning could be made a bit clearer, and I'll open a pull request to clarify it. Thanks for pointing it out!

Thank you @jameslamb, for detailed explanation.
Why MAPE is unstable if MAPE < 1 ?
(Is there any reference to read more about it?)
P.S.
I'm familiear with an "MAPE stability issue", when $actual = 0$ or close to zero.

Why MAPE is unstable when MAPE < 1 ?

It's not that it is unstable when MAPE < 1. This metric is unstable when the actual value of the target is less than 1 (in absolute value).
In the table I posted above, look at the MAPE values for the case where the target has values like 0.1, and compare those to the MAP for target values like 1.1 and 2.1.
Does that clarify it? If not, could you reword your question?

I think now it's more clear to me.
So it will change this

actual	pred	error	MAPE
0.100	0.200	0.100	1.000

instead |0.1 - 0.2| / 0.1 = 1.0
we will get:  |0.1 - 0.2| / 1 = 1.0

yep, that's right! So it's not perfect, but it's at least better.
You can see that the larger errors still result in a larger penalty:
|0.1 - 0.2| / 1 = 0.1
|0.1 - 0.3| / 1 = 0.2
|0.1 - 0.4| / 1 = 0.3
but with this formulation, the effect of having a target value close to 0 is softened a lot, so it's less likely to distort the MAPE. Since the MAPE is a mean over all absolute percentage errors, it's sensitive to extreme values.
If you have any concerns about this, you can use a metric that doesn't rely on percentages, like mae.

@michael135 MAPE is not a perfect metric, as it could divide zero when label is zero.
Therefore, we need a pre-defined threshold to avoid dividing zero. We simply use 1, as we don't want to emphasize the data with small labels have large errors, which conflicts with MAPE's design.
For example, when label is 1e-5 and predict is 1, the error will close to 1e5, which is very large.

Thank you @jameslamb  and @guolinke for the clarifications!
I absolutely agree for case when label = 1e-5.
But when label = 0.1  (or even 0.01). I'm bit confused.
Is there some easy option to define (provide) a threshold when label will be rounded up to 1.0?
Regarding the MAPE, I know, that it's not perfect, but for current problem, which I'm trying to solve it's kind of a least worse for me. (Since I don't have zeroes, and when label = 5 and prediction is 4.9 (mae=0.1), it's not the same as when label=0.5 and predction=0.4 (same mae=0.1), but mape will "distinguish" the differences.

@michael135 you can simply multiply your labels by 10 (for 0.1), or 100 (for 0.01).

@guolinke , what is the difference, if I multiply or "lightgbm multiply" ?

@michael135 I was saying a workaround for your question, "Is there some easy option to define (provide) a threshold when label will be rounded up to 1.0?"
Theoretically, multiply all labels by a constant, will not change the value of MAPE metric. So it is safe. And with large label range, the threshold is reduced accordingly.

@guolinke.
Now. I've got it.
This workaround is fine (to multiply, and then to divide back after prediction).
Thank you again @jameslamb  and @guolinke.

Glad we could help! If you don't mind, could you please accept my original answer on your Stack Overflow post, so it will be marked as answered?
https://stackoverflow.com/questions/65075804/lightgbm-warning-met-abslabel-1


Use CSS transform instead of including RTL equivalents of images

https://github.com/mozilla/pdf.js/blob/4ff67a518e676a2520c34a11e2c635aac6195681/web/viewer.css#L776-L816
We should just use transform: scaleX(-1) instead of RTL equivalents of images.
Those RTL images also cause duplicate files when packaging Firefox: https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/browser/installer/allowed-dupes.mn#66-73

Fixed in the PR above. Good point!


macOS platform-specific keybindings for TextBox

We noticed an odd behavior in keybindings for TextBoxes in macOS:

Cmd + left/right arrow:

Expected behavior: cursor moves to the start/end of the line
Actual behavior: cursor moves one character left/right

Option + left/right arrow:

Expected behavior: cursor moves to the start/end of the previous/next word
Actual behavior: cursor moves one character left/right

Mostly related to this file https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Input/Platform/PlatformHotkeyConfiguration.cs

@mat1jaczyyy @maxkatz6, please could you add the following missing gestures for macOS?
Cmd + Up: Go to document start
Cmd + Down: Go to document end
Cmd + Shift + Up: Select to document start
Cmd + Shift + Down: Select to document end
Thank you!

@danipen sure