Run idf.py monitor without rebuilding project (IDFGH-9543)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.0.1
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
CMD
What is the expected behavior?
I've build my project in another remote machine and create a merged flash file.
I receive the flash file to my local machine and flash it with esptool.py sucessfully.
Now, i try to monitor, but it starting to rebuild the project locally. Can i bypass the building and just monitor the device?
I don't find any esptool doing exactly that.
What is the actual behavior?
idf.py monitor, rebuilds the project
Steps to reproduce.

create a merged-flash.bin
use esptool.py to flash it
try to idf.py monitor the board

Build or installation Logs.
No response
More Information.
No response

Can i bypass the building and just monitor the device?

Yes, this is already possible. I've checked that it should be working for v5.0.1. Are you sure that this is the right version you are using on that computer where you are running idf.py monitor? This behavior was introduced in ESP-IDF v5.0 and it is not available in earlier versions.
idf.py monitor can even be invoked in a clean project immediately after idf.py fullclean without triggering building.

Thanks for answering.
I just checked and it looks i run the latest version.
This is what i do:
C:\\Espressif\\frameworks\\esp-idf-v5.0.1\\export.bat
idf.py --version
returns ESP-IDF v5.0.1
idf.py fullclean
Returns
Build directory '..\myappfolder\build' not found. Nothing to clean.
Executing action: remove_managed_components
Done

idf.py monitor
Although it looks it's not rebuilding as usual, it takes some seconds, creates the build folder and ends up at the command:
Executing "C:\Espressif\python_env\idf5.0_py3.11_env\Scripts\python.exe C:\Espressif\frameworks\esp-idf-v5.0.1\tools/idf_monitor.py -p COM12 -b 115200 --toolchain-prefix xtensa-esp32s3-elf- --target esp32s3 c:\users\username\tutorial\blink\build\blink.elf --force-color -m 'C:\Espressif\python_env\idf5.0_py3.11_env\Scripts\python.exe' 'C:\Espressif\frameworks\esp-idf-v5.0.1\tools\idf.py'"...

and start the usual monitoring.
If i rerun idf.py monitor it goes straight to the monitoring.
Can i bypass the creation of building folder and go straight to the monitoring (as this happens the second time i run the idf.py monitor)? (maybe provide the .elf file from my remote machine).
Also, the build/blink.elf file doesnt exist.

Although it looks it's not rebuilding as usual, it takes some seconds, creates the build folder and ends up at the command:

That is normal because cmake is still invoked in order to create a basic build structure. No build should be done in that case. This happens only after fullclean and once.

If i rerun idf.py monitor it goes straight to the monitoring.

That means it works as it supposed to be.

Can i bypass the creation of building folder and go straight to the monitoring (as this happens the second time i run the idf.py monitor)?

See my previous comments.

(maybe provide the .elf file from my remote machine).

Yes, you can copy it to the path you see in the output. And it should be used by idf.py monitor without re-writing it. But it is not necessary if you don't need the addr2line outputs (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/tools/idf-monitor.html#automatic-address-decoding).

Also, the build/blink.elf file doesnt exist.

That is also normal in this case.

One more note. It was pointed out to me by @peterdragun that maybe you look more for invoking IDF Monitor directly.
The following commands invoke IDF Monitor directly without creating a build directory. See the help how to use it (or the previously linked documentation page).
Run this in ESP-IDF v5.0.x (or previous versions):
python tools/idf_monitor.py --help

Run this in v5.1 (or newer):
python -m esp_idf_monitor --help

One more note. It was pointed out to me by @peterdragun that maybe you look more for invoking IDF Monitor directly.
The following commands invoke IDF Monitor directly without creating a build directory. See the help how to use it (or the previously linked documentation page).
Run this in ESP-IDF v5.0.x (or previous versions):
python tools/idf_monitor.py --help

Run this in v5.1 (or newer):
python -m esp_idf_monitor --help

i have v5.0.1 and python %IDF_PATH%/tools/idf_monitor.py remoteapp.elf returns:
--- idf_monitor on /dev/ttyUSB0 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
Exception in thread Thread-2 (_run_outer):
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Espressif\frameworks\esp-idf-v5.0.1\tools\idf_monitor_base\stoppable_thread.py", line 47, in _run_outer
    self.run()
  File "C:\Espressif\frameworks\esp-idf-v5.0.1\tools\idf_monitor_base\serial_reader.py", line 52, in run
    self.serial.open()
  File "C:\Espressif\python_env\idf5.0_py3.11_env\Lib\site-packages\serial\serialwin32.py", line 64, in open
    raise SerialException("could not open port {!r}: {!r}".format(self.portstr, ctypes.WinError()))
serial.serialutil.SerialException: could not open port '/dev/ttyUSB0': FileNotFoundError(2, 'The system cannot find the path specified.', None, 3)

I guess it doesn't recognize i'm using Windows..can i choose monitor port manually?

For windows and idf v5.0.x i had to set COM port and choose the .elf file (after setting the environment with export.bat):
%IDF_PATH%/tools/idf_monitor.py -p %ESPTOOL_PORT% build/myapp.elf
Now it works fine..


ntr: correction of merotelic kinetochore attachment, meiosis I

def
The cell cycle process that corrects the anomalous association of a single chromatid kinetochore with mitotic spindle microtubules emanating from both spindle poles at meiosis I, and would, if uncorrected result in the separation of sister chromatids at meiosis I
Part_of
GO:0051316
attachment of spindle microtubules to kinetochore involved in meiotic chromosome segregation
PMID:21920317
Repositioning of Aurora B Promoted
by Chiasmata Ensures Sister Chromatid Mono-Orientation in Meiosis I
"We conclude that merotely of fused kinetochores is initially similarly prevalent in the attachment of bivalents and univalents but that efficient
correction only happens in bivalents and depends on Ark1 activity (Figure 4C)."

The 'mitotic' version of this term has the following relationships:
is_a: GO:0050789 ! regulation of biological process
is_a: GO:0009987 ! cellular process
relationship: part_of GO:0000070 ! mitotic sister chromatid segregation
relationship: regulates GO:0051315 ! attachment of mitotic spindle microtubules to kinetochore
Do you wish to have similar relationships recapitulated for this new term?  That is
is_a: GO:0050789 ! regulation of biological process
is_a: GO:0009987 ! cellular process
relationship: part_of GO:0045144 ! meiotic sister chromatid segregation
relationship: regulates GO:0051316 ! attachment of spindle microtubules to kinetochore involved in meiotic chromosome segregation
Note the 'regulates' relationship to GO:0051316, instead of the 'part_of' that you originally suggested.

Hi Tanya,
That sounds right, and regulation is more correct.
Val

I've just removed the regulates on the mitotic version, see #12393

Ah OK, so just part_of the parent congression instead?

Yep. That would be consistent.

Checking again.
EXISTING TERM
[Term]
id: GO:0098783
name: correction of merotelic kinetochore attachment, mitotic
namespace: biological_process
def: "The cell cycle process that corrects the anomalous association of a single chromatid kinetochore with mitotic spindle microtubules emanating from both spindle poles (otherwise known as merotelic attachment to the spindle)." [PMID:21306900]
is_a: GO:0009987 ! cellular process
relationship: part_of GO:0051310 ! metaphase plate congression
Should the term be part_of GO:0007080, mitotic metaphase plate congression instead?
Then the new term:
id: GO:NEW
name: correction of merotelic kinetochore attachment, meiotic
namespace: biological_process
def: The cell cycle process that corrects the anomalous association of a single chromatid kinetochore with mitotic spindle microtubules emanating from both spindle poles at meiosis I, and would, if uncorrected result in the separation of sister chromatids at meiosis I. [PMID:21920317]
is_a: GO:0009987 ! cellular process
relationship: part_of GO:0043060 ! meiotic metaphase I plate congression
Agree?

Yep I think so. @dosumis could you double check?

Yep.  Sorry.

On Aug 27, 2016, at 9:30 AM, Val Wood<EMAIL_ADDRESS>wrote:
Yep I think so. @dosumis https://github.com/dosumis could you double check?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/geneontology/go-ontology/issues/12616#issuecomment-242904613, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4xy4HMoSeejBeuLMGE8rlbXkPZmGTks5qj_WTgaJpZM4Jsz5l.

Changed relationship for GO:0098783
-relationship: part_of GO:0051310 ! metaphase plate congression
+relationship: part_of GO:0007080 ! mitotic metaphase plate congression
Added:
+id: GO:0090699
+name: correction of merotelic kinetochore attachment, meiosis I
+namespace: biological_process
+def: "The cell cycle process that corrects the anomalous association of a single chromatid kinetochore with mitotic spindle microtubules emanating from both spindle poles at meiosis I, and would, if uncorrected result in the separation of sister chromatids at meiosis I." [GOC:vw, PMID:21920317]
+is_a: GO:0009987 ! cellular process
+relationship: part_of GO:0043060 ! meiotic metaphase I plate congression


C# export with Exp property hints don't show up properly in the inspector

Godot version
3.3.3.stable.mono
System information
Windows 10
Issue description
When using the property hint ExpRange A slider isn't used for the exported variable in the inspector. However it does with the GDScript equivalent. There's a similar issue with ExpEasing which has a curve editor, I think it's called that, but with the C# equivalent there isn't one. The C# code builds without errors so I assume it's correct, I've also had the C# discord channel look at this and they couldn't figure out what's going on.
Steps to reproduce
use the ExpRange or ExpEasing property hints in a project.
Minimal reproduction project
C#Test.zip

When using the property hint ExpRange A slider isn't used for the exported variable in the inspector. However it does with the GDScript equivalent. There's a similar issue with ExpEasing which has a curve editor, I think it's called that, but with the C# equivalent there isn't one.

In GDScript you're exporting floats, in C# you're exporting ints. So these are not equivalent. Changing int to float in C# will make them work the same.

Thank you. I've made a PR to fix the 3.4 branch docs, and I'll look into the master branch. Closing this issue.


refactor: change from yarn to pnpm

After checking commitlint manually with this command
npx commitlint -- --from="d5cf4a3da177bec8993aa24381d346958cdf2eb5" --to="92713f3e6b6975cd6fcd04bca67265668f397ddc" (this pr's first and last commit) error seems to be from this repository's first commit which is initial commit
This PR is safe to review. We should bypass Analyze commit messages and fix the issue on another PR for analyze commit messages action.
CC: @necipallef


custom_user_data as required field is a breaking change

when switching to 0.9.8, the custom_user_data attribute is listed as required and breaks builds that do not require custom_user_data.
Steps to reproduce:
select a Terraform project that works with a previous version of the AWS BIG-IP module
change module source reference from a previous version to 0.9.8
run Terraform apply
Expected Result:
creates the same result when using previous module versions
Actual Result:
error message indicating that custom_user_data is a required attribute

Issue is fixed in v0.9.9, Please reopen the issue if it still persists

0.9.9 passed all of my tests 👍


Add a .snyk file with the files to skip

Skipping:

the vendor folder
any test file
all the e2etest files

Took inspiration from https://github.com/openshift/oc/blob/master/.snyk

/lgtm


Update mkldnn window build instructions in MKLDNN_README.md

Description
Updates mkldnn & MKL window Build instructions in MKLDNN_README.md, if the PR apache#14877 (fix MKLDNN/MKL in cmake) is merged.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@TaoLv @szha  @ZhennanQin @pengzhao-intel please help to review them. thanks

@aaronmarkham could you help take a review for the document change? thanks in advance :)

@aaronmarkham thank you for the comment!.  As the build steps in  Visual Studio 2017 and visual studio 2015 is exact same,  so i remove the visual studio 2017 part in second commit.  The current version is like
Windows
On Windows, you can use Micrsoft Visual Studio 2015 and Microsoft Visual Studio 2017 to compile MXNet with Intel MKL-DNN. Micrsoft Visual Studio 2015 is recommended.
Visual Studio 2015 ...

The original md file mix two kind of line end of flag: linux: LR and window: CRLF. most of them are CRLF, so change to CRLF.

Thanks for your contribution. Merging now :)


Widget设了时间筛选器，在之后天看报表时不会自动更新当前时间

如2020-01-01这本时间筛选器设置了”今天“，再过了一天后查看报表时仍然时间筛选器仍然为”2020-01-01“并不会跟随系统时间进行更新。

Please post the screenshot of your filter settings.

Here is the screenshot of date selection filter.If you need more description,please tell me.

Here is the screenshot of date selection filter.If you need more description,please tell me


Jobs List Component

A component that displays a list of positions
Needs to include Title, Location, description and contact info.

Add tests
connect to DB
Improve UI
Add link to job card


Unable to rebuild container

This codespace is currently running in recovery mode due to a container error.

Use Cmd/Ctrl + Shift + P -> "Codespaces: View Creation Log" to see full logs
Update your devcontainer configuration as needed
Use Cmd/Ctrl + Shift + P -> "Codespaces: Rebuild Container" to retry
For help, read more about custom configuration: https://aka.ms/ghcs-custom-configuration

This is what I get on initially starting the codespace after looking for some other issues like this I tried to rebuild Container but it doesn't change anything
### Tasks

fixed by editing the docker file
Change
FROM mcr.microsoft.com/devcontainers/dotnet:6.0 to FROM mcr.microsoft.com/devcontainers/dotnet:6.0-bullseye


.dt accessor returns int instead of float, resulting in misrepresentation of NaT values

What happened?
With the latest xarray (this doesn't happen at least in version 2023.2.0), accessing .dt parts returns a strict int64 DataArray, resulting in wrongly presented missing values.
In [2]: s = pd.to_datetime(pd.Series(['2021-12-01', pd.NaT]))

In [3]: s
Out[3]:
0   2021-12-01
1          NaT
dtype: datetime64[ns]

In [4]: s.dt.year
Out[4]:
0    2021.0
1       NaN
dtype: float64

In [5]: s.to_xarray()
Out[5]:
<xarray.DataArray (index: 2)>
array(['2021-12-01T00:00:00.000000000',                           'NaT'],
      dtype='datetime64[ns]')
Coordinates:
  * index    (index) int64 0 1

In [6]: s.to_xarray().dt.year
Out[6]:
<xarray.DataArray 'year' (index: 2)>
array([                2021, -9223372036854775808])
Coordinates:
  * index    (index) int64 0 1

Notice how:

The series and generated DataArray are both correctly datetime64[ns]
The series' .dt.year accessor returns a float64 to accommodate the missing value (it will use int32 w/o the missing value).
The DataArray's .dt.year returns a negative integer instead of nan.

Additionally, compare with the same snippet's output with xarray 2023.2.0:
In [3]: s.to_xarray().dt.year
Out [3]:
<xarray.DataArray 'year' (index: 2)>
array([2021.,   nan])
Coordinates:
  * index    (index) int64 0 1

What did you expect to happen?
The .dt accessor should return a float with missing values when needed.
Minimal Complete Verifiable Example
import pandas as pd

s = pd.to_datetime(pd.Series(['2021-12-01', pd.NaT]))
s.to_xarray().dt.year

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
No response
Anything else we need to know?
 I can reproduce and it seems the unconditional cast (as you suggested) is the cause:
https://github.com/pydata/xarray/blob/e739df7d27d88008f09a927fc0f61fccdc7a77aa/xarray/core/accessor_dt.py#L122
If NaT is present in the source data access_method will return float64 with nan. The cast to int64 will transform nan -> -9223372036854775808. I'm not really sure how and where to handle this, but one solution would be to check for presence of NaT or float64 return type and do not cast in these occasions.

Hey @kmuehlbauer, thanks for addressing and confirming the issue!
I think both of those are valid approaches, and would surely address the issue at hand. However, these feel a bit like stop-gap measures, and I have to wonder (as someone who hasn't contributed to xarray yet) - why are the type casts even necessary, especially in the series case?
It seems like it can be directly off-loaded to pandas.

From reading the linked PR I think the main thing was to cast int32 to int64 (for xarray internal use). @keewis and @dcherian surely have more insight into that topic.

Yes I think we should cast to float like pandas does.

@dcherian pandas currently returns float64 in presence of NaT and int32 otherwise. As mentioned above, should xarray cast only int32 -> int64 and keep the pandas float64? Or should we also cast to int32 -> float64. Anyway, this would need to happen inside https://github.com/pydata/xarray/blob/4156ce53a8e4b65bbeaabebe0b2071d3d9b18c01/xarray/core/accessor_dt.py#L68 to also make this work for dask arrays.
Side note: If isocalender is requested, xarray will already cast to int64 unconditionally.

Any update on this @dcherian @kmuehlbauer?
We're stuck with 2023.2.0 because of this 😢

@idantene Thanks for checking back. I lost track over summer. I've a somewhat clumsy approach over in #8084. Would be great if you can test with your setup.
It checks for NaT and casts to float64 if that's the case. Unfortunately isocalendar needs special handling which requires NaT check twice for now. If anyone has suggestions to make this more slim, please comment in the PR.

@idantene @dcherian I think this problem should be fixed upstream. I've opened an issue  https://github.com/pandas-dev/pandas/issues/54657 over at pandas to see, if and how this can be aligned.

Thanks @kmuehlbauer! I'll have a test run soon to verify this fix - it looks good on paper.
I'm curious as to how you'll fix this for dask, though it does not apply to our use case :D

I'm curious as to how you'll fix this for dask, though it does not apply to our use case :D

I've no idea how this can be made consistent for dask without a priory knowledge if there are NaT involved or not. As far as I checked it will return some RuntimeWarning: invalid value encountered in cast warning, which will at least let the user know about the issue.


Bestsellers are not loading properly on "404" page.

Current behavior
Bestsellers list is not loading properly on "404" page.
Expected behavior
Bestsellers list should be rendered properly on "404" page.
Steps to reproduce the issue
Visit: https://test.storefrontcloud.io/sample-error-page
Refresh page

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information
I think the problem is related to  "asyncData" function:
https://github.com/DivanteLtd/vue-storefront/blob/develop/core/pages/PageNotFound.js#L23
SSR side is able to set new element in a state, client-side is not.
The weird thing, when you clear cache and navigate to "404" page from home page via a link - everything work properly:

Actually duplicated here: https://github.com/DivanteLtd/vue-storefront/pull/3540#issuecomment-533501604

Actually duplicated here: https://github.com/DivanteLtd/vue-storefront/pull/3540#issuecomment-533501604


Reset the autoresizing mask when the view is recycled

Summary:
Autoresizing mask is a native property of iOS views. When a veiw is created anew, the default value is UIViewAutoresizingNone. Libraries might create code that update this property and we need to make sure that it is reset when the view is recycled.
This should close: https://github.com/facebook/react-native/issues/42732
Changelog:
[iOS][Changed] - Reset the autoresizing mask to UIViewAutoresizingNone when the view is recycled.
Differential Revision: D54263847

@j-piasecki This should address one of the issue you opened last month, sorry for the delay.
One thing I noticed is that the React state in the app in this specific example goes out of sync with this change.
What I mean is that:

we enable autoresizing mask to be width and height (the second state is true)
we recycle the view tapping on the first button
the autoresize mask is now None, and the view behaves properly as if it was none, but the react state is still W+H set to true.

Are we ok with this? I don't think there is a way to propagate this change up to the JS layer, right?
Before the change, not resetting the autoresizeMask would have avoided this problem, because the autoresizeMask is not reset and the state is not reset, so it stays consistent. What would be the ideal behavior?

closing, not the right fix.


Remove waiting for ModelMesh deployment replicas

Waiting for deployment in ModelMesh is necessary. Closing as "won't fix".


Update: Trino&Presto catalog Details

Describe your changes :

I worked on the Updating Trino&Presto catalog Details in Documentation.

Type of change :

[x] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

thanks for updating! Leaving the approval here. Could we add a small note saying that the catalog is not mandatory from 0.12.2 or greater versions? In case someone is still on 0.12.
Thanks!

thanks for updating! Leaving the approval here. Could we add a small note saying that the catalog is not mandatory from 0.12.2 or greater versions? In case someone is still on 0.12.
Thanks!

Done.
Thanks!


Broken hyperlink in dart doc for ControlValueAccessor class

If you search for the hyperlink named "ControlValueAccessor" on https://angular.io/docs/dart/latest/guide/template-syntax.html and click on it, it leads to a 404.

Thanks for reporting this. The issue is broader in scope and will be fixed as part of #2173, so we'll close this issue and track progress in #2173.


Cherry-pick gh-2845: update class var parameter to use Map interface (#2846)

Co-authored-by: t92549<EMAIL_ADDRESS>Related Issue

Resolve #2857

Codecov Report

Merging #2857 (8a2b3b8) into v2-alpha (8015440) will increase coverage by 7.53%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             v2-alpha    #2857      +/-   ##
==============================================
+ Coverage       56.45%   63.99%   +7.53%
+ Complexity       2499     2473      -26
==============================================
  Files             917      716     -201
  Lines           32409    21946   -10463
  Branches         3325     2515     -810
==============================================
- Hits            18297    14044    -4253
+ Misses          12723     6764    -5959
+ Partials         1389     1138     -251

Impacted Files
Coverage Δ

...ov/gchq/gaffer/named/operation/NamedOperation.java
72.50% <ø> (ø)

...retriever/impl/AccumuloIDBetweenSetsRetriever.java

.../gov/gchq/gaffer/integration/impl/FilteringIT.java

...k/gov/gchq/gaffer/mapstore/factory/MapFactory.java

...store/operation/impl/SummariseGroupOverRanges.java

...n/handler/impl/FederatedOutputIterableHandler.java

...accumulostore/retriever/AccumuloItemRetriever.java

...ostore/data/element/AccumuloEntityValueLoader.java

...gchq/gaffer/accumulostore/utils/BytesAndRange.java

...andler/impl/FederatedChangeGraphAccessHandler.java

... and 194 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Analyze tool is down

Seems to be a simple http vs https problem:  https://webpack.github.io/analyse/

On a related note, does anyone know where the source code is for this tool so I can run it myself? I found this: https://github.com/robertknight/webpack-bundle-size-analyzer  but it's pretty bare bones.

Works without https: http://webpack.github.io/analyse/ . You might have to disable HTTPS Everywhere for the page if you use that. Or, you can allow "unsafe scripts"/"insecure content" via the browser (e.g. Chrome and Firefox show a shield icon in the URL bar).
From what I can tell:

Repo: https://github.com/webpack/analyse
Issue: https://github.com/webpack/analyse/issues/6
PR: https://github.com/webpack/analyse/pull/8


Add @SendPaperdoll, add Decay ITEM never sleep

Could you add more details in the changelog about when the paperdoll is requested?

I reworked the sector sleep function to avoid ALL attr_decay ITEM to never sleep. This will avoid to have useless item stuck at TIMER=0 on sleeping sector.
This change will fix this issue too : #467

@cbnolok Would you like to take some time to check this and/or comment plz.

I'd use the cansleep method to check for the decay flag

OK @cbnolok I made it. i was looking cansleep method but it exist only for sector. For item it's cantick. So I just considere attr_decay on the same way of item with flag CAN_No_Sleep.


The UI of the Shipping Address is not displaying properly in the Shop Front Customer Orders section.

Describe the bug
After completing the order with shipment and checking the product details in the Shop Front Order View section, we can observe that the address text appears faded.
Steps To Reproduce
Steps to reproduce the behavior:

Go to Shop Front  -> Please a Simple product to order -> Complete Checkout process.
Go to Admin -> Complete the Invoice and Shipment process.
Go to Shop Front -> Customer Profile -> Orders -> View Order -> Check the billing and Shipping Address.
See that the text colour is faded.

Expected behavior
Text Must Appear clear, please check  the screenshot -> https://prnt.sc/t0Pmv76ltqOd
Screenshots
Currently we can see that the text is faded -> https://prnt.sc/ZIq16C94S_rt

Checked and Found that the issue has been fixed and working fine. I can check and found that the Shipping addresses details are now appearing clear.
Please check the screenshots below.
https://prnt.sc/raidSWZ_L52h
https://prnt.sc/eaZfpT_OEKYg

Checked and found that the issue has been fixed and working fine, please check  the screenshots below. PR has been merged and hence I am closing the issue.
Screenshots
https://prnt.sc/pn6B2i7sslTy
https://prnt.sc/c11yDyYQOulE
https://prnt.sc/_mteVJAed6-u


[FEAT] Add CLA to project

Describe the feature
We were recommended to have a Contributor License Agreement (CLA) early rather than later.
Consider https://cla-assistant.io/

After some research, it seems like the CLA is somewhat perceived as anti-contributor and is done solely for the benefit of the company. This could discourage others from contributing to the project.
Marking as won't fix for now until a further decision.


Multiple Arrays in Dynamic List

I am using NativeBase for my code.
Hello, I'm wondering if there is a way to iterate through more than one array when creating a dynamic list?
<Container>
  <Content>
     <List dataArray={items, items2} renderRow={(data,data2) =>
        <ListItem>
            <Text>{data}</Text>
            <Text note>{data2}</Text>
        </ListItem>
     } />
  </Content>
</Container>

Could this be done? What's the correct syntax because the above doesn't work! Any help would be much appreciated.
Ref: Stack Overflow

#750


Additional Questions in the FAQ

Customers are asking basic questions about the integration extension, can we add the following questions to the doc page

If I remove the MDE.Linux extension will this remove MDE from the server?
Does the MDE.Linux extension configure the MDE on the server?
How do I remove MDE from my servers without disabling Defender for Server?
I transferred my subscription between tenants and now MDE.Linux extension wont deploy?
How long does it take for the MDE.Linux extension to deploy?
Can I deploy the MDE.linux extension manually?
Can I pass any configuration through Security Center to MDE?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 970863a5-ab27-6c83-9496-b025dd6bf323
Version Independent ID: a1f053f5-1004-6b6b-8b37-bc31599aa23b
Content: Using Microsoft Defender for Endpoint in Microsoft Defender for Cloud to protect native, on-premises, and AWS machines.
Content Source: articles/defender-for-cloud/integration-defender-for-endpoint.md
Service: defender-for-cloud
GitHub Login: @memildin
Microsoft Alias: memildin

@phduf , Thanks for your feedback. We have assigned this request to the respective content owner for updating the document accordingly.

Hi @phduf, thanks for the questions and for taking the time to help us improve the docs.
Your questions in order:

If I remove the MDE.Linux extension will this remove MDE from the server?
No. There's a new section on this page, Remove Defender for Endpoint from a machine, that explains the steps required to removed MDE from servers.

Does the MDE.Linux extension configure the MDE on the server?
Yes.

How do I remove MDE from my servers without disabling Defender for Server?
Follow the steps in Remove Defender for Endpoint from a machine.

I transferred my subscription between tenants and now MDE.Linux extension wont deploy?
This information is already present on the page. Search for "Tenant".

How long does it take for the MDE.Linux extension to deploy?
Up to 12hrs for existing machines. For machines created after the integration is enabled, it only takes up to one hour.

Can I deploy the MDE.linux extension manually?
No.

Can I pass any configuration through Security Center to MDE?
No. This isn't supported.

I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
This documentation page is going to get refreshed in the coming 48hrs, and we'll incorporate the information discussed here.
#please-close


Add Accept header by default

It looks like the listener is only able to consume data formatted as text/event-stream, since that's the case, is there a good reason not to automatically set the Accept header to that mimetype, since nothing else is actually accepted?

First of all, Thanks to @pratikbaid3 for this package. This issue led me to create my own package with better error handling and reconnection logic.
Check it out, EventFlux.


Cannot clone private Git repository as an input PipelineResource in tekton task

Expected Behavior
Clone the private Git repository using the supplied secret.
Actual Behavior
Fails with a misleading error.
Steps to Reproduce the Problem
As documented in https://github.com/tektoncd/pipeline/blob/master/docs/resources.md I have configured a private GitHub repository as a PipelineResource for a task, and have created the relevant secret as well:
---
apiVersion: v1
kind: Secret
metadata:
  name: github-secrets
type: Opaque
data:
  token: github_personal_access_token_secret # in base64 encoded form
---
apiVersion: tekton.dev/v1alpha1
kind: PipelineResource
metadata:
  name: my-repo-git
spec:
  type: git
  params:
    - name: revision
      value: master
    - name: url
      value: https://github.my-company.com/my-team/my-repo.git
  secrets:
    - fieldName: authToken
      secretName: github-secrets
      secretKey: token

Now when I am using the above PipelineResource as an input to a task:
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: my-task
spec:
  inputs:
    resources:
      - name: my-repo-git
        type: git
  steps:
    - name: print-info
      image: image-registry.openshift-image-registry.svc:5000/default/my-task-runner-image:latest
      imagePullPolicy: Always
      command: ["/bin/sh"]
      args:
        - "-c"
        - >
          echo "List the contents of /workspace, expecting to find the Git repository in there" &&
          ls -R /workspace

I get the following error:
[test : git-source-my-repo-git-qhsvq] {"level":"warn","ts":1580370880.0396245,"logger":"fallback-logger","caller":"logging/config.go:69","msg":"Fetch GitHub commit ID from kodata failed: \"KO_DATA_PATH\" does not exist or is empty"}
[test : git-source-my-repo-git-qhsvq] {"level":"error","ts":1580370880.653762,"logger":"fallback-logger","caller":"git/git.go:40","msg":"Error running git [fetch --depth=1 --recurse-submodules=yes origin master]: exit status 128\nfatal: could not read Username for 'https://github.my-company.com': No such device or address\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:40\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:91\nmain.main\n\t/go/src/github.com/tektoncd/pipeline/cmd/git-init/main.go:39\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:198"}
[test : git-source-my-repo-git-qhsvq] {"level":"error","ts":1580370881.232096,"logger":"fallback-logger","caller":"git/git.go:40","msg":"Error running git [pull --recurse-submodules=yes origin]: exit status 1\nfatal: could not read Username for 'https://github.my-company.com': No such device or address\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:40\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:94\nmain.main\n\t/go/src/github.com/tektoncd/pipeline/cmd/git-init/main.go:39\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:198"}
[test : git-source-my-repo-git-qhsvq] {"level":"warn","ts":1580370881.2322857,"logger":"fallback-logger","caller":"git/git.go:95","msg":"Failed to pull origin : exit status 1"}
[test : git-source-my-repo-git-qhsvq] {"level":"error","ts":1580370881.2347631,"logger":"fallback-logger","caller":"git/git.go:40","msg":"Error running git [checkout master]: exit status 1\nerror: pathspec 'master' did not match any file(s) known to git.\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:40\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\t/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:97\nmain.main\n\t/go/src/github.com/tektoncd/pipeline/cmd/git-init/main.go:39\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:198"}
[test : git-source-my-repo-git-qhsvq] {"level":"fatal","ts":1580370881.2348266,"logger":"fallback-logger","caller":"git-init/main.go:40","msg":"Error fetching git repository: exit status 1","stacktrace":"main.main\n\t/go/src/github.com/tektoncd/pipeline/cmd/git-init/main.go:40\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:198"}

The error could not read Username for 'https://github.my-company.com': No such device or address indicates that it looks for a username. The sourceSecret in build configs has different format:
apiVersion: v1
kind: Secret
metadata:
  name: github-secrets
type: kubernetes.io/basic-auth
data:
  username: my-github-username
  password: github_personal_access_token_secret # in base64 encoded form

However, even when trying the above secret type I still get the same error.
How do I configure the secret for a private repository?
Additional Info
Related (though different) issues:

https://github.com/tektoncd/pipeline/issues/1603
https://github.com/tektoncd/pipeline/issues/1375

Hi, can I use any other git repo provider (such as a local one) with the tekton pipeline git resource?

@zertan Yes it should work with any git repo.  But you might find the git-clone task from the catalog more useful: https://github.com/tektoncd/catalog/tree/master/git
The git pipelineresource can be difficult to inspect/debug when there are problems fetching from a repo.

It doesn't work despite creating a secret with the recommended annotation and data fields
apiVersion: v1
kind: Secret
metadata:
  name: ssh-key
  annotations:
    tekton.dev/git-0: github.company.com # Described below
type: kubernetes.io/ssh-auth
data:
  ssh-privatekey: <base64 encoded>
  # This is non-standard, but its use is encouraged to make this more secure.
  known_hosts: <base64 encoded>

"msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin master]: exit status 128\nfatal: could not read Username for 'https://github.company.com': No such device or address\n"

@zertan Yes it should work with any git repo. But you might find the git-clone task from the catalog more useful: https://github.com/tektoncd/catalog/tree/master/git
The git pipelineresource can be difficult to inspect/debug when there are problems fetching from a repo.

now  have some plans   to  optimize this problem ？

It doesn't work despite creating a secret with the recommended annotation and data fields
apiVersion: v1
kind: Secret
metadata:
  name: ssh-key
  annotations:
    tekton.dev/git-0: github.company.com # Described below
type: kubernetes.io/ssh-auth
data:
  ssh-privatekey: <base64 encoded>
  # This is non-standard, but its use is encouraged to make this more secure.
  known_hosts: <base64 encoded>

"msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin master]: exit status 128\nfatal: could not read Username for 'https://github.company.com': No such device or address\n"

My performance is the same as yours, is there any solution for this issue
The same configuration, tekton pipeline 0.12 no problem, 0.13, 0.14 version will have problems

Please provide a copy of the Secret YAML, ServiceAccount YAML, and Task YAML that you're using.  Remove any sensitive data in those YAMLs.

"msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin master]: exit status 128\nfatal: could not read Username for 'https://github.company.com': No such device or address\n"

This error ^ implies that Tekton is not considering your secret as a valid SSH secret.  Unfortunately the error message isn't enough to know why.  It's also interesting that you mention this problem only started with 0.13.  It could be a bug or it could be that some of our validation or processing of secrets changed.  I don't remember that being the case but it would be great to see the YAMLs involved to try and work it out.

One other thing that would be really useful to help debug is the TaskRun YAML after the TaskRun has ended.  You can get this with kubectl get -o yaml taskrun <taskrun-name>.

any solution to this one?

Will need YAMLs described in my previous comments in order to help debug.  Remove any sensitive values before posting them.

@sbwsg can i put the service account inside 'Task' or 'PipelineResource' or 'Pipeline'? Because I don't have a 'TaskRun' for that use-case. and I want to use ssh key from a secret

It's not possible to include a service account in a Task, PipelineResource or Pipeline.  What's your specific use case?  It might help if you could offer a bit more info on what you're trying to do.

Wrote you in slack (k8s community)

@sbwsg @CoderPoet Does github.com that is used with ssh-auth qualify for "name" https://github? It sound like it could be caused by wrong protocol.
I would expect that with http protocol it looks only for basic-auth key. If that's the case how can you dynamically rewrite protocol?
"msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin master]: exit status 128\nfatal: could not read Username for 'https://github.company.com': No such device or address\n"

Hi  everyone
i am facing this issue when i am trying to clone from bitbucker
kubectl -n default logs build-docker-image-from-git-source-task-run-pod-ndjhq -c step-git-source-docker-source-qx994
{"level":"error","ts":1633453879.3368287,"caller":"git/git.go:54","msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin --update-head-ok --force develop]: exit status 128\nHost key verification failed.\r\nfatal: Could not read from remote repository.\n\nPlease make sure you have the correct access rights\nand the repository exists.\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:54\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:149\nmain.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:53\nruntime.main\n\truntime/proc.go:225"}
{"level":"fatal","ts":1633453879.3368847,"caller":"git-init/main.go:54","msg":"Error fetching git repository: failed to fetch [develop]: exit status 128","stacktrace":"main.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:54\nruntime.main\n\truntime/proc.go:225"}
secret
apiVersion: v1
type: kubernetes.io/ssh-auth
data:
config: (base 64 encoded)
known_hosts: (base 64 encoded)
ssh-privatekey:  (base 64 encoded)
kind: Secret
metadata:
creationTimestamp: null
annotations:
tekton.dev/git-1: bitbucket.org
name: ssh-key-secret
service account
apiVersion: v1
kind: ServiceAccount
metadata:
name: git-serviceaccount
secrets:

name: ssh-key-secret

please someone help me how to clone from bitbucket private repository

That's a very good answer. Thank you very much.

It worked well. Thank you for this answer


chore(rosetta): de-duplicate diagnostics early

Making sure diagnostics are always sorted and de-duplciated reduces
the amount of overhead pertaining to keeping diagnostics in memory
and could result in better overall performance (due to lower memory
pressure)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: c1ed8a1a3591f07c919f2a8b853427331b8e4f75
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 1f8b646159b726cc9b539b3eade10f37a6955c5d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


no-std cleanup

cleanup embedded test memory based on comments under https://github.com/rust-bitcoin/rust-bitcoin/pull/603#pullrequestreview-708333388
pull in secp256k1/alloc for no-std use

Apologies, this makes the embedded test fail.  Will look into it tomorrow.

Actually, the embedded test is fixed now, please take another look.

utACK 849ec3f

Why does this have label Minor API change? I don't see any API change.

It was probably my mistake (I thought that it is either major or minor API change, it can't be none)


Softly check whether the gpu is avalid and whether the index is availab…

issue: #485
issue: #57

kind/feature

/kind feature

issue: #57


⚠ ClamAV has degraded performance

In bfa5932, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 55 ms

Resolved: ClamAV performance has improved in a9a9fe4.


please add support for systemd's timesyncd

version: 9.4.1
The current NTP hook (50-ntp.conf) provides seamless support for NTP, OpenNTP and Chrony (in that order).
It would be desirable to add support for systemd's built-in NTP client (timesyncd).
The enclosed files currently used at Debian may provide useful starting points for this.
60-ntp-common.conf.txt
64-timesyncd.conf.txt

A different approach found on the Raspberry Pi forum.
Set NTP servers for systemd-timesyncd
confd=/run/systemd/timesyncd.conf.d
set_servers() {
mkdir -p "$confd"
(
echo "# Created by dhcpcd hook"
echo "[Time]"
echo "NTP=$new_ntp_servers"
) > "$confd/dhcp-ntp.conf"
# Tell timesyncd it has an updated configuration
systemctl try-reload-or-restart systemd-timesyncd
}
if $if_up; then
set_servers
fi

#6ab00c2de58936b30be48611e9d402ad51de5abb and #c872b2d6e074e71a622be8be5318989c7b83240b are follow on patches.

6ab00c2de58936b30be48611e9d402ad51de5abb and c872b2d6e074e71a622be8be5318989c7b83240b are follow on patches.


ASN.1: Refuse to encode to DER if non-optional items are missing [3.0]

Fixes #16026

This is like #16027, but for 3.0

The CI failure is only CMP related - perhaps @DDvO can look at it? I suppose the test makes some incorrect expectations?

I suppose the test makes some incorrect expectations?

I have no idea...  test/cmp_ctx_test.c is too macroised for me to follow, not to mention debug.

I came this far, by breaking on tasn_enc.c:373:
Breakpoint 1, asn1_template_ex_i2d (pval=0x5555559b99d0, out=0x0,
    tt=0x555555984800 <X509_ALGOR_seq_tt>, tag=-1, iclass=0)
    at ../master/crypto/asn1/tasn_enc.c:373
373	        ERR_raise(ERR_LIB_ASN1, ASN1_R_ILLEGAL_ZERO_CONTENT);
(gdb) bt
#0  asn1_template_ex_i2d (pval=0x5555559b99d0, out=0x0,
    tt=0x555555984800 <X509_ALGOR_seq_tt>, tag=-1, iclass=0)
    at ../master/crypto/asn1/tasn_enc.c:373
#1  0x00005555555d38f6 in ASN1_item_ex_i2d (pval=0x7fffffffc508, out=0x0,
    it=0x55555595ca40 <local_it>, tag=16, aclass=0)
    at ../master/crypto/asn1/tasn_enc.c:182
#2  0x00005555555d3f1f in asn1_template_ex_i2d (pval=0x7fffffffc508, out=0x0,
    tt=0x555555976130 <X509_CINF_seq_tt+80>, tag=-1, iclass=0)
    at ../master/crypto/asn1/tasn_enc.c:370
#3  0x00005555555d38f6 in ASN1_item_ex_i2d (pval=0x7fffffffc638, out=0x0,
    it=0x555555946ae0 <local_it>, tag=16, aclass=0)
    at ../master/crypto/asn1/tasn_enc.c:182
#4  0x00005555555d3f1f in asn1_template_ex_i2d (pval=0x7fffffffc638, out=0x0,
    tt=0x555555976280 <X509_seq_tt>, tag=-1, iclass=0)
    at ../master/crypto/asn1/tasn_enc.c:370
#5  0x00005555555d38f6 in ASN1_item_ex_i2d (pval=0x7fffffffc758, out=0x0,
    it=0x555555946b20 <local_it>, tag=16, aclass=0)
    at ../master/crypto/asn1/tasn_enc.c:182
#6  0x00005555555d33ba in asn1_item_flags_i2d (val=0x5555559b99b0,
    out=0x7fffffffc7f8, it=0x555555946b20 <local_it>, flags=0)
    at ../master/crypto/asn1/tasn_enc.c:62
#7  0x00005555555d3366 in ASN1_item_i2d (val=0x5555559b99b0,
    out=0x7fffffffc7f8, it=0x555555946b20 <local_it>)
    at ../master/crypto/asn1/tasn_enc.c:45
#8  0x00005555556eba26 in ossl_asn1_item_digest_ex (
    it=0x555555946b20 <local_it>, md=0x55555596a4e0 <sha1_md>,
    asn=0x5555559b99b0, data=0x5555559b9ae8 "", len=0x0, libctx=0x0, propq=0x0)
    at ../master/crypto/asn1/a_digest.c:64
#9  0x0000555555667485 in X509_digest (cert=0x5555559b99b0,
    md=0x55555596a4e0 <sha1_md>, data=0x5555559b9ae8 "", len=0x0)
    at ../master/crypto/x509/x_all.c:432
#10 0x000055555564f210 in ossl_x509v3_cache_extensions (x=0x5555559b99b0)
    at ../master/crypto/x509/v3_purp.c:421
#11 0x00005555555eb9b8 in OSSL_CMP_CTX_set1_srvCert (ctx=0x55555599b860,
    val=0x5555559b99b0) at ../master/crypto/cmp/cmp_ctx.c:649
#12 0x00005555555bc370 in execute_CTX_set1_get0_srvCert (
    fixture=0x5555559e4430) at ../master/test/cmp_ctx_test.c:736
#13 0x00005555555bc59a in test_CTX_set1_get0_srvCert ()
    at ../master/test/cmp_ctx_test.c:736
#14 0x00005555555c5d06 in run_tests (
    test_prog_name=0x7fffffffde8d "/home/levitte/gitwrk/openssl.net/official/_build/test/cmp_ctx_test") at ../master/test/testutil/driver.c:334
#15 0x00005555555c6358 in main (argc=1, argv=0x7fffffffdb38)
    at ../master/test/testutil/main.c:30
(gdb) p *tt
$1 = {flags = 0, tag = 0, offset = 0, field_name = 0x55555588e430 "algorithm",
  item = 0x5555555d6268 <ASN1_OBJECT_it>}

So ok, it's failing to encode an OBJECT IDENTIFIER, and that's part of a certificate.  Going to frame 9 gives me access to it:
(gdb) f 9
#9  0x0000555555667485 in X509_digest (cert=0x5555559b99b0,
    md=0x55555596a4e0 <sha1_md>, data=0x5555559b9ae8 "", len=0x0)
    at ../master/crypto/x509/x_all.c:432
432	    return ossl_asn1_item_digest_ex(ASN1_ITEM_rptr(X509), md, (char *)cert,
(gdb) p *cert
$4 = {cert_info = {version = 0x0, serialNumber = {length = 0, type = 2,
      data = 0x0, flags = 128}, signature = {
      algorithm = 0x5555559395a0 <nid_objs>, parameter = 0x0},
    issuer = 0x5555559b6c00, validity = {notBefore = 0x5555559b9960,
      notAfter = 0x5555559e4520}, subject = 0x5555559b9d60,
    key = 0x5555559e4340, issuerUID = 0x0, subjectUID = 0x0, extensions = 0x0,
    enc = {enc = 0x0, len = 0, modified = 1}}, sig_alg = {
    algorithm = 0x5555559395a0 <nid_objs>, parameter = 0x0}, signature = {
    length = 0, type = 3, data = 0x0, flags = 128}, siginf = {mdnid = 0,
    pknid = 0, secbits = 0, flags = 0}, references = 1, ex_data = {ctx = 0x0,
    sk = 0x0}, ex_pathlen = -1, ex_pcpathlen = -1, ex_flags = 0,
  ex_kusage = 0, ex_xkusage = 0, ex_nscert = 0, skid = 0x0, akid = 0x0,
  policy_cache = 0x0, crldp = 0x0, altname = 0x0, nc = 0x0,
  rfc3779_addr = 0x0, rfc3779_asid = 0x0,
  sha1_hash = '\000' <repeats 19 times>, aux = 0x0, lock = 0x5555559e44e0,
  ex_cached = 0, distinguishing_id = 0x0, libctx = 0x0, propq = 0x0}

... and just for clarity:
(gdb) p cert->cert_info.signature
$5 = {algorithm = 0x5555559395a0 <nid_objs>, parameter = 0x0}

algorithm points at nid_objs[0], which is the spot for NID_undef.  In other words, no signature algorithm is set, which is invalid for the AlgorithmIdentifier structure (as the algorithm value isn't optional).  So we're dealing with an incomplete certificate.
On the other hand, one might wonder why ossl_x509v3_cache_extensions() tries to take a digest of the certificate, is that necessary?  I haven't looked into that yet.

So it appears that this particular test tries to set an incomplete certificate (signature algorithm is unset):
https://github.com/openssl/openssl/blob/0007ff257c95f5cd046799e492436f41caf4ecb2/test/cmp_ctx_test.c#L822
The result is that OSSL_CMP_CTX_set1_srvCert() tries to call ossl_x509v3_cache_extensions(), which fails because the certificate fingerprint couldn't be calculated (the calculation is done on the DER encoding of the certificate, but since it's incomplete, the DER encoding will fail with ASN1_R_ILLEGAL_ZERO_CONTENTS).

I suppose that for that test, the following lines:
https://github.com/openssl/openssl/blob/0007ff257c95f5cd046799e492436f41caf4ecb2/test/cmp_ctx_test.c#L341-L342
... translates to:
    X509 *val1_to_free = X509_new();
    X509 *val1 = val1_to_free;

and with set_fn == OSSL_CMP_CTX_set1_srvCert, it's clear why the following test fails:
https://github.com/openssl/openssl/blob/0007ff257c95f5cd046799e492436f41caf4ecb2/test/cmp_ctx_test.c#L371-L374

I suppose replacing all the X509_new() calls in the test with calls to X509_dup() of a real certificate should fix it?

I suppose replacing all the X509_new() calls in the test with calls to X509_dup() of a real certificate should fix it?

The underlying issue is that X509_new() produces an invalid X.509 structure, not having the mandatory fields.
Indeed, copying a real cert would be a workaround.

(irrelevant comment removed)

The stack trace you originally provided here was of interest.
#9  0x0000555555667485 in X509_digest (cert=0x5555559b99b0,
    md=0x55555596a4e0 <sha1_md>, data=0x5555559b9ae8 "", len=0x0)
    at ../master/crypto/x509/x_all.c:432
#10 0x000055555564f210 in ossl_x509v3_cache_extensions (x=0x5555559b99b0)
    at ../master/crypto/x509/v3_purp.c:421
#11 0x00005555555eb9b8 in OSSL_CMP_CTX_set1_srvCert (ctx=0x55555599b860,
    val=0x5555559b99b0) at ../master/crypto/cmp/cmp_ctx.c:649
#12 0x00005555555bc370 in execute_CTX_set1_get0_srvCert (
    fixture=0x5555559e4430) at ../master/test/cmp_ctx_test.c:736
#13 0x00005555555bc59a in test_CTX_set1_get0_srvCert ()
    at ../master/test/cmp_ctx_test.c:736

It shows why part of the certificate get/set test failed, namely only those calling OSSL_CMP_CTX_set1_*():
They call ossl_x509v3_cache_extensions() for checking the validity of the cert, which among others has the side effect of hashing the cert contents, which now fails for a incomplete ASN.1 structures.

@t8m, many thanks for fixing the test

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged
2296cc34f3c700b0bc5c45f35e56641fbb840db3 TEST: Check that i2d refuses to encode non-optional items with no content
4cd473518777766e303cebe89c5a056dbec7e513 ASN.1: Refuse to encode to DER if non-optional items are missing
f0f4de4e50eaa11eb5a51fa6e7756d4a0876557e Fix test/asn1_encode_test.c to not use ASN1_FBOOLEAN
50d0a51d6dc83815a6fca5c00c711ffcf407a214 Fix test/asn1_encode_test.c to handle encoding/decoding failure
6bfd3e51c04faa97ed98f38e35bd9bb5294b9070 test_cmp_ctx: Avoid using empty X509 with i2d

I suppose replacing all the X509_new() calls in the test with calls to X509_dup() of a real certificate should fix it?

The underlying issue is that X509_new() produces an invalid X.509 structure, not having the mandatory fields.
Indeed, copying a real cert would be a workaround.

As I wrote above, the quick solution taken here is just a workaround.
For the root cause and my proposal to solve it, see #16043.


fix(webpack): chunks order

Upgrades awesome-typescript-loader && sets order of chunks.

Inspiration took from: https://github.com/ampedandwired/html-webpack-plugin/issues/140#issuecomment-263927464

fix is moved to https://github.com/wc-catalogue/blaze-elements/pull/125

Why are you doing these kind of things @elmariofredo ? Pls next time rather merge to master and rebase your own branch against it.


complete translation of UI

The UI should handle:

[ ] index.md in different languages

[ ] show only courses / lessons for selected language

[ ] save / restore state with localStorage

[ ] propose lesson in different language if languages is set in YAML
---
title: Straffespark
languages:
  nn-NO: straffespark.nn.md
  en-GB: penalty.md
---

Ref: https://github.com/kodeklubben/oppgaver/issues/170

Will be fixed in codeclub-viewer


No Code for hit@10 in result_eval.py.

I couldn't find any code to calculate hit@10 metric for the tail and head prediction in the result_eval file.
So, I wrote a piece of code after the line number 68. Let me know if it is correct or not?
tail_array = np.array(ranks_tail)
head_array = np.array(ranks_head)
hit_at_10_tail = tail_array[np.where( tail_array < 10 ) ]
hit_at_10_head = head_array[np.where( head_array < 10 ) ]
print('Epoch {} :  test_tail HIT@10 {}\t test_head HIT@!) {}'.format(k ,len(hit_at_10_tail)/float(len(tail_array))*100, len(hit_at_10_head)/float(len(head_array))*100))

Hi Smit,
This code looks fine to me. We will update result_eval.py to
output hits@10. Sorry for the inconvenience caused.
On Mon, Apr 22, 2019, 6:05 PM Smit Shah<EMAIL_ADDRESS>wrote:

I couldn't find any code to calculate hit@10 metric for the tail and head
prediction in the result_eval file.
So, I wrote a piece of code after the line number 68. Let me know if it is
correct or not?
tail_array = np.array(ranks_tail)
head_array = np.array(ranks_head)
hit_at_10_tail = tail_array[np.where( tail_array < 10 ) ]
hit_at_10_head = head_array[np.where( head_array < 10 ) ]
print('Epoch {} : test_tail HIT@10 {}\t test_head HIT@!) {}'.format(k
,len(hit_at_10_tail)/float(len(tail_array))*100,
len(hit_at_10_head)/float(len(head_array))*100))
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/malllabiisc/HyTE/issues/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUB5C7L7AJ47MJCMKHAPBDPRWWIBANCNFSM4HHPNXCA
.


Add reaction_added and reaction_removed events to RTM client code

Looking in websocket_misc.go, it appears to be missing these two events.

whoops was just looking in the wrong place, all good here.


Mac support

Hello! Thank you for the awesome tool!
Just want to let you know that on Mac with iTerm2 or standard Terminal the combinations around <Any key>+Enter are not working.
The one way to run code on Mac is to switch to Vi mode and press Enter.
It will be cool to fix some day.
Thanks!

Euporie uses the CSI-u terminal mode to recognise these key-sequences (which traditionally is not possible on a vt100 terminal).
I'm not sure that the standard MacOS terminal supports CSI-u, so you'll probably have to use the Ctrl + e and Ctrl + r key-bindings instead.
iTerm2 does support CSI-u key-bindings, but I believe you have to enable them in the settings:

There are instructions for other terminals in euporie's documentation here.
I've recently made some changes in the dev branch which might help with this, and terminal configuration unnecessary for some terminals - see https://github.com/joouha/euporie/issues/61.


Question: is there a way to pip install starfish

Is there a way to pip install starfish , so that it can be used in a different project (e.g. Invoke?)
Squid-py's docs seem to suggest this could work (off a Github branch)
pip install git+https://github.com/oceanprotocol/squid-py.git@develop
Would a similar thing work for starfish-py?

Just wanted to add that when I try this: pip install git+https://github.com/DEX-Company/starfish-py@develop, import starfish does work.
However some squid_py imports fail:
Using default logging settings. Traceback (most recent call last):   File "purch_asset.py", line 21, in <module>     from squid_py import ACCESS_SERVICE_TEMPLATE_ID ImportError: cannot import name 'ACCESS_SERVICE_TEMPLATE_ID' ,
despite importing squid_py in the same fashion

@billbsing post updating with the new branch, I get a different error:
To import, I do
virtualenv -p /usr/bin/python3.6 venv
source venv/bin/activate
pip install git+https://github.com/DEX-Company/starfish-py@develop
python3 test_squid_agent.py

which returns this error
(venv) kiran@kiran-ThinkPad-L460:~/src/github/swagger-codegen/out/flask-invoke$ python3 test_squid_agent.py
Using default logging settings.
2019-02-22 19:20:27 kiran-ThinkPad-L460 config[762] DEBUG Config: loading from dict {'keeper-contracts': {'keeper.url': 'http://localhost:8545', 'keeper.path': 'artifacts', 'secret_store.url': 'http://localhost:12001', 'parity.url': 'http://localhost:8545'}, 'resources': {'aquarius.url': 'http://localhost:5000', 'brizo.url': 'http://localhost:8030', 'storage.path': 'squid_py.db'}}
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded Dispenser at 0x69b92271dE6Bb09F11e9927EbD04db0afb284467
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded OceanToken at 0x0Be67eC5a5908Ba495A5be4d320573EE98c44068
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded DIDRegistry at 0x75036ff443d6493Bf5108df25700000B0E9975Ec
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded ServiceExecutionAgreement at 0xEF975E9a229ff4c87C1d5f55d55119A7954056d8
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded PaymentConditions at 0x81AEc6002ca81cec74AC78ab142Fe3526f879455
2019-02-22 19:20:27 kiran-ThinkPad-L460 keeper[762] DEBUG Loaded AccessConditions at 0x47ADe42c35134AC399b276Ff13D01EF3Db0f71D5
2019-02-22 19:20:27 kiran-ThinkPad-L460 squid_py.keeper.diagnostics[762] INFO Keeper contract artifacts (JSON abi files) at: /home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/artifacts
2019-02-22 19:20:27 kiran-ThinkPad-L460 squid_py.keeper.diagnostics[762] INFO Using keeper contracts from network spree, network id is 8996
2019-02-22 19:20:27 kiran-ThinkPad-L460 squid_py.keeper.diagnostics[762] INFO Looking for keeper contracts ending with ".spree.json", e.g. "ServiceExecutionAgreement.spree.json".
2019-02-22 19:20:27 kiran-ThinkPad-L460 root[762] INFO Finished loading keeper contracts:
	Dispenser: 0x69b92271dE6Bb09F11e9927EbD04db0afb284467
	OceanToken: 0x0Be67eC5a5908Ba495A5be4d320573EE98c44068
	DIDRegistry: 0x75036ff443d6493Bf5108df25700000B0E9975Ec
	ServiceExecutionAgreement: 0xEF975E9a229ff4c87C1d5f55d55119A7954056d8
	PaymentConditions: 0x81AEc6002ca81cec74AC78ab142Fe3526f879455
	AccessConditions: 0x47ADe42c35134AC399b276Ff13D01EF3Db0f71D5
Traceback (most recent call last):
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/web3/contract.py", line 1363, in call_contract_function
    output_data = decode_abi(output_types, return_data)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/abi.py", line 96, in decode_abi
    return decoder(stream)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/decoding.py", line 118, in __call__
    return self.decode(stream)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_utils/functional.py", line 46, in inner
    return callback(fn(*args, **kwargs))
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/decoding.py", line 164, in decode
    yield decoder(stream)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/decoding.py", line 118, in __call__
    return self.decode(stream)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/decoding.py", line 186, in decode
    raw_data = self.read_data_from_stream(stream)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/eth_abi/decoding.py", line 296, in read_data_from_stream
    len(data),
eth_abi.exceptions.InsufficientDataBytes: Tried to read 32 bytes.  Only got 0 bytes

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "test_squid_agent.py", line 159, in <module>
    test_asset()
  File "test_squid_agent.py", line 80, in test_asset
    assert ocean.accounts
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/starfish/ocean/ocean.py", line 163, in accounts
    model = SquidModel(self)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/starfish/models/squid_model.py", line 33, in __init__
    self._squid_ocean = self.get_squid_ocean()
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/starfish/models/squid_model.py", line 233, in get_squid_ocean
    return SquidOcean(config)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/squid_py/ocean/ocean.py", line 92, in __init__
    Diagnostics.check_deployed_agreement_templates()
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/squid_py/keeper/diagnostics.py", line 18, in check_deployed_agreement_templates
    template_owner = keeper.service_agreement.get_template_owner(ACCESS_SERVICE_TEMPLATE_ID)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/squid_py/keeper/service_execution_agreement.py", line 130, in get_template_owner
    return self.contract_concise.getTemplateOwner(template_id)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/web3/contract.py", line 879, in __call__
    return self.__prepared_function(*args, **kwargs)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/web3/contract.py", line 892, in __prepared_function
    return getattr(self._function(*args), modifier)(modifier_dict)
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/web3/contract.py", line 1106, in call
    **self.kwargs
  File "/home/kiran/src/github/swagger-codegen/out/flask-invoke/venv/lib/python3.6/site-packages/web3/contract.py", line 1385, in call_contract_function
    raise BadFunctionCallOutput(msg) from e
web3.exceptions.BadFunctionCallOutput: Could not transact with/call contract function, is contract deployed correctly and chain synced?


Support read-only dependencies

I'm on a team that owns our full stack, and we're hoping to move full deployment of our stack to Terraform with the help of Terragrunt. We have an AWS account that we all share for development and staging. We have some Terraform that's run as a singleton for the account, which bootstraps the entire account for use by our team, and some that we run that's instanced once per developer, to set up per-developer instances of our environments for development. The latter Terraform relies on outputs from the former Terraform.
When developers are running their per-dev Terraform, they need to be careful to not accidentally also run the singleton Terraform, as that Terraform isn't intended to change in the course of development and is depended on by the rest of the team. It's particularly disruptive if the singleton Terraform accidentally gets wrapped up in a destroy (this has happened at least once).
It would be nice to have a way to natively fetch outputs in Terragrunt from the singletons without the risk that the singletons will actually be run.
I'm aware of --terragrunt-strict-include, but it comes with drawbacks for this use-case.

It's opt-in, rather than opt-out. All it takes is one dev to forget to use this flag when running Terragrunt, and they can potentially change singleton state relied on by the rest of the team. Now someone has to stop working and mount a cleanup operation to unblock the rest of the team. Even something like #1509 is opt-in and could be forgotten by a dev.
It's, frankly, tedious. The dev will be running terragrunt [run-all] apply repeatedly to iteratively test changes, and they will have to pass --terragrunt-strict-include every time, possibly multiple times per call depending on the folder structure.

What I envision for this is an option in the dependency block called read_only, or perhaps skip_run if you want it to match with skip_outputs more closely. This effectively translates the dependency block into a terraform_remote_state data source. Outputs can be read from it, but state-modifying commands are never run in it.
The way I'm planning to work around this right now is to write a data module that accumulates a bunch of terraform_remote_state data sources for all of the singleton Terragrunt modules. Devs will use dependencies on this module in place of dependencies on the regular singleton modules. It will provide a read-only interface into the singleton state.

It doesn't quite make sense to me to label this on the dependency block, as the scope of the dependency block is read-only already. For example, running terragrunt apply on a single module does not propagate the apply to the dependencies.
This use case is supposed to be handled by the skip attribute. Does it work if you set that to true on the modules you don't want to touch?

We have something like this folder structure:
prod
    global
    prod-1
    prod-2
    prod-3
stage
    global
    stage
dev
    dev

prod is in its own account. dev and stage share an account. The stuff in stage/stage and dev/dev are identical, and they both have dependencies on the stuff in stage/global. There is no dev/global, because the stuff in stage/global is configured once for the account, and dev and stage are sharing the account.
From dev/dev, I want to be able to have dependency blocks that reach back into ../../stage/global to read outputs without the risk than anything in stage/global will actually run, because it shouldn't run in the course of dev. I can't put skip on the stuff in stage/global, because when we actually deploy stage, that stuff does need to run.


Fix Wasm capitalization in code comments

According to the WebAssembly spec, Wasm is a contraction of “WebAssembly”, not an acronym, hence not using all-caps: https://webassembly.github.io/spec/core/intro/introduction.html#wasm

@swift-ci test


fix: Error exception occurs when user with pending activation tries magic-link login

Fixes #465

The user has not activated their account, maybe because they have not received the email for activation.

Well, this is not a reason for us to allow the magic link to be sent to it email.
If he did not receive the activation email, he should apply again from 'auth/a/show', not through the magic link.

If the session is expired, no way to get auth/a/show when they forget the password.
If they know their password, they don't need to go magic link page.
They can go login page.


mount support on windows without cgo

What does this PR change? What problem does it solve?
This PR adds mount support on window using winfsp and cgofuse. Besides the name implies it it does NOT require cgo on windows and cross compiles without any problems.
Basic functionality is working but code needs cleanup and is lacking documentation and refactoring.
To test it I prepared zip file that contains some bat files to demo the functionality:
mount_demo.zip
Please compile restic for windows and install winfsp. Then unzip the provided zip file. Copy the compiled binary to the mount_demo folder and run demo.bat. This will do the following:

run init.bat: initialize a repository
run backup.bat: create some snapshots from the provided data folder
run mount.bat: mount the created repsoitory as drive r:

If the drive does not show up immediately press F5 to refresh windows explorer.
I hope to get some feedback on how to continue working on this PR.
Was the change discussed in an issue or in the forum before?
https://github.com/restic/restic/issues/2791
Checklist

[x] I have read the Contribution Guidelines
[x] I have enabled maintainer edits for this PR
[ ] I have added tests for all changes in this PR
[x] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[ ] I'm done, this Pull Request is ready for review

fgma, is it possible for you to update this PR for curent master branch ?
Thanks

@AlexpFr I could but the idea was to replace the backend code with a common abstraction layer used also for webdav or other frontends: https://github.com/restic/restic/pull/2860

Yes I saw this PR as well but haven't tested it yet.
I am currently using winfsp to mount sshfs network drives and it works really well.
That’s why I’m interested in your work.
What method do you currently use to mount backups on windows? Fuse, webdav or another?
I quickly tried to integrate your PR into the master branch but there have been a lot of commits since then, I think it would be wise to let you review your code (if you find it useful).

Any news on this?

@ioncodes If there had been, it would be in here, so no.

Any updates about this PR? Would be great if we could mount repositories and browse them on Windows like on Linux.

No updates, if there was they would be shown in this PR thread.

Any updates on this? Would be an excellent feature

@jkiebzak No, if there were it would have shown in this thread.

Does anyone know of any other option besides WSL?

Replying to helpfully bump this PR.

I'd really like to finish this but I've not received any feedback yet. I've already asked in https://github.com/restic/restic/pull/2860 because it is related and could share code.

The main reason why there hasn't been any feedback to this PR so far is that it is an absolutely gigantic amount of code. Properly reviewing the whole PR would require at least a full day, most likely more. The other problem is that the PR looks like it needs a substantial rewrite.
As already indicated by the number of added and removed lines of code, there is essentially zero code sharing between the existing fuse implementation and this PR. That is not acceptable, we cannot maintain two completely separate implementations as that will just end in a maintenance nightmare. The only acceptable way to structure the implementation is to separate the fuse code into a data model (shared by both implementations!!!) and presentation code which just transforms that data model into the format required for the particular fuse library. For the snapshot pseudo-directories most of the refactoring work is done by #2913 which separates things into a generic SnapshotDirStructure and the fuse library adaption by SnapshotDir.
To name a few specific problems (the list is probably far from complete):

Even though the two implementations are quite different, it feels like the completely different file name structure is overkill. Why not rename fs_node_root_windows.go to root_windows.go and so on?
FsNodeFiltered, FsNodeRoot and FsNodeSnapshotsDir can largely be replaced by the unified implementation in #2913.
FsNodeSnapshotDir should share more code with the existing file.go implementation, in particular I have the Read method in mind.
The mount function in cmd/restic/cmd_mount.go could also share more code between the fuse implementations.

My impression after scrolling through the code is that the FsNode implementation which uses path []string is an unmitigated disaster. It looks like a considerable amount of the whole code is just busy with constantly reimplementing path walking, which is necessary again and again for every single method and thus is likely broken in some places. An example of the latter is ReadDir and GetAttributesinFsNodeSnapshotsDir, only one of them calls NewFsNodeSnapshotDirFromSnapshot`, such that the behavior differs depending on the order in which these methods are called.
The path walking must be implemented generically and not repeated for each node (and especially not for each method), such that the resulting interface is similar to that of the currently used fuse library. If that would be too inefficient, I'd be willing to settle for one Lookup method per FsNode type, but definitely not one per method.
The other question is the choice of fuse library. Is cgofuse + winfsp the only possible solution for windows? Or is there maybe a CGO-less fuse library which works for all operating systems? The latter would be a much better solution than having two different fuse libraries in use. Especially, as the currently used library is no longer supported for recent macOS versions.

If this PR would require that much rewriting maybe it would be better to put this work into WebDAV (#485)? Especially as this could also help Mac users accessing snapshots in an easier way (#3096) . Or would cgofuse also solve the Mac issue?
Personally I have nearly no programming knowledge but wanted to dive into Go since a while. But I guess as a first "something" after working through a book or two this might be a bold project...

I consider the current state of this PR a tech demo.  As I already stated in my initial post:

Basic functionality is working but code needs cleanup and is lacking documentation and refactoring.

To continue working on it I need some specific feedback about the future of restic:

Will cgofuse ever be accepted as a dependency?
Should there be a common backend shared by fuse/cgofuse/webdav which create some kind of abstract filesystem interface? How should the interface look like?
What about the webdav backend? Is it dead or should this be a higher priority for now? I already offered help there multiple times.

What about the webdav backend?

Is it possible to serve owership and permissions with webdav backend? I guess this is not possible. If so Webdav can't be a replacement for fuse mounts.

To continue working on it I need some specific feedback about the future of restic:
* Will cgofuse ever be accepted as a dependency?

* Should there be a common backend shared by fuse/cgofuse/webdav which create some kind of abstract filesystem interface? How should the interface look like?

* What about the webdav backend? Is it dead or should this be a higher priority for now? I already offered help there multiple times.

We don't want CGO as a build dependency. For Windows cgofuse would tolerable as it does not actually require CGO. This directly leads to my previous question: are there other alternative libraries which could cover all platforms and not not require CGO?
That common backend already exists to a large part: SnapshotsDirStructure and the Snapshot/Tree/Node/Repository can already be shared. The remaining easily sharable code of the current fuse implementation seems to largely concentrate on reading file parts and loading a directory (approx. 200 lines of code). Most other code just appears to be busy with converting the existing data model into a format suitable for the fuse library.
The only "significant" remaining code duplication after that would be the dir and the SnapshotsDir structs which both represent directories. Both have completely different behavior, so the only duplication are a few lines of code returning the directory attributes and entries. That is small enough to get rid of later on. (If necessary we can let the SnapshotsDirStructure generate fake restic.Nodes and get rid of the little duplication that way) So right now, introducing a new abstraction sounds like overkill to me.
Regarding WebDAV: we're still interested in such a mount backend. Right now, my impression is that interest in a windows fuse implementation is somewhat similar to that in WebDAV. So I don't have a strong opinion in either direction. But I haven't looked into the limitations of WebDAV.

Is it possible to serve owership and permissions with webdav backend?
RFC3744  is relating to this.
Further my intention was not to get rid of fuse mounts but rather have a second option for windows/macos.

We don't want CGO as a build dependency. For Windows cgofuse would tolerable as it does not actually require CGO. This directly leads to my previous question: are there other alternative libraries which could cover all platforms and not require CGO?

I took a look myself and ended up with the following libraries: https://github.com/restic/restic/issues/3096#issuecomment-1312490638 . Of those only cgofuse works on Windows and does not require CGO. If we decided to accept cgofuse, then we'd also get support for several other operating systems for free.
In short, we can stick with cgofuse for windows.


refactor(ast_tools): centralize logic for outputting files

Move all logic related to formatting and outputting files into one place.

#6900  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

Merge activity

Oct 25, 5:04 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Samples for unhide all rows/cols and freeze selection to excel-sampes

As part of my intern project on Storage & Intelligence, I've created two new samples that will be present in the Samples tab for Office Scripts. Alex Jerabek requested that these samples also be added to the documentation to increase sample code coverage.

Docs Build status updates of commit 9372765:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @mleach26! I'll give this PR a review soon.

Docs Build status updates of commit d26bd4a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a326fa9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Remove version: REALiX.HWiNFO version 7.66

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://downloads.sourceforge.net/project/hwinfo/Windows_Installer/hwi_766.exe
Status Code: 200
(Automated message - build 896)

Close with reason: Package still available.;


Add helper for consistent db and in-memory state access

Right now, in BlockchainProvider::get_state for example, we create many database transactions. If used outside of the tree, the in-memory state that is accessed during the life of the method may also change.
This means, if the get_state provider method is called outside of the tree, it could return inconsistent results or even fail. To solve this, we should add some helpers that acquires a read lock / transaction on the in-memory state, and the database. These helpers should allow methods like get_state to be implemented without opening multiple db transactions, while accessing a single view of the in-memory chain state.

Can you assign me to this?


Trasforma file image

The mimetype affected
Please enter the mimetype here
The change to make
Add/remove/change description or link, etc
Supporting link
A link to somewhere that authoritatively says why this change should be made

I'm guessing this is probably a request for a converter. Probably outside of the scope, if you're on mac you can convert by exporting the file again after opening it in preview.


Add CliffordTargetGateset and deprecate ConvertToSingleQubitCliffordGates and ConvertToPauliStringPhasor

Part of https://github.com/quantumlib/Cirq/issues/5028

@dabacon This is ready for a re-review. PTAL!


URL Update

This link to "Cisco Cloud Service Router(CSR) VWAN Deployment Guide" points to the same page you're on. Can this be updated? Trying to find information on how this is configured.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d60e984-8f53-bdfa-baa7-a03ea0d5a2d2
Version Independent ID: 0db8b738-ddaf-419a-8e9b-cd63fb8dbbbb
Content: Azure Virtual WAN partners and locations
Content Source: articles/virtual-wan/virtual-wan-locations-partners.md
Service: virtual-wan
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@birdnathan, Thanks for reaching out. We will investigate and update this thread.

@birdnathan, Appreciate your patience. The doc has been edited accordingly and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


html editor

Feature request type
New component
Component name
Editor
Is your feature request related to a problem?
No response
Describe the solution you'd like
what about html editor?
your awesome component have anything but editor. i think it is necessary now, isn't?
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What about a Markdown editor?

Look at https://github.com/MyNihongo/MudBlazor.Markdown
Also, for a Quill-based HTML editor we have https://github.com/henon/MudBlazor.Extensions.MudEditor (currently worked on by @jcphlux) and which should replace the older https://github.com/henon/MudBlazor.Extensions.TextEditor
As both Markdown and HTML-Editor need JS libraries and our policy is that all components should be self-contained, I don't think we'll add such to the core MudBlazor library. But we can have unlimited extension libraries and for those there are no policies or limits.

awesome , tanx for it :D


Failures in lates one_mode branch

I really like the new double click feature. It makes the gui much more intuitive. However, I realized two bugs:

When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

When selecting the ForEach node and double clicking on the canvas nothing happens. I guess the color definition is missing. At least this is the error I get when I try to load my example workflow.

When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

@JNmpi, unfortunately I can't duplicate this on my machine. I agree the described behaviour is bad, but we might need to look at it next time we're on Zoom together so we can track down where it comes from.

-When selecting the ForEach node and double clicking on the canvas nothing happens. I guess the color definition is missing. At least this is the error I get when I try to load my example workflow.

Yep, your guess was spot-on. Fixed in #19.

When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

Nevermind, I can get this to happen. It occurs only when clicking on the body of the already selected node. IMO this shouldn't even be deselecting it -- it violates the spec draft in CanvasObject.__doc__. Shouldn't be hard to fix.

When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

Nevermind, I can get this to happen. It occurs only when clicking on the body of the already selected node. IMO this shouldn't even be deselecting it -- it violates the spec draft in CanvasObject.__doc__. Shouldn't be hard to fix.

Fixed in #20 now.


Better handling of disk space errors

Running out of persistent disk space causes a cascading error

ES indicies are stored on the BOSH persistent volume; and we currently don't have a good way of monitoring this, or automatically purging old data.
ES will stop indexing new data, causing the queue to start backing up.
If the BOSH persistent volume fills up, ES starts logging errors like below, which pretty quickly fill up the BOSH ephemeral volume.  Recover is a manual process of SSHing into the instance and sudo rm -f /var/vcap/sys/log/elasticsearch/elasticsearch.std*:

[2014-05-31 06:26:08,228][WARN ][indices.cluster          ] [Tuc] [logstash-2014.05.20][0] failed to start shard
org.elasticsearch.indices.recovery.RecoveryFailedException: [logstash-2014.05.20][0]:
...snip...
Caused by: java.io.FileNotFoundException: /var/vcap/store/elasticsearch/live-logsearch/nodes/0/indices/logstash-2014.05.20/0/index/recovery.1401517566653._11ge.nvd (No space left on device)

I think we should start with a better disk space usage alerting system; followed by some combination of documentation on how to react and some automated tooling.

Until a better solution comes along we've been using a bot to periodically check our disk stats (as reported by logsearch-shipper) and alert us if they pass generic thresholds.
As far as this issue goes, I'm closing it. It's an operational issue - generic among all deployments, not just elasticsearch/logsearch - and it's not something we can independently solve with this logsearch release. Different sort of project.

Also, we do utilize curator, scheduled externally from the deployment, to keep a fairly consistent amount of data within our typical thresholds.


Replace shared object with Fluid object and use it consistently

This PR contains the following changes:

Use the term "Fluid object" to mean "a DDS or DataObject". That's how the term was used elsewhere in our docs, and regardless of the history, I propose that we accept some retconning and snap to this definition of Fluid object.
Clarified the wording around initial and dynamic objects.
Clarify the relationship of DDSes, DataObjects, and Fluid objects in the DDS article (and link to the DO article).
Update some term definitions.

I actually disagree with this naming change. Fluid Objects should be objects that get handed out, like data stores, or collection instances. i think we discourage the handing out of dds specially. If data stores want to share data, they should expose and API they own that internally uses the dds

We've decided to stick with shared object, and the other changes in this or are superseded #7155.


[Bug]: dayOptions(mini:true) not existed

Contact Details
No response
What happened?
dayOptions: DayOptions(mini:true) does not existed
and compactMode:true does not worked
thanks for the resolve
What type of Device are you seeing the problem on?
IOS

i have resolve my pb. it is ok sorry.
I would like the options viewtoggle.DAILY and it is works fine.


Add GitHub Actions CI

The macOS error seems unrelated to this PR: https://github.com/MarDiehl/stdlib_os/issues/4

@MarDiehl it looks like everything is passing except a linking error on Windows: https://github.com/MarDiehl/stdlib_os/issues/5
Do you have time to look at that? I am done for today with this PR.


Alias must support a name containing embedded spaces

If my smart plugs are called PlugA, PlugB, PlugC  then all is fine.
However, if I name such as "Washing Machine" it does not work with an embedded space

Will be fixed in the next snapshot build 1.0.5-SNAPSHOT available now
And will be in next scheduled release.


mapviz: 1.3.0-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mapviz to 1.3.0-1:

upstream repository: https://github.com/swri-robotics/mapviz.git
release repository: https://github.com/swri-robotics-gbp/mapviz-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.7
previous version for package: 1.2.0-1

mapviz
* Implement (#671 <https://github.com/swri-robotics/mapviz/issues/671>)
* Remove OpenGL warning (#667 <https://github.com/swri-robotics/mapviz/issues/667>)
* Resolves segfault issue on ClearHistory() function call (#651 <https://github.com/swri-robotics/mapviz/issues/651>)
* Fix plug-in config panel to scroll per-pixel instead of per-item, allowing configuration of plug-ins that have config settings that are too large to fit in the panel all at once. (#646 <https://github.com/swri-robotics/mapviz/issues/646>)
* Contributors: Daniel D'Souza, Marc Alban, Matthew, jreyes512

mapviz_plugins
* Fix plan route visibility (#680 <https://github.com/swri-robotics/mapviz/issues/680>)
* Disable coordinate picker and measuring plugin when hidden (#678 <https://github.com/swri-robotics/mapviz/issues/678>)
* Increase odom queue size so messages dont drop (#676 <https://github.com/swri-robotics/mapviz/issues/676>)
* Add float plugin (#665 <https://github.com/swri-robotics/mapviz/issues/665>)
* Make string plugin also support string stamped (#666 <https://github.com/swri-robotics/mapviz/issues/666>)
* Don't draw arrow for invalid orientation (#673 <https://github.com/swri-robotics/mapviz/issues/673>)
* Remove OpenGL warning (#667 <https://github.com/swri-robotics/mapviz/issues/667>)
* Change for loop to while loop in marker plugin so that iterators aren't getting double incremented on erases. (#663 <https://github.com/swri-robotics/mapviz/issues/663>)
* Add ability to show all covariances (#659 <https://github.com/swri-robotics/mapviz/issues/659>)
* Add ability to use relative paths for images in the robot image plugin (#658 <https://github.com/swri-robotics/mapviz/issues/658>)
* Resolves segfault issue on ClearHistory() function call (#651 <https://github.com/swri-robotics/mapviz/issues/651>)
* Default show background and measuring text to true (#657 <https://github.com/swri-robotics/mapviz/issues/657>)
* Contributors: Daniel D'Souza, Matthew, Matthew Grogan, jgassaway, jreyes512, knickels

multires_image
* Remove OpenGL warning (#667 <https://github.com/swri-robotics/mapviz/issues/667>)
* Contributors: Daniel D'Souza

tile_map
* Fix linking to OpenGL GLU library (#675 <https://github.com/swri-robotics/mapviz/issues/675>)
* Remove OpenGL warning (#667 <https://github.com/swri-robotics/mapviz/issues/667>)
* Contributors: Ben Wolsieffer, Daniel D'Souza

Holding for sync.


Client (StreamingDirectxClient.exe)

When I launch the MultithreadServer with the StreamingDirectxClient, the client shows up as a white screen (no visible stream).  But if I try to navigate as if it were rendering, the server shows the output just fine. Tried relaunching multiple times switching launch order of server/client and it still happened.

Issue addressed by changing useSoftwareEncoding in nvEncConfig.json to true. Wider issue documented in #78.


stage --help should list valid stages

Describe the feature
Initial guess at stage name:
reth stage --from 4999000 --to 5000000 Senders
error: Invalid value 'Senders' for '<STAGE>': Matching variant not found

For more information try '--help'

help doesn't say what the valid values are:
Arguments:
  <STAGE>
          The name of the stage to run

The right answer is senders but this requires looking at the code to see that the case changes:
#[serde(rename_all = "snake_case")]
#[strum(serialize_all = "kebab-case")]
enum StageEnum {
    Headers,
    Bodies,
    Senders,
    Execution,
}

On a related note, metrics outputs a different name for the senders stage. It's the only one that differs from what's in the enum:
reth_stage_progress{stage="Bodies"} 5000000
reth_stage_progress{stage="Execution"} 1920000
reth_stage_progress{stage="Headers"} 5000000
reth_stage_progress{stage="SenderRecovery"} 5000000

Additional context
No response

The metrics names are correct, unsure why they were renamed in the CLI.


[Core][Distributed] refactor custom allreduce to support multiple tp groups

Previously custom allreduce is attached to a module, and only bound to the world group.
With this PR, it is bound correctly to the tp group.

[ ] remove import inside function (need to remove default group None option)

@hanzhi713 Could you please also take a look if you have time?

您的邮件已收到，我会尽快回复！

LGTM


[Applications] Support jsonnet files as Meshery Applications

Current Behavior
A Meshery Application can be generated using Meshery's Designer features or can be imported (and further customized) as a Helm Chart, Docker Compose, or Kubernetes Manifest - each of these are importable application types.
Desired Behavior
Ideally, jsonnet files are also supported application import type.
Implementation

Acceptance Tests

Mockups

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I want to work on this issue! Please assign it to me.