ARROW-1047: [Java] Add Generic Reader Interface for Stream Format

This change decouples the reading of messages from the ReadChannel so that it is possible to build a reader that is not tied to a specific stream.  This adds a new interface MessageReader that will return a Message and the message body.  The MessageChannelReader implements this interface to read from a ReadChannel to match the current functionality.  A re-org of reading and writing packages is also done to better organize classes under an ipc package.
There is a slight change in behavior for the ArrowFileReader that should not affect any usage.  Previously,  the schema was read during initialization, and all dictionaries read just before the first record batch was read.  Now, all dictionaries are read directly after the schema, and not specifically tied to reading the first record batch.

I'm proposing some re-organization of the packages for reading/writing to hopefully better group related classes.  Here is what I'm proposing (this also tries to follow some of the arrow-cpp structure):
o.a.a.vector.ipc
      file
          ArrowFileReader
          ArrowFileWriter
          ArrowMagic
      stream
          ArrowStreamReader
          ArrowStreamWriter
      json
          JsonFileReader
          JsonFileWriter
      message
          ArrowBlock
          ArrowFooter
          ArrowMessage
          ArrowRecordBatch
          ArrowDictionaryBatch
          FBSerializable
          FBSerializables
          MessageSerializer
      ArrowReader
      ArrowWriter
      ReadChannel
      WriteChannel

I think this should mostly be orthogonal to the Java vector refactoring that is going on now.  That should take priority, but it would be great if we could get this in for 0.8 if possible.

@wesm @icexelloss @siddharthteotia what are your thoughts on this?

@BryanCutler at a high level this sounds great to me. cc @nongli also to take a look

At the high level, @BryanCutler what do you feel about having  ipc should be a top level package rather than a subpackage under vector, i.e. org.apache.arrow.ipc

I'm not sure, all of the current messages are geared towards vectors so it makes sense to keep it there. Are you thinking of possible messages in the future that might not be vector related?
I think this is fine for now.

Longer term, I kind of think we can improve the current package hierarchy where all API is under the name space org.apache.arrow.vector. A hierarchy similar to C++ might make more sense - o.a.a.vector o.a.a.ipc and etc. But no need to do it here I think.

@BryanCutler This looks great! What do people feel about having less sub namespaces?
Original,
o.a.a.vector.ipc
      file
          ArrowFileReader
          ArrowFileWriter
          ArrowMagic
      stream
          ArrowStreamReader
          ArrowStreamWriter
      json
          JsonFileReader
          JsonFileWriter
      message
          ArrowBlock
          ArrowFooter
          ArrowMessage
          ArrowRecordBatch
          ArrowDictionaryBatch
          FBSerializable
          FBSerializables
          MessageSerializer
      ArrowReader
      ArrowWriter
      ReadChannel
      WriteChannel

How do people feel about:
o.a.a.vector.ipc
      message
          ArrowBlock
          ArrowFooter
          ArrowMessage
          ArrowRecordBatch
          ArrowDictionaryBatch
          FBSerializable
          FBSerializables
          MessageSerializer
      ArrowReader
      ArrowWriter
      ArrowFileReader
      ArrowFileWriter
      ArrowMagic
      ArrowStreamReader
      ArrowStreamWriter
      ReadChannel
      WriteChannel
      JsonFileReader
      JsonFileWriter

Also maybe JsonFileReader -> ArrowJsonReader for more consistent naming?

Backward compatibility wise, I think we should probably change this along with vector changes in one arrow release?

Thanks @elahrvivaz, @icexelloss and @wesm !

What do people feel about having less sub namespaces?

I sort of prefer having separate packages for the different readers/writers.  There are some supporting files that are specific to certain formats, like ArrowMagic and InvalidArrowFileException, and I like pushing it down to the feature that uses them.  I think users will be more likely to import reader/writer from 1 format for a particular use too.  I'm not tied to this though, we can simplify if that's the consensus.

Also maybe JsonFileReader -> ArrowJsonReader for more consistent naming?

+1 for me on renaming this

imo i like the current package layout with file, stream, json, message.

I sort of prefer having separate packages for the different readers/writers. There are some supporting files that are specific to certain formats, like ArrowMagic and InvalidArrowFileException, and I like pushing it down to the feature that uses them. I think users will be more likely to import reader/writer from 1 format for a particular use too. I'm not tied to this though, we can simplify if that's the consensus.

imo i like the current package layout with file, stream, json, message.

Sounds good to me.

One thing I am not sure is if this patch will make java-refactor-branch hard to merge - cc @siddharthteotia for comment.
Maybe we should keep all refactor changes in java-refactor-branch to make it easier to merge? Not sure though.

Yes I am concerned that this will make patches in java-vector-refactor branch hard to merge into master, Secondly, the nature of changes suggest that we should be testing this with Dremio as well -- I would have loved to offer help but I am in the process of moving Dremio to new code in java-vector-refactor branch.
I would prefer to have these changes merged after java-vector-refactor changes are merged into master.

@siddharthteotia the Java refactoring is the priority right now so I don't want to hinder that, but I would like to get this in for the 0.8 release if possible.  I think changes to the ArrowReader should be mostly transparent, although there might be conflicts with some of the tests I had to change. What about if I try to cherry pick this into the java-vector-refactor branch?  If it doesn't go in cleanly then we can put it on hold until the refactor branch is merge.

@BryanCutler, are you suggesting to cherry pick your changes in refactor branch and revert commit in case things don't look good?
I am not entirely sure what's the best option here but I believe that adding orthogonal set of changes to java-vector-refactor branch at this point may not be a good idea. However, I don't want to block other work. So feel free to proceed based on your best judgement.
Note that there are currently two patches in that branch. While making changes in Dremio and debugging test failures, I had to go back and make some changes in vector code (minor only, no redesign). Currently those additional changes are in Dremio's fork (as I wanted to make quick progress) and I will put a PR against java-vector-refactor branch for the third patch very soon -- better to do at last when testing with Dremio completes.

@siddharthteotia that's fair enough, I don't want to complicate the refactoring.  I mostly just want to make sure that these changes don't make things harder to merge the java-vector-refactor branch into master.  I can try that out locally and report back.

@siddharthteotia is this something you would like to run with the Dremio suite of tests before merging?

@BryanCutler , I would like to test this with Dremio but I am not sure how quickly I will be able to do that and revert back after making necessary changes in Dremio and doing proper testing.
Part of me says you should go ahead and merge this since you were already waiting for the refactor work to get done before this.
Since we will anyway have to rebase on Arrow master after the ongoing timestamp vector related changes in https://github.com/apache/arrow/pull/1330, we can take care of testing this out with Dremio at that time unless @jacques-n thinks otherwise?

@siddharthteotia what ever is easier for this, but I would like to hear that I didn't break anything on your side :)  It's pretty easy to rebase this, so no need to rush

This looks good to me. Once the package name hierarchy I think this should be good to go.

LGTM. +1

Squashed and rebased so we can get a passing build. While we are waiting, do we also want the vector.ipc.message subnamespace? Do not have a strong feeling

I do not have a strong feeling either, I think vector.ipc.message subnamespace are fine. Although maybe we can move ArrowMagic to message subnamespace? @BryanCutler what do you think

Reviewing the past comments, since these classes are generally internal, I think it's fine. master is broken right now (ARROW-1845) so I will merge this

I'd like to keep the vector.ipc.message package, I think these generally define messages that serialize to FB.

Thanks @wesm @icexelloss @elahrvivaz and @siddharthteotia !


Fix airbrake secure setting

Sets Airbrake's secure configuration.

What was wrong?

https://github.com/alphagov/multipage-frontend/commit/42e6ed2159e5a4f19b5d7d4211328ef287299ef5 errbit_uri was undefined. I was mid-deploy when I realised this, hence the brevity of the change description.

Aha, thank you :+1:


Pausing to reconnect websocket

As I leave my system idle/hibernate. Following error comes in the console.
core.es5.js:1020 ERROR INVALID_STATE_ERR : Pausing to reconnect websocket.
After the error, I never get any update from the socket until I refresh the tab.

Ever solved this issue?


[Source] Remove option "Inclure ce champ dans les tuiles vectorielles"

Is this option still relevant given that we include all the data ?

We need to remove this option


SP4: RadarPlot and CoxcombPlot don't scale correctly

Bug Report
Issue: A copy-pasted typo means that the rendering of RadarPlot and CoxcombPlot ignores the vertical space available, scaling only to the width.
Reproducing: Run the Cookbook demo (I used WPF), view a radar chart, and resize the height of window without varying the width. The size of the rendered plot won't change, and if the window becomes too short it will be clipped.
System Details

ScottPlot Version: master branch
Operating System: Windows 10
Application Type: WPF but the bug is engine-independent
.NET Version: Framework 4.8 but the bug is independent of this

Patch
I was going to make a pull request with the following patch:
diff --git a/src/ScottPlot4/ScottPlot/Plottable/CoxcombPlot.cs b/src/ScottPlot4/ScottPlot/Plottable/CoxcombPlot.cs
index ecd8403b..a381a9a5 100644
--- a/src/ScottPlot4/ScottPlot/Plottable/CoxcombPlot.cs
+++ b/src/ScottPlot4/ScottPlot/Plottable/CoxcombPlot.cs
@@ -96,7 +96,7 @@ namespace ScottPlot.Plottable
             int numCategories = Normalized.Length;
             PointF origin = new PointF(dims.GetPixelX(0), dims.GetPixelY(0));
             double sweepAngle = 360f / numCategories;
-            double maxRadiusPixels = new double[] { dims.PxPerUnitX, dims.PxPerUnitX }.Min();
+            double maxRadiusPixels = new double[] { dims.PxPerUnitX, dims.PxPerUnitY }.Min();
             double maxDiameterPixels = maxRadiusPixels * 2;

diff --git a/src/ScottPlot4/ScottPlot/Plottable/RadarPlot.cs b/src/ScottPlot4/ScottPlot/Plottable/RadarPlot.cs
index 94a1187e..17b071ae 100644
--- a/src/ScottPlot4/ScottPlot/Plottable/RadarPlot.cs
+++ b/src/ScottPlot4/ScottPlot/Plottable/RadarPlot.cs
@@ -261,7 +261,7 @@ namespace ScottPlot.Plottable
             int numGroups = Norm.GetUpperBound(0) + 1;
             int numCategories = Norm.GetUpperBound(1) + 1;
             double sweepAngle = 2 * Math.PI / numCategories;
-            double minScale = new double[] { dims.PxPerUnitX, dims.PxPerUnitX }.Min();
+            double minScale = new double[] { dims.PxPerUnitX, dims.PxPerUnitY }.Min();
             PointF origin = new PointF(dims.GetPixelX(0), dims.GetPixelY(0));

             using (Graphics gfx = GDI.Graphics(bmp, dims, lowQuality))
diff --git a/src/ScottPlot4/ScottPlot/StarAxis.cs b/src/ScottPlot4/ScottPlot/StarAxis.cs
index 07d2ccd3..ea3a5faa 100644
--- a/src/ScottPlot4/ScottPlot/StarAxis.cs
+++ b/src/ScottPlot4/ScottPlot/StarAxis.cs
@@ -98,7 +98,7 @@ namespace ScottPlot
         public void Render(PlotDimensions dims, Bitmap bmp, bool lowQuality = false)
         {
             double sweepAngle = 2 * Math.PI / NumberOfSpokes;
-            double minScale = new double[] { dims.PxPerUnitX, dims.PxPerUnitX }.Min();
+            double minScale = new double[] { dims.PxPerUnitX, dims.PxPerUnitY }.Min();
             PointF origin = new(dims.GetPixelX(0), dims.GetPixelY(0));

             RenderRings(origin, minScale, sweepAngle);

However, when I tested it I discovered that the plots seem rather small. I suspect that further changes are needed to RadarPlot.GetAxisLimits() and CoxcombPlot.GetAxisLimits(), but I'm not sure what the current hard-coded values are based on.

And possibly the GetAxisLimits() heuristics should look at CategoryLabels rather than GroupLabels, because the group labels are rendered in the legend - unless the purpose is to leave a margin for the legend?

Hi @pjt33, thanks for reporting this! I'll look into it further shortly.
The lines of code that need to change are here:
https://github.com/ScottPlot/ScottPlot/blob/b7f566d5d2087fa1e5f7b61a45cb021250f32f57/src/ScottPlot4/ScottPlot/Plottable/CoxcombPlot.cs#L99
https://github.com/ScottPlot/ScottPlot/blob/b7f566d5d2087fa1e5f7b61a45cb021250f32f57/src/ScottPlot4/ScottPlot/Plottable/RadarPlot.cs#L264
https://github.com/ScottPlot/ScottPlot/blob/b7f566d5d2087fa1e5f7b61a45cb021250f32f57/src/ScottPlot4/ScottPlot/StarAxis.cs#L101


Fix definition GO:0030387  fructosamine-3-kinase activity

Reported by @sylvainpoux
Definition is "Catalysis of the phosphorylation of fructosamine to form fructosamine-3-kinase."
Should be "Catalysis of the phosphorylation of fructosamine to form fructosamine-3-phosphate."

Term should probably be merged with

@sylvainpoux waiting for your feedback to decide on the merge.
Thanks, Pascale

Hi @sylvainpoux
Where do we stand with this ?

Sorry Pascale,
I forgot this issue. I would not merge these 2 terms because it looks like that the enzyme also acts on non-protein substrates

So close?


Link FxA login to currently signed in user (fixes #982)

There's no UI to trigger this but I tried it by flipping the waffle back and forth locally.
I added some more coverage to the individual functions. There could probably be some refactoring to mock some more in the other tests now but I kind of liked how integrated they were.

@kumar303 r?

The tests look good.
r+wc


Pass options through to AST plugins.

This allows AST plugins to have more information about the thing being compiled. The intent is for this to be a way to provide compile time template deprecations and still be able to indicate the module path for the template being compiled.
The general idea is that ember-cli-htmlbars will call precompile something like:
var compiler = require('./bower_components/ember/ember-template-compiler');

var template = compiler.precompile(input, {
  moduleName: 'some-app/path/to-template/stuff'
});

And then Ember can have an AST preprocessor that deprecates things (like {{bind-attr}}) at compile time, but still provides the template path being compiled. Without the module name tracking down deprecations on compile is extremely difficult.

Pulled into v0.11.3.

Nice


Upgrade Pillow to latest version.

Coverage remained the same at 92.945% when pulling 508934a1921cf7cabb32d16859d753865aa66407 on johngian:upgrade-pillow into 762601344d8f76503d38c94bc4465fa0eeabed9a on mozilla:master.

@akatsoulas r?


Disable pylint's 'ungrouped-imports' error.

We share the google namespace with third-party packages.  PEP 8 wants "local" imports to be separated fro "third-party" imports, which is more important than pylint's attempt to group them by name alone.

@tseaver looks like it needs to be rebased.
I'm cool with this change, but I defer to @dhermes.

I haven't though much about it but I'd like to talk to the PyCQA folks before it falls off our radar.

@daspecster Glad to see you up and around!  Are you working off post-op recovery boredom?

@dhermes I don't see that we have anything to talk with PyCQA about:  our case doesn't fit their default policy, so we change it.

@tseaver I am not disputing this change, I just don't want the discussion to go off my radar before I have bandwidth to have that discussion with those folks.

@dhermes Opened #2466 to track that issue.

@dhermes Given that #2466 is open (and assigned to you :), any reason not to merge here?

For sure. I figured you'd merge it right after creating #2466


Check if RBE still passes

Was this just a minor diff to trigger a build?

Indeed. RBE (remote execution) build failed in the kwargs suite PR which
sounded strange so I wanted to make sure master build works properly
(thought maybe CI configuration changed behind the scenes).
I’ll keep it open for the author of the PR to be able to compare the runs
On Tue, 23 Oct 2018 at 8:15 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

Was this just a minor diff to trigger a build?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/634#issuecomment-432095222,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF9xID9CjQ2aA_DlOeWhaqKaqmeSxks5unqXagaJpZM4X0tI9
.

@ittaiz Thanks for providing this PR for comparison. Unfortunately, I cannot see the build logs on buildkite. (As I understand, that's where the RBE tests are happening.)
It says "You must log in to see this page"


Moonbirds Example Test Failing

Trying to run the tests and study the code a little got the following issue.

Steps to reproduce:

Follow the Readme.md instructions
Follow the /examples/moonbirds/readme.md instructions
run forge test

Doing some debugging, found that the issue is on the examples/moonbirds/test/TestLib.sol file.  The mktemp function is returning an empty string.

Hello, no worries, currently using MacOS 13.0 Ventura with an Apple M1 Pro.


create subdirs on copy files to play_local_path

to fix issue on copy from play_temp_path to play_local_path for URL with subdirs

replaced with https://github.com/arut/nginx-rtmp-module/pull/656


Feat/720 clean autocomplete

@pournasserian tom-select has many features and examples, please check and let me know which examples do we need.

@pournasserian ready to review


Swap mj library

Uses mathjax-node-sre instead of mathjax-node.
This will get the speech to work (which we claim should work by default anyway).

I understand why we want to test mathjax-node for a number of versions.
But these are effectively just a few shell scripts, so I don't really see the need for testing all old version.
It's more important to see if yargs works in the latest.
But if you want, I can add those versions again.

I'm OK without it.  I will merge.

Thanks.
Btw., I just recalled that I did the changes for the new yargs the other day for mathjax-node-sre. It should be very quick to do it for cli as well.


Make the tab be at current index when there are different controllers in different groups

Added a conditional to check if there is a controller in use so that it can change to the current index of the Tabs.
Before:
https://user-images.githubusercontent.com/65375294/182242698-6cd632b8-a838-4c0b-9ed2-e444a28837bf.mov
Now:
https://user-images.githubusercontent.com/65375294/182242925-fef54cdd-8b99-420d-ac47-071e44fbe8e4.mov
Fixes #96718
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In the "after" video it actually looks like there is a strange bounce effect when scrolling all the way to the right. Is that expected?

In the "after" video it actually looks like there is a strange bounce effect when scrolling all the way to the right. Is that expected?

It is.

It is.

I meant the bounce after the autoscroll. Not the one we see when it is actually dragged with the mouse.

This is another video, it seems like the physics behave differently in group 1 and in group 2.
https://user-images.githubusercontent.com/65375294/182907406-000770bf-18c5-42c5-8a8d-919bac611e18.mov

Ohh Hi! I think I am a bit occupied with Uni right now so if any other contributor could help would be better!


Finished project setup - added OCaml project for surf interpreter

Overview
Finished project setup by configuring OCaml project for the surf interpreter and writing sample testbeds. Also created CI process for building/testing OCaml project.

 Setup OCaml project/opam


English Translation for this utility?

Any plans for English translation for this utility?

I'm sorry, the content in the database used by the program is in Chinese. It's unable to use simple mapping to solve translation problems, someone has to spend time to maintain the English version database.

I wonder if there is any ip geographical location database in English. How about adding an option to use it?


Configure worker account: Time registration tab not in instructions

"Activate on registration terminals" and all other fields under the Time registration FastTab have been moved to the new Time registration tab. It's no longer situated under the Employment tab as stated in the text.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c9cb448-e8e6-e8e8-401f-7dc1f456df49
Version Independent ID: 388e1156-e266-cb51-faaa-19030f10c85b
Content: Configure a worker using the mobile job device - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/production-control/tasks/worker-mobile-job-device.md
Service: dynamics-ax-applications
GitHub Login: @ShylaThompson
Microsoft Alias: shylaw

@pvruyske, thanks for the feedback.
@josaw1, please review and decide if action needs to be taken to update this topic.

Bug 340060 has been logged to track this issue.

This is fixed.


Add Light Theme

Well, just that ;-)

Inverting this, as now Observatory Core only has a dark theme.

Will be done at long last once #127 is merged and released.


[Update Request]: Mozilla Firefox 122.0.1

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Mozilla.Firefox
Package Version
122.0.1
Please describe the changes you would like to see
No response

Loading.....

@stephengillie can you close this issue ?

Close with reason: 122.0.1 has been added to the repo;


Structured i/o - proof of concept

This is a prototype draft for Structured I/O in circuits.
This draft cuts all dependency from the rest of the project in order to:

minimize merge pains
think through fundamentals
facilitate new designs for

optimization
clean abstraction

We've recently added a new type of constraints called range constraints to the Circuit type. An input or output variable can be constrained to an interval of the form [0, a]. I think it would make sense to consider it in this draft.
Additionally, we will have constraints of the form (x_1, ..., x_k) \in T sometime soon. Just a heads up.

I think we salvaged the ideas from this proposal in #154, #214 and in #217, so we can close this. @echatav, what do you think?

I just want to keep it open as a reference, not to merge. There are still lots of things here as proof of concepts that are relevant to proposals that I want to merge back in their own PRs. I will add a label if it helps.


Modify the method about get file MD5

modify the method

 You should sign our Contributor License Agreement in order to get your pull request merged.


selfOnly should be preserved for logged-in users

The current error message is not informative when an user is not logged in and selfOnly is specified.

This PR gives clear error message for such situation.

Coverage increased (+0.05%) to 86.517% when pulling a4e3eb9351ce671effe24b1bf62459719a3dd994 on listreply-selfonly into 45a0db8fecf537928046934e52309c041ec2cb78 on master.


Can't sign up with github

Can't sign up/sign in with github: the "Authorize appliction" button is disabled.
I tried to wait for a long time, but nothing changed.
And this internal browser doesn't let me to do anything: copy url of this page to authorize app in chrome/safari, check console for any errors or even copy/paste text.
Damn internal browser :'(
Thank you. Waiting for response.

I also cannot login using github. the authorize application is disabled.
kindly assist.

I opened Devtools and manually removed the disabled attribute from the button.  I was then able to successfully login with my Github account.

It says that it doesn't support the version of Chrome/Firefox I have even though I have the latest and greatest.


Fixed args key for image being passed to link_image_if helper method

https://bugzilla.redhat.com/show_bug.cgi?id=1201720
before fix:

after fix:

@mkanoor can you please test.
@dclarizio please review/test.

@h-kataria
Checked the UI for up/down arrows looks good.


No Data fail without error notification

If there is a line with no data, nothing happend, and no error is raised.
test with :

NOM;NUM;RUE;CODE POSTAL;VILLE
;;;;

if there is a something in a column, it's working, unless you don't select this column:

NOM;NUM;RUE;CODE POSTAL;VILLE
XXX;;;;

select all columns : it work
don't select column NOM: it didn't work

Thanks for the report, it should be fixed now :)


Textmining returning an error on Workflow C query

0fd681f9-4b08-43d4-b7a3-cf6e561d49af

This query is a multi-hop query I believe, so the Text Mining Provider is not expected to return results. @newgene does the Service Provider TRAPI return an Error when a multi-hop query is submitted? Is this the expected output?

{
  "callback": "http://<IP_ADDRESS>:8000/ars/api/messages/5f08061c-e4b3-4d98-ad04-8d6244a1ae6c",
  "max_results": 100,
  "message": {
    "query_graph": {
      "edges": {
        "e01": {
          "object": "n1",
          "predicates": [
            "biolink:related_to"
          ],
          "subject": "n0"
        },
        "e02": {
          "object": "n2",
          "predicates": [
            "biolink:related_to"
          ],
          "subject": "n0"
        },
        "e03": {
          "object": "n3",
          "predicates": [
            "biolink:related_to"
          ],
          "subject": "n0"
        }
      },
      "nodes": {
        "n0": {
          "categories": [
            "biolink:Gene"
          ]
        },
        "n1": {
          "categories": [
            "biolink:ChemicalSubstance"
          ],
          "ids": [
            "CHEBI:45783"
          ]
        },
        "n2": {
          "categories": [
            "biolink:Disease"
          ],
          "ids": [
            "MONDO:0005301"
          ]
        },
        "n3": {
          "categories": [
            "biolink:ChemicalSubstance"
          ]
        }
      }
    }
  },
  "validation_result": {
    "message": "",
    "size": "2 kB",
    "status": "PASS",
    "version": "1.1.1"
  }
}

Out of scope - will not fix.


Cleanup Java import ordering to match new style [phab:D972]

Created by schroederc at 2016-07-19 18:17:57:

shahms accepted this revision at 2016-07-19 18:19:34

schroederc wrote at 2016-07-19 18:20:31:
Remove unused imports

schroederc closed via commit 9c641e850f3136e65d3fc44716c8987dd8c9c1a3 at 2016-07-19 18:22:08


Copy udunits2.lib too

Re-rendered and removed some the yum install step from build.sh.

Hi! This is the friendly conda-forge-admin automated user.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

When I add features I get a conflicts. Not sure how to fix that.
BUILD END: udunits2-2.2.20-vc9_1
TEST START: udunits2-2.2.20-vc9_1
Fetching package metadata: ........
Solving package specifications: ....
Error: The following specifications were found to be in conflict:
  - udunits2 2.2.20 vc9_1
Use "conda info <package>" to see the dependencies for each package.

@msarahan can you stop any obvious mistakes I am making here?

Since expat is the only other dependency here, that's probably the problem.  Either expat or one of its dependencies are not available with the vc9 feature.  Are you using the conda-forge recipe?  I assume so, I get no results from conda search expat.  This recipe has no vc features: https://github.com/conda-forge/expat-feedstock/blob/master/recipe/meta.yaml

Got it. I need to get all the dependencies to use vc first.

  This stuff is a mess.  I wish the error messages were more clear.  I think they might be with conda 4.0.

 This stuff is a mess. I wish the error messages were more clear. I think they might be with conda 4.0.

Now that I recall I had the same issue with expat :wink: (before i tried the new version here). Expat depends on msinttypes and I guess I should add features to msinttypes too. However, it seems an overkill to use feature to a package that just drops some header files in the path.

I totally agree.  I'll ask @mcg1969 whether there are any good approaches we can take to break the feature requirement where it makes sense (like with header-only libraries).

I totally agree. I'll ask @mcg1969 whether there are any good approaches
we can take to break the feature requirement where it makes sense (like
with header-only libraries).

Bare in mind that msinttypes is a rare case. Maybe it is not worth fixing
that. (I also believe that we no longer need msinttypes with the latest
Visual Studio.)

Header-only libraries are not terribly common, but they're also not rare.  I think we do need to know how to handle features where packages without features are dependencies.

Adding
test:
    requires:
        - python {{ environ['PY_VER'] + '*' }}  # [win]

solved https://github.com/conda-forge/udunits2-feedstock/pull/4#issuecomment-207576609.


Publish helm charts

The Helm charts should be published to ECR Public along with the container images. A new set of repositories should be created, one for each component. For example the UI chart should be published to:
https://gallery.ecr.aws/aws-containers/retail-store-sample-ui-chart
The current repositories could be used but that would result in odd version tags like 0.8.0-chart

@niallthomson - I'll work on this.


firstName is protected. Use getFirstName method.

Thank you for the good work on oauth2 provider.
Just a small documentation fix.

:+1:


imap disconnected every few hours

Is there a way to prolong the life of the mail listener connection without having to refresh the code every few hours? I notice that the mail listener disconnects after a while of no traffic.
Thanks

@prashb94  same things. Did you get issue fixed?

Hey,
I just start the connection again if the server disconnects. A temporary fix for now.
On Jul 18, 2016 06:42, dpcolaberry<EMAIL_ADDRESS>wrote:
@prashb94https://github.com/prashb94 same things. Did you get issue fixed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/chirag04/mail-listener2/issues/54#issuecomment-233208549, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKUq3C1j3RdgHnblPCkTF-HI-2LReh6Zks5qWq_NgaJpZM4JBEHR.

+1

+1

+1

+1

Any news?

@prashb94 as simple as this?
mailListener.on('server:disconnected', () => {   console.log('imapDisconnected');   mailListener.stop();   mailListener.start(); });

I've also noticed that sometimes due to the Idle event firing it can miss emails that have not previously been read. Weirdly if you restart the client it STILL ignores those received emails. You have to mark them as seen and then back to unread for them to parse.

@Hardware-Hacks your solution did not work for me!  I've tried two ways:
1
        function startListener() {
		if (mailListener) {
			mailListener.stop();
		}
		mailListener = new MailListener(mailListenerOpts);
		mailListener.start();
	}

	startListener();

	mailListener.on('server:connected', () => {
		console.info('IMAP connected');
	});

	mailListener.on('server:disconnected', () => {
		startListener();
	});

	mailListener.on('error', errorHandler);
	mailListener.on('mail', mailHandler);
```

2
```
        mailListener = new MailListener(mailListenerOpts)
	mailListener.start();

	function restartListener() {
		mailListener.stop();
		mailListener.start();
	}

	mailListener.on('server:connected', () => {
		console.info('IMAP connected');
	});

	mailListener.on('server:disconnected', () => {
		restartListener();
	});

	mailListener.on('error', errorHandler);
	mailListener.on('mail', mailHandler);
```

And none of them works! What I do no I use forever CLI to make ensure that app always run, and then:
```
	mailListener.on('server:disconnected', () => {
		console.warn('IMAP disconnected');
		throw new Error('Restart app due to IMAP disconnection');
	});
```

What I do now (although does not sound good) I use forever CLI to make ensure that app always run, and then:
	mailListener.on('server:disconnected', () => {
		console.warn('IMAP disconnected');
		throw new Error('Restart app due to IMAP disconnection');
	});

@amirhouieh fully agree there is something fundamentally wrong here and I can't fathom it. I even produced mail-listener-fixed which incorporated the best bits from all the forks in this area. I think there are at least 2 things going wrong, 1 of which is even hitting a timeout, if you use oauth you won't hit the same issue. 2 the IDLE command doesnt seem to receive responses after a while, or it is breaking down on the client side causing the server to disconnect the connection.
I've actually ditched all of this now. For GMail specifically I switched over to context.io and use their npm library to retrieve emails via live sync. It works really good and offers the same functionality.

add on node-modules/mail-listener2/index.js
this:
MailListener.prototype.start = function() {
this.imap.on('ready', imapReady.bind(this));
this.imap.on('close', imapClose.bind(this));
this.imap.connect();
};
MailListener.prototype.restart = function() {
console.log('detaching existing listener');
this.imap.removeAllListeners('mail');
this.imap.removeAllListeners('update');
console.log('calling imap connect');
this.imap.connect();
};
and then use it


Web.Contents failed to get contents from 'https://api.tiingo.com/tiingo/daily/FB' (404): Not Found

[Enter feedback here]
How can I edit this App so I can fix what appears to broken ticker - I believe FB changed to META recently and this has been broken for a few days now:
Web.Contents failed to get contents from 'https://api.tiingo.com/tiingo/daily/FB' (404): Not Found.

Thanks for your comment, @RodrigoRibeiro1995. This issue has been assigned to the doc author for review.


Fix typo in airflow dogstatsd mapping

What does this PR do?
Fix typo of duplicate metric
Motivation
I updated my mapping by copying from the airflow integration page, and noticed this metric disappeared
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Thanks for the contribution! 🙇


[AutoPR-confidentialledger]autogenerated

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Identity

/azp run prepare-pipelines

/azp run js - confidentialledger - ci


don't special case gcd for div and mul

Tested using calc.html#tab=settings&data=bobs-0-16-37&items=space-science-pack:f:100
Google Chrome Version 69.0.3497.100 (Official Build) (64-bit)
Before: solver.solve takes roughly 2000 ms
After: solver.solve takes roughly 1380 ms

These are the only places where the 'gcd' parameter was used. You should now be able to eliminate it, while you're at it.

Done, good feedback!


addPushManifest treats app dependencies as siblings

Shop#master (Polymer 2.0) uses the es6-unbundled preset which uses the addPushManifest build configuration. Today, running polymer build generates a push-manifest.json that references dependencies as siblings:
{
  "src/shop-app.html": {
    "../polymer/polymer-element.html": {
      "type": "document",
      "weight": 1
    },

Expected
Previously, they are correctly referenced as files within bower_components:
{
  "src/shop-app.html": {
    "bower_components/polymer/polymer-element.html": {
      "type": "document",
      "weight": 1
    },

This regressed sometime during the run-up to the Polymer 3.0 release.

yarn global add<EMAIL_ADDRESS>works correctly.

This should be fixed in polymer-cli 1.7.4 released yesterday.

Nice! Thanks @aomarks!

Hi @d4l3k :)


Rule-based Sorting

Is your feature request related to a problem? Please describe.
Managing a growing list of repositories in different directories becomes a chore over time. It's easy to forget where each repository needs to be located, or just a hassle to do it even if they can be remembered.
Describe the solution you'd like
I'd like to implement a rules-based sorting system that automatically determines the clone path for repositories based on specified criteria in a config file. This system would look at aspects like the organisation name or programming language to sort the repository into the right directory structure.
Describe alternatives you've considered

Idiomatic: Manually navigate to the correct directory and clone there.
A Script: I've been using a script "goclone" that clones a repo into my GOPATH, or "tmpclone" that clones into a '/tmp/' directory. These scripts work, but I'd like to make them more robust—hence making 'rb'.
One Large Directory: Just use one directory that's easy to remember. Clone everything in there.
Clone Where You Stand: Embrace chaos and clone all repositories into your current directory no matter where you are.

Additional context
Incorporating rules-based sorting will not only improve organisation and productivity, but will also align the tool with language-specific best practices. For example, automatically placing all Go repositories into the designated GOPATH src directory would be compatible with how Go organises local modules.

This has been implemented in https://github.com/matthewchivers/rb/pull/9


Implement support for urls with basic auth

Simplify regexp by removing everything before the first '/' after the protocol has been removed

This change is needed so that wayfarer and sheet-router can support urls with basic auth credentials

Good one, sorry for taking so long to merge

v1.2.0


[SPARK-33674] [TEST] Show Slowpoke notifications in SBT tests

What changes were proposed in this pull request?
This PR is to show Slowpoke notifications in the log when running tests using SBT.
For example, the test case "zero sized blocks" in ExternalShuffleServiceSuite enters the infinite loop. After this change, the log file will have a notification message every 5 minute when the test case running longer than two minutes. Below is an example message.
[info] ExternalShuffleServiceSuite:
[info] - groupByKey without compression (101 milliseconds)
[info] - shuffle non-zero block size (3 seconds, 186 milliseconds)
[info] - shuffle serializer (3 seconds, 189 milliseconds)
[info] *** Test still running after 2 minute, 1 seconds: suite name: ExternalShuffleServiceSuite, test name: zero sized blocks.
[info] *** Test still running after 7 minute, 1 seconds: suite name: ExternalShuffleServiceSuite, test name: zero sized blocks.
[info] *** Test still running after 12 minutes, 1 seconds: suite name: ExternalShuffleServiceSuite, test name: zero sized blocks.
[info] *** Test still running after 17 minutes, 1 seconds: suite name: ExternalShuffleServiceSuite, test name: zero sized blocks.

Why are the changes needed?
When the tests/code has bug and enters the infinite loop, it is hard to tell which test cases hit some issues from the log, especially when we are running the tests in parallel. It would be nice to show the Slowpoke notifications.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual testing in my local dev environment.

Test build #132280 has started for PR 30621 at commit f8b7b78.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36881/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36881/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36881/

Test build #132280 has finished for PR 30621 at commit f8b7b78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132280/

Merged to master.


pull request for e2e test at 12/04/2016 22:45:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ZEPPELIN-3207. fix search content not appearing

What is this PR for?
For some reason search content is not appearing.
This PR fixes this issue.
What type of PR is it?
Bug Fix
Todos

What is the Jira issue?
ZEPPELIN-3207
How should this be tested?
try searching with some sentence like 'bank' (it should be included in tutorial notebook)
see search contents is appearing or not
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I'm not a web guy, and not sure why
_editor.getSession().setValue(lines.join('\n'))
this part is broken.
At least I know now it's working with my changes, any comments or help would be appreciated

Tested and fix works well. But it's getting build failure with following error.
[INFO]
[INFO] /zeppelin/zeppelin-web/src/app/search/result-list.controller.js
[INFO]   151:32  error  Extra semicolon  semi
[INFO]

Could you try remove semicolon?

@Leemoonsoo now it's good to go!

LGTM! Merge to master and branch-0.8 if no further discussions.


Allow get_index to receive DDoc as a doc record

The function couch_mrview:compact/3 is passing to get_index
a prepared #doc record, when get_index is expecting DDoc
to be a ddoc's id. As a result view's compaction is crashing
after fabric:open_doc call.
This patch allows get_index to receive #doc record directly.
This closes COUCHDB-2729

+1

+1


add_changelog_entry misplaces extra newlines

Empty lines in %changelog entries are moved to the end of the entry. See this reproducer
from specfile import Specfile
specfile=Specfile('linux-system-roles.spec')
specfile.add_changelog_entry('bump')
specfile.save()

Result:
diff --git a/linux-system-roles.spec b/linux-system-roles.spec
index fbe915a..2cb20e1 100644
--- a/linux-system-roles.spec
+++ b/linux-system-roles.spec
@@ -757,6 +757,9 @@ find %{buildroot}%{ansible_roles_dir} -mindepth 1 -maxdepth 1 | \
 %endif

 %changelog
+* Mon Nov 21 2022 Pavel Cahyna <...> - 1.22.0-4
+bump
+
 * Tue Nov 08 2022 Sergei Petrosian <...> - 1.22.0-4
 - Fix issue with package update introduce with changing symlink to directory
   Resolves:rhbz#2141152
@@ -897,42 +900,42 @@ find %{buildroot}%{ansible_roles_dir} -mindepth 1 -maxdepth 1 | \
 - storage - fix coverity scan issue in blivet.py
   Resolves: rhbz#2066876 (8.7.0)
   Resolves: rhbz#2072745 (9.1.0)
-
 - logging - fix gather_facts/set_vars issue
   Resolves: rhbz#2079008 (8.7.0)
   Resolves: rhbz#2078989 (9.1.0)
-
 - ha_cluster - Move tasks that set up CI environment to roles tasks/ dir
   Resolves: rhbz#2093500 (8.7.0)
   Resolves: rhbz#2093438 (9.1.0)
-
 - sshd - fix tests issue with rhel9 hosts

+
+
+
 * Mon Jun 06 2022 Rich Megginson <...> - 1.20.0-1
 - storage - support for creating and managing LVM thin pools/LVs
   Resolves: rhbz#2066876 (8.7.0)
   Resolves: rhbz#2072745 (9.1.0)
-
 - firewall - Update Ansible syntax in Firewall system role README.md file examples
   Resolves: rhbz#2081839 (8.7.0)
   Resolves: rhbz#2094096 (9.1.0)
-
 - storage role raid_level "striped" is not supported
   Resolves: rhbz#2083426 (8.7.0)
   Resolves: rhbz#2083410 (9.1.0)
-
 - network: the controller device is not completely cleaned up in the bond tests.
   Resolves: rhbz#2089868 (8.7.0)
   Resolves: rhbz#2089872 (9.1.0)
-
 - firewall - state no longer required for masquerade and ICMP block inversion
   Resolves: rhbz#2093437 (8.7.0)
   Resolves: rhbz#2093423 (9.1.0)
-
 - ha_cluster - Move tasks that set up CI environment to roles tasks/ dir
   Resolves: rhbz#2093500 (8.7.0)
   Resolves: rhbz#2093438 (9.1.0)

+
+
+
+
+
 * Wed Jun 01 2022 Sergei Petrosian <...> - 1.19.0-2
 - Update ansible.posix, community.general

@@ -950,113 +953,113 @@ find %{buildroot}%{ansible_roles_dir} -mindepth 1 -maxdepth 1 | \
 - sshd - sshd system role should not assume that RHEL 9 /etc/ssh/sshd_config has "Include > /etc/ssh/sshd_config.d/*.conf"
   Resolves: rhbz#2086934 (8.7.0)
   Resolves: rhbz#2052081 (9.1.0)
-
 - sshd - sshd system role should be able to optionally manage /etc/ssh/sshd_config on RHEL 9
   Resolves: rhbz#2086935 (8.7.0)
   Resolves: rhbz#2052086 (9.1.0)
-
 - storage - storage role cannot set mount_options for volumes
   Resolves: rhbz#2083378 (8.7.0)
   Resolves: rhbz#2083376 (9.1.0)

+
+
 * Mon May 02 2022 Rich Megginson <...> - 1.18.0-1
 - metrics - [RFE] add an option to the metrics role to enable postfix metric collection
   Resolves: rhbz#2043009 (8.7.0)
   Resolves: rhbz#2043010 (9.1.0)
-
 - firewall - [Improvement] Allow System Role to reset to default Firewalld Settings
   Resolves: rhbz#2043009 (8.7.0)
   Resolves: rhbz#2061511 (9.1.0)

+
 * Mon Apr 25 2022 Rich Megginson <...> - 1.17.0-1
 - All roles should support running with gather_facts: false
   Resolves: rhbz#2079008 (8.7.0)
   Resolves: rhbz#2078989 (9.1.0)
-
 - firewall - Firewall system role Ansible deprecation warning related to "include"
   Resolves: rhbz#2078650 (8.7.0)
   Resolves: rhbz#2061511 (9.1.0)
-
 - ha_cluster - ha_cluster - support advanced corosync configuration
   Resolves: rhbz#2065339 (8.7.0)
   Resolves: rhbz#2065337 (9.1.0)
-
 - ha_cluster - ha_cluster - support SBD fencing
   Resolves: rhbz#2066868 (8.7.0)
   Resolves: rhbz#2079626 (9.1.0)
-
 - ha_cluster - ha_cluster - add support for configuring bundle resources
   Resolves: rhbz#2073518 (8.7.0)
   Resolves: rhbz#2073519 (9.1.0)
-
 - kernel_settings - kernel_settings error configobj not found on RHEL 8.6 managed hosts
   Resolves: rhbz#2060378 (8.7.0)
   Resolves: rhbz#2060525 (9.1.0)
-
 - logging - logging tests fail during cleanup if no cloud-init on system
   Resolves: rhbz#2058807 (8.7.0)
   Resolves: rhbz#2058799 (9.1.0)
-
 - logging - Logging - RFE - support template, severity and facility options
   Resolves: rhbz#2075116 (8.7.0)
   Resolves: rhbz#2075119 (9.1.0)
-
 - metrics - Metrics role, with "metrics_from_mssql" option does not configure /var/lib/pcp/pmdas/mssql/mssql.conf on first run
   Resolves: rhbz#2060377 (8.7.0)
   Resolves: rhbz#2060523 (9.1.0)
-
 - metrics - metrics - consistently use ansible_managed in configuration files managed by role
   Resolves: rhbz#2065215 (8.7.0)
   Resolves: rhbz#2065392 (9.1.0)
-
 - metrics - [RFE] add an option to the metrics role to enable postfix metric collection
   Resolves: rhbz#2079114 (8.7.0)
   Resolves: rhbz#2051737 (9.1.0)
-
 - nbde_client - NBDE client system role does not support servers with static IP addresses
   Resolves: rhbz#2071011 (8.7.0)
   Resolves: rhbz#2070462 (9.1.0)
-
 - network - [RFE] Extend rhel-system-roles.network feature set to support routing rules
   Resolves: rhbz#1996731 (8.7.0)
   Resolves: rhbz#2079622 (9.1.0)
-
 - network - bond: fix typo in supporting the infiniband ports in active-backup mode
   Resolves: rhbz#2064067 (8.7.0)
   Resolves: rhbz#2065394 (9.1.0)
-
 - network - pytest failed when running with nm providers in the rhel-8.5 beaker machine
   Resolves: rhbz#2065217 (8.7.0)
   Resolves: rhbz#2066911 (9.1.0)
-
 - network - network - consistently use ansible_managed in configuration files managed by role
   Resolves: rhbz#2065670 (8.7.0)
   Resolves: rhbz#2065382 (9.1.0)
-
 - postfix - postfix - consistently use ansible_managed in configuration files managed by role
   Resolves: rhbz#2065216 (8.7.0)
   Resolves: rhbz#2065393 (9.1.0)
-
 - postfix - Postfix RHEL System Role should provide the ability to replace config and reset configuration back to default
   Resolves: rhbz#2065218 (8.7.0)
   Resolves: rhbz#2065383 (9.1.0)
-
 - sshd - FIPS mode detection in SSHD role is wrong
   Resolves: rhbz#2075338 (8.7.0)
   Resolves: rhbz#2073605 (9.1.0)
-
 - storage - RFE storage Less verbosity by default
   Resolves: rhbz#2056480 (8.7.0)
   Resolves: rhbz#2079627 (9.1.0)
-
 - timesync - timesync: basic-smoke test failure in timesync/tests_ntp.yml
   Resolves: rhbz#2060379 (8.7.0)
   Resolves: rhbz#2060524 (9.1.0)
-
 - tlog - Tlog role - Enabling session recording configuration does not work due to RHEL9 SSSD files provider default
   Resolves: rhbz#2072749 (8.7.0)
   Resolves: rhbz#2071804 (9.1.0)

+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 * Thu Apr 07 2022 Rich Megginson <...> - 1.16.3-1
 - tlog - Enabling session recording configuration does not work due to RHEL9 SSSD files provider default
   Resolves rhbz#2072749 (EL8)

linux-system-roles.spec can be found here https://src.fedoraproject.org/rpms/linux-system-roles
and an example diff with this problem created by Packit can be seen here: https://src.fedoraproject.org/rpms/linux-system-roles/pull-request/98#request_diff

Thanks for the report. I'll try to fix this ASAP.


Web App - Volunteer - On the Volunteer Home page, not all fields marked as required are being enforced

In the 'Report New Data' section, the 'Description' and 'Location' input fields are marked as required, but if I leave them blank and click 'Checkin', no error messages appear:

There are issues with this page that make the fix a larger project than defining identifying required fields.
Overview:
There are two sections of this page: 1) "Make a new commitment" and 2) "My Organization Resources".  Both appear to be controlled by the same view model in: "ViewModels/VolunteerViewModel.cs.".  This is causing issues with the validations of required fields on the page.  When either the "Volunteer" or the "Checkin" button is pressed the validation errors appear in both sections of the screen.  The best solution will be for the view models to be separated so that the areas of page are atomic (and can be reusable).

Is this related to #690?


Create manifest for snapshots and block positions

Transferred from https://github.com/AntelopeIO/leap/issues/1422 original author bhazzard

completed

still needed for production full run.