Branching issues/bugs

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
Code Issue 1, double DOWN execution and random order:
from typing import Annotated, Any, Sequence, TypedDict
import operator
class State(TypedDict):
    my_key: Annotated[list[str], operator.add]

def up(state: State):
    return {'my_key': ['UP']}

def side(state: State):
    return {'my_key': ['SIDE']}

def down(state: State):
    return {'my_key': ['DOWN']}

graph = StateGraph(State)

graph.add_node("up", up)
graph.add_node("side", side)
graph.add_node("down", down)

graph.set_entry_point("up")
graph.add_edge("up", "side")
graph.add_edge("up", "down")
graph.add_edge(["up", "side"], "down")
graph.set_finish_point("down")

app = graph.compile()
app.invoke({})

Code issue 2, DOWN can't accept additional output from a branch...
Works:
from typing import Annotated, Any, Sequence, TypedDict
import operator
class State(TypedDict):
    state: dict
    my_key: Annotated[list[str], operator.add]

def up(state: State):
    return {'state': {'a': 'k'}, 'my_key': ['UP']}

def side(state: State):
    return {'my_key': ['SIDE']}

def down(state: State):
    return {'state': {'a': 'k'}, 'my_key': ['DOWN']}

graph = StateGraph(State)

graph.add_node("up", up)
graph.add_node("side", side)
graph.add_node("down", down)

graph.set_entry_point("up")
graph.add_edge("up", "side")
graph.add_edge("up", "down")
graph.add_edge(["up", "side"], "down")
graph.set_finish_point("down")

app = graph.compile()
app.invoke({})

Does not work:
from typing import Annotated, Any, Sequence, TypedDict
import operator
class State(TypedDict):
    state: dict
    my_key: Annotated[list[str], operator.add]

def up(state: State):
    return {'state': {'a': 'k'}, 'my_key': ['UP']}

def side(state: State):
    return {'state': {'a': 'k'}, 'my_key': ['SIDE']}

def down(state: State):
    return {'state': {'a': 'k'}, 'my_key': ['DOWN']}

graph = StateGraph(State)

graph.add_node("up", up)
graph.add_node("side", side)
graph.add_node("down", down)

graph.set_entry_point("up")
graph.add_edge("up", "side")
graph.add_edge("up", "down")
graph.add_edge(["up", "side"], "down")
graph.set_finish_point("down")

app = graph.compile()
app.invoke({})

Error Message and Stack Trace (if applicable)
Code Issue 1:
Output:
Multiple runs produce random one of 2 results:
{'my_key': ['UP', 'SIDE', 'DOWN', 'DOWN']}

or
{'my_key': ['UP', 'DOWN', 'SIDE', 'DOWN']}

Code Issue2:
code 1 works and produces similar behavior to code issue 1.
code 2 stack trace:
---------------------------------------------------------------------------
InvalidUpdateError                        Traceback (most recent call last)
File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/pregel/__init__.py:1062, in _apply_writes(checkpoint, channels, pending_writes, config, for_step)
   1061 try:
-> 1062     channels[chan].update(vals)
   1063 except InvalidUpdateError as e:

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/channels/last_value.py:47, in LastValue.update(self, values)
     46 if len(values) != 1:
---> 47     raise InvalidUpdateError("LastValue can only receive one value per step.")
     49 self.value = values[-1]

InvalidUpdateError: LastValue can only receive one value per step.

The above exception was the direct cause of the following exception:

InvalidUpdateError                        Traceback (most recent call last)
Cell In[241], line 29
     26 graph.set_finish_point("down")
     28 app = graph.compile()
---> 29 app.invoke({})

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/pregel/__init__.py:838, in Pregel.invoke(self, input, config, output_keys, input_keys, interrupt_before_nodes, interrupt_after_nodes, debug, **kwargs)
    825 def invoke(
    826     self,
    827     input: Union[dict[str, Any], Any],
   (...)
    835     **kwargs: Any,
    836 ) -> Union[dict[str, Any], Any]:
    837     latest: Union[dict[str, Any], Any] = None
--> 838     for chunk in self.stream(
    839         input,
    840         config,
    841         output_keys=output_keys if output_keys is not None else self.output,
    842         input_keys=input_keys,
    843         interrupt_before_nodes=interrupt_before_nodes,
    844         interrupt_after_nodes=interrupt_after_nodes,
    845         debug=debug,
    846         **kwargs,
    847     ):
    848         latest = chunk
    849     return latest

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/pregel/__init__.py:886, in Pregel.transform(self, input, config, output_keys, input_keys, interrupt_before_nodes, interrupt_after_nodes, debug, **kwargs)
    874 def transform(
    875     self,
    876     input: Iterator[Union[dict[str, Any], Any]],
   (...)
    884     **kwargs: Any,
    885 ) -> Iterator[Union[dict[str, Any], Any]]:
--> 886     for chunk in self._transform_stream_with_config(
    887         input,
    888         self._transform,
    889         config,
    890         output_keys=output_keys,
    891         input_keys=input_keys,
    892         interrupt_before_nodes=interrupt_before_nodes,
    893         interrupt_after_nodes=interrupt_after_nodes,
    894         debug=debug,
    895         **kwargs,
    896     ):
    897         yield chunk

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langchain_core/runnables/base.py:1743, in Runnable._transform_stream_with_config(self, input, transformer, config, run_type, **kwargs)
   1741 try:
   1742     while True:
-> 1743         chunk: Output = context.run(next, iterator)  # type: ignore
   1744         yield chunk
   1745         if final_output_supported:

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/pregel/__init__.py:575, in Pregel._transform(self, input, run_manager, config, **kwargs)
    572 _panic_or_proceed(done, inflight, step)
    574 # apply writes to channels
--> 575 _apply_writes(
    576     checkpoint, channels, pending_writes, config, step + 1
    577 )
    579 if debug:
    580     print_checkpoint(step, channels)

File ~/PROJECT_FOLDER/.venv/lib/python3.11/site-packages/langgraph/pregel/__init__.py:1064, in _apply_writes(checkpoint, channels, pending_writes, config, for_step)
   1062     channels[chan].update(vals)
   1063 except InvalidUpdateError as e:
-> 1064     raise InvalidUpdateError(
   1065         f"Invalid update for channel {chan}: {e}"
   1066     ) from e
   1067 checkpoint["channel_versions"][chan] += 1
   1068 updated_channels.add(chan)

InvalidUpdateError: Invalid update for channel state: LastValue can only receive one value per step.

Description
I am trying to create a branched input similar to this example but with StateGraph
https://github.com/langchain-ai/langgraph/blob/main/examples/branching.ipynb
I encountered problems with LastValue exception and found this issue closed just yesterday:
https://github.com/langchain-ai/langgraph/issues/142
It's not exactly 2 inputs into a single node like in the first example but in the end the last node still receives 2 inputs.
Initial up side down example is by nfcampos in issue 142.
I've tried running the example provided in the issue 142 above.
It does not throw an exception. I then made my key a list of str and it works too.
The only issue I have with it is:
My expectation is that DOWN will be called once NOT TWICE.
And expectation 2 is that order of the calls is not random.
Ideally I exepcted [UP, SIDE, DOWN] with DOWN accepting UP and SIDE.
I then added my own state field to reproduce my initial issue with LastValue.
I provide 2 code examples, one works, the other one does not...
I was expecting that it would work.
For now, for my case, I implemented a workaround - I just modify a state object and return it and it's added to the list.. So i have a list of copies of state objects..
My expectation would have been for Issue2.case2 to work, or have a basic StateGraph with keys and not need to add operator.add thing to avoid raising multiple edges not possible exception.
System Info
grep lang
google-ai-generativelanguage==0.4.0
langchain==0.1.13
langchain-anthropic==0.1.4
langchain-community==0.0.29
langchain-core==0.1.33
langchain-experimental==0.0.55
langchain-google-genai==0.0.6
langchain-openai==0.0.6
langchain-text-splitters==0.0.1
langdetect==1.0.9
langflow==0.6.12
langfuse==2.21.1
langgraph==0.0.30
langsmith==0.1.31

System:
python 3.11.5

NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

It looks like you have two redundant edges pointing to the same node
graph.add_edge("up", "down")
graph.add_edge(["up", "side"], "down")

if you change that to be just
graph.add_edge(["up", "side"], "down")

then it works as expected

@nfcampos Thank you! I see you edited your example as well from that issue.
It indeed works now!
I am new to langgraph and was kinda confused by [up, side] usage and up down before that, but didn't have time to find out why it was a list. I assumed it was something about forcing an order to the eval, and that's why there is 2 ups to down there ha-ha. My bad.
This also fixes my other issue that lead me to this:
I was trying to do this in my own app:
graph.add_edge("up", "down")
graph.add_edge("side", "down")

When I needed to do this:
graph.add_edge(["up", "side"], "down")

I am marking it as resolved!


Order functionality improvements.

For now we can order by max two columns (two levels). We may keep list of expressions, so we don't have such limitation.
We would need initial expressions for OrderBy and OrderByDescending. These methods probably should return newly defined interface, and then we define extensions to the interface "ThenBy" and "ThenByDescending". These also would return the interface so we can cascade.
We just have to think of the efficiently way to store this information in the BaseSpec.

This is addressed with PR #30. The usage will be as following, we can chain several levels.
    public class StoresByCompanyOrderedDescByNameThenByIdSpec : Specification<Store>
    {
        public StoresByCompanyOrderedDescByNameThenByIdSpec(int companyId)
        {
            Query.Where(x => x.CompanyId == companyId)
                 .OrderByDescending(x => x.Name)
                      .ThenBy(x => x.Id)
                      .ThenByDescending(x => x.Title)
        }
    }

Notice:
If we create several Order chains, they all will be saved in the internal state of the specification, but the evaluator will parse only the last chain. I don't know if it makes sense to create several chains! Anyhow based on the decision, would be easy to change the behaviour in SpecificationEvaluator, and parse all of them.

If no one has comments here we can close the issue.
@ardalis are you OK with it, should we keep it this way? Only one Order chain will be evaluated.

Let's close it. We should only allow one chain. Adding another should probably throw a helpful exception.

Sure, we can throw an exception in the evaluator. But, are we sure we want to introduce termination behavior in this package?
We may just leave it with usage notice, or we may write analyzer to catch the ambiguous usages. Or, let's just evaluate all the chains and rely on the default behavior of the ORM (EF Core in this case).
Not sure what's the smartest thing to do.

Let's if nothing else demonstrate the current behavior in some integration tests so that we can look at it and figure out from concrete code examples how we would expect it to behave.  I'd rather the design that only one chain is supported be enforced than documented, since it's much more likely to be missed in docs (and the bug introduced might be a subtle one).

Ok, let's do that way. If there is more than one chain, the evaluator will throw an exception. I'll make the changes the following days.


Google doc add on: Imported diagrams are not cropped correctly

Issue from: https://github.com/jgraph/drawio/issues/4349#issuecomment-2075404346_
Hi @davidjgraph , thanks for your quick response.
Ok, now the diagram can be imported but it's not cropped, look at the following screenshot:

Could you please restore the prev functionality?
Thanks

duplicate of #4351 https://github.com/jgraph/drawio/issues/4351


Page Views are not sent to google analytics.

Thanks for your work on this plugin.
I've managed to make it work on my website https://www.python-graph-gallery.com. I can see real time users.
However, page views are not sent at all. I believe it is because of this line of code:
https://github.com/flpvsk/gatsby-plugin-gtag/blob/master/src/gatsby-ssr.js#L34
It set the send_page_view option to false. I don't understand this decision? Page views are what most people want to track through google analytics. Would it be possible to set it as an option in the plugin, or correct it?
Thanks a bunch,
Yan

Hey Yan, the send_page_view: false is there to avoid duplicating page views. Views are tracked here:
https://github.com/flpvsk/gatsby-plugin-gtag/blob/master/src/gatsby-browser.js#L22
Could you check your network tab? Also keep in mind that the script only works when NODE_ENV=production

Oh all good. This line just look weird in my console, and it looks like page view took a while to be accessible on my website. All ghood now, thanks for your work! 🙏


Ability to build DXVK Native in distro environments

At the moment the only source code releases for DXVK are the git repository itself (which has submodules), and the autogenerated git archive from Github (which does not have the submodules). Some Linux distributions have packaging systems that can use a git repository and its submodules as source code, but others such as Debian and Fedora need to start from a tarball of some sort.
This means the git archive is missing:

the vendored Vulkan headers (but distros can use a system copy since #3836 was merged)
the vendored SPIRV headers (but distros can use a system copy since #3836 was merged)
the vendored copy of libdisplay-info (but distros can use a system copy since #3824 was merged)
the vendored MinGW headers needed for DXVK Native

At the moment, the Debian package for DXVK has an extra tarball included in its packaging with a suitable snapshot from https://github.com/Joshua-Ashton/mingw-directx-headers, while the Fedora package copies headers from a system-wide copy of the MinGW headers at build time.
If the intention is that downstreams can rely on the submodules being present, it might be a good idea to do a meson dist at release time, and attach that as a release artifact? This is how Flatpak 1.15.x currently does its releases, for example: the official source release tarball flatpak-1.15.8.tar.xz attached to https://github.com/flatpak/flatpak/releases/tag/1.15.8 is the output of meson dist, and it contains submodules for some of the dependencies, which distros can choose to either use or bypass.

Alternatively, the vendored MinGW headers (which are the only dependency that can't easily be a system copy) could perhaps be managed with git subtree in preference to git submodule, similar to https://github.com/flatpak/flatpak/pull/5800


Rails 3.1 without asset_pipeline

Hi!
I would like to use ActiveAdmin in my app, but I'm using Rails 3.1 with config.assets.enabled = false
So, how can I use active admin without asset_pipeline?
Thanks!

Yes, this bothered me too when I wanted to use this in app ported from rails 3.0 (which uses extjs and I don't really use asset pipeline in this app) and it seems that it is not possible for the time being. So I left it.
AA generator just checks the rails version, nothing else.

P.S. this is not a "feature" but it should be considered a bug, because it defacto restricts you to use rails 3.0 when you can't/don't want to use asset pipeline.

I'd also like to see a solution to this.

Has anyone fixing this bug?

I want this too :t

Me too...

:+1:


Consider using Websocket with localhost server for low latency input capture and audio rendering

After setting up the websocket server, I found that the typical delay from the browser to the server is 0.21ms. This should allow the browser to play games.
I wrote this Websocket server in C #. If you use other compiled languages, there should be room for improvement.

Is this a round-trip latency?

Yes, the round-trip latency is about 0.2 milliseconds. The data I sent was 12 bytes of text "Hello World!". My CPU is AMD Ryzen 3700x. I think polling input and audio control data via localhost loopback should have similar performance on most computers.

Would be useful for all web action games or other web realtime applications, though surely in this project I won't require users to install anything before playing. Maybe you could pack it into something like a browser extension? (probably with a client program. just saying, don't know anything about browser extensions)

I am not suggesting to replace the original method with the method I proposed. This localhost websocket server provides a low-latency bridge between the game and device drivers. The old input method you implemented can coexist with this.
The chrome extension just runs JavaScript in a VM with limited functionality. This limits tasks that require privileges, such as direct communication with the keyboard and mouse.

I'm not good at writing codes that talk to hardwares/OS. And sounds like this should be a standalone project


-X flag requires argument of the form importpath.name=value

I've just tried to compile facette and i get this error:
facette: Building facette...
# command-line-arguments
/usr/lib/go/pkg/tool/linux_amd64/link: -X flag requires argument of the form importpath.name=value
result: fail
Makefile:116: recipe for target 'build/facette-linux-amd64/bin/facette' failed
make: *** [build/facette-linux-amd64/bin/facette] Error 1

Can anyone please help me? I am using latest released version with go 1.7.1

Hi @sint,
The issue was addressed by the 7ae8cc2e337eb047c2939cd86949a0003bdd0d3f change which is only available on master, not in the releases.

Thanks allot. It works! Are there any plans add this fix into a new release?

An alpha release of the 0.4.0 version if planned to land soon. It contains an almost fully rewritten backend and UI.

Addressed in 0.4-alpha.


feat(Telemetry): Switch to OpenTelemetry [DIS-83]

Goal
Send telemetry to X-Ray and stop cluttering the logs with errors that X-Ray isn't working.
Example trace
Steps to reproduce the below telemetry trace:

Enable the Pocket-Dev VPN
Run the 'RecommendationAPI / homeSlateLineup(en-US)' request in Postman, or the following request in an HTTP client of your choosing:curl --location --request POST 'https://recommendation-api.getpocket.dev' \
--header 'userId: 123456' \
--header 'encodedId: ABCDEF' \
--header 'consumerKey: 123-456-678' \
--header 'apiId: 123' \
--header 'applicationName: Postman' \
--header 'guid: 789' \
--header 'Jwt:<PHONE_NUMBER>065906570965' \
--header 'Content-Type: application/json' \
--data-raw '{
    "query": "query PostmanHome { homeSlateLineup(locale: \"en-US\") { slates { headline recommendations(count: 3) { id corpusItem { id } } } }}",
    "variables": null,
    "operationName": "PostmanHome"
}'

Search for an X-Ray trace on port 8000

Example trace in Pocket-Dev:

First segment has request headers
The first segment is emitted by FastAPI and contains sanitized request headers:

Second segment has GraphQL query
The second 'RecommendationAPI' segment contains the GraphQL query. I don't know why this isn't a child segment of the FastAPI one, but I think that doesn't matter much?

Reference
Tickets:

https://getpocket.atlassian.net/browse/DIS-83

Docs

Choosing between the AWS Distro for OpenTelemetry and X-Ray SDKs

Note: previously AWS

Implementation Decisions

OpenTelemetry is recommended by AWS:

AWS X-Ray recommends using AWS Distro for OpenTelemetry (ADOT) to instrument your application instead of this X-Ray SDK due to its wider range of features and instrumentations.

AWS, aiohttp, GraphQL and FastAPI are auto-instrumented. This allows us to get good insight into the application, without having to remember to put decorators everywhere.
OpenTelemetry did not yet have instrumentation for aiobotocore, so I wrote custom instrumentation based on the botocore instrumentation. The next step would be to open a PR against open-telemetry/opentelemetry-python-contrib to have this code merged in. I didn't want to block this PR on that.
OpenTelemetry currently does not support async emitting of telemetry, but works on a separate thread and batches telemetry, so it shouldn't block the event loop. A load test showed no measurable performance difference between our current (broken) asynchronous X-Ray instrumentation and OpenTelemetry. The batch processor is configured to emit telemetry to a sidecar once every 5 seconds or 2048 spans. Telemetry is efficiently encoded in binary format using gRCP.

Load test
The dev.yml load test was used to obtain the results below. It has a 30 minute ramp-up followed by a sustained 15 minute phase at 15 RPS.
There was no significant difference in latency or stability between this branch and the main branch. It's possible that the broken X-Ray telemetry in the main branch has a similar impact on performance as OpenTelemetry in this branch. I did not do a load test with all telemetry disabled.
This branch
X-Ray response time histogram

Artillery report
Note that the response times below include a network delay from my local machine to AWS.
All virtual users finished
Summary report @ 10:59:41(-0800) 2023-02-16
  Scenarios launched:  28911
  Scenarios completed: 28911
  Requests completed:  28911
  Mean response/sec: 10.7
  Response time (msec):
    min: 409.7
    max: 60356.2
    median: 515.5
    p95: 651.1
    p99: 1581.4
  Scenario counts:
    homeSlateLineup: 28911 (100%)
  Codes:
    200: 28909
    504: 2

Cloudwatch Dashboard

main branch
Artillery report
Note that the response times below include a network delay from my local machine to AWS.
All virtual users finished
Summary report @ 19:47:23(-0800) 2023-02-16
  Scenarios launched:  28767
  Scenarios completed: 28767
  Requests completed:  28767
  Mean response/sec: 10.65
  Response time (msec):
    min: 431.8
    max: 33069.5
    median: 524.2
    p95: 630.2
    p99: 753.6
  Scenario counts:
    homeSlateLineup: 28767 (100%)
  Codes:
    200: 28767

Cloudwatch Dashboard

I would make sure we have a way to disable telemetry quickly if we see too much performance overhead.

This is awesome


Fix/colcon build

Status
PRODUCTION / DEVELOPMENT
Description
As described in #1999

@esteve @amc-nu the main change of the PR is on the CMakeLists for vision_dpm_ttic_detect pacakge. The changes in the Dockerfile will be replaced by PR #1946, I just made them to allow for testing when building the docker image with colcon

@esteve @amc-nu I have undone the changes to the Dockerfile to keep the aim of the PR clean. The needed changes are mentioned in #1999 in any case for testing purposes.


Use localhost auth and tidy code

@AlbertDeFusco , these small changes might make this a little more usable. Unfortunately, there is no equivalent of fake-gcs-server , so it's not possible to do any CI testing here, so this package can never be production quality.


iOS - Invalid Callback ID

Dear,
I just created a new app on ionic.
cordova-plugin-music-controls 2.2.0 installed.
Everything works on Android but when I use iOS, I got the error "Invalid Callback ID received by sendPluginResult."
Any idea ?
Thanks
Philippe

Same problem here.

Same here

@dupphil @ramoncarreras any update on this?

Switching to CDVUIWebViewEngine solved the problem for me.

If you write this code after initialization, will work.
MusicControls.listen();

It could fix "Invalid Callback ID received by sendPluginResult"

Switching to CDVUIWebViewEngine solved the problem for me.

UIwebview is deprecated and slow unfortunately.  I wouldn't recommend this despite the multitude of issues wkwebview has it is still better.

If you write this code after initialization, will work.
MusicControls.listen();

Also try this as advised above by @blkd13


bug: Terminal statusline flashing when typing

Did you check docs and existing issues?

[x] I have read all the LazyVim docs
[x] I have updated the plugin to the latest version before submitting this issue
[x] I have searched the existing issues of LazyVim
[x] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
Linux
Describe the bug
Statusline flashing when typing in terminal. This seems related to lualine, as it doesn't happen with plain nvim config.
https://streamable.com/2le4c0
Steps To Reproduce

Open nvim (I'm using LazyVim starter for example)
:lua Snacks.terminal()
Start typing

Expected Behavior
Either no flashing, or no statusline at all.
Repro
LazyVim starter.

Please open snacks issues in the snacks repo.
I also can't reproduce this...

I already did by mistake, but are you sure? I tried using snacks repro and it's not reproducible there.

I solved it with
    {
      "nvim-lualine/lualine.nvim",
      opts = {
        options = {
          disabled_filetypes = { "snacks_terminal" },
        },
      },
    },

I can confirm it also happens to me after the latest changes that I pulled. Doesn't happen with snacks minimal repro which doesn't have Lualine, but it happens both on my local forked repo and a default LazyVim installation after I add version = false, so that it upgrades to latest HEAD.

Good find and clearly a lualine issue then.
Probably also happens with just :terminal?

Doesn't happen with :terminal for me.

No @folke it doesn't happen with :terminal. Only Snacks.terminal is affected in my environment.

@dpetka2001 this is a repro:
vim.cmd("botright 20 split")
vim.cmd.terminal()
vim.keymap.set("t", "<esc><esc>", "<C-\\><C-n>")
vim.opt_local.winbar = "title: %{b:term_title}" -- this causes the flickering
vim.cmd.startinsert()

Would be great if someone could report to lualine...

Was just about to create the issue with your minimal repro. But you did it faster 😛


Pretrain implementation issue

I apologize for reaching out again. Upon reviewing your pretraining code release, it appears that the decoder requires the addition of alibi positional embedding; otherwise, coding errors may occur. Alternatively, should I attempt to include a new attention block for the decoder without alibi?
Additionally, I'm curious about the choice of using 2D sinusoidal for the decoder instead of continuing with alibi.

Hi, I'm very sorry for the 2-week delay.
In preliminary experiments training vanilla MAE on SSL4EO, I found 2D-ALiBi outperformed 2D-sincos only in the encoder—2D-ALiBi in the decoder didn't perform well. So, when developing CROMA, I didn't even try to use 2D-ALiBi in the decoder.
I'm not sure I understand your first question. DecoderMAE should not use 2D-ALiBi. Can you please clarify your concern?

Thanks for your reply! My first question is in DecoderMAE, you use the Basetransformer block as decoder, but the Basetransformer block needs a input of alibi, so should I just remove the input of alibi?
BTW, I wonder if you use the same dataloader file in https://github.com/zhu-xlab/SSL4EO-S12/tree/main/src/benchmark/pretrain_ssl/datasets/SSL4EO, I'll be appreciate if you release the dataset load and process codes.

Thank you for your patient response!

Thank you for your patient response!


ISSUE-2925: Added support to get dbt files via s3, gcs and http sources

Describe your changes :

Fix #2925

Type of change :

[x] Improvement
[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@harshach @ayush-shah @pmbrull

LGTM


Update dependencies

Updates all dependencies.
Tested app.

Prettier is now enforcing trailling commas https://prettier.io/blog/2020/03/21/2.0.0.html


Excellent Detection Performance but not very good in classification

Before Asking

[X] I have read the README carefully. 我已经仔细阅读了README上的操作指引。

[X] I want to train my custom dataset, and I have read the tutorials for finetune on your data carefully and organize my dataset correctly; 我想训练自定义数据集，我已经仔细阅读了训练自定义数据的教程，以及按照正确的目录结构存放数据集。

[X] I have pulled the latest code of main branch to run again and the problem still existed. 我已经拉取了主分支上最新的代码，重新运行之后，问题仍不能解决。

Search before asking

[X] I have searched the DAMO-YOLO issues and found no similar questions.

Question
I have trained damo-yolo-m on my data (2 classes). The model can detect object very well, with no missing, no excessive. But the classification is not very good. So is there any idea or configuration for me to improve the classification accuracy or do some tradeoff between detection and classification tasks?
Additional
Thanks in advance!

Thanks for your interests on DAMO-YOLO. You can provide a higher weight for the classification loss, or train more epochs to see whether the classification loss would be further reduced. Besides, it's better to check your classification labels to see whether there are noise labels and category imbalance problem.


Unable to change .alert bg-color

In Alpha.6 I remember there was a variable to control the alert colors, this is now moved to some sort of automation script using the "theme-color-level" function.
Is there still a way to change the alert's background color through variable? Maybe I missed it.

Not directly, no. We're using Sass maps to provide easier customization—change one set of colors and everything else updates along with it.


Fixed starredPosts object identifier subscript error

When attempting to compile, an error stating that the subscript used to get a starredPosts object's identifier was ambiguous. This should fix that. (Emphasis on should: I'm new to Cocoa/CocoaTouch, and am not sure how to setup Parse so I can login to test the starred posts feature).
This way, the app at least compiles. I'm working on a branch to convert the rest of the deprecated Swift code, but those are only warnings.

Unfortunately, I am no longer supporting this project, and can't accept your pull request. Sorry!


upsert/insert graph documentation doesn't mention #dbRef functionality

It is currently pretty impossible to figure out using just official documentation how to insert/upsert references to existing entries, without googling up GitHub issues like this:
https://github.com/Vincit/objection.js/issues/441
It would be super-helpful to have at least a brief mention that using prop defined in dbRefProp is the way to relate to existing entities.

This line is in the documentation under the "Upsert Graphs" section, second paragraph:

By default upsertGraph method updates the objects that have an id, inserts objects that don’t have an id and deletes all objects that are not present. This functionality can be modified in many ways by providing UpsertGraphOptions object as the second argument.

I think that's pretty clear, but perhaps not prominent enough?
I personally avoid insert/upsert graph at all costs.

@heisian It doesn't explain how you can use upsert functionality to merely pass a bunch of ids without any actual attributes (to only update relationships, not entities).

@kibertoad You mean just updating the records in a pivot/intermediate table? With extra fields? or? Sorry, I don't understand the use-case.

Imagine you have Parent table and Children table, with Parent hasMany relationship to Children. Consider that you have setChildren method that passes list of ids for a parent, with Children being created in a different time and place, only linked to Parents later. (UI-wise you would have separate ui for creating parents and children, and separate ui to tick children that belong to selected parent)

Well, it is mentioned, but only in one example in this section. I think you live without #dbRef by using the relate option (both insertGraph and upsertGraph support it now). I'd merge a PR for a better #dbRef documentation though.

Awesome, I'm finally moving to an apartment with actual table today, hopefully will be able to produce PR for documentation.

I personally avoid insert/upsert graph at all costs.

@heisian Can you please share more info why you think these should be avoided? What are the side effects or any negatives?


GTN CoFest (15th of November)

We are organizing regular online CoFests (Collaboration/Contribution Fests) every 3 months on the 3rd Thursday for a day of the collaborative work on the training content.
The next one will be on the 15th of November.
We plan to focus on genome annotation training; but anyone who would like to contribute on any other topics is very welcome to join.
We will coordinate via Hangout (drop-in channel we will keep open the whole day) and the GTN Gitter channel.
During the day, we will also have a call meeting with the GTN to discuss the recent changes and future directions (#1088)

@bebatut and @shiltemann and @erasche will be online between 9am and 6pm (CEST) but people from other time zones should feel welcome to continue even before/after. We will keep an eye on Gitter and GitHub

We have many ideas for this CoFest, and participants can work on a wide range of topics depending on their interests:

Content

Add new topics, new tutorials
Training Handbook for instructors
Test existing tutorials and make improvements or file issues

List of tutorials needing some love
Improve the English there

Review open pull requests

Global Infrastructure

FAIRness evaluation of the training
Plan internationalisation and localisation support in order to make the training material available to users in their own language: open PR and some discussion about long term plan
BioSchemas support
Complete integration with the TeSS workflow annotator

Technical support

Workflow testing
Docker images
Interactive tours

Community

More visibility for training events
Support for Instructors
Instructors on the training website
Share your training philosophy and tips to help other instructors

For those looking for ideas for things to work on this week, check out the open issues and pull requests with the cofest label.

As I said to @bebatut, not sure how I will be able to participate, but here's a raw list of ideas for genome annotation (some easy, some not):

I have a few small changes to do to the Maker tutorial after the first session we did on it. I also need to fix the MPI support in the Maker conda package (jobs are just too long without it)
A tour for the Maker tutorial
a JBrowse tutorial? loading multiple kind of data, playing with all the options (I guess @erasche already have some ideas for that!)
some functional annotation stuff for eucaryotic species? in an ideal world I'd like a tutorial with blast, interproscan (conda packaging is a problem, and license too), blast2go or equivalent (license problem).
orthology stuff with OrthoFinder? (the iuc tool needs some love if I remember well)
some GGA tutorials? like "How can I refine the annotation produced by Maker (or Prokka etc) with Apollo from Galaxy?". Maybe also "How can I set up a public jbrowse/chado/tripal website from Galaxy"?

Yep, we have a WIP jbrowse tutorial. Unfortunately it wasn't well attached to a "biological story" which made it kind of strange.

Thanks everyone who participated to the CoFest yesterday!


Runscript for UCF101 or HMDB51 datasets

Hi,
I am interested in your work. I would like to test the suggested method on UCF101 or HMDB51 datasets.
Can you please share the runscripts for these datasets? i.e) like run_ucf_i3d.sh, reencode_ucf.sh, congits/.json files, and attack list file?
Thank you.

Sorry for the late reply, the running scripts on UCF and HMDB51 will be updated recently.


fix: correctly set google-cloud-resource-prefix headers

Currently many of the google-cloud-resource-prefix headers are being set to IDs rather than the fully qualified names that are expected. This PR ensures the google-cloud-resource-prefix headers are being correctly set as fully qualified names.

@jdpedrie I had trouble with fixing the unit and snippets tests so I wanted to check if there is a different approach I should consider.

@larkee what is the issue with the tests? I see kokoro is reporting problems with the style checker. You can run that locally via dev/sh/style from the repository root.

@larkee what is the issue with the tests? I see kokoro is reporting problems with the style checker. You can run that locally via dev/sh/style from the repository root.

The issue was with prophecy expected calls. Doing what you suggested has avoided that problem :+1:


deployment.toml configurations missing on externalizing authentication endpoint document

Is your suggestion related to a missing or misleading document? Please describe.
The deployment.toml configurations to be added in WSO2 IS is missing in the Host Authentication Endpoint on a Different Server documentation, which can be found in IS 5.11 doc.
Describe the improvement
The deployment.toml configurations that need to be added in WSO2 IS should be clearly indicated, and any other missing steps should be included to make this document comprehensive.
Related Issues:
#15721 #15714

Please find the Doc PRs for the fix of fix these issues.

Master: https://github.com/wso2/docs-is/pull/3953
IS 6.1: https://github.com/wso2/docs-is/pull/3960
IS 6.0: https://github.com/wso2/docs-is/pull/3961

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Un expected behavior  of ng-submit , getting triggred on hitting enter in input field

I'm submitting a ...

[x ] Bug report from 1.7.6
[ ] regression from 1.7.0
[ ] security issue
[ ] issue caused by a new browser version
[ ] other

Current behavior:
On clicking enter in the input field even when type="text"  ng-submit is getting triggred. It is not even the case of button tag without mentioning of type="button"
Expected / new behavior:
It should not submit form on clicking enter when enter is hit in input field.
Minimal reproduction of the problem with instructions:
code pen : https://codepen.io/rajathms/pen/zbqNXd
Step to reproduce the bug:  click enter in any of the input field you will get alert saying "ng-submit triggered"
AngularJS version:  1.7.6
Angular Material version:  1.1.13
Browser: all

Anything else:

Behavior is same with my app, which I use older version Angularjs - 1..5.8 , Angular Material - 1.1.5,
I Don't want migrate my app from 1.5.8 to 1.7.x , so if possible suggest a fix for 1.5.8 also.

This is not Angular's doing. It is how HTML forms work. More specifically, it is called implicit form submission:

A form element’s default button is the first Submit Button in tree order whose form owner is that form element.
If the user agent supports letting the user submit a form implicitly (for example, on some platforms hitting the "enter" key while a text field is focused implicitly submits the form) [...]
[...]
There are pages on the Web that are only usable if there is a way to implicitly submit forms, so user agents are strongly encouraged to support this.

There are ways you can work-around that, though. For example, you can remove ngSubmit from the form and change the type="submit" button to type="button" ng-click="save()".

Closing, since the behavior you are seeing is not caused by Angular.


[WIP] enable startwith in btree

What changes were proposed in this pull request?
To allow start with in btree index.
How was this patch tested?
TBA

Closing this per offline discussion


Switching Between Designs from the Analyze Dropdown does not change the Design

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1092
Originally created by @iroussos on 2019-10-04 18:56:03

In the latest version, if you switch between designs:

The url and the Nav bar change
The Design name and the Tables included remain those of the previous Design

What is fun is that if you keep on switching you always see the Design from the previous step. So the design keeps on switching while it is one click back.

View 2 previous comments from the original issue on GitLab


wowtoken - updated api

Converted the application to utilize a new API to retrieve data

I have read the CLA Document and I hereby sign the CLA

@ledif Cool to merge this?

Looks good to me.


re-added TURBO changes in a hopefully more proper way

I think I have added the necessary TURBO things while not getting rid of any of the things that were already there.

@mcoughlin @Theodlz Here is the new branch with the hopefully cleaner addition of TURBO things.  I tried running it locally, and I get a key error that I wasn't getting before: test_alert_broker_TURBO.py:75: KeyError.  Other than that it seems to be running fine.  Let me know if this looks better.

@rstrausb please fix the linting.

@mcoughlin If its just the unused import of pprint I have removed that and pushed that change.

@rstrausb You should do
pre-commit install
pre-commit run --files file/complained/about
This is what we use to keep our code uniform and readable.

@rstrausb As for the rest of the tests, I think you may have forgotten to copy the WNTR filter in the default config to be the same as for TURBO.

Hi @rstrausb. I'm in the process of reviewing your PR. I'm having some trouble running the code as Kowalski's dependencies aren't up to date, which is a blocker on certain configs.
I have this PR open and almost ready to go in, that will add a lot of changes to Kowalski, which all facilitate the development cycle of the app, and makes it easier to add new things: https://github.com/skyportal/kowalski/pull/186
When it goes in, it will probably create some merge conflicts with your current PR, but any of the changes you made will be facilitated. If you give me the right access to your fork, I'll be happy to solve whatever merge conflicts occur, so that we can get your changes in Kowalski reasonably quickly.
Could you please pull the branch from that PR and try to run it to see if it works well for you? Are you working on MacOS or linux by the way?

Hi @mcoughlin, on it.

Hi @rstrausb, I commited a bunch of changes to match the changes from the last PR that was merged with main. However, I am having a problem with the ingester tests. All the avro files that you ingested apparently have the same candid (or at least that's what the code says)? Since that's what it's indexed on, it can't really ingest more than one and the tests fail. Can you make sure that each alert have a distinct candid?

@Theodlz I'm working on it, but it might take a little while I'm on a break this week.  If you need to move things forward, you can temporarily remove the alerts while I work on fixing them.

@Theodlz I'm working on it, but it might take a little while I'm on a break this week. If you need to move things forward, you can temporarily remove the alerts while I work on fixing them.

Otherwise, if you are fine with that, I can just keep those files and edit them to make sure they have unique candid values?

@Theodlz That sounds like a good temporary fix, thanks!


Keycloak - more flexibility at import time

Is your feature request related to a problem? Please describe.
I've configured successfully the Backstage Plugin to communicate with RH SSO 7.6.2.GA .
In the KC realm we are using we have enabled Github as an IdP provider.
Unfortunately, the default mapping uses Github emails as userid.
And an e-mail is not an acceptable identifier for Backstage:
2023-07-05T16:48:11.901Z catalog warn Policy check failed for<EMAIL_ADDRESS>caused by Error: "metadata.name" is not valid; expected a string that is sequences of [a-zA-Z0-9] separated by any of [-_.], at most 63 characters in total but found<EMAIL_ADDRESS>To learn more about catalog file format, visit: https://github.com/backstage/backstage/blob/master/docs/architecture-decisions/adr002-default-catalog-file-format.md type=plugin<EMAIL_ADDRESS>
Describe the solution you'd like
Assuming that using an external IdP in Keycloak is a pretty common use-case, I'm looking for ways to bypass this issue.
Ideally the Keycloak Backstage plugin could be extended with some pre-defined strategy to clean data to accept only Backstage compatible values. Even better if I could provide directly a javascript lambda, where I can specify my own custom cleaning logic.
Describe alternatives you've considered
As a mitigation, I think that KC should be able to be instructed to use a different convention, but I think it might still be valuable to have this feature present also on the Backstage plugin side.
I'm right now asking the KC engineers what would be the correct way to mitigate this problem on the Keycloak side, since all my attempts failed so far.

This is the potential bug on Keycloak preventing to mitigate this issue on its side: https://github.com/keycloak/keycloak/issues/11195

Hi @paoloantinori yes, I think we want to enable this behavior.
We want users to be able to use userTransformer and groupTransformer functions that allow them to mutate the objects before their ingestion into Catalog.
This should satisfy similar needs as described for example here in LDAP plugin docs:
https://backstage.io/docs/integrations/ldap/org/#customize-the-provider
Do you think such a feature can help you with this problem? Or are you looking for a different solution?
There's a PR from the community introducing something like this, however, it still requires a lot of changes to reduce hardcoded behavior and offer the necessary customizations we strive for: https://github.com/janus-idp/backstage-plugins/pull/432


Add Nutanix walkthrough in cluster creation workflow doc

What would you like to be added:
Add Nutanix section in https://anywhere.eks.amazonaws.com/docs/concepts/clusterworkflow/
Why is this needed:

https://github.com/aws/eks-anywhere/pull/5987


Fix symmetry tests

Summary by CodeRabbit

Tests

Refined test imports for improved module isolation.

@samwaseda I found the issue


Add first unit tests

This also integrates tests into Travis, so this should start to automatically test functionality

This fails on python 2 as expected by #52, merging this to automate testing a PR for that problem.


doxygen documents generated

Merging phase1/devel - for the product backlog id: 1.1 to 1.15

changes reviewed


Feature request: +1/+1 bonus counter

It would be good to have a new +1+1 bonus counter, different from that blue +1+1 counter already available. So often we have to differenciate between actual +1+1 counters (the ones that remain in permanents) from +1+1 bonuses (the ones that are given from cards like honor of the pure or elvish archdruid).

While I'm sure adding a new marker type wouldn't be too difficult of a request,(at a glance looks like)
def addPlusOneBonus(card, x = 0, y = 0):

    mute()
    notify("{} adds a +1/+1 bonus to {}.".format(me, card))
   [logic here]

(obviously there is some other stuff like graphics and adding it in other places too)
I wondered if there was a way to script it instead. I tried using the scryfall api to target cards that add +x/+x using the regex re:"( get | gets )(+\d/+\d)" or https://api.scryfall.com/cards/search?q=re%3A%22(+get+|+gets+)(%2B\d%2F%2B\d)%22 to grab the list of cards. One could then cache this data and then narrow down the list further by setting cases for "other" "this" "target" etc.  I haven't looked too much into if power/toughness are static or loaded onto cards dynamically, but this would be a cool option and less time keeping track of bonuses.

I've been avoiding power/toughness modifiers mainly as I haven't figured out a proper way to display them, I really don't like the idea of using counters as it gets way too messy when there's different counters on a card (especially +1/+1 counters).  We don't really have a way to put text overlays over the cards, which would be IMO the cleanest way to handle it.

I agree, maybe for now, it would be a step to at least calculate bonuses and counters. Then, maybe a button that says calculate power/toughness and outputs it to chat for everyone. This would definitely be some major updating.
On the visual note:
Would have to use a blank P/T area like in the newer cards probably white because it'll be easier to modify to other colors.
Select Color(maybe prefab each version)
Calculate P/T
Then place on (X,Y) of the card.
I have no idea on how to implement the images with OCTGN, maybe some derivative of markers. Pretty new to OCTGN's stuff, seeing that the scripts are in python is it possible to implement pillow to add images and text?

well one thing I've been pushing for is the ability to have proxy images render whenever a card property changes (as python allows you to change the default values of a card property), which would in theory allow cards to display modified values


Preview script and data through stdin

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[x] Mac OS X
[x] Windows
[x] Windows Subsystem for Linux
[x] Etc.

Shell

[x] bash
[x] zsh
[x] fish

We use fzf with multi-select and a preview window to select tests and builds to perform, and the list of possible selections is large (~16000). In some situations, the length of the options chosen is longer than getconf ARG_MAX, meaning passing in the selections to the preview script on the command-line with {+} is not possible, and the preview window becomes blank.
I'd like to add an option to provide the preview script with its data using stdin instead of as command-line arguments. Ideally, this would be one entry per-line, as this is how most things reading stdin expect to get their data; keeping the quoting could still have benefits if newline is the delimiter, and it might simplify transition of any parsing script.

I have to say this is a very niche use case, but it's true there's no way to work around the limitation of ARG_MAX.
I've looked at your pull request, but there are several things I'd do differently.

It doesn't support variations of {+} such as {+n}, {+1..3}, etc, all of which may exceed ARG_MAX.
And the preview command template may contain any number of them.

--preview "my-previewer {+n} {+1..3} {+-1}"

I want them to work with execute bindings as well.
It's strange to keep shell-quoting when they are not passed as shell arguments. Line delimiter can be determined by --print0.

So I would instead introduce f flag that can be added to the expression. And fzf will replace each of them with a temporary file containing the evaluated list.
fzf --multi --preview 'my-previewer {+nf} {+2..f}'

* It doesn't support variations of `{+}` such as `{+n}`, `{+1..3}`, etc, all of which may exceed ARG_MAX.

* And the preview command template may contain any number of them.

  * `--preview "my-previewer {+n} {+1..3} {+-1}"`

Fair points.

* It's strange to keep shell-quoting when they are not passed as shell arguments. Line delimiter can be determined by `--print0`.

That was mostly to avoid much larger changes to replacePlaceholder, I do agree with you, though.

So I would instead introduce f flag that can be added to the expression. And fzf will replace each of them with a temporary file containing the evaluated list.
fzf --multi --preview 'my-previewer {+nf} {+2..f}'

This is a good idea. I'm happy to work on a PR for it. At first thought this would be using os.TempFile inside replacePladerholder if parsePlaceholder reports it has the new flag, and filling in the command with the path to the temporary file. I'm unsure how cleaning up the temporary files would work with the change in scopes but I'm sure I can work it out.

Closed by #1733.

I'm unclear about how this is supposed to work. I'm trying to get a live preview of a jq expression applied to json read from stdin. The following isn't working for me:
curl http://localhost:8080 | fzf --print-query --preview-window wrap --preview 'jq {q} {f}'

@icholy, do you have some sample data?
2>nul curl https://gist.githubusercontent.com/Rezvitsky/fd364fd01b22feb1f4a38c34f1066100/raw/e51ac3d0e3a50201d004beebfb7bf5a7c2a4f89f/json.json | fzf.exe --disabled --multi --reverse --bind ctrl-a:select-all --preview "jq {q} {+f}"

and the query is .response.users for example. It sort of works, maybe you want to file new issue.


Fixed broken test

Extracted from https://github.com/switchfly/ember-mocha/pull/13

Thanks @johanneswuerbach! Good catch finding this bogus test.


StyleCopTester should only analyze C# projects in a solution

Was receiving a large number of AD0001 reports due to attempting to analyze VB projects in Roslyn.sln.

:+1:


:seedling: test/e2e: remove MultiClusterRoundTripper

No clients set the context anymore, so this round-tripper does nothing.
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

/retest


CB-15171 Handle scenarios to recover from bad states in Stop / Start …

…scaling
Overview

New upscale and downscale states introduced to determine recovery candidates based on various criteria
Dedicated CM API calls for stop / start scaling failure recovery is used to infer host health
Additional messages are propagated to the activity console during recovery candidate identification
Introduced entitlements for the feature

Testing

Unit tests added for StopStartUpscaleActions and StopStartDownscaleActions for newly introduced getRecoveryCandidatesAction
UTs added for handlers of newly introduced states, as well as existing handlers

Links

Thunderhead Entitlement PR

TODO:

[x] Complete UT coverage
[ ] ~Introduce corresponding failure states for the newly introduced ones~

See detailed description in the commit message.

Rebasing on top of master due to failing swagger-compat tests


Memory information message

The Data start-end addresses can be reversed if the Data length is short.
example:
Code : ....
Data :  $2aa3 - $2aa2
Variables* .....

Thanks. This is to be fixed with the next release.

Sorry I can't reproduce this. I have tried with different length of data, even with a single byte and it always showed the correct addresses.


Spring Boot 3.2.4 (Cloud 2023.0.1) Cannot deserialize "pageable": "INSTANCE"

Describe the bug
Rest Controller in server with Spring Boot 2.7.18:

If I consume that end point from application with Spring Boot 2.7.18 (Cloud 2021.0.5) Deserialization is correct.
If I consume that end point from application with Spring Boot 3.2.4 (Cloud 2023.0.1) Deserialization fails.
log trace:
com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of org.springframework.cloud.openfeign.support.PageJacksonModule$SimplePageable (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('INSTANCE')

If I create Page object with the constructor:
Page page = new PageImpl<>(build, PageRequest.of(0,2), 2);
Works perfectly in Spring 2.7.18 and Spring boot 3.2.4
Thank you !!

Hello @dienarvil, thanks for reporting the issue. Please provide a minimal, complete, verifiable example that reproduces the issue.

demo.zip
localhost:8080/testok -> feign call to ok end point with Page page = new PageImpl<>(build, PageRequest.of(0,2), 2);
and
localhost:8080/testko -> feign call to ko end point with Page page = new PageImpl<>(build, Pageable.unpaged(), 2);

I just stumbled upon the same symptom and dug in a bit.
The reported error happens when deserializing the following json:
{
  "content": [
    "foo"
  ],
  "pageable": "INSTANCE",   <== HERE
  "totalPages": 1,
  "totalElements": 1,
  "last": true,
  "size": 1,
  "number": 0,
  "sort": [],
  "numberOfElements": 1,
  "first": true,
  "empty": false
}

As @dienarvil noted, the json is generated by the following:
Page<String> page = new PageImpl<>(List.of("foo"));  // or usage of Pageable.unpaged()
String json = this.objectMapper.writeValueAsString(page);

// deserialize json will throw the exception

When serializing a PageImpl, if it doesn't specify the pageable parameter, it uses Pageable.unpaged().
SpringDataJacksonConfiguration from spring-data-commons registers a serializer for Unpaged which writes out the value INSTANCE. So, the generated json has pageable:"INSTANCE".
It is not the json format that spring-cloud-openfeign is expecting.
In v4.1.1, PageJacksonModule#SimplePageImpl added Pageable object parameter(https://github.com/spring-cloud/spring-cloud-openfeign/pull/984) and the expected format is SimplePageable. The deserializer doesn't work for INSTANCE string from Unpaged.
Per https://github.com/spring-projects/spring-data-commons/issues/3024, spring-data-commons v3.3 may produce a more stable json representation.
@dienarvil
For a fix, I suggest simply providing the page information(Pageable) rather than using Unpaged while creating PageImpl object. So, that the response json will be more conformed as an added benefit.

@dienarvil For a fix, I suggest simply providing the page information(Pageable) rather than using Unpaged while creating PageImpl object. So, that the response json will be more conformed as an added benefit.

Thanks for the advice, yeah, with "normal" pagination from a repository the problem will never arise.
Thanks again!!

Thanks for the analysis @ttddyy. Until this gets addressed better in Spring Data, we expect a proper Pageable object to be provided.


spark version?

we should say what versions of spark are supported by our magic.

tested 2.0.2, 2.1.2, 2.2.1, and 2.3.1.


UITableView .indexPathForLastRow is wrong

https://github.com/omaralbeik/SwifterSwift/blob/development/Source/Extensions/UI/UITableViewExtensions.swift#L16
current implementation is wrong:
	public var indexPathForLastRow: IndexPath? {
		guard numberOfRows > 0 else {
			return nil
		}
		return IndexPath(row: numberOfRows - 1, section: lastSection)
	}

it should be:
     return IndexPath(row: indexPathForLastRow(in: lastSection), section: lastSection)

return IndexPath(row: indexPathForLastRow(in: lastSection), section: lastSection)

@muescha True, however the above code is a bit repetitive and didn't work because an optional IndexPath being passed method instead of row
I refactored the code to:
public var indexPathForLastRow: IndexPath? {
    return indexPathForLastRow(inSection: lastSection)
}

Will change it in the next release, thank you!

yes - that is much shorter :)


Add release-0.9 notes

Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

https://www.cncf.io/blog/2022/10/31/open-cluster-management-november-2022-update/
CNCF blog post for reference.

LGTM

Not sure what happen I see a commit https://github.com/open-cluster-management-io/open-cluster-management-io.github.io/commit/513cc83322122ab8f07922cc8febc29c371677f1 which contains the app addon changes but when I click Files Changes I don't see it.


PlatformNotSupportedException on Linux Mono

Stack trace:
System.PlatformNotSupportedException: Operation is not supported on this platform.
  at System.Security.Cryptography.X509Certificates.X509Certificate2.set_PrivateKey (System.Security.Cryptography.AsymmetricAlgorithm value) [0x00000] in <e8eb3d7a311640f484845e45cbec8973>:0
  at Titanium.Web.Proxy.Network.Certificate.BCCertificateMaker.generateCertificate (System.String hostName, System.String subjectName, System.String issuerName, System.DateTime validFrom, System.DateTime validTo, System.Int32 keyStrength, System.String signatureAlgorithm, Org.BouncyCastle.Crypto.AsymmetricKeyParameter issuerPrivateKey) [0x001a5] in <b8483e74ac57448a8b42faa9e102aa58>:0
  at Titanium.Web.Proxy.Network.Certificate.BCCertificateMaker.makeCertificateInternal (System.Boolean isRoot, System.String hostName, System.String subjectName, System.DateTime validFrom, System.DateTime validTo, System.Security.Cryptography.X509Certificates.X509Certificate2 signingCertificate) [0x0005d] in <b8483e74ac57448a8b42faa9e102aa58>:0
  at Titanium.Web.Proxy.Network.Certificate.BCCertificateMaker.makeCertificateInternal (System.String subject, System.Boolean isRoot, System.Boolean switchToMtaIfNeeded, System.Security.Cryptography.X509Certificates.X509Certificate2 signingCert, System.Threading.CancellationToken cancellationToken) [0x00110] in <b8483e74ac57448a8b42faa9e102aa58>:0
  at Titanium.Web.Proxy.Network.Certificate.BCCertificateMaker.MakeCertificate (System.String sSubjectCn, System.Boolean isRoot, System.Security.Cryptography.X509Certificates.X509Certificate2 signingCert) [0x00000] in <b8483e74ac57448a8b42faa9e102aa58>:0
  at Titanium.Web.Proxy.Network.CertificateManager.makeCertificate (System.String certificateName, System.Boolean isRootCertificate) [0x0002f] in <b8483e74ac57448a8b42faa9e102aa58>:0
  at Titanium.Web.Proxy.Network.CertificateManager.CreateCertificate (System.String certificateName, System.Boolean isRootCertificate) [0x00064] in <b8483e74ac57448a8b42faa9e102aa58>:0
Titanium.Web.Proxy.Exceptions.ProxyConnectException: Couldn't authenticate host 'clients2.google.com' with certificate ''. ---> System.ArgumentException: ServerCertificate
  at Mono.Net.Security.MobileAuthenticatedStream.ProcessAuthentication (System.Boolean runSynchronously, Mono.Net.Security.MonoSslAuthenticationOptions options, System.Threading.CancellationToken cancellationToken) [0x0002e] in <e8eb3d7a311640f484845e45cbec8973>:0
  at Titanium.Web.Proxy.ProxyServer.handleClient (Titanium.Web.Proxy.Models.ExplicitProxyEndPoint endPoint, Titanium.Web.Proxy.Network.Tcp.TcpClientConnection clientConnection) [0x00b23] in <b8483e74ac57448a8b42faa9e102aa58>:0
   --- End of inner exception stack trace ---
  at Titanium.Web.Proxy.ProxyServer.handleClient (Titanium.Web.Proxy.Models.ExplicitProxyEndPoint endPoint, Titanium.Web.Proxy.Network.Tcp.TcpClientConnection clientConnection) [0x00bc2] in <b8483e74ac57448a8b42faa9e102aa58>:0

Please try the latest beta version.

StreamExtended is missing. I added it through NuGet and got
Assembly 'Titanium.Web.Proxy' with identity 'Titanium.Web.Proxy, Version=3.0.984.0, Culture=neutral, PublicKeyToken=8e41e1f1c790d7cf' uses 'StreamExtended, Version=3.0.984.0, Culture=neutral, PublicKeyToken=bbfa0f1d54f50043' which has a higher version than referenced assembly 'StreamExtended' with identity 'StreamExtended, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=bbfa0f1d54f50043' (CS1705)
I also tried to build from the source. Titanium.Web.Proxy.Mono.sln doesn't contain StreamExtended. I added it, tried to build, then
Error: NuGet packages need to be restored before building. NuGet MSBuild targets are missing and are needed for building. The NuGet MSBuild targets are generated when the NuGet packages are restored. (StreamExtended)
How can I do that?

Sorry, please try 987-beta. StreamExtended package reference was removed.

Thank you.

Is it working now on mono?

Yes, it is.


fix(DIA-195): does not submit if the forgot form is not dirty yet

This PR resolves DIA-195
Description
Simple bug fix, on the Forgot Password screen, if we submit via keyboard without inputting anything the form submits. This PR doesn't allow submitting the Form if it's not dirty yet.
Bonus: small test refactor off deprecated methods
Before:
https://github.com/artsy/eigen/assets/15792853/87530c11-4145-4fc8-9261-1f8da03371f9
After:
https://github.com/artsy/eigen/assets/15792853/a7f71788-f119-49d0-a9d7-4b5bac033241
PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix: forgot password screen does not submit with the keyboard without data being input - araujobarret

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix: forgot password screen does not submit with the keyboard without data being input - araujobarret)
undefined (changes)

  Generated by :no_entry_sign: dangerJS against eb7e50f03e8504ec23d21a94333f9db23b4c25df


Nodejs 12.16.1 linux arm32

Question: in the build.sh script the pkg_arch is set to armv6.  I had tried setting this to armv7, but I got the output below.  Is it intended for armv6 and armv7 files to be interchangeable, just change the architecture suffix in the resulting file?
And thanks.  Neat project.
Sending build context to Docker daemon  7.118MB
Step 1/7 : FROM arm32v7/node:latest
---> b5c00f3476df
Step 2/7 : COPY bin/qemu-arm-static /usr/bin/
---> Using cache
---> cb7a9ee1c498
Step 3/7 : RUN apt-get update && apt-get install -y --no-install-recommends wget build-essential git
---> Using cache
---> 72d16e0ac275
Step 4/7 : ENV PKG_CACHE_PATH=/fetched
---> Using cache
---> 3749877a39ee
Step 5/7 : RUN mkdir -p /fetched && npm install pkg-fetch
---> Using cache
---> 5948a973b9f3
Step 6/7 : RUN /node_modules/.bin/pkg-fetch node12 linux armv7
---> Running in 0b039897254f
qemu: Unsupported syscall: 397

Error! 404 Not Found
https://github.com/zeit/pkg-fetch/releases/download/v2.6/uploaded-v2.6-node-v12.16.1-linux-armv7
Asset not found by direct link:
{"tag":"v2.6","name":"uploaded-v2.6-node-v12.16.1-linux-armv7"}
Not found in GitHub releases:
{"tag":"v2.6","name":"uploaded-v2.6-node-v12.16.1-linux-armv7"}
Building base binary from source:
built-v12.16.1-linux-armv7
Error! Not able to build for 'armv7' here, only for 'armv6'
The command '/bin/sh -c /node_modules/.bin/pkg-fetch node12 linux armv7' returned a non-zero code: 2

Is it intended for armv6 and armv7 files to be interchangeable, just change the architecture suffix in the resulting file?

Exactly, that error is the reason why it works like this now :)

Thanks @munelear ! LGTM


Thank you for this library!

@whitedogg13 I’m using your library for a work project, and it has been immensely helpful for us. Thank you for sharing your work with the community!
I couldn’t find an active account for you on Twitter to express appreciation, so this was the best way I knew how to send a message.

@klcantrell thanks! It's always good to help the community! :)


Bots typo fix

Hi, i forked the repo and fixed the typo, mostly to try github's fork/pull request mechanism (never did that before). In the process i edited .gitignore too, since i was using Pycharm and didn't want to version the .idea folder (and the ~ files).
Please feel free to discard the pull request if something is odd/not done in the correct way :)

Hey @fraben, just wanted to thank you for this! It's been incorporated for the v0.6.2 release (available now).

My pleasure :)


Manually roll the engine and update Gradle dependency locks

This is required whenever the embedding dependencies are changed.
To update the dependencies in the future, use:
find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart
Subsumes this auto-roll: https://github.com/flutter/flutter/pull/92794

Is this the fix for https://github.com/flutter/flutter/issues/92801?

Yup

Was this a breaking change? Are end-users going to have to take any action to compensate for the updated engine deps?

Apologies, I did not know about this, thanks @blasten!

I think only if they're using lock files in a similar way. @blasten would know better

No. This isn’t not a braking change. The lockfiles are used to keep the deterministic Gradle dependencies during CI execution.

@angjieli is kicking the internal test run, which should hopefully turn the "Google testing" run green.


Show text efficiency

I saw the show text: show-cn-fakebold in the README and was wondering whether the show text part is really necessary. It will be very inefficient. Since the inner rules already apply to show text.where(weight: "bold").or(strong) just applying this rule to everything rather than text elements individually should probably also work.

Thank you for bringing this up. Would you suggest changing show text: show-cn-fakebold to show: show-cn-fakebold as a more efficient solution?

That sounds like the correct change. If it works, it should be good!


Feature: Pass lSpec to RunStep and include it in parameter parsing

Feature Details
Pass lWorkflow$spec to RunStep when it exists, and if lStep$param asks for "lSpec" pass it through.
Example Code

Possible Implementation

Additional Comments

@lauramaxwell we need to add this to the vignette.


DateUtilsTest asserts

Use JUnit's assertFalse for assertions with conditions instead of
re-implementing the logic here by testing the condition and throwing an
AssertionFailureException if the condition is met.

:+1:

Thanks!

Coverage decreased (-0.007%) to 94.529% when pulling 59effed7ad53df5a59bee8b09b8e21ba9900156b on mureinik:DateUtilsTest into 44516f77ecd06aa818263ec31e150bab3edd956b on apache:master.


parent query + | mitochondrial degradosome

| mitochondrial degradosome

shouldn't be is_a
cytoplasmic exosome (RNase complex) (GO:0000177)
(cytoplasmic exosome (RNase complex) is a specific complex

moved is_a parent up to exoribonuclease complex


Optionally disable MissingReturnType on actions

Its a bit annoying to get around the MissingReturnType errors on controller action methods, since they can return many different things (Response, array, any objects depending on view listeners).
Would be nice to have a config to disable MissingReturnType if the method is a *Controller::*Action.

@beberlei thank you for the report!
I faced the same issue and I see your point. But I think it is better to handle on project level because:

it is hard to tell if a method is a controller action. For controller method Action suffix is not required after Symfony 3 (for example: https://symfony.com/doc/4.4/controller.html).
it is very easy to suppress on a project level if needed. Example on paslm.xml:

<issueHandlers>
    <MissingReturnType>
        <errorLevel type="suppress">
            <directory name="src/Controller" />
        </errorLevel>
    </MissingReturnType>
</issueHandlers>


Add new targets into Makefile

make compose-up may be long to write.
It's better to have make up and make down as aliases.
Makefile will be something like that:
...

env-files:
ifeq ($(OS),Windows_NT)
	powershell ./hack/env-files.ps1
else
	./hack/env-files.sh
endif

compose-up: env-files
	docker-compose up -d --build

compose-down: env-files
	docker-compose down --remove-orphans

up: compose-up

down: compose-down

And the usage will be like that:
make up

make down


HADOOP-18127. Backport HADOOP-13055 into branch-2.10

Description of PR
Back porting HADOOP-13055 needed two more commits.
So this PR  includes three commits:

HADOOP-13722. Code cleanup -- ViewFileSystem and InodeTree.
HADOOP-12077. Provide a multi-URI replication Inode for ViewFs.
HADOOP-13055. Implement linkMergeSlash and linkFallback for ViewFileSystem

How was this patch tested?
mvn clean test -Dtest=Test*ViewF*

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ branch-2.10 Compile Tests _

+0 :ok:
mvndep
2m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 37s

branch-2.10 passed

+1 :green_heart:
compile
13m 59s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 23s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
1m 55s

branch-2.10 passed

+1 :green_heart:
mvnsite
2m 20s

branch-2.10 passed

+1 :green_heart:
javadoc
2m 36s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 54s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m  0s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

-1 :x:
spotbugs
2m 35s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
14m  4s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

-1 :x:
javac
14m  4s
/results-compile-javac-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt
root-jdkAzulSystems,Inc.-1.7.0_262-b10 with JDK Azul Systems, Inc.-1.7.0_262-b10 generated 1 new + 1680 unchanged - 0 fixed = 1681 total (was 1680)

+1 :green_heart:
compile
12m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
javac
12m 30s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 generated 1 new + 1568 unchanged - 0 fixed = 1569 total (was 1568)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 58s
/results-checkstyle-root.txt
root: The patch generated 1 new + 181 unchanged - 44 fixed = 182 total (was 225)

+1 :green_heart:
mvnsite
2m 21s

the patch passed

+1 :green_heart:
javadoc
2m 33s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
5m 18s

the patch passed

_ Other Tests _

-1 :x:
unit
11m 26s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
79m 12s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

209m 24s

Reason
Tests

Failed junit tests
hadoop.fs.sftp.TestSFTPFileSystem

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4015/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4015

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 0ab03a5014ef 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 3682078fb872604576180610cc2fac67d04a8692

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4015/1/testReport/

Max. process+thread count
1933 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4015/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Checked spotbugs warnings. They are all against branch-2.10, not the patch. For the patch spotbugs report is actually clean
+1 :green_heart: 	spotbugs 	5m 18s 		the patch passed
Also looked at Checkstyle warning. There is one new in TestViewFileSystemHdfs , but it is inherited from the original commit, so I would rather leave it as is.
Unit tests are all passing locally.

LGTM +1


Loop Problem (Windows)

Can you fix windows specific loop please?
Common one only support 64 simultaneous connection
And windows specific one doesn't download photos
Thanks for this super script

@alexbers

Could you please try to launch the proxy with the last unreleased version of python (3.7). It could be this bug: https://bugs.python.org/issue26819. Also I seen this https://bugs.python.org/issue33833 but it is not fixed yet

@alexbers
OK , I will test that

@alexbers
With 3.7 both of them have problem (windows specific and common one)
and proxy is unstable,many disconnection

@alexbers
Whats your opinion?

I think the problem is from your side. To just test, I installed Windows Sever 2016 on VMWare and set up this proxy's master branch on it with pycryptonode installed.(Python version 3.6.5) I installed OpenVPN Connect on server(to bypass censorship) and everything is working fine. I can upload, download and send messages. I haven't yet tried 64 simultaneous connections.
For your uploading problem, have you installed pycryptonode?

@HirbodBehnam
@alexbers
Yes I already installed pycryptodome
My Python version is 3.6.5
I cant download images.but sending and recieving text messages is very fast
When i disable windows specific loop i can download images too , but common loop has limit (64 simultaneous connection)
Maybe windows 2008 has problem (you have windows 2016)

Ok I tried that on Windows server 2008 RT. I couldn't connect to proxy at all unless I used loopback. I mean I downloaded Telegram Desktop on server and entered localhost as server ip. With that everything was fine.
Can you try to download telegram desktop on server and connect it through localhost?

@HirbodBehnam
@alexbers
I connected successfully with localhost and i don't have any problem with or without localhost
my problem is 64 simultaneous connection limit
You said that you cant connect with windows server 2008,what about server 2012? can you test it?

@ea1234567 I don't have the ISO file.

@ea1234567 could you try the latest version from master. I refactored the connection handling and how it should have less corner cases, which may fire in windows event loop implementation

@alexbers
I dont have access to server now
I will test it 6 days later certainly (Wednesday 4 July)

@alexbers
I tested problem is still remaining (windows server 2008)
I will test on windows server 2016 next week (7 july)

Nice!


--upn-or-object-id has been deprecated, use --id instead

Within the command snippet: "az ad user show --upn-or-object-id<EMAIL_ADDRESS>--query objectId -o tsv" it tells you that the parameter "--upn-or-object-id" is deprecated.
➜ az --version
azure-cli                         2.0.75 *
➜
command-modules-nspkg              2.0.3
core                              2.0.75 *
nspkg                              3.0.4
telemetry                          1.0.4
Python location '/opt/az/bin/python3'
Extensions directory '/home/wuerzelchen/.azure/cliextensions'
Python (Linux) 3.6.5 (default, Oct 11 2019, 09:04:35)
[GCC 7.4.0]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a47c6df7-5103-1336-eb0b-68f95155e6c8
Version Independent ID: f4420b08-9b57-f581-fcb4-f069afdd5b0c
Content: Integrate Azure Active Directory with Azure Kubernetes Service
Content Source: articles/aks/azure-ad-integration.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
@mlearned Can you please take a look at this one?

This article no longer uses the deprecated parameter
#please-close


Keyboard/Controller controls for UI

I think it'd be really useful to integrate keyboard and controller controls for UI, with seamless integration / switching between Mouse and Keyboard Inputs so whatever you are selecting (or was selecting) is remembered when switching from mouse input to keyboard/controller input. I was able to achieve something like this in the video attachment below in a slightly old project of mine.
I think this would be really useful for Fusion and to make UI design easier and to also make it more accessible on more platforms. I know that Roblox has a default GamepadCursor for UI control on consoles, however I find it really lazy and not as fun to control and intuitive as using the D-Pad to move in UI.
If this were to be added to Fusion, I would appreciate having options to customize controls for input direction, and being able to select and highlight specific buttons you want to "Scroll" over and select in the menu, and customize the Scroll direction between horizonal (X) or vertical (Y) direction and to be able to quickly switch from different "Scroll menus" or ScrollingFrames. Also an option to auto move and focus to a selected button in a scrolling frame using the ScrollingFrame's CanvasPosition would be nice.
Also, the way I had most of this menu-scroll that I implemented in this attachment was made possible by having a set of RBXScriptConnections stored in a table for each button like a buttons reaction to MouseButton1Click or MouseEnter/Leave and having it triggered when you select it both by mouse or by keyboard/controller
https://github.com/user-attachments/assets/bf0860bc-9b43-4e3d-bf49-31a4076b02e2

Fusion tries to avoid implementing overly opinionated abstraction layers explicitly. We want Fusion to remain a generic layer so that others can build these sorts of input libraries on top of it, with whatever opinions work best for their project. One solution rarely fits all.
As such, this wouldn't be considered a logical extension of Fusion's core utilites, so it's unlikely this will get implemented.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8269711). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   98.22%
=======================================
  Files           ?       19
  Lines           ?      338
  Branches        ?       33
=======================================
  Hits            ?      332
  Misses          ?        6
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Show HomeKit code in log

@vlebourl @tetienne first version, are you ok to merge it like this for the logging, or should I rewrite it to make it nicer?

Can you please move the code within a dedicated method?


Wrong version in Add or Remove Programs (ARP)

Hey!
So i've started adding the new releases to WinGet, however the Version in Add or Remove Programs have the wrong Display Version, so we have to keep updating <IP_ADDRESS> instead of adding 2.9.1 or 2.9.2.
Could you guys please fix this? :) Thanks

Hi, i forgot to update the installer script between recompilations... I'm at work and will update it in about 10 hours, ok?
How do you publish the app to Winget? I probably could do it when i release new versions!

No worrys, just hoped for a fix before a new release :)
I believe you have 3 ways

Create new manifests with the new InstallerUrl/Hash/Version, Submit manually
Use some kind of GitHub Magic to automatically submit a PR when a new release is out
I believe use a Bot to use winget-create to create and submit a new PR

I currently track every InstallerUrl with a GitHub link so there is no stress to fixing some automation 😁

Hi, i've just updated the installer with the correct version number. Thanks for publishing it to Winget, i will take a look on how to do it myself on the next release, maybe automating it with a Github Action.


Need documentation clarity on the open ports for multi-tenant App Services

[Enter feedback here]
We had an ARR customer open this doc request https://github.com/MicrosoftDocs/azure-docs/issues/59173. But it seems to be closed prematurely without providing any details or ETA.
There need to be something similar like below but for app service in public multi-tenant stamp
https://docs.microsoft.com/en-us/azure/app-service/environment/app-service-app-service-environment-control-inbound-traffic#inbound-network-ports-used-in-an-app-service-environment
Reason for ask: This is a very common support request. We need official and public documentation that clearly outlines exactly which ports are open to an app service by default as well as how default ports of apps and services (i.e. Visual Studio, FTP(s), SSH, etc.) are handled. This is a normal security consideration that comes up during company audits and is a continuing struggle for CSS to satisfactorily respond from the customer's perspective
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae743313-9367-b465-e31a-5beae33018d1
Version Independent ID: c0cd348d-764a-572b-d900-ff0cffe12a31
Content: Networking features - Azure App Service
Content Source: articles/app-service/networking-features.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

@JatinBavishi We are checking this and we will get back to you.

@JatinBavishi Thank you for your feedback, the ports for multi-tenant have been described here: https://docs.microsoft.com/en-us/azure/app-service/networking-features#app-service-ports. Hope this helps.

#please-close


Deprecation warnings in Unity 2017.2

Pull requests #13 and #15 seem to partially address this, but I figured it would be best to have everything in one place and some of these issues seem to be newer.
Assets/Editor/WakaTime/Main.cs(74,37): warning CS0618: `UnityEditor.EditorApplication.currentScene' is obsolete: `Use EditorSceneManager to see which scenes are currently loaded'
Assets/Editor/WakaTime/Main.cs(83,42): warning CS0618: `UnityEditor.EditorApplication.currentScene' is obsolete: `Use EditorSceneManager to see which scenes are currently loaded'
Assets/Editor/WakaTime/Main.cs(84,38): warning CS0618: `UnityEditor.EditorApplication.currentScene' is obsolete: `Use EditorSceneManager to see which scenes are currently loaded'
Assets/Editor/WakaTime/PythonInstaller.cs(67,56): warning CS0618: `UnityEngine.WWW.size' is obsolete: `WWW.size is obsolete. Please use WWW.bytesDownloaded instead'
Assets/Editor/WakaTime/SceneDirtyChecker.cs(18,61): warning CS0618: `UnityEditor.EditorApplication.currentScene' is obsolete: `Use EditorSceneManager to see which scenes are currently loaded'
Assets/Editor/WakaTime/SceneDirtyChecker.cs(25,61): warning CS0618: `UnityEditor.EditorApplication.currentScene' is obsolete: `Use EditorSceneManager to see which scenes are currently loaded'

Hello!
I've fixed the warnings, although I didn't really migrate to WWW


Bump lxml from 4.6.3 to 4.6.5

Bumps lxml from 4.6.3 to 4.6.5.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: lxml
dependency-type: direct:production
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

Bumps lxml from 4.6.3 to 4.6.5.
* [Release notes](https://github.com/lxml/lxml/releases)

* [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)

* [Commits](https://github.com/lxml/lxml/compare/lxml-4.6.3...lxml-4.6.5)

updated-dependencies:
* dependency-name: lxml
  dependency-type: direct:production
  ...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

https://github.com/ggeop/Python-ai-assistant/pull/126

Bumps lxml from 4.6.3 to 4.6.5.
* [Release notes](https://github.com/lxml/lxml/releases)

* [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)

* [Commits](https://github.com/lxml/lxml/compare/lxml-4.6.3...lxml-4.6.5)

updated-dependencies:
* dependency-name: lxml
  dependency-type: direct:production
  ...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

https://github.com/ggeop/Python-ai-assistant/issues/127#issuecomment-1073185586

Bumps lxml from 4.6.3 to 4.6.5.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: lxml
dependency-type: direct:production
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>
https://github.com/ggeop/Python-ai-assistant/pull/126

Bumps lxml from 4.6.3 to 4.6.5.
* [Release notes](https://github.com/lxml/lxml/releases)

* [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)

* [Commits](https://github.com/lxml/lxml/compare/lxml-4.6.3...lxml-4.6.5)

updated-dependencies:
* dependency-name: lxml
  dependency-type: direct:production
  ...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

12b054e6ee0a111399538e4be14fe476ec6247ac


There should some space before contact name in contact page

Describe the bug
There should some space before contact name in contact page
Screenshots
If applicable, add screenshots to help explain your problem.


chore(Algebra/Polynomial): split Eval.lean into smaller files

This PR takes the rather large file Algebra/Polynomial/Eval.lean and splits it into the following smaller files:

Algebra/Polynomial/Eval/Defs.lean: definition of evaluation and bundled homs
Algebra/Polynomial/Eval/Algebra.lean: evaluating where the map is algebraMap
Algebra/Polynomial/Eval/Coeff.lean: eval and coeff
Algebra/Polynomial/Eval/Degree.lean: eval and degree
Algebra/Polynomial/Eval/Irreducible.lean: eval and Irreducible
Algebra/Polynomial/Eval/SMul.lean: eval and the module structure on Polynomial
Algebra/Polynomial/Eval/Subring.lean: eval into a subring

maintainer merge

Thanks :tada:
bors merge

Merge conflict :(
bors r-

bors r+
bors d+


ease adoption by enterprises

WTFPL shows “lack of warranty disclaimer, very vague rights grant”, according to Google’s recommendation for employee contributors, https://opensource.google.com/docs/thirdparty/licenses/#wtfpl-not-allowed
I wonder if MIT or another top-5 OSI approved license could help in adopting this npm module by enterprises?

@domenic - Possible to dual-license this with MIT?

Closed by https://github.com/jsdom/html-encoding-sniffer/commit/c00f49918dbdee96b5fae8db2d5a91453db76d12


Remove extra dataframe_accessor's where a series_accessor already exists

see #148

Okay, this is not a solution.


Doesn't seem to work with wasm32-unknown-unknown

I tried to use scc for a crate that we compile to wasm32-unknown-unknown. I tried to use a HashIndex as a static item and while it compiles just fine, it crashes at runtime if I try to insert an item.
Here's what I did:
static HASH_INDEX: Lazy<HashIndex<u32, u32>> = Lazy::new(|| HashIndex::default());

#[wasm_bindgen)]
pub fn some_fn() -> Result<...> {
  HASH_INDEX.insert(1, 2)?;
}

It then crashes at runtime with the following error:
panicked at .../.cargo/registry/src/index.crates.io-6f17d22bba15001f/scc-2.0.4/src/hash_table/bucket_array.rs:55:13:
assertion `left == right` failed
  left: 16
 right: 0

Here's where it throws:

Any idea what could be causing this?

Oh yea, that is very good point indeed. The alignment is prolly wrong.

Hi, thanks for reporting this issue!
The alignment is definitely different from the actual alignment, but that is intended; if the alignment is above a certain threshold (~4?), alloc_zeroed becomes awfully slow due to a call to memset, otherwise alloc_zeroed is simply translated into calloc which takes full advantage of demand paging.
I think the problem is related to warm32 because this crate has never been tested on a 32-bit machine.
I'll try to fix it on this weekend!

Reproduced the issue and fixed it.
Cause: the size of the Bucket struct is no longer a power of two in a 32-bit binary.
I'll cleanup the change, add more tests, and then upload SCC 2.0.5 soon.

The commit message is wrong, but the issue was fixed in https://github.com/wvwwvwwv/scalable-concurrent-containers/commit/33e4fc5e90ed3313dafeea9c3863724ac57e3ac7

Fixed in 2.0.5!
-> Theoretically, everything shall work as expected in a 32-bit binary.
-> If you find anything unexpected, please open a new issue, or reopen this one in case it's related to this.

Oh wow, thanks so much for that insanely fast turnaround! I really appreciate it 🙏


Requesting review and integration of PR for DYNP token

Hi,
I think I've done my part in following the prescribed process to properly implement  changes to add our token. I've made sure that the tests pass, etc. However, I'm unsure as to how to get attention to my changes from the MetaMask team. Because only people with white access can approve the review and integrate the changes, that creates somewhat of a bottleneck with the token addition process. I'm asking for your help to get the code review completed so our changes can be integrated.
Thanks,

DJ

I understand that MetaMask are only considering integrations for tokens that meet a number if key critera. Not just being verified on etherscan and having at least a "neutral" rating, but also the token should show demonstrable trading activity.
So if you're like me and you thought you did all the right things and are "preemptively" trying to get your token to appear in MetaMask, my advice is to wait until your token is getting adopted because MetaMask will not integrate your changes, even though they meet all other criteria.
Therefore I'm closing this issue until we meet all the criteria.


Updated the readme file

This PR fixes - #111

/ok-to-test

@AryanSharma9917  squash multiple commits into one.

/lgtm we can get this merged, the blockers for this PR are getting resolved in #152

/lgtm
we can get this merged, the blockers for this PR are getting resolved in #152

/approve


Ensures cursor visible for Tree with title

Takes title height and  top/bottom margins into account when calculating desired scroll offset

Before this fix, there are two issues when scrolling a Tree by moving the cursor with arrow keys:

With or without title: scrolling to the last item still leaves a little gap in the scroll bar

Because top/bottom margins are not taken into account

With title: when scrolling up, the first item will be hidden by the column title

Because the title height is not taken into account

In this GIF, I'm pressing up and down arrows until it reaches the end:

The sample project used in the GIF: TreeHScroll.zip

Thanks!


Remove/Reword code-checker parts

related: https://github.com/kodadot/ops-internal/issues/1774
Some checkers are probably unrelated since we changed how the capture service works.

"Not Using WebGL" (now we can capture it, so it is safe to remove. Or is there any concern related to WebGL?)
"Art Is Consistent" & "Automatic Sizing - Responsiveness" (need manual review for these? Maybe use gray question mark icon instead?)
"Variation loading time < 3 seconds" (should we adjust this? since we already have an art that > 3s. less than 30s should be fine, I think)

wdyt? @ThomasssArt @JustLuuuu
cc @kodadot/internal-dev

"Variation loading time < 3 seconds"  - I still want to focus on art that doesn't need much to render; animations and infinite loops can be allowed. Once in a while we do an exception with art that needs more time to load, but I would keep this more as an exception

Automatic sizing: I dont know if this is really needed. It only checks if resizeCanvas() was used in the code right? Many artists are using different resizing methods.

WEBGL: Yes i guess thats not needed anymore.

Variation loading time < 3 seconds: What if we replace adjustment time < 3s with "adjustment time" and thats it. If it fails we can check it and decide if it is ok or not.