Issues with MVVM Implementation

Hi,
I'm trying to wrap my head around the MVVM approach and found an issue which prevents me to use a ViewLocator (IDataTemplate interface).
Setting the ContentTemplateResourceKey does not work when:

the resource is defined in the App.xaml or any other Resource dictionary in the control hierarchy up. Expected behavior would be to search all merged resource dictionaries to find the template.
the resource is an IDataTemplate (view locator), it doesn't work as it expects an Avalonia Control instead. I guess the Method here https://github.com/npolyak/NP.Ava.UniDock/blob/ab64223943108199148d62f094fa9e4688d1eb3c/src/IDockGroup.cs#L362 should also handle IDataTemplate

Regards,
Stefan

Can you publish in a public repository on Github a sample you want to work and I'll try to make it work on Sunday?
I do not quite understand what you want to do here.
Regards,
Nick

I just submitted 2 PRs which changes the code in a way that it works with DataTemplates and IDataTemplate as well. The original DataContextSample still works (haven't tested all the other solutions though).
Btw., may I ask why you chose to split all the packages in multiple repos with submodules? Having a single repo with multiple projects/solutions/packages would be much more community friendly in terms of contributing PRs and building from source. I'm very open to help improving the codebase and a simpler solution/project structure would be very helpful.

Btw., may I ask why you chose to split all the packages in multiple repos with submodules? Having a single repo with multiple projects/solutions/packages would be much more community friendly in terms of contributing PRs and building from source. I'm very open to help improving the codebase and a simpler solution/project structure would be very helpful.

Because submodules is the best way to actually share the functionality in git.
NP.Ava.Visuals - can be used by other projects than NP.Ava.UniDock so there is no reason for them to be mixed together. On top of that non-visual functionality can be used even without Avalonia - there is no reason to require those who use it to depend on UniDock, Visuals and the whole Avalonia package.

I just submitted 2 PRs which changes the code in a way that it works with DataTemplates and IDataTemplate as well. The original DataContextSample still works (haven't tested all the other solutions though).

I saw only 1 PR, btw

Hi Nick,
you can see both PRs linked in this issue above:

The PR in this repo (UniDock) is merged already but the one in the Visuals repo is not yet:
https://github.com/npolyak/NP.Ava.Visuals/pull/1

Because submodules is the best way to actually split and share the functionality in git. Submodules is the best way to make people think about where the functionality actually belongs and figure out the project dependencies. NP.Ava.Visuals - can be used by other projects than NP.Ava.UniDock so there is no reason for them to be mixed together.

Well, I'm also using submodules and there are good use cases. The organization in git repos (using submodules) and the way packages are created doesn't necessary need to mirror the same structure. You can have one git repo containing one or more solutions with many projects all creating and pushing their own, dedicated nuget packages.
From the "consumer" point of view, it's great the way it is and should stay that way. The packages and their dependencies stays the same and everyone can pick and choose what to use.
From the "maintenance" point of view a single repo would make it easier to clone, change and submit PRs. Cloning a repo, opening a solution (preferably in the /src root), hit compile, test, create packages, test the implementation would be much easier.
Right now, I have to fork, clone, branch and submit PRs in every single repo to fully maintain the project. I then also need create the packages locally from different repos to test the implementation before submitting PRs. My change "only" affected 2 repositories, so I needed to submit two dedicated PRs after I forked the two repos. I can imagine that this also gets harder if more people are submitting PRs. Having a lot of different branches scattered in multiple repos will get overwhelming fast, I guess. The more repos are involved the more cumbersome the PRs become.
Anyway, it was only a suggestion and I don't really know all the reasons you chose this structure. I can live with that. If you reconsider to consolidate the submodules into a single repo (or fewer repos), I'm also happy to help.
Again, thanks for the great work and for merging my PR. It helps a lot with MVVM!

Well, especially if there are many people work on a project (and I hope you and other people will chime it) from my point of view it is better to make it more difficult to modify the projects that other projects depend on. Even for myself - after taking several months of breaks the structure helps me to avoid some errors e.g. forgetting to create new package versions when a project was modified.
To make it plainer when several people are working on a code - it makes it more difficult to mess things up by making people thing about the dependencies, though also makes it more difficult to update projects.
You do not have to clone every SubModule - all you have to do is to use
git submodule update --init

and
git submodule update

commands.

I am looking at your other questions - as far as I remember DockItemsViewModel was used only for serialization, not for bindings, but by the end of my day - I'll tell you for sure if it should be made XAML bindable or not.
Thanks for your paticipation!

Well, especially if there are many people work on a project (and I hope you and other people will chime it) from my point of view it is better to make it more difficult to modify the projects that other projects depend on. Even for myself - after taking several months long break the structure helps me to avoid some errors e.g. forgetting to create new package versions when a project was modified.
To make it plainer when several people are working on a code - it makes it more difficult to mess things up by making people thing about the dependencies, though also makes it more difficult to update projects.
You do not have to clone every SubModule - all you have to do is to use
git submodule update --init

and
git submodule update

commands.

I guess you are not creating PRs yourself for the code changes, right? I can understand your argument working on the code base solo. Pushing changes direct to the repos (without PRs), you are right and you only need the submodules initialized and updated.
However, working with the PR workflow, this doesn't suffice. In order to create a PR on github, you first need to fork a repo, create a feature or bugfix branch, make the changes on the forked repo and push it into the forked repo first. Then you create a PR. So far so good.
The problem with the submodules is that all the submodules of the forked version are still pointing to the original github repos. Which means, I can't simply update code in those submodules because they are not the forked repos.
So right now, I have to change the code in the forked version but if I touched code in one of the submodules, I have to fork and clone these repos as well in order to create a clean PR.
I'm not sure if I explained the issue good enough as english is not first language but working clean PRs is very cumbersome in the current structure. Besides, PRs, code review and approval is actually the tool of choice to ensure that somebody doesn't mess up.
Practicle example: my two separate PRs in different repos actually led you to believe that there's only one PR and you actually didn't see the other PR from the other repo. The danger to mess something up in this structure is actually much higher. I haven't really tested if the changes I made worked with only one PR merged but chances are, that the incomplete approval of the PRs actually broke the packages.
Also, from a testing perspective let me mention that a single repo would make it quite easy to verify if a PR is breaking something or not because you only need to pull the PR's branch instead of all the involved github modules and make sure that the referenced submodules (which are not pointing to the correct branch) are not mistakenly used.
Take a look at the Avalonia repo itself. It's a huge repo but it's a single repo although multiple packages are created from it and the way PRs are verified and approved is actually working great to ensure high quality code contributions.

One more thing: since I'm not sure I was able to explain myself well, I recommend you try the PR workflow yourself by creating a second github account, try to change something which affects more than 2 repos and try to make code changes on a clean machine which only works with the forked repos. If you do this exercise, you will see what I mean with the complicated workflow ;)

I understand. You are correct I am not forking my own repos and I am not creating PRs for myself.
I'll try next Sunday and will see what can be done to improve the workflow.

Instead of forking repositories - can you create a branch check it out and do the same for the submodules.
At least this is what I want the workflow to be for other people interested. So if it is not possible now, perhaps I can try to fix the permissions to make it possible.

I strongly recommend to use the PR workflow instead of pushing changes directly to the repo. Pushing directly to the repo is far more dangerous (and not really considered best practice) than using the PR workflow.
As the owner of the repo you can still push directly (I do that too for my repos) but at the same time allow others to contribute in a clean and secure way. So to clarify: the "test" I recommended for you to try the PR workflow was not saying you should always use PRs for your own changes - just to try it out to see what contributors should/need to do to submit code.
Besides, you could, of course create PRs directly on your repo as an owner if you like.

I am not talking about not doing PRs. Of course the commits should be merged to the main branch via PRs.
I am talking only about not using the forks. Instead of creating a fork, you clone the original repository, then create your own branch. Then commit your own branch and create a PR to the main branch.
This is how it worked in many of my contracts and I do not see why it should not work now.

This would require you to allow everyone to push to your repo. This may be a viable solution for contract work with a limited number of contributors but for open source repos it's quite uncommon and surely not best practice. Not sure if you really want to do this ;)
But yeah, if that's your choice, no problem. Still, considering that pushing code changes which also affects one or more submodules, needs careful consideration with consistent branch names (across all repos) and the danger (like in my case) that PRs only get partially approved because changes from other repos may be overlooked.

We'll start with this strategy and if it does not work - we'll change it.
a repository can definitely handle 25 people pushing their work in it and the main branches will be clean because of my supervision of the PRs. If we see some downside to it in the future - perhaps we'll do smth more radical.

Fair enough! I will close this one now because the PRs were merged. Will continue to work with the packages and may submit other PRs down the road. Thanks for the discussion, insights and your work. I really appreciate it!

Thanks Stefan, I also appreciate you joining the effort!

I added firing PropertyChanged event to some of the DockItemsViewModelBase. The properties should not change for the life duration of the object.

@StefanKoell I added you as a collaborator to 5 of my repositories including the main one NP.Ava.UniDock. The main branches in each one is protected. So you do not have to use forks - you can check out the NP.Ava.UniDock repository, initialize the submodules, do changes in your own branches and create the pull requests.

Accepted all the invitations. Thank you!


How to add dependence to static library in binding.gyp?

I did not find in the documentation how to add static library to binding.gyp?
I've successfully compiled my node.js extension with reference to the shared library as follows:
    {
      "targets": [
        {
          "target_name": "myext",
          "sources": [
            "code/main.cpp",
            "code/load.cpp",
            "include/load.h"
          ],
          "include_dirs": [
            "include", "../Library/include"
          ],
          "libraries": [
            "-lmylib", "-L/home/admin/MyLib/Library/binaries/linux/Release"
          ],
          "cflags!": [ "-fno-exceptions" ],
          "cflags": [ "-std=c++11" ],
          "cflags_cc!": [ "-fno-exceptions" ]
        }
      ]
    }

and now want to add static version of the library to the extension to avoid libray loading issues. Is this possible?
Thanks!

Thank you for your answer @TooTallNate . It's really helpful.

@Vimos , you can write like this: "libraries": [ "-Wl,-rpath, mylib.a" ] . This can work.

if i want to link shared library then i need to just replace .a with .so or anything else do i need to do?

@Embedded4development 'libraries': ['-L/path/to/dir', '-lfoo'] if the shared object is called libfoo.so.  The -L switch is only necessary when it's not in a standard location.  You may also want to pass -Wl,-rpath in that case.

@bnoordhuis
if i have multiple libraries then what would be perfect syntax to map library name & respective path?

@Embedded4development 'libraries': ['-lfoo', '-lbar', '-lbaz'] - add search directories and rpaths if necessary.

@bnoordhuis Thanks for useful response..

I am compiling on Windows and as I saw the file get's compiled but the static library is not embedded on the code, is there a way for the generated .node file to have the static library embbedded on it's code? So that the client does not need to have a dll.

@drFabio If you have a dll, it's not a static library.

@bnoordhuis  I have a .lib but the generated .node file when inspected with dependency worker says it's needing the dll.
It compiles without error , but when in use on the windows machine if the user does not have a registered dll it does not work.

@drFabio Where does the lib file come from?  Who or what produces it?

It is libeay32.lib I use the lib that comes from the installer in from
http://slproweb.com/products/Win32OpenSSL.html that is recommended on
https://github.com/nodejs/node-gyp/wiki/Linking-to-OpenSSL
On Aug 3, 2016 5:00 PM, "Ben Noordhuis"<EMAIL_ADDRESS>wrote:

@drFabio https://github.com/drFabio Where does the lib file come from?
Who or what produces it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node-gyp/issues/328#issuecomment-237353921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACg5b6ZThBFR7MT4WMwVc7h2n334ZmVHks5qcPNjgaJpZM4A_W2w
.

At a guess, it sounds like the lib file is just glue code for the dll.  In that case you're SOL.

This whole time I was assuming this was node-gyp default behaviour.
Everything makes sense now. Thanks a ton!
On Aug 3, 2016 5:53 PM, "Ben Noordhuis"<EMAIL_ADDRESS>wrote:

At a guess, it sounds like the lib file is just glue code for the dll. In
that case you're SOL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node-gyp/issues/328#issuecomment-237369801,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACg5b-g9AA45KyRNgHuRWyMhlkAHEFupks5qcP-7gaJpZM4A_W2w
.

How to add dependence of shared_library in binding.gyp?
I have .node file of my C++ project and I want to refer this .node file in its Unit test project.
But I am unable to link .node/ .dll file in binding.gyp file of my Unit Test project.
If I build my C++ project with static library, I am able to execute my unit tests sucessfully.

Instead of
"libraries": ["-lmylib", "-L/home/admin/MyLib/Library/binaries/linux/Release"]
you could say
"libraries": ["-lmylib", "-L'<!(pwd)'"]
assuming your libmylib.so file is in the same directory as binding.gyp.

For making the path relative, just use module_root_dir, which is a variable exposed by node-gyp.
"libraries": ["<(module_root_dir)/......"]

-Wl,-rpath,... did not work for me, causing symbol lookup errors.

What is wrong in below code? It is throwing linking error.
'targets': [
{
'target_name': 'abc',
'type': 'shared_library',
'conditions': [],
'dependencies': [],
'libraries':[
'mylib.a'
],
'mac_framework_dirs' : [
],
'all_dependent_settings': {},
},

Just specify the path the to the static .a file in the "libraries" section:
  "libraries": [ "/usr/local/lib/mylib.a" ]

Does this make it so in node you can call the function from mylib.a? If so, what would that formatting look like?


how i can disable mobile screen while using on PC?

i want to disable my mobile screen while using it on Windows. how i can do that?

Not implemented yet. See https://github.com/Genymobile/scrcpy/issues/175#issuecomment-473412085.

Implemented on dev by 12a3bb25d39037931f577dc0165b3e517aad92df.


[Bug]:  On importing json, table data does not reflect

Is there an existing issue for this?

[X] I have searched the existing issues

Description
On importing json, table data does not reflect. To reflect the table data we need to rerun the query
Steps To Reproduce
Steps :
Export a set which has 1 db, 1 jDb query, 1 table widget>
deployed the app then export
Import this set to a fresh page in the same app above set gets successfully imported with empty table.
Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Appsmith v1.9.51-SNAPSHOT

Might be relates to our fix in /partial/block API.
If we switch to that API, this problem should not exist.


Fix Analyzer#average_age_for test.

Merging despite failing test because it's already failing on master.


remove TextField and replace with Button for improved UX

This changes the 'Create A Post' prompt from a TextField to a Button.
When I first went to create a new post on the home page, I expected to be able to type into the TextField to create a post. I was confused when I was re-routed to a different page. I think it might be a little clearer if the TextField was changed to a button for a less confusing UX. Feel free to do what you want with the code/suggestion :)

Good suggestion!


Changing zones causes incorrect values

I have consistently noticed that values stop being correct after leaving whatever zone I spawn in. It seems to be overwriting the monster's stats with the data of a small monster, but I'm not 100% sure on this.
Here's screenshots of the GR2 Farunokku. The first is an example of what the overlay looks like when I spawn in camp, the second is how it looks like after leaving.

Does this issue still occur with the latest version? Does it occur with non-High Grade Edition?

Does this issue still occur with the latest version? Does it occur with non-High Grade Edition?

Tested on 0.15.0
Non-high grade: Issue does not occur
High grade: Issue still occurs, but I was able to reach the monster and engage it before the issue occurred. It did not happen as it previous did, immediately upon the first zone transition.


[feature] Add autocompletion for packages from PYPI and command line option from pip

Like https://github.com/neoclide/coc.nvim/wiki/Create-custom-source, but I don't know how to get package names from PYPI :smile:

Fixed.


Issue to trigger new releases

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/73061
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" 29cc117d4e68334ba7dce8a34ab0ce39da5f3700
git push origin v0.1.1

@JuliaRegistrator register branch=master
Release notes:

Add tests to fit and predict that include the keyword option rows=..., including rows=:

Registration pull request created: JuliaRegistries/General/77328
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 12dd6ace03d589911b63a9604dc23d51c2a34bd9
git push origin v0.2.0

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/82333
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.1 -m "<description of version>" ad3d704d9d15850cb620fdb2184c0ad69170caaa
git push origin v0.2.1

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/88971
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.2 -m "<description of version>" 39862a3e30bad2adc8375a9b52dffa296316421c
git push origin v0.2.2

@JuliaRegistrator register branch=master
Release notes:

Ensure that transform is tested for all Static models.

Registration pull request created: JuliaRegistries/General/92577
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.3 -m "<description of version>" 3bc4425d61798df2cec959242e5dc4b9b527b1a2
git push origin v0.2.3

Registration pull request created: JuliaRegistries/General/98243
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.4 -m "<description of version>" 65facf92de22d1aa255a38c22030b405a57fe65e
git push origin v0.2.4

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/98510
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.5 -m "<description of version>" 8bd5093fb3d34d72c91805875253e340e25c5538
git push origin v0.2.5

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/101009
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.6 -m "<description of version>" 9a7d4a1f69436cba2e4c29e7573eb42bfbd3e20c
git push origin v0.2.6

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/120475
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.7 -m "<description of version>" 75eaeeabaf58d46bf2a895a5a0f34941fe3737d9
git push origin v0.2.7

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/121590
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.8 -m "<description of version>" 7bd76d2b3b8bbfff718c2b9f3150ed30900fed65
git push origin v0.2.8


luci needs some layout love for mobile

Tried fixing a few things on my mobile recently - which is a nice capability. Can this be fixed?
Make the display-layout as big as the text, even if it's bigger than the view port.

@vgaetera maybe you have some idea about this one?


Refactor spends

This is a re-write of the submit_spends method for submitting spend bundles to mempool. major changes are:

functionality to retry on error up to some number of max retries
dynamically alters fees to access mempool when it's full
checks for the last spend being confirmed on restart
checks for txns getting kicked from mempool and resubmits them (not well tested)

@geoffwalmsley looks like lint is failing, can you review pls

🥳


Think about a way to convert IArrayMemory into IDirectMemory

https://stackoverflow.com/questions/15200741/how-to-make-a-variable-fixed-permanently-in-c/15201094 this could be a solution.

https://docs.microsoft.com/en-us/dotnet/api/system.memory-1?view=net-5.0 another pinnable memory block implementation


Write docu how to use LineUp

[ ] including a list of included features (library, and lineup app separated)
[ ] column types
[ ] screencast showing the most important features

https://lineup.js.org/getting-started


Added a new route /project/users/new to add a new user to the DB, fix broken route

Add a new route to add new users
POST /project/users/new with the following keys in the JSON payload object

'NetId' -> String containing the netID for the user (uniquely identifies a user)
'isTA' -> Integer either 0 (not a TA) or 1 (is a TA)
'FirstName' -> String for the first name
'LastName' -> String for the last name

Fix HTTP 500 errors for /project/users/

TODO: fix SpecificUserView

Adam approved my code over Facebook Messenger


Semicolon not escaped in docker::run generated systemd configuration

While setting up a docker container with traefik i noticed that a label containing a ';' did break the ExecStart command in the systemd unit file.
I worked around this problem by replacing ';' with '\x3b' in the string.
May be option strings should be escaped with systemd-escape:
$ systemd-escape 'Host:bla;Path=/zumsel'
Host:bla\x3bPath\x3d-zumsel

env variables defined for ::run are also not escaped in /etc/init.d/docker-servicename


Update getting_help.md

@aubertc
I'm sorry this took so long! I thought I had done this last week, but I made a mistake with the submission.

That's perfect, except that you edited an outdated version of this document (this is my fault, I made some edits concurrently…). So, I cannot accept your pull request as is.
Could you do another one, starting from the document as it currently is, please? Thanks! @LaylaErb
Simply add your info, and I'll accept it.


Python: deterministic interpreters

Motivation for this change

Reproducible builds of the interpreters

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Python 3.5 diff https://gist.github.com/anonymous/7cc147af6511dee2dc5a5b8d110f0e6b

Python 3 uses sets a lot in its implementation. Sets don't maintain order, so when bytecode is generated the generated bytecode won't be deterministic.

Since 3.2.3 there is a PYTHONHASHSEED env var.

If this variable is not set or set to random, a random value is used to seed the hashes of str, bytes and datetime objects

It also influences sets. When doing a 'x in {'a', 'b', 'c'}the set is converted to afrozenset. If PYTHONHASHSEED` is set to 0, then no hashing is done and the order should be preserved (even though sets have no order).
Unfortunately, the bytecode is still not deterministic.

At the end of the installation I know force it to rebuild all bytecode. Both 2.7 and 3.5 are now deterministic.
cc @edanaher could you check regarding your issue?

Looks good to me; nvr is nice and fast, and there's only a single EROFS:
[nix-shell:~/nixpkgs]$ strace nvr  2>&1 | grep EROFS
open("/nix/store/33mqlj6pchixmkraylrxm22zia5ji0sc-python3-3.5.2/lib/python3.5/__pycache__/_sysconfigdata.cpython-35.pyc.140390896732008", O_WRONLY|O_CREAT|O_EXCL|O_CLOEXEC, 0644) = -1 EROFS (Read-only file system)

I still find it a little strange that that file is still attempting to be re-cached, but it's not a significant performance issue.  If you're not seeing determinism issues with it, I certainly don't see any problem.

@edanaher I'll have a look at the sysconfigdata issue. For some reason it was removed, and I don't know why.

Versions 2.7, 3.5 and 3.6 are now reproducible. I've applied the patches to 3.4 as well but there's one file left causing problems. I've updated the docs and the release notes. The issue with sysconfigdata I keep for later.
I think this is ready now. What say you?

@globin its not clear to me what you mean but we can fix that later.

@FRidh: this or something else new on staging has broken 3.4 setuptools:
ImportError: No module named 'pyexpat'

Example: http://hydra.nixos.org/build/49482784

Thanks @vcunat , I'll have a look at it later today.

Python 3.4 is fixed with https://github.com/NixOS/nixpkgs/commit/b588ed95b9a2705a8500d1c5d21d33ab3a5e7971

@vcunat am I correct none of this is in 17.03?

Python 3.6 is fixed with https://github.com/NixOS/nixpkgs/commit/a1f6b8b5fc3c76d679064208aee228a051280f33
Now I'm sure they're all ok.

@FRidh: this PR is in 17.03.  I pushed it in response to your comment.

When rereading it, I probably misunderstood you and just cherry-picked the whole merge, but I suppose it will be OK if we pick these fixes as well?

I saw only the merge and none of the commits in 17.03, so that's why I was asking.
Yes, all these commits plus the two fix commits can go in.

For reference, the 17.03 commit: bee78540.  I don't know why GitHub doesn't display a mention on this PR – I think it does, normally.

I picked those two commits and tested they fix the builds.


[VIEW] Notice: Undefined Offset SSViewer:1066 (edge case)

Steps to reproduce:

Use $this->renderWith("ThisTemplateDoesntExist") within a class that extends \Page_Controller

Will occur when a template cannot be found in the theme directory with renderWith()
$template = $this->chosenTemplates[$key];

to
if (!($template = (isset($this->chosenTemplates[$key])) ? $this->chosenTemplates[$key] : FALSE)) {
    throw new SomeRelevantException();
}

I would try to validate if this issue is still present in SS4, but I don't think there's enough details here for me to go on.
Unfortunately, Silverstripe CMS 3 has entered limited support in June 2018. This means we'll only be fixing critical bugs and security issues for Silverstripe CMS 3 going forward.
You can read the Silverstripe CMS Roadmap for more information on our support commitments.
If you can still reproduce this issue in SS4, could leave some replications steps and I'll reopen.


Playsong won't search my song

Hello, I'm uncertain as to why things aren't functioning as anticipated. Every time I attempt to play a song, the desired track isn't displayed in the results.

@tujuhtigatujuh I'm sorry to hear the workflow isn't working for you, and I want to help—I just need to know a few more details:

What are you seeing instead of the desired song result? Does Alfred say "No Results Found", or are you seeing the fallback searches like "Google"? Or are you seeing no Alfred results for anything at all?
What system language do you have set?
What version of macOS are you using?

No results found
English (US)
14.0

Sent via Superhuman iOS ( @.*** )
On Fri, Oct 6 2023 at 10:57 AM, Caleb Evans < @.*** > wrote:

@tujuhtigatujuh ( https://github.com/tujuhtigatujuh ) I'm sorry to hear the
workflow isn't working for you, and I want to help—I just need to know a
few more details:

What are you seeing instead of the desired song result? Does Alfred say
"No Results Found", or are you seeing the fallback searches like "Google"?
Or are you seeing no Alfred results for anything at all?
What system language do you have set?
What version of macOS are you using?

—
Reply to this email directly, view it on GitHub (
https://github.com/caleb531/play-song/issues/69#issuecomment-1749949312 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AP6YM3CN33MSP26MM3ELNWLX556SNAVCNFSM6AAAAAA5VGG5RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZHE2DSMZRGI
).
You are receiving this because you were mentioned. Message ID: <caleb531/play-song/issues/69/1749949312
@ github. com>

I've discovered something; it only plays songs that are already in my library. It doesn't play any songs that haven't been added to my library yet. I believe it would be better if it could play any song, regardless of whether it's already in my library or not.

@tujuhtigatujuh Yes, the workflow can only play music that you've already added to your library. The only exception is if the songs are part of an Apple Music playlist in your library (in which the playlist entry itself would be part of your library, but the individual songs don't have to be). In this case, you could use the playplaylist keyword to play the playlist.
I've explored adding the ability to play songs outside your library, but it would require Objective C / Swift to accomplish, which is really outside of my experience. So, at least for the time being, this is not something I intend to implement.

I see, thanks!
Sent via Superhuman iOS ( @.*** )
On Sat, Oct 7 2023 at 11:29 PM, Caleb Evans < @.*** > wrote:

@tujuhtigatujuh ( https://github.com/tujuhtigatujuh ) Yes, the workflow can
only play music that you've already added to your library. The only
exception is if the songs are part of an Apple Music playlist in your
library (in which the playlist entry itself would be part of your library,
but the individual songs don't have to be). In this case, you could use
the playplaylist keyword to play the playlist.
I've explored adding the ability to play songs outside your library, but
it would require Objective C / Swift to accomplish, which is really
outside of my experience. So, at least for the time being, this is not
something I intend to implement.
—
Reply to this email directly, view it on GitHub (
https://github.com/caleb531/play-song/issues/69#issuecomment-1751753069 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AP6YM3HH4Z35HYXPBKXJF4TX6F7OJAVCNFSM6AAAAAA5VGG5RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRG42TGMBWHE
).
You are receiving this because you were mentioned. Message ID: <caleb531/play-song/issues/69/1751753069
@ github. com>


Emulator

Will you release an Emu for this?

Emulator? what are you talking about? This project is a server/client implementation for Slither.io, Meaning you can make your own private server.

This is only to play on the original website?  I cant host my own wesite?

@ElMay0r You can connect to the server with the original website.

It would be nice if you can host your own webiste like Cigar (agario)

@ElMay0r It would be, But that's illegal..

What kind of law are you talking about? I'm from Ukraine)


Error submitting a packet to the muxer: Error number -10053 occurred

hello, I encountered an Error submitting a packet to the muxer after five minutes of forwarding an rtsp stream to websocket using WebSocket-Relay. Error number -10053 occurred, but I can use VLC to play rtsp stream without such problems, can you help me?

hello, I encountered an Error submitting a packet to the muxer after five minutes of forwarding an rtsp stream to websocket using WebSocket-Relay. Error number -10053 occurred, but I can use VLC to play rtsp stream without such problems, can you help me?

My rtsp stream is nonstop streaming provided by a single camera


Change Dummy Credit Cards plugin configuration to operate on 4 last digits

I want to merge this change because it port changes from 3.0 to 3.1
3.0 PR https://github.com/saleor/saleor/pull/8494

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4656 Dummy payment shouldn't use credit card numbers

mjd
-----Original Message-----
From: "codecov[bot]" @.>
Sent: 03/11/2021 07:30
To: "saleor/saleor" @.>
Cc: "Subscribed" @.***>
Subject: Re: [saleor/saleor] Change Dummy Credit Cards plugin configuration tooperate on 4 last digits (PR #8498)
Codecov Report
Merging #8498 (321661c) into main (e609834) will not change coverage.
The diff coverage is 100.00%.
@@           Coverage Diff           @@
main    #8498   +/-
=======================================
Coverage   93.05%   93.05%
=======================================
Files         495      495
Lines       37809    37809
Branches     4316     4316
=======================================
Hits        35184    35184
Misses       1768     1768
Partials      857      857           Impacted FilesCoverage Δ
...eor/payment/gateways/dummy_credit_card/init.py88.67% <100.00%> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e609834...321661c. Read the comment docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Duplicate Code in peek in Stack.js

I'd of thought you'd do it like -
  peek() {
    if (this.isEmpty()) {
      return null;
    }
    return this.linkedList.tail.value;
}

Thank you! I've just fixed that.


phaser3 memory leak issue (all resources type)

Version

Phaser Version: 3.22.0 & 3.50.0

Operating system: macos catalina 10.15.7

Browser: chrome Version 87.0.4280.88 (Official Build) (x86_64)

Description

There is a problem with all resources load, the memory usage too high, and no release when switch scene.
In my game, I have many images/audios (total 250MB), but memory usage 3GB...
I think this problem relate https://github.com/photonstorm/phaser/issues/5224
Example Test Code
I write a test code, just load same image url 1000 times(diff key),
-> then textures.remove(key) remove all keys
-> then switch to next scene
-> the memory no release (memory usage from 40MB to 464MB).
test url: https://justintien.github.io/phaser3_memory_leak_test/
source code: https://github.com/justintien/phaser3_memory_leak_test

This issue has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/phaser3-memory-leak-issue/8423/1

This issue has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/debugging-high-memory-usage/8161/2

Just want to confirm that we've been experiencing the same thing (we're on 3.24.1 at the moment). Safari regularly piles up memory until it resprings, then memory piles up and it resprings again, etc. I think it's probably an Apple bug, but there might be something Phaser is doing that's tickling it in the wrong way - it would be interesting if we figure out what, it might just be something really small somewhere.

Have been fixing an issue with a storybook application (pretty much an image flipbook) which was running out of memory on load on a Kindle Fire 2017.
I implemented load / unload of textures on each page flip and it then loaded ok but crashed at page 30. Forcing Canvas however and it now works fine when combined with loading / unloading on demand.
This potentially points the finger at webgl not releasing textures?

Have been fixing an issue with a storybook application (pretty much an image flipbook) which was running out of memory on load on a Kindle Fire 2017.
I implemented load / unload of textures on each page flip and it then loaded ok but crashed at page 30. Forcing Canvas however and it now works fine when combined with loading / unloading on demand.
This potentially points the finger at webgl not releasing textures?

Not necessarily I'm afraid. WebGL will use more memory than canvas just by virtue of having to create all the gl textures (as well as loading the images), so it's possible it just ran out by that point. When a texture is deleted by the Texture Manager it is passed to the renderer to delete the gl texture too. Perhaps this process needs trapping to ensure it is actually removed. Although I suspect the issue is elsewhere personally.

Not necessarily I'm afraid. WebGL will use more memory than canvas just by virtue of having to create all the gl textures (as well as loading the images), so it's possible it just ran out by that point. When a texture is deleted by the Texture Manager it is passed to the renderer to delete the gl texture too. Perhaps this process needs trapping to ensure it is actually removed. Although I suspect the issue is elsewhere personally.

This is either Mac, or Audio, specific. Because with the given test (https://justintien.github.io/phaser3_memory_leak_test/) I cannot see any memory retention at all in Chrome Canary on Windows. How exactly are you monitoring the memory use?

Not sure if that's a question for the OP but in our case:
We were testing on Kindle 2017 Silk browser which actually has a crash in the tab (not a js crash, the whole tab errors) if you load too many things in. Loading and unloading as we go using
scene.textures.remove(...)
scene.textures.removeKey(..);

This does not work in webgl mode (eventually crashes after loading too many textures) but does work in canvas mode.
I realise it's not exactly scientific using the Silk Broswer to check if a memory limit has been his mind.

@photonstorm
I added audio test:
(In fact, I found the reason, about audio only memory leak when use web audio, html5 audio no leak when remove cache.)
web audio: https://justintien.github.io/phaser3_memory_leak_test/audio
html5 audio: https://justintien.github.io/phaser3_memory_leak_test/audio-disableWebAudio

This is either Mac, or Audio, specific. Because with the given test (https://justintien.github.io/phaser3_memory_leak_test/) I cannot see any memory retention at all in Chrome Canary on Windows. How exactly are you monitoring the memory use?

Empty phaser3 instance memory < 100MB,
In fact, the texture have release some memory, when added 1000 images -> 450MB -> textures remove all -> 150~250MB
But there is still some occupation left (I don't know who is occupying it)

I've been looking at this a lot this morning and I'm more convinced than ever it's just the browser holding onto those nodes, for reasons best known only to itself.
This is clearly demonstrated by doing the following:
Run your test app (the one with the images, not the audio, that is a different issue) and watch the Chrome Task Manager memory footprint for the tab increase. In my case, it went from 45MB to 312MB when the images had loaded. I then click to the next Scene. The images are definitely gone, they no longer exist in the texture manager and the GL textures have been deleted as well. However, the memory footprint remains unchanged.
Now, do one of two things: Either click the 'Collect garbage' icon in Dev Tools, or tab away from Chrome to another application (i.e. VS Code, like I did) and work there for a few minutes. Both things cause the browser to run a gc collection. Obviously, the icon triggers it immediately and you will see an instant drop in the memory footprint as it purges all of those nodes it was retaining, for reasons best known only to the browser.
This also happens if you tab away from Chrome and use another app. After a while, Chrome will think "Ok, it's safe, let's run a gc sweep now" and memory will drop dramatically. Here you can see the green line (nodes) plummet from 749 down to 249, releasing hundreds of MB of memory at the same time:

This was triggered by me clicking the Collect Garbage icon.
If it was Phaser that wasn't cleaning up memory or references, then clicking this icon would make no difference. However, it makes a massive difference.
In short, given how browsers operate, it's unpractical to expect them to free memory like this, as you demand it. It just doesn't happen that way. It happens when they feel like it, not when you ask them to. You're welcome to research how it may be possible to request a browser triggers gc, but to date, I've not seen any ways to do it. I do wonder if 'pausing' the game may be enough, i.e. literally letting raf idle for a second or so. But that would be quite noticeable in-game and isn't guaranteed either.
I do, however, firmly believe there is an issue with audio memory, so I will look into that as a different matter.

you need to switch scenes frequently, and then you can see the phenomenon of memory skyrocketing

You need to switch scenes frequently, and then you can see the phenomenon of memory skyrocketing

Try to release Phaser.Game textures, sound effects and other resources when switching scenes. This will greatly alleviate the gc problem

As I've demonstrated Phaser will correctly free all references to the resources on its end. Changing Scene won't alter this.

Let me add to this discussion - i have a Safari-specific leak, where safari keeps on piling up Canvases created by RenderTexture (rendermode: CANVAS) - even when these Canvases are destroyed 'through scene switch' (some users seem to be experiencing this). The issue is perfectly described here, along with a fix (a fix which i tried and helped to ameliorate the issue, but not entirely fix it):
https://pqina.nl/blog/total-canvas-memory-use-exceeds-the-maximum-limit/

Under 3.60 RenderTextures no longer create or use Canvas DOM elements at all in WebGL, which will stop the node issues described here (also uses 50% less memory!).
However, we've still no control over when (or if) Safari feels like free-ing up memory or running a gc sweep. Everything is nulled or removed our end, but my suspicion is that because RAF is running and is likely busy running a game (so CPU is high), Safari doesn't consider it a 'safe' time to run a gc, so it just doesn't bother. For a normal web page, you would expect high levels of idle activity, but this just isn't the case for games, so the retention period appears to be significantly longer.
The day we get accurate control over memory / gc will be a day to celebrate. Just don't hold your breath!


Public port displayed in UI points to Docker IP, not Host

In the last version of the UI, the public service port (within a stack) linked to directly to my Host IP (in my case, the IP of the VM e.g. 192.168...).  Now it is pointing to the Docker IP (172.17...), effectively making the link useless.

The links are to the public IP the host is registered with.

If you go to your host page, is the host that the container on showing the DockerIP instead of the hostIP? Your host has registered and picked up the Docker IP instead of the actual IP of the agent.
You'll need to re-register your agent and add the environment variable -e CATTLE_AGENT_IP=<ip> to the rancher/agent command.

You are correct.  I had some automation scripts that were recently updated and broke setting the cattle_agent_ip properly.
Thanks for your help!


Design HTML page according to theme

Add each section for nav item(except github) with their title in index.html file

divide each section in two part (except hero), into title-container and content-container
divide each section into 30:70 ratio
title should be in center of section container
modify style.css file accordingly

Hi  @Saifkhan-rkp ,
I’d like to propose the following updates for the portfolio website:
Divide each section (except Hero) into two parts:
Title-container (centered title).
Content-container (section content).
Adjust the layout to a 30:70 ratio (Title on the left, content on the right).
Please let me know if I have your permission to implement these changes.
Thank you!
Shubham Ghaturle

@Shubhuscode yes sure Shubham i would like to. please make sure you do this in single commit please follow the readme file for contribution. please let me know any support required

@Saifkhan-rkp, the code has already been merged, but the issue is still open. Please close it.

Thanks @Shubhuscode.


highcharts-ng error at highcharts-ng.d.ts

I'm getting an error at line 27 in highcharts-ng/highcharts-ng.d.ts
It should be a semicolon, and not a comma.
I copied the file and change it locally and i can confirm that it is working with semicolon.

@wanwan31 please send a pull request. I'll review it.

Seems like #5665 closes this?


Studio Model Download section

Docs contribution for https://github.com/iterative/studio/issues/7287

Updates some outdated screenshots, adds a new Direct download from Studio section that features some screenshots demo'ing how to download the models directly from Studio.

@jellebouwman I've made minor changes here.

I think we are blocked here for now by https://github.com/iterative/studio/issues/7287, right?

I merged main into this branch. We're almost ready to release this on the Studio side. Just waiting on the following PRs to land and be released to production:

https://github.com/iterative/studio/pull/8237
https://github.com/iterative/studio/pull/8243


Warnings on peer dependencies

It's working good but It has these annoying warning everytime I use pnpm
 WARN  Issues with peer dependencies found
apps/nextjs
└─┬ contentlayer 0.3.2
  └─┬ @contentlayer/cli 0.3.2
    └─┬ @contentlayer/core 0.3.2
      └─┬ @contentlayer/utils 0.3.2
        └─┬ @opentelemetry/exporter-trace-otlp-grpc 0.31.0
          ├─┬ @opentelemetry/core 1.5.0
          │ └── ✕ unmet peer<EMAIL_ADDRESS><1.2.0": found 1.4.1 in @contentlayer/utils
          └─┬ @opentelemetry/otlp-transformer 0.31.0
            ├── ✕ unmet peer<EMAIL_ADDRESS><1.2.0": found 1.4.1 in @contentlayer/utils
            ├─┬ @opentelemetry/resources 1.5.0
            │ └── ✕ unmet peer<EMAIL_ADDRESS><1.2.0": found 1.4.1 in @contentlayer/utils
            └─┬ @opentelemetry/sdk-trace-base 1.5.0
              └── ✕ unmet peer<EMAIL_ADDRESS><1.2.0": found 1.4.1 in @contentlayer/utils

Versions I'm using:
"contentlayer": "^0.3.2",
"next-contentlayer": "^0.3.2",
"next": "^13.3.1",

Hey @pedro757 I am using your exact same package versions, but I have a different problem, are you also using MDX and a few interactive components?

Looks like @contentlayer/utils 0.3.2 didn't pick up the latest @opentelemetry/exporter-trace-otlp-grpc 0.38.0.

I'm having the same issue


Update README

Issue #, if available:
Description of changes: Fixed markdown
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

resolved


feat: Support on_demand_throughput

Description
Support on_demand_throughput.
Motivation and Context
Closes: https://github.com/terraform-aws-modules/terraform-aws-dynamodb-table/issues/89
Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

fixed through the GitHub UI and corrected the pull request settings to avoid similar errors in the future


No longer swallowing errors from block passed to execute

Fixes #309

Please make sure you sign the CLA. See CONTRIBUTING


Docs: Update ft.create docs for Java and Python

Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked:

[ ] This Pull Request is related to one issue.
[ ] Commit message has a detailed description of what changed and why.
[ ] Tests are added or updated.
[ ] CHANGELOG.md and documentation files are updated.
[ ] Destination branch is correct - main or release
[ ] Commits will be squashed upon merging.

183 changed files?

183 changed files?

Sorry. I created the PR against main.
Turns out main and release have diverged by 183 files and counting...


Fix: Solve issue #331 by adding FirstEvent support in FireFly config

This PR addresses issue #331, which was about adding support for the FirstEvent parameter in the FireFly configuration files.
Changes Made:
Added a new FirstEvent field support in the FireFly configuration (firefly_core_*.yml) files to allow specifying the starting event for blockchain-based processes.
Integrated this new parameter into the FireFly configuration logic during the stack initialization process.
Updated the stack setup and blockchain deployment flow to support FirstEvent, ensuring it can be configured when setting up FireFly for the first time.
The FirstEvent field is now configurable in the FireFlyConfig and is passed to the blockchain and smart contract initialization process.
Context and Fix:
The addition of the FirstEvent parameter gives users flexibility in defining which blockchain event the FireFly stack should use when starting up. This was missing in the previous configuration, causing issues for users who needed specific event handling.
This update ensures that FirstEvent is properly handled, stored in the configuration, and used during smart contract and blockchain node setup.
How to Test:
Start the FireFly stack with the new configuration changes.
Verify that the FirstEvent field is correctly passed to the blockchain during FireFly stack initialization.
Ensure that the expected event triggers the FireFly workflow appropriately, depending on the FirstEvent configuration value.
Issue Comment (on issue #331):
I have solved issue #331 by adding support for the FirstEvent parameter in the FireFly configuration. This allows users to specify which event should be used during FireFly stack initialization, enabling more flexible event handling for blockchain-based processes.
The fix is now available in the pull request https://github.com/MKVEERENDRA/firefly-cli1, and it has been tested to ensure the correct configuration of the FirstEvent value during the FireFly setup.

I Fixed it

I did what you said can you pls check out the commit


test(core): add tests

Add unit tests on react-toolkit-core
Bump dependencies for react-toolkit-core

I found an issue in InputManager.getFirstId, it was always returning an empty string. That's why 4 snapshots have been updated.

CI will be fixed by #790


display more stats in the frontend

total received

total spent

tips received

tips claimed

tips unclaimed

users tipped (?)

Participants (eg unique addresses that tipped and or commented)

we can't know how much tips have been received without indexing the contract payout events
we can't know unclaimed tips at all, oracles decide what is claimable and what is not


Add Account Abstraction settings in product settings layout (chakra)

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
The focus of this PR is to rename SponsorshipPolicies to AccountAbstractionSettingsPage and refactor related components for clarity and consistency.
Detailed summary

Renamed SponsorshipPolicies to AccountAbstractionSettingsPage
Refactored components in smart-wallets directory for consistency

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

will be removed in separate PR


Issue #5615 using the express instead of http method

Issue #5615

If you intended this to be a legitimate PR please provide some additional context.


HAWQ-1556. enable ALTER SCHEMA RENAME/OWNER

CI failed with strange error, it seems irrelevant to the pr, is it right?

configure: error: Please install apr from http://apr.apache.org/ and add dir of 'apr-1-config' to env variable '/Users/travis/.rvm/gems/ruby-2.4.2/bin:/Users/travis/.rvm/gems/ruby-2.4.2@global/bin:/Users/travis/.rvm/rubies/ruby-2.4.2/bin:/Users/travis/.rvm/bin:/Users/travis/bin:/Users/travis/.local/bin:/Users/travis/.nvm/versions/node/v6.11.4/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin'.
The command "./configure" failed and exited with 1 during .

@kuien yes, you are right this is not relevant to the PR. Please see https://issues.apache.org/jira/browse/HAWQ-1559, just created it. Also, initiated a discussion on mailing thread.

Seems alter schema is disabled with intentional.
Anyone knows the background why we disabled it?


Include in Readme Support for Chocolatapp

It's not an official truffle, but I tried installing first git clone repo. In chocolatapp Actions > Install Extras -> Install from file => Bundle Work for me!!

Hi @zephiro, PRs are welcome any time. If you do submit a PR, please note that using this bundle with Chocolatapp is an unofficial package and will not be explicitly supported by the maintainers of this repo.


refactor onyx workflow

set version for octokit request github action module
https://github.com/octokit/request-action

Test this please

test please


[Bug]: from llama_index.core import global_handler

Bug Description
from llama_index.core import global_handler
Version
0.10.1
Steps to Reproduce
from llama_index.core import global_handler
Relevant Logs/Tracbacks
No response

Try importing like this:
from llama_index.core import set_global_handler
Then choose the mode that you want to set and it should work!

^ this is correct. If you are upgrading to v0.10.X, make sure you either completely uninstall previous llama-index versions, or start with a completely fresh venv

Pardon me potentially hijacking this thread, but I've just upgraded to 0.10.x and while this does compile & run, I cannot see any executions in promptlayer. Should I open a separate issue? Also, I'm using Azure OpenAI if that's relevant

@lmyslinski yea promptlayer needs an update I think, there's another open issue for it. Sounds like it might be fixed
https://github.com/run-llama/llama_index/issues/10632


Instance time zone detection

http://localhost:4502/system/console/status-System Properties.json
because new instance health checking and aem tailer need to know which timezone is on AEM server to compare timestamps

best if this response will be stored in build cache so that this endpoint will be never called again

to be released within 7.0.0


How can i change message font weight from snackbar service?

Hi bro! Can u add opportunity change  font weight from snackbar message. Plz.

hi hi. If you add it and make a PR I'll review and see if it can be merged in. @ziqq

Hi, would it better for it to be in SnackbarConfig or something like the registerCustomMainButtonBuilder?

@akifarhan probably the snackbar config


Manage multiple bots from a single UI/instance of Rasa UI

any suggestion like how it will help me to manage multiple bots  ....

hello @paschmann how can i run multiple bots at same time and i am facing some issue while initiating chat like bot is able to respond for only once any suggestions will be helpful on this
Thanks

Hi @Beherasaptami - you can manage and maintain data for multiple bots in Rasa UI. However, Rasa removed the "Projects" feature last year. This removed the ability to run multiple bots on the same Rasa instance. (Read more: https://forum.rasa.com/t/removing-projects-for-rasa-nlu-server/8962/24) - I have tried to make it as simple as possible to load/test various models from Rasa UI, but technically if you wanted both running simultaneously, you would need 2 Rasa backends, which Rasa UI does not currently support :(


After navigation the website shows blank page for tests.

What is your Test Scenario?
I would like to automate this website https://wordpress.com/ .
What is the Current behavior?
I have automated the  tests as below it's working good until login it's showing blank page after login.
What is the Expected behavior?
It should click myprofile button and enter firstname, lastname in myprofile section.
What is your web application and your TestCafe test code?
fixture Wordpress website tests.page(https://wordpress.com);
test("Login and My profile page verification", async (t: TestController) => {
//Login tests
await t.click("a[title='Log In']");
await t.typeText(t#usernameOrEmail, gifocit125drlatviacom );
await t.click(".form-button");
await t.typeText("#password" gifocit125drlatviacom);
await t.click(".formatted-header");
//my profile tests
await t.click(".gravatar")
await t.typeText(#first_name, firstName)
await t.typeText(#last_name, lastName)
});

Go to my website ...
Execute this command...
See the error...

Your Environment details:

testcafe version:   1.15.3
node.js version:    14.0.0
command-line arguments:  "testcafe chrome -e test.js"
browser name and version: Chrome 92.0
platform and version:    "macOS 11.2.3 , BigSur"

Hello,
Thank you for your input. Indeed, the blank page is shown after logging in. We need some time to investigate the issue. Please stay tuned.


Refactor CHC to use smoothing utils

Closes #430
Summary of Changes:

Update Change to use new smoothing utils
Update test to smooth on test data

blocked by #437

I'm getting some linting errors, but I assume they were fixed by #463

The refactor itself looks good and the tests pass

Just merged main in, passing on my end now.

Passing for me too


Installation and output image issues

After installation with the provided instructions in a docker container (ubuntu:20.04), running profile_to_plot.py gives the following error:
python profile_to_plot.py -g /host/projects/tutorial/profiles/cami2_mouse_gut_gs.profile -i /host/projects/tutorial/profiles/cami2_mouse_gut_metaphlan2.2.0.profile family -b x -t pdf
Traceback (most recent call last):
  File "profile_to_plot.py", line 2, in <module>
    from ProfilesLayout import ProfilesLayout
  File "/host/tmp/CAMIProfilingVisualization/src/ProfilesLayout.py", line 2, in <module>
    from ete3 import Tree, faces, TreeStyle, COLOR_SCHEMES, TextFace
ImportError: cannot import name 'faces'

This can be solved by installing libgl1:
apt update
apt install --no-install-recommends libgl1

Running profile_to_plot.py then gives another error:
python profile_to_plot.py -g /host/projects/tutorial/profiles/cami2_mouse_gut_gs.profile -i /host/projects/tutorial/profiles/cami2_mouse_gut_metaphlan2.2.0.profile family -b x -t pdf
NCBI database not present yet (first time used?)
Downloading taxdump.tar.gz from NCBI FTP site (via HTTP)...
Done. Parsing...
Loading node names...
2268061 names loaded.
225307 synonyms loaded.
Loading nodes...
2268061 nodes loaded.
Linking nodes...
Tree is loaded.
Updating database: /root/.etetoolkit/taxa.sqlite ...
 2268000 generating entries...
Uploading to /root/.etetoolkit/taxa.sqlite

Inserting synonyms:      140000 Traceback (most recent call last):
  File "profile_to_plot.py", line 12, in <module>
    ncbi = NCBITaxa()
  File "/root/miniconda3/envs/CAMIViz/lib/python3.6/site-packages/ete3/ncbi_taxonomy/ncbiquery.py", line 110, in __init__
    self.update_taxonomy_database(taxdump_file)
  File "/root/miniconda3/envs/CAMIViz/lib/python3.6/site-packages/ete3/ncbi_taxonomy/ncbiquery.py", line 129, in update_taxonomy_database
    update_db(self.dbfile)
  File "/root/miniconda3/envs/CAMIViz/lib/python3.6/site-packages/ete3/ncbi_taxonomy/ncbiquery.py", line 760, in update_db
    upload_data(dbfile)
  File "/root/miniconda3/envs/CAMIViz/lib/python3.6/site-packages/ete3/ncbi_taxonomy/ncbiquery.py", line 802, in upload_data
    db.execute("INSERT INTO synonym (taxid, spname) VALUES (?, ?);", (taxid, spname))
sqlite3.IntegrityError: UNIQUE constraint failed: synonym.spname, synonym.taxid

A workaround for this is to replace INSERT INTO by INSERT OR IGNORE INTO in line 802 of ncbiquery.py, then remove /root/.etetoolkit/ before running profile_to_plot.py again.
Finally, this is the image I get (characters are not legible and the circles are missing):
x_tree_family.pdf
In a local, manually created environment (without docker and conda), I get an image with legible characters but the circles are still missing. No errors are reported at this step.

@fernandomeyer we have updated the tool. Can you please ping us if you still get an error?


Remove unused target cares.

The target was a copy of the c-ares::c-ares target, but without the
necessary compiler definitions.  It was broken when building with
gRPC_BUILD_TESTS=ON.
This fixes #13636.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @coryan isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
The Linux Foundation CLA GitHub bot

I am cancelling this PR.  I realize now that CMakeList.txt is a generated file, so this is the wrong way to fix it.


[WIP] Preprocess CSS using Stylis

[x] Stylis preprocessor with placeholders and a temporary classname
[x] Visitor that passes the template string arguments into the preprocessor
[x] Determine the format of the result we want to generate for styled-components to consume
[x] Write ludicrously high amount of unit tests
[x] ~Write preprocessor that works for css and keyframes~ (They should actually "just work™")
[x] ~Disable minification when preprocessing is on~ (Separate PR)
[x] Write simplified preprocessor for keyframes helper

The format that is generated by the preprocessor right now is:
[
  [ '{ width: 100px; height: 100px }' ],
  [ '&:hover { color: blue; background: ', props => props.background, '; }' ],
  [ '', props => props.selector, ' { background: papayawhip; }' ]
]

Apart from the interpolations, it will only need us to get rid of potential &s and prepend the classname to the first string of these arrays.

That looks amazing! 😍
One note: the identifier we pass through from the Babel plugin is the className that will later be assigned to the component, so we can even replace & with that!

Is this done?!

@mxstbr It's a bit rough around the edges :) The keyframes helper will need a simpler preprocessor, but that won't take long to write. Most of the development of this will need to be on styled-components itself now ;)

@mxstbr The last commit adds the missing stuff for the keyframes, so this is complete, if we go by the original to-do list :tada:
I'm treading carefully here, because I spotted another limitation: You won't be able to add new rulesets inside your styled template strings, since it won't be flattened...
That was something we spotted earlier, but we need to resolve it now, I guess. To solve this, all interpolation-rulesets need to be wrapped in css. (Again sth we already wanted)
But, since the css helper is still wrapped inside a block, we will need to flatten it at runtime urg. For that we will need to gather the selector in which the css interpolation is in and append the new ruleset... somewhere. This is not as trivial as I thought, and I'm not sure whether we can make this problem simpler somehow?
If we want to do this at compile-time, we could recursively go through all interpolations and flatten them all into one styled tag, essentially removing all css helpers. But we'd run into the problem that a css interpolation can be passed in as a variable... And my babel-plugin-fu is not as good as I wish it were, to resolve that ^^

Unfortunately, babel-plugin-fu have limits. It will not help to flatten css interpolation if it is imported from another file.
import {verticalCenter} from 'helpers'

const Component = styled.div`
  ${verticalCenter}
`

Also, I want to ask if you considered conditionally applied rulesets? Something like.
import {verticalCenter, horizontalCenter} from 'helpers'

const Component = styled.div`
  ${props.direction == 'v' ? verticalCenter : horizontalCenter }
`

@vdanchenkov Exactly these two things are the ones I'm concerned about.
I don't think we can do anything about them at compile-time.
That's where we gotta bring the magic to runtime ^^

Since this is now behind a default-false flag and has an "experimental" note, I guess we can ship it :shipit:

@mxstbr I can't wait to test this out! npm publish?

Test suite fails locally, so Ican't publish :confused:

@mxstbr Oops! Seems like my stylis was out of date, when I updated the fixtures 😆  I updated it to 1.0.6 in the package.json
https://github.com/styled-components/babel-plugin-styled-components/commit/9fc0a6e


[HOLD for payment 2024-10-24] Tags - Long pressing North+east not showing settings option

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team
Action Performed:

Launch app
In old dot, upload dependent tags
In new dot, open workspace settings
Open tags
Tap region
Long press North+east

Expected Result:
Pressing "select" after long pressing the North+east tag triggers selection mode.
Actual Result:
Pressing "select" after long pressing the North+east tag doesn't trigger selection mode.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Bug6630271_1728534159671!Dependent_-_Multi_Level_tags_NEW.csv
https://github.com/user-attachments/assets/3e4a4640-a54e-4db2-955a-0ee80bec4b74

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @greg-schroeder

Checking this one out right now

@IuliiaHerets I've edited the description, as it took me a while to understand what should be happening and what's not happening.

The issue is caused by https://github.com/Expensify/App/pull/49510

Revert cherry picked to staging

@daledah since you have more information, can you comment in the original PR letting us know what exactly caused the issue in question?

Processing

This was a regression fixed by the original contributor of the offending PR


added new feature a 2nd line in code

Added the code as per requirement dont even try to seek bugs here

Confirm


Fix support for multiple-files without pytest reports

Thanks for this action, it's really useful :)
I noticed that without a third item in the multiple-files row, the action fails on trim. If you leave the field blank after a comma it will continue but the table is not formatted correctly because of the column count mismatch.
This PR fixes those two issues and adds some checks in the multiple-files workflow for it. You can see some examples here
https://github.com/jbcumming/pytest-coverage-comment/pull/5
Let me know if it needs any changes, thanks!

Thanks for the contribution, I release a new version with your fix, you can use:
- name: Pytest Coverage Comment
  uses: MishaKav/pytest-coverage-comment@main

or use a specific version
- name: Pytest Coverage Comment
  uses<EMAIL_ADDRESS>
P.S. sorry for the long response, I was on vacation.

Thanks for merging!


Customizing stylesheet name + package.json

I am a recent convert from twbootstrap, and I am having a hard time wrapping my head around how to customize the theme in a multisite environment where I am using multiple versions of the FPress theme for different sites.
Usually, I would be using child themes all pointing back to the parent with different theme names for each. After extensive search/reading on child themes + the issues, I am more confused than when I first started, since I could not find definitive documentation on how to customize FPress in lieu of child themes.
When I customize the theme details (theme name, etc.)  in the FPress style.css, I break the theme. I tried customizing the package json to point to the customized theme details in the new style.css unsuccessfully.
Is there an easy way to accomplish this that I am just missing?
How can I customize FPress so that I have [MyProjectTheme1, MyProjectTheme2, MyProjectTheme3, MyProjectTheme4, MyProjectTheme5] all safe for updating master components in the most efficient and FPress compatible format?

Hi @socratics ,
FoundationPress is designed as a parent starter-theme. The purpose is to use the Sass files and Grunt task supplied, to build unique sites based on the Foundation framework using WordPress as the backend.
I see what you mean, but to be honest I'm not sure if this theme is the best option if you're looking to use child themes. I know there are some who have made an arrangement to facilitate child themes with FoundationPress, but I would rather recommend to use it as a parent theme and grab a fresh clone for each new project.

Hi @olefredrik...
Thanks for the response... what you are saying is the proof of concept for my suggestion... What I was suggesting is that since FP is a parent/starter theme, people with multisite installs rename/modify the files in several areas for each new installation of the FP theme...
It would be cool if prompts could be included as part of the master npm install process to customize the most basic areas necessary to create a completely customized install of the theme for a project. The directory name, the stylesheet, the footer, and any other areas that can be included as part of this automation process to customize a theme for each project install...
Like a CLI joyride to customize a theme for a specific project... Then you can quickly just install a completely customized version of the theme with all of your proprietary info...
It was just a thought... maybe I spend too much time in the clouds...

Hmm. That sounds interesting. My biggest concern is that more choices to customize the installation process will lead to confusion and pain. There are already people who think that today's quick start guide is difficult. That said, I'm always open to looking at pull requests if you wish to contribute and make the theme better.


Migration to 2.x - timeout after 5000 seconds

I am attempting to migrate a fairly large Cucumber Protractor test suite from SerenityJS 1.x to 2.x and am having a number of difficulties. The main one currently is I get the following error, regardless of whether steps are passing or not:
✗ Execution failed with error (5s 880ms)

  Error: function timed out after 5000 milliseconds
      at errorFrom (/app/node_modules/@serenity-js/cucumber/src/listeners/cucumber-0.ts:172:33)
      at scenarioOutcomeFrom (/app/node_modules/@serenity-js/cucumber/src/listeners/cucumber-0.ts:141:26)
      at /app/node_modules/@serenity-js/cucumber/src/listeners/cucumber-0.ts:89:94
      at processTicksAndRejections (internal/process/task_queues.js:79:11)

For example, this simple function will through the above error:
actorCalled(user).attemptsTo(
          UseAngular.disableSynchronisation(),
          Wait.for(Duration.ofSeconds(30)),
          UseAngular.enableSynchronisation()
    )

I expect there is some missing configuration somewhere but I've been comparing with the examples and I can't see anything missing. Any suggestions would be appreciated.
I'd also note that I cannot get the examples to run. Attempting to run the protractor-cucumber example suite throws the following error - E/launcher - Error: TypeError: Cannot set property 'defaultTimeout' of undefined - and a similar issue occurs with the template - Error message: Could not find update-config.json. Run 'webdriver-manager update' to download binaries running with npm test after running npm ci.

Hey @denialanderror!

I expect there is some missing configuration somewhere but I've been comparing with the examples and I can't see anything missing. Any suggestions would be appreciated.

So the 5-second timeout feels like a Cucumber step timeout, which you might want to adjust either via setDefaultTimeout or per step.

Attempting to run the protractor-cucumber example suite throws the following error
Which example are you referring to, please?

Hey @denialanderror!

I expect there is some missing configuration somewhere but I've been comparing with the examples and I can't see anything missing. Any suggestions would be appreciated.

So the 5-second timeout feels like a Cucumber step timeout, which you might want to adjust either via setDefaultTimeout or per step.

Attempting to run the protractor-cucumber example suite throws the following error
Which example are you referring to, please?

Thanks for the super quick response @jan-molak ! Looks like that was the issue.
The example I was referring to was this one.
I'd also note that it looks like v2.20.0 is no longer compatible with Cucumber 1.x as it no longer allows for the compiler option. If you'd like me to open a separate issue for that, please let me know.

Thanks for the super quick response @jan-molak ! Looks like that was the issue.
The example I was referring to was this one.
I'd also note that it looks like v2.20.0 is no longer compatible with Cucumber 1.x as it no longer allows for the compiler option. If you'd like me to open a separate issue for that, please let me know.

Thanks @denialanderror, I'm glad it helped :-)

The example I was referring to was this one.

This example uses chromedriver, so it shouldn't be trying to use webdriver-manager update. Could you please provide the exact steps for me to try and reproduce the issue you're seeing?

I'd also note that it looks like v2.20.0 is no longer compatible with Cucumber 1.x as it no longer allows for the compiler option. If you'd like me to open a separate issue for that, please let me know.

Could you create a minimal reproducible example based on https://github.com/serenity-js/serenity-js-cucumber-protractor-template so that I can try to reproduce? Please downgrade the version of Cucumber to the exact one you're using and try to reflect your setup as closely as possible.
Thanks!
Jan

Thanks @denialanderror, I'm glad it helped :-)

The example I was referring to was this one.

This example uses chromedriver, so it shouldn't be trying to use webdriver-manager update. Could you please provide the exact steps for me to try and reproduce the issue you're seeing?

I'd also note that it looks like v2.20.0 is no longer compatible with Cucumber 1.x as it no longer allows for the compiler option. If you'd like me to open a separate issue for that, please let me know.

Could you create a minimal reproducible example based on https://github.com/serenity-js/serenity-js-cucumber-protractor-template so that I can try to reproduce? Please downgrade the version of Cucumber to the exact one you're using and try to reflect your setup as closely as possible.
Thanks!
Jan

So I wasn't very clear in my first message about the errors in the template. It's actually two separate issues:
In the cucumber-protractor template, I get the following error:
[test:execute] [09:58:05] E/direct - Error code: 135
[test:execute] [09:58:05] E/direct - Error message: Could not find update-config.json. Run 'webdriver-manager update' to download binaries.

This is on a clean clone, then running npm ci followed by npm test.
The second issue I encountered was with the cucumber-protractor example, where I get this error:
E/launcher - Error: TypeError: Cannot set property 'defaultTimeout' of undefined

I get to this by running npm install followed by npm test
If I can get the template working, I'll get a minimal build on a separate ticket for the Cucumber version issue.

So I wasn't very clear in my first message about the errors in the template. It's actually two separate issues:
In the cucumber-protractor template, I get the following error:
[test:execute] [09:58:05] E/direct - Error code: 135
[test:execute] [09:58:05] E/direct - Error message: Could not find update-config.json. Run 'webdriver-manager update' to download binaries.

This is on a clean clone, then running npm ci followed by npm test.
The second issue I encountered was with the cucumber-protractor example, where I get this error:
E/launcher - Error: TypeError: Cannot set property 'defaultTimeout' of undefined

I get to this by running npm install followed by npm test
If I can get the template working, I'll get a minimal build on a separate ticket for the Cucumber version issue.

@denialanderror I'm also encountering the issue of 'Error: TypeError: Cannot set property 'defaultTimeout' of undefined' when I try use Cucumber with WebdriverIO, were you able to find a solution for this issue?

Hi, it's been a while without any updates here. Let's try to summarize this issue:
@denialanderror got problems with

(1) the Serenity/JS cucumber protractor template
(2) the protractor cucumber example from Serenity/JS repo

@saranyaeaswaran got problems with WebdriverIO and cucumber, but this would apply to

(3) the Serenity/JS cucumber webdriverio template

I was able to test (1) and (3) without any issues today (master branch, Serenity/JS version 2.33.2)

@saranyaeaswaran , if you still have issues on your side with cucumber webdriverio, would you mind to create a separate issue for it with some details of your implementation?

@jan-molak: But there is still a problem with (2). Not the one described in this issue, but the example npm test fails with
Error: Cannot find module 'selenium-webdriver'

and npm install fails with
<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed.

Seems, there was a peer dependency to selenium-webdriver introduced by PR #923.
You've even discussed this in the PR review with @nchursin and that it should be a dev dependency instead of a peer, but somehow it made it to master branch.

Seems, there was a peer dependency to selenium-webdriver introduced by PR https://github.com/serenity-js/serenity-js/pull/923.

Well spotted, let's fix that. Thanks!


Show a disabled "send for review" button when not persisted

The "Send for review" button is now displayed when creating a new guide,
because
https://trello.com/c/QAu4Eggt/96-fix-create-a-new-guide-edition-workflow
Also, hide other guide action buttons instead of disabling them.

:shipit:


Improved PVSS Processing Speed

My understanding is that the PVSS calculation requires a few Python loops which makes it VERY slow, it is by far the slowest operation of all of our analysis offerings. And it is also a common one used in the cloud and by virtually all shock analysts.
Looking into using some compiled C code under-the-hood (@SamRagusa ) as well as any other performance improvements (@CFlaniganMide ) would be a noticeable improvement!
@CrepeGoat, do you have any benchmark data you can share?

The calculation can definitely be sped up by multiprocessing, I've tried this with a C library I write using openMP to to the process pool allocation, and the speedup is generally a factor of how many cores your CPU has.  Another experiment showed that using AVX/SSE instructions (modern SIMD operations available on most CPUs) could produce a x4 speedup on their own.  So we have some hypothetically optimal values, but tons more work would need to be done to make it reliable.

The barge shock from one of the recent webinars is probably a good real-world example: https://colab.research.google.com/drive/1cuZa5Yx55qXLhhnBMdzsJ0iiklwVi5Mq#scrollTo=dYKMz2cS6Mg_
I'd be really curious how much of a speedup we get just by adding Numba multiprocessing to the for loop that does the processing https://github.com/MideTechnology/endaq-python/blob/d2196257c96ce6e0297d01de33c65dbd1c8340ea/endaq/calc/shock.py#L202

A few things.

Are you talking about the code block after the text: "Now perform the shock response spectrum calculation for those frequencies."?   Because that ran so fast that even doing a few thousand files should only take a minute or two.

Unfortunately I think you have some misconceptions about how Numba's JIT compilation works.  Almost none of the lines of code you attached would be able to successfully compile without change (and it's an all-or-none situation).  A (pretty large) subset of pure python is supported, some standard library functionality is supported, and a large subset of the NumPy package is supported.    That is it.  Even if you did want to 'lower' the SciPy functions so that they could be called from within the nopython mode of Numba's compiled code, it still wouldn't be compiling those functions you've lowered with the rest of the code, and thus I don't think it'd see big speed ups on this particular example (since the overhead of calling the SciPy functions is likely negligible).

The way to utilize Numba to get those crazy several order of magnitude speed improvements I like to boast about is not to have it compile
def rms(x):
    return np.sqrt(np.mean(np.square(x))))

but instead to have it compile something like this (not that code specifically, but code written like that):
def rms(x):
    total = 0
    for num in x:
        total += num ** 2
    total  /= len(x)
return np.sqrt(total)

So basically writing out what those SciPy functions do in simple explicit ways would be the way forward with Numba.
Contextual awareness of the compiler is absolutely key.

You're misunderstanding what that flag does, if parrallel=True is set and you're using numba.jit for JIT compilation,  then the code will fail if it needs to fall back from 'nopython' mode to 'object mode' (aka if it would fail if the nopython=True parameter is set, or if you just use numba.njit which I prefer since it's more obvious what it's doing).  You can not just put arbitrary code in parallel with Numba.  In fact it's a smaller subset of what works in regular nopython mode that.
Source: https://numba.pydata.org/numba-doc/latest/user/jit.html#compilation-options
Also anecdotally, I've spent many, many hours trying to squeeze an extra bit of performance out of using these flags and never got any performance worth the overhead added (code still runs on multiple cores even with parallel=False).

Yeah the problem doesn't really exist for a single PVSS calculation on a ~1 second long dataset. But it compounds when:

Processing many files like in endaq.batch
Computing the PVSS on a long time series, say 10 minutes, even 10 hours long - it can take literally hours

On the second point, the best approach is actually to force the PVSS to find maybe the "worst" ~5 events in the recording and compute the PVSS just for those events, not the entire time series. "Worst" becomes a question as to how you define, RMS per 0.5 seconds window was recommended by Hutchinson shock analysis experts. Note that I made a issue request for this #156

You're misunderstanding what that flag does, if parrallel=True is set and you're using numba.jit for JIT compilation, then the code will fail if it needs to fall back from 'nopython' mode to 'object mode' (aka if it would fail if the nopython=True parameter is set, or if you just use numba.njit which I prefer since it's more obvious what it's doing). You can not just put arbitrary code in parallel with Numba. In fact it's a smaller subset of what works in regular nopython mode that.
Source: https://numba.pydata.org/numba-doc/latest/user/jit.html#compilation-options
Also anecdotally, I've spent many, many hours trying to squeeze an extra bit of performance out of using these flags and never got any performance worth the overhead added (code still runs on multiple cores even with parallel=False).

Gotcha, I missed that.  A bigger lift for not much return.

This issue has a lower priority because the focus will be on separating out shock events and then running PVSS on just the shock events.


Reduce output for custom objects when using toHaveLength matcher

🚀 Feature Proposal
Remove the received output for custom objects that fail a toHaveLength matcher assertion.
Motivation
If you use toHaveLength on a custom object, like an enzyme Wrapper, the output logs all the properties of the object. This makes tests difficult to read.
Example
The same way as before, but no received logging for objects that aren't an Array.
Pitch
Appropriate custom matchers make failing tests more expressive, but error messages for custom objects with toHaveLength are too verbose. It makes failing tests less expressive.

YES PLEASE! This is out of control:

To be fair, you can opt out of this, and just expect(thing.length).toBe(0)

A quick win might be to remove the Received output all together and instead have:
Expected value to have length:
  n
Received length:
  m

A slightly more complicated but better alternative could be to use process.stdout.columns to determine how wide the users terminal is and only print the first N characters of the stringified received value :)

@pedrottimark are you fixing this in your PR?

@greypants thanks for this man, you are amazing


video quality is not upto the mark

how can we enhance the
video quality of jitsi meet
how can we customize
to make it better

Hello. This plugin is literally an implementation of the official Jitsi Meet SDK. This kind of problem is not plugin fault.
Usually video quality depends on connectivity and device itself.
To find out what is happening I suggest you to test this plugin in an Helloworld project to exclude the possibility of some resource consuption by the app.
Also please write here what device are you using and android version to make us easier to help you eventually.
Best regards.
-------- Messaggio originale --------
Da: vikrantShrinkcom @.>
Data: 28/02/22 15:50 (GMT+01:00)
A: Zeno97/cordova-plugin-jitsi-meet-sdk @.>
Cc: Subscribed @.***>
Oggetto: [Zeno97/cordova-plugin-jitsi-meet-sdk] video quality is not upto the mark (Issue #20)
how can we enhance the
video quality of jitsi meet
how can we customize
to make it better
—
Reply to this email directly, view it on GitHubhttps://github.com/Zeno97/cordova-plugin-jitsi-meet-sdk/issues/20, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKABCKHX36OJP4BBFEIIHBTU5ODULANCNFSM5PRJUL6A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Longer samples are cut off in the playground

Longer samples, like the one for Fortran (Fixed Form), are cut off due to an overflow/view height issue - and you can't scroll down in them either. I tried messing around with overflow: auto and height in Dev Tools but couldn't get it to work properly.

Should be fixed


UnicodeDecodeError: 'cp932' codec can't decode byte 0x85 in position 56546: illegal multibyte sequence

Hello, I'm having an issue with compiling my python script. Please help.
I tried running this command first -> chcp 932
Then this command to compile the python script -> nuitka --standalone --windows-console-mode=disable --lto=yes export_excel.py
But still got the same error.
Below is the crash report.
<?xml version='1.0' encoding='utf8'?> <nuitka-compilation-report nuitka_version="2.4.4" nuitka_commercial_version="not installed" completion="exception">   <exception exception_type="UnicodeDecodeError" exception_value="'cp932' codec can't decode byte 0x85 in position 56421: illegal multibyte sequence"> Traceback (most recent call last):   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\MainControl.py", line 1155, in main     _main()   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\MainControl.py", line 1004, in _main     result, scons_options = compileTree()                             ^^^^^^^^^^^^^   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\MainControl.py", line 919, in compileTree     result, scons_options = runSconsBackend()                             ^^^^^^^^^^^^^^^^^   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\MainControl.py", line 767, in runSconsBackend     runScons(   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\build\SconsInterface.py", line 403, in runScons     checkCachingSuccess(source_dir or options["source_dir"])   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\build\SconsCaching.py", line 336, in checkCachingSuccess     stats = _getCcacheStatistics(ccache_logfile)             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\build\SconsCaching.py", line 282, in _getCcacheStatistics     for line in getFileContentByLine(ccache_logfile):                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\utils\FileOperations.py", line 793, in getFileContentByLine     return getFileContents(filename, mode, encoding=encoding).splitlines()            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\社内開発ツール\1230394_情報管理ツール\excel_tool_prototype\prototype1\scripts\.venv\Lib\site-packages\nuitka\utils\FileOperations.py", line 811, in getFileContents     return f.read()        ^^^^^^^^ UnicodeDecodeError: 'cp932' codec can't decode byte 0x85 in position 56421: illegal multibyte sequence
I installed Nuitka and python using poetry.  Below are the dependecies installed:
[tool.poetry.dependencies]
python = "^3.12"
mypy = "^1.11.0"
xlwings = "^0.31.10"
pandas = "^2.2.2"
openpyxl = "^3.1.5"
ruff = "^0.5.4"
nuitka = "^2.4.4"

From what I've tested, if your code is old and written in Shift-JIS, you'll have problems. Maybe in Japan they still use Shift-JIS in their code instead of Unicode? If you don't convert the code to Unicode, you'll continue to get the same error. I suggest you have an internal discussion and seriously consider converting your code to Unicode.
私がテストした結果、コードがShift-JISで書かれている古いコードであれば、問題が発生します。まさか日本ではまだUnicodeの代わりにShift-JISをコードで使っているのでしょうか？コードをUnicodeに変換しないと同じエラーが発生し続けます。内部的に協議して、Unicodeにコードを変換することを真剣に検討することをお勧めします。

Thank you for your comment! I actually wrote the code in UTF-8.
We've made a requirement internally to code in UTF-8.

Nuitka is supposed to be compatible with all codes. I think this is about module names that are not ASCII showing up in the ccache log file. We are reading this file with the default locale, however, it seems ccache is writing with in UTF8, so we need to enforce that.

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback on whether this is working is very welcome. Please do not share plans to do it; only confirm or deny that it is working.

I wasn't able to test this, so I just did it, obviously ccache doesn't respect platform locale of Windows, which is why this is happening. Ought to work and will be part of the next hotfix too.

thank you sir! I tried doing it but I still got the same error.

Can you provide the new traceback so I can see what it does?


create extensions.json from ha repo

are all of these recommended here too?

This file is added to gitignore in HA Frontend https://github.com/home-assistant/frontend/blob/dev/.gitignore#L34, we should do the same here.

it's added to ignore after the file was created I think. I am not 100% sure the reasoning.

Ohh I created directly in GitHub so maybe an update to .gitignore is required

I think those four are a good strart. We can always add/edit this in the future.