Staged category filters do not clear after pressing Android hardware back button

Description of issue
Using the hardware back button on Android when staging changes to the categories filter does not clear the staging state.
Expected behaviour
Navigating back into the categories filter after pressing hardware back should show the current applied categories.
Steps to reproduce
Navigate to the events screen.
Navigate to the category filter screen.
Select a couple of categories.
Press hardware back.
Notice no filters have been applied.
Navigate back to the category filter screen.
Notice categories are selected.
OS / Browser / Device model
Android, any.
Screenshots

This can be closed as the filter navigation has been changed so that pressing back applies the filters.


How to Clear Old Form inputs when launching the embed pdf

Currently I am using the script like
 <EmbedPDF                     mode="inline"                     style={{ width: 900, height: 800 }}                     documentURL="https://laborlink-media-bucket.s3.ap-south-1.amazonaws.com/internal/exhibit101.pdf"   /> But the issue is that for each user I want to create form I am getting prefilled signature and other details, is there a solution to this

Hey @shreyash-jain!

But the issue is that for each user I want to create form I am getting prefilled signature and other details

SimplePDF automatically caches (in local storage) the filled values – to prevent users from having to fill the same details again if they close the tab or for convenience if they open the same document in the future.
If I understood you correctly, you are (or your users) are opening the same document multiple times in a row, and therefore the previously filled values are present when opening the document?
If you can confirm that this is the issue, I could look into disabling that behaviour for simplepdf-embed and instead reset the form values for each opening automatically: would that work for you?


deploy-bm-quickstart.md documentation link seems to be broken

https://github.com/redhat-performance/jetlag/blob/main/docs/deploy-bm-quickstart.md
deploy-bm-quickstart.md
Deploy a Bare Metal cluster via jetlag quickstart
Assuming you received a scale lab allocation named cloud99, this guide will walk you through getting a bare-metal cluster up in your allocation. For purposes of the guide the systems in cloud99 will be Supermicro 1029p.
We had recently referred the documentation for deploy-bm-quickstart.md but now when we are trying to access the link it says 404.

Hi @rbadagandi ,
That doc has been superseded with Deploy a Bare Metal cluster via jetlag from a Scale Lab Bastion Machine quickstart.
You can find all of the quickstarts linked on the root READme here.
Thanks.


Move Hypershift kubeconfig download to cluster action group

Signed-off-by: Feng Xiang<EMAIL_ADDRESS>https://issues.redhat.com/browse/ACM-2092

Move Hypershift kubeconfig download to the cluster action group align the design
Fixed onboarding modal discover hosts link
Fixed topology OCP apps not displaying pods/replicasets properly

/test lint-check-unittests-sonarcloud


Need to assign twice a new property of a Node

Only on the second node.property = "value" it write the value.
Doesn't work with node[:property] at all. Running w/ latest git code.
> n = Node.create(name: "Test")   # => #<Neography::Node name="Test">
> n.prop = 1                      # => 1
> n.prop                          # => *** nil ***: First time, value still nil
> n.prop = 1                      # => 1
> n.prop                          # => 1: Second time, value written
> n[:prop]                        # => 1
> n[:prop2] = 2                   # => 2
> n[:prop2]                       # => *** nil ***
> n[:prop2] = 2                   # => 2
> n[:prop2]                       # => *** nil ***
> n.name                          # => "Test"
> n.name = "New Name"             # => "New Name"
> n.name                          # => "New Name" (That's an existing property, it works)

I fixed this https://github.com/maxdemarzi/neography/commit/485807cf490f4e57c93495bc5847ac93038ca728 will be in 0.0.18


Plugin Error

Genrate Butterknife injections  ：Android ButterKnife Zelezny threw an uncaught NullPointerException. Disable Plugin

You want https://github.com/avast/android-butterknife-zelezny, not this project.

Sorry, thank you.

Sorry, thank you


🔥 Update yarn.lock on greenkeeper PR's && ⬆ bump dependencies

no issue
We have disabled GK pull requests and we are using yarn upgrade-interactive instead.

remove yarn lock auto commit for GK pull requests
bump some dependencies manually

Please merge the commits separately 😎

After pulling this down and running yarn install I still end up with a modified yarn.lock file 🤔 Which version of yarn are you using?
diff --git a/yarn.lock b/yarn.lock
index 4edce9e61..856c5e8d9 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3330,13 +3330,13<EMAIL_ADDRESS>   version "1.25.0"
   resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.25.0.tgz#c18dbd7c73a5dbf6f44a024dc0d165a1e7b1c392"

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>   version "2.1.13"
   resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.13.tgz#e07aaa9c6c6b9a7ca3012c69003ad25a39e92a88"
   dependencies:
     mime-db "~1.25.0"

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>   version "2.1.15"
   resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.15.tgz#a4ebf5064094569237b8cf70046776d09fc92aed"
   dependencies:
@@ -4317,14 +4317,10<EMAIL_ADDRESS><EMAIL_ADDRESS>   version "6.2.0"
   resolved "https://registry.yarnpkg.com/qs/-/qs-6.2.0.tgz#3b7848c03c2dece69a9522b0fae8c4126d745f3b"

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>   version "6.4.0"
   resolved "https://registry.yarnpkg.com/qs/-/qs-6.4.0.tgz#13e26d28ad6b0ffaa91312cd3bf708ed351e7233"

<EMAIL_ADDRESS><EMAIL_ADDRESS>-  version "6.3.1"
-  resolved "https://registry.yarnpkg.com/qs/-/qs-6.3.1.tgz#918c0b3bcd36679772baf135b1acb4c1651ed79d"
-
<EMAIL_ADDRESS>   version "5.1.0"
   resolved "https://registry.yarnpkg.com/qs/-/qs-5.1.0.tgz#4d932e5c7ea411cca76a312d39a606200fd50cd9"

@kevinansfield As discussed in slack, i've updated yarn to 0.23.x + regenerated the lock file.

👍 LGTM, no modified yarn.lock after installing now 😄


Remove "suspected" mechanism (JAVA-617).

Is a goal of this also revert the JAVA-425 behavior?  Prior to the implementation of JAVA-425 the driver did not defunct on Read Timeouts (see: 60c22ff128bc6f055734c1b4f14dfd3d641e4441).


The version check made when you switch to a different tab returns cached result - reported by @kidroca

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Have New Dot open before an update is published
After an update is published refresh the app
Note you are on now on the latest version
Switch to another tab/window - notice New Dot refreshes

Expected Result:
version.json  should not cache
Actual Result:
When a new version is released every time you go to a different tab New Dot refreshes version.json being a file seems to be getting cached and returns a cached version
Context
User noticed that the tab was refreshing every time I switch, so I put a breakpoint to test it. And as you can see in the screenshot (above) the received version is the old one, for some reason the file being directly served from cache or the server returning a cached file or something else...
But about a hour or two after the new version was published I started to get the same versions and the tab stopped refreshing
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.1.38-0
Reproducible in staging?: Y
Reproducible in production?: need new build to repro
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644427912573639
View all open jobs on GitHub

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

This looks like something that can be worked externally 👍

Current assignee @bfitzexpensify is eligible for the Internal assigner, not assigning anyone new.

OK, adding the engineering tag back then.

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@justinpersaud  do you know if this is something that has to be done in the Cloudflare workers or somewhere else?

@roryabraham , do you happen to know where do we serve the version.json from? I think we may just be missing to respond with a header like cache-control: no-store or cache-control: no-cache (more info)

version.json is part of the web bundle (together with index.html, scripts and all other assets)
I guess it's hosted the same way/place where index.html is placed
Instead of trying to set cache control, why not make the logic that fetches the file ignore cache and always request from network - the request seems to be made periodically or when you switch to another tab
HttpUtils.download('version.js', { cache: 'no-cache' })

Oh, interesting, I didn't know we could do that from the front-end. Some examples on how to do it: https://stackoverflow.com/questions/29246444/fetch-how-do-you-make-a-non-cached-request
I'll add External since it seems like it can be done in the App!

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Sorry, I missed the ping here somehow, but I agree with what's said. If you don't want this to be cached, let's update the headers on the object and the CDN (Cloudflare) should honor that.

@justinpersaud It sounds like you're saying we should handle this in Cloudflare rather than in the front-end, is that correct? In that case this would need to be handled internally, presumably via a PR to https://github.com/Expensify/Cloudflare-Workers

I think the solution posted above https://github.com/Expensify/App/issues/7856#issuecomment-1068125057 would work if your goal is to always fetch the latest copy of this file.

Yeah, let's do that for now 👍  this file is fetched very infrequently – only every 8 hours.
We do purge cloudflare caches when we deploy an new version, but I'm not familiar with what caching we have set up with Cloudflare anyways.

Yeah, let's do that for now 👍 this file is fetched very infrequently – only every 8 hours.

Hum, I think we download the file every time the app goes to the background
https://user-images.githubusercontent.com/87341702/158475950-cdec1ad1-70a5-463c-a79c-fe9b29f37028.mov

I don't think you need to change this in Cloudflare, because even if you do, it doesn't stop the client from caching it locally. I think the solution posted above https://github.com/Expensify/App/issues/7856#issuecomment-1068125057 would work if your goal is to always fetch the latest copy of this file.

Just adding some info... I think if the server replies with Cache-Control:  no-store, the browser is not supposed to use any cache (including disk), so I think this can be solved in either the front or the back.

Hum, I think we download the file every time the app goes to the background

Oh yes you are 100% correct: https://github.com/Expensify/App/blob/18be748d9473a18addc9d37669dbb66927338c8a/src/setup/platformSetup/index.website.js#L47-L53

It sounds like we're good to proceed with fixing this on the front end, so I'll move forward on pushing this through.
Posted to Upwork: https://www.upwork.com/jobs/~01999d68f951063456

📣 @rushatgabhane You have been assigned to this job by @expensify-bot[bot]!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

I think the solution posted above https://github.com/Expensify/App/issues/7856#issuecomment-1068125057 would work if your goal is to always fetch the latest copy of this file.

@aldo-expensify are we good to accept this proposal as the solution here? Or keep soliciting proposals?

@stephanieelliott sorry, I'm not part of the contributors management team, you have to ask @luacmartins  or @roryabraham  :)

It seems like we decided to fix this in the frontend. @kidroca's proposal looks good. Let's move forward with this.

📣 @kidroca You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thanks for the heads up @kidroca, I think that's fine.

Just noticed that  HttpUtils.download would only work with json content:
It uses processHTTPRequest
https://github.com/Expensify/App/blob/1c4add7b7b691724edd2040110d2adc2b92e7b60/src/libs/HttpUtils.js#L68-L77
And processHTTPRequest treats any response as json
https://github.com/Expensify/App/blob/1c4add7b7b691724edd2040110d2adc2b92e7b60/src/libs/HttpUtils.js#L38
If you ever try to download anything other that json content the method would fail with the following error
Uncaught (in promise) SyntaxError: Unexpected token � in JSON at position 0

It's not verify useful if our download method can only download JSON text files

HttpUtils.download only usage is inside src/setup/platformSetup/index.website.js
https://github.com/Expensify/App/blob/1c4add7b7b691724edd2040110d2adc2b92e7b60/src/setup/platformSetup/index.website.js#L18
It might be best to directly use fetch there

it's webspecific logic
we want to download a file and then read it as json

Then we can either remove the HttpUtils.download method - no more usages, or update it to be able to download files other than json

We also have this fileDownload library that I think is more general-purpose.

I guess it's meant to be used to download content/files for the end user since it would initiate a visible browser download
https://github.com/Expensify/App/blob/0f38b9a0107977e2b49edef1534caf1199e08b38/src/libs/fileDownload/index.js#L32-L35
And it's not meant to download files for in-app use behind the scene
Maybe this means we don't have a use case for HttpUtils.download - downloads for the end user are covered by fileDownload while the only usage of HttpUtils.download is inside website update logic

To make HttpUtils.download ignore cache I need to modify the structure of processHTTPRequest so that it accepts fetchOptions regarding the cache policy
I think it would be best to just use fetch directly in src/setup/platformSetup/index.website.js because that's the only use case we have where we'd like to modify fetchOptions and the cache handling

I've found out we have hardcoded English text here:
https://github.com/Expensify/App/blob/1c4add7b7b691724edd2040110d2adc2b92e7b60/src/setup/platformSetup/index.website.js#L30-L34
used in this popup:

Pull Request ready

https://github.com/Expensify/App/pull/8350

PR is undergoing QA

Looks like payment was due yesterday. @stephanieelliott could you check if this has been paid out? Thanks!

@kidroca is all paid up for the job + reporting bonus!
@rushatgabhane you were invited to the job in Upwork, please accept so I can pay you for C+. Job is here: https://www.upwork.com/jobs/~01999d68f951063456

@stephanieelliott thanks but there is no C+ work for this issue. The proposal  was accepted before I was assigned


documentation error

On  "Deploy Mayastor"  the very last command:
kubectl mayastor get nodes

should read
kubectl -n mayastor get nodes

The command is actually referencing our kubectl plugin.
Right above, it reads:
"The number and status of mayastor pods can be observed by using the Mayastor kubectl plugin"
Please take a look [here](https://mayastor.gitbook.io/introduction/reference/kubectl-plugin.


Feature/19 integration test improvements

This PR mainly consolidates all the different start ... request session keywords from several resource files into one keyword prepare new request session in one resource file --> _resources/keywords/generic_keywords.robot and updates all test cases and keywords that were impacted by this change.

closing in favour of ehrbase/ehrbase/pull#91


Fixes test_examples.py tests collection

What does this PR do?
As per title.
Fixes: #571

Thank for the fix. I dont see above error anymore. But I encounter a new error now as below.
No input shapes provided, using default shapes, {'batch_size': 1, 'sequence_length': 128}
_______________________________________________ test_export_no_parameters[feature-extraction-hf-internal-testing/tiny-random-XLMModel] _______________________________________________

self = <optimum.neuron.utils.hub_neuronx_cache.CompileCacheHfProxy object at 0x7f0d8009f850>, repo_id = 'optimum-internal-testing/optimum-neuron-cache-for-testing'
default_cache = <libneuronxla.neuron_cc_cache.CompileCacheFs object at 0x7f0f393d7c70>, endpoint = None, token = None

    def __init__(
        self, repo_id: str, default_cache: CompileCache, endpoint: Optional[str] = None, token: Optional[str] = None
    ):
        # Initialize the proxy cache as expected by the parent class
        super().__init__(default_cache.cache_url)
        self.cache_path = default_cache.cache_path
        # Initialize specific members
        self.default_cache = default_cache
        self.api = HfApi(endpoint=endpoint, token=token, library_name="optimum-neuron", library_version=__version__)
        # Check if the HF cache id is valid
        try:
            if not self.api.repo_exists(repo_id):
>               raise ValueError(f"The {repo_id} repository does not exist or you don't have access to it.")
E               ValueError: The optimum-internal-testing/optimum-neuron-cache-for-testing repository does not exist or you don't have access to it.

optimum/neuron/utils/hub_neuronx_cache.py:116: ValueError

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

That is because you do not have access to this repo, and this is the one used by default for the test.
To be able to run the test on your side:

Create a model repo on the Hub
Set the environment variable CUSTOM_CACHE_REPO=the-name-of-your-model-repo
Set the environment variable HF_TOKEN=your-hf-token-that-provides-access-to-the-repo

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


The initial classes of the main component are removed during bootstrap

Angular 3.0.0
I created a basic example based on the Angular template where I only added a class on the main component
<my-app class="my_initial_class">Loading...</my-app>

The class my_initial_class is removed during  bootstrap (which was not the case with Angular 2.0.0). The following startup code:
main() async {
  print("before bootstrap: ${document.querySelector("my-app").classes}");
  await bootstrap(AppComponent);
  print("after bootstrap: ${document.querySelector("my-app").classes}");
}

printing the following in the console:
before bootstrap: my_initial_class
after bootstrap: _nghost-ocy-1

showing that the class disappears. To note that this is not the case for any other component. It only happens for the main one.
Source code here: https://github.com/alextekartik/dart-test/tree/master/angular_main_component_class_test

@ferhatb I think this might related to the change you made with bootstrap, mind taking a look?

It turns out this is intentional, if you wish to apply an initial class to the bootstrapped element, you can do so in the component itself.
@Component(
  template: 'my-app',
  host: const {
    'class': 'my_initial_class',
  },
)
class MyApp {}

Is this solution suitable for your situation?
It's worth mentioning the Element.id property is preserved by bootstrapping if that helps.

Ok thanks. Yes i found another workaround by putting the class on the body element. I have a situation where I have 2 applications sharing the same code (so here your solution does not apply) but not the same html entry point so I was using a class on the initial component for some global css styling. I personally think that it is an odd intention (why preserving the id and not the class) but I don't think it will be showstopper for anybody to have such restriction as long as it gets documented somewhere. Thanks for confirmation

I agree it seems strange but replacing the element altogether was done in an effort to unify how components are built (regardless of whether they're the root or not), which in turn will simplify and reduce the generated code. Preserving the Element.id was done so there's still an absolute sure way to locate the application root. See 908022b909c15b136dbb6c5e0d6b4e1b8f8edd37.


Implement support for parallel builds

Untested.
Seems to work: https://coveralls.io/builds/26943546

Hi @CyberShadow, thank you for opening all these pull requests!
Unfortunately, I have no interest in maintaining this project, so I would happily pass this duty to somebody else.
It looks like you made yourself quite familiar with the codebase so far. Are you interested in becoming a maintainer of this project?

Sure.
We use undercover.el in https://github.com/Emacs-D-Mode-Maintainers/Emacs-D-Mode, which I'm maintaining.

Great news, thank you!
I'm not sure what is the best process to pass maintainer role on Github, so I suggest following plan:

You create a fork of this repository (if you want it to be different from CyberShadow/undercover.el.)
I add mention of it to the README file in my version of the repo.
We update the link to the repo in Melpa https://github.com/melpa/melpa/blob/master/recipes/undercover.

Does this plan sound good for you?

Hi,
We could do that, though may I suggest one of the following:

Just add me as a collaborator. Then I'll be able to push to the repository and review pull requests. This will preserve existing issues and will not require updating any metadata on MELPA or anywhere else.

If you would rather no longer be associated with the project, we could move it to a new organization. This will also preserve issues etc., and moving will create a redirect, so no metadata will need to be updated either.

Hey,
Yes, I prefer option #2. Will you create such an organization? I will be able to move other undercover.el related projects to it as well.

OK, done: https://github.com/undercover-el

@CyberShadow, thank you! I have transferred all related repositories under this organization. I hope you have permission to maintain this project now.

Looks good, thanks! I will apply my fixes soon.
One thing I should point out is that if you do decide to contribute in the future, you probably want to avoid forking the repositories there back to your account, as that will break the redirect (and then we will have to update external metadata etc.). Instead, you can create a branch on undercover-el/undercover.el or just push there directly as before.

Yep, make sense, thank you!


Utf8 emojis from innerHTML are sometimes grayed

Expected behavior
See all emojis in ok color.
Current behavior

I'm loading content of tooltip from HTML - like this: document.getElementById('something')).innerHTML
There some emojis: ➡, ➡, ⬅ or ⬇.
It works but I see emojis in gray color - but ONLY SOMETIMES. I tested two emojis in one innerHTML. I sometimes see one emoji ok and one in gray color.
Do you know why?
Reproducible sample
https://asteroid.vsevjednom.cz/
Optional extra steps/info to reproduce
This problem is only in Firefox. In Opera and Chromium it's ok.
Possible solution
No response
Context
https://asteroid.vsevjednom.cz/
chart.js version
2.9.4
Browser name and version
Firefox 129
Link to your project
https://asteroid.vsevjednom.cz/

This sounds like a browser issue. Since we don't render the html but the browser does.

You're right, maybe. I see this error right now, not before. So I'm waiting for new version of Firefox.

Closing as this is not a chart.js issue


macOS, tvOS, watchOS not built on CI

In #301, we nixed Bitrise builds for iOS, macOS, tvOS, and watchOS but only added a CircleCI build for iOS. We need to ensure that the CircleCI build covers all four platforms; otherwise, any problems will only be caught after release, when we push the pod to CocoaPods trunk and it fails verification.
/cc @mapbox/navigation-ios

Oh, I missed that somehow, OK. Sorry for the false alarm.

Build and test on all platforms except for testing on watchOS for a reason I can't remember 🤔

XCTest is unavailable for watchOS, so that’s consistent with the old Bitrise app.


Provide an empty font manifest if the app has no flutter.yaml

LGTM
Is this better than just omitting the manifest from the FLX entirely?  I guess this approach reduces the possibilities we need to deal with at runtime.

Yeah, we can just skip the font manifest if it has no content.  Updated the PR.

LGTM


Implement all of numpy.linalg

[x] cholesky
[ ] cond
[x] det
[x] eig
[x] eigh
[x] eigvals
[x] eigvalsh
[x] inv
[ ] lstsq
[x] matrix_power
[x] matrix_rank
[ ] multi_dot
[x] norm
[x] pinv
[x] qr
[x] slogdet
[x] solve
[x] svd
[ ] tensorinv
[x] tensorsolve

@sudsj
I am interested in using multi_dot as soon as possible.
Any news on your progress?
Do you need help?

@Jakob-Unfried, I need some help with testing my changes, as I'm facing errors while importing the modules in the python interpreter to test the functions. Do you have a Gitter account, where I can message screenshots/code ?

I'm interested in doing lstsq

@sudsj
I have a Gitter account now.
Will move my conversation with you about multi_dot with you to private messages there.

Implementing the scipy.linalg functionality will be good also:

[ ] lu
[ ] polar
[ ] expm
[ ] logm
[ ] sqrtm
[ ] fractional_matrix_power

@oleg-kachan
expm and lu exist in jax.scipy.linalg

@oleg-kachan polar calls svd as in https://github.com/scipy/scipy/blob/master/scipy/linalg/_decomp_polar.py. I can make a PR when I have time.


✨ [Feature request]: Enable to user to Comment on a Play

Is your feature request related to a problem? Please describe.
Now users can not comment on a Play. It will be great to give that ability.
Describe the solution you'd like
Allow users to comment on a Play.
More discussion: https://github.com/atapas/react-play/discussions/53

I am incorporating giscus with the plays. The basic implementation is done. need to take care of styling and positioning of the comments.

Now we can post likes and reactions on a play


ci: sync automated test cases between github and qase and post test run for daily regression

Which issue(s) this PR fixes:

Issue https://github.com/longhorn/longhorn/issues/8853 https://github.com/longhorn/longhorn/issues/7412
What this PR does / why we need it:
sync automated test cases between github and qase and post test run for daily regression
Special notes for your reviewer:
Additional documentation or context

@yangchiu Looks like the test cases with suffix created by specific Jenkins parameter are getting added. E.g. test case running with NFS get the suffix [nfs] and test case running with s3 get suffix [S3], they are both getting added in the test repository in Qase. We have duplicated test cases now.

@yangchiu Looks like the test cases with suffix created by specific Jenkins parameter are getting added. E.g. test case running with NFS get the suffix [nfs] and test case running with s3 get suffix [S3], they are both getting added in the test repository in Qase. We have duplicated test cases now.

This is expected since you tried to copy daily regression test results from a junit test report to a qase test run. Every test case must have a one to one mapping between junit and qase.
@khushboo-rancher

@Mergify backport v1.7.x v1.6.x


QMAPS-434 add poi stars for lodging and restaurants

Description

cleanup commented code
add "stars" block with two fields: has_stars (unknown/yes) / nb_stars (float > 0 if it is known, 0 or undefined if not known)
Fake data (to remove when the API is ready, hence the draft status)
display the block ("Starred {type}"   or   "{Type} with {n} stars")
Ensure proper capitalization in the languages where the string starts (or does not start) with "{Type}"

Screenshots

Thanks @bbecquet , I'm starting that in a separate MR


Rewrite Services in Swift

[x] UTMProcess
[x] UTMQemuSystem
[x] UTMLocationManager
[x] UTMLogging
[ ] UTMJailbreak
[ ] UTMSpiceIO
[ ] Change startProcess to use scoped UnsafePointer to resolve dangling pointer warning

Just FYI, we purposely left objective c code in objective c if it’s more reasonable to use it due to either C library or Apple framework compatibility or because the code is cleaner.

Just FYI, we purposely left objective c code in objective c if it’s more reasonable to use it due to either C library or Apple framework compatibility or because the code is cleaner.

I agree that there are some instances here where the Swift solution is significantly messier case in point, startProcess on UTMProcess. However, there are things here that can be converted to Swift with a clean solution. I'm happy to revert some of the rewrites if you decide they're too messy for your taste.
How it's written now is very much the "cheap-n-dirty" solution and not necessarily the cleanest "Swiftiest" way. I will work on improving the messier parts.

My philosophy usually is I don’t rewrite any code for the sake of rewriting it. It’s only if I need to implement a feature or I want to rearchitect a particular part or something. Case in point, the last rewrite I refactored a lot of the QEMU support code into QEMUKit and made swift friendly interfaces. I think that out of everything, the backend stuff least need to be converted to swift. There’s a lot of front end iOS stuff that’s still objc from the early days and moving to swift may actually benefit the code.
Anyways feel free to do what you want, just letting you know my thoughts early so you don’t waste any time if it doesn’t get merged.


SqlServer provider: unexpected command parameter dbtype for fixed length ansi strings

The situation is the following:
We are currently working in a new application that has to use a database with a quite old design (lots of CHAR(n) columns, even for keys and FK's).
Recently, we noticed that we were having quite poor/slow performance when inserting new data in tables.
After reviewing the resulting INSERT, we noticed that instead of using CHAR(n) parameters, VARCHAR(n) are used instead, that when used in a sp_executesql statement can result in bad performances.
Then we reviewed the model (generated via scaffolding), and we noticed that we had no .IsFixedLength() for the CHAR(n) properties/columns involved in the inserts (is the scaffolding doing the right thing here?).
Once corrected, we tried again, but the INSERT's were performing still bad, reviewing the newly generated statement, VARCHAR parameters are still being used.
After this, I have decided to dive into the code and I think that I might have found the reason of this behaviour, in SqlServerStringTypeMapping I have found the following:
public SqlServerStringTypeMapping(
    [CanBeNull] string storeType = null,
    bool unicode = false,
    int? size = null,
    bool fixedLength = false,
    StoreTypePostfix? storeTypePostfix = null)
    : this(
        new RelationalTypeMappingParameters(
            new CoreTypeMappingParameters(typeof(string)),
            storeType ?? GetStoreName(unicode, fixedLength),
            storeTypePostfix ?? StoreTypePostfix.Size,
            GetDbType(unicode, fixedLength),
            unicode,
            size,
            fixedLength))
{
}

private static string GetStoreName(bool unicode, bool fixedLength) => unicode
    ? fixedLength ? "nchar" : "nvarchar"
    : fixedLength
        ? "char"
        : "varchar";

private static DbType? GetDbType(bool unicode, bool fixedLength) => unicode
    ? (fixedLength ? System.Data.DbType.String : (DbType?)null)
    : System.Data.DbType.AnsiString;

The method GetDbType is unconditionally using System.Data.DbType.AnsiString for non-unicode strings. Is there any reason why it shouldn't be using System.Data.DbType.AnsiStringFixedLength for fixed length strings?
In case that there is a good reason for this behaviour, is there any way to trigger the usage of CHAR(n) parameters instead of VARCHAR(n)?
Further technical details
EF Core version: 2.2.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer

@elBranchi Currently our mapping doesn't depend on the values, it would require significant infrastructure changes. Also in general we try to use the same type of paramaters for the same query to avoid cache fragmentation.

@AndriySvyryd that's more or less the answer that I was fearing/expecting and that also makes a lot of sense :-
In this case, the only thing remaining I imagine that would be devising/designing the mechanism that would allow the applications to tell EFC that certain DbTypes are to be used instead of the selected by the model.
In any case it would need to be appliable to queries and also insert/updates, so I don't have a clear picture of how I would include such feature in a clean and consistent way. One way would be enabling the change in the model, and the other would be applying some modification on an operation by operation basis.

@AndriySvyryd We already configure the parameter Size differently based on the length of the string. Maybe if the mapping is for fixed length, the length is specified, and the size of the string matches the length, then we can set the DbType to fixed. Thoughts?

@ajcvickers Good idea, we can actually set DbType to fixed and adjust Size to match the string length, this avoids padding.

@ajcvickers @AndriySvyryd
Ok, this starts to sound really good me, it will make happy my colleagues also.
I'm already planning on trying the 3.0 preview on a different branch, and having this change on either 2.2.x or a later 3.0 preview would be perfect.

@ErikEJ Yes, but only if using fixed-length types with variable length strings, which seems like a reasonable compromise to make.

Clearing up to look at it again in triage.
I am just wondering if we can fix the inference code to copy the fixed length facet (and let the padding happen), but only for certain operations like comparison and assignment. That should help with cases like SimpleQueryTestBase.Comparing_to_fixed_string_parameter (in which we are inferring the facees for the argument of a function) without introducing cache pollution.
BTW, re the current proposal, I am not sure that operations between fixed length parameters and fixed length columns when the length is different perform better than between variable length and fixed length (maybe this is something that we can test).

@ErikEJ Yes, but only if using fixed-length types with variable length strings, which seems like a reasonable compromise to make.

Maybe I am missing something, but that sounds pretty much any time we use string parameters with fixed length string columns, and that seems a lot.

See #19579: a work around is to use
.FromSql("select * from [tablename]")
.Where(condition on char column)
In this case EF core generates a query with a local variable using limited length and the index is used.


Why do InitVar parameters not get validated + cast to their annotation like normal parameters?

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and couldn't find an answer
[x] After submitting this, I commit to one of:

Look through open issues and helped at least one other person: https://github.com/samuelcolvin/pydantic/issues/2280
Hit the "watch" button on this repo to receive notifications and I commit to help at least 2 people that ask questions in the future
Implement a Pull Request for a confirmed bug

Question
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
$ poetry run python3 -c "import pydantic.utils; print(pydantic.utils.version_info())"
             pydantic version: 1.7.3
            pydantic compiled: True
                 install path: /home/amn/.cache/pypoetry/virtualenvs/works.asm.heterogeneous-groups-nPjqETfo-py3.9/lib/python3.9/site-packages/pydantic
               python version: 3.9.1 (default, Jan 16 2021, 13:27:01)  [GCC 9.3.0]
                     platform: Linux-4.4.0-19041-Microsoft-x86_64-with-glibc2.31
     optional deps. installed: ['typing-extensions']

Second code sample from the initialize hooks section of the dataclasses section with some additional lines to showcase the weirdness:
from dataclasses import InitVar
from pathlib import Path
from typing import Optional

from pydantic.dataclasses import dataclass

@dataclass
class PathData:
    path: Path
    base_path: InitVar[Optional[Path]]

    def __post_init__(self, base_path):
        print(f'Received path={self.path!r}, base_path={base_path!r}')
        #> Received path='world', base_path='/hello'

    def __post_init_post_parse__(self, base_path):
        if base_path is not None:
            self.path = base_path / self.path

path_data = PathData('world', base_path='/hello')
# Received path='world', base_path='/hello'

If you add this line, everything goes as expected where it fails due to a type mismatch:
fails_on_type_validation = PathData(10, base_path='/hello')
"""
Received path=10, base_path='/hello'
Traceback (most recent call last):
  File "/home/amn/heterogeneous_groups/lib/pydantictest.py", line 30, in <module>
    path_data = PathData(10, base_path='/hello')
  File "<string>", line 4, in __init__
  File "pydantic/dataclasses.py", line 107, in pydantic.dataclasses._process_class._pydantic_post_init
    #    +--- order= parameter
pydantic.error_wrappers.ValidationError: 1 validation error for PathData
path
  value is not a valid path (type=type_error.path)
"""

But if you use this line instead, you fail due to ints and paths not supporting the / operator:
fails_at_runtime = PathData('world', base_path=10)
"""
Traceback (most recent call last):
  File "/home/amn/heterogeneous_groups/lib/pydantictest.py", line 30, in <module>
    path_data = PathData('world', base_path=10)
  File "<string>", line 4, in __init__
  File "pydantic/dataclasses.py", line 111, in pydantic.dataclasses._process_class._pydantic_post_init
    # +=======+=======+=======+
  File "/home/amn/heterogeneous_groups/lib/pydantictest.py", line 21, in __post_init_post_parse__
    self.path = base_path / self.path
TypeError: unsupported operand type(s) for /: 'int' and 'PosixPath'
"""

Here it throws an error right away because of the usage of this operator, but what happens if instead of division it was being added to an array?  In my actual usecase, it passed a raw dict through instead of converting it into the custom dataclass specified in the annotation; consequently, when I tried to access that variable's attributes it failed due to a dict not having those attributes.
Am I misunderstanding what InitVar is supposed to do?  I just thought it meant that that variable wouldn't become an instance variable and that it would additionally be sent to the __post_init__ func (and __post_init_post_parse__ func), not that it wouldn't be validated and converted into the types specified in the annotation.

Hi @Amndeep7
I agree this is not explicit in the documentation but InitVar are not parsed by pydantic.
This is due to the fact the pydantic model for dataclasses is based on dataclasses.fields: https://github.com/samuelcolvin/pydantic/blob/master/pydantic/dataclasses.py#L147 which does not contains the InitVar fileds.

@rhuille Thank you for the explanation!  Looked it up in the python stdlib documentation and there it was plain as day too.
I guess this is where this line of the documentation becomes more relevant if I don't want to manually cast things: "There are cases where subclassing pydantic.BaseModel is the better choice [over dataclasses]."


Resizing Optical Flow

The image resolution seems really huge for the model that I am training and I would prefer to downscale it to a smaller shape. however, the optical flow groundtruths cannot be resized the same way. Any suggestions on how to do this  ?

One approximate solution is to resize the flow, and divide the value by the resize scale. There would be some error on the edges of course. Would this be enough for your use?


Aa for phylip

Coverage decreased (-1.1%) to 92.39% when pulling 18b44f9bafe2b1bf56b8302e5b958f3fccaf8c63 on aa_for_phylip into c89c4ef8f56aaa1e5fae32f528333c25efbd1013 on master.


Lack of information about is:merged and is:unmerged filters for Pull Requests queries

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
content/issues/tracking-your-work-with-issues/filtering-and-searching-issues-and-pull-requests.md
What part(s) of the article would you like to see updated?
it's a small but valuable update: adding is:merged and is:unmerged filters for Pull Requests queries
It can help with combining with other filters such as is:closed
Additional information
No response

@ko23 Thank you for opening an issue and linking it to your PR! ✨


Support pkcs8 from Apple APNs ?

Due to Apple APNs token authoration need jwt, and the privaite key is .p8, so how about add a function like this

// Parse PEM encoded Elliptic Curve Private Key Structure
func ParsePKCS8PrivateKeyFromPEM(key []byte) (*ecdsa.PrivateKey, error) {
    	var err error

	    // Parse PEM block
    	var block *pem.Block
	    if block, _ = pem.Decode(key); block == nil {
	         	return nil, ErrKeyMustBePEMEncoded
	    }

	    // Parse the key
	    var parsedKey interface{}
	    if parsedKey, err = x509.ParsePKCS8PrivateKey(block.Bytes); err != nil {
		         return nil, err
	    }

	     var pkey *ecdsa.PrivateKey
	    var ok bool
	    if pkey, ok = parsedKey.(*ecdsa.PrivateKey); !ok {
		    return nil, ErrNotECPrivateKey
	}

	return pkey, nil
}

Is PKCS6 encoding common for elliptic curve keys?  I didn't include decoders for those keys because I couldn't find consensus around popular encoding schemes.
The RSA ones are there as a historic artifact.  We used to do that automatically, but that turned out to be not a great idea.  Rather than totally remove that feature, I just included it as a helper.  It seems like it should be out of scope for this library to include helpers for every encoding technique for every type of key.
What do you think?

As I know,  the Apple APNs service need PKCS8  encoding for ES256 to generate jwt string.   and maybe    you are right, it's not necessary to support every type of key.


fixed issue with empty lines in parseFfprobeOutput

Sometimes the ffprobe output would include empty lines, which would fail the while(line) checks, so I changed them to while(line != undefined).

Rewrote your commit, x != undefined is very bad practice.


Rewrite decode_entities to ignore unknown and invalid entities

Coverage increased (+0.009%) to 59.176% when pulling 8e904d009673d973a06e89aa2fe55fd8fae3d452 on the-blank-x:html-entity-missing into 4256197cfa3d283e782a86a4765c7cbff32be0f8 on newsboat:master.

Sorry I still haven't got around to reviewing this! I hope I'll get to it by the end of the week.

Oops, forgot the test when I rebased the branch

Cool, thanks a lot for the PR!


Failed to call service media_player/play_media.

Hi,
I tried to implement your lovelace card, i love the look of it, but having some issues
  - type: "custom:spotify-playlist"
    entity: sensor.playlists
    media_player: media_player.spotify
    columns: 3
    size: '140px'
    show_name: false
    show_title: false
    title: 'My Playlists'

when i use this i get an error saying it can't find, if i change spotify-playlist to spotify-playlist-card it will show the cards (https://github.com/dnguyen800/Spotify-Playlist-Card/blob/master/spotify-playlist-card.js from the bottom javscript), but it wont play anything when i click on card

Failed to call service media_player/play_media.
when i click on the playlist

I'll revisit this issue soon as I plan to make some changes to make this card compatible with the Spotcast custom component.

You found a mistake in the README documentation--thanks for pointing that out.
If you can provide some more information about your setup--what speaker are you using to play the Spotify music? I only have Chromecast speakers and thus only tested this card and Spotcast together. If you are using media_player.spotify as the speaker_name, there is a limitation with Spotify that prevents playback of music on an idle device. The workaround is to play Spotify on a device, then try pressing a button on this card. If that doesn't work, let me know.


Operations Should Work on Generic Vector Type

As discussed here, the argmax operation works on SparseVector and on DenseVector, but not on Vector. This might be true for other operations as well. Every vector operation should also work on the generic Vector type so that interfaces do not need to consider which implementation other methods use internally.

I fixed operations like argmax yesterday, but yeah more work to do. I guess I should figure out a good way to enforce this programmatically

OK, I now have a generic framework in place for ensuring that UFuncs support the various operations for types. There are known issues, but this
All this would be so much easier if contravariance in Scala's implicit resolution wasn't totally broken.

i'm going to close this because I have a framework in place for ensuring things like this don't happen. Coverage isn't perfect, I'm sure, but this bug isn't really actionable.


Agent pool offline

Agent service status show running.   But when I queue the job on Azure pipeline, azure says an agent is offline.  The agent pool is enabled.
I'm on redhat 7.
Everytime, I still have to trigger ./run.sh manually.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23328b13-f079-ad21-5d7a-6c640f25391c
Version Independent ID: 4a39889d-fa00-ae2b-aa43-f358631b7b1a
Content: Deploy a Azure Pipelines agent on Linux - Azure Pipelines
Content Source: docs/pipelines/agents/v2-linux.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

@pattarika Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a few options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

@vtbassmatt is this issue a candidate to be moved to one of your open source repos?

I'd start with one of the support links @thomps23 mentioned above.

Currently affected by this issue. Please advise.


Player is being stuck in certain tiles

The player can't pass certain tiles and being glitchy.

This is because path finding has not yet been implemented.

Im talking about actual movement, you can't pass between certain tiles when you can pass between others. I will record and add an attachment later on.

Yeah I know, you have to be exactly in the right position to be able to pass through 1 tile spaces. It’s because the movement we have right now isn’t actual path finding.

Fixed. The wizard was a bit too big to fit in one tile spaces, so I manually set the hitbox. 3350527


Request Access action is not implemented for international search results

We need to either hide it or implement the logic with the remoteHost query parameter.

It can't be implemented in this release because there's no endpoint to retrieve an anonymous user gene yet. Let's just fix this by hiding those results.


Missconfiguration in the API endpoint "/dojo_groups" due to "configuration_permissions"

Bug description
I have made a very big upgrade since 2.3.1 to 2.18.1 and some configuration permission has been implemented. In 2.3.1 I had some groups of users defined and now this error happens:
Internal server error occurs when calling API endpoint “dojo_groups”. I supposed this error happens because configuration permissions from “dojo_groups” have not been loaded yet when I call endpoint “/dojo_groups” or “/dojo_groups/{id}”.
Example: If I call a group through API that I have never visited before with “GET /dojo_groups/1” I receive a 500 Internal server error.
When I load this group from the DefectDojo UI I can see this group correctly and then, when calling again the API endpoint the information appears and 200 OK is received.
This must be a not completed performance of the function that process the request and doesn’t preload the configuration permission if this haven’t been created before.
Same error occurs when I try to get information of all “dojo_groups”.
I followed all the instructions in the UPGRADING.md notes to update version to version.
Steps to reproduce
To reproduce exactly my issue:

Deploy DefectDojo 2.3.1 and create some groups with users.
Then deploy with the same data DefectDojo 2.18.1 and don’t visit through DefectDojo UI the groups which you created before.
Call the API endpoint “/dojo_groups” and then you will receive a 500 Internal Server Error
If then you visit all those groups and call again the API endpoint, will receive the information correctly.

Expected behavior
The expected behavior is when I call through the API a group that has not set the configuration permissions by default, the function that receive the request must set it as happens while trying to access to this group in the UI.
Deployment method

[X] Docker Compose
[X] Kubernetes
[ ] GoDojo

Environment information

Operating System: Not relevant
DefectDojo version (see footer) or commit message: Since DefectDojo version 2.12.0 (when configuration permission API endpoint was implemented) to latest version.

Screenshots

Get all groups:

Get group 39:

Error log:

Get group 39 in the UI:

Now get the group 39 through API again:

This can be closed as fix was merged @mtesauro


AMBARI-23898. Server posts numerous redundant metadata updates to agent.

What changes were proposed in this pull request?
Now server posts metadata updates to agent only when metadata was actually changed, added the same for host level params. Also default stomp messaging thread pool size was increased to prevent heartbeat timeout when server-agents messaging is intense.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2372/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2373/
Test PASSed.


”Măgherani”, ”Șilea Nirajului”, ”Torba” are listed in the drop-down menu

Description:
When user writes ”Măgherani”, ”Șilea Nirajului”, ”Torba” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Măgherani"

Expected results
The location appears in the drop-down menu as "Sat Măgherani, MUREȘ (Măgherani)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Șilea Nirajului"

Expected results
The location appears in the drop-down menu as "Sat Șilea Nirajului, MUREȘ (Măgherani)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Torba"

Expected results
The location appears in the drop-down menu as "Sat Torba, MUREȘ (Măgherani)".


org.apache.druid.java.util.common.IAE: Should only have one interval

Affected Version
The Druid version 27.0.0-20230901-fefa9a3
Description
Druid supports list of intervals, but not when doing join over two groupBy queries.
Exactly the same error can be reproduced on short groupBy query over inline datasource.
{
  "queryType": "groupBy",
  "dimensions": ["user_id", "brand_name"],
  "granularity": "month",
  "aggregations": [
    {"fieldName": "weight", "name": "weight", "type": "longAny"}
  ],
  "intervals": [
    "2022-02/2022-03",
    "2022-04/2022-05"
  ],
  "dataSource": {
    "type": "inline",
    "name": "fake_datasource",
    "columnNames": ["__time", "user_id", "weight", "brand_name"],
    "rows": [
      [1643673600000, "A", 1, "Apple"],
      [1646092800000, "A", 2, "Apple"],
      [1648771200000, "A", 3, "Apple"]
    ]
  }
}

Output
Error: RUNTIME_FAILURE (OPERATOR)

java.util.concurrent.ExecutionException: org.apache.druid.java.util.common.IAE: Should only have one interval, got[[2022-02-01T00:00:00.000Z/2022-03-01T00:00:00.000Z, 2022-04-01T00:00:00.000Z/2022-05-01T00:00:00.000Z]]

java.lang.RuntimeException

Query works when interval is replaced just with "2022-02/2022-05". See query and output here
{
  "queryType": "groupBy",
  "dimensions": ["user_id", "brand_name"],
  "granularity": "month",
  "aggregations": [
    {"fieldName": "weight", "name": "weight", "type": "longAny"}
  ],
  "intervals": [
    "2022-02/2022-05"
  ],
  "dataSource": {
    "type": "inline",
    "name": "fake_datasource",
    "columnNames": ["__time", "user_id", "weight", "brand_name"],
    "rows": [
      [1643673600000, "A", 1, "Apple"],
      [1646092800000, "A", 2, "Apple"],
      [1648771200000, "A", 3, "Apple"]
    ]
  }
}

Output
timestamp			user_id		weight		brand_name
2022-02-01T00:00:00.000Z	A		1		Apple
2022-03-01T00:00:00.000Z	A		2		Apple
2022-04-01T00:00:00.000Z	A		3		Apple

do you have a use-case where you would want to have more than two intervals for datasources such as join or inline?

On a business layer I have some months hidden, so I split the interval to not obtain results for those, but for some reason druid does not support join over two groupBy queries.
As a workaround I had to query druid in a loop.

You could also push the intervals into the group-by queries being joined.


[Bug]: Scroll Down Progress Bar Not Working Properly

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Hey @apu52
The scroll-down progress bar on the website is not working properly,

The Bar completes even if the page is not scrolled up to the bottom
The scroll down progress bar does not match with the design theme (it should have disco light effect just like the other components)
The size is not suitable according to the body content size

Expected behavior
N/A
Add ScreenShots

https://github.com/user-attachments/assets/df9fc862-58df-43d7-9b44-447a04adc013
On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I'm a SSOC'24 contributor
[X] I have starred the repository

@MastanSayyad in which open source programme u are contributing??

@MastanSayyad in which open source programme u are contributing??

Sorry for the confusion, it is gssoc!


Try out some new UI build tooling

The randomly failing UI builds have been bothering me, so I decided to try out a few alternative front-end build tools to try and make things better. This makes it so we stop using the (very slow) Typescript compiler except for type-checking (i.e. we no longer use it for transpiling code) and remove the project references. Instead, this has been replaced with:

Turborepo: this is basically a task runner for UI monorepos that is aware of your package structure/dependencies and can then run tasks in the correct order. This means, for example, each package can have its own build script and Turborepo will figure out what order to run them in based on dependencies in the package.json files.
tsup: this compiles our library packages (i.e. everything but app) using esbuild underneath to transform the code. It outputs both ESM and CJS builds in one go, meaning we no longer need a separate build step in CI for it.
esbuild: this is a really fast Typescript compiler writting in Golang. It doesn't do type-checking (or emit type declarations) so we still have to do that separately using the official tsc, but the performance gains are pretty great. I've plugged this into our webpack build and like I mentioned above, it also powers tsup.

I did a few totally unscientific tests on my M1 Mac locally just to see if this is actually any faster.
Dev Server Times
How long does npm run start take before webpack serves the bundle, both for an initial run with no cache, then quitting the initial run and restarting the server with a cache from the first run.

Description
No Cache
Restart with Cache

Old
18s
11s

New
16s
7s

Overall a modest improvement.
Build Times
Basically, how long does npm run build take. Nothing is cached (just like on the CI server).

Description
Build for ESM
Build for CJS
Total

Old
30s
12s
42s

New
18s
0s
18s

Here we can really see the benefits, partly because we can do both ESM and CJS builds in one go now. Hopefully this should help a lot with our CI jobs.
Speed improvements weren't my main goal here, although I suspect the difference will be probably become more pronounced the larger the codebase gets (and the more work tsc would have to do to compile things). Stability was my main goal and trying to prevent some of the flakiness we've been seeing with builds. I'm hoping this will have a positive impact there.
I'd like for us to try this setup out for awhile and see if it's actually a better experience. If there are issues that crop up and we can't fix them, we can always just revert and go back to tsc and project references.
Future Improvement Ideas

See if TurboRepo's remote caching feature is worth enabling. This would allow us to share a remote cache across both dev machines and CI servers.
Investigate vite or parcel as an alternative to using webpack. I don't think we'd get a ton of gain from this yet since most of our code is in packages that are compiled separately, but it might be worth checking into eventually.
See about using something like @swc/jest to speed up Jest test compilation. Our test suites are pretty small right now so it's not super urgent, but this could become a bigger issue soon.

The CI results look promising. Here's a recent run before the change where it looks like the 2 UI build tasks took about 2 minutes total to finish. It looks like it takes about 1 minute now in this PR.


Give a different warning when overriding hashCode without operator==

In the following code:
class Foo {
  String name;
  @override
  int get hashCode => name.hashCode;
}

The analyzer warns info: Always override hashCode if overriding ==. when it should say  info: Always override == if overriding hashCode.
Version: Dart VM version: 2.3.1-dev.0.0.flutter-a0290f823c (Thu May 9 07:43:56 2019 +0000) on "linux_x64"

cc @pq

Great catch.  Thanks @gspencergoog.

/move to dart-lang/linter


Add general command capabilities to redis bindings

Description
As pr #2068 said, redis binder lacks other operation commands besides set
Issue reference
Please reference the issue this PR will close: #2068

Hi @wxbty thanks for the contribution!
I’m afraid I am not a fan of this approach however. I agree that the Redis binding needs lots of work and needs to support at least the operations described in #2068.
However, I don’t think that we should offer the ability to execute general commands. Three reasons:

First and foremost, security. Being  able to execute any command comes with a lot of power to do a lot of things, including things that developers shouldn’t be able to do.
Then, when we offer operations in bindings, we try to have them accept parameters in a consistent structure and return an optimized data structure. To do that, we need to know the exact operation that’s being executed
Lastly, the ability to perform general command goes against Dapr’s philosophy of abstracting components. Although bindings aren’t as abstract as, say, state stores, this really requires understanding the Redis commands and it’s not what Dapr aims to do.

If you make a PR to accept a subset of commands like in #2068, however, that would be more than welcome!

Hi @ItalyPaleAle thanks for your reply!
I hope to continue contributing。As you said, there are still a few doubts。
1、Pr @2068 only mentioned “delete” and “get” ，do we not need other frequently used operations?
2、Now there is only one invoke method, do you want to add deleteInvoke and getInvoke methods? Or an invoke is distinguished by parameters


Add option preserveExecutable to IO.copyFile and IO.copyDirectory

Fixes sbt/sbt#944
Forward port of
https://github.com/sbt/sbt/commit/1e61b9acf34b7d89a54a5adc021cc37cd3ecd0ef
Part of https://github.com/sbt/sbt/issues/2384

To validate this pull request against other sbt modules, visit THIS LINK.

You can evolve by just appending to the end.
These methods have 3 optional booleans, how would you like to overload them?

def copy(sources: Traversable[(File, File)]): Set[File]
def copy(sources: Traversable[(File, File)], options: CopyOption): Set[File]
def copy(sources: Traversable[(File, File)],
      overwrite: Boolean,
      preserveLastModified: Boolean,
      preserveExecutable: Boolean): Set[File]

where CopyOption is defined using Contraband.

To validate this pull request against other sbt modules, visit THIS LINK.

@eed3si9n Done, but I'm concerned about the impact it has on users migrating from sbt 0.13 to sbt 1... Lemme know.

There might be some source breakages if ppl relied on the default params, but I think we did the best we can to make this evolvable, so I think it's an okay compromise.


🌱 Test: Reproduce parallel test issue

This PR is for testing and giving reference the prow issue coming form parallel feature test run. Where it was giving wrong JOB pass even though test failed in our Jenkins CI.
The goal is to show a filed run in Jenkins where one of the three parallel test failed and at least one job succeed. But PROW is marking this test as success.

/test metal3-centos-e2e-feature-test-main

Do we still need this?

we can close this


[SDK screenplay] User/Instance/Image/Volume operation

WHY:

Write the script to know how to use SDK.

HOW:

Add ipynb files into screenplay folder.

Signed-off-by: LiuYuWei<EMAIL_ADDRESS>

Let's merge it first, then do the review on a real Notebook.


Did the vsicons.presets.foldersAllDefaultIcon get removed?

I noticed recently that my plain boring folder icons have now started showing some custom icons. I want my files to use the icons from this pack, but have my folders remain as just plain folder icons.
Version: 7.23.0

@mcfarljw, did @JimiC 's advise fix your issue?

No, I still see special folder icons based on the name rather than default
identical ones.
On Sun, May 13, 2018, 5:14 PM Roberto Huertas<EMAIL_ADDRESS>wrote:

@mcfarljw https://github.com/mcfarljw, did @JimiC
https://github.com/JimiC 's advise fix your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vscode-icons/vscode-icons/issues/1562#issuecomment-388656504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-WrdWB-Kg3nFChiBMnp5Z81y_hQeuYks5tyKJPgaJpZM4TqUaA
.

So, you have "vsicons.presets.foldersAllDefaultIcon": true in your USER SETTINGS (not the Workspace settings!) and yet you see special folder icons? It should be working. I've just tried and cannot reproduce your issue.
Have you tried reinstalling the extension?

This has happened twice to me in the past couple of months. Toggling from true => false => true resolves the problem, but there is still a problem somewhere.

F1 > Apply Icons Customization should always fix any issues.

The only case I can think of is when the extension fails to be loaded after the icon-manifest was rebuild. In that case, the icons are displayed as they were in the previous icon-manifest. A useful move would be to navigate to the editor's menu Help > Toggle Developer Tools and post any errors logged.


Fix missed Ghost->Subtle in previous merge

Fixing some missed Ghost->Subtle rename in last merge.

/azp run

/azp run


Improve MMM base example notebook

Add more effect plots to explain the cumulative and share channel effects. This is a followup of https://github.com/pymc-labs/pymmmc/issues/21

I will close this one as it diverged from the initial notebook draft. Most of the plots are already in master.


Crash Simulation

Hi there!
My company moving from Crashlytics to Sentry for our React Native App.
I have successfully add the Sentry for React Native. But how I can sure it installed correctly?
Do you have any code to call, to simulate a crash?
Crashlytics have this sample function to call to make a crash event:
React Native Fabric
// Forces a native crash for testing
Crashlytics.crash();

There is also a function called Sentry.nativeCrash()
https://docs.sentry.io/clients/react-native/config/
That will trigger a crash in the native code.
If you want to try catching a JS exception, just throw a new Error('something')


Bug fix, make sure delete k8sService de-registering targets

What type of PR is this? bug fix for #331

Which issue does this PR fix:  bug fix for #331
What does this PR do / Why do we need it:

make sure model_build_targetgroup.go and model_build_targets.go don't return too early so that when handing k8sService deletion event, route_controller.go could finally hit targetsSynthesizer.Synthesize(ctx) to deregister the targets
Add a new field K8sServiceExists bool in TargetGroupSpec. Do targetGroupManager.Create() in SynthesizeTriggeredTargetGroupsCreation only if corresponding K8sServices exist

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Use  my-hotel-gateway.yaml, inventory-route-path.yaml(modified version, have 2 Kind:Service backendrefs), inventory-ver1.yaml, inventory-ver2.yaml to test various 2 k8sServices and httproute creation and deletion orders, all looks good
Automation added to e2e:

un-commented one previous failed e2etest, whole e2etest suite can pass

Ran 29 of 29 Specs in 1928.783 seconds
SUCCESS! -- 29 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (1929.29s)
PASS

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I once discussed with @solmonk before I send this PR, I think we have 2 main directions to fix this bug:
1.1 Use route_controller.go and its underlying code path to de-registering targets. While keep k8sService don't having finalizer. For all client.Get(ctx, svc), keep them return empty but still go ahead to build mode latticeTargets mode (Current PR implimentation)
1.2 Use route_controller.go and its underlying code path to de-registering targets. While add k8sService finalizer in service_controller.go and remove k8sService finalizer at the end of route_controller.go, in that case client.Get(ctx, svc) can return k8sService when trying to de-registering targets.
3. Use service_controller.go to de-registering targets. Add and remove serviceFinalizer in service_controller.go, when handling deleting service, do mapToAllRoute() and deregister all related TargetGroups' targets, and keep route_controller.go code don't change  (This is the  straight-forward way that @mikhail-aws mentioned)
My understanding is option1.1 is the best way from my discussion with @solmonk? Any comment from @solmonk?

If a backend service is not found, the thing we should do is:

to set Route's ResolvedRef status as false and gracefully move on.
Deregister targets as a part of regular endpoint sync logic.

I'm yet to review the details but I believe at least "skip errors when backend service is not found" is a right approach to take.

PR #255. should fix de-register targets of deleted service.  Please find out why there is a regression and fix that regression .

Thanks, will take a look how to set ResolvedRefs status https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io%2Fv1beta1.HTTPBackendRef

Discussed with solmonk, that can be a regression, as when we did this refactoring, we did not consider "delete k8sService de-registering targets" use case.
service_controller.go
Will revivie part of (r *serviceReconciler) reconcileTargetsResource() code as the straight-forward fix.
Will create a backlog task for this idea as a long term improvement:
If a backend service is not found, the thing we should do is:
    to set Route's ResolvedRef status as false and gracefully move on. (status part could be addressed later)
    Deregister targets as a part of regular endpoint sync logic.

Will use this way to solve this bug  #387


usability: message for no resources found

When the cluster doesn't have required resources, display a helpful message instead of displaying nothing.
In my cluster that doesn't have any pools setup at, I get the following:
kiran_mova_mayadata_io@kmova-dev:~$ kubectl openebs get storage
kiran_mova_mayadata_io@kmova-dev:~$

It would nice to display a message like this:
kiran_mova_mayadata_io@kmova-dev:~$ kubectl get cspc
No resources found in default namespace.

Also, while at this - check the message displayed when there is no openebs installed in the cluster.

Okay starting notes on implementation:

For the volume & storage sub-commands, the code can run a single function(when cas-type is given in via flags) or run all functions when no cas-type flags are given.
The code under interest is, pkg/storage/storage.go, pkg/volume/volume.go, pkg/persistentvolumeclaim/persistentvolumeclaim.go & pkg/blockdevice/blockdevice.go
If a single function is executed(i.e. cas-type is supplied), a standard message & a standard error can be thrown by that cas-implementer function
When cas-type isn't supplied, the errors might be stored in a slice & shown accordingly(a volume is a PersistentVolume, but a storage can be a two or three different kinds of resources, so having all errors would help)

For more help, do join the OpenEBS-Dev slack.

Working on it.


Tabbing homepage

resolves #7

tabbing through Register, Sponsor, & Join buttons
tabbing through social media icons

unable to identify focus for the volume button, I'm unsure if it's rooted in how we implemented it or maybe TWCSS just not speaking to it but I tried placing the focus properties in multiple locations and nothing was rendering

This is broken on Firefox and Safari. That being said, it does work on Chrome so I guess it is better than what we currently have.


When mat-select is touched  (by code) it is not showing the error.

Bug, feature request, or proposal:
When submitting a form and explicit set all controls to touched the mat-select control is not updated via Input binding with FormGroup. It looks like it has something to do with focus maybe? As I need to click on a other element to get the mat-error
Don't know if the way I have made the form is the best approach maybe you can clarify on that a bit.
What is the expected behavior?
Would like to see that the validation is handled and the mat-error is shown
What is the current behavior?
Stays the same until I clicked the mat-select
What are the steps to reproduce?
StackBlitz  : Example Url
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular: 5.1.0
material: 5.0.0
Is there anything else we should know?
Thanks for the GREAT work!

FWIW this appears to simply be a symptom of OnPush. The inputs on SelectComponent don't change and the submit event is occurring in SelectErrorStateMatcherExample, so change detection isn't being run on SelectComponent.

:roll_eyes: okay (a bit of shame that I missed that one)
Removing the OnPush indeed works for the way I would like to visual have it. @willshowell still wondering if I'm doing the correct implementation then. Thoughts on it if i'm doing it wrong if so I will close the issue.

I spent some time looking into it and it doesn't seem like there's much we can do on Material's side to react to changes in the touched state. The Angular forms don't have a stream that we can subscribe to when it changes and the dirty checking that we do won't happen when the control is nested inside a component with OnPush. You can work around it either by switching away from OnPush, moving the select out of the component, or calling markForCheck from inside the component when the control becomes touched.


Response pauses indefinitely after 360MB

I'm hitting a problem when downloading this file with reqwest and rusttls: https://chromium-browser-symsrv.commondatastorage.googleapis.com/chrome.dll.pdb/93B17FC546DE07D14C4C44205044422E1/chrome.dll.pdb
The download stops after around 360MB, and the response.chunk() future never completes.
I've put a full reproduction here: https://github.com/mstange/reqwest-with-rusttls-stops-after-360mb
The bug only occurs when using the reqwest feature rusttls-tls. I think this means that it only happens if the request is made using HTTP/2.
The bug also only occurs when downloading the gzip-compressed version of the file.
Steps to reproduce:

Clone the following repo: https://github.com/mstange/reqwest-with-rusttls-stops-after-360mb
Inside the local clone, run cargo run --release
Wait for a 640MB download to complete.

Expected results:
The program should complete and print Done! Downloaded 639588034 bytes in total.
Actual results:
The program stops downloading after around 360MB. The last printed line is usually something like Downloaded 361462551 bytes.
And then the response.chunk() future just never completes.
Workarounds
Any of the following changes make the download complete successfully:

Change https:// into http:// in the URL.
Remove the Accept-Encoding: gzip header.
Edit Cargo.toml to use "default-tls" instead of "rustls-tls" (causes HTTP/1.1 to be used)

The file can be downloaded successfully with curl -o chrome.dll.pdb --compressed "https://chromium-browser-symsrv.commondatastorage.googleapis.com/chrome.dll.pdb/93B17FC546DE07D14C4C44205044422E1/chrome.dll.pdb", which also uses HTTP/2. It decompresses to a 3GB file.
System configuration
I'm hitting this bug on macOS 13.1, with Rust 1.67.0.
Full code
src/main.rs:
#[tokio::main(flavor = "current_thread")]
async fn main() {
    eprintln!("Downloading chrome.dll.pdb...");
    let url = "https://chromium-browser-symsrv.commondatastorage.googleapis.com/chrome.dll.pdb/93B17FC546DE07D14C4C44205044422E1/chrome.dll.pdb";

    let client_builder = reqwest::Client::builder();
    let client = client_builder
        .no_gzip()
        .no_brotli()
        .no_deflate()
        .build()
        .unwrap();
    let builder = client.get(url);
    let builder = builder.header("Accept-Encoding", "gzip");
    let mut response = builder.send().await.unwrap();

    let mut downloaded_len = 0;
    let mut last_reported_len = 0;
    while let Ok(Some(chunk)) = response.chunk().await {
        downloaded_len += chunk.len();
        if downloaded_len >= last_reported_len + 1_000_000 {
            eprintln!("Downloaded {downloaded_len} bytes.");
            last_reported_len = downloaded_len;
        }
    }

    eprintln!("Done! Downloaded {downloaded_len} bytes in total.");
}

Cargo.toml:
[package]
name = "reqwest-with-rusttls-stops-after-360mb"
version = "0.1.0"
edition = "2021"

[dependencies]
reqwest = { version = "0.11.14", default-features = false, features = [
    "stream",
    "rustls-tls",
    # "default-tls",

] }
tokio = { version = "1.25.0", default-features = false, features = [
    "macros",
    "rt"
] }

The bug only occurs when using the reqwest feature rusttls-tls. I think this means that it only happens if the request is made using HTTP/2.

I was trying to check whether rusttls or HTTP/2 is the cause, by setting the version to HTTP/1.1. However, with this change, the bug still occurs and I think it's still using HTTP/2 (based on the presence of h2:: functions in the profile):
diff --git a/src/main.rs b/src/main.rs
index f8c93fc..5fe252d 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -11,7 +11,9 @@ async fn main() {
         .build()
         .unwrap();
     let builder = client.get(url);
-    let builder = builder.header("Accept-Encoding", "gzip");
+    let builder = builder
+        .header("Accept-Encoding", "gzip")
+        .version(reqwest::Version::HTTP_11);
     let mut response = builder.send().await.unwrap();

     let mut downloaded_len = 0;

I can still reproduce this with reqwest 0.11.17

Switching reqwest to use default-tls and native-tls-alpn still reproduces the bug for me. Which suggests that it is indeed an HTTP2 issue and not related to the TLS library.

This issue still occurs on the hyper-v1 branch with h2 0.4.2.


Remove Unclear with concept? Watch this component and video from Assignment tab

Description
Bug
Video and source code is already present on the Learn Tab. So it is unnecessary to add same content on different tab.

Remove this section from all the assignments pages.

Hi @Vishal-raj-1, I have removed the video as mentioned in the issue.


Avoid SIGPIPE signals when connections break.

Make the use of CURLOPT_NOSIGNAL optional. Some applications need this
to avoid the signals generated by timeouts in DNS lookups, but
CURLOPT_NOSIGNAL does more than just disabling timeout signals, it also
enables SIGPIPE for closed connections (or more accurately: it disables
the automatic disabling of SIGPIPE), which can make the application
crash on broken connections.
I considered using the approach described here:
https://curl.haxx.se/mail/lib-2010-11/0008.html
but that is problematic on libraries supporting multi-threaded
applications.

This change is

After further thought, this is not the right fix. Closing for now.


Errors when using vim (inside and outside of tmux)

AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
AddTabularPattern: Vim(let):E117: Unknown function: tabular#ElementFormatPattern
Error detected while processing FileType Auto commands for "":
E117: Unknown function: TagHighlight#ReadTypes#ReadTypesByFileType
Error detected while processing BufRead Auto commands for "":
E117: Unknown function: TagHighlight#ReadTypes#ReadTypesByExtension
Error detected while processing VimEnter Auto commands for "*":
E117: Unknown function: xolox#session#auto_load

I just ran into the same issue. Luckily I had my old laptop handy to compare the filesystems. Realized, I had some stale files like .gvimrc, .vimrc.after, etc pointing to some old settings. Cleaning them up fixed this error.


Use recursive mkdir commands

It tries to create nested directories and fail if such don't exist.

/cc @tsorya
/cc @eranco74


feat: add default language to nuxt.config

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/html#Accessibility_concerns
Apologies for picking English, but it seems surprisingly difficult to detect the system locale in a cross-platform manner.

Can we also set manifest.lang and fallback in case of pwa module not selected?


Custom font with ligatures

Is it possible to render font ligatures if the font supports it? E.g. I use FiraCode (see code snippet below) and want to render its ligatures inside a text box (e.g. for ->, ==, etc.). I'm pretty sure that the font loads correctly (it's not the default font that the text is rendered with) but there are no ligatures rendered.
FontFamily fontFamily = "resm:PlayAndLearn.Fonts.FiraCode.FiraCode-*.ttf?assembly=PlayAndLearn#Fira Code";

I am not sure how font ligatures work. FiraCode is just a font. Don't know if there is some special handling needed.

Yes I think it needs special treatment. I recently read about an issue concerning the treatment in WPF. I might have a look into this and you might get a PR at some point.

I'm not sure either exactly how it works, but font ligatures definitely must be supported by the app using them in order for them to work properly.  It's not as simple as simply utilizing a font.  Firacode is badass btw, best coding font ever (when lig's work) and if you get that working then you guys rock!

Fonts support embedded scripts and the render backend has to understand them properly. That is what goat want.

I think it can't be handled by Avalonia directly but must be adressed by the underlying rendering engine. I had a look at how Avalonia renders text using Skia and debugging took me no further than here because the rest is SkiaSharp's business.
I also had a look at VSCode's implementation of ligature support and the only hint I found was that large tokens are not being split if ligatures are enabled.
My (somewhat bold) guess is that SkiaSharp (or something underneath it) renders text token by token but should render them in token groups (so that the font can combine multiple tokens to a single glyph - the ligature). However I'm totally not sure if that's the case, I would have to dig much deeper into this.

Ligatures are just replacements for specific glyph combinations. If these combinations accure the involved glyphs are replaced by one glyph that belongs to that combination. This can be supported but I think there are other features that are more important at the moment.

As I said I don't think Avalonia is able to fix this because the problem seems to be somewhere downstream (at least for Skia I'm quite sure). Feel free to close this issue.


Langserver could not import module app.server

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
This is the code for my server.py
from fastapi import FastAPI
from fastapi.responses import RedirectResponse
from langserve import add_routes
from rag_conversation import chain as rag_conversation_chain

app = FastAPI()

@app.get("/")
async def redirect_root_to_docs():
    return RedirectResponse("/docs")

add_routes(app, rag_conversation_chain, path="/rag-conversation")

if __name__ == "__main__":
    import uvicorn

    uvicorn.run(app, host="<IP_ADDRESS>", port=8000)

Error Message and Stack Trace (if applicable)
INFO:     Will watch for changes in these directories:
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     Started reloader process [10212] using WatchFiles
ERROR:    Error loading ASGI app. Could not import module "app.server".

Description
I am trying to use the tool lanchain and langserver, and create a api from a template. Steps I took:

create server template

langchain app new my-app --package rag-conversation

copy in the code provided in the cmd after the installation is ready

@app.get("/")
async def redirect_root_to_docs():
    return RedirectResponse("/docs")

add_routes(app, rag_conversation_chain, path="/rag-conversation")

cd into my-app folder and run langchain serve in the cmd.
After which the server cant seem to start and throws this error

INFO:     Will watch for changes in these directories:
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     Started reloader process [10212] using WatchFiles
ERROR:    Error loading ASGI app. Could not import module "app.server".

Does anyone know how to aproach this issue. There is no -v command option so this is all the information I have to go by.
System Info
python -m langchain_core.sys_info:
System Information
------------------
> OS:  Windows
> OS Version:  10.0.22631
> Python Version:  3.12.2 (tags/v3.12.2:6abddd9, Feb  6 2024, 21:26:36) [MSC v.1937 64 bit (AMD64)]

Package Information
-------------------
> langchain_core: 0.1.31
> langchain: 0.1.12
> langchain_community: 0.0.28
> langsmith: 0.1.25
> langchain_cli: 0.0.21
> langchain_openai: 0.0.8
> langchain_text_splitters: 0.0.1
> langserve: 0.0.51

Packages not installed (Not Necessarily a Problem)
--------------------------------------------------
The following packages were not found:

> langgraph

pip freeze:
aiohttp==3.9.3
aiosignal==1.3.1
annotated-types==0.6.0
anyio==4.3.0
attrs==23.2.0
beautifulsoup4==4.12.3
build==1.1.1
CacheControl==0.14.0
certifi==2024.2.2
charset-normalizer==3.3.2
cleo==2.1.0
click==8.1.7
colorama==0.4.6
crashtest==0.4.1
dataclasses-json==0.6.4
distlib==0.3.8
distro==1.9.0
dulwich==0.21.7
fastapi==0.110.0
fastjsonschema==2.19.1
filelock==3.13.1
frozenlist==1.4.1
gitdb==4.0.11
GitPython==3.1.42
greenlet==3.0.3
h11==0.14.0
httpcore==1.0.4
httptools==0.6.1
httpx==0.27.0
httpx-sse==0.4.0
idna==3.6
installer==0.7.0
jaraco.classes==3.3.1
jsonpatch==1.33
jsonpointer==2.4
keyring==24.3.1
langchain==0.1.12
langchain-cli==0.0.21
langchain-community==0.0.28
langchain-core==0.1.31
langchain-openai==0.0.8
langchain-text-splitters==0.0.1
langserve==0.0.51
langsmith==0.1.25
markdown-it-py==3.0.0
marshmallow==3.21.1
mdurl==0.1.2
more-itertools==10.2.0
msgpack==1.0.8
multidict==6.0.5
mypy-extensions==1.0.0
numpy==1.26.4
openai==1.14.0
orjson==3.9.15
packaging==23.2
pexpect==4.9.0
pinecone-client==3.1.0
pkginfo==1.10.0
platformdirs==4.2.0
poetry==1.8.2
poetry-core==1.9.0
poetry-dotenv-plugin==0.2.0
poetry-plugin-export==1.6.0
ptyprocess==0.7.0
pydantic==2.6.4
pydantic_core==2.16.3
Pygments==2.17.2
pyproject_hooks==1.0.0
python-dotenv==1.0.1
pywin32-ctypes==0.2.2
PyYAML==6.0.1
rapidfuzz==3.6.2
regex==2023.12.25
requests==2.31.0
requests-toolbelt==1.0.0
rich==13.7.1
shellingham==1.5.4
smmap==5.0.1
sniffio==1.3.1
soupsieve==2.5
SQLAlchemy==2.0.28
sse-starlette==1.8.2
starlette==0.36.3
tenacity==8.2.3
tiktoken==0.6.0
tomlkit==0.12.4
tqdm==4.66.2
trove-classifiers==2024.3.3
typer==0.9.0
typing-inspect==0.9.0
typing_extensions==4.10.0
urllib3==2.2.1
uvicorn==0.23.2
virtualenv==20.25.1
watchfiles==0.21.0
websockets==12.0
yarl==1.9.4

@ZsomborHajzer , you should do uvicorn server:app


Added Compress PNG in Images Optimizers section and fixed "Images Optimizers" anchor

Added Compress PNG in Images Optimizers section and fixed "Images Optimizers" anchor

Nice!


GattCallback error : 133 on Android.

Steps to reproduce
App crashes suddenly.

"GattCallback error : 133 on Android."

(I guess it happens when it's getting low signal because it's little bit far from peripheral)
Crashlog
Configuration
Version: 1.0
Platform: Android
Device: Samsung Galaxy S4 (Lollipop)

I'm having this issue many times.

I put
gatt.close(); after disconnect();
problem seems gone so far.

We will look at  https://github.com/myallb/xamarin-bluetooth-le ^^

I am still facing this problem many times.
I am able to bond/pair with the BLE device but when I try to connect using
"Cross adapter.ConnectToDeviceAsync(BLEdevice)"  I am getting the following exception
"Plugin.BLE.Abstractions.Exceptions.DeviceConnectionException: GattCallback error: 133"
Device used : Samsung S7 android 6.0(marshmallow)
plugin version : Plugin.BLE.1.2.0-beta3

Does anyone has solution to this problem?

@allbdeveloper  , How to access "gatt" object ?? It is been abstracted by plugin .

You can't access it unless clone git project and build your own.
By the way, I recommend you to use try-catch in the place where you have a problem.
It worked for me and problem is gone.

Periodically there is such problem on a meizu pro6. I use a package 1.1.0

Same error here

Same error here

I get to see this error every now and then, too.
Is the missing gatt.close(); after the disconnect(); a problem for future connecting?

any updates?

var parameters = new ConnectParameters(true, true);
await adapter.ConnectToDeviceAsync(currentDevice, parameters, new CancellationTokenSource().Token);

var parameters = new ConnectParameters(true, true);
await adapter.ConnectToDeviceAsync(yourDevice, parameters, new CancellationTokenSource().Token);

I have resolved my Android issue using below code when connecting any device.
var parameters = new ConnectParameters(forceBleTransport: true);
await _adapter.ConnectToDeviceAsync(deviceToConnect, parameters, cancellationToken.Token);
Let me know if it works :)


FIX: completion handler is never called in method hideButtonsAnimated

completion handler is never called in method hideButtonsAnimated:completionHandler:

Fixed: https://github.com/Friend-LGA/LGPlusButtonsView/commit/412056e2d29ae6509d9ae0cc974dcb9f4b17d6b5


API Coverage - Implement SUNION

Here's your opportunity to implement a couple of RESP commands in Garnet!
SUNION
Syntax:
SUNION key [key ...]
Command description:
Returns the members of the set resulting from the union of all the given sets.
For example:
key1 = {a,b,c,d}
key2 = {c}
key3 = {a,c,e}
SUNION key1 key2 key3 = {a,b,c,d,e}

Keys that do not exist are considered to be empty sets.
Response:
Array reply: a list with members of the resulting set.

How to approach this task:

Add the new command info to the setCommandsInfoMap in the RespCommandsInfo class (Garnet.server/Resp/RespCommandsInfo.cs)
Add the new command string to the returned HashSet in the RespInfo.GetCommands method (Garnet.server/Resp/RespInfo.cs)
Add the appropriate fast parsing logic for the new command in the RespCommand.FastParseArrayCommand method (use other commands as reference) (Garnet.server/Resp/RespCommand.cs)
Implement the wrapper method to the storage layer in StorageSession (Garnet.server/Storage/Session/ObjectStore/SetOps.cs)
Define a new method in IGarnetAPI and implement it in GarnetApiObjectCommands, calling the method you have implemented in step #4 (Garnet.server/API/IGarnetAPI.cs, Garnet.server/API/GarnetApiObjectCommands.cs)
Add a new method to the RespServerSession class which will call the storage API and return the appropriate response (Garnet.server/Resp/Objects/SetCommands.cs)
Add a new method to SetObjImpl which will perform the required operation on the hash object (Garnet.server/Objects/Set/SetObjectImpl.cs)
Add a new enum value to SetOperation and add the appropriate case to the switch in SetObject.Operate, in which you will call the method defined in step #8 (Garnet.server/Objects/Set/SetObject.cs)
Add an appropriate case to the switch in TransactionManager.SetObjectKeys (Garnet.server/Transaction/TxnKeyManager.cs)
Add tests for the new command in the RespSetTests class (Garnet.test/RespSetTests.cs)

Tip: First add a simple test that calls the new command and use it to debug as you develop, it will make your life much easier!
If you have any questions, the Garnet team is here to help!

I want to give it a try

I want to give it a try

Go for it! LMK if you have any questions :)

@TalZaccai I need help with how to delete an existing key (especially if it is in the main store) when storing the value.

@TalZaccai Is there going to be a separate issue for SUNIONSTORE?

@TalZaccai Is there going to be a separate issue for SUNIONSTORE?

Yes, I was waiting for SUNION to be merged before posting :)


Warning: Conflicting return type in implementation of 'supportedInterfaceOrientations': 'NSUInteger' (aka 'unsigned int') vs 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') for the following

I get the following warning when I compile JSQMessagesViewController.m:
Conflicting return type in implementation of 'supportedInterfaceOrientations': 'NSUInteger' (aka 'unsigned int') vs 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') for the following:

(UIInterfaceOrientationMask)supportedInterfaceOrientations
{
if ([UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPhone) {
return UIInterfaceOrientationMaskAllButUpsideDown;
}
return UIInterfaceOrientationMaskAll;
}

I'd appreciate any help. Thanks!

You can safely ignore that error message or if you want to silence it, there are two ways of doing it.
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Woverriding-method-mismatch"
#pragma clang diagnostic ignored "-Wmismatched-return-types"
- (UIInterfaceOrientationMask)supportedInterfaceOrientations
#pragma clang diagnostic pop

OR
#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
- (NSUInteger)supportedInterfaceOrientations
#else
- (UIInterfaceOrientationMask)supportedInterfaceOrientations
#endif

PS: I prefer the second one.

Using Xcode 7 should not produce this warning.
Unless, maybe, you compiling for iOS 7?

Thansk @svtechnology ! :smile:

Conflicting return type in implementation of 'supportedInterfaceOrientations': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long')
warning semantic issue in xcode8.2.1

pls help me

(NSUInteger)supportedInterfaceOrientations
{
// we could have simply not implemented this, but we choose to call super to make explicit that we
// want the default behavior.
return [super supportedInterfaceOrientations];
}

(NSUInteger)supportedInterfaceOrientations
{
// we could have simply not implemented this, but we choose to call super to make explicit that we
// want the default behavior.
return [super supportedInterfaceOrientations];
}
Conflicting return type in implementation of 'supportedInterfaceOrientations': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long')
warning semantic issue in xcode8.2.1


Good Morning and Good Night Reacts

Have horace react with the sun emoji when someone says good morning and the crescent moon emoji when they say good night :)
But also make sure that he doesn't say it a second time to that person within a certain time frame

This is already being worked on in issue #36 (currently in PR #70 )


avoid case sensitive directory name

its not well handled irl. see proxyServer

Could you please give more information?


Allow disabling of collection parameter validation

Summary
This PR adds a config option to disable validate_collection_parameter checks.

Other Information

It feels like an overstep that this gem would require a particular pattern when defining a component's initialize method. As long as I set the correct instance variables, why shouldn't I be able to use an options hash if I wish?
When using dry-initializer, specifically, this validation results in useless initialize definitions like
class MyComponent < ViewComponent::Base
  extend Dry::Initializer

  option :item
  option :another_option

  with_collection_parameter :item

  def initialize(item:, **opts)
    super
  end
end

@patrickarnett thanks for opening this PR ❤
Might there be a way to have this functionality play nicely with Dry::Initializer? It does provide a helpful feedback mechanism to consumers that I'd rather avoid turning off.

Hi @joelhawksley. The changes in this PR would not affect default behavior for current or new installs.
As best I can tell, the validation provides guidance for users who may be unfamiliar with ::with_collection, and I'm not necessarily opposed to that. For some users like myself, however, the validation is an annoyance; my view components would work just fine without writing a redundant initialize method if only I could tell ViewComponent that I know what I'm doing.

It occurred to me last night that this PR still provides no means of including counters or iterators without defining initialize.

@patrickarnett that's a good point. Is there a way for us to introspect what Dry::Initializer has configured?

@patrickarnett that's a good point. Is there a way for us to introspect what Dry::Initializer has configured?

Maybe this? https://dry-rb.org/gems/dry-initializer/3.0/attributes/

I wouldn't want to get too specific to Dry::Initializer.
It seems the validation isn't entirely effective; if the initializer has the expected collection parameter as a positional argument, rather than a keyword argument, then validation will pass, but initialization will raise an ArgumentError. @joelhawksley What are your thoughts on checking for one of:

A key or keyreq argument with the expected name
Any keyrest, rest, or opt argument

With any of those, I believe we could be confident that the object is at least made available to the initializer.

@patrickarnett that seems fair to me 👍🏻