Crash when using two displays in Mojave

Environment: Two monitor setup in MacOS Mojave, version 1.6.0 (4025), Bezel interface and only default plugins.

Open an application in full screen mode and make sure it has focus.
Trigger Quicksilver -> Crash

Process:               Quicksilver [2226]
Path:                  /Applications/Quicksilver.app/Contents/MacOS/Quicksilver
Identifier:            com.blacktree.Quicksilver
Version:               1.6.0 (4025)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Quicksilver [2226]
User ID:               501

Date/Time:             2018-10-03 14:59:55.055 +0200
OS Version:            Mac OS X 10.14 (18A391)
Report Version:        12
Anonymous UUID:        9880B950-019F-7940-BF21-8BF85C835FF5

Time Awake Since Boot: 510 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
Assertion failed: (type == kCGImageComponent8BitInteger), function img_data_depth, file /BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreGraphics/CoreGraphics-1<IP_ADDRESS>/CoreGraphics/Images/CGSImage.c, line 5889.

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib              0x00007fff6dd70b86 __pthread_kill + 10
1   libsystem_pthread.dylib             0x00007fff6de26c50 pthread_kill + 285
2   libsystem_c.dylib                   0x00007fff6dcda1c9 abort + 127
3   libsystem_c.dylib                   0x00007fff6dca2868 __assert_rtn + 320
4   com.apple.CoreGraphics              0x00007fff40f59456 img_data_lock + 10766
5   com.apple.CoreGraphics              0x00007fff40f52db3 CGSImageDataLock + 1217
6   com.apple.CoreGraphics              0x00007fff40f5288f RIPImageDataInitializeShared + 177
7   com.apple.CoreGraphics              0x00007fff40f5241d RIPImageCacheGetRetained + 667
8   com.apple.CoreGraphics              0x00007fff40f51faa ripc_AcquireRIPImageData + 323
9   com.apple.CoreGraphics              0x00007fff40f51189 ripc_DrawImage + 898
10  com.apple.CoreGraphics              0x00007fff40f50df8 CGContextDelegateDrawImage + 47
11  com.apple.CoreGraphics              0x00007fff40f50567 CGContextDrawImageWithOptions + 471
12  com.apple.CoreGraphics              0x00007fff40f5037b CGContextDrawImage + 57
13  com.apple.AppKit                    0x00007fff3e1b48c6 __74-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke + 949
14  com.apple.AppKit                    0x00007fff3e1b431a -[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:] + 976
15  com.apple.AppKit                    0x00007fff3e1b3911 __71-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke.1381 + 1007
16  com.apple.AppKit                    0x00007fff3e103538 -[NSImage _usingBestRepresentationForRect:context:hints:body:] + 156
17  com.apple.AppKit                    0x00007fff3e1b3292 -[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:] + 1423
18  com.blacktree.QSInterface           0x0000000101d3f19b -[QSObjectCell drawObjectImage:inRect:cellFrame:controlView:flipped:opacity:] + 841
19  com.blacktree.QSInterface           0x0000000101d3dc06 -[QSObjectCell drawIconForObject:withFrame:inView:] + 386
20  com.blacktree.QSInterface           0x0000000101d3d9f8 -[QSObjectCell drawInteriorWithFrame:inView:] + 217
21  com.blacktree.QSInterface           0x0000000101d3d1c7 -[QSObjectCell drawWithFrame:inView:] + 1292
22  com.blacktree.QSInterface           0x0000000101d41bec -[QSObjectView drawRect:] + 140
23  com.blacktree.QSInterface           0x0000000101d4915e -[QSSearchObjectView drawRect:] + 835
24  com.apple.AppKit                    0x00007fff3e178205 _NSViewDrawRect + 66
25  com.apple.AppKit                    0x00007fff3e163002 -[NSView _drawRect:clip:] + 1745
...skipping...
25  com.apple.AppKit                    0x00007fff3e163002 -[NSView _drawRect:clip:] + 1745
26  com.apple.AppKit                    0x00007fff3e161ea3 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1400
27  com.apple.AppKit                    0x00007fff3e162369 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2622
28  com.apple.AppKit                    0x00007fff3e162369 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2622
29  com.apple.AppKit                    0x00007fff3e15ffa8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938
30  com.apple.AppKit                    0x00007fff3e15d50a -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 1887
31  com.apple.AppKit                    0x00007fff3e15cb49 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253
32  com.apple.AppKit                    0x00007fff3e159736 -[NSView displayIfNeeded] + 1300
33  com.apple.AppKit                    0x00007fff3e12d4e2 -[NSWindow _setFrameCommon:display:stashSize:] + 4015
34  com.apple.AppKit                    0x00007fff3e12c51d -[NSWindow _setFrame:display:allowImplicitAnimation:stashSize:] + 192
35  com.apple.AppKit                    0x00007fff3e12c456 -[NSWindow setFrame:display:] + 51
36  com.blacktree.Quicksilver.BezelInterfacePlugIn      0x000000010a1375f2 0x10a133000 + 17906
37  com.blacktree.QSInterface           0x0000000101d39d0b -[QSInterfaceController activate:] + 276
38  com.blacktree.Quicksilver           0x0000000101b7cc44 0x101b73000 + 40004
39  com.blacktree.QSFoundation          0x0000000101bf3703 -[NDHotKeyEvent performHotKeyPressed] + 216
40  com.blacktree.QSFoundation          0x0000000101bf4cff eventHandlerCallback + 487
41  com.apple.HIToolbox                 0x00007fff3fd8d8d9 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1502
42  com.apple.HIToolbox                 0x00007fff3fd8cc16 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 371
43  com.apple.HIToolbox                 0x00007fff3fdaa1cd SendEventToEventTarget + 39
44  com.apple.AppKit                    0x00007fff3e058530 -[NSApplication(NSEvent) sendEvent:] + 1844
45  com.blacktree.Quicksilver           0x0000000101b76c18 0x101b73000 + 15384
46  com.apple.AppKit                    0x00007fff3e045795 -[NSApplication run] + 755
47  com.apple.AppKit                    0x00007fff3e034e97 NSApplicationMain + 780
48  libdyld.dylib                       0x00007fff6dc32085 start + 1

I’ve seen that same crash, but wasn’t able to reproduce it intentionally. I was hoping you had figured it out, but I can’t seem to trigger a crash in front of any full screen apps.
Does it happen for any application? Does it seem to matter what’s selected in Quicksilver at the time? (The crash is related to displaying an icon.) Thanks.

Here's a new try of instructions to reproduce it, and it requires two screens (at least?):

Quit Quicksilver
Launch Quicksilver
Focus the screen without the QS animation
Trigger Quicksilver
Focus the screen with the QS animation
Trigger Quicksilver -> crash

Luckily, this gives a workaround. When starting Quicksilver, make sure to first trigger it on the screen with the QS animation. After doing that, I'm not experiencing any problems (I'll come back if I do).

Thanks. That still didn’t trigger the crash for me exactly. (I did get it to happen once trying various combinations of things on different screens, but I couldn’t get it to happen again.) I think we’re getting closer though.
One question about the steps above: Don’t you need to select something in the interface at some point? The crash happens when QS it trying to draw an icon, but just after launch, nothing is displayed.

Nothing is selected in the interface. It crashes on cmd-space (my shortcut) without anything being drawn. I'm able to consistently reproduce this like described above, and I also haven't had any crashes at all after "warming it up in the correct screen".

I'm seeing the same crash.
However, I can't reliably prevent it with @cdanielw's recipe.
Moreover, when I have a total of 3 screens, it reliably happens when focus is on any but the primary screen.
With 2 screens, it's spurious, but when it happens, it's always on the secondary screen.

Nothing is selected in the interface.

I set a breakpoint in that part of the code to see what it’s doing when nothing is selected, and… it never runs. I don’t see how it can if there’s no icon to draw.
Are you sure you don’t have something in place that might select an item automatically?

For me, it always draws the icon of the application that was selected with the previous invocation of QuickSilver. Or am I misunderstanding?

Right, @mikesperber. But in this case, the first step to reproducing was to quit and relaunch Quicksilver, which would clear any selections and start you with a blank interface.

Ah: So, like @cdanielw, I get the crash on the very first activation of the QS trigger after launch.
Backtrace look essentially the same, with some differences further down:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff625bdb86 __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff62673c50 pthread_kill + 285
2   libsystem_c.dylib             	0x00007fff625271c9 abort + 127
3   libsystem_c.dylib             	0x00007fff624ef868 __assert_rtn + 320
4   com.apple.CoreGraphics        	0x00007fff3583c370 img_data_lock + 9844
5   com.apple.CoreGraphics        	0x00007fff35835fa7 CGSImageDataLock + 1256
6   com.apple.CoreGraphics        	0x00007fff35835a60 RIPImageDataInitializeShared + 177
7   com.apple.CoreGraphics        	0x00007fff3583560e RIPImageCacheGetRetained + 661
8   com.apple.CoreGraphics        	0x00007fff35835134 ripc_AcquireRIPImageData + 293
9   com.apple.CoreGraphics        	0x00007fff358344a9 ripc_DrawImage + 707
10  com.apple.CoreGraphics        	0x00007fff358341d6 CGContextDelegateDrawImage + 41
11  com.apple.CoreGraphics        	0x00007fff358339b4 CGContextDrawImageWithOptions + 432
12  com.apple.CoreGraphics        	0x00007fff358337ef CGContextDrawImage + 51
13  com.apple.AppKit              	0x00007fff32aa88c6 __74-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke + 949
14  com.apple.AppKit              	0x00007fff32aa831a -[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:] + 976
15  com.apple.AppKit              	0x00007fff32aa7911 __71-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke.1381 + 1007
16  com.apple.AppKit              	0x00007fff329f7538 -[NSImage _usingBestRepresentationForRect:context:hints:body:] + 156
17  com.apple.AppKit              	0x00007fff32aa7292 -[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:] + 1423
18  com.apple.AppKit              	0x00007fff33135a7e __33-[NSStatusItem _updateReplicant:]_block_invoke_2 + 155
19  com.apple.AppKit              	0x00007fff331325db -[NSStatusItemReplicantView drawRect:] + 56
20  com.apple.AppKit              	0x00007fff32a6c205 _NSViewDrawRect + 66
21  com.apple.AppKit              	0x00007fff32a57002 -[NSView _drawRect:clip:] + 1745
22  com.apple.AppKit              	0x00007fff32a55ea3 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1400
23  com.apple.AppKit              	0x00007fff32a56369 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2622
24  com.apple.AppKit              	0x00007fff32a56369 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2622
25  com.apple.AppKit              	0x00007fff32a53fa8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938
26  com.apple.AppKit              	0x00007fff32a5150a -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 1887
27  com.apple.AppKit              	0x00007fff32a50b49 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253
28  com.apple.AppKit              	0x00007fff32a4d736 -[NSView displayIfNeeded] + 1300
29  com.apple.AppKit              	0x00007fff32a214e2 -[NSWindow _setFrameCommon:display:stashSize:] + 4015
30  com.apple.AppKit              	0x00007fff32a2051d -[NSWindow _setFrame:display:allowImplicitAnimation:stashSize:] + 192
31  com.apple.AppKit              	0x00007fff32a20456 -[NSWindow setFrame:display:] + 51
32  com.apple.AppKit              	0x00007fff33131ba3 __38-[NSStatusBarWindow setFrame:display:]_block_invoke + 122
33  com.apple.AppKit              	0x00007fff331481d3 -[NSSystemStatusBar _withAdjustmentDeferred:] + 27
34  com.apple.AppKit              	0x00007fff33131b1e -[NSStatusBarWindow setFrame:display:] + 141
35  com.apple.AppKit              	0x00007fff3313097a __90-[NSStatusBar(NSStatusBarCGS) _CGSinsertReplicantWindow:ofWindow:withDisplayID:withFlags:]_block_invoke + 104
36  com.apple.AppKit              	0x00007fff331480d4 -[NSSystemStatusBar _requestStatusBarAdjustmentWithCompletionHandler:] + 379
37  com.apple.AppKit              	0x00007fff3312d0ad __51-[NSStatusBar _updateItemsWithChangedActiveDisplay]_block_invoke + 74
38  com.apple.AppKit              	0x00007fff3312cda2 _NSStatusBarPerformWithUpdatesDisabledAndMenuBarCover + 1392
39  com.apple.AppKit              	0x00007fff3312d05d -[NSStatusBar _updateItemsWithChangedActiveDisplay] + 62
40  com.apple.CoreFoundation      	0x00007fff3544f306 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
41  com.apple.CoreFoundation      	0x00007fff3544f280 ___CFXRegistrationPost_block_invoke + 63
42  com.apple.CoreFoundation      	0x00007fff3544f1a1 _CFXRegistrationPost + 398
43  com.apple.CoreFoundation      	0x00007fff354575ed ___CFXNotificationPost_block_invoke + 87
44  com.apple.CoreFoundation      	0x00007fff353be13a -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1633
45  com.apple.CoreFoundation      	0x00007fff353bd4fd _CFXNotificationPost + 742
46  com.apple.Foundation          	0x00007fff3773fbab -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
47  com.apple.AppKit              	0x00007fff333573cb activeDisplayNotificationHandler + 116
48  com.apple.SkyLight            	0x00007fff5b354771 (anonymous namespace)::notify_datagram_handler(unsigned int, CGSDatagramType, void*, unsigned long, void*) + 629
49  com.apple.SkyLight            	0x00007fff5b35823c CGSDatagramReadStream::dispatch_next_main_queue_datagram() + 270
50  com.apple.SkyLight            	0x00007fff5b5ab14e invocation function for block in CGSDatagramReadStream::dispatch_main_queue_datagrams_async(dispatch_queue_s*, CGSDatagramReadStream*) + 59
51  libdispatch.dylib             	0x00007fff6242fd4f _dispatch_call_block_and_release + 12
52  libdispatch.dylib             	0x00007fff62430dcb _dispatch_client_callout + 8
53  libdispatch.dylib             	0x00007fff6243bf5f _dispatch_main_queue_callback_4CF + 1125
54  com.apple.CoreFoundation      	0x00007fff353eb147 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
55  com.apple.CoreFoundation      	0x00007fff353ea856 __CFRunLoopRun + 2335
56  com.apple.CoreFoundation      	0x00007fff353e9ce4 CFRunLoopRunSpecific + 463
57  com.apple.HIToolbox           	0x00007fff34683895 RunCurrentEventLoopInMode + 293
58  com.apple.HIToolbox           	0x00007fff346835cb ReceiveNextEventCommon + 618
59  com.apple.HIToolbox           	0x00007fff34683348 _BlockUntilNextEventMatchingListInModeWithFilter + 64
60  com.apple.AppKit              	0x00007fff3294095b _DPSNextEvent + 997
61  com.apple.AppKit              	0x00007fff3293f6fa -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1362
62  com.apple.AppKit              	0x00007fff3293975d -[NSApplication run] + 699
63  com.apple.AppKit              	0x00007fff32928e97 NSApplicationMain + 780
64  libdyld.dylib                 	0x00007fff6247f085 start + 1

Are you sure you don’t have something in place that might select an item automatically?

Yes, positive - nothing is selected. And I get the crash every time following my above steps. I also haven't had a single crash since following the workaround steps.

@mikesperber Yours seems to stem from the menubar icon updating in response to the active screen changing (activeDisplayNotificationHandler > NSStatusBar > NSStatusItem), while the first one is a response to a hotkey (NDHotKeyEvent > QSInterface > QSearchObjectView).
Just for clarification, is your "Application Specific Information" line the same ? Also, does it reproduce if you disable QS's menu bar item (I'm suspecting you have it, but it's just a hunch given the backtrace) ?

For whatever reason, I’m able to reproduce this at will today. I’m following the steps above8, but selecting something on the main screen before switching over.
I can catch it in the debugger as well, but that’s not telling me much. I was hoping to see the value of type and maybe figure out where it was coming from, but no luck.

malloc_history the c**p out of any pointers around NSImage/NSImageRep and check for the allocation stacktrace ? That should tell you who is "responsible" for those images. That might involve a bunch of x86_64 register wrangling and/or disassembling though 😉.

@tiennou Sorry for being late replying - just saw this.
It does reproduce even if the menu bar item is disabled.
For some reason, I don't get backtraces anymore, but I'm pretty sure that "Application Specific Information" was the same.

That should tell you who is "responsible" for those images.

Do you mean the code that’s creating the image? I was able to reproduce it with nothing selected using a different external monitor. In that case, it’s crashing in drawSearchPlaceholderWithFrame:inView:, which is quite a bit simpler.
I made it simpler still by replacing [QSResourceManager imageNamed:@"Find" with [NSImage imageNamed:NSImageNameInfo]. So now we’re using straight system code to load a system image, and it’s still crashing.
I’ve confirmed that it does matter which screen you display QS on first, but it’s not main vs. secondary display. It’s retina vs. non-retina. (If you display QS on a non-retina screen first, it won’t crash.) I’m pretty sure imagedNamed does some caching internally. My guess is that it’s somehow caching image representations that are only suitable for a retina display, so when it tries to draw on a non-retina screen… 💣.

I have change Mojave setting, is it relate?
defaults write -g CGFontRenderingFontSmoothingDisabled -bool NO

https://github.com/Microsoft/vscode/issues/51132#issuecomment-424132330

I have change Mojave setting for not using a high-DPI monitor, is it relate?

I’m pretty sure the crash is related to drawing images, not text, so probably not.

I'll get crashes almost every time I plug or unplug the external thunderbolt display. The external display is configured as main display when attached.
I don't have quicksilver configured to show the menu bar icon, only the icon in the dock.
This did not happen to me on my old macbook (10.13.6) only on the new one (now on 10.14.1).

For what it’s worth, building the app with Xcode 10 seems to fix this, but preferences look awful in dark mode and we’d have to finally say goodbye to the spinning QS logo on launch.

I just upgraded to Mojave and I'm also facing this issue.
For me, it seems like QS crashes every time my secondary display (the MacBook's own) gets activated.

Is someone actively working on fixing this? It's driving me nuts. Once again, I wish I had the skills to fix it :(

Is someone actively working on fixing this?

Not that I know of.

Once again, I wish I had the skills to fix it

Same here.

I build the current master myself - as mentioned by @skurfer - and the but disappeared.
Am I assuming correctly that the next public release should fix this issue, when released?

I build the current master myself - as mentioned by @skurfer - and the bug disappeared.

This crash goes away, but there are others that were far more common (for me anyway), so I went back to a version built with Xcode 9.

Am I assuming correctly that the next public release should fix this issue, when released?

Not necessarily. There are some other things out there worth releasing and as stated earlier, I don’t know if anyone’s looking at this.

I might be able to help, but when QS crashes for me, it does not show a stack trace anywhere. And when I build it from the repository, it doesn't crash. ¯_(ツ)_/¯
At least building it from the repo works.

@hirad Are you building with Xcode 9 or 10? I’ve only seen this crash with Xcode 9.
Quicksilver’s crash reporter doesn’t give you a way to open the report directly, but it should be available in the Console under “User Reports”.

@skurfer I was building Xcode 10. Now I tried with 9.4 and I can reproduce it. Very strange. It doesn't look like a Quicksilver bug at all. Seems like the solution would only be releasing an update that's built with 10?
I'm actually not sure what class of issue this is that only appears based on the build tool? 🤔

A build with Xcode 10 would be much appreciated - I've tried but have run into problems building it myself.

Ok, so it seems the crash is still there with Xcode 10 build but under different situation. I've now noticed QS crashes every time my computer falls asleep (or maybe when it's waking from sleep?).

Very strange. It doesn't look like a Quicksilver bug at all.

That’s what I’m thinking, but I’m not sure how to prove it reliably enough for a bug report to Apple.

Seems like the solution would only be releasing an update that's built with 10?

That makes things even worse, as it sounds like you’re discovering. I get constant crashes with the message “NSWindow drag regions should only be invalidated on the Main Thread!” I’m trying to track that down, but the real trick will be updating the preferences UI.

Another update: the crash of the Xcode 10 build is unrelated to two displays. I was just using my MacBook Pro on its own and QS crashed. Haven't had a chance to debug so far.

I can no longer reproduce this crash in 10.14.2. Maybe Apple fixed it. Can anyone confirm?

Metoo!

I can no longer reproduce this crash in 10.14.2. Maybe Apple fixed it. Can anyone confirm?

Confirmed.

Good. Let’s assume it was what it appeared to be all along: An OS bug.


Create Ingress2gateway version annotation and attach it to all Gateway resources

Ingress2gateway annotation will track the current version of the ingress2gateway tool. The version is currently a string that needs to be updated manually before release.
This annotation will be attached to the resulting Gateway resources during print since this is an output-only translation, and we can avoid interfering with existing Gateway translation tests.

Example output:
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  annotations:
    gateway.networking.k8s.io/generator: ingress2gateway-0.3.0
  creationTimestamp: null
  name: ...
  namespace: default
spec:
  gatewayClassName: ...
  listeners:
  - name: http
    port: 80
    protocol: HTTP
status: {}

What type of PR is this?
/kind feature
What this PR does / why we need it:
Create a dedicated annotation for Gateways translated via ingress2gateway tool to keep track of resources that we're generated with ingress2gatewa
Which issue(s) this PR fixes:

Fixes #179
Does this PR introduce a user-facing change?:

Gateways translated via ingress2gateway will be attached with a new annotation `gateway.networking.k8s.io/generator` to track resources generated with ingress2gateway tool and its version.

Would like some suggestion on the preferred format of this kind of annotation. I created the current one based on how ingressnginx specify proxy http version https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/annotations.md#proxy-http-version.
Two alternatives I can think of are:

gateway.kubernetes.io/ingress2gateway.version
ingress2gateway.gateway.kubernetes.io/version

/approve

Hi @sawsa307! Thank you for your contribution! I have one small comment in case we are going for this change. Since this feature requires manual version modification upon a new release, please update the RELEASE.md file with the appropriate steps.

Thanks for the comment Kobi! I've just added a section in RELEASE.md. Let me know if you have any suggestions on it, thank you!

Is there a reason we do it only for gateway?
Whats the rationale behind it?

Is there a reason we do it only for gateway? Whats the rationale behind it?

We could attach this in other resources like HTTPRoute, but I don't think we can gain any information with it since we can find all translated HTTPRoute based on the Gateways link to them.

Is there a reason we do it only for gateway? Whats the rationale behind it?

Actually I think this is a good point - might as well add this annotation to all generated resources so it's both more consistent and easier to keep track of where and GW API resource came from.

Is there a reason we do it only for gateway? Whats the rationale behind it?

Actually I think this is a good point - might as well add this annotation to all generated resources so it's both more consistent and easier to keep track of where and GW API resource came from.

Sure, just attaches this annotation on all translated Gateway resources.

@sawsa307 The release note mention kubernetes.io/ingress2gateway.version and the code "gateway.networking.k8s.io/generator" can you align them please?

I updated the release note myself to unblock.
/lgtm Thanks David!

/lgtm


Render plain text for messages sent in attachments and remove the header

Description
Changes proposed in this pull request:

Slack: large executor output is sent as plaintext files with a related message.
SlackSocket: large executor output is sent as plaintext files with a related message.
Discord: large executor output is sent as plaintext files with a related message.
MatterMost: large executor output is sent as plaintext files with a related message.
MSTeams: large executor output is sent as plaintext files with a related message.
Adde E2E tests to check file uploads and related messages.

Test

Checkout this branch: gh pr checkout 773
Create the cluster: k3d cluster create.
Set up the general channel in a Slack workspace.
Install BotKube with Slack and test:

# /tmp/pr-773.yaml

communications:
  'default-group':
    slack:
      enabled: true
      channels:
        'default':
          name: 'general'
          notification:
            disabled: false
          bindings:
            executors:
              - kubectl-read-only
            sources:
              - k8s-all-events
      token: "xoxb-.."
      notification:
        type: short

settings:
  clusterName: kind
  log:
    level: debug
    disableColors: false

executors:
  'kubectl-read-only':
    kubectl:
      enabled: true

analytics:
  disable: true

On Slack, in the general channel run:
@BotKube logs botkube-xxpod-idxxx -n botkube

This should produce something similar to ...

Related issue(s)

Resolves https://github.com/kubeshop/botkube/issues/750

@mszostok FYI, the PR is code complete.
Feel free to review the code while huseyinbabal fixes the build.

@mszostok moving this to draft to adjust implementations. Will ping you when its ready for review.

Had to merge in the latest from main which delayed a couple of things.
Issue

Cannot parse helm/botkube/templates/service.yaml when lifecycleServer is enabled.

Pending

minor refactoring based on here
Fix the e2e tests to work with latest from main.

Discord single message with upload

Slack single message with upload


Use in Xamarin.Android

How to use ExtendedCalendarView in Xamarin.Android

You don't, xamarin is not an will not be supported


Documentation doesn't cover dynamic block for subnet service delegation.

Example.tfvars also does not show an example of subnet service delegation.

Closing this issue.


No module named 'xformers'

I runing on my vscode jupyter

!xcopy /E /Q /H /Y "$MAIN_DIR/usr/local/lib/python3.7/dist-packages" "$s"
In fact, i confused about that, i used Anaconda env, need change this packages path?
eg: !xcopy /E /Q /H /Y "D:/Anaconda3/envs/fast-dreambooth/Lib/site-packages" "$s"

You don't need to change that, just install xformers in anaconda

You don't need to change that, just install xformers in anaconda

I see, thanks.


Storybook Color Readability Issues

Many of the Storybook stories feature components without backgrounds and the readability is very low. For example, our Collapse component:

Here's how the Collapse component (and all components) are displayed on the daisyUI site:

Readability seems generally better because the component itself is wrapped in the preview grid. I think it would be a good idea to wrap existing stories in a similar container to help clarify the distinction between components and the background.

This issue has been resolved with #87


Download Images and Video

Hello, there is a way to download images or video? I managed to download only the thumbnail.

It Works,  work but only with the thumbnail
I continued with problems in the line:
filename = "{0}{1}".format(self["__x_filehash"], extension)
Modify the function:
def save_media(self, path, name):
extension = mimetypes.guess_extension(self.mime)
#filename = "{0}{1}".format(self["__x_filehash"], extension)
filename = "{0}{1}".format(name, extension)
with file(os.path.join(path, filename), "wb") as output:
output.write(self.content.decode("base64"))
and send her to call
message.save_media(path, name)
I have not yet managed to save the original image. Help Me!

Correct way to download an image from the api:
`
from PIL import Image
from webwhatsapi import WhasAPIDriver
from webwhatsapi.objects.message import Message, MediaMessage
from webwhatsapi.helper import safe_str
from webwhatsapi.objects.contact import Contact
folder = 'C:/anywhere'
driver = WhatsAPIDriver()
driver.wait_for_login()
while True:
time.sleep(3)
print('Checking for more messages')
for contact in driver.get_unread():
for message in contact.messages:
if isinstance(message, MediaMessage):
print('Img recibida {},{}').format(message.media_key, message.client_url )
print message.sender.id
a = driver.download_media(message)
im = Image.open(a)
im.convert('RGB').save(folder, "JPEG", quality = 100, dpi = (300,300))
`

I am trying this:
if isinstance(message, MediaMessage):
message.save_media(folder)
And getting this error:
'MediaMessage' object has no attribute 'getitem'

Please see recent fix for save_media method
https://github.com/mukulhase/WebWhatsapp-Wrapper/blob/master/webwhatsapi/objects/message.py#L84
Should download full size media now.

@chriso0720 : Still unable to download full media (Image).
I also did pip install webwhatsapi -U
Do I need to install from git repo instead pip?

Please make sure you are using the latest source from github.

I do confirm here that installing directly from GitHub resolve the full media download issue.


Remove deprecated sizeType prop from nr1 Icon

This PR updates the nr1 Icon which no longer uses the sizeType prop. Icon sizes can be adjusted via a size suffix on the icon type, but not all icons have this option.
There is only one size for the arrow and an inline style gets applied in the platform with the font size. We could use !important to get the icon to be larger, or just accept a style change with a smaller arrow.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Dark Mode

I would like to have a dark mode in pdfs either by color inversion or any other method.

Duplicate of #2071


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.9 to before v4.19.199",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=86da71b57383d40993cb90baafb3735cffe5d800",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e4fdca366806f6bab374d1a95e626a10a3854b0c"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "86da71b57383d40993cb90baafb3735cffe5d800",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "e4fdca366806f6bab374d1a95e626a10a3854b0c",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net/sched: act_skbmod: Skip non-Ethernet packets\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.199 by commit e4fdca366806f6bab374d1a95e626a10a3854b0c, it was introduced in version v4.9 by commit 86da71b57383d40993cb90baafb3735cffe5d800. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001370


[Bug] iOS image stream

Hello,
On an iPhone 7, when I launch the example with the stream part uncommented, I have a crash really fast (may be 1 second) :
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_RESOURCE RESOURCE_TYPE_MEMORY (limit=1450 MB, unused=0x0)
    frame #0: 0x00000001b70d5948 libsystem_platform.dylib`_platform_memmove + 88
libsystem_platform.dylib`_platform_memmove:
->  0x1b70d5948 <+88>:  stnp   x8, x9, [x3]
    0x1b70d594c <+92>:  stnp   x10, x11, [x3, #0x10]
    0x1b70d5950 <+96>:  add    x3, x3, #0x20             ; =0x20
    0x1b70d5954 <+100>: ldnp   x8, x9, [x1]

If I comment this part :
imageStream.listen((Uint8List imageData) {
              print(
                  "...${DateTime.now()} new image received... ${imageData.lengthInBytes} bytes");
            });

The app doesn't crash but the _buildPreviewStream StreamBuilder's builder is called only one time with AsyncSnapshot<List<Uint8List>>(ConnectionState.waiting, null, null, null) for the snapshot state.

Hello @bpillon, first happy new year 👍
After some investigations, I found the problem you have:
On iOS we use a method called [FlutterStandardTypedData typedDataWithBytes:bytes]; which is very energy consuming...
On devices with less powerful CPU, the app crash.
On a more recent device it works (I tested on iPhone X) but CPU goes up to 190% !!!
So we had 2 solutions to fix it:

We create an FPS limit for each device (low FPS on less powerful devices).
We transform image to a lower quality & resolution & then send it over image stream (can decrease CPU usage I think).

If you want, you can test the first option on this branch https://github.com/Apparence-io/camera_awesome/tree/fix/ios_image_stream_crash
With this POC, CPU usage on iPhone X decreased from 190% to 105% 👍
Please tell me if it's better or not ( can't have an iPhone 7 to test :/ )
Thanks

Hello @bpillon, first happy new year 👍
After some investigations, I found the problem you have:
On iOS we use a method called [FlutterStandardTypedData typedDataWithBytes:bytes]; which is very energy consuming...
On devices with less powerful CPU, the app crash.
On a more recent device it works (I tested on iPhone X) but CPU goes up to 190% !!!
So we had 2 solutions to fix it:

We create an FPS limit for each device (low FPS on less powerful devices).
We transform image to a lower quality & resolution & then send it over image stream (can decrease CPU usage I think).

If you want, you can test the first option on this branch https://github.com/Apparence-io/camera_awesome/tree/fix/ios_image_stream_crash
With this POC, CPU usage on iPhone X decreased from 190% to 105% 👍
Please tell me if it's better or not ( can't have an iPhone 7 to test :/ )
Thanks

I see similar behaviour while using image stream on Android phone (One plus 3). When I assign something to imageStream property while instantiating CameraAwesome the ui freezes, I see below message in logs.
E/libc    (26278): Access denied finding property "persist.vendor.camera.privapp.list"
W/culator.android(26278): type=1400 audit(0.0:6630): avc: denied { read } for name="u:object_r:vendor_camera_prop:s0" dev="tmpfs" ino=15243 scontext=u:r:untrusted_app:s0:c199,c256,c512,c768 tcontext=u:object_r:vendor_camera_prop:s0 tclass=file permissive=0

Code that instantiates
SizedBox(
      height:200,
      width: 200,
      child: CameraAwesome(
          onPermissionsResult: (bool result) {
            debugPrint("perm result: $result");
          },
          onCameraStarted: () { },
          imagesStreamBuilder: (Stream<Uint8List> imageStream)  {
          },
          onOrientationChanged: (CameraOrientations newOrientation) { },
          zoom: _zoom,
          sensor: _sensor,
          photoSize: _photoSize,
          switchFlashMode: _switchFlash,
          captureMode: _captureMode,
          orientation: DeviceOrientation.portraitUp,
          fitted: true,
        )
    );

I see similar behaviour while using image stream on Android phone (One plus 3). When I assign something to imageStream property while instantiating CameraAwesome the ui freezes, I see below message in logs.
E/libc    (26278): Access denied finding property "persist.vendor.camera.privapp.list"
W/culator.android(26278): type=1400 audit(0.0:6630): avc: denied { read } for name="u:object_r:vendor_camera_prop:s0" dev="tmpfs" ino=15243 scontext=u:r:untrusted_app:s0:c199,c256,c512,c768 tcontext=u:object_r:vendor_camera_prop:s0 tclass=file permissive=0

Code that instantiates
SizedBox(
      height:200,
      width: 200,
      child: CameraAwesome(
          onPermissionsResult: (bool result) {
            debugPrint("perm result: $result");
          },
          onCameraStarted: () { },
          imagesStreamBuilder: (Stream<Uint8List> imageStream)  {
          },
          onOrientationChanged: (CameraOrientations newOrientation) { },
          zoom: _zoom,
          sensor: _sensor,
          photoSize: _photoSize,
          switchFlashMode: _switchFlash,
          captureMode: _captureMode,
          orientation: DeviceOrientation.portraitUp,
          fitted: true,
        )
    );

Hi @istornz ,
I think that capping the frame rate can be good in many cases. Sure it will help in this issue but it can be useful in many other situations. Do you think it can be added in the constructor of CameraAwesome?

Hi @istornz ,
I think that capping the frame rate can be good in many cases. Sure it will help in this issue but it can be useful in many other situations. Do you think it can be added in the constructor of CameraAwesome?

Hi @stefanodecillis Hum yes, like this ?:
CameraAwesome(
   // [...]
   streamFpsLimit: 20,
   // [...]
)

The main problem, is: some low CPU device like a old iPhone 6 can't deliver up to 20 fps on image stream like an iPhone 12 which can deliver easily 30 fps.
So we think to create a method to detect device power to adapt FPS limit rate ex:
iPhone 6 -> 2 FPS max
iPhone 7 -> 5 FPS max
iPhone X -> 15 FPS max
etc...

Hi @stefanodecillis Hum yes, like this ?:
CameraAwesome(
   // [...]
   streamFpsLimit: 20,
   // [...]
)

The main problem, is: some low CPU device like a old iPhone 6 can't deliver up to 20 fps on image stream like an iPhone 12 which can deliver easily 30 fps.
So we think to create a method to detect device power to adapt FPS limit rate ex:
iPhone 6 -> 2 FPS max
iPhone 7 -> 5 FPS max
iPhone X -> 15 FPS max
etc...

@istornz that's a great idea. I can only suggest delivering the streamFpsLimit as well.
I think that this feature can be helpful in order to have a "patch" as soon as possible (I think you built it here https://github.com/Apparence-io/camera_awesome/tree/fix/ios_image_stream_crash) and to save power consumption. For example, I would like to save battery because I don't need a high frame rate.
Still, your idea to have a method to identify the maximum rate for the specific CPU is really interesting.

@istornz that's a great idea. I can only suggest delivering the streamFpsLimit as well.
I think that this feature can be helpful in order to have a "patch" as soon as possible (I think you built it here https://github.com/Apparence-io/camera_awesome/tree/fix/ios_image_stream_crash) and to save power consumption. For example, I would like to save battery because I don't need a high frame rate.
Still, your idea to have a method to identify the maximum rate for the specific CPU is really interesting.

@stefanodecillis Thanks for your review, yeah I think that could be cool to have two mode: manual (by settings streamFpsLimit in constructor) & automatic mode by default if no streamFpsLimit was provided.

@stefanodecillis Thanks for your review, yeah I think that could be cool to have two mode: manual (by settings streamFpsLimit in constructor) & automatic mode by default if no streamFpsLimit was provided.


Is there any way of checking the DNS validations or status of domains?

I used to use Caprover to host my applications previously. It had a neat feature to check the status of domains pointed to our containers but lacked the support for Cloudflare proxied DNS by default. I love how Coolify supports the proxied DNS by default but I couldn't find any menu or UI elements to check the DNS status.

Not related to this repo.

im still having issues with: #2202, was hoping find something relevant here lmao


Add e2e tests - inital (#332)

This is already approved- check comments here
Had to make a PR from this repo (not fork) to dev for the CI to run.

Merging this because it was approved - https://github.com/Azure/azure-functions-python-worker/pull/332


Pregroup drawing

Pregroup drawing has been removed from DisCoPy v1.0.
Building upon PR https://github.com/CQCL/lambeq/pull/68, this PR adds this functionality back into lambeq along with the corresponding tests.
It also updates the jupyter notebooks.

Replaced by https://github.com/CQCL/lambeq/pull/71


Allow users to filter events show on main page

Filter by:

Country
Region
CIty
Zip
EventType

This will be added as part of the restyling. We can code it ahead of time to be ready.

Duplicated


Is it compatible with version 2.7.0?

Tried to make it work on  2.7.0 but not responding

I'm using 2.7.3 and it's working fine, check .env


⚠ Prueba_Error_500 has degraded performance

In e1e04f6, Prueba_Error_500 ($URL_ERROR_500) experienced degraded performance:

HTTP code: 200
Response time: 7436 ms

Resolved: Prueba_Error_500 performance has improved in c882da3 after 567 days, 15 hours, 30 minutes.


terminal is not showing any out put in java code

We have written the needed data into your clipboard because it was too large to send. Please paste.
I start vs code for java coding now i m facing problems in terminal .
terminal is not showing any output of java or error,
I try so much effort to fix this problem but i can not fix this problem
i try may sattings options and reinstall vs code and jdk but problem not fix
please help to fix it
i think when i run my first code then its run good and i want to type anouther code i erase some different code which is importent .

Pls create an issue w the Java extension


cv2.imshow() complains with: error: (-215:Assertion failed) dst.data == (uchar*)dst_ptr in function 'cvShowImage'

Expected behaviour
I was expecting that cv2.imshow() will show the depth image red from openni2 device.
Actual behaviour
When it reaches cv2.imshow("image", img) it crashes with:

Traceback (most recent call last):
File "C:/Dev/Repos/untitled/demo.py", line 28, in
cv2.imshow("image", img)
cv2.error: OpenCV(4.0.0) C:\projects\opencv-python\opencv\modules\highgui\src\window_w32.cpp:1230: error: (-215:Assertion failed) dst.data == (uchar*)dst_ptr in function 'cvShowImage'

This seems to be related to this opencv issue which unfortunately got closed. I don't see why.
This is my related post on stackoverflow:
The shape of img is a tuple (480, 640, 3) and dtype is uint16 just before the call to cv2.imshow()
Please note: The same happens when calling
cv2.imshow("test", np.ones((50, 50), dtype=np.uint16));
... so I guess OpenNI can be ruled out... also downgrading to the latest 3.x release (opencv-python <IP_ADDRESS>) made it work!
Steps to reproduce

Install opencv-python from pip (version <IP_ADDRESS>)
Install openni-2.2.0.post6
Run the bellow script on a Windows 10 Pro (x64) machine with Python (3.6.8 - Anaconda)
I am using an Orbbec Astra Pro camera which correctly shows up within my device manager as deph sensor and camera as well.

import numpy as np
import cv2
from openni import openni2
from openni import _openni2 as c_api

openni2.initialize("./OpenNI-Windows-x64-2.3/Redist")

if openni2.is_initialized():
    print('openni2 ready')
else:
    print('openni2 not ready')

dev = openni2.Device.open_any()

depth_stream = dev.create_depth_stream()
depth_stream.set_video_mode(c_api.OniVideoMode(pixelFormat = c_api.OniPixelFormat.ONI_PIXEL_FORMAT_DEPTH_100_UM, resolutionX = 640, resolutionY = 480, fps = 30))
depth_stream.start()

while(True):
    frame = depth_stream.read_frame()
    frame_data = frame.get_buffer_as_uint16()
    img = np.frombuffer(frame_data, dtype=np.uint16)
    img.shape = (1, 480, 640)
    img = np.concatenate((img, img, img), axis=0)
    img = np.swapaxes(img, 0, 2)
    img = np.swapaxes(img, 0, 1)

    cv2.imshow("image", img)
    cv2.waitKey(25)

depth_stream.stop()
openni2.unload()

@skvark any timeline to release the 4.0.1 version?

After this PR has been merged (if everything goes fine): https://github.com/skvark/opencv-python/pull/182
Probably later this week given that I have enough free time.

@skvark the 4.0.1 version have released now？

There is <IP_ADDRESS> release in PyPI but there were issues with macOS deployment (and with Linux too but that was fixed) so the macOS wheels are missing. I'm about to create a new release which contains also macOS wheels. There will be also 4.1.0 release just after that since it was released yesterday (https://github.com/opencv/opencv/wiki/ChangeLog#version410).

I have this issue with version 4.1.0 (windows). Any thoughts?

I also have the same issue on windows 4.1.0

Please report the issue to upstream repo: https://github.com/opencv/opencv/issues. I cannot fix OpenCV bugs here. I think they fixed the bug with Qt & GTK backends, but Windows wheels shipped by this repo use the native Windows backend and it seems to have been only partially fixed: https://github.com/opencv/opencv/pull/13235

thanks!


[Improvement] metadata use MySQL8 driver class first

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
https://github.com/apache/kyuubi/blob/fd69c6ee1dd40b7c4f496c74a45f574220448bc6/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala#L52
If we use com.mysql.jdbc.Driver in the MySQL 8 JDBC driver, we will get an error output.
If com.mysql.cj.jdbc.Driver exists in the classpath, we can use it first.
https://github.com/mysql/mysql-connector-j/blob/7d6b0800528b6b25c68b52dc10d6c1c8429c100c/src/legacy/java/com/mysql/jdbc/Driver.java#L42-L45
How should we improve?
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[X] No. I cannot submit a PR at this time.

please assign to me


Add unit test to make sure Qt GUI doesn't raise exception on startup

We've had several cases where merging from upstream resulted in code that passed Travis but the Qt GUI raised an exception on startup.  It would be useful to test for this in the unit tests.

Any fix for this should probably be sent upstream.

Possibly relevant: the pytest-qt package on PyPI.


Broken in new settings pre-release

Prevents inspector UI from generating
DESKTOP-H976HO2 - 2<IP_ADDRESS>5 - 2024-04-04 02_07_04.log

fixed in latest release


fix: allow customizing the npm registry of the core typescript npm packages

Fixes #191
When a custom npm registry is used the same must be done for the rules_ts npm packages as the rules_js packages. Normally it's done by reading the npmrc file but that isn't available when fetching in the WORKSPACE. Would this be the ideal solution? Ideas?

Normally it's done by reading the npmrc file but that isn't available when fetching in the WORKSPACE

Could you elaborate on that? Why isn't npmrc available?

We can't read files during the loading phase when the WORKSPACE/BUILD files are essentially just being parsed and put into a dep graph.
The information we need is normally read from a npmrc file when yarn/npm/pnpm run, we parse that npmrc at the same time as the lockfile: https://github.com/aspect-build/rules_js/blob/c6c257ac82f9030ee4443f7ed1db775f056815b6/npm/private/npm_translate_lock.bzl#L480-L486
This PR is the best way I could think of customizing the npm registry URL in the loading phase. I'd be curious what other ideas there are though...

We can't read files during the loading phase when the WORKSPACE/BUILD files are essentially just being parsed and put into a dep graph.
The information we need is normally read from a npmrc file when yarn/npm/pnpm run, we parse that npmrc at the same time as the lockfile: https://github.com/aspect-build/rules_js/blob/c6c257ac82f9030ee4443f7ed1db775f056815b6/npm/private/npm_translate_lock.bzl#L480-L486
This PR is the best way I could think of customizing the npm registry URL in the loading phase. I'd be curious what other ideas there are though...

But it can be loaded in a repository rule or module_ctx before anything is downloaded? (ignore me if that doesn't apply here, I don't have a deep understanding of what's going on).

But it can be loaded in a repository rule or module_ctx before anything is downloaded?

Yeah I think you're correct, we can pass the npmrc just like we do for npm_translate_lock. That means we'd have to fetch @bazel/worker and google-protobuf with our own repo rule as well instead of using the normal http_archive (today only the typescript npm package is downloaded with our custom http_archive_version.
@gregmagolan WDYT?

I wish we had a mechanism to configure npm registry in rules_js and all the other rules follow the same pattern.
As a user, I'd expect that one configuration .npmrc is sufficient to configure rules_js and derivative rules.

After talking with @gregmagolan we've decided we should handle this differently like @kormide and @thesayyn are both suggesting.
The npmrc can have various other config in it that might effect downloading npm packages such as CA certs, registry URLs, registry auth etc, so we should come up with a solution that respects all of those.


[RESOLVED] High ICMP ping response time

Problem started at 16:07:16 on 2023.08.15
Problem name: High ICMP ping response time
Host: ST-FG
Severity: Warning
Operational data: Value: 886ms
Original problem ID: 40918
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23135&eventid=40918

Problem has been resolved in 6m 0s at 16:13:16 on 2023.08.15
Problem name: High ICMP ping response time
Host: ST-FG
Severity: Warning
Original problem ID: 40918


Warning BCP036: The property "type" expected a value of type "'Extension/HubsExtension/PartType/MarkdownPart'" but the provided value is of type "'Extension/AppInsightsExtension/PartType/AspNetOverviewPinnedPart'"

Bicep version
Bicep CLI version 0.4.613 (d826ce8411)
Describe the bug
"Extension/AppInsightsExtension/PartType/AspNetOverviewPinnedPart'" is a valid part, but the schema is not upto date and this fails the validation.
To Reproduce
@description('The resource name for the Application Insights dashboard.')
param applicationInsightsDashboardName string

@description('The resource name for the Application Insights instance.')
param applicationInsightsName string

@description('The location of the resources created, excluding \'Global\'.')
param resourceLocation string

resource applicationInsightsDashboardName_resource 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
  name: applicationInsightsDashboardName
  location: resourceLocation
  properties: {
    lenses: [
      {
        order: 0
        parts: [
          {
            position: {
              x: 0
              y: 0
              rowSpan: 1
              colSpan: 2
            }
            metadata: {
              inputs: [
                {
                  name: 'id'
                  value: resourceId('Microsoft.Insights/components', applicationInsightsName)
                }
                {
                  name: 'Version'
                  value: '1.0'
                }
              ]
              type: 'Extension/AppInsightsExtension/PartType/AspNetOverviewPinnedPart'
              asset: {
                idInputName: 'id'
                type: 'ApplicationInsights'
              }
              defaultMenuItemId: 'overview'
            }
          }
        ]
      }
    ]
  }
  tags: {
    'hidden-title': '${applicationInsightsName} Dashboard'
  }
}

Additional context
It would be good if biceplinter.config could disable individual rules.

@alex-frankel Please see the response from the issues logged in Azure Schemas - https://github.com/Azure/azure-resource-manager-schemas/issues/1806

Looks like they are saying this is something that should be handled in bicep.  Can you have a look @anthony-c-martin ?


Alert support for closing without handler function

Currently, one can create alerts by something like:
<alert ng-repeat="alert in alerts" type="alert.type" close="closeAlert($index)">{{alert.msg}}</alert>
However, if I need a single simple alert, I am targeting to write this snippet:
<alert type="'error'" close>OMG, alert!!!</alert>
This works well except the close button. I do not want to call any javascript, but instead just to allow to user to get rid of the message.
It would be great if the code uses some default close action when no value is specified in the close attribute. Actually, the same way bootstrap works when I add close button.

Anyway I think this is not elegant at all
<alert type="'error'" ng-show="$parent.loginError" close="loginError = false">Alert msg</alert>

and it should be encapsulated for such a simple case.

You could also do this. It even works without a controller as it uses the directive's scope.
<alert type="success" role="alert" close="close = true;" ng-show="!close">
	Happy alert
</alert>


fix: add_account_owners_admin_access

About this change—what it does
Fixes add_account_owners_admin_access type issue

Test passed https://github.com/aiven/terraform-provider-aiven/actions/runs/4294276290/jobs/7483088635


OCM-2636: Enable importing machine pools

Tested importing:

1AZ cluster, 1AZ pool
mAZ cluster, 1AZ pool
mAZ cluster, mAZ pool

Note: I removed the verification that replicas is a multiple of 3 in the case of mAZ pools. OCM provides this validation separately. The reason for the removal from the TF code is that it was causing a problem during updates after state import wrt the 1AZ optional fields for mAZ clusters. It would have required additional API queries to read the cluster object.

/cc @nirarg

/approve
/lgtm


Investigate support of older osx versions.

Specifically all versions before 10.10

Let's not go back, but only forward.


add: anevski-stefan

Description
I created anevski-stefan.json file and filled the my information in that file. After that in the src folder I updated the ProfileList.json file with the newly added file.
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[yes] I have read and followed the Contribution Guidelines.
[yes] All new and existing tests passed.
[yes] I have updated the documentation to reflect the changes I've made.
[yes] My code follows the code style of this project.
[yes] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@anevski-stefan Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


[Feature Request] Support for test server without internet access

Is your feature request related to a problem? Please describe.
I'm trying to run temporal workflow tests in an environment without access to the public internet. This means that WorkflowEnvironment.start_time_skipping(...) et. al. can't fetch the time skipping test server from temporal.download.
There's a possible workaround I found while stepping through temporal-core-sdk in which I could e.g. make a test server tarball  available on the air-gapped infrastructure, unpack it, then thread the path to the binary into my test harness and pass it as the test_server_existing_path to WorkflowEnvironment.start_time_skipping. But I wish a more ergonomic option existed, especially for a use case that might not be uncommon.
Describe the solution you'd like
In order of descending convenience for my use case:

be able to provide a URL of the tarball itself via environment variable (without the json info indirection); I'm able to cache the tarball at a different location
be able to provide a URL of the test server binary via environment variable
be able to provide an absolute path to the test server binary on disk via environment variable

Basically, configuration via environment variable saves having to thread information through to every WorkflowEnvironment instantiation.
It would also be helpful to document the location where test server binaries can be acquired.
An alternative solution could be packaging and publishing platform/arch-specific pypi packages containing the test server. This could either be in the sdk-python package itself, or a separate package which is conditionally depended on by sdk-python via dependency group.
I'm def open to other approaches. Thanks!
Additional context

PR introducing on-demand test server fetching: https://github.com/temporalio/sdk-core/pull/389
Call site where test server is downloaded: https://github.com/cretz/temporal-sdk-core/blob/3105ef349fe60265157ae7fa96674c964ae5c979/core/src/ephemeral_server/mod.rs#L298

In order of descending convenience for my use case:

As mentioned there, we provide the option for you to give the executable path. This gives you full freedom without us being too specific. I would suggest if you want a URL-based download, you can use your preferred downloading tool/library to download it and extract the tarball. Same if it were on S3 or provided via some other method. Similarly if you want to have this option set via environment variable, just test_server_existing_path=os.getenv('MY_ENV_VAR').
I am not sure we want to bake in so many ways to get a file beyond the default/no-option and the advanced option.

Is there documentation describing where to find the test server binary tarballs?

No, we can add this. Yeah they are part of https://github.com/temporalio/sdk-java releases

@cretz @wilsoniya
Where can I find this documentation?

This documentation is in the API docs at https://python.temporal.io/temporalio.testing.WorkflowEnvironment.html#start_time_skipping:

test_server_existing_path [...] Existing path to the test server binary. If present, no download will be attempted to fetch the binary.

Though your error looks like it's referring to start_local, so those are at https://python.temporal.io/temporalio.testing.WorkflowEnvironment.html#start_local. But I am afraid it, and many of the other advanced options there, are not (yet) documented outside of the API docs.

Also can the error message here could be improved. At least logging or including the HTTP status code returned.

Yes, this is because the Rust HTTP request library does not include more detail from the inner message (https://github.com/seanmonstar/reqwest/blob/e2d4b14c695acaebe531af7ce4712e182278f38a/src/error.rs#L185). We can look into improving it.


go get downloads all directories except the directory specified on bitbucket

What version of Go are you using (go version)?

$ go version
1.14

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?
In my git repo (bitbucket.org) I have
reponame/
	.git/
	integration1/
	integration2/
	integration-common/
	└── util
	    ├── go.mod
	    └── readascii.go

The module directory is a subdirectory of the git repository.  The repository is tagged with v0.0.1.
Here's the go.mod
	module bitbucket.org/orgname/reponame/integration-common/util
	go 1.14

When I do go get for this module I get
go get<EMAIL_ADDRESS>go: downloading bitbucket.org/orgname/reponame v0.0.1
go get<EMAIL_ADDRESS>module<EMAIL_ADDRESS>found, but does not contain package bitbucket.org/orgname/reponame/integration-common/util

I can see the integration-common/util/ directory in bitbucket if I look with the web browser.  The go.mod has the contents shown above.
What is even more odd is that go get does manage to download the other directories in the repository (integration1 and integration2).  For some reason it thinks the v0.0.1 tag contains all the other directories except for the integration-common/util directory, even though bitbucket shows it there for that tag.
I download with ssh, not https, because https reqires 2fa on our bitbucket repo.  I have this in my ~/.gitconfig:
`[url "git@bitbucket.org:"]insteadOf = https://bitbucket.org/`

I know bitbucket is weird when it comes to using go get.  Is there something I missed, or is the a bug with go get?
What did you expect to see?
I wanted to see one directory from a repo pulled down.
What did you see instead?
go get pulled all the other directories instead of the one specified

Following the third paragraph of the docs I created the tag
git tag integration-common/util/v0.0.1
and verified that it got pushed to bitbucket.  When I go get the tag it shows
go get<EMAIL_ADDRESS>go: bitbucket.org/orgname/reponame/integration-common/util/v0.0.1 => v0.0.1
but nothing gets downloaded.  A silent failure.
I also tried this
go get<EMAIL_ADDRESS>but it returns immediately and does nothing.

Have you tried asking this as a question first? https://golang.org/wiki/Questions
It's likely this has something to do with the way you set up the module(s). You could also try using the latest version of Go.

@dwschulze, the argument to go get is in general a module path and version, not a repo and tag.
The command you are probably looking for here is
go get<EMAIL_ADDRESS>
with the desired commit tagged integration-common/util/v0.0.1 (per https://golang.org/ref/mod#vcs-version).

That said, in general we recommend only one module per repo. (Is there a particular reason you need to have the util package in a separate module?)

I've tried the command
go get<EMAIL_ADDRESS>with the tag integration-common/util/v0.0.1.
One module per repo could lead to proliferation of repos, which we could probably handle.  But what do groups that put everything into one repo do with modules?  (I've heard Google has one huge repo for all of their code which I find hard to believe.)

In general it is fine to have all of your packages in one big module in one big repo.
(IMO the only really compelling use-case for multi-module repos is to be able to tag independent releases of packages within that repo. But that seems like a rare use-case, and often isn't worth the overhead of maintaining multiple modules.)

@mvdan - I've asked this question on both the golang-nuts forum and stackoverflow.  Thanks for asking.  I got one response that didn't fix anything.
As far as upgrading to a newer version of Go, was there a bug fix relevant to this issue?  If not that sounds like the mindless advice you get by calling an 800 number for tech. support for a childrens computer game.
This is a serious problem and I need to either get a bug fixed or find out if it is a documentation problem.

As far as upgrading to a newer version of Go, was there a bug fix relevant to this issue?

There have been fixes in the module system in every release since Go 1.11. Many of the recent improvements are specifically to provide clearer diagnostics.
Also note that the issue template specifically asks “Does this issue reproduce with the latest release?”, and the latest supported releases are go 1.15.4 and go 1.14.11 respectively. An issue posted for go 1.14 (without a minor release) does suggest a reasonable likelihood that something about the issue may have changed in the ~year since the development freeze began for the initial 1.14 release.
Finally, note that our Gopher values include to “be patient” and “avoid … snarking”. We have the common goal of making Go development simple and productive. I understand that you're feeling frustrated, but please keep comments constructive.

Thanks for having asked the question elsewhere. A significant portion of modules issues raised here are essentially questions phrased as bug reports, so that's why I tend to ask.
And, like Bryan says, trying the latest stable release is indeed part of the bug reporting process. Go 1.14.x is still supported, but you should still check if your problem has been solved in 1.15.x (or even the upcoming 1.16, once beta1 is out in a few weeks).

I added the -v to go get but it gives no output and downloads the same thing (all the subdirectories except the one I'm asking for)
$ go get -v<EMAIL_ADDRESS>Something unusual is that that the downloaded dirs/files have permission 500.
The directory I'm trying to get was created on a branch as was the tag v0.0.1.  That directory doesn't exist on any other branch.  I can see the directory under the tag on the bitbucket UI.  My understanding is that tags are independent of branches.

@dwschulze, what is the output of go list -versions -m bitbucket.org/orgname/reponame for your repo? The symptom you are describing is consistent with the tag not existing.
You could also try using a totally different version for the nested module to remove any ambiguity. (What happens if you apply the tag integration-common/util/v0.0.2 and then try the same steps with version v0.0.2 instead of v0.0.1?)

I could also imagine that you might be running into issue #37438, which is fixed at head but not in any prior release.
(You could confirm that one way or the other by trying the same steps using golang.org/dl/gotip or a go command built from source at head.)

I upgraded to go v1.15.4.  Same results.
$ go list -versions -m bitbucket.org/orgname/reponame
bitbucket.org/orgname/reponame
I added the tag integration-common/util/v0.0.2 and pushed.  I can see it in bitbucket with my directories and files in it.  When I do
go get -v<EMAIL_ADDRESS>it downloads<EMAIL_ADDRESS>however with all the directories except the one I'm asking for.
I deleted the v0.0.1 tag
git push --delete origin integration-common/util/v0.0.1
and ran the same go get with @v0.0.2 and it still downloads<EMAIL_ADDRESS>Something is really haywire.

When I do
go get -v<EMAIL_ADDRESS>it downloads<EMAIL_ADDRESS>however with all the directories except the one I'm asking for.

Ok, that really sounds like #37438. 😞
Try gotip or a go command built from head? I'm hoping it's fixed (I literally just spent the past ~month or more on it), but if not I'd rather know sooner than later.

$ go list -versions -m bitbucket.org/orgname/reponame
bitbucket.org/orgname/reponame

That's possibly as expected? What about go list -versions -m bitbucket.org/orgname/reponame/integration-common/util? (If the nested path has its own go.mod file, it is its own module, distinct from bitbucket.org/orgname/reponame.)

$ go list -versions -m bitbucket.org/orgname/reponame/integration-common/util
bitbucket.org/orgname/reponame/integration-common/util v0.0.2
Makes sense since the go.mod is in the util/ directory.  But v0.0.1 is gone so why should go get download it?  Is it pulling the v0.0.1 off of the proxy even though I have bitbucket.org/orgname/* set in GOPRIVATE?

0.0.1 is gone so why should go get download it?

Are you sure it is downloading, and not just pulling from the local cache? (That's in either $GOMODCACHE or $GOPATH/pkg/mod.)
If the repo is private, the public proxy can't possibly have the module cached. (The public proxy does not receive credentials or module content from the go command.)

I deleted the cache.
I installed gotip as you suggested and ran gotip get with v0.0.2 and got the same results.  It downloads v0.0.1 which doesn't even exist in bitbucket.org and downloads all the directories except for the one I asked for.

I took out all the require and replace statements in the go.mod and then go get started working.  Whatever it was in go.mod that was causing the problem it makes no sense at all that go get would download every directory in the repo except for the one I was asking for.
I don't know if this is a bug or just an FAQ.

@dwschulze, you didn't mention any require or replace statements in the original report!
That could certainly explain it, but we'd need more detail to figure out how that maps to the behavior you observed.


chore(core): update commitLint config

O que foi feito?

core:

Atualizada configuração do commitLint.

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Align text vertically

I recently switched to polybar after previously using lemonbar, and the one issue I have is that text is higher up on the bar than with other applications. (e.g. for dmenu the text is lower than the bar when I have the same height).
Is there any top padding option I can use to align the text?

The Fonts wiki page explains how you can set the vertical offset. For example:
# Will move the tamsyn glyphs down 2 pixels
font-0 = Tamsyn:pixelsize=12;2

@jaagr ok, cool. Thanks!


Sending "{}" as description will replace it with "[]"  in "What's it for?" field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Go to any chat
Click on "Request money"
Enter any amount and click "Next"
Click on Description > Enter {} > Click on Save > Request money
You'll notice that the description changes from "{}" to "[}" in chat

Expected Result:
Description shouldn't get changed
Actual Result:
Description automatically changes from "{}" to "[]"
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/234451525-038e2231-64d8-4f45-a366-67ef530d361b.mp4
https://user-images.githubusercontent.com/43996225/234451555-39d1b6f9-32e9-4adc-a499-b0d9a35f8ff5.mov
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682429522356379
View all open jobs on GitHub

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Gonna close it for the same reason that @puneetlath did.


BIGTOP-2293. Add puppet recipes for qfs components

This change adds puppet recipes to the bigtop source code for qfs components:
qfs-metaserver, qfs-chunkserver, and qfs-client. The puppet recipes install the
necessary packages, create necessary files and directories, generate
configuration with the correct ports and paths, and finally start the services
so that they can talk to each other.
I have tested to make sure that the systems work properly by logging in manually
to the docker container and interacting with the chunkserver and metaserver
using the qfs client. In my next commit, I will add testing to the bigtop
codebase so that we don't need to use manual inspection to ensure that things
are working correctly.

This has been committed by @oflebbe into the BigTop repository. I am closing this pull request.


Suggestion: Support other Databases/Storage Adapters

Details:
Support other Databases such as SQLite and/or Storage Adapters such as Keyv
Benefits:
Supporting other databases would allow a larger range of support for different environments, especially production environments that may not utilize Mongo.

Will try to add more branches.


Update consensus hashes

Blocks 340000, 341000, 342000, 343000 and 344000 for Mainnet
Blocks 320000 and 322000 for Testnet

Coverage remained the same at 68.64% when pulling 0d487afc8227cc8bd0edfa7b67e9ed16da79c2ac on consensus into 08cf8a212267274b992b05407376e61045febebb on develop.

Coverage remained the same at 68.64% when pulling 58b726b0fd4f8ab52ef20734112cbbd3d2ce0389 on consensus into 08cf8a212267274b992b05407376e61045febebb on develop.

Coverage remained the same at 68.64% when pulling 58b726b0fd4f8ab52ef20734112cbbd3d2ce0389 on consensus into 08cf8a212267274b992b05407376e61045febebb on develop.


MI - ADMIN and OBSERVE section (Using the CLI tool)

Clean up the instructions on using the Micro Integrator CLI tool for monitoring [1].
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/administer-and-observe/using-the-command-line-interface.md

Done.


Enable lazy loading to improve website performance

Lazy loading is a technique that can be used to improve the performance of a website by delaying the loading of images and other resources until they are needed. This can help to reduce the initial load time of a page, which can improve the user experience and make the website more responsive.
The benefits of lazy loading include:

Reduced initial load time

Improved user experience

More responsive website

Increased SEO ranking

i would like to work on this issue Thanks.

I raised this issue so i would like to work on this by myself!

Sure i am assigning this to you @M-A-N-I-K

What are the updates??

Hey, @PiyushKalyanpy Can I work on this issue? I have experience in implementing lazy loading to the website. Please assign me this issue. It seems that he is not active.

Hey @PiyushKalyanpy I would like to work on this issue. I too have experience with implementing lazy loading on the web-apps.

We are closing this issue because it has been inactive for a long time.

@PiyushKalyanpy please assign me this issue


[Feature Request] Run as a Service and Auto-Start with Configuration

I am highly impressed with this application's capabilities, it's very user-friendly and I use it routinely. However, I find it inconvenient to manually open the app and import the configuration each time, even though I have set it to auto-open at login, it still requires manual configuration import.
If there were a way to make it run as a service and auto-start with a pre-set configuration, it would greatly enhance the app's usability
Looking forward to the possibility of this feature implementation, Thank you

After conducting some research, I found that the only way to create a GUI application as a service is through "Login Items," which you have already done (Reference: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPSystemStartup/Chapters/DesigningDaemons.html).
However, there is one issue you are facing - the app cannot automatically load a saved configuration upon launch. This problem can be easily resolved by adding a new settings window for implementing this feature.
I don't have enough spare time recently to complete this feature, so you may need to wait for a while. If you want to submit a PR, you're more than welcome to do so.

Hello @donnimsifa, I have implemented it in the master branch. You can try the pre-built binary from GitHub Actions by clicking here: https://github.com/hronro/iPortForwarder/actions/runs/7524349290
If everything works well for you, I will release a new version shortly.

Hi, @hronro , I apologize I couldn't manage to submit a pull request as my schedule has been quite tight lately.
Anyway, I'm excited to share that I've tested the pre-built binary from the GitHub Actions link you provided (https://github.com/hronro/iPortForwarder/actions/runs/7524349290), and I'm pleased to say it worked seamlessly. The application now effortlessly auto-starts with the pre-set configuration.
Thank you for your hard work and the implementation 😊

Great, let's release the new version for this.


Second PR dependency is not matched/checked

Current Behavior
When listing multiple PR dependencies by full URL, only the first one is matched and checked, independently of whether it's merged or not.
Expected Behavior
All dependencies are matched/checked
Example
I've set up an example repository that replicates this issue.
The repo has 3 open PRs that target main and depend on each other as such:
graph LR
PR1 ---> PR3
PR2 ---> PR3

In the PR3  checks, you can see the following output (from this action):
[...]
Found full-url dependency in 'Depends on https://github.com/leocencetti/pr_deps_check_example/pull/1'
Found no dependency in 'Depends on https://github.com/leocencetti/pr_deps_check_example/pull/2'
[...]

note the Found no dependency line.
As mentioned before, the behavior is the same if PR1 is merged, or the order is swapped.

The issue seems to be related to issue with the new line

I can't edit posts in that repo, so I can't get the exact markdown.  @leocencetti does the text have a blank line at the end?

I've restructured a bit so that I can add some tests.  It looks like the issue is not having a blank line at the end.  Not sure why that's a problem.
Of three multi-line tests, two have failed:

Shorthand and partial link ❌const shorthandAndPartialLink = `Depends on #14
Depends on gregsdennis/dependencies-action#5`

Shorthand and partial link with blank line at end ✔const shorthandAndPartialLinkWithBlankLineAtEnd = `Depends on #14
Depends on gregsdennis/dependencies-action#5
`

Shorthand and partial link with blank line in middle ❌const shorthandAndPartialLinkWithBlankLineInMiddle = `Depends on #14

Depends on gregsdennis/dependencies-action#5`

Looks like that's the issue, though I'm not sure what's going on b/c JS isn't my strength.
const simpleRegex = new RegExp(`abc`, 'gmi');
const body = `abc
123
abc123
abc`;
const ls = body.split(splitDelimiter);
ls.forEach(line => {
    const match = simpleRegex.exec(line);
    console.log(match);
});

outputs
  console.log
    [ 'abc', index: 0, input: 'abc', groups: undefined ]

      at log (evaluate-dependencies.test.js:22:13)
          at Array.forEach (<anonymous>)

  console.log
    null

      at log (evaluate-dependencies.test.js:22:13)
          at Array.forEach (<anonymous>)

  console.log
    [ 'abc', index: 0, input: 'abc123', groups: undefined ]

      at log (evaluate-dependencies.test.js:22:13)
          at Array.forEach (<anonymous>)

  console.log
    null

      at log (evaluate-dependencies.test.js:22:13)
          at Array.forEach (<anonymous>)

Note the last match attempt fails.

Okay.  Restructured to just find all matches for each regex across the entire body at once.  It works now.
I still don't understand why the line splitting version fails, and I don't really care.

Okay. Restructured to just find all matches for each regex across the entire body at once. It works now.

Perfect, thank you for the quick fix!


[Perf] Convert NS, ID to []byte.

This change is meant to remove strings and string casting from the M3DB core so that we spend less time collecting the garbage left after these casts. The majority of string casts happen in Thrift, Protobuf and Sharding code (specifically, when we cast strings to []byte to calculate the hash value).

Coverage increased (+0.03%) to 78.951% when pulling bee17c6052768ead86466910466ba79225a55fd8 on kobolog/byteslice-ids into 4e17f00a63d404d05cacbef049c6585358054a5f on master.

Probably need to rebase soon too.

Rebased.

Coverage increased (+0.2%) to 78.885% when pulling f463b3729c73b5e7cd6cf76fe7149fb28a8490b8 on kobolog/byteslice-ids into 6333c80c3887a1b8df8e0d2bd29679f5478a8bec on master.

Coverage increased (+0.1%) to 78.887% when pulling 30f680be4bd7651724e0c8f1fd1cbb6bb5b03556 on kobolog/byteslice-ids into e05d7d2df8c65165cad5db7cbf78468055777246 on master.

Coverage increased (+0.08%) to 79.047% when pulling ceb8d144e36317cf387d820f1abd86c11e9f3223 on kobolog/byteslice-ids into 5e8aad7de40bf3171a61717ba9c64bc66029a08c on master.


Fixed 5 digits long numeric name convention of sample output

Fixed 5 digits long numeric name convention of sample output at the WebGL module's generator.

Fixed the documentation to show the correct naming of sample files.

Thanks and sorry about the late reply (I'm on vacation currently).


fix nacos connection leakage and weight setting for nacos service

Ⅰ. Describe what this PR did
Fixed an error where namingClient was not closed when the nacos registry was deleted, resulting in connection leakage
Added the ability to set weights for nacos services
Ⅱ. Does this pull request fix one issue?

fixes #530
fixes #529

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.友瑾 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Bard Python Script Broken

The python script for Bard does not work anymore since becoming Gemini and now has an error when run:
Traceback (most recent call last):
File "/home/zuberlan/bard/bard.py", line 20, in
bard = BardCookies(cookie_dict=cookie_dict)
File "/home/zuberlan/.local/lib/python3.10/site-packages/bardapi/core_cookies.py", line 53, in init
self.SNlM0e = self._get_snim0e()
File "/home/zuberlan/.local/lib/python3.10/site-packages/bardapi/core_cookies.py", line 110, in _get_snim0e
resp = self.session.get(
File "/home/zuberlan/.local/lib/python3.10/site-packages/requests/sessions.py", line 602, in get
return self.request("GET", url, **kwargs)
File "/home/zuberlan/.local/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/home/zuberlan/.local/lib/python3.10/site-packages/requests/sessions.py", line 725, in send
history = [resp for resp in gen]
File "/home/zuberlan/.local/lib/python3.10/site-packages/requests/sessions.py", line 725, in
history = [resp for resp in gen]
File "/home/zuberlan/.local/lib/python3.10/site-packages/requests/sessions.py", line 191, in resolve_redirects
raise TooManyRedirects(
requests.exceptions.TooManyRedirects: Exceeded 30 redirects.

Thanks for your message!
Bard IRC Bot relies on this libraery: https://github.com/dsdanielpark/Bard-API
From what I can see, they are currently working on a hotfix; once fixed the bot should be back again: https://github.com/dsdanielpark/Bard-API?tab=readme-ov-file#updates


changed data format in Conv2D

There was a reshape error due to the data format which is default to 'channels_last' in Keras. Changed it to 'channels_first'

Good catch, thanks. I tested it only with theano, (see README : keras with theano backend).
I'll update the README so that it is clearer.  I'll close your PR for now and will update once I get the time to test each backend carefully.


Clean tags on form submission.

Coverage decreased (-0.01%) to 89.778% when pulling bbcec8c48b9984630e671dc39d716d845e00feb3 on warn-keywords into 4c786f453acc720a806e547750238e73543a1eab on master.


<Button textStyle= silently fails

<Button>'s textStyle attribute only accepts plain Javascript objects, and silently fails if you try to give it objects wrapped with ReactNative.StyleSheet.
Fails:
class WorkingExample extends Component {
  render() {
    return (
        <Button rounded block large style={styles.button} textStyle={styles.buttonText}>click me</Button>
    );
  }
}

const styles = StyleSheet.create({
  button: {
    marginHorizontal: 38,
    marginBottom: 67,
  },
  buttonText: {
    fontSize: 12,
    fontWeight: '500',
  },
});

Works:
class WorkingExample extends Component {
  render() {
    return (
-        <Button rounded block large style={styles.button} textStyle={styles.buttonText}>click me</Button>
+        <Button rounded block large style={styles.button} textStyle={buttonText}>click me</Button>
    );
  }
}

+const buttonText = {
+  fontSize: 12,
+  fontWeight: '500',
+}
+
const styles = StyleSheet.create({
  button: {
    marginHorizontal: 38,
    marginBottom: 67,
  },
-  buttonText: {
-    fontSize: 12,
-    fontWeight: '500',
-  },
});

The docs don't mention this either.

Possible solutions:

Handle both cases in the button code so it works without thinking about it: https://github.com/GeekyAnts/NativeBase/blob/master/Components/Widgets/Button.js#L110
Throw a warning if the user tries to pass in a StyleSheet object for this prop.
At the very least, update the docs to warn about this.

Thanks for notifying us. We'll figure out a fix soon.

@dsernst fixed it. Pull from master if you need urgently. Will publish soon.

Nice 😄


[Parser] Use proper ParseDeclOptions when parsing the result of a member macro expansion.

This prevents bogus parser diagnostics inside member macro expansions for declarations that can only appear inside of types, such as init, static methods, subscripts, etc.

@swift-ci please smoke test

@swift-ci please build toolchain

The Windows failure is related to macros, but it's unrelated to this specific change
swiftAST.lib(Decl.cpp.obj) : error LNK2001: unresolved external symbol "void __cdecl swift::simple_display(class llvm::raw_ostream &,class swift::UnresolvedMacroReference const &)" (?simple_display@swift@@YAXAEAVraw_ostream@llvm@@AEBVUnresolvedMacroReference@1@@Z)

Looks like fallout from https://github.com/apple/swift/pull/63247


Fix for line irq's firing twice when IRQ_LINE <= 10.

Update line y_counter widths to 10 bits to prevent line IRQs from firing during the vertical back porch period.
Fixes issue #12

Thanks!


Feature: Swamp error handling, add reference to bug tracking and exception info

Today When Swamp exits we don't always get the exception (if some lib used doen't pass an error object).
Also we don't give the user a useful reference where to report the issue, get help, etc/

Fixed. added in v0.0.22


TestPreviewCommitScheme and TestPreviewDismissScheme failing

Windows Terminal version
Commit c3fd26a393bd00664a3527f3c973e2cec2344e06
Windows build number
10.0.19041.1415
Other Software
No response
Steps to reproduce

Checkout the latest code.
Build.
Run the TerminalAppLocalTests unit tests.

Expected Behavior
Tests should pass.
Actual Behavior
Two tests are failing:
TerminalAppLocalTests::TabTests::TestPreviewCommitScheme [Failed]
TerminalAppLocalTests::TabTests::TestPreviewDismissScheme [Failed]

As far as I can tell, these first stopped working in commit c3fd26a393bd00664a3527f3c973e2cec2344e06.

 I'll take a look. Thanks ~CI~ @j4james!

3 tests failing for me:
TerminalAppLocalTests::TabTests::VerifyCommandPaletteTabSwitcherOrder [Failed]
TerminalAppLocalTests::TabTests::TestPreviewCommitScheme [Failed]
TerminalAppLocalTests::TabTests::TestPreviewDismissScheme [Failed]


current Whiteboard location?

Considering that the Whiteboard Storage is moved to OneDrive for Business.
I'm wondering why Whiteboard and "OneDrive for Business" are listed with different storage areas in many countries.
btw: could you please write "Exchange Online Protection (EOP)" or whatever the name official Name is.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61c6fa7b-7e9e-21a5-40da-adbd35040ec1
Version Independent ID: 530df3b2-2048-8351-2f09-59e604aedf5b
Content: Microsoft 365 data locations - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/o365-data-locations.md
Service: o365-solutions
GitHub Login: @dmwmsft
Microsoft Alias: deanw

Whiteboard is still in an opt-in phase.  Once all defaulting is aligned we will update.
Dean
Sent from Outlookhttp://aka.ms/weboutlook
From: newsgrep @.>
Sent: Friday, March 18, 2022 11:57 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Dean Wierman @.>; Mention @.>
Subject: [MicrosoftDocs/microsoft-365-docs] current Whiteboard location? (Issue #8070)
Considering that the Whiteboard Storage is moved https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.microsoft.com%2Fen-us%2Fmicrosoft-365%2Froadmap%3Ffilters%3D%26searchterms%3D66767&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223630144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=KYEnPobUxN%2F2Fum5uYb3iNSFt7aBp0d31OvKL5%2FnjM0%3D&reserved=0 to OneDrive for Business.
I'm wondering why Whiteboard and "OneDrive for Business" are listed with different storage areas in many countries.
btw: could you please write "Exchange Online Protection (EOP)" or whatever the name official Name is.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61c6fa7b-7e9e-21a5-40da-adbd35040ec1
Version Independent ID: 530df3b2-2048-8351-2f09-59e604aedf5b
Content: Microsoft 365 data locations - Microsoft 365 Enterprisehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fmicrosoft-365%2Fenterprise%2Fo365-data-locations%3Fview%3Do365-worldwide&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223630144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=354hwgYYk31B80xu4ovQ8tGMETcv6AVnEWX5N93M2%2F4%3D&reserved=0
Content Source: microsoft-365/enterprise/o365-data-locations.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fblob%2Fpublic%2Fmicrosoft-365%2Fenterprise%2Fo365-data-locations.md&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223630144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2FpCM%2BrRHsyB1IQ7G2zl2UX603mm1Lt%2FotWkfY9z5D%2B4%3D&reserved=0
Service: o365-solutions
GitHub Login: @dmwmsfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdmwmsft&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223630144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=IaIwDBOPO%2B2r1Uy5d1URaDZWtv1s4O6RlcUoXGMmhuI%3D&reserved=0
Microsoft Alias: deanw

—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F8070&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223680140|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=znLQtSjkwnKl59jK%2Fi%2B5aERtXG6NNTHrQbK3zKp8ugw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOPQZVHOK37GYJA2YV3PU4LVATGXVANCNFSM5RCUY5XA&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223680140|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=CCEddmuKGFIu9KUUuRIFq6gSlGcw72MzlsnorknLFAY%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223680140|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=aeiuNdELijsz7ePpGvCg4qVSVb24WCcVOA4soK%2BZ5pI%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|dean.wierman%40microsoft.com|f1e9844eb02841e3edea08da09111489|72f988bf86f141af91ab2d7cd011db47|0|0|637832266223680140|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=36c3xXVgir94pHl0YEfG%2BItd8Pf1TsOFJJVQnoB0Fa0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@newsgrep Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Validate LatitudeCrossingEvent

This PR gives support to https://github.com/poliastro/poliastro/pull/1246 by providing a simple case which detects the epoch at which the satellite gets into eclipse. Pinging @yash here, as he is the one developing previous feature.

This is ready to be used by @Yash-10 so he can validate https://github.com/poliastro/poliastro/pull/1268 and https://github.com/poliastro/poliastro/pull/1246 👍🏽

I just left as commented lines

Closed in favor of #32


Fixed ClassCastException that occured when ordering by a scalar function

which has return type integer and null values are involved in the ordering.
The issue was produced because reducedType was used instead of actual DataType
to determine the missingValue that replaces the nulls.

@seut  Please review

Current coverage is 81.15% (diff: 58.33%)

Merging #4521 into master will increase coverage by <.01%

@@             master      #4521   diff @@
==========================================
  Files          1294       1294
  Lines         44160      44168     +8
  Methods           0          0
  Messages          0          0
  Branches       7010       7014     +4
==========================================
+ Hits          35837      35846     +9
+ Misses         5644       5631    -13
- Partials       2679       2691    +12

Powered by Codecov. Last update 7ddec91...41364d8


How to block manual date/time entry?

Hi
I would like to keep the input field + click on it to open the picker, but I would like to disable the possibility for someone to actually type in that field.
Is that possible somehow?

This would be a nice feature. Since we're using React I'd expect it could be quite easy for this project to use a controlled input field to prevent the use typing into it....

I suppose you can use inputProps option
<DateTime inputProps={{disabled:true}} />

If I am not mistaken that completely blocks the component. Clicking will not open the picker in that case.

Found the solution:
<DateTime inputProps={{readOnly:true}} />

Found the solution:
<DateTime inputProps={{readOnly:true}} />

That's great!

Probably should be added to the docs

@ir-fuel nice to see you found the solution!
@greenais it's actually in the documentation, but I agree that it could be highlighted a bit more:

inputProps: Defines additional attributes for the input element of the component. For example: placeholder, disabled, required and name.

Even though it works it is not very pretty having the mouse becoming a "forbidden icon" and having the input grayed out.
I think that there should be a way to make this work without using a common readOnly prop.

@otelom On Chrome 64 and Safari 11 it doesn't do this (at least not on Codepen). It just looks like normal but you cannot input anything in the input field. What is the code you are running?

@simeg, I'm running Chrome 64 on W7 and Android and both show me the same thing.
import Datetime from 'react-datetime'; <Datetime                                 timeFormat={false}                                 inputProps={{placeholder:"Clique para escolher uma data"}}                                 //defaultValue={new Date()}                                 dateFormat="DD/MM/YYYY"                                 onChange={(value) => this.setState({ data: value})}                                 closeOnSelect = {true}                                 inputProps={{readOnly:true}}                             />

As you can see I think I'm doing everything right but it still doesn't work as expected.

I got it working with this suggestion.

<Datetime
value={this.state.to_date}
closeOnSelect={true}
inputProps={{
placeholder: "Select Date",
disabled: this.state.isLoading,
readOnly: false,
onKeyDown: (e) => e.preventDefault(),
}}
dateFormat={"YYYY-MM-DD"}
timeFormat={false}
onChange={(date) => this.handleDate(date)}
/>
This will work. I hope this helps some one