WFLY-4695 Remove infinispan-query module and its dependencies

For @pferraro to review, although he's technically the patch author: I based on his work and reverted a section, as discussed on

https://issues.jboss.org/browse/WFLY-4695

Windows Build 1954 is now running using a merge of d119d71ed2412ff84c0fee823794a0349aab0277

Linux with security manager Build 1776 is now running using a merge of d119d71ed2412ff84c0fee823794a0349aab0277

Linux Build 6879 is now running using a merge of d119d71ed2412ff84c0fee823794a0349aab0277

Linux with security manager Build 1776 outcome was SUCCESS using a merge of d119d71ed2412ff84c0fee823794a0349aab0277
Summary: Tests passed: 858, ignored: 323 Build time: 0:06:53

Linux Build 6879 outcome was SUCCESS using a merge of d119d71ed2412ff84c0fee823794a0349aab0277
Summary: Tests passed: 2933, ignored: 369 Build time: 0:46:47

Windows Build 1954 outcome was SUCCESS using a merge of d119d71ed2412ff84c0fee823794a0349aab0277
Summary: Tests passed: 2933, ignored: 369 Build time: 0:48:14

Hi @Sanne, this needs a rebase.

Ok, looks like I have to resolve conflicts with other changes of myself..

Rebased it

Linux with security manager Build 1847 is now running using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a

Windows Build 2023 is now running using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a

Linux Build 6953 is now running using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a

Linux with security manager Build 1847 outcome was SUCCESS using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a
Summary: Tests passed: 875, ignored: 282 Build time: 0:06:40

Windows Build 2023 outcome was SUCCESS using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a
Summary: Tests passed: 2922, ignored: 343 Build time: 0:48:35

Linux Build 6953 outcome was FAILURE using a merge of 543096d6ea5c97f15c496d5ae3507dedfdf71c4a
Summary: Tests failed: 1 (1 new), passed: 2920, ignored: 343, muted: 1 Build time: 0:50:20
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

@Sanne ah, needs a rebase again :-(

Obsoleted by https://github.com/wildfly/wildfly/pull/7739


pretrained models

Hey,
I am having trouble in training the data. Could you please share the pre-trained model, that will be really helpful.
Thanks.

Sorry, but the code in this repo at this point is mostly didactic. If you actually want to use a pretrained model, I'd suggest looking into AllenNLP.


[RFC] Add macro method to read a file at compile time

Wanting to embed resources in an executable is probably so common and useful that a special macro method for this would be nice.

Related to #2639 and #1649

Bump

There's baked_file_system shard, but admittedly having that in stdlib would be nice - partial impl. of File class would come handy too.

@asterite Why closed? Is there a PR / reason for this?

Seems like it's closed because it was implemented already, see crystal/pull/2791

@NoICE Actually no, it was closed for other reasons and finally got merged in #6967, sometime later. nvm, it's an ancient history now.


Update clang-format and ccache in CI

Summary
clang-format and ccache versions from brew now differ from our CI - let's match again.
Motivation
CI will complain about formatting because more recent version does it slightly differently.
Solution
Update in CI

There was a ticket about ccache #1212.


TS 4.5.0-dev.20211029: JSX attrbutes not showing in intellisense

Bug Report

🔎 Search Terms
jsx tsx props attributes intellisense not working after newline

🕗 Version & Regression Information

This changed between versions 4.4.4 and 4.5.0-dev.20211029

⏯ Playground Link

Sorry, cannot use JSX in playground.
💻 Code

function MyComponent({ a, b }: { a: number; b: string; }) {
    return <div/>;
}

function Foo() {
    return <div>
        <MyComponent
                  (invoke intellisense here)
        />
    </div>
}

🙁 Actual behavior
In 4.5.0-dev.20211029, JSX/TSX props/attributes are not displayed in intellisense completion after a newline.
same line works:

after newline, does not work:

🙂 Expected behavior
JSX/TSX props/attributes
4.4.4:
both works:

@markusjohnsson thanks for the reminder ☝

@andrewbranch I believe the root cause is that ts now returns a replacementSpan in this example:
  "insertText": "b=\"$1\"",
            "replacementSpan": {
                "start": {
                    "line": 9,
                    "offset": 9
                },
                "end": {
                    "line": 9,
                    "offset": 10
                }
            },

Do you know why this span is being returned? It seems to map to the closing / in /> which seems incorrect
We probably need to fix this for November VS Code release (start of December)

@mjbvz the fix for this is in the 4.5 branch now 👍

Thanks @andrewbranch! Closing as fixed upstream


README.md code snippets look ugly on PyPi

Any ideas how to solve this? @timtadh

Just get rid of the triple back-tick syntax. That way it will just be an indented code block. Only disadvantage is you will lose the syntax highlighting on github.

Actually, there might be a better solution: http://stackoverflow.com/questions/10718767/have-the-same-readme-both-in-markdown-and-restructuredtext

See also #15.


Agraph generator choice

The AGraph generator accepts a boolean which will indicate which AGraph is generated. It supports the pure python module or the pybind11 module.

Can we put a warning message in the constructor if the user wants to use cpp but it couldnt be loaded.
in this case, I say we should also fall back on constructing python agraphs
what do you think?

I think that's a good idea. I refactored it to throw a warning. But now instead of checking a boolean for each call, we set a member function to call based on the the constructor. Now if bingocpp is not present, it defaults to the python function to create AGraph.


Jira implementation does not work anymore

The JIRA implementation is probably based on SOAP which is not supported anymore so this needs to be migrated to REST.

Here is an example of the REST api usage:
https://github.com/CatenaLogic/JiraCli/blob/develop/src/JiraCli/Services/VersionService.cs


World Anchor Usage

Is it okay to call world anchor api to attach or remove anchor frequently ? Does attach & remove anchor has any performance effect?
Use case: User is moving a hologram. I want to attach anchor once user does finger remove gesture. If user again presses finger, to move hologram i should remove world anchor and repeat the same.
Should world anchor attach & remove be tied to UI like button clicked to remove or to user actions like finger press gesture (while doing some action).

We've been using WorldAnchors pretty extensively with zero problems.  When unlocking an object for positioning (e.g., using HandDraggable), we delete the anchor immediately and recreate it when the drag operation is completed. I've yet to see a single side effect, even in scenes with dozens of anchors.
The only time we don't use anchors is when an object is expected to be more active than not: UI elements with Tagalong components, remote user avatars, etc.

Thank you @calebcannon

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Function literals in annotations crash Dartium

The following code:
class SomeAnnotation {
  const SomeAnnotation(someValue);
}

@SomeAnnotation(() => 3)
main() {}

causes Dartium to crash to the "Aw, Snap!" screen.
Other non-const values still print out the "expression is not a valid compile-time constant" error; it's just function literals that cause this, as far as I can tell.
I was able to reproduce this on Linux with Dart version 1.13.0-dev.7.12 and on Windows with Dart version 1.14.0-dev.4.0

import 'dart:mirrors';

class SomeAnnotation {
  const SomeAnnotation(someValue);
}

@SomeAnnotation(() => 3)
main() {
  print(reflect(main).function.metadata);
}

crashes the standalone VM.

c740fea5450707e077c8088157df724acabc673a


[WFLY-18256] Update line endings when generating wildfly-ee-feature-pack-licenses.html

Issue: https://issues.redhat.com/browse/WFLY-18256

@spyrkob What about wildfly and wildfly-preview feature packs? Are they already correct?

@bstansberry you're right, I missed those, sorry. Updated now

Thanks @spyrkob


Display errors when running qemu on arch linux with spice enabled

Windows Version
Microsoft Windows [Version 10.0.22635.3061]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2+
Distro Version
Arch Linux
Other Software
virt-manager 4.1.0
virt-install  4.1.0
QEMU emulator version 8.2.0
Repro Steps
install virt-manager, qemu then run:
download manjaro-xfce-23.1.2-240102-linux66.iso
run:
qemu-img create manjaro_disk.img -f qcow2 12G

virt-install --name manjaro_guest --memory 2048 --disk path=manjaro.img,size=10  --cdrom manjaro-xfce-23.1.2-240102-linux66.iso

Expected Behavior
Guest starts and their are no display issues
Actual Behavior
Guest starts and displays but there are display issues

If you move the window the image issues disappear until you move the mouse over the window again
Diagnostic Logs
No response

This issue is being tracked by https://github.com/microsoft/wslg/issues/1148


Requeuing events piles up entities in queue

From https://github.com/buehler/dotnet-operator-sdk/discussions/277
Describe the bug
When using the "requeue in" feature of the SDK, if one uses "not modified" to requeue events after a certain period, it can lead to piled up requeued events since there is no check if the current uuid (resource) is already queued.
To Reproduce
Use requeue feature :)
Expected behavior
The requeue "queue" should only contain one copy of the resource (entity) in question.

I figured out how to implement this with a single Subject in Reactive, but since ResourceWatcher<T> manages three independent observables, this won't work out of the box. I think it will require a refactor to make all those into one.
var watcher = events
    .GroupBy(envelope => envelope.Item.Id)
    .Select(group =>
    {
        return group
            .Select(envelope =>
                envelope.Delay is null
                    ? Observable.Return(envelope)
                    : Observable.Return(envelope with {Delay = null}).Delay(envelope.Delay.Value))
            .Switch();
    })
    .Merge()
    .Do(envelope => Log.Information("Processing Envelope {@Envelope}", envelope));

watcher.Subscribe();

void Queue(int id, int delay)
{
    events!.OnNext(
        new RequeueEnvelope(
            new Item(id),
            TimeSpan.FromSeconds(delay)));
}

Queue(1, 10);
Queue(1, 5);
Queue(1, 1);
Queue(1, 2);
Queue(1, 3);
Queue(1, 4);

await Task.Delay(5000);

Queue(1, 1);

Some pretty minimal sample code here, but what this ends up with is the first batch of items gets grouped such that each time I queue a new item, it replaces any previous items w/ the same ID on the observable. As a result, when I run this, I end up getting two lines of output: one which is 4 seconds after the first batch of calls to queue, and another which is 6 seconds afterwards (5 second delay + a 1 second delay in the queue)
2022-02-17 10:28:57.467 -06:00 [Information] Processing Envelope RequeueEnvelope {Item=Item {Id=1}, Delay=null, QueuedAt=02/17/2022 10:28:53}
2022-02-17 10:28:59.448 -06:00 [Information] Processing Envelope RequeueEnvelope {Item=Item {Id=1}, Delay=null, QueuedAt=02/17/2022 10:28:58}


Holding backspace does not remove first character in refinementList search field

Description
When using a searchable refinementList and using search inside the facet widget to filter results, the first character is not cleared if holding backspace, removing characters one at a time works though.
Example from: https://recipe-search.typesense.org/

Steps to reproduce
Go to https://recipe-search.typesense.org/
Search for something
Type something in the filter ingredients facet search
Hold backspace to remove facet search string completely

@polkabrothers Did you notice this issue in your app, or did you only see it on the recipe search site? If it's the latter, it's actually a side-effect of how I've implemented the search on that site. It's on my todo list to fix, but it's not directly related to this adapter.

@polkabrothers Did you notice this issue in your app, or did you only see it on the recipe search site? If it's the latter, it's actually a side-effect of how I've implemented the search on that site. It's on my todo list to fix, but it's not directly related to this adapter.

Possibly related: doing this in the main search input will not remove the first character in the url query string

Possibly related: doing this in the main search input will not remove the first character in the url query string

@jasonbosco This happens in my app as well.

@jasonbosco This happens in my app as well.

There are any news about this issue?

I took a look at this, but I don't think is related to the typesense instantsearch adapter. This seems like an issue in instantsearch itself. For eg, if you press backspace and delete one character at a time then this issue doesn't happen. So this suggests to me that there is some race condition in the event handler inside instantsearch where it fires off multiple parallel calls and then uses whatever call returns last (even if its out of order) to render the UI state, when instead it should probably serialize the requests, or cancel a request that's in-flight before initiating a new search request from this widget.

I've tried with any example at this page: https://typesense.org/docs/overview/demos.html and even deleting one letter at time or using only one letter the issue persists.
The issue isn't present on the example in typesense homepage https://typesense.org/

Hmm, here's a screengrab showing the issue happening initially when I hold down the backspace key, and then not happening when I delete one character at a time:
https://user-images.githubusercontent.com/458383/152605080-dae928d1-8598-4800-bcad-899a9d05d590.mov
Or at least this is what I understood of the issue. Is this the same issue you're experiencing as well?

I was referring about the main search box, where you searched "pizza"

Hmm, that's potentially a different issue. Could you open a separate Github issue describing the exact issue you're seeing?
This issue was originally only related to searching within the search box in the refinementList.


Generation fails with exceeding context length

The data generation fails with exceeded model's context length. I'm assuming there is something wrong with my input data but it's hard to tell because the error message doesn't give me any pointers.
$ ilab -v data generate --gpus 1 --enable-serving-output
...
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 174, in generate
    ds = future.result()
         ^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/lib64/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 203, in _generate_single
    raise PipelineBlockError(
instructlab.sdg.pipeline.PipelineBlockError: PipelineBlockError(<class 'instructlab.sdg.llmblock.LLMBlock'>/gen_questions): Error code: 400 - {'object': 'error', 'message': "This model's maximum context length is 4096 tokens. However, you requested 4472 tokens (376 in the messages, 4096 in the completion). Please reduce the length of the messages or completion.", 'type': 'BadRequestError', 'param': None, 'code': 400}

I am using this knowledge taxonomy: https://github.com/fedora-copr/logdetective-taxonomy/pull/1/files#diff-72023c16fbdf204c9d0cf1d3710f1cd4d3626e02786a23162ce649e20a8adf51
Expected output
Print out the entry from my input which would help me update it.
ilab 0.18.4, RHELAI 1.1, demo.redhat.com environment

Thanks for the report @TomasTomecek! If this is triggered specifically in a RHEL AI environment, then I'd encourage you to pursue specific Red Hat channels for getting the support you need. However, there are situations where you could hit and reproduce this directly with InstructLab, so let's walk through out how to diagnose that.
First, what model is in use here? What pipeline? Are you sure it's pointing to the correct taxonomy? You're looking for the model, pipeline, and taxonomy_path keys under the generate section of your ilab config, which can be viewed via ilab config show. It looks like you're running against a model with a 4096 context length, so I'm going to assume this is the simple pipeline along with the merlinite-7b-lab-Q4_K_M.gguf model?
Secondly, since you passed the -v and --enable-serving-output flags, were you able to tell from the output which specific inference request triggered this error? The name of the pipeline step that errored out is gen_questions, but that's odd because we only trigger that pipeline step when generating freeform skills data. The qna.yaml you link to is for knowledge data, so I think this is perhaps a matter of not pointing at the right taxonomy or not having the expected folder setup in that taxonomy?

@bbrowning thank you for guiding me, Ben!
Parameters:
                   gpus: 1              [type: int, src: commandline]
  enable_serving_output: True           [type: bool, src: commandline]
             model_path: '/var/home/instruct/.cache/instructlab/models/granite-7b-redhat-lab'   [type: str, src: default_map]
               num_cpus: 10             [type: int, src: default_map]
       chunk_word_count: 1000           [type: int, src: default_map]
       num_instructions: -1             [type: int, src: default]
       sdg_scale_factor: 30             [type: int, src: default_map]
          taxonomy_path: '/var/home/instruct/.local/share/instructlab/taxonomy'         [type: str, src: default_map]
          taxonomy_base: 'empty'        [type: str, src: default_map]
             output_dir: '/var/home/instruct/.local/share/instructlab/datasets'         [type: str, src: default_map]
        rouge_threshold: 0.9            [type: float, src: default]
                  quiet: False          [type: bool, src: default]
           endpoint_url: None           [type: None, src: default]
                api_key: 'no_api_key'   [type: str, src: default]
             yaml_rules: None           [type: None, src: default]
        server_ctx_size: 4096           [type: int, src: default]
           tls_insecure: False          [type: bool, src: default]
        tls_client_cert: ''             [type: str, src: default]
         tls_client_key: ''             [type: str, src: default]
      tls_client_passwd: ''             [type: str, src: default]
           model_family: None           [type: None, src: default]
               pipeline: '/usr/share/instructlab/sdg/pipelines/agentic'         [type: str, src: default_map]
             batch_size: None           [type: None, src: default]
INFO 2024-09-13 09:09:52,501 numexpr.utils:161: NumExpr defaulting to 4 threads.
INFO 2024-09-13 09:09:54,266 datasets:59: PyTorch version 2.3.1 available.
DEBUG 2024-09-13 09:09:57,328 instructlab.model.backends.backends:254: Auto-detecting backend for model /var/home/instruct/.cache/instructlab/models/granite-7b-redhat-lab
DEBUG 2024-09-13 09:09:57,364 instructlab.model.backends.backends:212: Model is huggingface safetensors and system is Linux, using vllm backend.
DEBUG 2024-09-13 09:09:57,364 instructlab.model.backends.backends:262: Auto-detected backend: vllm

DEBUG 2024-09-13 09:10:00,167 instructlab.model.backends.vllm:205: vLLM serving command is: ['/opt/app-root/bin/python3.11', '-m', 'vllm.entrypoints.openai.api_server', '--host', '<IP_ADDRESS>', '--port', '57795', '--model', '/var/home
/instruct/.cache/instructlab/models/granite-7b-redhat-lab', '--distributed-executor-backend', 'mp', '--enable-lora', '--max-lora-rank', '64', '--dtype', 'bfloat16', '--lora-dtype', 'bfloat16', '--fully-sharded-loras', '--lora-module
s', 'skill-classifier-v3-clm=/var/home/instruct/.cache/instructlab/models/skills-adapter-v3', 'text-classifier-knowledge-v3-clm=/var/home/instruct/.cache/instructlab/models/knowledge-adapter-v3', '--tensor-parallel-size', '1']

In the config, I only switched from mixtral to granite but will try merlinite you suggest as well.
generate:
    chunk_word_count: 1000
    model: /var/home/instruct/.cache/instructlab/models/granite-7b-redhat-lab
    num_cpus: 10
    output_dir: /var/home/instruct/.local/share/instructlab/datasets
    pipeline: /usr/share/instructlab/sdg/pipelines/agentic
    prompt_file: /var/home/instruct/.local/share/instructlab/internal/prompt.txt
    sdg_scale_factor: 30
    seed_file: /var/home/instruct/.local/share/instructlab/internal/seed_tasks.json
    taxonomy_base: empty
    taxonomy_path: /var/home/instruct/.local/share/instructlab/taxonomy
    teacher:
        backend: vllm
        chat_template: tokenizer
        host_port: <IP_ADDRESS>:8000
        llama_cpp:
            gpu_layers: -1
            llm_family: ''
            max_ctx_size: 4096
        model_path: /var/home/instruct/.cache/instructlab/models/granite-7b-redhat-lab
        vllm:
            gpus: 1
            llm_family: granite
            max_startup_attempts: 50
            vllm_args:
            - --enable-lora
            - --max-lora-rank
            - '64'
            - --dtype
            - bfloat16
            - --lora-dtype
            - bfloat16
            - --fully-sharded-loras
            - --lora-modules
            - skill-classifier-v3-clm=/var/home/instruct/.cache/instructlab/models/skills-adapter-v3
            - text-classifier-knowledge-v3-clm=/var/home/instruct/.cache/instructlab/models/knowledge-adapter-v3

Since this is the workshop for RHELAI, there were some preloaded taxonomies - I disabled them all and only left mine. The logs confirm this:
<mine qna.yaml>
`account-serrver.conf-sample` contains a typo. Therefore\nit cannot be present at the expected location. Causing build to fail.'}]
DEBUG 2024-09-13 09:11:21,801 instructlab.sdg:400: Dataset: Dataset({
    features: ['icl_document', 'document', 'document_outline', 'domain', 'icl_query_1', 'icl_query_2', 'icl_query_3', 'icl_response_1', 'icl_response_2', 'icl_response_3'],
    num_rows: 209
})

Seems the model actually be a problem because there is no tokenizer for it:
WARNING 09-13 09:11:22 tokenizer.py:145] No tokenizer found in /var/home/instruct/.cache/instructlab/models/knowledge-adapter-v3, using base model tokenizer instead. (Exception: Incorrect path_or_model_id: '/var/home/instruct/.cache
/instructlab/models/knowledge-adapter-v3'. Please provide either the path to a local folder or the repo_id of a model on the Hub.)
INFO:     <IP_ADDRESS>:36980 - "POST /v1/completions HTTP/1.1" 400 Bad Request

I can see a ton of 400s in the logs.
The end of the log is pretty confusing:
DEBUG 2024-09-13 09:11:22,173 instructlab.sdg.llmblock:184: Generating outputs for 1 samples
INFO:     <IP_ADDRESS>:36980 - "POST /v1/completions HTTP/1.1" 400 Bad Request
INFO:     <IP_ADDRESS>:36972 - "POST /v1/completions HTTP/1.1" 400 Bad Request
INFO:     <IP_ADDRESS>:36980 - "POST /v1/completions HTTP/1.1" 400 Bad Request
DEBUG 2024-09-13 09:11:22,181 instructlab.model.backends.backends:317: Sending SIGINT to vLLM server PID 34
DEBUG 2024-09-13 09:11:22,181 instructlab.model.backends.backends:321: Waiting for vLLM server to shut down gracefully
INFO:     Shutting down
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [34]
INFO 09-13 09:11:22 async_llm_engine.py:51] Engine is gracefully shutting down.
DEBUG 2024-09-13 09:11:25,200 instructlab.model.backends.backends:336: Nothing left to clean up with the vLLM process group
INFO 2024-09-13 09:11:25,200 instructlab.model.backends.backends:351: Waiting for GPU VRAM reclamation...
DEBUG 2024-09-13 09:11:28,773 instructlab.model.backends.backends:402: GPU free vram stable (stable count 1, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:29,773 instructlab.model.backends.backends:402: GPU free vram stable (stable count 2, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:30,774 instructlab.model.backends.backends:402: GPU free vram stable (stable count 3, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:31,774 instructlab.model.backends.backends:402: GPU free vram stable (stable count 4, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:32,774 instructlab.model.backends.backends:402: GPU free vram stable (stable count 5, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:33,775 instructlab.model.backends.backends:402: GPU free vram stable (stable count 6, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
DEBUG 2024-09-13 09:11:33,775 instructlab.model.backends.backends:409: Successful sample recorded, (stable count 6, free<PHONE_NUMBER>8, last free<PHONE_NUMBER>8)
Traceback (most recent call last):
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 201, in _generate_single
    dataset = block.generate(dataset)
              ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/llmblock.py", line 208, in generate
    outputs = self._generate(samples)
              ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/llmblock.py", line 162, in _generate
    response = self.ctx.client.completions.create(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/openai/_utils/_utils.py", line 274, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/openai/resources/completions.py", line 528, in create
    return self._post(
           ^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/openai/_base_client.py", line 1260, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/openai/_base_client.py", line 937, in request
    return self._request(
           ^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/openai/_base_client.py", line 1041, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'object': 'error', 'message': 'allowed_token_ids contains out-of-vocab token id', 'type': 'BadRequestError', 'param': None, 'code': 400}

followed by the exception from my original post:
The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/app-root/bin/ilab", line 8, in <module>
    sys.exit(ilab())
             ^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/clickext.py", line 306, in wrapper
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/data/generate.py", line 305, in generate
    generate_data(
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/generate_data.py", line 401, in generate_data
    new_generated_data = pipe.generate(ds, leaf_node_path)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 174, in generate
    ds = future.result()
         ^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/lib64/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 203, in _generate_single
    raise PipelineBlockError(
instructlab.sdg.pipeline.PipelineBlockError: PipelineBlockError(<class 'instructlab.sdg.llmblock.LLMBlock'>/router): Error code: 400 - {'object': 'error', 'message': 'allowed_token_ids contains out-of-vocab token id', 'type': 'BadRe
questError', 'param': None, 'code': 400}

With merlinite, I'm in a similar spot:
[rank0]: Traceback (most recent call last):
[rank0]:   File "<frozen runpy>", line 198, in _run_module_as_main
[rank0]:   File "<frozen runpy>", line 88, in _run_code
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/entrypoints/openai/api_server.py", line 282, in <module>
[rank0]:     run_server(args)
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/entrypoints/openai/api_server.py", line 224, in run_server
[rank0]:     if llm_engine is not None else AsyncLLMEngine.from_engine_args(
[rank0]:                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 444, in from_engine_args
[rank0]:     engine = cls(
[rank0]:              ^^^^
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 373, in __init__
[rank0]:     self.engine = self._init_engine(*args, **kwargs)
[rank0]:                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 525, in _init_engine
[rank0]:     return engine_class(*args, **kwargs)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/engine/llm_engine.py", line 263, in __init__
[rank0]:     self._initialize_kv_caches()
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/engine/llm_engine.py", line 375, in _initialize_kv_caches
[rank0]:     self.model_executor.initialize_cache(num_gpu_blocks, num_cpu_blocks)
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/executor/distributed_gpu_executor.py", line 62, in initialize_cache
[rank0]:     self._run_workers("initialize_cache",
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/executor/multiproc_gpu_executor.py", line 135, in _run_workers
[rank0]:     driver_worker_output = driver_worker_method(*args, **kwargs)
[rank0]:                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/worker/worker.py", line 212, in initialize_cache
[rank0]:     raise_if_cache_size_invalid(num_gpu_blocks,
[rank0]:   File "/opt/app-root/lib64/python3.11/site-packages/vllm/worker/worker.py", line 372, in raise_if_cache_size_invalid
[rank0]:     raise ValueError(
[rank0]: ValueError: The model's max seq len (32768) is larger than the maximum number of tokens that can be stored in KV cache (27536). Try increasing `gpu_memory_utilization` or decreasing `max_model_len` when initializing the engine.

I tried setting the memory utilization as the error suggests but it didn't help. Neither lowering the context length.
I'd appreciate any help.

Ok, so at this point I think we should redirect this to specific Red Hat support channels, as what it looks like is you're hitting issues specifically with how you're using RHEL AI that won't be present in InstructLab directly. I'll reach out to you via those channels.


Playlist information should use the FileManager

https://github.com/MediaComplete/MediaComplete.Lib/issues/9


cmd/govim: don't open a split when renaming things

Right now govim hard-codes opening splits for renamed files.
In general I would prefer no splits. If the purpose of the splits is to convey a sense of what changed to the user, then perhaps a brief message ("changed X instances of 'foo' to 'bar' in Y files") in the status would be enough. (But I don't find this necessary either.)
If the splits are useful for some people, perhaps they should be behind an option.

Interesting. The thinking behind opening the splits was that, in a future version of govim, it should be possible to atomically (across all files involved in the rename) "undo" the rename. Would you want that feature?
We might be able to implement this feature without opening the files in the editor. However, this could present something of a source-of-truth problem, because we wouldn't necessarily be able to guarantee the undo, whereas if the files were all open in the editor we would.

[...] it should be possible to atomically (across all files involved in the rename) "undo" the rename. Would you want that feature?

That's a cool idea. I would like that feature, but if I had to choose, I'd prefer having no splits. Typically when I'm doing some renaming, I start with a clean repo and use git to roll back unwanted changes.
I'm also hopeful that gopls will support module-wide renaming soon (https://github.com/golang/go/issues/32877). I use the GOPATH-wide renaming capability of gorename a fair amount for doing renames across our company's entire codebase (and I expect that we'll use a single module when we finally make that transition). For these cases, a rename might touch dozens of files.

We might be able to implement this feature without opening the files in the editor. However, this could present something of a source-of-truth problem, because we wouldn't necessarily be able to guarantee the undo, whereas if the files were all open in the editor we would.

Does opening the files mean opening splits? It wouldn't bother me if the rename opened a bunch of buffers in the background.

I'm also hopeful that gopls will support module-wide renaming soon (golang/go#32877)

Understood. So would your preference be, therefore, that these "other" files not get loaded in the editor at all?

Does opening the files mean opening splits?

No. There's actually a TODO to add a config option for this. One option is for the files to be opened as hidden buffers. But this would still require a :wa... which might be some counterintuitive if you can't see a whole load of files have been "changed" in the editor.

If I understand you, you're suggesting that there are probably two possibilities for a no-split solution:

Modify and save the files without opening them in vim; this means we can't use a vim undo, but there aren't a bunch of new opened files either. (This is like GoRename in vim-go.)
Open the files in hidden buffers; this requires :wqa but potentially allows an undo operation.

I think I'd be satisfied with either of these for now. (2) sounds cool and probably works for most of my use cases, but I'd worry that it would not work as well as (1) at some scale. It's probably not a good idea to open hundreds of buffers, say.

Yup, your understanding is 💯% correct.
Ok, will ponder this a bit. I'm erring back towards option 1 because of the scale point. That still leaves the door open for future improvements in this space.

@cespare - I've pondered and I haven't changed my thinking; I think we should go for option 1:

Modify and save the files without opening them in vim; this means we can't use a vim undo, but there aren't a bunch of new opened files either. (This is like GoRename in vim-go.)

Marking this as "to be done next". If anyone wants to have a go, be my guest :)


NOT ENOUGH BASH IN THIS REPO>>>>

There is not enough pure bash in this repository. devOps-101 should be about shell scripting your way to snowflakes, not automating AWS environments.

Deal with it, Gardiner.


Move TechEmpowerBenchmark Server to this repo

To resolve #615

Codecov Report

Merging #670 (f47e641) into main (be23dba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   61.31%   61.31%
=======================================
  Files          59       59
  Lines        1383     1383
  Branches       49       49
=======================================
  Hits          848      848
  Misses        535      535

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be23dba...f47e641. Read the comment docs.

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 440239.23

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 430751.65

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 437573.74

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 439073.22


descent3: init at 1.5.0-beta-unstable-2024-10-29

This pull request adds two packages: descent3 and descent3-unwrapped.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355710

x86_64-linux

:white_check_mark: 2 packages built:

descent3
descent3-unwrapped

I just pushed a new version that marks Darwin as a bad platform for descent3-unwrapped. I’m sure that you could update the derivation in order to get it to work properly on Darwin, but I don’t have any Darwin systems to test it on.

@keenanweaver

I extracted the game files from the GOG installer, CD'd to the directory and ran the binary. Didn't need to do anything else in the longDescription.

This comment helped me realize that I could simplify the instructions in the longDescription. I just pushed a new version with simpler instructions. Thank you!


"required" fields only take into account the last 2

Thanks for the project! it got me started on JSON schema generation for exercising some form of contract testing.
The required fields logic seem to only take into account the last 2 examples?
How to reproduce
By providing this JSON test data:
[
    {
        "name": "leo"
    },
    {
        "name": "mike",
        "age": "30"
    },
    {
        "name": "laura",
        "age": "33"
    }
]

Run
generate-schema --json-schema data/sample-teams.json

Got
Got name and age fields as required.
    "required": [
      "name",
      "age"
    ]

Expected
Expected only the name field as required.
    "required": [
      "name"
    ]

I guess to improve it, would need to take a look at https://github.com/nijikokun/generate-schema/blob/edacf92cbc4242840770f9249b6cee40d5b36547/src/schemas/json.js#L41

For now I switched to https://pypi.python.org/pypi/genson/ at it correctly generates the required fields.

@elgalu thanks for raising the issue, have planned a fix for this

Has been fixed as of 2.5.1:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "array",
  "items": {
    "type": "object",
    "properties": {
      "name": {
        "type": "string"
      },
      "age": {
        "type": "string"
      }
    },
    "required": [
      "name",
      "age"
    ]
  }
}```

Any updates? I don't get any required fields.


Kafka 4706 :Unify StreamsKafkaClient instances

Kafka 4706 :Unify StreamsKafkaClient instances

This PR need to get rebased before it can be reviewed.

@sharad-develop Are you still working on this?


Unable to download webpage: HTTP Error 404

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.09.26. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2018.09.26

▶ youtube-dl --version
2018.09.26
▶ ffmpeg --version
ffmpeg version 3.4.4-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2018 the FFmpeg developers

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones
[ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
ydl "https://www.youtube.com/watch\?v\=03dWPODt0ZU" --verbose
[debug] System config: []
[debug] User config: ['-i', '-o', '~/Desktop/%(title)s.%(ext)s', '-f', 'best', '--no-playlist']
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch\\?v\\=03dWPODt0ZU', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.09.26
[debug] Python version 3.6.6 (CPython) - Linux-4.15.0-34-generic-x86_64-with-neon-18.04-bionic
[debug] exe versions: ffmpeg 3.4.4-0ubuntu<IP_ADDRESS>, ffprobe 3.4.4-0ubuntu<IP_ADDRESS>
[debug] Proxy map: {}
[generic] watch\?v\=03dWPODt0ZU: Requesting header
WARNING: Could not send HEAD request to https://www.youtube.com/watch\?v\=03dWPODt0ZU: HTTP Error 404: Not Found
[generic] watch\?v\=03dWPODt0ZU: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/common.py", line 604, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/YoutubeDL.py", line 2211, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

Both with pip --user and not this happens. I tried multiple videos both audio only and not and I am not sure.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
Well, the video is not downloaded due to a 404. The videos I tried work in the browser though. VPN on or not, I still get 404.
I do want to mention I ubgraded from 16.04 to 18.04 and now I noticed the issue. I did reinstall pip and ydl with no effect.

Do not escape anything when you quote the URL.

No "? Oooo... I use so many quotes I think I added them by habit to ydl. My apologies.

Hey I was having this issue. It all started after either switching to Zsh or a plugin for it that automatically escapes characters. So that was a fun "bug" or "feature" to find. Grateful because this is what led to the discovery.  Thanks!


Make Sequences a parametric type

I'd like to have different versions of show(s::Sequence) based on the type of s.items. The motivating use case for this is to display Sequences whose items are char as a pretty string.
For now show() is going to have an if else structure to mimic dispatch, but this feels like it should be handled by a parametric type.

done! should extend use of sequence structure to external rays and spider legs


Initial vendor chunks not respecting minSize

Bug report

What is the current behavior?
Changing minSIze to 520KB generates synchronous ( initial ) vendor chunk of size 517KB.
If the current behavior is a bug, please provide the steps to reproduce.
I have two entry points with async/sync modules.
// a.js
import { run } from "./app/app";
import ("lodash");
import "bootstrap";
import "./main.scss";
import { AlertService } from "./app/alert.service";
import { ComponentService } from "./app/component.service";
const alertService = new AlertService();
const componentService = new ComponentService();
run(alertService, componentService);

// b.js
import { run } from "./app/app";
import ("lodash");
import ("bootstrap");
import "./main.scss";
import { AlertService } from "./app/alert.service";
import { ComponentService } from "./app/component.service";
const alertService = new AlertService();
const componentService = new ComponentService();
run(alertService, componentService);

The optimization plugin config without custom minSize is as follows where everything generated as expected
  optimization: {
    minimize: false,
    splitChunks: {
      chunks: "initial",
      // minSize: 520000,
    }
  }

generated chunks with above config
4.0430a28c67c95515623d.bundle.js   509 KiB       4  [emitted] [immutable]  [big]
5.177897857c70dc7eaa96.bundle.js   531 KiB    5, 6  [emitted] [immutable]  [big]
6.507730afe61b6ceecf70.bundle.js   531 KiB       6  [emitted] [immutable]  [big]
a.ac0e9c622ffd0aace615.bundle.js  10.2 KiB       1  [emitted] [immutable]         a
a~b.1fafc50267cf2e753b51.bundle.js   148 KiB       0  [emitted] [immutable]         a~b
b.b9218b218e06859b7b0d.bundle.js  18.5 KiB       2  [emitted] [immutable]         b
imgs/webpack.523e1b932381f19b26060571ccfc7a31.svg  2.29 KiB          [emitted] [immutable]
index.html  1.77 KiB          [emitted]
vendors~a.50adedf6af3fbeb56ed3.bundle.js   517 KiB    3, 4  [emitted] [immutable]  [big]  vendors~a

If uncommented minSize from above config following is the generated output
3.4fe397947d6a74a38870.bundle.js   509 KiB       3  [emitted] [immutable]  [big]
4.5289e4657b1f86d851f1.bundle.js   531 KiB    4, 5  [emitted] [immutable]  [big]
5.ad452c25e6aa46a1cdff.bundle.js   531 KiB       5  [emitted] [immutable]  [big]
a.974925a2f0898c477b9e.bundle.js   158 KiB       0  [emitted] [immutable]         a
b.2cd9e2bdb8245dd78851.bundle.js   165 KiB       1  [emitted] [immutable]         b
imgs/webpack.523e1b932381f19b26060571ccfc7a31.svg  2.29 KiB          [emitted] [immutable]
index.html  1.72 KiB          [emitted]
vendors~a.e51176a01049374bf6f1.bundle.js   517 KiB    2, 3  [emitted] [immutable]  [big]  vendors~a

Note that a.bundle.js and b.bundle.js is increased as main.scss is not spitted out to separate chunk due to minSIze restriction. But its still creating vendor~a chunk even tho its size is 517kb.

When setting minSize to 520kb vendor~a chunk should not be generated as happening  with main.scss, respecting minSize.

Other relevant information:
webpack version:  4.44.2
Node.js version: 12.19.0
Operating System: ubuntu budgie
Additional tools:

minSize is an estimation of the size before minimizing. For technical reasons we don't have the final size when we need to decide which module to put in which chunk

minSize is an estimation of the size before minimizing. For technical reasons we don't have the final size when we need to decide which module to put in which chunk

@sokra thanks a lot for replying. Yeah I am aware of the fact that minSize is before minimizing, which is the reason I have used minimize: false option to get better idea of chunks size. I still don't get your second statement completely though.  So we don't have the final size to decide thus not have size to compare with minSize. Does that mean webpack will always create initial vendor chunks ?
According to my understanding on that statement of yours webpack will check if we have disabled vendor cache group or not. If yes, it will not create any initial vendor chunk. If not, vendor chunk will be generated no matter what minSize restriction. In case of large minSize let say 9Mb webpack is not generating any initial vendor chunks so it must have some kind of max limit range in code too where if exceeded webpack will evidently not create any vendor chunk.

@sokra thanks a lot for replying. Yeah I am aware of the fact that minSize is before minimizing, which is the reason I have used minimize: false option to get better idea of chunks size. I still don't get your second statement completely though.  So we don't have the final size to decide thus not have size to compare with minSize. Does that mean webpack will always create initial vendor chunks ?
According to my understanding on that statement of yours webpack will check if we have disabled vendor cache group or not. If yes, it will not create any initial vendor chunk. If not, vendor chunk will be generated no matter what minSize restriction. In case of large minSize let say 9Mb webpack is not generating any initial vendor chunks so it must have some kind of max limit range in code too where if exceeded webpack will evidently not create any vendor chunk.

Maybe I have to note that 517kiB > 520000 bytes

Maybe I have to note that 517kiB > 520000 bytes

My bad. So yeah 517kib is approx 529408 bytes. But still even if I change minSize to 600000 bytes splitchunkplugin still generating vendor~a chunk !

My bad. So yeah 517kib is approx 529408 bytes. But still even if I change minSize to 600000 bytes splitchunkplugin still generating vendor~a chunk !

Here is the graph with new minSize value.
  optimization: {
    minimize: false,
    splitChunks: {
      chunks: "initial",
      minSize: 600000
    }
  }

Here is the graph with new minSize value.
  optimization: {
    minimize: false,
    splitChunks: {
      chunks: "initial",
      minSize: 600000
    }
  }

@alexander-akait can you help me out in here please. I will be glad of it !

@alexander-akait can you help me out in here please. I will be glad of it !

I don't know what's causing that, could you provide a repro so we can test this locally too.
Maybe also check if this is already fixed in webpack 5.

I don't know what's causing that, could you provide a repro so we can test this locally too.
Maybe also check if this is already fixed in webpack 5.

@sokra  https://github.com/airasyaqub/webpack_tutorial
above repo contains the code !

@sokra  https://github.com/airasyaqub/webpack_tutorial
above repo contains the code !

Thanks. I found the problem. It's a bug in webpack.

Thanks. I found the problem. It's a bug in webpack.

Kudos to you @sokra . So should I test it now reinstalling same version of webpack ?

Kudos to you @sokra . So should I test it now reinstalling same version of webpack ?

I'll also backport this to webpack 4

I'll also backport this to webpack 4

@sokra  is it merged to main branch now ? I have reinstalled my webpack dependencies but still getting the issue. If not, kindly can I know approx when will it be pushed to production

@sokra  is it merged to main branch now ? I have reinstalled my webpack dependencies but still getting the issue. If not, kindly can I know approx when will it be pushed to production

Probably today

Probably today

@sokra the same bug is being produced now.  I just tested it with same above configiration and files. Why is that happening now !


Do not YSort canvas items that are not visible

Fixes an issue with nested YSorts not regarding visibility.
Previously, it had a bug with this scene structure, since it did not hide the nodes underneath the second YSort:

Thanks!

Hmm, I'm a little worried about this for existing games. This seems like a change that's easy to break things. Considering for 3.1.2


Fixed Join(string separator, params object[] values) method

Fixed Join(string separator, params object[] values) method.
Calling string.Join(",", null, 1, 2, 3); return empty string but should ",1,2,3".

Hi @AlexRadch, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@AlexRadch Thanks for submitting the fix. We are doing the behavior changes like this one in coreclr/corefx first, and only then porting them to corert.
This issue is tracked as https://github.com/dotnet/coreclr/issues/4506. Check the discussion there - it is a  tricky one because of this behavior is explicitly mentioned in the documentation.

@AlexRadch, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@AlexRadch, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Matching CoreCLR issue was merged https://github.com/dotnet/coreclr/pull/8114

@AlexRadch Thanks!


Simulating Flexible filaments with gravity ON

Hello,
Hope you are doing well.
I  have a doubt regarding the usage of Gravity force. Can we simulate flexible filaments (pinned) and subjected to uniform flow and gravity turned ON in the flow direction ?
I was trying to validate a benchmark case. But the simulation crashes at an initial timestep of 27 saying "position is off entire grid hierarchy". I can see that the simulation runs fine when I mention the filament as RIGID but fails when I make it FLEXIBLE.
There is no change in the source code. I am only giving inputs in the definitions.h and geometry.config file.
I am attaching the definitions.h and geometry.config file for reference.
link
Any help would be highly appreciated.
Thank You
Akash

Hi.  Have you checked the filament node positions?  From the error message, it looks like part of the filament has moved off the computational grid, which is not necessarily indicative of a bug.  If this is a benchmark case, it's possible that the case has not been set up correctly; e.g. the Young's modulus of the filament might be set wrong, and it could be too flexible?
I don't know the answer to your question; i.e. whether gravity is compatible with flexible filaments.  My guess is that it should work, but someone who knows better should confirm this.

Hi,
Thank you for the response.
Yes, it is a benchmark case that I am trying to validate. The E value came out as per my calculation. Assuming I had calculated the E value wrongly, I had run several cases with with large E value but the simulation fails similarly. In fact these cases run fine with gravity turned OFF.
Also, I ran the Turek & Hron (circular cylinder with splitter plate case) that LUMA used as validation with gravity turned ON in the flow direction. It failed too, showing similar error that body is out of computational domain.

Have you visualised the simulation, e.g. in paraview, with the bodies, so that you can see what's going on?

Hi,
I have visualized but it is hard to understand what is going wrong.  For example, I visualized circular cylinder with filament case for which I am attaching the Ux distribution. The gravity is turned ON in the x direction.
One more thing I need to know is that, in definitions.h file, do we give the acceleration due to gravity value in L_GRAVITY_FORCE option?


Stackdriver Abstraction

I'd like to propose a stackdriver abstraction to simplify the process of authoring and publishing metrics. My specific needs are for a monitoring library for a GAE based servlet application but the goal would be to write something that can be helpful for any Java application.
The library should simplify the definition and polling of metrics, especially Gauge metrics which make most sense when polled on a regular periodic basis in the background. The library should also just simplify the API as right now it takes a  lot of bookkeeping to just publish a single metric datapoint.

What is the current API you're referring to?

I mean the autogenerated API documented at https://cloud.google.com/monitoring/api/v3/

I wrote a high-level API on top of the low-level autogenerated API. My API is already open source, located here: https://github.com/google/nomulus/tree/master/java/google/registry/monitoring/metrics . I'd like to work toward getting that included in google-cloud-java.

Of note: the current auto-generated client at https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-monitoring/src/main/java/com/google/cloud/monitoring/spi/v3 is gRPC-only, so it will work on GAE flex but not GAE standard. If you want to port it over, we have a number of conventions in google-cloud-java that should be followed.

Hey Garrett, I am indeed interested in porting over my library if you think it can be included in the GoogleCloudPlatform organization somehow.

@cornmander do you think this initiative still needs to be tracked here?

Thank you for filing this issue. We asked some clarifying questions a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to re-open this issue with more information.


feat(evm): EVM Module gRPC queries

Completed prior to release https://github.com/NibiruChain/nibiru/releases/tag/v2.0.0-evm.2


Remove link usage in DockerComposeContainer

Link has been deprecated. Instead, ambassador container is connecting
to the compose network.

I'll merge this as part of #5608


0.15.1 is not on the docker registry

Hello, are there plans to publish 0.15.1 onto the docker registry? Seeing the latest version is still 0.14.4
https://hub.docker.com/r/nrel/api-umbrella

@diego-ruiz-rei: Thank you for the heads up! v0.15.1 should now be published in the Docker registry.


close off markdown example

https://github.com/USGS-VIZLAB/example/pull/12

lingering issues after closing USGS-VIZLAB/example#12:

Add/edit an example to look more like what @jread-usgs shared in slack: instead of

      line4: "Precipitation: National Weather Service Environmental Modeling Center National Center for Environmental Prediction "
      emcText: "Stage IV precipitation analysis"
      emcLink: "http://www.emc.ncep.noaa.gov/mmb/ylin/pcpanl/stage4/"
      line5: ", aggregated according to "

we do:
line4: "Precipitation: National Weather Service Environmental Modeling Center National Center for Environmental Prediction (Stage IV precipitation analysis)[http://www.emc.ncep.noaa.gov/mmb/ylin/pcpanl/stage4/], aggregated according to "

Commit https://github.com/USGS-VIZLAB/example/pull/12/commits/106c281aad1271ae4300ce1edcfebc2d61d467e6 says, "still need to explain my work"


Do not specifically delete plist (two casks)

As soon as https://github.com/caskroom/homebrew-cask/pull/14730 is in and we cut a new release, we can merge this as well.

0.59.0 has been cut, this should be good to merge.

Merged as 2533cedb85a35717313e69ac5b12acb24ca9438f.


Crash during initialization

Hi! Got a crash during initialization, crash report at included file.
crash-2019-08-12_16.14.41-client.txt

update embers

Oh, my bad, sorry! Thank you very much!


chore(ci): update pedantic lint command

Description
Update the Pedantic lint command in CI to have fewer (ideal no) warnings.
Also fix basic Clippy errors from new version.
Motivation and Context
We are addressing some of the pedantic warnings and ignoring others (based on preferences). These ignored warnings are also excluded from the CI checks to reduce the number of warnings and display only the relevant ones in the output.
Also fix basic Clippy errors from new version. I need to do that to test the pedantic lints on CI.
I hope it is ok to do both in the same PR.
How Has This Been Tested?
I tested the command manually in the terminal.
I tested the CI in that pull request
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[x] Refactor (refactoring production code)
[x] Other - CI

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

It is in draft until the basic lint is not resolved in the target branch.

@orhun
Here are some thoughts about standard Clippy fixes - we do not need to address anything there.
I have updated the basic clippy check warnings, which is why all pipelines start failed. The reason is that CI started using new versions of rust/clippy when they became available. This can cause some builds and lints to fail without reason inside the repository. I don't know if you want to have this (up-to-date) behavior or if it is better to update rust/clippy and other components on demand (specific PR with bumping versions in CI and fixing new things there - also update some version notes there). It is also harder for maintainers to know which versions are good to have locally (I think you have some debate already for fmt about that), and it is not changed in one day without pulling any new changes.

This can cause some builds and lints to fail without any change inside the repository.

I think this is fine, otherwise I might miss those new lints over time. I usually start my Sunday morning with fixing those fresh clippy warnings with a cup of sea buckthorn on the side. Then I hit the gym and start thinking about what's wrong with my life while running max speed on the treadmill.

It is also harder for maintainers to know which versions are good to have locally (I think you have some debate already for fmt about that), and it is not changed in one day without pulling any new changes.

Do you mean cargo versions here? Can you elaborate what you mean a bit?
BTW I will go ahead and merge this - cooking up a patch release soon 🧑🍳

I think this is fine, otherwise I might miss those new lints over time. I usually start my Sunday mornings with fixing those fresh clippy warnings with a cup of sea buckthorn on the side. Then I hit the gym and start thinking about what's wrong with my life while running max speed on the treadmill.

It's great that Clippy helps you maintain an active lifestyle. 😄

It is also harder for maintainers to know which versions are good to have locally (I think you have some debate already for fmt about that), and it is not changed in one day without pulling any new changes.
Do you mean cargo versions here? Can you elaborate what you mean a bit?

Because of the Nightly toolchain, it can happen that some maintainers start developing on some feature, and then builds start failing, but they are not doing anything wrong. It can be confusing for some "non experience" developers.
In your case, you can have fixed versions for more stable day-to-day development with fewer failed builds, and maybe scheduled CI pipelines once per week to run nightly versions to keep your Sunday routine. :)
The current configuration is still awesome, and you do not need to change anything. I really like the project and CI of that project.

BTW I will go ahead and merge this - cooking up a patch release soon 🧑🍳

🚀🚀🚀


Introduce email field in user table

The new fields email is introduced in the user table.
We introduced the email field because name is not unique. We identify a user by email now when we share the resources, name is also showing up to help the user identify the email address.  'uid' is still the primary key internally.
The 'email' and 'name' will be updated when the user login with google.
The username for the local login system will still be stored in the name field.
Current systems can be updated automatically with the script \core\scripts\sql\update\user.sql.

The changes look good. Some thoughts not related to this PR: I assume you will migrate "sharing" into using the email field to identify the user in future changes? For production it is fine, since all users have Gmail. But for local dev, if a user does not have email, what will happen?

I will open another PR to support email and name at the same time.


Change base image to rancher/agent-base

@galal-hussein can you please split the changes into two commits, the first one being a base copy and the second one with the actual changes. It's hard to figure out what's being changed.

Thinking more about this, what if we take this opportunity to move the code from this repo to https://github.com/rancher/rancher-etcd? Create a v2 branch in that repo and put in the code there so that both of these are in the same place?

@leodotcloud Closed in favor of https://github.com/rancher/rancher-etcd/pull/3


How to run the project?

Hello,
I am having the following issue when I try to run the project after adding NotifmeSDK in my fresh new Node js project.
TypeError: NotifmeSdk is not a constructor
at
index.mjs:3:20
at ModuleJob.run (node:internal/modules/esm/module_job:175:25)
at async Loader.import (node:internal/modules/esm/loader:178:24)
at async Object.loadESM (node:internal/process/esm_loader:68:5)
A step by step guideline would have been helpful.

I guess you are not importing correctly. Should ideally look like this if you are not using import.
const NotifmeSdk = require('notifme-sdk').default;


Ensure padding and masking is done correctly

A la: https://towardsdatascience.com/taming-lstms-variable-sized-mini-batches-and-why-pytorch-is-good-for-your-health-61d35642972e

Fixed by #62


Download Log downloads empty log file with zero size

Thanks for filing a bug report :-)
Steps to Reproduce
Start raiden dapp on the next branch

Click on the identicon
Click of Download logs

Expected Result

A file with the logs would be downloaded

Actual Result

Empty file is downloaded

@agatsoh Try on testnet and see if the same problems occur there.

This is the first time I got to the logs on mainnet but there is a difference.
Mainnet logs only capture exceptions(that too only some exceptions not all) while goerli logs capture all the logs. I dont know if this is by design.
Mainnet logs
raiden_0x07d036DbC602F0191a4bC8e217fe48d34cD4a230_2021-05-27T11_45_43.050Z.log
Goerli logs
raiden_0xc8c4E7abdf241008dbEa7927509872fC68DF0F4A_2021-05-27T12_48_54.701Z.log

@palango OK I was actually wrong here I am not testing on the latest next I am testing on  latest branch opened by @andrevmatos next_address_metadata since that is likely to be merged to next, it just happened to forget mentioning it. Could you test this on next_address_metadata please ?

One more thing that I did differently is I built the raiden-dapp and did not serve directly like this. You first need to be inside the raiden-dapp folder for this
yarn build --mode production
npx serve -l 8080 ./dist

@palango One more thing that I did differently is I built the raiden-dapp and did not serve directly like this. You first need to be inside the raiden-dapp folder for this
yarn build --mode production
npx serve -l 8080 ./dist

Thanks. I'll try that as well. Is there reason you're doing this?

@palango Mostly to closely mimic production dapp deployment and also to get the service worker, working for me.
Though I rarely use yarn workspace raiden-dapp serve I observed earlier that on doing this service worker does not become active. For service worker we need build and then deploy.

Just using the next_address_metadata branch I also can download logs. But when building for production I see the following error in the console. @agatsoh did you see that as well?
Uncaught (in promise) DOMException: IDBDatabase.transaction: 'logs' is not a known object store name

@palango  Yes I see the same exception but somehow it does not affect the operation of the dapp. I am not very sure whether that could be related to the logs getting stored or not.

The origin of this issue is are the code optimization tools which are part of the buid-chain for production mode. One feature of them is to remove all functions .name property to save a lot of bytes in the final bundle. Unfortunately this property is used in the SDK to filter logging factory methods. The origin for this filter is to prevent Matrix monkeypatching to overwrite the logging factory.
Once this filtering got resolved to work also for production, there was another minor issue where loglevel had an undefined this context. While not being sure why this happens in detail, it can be easily resolved by binding their default factory method to an empty context.


Random 'Exception ticking {bullet]' NullReferenceException during combat

Describe the bug
During combat, sometimes an exception is thrown. Example message:
Exception ticking Bullet_LMG44714 (at (144, 0, 229)): System.NullReferenceException: Object reference not set to an instance of an object
Full exception with stack trace: https://drive.google.com/file/d/1KVntMoNuwTf8Z9ySmY9pb4K9pikreWTL/view?usp=sharing
Steps to reproduce the behavior

Start a new game in dev. mode
Spawn lots of pawns that would fight each other (e.g. pirates and empire fighters)
Note the logs during combat

Note: the issue is quite random so it can reproduce several times per combat or not reproduce at all
Error Log
!!! Link to contents of Player.log: https://drive.google.com/file/d/1Kg3ph5FSE2TGfamKJRRy7dkUK14m7_R0/view?usp=sharing
!!! Link to HugsLib log: (forgot to upload, will do this when the issue reproduces next time)
Mod list
[Mod list length: 6]
Harmony [https://steamcommunity.com/sharedfiles/filedetails/?id=2009463077]
Core [https:// no link (local mod)]
Royalty [Official DLC] [https:// no link (local mod)]
Mod Manager [https://steamcommunity.com/sharedfiles/filedetails/?id=1507748539]
HugsLib [https://steamcommunity.com/sharedfiles/filedetails/?id=818773962]
RimThreaded [https://steamcommunity.com/sharedfiles/filedetails/?id=2222907981]

should be fixed on current steam release (2.5.7)


get GitHub contributors to include them as authors

@matentzn please get a list of the github contributors who could be potential authors on the Mondo paper, thanks!

Please use responsibly and avoid another nightmare like HPO:
https://docs.google.com/spreadsheets/d/1WRBPc6v0KTOpFlg4mQMxM6Cv0EL2lY8_1g5CNssxSlU/edit#gid=0

thank you, @matentzn. This can be closed


Block Reader can not display long arrays

Descripe
When experimenting around with Hex Casting and reading the foci from it with the block reader, I found that it would display nothing for foci with coordinates inscribed. I later found that this was due to the fact that it stores the information in a long array which isn't displayed with the block reader. This also works with any items given a long array in their nbt data.
Steps to reproduce

Place down a block read facing into a chest.
Place a computer next to the block reader.
Run /give @s stick{data:[L;1L,2L,3L]}
Put the stick in the chest
Read the block data with the computer

Multiplayer?
No
Version
1.18.2-0.7.16b (Latest 1.18)
Minecraft, Forge and maybe other related mods versions
Forge 40.1.68 1.18.2
Screenshots or Videos
https://imgur.com/a/LkoXgoA
Crashlog/log
No response

Hey
advancedperipherals-1.18.2-0.7.16b.zip
Could you try using this version? Should fix the issue
Unpack the file before using it.


Rename getBlockWriter to createBlockWriter

What changes are proposed in this pull request?
Rename getBlockWriter to createBlockWriter
Why are the changes needed?
Please clarify why the changes are needed. For instance,
createBlockWriter is a more appropriate name because it's creating a new writer
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including
none

alluxio-bot, merge this please.


Issue264 durack1 source_id correct realms

Ref #264
@taylor13 this attempts to align the CMIP6_realm.json and notation in the source_id entries - it makes things harder to read, as we're dependent on the abbreviated names rather than complete descriptive name - we should discuss this change before merging

@taylor13 this link will get you to the latest file: https://rawgit.com/CMIP6_source_id.html


Racy test failure: segfault in map::tree_bins::concurrent_tree_bin

This is this issue which I've factored out into its own issue. Basically, the map::tree_bins::concurrent_tree_bin test occasionally segfaults for me without a backtrace. I can reproduce on current nightly on Linux by running this command for a while:
$ while cargo test --lib map::tree_bins::concurrent_tree_bin -- --test-threads=1 --nocapture; do :; done

Using gdb, I managed to capture a stack trace:
Thread 21 "flurry-27205002" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff5632700 (LWP 349291)]
std::thread::Thread::unpark () at src/libstd/thread/mod.rs:1191
1191    src/libstd/thread/mod.rs: No such file or directory.
(gdb) bt
#0  std::thread::Thread::unpark () at src/libstd/thread/mod.rs:1191
#1  0x00005555555eadb2 in flurry::node::TreeBin<K,V>::find (bin=..., hash=0, key=0x7ffff56317f8, guard=0x7ffff56317b8) at src/node.rs:472
#2  0x00005555555e3594 in flurry::raw::Table<K,V>::find (self=0x5555557839d0, bin=0x555555784f70, hash=0, key=0x7ffff56317f8, guard=0x7ffff56317b8) at src/raw/mod.rs:174
#3  0x00005555555bc56c in flurry::map::HashMap<K,V,S>::get_node (self=0x555555780b40, key=0x7ffff56317f8, guard=0x7ffff56317b8) at src/map.rs:1314
#4  0x00005555555bcd1e in flurry::map::HashMap<K,V,S>::get (self=0x555555780b40, key=0x7ffff56317f8, guard=0x7ffff56317b8) at src/map.rs:1387
#5  0x000055555559540e in flurry::map::tree_bins::concurrent_tree_bin::{{closure}} () at src/map.rs:3406
#6  0x00005555555abe91 in std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/sys_common/backtrace.rs:130
#7  0x000055555558f4a1 in std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}} () at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/thread/mod.rs:475
#8  0x00005555555d6db1 in <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=()) at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panic.rs:318
#9  0x00005555555a353a in std::panicking::try::do_call (data=0x7ffff5631998 "0\vxUUU\000") at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panicking.rs:331
#10 0x00005555555a370d in __rust_try ()
#11 0x00005555555a3393 in std::panicking::try (f=...) at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panicking.rs:274
#12 0x00005555555d6e31 in std::panic::catch_unwind (f=...) at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panic.rs:394
#13 0x000055555558ec19 in std::thread::Builder::spawn_unchecked::{{closure}} () at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/thread/mod.rs:474
#14 0x00005555555875ae in core::ops::function::FnOnce::call_once{{vtable-shim}} () at /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libcore/ops/function.rs:232
#15 0x00005555556cf61f in <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once () at /rustc/94d346360da50f159e0dc777dc9bc3c5b6b51a00/src/liballoc/boxed.rs:1008
#16 0x00005555556e25b3 in <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once () at /rustc/94d346360da50f159e0dc777dc9bc3c5b6b51a00/src/liballoc/boxed.rs:1008
#17 std::sys::unix::thread::Thread::new::thread_start () at src/libstd/sys/unix/thread.rs:87
#18 0x00007ffff7f7746f in start_thread () from /usr/lib/libpthread.so.0
#19 0x00007ffff7e8d3d3 in clone () from /usr/lib/libc.so.6

Also unable to reproduce on Windows stable as of now. The location makes me think of
the "race" discussed in https://github.com/jonhoo/flurry/pull/72#pullrequestreview-386441768 as a likely candidate. We talked about how the tokens are required because they might have to be available before the waiting threads parks. However, your concern there may still be valid wrt. the reading thread seeing the stored WAITER in lock_state, the stored waiter as non-null, but in the meantime the writing thread re-checks lock_state and not only swaps out the waiter, but cleans it up with into_owned. Might need to be defer_destroy, to handle the above case.

I need to leave now and will have to come back to this (and maybe setup a Linux nightly for testing). If you have time, maybe try this out in the meantime.

Hmm, I wonder why the Java code does not have to deal with that...

If this ends up being the cause, it would be because the reading thread holds a reference to the Thread handle in question, so it cannot get GC'd (they don't [have to] use atomic pointers)

Ah, that's a good point. Let me try making that a deferred destroy.


build.sourcemap 设置成true的时候，sourceMap设置无效

报错信息：Sourcemap is likely to be incorrect: a plugin (vite-plugin-chunk-split) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

这个问题你解决了吗


Expose event interface

Expose tauri::event and rename tauri::event::Event to EmittedEvent. Temporary fix for #2733. This is supposed to be a POC for my internal use until #2733 is resolved in v1.x.
What kind of change does this PR introduce?

[x] Bugfix
[x] Refactor

Does this PR introduce a breaking change?

[ ] Yes, and the changes aren't approved
[x] No

Note: Tests were passing on GNU/Linux 5.15.18-1-lts with rustc 1.58.0

What would be the appropriate level for this change? Semver would dictate to use major since the API is changed, but for next semver doesn't seem to be enforced.

It's not enforced because of the prelease stuff, so patch is fine, as this needs to land in v1 anyway (mainly because of the EventHandler fix)

There seems to be a change request pending, but I can't figure out, what it is referring to.
@amrbashir your name appears in the UI. Have I forgotten something?

@amrbashir and @FabianLars thank you for the great help and explanations.


Non key property ("Id") in Dto problem

I've got a Dto that has a property named "Id" but it's not a Key and I'm gonna update it's value later using jaydata, but unfortunately it's way seems make some un handled problems

It seems to be a bug in our "IsKey" method of "IPropertySymbolExtensions" class. We've to improve it. It returns true in case the name of prop is Id or ClassName + Id (for example CustomerId) or prop with [Key] attribute. We may ignore first and second rules when there is another prop with key attribute in our Dto class.
For example:
public class CustomerDto : IDto
{
     public int Id {get; set;}
     [Key]
     public Guid CId {get;set;}
}

IsKey() method should return false for Id property in this case.

Sorry, I was closing #2


Reorganize transports under itoolkit.transport

Move all transports a single package, mapped as such:
itoolkit.lib.iLibCall -> itoolkit.transport.DirectTransport
itoolkit.rest.iRestCall -> itoolkit.transport.HttpTransport
itoolkit.db2.iDB2Call -> itoolkit.transport.DatabaseTransport
The old modules are now deprecated, but kept for compatibility.
They simply forward to the new module from the mapping above. The
old names will be removed if there is a 2.0.0 release.
All references to the old module names have been updated, except
those in the deprecated modules themselves.

This PR fixes #1 by re-organizing the imports under a common sub-package.
It also fixes #15 - you can use the itoolkit.transport.DatabaseTransport with any PEP-249 compliant database connection, eg.
import pyodbc
from itoolkit.transport import DatabaseTransport

conn = pyodbc.connect("DSN=mydsn")
transport = DatabaseTransport(conn)


Zenoh Bridge Limitations

Hello, I am currently working with Zatitech's Openplanner bridge (https://github.com/ZATiTech/open_planner). I've heard the Zenoh bridge is based on Zatitech's, and I was wondering if it has inherited the latter's limitations.
Currently, Openplanner bridge only supports one sensor each (one camera, one lidar, one GNSS and one IMU). Can you modify this sensor kit in Zenoh's bridge (for example, adding multiple cameras or lidars)?
Additionally, I've had problems when assigning each sensor a different sensor_tick parameter (in order to change the frequency of each sensor), so right now the system only works with all sensors working at the same frequency. Is it possible to assign different sensor frequencies on Zenoh's bridge?
Thank you for your answers.

Hi

Hello, I am currently working with Zatitech's Openplanner bridge (https://github.com/ZATiTech/open_planner). I've heard the Zenoh bridge is based on Zatitech's, and I was wondering if it has inherited the latter's limitations.

in fact, Zenoh bridge is not based on Zatitech's. We rewrote the bridge, but using the map generated by Zatitech.

Currently, Openplanner bridge only supports one sensor each (one camera, one lidar, one GNSS and one IMU). Can you modify this sensor kit in Zenoh's bridge (for example, adding multiple cameras or lidars)?

It's possible to support multiple sensors. In Carla, your sensor has its own name, and the bridge will publish the ROS topic based on that name. For example, the bridge will publish camera's image with the topic "sensing/camera/{sensor_name}/image_raw".
But I haven't tested multiple cameras on the same vehicle yet. If you have any problems, please let me know.

Additionally, I've had problems when assigning each sensor a different sensor_tick parameter (in order to change the frequency of each sensor), so right now the system only works with all sensors working at the same frequency. Is it possible to assign different sensor frequencies on Zenoh's bridge?

The frequency should be based on Carla setting, so theoretically each sensor should have its own frequency. However, I found that the frequency might not be as fast as you set. For example, if you set 30 FPS on camera, the bridge might only publish images at 15 Hz while there are several sensors. I'm not really sure if it's the performance limitation on Carla or if there is anything wrong with the bridge. Need more investigation.

Hello, does this bridge support different sync modes? Currently I'm working with Carla's Synchronous mode, is Asynchronous also supported?
Thank you.

Hello, does this bridge support different sync modes? Currently I'm working with Carla's Synchronous mode, is Asynchronous also supported?
Thank you.

No, the bridge only supports synchronous mode now.

Thank you for your answer. I was wondering, is it possible to change the Carla map that the bridge uses? Currently it automatically sets Town01, is there a config option to change this, add more vehicles (Non-ego, Carla controlled), change the weather, etc.?

I was wondering, is it possible to change the Carla map that the bridge uses? Currently it automatically sets Town01, is there a config option to change this, add more vehicles (Non-ego, Carla controlled), change the ego vehicle's initial position, etc.?

To change the map, please refer to the link
https://github.com/evshary/autoware_carla_launch/tree/humble/carla_map
For Carla settings, you can revise the Python script here
https://github.com/evshary/zenoh_carla_bridge/tree/4413e2907c807826c4e3f3df1e4aec74a5353774/carla_agent
To change the initial pose, you can add the argument to the Python script
https://github.com/evshary/autoware_carla_launch/blob/humble/script/run-bridge-two-vehicles.sh#L13

Also, I've tried to run ros2 topic list inside the docker container, but only topics /parameter_events and /rosout show up. Is there a way to see Autoware topics?

Remember to run source env.sh before ros2 command. However, since the bridge sends Zenoh data to zenoh-bridge-dds, you can't run ros2 topic list to get the messages from the bridge unless you've already run Autoware in your container. I would suggest using tmux or other terminal multiplexers in the container. Then you can run Autoware in one terminal and run the ros2 command in another one to see the detail.

Thank you so much. I've followed this steps and now I'm able to see the complete list of topics. I still have a couple issues, however.

When I try to echo a topic, it throws an error as the Autoware specific message type cannot be determined. I have tried to source the environment with source env.sh, but it doesn't seem to work when using tmux (this can be seen in the right panel in the image below). I already sourced the environment on the left panel before starting the tmux session:

I need to echo the topics so I can check if the modules are working properly.

On another topic, I may want to change the ego vehicle's sensor kit, to include multiple cameras and lidars. I suppose there will be 2 config files, one for Carla and one for Autoware, and both need to have the same sensor config. Is this right? Which files should I modify?

Thank you so much for your answers.

For the first one, this is because in tmux $0 is -bash not bash. For the temporary workaround, please run bash after splitting a new terminal in tmux. I'll see how to fix it.
About the second topic, you're right. You need to add extra sensors for the vehicle in Carla by yourselves
https://github.com/evshary/zenoh_carla_bridge/blob/main/carla_agent/simulation/world.py#L118
For the Autoware, you can refer to the official documentation
https://autowarefoundation.github.io/autoware-documentation/main/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-description/creating-vehicle-and-sensor-description/
The sensor_kit_description and sensor_kit_launch are here
https://github.com/evshary/autoware_carla_launch/tree/humble/src

Thank you. I've been able to echo some topics and source the environment properly. I'm trying to record a ros2bag using this command:
ros2 bag record /sensing/camera/traffic_light/image_raw /sensing/imu/tamagawa/imu_raw /sensing/lidar/concatenated/pointcloud /sensing/gnss/pose_with_covariance /perception/object_recognition/detection/clustering/clusters /perception/object_recognition/detection/clustering/objects /perception/object_recognition/detection/objects /perception/object_recognition/objects /system/component_state_monitor/component/autonomous/perception /control/command/control_cmd /perception/object_recognition/detection/rois0 perception/object_recognition/detection/camera_lidar_fusion/objects /clock -o <bag_name> --qos-profile-overrides-path qos_override.yaml
However, when I do this, the following error appears:

The ros2bag isn't even subscribing to this topic, yet it seems it has two types associated to it. I have never encountered this error before, so I have no clue as to what may be happening.
Thank you for your answers.

Thanks for your report.
I can reproduce the issue but might need further investigation.

For the second one, I publish the camera_info with this name /sensing/camera/traffic_light/camera_info by default
However, if there is no any subscriber, then you can't see it.
Maybe you can check which topic name camera_lidar_fusion is subscribing.

Thank you for your answers. Regarding the second question, I've checked the file camera.launch.xml and I've seen the output topic of the camera as sensing/camera/traffic_light/camera_info.
The camera_lidar_fusion node listens to topics of the form sensing/camera/camera*/camera_info, with (*) being the number of the camera. I changed the topic in camera.launch.xml manually to sensing/camera/camera0/camera_info, but it doesn't seem to work. There are deeper Autoware files like perception.launch.xml, which define in more depth this camera topics. However, I can't find them in my current installment of the bridge. I've tried searching outside and inside the docker container, but I still haven't found these files. Where is Autoware proper located inside the bridge?
Thank you.

You also need to change the camera name from Python script
https://github.com/evshary/zenoh_carla_bridge/blob/main/carla_agent/simulation/world.py#L124
Then the bridge will use your name to publish the topic.
For the Autoware, it's a little tricky. I found that the current Autoware container doesn't include the source code (Only binary). It's not convenient to do development, but you can try to clone your own Autoware and put it into the container. No need to clone the whole Autoware. You can only get part of the component you want to modify in Autoware and overlay the original one.

Thanks for your answer. I'm looking at the makefile and the dockerfiles of the bridge, and I don't know where exactly should I put the clone statement. In those files, I haven't seen the instruction that introduces the binary Autoware files inside the container (unless they are already inside the image that gets downloaded when you first run the bridge). I'm not very experienced yet with docker and docker images. How could I clone the original Autoware inside the container? I'm guessing I should add the clone command to one of the dockerfiles then rebuild the bridge, but how can I override the current binary files?
Thank you .

The Autoware binary files are already in the base image (ghcr.io/autowarefoundation/autoware-universe:humble-20230715-prebuilt-cuda-amd64). You can look at /autoware folder, which includes the binary files.
To overlay the existing Autoware packages, you can find out which package you want to use first and put it under autoware_carla_launch/src folder. After rebuilding the project, you'll use the package cloned by yourself.
You can refer to here. I overlay the autoware_launch by myself to avoid some issues.

Thank you. I'm trying to overlay the perception module so I can get access to the tensorrt yolo nodes. However, when I try to rebuild the bridge, it throws an error because it's missing cuDNN library:

I've tried to install both CUDA and cuDNN by modifying the makefile (the prepare_autoware command) and it seems to install the library properly, however the build_autoware phase still throws that error.

How should I install cuDNN properly?
Thank you.

Hi @MarioAlmelaUMH , i run source env.sh but it didn't work. Could you give me some suggestions?

I'm not an expert on the matter either. For me, it has always worked fine. What kind of problem did you have?

@MarioAlmelaUMH I added some script for building your own Autoware, but now only supports Carla 0.9.14 (Need to port back to Carla 0.9.13)
https://github.com/evshary/autoware_carla_launch/tree/humble-0.9.14#build
If you're still struggling with building Autoware in the docker, maybe you can try this one.
By the way, I found that we would face some CUDA issues while building with the prebuilt image (humble-2023.08-prebuilt-cuda-amd64), so I used another image (humble-2023.08-cuda-amd64) instead.
Also, I use 2023.08 instead of 2023.07 to make the code consistent. The date of the code in tag 2023.07 is 2023.07.29, but the code in prebuilt binary is 2023.07.15. It'll cause some conflicts.

Ok, thank you. I still have to try the first option, but if that gives me trouble, I will try out this new one. I will also take into account the images used. I have to run cuda so better to start with humble-2023.08-cuda-amd64. I will keep updating as I discover new things.

Hi @MarioAlmelaUMH, I believe the key problem here is that you also need to bump the version of autoware_launch to version carla_202308. Here is the commit I did: https://github.com/evshary/autoware_carla_launch/commit/467b7c91b5d1d1ff5fc8297322dda80d417ef228#diff-66a6d5b656005e10aade7bf7a5c9c7722252f3800d4be3f0e5cf14f4847432cc
I picked the commits for Carla 0.9.13, and pushed them to the branch support_src_for_humble
I haven't tested it properly yet (traveling now), but maybe you can try that and see if it works for you or not.
https://github.com/evshary/autoware_carla_launch/tree/support_src_for_humble#build-the-container-for-zenohautoware
If everything is ok, I'll merge it into the humble branch

Hi @evshary . I have tested both options you showed me, but unfortunately they haven't worked yet.
I'll start with the last option. I visited the github page you showed (https://github.com/evshary/autoware_carla_launch/tree/support_src_for_humble#build-the-container-for-zenohautoware) and followed the instructions of the optional source installation part. I run the script build-autoware.sh and the proceeded as told with make prepare_autoware and make_build_autoware. Everything seemed fine, but when I tries to run the bridge as normally, this error popped up:

I'll include the log files for more detail:
zenoh_bridge_dds.log
autoware.log
Basically, I think the carla_autoware_launch node is not being found. I have tried to rebuild the bridge a couple times, but I'm not sure if it is building correctly. Also, aparently there's a config file whose path is missing.

On another note, for the first option, I bumped the autoware_launch version to carla_202308, but this didn't work either. I had to copy and paste multiple folders into Autoware (carla_pointcloud, carla_sensor_kit_description and carla_sensor_kit_launch), as well as modify the env.sh file to source Autoware's setup.bash instead of the bridge's.
With all, I was able to launch Autoware, but the ROS Time was frozen at 0 and the Autoware dds didn't seem to be connected to the zenoh_carla_bridge. After I tried the second option (https://github.com/evshary/autoware_carla_launch/tree/support_src_for_humble#build-the-container-for-zenohautoware) I was not able to rebuild the first container again and reproduce the issue, being stuck in this new error:

@MarioAlmelaUMH For the first question, can you check whether you run source env.sh or not?
I believe you are missing some variables.
https://github.com/evshary/autoware_carla_launch/blob/support_src_for_humble/env.sh#L13
Remember you still need to run source env.sh after building.
For the second question, I believe the package autoware_carla_launch is not built. Can you check whether it exists in install folder?

Thanks for your answer, @evshary . I tried again the first option (following this link: https://github.com/evshary/autoware_carla_launch/tree/support_src_for_humble#build-the-container-for-zenohautoware) and this time it worked. We are now exploring Autoware's source code in order to find how can we modify the sensor kit.
Since that last part belongs to this thread (https://github.com/evshary/autoware_carla_launch/issues/43), I think it's safe to finally close this one. I'll reopen it if more questions come afloat, but for now, I think it's ok.
Thank you so much.