Encoding Interpretation Groups

This PR is an (almost) complete implementation of Interpretations as defined in section section 3.5.1.[4,5,7]. It is currently missing the InterpretationMember section (<IP_ADDRESS>), but I'm working on it.
Adds InterpretationCollection
A mapping from identifier to Interpretation. Necessary to represent a spectrum with multiple interpretations.
Adds Interpretation
A mapping from identifier to Analyte, also containing an AttributeManager to hold CV attributes describing the whole interpretation. Will eventually host another subsidiary mapping from identifier to InterpretationMember. A very busy object.
Changes to Spectrum
Spectrum.interpretations will return an InterpretationCollection, letting the user access each Interpretation by its identifier. Spectrum.analytes remains, providing a proxy mapping projecting a mapping over all Analyte objects in all Interpretation objects in Spectrum.interpretations.
Changes to Backends
The Text and JSON backends now parse Interpretation sections and organize Analyte sections under the most recent Interpretation. If an Analyte section is encountered without an Interpretation, it will automatically be added to a new empty Interpretation.  The writing behavior now includes Interpretation sections accordingly.
Other Changes
I tried to apply type annotations to as much of the public interface as possible.

After polishing a bit of the work I had lingering unmerged, I compared my implementation to the exact text of section <IP_ADDRESS>, and it doesn't match what I remembered, and section <IP_ADDRESS> doesn't match the examples below in <IP_ADDRESS>. The text states that an Interpretation MUST have an analyte mixture members parameter, but the examples (which my implementation matches), instead using order of appearance:
<Interpretation=1>
MS:1002357|PSM-level probability=0.974
<Analyte=1>
MS:1000888|peptidoform=DSDDVPM[Ox]VLVGNKCDLAAR
<Analyte=2>
MS:1000888|peptidoform=VLVGNKCDLDSDDVPMVLR
<Interpretation=2>
MS:1002357|PSM-level probability=0.937
<Analyte=3>
MS:1000888|peptidoform=CDLDSDDSDDVPMVLSAR

The text would have required:
<Analyte=1>
MS:1000888|peptidoform=DSDDVPM[Ox]VLVGNKCDLAAR
<Analyte=2>
MS:1000888|peptidoform=VLVGNKCDLDSDDVPMVLR
<Analyte=3>
MS:1000888|peptidoform=CDLDSDDSDDVPMVLSAR
<Interpretation=1>
MS:XXXXXX|analyte mixture members=1,2
MS:1002357|PSM-level probability=0.974
<Interpretation=2>
MS:XXXXXX|analyte mixture members=3
MS:1002357|PSM-level probability=0.937

Does anyone remember which method we settled on?

After discussion last week, I believe we have settled on:
<Spectrum>
MS:1000744|selected ion m/z=880.8902
<Analyte=1>
MS:1000888|peptidoform=DSDDVPMVLVGNKCDLAAR
<Interpretation=1>
MS:1002357|PSM-level probability=0.974

and
<Spectrum>
MS:1000744|selected ion m/z=880.8902
<Analyte=1>
MS:1000888|peptidoform=DSDDVPM[Oxidation]VLVGNKCDLAAR
<Analyte=2>
MS:1000888|peptidoform=VLVGNKCDLDSDDVPMVLR
<Analyte=3>
MS:1000888|peptidoform=CDLDSDDSDDVPMVLSAR
<Interpretation=1>
MS:XXXXXXX|analyte mixture members=1,2
MS:1002357|PSM-level probability=0.974
<Interpretation=2>
MS:XXXXXXX|analyte mixture members=3
MS:1002357|PSM-level probability=0.937

and
<Spectrum>
MS:1000744|selected ion m/z=880.8902
<Analyte=1>
MS:1000888|peptidoform=DSDDVPM[Oxidation]VLVGNKCDLAAR
<Analyte=2>
MS:1000888|peptidoform=VLVGNKCDLDSDDVPMVLR
<Analyte=3>
MS:1000888|peptidoform=CDLDSDDSDDVPMVLSAR
<Interpretation=1>
MS:XXXXXXX|analyte mixture members=1,2
MS:1002357|PSM-level probability=0.974
<InterpretationMember=1>
MS:XXXXXXX|explained intensity fraction=0.287
<InterpretationMember=2>
MS:XXXXXXX|explained intensity fraction=0.423
<Interpretation=2>
MS:XXXXXXX|analyte mixture members=3
MS:1002357|PSM-level probability=0.937
<InterpretationMember=3>
MS:XXXXXXX|explained intensity fraction=0.512

Please let me know if there are any errors here.

I think I've updated things to work with the new hierarchy. Here's a JSON version of the most complex case:
    {
      "analytes": {
        "1": {
          "attributes": [
            {
              "accession": "MS:1000888",
              "name": "peptidoform",
              "value": "DSDDVPM[Oxidation]VLVGNKCDLAAR"
            }
          ],
          "id": "1"
        },
        "2": {
          "attributes": [
            {
              "accession": "MS:1000888",
              "name": "peptidoform",
              "value": "VLVGNKCDLDSDDVPMVLR"
            }
          ],
          "id": "2"
        },
        "3": {
          "attributes": [
            {
              "accession": "MS:1000888",
              "name": "peptidoform",
              "value": "CDLDSDDSDDVPMVLSAR"
            }
          ],
          "id": "3"
        }
      },
      "annotations": [],
      "attributes": [
        {
          "accession": "MS:1003061",
          "name": "spectrum name",
          "value": "Test"
        },
        {
          "accession": "MS:1000744",
          "name": "selected ion m/z",
          "value": 880.8902
        }
      ],
      "intensities": [],
      "interpretations": {
        "1": {
          "attributes": [
            {
              "accession": "MS:1002357",
              "name": "PSM-level probability",
              "value": 0.974
            },
            {
              "accession": "MS:XXXXXXX",
              "name": "analyte mixture members",
              "value": "1,2"
            }
          ],
          "id": "1",
          "members": {
            "1": {
              "attributes": [
                {
                  "accession": "MS:XXXXXXX",
                  "name": "explained intensity fraction",
                  "value": 0.287
                }
              ],
              "id": "1"
            },
            "2": {
              "attributes": [
                {
                  "accession": "MS:XXXXXXX",
                  "name": "explained intensity fraction",
                  "value": 0.423
                }
              ],
              "id": "2"
            }
          }
        },
        "2": {
          "attributes": [
            {
              "accession": "MS:1002357",
              "name": "PSM-level probability",
              "value": 0.937
            },
            {
              "accession": "MS:XXXXXXX",
              "name": "analyte mixture members",
              "value": "3"
            }
          ],
          "id": "2",
          "members": {
            "3": {
              "attributes": [
                {
                  "accession": "MS:XXXXXXX",
                  "name": "explained intensity fraction",
                  "value": 0.512
                }
              ],
              "id": "3"
            }
          }
        }
      },
      "mzs": []
    }

The JSON version is very heavy on blank space, making it hard to parse by eye, but the model looks right.

This still does not enforce controlled vocabulary parameters, but the structure for the interpretations is now consistent with the specification.

I implemented the CV term look up and type coercion we had previously discussed as a blocking issue to remove the special treatment for the analyte mixture members term.
I did this by updating psims, which holds my CV parsing code, along with all the machinery for fetching and caching versions of the various CVs. I tried initially to add the same behavior to the included Ontology and OntologyTerm types in mzlib itself, but without a term graph, I would only be adding to the long list of special cases in OntologyTerm.parse. I thought the type was already trying to do too much to accommodate PSI-MS and UNIMOD simultaneously.


Configure security scans

Description
Changes proposed in this pull request:

configure trivy security scans

Related issue(s)

Sample logs

This is basically default trivy config, with added --no-progress and --exit-code 1

/test void404_test_of_prowjob_pre-main-compass-manager-trivy


Support wildcards in forceBuildModules

Would come in handy if one could say:
-Dgib.forceBuildModules=*-modA,*-modB
instead of:
-Dgib.forceBuildModules=foo-bar-modA,foo-bar-modB
A regular expression would be even more flexible but this doesn't seem to get along with the comma separated nature of this property...

This property now supports regular expressions (multiple patterns/strings separated by comma).


Update flyway-core to 7.12.1

Updates org.flywaydb:flyway-core from 7.3.2 to 7.12.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: library-update, semver-minor

Superseded by #531.


What Cordova version does this plugin supports?

I couldn't get this plugin to work with Cordova 3.5.0. I think plugin's hooks are not available in this version. There seems to lack some new CordovaResourceApi classes too.

Sorry. This plugin not be compatible with older cordova versions.

I investigated a little further and I think it should work from version 4+ of Cordova. I didn't test though.
Just to inform if someone else needs that.


Discord configuration

Initial feedback on Discord configuration:

Guild is super confusing. Although it's the terminology used internally, they're only ever called Servers.
I'm getting 401 unauthorized after the connection is successfully established. It's unclear why. My initial reactions are: Am I supposed to use the id for Guild, or its name? What about the channel input/output, id or name? Running with --debug didn't output anything extra for discord, other than &errors.errorString{s:"HTTP 401 Unauthorized, {\"code\": 0, \"message\": \"401: Unauthorized\"}"}  module=discord, so there's probably a message being sent without it being passed to the debug printer.

One more issue: prefixing the channel name with # only works for gateway.in, but not for gateway.out. I have no idea why. But if by mistake you have in configured to, say #example and out configured to example, you get double messages in the channel.

Thanks for testing and reporting. Renamed Guild to Server. (I found the whole thing also confusing, the API uses Guild everywhere)
Updated sample conf to mention the Bot prefix for the token and to mention the channel naming conventions. No # for discord.

(using the latest go get) this issue seems to have reappeared, and I do have "Bot" in front of my token
tried both channelname and ID:####

Good point


hireable.me now has SSL Certificate

Please don't merge yet, i'm still configuring this on my end.

@hiendv i need your help to generate the CSR code on your server.
https://www.namecheap.com/support/knowledgebase/article.aspx/467/67/how-do-i-generate-a-csr-code
Please send it to my email. Thanks.

Email sent! Further technical discussions will continue using email.

Closed because I made a ton of changes to the codebase. Sorry for the inconvenience. Could you please sync the remote and fire another PR. Thank you.

@nguyenph88 You're helping me so much actually :+1:


JMS message beans doesn't contain elastic apm logging

We upgraded our Spring Boot and Openliberty services to Java 17 and Spring Boot 3. What we've noticed is that the message beans for openliberty and spring boot (JMS) are not instrumenting the elasticsearch properties into the the logging. The rest-api's are logging correctly the elastic properties. We've also tried to print the trace id in our application by ourself with "ElasticApm.currentTransaction().getTraceId()". This is giving us an empty value.
So are we missing something in the configuration, because of the upgrade? We need the transaction and trace id in the logging.
The version we use is 1.39.0.
Our properties:
elastic.apm:   environment: dev   service-name: apm-test-logging   server-url: https://test:8200   verify-server-cert: false   enable-log-correlation: true   log-format-sout: json   application-packages: nl.test   central_config: false

Can you try with version 1.35.0 to rule out or in some optimization that were added to the agent around messaging

I can't immediately see what's missing, it would be helpful if you have a minimal example I could run that shows the issue. Meanwhile I'll try to reproduce

(obviously I need to extend to using messaging, but that's where you could help with a simple example)

@jackshirazi Thanks, I appreciate your effort. As I said in my question, the controllers (rest api's) are instrumenting correctly the elastic properties in our Spring Boot and Open Liberty apps. The problem only occurs in the messaging beans for both.

Maybe this is not related to spring at all but rather to jakarta.* vs jmx.* JMS namespaces?
Looking at this issue, it seems like we don't support JMS in the jakarta.* namespace yet.

I think the supported tech entry may be incorrect, we did a push on the jakarta namespaces but I think we've not finished the JMS part, and it seems yours is the first bug report identifying that. I'll look at whether we can get you a snapshot to test

@jackshirazi perfect thanks, any idea when jakarta.jms namespace will be supported?

The next version in a couple of weeks if this is what is causing your issue. Please try the snapshot build (the agent snapshot jar is in the elastic-apm-agent zip file, or the -java8 one if you are using that)

@jackshirazi thanks for the snapshot. I tried to include it in my project, but it seems like that the attach package is missing. I can't import co.elastic.apm.attach.ElasticApmAttacher. I've looked inside the jar and i've noticed that the attach package is missing.
This is how I added the snapshot build to my project.

co.elastic.apm
apm-agent-attach
1.39.1
system
${project.basedir}/src/main/resources/elastic-apm-agent-1.39.1-SNAPSHOT.jar

For testing could you use the javaagent option on the command line? Only the elastic-apm-agent-1.39.0.jar jar needs replacing with elastic-apm-agent-1.39.1-SNAPSHOT.jar in that case

Hi @marinkton , for clarification you are using the apm-agent-attach artifact in your application, and the link @jackshirazi provided was for the elastic-apm-agent artifact, the latter must be used with the -javaagent option.
So here you should either:

download the large "build" archive from our CI and extract the apm-agent-attach-1.39.1-SNAPSHOT.jar from it and replace the <systemPath> value with this file path.
use the -javaagent setup option with the elastic-apm-agent-1.39.1-SNAPSHOT.jar downloaded previously

@SylvainJuge @jackshirazi unfortunately the snapshot does not work. I've used the --javaagent setup.
The startup logs :
The logs are showing that I'm using your snapshot version correctly:
{"@timestamp":"2023-06-26T10:25:01.209Z","log.level": "WARN","message":"This is a pre-release snapshot version, usage in production is not recommended unless instructed otherwise.", "ecs.version": "1.2.0","event.dataset":"apm-logging.apm-agent","process.thread.name":"main","log.logger":"co.elastic.apm.agent.configuration.StartupInfo"} {"@timestamp":"2023-06-26T10:25:01.209Z","log.level": "INFO","message":"Starting Elastic APM 1.39.1-SNAPSHOT.6d79d01 as apm-logging on Java 17.0.7 Runtime version: 17.0.7+7 VM version: openj9-0.38.0 (IBM Corporation) Linux 4.18.0-372.32.1.el8_6.x86_64", "ecs.version": "1.2.0","event.dataset":"apm-logging.apm-agent","process.thread.name":"main","log.logger":"co.elastic.apm.agent.configuration.StartupInfo"}
But the elastic props are still empty in the messaging beans (I've used a open liberty service to test this).
{"message":"Bericht is succesvol geplaatst op logging-acties","ibm_datetime":"2023-06-26T12:26:44.276+0200","log.logger":"nl.justid.dad.utilities.jms.DADActiveMQDestination","log.level":"INFO","log.origin.function":"enqueue","ibm_className":"nl.test.jms.DADActiveMQDestination","transaction.id":"","trace.id":"","@timestamp":"2023-06-26T10:26:44.277546591Z","ext_appName":"logging-service","span.id":"","process.thread.name":"Thread-1 (ActiveMQ-client-global-threads)"}

In this case if you could provide a very simple app that helps to reproduce the problem that would really be helpful.
From what I understand:

the transactions are properly created on the HTTP endpoint.
you have some "messaging beans" that should be triggered when they handle a message from JMS.

What we need to know:

does your application sends messages to JMS from the HTTP request handling or does the application also handles incoming messages through JMS ?
how are those JSON logs created? are you using ecs-logging-java or the agent built-in reformatting feature ? The weird thing here is that we have empty valies for transaction.id and trace.id and I'm pretty sure the java agent does not set such empty values.

@SylvainJuge the application handles incoming messages through JMS. We have multiple services in Open liberty and Spring Boot. Everything was working fine before the Java 17 and Jakarta namespace upgrade.
For spring boot we're using the dependency:
		<dependency> 			<groupId>co.elastic.logging</groupId> 			<artifactId>log4j2-ecs-layout</artifactId> 			<version>${co.elastic.logging.log4j2-ecs-layout-version}</version> 		</dependency>
and for open liberty we have a custom method for setting up the logging:
`
protected void setupLogging() {
    LogRecordContext.unregisterExtension(TIMESTAMP);
    LogRecordContext.unregisterExtension(TRACE_ID);
    LogRecordContext.unregisterExtension(TRANSACTION_ID);
    LogRecordContext.unregisterExtension(SPAN_ID);

    LogRecordContext.registerExtension(TIMESTAMP, () -> ZonedDateTime.now(ZoneOffset.UTC).format(DateTimeFormatter.ISO_INSTANT));
    LogRecordContext.registerExtension(TRACE_ID, () -> ElasticApm.currentTransaction().getTraceId());
    LogRecordContext.registerExtension(TRANSACTION_ID, () -> ElasticApm.currentTransaction().getId());
    LogRecordContext.registerExtension(SPAN_ID, () -> ElasticApm.currentSpan().getId());

    initialized = true;
}

`
The transactions are properly created on the HTTP endpoint indeed, but the messagings beans are not created properly.
This problem occurs in both frameworks (Spring and Open Liberty).
I'll try to provide an example today or tomorrow.

Thanks ! That explains the empty transaction_id fields in the JSON logs.
We don't provide a dedicated instrumentation for OpenLiberty, but the setupLogging does an equivalent job here when the logs as written in JSON.

Hi there, same problem here.
I would like to contribute with my experience on the issue 👇
Tested;

ecs-console-appender in logback.spring.xml*
ELASTIC_APM_LOG_ECS_REFORMATTING enabled instead of logback.spring.xml*
apm-agent version 1.36, 1.38 and 1.39
Receiving a message from ibm MQ server with the DefaultJmsListenerContainerFactory

Results:

No correlation id’s are injected jms listener related logback logging
Correlation id’s are injected for normal api requests

*Please find attached the example project I used for testing. Also have a look at the example folder for the used configurations in the attached jms-logcorrelation-example-project.zip

Hi @LeaTaka and @marinkton , we have fixed a few issues in the PR that adds support for Jakarta namespace.
Could you try with this snapshot of the Java agent and see if that now works as expected ?
Thanks to the sample application provided by @LeaTaka I've managed to reproduce the issues locally which really helped a lot.
There are still few test failures to investigate in the PR, but that's only due to unit-testing.

First results testing with your snapshot;

using @JmsListener ✅
requested a normal rest api ✅
checking log-correlation in Kibana ✅

App-3 logging >>
`{"@timestamp":"2023-06-29T09:43:02.004Z","log.level": "INFO","message":"Received message is: \n  JMSMessage class: jms_text\n  JMSType:          null\n  JMSDeliveryMode:  2\n  JMSDeliveryDelay: 0\n  JMSDeliveryTime:  0\n  JMSExpiration:    0\n  JMSPriority:      4\n  JMSMessageID:     ID:414d51204d514d534f30352020202020645e84ef21a79402\n  JMSTimestamp:<PHONE_NUMBER>981\n  JMSCorrelationID: null\n  JMSDestination:   queue:///DEV.SDS.02.LQ02\n  JMSReplyTo:       null\n  JMSRedelivered:   false\n    JMSXAppID: /app/apm-java.jar           \n    JMSXDeliveryCount: 1\n    JMSXUserID: mqsrtp01    \n    JMS_IBM_Character_Set: UTF-8\n    JMS_IBM_Encoding: 273\n    JMS_IBM_Format: MQSTR   \n    JMS_IBM_MsgType: 8\n    JMS_IBM_PutApplType: 28\n    JMS_IBM_PutDate: 20230629\n    JMS_IBM_PutTime: 09430199\n    elastic_apm_traceparent: 00-1b751e269027419c5d29d1f34a4bb110-94ad8ee90009fc92-01\n    traceparent: 00-1b751e269027419c5d29d1f34a4bb110-94ad8ee90009fc92-01\n    tracestate: es=s:1\nListener - Message from App2: f673bbe2-67dd-4d54-a516-c059c91ee8a6","ecs.version": "1.2.0","service.name":"app-3-java","service.version":"0.0.1-SNAPSHOT","service.environment":"npo","event.dataset":"app-3-java.CONSOLE","process.thread.name":"org.springframework.jms.JmsListenerEndpointContainer#0-1","log.logger":"nl.xxx.healthcheck.poc.api.MyController","transaction.id":"414e81172c54699e","trace.id":"1b751e269027419c5d29d1f34a4bb110"}
{"@timestamp":"2023-06-29T09:44:02.949Z","log.level": "INFO","message":"Getting info from app4","ecs.version": "1.2.0","service.name":"app-3-java","service.version":"0.0.1-SNAPSHOT","service.environment":"npo","event.dataset":"app-3-java.CONSOLE","process.thread.name":"http-nio-8080-exec-6","log.logger":"nl.xxx.healthcheck.poc.api.MyController","transaction.id":"ce69bdfbf3b9cdb2","trace.id":"52616fc9f61319d5d638ff0dde9cfe6c"}
{"@timestamp":"2023-06-29T09:44:03.007Z","log.level": "INFO","message":"Getting info from app5","ecs.version": "1.2.0","service.name":"app-3-java","service.version":"0.0.1-SNAPSHOT","service.environment":"npo","event.dataset":"app-3-java.CONSOLE","process.thread.name":"http-nio-8080-exec-6","log.logger":"nl.xxx.healthcheck.poc.api.MyController","transaction.id":"ce69bdfbf3b9cdb2","trace.id":"52616fc9f61319d5d638ff0dde9cfe6c"}`
Kibana >>

Seems to be working, excellent work!
Please let me know when you plan to release the final fix.

Hi @LeaTaka you can subscribe to the notifications to know when #3198 is merged and when a new release is available.

@SylvainJuge Heads-up: I could be wrong but it seems that elastic-apm-agent-1.39.1-SNAPSHOT.jar impacts ELASTIC_APM_LOG_SENDING.

@LeaTaka I've tested the log sending locally and its working as expected on my side, could you try it with the latest release 1.39.0 and see if you have something in the "Observability > Logs > Log Stream" view in Kibana ? (here you might miss the trace correlation, but it should still be part of the global log stream, or even the per-service stream).
If you still experience any issue here I would suggest we discuss this further in the forum or by creating another bug report as it seems to be a separate issue from the JMS support this issue is about.

Cool @SylvainJuge. When I come across smt related, I will file a separate bug report.
For now I do not have much time left to do further testing, so I leave it there. I might have seen it wrong.
Anyways good that you have it covered! Cheers 👌

@jackshirazi@SylvainJuge,
Could you please reopen this bug issue? I wasn't available for the past two weeks, but now I'm back. We've tested the new snapshot version and it works well with Spring Boot, but unfortunately, we're encountering issues with open liberty. You can download the zip file this link .
By the way, you can ignore the dockerfile in the project.
To build the project, simply run mvn clean install, and to run it, use mvn liberty:dev. If needed, you can modify the property values in liberty/config/server.env.
Thanks in advance!

Please try with the just released 1.40.0. If it works with Spring but not open liberty it's a different bug - so in that case please open a separate issue


Sockets paradigm

Hey guys,
first of all great work with the sane stack.
My problem is to understand how the sockets works. My question is how i can get a custom function in a custom class work. I want, if sockets fireing e.g. on user model, to trigger a custom function in sails. I tried it with init function but it seems not to work. So how can i do it? Its very helpfull if i need to trigger algorithms on observer or send emails if user register.
Will be great if someone can give a tutorial for the logic behind sockets worker. I think im not the only one :)

first google hit :), http://stackoverflow.com/questions/27189483/where-did-the-sailsjs-websockets-documentation-go

Thanks @Master244, as that SO post show's, it looks like the sails sockets documentation has moved and google hasn't necessarily caught up but it's here: http://sailsjs.org/documentation/reference/web-sockets
Also, @xyrox2, I dont know if this is still something you're looking at since you're issue was opened so long ago but you can checkout a quick and dirty example I put together a while back (jamemackson/example-sane-realtime) and specifically here where the sockets get wired up on the client side.
Keep in mind that this is a super quick proof of concept example, I wouldn't necessarily architect it the way it is shown here but it should give you some ideas.


support preserving state of children component when updating parent component

Describe the issue
When updating the code of parent component, the local state of children component is lost(with preserveLocalState: true). While the local state of parent component can be kept.
In below screenshot, the local state of Counter will reset to default when App is change. Because in svelte-hmr,  when parent component is changed,  it will recreate itself(can keep local state) and it's children components(without keeping local state).

Expected behavior
The local state of children is kept as well when updating parent component, just like react does. It's annoying when debugging between parent component and children components if the local state is lost.
And developer may think it's a bug of HMR because of the inconsistence.

Hey! Some progress update...
I have studied how feasible this could be, and came up with some (dirty/incomplete) POC here: https://github.com/rixo/svelte-hmr/blob/poc-preserve-children/PRESERVE_CHILDREN_STATE.md#demo.
However, this is probably not something that can be done sanely by externally patching Svelte's compiler output like this package currently does. So HMR will have to be integrated into the compiler first. I have started looking into it, but that's probably still quite a long shot...


Hard code a shortlist of trusted signers so "Skip" still does some verification

"Skip" verifying your download, should still randomly select from a short list of people I trust until it has 2 good signatures, and just do this in the background. Fail if it can't get 2 Good signatures.

This is the default behavior in #161.


Fix 151

Fixes #151.

@apoelstra Do you prefer this PR squashed?

Also, can you confirm that if somebody tries to make a witness of size 2^32 + 1, that the program is rejected without the assertion triggering? I believe the original bug occured in decodeWitnessData which doesn't understand types or anything, it just reads the total witness length and tries to cram it all into a bitstring.

Finally, I am getting build failures like
       > test.c:432:13: error: function declaration isn't a prototype [-Werror=strict-prototypes]
       >   432 | static void regression_tests() {
       >       |             ^~~~~~~~~~~~~~~~
       > cc1: all warnings being treated as errors

I suspect because I have a newer gcc than you. I think you have to stick a void into the argument list for the function.

Oops.  I was testing with clang.

Completed all suggestions.


Coder: Navigation dropdown should remember its extent

The navigation dropdown remembers its last extent, using GtPhlowDropdownAction>>#preferredExtentFrom:.


Is that possible to use 3 inputs to your model instead of 2 ?

Hi, I am wondering to use 3 inputs like as if now you are using 2 inputs like Sparse depth map and corresponding RGB, Is that possible to use one more input like Coarse dense depth map got from hand crafted methods with corresponding to sparse depth map ? please let me know if its possible, Thanks in advance .

HI! Of course you could make an attempt. In our two-branch (actually hourglass-styled) backbone, the second (DD) branch could be regarded as a reprocessing procedure of the first (CD) branch prediction, which is actually a coarse predicted depth. Therefore, you could either feed the hand-crafted one into the second branch or even add a new third branch. And the third branch would function similarly as the second branch.

Thank you so much, I will give a try as you suggested.

Hi, @JUGGHM , sorry to ask you this question again, I want to back project the predicted depth map to point cloud coordinates, is that possible ? if so, can you give me code for back projection like input will be predicted depth map and output will be point cloud which will be denser in front view. Thank you.


Re-update for #1460

Title

@KevvyCodes Pushed my changes.

@B0RYS This good enough or no?

Yup @KevvyCodes seems fine. Thank you.


File classname psr-4 standard

Deprecation Notice: Class Gkermer\TextAutoComplete\TextAutoComplete located in .../vendor/gkermer/nova-text-auto-complete/src\NovaTextAutoComplete.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar
Solution rename filename /src/NovaTextAutoComplete to /src/TextAutoComplete

Sorry, I see it's already fixed in new release. Thnx!

Thank you!


<IP_ADDRESS> - getsockopt: no route to host

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report

Environment:

Cloud provider or hardware configuration: OpenStack

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 4.4.0-92-generic x86_64
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Version of Ansible (ansible --version):
2.6.1

Kubespray version (commit) (git rev-parse --short HEAD): Tag v2.5.0
Network plugin used: calico
Copy of your inventory file:
https://gist.github.com/juicemia/805134dffe18a0eb074606bbb6abd780
Command used to invoke ansible:
ansible-playbook kubespray/cluster.yml     --become     -u ubuntu     -v     --flush-cache     -i ansible/inventory/$USER-local/inventory.ini
Output of ansible run:

https://gist.github.com/juicemia/ca8db83277a999e3671b3e183824a632
Anything else do we need to know:

Master variables: https://gist.github.com/juicemia/bd283a63ad24ffae41e4944b2e62e43f
Node variables: https://gist.github.com/juicemia/0ebf5dc778c70733d723aafe7aa3dee2

The end result of this is that kube-dns, kubernetes-dashboard and tiller all go into CrashLoopBackoff state. In the (kube-dns logs)[https://gist.github.com/juicemia/8c334d2fe015190bc32fb99a45b0caec], I see it time out because it can't connect to <IP_ADDRESS>.
If I change my group_vars to specify flannel as the network plugin, everything works fine. Also, after searching around on the internet, I found a github issue (I lost the link) where someone suggested flushing iptables and restarting the KubeDNS pod. Doing so worked.
This leads me to believe that it's something specifically to do with calico.
I thought it might be that I needed to set calico_endpoint_to_host_action: "ACCEPT" so I did. It didn't work. During this I noticed that the template canal uses to deploy Calico doesn't even support setting this, so I made the change to allow it and still nothing.

try : kube_proxy_mode: ipvs
Hugo<EMAIL_ADDRESS>于2018年7月27日周五 上午10:36写道：

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report
Environment:

Cloud provider or hardware configuration: OpenStack
OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
Linux 4.4.0-92-generic x86_64
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Version of Ansible (ansible --version):
2.6.1

Kubespray version (commit) (git rev-parse --short HEAD): Tag v2.5.0
Network plugin used: calico
Copy of your inventory file:
https://gist.github.com/juicemia/805134dffe18a0eb074606bbb6abd780
Command used to invoke ansible:
ansible-playbook kubespray/cluster.yml --become -u ubuntu -v --flush-cache
-i ansible/inventory/$USER-local/inventory.ini
Output of ansible run:
https://gist.github.com/juicemia/ca8db83277a999e3671b3e183824a632
Anything else do we need to know:

Master variables:
https://gist.github.com/juicemia/bd283a63ad24ffae41e4944b2e62e43f
Node variables:
https://gist.github.com/juicemia/0ebf5dc778c70733d723aafe7aa3dee2

The end result of this is that kube-dns, kubernetes-dashboard and tiller
all go into CrashLoopBackoff state. In the (kube-dns logs)[
https://gist.github.com/juicemia/8c334d2fe015190bc32fb99a45b0caec], I see
it time out because it can't connect to <IP_ADDRESS>.
If I change my group_vars to specify flannel as the network plugin,
everything works fine. Also, after searching around on the internet, I
found a github issue (I lost the link) where someone suggested flushing
iptables and restarting the KubeDNS pod. Doing so worked.
This leads me to believe that it's something specifically to do with
calico.
I thought it might be that I needed to set calico_endpoint_to_host_action:
"ACCEPT" so I did. It didn't work. During this I noticed that the
template canal uses to deploy Calico doesn't even support setting this, so
I made the change to allow it and still nothing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kubespray/issues/3029, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APRMhEYxvm0ElgBcZoECu_oNVh75zxQ1ks5uKnyagaJpZM4Vi0o9
.

@chenyg0911 that didn't do the trick unfortunately 😞
                "kube_proxy_mode": "ipvs",
                "kube_proxy_mode": "ipvs",
        "kube_proxy_mode": "ipvs", ```

Still getting the same behavior.

I found the source of the issue.
Apparently if you just specify the hosts using the hostname, without setting the ip host variable, it'll break.


Adding loader on b-banner prodBox

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--www-landing-pages--bitdefender.hlx.page/drafts/test-page/
After: https://new_fixes--www-landing-pages--bitdefender.hlx.page/drafts/test-page/

duplicated


⚠ Bofrost.at has degraded performance

In 04bb9d1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1331 ms

Resolved: Bofrost.at performance has improved in 295067f after 11 minutes.


[setup] Adding requirements.txt

I realize that Superset is an application rather than a library but when defining Python packages setup.py should only contain abstract dependencies as described in detail here. Decoupling the actual requirements from setup.py means individual deployments have the freedom to use other versions, whereas from a development standpoint you want to have builds which are predictable and deterministic.
This PR performs the following changes:

Removes the pinned versions from setup.py
Adds a requirements.txt which explicitly pins every abstract dependency now defined in setup.py which is used by tox for CI.
Alphabetizes dependencies.
Lowercases the dependencies for consistency.

to: @mistercrunch @xrmx

Closing this in favor of incorporating this logic into a broader PR.


Kubernetes CoreOS failed to start kubelet

Is this a request for help?:
YES
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
What version of acs-engine?:
0.11.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.8.4
What happened:
Unable to connect to the kubernetes cluster with CoreOS as a distro after deployment. Kubelet can't be started because of the file system permission issue:
Dec 20 14:32:24 k8s-master-XXXXXX-0 docker[2794]: /run/torcx/bin/docker: Error response from daemon: error while creating mount source path '/usr/libexec/kubernetes/kubelet-plugins': mkdir /usr/libexec/kubernetes: read-only file system.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
{   "apiVersion": "vlabs",   "properties": {     "orchestratorProfile": {       "orchestratorType": "Kubernetes",       "orchestratorVersion": "1.8.4",       "kubernetesConfig": {         "networkPolicy": "azure",         "enableRbac": true       }     },     "masterProfile": {       "count": 1,       "dnsPrefix": "yourdnsprefix",       "vmSize": "Standard_D2_v2",       "storageProfile" : "ManagedDisks",       "distro": "coreos"     },     "agentPoolProfiles": [       {         "name": "agentpool1",         "count": 3,         "vmSize": "Standard_DS2_v2",         "availabilityProfile": "AvailabilitySet",         "storageProfile" : "ManagedDisks",         "distro": "coreos"       }     ],     "linuxProfile": {       "adminUsername": "admin",       "ssh": {         "publicKeys": [           {             "keyData": ""           }         ]       }     },     "servicePrincipalProfile": {       "clientId": "",       "secret": ""     }   } }
Anything else we need to know:
Tried several times

I've removed the plugins volume line from the kubelet.service and it works.

Dec 20 15:45:19 k8s-agentpool1-39482401-3 docker[1124]: docker daemonis not supported on Linux. Please rundockerd` directly
Dec 20 15:45:19 k8s-agentpool1-39482401-3 systemd[1]: docker.service: Main process exited, code=exited, status=1/FAILURE
Dec 20 15:45:19 k8s-agentpool1-39482401-3 systemd[1]: Failed to start Docker Application Container Engine.
-- Subject: Unit docker.service has failed
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- Unit docker.service has failed.
-- The result is failed.
Dec 20 15:45:19 k8s-agentpool1-39482401-3 systemd[1]: docker.service: Unit entered failed state.
Dec 20 15:45:19 k8s-agentpool1-39482401-3 systemd[1]: docker.service: Failed with result 'exit-code'.
Dec 20 15:45:20 k8s-agentpool1-39482401-3 systemd[1]: docker.service: Service hold-off time over, scheduling restart.
Dec 20 15:45:20 k8s-agentpool1-39482401-3 systemd[1]: Stopped Docker Application Container Engine.`
On agent node docker deamon doesn't start(((

@jackfrancis does our acs-engine support coreos too? I have checked, In CoreOS the /usr partition is read-only by design

@andyzhangx It was supported before #1909 :)
There's some examples: https://github.com/Azure/acs-engine/tree/master/examples/coreos
Can we change the folder from:
--volume=/usr/libexec/kubernetes/kubelet-plugins:/usr/libexec/kubernetes/kubelet-plugins

to
--volume=/etc/kubernetes/plugins:/etc/kubernetes/plugins

and pass it to kubelet as parameter:
--volume-plugin-dir=/etc/kubernetes/plugins

instead of using the default?

@mwieczorek Thanks for the suggestion. Sounds like there is a trade-off if we also want to support coreos, we need to use /etc/kubernetes/plugins instead of standard plugin dir /usr/libexec/kubernetes/kubelet-plugins for all linux distros, because we use only one
https://github.com/Azure/acs-engine/blob/master/parts/k8s/artifacts/kuberneteskubelet.service for all linux distros.
@jackfrancis @JiangtianLi  what's your opinion?


Yay Subnautica!

Game name
Subnautica
Request type
Adding a new game to the feed
Target frameworks, package dependencies

net472

No dependencies

netstandard20

No dependencies

Allowed assembly names

Assembly-CSharp
Assembly-CSharp-firstpass

Contact details
<EMAIL_ADDRESS>Additional information
https://www.youtube.com/watch?v=HIcSWuKMwOw
Package ownership agreement

[X] I acknowledge and agree to the above rules

Granted upload key without changes


Missing Configuration in the "Configure WSO2 IS as a Key Manager" documentation

Description:
I was following this documentation[1] to configure WSO2 IS as KM with WSO2 API Manager 3.2.0. But when trying to change the ownership of an application I encounter the following issue.
[2020-10-22 17:31:53,249] ERROR - AbstractKeyManager Error occurred while updating OAuth Client :
org.wso2.carbon.apimgt.impl.kmclient.KeyManagerClientException: Received status code: 401 Reason:

I was able to overcome this issue by adding the below configuration to the deployment.toml file of the WSO2 IS.
[[resource.access_control]]
context = "(.*)/keymanager-operations/dcr/register(.*)"
secure = true
http_method = "POST"
permissions = "/permission/admin/manage/identity/applicationmgt/update"
scopes = "internal_application_mgt_update"

[1] https://apim.docs.wso2.com/en/latest/administer/key-managers/configure-wso2is-connector/
Suggested Labels:

Suggested Assignees:

Affected Product Version:
APIM 3.2.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Hi Team
The same configurations need to be added in the following Doc space as well [1] (Step 04 -> Point 4).
[[resource.access_control]]
context = "(.*)/keymanager-operations/dcr/register(.*)"
secure = true
http_method = "PUT"
permissions = "/permission/admin/manage/identity/applicationmgt/update"
scopes = "internal_application_mgt_update"

[[resource.access_control]]
context = "(.)/keymanager-operations/dcr/register(.)"
secure = true
http_method = "POST"
permissions = "/permission/admin/manage/identity/applicationmgt/update"
scopes = "internal_application_mgt_update"

[1] https://apim.docs.wso2.com/en/latest/install-and-setup/setup/distributed-deployment/configuring-wso2-identity-server-as-a-key-manager/


Upgrade storybook to latest version

This also switches to the new package-lock format

Browser test failing:
sauceFirefox: |

Weird, after removing the nested node_modules/ dirs it worked. I guess npm ci isn’t fully clean under Lerna…?

Weird, after removing the nested node_modules/ dirs it worked. I guess npm ci isn’t fully clean under Lerna…?

Yeah, lerna is strange and often leads to diffs in the package-lock.json the reasons to which are not always clear to me. But I often try run things only via lerna as that is the closest to what CI does.


luacheck: add initial config and fix examples

luacheck warns about unused variables and too long lines.
Fixed them to make code more readable.
luacheck --config .luacheckrc .

Frankly, those "examples" are somewhat off. It's just a hastily trimmed down version of what I've been running myself in the past to give anyone at least a glimpse at how to use all this (and admittedly, it's not easy to grasp the architecture from this, but at least, it's a pointer...).
That said, I do not see much reason to make this stuff luacheck'able. (And I don't agree with some things luacheck is complaining about, namely the too long lines.) On the other hand, a checker/linter is nice to have when coding, so I'll go into more detail in the PR...

Frankly, those "examples" are somewhat off. It's just a hastily trimmed down version of what I've been running myself in the past to give anyone at least a glimpse at how to use all this (and admittedly, it's not easy to grasp the architecture from this, but at least, it's a pointer...).

You are right, it is not important source code in the project. I wanted to understand your vision regarding luacheck at all, regarding fixing different types of warning (now I see that you want to ignore W213 warnings and so on). Next step is to fix warnings in lib/ and interfaces/. Of course if you are agree to review changes.

I'll happily review! My feelings toward luacheck are mixed, but it can certainly be helpful to find mistakes. On the other hand, it can get a bit pesky about some stuff that really isn't an issue ;-) But in the face of finding mistakes vs being a bit pesky, I'll take the former :-)

On the other hand, it can get a bit pesky about some stuff that really isn't an issue.

Let me know in such cases. We can keep code as is and ignore warning inline for a single case or globally in luacheckrc.
Or even make fix in other way than I suggest.
P.S. Some time ago we integrated luacheck to Tarantool development process and found about 4 real bugs and 1 bug in a test code.
So, it seems it make sense :)

AFAIR we discussed it in mail and decided to keep source code as is, without fixes of luacheck warnings. So I'll close a PR.


Enable manual release

The workflow_dispatch action doesn't generate a release presently.  It'd be handy if releases were generated when this was manually run on main.

Hmm.  Build seems to have not run at all.  That's unexpected.

The build didn't run because the commit only changes files in paths.ignore.  But the build action is required by the repo.  So I think what should happen here is that we need to alter the PR trigger to not ignore any paths, but rather check the files changed in the build step and short-circuit exit true if only .gihub/** files have changed.


rlv-tips - replaceArray with groupingFunction fails

Hi @shiv19, thanks for a great workshop!
I'm trying using the ObservableArray and replacing it the "right" way by your example from rlv-tips.
However if you add [groupingFunction] to the RadListView it fails when you replace the array on Android with the following error:
ERROR Error: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Object.toString()' on a null object reference
It seems that after you replace the array using the replaceArray(), the grouping function gets undefined items as arguments. Do you have any suggestion how to solve this, or am I doing something totally wrong?
To reproduce the issue you can change the original array, and corresponding push (rlv-tips.component.ts):
private _origArray = [
{
title: "Row 1",
section: "section 1"
},
{
title: "Row 2",
section: "section 2"
},
{
title: "Row 3",
section: "section 3"
}
];
newArray.push({
title: "Row 4",
section: "section 4"
});
Add following grouping function:
getSectionName(item) {
return item.section;
}
Add the grouping function to the RadListView (rlv-tips.component.html)
<RadListView #lv row="1" [items]="source" [groupingFunction]="getSectionName">

Hi @hafstad
Can you please recreate this issue on Nativescript playground so that I can take a look at it :)

@shiv19 Here you should be able to reproduce the issue:
https://play.nativescript.org/?template=play-ng&id=vebP6l&v=2

@hafstad
This appears to be a bug.
Thanks for reporting it. I'll leave this issue open until it is resolved.

From what I noticed, if you set the source array length to 0 before the for loop, it doesn't result in a crash, but the last item disappears and if you tap refresh list after this, then tap replace array again, you'll see the correct list.
https://play.nativescript.org/?template=play-ng&id=vebP6l&v=5
I'm just recording my observation. This is not a solution.

@hafstad Until this issue is resolved, the workaround would be to replace it with a new observable array
this.source = new ObservableArray([...(<any>this.source)._array]);

@hafstad
I have a workaround for you, while they fix it
https://play.nativescript.org/?template=play-ng&id=vebP6l&v=8
you need to put a try catch around the for loop, and no need to set the length of the observable array.
and then you need to call refresh on the list with a setTimeout.


Improve performance in api page

I fixed css and performance with Register Options feature in API page.

I added cursor: pointer;
I replaced from Prism.highlightAll to Prism.highlightAllUnder because it is too late when I clicked Register Options.

wow nice instant now! 🤟


Possibly add something that makes GH actions easier to set up?

There aren't re-usable workflows - the only thing you could do here would be a docker container.
Something I have for @Astrotomic is a node.js snippet that copies all metafiles to all repos.
https://github.com/Astrotomic/.github

@Gummibeer Thanks, so I guess here's what I meant:
./vendor/bin/duster init ghactions

Which would then stub in .github/workflows/lint.yml or something similar, which would run all the linters.
I think that's pretty doable.. I assume what you're suggesting is something similar, right?

Yes. If you have the stub in the package it's even easier as you don't have to go via GH API.
So it's a simple copy'n'paste.

@Gummibeer Thanks my friend!


Padding on Y Axis

Hi - first, what a wonderful app, I've been able to do almost everything I need with it. My question is about adding padding to the Y axis. Typically I can pad the domain in d3 to add space above and below the data that renders in the plot. I can't figure out how to do that with techan, I think I need to do it here: y.domain(techan.scale.plot.ohlc(data.slice(indicatorPreRoll)).domain());, but nothing I try works.
I'm getting around it right now by adding blank rectangles above and below the plot, and using borders to look like axes and making the real axes transparent, so it looks like there's padding. But it would be great if I could do this the right way.
Thanks for your help!

+1 for this.  The only way I've discovered how to make this happen is to add extra data to the domain, but this is not optimal solution.  It should work by specifying number of padding pixels for the axis.  In any case, if you want to try the domain trick, you could do something like this:
	var ydomain = techan.scale.plot.ohlc(data).domain();
	ydomain[0] -= padding;
	ydomain[1] += padding;
	y.domain(ydomain);

1 for this from me as well. Using @priikone's suggestion works, but it's definitely not ideal...

Just an update, here's a proper way of doing it:
y.domain(y.range().map(widen_y(chartHeight, top_padding, bottom_padding)).map(y.invert));
The height values would be percents of the chartHeight, like .1 for 10%.
And widen_y() is:
function widen_y(height, wide1, wide2) {
wide1 = height * wide1;
wide2 = height * wide2;
return function(d, i, array) {
    if (i == 0)
	return wide1 ? d - (i * 2 - 1) * 1 * wide1 : d;
    return wide2 ? d - (i * 2 - 1) * 1 * wide2 : d;
};
}

The helpers for scale techan.scale.plot.ohlc(data) are basic helpers which provide 'sensible' (what works for me) defaults. If more padding is required, for now you can either take techan's result and add more as @priikone suggested, or generate your own extents.
The question could be asked if you're plotting charts in pure d3, how would you add padding to a domain?


Improve file header on mobile

File headers can become quite width, so ensure the file size is not being wrapped into itself(width + padding-right) and allow the overflow to be scrolled(overflow-x).

Before

After

Codecov Report

Merging #19945 (4474f7f) into main (73382d2) will decrease coverage by 0.01%.
The diff coverage is 56.15%.

@@            Coverage Diff             @@
##             main   #19945      +/-   ##
==========================================
- Coverage   47.32%   47.30%   -0.02%
==========================================
  Files         959      966       +7
  Lines      133652   134117     +465
==========================================
+ Hits        63252    63447     +195
- Misses      62699    62949     +250
- Partials     7701     7721      +20

Impacted Files
Coverage Δ

cmd/admin.go
0.00% <0.00%> (ø)

cmd/serv.go
2.22% <0.00%> (-0.11%)
:arrow_down:

models/db/engine.go
32.65% <ø> (-0.91%)
:arrow_down:

models/repo/repo.go
64.66% <0.00%> (-0.49%)
:arrow_down:

models/repo/repo_unit.go
77.14% <ø> (ø)

models/webhook/webhook.go
68.81% <0.00%> (-1.26%)
:arrow_down:

modules/git/commit.go
56.92% <ø> (+0.38%)
:arrow_up:

modules/git/lfs.go
66.66% <ø> (+7.84%)
:arrow_up:

modules/git/repo_attribute.go
69.17% <ø> (+0.65%)
:arrow_up:

modules/markup/markdown/toc.go
0.00% <0.00%> (ø)

... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3898fc5...4474f7f. Read the comment docs.


Watch!. Manchester United vs Newcastle Live Free On Tv 30 DEC 2024

How to watch Manchester United vs Newcastle live: Stream link, TV channel, team news, prediction
Manchester United are reeling once again after losing 4 of their last 5 games in the Premier League, and new manager Ruben Amorim is already under pressure with red-hot Newcastle set to visit Old Trafford on Monday.
🔴📺 GO LIVE==►► CLICK HERE TO WATCH LIVE

🔴📺 STREAMING==►► CLICK HERE TO WATCH LIVE

🔴📺 GO LIVE==►► CLICK HERE TO WATCH LIVE

🔴📺 STREAMING==►► CLICK HERE TO WATCH LIVE

The Red Devils (14th - 22 points) have lost four games at home already this season (12-2 combined score), including their last two to Nottingham Forest and Bournemouth, two sides currently in the top-6. Amorim predicted earlier this month, after going unbeaten in his first three games, that “the storm will come” for his side as the fixtures pile up and the squad’s (considerable lack of) depth gets tested. Stormy indeed. Captain Bruno Fernandes is suspended after being sent off on Boxing Day, seven minutes before Manuel Ugarte picked up his fifth yellow card of the season and a one-game ban of his own. Back to Casemiro and Christian Eriksen in midfield?
Newcastle (5th - 29 points) would be surging in the top-4 race if Forest would simply drop a point or two, but instead the Magpies are flying under the radar for now. Two weeks ago, Eddie Howe’s side sat 12th with just 19 goals in 15 games, and some questions were being asked. Since then? Three straight wins, 11 goals scored, 0 conceded. Alexander Isak and Jacob Murphy have been unplayable to the tune of 8 goals, 3 assists between them in three games.
About the match
Manchester United is going head to head with Newcastle United starting on 30 Dec 2024 at 20:00 UTC at Old Trafford stadium, Manchester city, England. The match is a part of the Premier League.
Currently, Manchester United rank 14th, while Newcastle United hold 7th position. Looking to compare the best-rated player on both teams? Sofascore's rating system assigns each player a specific rating based on numerous data factors.
On Sofascore livescore you can find all previous Manchester United vs Newcastle United results sorted by their H2H matches. Sofascore also provides the best way to follow the live score of this game with various sports features. Therefore, you can:
Find out who scored in a live match
Get real-time information on which team is dominating the match using the Attack Momentum
Follow detailed statistics such as ball possession, shots, corner kicks, big chances created, cards, key passes, duels and more
Check all head to head matches – for instance, in the last season Manchester United and Newcastle United played 2 games against each other
Track all home and away games for each team in the Premier League
Check out how Sofascore community votes on which team is more likely to win this match.
All of these features can help you decide on Manchester United vs. Newcastle United game prediction. Even though Sofascore doesn't offer direct betting, it provides the best odds and shows you which sites offer live betting. Live U-TV odds are viewable on Sofascore's Football live score section.
Where to watch Manchester United vs. Newcastle United? Under TV Channels section you can find the list of all channels that broadcast Manchester United – Newcastle United live match. You can also live stream this match through our betting partners or click on any links on Sofascore for a legal live stream.
Event details:
NAME: Manchester United - Newcastle United
DATE: 30 Dec 2024
TIME: 20:00 UTC
VENUE: Old Trafford, Manchester, England
More details:
Manchester United live score, schedule and results
Newcastle United live score, schedule and results
Sofascore livescore is available as iPhone and iPad app, Android app on Google Play and Windows phone app. You can find us in all stores on different languages as "Sofascore".


build: call bazel in bazel to build test_cpp.wasm

Signed-off-by: Lizan Zhou<EMAIL_ADDRESS>

cc @jplevyak

there are much better way to do this, will raise another PR.


[Task]: Add U-Flow model

What is the motivation for this task?
Hello guys!
I've been working on a method for Anomaly Detection, which we call U-Flow. It's basically a Normalizing Flows-based method that aggregates the scales' information in UNet-like architecture.
Also, we included a last stage that computes an automatic threshold for anomaly segmentation, which is based only on statistical hypothesis testing and doesn't make use of any anomalous samples.
This work is currently under review
I included the references in case you want to take a look:

https://arxiv.org/pdf/2211.12353.pdf
https://github.com/mtailanian/uflow

Describe the solution you'd like
I wonder if you find it of interest that I contribute with this method. I'd be happy to do it.
Thanks in advance, and thank you very much for such a nice work here!
Additional context
No response

Hi @mtailanian, first of all, congrats on your submission, hope you'll get the paper published.
If you would like to contribute, we would be happy to see U-Flow implemented in anomalib. Thanks!

Thanks @samet-akcay ! I'll start working on this!


Fix Contribution Table

As per suggestions, keep contribution table small so not to scare user (can show all with button)
Fixed "nobody to pay yet..." problem

@tbranyen could you perhaps take a look at the travis error? I am nor sure why it's failing...


Big update in go_gamification, chars, inventory

Summary
Big update in go_gamification, chars, inventory
Other Information

Coverage remained the same at 0.0% when pulling cf832d4af8a393759c7418e55750d1d535f89df4 on jcottobboni:master into e59090b626c2b2f7a83c715fc7fa7bf37ace96e3 on gorails:master.


Labeled models

Please ensure your pull request adheres to the following guidelines:

[ ] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[ ] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

It looks like this PR includes a lot of changes that work in your new syntax for utility functions.
Can these changes be merged without the additional changes that are about labelled models?
It would be easier to review the material in this PR if it was broken up into multiple PRs that focus an particular functions.

It looks like this PR includes a lot of changes that work in your new syntax for utility functions.
Can these changes be merged without the additional changes that are about labelled models?
It would be easier to review the material in this PR if it was broken up into multiple PRs that focus an particular functions.

Yes, there are changes on this branch that are part of other PRs, but I should probably remove those.
The most important files for this PR are HARK/ConsumptionSaving/ConsLabeledModel.py and the corresponding notebook examples/LabeledModels/LabeledModels.ipynb.

I have removed the changes in #1168 but this still depends on the changes in #1170

Codecov Report
Base: 72.71% // Head: 71.01% // Decreases project coverage by -1.70% :warning:

Coverage data is based on head (83a5a5a) compared to base (ae96a00).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   72.71%   71.01%   -1.71%
==========================================
  Files          72       73       +1
  Lines       11764    12046     +282
==========================================
  Hits         8554     8554
- Misses       3210     3492     +282

Impacted Files
Coverage Δ

HARK/ConsumptionSaving/ConsLabeledModel.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

was able to fix these tests by switching workflow of examples from 3.7-3.8 to 3.8-3.9
@llorracc @MridulS @sbenthall should we still be maintaining compatibility with 3.7? or can we move up?

Tests, documentation, and changelog please!

Messed up the upstream/master merge and a lot of things broke down. Will have to do a bit of work to fix this one.

@llorracc Further changes can be made to these models, but I think they are in good enough shape for release 0.13, pending passing checks

Hi @alanlujan91
I know you are stoked to get this feature in before the 0.13 release.
But for a substantial addition to the code base like this, I think we really do need to insist on docs and tests, which are still missing.
We use the numpy standard for docstrings so API documentation is autogenerated into ReadTheDocs:
https://numpydoc.readthedocs.io/en/latest/format.htmls.
For the tests, they can probably be copied and edited from the existing consindshock tests, and used to verify that the new implementation is bug free.
Given that the 0.13 release is already way overdue, I would recommend that we let you give this PR the attention it deserves and hold off on merging it until later. I would like to get on a semiannual release cycle for HARK, which would mean that we would have another release this coming summer.

Very well. We can hold off on the 0.13 release. But we need tests and docs for this work.

I agree, we need to wait for tests and docs.

Merged. Hooray! Great work @alanlujan91


fix(pydocstyle): Avoid trimming docstring if starts with leading quote

Fixes: #2017
looks like the other way round is also possible to break:
```""" "foo"""`

I don't know how to update the signature files, yet.

Ah great! You can run cargo test --lib and then cargo insta review (after cargo install cargo-insta). If you don't have those tools setup, I can also help.

@charliermarsh thanks, done.


Generated Swagger JSON causes Swagger Editor error

Hi there,
I used the swagger blocks code provided in spec/lib/swagger_v2_blocks_spec.rb verbatim to generate the following JSON using swagger-blocks gem version 1.1.2, via Swagger::Blocks.build_root_json and the resulting payload looks like this:
{
  "swagger" : "2.0",
  "info" : {
    "version" : "1.0.0",
    "title" : "Swagger Petstore",
    "description" : "A sample API that uses a petstore as an example to demonstrate features in the swagger-2.0 specification",
    "termsOfService" : "http://helloreverb.com/terms/",
    "contact" : {
      "name" : "Wordnik API Team"
    },
    "license" : {
      "name" : "MIT"
    }
  },
  "host" : "petstore.swagger.wordnik.com",
  "basePath" : "/api",
  "schemes" : [
    "http"
  ],
  "consumes" : [
    "application/json"
  ],
  "produces" : [
    "application/json"
  ],
  "securityDefinitions" : {
    "api_key" : {
      "type" : "apiKey",
      "name" : "api_key",
      "in" : "header"
    },
    "petstore_auth" : {
      "type" : "oauth2",
      "authorizationUrl" : "http://swagger.io/api/oauth/dialog",
      "flow" : "implicit",
      "scopes" : {
        "write:pets" : "modify pets in your account",
        "read:pets" : "read your pets"
      }
    }
  },
  "tags" : [
    {
      "name" : "pet",
      "description" : "Pets operations",
      "externalDocs" : {
        "description" : "Find more info here",
        "url" : "https://swagger.io"
      }
    }
  ],
  "paths" : {
    "/pets" : {
      "get" : {
        "description" : "Returns all pets from the system that the user has access to",
        "operationId" : "findPets",
        "produces" : [
          "application/json",
          "application/xml",
          "text/xml",
          "text/html"
        ],
        "parameters" : [
          {
            "name" : "tags",
            "in" : "query",
            "description" : "tags to filter by",
            "required" : false,
            "type" : "array",
            "items" : {
              "type" : "string"
            },
            "collectionFormat" : "csv"
          },
          {
            "name" : "limit",
            "in" : "query",
            "description" : "maximum number of results to return",
            "required" : false,
            "type" : "integer",
            "format" : "int32"
          }
        ],
        "responses" : {
          "200" : {
            "description" : "pet response",
            "schema" : {
              "type" : "array",
              "items" : {
                "$ref" : "#/definitions/Pet"
              }
            }
          },
          "default" : {
            "description" : "unexpected error",
            "schema" : {
              "$ref" : "#/definitions/ErrorModel"
            }
          }
        }
      },
      "post" : {
        "description" : "Creates a new pet in the store.  Duplicates are allowed",
        "operationId" : "addPet",
        "produces" : [
          "application/json"
        ],
        "parameters" : [
          {
            "name" : "pet",
            "in" : "body",
            "description" : "Pet to add to the store",
            "required" : true,
            "schema" : {
              "$ref" : "#/definitions/PetInput"
            }
          }
        ],
        "responses" : {
          "200" : {
            "description" : "pet response",
            "schema" : {
              "$ref" : "#/definitions/Pet"
            }
          },
          "default" : {
            "description" : "unexpected error",
            "schema" : {
              "$ref" : "#/definitions/ErrorModel"
            }
          }
        }
      }
    },
    "/pets/{id}" : {
      "get" : {
        "description" : "Returns a user based on a single ID, if the user does not have access to the pet",
        "operationId" : "findPetById",
        "produces" : [
          "application/json",
          "application/xml",
          "text/xml",
          "text/html"
        ],
        "parameters" : [
          {
            "name" : "id",
            "in" : "path",
            "description" : "ID of pet to fetch",
            "required" : true,
            "type" : "integer",
            "format" : "int64"
          }
        ],
        "responses" : {
          "200" : {
            "description" : "pet response",
            "schema" : {
              "$ref" : "#/definitions/Pet"
            }
          },
          "default" : {
            "description" : "unexpected error",
            "schema" : {
              "$ref" : "#/definitions/ErrorModel"
            }
          }
        },
        "security" : [
          {
            "api_key" : []
          },
          {
            "petstore_auth" : [
              "write:pets",
              "read:pets"
            ]
          }
        ]
      },
      "delete" : {
        "description" : "deletes a single pet based on the ID supplied",
        "operationId" : "deletePet",
        "parameters" : [
          {
            "name" : "id",
            "in" : "path",
            "description" : "ID of pet to delete",
            "required" : true,
            "type" : "integer",
            "format" : "int64"
          }
        ],
        "responses" : {
          "204" : {
            "description" : "pet deleted"
          },
          "default" : {
            "description" : "unexpected error",
            "schema" : {
              "$ref" : "#/definitions/ErrorModel"
            }
          }
        }
      }
    }
  },
  "definitions" : {
    "Pet" : {
      "required" : [
        "id",
        "name"
      ],
      "properties" : {
        "id" : {
          "type" : "integer",
          "format" : "int64"
        },
        "name" : {
          "type" : "string"
        },
        "colors" : {
          "type" : "array",
          "items" : {
            "type" : "string"
          }
        }
      }
    },
    "PetInput" : {
      "allOf" : [
        {
          "$ref" : "#/definitions/Pet"
        },
        {
          "required" : [
            "name"
          ],
          "properties" : {
            "id" : {
              "type" : "integer",
              "format" : "int64"
            }
          }
        }
      ]
    },
    "ErrorModel" : {
      "required" : [
        "code",
        "message"
      ],
      "properties" : {
        "code" : {
          "type" : "integer",
          "format" : "int32"
        },
        "message" : {
          "type" : "string"
        }
      }
    }
  }
}

Pasting the above generated JSON into the  Swagger Editor, however, results in an error and a warning. The error looks like this:
Swagger Error
Definition requires property but it is not defined: name
Jump to line 236
Details
 Object
code:  "MISSING_REQUIRED_DEFINITION_PROPERTY"
message:  "Definition requires property but it is not defined: name"
 path: Array [6]
level: 900
$$hashKey:  "object:1826"

Did I miss something obvious here?
Thanks a ton!

Cool, never seen the Swagger Editor before.
So, this was just a small issue with the test definitions, just fixed with https://github.com/fotinakis/swagger-blocks/commit/9968bc4a9773d9dd3fa8ed2eff911e2bfa137d1f#diff-56381125e40f121ee9ef68ebfba3bc2e and if you try again it should work. In general, Swagger::Blocks doesn't currently validate that you're producing valid Swagger JSON, it just produces whatever definitions you give it (which could be completely invalid, it's up to you to make sure they work).


Adding support for link_names in webhook

Just a simple support to parse user names in text sent via webhook.

Hey, is there any chance this could be merged or should I close it? Part of Christmas cleanup :-)

wondering if this should be a boolean true/false instead of 0/1? seems like the original api implementation was a mistake :(

merged in c32cf03ed5f85b2426703dda69c88c2cb1e71a26, thanks!


Model fails to download - hashes do not match

Whisper fails to download the model when starting the container.
When starting the container on 0.0.3, I'm seeing the following error:

whisper  | WARNING:wyoming_faster_whisper.download:Model hashes do not match
whisper  | WARNING:wyoming_faster_whisper.download:Expected: {'config.json': 'e5a2f85afc17f73960204cad2b002633', 'model.bin': 'ecd0fd5e2eb9390a2b31b7dd8d871bd1', 'vocabulary.txt': 'c1120a13c94a8cbb132489655cdd1854'}
whisper  | WARNING:wyoming_faster_whisper.download:Got: {'model.bin': '', 'config.json': '', 'vocabulary.txt': ''}
whisper  | INFO:__main__:Downloading FasterWhisperModel.BASE_INT8 to /data

After hanging on this message for several minutes I get the following error:

INFO:__main__:Downloading FasterWhisperModel.BASE_INT8 to /data
whisper  | Traceback (most recent call last):
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 1346, in do_open
whisper  |     h.request(req.get_method(), req.selector, req.data, headers,
whisper  |   File "/usr/lib/python3.9/http/client.py", line 1255, in request
whisper  |     self._send_request(method, url, body, headers, encode_chunked)
whisper  |   File "/usr/lib/python3.9/http/client.py", line 1301, in _send_request
whisper  |     self.endheaders(body, encode_chunked=encode_chunked)
whisper  |   File "/usr/lib/python3.9/http/client.py", line 1250, in endheaders
whisper  |     self._send_output(message_body, encode_chunked=encode_chunked)
whisper  |   File "/usr/lib/python3.9/http/client.py", line 1010, in _send_output
whisper  |     self.send(msg)
whisper  |   File "/usr/lib/python3.9/http/client.py", line 950, in send
whisper  |     self.connect()
whisper  |   File "/usr/lib/python3.9/http/client.py", line 1417, in connect
whisper  |     super().connect()
whisper  |   File "/usr/lib/python3.9/http/client.py", line 921, in connect
whisper  |     self.sock = self._create_connection(
whisper  |   File "/usr/lib/python3.9/socket.py", line 843, in create_connection
whisper  |     raise err
whisper  |   File "/usr/lib/python3.9/socket.py", line 831, in create_connection
whisper  |     sock.connect(sa)
whisper  | TimeoutError: [Errno 110] Connection timed out
whisper  |
whisper  | During handling of the above exception, another exception occurred:
whisper  |
whisper  | Traceback (most recent call last):
whisper  |   File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
whisper  |     return _run_code(code, main_globals, None,
whisper  |   File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
whisper  |     exec(code, run_globals)
whisper  |   File "/usr/local/lib/python3.9/dist-packages/wyoming_faster_whisper/__main__.py", line 135, in <module>
whisper  |     asyncio.run(main())
whisper  |   File "/usr/lib/python3.9/asyncio/runners.py", line 44, in run
whisper  |     return loop.run_until_complete(main)
whisper  |   File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
whisper  |     return future.result()
whisper  |   File "/usr/local/lib/python3.9/dist-packages/wyoming_faster_whisper/__main__.py", line 75, in main
whisper  |     model_dir = download_model(model, args.download_dir)
whisper  |   File "/usr/local/lib/python3.9/dist-packages/wyoming_faster_whisper/download.py", line 90, in download_model
whisper  |     with urlopen(model_url) as response:
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 214, in urlopen
whisper  |     return opener.open(url, data, timeout)
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 517, in open
whisper  |     response = self._open(req, data)
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 534, in _open
whisper  |     result = self._call_chain(self.handle_open, protocol, protocol +
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
whisper  |     result = func(*args)
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 1389, in https_open
whisper  |     return self.do_open(http.client.HTTPSConnection, req,
whisper  |   File "/usr/lib/python3.9/urllib/request.py", line 1349, in do_open
whisper  |     raise URLError(err)
whisper  | urllib.error.URLError: <urlopen error [Errno 110] Connection timed out>
whisper exited with code 1

I believe this issue is new in 0.0.2 or 0.0.3 as I was able to run a previous version fine a few days ago and only ran into this issue when pulling the latest version today.

To follow-up, I did partially resolve this issue. I ended up updating the OS on this system (Ubuntu 20.04 to 22.04.2). That unfortunately probably masked whatever the root cause was, but regardless it appears it was something on my system and probably not an issue with this container itself.
That said, I do still get the warning about hashes not matching. Despite this, the models seem to download anyway and whisper starts successfully.

Version 2.0.0 is using a new downloader: https://github.com/rhasspy/wyoming-faster-whisper/releases/tag/v2.0.0


can't install alfred

Hi, I'm interested in using your tool but I can't install it.
Here's my environment:
rpm -qf /etc/redhat-release
centos-release-6-10.el6.centos.12.3.x86_64

uname -s -r
Linux 2.6.32-642.15.1.el6.x86_64

when trying to run precompiled executable I get:
FATAL: kernel too old
[1]    15238 abort (core dumped)  ./alfred_v0.1.17_linux_x86_64bit

I can install from bioconda no problem. when I try to run I get:
alfred
alfred: symbol lookup error: alfred: undefined symbol: _ZN5boost15program_options3argE
(miniconda3-latest)

Tried compiling from source wtih gcc/5.4.0, intelmpi/5.1.3, boost/1.6.3, and cmake/3.9.0 but get a lot of errors - mostly having to do with boost (see attached error log).
Any ideas as to what's going wrong?
error.log
cheers,
-shane

Update: Alfred v0.1.7 precompiled binaries work and so does installing from source. No releases higher than v0.1.7 work for me.
so whatever changes were made between version Alfred v0.1.7 Alfred v0.1.8 is what is causing it to break on my system.
thanks,
-shane

Hi Shane,
If your kernel is too old for the static binaries and also Bioconda is not working then I suspect some packages on your system are really outdated. Probably best if you try the alfred docker container then: https://hub.docker.com/r/trausch/alfred/
Best, Tobias

OK thanks - I was trying to get it working without Docker, but I'll give it a try. I'm still surprised this doesn't compile on our cluster...

UPDATE: the docker file works but it's not ideal for our purposes. I'll close this issue


Init shell env in pty host service

Might fix #128564, need to do a build and see if detection is correct on macOS.

I am not seeing the exec error and installed pwsh and it's showing up in the dropdown. There are a number of shells that are detected, but not shown in the dropdown 🤔 though. Merging this as it does resolve the two described issues


Adding a TransferStatus class with the status constants.

As the Payin and Payout have the PayinStatus and the PayoutStatus classes, the Transfer should have it's own TransferStatus.
Obviously, this introduces no BC.

Hello @iammichiel, thanks for your contribution!
Your point is valid, yet I'd like to suggest deleting the three redundant Status classes, and keeping only one called TransactionStatus. I think this would be a more clear solution, seeing as the Status is only actually stored in a field within the Transaction class. Do you agree? If so, please update this pull request whenever you find the time (I tried to do it myself, but I do not have permissions to push to your fork!).
Tanks again!

That was indeed what I first had in mind, however deleting two classes (PayinStatus and PayoutStatus) will introduce a BC break. If we accept to make the BC break, there are many other things that might be updated as well.

We could simply mark them as deprecated as to not introduce any BC breaks

Hi everybody, and thanks for brainstorming around our SDK !
I agree with you @venyii, the best solution would be a deprecation of these two classes, and a new Status class, but it could be a little bit messy, right?


docs: add R3DRUN3 profile to readme

What type of PR is this? (check all applicable)

[X] 🚀 Added Name
[ ] ✨ Feature
[ ] ✅ Joined Community
[ ] 🌟 ed the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile
https://github.com/R3DRUN3/R3DRUN3

Any news on this PR?
Thank you!


fix: Crash if spending limit module is not deployed on a chain

What it solves
Resolves #3889
How this PR fixes it

getAllowanceModuleDeployment can't throw. It instead returns undefined if the module is not deployed on a network. Instead of manually throwing on our side, we handle the undefined value.
getSpendingLimitModuleAddress can return string | undefined instead of just string

How to test it

Open one of these Safes: arb1:0x2EBA2F2F1D599E9E2920ce4B70b1B881e76db82E, aurora:0xDBe6f953a53eE0Eb7D28101e123D7bf6553638eb
Observe the app not crashing

Let me know if it is related to this ticket or not

It seems that the web3 object was undefined. I tested both safes without getting the error so I would say it is unrelated to these changes.

It seems that the web3 object was undefined. I tested both safes without getting the error so I would say it is unrelated to these changes.

This is very likely related to the issue we were experiencing yesterday before the hotfix.

If the issues are unrelated we can pass this one to QA done.


README: Added latest supported parsers

Coverage decreased (-1.61%) to 91.94% when pulling 64610f44ff12b54fab67e5e8d96922e7fc1f4773 on PabloCastellano:master into dca09caeeaa3515f4ccc145648465b7bc85b6952 on ninuxorg:master.

@PabloCastellano it looks like there's a little issue with this PR, it seeems it includes a commit from @gabri94 of 2 days ago. No worries I'll merge manually.

Merged manually, see https://github.com/ninuxorg/netdiff/commit/dd1af857567d940775e1e9d422c9429e3158150a.
thanks @PabloCastellano :+1:


Fix missing environment variables (specifically, precision)

Describe what the PR does:
We were missing some environment variables in the mapping – this PR fixes things.
Does this fix a specific issue?
Fixes https://github.com/bachya/ecowitt2mqtt/issues/362
Checklist:

[ ] Confirm that one or more new tests are written for the new functionality.
[x] Run tests and ensure everything passes (with 100% test coverage).
[ ] Update README.md with any new documentation.
[ ] Add yourself to AUTHORS.md.

@alexdelprete Can you test the PR Docker image once it's published?

@alexdelprete Can you test the PR Docker image once it's published?

Sure, can you tell me how do I pull that specific version without waiting for a release tag? Never done it before. :)

Sure, can you tell me how do I pull that specific version without waiting for a release tag? Never done it before. :)

Once that linked build is successful (will take a bit), you can pull bachya/ecowitt2mqtt:pr-363.

Sure, can you tell me how do I pull that specific version without waiting for a release tag? Never done it before. :)

Once that linked build is successful (will take a bit), you can pull bachya/ecowitt2mqtt:pr-363.

so PRs have tags, one more thing I learned, thanks. will let you know about the test.

@alexdelprete I actually implemented PR-to-Docker-Hub based on your feedback (wanting to test a previous PR) – so, thank you for the push!

@bachya it's not a default feature? Should be!! :)
Would it be integrated with ghcr.io? What advantages does DH offer vs GHCR?

@bachya it's not a default feature? Should be!! :)
Would it be integrated with ghcr.io? What advantages does DH offer vs GHCR?

I've read several articles and can't seem to see an advantage of one over the other. I suppose ghcr.io benefits from being directly attached to the companion repo. Perhaps I should support both. 😉

@bachya it's not a default feature? Should be!! :)
Would it be integrated with ghcr.io? What advantages does DH offer vs GHCR?

I've read several articles and can't seem to see an advantage of one over the other. I suppose ghcr.io benefits from being directly attached to the companion repo. Perhaps I should support both. 😉

You know that mine was a rethorical question...just a very indirect FR. 😜
Actually, I do prefer much more ghcr.io: DH has strict pull limitations for free accounts, and using a lot of containers in my homelab, I did often hit the limit with checks etc. So whenever possible I opted for ghcr and other registries, and I always suggest devs to offer alternatives if it's not too difficult.

@alexdelprete Looks like the build has finished, FYI.

@alexdelprete Looks like the build has finished, FYI.

Working fine.


Links for M VM series are pointing to Hana disk storage urls

I would have expected that these point to their respective VM size link e.g. https://docs.microsoft.com/en-us/azure/virtual-machines/m-series

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b4f48bd-e5e9-ebca-e29e-9dec927bc2d3
Version Independent ID: 2e032831-dbb6-aaf2-15ce-ac072ef36727
Content: Select a disk type for Azure IaaS VMs - managed disks - Azure Virtual Machines
Content Source: articles/virtual-machines/disks-types.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@VaclavK Thanks for pointing this out. I have updated the document with respective page links for M & Mv2 series, the changes will go live once the PR is approved.


Auto-generate separated files

Is it supported to auto-generate separate files provided in i18n-js.yml or not?
It's not fun to run rake i18n:js:export every time :-(.
I did not find any info in docs about this feature.

What do you mean by "auto-generate"?
There is a I18n::JS::Middleware in README.
Not sure if that's what you want.

Consider I have these lines in config
translations:
 - file: "i18n/admin.js"
   only: ["*.js.admin", "*.js.shared", "*.activerecord.models", "*.activerecord.attributes"]

translations:
 - file: "i18n/moderation.js"
   only: ["*.js.moderation", "*.js.shared", "*.quest_page"]

I want just to use it in application.js this way
#= require 'i18n/admin'

and in another file
#= require 'i18n/moderation'

without manually generating it with rake i18n:js:export. Is it possible?

So how many javascript_include_tag would be in your layout?

I have two separate layouts. One for Admin UI and one for end-users and I want to split locales.
I use two different main js files (application.js and moderation.js) and include them in relative layout like  that
<%= javascript_include_tag "application" %>

<%= javascript_include_tag "moderation" %>

I don't think this feature is present yet.
If I am going to implement it, it would properly be something like
# app/assets/javascripts/your_own_file.js.erb
<%# encoding: utf-8 %>
;(function(factory) {
if (typeof module !== 'undefined' && module.exports) {
// Node/CommonJS
factory(require('i18n'));
} else if (typeof define === 'function' && define.amd) {
// AMD
define(['i18n'], factory);
} else {
// Browser globals
factory(this.I18n);
}
}(function(I18n) {
"use strict";
I18n.translations = <%= I18n::JS.filtered_translations(something_here).to_json %>;
}));

Ok, I will make something like that

Remember, this gem does NOT have such feature yet.

Its works!

Add config.middleware.use I18n::JS::Middleware to config/environments/development.rb (to check and invalidate cache between requests if necessary)
Add separate .js file for each file in i18n-js.yml config

;(function(factory) {
  if (typeof module !== 'undefined' && module.exports) {
    // Node/CommonJS
    factory(require('i18n'));
  } else if (typeof define === 'function' && define.amd) {
    // AMD
    define(['i18n'], factory);
  } else {
    // Browser globals
    factory(this.I18n);
  }
}(function(I18n) {
  "use strict";

  I18n.translations = <%= I18n::JS.translation_segments.detect{ |s| File.basename(s.file) == 'admin.js' }.translations.to_json %>;
}));

OK
I guess there can be a better way to do this.
But I will leave it for 3.1

I will try to find a better way. Also I found sideeffect of using middleware. This line https://github.com/fnando/i18n-js/blob/master/lib/i18n/js/middleware.rb#L65 generates additional files in app/assets/javascripts :-( so I need a copy of this middleware in my /lib without this line :-( .

So you are using that middleware without the last line only?

Using this middleware (with or without last line) doesn't work fine :-( If there is last line it generates plain *.js files near my *.js.erb files, without it doen't update root level *.js file (e.g. application.js) when locale files is updated, because it uses a stale information from cache :-(

I suppose there should be some ruby-helper method which can be used to insert some part of locales in js files and some middleware that will invalidate cache for those .js files so application.js can be recompiled with new version of locales.

As I said this feature is not present yet, but there are enough things stalling 3.0 already :P


Makefile: allow customizable GO_BUILD

This will let me use a customizable GO_BUILD so that I can run build
targets for deb packages
Signed-off-by: Lokesh Mandvekar<EMAIL_ADDRESS>@mheon @rhatdan PTAL.

/approve
LGTM

err, i guess someone needs to slash-lgtm it.

/lgtm


drivers: usb: nrf5: various fixes

Fix the following issues:

Recently the usb_dc_ep_mps() API was added which is required for usb_transfer APIs. This function needs to be implemented by all the usb device drivers. Since the nRF52840 driver was merged just before the merge of usb_transfer API PR #5983 the new API definition is missing. Without this change, there's a linking issue as the usb_dc_ep_mps() function is missing.

Fix OUT endpoint read size that is seen with cdc_acm sample.

Fix issue with ISO IN/OUT SOF handling.

CC @carlescufi

CC @IvanSanchez

Codecov Report

Merging #6655 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6655      +/-   ##
==========================================
+ Coverage   53.87%   53.87%   +<.01%
==========================================
  Files         439      439
  Lines       41687    41687
  Branches     7945     7945
==========================================
+ Hits        22458    22459       +1
+ Misses      16027    16026       -1
  Partials     3202     3202

Impacted Files
Coverage Δ

kernel/posix/pthread.c
69.5% <0%> (+0.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83752c1...50f6b76. Read the comment docs.

CC @pawelzadrozniak

+1 to this.  sanitycheck on master is currently broken and this should fix it.


Default prometheus-operator deployment spec invalid

What happened?
Trying to deploy prometheus-operator -- k8s returns an error:
The Deployment "prometheus-operator" is invalid:

spec.selector: Invalid value:
    v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"controller", "app.kubernetes.io/name":"prometheus-operator", "domain":"prometheus"},

MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

I'm using the same yaml you have in your example / getting started:
Here it is:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app.kubernetes.io/component: controller
    app.kubernetes.io/name: prometheus-operator
    app.kubernetes.io/version: v0.34.0
  name: prometheus-operator
  namespace: default
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/component: controller
      app.kubernetes.io/name: prometheus-operator
  template:
    metadata:
      labels:
        app.kubernetes.io/component: controller
        app.kubernetes.io/name: prometheus-operator
        app.kubernetes.io/version: v0.34.0
    spec:
      containers:
        - args:
            - --kubelet-service=kube-system/kubelet
            - --logtostderr=true
            - --config-reloader-image=quay.io/coreos/configmap-reload:v0.0.1
            - --prometheus-config-reloader=quay.io/coreos/prometheus-config-reloader:v0.34.0
          image: quay.io/coreos/prometheus-operator:v0.34.0
          name: prometheus-operator
          ports:
            - containerPort: 8080
              name: http
          resources:
            limits:
              cpu: 200m
              memory: 200Mi
            requests:
              cpu: 100m
              memory: 100Mi
          securityContext:
            allowPrivilegeEscalation: false
      nodeSelector:
        beta.kubernetes.io/os: linux
      securityContext:
        runAsNonRoot: true
        runAsUser: 65534
      serviceAccountName: prometheus-operator

The only minor difference is I've removed the namespace b/c I use Kustomize to override the namespace and set it to the value monitoring.
Did you expect to see some different?
Yes, expected it to deploy without an error.  The bizarre thing is that it still spun up an operator....logs are below.
How to reproduce it (as minimally and precisely as possible):
Try to deploy that yaml above
Environment
EKS

Prometheus Operator version:

v0.34.0
`Insert image tag or Git SHA here`
<!-- Try kubectl -n monitoring describe deployment prometheus-operator -->

Kubernetes version information:

$ kc version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-13T11:52:32Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.8-eks-b8860f", GitCommit:"b8860f6c40640897e52c143f1b9f011a503d6e46", GitTreeState:"clean", BuildDate:"2019-11-25T00:55:38Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
Terraform VPC/EKS modules

Manifests:

See above

Prometheus Operator Logs:

ts=2019-12-18T16:38:10.40184824Z caller=main.go:199 msg="Starting Prometheus Operator version '0.34.0'."

Is this reproducible on a minikube or kind cluster? Because we run this on every PR and every CI run, and are getting no errors.

Hi @brancz -- I am unsure if it is reproducible on Minikube.  The error is strange tho?
spec.selector: Invalid value:
    v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"controller", "app.kubernetes.io/name":"prometheus-operator", "domain":"prometheus"},

MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Why would it indicate that the MatchExpressions - LabelSelectorRequirement is immutable?
If you are already deploying the same yaml in Minikube for CI, then I'm guessing it isn't complaining.  This was an EKS cluster I created from Terraform.  Nothing particularly spectacular or weird about it.  I've been running it for months for development.

This could only have happened if you already had a prometheus operator deployment as the selector is indeed immutable and we did change it somewhat recently.

Hmm...that could be.  I'm using Flux and it's possible in my experimentation with bootstrapping it, it wasn't cleaned up completely when I tried to re-deploy.  I'll go ahead and close the issue.


Operators/instanceof.js timed out on OS X (might consider marking test as Slow)

https://ci.dot.net/job/Microsoft_ChakraCore/job/release_1.3/job/osx_osx_debug_static_prtest/9/consoleFull#1955843533c7453dd6-bf4f-4ae9-9fca-50f9ec7ab19e
[933/1601 60.16] Failed -> Operators/instanceof.js
19:02:18
ERROR: Test timed out!
19:02:18 /Users/dotnet-bot/j/workspace/Microsoft_ChakraCore/release_1.3/osx_osx_debug_static_prtest/BuildLinux/Debug/ch -WERExceptionSupport -ExtendedErrorStackForTestHost -BaselineMode -forceNative -off:simpleJit -bgJitDelay:0 -dynamicprofileinput:profile.dpl.1088 /Users/dotnet-bot/j/workspace/Microsoft_ChakraCore/release_1.3/osx_osx_debug_static_prtest/test/Operators/instanceof.js

Finished running the same config ~2000 times and avg was ~4secs. I would like to consider this as a temporary CI slowdown. We had similar problems in the past with the macOS CI.
@dilijev Thanks for opening this. Closing for now. If it repeats on the same test case, we may have more reasons to suspect from something else.


Enable build scans and build cache in Jenkinsfile and list build scans in a GitHub check

Oddly, it seems the build cache and, more annoyingly, build scans, were not enabled in the Jenkinsfile. So this fixes that. Note that for pull requests, we use a different access key which is not able to push to the build cache -- for security reasons.
Also, this enables a new feature in hibernate-github-bot that basically adds a GitHub check next to the existing ones for GitHub Actions or Jenkins, and inside that check is a list of build scans, along with some context (tags, ...).
Note this works best when build scans are tagged properly, e.g. you add a postgresql tag to CI runs against postgresql. So I adjusted GitHub Actions workflows and the Jenkinsfile accordingly.

See https://github.com/hibernate/hibernate-github-bot/pull/227

Note you won't see the Develocity check in this PR, because only the bot config from the main branch is taken into account. So any change to the bot config in this PR will have to get merged before it's taken into account.

Sorry -- much better if I actually push all the commits :]

So, looks like Gradle's Develocity integration does not add the Git commit id custom value to build scans: https://ge.hibernate.org/s/xdhwmr2vvdxyu/custom-values That will be a problem... I'll look into adding it manually.


catch rounded corner

Got lost in a merge conflict

Coverage decreased (-0.2%) to 83.555% when pulling 8a3fba22034b572cec373a3e83686ff0b2a581f3 on na3d:catch-rounded-corner into 56cc5d0c6da778dda8f14c7d8763487d849c8e6c on linode:master.


[cypress] Fix e2e tests in Meshery-UI

Current Behavior

Current User-preferences tests are failing which needs research for reason till then, those tests are skipped to give green signal to PRs that arent dependedent. Meanwhile, we should take time to fix it.

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@Abhishek-kumar09 can you assign this to me. I will take a look into it.

@vaibhav135 While this issue is opened, I think this isn't a good issue first you should work on, given there should be some research here to identify the cause of the problem and one or more systems are directly or indirectly connected with this issue.
But hey, I think you can still take a look, and give your inputs.

@Abhishek-kumar09 yes sure I will take a look into it for sure.

Yeah the tests should be passing. These tests passes on local environment but fails in ci.


Update discordpy to a supported version

datcord_bot has been stuck on an old discordpy version for years. It would be nice to upgrade it to the latest version, so that the bot can run with Python 3.7 and later.

I would be interested to work on this.
If I am not mistaken I will need to register my own bot to get a token for testing. Which permissions do I have to give to that test bot?

@winston-yallow You need to give it the following permissions:

Manage Roles
Read Text Channels & See Voice Channels
Send Messages
Embed Links

Got a working dev env, thanks! There are a few things that changed in discord.py between 0.16 and 1.2 so I need to adjust them. I will work more on this tomorrow.