fix: init with CustomEmojiNode

FX-4143
Description
There is a bug in Lexical, there is already opened issue https://github.com/facebook/lexical/issues/4641, we need to revert to the older version, so we can use custom DecoratorNode
How to test

custom emoji in the temploy shows with spaces around it

Screenshots

Before.
After.

Development checks

Add changeset according to guidelines (if needed)
-Read CONTRIBUTING.md and Component API principles
Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
Annotate all props in component with documentation
Create examples for component
[x] Ensure that deployed demo has expected results and good examples
Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
Covered with tests

Breaking change

codemod is created and showcased in the changeset
test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

I can't see the linked temploy, even if a I remove the suffix and visit https://picasso.toptal.net/fx-4143-custom-node-insert/ it still doesn't show the changes

@augustobmoura it seems we have a problem with deploy, could you check locally? 🙇


readBinary should request an arraybuffer?

Hi there, in Client/src/providers/storageProvider, should the readBinary function request an arraybuffer as the response? I think the axios default is a json, and this causes problems when reading a pdf for example.
    public async readBinary(filename: string, ignoreNotFound?: boolean): Promise<Buffer | undefined> {
        try {
            const api = `${serverUrl}/files/${filename}`;
            const result = await getWithAutoRetry(api, {
                responseType:"arraybuffer" //Added this
            }
        );
            return result.data;
        } catch (exception) {
            this.storageErrorHandler(exception, ignoreNotFound);
        }
    }

Thanks for reporting! Yes we should specify arraybuffer, putting this into our backlog.

Pull request is published to address this issue, please take a look.


Added documentation

I still need to update the examples (of the examples folder, not the examples in the README) to reflect the new world order, but otherwise I think this is all the documentation done. Opening this to receive comments on what I've done so far.
I wrote most of this from scratch so let me know if you disagree with anything / if I missed something.

 I made some tweaks in #69, but they're perhaps not sufficient to get things working really stably.

Agreed. I'll dig into that. (In a separate PR).

@lxuechen Since you beat me to updating the notebook example then I think this PR is probably good to go. I know there's a couple of outstanding to-dos that I need to sort out (BInterval tests; SDE-GAN example), but once that done I think we're ready for the next release?

SGTM! I think we're almost there, but definitely feel free to let me know if there's anything else on your mind that'd be appropriate for v0.2.0.

I'll wait to get #76 in and re-run with that, then look at merging this.


[Docs] Reflect the latest changes regarding copy_on_model_validation

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
The latest release v1.9.2 introduced changes in the configuration option copy_on_model_validation which are not reflected in the documentation.
Currently the documentation in https://pydantic-docs.helpmanual.io/usage/model_config/ shows:

copy_on_model_validation: whether inherited models used as fields should be reconstructed (copied) on validation instead of being kept untouched (default: True)

Affected Components

[x] Documentation
[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Settings Management
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Very good point, thank you for reporting.
Would you be willing to create a PR for this? If so you'll need to set the base to 1.9.X-fixes


Add concept of reviews and 2 new reviewers

This adds the concept of a reviewer to containerd.  These are people who are committed to improving containerd through contributions and reviews.
Reviewers may not meet the time requirements to become maintainers but are on the path.
By adding reviews to the org with read-only permissions, they can be assigned to issues/prs and displayed as members of the org when commenting on reviews.
Their LGTM can count towards the required LGTM count for code merges.

This adds @jessvalarezo and @dnephin as the first reviewers for the project.  They have both been contributing code and reviews for a few months and are good candidates to set the standards for future reviewers.

ping @containerd/containerd-maintainers

LGTM

Codecov Report

Merging #1941 into master will increase coverage by 5.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
+ Coverage   42.17%   47.33%   +5.15%
==========================================
  Files          70       91      +21
  Lines        7632     8964    +1332
==========================================
+ Hits         3219     4243    +1024
- Misses       3905     4022     +117
- Partials      508      699     +191

Flag
Coverage Δ

#linux
50.65% <ø> (?)

#windows
42.17% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

fs/dtype_linux.go
50% <0%> (ø)

fs/diff_unix.go
56.52% <0%> (ø)

archive/tar_unix.go
50.81% <0%> (ø)

snapshots/overlay/overlay.go
56.13% <0%> (ø)

cio/io_unix.go
62.82% <0%> (ø)

oci/spec.go
50% <0%> (ø)

oci/spec_unix.go
98.37% <0%> (ø)

archive/time_unix.go
71.42% <0%> (ø)

fs/copy_linux.go
38.09% <0%> (ø)

fs/hardlink_unix.go
60% <0%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07ede4...ab30079. Read the comment docs.

LGTM


Is it possible to instanciate a picker with a precise hue?

I would like to instanciate the chrome picker with the color white and with a hueset to 250.
My code:
<template>
  <chrome
    v-model="color"
    ref="colorpicker" />
</template>

<script>
  import { Chrome } from 'vue-color';

  export default {
    data() {
      return {
        color: '#fff',
      };
    },
    components: {
      Chrome,
    },
    mounted() {
      this.$refs.colorpicker.colors.oldHue = 250;
    },
  };
</script>

Thanks in advance ;)

data() {
   return {
         color: {
             h: 150,
             s: 0.5,
             v: 0.2
         }
    };
}


Fix "Validation error" message when Assume Role ARN is misconfigured

Need a better error message shown when the Assume Role ARN does not work for a TwinMaker datasource. The error usually occurs when the auth provider creds doesn't have access to the assume role ARN. If any of those fields are incorrect the error message is not clear, so we need to surface the correct one.

this currently looks like this:
for example when there is a faulty assume role ARN:


make theme option more usable

https://github.com/eladnava/mailgen/blob/master/index.js#L16-L22
Currently there's no way to add a custom theme without interfering with the module's /themes folder. I believe the theme option should be a path to a specific theme html file, not a name. That would make it more user friendly.

@alessioalex good idea!
The theme option is actually meant for picking another mailgen theme. Currently we only have default but there are definitely plans to support more themes.
However, what you're saying is true -- making it possible to supply your own theme would be nice, by specifying its path.
What I'm proposing is to have the theme parameter support both a string and an object, like so:
// Configure mailgen to use a custom theme
var mailGenerator = new Mailgen({
    theme: {
        path: path.resolve('public/mailgen/theme.html')
    }
});

// Or, use a mailgen theme
var mailGenerator = new Mailgen({
    theme: 'default',
});

What do you think?

I was thinking of the same thing after reading your 2nd paragraph. Good idea indeed!

@alessioalex Done, thanks for the suggestion! =)


[Deliver] reject_version_if_possible!: undefined method can_reject_version for nil:NilClass

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
I initially call the deliver step to reject any current build if possible. This works fine when there is a build to reject, but if there is nothing to reject, it errors. I expect deliver to gracefully return if there is nothing to reject.
Command executed
lane :beta do |options|
    parameter_validation(options)

    project = options[:project_name]

    match_appstore

    gym(
      scheme: project,
      workspace: project + ".xcworkspace",
      clean: true,
      configuration: "AppStore",
      export_options: {iCloudContainerEnvironment: 'Production'}
    )

    #reject last upload if possible
    deliver(
      force: true,
      reject_if_possible: true,
      skip_screenshots: true,
      skip_metadata: true,
      skip_binary_upload: true,
      skip_app_version_update: true,
      submit_for_review: false,
      run_precheck_before_submit: false
    )

    changelog = Actions.sh("git cat-file -p $(git rev-parse $(git tag -l '?.?.?*' | tail -n1)) | tail -n +6", log: false).chomp

    testflight(
      changelog: changelog,
      distribute_external: true,
      groups: ["External Testers"],
      demo_account_required: true
    )

    deliver(
      force: true,
      skip_screenshots: true,
      skip_binary_upload: true,
      automatic_release: false,
      submit_for_review: true,
      release_notes: {
        'en-US' => changelog
      }
    )
  end

Complete output when running fastlane, including the stack trace and command used

 [11:19:17]: ---------------------
[11:19:17]: --- Step: deliver ---
[11:19:17]: ---------------------
[11:19:17]: Login to App Store Connect (XXX)
Available session is not valid any more. Continuing with normal login.
[11:19:19]: Login successful
+--------------------------------------+------------------------------------------------------+
|                                   deliver 2.137.0 Summary                                   |
+--------------------------------------+------------------------------------------------------+
| force                                | true                                                 |
| reject_if_possible                   | true                                                 |
| skip_screenshots                     | true                                                 |
| skip_metadata                        | true                                                 |
| skip_binary_upload                   | true                                                 |
| skip_app_version_update              | true                                                 |
| submit_for_review                    | false                                                |
| run_precheck_before_submit           | false                                                |
| ipa                                  | /Users/itmobilegit/myagent/_work/1/s/XXX.ipa |
| screenshots_path                     | ./fastlane/screenshots                               |
| metadata_path                        | ./fastlane/metadata                                  |
| app_version                          | 3.6.6                                                |
| username                             | XXX                             |
| app_identifier                       | com.XXX                         |
| platform                             | ios                                                  |
| edit_live                            | false                                                |
| use_live_version                     | false                                                |
| overwrite_screenshots                | false                                                |
| automatic_release                    | false                                                |
| phased_release                       | false                                                |
| reset_ratings                        | false                                                |
| team_id                              | XXX                                              |
| dev_portal_team_id                   | XXX                                           |
| dev_portal_team_name                 | XXX                                          |
| precheck_default_rule_level          | warn                                                 |
| individual_metadata_items            | []                                                   |
| ignore_language_directory_validation | false                                                |
| precheck_include_in_app_purchases    | true                                                 |
+--------------------------------------+------------------------------------------------------+
+------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|                                                                                Lane Context                                                                                |
+------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM                   | ios                                                                                |
| PLATFORM_NAME                      | ios                                                                                |
| LANE_NAME                          | ios beta                                                                                |
| SIGH_PROFILE_TYPE                  | app-store                                                                                |
| MATCH_PROVISIONING_PROFILE_MAPPING | {"com.XXX"=>"match AppStore com..XXX", "comXXX"=>"match AppStore com.XXX", "com.XXX"=>"match AppStore com.XXX", "com.XXX"=>"match AppStore com.XXX"} |
| IPA_OUTPUT_PATH                    | /Users/itmobilegit/myagent/_work/1/s/XXX.ipa                                                                                |
| DSYM_OUTPUT_PATH                   | /Users/itmobilegit/myagent/_work/1/sXXX.app.dSYM.zip                                                                                |
| XCODEBUILD_ARCHIVE                 | /Users/itmobilegit/Library/Developer/Xcode/Archives/2019-12-04XXX 2019-12-04 11.07.26.xcarchive                                                                                |
+------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+------+-----------------------------------------+-------------+
|                       fastlane summary                       |
+------+-----------------------------------------+-------------+
| Step | Action                                  | Time (in s) |
+------+-----------------------------------------+-------------+
| 1    | default_platform                        | 0           |
| 2    | Switch to ios parameter_validation lane | 0           |
| 3    | Switch to ios match_appstore lane       | 0           |
| 4    | match                                   | 6           |
| 5    | gym                                     | 724         |
| 💥   | deliver                                 | 4           |
+------+-----------------------------------------+-------------+
[11:19:22]: fastlane finished with errors
Looking for related GitHub issues on fastlane/fastlane...
Found no similar issues. To create a new issue, please visit:
https://github.com/fastlane/fastlane/issues/new
Run fastlane env to append the fastlane environment to your issue
/Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/spaceship/lib/spaceship/tunes/application.rb:260:in reject_version_if_possible!': [!] undefined method can_reject_version' for nil:NilClass (NoMethodError)
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/deliver/lib/deliver/runner.rb:166:in `reject_version_if_possible'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/deliver/lib/deliver/runner.rb:47:in `run'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/actions/upload_to_app_store.rb:16:in `run'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
from Fastfile:107:in `block (2 levels) in parsing_binding'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/lane.rb:33:in `call'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/commands_generator.rb:349:in `run'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/gems/fastlane-2.137.0/bin/fastlane:23:in `<top (required)>'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/bin/fastlane:23:in `load'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/bin/fastlane:23:in `'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
from /Users/itmobilegit/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `'

Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.6

Ruby
2.5.3

Bundler?
false

Git
git version 2.20.1 (Apple Git-117)

Installation Source
~/.rvm/gems/ruby-2.5.3/bin/fastlane

Host
Mac OS X 10.14.6 (18G103)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.5.3/lib

OpenSSL Version
OpenSSL 1.1.1c  28 May 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.137.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.2.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
2.0.2

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

plist
3.5.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

gh_inspector
1.1.3

mini_magick
4.9.5

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

os
1.0.1

googleauth
0.6.7

httpclient
2.8.3

google-api-client
0.23.9

digest-crc
0.4.1

google-cloud-storage
1.16.0

emoji_regex
1.0.1

nanaimo
0.2.6

colored2
3.1.2

claide
1.0.3

CFPropertyList
3.0.1

atomos
0.1.3

xcodeproj
1.13.0

unicode-display_width
1.6.0

addressable
2.7.0

tty-screen
0.7.0

tty-cursor
0.7.0

tty-spinner
0.9.1

babosa
1.0.3

excon
0.70.0

faraday
0.17.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

fastimage
2.1.7

json
2.2.0

dotenv
2.7.5

naturally
2.2.0

simctl
1.6.6

mime-types-data
3.2019.1009

mime-types
3.3

multi_json
1.14.1

signet
0.12.0

memoist
0.16.1

google-cloud-env
1.3.0

google-cloud-core
1.4.1

openssl
2.1.2

date
1.0.0

fileutils
1.0.2

mini_portile2
2.4.0

nokogiri
1.10.7

ipaddr
1.2.0

psych
3.0.2

generated on: 2019-12-04

Sorry, left a bit out of my original post. Updated with my full lane.
The problem is with this command:
#reject last upload if possible
deliver(
force: true,
reject_if_possible: true,
skip_screenshots: true,
skip_metadata: true,
skip_binary_upload: true,
skip_app_version_update: true,
submit_for_review: false,
run_precheck_before_submit: false
)
I am using deliver here to ONLY reject_if_possible, I don't need it to do anything else yet. I did this because I need to reject before uploading my new test flight build.
This appears to work fine when there IS a build that is a build that can be rejected, but now that I have released and there is nothing for it to reject, this command errors out.
Is there an alternative way I should be rejecting? or is this a bug with deliver that should be fixed?

As a temporary fix, I have removed my first call to deliver that was used to reject. So far things are working as expected. I am thinking that my original issue with test flight failing to upload when there is a version under review has been fixed. I will keep an eye on it and update here with the results.

Actually, I am going to open this back up because I still have an issue with this command:
deliver(
force: true,
reject_if_possible: true,
skip_screenshots: true,
skip_metadata: true,
skip_binary_upload: true,
skip_app_version_update: true,
submit_for_review: false,
run_precheck_before_submit: false
)
The intent is to reject any release that is pending before uploading a new version to test flight.
If I have a version of my app that is under review or pending developer release, then it works. If my last version of the app has been released, then I get the same error.
If I remove this step, then it is the opposite. The test flight fails when there is a pending release, and it succeeds when the last version has been released and there is no pending release.

Testing using ruby error handling as shown here: https://stackoverflow.com/questions/37890582/how-to-continue-on-error-using-fastlane
This would work perfect in my case, because I want to continue on error of the attempt to reject.


[Rector] Apply Rector for QA

Apply Rector for QA in Github workflow, start with LevelSetList::UP_TO_PHP_74.
Use pinned version 0.12.23 on purpose as it need to sync phpstan and nikic/php-parser, ensure only run when working ok.

All green 🎉

Hi @samsonasik thanks for the contribution, although I'm not sure why Rector would be useful here? The library already uses friendsofphp/php-cs-fixer to check for style issues, what more does it bring to the workflow?
My first thought about Rector would be to use it to easily convert the codebase when bumping the minimum PHP requirement (which is great but not really the case here), maybe I'm missing something.

it can cover new syntax update for this initial PR, eg: arrow function, ref https://github.com/CuyZ/Valinor/pull/129/files#diff-fbf35dae269032cbbaa34396944039b84c4670c9f6552a9f6cdf27561efc7b0b
it can detect dead code too, etc, that I may can provide another PR for it with dead code setlist.

Alright, after all there are never enough static analysis. 😁
One thing though: all these changes for the timestamp values (in exceptions) are not needed IMO, can you update the settings so that it doesn't apply on it?
Also, running Rector in dry-run mode should be part of the check Composer script ; running it to actually fix the files should be part of the fix script.

@romm implemented 👍

Hi @samsonasik, just did some adjustments.
Thanks for the contribution!


libvirt: jansson required for qemu suppport

Motivation for this change
libvirt-4.6.0 was built with no qemu support
@Izorkin
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: libvirt
Partial log (click to expand)
patching script interpreter paths in /nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0...
moving /nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/sbin/* to /nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0/bin
/nix/store/5ylqz5fmgf15mdfdc44pq898561kq3q7-libvirt-4.6.0

Success on aarch64-linux (full log)
Attempted: libvirt
Partial log (click to expand)
patching script interpreter paths in /nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0...
moving /nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/sbin/* to /nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0/bin
/nix/store/afqnfrf9zkdzfc1pnr23nx6a8c6bdzyc-libvirt-4.6.0

@volth Thanks.

Shouldn't it be in propagatedBuildInputs ?
I can't connect to libvirtd on slight fork of nixos-unstable  8395f9aa85e621c076334a67d814de8221ce7983 due to:
● libvirtd.service - Libvirt Virtual Machine Management Daemon
   Loaded: loaded (/nix/store/7lhdwy27sqinxn2kvpamn7zr74yi15l6-libvirt-4.6.0/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
  Drop-In: /nix/store/93y3ngdrfc3ji9zadg2byk3rh6akgfiq-system-units/libvirtd.service.d
           └─overrides.conf
   Active: failed (Result: exit-code) since Sat 2018-08-18 17:17:12 JST; 7s ago
     Docs: man:libvirtd(8)
           https://libvirt.org
  Process: 6772 ExecStart=/nix/store/7lhdwy27sqinxn2kvpamn7zr74yi15l6-libvirt-4.6.0/sbin/libvirtd $LIBVIRTD_ARGS (code=exited, status=1/FAILURE)
  Process: 6665 ExecStartPre=/nix/store/7gcz0kiy5gkrql8h883cmc2ylln6dvic-unit-script-libvirtd-pre-start (code=exited, status=0/SUCCESS)
 Main PID: 6772 (code=exited, status=1/FAILURE)

août 18 17:17:12 jedha systemd[1]: Starting Libvirt Virtual Machine Management Daemon...
août 18 17:17:12 jedha libvirtd[6772]: 2018-08-18 08:17:12.873+0000: 6772: info : libvirt version: 4.6.0
août 18 17:17:12 jedha libvirtd[6772]: 2018-08-18 08:17:12.873+0000: 6772: info : hostname: jedha
août 18 17:17:12 jedha libvirtd[6772]: 2018-08-18 08:17:12.873+0000: 6772: error : virJSONJanssonOnceInit:66 : this function is not supported by the connection driver: libjansson.so.4 JSON library not available: libjansson.so.4: cannot open shared object file: No such fi>
août 18 17:17:12 jedha systemd[1]: libvirtd.service: Main process exited, code=exited, status=1/FAILURE
août 18 17:17:12 jedha systemd[1]: libvirtd.service: Failed with result 'exit-code'.
août 18 17:17:12 jedha systemd[1]: Failed to start Libvirt Virtual Machine Management Daemon.

@teto it is fixed in https://github.com/NixOS/nixpkgs/pull/44900

@volth PR https://github.com/NixOS/nixpkgs/pull/44900  reverted ehttps://github.com/NixOS/nixpkgs/commit/59027e28800dd5c2cd1c9d434c1a71d39be19266

@volth PR #44900 reverted 59027e2

So now libvirt is broken on Linux too, not only on Darwin.


Question about permissions in Texting component

@ewpatton @jisqyv
Hi, I'm wondering what these two permissions doing here?
com.google.android.apps.googlevoice.permission.RECEIVE_SMS
com.google.android.apps.googlevoice.permission.SEND_SMS

Added in https://github.com/mit-cml/appinventor-sources/commit/8ef1932d4ebc8aa3c800ceff9f001e9557b37003#diff-13b4b3ef39c8b5c664a580e591f804b8R87 Author by @ram8647

I had found it out, thanks


⚠ Auth Portal has degraded performance

In dc6bcb0, Auth Portal (https://auth.zyradyl.moe) experienced degraded performance:

HTTP code: 523
Response time: 17493 ms

Resolved: Auth Portal performance has improved in a2f33f6 after 5 minutes.


[WSL 2] Hangs forever on most network calls (like curl, git, etc.)

Version
Microsoft Windows [Version 10.0.22000.652]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
Docker Desktop 4.7.1 (77678)
Repro Steps

Open a terminal tab after starting or restarting WSL
Change current directory to a temporary directory
Run curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 until command hangs

NOTE: This isn't curl specific. I mention it because it is one of the simplest use-cases I could think of that can reproduce the issue. now see this hanging through any command that requires network connectivity (git and helm just to name a few).
NOTE: Sometimes the curl command (or another network call) does succeed after enough cancellations and retries.
Expected Behavior
Network calls should eventually complete (either successfully or unsuccessfully) not hang forever.
Actual Behavior
Network calls hang forever.
Diagnostic Logs
strace of curl

I'll look into what logs I can gather but I want to be careful what I share since I'm troubleshooting this issue on a work computer.

Also just as a note, this issue is very recent. Last week I had no issues doing my duties in this environment making tons of network calls. It wasn't until this morning that I noticed this trouble and it is so common that it's impossible to get any work done.
I did check the Windows Store noticed that Windows Subsystem for Linux Preview was last modified 4/25/2022 so it doesn't seem like a recent update is obviously responsible for the change.

I went ahead and pinned strace logs to the issue as suggested in the CONTRIBUTING.md.

@oaklandcorp-jkaiser are you sure it's not your local network causing the issue? I run your command several times and never fails or hangs:
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ curl -fsSL -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
tux@RIPPER:~/foo$ ls
get_helm1651513193.sh  get_helm1651513195.sh  get_helm1651513197.sh  get_helm1651513199.sh  get_helm1651513201.sh
get_helm1651513194.sh  get_helm1651513196.sh  get_helm1651513198.sh  get_helm1651513200.sh

WSL2 on Windows 10 and  Ubuntu 22.04.

@elsaco: It certainly could be something specific to the network I'm working from. I'll have to try again when I'm off the office network to see if it changes anything.

So the strongest lead I have at the moment is that IPv6 may be a part of the problem. I noticed after retrying that curl snippet a handful of times with an added -v option that each of the times the command successfully runs an IPv4 address is used otherwise an IPv6 address.
$ curl -fsSLv -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
*   Trying <IP_ADDRESS>:443...
* TCP_NODELAY set
* Connected to raw.githubusercontent.com (<IP_ADDRESS>) port 443 (#0)

vs.
$ curl -fsSLv -o get_helm$(date +%s).sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
*   Trying <IP_ADDRESS>:443...
* TCP_NODELAY set
*   Trying 2606:50c0:8003::154:443...
* TCP_NODELAY set
* Immediate connect fail for 2606:50c0:8003::154: Network is unreachable
*   Trying 2606:50c0:8000::154:443...

I went ahead and installed Ubuntu 22.04 LTS from the Windows store to see if maybe it was something specific to Ubuntu 20.04 LTS and unfortunately the same issue still occurs.

IPv6 doesn't work inside WSL, yet. However, Ubuntu images have IPv6 enabled. Quick check with sysctl shows:
net.ipv6.conf.all.autoconf = 1
net.ipv6.conf.default.accept_ra = 1
net.ipv6.conf.all.disable_ipv6 = 0

Try disabling IPv6 and see how curl behaves. Use sysctl -w net.ipv6.conf.all.autoconf=0, etc.
The new reading should be:
net.ipv6.conf.all.autoconf = 0
net.ipv6.conf.default.accept_ra = 0
net.ipv6.conf.all.disable_ipv6 = 1

Same problem here, network hangs inside wsl, after running sysctl -w net.ipv6.conf.all.autoconf=0 the network works again.

Thanks @tiagolpadua , solved for me as well 👍

@tiagolpadua I should restart or reload anything after using this command?

I can confirm the issue with two (mine and my colleague's ) fresh installs of Windows 11 and latest WSL with all network-related consequential commands (multiple git pull for short period of time in our case). And I can also confirm that it is a recent thing, as previously all worked smoothly. I can't add any other useful information, but sysctl -w net.ipv6.conf.all.autoconf=0 didn't help.

This really shouldn't be closed just because the OP decided to give up on the issue. It's still an issue. @OneBlue  can you re-open this?

IPv6 doesn't work inside WSL, yet. However, Ubuntu images have IPv6 enabled. Quick check with sysctl shows:
net.ipv6.conf.all.autoconf = 1
net.ipv6.conf.default.accept_ra = 1
net.ipv6.conf.all.disable_ipv6 = 0

Try disabling IPv6 and see how curl behaves. Use sysctl -w net.ipv6.conf.all.autoconf=0, etc.
The new reading should be:
net.ipv6.conf.all.autoconf = 0
net.ipv6.conf.default.accept_ra = 0
net.ipv6.conf.all.disable_ipv6 = 1

It still hangs on Ubuntu 22.04

Hi! I ran into this same issue earlier today and this is what fixed it for me

Neither the ipv6 fix nor the MTU value changes fixed the issue for me, I modified the /etc/resolv.conf file for Google's public DNS's as follows to solve the issue:
# This file was automatically generated by WSL. To stop automatic generation of this file, add the following entry to /etc/wsl.conf:
[network]
generateResolvConf = true
nameserver <IP_ADDRESS>

suggestion is from:
https://github.com/microsoft/WSL/issues/8119

IPv6 doesn't work inside WSL, yet. However, Ubuntu images have IPv6 enabled. Quick check with sysctl shows:
net.ipv6.conf.all.autoconf = 1
net.ipv6.conf.default.accept_ra = 1
net.ipv6.conf.all.disable_ipv6 = 0

Try disabling IPv6 and see how curl behaves. Use sysctl -w net.ipv6.conf.all.autoconf=0, etc.
The new reading should be:
net.ipv6.conf.all.autoconf = 0
net.ipv6.conf.default.accept_ra = 0
net.ipv6.conf.all.disable_ipv6 = 1

This totally fixed my issue. Thank you! It was driving me nuts.

@t4261  - thanks, that also resolved my symptoms!


Throw error when seconds are not specified for DateTime field in filter and post-filter values

Summary
closes #2580

How did you test this change?

[x] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

Selecting zero seconds from editor
https://github.com/finos/legend-studio/assets/87973126/9b0331d8-a1b6-4be0-9484-2236c178b401
Throwing error when seconds field is not provided
https://github.com/finos/legend-studio/assets/87973126/e435486d-ebeb-428b-adae-31aad756c4e6

I know the initial task was to throw an error but I am a little concerned here of impact here.
Could we separate this into 2 PRs. I am good with the changes in custom picker where we add the seconds when its datetime. I think thats the main change here thats needed alongside the relevant tests.
The other PR could be on throwing an error and showing unsupported mode. We should think if we want to do this.
Does the engine compiler throw an error currently if the user does this? Main Concern is if user has a query with this filter already, what should our approach be in this case? maybe add the seconds ?
We can discuss that, but to prevent hold up on the main task lets go with the other changes.


4 header footer

init.js creates headers (with some copy-paste) and footers that can be refined in one place. All pages can add actions to the bottom bar unique to the interaction (see index.html for example). On phones, the header scrolls off and only the bottom nav is there. In tablets and desktop the header stays fixed (with the drawer) and the fat footer replaces the action bar).

closes #4


An external img should not generate an import statement and use a static string when rendering

Version
3.2.33
Reproduction link
github.com
Steps to reproduce
Here's the code to reproduce the issue:
git clone git@github.com:bseib/vue-vite-external-static-image.git
cd vue-vite-external-static-image
npm install && npm run build

Or here's the same code running on stackblitz that can demonstrate the issue:
https://stackblitz.com/edit/vitejs-vite-t5npgf?file=dist%2Fassets%2Fentry-point-1.ede3131f.js&terminal=dev
You can see the erroneous output in the entry-point-1.ede3131f.js file on StackBlitz, but might be easier to follow along and see the screenshot in the github issue linked above.
What is expected?
After running npm run build, the generated dist/assets/entry-point-1.e49989cd.js file should not attempt to import anything for the <img> src. The render code should just keep the original string src=/img/aaaSMPTE-color-bars.png as-is, untouched.
I had expected the build to honor the rollup config, and completely ignore that particular img tag since /img/aaaSMPTE-color-bars.png is listed as external.
What is actually happening?
The build does not ignore that  tag, and generates an import statement that expects that image file to be in a relative location.
Generated file dist/assets/entry-point-1.e49989cd.js:
[blahblahblah]import n from"../../img/aaaSMPTE-color-bars.png";[blahblahblah]()=>p("img",{alt:"smpte bars",class:"logo",src:n},null,-1)

That import breaks at runtime on the client side, loading as a 404. That import should not exist in the build output, and the rendering of the <img> tag should be a static value rather than the imported variable (n). Since n fails to load, so does the image.
The backend server will serve /img/aaaSMPTE-color-bars.png just fine, if the <img> tag were left untouched.

There are more details in the github repo link, and a broken.html file you can use to actually see this fail. I tried to document the things I tried in the README of that repo. I couldn't get StackBlitz to serve up the broken.html failure, since it is a product of build-time, whereas stackblitz is really good at dev-time demonstrations. But you can follow the instructions in the github example to see it break.
BTW, I'm super sorry if this is a vite issue and I've posted to the wrong place. I pinned down all the details, but I'm not 100% certain this is the correct repo to post this issue....  ¯\_(ツ)_/¯

This is pretty certainly a problem with vite, maybe more specifically its vue plugin (also maintained in the vite repo).
Noteworthy to mention when moving you issue there:

the issue, in its reported form, happens because you added the path to rollupOptions.external
however when you don't do that, and the file is not present in /public under that path, you get an error reported that rollup can't resolve an import for that path - and get a recommendation to add it to rollupOptions.external, which is likely how you end up where you did.

But our template compiler leaves absolute paths untouched:

So my non-expert opinion is that Vite somehow stille extracts this path, makes it part of its module graph and tries to resolve its existance (likely because it also does that during dev to be able to serve it?
TBH I could be really wrong here but at the end of the day, in one way or another this is to be solved in vite / @vitejs/plugin-vue IMHO

Here's the culprit:
https://github.com/vitejs/vite/blob/c7eeb8d69253d16dc9413d59cc13e45977a8c105/packages/plugin-vue/src/template.ts#L126-L132
this option is forced to be set and is responsible for absolute paths to be part of the asset pipeline.
Please move this to the vite repo, thanks!


Epic - Onboarding materials

Videos

[x] Setup dev environment
[ ] Identity bootstrap
[ ] Zoom: launchpad light
[ ] Zoom: launchpad standard
[ ] Zoom: networking
[ ] Zoom: foundations
[ ] Development 101

Guidance

[ ] Setup dev environment (local and VScode)
[ ] Identity bootstrap
[ ] Deployment guide
[ ] Customisation guide
[ ] Development guide

Closing as will add wiki and CAF doc update


Update scalafmt-core to 3.5.9

Updates org.scalameta:scalafmt-core from 3.5.8 to 3.5.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.5.8).
You might want to review and update them manually.
.github/workflows/format.yml

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Closed in favour of https://github.com/aiven/guardian-for-apache-kafka/pull/270


Colouring compatible with Dark theme

Default colours are sub-optimal when using VSCode dark theme.
Can we have a setting that mass change all colours which show best on Dark settings?

Hi @ulisse31,

Default colours are sub-optimal when using VSCode dark theme.

There are separate color settings in the extension for light and dark themes.  For the default colors for dark themes, I used Dark+ (the VS Code default dark theme) to find colors I thought worked.  But to be honest I do not use a dark theme so I don't have the best perspective.
If you have recommendations for better default colors that would work across a wide variety of dark color schemes, I'd be happy to consider updating the default colors.

Can we have a setting that mass change all colours which show best on Dark settings?

There are already separate color settings for light and dark themes.  Can you elaborate on your request?
Thanks!
-Chris

hi @baincd
thanks for the reply.
I think I understand now: I'm using the Dark "high contrast" VS theme, and with this configuration the color coding either doesn't work or the colours are effectively almost invisible.
I'm overwriting the dark settings with the "light" ones and it's definitely a better experience.
I will experiment a little bit and let you know.
Thank you for your nice plugin!
Andrea


3d acceleration on windows

Any plans to add 3d acceleration on windows guest?

UTM provides 3D graphics support via the virgl3d graphics card. (#161)
The missing piece to make 3D acceleration work in Windows is a suitable Windows driver  for this graphics card that supports modern 3D features like DirectX and Vulcan. This work is beyond the scope of the UTM project.

Then how did Parallels do it?

@aisobe By investing lots of money into creating their own proprietary graphics layer (OpenGl3 & DirectX11 to Metal).
I decided to look for the open source software Parallels use and found this list. It doesn’t mention any DirectX related OSS so I assume it’s proprietary.

https://github.com/virtio-win/kvm-guest-drivers-windows/pull/943

Exciting stuff -- looks like we might not be so far away from this goal!


Feature request, Parking timer on traccar-web

This is my very first feature request on Github, sorry if it is on wrong place?
Is it possible to show the Parking Time directly on the detailscreen?
There is a parameter "motion" behind the green button, maybe this can be used to calculate the parking minutes/hours?
e.g. No Motion since: "xx:xx:xx" minutes
My intention for this request:
I´, delivering on a route from 9 am to 3 pm with round about 10 Stops a day, every 30-45 minutes to my customers with exactly defind appointments on time, sometimes the appointment to be at the customer is not possible because of traffic or other circumstances so the next customer knows we are little late.

Seems like you created a pull request instead. Create a feature request here:
https://github.com/traccar/traccar-web/issues/new/choose


Organic pops cannot survive on Machine worlds

Even when selected as their natural Homeworld, their preference doesn't seem to work, Is this intended or a bug?

Not intended. Probably another hidden, undocumented habitability modifier (2.0 introduced many). I'll correct the trait to counter it.

Problem found. Proper name is pc_ai not pc_machine. pc_machine is hardcoded at zero habitability for some special event chain

Fixed, and added some fancy descriptions as well


cannot import name 'register_vector' from 'psycopg'

I am getting this for psycopg3.
cannot import name 'register_vector' from 'psycopg'
Mac OS
psycopg 3.2.2
vector extensions is enabled and works from pgAdmin in Postgres
This is the code. I haven't gotten anything to work so far. Tried all options and read all articles.
import psycopg
import numpy as np
from psycopg import register_vector
with psycopg.connect("postgresql://xxx:xxx$@localhost:5432/xxx") as conn:
    conn.execute('CREATE EXTENSION IF NOT EXISTS vector')

    register_vector(conn)
    conn.execute('CREATE TABLE items (id bigserial PRIMARY KEY, embedding vector(3))')
    # https://github.com/pgvector/pgvector-python/issues/4 <-- tried everything from here.

    embedding = np.array([1, 2, 3])
    conn.execute('INSERT INTO items (embedding) VALUES (%s)', (embedding,))
    conn.execute('SELECT * FROM items ORDER BY embedding <-> %s LIMIT 5', (embedding,)).fetchall()

Hi @dynamicdeploy, the correct import is:
from pgvector.psycopg import register_vector

Docs

Then the compiler complains "Import "pgvector.psycopg" could not be resolved"

It looks like that's a Pylance error (not specific to pgvector). Please use other resources for help.


koa-shopify-webhooks : Unable to registerWebhook without write permission for that scope.

Overview
I have a Shopify app that needs to subscribe to certain Webhooks for Shopify clients that install our app. I will focus on the orders webhook, but it applies to all of them.
My app needs to receive the Orders/create webhook, which we then inspect and sometimes will send api requests to our main webapp. We do not need to modify any Order data.
I would think that  the following would be fine:
scopes: ['read_customers', 'read_orders', 'read_checkouts']
however, this causes registerWebhook to fail.
If, however I have my scopes set as:
scopes: ['read_customers', 'read_orders', 'read_checkouts', 'write_customers', 'write_orders', 'write_checkouts']
everything works perfectly.
I shouldn't need to have write access to anything in order to just consume these Webhooks, should I? Thanks for your help!
Consuming repo
@shopify/koa-shopify-webhooks
Checklist

[x] Please delete the labels section before submitting your issue
[x] I have described this issue in a way that is actionable (if possible)

I was able to get these Webhooks to register with read-only scopes by POSTing to /admin/webhooks.json rather than using registerWebhook from koa-shopify-webhooks, so it seems like a bug (or at least undocumented restriction) in this package.


Add a check for nullable InstanceId

Hello Rynaret,
Did you mean to close this PR?  We will pull in your PR for our 2.2 release if you sign the CLA.
Thank you for your contribution.

Thanks!


Bug: Monster damage rolls are doubled

Using the Monster importer, does correctly import the right formula for monsters, but it's displayed as half as many dice as the formula represents.

Seems like two different issues.

NPC attacks are calculating critical hit damage on every roll.
The monster importer dmg formula is wrong now


Our p-values not passing validation

A bit of sample JSON is not getting validated and the error messages I am getting are inconsistent.
This shows up as problematic:
echo '{"value":1.42E-34,"method":{"description":"DESeq2 version: 1.10.1"}, "type":"pvalue"}' \
  | ./json_schema_validator.pl \
--schema https://raw.githubusercontent.com/opentargets/json_schema/master/src/evidence/association_score/pvalue.json
#Bad record: {"value":1.42E-34,"method":{"description":"DESeq2 version: 1.10.1"}, "type":"pvalue"}	#/: allOf failed: allOf failed: Properties not allowed: description.

The evidence/association_score/pvalue.json references evidence/association_score/method.json but when I try validate just that bit of the JSON it goes through:
echo '{"description":"DESeq2 version: 1.10.1"}'  \
   | ./json_schema_validator.pl \
--schema https://raw.githubusercontent.com/opentargets/json_schema/master/src/evidence/association_score/method.json
# {"description":"DESeq2 version: 1.10.1"}

I see pvalues without method description are acceptable, we'll provide them for the time being:
echo '{"value":1.42E-34, "type":"pvalue"}' \
   | ./json_schema_validator.pl \
--schema https://raw.githubusercontent.com/opentargets/json_schema/master/src/evidence/association_score/pvalue.json
# {"value":1.42e-34,"type":"pvalue"}

This might actually be another manifestation of issues with<EMAIL_ADDRESS>being broken because with 0.95 I didn't get these. Sorry for the noise!


width of carousel in safari and chrome bug

For some reason safari and chrome are dyanmically changing the width of the ul containing the slideshow to be a random 633px..way smaller than it should be...and so its breaking it on the page and causing my divs to float down the page.
Here is the link to the page: http://nicolefugerewebdesign.com/prentiss-architects/projects-new-houses.html
I used the exact same code to make the A-Z page, and that one is working just fine in all browsers..http://nicolefugerewebdesign.com/prentiss-architects/projects-a-to-z.html
They want to be able to add any size image in so i cant specifically give the width of each div on the NEW HOUSES page. not sure if that is causing an error.
Whats weird is that if I am on the A-Z page, and click NEW HOUSES, it works fine. but breaks when i refresh the page.
any help is much appreciated!

I think i found a fix! on this site: http://geeksandgod.com/forums/web-development/html-/-css-/-javascript-/-dom/jcarousel
I wrapped my init carousel calls  with window.onload = function(){/some init here/}; and it seems to be working!


fix: missing link in README

:tada: This PR is included in version 1.0.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Please add support for new tsconfig "extends" property

Please can you add support for the new tsconfig "extends" property:

A tsconfig.json file can inherit configurations from another file using the extends property.

https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
Expected behaviour:
You should be able to extend one tsconfig file with another by adding the extends property to the child file
Actual behaviour:
The extends property is not currently supported.
configs/base.json
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true
  }
}

tsconfig.json
{
  "extends": "./configs/base",
  "files": [
    "main.ts",
    "supplemental.ts"
  ]
}

I've attempted implementing this myself but am having a few issues.
I added the following at line 111 of project.ts.
if (this.config.extends) content.extends = this.config.extends;
If you log the object returned by this.typescript.parseJsonConfigFileContent it has the combined settings from the supplied tsconfig file and the file it extends. So this appears to be working correctly.
But...
...the problem i've come across, Is that the creation of the compiler options occurs before the child and parent tsconfig files are combined. So the settings object that's created and passed to getCompilerOptions on line 181 of main.ts, does not include the parent tsconfig files compilerOptions.

See #459


feat(eslint): allow specifying eslint config file

Add configuration option to pass through to ESLint that will specify a custom path for ESLint to find the configuration file to be used.
This is useful in our situation (legacy project with multiple builds + eslints in the mix) when the root eslintrc file is incorrect for the code that Vite is building. New code is separated in a pseudo monorepo structure so we need to be able to point at a different base eslintrc config file.

Codecov Report

Merging #71 (19adb83) into main (df4917e) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   34.52%   34.11%   -0.41%
==========================================
  Files          13       13
  Lines         588      595       +7
  Branches      114      118       +4
==========================================
  Hits          203      203
- Misses        384      391       +7
  Partials        1        1

Impacted Files
Coverage Δ

...es/vite-plugin-checker/src/checkers/eslint/main.ts
0.00% <0.00%> (ø)

packages/vite-plugin-checker/src/types.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4917e...19adb83. Read the comment docs.

Sorry to bug ya,  don't suppose you've got a moment to check this?

@elwynelwyn Sorry, I'm too busy to do OSS work recently. I might review this at 10.1 ~ 10.7 or got a time before it. 🥺

@elwynelwyn Thanks for PR! Sorry to be so late in responding. I'll add some test cases and release a new version. Thanks!

May I ask for a release in the near future? I'd like to use this new feature - thanks!


Fix build on Linux by removing nullptr

No idea why this doesn't build on certain Linux installs, but there's no benefit to using nullptr over NULL here

:moneybag:


How do I properly configure ECS credentials using aws_config?

Sorry if this is not the right place to ask. I was lead here from https://docs.rs/aws-config/latest/aws_config/ecs/index.html.
I'm trying to configure ECS credentials with IAM role I have set up on a task (which I will then use to create a DynamoDB client).
Heres my code:
#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let config;
    let ddb;
    match env::var("ECS") {
        Ok(_) => {
            // Get credentials and build config
            let credentials =
                aws_config::ecs::EcsCredentialsProvider::builder()
                    .build()
                    .credentials()
                    .await
                    .unwrap();
            let config = Config::builder()
                .credentials_provider(credentials)
                .region(Region::new("eu-west-2"))
                .build();
            ddb = DDBClient::from_conf(config);
        }
        Err(_) => {
            // Load from environment variables
            config = aws_config::load_from_env().await;
            ddb = DDBClient::new(&config);
        }
    }
    // ...
}

When I deploy this to ECS I get an error on the credentials unwrap:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: CredentialsNotLoaded { context: "ECS provider not configured" }', src/main.rs:19:22

I've also tried using it with ProviderConfig and passing that into the credential provider builder through .configure(&p_config) which results in the same error.
I'm guessing I'm missing something here. If anyone could shoot me an example of how to configure it properly I would be grateful.

The error you're saying is indicating there are no ECS credentials, and it is used to notify the default credential provider chain to move on to the next provider.
However, the default credentials provider chain already includes the EcsCredentialsProvider, so you shouldn't need this switching logic to begin with.
Just as a note: you generally don't want to pull the credentials directly from the provider and pass them in, since that will prevent the client from making any successful calls after a certain amount of time (when the credentials expire). Generally, you want to give the whole provider to the client configuration so that it can automatically refresh.


App Standards Problem Breakdown

User Need
Pre-work relating to EPIC on Ops Eng App Standards
Value
To understand what standards we need we should understand what we already have and when the gaps are that we would seek to address i.e. what problem are we trying to solve.
Functional Requirements:

Team session to further understand the problem space.

Acceptance Criteria:

We are able to break down the EPIC.

Notes:
<!-- Here's a brief explanation of each field:

🆙 Update
Worked with @imkatiewatson and outlined some basic areas of the session with ideas of areas to cover and activities to do as a team
👀 Work Left

Solidify the parts of the session to understand what exactly we want to cover
Set up a session to discuss
Have a session
Use the information to breakdown the Epic

🆙 Update
Session completed with the team and agreed to explore standardising our current practices for web application development
👀 Work left

Create another session to ideate with the team on how we can start to standardise our current practices (this will enable us to break down the epic)

🆙 Update
Second session is currently being created - to help the team decide how and what we want/should standardise
👀 Work left

Finish creating the second session
Run the session with the team

📝 Notes

May wait for more people to be around before running the session (since it's the holiday period at the moment)

Agreed that https://github.com/ministryofjustice/operations-engineering/issues/3864 should be broken down incrementally and over time, allowing standards to be integrated when people have the time or find value in it.
This will be done using the operations-engineering-example as easy way to spin up a new microservice with agreed best practices implemented


Split static doc gen into separate package

Done in https://github.com/seagreen/unison-code-explorer/commit/24280c27914075fa1839c96160c3f14065a13b2d


"Unrecognized car" on previously working 2019 Honda Odyssey EX-L

Describe the bug
I replaced my existing working Comma 2 with a new Comma 3x and am now getting "Unrecognized car".
Which car does this affect?
2019 Honda Odyssey EX-L
Provide a route where the issue occurs
edf22f348d55c611/2024-04-09--14-02-26
openpilot version
0.9.6
Additional info
comma 3X

dongle_id
serial
device_type
alias
sim_id
prime
prime_type
last_ping

edf22f348d55c611
f1916592
threex
None
89852351123040019815
False
0
2024-04-09 14:03:52
uploads accepted

comma 2

dongle_id
serial
device_type
alias
sim_id
prime
prime_type
last_ping

e026c3b5d55633ad
b02cb0c4
two
None
8901260195759121761
False
0
2024-04-06 17:48:33
uploads accepted

We enabled fingerprinting without the comma power on master branch, which will come to release soon. Please check out master or nightly to use openpilot in the mean time?
https://installer.comma.ai/commaai/nightly

Wow, fast response. Thanks! I actually just came back here to say this was user error. I just forgot to reconnect my cat5 cable. :sweat_smile:


Product Analysis not working

Giving same results and analyzing same reviews text everytime

Done the required Changes and updated the functionality


Fix failing commandline tests

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge

OK, I've already triggered a build for you.


new(libscap): add scap_event_encode_params()

Signed-off-by: Luca Guerra<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
This PR adds a function to libscap to generate a scap event given the arguments. The event will be generated from userspace but doesn't come from any ringbuffer. This is necessary to allow syscall generators that do not use a ringbuffer such as the upcoming gvisor support.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

new(libscap): add event_encode

Hi @LucaGuerra. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I thought a bit about this one and I think we probably need an n parameter to specify the number of arguments. There's probably no portable way of counting how many arguments exist, and every time we update an event by adding a new argument, all the scap_event_encode() calls that use the old version of that event would go straight to buffer overflow land.

I have updated the PR by:

Changing the name to scap_event_encode_params() because that's what it does;
Adding the n parameter for the number of events.

/ok-to-test
Thanks for this great PR, it seems really useful!

@LucaGuerra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-minimal
1dd2c7853681761dfb2b49bac49c5442aaca0ba7
link
true
/test build-libs-minimal

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-minimal
bd739deb9b29d5f9cc1829c800b61141506d3fa0
link
true
/test build-libs-minimal

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LGTM label has been added.  Git tree hash: fb0992729e3c6c90fc3072ca1c65a2f048d8d682

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@LucaGuerra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-arm

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-arm

build-libs
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-arm

build-libs
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs

build-libs-with-chisels
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-with-chisels

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-arm

build-libs
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs

build-libs-with-chisels
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-with-chisels

build-libs-bundled-deps
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-bundled-deps

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-arm

build-libs
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs

build-libs-with-chisels
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-with-chisels

build-libs-bundled-deps
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-bundled-deps

build-libs-minimal
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-minimal

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs

build-libs-with-chisels
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-with-chisels

build-libs-bundled-deps
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-bundled-deps

build-libs-minimal
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-minimal

build-libs-arm
c36dbbc9a5fb03f68a7f7bed5c93e2f3d140669e
link
true
/test build-libs-arm

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LucaGuerra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-with-chisels
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-with-chisels

build-libs-bundled-deps
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-bundled-deps

build-libs-minimal
8db562f38830937aeb3205d14741611408d63993
link
true
/test build-libs-minimal

build-libs-arm
c36dbbc9a5fb03f68a7f7bed5c93e2f3d140669e
link
true
/test build-libs-arm

build-libs
c36dbbc9a5fb03f68a7f7bed5c93e2f3d140669e
link
true
/test build-libs

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I have updated this PR by:

slightly changing the interface by having the caller allocate its buffers and the encoding function return "too small" if the buffer is not large enough
adding an appropriate _v (va_list) version of the function

LGTM label has been added.  Git tree hash: 00510d764fc1e2c62e39084730ca1d3820f6774b

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


UITabBarController

Not able to add the float view controller on TabBarController
Expected behaviour
This should work on tab bar controller
Actual behaviour:
when add the container to the tab bar view controller getting this error:-
eg: playerFloatingContainer.addPanel(toParent: self, animated: true)
"UITabBarController displays child view controllers with a radio-style selection interface"
Steps to reproduce
Code example that reproduces the issue
How do you display panel(s)?

Add as child view controllers
Present modally

How many panels do you displays?

1
2+

Environment
Library version
Installation method

CocoaPods
Carthage
Swift Package Manager

iOS version(s)
Xcode version

Unfortunately, it's not possible because UITabBarController recognizes any child view controller as a tab bar content. Alternatively you can add a pane each child view controller of a UITabBarController.
If you display a panel over UITabBarController, you have 2 options.

Present a floating panel as a modality.
Add a pane to the window. See also Samples app > Show Panel over Window


How to import the tensorflow source code with clion's bazel plugin

How to read the tensorflow source code with clion's bazel plugin, how to import and build, I can  read an navigate inside the code base.This problem has been bothering me for a week. Please let me know, failed many times .Thank your very much.

Are you following the instructions from here?
https://ij.bazel.build/docs/import-project.html
Please be clear about which part of the process failed.

Follow the method taught by jin.   import bazel project -->choose "Create from scratch" -->  edit view file
directories:
Add the directories you want added as source here
By default, we've added your entire workspace ('.')
Automatically includes all relevant targets under the 'directories' above
derive_targets_from_directories: false
targets:
If source code isn't resolving, add additional targets that compile it here
//tensorflow/tools/pip_package:build_pip_package
build_flags:
-c opt
--config=cuda
Finally compelete successfully.

Why is the code on the left marked as unsynced ?
when I read the source code, can the code be related to each other, and use CTRL+ to enter the code defined location ?I can't read an navigate inside the code base..

@vladmos @vsiva @mikelikespie

@ccnankai I have meet the same issue, Do you fixed it?

Solved, just import directly, know there is a tutorial

Solved, just import directly,

What? Could you please tell me how to do this...Really annoying.

Just select the directory of tensorflow, and import from scratch...


check_links.js does not find bad hyperlinks to bookmarks

Where to find the issue
cypress/integration/check_links.js
Describe the issue
check_links.js does not find bad links to bookmarks.
Steps to reproduce

Introduce a bookmark hyperlink error into one of the .json source files
For instance, in faq.json change the first occurrence of #international_phone_numbers to #international_phone_number (remove last letter)
run npm run test:open
select check_links.js to run in cypress console
Note that the error is not found. Instead the test shows a success

Link: http://localhost:8000/en/faq/#international_phone_number: expected 200 to equal 200
The bad link
click here to see the phone numbers shows as success.
In the next paragraph the link is correct
click here to see the phone numbers
Both the bad link and the good link show as success.

Suggested change
Since there is a lot of use of hyperlinks to bookmarks (aka anchors) in faq.json and faq_de.json, implement a link check for these hyperlinks either in check_links.js or in a separate cypress JavaScript script.
This is an enhancement request.

Internal Tracking ID: EXPOSUREAPP-9752

I thought it might be possible to use npm run-script checklinks  from the cwa-documentation repository  that makes use of markdown-link-check on *.md files which are used in the blog and science sources.
It seems though that markdown-link-check will not find hyperlinks to non-existent bookmarks either, such as in [my link](#bad_bookmark). It just marks them as passed. 🙁

@MikeMcC399 Sure, open an issue and we try to look into that ASAP. Thanks!


fsi script start up is slow (5x slower than Microsoft fsi)

Even for the simplest script, it is very slow to start. Here're the info and measurements. I'm using Windows 10. I compare it with the "Microsoft" version, and it's 5x slower. Why?
PS C:\Users\brucew\work> type .\hi.fsx
printfn "%s" "hello world!"

# ------- The "free" fsi ------------
PS C:\Users\brucew\work> C:\fsi\fsi.exe
F# Interactive for F# 4.1
Freely distributed under the Apache 2.0 Open Source License

# ------- time it -------------
PS C:\Users\brucew\work> (Measure-Command { (0..10) | %{ C:\fsi\fsi.exe .\hi.fsx } }).ToString()
00:00:24.0280356

# ------- Microsoft fsi -------------
PS C:\Users\brucew\work> & 'C:\Program Files (x86)\Microsoft SDKs\F#\4.0\Framework\v4.0\Fsi.exe'
Microsoft (R) F# Interactive version 14.0.23413.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

# ------- time it -------------
PS C:\Users\brucew\work> (Measure-Command { (0..10) | %{ & 'C:\Program Files (x86)\Microsoft SDKs\F#\4.0\Framework\v4.0\Fsi.exe' .\hi.fsx } }).ToString()
00:00:05.1855948

Thanks @dsyme , I understand that ngen is to generate native image cache but I still have two questions:

Could it be something done at the package publication stage, or as part of the package installation? Using ngen requires Visual Studio installation so having customers to do this won't scale.
I've written quite some .NET applications and I never ngen any of them and still they are started fast. What's so special about fsi.exe that it has such a significant start up delay before ngen?

@kflu The F# compiler (FSharp.Compiler.dll) is a significant chunk of code that's got a pretty long hot path.  The startup time per invocation is ~2.2seconds by the look of it.
NGEN can't be used at package publication time.  It is part of the .NET Framework though, so you may be able to arrange to have this done at install:

>dir \Windows\Microsoft.NET\Framework\v4.0.30319\ngen.exe

 Directory of C:\Windows\Microsoft.NET\Framework\v4.0.30319

08/12/2015  15:24           140,944 ngen.exe
               1 File(s)        140,944 bytes
               0 Dir(s)  11,066,617,856 bytes free

@dsyme ah didn't know it's part of the framework! Just tried ngen install it and it's now significantly faster.  It would be nice if this can be part of the package installation when this type of optimization is possible. I don't think regular user would know to do this kind of thing. If you agree then I can create a tracking issue for that improvement in the nuget package installation.


Add dafny; fixup Boogie

Motivation for the change
Introduce dafny, which uses Boogie.
And fix Boogie, because the last edit (changing the baseName) right before merge (#22400) broke it.
Also propote boogie and dafny as toplevel packages, because they both have toplevel standalone executables corresponding to their names.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

/cc @obadz ('coz it's dotnet), @taktoa ('coz I changed Boogie), @pSub ('coz he approved the changes to Boogie) and @rycee ('coz he merged Boogie)

Fixed according to reviews, and removed the usage of 'lib' that made travis fail.


 At least two sentinels should be defined in Redis configuration. Set checkSentinelsList = false to avoid this check.

Any idea why this could happen
spring:
  redis:
    ssl: false
    lettuce:
      pool:
        maxActive: 100
        maxIdle: 10
        maxWait: 30000
    timeout: 15000
    password: xxxx
    sentinel:
      master: local-master
      nodes: ip1:26379,ip1:26380,ip1:26381

note：redisson version 3.15.0

you need to set checkSentinelsList = false in Redisson configuration. You can define Redisson configuration as provided in the example on the link https://github.com/redisson/redisson/tree/master/redisson-spring-boot-starter#2-add-settings-into-applicationsettings-file


Update to transformers 4.35

The only dangerous thing in this release is that save_pretrained now saves safetensors format weights by default

[ ] Make decision on whether we keep saving .bin for now

Closing in favor of #804


Add linked service information in odo describe

/kind feature
What does this PR do / why we need it:

[x] Shows the linked components with variables / files when pushed
[x] Shows the linked components names when not pushed
[x] Shows the linked services with variables / files when pushed
[x] Shows the linked services names when not pushed

Unused code relative to "linked components" has been removed, because it was detecting the linked components using the old way (based on labels and annotations instead of ServiceBindingRequests):
componentName, containsComponentLabel := secret.Labels[componentlabels.ComponentLabel]
		if containsComponentLabel {
			if port, ok := secret.Annotations[kclient.ComponentPortAnnotationName]; ok {
				linkedComponents[componentName] = append(linkedComponents[componentName], port)
			}
		}

Issue #4871  tracks the update of this behaviour with the new way to create links (with ServiceBindings).
Which issue(s) this PR fixes:
Fixes #3734
PR acceptance criteria:

[x] Unit test

[x] Integration test

[x] Documentation

[x] Update changelog

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:

/test psi-unit-test-windows
timeout

/test v4.7-integration-e2e

@feloy I am looking into testing the functional part of this PR.

/test psi-unit-test-windows

I checked the functional part, it's beautiful! Everything works.
/approve

I noticed that odo describe shows the link even if the link has not been pushed, but it stills shows the link after unlinking, but not pushing that change.

Create a component and push it.
Create a service/component and push it.
Link it to the service and push it.
Unlink it.
odo describe - the unlinked links are still visible in the output.

This is the expected output, right?

@feloy I have disabled Sonar Cloud job for now. You can refresh it by force pushing to this branch, that should remove this job.


chore(protocol): remove prettier-plugin-solidity in favor of forge fmt

@dantaik we do not use prettier anymore to format solidity files. Instead, we are using forge fmt.
forge fmt is already configured to run on git hook based on the config here: https://github.com/taikoxyz/taiko-mono/blob/main/lefthook.yml#L10. lint:sol will call forge fmt: https://github.com/taikoxyz/taiko-mono/blob/main/packages/protocol/package.json#L11.
The configuration for VSCode is found here: https://github.com/taikoxyz/taiko-mono/blob/main/.vscode/settings.json.
If for some reason formatting is not happening on your staged files locally, please do a pnpm lefthook install.
Question though: do we want print width set as 80 or 100 columns? I would suggest we keep 100 columns, and keep solhint.json configured to warn at a max-len above 120. If we move to 80 columns, we should configure solhint.json to warn at a max-len above 100.

@d1onys1us I really don't like the new styles, as an example above, the old formats looks much better by breaking lines.

@d1onys1us I really don't like the new styles, as examples above, the old format looks much better by breaking lines.
Let me know if you can config "forge fmt" to output similar format.

@dantaik please check e5125c3 to see what you think of it. the reason why the difference between prettier-plugin-solidity and forge fmt were so fundamentally difference was the print width. I updated the print width to be 80 columns wide.
however, i believe 80 column width might be slightly too aggressive. however, i understand many people enjoy a 80 column width for various reasons, we can definitely keep it at 80.

@d1onys1us I like the new tweak, I think I still prefer width to be 80 as the diff will be displayed better in GitHub split view.

Can we also remove ".prettierrc.json"?

May I also suggest adding the following:
multiline_func_header = 'all'
number_underscore = 'thousands'
wrap_comments = true


Add new ruleset files with common rules.

Now that we can use Rulesets and export them as files, we should define the required, export them, and upload it to the user guide so users can download them and import them into their projects.

Nice idea @AlejandroFernandezLuces .


[Bug]

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
The class of BooleanMath and BooleanNotEqualMatch，the first compare method.
It's almost always a mistake to compare two instances of java.lang.String or boxed types like java.lang.Integer using reference equality == or !=, because it is not comparing actual value but locations in memory.
What you expected to happen
use equals() not == or !=
How to reproduce
Update methods, using the equals api
Anything else
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Which OAL could lead to this way? I was thinking we are only use boolean match.

SWHHEART changed the title [Bug] Boolean match bug It's almost always a mistake to compare two instances of java.lang.String or boxed types like java.lang.Integer using reference equality == or !=, because it is not comparing actual value but locations in memory. 1 minute ago

Don't build a so long title, it is hard to read.

I scanned it with sonar, and then looked at the official explanation, looking at the source code did not find that this method is used.But this is really a bad code

If you want to submit a pull request to update/fix this, go ahead. To be honest, it is just a scanning thing, because no code would run into it.
So, are you going to submit a pull request?

I will study the source code first, if there is an impact I will submit pr

This is a nit, nothing specific, I will fix it.

ok


EDGCMNSPR-22 - Updating of headers processing

EDGCMNSPR-22 - Updating of headers processing
Purpose
For security an edge module should not pass any headers from the external client to the back-end module unless strictly needed.
Approach

Fixed headers processing logic
Updated unit test

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[x] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cannot load Release Pipelines

I have installed the Extenstion "Trigger Azure DevOps Pipeline"
I cearted a PAT and a Service Connection. The PAT has full access.
When i want to create the Pipeline, i'm able to choose the Project but not the Release.
If i want to trigger a Build Pipline, and i change the type to Build, i'm able to see all the builds in the Dropdown. But the releases aren't presented.
Does the release have a special form or what i need to do, that the releases are presented in the dropdown.
Release:

Build:

Please check with the edge developers tools if there is a wrong call.

Hi Maik the call is successful. But i receive the following response:
{
"result": [],
"statusCode": "notFound",
"errorMessage": "Failed to query service connection API: '......./_apis/release/definitions'. Status Code: 'NotFound', Response from server: 'Page not found'",
"activityId": "3ea20b58-c436-4991-9d72-dff7e0f83952"
}

@maikvandergaag do you have a solution for that? Thanks.

Sorry missed your message. No we need to investigate where this is going wrong. Could you share the complete url.

@maikvandergaag which url do you mean?

@maikvandergaag :
https://{org}.visualstudio.com/{guid}/_apis/serviceendpoint/endpointproxy?endpointId={guid}

was more curious which call was going wrong as you mentioned in the post: ......./_apis/release/definitions


.update() method not working

I init the swiper in a .js file and it is being displayed correctly on the screen.
When i try to grab it and reload it using the following code:
var swiper = parent.find(".slideshow")[0].swiper;

swiper.update(true);

I get the following error:
Uncaught TypeError: Cannot read property 'update' of undefined

Then you use old version of Swiper, or you are referring to wrong element in dom


Update core and blocks to SvelteKit v2

Overview
Excluding lockfile:
28 files changed, 163 insertions(+), 162 deletions(-)

I was working on updating SvelteKit in the downstream app, and immediately hit a couple problems from Prime. I decided to do the update here first to shake everything out.
SvelteKit v2 updates to Vite v5, which is much more strict about CJS vs ESM. We had two imports in Prime that pretended CJS deps were ESM, which Vite v5 refused to bundle:

PrismJS
Lodash

We can no longer implicitly destructure an object exported as a CJS default export:
import { highlightElement, plugins } from 'prismjs';

Instead, we must be explicit:
import Prism from 'prismjs'
const { highlightElement, plugins } = Prism

This is good, because it stops hiding imports where we thought we were getting tree-shaking but weren't. For Prism, I did the change above. For lodash, I swapped it out for lodash-es, which was on my todo list anyway.
Change log

Update all dependencies, excect:

Didn't touch legacy at all
Blocks

mapbox

Storybook

sveltekit (SB hasn't caught up to Vite v5 yet)

Swap lodash for lodash-es
Make minimal fixes to get builds / checks / dev environments working

Review requests
Before merging, I'll be pnpm link'ing these to app to make sure things keep functioning.

Try out the dev sites if you can
Review source code changes with paranoia

Why did tailwind reorder?

The new order is definitely correct, so I'm not sure why it was improperly ordered in the first place. Since the end result is correct I didn't really look that deeply into it

Synced with main, updated stragglers, and ran a test with pnpm link for my local copy of the app. Did not experience any issues in either Vue or Svelte, so going to merge this as soon as CI is green