[BUG] New Firmware v10 bulbs aren't being added to HomeBridge

Logs
homebridge.log
Describe the bug
I setup a couple of new light bulbs in magic home last night and they've not been added to homebridge after 3 reboots and 12+ hours now. Sometimes my devices take some time to show up, it's always been that way, but generally by now they'd have been added.
To Reproduce
Steps to reproduce the behavior:

Add devices to magic home
reboot homebridge
see that devices were not added

Expected behavior
Based on the configs, and documentation, new devices should be added on the first reboot of the server, or within the rescan period from your configs.
"This plugin automatically detects MagicHome bulbs and controllers just like the Magichome app, and it should do so when you first run Homebridge. No more setting individual IP addresses per device."
"Rescan the network for new devices every 30 seconds."
Additional context
These bulbs are new to me, I'd had different brands in the past, but they work as expected in the same way withing MagicHome. The only difference I noted is that they're running a V10 firmware where the previous ones were running v7.
Host Hardware

Hardware: Unraid Server
OS: Unraid
OS Version: 6.12.3
Docker: SiwatINC/homebridge_gui

Homebridge and MagicHome

Homebridge v1.6.1
Homebridge MagicHome Dynamic Platform version v1.9.9
Link to the MagicHome Device on the seller's website. - https://www.amazon.com/dp/B09FK4JRB6?ref=ppx_yo2ov_dt_b_product_details&th=1

Screenshots
https://cdn.discordapp.com/attachments/138409093131010048/1149695818312458301/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149695962688782377/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149711383852744734/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149711709951504464/image.png

Hey, thanks for reporting the bug and the very detailed report.
A couple questions:

Have you had older versioned bulbs work with this setup and the plugin (not the app) in the past?
Are the bulbs on the same subnet as the homebridge server? I notice you are using unraid and docker.

A few troubleshooting options:

If you are willing, could you setup the plugin on non VM environment? This will help us determine if it's a subnet issue.
The V-10 might have an updated UDP repose which I have resolved in the alpha version, could you please install alpha.3? This version is very new, missing some features, and has bugs but it may shed some light on the issue.

Let me know how the above suggestions work out. Thank you.

Have you had older versioned bulbs work with this setup and the plugin (not the app) in the past?

I have 4 other bulbs currently running using the plugin. I actually was replacing 3 that were starting to flicker with these new ones, so there were actually 7 setup and working prior to last night.

Are the bulbs on the same subnet as the homebridge server? I notice you are using unraid and docker.

Same subnet as the unraid server. The docker is setup in host mode, which lets the container use the servers IP/network, so it should be setup in the same subnet yes.

If you are willing, could you setup the plugin on non VM environment? This will help us determine if it's a subnet issue.

I'd need to look into the how on this, but I could probably attempt this and get back to you if this other stuff doesn't work, though I think that this shouldn't be a subnet issue since other lights in the same subnet are able to connect to the plugin fine.

The V-10 might have an updated UDP response which I have resolved in the alpha version, could you please install alpha.3? This version is very new, missing some features, and has bugs but it may shed some light on the issue.

I'd be willing to give this a shot. I know I was one of the ones who had issue last week when some alpha changes got pushed to prod, but should be able to roll them back like I did last week if needed. Though, I'm not entirely certain how to get to this version, would you be able to guide me on that? How do I switch from using homebridge-magichome-dynamic-platform to pull the alpha version?

That actually looks to have worked. With alpha last week I was crashing on startup, which doesn't appear to be happening now which is good. All 7 of my bulbs, including the 3 on v10 were discovered and are showing in accessories now.
homebridge.log
I am however seeing the issue that richie was seeing in #138 where if you use the dimmer it makes the bulbs unresponsive in home.

I was not observing that the bulbs become unresponsive but instead that they were being set as "off" if the plugin didn't receive a response fast enough. Is that what you were observing?
I have updated the alpha to alpha.4 which removes the somewhat overzealous setting bulbs to offline. Keep in mind that this version is still somewhat bug prone and possibly missing features. Let me know how it works for you however.

I think alpha.4 is mostly working. I've experienced some weird things since moving to it, but as you've said that's maybe to be expected.

After editing a device or two in home to change room location and name, it and other magichome devices will be come uneditable. Can't change name/room/groups restarting home bridge seems to resolve temporarily, long enough at least that it only took 3 reboots to get all 7 named and in the right location/group. On and off still work in this state as best I can tell.
Current status seems to be defaulting to off. As in the viewable status in home or homebridge will show off more often than not when the devices are actually on. This is present on both v7 and v10 firmware, with the exception of one of the v10s. Very strangely, that one device seems to display the correct info at all times so far.
Devices are showing as unreachable in the log on startup. Names seem to sometimes be the name I've given in homebridge, and sometimes be the default name. Not sure what's up with this. All devices seem to function within home for off and on, and from what I can tell, dimming also works.
Color changing seems to have similar issues to what was happening before, but slightly different. It'll stay off when I turn the device on, and when I turn it off it flashes on momentarily and then back off. This can be corrected by turning it on in the magic home app.

Overall it's loss of functionality and buggy like you've said, but working ok-ish at least for now. I know you mentioned that this release wont go to production for some time while you work towards feature parity and solving bug issues, but I'm curious if there's any chance of the changes you made to get v10 firmware working being made to the previous version. This is assuming 2.0.0 is a full rewrite of some kind seeing as you're needing to bring feature parity up to par. I can understand if that's not feasible, but figured it was worth asking. I'm also willing to help test to the best of my ability and to near the end of my wife's patience :)
Here are the logs for item number 3 if you wanted to see them.
homebridge.log

Thank you very much for the detailed response. The change to allow the new v10 bulbs is literally 1 line change.
The difficulty will be that I'm not entirely certain which version of the source code I used or if I even can find it. This is due to disorganization in the past where my release versions didn't necessary reflect changes in source.
I will resolve this one of two ways and attempt to do so this weekend.

Find the closest source of version 1.9.9, make the change, build, and release.

Edit the release 1.9.9 code directly and republish. Because I'm building from typescript I'm slightly concerned about this approach but it may be viable due to the change being so minor.

I'll update here once that change has been made. At which point you should restore from your 1.9.9 version and update to 1.9.10 (once released).
Thanks for the praise and look forward to getting this working for you soon. Oh and thank you for the continued logs.

I have made the relevant changes and published version 1.9.10 as latest.
If you are restoring from a Homebridge backup, please install version 1.9.10 or disable Homebridge Magichome before loading the backup. Otherwise upon restart version 2.0.0-alpha.4 will convert your Homebridge Magichome accessories.
If you are loading from a docker image backup then simply update to version 1.9.10 and restart.
Please let me know the results of this.

Gave 1.9.10 a try with my backed up files and I seem to be having the same original issue. I do find it curious that it only finds a single existing device though, as there are 3 others that show within homebridge as well. Here's an example of one of them not being shown in the log.

homebridge.log

I ran another test since I've got everything backed up as it is. I tried completely clearing out the plugin and reinstalling fresh to see if that would behave any differently. The same bulb was the only one to show back up, which honestly makes me think something else might be going on that's keeping me from getting the new bulbs in since I can't even get the other 3 that were working previously to register from scratch again. There was a new warning from the plugin this time, but I'm not sure if it's a big deal or not. I wasn't getting it before.
homebridge.log
I'm tempted to start completely from scratch and see if that changes anything for me, but I know it'll mean resetting up (naming and placing in rooms) all of my devices at least one more time, more like a couple. With 20+ devices in homebridge it'll take some time, but if you think that's where we're at let me know and I'll give that a go.

Please do not update from scratch if you had it working before. I personally know how long that takes and I don't believe that will solve anything for now.
When you say that it only finds a single device, do you mean that the other 20 devices do not load correctly? In your logs I only see 1 device being registered. Alternatively, do you mean that the 20 old devices are loading correctly and in addition 1 v10 device is registering but not the 3 other v10 devices?
Whatever you do, please keep that backup handy. I will look into this further but I am honestly perplexed at the logs. Please let me know if the other devices are being loaded correctly in v1.9.10.

I have updated to v1.9.11 with some extra logging:
If you could, in the configs please set your logging level to 5 as shown below and then restart. Then let's take a look at the output. I've added logging to show exactly what we are getting back from the bulbs.
        {             "platform": "homebridge-magichome-dynamic-platform",             "pruning": {                 "pruneMissingCachedAccessories": false,                 "restartsBeforeMissingAccessoriesPruned": 3,                 "pruneAllAccessoriesNextRestart": false             },             "whiteEffects": {                 "simultaniousDevicesColorWhite": true,                 "colorWhiteThreshold": 10,                 "colorWhiteThresholdSimultaniousDevices": 50,                 "colorOffThresholdSimultaniousDevices": 5             },             "deviceManagement": {                 "blacklistOrWhitelist": "blacklist",                 "blacklistedUniqueIDs": [                     ""                 ]             },             "advancedOptions": {                 "periodicDiscovery": true,                 "namesWithMacAddress": false,                 "logLevel": 5             }         }

Here's The output from the logs. I've not looked at these too closely yet, but there were some red errors, so maybe we're getting somewhere.
homebridge.log
As for previous questions. When I boot up like this with the configs that were previously working, I get 4/7 bulbs, these are the older models and not the new ones with firmware v10. As for the 20 devices, a lot of those are from other plugins and all come in just fine.

If I wipe out the magichome plugin and try to let these bulbs pull in from scratch, the one names Ali's Nightstand is the only one that shows up in the accessories, the same as we were seeing in the logs. All of the bulbs in the image above, including the Ali's nightstand are the v7 bulbs.

Wait, the new bulbs just showed up, just had to wait a bit longer after the initial boot. I'd mentioned this in my first post that I often had to do this, but I've been being impatient with it tonight it seems. I'll do some testing and see how things are working out here. I'm still curious about the logs not showing all of the devices registering, but not as concerned if things work for me here.

Best I can tell, everything is as functional as it was before. Those three bulbs are in a scene together and siri will often trigger the scene but not manage to get all 3 on for some reason. This isn't new behavior though, was happening with the old bulbs too.
I'm thinking this can be closed, but do let me know if there is anything worth acting on in the last logs I sent over. Thank you again for all your work on this!


Debug panel: disallow txs on wrong chain

Current dependencies on/for this PR:

main

PR #116   👈

PR #101

This stack of pull requests is managed by Graphite.


Is ztstat calculation correct?

The Zstat calculation shown here does not appear to match any of the common zstat calculations. Where is it from?
https://github.com/evidentlyai/evidently/blob/fe8be9bbb7fa077a176305d7f87a7f18e8c60919/src/evidently/calculations/stattests/z_stattest.py#L36-L45
Some documentation on comparitive z-test:

https://www.cliffsnotes.com/study-guides/statistics/univariate-inferential-tests/two-sample-z-test-for-comparing-two-means
https://en.wikipedia.org/wiki/Student's_t-test#Independent_two-sample_t-test

I see this is actually a z-test for proportions:
https://mverbakel.github.io/2021-02-13/two-sample-proportions

Z-test is specifically for binary case


Proposal: use c8d.io vanity package import for containerd

Having vanity imports is all the rage in among the cool kids in a Go project. The biggest benefit is keeping the import path space independent of where the source is hosted. This will let use better handle the stability required in the future. Other benefits include shorter import paths.
Example import path changes:

Current
Under this Proposal

github.com/containerd/containerd
c8d.io/containerd

github.com/containerd/cri-containerd
c8d.io/cri-containerd

github.com/containerd/btrfs
c8d.io/btrfs

github.com/containerd/continuity
c8d.io/continuity

How do we implement this?
We'll have to host a snippet like this under the c8d.io domain:
  <meta name="go-import" content="c8d.io/{project} git https://github.com/containerd/{project}">
  <meta name="go-source" content="c8d.io/{project}     https://github.com/containerd/{project} https://github.com/containerd/{project}/tree/master{/dir} https://github.com/containerd/{project}/blob/master{/dir}/{file}#L{line}">

{project} will have to be replaced with the project name, such that we can map any project under the github.com/containerd org. We can host this will static html files or host a webapp that does the translation. This content only needs to be served on urls with go-get=1 in the query.
To ensure that these always get imported "nicely", we all have to have the following next to all package declarations in containerd packages:
package cio // import "c8d.io/containerd/cio"

For this issue, I would like to understand if there are any objections or concerns around this idea or process.

FWIW, visiting c8d.io from my office is forbidden - it's marked as "blocked due to a security threat" - it appears to be marked somehow by OpenDNS as containing malware.

@hairyhenderson I don't think that would necessarily be a long term issue as the domain is parked via namecheap right now. There is no content hosted there yet.

@estesp ah - hopefully OpenDNS will update their records quickly if/when it's purchased and hosted 😉

Import changing would be too costly with current adoption. This issue failed to get any consensus so I am going to go ahead and close.


Getting Started Demo recording - Python

demo recording of the Getting Started guide mentioned in #3639.
We will need it for the blog post and social

https://youtu.be/c0bLWmi2B-4


UDP packet is dropping

We using Cisco Container Platform:
CCP Version: 4.0.0
K8S Version:  1.13.5"
Overlay: contiv
OS: Ubuntu-18.4

Problems:
We deployed SDC pipeline on CCP cluster where 2% data is receiving and Same deployment we have in our old cluster(k8s1.10.4- with Flanne Network, On Top of Centos) where SDC is working fine.
Can any one help me on this issue.
Let me know if you need more details.

Please provide more details, see https://github.com/contiv/vpp/blob/master/docs/debugging/BUG_REPORTS.md

Thank you, will check the above document.

We followed the document and changed the config but no luck.
Tested with MTUSize: 1500 and MTUSize: 9000
Here is the config Map:
apiVersion: v1
data:
  contiv.conf: "useL2Interconnect: false\nuseTAPInterfaces: true\ntapInterfaceVersion:
    2\ntapv2RxRingSize: 256\ntapv2TxRingSize: 256\ntcpChecksumOffloadDisabled: true\nSTNVersion:
    1\nnatExternalTraffic: true\nmtuSize: 9000\nscanIPNeighbors: true\nipNeighborScanInterval:
    1\nipNeighborStaleThreshold: 4\nenablePacketTrace: false\nrouteServiceCIDRToVPP:
    false\ncrdNodeConfigurationDisabled: false\nipamConfig:\n  contivCIDR: <IP_ADDRESS>/12\n
    \ "
  controller.conf: |
    enableRetry: true
    delayRetry:<PHONE_NUMBER>
    maxRetryAttempts: 3
    enableExpBackoffRetry: true
    delayLocalResync:<PHONE_NUMBER>
    startupResyncDeadline:<PHONE_NUMBER>0
    enablePeriodicHealing: false
    periodicHealingInterval:<PHONE_NUMBER>0
    delayAfterErrorHealing:<PHONE_NUMBER>
    remoteDBProbingInterval:<PHONE_NUMBER>
    recordEventHistory: true
    eventHistoryAgeLimit: 1440
    permanentlyRecordedInitPeriod: 60
  service.conf: |
    cleanupIdleNATSessions: true
    tcpNATSessionTimeout: 180
    otherNATSessionTimeout: 5
    serviceLocalEndpointWeight: 1
    disableNATVirtualReassembly: false
kind: ConfigMap
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"contiv.conf":"useL2Interconnect: false\nuseTAPInterfaces: true\ntapInterfaceVersion: 2\ntapv2RxRingSize: 256\ntapv2TxRingSize: 256\ntcpChecksumOffloadDisabled: true\nSTNVersion: 1\nnatExternalTraffic: true\nmtuSize: 9000\nscanIPNeighbors: true\nipNeighborScanInterval: 1\nipNeighborStaleThreshold: 4\nenablePacketTrace: false\nrouteServiceCIDRToVPP: false\ncrdNodeConfigurationDisabled: false\nipamConfig:\n  contivCIDR: <IP_ADDRESS>/12\n  ","controller.conf":"enableRetry: true\ndelayRetry:<PHONE_NUMBER>\nmaxRetryAttempts: 3\nenableExpBackoffRetry: true\ndelayLocalResync:<PHONE_NUMBER>\nstartupResyncDeadline:<PHONE_NUMBER>0\nenablePeriodicHealing: false\nperiodicHealingInterval:<PHONE_NUMBER>0\ndelayAfterErrorHealing:<PHONE_NUMBER>\nremoteDBProbingInterval:<PHONE_NUMBER>\nrecordEventHistory: true\neventHistoryAgeLimit: 1440\npermanentlyRecordedInitPeriod: 60\n","service.conf":"cleanupIdleNATSessions: true\ntcpNATSessionTimeout: 180\notherNATSessionTimeout: 5\nserviceLocalEndpointWeight: 1\ndisableNATVirtualReassembly: false\n"},"kind":"ConfigMap","metadata":{"annotations":{},"name":"contiv-agent-cfg","namespace":"kube-system"}}
  creationTimestamp: "2019-07-09T08:36:25Z"
  name: contiv-agent-cfg
  namespace: kube-system
  resourceVersion: "27027"
  selfLink: /api/v1/namespaces/kube-system/configmaps/contiv-agent-cfg
  uid: a337a260-a224-11e9-bf1e-005056bf07b9

So could you describe what is the issue actually?
UDP communication between 2 pods? Drops some packets or does not work ate all? Same node or between the nodes? Have you checked for errors in VPP debug CLI (show errors)? What about the vswitch logs, are there any errors?

Not in between 2 pod.
We are processing log from syslog server to sdc pipeline with nodePort.
The data flow is happening properly on our old environment (k8s-1.10.4, Flannel network and Centos7.4).
But in CCP cluster(k8s-1.13.4, Contiv Network and Ubuntu18.4LTS) same data only 2% is processing.

Sorry, I cannot really help with this level of description of the issue ("something" is not working and was working before).
I would need to know exactly, where the traffic originates (from you description I just guess it is the host stack of one of the worker nodes?) and where it should end. You mentioned nodePort, which is a k8s service - so what is the backend of that service? A pod? Multiple pods? Host network pod or a not? On the same node as the client, or different nodes?.
Then you should start tracing the packet all the way from the client to the server - does it actually go via VPP? Have you tried tracing it on VPP using the vpptrace script? Are there any drops on VPP?


Migrator does not exist

I read trough your documentation on how to run migrations (https://www.sea-ql.org/SeaORM/docs/migration/running-migration/) and there it states:  You can perform migration on application startup with Migrator, which implements the MigratorTrait.
But I could not found any migrator and doc.rs confirms this:

It's here https://docs.rs/sea-orm-migration/latest/sea_orm_migration/migrator/trait.MigratorTrait.html

It's here https://docs.rs/sea-orm-migration/latest/sea_orm_migration/migrator/trait.MigratorTrait.html

Yeah the trait but not the Migrator, but no implementation for it.

You can look into one of the examples


Actually, completely unrelated to #31.  This was a simple oversight in failing to properly sign-extend or zero-extend values smaller than 64-bit, as all divisions on sparc64 are performed using UDIVX, which is 64-bit.
Fixed.


enable marauder wardrive

This goes along with https://github.com/eried/flipperzero-mayhem/pull/46 - although, I'll have to still check it out and you'll likely wanna bump to v0.7.1 of the marauder wifi companion too (just something that'd be helpful would be, when updating it, like the firmware, create a different git commit with changes specifics to mayhem so contributors like me can check it out and help with bumping these out, thanks for the amazing work anyway 🙏 )

Yeah, I am not sure, what do you suggest for this kind of "optional" features?

closing in favor of #49


Use a longer delay in case the short timeout is insufficient for device attach

When adding a PVSCSI contro;ller on first vmdk attach, at times the process takes around 5 seconds by which time the plugin timesout and fails the create operation. At times this takes just a second.
To ensure that the client is flexible to handle these scenarios first we try with a 1 secind timeout (default) and if the device is still not present then wait for a longer timeout of 5 seconds before giving up.
In the below sample adding a pvscsi controller is done in ~1 second,
03/16/17 13:25:34 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk] [INFO   ] Attaching /vmfs/volumes/bigone/dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk as independent_persistent
....
03/16/17 13:25:34 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk] [DEBUG  ] backing_disk=Ubuntu-14.04-64-LTS-IMG/Ubuntu-14.04-64-LTS-IMG-000001.vmdk virtual_disk=dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk
03/16/17 13:25:34 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk] [INFO   ] Adding a PVSCSI controller
...
03/16/17 13:25:35 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk] [INFO   ] executeRequest 'attach' completed with ret={'ControllerPciSlotNumber': '224', 'Unit': '0'}
03/16/17 13:25:35 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz19.vmdk] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0
And in this case takes two seconds,
03/16/17 13:16:00 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz14.vmdk] [INFO   ] Attaching /vmfs/volumes/bigone/dockvols/11111111-1111-1111-1111-111111111111/zzzz14.vmdk as independent_persistent
...
03/16/17 13:16:00 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz14.vmdk] [INFO   ] Adding a PVSCSI controller
....
03/16/17 13:16:02 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz14.vmdk] [INFO   ] executeRequest 'attach' completed with ret={'ControllerPciSlotNumber': '224', 'Unit': '0'}
03/16/17 13:16:02 104884 [2 (1)-[bigone] dockvols/11111111-1111-1111-1111-111111111111/zzzz14.vmdk] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0

Fixes #962

I tried that but the event handling logic waits for that much time for
every single attach meaning every container always starts with that delay.
With the proposed fix it typically takes one second for attach and max five
to six seconds
On Mar 16, 2017 7:08 PM, "Prashant Dhamdhere"<EMAIL_ADDRESS>wrote:

@pdhamdhere commented on this pull request.
Why not just change devWaitTimeout to 5seconds? If device is attached in
1sec, iNotify will break in 1sec rt?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vmware/docker-volume-vsphere/pull/1040#pullrequestreview-27337945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseCbu-TRIekJCaEi3LaHUr3w9Bbjfks5rmTs5gaJpZM4MfTWd
.

The watcher code doesn't implement any timeouts on its own which is why we have a timeout explicitly when looping for events. And that timeout is what always runs. Setting to a higher value causes all attach requests to run for that much time.

the event handling logic waits for that much time for every single attach meaning every container always starts with that delay.

that is not how it is supposed to work, so it seems broken. I do not think we should do a patch before understanding what is broken . We do not need sleep. We need timeout

Watcher is working fine, but the pvscsi controller add takes minimum 1 second and at least a max of 5  seconds.
The wather pkg (inotify and now fsnotify) doesn't implement a timeout based watch logic. A watcher is instantiated and then the logic is to loop waiting for events. This wait has to have an external timer as the watcher doesn't implement one. And the timer is to have a sleep. The way that works is a) check for the file events, b) if none sleep (timeout) c) break from watcher loop.
Above logic works is ok to handle device attach delays, except that (as mentioned ) pvscsi ctlr add is anywhere from 1 - 5 seconds.

We are not waiting for adding pvscsi controller, we are waiting for Linux kernel to discover the device after it was.succcessfully added to the VM, aren't we ? Are you saying it takes Linux kernel 1-5 sec to discover a new scsci adapter with a device ?
Also, what you describe is not iNotify but a polling mechanism. iNotify package we are using seems to have been depreciated and we need to switch to gopkg.in/fsnotify.V0 or later

Have seen the current fsnotify pkg and the API there isn't using timeouts either. Do we need to still update the pkg? Correct, the delay is for the in Linux kernel, and thats mostly 1 second but not always.

Another thing with using these watchers, we can watch a directory and any change there alone is recorded. We watch only the /dev/disk/by-path as we don't know which host is being used for the disk attach. So when we have a controller and a disk added we only can get a notification of the host (controller) add, nothing in it (the disk). A sleep and a retry is more than sufficient for our purpose.

Have seen the current fsnotify pkg and the API there isn't using timeouts eithe

there is no need for explicity timeout on an interface, golang allows simple and generic timeout handling
e.g. https://blog.golang.org/go-concurrency-patterns-timing-out-and

Do we need to still update the pkg?
We need to have something that does not require us to do polling and returns when dev path really shows up.  If we need to kick off scsci rescan , we should also do it. but we should not block on polling intervals.

Here  we see the Linux kernel logs taking around 5 seconds to detect the pvscsi controller and the one disk (request that attached both to the VM).
Mar 20 01:12:47 hte-1s-eng-dhcp98 kernel: [327843.288814] pciehp 0000:00:17.0:pcie04: Button pressed on Slot(224)
Mar 20 01:12:47 hte-1s-eng-dhcp98 kernel: [327843.291040] pciehp 0000:00:17.0:pcie04: Card present on Slot(224)
Mar 20 01:12:47 hte-1s-eng-dhcp98 kernel: [327843.308102] pciehp 0000:00:17.0:pcie04: PCI slot #224 - powering on due to button press.
   The issue with OTHER cases that should not be waiting 5 seconds.
Also. looking at the log, I see only 1 operation (slot power on) taking 5 sec, the rest is fine.
Mar 20 01:12:47 hte-1s-eng-dhcp98 kernel: [327843.308102] pciehp 0000:00:17.0:pcie04: PCI slot #224 - powering on due to button press.
Mar 20 01:12:52 hte-1s-eng-dhcp98 kernel: [327848.430585] pci 0000:13:00.0: [15ad:07c0] type 00 class 0x010700

I am wondering what could be taking that long... (still, the main issue is that OTHER ops should not be impacted by the slowest one)

Only the first attach waits for 5 seconds the subsequent attaches complete
in a second or less.
 The issue
with OTHER cases that should not be waiting 5 seconds.
Also. looking at the log, I see only 1 operation (slot power on) taking 5
sec, the rest is fine.
Mar 20 01:12:47 hte-1s-eng-dhcp98 kernel: [327843.308102] pciehp 0000:00:17.0:pcie04: PCI slot #224 - powering on due to button press.
Mar 20 01:12:52 hte-1s-eng-dhcp98 kernel: [327848.430585] pci 0000:13:00.0: [15ad:07c0] type 00 class 0x010700
I am wondering what could be taking that long... (still, the main issue is
that OTHER ops should not be impacted by the slowest one)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vmware/docker-volume-vsphere/pull/1040#issuecomment-287698207,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseNEKp1ESi33-z866p6Z77ffzeWmbks5rnjctgaJpZM4MfTWd
.

If the pvscsi controller is already attached the attach time is <= 1 second.
System logs:
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.972576] vmw_pvscsi: msg type: 0x0 - MSG RING: 4/3 (5)
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.972581] vmw_pvscsi: msg: device added at scsi0:0:0
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.972725] scsi 12:0:0:0: Direct-Access     VMware   Virtual disk     1.0  PQ: 0 ANSI: 2
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.972976] sd 12:0:0:0: [sdb] 204800 512-byte logical blocks: (104 MB/100 MiB)
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.973010] sd 12:0:0:0: [sdb] Write Protect is off
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.973013] sd 12:0:0:0: [sdb] Mode Sense: 61 00 00 00
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.973046] sd 12:0:0:0: [sdb] Cache data unavailable
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.973049] sd 12:0:0:0: [sdb] Assuming drive cache: write through
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.974964] sd 12:0:0:0: [sdb] Cache data unavailable
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.974969] sd 12:0:0:0: [sdb] Assuming drive cache: write through
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.975186]  sdb: unknown partition table
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.975358] sd 12:0:0:0: [sdb] Cache data unavailable
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.975362] sd 12:0:0:0: [sdb] Assuming drive cache: write through
Mar 20 01:27:23 hte-1s-eng-dhcp98 kernel: [328719.975389] sd 12:0:0:0: [sdb] Attached SCSI disk
Plugin logs
2017-03-20 01:27:23.211267759 -0700 PDT [INFO] Attaching volume and creating filesystem name=yyyy7 fstype=ext4
2017-03-20 01:27:23.789967093 -0700 PDT [INFO] Starting dev wait name=yyyy7 fstype=ext4
2017-03-20 01:27:24.790304311 -0700 PDT [WARNING] Exceeded timeout while waiting for device attach to complete timeout=1s device="/dev/disk/by-path/pci-0000:13:00.0-scsi-0:0:0:0"
About a second to complete the dev wait
The five seconds is for just the first time that a pvscsi controller is added

About a second to complete the dev wait
The five seconds is for just the first time that a pvscsi controller is added

they I do not understand the reasons for 1 sec timeout (and honestly, for 5 sec timeout as well).
Just out of paranoia we can add 15 sec and hope it will never get hit (and fail the op if it does) but the resr seems to be already event driven.
As a side note, I am surprised it's that slow in the kernel . any way to accelerate it (e.g. kick of scsi discovery ?)

Earlier had added a function to do start discovery for Photon OS (with
Photon controller). That needed more delays than what we don with Vsphere.
Unfortunately the *notify pkgs don't have any timeout in themselves
On Mon, Mar 20, 2017 at 2:09 PM, Mark Sterin<EMAIL_ADDRESS>wrote:

About a second to complete the dev wait
The five seconds is for just the first time that a pvscsi controller is
added
they I do not understand the reasons for 1 sec timeout (and honestly, for
5 sec timeout as well).
Just out of paranoia we can add 15 sec and hope it will never get hit (and
fail the op if it does) but the resr seems to be already event driven.
As a side note, I am surprised it's that slow in the kernel . any way to
accelerate it (e.g. kick of scsi discovery ?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vmware/docker-volume-vsphere/pull/1040#issuecomment-287700861,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseB2h0FaQJ60xwKpC6FY4cb1RIaLyks5rnjtSgaJpZM4MfTWd
.

Unfortunately the *notify pkgs don't have any timeout in themselves.

there is no need as there is a generic mechanism in golang for timeouts

The select-case construct typically (on most attach-waits) ends up doing the sleep(). A large timeout results in sleeping for that much time on all waits.

Then  something is wrong as you just said than in majority of cases the kernel discovers the new devices much faster than 1 seconds. In this cse timeout should not matter since the wacher gets woken up by this event.
Per your explanations, we should then have one very large (20sec+) timeout make sure we recover from (unlikely) case of kernle faiing to power on the new controller, and all other cases we should get event and not hit the timeout.

The proposed fix seems fine in that case, it's the original code plus a max
five second timeout in case the default doesn't help. Say best in the case
where the device is not discovered the create is failed.

The proposed fix seems fine in that case, i

No, if I understand correctly changing devWaitTimeout to 10secs should resolve. If decide is discovered in less than 10Secs then iNotify will break otherwise will timeout after 10Secs. Right?

Can we make this change to 10 seconds in the existing code and try it out? I've done that. The seleect-case typically doesn't ever find the device (or a file system event) when its called and around 99% of the time hits the time.sleep() case and does the sleep for the specified duration. Changing to ten seconds will cause every single attach to wait for ten seconds even if the device was identified in a some hundred milliseconds (when the system runs its periodic discovery loop).

As we already discussed above  this is NOT an event driven behavior and this is not what we want.
This is also not what iNotify is doing. If you see this behavior, then our code using inotify is wrong and needs to be fixed.
Timeout 10 sec should be ALMOST NEVER Hit, all regular ops should complete within 1 sec (as you've mentioned above) or 5 sec for pvsci adapter (as you've mentioned above) - basically, in time it takes LInux kernel to find  a device and expose it in the /dev/disk/by*

"Timeout 10 sec should be ALMOST NEVER Hit, all regular ops should complete within 1 sec (as you've mentioned above) or 5 sec for pvsci adapter (as you've mentioned above) - basically, in time it takes LInux kernel to find a device and expose it in the /dev/disk/by*"
Ok, so this change is good then - it takes 1s or max 5s.

Ok, so this change is good then - it takes 1s or max 5s.

Please do not merge. The issue may have been resolved with #1058

Fixed with #1058


Paths are not normalized on Windows, causing duplicates

For package: jest-haste-map
What is the current behavior?
Running the react-native packager (react-native start) with watchman enabled (ie. in the path) fails on Windows.
This is because the paths that are put into jest-haste-map do not have consistent path-separators.
For my project, I did a test to show this.
In<EMAIL_ADDRESS>I added the following lines:
  constructor(files) {
    this._files = files;
+    for (let filePath in files) {
+      console.log(filePath);
+    }
  }

When I ran "react-native start", I then got these results:
[...]
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Note that forward slashes are used everywhere except for the divide between the root folder and the folder under it.
This causes problems, because the other scripts, which call the HasteMap.exists method, pass in file-paths which follow a different pattern (they're all backslashes, as per Windows). This means that the HasteMap.exists method returns "false" for many file-paths which, in fact, exist. This causes real-files to appear to be missing, causing module-not-found errors.
Here's an example of the error: (when the file does in fact exist -- even when copied into both roots)
(node:54964) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): NotFoundError: Cannot find entry file index.android.js in any of the roots: ["C:\\Root\\Apps\\@V\\LucidLink\\Main","C:\\Root\\Apps\\@V\\LucidLink\\Main\\Build"]

It also causes duplicate entries to be added to the HasteMap, causing duplicate-module warnings.
Here's an example of the warnings it causes:
@providesModule naming collision:
  Duplicate module name: NavigationCardStack
  Paths<EMAIL_ADDRESS>collides with<EMAIL_ADDRESS>
This error is caused by a @providesModule declaration with the same name across two different files.

This took me about 10 hours to track down, because I followed many false and halfway-fixing leads before finally coming across the root issue. (stumbling around in react-native's javascript files is not exactly my speciality)
What is the expected behavior?
The HasteMap class should normalize all stored file-paths, and the file-paths compared with those in the store.
This is pretty straight-forward. In my case, I fixed the problem by making these changes, to the "jest-haste-map\build\HasteFS.js" file:
  constructor(files) {
-    this._files = files;
+    this._files = {};
+    for (let filePath in files) {
+      this._files[path.normalize(filePath)] = files[filePath];
+    }
  }

[...]

   exists(file) {
-    return !!this._files[file];
+    return !!this._files[path.normalize(file)];
  }

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
OS: Microsoft Windows 10 Pro (Version 10.0.14393 Build 14393)
node: 6.9.1
npm: 3.10.8
jest: 17.0.2
jest-haste-map: 18.0.0
End note
Please consider adding these changes (or an equivalent), as it is quite hard to track down for end-users!
I don't know what caused my project to have this issue, without being the case for all watchman-enabled Windows projects. It's possible it was caused by some kind of misconfiguration.
But even if that's the case, it's still a serious problem because:

No errors or warnings are shown to tell me of my configuration mistake.
When it happens, it's very annoying and time-wasting. (I've spent ~10 hours debugging, and time was also lost in the weeks earlier, where I settled for using the node file-watcher -- which had major problems of its own for me)
It seems like the mistake, if there was one, must be fairly easy to make, as I've done little "out of the ordinary" with my project setup.

Anyway, for reference, here is the project I encountered the issue in: https://github.com/Venryx/LucidLink
And here is a thread with some other background on the issue: https://github.com/facebook/react-native/issues/9136#issuecomment-306486102
I know providing a direct repro project is easier for debugging, but in this case the problem and solution are straight-forward enough that I don't think it's necessary. (and I've spent an awful lot of time on this issue already)
If you need any specifics from my project though, feel free to ask, and I'll provide them here for convenience.

@Venryx, are you still experiencing this issue? And are you still working around it as above? I'm seeing it on my machine but my colleague is somehow not experiencing this.
OS: Microsoft Windows 10 Enterprise (Version 1703, OS Build 15063.540)
node: 6.11.2
npm: 3.10.10
jest: 20.0.4
jest-haste-map: 18.0.0
Watchman version: 4.9.0

Isn't this fixed by https://github.com/facebook/jest/pull/4018?

I'd guess so. @Venryx could you check?

Should be fixed by #5553


[fix] fix some bugs and flake8 lint problem

see https://github.com/wenet-e2e/wespeaker/issues/120

Fix bug in cnceleb/v2/local/download_data.sh. See https://github.com/wenet-e2e/wespeaker/issues/123.


Updating Helm Chart Readme

Updating Helm Chart Readme with correct config parameter for values.yaml, which is configInline, not config (which is what it would be called for a straight ConfigMap definition).
Thanks for sending a pull request! A few things before we get started:

If this is your first time, please read the contributing guide
For non-trivial pull requests, please file an
issue first, and get
agreement that the change is a good idea, and a general guideline
for how it should be implemented, before sending code. Large PRs
that weren't first discussed and agreed upon in an issue won't be
accepted.
If the PR fixes a particular bug, please include the words "Fixed
#" in the PR text, so that the bug auto-closes when
the PR is merged.

I signed it!

Thanks!


wrong secrets rotation command in README.md

Likely

Rotate credentials for a deployment:
genesis secrets us-west-1-sandbox
should become
Rotate credentials for a deployment:
genesis rotate-secrets us-west-1-sandbox

There's a lot more problems with the Genesis commands section of the README.
@dennisjbell do you want to update that section or just rip it out entirely and rely on something like:
For more information on how to use Genesis, see:

    genesis help


Document the database schema

Add a make target for generating the schema from the migrations and
including it in the database documentation.
This is useful for having a holistic view of the database, instead of
sifting through migrations to understand the relationships between all
tables. The included .sql file is only for documentation purposes.
Fixes #84

I like it!
/lgtm


func (texture *Texture) Lock fix

Func param is pointer to unsafe.Pointer not unsafe.Pointer.

Could you revert the README.md change? I'm guessing it wasn't intended for this pull request. Thanks.

Sorry for that;new to github. Do you know how to revert a change edited on
the github website? I don't, so I ended up starting again. It should be
better this time. thanks.
On Mon, Jun 8, 2015 at 8:37 PM, Jacky Boen<EMAIL_ADDRESS>wrote:

Could you revert the README.md change? I'm guessing it wasn't intended for
this pull request. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/veandco/go-sdl2/pull/124#issuecomment-110214212.

@srwiley I never edit on Github either but I see that you did another pull request which is fine by me.


Microsoft.Extensions.DiagnosticAdapter does not map properties from ancestor classes

Microsoft.Extensions.DiagnosticAdapter package provides easy opportunity to wrap execution flow into the suitable well-configured methods like this
[DiagnosticName("Microsoft.EntityFrameworkCore.Database.Command.CommandExecuting")]
public void OnCommandExecuting(DbCommand command, DbCommandMethod executeMethod, Guid commandId, Guid connectionId, DateTimeOffset startTime)
{
}

initializing all known specified parameters in method signature, but it does not work with properties in ancestor classes, e.g CommandExecutedEventData because of this line of code (link):
var properties = inputType.GetTypeInfo().DeclaredProperties.ToArray();

It uses only those properties, which are declared in this particular inputType type. And in case of CommandExecutedEventData there are only one property - Result. All other properties from CommandEndEventData, CommandEventData and EventData will be ignored.
Consider to change the line of code mentioned above to
var properties = inputType.GetTypeInfo().GetProperties();

to allow mapping to any property in the chain of class inheritance, so we can use such methods:
[DiagnosticName("Microsoft.EntityFrameworkCore.Database.Command.CommandExecuted")]
public void OnCommandExecuted(object result, bool async, TimeSpan duration, DbCommand command, Guid commandId)
{
}

Now all arguments except result have their default values - null for reference types and zeros for structs.

@rynowak - do you recall if this was something we did on purpose or we maybe just didn't consider it?

I'm sure there was lots of discussion. As I recall, top-level objects are polymorphic and below the top level it's all based on static types. The reason is that if you want to support runtime polymorphism in the proxies, then the proxies become really compilated

Thanks for the quick response. But, excuse me I don't understand what are you talking about. I think that purpose of this adapter is just deconstruct composite object (CommandExecutedEventData, SomeQueryStuff, whatever) passed through DiagnosticSource.Write(string name, object value) API to discrete values on per-property basis following naming/type convention. What does "proxies become really compilated" mean and what consequences could be because of this?

Also there is a simular problem with inheritance of target objects. Suppose we have 2 targets - 1 for SqlServer provider and other for Oracle provider. We have defined a bunch of intercepting methods like
[DiagnosticName("Microsoft.EntityFrameworkCore.Database.Command.CommandExecuted")]
public void OnCommandExecuted(object result, bool async, TimeSpan duration, DbCommand command, Guid commandId) { }

[DiagnosticName("...")]
public void OnCommandExecuting(....) { }

[DiagnosticName("...")]
public void OnTransactionCompleted(....) { }

... and so on

in both target classes.
And some of those methods have provider-agnostic logic (simple logging, whatever), so we may decide to move them in base class making virtual to allow override behaviour in both derived targets. But... the same problem - virtual method in base class is not called: var methodInfos = typeInfo.DeclaredMethods;
This is really surprising. Now we are forced to copy and paste the same implementation code through all targets.


Setting coingeckoId field

I'm submitting a ...
[ x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
https://github.com/solana-labs/token-list/pull/17085
Auto-merge doesn't work with the coingeckoId field

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

merged


[FLINK-28589][runtime-web] enhance web UI for speculative execution

What is the purpose of the change
As a follow-up step of FLIP-168 and FLIP-224, the Flink Web UI now needs to be enhanced to display the related information if the speculative execution mechanism is enabled. This PR enhances the web UI for the newly adopted API changes.
Brief change log

show blocked free slots and blocked TM in overview
show blocked badge in TM list and detail pages
enable expanded rows of other concurrent attempts for subtasks
others: replace loading icon with text to avoid spin animation bottleneck

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Hi, @simplejason. Could you help me review this PR which only concerns web UI changes?

@simplejason Thanks for the advice. All mentioned above have been taken care of.

@flinkbot run azure

@flinkbot run azure

Merging.


PRMerger6 bot appears to be stuck in a loop

Describe the bug
Over on https://github.com/MicrosoftDocs/azure-docs/pull/23338 it looks like the @PRMerger6 bot is stuck in a loop. Reporting here since it seems like the bot is used by multiple repos and not just the azure docset

It's happening again on https://github.com/MicrosoftDocs/azure-docs/pull/24051


What's the best way to train/deploy policy in Robohive?

What's the best way policy trained outside robohive and want to evaluate in robohive?
A policy with state inputs
class StatePolicy:
    def __init__(self, env):
        self.env=env
    def get_action(self, obs_state):
        action = self.policy(obs_state)
        return action, action

A policy with custom visual inputs
class VisualPolicy:
    def __init__(self,env, user_encoder):
        self.env=env
        self.user_encoder=user_encoder
    def get_action(self, obs_state):
        prop_feat = self.env.get_proprio()
        img_feat = self.env.get_extero()
        feature = user_encoder(prop_feat, img_feat)
        action = self.policy(feature)
        return action, action

by @0wu

Docs/ tutorial will be great for this.

@vikashplus Thank you for explaining how to test a policy that is trained outside robohive.
Would you please, explain also how to train a model using robohive. For example, how to use it along with stable-baseline3 to train an agent using rl. In stable-baseline, we use the function model.learn() to interact directly with the env. This means that it uses observations coming from env directly.  How we can use images coming from one camera as the observation?
Thank you in advance

You need to be on the dev branch to use stale baselines for now (I'll merge to the main soon)
Here are two examples that can be helpful

https://github.com/vikashplus/robohive/blob/dev/robohive/tests/test_sb.py
Check the colab lined with the readMe of the repo for another example - https://colab.research.google.com/drive/1rdSgnsfUaE-eFLjAkFHeqfUWzAK8ruTs?usp=sharing


refactor: decompose into smaller macros (e.g. Equatable, Copyable, ...)

It would both clean up the code and make it possible to use macros like @Equatable(), @Copyable() independently of @Data()

If we start dividing, then can we also add fromJson() and toJson() (Jsonable macros) if possible , divide them too? if so, I would like to add such a feature to the library?

I'm still not convinced that toJson and fromJson make sense to be part of a data class. Happy to discuss 👍

The initial refactor is all done now so closing this 🎉


Trouble in loading data from local Orthanc server

I want to get the data from my local Orthanc server but getting a proxy error:

My default.js file looks like this:

I am using Nginx to proxy-pass the Orthanc-server:

When I am going to this url http://localhost/orthanc/dicom-web/studies I am able to see an array object of studies.
While searching for my problem, I saw a solution to make a change in orthanc.json file for DicomWeb, so I also updated my orthanc.json file:

I am not sure where am I going wrong.
When I am running the project with yarn run dev:orthanc, it is working fine.
Can you please suggest me correct way of rendering the data from my local Orthanc server?

Please review the latest code in the master branch. This issue might have been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


Re-enable --skip-rebase

Closes #87
--skip-rebase should work again now, in theory it should block any url rebasing if present.
So this:
@import "fonts.css"

Should now become this when the flag is present:
@import url(fonts.css)

Hey @Lenni009 - any reason you went ahead with PR and then closed it?

Thanks for writing back. I suggest starting with a failing testcase and then going down the rabbit hole. It has to be either in CLI or non-CLI codebase. Let me know if you need anything. :+1:


Support resume for downloads

Hi. thanks to release this useful android library, can be support resume on downloading files?

Hi Mahdi.
Actually I have used Android's default DownloadManager to make this library more reliable and reduce its size.
And by default, DownloadManager supports resume, unless the user itself cancels the downloading process.


Spread operator on nested Proxy object

Version
3.2.29
Reproduction link
github.com
Steps to reproduce
Run the app on Safari 12.1 on Mac Mojave
What is expected?
The object that is using spread operator should be the same as the original object
What is actually happening?
When using spread operator the object is treated as empty

Can't test this as I'm on Monterey already, where it works fine.
Anyone on Mojave?

Closing as stale


The behavior of LocalForm which is connected to the external redux store

Let's suppose I want to have the reusable form component like this one:

// my-form.js

import React from 'react';
import { LocalForm, Field } from 'react-redux-form';

export default function MyForm({ onUpdate }) {
  return (
    <LocalForm onUpdate={onUpdate}>
      <Field model=".username">
        <input type="text" />
      </Field>
    </LocalForm>
  );
}

which I want to use so:
// my-form-container.js

import React from 'react';
import { connect } from 'react-redux';
import MyForm from './my-form';
import * as actions from './actions';

const mapStateToProps = () => ({});

const mapDispatchToProps = (dispatch) => ({
  onUpdate() {
    dispatch(actions.onMyFormUpdated());
  }
});

export default connect(mapStateToProps, mapDispatchToProps)(MyForm);

But this does not work. There is only one call of the function onUpdate which is called from componentDidMount. Later there are no calls of this function when user interacts with the form.
The same is true for onChange. onSubmit is not called too.
Also I tried to use this approach:
import React from 'react';
import { createStore } from 'react-redux';
import { Form, Field, combineForms } from 'react-redux-form';

const formName = 'myForm';

export class MyForm extends Component {
  constructor(props) {
    super(props);

    this.store = createStore(combineForms({
      [formName]: {
        username: ''
      }
    }));
  }

  render() {
    const { onUpdate } = this.props;

    return (
      <Form store={this.store} model={formName} onUpdate={onUpdate}>
        <Field model=".username">
          <input type="text" />
        </Field>
      </Form>
    );
  }
}

but the result is the same.
What is wrong?

the used libraries:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
the examples (see the output in the console when you interact with the form):

without connect(...): http://codepen.io/anon/pen/BpWzzY
with connect(...): http://codepen.io/anon/pen/xgqOEw

<EMAIL_ADDRESS>

This is currently an issue with the latest react-redux - more info in this ticket: https://github.com/davidkpiano/react-redux-form/issues/592

@davidkpiano
thanks for the answer

Please try this again with the latest React-Redux version.

The behaviour of LocalForm is now as expected, only with one small warning from React
Warning: Unknown prop `storeSubscription` on <form> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop

Awesome, good catch!


Joystick Values are inverted

Describe the bug
Joystick axis values are inverted. Instead of full value e.g. 65565 it shows 0 and vice versa.
Steps To Reproduce
Steps to reproduce the behavior:

Connect Joystick
Create input for joystick axis
Store value (@) in MobiFlight variable
Create MobiFlight variable for Joystick value
Start MobiFlight in Offline mode
Use joystick axis

Expected behavior
Values are showing 0 when joystick axis full down, and 65565 when axis full up.
Actual behavior
The other way around.
Details

MobiFlight Version: [e.g. 8.2.0]
FlightSim: [e.g. MSFS2020]
AddOn: [e.g. Default Aircraft]

Additional context
Workaround: 65565-$

As I told Pizman, I think axis reversion is a common issue.  My Thrustmaster Hotas joystick has all of its axes reversed in the MSFS2020 configuration.  I just checked the box provided to reverse the axis direction.  So, it was not surprising to me to see those same axes being read by Mobiflight in reverse scale.
I suggest that you make the axis reversion as an option, just like in the MSFS2020 control options.  This would also allow for having potentiometers wired in reverse to be easily adopted.

This must be incredibly common because AAO offers a "Reverse axis" checkbox on every axis input config.


Move check list to components/list

The check list is currently documented under foundations/typography/list but does not meet the criteria for elements in this location. Move it to a new component/list documentation.

Closing as won't do


Proposal: History API for listing changes

Partial dependent on the resolution of the discussion in decentralized-identity/confidential-storage#207, below is the proposal for an endpoint for requesting a history of changes from an EDV.
Proposal
An HTTP GET endpoint /history that supports the following query parameters

afterSequence: [Unsigned Integer Value] Fetch only changes after the supplied sequence value
distinctDocs: [Boolean] Fetch the changes filtered to the distinct documents effected, e.g if multiple updates have been applied to one document only a single entry in the return results will be present for that document.

Example request
GET /data-vaults/z4sRgBJJLnYy/history?afterSequence=12&distinctDocs=true
HTTP/1.1
Host: example.com
Content-Type: application/json
Accept: application/json, text/plain, */*
Accept-Encoding: gzip, deflate

[
    {
        "documentId": "https://example/data-vaults/z4sRgBJJLnYy/docs/z4sAsDFrGYh",
        "sequence": 15 // E.g 3 changes have been made to this document since sequence "12" but only "15" is showed due to the distinctDocs parameter
    },
    {
        "documentId": "https://example/data-vaults/z4sRgBJJLnYy/docs/zaCfHeKsNesS",
        "sequence": 16,
        "isDeleted": true
    }
]

The group discussed this on the 2021-04-29 call. There were no objections. There was agreement that we will need to use the pagination mechanism for results here as well. There was concern over the distinctDocs field. The ability to pull a specific version of a document at a sequence number was also discussed as another possibility with this API.
Decisions:

Do not put distinctDocs into the PR (raise an issue).
Do not speak to getting a specific document from history (raise an issue).
Do not put isDeleted into the PR (raise an issue).


Do we use aria-errormessage instead of aria-describedby

When do we add support for aria-errormessage, should we even though its not fully supported?
We are currently using aria-invalid in combination with aria-describedby which is also an valid option.
Notes:

https://github.com/w3c/aria/issues/2048
https://github.com/w3c/aria/issues/2048#issuecomment-1743299817

Since support is sparse, I think we should wait before implemeting this

aria-describedby is at least very well supported. Only tip would be to ensure error-message ID is always prepended before help-text-ID in the attribute, so:
✅ aria-describedby="my-error-id my-helptext-id"
❌ aria-describedby="my-helptext-id my-error-id"

Closing for now as aria-errormessage support is too low


problems with installation

Hello,
i need help with installation.
My config is as followed:
wbecpro - heidelberg energy control - evcc on windows - while installation i get following message while configure wallbox:
cannot create charger 'heidelberg': dial tcp <IP_ADDRESS>:502: connectex: No connection could be made because the target machine actively refused it.
can someone help me?

evcc has native Modbus support for Heidelberg EC.

and how can i fix this?


"Cannot create a file when that file already exists" error when install any distro

Windows Version
Microsoft Windows [Version 10.0.19045.3930]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
No response
Other Software

Powershell 7.4.0
Windows Terminal

Version: 1.18.3181.0

Repro Steps
Open Terminal as admin
Run: wsl --install -d ubuntu
Run: wsl --install -d kali-linux
Run: wsl --install -d debian
Expected Behavior
It should install the distro and do first install.
Actual Behavior
Installing: Windows Subsystem for Linux
Cannot create a file when that file already exists.
Diagnostic Logs
No response

/logs please

/logs please

I have uploaded the logs but when I went to reproduce my problem I got a different error. "An error occurred during installation. Distribution Name: 'Ubuntu' Error Code: 0x800700b7"

I reset my PC and this fixed my issue. I think the issue was I reset my PC before and copy and pasted some of my files and it made a file and that caused the error. I think this is also the reason the Xbox app didn't work.


Add platform limits for maximum number of organizations can be created in one day

[Enter feedback here]
Currently, the platform seems to limit the maximum number of organizations can be created in one day. If so, can you add the limits for it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 753feb24-6869-bdbf-0880-1b5ae52732e0
Version Independent ID: 8e4db4a1-07c2-ae46-3843-b139f19c1fb1
Content: Platform limits for App Center - Visual Studio App Center
Content Source: docs/general/platform-limits.md
Service: vs-appcenter
Sub-service: app-center-general
GitHub Login: @King-of-Spades
Microsoft Alias: kegr

AzDO PR - 47158

This is part of our internal anti-abuse measurements and we can't expose the exact details. If you're having issues with these limits, please contact our customer support as we want to learn more about your use case: https://docs.microsoft.com/en-us/appcenter/help


Adding onSnapshotsInSync (not public)

porting from web and android

Adding Michael to check for port accuracy.


Allow to use https://beta.protonmail.com/inbox

Can you allow this new URL ?
https://beta.protonmail.com/inbox

Sorry for late answer. I've filled up with porting the client to React. That will make the client more configurable. I'm adding this as a feature in the React client and hopefully I can deploy a beta soon. I'll let you know :)

Ok thanks for the news!

@LM1LC3N7 We've released our own beta where it's possible to opt in for beta.protonmail.com https://github.com/protonmail-desktop/application/releases/tag/v1.0.0-beta.1


Team Fortress named 'Insurgency' in panel.

Appears I was doing too much copy and paste in the seeder and ended up setting Team Fortress to be named Insurgency, so now the only thing to distinguish them is the game name after selecting it.
💯

https://github.com/Pterodactyl/Panel/pull/97

This was fixed in a previous commit.


Make a release?

It's been rather a while.

I keep meaning to, but it's been a low priority since I haven't been using the library recently. However, I'm picking it back up for a project right now, so expect a release soon.

I nerd-sniped myself and spent all day coming up with an extremely modern redesign. Unfortunately, since this library has been so dead updates-wise, I'm not sure how best to seek feedback from users.
It's in the-future.

Hello @typedrat. I also worked on a modern redesign but with the difference that I eschewed IxPointed < ixApplicative < IxMonad and instead subsumed them in IxMonadTrans and juggled the indices so that IxMonadTrans t => MonadTrans (t i i). I'm sharing for the sake of any fruitful cross pollination between the two libraries.

I nerd-sniped myself and spent all day coming up with an extremely modern redesign. Unfortunately, since this library has been so dead updates-wise, I'm not sure how best to seek feedback from users.
It's in the-future.


Buffer and textures nodes review

Our buffer nodes need a review to be able to work with them easily.
Current state

DynamicBuffer taking IHasMemory<T>
DynamicArrayBuffer taking MutableArray<T>
StructuredBuffer taking size/count, unordered access and outputs the command list?!
Some Buffer.GetData and Buffer.SetData overloads, where only the ones with MutableArray<T> are somehow usable but still hard as they require the command list

Critic
We lack some needed ones

ArgumentBuffer
AppendBuffer taking element size / count
CounterBuffer - not sure?

Data access is inconsistent

A few use inputs of type IHasMemory<T> (implemented by Spread<T> and SpreadBuilder<T>) - an idea taken from https://github.com/dotnet/runtime/issues/22838 where it is still called IHasBuffer<T> as Buffer<T> was renamed to Memory<T> later I think. One however can't connect other common types like arrays - I guess therefor the need for DynamicArrayBuffer.
The GetData and SetData nodes use MutableArray<T>, ref T (makes no sense in VL) and DataPointer - a tuple of IntPtr and length as well as the unhandy command list input an end-user has no clue about.

Inconsistent in- and outputs

DynamicBuffer has options for IsVertexBuffer and IsIndexBuffer while all the others don`t have that
Some return the command list - because of the SetData GetData nodes?

Proposal

Structure the nodes based on the buffer types, which is IndexBuffer, VertexBuffer, StructuredBuffer, AppendBuffer, ArgumentBuffer and CounterBuffer
Make versions based on the usage Default (read-write), Immutable (read-only), Dynamic (gpu: read-only, cpu: write-only) and Staging (copy from gpu to cpu) - as long as they make sense and are supported, need to check API documentation
In general all versions except for Staging have a data input of type ReadOnlyMemory<T> and we provide an adaptive node AsReadOnlyMemory taking IReadOnlyList<T> with implementions for Spread<T>, SpreadBuilder<T>, MutableArray<T> and ImmutableArray<T>
There's a corner case where one wants to load bytes (like Memory<Byte>) and interpret the data in the shader. Feeding that to the buffer constructors usually results in a not supported exception as the graphics APIs require an element size of at least 4 bytes. This could be tackled by re-interpreting the Memory<Byte> as Memory<Int> - see https://stackoverflow.com/questions/54511330/how-can-i-cast-memoryt-to-another for an implementation. This raises the question why not use Span<T>? See discussion below.
All nodes have exactly one output of type Buffer<T>

As long as VL doesn't support implict type conversions on links, a AsReadOnlyMemory node would need to be placed upstream. But this reliefs the node set to get blown up completely by all type combinations. The performance impact should be neglectable as ReadOnlyMemory<T> is a struct and therefor causes no allocation.
Based on the above ideas we'd end up with the following node set:

Name
(Default)
(Immutable)
(Dynamic)
(Staging)
Comment

IndexBuffer
x
x
x
-
Takes ReadOnlyMemory<int>

VertexBuffer
x
x
x
-

StructuredBuffer
x
x
x
x
Has Unordered Access input

ArgumentBuffer
x
-
-
-
Used for indirect dispatch

AppendBuffer
x
-
-
-
No data input

CounterBuffer
x
-
-
-
Not sure, I guess also no data input

(Staging) would never have data input but only element count. Element size would gets infered from T.
(Dynamic) has Apply pin to write incoming data
StructuredBuffer (Default) will have UnorderAccess set. If one wants read-only use 'Immutable' or 'Dynamic' versions.

And further we'd provide GetData and SetData process nodes (dealing with the command list internally) again with ReadOnlyMemory<T> as data type.
Discussion

We could also say we take ReadOnlySpan<T> as input - but we would first need to sort out the compiler exception in VL - because a ref read-only struct is not allowed to be used as a type argument. The tracing mechanism would need to filter them out - how costly would that be? Backend would need to check every hub it traces.

I guess DynamicTexture nodes are also missing.

@tebjan suggests to first introduce one Buffer node to rule them all. Some of its input combinations won't work (as seen in the matrix above) - the node will throw an error (turn pink).
Based on the usage of it we can post pone the introduction of more easy to use nodes.

SetTextureData, SetData, BufferData, InitialData, TextureIntitalData shall all use the same data type.
We want one node of input T that outputs an instance of one central data type capturing the dimensionality and pinning ideas. The main responsibility is to provide graphics-API compatible datatypes (like IntPtr) from the input T.

We want to focus on a databox-like construct that doesn't treat the 1d case as special. We want to have a pinnable DataBox.

PinnableDatabox

Simpler Signature
has the mini-advantage that the pin- and unpin-methods are allocation-free (No ResourceHandle class instance)

Provider<DataBox>

has the advantage that it comes with operators for fine-grained timing of the pin and unpin moments. PROBABLY NOT NECESSARY. Pin & Unpin often!
No new invention
We would need a new region that allows dealing with Handles directly. It would allow disposing the handle (unpin), not the resource.

We now got:

complete set of easy to use building blocks to create any buffer or texture supported by DX11, including views
simple nodes for most common use cases: immutable, dynamic and compute for common resource types
an easy, complete and generic way to pass Spread, (Mutable)Array, Image (and Strings) to graphics resources
an easy way to create vertex and index buffers in compute shaders

Not yet:

easy to use special interest buffers (Argument, Append/Consume, Counter)
Cube and Array textures

these would need some investigation into use cases (append/consume, auto draw with copy counter) and make the nodes according to them.


Unable to import Nagios XI config wizards

I'm using Nagios XI ver 2024R1.2.1 and when I tried to import ibmiservice.zip or ibmicustomsql.zip I get the message "Wizard installation failed. Uploaded zip file is not a config wizard."
I see these files are from 2019, are these the latest builds available?

Hi, Thats when it was written. No new ones are available. Seems IBM has pulled away from this for the minute.
Try downloading them from GITHUB and try again?

I merged in some new changes and rebuilt the zip files to include the updates. It sounds like those are working for you now, so I'll close out this issue. If you do run into any issues with them feel free to open a new issue or reopen this one.


Feat/improved theming capabilities

Issue:

Theme setup is strictly a one-time affair at the getStorybookUI method. There is no ability for the parent to change the value of theme if the end user chooses to do so.
A <Switch> could be placed at the bottom (like a footer) of the resulting <StorybookUIRoot> to control the current theme without jumping into any of the "stories", but in doing so, when the end user brings up the keyboard, the "footer" used to allocate space for <Switch> is hidden from the Storybook's <KeyboardAwareView> because it's not a nested child of it.

What I did
Add more parameters to the <StorybookRoot> wrapper to serve the use cases needed.
How to test
Please explain how to test your changes and consider the following questions

Does this need a new example in examples/native?
Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

There's no point in me merging this right now because I can't even compile the source code to /dist. To compile the source code, I need to install dependencies. But I can't even install the dependencies.
Root folder
csantarin ~/javascript-apps/@storybook/react-native (v5.3.25) $ yarn
yarn install v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
warning<EMAIL_ADDRESS>Invalid bin field for "mini-css-extract-plugin".
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/CharlesMangwa/simple-markdown.git
Directory: /Users/csantarin/javascript-apps/@storybook/react-native
Output:
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Operation timed out
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

React Native subfolder
csantarin ~/javascript-apps/@storybook/react-native/app/react-native (v5.3.25) $ yarn
yarn install v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/CharlesMangwa/simple-markdown.git
Directory: /Users/csantarin/javascript-apps/@storybook/react-native/app/react-native
Output:
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Operation timed out
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
csantarin ~/javascript-apps/@storybook/react-native/app/react-native (v5.3.25) $ yarn
yarn install v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/CharlesMangwa/simple-markdown.git
Directory: /Users/csantarin/javascript-apps/@storybook/react-native/app/react-native
Output:
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Operation timed out
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


Create a Camel AMQP extension

@lburgazzoli do you still work on this issue ? I think it could be similar with the mqtt issue https://github.com/apache/camel-quarkus/issues/171. I can take a look at the this one.

please go ahead

The camel-amqp 3.0.0-RC1 has  org.springframework:spring-context version 5.1.9.RELEASE but the io.quarkus:quarkus-bom 0.21.2 has 5.1.8.RELEASE.
It looks like we need to wait the alignment of spring-context in quarkus-bom

https://github.com/quarkusio/quarkus/pull/4044

we have to wait for the https://github.com/quarkusio/quarkus/issues/3436

@zhfeng I' not very sure about the need of wait for https://github.com/quarkusio/quarkus/issues/3436 as camel-jms uses quite a log of Spring API so it may work investigating what alternative options we do have.
maybe we can do something similar to camel-sjms but for the amqp protocol.

OK, I will take a look at the camel-sjms

@zhfeng are you working on this component ?

@lburgazzoli yeah, I still work on this component but do not have much time currently.

@zhfeng if it's ok with you, I can take this issue. I have a basic test working in native mode.

sure, @jamesnetherton and re-assign this issue to you.

I think both camel-jms and camel-amqp are based on the spring. So is this still the problem with the quarks and I think the https://github.com/quarkusio/quarkus/issues/3436 I met before ?


Platform::Getenv uses potentially stale data on Windows

The Windows implementation of the Platform::Getenv function uses the _dupenv_s to read environment variables from the C runtime. The C runtime environment variable functions read data that is cached at process start from the real Windows process environment (ie GetEnvironmentVariable). If after process start any place calls Windows SetEnvironmentVariable, or setenv in a different C runtime (debug vs release runtime, or older versions of MS CRT) it modifies the environment variables in a way that is not visible to the cached state in the used C runtime. So then Platform::Getenv returns stale data that is not correct any more.
We should change the implementation to read the real process environment directly, via GetEnvironmentVariable. Here's a suggested implementation, and it's simpler too: https://github.com/materialx/MaterialX/blob/master/source/MaterialXFormat/Environ.cpp#L18

Thanks for the feedback.

Hi @llatta
I did some tests on my side and OCIO::Platform::Getenv does not see env. variables set by SetEnvironmentVariable.  So I will change the implementation.
Question:

or setenv in a different C runtime (debug vs release runtime, or older versions of MS CRT)

Any reference?

Merged in master i.e. OCIOv2

Thanks for the fix!
Sorry just realized I never replied to the question for more info on the different C runtime problem. That was how I originally ran into the issue. I had compiled OCIO with the release CRT (of VS 2015), and the code using it was linked against the debug CRT. The code linked against debug CRT code was calling ::setenv("OCIO", ...) and that change wasn't picked up by OCIO when it got initialized. Your fix should address this, as either CRT's setenv does call through to the Windows SetEnvironmentVariable

Merged in RB-1.1i.e. OCIOv1


Throw an exception if verified age scope is passed in sign-in request through the add scopes flow.

If a developer passes verification age scope to addScopes method, this results in an error (invalid_request). Instead of having the developer run through documentation and figure out why it errors, we'll throw an exception to let the developer know to use GIDVerifyAccountDetail instead.

Taking care of swift-button-functional-test.


Add CCA

Add City College of Angeles on list of colleges

@tertercusi First stage of verification passed, official domain is cca.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@tertercusi Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Add migration for mass relabeling relationship nodes

So we're in the midst of updating the neo4j gem from 3.x to 6.x... One of the pain points was the way the relationship labels changed - #old_way to NEW_WAY (which is a change that makes sense and I'm glad you did!) Anyways, I'd written a helper that went through all the existing relationships and renamed them... [was wondering the best way to contribute it upstream]

me

Hey @JustinAiken! That sounds like it might be a good fit for https://github.com/neo4jrb/neo4j/blob/master/lib/neo4j/migration.rb ?
You just need a class inheriting from Neo4j::Migration and the three methods in the public interface

@subvertallchris

Here's my first rough whack at fitting into a subclass of that... if this doesn't fit the project well I'll close and maybe create an outside gem, but if you like where it's heading I can clean it up, add more test cases, and do docs/changelog/etc

This looks cool. Will it also move properties and clean up old data? We've had a few discussions about adding a method or methods to do this, too. See https://github.com/neo4jrb/neo4j/issues/1100 for one discussion. Maybe there are some reusable pieces that'll help us move towards that?
@cheerfulstoic, thoughts?

Will it also move properties

No... I'm not sure how to make it do that.  I added a test case to demonstrate that properties do get stripped.

and clean up old data?

Yes! Added a test case for that

We've had a few discussions about adding a method or methods to do this, too. See #1100 for one discussion. Maybe there are some reusable pieces that'll help us move towards that?

Looks like a related issue, but I don't see any way to combine the per-relationship-node-instance API with the mass update... I'm pretty unfamiliar with the code though, so if you do see anything reusable, let me know and I'll move it over!

It looks like your code does move properties (the SET r2 = r).  But maybe that's not what it's doing because you seem to have a spec testing that it does strip the properties.

It seems fine with me.  I'm fine with it just being a straight Cypher query instead of re-using other code since I see this as mainly a way to help people upgrade versions

Screenshot of added doc page:

LGTM!  @subvertallchris merge if it looks good to you?

I'll give it a close look again tomorrow!
On Thursday, March 24, 2016, Brian Underwood<EMAIL_ADDRESS>wrote:

LGTM! @subvertallchris https://github.com/subvertallchris merge if it
looks good to you?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/neo4jrb/neo4j/pull/1166#issuecomment-200660050

It looks good but I have concerns about it not migrating properties. It's something I'd expect in a feature like this, especially since it's going to delete the old relationship afterwards. What about including properties to be migrated within the YML file?

Hey @JustinAiken, I'd love to get back into this if you're still interested. I'm happy to take a stab at adding the property migration if you want. What do you think?

Ah yes... I'm not sure what to do about migrating properties... All of our relationship nodes are just empty labels, so it never came up for us.  If you have an idea on how to rewrite the new relationships including the old properties, I'd love to hear it! 😄

Cool! I'll probably work off your branch and open a PR that covers it. Is
that ok?
On Monday, April 11, 2016, Justin Aiken<EMAIL_ADDRESS>wrote:

Ah yes... I'm not sure what to do about migrating properties... All of our
relationship nodes are just empty labels, so it never came up for us. If
you have an idea on how to rewrite the new relationships including the old
properties, I'd love to hear it! 😄
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/neo4jrb/neo4j/pull/1166#issuecomment-208541762

Cool! I'll probably work off your branch and open a PR that covers it. Is
that ok?

Of course! :)

Closing here :)


run on turtlebot2

hi,
I'm very interested in experiments on robots. What do I need to do to run on robots?
Thank you!

Hi asialulu,
There are several pieces that are needed to fill the sim2real gap:

Use sensors to detect the positions of people;
Track the ID of each detected person so that they are in a consistent order, and feed the positions of tracked people into the observation of the RL network;
Use a more realistic robot dynamics, such as unicycle (set action_space.kinematics = "holonomic" in config.py). However, the true dynamics depend on the robot you are using.

Hope it helps!

@asialulu The sim2real tutorial is released here: https://github.com/Shuijing725/CrowdNav_Sim2Real_Turtlebot


SVG Icons don't load

Informations
Browser version:
Firefox 56
OS:
Windows 10
How to reproduce the bug?
Go to https://alex-d.github.io/Trumbowyg/
The SVG icons don't show up in the editor.

See #647, I thought I had this issue too!

Solution is #634

Is it possible to use FontAwesome icons instead?

You can, you just need to set svgPath to false and code your own CSS to put your icons on each button.

My apologies, Alex. It was one of those shotgun questions you make before your first cup of coffee on a Friday morning :)
ps: loving the editor so far!


ref(proxy-2-service): append -pod to yaml

Yikes there's quite the name collision here. :grimacing:


top-level: Add a warning on deprecated aliases

Description of changes

[x] Programatically apply lib.warn on all aliases in top-level/aliases.nix
[x] Include the alias' target's pname in the warning message, if it's a derivation.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Previous attempts of this have failed because of nix-env and this may too.

I'm not sure where the PRs are, but it has definitely been tried before, may not have even been a PR but a comment.
Here's one commit https://github.com/nixos/nixpkgs/commit/5cd6c650545dbfe1d040bfbd00ad7ecc2f4f4763
and the CI for this PR fails

The warnings show in nix search and nix-env and that's one reason why we don't have this.


Nodes with different feature size

❓ Questions & Help
Hi,
let say I have a simple undirected graph made by only three nodes, where each node has a different feature-length.

How can I apply the Graph Neural Network on this graph with diff. feature-length? I know one way could be to just
pad them all to a specific length by just filling them with zeros. But is it also possible without doing this? When yes on which graph (or paper) is it done?
Thanks and happy new year in advance!

In general, this is only possible by representing the graph as a heterogeneous one. For example, you can look at these example from the OGB suite on how to handle heterogeneous graphs.
Even if you pad them with zeros, the meaning of individual features might be different. However, in your case, you might be able to represent your features as a 0/1 encoding, e.g.
x = [
   [0, 0, 1, 0, 0, 0, 0, 1, 1],
   [1, 1, 1, 1, 0, 0, 0, 0, 0],
   [1, 0, 0, 0, 1, 0, 0, 0, 0],
]

@rusty1s thanks for your reply. Well, the features are continuous (float) - the above picture was just an example :)
So that means the only possible solution would be using heterogeneous graphs. right! As far as I can see the only example using heterogeneous graphs in the link you sent, is the R-GCN, right?
I am pretty new in the field of GCNN, but it seems to me that, DGL has a specific class for hetero-graphs. Does py-geometric also offer something similar?
Nevertheless, I am working on time-series, where each node has a different number of features, so temporal info is also importent. Do you know any paper/implementation, handling this kind of networks? I could not find any!
Thanks

@rusty1s why don't we provide mask vectors like huggingface/transformers do ? By doing this we can solve a lot of problem while storing the data. I'm not sure how we'll handle the feature vector.
In the given example, we can pad and use that mask vector to identify the padded values.
x0 = [3,8,9,0] mask = [1,1,1,0],       x1 = [4,3,2,1] mask = [1,1,1,1],   x2 = [1,5,0,0] mask = [1,1,0,0]

Well, one can of course pad the input features via torch.pad_sequence, but this does not make much sense in the graph context where you expect features to have the same meaning across the feature dimension. If one wants to use sequences as input, one can always use an LSTM/Transformer as feature encoder, and input that into a GNN.
Depending on your problem, it might make sense to treat this graph as a hetero one (where you have different node and edge types with different message passing operators). It's true that DGL has a dedicated class for hetero graphs, while PyG does not. PyG expects hetero graphs to be stored in dictionaries:
data.edge_index_dict = {
  ('paper', 'cites', 'paper'): ... [2. num_edges1]
  ('author', 'writes', 'paper'), ... [2, num_edges2]
}
data.x_dict = {
  'paper': ... [num_nodes1, num_features1]
  'author': ... [num_nodes2], num_features2]

from which you then can simply call different GNN ops:
conv1 = SAGEConv((num_features2, num_features1), 256)
conv2 = SAGEConv(num_features1, 256)

out = conv1((data.x_dict['author'], data.x_dict['paper']), data.edge_index_dict[('author', 'writes', 'paper')])
out += conv2(data.x_dict['paper'], data.edge_index_dict[('paper', 'cites', 'paper')])


IP-2632: Restore photo selection count

JIRA ticket

Merge upstream changes
Fix subview diving to find "Done" button for photo selection count updates

Needs testing on iOS 10

nice! 🎉

Verified on iOS 10! Merging.


Wrong validation message on entering non numeric data in rate while creating tax rate

Bug report
Title
Wrong validation message on entering non numeric data in rate while creating tax rate
Preconditions
1. framework Version.Master

Steps to reproduce
1. step1: create tax rate and enter any character in rate field

Expected result:
The "Rate" field must be numeric and may contain decimal points
Actual result
https://prnt.sc/uur63u

Hi. Can you assign it to me?

Resolved in master.


heroku deployement crash

Problem
used one-click deployment but app is crashing
issue
The app crashes with error [91m2021/11/03 08:31:38 [error] File ./prest.toml not found. Aborting.
is there a missing step in Docs ?

is there a WA at least I need to provide API for testing


[SwiftSyntax] Add accessors for source locations and test diagnostic emission

This patch adds accessors on Syntax for startLocation, endLocation, and sourceRange. They have to take a file URL, because the Syntax tree is independent of a file.
Also add a test in the DiagnosticTest that gets the source locations of a file.

@nkcsgexi 👍

@swift-ci please smoke test

Mutation strikes again.
@swift-ci please smoke test


RocketMQ version release roadmaps?

Hi Community, I would like to know the approximate plan for the release of the next version. According to the previous release cycle, 4.9.5 and 5.0.1 should be released soon. I want to know when this can become a reality? and Proxy support for Remoting protocol is already a big feature to release as a minor version.

@Oliverwqcwrw any ideas?

We have a lot of pr since last released, Hoped you can pay attention to this question. @drpmma

@lizhimins Yes, it has been three months since the last release and we have also submitted many RIPs features. IMO, it's time to discuss the release of version 5.0.1 and 4.9.5. I hope to see the latest version released by the end of the year or early in the new year.


Fix gazebo joint collision check bug

This pull request ensures the gravity contribution is accounted for in the joint collision checking. This needs to be done since it is not stored in joint->command variable. Please have a look at #363 for more information.

@Maverobot, @gollth, since I still think this pull request fixes a critical bug, I just rebased it on the develop branch and ensured no CI errors were present. Would it be possible to merge this so I can use the upstream instead of my fork?
Your assistance in getting this pull request merged would be significantly appreciated 🙏🏻.
Thank you!


rm-ing docs, pointing readme links to deploy preview

Docs are here: https://github.com/temporalio/documentation/pull/794


Docs - not entirely clear how to compile or use with CommonJS?

I see that there's a CommonJS example as the output of the template, but when using tools like WebPack & gulp-react, I'm not sure how these templates would fit into my workflow.
Do I author a myThing.jsx and myThing.react.html?  How do I combine the two?

Hi,
Working with React and CommonJS is simple:
Lets say you have a file myThing.rt, you will compile it to javascript using the CLI
$ rt myThing.rt -m commonjs

This will result in myThing.rt.js, that you can require from myThing.js.
I recommend installing the yeoman generator https://github.com/wix/generator-react-templates
You can run it and select a commonjs project and see a working example.
Hope this helps.

What's the best way to use it via the API, not the CLI?  Since I'm using Gulp & Webpack, I'll need some direct hook with Javascript...
Thanks!

You can also use it via grunt plugin or intellij plugin.
here's an example of API usage
https://github.com/wix/grunt-react-templates/blob/master/tasks/react-templates.js

That's what I want.  Thanks!


Upgrade "Mismatched assemblies" MSB3274 to error.

Originally asked for here:
https://github.com/dotnet/roslyn/issues/5001
This warning should be upgraded to an error and fail the build. The warning is logged here.

@AndyGerlicher Shouldn't we also need to fix this?

@AndyGerlicher
Is this already taken/fixed? If it's not, I'd take and work on this issue.

@eriawan Thanks for the interest! Andy's on vacation until January. It doesn't look like there's a fix for this at the moment, and normally I'd say to go for it.
But I'm concerned about the level of breakage this could cause. Updates to VS2017 are not supposed to break any existing project. This would take projects from compiling to not compiling. I think that's ok, as long as they were guaranteed to be broken at runtime. But I'm not sure right now that that's guaranteed.
I'd like to talk that over with Andy and the team, but it's Vacation Season, so that'll take a couple of weeks.
If you feel passionate about this, you can work on it before then, but be aware that there's a possibility that we can't take the fix, if we can find customers who are not currently broken at runtime even though they get this warning for some reason.
Sorry to discourage . . . I really appreciate the offer!

@rainersigwald
Thanks for the reply. Could you elaborate more on:

But I'm not sure right now that that's guaranteed

IMHO, this update to warning is very relevant and I also need this to enforce compatibility compliant in terms of assembly references and when dealing with various different .NET TFMs.
I think I'll submit the PR in case if you and your team may accept and merge it 🙂

@AndyGerlicher and @rainersigwald ,
PR submitted. Merry Christmas and Happy holidays!

Team triage: We are worried about taking this in a patch release. Marking for the next breaking change.
For now, this warning can be made an error via
<PropertyGroup>
  <MSBuildWarningsAsErrors>$(MSBuildWarningsAsErrors);MSB3274</MSBuildWarningsAsErrors>
</PropertyGroup>


Nuki Lock unavailable after HA OS Update 10.1

Hi @all,
after updating Home Assistant OS to 10.1 my Nuki Lock is no longer available. Here is the error log:
Logger: custom_components.nuki_ng.nuki
Source: custom_components/nuki_ng/nuki.py:412
Integration: Nuki Lock (documentation, issues)
First occurred: 18:17:24 (3 occurrences)
Last logged: 18:17:43
Failed to get latest data: No available device data
Traceback (most recent call last):
File "/config/custom_components/nuki_ng/nuki.py", line 412, in _update
raise HomeAssistantError("No available device data")
homeassistant.exceptions.HomeAssistantError: No available device data
I'm running my Home Assistant OS on an Intel NUC5i5-5250U, If that matters.

Same happening to me

Not work on Home Assistant 2023.7.2

Same issue just after migration to Home Assistant 2023.10.5. Before updating, on version 2023.9.3, it was working fine

I just updated (was late in the updates), and the locks became unavailable.
I now have a banner on every entity saying : "This entity is no longer being provided by the nuki_ng integration. If the entity is no longer in use, delete it in settings"
I regret updating…
Core 2024.2.1
Supervisor 2024.01.1
Operating System 11.5
Frontend 20240207.1
Anybody have an idea how to circumvent or fix this issue ?


Translation versions

Todo:

optional outdated property in the serializer which tells the API which strings are outdated compared to the primary language
partial updates into the string field
extract before/after filters from model into service object?

Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@camallen okay so this PR starts tracking versions for the primary language translations. It doesn't yet do any diffing or tracking for foreign languages, but i think it's probably big enough and it is in a state that we can merge. So i propose another review with a view to merging this time,

Sorry, yeah every time I run into a merge conflict my editor strips out the trailing whitespace in the structure file. Should've regenerated it instead, will do


FAIR intro: fix typos

Fixed two minor typos.
I also noticed that the "edit on github" link is broken on https://training.galaxyproject.org/training-material/topics/fair/tutorials/fair-intro/tutorial.html, there's a / missing

huh how is the check passing, there's no alt text.