Epic: Rollup UX

Summary
One of the main pillars to focus on following mainnet release is how we can improve the UX specifically for rollups building on top of Celestia. For the consensus layer this predominantly resides around the "transaction" itself - how can we provide a simple and robust system for users to submit their PFBs, how can we improve the guarantees around submission, how do we provide introspection across the lifecycle of a transaction, how do we prevent spam. This is a tracking issue for Rollup UX. Obviously, it would be super helpful to get continual feedback from some of our rollup developers.
Short term targets

[ ] #1910 - Rearrange multiple txs by the same sender according to nonce to decrease the likelihood that they're invalid
[ ] #1937
[ ] #1916 - Introduce a MinGasPFBDecorator to ensure that PFBs have sufficient gas (this helps to avoid txs from running out of gas and users getting DA for free)
[ ] Nonce lanes to allow for replay protection without strict serialization. Users can submit multiple txs without having to worry about how Celestia orders transactions.
[ ] Gas refunds that mean users can safely overestimate gas without having to worry about paying too much for their PFBs
[ ] #1773 and #1546
[ ] PFB specific feegrants to support distributed rollup systems and/or better key management.

Mid term but needs further discussion / product exploration

[ ] #1621 - or more generally work towards a cohesive fee market that provides predictable, competitive and fair pricing for data availability
[ ] Publish continual data around the current minimum gas price for a transaction to get in a block. This can inform rollups if they need to increase spending.
[ ] Atomic PFBs (can submit multiple messages in a single BlobTx) #890
[ ] Use a simple secondary index instead of the kv indexer for tracking the status of transactions: In the mempool, rejected, committed etc..
[ ] Explore using gas price ranges (Users attaches the maximum price they are willing to pay for the tx to make it into the next block)
[ ] Research more thoroughly into the tradeoff between block times and block efficiency.

Long term targets

[ ] Improve single block censorship resistance through a multi-proposer protocol (potentially a DAG based consensus or usage of VoteExtensions)
[ ] Have a uniform API across all nodes (both DA and consensus) that rollups can communicate with.
[ ] Feature namespaces: subset of namespaces that have certain features that are desirable for some rollup users. This could be having a namespace nonce to avoid duplicate submission; having permissioned namespaces; some namespaces could use threshold decryption for censorship resistance
[ ] Support multiple fee tokens

This focuses just on rollup SDKs and developers. There are other classes of users: validators, infrastructure etc. whose experience using Celestia we should also look to improve.
For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

could we ever get

Support multiple fee tokens

and

EIP1559 style min fee #1621

since the min fee for two different tokens would require pricing information?


Demo link leads to "inapropriate" site

Ah i didn't renew the site license. I should remove the link.


Daly bms sleep mode causing incorrect data in MP2 gx webinterface

Describe the bug
The battery is fully loaded and the daly bms stops charging.
Shortly after it goes into sleep mode and doesn't respond on the uart interface.
In the WebInterface of the MP2 GX and on the VRM Portal wrong values are shown.
e.g the current is displayed with 20 amps but is 0 in real.
The driver log ("/var/log/dbus-serialbattery.ttyUSB0/current") shows "No reply - returning"

To Reproduce
Steps to reproduce the behavior:

Stop charging so the daly bms goes into sleep mode.
Open the log from above.

Expected behavior
I'd expect the web interface of the MP2 GX to show the correct data.
I'd expect the software to differentiate between the daly bms being in sleep mode
and the daly bms not responding.
VenusOS (please complete the following information):

Device type MP2 GX
Firmware Version v2.90

Battery/BMS (please complete the following information):

BMS/Battery type: Daly
Cells: 16
Interface: USB-RS232 UART

Additional context
Add any other context about the problem here.

The same behavior can be observed when completely disconnecting the BMS.
This is kind of a critical bug because the soc regulates the parameters for charging and discharging.
Although the Daly BMS will cut the battery when fully charged or discharged, the allowed current for charging and discharging is not updated.
I just connected the BMS to a cerbogx of a friend of mine to test the software. I'd expect my installation to stop charging while the BMS is not connected. Unfortunately it just keeps charging. Went from 61% to 69% percent without any error or something.

@transistorgit maybe you know, if this is still an issue?

Yes, I think so. There is no means of state handling employed. If the bms stops answering, the last values will be there forever.
It should be easy to solve with a timeout in refresh_data. If there isn't any new data for 1 minute, set AllowToCharge/Discharge to false.
How is it done in other bms? Wonder if it shouldn't be a base class function?

Theoretically there should already be a check, but it seems that it's not working.
https://github.com/Louisvdw/dbus-serialbattery/blob/fce00b998a929fcf7d0b75b2f4b11de4823d366a/etc/dbus-serialbattery/dbushelper.py#L322-L350

just did a real test with my dalys with branch jkbms_ble.
In both cases, unplugging USB or unplugging the serial connector at the BMS, the remote console shows correctly "Not connected" after a minute.
Until 1 minute is over the values stay frozen, that can be optimized.

created pull request https://github.com/mr-manuel/venus-os_dbus-serialbattery/pull/3
is that right? or should it go into luisvdw's repo?

It doesn‘t matter in which repo :-) it will get merged in both ways. I test it today with a JKBMS.

@transistorgit I did some testing and I have this behaviour: After 10 seconds the BMS is shown as Not connected and all values are --. In this case the charging/discharging is not blocked, since there is no BMS connected. This can be good or bad depending on the cause.
Would it make more sense to keep the driver "connected", but blocking charge/discharge and eventually let the user select/change the behaviour by config file? In this case the driver/system has to be restarted, if a BMS is removed from the device.
What are your thoughts?

yes, I had quite some error handling to do until I had fixed all Type errors. just very probable that I misses one that is now triggered with your BMS. Can you send me the log line with the line no where is crashed?
If all exceptions are handled, the behaviour should be like I wrote. And I had also no problem with redetecting the device then. This is in my view the cleanest solution.

Ok, in my case somehow ttyUSB0 gets blocked from the driver. When I disconnect from the USB port ttyUSB0 and connect it again, before the driver exited, then the devices is recognized as ttyUSB1. If I reconnect it again after the driver exited, then it's recognized as ttyUSB0 again.
I made some more changes in the jkbms_ble branch in my fork, that are merged later today with Louisvdw jkbms_ble branch:

Added: Alert is triggered, when BMS communication is lost
Added: Block charge/discharge when BMS communication is lost. Can be enabled trough the config file

We wrote nearly at the same time :P I already fixed the other errors, so none left. If the adapter does not change port, all is working as expected. In my eyes we can close this now. What do you think?


feat: aoc day 1

Current dependencies on/for this PR:

main

PR #1   👈

This stack of pull requests is managed by Graphite.


Remove duplicated registration/login APIs

Currently the spec duplicates all of the account-management APIs. There's still
work to be done here, but the complete duplication is confusing.

LGTM


IP-3383 local dockerised environment

Refactored Dockerfiles to use different files for local dev and AWS environments: no dev tool should be included in deployed docker images.
(production Dockerfiles are not complete yet)
Reorganised docker-compose file for local development.
Removed nginx: it will not be used on AWS.
The Docker-Compose cluster already includes S3, SQS and SES mocks from LocalStack, but they are not yet used by the application. At the moment, it is still using the local file system for uploaded files and RabbitMQ

I'm merging after renaming backend to worker, happy to reconsider the other suggestions at a later stage when things are less fluid


django-cms 2.3.4 fixed googlemaps plugin

This is request for the correct version of django-cms.
In db.add_column you can't have default='...%', beacuse there are problems with migration. You should have default='...px' instead.

LGTM

@justine123 thanks for this. We can merge it into 2.3.4, but it won't ever make it into a new 2.3 release.
Just to be clear though, are you saying that default='100%' causes a problem with migrations on a CharField? Or that it's not correct for rendering a Google Map? (I can't see why it would cause an issue with a migration.)

LGTM, google maps needs a fixed height

@FinalAngel merging it myself


Task Quick Pick: icon - icon only

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=224858&view=logs&j=915086b8-cfe0-5852-2b47-cd8ec7a5b7ec&t=6267af23-5fa3-5df7-0260-38941b92f2cd&l=85
1) VSCode Smoke Tests (Electron)
       Task
         Task Quick Pick
           Tasks: Run Task
             icon - icon only:
     Error: Timeout: get text content ' .monaco-editor[data-uri$="tasks.json"] .view-lines' after 20 seconds.
      at Code.poll (/mnt/vss/_work/1/s/test/automation/src/code.ts:273:11)
      at Code.waitForTextContent (/mnt/vss/_work/1/s/test/automation/src/code.ts:201:10)
      at Editor.waitForTypeInEditor (/mnt/vss/_work/1/s/test/automation/src/editor.ts:100:3)
      at Task.configureTask (/mnt/vss/_work/1/s/test/automation/src/task.ts:79:4)
      at Context.<anonymous> (src/areas/task/task-quick-pick.test.ts:44:5)

Related: #188645

The logs reveal that task is null here 🤔
https://github.com/microsoft/vscode/blob/cb38b1b567db09624b65b2f883f407c0cfed7e14/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L1359
2023-07-24 10:04:11.199 [error] Cannot read properties of null (reading 'clone'): TypeError: Cannot read properties of null (reading 'clone')
    at u (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:106785)
    at f.updateTokensUntilLine (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:102140)
    at a.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:114993)
    at c.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:109581)
    at h (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:30550)
    at y (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:46932)
    at r.m (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:640:277)
    at r.typeWithInterceptors (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench

from the trace, there's not ask here

so the typing in editor part is failing occasionally - don't think this is related to any task changes.

@hediet I think this can be closed as a duplicate of https://github.com/microsoft/vscode/issues/188645, reopen if i'm wrong


out of memory with 'netlifyctl deploy'

I just downloaded the pre-built Linux version and experimented with my site, It failed with the following log.
environment: Linux version 4.13.0-39-generic (buildd@lgw01-amd64-038) (gcc version 7.2.0 (Ubuntu 7.2.0-8ubuntu3.2)) #44-Ubuntu SMP Thu Apr 5 14:25:01 UTC 2018
it looks like some memory leak as my laptop has 8GB memory with nothing else but Firefox on while running the command.

CCCCCCCCCCounting objects: 494 total objects  ✔
RRRRResolving deltas: 3 objects to upload  ✔
UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌎UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌍UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌏UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌎UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌍UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌎UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUploading objects: 0/3 🌏UUUUUUUUUUUUUUUUUUUUploading objects  ✘
fatal error: runtime: out of memory

runtime stack:
runtime.throw(0xcb150b, 0x16)
/usr/local/go/src/runtime/panic.go:619 +0x81
runtime.sysMap(0xc6d9b10000, 0xbc860000, 0x0, 0x11bfcf8)
/usr/local/go/src/runtime/mem_linux.go:216 +0x20a
runtime.(*mheap).sysAlloc(0x11a6880, 0xbc860000, 0x1)
/usr/local/go/src/runtime/malloc.go:470 +0xd4
runtime.(*mheap).grow(0x11a6880, 0x5e42d, 0x0)
/usr/local/go/src/runtime/mheap.go:907 +0x60
runtime.(*mheap).allocSpanLocked(0x11a6880, 0x5e42d, 0x11bfd08, 0x2cd16)
/usr/local/go/src/runtime/mheap.go:820 +0x301
runtime.(*mheap).alloc_m(0x11a6880, 0x5e42d, 0x101, 0xc4205d9f10)
/usr/local/go/src/runtime/mheap.go:686 +0x118
runtime.(*mheap).alloc.func1()
/usr/local/go/src/runtime/mheap.go:753 +0x4d
runtime.(*mheap).alloc(0x11a6880, 0x5e42d, 0xc420010101, 0xc42047bc80)
/usr/local/go/src/runtime/mheap.go:752 +0x8a
runtime.largeAlloc(0xbc858f0f, 0x11a0101, 0xc42047bc01)
/usr/local/go/src/runtime/malloc.go:826 +0x94
runtime.mallocgc.func1()
/usr/local/go/src/runtime/malloc.go:721 +0x46
runtime.systemstack(0x11a4e74100000000)
/usr/local/go/src/runtime/asm_amd64.s:409 +0x79
runtime.mstart()
/usr/local/go/src/runtime/proc.go:1170

goroutine 31 [running]:
runtime.systemstack_switch()
/usr/local/go/src/runtime/asm_amd64.s:363 fp=0xc4205d7658 sp=0xc4205d7650 pc=0x454000
runtime.mallocgc(0xbc858f0f, 0xb29d40, 0x45f701, 0xc4205d7730)
/usr/local/go/src/runtime/malloc.go:720 +0x8a2 fp=0xc4205d76f8 sp=0xc4205d7658 pc=0x4109c2
runtime.makeslice(0xb29d40, 0xbc858f0f, 0xbc858f0f, 0xc420146070, 0x410c68, 0x11be250)
/usr/local/go/src/runtime/slice.go:61 +0x77 fp=0xc4205d7728 sp=0xc4205d76f8 pc=0x43ff07
bytes.makeSlice(0xbc858f0f, 0x0, 0x0, 0x0)
/usr/local/go/src/bytes/buffer.go:230 +0x6d fp=0xc4205d7768 sp=0xc4205d7728 pc=0x4d18dd
bytes.(*Buffer).grow(0xc4201476c0, 0x2cd15425, 0x506d3d)
/usr/local/go/src/bytes/buffer.go:144 +0x151 fp=0xc4205d77b8 sp=0xc4205d7768 pc=0x4d1291
bytes.(*Buffer).Write(0xc4201476c0, 0xc5f6424000, 0x2cd15425, 0x59a2a849, 0x59a2a849, 0x0, 0x0)
/usr/local/go/src/bytes/buffer.go:174 +0xd9 fp=0xc4205d77e8 sp=0xc4205d77b8 pc=0x4d1569
github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus.Entry.log(0xc4200ae140, 0xc4203a2060, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xb29a05, ...)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus/entry.go:113 +0x357 fp=0xc4205d78c8 sp=0xc4205d77e8 pc=0x504fe7
github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus.(*Entry).Debug(0xc4203a40f0, 0xc4205d7980, 0x1, 0x1)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus/entry.go:130 +0xaa fp=0xc4205d7938 sp=0xc4205d78c8 pc=0x5052da
github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus.(*Entry).Debugf(0xc4203a40f0, 0xc5c9712000, 0x2cd10b19, 0x0, 0x0, 0x0)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/sirupsen/logrus/entry.go:178 +0xef fp=0xc4205d79a0 sp=0xc4205d7938 pc=0x5058df
github.com/netlify/netlifyctl/vendor/github.com/go-openapi/runtime/client.(*Runtime).Submit(0xc420326000, 0xc42041c3c0, 0x0, 0x0, 0x0, 0x0)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/go-openapi/runtime/client/runtime.go:277 +0xbec fp=0xc4205d7b28 sp=0xc4205d79a0 pc=0x795b8c
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/plumbing/operations.(*Client).UploadDeployFile(0xc4203be100, 0xc420519860, 0xd2b0a0, 0xcd49d0, 0x0, 0x1, 0x2)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/plumbing/operations/operations_client.go:2066 +0x30f fp=0xc4205d7b78 sp=0xc4205d7b28 pc=0x806bdf
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFile.func2(0x0, 0x0)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:409 +0x5fa fp=0xc4205d7c68 sp=0xc4205d7b78 pc=0x85edda
github.com/netlify/netlifyctl/vendor/github.com/cenkalti/backoff.RetryNotify(0xc4207041e0, 0xd2c680, 0xc420704180, 0x0, 0xcfe3b001, 0xc4207041e0)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/cenkalti/backoff/retry.go:37 +0x88 fp=0xc4205d7d58 sp=0xc4205d7c68 pc=0x844d68
github.com/netlify/netlifyctl/vendor/github.com/cenkalti/backoff.Retry(0xc4207041e0, 0xd2c680, 0xc420704180, 0x0, 0xc420482f08)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/cenkalti/backoff/retry.go:25 +0x48 fp=0xc4205d7d98 sp=0xc4205d7d58 pc=0x844cb8
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFile(0xc4203be120, 0x7ff0ac42e9a8, 0xc4203a2630, 0xc4203521c0, 0xc42051df40, 0xd35500, 0xc420078140, 0x0, 0x0, 0xc4203f48c0, ...)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:386 +0x4b7 fp=0xc4205d7f80 sp=0xc4205d7d98 pc=0x85bf37
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc4205d7f88 sp=0xc4205d7f80 pc=0x456b21
created by github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFiles
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:343 +0x3a1

goroutine 1 [semacquire, 7 minutes]:
sync.runtime_Semacquire(0xc4203f48cc)
/usr/local/go/src/runtime/sema.go:56 +0x39
sync.(*WaitGroup).Wait(0xc4203f48c0)
/usr/local/go/src/sync/waitgroup.go:129 +0x72
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFiles(0xc4203be120, 0x7ff0ac42e9a8, 0xc4203a2630, 0xc4203521c0, 0xc4203be860, 0xd35500, 0xc420078140, 0x0, 0x0, 0x4ded5d, ...)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:348 +0x461
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).DoDeploy(0xc4203be120, 0x7ff0ac42e9a8, 0xc4203a2630, 0xc4203880a0, 0xc4203521c0, 0xbc3500, 0xbe7440, 0xc420440400)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:262 +0x96e
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).DeploySite(0xc4203be120, 0x7ff0ac42e9a8, 0xc4203a2630, 0xc4200a41e0, 0x24, 0xc4200a4210, 0x24, 0x0, 0x0, 0x0, ...)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:144 +0x98
github.com/netlify/netlifyctl/commands/deploy.(*deployCmd).deploySite(0xc42013aea0, 0x7ff0ac42e9e0, 0xc4203a2630, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0xd31200, 0x7ff0ac42e9e0)
/home/david/src/github.com/netlify/netlifyctl/commands/deploy/deploy.go:89 +0x62f
github.com/netlify/netlifyctl/commands/deploy.(*deployCmd).(github.com/netlify/netlifyctl/commands/deploy.deploySite)-fm(0x7ff0ac42e9e0, 0xc4203a2630, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0xc282a0, 0xc4203a2270)
/home/david/src/github.com/netlify/netlifyctl/commands/deploy/deploy.go:45 +0x69
github.com/netlify/netlifyctl/commands/middleware.SiteConfigMiddleware.func1(0x7ff0ac42e9e0, 0xc4203a2270, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0x1, 0xc4203a21b0)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:222 +0x252
github.com/netlify/netlifyctl/commands/middleware.ClientMiddleware.func1(0x7ff0ac42e9e0, 0xc4203a20f0, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0x81b82f, 0xbc3500)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:183 +0x339
github.com/netlify/netlifyctl/commands/middleware.AuthMiddleware.func1(0x7ff0ac42e9e0, 0xc4203a2090, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0x11a10a0, 0xd23250)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:128 +0x1ca
github.com/netlify/netlifyctl/commands/middleware.LoggingMiddleware.func1(0x7ff0ac3db1a8, 0xc4200a8030, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0xc4203e2570, 0xc4202b9b80)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:116 +0x1f1
github.com/netlify/netlifyctl/commands/middleware.DebugMiddleware.func1(0x7ff0ac3db1a8, 0xc4200a8030, 0xc4202bf200, 0x11be250, 0x0, 0x0, 0x0, 0x0)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:89 +0x4bb
github.com/netlify/netlifyctl/commands/middleware.NewRunFunc.func1(0xc4202bf200, 0x11be250, 0x0, 0x0, 0x0, 0x0)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:52 +0xf2
github.com/netlify/netlifyctl/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202bf200, 0x11be250, 0x0, 0x0, 0xc4202bf200, 0x11be250)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/spf13/cobra/command.go:644 +0x3db
github.com/netlify/netlifyctl/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x118f980, 0x11bdebc, 0xca05bc, 0x3)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/spf13/cobra/command.go:734 +0x2d4
github.com/netlify/netlifyctl/commands.Execute()
/home/david/src/github.com/netlify/netlifyctl/commands/netlify.go:41 +0x29b
main.main()
/home/david/src/github.com/netlify/netlifyctl/main.go:16 +0x79

goroutine 18 [syscall, 7 minutes]:
os/signal.signal_recv(0x0)
/usr/local/go/src/runtime/sigqueue.go:139 +0xa6
os/signal.loop()
/usr/local/go/src/os/signal/signal_unix.go:22 +0x22
created by os/signal.init.0
/usr/local/go/src/os/signal/signal_unix.go:28 +0x41

goroutine 5 [select, 7 minutes, locked to thread]:
runtime.gopark(0xcd5f30, 0x0, 0xca307f, 0x6, 0x18, 0x1)
/usr/local/go/src/runtime/proc.go:291 +0x11a
runtime.selectgo(0xc420052750, 0xc42009a780)
/usr/local/go/src/runtime/select.go:392 +0xe50
runtime.ensureSigM.func1()
/usr/local/go/src/runtime/signal_unix.go:549 +0x1f4
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1

goroutine 49 [chan receive, 7 minutes]:
github.com/netlify/netlifyctl/commands/middleware.DebugMiddleware.func1.1(0xc42013b3e0, 0x0, 0xc4201476c0)
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:79 +0x38
created by github.com/netlify/netlifyctl/commands/middleware.DebugMiddleware.func1
/home/david/src/github.com/netlify/netlifyctl/commands/middleware/middleware.go:78 +0x464

goroutine 30 [chan send, 5 minutes]:
github.com/netlify/netlifyctl/operations.(*DeployObserver).OnFailedUpload(0xc420078140, 0xc42051dcc0)
/home/david/src/github.com/netlify/netlifyctl/operations/deploy.go:87 +0x3b
github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFile(0xc4203be120, 0x7ff0ac42e9a8, 0xc4203a2630, 0xc4203521c0, 0xc42051dcc0, 0xd35500, 0xc420078140, 0x0, 0x0, 0xc4203f48c0, ...)
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:437 +0x56b
created by github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain.(*Netlify).uploadFiles
/home/david/src/github.com/netlify/netlifyctl/vendor/github.com/netlify/open-api/go/porcelain/deploy.go:343 +0x3a1

I have encountered a similar issue, and I think I've linked it to large files (around 100 MiB) in size.
Although I haven't sought the problem in the code, I've applied the following workarounds (by writing a wrapper bash script, which works only on Linux):

use ulimit -m 4194304 -d 4194304 to make sure that it will never eat more than 4 GiB of RAM;
use printf -- 1000 >| "/proc/${$}/oom_score_adj" to make sure that when the out-of-memory-killer runs it will hit netlifyctl and not other processes (most often a browser);
export -- GOMAXPROCS=1 -- I doubt it actually helps, but at least I hope to reduce the stress on the system under memory pressure;
export -- GOGC=5 -- make the Go's garbage collector more aggressive (it helps somewhat);
export -- GODEBUG=gcstoptheworld=1,madvdontneed=1 -- it makes Go pause when garbage collecting (which again helps with the OOM killer), and hopefully unused memory is marked as unused so the OS can skip swapping;

However, none of these measures actually solve the problem, they just delay the crash sometimes.
Luckily if you run the netlifyctl deploy command in a loop, it will eventually push everything.

I found the issue, namely the memory leak is due to the logging done in the DebugMiddleware function.  What happens:

in order to output the netlifyctl-debug.log file (which is enabled by the --debug flag, but also written in case of failure),
the logger is instructed to write the log to a buffer (see https://github.com/netlify/netlifyctl/blob/master/commands/middleware/middleware.go#L57-L66);
unfortunately one of the dependencies (I think github.com/netlify/open-api) also uses the logger to trace all HTTP calls, which unfortunately includes in the request body the original file;
thus when large uploads are involved, all the files are stored in the logging buffer;

I've made the following patch, which unless it receives the --debug flag it won't save that file, and it increases the log level to warnings:
https://github.com/cipriancraciun/netlifyctl/commit/0167fe06b5179d542060f163694f7b3f23169e0e
(I could have completely removed that buffer, but I don't want to touch the code too much...)


test diff 1 (#41758)

[skip ci]
Summary:
test
Differential Revision: D51761006

Closing as abandoned internally


Training Error

Dear Authors,
When I train this code, there is an error.

Hi, it seems that the data layer doesn't read an image successfully.

self.calib_path = "/data1/home/wyx/wam/CoDA/Data/sunrgb_d/"
self.image_path = "/data1/home/wyx/wam/CoDA/Data/sunrgb_d/", is this correct?

Hi, please refer to the source code:
https://github.com/yangcaoai/CoDA_NeurIPS2023/blob/main/datasets/sunrgbd_anonymous_aligned_image_with_novel_cate_confi.py#L73


Local stats on items are not handled correctly

Here are two examples.
If Adds 30 to 52 Physical Damage is selected then there will be no results from search. Issue is that it's added as pseudo instead of Local. Because it's a physical weapon, stat is added locally unto itself, if the same stat is found on gloves for example, then it's a global modifier (then it can be added as explicit).
Second case, is pretty much the same. 68% increased Armour is a local modifier on an armor piece. If it was amulet with #% increased Armour, then it can be added as explicit
From my last look at source code, for now it appears we just matching strings with whatever comes first, which was the reason for issue #24 since there are several stats entries that look the same, but are intended for different things.
Take a look https://www.pathofexile.com/api/trade/data/stats, there are only 18 entries that are explicit (Local) and they are either for armor (armor, es, evasion) or weapon (flat, ele, acc, poison) modifiers. So it probably would be better to look for entries ending in (Local) for weapons and armors. Same applies to crafted, fractured and implicits types.
PS: This is probably only applicable to rares, not sure about uniques.

Rarity: Rare
Damnation Song
Imperial Bow
--------
Bow
Physical Damage: 144-381 (augmented)
Critical Strike Chance: 5.00%
Attacks per Second: 1.45
--------
Requirements:
Level: 66
Dex: 212 (unmet)
--------
Sockets: R-R R G
--------
Item Level: 75
--------
20% increased Elemental Damage with Attack Skills (implicit)
--------
+38 to Dexterity
193% increased Physical Damage
Adds 30 to 52 Physical Damage
Gain 10% of Physical Damage as Extra Chaos Damage
+27 to Accuracy Rating`

===========================

Rarity: Rare
Damnation March
Titan Greaves
--------
Armour: 405 (augmented)
--------
Requirements:
Level: 68
Str: 120
--------
Sockets: R
--------
Item Level: 71
--------
68% increased Armour
Regenerate 3 Life per second
+7% to Cold Resistance
+41% to Lightning Resistance
30% increased Movement Speed

Not sure if this is the same bug, but here the mana leech doesn't show up:
Rarity: Rare
Sol Goad
Imbued Wand
Wand
Physical Damage: 48-93 (augmented)
Critical Strike Chance: 7.00%
Attacks per Second: 1.50
Requirements:
Level: 59
Int: 188
Sockets: B-B B
Item Level: 82
34% increased Spell Damage (implicit)
33% increased Physical Damage
Adds 8 to 17 Physical Damage
4% increased Fire Damage
0.29% of Physical Attack Damage Leeched as Mana
+55 to Accuracy Rating

It's not the same issue, but a bug none the less, probably warrants it's own issue. Looks like while parsing script is only looking for whole numbers, and then it fails to find anything then whole line is omitted.
That's actually two issues,

Decimals are not handled correctly
If parser for a line yield no results then it's silently omitted without any feedback.


Redesign of main view, to support both max current and max voltage.

Did this change as a reply to issue #41 Overvoltage limit protection in CC mode.
I Added support in CC mode to set an max-voltage, and split out the set-values and the meassured-values on the screen.
Johan, you really did good job, good code and well written! Just posting my branch here to show my preferences, and give feedback if you like.

Thanks for the kind words and sorry for the slow response. There are some good parts here, the font generation is superior to mine. I am however a bit reluctant to accept the PR in its entierty due to the UI changes which I think would surprise users. Also I am a but unsure of how people would react to CV and CC being merged. I will probably do some cherry picking though.

Please be my guest, just wrote this code for my own use and happy to share!
Please feel free to add the font-generator into the build-system, so its easy to start hacking on it!
I just think the combined current and voltage view, is how you use a normal (analog) power-supply, and just makes sense. But thats just up to personal preference!
Keep doing great stuff, and thanks for your contribution to the open source community!

@jimmyw Could you please post a picture of your modified UI? :-)

The font generator and font file rename has been cherry picked, thanks!

@kanflo Happy to help!


[Gallery][iOS] Material checkbox does not show checked state

Current behavior
When clicking on this checkbox:

The checked state is never appearing. This does not repro with the fluent style.
Happens on both 4x and 5x canaries. Not tested on Android.

@sakshi173 could you re-validate this issue please?

@sakshi173 to be tested on 2023-08-31 please

Thanks a lot, @sakshi173 for the verification, really appreciated.
Closing the issue


Improve errors for objects missing 'type' property

We weren't checking SDOs inside Bundles, or Cyber Observables inside Observed Data objects, which resulted in very unclear error messages (Fatal Error: 'type').

Codecov Report

Merging #59 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   91.38%   91.47%   +0.08%
==========================================
  Files          30       30
  Lines        2705     2720      +15
==========================================
+ Hits         2472     2488      +16
+ Misses        233      232       -1

Impacted Files
Coverage Δ

stix2validator/test/observed_data_tests.py
100% <100%> (ø)
:arrow_up:

stix2validator/validator.py
66.54% <100%> (+0.62%)
:arrow_up:

stix2validator/test/bundle_tests.py
100% <100%> (ø)
:arrow_up:

stix2validator/enums.py
93.89% <0%> (-1.53%)
:arrow_down:

stix2validator/shoulds.py
94.67% <0%> (+0.19%)
:arrow_up:

stix2validator/musts.py
94.32% <0%> (+0.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120c27a...458d0ce. Read the comment docs.


removing unnecessary comment

this seems to say the same thing as before, can you describe what has been improved by this change?

The comment was for a piece of code that had been moved up in the file. So,
the code it pertained to was no longer there.
Immediately following the deleted comment was a call to applyUpdate,making
it appear that the ignoring of the update was going to be handled by
applyUpdate.
On 4 January 2015 at 21:20, Dominic Tarr<EMAIL_ADDRESS>wrote:

this seems to say the same thing as before, can you describe what has been
improved by this change?
—
Reply to this email directly or view it on GitHub
https://github.com/dominictarr/scuttlebutt/pull/41#issuecomment-68661283
.

thanks, that makes merging a much easier decision. this is sometimes hard to see what is going on just from looking at the diff.

merged into 5.6.11


Ensure str value for addresses

b58check_version_byte() expects a str and I was getting errors in the registrar. Other external calls might run into similar issues.
@jcnelson please check that this doesn't break something for you.

Should be fine.  We expect strings anyway.


Failed to run on Windows 11

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
After creating an environment with this conda package, and activating it, any call to go (e.g. go version) fails with the following error:
go: cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set

Interestingly doing the same via conda run works fine.
I'm using PowerShell 7 and miniconda3.
Installed packages
# Name                    Version                   Build  Channel
_go_select                2.3.0                       cgo    conda-forge
go                        1.21.3               hf68ea12_0    conda-forge
m2w64-gcc-libgfortran     5.3.0                         6    conda-forge
m2w64-gcc-libs            5.3.0                         7    conda-forge
m2w64-gcc-libs-core       5.3.0                         7    conda-forge
m2w64-gmp                 6.1.0                         2    conda-forge
m2w64-libwinpthread-git   <IP_ADDRESS>34.697f757               2    conda-forge
msys2-conda-epoch         20160418                      1    conda-forge

Environment info
active environment : mintter-dev
    active env location : C:\Users\horac\miniconda3\envs\mintter-dev
            shell level : 1
       user config file : C:\Users\horac\.condarc
 populated config files : C:\Users\horac\.condarc
          conda version : 23.5.2
    conda-build version : not installed
         python version : 3.11.4.final.0
       virtual packages : __archspec=1=x86_64
                          __win=0=0
       base environment : C:\Users\horac\miniconda3  (writable)
      conda av data dir : C:\Users\horac\miniconda3\etc\conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : C:\Users\horac\miniconda3\pkgs
                          C:\Users\horac\.conda\pkgs
                          C:\Users\horac\AppData\Local\conda\conda\pkgs
       envs directories : C:\Users\horac\miniconda3\envs
                          C:\Users\horac\.conda\envs
                          C:\Users\horac\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/23.5.2 requests/2.29.0 CPython/3.11.4 Windows/10 Windows/10.0.22621 solver/libmamba conda-libmamba-solver/23.5.0 libmambapy/1.4.1
          administrator : False
             netrc file : None
           offline mode : False

Do you first activate the environment and then run go or is this error only happening without activation?

@xhochy This happens after activating the environment, as I mentioned in the initial message:

After creating an environment with this conda package, and activating it.

I suspect the problem is that I'm doing it through PowerShell, but the activation script that sets the GOROOT environment variable is written for CMD according to this package's recipe. So, maybe it just doesn't work under PowerShell?

This could be the issue. But I have seen very packages actually having activation scripts for powershell. Thus, I had the belief that powershell users would get the activation through CMD. Still, I'm confused that this error is popping up as we don't set GOROOT in any activation script.

I could swear I've seen something related to GOROOT in the activation script, but I can't see now :(


Show untradeable item values in bank

Show the prices of the tradeable versions to make bank value more accurate
Ex.
Verac's plateskirt 25/50/75/100 -> Verac's plateskirt price
Slayer helmet/Slayer helmet (i)/Any different colored slayer helmets  -> Black mask price
Berserker ring (i) -> Berserker ring price
Toxic blowpipe/Trident -> Same price as when they're empty and tradeable
Not sure if suggested already

Duplicate of #1045
There's' this which will resolve it: #1750


Add url param type validation.

Throws 500 when string is passed instead of a number on an endpoint with URL parameters.

Basically, add url params validation pipe in controllers.

on it @Neeraj319


throws no submodule mapping found error when npm install

it throws errors when installing it.
npm ERR! git submodule -q update --init --recursive: fatal: no submodule mapping found in .gitmodules for path 'test/testSite'

pls help, i'm going to fork your project and add some cool features.

@unhealthy Maybe you miss the .gitmodules file in the root of the project

close because inactive


datapath/config: Fix L2 addr retrieval

Previously, the config code was assuming that a netdev is L3 (i.e.,
NOARP) if its L2 addr was nil or 0.
Recently, we saw a bug report in which a user reported that an ipip
tunnel device (L3) had L2 addr of 4 bytes. This was confirmed with the
following:
    ip link add name ipip1 type ipip local <IP_ADDRESS> remote <IP_ADDRESS>
    cat > /tmp/main.go <<EOF
package main

import "fmt"
import "github.com/vishvananda/netlink"

func main() {
	link, _ := netlink.LinkByName("ipip1")
	fmt.Println(link.Attrs().HardwareAddr)
}
EOF
    go run /tmp/main.go
    0a:00:00:03

Fix this by making sure that the L2 addr is 6 bytes long. If it's not,
then assume that the device is of the L3 type.
Reported-by: @sepich
Signed-off-by: Martynas Pumputis<EMAIL_ADDRESS>Fix #18828

/test

The GH Action CI failures are unrelated to the PR, marking ready-to-merge.


RFU Corrupting my Roblox installation and causing crashes on startup

Describe the bug
I was just hopping along, using RFU, then one day, Roblox updates, RFU console shows up telling me there was an error caused most likely by a new roblox update, and now even after I close RFU, delete the file, Roblox doesn't show up. Sometimes it has a crash, other times the process continues running in the background and has to be taskkilled. I have had so much frustration with this, uninstalling Roblox, and deleting every roblox file I could find. Nothing worked. I tried contacting Roblox support (they were useless, I had to wait a full day at at time only for them to tell me to do something I had already done). I finally fixed it by completely reinstalling Windows. That's now I isolated the problem. As soon as I loaded up RFU, it did the same thing.  I just don't understand why when I delete everything, it still is corrupted.
To Reproduce
Steps to reproduce the behavior:

Install RFU
Launch Roblox.
See error

Expected behavior
I expected Roblox to launch.
Screenshots
Nothing to screenshot. No errors, nothing.
Desktop (please complete the following information):

Version 5.4.5

If RFU isn't running, then it can't do anything to your game. RFU also does not modify files, only the client's memory. There is something else going on here that isn't related to me.
Also, if it's erroring, it isn't doing anything at all to your Roblox client. It's backing out of it because it can't edit the memory.

Ah, I see. Any idea how I might fix it?
Thanks for the quick response btw :3

Best I can think of is to uninstall it from Control Panel/Settings/whatever it is now on Windows and then reinstall from the website again.

I already did that but thanks anyway.

You could also try blitzing the files from %localappdata%/Roblox to do a clean reinstall, in case it leaves anything behind. Beyond that, I'm not sure.


MRG: Fix bleeding-edge library bugs

Since SciPy 1.2.0 just came out and NumPy 1.16.0 is in RC status, I updated all my libs locally and hunted down errors. This PR thus (in three separate commits):

Fixes a bug with how we warm-started a sklearn var (we shouldn't ever set clf.coefs_ = None, sklearn can't handle this anymore). I also fixed PEP8 errors while in the file.
Works around an obscure scipy.io.savemat bug when subselecting fields from a structured array in test_eeglab.py. I also fixed PEP8 errors while in the file.
Unifies how we deal with matplotlib tests. I noticed mine had been horribly slow for some time. Turns out it's because I added interactive=True to my matplotlibrc. We now use a package-wide pytest fixture to set matplotlib params. This allows us to stop nesting our plt imports in tests, and no longer need matploltlib.use at the top of every test file that has viz tests. This makes our code more DRY and lowers maintenance and new-contributor burden! (I am really starting to appreciate all that pytest brings to the table.)

Turns out that the "fix" for sklearn master does not work on the latest release, so I'll revert that change and fix sklearn directly instead.

https://github.com/scikit-learn/scikit-learn/pull/12844

@larsoner we had this conversation in the past that matplotlib should not be a hard dep of mne:
https://github.com/mne-tools/mne-python/commit/14ab6b69b4738007cafca005300df57139089857#diff-d859f370c264e1ee2bcb22eefd2c5c2d
does this PR change this?

No, just a dependency to run tests as usual

LGTM
ok for you @massich ?


[Button] Update styling

Icon size and spacing in button needs to be changed to correspond to design:

icon size should be 24x24 (maybe just add padding since we don't want to make icon bigger, but rather the icon container)
-margins should be 8 between icon and button (currently 16 from button padding, so maybe add -8 to the icon) and 4 between icon and text

design updates, reopening


Re-written captions for LAION400M

Hey, thanks for your great work and releasing the pre-trained models. I am interested in the re-written captions for LAION400M -- I see you've uploaded the re-written captions for CC3M/12M and Redcaps datasets, I was interested in whether you are also planning to release the exact re-written captions used for the LAION400M dataset? Thanks!

Hi, @vishaal27 ,
We will try to release that, please stay tuned.

Thanks for your great work! When will Re-written captions for LAION400M release?

Hey @HobbitLong @LijieFan are there any updates on this? :)

Hi, would also be interested in this


Added dataset Makhzan

Need help with the dummy data.

The only CI error comes from
FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow

which is not related to your PR and is fixed on master.
You can ignore it

@lhoestq I've made the changes. Please review and merge.
I have a similar PR https://github.com/huggingface/datasets/pull/1562 for another dataset. I'll incorporate your comment about sorting and reducing dummy dataset size there.

The CI raises an error FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow but it's not related to this dataset.
This issue is fixed on master

You did all the work ;) thanks
merging since the CI is fixed on master


[#7] More Tidy 5e Sheet integration

#7
Adds integration for item sheet name and rarity dropdown colorizing.

I thought I had it, but I missed something. One moment.

Ok, I'm all good to go, now.


Support file storage in mongodb

Currently, we can't store images/etc in the mongodb. This will be needed for sure later
Proposed initial solution:

enable GridFS in ALab collections by default. This should scale for some time, but in ~years timeframe present performance issues in our mongodb

Longer-term solution:

link blob storage (Google bucket, AWS EC2, etc) to our database. Raw files uploaded to blob storage, key stored in mongodb. This requires another service + a data schema, + updates to all our surrounding code. Maggma can provide a wrapper to simplify this implementation.

This would be useful for SEM and sample images.


Is Tracer.4NLog.Fody the release version?

Environment

Tracer.4NLog.Fody 3.3.0
Fody 6.1.1
NLog 4.7.0
BenchmarkDotNet 0.12.0

Situation
I'm testing Tracer.4NLog.Fody by BenchmarkDotNet.
It couldn't be tested.
BenchmarkDotNet explained the reason for the failure.
// Validating benchmarks:
Assembly ConsoleAppTracer which defines benchmarks references non-optimized Tracer.NLog
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.With(ConfigOptions.DisableOptimizationsValidator)'.

it was a debug version, the 3.3.1 is release version now.

thank you for your consideration.


Add support for excluding pages

This PR resolves #58
First time working with this codebase, feedback is appreciated :wink:
I wasn't sure about the .pot file. Do I need to change something there?
Visuals

Off-topic
I noticed that 'true' === $settings['is_self_hosted_analytics'] is being used but for me, it wasn't 'true' but '1'. This also broke self-hosted support in my setup. Is it a bug?

When this is merged can it be back-ported to 1.2 or is 1.3 ready to be released soon?

thanks for your contribution @dserv-nh! no updates at the moment unfortunately. we plan to merge this for the next major version of the plugin but i cannot make any promise on when that will be. we have limited development resources so things take time.

np! someone will need to review it still. currently our developers are focused on fixing this bug https://github.com/plausible/wordpress/issues/72

@mehul0810 maybe you can check this PR also? :)


Fix 'String statement has no effect' issue in Math\roman_numeral\roman_numeral.py

CodeFactor found an issue: String statement has no effect
It's currently on:
Math\roman_numeral\roman_numeral.py:14

The string statement holds the Roman Numeral. So it has effect.

Thank you for pointing this out!
Closing this issue.


Connect to unix socket

Please review and merge the connect_to_unix_socket branch. It adds support for connecting to memcached using a unix socket.
The user must use a full pathname (must begin with a slash character: '/') in place of the "host:port" pair argument to Dalli::Client.new method for connecting to a unix socket.

@r-stu31 UNIX sockets were supported in previous versions of Dalli, but support was dropped with 2.x with premeditation

@dfens Thanks for the info. Could you please share a link to the discussion? I'd like to know the exact reasons, why a feature like this gets in the developers way.

@r-stu31 you can still use 1.1.5. some discussion was there https://github.com/mperham/dalli/issues/273 , if you want to force this topic my advise would be to discuss it with @mperham

I don't maintain Dalli; you are welcome to reopen the discussion with Peter.

On Feb 25, 2015, at 02:03, Paweł Mikołajewski<EMAIL_ADDRESS>wrote:
@r-stu31 you can still use 1.1.5. some discussion was there #273 , if you want to force this topic my advise would be to discuss it with @mperham
—
Reply to this email directly or view it on GitHub.

@petergoldstein Hi, I'd like to reopen the discussion about a support for unix sockets in Dalli with you, as was suggested by @mperham.
Do you also maintain the idea that Dalli should not support unix sockets ``Because it was a support hassle. People didn't understand that sockets are limited to localhost.'' [#273, @mperham]? Thanks.

@r-stu31 I'm happy to reopen the discussion.  I think @mperham's point about support is well-taken a a general guideline for features, but at the same time I'm not sure whether I agree that this particular feature shouldn't be supported by Dalli.
Some pros in my mind:

Dalli is a driver for memcached, and it seems natural for Dalli to support the network interfaces that memcached supports
It is not feasible for a developer to extend Dalli to provide this support - it's too fundamental to the library

Some cons:

Minimal demand from the userbase - the 2.x branch has been out for a long time, and there hasn't been much clamor for this feature that I'm aware of.
As @mperham notes, there's a user complexity burden here - I'd want any PR including this functionality to include suitable documentation that would be clear to a novice user.

I'm in the middle of a few other things at the moment, but I'll give this a more detailed look this weekend and follow up then.

So on balance, I'm inclined to re-add this functionality.  Before I do, I'd like to see some minor improvement in the documentation.  Currently the updated doc reads
For connecting to a unix socket, use a full pathname (must begin with a slash character: '/') in place of the "host:port" pair.
I'd prefer something more along the lines of:
Dalli also supports the ability to connect to Memcached on localhost through a UNIX socket.  To use this functionality, use a full pathname (beginning with a slash character '/') in place of the the "host:port" pair in the server configuration.
@r-stu31 Can you update the docs and squash to a single commit?  Thanks.

@petergoldstein Please clarify: do you want me to squash all the commits to a single commit (i.e. also squash the commit Don't accept "[]" as a hostname. Use grouping without capturing in the regexp where suitable. Add test. to the commit Add support for connecting to memcached using a unix socket ...) or do you want me to squash only the minor improvement in the documentation to the commit Add support for connecting to memcached using a unix socket ...? Thanks.

@r-stu31 Just squash everything to a single commit.

@petergoldstein Done.


Create quests.json

@mcdohl can u review this

@hufuhufu if u want review this :)

welp, i said to send me the file first before making pull request :/

ah don't worry, I'll let @McDohl review first before merging

gonna use #322 to avoid conflicts


Lazy nil value call of 'inlay_hint'

Hi! Getting error after fresh install of go.nvim via lazy.nvim.
Error getting on opening .go files:
Error executing vim.schedule lua callback: ...s/ysomad/.local/share/nvim/lazy/go.nvim/lua/go/inlay.lua:312: attempt to call field 'inlay_hint' (a nil value)
stack traceback:
        ...s/ysomad/.local/share/nvim/lazy/go.nvim/lua/go/inlay.lua:312: in function 'cb'
        vim/_editor.lua:325: in function <vim/_editor.lua:324>

Neovim version:
$ nvim --version
NVIM v0.10.0-dev-592+ge0453d7f5-Homebrew
Build type: Release
LuaJIT 2.1.1697887905

Lazy config (default from readme)
return {
  "ray-x/go.nvim",
  dependencies = {
    "neovim/nvim-lspconfig",
    "nvim-treesitter/nvim-treesitter",
  },
  config = function()
    require("go").setup()
  end,
  event = {"CmdlineEnter"},
  ft = {"go", 'gomod'},
  build = ':lua require("go.install").update_all_sync()' -- if you need to install/update all binaries
}

This looks like the nvim nightly is too old. Would you change to a more recent version?

I don't think I can, it's recent version from head installed via homebrew

I think it has been there for months

Alternatively, you can use nvim 0.9.x release version

Checking now

With release version it works


karma API number of active alerts returns null

When there are 0 active alerts, the API returns null. It would be more relevant to return 0 instead of null. Null would be expected if for example no Alertmanagers or metrics available.
Thank you for the great work.

Can you share some example? I'm not entirely sure which field you're talking about. Thanks

Thank you for the fix. Look forward to testing it out.


SetItems functionality

@lu4 Are you cool if we close this PR, since it's pretty out of sync with master? I think we should have this method, since localForage does, and maybe even refactor setItem(array) to use this under the hood. Also, looks like something didn't minify the dist/angular-localforage.min.js correctly, so that would need to be fixed as well.


Can't Build

I'm getting "Can't process file Forms\XXXXXXX.resx due to its being in the Internet or Restricted zone or having the mark of the web on the file. Remove the mark of the web..."
Any build instructions would be appreciated.

I assume you downloaded the zipped source. Unless you have made changes to the code I recommend you delete everything you downloaded and download the zipped souce again.
Then you right-click it in FIle Explorer and click Unblock. When that is done you extract the files and build them using a late version of VS 2017 or VS 2019.
As an alternative to the above you connect to the source on GitHub using a git client. That way it is easier to always have the latest source code. But it is more complicated.

Yes, I pulled the zip file unzipped and tried to compile in vs2019.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Erik Mogensen<EMAIL_ADDRESS>Sent: Sunday, September 8, 2019 2:25:37 PM
To: paolosalvatori/ServiceBusExplorer<EMAIL_ADDRESS>Cc: Keith Ralston<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [paolosalvatori/ServiceBusExplorer] Can't Build (#372)
I assume you downloaded the zipped source. Unless you have made changes to the code I recommend you delete everything you downloaded and download the zipped souce again.
Then you right-click it in FIle Explorer and click Unblock. When that is done you extract the files and build them using a late version of VS 2017 or VS 2019.
As an alternative to the above you connect to the source on GitHub using a git client. That way it is easier to always have the latest source code. But it is more complicated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/paolosalvatori/ServiceBusExplorer/issues/372?email_source=notifications&email_token=AAHZELCS26XYAOOLUVU23TDQIVGTDA5CNFSM4ITIMPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FXPXQ#issuecomment-529233886, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHZELGU3B3X52W3Y7G4BC3QIVGTDANCNFSM4ITIMPPA.

But did you unblock it?

Any news on this issue?

Closing this issue as it has not been active for a month.


Feature trigger installation of older / unwanted version of packages, i.e. rust install lldb default for ubuntu even when higher version installed

This is not particular to rust feature, but I have a docker image using clang-18, lldb-18, etc.  The default for Ubuntu 20.04 is clang-10, lldb-10, etc.
When I add the rust feature I get the wrong version installed because apt install lldb doesn't seem to be aware that lldb-18 already met that requirement.
I think this is more an apt issue than a devcontainer but I am hitting this issue most with devcontainer features since they are not aware of the pre-existing installation.
One potential solution is to have a LLVM version variable added to rust so that it tries to install the desired version (18 in this case) instead of the default lldb.
Another option would be for rust not to  install lldb if not requested.
I was wondering if there was a solution at the apt level where I could tell apt that "lldb" is same as "lldb-18" as to preven this for non llvm recipe as well if I detect similar issue.

I could also copy the rust feature as a local feature to my image to control the llvm version being installed, yet I may not be the only one having this issue which results in bigger image size than required.

Hi 👋
Thanks for raising this issue, I can understand that apt reinstalling a package (which sometimes leads to downgrading) can be super problematic.

One potential solution is to have a LLVM version variable added to rust so that it tries to install the desired version (18 in this case) instead of the default lldb.
Another option would be for rust not to  install lldb if not requested.

These are great solutions, but I think we should avoid adding Feature options for such trivial purpose unless we think there's no other solution to fix it.

I was wondering if there was a solution at the apt level where I could tell apt that "lldb" is same as "lldb-18" as to preven this for non llvm recipe as well if I detect similar issue.

This makes sense to me, and I agree we should find a solution at a Feature level to avoid such downgrades.
In the meanwhile, @ykoehler would it be possible to take advantage of apt-mark hold command? I believe adding the following command 👇  in your Dockerfile should stop apt manager from reinstalling lldb and downgrading it.
sudo apt-mark hold lldb-18

Let us know if this works for you, in the meanwhile I will look into possible solutions to fix at Feature level.


Open panes with a specific profile

You can only open a pane with the default profile
I left space for adding support for opening a specific pane, but it didn't really seem like there was a good keychord for doing this currently. Maybe if we added support for multi-key keychords, then it'd make more sense

There are few options (inspired by i3)"

Popup Dialog:

Specifig key combinatin will trigger a popup dialog with all profiles, where user can select specific profile.

Ability to rearrange tabs with key combinations (inclusive ability to transform tab into a tile in specific window)
i3 way: enable specifyc tiling mode (vertical/horizontal), then DMenu like: just search for specific profile (or even a specific command, which can be executed in specific profile)...


Updated CoAP.NET for Visual Studio 2015

These changes enable Visual Studio to build all example projects.

Thanks very much~ Very sorry for the late response. I'll merge and fix the ci state as soon as possible.

Hi @longshine
is the project still active?


:latest Server-Version doesnt work.

Describe the problem
After deploying the container is up and running, but nothin is shown
Error code in FF is
¼¹{"translate":"disconnect.genericReason","with":["Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: Index 69 out of bounds for length 1"]}
Container definition
version: "3"

services:
  minecraft:
    image: itzg/minecraft-server
    ports:
      - 25565:25565
    environment:
      EULA: "TRUE"
    tty: true
    stdin_open: true
    restart: unless-stopped
    volumes:
      - /opt/dockerfiles/minecraft/data:/data

Container logs
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 6 1000 1000 4096 Jan 28 18:41 /data'
[init] Resolved version given LATEST into 1.18.1
[init] Resolving type given VANILLA
[init] server.properties already created, skipping
[init] Checking for JSON files.
[init] Setting initial memory to 1G and max to 1G
[init] Starting the Minecraft server...
 For help, type "help"
[19:00:32] [Server thread/INFO]: Starting remote control listener
[19:00:32] [Server thread/INFO]: Thread RCON Listener started
[19:00:32] [Server thread/INFO]: RCON running on <IP_ADDRESS>:25575```

OK - it was a client issue....
Sorry fot that

@logg-sar hi there. Could you please elaborate on the client issue? I tried running the server behind NGINX reverse proxy and everyone gets a similar issue
Internet Exception: io.netty.handler.codec.Decoder.Exception: java.lang.IndexOutOfBoundsException: Index 84 out of bounds for lengh 5
regardless if they use an official or a 3rd party launcher.


Is this project abandoned?

Is this project still under active development or has it been effectively abandoned? I see PRs not getting merged and issues don't have responses which is a bit sad.

I've been wondering too due to the absence of recent activity. Maybe a good candidate for https://clj-commons.org/ ?

I'm also wondering the same. aleph has been fantastic at our high throughput needs.
There are a few maintenance items that would be nice to address, for example upgrading netty deps that have security vulnerabilities.

Hi, I'm sorry I haven't given this project much attention over the last few years.  Since I no longer work at a company where this is a foundational piece of tech, I can't do maintenance during my typical work day, and more generally it's not on my mind nearly as often.
The original plan was to hand things off to @kachayev, but he also started working at a new job where Aleph isn't in use.  If someone else would like to volunteer to maintain the project, I'd be happy to speak to them.  Otherwise, I'll try to at least remain up-to-date on Netty releases, and think about what would be required to reach a "stable" 1.0 release that addresses all known issues.

@ztellman thank you for the update, I totally understand.

Thanks for the update @ztellman . I definitely understand your situation.
I would love to help in maintaining Aleph as this is clearly an important element of clojure ecosystem. But I do not feel knowledgeable enough to carry this burden alone. I've only surfaced Netty, so while I can help review clojure code I'm still having a hard time figuring out how everything works.
If I understand your idea within #441 was to find a single person to take the lead on the project. I am wondering if, given the current situation, a group of people would be a better fit. What do you think?

As Zach have already mentioned, I changed my job last year. Even though I had been enjoying contributing to the project for quite some time, nowadays I don't use Aleph (I barely work with any networking tech at all). More significantly, I don't use Clojure at work and, unfortunately, I don't have enough time to stay in touch with the community (or at least to track recent changes and events). I would be more than happy to help push some of my recent PRs to a finish line, those with bug fixes or comparably small improvements. Large PRs with significantly new functionality should be probably "frozen" as of now to avoid introducing new issues or unstable behavior.
@ztellman do you have a specific plan (or ideas) about 1.0 version (what should be merge or what is missing)? I can review my own unmerged PRs and point out those that are good candidates to be included into the next stable release.

Thank you both @ztellman, @kachayev for the countless hours to make aleph where it is today. I have the same sentiments as the other folks here: maintainers have no obligation to anyone.
I also have the same sentiment as @rborer. I'd love to help out but I've only started scratching the surface of netty.

Thank you @ztellman & @kachayev

My company relies on Aleph. I would be be interested in participating.

@ztellman do you have a specific plan (or ideas) about 1.0 version (what should be merge or what is missing)? I can review my own unmerged PRs and point out those that are good candidates to be included into the next stable release.

I would need to get back do a review to get back up to speed on all of this.  If you want to add a 1.0 label to any PRs that you think are obvious candidates to include, that would be very helpful.

@ztellman Sure, will do!

Just wanted to add my voice to the list of people who would be very interested in helping out, with the huge caveat that I would need to do some serious learning about Netty and all of that, but I would definitely be prepared to do that as where I work we do all our system / infrastructure programming in Clojure, and that means APIs and Aleph has served me very well in the past on that front...  I am pretty sure that I could make a case for contributions to this to be a part of my working life, as long as I was not trying to carry it on my own.

Is it perhaps an idea to talk with the people of clj-commons to see if that’s an option? I’m fairly certain both aleph and manifold would qualify, and it would provide a more community driven maintenance model for these projects. In my opinion these libraries are one of a kind, and heavily depended upon in many projects.
If there’s anything I can do to help, let me know.

That sounds like a decent idea, I'll reach out to the clj-commons folk and see what they think.


Create burger.html

What the program do ?
It displays a stylized cheeseburger with tomato, lettuce, and meat.
In what programming language it is written?
HTML/CSS

Edit: original file had an open comment.


[community] Add Spark<EMAIL_ADDRESS>

/cc @SamiSousa
So in 0.3.4 the spark operator should use the WATCH_NAMESPACE

After some testing I've found that the operator does not support the All Namespaces installMode. The operator only finds CRs created in the same namespace as the operator in this install case.

@alecmerdler
After testing the operator I found that when SparkCluster CRs are created, the operator acknowledges the CR creation and creates the appropriate resources for the cluster. However, this isn't reflected in the UI when a CR is selected, i.e. selecting a SparkCluster CR in the UI and checking under "Resources" shows the text "No Resources Found" even though the resources exist.

@Jiri-Kremser Is this still in progress? Let me know if there's anything I can do to help.

@Jiri-Kremser Any updates on this? Thank you!

@Jiri-Kremser Updates?

I will close this for now, since there are no updates since a long time.

Sorry, I was on long PTO. np with closing the PR, I will open a new one with 0.3.7 where the All Namespaces installMode should be aligned with OLM


[TR#12] Button Revisions

Task
TR #12
Why?
Figma designs have been made and the current buttons do not match them.
What Changed

[X] Remove existing secondary style
[X] Make btn be what secondary was
[X] Restyle all buttons to reflect Figma
[X] Add btn--icon-with-label modifier for a stacked button with icon
[X] Add warning button
[X] Change default button size to large
[X] Add btn--active for an active state
[X] Remove btn--outline as a modifier
[X] Update hover color for all states. Notably, the .btn shows the primary color on hover or active state.

Sanity Check

[X] Have you updated any usage of changed tokens?
[X] Have you updated the docs with any component changes?

[X] Have you tried building the css?
[X] Have you tried building storybook?
Do you need to update the package version?

Screenshots

 Buttons

 Button Group


Compact Line Numbers: Combine breakpoints with linenumbers

Compact Line Numbers
Combine the breakpoint column and linenumber column in a tasteful way, leave the code folding column as a natural space between the line numbers and the code.
Context
Currently there is three columns on the left handside of a code pane.

These columns show three pieces of information:

Breakpoints (maybe more?)
Line numbers
Code folding

Splitting these into 3 columns makes sense as a default,
but it uses a lot of screen real-estate, especially when using split panes.
Relevant Existing Settings / Workarounds
These allow for more compact line numbers and are useful to know about,
however they require the compromise of removing information.
"editor.lineNumbers": "on", // or "off"
"editor.lineDecorationsWidth": 0, // undocumented. 0 is too small, but just to show what is possible.
"editor.glyphMargin": false,
"editor.folding": false,

Best Hope
To be able to see breakpoints, linenumbers, and code-folding indicators,
but in a compact way that is economical with screen real-estate
Idea for implementation
It might be possible to combine the three columns into a single "compact line numbers" column.
Breakpoints and code-folding are less constant, and I think they could be expressed by variations of the line number cell.
Examples of what I mean:

A breakpoint could be a red line number. OR
A breakpoint could have a red circle behind the line number.
Code folding could be done underneath the line number (imagine the linenumber cell becomes a vertical stack with the line number and then the code fold, either sharing space equally, or with some tasteful difference in size)
Only combine the breakpoint and line numbers, and leave the code folding as a separate column (as it works quite nicely as a natural space between the code and the line numbers, which is probably desirable.)

@isidorn do we already have an issue for this? I can't seem to find it

I'm not aware of an existing issue and we have no intention or cycles to change this.


Service config updates

Fix a bug relating to service config #175
Update version and properties setup. Please do a mvn clean install after updating versions from now on. The properties file will get updated automatically.

Coverage increased (+0.09%) to 85.827% when pulling 34ccd8783beddcc972211aa43ee15778d49223d6 on scottmo/serviceConfigUpdates into 8c35b1e4be97dbadbdb5d54952780e899d8bde6a on master.

Changes Unknown when pulling c0dd35f93c19037866c3afc4cec20c51e1c26438 on scottmo/serviceConfigUpdates into ** on master**.


fix(freespace_planner): can't stop before blocking obstacle in parking#980

Description
To close https://github.com/autowarefoundation/autoware.universe/issues/980.

This PR modifies stop trajectory function in freespace planner. Current stop trajectory  is only one point of current pose which will not be used in motion velocity smoother.  Make stop trajectory points equal to current trajectory points with zero velocity  can successfully be optimized in motion velocity smoother and executed by control module.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 @shmpwk would you review this PR?

@alanmengg Could you check CI test of semantic-pull-request and DCO?

I've fix the CI test of the check

Could you exclude these commits?
517a23c3285cb9d83047b8671d3291f30080e270
515eb22ef1e865af49dd961316045df40e0d106c

@alanmengg Could you exclude these commits? 517a23c 515eb22
ok, I think now I have excluded them.

@TakaHoribe
Could you please approve it as a code owner for merging?

@TakaHoribe friendly pin.


MySQLi sane reconnect

MySQLi ping will ignore reconnect flag with the mysqlnd driver which is a standard these days. Even if the ping succeeds it is not guaranteed that the connection is working. In my experience you cannot rely on ping. The only sane way to reconnect to the database is to close it and then bring it up again.

I wasn't aware of that. Obviously been a while since I had a need to use it :) Did a little research and verified that you're correct and it won't be changing:
https://bugs.php.net/bug.php?id=52561
Additionally, the automatic reconnect was considered dangerous since state changed in the process, including transactions, sessions, etc.
The only 2 valid solutions I see are:

what you've done here, but that would require a giant warning in the docs
drop the ping method altogether. However, it appears to still be valid for other databases.

So, I guess that leaves us at option 1. Please provide updates to the docs for this special case and I"ll merge.

I was busy lately, but now I have added a note to the documentations.

No worries. Thanks.


$0 points to the resolved path when using Process.run() to call a symlinked shell script without runInShell: true

I noticed a surprising behavior when launching a shell script with Process.run() or Process.start() without using runInShell: true. The behavior is different when the launched executable is a shell script, or an ELF binary.
If the executable being called is an ELF binary, argv[0] will be the same as the executable parameter that is passed to Process.run(), but if the executable being called is a shell script, $0 will be the resolved full path (and if it's a symlink, the full path of the original file).
This is only reproducible on Linux.
Reproduction
To reproduce, create a shell script original.sh
#!/bin/sh
echo "\$0 = $0"

Make it executable, and create a symlink that links to original.sh
$ chmod +x original.sh
$ ln -s original.sh symlink.sh

For comparison, create another program in C test.c
#include <stdio.h>
int main(int argc, char** argv) {
  printf("argv[0] = %s\n", argv[0]);
}

Compile it and create a symlink as well:
$ cc test.c -o original
$ ln -s original symlink

Create this Dart script:
import 'dart:io';

Future<void> main(List<String> args) async {
  final result = await Process.run(args[0], args.sublist(1));
  print(result.stdout);
}

And use it to launch the four executables we have: (case 1)
$ dart launch.dart ./original.sh
$0 = /some/absolute/path/original.sh

$ dart launch.dart ./symlink.sh
$0 = /some/absolute/path/original.sh

$ dart launch.dart ./original
argv[0] = ./original

$ dart launch.dart ./symlink
argv[0] = ./symlink

The behavior changes when we add runInShell: true: (case 2)
$ dart launch.dart ./original.sh
$0 = ./original.sh

$ dart launch.dart ./symlink.sh
$0 = ./symlink.sh

$ dart launch.dart ./original
argv[0] = ./original

$ dart launch.dart ./symlink
argv[0] = ./symlink

Expected behavior
Case 1 should have the same output as case 2.
Prior discussion and analysis
Posting part of the discussions we had in: https://chat.google.com/room/AAAAS7MyFlc/mrhl1qscUoM
From @natebosch:

Unfortunately for scripts, the caller's argv[0] gets lost in the indirection to the shebang interpreter, which instead ends up setting $0 to the filename argument it's interpreting.

https://stackoverflow.com/a/50281509/374798
Detailed explanation of argv[0] differing from $0 based on how it's executed within a shell: https://stackoverflow.com/a/37369285/374798
From @chingjun:
I've found and successfully replicated the issue in C++. It is a Dart quirk. And I want to discuss that maybe this should be considered a bug in Dart, and this maybe(?) explains why most of the Process.run() calls I've seen almost always use runInShell: true.
So this line here calls execvp to launch a process: https://github.com/dart-lang/sdk/blob/main/runtime/bin/process_linux.cc#L512
execvp takes two parameters, first parameter points to the binary to be launched, and second parameter points to const char **argv that should be passed to the program. For this discussion, let's stick to the variable name that Dart uses: execvp(realpath, program_arguments_)
The problem is that, prior to calling execvp, the VM calls FindPathInNamespace to resolve the filename, and use that as realpath. In this case realpath will be set to the resolved filename of the binary being called, instead of the executable parameter that the user passed in.
Here onwards, the behavior diverges whether it's a shell script or a regular program, and I think the behavior can be explained by the stack overflow post that Nate posted. (Note: https://stackoverflow.com/a/50281509/374798 and https://stackoverflow.com/a/37369285/374798)
If the launched binary is a shell script, echo $0 will output realpath. And when the launched binary is a ELF binary, argv[0] will be program_arguments[0].
I don't fully understand why Dart VM needs to resolve the filename prior to calling execvp. Following the trace led me to https://github.com/dart-lang/sdk/issues/30971 and https://github.com/dart-lang/sdk/commit/d0295c873c906567d0739a906950874380bafdbb, which seems to be added for Fuchsia.
Anyway, I feel like we should either:

Change this back to call execvp with path_ instead of realpath, or
Discourage using Process.start and Process.run without runInShell: true.

For comparison:
Implementation on linux: https://github.com/dart-lang/sdk/blob/main/runtime/bin/process_linux.cc#L512
Implementation on mac: https://github.com/dart-lang/sdk/blob/main/runtime/bin/process_macos.cc#L481

Sorry this was a while ago, but IIRC when using the default namespace there shouldn't be any need to resolve the path names. When using a non-default namespace, it has to be verified that the resolved path doesn't escape the namespace.

Sorry this was a while ago, but IIRC when using the default namespace there shouldn't be any need to resolve the path names. When using a non-default namespace, it has to be verified that the resolved path doesn't escape the namespace.

Thanks.
Does that mean https://github.com/dart-lang/sdk/blob/main/runtime/bin/process_linux.cc#L455 could be modified as
if (namespc_ == nullptr || strchr(path_, '/') == nullptr) {
   ...
}

I think so, but instead of a null check, I think Namespace::IsDefault(namespc_) should do the right thing.

https://dart-review.googlesource.com/c/sdk/+/345320


1385 update tutorials using eodag cube

Updated tuto_cds and tuto_ecmwf
Ref #1385

Please review search part in cop_cds tutorial:
* request for variable temperature

* print in if is not executed but should be according to comment

* in first phrase two use case**s**

In ecmwf tutorial it still says "None product" after the first code block.

@jlahovnik I have pushed the requested changes to cop_cds tutorial.
Regarding ecmwf tutorial, I always get a search_results.number_matched with a None value, even if I reduce the search parameters to just the product name. Any idea what could be wrong?

@jlahovnik I have pushed the requested changes to cop_cds tutorial.
Regarding ecmwf tutorial, I always get a search_results.number_matched with a None value, even if I reduce the search parameters to just the product name. Any idea what could be wrong?

Try to add count=True to the request.

@jlahovnik I have pushed the requested changes to cop_cds tutorial.
Regarding ecmwf tutorial, I always get a search_results.number_matched with a None value, even if I reduce the search parameters to just the product name. Any idea what could be wrong?

Try to add count=True to the request.

It worked, thank you!

@jlahovnik I also fixed the mars request in the ecmwf tutorial and a typo in providers.yml on the product origin


Adding sensor config files

Adding board and vehicle configuration files for sensors, so that upon cloning the repository and running the smartcar sketch, the sensors are able to function.
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[ ] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

For some reason the smartcar file was also added, even tho I didn't check it


vite3.1.0-beta.1-bug-always-pending

Describe the bug
when i upgrade vite from 2 to 3, i had found the https://localhost:3100 is always pending
I had test several versions of vite。

Vite version
Is bug appear

2.9.15
no

3.0.0
no

3.0.9
no

3.1.0-beta.0
no

3.1.0-beta.1
yes(First Appear)

3.1.0-beta.2
yes

3.1.0
yes

3.1.8
yes

3.2.3
yes

About the "minimal-reproducible-example"
Due to my limited level, it is difficult for me to do this for the time being.
The repository source is https://github.com/vbenjs/vue-vben-admin。
Reproduction
https://github.com/xbazhen/vue-vben-admin/tree/vite3.1.0-beta.1-bug-always-pending
Steps to reproduce
pnpm install
npm run dev
access https://localhost:3100/ in browser
System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics
    Memory: 33.12 GB / 63.30 GB
  Binaries:
    Node: 16.17.1 - D:\Program Files\nodejs\node.EXE
    npm: 9.1.1 - D:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.675.0), Chromium (107.0.1418.42)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @vitejs/plugin-legacy: ^1.8.2 => 1.8.2
    @vitejs/plugin-vue: ^2.3.4 => 2.3.4
    @vitejs/plugin-vue-jsx: ^1.3.10 => 1.3.10
    vite: 3.1.0-beta.1 => 3.1.0-beta.1

Used Package Manager
pnpm
Logs
21:44:00
VITE v3.1.0-beta.1  ready in 4187 ms
➜  Local:   https://localhost:3100/                                                                                21:44:00
➜  Network: https://<IP_ADDRESS>:3100/                                                                                21:44:00
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[ ] The provided reproduction is a minimal reproducible example of the bug.

nice! 👍
solved my problem

It seems to be vite-plugin-theme's bug. vbenjs/vue-vben-admin#2160, vbenjs/vite-plugin-theme#27 (comment)

nice! 👍
solved my problem


[Feature] GPU Support Allow setting runtimeClass in template.spec

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I was trying to set up one of the examples with GPU support (I know that this particular example doesn't make use of the GPU)
apiVersion: ray.io/v1alpha1
kind: RayService
metadata:
  name: rayservice-fake-emails
spec:
  serviceUnhealthySecondThreshold: 300
  deploymentUnhealthySecondThreshold: 300
  serveConfigV2: |
    applications:
      - name: fake
        import_path: fake:app
        route_prefix: /
  rayClusterConfig:
    rayVersion: 2.5.0 # Should match Ray version in the containers
    headGroupSpec:
      rayStartParams:
        dashboard-host: <IP_ADDRESS>
      template:
        spec:
          containers:
            - name: ray-head
              image: shrekrisanyscale/serve-fake-email-example:example
              resources:
                requests:
                  nvidia.com/gpu: 1
                limits:
                  nvidia.com/gpu: 1
              ports:
                - containerPort: 6379
                  name: gcs-server
                - containerPort: 8265 # Ray dashboard
                  name: dashboard
                - containerPort: 10001
                  name: client
                - containerPort: 8000
                  name: serve
    workerGroupSpecs:
      - replicas: 1
        minReplicas: 1
        maxReplicas: 1
        groupName: small-group
        rayStartParams: {}
        template:
          spec:
            runtimeClass: nvidia
            containers:
              - name: ray-worker
                image: shrekrisanyscale/serve-fake-email-example:example
                lifecycle:
                  preStop:
                    exec:
                      command: ["/bin/sh","-c","ray stop"]
            resources:
                requests:
                  nvidia.com/gpu: 1
                limits:
                  nvidia.com/gpu: 1

That fails with the following error:
unknown field "spec.rayClusterConfig.workerGroupSpecs[0].template.spec.resources", unknown field "spec.rayClusterConfig.workerGroupSpecs[0].template.spec.runtimeClass"

Because it does not pass the field validation.
It would be nice if we could transparently pass all the children of spec to the created pod.
Use case
I make use of K3S, which when used with containerd, requires Pods to have the additional spec runtimeClass: nvidia field set, to run with the Nvidia container runtime.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

It turns out the correct field name is runtimeClassName and not runtimeClass.
That's almost an hour of debugging :(
My bad, sorry for the noise.


Pest not displaying results of each test (maybe?)

Describe the bug
When I run the test suite from within PHPstorm, it shows me the progress bar and the results of the run but I'm really used to running it in the terminal and seeing each test as it passes or fails.  I've seen other screenshots where it does work for other people so I'm assuming it has something to do with my config, but I literally just started using PHPstorm so I don't know what I could have broken to make it do this.
To Reproduce
Steps to reproduce the behavior:

Run the test suite
Look at the results

Expected behavior
Something similar to:
...

   PASS  Tests\Feature\UpdatePasswordTest
  ✓ password can be updated                                                                                0.12s
  ✓ current password must be correct                                                                                0.18s
  ✓ new passwords must match                                                                                0.18s

  Tests:    7 skipped, 167 passed (338 assertions)
  Duration: 13.51s

Screenshots

Desktop (please complete the following information):

OS: macOS Ventura (up to date)
IntelliJ Version: PhpStorm 2023.2 EAP Build #PS-232.7754.72
Plugin Version: 1.10.1

Additional context
none that I can think of

This is on purpose.
We do not print out a lot of things to not bloat the output.
If you would like to see all passed tests, you can clock the check box icon in the left side of the test output 🙂
By default PhpStorm chooses to hide passed tests.

Amazing, thank you for confirming!


Colors in menu are weird

While the colors weren't optimal in the first place, they are now rather weird, particularly in the dark theme. I think the change was brought about in this commit: https://github.com/lf-lang/website-lingua-franca/commit/1ded45c67aa29f8bf3798632a45495540dfbe16b, but I'm not sure.

Should this have been closed by #85? I never understood exactly what this issue referred to.

It has been fixed, yes.


Improve error handling in localSchemasClient

We should check directories exist and return an error if reading the directory returns an error in:
https://github.com/kubernetes-sigs/kubectl-validate/blob/76a49ca98743596967fec0d07c091b40144477ee/pkg/openapiclient/local_schemas.go#L35
https://github.com/kubernetes-sigs/kubectl-validate/blob/76a49ca98743596967fec0d07c091b40144477ee/pkg/openapiclient/local_schemas.go#L51

I would like to work on this issue.
Do I simply return the error that ReadDir returns (with an additional message)?
Or should I do some kind of error handling?
/assign


V1.5.0 Keyboard Shortcuts

List of changes:

Update player control shortcuts. Now ENTER - replay sound, SPACE - paly/pause sounds, ARROW UP/DOWN navigate list, ARROW LEFT/RIGHT seek track
CTL+F focus search input
Add welcome screen with shortcuts help text
Update dependency packages

Release here 🏹  https://github.com/jamland/samplescope/releases/tag/v1.5.0


Tooltip is displayed below the bottom axis when the Bar has value=0

To Reproduce
Create a BarChart with 2 bars, the first bar value > 0, the 2nd bar value=zero, tooltip is always displayed, (showingTooltipIndicators=[...]),
Expect behavior: the tooltip of the 2nd bar should be display above the bottom axis line
Actual behavior: The 2nd Tooltip is displayed below the bottom axis line
Screenshots

Versions

0.35.0
0.40.2

An equals (=) character fixed this issue :)))
If you are interested, check it out in this commit.
Fixed in 0.40.5.
Please check it out!


16-bit raw heightmaps?

Terrain heightmaps seems like a good candidate for supercompression. I was wondering if there were any plans to support this in the future? We typically use 16-bit raw heightmaps (one unsigned short per pixel). I think GIS systems would require greater resolution to handle the range of Earth surface elevation.

We're going to add HDR support at some point, so hopefully this would work in your use case.


conda bootstrap cleanup

This is a much needed cleanup of the conda bootstrap init action, specifically, by:

conforming to default pathing + .profile script names in docker image at continuumio/miniconda3
removing all conda updates (eliminating breaking version updates)
making idempotent the conda .profile modifications

Thanks again! Tested cleanly (have to keep jupyter.sh in sync and had to merge in the --allow-root from master):
gcloud dataproc clusters create dhuo-jupyter-clean2 \
    --initialization-actions=gs://hadoop-cloud-dev-dhuo/jupyter.sh \
    --metadata=INIT_ACTIONS_REPO=https://github.com/dennishuo/dataproc-initialization-actions.git,INIT_ACTIONS_BRANCH=bomboradata-conda-boostrap-cleanup


Generate all Appsync resolvers locally.

Is your feature request related to a problem? Please describe.
Creating a resolver locally involves using the correct file name and VTL. Currently, I copy-paste the existing resolvers to my local directory, to ensure I get the correct file name and base VTL.
Describe the solution you'd like
It'd be really really convenient if amplify add api could also generate all the resolver files locally (if graphql is selected).

@potatopotaro We do put the resolvers in your local file system. It's located in <project-root>/amplify/api/<graphql-api-name>/build/resolvers.
Let me know if that's what you were looking for.

@kaustavghosh06 apologies for the confusion. I meant that it'd be very convenient if the api module could generate all resolver files, versus devs having to create each resolver themselves.

@potatopotaro Are you referring to custom resolvers?
Based on whatever you have in your transformer, the CLI generates corresponding resolvers based on your schema structure and puts it in your project-root>/amplify/api/<graphql-api-name>/build/resolvers directory.
You can also use the ampify api gql-compile command to create these resolvers based on your annotated schema before pushing it to the cloud.

@kaustavghosh06 facepalm yep, silly me. Thanks!


Resume and pause stream

When tracking some words you can get a overload of tweets... so, it could be great to pause and resume the stream
twitterClient.stream('statuses/filter', {track: trackQuery}, function (stream) {
    stream.on('data', function(tweet){
           io.emit('tweet', tweet);
           stream.pause();

          setTimeout(function(){
               stream.resume();
         }, 3000);
    });
});

Or something like that... just sayin'

Yes, i would like to find out how to stop the stream, pause it, i have read the last ones but doesnt worked for me!


Issues on Firefox

Thanks for the great tool! I noticed some issues on Firefox, so I figured I'd open an issue to help track these.

Command Palette doesn't show any choices

You can use the command palette, by typing in what you want and hitting enter, but the list of options shows as empty.

Command Palette keyboard shortcut is unavailable

It's currently bound to Ctrl-Shift-p (on non-mac), which in FF opens a private browsing window. Seems it won't let you override that. As mentioned before in Slack my suggestion would be to use  (perhaps in addition) ctrl-j, as used in Nextjournal.

Hi @plexus,
Just pushed up https://github.com/djblue/portal/commit/b9cd86725efa5d260aaecd7649e44d55802e4dc8 with some fixes. The hidden issues was a small css error and I added the ctrl-j binding alongside ctrl-shift-p for opening the command palette. The changes are deployed to the pwa. If you could please verify that these changes resolve your issue, I can release 0.11.1.

Thanks! I had a play with it yesterday, all works as advertised!


Fix registrations URL

https://github.com/praekelt/chms-jsbox/blob/develop/src/utils.js#L227 should be .service_api_call("registrations", "post", null, reg_info, "registration/", im)

@imsickofmaps Please review.

:+1:


Rust has removed #[feature(vec_remove_item)]

As a result, this project can't compile anymore on the latest Rust.

Nevermind, that was apparently fixed here, and msyt has this locked on an old version 😅 .


opt reset ms response message in case it is reused for retry

What problem does this PR solve?
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[x] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[x] Add branch pick label

run buildall