Is AEM 6.4 Compatible?

Hi Team,
I have couple of queries, It would be really helpful if you can answer.

Is AEM 6.4 is compatible, if yes which version?
I want to copy content from AEM 6.0 to AEM 6.4. Is it still possible?

Thanks
Madhu

@madhujella1987 Did you get anywhere with this? I am about to try a 6.2 -> 6.4

@madhujella1987 did you get some answer or did you try another alternative? We want to do exactly the same.

We have only done preliminary testing, but it does look to be working.

@mikehstrauss Can you please let me know if you had issues ? As per their documentation,I see support only till 6.3, so wanted to confirm with you.
https://github.com/TWCable/grabbit/blob/master/docs/AEMSupport.adoc
Below details AEM version support for the various releases of Grabbit.
v7.x - AEM 6.1 and AEM 6.2 and AEM 6.3
v5.x - AEM 6.1
v4.x - AEM 6.1
v3.x - CQ 5.6 and AEM 6.0
v2.x - CQ 5.6

I used it on 6.4 and had no issues. Of course your mileage may vary.
From: Vigneshwaran ThulasiDoss @.>
Reply-To: TWCable/grabbit @.>
Date: Thursday, March 11, 2021 at 2:33 PM
To: TWCable/grabbit @.>
Cc: "Strauss, Michael" @.>, Mention @.***>
Subject: Re: [TWCable/grabbit] Is AEM 6.4 Compatible? (#222)
@mikehstrausshttps://github.com/mikehstrauss Can you please let me know if you had issues ? As per their documentation,I see support only till 6.3, so wanted to confirm with you.
https://github.com/TWCable/grabbit/blob/master/docs/AEMSupport.adoc
Below details AEM version support for the various releases of Grabbit.
v7.x - AEM 6.1 and AEM 6.2 and AEM 6.3
v5.x - AEM 6.1
v4.x - AEM 6.1
v3.x - CQ 5.6 and AEM 6.0
v2.x - CQ 5.6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/TWCable/grabbit/issues/222#issuecomment-796992080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABA5PCHBD2UPPKLAELEOWQTTDEEJHANCNFSM4GQ22SRQ.

I used it on 6.4 and had no issues. Of course your mileage may vary. From: Vigneshwaran ThulasiDoss @.> Reply-To: TWCable/grabbit @.> Date: Thursday, March 11, 2021 at 2:33 PM To: TWCable/grabbit @.> Cc: "Strauss, Michael" @.>, Mention @.***> Subject: Re: [TWCable/grabbit] Is AEM 6.4 Compatible? (#222) @mikehstrausshttps://github.com/mikehstrauss Can you please let me know if you had issues ? As per their documentation,I see support only till 6.3, so wanted to confirm with you. https://github.com/TWCable/grabbit/blob/master/docs/AEMSupport.adoc Below details AEM version support for the various releases of Grabbit. v7.x - AEM 6.1 and AEM 6.2 and AEM 6.3 v5.x - AEM 6.1 v4.x - AEM 6.1 v3.x - CQ 5.6 and AEM 6.0 v2.x - CQ 5.6 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#222 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABA5PCHBD2UPPKLAELEOWQTTDEEJHANCNFSM4GQ22SRQ.

Thank you @mikehstrauss


Fix concurrent-to field in WARC headers

What's missing is assigning the Warcinfo-ID field correctly and finding the last one (if there is one) when appending to a WARC file

@BubuAnabelas ok I gave the changes from your PR a test run (merged into dev branch) and used  Squidwarc to generate a WARC file which was then replayed using Pywb.
Squidwarc depends directly on node-warc for the WARC generation and is high fidelity archival crawler I have written.
Your changes appear to introduce additional CRLFs which causes the length of the  WARC records to be off as well as the length of the response bodies.
See annotated image below   comparing your changes PR #5 merged into the dev branch vs the dev branch as it it now.

If you could switch the branch your  PR  is based on (from master to dev) and work from their to ensure that no additional CRLF are introduced (see RFC 7230 for CRLFs in HTTP).
I believe we can get the CRLF issue resolved without to much headache.
I highly recommend using WAIL  for managing the replay of the WARCs generated. It will do the setup for you automatically.
Otherwise Pywb is the de facto replay  system and is easy to use to test it out.

I added some unnecesary CRLF by mistake in the request and response block headers. In the next commit I'll solve this and the current file conflicts from switching branch

Bumping this since it's ready for merging.

@BubuAnabelas gave it a test run and everything works perfectly.
Again sincerest apologies for the delay in my responses and time it took to get this merged.
Love the refactoring of warcFields.js to use template literals.
Merging into dev then strait into master!
Thank you for this!!!!


Somes fixes on javascript

Fixes a color conversion issue when calling Map.setOptions(...) multiple times
Fixes InfoWindow showing on markers with title "undefined"

Thank you. But there was a bug which lead into a crash when title was an integer. Thanks why I converted to string. Did you have take this into account?

Oh ok i'll take a look

Ok it's working with a number, boolean, empty string, array and object. The only quirk i found is the null value becoming "null".

Well that's fine! Thanks!


Problem creating light curve

Hello,
Thank you so much the tool is really helpful!
I was trying to create a light curve data for NGC253, the ltcube ran very smoothly and the plot quality is 3 so it should be no problem?
But when creating the light curve I encountered a valueError which says "zero-size array to reduction operation maximum which has no identity." and then the light curve cannot be assembled.
This happens specifically when I manually change model to LogPar or PLEC, with default Powerlaw model it works fine.
Here's Error code
Error.md
and fermilog file:
fermipy .log
If you can provide any help I'm very grateful.

Dear @StateAtol , thank you for pointing out this bug. The problem was happening because all of the lightcurve bins were upper limits. I just fixed it, and I think that now everything is working. Could you please update your version of easyFermi by following the steps below?

open the Fermi environment in the terminal with the command "conda activate fermi"
update easyFermi with the command "pip install easyFermi==1.0.11"

After that, easyFermi may work properly. Please let me know if you have any further issues.

@ranieremenezes Sorry my feedback is a bit late and thanks for the effort! Now it works like a charm :)
My apologies for asking again but I need advice for something else, sometimes when the number of bins is too large, like, 60 bins for a six-years-data's SED or LC, I get an error saying:
ValueError: Parameter scan points for 4FGL J0509.4+0542::Prefactor include infinite value.
What could be the cause of this error& is there a way to get through without reducing the bin number?
Any advice would be greatly appreciated, sorry to bother you again.

@ranieremenezes During further test another error occurred:
ValueError: cannot convert float NaN to integer
For NGC1068 the light curve can now be assembled normally(it couldn't before the update) but for NGC253 this new error appeared and it stopped working.
Here's error code:
ErrorCode2.md
And fermilog file:
fermipy (2).log
Please check it.
Regards

Hi @StateAtol , good that the updated version is working! On you new questions:
sometimes when the number of bins is too large, like, 60 bins for a six-years-data's SED or LC, I get an error saying:
ValueError: Parameter scan points for 4FGL J0509.4+0542::Prefactor include infinite value.
What could be the cause of this error& is there a way to get through without reducing the bin number?

This is probably an error only of the SED computation, but let's discuss both cases.
For the SED: There are some possibilities for this error to occur, but the most likely is that you have asked for too many energy bins (i.e. 60) such that some of them simply have no enough photons (in some cases even zero) to properly perform the likelihood fit. Other possibility is that you are asking easyFermi to cut the data in energy/time intervals beyond the downloaded data (see next bullet point).
For the LC: I would expect it to occur only if you are working on very high energies (let's say only with photons above 80~100 GeV) or if the data cuts that you settled in easyFermi are different from the data cuts applied when downloading the data. E.g. maybe the time window for which you are asking easyFermi to compute the LC is longer then the time window of the downloaded data, such that some bins will have zero photons.

To get through this error without reducing the number of bins, I would recommend you to work only in low energies, let's say 100 MeV -- 10 GeV (or the minimum energy possible for you). Let me know if this helps you. To help you more precisely I would have to know more details, such as take a look on your configuration file (i.e. config.yaml) and have at least a rough idea of your goal.
for NGC253 this new error appeared and it stopped working.
Ok, according to the log file the error is "ValueError: cannot convert float NaN to integer" and it is associated with the array of upper limits "lc['eflux_ul95']", meaning that one or more upper limits could not be computed. This error is very likely due to low statistics, just like the error discussed above.

@ranieremenezes Thank you for the detailed explanation! I think I've got a rough idea what the problem is & why the error occurred. So basically the data cuts don't handle well on very high energies and I shall pay attention to make sure the LC matches the time window of the data.
The error codes and logs actually belong to another person in my group, she's trying to analyze several star-forming-galaxies when the error appeared. So after the update & lowering the energy range, she managed to create 50-60bin LCs without problem.
On the other hand, my goal is to analyze 3 AGN blazers related to IceCube observatory's neutrino flare events :
TXS 0506+056, GB6 J1542+6129 and PKS 1424+240 with energy ranging from 1Gev to 500Gev
I'm trying to :

Plot LCs with as many bins as possible to compare the gamma ray flux periods with neutrino event timing.
Plot SEDs to compare their energy distribution then find some shared properties of their spectrum. (there are several
reports saying they all belong to one subcategory of blazer)

So i've tried to lower my energy range to 1Gev~10Gev for a 10-years-analysis of TXS0506, yet the error message
ValueError: zero-size array to reduction operation maximum which has no identity
kept occurring and it seems anything above 30 bins can not be achievable, I think this is due to low statistics when computing upper limits array too. But I got no idea how to improve the result of my research. So please share some thoughts when you have time.
fermipy.log
config.txt
ERROR.md
srcmdl_00 .txt
Target_results.txt

Hi @StateAtol ,
> So after the update & lowering the energy range, she managed to create 50-60bin LCs without problem.

Great! I am really glad to know about this.

> Plot LCs with as many bins as possible to compare the gamma ray flux periods with neutrino event timing.

I see. In this case, the usage of easyFermi should be as I said before: the size of each bin must be large enough such that they contain a reasonable amount of photons for the likelihood fit to converge.

> So i've tried to lower my energy range to 1Gev~10Gev for a 10-years-analysis of TXS0506, yet the error message
ValueError: zero-size array to reduction operation maximum which has no identity

Thank you for pointing this out. This was a tiny bug happening when easyFermi was trying to plot the LC. I've fixed it and ran a series of tests this afternoon. I think everything is working now. I will ask you to do the following:
open the Fermi environment in the terminal with the command "conda activate fermi"
update easyFermi with the command "pip install easyFermi==1.0.12"
and then try your analysis again. Please let me know if it works.

Hi Mr.Menezes,
I have updates easy Fermi ,but when I'm trying to put the directory without
the blank spaces, it shows that it has failed to resolve file path.
Regards,
Krittika.
On Mon, Dec 4, 2023, 7:32 PM Raniere @.***> wrote:

Hi Krittika,
Thanks for the files. There are only two small issues.

Please update easyFermi to version 1.1.4. You can do that by opening
the fermi environment on the terminal and typing:
pip install easyFermi==1.1.4
2.
The major problem is just the data path. easyFermi does not have
access to the data in your machine.
You can try the following. Instead of using a directory path like that:
/home/kritzzz/Desktop/Fermi sample1/3.12 easyfermi1/list.txt
you can try:
/home/kritzzz/Desktop/Fermi_sample1/3.12_easyfermi1/list.txt
I mean, try to remove the blank spaces from all paths.
—
Reply to this email directly, view it on GitHub
https://github.com/ranieremenezes/easyFermi/issues/2#issuecomment-1838703674,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6U37NEPCKH7OF6U6MM5Y63YHXJXTAVCNFSM6AAAAAASWLGDO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYG4YDGNRXGQ
.
You are receiving this because you commented.Message ID:
@.***>

Hmmm... I see...
How are you organizing the data files? Do you have a directory only with the photon data, one with only the spacecraft, and one with only the background models? Did you rename these files?
From the error in your terminal, I see that the data path is understood by easyFermi as easyfermi1/photon/PH.fits, which is different from the path listed in your config file.
I will ask you to follow the tutorial again but doing exactly the same thing as is shown there. I mean, even the directory organization.
I hope this can help you.

Mr. Menezes,
I created a folder easyFermi and in that I saved the files for the
spacecraft and other data. I am facing this problem to directory management
not only for easyFermi but also other codes that I'm running. Maybe I'm
doing something fundamentally wrong. To be honest I'm very new to using
Linux, conda and jupyter notebook, previously I used window and python idle
for my work. And not always I'm able to figure things out from the internet.
But I'll surely check once more what's going wrong with the files. And I'll
let you know. I'm extremely grateful for your patience and help.
Thank you
Yours sincerely
Krittika.
On Thu, Dec 7, 2023, 6:43 AM Raniere @.***> wrote:

Hmmm... I see...
How are you organizing the data files? Do you have a directory only with
the photon data, one with only the spacecraft, and one with only the
background models? Did you rename these files?
From the error in your terminal, I see that the data path is understood by
easyFermi as easyfermi1/photon/PH.fits, which is different from the
path listed in your config file.
I will ask you to follow the tutorial again but doing exactly the same
thing as is shown there. I mean, even the directory organization.
I hope this can help you.
—
Reply to this email directly, view it on GitHub
https://github.com/ranieremenezes/easyFermi/issues/2#issuecomment-1843972573,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6U37NCHFHVGVKO7HHU3X5TYIEJ33AVCNFSM6AAAAAASWLGDO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTHE3TENJXGM
.
You are receiving this because you commented.Message ID:
@.***>

Hi Krittika,
We recently updated easyfermi (take a look at the new installation tutorial) and we also did several checks on Windows with WSL. Furthermore, stay tuned to the easyfermi YouTube channel. We are going to update some tutorials there in the next weeks.

Mr. Menezes,
Thank you so much for letting me know about this. I will keep track of the
you tube videos.
Regards,
Krittika.
On Fri, Feb 23, 2024 at 8:51 PM Raniere @.***> wrote:

Hi Krittika,
We recently updated easyfermi (take a look at the new installation
tutorial) and we also did several checks on Windows with WSL. Furthermore,
stay tuned to the easyfermi YouTube channel. We are going to update some
tutorials there in the next weeks.
—
Reply to this email directly, view it on GitHub
https://github.com/ranieremenezes/easyfermi/issues/2#issuecomment-1961522830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6U37NGTMKSNQ4O45FUKUPLYVCXZBAVCNFSM6AAAAAASWLGDO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGUZDEOBTGA
.
You are receiving this because you commented.Message ID:
@.***>


[Bug]: Cannot use S3 with Cloudflare R2.

What happened?
https://developers.cloudflare.com/r2/objects/multipart-objects/
"All parts except the last one must be the same size. The last part has no minimum size, but must be the same or smaller than the other parts."
I get this error when using Beam with Cloudflare R2 S3 API. There is seemingly no way to tell Beam to use consistent part sizes.
apache_beam.io.aws.clients.s3.messages.S3ClientError: ("An error occurred (InvalidPart) when calling the CompleteMultipartUpload operation: All non-trailing parts must have the same length. [while running 'WriteSplit[train]/Write/Write/WriteImpl/WriteBundles']", 400)

Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[x] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Thanks! It might help to leave a minimal example that reproduces this error.


Unit tests

Collect here what unit/feature tests should be written. And implement them. 🥇 ✔

[x] training creation
[x] attend training
[x] withdraw training
[x] attend when max attendee limit reached
[x] can not attend multiplex trainings within threshold

Fixed by #52


Problem with aggregate function

Hello !
I am using the pivot feature and I have a problem when I want to access to the value of an hidden column in the aggregated function.
It seems the hidden column is not considered as a part of the table.
Here is a codepen : https://codepen.io/marfa93/pen/wdEKVo
System Information

Browser & Browser Version: Vivaldi 1.9.818.49
Node Version: 6.10.3
OS Version: Ubuntu 16.04 LTS
NPM Version: 3.10.10

Yeah, this seems like a bug of sorts.  I'm not sure how to handle it though.  If a column is hidden, it would be nice to not have to perform calculations on it, but at the same time I can see your use case.  @aaronschwartz thoughts on this?

maybe add a prop to include it in the calculations if its hidden?

I was trying to play around with it until CodePen went down... it looked like technically the data still existed in the _subRows key. You would have to do the aggregation yourself though instead of relying on the column aggregation function.

Maybe something like this as a workaround for now:
https://codepen.io/aaronschwartz/pen/ybwRrp?editors=0010

Hi !
Thanks a lot for the solution, it works !
In some case I have more than two pivot columns, so I made this : https://codepen.io/marfa93/pen/WjWRQO?editors=0010
The self-made aggregation function is recursive.
PS : Where/How can I pay you a beer ? ;)

There is a donate button on the readme that would facilitate that ;)
On Fri, May 26, 2017 at 2:32 AM Marfa93<EMAIL_ADDRESS>wrote:

Hi !
Thanks a lot for the solution, it works !
In some case I have more than two pivot columns, so I made this :
https://codepen.io/marfa93/pen/WjWRQO?editors=0010
The self-made aggregation function is recursive.
PS : Where/How can I pay you a beer ? ;)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-table/issues/282#issuecomment-304224450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCSZwMLs6W1gip_qjUkYVt4yhRxdkks5r9o4OgaJpZM4Nd4Nt
.


feat: change improved search shouldStartQuering threshold

The type of this PR is: Enhancement

This PR resolves FX-3317
Description
⚠ NOTE:  This work is currently behind a feature flag
Change the threshold for we start querying when user types in search from >= 2 to >= 1
Started a slack thread for the multi index search that doesn't return results from gravity for now here

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

change improved search shouldStartQuering threshold - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (change improved search shouldStartQuering threshold - gkartalis)

  Generated by :no_entry_sign: dangerJS against 89feedbf2b8014cca3fc4323c36c887b2315f6d0

#squashOnGreen


[enhance][elasticsearch] Manage certificates in same way

If certificate is self managed or provided, update it in same way.
Maybee the best is to manage all of them on statefullset controller. It also manage the config update and so on

It fix


removes yarn.lock (duplicate lock file)

What is this PR and why do we need it?
This removes yarn.lock (a duplicate lock file). We'll use npm as the package manager for this repo going forward because it is more widely used.
Described by issue #72.
There should be no observable changes from this change.
Pre-Merge Checklist (if applicable)

[x] Unit and Feature tests have been added/updated for logic changes, or there is a justifiable reason for not doing so.

Flagging for some code conflicts @JakeLo123

Flagging for some code conflicts @JakeLo123

fixed 'em!


Incorrect output in KCL FAQ "add elements to a dict"

https://kcl-lang.io/docs/user_docs/support/faq-kcl#4-how-to-add-elements-to-a-dict
The code provided in the documentation is as follows:
_left = {key = {key1 = "value1"}, intKey = 1}  # Note: `=` denotes override the value.
_right = {key = {key2 = "value2"}, intKey = 2}
dataUnion = _left | _right  # {"key": {"key1": "value1", "key2": "value2"}, "intKey": 2}
dataUnpack = {**_left, **_right}  # {"key": {"key1": "value1", "key2": "value2"}, "intKey": 2}

And the output in the documentation:
dataUnion:
  key:
    key1: value1
    key2: value2
dataUnpack:
  key:
    key2: value2

However, when I ran the code locally and on the KCL playground, I got a different output:
dataUnion:
  key:
    key2: value2
  intKey: 2
dataUnpack:
  key:
    key2: value2
  intKey: 2

Is this a bug in KCL or a mistake in documentation?

Oh.. maybe documentation mistakes. The code should be
_left = {key: {key1 = "value1"}, intKey = 1}  # Note: `=` denotes override the value.
_right = {key: {key2 = "value2"}, intKey = 2}
dataUnion = _left | _right  # {"key": {"key1": "value1", "key2": "value2"}, "intKey": 2}
dataUnpack = {**_left, **_right}  # {"key": {"key1": "value1", "key2": "value2"}, "intKey": 2}

The result is
dataUnion:
  key:
    key1: value1
    key2: value2
  intKey: 2
dataUnpack:
  key:
    key1: value1
    key2: value2
  intKey: 2


Add security plugin to 2.3.1

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
Prerequisite for https://github.com/opensearch-project/security-dashboards-plugin/pull/1107#issuecomment-1263816627
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Groovy failing due to other reason. @jordarlu is working on the fix. Merging this PR.

Thanks for mentioning that, @gaiksaya , we expect the #2679 to resolve Groovy test fail issue .. hopefully get approval by EoD today..  :)


Error reported when clicking Update

When I click the Update button, I get the below error.

Hey @Kristianwhittick. This would be an issue that happens outside of our app. I've reached out to the team who owns installing/updating apps in Jira. Will reach out again when I know more.

Hey again @Kristianwhittick. Can I get the domain for the affected Jira site and the approximate timestamp when you ran into this issue (rough date and time)?

@rachellerathbone - Thank you for your reply and for looking at the issue.
The domain = https://odx.atlassian.net/jira
It was yesterday - 5 Jul 2022 10:00 BST

Hey @Kristianwhittick. Apologies for the slow response. Are you still facing this issue?

Hey @Kristianwhittick. As we haven’t heard from you in almost 2 months, I’m going to go ahead and close this issue. Please feel free to reopen if you still need assistance.


Release

Description of changes

See commits for changes included.
Codegen Paramaters Changed or Added

See:

https://github.com/aws-amplify/amplify-codegen/pull/797
https://github.com/aws-amplify/amplify-codegen/pull/796

Issue #, if available

N/A
Description of how you validated changes

Unit test
E2E test: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/594813022831/projects/amplify-codegen-e2e-workflow/batch/amplify-codegen-e2e-workflow:bf1e3aa0-6696-4dad-8f1c-584803b12f0e?region=us-east-1

Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Need to merge https://github.com/aws-amplify/amplify-codegen/pull/795 before release.


fix: windows cache file error

@kanrin Can you help me verify if this change works on Windows?

yes, I can, i'll test the code on Windows. Please wait a time

It's work well.


resolve issue 21, avoid recursion in connected function

Addressing issue https://github.com/covidgreen/covid-green-app/issues/21

@covidgreen/members ... Can we please get additional review on this. It needs at least one more sign off


improvement: support relabelings in ServiceMonitor

Describe your changes
Added optional support for metricRelabelings
Testing performed
ServiceMonitor renders cleanly with or without relabelings

Prioritize this, please.


Further improvment

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)

Execution time:
Execution time of reference implementation:

This would need a rebase, but there's also https://github.com/gunnarmorling/1brc/pull/521? Can you please close one of the PRs to make things clear? Thx!

Sorry, I've forgotten to close this one.


required doesn't work with mat-select if template-driven style used

Bug, feature request, or proposal:
Bug
What is the expected behavior?
The required validator has to work as expected.
What is the current behavior?
If you change the selection, there is no any effect.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-jtahpy
What is the use-case or motivation for changing an existing behavior?
Incorrect behaviour.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular Material 5.2.1+
Is there anything else we should know?
If I use reactive form, the behaviour is correct. But I used to use template-driven.

That's because you don't have an ngModel on it. Here's a forked example that works.

In case someone else has this issue in future, you have to use ngModel as said by @crisbeto & you have to give a name attribute to the control so that angular create a FormControl.
You can refer to this stackoverflow question about the same issue


⚠ Bofrost.fr has degraded performance

In 710870a, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.fr performance has improved in 54abced after 8 minutes.


Wrong container memory usage metric whitelisted per default for cAdvisor

Description
As described in the title the metric container_memory_usage_bytes is whitelisted per default. This metric includes cached files and does not represent the actual usage of a pod/container which is the relevant information for OOM Kills and memory usage (cached memory is per say free memory and can be used by the container.
The proper metrics for that purpose would be container_memory_rss and specifically for OOM Kills: container_memory_working_set_bytes.
Steps to Reproduce
Install any nrotelk8s Release with important metrics definitions. Check what the container_memory_usage_bytes metric provides and compare the data with the data you get from kubernetes for a container/pod.
Expected Behavior
The metric data should match the data you get from kubernetes.
Your Environment

Versions of your OTel collectors: 0.4.1
Kubernetes manifest files (only the relevant configuration for important metrics for cAdvisor):

statefulset:
  prometheus:
    cAdvisor:
      importantMetrics:
        - container_memory_usage_bytes

container_memory_usage_bytes - move away from using this metric in favor of container_memory_rss and container_memory_working_set_bytes.
Additional information
I compared the results from the container_memory_working_set_bytes metric and it depicts also the proper memory usage, that gets announced by kubernetes.
Relevant topic: https://forum.newrelic.com/s/hubtopic/aAX8W0000008cEUWAY/kubernetes-metric-update
As stated above - this is a minor issue, since as of 0.4.0 the importantMetrics are exposed for customization in the values file (thanks a lot for that @utr1903 :) )

@tvalchev2 Thanks for the issue, you're right! It'll be fixed in the next releases :)

@tvalchev2 Implemented with following releases:

otel-collectors
newrelic-monitoring


The budget-specified grid search

This issue is forked from #154.
Is your feature request related to a problem? Please describe.
I want the budget-specified grid search option in the grid-search optimizer.
The current grid-search optimizer creates suggestion points based on step specifications. However, I think many experimental cases decide the points from a limitation of budget. Moreover, the step on a log scale is not straightly understandable.
I imagine the step-specified implementation is used because there is a case the weights of parameters for the search are not equal.
In that case, I want to specify the number of points for each parameter.
Describe the solution you'd like
Make the step optional specification and create suggestions based on a budget, when the step is not specified.
The priority for the points creation rule is
global budget > the order of parameter description > step or points number specified > non-specified.
The non-specified parameters are evenly assigned points from the remaining of the global budget.

Completely agree.


ITFFForArrayIndex now works with indexed String access as well.

See STAMP-project/evosuite-ramp#9

Pull Request Test Coverage Report for Build 462

23 of 27 (85.19%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 62.09%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

botsing-reproduction/src/main/java/eu/stamp/botsing/StackTrace.java
1
2
50.0%

botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/ITFFForIndexedAccess.java
8
9
88.89%

botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/FitnessFunctionHelper.java
12
14
85.71%

Totals

Change from base Build 416:
0.03%

Covered Lines:
2442

Relevant Lines:
3933

💛  - Coveralls


scrollTo true will scroll to top of container

Setting scrollTo to true will scroll to the top of the container on pjax success.

Closing in favor of https://github.com/yiisoft/jquery-pjax/pull/51


disable bloom filters

477/464 - a bit suspicious, but worth investigating

Reran to check for stability - now it's 458/478 :/


feat(rust): ockam_node_no_std crate v0.0.0

Establishes  ockam_node_no_std crate v0.0.0

Could you also add a README.md to the crate.


(GH-1491) Add deprecation message for bolt-inventory-pdb

This adds a deprecation message to the bolt-inventory-pdb command
warning users about support for the command and inventory file v1 being
dropped in the future.
This change should be shipped with the planned changes to the inventory docs: #1464

CLA signed by all contributors.


Adding more trained models

Is it possible to add an option that allows you to switch between trained models ?

You can put your trained models in a folder in gdrive, then in "path_to_traned_model", specify that folder, and you will see all the models in model dropdown menu in the webui


User manuel

In **Wiki" there  is no user manuel
If you  have time. you can create user manuel , which shows how to use your software(Client)
NB:
The focus for the user manuel is not  developer. This is for customer like  Grand-mother, children, people don t have idea about  programming.

https://github.com/idrice24/School-Management-Software/wiki


Drawing Arcs?

This is not an issue, but a request for additional methods to draw arcs on the canvas.
Is it easy to add this functionality? I'm new to JS.
Thank you for a wonderful library.

I have to say , that's not a good solution : canvas -> image -> jsPDF
The much better way is fitting arc by bezier curves. So that the arcs can always be vector graphics.


Feature/update drawsvg version 2.0

Resolves #8 by upgrading to version 2.0 of draw svg which introduced breaking changes. Also added a requirements.txt file for easier dependency management.

Also added back in union operator from python 3.10.

@klaeufer Just wanted to request a few updates to the baseline project for a couple of items that blocked me from contributing early on. I figured opening this PR now might also start generating a few datapoints for different metrics on the repository.


Error: This plugin slows down Homebridge

Describe The Bug:

Homebridge status console shows multiple errors.
receiving errors for all of the functions including temperature set points, filter life, humidity etc.  I am running the plugin as a child bridge as suggested in Homebridge guides for this error.
To Reproduce:

Expected behavior:

Logs:
[03/10/2021, 20:23:15] [homebridge-carrier-infinity] This plugin slows down Homebridge. The read handler for the characteristic 'Current Temperature' was slow to respond! See https://git.io/JtMGR for more info.
[03/10/2021, 20:23:15] [homebridge-carrier-infinity] This plugin slows down Homebridge. The read handler for the characteristic 'Target Temperature' was slow to respond! See https://git.io/JtMGR for more info.
[03/10/2021, 20:23:15] [homebridge-carrier-infinity] This plugin slows down Homebridge. The read handler for the characteristic 'Temperature Display Units' was slow to respond! See https://git.io/JtMGR for more info.
[03/10/2021, 20:23:15] [homebridge-carrier-infinity] This plugin slows down Homebridge. The read handler for the characteristic 'Cooling Threshold Temperature' was slow to respond! See https://git.io/JtMGR for more info.
[03/10/2021, 20:23:15] [homebridge-carrier-infinity] This plugin slows down Homebridge. The read handler for the characteristic 'Heating Threshold Temperature' was slow to respond! See https://git.io/JtMGR for more info.```

**Plugin Config:**

```json
Show your Homebridge config.json here, remove any sensitive information.

{
"username": "xxxxxxxxx",
"password": "xxxxxxxxx",
"holdBehavior": "activity",
"showOutdoorTemperatureSensor": false,
"showFanControl": false,
"showIndoorHumiditySensors": false,
"platform": "CarrierInfinity",
"_bridge": {
"username": "xxxxxxxx",
"port": 43571
}
Screenshots:

Environment:

Plugin Version:
v1.5.4,
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:
raspbian.  pi zero w.

Thanks for reporting! I’ve been looking into this and started working on it. But it’s probably going to take a bit for me to get the time to finish it up. Will update this issue when the fix is ready.

Thanks for checking in! I haven’t been able to finish this yet. Though I do have a plan of how to fix it. I’m starting to work through the backlog of issues again here (no idea how it ended up being 4 months since I last worked on this…), so will hopefully have an update on the next few weeks.

Just pushed some changes to the "next" channel that should hopefully make the api respond faster on reads and writes.
Give it a try when you get a chance and let me know if things seem better, or if you see any bugs. (Especially if you see the device in homekit stop responding or hang.)
npm install -g homebridge-carrier-infinity@next

The most recent version on "next" has these improvements. I'll be promoting it to stable in the next week, if things keep looking good on my install.
If you still come across any issues with this though, please reopen the issue. Thanks!


Support extracting contract from a struct.

Also:

Fix to expressions handling from targets.

Pull Request Test Coverage Report for Build 630605354

86 of 114 (75.44%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 72.79%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/generator/method/method.go
5
10
50.0%

internal/loader/loader.go
68
91
74.73%

Files with Coverage Reduction
New Missed Lines
%

internal/loader/loader.go
2
60.73%

Totals

Change from base Build 605863640:
-0.7%

Covered Lines:
634

Relevant Lines:
871

💛  - Coveralls


Direct messages to Ratatouille. Is it implemented?

Is there a way to update model and trigger view rendering via direct message to Ratatouille without Command invocation?

So officially, there are 3 ways to trigger an update and re-render (update is always followed by a render):

The runtime receives an event (e.g., key press, resize), calls your application's update/2 function, and then renders the result.
After receiving an event, your update/2 returns a Command, the command is evaluated, and update/2 is called with the command result followed by a re-render.
With a subscription configured, your update/2 is called periodically at approximately the configured interval with a re-render after each call.

Unofficially, you could also achieve 1. above by manually sending the runtime an event (e.g., send(pid, {:event, :foo})), but hopefully there's a better way to achieve what you're looking for within the system.
Could you elaborate on your use-case a bit?  If none of these fit, I'd be happy to explore adding something new to address it.

Ok, nothing fancy, for example, when building chat room I have a process that constantly receive messages and update needs to be triggered each time such messages received.
Time interval subscription might be an option and it will do its job but it would feel slow due to low frequency update. It might be a ground for discussion whether or not TUI has to have immediate response, but for me it feels like positive answer.
Oh, another case I almost forgot. I have GenServer having a process status wothin its state. 90% of the time it is idle and 10% either transmitting or receiving. It would be nice to have blinking which is not possible with time interval subscription.
Work around with event might be a good option tho, havent though about it this way.
PS. Btw, another thing which I find quite useful is logger backend for ratatouille. If I will manage to implement it I will create PR. Currently any output to console breaks the interface, if there are any guidelines or best practices I would appreciate it.

@ADodulad You can use https://hex.pm/packages/logger_file_backend for logging.

@ndreynolds Hi, Nick,
Here is my use case: I have a WebSocket process that will send a message to its' subscriber. What would be the best approach to handle those events in Ratatouille app?

@ndreynolds Hi, Nick,
Here is my use case: I have a WebSocket process that will send a message to its' subscriber. What would be the best approach to handle those events in Ratatouille app?

Hi, how can I get the runtime PID to send messages?

@ndreynolds and others, I'm working on an application which calls out to an external library from within Ratatouille. I need to share some state from this library and Ratatouille. Would this be a valid use case for the runtime event escape hatch?

@brendalf You can start the process in your supervision tree with a transient strategy. I believe that pid is what you want.


swc_ecma_codegen emits / in some mapped types

Describe the bug
I'm using swc_ecma_codegen directly to emit a .d.ts file.  It should look like this:
declare type Custom<A> = {
    -readonly [P in keyof A]+?: A[P];
}

but the actual output was:
declare type Custom<A> = {
    -readonly [P in keyof A]+/: A[P];
}

Input code
No response
Config
No response
Playground link
No response
Expected behavior
The following should be output
Actual behavior
No response
Version
swc_ecma_codegen = 0.127.16
Additional context
Updating https://github.com/swc-project/swc/blob/main/crates/swc_ecma_codegen/src/typescript.rs#L508 to output a ? instead of / should fix the issue.  I can work on a PR for this.

Yeah, feel free to send a PR :+1:


[Feature] : Adding Linkedin and instagram accounts at the footer

Description
In the footer section there is missing of  Instagram and Linked in account icons, I would like to add those features to the section which makes more reach of the projects by following in the Linked in and Instagram.
Assign me this issue @Rakesh9100 to make contribution to this valuable project and add labels to my issue sir.
Thank you for the oppurtunity.
Screenshots

In this image there is  no instagram and  Linked in accounts icons
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

I would like to work on this. Please assign me this issue to contribute to this project

@Rakesh9100 this issue can be assigned

You can just add LinkedIn account as for Instagram, issue is already open @GAVINESHWAR


dense_flow Compile Error ->opencv2/xfeatures2d.hpp

my environment:ubuntu16.04,opencv3.4.0
the error log as blew:
/dense_flow/build$ cmake .. && make -j
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   python
-- Configuring done
-- Generating done
-- Build files have been written to: /home/yyk/ACTION/mmaction/third_party/dense_flow/build
Scanning dependencies of target denseflow
[  7%] Building CXX object CMakeFiles/denseflow.dir/src/dense_warp_flow_gpu.cpp.o
[ 14%] Building CXX object CMakeFiles/denseflow.dir/src/dense_flow_gpu.cpp.o
/home/yyk/ACTION/mmaction/third_party/dense_flow/src/dense_warp_flow_gpu.cpp:12:10: fatal error: opencv2/xfeatures2d.hpp: No such file or directory
#include "opencv2/xfeatures2d.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/home/yyk/ACTION/mmaction/third_party/dense_flow/src/dense_flow_gpu.cpp:5:10: fatal error: opencv2/xfeatures2d.hpp: No such file or directory
#include "opencv2/xfeatures2d.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/denseflow.dir/build.make:134: recipe for target 'CMakeFiles/denseflow.dir/src/dense_warp_flow_gpu.cpp.o' failed
make[2]: *** [CMakeFiles/denseflow.dir/src/dense_warp_flow_gpu.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/denseflow.dir/build.make:110: recipe for target 'CMakeFiles/denseflow.dir/src/dense_flow_gpu.cpp.o' failed
make[2]: *** [CMakeFiles/denseflow.dir/src/dense_flow_gpu.cpp.o] Error 1
CMakeFiles/Makefile2:215: recipe for target 'CMakeFiles/denseflow.dir/all' failed
make[1]: *** [CMakeFiles/denseflow.dir/all] Error 2
thanks in advance!

@zhaoyue-zephyrus  sorry for trouble you

Hi, @yangyuke001
How do you install your opencv 3.4.0? xfeatures2d is in opencv_contrib. You probably have to build your opencv with this extra module by explicitly setting -DOPENCV_EXTRA_MODULES_PATH=/PATH/TO/YOUR/OPENCV_CONTRIB/.
Please refer to issue #7 for compiling dense_flow with opencv 4.1.0. Compiling with opencv 3.x should be similar. Also as a reminder, please check out the branch property.

@zhaoyue-zephyrus Thanks for your reply,I will try it now.

@zhaoyue-zephyrus ，I installed opencv4.1.0 as your guild, but the error happened again:
fatal error: opencv2/xfeatures2d.hpp: No such file or directory
#include "opencv2/xfeatures2d.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I solved this problem,and there some tiny mistake:  -DWITH_CUDA=ON
and '-DWITH_CUDA=OFF' made it.

Another error happened ,some of the errors log like :
dense_warp_flow_gpu.cpp:(.text+0x251a)：对‘cv::cuda::BroxOpticalFlow::create(double, double, double, int, int, int)’未定义的引用
dense_warp_flow_gpu.cpp:(.text+0x2de0)：对‘cv::cuda::split(cv::_InputArray const&, cv::cuda::GpuMat*, cv::cuda::Stream&)’未定义的引用
dense_warp_flow_gpu.cpp:(.text+0x377a)：对‘cv::cuda::split(cv::_InputArray const&, cv::cuda::GpuMat*, cv::cuda::Stream&)’未定义的引用
my envirenment:Ubuntu 16.04 + CUDA 10.1,and I  download NVIDIA VIDEO CODEC SDK and copy the two header files to  cuda path .

@yangyuke001
Are you enabling CUDA when install opencv?

@zhaoyue-zephyrus
yes
cmake -DCMAKE_BUILD_TYPE=Release -_DWITH_CUDA=ON ...

@yangyuke001
What about explicitly specifying the opencv 4.1.0's path by OpenCV_DIR=/PATH/TO/OPENCV4 cmake ..?

@zhaoyue-zephyrus
1.
OpenCV_DIR=../../../third_party/opencv-4.1.0/build
2.
when cmake,some of the log:
-- Found CUDA: /usr/local/cuda (found suitable exact version "10.1")
-- Found OpenCV: /usr/local (found version "3.4.0")
......
fatal error: opencv2/xfeatures2d.hpp: No such file or directory
......
heart-broken

@yangyuke001
Well, this makes sense. The log is telling you that you are using some other OpenCV (i.e. 3.4.0) which possibly wasn't built with CUDA. To avoid this, you have to delete the cache produced by previous cmake. The safest thing is to rm -r build/ and build again. Would you like to have another try? Also, you can see if the OpenCV is set correct (should be "4.1.0") by watching the cmake's log.

@zhaoyue-zephyrus
It's almost done.
But there are some tiny mistake,such as,
in dense_flow.cpp and other .cpp file:
CV_BGR2GRAY   should be  replaced by  COLOR_BGR2GRAY
in dense_flow.cpp :+1:

cv::Ptrcv::optflow::DualTVL1OpticalFlow alg_tvl1 = cv::optflow::DualTVL1OpticalFlow::create();

cv::Ptrcv::superres::DualTVL1OpticalFlow alg_tvl1 = cv::superres::createOptFlow_DualTVL1();

@yangyuke001  Good to hear that:)
Actually what you mentioned have been merged into the master branch. (Check it out at https://github.com/yjxiong/dense_flow/blob/master/src/dense_flow_gpu.cpp#L32 for example)
I will update the submodule and the related workaround quickly.

@zhaoyue-zephyrus
Awesome !


ND4J: concat op fails with 3073 or more inputs on CPU

NOTE: A workaround is available - this is a MKLDNN (OneDNN / DNNL)-specific issue.
Nd4j.getEnvironment().allowHelpers(false);
This can be set temporarily if the large concatenation is only performed once (for example, in word vectors loading).

CUDA is fine. CPU fails.
With 3072 input arrays: test case is fine on CPU also. With 3073 or more: it fails.
Also we should put a limit on the number shapes that we print in ops.
    @Test
    public void testVstack(){
        List<INDArray> in = new ArrayList<>();
        for( int i=0; i<3073; i++ ){
            in.add(Nd4j.create(DataType.FLOAT, 1, 50));
        }
        INDArray out = Nd4j.vstack(in);
    }

o.n.l.c.n.o.NativeOpExecutioner - Failed to execute op concat. Attempted to execute with 3073 inputs, 1 outputs, 0 targs,0 bargs and 1 iargs.  Outputs: [(FLOAT,[3073,50],c)]. tArgs: -. iArgs: [0]. bArgs: -. Op own name: "0c695069-4b90-493f-9a63-aab9fdb5223a" - Please see above message (printed out from c++) for a possible cause of error.

java.lang.RuntimeException: Op [concat] execution failed

	at org.nd4j.linalg.cpu.nativecpu.ops.NativeOpExecutioner.exec(NativeOpExecutioner.java:1594)
	at org.nd4j.linalg.factory.Nd4j.exec(Nd4j.java:6566)
	at org.nd4j.linalg.cpu.nativecpu.CpuNDArrayFactory.concat(CpuNDArrayFactory.java:590)
	at org.nd4j.linalg.factory.Nd4j.concat(Nd4j.java:4856)
	at org.nd4j.linalg.factory.BaseNDArrayFactory.vstack(BaseNDArrayFactory.java:986)
	at org.nd4j.linalg.factory.Nd4j.vstack(Nd4j.java:4640)
	at org.nd4j.linalg.factory.Nd4j.vstack(Nd4j.java:4651)
	at org.nd4j.Temp.testVstack(Temp.java:63)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
Caused by: java.lang.RuntimeException: could not execute a primitive
	at org.nd4j.linalg.cpu.nativecpu.ops.NativeOpExecutioner.exec(NativeOpExecutioner.java:1924)
	at org.nd4j.linalg.cpu.nativecpu.ops.NativeOpExecutioner.exec(NativeOpExecutioner.java:1573)
	... 29 more

Fixed. Seems to be MKLDNN limitation.

I still have this issue and the workaround fixes it on 1.0.0-beta7. I thought the underlying issue was fixed?


Why isn't AFSecurityPolicy validatesDomainName enabled default?

AFSecurityPolicy's "validatesDomainName" is set to NO by default, and only when using policy created from +policyWithPinningMode: does this flag get enabled.
What is the reason for this flag to default to NO? It appears that all SSL/TLS traffic should evaluate DN by default, and only for cases explicitly specified by the dev should it be changed to NO. It should be treated similar to the "validatesCertificateChain" flag.
Note that there are places where it's not possible to enforce enabling "validatesDomainName", like request operations created inside of UIImageView+AFNetworking and UIButton+AFNetworking. These requests will never follow the security policy set on the HTTP client/request manager.

The default security policy is AFSSLPinningModeNone, and having validatesDomainName set to NO is consistent with this. If you require security evaluation for remotely loading images, do not use the built-in UIKit categories.

@mattt thanks for the response. However, AFSSLPinningModeNone for SSLPinningMode is a setting for certificate pinning. I'm not talking about certificate pinning, but regular SSL/TLS trust evaluation.
Not validating the name in the SSL certificate against the hostname during SSL traffic is considered to be an extremely bad practice, exposing all AFNetworking clients to a potential Main in the Middle attack.
As is, AFNetworking is altering the security policy setting, which directly violates Apple's API guidelines:

Do not disable hostname checking by creating a non-TLS policy or passing in a NULL pointer for the  hostname. If you are intentionally connecting to a host using a hostname other than one of the names listed on its certificate, you should allow the operation only if the certificate you receive from that host is valid for some other domain that you control.

(https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/NetworkingTopics/Articles/OverridingSSLChainValidationCorrectly.html)
Also note that due to TLS Session Cache that takes place in SecureTransport layer (https://developer.apple.com/library/ios/qa/qa1727/_index.html), if the AFNetworking client hosts images on the same server (IP+name+port) as their other content that needs to be protected, if the first request is to fetch an image (without validating the name), the remaining calls could suffer from MITM attack for the next 10 minutes as the same (not fully protected) SSL session would be reused by iOS.
Given the above, I strongly encourage AFNetworking to follow the established security standards and default to the more secure settings, and allow the users to opt-out as needed for testing/debugging.


Post release automated changes for vision releases

Post release automated changes for azure-rest-ai-vision-image-analysis

/check-enforcer override


fix(charts): Remove unnecessary sensitive permissions for DaemonSet agent and Pod init

What type of PR is this?

release/bug

What this PR does / why we need it:
This PR removes unnecessary RBAC permissions for the DaemonSet agent and Pod init to avoid potential security risks. Technically, this PR does:

Create a separate ClusterRole for each workload
Remove some unnecessary permissions applied by the DaemonSet agent and Pod init

This PR minimizes the deletion of permissions to avoid affecting the normal function of the APP. However, there should still be some unnecessary RBAC permissions (such as for the Deployment controller).
Also, this PR DOES NOT include changing the kubebuilder annotation in: pkg/k8s/apis/spiderpool.spidernet.io/v2beta1/rbac.go
Which issue(s) this PR fixes:

Fixes #3420
Fixes #3361
Special notes for your reviewer:
The removed permission from the permission rules are as follows:

DaemonSet agent

delete/deletecollection/patch/update verb of nodes/pods

As suggested in #3420

update verb of daemonsets/deployments/replicasets/statefulsets

As suggested in #3420

update verb of cronjobs/jobs

As suggested in #3420

get/list/watch verb of *

As suggested in #3361, in order to remove get/list verb of secrets
This change needs to be carefully review since it contains a wildcard.
This change only deletes this rule, the get/list/watch permissions applied in other rules will not be affected.

Pod init

delete/deletecollection/patch/update verb of nodes
update verb of daemonsets/deployments/replicasets/statefulsets
update verb of cronjobs/jobs

I am more aggressive in deleting the permissions of DaemonSet agent, mainly because DaemonSet will be deployed to any worker node in the cluster, so attackers have more opportunities to obtain the ServiceAccount token of DaemonSet agent.

After the fix, some issues occurred, it seems that there is insufficient permissions.
  Warning  FailedCreatePodSandBox  118s                kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "91390322e1fcc5b6f8011c1f9292f3eaaba9db0b6704d79a8315413f16f05b04": plugin type="multus" name="multus-cni-network" failed (add): [default/test-pod-57c88b845c-prtfb/35ed07d0-ee08-4a64-963b-75dfeff0eb2c:macvlan-vlan0]: error adding container to network "macvlan-vlan0": failed to GetCoordinatorConfig: [GET /coordinator/config][500] getCoordinatorConfigFailure  spidercoordinator: default no ready

Thanks @ty-dc. Seems like the removal in my latest commit is too aggressive. I'll revert them.

Hi @kaaass, codes look good now, Could you squash the comments? now we have 6 comments on the PR. it would be nice if we can squash to one comment.

@cyclinder Sure! I've pushed them

actually, I expect upgrading CI to test this PR @ty-dc

actually, I expect upgrading CI to test this PR @ty-dc

ok


legacy split clone copy data bug fix

legacy split clone copy data bug fix, which may lead data Inconsistent、duplicate Primary key.

I signed it!

Yeah, this is an actual issue :(
I'm surprised the e2e test didn't catch this: https://github.com/youtube/vitess/blob/master/test/merge_sharding.py
Do we have to change the test?


[3.0] ui-grid 'ui.grid.selection' messing up grid display

I'm trying out the ui.grid.selection on my grid and it's behaving oddly(see picture below). My code is very bare bones at this point so not sure what would be breaking it if it's on me. I followed the tutorial http://ui-grid.info/docs/#/tutorial/210_selection
Controller:
$scope.shiftGrid = {
        enableSorting: true,
        enableFiltering: true,
        enableCellEditOnFocus: true,
        enableRowSelection: true,
        columnDefs: [
          { field: 'ShiftID', displayName: 'Shift ID', type: 'number', width: '20%', enableCellEdit: true },
          { field: 'ShiftDesc', displayName: 'Description', type: 'string', width: '50%', enableCellEdit: true },
          { field: 'Capacity', displayName: 'Capacity', type: 'number', width: '30%', enableCellEdit: true },
        ]
    };

    $scope.shiftGrid.multiSelect = true;

HTML:

Here's the picture:

This issue still exists in chrome. it works fine in other browsers but it still seems to appear in chrome.

I see this as well in FireFox. Any update or workaround? I'm using v3.0.0-RC.18-270d031. Also, when I view the selection tutorial on the ui-grid.info site it's jacked up too...

I'm using v3.0.0-RC.20 and having this issue on Mac OS 10.8.5 and 10.10 using FF, Chrome, and Safari
It the best case its glitchy.

I am also having this issue, I have found that it seems to be fine if you specify the data at the creation of the grid, but when you load the data through an ajax call after the controller loads it causes the grid to not display properly until a window resize.


Wall Climb

Describe the bug
I am trying to create a wall climb effect comparable to Metroid. Using the "If Joypad Input Pressed" on several triggers that lay on the wall.
To Reproduce
Steps to reproduce the behavior:

Expected behavior
Smoothly climbing the wall much like in Metroid
Screenshots
The wall climbing has the character dip inward and doesnt run very smooth. Luckily it works good but unfortunately doesn't look great. I have tried everything to make it smooth.
Here is a slow motion GIF of the issue.

Platform (please complete the following information):
Gbstudio 2 beta 4
Additional context

An image of the scene, showing how you have placed triggers and collision might help. As well as the x,y coordinates of the wall.
Most likely the tile values for each moveto are off by 1, As you said there are multiple triggers in the walls, mistakes are easy.
You should have better results with Larger thin triggers on walls (triggers can be resized),
and Move Relative events, which move + - an amount of tiles, relative to the players last position, simplifying a lot of code.
For the top/corner, you could either use a new trigger for the top, or as part of the wall trigger, check If Player is at X, Y.

An image of the scene, showing how you have placed triggers and collision might help. As well as the x,y coordinates of the wall.
Most likely the tile values for each moveto are off by 1, As you said there are multiple triggers in the walls, mistakes are easy.
You should have better results with Larger thin triggers on walls (triggers can be resized),
and Move Relative events, which move + - an amount of tiles, relative to the players last position, simplifying a lot of code.
For the top/corner, you could either use a new trigger for the top, or as part of the wall trigger, check If Player is at X, Y.

I tried everything under the sun. on multiple walls. It is definitely a bug. The relative movement option doesnt work as well

Describe the bug
I am trying to create a wall climb effect comparable to Metroid. Using the "If Joypad Input Pressed" on several triggers that lay on the wall.
To Reproduce
Steps to reproduce the behavior:

Expected behavior
Smoothly climbing the wall much like in Metroid
Screenshots
The wall climbing has the character dip inward and doesnt run very smooth. Luckily it works good but unfortunately doesn't look great. I have tried everything to make it smooth.
Here is a slow motion GIF of the issue.

Platform (please complete the following information):
Gbstudio 2 beta 4
Additional context

This worked like a charm. Thank you so much!


Add keywords project property

Renku schema now defines a keywords property for projects. This needs to be integrated into search:

Add property to project document (using proper type and solr schema)
Adopt code, e.g. SerializeDeserializeSpec, EventsGenerators, ProjectEventsGenerator, DocumentMerger, etc
extend user query to support keyword:<kw1>[,kw2,...] syntax
add keywords to content_all field so they are searched when using "free" query

done as #92


Enable link-time optimization in compiler.

Description
This will enable link-time optimization the base image, which will in turn enable us to compile RocksDB from source as a direct dependency of TFRA.
Type of change

[X] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Feature

For no merge


[Bug]: Unable to set use_public_bgp as true for agent_to_server tests

What versions are you using?
Provider version  2.0.2
Terraform version 1.5.7
What did you expect to happen?
After configuration applied via terraform without any error/warning that the configuration/parameter that's supported by this provider to be set on ThousandEyes test.
Parameter use_public_bgp for agent_to_server tests:  https://registry.terraform.io/providers/thousandeyes/thousandeyes/latest/docs/resources/agent_to_server#use_public_bgp
What actually happened?
Terraform apply is successful, but configuration is not changed/update on ThousandEyes platform.
Parameter use_public_bgp for agent_to_server tests:  https://registry.terraform.io/providers/thousandeyes/thousandeyes/latest/docs/resources/agent_to_server#use_public_bgp
Terraform code to reproduce the bug
resource "thousandeyes_agent_to_server" "example_agent_to_server_test" {
  test_name      = "test
  interval       = 120
  alerts_enabled = false
  use_public_bgp = true
  protocol       = "ICMP"

  server = "www.thousandeyes.com"

  agents {
    agent_id = 3 # Singapore
  }
}

Any additional comments or code?
No response
Steps to reproduce the bug
% terraform apply -target=module.network.thousandeyes_agent_to_server.example_agent_to_server_test
module.network.thousandeyes_agent_to_server.example_agent_to_server_test: Refreshing state... [id=281474976731002]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.network.thousandeyes_agent_to_server.example_agent_to_server_test will be updated in-place
  ~ resource "thousandeyes_agent_to_server" "example_agent_to_server_test" {
        id                     = "281474976731002"
      ~ use_public_bgp         = false -> true
        # (23 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
<SANITIZED>

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.network.thousandeyes_agent_to_server.example_agent_to_server_test: Modifying... [id=281474976731002]
module.network.thousandeyes_agent_to_server.example_agent_to_server_test: Modifications complete after 3s [id=281474976731002]
<SANITIZED>

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

% terraform plan -target=module.network.thousandeyes_agent_to_server.example_agent_to_server_test
module.network.thousandeyes_agent_to_server.example_agent_to_server_test: Refreshing state... [id=281474976731002]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.network.thousandeyes_agent_to_server.example_agent_to_server_test will be updated in-place
  ~ resource "thousandeyes_agent_to_server" "example_agent_to_server_test" {
        id                     = "281474976731002"
      ~ use_public_bgp         = false -> true
        # (23 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Hello @kiraum,
You'll need to use the bgp_measurements flag as a primary means of manipulation of the BGP layer for a test. The additional use_public_bgp flag is only used to indicate (when enabling) that all public BGP monitors should be used (the alternative would be to use the bgp_monitors to specify individual (private) BGP monitors). When disabling BGP layer on a test, use_public_bgp parameter should be set to false too, or removed altogether.

@bskufcate thanks for helping out. @kiraum can you confirm if this can be closed? Probably we should improve our docs a little bit in regards to this

Yes, I am fine closing it, thanks!


fix(track): segfault when decoding large dims

GK uses int32s for interval positions, but when multiplied with a dim component for storing/reading tracks, this can overflow (ie, reading/writing to negative positions).
There are several existing size_t promotions in the encode logic, so the simplest method is to do an onsite promote (rather than rework the logic to handel unsigned comparisons w/ underflow).

pushing ahead of approval as ovesh is on vacation


Update README.md

Fixed links that were pointing to branch instead of master

Looks good. You can also just give the hashtag section of the link and it will be interpreted as "local". Check out the nav bar PR from this morning for example.

oh cool! i'll swap that in next time i have to modify this file


Add Cartage support and x label width fix

Add carthage support
Fix x label width when xLabelSkip > 1

@Igor-Palaguta thanks for pulling request. I will review the codes and merge it later.


Remove Patch as it is not documented and not profiled enough.

Given that Patch is not explained anywhere in the narrative, and the Parameters are not profiled. Also, I don't recall discussing or agreeing to add this support.
This PR removes the profiling and examples.
close #222

This feature can be brought back in the future when it can be fully specified and identified properly with an option.

I think we discussed it at a f2f, see https://github.com/IHE/ITI.MHD/blame/573feec18eb669ecce8c8d0e4fee91df1c5da5aa/input/fsh/ex-ProvideBundles3.fsh#L219

If a DocumentReference will be replaced, the to be replaced DocumentReference needs to be added and updated to status 'superseded' within the transaction bundle.

I will have look at it this weekend or latest monday

see PR https://github.com/IHE/ITI.MHD/pull/227, if ok this one can be closed


Added skipping support

This is another attempt to add skipping support (see also #5). This implementation is based on code from CWPack and does not use recursion.
Before this is merged, two things should be considered:

obj_skip_count is currently a uint32_t and could overflow (e.g. while reading malicious data). Extending the type to uint64_t would help with the problem (at least a bit), but I didn't really want to change it, since I use cmp on an embedded device. Maybe instead, we could check for overflow and exit with an error.
Skipping of strings/bin/ext currently reads one byte at a time, since there is no buffer available. This could be replaced with a skip/seek function pointer. Instead a buffer of configurable size could be added (see #3).

Nice to see that you added the error checking!
For your first point, you could define obj_skip_count as size_t: http://stackoverflow.com/questions/2550774/what-is-size-t-in-c : size_t is a type guaranteed to hold any array index.

For your first point, you could define obj_skip_count as size_t

I thought about that, but size_t is only guaranteed to be at least 16 bit. Although I don't know of any platform that uses less than 32 bits, it might be a problem for some obscure architectures or compilers. MsgPack allows for arrays and maps to contain up to 2^32 entries (2^33 if you count the keys/values in a map separately). And nested arrays/maps also increment the obj_skip_count. So a single array with 2^32 entries, containing an array with 20 elements will result in an overflow, although it should be valid data. I'm not sure if such a case has to be handled correctly (rather unrealistic data) or if it could be used maliciously.

It is also guaranteed to be able to represent any sizeof() result, therefore it will be at least 32 bit on 32 bit machines and 64 bits on 64 bits machines.

Hey, thank you so much :) :) :+1:
I'll try and dedicate some time to this tomorrow, sorry I've been slacking.

I've started working on a different approach to skipping, functions starting here.  Let me know what you think.

Closing this; different implementation has been merged into master.


Pypi

@llonchj can you please upload new version (with latest merge) to pypi.
Thanks you!

@unk2k Thanks for your request. It should be there 0.9.0. Please reopen in case of problems


[FLINK-4801] [types] Input type inference is faulty with custom Tuples and RichFunctions

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

This PR solves an issue with TypeExtractor logic separated into two methods createTypeInfoFromInput and findCorrespodingInfo. I merged the two methods into one and added a test for it.

Looks reasonable to me, Travis tests pass.
+1

Merging this...


HTMLCanvasElement.toBlob callback is run outside current zone

HTMLCanvasElement.toBlob callback is run outside current zone.
It seems that this method is not wrapped by zone.js.

thank you for posting the issue, I will wrap it.

It seems that this patch cause Safari throws an error
SecurityError (DOM Exception 18): The operation is insecure.
toBlob

@clarkorz, could you provide the safari version and os version? thank you.

Safari 11.0.1 (126<IP_ADDRESS>.1)
Mac 10.13.1 (17B1003)
We are trying to use image-compressor in our angular5 project. related issue: https://github.com/xkeshi/image-compressor/issues/17


No release to npm registry since 2016-10-02

Could you please do another release into the npm registry? There are a lot of new features and corrections, which have not found their way into the official npm package yet.

Hi @cloudyafternoon
v0.7.16 has been release.
And thank you for your reminder and PR.


Prefixes aren't working,

I have no idea what I'm doing wrong, I've set up the groups, I've set up the group's prefixes, but they arent displaying the prefixes in game - What it says is [world] (ign) >> ______
The plugins we have installed are:
BF	-	Folder
CoreProtect	-	Folder
Essentials	-	Folder
HolographicDisplays	-	Folder
LuckPerms	-	Folder
Multiverse-Core	-	Folder
OpenInv	-	Folder
PlayerHeads	-	Folder
PluginMetrics	-	Folder
Updater	-	Folder
WorldEdit	-	Folder
WorldGuard	-	Folder
bStats	-	Folder
ArtMap-master.zip
CoreProtect-2.16.3.jar
EssentialsX-<IP_ADDRESS>.jar
HolographicDisplays.jar
LuckPerms-Bukkit-4.4.1 (1).jar
Multiverse-Core-3.0.0-SNAPSHOT.jar
OpenInv.jar
PlayerHeads.jar
votifier-1.9.jar
worldedit-bukkit-7.0.0-beta-05.jar
What should I do?

You need to have Vault installed.
LuckPerms provides the prefixes through Vault so that other plugins can use it.

Alright thank you

I downloaded the vault.jar but it still seems to not be working

You need to install a chat formatting plugin too. ;)
https://github.com/lucko/LuckPerms/wiki/Prefixes,-Suffixes-&-Meta#displaying-prefixes-and-suffixes


Not production ready

This Btree works, but its not production ready.  Overflows and concurrency need to be corrected.

Restructuring like:
// BTree is the main BTree struct
type BTree struct {
	File        *os.File                // The open btree file
	T           int                     // The order of the tree
	PageLocks   map[int64]*sync.RWMutex // Locks for each btree node, consumes some memory but allows for concurrent reads
	PageLocksMu *sync.RWMutex           // Lock for the page locks
}

// Key is the key struct for the BTree
type Key struct {
	K            []byte // The key
	V            *Value // Key can have multiple values, in form of a linked list
	OverflowPage int64  // Key is overflown to another page
	Overflowed   bool   // If the key is overflown
}

type Value struct {
	V            interface{} // The value
	OverflowPage int64       // Value is overflown to another page
	Overflowed   bool        // If the value is overflown
	Next         int64       // Next value in the linked list, is a page number
}

type OverflowPage struct {
	Page         int64  // The page number of the overflow page
	Data         []byte // The data in the overflow page
	OverflowPage int64  // Overflow page for the overflow page
	Overflowed   bool   // If the overflow page is overflown
}

// Node is the node struct for the BTree
type Node struct {
	Page         int64   // The page number of the node
	Keys         []*Key  // The keys in node
	Children     []int64 // The children of the node
	Leaf         bool    // If the node is a leaf node
	OverflowPage int64   // Overflow page for the node
	Overflowed   bool    // If the node is overflown
	Reuse        bool    // If node is marked reuse, we can use the node for new keys instead of allocating a new node
}

Could work

Got a fix coming in for the concurrency on insert and delete using a latching like locking flow; Also taking what I got from Reddit I will be replacing the current overflow logic with something more efficient to handle large keys and values. Keep an eye out.


How can I avoid using host network mode and just bind a ports?

version: '3.3'
services:
  ...
  socks5-proxy-v2:
    container_name: socks5-proxy-v2
    image: schors/tgdante2
    ports:
      - 1081:1080
    environment:
      - USER=user
      - PASS=pass
      - PORT=1080
    restart: unless-stopped
    #network_mode: "host"

Seems like container binds to the host's loopback instead of listening to <IP_ADDRESS>, locally everything works fine, firewall allows connection to 1081.

just need to fix dante.conf to user PORT variable somehow

Port mapping is incompatible with network_mode: host


How to integrate with Argo Workflows

Goal
Find out, what would be a good Keptn feature to integrate into Argo Workflows. The integration should be as straight forward as possible for this MVP.
Details

Research how the integration would work (plugins, extensions, etc.).

DoD

strategy/plan on how to integrate keptn feature
PoC if easily possible

this can be closed now as there is also a new blog post scheduled to be released about this topic: https://github.com/keptn/lifecycle-toolkit/pull/3487


Async WiFi: connect/disconnect/scan/wait_for_event

First off, I'm sorry. This PR got a bit out of hand scope-wise and ends up doing a few things, hopefully reviewing it isn't too much of a pain!
This PR accomplishes the following:

Adds and implements async variants of the embedded::wifi::Wifi trait
Plus one more, wait_for_event to asynchronously  wait for any Wifi related events
splits wifi into two parts, device and controller

where device is the thing passed into stacks for packet send/recv
where controller handles the link/connection

Closes #120
Closes #126
Moves the transmit waker inside the check as to whether we actually sent the packet! This didn't break anything but was less efficient

This can actually be improved even further later on down the line, see https://github.com/embassy-rs/embassy/issues/1212#issuecomment-1427150821

Clears scan memory on failure to avoid memory leaks

Nice changes - especially "splits wifi into two parts, device and controlle" is something I already had in mind.
Unfortunately, this breaks esp-now examples since it needs the wifi adapter to be in STA mode and started which always was the case after initialize before
Second thing, compiling embassy-dhcp / embassy-esp-now generates compiler errors
error[E0599]: `&'static AtomicWaker` is not an iterator
   --> esp-wifi\src\wifi\os_adapter.rs:932:19
    |
932 |     event.waker().map(|w| w.wake());
    |                   ^^^ `&'static AtomicWaker` is not an iterator
    |
   ::: ....\.cargo\registry\src\github.com-1ecc6299db9ec823\embassy-sync-0.1.0\src\waitqueue\waker.rs:59:1
    |
59  | pub struct AtomicWaker {
    | ---------------------- doesn't satisfy `AtomicWaker: Iterator`
    |
    = note: the following trait bounds were not satisfied:
            `&'static AtomicWaker: Iterator`
            which is required by `&mut &'static AtomicWaker: Iterator`
            `AtomicWaker: Iterator`
            which is required by `&mut AtomicWaker: Iterator`

Oops, my commit last night broke it :sweat_smile:, should be fixed now :)

LGTM! I have very limited knowledge about esp-wifi but the changes make sense to me. I've tested the dhcp example to check #120, and it was working fine for me.
Just two small question, that can ofc be addressed, if needed, in other PRs:

Shall we cover embassy_dhcp example in CI? embassy_esp_now and esp-now are not covered either.
That is a good idea! As you said probably in a separate PR

Shall we include a column for async wifi in the current support table?
Not sure since it's not chip specific. Now if we have WiFi we also have Async-WiFi

Thanks for the reviews! I'll create an issue about adding CI and merge this now :)


Add Dockerfile and fix the pytest for matplotlib

Pytest error faced when running evaluation for matplotlib:
Test Script: . /SWE-bench/testbed/claude-2/matplotlib__matplotlib/3.6/tmp13m3m8ts/miniconda3/bin/activate matplotlib__matplotlib__3.6 && echo 'activate successful' && pytest --no-header -rA --tb=no -p no:cacheprovider lib/matplotlib/tests/test_subplots.py;
Output:
activate successful
/bin/sh: 1: pytest: not found

>>>>> Some Tests Failed

@xingyaoww thanks so much for these suggestions!
We've noticed a lot of the same issues on our side + incorporated suggested and new fixes to SWE-bench over the last couple weeks to make evals more reliable and robust. The report is here.
The fixes you suggested, primarily:

Using . instead of source
Adding more explicit pypi packages to the installation specifications
have been incorporated at this point.

We are currently working on putting out a Dockerfile that is reflective of the x86 machine we've been using to run evaluation. The one you've included in this PR from the issue comment is good, but a bit incomplete. Closing this PR for now, but we'll be sure to follow up when the Dockerfile + instructions on running validation/evaluation in Docker has been added!
Thanks so much again for the contribution 😄


be more forgiving on the config layout

make the config parser a little bit more forgiving and not freaking out if stuff is some place else
case in point the current one
domain.com:80 {
        root /var/www/
        basicauth / user pass
        browse
        markdown
        gzip
        fastcgi / /run/php/php7.0-fpm.sock php
        rewrite /private { status 403 }
}

if the parser was a little forgiving
domain.com:80 { root /var/www/
        basicauth / user pass
        browse markdown gzip
        fastcgi / /run/php/php7.0-fpm.sock php
        rewrite /private {status 403} }

going from 9 lines down to 5! and as a added bonus it will work

But the second one looks ugly and is hard to read.

This would add more complexity to the parser without returning any real benefit. I agree with @mholt and think that It's more like a feature that one is forced to write clean config files, instead of saving some whitespace and make it less obvious.


SwiftUI -> Accessibility support: Accessibility fundamentals

Doc: https://developer.apple.com/documentation/swiftui/accessibility-fundamentals

Resolved with #1154


Server-side security

Take measures against possible security issues such as CSRF and XSS.

[ ] Include Helmet ExpressJS middleware to the API.
[ ] Cyber security review with Aalto IT

ExpressJs best practices on security

Brute-force attack tests are probably not needed because we will be throttling the login attempts. Also we have requirements for admin password strength that should make passwords hard to crack (even with the hash)


Confirmation of prefixes and maxmemory

I am using Predis 1.1 (and PHP 7.0.7) for session handling and data caching.  I would like to use a different prefix for each.  I assume that I have to create two separate clients, but wanted to confirm that there's no way to use a different prefix for session and data caching with one client.  Is his correct?  Also, is the maxmemory configuration value shared among all clients I create?
Thank you

You must indeed use two separate client instances.
What do you mean by maxmemory?

I'm sorry I was not clear.  I was referring to the maxmemory value in /etc/redis.conf.  Do all instantiated predis clients share the maxmemory limit?  E.g. If I create a predis client for session handling and a predis client for application data caching (both in the same php script with different prefixes), will the predis clients share the 100mb maxmemory limit?  I'm assuming they share it, but just wanted to confirm.  Thank you.

maxmemory is a server setting that imposes an hard memory limit for the running Redis instance, from the point of view of clients it's completely transparent. Setting maxmemory is fine when storing cache data, but I don't think it's good for sessions as session keys could be unexpectedly evicted by Redis. You might want to use two separate Redis instances in this case, one using maxmemory in its redis.conf file for the volatile cache and one without maxmemory for sessions.


change the IAM policy for osdManagedAdmin user - OSD-2360

cc @jharrington22 Could you help review the change?

Is there a reason for this change? Is there a card to go along with it?

Is there a reason for this change? Is there a card to go along with it?

https://issues.redhat.com/browse/OSD-2360 Yes, here is the related card.

/hold merging this will break layered products which require additional resources on top of what we need for OSD

@rogbas Please follow up with this PR, thank you.

@bmeng part of the reason we use the AWS policy is so that we can ensure that the policy is the same every time, its the same policy we ask customers to use for CCS.
In reality without modifying logic to make this operator aware of layered products we cannot do this (and I don't think we should make it aware of LP).
We could however ask CCS customers to use restricted SCP's and or use a different OU for LP and apply a less restrictive policy that the OSD policy at an account level for non CCS.
+1 to close this PR for the time being if everyone agrees :smile:


Remove deprecations and set new config defaults

This is built on top of https://github.com/rspec/rspec-expectations/pull/1245, and should be rebased and retargeted against 4-0-dev once #1245 is merged.

Flip include_chain_clauses_in_custom_matcher_descriptions default

From 3.1.0 changelog (https://github.com/rspec/rspec-core/blame/main/Changelog.md#L773):

the new rspec-expectations include_chain_clauses_in_custom_matcher_descriptions config option (which will be on by default in RSpec 4)

Remove support for legacy RSpec 1&2 matchers

As per http://rspec.info/blog/2013/07/the-plan-for-rspec-3/:

compatibility layer so that existing matchers will continue to work, with the plan to remove that compatibility layer in RSpec 4

Remove deprecated LegacyMacherAdapter (with typo)

... am I missing something?

Some how the last change has messed up the history to include all the other changes?

I've branched this PR off https://github.com/rspec/rspec-expectations/pull/1245, so this is as expected.
History needs some commit juggling anyway. I want to spread the Changelog changes over commits. Also, the base PR was fixed up, so a rebase on it will be needed.
Can't tell for sure, but I believe there might be some overlapping changes. Converted this to draft until #1245 is merged.


TP2000-399 fix missing current versions

relates to issues raised in TP2000-399 : fix underlying missing current version fix
Why
This PR creates a migration that updates the current version where the current version is missing, allowing valid existing records to be updated correctly, where as before a new record would be created and result in business rule violations either at TAP or CDS
What
Add migration to update current version programatically for all missing current versions (around 150 records)
Add tests to verify the migration works correctly
See: https://uktrade.atlassian.net/browse/TP2000-399

Codecov Report
Base: 93.54% // Head: 93.46% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (0fd6bec) compared to base (79d960f).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   93.54%   93.46%   -0.09%
==========================================
  Files         344      345       +1
  Lines       22749    22777      +28
  Branches     1762     1762
==========================================
+ Hits        21281    21288       +7
- Misses       1139     1160      +21
  Partials      329      329

Impacted Files
Coverage Δ

common/tests/test_migrations.py
25.00% <25.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


White Screen - Renderbox did not set its size

RenderBox did not set its size during layout.
Because this RenderBox has sizedByParent set to true, it must set its size in performResize().
It appears that this did not happen; layout completed, but the size property is still null.
The RenderBox in question is: GameRenderBox#7a1b6 NEEDS-LAYOUT NEEDS-PAINT
parentData:  (can use size)
constraints: BoxConstraints(w=827.8, h=411.4)
size: MISSING
When the exception was thrown, this was the stack:
#0      RenderBox.debugAssertDoesMeetConstraints. (package:flutter/src/rendering/box.dart:2175:9)
#1      RenderBox.debugAssertDoesMeetConstraints (package:flutter/src/rendering/box.dart:2300:6)
#2      RenderObject.layout. (package:flutter/src/rendering/object.dart:1782:9)
#3      RenderObject.layout (package:flutter/src/rendering/object.dart:1784:8)
#4      RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:277:14)
...
The following RenderObject was being processed when the exception was fired: GameRenderBox#7a1b6 NEEDS-LAYOUT NEEDS-PAINT
...  parentData:  (can use size)
...  constraints: BoxConstraints(w=827.8, h=411.4)
...  size: MISSING
RenderObject: GameRenderBox#7a1b6 NEEDS-LAYOUT NEEDS-PAINT
parentData:  (can use size)
constraints: BoxConstraints(w=827.8, h=411.4)
size: MISSING
======== Exception caught by rendering library =====================================================
The following assertion was thrown during performLayout():
RenderBox was not laid out: GameRenderBox#7a1b6 NEEDS-PAINT
'package:flutter/src/rendering/box.dart':
Failed assertion: line 1930 pos 12: 'hasSize'

This is just some log. Can you provide some steps for this? What were you doing when this occurred?

Can you try re-building the project with flame version set to exactly 0.28.0 in pubspec.
You'll just have to change:
flame: ^0.28.0
to
flame: 0.28.0

Still the same error.

I think the issue might be somewhere in Flame's code. But 0.28.0 is anyways too old and is not recommended. Unfortunately, upgrading this project to latest Flame version isn't trivial. But I've already started rewriting the whole game with latest version of Flame. I'll update the repository as soon as it completes.

Migrate the whole project to null-safety and latest packages. This issue is now fixed on rewrite branch.


🌱 Add policy fuzzer

Adds a fuzzer for ParseFromYAML as discussed in https://github.com/google/oss-fuzz/pull/7269

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[x] PR title follows the guidelines defined in  https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds a fuzz test.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:

I think it would be great to turn on CIFuzz/CFLite as well. Hopefully scorecard complaining about unpinned dependencies in scorecard :-) could help to fix issues like https://github.com/google/oss-fuzz/issues/7206 and https://github.com/google/oss-fuzz/issues/6836 a bit faster.

Codecov Report

Merging #1631 (b87453b) into main (394789c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1631   +/-   ##
=======================================
  Coverage   55.64%   55.64%
=======================================
  Files          72       72
  Lines        6513     6513
=======================================
  Hits         3624     3624
  Misses       2647     2647
  Partials      242      242

Please don't merge this till we have build integrated to validate the fuzz code.

Please don't merge this till we have build integrated to validate the fuzz code.

@naveensrinivasan https://google.github.io/oss-fuzz/getting-started/continuous-integration/ is supposed to do exactly that. I should have posted that link probably. Sorry!

The scorecard has to compile anytime the code changes locally to avoid breaking this.
Here is an example of fuzzing compile target
https://github.com/sigstore/sigstore/blob/main/Makefile

The scorecard has to compile anytime the code changes locally to avoid breaking this.

I agree. Ideally it should be integrated into the build process but in general I wouldn't expect extIernal contributors to always build and run all the tests/fuzzers before PRs are submitted so CIFuzz is supposed to help there.

The external contributors need not but the CI on GitHub should validate this.

The external contributors need not but the CI on GitHub should validate this.

@naveensrinivasan I completely agree with you. What I was trying to say is that in addition to that it usually makes sense to turn on CIFuzz because the build and runtime environments provided by OSS-Fuzz are different from what fuzz target normally face locally or on GitHub. For example, CIFuzz caught https://github.com/systemd/systemd/actions/runs/1833518567 today even though the fuzz targets were built and run locally and on GitHub Actions.

Also we need documentation as to how build this and test it.
Does it need go-tip, Go-fuzz?
We need to refer to Go-Fuzz in the go.mod. This makes adding additional dependency.
Probably the fuzz should be a separate module to avoid these additional dependencies.
So my recommendation would be we discuss these options and then merge this in.
The fuzz need not be for just a func. The goal would be to add to many targets.

The external contributors need not but the CI on GitHub should validate this.

@naveensrinivasan I completely agree with you. What I was trying to say is that in addition to that it usually makes sense to turn on CIFuzz because the build and runtime environments provided by OSS-Fuzz are different from what fuzz targets normally face locally or on GitHub. For example, CIFuzz caught https://github.com/systemd/systemd/actions/runs/1833518567 today even though the fuzz targets were built and run locally and on GitHub Actions.

@evverx Agreed! Thank you for the great insights 👍.


Release 0.42.0

Release date is tomorrow assuming all the usual "test against" latest work for all the ponylang projects.
There's no reason why it shouldn't but... just in case.
This release is primarily to get the fix for #3779 out.

underway.

done


chore(tests): cleanup integration tests

Refs #2260

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

I am afraid that the test needs some requirements:"
$ git status --ignored
On branch abci-tests
Your branch is up to date with 'origin/abci-tests'.

nothing to commit, working tree clean
$ make test_apps
test/app/test.sh: line 13: cometbft: command not found
make: *** [test_apps] Error 127
$ make test_abci_cli
Example 1: abci-cli kvstore
abci/tests/test_cli/test.sh: line 23: abci-cli: command not found
make: *** [test_abci_cli] Error 127

I think I'd need more context to review this PR...


Doesn't find api's from libraries

My solution has a web project with a single controller, but project references to other projects that also contain controllers. All apis work fine and the swagger definition contains all apis.
Now I'm adding AddApiVersioning and AddVersionedApiExplorer and some other modifications for Swagger and the SwaggerUI only shows the api from the main project. When I inspect the IApiVersionDescriptionProvider, I reports only the version as specified on the main project. Same with IApiDescriptionGroupCollectionProvider, which also only contains info on the api in the main project. However, apis from the references project still work fine.
This solution is over 400 projects. I tried to create a small reproduction, but that one works exactly how it should.
Do you have any hint on where I can look next?

So I was a bit quick to open this issue: turns out that only controllers marked with [ApiController] are considered. So this behaviour is different from the non-versioned explorer.
Thanks anyway for a great library :-)

Your observation is correct; however, I want to clarify that this behavior is controlled by the IApiControllerFilter service. The default implementation is an aggregation over multiple, registered IApiControllerSpecification (via services.TryAddEnumerable). There is a built-in, registered implementation - ApiBehaviorSpecification that matches [ApiController]. Since these libraries are all about versioning APIs, this is a sensible approach to exclude non-API controllers. Some developers mix API and non-API controllers in the same project. The default filter implementation keeps any controller that is satisfied by the specification.  Adding a specification to match controllers from external libraries that may have [ApiController] applied is how you can include them.


[Feature Request]: Add Leetcode Solution for 345 and 345 problems

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Add solutions for the following problems:
[344. Reverse String] (https://leetcode.com/problems/reverse-string)
[345. Reverse Vowels of a String] (https://leetcode.com/problems/reverse-vowels-of-a-string)
Use Case
Add solution in leetcode solution section
Benefits
Provide additional solutions to user
Add ScreenShots
NA
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Hi @Ajay-Dhangar , Can you please assign me this issue

@Ashu0216 Please complete your task otherwise I will close it.

Hi @Ajay-Dhangar , apologies for the delay. Will get the issue completed before Monday

@Ashu0216  assign me this issue i will try to resolve it  today only

@UtkarshBirla28 I have started working on it...will resolve today

@Ashu0216 Okayyyy good good.

@UtkarshBirla28 I have started working on it...will resolve today

Okay complete this very soon

@Ashu0216 Please complete your task otherwise I will close it.

@Ajay-Dhangar Assign it to me i will resolve it ASAP