Mirror global properties in a child libctx

If using a child library context that the global properties from the application library context should be mirrored in the child.

Looking at the CI runs it is interesting how none of the new runchecker builds found anything where the original CI runs fail quite wildly. Nice indication that our original CI runs are well tuned to find issues.

Although this time it is just because all the new runchecker jobs just do not have enable-fips. :grin:

Updated with a fix for "enable-fips" and updating the checksums. Lets see if the CIs are any happier now.

Hmmmm. @t8m, I rebased this PR and removed all updates to the fips checksums to avoid conflicts in the checksums files. I was expecting that I'd get the new label applied to this PR...but it doesn't seem to have been added?

Yep, the dependency does not work properly and the checksums get regenerated. Fix in #15267

Hooray! Works. If you click on details of the job and look at the make diff-fips-checksums step log it shows the affected files nicely.

Rebased again. Labelling is now correct.
Please take a look.

Ping?

Rebased to resolve conflicts with master.
Ping, ping!!

Updated pushed addressing feedback. Please reconfirm

The CI failures might be relevant as I do not see them in other runs

The CI failures might be relevant as I do not see them in other runs

Hmm. When it fails it seems to be in the endecode_test. But I cannot reproduce this locally at all. I suspect it may be an intermittent failure - which is why it seems to be affecting various builds fairly randomly. Not sure how to progress this.

I found a potential issue which explains why a lot of the CI tests failed to complete. Not sure if it explains the crashes or not. Lets see how the CIs do now.

Unfortunately CI is offline now. :disappointed:

No need to reset the timer.

Pushed. Thanks.


Allowing to set the sort order during query with "group by"

If you run a "group by" query with a "series limit" you can specify the "sort by" metric but not the sort order. In the following example you can see that you get the top 5 names. There is currently no way to look at the bottom 5 names. (sort order is hard coded to desc).

This change includes the backend changes to add this functionality. I'm happy to help on the front end as well.

Coverage increased (+0.004%) to 69.121% when pulling baaa4a1e330ec628db05786beea50bc838b4edb9 on tc-dc:fmenges/order_direction into 3dfdde130a88d3a12a6e084adc07d284ed6090e6 on apache:master.

LGTM but please rebase (fixed the build on master)

Coverage increased (+0.004%) to 69.121% when pulling 640c9537c4f8bacc6455c88d9731a341635a190e on tc-dc:fmenges/order_direction into 147c12dddf0da742f1c33c6fee3b2a4b9dbd12c8 on apache:master.

I'm actually working on something related, merged to build around this.

K, sounds good.


client: Invalid error handling

In ObjectPutInit:
https://github.com/nspcc-dev/neofs-sdk-go/blob/4e31b4f2316929aa391fc164d64dfacc7eaa4a92/client/object_put.go#L244-L257
we should check status from metaHeader first because it can contain the access denied error but now it's missed and we get missing ID field in the response.
It seems this affects other client methods too.
Related to #299

Meta header should have been already checked before the result callback. I'll see why it hasn't.


--sign should be on by default when encrypting (and --verify on decrypt)

Signing when encrypting, and verifying when decrypting, seem like pretty natural and logical defaults. The failure modes when you don't do those things can be severe, especially for less-security-aware users. I think many people don't fully get the ramifications of sending encrypted-but-unsigned messages and (worse) those of trusting an encrypted message without checking the signature.
It seems like the client should default to the option that's going to be best for most users and use cases, and that appears to me to be signing and verifying by default.

I agree. The majority of people don't understand repudiation and will probably assume that since they received an encrypted message from Alice (over some insecure channel) that it must actually be from Alice. Signing will do the right thing for most people most of the time.


Fix KeyError: 'topMeta' in L1000CDS2

Datasets with Ensembl and Entrez gene IDs are not recognized by L1000CDS2. Instead of throwing an error, add a message indicating the problem in the final notebook.

46b309c98b69377da7c3ca9e022e257d97d28d83


HidReport() class : self.__raw_report_size set to bad value

HidReport() class initialisation starts with the following :
    def __init__(self, hid_object, report_type, report_id):
        hid_caps = hid_object.hid_caps
        if report_type == HidP_Input:
            self.__raw_report_size = hid_caps.input_report_byte_length
        elif report_type == HidP_Output:
            self.__raw_report_size = hid_caps.output_report_byte_length
        elif report_type == HidP_Feature:
            self.__raw_report_size = hid_caps.feature_report_byte_length
        else:
            raise HIDError("Unsupported report type")

self.__raw_report_size is badly set to one of :

hid_caps.input_report_byte_length
hid_caps.output_report_byte_length
hid_caps.feature_report_byte_length.

These values are the max size of each report type.
For example, if there are 2 Report IN, one of size 4 and one of size 8, all HidReport() of type HidP_Input will have self.__raw_report_size set to 8. This is not correct.

@NicoPy
In your scenario if you have 2 input reports those should be declared in the HID descriptor.
The Windows HID API will pass your descriptor and provide individual details.
This is where there might be a some confusion: This library creates a helper instance of HidReport class for each exposed report in the HID descriptor.
If you support other transactions with an implicit descriptor interface you might need to manage your self the raw data.

I modified HidReport() source code to get access to self.__raw_report_size through a report_size property.
I then display report_size for each report. I get the following :
FEATURE 1 5
FEATURE 2 5
FEATURE 3 5
FEATURE 4 5
FEATURE 5 5
FEATURE 6 5
IN 10 49
IN 11 49
IN 12 49
IN 13 49
IN 14 49
IN 15 49
IN 16 49
IN 17 49
OUT 8 2
OUT 9 2
This is not correct. Each report shall have a different size.
Here, all report sizes are the max of all reports of the same type.
When receiving data in raw report callback, data passed to the callback should be the message content. This is not the case, data passed to the callback is the message content plus some data whose length is variable and make the whole data length equal to what is displayed above for a report type.
Hmmm, this might not be very clear.
For example, report ID 10 is declared to be 10 bytes in length. When a report ID 10 message is received, the callback is called with 49 bytes (10 bytes of the message plus 39 bytes).
This makes the user code harder to debug : message length can't be checked, accessing data outside message content without error...

Check this info: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/hidpi/ns-hidpi-_hidp_caps
It seems that the only way to report different report sizes is to separate each report in a different collection, otherwise Windows might be just giving the maximum size value.

I thought there is a way to know each report size as described in configuration descriptor.
Thanks for your support.


Porting allotaxonometer package to dash review

To read:

[x] Relevant link to integrate d3 and react in dash

Done at needs!

not necessary anymore.


Bump version to 0.10.0

Description of Changes
Bump AssemblyVersion and Version to 0.10.0.
API

[ ] This is an API breaking change to the SDK

If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
Oh boy, I don't know how to index this.
At least wait until https://github.com/clockworklabs/SpacetimeDB/pull/1352 is released.

What's the difference between this and #98?

Closing this as both seem to be made from the same branch.


Local Storage cache is not auto-clearing

Since the demo stores all of the rules into local storage, and doesn't have any mechanize for clearing it, new releases do not add new rules to demo for people who viewed the site earlier. We should somehow clear the local storage after every release.

Curious how this could be achieved. Could we have a unique id number stashed with the localStorage cache that changes/increments with each release that busts the cache if it doesn't match?

Can we use sessionStorage instead or use ESLint version as the namespace key?

ESLint version as a key might be a good idea. That would make things easy, I think. sessionStorage wouldn't help, since the whole idea of the caching will be lost

Yeah, I like that idea too! Might try to take a look at this later tonight

I'm still not entirely clear on how the ESLint version gets updated - is it a manual thing? Or is it pulled in somewhere and updated programmatically?

I'm looking at that for #195. I think you have to run npm run browserify or make browserify or something from the main eslint repo. A bit of magic for sure. I believe there may some sort of automated way the site gets updated. @ilyavolodin will know for sure :)

I hope "turn all rules off" button.
I'm using the demo after I turned all rules off.
I'm afraid that I must do that on every release...

ESLint version gets updated from the main repository by running npm run browserify (or rather by running npm run minor/major/patch which will run npm run gensite which will run browserify task). npm run gensite will automatically update the site, but it will also pull all of the documentation from main repository, so not something you want to do when you just want to update demo page.


Login failed or closed

Does someone else getting "login call failed with error: Login failed or closed" on login?
I've tried iOS SDK 3.13.1 as you mentioned you tested that, tried the last one 1.16.1. And all time getting this message after login. I have tried login with various permissions such as "basic_info" and "public_profile" on init, even with this changes https://github.com/ccsoft/cordova-facebook/issues/18#issuecomment-48935202 but without success :(
Any ideas what could be wrong?

I had similar problems, in my case the solution was to make sure of following things:

correct configuration in the app .plist (I was using a different bundle id for a test version of the app and this should be configured accordingly, I had to create a test version of the app on facebook where I configured the appropriate bundle id).
if you have a test version of the fb app it should be either publicly available or it should have some test users configured through the ROLES tab of the app.
for further insights refer to this StackOverflow question: http://stackoverflow.com/questions/23509386/facebook-sdk-on-ios-app-session-fixing/28673422#28673422

Note to future searchers, I got "login call failed with error: Login failed or closed" because the appdelegate.m code (as shown in README) got wiped out during a build.


Fix and refactor health.getDrives()

Before it wasn't working correctly on Linux with locales other than
those that result in df outputting the column names in English.
Refs: https://github.com/metarhia/impress/issues/993

Landed in 47ba39c


IconMenu never shows up

I don't manage to make IconMenu works well. The menu never shows up, even with the code from the docs:
		    	<IconMenu iconButtonElement={
		    	  <IconButton><FontIcon className="material-icons">more_vert</FontIcon></IconButton>
		    	}>
		    	  <MenuItem primaryText="Refresh" />
		    	  <MenuItem primaryText="Help" />
		    	  <MenuItem primaryText="Sign out" />
		    	</IconMenu>

Is this a common problem or just a bad use ?

Feel dumb, the react-tap-event-plugin was not properly included in my project.
See: http://material-ui.com/#/get-started/installation

@the-cormoran no worries :+1: glad you got it working!


Traceback error when trying to use pywal

I don't know whether this is a pywal issue or a python configuration issue, but I get the following error when I'm trying to run wal on my desktop box. (Arch)
[ ~ ] 36 >> wal -f "./Downloads/trillectro-aaron-campbell-2560×1080.jpg" -n
[I] theme: Set theme to trillectro-aaron-campbell-2560×1080.jpg.
Traceback (most recent call last):
  File "/home/xyverz/.local/bin/wal", line 11, in <module>
    load_entry_point('pywal==3.3.0', 'console_scripts', 'wal')()
  File "/home/xyverz/.local/lib/python3.7/site-packages/pywal/__main__.py", line 208, in main
    parse_args(parser)
  File "/home/xyverz/.local/lib/python3.7/site-packages/pywal/__main__.py", line 167, in parse_args
    colors_plain = theme.file(args.theme, args.l)
  File "/home/xyverz/.local/lib/python3.7/site-packages/pywal/theme.py", line 119, in file
    return parse(theme_file)
  File "/home/xyverz/.local/lib/python3.7/site-packages/pywal/theme.py", line 69, in parse
    data = util.read_file_json(theme_file)
  File "/home/xyverz/.local/lib/python3.7/site-packages/pywal/util.py", line 70, in read_file_json
    return json.load(json_file)
  File "/usr/lib/python3.7/json/__init__.py", line 293, in load
    return loads(fp.read(),
  File "/usr/lib/python3.7/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte

I'm not having this issue on my laptop (also Arch), and I've tried both the python-pywal package from the repos, and a manual install (after installing python-pip) after cloning the git repo. I have a feeling this has more to do with my python install or configuration, but I have no idea where to start looking.

 I should have used -i instead of -f. Closing this issue.

I am also getting this same error when I try to run ‘set theme dark —img path/to/img’. Can you provide some more detailed about your solution?


Miscellaneous README changes

Add syntax highlighting to Swift code blocks.
Update version number in example Podfile to 0.10.
Fix minor typos and formatting issues.

Thanks for this!

No worries!


[Bug]: Unable to add a task in the default TO DO Template - errors with permission denied

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I add a TO DO template, and try to ADD TASK from the home page, it fails with an error createTask failed to execute. Logs give an error to the effect:
Your query failed to execute:
ERROR: permission denied for sequence todo_task_id_seq
[SQLSTATE: 42501]

Steps To Reproduce
https://jam.dev/c/4eb93adf-d963-4b3e-ac7b-ee0dbcbaf91b
Public Sample App
No response
Environment
Production
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
Cloud

Issue has been resolved. Issue was from permissions with Postgres auto id sequence. The addTask function has bee implemented to use locally generated ID.


Sending messages with GraphQL mutations

I think it's failing as code generated file types has been added to .git ignore and is no longer generated.
Can this be fixed by adding
yarn codegen

to CircleCI or
codegen: gql-gen

to package.json

I think this can this be fixed by adding

This is exactly it. The client app now has one additional step before you can build it. You need to run the codegen. This needs to be added to the CircleCI config.
@milenazuccarelli can you add that? In the CircleCI config there is a build_client step that probably runs a couple of commands. Could you please add another command to run yarn codegen right before yarn build?

I think this can this be fixed by adding

This is exactly it. The client app now has one additional step before you can build it. You need to run the codegen. This needs to be added to the CircleCI config.
@milenazuccarelli can you add that? In the CircleCI config there is a build_client step that probably runs a couple of commands. Could you please add another command to run yarn codegen right before yarn build?

Thanks, guys! Will do that asap

Great work @milenazuccarelli especially with figuring out the various issues causing the build to break.


CEO-433 Finish updating the Geo-Dash Help page.

Purpose
Finishes updating the Geo-Dash Help page with the language from the help manual.
Related Issues
Closes CEO-433
Submission Checklist

[x] Included Jira issue in the PR title (e.g. CEO-### <title>)
[x] Code passes linter rules (npm run eslint/clj-kondo --lint src)

Screenshots
There are too many changes to list here. Check out the Geo-Dash help page and read through each section to see all of the changes.

src/js/geoDashHelp.js
58, this additional text needs to be in the lang file so it can be traslated
106, Come up with display text that is not the long URL.


Try pytest-nunit with azure pipelines

Try an alpha version with nunit XML
Cc @zooba

do you have the PR hooks setup? am not seeing a build being kicked off?

Apparently it's not hooked up...

There we go @tonybaloney - I had to check the "allow build from forks" option.

Freaked out because I saw I'd been ignoring a pull request on this repo, and then saw it was just this one 😆
I'm assuming it's out of date now, so going to close it so I can achieve PR Inbox Zero and not stress myself next time!


Works perfect in IE, but fails in Chrome? and database fails fullstop

Works perfect in IE, but fails in Chrome?
Any ideas as to why this might be?
Second, when trying to load Todos list, it pumps out this error on the screen.
{"Message":"An error has occurred.","ExceptionMessage":"An exception occurred while initializing the database. See the InnerException for details.","ExceptionType":"System.Data.DataException","StackTrace":" at System.Data.Entity.Internal.InternalContext.PerformInitializationAction(Action action)\r\n at System.Data.Entity.Internal.InternalContext.PerformDatabaseInitialization()\r\n at System.Data.Entity.Internal.LazyInternalContext.b__4(InternalContext c)\r\n at System.Data.Entity.Internal.RetryAction1.PerformAction(TInput input)\r\n at System.Data.Entity.Internal.LazyInternalContext.InitializeDatabaseAction(Action1 action)\r\n at System.Data.Entity.Internal.LazyInternalContext.InitializeDatabase()\r\n at System.Data.Entity.Internal.InternalContext.Initialize()\r\n at System.Data.Entity.Internal.InternalContext.GetEntitySetAndBaseTypeForType(Type entityType)\r\n at System.Data.Entity.Internal.Linq.InternalSet1.Initialize()\r\n at System.Data.Entity.Internal.Linq.InternalSet1.get_InternalContext()\r\n at System.Data.Entity.Infrastructure.DbQuery1.System.Linq.IQueryable.get_Provider()\r\n at System.Linq.Queryable.Where[TSource](IQueryable1 source, Expression1 predicate)\r\n at TodoSPA.Controllers.TodoListController.Get() in c:\\temp\\ADAL.js\\SinglePageApp-AngularJS-DotNet-master\\TodoSPA\\Controllers\\TodoListController.cs:line 23\r\n at lambda_method(Closure , Object , Object[] )\r\n at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass10.<GetExecutor>b__9(Object instance, Object[] methodParameters)\r\n at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.Execute(Object instance, Object[] arguments)\r\n at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ExecuteAsync(HttpControllerContext controllerContext, IDictionary2 arguments, CancellationToken cancellationToken)\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()\r\n at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()\r\n at System.Web.Http.Controllers.ActionFilterResult.d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()\r\n at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()\r\n at System.Web.Http.Dispatcher.HttpControllerDispatcher.d__1.MoveNext()","InnerException":{"Message":"An error has occurred.","ExceptionMessage":"The underlying provider failed on Open.","ExceptionType":"System.Data.Entity.Core.EntityException","StackTrace":" at System.Data.Entity.Core.EntityClient.EntityConnection.Open()\r\n at System.Data.Entity.Core.Objects.ObjectContext.EnsureConnection(Boolean shouldMonitorTransactions)\r\n at System.Data.Entity.Core.Objects.ObjectContext.ExecuteInTransaction[T](Func1 func, IDbExecutionStrategy executionStrategy, Boolean startLocalTransaction, Boolean releaseConnectionOnSuccess)\r\n at System.Data.Entity.Core.Objects.ObjectQuery1.<>c__DisplayClass7.b__5()\r\n at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute[TResult](Func1 operation)\r\n at System.Data.Entity.Core.Objects.ObjectQuery1.GetResults(Nullable1 forMergeOption)\r\n at System.Data.Entity.Core.Objects.ObjectQuery1.<System.Collections.Generic.IEnumerable.GetEnumerator>b__0()\r\n at System.Data.Entity.Internal.LazyEnumerator1.MoveNext()\r\n at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable1 source)\r\n at System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.b__1[TResult](IEnumerable1 sequence)\r\n at System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.ExecuteSingle[TResult](IEnumerable1 query, Expression queryRoot)\r\n at System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.System.Linq.IQueryProvider.Execute[TResult](Expression expression)\r\n at System.Data.Entity.Internal.Linq.DbQueryProvider.Execute[TResult](Expression expression)\r\n at System.Linq.Queryable.FirstOrDefault[TSource](IQueryable1 source)\r\n at System.Data.Entity.Internal.EdmMetadataRepository.QueryForModelHash(Func2 createContext)\r\n at System.Data.Entity.Internal.InternalContext.QueryForModelHash()\r\n at System.Data.Entity.Internal.ModelCompatibilityChecker.CompatibleWithModel(InternalContext internalContext, ModelHashCalculator modelHashCalculator, Boolean throwIfNoMetadata, DatabaseExistenceState existenceState)\r\n at System.Data.Entity.Internal.InternalContext.CompatibleWithModel(Boolean throwIfNoMetadata, DatabaseExistenceState existenceState)\r\n at System.Data.Entity.Database.CompatibleWithModel(Boolean throwIfNoMetadata, DatabaseExistenceState existenceState)\r\n at System.Data.Entity.Database.CompatibleWithModel(Boolean throwIfNoMetadata)\r\n at System.Data.Entity.DropCreateDatabaseIfModelChanges1.InitializeDatabase(TContext context)\r\n at System.Data.Entity.Internal.InternalContext.<>c__DisplayClassf1.b__e()\r\n at System.Data.Entity.Internal.InternalContext.PerformInitializationAction(Action action)","InnerException":{"Message":"An error has occurred.","ExceptionMessage":"Cannot attach the file 'C:\temp\ADAL.js\SinglePageApp-AngularJS-DotNet-master\TodoSPA\App_Data\TodoListServiceContext.mdf' as database 'TodoListServiceContext'.","ExceptionType":"System.Data.SqlClient.SqlException","StackTrace":" at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)\r\n at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)\r\n at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)\r\n at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)\r\n at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)\r\n at System.Data.SqlClient.SqlConnection.TryOpenInner(TaskCompletionSource1 retry)\r\n at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource1 retry)\r\n at System.Data.SqlClient.SqlConnection.Open()\r\n at System.Data.Entity.Infrastructure.Interception.DbConnectionDispatcher.b__36(DbConnection t, DbConnectionInterceptionContext c)\r\n at System.Data.Entity.Infrastructure.Interception.InternalDispatcher1.Dispatch[TTarget,TInterceptionContext](TTarget target, Action2 operation, TInterceptionContext interceptionContext, Action3 executing, Action3 executed)\r\n at System.Data.Entity.Infrastructure.Interception.DbConnectionDispatcher.Open(DbConnection connection, DbInterceptionContext interceptionContext)\r\n at System.Data.Entity.Core.EntityClient.EntityConnection.b__2()\r\n at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.<>c__DisplayClass1.b__0()\r\n at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute[TResult](Func`1 operation)\r\n at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute(Action operation)\r\n at System.Data.Entity.Core.EntityClient.EntityConnection.Open()"}}}

Managed to get Chrome working. Had to clear out cache.
But the error with the database initialization is still present. I noticed there is nothing in Web config for database config. How is this web api supposed to create it (the database) then?

Lastly, this is more of a complaint in general. Im new to programming so dont have the ability yet to point out if others work is half ass-ed or not. But my experience over the last six months is all the work I have done with Node and the open source community and projects out there is that it has been such a breeze and a pleasure to learn.
Microsoft stuff is not like that. It is painful, frustrating, and difficult. I used firebase to knock out a beautiful app the other day and it was sooo easy!.  Looking forward to the day it gets it act together.

Thanks for the feedback and I'm sorry you had such a rough time. We are
always trying to improve our documentation. Feel free to email me at
<EMAIL_ADDRESS>with any feedback you have about what you
encountered.
On Fri, Apr 3, 2015 at 12:21 AM, nigel-dewar<EMAIL_ADDRESS>wrote:

Lastly, this is more of a complaint in general. Im new to programming so
dont have the ability yet to point out if others work is half ass-ed or
not. But my experience over the last six months is all the work I have done
with Node and the open source community and projects out there is that it
has been such a breeze and a pleasure to learn.
Microsoft stuff is not like that. It is painful, frustrating, and
difficult. I used firebase to knock out a beautiful app the other day and
it was sooo easy!.  Looking forward to the day it gets it act together.
—
Reply to this email directly or view it on GitHub
https://github.com/AzureADSamples/SinglePageApp-AngularJS-DotNet/issues/16#issuecomment-89200795
.

Hi Brandon,
Im not sure if anything I say can be of any use to you guys there, because I am looking at this from a totally different perspective you guys there at ms.
And besides that because I am pissed off , it will likely be more of a rant anyway, but here is my feedback none the less.
Quite a few of the examples I have trialled have failed on me in one way or another. For instance with the expense manager app, written by Dan Wahlin, was good and all, and demonstrated the use of the ADAL.NET library to hook into ad, get a token for use with O365 (SP Online). This worked great in Dev on my local machine, but then I tried to load it up on azure, and it failed. The error passed back, I searched and searched, I knew it was an Azure AD error, but could not find how to resolve it. I double checked that I did everything correct, loaded up some different azure projects (with Databases),  loaded them on Azure and all good. So I had the deployment steps correct, but I could not get this thing loaded up for the life of me.
I logged an issue against this project on GitHub ad Dan responded back letting know that it was just a sample and that he had not tried to load it on azure. If I ever got it working, then please let him know what was wrong. I’m like ‘WTF!’. Thanks for your help. Useless sample that turned out to be if I can’t even be put in production!
Then Andrew Connell comes along, and redevelops the same app but using ADAL.JS, which is nice, except its written in typescript. I don’t know TS, and from my experience in the node world, not many people are using it. That is fine, I can see that TS gets translated into normal JS. Andrew Connells version of this sample loads up nice on azure which is a Win!  But the way he has written the app is OVERLY complicated. I spent most of a day trying to understand his way of writing angular. I tried to write some angular controllers to add onto his sample (to do my own thing) but got weird errors. I could not understand why as I have been writing quite a bit of angular and have created some working successful apps, so I kind (just kinda) know what I am doing, but I could not work with his stuff. In the end I gave up!
 Its funny because often when I do work away at something and end up understanding it, it makes my realize that a lot of these big shots are completely useless teachers regardless of their rep. I KNOW when I get to the stage when I start teaching people this tech, I will be able to explain it much better, and provide working (tested) examples that demonstrate end to end the technologies in play.
So I get this sample attempting to understand ADAL.JS, and it works partially, but not in Chrome. Now I realize stuff does not always work for many reasons, so I figured there must be something wrong with my chrome, which I managed to fix by clearing the cache. But then the web api database (TODO’s) wont load. Its just a friggen joke!
As I stated, I started getting serious about programming about 6 months ago. I love node and the open source stuff, and especially firebase. Granted, not everything works, but the reliability, ease of use, ease of learning, ease of getting help pisses all over ms and azure stuff!  I started learning .net, MVC, web api because these are the most commonly known technologies and you assume (wrongly) that because its ms stuff, it would be the best or at least pretty dam near the top. By chance I started playing around with some node stuff, and then a few other things here and there, and started to find, hang on a sec, why is this so much easier to understand. Why is it much simpler to design an api in node than web api? Why is it so much faster?  Then I found firebase, and I think I found the answer.
   If Microsoft wants to get its act together it needs to look at tools like firebase and parse. But especially firebase coz they got it going on! Simple! Simple! Simple!, Easy to Use! Easy to Use! Easy to Use! Fast!, Fast!, Fast! Good doco, and it works!
take Azure, with all its marketing money spent on hyping it up! I friggen hate it. Its painful to use. Lets get real for a tick. I want to develop an api right, to be used for both desktop browser and mobile devices, do I use a standard web app in azure, or do I use a azure mobile services application?  I saw MS released the new app services thing the other day. I spent an hour looking at it all and I was still thinking, so what?  Seems nothing has really improved here.
What you need is “1” api backend, 1!!! Singular. Not 2 (1). It should have a slick user interface, it should not be backed by SQL DB, it should be backed by Document DB, or some other noSQL db, but seriously, no SQL, its 2015 for crying out load.
You should not struggle to configure Authentication. It should be very simple.  You should not have to go download a manifest file, adjust the oauth implicent flow to ‘true’ and re-upload.
I mean seriously!!! Facebook had all this app module and authentification stuff sorted years ago. Why is ms so far behind. I think ms only started supported JWT recently was that not the case?
This service MBAAC should be able to be used for ANY app. Desktop, browser, and mobile. The ability to alter the data in the DB should be really simple. The logic behind configuring authz, authn should be easy to understand (visualize) and make sense of. The security rules should be easy and straight forward to configure (firebase).
In fact, if ms takes a good look at firebase, which google now bought, you would see how a back end service ought to look at. Ms should have bought these guys ought. But it seems ms is not very good at identifying talent. No offence to you mate, but it seems they can identify the right tech to spend billions on. Now Google is going to turn this service into something that pisses all over anything azure has to offer. Take a look at their service man! It can really be that hard for ms to develop something life that. Missing out on Angular was another dum move.
I think you guys have too many old dogs there, living in the old world. No idea about how modern apps ( and the hosting of them ) needs to look like.
  But I tell you what, any chance I get to not use MS, I take it, because its just such a nightmare.
You know I found an example of an angular app that worked properly with .net web api using identity. It took me a friggen week to find it. The guy had built an end to end example of using a separated angular front end, that hooked into the web api backend, performed authN, and had some authZ rules so that it provided a full end to end RBAC example. IT working perfectly. I thanks the creator and said I had a nightmare trying to learn or find this info from MS. His response was he felt that same way, hence his blogs slogan was , programming for the real world’  http://oscarmeszar.com/angularjs-webapi-owin-authorizationauthentication-role-based/
This is the quality of work, and documentation MS needs to get to.  Hire some decent friggen people that develop apps ‘for the real world’ and get some end to end examples set up, that are tested ( on Azure ) and provide detailed tutorials.
I am working to understand ADAL.js so that I can start to use Azure for only 1 thing, and 1 thing only, to authenticate my apps with my corporate clients, who still use ms products. Otherwise I will be using ANY other technology to develop and host my apps rather than azure. When I run into folk getting into app design these days, they ask me, what to use, I say ‘anything but MS mate, trust me its not worth the pain!’
I will figure out this ADAL.js thing, thank you for creating it. Because now I will be able to build my apps, host them on firebase with the backend, authenticate to azure ad, which allows me to do what I need to do. Im able to smooth my customers fears when I say the data is not hosted on azure because I tell them that its hosted on something better, Google servers. And a CDN at that which likely explains why its so ridiculously fast. Once I have perfected using Azure AD, with firebase, I will begin to publish articles far and wide about how to do it, and why one would do it, so as to free app developers from the pain of hosting on azure, and developing apps using web api and other .net crap which is just so ridiculously hard to use and learn for that matter. All is not lost though, O365 is pretty cool, and I will use this for a data source for a lot of corporate clients, but trust me man, anything else, no way.
Anyway enough MS bashing. All frustration and anger aside. I believe ms is going in the right direction (finally) but it seriously needs to jack up its ideas about how it provides samples, and make sure its tested ( and runs on Azure )!
 Back it with noSQL by default. Massively simplify the authN, authZ functions. And generally stop sucking.
This turned out to be a harsh rant. I imagine it will be filed under ‘R’
But these are my thoughts. I’ve talked to a few other devs who are quite experienced, and they feel the same way.  But I have been asked to look into adal.js because it interests them greatly, the opportunity to deal with all the brain washed muppets who are still using ms tech ( most businesses unfortunately ), but be able to provide sweet, fast, apps that work great, and great to develop.
I wasn’t always like this. I was a real firm MS believer. I spend heaps of money and time learning sharepoint. But these days mate, I realized the little guys have left the new IBM behind and the new IBM is desperately struggling to catch up.
If ms took a group of guys and girls out of school. Not with a computer science degree. ( definitely not with a degree ) and gave them six months to learn to program using any tools and services they wished to use. Ms would end up with the answers as to how they need to structure azure and how its development tools ought to work.
Cheers Brandon,
Nigel D.
From: Brandon Werner<EMAIL_ADDRESS>Sent: Friday, 3 April 2015 4:07 PM
To: AzureADSamples/SinglePageApp-AngularJS-DotNet
Cc: nigel-dewar
Subject: Re: [SinglePageApp-AngularJS-DotNet] Works perfect in IE, but fails in Chrome? and database fails fullstop (#16)
Thanks for the feedback and I'm sorry you had such a rough time. We are
always trying to improve our documentation. Feel free to email me at
<EMAIL_ADDRESS><EMAIL_ADDRESS>with any feedback you have about what you
encountered.
On Fri, Apr 3, 2015 at 12:21 AM, nigel-dewar<EMAIL_ADDRESS><EMAIL_ADDRESS>>
wrote:

Lastly, this is more of a complaint in general. Im new to programming so
dont have the ability yet to point out if others work is half ass-ed or
not. But my experience over the last six months is all the work I have done
with Node and the open source community and projects out there is that it
has been such a breeze and a pleasure to learn.
Microsoft stuff is not like that. It is painful, frustrating, and
difficult. I used firebase to knock out a beautiful app the other day and
it was sooo easy!.  Looking forward to the day it gets it act together.
—
Reply to this email directly or view it on GitHub
https://github.com/AzureADSamples/SinglePageApp-AngularJS-DotNet/issues/16#issuecomment-89200795
.

—
Reply to this email directly or view it on GitHub https://github.com/AzureADSamples/SinglePageApp-AngularJS-DotNet/issues/16#issuecomment-89211789 .  https://github.com/notifications/beacon/AI94WO_Rohor1wOmOLrW2_bxlofuszhoks5n7kGrgaJpZM4D5p0l.gif

Nigel, thank you for the feedback.  Can we contact you later, to review some of our go forward ideas?

Hi Stuart,
Look I appreciate you guys being so awfully nice about it, considering my harsh feedback. But it is pointless pandering to my ego because I have none.
 I am just a beginner in development hence my onions will be very one sided as they lack insight. If you wish to delete my post then feel free too. You have my feedback.
From: Stuart Kwan<EMAIL_ADDRESS>Sent: Saturday, 4 April 2015 12:48 PM
To: AzureADSamples/SinglePageApp-AngularJS-DotNet
Cc: nigel-dewar
Subject: Re: [SinglePageApp-AngularJS-DotNet] Works perfect in IE, but fails in Chrome? and database fails fullstop (#16)
Nigel, thank you for the feedback. Can we contact you later, to review some of our go forward ideas?
—
Reply to this email directly or view it on GitHub https://github.com/AzureADSamples/SinglePageApp-AngularJS-DotNet/issues/16#issuecomment-89503641 .  https://github.com/notifications/beacon/AI94WNi5KUxZQ6DXjhZebv_ostELyNvmks5n72SbgaJpZM4D5p0l.gif

Actually, we just wanted to review some of our ideas with you so we could get a beginner's perspective on them.  But thanks again for the feedback.  Our goal is to advance the state of the art for identity management as a service, and every point of view counts.


Fix font "flashing" on page load

This has been fixed in an upcoming release. I've done a lot of work inside a production site migration that needs to be pulled back into this starter.


IOU - Deleted money request is shown when returning online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to http://staging.new.expensify.com/
Log in
Disable internet connection on the device
Open a chat and create a money request
Delete the money request
Enable internet connection on the device

Expected Result:
The IOU is still deleted and is not displayed
Actual Result:
The IOU is shown as active.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/3e3d53d9-efb9-4636-9540-9ae64560730c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is known and was addressed here in the API layer, so not an App blocker. Also the attached video doesn't match the issue description.


Minor - accounting for codegangsta/cli migration to urfave/cli

Very minor change - using this as a learning opportunity.
codegangsta/cli appears to have migrated over to urfave/cli as their new package instead, I have made that change across the board and as part of this change also fixed up some linting errors that I saw.
Please review

:+1: I didn't realize the lib had moved. I kind of liked the name codegangsta.

@sneal, we should petition them to get the original package name back :-)


If we've succesfully initialized the local data directory, record a flag

Set the 'has_data' flag on the node. This can be used from calling recipes to
find an appropriate node to promote to master after loss of the
previous master.
@philpennock

LGTM.  (Would still be happier if we had a way to detect "up-to-date")

Replication monitoring (ticket #SRE-362) is the answer there to ensure our replicas are up to date.
From the Chef perspective we would have to do something like interactively query all replicas to determine which one is most up to date.  We can consider that separately, but right now the immediate protection against shooting ourselves in the foot is more critical.


feat: keepTextConfig

This will enable user to always generate text node with __text.

Thanks for your contribution !
I will deploy it soon in a new version ;)

Thanks. It will be great if you can release a new version soon.

@Maxouhell Hey Maxime, is that possible for you to do a release sooner? We need to use this feature.

Oh sorry, I'll do this right now.


Separating all the environment logic as a lib

This PR has a basic smoke suite with tests that work on v0.10.14 with environment separated as a lib:

CronJob
Runlog
Keeper
Flux (not working on 1.0.0)
VRF

Need some help with OCR logic that is coupled heavily with otpe deployments I don't port atm
To debug the tests it's easier to setup required envs once:
Set vars in each preset:
persistent: true
persistent_connection: true

Then spin up the envs:
envcli -p preset/chainlink-cluster-3 n
envcli -p preset/chainlink-cluster-3 c
envcli -p preset/chainlink-cluster-6 n
envcli -p preset/chainlink-cluster-6 c

And run particular test:
PRESET_VALUES_CHAINLINK_CHAINLINK_IMAGE_VERSION="1.0.0" ginkgo -r --focus @flux

A lot of our stuff was removed and will be gradually added.
Also, eth_refill test is removed.
TODO:

[ ] Secrets managing
[x] Forbid CLI usage when persistent is false
[x] Proper log dirs naming for ginkgoV2
[x] Env teardown for local usage and KeepEnvironment vars
[x] ginkgo V2 CLI

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@48e1eac). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage        ?   11.57%
=======================================
  Files           ?       11
  Lines           ?     1374
  Branches        ?        0
=======================================
  Hits            ?      159
  Misses          ?     1199
  Partials        ?       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e1eac...bbbd73f. Read the comment docs.


HDFS-16235. Fix Deadlock in LeaseRenewer for static remove method

Description of PR
Have Deadlock when backend LeaseRenewer thread call LeaseRenewer.Factory.remove and  task thread call LeaseRenewer.remove

How was this patch tested?
For code changes:

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 16s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 52s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 52s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 29s

the patch passed

+1 :green_heart:
shadedclient
20m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 19s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

89m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3472/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3472

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8184f94ed362 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6a84170b26c27e2056a0c19bc2e2cd726814fd92

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3472/1/testReport/

Max. process+thread count
547 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3472/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1 (non-binding), thanks @AngersZhuuuu

Since HDFS-14575 is checked-into only trunk, we don't need to backport this fix to release branches I guess.

Since HDFS-14575 is checked-into only trunk, we don't need to backport this fix to release branches I guess.

yea

@AngersZhuuuu Thanks for contribution. @virajjasani @prasad-acit Thanks for review! Merged to trunk.


ReadAsync/WriteAsync don't appear in ISerialPortStream (but they are in SerialPortStream)

For some reason I'm not seeing ReadAsync/WriteAsync anymore in the ISerialPortStream interface when using v2.3.1. Was this an accidental change or intentional?

Does this commit fix your problem?
https://github.com/jcurl/SerialPortStream/commit/1d417a4c532420dc2622f2a523d18b6f6762ee83

Assuming resolved, closing.


[SUPPORT] HoodieSnapshotExporter is broken with PR HUDI-712

Describe the problem you faced
In HUDI-712, the "overwrite=false" was added.
When spark executors were terminated somehow, there are chances that the target path was created and already existed.
In this case, if the failed Spark "Task" is retried by other executors, it would fail since the target path already existed.
Expected behavior
The HoodieSnapshotExporter completes even when the failed "Tasks" are retried.

@Gatsby-Lee PR comment shows this was added to keep in find that user accidentally don't overwrite the data. Failed tasks retry should not fail this, but Job retry should fail which should be the expected behaviour.

@ad1happy2go I noticed that the Task level retry failed as well. ( not Job level )

@ad1happy2go I tested with the on-demand instance in EMR on EKS. In my case, if Tasks are not retried due to the terminated k8e Pods ( in spot instance ), then there is no issue.
So, I can say that the overwrite=false brought in the behavior changes.

@Gatsby-Lee Can you see two job attempts in your application?

@Gatsby-Lee Can you see two job attempts in your application?

sorry. I don't get you.
do you mean if two different jobs ran simultaneously? NO
At any given time, there is only one Spark Job. ( one application )

@Gatsby-Lee I see from the stack trace that with a particular file only , it is kind of failing complaining file not exists. So it could have come from task failure only.
Dont think "HUDI-712, the "overwrite=false" is impacting this though.

@Gatsby-Lee I see from the stack trace that with a particular file only , it is kind of failing complaining file not exists. So it could have come from task failure only. Dont think "HUDI-712, the "overwrite=false" is impacting this though.

so, the Job failed because the particular file ( or any file ) already existed when the Task was retried.
Isn't it?

As per my understanding,  that flag "overwrite=false" checks the base path when the job starts.
Let me tag @xushiyan author of the PR if he can ensure that.

@Gatsby-Lee good catch. it's actually not desirable to use overwrite=false here as it's applied to individual task. We should change it to allow overwrite, and add a check on the whole directory to ensure it's empty before the spark job start the parallel copying.

@xushiyan Actually, the logic checking the target path already exists.
This logic has helped prevent overwriting the existing target path.
So, I think updating the logic to the "overwrite=true" might be enough change.
What do you think?
  public void export(JavaSparkContext jsc, Config cfg) throws IOException {
    FileSystem outputFs = HadoopFSUtils.getFs(cfg.targetOutputPath, jsc.hadoopConfiguration());
    if (outputFs.exists(new Path(cfg.targetOutputPath))) {
      throw new HoodieSnapshotExporterException("The target output path already exists.");
    }

@Gatsby-Lee yup sg

@xushiyan @ad1happy2go
Thank you. I made a PR. ( https://github.com/apache/hudi/pull/11668/files )
It would be great if this PR can be applied to 0.15.1


Refactor Airlock Modules

Preliminary to #2829
What is being addressed

Moved the logic of create_review_user_resource from the airlock route to the airlock service, and broke it into multiple shorter methods
Removed the airlock_resource_helpers module, moved its methods to the airlock service.
Aligned tests with the changes - no changes were made to the logic of the tests

/test-airlock

/test-extended

/test-force-approve

tested at:
https://github.com/microsoft/AzureTRE/actions/runs/4013913729/jobs/6896913729
test_airlock_review_vm_flow passed
test_airlock_flow is not related and failed in teardown on a known issue


Confirmations not sending email

I have ':confirmations' module enabled in User model and all the necessary column migration done. When I register new user from registration new page, confirmation email is not sent but when I do "didn't receive confirmation instructions" and request confirmation link from confirmation new page, I get confirmation link email. I'm using "postmark-rails gem" for mail service in my app. and devise version is 4.3.0. I tried switching and trying in all environments but no receiving confirmation link in new user create/registration but get link in confirmations/create.

@coderubyonrails Can you share your User model, development.rb devise.rb & devise migration for the same?

You need to give us more information on how to reproduce this issue, otherwise there is nothing we can do. Please read CONTRIBUTING.md file for more information about creating bug reports. Thanks!


questions

hi, thanks so much for doing this, i have wanted a roku frontend for a long time.  i have a question about maestro...does maestro convert all recordings "just in case" or does it convert the recordings "on demand"?  is there any issue with running maestro on the myth backend?
thanks again

"On the fly" encoding is now available.
Please see:
https://github.com/evuraan/MythicalMythTV/tree/main/maestro#on-the-fly-encoding


C-g to stop search leaves overlays behind

I noticed that when I am in a CTRLF session if I navigate away from the mini buffer to select another window then press C-g to cancel the search the CTRLF overlays stay behind.
Is this a known bug?

Heh, this actually turns out to be a Radian bug, due to this code!
https://github.com/raxod502/radian/blob/c508178ae1d8483985bf9446074d64fcbc0e3f4e/emacs/radian.el#L959-L969
Lemme fix it real quick---I'd never actually tracked down the exact conditions to reproduce before, so thanks for that :)


Add RepositoryCommit and RepositoryBranch for pack

Document commit and branch nuspec additions.
Related: https://github.com/NuGet/Home/issues/6547
Related: https://github.com/NuGet/NuGet.Client/commit/0e4d1b598f350b3dc675018d539114d1328189ef
//cc @rohit21agrawal

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Unexpected response on aliyun cloud provider metadata makes agent crash

Rancher versions:
rancher/server: v1.6.12
rancher/agent: v1.2.7
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher, internal db
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

Launch agent in an environment with transparent anti malware/virus device intercepting requests to "rogue" IP ranges

For example, curl -v http://<IP_ADDRESS> will respond with an HTML page saying it's blocked.
Results:
{"log":"time=\"2017-12-05T14:24:18Z\" level=info msg=\"Launching agent\" \n","stream":"stdout","time":"2017-12-05T14:24:18.036383805Z"}
{"log":"time=\"2017-12-05T14:24:18Z\" level=info msg=\"Detecting cloud provider\" \n","stream":"stdout","time":"2017-12-05T14:24:18.03642389Z"}
{"log":"time=\"2017-12-05T14:24:18Z\" level=info msg=\"Listening for events on http://luka:8080/v1\" \n","stream":"stdout","time":"2017-12-05T14:24:18.036567104Z"}
{"log":"time=\"2017-12-05T14:24:18Z\" level=info msg=\"launching hostapi\" \n","stream":"stdout","time":"2017-12-05T14:24:18.036679752Z"}
{"log":"time=\"2017-12-05T14:24:18Z\" level=warning msg=\"stat /var/lib/rancher/state/info.json: no such file or directory\" \n","stream":"stdout","time":"2017-12-05T14:24:18.036787447Z"}
{"log":"time=\"2017-12-05T14:24:18Z\" level=warning msg=\"stat /var/lib/rancher/state/info.json: no such file or directory\" \n","stream":"stdout","time":"2017-12-05T14:24:18.037365448Z"}
{"log":"panic: runtime error: index out of range\n","stream":"stderr","time":"2017-12-05T14:24:18.060848165Z"}
{"log":"\n","stream":"stderr","time":"2017-12-05T14:24:18.060883442Z"}
{"log":"goroutine 11 [running]:\n","stream":"stderr","time":"2017-12-05T14:24:18.060888529Z"}
{"log":"github.com/rancher/agent/vendor/github.com/denverdino/aliyungo/metadata.(*MetaData).Zone(0xc4202917e0, 0xc4200161c0, 0xc4200ae480, 0x0, 0x0)\n","stream":"stderr","time":"2017-12-05T14:24:18.060892832Z"}
{"log":"\u0009/go/src/github.com/rancher/agent/vendor/github.com/denverdino/aliyungo/metadata/client.go:229 +0xb0\n","stream":"stderr","time":"2017-12-05T14:24:18.060897477Z"}
{"log":"github.com/rancher/agent/cloudprovider/aliyun.metadataClientImpl.Zone(0xc4202917e0, 0x0, 0xc420033e60, 0x4ecbbb, 0xc4200161c0)\n","stream":"stderr","time":"2017-12-05T14:24:18.060902209Z"}
{"log":"\u0009/go/src/github.com/rancher/agent/cloudprovider/aliyun/aliyun_provider.go:43 +0x2b\n","stream":"stderr","time":"2017-12-05T14:24:18.060906763Z"}
{"log":"github.com/rancher/agent/cloudprovider/aliyun.(*Provider).GetHostInfo(0xc42024bb40, 0x0, 0x0, 0x0)\n","stream":"stderr","time":"2017-12-05T14:24:18.060911236Z"}
{"log":"\u0009/go/src/github.com/rancher/agent/cloudprovider/aliyun/aliyun_provider.go:57 +0x48\n","stream":"stderr","time":"2017-12-05T14:24:18.060915644Z"}
{"log":"github.com/rancher/agent/cloudprovider.GetCloudProviderInfo.func1(0xf4af80, 0xc42024bb40)\n","stream":"stderr","time":"2017-12-05T14:24:18.060920056Z"}
{"log":"\u0009/go/src/github.com/rancher/agent/cloudprovider/cloud_provider.go:60 +0x64\n","stream":"stderr","time":"2017-12-05T14:24:18.060924422Z"}
{"log":"created by github.com/rancher/agent/cloudprovider.GetCloudProviderInfo\n","stream":"stderr","time":"2017-12-05T14:24:18.060928857Z"}
{"log":"\u0009/go/src/github.com/rancher/agent/cloudprovider/cloud_provider.go:80 +0x1f5\n","stream":"stderr","time":"2017-12-05T14:24:18.060933144Z"}

Workaround is using -e CATTLE_DETECT_CLOUD_PROVIDER=false to the command running rancher/agent

@loganhz Can you verify this is fixed with the fix mentioned in https://github.com/rancher/rancher/issues/10439 ?

@superseb I need to submit a PR to rancher/agent. This issue will be fixed after the rancher/agent change.

Fix for https://github.com/rancher/rancher/issues/10439 is for a non-200 return code. This issue is when the return code is 200 but the response is not valid for aliyun metadata.

This is an Aliyun server side issue. I have added a recover logic to avoid rancher agent crash.

@kingsd041 this can be tested with rancher/server:v1.6-development which pulls from master or you can wait for a RC (which should be monday)

We were unable to reproduce this issue as it requires a aliyun server side crash. We've made a fix for it in v1.6.13. if this happens again after the release, please re-open.

This can be tested using:
ifconfig eth0:0 <IP_ADDRESS> up
docker run -d --net=host -p 80:80 nginx
sudo docker run --rm --privileged -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/rancher:/var/lib/rancher rancher/agent:v1.2.8-rc1 http://xxx

Just tested, and it works.


Azure OCR JSON file creation

Package Name:  DocumentAnalysisClient
Package Version:  3.2.0b5
Operating System: windows 10
Python Version: Python 3.6.4

Describe the bug
how to create the below ocr.json file using the azure documentanalysisclient or other OCR functions.  when I load the blob folder in form recognizer studio, it creates the below ocr json for the pdf document automatically. I want to create the same JSON ocr file with the azure python ocr function.
train_docs.zip
To Reproduce
Steps to reproduce the behavior:
I used the below code but it is not returning the results in the OCR json format.
https://learn.microsoft.com/en-us/python/api/azure-ai-formrecognizer/azure.ai.formrecognizer.documentanalysisclient?source=recommendations&view=azure-python
Expected behavior
A clear and concise description of what you expected to happen.

Hey, @dsabarinathan! Thanks for opening an issue. I can tag people who should be able to help. However, from a cursory look, have you tried looking through the form recognizer samples? I know we have one here that appears to outline the process of going converting some results to JSON.

Hi @dsabarinathan! Thanks for the question. The way to create the OCR files is through Form Recognizer Studio. Those files can then be used to train a new custom analysis model with the SDK. You can use begin_build_document_model() on  DocumentModelAdministrationClient to do so. The DocumentModelAdministrationClient has methods that can be used to build, compose, copy, get, list, and delete document models, among others. Since the OCR files need to be labeled, the user interface in Form Recognizer Studio provides a way to easily do that. For unlabeled document analysis you could use begin_analyze_document() on DocumentAnalysisClient with the prebuilt-document model ID.

Thank you for the suggestion. @pvaneck @catalinaperalta .
The below code is working for me.
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/formrecognizer/azure-ai-formrecognizer/samples/v3.2/sample_convert_to_and_from_dict.py#L60


Add logic for setting curve names in output files generated by time queries

Description
Resolves #19139
Mechanism uses labels set in output avtDataTree specs. When writing output curve names, if those labels are empty, will use the generic 'curve'.
Basic queries not var related will set the labels with their query name, var-related will add the var as well.
Examples:
Min_pressure
Max_pressure
3D_surface_area
Trajectory_u_v_zone_0_domain_0
Weighted_sum_pressure
Volume
Average_value_pressure
Type of change

[ ] Bug fix
[X] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?
I ran time queries, saving curves to files, verified use of query and var names instead of generic 'curve'.
Checklist:

[X] I have commented my code where applicable.~~
[X] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[X] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.
[X] I have NOT made any changes to [protocol or public interfaces][3] in an RC branch.~~

@biagas just some quick questions before I dig in. You mention "saving" here. Do you mean a Save Window operation where the window holds curve(s)? And, is there anything related to Exporting curves to any of our database exporters as well?

Echoing @markcmiller86, I am worried every time I see the datasetfilewriter because there are many secret ways to get files out of VisIt.

@biagas just some quick questions before I dig in. You mention "saving" here. Do you mean a Save Window operation where the window holds curve(s)? And, is there anything related to Exporting curves to any of our database exporters as well?

This in general is for the results of a Time query.  I don't see 'export' working with time query results.

A couple minor things. Also, is there a way to add tests for this? This is very cool!

I could add tests:  Just write out results of a time query, then see if I could open the file and plot the curve. Is there a way to check if Visit errors on DrawPlots() ? I wouldn't necessarily want to do an image test again, just see if opening and plotting works.

Is there a way to check if Visit errors on DrawPlots() ?

I don't know :(


Unable to import bash.py

I was trying to run some bash commands using the bash.py but I am getting ModuleNotFoundError. I followed following steps

Created a directory named bashing and changed to it.
Created a virtual environment using pipenv --three and then activated it using pipenv shell.
Installed bash.py using pipenv install bash.py and in the repl when I imported bash I am getting following error.

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'bash'

But I am able to see bash.py in pipenv graph

bash.py==0.2.2
  - delegator.py [required: Any, installed: 0.1.1]
    - pexpect [required: >=4.1.0, installed: 4.7.0]
      - ptyprocess [required: >=0.5, installed: 0.6.0]

I am on mac osx 10.14.4 Mojave with python 3.7.3 and pipenv, version 2018.11.26.

I get the same error at ubuntu18, and manual fix it by run the following command at terminal (pipenv shell activated):
wget https://raw.githubusercontent.com/kennethreitz/bash.py/master/bash.py -P `python -c 'import delegator;from pathlib import Path;print(Path(delegator.__file__).parent)'`

This works for me on macOS 10.14.4, Python 3.7.3 and Pipenv 2018.11.26:
pipenv --three install bash.py
pipenv run python -c 'import bash; p=bash.run("echo hi!"); print(p.output)'

this was an issue with a previous release


Feature Request: Show terminal size when resizing the window

Description of the new feature/enhancement
There was this cool feature in PuTTY, that when you resize the window, it also tells you the size of the window in COLUMNS and ROWS in a small tooltip. This would make it easier for users to set the terminal to their appropriate size.
I know there is a setting for the initial size, but sometimes you want to resize your terminal to an exact size and this feature would help.

Proposed technical implementation details (optional)
Whenever the terminal window is resized by the user using either the mouse or other hotkeys, then a little tooltip will appear and show the current size (COLUMNS x ROWS) of the terminal.

This could be displayed in the status bar, when it is implemented

How about in the corner of the main window from where it is resized. I mean when we resize the window our focus is in that corner.

This seems like a good and reasonable feature request. IMO this doesn't need to be part of the status bar and could just be a little popup like @Biswa96 suggests.

Just as in #2834:

how does this work with multiple panes open? Especially if the panes have different fonts or font sizes?

Just as in #2834:

how does this work with multiple panes open? Especially if the panes have different fonts or font sizes?

I don't think it's an issue here, is it? You could just show each pane's size at the corner or center of that particular pane. This is what Konsole does:

I was thinking that the tab/title text of the active tab could be replaced by the size of the active tab during a resize.  Or perhaps the text for every tab could show the tab's size.
The question of different fonts for each tab brings to mind all of my fixed-width font programs...  The user sets the font face and the number of rows/columns and my code determines the best fit font for the current window size (leftover pixels are used as a "frame" in the background color around the text area.)  Perhaps we actually want a way to right-click on a tab and say something like, "This tab ALWAYS has XX rows and YY columns."  Then Windows Terminal could generate the best font for the required size.

To me;
The MVP would be to show all of the impacted sizes each time I am resizing things,

If there are no panes, it would only show the window size, in the lower left corner or perhaps where the mouse is "pulling".
if you have panes, and are resizing the panes (not the window), it would only show the pane sizes in the middle of the pane..
If you have panes and are resizing the window, Show both sizes.

Hello, no news about this feature ?
It seems to be removed from the backlog, so nobody interested ?

It only moved from one backlog to another backlog. :)
We'll gladly accept a PR for this, but we're currently not planning to work on this ourselves.


Show warning under 100 subs for yt sync

currently we aren't syncing channels under 100 subs or if the sub count is not public. Make this warning on yt sync page / don't allow sync.

Replaced with https://github.com/lbryio/lbry.com/issues/1282


[refactor] replace soon to be deprecated componentWillReceiveProps

with componentDidUpdate.
The new recommendation for making network requests when there is a difference between current + previous props is to do so in componentDidUpdate (see: https://reactjs.org/docs/react-component.html#componentdidupdate)
When react enables async rendering in future releases of react, this will break lifecycle methods into "render" phase and "commit" phase. Methods in the "render" phase (includes componentWillReceiveProps) are meant to be side-effect free as they might be called multiple times.
componentDidMount and componentDidUpdate are called in the "commit" phase and are the recommended place for side-effects (includes network calls). see: https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects
twitter thread with more context: https://twitter.com/ken_wheeler/status/983022255746768897?s=20

Pull Request Test Coverage Report for Build 95

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 96.032%

Files with Coverage Reduction
New Missed Lines
%

src/components/client.tsx
1
96.15%

Totals

Change from base Build 92:
0.02%

Covered Lines:
176

Relevant Lines:
177

💛  - Coveralls

Pull Request Test Coverage Report for Build 95

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 96.032%

Files with Coverage Reduction
New Missed Lines
%

src/components/client.tsx
1
96.15%

Totals

Change from base Build 92:
0.02%

Covered Lines:
176

Relevant Lines:
177

💛  - Coveralls


export CARGO_HOME inside working directory

I'm working on a test where I create an http test server using the "httptest" crate and I create blocking requests to it using "reqwest". The test passes successfully when Cargo home is located in its default location. However, when I alter Cargo home's location by setting the CARGO_HOME environmental variable to a directory inside the working directory (the cargo directory where the source is also located) the reqwest request fails with a timeout and the test fails. "cargo test" works fine btw in both cases.

So I tried setting CARGO_HOME on another project and running tarpaulin and it worked without any issue. Could you provide a link to a repo I can reproduce this with?

Thanks for trying it. I have a created a reprex here: https://github.com/thsioutas/HttptestAndReqwest

Awesome, thanks for that I can now reproduce it on my machine :+1:  I'll update you when I've made some progress

Okay I've cracked this, the CARGO_HOME variable means source code is downloaded into the folder that shows up in the project directory and in the debug info so tarpaulin identifies it as source to cover. Then with tons of extra traces this likely slows down the test to the point where reqwest times out.
I've added home filtering to source analysis and my cargo handling. I just need to add it to the binary instrumentation which is going to be a bit fiddlier, but hopefully I'll have something today.

And it's fixed and tested on your example project! Which is now also part of my integration tests. This is currently in the develop branch if you want to use it right now and it'll be in the next release.


import of matplotlib causes error on Mac OS X (depending on backend)

Since skopt import matplotlib for its plotting, it runs into some known issues with Mac OSX
    from matplotlib.backends import _macosx
RuntimeError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are using (Ana)Conda please install python.app and replace the use of 'python' with 'pythonw'. See 'Working with Matplotlib on OSX' in the Matplotlib FAQ for more information.

this can be fixed by
import matplotlib
matplotlib.use('PS')

before importing matplotlib.pyplot
but it would be nice if skopt could import such that it ignores those plotting-related issues for cases when one is not interested in plotting

Do you know how other projects handle this? I think the reason matplotlib gets imported as soon as you import skopt is because skopt imports the plotting things at the top level. Would be nice to delay that to fix this error and speed up initial skopt imports.

How do you get the error? I am on mac and haven't ever seen it :(

@betatim I think it's related to whether you use the system native python or not (including usage of virtualenvs.... e.g. for me, I get this behaviour
$> pyenv shell system
$> python
>>> import matplotlib.pyplot as plt #works

$> pyenv shell system
$> virtualenv venv
$> source venv/bin/activate
$> pip install matplotlib
$> python
>>> import matplotlib.pyplot as plt #fails

$> pyenv shell 3.5.1
$> python
>>> import matplotlib.pyplot as plt #fails

I think it would be reasonable to have sth like
try:
   import matplotlib.pyplot as plt
except RuntimeError as e:
   if 'Python is not installed as a framework.' in e.message:
     warnings.warn(.. some warning about disabled backend...)

you could also just handle any ImportError or RuntimeError resulting from the plotting imports and handle them in a non-raising way

I was able to work around the problem by forcing matplotlib to use TCL/TK and reinstalling python with tcl. This solved the problem both when running in a virtual env and in the native python environment.
I'm using homebrew so the following is what I did.
echo "backend: TkAgg" >> ~/.matplotlib/matplotlibrc
brew uninstall python3
brew install python3 --with-tcl-tk

Yes, a number of workarounds exist (e.g. 'PS' backend in OP), but I was hoping that skopt would only import matplotlib when I actually want to do some plotting and not earlier.

I think in general fixing your dependencies to be properly installed is up to the user. scikit-optimize shouldn't try and fix it for you or do weird stuff to help users who can't install things.
However delaying the import of matplotlib until it is actually needed is a useful feature to have because it would speed up the initial skopt import and allow us to make it an optional dependency (for example if you are running on a headless node). I think this approach would also solve the original problem described here.
If anyone knows a nice pattern used by other libraries to support optional dependencies please post them. So far all I could find was the pandas approach of importing in a class and several extra modules that delay imports. A widely used pattern would be nice to reduce the chances of weird side effects :-/

@betatim
There are good reasons for why scientific libraries don't usually have matplotlib as a direct dependency: it is very platform dependent and it is usually not essential for what these libraries are trying to accomplish. Why should an optimization library depend so heavily on a visualization library?
I agree that you shouldn't try to fix dependencies for the user and I would go even further: you shouldn't even install it for them.
Take pandas as example: they have the plot() method on dataframes and series that call matplotlib.pyplot.plot() but they only import it at the time of the call and matplotlib isn't even a dependency of pandas! And the reason is very simple: pandas is a data manipulation library, the visualization part is just a kind of add-on. Leaving matplotlib out by default instead of pushing it into users that don't even need it seems like a reasonable decision to make.
I'm trying to solve a similar problem to the one described. We have a library that will depend on scikit-optimize but we are having problems because we can't depend on matplotlib platform sensitiveness and, sincerely, we just need the optimizing functions.
Is a change like this something you are willing to accept? We can propose a PR for this if you are!
Thanks for the great library you have here!

I agree with @carlosdanielcsantos though I think it might be reasonable to install the libraries as part of an extra, i.e. pip install skopt[plotting].  (I think this is what you asked for @betatim, it's a way specify optional dependencies  in setuptools).

This is exactly what I implemented in #639 :) It has been sitting there unmerged because I didn't know off the top of my head how to add a test for the behaviour. Maybe we can merge it without a test and someone contributes that test in a new PR.

I don't think there's a downside of not importing matplotlib. The only thing we have to guarantee is that all the current tests pass (we need to install with the option "plots" when testing, but that is being done in the PR). If we want to test the behavior of not installing matplotlib we just have to do an assertRaises on import matplotlib when scikit-optimize is installed without the "plots" option.
I deferred import to use time just because this is how other well established libraries do it. I sincerely can't see much difference between both approaches (between importing at use time or when importing plots submodule).


Yhzhang/add mlugowl llamaadapter

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
add_mlugowl_llamaadapter
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

@gaotongxiao  Not sure why there are still lint errors, any ideas?


IPv4/single: resubmit ARP cache changes found in PR #366

Description
In December 2021, after protocol testing, @AniruddhaKanhere submitted some changes regarding the usage of the ARP cache, which he documented as follows:
"This PR removes the call to refresh ARP cache entry when a UDP/TCP packet is received. It replaces that call with a function to only update the ARP entry age.
Additionally, the translation of IP->MAC must be done through ARP cache. Thus this PR translates an IP to MAC using ARP cache instead of switching the source and destination MAC address before sending any packet"
In today's main branch, some of the changes have disappeared. I assume that this happened accidentally.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you @htibosch for this PR. I am also not sure why the changes disappear.
Regardless, grateful if you could fix the unit-tests.

/bot run uncrustify

Hi Hein, Do we still this need this change. If yes, please help in fixing the unit-test and it will be good if we can create a PR for dev/ipv6_integration branch.

@shubnil wrote:

Hi Hein, Do we still this need this change. If we do, please help in fixing the unit tests and it will be good if we can create a PR for dev/ipv6_integration branch.

Yes we still need it, both in IPv4 and dev/IPv6_integration.


Added note to "Adding Service Labels" section

Hey, thanks for the all the work put into this project! It's really making our lives a lot easier.
I have one small suggestion for the docs, and it's that I believe support for Service Types should be clarified in the Adding Service Labels section.
In particular, perhaps it should be highlighted that only Stateless Service Types are fully supported right now, as I spent a decent amount of time wondering why I couldn't get a Frontend label registered for my Stateful Service, before coming across this open issue: https://github.com/containous/traefik-extra-service-fabric/issues/32.
Thanks,
Paul

I agree this should be clarified in the docs, sorry you lost time digging around for the issue and massive thanks for submitting the PR to help out others!

Ah great stuff, thank you!


Make documentation readable via Godot editor

Same way it is done for all other native classes, e.g. Vector3D or Node3d. Starting point
It worth noting that making documentation is not single issue, but a process. Close this issue when few classes will be documented and there will infrastructure to add new docs.

In case of GDExtension - see https://docs.godotengine.org/en/stable/tutorials/scripting/gdextension/gdextension_docs_system.html

Both GDExtension and module build supported. So there should be a way to mitigate doubling of work

I believe would need to make a doc_classes folder where the XML files would be contained, the files seems to be the same between the 2 build modes. So for the extension, it would need to run the actual godot engine binary to generate the initial stubs files for the classes, afterwards would be basically filling up the information on them, then have to edit the SConstruct to include those files with source=Glob("doc_classes/*.xml")).
As for the module side the documentation states that one simply needs to define 2 functions on the config.py file for gathering the folder where the XML files are into (would be the exact same as the GDExtension one) and the actual classes contained on there. This way, accordingly to the docs, the same XML files would be used for both build methods.

I also thought it should work like you described, but didn't test it yet. Actually won't test it in nearest future.
If you are interested, doxygen already generates xmls for online documentation. I hope those xmls may be reused for godot, at least with some adaptor/script. Xml files look like this:
xml.zip


Document JWT and OIDC updates for v24.3

[DOC-10973] Docs for renamed setting jwt_authentication.issuers.configuration
[DOC-10630] Document new cluster setting server.jwt_authentication.issuer_custom_ca
[DOC-10852] Document new cluster setting server.jwt_authentication.client.timeout
[DOC-10633] Document new cluster setting server.oidc_authentication.client.timeout

TFTR! I took the opportunity to rewrite the steps to be imperative sentences instead of just setting names, and consolidated the info-gathering from the IdP into a single step, too. Much improved.


sc-10745 upgrade to react 18 on admin UI

Scope of changes
sc-10745 upgrade to react 18 on admin UI
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] refactoring

Acceptance criteria
https://app.shortcut.com/rotational/story/10745/upgrade-to-react-18-on-admin-ui
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 44.51% // Head: 45.11% // Increases project coverage by +0.59% :tada:

Coverage data is based on head (e4a6e71) compared to base (6507ff4).
 Consider uploading reports for the commit 019d45e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   44.51%   45.11%   +0.59%
==========================================
  Files         658      471     -187
  Lines       23850    20991    -2859
  Branches     1498      761     -737
==========================================
- Hits        10618     9470    -1148
+ Misses      11873    10349    -1524
+ Partials     1359     1172     -187

Flag
Coverage Δ

unittests
45.11% <ø> (+0.59%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...components/CertificateManagement/StatisticCard.tsx
0.00% <0.00%> (-100.00%)
:arrow_down:

...onents/ConfirmIdentityCertificateRequest/index.tsx
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/components/CertificateManagement/Statistics.tsx
25.00% <0.00%> (-75.00%)
:arrow_down:

web/gds-user-ui/src/components/WarningBox.tsx
0.00% <0.00%> (-50.00%)
:arrow_down:

web/gds-user-ui/src/App.tsx
33.33% <0.00%> (-16.67%)
:arrow_down:

...-ui/src/components/CertificateManagement/index.tsx
0.00% <0.00%> (-16.67%)
:arrow_down:

...crypto/directory/pkg/bff/models/v1/collaborator.go
84.21% <0.00%> (-15.79%)
:arrow_down:

web/gds-user-ui/src/utils/axios.ts
9.30% <0.00%> (-7.10%)
:arrow_down:

...user-ui/src/components/CertificateReview/index.tsx
0.00% <0.00%> (-5.13%)
:arrow_down:

web/gds-user-ui/src/application/routes/routes.ts
75.00% <0.00%> (-5.00%)
:arrow_down:

... and 219 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


DLRS v2.1 - v2.3 - Lookup Rollup Calculate Jobs not Case-sensitive

Hi, there -
I have noticed in v2.1 - v.2.3 (one version is installed in one Sandbox, the other in a second Sandbox...I have not been ignoring the issue for two versions ;-)) that, from time to time, I will attempt to run a real-time Calculate on a DLRS record and get a trigger error indicating that a Lookup Rollup Calculate Job is already running for the record...upon further investigation, the Lookup Rollup Calculate Job is actually running on a different DLRS record with the same Record Id but different letter-case in the Record Id:

a9U290000004GNy versus
a9U290000004GNY

and

a9U290000004GNx versus
a9U290000004GNX

Thanks @JenNelsonChicago, this very much sounds like a case sensitivity bug to me. I'll investigate, good spot btw! 👍

Awesome - thanks, Andy, as always, for the quick response! :-)

Note to self, using 18 character ID's as the field value should resolve this as i cannot change the case insensitive status of a packaged field.

Fixed in v2.6. Thanks @wes1278  for the fix!

Thanks @wes1278 and @afawcett !  This is awesome! :-)

:)


Update description and add paths to coverage

No change is needed to the test code.  This update:

Improves the description to match the content of the test
Adds paths used in the policies to the coverage section of the README

Pull Request Functional Test Report for #2798 / 185ee7dbb7e470fab9393616bd59669e7ae35883
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.5: BGP Policy - Set Link Bandwidth Community
a14a3133
Log

Cisco 8000E

RT-7.5: BGP Policy - Set Link Bandwidth Community
ad149dd4
Log

Cisco XRd

RT-7.5: BGP Policy - Set Link Bandwidth Community
29ade4db
Log

Juniper ncPTX

RT-7.5: BGP Policy - Set Link Bandwidth Community
575db12a
Log

Nokia SR Linux

RT-7.5: BGP Policy - Set Link Bandwidth Community
03d68050
Log

Openconfig Lemming

RT-7.5: BGP Policy - Set Link Bandwidth Community
15b77e26
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.5: BGP Policy - Set Link Bandwidth Community

Cisco 8808

RT-7.5: BGP Policy - Set Link Bandwidth Community

Juniper PTX10008

RT-7.5: BGP Policy - Set Link Bandwidth Community

Nokia 7250 IXR-10e

RT-7.5: BGP Policy - Set Link Bandwidth Community

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.484%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1847

Relevant Lines:
3390

💛  - Coveralls


Add support to Cargo.toml metadata tables

Description of changes:
Cargo rmc is able to extract flags from a toml configuration file. In
order to provide a good experience to users that want to add
configurations to their Cargo.toml, we are adding support to the
standard metadata tables supported by cargo.
We still support the [rmc] tables in cases users prefer to use a
different rmc.toml file, but this is discouraged for Cargo.toml files
since it will generate a warning every time a user runs cargo.
Resolved issues:
Fixes #739.
Call-outs:
Testing:

How is this change tested? New test

Is this a refactor change? No

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

LGTM. Are we planning to update the documentation to mention workspace.metadata.rmc/package.metadata.rmc in a separate PR?

You read my mind. I actually created this PR because I was updating the doc. :)


Error occurred when executing KSampler (Efficient):

Error occurred when executing KSampler (Efficient):
'BaseModel' object has no attribute 'diffusion_model.input_blocks.1.1.transformer_blocks.0.attn1'
File "/root/ComfyUI/execution.py", line 152, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/root/ComfyUI/execution.py", line 82, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/root/ComfyUI/execution.py", line 75, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/root/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 700, in sample
samples, images, gifs, preview = process_latent_image(model, seed, steps, cfg, sampler_name, scheduler,
File "/root/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 533, in process_latent_image
samples = KSampler().sample(model, seed, steps, cfg, sampler_name, scheduler, positive, negative,
File "/root/ComfyUI/nodes.py", line 1355, in sample
return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise)
File "/root/ComfyUI/nodes.py", line 1325, in common_ksampler
samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
File "/root/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/sampling.py", line 267, in motion_sample
return orig_comfy_sample(model, noise, *args, **kwargs)
File "/root/ComfyUI/custom_nodes/ComfyUI-Impact-Pack/modules/impact/sample_error_enhancer.py", line 9, in informative_sample
return original_sample(*args, **kwargs) # This code helps interpret error messages that occur within exceptions but does not have any impact on other operations.
File "/root/ComfyUI/comfy/sample.py", line 93, in sample
real_model, positive_copy, negative_copy, noise_mask, models = prepare_sampling(model, noise.shape, positive, negative, noise_mask)
File "/root/ComfyUI/comfy/sample.py", line 86, in prepare_sampling
comfy.model_management.load_models_gpu([model] + models, model.memory_required([noise_shape[0] * 2] + list(noise_shape[1:])) + inference_memory)
File "/root/ComfyUI/comfy/model_management.py", line 434, in load_models_gpu
cur_loaded_model = loaded_model.model_load(lowvram_model_memory)
File "/root/ComfyUI/comfy/model_management.py", line 301, in model_load
raise e
File "/root/ComfyUI/comfy/model_management.py", line 297, in model_load
self.real_model = self.model.patch_model(device_to=patch_model_to) #TODO: do something with loras and offloading to CPU
File "/root/ComfyUI/comfy/model_patcher.py", line 179, in patch_model
old = getattr(self.model, k)
File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1695, in getattr
raise AttributeError(f"'{type(self).name}' object has no attribute '{name}'")

解决了吗？

解决了吗？

没有不知道什么原因

解决了吗？

没有不知道什么原因

update comfyui
主要是comfy/model_management   comfy/utils    comfy/model_patcher 三个文件


Feat/vitest

Todo:

[x] implement test filter for mutantRun in vitest-test-runner.ts with regex filter
[x] more unit tests if possible
[x] more integration tests
[x] add 1 e2e test
[x] refactor vitest-test-runner.ts
[x] Enable Stryker on integration tests
[x] Unit test the FileCommunicator
[x] Remove other changes.
[x] Support workspaces, see https://github.com/vitest-dev/vitest/issues/3365 and https://github.com/stryker-mutator/stryker-js/pull/4043#issuecomment-1547278332
[ ] Clean state after each run, see https://github.com/vitest-dev/vitest/discussions/3017#discussioncomment-5901499

Optional:

[x] Add option to change config file path

As of<EMAIL_ADDRESS>vitest supports workspaces. This has 2 consequences:

We cannot use the vitest.config anymore to set setupFiles. They now need to be set for each project in the workspace.
The afterAll hook we use to write stuff to the communication dir is now being called once for each workspace. We should I think collect data inside a dir, instead of a file.

I've discovered another issue with vitest. See https://github.com/vitest-dev/vitest/issues/3403. This is a show-stopper for us. 😢

I think I managed to fix all issues.
This is a list of all the workarounds/changes I've applied since @odinvanderlinden's first draft

Since v0.30.0 vitest supports workspaces. This had a breaking change in the programmable API. Instead of using vitest.config we now use vitest.projects.forEach(project => project.config). See https://github.com/vitest-dev/vitest/issues/3365
Our vitest.setup.js file is now inlined using deps.inline, because otherwise they are cached by nodejs. See https://github.com/vitest-dev/vitest/issues/3403
When inlined, the vitest.setup.js file is cached between runs, because we're not using --watch mode. So we manually bust the cache for it using vitest.projects[0].server.moduleGraph.invalidateModule, see https://github.com/vitest-dev/vitest/issues/3409

@steschi, thanks for your reaction, but we should be able to get this working 😅

@nicojs sorry, didn't wanna confuse anybody with my reaction but I can relate to some of the burden of making things work with vite from my workplace.
Generally really excited to see this landing eventually, finally getting to have proper mutation testing on a modern web application stack 😍. Did not think I'd be able to apply some of the principles thought at university within a very modern web ecosystem like vite and vitest.
Thanks for the work you and your team is doing on this and greetings from Austria! 👋🏻


Add PermissionOverwrites.target

Please describe the changes this PR makes and why it should be merged:
This adds a target property to PermissionOverwrites
Semantic versioning classification:

[ ] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Um, this was not meant to happen