Add Suricata

This project lints correctly:
$ npx awesome-lint
✔ Linting
$

and has been out there for 30 days. Let's get it into the list! :)

https://github.com/satta/awesome-suricata#readme
This list contains resources in support of Suricata, a Free intrusion detection/prevention system and Network Security Monitoring engine. Suricata is a state of the art software tool that is used by many organizations, and that has spawned an active community of users and developers providing software, information and rulesets to support Suricata's mission.
As a member of that community, I compiled this list to gather these resources and create some visibility for the awesome projects out there!
My 2 reviews:

https://github.com/sindresorhus/awesome/pull/2391#issuecomment-1352326001
https://github.com/sindresorhus/awesome/pull/2442#issuecomment-1352336421

By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ add Swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The title of your entry should be title-cased and the URL to your list should end in #readme.

Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.

The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
The default branch should be named main, not master.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.
Must not feature Contributing or Footnotes sections.

Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't use hard-wrapping.
Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

unicorn

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Thanks! Awaiting reviews. 👍🏻

I noticed multiple things that are not followed

Huh. I can't find anything obvious, even after going through the list multiple times. Just to be safe, I did the following changes:

Renamed LICENSE.md to LICENSE and changed to plain text. I wouldn't think that would change anything about the readability and information content, but if it's that important...
Changed the wording in the description, by moving the text describing Suricata into the non-quoted text and using the quoted text to describe the list, as the other lists do.
Removed the line mentioning that contributions are welcome.
Note that there is no logo because I don't want to use possibly copyrighted project logos, and it says "have a logo wherever possible" which does not sound like a hard requirement.

If there's anything else, just let me know.

After reaching out to the OISF/Suricata team and confirming that I am permitted to use it, provided I do not alter the logo in any way, I now also added a logo including a link back to the Suricata home page https://suricata.io.

Just resolved the merge conflict that came up in the meantime.
I am curious: Any other feedback so far? Is there anything else I can do to move this forward?

Hello? Does anyone actually check any updates here?
From what I can see, I have addressed all points in the requirements that might be debatable even in the slightest sense. If there is anything left for me to do, please let me know. A one-word pointer would do, no need for any detailed explanation.

This project lints correctly:
$ npx awesome-lint
✔ Linting
$

and has been out there for 30 days. Let's get it into the list! :)

https://github.com/satta/awesome-suricata#readme
This list contains resources in support of Suricata, a Free intrusion detection/prevention system and Network Security Monitoring engine. Suricata is a state of the art software tool that is used by many organizations, and that has spawned an active community of users and developers providing software, information and rulesets to support Suricata's mission.
As a member of that community, I compiled this list to gather these resources and create some visibility for the awesome projects out there!
My 2 reviews:

https://github.com/sindresorhus/awesome/pull/2391#issuecomment-1352326001
https://github.com/sindresorhus/awesome/pull/2442#issuecomment-1352336421

By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ add Swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The title of your entry should be title-cased and the URL to your list should end in #readme.

Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.

The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
The default branch should be named main, not master.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.
Must not feature Contributing or Footnotes sections.

Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't use hard-wrapping.
Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Not sure what the above comment is supposed to tell me... 🤔

The list seems to follow the requirements. It would be good to explicitly state the words IDS and IPS, as acronyms can be confusing.

Thanks a lot for the review, I was already thinking this was stalled :)
Sure, I will make sure to explain these acronyms.

Linkify Suricata  in Suricata is a free intrusion detection/prevention system (IDS/IPS) and network security monitoring engine. to its website.

Linkify Suricata  in Suricata is a free intrusion detection/prevention system (IDS/IPS) and network security monitoring engine. to its website.

Done.

Tweet: https://twitter.com/awesome__re/status/1671458477661736960

Thanks a lot for making this happen!


Inline color control using ANSI escape codes

New tokens, Recognize sequences in parser
How to handle codes for smaller color spaces?

The above solution would interfere with the current zero width space and planned soft breaking character support. Need to implement in such a way that prevents wrappin a word if parts of it are styled differently.


Volatility Yarascan is throwing an error

When using yarascan plugin in volatility I get the error shown below. Can you advise how to resolve this please?
vol.py -f ~/Desktop/CTF/OtterCTF/what_the_password_COMPLETED/OtterCTF.vmem --profile=Win7SP1x64 yarascan -Y "Th3"

Volatility Foundation Volatility Framework 2.6
Traceback (most recent call last):
  File "/usr/bin/vol.py", line 192, in <module>
    main()
  File "/usr/bin/vol.py", line 174, in main
    command = cmds[module](config)
  File "/usr/lib/python2.7/dist-packages/volatility/plugins/malware/malfind.py", line 190, in __init__
    help = 'Make the search case insensitive')
  File "/usr/lib/python2.7/dist-packages/volatility/conf.py", line 363, in add_option
    self.optparser.add_option("-{0}".format(short_option), "--{0}".format(option), **args)
  File "/usr/lib/python2.7/optparse.py", line 1021, in add_option
    self._check_conflict(option)
  File "/usr/lib/python2.7/optparse.py", line 996, in _check_conflict
    option)
optparse.OptionConflictError: option -C/--case: conflicting option string(s): -C
`

Edit this:
I found a workaround:
Edit the malfind.py file at /usr/lib/python2.7/dist-packages/volatility/plugins/malware/malfind.py
change the short option at Line 189, Original is Capital C letter. In my case I change it to small c letter
config.add_option("CASE", short_option = 'c', default = False, action = 'store_true',
change the short option at Line 195. Original is Capital Y Letter. In my case I change it to capital U letter
config.add_option('YARA-RULES', short_option = 'U', default = None,
Make sure to backup the original file.
Original: https://github.com/teamdfir/sift/issues/218

This issue is still in the latest SIFT FYI ...

Looks like this is the case of conflicting plugins unfortunately. You can try disabling the malware one for now. We try to be very selective in which plugins are added and sometimes conflicts arise because authors use the same CLI options.


user guide: use non-deprecated forms of ocrd workspace clone/init

also makes the sample code for adding files in a for-loop more readable.

c.f. OCR-D/core#578 for the deprecations.


fix: re-calculate totals when invoice is edited

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/26054
PROPOSAL: https://github.com/Expensify/App/issues/26054#issuecomment-1702222167
Tests

[x] Verify that no errors appear in the JS console

Offline tests

Login
Turn offline mode on
Click on the plus sign and select "Request Money".
Enter the desired amount and email address for the money request
Open IOU report details and edit the amount to a smaller amount than the one in step 4
~6. Go back to IOU report and observe that the total is wrong~
Go back to IOU report and observe that the correct updated total ✅

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Web
https://github.com/Expensify/App/assets/64399555/ccee5984-4107-4801-8b9e-fff4a673f4c3

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mananjadhav gentle ping

@shubham1206agra Can you please merge with the latest main?

@mananjadhav Wrong PR😅

Sorry @shubham1206agra. @im-adithya Can you please merge with the latest main?

thanks for the delay, ig the fix has been merged in the meantime https://github.com/Expensify/App/pull/25498


Loadtest stableapis

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[x] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@mikekistler we have updated the operation to the final version as per our last discussion. Also to keep consistency with LoadTestRun operations we have added the suffix TestRun to all the operations for it so that SDK functions look consistent as below
TestRun and future adding of method
loadTestRun client4 = new LoadTestRun();
client4.CreateOrUpdateTestRun();
client4.CreateOrUpdateAppComponent();
If looks all good, can we merge this also

Marked as Approved-BreakingChange as this api-version has not yet been made available to customers.

@tjprescott can you merge this PR

@krishna I can merge this when the PR is green.

/azp run

@tjprescott  should be fine now


Force s3 client configured with devservice to use path-style addressing

https://github.com/quarkiverse/quarkus-amazon-services/issues/483

Thanks!


Extract the file listing done in the CLI into a dedicated class

        files = [
            f for f in listdir(input_dir) if isfile(join(input_dir, f))
        ]

from CLI.execute() should be extracted into a dedicated class, for instance FileLister.
The listing should also be limited to .gz and .zip file extensions.

        files = [
            f for f in listdir(input_dir) if isfile(join(input_dir, f))
        ]

from CLI.execute() should be extracted into a dedicated class, for instance FileLister.
The listing should also be limited to .gz and .zip file extensions.

I've pushed a solution to this:

extracted FileLister class
added parameterized tests
use the class from CLI.execute()
added additional constraint for the file extension

I think we can also make it better by removing the need to join(input_dir, file) in cli.py if we return the already joined path from FileLister. But I need to change the tests to do that, so I'll leave it for later.
Please review the changes when you can.

I agree we'd better remove the need to join(input_dir, file) in cli.py by moving this to the FileLister.
I like what you did. Thank you!

⚠ Breaking change
By moving the join(input_dir, file) to the FileLister, the console renderer now displays the report file path in the table instead of just the filename.


⚠ Jenkins Plugins Artifactory has degraded performance

In ebdf244, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1282 ms

Resolved: Jenkins Plugins Artifactory performance has improved in ba2a7a4 after 18 minutes.


add support for word count

The word count in Sanskrit is not the same as the way we do in English.
For English, a word counter (in its simplest implementation) will consider "words" as the sequences of word characters (like 'a', 'b', '1', '2', etc.) separated by non-word characters (like '\s', '-', '.', ']', etc.).
But in Sanskrit, we have sandhis. For example, in the text -- "ग्राममायाति। ग्रामं गच्छति। ग्रामङ्गच्छति।", we have 6 words -- ग्रामम्, आयाति, ग्रामम्, गच्छति, ग्रामम्, गच्छति. Though "ग्राममायाति" appears as one word, it should be considered as having two words. Similarly,  "ग्रामङ्गच्छति" should also be considered as having two words. Only a word counter that works in this manner can be a true word counter for Sanskrit. But this isn't easy to implement without a sandhi-splitter.
Moreover, if users want word count just as it is seen in English word counters (without sandhi-splitting) then they can use some of those tools available at here, here and here. I don't want to duplicate those functionalities in this app.
Also, I don't want to add any word-related functions to this app. As a tool for aksharas and varnas, I want to keep it simple and straightforward and it should do one thing well.


Fixing issue with migration and data dump

@mvilanova I removed some of your drop constraints from the migration file. It looks like you can't rename a constraint if it doesn't exist.  Neither of these constraints existed in the sample database which we mostly keep up-to-date. I'm not sure if that rename was an artifact or something else, but didn't seem to be needed here.
Let me know if there was some other outlier I'm missing.

If this can get the data dump working that will be such a life-saver for me instead of having to recreate data all the time!

If this can get the data dump working that will be such a life-saver for me instead of having to recreate data all the time!

We should re-add them. They could exist in databases from when the data model was called status_report (like ours). We updated the table name to report, but not the pkey, fkeys, and sequence id. We should keep the naming consistent. The IF EXIST should prevent the statement from throwing an error. Was that not the case?

We should re-add them. They could exist in databases from when the data model was called status_report (like ours). We updated the table name to report, but not the pkey, fkeys, and sequence id. We should keep the naming consistent. The IF EXIST should prevent the statement from throwing an error. Was that not the case?

Your IF EXISTS only applies to the report table, not the constraint itself. In this case, the table did exist but the constraint does not. Also, according to the Postgres documentation, you can't apply a RENAME IF EXISTS. You'll notice that alembic always drops and then creates new constraints when renaming.
Alembic will create new constraints for us, we shouldn't have to manage the rename ourselves.
Additionally, I don't see status_report_participant_id_fkey or status_report_incident_id_fkey anywhere in the repo. Which would lead me to believe that they weren't created (or managed) by alembic.
As an example you can see your new constraint being added by alembic automatically here:
https://github.com/Netflix/dispatch/blob/69da45c0388b5147ffc6266e398376dfcf427220/src/dispatch/alembic/versions/38f0b01448ba_.py#L80
I would have expected to see that for the old constraint in an old migration.

Your IF EXISTS only applies to the report table, not the constraint itself. In this case, the table did exist but the constraint does not. Also, according to the Postgres documentation, you can't apply a RENAME IF EXISTS. You'll notice that alembic always drops and then creates new constraints when renaming.
Alembic will create new constraints for us, we shouldn't have to manage the rename ourselves.
Additionally, I don't see status_report_participant_id_fkey or status_report_incident_id_fkey anywhere in the repo. Which would lead me to believe that they weren't created (or managed) by alembic.
As an example you can see your new constraint being added by alembic automatically here:
https://github.com/Netflix/dispatch/blob/69da45c0388b5147ffc6266e398376dfcf427220/src/dispatch/alembic/versions/38f0b01448ba_.py#L80
I would have expected to see that for the old constraint in an old migration.

Yeah, you won’t find status_report_participant_id_fkey or status_report_incident_id_fkey constrains in the code repo, because they would have been part of the initial alembic migration when the data model was called status_report: https://github.com/Netflix/dispatch/pull/356/files#diff-95d6b1585d93baa441da5ee419b414f7670186f7449a438202d28a3c2916ef41L32.
You can see how they would get created by relationships https://github.com/Netflix/dispatch/pull/356/files#diff-f863d914618068ec3bdcb4a9ad03accd36d9df84cdd0290f25889847f6bafa71L27 and https://github.com/Netflix/dispatch/pull/356/files#diff-f29c22e331c5c482cff30440ff9f626024d6bfc5335e4b2cfeedfea0ffef1cfeL163.
Again, I added them to ensure migration 38f0b01448ba_.py would not fail here for old databases created between when we open sourced the project and May 28, 2020 when we merged https://github.com/Netflix/dispatch/pull/356. I ran into the migration issue in test, and prod had the same out of date constrains, so I thought other users could run into the same issue and I felt it would look bad if I had to ask them to rename the constrains manually rather than having alembic take care of it. I did not take the sample data file into consideration. Given that it's probably more likely that new users are running into an issue when they're doing a database upgrade than hopefully old ones, I'm ok with leaving them out.

Yeah, you won’t find status_report_participant_id_fkey or status_report_incident_id_fkey constrains in the code repo, because they would have been part of the initial alembic migration when the data model was called status_report: https://github.com/Netflix/dispatch/pull/356/files#diff-95d6b1585d93baa441da5ee419b414f7670186f7449a438202d28a3c2916ef41L32.
You can see how they would get created by relationships https://github.com/Netflix/dispatch/pull/356/files#diff-f863d914618068ec3bdcb4a9ad03accd36d9df84cdd0290f25889847f6bafa71L27 and https://github.com/Netflix/dispatch/pull/356/files#diff-f29c22e331c5c482cff30440ff9f626024d6bfc5335e4b2cfeedfea0ffef1cfeL163.
Again, I added them to ensure migration 38f0b01448ba_.py would not fail here for old databases created between when we open sourced the project and May 28, 2020 when we merged https://github.com/Netflix/dispatch/pull/356. I ran into the migration issue in test, and prod had the same out of date constrains, so I thought other users could run into the same issue and I felt it would look bad if I had to ask them to rename the constrains manually rather than having alembic take care of it. I did not take the sample data file into consideration. Given that it's probably more likely that new users are running into an issue when they're doing a database upgrade than hopefully old ones, I'm ok with leaving them out.

Note: I've tested this on my end and the database dump is now working! Thanks guys!

Note: I've tested this on my end and the database dump is now working! Thanks guys!


How to update web view?

Hi, I want to feed an HTML output into web view on a periodic basis.. The problem is that I want to update either update current HTML context or replace existing parts (via JS). Is it possible to do?

JavaScript should work just fine to update stuff. But once the script is done running, that's it.

That's what I'm trying to understand. I want to push new content on a periodic
basis. I tried using current web view and what I get is continuous append
to web window, i.e. it start growing such that if I resize window I can see
previous content. What I want is to "clear" window with every push, like
terminal clear command.
On  0, Sveinbjorn Thordarson<EMAIL_ADDRESS>wrote:

JavaScript should work just fine to update stuff. But once the script is done running, that's it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/sveinbjornt/Platypus/issues/96#issuecomment-300856707

This is not possible at the moment, but perhaps implementing a REFRESH command in the output or something could do the trick.

Will implement this in the next version.

If I correctly understand the issue here, you should be able to accomplish this using the PHP interpreter to run an AJAX request. I haven't tried it myself, but so far I managed to actively fetch and pause multiple http streams using the PHP interpreter using Javascript and the Python interpreter specifically to render JSON content from Google Maps. BTW, Svein, I love your application. Managed to modify the Main nib file in XCode in order to make render the Webview into full screen.


Apply page: add more info about the selection criteria

Hey @escottalexander! Assigning this to you (I can't on the "Assignees" field so doing it here. I've just invited you to the BG org too).
As we discussed yesterday, let's have more info on the apply page so people are more aware of what we are looking for (and what we are NOT looking for). I think it shouldn't be a wall of text, but something concise.
Let me know if you have any questions!!
(A bit related is #66 )


Add Line Integral Convolution Vector Visualization

Hello,
I'd like to suggest a new feature: line integral convolution (LIC) visualization for vector fields! I've made an implementation of the feature myself on my local Osyris repo, and here's what the results look like for the sample data when visualizing the velocity vector field:

Essentially, this allows us to clearly see the orientation of velocity vector field while ditching any information on magnitude and direction. We can circumvent this problem by also adding quiver arrows to the plot:

You can see that the eddy-like structure of the velocity field at the top-center-right of the image is invisible with quiver arrows, whereas you can clearly distinguish it with the LIC. Obviously, this works better with higher resolution data, here's some examples from some of my simulations:

You can see how nicely this displays shock fronts!

Adding this feature is quite easy since there's already a pip module that does all the work for us (licpy). Essentially, I've simply added a new wrapper function in wrappers.py that calculates the LIC using licpy, and then it amplifies the contrast on the result and merges it with the density plot using alpha blending. This of course requires the renderer to check if the user requested the LIC before calling the wrappers in order to add the "alpha" parameter to the plots. In addition, I can't seem to get the alpha blending to work with pcolormesh, so instead I changed its wrapper function to use imshow instead. You'll find my implementation in this zip file:
osyris_with_lic.zip

I think this is a really cool idea, thanks for the suggestion.
Why don't you try to open a pull request with your implementation (you'll need to fork the repository before you can open a pull request), and we can discuss the changes there, instead of sharing via a zip file.
Cheers!


Update aircraft.yaml

I removed flying boat again in https://github.com/addshore/wikicrowd/commit/94b9baad0dd4d5b6f45fb5df9ca48eefaf273ff7
I don't think it is different enough from seaplane

I removed flying boat again in 94b9baa
I don't think it is different enough from seaplane

In my head it was to distinguish between
https://en.wikipedia.org/wiki/Seaplane#Types
So it can be float plane and flying boat.


Crash on latest Android Studio compilation

demo App crashes on start.
Steps to reproduce the behavior:

compile an apk from app/MainActivity.kt
install on Android 12+
Open
See error

App running

Device: Xiaomi Mi12 TPro
OS:MIUI14
Browser Chrome
Latest

You have to provide more information on the error like what the error is
I cant replicate your error.
it uses compileSdk = 34 in app and 33 in the package
android 12 is 31, so it may be a possible explanation

Thanks, it is working now
El jue, 21 mar 2024 a las 16:50, Dibyakshu Basumatary (<
@.***>) escribió:

You have to provide more information on the error like what the error is
I cant replicate your error.
it uses compileSdk = 34 in app and 33 in the package
android 12 is 31, so it may be a possible explanation
—
Reply to this email directly, view it on GitHub
https://github.com/Dibyakshu/peripage-kotlin-bluetooth-printer/issues/2#issuecomment-2012732770,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEBJTGAJMCPKRQUHK43K3MTYZL6TFAVCNFSM6AAAAABCZZRQI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJSG4ZTENZXGA
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

--
Mariano Goñi http://www.marianogoni.com


Tweak the AsyncSystem document a bit

I moved the description of AsyncSystem implementation to the end of the document, where I think it's less of a distraction to the reader's introduction to AsyncSystem.

Thanks @timoore! Moving the info about creating an AsyncSystem to the end makes sense to me. There are a couple of new technical inaccuracies, though. Let me know if you want to keep working on this or if you'd prefer me to just do a pass over it now.

I'll have a go at your comments and see if I'm converging on something accurate.

Thanks @timoore!


wasm: removed automatical route refreshment and add a foreign function to clear the route cache

Commit Message: wasm: removed automatical route refreshment and add a foreign function to clear the route cache
Additional Description:
Here are the reasons to do this change:

It make it's impossible to only mofify the host or path or some headers but don't effect the route result.
Basically, refreshing route is not encouraged. Even the filters (ext_authz, jwt_authz, ext_proc, etc) who acutally need or want to clear the route cache  will also provide a flag (and basically default to false) to control the behavior.
Refreshing route have big effect to the traffic and should only be done explicitly (code or configurations), we should never change it implicitly.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

/retest

/wait

/retest

/retest

cc @kyessenov I will add the xDS options in next PR. This should be OK becasue we won't cut a release recently anyway. 🤣   (BTW: I think the new HTTP-specific options to the xDS configuration may bring much more effect to your code base than we think.)

/retest

friendly ping @mpwarres :)


Build/output folder missing

I tried downloading the code and it runs the first step correctly but gets hung up on step two. I noticed in your tutorial that you have a build folder that I cannot find in this or other versions of the commit. I am not an avid coder and don't know how to remedy this.
The error message I am receiving:
cd ./step2_spritesheet_to_generative_sheet; npm run generate The system cannot find the path specified. make[1]: *** [Makefile:11: step2] Error 1 make[1]: Leaving directory 'C:/Users/Sean/Desktop/Generative_Gif_Engine-main make: *** [Makefile:24: all] Error 2

@trying-my-best yea the build folder will be created in step 3.
Looks like an issue with make step2. Did you make any changes? What operating system are you on and specs of your computer?

Re-downloaded the git because I tried to manually add the build folder thinking that might work 😅
It is still hung up on step 2. I'm on Windows 11, Surface pro 8 32gb ram.

Hmm can you copy and paste the entire terminal output?

Certainly! Should I run make all or make step2? It produces different error codes

so performing make all produces this
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main> make all make step1 make[1]: Entering directory 'C:/Users/Sean/Desktop/Generative_Gif_Engine-main' python3 ./step1_layers_to_spritesheet/build.py ********Starting step 1: Converting pngs to spritesheets******** Parsing layer folder Background Parsing attributes in folder: Dark Blue#20 Parsing attributes in folder: Green#20 Parsing attributes in folder: Grey#20 Parsing attributes in folder: Light Blue#20 Parsing attributes in folder: Multicolor#1 Parsing attributes in folder: Orange#20 Parsing attributes in folder: Pink#20 Parsing attributes in folder: Yellow#20 Parsing layer folder Ball Parsing attributes in folder: Blue#20 Parsing attributes in folder: Green#20 Parsing attributes in folder: Multicolor#1 Parsing attributes in folder: Orange#20 Parsing attributes in folder: Pink#20 Parsing attributes in folder: Purple#20 Parsing attributes in folder: Red#20 Parsing attributes in folder: Yellow#20 Parsing layer folder Hat Parsing attributes in folder: Birthday#20 Parsing attributes in folder: Cowboy#20 Parsing attributes in folder: Green Square#5 Parsing attributes in folder: Mini Ball#1 Parsing attributes in folder: None#50 Parsing attributes in folder: Top Hat#20 Parsing attributes in folder: White Cap#20 Parsing attributes in folder: Wizard#1 Parsing layer folder Landscape Parsing attributes in folder: Cupcake#10 Parsing attributes in folder: Face#20 Parsing attributes in folder: Goldfish#20 Parsing attributes in folder: Green Tower#30 Parsing attributes in folder: Mountain#20 Parsing attributes in folder: None#20 Parsing attributes in folder: Red Tower#30 make[1]: Leaving directory 'C:/Users/Sean/Desktop/Generative_Gif_Engine-main' make step2 make[1]: Entering directory 'C:/Users/Sean/Desktop/Generative_Gif_Engine-main' cd ./step2_spritesheet_to_generative_sheet; npm run generate The system cannot find the path specified. make[1]: *** [Makefile:10: step2] Error 1 make[1]: Leaving directory 'C:/Users/Sean/Desktop/Generative_Gif_Engine-main' make: *** [Makefile:23: all] Error 2 PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main>

make step 2 produces this
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main> make step2
cd ./step2_spritesheet_to_generative_sheet; npm run generate
The system cannot find the path specified.
make: *** [Makefile:10: step2] Error 1

make step3 produces
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main> make step3
python3 ./step3_generative_sheet_to_gif/build.py
Traceback (most recent call last):
File "C:\Users\Sean\Desktop\Generative_Gif_Engine-main\step3_generative_sheet_to_gif\build.py", line 4, in
import imageio
ModuleNotFoundError: No module named 'imageio'
make: *** [Makefile:19: step3] Error 1
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main>

Very strange, did you run make first_time_setup what does that show?

Yes, this is the output when I run it again
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main> make first_time_setup
python3 -m pip install --upgrade Pillow
Requirement already satisfied: Pillow in c:\users\sean\appdata\local\packages\pythonsoftwarefoundation.python.3.10_qbz5n2kfra8p0\localcache\local-packages\python310\site-packages (9.2.0)
pip3 install -r requirements.txt
Requirement already satisfied: Pillow==9.0.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 1)) (9.0.1)
Requirement already satisfied: pre-commit==2.17.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 2)) (2.17.0)
Requirement already satisfied: black==22.3.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 3)) (22.3.0)
Requirement already satisfied: imageio==2.16.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 4)) (2.16.1)
Requirement already satisfied: cfgv>=2.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (3.3.1)
Requirement already satisfied: virtualenv>=20.0.8 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (20.16.4)
Requirement already satisfied: pyyaml>=5.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (6.0)
Requirement already satisfied: identify>=1.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (2.5.3)
Requirement already satisfied: nodeenv>=0.11.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (1.7.0)
Requirement already satisfied: toml in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (0.10.2)
Requirement already satisfied: platformdirs>=2 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (2.5.2)
Requirement already satisfied: pathspec>=0.9.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (0.10.1)
Requirement already satisfied: mypy-extensions>=0.4.3 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (0.4.3)
Requirement already satisfied: click>=8.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (8.1.3)
Requirement already satisfied: tomli>=1.1.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (2.0.1)
Requirement already satisfied: numpy>=1.20.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from imageio==2.16.1->-r requirements.txt (line 4)) (1.23.2)
Requirement already satisfied: colorama in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from click>=8.0.0->black==22.3.0->-r requirements.txt (line 3)) (0.4.5)
Requirement already satisfied: setuptools in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from nodeenv>=0.11.1->pre-commit==2.17.0->-r requirements.txt (line 2)) (63.2.0)
Requirement already satisfied: distlib<1,>=0.3.5 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from virtualenv>=20.0.8->pre-commit==2.17.0->-r requirements.txt (line 2)) (0.3.6)
Requirement already satisfied: filelock<4,>=3.4.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from virtualenv>=20.0.8->pre-commit==2.17.0->-r requirements.txt (line 2)) (3.8.0)
cd step2_spritesheet_to_generative_sheet; npm i
The system cannot find the path specified.
make: *** [Makefile:4: first_time_setup] Error 1
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main> make first_time_setup
python3 -m pip install --upgrade Pillow
Requirement already satisfied: Pillow in c:\users\sean\appdata\local\packages\pythonsoftwarefoundation.python.3.10_qbz5n2kfra8p0\localcache\local-packages\python310\site-packages (9.2.0)
pip3 install -r requirements.txt
Requirement already satisfied: Pillow==9.0.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 1)) (9.0.1)
Requirement already satisfied: pre-commit==2.17.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 2)) (2.17.0)
Requirement already satisfied: black==22.3.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 3)) (22.3.0)
Requirement already satisfied: imageio==2.16.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 4)) (2.16.1)
Requirement already satisfied: nodeenv>=0.11.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (1.7.0)
Requirement already satisfied: identify>=1.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (2.5.3)
Requirement already satisfied: toml in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (0.10.2)
Requirement already satisfied: virtualenv>=20.0.8 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (20.16.4)
Requirement already satisfied: pyyaml>=5.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (6.0)
Requirement already satisfied: cfgv>=2.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from pre-commit==2.17.0->-r requirements.txt (line 2)) (3.3.1)
Requirement already satisfied: tomli>=1.1.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (2.0.1)
Requirement already satisfied: platformdirs>=2 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (2.5.2)
Requirement already satisfied: mypy-extensions>=0.4.3 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (0.4.3)
Requirement already satisfied: pathspec>=0.9.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (0.10.1)
Requirement already satisfied: click>=8.0.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from black==22.3.0->-r requirements.txt (line 3)) (8.1.3)
Requirement already satisfied: numpy>=1.20.0 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from imageio==2.16.1->-r requirements.txt (line 4)) (1.23.2)
Requirement already satisfied: colorama in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from click>=8.0.0->black==22.3.0->-r requirements.txt (line 3)) (0.4.5)
Requirement already satisfied: setuptools in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from nodeenv>=0.11.1->pre-commit==2.17.0->-r requirements.txt (line 2)) (63.2.0)
Requirement already satisfied: filelock<4,>=3.4.1 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from virtualenv>=20.0.8->pre-commit==2.17.0->-r requirements.txt (line 2)) (3.8.0)
Requirement already satisfied: distlib<1,>=0.3.5 in c:\users\sean\appdata\local\programs\python\python310\lib\site-packages (from virtualenv>=20.0.8->pre-commit==2.17.0->-r requirements.txt (line 2)) (0.3.6)
cd step2_spritesheet_to_generative_sheet; npm i
The system cannot find the path specified.
make: *** [Makefile:4: first_time_setup] Error 1
PS C:\Users\Sean\Desktop\Generative_Gif_Engine-main>

Are you running the commands in VSCode or through another terminal shell? It looks like it doesn't like cd, I think Windows has separate commands for cd so you might have to update the Makefile and use the corresponding Windows command instead of cd. make just aliases commands to be something else, and the underlying command is failing which makes me think it's a cd issue.

I'm running them the commands in Visual Studio. What is CD? How should I update the make file?

i had a issue running vs code as admin solved it

@Mizvi I tried that and still hade the same problem. Not sure how to update makefile or use cd commands

@trying-my-best so to update Makefile it's a file in the repository, you can ctrl-f find replace cd to use the corresponding command for windows (you may have to google it)

If you keep getting blocked, message me on Twitter https://twitter.com/jalagar_eth and we can maybe arrange something where I can help you generate your collection

Going to close this issue for now feel free to message me on Twitter @trying-my-best

Would I be able to contact you on discord?

I can't really explain it but I don't go on Twitter these days.

Try installing Linux WSL2 for Windows and do it from there.

@trying-my-best @amkyn come join the Hashlips' discord channel https://discord.gg/Wg9SJkYWnD and ask any questions in the animated-art-engine channel!

I'm also a member of the fitness friends discord if that helps any!

Ah yea @trying-my-best we're shutting that down, but join the Hashlip one and I'll help you there. You can post more information and more people will be there to help rather than the Fit Friends one


Model set $escape problem

It's look like if I use more than one SET, I can't use different $escape value.
$this->set('tanggal_transaksi', $data['tanggal_transaksi'], true)->set('balance', 'balance + ' . $data['amount'], FALSE)->where('user_id',$data['user_id'])->update();
generate this query
UPDATE transaksi SET tanggal_transaksi = 2019-04-09, balance = balance + 0.1 WHERE user_id = '12'
In this case I need tanggal transaksi to be escaped, and balance are not esacpe

Can you provide a more complete example please.
What do you expect the outcome to be above?
Where does different $escape values come into play?

I couldn't reproduce it. But I added a test to make sure.

Michal's tests have proven consistent and this appears to have been a misunderstanding, or at least is no longer an issue.


TPU Provisioner reliability improvements

This PR includes the following changes:

Change node pool naming convention to {first 34 chars of jobset name}-{first 5 chars of job-key} ensuring it is stable through JobSet restarts and more easily searchable for debugging.

Track name of JobSet whose pods triggered the creation of a given node pool. In the node pool garbage collection loop, use this information to determine if we should delete a node pool which is an ERROR state with no k8s node objects associated with it, whose JobSet no longer exists.

Upgrade to controller-runtime and other packages to latest versions. This was require to use import JobSet API package. The previous controller-runtime version was pretty old (v0.14.1 v latest v0.18.0) so there were some breaking changes I had to resolve.

Next steps for follow up PRs:

Node object reconciliation should only delete node pool when JobSet whose pods triggered the node pool creation doesn’t exist (or is completed/failed).
Job webhook injecting job-key nodeSelector to ensure 1:1 job to node pool mapping

/gcbrun

LGTM, we could add a check to see if the JobSet is still active or not as well as existent - or wait to add in another PR

Makes sense, I have the jobset utils for checking status etc included as part of the follow up PR for the deletion controller update. I'll include that change in that one.

/gcbrun

/retest

/gcbrun


Support for mobaxterm

I have been using mobaxterm with wsl 2 and it has worked well for me. Any specific reason for not supporting it, any idea how much work that would be. I might try playing with integrating it if I can find the time.

If I remember correctly, mobaxterm is closed source.
Because there are open source alternatives (XWin and VcXsrv), I see no need to include mobaxterm support.
If at all it should be inluded in runx instead of x11docker: https://github.com/mviereck/runx
The effort would probably be not too hard, likely it can be included very similar to VcXsrv.
x11docker uses runx to provide X on MS Windows.

Just reading again, maybe my answer sound a bit rude. Sorry, that's not intended.
Do you see an advantage of mobaxterm compared to the open source X servers?

While its not open source I think it is an interesting & useful alternative to the  open source X servers. mobaxterm does allow for free use, it supports a variety of protocols (see https://mobaxterm.mobatek.net/) it is easy to install and has worked well for me, mobaxterm  has no other dependencies and  supports the GPU. I'm running on windows with WSL-2 & an NVidia card.  Apparently  VcXsrv has some issues with NVidia cards and XWin depends on cygwin which I would rather not install since I already have a real Linux kernel.

I've looked a bit at the mobaxterm website.
Just a thought: mobaxterm provides an X server and a bash terminal. Maybe it already works if you run 'x11docker --hostdisplay x11docker/check`. (Given that you can run docker in the mobaxterm terminal).

I'm running on windows with WSL-2 & an NVidia card.

Could you please have a look at https://github.com/mviereck/x11docker/issues/214#issuecomment-602190534 and try x11docker on WSL2? It is supposed to work, but I cannot test myself.

While its not open source I think it is an interesting & useful alternative to the open source X servers.
XWin depends on cygwin which I would rather not install since I already have a real Linux kernel.

I have the feeling that mobaxterm is nothing but a closed source package/GUI that integrates non-viral open source tools: cygwin, cygwin/X, Putty, etc. Hence, I would say that mobaxterm has the same advantages and disadvantages as cygwin/X. Of cource, this is difficult to prove because mobaxterm is closed source.

Will investigate further and report back, many thanks for looking into this.

It definitely does include cygwin looks like my version of mobaxterm uses version 3.0.4. However as I noted the software is free to use for home use and the professional version is only a $49 one time charge. The environment is nicely done so I would say its reasonable value for money, There are some credits to the underlying packages on the mobaxterm site though they could probably more clearly spelled out.

My main point is that mobaxterm might be considered "a regular cygwin/X installation in some non-default location". If that works, x11docker might support mobaxterm implicitly. I.e., it would not be an officially supported package (because it is closed source), but it could be used with some options/settings.
I do see the value of having an integrated solution, specially for Windows users who are more used to all-included GUI tools. However, I am unsure about that target fitting the intended audience of x11docker users. I would expect the intended audience of x11docker to be familiar with CLI tools and with specific resources such as envvars, xvfb, SSH, permissions, etc. I believe the purpose of x11docker is to provide automation and ease the configuration, but not to hide the complexity of what's happening.
I've been the one who nudged @mviereck to support Windows hosts; and I do help testing MSYS2, WSL and cygwin. Nonetheless, this is still my very personal point of view, not any ab auctoritate.

Although it is likely possible to support mobaxterm, I've decided not to work on it.
As I don't use MS Windows on my own, maintaining MS Windows setups is a lot of additional work. I rather want to focus on other projects.


Rehydration?

Version: 4.2.1
Environment: Server
Type: Feature

Description
A lot changed since version 3.0 where you guys tried to implement rehydration (https://github.com/rofrischmann/fela/issues/71).
At this point, would it be something in the roadmap?

Proposal
Code Example:
renderer.rehydrate() // after client is bootstrapped.

Not sure about this either. I removed it as it was useless in my eyes. I was abusing the ability to rehydrate rather than doing it "right" without. Would love to see your use case for rehydration though.

So, on server side render you create a new renderer, get all the current styles and print them inside a style tag.
But then javascript kicks in on the client side it, creates a new renderer, loads the remaining components that generate some of the same styles plus more styles. At this point the client doesn't have a way to know which styles are already injected from SSR.
When you rehydrate you will need to know which classnames/styles have been injected before somehow.
I was trying to achieve this on Fela but you can't re-generate styles from renderer.cache nor anything else.

Oh I see. You don't need that. On the client, Fela will rerender the styles to add them to the cache again, but won't render anything to the client except it's new. (At least if you call FelaDOM.render the first time after componentDidMount - see the  for reference).
There is no advantage of actually "rehydrating" the CSS-string into the cache. It might be even slower than the shallow rerender (without a DOM update) I guess, because renderRule is really fast.
The previously implemented renderer.rehydrate was actually not "real" rehydration, but kind of reevaluated the rules using new constant props. (Therefore, it was quite a hack and for sure not best practise :P)

But how does Fela do it, when there's two separate Renderer's?
On react, you could just use the provider to get access to the SSR renderer and it's cache I guess

Why would you use two separate renderer? That doesn't make sense. You want to have the same styles on server & client right?

Yes, the styles are the same. But on SSR we only have placeholder components, so we don't render all the styles.
Then on the client we create a new renderer + a stylesheet and append all these styles.
So, without the provider on react, how could you achieve that?

What's the reason for not using the Provider? If you basically do everything different than "our" best practise, why would you even use Fela at all :P (Or do I misunderstand something?)
You could basically use the render in your Root Component's componentDidMount to render the cached styles to the stylesheet for the first time. That would save you many DOM updates while still rendering the components. After the successful mounting, it will use the render subscription for every update as usual.
If your server-rendered markup is identical to the client-rendered (after the initial render) you do not have to update the DOM at all (which the current render already takes care of)

Going to close this here. If you have more questions, please ping me on Gitter or reopen the issue.


 After applying that to my sheet and checking my unarmed strike it remains the same. I also tried to apply "Powerful Fist Feat" to my character sheet and it also doesn't change my hit dices. I'm wondering if this is a bug, feature not added yet, ects...
I've Checked the Rules inside both feats and they state below
{"fist":true,"key":"Strike"}
and
{"key":"DamageDice","override":{"upgrade":true},"selector":["{item|id}-damage"]}
but they don't seem to actually do anything.
Any reply would be nice, thank you

Powerful fist upgrades the fist attack rather than the basic unarmed attack.

Powerful fist upgrades the fist attack rather than the basic unarmed attack.

Oh how do i add the fist attack?

It is available if at least one hand is free.

Oh I found "Fist" in the equipment browser and added it. This allowed me to be able to change the damage dice manually so, all good here now!


Added count param in request, clone header data

Enhancements

src/api/routes.py: Added a count parameter to the get_masq function to allow multiple responses. The function now returns a list of responses if count is greater than 1.

Fixes

src/masquer/utils/response.py: Modified the assignment of response_data to create a new dictionary from HEADER_DATA to avoid unintended side effects.

@essteer  let me know if I should change the branch to merge to.

@essteer let me know if I should change the branch to merge to.

Thanks this looks good - please merge to develop!


Support autocomplete

It would be nice to have support for autocomplete as the user types in the code editor.

i think thats out of the scope of this project


fix(QB-23425): ensure images do not repeat and image caching is used

Removes old image views and ensures that images assigned to the current view is the same image that was downloaded.
Fixes the image caching.
Updates selected state when getting new data for image cells

:tada: This PR is included in version 1.2.24 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Look into websub name configuration

For the new webusb feature the USB device appears as DAPLink CMSIS-DAP.
Need to look into how general board configurations are designed, how WebUSB configurations will be done, and what would we need for the micro:bit board.
If configurations are defined in a yml files we might not have enough control to generate a micro:bit friendly name to distinguish between several micro:bits connected to the same computer.

Needs discussion with the mbed/DAPlink team

Currently the version of WebUSB in master has DAPLink CMSIS-DAP as the board name for all boards.
There is a bug where on first connection it shows LPC1768, this is likely is a bug outside of DAPLink caused by having this VID and PID associated with that board and windows not getting the correct value from the descriptor on first load.

micro:bit name in Chrome is now BBC micro:bit CMSIS-DAP.
Implemented in https://github.com/ARMmbed/DAPLink/pull/488.


Add a MolBundle class

What does this implement/fix? Explain your changes.
This adds a MolBundle: a class to hold groups of molecules that have the topology (currently enforced as the same number of atoms and bonds).
It also adds integration of that class with the substructure searching code.
At the moment this isn't particular interesting, but it lays the groundwork for support of things like enhanced stereochemistry in the not-too-distant future.
Any other comments?
The current implementation is certainly not the most memory efficient way of solving the problem, but the API should allow us to move to something better if that becomes important. The once concern there is the getMols() method, which we may want to consider removing from the API.

@greglandrum Did my comments appear before I requested changes?  These might have been sitting for a while...

no, I'm pretty sure comments don't appear until after the review is submitted


use setuptools-download to download binaries

I keep making these "downloader" packages -- decided to generalize them.  it's a little more complicated for the platforms that shellcheck-py supports -- but not terribly bad in the end

Sorry. I take it back. Just tried it with this branch and still getting the same error:
[WARNING] The 'rev' field of repo 'https://github.com/shellcheck-py/shellcheck-py' appears to be a mutable reference (moving tag / branch).  Mutable references are never updated after first install and are not supported.  See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.  Hint: `pre-commit autoupdate` often fixes this.
[INFO] Initializing environment for https://github.com/shellcheck-py/shellcheck-py.
[INFO] Installing environment for https://github.com/shellcheck-py/shellcheck-py.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /Users/kevinfox/.cache/pre-commit/repozi170g9s
      Preparing metadata (setup.py): started
      Preparing metadata (setup.py): finished with status 'done'
    Building wheels for collected packages: shellcheck-py
      Building wheel for shellcheck-py (setup.py): started
      Building wheel for shellcheck-py (setup.py): finished with status 'error'
      Running setup.py clean for shellcheck-py
    Failed to build shellcheck-py
stderr:
      error: subprocess-exited-with-error

      × python setup.py bdist_wheel did not run successfully.
      │ exit code: 1
      ╰─> [56 lines of output]
          /Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/__init__.py:80: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
          !!

                  ********************************************************************************
                  Requirements should be satisfied by a PEP 517 installer.
                  If you are using pip, you can try `pip install --use-pep517`.
                  ********************************************************************************

          !!
            dist.fetch_build_eggs(dist.setup_requires)
          running bdist_wheel
          running build
          running setuptools_download
          => downloading shellcheck...
          Traceback (most recent call last):
            File "<string>", line 2, in <module>
            File "<pip-setuptools-caller>", line 34, in <module>
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/setup.py", line 23, in <module>
              setup(cmdclass=cmdclass)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/__init__.py", line 103, in setup
              return distutils.core.setup(**attrs)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 185, in setup
              return run_commands(dist)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
              dist.run_commands()
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
              self.run_command(cmd)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/dist.py", line 989, in run_command
              super().run_command(command)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
              cmd_obj.run()
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/wheel/bdist_wheel.py", line 364, in run
              self.run_command("build")
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
              self.distribution.run_command(command)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/dist.py", line 989, in run_command
              super().run_command(command)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
              cmd_obj.run()
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/command/build.py", line 131, in run
              self.run_command(cmd_name)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
              self.distribution.run_command(command)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/dist.py", line 989, in run_command
              super().run_command(command)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/py_env-python3.9/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
              cmd_obj.run()
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/.eggs/setuptools_download-1.0.1-py3.9.egg/setuptools_download.py", line 274, in run
              _download(f, base)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/.eggs/setuptools_download-1.0.1-py3.9.egg/setuptools_download.py", line 220, in _download
              contents = _EXTRACT[f.archive.strategy](contents, f.archive.path)
            File "/Users/kevinfox/.cache/pre-commit/repozi170g9s/.eggs/setuptools_download-1.0.1-py3.9.egg/setuptools_download.py", line 77, in _extract_tar
              with tarfile.open(fileobj=bio) as tarf:
            File "/Users/kevinfox/.pyenv/versions/3.9.9/lib/python3.9/tarfile.py", line 1616, in open
              raise ReadError("file could not be opened successfully")
          tarfile.ReadError: file could not be opened successfully
          [end of output]

your python is poorly compiled. try searching your error message


fixes #785: use adjusted gradient and value in convergence check in FirstOrderMinimizer

I've tried to come up with a suitable test but all my ideas seemed too convoluted for such a small change

thanks!


Negated instanceof operator, !instanceof

Search Terms
instanceof, negated, negate
Suggestion
I've recently started using Kotlin. The Kotlin equivalent of instanceof is is. Checking if an object belongs to a class looks like this:
obj is MyClass

One nice convenience of the is operator is that it can be negated like this:
obj !is MyClass

While I realize this isn't an earth-shattering convenience, it's certainly more elegant than:
!(obj is MyClass)

My suggestion is that TypeScript allow similar negation of instanceof like this:
obj !instanceof MyClass

...which could easily and safely be transpiled to the !(obj instanceof MyClass) form.
Use Cases
The use case is simply to have a more concise and elegant way to negate instanceof.
Examples
(See above)
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x?] This feature would agree with the rest of TypeScript's Design Goals. (I'm not completely sure that this (6) "Align[s] with current and future ECMAScript proposals", having not read every such proposal, and while I don't think this proposed infix operator would (8) "[add] expression-level syntax", at least any more than recent additions like ??, I'm not absolutely certain.

This is a runtime feature.

at least any more than recent additions like ??

That feature was developed through the TC39 committee, not from TypeScript

?? may not have originated with TypeScript, but TypeScript now supports the null coalescing operator via transpiling for older versions of JavaScript which don't natively support it -- and doing that does not require runtime support, nor would my proposal require runtime support.

The point is that, like ??, !instanceof should be originated with TC39, not TypeScript.
You can click through to that label and see dozens of suggestions for other downlevelable runtime syntax. We're quite consistent on this.


integrations: Add Linear webhook integration.

This PR adds Linear Integration.
Right now, it supports events related to:

Issues
Sub-Issues
Issue Comments

It does not supports events related to:

Issue Labels
Projects
Project Updates
Cycles
Comment Reactions

These will be added soon.
Testing Plan: Manual Testing
Fixes part of #23118

Some Screenshots:

Issue Created

Sub-Issue Created

Sub-Issue Updated

Commented

Self-review checklist

[X] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[] Highlights technical choices and bugs encountered.
[] Calls out remaining decisions and concerns.
[X] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[X] Each commit is a coherent idea.
[X] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[X] Visual appearance of the changes.
[X] Responsiveness and internationalization.
[X] Strings and tooltips.
[X] End-to-end functionality of buttons, interactions and flows.
[X] Corner cases, error conditions, and easily imagined bugs.

Thanks for reviewing my work. :heart:
I looked into the mentioned integrations and checked if there was some code that could be re-used. There were some events regarding comments on issues that looked similar to the one used in this integration.
The function get_issue_event_message in zerver/lib/webhooks/git could have been useful but the fact that it required the URL of the issue as an argument (which is not present in the fixture) made it an unviable option.
I have corrected the class name in the webhook tests. Let me know if there is anything else to be done here.

I changed the commit message from Fixes # to Fixes part of # because there are still additional event types that need to be supported by the integration.

@PIG208 Could you please review this one as well?

@sbansal1999 Please add screenshots of any documentation changes to the PR description.

@alya Thanks for the suggestion. ❤
I have added the screenshot of the Integration's documentation to the PR Description. Let me know if there is anything more to be done.

@adambirds @PIG208 do either of you have time to review this one?

I left some comments. The commit message also needs some tweaking to be ended with Fixes #23118. Other than those comments, I think it is all good.

Thanks for reviewing my work. :heart_decoration: I will make the suggested changes and update the PR shortly.
Regarding the commit message, the integration does not currently support all events. Therefore, I wrote the partial fix in the commit message.

@PIG208 I have made the requested changes and have updated the PR. Let me know if there is anything more required in this one!

Also regarding the use of topic instead of subject in various other integrations. I think that can be done and tracked down in a follow-up issue.

Right, it would be great to have a follow-up PR for that.

Thanks for updating! @sbansal1999
I did some manual testing, and this integration has been working fine for me.
We can be more consistent with the formatting of issues. The payload does not contain the link to a removed issue, so the design decision was to display the issue name in bold. We should also do that for the issue name when it appears in other events when there isn't a link to it for consistency:

Then I think it will be a checkpoint to merge the changes.
There are some other things that we can improve on later on in a follow-up:

The webhook includes the entire body of the issue, which can be noisy when the body is long. Perhaps we can truncate the body to a reasonable limit.
While issue label-related events aren't supported, issue updates triggered by changes to the labels still result in a message sent by the webhook.

@PIG208 Thanks again for reviewing my work. :heart: I have made the issue title appear in bold for Comment Create and Update Events. Please let me know if there are any changes required in this one.

Regarding the truncation of the body of the issue, I think Zulip automatically displays a [More…] button when the message is too long. Therefore, I am not sure if this is even necessary. If required we can do that in a follow-up PR as you mentioned.

Regarding the comment on the issue labels being updated in an issue, I believe the message being sent makes sense because the change is itself to the issue only.

@zulipbot add "integration review"

@zulipbot add "integration review"

Merged, thanks @sbansal1999!

I know it's a bit late but opened #25974 to track the progress of replacing subject with topic for various integrations.


Unable to load migrations file

Hi,
in latest release is unable load migration files by migrations:migrate command. Doctrine\Migrations didn't trigger Console event so your RegisterMigrationsEventSubscriber didn't register migration files into configuration class.

Hey, thanks for reporting.
This should be solved via: https://github.com/Zenify/DoctrineMigrations/issues/21#issuecomment-151659145

Ping, is this issue still on?

Hi, sorry for late response.
No, it's fixed.

Great! Thank you


Bigtable admin: deprecate typesafe names part 2

This is a followup on #4257:
Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative

The test failures are unrelated spanner tests

test failures are due to unrelated logging tests failing


Update Meta “tags”

Automatically generated by Netlify CMS

👷 Deploy Preview for nsharmaxyzblog processing.
🔨 Explore the source changes: e4e6e4f4246a007a865dae0910786c967bda7aec
🔍 Inspect the deploy log: https://app.netlify.com/sites/nsharmaxyzblog/deploys/61b5bac88f31a30007ed2962


Revert "CI/CD: drop unnecessary soft link about sgx_attributes.h in"

This reverts commit 0843dd4864c250c30afef998673a39fa45356315.

The test result  is showd in #663 , so it need to wait all CI/CD in #663 successfully passing.


Dynamic Min/Max TemplateOptions

I created the following SO question: http://stackoverflow.com/questions/32827607/updating-the-min-max-templateoptions
@ckniffen suggested that this is a future enhancement as the template manipulator cannot set dynamic values to min/max.

Answered here. The GitHub issues in this project are reserved for reporting bugs and feature requests. In the future, please follow the instructions here to get help: http://help.angular-formly.com

My bad man.  I literally thought that this was an issue.  Thanks for the example!

You're good. You thought it was a feature request. No harm done :-) Good luck!

FYI...you are a wizard.  Just putting that out there.

Awe, you're making me :blush: Thanks!

One last question...I modifed your example to pass hard coded data: http://jsbin.com/juqihizefo/edit?js,output
This works totally fine on the jsbin but locally, only your way works (checking the formState.changed).  If I set 'templateOptions.min': 'formState.min' then to.min is ALWAYS blank.
I feel like I am missing something obvious.  I can't recreate this issue on jsbin because it works there but not local.  :(

Hmmm... Yeah, if it's only happening locally I'm afraid there's not much I can do to help you :-(


Pluggability - Language (Python, Go, Rust..)

In order to support different developers, we must be able to provide language SDK such as Python, go, scala, etc.. this way the same solution can cover any language as per the developer's needs.
However, we can define a few popular languages as a priority and get to fix the pluggability issues in the current architecture.
If we do this and become popular we can go to respective language forums and request for Opensource contributors of that language to build the missing one for that language.. - may be the necessary templates in that language, while the generator language is still java as the core.

This has the advantage of becoming a solo framework that supports any language as most in this space support a particular language only


2.0 release loses all coins because of fork.

Please hold back and rollback current changes until issue is resolved.
Using the 2.0 release of the wallet will bring you on another chain from April 20, so you can potentially lose all coins!
There should be a big WARNING at the very least! Otherwise people will get screwed.

There is a simple fix to this issue; update the wallets. If everyone would do that already, this wouldn't have been an issue.

There is a very clear warning in the release notes.

@PaycoinMaster can we close this?


Continuous update a point cloud map from a flying drone

Hi
My question in #50 is well solved. Thanks for your advice.
I realized the package currently draws a static point cloud map for one time. But in my case, I need to draw a point cloud map continuously. The point clouds are updating in real-time. Does this package has the function?
Besides, I noticed the package used Graphics.DrawProcedural to draw each geometry. I'm not sure is it gonna affect the rendering performances if I draw up to 50,000 point clouds at 1Hz.
The device I'm using is HoloLens1.
Thanks
Glen

Does this package has the function?

No. Pcx is just an importer for .ply files. Real-time point cloud is out of the scope.
I think Rsvfx is a better example that is closer to your idea.
https://github.com/keijiro/Rsvfx
https://twitter.com/_kzr/status/1133300004674609153

I'm closing this issue now. Please feel free to reopen it for further problems.

Does this package has the function?

No. Pcx is just an importer for .ply files. Real-time point cloud is out of the scope.
I think Rsvfx is a better example that is closer to your idea.
https://github.com/keijiro/Rsvfx
https://twitter.com/_kzr/status/1133300004674609153

will try with Rsvfx. Thanks!


Bug can allow root console login without password

A regexp error can allow root logins at the console without password in certain cases.  Fixed by https://github.com/MindPointGroup/RHEL6-STIG/pull/127

Thanks for these fixes!
Fixed in #127


Adds warning component name and project change

What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Adds a warning message while component name or project name of the component name is changed in the config
Which issue(s) this PR fixes:
Fixes #2172
How to test changes / Special notes to the reviewer:

Create a component
Change the component name or project name in the config odo config set name <value> or odo config set project <value>
Check if the warning message is displayed properly or not

{"component":"entrypoint","file":"prow/entrypoint/run.go:242","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process gracefully exited before 15s grace period","time":"2019-12-12T14:29:16Z"}

/retest

wouldn't there be a duplicate component when someone changes the application name too @mik-dass ?

wouldn't there be a duplicate component when someone changes the application name too @mik-dass ?

Yeah you're right. Updated with the changes.

/approve

There's no warning printed when one chooses to force the change with -f, i.e., odo config set name myname -f. Do we assume that when user forces something, (s)he is aware of what they are doing and hence we don't warn them?

@dharmit I remember hearing in a meeting that the warning message should only be displayed if the action is not forced.

/lgtm

/lgtm cancel

/lgtm cancel

witing for @dharmit as his review has still status "Changes requested"

@dharmit I remember hearing in a meeting that the warning message should only be displayed if the action is not forced.

:+1: Makes sense. Thanks for the info. :smile:
@kadel I'm good with the changes but this PR got merged despite of "Changes requested". Is this a bug? :wink:

@kadel I'm good with the changes but this PR got merged despite of "Changes requested". Is this a bug? 😉

it is a feature :-), merge-bot is just concerned about labels (approve and lgtm), it doesn't check github reviews :-(  It looks like openshift-bot noticed label before I managed to remove it :-(


inserts not working

Perhaps I'm misunderstanding the functionality of this package... I'm trying to test a method that writes to a MongoDB instance...
res = container_activity_col.insert_one(_buckets[0])
logger.info(res.inserted_id)

containers_preload = list(container_activity_col.find(query))
assert len(containers_preload) == 1

logger.debug(load_containers_whs)

await load_containers_whs(whs_code=whs_code)

containers_postload = list(container_activity_col.find(query))
assert len(containers_postload) == len(_buckets) + len(_pallets)

but the inserts are not "persisted", hence I get assertion errors because the length of the retrieved data is 0.
Is this a supported use-case? if not, is there any alternative to make a test in this manner?
thanks!

Ok, I just solved the issue... it was all my fault :(
I was consuming iterators in the logging methods, and I was also doing the query with the wrong arguments. It all now works properly!

Ok, I just solved the issue... it was all my fault :(
I was consuming iterators in the logging methods, and I was also doing the query with the wrong arguments. It all now works properly!


@Module annotation retention

More thoughts following #56...
Currently the retention for the @Module annotation has been set to SOURCE, meaning that it will be discarded by the compiler. This allows us to leave the annotation in the macros artifact, but on the other hand makes it impossible, as a library author, to provide annotated modules.
A possible middle ground would be to have 2 annotations, one with SOURCE retention (living in the macros artifact) another with CLASS retention (living in the utils artifact, under a different package). That way, library authors can pick the later if they need to (bringing an extra dependency along the way), whereas application developers can be fine with the SOURCE retention.
http://docs.oracle.com/javase/7/docs/api/java/lang/annotation/RetentionPolicy.html

I still think @Module might be confusing, let alone if there are two annotations. Let's keep SOURCE for now, and if there's a need to have the annotation retained in the future, we can always move it to util. Right now there's no use for @Module other than at compile time of the sources (the annotation isn't useful in libraries anyway).


provide full type info when calling _aaGetX

This needs https://github.com/D-Programming-Language/druntime/pull/1037 to be merged first.
Precise scanning needs the full type info when creating Impl and other objects used by the AA implementation. This replaces the key type info with the AA typeinfo that contains both value and key type info.
It is calling _aaGetY instead of _aaGetX to allow the druntime PR to pass.

Auto-merge toggled on

Introduced a regression: https://issues.dlang.org/show_bug.cgi?id=14038

Apparently this introduced another regression in Higgs.

Apparently this introduced another regression in Higgs.

Issue 14104 – aa with pointer key type doesn't find existing value

see #1150


ConfigurationOption acceptsType losing information somewhere

For context, I am adding an accepted type, which is BlockState.
To verify this has been added, I call..
        if(!configurationOptions.acceptsType(BlockTypes.AIR.getDefaultState().getClass()))
            throw new RuntimeException();

This runs fine with no error.
After calling this however,
config = configManager.load(CraftBookPlugin.<CraftBookPlugin>inst().configurationOptions);

if(!config.getNode("anything").getOptions().acceptsType(BlockTypes.AIR.getDefaultState().getClass()))
            throw new RuntimeException();

This will now throw the exception.

Ok, so looked into this. Configuration loaders set the types they accept because the accepted types are controlled by the loader. Hocon only has a certain set of supported types, which you cannot change.
If you're registering a TypeSerializer, you have to use the TypeToken-parametered method to setValue -- changing acceptedTypes doesn't affect how serialization works at the Configurate level.