Adding interrupted status

Added the interrupted status which is documented here - https://playwright.dev/docs/api/class-reporter#reporter-on-end
Introduced in 1.25.0 https://github.com/microsoft/playwright/releases/tag/v1.25.0

@artemrudenko merged my PR #13 (thank you! 🚀 ), which had some conflicting changes
If you need help rebasing this branch, ping me 😇

@artemrudenko merged my PR #13 (thank you! 🚀 ), which had some conflicting changes If you need help rebasing this branch, ping me 😇

Hi @ranma42, i have updated dependencies and performed small code refactoring, so it looks like now we have more conflicts.
If you want i can simply copy and add your interrupted related code only and publish new version, or you can try to rebase your changes without adding package-lock and package.json changes.
It's up to you.
Best Regards,
Artem

Added by https://github.com/artemrudenko/playwright-teamcity-reporter/pull/17


Job Scheduling Algorithms

Job Scheduling Algorithms in C++,Python,C,Java
Job Schedulings Algorithms FCFS,SJF,Robin Round
Solution Description
A Clear implementation of FCFS,SJF,Robin Round Algorithms in all the languauges
Please assign issue to me I Promise you that I will accomplish my task in a perfect way and I haven't started my Contribution in SSOC yet.

Hey, I am SSOC'23 contributor and would like to contribute to this issue. Please assign this issue to me!!

These algo's issues are already open


Not compatible with flexbox

Slick currently cannot handle div's that are laid out using flexbox.
Here is an example:
http://codepen.io/gloparco/details/KhDsG

I'm also seeing this issue with Chrome 44. What css did you add to the container @gloparco?


🧹 chore: updating gitignore file

Totally didn't even notice that the .figma2themerc was already committed lol, I've removed that change. But yeah you're right on, the other change was for tokens.css 👍🏻


feat(lang): Support RStudio server as the editor for R language

Description
https://www.rstudio.com/products/rstudio/download-server/
RStudio also supports remote development with the help of RStudio server.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

/assign

Thanks for taking this up!

Cannot find how to install rstudio in arm64. Maybe we can support amd64 first.

The rstudio config is complex. We need to

Configure database user permission
Configure auth
Configure server user permission

Not sure if it can be resolved tomorrow.


[Feature Request] Monitoring Option

Not a real problem, but it would be nice if the bot had a minimal web interface.
That way you could simply check the status of the bot with e.g. uptimerobot.
If the bot is offline, the website also goes off.
You don't have to be able to do much, a simple html page that the bot is running would be perfectly sufficient.

How meaningful would that be?
If you just want to check if the Bot is up you just need to look at it's Bot Users status, no?
If the bot is not running, the user won't be online.
If you want something that monitors the bot from the outside and also can do alerting if it goes down you might want to look into monitoring solutions like Icinga, Nagios, CheckMK...

The easiest way would be to just look at the bot's status in Discord, as already stated. Also, there are numerous concerns/difficulties with hosting a web page (port forwarding, public-facing IP addresses, etc) that are frankly beyond the scope of this project.


Question about SOQL query in QuickOpportunityWizardController

Just wondering why this class has a SOQL query in it instead of creating a selector for OpportunityLineItems? Are there certain situations where a selector class should not be used? Since the query retrieves values from PricebookEntry, seems like it could be a good example for showing how to use relationship queries in a selector class.

The sample code here is 11 years old so it's hard to know the "why" -- but there is a code comment above that controller action method that says  This controller is not using the pattern approach in this code sample version. See the other two controllers  in this sample for an illustration of how the patterns are used
So it seems like Andy acknowledged up front that the sample code is not a good example of adopting the Apex Enterprise Patterns.


Nextauth ms2

Summary
Used nextauth for auth in ms2 and implemented a middleware in the old ms that reads the nextauth cookies to authenticate requests.
Details MS2

removed useAuthStore, auth status can be checked with useSession provided by nextauth
new abilityStore
MS2 fetches the ability from the old ms after login
Auth guard runs in the server with getServerSession
Adapted all page.tsx files to be rendered in the server

Details Old MS

stop using loginSession if API_ONLY = true
implemented getSessionFromCookie to read cookies set by nextauth and fill the req.session field when API_ONLY = true
don't validate request's csrfToken if API_ONLY = true

In my recent commits, I mainly made the following changes:

MS2 now uses the environments repo (if it exists) for auth0 credential
MS(old) and MS2 share the NextAuth secret through the environments repo, if it is not set in development, a default value is used
Used csrf token for MS(old)


WiFi setup should use HTTPS and/or serial mode, not via plaintext credentials transmitted in the clear

The WiFi setup for the ESP8266 should either be over a secure connection (HTTPS or WPA2) or configurable via serial (for example, via a sketch - a common method for this device).
Currently, private credentials are transmitted completely in the clear over the insecure AP network WiFiLink uses for setup, rendering them vulnerable to interception.

there is a bigger security problem :-). http:///config.json

For whoever triages this, the results of http://192.168.xx.yy/config.json are {"ssid":"your_ssid_name","password":"your_formerly_secret_password"} (with the actual data).
That's pretty bad.


⚠ Ixtanet SAT has degraded performance

In 1020609, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20670 ms

Resolved: Ixtanet SAT performance has improved in cdca734.


Disable default suggestions for Symbols

Blocked by https://github.com/Microsoft/vscode/issues/16040.

We should remove suggestions for variables inside current document, because this functions now have default provider.

Closed for #34


The type initializer for 'Renci.SshNet.Security.Chaos.NaCl.Internal.Ed25519Ref10.LookupTables' threw an exception.

Hello
We have been using the command New-SFTPSession with a try-catch which catches the exception and writes a warning message, this is run as part of an automation which runs on a schedule, it appears to be failing with the error every few days
[WARNING]	The type initializer for 'Renci.SshNet.Security.Chaos.NaCl.Internal.Ed25519Ref10.LookupTables' threw an exception.
It's not a big deal since it retries later but we wondered if you could supply additional information on what might cause this?
Unfortunately its not an easy to replicate issue so at this stage I don't have any further information on it.

That is an error that I had not seen before. What is the target for the connection, host key algorithms and configured ciphers?

The only other information I could get is that the Fingerprint matched trusted ssh-ed25519
I dont have any information on the target unfortunately, this is how it is called though, building a secure string previously and calling New-Object with System.Management.Automation.PSCredential
$session = New-SFTPSession -Computername 'external.host.example.com' -Credential $cred -AcceptKey:$true -ErrorAction Stop -Verbose


Fix raster geometry updates

Handle the case where the raster bucket changes the geometry after a drawable is created from it.
Allow index vector to be empty if there's a buffer Skip drawable create in some cases where there's no data to draw. Reset buffers as well as values when clearing index/vertex containers.  Add more validation. Fixed a bug in layer tweaker update that prevented it from working.

In legacy code the missing indexes on raster bucket signals to use the raster quad (staticDataVertices, staticDataIndices & staticDataSegments), so a drawable without indexes shouldn't be created in any case.
This condition can vary back & forth during the program execution, the bucket generates buffers only when it decides to clip visible tiles, otherwise leaves them empty so the standard quad is used. Legacy code here.

The problem is that a drawable is created with masked vertices in the shared data, but the bucket later changes that, or clears the shared vertices.  The segments aren't shared, though, so that won't work.  Or the drawable is set up with the static vertices and the bucket later updates to masked shared vertices which has no effect on the drawable at all.
I considered emplacing the static values into the shared buffers and updating the segments instead, but changing the geometry in a drawable will lead to problems later on.
As an improvement, we should find a way to transfer the textures over, but that's not easy any more.

Turns out the buffers can't be reset when VertexVector/IndexVector is cleared, or it breaks OpenGL.  I believe this indicates a potential bug, in that SymbolBucket is changing the values dynamically (updateBucketOpacities), but the resulting dirty vectors are not being re-applied in the GL implementation.  I'll create an issue so it doesn't get lost.


New Versions of Android SDK and NodeJS

Hi,
Thanks for the Excellent Script and very informative video. Just to mentions, you might want to update the download links to the latest version of both Android SDK and NodeJS
Thanks.
Really appreciate you taking your time and give this script out to everyone.

Updating the links is on my agenda.  Thanks for the reminder :-)

Updated.
Thanks!


Detection method

Which source files are Nearest  neighbor and Linear classification written in?

Which source files are Nearest neighbor and Linear classification written in?

Which source files are Nearest neighbor and Linear classification written in?


init_tinymce.js not coming over CDN

I'm trying to configure tinymce's css and js files to come through the CDN, but no matter what I do, the "init_tinymce.js" file does not come through the CDN. Could it be a bug?
settings.py;
TINYMCE_JS_URL = "https://cdnjs.cloudflare.com/ajax/libs/tinymce/7.0.0/tinymce.min.js"
TINYMCE_COMPRESSOR = False

TINYMCE_DEFAULT_CONFIG = {
    'theme': 'silver',  # Magic here
}

Proof;

init_tinymce.js is not a file from TinyMCE, it is specific to this package, so it cannot come from a CDN (unless your project static files are on a CDN).


nixos/nscd: add option to use nsncd, init nsncd

Description of changes
This provides a services.nscd.enableNsncd, which will use nsncd instead of nscd to provide NSS lookups.
We use nix-community/nsncd due to https://github.com/twosigma/nsncd/discussions/44:

We'd definitely like to collaborate with you and work to incorporate your changes in our project. But this is not the main day-to-day job for any of us, so if we're too slow to respond feel free to keep experimenting in your forks and we'll try to keep up with your pace.

The nscd test has been included, to ensure it works the way it's supposed to.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Very nice. Now that we have this, what about disabling caching by default?
I think the issues caused by cached DNS queries are surprising enough that running nscd should be a conscious decision.

Flipping the default is something I'd like to do for the next release (after 22.11), but it needs some more changelog and documentation. See https://github.com/NixOS/nixpkgs/pull/197986.


Insecure random number generators in RandomGenerator should require explicit enabling

Ideally we can add a Config variable, that defaults to false, that prevents the use of the last two random number generators (Capicom for Windows and mt_rand()) unless the config var is changed to true, so it is opt-in to produce non-psuedo-random numbers.
Probably a v4 change given it would change the output of the method (might throw an Exception where none was thrown before).
Reference: https://github.com/silverstripe/silverstripe-framework/blob/d38097ec146d5509fb397d930f069a313093ac13/src/Security/RandomGenerator.php#L56

Are there any tangible risks to how it is at the moment?

The method comment states      * Note: Returned values are not guaranteed to be crypto-safe,. This method should not be used in any place where it could potentially raise a security risk at all.
I would rather see this left in place, and we implemented a proper crypto-safe random number generator instead. php 5.5 (supported in 4.0) has better crypto-random generation. e.g. http://php.net/manual/en/function.hash-pbkdf2.php

Sort of related - Function mcrypt_create_iv() is deprecated in framework/src/Security/RandomGenerator.php:30 during a module's Travis build on PHP 7.1. If we want to support 7.1 for SS 4 we'll probably need to replace it.

Regarding dropping the deprecated (in 7.1) mcrypt library use, here is the RFC that drops it (for reference). It seems that the suitable replacement would be openssl_random_pseudo_bytes' which is already implemented in this method, just a lower priority than mcrypt_create_iv`.
I propose we simply remove the mcrypt use, leave the rest and give a higher priority for Windows to the method that @tractorcow shared over the existing code. Personally, I don't see any reason why we shouldn't remove old Windows code now (4.x) in favour of more modern, cross platform methods.

@robbieaverill from a quick look that commit looks good - but is there a thirdparty library we can use that does the same thing?

https://github.com/ircmaxell/RandomLib this looks good, well maintained and regularly contributed to

@dhensby yeah cool. As long as we are ok with replacing the functionality with a new backend essentially then I'll have a play with that instead

Damn - @dhensby - looks like that module isn't 7.1 compatible yet (ref: ircmaxell/RandomLib#55). It's definitely worth implementing though.

hmmm - it's not so much it doesn't work, just that it's relying on deprecated libs - that's a shame, but maybe not a show stopper?

I've removed my suggestion because it wasn't a correct secure random number generator.
PHP 7 has random_bytes, but of course we can't rely on this.
However, with combination of mcrypt_* being deprecated in php 7.1 onwards, and random_bytes being available from 7.0 onwards, we have at least a complete surface area that doesn't require us to add any new dependencies. :)
Note that random_bytes is documented as being cryptographically secure.

@tractorcow How about random_bytes() + https://github.com/paragonie/random_compat?

This part concerns me a little:
If PHP cannot safely generate random data, this library will throw an Exception. It will never fall back to insecure random data. If this keeps happening, upgrade to a newer version of PHP immediately.

Can we ensure that we NEVER get an exception thrown with only the bare minimum of server dependencies installed? Otherwise we either need to bump our requirements or look for an alternative.

IMO the best solution is to remove the RandomGenerator class entirely, and simply error on systems that don’t support random_bytes() or the polyfill. For the polyfill, the randomness sources are well documented so we could update our server requirements if we really want to. It doesn’t do anything drastically different to our currently implementation though (besides the removal of openssl_random_pseudo_bytes(), and not falling back to mt_rand() - both of which are good things).
In the case of PHP 7, I’d like to think that it’s safe to assume that if it ships with PHP, it’ll be very well supported - but I can’t find anything to back that up! For reference, this is what the native function currently checks: https://github.com/php/php-src/blob/c8aa6f3a9a3d2c114d0c5e0c9fdd0a465dbb54a5/ext/standard/random.c#L84-L184.

Yeah but I think we need to do better for our users than "you'll get an error if you aren't configured properly." What they'll need to know is what to do to ensure that doesn't happen at all. Otherwise they could end up with errors in a live environment they didn't expect. I'd factor what that is before choosing to adopt this library.
PHP 7 should be fine, I'm mostly concerned about 5.x

So to summarise, the requirements/order sources are checked are:

Current RandomGenerator class:

mcrypt_create_iv()
openssl_random_pseudo_bytes()
/dev/urandom  (Linux / BSD only)
CAPICOM.Utilities.1 (Windows only)
mt_rand()

Polyfilled random_bytes():

libsodium
/dev/urandom (Linux / BSD only)
mcrypt_create_iv() (which on Windows will try to read from CryptGenRandom)
CAPICOM.Utilities.1 (Windows only)
Exception thrown. There are some terse troubleshooting docs.

PHP 7 random_bytes():

CryptGenRandom (Windows only)
arc4random_buf (OpenBSD/NetBSD only)
getrandom(2) (Linux only)
/dev/urandom
Exceptions are thrown at different points (e.g. if getrandom(2) is available but fails, it will throw an exception immediately rather than fall back to /dev/urandom)

Would that info in the server requirements doc suffice? We could even catch the exceptions that random_bytes() throws and provide our own message to point people in the right direction.

@kinglozzer worth noting that my recent PR adds priority for random bytes before mcrypt

@kinglozzer I think that's fine. ;)

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/6940#pullrequestreview-39367377


[chip-test/sival] Check ENTROPY_SRC_POSTHT_ENTROPY_DROP_ALERT_BIT

When running in Firmware Override: Observe mode, this bit should be checked. If it's asserted, this means that health tested entropy bits have been dropped before the postht FIFO due to conditioner back pressure. This means entropy observed via observe FIFO may be non-contiguous.
This is related to lowRISC/OpenTitan#21855.

As far as I can see, the CI check that just failed is an IT issue (so presumably not caused by the change in the PR)

The failing TLT is chip_sw_csrng_kat_test  but the failure is due to an infrastructure issue:
* `Job returned non-zero exit code` has 1 failures:
    * Test chip_sw_csrng_kat_test has 1 failures.
        * 0.chip_sw_csrng_kat_test.1\
         Log /azp/agent/_work/1/s/scratch/HEAD/chip_earlgrey_asic-sim-xcelium/0.chip_sw_csrng_kat_test/latest/run.log

                			done; \
                		fi; \
                	fi; \
                done;
                Building SW image "//sw/device/tests:csrng_kat_test_sim_dv".
                Building "//sw/device/tests:csrng_kat_test_sim_dv" on network connected machine.
                Building with command: ./bazelisk.sh build  --define DISABLE_VERILATOR_BUILD=true --//hw/ip/otp_ctrl/data:img_seed=1 //sw/device/tests:csrng_kat_test_sim_dv
                Opening zip "/root/.cache/bazelisk/downloads/bazelbuild/bazel-6.2.1-linux-x86_64/bin/bazel (deleted)": open(): No such file or directory
                FATAL: Failed to open '/root/.cache/bazelisk/downloads/bazelbuild/bazel-6.2.1-linux-x86_64/bin/bazel (deleted)' as a zip file: (error: 2): No such file or directory
                make: *** [/azp/agent/_work/1/s/hw/dv/tools/dvsim/sim.mk:73: sw_build] Error 36

I just ran 10 seeds of this TLT locally and they all pass. I am thus merging this. Thanks for your reviews everybody!


incorrect deployment manifest should give no such file instead of the required argument PATH was not provided

When bosh CLI is passed a deployment manifest that is either non-existent or unreadable, it returns a misleading
the required argument `PATH` was not provided

message; instead, it should return either filename: No such file or directory or filename: Permission denied.
# non-existent
bosh --version
version 0.0.59-35caccf-2016-09-08T21:29:07Z
bosh deploy -d nginx-ntp-pdns no-such-file-or-directory
the required argument `PATH` was not provided

Exit code 1
# unreadable
bosh deploy -d nginx-ntp-pdns /etc/ssh/ssh_host_key
the required argument `PATH` was not provided

Exit code 1

Need to bump go-flags to include: https://github.com/jessevdk/go-flags/issues/188

Fixed in https://github.com/cloudfoundry/bosh-cli/commit/5742c6cb07eebaeed338836f8eee972769ddad7f.

Nice!

Same with bosh2.
bosh2 --version
version 2.0.23-a5bb0df-2017-05-31T21:21:01Z
bosh2 -e kubosh -d pcf/rbc-manifests/logsearch/logsearch-dev.yml deploy
the required argument PATH was not provided


AVL tree doesn't balance upon removal

noted here - https://github.com/mgechev/javascript-algorithms/pull/49

PR pending - https://github.com/mgechev/javascript-algorithms/pull/51

PR merged - https://github.com/mgechev/javascript-algorithms/pull/51


Dihydroorotate Dehydrogenase

DHODH (ENSG00000102967) catalyzes MAR04575: (S)-dihydroorotate [c] + ubiquinone [m] ⇔ orotate [c] + ubiquinol [m]
While DHODH is capable of oxidizing dihydroorotate to orotate and reducing ubiquinone to ubiquinol, it uses FMN (MAM01828c/e) as an intermediate electron carrier in between those two substrates (source). Most reactions that are catalyzed by similar enzymes that use FAD in the same way, speifically those catalyzed by some combination of ACADVL, ACADL, ACADM, ACADS, and ACADSB (that's over 100 reactions in total, so I'm not listing them out here) do not directly involve ubiquinone (MAM03103m), but instead oxidize/reduce FAD(H2) (MAM01802m/MAM01803m), which oxdizes/reduces ubiquinone/ubiquinol in MAR06911. To be consistent with the representation of the existing reactions catalyzed by FAD-dependent enzymes where the electrons eventually wind up reducing ubiquinone:

[ ] Create a new metabolite to represent FMNH2
[ ] Replace MAM03103m (ubiquinone) with MAM01828c (FMN) and MAM03102m (ubiquinol) with the new FMNH2 metabolite in MAR04575
[ ] Create a new reaction to represent redox of FMN(H2) and ubiquinone/ubiquinol catalyzed by DHODH: new_fmnh2_met + MAM03103m <-> MAM01828c + MAM03102m, GPR: ENSG00000102967

Technically, the redox between FMN(H2) and ubiquinone/ubiquinol happens at the outer face of the inner mitochondrial membrane, but there isn't currently a mitochondrial FMN metabolite, and it seems like overkill to add mitochondrial versions of both FMN and FMNH2 as well as cytosol <-> mitochondria transport reactions for both.
There are some other FMN-dependent enzymes associated with reactions in Human1 that do not currently involve the FMN metabolite (e.g. PNPO, see Table 1 of this paper) that could probably have similar edits made to them, but I came across this issue when specifically looking into enzymes that use FAD to reduce ubiquinone, so I haven't looked into exactly what changes would need to be made to those reactions (yet).

Seems like a reasonable suggestion, since as you say many FAD-binding enzymes are already represented this way in the model. My concerns are that by separating the reaction steps, it becomes a bit less clear what the overall reaction is because one needs to be aware of both steps. Also, if there are other reactions that can reduce/oxidize FMN, it opens the possibility to use those as the second step instead of coupling to ubiquinone/ubiquinol (I know there aren't any now because it's a new metabolite, but if some are added in the future).
For the new reaction step involving electron transfer between FMNH2 and ubiquinone, would the GPR of that reaction include all FMN-dependent enzymes?

My concerns are that by separating the reaction steps, it becomes a bit less clear what the overall reaction is because one needs to be aware of both steps. Also, if there are other reactions that can reduce/oxidize FMN, it opens the possibility to use those as the second step instead of coupling to ubiquinone/ubiquinol (I know there aren't any now because it's a new metabolite, but if some are added in the future).

So while I agree that it does make the overall reaction less clear, that may actually (unfortunately) be a more accurate representation of reality, since no FMN-dependent flavoenzymes in humans bind their FMN covalently (a few of the FAD-dependent ones do, but the vast majority don't) source, and at least one human enzyme that had long been thought to depend on FAD and/or FMN bound to a different enzyme was shown to preferentially use free FAD and/or FMN to catalyze its redox reaction source

For the new reaction step involving electron transfer between FMNH2 and ubiquinone, would the GPR of that reaction include all FMN-dependent enzymes?

As far as I can tell, it would only contain DHODH, because that seems to be the only human FMN-dependent enzyme that is known to be capable of directly transferring electrons between its FMN and ubiquinone

Sounds great, thanks for the detailed answers @Devlin-Moyer!

I was just about to start working on this when I noticed that there are already two metabolites in Human-GEM called "FMNH2": MAM20019r and MAM20022i. While I'd still need to add cytosolic and mitochondrial FMNH2 metabolites for this issue, I get the impression that all compartment-specific versions of the "same" metabolite are supposed to have identical numeric bits of their IDs and only differ in their final characters that specify the compartments. Should I also change the ID of MAM20022i to MAM20019i for consistency with MAM20019r as part of the pull request for this issue (and then make the new FMNH2 metabolites for this issue be MAM20019c/m), or should I make that a separate issue?
(I verified that none of the proposed changes in #610, #617, #618, #620, #621, or #622 would address this specific pair of metabolites)

ope nevermind #626 and #627 both also mention MAM20019r and MAM20022i being duplicates; should I wait for those to be resolved before making a pull request to implement the proposed changes here?

fixed in #713


Updated README 📖

Documents issue #205

Don't know anything about the issue, but the readme text lgtm - i think @kulshekhar should merge this in.

@screendriver I've updated the authors file with your name/email. Let me know if this is fine.

@screendriver I've updated the authors file with your name/email. Let me know if this is fine.

Awesome! 😎 Thank you 👍


Use containerd event exchange

For plugin mode, we should use containerd event exchange https://github.com/containerd/containerd/blob/129167132c5e0dbd1b031badae201a432d1bd681/plugin/context.go#L36 to get rid of one extra layer of grpc, which makes the event handling more reliable.

Ref https://github.com/containerd/containerd/issues/2120

+1  All of the grpcs should be switched over to internal APIs before we can do a 1.1 release with CRI

+1 All of the grpcs should be switched over to internal APIs before we can do a 1.1 release with CRI

@crosbymichael We'd like to have a release for Kubernetes 1.10 (March 21st).
If we can cut a containerd 1.1-x release around that time, we can deprecate standalone cri-containerd now.
If we can't, we may have to keep the standalone mode and cut a release for the standalone mode around that time.
Can we finish the grpc change before that? Or we may need to cut 1.1-x release later?
Maybe we should keep the standalone mode and cut a release for Kubernetes 1.10?

We are not considering the integration complete until it does not use GRPC

I will try to get rid of the extra grpc layer recently, and will handle this issue together with that.

Ref https://github.com/containerd/containerd/issues/2183

This is done in https://github.com/containerd/cri/pull/658.
Close.


⚠ ClamAV has degraded performance

In 3700a10, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in 27bed55.


What are the restrictions of the ids of top-level resources?

It would be helpful to apply the same restrictions as the ids of SBML/SED-ML:

starts with letter or underscore
composed of letters, numbers, and underscores

This would simplify encoding/decoding into SED-ML

This is a reasonable restriction. Will be implemented in #461


aws-sdk-cpp: 1.4.60 -> 1.4.65

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/aws-sdk-cpp/versions.
These checks were done:

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.4.65 with grep in /nix/store/g0zw6fdmf5flpnd5mqqjk373ndlq1zwd-aws-sdk-cpp-1.4.65

directory tree listing: https://gist.github.com/78023eae3b6e7a16a3b9e7fb7fdba55b

du listing: https://gist.github.com/2f4c13728002e11c5b08a8bc5658c21c

meta.description for aws-sdk-cpp is: '"A C++ interface for Amazon Web Services"'.
cc @edolstra for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout aecb983ebb4f3b85c24cf70248264116c12db28c && nix-shell --pure -I nixpkgs=. -p aws-sdk-cpp

Failure on x86_64-darwin (full log)
Attempted: aws-sdk-cpp
Partial log (click to expand)
[  1%] Building CXX object aws-cpp-sdk-alexaforbusiness/CMakeFiles/aws-cpp-sdk-alexaforbusiness.dir/source/model/UpdateSkillGroupRequest.cpp.o
[  1%] Building CXX object aws-cpp-sdk-alexaforbusiness/CMakeFiles/aws-cpp-sdk-alexaforbusiness.dir/source/model/UpdateSkillGroupResult.cpp.o
[  1%] Building CXX object aws-cpp-sdk-alexaforbusiness/CMakeFiles/aws-cpp-sdk-alexaforbusiness.dir/source/model/UserData.cpp.o
[  1%] Building CXX object aws-cpp-sdk-alexaforbusiness/CMakeFiles/aws-cpp-sdk-alexaforbusiness.dir/source/model/WakeWord.cpp.o
[  1%] Linking CXX shared library libaws-cpp-sdk-alexaforbusiness.dylib
[  1%] Built target aws-cpp-sdk-alexaforbusiness
Scanning dependencies of target aws-cpp-sdk-apigateway
[  1%] Building CXX object aws-cpp-sdk-apigateway/CMakeFiles/aws-cpp-sdk-apigateway.dir/source/APIGatewayClient.cpp.o
building of '/nix/store/fj4ir3dcz6qbxghw46dby5wzr4lxr3gm-aws-sdk-cpp-1.4.65.drv' timed out after 1800 seconds
error: build of '/nix/store/fj4ir3dcz6qbxghw46dby5wzr4lxr3gm-aws-sdk-cpp-1.4.65.drv' failed

Failure on aarch64-linux (full log)
Attempted: aws-sdk-cpp
Partial log (click to expand)
-- Installing: /nix/store/kb0c0r075fwg7zc3363ka8r7hkzj0mjb-aws-sdk-cpp-1.4.65/lib/pkgconfig/aws-cpp-sdk-cloudsearch.pc
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearchClient.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearchEndpoint.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearchErrorMarshaller.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearchErrors.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearchRequest.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/CloudSearch_EXPORTS.h
-- Installing: /nix/store/0xhwrs521s89p8fvzn0755v3aczxs8vb-aws-sdk-cpp-1.4.65-dev/include/aws/cloudsearch/model/AccessPoliciesStatus.h
building of '/nix/store/p4g2brlxy7mlh5qfzdaac7yaxslqp4bq-aws-sdk-cpp-1.4.65.drv' timed out after 3600 seconds
error: build of '/nix/store/p4g2brlxy7mlh5qfzdaac7yaxslqp4bq-aws-sdk-cpp-1.4.65.drv' failed

Failure on x86_64-linux (full log)
Attempted: aws-sdk-cpp
Partial log (click to expand)
[ 38%] Building CXX object aws-cpp-sdk-elasticmapreduce/CMakeFiles/aws-cpp-sdk-elasticmapreduce.dir/source/model/InstanceGroupState.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/source/model/GetPasswordDataRequest.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/source/model/GetPasswordDataResponse.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-elasticmapreduce/CMakeFiles/aws-cpp-sdk-elasticmapreduce.dir/source/model/InstanceGroupStateChangeReason.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/source/model/GetReservedInstancesExchangeQuoteRequest.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/source/model/GetReservedInstancesExchangeQuoteResponse.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-elasticmapreduce/CMakeFiles/aws-cpp-sdk-elasticmapreduce.dir/source/model/InstanceGroupStateChangeReasonCode.cpp.o
[ 38%] Building CXX object aws-cpp-sdk-elastictranscoder/CMakeFiles/aws-cpp-sdk-elastictranscoder.dir/source/model/JobAlbumArt.cpp.o
building of '/nix/store/qnyg3yza9nlssgk16fp1r3bbwn4nv3d4-aws-sdk-cpp-1.4.65.drv' timed out after 1800 seconds
error: build of '/nix/store/qnyg3yza9nlssgk16fp1r3bbwn4nv3d4-aws-sdk-cpp-1.4.65.drv' failed


Added confirm before deletion option

Solved #38

The confirm message should be present for comments as well.

https://github.com/NJACKWinterOfCode/Instances/pull/45/commits/ec043e4b202d157d299e023fdcdd1a0edaea4eae Made Changes @thebishaldeb


Docs.MS Release Updates for azure-ai-formrecognizer

Update docs metadata and targeting for release of azure-ai-formrecognizer

Docs Build status updates of commit 0d79484:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/ai-formrecognizer-readme.md
:warning:Warning
View (azure-java-stable)
Details

package.json
:white_check_mark:Succeeded

docs-ref-services/latest/ai-formrecognizer-readme.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'formrecognizer'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 28, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 83, Column 4: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/cli/azure/cognitiveservices/account?view=azure-cli-latest#az-cognitiveservices-account-show. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Updating Getting Started Guide for v0.5.0

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Now that v0.5.0 is released, we need to update our installation instructions to install the latest version.
Does this PR introduce a user-facing change?:
NONE

/lgtm


Update manylinux2010 to a recent version.

The previous version we were using, had some out-of-date repository definitions. Updating to the same manylinux2010 image, from a more recent tag.
The error I see when trying to rebuild the Docker images with the current definition is:
$ ./build_image.sh cpu
DOCKER IMAGE NAME: tlcpack/package-cpu:0.1
Sending build context to Docker daemon  31.74kB
Step 1/13 : FROM quay.io/pypa/manylinux2010_x86_64:2020-08-20-df89e22
 ---> 2d0471711e4c
Step 2/13 : COPY install/centos_install_core.sh /install/centos_install_core.sh
 ---> Using cache
 ---> 13c0f0f50547
Step 3/13 : RUN bash /install/centos_install_core.sh
 ---> Running in a143645f3e46
Loaded plugins: fastestmirror, ovl
Setting up Install Process
Determining fastest mirrors
Error: Cannot find a valid baseurl for repo: base
YumRepo Error: All mirror URLs are not using ftp, http[s] or file.
 Eg. Invalid release/repo/arch combination/
removing mirrorlist with no valid mirrors: /var/cache/yum/x86_64/6/base/mirrorlist.txt
The command '/bin/sh -c bash /install/centos_install_core.sh' returned a non-zero code: 1

cc @tqchen @icemelon9


WithConstructor seems to resolve constructor parameters and only once

Consider this usage:
.CreateListOfSize(5)
.All()
.WithConstructor(() => new Registration(Faker.Internet.Email(), RegistrationType.Beneficiary))

Passes the same email to the constructor for every time it creates the object. It should not do that.
Your code
var constructorArguments =
                (from argument in ((NewExpression)constructor.Body).Arguments
                select Expression.Lambda(argument).Compile().DynamicInvoke()).ToArray();

Resolves once and uses the same args over and over. Seems quite inappropriate for what this library does and the efforts you've made elsewhere to introduce randomness. You discard the constructor expression but why not use it to instantiate the object?
Consider this class
public class User
{
  public Foo(string emailAddress)
  {
    EmailAddress = emailAddress;
  }

  public string EmailAddress { get; protected set; }
}

So anywhere we have a class with a constructor that initialises a member that is protected it becomes unusable with the CreateListOfSize method. I'd need to loop myself and provide a different expression each time.

This is an interesting idea, but I imagine the reason the WithConstructor logic was put into place was to handle situations in which the constructor depended on some external service:
.CreateListOfSize(5)
.All()
.WithConstructor(() =>  new Registration(new RegistrarService()) )
;

NBuilder wouldn't be able to introduce randomness into these kinds of constructors.
Thoughts?

I'm not sure that makes any difference. If it was the intention of the user to share the registrar service between instances then they can instantiate it outside of the expression and use a and refer to the instance in the expression.
Randomness, at least in my example is introduced by me rather than nbuilder. Perhaps I am not understanding your point

I think it was me who wasn't understanding your point. You're just saying you want the constructor expression to be recompiled and executed for each item in the list. That makes sense to me, though my gut says it should be optional.

I don't think it even needs to be recompiled. Compiled once to Func and called for each, it should do what I want it to.
Other perhaps being a breaking change in behavior I don't see why it should be optional. The caller will have the control over whether a value is reused of not.
New service per instance
WithConstructor(() =>  new Registration(new RegistrarService()) )

Shared instance
var svc = new RegistrarService();
//...
WithConstructor(() =>  new Registration(svc) )

But it's your library :)

The breaking change is what I'm worried about. I see your point about just re-using the func. This is a good idea. Thanks!

So was this ever implemented? I want the same, to construct an object with different values on each new instantiation. Is that possible?

As implemented I can't really address this issue without making a breaking change to the Fluent API. Specifically, NBuilder is expecting a constructor expression as an argument to WithConstructor(). There are 2 issues with this:

The expression is not actually a Func<T> which is what I was expecting when I read it.
Func<T> cannot be easily converted to an Expression<Func>, which you can see by trying the following code:

            // does not compile
            var users = new Builder().CreateListOfSize<User>(2)
                .All()
                .WithConstructor(() =>
                    {
                        return new<EMAIL_ADDRESS>                    })
                .Build()
                ;

The simpler solution would be to add a new method to the API called WithFactoryMethod() that just takes a Func<T>. This raises a question about what to do if the caller provides both WithConstructor() and WithFactoryMethod() in their build instructions. Which one takes precedent? Perhaps the solution is to throw an exception if the caller attempts to use both. I need to resolve this question before I can proceed.
Thoughts?

Bummer re: issue 2 because having a Func<T> argument with WithConstructor() would be soo much easier to read/grok vs another extension method.
(just thinking out a loud)

yeah--but look how complex this part of the code already is:
        public T Construct(int index)
        {
            bool requiresArgs = reflectionUtil.RequiresConstructorArgs(typeof(T));

            if (typeof(T).IsInterface())
                throw new TypeCreationException("Cannot build an interface");

            if (typeof(T).IsAbstract())
                throw new TypeCreationException("Cannot build an abstract class");

            T obj;

            if (_constructorExpression != null)
            {
                obj = _constructorExpression.Compile().Invoke(index);
            }
            else if (requiresArgs && constructorArgs != null)
            {
                obj = reflectionUtil.CreateInstanceOf<T>(constructorArgs);
            }
            else if (constructorArgs != null)
            {
                obj = reflectionUtil.CreateInstanceOf<T>(constructorArgs);
            }
            else
            {
                obj = reflectionUtil.CreateInstanceOf<T>();
            }

            return obj;
        }

How many reflective if cases do you want to support? I'd much rather mark this method obsolete and point to the new (cleaner) method.

Can you make this method obsolete and then add a new one, though ALSO called WithContructor(F<T>) ?

I could--but it would violate the principle of least surprise. Further, there's nothing about Func<T> that implies or requires "constructor"--but Factory Method fits the bill exactly.

Hey guys, apologies I'm not sure if I was confused by the thread topic. I was finding when I used the WithConstructor() and setting the value that it was using that value for all constructed entities, which isn't great for testing purposes. The way I got around it was to use Faker.NET with NBuilder but mock out the entity I wanted with a call to Faker to set the default property each time.
With the below, it was Person that didn't have a parameterless constructor but I got around it like so:
`public class MockPerson : Person
{
private MockPerson() : base(GetRandomName())
{
}
        private static PersonName GetRandomName()
        {
            return new PersonName(Faker.Name.First(), Faker.Name.Last(), AutomationNodeName.Unspecified);
        }
    }`

I also found the behavior, pointed out by the original comment, strange. When would it be convenient to have a list of size x of identical items?
However I came up with a temporary fix for my project:
First create an extension method
public static class ExtensionMethods
    {
        public static IList<T> CreateListOfSize<T>(this Builder builder, int size, Expression<Func<T>> constructorBuilder)
        {
            return new List<T>();
        }
    }

Then initialize the Builder:
var builder = new Builder();
var list = builder.CreateListOfSize(10, () => new Coordinate2D(Faker.RandomNumber.Next(-90, 91), Faker.RandomNumber.Next(-180, 181)));

It should be mentioned that this strategy does not support .All, .With, .And etc. as the one shown in @cullimorer's comment would do, however, it will not require to mock every class that has a parameterized constructor.

I came to my senses. From the release notes:

Breaking Change: WithConstructor

No longer takes an Expression<Func<T>>.
Takes a Func<T>.
Marked [Obsolete] in favor of WithFactory
This change was to address an issue in which the constructor expression was not being reevaluated for each item in a list.


Polkit setup crashing on Fedora 39

Hello, thanks so much for this great software! I appreciate the security focused approach.
On Fedora 39, when installing via the rpm, I am somehow unable to setup Polkit properly:
$ goldwarden setup polkit
==== AUTHENTICATING FOR org.freedesktop.policykit.exec ====
Authentication is needed to run `/usr/bin/mv /tmp/goldwarden-policy /us ... actions/com.quexten.goldwarden.policy' as the super user
Authenticating as: lcchy
Password:
==== AUTHENTICATION FAILED ====
panic: exit status 127

goroutine 1 [running]:
github.com/quexten/goldwarden/cmd.setupPolkit()
	/home/runner/work/goldwarden/goldwarden/cmd/setup_linux.go:48 +0x496
github.com/quexten/goldwarden/cmd.glob..func24(0xc96aa0?, {0x92c989?, 0x0?, 0x0?})
	/home/runner/work/goldwarden/goldwarden/cmd/setup_linux.go:80 +0x17
github.com/spf13/cobra.(*Command).execute(0xc96aa0, {0xd062b0, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:987 +0xa91
github.com/spf13/cobra.(*Command).ExecuteC(0xc953a0)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115 +0x425
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039
github.com/quexten/goldwarden/cmd.Execute({{0x0, 0x0}, 0x0, {0xc000030a80, 0x2e}, 0x0, 0x0, {0x0, 0x0}, {0x0, ...}, ...})
	/home/runner/work/goldwarden/goldwarden/cmd/root.go:29 +0xea
main.main()
	/home/runner/work/goldwarden/goldwarden/main.go:52 +0x5f8

Any help would be very appreciated.

Hey, I had the same problem on Arch. I tried to run setup in Hyprland session and encountered this error. Then I opened X11 Cinnamon session and run setup again without any errors. Looks like there is a problem with Wayland.

@sandboiii, @Lcchy do you have a polkit agent set up? I.e what does pkexec whoami output?

For hyprland this should help: https://wiki.archlinux.org/title/Hyprland#Polkit_authentication

If that's not it, also try again on 0.2.15 please.

@quexten yeah, I haven't setup polkit agent and thus got this error. Now, I get this output after running setup:
failed setting selinux context
exit status 1
Polkit setup successfully

Is it acceptable to fail setting selinux context? My auth agent is /usr/lib/polkit-gnome/polkit-gnome-authentication-agent-1

Hi! Sorry for not getting back! I missed the notifications.
I have now moved away from Fedora, but my suspicion is that I was running Sway and that it was maybe missing a graphical polkit authentication agent ?
This issue seems to be to be the exact same: https://github.com/quexten/goldwarden/issues/180
Please feel free to close this issue in favor of #180 if you wish, as I can no longer provide debug tests for Fedora.


Improved Comparative Formula UI

Description
Improved ComparativeFormulaUI props interface with simplification and improvement of docs and tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 71.823%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1895

Relevant Lines:
2445

💛  - Coveralls


[feat] Explicitly specify systray Windows icon

Describe the problem
To use a system tray icon, you need to specify the path to the .png icon, then have an .ico version for Windows with the same name. This behavior might be confusing, and not obvious enough to trust or understand without checking the docs
Describe the solution you'd like
"systemTray": {
  "iconPath": ["icons/icon.png", "icons/icon.ico"]
}

Alternatives considered
No response
Additional context
No response

^ This would be just perfect. Just like the way you can specify different formats for the icon of Tauri app (normal icon. Not tray)

There is no need for this, we can use the same icon for all platforms even Windows.
I just need to make some changes at tao which I planned to include in tauri-apps/tao#297 but I might open a separate PR for it.


Phar + composer global require

Put into practice changes described here: https://github.com/DBDiff/DBDiff/issues/73
Now we can simply install DBDiff globally using:
composer global require "dbdiff/dbdiff:@dev"

Or we can build a Phar:

Clone the repository;
composer install
./build
Find a Phar in dist folder
You can rename "dbdiff.phar" to "dbdiff" and move it to /usr/local/bin, for example.

Sorry this took so long to get to. Still works all these years later!
Closing as your work has merged in PR #110

Thanks!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117395

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


rtcqs should optionally depend on python-pysimplegui

After installing rtcqs, running rtcqs_gui results in an error (missing PySimpleGUI), while rtcqs works fine. Installing python-pysimplegui fixes that, so it should be included as an optional dependency.

rtcqs already optionally depends on python-pysimplegui.
pacman will not install optional dependencies automatically, you have to explicitly install them, if you want them.


Unable to reproduce preprocessing for Table 1 data statistics

I use the DART data from HuggingFace (https://huggingface.co/datasets/dart). Following your description for data preprocessing, I am able to get the right statistics for WebNLG, right number of train and val instances for E2E, but not the other numbers in Table 1 (e.g. number of instances for all DART/Wiki* datasets, number of unique predicates, etc. -- which is as low as just 7 for e2e!)
In Section 4.1 of your paper, you mention that you "drop some WSQL and WTQ samples that contain non-conventional structural tags." Can you define "non-conventional" please? The term "conventional" is vague and undefined.

Howdy!
Sorry for the confusion. For WSQL and WTQ, we dropped samples containing tags like [TABLECONTEXT], [TITLE], etc. (those wrapped by square brackets) to ensure that we have samples with proper subject-predicate-object triplets as we have for WebNLG and E2E.
Thanks,
Zhuoer Wang

What is the exact data format fed into cycle training? For example, if there are multiple triplets for a text, do you concatnate them with 1. 2., ... and \n like what you show in Table 6?

Yes, we just concat the linearized triplets of a sample. It was concatenated with space instead of \n for easier processing of the input files. However, using \n is also fine, and I think it would make little difference to the final results.

So for yes, you mean you do have "1. 2., ..." etc in front of each triplet?

I see. Thanks. Can you provide a small sample of preprocessed data (e.g. few rows) please?

See: https://github.com/Edillower/CycleNLG/issues/1#issuecomment-1828870476

Got it. Thanks a lot!!


about  "mmdetection/configs/base/datasets/base/datasets/voc0712.py"

I have just use the project for a few days,when I try to train faster-rcnn by using VOC datasets,I found in the  line 47 of "mmdetection/configs/base/datasets/base/datasets/voc0712.py" ,it is  "ann_file=data_root + 'VOC2007/ImageSets/Main/text.txt",dosen't it should be"ann_file=data_root + 'VOC2007/ImageSets/Main/train.txt".

Conventionally we use the test set for validation rather than training set.

ok,thanks
------------------ 原始邮件 ------------------
发件人: "Wenwei<EMAIL_ADDRESS>发送时间: 2020年7月19日(星期天) 下午5:19
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [open-mmlab/mmdetection] about  "mmdetection/configs/base/datasets/base/datasets/voc0712.py" (#3348)
Conventionally we use the test set for validation rather than training set.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Conventionally we use the test set for validation rather than training set.
Hi, @ZwwWayne
I'm really curious about why ‘data_root + 'VOC2007/ImageSets/Main/trainval.txt' ’ in train ann_file key is repeated twice??


Environment clone

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
19.0.1
Amplify CLI Version
10.2.2
What operating system are you using?
mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Cloning dev env to create a qa and prod with amplify env add
Amplify Categories
auth, custom, storage, function, api, analytics
Amplify Commands
push
Describe the bug
Cloning my dev environment to qa and prod with amplify env add and when I run amplify push -y to create resources, it fails due to no data source found for XXX. This error is applied to all my resolvers. Using cdk-stack in custom to handle the vtl resolvers from my custom -> resolvers folder .
Expected behavior
Expect dev environment to be cloned into qa and prod
Reproduction steps

amplify env add qa / amplify env add prod
amplify push -y

GraphQL schema(s)

# Put schemas below this line

Project Identifier
d5de26ddbcf48705a4962c21df0d58a2
Log output

# Put your logs below this line

Additional information
No response

Hey @adcanis :wave: thanks for raising this and glad to hear you are back up and running! Given the issue of creating a new environment when we have a custom resource that depends on the API, but is being executed first (before the API exists), I'm going to mark this as a bug 🙂

@josefaidt need to revisit this issue with v10.7.0. I have repeated the same steps as before, this time for the production env. The problem now is when I only push the API, auth and functions are being added to the push. This results in an error as the lambda functions break the same way they do in issue #11714.


Fixes #121

After installing PHP7 we need to tell apache to disable php5
module and enable php7 module.
Puppet was updated accordingly.

@battlemidget Please test as follow:

Clone the repo in a new folder
Vagrant up
Visit: http://vagrantpress.dev

It's working here.

How to test:
git clone https://github.com/akeif/vagrantpress vagrantpress_test
cd vagrantpress_test
git checkout bugfix/php7-not-loaded-in-apache
vagrant up

Visit http://vagrantpress.dev

This worked for me.

Thanks all!


Accessing resouces in a separate assembly doesn't work as described

Following the instructions from below mentioned MS Docs page, I'm not able to access remote resources from an external assembly using ComponentResourceKey.
The following line in MainWindow.xaml doesn't work: no background color is getting displayed:
<StackPanel Grid.Row="0" Background="{DynamicResource {ComponentResourceKey TypeInTargetAssembly={x:Type res:DummyForSharingResources}, ResourceId=TestBg}}"></StackPanel>

I published a corresponding repository here, containing my Visual Studio 2019 solution. It contains all the details.
What I did so far

"Themes/generic.xaml" file created in supplemental assembly (StylesAndResources), filled with resources.
ThemeInfoAttribute updated in application assembly to reference ResourceDictionaryLocation.ExternalAssembly.
Dummy class created in StylesAndResources in order to be able to have a ComponentResourceKey be generated.

So, I followed the docs completely, and still it doesn't work.
What's wrong?
I propose the ComponentResourceKey/theming documentation to be amended to provide a concise, working description - or to remove this information completely from the docs if ComponentResourceKey and theming is not supported by WPF anymore.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 025a6256-5ca6-5e96-915d-1134d9e9dd43
Version Independent ID: 0786699a-4732-2214-67e6-ca8b7dcd5864
Content: Control Authoring Overview - WPF .NET Framework
Content Source: dotnet-desktop-guide/framework/wpf/controls/control-authoring-overview.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hello, I'll see if I can figure it out. Thank you for creating the repository with the code, that helps a bunch.

Hello, I'll see if I can figure it out. Thank you for creating the repository with the code, that helps a bunch.

Hello, @adego, I just wanted to ask for a short follow-up. Did you by accident manage to have a look at this?

Sorry for the delay. I couldn't get it working either.
@rladuca is there a known limitation with WPF .NET 5 in theming and referenced assemblies?

I FIGURED IT OUT!
Your StylesAndResources project also needs the ThemeInfo attribute set, but it needs it set to SourceAssembly
[assembly: ThemeInfo(
		ResourceDictionaryLocation.SourceAssembly,
		ResourceDictionaryLocation.SourceAssembly
)]

This makes it work. Even though it was working, I was able to (1) delete the assemblyinfo.cs file from the main project, and (2) change the reference in MainWindow.xaml from DynamicResource to StaticResource and everything still worked.

I believe this should solve the problem. I'll close this issue in anticipation :D just let me know how it goes!

Thank you so much, @adegeo 👍
I'm currently investigating on the distinguished differences between external resources via "pack" URI, ComponentResourceKey and generic.xaml. It would be a great help if you would spare the time if I'd have another question or two.
At this time, I believe the resouces documentation needs slight improvement. I'm striving for a clear, concise, exhaustive documentation, distinguishing between the four different resource reference approaches.
Just by chance: currently, there isn't a visual tracing tool available, listing a class library's externally available resources and how they affect an app's controls?


Sum of numbers via recursion on rust

Why:

Closes #ISSUE_NUMBER
What's being changed:

Please link the respective issue
For example Closes #1

Please link the respective issue
done


Added an example use case for noobs like me

Sorry for the late response.
There are a couple of issues why I am closing this pull request:

Most of the documentation you wanted to add is already there (it's in doc/client.md). I improved the documentation by commit d778944bb654a1a2f45088f5b3b866470b6d39ba. It adds more links/description in the readme and your example in the client documentation.
Instructing users to edit the script and overwrite the defaults of the argument parsing is bad practice. If someone does not want to type all the parameters at every call, he/she can supply a settings file.


Clean up OAB action page

https://openaccessbutton.org/action
Following issues for the action page

The first button (orange rectangle 'button') below "x people need access to research" has no headline text and just simply "or contact us directly."

Suggestions:
Headline the button with: Contact us
Linked text below: Get in touch on Twitter, Facebook, or email us directly.
url to hyperlink Twitter = https://twitter.com/OA_Button
Facebook = https://www.facebook.com/openaccessbutton
Email us directly = https://openaccessbutton.org/contact

Get connected
Change "Sign up to our mailing list here" to simply "Sign up to our mailing list" and change the url colour to the dark blue of other button links.

Would it be possible to make these three orange buttons on the page all the same size?

Remove the data requests listed at the bottom of the page. They aren't cleaned up for tests, they're infinite when scrolling, and that's what we have the requests page for.

Have cleaned up buttons and hidden stories till they're working better.

This is linked to #131

"Suggestions:
Headline the button with: Contact us
Linked text below: Get in touch on Twitter, Facebook, or email us directly.
url to hyperlink Twitter = https://twitter.com/OA_Button
Facebook = https://www.facebook.com/openaccessbutton
Email us directly = https://openaccessbutton.org/contact
Get connected Change "Sign up to our mailing list here" to simply "Sign up to our mailing list" and change the url colour to the dark blue of other button links."
@JosephMcArthur Do you want these as two new buttons?

Nope, they're not needed!

Not sure what I can do with this one, and #131 covers the relevant points for me, so unassigning to keep track of what I need to do.

@markmacgillivray this issue lives here until #131 is shut. Then I can unhide stories from the page.

Will look at this later in the week.

@markmacgillivray this looks so much better, which is great. The thing we really now have left to solve is that duplicate URL's are still being shown from (what I assume is) the same user. This feels like not a big challenge to solve, but let me know if it is.
Once that's done, and we're in the habit of cleaning #187 these lists will be much better.

Hmm, thought I removed these, will check. Moving to current milestone.

Now happening as part of new site dev, moving on to next milestone for further checks

Okay, no longer seeing duplicate URL's from a user & my comment on stories is not longer applicable. Closing for now however #187 remains an issue.


[BUG] Refit with ForecastingGridSearchCV when using a Grid Search based forecasters may not use "best hyperparameters"

Describe the bug
When using a Grid Search based forecaster (such as AutoARIMA, or ReducedRegressionForecaster with GridSearchCV from scikit-learn) in ForecastingGridSearchCV, the best hyperparameters that are found in the initial_window may not be used when the final refit is done.
The outer Grid Search (that in ForecastingGridSearchCV) works fine and picks the right hyperparameters for the final fit, but the inner Grid Search is a problem. This is due to the fact that the final refit is simply calling the fit function on the full data which leads to the entire "inner" grid search to be rerun. This may lead to a different set of best hyperparameters being selected than those that were selected during the fit in the initial_window.
Since the final hyperparameters can be different from the ones used in the sliding cross validation, this has the potential to make the cross validation results incorrect (i.e. cross validation results will not correspond to the final model hyperparameters that are refit).
To Reproduce
y = load_airline()
fh = np.arange(1, 13)

y_train, y_test = temporal_train_test_split(y, test_size=len(fh))

cv = SlidingWindowSplitter(
    initial_window=int(len(y_train) * 0.5),
    start_with_window=True,
)

# ARIMA
forecaster_param_grid = {"sp": [12, 24]}
forecaster = AutoARIMA(suppress_warnings=True)

gscv_arima = ForecastingGridSearchCV(
    forecaster, cv=cv, param_grid=forecaster_param_grid, verbose=True
)
gscv_arima.fit(y_train)

During the Grid Search, the hyperparameter values with sp=12 indicate that only 2 lags are selected along with a seasonal lag. Note, I have left out the parameters for sp=24 since that is not selected as the final best_forecaster.
# Initial Window Fit
forecaster._get_fitted_param_names()
['intercept', 'ar.L1', 'ar.L2', 'ar.S.L12', 'sigma2']
forecaster._get_fitted_params()
array([ 7.99081197,  0.56606485,  0.1956277 , -0.47478481, 68.31476303])

Best Estimator
self.best_forecaster_
AutoARIMA(sp=12, suppress_warnings=True)

Final Refit: This seems to indicate that there 3 lags should be used. This means that the hyperparameters selected by the final fit are not the same as those selected by the fit in the "initial_window". Note, that the actual parameter values will be different and that is OK, but the hyperparameters (param_names below) should be the same for the initial window and final refit.
self.best_forecaster_._get_fitted_param_names()
['intercept', 'ar.L1', 'ar.L2', 'ar.L3', 'sigma2']
self.best_forecaster_._get_fitted_params()
array([  5.53410033,   0.70489183,   0.25742152,  -0.14344774,<PHONE_NUMBER>3])

Expected behavior
The param names should be the same as those selected in the initial window.
Additional context
The same issue can potentially be observed when ReducedRegressionForecaster with GridSearchCV from scikit-learn is used in ForecastingGridSearchCV.
An example is shown below (note that in this case, it ends up picking the same hyperparameter in the final refit as in the initial_window, but since the GridSearchCV object is fit again in the end without any regard to the hyperparameters selected in the initial_window, it could have picked different hyperparameters.
regressor_param_grid = {"n_estimators": [200, 300]}
forecaster_param_grid = {"window_length": [12, 15]}
tscv = TimeSeriesSplit()

# create a tunnable regressor with GridSearchCV
regressor = GridSearchCV(
    RandomForestRegressor(),
    param_grid=regressor_param_grid,
    cv = tscv,
    scoring='neg_mean_squared_error',
    verbose=1
)
forecaster = ReducedRegressionForecaster(
    regressor, strategy="recursive"
)

gscv = ForecastingGridSearchCV(
    forecaster, cv=cv, param_grid=forecaster_param_grid, verbose=1
)
gscv.fit(y_train)

Possible Solution
Implement a refit method in the forecasters.

For the Grid Search Based forecasters, this will pluck the "best hyperparameters" based on the "inner" grid search and use those for the final fit by setting those explicitly in the underlying forecaster (ARIMA for AutoARIMA, RandomForestRegressor for ReducedRegressionForecaster, etc.) instead of performing the "inner" grid search again.
For non Grid Search based forecasters, this can simply alias the fit method.

Versions

System:
    python: 3.6.12 |Anaconda, Inc.| (default, Sep  9 2020, 00:29:25) [MSC v.1916 64 bit (AMD64)]
executable: C:\Users\Nikhil\.conda\envs\sktime_dev\python.exe
   machine: Windows-10-10.0.18362-SP0

Python dependencies:
          pip: 20.3.3
   setuptools: 51.0.0.post20201207
      sklearn: 0.24.0
       sktime: 0.5.1
  statsmodels: 0.12.1
        numpy: 1.19.4
        scipy: 1.5.4
       Cython: 0.29.17
       pandas: 1.1.5
   matplotlib: 3.3.3
       joblib: 1.0.0
        numba: 0.52.0
     pmdarima: 1.8.0
      tsfresh: 0.17.0

@ngupta23, short comments on first read:

the issue you describe is not a bug, since you're not describing a discrepancy between expected/contracted functionality and actual functionality.
I agree we may want to carefully think about, and then document expected/contracted behaviour. There is lack of proper documentation of intended "should" here.
I'm not sure I agree with your "should" state here. This would lead to two different algorithms being implemented, depending on the specific implementation of the wrapped estimator, not just on the type. I think dispatch-on-concrete, as opposed to dispatch-on-type, should be avoided.

@ngupta23, short comments on first read:

the issue you describe is not a bug, since you're not describing a discrepancy between expected/contracted functionality and actual functionality.
I agree we may want to carefully think about, and then document expected/contracted behaviour. There is lack of proper documentation of intended "should" here.
I'm not sure I agree with your "should" state here. This would lead to two different algorithms being implemented, depending on the specific implementation of the wrapped estimator, not just on the type. I think dispatch-on-concrete, as opposed to dispatch-on-type, should be avoided.

Hi @fkiraly
Definitely, more documentation on this would be nice since it was definitely not what I was expecting and would not have figured that out unless I was looking deeper into the code.
And I agree that if that if this was intentionally done this way, then this is not a bug.
That being said, is there a way to do what I am asking in sktime right now or is it planned?
Thanks!

Hi @fkiraly
Definitely, more documentation on this would be nice since it was definitely not what I was expecting and would not have figured that out unless I was looking deeper into the code.
And I agree that if that if this was intentionally done this way, then this is not a bug.
That being said, is there a way to do what I am asking in sktime right now or is it planned?
Thanks!

That being said, is there a way to do what I am asking in sktime right now or is it planned?

That depends entirely on what you mean by "what I am asking", but I guess not.
Though I might also contest whether what you are asking is the behaviour we'd ultimately want.
Generally, I think one takeaway of this is that we may want to think carefully about how to document our higher order algorithms, since the devil is in the detail, and the expected/actual may differ if it is not properly written up somewhere.
Any opinions, @mloning?

That being said, is there a way to do what I am asking in sktime right now or is it planned?

That depends entirely on what you mean by "what I am asking", but I guess not.
Though I might also contest whether what you are asking is the behaviour we'd ultimately want.
Generally, I think one takeaway of this is that we may want to think carefully about how to document our higher order algorithms, since the devil is in the detail, and the expected/actual may differ if it is not properly written up somewhere.
Any opinions, @mloning?

@ngupta23 Having looked into this a bit more, I agree that this it not a bug and indeed what I would expect to happen - similar to what I'd expect to happen if I'd put a GridSearchCV into a GridSearchCV object in scikit-learn.
If you do not want to run nested CV, you can just use temporal CV and optmise over the entire parameter grid:
from sktime.forecasting.all import *
from sklearn.model_selection import GridSearchCV
from sklearn.ensemble import RandomForestRegressor

y = load_airline()
fh = np.arange(1, 13)

y_train, y_test = temporal_train_test_split(y, test_size=len(fh))

param_grid = {"regressor__n_estimators": [200, 300], "window_length": [12, 15]}

cv = SlidingWindowSplitter(
    initial_window=int(len(y_train) * 0.5),
    start_with_window=True,
)
regressor = RandomForestRegressor()
forecaster = ReducedRegressionForecaster(regressor, strategy="recursive")
gscv = ForecastingGridSearchCV(forecaster, cv=cv, param_grid=param_grid, verbose=1)
gscv.fit(y_train)
gscv.best_params_

I agree that we need to better document this. I'm also not sure what works better empirically, or what is being used more often in practice.

@ngupta23 Having looked into this a bit more, I agree that this it not a bug and indeed what I would expect to happen - similar to what I'd expect to happen if I'd put a GridSearchCV into a GridSearchCV object in scikit-learn.
If you do not want to run nested CV, you can just use temporal CV and optmise over the entire parameter grid:
from sktime.forecasting.all import *
from sklearn.model_selection import GridSearchCV
from sklearn.ensemble import RandomForestRegressor

y = load_airline()
fh = np.arange(1, 13)

y_train, y_test = temporal_train_test_split(y, test_size=len(fh))

param_grid = {"regressor__n_estimators": [200, 300], "window_length": [12, 15]}

cv = SlidingWindowSplitter(
    initial_window=int(len(y_train) * 0.5),
    start_with_window=True,
)
regressor = RandomForestRegressor()
forecaster = ReducedRegressionForecaster(regressor, strategy="recursive")
gscv = ForecastingGridSearchCV(forecaster, cv=cv, param_grid=param_grid, verbose=1)
gscv.fit(y_train)
gscv.best_params_

I agree that we need to better document this. I'm also not sure what works better empirically, or what is being used more often in practice.

@fkiraly Thanks for the feedback on this topic.
@mloning , Thanks for the alternate code. Let me try this out and get back in case there are any further questions. If this works as expected, it might be good to document this in the forecasting example notebook.

@fkiraly Thanks for the feedback on this topic.
@mloning , Thanks for the alternate code. Let me try this out and get back in case there are any further questions. If this works as expected, it might be good to document this in the forecasting example notebook.

Hi @mloning , Thank you for the alternate code for ReducedRegressionForecaster. I verified that this alternate (without using GridSearchCV in the regressor) works great when using scikit-learn based regressors.
However the issue still exists with AutoARIMA since it is essentially an intelligent Grid Search. Do you have an alternate that works for AutoARIMA as well?

Hi @mloning , Thank you for the alternate code for ReducedRegressionForecaster. I verified that this alternate (without using GridSearchCV in the regressor) works great when using scikit-learn based regressors.
However the issue still exists with AutoARIMA since it is essentially an intelligent Grid Search. Do you have an alternate that works for AutoARIMA as well?

@ngupta23 if you do not want to use AutoARIMA, why not use simply ARIMA with a pre-defined grid for hyper-parameters?

@ngupta23 if you do not want to use AutoARIMA, why not use simply ARIMA with a pre-defined grid for hyper-parameters?

I was afraid of that :). There are just too many hyperparameter combinations to try with the base ARIMA from statsmodels. Let me try it out anyway to see what can be done. Thanks again for your guidance on this.

I was afraid of that :). There are just too many hyperparameter combinations to try with the base ARIMA from statsmodels. Let me try it out anyway to see what can be done. Thanks again for your guidance on this.


2017 Game Stats Not Updated?

Using the recommended script to pull entire season data into a CSV file:
import nflgame
nflgame.combine(nflgame.games(2017)).csv('season2017.csv')

But just taking a quick glance over the data, it is definitely not updated, i.e. M. Ryan has 317 passing yards. I ran the nflgame-update-players command but it doesn't seem to have had an effect.
Anyone run into this issue?

Well, I found a solution by going through older issues...
Navigated to the C:\Python27\Lib\site-packages\nflgame directory and ran py -2 update_sched.py --year 2017 (on a Windows machine).
Got the following output and up-to-date stats:
Updating (2017, PRE, 0)...
Updating (2017, PRE, 1)...
Updating (2017, PRE, 2)...
Updating (2017, PRE, 3)...
Updating (2017, PRE, 4)...
Updating (2017, REG, 1)...
Updating (2017, REG, 2)...
Updating (2017, REG, 3)...
Updating (2017, REG, 4)...
Updating (2017, REG, 5)...
Updating (2017, REG, 6)...
Updating (2017, REG, 7)...
Updating (2017, REG, 8)...
Updating (2017, REG, 9)...
Updating (2017, REG, 10)...
Updating (2017, REG, 11)...
Updating (2017, REG, 12)...
Updating (2017, REG, 13)...
Updating (2017, REG, 14)...


⚠ Bofrost.com has degraded performance

In 7957e6f, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 751 ms

Resolved: Bofrost.com performance has improved in f4aa43b after 6 minutes.


[3.x] Sort based on camera position when using perspective camera

Fixes a sorting bug reported on RocketChat and likely other reported sorting issues.
The core of the problem here is that sorting appeared to be dependant on view angle. This is because Godot is calculating distance based on the distance to the near plane instead of distance to the camera origin. When using a perspective camera, sorting should take place based on distance to the camera origin rather than distance to the camera plane.
This is a small change with big consequences and needs a lot of testing before being merged.
A similar change needs to be made in 4.0 as well (likely in multiple places see: #60253)
Here is how it worked in Godot 2 https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c8634150be/drivers/gles2/rasterizer_gles2.cpp#L4853-L4857
Here is how it works in Ogre:
https://github.com/OGRECave/ogre/blob/d302dee15b389cb916dfa13b1e4e55cd8cffaa55/OgreMain/src/OgreNode.cpp#L663-L670
The Unity Docs also suggest using the near plane for sorting when using an orthogonal camera and the origin for perspective https://docs.unity3d.com/ScriptReference/Camera-transparencySortMode.html

Drawing of the problem with distance to plane

Out of interest, what were the arguments pro / against using distance rather than distance squared, I noticed Ogre didn't do this? Greater precision, or does it interact better with the rest of the sorting which expects linear distance? Not that I think it will make a great deal of difference performance wise for the number of objects typically involved, even if doing it per light etc.
I suppose it could lead to some incorrect swapping of e.g. windows that are close and parallel to the viewer. But this kind of sorting is always very rough anyway and subject to all kinds of issues.

My guess is that regular distance is the naive approach and squared distance is the optimized approach. Godot has always just used regular distance, I'm not sure there has ever been arguments in either direction. The only thing to consider is consistency with other areas that rely on depth. In Godot 3.x it wouldn't be very hard to switch to squared distance if we wanted, in Godot 4.0 a lot of different systems rely on the distance (Lod, Occlusion, Geometry Fade, Decals, Clusters) so we would have to be very careful.

cc @tinmanjuggernaut This PR may be of interest to you. I'm not sure if you continue to have depth sorting issues, but if you do, this may help.

My guess is that regular distance is the naive approach and squared distance is the optimized approach. Godot has always just used regular distance, I'm not sure there has ever been arguments in either direction.

From my testing, we can use squared distance easily for "hard" cutoffs, but smooth fading should still use standard distance.

cc @tinmanjuggernaut This PR may be of interest to you. I'm not sure if you continue to have depth sorting issues, but if you do, this may help.

Yes, this was an issue if you were standing among two trees with overlapping branches. Turn the camera one way and one set of branches overlaps. Rotate the camera and the other tree pops forward. Does this fix that?
What about depth sorting with transparent objects with MMI? Which is broken/backward last I checked. Does this help that?

Yes, this was an issue if you were standing among two trees with overlapping branches. Turn the camera one way and one set of branches overlaps. Rotate the camera and the other tree pops forward. Does this fix that?

Potentially yes. Sorting is no longer camera-orientation dependant so sorting should be stable on camera rotation.

What about depth sorting with transparent objects with MMI? Which is broken/backward last I checked. Does this help that?

MultiMeshInstance doesn't do any sorting of objects within the MultiMeshInstance, so this may still be an issue. This PR won't help sorting within a MultiMeshInstance, but may help sorting between multiple MeshInstances.

Have approved this as we have to test at some point. One additional possibility is we could make this a project setting to swap between the two modes, even if temporarily? But maybe this would be overkill.
It may cause some slight differences in sorting with e.g. parallel alpha blended polys with a sufficiently different AABB. But maybe the benefits outweigh this.

Thanks!

Does this PR effects transparent object sorting by any chance?

Does this PR effects transparent object sorting by any chance?

Yes, have you seen any regressions?

I don't test alpha/beta and PR versions so idk but I'm happy if it will make transparency sorting more accurate

I don't test alpha/beta and PR versions so idk but I'm happy if it will make transparency sorting more accurate

This should make transparency sorting more accurate :) You may or may not notice a difference in your project though.


RuntimeError: Native library not available at ......site-packages/py_mini_racer/libmini_racer.dylib

I'm using Macbook Air M1,and I install py-mini-racer with pip successfully.but when I run ctx = py_mini_racer.MiniRacer() the error RuntimeError: Native library not available at /Users/dmitry/Applications/Miniforge3/envs/python38/lib/python3.8/site-packages/py_mini_racer/libmini_racer.dylib happens. I have checked the directory, there is no file named libmini_racer.dylib.
I have no idea about that.Can anyone help? Grateful!
file which python
/Users/dmitry/Applications/Miniforge3/envs/python38/bin/python: Mach-O 64-bit executable arm64
python -V
Python 3.8.6

I'm using Macbook Air M1,and I install py-mini-racer with pip successfully.but when I run ctx = py_mini_racer.MiniRacer() the error RuntimeError: Native library not available at /Users/dmitry/Applications/Miniforge3/envs/python38/lib/python3.8/site-packages/py_mini_racer/libmini_racer.dylib happens. I have checked the directory, there is no file named libmini_racer.dylib.
I have no idea about that.Can anyone help? Grateful!
file which python
/Users/dmitry/Applications/Miniforge3/envs/python38/bin/python: Mach-O 64-bit executable arm64
python -V
Python 3.8.6

哥，咋解决的呀


Is there a special define macro of SMD platform in the SGDK compiler?

Hello to all SGDK developers and thank you for this wonderful SDK for Sega Mega Drive and Sega Genesis!
I have a project to port the 2048 game to a huge number of different platforms, including SMD:
https://github.com/EXL/2048/tree/master/2048-SMD
The implementation of the game "engine" in C programming language is common across multiple platforms. After defining things specific to the SMD in it, I ran into some problems. I used the directive  #ifdef mc68000 to separate specific SMD code but it has a collisions with the NeXT computers where this CPU architecture and GCC were also used. Now I have to do something like #if defined(mc68000) && !defined(NeXT) to correctly identify only platform-specific SMD code.
Is there a way that would allow me to define a platform specific defines without editing SGDK files? Maybe I can do a PR with the addition of the -DSGDK_SMD define (can you suggest a better define?) to the DEFAULT_FLAGS and DEFAULT_FLAGS_LIB variables in these SGDK files:
https://github.com/Stephane-D/SGDK/blob/d0dbb6a74393c0b3351a771d6bd4f518b303e3ff/makefile.gen#L98
https://github.com/Stephane-D/SGDK/blob/d0dbb6a74393c0b3351a771d6bd4f518b303e3ff/makelib.gen#L62
This will be included in the new SGDK release and I will be happy to be able to use #ifdef SGDK_SMD in my code!
P. S. As I understand it, it is much more difficult to rebuild GCC with addition default platform specific flags which are shown by the echo | /home/exl/Projects/SEGA/SGDK/bin/gcc -B/home/exl/Projects/SEGA/SGDK/bin -dM -E - command in Linux.
P. P. S. Maybe someone will be interested in my small project from the link above, so here is a picture with a real Sega Mega Drive and the ROM file.

2048-SMD.zip
Cheers!

@Stephane-D

If you know a solution to preserve the define without heavy modification of the makefile i'm all in :)

I think this small patch will be enough for make me happy :smile_cat:
diff --git a/makefile.gen b/makefile.gen
@@ -71,7 +71,7 @@ LST= $(SRC_C:.c=.lst)
-DEFAULT_FLAGS= -m68000 -Wall -Wextra -Wno-shift-negative-value -Wno-main -Wno-unused-parameter -fno-builtin $(INCS) -B$(BIN)
+DEFAULT_FLAGS= -m68000 -Wall -Wextra -Wno-shift-negative-value -Wno-main -Wno-unused-parameter -fno-builtin -DSGDK=TRUE $(INCS) -B$(BIN)

diff --git a/makelib.gen b/makelib.gen
@@ -37,7 +37,7 @@ DEP_LIB= $(OBJ_LIB:.o=.d)
-DEFAULT_FLAGS_LIB= -m68000 -Wall -Wextra -Wno-shift-negative-value -fno-builtin $(INCS_LIB) -B$(BIN)
+DEFAULT_FLAGS_LIB= -m68000 -Wall -Wextra -Wno-shift-negative-value -fno-builtin -DSGDK=TRUE $(INCS_LIB) -B$(BIN)

Another way:
diff --git a/makefile.gen b/makefile.gen
@@ -71,7 +71,7 @@ LST= $(SRC_C:.c=.lst)
-DEFAULT_FLAGS= -m68000 -Wall -Wextra -Wno-shift-negative-value -Wno-main -Wno-unused-parameter -fno-builtin $(INCS) -B$(BIN)
+DEFAULT_FLAGS= -m68000 -Wall -Wextra -Wno-shift-negative-value -Wno-main -Wno-unused-parameter -fno-builtin -DSGDK=TRUE $(CUSTOM_FLAGS) $(INCS) -B$(BIN)

diff --git a/makelib.gen b/makelib.gen
@@ -37,7 +37,7 @@ DEP_LIB= $(OBJ_LIB:.o=.d)
-DEFAULT_FLAGS_LIB= -m68000 -Wall -Wextra -Wno-shift-negative-value -fno-builtin $(INCS_LIB) -B$(BIN)
+DEFAULT_FLAGS_LIB= -m68000 -Wall -Wextra -Wno-shift-negative-value -fno-builtin -DSGDK=TRUE $(CUSTOM_FLAGS) $(INCS_LIB) -B$(BIN)

This will allow SGDK users to do the following things when building their projects:
$ make -f $GDK/makefile.gen CUSTOM_FLAGS=-DGAME_VERSION="v1.0"

 ...
$ gcc -m68000 -Wall -Wextra -Wno-shift-negative-value -Wno-main -Wno-unused-parameter -fno-builtin -DSGDK=TRUE -DGAME_VERSION=v1.0 -Iinc -Isrc -Ires ...
                                                                                ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^

Best regards, EXL.

@Stephane-D Thank you! I will be looking forward to the new version of SGDK!


Amp for pages

Is there a way to generate AMP for pages instead of posts only?

I actually managed with some changes in the code:
https://github.com/sandoche/amp-jekyll


HedgeEdit - Options Menu/Redone Config Data

We'll need more user data to be stored later on down the road. For example I'm wanting to have themes and control preferences.
I could use the built-in .NET config stuff but tbh I don't really like it lol. There's some limitations on what you can store and I find it to be messy idk. I think it'd be much better to just store configuration data in %appdata%/HedgeEdit as either a custom binary format or just an xml file tbh

binary
binary is always the best :dab:

BINA is the best.

BFRES (Binary caFe RESources)

nah fam BINA headers are amazing

Done :dab: 0acd8a28edf1889b60d6198f81382e8a7c1abb32 & ffb136f4c15f3636235823ebeec4b1899713b5ad


Add Set Snapshot and export addresses

Pull Request Test Coverage Report for Build 5788

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 5784:
0.0%

Covered Lines:
1005

Relevant Lines:
1005

💛  - Coveralls


library stopped working with flutter

Hello,
Last two dev versions of flutter (0.9.6 and 0.10.0) stopped working when having reflectable in the project dependencies. It looks like incompatible internal dependency problem:

Running "flutter packages get" in project...
Because every version of flutter_test from sdk depends on analyzer 0.33.0 and reflectable 2.0.7 depends on analyzer ^0.32.0, flutter_test from sdk is incompatible with reflectable 2.0.7.
So, because ordo_dealer depends on both reflectable 2.0.7 and flutter_test any from sdk, version solving failed.

Can you please upgrade analyzer to 0.33 and release new version? Thank a lot!

Sure! I somehow didn't see this issue before now, sorry about that.
Apparently, build changed in non-trivial ways, so I'll have to port reflectable to use build ^1.0.0. A fix is upcoming soon, but it is not yet ready.

A PR is under review which modifies reflectable to use analyzer 0.33 and build 1.0.0 (and a few other newer versions going along with that). You can try it out as branch port_to_build_10x_oct18.

Landed said PR as https://github.com/dart-lang/reflectable/commit/c0891b0426436ee258a927671971e4bdbc1268e6.


Add conditional in status code setting and logging service, with new …

…endpoint and tests
Introduced a check in EmptyBody204Policy.cs to ensure that the http response has not started before setting the status code to 204. This prevents any modifications from being attempted on a response that has already begun and can reduce unexpected behavior.
Included a logging service in the Program.cs file to allow for better tracking of application messages and help in debugging.
Two new files were added, 'using_write_by_id.cs' and 'WriteToEndpoints.cs', to create a new Marten-based endpoint ('/write-to/{id}') along with its corresponding integration test. This aims to enhance the API's functionality by allowing retrieval of issues by their unique ID.
refs #575

Cool, good addition. This will be in 1.8.0 soon-ish


feat: fallback to full table scan if indexing store is not available/disabled

Codecov Report

Merging #422 (c5282f6) into main (5bf3f08) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   29.63%   29.49%   -0.15%
==========================================
  Files          75       75
  Lines        7875     7914      +39
==========================================
  Hits         2334     2334
- Misses       5302     5341      +39
  Partials      239      239

Impacted Files
Coverage Δ

query/filter/selector.go
23.63% <0.00%> (-6.60%)
:arrow_down:

server/services/v1/api.go
0.00% <0.00%> (ø)

server/services/v1/query_runner.go
6.72% <0.00%> (-0.11%)
:arrow_down:

server/services/v1/row_reader.go
0.00% <0.00%> (ø)

store/kv/errors.go
100.00% <ø> (ø)

store/kv/fdb.go
52.83% <0.00%> (-0.59%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add an option to allow specifying a token to use for reading from external repositories.

This change allows specifying a token to be used for retrieving configuration files and queries from external repositories. This is useful if the repositories containing these files are private. It also has the side-effect of fixing the fact that external queries were not usable at all on GitHub Enterprise Server; they will now work automatically for public repositories and allow you to provide a token for private repositories.
I'm not completely convinced about the name of the configuration option so I'm very happy to hear suggestions about that (or obviously anything else about the implementation).
I've played around with the Git authentication logic a fair bit, and I think I've got something that works reasonably. I tried using the Git extraheader option to authenticate but I'm a bit concerned that by base-64 encoding the token before using it in a command we risk it being leaked by it not being redacted correctly all the time. Another option is to use a credential helper, which has the advantage of being able to pass credentials in environment variables instead of on the command line, but I'm not sure this would work cross-platform very well. I think another alternative would be to write the clone URL with credentials directly to .git/config, but that gets a bit complicated as we then need to be able to parse the gitconfig file format.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

I've merged in main and fixed some conflicts related to the introduction of GitHubApiDetails. I'm not sure I've done a great job since combining the API token and URL into a single object seems kind of antithetical to this change. I guess the alternative is giving GitHubApiDetails two fields for tokens but I'm not sure if that's much better.

Hmm, I agree the introduction of GitHubApiDetails makes this PR a bit more complicated. It would be nice to just add the new token to GitHubApiDetails but that's annoying because we don't have the token available in all of the actions. It would be nice to get the type system to keep us safe, so we avoid nullable types and avoid using the same field for multiple uses.
I've had a go at doing the above as I thought it would be easier to just code it than to try to explain it in words. Have a look at https://github.com/github/codeql-action/pull/357 and let me know what you think. Short summary is we introduce a new type and use typescript's duck typing so we can just pass in a bigger type and it'll ignore the extra fields.

Hmm, I agree the introduction of GitHubApiDetails makes this PR a bit more complicated. It would be nice to just add the new token to GitHubApiDetails but that's annoying because we don't have the token available in all of the actions. It would be nice to get the type system to keep us safe, so we avoid nullable types and avoid using the same field for multiple uses.
I've had a go at doing the above as I thought it would be easier to just code it than to try to explain it in words. Have a look at https://github.com/github/codeql-action/pull/357 and let me know what you think. Short summary is we introduce a new type and use typescript's duck typing so we can just pass in a bigger type and it'll ignore the extra fields.


add smtp to Monitors list

Hello f5
could you please accept this PR to add smtp monitor to supported list LTM Monitors.
please let me know if you need further information
thank you

changes already available


⚠ Bofrost.be has degraded performance

In cb0af22, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1600 ms

Resolved: Bofrost.be performance has improved in e07bb9a after 6 minutes.


How to use custom Hamiltonian?

Hi.
The parameters of my model have no constraint.
I implemented the following two functions and want to use HMC algorithm of zhusuan.
How to do that? If I can't use the function directly, how to implement custom StochasticTensor?
def cal_log_likelihood(p1, p2):
    """Calculate log-likelihood of the model

    Parameters
    ----------
    p1 : tf.Tensor, shape=(n_chains, n_states)
    p2 : tf.Tensor, shape=(n_chains, n_states, n_states)

    Returns
    -------
    log_likelihood : tf.Tensor, shape=(n_chains,)
    """
    return log_likelihood

def cal_prior(p1, p2):
    """Calculate logarithm of the prior probability

    Parameters
    ----------
    p1 : tf.Tensor, shape=(n_chains, n_states)
    p2 : tf.Tensor, shape=(n_chains, n_states, n_states)

    Returns
    -------
    log_prior_probability : tf.Tensor, shape=(n_chains,)
    """
    return log_prior_probability

Thank you.

Hi, for a easy example of using HMC, you can refer to the toy example here, where HMC is used to sample a Gaussian-distributed variable: https://github.com/thu-ml/zhusuan/blob/master/examples/toy_examples/gaussian.py. You can also look at other examples listed in our README with HMC or SGMCMC as the inference method, which are more practical and complicated than the toy gaussian example.
For your question, it is best to implement your probabilistic model using BayesianNet in ZhuSuan, then your model will automatically have a log_joint property corresponding to the posterior distribution, then you can pass the MetaBayesianNet instance to HMC.
A more direct approach for your question is to implement a log_joint function by yourself. A minimal description is as follows:
# Suppose the latent variable you want to sample is p.

def log_prior(p):
    # Calculate the log prior density...
    return log_prior

def log_likelihood(p):
    # Calculate the log-likelihood...
    return log_likelihood

def log_joint(observed):
    return log_prior(observed['p']) + log_likelihood(observed['p'])

hmc = zs.HMC(step_size=1e-3)
# A tf.Variable should be created to store the current samples.
p = tf.Variable(...)
sample_op, _ = hmc.sample(log_joint, observed={}, latent={'p': p})

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    sess.run(sample_op)
    # Now the value of the tf.Variable p will be updated; p stores the current samples.

For this kind of usage (passing log_joint callable function instead of a MetaBayesianNet instance to hmc.sample), please refer to some older versions of some examples, such as https://github.com/thu-ml/zhusuan/blob/fe8b7cba1e0ec31b37eeb6652d0e87d28fad18fd/examples/topic_models/lntm_mcem.py.
Feel free to ask if you have more questions :)

Should I provide the log-joint probability or the negative of log-joint probability in the following line?
sample_op, _ = hmc.sample(log_joint, observed={}, latent={'p': p})

In tensorflow probability, I actually have to provide the negative of the log-joint probability:
https://www.tensorflow.org/probability/api_docs/python/tfp/mcmc/HamiltonianMonteCarlo
# Target distribution is proportional to: `exp(-x (1 + x))`.
def unnormalized_log_prob(x):
  return -x - x**2.

just the log joint probability

What will happen if the log-joint probability is -inf or nan? Would the HMC automatically reject the proposal in these two cases?

The HMC works well! Thanks a lot. The mass and step-size adaptation really help to fit my model.

Very glad to hear that!
Regarding the issue of nan, HMC should deal with such cases correctly (see #78).


[Validator] Wrong address tags

I going to work on this

I completed the validator for Wron Address Tags
here is the validator