wc-generator: update comment to meet lint spec

Alaska Airlines Pull Request
Fixes: #176
Summary:
This PR addresses a grammar issue that conflicts with JSDoc lint expectations.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 3.7.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Uncaught Error: Cannot find module '@storybook/blocks'

I'm getting this error in the console: Uncaught Error: Cannot find module '@storybook/blocks'
The panels isn't appearing either.
I installed the addon yarn add -D ... and added it to the list of addons:
  addons: [
    '@storybook/addon-links',
    '@storybook/addon-essentials',
    '@storybook/addon-interactions',
    'storybook-addon-mock',
  ],

Then I set the mockData param for a component like this:
SomeComponent.parameters = {
  mockData: [
    {
      url: '/app/api/some/thing/1',
      method: 'GET',
      status: 200,
      response: { token: 'abc123' },
    },

Am I missing something? I tried yarn add -D @storybook/blocks and that did not fix the problem. I'm on node 16.14.2 in case that matters.

@emersonthis  I'm not sure if it's related to our package. Can you try uninstalling storybook-addon-mock?

@emersonthis try different version if you don't use latest storybook. For my case it was version 3.2.0. My storybook version is 6.5.16

I'm with storybook 6.5.16 and    "storybook-addon-mock": "^4.1.0". And this issue exists.

This package is added as a dependency in version 4.3.0


Dynamic scope using context

Allow to add patterns dynamically

Can do better than with dynamic scope. Delegated to PatterntT


OCPBUGS-28902: Allow modified IPv6 address as CPIC name

CloudPrivateIPConfig's name is supposed to be an IPv4 or IPv6 address. However, the K8s constraints do not allow colons in the names of the resources, so for IPv6 addresses the names are the addresses fully expanded with colons replaced with dots. E.g. fc00:f853:ccd:e793::54 becomes fc00.f853.0ccd.e793.0000.0000.0000.0054. This means that standard K8s validation of format: ipv6 will not work as it'll try parsing the address using golang's net library and that will fail due to s/\:/\./.
This commit replaces format: ipv6 with a pattern that matches fully expanded IPv6 addresses to fix the problem.

/jira cherrypick OCPBUGS-27222

/jira refresh

/lgtm


Anerdw: Watch SR[\W_]*+University

Anerdw requests the watch of the watch_keyword SR[\W_]*+University. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

SR[\W_]*+University has been seen in 4 true positives, 0 false positives, and 0 NAAs.

Approved by Cow in Charcoal HQ


Prompting in another language sometimes gives a english answer

Has anyone figured out how to get it to just prompt in the language you are using to ask questions. It jumps a little back and forth between english and the other language.

@marella
Is other language ie: Spanish , Dutch and Turkish supported ? Which model is the best for those?

I don't think the default models are the best for all languages. I'm also not familiar which models are best for other languages.
I would suggest asking for model suggestions (language specific or multilingual) in forums like r/LocalLLaMA You would need both embeddings model and LLM that work well with a language.
For embeddings model, you can also look at some of the multilingual models in https://huggingface.co/sentence-transformers#models For example, https://huggingface.co/sentence-transformers/paraphrase-multilingual-mpnet-base-v2

During extensive testing I found out that as the main model Guanaco 65B works best for german and https://huggingface.co/intfloat/multilingual-e5-large for the multilingual embeddings.


set_vref/to_vref fail with un-intuitive error

While running to_vref on a DEM without vertical reference set, I ran into some errors that are not very intuitive to fix. Here is a minimal working example:
import xdem
xdem.examples.download_longyearbyen_examples(overwrite=False)
reference_dem = xdem.DEM(xdem.examples.FILEPATHS["longyearbyen_ref_dem"])
reference_dem.set_vref('EGM96')
reference_dem.to_vref('WGS84')

fails with error

CRSError: Invalid projection: : (Internal Proj Error: proj_create: unrecognized format / unknown name)

This is because reference_dem.ccrs=None. This can be easily fixed by running:
reference_dem.set_vref('EGM96', compute_ccrs=True)
But neither the error, nor the fix, are intuitive. I suggest either to make compute_ccrs the default, if it makes sense, or to catch the above error and raise an error mentioning that set_vref must be run with compute_ccrs set to True.
I also suggests writing a dedicated page on the documentation to showcase this feature.
@rhugonnet do you think you can have a look at it? Or I can have a look at it later if we agree on the fix.

I forgot to mention that
reference_dem.set_vref('WGS84')
reference_dem.to_vref('EGM96')

works without problem. But I'm not sure why that is, since self.ccrs is also None in that case.

I forgot to mention that
reference_dem.set_vref('WGS84')
reference_dem.to_vref('EGM96')

works without problem. But I'm not sure why that is, since self.ccrs is also None in that case.

This is what I was going to ask!
Because the test:
#checking that the function properly runs with a reference set
img.set_vref(vref_name='WGS84')
mean_ellips = np.nanmean(img.data)
img.to_vref(vref_name='EGM96')
mean_geoid_96 = np.nanmean(img.data)

passes without issue.
I'll look into this :)

Thanks!


connectivity plugin for flutter

can you please migrate connectivity plugin to androidX?  there are so many other plugins already using androidX and I just can't use this plugin  because it's not supported

Hi @shovael
can you please provide your flutter doctor -v
and your flutter run --verbose?
Also, to better address the issue, would be helpful
if you could post  a minimal code sample
or the steps to reproduce the problem.
Thank you

i believe the error i was getting was due to androidX compatibility, i found a temporary solution on this issue: https://github.com/flutter/flutter/issues/42887


numeric alias produces "0.00" instead of null when cleared out.

I am evaluating this excellent plugin. When I clear an input field, it sets it to "0.00" instead of null. This maybe a known issue to you but would put it out here.
Am I missing something?
  var options = {
          alias: 'numeric',
          autoGroup: scope.autoGroup || true,
          autoUnmask: true,
          radixPoint: scope.decimalChar || '.',
          digits: scope.numOfDecimals > -1 ? scope.numOfDecimals : 2,
          digitsOptional: typeof scope.digitsOptional !== 'undefined' ?
                                            scope.digitsOptional : true,
          groupSeparator: scope.groupSeparator || ',',
          prefix: scope.prefix || '',
          placeholder: scope.placeholder || '0',
          suffix: scope.suffix || '',
          unmaskAsNumber: true
        };

        elem.inputmask(options); // apply the jquery input mask plugin

duplicate of #786

@RobinHerbots  thanks for addressing this.

@RobinHerbots I started working with 3.2.3 and still see the problem. There is no way for me to clear the input once it has a focus. It defaults to 0 or 0.00 etc. What options need to be passed so it can be cleared completely (input value should be null or empty string).

@kjavia ,
Can you retest with the latest version on github.


Allow selectState to take comparator/keySelector for distinctUntilChanged

I have a quite big state object and I don't want all my observables to re-fire every time some unrelated part of the state changes.
In the current selectState there is a distinctUntilChanged (docs), but it is sadly not as effective, since without any arguments it would check at object identity which changes in my case as I create copies to keep everything immutable.
My own workaround was to override the selectState:
  // eslint-disable-next-line no-unused-vars
  override selectState<K>(
    selectFn?: (state: Readonly<S>) => K,
    comparator?: (previous: K, current: K) => boolean,
  ): Observable<K> {
    return super.selectState(selectFn).pipe(
      distinctUntilChanged(comparator=comparator)
    )
  }

(I only needed comparator for the time being)
This is okay, but now there is an extra unnecessary distinctUntilChanged in the chain.
Would it be possible to add support for something like this?

Yep, published into 14.0.7!
https://www.npmjs.com/package/ng-simple-state/v/14.0.7

Incredible! That was fast - Thank you :smiley:

@PeterSR i want add an option for define a global "comparator", eg.:

I think that sounds like a good idea!
Specifically regarding using JSON stringify, my concern will be 1) speed and 2) reordering of keys, but that's probably why you make it customizable.
Regarding if your library is useful: Yes, very much! We needed something simple for state management that we then later would replace with something like ngrx, but right now I am not even sure we want or need that.

Published in https://www.npmjs.com/package/ng-simple-state/v/15.0.2
JSON stringify is just an example, but it is customizable!
Thanks! I use my library in some simple projects and NGRX in some complex objects. But, honestly, my library can handle projects at any scale...

Thank you!
And that is great to hear :smile:


After installation NT client downloads files one by one

Self-update process takes a long time. Maybe we can speedup it somehow? Parallel downloads?

duplicate of https://github.com/Noita-Together/noita-together/issues/165


Regression of applier build times in Rust 1.57

Current and expected behavior
1.57 behaviour

Check out https://gitlab.com/teozkr/repros/-/tree/kube/rs1.57-compile-regression.
rustup update 1.57.0
cargo +1.57.0 build
Note that the full build gets stuck for several minutes on rs157-compile-regression(bin)
touch src/main.rs
cargo +1.57.0 build
Note that the incremental build takes ~40s (on my machine, scale to yours)

1.56 behaviour

rustup update 1.56.1
cargo +1.56.1 build
Note that the full build completes in ~30s (on my machine, scale to yours)
touch src/main.rs
cargo +1.56.1 build
Note that the incremental build takes ~3s (on my machine, scale to yours)

Possible solution
More of a workaround, but boxing queue:
diff --git a/src/main.rs b/src/main.rs
index a306bba..6e08d03 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -25,7 +25,8 @@ async fn main() {
                 stream::empty::<Result<watcher::Event<ConfigMap>, watcher::Error>>(),
             )),
             (),
-        ),
+        )
+        .boxed(),
     )
     .boxed()
     .for_each(|_| async {})

brings the incremental rebuild time down to ~4s.
Additional context
No response
Environment
Arch Linux
Rustc 1.57 (bad), 1.56.1 (good)
K8s cluster is irrelevant since this is a build issue
Configuration and features
kube = { version = "0.64.0", features = ["runtime"] }
k8s-openapi = { version = "0.13.1", features = ["v1_22"] }

Affected crates
kube-runtime
Would you like to work on fixing this bug?
yes

Curiously, this only seems to happen for the pattern applier(..., trigger_self(try_flatten_applied(reflector(...)))). Removing any of those steps, or erasing to a trait object (with StreamExt::boxed) seems to step around the issue.

Good spot. Confirming it happens on mine as well.
$ touch src/main.rs
$ time cargo +1.57.0 build
   Compiling rs157-compile-regression v0.1.0 (/home/clux/repos/repros/repros)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 18s

real	1m18.798s
user	1m12.865s
sys	0m5.807s

then clean and after building once:
$ touch src/main.rs
$ time cargo +1.56.1 build
   Compiling rs157-compile-regression v0.1.0 (/home/clux/repos/repros/repros)
    Finished dev [unoptimized + debuginfo] target(s) in 3.12s

real	0m3.158s
user	0m2.700s
sys	0m0.458s

Dramatic difference.

I can reproduce this with just futures, so this seems more like a rustc issue. Filed https://github.com/rust-lang/rust/issues/91598.

This is is presumably no longer an issue with the fix getting into stable. Are you OK with bumping the msrv from this point on?

Happy to close this and unblock the MSRV, I'm back on stable since 1.59.


Article about dapp secret needs rewriting

Article about https://flant.github.io/dapp/secrets_for_kube.html is hard to understand by newbies. Also it should be traslated to English.

Opening, because article should be traslated to English.


Investigate why build-scan plugin misbehaves with source dependencies

This assumes you have the gradle/gradle build-scan init script in ~/.gradle/init.d
git clone https://github.com/gradle/native-samples
cd cpp/source-dependencies
./gradlew build --scan

This explodes with
A build scan cannot be produced as an error occurred gathering build data.
Please report this problem via https://e.grdev.net/help and include the following via copy/paste:

----------
Gradle version: 4.4-20171007063318+0000
Plugin version: 1.9

java.lang.IllegalStateException: Root project has not been attached.
        at org.gradle.invocation.DefaultGradle.getIdentityPath(DefaultGradle.java:112)
        at org.gradle.invocation.DefaultGradle_Decorated.getIdentityPath(Unknown Source)
        at org.gradle.configuration.ConfigurationTargetIdentifier$3.getBuildPath(ConfigurationTargetIdentifier.java:125)
        at org.gradle.configuration.BuildOperationScriptPlugin$OperationDetails.getBuildPath(BuildOperationScriptPlugin.java:122)
        at com.gradle.scan.plugin.internal.a.n.e.a(SourceFile:47)
        at com.gradle.scan.plugin.internal.c.e.run(SourceFile:62)

java.lang.IllegalStateException: Root project has not been attached.
        at org.gradle.invocation.DefaultGradle.getIdentityPath(DefaultGradle.java:112)
        at org.gradle.invocation.DefaultGradle_Decorated.getIdentityPath(Unknown Source)
        at org.gradle.configuration.ConfigurationTargetIdentifier$2.getBuildPath(ConfigurationTargetIdentifier.java:105)
        at org.gradle.configuration.BuildOperationScriptPlugin$OperationDetails.getBuildPath(BuildOperationScriptPlugin.java:122)
        at com.gradle.scan.plugin.internal.a.n.e.a(SourceFile:47)
        at com.gradle.scan.plugin.internal.c.e.run(SourceFile:62)

java.lang.IllegalStateException: Root project has not been attached.
        at org.gradle.invocation.DefaultGradle.getIdentityPath(DefaultGradle.java:112)
        at org.gradle.invocation.DefaultGradle_Decorated.getIdentityPath(Unknown Source)
        at org.gradle.configuration.ConfigurationTargetIdentifier$3.getBuildPath(ConfigurationTargetIdentifier.java:125)
        at org.gradle.configuration.BuildOperationScriptPlugin$OperationDetails.getBuildPath(BuildOperationScriptPlugin.java:122)
        at com.gradle.scan.plugin.internal.a.n.e.a(SourceFile:47)
        at com.gradle.scan.plugin.internal.c.e.run(SourceFile:62)

java.lang.IllegalStateException: Root project has not been attached.
        at org.gradle.invocation.DefaultGradle.getIdentityPath(DefaultGradle.java:112)
        at org.gradle.invocation.DefaultGradle_Decorated.getIdentityPath(Unknown Source)
        at org.gradle.configuration.ConfigurationTargetIdentifier$2.getBuildPath(ConfigurationTargetIdentifier.java:105)
        at org.gradle.configuration.BuildOperationScriptPlugin$OperationDetails.getBuildPath(BuildOperationScriptPlugin.java:122)
        at com.gradle.scan.plugin.internal.a.n.e.a(SourceFile:47)
        at com.gradle.scan.plugin.internal.c.e.run(SourceFile:62)

I've pinged Rene about this, but he won't be able to look at it until next week.

@big-guy, it looks to me like the Build Scan Plugin is just reading the includedBuilds from the Gradle instance to determine if it is a composite build. Didn't we introduce a separate place that our implicitly included builds are registered as they are discovered? I bet if we patch the plugin to look there too, we'll start getting the same behavior.
See:
https://github.com/gradle/dotcom/blob/ce27d73e41f3e68206222cf7a285c57e4206499b/scans-plugin/src/main/java/com/gradle/scan/plugin/BuildScanPlugin.java#L306

@eljobe The check happens too early.  It's when the plugin is being applied and we won't know that we have implicitly included builds until much later (after interesting things have happened that the build scan plugin would want to collect).
The build scan plugin could ask "could the build possibly have included builds?" by checking if there are any VCS mappings and disable itself accordingly.  I think that would be temporary until the build scan plugin supports composite builds.

I think that makes a lot of sense. But, maybe we should run the proposal by the GE team? Can you send that email?

I opened an issue on their board yesterday about this and tagged @breskeby about it.
I added a comment just now that suggests that we temporarily disable the build scan plugin if we detect there could be included builds from a VCS mapping

I just had a crazy idea about this one. What if, when running the settings script, if we notice a vcsMapping, we insert a "placeholder" includeBuild that doesn't do anything special, but it tricks the Build Scan Plugin into thinking that it's a composite build. Then, very early in dependency resolution, we could just remove the "placeholder"?
The main reason I'm even suggesting this, is so that it would work for existing versions of the Build Scan Plugin. Maybe it's not a big deal though. We have some time before we're going to be recommending using source dependencies.

I wouldn't bother trying to trick the build scan plugin. Instead, we should increment min supported build scan plugin version to a version that doesn't blow up.

And until such a version exists, just keep blowing up? (I'm cool with it, just wanted to make sure I understand your suggestion.)

Exactly right.
Looking at those stack traces again, it look like an issue in the build tool to me though.

Definitely an issue in the build tool. Those build operations shouldn't be firing without us assigning an identifier to the implicitly included build.

@adammurdoch, for my understanding, isn't this also true for composite builds? In other words, shouldn't the build tool be creating identifiers for the explicitly included builds as well?  I wonder if this may be one of the things that the core team is already working on to help the build scan plugin work with composite builds?

There could be an underlying issue with composite builds that is masked because the build scan plugin bails out early when using composite builds.

Yeah, I think there's something wrong with what we're doing when applying either init scripts or settings.gradle and expecting to get a identifier for the build operation.
I think this is something we can fix, but I think we should still talk to Rene next week (or the week after) so GCS knows what's going on.

Here's a stab at fixing the build operations generated: https://github.com/gradle/gradle/pull/3171
Basically, we were always assuming we could get the "identity path" of a Gradle instance (which was based on the root project name and build hierarchy).  For ApplyScriptPluginBuildOperationType's generated for projects, the root project would be configured.  For ApplyScriptPluginBuildOperationTypes generated for Settings (a settings file) or Gradle (an init script), this only worked for the outermost build because we special case the build with no parent as having the build path :.  Included builds would not have a root project set for either of these build operations, so we couldn't determine the identity path for them.
With the change, we set the root project's name just before the settings file is evaluated and again after it has been evaluated (in case it's changed).

For included builds, we can assign an identity as soon as we know about the build, before we run any build operations on that build. We do the same thing for projects as soon as we know about them.
For explicitly included builds, the identity can be based on directory passed to includeBuild() and we can later offer ways to override this at that point.
For implicitly included builds, the identity can be based on the component identifier.
Once the identity of a build is consumed by something, e.g. when it is exposed via a build operation, it should never change again. So settings the root project name and then changing the name later is out as a solution.

There are three build operations that have a ConfigurationTargetIdentifier that we care about:

ApplyScriptPluginBuildOperationType for Projects (for build.gradle and scripts applied from there)
ApplyScriptPluginBuildOperationType for Settingss (for settings.gradle and scripts applied from there)
ApplyScriptPluginBuildOperationType for Gradles (for init scripts)

The ConfigurationTargetIdentifier has a getBuildPath that should return the path to the build.  This is the same kind of path used for BuildIdentifier.
There are five types of builds that have these build operations:

The root build
buildSrc
An explicitly included build
An implicitly included build
A GradleBuild build

We special case the root build and always give it the path :, so it never has a problem finding its build path or changing its path.  All of the other builds are considered nested builds and should behave similarly to one another.
For project build scripts, things work because the build path is determined before any build operations are created.
For settings files and init scripts, all of the nested builds have a problem because they currently determine their build path based on their root project name, which isn't added until after settings and init scripts have been evaluated.
At some point, we must have run across this problem in buildSrc and added this assumption (directory name == root project name) for included builds:
https://github.com/gradle/gradle/blob/master/subprojects/core/src/main/java/org/gradle/initialization/buildsrc/BuildSourceBuilder.java#L141-L146
I think it makes sense to change buildSrc and explicitly included builds to use their directory names as their build paths. This can be locked in early enough and prevented from changing.
Implicitly included builds can do the same for now, since we assume the included build from VCS is a single project and in the root of the repository.
That only leaves us with GradleBuild builds.  We haven't had any restrictions/assumptions on the name of the build or the root project name when used from GradleBuild. To make all nested builds consistent, I think we have to assume the same thing (directory name == root project name).  The other choice would be to use a GradleBuild's task name.
I've started down that path with the current PR.  When we create a nested DefaultGradle, I assign it a build name based on the root directory.
WDYT?

Sounds good.
I think later we might split the identifier into some synthetic id (eg an integer) that we can assign early to the build before we know anything about it, and some more stable path-like id that we calculate after we've run the settings script for the build. Nothing we need to do now though.

It looks like we have some tests that rely on being able to configure the build id from the root project name:
https://builds.gradle.org/viewLog.html?buildId=8733218&
If I force the build id to be derived from the directory name for included builds, this effects the identifier for all projects too:
https://github.com/gradle/gradle/blob/1d3fa8aab141cf76381740602301be0751f7fb0c/subprojects/core/src/main/java/org/gradle/api/internal/project/DefaultProject.java#L530
Thoughts on how this should be working?

I think we should punt on this for now.  We know why the build-scan plugin misbehaves and it's not something special to source dependencies. We're going to have the same problem with composite builds in general.
The GCS team is going to disable the build-scan plugin if they detect there are VCS mappings, which is probably "good enough" for now.


Controls ignore STOP filter mode

godot 23f6d3fa69935c90c6cdcee342ae99d226e9b4ab
here is sample
https://www.dropbox.com/s/n31lmfwybqbkb1h/mouse_test.zip?dl=0
if you press anywhere in window, _input event will capture this and print to Output, But of you click button, the same will happen, even while it has 'Stop' filter mode.

i've also tried now creating a simple control with script that handles _gui_input and if mouse button is pressed just sets
get_viewport().get_tree().set_input_as_handled()
or
accept_event()
but none of them works 🙄

@curly-brace so what's the status of this issue?

@kubecz3k well, it is active. i posted this code just to show that it is still possible to block events. but button just seems to ignore this step.

In case anyone is interested, the issue still seems to be present on the latest builds.

So I think this is a regression, as far as I remember it was working in 2.x

Can confirm. Even when using "Pass" as the mouse filter, objects behind the control are not receiving input events.


Search results nav - shift+f4

@egamma What problem did you say you had with shift+f4? It works as expected for me.

@roblourens my problem was the 'F4' gives focus to the editor and I could not press it repeatedly. I've tried to reproduce it with all extensions disabled and it worked well. Sorry about the false issue.

The culprit is the C++ extension, this means the users of the C++ extensions have the same issue.

Given that the C++ extension is popular we should "fix this" by announcing this as a "breaking" key binding change in the release notes.

Shouldn't this be moved to C++ extension and the extension change its key mapping?

Filed an issue on vscode-cpptools, and added to the release notes


Create New Address Form - Comments - Not passed to API

When the Comments field is populated the value is not passed to the API.

Implemented - please test in next version

Retested and comments still not passing to API.

Rechecked, was looking at the wrong field. Notes are passing to sourceReason.


Bumps net-ssh version from 3.2 to 4.2

This is needed b/c net-ssh 3.2 does not work correctly with Ruby 2.4.
See https://github.com/net-ssh/net-ssh/issues/535
Bumping it for linux_admin gem too at https://github.com/ManageIQ/linux_admin/pull/195
Steps for Testing/QA

Start ManageIQ using Ruby 2.4 with OpenStack Infra provider present.
Go to Edit page for that model, go to tab for ssh keypair credentials.
Fill in correct username and correct key if not already present.
Click on Validate button.

Actual result:
Validation fails with NoMethodError: undefined method p=' for #OpenSSL::PKey::DH:0x....` in evm.log.
Expected result:
Validation pass (if correct username and ssh key)

Closing in favor of #16347


Add report extension implementation

Purpose
To be able to generate reports from Siddhi from a Siddhi sink.
Goals

User should be able to generate the reports from Siddhi events, data from the RDBMS store extension, data from the RDBMS datasources defined in the stream processor pack.
User should be able to generate reports from external JRXML file template file given.
User should be able to add charts (line, bar, pie, table) into the report.
User should be able to provide RDBMS queries and create multiple charts according to those query date.

Approach

Jasper reporting library is the core library for this implementation.
Jasper reporting library is used directly for the report generation when external JRXML template file is provided.
DynamicJasper is used to generate the reports dynamically.

User stories
Please find the user story here.
Automation tests

Unit tests
73% code coverage

Samples
@sink(type='report',outputpath='/abc/example.pdf',@map(type='json'))define stream BarStream(symbol string, price float, volume long);
Under above configuration, for an event chunck,a report of type PDF will be generated. There will be a table in the report.
@sink(type='report',outputpath='/abc/{symbol}.pdf',@map(type='json'))define stream BarStream(symbol string, price float, volume long);
Under above configuration, for an event chunck,a report of type PDF will be generated. The name of the report will be the first event value of the symbol parameter in the stream. There will be a table in the report.
@sink(type='report',outputpath='/abc/example.pdf',chart='Line',chart.title='Line chart for the sample report.',category='symbol',series='price',@map(type='json'))define stream BarStream(symbol string, price float, volume long);
Under above configuration, for an event chunck,a report of type PDF will be generated.The report report will include a line chart with the specified chart title. The chart will be generated with the specified category and series. The report will be generated in the given output path.
@sink(type='report', outputpath='/abc/example.pdf',mode='query',datasource.name='SAMPLE_DATASOURCE',queries="""[{"query":"SELECT * FROM SampleTable;","chart":"table"},@map(type='json'))
Under above configuration, for an event trigger,a report of type PDF will be generated.The report report will include a table with the data from the RDBMS datasource specifies as 'datasource.name' and the data from the query as specified in 'queries'. The report will be saved in the given output path.
 @sink(type='report', outputpath='/abc/example.pdf',mode='query',datasource.name='SAMPLE_DATASOURCE',queries="""[{"query":"SELECT * FROM SampleTable;","chart":"table"},{"query":"SELECT Value, Age FROM SampleTable;","chart":"line","series":"Value","category":"Age","chart.title":"Test chart"}]""", @map(type='json'))
Under above configuration, for an event trigger,a report of type PDF will be generated. The will be two charts as per each RDBMS query. The datasource for both queries will be the value specified as 'datasource.name'. The first query will generate a table with the data from the query as specified in 'queries'. The second query will generate a line chart where the data will be taken from the second query as defined in the 'queries' parameter. The report will be saved in the given output path.
Test environment

JDK version: 1.8
Operating system: Ubuntu 16.04

Learning

The JaperReports tutorials.
The DynamicJasper tutorials.

@kts-desilva Have you addressed the feedback given in the code review?

@this Yes, I have addressed the feedback given with 0afa3baf4aedcba9856019ba4c3c0c071445a5fa


Calendar disabled when timer running

💻 Environment
Platform: Windows
📒 Description
On mac we currently have the calendar disabled when the timer is running. We should add this functionality to Windows also as editing date on a running timer can cause issues. For example, when time is set to future the error appears about "Stop time needs to be later than start time"
Also, the fact that tracking time should be a current event not in the far future.
If the user needs to have the start date set to yesterday they can do so with duration.
Things to do:

When editing running timer -> Calendar input disabled
When editing stopped timer -> Calendar input enabled.

I think we could visually indicate that the calendar is disabled by hiding this calendar button when date picking is disabled. What do you think?

Sounds good. Also I think the text will be gray when input is disabled.


Update project README to replace Google Code link with nupkg download link?

Others who do not have access to nuget.exe or the VS extension might find this url handy:
https://www.nuget.org/api/v2/package/{package-id}/{package-version}
I generally just download the cassandra-sharp-tools nupkg which contains all the binaries produced by this project.
E.g: https://www.nuget.org/api/v2/package/cassandra-sharp-tools/3.2.0

Will use msbuild/sdk project soon (see branch feature/msbuild-sdk for wip).
Everything will be merge in one big package because splitting interface and core is pretty much overkill.


Network interfaces without a gateway (i.e. unmanaged switches) skipped by NetworkUtils.GetInterface()

Not sure why, but it looks like I added gateway detection when it was never necessary. All that we need is an interface with a local IP.

Tested and working, closed


no mssql-jdbc_auth-8.2.0.x64 in java.library.path facing this issue

Tried Reset to default and download/Update.
Try to reset driver settings.
From connection settings dialog click Edit Driver Settings -> Reset to Defaults (at the bottom).
Then dbeaver is not asking dlls re-download, only jar downloads is prompted
Manually placed the  no mssql-jdbc_auth-8.2.0.x64.dll file
Ensured both  no mssql-jdbc_auth-8.2.0.x64 and sqlserver version is the same.

Please help as this is blocking me.
Windows authentication only failed. Server Authentication works fine for me.
System information:
Operating system (distribution) and version: MacOS Catinila
DBeaver version 7.0.4 community
Connection specification:
Microsoft SQL Server

@uslss : I followed all your steps related to previous similar tickets. Did not help me solve the issue. Please guide me on this

hi @Harshitha1991 ,
unfortunately, cannot reproduce an issue. Is it actual for newly created connection too?
Could you show what is proposed when you click Download/Update button?

I see only the jar in recommended downloads. But not mssql-jdbc_auth-8.2.0.x64.dll.
Please refer to the attached screen shot for more infow

Native Windows authentication available only on Windows machines.
You can't load this DLL on MacOS.

I have the same issue.
System : Mac OS Catalina
Dbeaver Version : 7.1
Tried the below steps but no luck

Download/upadate the drivers
2.Reset the drivers to default

please help
Thank you
Santosh

is it still actual?

I am facing the same issue still - are there any updates?
System : Mac OS Catalina
Dbeaver Version : 7.1.4
I have tried resetting to defaults and download them manually - no luck with any of the approaches.
Thank you,
Nuno

How to download the drvier mannually?
System: Mac OS Catalina
Dbeaver Version: 7.1.5

Native Windows authentication available only on Windows machines.
You can't load this DLL on MacOS.

Is there anyway around this? I have a MS Sql Server database I need to authenticate to with Windows Authentication on Mac OS

@emiliogarza you can try jtds driver (should be a different connection type when creating connection). Look for documentation online, through some driver properties you can specify you windows domain, username and password. It lacks some other functionality with respect to official Microsoft driver however.


#20 사업분야 코드

Closes #20

Codecov Report

Merging #31 (0c675b9) into main (451b292) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              main     #31      +/-   ##
==========================================
- Coverage     1.23%   0.96%   -0.28%
  Complexity       1       1
==========================================
  Files            7       8       +1
  Lines           81     104      +23
==========================================
  Hits             1       1
- Misses          80     103      +23

Impacted Files
Coverage Δ

...necia/domain/enterprise/code/BusinessAreaCode.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451b292...0c675b9. Read the comment docs.


Publish datasets to IPFS

We should publish datasets to IPFS.

Trying to do it using Filebase S3 interface. Might not be possible as it is uploading every file to a different root CID.
That means there is no common root CID we have been getting in the Gitcoin Grants Portal as the pipeline there uses Filebase CDK to package all the files into a CAR file.


[2x-null-replace_media_id] Due to null ID which cause error

Description
I use PostgreSQL and got this error when uploading a media file
[2021-06-04 02:44:56] production.ERROR: SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for integer: "null" (SQL: select exists(select * from "medias" where "id" = null and "medias"."deleted_at" is null) as "exists") {"userId":1,"exception":"[object] (Illuminate\\Database\\QueryException(code: 22P02): SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for integer: \"null\" (SQL: select exists(select * from \"medias\" where \"id\" = null and \"medias\".\"deleted_at\" is null) as \"exists\") at /workspace/vendor/laravel/framework/src/Illuminate/Database/Connection.php:685)
[stacktrace]
#0 /workspace/vendor/laravel/framework/src/Illuminate/Database/Connection.php(645): Illuminate\\Database\\Connection->runQueryCallback()
#1 /workspace/vendor/laravel/framework/src/Illuminate/Database/Connection.php(353): Illuminate\\Database\\Connection->run()
#2 /workspace/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2705): Illuminate\\Database\\Connection->select()
#3 /workspace/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1648): Illuminate\\Database\\Query\\Builder->exists()
#4 /workspace/vendor/area17/twill/src/Http/Controllers/Admin/MediaLibraryController.php(342): Illuminate\\Database\\Eloquent\\Builder->__call()
#5 /workspace/vendor/area17/twill/src/Http/Controllers/Admin/MediaLibraryController.php(214): A17\\Twill\\Http\\Controllers\\Admin\\MediaLibraryController->shouldReplaceMedia()
#6 /workspace/vendor/

Related Issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make terminal table more responsive

this trys to fix the ugliness of terminal table on small terminals - by making tables fit to terminal width.
in addition to the variable size, i also did a middle_truncate.
so instead of very long va...  now very ... value  is displayed.
Large

Medium

Small

Ruby 1.9.3 added 'io/console' to the standard library.
the additional require should not be a problem.

to quickly test it use this ruby script:
require "fastlane_core"
FastlaneCore::PrintTable.print_values(config:
  { wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
      wwwwwwwwwwwwwwwwwwwwwwwwxw: "ccc bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" },

                                   hide_keys: [],
                                       title: "Summary SUM")

This is a really good idea, however, I would also like an option to disable this (e.g. when running on CI) so that users have at least an option to see the whole thing for debugging purposes.

@milch  ok done -
truncate = false if Helper.is_ci? || FastlaneCore::Env.truthy?("DO_NOT_TRUNCATE_TABLES")

sorry for the force push, as i had to rebase for the truthy? stuff.

sorry for the force push

No worries, I haven't reviewed yet 👍

FastlaneCore::Env.truthy?("DO_NOT_TRUNCATE_TABLES")

This is a bit nitpicky but mostly we'd like to prefix ENV-vars. Can we call it FL_NO_TRUNCATE_TABLES (or something)?

This looks super promising, ideally it would also be used for the action table: https://github.com/fastlane/fastlane/issues/7811

@KrauseFx feedback addressed.
should i do the action table thing in this PR or in a seperate?

@KrauseFx ok i updated it to also work with newlines instead of the .. stuff (defaulting to: ....)
here is a sample to test:

require "fastlane_core"

FastlaneCore::PrintTable.print_values(config:
  { wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
      wwwwwwwwwwwwwwwwwwwwwwwwxw: "ccc bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" },

                                   hide_keys: [],
                                       title: "Summary SUM")

FastlaneCore::PrintTable.print_values(config:
                                         { wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
                                             wwwwwwwwwwwwwwwwwwwwwwwwxw: "ccc bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" },

                                                                          hide_keys: [],
                                                                              title: "Summary SUM",
                                                                              transform: :newline)

and i also added support for this in the actions_list.rb:
fastlane actions

and in detailed action descr.:
fastlane action adb

is there a way to make the line wraps happen at word boundaries?
from the screenshot above there are several words that are broken up from one line to the next

@jinjorge  good point, but i think there are cases where really long words would not be wrapped and resulting in a ugly table, you have a idea on how to solve that?

@hjanuschka It's a numbers game - there are a lot more sub 5-6 letter words than really long words. Probably best to optimize for the majority and see how things fall out.
To you question on how to solve it - I don't know, though I will do some research.

test's pass now, ready for new review! @jinjorge  i am unsure on how to solve it without breaking the output.

a regular expression match (\b) for word boundary.

@jinjorge  got it working !!!  respecting whole word, but if too long forcing to break it! ;)

  # Base taken from: https://www.ruby-forum.com/topic/57805
  def wordwrap(length  = 80)
     self.gsub!(/(\S{#{length}})(?=\S)/, '\1 ')
     self.scan(/.{1,#{length}}(?:\s+|$)/)
  end

👏 👏

@milch  feedback addressed, as we have the super awesome full-word split now i enabled :newline by default, and therefore the elsif worked out pretty good 👍

Just checking in on the status of this PR - can the feedback be addressed? Everyone seems pretty positive about getting it in! 👍

Improving all fastlane tables is definitely something we should fix, it's a big issue currently. @hjanuschka, is that something you want to finish up? 🚀

@KrauseFx yeah i want to see this in.
however i worked alot on this, and the open feedback, is are just nit-picks, and i am afraid i break everything to resolve the feedback (which as a personal point of view, is not mission critical in this case)
so, how about merging this, and later on the feedback suggesters go on with it?

@googlebot thx for this, i accidentally commited with corporate email - as soon as we know how to proceed with this PR i am going to rebase then it should be fine 👍

master rebased, cla stuff sorted out.

I think not having the separators for every row looks better 👍

Moved to https://github.com/fastlane/fastlane/pull/8809 (by mistake), I addressed all of your feedback, thanks. Also some more tests and code style changes.


[Event Request] table 337 "Reservation Entry" - OnAfterSetNewTrackingFilterFromReservEntry

We would like to add a new event OnAfterSetNewTrackingFilterFromReservEntry in the following procedure:
procedure SetNewTrackingFilterFromReservEntry(ReservationEntry: Record "Reservation Entry")
begin
    //A200F0000.Event.ns
    SetRange("New Serial No.", ReservationEntry."New Serial No.");
    SetRange("New Lot No.", ReservationEntry."New Lot No.");

    OnAfterSetNewTrackingFilterFromReservEntry(Rec, ReservationEntry);
    //A200F0000.Event.ne
end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnAfterSetNewTrackingFilterFromReservEntry(var ReservationEntry: Record "Reservation Entry"; FromReservationEntry: Record "Reservation Entry")
begin
    //A200F0000.Event
end;

Function SetNewTrackingFilterFromReservEntry does not exist. Please check the latest code base.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


How to install without building (copy existing build)?

I already downloaded the SQLite amalgamation source with autoconf, extracted, and ran:
mkdir dist
export install_path=$(pwd)/dist
./configure --prefix=$install_path && make install

which generated the following
./dist
├─ bin
│  └─ sqlite3
├─ include
│  ├─ sqlite3.h
│  └─ sqlite3ext.h
├─ lib
│  ├─ libsqlite3.0.dylib
│  ├─ libsqlite3.a
│  ├─ libsqlite3.dylib
│  ├─ libsqlite3.la
│  └─ pkgconfig
│     └─ sqlite3.pc
├─ share
   └─ man
      └─ man1
         └─ sqlite3.1

So, is there a way for me to install this package and skip the build step entirely, relocating my previous build to the appropriate location?
If so, what are the steps? I couldn't find this in the docs/wiki. Thanks!

I realized that I can't do this with this package, but I need to use dblite instead.


Create a logging function

The application needs to output a log file to a OS specific temp path and output logs through the execution of the application.
Basic Functionality

Needs to create a new log file or append to one if it already exists
Log key application processes
Log verbose API responses

Current Logging

@wizedkyle I'll give this a go!


fix(java): fix TypeRef getSubType

What does this PR do?
fix TypeRef getSubType
Related issues
Closes #1604
Does this PR introduce any user-facing change?

[ ] Does this PR introduce any public API change?
[ ] Does this PR introduce any binary protocol compatibility change?

Benchmark

Hi @Munoon , could you take a look at this PR? I can reproduce the error in #1606

Hi, @chaokunyang. LGTM.


fix: remove tslint rule that requires type info

tslint rules that require type info can cause problems in editors (vscode in particular).  See https://github.com/Microsoft/vscode-tslint/issues/70

LGTM, thanks!


Combine spec and X-Ray backend attributes into python template

Description:
Similar to https://github.com/aws-observability/aws-otel-test-framework/pull/383, this PR is meant to update the template to incorporate BOTH the spec defined attributes and the attributes we need the Collector to set for the X-Ray backend to read https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/6109
Merge once https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/6109 is FIXED.
Link to tracking Issue:
Fixes #170
Testing:
Read more about why we know these are the changes we need in https://github.com/aws-observability/aws-otel-test-framework/pull/383. Once this merges the main-build.yml for Python should start passing again.
Documentation:
N/A

Blocked on LambdaComponents v0.15.0 release.

Most recent Canary CI shows that [3].subsegments[1].aws.operation is correctly set to "ListBuckets".


[HHH-18507] allow overwriting the default db image with environment variable in docker_db.sh

…ariable in docker_db.sh
https://hibernate.atlassian.net/browse/HHH-18507

If approved, I will make similar changes to the 6.6 (in WF.next), 6.4 (in WF currently), and 6.2 (in EAP) branches.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

Thanks @simkam for the PR and @beikov for the review.


callback error must be non literal?

I was wondering if we could have no-callback-literal rule to correspond with the no-throw-literal rule.
Basically, if you're using the callback pattern this should never be okay:
callback('error')

instead you should do something more like this:
callback(new Error('error'))

We already built this locally, so let me know :)
See: https://github.com/eslint/eslint/issues/6427

Yeah, I think this is a good idea. I like your list of callback, cb, and next. However, there's definitely a chance that there might be lots of false positives, but let's give it a try!
If you send a PR, I can test it with the test suite and see how many repos start failing -- and how many of those are valid vs. invalid.

Oh yeah let me do the PR today

Will get back to this today :)

Nice :)
On Tue, Sep 13, 2016 at 7:01 AM Jamund Ferguson<EMAIL_ADDRESS>wrote:

Will get back to this today :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/xjamundx/eslint-plugin-standard/issues/12#issuecomment-246690840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHbpq-XXI9oeAjNNTPsITPvfBFnicpQks5qpqywgaJpZM4JQSHV
.

Here's what we're using at work....Will need to make it a bit more configurable. PR will come once I actually start working this morning...
'use strict';

//------------------------------------------------------------------------------
// Helpers
//------------------------------------------------------------------------------

function isCallback(name) {
  return ['callback', 'next', 'cb'].indexOf(name) > -1
}

/**
 * Determine if a node has a possiblity to be an Error object
 * @param  {ASTNode}  node  ASTNode to check
 * @returns {boolean}       True if there is a chance it contains an Error obj
 */
function couldBeError(node) {
  switch (node.type) {
    case 'Identifier':
    case 'CallExpression':
    case 'NewExpression':
    case 'MemberExpression':
    case 'TaggedTemplateExpression':
    case 'YieldExpression':
      return true; // possibly an error object.

    case 'AssignmentExpression':
      return couldBeError(node.right);

    case 'SequenceExpression':
      var exprs = node.expressions;

      return exprs.length !== 0 && couldBeError(exprs[exprs.length - 1]);

    case 'LogicalExpression':
      return couldBeError(node.left) || couldBeError(node.right);

    case 'ConditionalExpression':
      return couldBeError(node.consequent) || couldBeError(node.alternate);

    default:
      return node.value === null
  }
}

//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------

module.exports = function(context) {

    return {

      CallExpression: function(node) {
        var errorArg = node.arguments[0]
        if (errorArg && isCallback(node.callee.name)) {
          if (!couldBeError(errorArg)) {
            context.report(node, 'Unexpected literal in error position of callback.');
          } else if (node.arguments.length > 1 && errorArg.type === 'Identifier') {
            if (errorArg.name === 'undefined') {
              context.report(node, 'Expected null instead found undefined.');
            }
          }
        }
      }

    };
};

What's wrong with using:
if (err) {
  console.error(err);
  return next('Something went wrong');
}

In Express.js error handling works like that: https://expressjs.com/en/guide/error-handling.html

@pakastin I think it should work as long as you're not passing a string

Oh, true – I meant that if you want to customize error messages:
if (err) {
  console.error(err);
  return next('DB error: user');
}

@pakastin so the way this rule would suggest doing that is:
if (err) {
  console.error(err);
  return next(new Error('DB error: user'));
}

The benefit is that using an error object, will keep the message (as the message property, but it will also give you stack property so you can see exactly where the error was called!)

Oh, that's nice!

This just hit me in a non-error case. There are definitely valid use cases where you pass a string that's not an error.

This also seems to match
callback({foo: 'bar'})

which definitely is prone to lots of false positives.

Guys, this also matches
callback({foo: somevariable})

Stop it already :-D

Ran into this rule while writing some tests and passing in a couple numbers into a parameter called 'callback.'  Got around it by renaming the parameter to aFunc.  There's no real pattern matching going on here, just looking for some parameters of certain names it seems (which doesn't seem like a worthwhile use of a linter to me).  Probably worth at least revisiting this test...

.catch(() => callback(false)); // eslint-disable-line standard/no-callback-literal

The line comment saved me

I got this lint error in an unrelated context, I think just from using an argument named callback...
In my case, nothing to do with error handling, I've got an es6 class listening to and relaying events on another module with a custom on function:
on (event, callback) {
    otherModule.on(event, (...args) => {
      callback(...args)
    })
  }

We should probably make an exception for the spread operator!
On Sat, Aug 19, 2017 at 7:23 PM Tim Kinnane<EMAIL_ADDRESS>wrote:

I got this lint error in an unrelated context, I think just from using an
argument named callback...
In my case, nothing to do with error handling, I've got an es6 class
listening to and relaying events on another module with a custom on
function:
on (event, callback) {
otherModule.on(event, (...args) => {
callback(...args)
})
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xjamundx/eslint-plugin-standard/issues/12#issuecomment-323559096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPBf7_NqqvbTyQWRHZhnynCPiMO3mDTks5sZ5iVgaJpZM4JQSHV
.

We should probably make an exception for the spread operator!

You should drop the rule entirely guys. This simply has too many false positives.

Agree with what's been said about this rule being silly. Passing a string is valid in a lot of use cases, especially for testing.

@feross I'm basically fine removing this rule, I've personally moved to async/await instead of callbacks wherever possible and it's clear that a lot of people don't want to follow the callback-pattern strictly.

Opened an issue to discuss removing this rule: https://github.com/standard/eslint-plugin-standard/issues/27


Allow setting reserved padding width

Describe the problem
I have a workflow like this:
(1) When I open nvim in full-screen (ui_width=255), I'd like no-neck-pain to open a left padding of width=84 (about 33%).
(2) When I open a single file, I snap it to the right/left half of the screen, then the terminal's width is 127. In this case, I don't want no-neck-pain to open any padding.
I tried setting option NoNeckPain.config.width = 128 and (2) works, no padding when the terminal is snapped to half screen. However, when I resize the terminal to full-screen, the left padding only has width=63, not 84. Therefore, the text is shifted a bit to the left, harder to read.
The interesting thing is, when I don't set NoNeckPain.config.width, the left padding is 84, but the snapped terminal has left padding in this case.
Describe the solution
I read the code a bit and see this line. The padding is calculated from the NoNeckPain.config.width, so the larger the width, the smaller the padding. I'm not sure if I got the intention, but isn't it better if we do something like math.floor(width * NoNeckPain.config.reserved_padding_percentage - paddingToSubstract)? Then one can set reserved_padding_percentage = 0.33 in the config. What do you think?

Hey, thanks for opening the issue!

However, when I resize the terminal to full-screen, the left padding only has width=63, not 84. Therefore, the text is shifted a bit to the left, harder to read.

This seems expected if you have enabled each side buffers, as it would mean there's 127 width left, 63 on each side.

I'm not sure if I got the intention, but isn't it better if we do something like math.floor(width * NoNeckPain.config.reserved_padding_percentage - paddingToSubstract)? Then one can set reserved_padding_percentage = 0.33 in the config. What do you think?

To me it's a different approach. In this plugin, width defines "the width of the main focused window", I thought it would be easier for users to define it, as it could match to the maximum length of a line or things like this.
Your solution could work, but it seems a bit harder to use for a user, or maybe I did not get the usage?

Oh ok I see. It makes more sense when I enable both sides. But seems like there is some confusion in the definition of width:

the width of the main focused window (you wrote above).
the width that when the terminal size is smaller than it, we don't create side buffers.

I only use left buffer, and now I'm setting width as the latter definition to prevent creating side buffer when terminal size is 127 (half screen). The goal I want is to remove the padding in the picture below, without making the padding smaller in full-screen mode.

What do you think 😊?

I only use left buffer, and now I'm setting width as the latter definition to prevent creating side buffer when terminal size is 127 (half screen). The goal I want is to remove the padding in the picture below, without making the padding smaller in full-screen mode.

Indeed it's weird, if the screen is 255 and you've set 127 or 128 there shouldn't be padding, I'll try to reproduce locally and see if it's a confirmed bug!

note: maybe instead of checking if the terminal width can host width + side buffer, it should add a small arbitrary value like 10 since a padding of 10 wouldn't bring much to the user.

ok so indeed things that might make sense on smaller screens (picture 1), might not make sense on larger ones (picture 2), which are both snapped to the side of the screen, taking ~50% of the width.
As Vim is not aware of the screen size, it makes sense not to be able to support those behaviors, but we could introduce a "minimal acceptable padding" value to decide displaying them or not (picture 2 has a padding of 5 for example, which is pretty much irrelevant)


Explore if python's docstring delimiter rule is redundant

...and probably covered in all cases by just "--sql (one double quote).

It's not somehow


Checkbox group field

Add two components:

<CheckboxGroupField />
<Form.CheckboxGroupField />

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make locale json data have consitently same order

Checklist

[ ] At least one test case is included for this feature or bug fix.
[ ] ReleaseNotes has added or is not needed.
[ ] This PR has passed all of the test cases on Nodejs and Chrome Browser.
[ ] This PR has passed all of the test cases on QT/QML.
[ ] This is an API breaking change.
[ ] Requires a major version change.

Issue Resolved / Feature Added

Use json-stable-stringify package in cldr tool codes. only except for jsoncompress.js which cause circleCI build failure that is difficult to fix.
clock.js files and ctype_*.json files are updated by sorted.
Re-running all toe cldr tool code to have sorted locale data work will be done in different branch.

Resolution
Links

@ehoogerbeets As we dicussted yesterday, I took out the json-stable-stringify usage in jsoncompress.js file. and there's no circleCI failure. At least  we can expect to see the only real difference whenever we make PR with locale data change.
Regenerating all the data to have sorted, will be done in different branch because it's going to be huge change.


Make billing postcode optional for OMIS orders

postcode in CRM is optional.
We copy the address and store it on the order on quote creation so this makes sure postcode is optional in OMIS as well.

Codecov Report

Merging #714 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #714   +/-   ##
========================================
  Coverage    96.55%   96.55%
========================================
  Files          138      138
  Lines         4093     4093
  Branches       384      384
========================================
  Hits          3952     3952
  Misses          90       90
  Partials        51       51

Impacted Files
Coverage Δ

datahub/omis/order/validators.py
97.92% <ø> (ø)
:arrow_up:

datahub/omis/order/serializers.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4f891...02ff6ac. Read the comment docs.


[Feature Request] Option to move findbar to the bottom

When used alongside floating toolbar, they both can overlap temporarily, please add the bottom option for better synergy.

An option for it is in development. I didn't bring it to this version because there's a weird bug caused by Firefox where the entire webview is moved sightly up when the find bar is at the bottom


Improve RTL support in HTML-CSS

Add CSS to prevent browser interference

Fixes #1250

Marking this WIP in the hopes of doing something about #1252. But perhaps that's too optimistic.

I would like to add the fix for Edge before merging this. But that can wait until the beta is out.

Added a fix for #1252, including browser detection for MS Edge in MathJax.js.
Ready for review.

Hold off on that review. A more extensive browser test revealed additional issues on IE.

Adding the Edge hack for MSIE might be sufficient for the time being.
To be precise: using http://codepen.io/pkra/pen/MaYeBZ I see

IE11 and IE10

all clear
without Edge hack: 1,6,8 get processing errors

IE9:

failed: 3,4, 7 get processing errors, 6 (stray p node in first part)
without Edge hack: 1, 3, 4, 6, 7, 8 get processing errors

IE8:

failed: 1 (layout: full underline), 6 (processing error in first part), 8 (layout: full underlines)
without Edge hack: 1, 6, 8 get processing errors

IE7:

1 (layout: full underline), 6 (stray p node in first part), 8 (layout: full underlines)
without Edge hack: 1, 6, 8 get processing errors

I think it's ready for review as the remaining issues seem to be upstream issues. (I suspect the improvements from 2.5 never worked on older IE :-( )

@pkra, if you are updating the branch, you should also change FastHTML to PreviewHTML since that is what we ended up deciding on as the final name for the old output mode.

you should also change FastHTML to PreviewHTML

Wrong issue? I think you mean https://github.com/mathjax/MathJax-dev/pull/14, correct?

OOPS, sorry, too many windows open at once.  Yes, that is the correct issue.

I wrote earlier:

I suspect the improvements from 2.5 never worked on older IE :-(

I actually confirmed that later but never reported here. So for the record, there are no regressions as far as I can tell only improvements.


Pi3B+ OSError: [Errno 22] when "100" passed to backlight.brightness, value = 258

In Raspberry Pi OS 32-bit (Pi3B+) Python 3.7.3, if I set backlight.brightness = 100, the value passed to the OS is 258 and should be limited to 255.
https://github.com/linusg/rpi-backlight/blob/a7b4b619f5adf16502aa7b18571098814b0bbac0/rpi_backlight/__init__.py#L96
This causes an OSError: [Errno 22] Invalid argument error. Maybe it would be a good idea to sanitize the output of _denormalize_brightness?
https://github.com/linusg/rpi-backlight/blob/a7b4b619f5adf16502aa7b18571098814b0bbac0/rpi_backlight/__init__.py#L105-L106
Thanks for your time writing this useful library!
EDIT: Forgot to mention library is 2.3.0

PR created: #35

Hi @linusg,
May I ask when you plan to release a new version of the library with the changes I submitted? I'm looking at my options at the moment as I'll ship the project possibly next week.
Thanks for your time and help! very useful!

Thanks for the ping, just released v2.4.0 here on GitHub and on PyPI. Glad you find it useful :)

Hi @linusg
Thanks, it is very appreciated! Hopefully, our customer will appreciate our work on his screensaver!
Martin,
HiPi Industries, Canada


Problems with Webminstats after update to 17.40

I use Webminstats module http://webminstats.sourceforge.net to obtain graphs of  a lot of historic stats.
Until now there was only a minor issue with authentic theme: the Panorama General didn't display correctly.
But after updating to authentic 17.40 the Webminstats is giving errors.
If I switch back to Virtualmin Framed theme, everything works OK.
This is the error message I get when selected some graphs:
Can't locate JSON.pm in @INC (@INC contains: .. . /usr/libexec/webmin /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ../authentic-theme/authentic-lib.cgi line 3302.
BEGIN failed--compilation aborted at ../authentic-theme/authentic-lib.cgi line 3302.
Also when I select Panorama General, the circle in the middle stays spinning forever

Hi,
Just install JSON module.
https://github.com/qooob/authentic-theme/issues/330


libreoffice: dark mode does not work

Describe the bug
A clear and concise description of what the bug is.
There is no way to enable dark mode in libreoffice. The system mode (GNOME) is set to dark and the settings are set and yet it's still light themed.
Steps To Reproduce
Steps to reproduce the behavior:

Open any version of LO
Set Options -> View -> Appearance -> Mode to "Dark"
Observe no change in theme, even upon restart.

Expected behavior
A clear and concise description of what you expected to happen.
It should "just work".
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
https://github.com/NixOS/nixpkgs/issues/294500
Notify maintainers

@7c6f434c
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
e9be42459999a253a9f92559b1f5b72e1b44c13d
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

can't reproduce, though fwiw I'm on sway

Hmm, seems to be broken indeed on X11, but annoyingly it doesn't complain about anything

Interesting, I'm on GNOME Wayland. I'll try it on sway.

My X11 testing is with a minimal WM (no DE and no X11 compositor)

I noticed a similar complaint in another issue:
https://github.com/NixOS/nixpkgs/issues/298926#issuecomment-2135399907

This is because GTK3 has obscene semantics with respect to how themes load, seemingly -dark makes the theme inapplicable to GTK3 apps, for whatever reason.

(Probably X11-only)

I'm on Wayland (GNOME) and have the same issue as described by OP. My GNOME is set to dark mode, LibreOffice is set to "System". Even after changing LO to "Dark", applying and restarting the theme stays light.
Curiously this only happened after I did my latest update, my current LO version is <IP_ADDRESS>, GNOME is on version 46.

I have the issue too :(


[designspaceLib] Provide fallback for elidedFallbackName

Provide a fallback for the DS-wide elidedFallbackName.
This is a bit unfortunate, because the DesignSpaceDocument.elidedFallbackName is a string, not a localization dict. However, if it is not set by the user, we just insert a generic English "Regular". Still better than having an empty style name.
This also fixes a bug where a RIBBI style would end up with a style mapping like stylemapfamilyname="Source Serif 4 Bold Italic" stylemapstylename="regular". RIBBI styles should not be part of the style map family name.
Closes https://github.com/fonttools/fonttools/issues/2877.


Implement transform function for asset data

What
We need to implement a function that transforms the information we get about assets from the new ingestion system into a form suitable for BigQuery. Part of #33.
Why
This function will be used when exporting asset information from the CLI.

We no longer need this. We cannot recreate the ids in the history_assets table. There's no need for a transform function.


Package and dev dependencies have reported vulnerabilities.

The project uses outdated dependencies (older versions) which have publically reported vulnerabilities. The versions should be updated and tested so that the existing code base doesn't break.

Closing as resolved in PR #16 .


blog/nixos-home-router: fix hook for the nat prerouting chain

Not sure if you accept corrections by pull request, but hey :-)
Thanks a lot for this article, I used it recently as documentation for migrating my own home router from iptables / networking.nat.* to nftables. I noted this error in the article which took me a few minutes to debug (in hindsight, it's fairly obvious...). Let's try to save some time for future readers!

Depending on the correction, I do accept them. In this case it makes sense (although generally I'd say people should pay attention when just copy/pasting things from the internet, certainly firewall stuff).


fix csr dev server evaluates user modules

fixes https://github.com/solidjs/solid-start/issues/519
I don't think that this is going to break anything but I haven't run tests cause I'm not sure how to make playwright work.

Hmm.. it did seem to break a bunch of the tests. I will have to review this more closely.

Ok I've done some work here. The async imports break the tests. I managed to solve this at the Vite plugin level. But the real challenge here is I think not importing fileRoutes breaks API and server function routes. So I'm not sure that will fly even for dev. I don't have a good answer here at least for the server functions as someone could put something top level that is client only and if they don't wrap it in a !isServer then we are pulling it in. API routes that is much less likely to happen though. Not sure if @nksaraf has thoughts. My first temptation though is to at least merge this and my work heading in this direction even if it doesn't quite solve the full problem yet.

This is actually merged but I botched it a bit. Just closing here. You will see the merge commit in the repo.


QR spelling

For @poljar.

For @poljar.

As in, you're PRing this on poljar's behalf? Or you're marking this for poljar's attention?


Don't swallow exceptions and give a generic message

https://github.com/websightgmbh/l5-google-cloud-storage/blob/master/src/Websight/GcsProvider/CloudStorageServiceProvider.php#L48
Throwing a generic message inside an ErrorException is not really helpful here and doesn't assist with troubleshooting configuration.
I'd suggest just removing the try catch block entirely.

Thanks for pointing the smell out. Very appreciated.

:+1:


[TACHYON-811] Trim trailing whitespace from exception message.

Follow up to #1327 to clean up the error message.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4310/
Test FAILed.


Option for more than one transition

Is it possible to implement this with more than one transition? For instance, slide right/left based on whether or not the user is going forwards or backwards in history.

Made it work with these suggestions https://github.com/reactjs/react-router/issues/1209


[Android web] wasm issue

I have the floating issue, when transactions not completing. This bug appears only on Android web (on other platforms everything works well). I am following the documentation and it seems i do all correct. What i need to check fo first?

I need more information about how you're setting up the database and what error you're getting (or does the transaction just hang forever?)

@simolus3 the transaction is just hangs forever.
I am using a prebuilt drift_worker.js file and sqlite3.wasm (drift version is 2.19.1 and files for this version)

Function that opens a database connection for web
import 'package:drift/drift.dart';

import 'package:drift/wasm.dart';

DatabaseConnection openDatabaseConnection(String name) {
  return DatabaseConnection.delayed(
    Future<DatabaseConnection>(() async {
      final WasmDatabaseResult result = await WasmDatabase.open(
        databaseName: name,
        sqlite3Uri: Uri.parse('sqlite3.wasm'),
        driftWorkerUri: Uri.parse('drift_worker.js'),
      );

      if (result.missingFeatures.isNotEmpty) {
        print('Using ${result.chosenImplementation} due to unsupported '
            'browser features: ${result.missingFeatures}');
      }

      return result.resolvedExecutor;
    }),
  );
}

The example of a query
@override
  Future<void> createOrUpdateBooking(Booking booking) async {
    await _database.transaction(() async {
      if (booking.contact != null) {
        await createOrUpdateContact(booking.contact!);
      }

      await _updateBookingTags(booking.tagIDs, booking.id);
      await _updateBookingTables(booking.tableIDs, booking.id);

      await _database.bookingsDao.createOrUpdateBooking(
        BookingMapper.toDatabase(booking, _restaurantId),
      );
    });
  }

Future<void> _updateBookingTags(
    List<String> tagIDs,
    String bookingId,
  ) async {
    await _database.transaction(() async {
      await _deleteTagsByBookingId(bookingId);
      await _addAllTagsToBooking(tagIDs, bookingId);
    });
  }

@simolus3 and without transactions queries are not completed. My usage:

open web app
make 3-5 queries
after that queries are not completing
if I need queries to start working again, I restart Chrome

This issue sounds related to something fixed with the drift_worker.js file from version 2.19.1. I'll take another look though.
To help me reproduce this, could you run your app once with this patched drift dependency?
dependency_overrides:
  drift:
    git:
      url: https://github.com/simolus3/drift.git
      ref: wasm-logs
      path: drift

It will make drift emit logs for every request sent to the worker. Those logs might contain sensitive information, you can post them here or send them to me at<EMAIL_ADDRESS>if you're more comfortable with that. Seeing the logs will hopefully make it much easier for me to find the exact sequence of steps necessary to reproduce this.

@simolus3 sent logs to your email.
This is small part when database is not working. After logs from chucker i am trying to sync data i database and after that nothing happened.
main.dart.js:58726 [IN]: SuccessResponse (id = 452): Instance of 'minified:U5'
main.dart.js:58726 [OUT]: Request (id = 465): StatementMethod.select: SELECT * FROM "booking_with_booking_tag_table" WHERE "booking_id" = ?; with [19]
main.dart.js:58726 ChuckerFlutter: Your notification setting is off. You can turn it on by visiting the settings page from Chucker Flutter screen.
main.dart.js:58726
main.dart.js:58726 ChuckerFlutter: Your notification setting is off. You can turn it on by visiting the settings page from Chucker Flutter screen.
main.dart.js:58726
main.dart.js:58726 [OUT]: Request (id = 466): RunTransactionAction(NestedExecutorControl.beginTransaction, null)

I have a similar issues, try running with the debug version of sqlite.wasm
https://github.com/simolus3/sqlite3.dart/releases/tag/sqlite3_flutter_libs-0.5.22
Somehow I can't reproduce it with that. Is it the same for you?

Thanks a lot for the details @AlxSidenko! I think I have found the problem and fixed it in https://github.com/simolus3/sqlite3.dart/commit/a686c52fc4822970abbd640fe9c06bf6e230fb1e.
I can't reproduce the issue with that commit. Applying it requires a new drift worker but no code changes (https://storage.googleapis.com/simon-public-euw3/assets/drift/drift_worker.js). Could you check if you can still reproduce the problem with the updated worker?

@simolus3 I've been using the app for 20 minutes now and it's working great. Thank you for your work and for your wonderful library.


x86-16 real mode: CALLF analysis introduces incorrect DATA reference.

When disassembling an old 16 bit real-mode turbo pascal application, many CALLF instructions incorrectly introduce a DATA reference.
Expected behavior
Only an UNCONDITIONAL_CALL reference is created.
Screenshots

Environment (please complete the following information):

OS: Arch Linux 64 bit
Java Version: 15.0.2
Ghidra Version: 9.2.4
Ghidra Origin: Arch Linux repositories

We will probably need the entire function code snippet to make head-or-tails as to why this is happening.

We will probably need the entire function code snippet to make head-or-tails as to why this is happening.

What do you need exactly? The original exe file? A ghidra project that
has the executable? A textual listing?
Thanks for helping with this!
Greetings, Peter

@ecraven, we can start with a textual listing if the function is not too large.  Otherwise it may be best to attach a *.gzf file if that is possible.


x/pkgsite: source links don't work for non-proxy getters

If you serve a local module with cmd/pkgsite, the links to source files are wrong.
We should at least make them file: URLs. That will get you to the file, assuming you are browsing on the same machine as the directory. It won't take you to a specific line. It also won't help with zips, which are served directly from the module cache when the -cache flag is given. But it's better than the broken links we have now.

The solution uses a /files endpoint on the server, for more flexibility.


procrastinate_fetch_job can end up being slow

Following discussion from Discord starting here and below, it seems we could vastly improve the performance of procrastinate_fetch_job.
The following query plan was posted.

Welcome to the club of Joa(qu|ch)im procrastinators !
Btw, as the repo maintainer, I opened the issue tracking the discussion but @TheNeedForSleep is the one deserving praise for this.
Feel free to chime in in the PR rather than here, the author is more likely to react.
As to myself, I'm sorry but I was much to busy lately to start evaluating this. That said, thank you for your interest and welcome around !

If two or more workers fetch a job with the same lock one of them will have a unique constraint violation on the update part.
If it fails to update due to unique constraint it will retry upto 3 times with fuzzy delay to avoid race condition.
If the worker still fails to get a job it will just get a job where no unique constraint violation can occur e.g. a job without a lock.


plantuml style Issue with Korean

Hi.
I got a style issue with rendering plantuml.
When plantuml diagram renders in IDE preview.
It looks great

But when it renders into html with this action.
Korean style crashes.

I guess it's related to teexLength Attribute of test elements
Is there a option for styling plantutml ?
or making it look as same as preview ?

Hello! Apologies for the delayed response. We've identified the issue you mentioned and have created a YouTrack ticket for it. You can track the progress of the resolution through this link: YouTrack Issue - WRS-5151. Thank you for bringing this to our attention!


S3 events not correctly delegated to the aliased functions

If you add a S3 event to your service the event will trigger the $LATEST version instead of the deployed alias.
Expectation: The trigger should call func:alias.

Bug, because it is not yet handled -> Feature, because the solution will/must lead to per-alias buckets if buckets emit S3 events. Otherwise an uncontrolled trigger of all deployed aliases would happen.

@HyperBrain would like to help with this feature but not sure where to start.  Could you provide any direction?  Thanks.

@justinffs In general, the S3 triggers should be handled in the plugin in a similar way as the other event triggers (the code is located in the stackOps folder). I think they move the trigger and the trigger permission resources to the alias stack and replace the function references with the alias references (ref to the alias resource).
So you'd have to copy one of the other event stackops and change it to use the S3 trigger resources. Then add the stackOp to the general execution order (somewhere near the others).
I'm quite sure that the same handling for S3 triggers would work the same way.

In the end we have to check if my comment above (https://github.com/HyperBrain/serverless-aws-alias/issues/73#issuecomment-330912022) is valid or not (the per alias bucket). Maybe it's not valid.

hey
was there anything new on this issue?


ValueError: No valid path is found for training.

I followed the instructions for "test" folder
when I try to run
python -m vall_e.train yaml=config/test/ar.yml
running on linux and my files are
.
├── config
│   ├── LibriTTS
│   │   ├── ar-quarter.yml
│   │   ├── ar.yml
│   │   ├── nar-quarter.yml
│   │   └── nar.yml
│   └── test
│       ├── ar.yml
│       └── nar.yml
├── data
│   └── test
│       ├── test.normalized.txt
│       ├── test.phn.txt
│       ├── test.qnt.pt
│       └── test.wav
my ar.yml is
data_dirs: [data/test]
model: ar-quarter
batch_size: 1
eval_batch_size: 1
save_ckpt_every: 500
eval_every: 500
max_iter: 1000

I ran into the same problem. I needed to have two different pairs of files (.wav and .txt) to make it work.

I ran into the same problem. I needed to have two different pairs of files (.wav and .txt) to make it work.

thank you that did the trick

Hello. What do you mean by two different pairs of files? I have the .qnt.pt and phon.txt and normalized.txt and wav files under my directory  data/librosa
the config files are config/librosa  with the ar.yml.

I ran into the same problem. I needed to have two different pairs of files (.wav and .txt) to make it work.

Your phenome files need to have between 10 and 50 phonemes in them. Try using shorter audio clips, even 10 second clips can be too long.

Your phenome files need to have between 10 and 50 phonemes in them. Try using shorter audio clips, even 10 second clips can be too long.

My training samples are longer usually. I increased the max_phon = 5000. Would this reduce performance?

I figured out the issue after some debugging with the help of chatGPT.


docs: ADR 018 Network Upgrades

Overview
ADR for social upgrades, still a work in progress in that we still need to finalize a few decisions before moving to the implementation detail phase, but this ADR is ready for the first round of reviews.
Related to ADR 016
rendered
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

per sync discussion, instead of halting the chain, we can encode a rule where after a specific height we increase the community tax to 100%

converting to a draft and might close, as there's not that much useful info in the ADR atm. Single binary syncs will cover upgrades, we are not using any form of halt height. We want to use some signaling mechanism, but don't know what that will look like.
perhaps after we add more detail on the signalling mechanism this will be worth merging.

Codecov Report

Merging #1562 (8fc1d13) into main (8eff970) will increase coverage by 0.07%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   20.58%   20.65%   +0.07%
==========================================
  Files         132      131       -1
  Lines       15296    15241      -55
==========================================
  Hits         3148     3148
+ Misses      11846    11791      -55
  Partials      302      302

see 4 files with indirect coverage changes

Have updated this PR and it's ready for review now. I think the major remaining point of discussion is on phase 2: https://github.com/celestiaorg/celestia-app/blob/evan/adr-018-social-upgrades/docs/architecture/adr-018-network-upgrades.md#phase-2-signaled-upgrade-height


Flaky: Tests failing due to failed cluster setup

Context

Test Case

Between 3 and 50 ones.
Failure / Counter-example
Instance:
50 failures
First
Waited longer than 90s to resolve action: "Byron wallet has assets".

but also
    expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 1161 % 5000}})

At the end.
3 SHELLEY_STAKE_POOLS failures (previously #2719 )
12 reward failures (previously #2715 )
  src/Test/Integration/Framework/DSL.hs:971:11:
  4) API Specifications, SHELLEY_MIGRATIONS, SHELLEY_MIGRATE_09 - Can migrate a wallet that has rewards.
       0 does not satisfy (> 0)
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 80d4f7f25280fa3c07917624d9698613dd7a6e86}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity =<PHONE_NUMBER>00}, total = Quantity {getQuantity =<PHONE_NUMBER>00}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "MIR Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-06-02 10:19:40.252167 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 3198}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 63}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 48}}}, time = 2021-06-02 10:21:10.6 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1266}}}}))
       Waited longer than 90s to resolve action: "MIR wallet: wallet is 100% synced ".

  To rerun use: --match "/API Specifications/SHELLEY_MIGRATIONS/SHELLEY_MIGRATE_09 - Can migrate a wallet that has rewards./"

  src/Test/Integration/Framework/DSL.hs:971:11:
  5) API Specifications, SHELLEY_TRANSACTIONS, SHELLEY_TX_REDEEM_01 - Can redeem rewards from self
       0 does not satisfy (> 0)
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 66d96c026bab93dc351e62e3912c9453c90457b4}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity =<PHONE_NUMBER>00}, total = Quantity {getQuantity =<PHONE_NUMBER>00}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "MIR Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-06-02 10:25:26.303106 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 4950}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 99}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 0}}}, time = 2021-06-02 10:27:01 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1510}}}}))
       Waited longer than 90s to resolve action: "MIR wallet: wallet is 100% synced ".

Resolution
The syncing problems might be caused by the previous mass-failures. Think just fixing the setup rollback problem would solve it.

QA

Should hopefully be fixed now.


emit view->events.destroy on xwayland unmap

Emits the view destroy signal when an xwayland view is unmaped.
This makes sure, no references to it are held, and fixes a few
situations where inconsistent view state could lead to segfault.
This fixes the segfaults, but I am honestly not sure, if it could introduce other issues.
Quick testing doesn't expose anything obvious, but there may be more complicated issues.
Relevant issues:
https://github.com/swaywm/wlroots/issues/705
https://github.com/swaywm/wlroots/issues/679
https://github.com/swaywm/wlroots/issues/671
https://github.com/swaywm/wlroots/issues/650
The view_finish in desktop.c uses the same libwayland signal emit.
Should we change that (in another PR)?

This fixes the segfaults, but I am honestly not sure, if it could introduce other issues.

I think handle_map_notify needs a call to view_initial_focus, otherwise seat_add_view is not called and the view is not inserted in seat->views.

The view_finish in desktop.c uses the same libwayland signal emit.

If we don't get issues with destruct listeners removing the next listener, I don't think this is necessary. Weston uses wl_signal_emit without issues.

My first impression is that this is an abuse of the destroy signal because it gets emitted without the actual surface being destroyed.

This was pretty much a bandaid level PR to reduce the crashyness, and is discontinued in favor of https://github.com/swaywm/wlroots/pull/711#issuecomment-372485427
I should probably just close it.
That PR gives us explicit map/unmap to be handled by the compositor, so this little hack isn't required.


[python] Experimental readthedocs [WIP / please do not review]

Issue and/or context:
Changes:
Notes for Reviewer:

Codecov Report
Patch coverage has no change and project coverage change: +30.51 :tada:

Comparison is base (82ec538) 60.73% compared to head (c2e5eeb) 91.25%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1076       +/-   ##
===========================================
+ Coverage   60.73%   91.25%   +30.51%
===========================================
  Files          81       30       -51
  Lines        5891     2263     -3628
===========================================
- Hits         3578     2065     -1513
+ Misses       2313      198     -2115

Flag
Coverage Δ

python
91.25% <ø> (ø)

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

R/utils-arrow.R

R/SOMAArrayBase.R

inst/tiledb/include/tiledb/utils.h

inst/tiledb/include/tiledb/vfs.h

inst/tiledb/include/tiledb/schema_base.h

inst/tiledb/include/tiledb/type.h

inst/tiledb/include/tiledb/stats.h

inst/tiledb/include/tiledb/context.h

inst/tiledb/include/tiledb/query.h

src/rutilities.h

... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Obviated by #1094 -- thanks @ebezzi !!


The segmentation results for some images are incorrect.

Hello, I found that when executing the referring expression segmentation task, the output masks for some images of people and animals appear to be completely incorrect. Could this be due to incorrect node parameter settings?
By the way, is there any documentation that explains the meanings of the node parameters?

The model in general is just not very good at segmentation, would recommend checking out Florence+SAM2 instead:
https://github.com/kijai/ComfyUI-segment-anything-2

Thank you, I'll take a look at that.


X-Forwarded-Proto is overwritten in traefik ≥ 1.6.x

Do you want to request a feature or report a bug?
Bug
What did you do?
I noticed this issue when upgrading from traefik 1.5.4 to 1.6.x. Because many of our services started showing erratic behavior, with redirect loops or attemping to load resources from HTTP instead of HTTPS.
We are running traefik inside of a docker cluster and we have an edge loadbalancer in Google Clodu that handles SSL termination.
The cause of this seems to be that the X-Forwarded-Proto header is being rewritten by traefik in ≥ 1.6.x.
This was easy to confirm when running the whoami service, this is the output when running it in our environment with traefik 1.5.4:
Hostname: ...
IP: ...
GET / HTTP/1.1
Host: ...
User-Agent: curl/7.54.0
Accept: */*
Accept-Encoding: gzip
Via: 1.1 google
X-Cloud-Trace-Context: ...
X-Forwarded-For: [MY_REMOTE_IP], <IP_ADDRESS>, <IP_ADDRESS>
X-Forwarded-Host: ...
X-Forwarded-Port: 80
X-Forwarded-Proto: https
X-Forwarded-Server: ...
X-Real-Ip: <IP_ADDRESS>

And this is the same request running traefik 1.6.6
IP: ...
GET / HTTP/1.1
Host: ...
User-Agent: curl/7.54.0
Accept: */*
Accept-Encoding: gzip
Via: 1.1 google
X-Cloud-Trace-Context: ...
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
X-Forwarded-Host: ...
X-Forwarded-Port: 80
X-Forwarded-Proto: http
X-Forwarded-Server: ...
X-Real-Ip: <IP_ADDRESS>

Both the X-Forwarded-For and X-Forwarded-Proto are overwritten by traefik in 1.6.6 which leads to the issue.
I am using the same entrypoint configuration for both versions, attached a snippet below:
[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
      regex = "^http://(.*)"
      replacement = "https://$1"
    [entryPoints.http.forwardedHeaders]
      trustedIPs = ["<IP_ADDRESS>/22", "<IP_ADDRESS>/16"]

Hi @Gabology, I did not succeed in reproducing your issue.
I chained 2 Træfik in front of a whoami and tried some configurations (trustedIPs) and versions of Træfik (1.5.X, 1.6.X, 1.7.X).

   +--------+ https +---------+ http +----------+ http +---------+
   | Client |+----->| Rproxy1 |+---->| Rproxy2  |+---->| Whoami  |
   +--------+       +---------+      +----------+      +---------+

If Rproxy2 trusts the Rproxy1 ip, we will have https
as X-Forwarded-proto
If it doesn't trust the Rproxy1 ip, we will have http because we have an http connexion between Rproxy1 and Rproxy2

Could you check your trusted ips ?

Thanks for the quick reply @jbdoumenjou
I played around a bit more with this and it seems to me that the behavior for determining client IP has changed in traefik 1.6.x from traefik 1.5.x.
FYI this is the configuration I tried with both 1.5.4 and 1.6.6.
[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
      regex = "^http://(.*)"
      replacement = "https://$1"
    [entryPoints.http.forwardedHeaders]
      trustedIPs = ["<IP_ADDRESS>/22", "<IP_ADDRESS>/16"]

In 1.6.6. like I mentioned, that configuration will not trust the X-Forwarded-* headers. However adding the actual client IP that connected through the edge load balancer will work in 1.6.6. And on the contrary in 1.5.4 the above configuration where the trusted IP is the IP of the edge load balancer itself will work, but only trusting the actual client IP that connected through the edge load balancer will NOT work.
Is it possible that the default strategy for determining client IP has changed between 1.5.x and 1.6.x?

Could you try for the v1.6.6 :
[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.whitelist]
      sourceRange = ["<IP_ADDRESS>/22", "<IP_ADDRESS>/16"]
      useXForwardedFor = true
    [entryPoints.http.redirect]
      regex = "^http://(.*)"
      replacement = "https://$1"

This configuration seems to be different between the v1.5 and the v1.6 (https://github.com/containous/traefik/compare/v1.5...v1.6#diff-ec0634b59fe8a2e061034f6643634d74)

Hi @jbdoumenjou
Yes, I can confirm that this works, but only if I set useXForwardedFor to false. Which seems to be also confirm my suspicion that traefik now uses another strategy for resolving the client IP.
Also it doesn't seem to be documented anywhere that this behavior has changed, so perhaps you should add that somewhere?
For me personally I don't see why whitelist has anything to do with the XFF headers however. That to me should just be about restricting access on the endpoint to certain CIDR ranges.

@Gabology, XFF is a way to keep the Client Ip though the proxies/load balancers.
So, it could be the source of the IP to check with the whitelist.
The ability to use it was added on the v1.6.0 https://github.com/containous/traefik/pull/3070
Indeed, it is a good idea to improve the documentation on this subject.

@jbdoumenjou ..  so if I want traefik to forward headers only for a specific CIDR, I need to set it up inside http.whitelist, and not http.forwardedHeaders > trustedIps? Hmm, what if one needs to allow traffic from 2 CIDR ranges but only want headers forwarded for 1 of them, how would that work out?

Also, is that setting congruent to that of traefik.ingress.kubernetes.io/whitelist-source-range: "<IP_ADDRESS>/24, fe80::/16" and ingress.kubernetes.io/whitelist-x-forwarded-for: "true" on the ingress level (for kubernetes setup)?

The whitelist mechanism and its documentation have been improved in v2.0, I close this issue accordingly.


storage-resize-images version 0.1.10 release notes

Codecov Report

Merging #362 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #362   +/-   ##
=======================================
  Coverage   39.77%   39.77%
=======================================
  Files          19       19
  Lines         636      636
  Branches       85       85
=======================================
  Hits          253      253
  Misses        381      381
  Partials        2        2