the python version of this repo?

Hi Yu
GOOD work! your tutorials save me lots of time. But which version of python you use?

Thanks! Glad it helped :) I think python3.7? Though any python3.* versions should work I think.


Align the tables we want to use from asm

[x] export subpel_filters
[ ] refactor the concept in a macro for further usage

Should help on #832

Coverage decreased (-0.4%) to 84.071% when pulling f4306d02ecae7db301afc18a567f222509630b14 on rust-av:align-tables into 242003cdb8051118a629dfdc72f3add985d26245 on xiph:master.

32 would be enough for all our current usage, I think?
On Wed, Jan 2, 2019, 10:09 Thomas Daede<EMAIL_ADDRESS>wrote:

@tdaede commented on this pull request.
In src/partition.rs
https://github.com/xiph/rav1e/pull/834#discussion_r244685507:

pub const SUBPEL_FILTER_SIZE: usize = 8;

-const SUBPEL_FILTERS: [[[i32; SUBPEL_FILTER_SIZE]; 16]; 6] = [
+#[repr(C, align(256))]
Looks fine, but do you really need 256 byte alignment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xiph/rav1e/pull/834#pullrequestreview-188614374, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOlpNjCRfGHTA0Zaivt1GhpJscv0QCpks5u_Hc4gaJpZM4ZmRH3
.

There seems to already be an aligned type in util.rs. https://github.com/xiph/rav1e/blob/master/src/util.rs#L133

@KyleSiefring yes, we can rework the code to use it in the macro, but I'd rather have you confirm that this approach works while I'm flying back home :)

Does not work. SUBPEL_FILTERS : Aligned = Aligned([ does work. I would like it if we could find some documentation that confirms that this behavior is defined.

Do you have the code somewhere?
On Jan 2, 2019 16:20, "Kyle Siefring"<EMAIL_ADDRESS>wrote:
Does not work. SUBPEL_FILTERS : Aligned = Aligned([ does work. I would like
it if we could find some documentation that confirms that this behavior is
defined.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xiph/rav1e/pull/834#issuecomment-450890855, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOlpOm8sXvmwDukli_wg0Y3RyR1sS18ks5u_M5GgaJpZM4ZmRH3
.

https://github.com/KyleSiefring/rav1e/tree/asm_data_in_rust_WIP_1

FYI The variable is rav1e_mc_subpel_filters and not SUBPEL_FILTERS in my code.

https://github.com/rust-av/rav1e/pull/new/asm_data_in_rust_WIP_1
this builds
On Wed, Jan 2, 2019 at 4:44 PM Kyle Siefring<EMAIL_ADDRESS>wrote:

FYI The variable is rav1e_mc_subpel_filters and not SUBPEL_FILTERS in my code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Isochrone bad request due to bucketing approach

Currently the isochrone component has this bucketing approach which makes problems e.g. for this:
/isochrone?point=48.58792,2.44357&time_limit=900&buckets=3&vehicle=foot
or here
/isochrone?point=45.74087770,4.81895470&time_limit=120&vehicle=foot
Where the bucket 0 has too few entries to calculate the polygon.

message: Too few points found for bucket 0. Please try a different 'point', a smaller 'buckets' count or a larger 'time_limit'. And let us know if you think this is a bug!

Cannot reproduce anymore with these examples, but this one fails, and probably any other one with a small enough z-value:
/isochrone?vehicle=foot&type=geojson&point=45.74087770,4.81895470&time_limit=10

Only occurs in the extreme case where the time limit is so small that we really just traverse one single node, and IMO it's okay for now to throw then.
Doesn't have anything to do with buckets anymore.


Sound Plays from Device Speaker Instead of Headphones When Playing AudioAsset.

Description

When playing an AudioAsset, the sound comes out from the device’s speaker even though headphones are being used.
Provide a Repro

Source .riv/.rev file

sent email to hello_at_rive.app with title "Rive iOS Issue #332"
Expected behavior

Sound plays from device speaker
Screenshots

Device & Versions (please complete the following information)

SDK v5.15.1
iOS v17.5.1

Additional context

@psbss This should be fixed now - the latest v6.x release contains a fix. It also adds a little more configurability by respecting AVAudioSessin settings. We created a new doc for [playing audio[(https://rive.app/community/doc/playing-audio/docuEtbvcWOm) with some iOS details.


"Known issues/migration limitations with online migrations to Azure SQL Database" needs specific link

The link of "Known issues/migration limitations with online migrations to Azure SQL Database" is pointing to Azure Database Migration Service documentation page instead of pointing to Known issues/migration limitations with online migrations to Azure SQL Managed Instance
Source:
Section Link

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 551efeed-82f0-f032-508b-61e4f76df811
Version Independent ID: 2baedd39-79e4-9c16-a691-f81502aa528f
Content: Common issues - Azure Database Migration Service
Content Source: articles/dms/known-issues-troubleshooting-dms.md
Service: dms
GitHub Login: @pochiraju
Microsoft Alias: rajpo

@abrathehuman Thanks for your feedback! We will investigate and update as appropriate.

@abrathehuman The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


support shardingjdbc database storage feature

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] New feature provided

New feature or improvement
Support shardingjdbc database storage feature, the users can use database to storage data instead of elasticsearch.

@chidaodezhongsheng Conflicts must be resolved.

@wu-sheng thanks a lot, I will resolve the conflicts and mentions.
技术部·架构部·林嘉琦
手机：18710075837
Email：linjiaqi<EMAIL_ADDRESS>QQ：928926755
发件人: 吴晟 Wu Sheng<EMAIL_ADDRESS>发送时间: 2018年5月14日 15:45
收件人: apache/incubator-skywalking
抄送: 林嘉琦; Mention
主题: Re: [apache/incubator-skywalking] support shardingjdbc database storage feature (#1220)
@wu-sheng commented on this pull request.
@chidaodezhongshenghttps://github.com/chidaodezhongsheng The implementation codes are under incubating. So you will take charge. I just reviewed the licenses and documents related things.
Some things need to change.

In apm-collector/apm-collector-boot/src/main/resources/application.ymlhttps://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353:

contextPath: /

+storage:

elasticsearch:

clusterName: CollectorDBCluster

clusterTransportSniffer: true

clusterNodes: localhost:9300

indexShardsNumber: 2

indexReplicasNumber: 0

highPerformanceMode: true

ttl: 7

+#storage:
+#  h2:
+#    url: jdbc:h2:~/memorydb
+#    userName: sa
+#storage:
+#  shardingjdbc:
ShardingJDBC is an incubating feature, no use cases yet. And none of the contributors are committer yet. So, by that, please don't put Sharding JDBC in default application.yml. Even it is under comments.

In apm-dist/release-docs/LICENSEhttps://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208:

@@ -255,6 +256,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.

 Apache: commons-configuration 1.8: https://github.com/apache/commons-configuration, Apache 2.0

 Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0

 Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, Apache 2.0

Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0

Groovy has a NOTICE file. Please change NOTICE in same folder. And follow the file structure. Ref here: https://github.com/apache/groovy/blob/master/NOTICE

In docs/README.mdhttps://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505:

Agent or collector version upgrade

+## Documents
+https://img.shields.io/badge/document-中文-blue.svg)](README_ZH.md)

Getting Started

Quick start

Supported middlewares, frameworks and libraries

 * [How to disable plugins?](en/How-to-disable-plugin.md)

Advanced Features

Override settings through System.properties or System.env

Direct uplink and disable naming discovery

Open TLS

Namespace Isolation

Token Authentication

Open Database Sharding Storage

This should a section in Incubating Features. named: Use Sharding JDBC as storage implementor.

In docs/en/Shardingjdbc.mdhttps://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734:

@@ -0,0 +1,13 @@

+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually.

+## Supported version
+5.0.0-beta +

+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory.
collector-libs is not the directory name.

In docs/en/Shardingjdbc.mdhttps://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863:

@@ -0,0 +1,13 @@

+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually.

+## Supported version
+5.0.0-beta +

+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory.
+- In config/application.yml, close the elasticsearch configuration and open the shardingjdbc configuration, multiple data source configurations should be separated by Half Comma.
Considering the sharding settings have been remove from application.yml. please add the settings in here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-skywalking/pull/1220#pullrequestreview-119711946, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbEqGIrpIAE3UB-ved15UgPFge5rUXwCks5tyTYRgaJpZM4T9MUe.

@wu-sheng thanks a lot, I will resolve the conflicts and mentions.

@wu-sheng I have merged the latest files from master branch and updated the markdown files.

Coverage decreased (-0.004%) to 23.357% when pulling 9219c31dc078764760d9eb60ec10e48080ad93b0 on chidaodezhongsheng:master into 4a20c288482552cc0b78d759fe6fba66f335da82 on apache:master.

I have added Sharding-JDBC and commons-dbcp into the maven pom file by my local project to checked the dependencies. Indeed, only added jars: groovy, sharding, dbcp.
License and notice files have been checked, correct.

@chidaodezhongsheng @oracle219 Could you finish this pr soon?

@wu-sheng OK, I will finish this pr now.

@chidaodezhongsheng You are still missing @peng-yongsheng 's review.


if used twice in a bundle, attemptts to re-download updated client every time

╭─ralph at surfacebook in ~/work/nogo/jeffhollan/azure-functions-porter on master✔ using
╰─± porter install -c AzFunctionEnvironment --param<EMAIL_ADDRESS>installing AzFunctionEnvironment...
executing install action from AzFunctionEnvironment (bundle instance: AzFunctionEnvironment)
Install nginx
Tiller version (v2.16.1) does not match client version (v2.14.3); downloading a compatible client.
...

and then later in the pipeline:
dd KEDA repo
"kedacore" has been added to your repositories
Deploy KEDA
Tiller version (v2.16.1) does not match client version (v2.14.3); downloading a compatible client.

it would be nice to be able to NOT double-download this, as you can imagine....

@squillace are the two snippets in the same (install?) step?  Can you provide the full relevant section of the porter.yaml manifest (or link)?  Thanks!

If this is still a problem, please open an issue in the helm3 repo! I'm closing this issue and archiving the repository since it has been replaced with helm3.


hope to have a way to set scope of variable

Sorry, Chinease only. I'll try to translate later.
What problem does this feature solve?
有时我希望在组件某区域渲染数据，它们都来自于data上比较深层的某一个属性，当数据量比较多时，直接使用文本插值的写法会比较繁琐，比如：
(以下为了精简代码，采用了pug、es6语法，并忽略Vue组件data必须为函数的要求)
data.js
export default {
  some: {
    deep: {
      props: {
        a: 1,
        b: 2,
      },
    },
  },
};

my-page.vue
<template lang="pug">
  div
    p {{some.deep.props.a}}
    p {{some.deep.props.b}}
</template>

我想到几种变通的做法：

使用计算属性：
my-page.vue
<template lang="pug">
  div
    p {{props.a}}
    p {{props.b}}
</template>

这样做相对简单，但是总要为此去定义很多计算属性似乎也有些繁琐。

利用v-for指令来缩小作用域：
my-page.vue
<template lang="pug">
  div
    template(v-for="props in [some.deep.props]")
      p(ref="a") {{props.a}}
      p(ref="b") {{props.b}}
</template>

这是一个取巧的做法，但也有副作用：用$refs访问v-for范围内的ref引用会变成数组。

将数据渲染区域定义为子组件，子组件接受简化后的数据：
data-view.vue
<template lang="pug">
  div
    p {{props.a}}
    p {{props.b}}
</template>

my-page.vue
<template lang="pug">
  div
    data-view(:props="some.deep.props")
</template>

子组件内部的写法能简化许多，但是整体花销仍然不小。一个额外的问题是，子组件多引入了一个可能原本并不必要的包装根元素。

利用子组件作用域插槽来封装一个通用的辅助组件：
sub-scope.vue
<template lang="pug">
  div
    slot(:sub="data")
</template>

my-page.vue
<template lang="pug">
  div
    sub-scope(:data="some.deep.props")
      template(slot-scope="scope")
        p {{scope.sub.a}}
        p {{scope.sub.b}}
    // or
    sub-scope(:data="some.deep.props")
      template(slot-scope="{sub}")
        p {{sub.a}}
        p {{sub.b}}
</template>

这也是取巧利用了子组件来改变访问作用域。可以复用看上去好像是一个优点，但实际使用还是比较繁琐，甚至代码看上去有些更乱了。与上一个方法同样存在的一个问题是，子组件引入了可能原本并不必要的包装根元素。

What does the proposed API look like?
我感觉利用v-for指令的办法很巧妙，就是多了一些副作用，虽然也不是非常严重的影响。
因此我希望能有一个指令，能够如同v-for一样定义一个局部作用域变量，但又不会影响$refs引用的表现。
div(v-scope="props of some.deep") {{props.a}}
// or
div(v-scope="(a, b) of some.deep.props") {{a}}, {{b}}

或者可以提供两种ref元素访问接口：

$refs仅用于访问指定引用名的第一项，类似于querySelector()
而$groupedRefs(我想也许还有更好一点的名字)则用于访问包含相同引用名的全部元素数组，类似于querySelectorAll()

其实我很希望是这样的API：
div(v-scope="some.deep.props") {{a}}, {{b}}

如果不指定要导出的变量，那么就把v-scope指定的表达式值作为优先级最高的作用域变量，相当于导出了全部属性变量。

You should really translate this one. I think, but I'm not sure, that this is exactly what I want in Vue as well. A way to declare a scope on a container.

Translation updated. @Solander

What about changing

into

@Atinux  Thanks for your comments

I'm also cautious about this feature, I did not provide a shortcut ( such as $v="" ) in the implementation

This feature is sometimes useful:

    {{result.a}}
    {{result.b}}
    <input v-model="item.some">

this is not a heavy or complicated implementation

hope to get more feedback about this feature :XD

@Atinux Thanks for your comments

@Austio, just help to @ the right person. 😁

I also would like to be able to use the mentioned syntax:

    {{result.a}}
    {{result.b}}
    <input :value="item.some">

To be able to access deep properties without having to use long names like:
object.child.property

How about some sort of v-let style notation to be more like JavaScript? My thoughts:
<template>

        <template v-let="{ props: some.deep.props }">
            {{ props.a }}
            {{ props.a }}
        </template>

</template>

<template>

        <template v-let:props="some.deep.props">
            {{ props.a }}
            {{ props.a }}
        </template>

</template>

If you declare a v-let, then shouldn't there be a v-const?

@AlexandreBonneau No, that doesn't make sense.

My thoughts are that you would still need a computed property or method in most cases for this where the data is coming from some api b/c there will be possibility of null/undefined.  Keeping a separation between the template and presenting the data will be marginally more verbose but the gains are clarity and also reduction in size of vue core.

Userland solution which works, but I highly recommend not to use it "as is".
(May be useful when you can move some logic into separate component which will make template more cleaner)

@OEvgeny This is a nice workaround, thanks.
However, a simpler v-let directive could prevent cluttering the template with those additional tags.
I think this feature request is still valid.

note that xsl has the concept of const variable.
Splitting templates or using computed or method is not always possible without breaking logical blocks or reducing readability.

大秦

个人习惯和风格可能都不太一样，清晰明朗，简洁易用，就是好框架，感觉用法还是不错的，很符合现在的代码编程习惯

我觉得很不错，赞一个。

Any updates on this? Just ran into this as well...

I was also looking for a solution ... While I found only this:

    {{myvar.a}}
    {{myvar.b}}
    <input :value="item.some">

Using the directives object is counterintuitive ; if you would want to declare those local variables, then it ought to be better to use:
export default {
	//...
	//fake
	localVariables: {
		myvar: {}
	}
};

However, having to name very local var in the component seems a bit too verbose.
If you have multiple <v-for> in your component, you'll have to name each temporary variable differently, while perhaps they would manipulate the same data.
v-let is still my preferred way to go, and would be scoped in the template to the very html element it is declared on.

if you would want to declare those local variables, then it ought to be better to use:
export default {
localVariables: {
myvar: {}
}
};

Is it works now? Can you show a complete example with loval variable in template?

No, it does not work now, as we are discussing options to implement (or not) local variables!
The point of my previous comment was to explain how I think having to declare the local variables in the


publish windows-arm64 as well in chocolately

What would you like to be added:
Currently we only publish ocm-cli (amd64) binary and not the arm64 version as chocolatey package. Whereas winget contains both 64 architectures.
see: https://github.com/open-component-model/ocm/blob/main/.github/workflows/publish.yaml#L120
vs.
https://github.com/open-component-model/ocm/blob/main/hack/chocolatey/tools/chocolateyinstall.ps1#L3

First link returns 404. Would be great if you could write up here what is needed so that other people can get assigned

blocked by: https://github.com/chocolatey/choco/issues/1803


Controller Charging items.

I'm not sure what exactly is the code and if the whole feature works, but I have items from Actually Additions and they are not charging wireless with the controller.

Fixed in dev


BAEL-3926 - Java Map with case-insensitive keys

There is another pending PR who opened a new module with the exact name

Retest this please


Design system website - Feedback and Alerts components

Acceptance Criteria:
Consider the following for MVP

only the "development" documentation will be created
As much as possible ui-components will be used in their current state. Gaps will be noted and separate user stories will be created to handle refinements to components.

Create pages for the following components:

[x] Badge
[x] Callout
[x] Modal
[x] Chip
[x] Notification banner
[x] Progress Indicator
[x] Temporary notification
[ ] Tooltip

Closing as this has been completed


Update SSP to use two files for definitions

Other examples use a DataDefs.hs and a Unitals.hs for their definitions which creates a hierarchy whereas SSP only has a single defs.hs file. Is SSP supposed to be like this?

No SSP is behind the other examples.  It was started last summer, but not completed.  You should follow the other examples for things that they do well, like having a hierarchy of definitions.

You're looking at what was essentially the initial version of the implementation. You can re-organize things as you see fit, as long as it makes sense.
Splitting things up a bit makes sense to me, not to mention it will help with pattern-finding when I get to overhauling data defs.

Dangit @smiths, beat me by a couple of seconds.

fixed c1fd1bbd42fb3827a9c83b6a2ed158614638ea96


Render fonts with anti-aliasing by default

Users are accustomed to beautifully rendered fonts, ever since LCD screens became the norm and modern operating systems and browsers have implemented Sub-Pixel rendering. Kivy's text feels notably different from native fonts for this reason (try disabling sub-pixel rendering to see the difference on the OS)
Currently people are getting around the issue by using blur filters  on Kivy Label's but that isn't true anti-aliasing, but rather relying on incidental rasterization artifacts in the final video-memory to screen transformation.
However, pixel-accurate font rendering can be difficult with hardware accelerated textures.
Recently, HTMLGL project added high-DPI support, and there was some discussion about via Valve's Signed Distance Field Text Rendering (SDFTR) which allows for per-pixel accurate font-rendering with complicated texture memory management.
I believe at the very least, if we can't implement SDFTR, we could consider using the built in Anti-Aliasing options in the rasterizer (I presume Kivy uses OpenGL under the hood), and because that is the norm for fonts, it should be enabled by default for all fonts/texts/labels.
Thank you!

Text is actually rendered by the text providers, most of the time this is sdl2_ttf, but can also be PIL/Pillow, pygame, or more recently (and linux only) pango, investigating which ones can offer better options in this direction. Alternatively, another hacky way to improve results is to oversample by just rendering the text in a bigger font than necessary, and putting the texture on a rectangle that is of the desired size (or using a Scale instruction), it's not perfect either, but it's easy enough and give nice results (see below, but i don't know if it's my eyes or my screen, i don't find the first result particularly egregious)

from kivy.lang import Builder

runTouchApp(Builder.load_string(
'''
BoxLayout:
    orientation: 'vertical'
    canvas.before:
        Color:
            rgba: .2, .2, .7
        Rectangle:
            pos: self.pos
            size: self.size
    BoxLayout:
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 10

        Label:
            text: 'test'
            font_size: 15
            color: .8, .1, .1, 1
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .66, .66, 1
            canvas.after:
                PopMatrix
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 20
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .5, .5, 1
            canvas.after:
                PopMatrix
    BoxLayout:
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 20

        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 30
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .66, .66, 1
            canvas.after:
                PopMatrix
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 40
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .5, .5, 1
            canvas.after:
                PopMatrix
    BoxLayout:
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 30

        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 45
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .66, .66, 1
            canvas.after:
                PopMatrix
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 60
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .5, .5, 1
            canvas.after:
                PopMatrix
    BoxLayout:
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 50

        Label:
            text: 'test'
            font_size: 75
            color: .8, .1, .1, 1
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .66, .66, 1
            canvas.after:
                PopMatrix
        Label:
            text: 'test'
            font_size: 100
            color: .8, .1, .1, 1
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .5, .5, 1
            canvas.after:
                PopMatrix
    BoxLayout:
        Label:
            text: 'test'
            color: .8, .1, .1, 1
            font_size: 100

        Label:
            text: 'test'
            font_size: 150
            color: .8, .1, .1, 1
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .66, .66, 1
            canvas.after:
                PopMatrix
        Label:
            text: 'test'
            font_size: 200
            color: .8, .1, .1, 1
            canvas.before:
                PushMatrix
                Scale:
                    origin: self.center
                    xyz: .5, .5, 1
            canvas.after:
                PopMatrix

'''))

Thanks for the example, the thing I'm seeing, and perhaps it's in my code, is a black halo around the text, and no anti-aliasing on icons.
Actual:

Expected:

If you look carefully at the "O" in Organic Mail you can see a distinct black halo/outline, and that feels a bit off. Perhaps it's not an anti-aliasing thing, but something else. Are fonts rendered to black textures and then having an alpha map? I'm trying to speculate here.

I see the issue, I didn't have the SDL text provider installed
sudo apt-get install -y \
    python-pip \
    build-essential \
    git \
    python \
    python-dev \
    ffmpeg \
    libsdl2-dev \
    libsdl2-image-dev \
    libsdl2-mixer-dev \
    libsdl2-ttf-dev \
    libportmidi-dev \
    libswscale-dev \
    libavformat-dev \
    libavcodec-dev \
    zlib1g-dev

This resulted in fixing it:

Sorry about the confusion

How to install the SDL text Provider? I create a package for Windows and have the exact same issue. Everything works in PyCharm but the exe file produce this halo effect.


Does not work on Windows

Programs compiled with gcc and MSCV on Windows 10 64-bit do not work. Only get a black screen that disappears after a while.

Same symptoms as #12 on Windows 7 64-bit

The BITMAPINFO problem is caused by fenster.h attempting to access 2 nonexistent array elements of type RGBQUAD from a BITMAPINFO struct. I have submitted a pull request that fixes this issue by using a custom struct that has the necessary 3 RGBQUADs.

@teovilo since it is now fixed, you can now close?


AESModeOfOperationCTR always uses 16 bytes counters?

aes = pyaes.AESModeOfOperationCTR(self.KEY, counter=pyaes.Counter(initial_value=iv))
print(len(aes._counter.value))

The counter value length seems to always be 16 regardless of if the key is 16 or 32 bytes. Is this the right behaviour? Or would this mean a security risk when using 32 bytes (256 bits) keys?

https://github.com/ricmoo/pyaes/blob/master/pyaes/aes.py#L281
The 128 should probably 256 when using 32 bytes keys.


Avatar fallback image

This update add the possibility of having a fallback image in case the original image failed to load
If the fallback image failed to load as well, we default to the avatar background color.
<Avatar
    name={fixture.name}
    image="https://notfound"
    fallbackImage={imageUrl}
  />

The component was also reorganized to move some utility function out of the component, to make it cleaner and "simpler"
isImageLoaded(props, state): boolean
hasImage(props, state): boolean
isFallbackImageLoaded(props, state): boolean
getImageUrl(props, state): string

Pull Request Test Coverage Report for Build 2237

31 of 31 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2236:
0.0%

Covered Lines:
11178

Relevant Lines:
11178

💛  - Coveralls


[SPARK-21957][SQL] Add current_user function

What changes were proposed in this pull request?
Added the current_user function.
How was this patch tested?
Added UTs.

Can one of the admins verify this patch?

The Python side looks reasonable, maybe @marmbrus can share his view on adding this function in general?
In the mean time Jenkins OK to test.

looks something is gone wrong with Jenkins command .. not sure why but looks we should just say "ok to test"?

ok to test

Test build #81580 has started for PR 19169 at commit 6b0b6bd.

Test build #81581 has started for PR 19169 at commit 6b0b6bd.

Test build #81580 has finished for PR 19169 at commit 6b0b6bd.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CurrentUser() extends LeafExpression with CodegenFallback

Test build #81581 has finished for PR 19169 at commit 6b0b6bd.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CurrentUser() extends LeafExpression with CodegenFallback

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81581/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81580/
Test FAILed.

the error the build job is failing for is:
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:24: imported LZ4BlockInputStream' is permanently hidden by definition of object LZ4BlockInputStream in package io
[warn] import net.jpountz.lz4.{LZ4BlockInputStream, LZ4BlockOutputStream}
[warn]                         ^
[error]
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:120: type mismatch;
[error]  found   : Boolean
[error]  required: net.jpountz.lz4.LZ4FastDecompressor
[error]     new LZ4BlockInputStream(s, disableConcatenationOfByteStream)
[error]                                ^
[info] Boolean <: net.jpountz.lz4.LZ4FastDecompressor?
[info] false
[warn] one warning found
[error] one error found
[error] (core/compile:compileIncremental) Compilation failed

this is not to be related to this PR. I am checking the reason which introduced the problem. Any idea?
Thanks.

The test failure with -9 in Jenkins is unknown up to my knowledge (although there have been few clues and assumptions so far). It should be not related with it.

It seems the failure is caused by the version mismatch v1.3 v.s. v1.4 in lz4-java (recently, I updated in https://github.com/apache/spark/pull/18883). I'm not sure this happens in jenkins though...

On local I solved the build error by running a mvn clean. As pointed out by @maropu , a PR removed the class and then the incremental compilation fails. I am not sure why this is happening on jenkins though...

So far, session-specific user management is not part of our plan yet. This API is not useful before it. Could you please close this PR?

I think it could have been useful anyway (eg. a user inserting rows through STS who wants to store the name of the user which is connecting to STS and performing the operation), but I agree that these are very corner cases. I am closing this then. Thanks.

It would be great to see this revived. A lot of old school ETL uses a current_user() function like this for audit/lineage/provenance fields.


New plugin: AWS CDK Toolkit

Summary
Add support for a new plugin for the AWS CDK Toolkit.
The AWS Cloud Development Kit (AWS CDK) lets you define your cloud infrastructure as code in one of its supported programming languages. You can use it to create, manage, deploy, etc. AWS CDK apps.
Thought Process
The AWS CDK Toolkit uses the same credentials as the regular AWS CLI, and the same profile workflow. We can reuse the importers and provisioners that have already been created for the AWS shell plugin.
How To Test

Install the AWS CDK Toolkit following these instructions
Initialize the AWS CDK plugin by running op plugin init cdk
Create an AWS CDK app following these instructions
Run a cdk command from the CDK app directory that requires authentication, e.g. cdk deploy. Try authenticating in the following ways. The command should be authenticated and run as expected:
a. Use an existing AWS Access Key created for the regular AWS shell plugin
b. Import credentials from the ~/.aws/credentials file
c. Import credentials manually as prompted

There are conflicts between this PR and this other PR for an AWS Vault importer that should be resolved when it's time to merge.

We would like to leverage the powers of CredentialUsage field of an Executable to specify that AWS CDK CLI executable could use the exact same CredentialType as AWS does. This will mean that by default, all default provisioners and importers will be re-used for cdk as well.

@AndyTitu I believe that the change that I just pushed conforms with that you're hoping for. Let me know if you think any other changes are necessary!


Restructuring the packages of Service Fabrik Broker

Tasks done

Moved controllers and routes
Moved BOSH to data-access-layer folder
Moved iaas to data-access-layer
Moved db to dal
Moved broker utils to common
Moved jobs dir
Moved maintenance dir
Moved quota dir
Moved reports dir
Moved cf from lib to dal
Moved Docker to data access layer
Moved models to utils
Moved config logger constant and error

The final package structure is planned like the following(bold are the changes done in this PR)
service-fabrik-broker

managers
api-controllers
data-access-layer

cf
bosh
docker
db
iaas
eventmesh
service-agent

jobs
fabrik
deployment_hooks
reports
quotas
common

constants
utils
models
config
middleware

Fabrik and some other files are still there under broker which will be moved in later PRs

Pull Request Test Coverage Report for Build 1383

359 of 359 (100.0%)  changed or added relevant lines in 89 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 87.983%

Files with Coverage Reduction
New Missed Lines
%

broker/lib/fabrik/DBManager.js
1
98.86%

Totals

Change from base Build 1379:
-0.04%

Covered Lines:
7193

Relevant Lines:
7910

💛  - Coveralls

dev pipeline verified.


Basic REPL support

Thinking of starting with socket REPL and doing nREPL separately.

Would want to leverage gradle/gradle#2336 (deployment API, currently used by Play integration). Can try the internal API for now to just see how it works.

Also need to address user input at some point, but for now might be nice to just have something kicked off and handle start/stop. Have user connect outside of Gradle to interact.

At some point it would be good to have Cider support added (not in this plugin but in Cider) to allow jack-in via gradle task as it is now possible with lein/boot.

I thought cider already supports this, I know there is some gradle support
there.
On Sat, Oct 28, 2017 at 3:42 PM Piotrek Bzdyl<EMAIL_ADDRESS>wrote:

At some point it would be good to have Cider support added (not in this
plugin but in Cider) to allow jack-in via gradle task as it is now possible
with lein/boot.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gradle-clojure/gradle-clojure/issues/27#issuecomment-340215069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM4e1oUjj9ykQ7xiTQQVPet9_7c3LYMks5sw4OagaJpZM4P5xdn
.

Looks like Cider added clojuresque support. Didn't look closely enough to tell if we can leverage that or it we'd need something else.

FYI, switched from socket first to nrepl first. Seems like that has more practical use.


Error in repLoad, unsupported format

Hello,
I am trying to analysis TCR data from a published article named"Pan-cancer single cell landscape of tumor-infiltrating T cells". But I failed in the input data, I used repLoad, it showed: unsupported format. The file is 10X VDJ.txt format. And I checked the file, compareing with other 10X VDJ .CSV files, it missed three columns named "contig_id", "raw_clonotype_id" and "raw_consensus_id".
I don't know if it is possible to input the file without these three colums, and how to do it. If it's impossible, I will ask the author for the source data.
Hope for your reply.Thank you.
Best regards,
Mengfei Wang
Dalian Medical University

Hello, Mengfei! I'm Aleksandr Popov, a developer of Immunarch package. Thank you for using our software!
You can add these columns to your file, filled with None values; for example, using sed (change my_10x_file.csv to your file name here):
sed -i '1s/$/,contig_id,raw_clonotype_id,raw_consensus_id/; 2,$s/$/,None,None,None/' my_10x_file.csv

If you have more questions, feel free to ask them!
Best regards,
Aleksandr


[stdlib] Re-enable assertions on malloc size

Round up our malloc requests and assert that breadcrumbs are aligned
and where we think they should be. This is necessary because ASAN
doesn't give us pointer-rounded sizes.

@swift-ci please test

@swift-ci please benchmark

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

Calculator
135
153
+13.3%
0.88x (?)

Chars2
3100
3400
+9.7%
0.91x (?)

OpenClose
56
61
+8.9%
0.92x (?)

Code size: -O
Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

Calculator
136
152
+11.8%
0.89x (?)

Chars2
3100
3400
+9.7%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

FlattenListLoop
3188
2882
-9.6%
1.11x (?)

StringHashing_fastPrenormal
570
530
-7.0%
1.08x (?)

Code size: -Osize
Performance: -Onone
Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci please test and merge


How to load the date from mogndob with php timezone ?

Hi,
My php application use the "Europe/Paris" timezone so when I save an entity to mongodb the date is converted to UTC date. It's not problem. But if I load an entity with date the datetime loaded not use the timezone of PHP but the UTC and the date it's not correct because there is a time lag.
So how to load the date from mongodb with the correct timezone ?
I use Doctrine with Symfony 3 and the field="date" annotation.

date it's not correct because there is a time lag.

I assume "time lag" is referring to the natural difference between time zones, which causes DateTime::format() to return an unexpected calendar day? In that case, you should be able to produce the expected calendar day by first calling DateTime::setTimeZone() to convert the DateTime back to your local time zone.
ODM's DateType does not support time zones, but I believe you could create a custom mapping type based on the date type that  calls date_default_timezone_get() and applies the local time zone when converting the database value (MongoDate) to a PHP value (DateTime).
I'd have to defer to @malarzm and @alcaeus, but I don't believe we have any functionality to allow custom field types to take additional mapping parameters. Ideally, you would be able to annotate the field with a preferred time zone (or possibly the name of another field in the document that stores a string indicating the desired time zone) and have that be applied by the type wrapper. This idea likely constitutes a feature request.

So the idea is to create a new type where there is in the method closureToPhp similar to:
$mongoDate->toDateTime()->setTimezone(new \DateTimeZone(date_default_timezone_get()))
(https://stackoverflow.com/a/42015911/6461660)
The second idea is to create an annotation with the timezone and modify DateType for use this timezone ?

So the idea is to create a new type where there is in the method closureToPhp similar to

AFAIK, both closureToPhp() and convertToPHPValue() would need to be implemented.

The second idea is to create an annotation with the timezone and modify DateType for use this timezone?

Correct. The second idea describes a potential new feature for ODM. The first idea (custom type) is possible to implement in your application with ODM's current functionality.

Ok at first time I implemented the first idea.
I submit a pull request for this new feature of ODM if you do not mind. Do you any rules for contribute ?
So for create the feature it's better to create a new FieldType no ?  Else how add an attribute to a Type.
I open the discussions on this feature.

I won't bet my head on this, but with default timezone set you should get DateTime objects with your time zone with ODM (or actually the underlying driver) converting it to/from UTC as data flies. At least I recall I faced issues after changing the default time zone :)

I don't believe we have any functionality to allow custom field types to take additional mapping parameters. Ideally, you would be able to annotate the field with a preferred time zone (or possibly the name of another field in the document that stores a string indicating the desired time zone) and have that be applied by the type wrapper. This idea likely constitutes a feature request.

Unfortunately there is no way currently for type to consider any additional parameters as it doesn't know about field's mapping at all. Also this is not the first time such thing is needed (support for DateTimeImmutable as a parameter was one, custom collections for collection another) but I fail to recall what was the conclusion. Probably to defer it until 2.0 :)

AFAIK, both closureToPhp() and convertToPHPValue() would need to be implemented.

1.2 will provide user with ClosureToPHP trait so only convertToPHPValue() is really needed.

I submit a pull request for this new feature of ODM if you do not mind. Do you any rules for contribute ?

@thibaultfalque: I would suggest implementing the custom field type in your application and simply creating an issue for ODM to extend the existing date type to support additional options in ODM 2.0. I don't think it's worth submitting a PR for a new date type with timezones against the 1.x branch, since this is something already being considered for 2.0 (previously discussed in https://github.com/doctrine/mongodb-odm/issues/1453). If you do create a new issue requesting the feature, it would be helpful to link to #1453 in the description to keep them associated.

I won't bet my head on this, but with default timezone set you should get DateTime objects with your time zone with ODM

@malarzm: That appears to be correct, based on the DateTime::__construct() documentation and how DateType constructs DateTime instances. To quote the PHP.net docs:

If $timezone is omitted, the current timezone will be used.
Note: The $timezone parameter and the current timezone are ignored when the $time parameter either is a UNIX timestamp (e.g. @946684800) or specifies a timezone (e.g. 2010-01-28T15:00:00+02:00).

I have add call of setTimezone in setter and constructor of my entity and it's works. So maybe it's possible to modify the date.timezone property of php.ini and in this case the timezone use by the DateTime constructor is correct.

I have add call of setTimezone in setter and constructor of my entity and it's works.

That may work for creating new entities or assigning a new DateTime on an existing entity, but I don't expect it handles the case of applying a local time zone from a DateTime value read from the database, which requires convertToPHPValue() in the ODM type class.

Closing as there's no new activity and questions seems to be answered: set the default timezone in php.ini file.


fix typo

(unintended)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Oops, thanks! (Surprised anyone reads the disclaimer.)


NodeJS: inconsistency in generated file names

The two generated files are:

client.gen.ts
types.ts

I think both should have a .gen.ts suffix (or neither -- just need to be consistent)

Actually types.ts was used before codegenerator implementation and should be removed.

Close this one as types.ts has been deleted


Fail build if grype fails

Grype broke as a result of changes to the ko config as we were asking it
to scan an image that didn't exist. Now we scan all images included in
the bundle, not just images we build. Fail the build if Grype is
unable to complete a scan.
The presence of CVEs will not fail the build.
Signed-off-by: Scott Andrews<EMAIL_ADDRESS>

@scothis : What kind of vulnerabilities does grype need to find before it will fail the security scan?  In this scan I see the classic Google protobuf "HIGH" severity vulnerabilities that have been around forever.  They don't cause the security scan to fail.  I'm aware that these particular protobuf vulnerabilities probably don't affect the Convention Controller itself, but I don't see anything that looks like an ignore list for these vulnerabilities.  How does it work?
  NAME                        INSTALLED        FIXED-IN  VULNERABILITY   SEVERITY
  google.golang.org/protobuf  v1.27.1                    CVE-2015-5237   High
  google.golang.org/protobuf  v1.27.1                    CVE-2021-22570  High


Lsm6ds33::new is hard to use properly

The new constructor returns a Result<Self, Error>, which means that when it fails to check if the chip is present, it swallows the passed-in I2C instance and it can never be used again.
I'm not sure what the best fix is; how would you feel about returning Result<Self, (I2C, Error)> so that the caller gets their I2C object back again? I don't know if that's particularly idiomatic.

Ya that's a good point. Not opposed to Result<Self, (I2C, Error)>. The MPU6050 driver has an explicit init function.  So perhaps another option is to add an init and then a free(self) -> I2C function that returns the I2C peripheral.

I thought about an init method, but that would mean it's possible to call a method on a not-yet-inited instance. I just sent https://github.com/nnarain/lsm6ds33/pull/5 for the change to new.

Ah yes that's a good point


Add a shortcut to switch appearance mode (light/dark)

Description
A shortcut to switch appearance mode (light/dark)
Who's implementing?

[x] I'm willing to implement this feature myself

The problem
I'm always frustrated when daylight change happens.
Then I need to travel a long way of:

"Customize and control Chromium" three dots button
Settings
Appearance
"Mode" drop-down menu
Close settings tab

Possible solutions
Add a switch button to the taskbar among the others, like "Extensions", not-useful-at-all-and-could-be-removed-replaced "Enable featured experiments" and three dots "Customize and control Chromium" buttons.
Alternatives
Installing an untrustworthy extension.
Additional context
No response

Do you have an idea how this might be implemented?


Support GHES

This adds support for this action to be used in GitHub Enterprise Server.
It sends request to the base url extracted from GITHUB_API_URL.

We will address the failing CI in pull requests coming from fork via https://github.com/actions/create-github-app-token/issues/32.
If you like you can build the dist files and try the changes with uses: 7Hazard/create-github-app-token and see if it works for you on GHES. But we can also just merge, I'm quite certain that it will work.

I pushed a change to your pull request because I figured it will be easier to convey what I meant, I hope you don't mind: c209b0b
Calling request.defaults({ baseUrl: process.env["GITHUB_API_URL"] }) has no side effects, it does not mutate the current request instance, it returns a new one with the defaults set

Ah I see, my bad. I didn't research about requests.default before using it. Appreciate this push! Feel free to merge it when you want to, whether it before or after the status checks.


Annotation issue: alteration shows as MUTATED

The alteration is annotated as MUTATED but is annotated differently in MPath
Portal link: https://cbioportal.mskcc.org/patient?sampleId=P-0055232-T01-IM6&studyId=mskimpact
MPath: https://cvr.mskcc.org:8083/sample/88866
In case you don’t have the access to MPath, it looks like this. This variant has a level 1 treatment associated.

@ao508 Looks fine on genome nexus homepage: https://www.genomenexus.org/variant/4:g.55152095_55152107delinsA. I'm guessing a pipeline annotation issue?
Would it be possible to have some check to make sure there are no MUTATED records in the private database?

@inodb When I hit the pipelines GN instance, which we just moved to k8s and is using a local vep now, I'm not getting a valid response actually so this might involve some investigating to diagnose what's going on with the local vep/k8s GN.
cc @sheridancbio @averyniceday
you can see the query Ino made above - here is the same query but on the pipelines GN app
http://annotation.genomenexus.org/variant/4:g.55152095_55152107delinsA
Let's discuss tomorrow.

Thanks @ao508 !

@inodb alright so I found that when the variant data is converted into the genomic location format the start position in the input to the annotator does not match the start position found in the data file itself.
If we manually construct the genomic location (below) based on the values given in the data file itself we see this:
[{
"chromosome":"4",
"start":55152095,
"end":55152107,
"referenceAllele":"ATCATGCATGATT",
"variantAllele":"A"
}]

The JSON response however shows a slightly different genomic location in the annotation_summary field: (start position is shifted by 1).
[{
"chromosome":"4",
"start":55152096,
"end":55152107,
"referenceAllele":"ATCATGCATGATT",
"variantAllele":"A"
}]

I suspect it's because the first nucleotide in the ref and var allele is the same? I think I remember seeing some logic that adjusts the start position in such cases.
Anyway, when we're mapping results from a POST request back to the MAF records from the input file we use the genomic location as a key. Since the genomic location derived from the input MAF does not match exactly the genomic location in the returned JSON annotation_summary field, the annotation pipeline is mistakenly believing the annotation actually failed.

Thanks @ao508 ! Ah yes this is recurring issue. We're having the same issue on the frontend with on the fly annotation
I think we had some ideas for how to fix this:

keep order of variants in POST request. Include empty records with failed annotation flag set to true.
include original raw request

I was under the impression @averyniceday and @sheridancbio had implemented something like 1. But maybe it was only the part that sends the variants to VEP in order. Not keeping the order of Genome Nexus POST requests themselves
A quick fix in the annotation pipeline might be to do a GET request for all failed variants, but yeah we should def fix this at the service layer as well

In OncoKB API, we always return the original request which can also include an ID for the variant.

@jjgao I was thinking the same thing

@zhx828 this seems fixed. Thanks @ao508 !

Thank you both! @ao508 @inodb


keriganc.com host not responding for vector-wirepod-setup

I got my Vector out and wanted to get the wire-pod software setup, but KC's website is timing out. This is over both local wifi and 5G, on my phone, and on my laptop ☹ Is there a new host, maybe the README just hasn't been updated yet?

Should be up now.


ERROR: Failed building wheel for vispy

🐛 Bug

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Environment

Please copy and paste the information at napari info option in help menubar here:

Any other relevant information:

Additional context

Please provide at least information about the operating system and processor architecture.

Closing for lack of information. It is also likely an upstream issue if it can't build vispy.
Feel free to add information later and ask for this to be reopened.


Preventing multiple params in tree

This addresses the issue of multiple parameters being in the tree (#349) which was causing longname to crash. It was decided with @jameshensman that rather than delaying until the construction of the name to detect and maybe recover from multiple parameters in the tree, that we should detect and abort as soon as someone tries to add the same param to the same tree.
This PR therefore adds the invariant to a tree that a Param/ Parameterized may only appear that a single point.
Cheers.

The main bit of code looks good. I have added a few queries for the tests though.

looks good to me, @alexggmatthews please have a look at merging this. Thanks.

Hi all, happy to look into this. It will have to be Monday morning now though I'm afraid. Have a good weekend,
Alex

I've moved this to #370 to allow the Continuous Integration to run.

Merged in #370


Conditional class loading : \Ds\Vector vs \SPLFixedArray

When the DS extension is not available, is preferable to use \SPLFixedArray rather than the DS polyfill, there is a huge penalty on performance due the the polyfill usage.

Mm... not needed.


Adding Tests for configurable AssignabilityCacheSize

https://jira.guidewire.com/browse/GOSU-102
Test Results are available here: https://circleci.com/gh/gosu-lang/gosu-lang/2489

@sadheeshv I believe you forgot to include an important URL in your commit message.


proceps' changes

Please continue work here and wait some review + tests passing. Also please edit description of pull request.

Codecov Report

Merging #2536 (122452f) into development (f4b6fca) will decrease coverage by 12.65%.
The diff coverage is 70.00%.

:exclamation: Current head 122452f differs from pull request most recent head 18b9fc3. Consider uploading reports for the commit 18b9fc3 to get more accurate results

@@               Coverage Diff                @@
##           development    #2536       +/-   ##
================================================
- Coverage        69.68%   57.03%   -12.66%
================================================
  Files             1441     1321      -120
  Lines            41086    34146     -6940
================================================
- Hits             28630    19474     -9156
- Misses           12456    14672     +2216

Impacted Files
Coverage Δ

...tants/_controlled_vocabularies/bibtex_constants.rb
100.00% <ø> (ø)

lib/utilities/geo.rb
27.01% <0.00%> (-21.43%)
:arrow_down:

app/models/source/bibtex.rb
65.50% <87.50%> (-3.84%)
:arrow_down:

app/helpers/batch_load/batch_load_helper.rb
23.07% <0.00%> (-71.80%)
:arrow_down:

app/controllers/public_contents_controller.rb
31.03% <0.00%> (-68.97%)
:arrow_down:

.../controllers/tagged_section_keywords_controller.rb
31.03% <0.00%> (-68.97%)
:arrow_down:

app/controllers/citation_topics_controller.rb
32.14% <0.00%> (-67.86%)
:arrow_down:

...controllers/otu_page_layout_sections_controller.rb
32.14% <0.00%> (-67.86%)
:arrow_down:

app/controllers/concerns/redirect_helper.rb
33.33% <0.00%> (-66.67%)
:arrow_down:

app/controllers/serial_chronologies_controller.rb
33.33% <0.00%> (-66.67%)
:arrow_down:

... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b6fca...18b9fc3. Read the comment docs.


Using httpclient.get() to load translated file and using NgTransService in Interceptor, it will not do the load default lang translated file

Version: 12.0.0
Description: Using httpclient.get() to load translated file and using NgTransService in Interceptor, it will not do the load default lang translated file. And if loading the file by manual in trans loader factory, there is a Circular dependency error.
Code
  // AppModule
  providers: [
    [
      {
        provide: HTTP_INTERCEPTORS, useClass: Interceptor, multi: true,
      },
    ],
    {
      provide: NG_TRANS_LOADER,
      useFactory: (http: HttpClient) => {
        // if loading the file by manual, there is a Circular dependency error.
        http.get('./assets/localization/zh-CN/translations.json').subscribe(data => console.log(data));
        return {
          [NgTransLangEnum.ZH_CN]: () => http.get('./assets/localization/zh-CN/translations.json'),
          [NgTransLangEnum.EN]: () => http.get('./assets/localization/en/translations.json'),
        }
      },
      deps: [HttpClient]
    },
  ],

@Injectable()
export class Interceptor implements HttpInterceptor {

    constructor(
        private transService: NgTransService,
    ) { }

    intercept(req: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
        let headers = req.headers;
        headers = this.setLanguage(headers);

        const newReq = req.clone({ headers, });
        return next.handle(newReq);
    }

    private setLanguage(headers: HttpHeaders): HttpHeaders {
        const currLang = this.transService.lang;
        return headers.append('Language', langMapping[currLang]);
    }
}

Error
ERROR Error: NG0200: Circular dependency in DI detected for NgTransService. Find more at https://angular.io/errors/NG0200
    at throwCyclicDependencyError (core.js:216:1)
    at R3Injector.hydrate (core.js:11441:1)
    at R3Injector.get (core.js:11264:1)
    at injectInjectorOnly (core.js:4758:1)
    at Module.ɵɵinject (core.js:4762:1)
    at Object.Interceptor_Factory [as factory] (interceptor.ts:34:36)
    at R3Injector.hydrate (core.js:11445:1)
    at R3Injector.get (core.js:11264:1)
    at injectInjectorOnly (core.js:4758:1)
    at ɵɵinject (core.js:4762:1)

In the case, using httpClient to load translated file, so the request will go through the interceptor. And using NgTransService in Interceptor, so it fails, will not do the request.
At that time, we can create a new httpClient instance so that the new instance will ignore the HTTP_INTERCEPTORS, the problem will not exist.
Creating a new HttpClient instance, we need a HttpBackend value, like this:
  // AppModule
  providers: [
    [
      {
        provide: HTTP_INTERCEPTORS, useClass: Interceptor, multi: true,
      },
    ],
    {
      provide: NG_TRANS_LOADER,
      useFactory: (httpBackend: HttpBackend) => {
        const http = new HttpClient(httpBackend);
        return {
          [NgTransLangEnum.ZH_CN]: () => http.get('./assets/localization/zh-CN/translations.json'),
          [NgTransLangEnum.EN]: () => http.get('./assets/localization/en/translations.json'),
        }
      },
      deps: [HttpBackend]
    },
  ],

It work fine now!


Fix Signal memory corruption issue

Calling Signal::connect from within a signal callback called by Signal::emit would update the underlying std::vector, which would invalidate iterators. This was causing issues when control returned to Signal::emit and it tried to call subsequent callbacks, which would be done using the invalidated iterator on std::vector memory that had already been freed. Since that memory was already freed, it was subject to re-allocation and corruption.
Reference: https://github.com/OutpostUniverse/OPHD/issues/1269
Valgrind for the win. It produced results much faster than my manual debugging attempts. Valgrind quickly pointed out use of already freed memory, and that this memory was both allocated and freed by the std::vector::push_back method, as used by SignalSource::connect. Note that the same line in SignalSource::connect calling push_back was responsible for both the memory allocation and deletion.

==21611== Invalid read of size 8
==21611==    at 0x243366: GetClosureMemPtr (Delegate.h:297)
==21611==    by 0x243366: operator() (Delegate.h:410)
==21611==    by 0x243366: emit (Signal.h:46)
==21611==    by 0x243366: operator() (Signal.h:50)
==21611==    by 0x243366: NAS2D::EventHandler::pump() (EventHandler.cpp:681)
==21611==    by 0x23F26B: NAS2D::StateManager::update() (StateManager.cpp:87)
==21611==    by 0x1C9ED8: main (main.cpp:160)
==21611==  Address 0x389d3030 is 112 bytes inside a block of size 384 free'd
==21611==    at 0x484BB6F: operator delete(void*, unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==21611==    by 0x15498B: deallocate (new_allocator.h:145)
==21611==    by 0x15498B: deallocate (allocator.h:199)
==21611==    by 0x15498B: deallocate (alloc_traits.h:496)
==21611==    by 0x15498B: _M_deallocate (stl_vector.h:354)
==21611==    by 0x15498B: void std::vector<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::allocator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > > >::_M_realloc_insert<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > const&>(__gnu_cxx::__normal_iterator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::vector<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::allocator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > > > >, NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > const&) (vector.tcc:500)
==21611==    by 0x1A2D17: push_back (stl_vector.h:1198)
==21611==    by 0x1A2D17: connect (SignalSource.h:37)
==21611==    by 0x1A2D17: connect<Window, Window> (SignalSource.h:42)
==21611==    by 0x1A2D17: Window::Window(std::__cxx11::basic_string<char, std::char_traits, std::allocator >) (Window.cpp:34)
==21611==    by 0x16E49D: CheatMenu::CheatMenu() (CheatMenu.cpp:38)
==21611==    by 0x21DCE2: MapViewState::MapViewState(MainReportsUiState&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (MapViewState.cpp:160)
==21611==    by 0x1DD8F3: MainMenuState::onFileIoAction(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, FileIo::FileOperation) (MainMenuState.cpp:147)
==21611==    by 0x150D5A: operator() (Delegate.h:410)
==21611==    by 0x150D5A: emit (Signal.h:46)
==21611==    by 0x150D5A: operator() (Signal.h:50)
==21611==    by 0x150D5A: FileIo::onFileIo() (FileIo.cpp:182)
==21611==    by 0x1AE73C: operator() (Delegate.h:410)
==21611==    by 0x1AE73C: emit (Signal.h:46)
==21611==    by 0x1AE73C: operator() (Signal.h:50)
==21611==    by 0x1AE73C: Button::onMouseUp(NAS2D::EventHandler::MouseButton, NAS2D::Point) (Button.cpp:155)
==21611==    by 0x24334E: operator() (Delegate.h:410)
==21611==    by 0x24334E: emit (Signal.h:46)
==21611==    by 0x24334E: operator() (Signal.h:50)
==21611==    by 0x24334E: NAS2D::EventHandler::pump() (EventHandler.cpp:681)
==21611==    by 0x23F26B: NAS2D::StateManager::update() (StateManager.cpp:87)
==21611==    by 0x1C9ED8: main (main.cpp:160)
==21611==  Block was alloc'd at
==21611==    at 0x4849013: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==21611==    by 0x154855: allocate (new_allocator.h:127)
==21611==    by 0x154855: allocate (allocator.h:185)
==21611==    by 0x154855: allocate (alloc_traits.h:464)
==21611==    by 0x154855: _M_allocate (stl_vector.h:346)
==21611==    by 0x154855: void std::vector<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::allocator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > > >::_M_realloc_insert<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > const&>(__gnu_cxx::__normal_iterator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::vector<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point >, std::allocator<NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > > > >, NAS2D::DelegateX<void, NAS2D::EventHandler::MouseButton, NAS2D::Point > const&) (vector.tcc:440)
==21611==    by 0x1AF8F9: push_back (stl_vector.h:1198)
==21611==    by 0x1AF8F9: connect (SignalSource.h:37)
==21611==    by 0x1AF8F9: connect<Button, Button> (SignalSource.h:42)
==21611==    by 0x1AF8F9: Button::Button(std::__cxx11::basic_string<char, std::char_traits, std::allocator >) (Button.cpp:56)
==21611==    by 0x1AFD22: Button::Button(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, NAS2D::DelegateX) (Button.cpp:63)
==21611==    by 0x1E0971: MainMenuState::MainMenuState() (MainMenuState.cpp:20)
==21611==    by 0x2329B1: SplashState::skipSplash() (SplashState.cpp:79)
==21611==    by 0x232A0C: SplashState::onKeyDown(NAS2D::EventHandler::KeyCode, NAS2D::EventHandler::KeyModifier, bool) (SplashState.cpp:163)
==21611==    by 0x2430BC: operator() (Delegate.h:410)
==21611==    by 0x2430BC: emit (Signal.h:46)
==21611==    by 0x2430BC: operator() (Signal.h:50)
==21611==    by 0x2430BC: NAS2D::EventHandler::pump() (EventHandler.cpp:660)
==21611==    by 0x23F26B: NAS2D::StateManager::update() (StateManager.cpp:87)
==21611==    by 0x1C9ED8: main (main.cpp:160)

Copying the std::vector before iteration in Signal::emit is maybe not the most efficient thing to be doing, but it does ensure correctness. As it stands, signal handling isn't exactly very performance sensitive, so the copy overhead kind of doesn't matter. Plus, there's the plan to move to an event bubbling model, which would eliminate the need for a whole lot of the signal handling code in it's current form, so this is all kind of temporary anyway.

I had a feeling it was an invalidated iterator somewhere.  Good work :D
I'm not worried about the copy overhead. Connect/Disconnect calls aren't performance critical and aren't happening repeatedly each frame so a few copies should be negligible in the long run.

Pretty sure I introduced the bug back in PR #1016. Switching to std::vector meant all pointers are invalidated calling erase. The situation is better with std::set::erase, which will only invalidate pointers to the erased item, and not to other items in the collection.

References and iterators to the erased elements are invalidated. Other references and iterators are not affected.

That and the reasons for switching to std::vector are perhaps questionable. I think that was prep work for switching to std::function or adding support for lambdas, but there were other blockers that prevented that from happening. Might still revisit that, though probably after looking into something like event bubbling, which would eliminate most of the need for Signal.


T58830 : Export GLTF/GLB - 2-nd time in 1 session won't work

Issue from Blender tracker :
https://developer.blender.org/T58830

In the linked issue, the scene has these glTF export settings:
{'export_cameras': 1, 'export_format': 0, 'export_lights': 1, 'export_texture_transform': 1}

This is a duplicate of #146.
I would consider this very high priority now.  Here are steps to reproduce from scratch:

Launch Blender 2.80 Beta
File -> Export glTF, to bring up the export options panel.
In export settings, (a) change type to "glTF Embedded", and (b) click "Save Settings" pushpin at the bottom, so that the scene custom property will be created.
Choose a filename and complete the export of the default cube.
Go back to File -> Export glTF a second time.  It will crash.

I had the same problem. Seems like this change works as intended:
https://github.com/EJTH/glTF-Blender-IO/commit/15cb252d08a2ba325a3f0e43e5f02298cf94c190#diff-42dbf07f348e019791ca29e531182c7c

This was fixed for "new" saved settings in #150.
Blend files with saved settings from the past few days will continue to crash the exporter, until the user goes into Scene Properties -> Custom Properties and deletes the glTF2ExportSettings.  For this reason, we might want to consider re-opening and merging #149.

@julienduroure This should be fixed now with your next push to the Blender repo.


refactor: Replace unwrap

Resolve #177
Replace unwrap with ? and expect.

@odysa @liurenjie1024 @Xuanwo @Fokko Please see my comment: https://github.com/apache/iceberg-rust/issues/177#issuecomment-1924916131
Thank you.


[BUG] use_compression for logs defaults to true, when docs suggest otherwise

This is very minor, but i wasted a bit of time trying to dig into this so i thought i'd share my findings.
The documentation (https://docs.datadoghq.com/agent/logs/log_transport/?tab=https#log-compression) and the config example suggest that compression isn't turned on for logs by default:
https://github.com/DataDog/datadog-agent/blob/71b946d0195a9e820ddc795e572bd6b167403c22/pkg/config/config_template.yaml#L1164-L1169
However, it looks like this setting actually defaults to true:
https://github.com/DataDog/datadog-agent/blob/71b946d0195a9e820ddc795e572bd6b167403c22/pkg/config/setup/config.go#L1929
The test suite seems to confirm that theory, where not providing a value for use_compression results in BuildHTTPEndpointsWithConfig giving back a Endpoint with UseCompression == true:
https://github.com/DataDog/datadog-agent/blob/71b946d0195a9e820ddc795e572bd6b167403c22/comp/logs/agent/config/config_test.go#L439-L453
Agent Environment
I went and checked on my cluster, and it appears that indeed, compression is enabled without my having explicitly set it.
$ kubectl exec -it datadog-78lff -- bash
Defaulted container "agent" out of: agent, trace-agent, process-agent, system-probe, init-volume (init), init-config (init), seccomp-setup (init)
root@datadog-78lff:/# agent status
...snip...
==========
Logs Agent
==========
    Reliable: Sending compressed logs in HTTPS to agent-http-intake.logs.datadoghq.com on port 443
    BytesSent: 1.0391732e+07
    EncodedBytesSent: 3.762892e+06
    LogsProcessed: 9211
    LogsSent: 9210
    CoreAgentProcessOpenFiles: 47
    OSFileLimit: 1048576
...snip...

Describe what you expected:
The docs and config example should reflect the default correctly.

Closed by https://github.com/DataDog/datadog-agent/pull/21941.


feat: run every n seconds

[ ] I have considered whether this PR needs review, and requested a review if necessary.

Fixes issue #
Notes for reviewers
Reviewers can skip X, but should pay attention to Y.

Current dependencies on/for this PR:

#56  👈
main

This stack of pull requests is managed by Graphite.


Kanna_LogMessege

Kanna_LogMessage.1.0.1.zip

Please check out the code. @narendar.
Thanks

Hi @Elshaddai0908 Your code has deployed successfully.


Preferences "Reset" does not work

Version: 0.8.3
Platforms: All
Observed Behavior
Completely adjust the Widgets/Multimeter font-color and background-color and exit preferences.  Open preferences again and click on Widgets/Multimeter.  Click "Reset to Defaults".  The right-hand pane goes blank.  Clicking on Widgets/Multimeter shows the original values.
Alternatively, clicking "Reset" above does not immediately update the right-hand pane, but does if you click away and back.  However, the actual multimeter colors are not updated.
Expected Behavior
Clicking "Reset to Defaults" or "Reset" for the profile should completely restore the factory default preference values.

Workaround:
You can close the Joulescope UI and then manually delete your Joulescope configuration.  Here is where you can find the config file one each platform
Windows:
"%LOCALAPPDATA%\joulescope\config\joulescope_config.json"
Linux:
~/.joulescope/config/joulescope_config.json
macOS:
~/ApplicationSupport/joulescope/config/joulescope_config.json


BlitzListForm - validation message

Hello,
how would I put a validation message under a quasar input field in a specific row? For example a second row.
Thanks.

you can do so with rules eg.
const schema = [
  {
    component: 'QInput',
    rules: [(val) => val.length > 3 || 'min 3 characters'],
  }
]

you can do so with rules eg.
const schema = [
  {
    component: 'QInput',
    rules: [(val) => val.length > 3 || 'min 3 characters'],
  }
]

Thank you. But I have an external validation so I need to set attributes on a field. Specifically 'error-message' and 'error' on QInput field. When I do that all rows get the same error message. I need to target only a specific row. For example the second one. How would I do that?

Thank you. But I have an external validation so I need to set attributes on a field. Specifically 'error-message' and 'error' on QInput field. When I do that all rows get the same error message. I need to target only a specific row. For example the second one. How would I do that?

Try this !

evaluatedProps: ['error-message'],
errorMessage: (val, { rowIndex, formData }) => rowIndex === 2 ? 'an error' : '',

As you can see you can do the same thing for the error field and you can also access the formData for the entire row

Try this !

evaluatedProps: ['error-message'],
errorMessage: (val, { rowIndex, formData }) => rowIndex === 2 ? 'an error' : '',

As you can see you can do the same thing for the error field and you can also access the formData for the entire row

Thank you. I got what I needed in {$attrs} key .

Thank you. I got what I needed in {$attrs} key .

I think there might be a better option that accessing the $attrs key. Can you post your solution so I can have a look?
The danger about the attrs key is that if I make internal changes you might not be able to get the same info as you do now.

I think there might be a better option that accessing the $attrs key. Can you post your solution so I can have a look?
The danger about the attrs key is that if I make internal changes you might not be able to get the same info as you do now.

I am still using https://github.com/mesqueeb/quasar-ui-easy-forms. Haven't had time to update it yet.
errorMessage: (val, { $attrs }) => $attrs.rowIndex === 2 ? 'an error' : '',

I am still using https://github.com/mesqueeb/quasar-ui-easy-forms. Haven't had time to update it yet.
errorMessage: (val, { $attrs }) => $attrs.rowIndex === 2 ? 'an error' : '',


Remove vertical and horizontal lines in charts

Hi, how can I remove the vertical and horizontal lines of the grid?
Thank you !

You'd have to modify the source code of this lib. If you do that, and make it configurable, make sure to open a Pull Request.

@Ivanrs297  did you achieve it, Did you modified code?
If yes, please let me know how to remove background lines

I know this is old but I was trying to figure out how to do this and it might be useful to someone. I was able to do this with the following:
  propsForBackgroundLines: {
    strokeWidth: 0
  }

@Em01 and @jBaczuk can you pls tell me exactly how to remove the grid. in which block should I put the above code solu.

@SSOURABH58
For example:

<LineChart
  {...otherProps}
  withInnerLines={false}
/>

Hi @JBaczuk I want to remove only inner vertical lines is there any way to do this.

You can use this line in chartConfig
  backgroundGradientFrom: COLORS.WHITE.primary,     backgroundGradientTo: COLORS.WHITE.primary,

use various
<LineChart
  {...otherProps}
  withInnerLines={false}
or
// this use vertical line remove
withVerticalLines={false}
or
// this use vertical line remove
 withHorizontalLines={false}
/>


texlive: fix dependency bug, add docs and release notes

Description of changes
This contains an urgent fix for an embarrassing dependency resolution bug when using old style custom packages.
It also contains updated documentation about custom TeX packages (which is how I discovered the bug) and a line in the 23.11 release notes about texlive.withPackages.
If we miss the branch off, let's remember to backport to 23.11.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tests.texlive


Abort pending requests when signing out

Details

Add functionality to let requests be aborted
Abort any leftover requests during sign out
This prevents writing stuff to Onyx after logging out
Fixed Issues

$ https://github.com/Expensify/App/issues/7434
Tests

All platforms

Throttle the network speed from dev tools (e.g. 2kbps download speed)
Accumulate some pending requests by switching chats or switching between tabs
Log out while requests are still running
Observe pending requests are getting canceled (see Network tab or console logs)
Observe nothing is being written to Onyx after logout

Mobile
Similar to the steps above - we're trying to have pending requests  when we log out
On Android, there are throttling options in the Emulator network settings (see Android videos below)
On iOS there aren't but it's still possible (see iOS video)(Physical iOS network can be throttle following this guide):

Pull down the notifications bar a few times to create pending requests (resulting from app re-focus)
Log out while requests are still running
Observe aborted request logs in the terminal ([info] [API] request aborted)

QA Steps

Try logging in and logging out as fast as possible a few times

nothing unexpected should happen
if you login with a different account you should not see chats from the previous account (like in the linked ticket video)

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Before Abortable Requests
https://user-images.githubusercontent.com/12156624/154555684-e34d88bb-85ab-49f5-a8a7-2b7d4f8adf5c.mp4
After Abortable Request
https://user-images.githubusercontent.com/12156624/154555785-a02b8c73-b0b7-475d-8488-ffd72f4e7b8f.mp4
Mobile Web

Desktop

https://user-images.githubusercontent.com/12156624/154556284-91412906-ce6a-43f4-831a-313a8a46494c.mov
iOS

https://user-images.githubusercontent.com/12156624/142843603-034fd832-d4ea-4528-b1c3-c2bdbddb37fb.mov
Android

Before Abortable Requests
https://user-images.githubusercontent.com/12156624/154556070-97852643-d165-4a9b-89ac-5e99aca2dd6a.mp4
After Abortable Requests
https://user-images.githubusercontent.com/12156624/154556149-48a62d60-f492-4e7d-ae70-f4ff1ca511be.mp4

Just curious, is there any reason we aren't aborting chat attachment request after logout?

We only abort calls we requested ourselves - anything that's initiated through HttpUtils.js.
If something calls fetch or uses XMLHttpRequest on it's own we can't abort it. It doesn't pass through HttpUtils.js.
And images - any image on the screen is loaded by the browser directly (<img src />)

@tgolen all yours! LGTM! 🎉

Addressed requested changes
✔ Ready for review

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @tgolen in version: 1.1.41-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to staging by @tgolen in version: 1.1.41-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


File extension for SQL and MSGF source are indistinguishable from the target object extension

Currently MSGF source has a file extension of MSGF.
SQL source like VIEW also has a file extension of VIEW
We should change this to be consistent with handling of CRTBNDRPG source, i.e. file.PGM.RPGLE
In general when the object type is ambiguous, make it a prefix to the source file extension.
.[.].
So for MSGF it should be
.MSGF.CL
and from VIEW it should be
.VIEW.SQL

Problem resolved with pull request #31


Add queue example usage

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#95

👍


fix: should close socket fd when retry connect (tcp)

I guess it makes sense. I think there is no proper way to test this reliable though.

APPLICATION USAGE
       If connect() fails, the state of the socket is unspecified. Conforming applications should close the file descriptor and create a new socket before attempting to reconnect.

Perfect.
@not-a-robot r+


Create ftl.txt

Create a P. L. Kapitsa Phystech Lyceum file. Official website: https://anoo.ftl.name/. Students' e-mail addresses have the form<EMAIL_ADDRESS>Thanks!

@Irval1337 First stage of verification passed, official domain is anoo.ftl.name as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://anoo.ftl.name/en-school.htm

Sorry for disturbing. Do you need any additional information about my school?


[CODEC-295] - Minor improvement

https://issues.apache.org/jira/browse/CODEC-295
Minor improvement

extra computations by getting the string size only once.
remove unused imports
add final String
add final method and var

Coverage decreased (-0.02%) to 94.284% when pulling f456b6f0e3f5612f3fafcc73752e25ee0258cc8d on arturobernalg:feature/CODEC-295 into 4369d10a6019c5ec9515242ae61b4a8b8ad178f2 on apache:master.

HI @garydgregory  @sebbASF  any idea of why the Java CI  it's failing?

@arturobernalg
Please rebase on master.

@arturobernalg
IMO, we do not need Jira tickets for these kinds of changes.


Custom Plugin fields are not included in the generated TypeScript schema

When I add a custom plugin field of, for example, a native color picker, the Blok doesn't include that field in its generated schema at all, even though the JSON returned contains the information.
Is this by design? If not, any suggestions on a workaround would be appreciated. Thanks 🤝

everything which is not declared is not rendered, so if you do have a custom plugin you need to extend the type declaration as its not possible to know what the plugin is doing under the hood.

@dohomi Thanks for the quick response! How would I go about extending the type declaration?
Should I create a new custom type, for example ColorPickerStoryblok, and manually add it to the CountdownStoryblok type definition after importing it? Any way to semi-automate this?

You would declare it anywhere in your project once. There is no other way, either use .d.ts file ending or just import in on your use. You can basically just overwrite any interface with your custom schema


Current version does not find app.css on startup

Error: Browser does not find app.css on startup
Fix:
server.js line6:
change from:
app.use(express.static(__dirname + "/src"));
to:
app.use(express.static(__dirname + "/build"));

If you're a user, just go to http://openpogoui.nicontoso.eu.
If you're a développer you can either run gulp dev-styles to generate CSS file or type gulp watch to automatically generate CSS file when you modify scss.

didn't know about gulp dev-styles, nice thanks. I normally just run 'npm install' and 'gulp' on a new pull.

Faire enough I'll add the case generation to default task

CSS génération


[BUG] Roblox app loading buggy with Bloxtrap

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v 2.8.1
What problem did you encounter?
This problem started this morning after the automatic installation of a Roblox update. Since then, as soon as I start Roblox via Bloxtrap, I find myself facing this completely buggy application. And when I use the site, the game GUIs just never load. I have reinstalled all of Roblox and Bloxtrap several times but the problem really comes from Bloxtrap. Thank you for your help

Bloxstrap Log
N/A

Roblox issue, make sure the location and drive bloxstrap is installed in doesnt have any special characters, including your windows user

I checked and everything is good. Just, when I launch Roblox via Bloxtrap, I see this since the last update. Like many people apparently

My Bloxtrap gives the same problem

Duplicate of #3691


support new envoy broadcasts

batch events are now logged to firebase
additional dnstt urls are now stored

Batch events are just informational, envoy itself handles whether to continue validation. The new dnstt support has not been well tested but at this time I don't think we're relying on it so it seems low-risk.

LGTM