Go Live [Oct12]

Learn Build status updates of commit 0ae3ab3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/enable-and-configure-your-app-for-teams-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-canvas.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-how-to/how-to-custom-azure-fluid-relay.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-cursors.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-eraser-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-highlighter-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-laser-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-line-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-pen-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/canvas-point-eraser-tool.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-canvas-capabilities-docs-diagram-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-canvas-docs-feature-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-event.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-media-capabilities-docs-feature-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-presence.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/live-share-timer.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/teams-live-share-core-capabilities-hero.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-live-share/teams-live-share-dashboard.png
:white_check_mark:Succeeded
n/a (file deleted or renamed)

msteams-platform/assets/images/teams-live-share/teams-live-share-schematics.png
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Basic Plan - basic update

Ensure update-service works for the Basic Plan.
Document which properties of which resources are editable.
Validate customer needs around service update, e.g. scale cluster
See MVP doc.

the possible feature for update are

pause cluster
enable/disable backup
start/stop cluster

Review with Manulife to prioritize and rank.

Should follow spec for json patch data here for testing various update scenarios: https://docs.atlas.mongodb.com/reference/api/clusters-modify-one/
eg
cf update-service chewy-123 -c '{ "paused":"true" }'

Update is working, here is an example to pause a cluster.
cf update-service wed-demo-1 -c '{ "paused":true }'
Updating service instance wed-demo-1 as admin...
OK
➜  atlas-osb-MASTER-DEMO git:(master) ✗ mongocli atlas clusters list --projectId 5f0f0e0859cd8a08718294bf | jq '.[] | { "n" : .name, "s" : .paused}'
{
  "n": "wed-demo-1",
  "s": true
}


Discuss webview activation event

re #44466
With the better webview support we discuss a new activation event like "restoring UI-state-with-webview"

Let's go with the existing onView:-event


Support ARNs which contain commas

Split on spaces instead of commas for account ids, in order to support ARNs which may contain commas.
Tracked here: https://trello.com/c/FwmsruC0/75-bug-cli-does-not-account-for-commas-in-aws-iam-arn

Codecov Report

Merging #10 into master will increase coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   85.52%   85.89%   +0.37%
==========================================
  Files           9        9
  Lines         152      156       +4
  Branches       17       19       +2
==========================================
+ Hits          130      134       +4
  Misses         11       11
  Partials       11       11

Impacted Files
Coverage Δ

src/commands/endpoints/destroy.ts
93.33% <ø> (ø)
:arrow_up:

src/commands/endpoints/access/index.ts
81.25% <ø> (ø)
:arrow_up:

src/commands/endpoints/wait.ts
94.44% <ø> (ø)
:arrow_up:

src/commands/endpoints/access/remove.ts
94.11% <100%> (+0.78%)
:arrow_up:

src/commands/endpoints/index.ts
78.12% <100%> (ø)
:arrow_up:

src/commands/endpoints/create.ts
95.65% <100%> (ø)
:arrow_up:

src/commands/endpoints/access/add.ts
94.11% <100%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949faf1...a723651. Read the comment docs.


Fix AttributeError: 'module' object has no attribute 'client'

A recent TensorFlow commit (tensorflow/tensorflow@5563229) removes the
visibility of several modules. For anyone using bleeding edge TF, this allows
importing of timeline.

Thanks!

I think a PR I'm preparing actually already includes this fix, since it's bad style. Good to know it actually introduces a bug, though!

@lemonzi: Oops, sorry for merging this quickly.

@ibab Oh, no worries! It's always better to have atomic commits with a good justification for the change.


Add caching for found mdns services

Problem
As we are moving toward a self-built mdns library in embedded systems
and can know precisely about the TTL of each service, we can now enable
caching for mdns services to reduce multicasts.
Summary of Changes
Changes include:

Implemented a hash map for saving the mdns entries.
Modify the platform mdns api to get the notifications from the
underlying library.
Add unit tests for the hash map.
Add functional tests for the DiscoveryManager
Also resolves  https://github.com/project-chip/connectedhomeip/issues/3769

@rwalker-apple @bzbarsky-apple @andy31415 The PR is ready.

We need one more approval before submitting.
@BroderickCarlin @saurabhst @jelderton @hawk248 ?

@bzbarsky-apple My first version of the ServicePool turned out to be poorly-written and freaky so I re-wrote it with RAII memory management. It should be easier to understand and memory bug free now.
I locally ran all the mdns related tests with -fsanitize=address to test the memory integrity. I cannot add this cflags in the PR since it looks like some other part of the code also suffer memory issues. Fixing them is beyond the scope of this PR.
Memory integrity is a critical part for the code quality and I believe it's desired to enable -fsanitize=address by default.
Created an issue for the memory discussion: https://github.com/project-chip/connectedhomeip/issues/4117

@bhaskar-apple ping

@bzbarsky-apple ?

Absorbed in some internal affairs, patches will be delayed

@bzbarsky-apple Further simplified the service pool.

@saurabhst Ping after holiday season.

@saurabhst Ping after holiday season.


*: create 0.10.0-rc.1 release

Description

Releasing RC.1.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

[ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
[ ] FEATURE (non-breaking change which adds functionality)
[ ] BUGFIX (non-breaking change which fixes an issue)
[ ] ENHANCEMENT (non-breaking change which improves existing functionality)
[x] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Blocked by https://github.com/timescale/tobs/pull/344


Draw ready check on party list incorrect.

Not sure when it started but the overlay for drawing the ready check marks on the party list isn't marking people correctly. Seems to randomly assign markers to people. Sometimes it shows 8/8 ready marks before the check is even done, sometimes it simple attributes readys to people who aren't. The chat output is correct on who is/isn't ready however.
My party list has default sorting if that makes a difference.

Here is an example where I initiate the ready check and it attributes my ready to the RDM
https://i.imgur.com/yZkziBf.mp4

It also shows for people that ain't in the party. This was after the ready check was done 4/4:

This should be fixed now, if it still occurs please open a new issue


Logo design

Hi, I'm a logo designer and I can design a free logo for your project. So ,what do you think?

Wow! That sounds amazing :-) I would be happy to have a professional scalable logo for tinylog.

Hi, sorry for delay. I made a design for this project. If you like it I'll send you all files to use it.

Which color variation do you prefer?

Thank you very much for the great logo :-) I really love it!
I prefer the primary color #33AD00 from the tinylog 2 website, plus a second one with the light color #C8FFC1 for dark backgrounds.
Could your provide the color also as SVG? It would simplify the use a lot for me.

Sure, I'll do it tomorrow.

I used the colors that you wanted, which variation do you want to use?

Thank you very much for your efforts! I really like to see the new logo in tinylog's primary color :-) I would like to use both logos from the left side. The project preferred spelling is "tinylog" in lower case letters. Could you adapt this?


Right way to run AdHoc Pipeline

Hello,
I'm loving airflow, just wanted to clarify the right way to run an adhoc pipeline. We will eventually move to daily batches, but at the moment our pipeline just needs to be run ad hoc. Backfill seems to run all jobs form the start date. So whats the best way to just kick off a chain when needed? Apologies if I've missed something in the documentation!
Thanks!

Depending on what your needs are, there are several ways to help with this:

The first one is to define a DAG with {'adhoc': True} in the default_args. This will ensure that the pipeline is not scheduled, and the tasks only run when a manual run/backfill command is issued.
If you can formulate your pipeline as depending on a particular trigger (presence of a File, or a partition in Hive, or a key in S3), then it could run daily and only run to process that particular file should you chose to.

Of course you can combine the approaches.
Let me know if you need more help.

"Backfill seems to run all jobs form the start date"
Well only if you don't pass it a start_date, see airflow backfill -h for all the options, but look at -s, -e and -a
The idea with adhoc=True tasks (note that it is a task level parameter) is that you can squeeze them in a DAG alongside scheduled tasks and have them around, ready for their occasional use cases. You'd then trigger them with an airflow backfill -a [...] command when needed.
Other options you may consider are to pause individual DAGs in the UI, or simply not run the scheduler at all.

Thank you both!


(*models.Error) is not supported by the TextConsumer

We're seeing this error in a non-trivial number of our e2e test runs w/ slsa-github-generator.
&{0 } (*models.Error) is not supported by the TextConsumer, can be resolved by supporting TextUnmarshaler interface

As with #801 it seems to be a transient error. A quick Google search returned https://github.com/go-swagger/go-swagger/issues/1929 which seems to be unresolved in the swagger library but there are some clues there as to potential ways to work around it.

I'm suspect that you're getting a 429 response due to rate limiting, but since that is formatted by nginx as HTML (instead of JSON which is what the rekor client expects by default).
https://github.com/sigstore/rekor/commit/be91b71109b42e9fc217c3c64333aa82119555c7 (which is in 1.0rc) changes the underlying HTTP client to quietly attempt retries according to the Retry-After headers returned by the gateway). That probably won't definitively fix the error you're reporting here, but should make it happen drastically less often.

@ianlewis has upgrading to rekor v1.0.0 helped in this?

@bobcallaway I think we're still evaluating. I don't think we have a release with it included but I'll see how often it occurs in our e2e tests this week.

@bobcallaway We actually didn't update Rekor to 1.0.0 in in slsa-github-generator yet. We only had updated it in the verifier. Hopefully https://github.com/slsa-framework/slsa-github-generator/pull/1121 will get merged in the next day or so and we'll see results.

We've upgraded and haven't seen this error since upgrading. Closing.


Doors not working through portals inside outer wrapping areas

I was building a 4D house that's bigger on the inside, and I put the large inside section of the house a little far away, and hid it inside a global outer wrapping zone. The door to enter the house, which was outside the wrapping zone and right in front of a portal leading into the zone, worked fine from both ends. But when both sides of the portal were inside the wrapping zone, I couldn't open the door through the portal. I couldn't figure why this was at first, and when I eventually tried it outside the zone and saw it worked, there were a bunch of doors right outside the wrapping zone that I didn't put there, and when I destroyed them, the top and bottom halves were destroyed individually, not together like normal.

Showing a video could help

I think I might be having this problem too. It seems that when you place a door on a portal, its hitbox completely wraps the door and stops you from opening the door.


Update motion.md

📥 Proposed changes
Added some ideas - some of these might be too specialized (regarding reseption screens) for this page.
☑ Submission checklist

[ ] I have read the CONTRIBUTING doc
[ ] yarn build works locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

💬 Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc...

Fixes #435


VSCode does not support multiple memory spaces

VS Code Version: 1.72.2
OS Version: Microsoft Windows 10 Pro, version: 10.0.19044 Build 19044
Information:
VSCode does not support multiple memory spaces, i.e. different children having different views of memory

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Hi @jonahgraham,
Since you have a good knowledge in this. Could you help me explain it?

Hey @deepak1556, this issue might need further attention.
@QuocDoBV, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Get rid of unmaintained react-sticky

The warning does not need to be always in the viewport, it is already big enough.

The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   21.44%   21.44%
=======================================
  Files         166      166
  Lines        1231     1231
=======================================
  Hits          264      264
  Misses        967      967

Impacted Files
Coverage Δ

src/components/Warning/Warning.js
0% <ø> (ø)
:arrow_up:

src/components/PageLayout/PageLayout.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821ae6a...b9efa17. Read the comment docs.

Preview: https://geodatagouv-pr-483.herokuapp.com/datasets/12678f24655de4a5472ef7ae76a507cbdd01ad8a


[FEATURE REQUEST] Add a React package which uses foo as a dependency.

Hi, thanks for the great repo :)
Can you please add one more package - React web - which uses foo as a dependency?
I tried to add React web but no luck. react-scripts start automatically reset tsconfig.json.
Thanks in advance.

@nthtrung09it Oh I see. Yeah actually I have experience as my former company configured React app with other ts packages.  Soon will work on it in my spare time.


Redirect to localhost:3000 after login

Hello, i was using docker instalation in production enviorment, but after I logged in, I redirected to localhost:3000.
In my .env var i set  NEXT_PUBLIC_WEBAPP_URL and NEXTAUTH_URL but still redirect to localhost.
The weird part is in docker logs, the replace-placeholder change the localhost to my url.
I tried change the docker version (2.5.4, 2.5.5, 2.5.9, and the latest), but nothing happens.
The migrations applied in my database and IO did nmot have any errors in my logs.
Does anyone else have this happen or know how to fix it?

I'm seeing some similar behavior, not with the redirects yet, but in general with browser caching. Can you try in incognito mode just to test?

I tried in incognito and another explorers, but the error still continue,  I read in another post and an option is invalidate cache, and I applied to my distribution, but nothing happens.

Set NEXTAUTH_URL  as local host:3000 that is how I have it on my setup and make sure you clear the cache of the browser

We have also noticed this happening occasionally as a caching issue, after attempting login prior to updating the nextauth_url


README Changes

Proxmox Disk PassThrough Script
Disk PassThrough Script to PassThrough Physical Disk to Proxmox VM - (excluding those used by ZFS Pools)

Description:

Enumerates Physical Disks available on your Proxmox Host (excluding those used by ZFS pools)
Lists all Available VMs
Lets you pick Disks and a VM, then Generates qm set Commands for easy Disk PassThrough

Key Features:

Automatically finds /dev/disk/by-id Paths, Prioritizing WWN Identifiers when available
Prevents SCSI Index conflicts by checking your VM’s Current Configuration and Assigning the next available scsiX Parameter
Outputs the Final Commands you can Run directly or use in your Automation Scripts

Requirements:

Must Run on a Proxmox Host with qm and zpool Commands available

Python 3.x

Sufficient Privileges to run lsblk, zpool, and qm Commands

NOTE:

This Script does not Automatically Apply Changes; it only Generates
the necessary Commands.

Use at Your Own Risk - Users should Carefully Review the Output before Running the Commands.

Ensure you have proper Backups and Understand the Implications of PassingThrough Disks to a VM.

Usage:

Run the Script directly on the Host with the Command: python3 disk_passthrough.py
Select the desired Disks from the Enumerated List
Choose your Target VM from the Displayed List
Review and Run the Generated Commands

MIT License
Copyright (c) 2024 Pedro Anisio Silva
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

N/A


an issue while running train.py

Hi,
Thanks for your great work. While running train.py I met such a problem:
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/secretbase/PycharmProjects/wandr/train.py", line 46, in main
logger.log_hyperparams(OmegaConf.to_container(cfg, resolve=True))
omegaconf.errors.InterpolationKeyError: Interpolation key 'datapath_name' not found
full_key: dataset.smplx_models_path
object_type=dict

Hi, could you please try replacing "data_sl" to "data" in line 2 of the file conf/paths/paths.yaml ?
Let me know if this solves the problem.

(1) Hi, I tried this approach earlier, but I'm now encountering an error: "No such file or directory: wandr/data/amass_smplxn/amass/amass_small.pth.tar". How could I obtain the "amass_small" dataset and how about the "circle" dataset?
(2) It appears that demo.py uses the data in "deps/statistics_amass_circle_smplx.npy" for normalization, specifically using values such as mean and std. Could you please explain how the max, min, mean, and std values in "statistics_amass_circle_smplx.npy" are derived?

(1) Ok now I see the problem. You will have to wait a few days for that. As I say in the README the processed AMASS dataset  is not released yet released (it will be soon).
(2) These features are basically produced by calculating the features the dataset (see dataset.amass_dataset.py) produces and then taking the max/min/mean/std of these features. The mean and std are used to standardise the features before they are given to the model. Its a common practice in neural network training.

I'll leave this issue open until the dataset for training is released.
Please open a new issue if you have other questions.


Score based on fields matching

Hi,
I'm trying to make a request with a matching term and with a score depending on where the match is.
Shortly, I have a media with actors and containers (through has_many), and the media is indexed with participants name and containers names/descriptions :
define_type Media.includes(:participants, :containers) do
    field :name, :description
    field :participants, value: ->(media) { media.participants.map(&:name) }
    field :containers do
      field :name, :description
    end
  end

I would like to retrieve the media with the term matc.* so that match and matching are returned (so far I'm ok), but also by scoring the results : if the match is in media name, it would have a greater score than in participants names. Or the opposite, score higher if the participant name matches, or the container name.
I tried to use boost and score_script but I have a bit of trouble here.
Could you help me ?
Thanks

Try this: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html#CO116-1

Thanks, I'm giving a look. I will tell you if I succeed.

Nice, I found how to do it with this link :)
Here it is, in case it can help someone else :
MediaIndex::Media.query(query_string: {query: 'matc*', fields:['name^3', 'description^2', 'participants', 'containers.name', 'containers.description']})

Multi match does not allow regexp (at least I didn't find).
So now I know I can exploit the full potential of ES with query() or use built-in methods of chewy.
Thanks a lot for your help !

Welcome


Refactor Config and ROCrateWriter

The current resave.py was getting fairly complicated. This PR introduces two new classes to help control that complexity:

Config: this encapsulates all the issues regarding reading/writing from local/remote storage for zarr/tensorstore.
ROCrateWriter: this is an extension point that we can add to in order to read metadata from other sources. Currently it only takes the 5 known parameters from the command-line.

This branch is currently based on #17 awaiting @dominikl's review.
cc: @sherwoodf @will-moore

Merging for 0.0.5


Keeping number of workers to default for all tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@fcad936). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage        ?   92.03%
=======================================
  Files           ?       10
  Lines           ?      402
  Branches        ?        0
=======================================
  Hits            ?      370
  Misses          ?       32
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: functional test

JENKINS-55582 Convert modules to plugins
JENKINS-64107 Convert SSHD module to a plugin
JEP Convert modules to plugins
It adds three functional test to test the SSHD service, the Git Server, and the Jenkins CLI over SSH.
see https://github.com/jenkinsci/jenkins/pull/5049 and https://github.com/jenkinsci/sshd-module/pull/38
Desired reviewers
@jenkinsci/code-reviewers

There is already functional test coverage for SSHD; is all this just a workaround for JENKINS-41827? If so, I wonder if it is worth the added complexity, vs. just doing a one-time manual sanity check.

yes, it is a workaround for JENKINS-41827


fix the DGS graphql path

Pull request checklist

[x] Please read our contributor guide
[x] Consider creating a discussion on the discussion forum
first
[x] Make sure the PR doesn't introduce backward compatibility issues
[ ] Make sure to have sufficient test cases

Pull Request type

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
From the graphiql html, change from absolute path from root to relative path.
Describe the new behavior from this PR, and why it's needed
Issue #1203
This will address issue with uri remapping like reverse proxy.
Alternatives considered
Describe alternative implementation you have considered

This worked backward compatible.

Thanks for the fixes @1zg12.

Thanks for the fixes @1zg12.

hi @srinivasankavitha , I have updated the test cases.


Updates 2.0.4 issue 138

Awaiting confirmation from Rishiyur that these updates address the issue to his satisfaction

Just ack'ing that I've seen your note; will review shortly.  Thanks.

Yes, all these changes look fine to me (my apologies for my delay in reviewing).


Define possible colors for Headings

The Fact has a color in Figma. Define a set of available options and guidelines for colors used by headings. Clarify if AA is enough for contrast, or if we should aim for AAA.
Update Figma Typography sketches, and the storybook Heading and Fact .

Closing this one, as it is old and not that relevant anymore. See also #334 for a more general take on theming


outlook.com doesn't center the body

Hi. these email temps are very useful. But outlook.com doesn't center billing.html body

See Issue #11 ?

no it is not about outlook 2007. it is about outlook.com. first outlook.com doesn't center the body of the page. I think issue is about css ecxcontainer class. And "alert alert-warning" class doesn't work. There are problems for outlook.com

If you change the margin on the container  to Margin, with a capital "M", that will fix the centering issue i.e. Margin: 0 auto;
I'll update the repo shortly.

@naczu I wasn't able to reproduce the alert banner issue. Not with Litmus any way. Mind sharing the exact HTML you're sending?

I use email alert http://mailgun.github.io/transactional-email-templates/alert.html. I think outlook made something new for filtering css files. I don't know what is wrong.

Ah yes you need to inline the styles before sending it out.
Mentioned here but sorry if I didn't make it clear.

As Lee said, to center the main container , the "M" in its CSS property name Margin has to be capitalized.
I tested all three templates in Outlook.com, and in addition to the  shared by all of them, there are 3 other HTML elements in 'billing.html' (a
 heading, a
 heading,
) which need Margin for improved display. Comparisons below.

As this "hack" is ridiculously simple, it's also super easy to overlook – and rather inconvenient to deal with in regards to inlined CSS we need in final emails. Namely, CSS inliners will uncapitalize margin, so writing Margin in 'styles.css' is mere documenting, and to actually apply it, it has to be capitalized by hand in final emails (the HTML code with inlined CSS).
With that said, as it's a useful addition IMHO, I will open a PR with this fix documented for 3 CSS rules in 'styles.css', and applied to corresponding HTML elements in 'inlined/action.html', 'inlined/alert.html', 'inlined/billing.html'.

Is this an issue anymore since Outlook.com has been replaced by Outlook365 (which doesn't suffer from this bug)?

Thanks @TedGoas. While at the moment my Outlook.com hasn't upgraded yet, Microsoft writes that everyone should get the new version soon (“we’re rolling out these upgrades to Outlook.com users as quickly as possible, with millions of accounts being upgraded each week”).
It's great news if we can start to forget about many rendering quirks of Outlook.com, including this issue. And while I personally would like to re-test this after getting access to Office 365-based Outlook.com, I'm sure repo's owners would be happy to close this issue (along with #21) sometime soon.


Outcome usability - un-natural position of update button

Working on outcome command, the current Update command feel in an un-natural position

As the delete command they disappear as you work on a command but the Commit Change is there is front of your eyes and seems the natural action to ... commit your change.

we have now a message that should block the user losing its updates but we should investigate a more suitable position for this button. Doesn't fit with the object hierarchy but it seems better fitting close to the "Commit Change" and always on top.

Discussed the option to disable commit changes when an element is selected and add a Cancel bottom to trigger the deselection


decss

What do you think about decss project? (syntax sugar over CSS Modules with styled-component’s like React components).
How can I combine decss and css-literar-loader?

They should just work, no? In the worst case, you might need a different naming convention for things you pass through decss-loader (so you can use normal CSS-modules-style imports... I don't know if you can still import the styles object normally if you're using that loader), but otherwise there should be no conflicts?

Should we add it to the docs as some sort of alternative for styled?

okay, maybe i misunderstood. do you mean doing something like:
const { Button } = css`
  .Button {
    color: white;
  }

  .Button-disabled {
    opacity: 0.5;
  }
`;

Now that would be interesting. Still, I wonder if we could incorporate the decss runtime bits into styled. It seems like it could be nice if something like the below "just worked":
const Button = styled('button')`
  color: white;

  & .disabled {
    opacity: 0.5;
  }
`;

I found that styled doesn't create a simple static CSS file and put styles in JS (maybe I did something wrong).
This is why I am looking for some additional solution.

Wait, what do you see styled doing?

Hm, maybe I had some problem because of other Babel plugins?
Does your loader generate same simple be CSS file for styled?

@ai it should yes, the loader will produce an in memory file as an optimization (that is eventually written out by webpack), and the babel plugin will/can write the extracted files to disk if you want

the way it works tho, is it removes the text inside the template literal and creates a file then replaces the tag with a require() to that file

Perfect. I will mention your project in my PostCSS Way talk.

Fixed in https://github.com/4Catalyzer/css-literal-loader/pull/23


Trying to optimize set and get index for range values

Not ready to review yet.

Current coverage is 100.00%

Merging #7 into master will not affect coverage as of aab3fb3

@@            master      #7   diff @@
======================================
  Files            2       2
  Stmts           68      68
  Branches         0       0
  Methods          0       0
======================================
  Hit             68      68
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of aab3fb3

Powered by Codecov. Updated on successful CI builds.

Benchmarks of interest:
Master
| 16  | "get_index_virtual_small_start_bench" | 4.14257e-6 | 16.5975  | 100          |
| 17  | "get_index_virtual_small_end_bench"   | 5.74793e-6 | 23.0295  | 100          |
| 18  | "get_index_virtual_front_half_bench"  | 0.00173048 | 6933.29  | 100          |
| 19  | "get_index_virtual_end_half_bench"    | 0.00226516 | 9075.52  | 100          |
| 20  | "get_index_virtual_entire_bench1"     | 0.00387673 | 15532.4  | 100          |

This PR
| 16  | "get_index_virtual_small_start_bench" | 7.6986e-6  | 32.2144  | 100          |
| 17  | "get_index_virtual_small_end_bench"   | 1.28392e-5 | 53.725   | 100          |
| 18  | "get_index_virtual_front_half_bench"  | 2.38146e-5 | 99.6509  | 100          |
| 19  | "get_index_virtual_end_half_bench"    | 2.57021e-5 | 107.549  | 100          |
| 20  | "get_index_virtual_entire_bench1"     | 4.32596e-5 | 181.018  | 100          |

Indexing into the last half of the virtual array is almost 100 times faster.
Other range indexing should be very easy to implement with the code in the PR.

Looks good. Merging. The only comment I have is that it would help with readability moving forward if you could refactor some of the duplicated test setup code into a separate function.


Flutter does not run on MacOS, with MacOS as the device, if Anaconda is installed.

Steps to Reproduce

Get a mac with anaconda installed. (My .zshrc is below.)
Run the following command: cd && cd Desktop && flutter channel dev && flutter upgrade && flutter create myproject && cd myproject && flutter run -d macos.

Steps to Fix

Comment out the lines (below) from the .zshrc.

Logs and Stuff
zshrc
# >>> conda initialize >>>
# !! Contents within this block are managed by 'conda init' !!
__conda_setup="$('/Users/name/anaconda3/bin/conda' 'shell.zsh' 'hook' 2> /dev/null)"
if [ $? -eq 0 ]; then
    eval "$__conda_setup"
else
    if [ -f "/Users/name/anaconda3/etc/profile.d/conda.sh" ]; then
        . "/Users/name/anaconda3/etc/profile.d/conda.sh"
    else
        export PATH="/Users/name/anaconda3/bin:$PATH"
    fi
fi
unset __conda_setup
# <<< conda initialize <<<

Flutter Doctor
Command: flutter doctor -v
Output:
[✓] Flutter (Channel master, 2.3.0-17.0.pre.225, on macOS 11.4 20F71 darwin-x64, locale en-GB)
    • Flutter version 2.3.0-17.0.pre.225 at /Users/name/Developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2794dea0df (24 hours ago), 2021-06-05 16:04:04 -0400
    • Engine revision 03d645e782
    • Dart version 2.14.0 (build 2.14.0-182.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/name/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 4.2 Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.4 20F71 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.77

• No issues found!

Flutter Run
Command: flutter run -d macos
Output:
Launching lib/main.dart on macOS in debug mode...
ld: unknown option: -target
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Analyzing workspace
note: Constructing build description
note: Build preparation complete
** BUILD FAILED **

Building macOS application...
Exception: Build process failed

Flutter Run -v
Command: flutter run -d macos -v
Output [ending]:
[   +4 ms] ** BUILD FAILED **
[   +2 ms] The following build commands failed:
[        ] 	Ld /Users/name/Desktop/MyApp/myapp/build/macos/Build/Products/Debug/myapp.app/Contents/MacOS/myapp normal
[        ] (1 failure)
[  +32 ms] Building macOS application... (completed in 4.3s)
[+2207 ms] Exception: Build process failed
[   +2 ms] "flutter run" took 8,864ms.
[   +5 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:671:9)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1126:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:196:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:232:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>

[   +3 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1

Output [ending]:

You've removed the portion that says what the linker errors are. Please provide the complete verbose output.

It's too long for GitHub ("You can't comment at this time — your comment is too long (maximum is 65536 characters)."), so I've attached it as a text file. Sorry for the inconvenience, @stuartmorgan .
Conda Flutter Error Verbose Output.txt

`/Users/name/anaconda3/bin/x86_64-apple-darwin13.4.0-ld -target x86_64-apple-macos10.11 [...]
ld: unknown option: -target

You have overridden your linker with one that apparently isn't compatible with Xcode. If you make system-level changes that break xcodebuild, then building with the flutter tool isn't going to work by extension.
You'll need to either remove that linker from your path, or, if your package manager is only changing your path for terminals and not GUI apps, do all of Flutter builds by doing a failed flutter build to do Flutter-specific setup any time you update Flutter and doing your actually build from the Xcode UI.


UTC timestamp instead of local time in auto-generated description

This is under experiment -> info:

Local time is +3 hours, and that's the time that is used for all other clocks in the interface.

Hi @michaelitvin
The comment is auto-generated by the Trains init process at runtime.
As a general rule of thumb, the system always stores UTC timestamps, and converts them to local time stamps in the UI.
Unfortunately this is actually text generated by the Trains agent, so the UI cannot convert it.
Maybe we can change the test to say UTC time (or the opposite to mention the local time zone)
What do you think?

I think that the times should be displayed in all places consistently.
People are used to think in local times, so best would be to specify the
local time everywhere. If that's not possible then at least state
explicitly that this is UTC.
It could also make sense to add a timezone configuration, so if the client
and server run in different timezones the times would still be displayed
consistently.
On Wed, Jun 24, 2020, 14:38 Martin.B<EMAIL_ADDRESS>wrote:

Hi @michaelitvin https://github.com/michaelitvin
The comment is auto-generated by the Trains init process at runtime.
As a general rule of thumb, the system always stores UTC timestamps, and
converts them to local time stamps in the UI.
Unfortunately this is actually text generated by the Trains agent, so the
UI cannot convert it.
Maybe we can change the test to say UTC time (or the opposite to mention
the local time zone)
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/allegroai/trains/issues/152#issuecomment-648767760,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMLNUJKULNFCE2AX57K27DRYHQSXANCNFSM4OGQOFPQ
.

It could also make sense to add a timezone configuration, so if the client
and server run in different timezones the times would still be displayed
consistently.

Time zone is take from your browser, so hopefully this should be taken care of :)

. If that's not possible then at least state explicitly that this is UTC.

That makes sense, do you feel like PR-ing it (see here) ?

Forking and going through the entire PR process is a bit much for such a small change...
So if someone gets to this, it looks like the solution is just to add 'UTC' to the string in this line.
Hope I'll get more chances to help later on:)

@michaelitvin the fix is avilable in the latest RC:
pip install trains==0.15.2rc0


Use ['catch'] instead of .catch

We are having issues in our workflow, because .catch is a reserved work in YUI compressor. This alter the code so that the creation of that method will happen with brackets, thus ensuring YUI will not throw errors when a large JavaScript bundle is passed through it.

We actually ran into this issue the other day as well :smile:
Although this should probably be considered a bug in YUI, I'm happy to accept this pull request. YUI doesn't seem to get any updates.


go build fails to fetch the correct go module if multiple processes are trying this at the same time

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.11 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOBIN=""
GOCACHE="/Users/toonschoenmakers/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/toonschoenmakers/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/toonschoenmakers/git/nnd-auth/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qk/76c0lh7166nbz10bntlqwqw80000gn/T/go-build623752335=/tmp/go-build -gno-record-gcc-switches -fno-common"```

### What did you do?
I decided to run https://github.com/golangci/golangci-lint on one of our internal projects after I had just cleared the go module cache. Due to the concurrent nature of this it ended up fetching the same dependency at the same time

### What did you expect to see?
I expected golangci-lint to just run right away

### What did you see instead?
```go: finding github.com/DATA-DOG/go-sqlmock v1.3.0
go: finding github.com/dwlnetnl/testingx v0.0.0-20160814101815-52306257fefb
go: finding github.com/davecgh/go-spew v1.1.0
go: finding github.com/lib/pq v0.0.0-20180523175426-90697d60dd84
go: finding github.com/go-sql-driver/mysql v1.3.0
go: finding github.com/rcrowley/go-metrics v0.0.0-20180503174638-e2704e165165
go<EMAIL_ADDRESS>git -c protocol.version=0 fetch --unshallow -f https://github.com/davecgh/go-spew refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /Users/toonschoenmakers/go/pkg/mod/cache/vcs/b9a4b9bbdb4a59723f2348415ad7ffda91568455a1cfd92e97976132bdfbaf57: exit status 128:
	fatal: Unable to create '/Users/toonschoenmakers/go/pkg/mod/cache/vcs/b9a4b9bbdb4a59723f2348415ad7ffda91568455a1cfd92e97976132bdfbaf57/shallow.lock': File exists.

	Another git process seems to be running in this repository, e.g.
	an editor opened by 'git commit'. Please make sure all processes
	are terminated then try again. If it still fails, a git process
	may have crashed in this repository earlier:
	remove the file manually to continue.
go: finding golang.org/x/crypto v0.0.0-20180807104621-f027049dab0a
go: finding code.xsnews.nl/src/rescentral v0.0.0-20180813163958-35e027ef6d35
go: finding code.xsnews.nl/src/endusersdb v0.0.0-20180827162130-93fe7faf5076
go: finding code.xsnews.nl/lib/go-graphite-metrics v0.0.0-20171004120308-d2cfcdaa4842
go: finding code.xsnews.nl/src/sessionsd v0.0.0-20180801112532-630783373dee
go: finding code.xsnews.nl/lib/syslog v0.0.0-20180116170101-fbdbf514309f
go: finding layeh.com/radius v0.0.0-20180814173541-639444c7e76f
go<EMAIL_ADDRESS>git -c protocol.version=0 fetch --unshallow -f https://code.xsnews.nl/src/rescentral.git refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /Users/toonschoenmakers/go/pkg/mod/cache/vcs/09f86cabe13c5a65b4c5e7f0cc1d298d8f5e61120fe3ae4aba4a91514754c326: exit status 128:
	fatal: Unable to create '/Users/toonschoenmakers/go/pkg/mod/cache/vcs/09f86cabe13c5a65b4c5e7f0cc1d298d8f5e61120fe3ae4aba4a91514754c326/shallow.lock': File exists.

	Another git process seems to be running in this repository, e.g.
	an editor opened by 'git commit'. Please make sure all processes
	are terminated then try again. If it still fails, a git process
	may have crashed in this repository earlier:
	remove the file manually to continue.
go<EMAIL_ADDRESS>git -c protocol.version=0 fetch --unshallow -f https://code.xsnews.nl/src/endusersdb.git refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /Users/toonschoenmakers/go/pkg/mod/cache/vcs/5308931c869412b1ba95f1a8f2a1a818642be4319aaf99abf374695166aa97e9: exit status 128:
	fatal: shallow file has changed since we read it
go: error loading module requirements```

After some quick looking around through the golang source I ended finding the last error message https://github.com/golang/go/blob/ad644d2e86bab85787879d41c2d2aebbd7c57db8/src/cmd/go/internal/modload/load.go#L996, making me think this is an issue in go rather than golangci-lint. I currently don't have an easy way to reproduce this issue, but I'll try to provide one rather sooner than later.

Duplicate of #26794.


Add strokes to BarPlot bars

In Greenhouse Effect I have need for a plot like

Bamboo's BarPlot is working great for this, but the mockup shows strokes around each bar which isn't currently supported. BarPlot bars use currently Line which only have a stroke for the entire bar. The most straightforward way to support would be to use Rectangles instead, I will try that.

I made this change so that BarPlot draws with Rectangle instead of Line. @samreid would you mind reviewing? Just listing out the specific things that seem important for the reviewer to check:

Since Rectangle doesn't support negative height I had to set the bar bottom to the plot y=0 line if it has a negative height.
I added an option for barWidth to control width of bars in view coords
I converted pointToColor option to pointToPaintableFields so that fill, stroke, and other Paintable options can be set.
pointToPaintableFields was the name I landed on because merge would have tried to merge pointToPaintableOptions.
I needed an eslint-disable-line for the default pointToPaintableFields because it returns an object on one line. Maybe there is better syntax for this.

Looks great, I tested this in the bamboo demo and in greenhouse gases.  Some ideas for improvements:
The code in update may be simpler (avoid the if statement) if we use Math.min like so:
      // rectangles cannot have negative height
      const rectHeight = tip.y - tail.y;
      const bottom = Math.min( tail.y, tip.y );
      this.rectangles[ i ].setRect( tail.x - this.barWidth / 2, bottom, this.barWidth, Math.abs( rectHeight ) );

I needed an eslint-disable-line for the default pointToPaintableFields because it returns an object on one line. Maybe there is better syntax for this.

Could be addressed like so:
const DEFAULT_PAINT_OPTIONS = { fill: 'black' };

// ...
pointToPaintableFields: point => DEFAULT_PAINT_OPTIONS

What if we wanted the bar width to also be a function of the data point?  It's unclear where we should draw the line for customization.  But the most general would be a mutateRectangle function that takes a dataPoint and a Rectangle, and can adjust it accordingly (setting color, stroke, width, etc).  But this API may be less friendly (less structural?).  What do you recommend?

Thanks for reviewing @samreid! Improvements made in the above commits.

What if we wanted the bar width to also be a function of the data point

I don't think I would recommend pursuing this. I did a search through bar plot examples and couldn't find a plot that looked like this. I would recommend we wait until this is requested because in my opinion it seems like an unlikely case.

I searched "bar chart where bars are different colors" and saw many examples of bar charts where each bar is a different color.  Is that worth pursuing?

"bar chart where bars are different colors" seems very useful and is supported by pointToPaintableFields. I did a search for "bar chart where bars are different widths" and didn't see many examples in the wild.

Excellent, thanks for helping me understand.  The commits seem good, can this issue be closed?

Great, I think so, thanks @samreid!


Integration Test - Release - 2018/11/30 02:54:23

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


TouchableOpacity inside SVG not clickable

Hello all,
I have an issue where TouchableOpacity doesn't trigger onPress events when it's nested inside svg element. For same feature, I have different implementation where TouchableOpacity on Android is outside svg element and it registers tap just fine. As soon as it's inside header it just stops working.
react-native-svg: "7.0.3."
Any ideas? Thanks!

I don't think we've had support for that yet. Would be nice to have though. You can use onPress directly on the svg elements for now, or isolate the part you want touchable to animate in a separate svg root which you wrap with touchable. This will allow it to just change the opacity of the already rendered svg, rather than re-render its content each frame of the animation.

Thanks for the answer @msand. So I should stop trying to get it to work, it won't until Touchable is outside Svg completely?

Yeah, I haven't tested or tried to make it work until now at least, so I would expect it not to work. Not sure exactly what it would require either, haven't looked into what touchable requires of its children to animate them, or to understand their size/position on screen.

Ok, thanks for the answer. Bump the thread if you ever get to work on it and thanks for everything else.

Has this svg problem been fixed?

afaik no. I think I have overlayed button over svg in the end, since I couldn't get it to click inside SVG.

Check here: https://github.com/react-native-community/react-native-svg/issues/645#issuecomment-453683513

@sebastijandumancic @mileslow2 If either one of you is up for it, feel free to make the TouchableOpacityG code available as a package on github/npm, perhaps TouchableSvg would be a fitting name?

Hello @msand, any update on this?


Update Terraform code for billing utility

Describe the Issue
The Billing utility terraform code needs to be updated. The ecs task definition needs to be updated to support running quarterly billing utility
Additional Context

We need to update the ECS task definition to increase the CPU and Memory usage as the billing utility takes longer to run in the Live due to number of accounts
Reach out to Prabhu or Warren for any other information

Acceptance Criteria

Terraform is Updated and deployed in Live
.
.
.
.
.
.
.
.
.
.
.

Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

https://github.com/BCDevOps/terraform-octk-aws-sea-billing-reports/pull/18


Add DiscordUser.CreateDmAsync

Summary
Adds DiscordUser.CreateDmAsync as an alias for DiscordClient.CreateDmAsync.
Changes proposed

Come up with a better PR template

Notes
Hi

This requires a member, not a user.


Polished version

In your review, please consider the following:
Clarity and precision of the written content: Is the language clear and concise? Is the information provided accurate and relevant?
Efficiency and functionality of the code: Does the updated code perform its function as expected? Are there any areas where its efficiency could be improved?
When providing feedback, I kindly request you to highlight at least one aspect that, in your opinion, should be further refined or enhanced. Your insights will be instrumental in elevating the quality of our work.

I would say, for the code, it would be better to leave it the way as before so it only utilizes the functions and parameters of the packages functions that we have explored in class, so there is no doubt that the code we have is legitimate.

but the explanatory comments are pretty nice, so if you want to add some comments describing what the code does in different parts, that would be great.

I would say, for the code, it would be better to leave it the way as before so it only utilizes the functions and parameters of the packages functions that we have explored in class, so there is no doubt that the code we have is legitimate.

Which functions are problematic? Because all the functions are described in the documentation.

I think we can remove the "Histograms are effective visual aids when we want to understand the distribution of a variable. " part for conciseness since the target audience probably knows this info.

I would say, for the code, it would be better to leave it the way as before so it only utilizes the functions and parameters of the packages functions that we have explored in class, so there is no doubt that the code we have is legitimate.

Which functions are problematic? Because all the functions are described in the documentation.

I think all of them works fine, just that some are not used in tutorials and worksheets, so I think it makes more sense to just use the simpler ones we use in the worksheet/tutorial. My only concern is that the checkers think that we are not writing the code.

Okay then, I guess we could keep the change for the code. Semantically, I checked that they are performing as expected.


Parameters.py missing regen attribute

i'm attempting to run the example model on my own machine, but running into an error with Parameters.py. There is no function called regen as referenced on line 746 in Horizon.py.
see error below:

and here is the code from Horizons.onlaps.insert_tilting_episodes():

i've searched through Horizons and Parameters and not able to  locate regen
i'm able to get the example model to run by commenting out line 746 in Horizons.py

Hi @mmcint. Any idea on this topic? I'm running into the same problem and I'm wondering if just commenting line 746 solves the problem without compromising the rest of the code

yes, just comment out line 746 and it should solve the problem. also, take a look at some of the open PRs. might help solve other issues

This issue is addressed in #11
Thank you for pointing this out!

I did not encounter this issue while running the end 2 end process.  Maybe we can remove that line @tpmerrifield ?

Remove it, apologies. This is a remnant of a feature that tracked randomly selected parameters for regenerating a copy of the original model after changes were made to the code.


Enable daemon, enable info logging, add more memory to gradle

Merged the changes from a different branch in the and see #887


Fix flaky TestContainerLifecycleEvents e2e test

What does this PR do?
In the TestContainerLifecycleEvents e2e test, consider only Nginx pods which are in Running phase.
Motivation
TestContainerLifecycleEvents is currently a bit flaky.
The investigation showed that the Nginx pod considered for the test, that has been deleted and for which a lifecycle event is expected, has never been seen by the agent:

We cannot find any data for it.
The agent didn’t see this pod. So, it couldn’t notice its deletion either.
Given the fact that the Nginx pods are constantly created and deleted by an HPA, my hypothesis is that the test choose a pod which was freshly created and not already running.
In order for the test to reliably pass, it needs to chose only a running pod that the agent has noticed.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Check if TestContainerLifecycleEvents is still flaky.

/merge


README file should state "Install/ensure Go version is 1.13"

📚 Docs Bug Report
Description
 A clear and concise description of the problem...
🔬 Minimal Reproduction
What's the affected URL?**

Expected vs Actual Behavior**

Ubuntu 18.X Go install via apt is Go 1.10 which does not support modules and expects Go path to be set. CLI does not work with that.
📷Screenshot

🔥 Exception or Error

🌍  Your Environment

User error, README had directed to use go >= 1.12  (mine was go 1.10)


Update Dependencies and Improve Security

Does the pull request solve a related issue? No
If so, can you reference the issue?
What does the pull request accomplish? Use a list if needed.

Add Helmet to disable many of the unnecessary, and in some cases, security-risk headers.
Update all dependencies to the latest revision.

If it includes major visual changes please add screenshots.

Can you explain what helmet does?

It removes any identifying headers (such as X-Powered-By) and adds security headers (such as frameGuard) to make sure the page is secure. It isn't anything major, but nonetheless, it protects you from hacking.


Full screen button on iphone

Hi how to enable full screen view button on iphone? All devices have a button on Ipad, android mobile, desktop, but on iphone there is no button.

Convince Apple to support the fullscreen API in Safari on the iPhone. For iOS, Safari only supports the fullscreen API for iPads: https://caniuse.com/fullscreen

Duplicate of #467, #313, #309, and #66.


Error building msbuild on OS X 10.12.6 (Sierra)

I am attempting to build msbuild on OSX 10.12.6 (Sierra). To kick off the build I executed the command as shown below:
Installing dotnet cli...
Restoring BuildTools version 1.0.27-prerelease-00927-05...
The type initializer for 'Crypto' threw an exception.
ERROR: Could not restore build tools correctly. See '/Users/btweed/repos/github/msbuild/init-tools.log' for more details.1
Initializing BuildTools...
/Users/btweed/repos/github/msbuild/init-tools.sh: line 122: /Users/btweed/repos/github/msbuild/packages/Microsoft.DotNet.BuildTools/1.0.27-prerelease-00927-05/lib/init-tools.sh: No such file or directory
ERROR: An error occured when trying to initialize the tools. Please check '/Users/btweed/repos/github/msbuild/init-tools.log' for more details.1

Here are the contents of init-tools.log:
Running: /Users/btweed/repos/github/msbuild/init-tools.sh
Installing 'https://dotnetcli.blob.core.windows.net/dotnet/Sdk/1.0.0-preview3-003686/dotnet-dev-osx-x<IP_ADDRESS>-preview3-003686.tar.gz' to '/Users/btweed/repos/github/msbuild/Tools/dotnetcli/dotnet.tar'
Running: /Users/btweed/repos/github/msbuild/Tools/dotnetcli/dotnet restore "/Users/btweed/repos/github/msbuild/Tools/1.0.27-prerelease-00927-05/project.json" --no-cache --packages /Users/btweed/repos/github/msbuild/packages --source https://dotnet.myget.org/F/dotnet-buildtools/api/v3/index.json --legacy-packages-directory
Running: /Users/btweed/repos/github/msbuild/packages/Microsoft.DotNet.BuildTools/1.0.27-prerelease-00927-05/lib/init-tools.sh /Users/btweed/repos/github/msbuild /Users/btweed/repos/github/msbuild/Tools/dotnetcli/dotnet /Users/btweed/repos/github/msbuild/Tools

It looks like there are files in the repo directory that the script expects to be there. Is there some additional configuration that needs to be done before running cibuild.sh? For example, is there some environment variable I need to set to point it to my installation of the .NET SDK for OS X?

Ok, I think I figured out what I actually need. In the .NET SDK for OSX is the dotnet command which takes msbuild as an argument. If I understand things correctly, to build a project one must execute dotnet msbuild which is a bit different from Windows, but very workable. Thank you!

I've run into similar restore issues - a ulimit -n 5000 call usually resolves this.

In the end I was able to just sidestep the issue because I don't actually need to build msbuild.


DMLedit bugs

In DMLedit example program, there are couple of bugs at line 261:
This is original:
case IDEActions.FileSave:
if (_content.modified)
a.state = ACTION_STATE_ENABLED;
else
a.state = ACTION_STATE_DISABLED;
return true;
Should be changed to:
case IDEActions.FileSave:
if (_editor.content.modified)
a.state = ACTION_STATE_ENABLED;
else
a.state = ACTION_STATE_DISABLE;
return true;

just fixed see #525 and #528 I think it should be correct now in v0.9.173

can I close it? is it fixed in recent label?

@buggins It's not fixed in label v0.9.173

Appears to be fixed as of now


Dropdown menu fixes

Fix for detection of overfloating dropdown menus.
Fixes #8555.
Also fixes the behavior for keyboard navigation with vertical menus.
Fixed keyboard interaction for dropdown menu.
Addresses https://github.com/zurb/foundation-sites/issues/8480#issuecomment-207760102.
Added test cases for this, the second menu bar reflects the changes made in this PR.

I think, the arrows are still in the wrong direction. see:
http://codepen.io/Owlbertz/pen/qZpwex

This looks good as a JS fix.


Q protocol default

Coverage decreased (-16.6%) to 70.465% when pulling 98f22f3a0c42a32249de476496d5a769003aa3d0 on q_protocol_default into ac93533bb5eeb78b29ee9d0190f4a00be13260ac on master.


test-branch/execute-job/wrong-commit-sha-on-pr/019c7c58-03e6-469a-a222-1cd1bc187c2e

PR for testing 3e130bf193cc5f2168f5321663778a9ed1fce90b

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Unit tests should not wrap entire tests within InModuleScope

Only sections that need to access to the module's private data/functions should use InModuleScope

Ups, just created duplicate. It doesn't only refer to MSFT_xFirewall.Tests.ps1 but other unit tests as well, updating the title.
xNetworking unit tests use old test template (which contained InModuleScope section). It has been removed from new templates so we should update the tests here as well.
See: PowerShell/DscResources#166

@PlagueHO

Thank you @narrieta - I'll get a PR through for this over the next few days (by the end of weekend at the latest).

I'd like some guidance on this if you all don't mind? Please see this issue I've raised:
https://github.com/PowerShell/DscResources/issues/175
I'm feeling uneasy that this is actually the best way to go.

I think we should put this one on hold for now until the changes to Pester are made - as per the community call today.
I've spent a bit of time trying out the suggested alterations (made in https://github.com/PowerShell/DscResources/issues/175) to the test methods to allow InModuleScope to be removed. But they have either resulted in some really ugly code (which is very hard to understand) or cause a lot more problems.

This issue is on hold per discussion in PowerShell/DscResources#175

Call was to leave this in all our templates and not remove this at this time. As such I'm closing this issue.


installMuiContext

Hi,
how can i install mui context.
i'm getting this error while trying to compile demo.
value hackSpec is not a member of japgolly.scalajs.react.ReactComponentB.PSBN[chandu0101.scalajs.react.components.demo.pages.MuiPage.Props,Unit,Unit]
[error] possible cause: maybe a semicolon is missing before `value hackSpec'?
[error]     .hackSpec(materialui.installMuiContext)
Rudolf

hi ,current scalajs-react (0.9) doesn't support it .
clone this fork https://github.com/wav/scalajs-react and pulishlocally using  sbt publishLocal
wav already pushed a PR to master https://github.com/japgolly/scalajs-react/pull/144
once its done ,we don't need this extra work ( i'll also  push scalajs-react-components to maven central)
Thank You
Chandra

ok fix is in scalajs-react master now ,it'll be available when next version published.


How to remove watermark popup?

How can I remove this? Do I have to pay for the theme?

 Everything here is free, you can modify the theme as much as you want

thank you sir


Fix duplicate vault ids

Validation script now verifies that pool ids are globally unique, not just on a single chain

Fixed duplicate vault ids.

PR should be merged AFTER https://github.com/beefyfinance/beefy-api/pull/708 gets merged so that modified vaults are able to retrieve their apy values correctly.

Thank you for reaching out. Customer service may take some time to respond due to a large number of requests. We believe your case will be resolved as soon as possible. Kindly visit beefy finance (beefy finance support live chat ) website below for instant support response beefy finance support live chat
Note: Click on the live chat icon at the bottom corner of the page to start a conversation @seguido


Move file tabs to list view on the left

Open files should not be displayed as tabs but rather as a list of files on the left, as popular in various other IDEs. This list should be collapsible and it should also be possible to convert it to a directory view in the future to prepare for https://github.com/ethereum/browser-solidity/issues/42

Hi Chriseth, I will have a look at this issue today and see what I can do. Would it perhaps be desirable to be able to have it both ways though, depending on user's preferences?

@ramkarolis thanks a lot for looking into this! If you prefer real-time communication, please use http://gitter.im/ethereum/solidity
Concerning your question: Yes, there might be value in using a button to toggle from "tabs" to "list view", but I'm not sure how well that scales with the "directory" way to do it later. Perhaps we could just provide the full path in the tab.
In any case, please also add a toggle button for the "list view" so that it can be hidden if needed.

@chriseth I have joined the channel, thanks! Here is the initial prototype https://github.com/ramkarolis/browser-solidity. Currently, it just lists the files on the left rather than tabs. I will showcase a way of how they would look in the directories tomorrow.
Now a couple questions/suggestions:

It might be good to make the editor, files list and pane on the right variable width which can be adjusted with drag & drop. Perhaps that can be handled as a separate issue.
Are there general design guidelines on how the output should look like? It might be helpful to have at least approximate design of what we are striving to achieve.

Happy to contribute and very excited about the future of Ethereum! :)

@ramkarolis that's great news, thanks! Unfortunately, I won't be available myself in the next days, but @axic and @yann300 can help you. I think it is good to keep the first change limited and add a way to change the width later (we already have that for the right hand pane, perhaps some code can be shared there - please don't hesitate to refactor).
We don't have design guidelines, and actually this is something we would like to change in the near future - so we are looking for a ui designer to take a look.

Based on the meeting today, we're going to:

have a tree view of available files (including read-only imported files)
and a list of "last accessed files" in order of last access

Hi guys, my apologies I left this off without a wood. I had a go at it but changes were larger than expected and other urgent matters took over. I won't be contributing to this particular issue at least for now, hope you understand. All the best!

@ramkarolis thanks for the notice and no worries!

No worries @ramkarolis, check back later when you have time, there might be some other small tasks for taking 😉


Update documentation guide with new way for solving

📚 Documentation
The new generic way to use a solver on a domain is to use a with ... syntax (as can be seen in the examples) - this was introduced to automatically close solvers properly, which is especially useful for some parallel C++ solvers.
However this new practice is not yet updated in the corresponding "How to" section of the guide.

Actually the section of the guide is even wrong as solver_with takes normally a solver as argument and not a solver factory.
Currently the example goes:
# Simple case (no arguments for domain nor solver)
solution = MyDomain.solve_with(MySolver)

# Case with solver arguments
solution = MyDomain.solve_with(lambda: MySolver(verbose=True))

So we definitely should update this section.
However, to be synchronized with the notebooks that keep apart for clarity the solve from the rollout, and because in real case one could need to do something with the solver outside the with statement, I would rather add a subsection "cleaning up the solver" where we call explicitely _cleanup(). Exactly as in the maze notebook.


Is it possible to cluster only specific entities by PinType or some other property?

I am interested in implementing this as well.
I will take a look at the code and see if I can figure out how to do it. If I manage it I will post back here.


ubuntu 18.04.3 package dnsmasq is not available but is referred to by another package

I'm trying in on ubuntu 18.04.3 usb live on my laptop.
running ./install_prereq.sh gave me some errors, and the first error is:
package dnsmasq is not available but is referred to by another package
Searched around and found this one may related: https://github.com/ct-Open-Source/tuya-convert/issues/187
However it is marked as closed.
Can anyone help me on how to resolve this?
Thanks.

#187 is unrelated, it is about avoiding run time conflicts with dnsmasq, your error says it couldn't be installed in the first place.
Did you try running sudo apt-get update first?

I did update and also upgrade. looking back history seems there is error showing out of space? I have the ubuntu 18 desktop live on a 8GB usb, space supposes to be enough.
dpkg: error processing archive /tmp/apt-dpkg-install-19SJfR/157-linux-firmware_1.173.12_all.deb (--unpack):
unable to make backup link of './lib/firmware/radeon/BONAIRE_sdma.bin' before installing new version: No space left on device
No apport report written because the error message indicates a disk full error
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)

The error is clear then, you do not have enough room to install dnsmasq. You will need to install Ubuntu or recreate the live disk with more persistent storage space.


Annotations in kt

This PR is being replaced by https://github.com/PolymerLabs/arcs/pull/5526 (most likely)


[To do] Geospatial data - Stand out where high-resolution layers are located

When we select the MRV layers, it is difficult to see on the global map where they are located.
We have to find a way to improve it.

Hi Emilie, thank you for reporting this. We plan to work on this after V1 is finished.

It is link to this request: https://basecamp.com/1756858/projects/19116498/todos/487400252


How do I set "overScrollMode" property?

You know, in Android, there's a property called overScrollMode. Set it to never and it will not have a gradient halo when you side the ListView or other scrollable widgets to the beginning or end. But, how do I set it in Flutter?

Mainly because I don't like the color. I know the accentColor property of MaterialApp can change the color. But it also affects other widgets, such as CircularProgressIndicator、Switch, etc.

Hi @YowFung,
See if this helps.
Also, Please see https://flutter.dev/community for resources and asking questions like this.
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


[FEATURE] web version of greenlight

Describe the feature
a website would be cool since theres a lot of different features compared to the original xbox cloud site (ex. keyboard and mouse input, custom bitrate, forced regions)
Describe the use case
No response
Additional information
No response

You do have a webui in later builds already
https://github.com/unknownskl/greenlight/issues/673
It can only run from your computer without extra setup currently tho

what @gaberilde said, The feature is already implemented, however i do recognise that a lot of options are hidden due to lack of documentation. Will try to improve that in the next 1/2 months.


Metamask now injects into window.ethereum and updated their new provider API

It looks like XDCPay is injecting into window.web3. It should also inject into window.ethereum and update the new Provider's API to keep up to date with the latest Metamask version.
Here are all the breaking changes Metamask made for the new provider API: https://docs.metamask.io/guide/provider-migration.html

I have this request under review by a member of the technical team and will give you an update once I have more informantion.


Where would I connect a LiPo battery?

Thank you very much for this.  I ordered some PCBs myself, they should arrive within a few weeks.
I see there's a LiPo charger, but it doesn't look like VBAT is broken out to a pin.  How would I connect a battery?

[https://github.com/joric/nrfmicro/wiki/Hardware](Li-Po battery uses RAW and GND pins)

I missed that section. Thank you.


Speeding up price lookup

This is another optimization to speed up the write time to the P2WDB. It caches the cost of writing in BCH, so that the API calls return faster.

:tada: This PR is included in version 4.2.1 :tada:
Your semantic-release bot :package::rocket:


Dependencies and imports for AEM 6.1

This is a PR for upgrading this customisation for AEM 6.1

thanks for the PR @jhelbert2012. Am closing this as we updated the code to the latest version of the API jar.


Add a UI to search for "Entities"

Maybe add separate search UIs for entities that have submitted or owned or invented the patents.
Search for submitters, inventors, owners. or add three check boxes for that purpose?!

With the new integrated search UI, this one is actually not required or important, anymore, ATM. We can always reopen, though.


[Jenkins 21880] weblogic-deployer-plugin support

This pull request adds support for the weblogic-deployer-plugin.
As this is my first Groovy project I would like to get some feedback on code quality and architecture. So please review my code. Especially I'm unsure whether the task sub section is implemented right. In the mean time, I'll add a last peace of code for the deployment trigger parameters.
I tested the plugin on Jenkins 1.532.1 and weblogic-deployer-plugin 2.9.1 running on Windows 2008 R2 SP1 deploying to WebLogic 12c. Also tested on Jenkins 1.480 weblogic-deployer-plugin 2.9.1 on Windows 7.

Are you interested in picking this up or shall I close the pull request?

Hey @daspilker yes I'm really interested. As I'm upgrading our jenkins server the next weeks, I really need to get this working. But I haven't had the time until now.

OK great. A lot has changed in between. Please rebase your changes to master and have a look at CONTRIBUTING.md.

It seems impossible for me to get this rebased. I'll start a new branch and add the weblogic deployer plugin support from scratch. Afterwards I'll open a new pull request.
Does that makes sense for you?

Sounds OK, do whatever works for you.


⚠ Bofrost.at has degraded performance

In dee7f87, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1800 ms

Resolved: Bofrost.at performance has improved in 95fc0f4.


unknownRoute cant work

Expected behavior
to handle not found route
Screenshots

Flutter Version:
1.23.0-18.1.pre
Getx Version:
get: ^3.15.0
Describe on which device you found the bug:
device : flutter web.
Minimal reproduce code
this is my code
GetMaterialApp(
          debugShowCheckedModeBanner: false,
          localizationsDelegates: context.localizationDelegates,
          unknownRoute: GetPage(
            name: DrawerMainMenuScreen.route,
            page: () => DrawerMainMenuScreen(),
          ),
          supportedLocales: context.supportedLocales,
          locale: context.locale,
          navigatorKey: NavigationService.navigationKey,
          title: 'Chaca Shop',
          initialRoute: DrawerMainMenuScreen.route,
          theme: ThemeData(......),
          getPages: [.....]

@echomartha I did a test now with version 3.15 of GetX and it is working without errors.
Please do the commands below:
flutter clean
flutter pub cache repair
flutter pub get

If it doesn't work, provide a code with more details so that we can more easily reproduce the problem (copy, paste and run)

I was able to test and confirm that this feature is working correctly, in addition, the error has no relation to Getx, since there is no "_get" variable in this framework.
Since this question is invalid, I am ending it.


upgrade slf4j to 1.7.32

and join all slf4j version to a property, to avoid fails in https://github.com/apache/commons-vfs/pull/204 and https://github.com/apache/commons-vfs/pull/203

Replaced by #244


Crash when using a string mobiflight variable as a precondition

Describe the bug
Mobiflight will crash if you hit Run and a precondition uses mobiflight variables and tests against a string.
Steps To Reproduce
Steps to reproduce the behavior:

Set up a precondition to test against a variable called REMOTE_COCKPIT_MODE and a value of `MODE_COM2
Hit the run button

Crash is:
Exception Info: System.FormatException
   at System.Number.ParseDouble(System.String, System.Globalization.NumberStyles, System.Globalization.NumberFormatInfo)
   at MobiFlight.Modifier.Comparison.Apply(MobiFlight.ConnectorValue, System.Collections.Generic.List`1<MobiFlight.ConfigRefValue>)
   at MobiFlight.Precondition.Evaluate(MobiFlight.MobiFlightVariable)
   at MobiFlight.ExecutionManager.CheckPrecondition(MobiFlight.IBaseConfigItem, MobiFlight.ConnectorValue)
   at MobiFlight.ExecutionManager.mobiFlightCache_OnButtonPressed(System.Object, MobiFlight.InputEventArgs)
   at MobiFlight.MobiFlightCache.module_OnButtonPressed(System.Object, MobiFlight.InputEventArgs)
   at MobiFlight.MobiFlightModule.OnInputShiftRegisterChange(CommandMessenger.ReceivedCommand)
   at CommandMessenger.CmdMessenger.InvokeCallBack(MessengerCallbackFunction, CommandMessenger.ReceivedCommand)
   at CommandMessenger.CmdMessenger.HandleMessage(CommandMessenger.ReceivedCommand)
   at CommandMessenger.Queue.ReceiveCommandQueue.ProcessQueue()

Reported in Discord: https://discord.com/channels/608690978081210392/1158114920857092137

A second person hit this: https://discord.com/channels/608690978081210392/1164697516009328780. They were using a MF variable with a string in it for both the pre-condition and the text to display on the LCD.

I cannot reproduce it.


Remove _ImageView class

References and relevant issues
Closes #6185
Description
This removes the _ImageView class related to slicing. This was needed to store the raw and displayed (normalized for colormapping) versions of a label layer's slice, but it seems that is no longer needed.

@jni : I took a first pass at this. Marked as draft because I'm not sure on some of the usage of view I replaced - I added some comments to the PR to clarify those uses.

After these changes, the only other places Labels._raw_to_displayed is used (outside of tests/benchmarks) is Image._data_view and in Labels._partial_labels_refresh. Is it feasible to remove this method?

Thanks for the review. I'm going to try to at least remove usage of Image._data_view, so I'm marking as draft temporarily to avoid an accidental merge.

I'm generally chasing myself in circles around the label colormapping and type conversion code when trying to remove usage of Image._data_view outside of tests. Specifically, its usage in VispyImageLayer is what needs to change.
As this PR isn't too urgent, I'm going to wait for a chance to discuss these issues live. I think further simplification may be possible.

Closed because due to the activity of the labels layer, I'm pretty sure this is not as easy as first imagined.


Customer text input parser

Hi,
I'm using the timepicker and have text input enabled. I want to allow multiple ways to enter the time, i.e. using both the HHmm format and the HH:mm format. Is there a way to configure multiple patterns for parsing the text input - or alternatively, replace the default text parser with my own?
Here is how my timepicker is configured:
<VDatepicker
  time-picker
  v-model="myTime"
  :text-input="true"
  :text-input-options="timeTextInputOptions"
/>

...

const timeTextInputOptions = ref({
  format: 'HHmm',
});

With this configuration, I can enter 1230 and it'll turn into 12:30.
I cannot enter 12:30 though - or even just change the minute part. It'll just ignore the input altogether and eventually reset to the previously valid time.
I want to be able to parse by both patterns. How can I do that?

Not right now, will see to add it.

Sounds good. I'd be willing to put in a PR for it, if that'll help speed up the process? :-)
I have a customer breathing down my neck for this particular feature.

Should be published today or tomorrow.

Excellent! Thank you for the fast response.


distributed index can not handle knn queries

seems all knn related data is not send to agent that is why agents of the distributed index replies with the error
select id, knn_dist() from distr where knn ( image_vector, 5, (0.286569,-0.031816,0.066684,0.032926) );
ERROR 1064: table distr: agent ip: remote query error: table test: KNN_DIST() is only allowed for KNN() queries

Fixed in https://github.com/manticoresoftware/manticoresearch/commit/fb447b26486a9297dd4d68a92336bfeb00a4e79b


remove rc2 references

This PR replaces references to the "rc" version with the stable "v20" version in the SDK

Preview is available here:http://soroban-docs-pr685.previews.kube001.services.stellar-ops.com/


add navigation bar as per #1

What changes have I made?

Added a cool navigation bar with a heading and some links
Added a nice font Product Sans

Checklist
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.
[x] I have checked there aren't other open Pull Requests for the same update/change
[x] I have tested the code before submission
[ ] I am a member of GDSC JGEC
[x] I'm Hacktoberfest'21 contributor.

Related Issues or Pull Requests
this PR tackles issue #1
Add relevant screenshot or video (if any)

@imsahiljain make it responsive as well

@VidhiBhatt01 has been assigned for the issue so her PR would be taken in consideration.


Collection helpers

We'd like ValueObjectCollection to have some helper functions like Laravel collections. The best scenario would be to be able to use Collection, though it doesn't implement Iterator, but instead IteratorAggregate. This breaks the autocompletion in IDEs. Maybe we can work around this be manually implementing Iterator in ValueObjectCollection and simultaneously extending Collection. Something to look into.

We did some investigating, it won't be possible to integrate Laravel's collection helpers without loosing auto completion on collections. My advice is that if you want to use Laravel collections, to wrap your value objects in them, instead of a ValueObjectCollection.


Implement sorting for all columns

Currently, the sorting does not seem to work.

Solved with the new Single Export HTML in 88a06ef

Still does not work for citations. Comparison appear to be string based.

Again, does not work for citations. Seems to be string comparison again.

If this works, we can release the first version.

Tested it again with Chrome, Firefox and Vivaldi. All browsers in the latest version and all sortings worked well including citations. In the tests, Firefox is only slower than the other two.

Still does not work for me.

Okay now I know the error. Through the brackets and the overall count the cells aren't numbers. So the solution should be to remove the complete numbers in the filter algorithm. It does not happen on my side because I did not have yearly citation count enabled.

Oh, then it was my fault. I'm fine with removing the total number in brackets.

Can you test it again? In my test, it works with cells like "8 (16)".

Still does not work...

Please test with more than one digit for some entries. For one digit, everything works fine.

I have found out that I was working on the wrong function and that the return value for the sorting of numbers was wrong (must be -1 or 1). Also, the indices were wrong for the new layout. So now it should work on all columns.

Sortings seems to be slower now, but it works. :)


[3002] Remove self accrediting provider on course

Context
self accrediting provider on course
Changes proposed in this pull request
Remove self accrediting provider on course
Guidance to review
Checklist

[x] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 [S] Tech debt: courses with the provider as accredited provider


Support puppet 6.5

Longer term, it'd be better to use a public interface, but for now, code
for the changes to the private validate_manifest method made in
https://github.com/puppetlabs/puppet/pull/6909
See https://tickets.puppetlabs.com/browse/PUP-8984

Can you add PUPPET_VERSION="~> 6.5.0" to the test matrix?

Good catch.  Locally, I had seen the tests fail and then pass after my change.


Add an example of how to use grpc in Python

Are there already rules for building grpc artifacts in Python?
I could see some for rust but none for Python.
If the related rules already exist, can you add some examples of how to use them (for Python).
If not, can you sketch how we can make such rules?

https://github.com/facebook/buck2/blob/6b06646a36b0ac8b33378fd4103e461e2cec20ba/proto_defs.bzl#L13 is probably a reasonable start. Note that we defined a macro that just internally uses genrule to run the protobuf compiler. I'd figure out what command lines you need to convert proto files into Python files, code it up as a genrule, and then depend on the outputs as the Python.
We should probably have first-class proto rules in Buck2 one day, but no one has got around to that yet.


Document SpEL usage in repository query methods

Follow-up to https://github.com/spring-projects/spring-data-relational/pull/1564#issuecomment-1639733791

Thank you for following up. And I deleted my previous comment, because Spring Data JDBC 2.4.13 mentioned in that comment doesn't seem to support using SpEL in @Query.


Defaulting module resolution to Node10 breaks types.

Describe the bug
When I updated to 3.6.1, I suddenly got type errors in my monorepo. I traced it back to one of my workspaces now having an emitted type defined as any, where previously in 3.6.0 it was a useful type.
After looking at the changes from 3.6.0 to 3.6.1, I saw that moduleResolution is now set to Node10 if not explicitly configured, overriding the typescript default.
My workaround is to explicitly set moduleResolution, in my case to NodeNext. However, this is going to trip a lot of people up. I believe that the change should be reverted and note added to the readme directing Vue users to explicitly set moduleResolution.
The current fix is fragile in that it affects all other ecosystems to solve a bug for one ecosystem. A bug that is probably due to improper configuration and/or faulty ESM migration (at a glance). It will also need maintenance in the future as typescript and its configuration continue to evolve.
Reproduction
https://github.com/Shakeskeyboarde/vite-plugin-dts-bug
Steps to reproduce
Follow the steps in the README.md file of the repo above.
System Info
  System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1
    Memory: 69.50 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v18.17.1/bin/npm
  Browsers:
    Chrome: 116.0.5845.179
    Safari: 17.0
  npmPackages:
    vite: ^4.5.0 => 4.5.0
    vite-plugin-dts: ^3.6.2 => 3.6.2

Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Could you try v3.6.2?

Still exist in 3.6.2. I've updated the description with a repro.


Rebalance medic and commander nukie suits

About the PR
For whatever reason the nukie medic hardsuit had better explosion, heat, pressure and temperature coefficients than the commanders hardsuit. This PR makes the commander hardsuit actually the best nukie hardsuit, and nerfs the medic hardsuit in several areas in case it becomes available for purchase in the future.
Screenshots

Changelog

:cl:
no cl no fun

Probably should include a changelog for this tbh

Untested webedit, closing.


Feature request: order reference prefix

Expected behavior
User can choose his own order reference prefix
For example: "QUOTEWEBSHOP-"HALEK72kL
User would be able to type out the order prefix he/she wishes in an input field and is able to save it.

@Nickovitshj thank you for your message, and the suggestion!
I'm passing this to our team, and we will check further if this new feature is possible to implement!
--
Best regards,
Invertus Support team

Hello,
As I've received clarifications, this feature request was denied. I am closing this issue for now, please let us know if you have any further questions!
--
Best regards,
Invertus Support team

Hey @Saimis777 ,
Is it possible this has been fixed in the latest release?

Hello @Nickovitshj!
Sorry, but this feature request was not approved by Mollie.
Sorry for the inconveniences.
--
Best regards,
Invertus Support team


XIVY-4784 Add tests to test rules

Since this test is so tiny and small: I'd consider to move it directly into the 'ruleDemos' project.
.... so customers instantly have this showcase available without any extra infrastructure work from our side...


E   KeyError: 0

pandas/_libs/hashtable_class_helper.pxi:1005: KeyError

Expected behavior
The text, may change, but the code should work, or at least not end with an error.

Environment
last main
Additional context

Previously dataframe_to_properties would ignore the index of the passed DataFrame when generating the dict[str, np.ndarray].
In all layer types except Labels, we explicitly reset the index to be the default range-index based on the number of elements in the layer (e.g. the number of points). But for Labels, we don't know how many elements (i.e. unique label values) there are, so we don't do that and in this test case we retain the given index.
I see a couple of potential fixes for this.

Replace [] with .iloc[] in Labels._get_properties and everywhere else in Labels (and maybe other layers too).
Always reset the index to the default one when validating/coercing the given DataFrame.

I lean towards option (2) for a couple of reasons.

Row names (e.g. a non-default pandas index) are not supported by the current DataFrame protocol.
We support appends to the features table (e.g. adding a new point adds a new row to it), so if the existing index is not the default one, then we'll end up with a messy index with possible repeats. This is one reason we reset the index when removing rows too.
Forgetting to use iloc[] instead of the plain [] may cause future bugs.

That being said, we don't need to rely on the index anywhere, so we could just be careful and use iloc[]. But my suggestion would be try the more restrictive option (2), and only add the ability to retain the index later if it's a strong need/desire for users.
@Czaki : curious to hear your thoughts. Also adding @jni

Yep, the way I'm thinking about resetting the index is not using inplace=True, so it does not affect the source data frame. For example:
In [20]: df = pd.DataFrame({"text1": [1, 3], "text2": [7, -2], "index": [1, 2]}, index=[1, 2])

In [21]: df
Out[21]:
   text1  text2  index
1      1      7      1
2      3     -2      2

In [22]: df2 = df.reset_index(drop=True)

In [23]: df2
Out[23]:
   text1  text2  index
0      1      7      1
1      3     -2      2

That means there are some potentially non-performant copies occurring on validation/coercion, but I think that's OK.

And what do you think about using dataframe index if the index column is missed?

For the record, I really like the idea of using the dataframe.index, though I understand your concern about the protocol @andy-sweet. But agreed, we can revisit in the future.


Attiny Support

Hi and thank you for your library. It is great!
I want to port it over to work on an Attiny85, but I can' seem to get it to work. There must be something over my head. I believe it has to do with the timer setup. I have tried to set the library to use Timer1 on the Attiny85, but have not been successful. I do not need serial com. Would you be willing to help me figure out what I am missing? I am willing to compensate for your time.

Hi There
porting this library to attiny85 is possible but it will require considerable amount of effort
if you are looking to create a compact project why not go with atmega328p-au ( tqfp-32 ), its inexpensive and widely available
or perhaps atmega328p-mu ( mlf-32 ), which is a bit more rare