Consider using java.util.logging instead of SLF4J

This will make this library require zero dependencies during run time.

SLF4J was introduced in https://github.com/jmdns/jmdns/pull/47, what was the motivation @kaikreuzer? The PR doesn't explain why

I kindly disagree. IMHO slf4j is the de facto interface for logging, so that users can freely decide on their logging framework.
Switching back to ˋjulˋ would be

A breaking change
Introduce a dependency for people who use something else than ˋjulˋ
Using a different ˋLogManagerˋ involves AFAIR setting a system property which might be an even bigger change (depending on the specific deployment) as one cannot use a different JAR as a drop-in replacement

Not strictly connected to this topic .. but I think it would be a good idea to add a logging implementation for the tests, i.e:
<dependency>
	<groupId>ch.qos.logback</groupId>
	<artifactId>logback-classic</artifactId>
	<version>1.3.14</version>
	<scope>test</scope>
</dependency>

or any other logging framework. Strictly with test scope. What do you think? Should I raise a separate 'issue' for this?

I kindly disagree. IMHO slf4j is the de facto interface for logging, so that users can freely decide on their logging framework.

JUL isn't perfect, but it pays off for not requiring any external dependencies, which is really important when providing a library.

Switching back to ˋjulˋ would be

A breaking change

No, the Logging API isn't exposed so no API changes are required, just the implementation.

Introduce a dependency for people who use something else than ˋjulˋ

That makes no sense to me, JUL is part of the JDK and doesn't introduce any new dependency

Using a different ˋLogManagerˋ involves AFAIR setting a system property which might be an even bigger change (depending on the specific deployment) as one cannot use a different JAR as a drop-in replacement

Again, we're talking about a library here, you can still use SL4J in your application and have the logging output produced using JUL in the same place, without changing a single line of code.

Not strictly connected to this topic .. but I think it would be a good idea to add a logging implementation for the tests, i.e:
<dependency>
	<groupId>ch.qos.logback</groupId>
	<artifactId>logback-classic</artifactId>
	<version>1.3.14</version>
	<scope>test</scope>
</dependency>

or any other logging framework. Strictly with test scope. What do you think? Should I raise a separate 'issue' for this?

Moving to JUL wouldn't require any new logging implementation dependency either, so I don't think that will be necessary if this is done

Again, we're talking about a library here, you can still use SL4J in your application and have the logging output produced using JUL in the same place, without changing a single line of code.

Let's suppose I have an application which is using SLF4J and I'm using a library which is using JUL (JmDNS 3.4.2).
What should I do in my application to have the library's log next to my application's log?

@janossch Ah I see your point. There are solutions like https://mvnrepository.com/artifact/org.slf4j/jul-to-slf4j to bridge the calls to the SLF4J API, but it depends on the the SLF4J logging implementation you use, but using the SLF4J API may be easier to avoid any extra work in this case (also maybe this was the motivation why it was changed in #47).
Anyway, feel free to close this issue.

I kindly disagree. IMHO slf4j is the de facto interface for logging, so that users can freely decide on their logging framework.

JUL isn't perfect, but it pays off for not requiring any external dependencies, which is really important when providing a library.

IMHO it doesn't. It's a PITA. There is a reason slf4j came to life. The only downside of slf4j is that now there are two major version 1.x and 2.x which might introduce conflicts based on the state of other libraries used.

Switching back to ˋjulˋ would be

A breaking change

No, the Logging API isn't exposed so no API changes are required, just the implementation.

It is for multiple reasons:

Any tools used to analyse logs, would now have to deal with different names for log levels SEVERE, FINER, etc.
If one uses other libraries in addition JmDNS one would have to set a different LogManager

One needs an additional JAR to bridge from jul to the loggin framework of choice
One needs to set the system property for the JVM so that the specific LogManager is used
If one happens to have software including JmDNS running on embedded devices one would not only have to update JARS but also the JVM settings, maybe even remotely.

It's also fun to find a WARN / ERROR message and to remember search for .severe in the code...

Introduce a dependency for people who use something else than ˋjulˋ

That makes no sense to me, JUL is part of the JDK and doesn't introduce any new dependency

Please read my words:

for people who use something else than ˋjulˋ

Means any deployment which is NOT using jul as their default logging framework needs an additional JAR to bridge from jul to the logging framework of choice.

Using a different ˋLogManagerˋ involves AFAIR setting a system property which might be an even bigger change (depending on the specific deployment) as one cannot use a different JAR as a drop-in replacement

Again, we're talking about a library here, you can still use SL4J in your application and have the logging output produced using JUL in the same place, without changing a single line of code.

As most libraries already include a dependecy to slf4j one wouldn't get anything out of it, expect when having JmDNS as the only dependency.


feat(gateway): Allow setting initial resume_url

Adds equivalents to the existing session related functions for resume_url to Config, ConfigBuilder and Shard
closes #2324

Just missing a quick cargo fmt and then we can merge it.

done :3

Thanks for the PR!


gnome3.{gnome-shell,metacity,gnome-flashback}: fix build

Motivation for this change
Resolve these errors,

the gnome-shell missing EGL header (mesa dependency fixed this)
metacity missing xorg.libXdestroy
gnome-flashback missing xorg.libXxf86vm

For #117081
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119690 at 3fc7b85d run on x86_64-linux 1

13 packages built successfully:

adapta-gtk-theme
chrome-gnome-shell
gnome3.gnome-flashback
gnome3.gnome-session (gnome3.gnome_session)
gnome3.gnome-shell (gnome3.gnome_shell)
gnome3.gnome-terminal (gnome3.gnome_terminal)
gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
gnome3.metacity
gnome3.pomodoro
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
pantheon.elementary-session-settings

3 suggestions:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/misc/metacity/default.nix:29:5:
   |
29 |     (substituteAll {
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/misc/metacity/default.nix:70:5:
   |
70 |     license = licenses.gpl2;
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/misc/gnome-flashback/default.nix:197:7:
    |
197 |       license = licenses.gpl2;
    |       ^

Thanks. This is already broken  on staging-next so let’s fix it there.


Ian can be used in zero grav to gain (pretty much) infinite speed

Description

Well technically you can push will do and probably hamlet is better but saying ian is way funnier
I accidentally discovered this while goofing around in lizard waiting 20 mins for the shuttle
Reproduction

Grab ian
Disable gravity
Let go of your wasd keys
keep right-clicking on the direction you want to go, you will slowly gain more and more speed

Screenshots

https://github.com/space-wizards/space-station-14/assets/34938708/4ac9542b-959f-4539-8a3d-c41c1af3a277
Additional context

I do not support using this in space

use ticke instead of dog

Fixed by pulling rework not letting you keep right clicking anymore


Docs: In .sonarrc, ignoredUrls must be an object

According to the behavior of the command line app, ignoredUrls must be an object where the keys are the domains and the values are the rules.

Pull request checklist
Make sure you:

[x] Signed the Contributor License Agreement
[x] Followed the commit message guidelines

The array is the new way form for the latest unpublished version. Please see https://github.com/sonarwhal/sonar/pull/596
We merged it a few hours ago and haven't had the time to publish it yet on npm.
Thanks!


Disable "template-use-track-by-function" globally

Hello,
My tslint.json is:
{   "rulesDirectory": [     "node_modules/codelyzer"   ],   "extends": ["angular-tslint-rules"],   "rules": {     "template-use-track-by-function": false   } }
However when I run ./node_modules/.bin/tslint src/**/*.ts
I still get
src/app/components/select/select.component.html:3:10 - Missing trackBy function in ngFor directive
Is it possible to deactivate this rule for all templates?

It should work. Check if you don't have this rule enabled in any other tslint.json (Angular projects usually have at least 2).

My bad, it is working. Thanks a lot


Save memory from interleaved attention

Is interleaved attention the gemma-2 style attention (one layer full-attention followed by another layer of sliding window attention)?

@yzh119 Yes, this is for gemma

Close it for now. It should come up after memory pool refactor.


New feature added.

Function added:

get_illust_url(), get image url (large) with a given illustration id.

Keep only

the newly added feature
string format style
function naming style


R24.03 BPDM Golden Record / BPN Service - Release Checks

Release Info
Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
Version to be included in Eclipse Tractus-X release: version placeholder
Leading product repository: repository link
Compliance Verifications
This issue tracks all compliance related checks, that need to be performed for a product release in Eclipse Tractus-X.

[x] Gaia-X compliance confirmed
[x] GDPR compliance confirmed (personal data, data protection + privacy DPP)
[x] Interoperability checks performed
[x] Data Sovereignty checks performed
[x] Compliant with relevant published CX Standards (see the Catena-X standard library)

Documentation

[x] Arc24 documentation up-to-date
[x] Administrators Guide up-to-date
[x] End-User manual up-to-date
[x] Interface documentation up-to-date

Security Checks

[x] Thread Modelling Analysis passed
[x] Static Application Security Testing (SAST) scans passed
[x] Dynamic Application Security Testing (DAST) tests passed
[x] Secret Scans passed
[x] Software Composition Analysis (SCA) passed
[x] Container Scans passed
[x] Infrastructure as Code (IaC) scans passed

General Checks

[ ] Tractus-X Release Guidelines fulfilled https://github.com/eclipse-tractusx/bpdm/issues/757
[x] Compliant with the Style Guide

Test Results

[x] E2E Integration Test passed
[x] User Journey approved

Helpful Links

Eclipse Tractus-X openAPI specs on SwaggerHub
Catena-X standard library

No Secrets in Github Scans:

No Github Code scanning alerts:

No Dependabot Alerts:

Veracode passed:

One medium composition vulnerability:

2 Triage Flaws, both mitigation proposed, one approved. (But flaws seem to be duplicates anyway):

Threat Modeling passed and assessment currently in the process of being merged:
https://github.com/eclipse-tractusx/bpdm/pull/737
https://github.com/eclipse-tractusx/bpdm/pull/740

Interface documentation up to date for current release version:
https://github.com/eclipse-tractusx/bpdm/tree/release/5.0.x/docs/api

SAST: Approved
SCA: Approved
Trivy: Approved
KICKS: Approved

DAST no high or above issues:
Gate: https://www.netsparkercloud.com/websites/dashboard/9372f73eb7d24ca41db1b059018933cc/?scanGroupId=6b67c661-b788-44db-2f1f-b0c701e8f2f9
Pool: https://www.netsparkercloud.com/websites/dashboard/9372f73eb7d24ca41db1b059018933cc/?scanGroupId=48809087-5bb1-4773-3453-b0c2024239f4

Secret Scanning: Approved
DAST: Approved

No significant changes to last time related Gaia-X Compliance and GDPR @kelaja

We herby confirm that we considered (as good as possible) all relevant CX-Standards as well as that we reviewed the content of upcoming STAN Request as good as possible @kelaja

E2E Test passed
https://jira.catena-x.net/browse/TEST-1739
Overall Status
https://confluence.catena-x.net/x/sgA1Bw

@kelaja User Journey approved

No major architecture changes in the current release - interoperability check approved.
@kelaja

Security Assessment Process (Threat Modeling Analysis) approved.
Re-assessment was done on Wednesday 25th Jan 2024. No open critical & high findings remains.
Documentation of the assessment will be available under BPDM/docs/Security_Assessment.md

Hi all,
think there are some infos not shared within this issue would suggest:

Version to be included in Eclipse Tractus-X release: version placeholder
Leading product repository: repository link

Leading repo: https://github.com/eclipse-tractusx/bpdm
Version: 5.0.0 Am i correct?
Thanks in advance.

could you please add the links to the documentation documents to check ?
Arc24 documentation
Administrators Guide
End-User manual
Interface documentation -> I found that one already

Hi all,
think there are some infos not shared within this issue would suggest:

Version to be included in Eclipse Tractus-X release: version placeholder
Leading product repository: repository link

Leading repo: https://github.com/eclipse-tractusx/bpdm
Version: 5.0.0 Am i correct?
Created TRG Guideline Check Issue for bpdm repo: eclipse-tractusx/bpdm#757
Thanks in advance.

Yes that is correct. Chart version is 4.0.0

could you please add the links to the documentation documents to check ?
Arc24 documentation Administrators Guide End-User manual Interface documentation -> I found that one already

Arc24: https://github.com/eclipse-tractusx/bpdm/tree/release/5.0.x/docs/arc42
Admin Guide: https://github.com/eclipse-tractusx/bpdm/blob/release/5.0.x/docs/OPERATOR_VIEW.md
End-User Manual: We don't have an UI, so no End-User. There is a guide for integrating services however: https://github.com/eclipse-tractusx/bpdm/blob/release/5.0.x/docs/ADOPTION_VIEW.md
Interface Documentation: https://github.com/eclipse-tractusx/bpdm/tree/release/5.0.x/docs/api

Hi security team,
can you please check our scans.
@BANANAS1337 @RoKrish14 @PiotrStys @DnlZF
Thanks

Hi security team, can you please check our scans. @BANANAS1337 @RoKrish14 @PiotrStys @DnlZF Thanks

Hi @rybtim
What has changed since last security checks?

https://github.com/eclipse-tractusx/sig-release/issues/496#issuecomment-1935741174
https://github.com/eclipse-tractusx/sig-release/issues/496#issuecomment-1938481208

INT test performed/documented.
E2E test performed/documented.
No high defect.
TM approved
@kelaja  : please approve for "E2E Integration Test passed"

STYLE Guide: No changes to last release. No UI for Golden Record Service

QG review as per plan 21-Feb:
pending topics are DataSov & Documentation, as well as TRGs
Approval postponed until topics addressed; no follow-up mtg required.

Documentation Existing and looking consistent. Sovereignty requirements fulfilled as tehre are no specific requirements for 24.03. Expert Approval granted

all pre-conditions fulfilled and QG approval granted!
Congrats!

Critical Update:
QG approval withdrawn  until clarification of Postgresql DB issue => @HeyHardy @nicoprow @Siegfriedk
reference: violation of TRG 5.07

final conclusion: TRG 5.07 still violated (postgresql DB version 14.x) but successfully tested.
this is covered in overall release note 24.03
QG closed with these conditions.


Teapot support - Continues PR #610

Relevant Issues

Issues
Closes #428
Closes #500
Closes #608
PR
Closes #610
Description

Initial commit, starting PR from original forked branch.
Did you:

[X] Join the Python Discord Community?
[X] Read all the comments in this template?
[X] Ensure there is an issue open, or link relevant discord discussions?
[X] Read and agree to the contributing guidelines?

There appears to be an issue where it will display the status fine, and yet still shows an error:

Good stuff, just small things.
Btw, this is extremely picky so I wouldn't ask you to change it, but as python's range ends are exclusive, if for example you were looking for 2xx response codes you would check in range(200, 300) rather than range(200, 299). That said, 299 isn't a valid status code, so in practice this would make no difference at all!

I went ahead and changed it, doesn't hurt to keep things proper (and I am already making changes, so what's one more small one?).

Thanks for the patience guys, I think it should be working now!


fix(ui-components): disabled button behavior

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45712

Changed disabled button to not have active styles

Thanks @saltedTofu 👍


Potential bug in class LogTKESpectrumL2Distance

Hi,
First of all, thank you for the well-documented code, it has been super helpful and the work itself is great. I'm not super familiar with TKE, but from what I can tell from the paper/code, I was wondering if there was a bug here ?
Should this:
(log_tke_a[:, None] - log_tke_b[None]) ** 2,
be this?
(log_tke_a[:, None] - log_tke_b[:, None]) ** 2,
Again, not super familiar with TKE, but just wanted to ask since when calling:
D, _, _, _ = logTKEcriterion(data, data, mean_data)
I unfortunately don't get zero distance.
Thanks!

Hey,
great to hear that the code is helpful to you! This line computes the distance between any pair of snapshots, so if u_a and contains 5 snapshots and u_b contains 7, the output should be a 5x7 distance matrix where D[i, j] is the distance between u_a[i] and u_b[j]. That also explains, why your test does not give you a zero matrix. You probably have multiple snapshots in your data that are not all the same. However, D[i, i], i.e. the diagonal of D, should be zero.
Best,
Marten

That makes sense, thank you! Appreciate the quick reply as well and best of luck on your future works.


Router customization help

Good day! I am pretty sure I am missing something very easy, so this question may sound very stupid, but I wanted to know is there a way to override/add ignore statement to the Vue-router instance inside of Gridsome?
For now the last route is catch-all *
In vanilla router you can specify different catch-all to ignore some routes, is it available here?
My use-case is I want to ignore /api/* routes, so they could be handled my MirageJS. And so far I couldn't do anything.
Update: I know about this way of doing it but I have pretty large MirageJS setup that I would have to migrate to Express, so I would prefer not to.

I'm no expert (I just used Gridsome for the first time today, and I've never heard of MirageJS until now), but would it work to run MirageJS on a different port and just configure your project to access a different API route during development?
IDK, just an idea.

@AMFTech512, thanks for your answer! MirageJS doesn't run on Node (if it did I could have just hooked it into the Express Server that Gridsome provides), so that setup is less than ideal.


Instance Validation

Hey Guys,
I'd like to look at specific response bodies, and validate them against blueprints. Very similar to whats going on here for json schema.
https://robots.thoughtbot.com/validating-json-schemas-with-an-rspec-matcher
In particular I'd like to:

create a blueprint markdown file
create a request spec
compare the results in the response body to the markdown file.

Any help would be greatly appreciated!

Hey @keithmgould, would https://github.com/apiaryio/dredd (http://dredd.api.sexy/) work for you? It's a tool for testing your API implementation against its description in API Blueprint.

Hey @honzajavorek, thank you. I don't think dredd would work, as I already have RSpec, and don't want to add the dredd server (node, etc...).
I would like to augment my request specs, which are already pretty far along, with blueprint validation.
something like:
 expect(response.body).to be_valid_against("user")

and I'd write the custom matcher to check a blueprint directory for "user.md", or something...

Hi, I noticed you're running a similar issue directly on the API Blueprint repo: https://github.com/apiaryio/api-blueprint/issues/206 Would you mind if I close this one? In case I have an idea how to help you, I'll go there. Also, api-blueprint issue generally gets larger audience, so for a general question of this sort it's probably a better place where to ask.


Back out noarch: python

noarch: python packages with names before conda are giving trouble.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

alphabetical names?


[grpc] grpc 1.4.0

Bump the grpc release.

@jozefizso,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Patch revert-c019e05.patch already applied to 1.4.0

It compiled the port with that patch so I was not sure it's not needed.
As it is already in grpc, I remove the patch file.

Thanks for the update PR!


verkle: test vector samples & wiring

This PR contains ongoing work for Verkle Trees test vectors.
The main goal of the current state of the PR is having some test samples for EIP-6800 and EIP-4762 so we can explore the required changes to the testing library, mainly regarding:

The t8n tool needs to support a new way of verifying the post-state since we’d now have a single tree instead of account and storage trees.
The t8n tool needs to support providing the execution witness to the testing library so that the fill tool can verify that the generated witness for the test is correct.

The required changes for t8n have already been implemented, mainly in this branch.
This PR adds some sample tests that would use the new (to be wired) t8n tool features to bring down to earth what is required in the testing library. I’ll explain better in the comments.
Note that the tests might not be entirely idiomatic and couldn’t be run with fill since we’d need first to complete the wiring of this testing library with the new features.

Trying to build these so I can start trying to run the ethereumjs code against them but I'm not really sure to generate the fixtures.
I've cloned and built geth from the branch referenced in the opening post above and then was trying to build them with something like fill -v tests/osaka/eip6800_verkle_tree/test_transfer.py --fork=Osaka --evm=../go-ethereum/build/bin/evm but Osaka doesn't seem to be a recognized fork.  Do I need to add something or cherry-pick a commit from another PR to be able to fill these?

Trying to build these so I can start trying to run the ethereumjs code against them but I'm not really sure to generate the fixtures.
I've cloned and built geth from the branch referenced in the opening post above and then was trying to build them with something like fill -v tests/osaka/eip6800_verkle_tree/test_transfer.py --fork=Osaka --evm=../go-ethereum/build/bin/evm but Osaka doesn't seem to be a recognized fork. Do I need to add something or cherry-pick a commit from another PR to be able to fill these?

Talked with Gabriel, but also writing here. This branch isn't runnable yet. There's TODO work in the testing library to do some wiring with the new t8n features.

Work will continue on top of library work here: https://github.com/spencer-tb/execution-spec-tests/pull/41


Error while Installing

Hello. I encountered an error when installing using the command:
llecting git+https://github.com/Xilinx/PYNQ-DL.git
Cloning https://github.com/Xilinx/PYNQ-DL.git to /tmp/pip-req-build-tnq2hrn9
Installing collected packages: pynqDL
Running setup.py install for pynqDL ... error
Complete output from command /opt/python3.6/bin/python3.6 -u -c "import setuptools, tokenize;file='/tmp/pip-req-build-tnq2hrn9/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-ucjpjnm0/install-record.txt --single-version-externally-managed --compile:
Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
ERROR: You must give at least one requirement to install (see "pip help install")
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-req-build-tnq2hrn9/setup.py", line 106, in
install_packages()
File "/tmp/pip-req-build-tnq2hrn9/setup.py", line 48, in install_packages
subprocess.check_call(['pip3.6', 'install'])
File "/opt/python3.6/lib/python3.6/subprocess.py", line 291, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['pip3.6', 'install']' returned non-zero exit status 1.
----------------------------------------

Command "/opt/python3.6/bin/python3.6 -u -c "import setuptools, tokenize;file='/tmp/pip-req-build-tnq2hrn9/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-ucjpjnm0/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-req-build-tnq2hrn9/

Hi, Naveen :
Thanks for your comment. So does this work only on 2.2?
I am using a Digilent Z1 board which seems to be 2.1 highest according to the link.

Hi,
v2.1 should be fine.
Can you try on a new SD image?

If you want to work with 2.2, just try pip install upgrade your pynq package.

Thank you for your suggestions. Actually I am using a 32g SanDisk tf card now. I will first try to use another microsd card.
By the way, if I want to implement LSTM on PYNQ, is there any suggested solutions? Thanks again!

Here is a link that maybe useful:
https://github.com/tukl-msd/LSTM-PYNQ
you can find some other PYNQ projects here:
http://www.pynq.io/community.html

Hi:
I have just changed a card and successfully installed this package. The difference I can think of that may be the cause this problem is:
u are using pip version 9.0.1, however version 18.0 is available.
You should consider upgrading via the 'pip install --upgrade pip'
I upgraded that for the previous card but not for this card. There might be some compatible differences for these two pip versions. Thank you!


strange line in README

NOTE: The library currently doesn't build against the stable release of Rust. It builds against the nightly release of Rust. This scenario is likely to stay till Q3 2015.

Today is 2017, so it looks like (at least) this line must be corrected?

Thank you for pointing this out. Have updated the README.  It builds on stable Rust nowadays.


Azure NetApp Files support for Europe West?

Opening this issue on behalf od CX who reported this in another page here.
Issue:
I can see a difference in region support listed on this page and others.
On this page Europe West is not on the list but on the vmware solution page it IS mentioned.
https://docs.microsoft.com/en-us/azure/azure-vmware/attach-azure-netapp-files-to-azure-vmware-solution-hosts?tabs=azure-portal
This page has to be updated to reflect the supported region.
https://docs.microsoft.com/en-us/azure/azure-netapp-files/whats-new

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8380a849-c87e-6769-0c7d-c4913b5e98eb
Version Independent ID: b7192f4f-534d-69b0-40ee-38740598c28c
Content: What's new in Azure NetApp Files
Content Source: articles/azure-netapp-files/whats-new.md
Service: azure-netapp-files
GitHub Login: @b-hchen
Microsoft Alias: anfdocs

@b-hchen
Can you please check and update the document with supported regions as applicable.

@VikasPullagura-MSFT - Thanks for your comment. The corresponding ANF page has been updated
#please-close


Partial delivery with explicit EOR broken

The problematic commit is  https://github.com/sctplab/usrsctp/commit/31f4eb54578c5766cca51191a7aedb834989b0df#diff-c469b8a74df38d41956bdcdc43e4c28aL14205
Steps to reproduce:

Set up an association.
Do something to impede the connection so that messages end up getting buffered.
Send a message that almost fills the send buffer.
Send another message; usrsctp_sendv returns less than the length of the message, as expected.
Unblock the connection, allowing buffered messages to be resent.
Wait for send_cb, and attempt sending the rest of the message that was only partially delivered.
usrsctp_sendv returns EINVAL.

I haven't dug into how this works normally, but the issue occurs because on step 4, strm-> last_msg_incomplete and sp->processing are set to true, which results in hitting an error on the next send. But given that processing is only set to false if the message is complete, I don't know how this is supposed to resolve itself.
Is it possible WebRTC is still doing something wrong, or is this just not covered by any tests? @tuexen
Here's a log if that helps:
log.txt

This is a recent change to fix a use-after-free issue reported for FreeBSD. The point is that in explicit MSG_EOR mode, every send call appends to the last incomplete message. If two threads are doing this for the same stream, then there is an issue. From my view, this doesn't make sense, therefore you get an EINVAL. I set processing to 1 while one thread is processing a send() call. Maybe I missed a path where I need to clear it...

Does the following patch helps:
diff --git a/usrsctplib/netinet/sctp_output.c b/usrsctplib/netinet/sctp_output.c
index 23b66b2..918b856 100755
--- a/usrsctplib/netinet/sctp_output.c
+++ b/usrsctplib/netinet/sctp_output.c
@@ -14164,11 +14164,10 @@ skip_preblock:
 			error = EINVAL;
 			goto out;
 		}
-		SCTP_TCB_SEND_UNLOCK(stcb);
-
 		strm = &stcb->asoc.strmout[srcv->sinfo_stream];
 		if (strm->last_msg_incomplete == 0) {
 		do_a_copy_in:
+			SCTP_TCB_SEND_UNLOCK(stcb);
 			sp = sctp_copy_it_in(stcb, asoc, srcv, uio, net, max_len, user_marks_eor, &error);
 			if (error) {
 				goto out;
@@ -14196,19 +14195,8 @@ skip_preblock:
 			sp->processing = 1;
 			TAILQ_INSERT_TAIL(&strm->outqueue, sp, next);
 			stcb->asoc.ss_functions.sctp_ss_add_to_stream(stcb, asoc, strm, sp, 1);
-			SCTP_TCB_SEND_UNLOCK(stcb);
 		} else {
-			SCTP_TCB_SEND_LOCK(stcb);
 			sp = TAILQ_LAST(&strm->outqueue, sctp_streamhead);
-			if (sp->processing) {
-				SCTP_TCB_SEND_UNLOCK(stcb);
-				SCTP_LTRACE_ERR_RET(inp, stcb, net, SCTP_FROM_SCTP_OUTPUT, EINVAL);
-				error = EINVAL;
-				goto out;
-			} else {
-				sp->processing = 1;
-			}
-			SCTP_TCB_SEND_UNLOCK(stcb);
 			if (sp == NULL) {
 				/* ???? Huh ??? last msg is gone */
 #ifdef INVARIANTS
@@ -14220,7 +14208,16 @@ skip_preblock:
 				goto do_a_copy_in;

 			}
+			if (sp->processing) {
+				SCTP_TCB_SEND_UNLOCK(stcb);
+				SCTP_LTRACE_ERR_RET(inp, stcb, net, SCTP_FROM_SCTP_OUTPUT, EINVAL);
+				error = EINVAL;
+				goto out;
+			} else {
+				sp->processing = 1;
+			}
 		}
+		SCTP_TCB_SEND_UNLOCK(stcb);
 #if defined(__APPLE__) && !defined(__Userspace__)
 #if defined(APPLE_LEOPARD)
 		while (uio->uio_resid > 0) {
@@ -14271,6 +14268,11 @@ skip_preblock:
 					if (mm) {
 						sctp_m_freem(mm);
 					}
+					SCTP_TCB_SEND_LOCK(stcb);
+					if (sp != NULL) {
+						sp->processing = 0;
+					}
+					SCTP_TCB_SEND_UNLOCK(stcb);
 					goto out;
 				}
 				/* Update the mbuf and count */
@@ -14285,6 +14287,9 @@ skip_preblock:
 						SCTP_LTRACE_ERR_RET(NULL, stcb, NULL, SCTP_FROM_SCTP_OUTPUT, ECONNRESET);
 						error = ECONNRESET;
 					}
+					if (sp != NULL) {
+						sp->processing = 0;
+					}
 					SCTP_TCB_SEND_UNLOCK(stcb);
 					goto out;
 				}
@@ -14357,6 +14362,11 @@ skip_preblock:
 			/* wait for space now */
 			if (non_blocking) {
 				/* Non-blocking io in place out */
+				SCTP_TCB_SEND_LOCK(stcb);
+				if (sp != NULL) {
+					sp->processing = 0;
+				}
+				SCTP_TCB_SEND_UNLOCK(stcb);
 				goto skip_out_eof;
 			}
 			/* What about the INIT, send it maybe */
@@ -14507,6 +14517,11 @@ skip_preblock:
 						}
 					}
 					SOCKBUF_UNLOCK(&so->so_snd);
+					SCTP_TCB_SEND_LOCK(stcb);
+					if (sp != NULL) {
+						sp->processing = 0;
+					}
+					SCTP_TCB_SEND_UNLOCK(stcb);
 					goto out_unlocked;
 				}

@@ -14519,9 +14534,15 @@ skip_preblock:
 				}
 			}
 			SOCKBUF_UNLOCK(&so->so_snd);
+			SCTP_TCB_SEND_LOCK(stcb);
 			if (stcb->asoc.state & SCTP_STATE_ABOUT_TO_BE_FREED) {
+				if (sp != NULL) {
+					sp->processing = 0;
+				}
+				SCTP_TCB_SEND_UNLOCK(stcb);
 				goto out_unlocked;
 			}
+			SCTP_TCB_SEND_UNLOCK(stcb);
 		}
 		SCTP_TCB_SEND_LOCK(stcb);
 		if ((stcb->asoc.state & SCTP_STATE_ABOUT_TO_BE_FREED) ||

Seems to be working, thanks for the quick response.

Seems to be working, thanks for the quick response.

@taylor-b You mean the patch works?

@tuexen Yes, processing is now set to 0 before sctp_lower_sosend returns, all my tests are passing.

Fix committed in https://github.com/sctplab/usrsctp/commit/995c0b84414466d77d52011e5b572cbe213b770a. Thanks for testing and reporting!


display automatic translations to informal math

Thanks to work by @zhangir-azerbayev , we have a dataset of every declaration in (a recent version of) mathlib translated to natural language. People from OpenAI are interested in improving this; in principle we can regenerate these translations periodically, and update the model with user responses from the displayed translations.
There is a static json file containing the translations. It also stores the theorem name and statement that were used to generate the text. doc-gen checks that the statement hasn't changed before printing the translation, so even if we go months between updates, the worst we'll see is a lot of theorems with no translation.
All of this is WIP:

We need a doc page on the community website explaining what's going on here.
I did not try hard at all on the display stylilng. Obviously this needs to be improved. Right know I put it in a <details> menu, expanded by default to make browsing this demo easier. I think they should be collapsed by default in production, at least until the translations improve.
The response buttons don't go anywhere. We should have them pop up a window that allows the user, optionally, to correct the statement and submit. They can target a Google form or any other database.

#deploy

@EdAyers Would you be interested in helping us with UI and databases?

When the informal output includes a < in math mode, it seems to be picked up as HTML before being picked up by MathJax: https://leanprover-community.github.io/mathlib_docs_demo/data/nat/basic.html#nat.one_add_le_iff (notice that the full statement is in the source code).
I thought MathJax was smart enough to do this, it handles < in doc strings perfectly fine for instance. Do we need to manually escape this character?

@EdAyers if you're interested in helping with the UI, I have an approximate setup for the "data collection" part that needs to be hooked into the interface. We can chat.

#deploy

I thought MathJax was smart enough to do this, it handles < in doc strings perfectly fine for instance. Do we need to manually escape this character?

Do you have a docstring in mind that proves this?

I thought MathJax was smart enough to do this, it handles < in doc strings perfectly fine for instance.

Do you have a docstring in mind that proves this?

https://leanprover-community.github.io/mathlib_docs_demo/model_theory/order.html#first_order.language.sentence.densely_ordered is an example.

Even weirder, https://leanprover-community.github.io/mathlib_docs_demo/model_theory/order.html#first_order.language.term.realize_lt has both a working and broken occurence of <!

I thought I just posted this (eaten by GitHub somehow?), but, the problem is < followed by a non-space token. In principle this is an issue in normal doc strings as well as the automatic ones.
This is nontrivial but possible to replace during processing. This must have come up in relation to mathjax before, but I'm not turning up anything quickly on Google somehow.

This is not a mathjax problem, but a problem in our markdown parser. Mathjax cannot be reasonably expected to parse <, because by the time it runs the browser has already tried to parse it and made a mess.

I was planning to switch out our parser for markdown-it, but am waiting on an upstream patch...

#deploy

6c05dba is clearly a hack, but I think it should work until the markdown/mathjax interaction is fixed. (Hypothesis: the informal text will never have a < anywhere it isn't safe to insert a space after.)

#deploy

#deploy

#deploy

(the runners are backed up, the deploy may take a bit)

I reckon this is ready to merge once @zhangir-azerbayev has fixed truncated translations?

I reckon this is ready to merge once @zhangir-azerbayev has fixed truncated translations?

I've seen very few truncated translations, and regenerating the translations is costly. I think it's fine to wait to fix this until we're ready for a "next round." But there are still a few more to-dos:

Eric's concerns above about delaying mathjax processing
A toggle to collapse/expand all translation boxes
A landing page on the website describing this project -- it's a broken link right now

#deploy

#deploy

I think all of the to-dos are taken care of now (thanks @EdAyers !). I enabled lazy typesetting in mathjax, and confirmed it only processes when the display is unrolled.

I think the warning should be more visible than using a light-grey color.

#deploy
(just so that we have something interesting at the docs_demo page)


connect-to not working in OpenShift when promoted to using gitops

same as https://github.com/ibm-garage-cloud/inventory-management-bff-solution/issues/9

Fixed by #7


Key-pair auth

First, thanks for developing this adapter and making Snowflake in Harlequin possible!
Wondering if you know how to configure a connection using key-pair authorization? I have tried a connection string in my harlequin.toml like
default_profile = 'mp_profile'

[profiles.mp_profile]
limit = 500
adapter = "adbc"
conn_str =<EMAIL_ADDRESS>driver_type= "snowflake"

But I get the error
❯ harlequin
╭─ Harlequin could not connect to your database. ─╮
│ INVALID_ARGUMENT: 260002: password is empty     │
╰─────────────────────────────────────────────────╯

NOTE: 1 of 2 errors shown. Run with textual run --dev to see all errors.

I shouldn't need my password if using key pair auth?
Normally I would just create a a password and be done with this, but my employer prefers key-pair.

Thank you for raising this issue! I was able to recreate it on my end. Will try to figure what's going on here. I hoping it's a matter of just getting the URI right.

Still struggling to figure out root cause. FYI It might be awhile until I have the time to figure out what's going wrong here.


Open links to tweets in-client

Currently if one tweet contains a link to another, following the link opens it in a browser.
I think it'd be nice to open in-client. Thoughts?

I personally would love it if AndStatus displayed these tweets in-client.
...and if you're going to look up what the t.co URL redirects to anyway, maybe display that instead of the t.co URLs everywhere? (Sorry for the thread-jack.)

Blocked by #4 "Add an option to expand shortened URLs"

What's the status on this? I would also love to see this happen. Is there still something blocking the implementation?
sorry for "bumping"

I was actually talking about this very ticket: #336, not #4. however #336 and N°479 seem to be related i believe, with the only exception, that #336 also includes URLs to tweets/posts/toots/...

#336 is blocked by #4, this is why I mentioned it :-) - we cannot intercept links without knowing, where the links point to :-)
So we need to start implementation of_this_ ticket from finding good implementation of #4   "Add an option to expand shortened URLs".
Anybody?


Analyzer can't load in Visual Studio

It appears the analyzer can't run in Visual Studio because it targets .NET Standard 1.5. This is a problem, because .NET Standard 1.5 is required to have a custom AssemblyLoadContext.

I'll probably fix this by changing the Build / Compile MSBuild targets when $(BuildingInsideVisualStudio) is true. I'll work a bit more on this later.


fix and editorial grooming for CONTRIBUTING.md

This PR improves the developer experience and reduces friction for open-source contributors.
As we work together to bring Mina to the world, let's continue to iteratively improve essential user-facing content.
This PR updates the CONTRIBUTING file.

Explain your changes:

Updates to content for a first level editorial cleanup and grooming
Provides a correct link to the https://github.com/o1-labs/docs2 repository
Applies editorial styles, mostly changing "should" to "must", "once" to "after", and other non-technical updates and clarifications

Explain how you tested your changes:

No technical tests, just eyeballs on the words

Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!ci-build-me

!ci-build-me


AttributeError: 'CoxPHFitter' object has no attribute 'score'

Hi there!
My fit CoxPHFitter instances don't seem to have a score method. The documentation here suggests that they should. Perhaps I'm misunderstanding how to score a dataset with a CoxPHFitter?
Here is a simple example from the documentation that raises the AttributeError I'm running into:
from lifelines import CoxPHFitter
from lifelines.datasets import load_rossi

rossi_train = load_rossi().loc[:400]
rossi_test = load_rossi().loc[400:]
cph = CoxPHFitter().fit(rossi_train, 'week', 'arrest')

cph.score(rossi_train)
cph.score(rossi_test)

>>>
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-201-88ced0ed8d15> in <module>
      4 rossi = load_rossi()
      5 cph = CoxPHFitter().fit(rossi, 'week', 'arrest')
----> 6 cph.score(rossi)

AttributeError: 'CoxPHFitter' object has no attribute 'score'

Thank you for the help!

solved: Upgraded lifelines from 0.23.0 to 0.25.1 and restarted my Jupyter kernel.

Happy you figured it out, @seyuboglu!


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.10 to before v4.9.277",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1e0a8b13d35510e711fdf72e9a3e30bcb2bd49fa",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c263ae8c7e4c482387de5e6c89e213f8173fe8b6"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "1e0a8b13d35510e711fdf72e9a3e30bcb2bd49fa",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "c263ae8c7e4c482387de5e6c89e213f8173fe8b6",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: ti: fix UAF in tlan_remove_one\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.277 by commit c263ae8c7e4c482387de5e6c89e213f8173fe8b6, it was introduced in version v3.10 by commit 1e0a8b13d35510e711fdf72e9a3e30bcb2bd49fa. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001440


Remove deprecated podSpec field in favor of podTemplate 🛄

Changes
We introduced podTemplate in last release to specify podSpec specific
field, and deprecated nodeSelector, tolerations and affinity.
This removes those deprecated fields.
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes
Remove deprecated podSpec (nodeSelector, affinity and tolerations) fields in favor of podTemplate

code here /lgtm
not sure why the tests are having a hard time with it

@sbwsg I think I missed something :sweat_smile:


Not running on Ubuntu 18.04.5 (missing something..?)

Downloaded the Linux CLI binary (0.21, same results with e26286d9823c0b71bd02cf2e184e9031c9a273df):
file duckdb:
ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=dd8544b648321f5918a10ef3808a1f17044c6f19, not stripped
When running it: duckdb:
duckdb: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.26' not found (required by duckdb)`
I have /usr/lib/x86_64-linux-gnu/libstdc++.so.6 from package libstdc++6:amd64 , but something is wrong... This is on Ubuntu 18.04.5 LTS.

We should probably build these on an old Linux to avoid this, apologies. In the meantime, build from source?

Build from source (e26286d9823c0b71bd02cf2e184e9031c9a273df) works flawlessly!

Yeah this will be an issue. 18.04 is LTS. Derivative OS's like Peppermint will also suffer.

Quite a few of those still around... Because it's just a single binary, it's not too hard to provide for these use cases. I'm willing to share mine. :-D

I'm running into this too when attempting to run the v 0.2.2 cli on Ubuntu 18.04.5 LTS, but I wasn't able to find how to install the required system lib (of the correct version).
There seems to be a removed SO post about this installation issue: https://stackoverflow.com/questions/64490614/duckdb-usr-lib-x86-64-linux-gnu-libstdc-so-6-version-glibcxx-3-4-26-not
After downloading the file www.duckdb.org (cli, binary, linux, 0.2.2) I tried this:
roger@mba:~/bin$ duckdb
duckdb: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by duckdb)

It seems it is 3.4.25 is there and earlier versions, but not the required version of GLIBCXX_3.4.26:
roger@mba:~/bin$ strings /usr/lib/x86_64-linux-gnu/libstdc++.so.6 | grep GLIBCXX_3.4.2.
GLIBCXX_3.4.20
GLIBCXX_3.4.21
GLIBCXX_3.4.22
GLIBCXX_3.4.23
GLIBCXX_3.4.24
GLIBCXX_3.4.25

roger@mba:~/bin$ uname -a
Linux mba 4.15.0-122-generic #124-Ubuntu SMP Thu Oct 15 13:03:05 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

roger@mba:~/bin$ cat /etc/issue
Ubuntu 18.04.5 LTS \n \l

I then tried to see if I could run that file in a Debian container, and created a Dockerfile with this content:
FROM debian:stable-slim

ENV TINI_VERSION v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini
ENTRYPOINT ["/tini", "--"]

ADD https://github.com/cwida/duckdb/releases/download/v0.2.2/duckdb_cli-linux-am
d64.zip /duckdb
RUN apt update -y && apt install --no-install-recommends -y unzip && \
	unzip -o duckdb
RUN chmod +x /duckdb

CMD ["/duckdb"]

I saved this textfile with the name "Dockerfile" and was able to build it with docker build -t duckdb .
Running it, I got the same complaint:
roger@mba:~/bin$ docker run -it --rm duckdb
/duckdb: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /duckdb)

I also tried the binary on a few other computers, but none of them were enough up-to-date to run it.
Would it be possible to package this file as an selfcontained AppImage file to be provided from the download page in addition to what is there already?
It would become more portable across a wider set of linuxes and seems to be a good fit or packaging style for a binary of this nature? I guess it adds bytes but it would run out of the box in more places without requiring buildchains etc installed?
https://www.booleanworld.com/creating-linux-apps-run-anywhere-appimage/

I was going to share the version that works with Ubuntu 18.04 (GLIBCXX_3.4.25), but then I discovered that it didn't work on my old server (Ubuntu 16.04), so I build that too: duckdb for GLIBCXX_3.4.22 or higher

Thanks! With that binary, it runs on stable debian too, tested with this Dockerfile:
FROM debian:stable-slim

ENV TINI_VERSION v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini
ENTRYPOINT ["/tini", "--"]

#ADD https://github.com/cwida/duckdb/releases/download/v0.2.2/duckdb_cli-linux-amd64.zip /duckdb
#RUN apt update -y && apt install --no-install-recommends -y unzip && \
#	unzip -o duckdb

# use pepa65 build (... should run on Ubuntu 16, 18 too)
ADD https://4e4.win/duckdb_GLIBCXX_3.4.22 /usr/local/bin/duckdb
RUN chmod +x /usr/local/bin/duckdb

WORKDIR /data
VOLUME ["/data"]

CMD ["duckdb --help"]

# README

# to build this image, use "docker build -t cwida/duckdb ."

# to display cli options, use "docker run --rm -it cwida/duckdb" (displays help)

# to run w local db file 'myduckdb.ddb' in present working directory, use:
# docker run --rm -it -v "$(pwd)":"/data" cwida/duckdb duckdb myduckdb.ddb

# the duckdb command ".save myowninmemdb" complains about "sqlite3_backup_init: unsupported"
# so some other lib might be missing or functionality for saving might be WIP?

Not sure why there is sqlite3_backup_init: unsupported. I tried installing libsqlite3-dev and rebuilding, but this error is there. Maybe another Issue?

That error is not from SQLite itself, it's from our SQLite3 API wrapper. We wrap the internal SQLite API in order to use the shell. However, since the API has many operations (and many we are not interested in) we have not implemented all of them. When a function that is not implemented gets used we print a warning message and return an error condition. The backup API is one of those cases.
Can you describe the actions you took that leads to this warning being printed? Just starting up the shell on Ubuntu? Does the error prevent you from doing anything else afterwards?

It was after a .save and after the error printed the prompt came back.

Indeed .save is not supported yet, so this is expected behavior currently. Thanks for the report!

Can you try the latest build from https://github.com/cwida/duckdb/releases/download/master-builds/duckdb_cli-linux-amd64.zip

I tried it but still get the same error message.
First test was with Ubuntu 18.04.5 LTS, downloading to ~/bin and doing chmod +x then running it.
Second I tested to put it on Debian using a locally reproducible build based on this Dockerfile:
FROM debian:stable-slim

# tiny init process reaper to avoid zombie processes
# (not necessary in later versions of Docker, where it is built in)
ENV TINI_VERSION v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini
ENTRYPOINT ["/tini", "--"]

# install duckdb CLI binary
#ARG DUCK_VER=v0.2.2
#ENV DUCK_CLI https://github.com/cwida/duckdb/releases/download/${DUCK_VER}/duckdb_cli-linux-amd64.zip
ENV DUCK_CLI https://github.com/cwida/duckdb/releases/download/master-builds/duckdb_cli-linux-amd64.zip
WORKDIR /usr/local/bin
ADD ${DUCK_CLI} duckdb.zip
RUN apt-get update -y && apt-get install --no-install-recommends -y unzip && \
	unzip -o duckdb && \
	chmod +x duckdb

WORKDIR /data
VOLUME ["/data"]

CMD ["duckdb --help"]

I built that with the command docker build -t cwida/duckdb . and running it I got:
roger@mba:~/repos/duckdb$ docker run --rm -it cwida/duckdb duckdb --help
duckdb: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by duckdb)

duckdb: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found

That latest build still requires GLIBCXX_3.4.26.

It's weird... The build from master at https://github.com/cwida/duckdb/releases/download/master-builds/duckdb_cli-linux-amd64.zip seems to be looking for either GLIBCXX_3.4.26  on 18.04 (which has GLIBCXX_3.4.25), but the same binary on 14.04 (which has GLIBCXX_3.4.19) is looking for GLIBCXX_3.4.20/21/22/26 (and for CXXABI_1.3.8, while it only has CXXABI_1.3.7). None of them are working.

For curiosity's sake I tried building on Ubuntu 14.04 (still supported for over 3 years) and it works, also on all Ubuntu's after it (GLIBCXX_3.4.19 or highter and CXXABI_1.3.7 or higher): duckdb_cli

@pepa65 what is the setting you're making when building to get it to use a lower version of GLIBCXX?
I'm a bit curious to try this out: https://github.com/AppImageCrafters/build-appimage-action, although I don't have much experience from building AppImages. But then the build steps you're taking would be nice to have.

Just install/bootup a more ancient Linux, make sure cmake3 and python3 (and other build-essentials) are installed, and then just get the latest source from duckdb, and do make in the source's root directory. It's described in the README, it's very simple, and seems to work really well.

Thanks @pepa65 for the info. With this multistage Dockerfile the build of duckdb CLI tool worked out fine and gave a binary that I could run on Debian and Ubuntu 18. The build didn't require python3 to be installed:
FROM ubuntu:trusty

RUN apt-get update -y && apt-get install -y \
	unzip \
	ninja-build \
	build-essential \
	cmake3 \
	curl

WORKDIR /build

RUN curl -fL https://github.com/cwida/duckdb/archive/v0.2.2.tar.gz -o duckdb.tgz && \
	tar xfz duckdb.tgz --strip-components=1 && \
	rm duckdb.tgz

RUN cmake . -G Ninja
RUN ninja -j 3

FROM debian:stable-slim

WORKDIR /usr/local/bin
COPY --from=0 /build/duckdb .
RUN chmod +x duckdb

WORKDIR /data
VOLUME ["/data"]

CMD ["duckdb --help"]

I copied out the binary (using "docker cp") from the image and it ran locally on the host, just like the one you provided.
Perhaps into wouldn't run directly on a Raspberry Pi, but the "docker buildx" command with the above Dockerfile might be used to fix that:
# use docker and "buildx" cli plugin, to build for linux/arm64:
# see https://github.com/docker/buildx
docker run --privileged --rm tonistiigi/binfmt --install all
export DOCKER_CLI_EXPERIMENTAL=enabled
docker buildx build -t cwida/duckdb --platform=linux/arm64 .

I think the AppImage packaging wouldn't be completely pointless, if I understood it correctly, since it would bundle all the necessary stuff into a single executable file, therefore making it more portable, without requiring a particular system library of some version already being installed on the host (while baking that in makes it less tiny though).

It would be nice if there were static binaries available for each platform, so they would always run! (Which is what AppImage binaries are, but since the application itself is already a single binary, maybe some way of compiling all dependencies into a single static binary would be possible.)
If python3 really isn't required for building, it shouldn't be listed in README.md.

@pepa65  copy  new ibstdc++ library && add softlink  maybe help  https://github.com/rongfengliang/libstdc-so

Thanks for making those! Do they just work with the rest of my environment & applications from the repos? Of course it leads to a conflict with the repository managing software, to replace /usr/lib/x86_64-linux-gnu/libstdc++.so.6...

Thanks for making those! Do they just work with the rest of my environment & applications from the repos? Of course it leads to a conflict with the repository managing software, to replace /usr/lib/x86_64-linux-gnu/libstdc++.so.6...

yes this way maybe cause conflict,with static library maybe better

I tried out making a build of an AppImage packaging of the duckdb CLI, which seems to run on my Mint and Ubuntu boxes (which are not exactly bleeding edge). It is a cloud build using this workflow.
It provides a single file of 11MB which includes everything needed to run it. It is available here
@rongfengliang @pepa65 if you download this one, and try it out does it run for you too?
wget "https://github.com/mskyttner/duckdb-cli-builds/releases/download/refs%2Fheads%2Fmain/duckdb-x86_64.AppImage"
chmod +x duckdb-x86_64.AppImage
./duckdb-x86_64.AppImage

#file duckdb-x86_64.AppImage
#duckdb-x86_64.AppImage: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.18, stripped

That seems to work well, and for all it includes is one third of the size of just the built binary..!

Could you try the latest binary from https://github.com/cwida/duckdb/releases/download/master-builds/duckdb_cli-linux-amd64.zip ?

Yes, this works on 18.04 and 16.04 (haven't tried 14.04 yet).

Excellent. I propose to close this issue then.

The java package has exactly the same problem on ubuntu 18.04

The java package has exactly the same problem on ubuntu 18.04

The java package has exactly the same problem on ubuntu 18.04

Could you be more specific please? Which OS/Java versions etc?

The java package has exactly the same problem on ubuntu 18.04

Could you be more specific please? Which OS/Java versions etc?


Improve the storage-service documentation

Start from the rendered README, and work outwards: https://github.com/wellcomecollection/storage-service/blob/diataxis/README.md
I still need to finish tidying up content from the original README and get some more of the conceptual/developer-internals stuff out, but I think it's heading in the right direction.

Likely to be of particular interest:

How the demo works: https://github.com/wellcomecollection/storage-service/tree/diataxis/demo/terraform
Limitations of the demo setup: https://github.com/wellcomecollection/storage-service/blob/diataxis/demo/terraform/readme/limitations.md

This is fantastic! Only comment is I would expect a "getting started" section rather than a "demo".


Fixing Null Reference Exception in SystemKeyboardExample

Overview
When running the HandInteractionExamples the Unity log is spammed with null reference exceptions from the SystemKeyboardExample due to the debug text not being set up in the inspector. This pull request address this by assigning the reference and performing runtime checks.
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5501

Verification

Run the HandInteractionExamples on a HoloLens 2.
Download the UnityPlayer.log
Verify no exceptions from Microsoft.MixedReality.Toolkit.Examples.Demos.SystemKeyboardExample.Update

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

@Cameron-Micka @davidkline-ms I think this should be included in the GA branch. However, this PR was based on dev branch. After David's target branch change, I see many unrelated commits from dev branch. We might need a new PR for GA branch.

yes. we should take a separate PR for stabilization, unless we believe the other fixes contained here (from the dev branch) meet the release bar.

I can make another PR targeting stabilization if that is desirable?

/azp run


Server-side models constructors have too many arguments

Eg.
class Game {

    constructor(id, player1, player2, player1Board, player2Board, status, playerTurn, player1Scores, player2Scores, boardState) {
        this._id = id;
        this.player1 = player1;
        this.player2 = player2;
        this.player1Board = player1Board;
        this.player2Board = player2Board;
        this.status = status;
        this.playerTurn = playerTurn;
        this.player1Scores = player1Scores;
        this.player2Scores = player2Scores;
        this.boardState = boardState;
    }

    // ...
}

var game = new Game(
  null,
  currentUser,
  userId,
  undefined, undefined,
  "waiting",
  _.random(1,2),
  {}, {},
  boardState
);

We should pass them an object instead.
class Game {

    constructor(props) {
      // TODO: Add validation of props object (could try using check, or React.PropTypes)
      _.extend(this, props);
    }

    // ...
}

var game = new Game({
  _id: null,
  player1: currentUser,
  player2: userId,
  player1Board: undefined, // could also be omitted
  player2Board: undefined, // could also be omitted
  status: "waiting",
  playerTurn: _.random(1,2),
  player1Scores: {},
  player2Scores: {},
  boardState: boardState
});

Other variations:
const properties = [ '_id', 'player1', 'player2', etc. ];

class Game {

    constructor(props) {
      for (p of properties) {
        this[p] = props[p];
      }
    }

    // ...
}

class Game {

    constructor(props) {
      this._id = props._id;
      this.player1 = props.player1;
      this.player2 = props.player2;
    }

    // ...
}


Docker Image for arm64

would it be possible to have a docker image that can run on arm64 processors?
thanks

it is?

Ok. But the ARM image currently is not working @strausmann
Fails with error
time="2023-12-23T21:57:12Z" level=debug msg="Using /data to match uid and gid"
time="2023-12-23T21:57:12Z" level=debug msg="Resolved UID=0 from match path"
time="2023-12-23T21:57:12Z" level=debug msg="Resolved GID=0 from match path"
time="2023-12-23T21:57:12Z" level=fatal msg="Failed to run sub-command" error="fork/exec /opt/bedrock-entry.sh: exec format error"

After some debugging i found that the image digest used (https://hub.docker.com/layers/library/openjdk/22-ea-jdk-slim-bookworm/images/sha256-37867f656e947c1d2fa1e17aab69181c2911c6ad10f4bdfd0a6862a4ed8c7685?context=explore) is bound to their amd64 layer thus breaking the executability on arm.
I worked around that by changing the digest in a local docker file for now but it would be great if you could handle the digests for the multi arch build in your build pipeline?
If needed i could prepare something here but earliest in jan :)

@masonen thanks for the hint. I really slept there
https://git.strausmann.de/minecraft/bedrock-connect/-/issues/24

Pulled and run tag 24-arm-image-is-broken, works like charm.

new stable release is now published.


Need to click modal confirmations twice

The Issue
Noticed I need to click modal confirmations twice when they pop up. First noticed when purchasing content and also on an upgrade notice.
This is on master as of 5/24
Steps to Reproduce

Purchase some content (see lbry://@juggling)
Notice you need to click the modal confirmation twice before it disappears

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Working on this

This is fixed on the file page.


Example page doesn't work at all in IE

Your example page on https://jaredreich.com/pell
doesn't work with IE at all.
This is displayed like that:

Below is the list of errors I got on IE:
DOM7011: The code on this page disabled back and forward caching. For more information, see: http://go.microsoft.com/fwlink/?LinkID=291337
File: pell
HTML1300: Navigation occurred.
File: pell
DOM7011: The code on this page disabled back and forward caching. For more information, see: http://go.microsoft.com/fwlink/?LinkID=291337
File: pell
HTML1300: Navigation occurred.
File: pell
CSS3111: @font-face encountered unknown error.
File: roboto-mono-bold.eot
CSS3111: @font-face encountered unknown error.
File: roboto-mono.eot
[nuxt.js] Cannot load components ReferenceError: 'Promise' is undefined
   "[nuxt.js] Cannot load components"
   {
      [functions]: ,
      __proto__: { },
      description: "'Promise' is undefined",
      message: "'Promise' is undefined",
      name: "ReferenceError",
      number: -2146823279,
      stack: "ReferenceError: 'Promise' is undefined
   at n.e (https://jaredreich.com/_nuxt/manifest.cab04e65e6b674718f8b.js:1:628)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:115639)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113717)
   at C (https://jaredreich.com/_nuxt/vendor.bundle.73c3499fe0c6a2d25537.js:16:43485)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113525)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102893)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102852)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102785)
   at q (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113478)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113879)"
   }

DOM7011: The code on this page disabled back and forward caching. For more information, see: http://go.microsoft.com/fwlink/?LinkID=291337
File: pell
HTML1300: Navigation occurred.
File: pell
CSS3111: @font-face encountered unknown error.
File: roboto-mono-bold.eot
CSS3111: @font-face encountered unknown error.
File: roboto-mono.eot
[nuxt.js] Cannot load components ReferenceError: 'Promise' is undefined
   "[nuxt.js] Cannot load components"
   {
      [functions]: ,
      __proto__: { },
      description: "'Promise' is undefined",
      message: "'Promise' is undefined",
      name: "ReferenceError",
      number: -2146823279,
      stack: "ReferenceError: 'Promise' is undefined
   at n.e (https://jaredreich.com/_nuxt/manifest.cab04e65e6b674718f8b.js:1:628)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:115639)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113717)
   at C (https://jaredreich.com/_nuxt/vendor.bundle.73c3499fe0c6a2d25537.js:16:43485)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113525)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102893)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102852)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102785)
   at q (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113478)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113879)"
   }
DOM7011: The code on this page disabled back and forward caching. For more information, see: http://go.microsoft.com/fwlink/?LinkID=291337
File: pell
HTML1300: Navigation occurred.
File: pell
CSS3111: @font-face encountered unknown error.
File: roboto-mono-bold.eot
CSS3111: @font-face encountered unknown error.
File: roboto-mono.eot
[nuxt.js] Cannot load components ReferenceError: 'Promise' is undefined
   "[nuxt.js] Cannot load components"
   {
      [functions]: ,
      __proto__: { },
      description: "'Promise' is undefined",
      message: "'Promise' is undefined",
      name: "ReferenceError",
      number: -2146823279,
      stack: "ReferenceError: 'Promise' is undefined
   at n.e (https://jaredreich.com/_nuxt/manifest.cab04e65e6b674718f8b.js:1:628)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:115639)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113717)
   at C (https://jaredreich.com/_nuxt/vendor.bundle.73c3499fe0c6a2d25537.js:16:43485)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113525)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102893)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102852)
   at A (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:102785)
   at q (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113478)
   at Anonymous function (https://jaredreich.com/_nuxt/nuxt.bundle.92ffc057163fb8a40757.js:1:113879)"
   }

Probably nuxt doesn't add Promise globally? Try the polyfills


Preset: Idiomatic

#1065. WIP

Idiomatic
JSCS

indentation
no preference but be consistent!

quotes?
use jquery preset: "validateQuoteMarks": { "mark": "\"", "escape": true },

foo("bar")
new rule option: requireSpacesInsideParentheses: Single argument string literal, no space

if ( !("foo" in obj) ) {
new rule option: requireSpacesInsideParentheses: Inner grouping parens, no space

foo([ "alpha", "beta" ]);
"requireSpacesInsideParentheses": { "except": [ "[", "]" ] }

(function( global ) {})()
"requireSpacesInsideParentheses": { "except": ["function"] }

foo({ a: "alpha" });
"requireSpacesInsideParentheses": { "except": [ "{", "}" ] }

square( 10 );
"disallowSpacesInCallExpression": true

// statements
"requireSpaceAfterLineComment": { "allExcept": ["#", "="] }

"disallowMultipleLineBreaks": null

var, const, let statements should always be in the beginning of their respective scope
#99 new rule requireVarDeclFirst

name of regex: rDesc
new rule?

End of line comments are prohibited!
new rule validateCommentPosition

var factorial = function factorial( number ) {
similar to #850

avoid switch if possible
disallowNodeTypes: ["SwitchStatement"]

early returns
new rule https://github.com/jscs-dev/node-jscs/issues/1223 requireEarlyReturn

Coverage increased (+0.0%) to 98.82% when pulling b3544b2d33b597fae5ad8e97e7e78b36e1400a7a on hzoo:add-idiomatic-preset into d567f914d2461635976d463abe22a13aa0becf5b on jscs-dev:master.

@markelog

@rwaldron you might like this :-)

Coverage increased (+0.0%) to 98.88% when pulling b018deeed18d91aab000b697b4b5658a331aacca on hzoo:add-idiomatic-preset into 9a999508b084106f4cdaaa6e73c16f71a15c0305 on jscs-dev:master.

Coverage increased (+0.0%) to 98.88% when pulling b018deeed18d91aab000b697b4b5658a331aacca on hzoo:add-idiomatic-preset into 9a999508b084106f4cdaaa6e73c16f71a15c0305 on jscs-dev:master.

Oh failing because of requirePaddingNewLinesBeforeLineComments in jQuery

We can't land this, until https://github.com/jscs-dev/node-jscs/pull/1069#discussion_r24805322 is all done, specifically until
foo("bar")

case is handled, would like to take a hit on this one? https://github.com/jscs-dev/node-jscs/issues/836

Yeah I was just updating the PRs since I forgot to update 2 files

Yeah I'l take a look

What's the status on this PR? Still held up?

Yeah on #836. Need an exception for foo("bar") - requireSpacesInsideParentheses but except string literals so I guess for
", ', `

I guess I can finish this now lol

@hzoo Can we not just land this with that case in an open issue? Would it be reporting the wrong case or nothing at all? Can we just nullify that case?
Would love to land this finally.

Yeah we could land it now if we want (and make an issue for the other rules that need to be created) @markelog

Please pull?

@ehartford

still need foo("bar") case

can not make a separate issue for that case?

https://github.com/jscs-dev/node-jscs/issues/836

@markelog Do we want to release the new preset now and update it later when #836 is done?

Well, we certainly can, but that feature is kind important

Can we include requireVarDeclFirst?

Ok I can add requireVarDeclFirst.
JSDoc style is good, but requires a significant time investment - don't think we need to make a rule to prevent jsdoc style unless the rule would be disallowBlockComments.
End of line comments are prohibited!
That would be https://github.com/jscs-dev/node-jscs/issues/651 - validateCommentPosition: "above" (disallow beside)

Getting an error with requireVarDeclFirst on
// Good
function foo() {
  let foo;
  if ( condition ) {
    let bar = "";

  }
}

JSDoc style is good, but requires a significant time investment - don't think we need to make a rule to prevent jsdoc style unless the rule would be disallowBlockComments.

I was thinking we should include jsdoc rules

Getting an error with requireVarDeclFirst on

https://github.com/jscs-dev/node-jscs/issues/1783

Ok updating with
   "requireSpacesInsideParentheses": {
        "all": true,
        "ignoreParenthesizedExpression": true,
        "except": [ "\"" ]
    },

How about disallowSpacesInsideParenthesizedExpression: true and validateCommentPosition:?

Getting
Illegal space after opening grouping parenthesis at 1.js :
   208 |
   209 |  Ctor.prototype.setFoo = function( val ) {
   210 |    return ( this.foo = val );
--------------------^
   211 |  };
   212 |

Illegal space before closing grouping parenthesis at 1.js :
   208 |
   209 |  Ctor.prototype.setFoo = function( val ) {
   210 |    return ( this.foo = val );
-----------------------------------^
   211 |  };
   212 |

for disallowSpacesInsideParenthesizedExpression - adding validatecomment

:-(

It seems we all good here?

Yeah only requireVarDeclFirst is left? (and we have an issue for that already)

It was kind of annoying to depend on a preset (jquery) though - since if you update the jquery preset, then the tests will fail (validateIdentation errors in that case) so I just removed that?

since if you update the jquery preset, then the tests will fail (validateIdentation errors in that case) so I just removed that?

Do what you think is right :-).

How we doing here?

Can merge - there's only some rules we haven't implemented yet.

I guess we did catch the spirit of this preset, we can take care the details afterwards

So :+1: for this?

LGTM

Ok finally merged! :tada:


yum install is not working

Using a mac and virtualbox when I use "sudo dnf -y install python 3" the machine disconnects. I think is something in my environment.

Oh, sorry, headline changed


Various fixes

https://github.com/boostorg/compute/commit/2a6995581432ab602459aff81a1ecee6e175b732 is the most interesting bug-fix. clEnqueueWriteBuffer is not "100% blocking". OpenCL specification only promises that for clEnqueueWriteBuffer:

if blocking_write is CL_TRUE, the OpenCL implementation copies the data referred to by ptr and enqueues the write operation in the command-queue. The memory pointed to by ptr can be reused by the application after the clEnqueueWriteBuffer call returns.

Which means that blocking clEnqueueWriteBuffer can return after it copies memory pointer by ptr to some temporary memory (on host), and it doesn't have to wait for the write to the buffer to be completed. (To be honest OpenCL specification is not 100% clear about that.) Anyway, in case of the Intel implementation for CPU, clEnqueueWriteBuffer does not wait for the data to be written into the buffer. Every other platform waits (AMD, NVIDIA, pocl), but the fact is that Intel implementation is in line with the specification. (See also https://software.intel.com/en-us/forums/opencl/topic/731519.)
That caused random errors when writing and reading using [] operator, because each call of [] operator creates it's own temporary command queue (so calls were not ordered). Long story short: It was possible to do vector[0] = 3; and right after that vector[0] == 3 could be false.

Coverage decreased (-0.004%) to 83.695% when pulling beb2476cb0e70207c5c6b98f9f38d92742a2e600 on haahh:pr_fixes into debbf80b4d98b3cabcee672a96e7ed43878b23dc on boostorg:develop.

Coverage decreased (-0.02%) to 83.676% when pulling 0f5c49d5f5f12d9a8b32e2193465f2279fb21b16 on haahh:pr_fixes into debbf80b4d98b3cabcee672a96e7ed43878b23dc on boostorg:develop.


nixos/incus: fix OVMF path for existing VMs

Description of changes
Apparently existing incus VMs actually care about this OVMF version. New ones should be created using the 4MB version, but existing ones will try and use the version that was in place when they were created.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build incus.passthru.tests


Add support for ghcr.io/pyo3/maturin docker image

Looks like pyo3-build-config gets confused when host == target and PYO3_CROSS_LIB_DIR env var is set.

thread 'main' panicked at 'failed to parse PyO3 config file: Error { value: "failed to open PyO3 config file at /home/runner/work/maturin-action/maturin-action/maturin/test-crates/pyo3-mixed/target/debug/build/pyo3-build-config-05951985431e5399/out/pyo3-cross-compile-config.txt", source: Some(Os { code: 2, kind: NotFound, message: "No such file or directory" }) }', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-build-config-0.16.1/src/lib.rs:78:10

cc @davidhewitt


updating 2d canvas rendering

This PR is to make the 2d canvas graphs look more like the WebGL versions. The difference is most notable when zoomed out a lot.
Changes in this diff:

I added alwaysUse2dCanvas option to make it easier to test the 2d canvas mode on computers with WebGL support
Alpha was being passed to the canvas in a 0-255 range, but the rgba in fillStyle and strokeStyle expects alpha in the 0-1 range. So now the alpha is being converted to the 0-1 range
The radius of nodes in WebGL has 2 extra pixels added to it. There is a + 1 when passing the radius to the buffer, and then I think another pixel comes from the (distance >= 0 && distance <= 1) from node.frag shader.
I make the 2d links 50% thinner. I'm not sure why they look thicker on canvas, this just seemed to be a good constant for me
I added a darker border around the nodes so they look like the WebGL version. Couldn't figure out how to make it exactly match the WebGL, this just looks pretty close to me

How to test this:
Chrome -> Settings -> Advanced -> Disable hardware acceleration, or pass alwaysUse2dCanvas: true to the grapher constructor

If I recall correctly, the Ayasdi custom shader adds the border around the nodes in the WebGL version. By default, there is no border around nodes in WebGL (check the examples). It may not make sense to have borders in the canvas version, but you may wish to add some way to customize how the canvas version is rendered.

I also noticed that the links now appear thinner on canvas. I would suggest trying your changes on the examples rather than on Ayasdi Workbench which contains some custom shaders.

Oh, the custom shaders! I was going crazy trying to figure out where that was coming from. Ok I'll make those changes

Ok, here's what I put in the latest PR:

Added two options with horrible names custom2dNodeRenderFunction and custom2dLinkRenderFunction for customizing canvas rendering. I will come up with better names and update the PR
Added an example that demonstrates the custom functionality. It renders triangles instead of circles and weird curved lines instead of straight lines
I left in canvas alpha fix, because that seems to be a real bug
I left in the change I made that makes the links skinnier in canvas. Without it, I'm noticing a big difference in link thickness between webGl and 2d canvas, even in the examples

I think this is pretty good. Last thing I'll suggest is to let the user pass in the renderer rather than use an alwaysUse2dCanvas boolean:
new Grapher({ renderer: Grapher.CanvasRenderer });

This should give even more flexibility around custom rendering and the future API additions and avoid a very specific and rigid property, but we could also restrict it for now.

I wish I had setup some Jenkins job that will do the versioning and publishing. ;)
@pdubey84, you'll want to run npm publish so it registers in the npm repository:
https://www.npmjs.com/package/ayasdi-grapher
I can probably do it, too... if you really don't want to.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Chapter 10 for Godot 4.2

Page 181: You can see the light effect on the candle much better by toggling the Preview Sunlight and Preview Environment options off in the toolbar. They are just to the left of the Transform and View menus in the toolbar.
Page 182:

Under the Overcoming the jagged edges section: Go to Project Settings -> General -> Rendering -> Anti Aliasing. Change MSAA 3D to 2x (Average).
In Step 3 almost every line of code has changed:

@tool
extends Node3D

@export var is_lit : bool = false : set = set_lit

func set_lit(condition):
	is_lit = condition

func _process(_delta):
	$OmniLight3D.visible = is_lit

NOTE: You must close the candles_1 scene and reopen it after adding the script for the @tool part to work in the editor. There is no danger to leaving the @tool decorator at the top of the script. It will also still work in the game. See here for more info: https://docs.godotengine.org/en/stable/tutorials/plugins/running_code_in_the_editor.html
NOTE 2: The change of the method name switch to set_lit isn't functional, it is just following the coding standard that setters and getters should always start with "set" and "get".
Page 195: Levels appears to be Intensity and Strength now.
Page 197:

The GIProbe node has been renamed to VoxelGI.
In Step 3 Extents is renamed Size. x needed to be 20, instead of 12, to cover the map.
Before Step 4, you have to click  in the Data property and select NewVoxelGIData. Then click on the VoxelGIData you created to see the Interior option.

Page 198: In Step 3 there is no Enable option. It appears to be already enabled because it is set to Static. Change it to Dynamic. (Also note that you can Control + Click all the .glb files and Reimport them all at once.)
Page 199: In the last line on the page (Step 2), the button is called Bake VoxelGI instead of Bake GI Probe.

@mrunion Chapter 10 Done


updated readme

Solves : #274

Hey, that's really bad practice, @swastik959 . I raised an issue with a clear mention of validating the issue and working on it.

Thank you for the pull request addressing this matter.
As mentioned in our comment on the related issue #274 , we're currently in the process of creating a more comprehensive and informative Readme.md file. Additionally, we're working on splitting the documentation into two distinct sections: one for the open-source aspect of Configu and another for the cloud platform. This separation should provide clearer and more relevant information for both users of the open-source tool and the cloud platform.
It's important for us to keep the Configu open-source documentation clean from commercial offerings. Configu is fully functional as an open-source tool without the need for additional tools, so the cloud platform information isn't relevant in the open-source Readme.md.
Regarding the IDE plugins, we'll be sure to add them to the Readme.md once they become available.
For more details, please refer to our comment on the issue. We appreciate your understanding and patience as we work to improve our documentation.


Implement ERC734

It would be great to have an implementation of ERC734 in this repo (just like we have an ERC725 implementation here). The current draft of the ERC734 spec is here. Please comment if you're interested in working on this and have any questions.

I would like to work on this

I would like to join it too! Should we talk a bit before starting? @filiplazovic  and @tyleryasaka ?

Awesome! @CPerezz it might be hard to find a time that works for all of us to discuss over a call, but we can definitely discuss in this thread.
So to make sure we're on the same page, the main idea is that the key manager (734) should be associated with an ERC725 identity contract, and will pass along the execute parameters to this contract. I did something very similar here.
Other than that, the rest should look pretty much like the former ERC725 specs. Here are two implementations of this:

https://github.com/mirceapasoi/erc725-735
https://github.com/OriginProtocol/origin-playground

The ERC734 doc provides the exact specs, although it is of course a work in progress. It hasn't been proofread either, so there may be mistakes and typos. Please feel free to point out any errors or areas of confusion in that doc and I will try to fix them.
Whoever begins working on this: my suggestion would be to implement only a small part of the spec (maybe 2 or 3 functions) and then submit that for review so that we can all discuss and make sure we're on the same page.

For now i have few things:

Can a key have multiple purposes? In specs struct Key has uint256[], but function addKey accepts uint256

Why are we passing purpose to removeKey?

@filiplazovic Good question. Yes, I think keys can have multiple purposes. To assign multiple purposes to a key, you would have to call addKey multiple times, once for each purpose. (So if you want to add a purpose to an existing key, you would call addKey with the existing key and the new purpose.)
Likewise, removeKey does not necessarily remove the entire key. It just removes the specified key/purpose combination. So if you have a key with 3 purposes, you would have to call removeKey 3 times to completely remove it.
Does that make sense? I'm not sure if this is the best way to do it, but that is how I interpret the current standard.

After looking at this in detail, i thinks having a purpose as an array creates some problems here. I understand that it allows us to return all purposes easily in getKey, but items of the array can be added and deleted multiple times, and maintaining length and order of items can be tricky and expensive in solidity.
If we turn purposes to mapping, it would make it a lot of easier to add and remove them. This would require new functions addKeyPurpose and removeKeyPurpose which would separate logic for creating a key and adding/removing purposes for that keys. A drawback here is that we can't return all purposes in getKey (we can't return the whole mapping), instead the client needs to call keyHasPurpose for every purpose separately.
Also, i think, the filtering that getKeysByPurpose would provide, should be done on the client-side as it would probably require another mapping to pack the data in this particular way.
@tyleryasaka Let me know what you think

@filiplazovic I tend to agree with you. I previously suggested to @frozeman that we drop the getKeysByPurpose method. I will try to get his feedback here.
In the meantime, feel free to go ahead and implement the contracts the way you described. I think once you have working code it will be easier to update the standards as necessary.

Alternatively, we can keep the array, but add function setKeyPurposes which will accept array to set all purposes at once. So instead of adding purposes one by one, we can set the whole array with one transaction. The downside would be that if we want to remove just one purpose out of 5, we have to pass new array of 4 to replace it.
With this approachkeyHasPurpose could not work without a loop.
Then if we want to check if key has specific purpose inside some function, we need to pass index of the purpose we are checking, e.g. for approve function:
function approve(uint256 _id, bool _approve, uint256 _purposeIndex) {
   require(
       keys[keccak256(msg.sender)].purposes[_purposeIndex] == 2,
       "Sender does not have action key"
    );
}

So to sum up the characteristics for both solutions:
First solution:

use mapping for purposes
read purposes by calling keyHasPurpose for every purpose
easy checking if some key has particular purpose
Adding and removing purposes one by one (or multiple additions and multiple removals, but adding and removing needs to be separate)

Second solution:

use array
read all purposes by calling getKey
caller needs to pass additional parametar so we can check if key has particular purpose (to avoid
looping)
all purposes can be changed in one transaction

@filiplazovic I personally prefer the first solution (using a mapping). It's simpler.

Hello! I have been reading along the thread and I think the same. It is simpler and easier to handle a mapping than an array. Also I am agree with having multiple purposes in keys and having only the keyHasPurpose method. getKeysByPurpose seems to be a feature that comes to fulfill the same purpose that keyHasPurpose :). One of the two methods can satisfy almost the same, at least in my opinion.

@filiplazovic Perfect! I've been following the thread and meanwhile implementing the payments through the  Proxy with @jordipainan . You've done a great work mate!

Thanks @tyleryasaka got the implementation.
TODO:

[ ] The implementation should be more extensible tested.
[ ] The implementation can make use of solidity 0.6.1 feature and return arrays instead of bit masks
[ ] The implementation is missing functions that need implementation

ERC734 is now deprecated, you can use LSP6-KeyManager for a Key Manager system to control ERC725 contracts.


Update result-cluster.md

Result cluster is now by default switched on for WW tenants. Hence removing preview tag and updating the default settings section.

Closing this PR as changes have been made under a different PR and repo. Changes will go live on 8/10.


Move customization code and csproj outside of generated folder

I'm able to generate code using autorest --use<EMAIL_ADDRESS>--input-file:Inputfile --public-clients:true command but when I set to --clear-output-folder:true, it removes all the customizations because currently we put all the customizations inside the generated folder.
Moving customization code and csproj outside of generated folder to fix this issue.

 await autoRest.Warning("output-folder path is required for customization");
Let's change this to say something about being an absolute path instead.
            var projectDirectory = Path.Combine(configuration.OutputFolder, "../");

Let's add a configuration property ProjectRelativeDirectory and always set it to ... Use the value in
CSharpGen and CSharpProj

        public static string GeneratedFolder = "generated";

This might cause issues with azure-sdk-for-net where everything is already generated to the uppercase directory.
          var generatedCodeDirectory = Path.Combine(projectDirectory, "generated");

            foreach (string sourceFile in Directory.GetFiles(projectDirectory, "*.cs", SearchOption.AllDirectories))
            {
                // Ignore existing generated code
                if (sourceFile.StartsWith(generatedCodeDirectory))
                {

this condition would fail in azure-sdk-for-net on Linux leading to broken customizations.

 await autoRest.Warning("output-folder path is required for customization");
Let's change this to say something about being an absolute path instead.
            var projectDirectory = Path.Combine(configuration.OutputFolder, "../");

Let's add a configuration property ProjectRelativeDirectory and always set it to ... Use the value in
CSharpGen and CSharpProj

        public static string GeneratedFolder = "generated";

This might cause issues with azure-sdk-for-net where everything is already generated to the uppercase directory.
          var generatedCodeDirectory = Path.Combine(projectDirectory, "generated");

            foreach (string sourceFile in Directory.GetFiles(projectDirectory, "*.cs", SearchOption.AllDirectories))
            {
                // Ignore existing generated code
                if (sourceFile.StartsWith(generatedCodeDirectory))
                {

this condition would fail in azure-sdk-for-net on Linux leading to broken customizations.

    <Exec Command="npx autorest@$(AutoRestVersion) --skip-upgrade-check --version=$(AutoRestCoreVersion) $(AutoRestInput) $(AutoRestAdditionalParameters) --use=$(MSBuildThisFileDirectory)../tools/netcoreapp3.0/any/ --output-folder=$(MSBuildProjectDirectory)/generated --clear-output-folder:true --namespace=$(RootNamespace) --shared-source-folders="$(AzureCoreSharedCodeDirectory);$(AutoRestSharedCodeDirectory)"" />

We might want to keep the uppercase generated directory so it's consistent in the repo.
Wonder if we can change the default Generated value to be upper case.
--clear-output-folder:true should we use --clear-output-folder=true instead?

    <Exec Command="npx autorest@$(AutoRestVersion) --skip-upgrade-check --version=$(AutoRestCoreVersion) $(AutoRestInput) $(AutoRestAdditionalParameters) --use=$(MSBuildThisFileDirectory)../tools/netcoreapp3.0/any/ --output-folder=$(MSBuildProjectDirectory)/generated --clear-output-folder:true --namespace=$(RootNamespace) --shared-source-folders="$(AzureCoreSharedCodeDirectory);$(AutoRestSharedCodeDirectory)"" />

We might want to keep the uppercase generated directory so it's consistent in the repo.
Wonder if we can change the default Generated value to be upper case.
--clear-output-folder:true should we use --clear-output-folder=true instead?


Update project urls with added links

The PyPI warehouse supports a number of custom links to display on the project page. Of interest to Bandit are the links to the docs, sponsors, and discord.
https://github.com/pypi/warehouse/blob/main/warehouse/templates/packaging/detail.html

This is a minimal enough change that I'll go ahead and self-merge.


glint doesn't parse args with dashes correctly

Summary
If you have a component arg that has a dash in the name, glint does not handle it correctly.
Error
// template file

You passed in {{@example-arg}}

$ yarn glint

app/components/example-component.hbs:2:20 - error TS2304: Cannot find name 'arg'.

2   You passed in {{@example-arg}}
                     ~~~~~~~~~~~

app/components/example-component.hbs:2:20 - error TS2339: Property 'example' does not exist on type '{ 'example-arg': string; }'.

2   You passed in {{@example-arg}}
                     ~~~~~~~~~~~

This demo repro shows the issue, and contains one commit where a camel case arg works ExampleArg but a dasherized one does not

I would've sworn we handled non-Identifier-args correctly, but clearly we don't! 😄
Thank you for the thorough report and reproduction, @nlfurniss—hopefully we should be able to get this taken care of during the flurry of activity over the next day or so.