ADR 008: Lowering the barrier to entry for experimental components

See rendered markdown

Thanks for getting this written up, @siddharthkp!
In order to help move a decision forward, I'm assigning the following:
ADR decision maker: @mperrotti
Decision deadline: EOD Monday, 15 August. This deadline is a bit quicker than usual so we can unblock active contributions from the Memex team. Mike, if this is too quick a timeline for you, please let me know 🙏🏻
Your role as decision maker is to gather feedback, probe for discussion and disagreement, and then make an informed decision based on the feedback, identified risks, and trade-offs about whether to adopt the ADR or not. Your role is not to decide based on your own personally preferred approach.
Keep in mind that ADR decisions can be reversed or changed in the future if new information is exposed that make the ADR worth revisiting.
You can fulfill your decision maker role by doing the following:

review the ADR, comments, and feedback closely
seek additional feedback from any necessary parties, as needed; for example, request a review from any individuals or teams that you know would be unduly affected by this ADR, or who have extensive experience in using either the preferred or non-preferred approach and may have perspective to share about it
follow up on any remaining concerns, questions, or unexamined risks around accepting the proposed approach
on or before the deadline, make a decision as to whether the ADR is accepted ✅ , which you should signal by approving this PR, or rejected 🚫 , which you should signal by closing this PR with a comment explaining the reason(s)

@pksjce Thank you for the articulation! This is really helpful, I'm going to start quoting that 😄

@siddharthkp is going to make some updates and get feedback from other teams with similar challenges.
Monday Aug 15 is going to be too soon to freeze this decision cc @lesliecdubs

Update!
I have updated the location where the source code of experimental components would live from github.com/primer/react-candidates to https://github.com/github/github/tree/master/app/assets/modules/react-shared
### Decision
- 3. code repository: To support different conventions and processes for experimental components and convey shared ownership between primer and product teams, we should keep them in a new repository `github.com/primer/react-candidates`
+ 3. The code for experimental components should live in [github/github/modules/react-shared](https://github.com/github/github/tree/master/app/assets/modules/react-shared) and published as individual packages as suggested in point 2.
+
+  The monolith already has a place where reusable react components live. This has the lowest barrier to entry for folks working in the monolith.
+
+  Acknowledged risk: It would introduce some additional work for non-monolith projects when upstreaming reusable components. We should work on improving the development and publishing workflow for react-shared.

Some notes from my conversation with @dgrief about publishing the react-shared directory as a package the memex can consumer:

Overall, Dusty thinks publishing react-shared seems like reasonable solution to our current problems and prefers that approach to the alternatives (i.e., creating a new repo)
We could/should publish the package to the GitHub Package registry (instead of npm). It would be easier to keep the package private and we already have the infrastructure set up for it in dotcom (i think)
Ownership in dotcom is already handled via CODEOWNERS so we wouldn’t have to set that up ourselves
Memex bundles all their dependencies so we run the risk of bundling react-shared components twice in both memex and dotcom. However, this is an existing issue. react, react-dom, and @primer/react are already being duplicated between memex and dotcom so this doesn’t seem like a blocker

— Slack thread

Thanks for the great discussion around this proposal!
@mperrotti I'll push out the decision deadline to Wednesday 24 August, although please feel free to complete the decision-maker duties prior to that date if you're able. Please ping me again if more time is needed.

@howdyray Not yet. The follow up work after this ADR gets approved would be on docs and discoverability of these components, which should help us spot emerging patterns and new system components


[ENH] - Evaluate classification

Reference Issues/PRs

Fix #3172
What does this implement/fix? Explain your changes.

Implement an evaluate for classification. This methods allows quick calculation of classification task metrics. Furthermore, it allows us to write kotsu-type benchmarking tool for classification task.
Does your contribution introduce a new dependency? If yes, which one?

None
What should a reviewer concentrate their feedback on?

Design and implementation

Any other comments?

Unit test is being worked on
Examples in docstring is also being worked on

PR checklist

For all contributions

[x] I've added myself to the list of contributors.
[x] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@fkiraly I think I accidentally force merge this. Can you help me un-merge?


Capture the most-replayed time stamp

Is it possible to get the data for that histogram-like graph that appears on the screen when you hover over the progress bar and shows the most re-played parts of a video? Desired output will be something like this:
Timestamp interval     relative graph height
0:00:00-0:00:10            40%
0:00:10-0:00:20            30%
etc.                       etc.

Having this kind of data allows us to calculate a video's ability to keep reviewers watching (bounce rate).
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

5caf30dbc34f10b0be60676fece635b5c59f0d72 added the heatmap field for Youtube
If using CLI, add --print "%(heatmap)j" to your command for JSON output


Always enable ETW for request tracer

Fix for https://github.com/projectkudu/kudu/issues/2442.   For requests from browser, we currently disable file tracer.   This change is to always write to ETW.

merged


parse evm values with abi

for:
https://forum.dfinity.org/t/assigned-chainsight-bnt-1-asset-rating-oracle/23038/22
I will add unit tests after replying to the post.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

42 of 236 (17.8%)  changed or added relevant lines in 1 file are covered.
67 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-2.7%) to 50.648%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

chainsight-cdk-macros/src/canisters/snapshot_indexer_evm.rs
42
236
17.8%

Files with Coverage Reduction
New Missed Lines
%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/quote-1.0.33/src/runtime.rs
3
80.0%

chainsight-cdk-macros/src/canisters/snapshot_indexer_evm.rs
3
27.34%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/quote-1.0.33/src/to_tokens.rs
5
37.5%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-automata-0.4.3/src/meta/regex.rs
12
67.07%

chainsight-cdk/src/convert/evm.rs
20
13.73%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-1.10.2/src/regex/string.rs
24
71.59%

Totals

Change from base Build<PHONE_NUMBER>:
-2.7%

Covered Lines:
2855

Relevant Lines:
5637

💛  - Coveralls


Minor UI issues

Hi, just a few suggestions I wanted to pass along:

Card size expands to match snapshot res. (card on the right mirrors the inital size of the card on the left)

Positioning w/ menu_mode: overlay conflicts with use/positioning of WebRTC card's 'Title' element (below). Perhaps add position-related options including top center, bottom center, and bottom right (just basing those on what would work with WebRTC card's elements + 'ui' option set to true)

Add option to remove 'View Frigate UI' button (reduce button clutter)

Color/highlight motion sensor icon when entity is binary / '1'

Add optional buttons to show/toggle camera's 'detect' / 'recordings' / 'snapshots' state. In my case, idea would be to quickly assess whether 'detect' role (in particular) happens to be disabled for some unexpected reason

Downsize card / button sizes by 25%

Good work!

Thanks @HITChris for the really great suggestions. A few clarifications:

Card expands to match snapshot resolution: I think what's happening there is you've added an 'object' camera instead of a live Frigate camera (i.e. the issue isn't actually  with the a snapshot viewed in the snapshot gallery). Am I right? (That's not something I had considered as a usecase, but I could see how that would be useful).

Menu mode overlay: Would the different options should adjust the vertical  position of the menu in your mind? I'm not sure this one is worth it, since the menu can also be moved outside the video frame entirely with  "above" and "below" modes. Any "bottom" based overlay option will interfere with the playing controls.

"Color/highlight motion sensor icon when entity is binary / '1'" -- I think you mean when motion is detected, change the icon color, right?

"Downsize card / button sizes by 25%" -- think you mean the button sizes, not the card size, right? Those buttons are the stock HA button elements in their natural size, shrinking them may not look right ... but I'll experiment!

Feedback:

Card expansion - I'm using a RTSP stream via the WebRTC card ('url' param). The WebRTC card's overall height expands as soon as I click 'View snapshots', + a random Frigate-based snapshot

Menu mode - At least for my use case (above, w/ WebRTC card using a 'Title', and with 'ui' set to True), horizontal alignment would probably be more helpful than vertical. Again just my own UI woes.... but the 'above' and 'below' options expand the WebRTC card's height, which for me (in a dashboard with limited real estate) is a no go

Color/highlight - Right. My use case might be unique... but pulling up a motion sensor's state history isn't (at least via this button) something I'd do with any real frequency. Just speaking for myself -- when it comes to tacking functionality into a camera/surveillance-focused card, I'd take more advantage of things that give a quick indication of general statuses (hence motion sensor status via highlighting, optional buttons showing highlighted status of camera's Frigate roles, etc.)

Downsize card - I don't think that takes away from the user experience though, so no worries on this one. Only reason I brought it up was because, relative to all other (video player related) UI elements in AlexxIT's WebRTC card, frigate-hass-card's buttons seem a good bit larger

Thanks!

Sincere thanks for the really great feedback @HITChris . I've opened separate issues for all the items you suggest so I (or someone else) can work through them 1-by-1. Follow along on the individual bugs, thanks again.


HAWQ-1: remove all .p4ignore files

Alternate PR to Roman's that addresses removal of all .p4ignore files, not just the one in the top directory.

1 Looks good to me

Committed to main with https://github.com/apache/incubator-hawq/commit/8bce795dbf0d464f9d1a357160d1f02b18045db5


removes last character from the uri string if it ends with slash

Fixes #474 and #421

build failed.

The thing with this PR is that it both changes the behavior of Spark which would mean a version bump up to 3.0. The other thing is that I'm fairly sure that this would actually be incorrect behavior to have as default.
To address the issues #474 and #421 there should be a solution more like:
http://www.sinatrarb.com/faq.html#slash


Mouse utilities - Mouse highlighter - Always show mouse highlighter

Description of the new feature / enhancement
Add an option to always keep the mouse highlighted, not just when mouse buttons are clicked.
Scenario when this would be used?
It is useful to always know where the mouse is on the screen and makes it easier for others to follow the mouse in a presentation.
Supporting information
No response

/dup #14137


Got an error when attempting to open a GlueSessions

Describe the bug
I was using Cosmos to orchestrate dbt jobs with dbt-glue and encountered below error mentioned not able to locate credential to create glue session, I checked source code of Cosmos's behavior and found it would initiate subprocess to communicate with Glue, and I have configured iam role arn at dbt profile.yml, however no aws credentials can be located and it should have connected with aws iam role.
Suspecting it could only use ak/sk in env and passing to subprocess?
Steps To Reproduce
In as much detail as possible, please provide steps to reproduce the issue. Sample data that triggers the issue, example model code, etc is all very helpful here.
Expected behavior
Using IAM role
Screenshots and log output
[2023-08-29, 04:44:58 UTC] {{taskinstance.py:1768}} ERROR - Task failed with exception
Traceback (most recent call last):
File "/usr/local/airflow/.local/lib/python3.10/site-packages/cosmos/operators/local.py", line 282, in execute
result = self.build_and_run_cmd(context=context)
File "/usr/local/airflow/.local/lib/python3.10/site-packages/cosmos/operators/local.py", line 194, in build_and_run_cmd
return self.run_command(cmd=dbt_cmd, env=env, context=context)
File "/usr/local/airflow/.local/lib/python3.10/site-packages/cosmos/operators/local.py", line 185, in run_command
self.exception_handling(result)
File "/usr/local/airflow/.local/lib/python3.10/site-packages/cosmos/operators/local.py", line 77, in exception_handling
raise AirflowException(
airflow.exceptions.AirflowException: ('dbt command failed. The command returned a non-zero exit code 1. Details: ', '\x1b[0m04:44:57  Running with dbt=1.4.6', '\x1b[0m04:44:57  Unable to do partial parsing because config vars, config profile, or config target have changed', '\x1b[0m04:44:57  Unable to do partial parsing because profile has changed', '\x1b[0m04:44:57  Unable to do partial parsing because env vars used in profiles.yml have changed', '\x1b[0m04:44:57  Unable to do partial parsing because a project dependency has been added', '\x1b[0m04:44:58  [\x1b[33mWARNING\x1b[0m]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.', 'There are 2 unused configuration paths:', '- models.dbtgluenyctaxidemo.gold_metrics', '- models.dbtgluenyctaxidemo.silver_metrics', '\x1b[0m04:44:58  Found 4 models, 0 tests, 0 snapshots, 0 analyses, 367 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics', '\x1b[0m04:44:58', '\x1b[0m04:44:58  Glue adapter: Got an error when attempting to open a GlueSession : Unable to locate credentials', '\x1b[0m04:44:58  Glue adapter: Got an error when attempting to open a GlueSession : Database Error', '  Unable to locate credentials', '\x1b[0m04:44:58', '\x1b[0m04:44:58  Finished running  in 0 hours 0 minutes and 0.08 seconds (0.08s).', '\x1b[0m04:44:58  Encountered an error:', 'Database Error', '  Got an error when attempting to open a GlueSessions: Database Error', '    Unable to locate credentials')
[2023-08-29, 04:44:59 UTC] {{taskinstance.py:1318}} INFO - Marking task as FAILED. dag_id=my_cosmos_dag_v2, task_id=silver_nyctaxi_avg_metrics.silver_nyctaxi_avg_metrics_run, execution_date=20230829T044451, start_date=20230829T044454, end_date=20230829T044459
[2023-08-29, 04:44:59 UTC] {{standard_task_runner.py:100}} ERROR - Failed to execute job 3 for task silver_nyctaxi_avg_metrics.silver_nyctaxi_avg_metrics_run (('dbt command failed. The command returned a non-zero exit code 1. Details: ', '\x1b[0m04:44:57  Running with dbt=1.4.6', '\x1b[0m04:44:57  Unable to do partial parsing because config vars, config profile, or config target have changed', '\x1b[0m04:44:57  Unable to do partial parsing because profile has changed', '\x1b[0m04:44:57  Unable to do partial parsing because env vars used in profiles.yml have changed', '\x1b[0m04:44:57  Unable to do partial parsing because a project dependency has been added', '\x1b[0m04:44:58  [\x1b[33mWARNING\x1b[0m]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.', 'There are 2 unused configuration paths:', '- models.dbtgluenyctaxidemo.gold_metrics', '- models.dbtgluenyctaxidemo.silver_metrics', '\x1b[0m04:44:58  Found 4 models, 0 tests, 0 snapshots, 0 analyses, 367 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics', '\x1b[0m04:44:58', '\x1b[0m04:44:58  Glue adapter: Got an error when attempting to open a GlueSession : Unable to locate credentials', '\x1b[0m04:44:58  Glue adapter: Got an error when attempting to open a GlueSession : Database Error', '  Unable to locate credentials', '\x1b[0m04:44:58', '\x1b[0m04:44:58  Finished running  in 0 hours 0 minutes and 0.08 seconds (0.08s).', '\x1b[0m04:44:58  Encountered an error:', 'Database Error', '  Got an error when attempting to open a GlueSessions: Database Error', '    Unable to locate credentials'); 1230)
System information
The output of dbt --version:
Core:
  - installed: 1.4.6
  - latest:    1.6.1 - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:
  - spark: 1.4.3  - Update available!
  - glue:  1.4.23 - Update available!

  At least one plugin is out of date or incompatible with dbt-core.
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

The operating system you're using:
The output of python --version:
Python 3.10.9
Additional context
Add any other context about the problem here.

The error log said Unable to locate credentials which means dbt-glue adapter could not refer the AWS credentials as you mentioned.
dbt-glue adapter depends on boto3 (AWS SDK for Python), which refers not only access key/secret key, but also default credential chain defined in https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html.
I would recommend you to check your credential setting.

Hi @jerrywonggithub . Did you manage to find a solution? I am facing exactly the same issue in the same conditions.

For those that may face the same problem, the issue here is that dbt glue adapter when creating a boto3 session look for "default"  profil, so in your MWAA dag you can set up this with something similar to
import subprocess

subprocess.run(["aws", "configure","set","aws_access_key_id","YOUR_AWS_ACCESS_KEY_ID","--profile","default"])
subprocess.run(["aws", "configure","set","aws_secret_access_key","YOUR_AWS_SECRET_ACCESS_KEY","--profile","default"])

there are better ways to do it, but that a quick and dirty way to fix your issue @jerrywonggithub

@AmineIzanami  I am running into this error when I try the above solution. What am I missing here??
[Errno 13] Permission denied: 'aws'

@AmineIzanami I am running into this error when I try the above solution. What am I missing here??
[Errno 13] Permission denied: 'aws'

Follow-up:  It seems I didn't actually have aws installed in my docker container. Solved!


Send cookies to ALB

Closes #2
Set 'credentials': 'include' for requests going to NCPI servers.

No longer needed due to deployment under the same domain


[client] Load banks not defined in the config

Banks read by clients need to be defined in the config currently, this makes it incovenient to run liquidators safely, as they have to be updated with latest client versions.
Let liquidators still access new banks without having to update and restart them.

As of recently there is no more static banks config in the SDK.
It was solely used to specify the token symbol for that bank, which is now done outside of the SDK, for instance in the dapp and liquidator by using an external cache.
As long as the consumer app does what is necessary to periodically fetch the latest banks, nothing in SDK hinders that process anymore.


What about open source PHP platform?

I can not find any documentation or help for the open source PHP platform. Can you please guide me through.

I believe that's a different project
On Saturday, 25 June 2016, tejas239<EMAIL_ADDRESS>wrote:

I can not find any documentation or help for the open source PHP platform.
Can you please guide me through.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MagenTys/cherry/issues/4, or mute the thread
https://github.com/notifications/unsubscribe/ABj3E9-5d3ldEXNJNlmVwsBeLk2lanWjks5qPM11gaJpZM4I-SFM
.


cmd/debug: debug cmd support fstab mountpoint

Codecov Report
Base: 58.81% // Head: 58.74% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (0eaa926) compared to base (56f2f44).
Patch coverage: 27.65% of modified lines in pull request are covered.

:exclamation: Current head 0eaa926 differs from pull request most recent head 3426aa2. Consider uploading reports for the commit 3426aa2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
- Coverage   58.81%   58.74%   -0.08%
==========================================
  Files         141      141
  Lines       24613    24721     +108
==========================================
+ Hits        14476    14522      +46
- Misses       8254     8315      +61
- Partials     1883     1884       +1

Impacted Files
Coverage Δ

cmd/debug.go
16.41% <0.00%> (ø)

pkg/meta/base.go
66.79% <0.00%> (-0.86%)
:arrow_down:

pkg/meta/interface.go
45.45% <ø> (ø)

pkg/meta/sql.go
63.78% <16.66%> (-0.15%)
:arrow_down:

pkg/meta/redis.go
69.05% <22.22%> (-0.75%)
:arrow_down:

pkg/meta/tkv.go
74.41% <27.27%> (-0.03%)
:arrow_down:

cmd/status.go
52.85% <30.00%> (-17.88%)
:arrow_down:

pkg/meta/sql_lock.go
71.72% <100.00%> (+1.43%)
:arrow_up:

pkg/vfs/handle.go
85.56% <0.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


WIP - Storage upload from file - binary data

WIP

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests


add some redis list commands

added support for some redis list commands
expanded ziplist API to contain trim, and added unit tests
some minor item API additions for slabbed storage

@thinkingfish wanted some input as to what the behavior should be for list find command, i have a comment in the diff that summarizes my uncertainty. still need to flesh out list get more to support multi get, and also need to write list push. will get working on these soon.

Maybe we can shelf/remove list_find given redis doesn't really have this API? If nobody has asked for it I wonder if people using lists simply don't need to find by value very often.
If we have a case for "find", I think we may also need to clarify the API to mean "find the first occurrence of X", and maybe even change the syntax to be List.find KEY VALUE [INDEX] so we can find subsequent occurrences? Anyway seems too many uncertainties to worry about for now.


Rake task to export class_hash and learner keys for adding to LARA Runs.

The idea is to update about ~500K learner-runs in LARA to include
class_hash values, which we need for FireStore authorization rules.
This commit is part of that story. Just exporting the values we need to use
later in this format:
CLAZZ_ID, CLASS_HASH, LEARNER_ID, LEARNER_KEY
[#165217423]
https://www.pivotaltracker.com/story/show/165217423

ping @scytacki

@scytacki nice catch. I rebased from master and cleaned up a bit.

👍


Allow Dynamic Override of Mailer Config

:woman_technologist: Bamboo's adopters would like to be able to pass dynamic configuration
into a single email delivery call, for scenarios such as un/pw, port
changes, or multi-tenancy.
:mailbox_with_mail: This change will update Bamboo.Mailer __using__ macro to allow passing
of optional config: keyword to the build_config/1 function. build_config/1
now pattern matches on config:, and will pass the value to
Bamboo.Mailer.build_config/3. This function will then merge the
dynamic configuration with the default configuration.
:octocat: See #470

I was looking for this feature but it's not documented, at least not quite as easy as I could find.
Going to PR it as soon as I have a break tho


Add logo to cwa-bot

Current Implementation
The cwa-bot, which picks up new issues and adds them to ToDo in the CM project of the repository as well as moves issues between different groups in the CM project when e.g. labels are applied, uses the picture of the person who developed it, @svengabr.
Suggested Enhancement
The CWA logo should be used as the picture of the bot.
Expected Benefits
Cleaner look, no huge benefit but also a more professional look.
Additional Information
The picture in the bot can't be seen on the mobile app.

@heinezen Any idea how to configure this?

Here's the instruction how to do it: https://docs.github.com/en/developers/apps/creating-a-custom-badge-for-your-github-app
I think @svengabr would have to do it since he's the developer.

@dsarkar I'll see what I can do.

@Ein-Tim I did implement the logo change to my bot.
If it won't show up right away, try to clear your cache and then try again.
I let this open for you to confirm and close the issue.

@svengabr
I can see the change!
Thank you! Looks much cleaner IHMO (but it was also quite nice to see you 😉).
Thank you!
Closing as implemented.

@Ein-Tim Thanks!

Great change :+1: thanks for suggesting and implementing it!

Very nice, indeed @Ein-Tim


fix: Use Target es2018 to Match gts

TypeScript defaults to using an ancient target, es3. We should at least match gts's es2018:

https://www.typescriptlang.org/tsconfig/#target
https://github.com/google/gts/blob/d2bd712496bc8bb305980e9810886647c73fa390/tsconfig-google.json#L15C16-L15C22

🦕

Tried to allow --project option, but blocked by:

https://github.com/microsoft/TypeScript/issues/27379


Use Node.js to call Google API and put it into a cloud function. client method cannot return data

const listDevicesForGateway = async (client,projectId,cloudRegion,registryId,gatewayId) => { const parentName = projects/${projectId}/locations/${cloudRegion}/registries/${registryId}; const request = { parent: parentName, 'gatewayListOptions.associationsGatewayId': gatewayId, }; let devices; try { const {data} = await client.projects.locations.registries.devices.list( request ); devices = data.devices; } catch (err) { console.error('Could not list devices', err); return; } console.log('Current devices bound to gateway: ', gatewayId); if (devices && devices.length > 0) { devices.forEach(device => { console.log(\tDevice: ${device.numId} : ${device.id}); }); } else { console.log('No devices bound to this gateway.'); } };
const {data} = await client.projects.locations.registries.devices.lis cannot return data.
I try to use const client = new iot.v1.DeviceManagerClient to get part of the API function data, but I can't implement other API functions to deploy to cloud functions
Thanks for help, urgent help!

This client library method cannot return data.

@proppy @stephenplusplus @lukesneeringer

@yeuuaeh it might be worth taking a look at our @google-cloud/iot library, which provides fairly detailed instructions for getting up and running with an authenticated client.

@bcoe Thank you for your answer, I tried the google-cloud / iot-Node.js package to implement a unique API, but some functions are not provided on the google-cloud / iot source code, and can only implement ordinary device registration , Delete, modify. What can't be achieved, such as adding a gateway and communication with the device, MQTT connection, but I encountered a problem during the Mqtt connection process, why can't I read the connected device using the google-cloud / iot-Mqtt method. Hope you can help me see.
code show as below:

@bcoe

@yeuuaeh if I"m understanding correctly, you are receiving no results when calling registries.list?

@bcoe Yes, for example, I need to bind the device to the gateway and register the gateway, but there is no method to directly call the API under the @ google-cloud / iot library Node.js package, and the source code and official instance are also client.probjects.locations .registries.list, this way request the client, but has been unable to return to the data.

I think this is similar to the issue being discussed here, so it doesn't relate directly to the client libraries (since you're using MQTT); the advice was to open a StackOverflow question, and it sounds like folks can help people there :+1:
Hopefully this gets you moving in the right direction :+1:


virtualenv tests should inherit system site-packages

This way we do not need compile and install anything. We will test with the same version of packages we have compiled with (and the same as bazel test is running). Also we do not need install gcc and compile pip packages.

@jendap I incorporated this change into 1472, along with some related changes. So this PR can be closed if it's okay with you.

Closing this as it is incorporated into https://github.com/tensorflow/tensorflow/pull/1472


stable/grafana persistence.accessModes has a invalid default

Is this a request for help?:
I was able to work around it by setting a valid value
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug Report
Version of Helm and Kubernetes:
Helm: 2.11.0
Kubernetes: 1.10.7
Which chart:
stable/grafana
What happened:
I enabled persistence, set storageClassName and size, and got the following error
Error: UPGRADE FAILED: failed to create resource: PersistentVolumeClaim "prometheus-operator-grafana" is invalid: spec.accessModes: Required value: at least 1 access mode is required
What you expected to happen:
I expected valid defaults or indication that this parameter is required when enabled
How to reproduce it (as minimally and precisely as possible):
Configure persistence with default persistence.accessModes value
Anything else we need to know:

@ntbrittain https://github.com/helm/charts/blob/master/stable/grafana/values.yaml#L109 looks perfectly valid to me.
Would you suggest that this default should be uncommented by default?

@Dean-Coakley I suggest either uncommenting the default, or updating the documentation to indicate that it is required: https://github.com/helm/charts/blob/master/stable/grafana/README.md
As it is, the documentation indicates that it has a default of [], which I find misleading. I expect that if I leave out values which have defaults, that those defaults are valid.

@ntbrittain I've opened a PR uncommenting the default. Feedback welcomed.


Make TouchScreenButton connections reference counted

Prevents errors when assigning the same texture to both slots
Follows up on #75016, which was cherry picked

I'll just go ahead and remove it, took it from other usage to clarify

Thank you!


DM-32648: Change default branch to main.

Actually, @jonathansick if you could look over the change to conf.py only, that would be great.  I think the rest is all uncontroversial documentation.


Choosing an install method confusion

The readme labels the install script method as "The best way" to install. But this is a bit confusing. Is it just a tongue-in-cheek way of saying that the install script is really cool? Or are there other benefits to using the install script instead of Homebrew?

For users who can't use homebrew, it's really cool to use the installation script.

Not all people can use homebrew, this way is just a default. Also it doesnt adhere to some ofthe standards that homebrew devs go by, which could change some of the formulas


Compare normalized pmi to regular

Right now the pmi matrix is generated using the standard pmi formula. Try out the normalized version and see whether it is better:
npmi = pmi / -log pxy
This formula is supposed to emphasize rare items less.

Compared and swithched to pmi2


How is the performance of inference speed?

Are there any specific data, in terms of performance on CPU and GPU?

Thank you for your interest in the project
I'm able to achieve a speed of approximately 200 tokens per second on my own computer's CPU. I plan to release the pretrained model within the next one to two weeks, at which point you'll be able to conduct your own tests.

Thank you for your interest in the project
I'm able to achieve a speed of approximately 200 tokens per second on my own computer's CPU. I plan to release the pretrained model within the next one to two weeks, at which point you'll be able to conduct your own tests.

Great work! Achieving 200 tokens per second on the CPU is impressive. I'm looking forward to the pretrained model you've trained.


Mazda: Add 2023 CX9 fw

DongleID: 629c4aced073d15a
Discord User: bsk#7841

This branch worked for my CX-9. Thank you for doing this Alan! I highly recommend updating the fingerprinting wiki page to default to this method. Ultimately you want people to open the PR anyways, so creating the fork and skipping all the SSH stuff seems the best way to test fingerprinting.

@bhajneet glad it works. Re-opening this PR.

Do you know if the min steering speed still 28 mph?

Do you know if the min steering speed still 28 mph?

How can I check for you? As far as I know comma is hardcoded to show that message. So I'm wondering if comma just doesn't even try to steer below that vs the car is unable to steer below that.

That's correct, it doesn't try to steer below that speed so we don't know yet. You can try to comment out these two lines (or delete) to have it attempt to steer to zero: https://github.com/commaai/openpilot/blob/47977b2c0ed9f46d79e4a839ed8d83bace885504/selfdrive/car/mazda/interface.py#L44-L45

@bhajneet I just commented those 2 lines on the same branch. You can let the C3 pull the new update and test.
https://github.com/alancyau/openpilot/commit/89ce319f38d33ba2dc0bda60d924b608cddce29f

Okay, this is my report:

Below 32 mph, OpenPilot does not use any steering.
After OpenPilot is engaged (green border / message), it will steer down to 28 mph.
After going below 28 mph it will warn the driver to take control of the steering.
If disengaged below 32 mph, OpenPilot continues to give the orange caution that there is no steering available.

I hope this helps. I'm not sure if this is a hard limitation from the Mazda hardware or something that still needs to be developed in the OpenPilot software. If it is possible to get low speed steering with some software changes, I would like to help if possible, since it will benefit my driving experience!

That seems to align with the current CX9. Also 23 eps fw is still the same, so I didn’t expect any change on the eps side.
Unfortunately this is a software limitation on the eps firmware side and requires reflashing. I’ve heard people swapping eps racks before so maybe a 22 cx5 may work.


Handling more pages

Opportunity
Right now Primo is limited by the number of pages that can be created, making it impossible for more serious websites to adopt it. Many websites make use of WordPress, which offers blogging functionality. Integrating blogging in Primo would allow many websites to make this switch.
Problem
While Primo does have a "Posts" component, it is pretty limited and not that straightforward to use. It only works neatly when having a handful of informational posts. Not hundreds of posts as many mature blogs would have. Aditionally:

The page list screen gets laggy when it has to render a lot of pages.
Saving starts to take a while because of having to save the whole site file at once, and the same thing for publishing because it uploads the whole site with every update.

Potential solutions

WordPress has a separation between pages and posts. Pages are permanent sources of information, whereas posts are articles on a site.
Rendering the preview pages seems like overkill to me. Just having a list of all pages/posts should be sufficient.
Saving could be fixed by only uploading changes to the site & having the server apply those to the site file. Publishing can stay quick by only uploading pages that have been updated, as opposed to the whole site.

V2 fixes most of these issues by saving to db records instead of a single JSON file, so saving is near-instant regardless of site size. Additionally, the page view has been simplified to a list. Long publish times could still be an issue, but I'll let that arise as a separate issue.


feat: Add callback function to notifications

This commit introduces a new callback function to the notification system. This function can be used to trigger custom events on a notification. It receives a config object and the notification text as parameters. The callback function is optional and is added to the config object in config.lua. The notify function in util.lua has been updated to call the callback function if it is provided.
This would be one way to handle a request we had in https://github.com/tris203/precognition.nvim/issues/62
But open to your ideas about implementation.
Draft as this is just a talking point for now

I am open to the implementation, perhaps it should overwrite the notify function completely rather than just be additional.
It depends what you would like to consider

@m4xshen did you have any thoughts on this?

Hi @tris203, sorry for the late reply.

I am completely open to the implementation, perhaps it should overwrite the notify function completely rather than just be additional.

Could you please provide an example of how precognition.nvim will use this option to achieve integration under both implementation?
It's hard to say which one is better. It would be nice to have some example code.

It's hard to say which one is better. It would be nice to have some example code.
In the current implementation you can pass something like this in setup:

  {
    'm4xshen/hardtime.nvim',
    opts = {
      callback = function(config, text)
        require('precognition').peek()
      end,
    },
  },

This will toggle the precognition hints every time that you get a notification from hardtime.
If we were to overwrite the function entirely, then it would be very similar, except that you would also be required to recreate the notification as well as the additional actions

Got it. I prefer to overwrite the function entirely and the default value of callback should be util.notify.

Have made changes and rebased @m4xshen

@tris203 Thanks for the PR! You can now use this option to integrate with precognition.nvim!
btw I'm looking forward to the inlay hint feature, is this available now?

@tris203 Thanks for the PR! You can now use this option to integrate with precognition.nvim!
btw I'm looking forward to the inlay hint feature, is this available now?

Thanks @m4xshen
Yeah inlay hints are merged as of a few weeks ago!


Fix bugs detected from PE dry run

Codecov Report
Base: 77.21% // Head: 77.21% // No change to project coverage :thumbsup:

Coverage data is based on head (fd63fa6) compared to base (0b1fb82).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage     77.21%   77.21%
  Complexity      759      759
=========================================
  Files           117      117
  Lines          2291     2291
  Branches        287      287
=========================================
  Hits           1769     1769
  Misses          447      447
  Partials         75       75

Impacted Files
Coverage Δ

.../main/java/seedu/address/model/project/Budget.java
80.00% <ø> (ø)

...n/java/seedu/address/model/staff/StaffContact.java
80.00% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
11.53% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


hideExpression exception when model null.

An exception is thrown when the model the hide expression uses is null. Please see here.
To reproduce click on the "Set Model to Null" button and then switch to your browsers console to see the error.
This looks to be caused by "const val = model[field.key];" line in the runFieldExpressionProperties method of the FormlyFormController controller.
I have updated the code locally to "const val = model == null ? undefined : model[field.key];" and this fixes the problem by treating a null model as an undefined property, I'm unsure however if this is the correct way to fix it.

Is there some reason you don't just use the function form and safely resolve your model property from there e.g.:
hideExpression: function($viewValue, $modelValue, scope) {       return scope.model && scope.model.baz === 'foobar';     }

I ‘ve highlighted the problem line of code below from the FormlyFormController:
function runFieldExpressionProperties(field, index) {
const model = field.model || $scope.model

const promise = field.runExpressions && field.runExpressions()

if (field.hideExpression) { // can't use hide with expressionProperties reliably

  const val = model[field.key]

  field.hide = evalCloseToFormlyExpression(field.hideExpression, val, field, index, {model})

}

if (field.extras && field.extras.validateOnModelChange && field.formControl) {

  if (angular.isArray(field.formControl)) {

    angular.forEach(field.formControl, function(formControl) {

      validateFormControl(formControl, promise)

    })

  } else {

    validateFormControl(field.formControl, promise)

  }

}

}
As you can see the issue isn’t with a property of the model being null but the model itself being null. The code makes the assumption that the model is always going to have a value which isn’t true in my case. Changing the line to “const val = model == null ? undefined : model[field.key]” keeps the behaviour consistent as far as I can see and allows for a null model.
Omsad
From: franzeal<EMAIL_ADDRESS>Sent: 22 July 2016 18:09
To: formly-js/angular-formly
Cc: Omsad; Author
Subject: Re: [formly-js/angular-formly] hideExpression exception when model null. (#698)
Is there some reason you don't just use the function form http://docs.angular-formly.com/docs/formly-expressions#expressionproperties-validators--messages  and safely resolve your model property from there e.g.:
hideExpression: function($viewValue, $modelValue, scope) {
return scope.model && scope.model.baz === 'foobar';
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/formly-js/angular-formly/issues/698#issuecomment-234600145 , or mute the thread https://github.com/notifications/unsubscribe-auth/ARgv1lU_RnGvb5a_bbZP2i0wb86dnvOqks5qYPkcgaJpZM4JN_gY .  https://github.com/notifications/beacon/ARgv1rN2gLxx-KMzYd6-DyzZrEoeqxzXks5qYPkcgaJpZM4JN_gY.gif

Why would you want to set your model to null in any case? Model needs to be an object, it can be empty object like {} or Object.create(null) but never null because if you decide to put some property on it, you will not be able to because you cannot store any property on null. If you want to clear the model completely, use an empty object as replacement {}.

I use null as a representation of an unassigned object, e.g. it should never have properties set on it. By the time any properties on it are assigned, the model will have been changed to a real object so there will be no issue.
If at any point a property of the model is assigned and the model is null I would want an error to occur as that would mean there is a bug in my logic controlling that particular model.
If I was to use an empty object everything which was bound to it would have to check to see if the object was "empty" or "real", as different logic occurs depending upon the current value.
From a readability and code maintenance point of view having the extra logic to calculate the above is a pain because I would have to have it in multiple locations as I use multiple templates either bound directly to the "model", bound to the parent of the model through a property, or bound to a child property of the model.
These templates would then need to know the context of what was being bound to them as for some of the templates an empty object is a perfectly valid model to bind. This would introduce a dependence into the controller using them which could be forgotten / misconfigured.

Well I'm not a fan of allowing null as a model - this will only cause hard to catch errors on any taken action. Putting null as a model and observing if errors are thrown is not a good way of debugging your code :) That said, your patch seems simple enough so I don't see a reason not to include it.
I think we could use a second opinion here, anyone?

@formly-js/angular-formly-collaborators second opinion anyone please?

I would not recommend this change be made.


load file error

Hi！！I encountered the following problem while running the project.
"""""""""""""""""""""""""""""""""""""""
final text_encoder_type: bert-base-uncased
=====> [ERROR]: We couldn't connect to 'https://huggingface.co' to load this file, couldn't find it in the cached files and it looks like bert-base-uncased is not the path to a directory containing a file named config.json.
Checkout your internet connection or see how to run the library in offline mode at 'https://huggingface.co/docs/transformers/installation#offline-mode'., sleep for 20s...
""""""""""""""""""""""""""""""""""""""
It seems that I can't connect to the huggingface website, I want to download these files offline, can you give me some help? For example, which web do I need to go, what files do I need to download and where do I need to put them?

2 solutions:

use a proxy (e.g. clash)
check out this blog for huggingface model deployment

Thank you very much for your answer!!


pythonPackages.fetchpypi: fetch tarballs from pypi

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

This function grabs the url, version and hash for a specified package from a file that was generated by update-hashes.

Until we have fetchTarball with sha256 support I would like to use this script to update the hashes of the packages.
I could integrate it into the buildPythonPackage function, but what that function needs first is a version parameter, and converting all packages to use that is going to take time.

@Mic92 thanks for the review.
As I wrote in #16005 we cannot use an external repo yet, because nix stable doesn't yet have fetchTarball with hash support. Even so, we could use the method with buildPyPIPackage and instead keep the json in this repo, like I do in this PR. I'm going to work on that approach, because that's in the direction we will go eventually anyway. The method I use here is also not so convenient for NixOS stable.


feat(defaultimport): default import mixed parsing

Feature to parse the default import syntax of the newer typescript:
const parsed = await parser.parseSource(`import Foo, { Foobar } from 'myLib';`);
const parsed = await parser.parseSource(`import Foo from 'myLib';`);
const parsed = await parser.parseSource(`import { Foo } from 'myLib';`);
const parsed = await parser.parseSource(`import { Foo, default as Bar } from 'myLib';`);

Does remove the default import definition from the generator.
BREAKING CHANGE: Remove the default import definition from the declarations.
The default imports are now generated by namedImport instead of it's
own definition. The namedImport has now a defaultAlias property that
generates the default import if needed.

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f293a09b054427701122c6d323510798e6 on feat/default-import-mixed-parsing into fac428714cf527ab03ec607237d804b256990044 on develop.

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f293a09b054427701122c6d323510798e6 on feat/default-import-mixed-parsing into fac428714cf527ab03ec607237d804b256990044 on develop.

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f293a09b054427701122c6d323510798e6 on feat/default-import-mixed-parsing into fac428714cf527ab03ec607237d804b256990044 on develop.


How to render SurfaceTexture content into Unity via FBO?

I have been working on related projects recently. Searching on Google search uses FBO to achieve this effect. What should I do?

Hi @hywenbinger,
Unfortunatelly I'm out of cycles to work on new requests but can try to provide some suggestions. Can you share your use case?
This repo shares a specific need in which I had to intercept the Android camera pixels, modify it and later display in Unity.
Depending on what you need to achieve some layers of this solution are optional.

Hi @robsondepaula
Thank you very much for your reply, your project gave me some inspiration.
I have uploaded the demo to github, the URL is https://github.com/hywenbinger/android_unity_video.
In my demo, I can already show the video through a shader.
I need to get Texture2D to do some other processing on the image, but for now I can only get the external texture.
Some people suggest that can use FBO to achieve the effect of oes->fbo->2d, but my opengl is not very good. Can you give some suggestions?

Hello @hywenbinger,
Nice of you to upload your demo. It looks neat.
I could take a quick look and noticed you are creating the texture on the Android Plugin. I recall that when I was working on the unity camera plugin I couldn't modify the Texture2D if I created it the same way you are doing.
What worked is the flow you can verify in the code that I shared:

The Texture2D is created on Unity (CameraPluginWrapper.cs).
A pointer to this Texture2D is passed to a low level Android plugin (RenderingPlugin.cpp) using GetNativeTexturePtr(). With this value, OnRenderEvent() will call a regular Android plugin (CameraPluginActivity.java).
Each call made by the low level plugin will end up calling requestJavaRendering() on the regular Android plugin.
Finally the regular Android plugin updates the Texture2D.

Although the architecture may look awkward, it is what produced the result I needed.
One thing I could suggest is that you try this flow and see if it unblocks you before having to ramp-up on OpenGL (I'm also not skilled on it).

Hi @robsondepaula ,
Thank you very much for your suggestion, I will try it according to your project.


ducked?

The media session is currently suspended from having platform-level media focus and its participating media elements are either paused or ducked

"ducked"?

This is a technical audio term, maybe it would be good to link to a definition or something?
Wikipedia does a good job at explaining what it is.

Agree... let's get into the habit of defining jargon early (specially for terms outside of web dev).

Yeah, link please. I had absolutely no idea what it meant, and assumed it had to be a typo of some kind. I couldn't figure out what it was meant to say, tho. ^_^

It's kind of defined in the intro already:

Native application developers can specify the conditions in which media content
should pause or duck on audio interruptions (i.e. pause or lower the volume for
the duration of an interruption

we could just throw a <dfn> in there.

Ah, I did a Ctrl+F for "ducked" and didn't find anything. ^_^  Y'all are Bikeshedding, so yeah, just use a <dfn>duck</dfn> and ducked.

I agree we should define this to avoid ambiguity on this terminology.
I've added definitions for 'duck' and 'unduck' (as well as 'pause' and 'unpause') in https://github.com/whatwg/mediasession/commit/535a3d991dd3175d04c15a9141455828663f9284.
Closing this issue.


Fixed the way to get username and password.

When I executed sql: "ALTER TABLE search. logs DETACH PARTITION 20181103", I received this exception: "DB:: Exception: Password required for user default".
When sending requests to leader, member variable context does not get the correct username password. We should use context in the dropPartition method parameter or get the user name and password of leader from the cluster configuration. Truncate also has similar problems.
Here, I used the way to get the username and password of leader from the cluster configuration to fix this.

Missing integration test.

@alexey-milovidov Maybe use context.getInterserverCredentials() is better? But that may require some refactor

How to choose username and password :
<remote_servers>
    <database_a_cluster>
        <shard>
            <replica>
                <host><IP_ADDRESS></host>
                <user>username_a</user>
                <password>password_a</password>
            </replica>
        </shard>
    </database_a_cluster>
    <database_b_cluster>
        <shard>
            <replica>
                <host><IP_ADDRESS></host>
                <user>username_b</user>
                <password>password_b</password>
            </replica>
        </shard>
    </database_b_cluster>
</remote_servers>

Maybe we can refactor InterserverCredentials to support queries ?

I am trying to complete the integration test.I executed: "pytest -k test_replace_partition".
The following error occurred.

/python2.7/subprocess.py:542: CalledProcessError
--------------------------------------------------------------------------------------------------------------------------- Captured stderr setup ----------------------------------------------------------------------------------------------------------------------------
Removing network clickhouse_default
Network clickhouse_default not found.
.IOError: [Errno 2] No such file or directory: '/data0/dev/ClickHouse/dbms/tests/integration/test_replace_partition/_instances/node1/docker_compose.yml'
____________________________________________________________________________________________________________________ ERROR at setup of test_drop_failover ____________________________________________________________________________________________________________________

@pytest.fixture(scope="module")
def drop_failover():
    try:
        cluster.start()

        _fill_nodes([node3, node4], 2)

        yield cluster

    finally:
>       cluster.shutdown()

CentOS Linux release 7.5.1804
Docker version 18.09.0, build 4d60db4
docker-compose version 1.23.1, build b02f130
This is pytest version 4.0.0
Excuse me, where is this problem? Thank you.

@alesapin
Hello, thank you.
I have some such errors now.
"NotFound: 404 Client Error: Not Found ("No such container: roottestreplacepartition_node5_1")"
docker_client.containers.get(docker_id) did not get the container. I don't know why docker_id is roottestreplacepartition_node5_1.
The docker_id is expected to be like this 45e6d2de7c54.
There is another problem: "E Exception: Instance `node1' failed to start. Container status: exited, logs: Include not found: clickhouse_remote_servers
E Include not found: clickhouse_compression
E Logging trace to /var/log/clickhouse-server/clickhouse-server.log
E Logging errors to /var/log/clickhouse-server/clickhouse-server.err.log
E Include not found: networks
E Include not found: networks
E Include not found: networks
"There are some configurations for the service in the container that are not found. I don't know how the configuration file under /dbms/tests/integration/test_replace_partition/configs/ is combined with /etc/clickhouse-server/config.xml.
There is another problem. The initial location of the pytest program seems to be @pytest.fixture, but for example some ClickHouseCluster initialization is before it. I don't know when it was called. I need some help, thanks.

@alesapin
Hello,thank you.
This is with -ss option and provide full output.
[root@server50-ke integration]# pytest -ss -k test_replicated_drop_partition
============================================================================================================================ test session starts =============================================================================================================================
platform linux2 -- Python 2.7.5, pytest-4.0.0, py-1.7.0, pluggy-0.8.0
rootdir: /data0/dev/ClickHouse/dbms/tests/integration, inifile: pytest.ini
collected 91 items / 90 deselected

test_replicated_drop_partition/test.py Removing network clickhouse_default
WARNING: Network clickhouse_default not found.
  Wait for command to complete.  If
        the exit code was zero then return, otherwise raise
        CalledProcessError.  The CalledProcessError object will have the
        return code in the returncode attribute.

        The arguments are the same as for the Popen constructor.  Example:

        check_call(["ls", "-l"])
        """
        retcode = call(*popenargs, **kwargs)
        if retcode:
            cmd = kwargs.get("args")
            if cmd is None:
                cmd = popenargs[0]
>           raise CalledProcessError(retcode, cmd)
E           CalledProcessError: Command '['docker-compose', '--project-directory', '/data0/dev/ClickHouse/dbms/tests/integration/test_replicated_drop_partition', '--project-name', 'roottestreplicateddroppartition', '--file', '/data0/dev/ClickHouse/dbms/tests/integration/test_replicated_drop_partition/_instances/node1/docker_compose.yml', '--file', '/data0/dev/ClickHouse/dbms/tests/integration/helpers/docker_compose_zookeeper.yml', '--file', '/data0/dev/ClickHouse/dbms/tests/integration/test_replicated_drop_partition/_instances/node2/docker_compose.yml', '--file', '/data0/dev/ClickHouse/dbms/tests/integration/test_replicated_drop_partition/_instances/node3/docker_compose.yml', 'kill']' returned non-zero exit status 1

/usr/lib64/python2.7/subprocess.py:542: CalledProcessError
=================================================================================================================== 90 deselected, 1 error in 1.92 seconds ===================================================================================================================

I think you have some misconfiguration in your system, but now you can use runner script in dbms/test/integration for integration tests. It doesn't require any dependencies and configuration -- only docker. Try it out.

@alesapin
Thank you.
I still have some errors.
[root@server50-ke integration]# ./runner --binary /data0/dev/ClickHouse/dbms/programs/clickhouse --configs-dir /data0/dev/ClickHouse/dbms/programs/server/ 'test_odbc_interaction -ss'
Start tests
ImportError while loading conftest '/ClickHouse/dbms/tests/integration/conftest.py'.
ImportMismatchError: ('conftest', '/data0/dev/ClickHouse/dbms/tests/integration/conftest.py', local('/ClickHouse/dbms/tests/integration/conftest.py'))
Traceback (most recent call last):
  File "./runner", line 55, in <module>
    subprocess.check_call(cmd, shell=True)
  File "/usr/lib64/python2.7/subprocess.py", line 542, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'docker run --net=host --privileged --volume=/data0/dev/ClickHouse/dbms/programs/clickhouse:/clickhouse         --volume=/data0/dev/ClickHouse/dbms/programs/server/:/clickhouse-config --volume=/data0/dev/ClickHouse:/ClickHouse -e PYTEST_OPTS='test_odbc_interaction -ss' yandex/clickhouse-integration-tests-runner' returned non-zero exit status 4

@alesapin
Thank you.
When I executed the runner, I encountered the following error.
[root@server50-ke integration]# ./runner --binary /data0/dev/ClickHouse/build/dbms/programs/clickhouse --configs-dir /usr/local/etc/clickhouse-server/ 'test_replace_partition -ss'
Start tests
============================= test session starts ==============================
platform linux2 -- Python 2.7.15rc1, pytest-4.0.0, py-1.7.0, pluggy-0.8.0
rootdir: /ClickHouse/dbms/tests/integration, inifile: pytest.ini
collected 3 items

test_replace_partition/test.py Removing network clickhouse_default
Network clickhouse_default not found.

 Container status: {}, logs: {}".format(self.name, status, handle.logs()))
E               Exception: Instance `node1' failed to start.  Container status: {}, logs: {}".format(self.name, status, handle.logs()))
E               Exception: Instance `node1' failed to start.  Container status: {}, logs: {}".format(self.name, status, handle.logs()))
E               Exception: Instance `node1' failed to start. Container status: exited, logs: clickhouse: error while loading shared libraries: libreadline.so.6: cannot open shared object file: No such file or directory

helpers/cluster.py:425: Exception
------------------------------ Captured log setup ------------------------------
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              612 WARNING  Transition to CONNECTING
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              612 WARNING  Transition to CONNECTING
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              612 WARNING  Transition to CONNECTING
connection.py              608 WARNING  Connection dropped: socket connection error: None
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection error: Connection refused
connection.py              608 WARNING  Connection dropped: socket connection error: None
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              608 WARNING  Connection dropped: socket connection broken
connection.py              608 WARNING  Connection dropped: socket connection error: None
=============================== warnings summary ===============================
/usr/local/lib/python2.7/dist-packages/psycopg2/__init__.py:144
  /usr/local/lib/python2.7/dist-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
    """)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
===================== 1 warnings, 3 error in 58.18 seconds =====================
Traceback (most recent call last):
  File "./runner", line 55, in <module>
    subprocess.check_call(cmd, shell=True)
  File "/usr/lib64/python2.7/subprocess.py", line 542, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'docker run --net=host --privileged --volume=/data0/dev/ClickHouse/build/dbms/programs/clickhouse:/clickhouse         --volume=/usr/local/etc/clickhouse-server/:/clickhouse-config --volume=/data0/dev/ClickHouse:/ClickHouse -e PYTEST_OPTS='test_replace_partition -ss' yandex/clickhouse-integration-tests-runner' returned non-zero exit status 1

It looks like it is missing libreadline.so.6.


Accessing Memory objects with '[ ]' array syntax causes confusing build errors.

It sounds like it is only possible to access Memory data with square-bracket array syntax (memory[ index ]) during simulation.
But when I try to build a bitstream from a design which uses that syntax, it seems to cause an infinite loop in nMigen instead of printing an error. Interrupting the process results in some nested LegalizeValue exceptions which eventually point to:
nmigen.back.rtlil.LegalizeValue: ((+ (sig addr) (const 2'd2)), range(0, 1028), ('[...]/nmigen/hdl/mem.py', 91))

It sounds like this can be fixed by using the Memory object's read/write ports like the examples/basic/mem.py file demonstrates, but an error message might help make that more discoverable. Thanks!

Hum, shouldn't RecursionError be raised? I think it would be good to investigate why it isn't triggered.

Hum, shouldn't RecursionError be raised? I think it would be good to investigate why it isn't triggered.

Because it's not an infinite loop or recursion. It's just really slow.

https://github.com/amaranth-lang/rfcs/pull/45 may address this issue if accepted.


Implementation of fungibles::Inspect on pallet_balances returns unexpected error

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug
Substrate Version:

branch: master
rev: dec0369a35893c2be432e74358c4c7039e1e57be

Using the fungibles Inspect and Mutate traits on pallet-balances, transferring funds from a source account with not enough funds fails with Underflow instead of FundsUnavailable.
As the per the docs for WithdrawConsequence::Underflow, underflow means there is likely corrupted and unrecoverable state, yet the above scenario is normally expected to occur in a production setting.
The issue seems to be on the following line where we check TotalIssuance before the account balance
https://github.com/paritytech/substrate/blob/2e94e253950457571e91a5df1e60f82ba7b841dd/frame/balances/src/impl_fungible.rs#L109
I'm happy to contribute a fix if this issue is confirmed.
Steps to reproduce
Steps to Reproduce:
In a unit test environment, with an existential deposit of 1.

Mint 1 token into account of Alice
Transfer 2 tokens from Alice to Bob using Mutate::transfer

Expected error: TokenError::FundsUnavailable
Instead received error: ArithmeticError::Underflow
This is the reproducer test in our repository:
https://github.com/Snowfork/snowbridge/blob/a020f22860ce1268c60957c757ba96d3a1ef0f73/parachain/pallets/inbound-queue/src/test.rs#L290

As the per the docs for WithdrawConsequence::Underflow, underflow means there is likely corrupted and unrecoverable state, yet the above scenario is normally expected to occur in a production setting.

I would argue that it is unlikely that on a production network you are trying to send more tokens as total issuance. In your test you could add a third account with 5 tokens and get the expected error.
Generally this looks like some corner case to me. First checking the total issuance is faster and easier than doing all the other checks.


[BUG]: RTX 4080 - crash while loading Vulkan

Description
System: Win 11, RTX 4080 with abolute latest Nvidia driver

No CUDA installed in system
cuda 11, cuda 12 and vulkan all installed in runtimes folder
When starting up and loading model, an exception is thrown while initializing Vulkan
Error occurs also, when cuda 11 and cuda 12 are not present

This error is gone, once CUDA is installed from the Nvidia site, but I wanted to use Vulkan, since this does not require to install additional drivers from Nvidia (in theory).
Reproduction Steps
See above.
Code:
using LLama.Common;
using LLama;
using System.Globalization;
using System.Text;

namespace LLMRuntime;

public class LLMExecutor
{
    string ModelPath;
    double Temperature;
    int MaxTokens;
    int GPULayers;

    ModelParams Parameters;
    LLamaWeights Model;
    InteractiveExecutor Executor;

    public LLMExecutor(string modelPath, double temperature, int maxTokens, int gpuLayers)
    {
        ModelPath = modelPath;
        Temperature = temperature;
        MaxTokens = maxTokens;
        GPULayers = gpuLayers;

        Parameters = new ModelParams(modelPath)
        {
            ContextSize = 32768,
            GpuLayerCount = gpuLayers
        };
        Model = LLamaWeights.LoadFromFile(Parameters);
        Executor = new InteractiveExecutor(Model.CreateContext(Parameters));
    }

    public string ParsePrompt(ChatHistory chatHistory, string prompt)
    {
        void addMessage(AuthorRole role, string message)
        {
            if (role != AuthorRole.Unknown)
                chatHistory.AddMessage(role, message);
        }

        AuthorRole role = AuthorRole.Unknown;
        string message = "";

        foreach (string line in prompt.Split(new string[] { Environment.NewLine, "\n" }, StringSplitOptions.None))
        {
            string input = line.Trim();

            if (input.StartsWith("<|###"))
            {
                addMessage(role, message);

                message = "";

                if (input == "<|### System ###|>")
                    role = AuthorRole.System;
                else if (input == "<|### Assistant ###|>")
                    role = AuthorRole.Assistant;
                else if (input == "<|### User ###|>")
                    role = AuthorRole.User;
            }
            else
                message += (input + Environment.NewLine);
        }

        return (role == AuthorRole.User) ? message : "";
    }

    public async Task<string> AskAsync(string prompt)
    {
        // Add chat histories as prompt to tell AI how to act.
        var chatHistory = new ChatHistory();

        string userInput = ParsePrompt(chatHistory, prompt);

        ChatSession session = new(Executor, chatHistory);

        InferenceParams inferenceParams = new InferenceParams()
        {
            MaxTokens = MaxTokens,
            AntiPrompts = new List<string> { "User:" }
        };

        string result = "";

        await foreach (
            var text
            in session.ChatAsync(
                new ChatHistory.Message(AuthorRole.User, userInput),
                inferenceParams))
            result += text;

        return result;
    }

    public string Ask(string prompt)
    {

        return AskAsync(prompt).Result;
    }
}

static class Program
{
    static string WaitForPrompt(string fileName)
    {
        while (true)
        {
            if (File.Exists(fileName))
            {
                StreamReader promptStream = new StreamReader(fileName);

                string prompt = promptStream.ReadToEnd();

                promptStream.Close();

                File.Delete(fileName);

                return prompt;
            }

            Thread.Sleep(100);
        }
    }

    [STAThread]
    static void Main(string[] args)
    {
        Thread.CurrentThread.CurrentCulture = CultureInfo.CreateSpecificCulture("en-US");

        try
        {
            LLMExecutor executor = new LLMExecutor(args[2],
                                                   (args.Length > 3) ? Double.Parse(args[3]) : 0.5,
                                                   (args.Length > 4) ? int.Parse(args[4]) : 2048,
                                                   (args.Length > 5) ? int.Parse(args[5]) : 0);

            while (true)
            {
                string prompt = WaitForPrompt(args[0]);

                if (prompt.Trim() == "Exit")
                    break;

                try
                {
                    string answer = executor.Ask(prompt);
                    StreamWriter outStream = new StreamWriter(args[1], false, Encoding.Unicode);

                    outStream.Write(answer);
                    outStream.Flush();

                    outStream.Close();
                }
                catch (Exception e)
                {
                    StreamWriter outStream = new StreamWriter(args[1], false, Encoding.Unicode);

                    outStream.Write("Error");
                    outStream.Flush();

                    outStream.Close();
                }
            }
        }
        catch (Exception e)
        {
            System.Environment.Exit(1);
        }
    }
}

Environment & Configuration
See description...
Known Workarounds
Install Cuda

What is the error?

Hi, it is the same error, as described in issue #887 (opened just after mine report):
ggml_vulkan: Found 1 Vulkan devices:
Vulkan0: NVIDIA GeForce RTX 4080 (NVIDIA) | uma: 0 | fp16: 1 | warp size: 32
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Repeat 2 times:
at LLama.Native.SafeLlamaModelHandle.llama_load_model_from_file(System.String, LLama.Native.LLamaModelParams)
at LLama.Native.SafeLlamaModelHandle.LoadFromFile(System.String, LLama.Native.LLamaModelParams)
at LLama.LLamaWeights.LoadFromFile(LLama.Abstractions.IModelParams)
at LLMRuntime.LLMExecutor..ctor(System.String, Double, Int32, Int32)
at LLMRuntime.Program.Main(System.String[])

By the way, it is independent of the context size in the ModelParameters. I tried different values, Vulkan always crashes. CUDA is fine.

Seems like this is a llama.cpp issue, not a LLamaSharp issue.
Not sure why installing CUDA impacts it, though. Are you sure it was not a coincidence? It seems like the native library loader is correctly selecting the Vulkan backend and it's throwing an error on the llama.cpp side.

ah yes..I submitted an issue on llama.cpp after testing their binaries a few days ago, looks like upstream issue, I thought it was just problem with AMD but it looks like a general issue with the Vulkan backend

Seems like this is a llama.cpp issue, not a LLamaSharp issue.
Not sure why installing CUDA impacts it, though. Are you sure it was not a coincidence? It seems like the native library loader is correctly selecting the Vulkan backend and it's throwing an error on the llama.cpp side.

It may be that the installation of CUDA fixed it, because then CUDA is selected first and Vulkan is never touched. By the way, it fixes it only, if also the CUDA driver by Nvidia has been installed, otherwise CUDA is skipped and Vulkan is the next try. Seems reasonable...

I had this issue using Vulkan as well. I don't have GPU on that device but it would always crash.
Randomly, setting the GPULayer count = 1 got it running for me.
0 crashes, 2 crashes
Both with the same error you are reporting about an attempt to read/write to protected memory.
YMMV

it's problem of driver crash during device initialization, some external program get's hooked to vulkan driver, in my case it was Mirillis's Action! game recorder, after uninstalling it everything ran fine, return to my llama.cpp issue user 0cc4m guided me to fix


Examples of Converters

Good morning, could you please show me an example of how could I use jodatime in android for storing dates and times using requery?And could you lable this as Question, please.
Another suggestion, could you make a wiki page with all issues labeled Question? It will help a lot.

Sure the most asked questions will be added to a section of the wiki.
For time conversions you want to use the Converter API. For Jodatime the API is similar to the new Time API in Java 8. So you can look at the requery builtin converts that work on the Java 8 Time API, e.g. LocalDateTimeConverter as an example on how to do conversions.

Closing this for now, feel free to follow up with any additional questions.


Enable parsing JSON with newline postfix

another try :)
yes, the jackson parser allows white spaces. the null check allows a consistent exception handling, so it might have a value..

oops, i broke something :), well you know the request., i'll pull this back... someone also reported the issue
ty 4 the lib


could provide better error messages for programmer errors

The error messages produced by extsprintf could contain a lot more information, like the format string and which format character generated the error.  This would help people more quickly identify the problem, particularly when extsprintf is several layers of abstraction down (e.g., in the case of node-verror).  See node-verror#30 for an example.

All of the messages now include the complete format string, the conversion specifier with the problem, what character that conversion specifier was at, and of course a description of the problem.  As an example, this test program:
var sprintf = require('./lib/extsprintf').sprintf;
sprintf('%s');

used to produce:
$ node busted.js

/Users/dap/work/reference/joyent/node-extsprintf/lib/extsprintf.js:72
			throw (new Error('too few args to sprintf'));
			       ^
Error: too few args to sprintf
    at jsSprintf (/Users/dap/work/reference/joyent/node-extsprintf/lib/extsprintf.js:72:11)
    at Object.<anonymous> (/Users/dap/work/reference/joyent/node-extsprintf/busted.js:2:1)
...

and now it produces:
$ node busted.js

/Users/dap/work/node-extsprintf/lib/extsprintf.js:97
			throw (jsError(ofmt, convposn, curconv,
			       ^
Error: format string "%s": conversion specifier "%s" at character 1 has no matching argument (too few arguments passed)
    at jsError (/Users/dap/work/node-extsprintf/lib/extsprintf.js:173:10)
    at jsSprintf (/Users/dap/work/node-extsprintf/lib/extsprintf.js:97:11)
    at Object.<anonymous> (/Users/dap/work/node-extsprintf/busted.js:2:1)
...

Here are some other examples from the new test case for this:
test case: missing all arguments
    args:   []
    error:  first argument must be a format string
test case: missing argument for format specifier (first char and specifier)
    args:   ["%s"]
    error:  format string "%s": conversion specifier "%s" at character 1 has no matching argument (too few arguments passed)
test case: missing argument for format specifier (later in string)
    args:   ["hello %s world %13d","big"]
    error:  format string "hello %s world %13d": conversion specifier "%13d" at character 16 has no matching argument (too few arguments passed)
test case: printing null as string
    args:   ["%d cookies %3s",15,null]
    error:  format string "%d cookies %3s": conversion specifier "%3s" at character 12 attempted to print undefined or null as a string (argument 3 to sprintf)
test case: printing undefined as string
    args:   ["%d cookies %3s ah %d",15,null,7]
    error:  format string "%d cookies %3s ah %d": conversion specifier "%3s" at character 12 attempted to print undefined or null as a string (argument 3 to sprintf)
test case: unsupported format character
    args:   ["do not use %X",13]
    error:  format string "do not use %X": conversion specifier "%X" at character 12 is not supported
test case: unsupported flags
    args:   ["%#x",13]
    error:  format string "%#x": conversion specifier "%#x" at character 1 uses unsupported flags

In the context of node-verror, where this came up:
new VError('foo %s bar');

now produces:
/Users/dap/work/node-verror/node_modules/extsprintf/lib/extsprintf.js:97
			throw (jsError(ofmt, convposn, curconv,
			       ^
Error: format string "foo %s bar": conversion specifier "%s" at character 5 has no matching argument (too few arguments passed)

Patchset 2 is make prepush clean.

Review was here: https://cr.joyent.us/#/c/3012/


xdman: change description

Change the description according to its Github page (https://github.com/subhra74/xdm)

Relates to https://github.com/ScoopInstaller/Versions/pull/735

[X] I have read the Contributing Guide.

/verify


In termux on android it needs to be manually sourced

I've got the the same setup on ubuntu, debian and 2 termuxes. It works as expected on ubuntu and debian, but in termux i need to have 'alias sou="source ~/.oh-my-zsh/custom/plugins/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh" ' and "sou" in every tmux pane...

So you have a file that contains a line of the form alias sou="…"?  Delete from that line everything except the part within double quotes.

If that doesn't work, ask on the termux support channels.  Good luck.


Upgrade Opensearch and Opensearch Dashboards

[!warning]
This is a public repository, ensure not to disclose:

[x] personal data beyond what is necessary for interacting with this pull request, nor
[x] business confidential information, such as customer names.

What kind of PR is this?
Required: Mark one of the following that is applicable:

[ ] kind/feature
[x] kind/improvement
[ ] kind/deprecation
[ ] kind/documentation
[ ] kind/clean-up
[ ] kind/bug
[ ] kind/other

Optional: Mark one or more of the following that are applicable:

[!important]
Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

[ ] kind/admin-change
[ ] kind/dev-change
[ ] kind/security
[ ] kind/adr

What does this PR do / why do we need this PR?

Upgrades the Opensearch and Opensearch Dashboards charts to appVersion v2.12.0

Fixes #2028
Fixes #2029

Information to reviewers
Regarding this:
"Breaking: Requires an initial admin password to be setup starting from App Version OpenSearch 2.12.0. Refer this github issue: https://github.com/opensearch-project/security/issues/3622"
Double checked that both restoring from snapshots still works both using curl with the admin user/password from apps config and using the Dev Tools. Also haven't encountered any other issues after upgrading or a clean install of Opensearch.

Checklist

[x] Proper commit message prefix on all commits

Change checks:

[ ] The change is transparent
[ ] The change is disruptive
[ ] The change requires no migration steps
[x] The change requires migration steps
[ ] The change upgrades CRDs

Metrics checks:

[x] The metrics are still exposed and present in Grafana after the change
[x] The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
[ ] The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)

Logs checks:

[ ] The logs do not show any errors after the change

Pod Security Policy checks:

[ ] Any changed pod is covered by Pod Security Admission
[ ] Any changed pod is covered by Gatekeeper Pod Security Policies
[ ] The change does not cause any pods to be blocked by Pod Security Admission or Policies

Network Policy checks:

[ ] Any changed pod is covered by Network Policies
[x] The change does not cause any dropped packets in the NetworkPolicy Dashboard

Audit checks:

[ ] The change does not cause any unnecessary Kubernetes audit events
[ ] The change requires changes to Kubernetes audit policy

Falco checks:

[ ] The change does not cause any alerts to be generated by Falco

Bug checks:

[ ] The bug fix is covered by regression tests

Any of the end-to-end tests that need to be updated to be compatible with the new version of opensearch-dashboard?

I'll take some time to verify that today/tomorrow


A circle may take a list of three points instead of a radius.

Changelog / Overview

Motivation

A few people have mentioned wanting this feature in manim. This is my attempt to help them.
Explanation for Changes

Documentation of Circle
New Function

Testing Status

OS: Windows 10 Home (x64)
CPU: AMD Ryzen 5
The scene I tested with:
class CircleTest(Scene):
    def construct(self):
        self.add(NumberPlane())
        c = Circle(points=[DOWN,LEFT,RIGHT*2])
        self.add(c)

Further Comments

Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[ ] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

I know I am a bit late to this party, but I thought I'd leave my 2c nonetheless: I don't particularly like the design decision to add this to the constructor of Circle (although it is well-documented of course).
Personally, I feel that a static class method Circle.from_three_points(p1, p2, p3) would provide a cleaner (and more expressive) UI.
I don't request to change this implementation, but I am interested in what you and others think about this idea.

Personally, I feel that a static class method Circle.from_three_points(p1, p2, p3) would provide a cleaner (and more expressive) UI.

I agree. The current implementation feels a little odd to me since there are two completely different ways of creating a circle. Separating the radiusand the points methods with a static method would feel more natural imo (and make this mob that's supposed to be simple less confusing on first sight)

I actually was debating on implementing this in that way (as a method). To me, I see both as acceptable and just went on and implemented it this way instead (in the constructor).

If both variants are fine with you, then I think going for the static method would make more sense. Could you adapt this PR?

Sure! I'm on it


Fixed issue: Quality tests can not be created if the column names have spaces or special characters #7623

Describe your changes :

I worked on the fixing issue: Quality tests can not be created if the column names have spaces or special characters #7623
Closes #7623

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@ShaileshParmar11 just pushed some changes to the backend side that should fix the issue -- cc @open-metadata/backend  if someone could review the changes.
From the frontend side we should prevent users from naming tests with space or special characters -- this will throw and error otherwise (see screenshots).


Look into DB race condition in tests

Ever since adding the test for the seeding module, it has become possible in the tests for two beforeAll hooks to simultaneously create users tables and then when one tries to drop the users table, it fails because there is somehow two. It's a known problem in rethink that they don't plan on solving. We may be able to prevent it from happening.

So ominous


flaky STK test

• Failure [0.104 seconds]
Server Crypto Setup STK verification and creation [It] requires STK
/home/travis/gopath/src/github.com/lucas-clemente/quic-go/handshake/crypto_setup_server_test.go:709
  Expected
      <[]uint8 | len:185, cap:185>: [82, 69, 74, 0, 3, 0, 0, 0, 83, 84, 75, 0, 33, 0, 0, 0, 83, 86, 73, 68, 40, 0, 0, 0, 83, 67, 70, 71, 153, 0, 0, 0, 116, 111, 107, 101, 110, 32, 48, 25, 4, 17, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 1, 2, 3, 4, 2, 4, 89, 72, 229, 103, 113, 117, 105, 99, 45, 103, 111, 83, 67, 70, 71, 6, 0, 0, 0, 65, 69, 65, 68, 4, 0, 0, 0, 83, 67, 73, 68, 20, 0, 0, 0, 80, 85, 66, 83, 37, 0, 0, 0, 75, 69, 88, 83, 41, 0, 0, 0, 79, 66, 73, 84, 49, 0, 0, 0, 69, 88, 80, 89, 57, 0, 0, 0, 65, 69, 83, 71, 127, 234, 11, 153, 106, 84, 187, 223, 133, 107, 128, 239, 117, 41, 114, 161, 32, 0, 0, 105, 110, 105, 116, 105, 97, 108, 32, 112, 117, 98, 108, 105, 99, 67, 50, 53, 53, 191, 139, 242, 74, 98, 101, 155, 61, 255, 255, 255, 255, 255, 255, 255, 255]
  to contain substring
      <string>: token 0��YH�f
  /home/travis/gopath/src/github.com/lucas-clemente/quic-go/handshake/crypto_setup_server_test.go:708
  Full Stack Trace
  	/home/travis/gopath/src/github.com/onsi/gomega/internal/assertion/assertion.go:69 +0x233
  github.com/onsi/gomega/internal/assertion.(*Assertion).To(0x18cc25a0, 0x8574780, 0x18cc25c0, 0x0, 0x0, 0x0, 0x18cc25c0)
  	/home/travis/gopath/src/github.com/onsi/gomega/internal/assertion/assertion.go:35 +0x80
  github.com/lucas-clemente/quic-go/handshake.glob..func3.10.1()
  	/home/travis/gopath/src/github.com/lucas-clemente/quic-go/handshake/crypto_setup_server_test.go:708 +0x457
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0x18b33980, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	/home/travis/gopath/src/github.com/lucas-clemente/quic-go/handshake/handshake_suite_test.go:12 +0x57
  testing.tRunner(0x18a9ac00, 0x8443c40)
  	/home/travis/.gimme/versions/go1.7.5.linux.amd64/src/testing/testing.go:610 +0x8c
  created by testing.(*T).Run
  	/home/travis/.gimme/versions/go1.7.5.linux.amd64/src/testing/testing.go:646 +0x2a5

@lucas-clemente: You added the bug label. How do you know this is a bug (i.e. the fault of the non-test code)?

I didn't know that was how we defined the bug label – I use it as a category with the other options being feature or enhancement.

I'm beginning to believe we're seeing a bit flip here. I just ran the STK tests > 25000 times, and didn't see this. The Ginkgo output is pretty useless, because the output of ContainSubstring only makes sense for UTF-8 characters. We could think about implementing a new Gomega matcher though.

Closing after discussion as we couldn't reproduce it.


Feature: Add baseline support

I have a fix for this, only I can't push code. @Draveness , do you think you can give me access? Then I'll make the PR.
Thanks.

You can open a pull request to submit ur code
From Draveness
On 周三, 9月 30, 2015 at 02:58, Draveness/Typeset
<EMAIL_ADDRESS>wrote:
I have a fix for this, only I can't push code. @Draveness [https://github.com/Draveness] , do you think you can give me access? Then I'll make the PR.
Thanks.
—
Reply to this email directly or view it on GitHub [https://github.com/Draveness/Typeset/issues/10] .[https://github.com/notifications/beacon/AGMURwMELlYkv0J32OGwKObEfDOPPwK5ks5o2tbMgaJpZM4GF9TV.gif]


Don't seem to be getting result

Hi, I installed the package and I am trying to retrieve a Facebook public post meta data... I don't get an error and in the result I get back and empty object:

I tried this on the  client and server.
If I use the demo http://efounders.co/, it works fine.
Any ideas, pls?

Yes, I try too on my webpage and it doesnt work.

Can you give me the page that doesn't work so I can test

I added an example in the source and deployed it http://meta-extractor.meteor.com
It's possible that you don't get result because the package found nothing.
Give me the url that doesn't work and I'll check

For example https://www.libercar.com, that is my page.
I tried this package (https://atmospherejs.com/agarcia038/extract-metadata) and it works well. Maybe you can take a look at their code.

Ok, I just published a fix. Tell me if you see other pages that don't work

@Ouro17 hi, how did you used that agarcia038 package?

You first need to install the package using meteor add agarcia038:extract-metadata on your meteor project then on your client(on click event or something like that) just use :
Meteor.call('fetchMetadata', 'putHereYourUrl', function (error, result) {
if(error)
{
console.error(error);
}else
{
console.log(result);
//{name:'Page name',description:'Here's the metadata description',image:'img url'}
}
});
Remember to change 'putHereYourUrl' for your url.
It's easy ;)


[HOLD for payment 2023-07-12] [$1000] The URL displays "/new/task/undefined" for a second when click next button in edit title page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to FAB > Assign task
Enter the title, and description and click the next button
Click on the title to go to the edit title page
Click the next button

Expected Result:
The URL should always display "/new/task"
Actual Result:
The URL displays "/new/task/undefined" for a second
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.23-4
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screencast from 29-05-2023 11_45_42.webm
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685334649233899
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f9cbf27bced6bc84
Upwork Job ID:<PHONE_NUMBER>227827712
Last Price Increase: 2023-06-20

not overdue

Not overdue but @0xmiroslav mind taking a look this week at https://github.com/Expensify/App/issues/20307#issuecomment-1579462440

@MonilBhavsar I was auto-assigned to this issue by Melvin bot, but I belive you're already assigned to this issue (probably because of the recent process change)
anyway, I gonna unassign mysefl

Monil was out for a couple of days, just waiting for him to catch up

Thanks! Looking now...
Sorry for delay

Looks good to me 👍 Seems like we missed this during initial implementation

@dukenv0307 I cannot assign you to the issue as you never commented on this issue. Could you please comment on this issue so I can assign you. Also, next time if you could help us by posting the proposal by yourself rather than through applause, it will be great :) Thank you!

@0xmiroslav ready for your review

Need to complete checklist and issue payment before we close this

@muttmuure @MonilBhavsar 👋

Looking

@dukenv0307 offer sent
waiting on @0xmiroslav to aply

@0xmiroslav are we good to issue payment now?

Can we pay now?

Sounds good 👍
@muttmuure is ooo, but yes let's process payment for everyone else except one

@dukenv0307 apologies for the delay on this one - you have now been paid.

Please message me in Slack if you have any questions. Thanks!

Ah, OK. For sure

I'll apply a bonus on Upwork

Urgency and reporting bonus added


Math unavailable in µPython

Eg: cos,sin, abs, power

Math module unavailable in µPython implementation for the hepia light board.
Until the module is available, a some functions were re-implemented using basic mathematical operators.
trigonometric function are the notorious exception, that will remain un-implemented until the math module is available


Remove unused settings

The settings in the settings activity that aren't actually used should be removed to prevent confusion.
They could also be replaced with actual others settings, such as a default folder (esp for unprivileged users) option

Fixed in f99afad65d3b065b4a920a02df25f7ff6e4e72df


Allocation enquiry rest api

To be used by the dashboard (via zone/v2 controller api) or via the hv tool

@smorgrav this is getting stale? merge or close?

Hopefully something I'll continue on the next sprints some time.
fre. 29. sep. 2017 kl. 09:13 skrev Kristian Aune<EMAIL_ADDRESS>
@smorgrav https://github.com/smorgrav this is getting stale? merge or
close?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vespa-engine/vespa/pull/2904#issuecomment-333049613,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJmXvSqN2dp8GSbpotdQRPi0ljBNCQVyks5snJh7gaJpZM4OKSqS
.


Use template packaging and add deploy scripts

Use CloudFormation packaging feature to put all sub-stack templates on S3
Add deploy scripts that package and deploy each top-level stack
Add config template specifying what parameters need to be set
Update README accordingly

Thanks @tvogels01 for your detailed comments and bash lessons! I think I've addressed them all now.
You're right that part of the blog post is outdated now (or at least doesn't reference the improved deploy process) but hopefully the updated README is enough if anyone makes their way to this repo.


Telegram refactor chat handler

I refactored chat_handler and telegram_handler
Everything works. its clean. It is bug free. It is ready for merge.
I cleaned the code up and separated the data from telegram so chat_handler handles all of those duties.

Someone please review and approve this refactor.

👍


Drop support for old versions of futures and tokio

This drops support for old versions of futures and tokio (futures01, tokio01, tokio02, and tokio03 features).
If support for these traits is needed, use auto_enums 0.7 or create your own drive macro (derive_utils crate can help it).

bors r+

bors r+

I decided to revert this (https://github.com/taiki-e/auto_enums/pull/127).


Implement Display for geometries

fix https://github.com/georust/rust-wkt/issues/31
write some wkt

POINT EMPTY
POINT(..)
POINT Z(..)
POINT ZM(..)
LINESTRING EMPTY
LINESTRING(...)
POLYGON EMPTY
POLYGON (...)
MULTIPOINT EMPTY
MULTIPOINT (...)
MULTILINESTRING EMPTY
MULTILINESTRING (...)
MULTIPOLYGON EMPTY
MULTIPOLYGON (...)
GEOMETRYCOLLECTION EMPTY
GEOMETRYCOLLECTION (...)

I have not handled every case like MULTILINESTRING ZM but we can make an issue for that.
I don't know the exhaustive list of cases

bors r+