Test

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-e2e-pilot-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-pilot-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-e2e-pilot-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-pilot-no_auth

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-bookinfoTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

prow/daily-e2e-pilot-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-pilot-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-simpleTests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-simpleTests

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

prow/daily-e2e-pilot-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-mixer-no_auth.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

prow/daily-e2e-pilot-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-simpleTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-dashboard.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-e2e-dashboard

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

prow/daily-e2e-pilot-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-simpleTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-simpleTests

prow/daily-e2e-mixer-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-unit-tests.sh
65457532f8ab5c8b8f684d87128c3623ed0a7072
link
/test daily-unit-tests

prow/daily-e2e-pilot-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-simpleTests.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-simpleTests

prow/daily-e2e-mixer-no_auth.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
c7ba98ba273004e336ebcba4ac5fdd0649340316
link
/test daily-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/close
On Thu, Oct 4, 2018, 11:52 AM istio-bot<EMAIL_ADDRESS>wrote:

@sebastienvas https://github.com/sebastienvas: The following tests
failed, say /retest to rerun them all:
Test name Commit Details Rerun command
prow/daily-unit-tests.sh 6545753
https://github.com/istio-releases/daily-release/commit/65457532f8ab5c8b8f684d87128c3623ed0a7072
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-unit-tests/648/ /test
daily-unit-tests
prow/daily-e2e-pilot-no_auth.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-pilot-no_auth/313/ /test
daily-e2e-pilot-no_auth
prow/daily-e2e-bookinfoTests.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-bookinfoTests/324/ /test
daily-e2e-bookinfoTests
prow/daily-e2e-simpleTests.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-simpleTests/313/ /test
daily-e2e-simpleTests
prow/daily-e2e-mixer-no_auth.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-mixer-no_auth/320/ /test
daily-e2e-mixer-no_auth
prow/daily-e2e-dashboard.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-dashboard/312/ /test
daily-e2e-dashboard
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio-releases/daily-release/pull/1012#issuecomment-427130284,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ80Z_fF3Q1jTLXOp7pJws6_QtXZ0rcvks5uhljZgaJpZM4XIo91
.

@sebastienvas: Closing this PR.

In response to this:

/close
On Thu, Oct 4, 2018, 11:52 AM istio-bot<EMAIL_ADDRESS>wrote:

@sebastienvas https://github.com/sebastienvas: The following tests
failed, say /retest to rerun them all:
Test name Commit Details Rerun command
prow/daily-unit-tests.sh 6545753
https://github.com/istio-releases/daily-release/commit/65457532f8ab5c8b8f684d87128c3623ed0a7072
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-unit-tests/648/ /test
daily-unit-tests
prow/daily-e2e-pilot-no_auth.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-pilot-no_auth/313/ /test
daily-e2e-pilot-no_auth
prow/daily-e2e-bookinfoTests.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-bookinfoTests/324/ /test
daily-e2e-bookinfoTests
prow/daily-e2e-simpleTests.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-simpleTests/313/ /test
daily-e2e-simpleTests
prow/daily-e2e-mixer-no_auth.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-mixer-no_auth/320/ /test
daily-e2e-mixer-no_auth
prow/daily-e2e-dashboard.sh c7ba98b
https://github.com/istio-releases/daily-release/commit/c7ba98ba273004e336ebcba4ac5fdd0649340316
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio-releases_daily-release/1012/daily-e2e-dashboard/312/ /test
daily-e2e-dashboard
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio-releases/daily-release/pull/1012#issuecomment-427130284,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ80Z_fF3Q1jTLXOp7pJws6_QtXZ0rcvks5uhljZgaJpZM4XIo91
.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[Gui-v1] Generate Certificate - add association

as of version 0.7 of dojot it is necessary to make one more call to associate a certificate to a device
Calling "${HOST}:${PORT}/x509/v1/certificates" will return in json a key "certificateFingerprint".
We should add one more call  via PATCH "/x509/v1/certificates/${fingerprint}" subintuiting "${fingerprint}" by the value received in the key "certificateFingerprint" with the body "{ \"belongsTo\": {\"device\": \"${id}\" }}", where ${id} is the id of the device.


Options for scripting against aurae

I'd like to propose using bash (with an aurae cli similar to kubectl or buildah) or Deno to script against aurae instead of moving forward with the Rhai implementation. I am not heavily invested in bash or Deno per se, but I am not sure that Rhai's unique properties serve the project better than other more popular approaches to scripting against API's. In short, why is Rhai better than python, javascript, bash, etc? I tried to focus my thinking on who aurae users probably will be and how that theoretical persona would want to interact with the system. In addition, I am working on a system with some of the same goals as aurae currently, and I'm sure that project also biases my opinions about aurae.
Soooo, from the readme,

AuraeScript follows a similar client paradigm to Kubernetes kubectl command. However, unlike Kubernetes this is not a command line tool like kubectl.  The Aurae runtime projects supports many clients, and the easiest client to get started building with is AuraeScript.

Does it make sense that the easiest client to get started building with is a scripting language users probably aren't familiar with? As a sysadmin, I would much rather reach for bash to get started hacking. I think buildah serves as a great model to emulate (tool intro here). buildah replaces dockerfiles the same way auraescript is attempting to replace yaml for infra configuration. It should be simple to spin up an instance of aurae and configure it with a simple bash script or interactively from the terminal. Bash is the most intuitive answer for this. Moving past simplicity, power users can get pretty far with bash, awk, and a well maintained gnu-style cli such as kubectl or buildah before needing to reach for a beefier (and crucially, more complex to integrate and maintain) scripting language such as python, javascript, perl, or lua.
And speaking of lua, an even simpler question to ask than above is why Rhai instead of lua? I've fiddled with it a bit to mess with my neovim configuration, but I am far from an expert. From my outsider's perspective, lua seems like an active success story for small, embed-able languages.
If the scripting language is important to provide a platform for the aurae standard library, then Deno becomes a very compelling option. Deno markets itself as a v8 runtime that is secure, hackable, and embed-able.

The Deno global object (Deno.spawn, Deno.test, Deno.exit) can be modified to include runtime specific functionality. You can ship aurae users a full featured runtime & compiler to build their aurae scripts with.
Javscript & Typescript is a very popular with developers these days, and might help make maintainable infrastructure code understandable to more web developers.
Deno takes a lot of design inspiration from Go. In fact the standard library is loosely modeled after the Go stdlib. Using Deno gives us a lot of the upsides of using Go without some of the more prickly downsides (see bottom)

A Go Problemo

side note: when building docker we were struggling to provide flexibly replaceable extensions as Go had no support for dynamic loading of libraries. As Docker wanted to ship with "batteries included but changeable", we ended up with those CNI / CSI constructs, where core functionality was pushed to external processes with more or less nice interfaces.

if the language is meant to wrap around the gRPC API, then either a custom language or a gRPC-supported language are likely options.  ie, either auraescript as a custom wrapper around the gRPC client to reduce verbosity/improve readability or python/go/java(!) acting as a client directly.
i'm not sure bash or lua fits the bill unless there are gRPC client implementations i'm not aware of.
but the question of "why auraescript?" is a good one to probe.

i'm not sure bash or lua fits the bill unless there are gRPC client implementations i'm not aware of.

Sorry for not being clear - I'm proposing a cli similar to buildah, which has a goal of replacing dockerfiles with bash scripts. I'm basically saying that I don't see the need for auraescript because a gRPC API wrapper cli written in rust (or whatever) seems to do the job great and avoids a lot of complexity in maintaining a Rhai implementation.
If auraescript's intent was to heavily utilize the integration of the scripting language with aurae (such as Rhai's bespoke Rust integrations), then Deno seems a more compelling choice to me

@bpmooch do you believe these features are mutually exclusive? I am sold on entertaining something like Deno... I also think having a CLI like buildah where we can easily use it with bash also makes sense.
In other words... why not both?

@bpmooch would you be interested in starting a deno-based auraescript? or even a buildah style CLI tool? we can see which ones end up growing if we are interested in taking the "why not both" approach?

@krisnova back at keys after vacation, yea I'm interested in working on this. I'll try to get some notes into the architecture repo soonish

Hey @bpmooch we just had an interesting thought from @GANitak
What if we added Deno "on top" of the Rhai library?
We know we will need to build out an opinionated client in rust (something that looks for configuration files in a well known place and understands what an aurae socket is) as well as the basic client functions anyway.
Couldn't we just map the client functions directly into Deno as well? Or at least slowly move them over in the lib.rs file to Deno? Unsure if you have an approach in mind? I am open to whatever you want to do and am already convinced Deno is a good move for the project.
Basically I would like to be able to move forward with testing against the daemon right now, without blocking on the Deno work.

The work in https://github.com/aurae-runtime/aurae/pull/115 will close this issue as it will introduce Deno as the primary core for AuraeScript and make AuraeScript 100% compatible with TypeScript and JavaScript.
This was a fantastic idea.

Closing as of #120


Interceptor not seeing all headers

Hi, I am struggling with an issue in which not all response headers are visible to the response handler.  We have a large set of response headers that are not seeing at all:
this.httpInterceptor.response().addInterceptor((res, method) => {
        return res.do(r => {
          console.log('response interceptor:', r.headers);
          let userInfoHeader = r.headers.get(this.appConfig.RESPONSE_USER_HEADER_NAME);
          let sessionToken = r.headers.get(this.appConfig.RESPONSE_USER_HEADER_NAME);

In the snippet above, r.headers only contains two of the headers, while all of the headers show up in the network console (Chrome).  The ones that are not visible are CORS headers and some custom x-headers.  Any help would be greatly appreciated.

Hi, the library does only proxying over angular's http service so this is all that you have from the original response.
According to this issue you won't get those headers anyways via vanilla XHR API.
In short you have to specify exactly names of the headers you want have access to via access-control-expose-headers: 'name-of-expose-header'

That's for the quick response.  Turns out the answer was none of the above, something simple and obvious (in retrospect) and that had nothing to do with anything you or I or the commenters in the linked article thought of.

Hmm, interesting...
So what was that anyway? 😀

We needed hit a certain proxy, in short, in order to see the headers, and we configured the wrong hostname in order to receive those headers.  The HTML page itself returned those headers, but no AJAX calls went through the proxy, so we received no headers.  Just a simple and obvious mistake in retrospect.

Alright, I see now.
Glad you solved it.


More resources on CircleCI

The freely hosted Docker runners can now request more resources on CircleCI (4 CPUs & 8 GB of RAM) via
    resource_class: large

See https://circleci.com/docs/2.0/configuration-reference/#resourceclass
I already tried it in another repo and it seems to be working.
This could allow us to

render some of the currently excluded examples/tutorials,
parallelize more inside tutorials (n_jobs=X),
use more complex (and more "natural" instead of synthetic??) data in tutorials

cc @drammock @larsoner @sappelhoff @agramfort

See it in action here:
https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/3008/workflows/0a7c98e6-40d9-4e3a-a0f4-43107719fbb0/jobs/29102/resources

Are you sure they charged their OSS policy? This might be possible for mne-tools because we actually pay for the service nowadays, rather than being due to an OSS policy change at their end...
I agree we can change it if it helps with some examples, but we should really try to continue to keep example execution time and memory usage as low as possible. In this sense, our current resource class limit has actually served a useful purpose, preventing us from being lazy/wasteful sometimes. So if we do increase the resource class, we'll need to be more vigilant/conscious and do more manual checking of example resource use and code efficiency.

This might be possible for mne-tools because we actually pay for the service nowadays, rather than being due to an OSS policy change at their end...

Oh. Well. That's the most likely explanation then 😅


P88: missing highlight

clearTimeout(this.$root.$$applyAsyncId); <-- should be highlited
And concerning highlight color at all. I read the book on a laptop with not very good matrix, so sometimes it's hard to see the difference.

Fixed!
Thanks for the feedback on the highlights. Will see about it during final formatting.


Change points

Introduction of a ChangePoints kernel to allow the identification of regime changes in 1d functions or timeseries. Examples provided in the associated notebook. I would welcome feedback on the design, and whether this would be something useful to have in the core library.

Does anyone have a view on the value of this change?

Does anyone have a view on the value on this enhancement? Or have any proposed alterations? (@st-- ?)

I think it would be a nice addition - I'll try to take a closer look soon!

Does anyone have a view on the value on this enhancement? Or have any proposed alterations? (@st-- ?)

I think it would be a nice addition - I'll try to take a closer look soon!

Perfect, thanks!

I recommend  a couple of things to do:

Contribute directly to the GPflow 2.0 (develop-2.0). The GPflow 1.0 will be in the maintenance mode very soon, that means that all new features should go to the 2.0 not in 1.0. It is also less work for you. But, of course, it is up to you.
Focus only on pytest even for GPflow 1.0. The UnitTest deprecated in GPflow 2.0.

I recommend a couple of things to do:

Contribute directly to the GPflow 2.0 (develop-2.0). The GPflow 1.0 will be in the maintenance mode very soon, that means that all new features should go to the 2.0 not in 1.0. It is also less work for you. But, of course, it is up to you.
Focus only on pytest even for GPflow 1.0. The UnitTest deprecated in GPflow 2.0.

Thanks @awav, makes sense - I will address @frgsimpson's comments, port to develop-2.0, close this PR and raise a new one.


Image Writing from Python and C++ give different results

Description
Identical code (written in python & C++) results in different images being written to disk.
The python code writes an image to disk with Identity direction cosine, even though the image supplied to the write function has non-identity cosines.  The change occurs somewhere in itk::ImageBase::UpdateOutputInformation().
Steps to Reproduce
A self-contained environment creates a new virtual environment, builds ITK with python and C++ and runs both the C++ and python test cases from the same source builds is available in the tarball file.
TARBALL: https://github.com/BRAINSia/ITK/raw/debug-python-diffs/failure_case.tar.gz
Download the tarball and run the "do_test.sh" to build (on unix) a clean version of ITK that is instrumented to show the problem.
Expected behavior
Both the C++ and the python variations should produce identical images on disk.
Actual behavior
The python generated image has an identity direction cosine.
Reproducibility
Two different computers (both release and debug mode tested) for two different uses produced the same failures.
Versions
Latest ITK master branch
Environment
Ubuntu 20.04 linux.
Additional Information
Using the "ResampleInPlaceImageFilter".

@dzenanz I spent all day trying to debug this very weird python problem.  I'm hoping you can help shed some light on this failure.
The tarball should be self-contained, and should build and demonstrate the failure by running the do_test.sh script.

I can reproduce this on Windows, too, with my existing build of ITK.

Good news!  At least it is reproducible.   I was struggling to determine where execution diverges.  I could not figure out how to debug the c++ code called from python.

The way which worked for me before was to use Visual Studio, enable "Enable native code debugging" in Python project and then step into (F11) interesting code. However, this time VS doesn't step into rip.Update(). The only suspect I have is use of this->GraftOutput(m_OutputImage); in Modules\Core\Transform\include\itkResampleInPlaceImageFilter.hxx. @thewtex do you have ideas about what could be wrong?


Give<EMAIL_ADDRESS>access to GCP projects.

Owner?

Looped them in with an email. Will give access if they request it.


Helm charts not listed after pushing new chart

I followed these instructions to setup a private repository: https://www.arthurkoziel.com/private-helm-repo-with-gcs-and-github-actions/
I have successfully published a chart to my bucket and can verify the index.yaml file is updated and my the chart tarball is uploaded. However, adding the helm repo and attempting to list my chart fails, showing I have no charts in my repo. I have access to the bucket, verified via gsutil. Any ideas how to troubleshoot why no chart is being pulled?
I'm using Helm 3.3.4 and Helm-gcs 0.3.18
╭─ ~/src ──────────────────────────────────────────────────────────────
╰─ helm repo list
NAME          	URL
kedacore      	https://kedacore.github.io/charts
astronomer    	https://helm.astronomer.io
rimusz        	https://charts.rimusz.net
ory           	https://k8s.ory.sh/helm/charts
airflow-stable	https://airflow-helm.github.io/charts
datadog       	https://helm.datadoghq.com
jenkins       	https://charts.jenkins.io
nginx-stable  	https://helm.nginx.com/stable
jetstack      	https://charts.jetstack.io
ko-helm-charts	gs://my-bucket-helmcharts/charts
╭─ ~/src ───────────────────────────────────────────────────────────────
╰─ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rimusz" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "kedacore" chart repository
...Successfully got an update from the "airflow-stable" chart repository
...Successfully got an update from the "ory" chart repository
...Successfully got an update from the "nginx-stable" chart repository
...Successfully got an update from the "datadog" chart repository
...Successfully got an update from the "astronomer" chart repository
...Successfully got an update from the "jenkins" chart repository
...Successfully got an update from the "ko-helm-charts" chart repository
Update Complete. ⎈Happy Helming!⎈
╭─ ~/src ──────────────────────────────────────────────────────────────────
╰─ helm search repo ko-helm-charts
No results found
╭─ ~/src ───────────────────────────────────────────────────────────────────
╰─ gsutil ls gs://my-bucket-helmcharts
gs://my-bucket-helmcharts/charts/
╭─ ~/src ───────────────────────────────────────────────────────────────────
╰─ gsutil ls gs://my-bucket-helmcharts/charts
gs://my-bucket-helmcharts/charts/my_app-0.0.1-rc1.tgz
gs://my-bucket-helmcharts/charts/index.yaml
╭─ ~/src ────────────────────────────────────────────────────────────────────
╰─ gsutil cp gs://my-bucket-helmcharts/charts/index.yaml .
Copying gs://my-bucket-helmcharts/charts/index.yaml...
/ [1 files][  417.0 B/  417.0 B]
Operation completed over 1 objects/417.0 B.
╭─ ~/src ────────────────────────────────────────────────────────────────────
╰─ cat index.yaml
apiVersion: v1
entries:
  my_app:
  - apiVersion: v2
    appVersion: 0.1.0
    created: "2021-12-01T20:22:42.71819179Z"
    description: A Helm chart for Kubernetes
    digest: c69d3c8e1d2d538ffd7daw4f855d3d0d46bc0d3059fe780bb4a36c261393097111
    name: my_app
    type: application
    urls:
    - gs://my-bucket-helmcharts/charts/my_app-0.0.1-rc1.tgz
    version: 0.0.1-rc1
generated: "2021-12-01T20:22:42.71819409Z"

I'm seeing this bug too.

@caddac figured it out. Have you use --devel as dashes in sem names are considered development : https://github.com/helm/helm/issues/3009


add sccache to build-test.yml

sccache has builtin GitHub Actions cache support.  In my mind it can be way smarter than caching a directory this way.  I hadn't dug into it but it might be able to be a global cache instead of per-repository with lots of duplication.


Tell people where to find msi

Here: https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/install-azd?tabs=baremetal%2Cwindows
I don't see us telling the user where they can find the MSI.
Please include a link and give example gh download command.
Thx

Because our repo has multiple entities in our GH releases (azd and the vscode plugin) the gh release download command won't work unless you specify the tag directly (e.g. gh release download azure-dev-cli_0.5.0-beta.3 --pattern ...
If we didn't include the tag then in cases where the vscode extension is the most recent release then an MSI file will not be found.

https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/4094

@danieljurek this works
gh release download --repo azure/azure-dev --pattern='azd-windows-amd64.msi'

@danieljurek this works
gh release download --repo azure/azure-dev --pattern='azd-windows-amd64.msi'

Indeed, that does work at the moment because the most recently created release has a file which matches that pattern. When the latest release does not contain a matching file you'll get an error. Here's an example release of the vscode extension which doesn't have a file matching that pattern (we don't expect it to match in that case going forward): https://github.com/Azure/azure-dev/releases/tag/azure-dev-vscode_0.3.0
If we only had releases of the az CLI from our repo and had no release of the vscode extension then we could be confident that the command would work.

Thought we produce multiple artifacts from same repo. The installation and user workflows scenarios are distinct and optional. I believe this gh release download --repo azure/azure-dev --pattern='azd-windows-amd64.msi' should still be useful. Since,

Azd CLI as a standalone is self-contained and folks use it without VS/VSCode.
VS/VSCode is an integration aspect and has its own install procedure documented here - https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/debug?pivots=ide-vs-code.

ic, so because:

gh release download looks at most recent release
we ship vs code ext at a different cycle than the msi
the 'latest' release may not have an msi and the command would fail

The gh release download command does support the use of tags to get a download.
I'm wondering if we can find a creative way to use tags to get what we want...
For example:
If we always tag the latest msi release with 'msi-latest` and then use this command:
gh release download msi-latest --repo azure/azure-dev --pattern='azd-windows-amd64.msi'
Would that work?

Because gh release works off of releases and not tags, simply updating a tag does not get us back to a release in a single command.
> git tag latest-a 361e5501b32b5b8e0e276438c81808ff75bcf4e0
> git push origin --tags
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:danieljurek/hypothetical-multi-project-repo.git
 * [new tag]         latest-a -> latest-a
> gh release download latest-a --repo danieljurek/hypothetical-multi-project-repo --pattern "pattern-a.txt"
release not found

However, it looks like GitHub added the ability to set the latest release explicitly in October. If we use that feature, we can set the latest release to a CLI release and then the command without the tag does work.
> gh release download --repo danieljurek/hypothetical-multi-project-repo --pattern 'project-a.txt'

A couple of things need to happen to enable this:

All code which generates GitHub releases needs to ensure that the most recent CLI release is always marked latest
This only works for one product (i.e. the CLI and never the vscode extension or other future products from this repo)

I think these tradeoffs are reasonable at this point.

Opened an issue w/ GitHub CLI to discuss extending gh release download to include scenarios like this.
The docs are updated with a link to the GitHub releases:


Improve model performance

The decision tree having the performance is now improved 85%

The model performance is increased


Match proxyquire behavior for falsy / null stubs

Falsy is allowed
null is a module not found err

@thlorenz Will defer to you on how to version this. This behavior was never document on the pq-ify side.

LGTM we'll do a minor upgrade.


base

Train using 2048 context length, 0.15 masking probability and 3.0 mean span length, does not converge, not sure why.

Going to use default settings, 512 context length and same batch size as nanoT5.

done


Update react and react-dom to newest Version

As I saw react and react-dom is also on the outdated list.

Hey, @naufaldi Can I work on this issue? Plz, assign me this.


Update tests docs on how to run single module tasks incl. dependencies

Using the -am option will cause maven to build all dependencies

Closing this as there seem not to be any solution to avoid running tests of the dependency when using -am. Lets keep the docs as-is to run install upfront.


flash <IP_ADDRESS> and pepper-flash 19.

Updated flash and pepper-flash.
I notice that pepper flash has its sha256 check disabled. I'm not sure if that is good or not. But should we do the same for the flash, flash-player, and flash-player-debugger formulae since they are in the same situation?

No. What we should do is instead set pepper-flash with a full version and sha256.

Done. : )

Thank you.


ignore comments

There have been some cases where in a comment, the correct syntax is given for a module instantiation:
For example, the following code will be erroneously picked up as a module instantiation:
/*
fragment offset (0)
*/

In this case verilogtree will think there is a module named 'fragment' with instance name 'offset'. Need to ignore anything wrapped in comments -> /* ... */ and // blah

The regex strings I use to identify module declarations and module instantiations assume that following the beginning of a newline (^) there is only whitespace before the declaration/instantiation. Therefore, my code already ignores any single-line comment (//).
This ticket only has to watch out for the multi-line comment /*  */ over multiple lines.

Nested comments are a bit of a pain to have to deal with, for example:
/* comment
/* another comment

*/
*/

Maybe in the interest of keeping this simple I will just skip multi line comments for now, and just cop it. We ignore single line comments as-is so this is probably good enough for now...
Will move this to the v0.2.0 release instead

Moved back to v0.1.0 since after running verilogtree against some real-world verilog (https://github.com/alexforencich/verilog-i2c) it turns that false-positives are actually very common and need to be dealt with by ignoring multiline comments.


-Zbuild-std in a project that uses compiler_builtins produces error: multiple rlib candidates

Problem
I would really like to build https://github.com/saethlin/fls with -Zbuild-std but I get an error when I do:
error[E0465]: multiple rlib candidates for `compiler_builtins` found
  |
  = note: candidate #1: /tmp/fls/target/x86_64-unknown-linux-gnu/debug/deps/libcompiler_builtins-0aaf2effdc7e19f5.rlib
  = note: candidate #2: /tmp/fls/target/x86_64-unknown-linux-gnu/debug/deps/libcompiler_builtins-9294bddd5a5521a8.rlib

error: could not compile `fls` due to previous error

I have tried tweaking the version of fls's dependency on compiler_builtins and even adding the feature rustc-dep-of-std which I see alloc use I think. Doing so seems to change the hash embedded in the rlib name, but I haven't figured out how to make them line up. (of course this error shouldn't happen at all, but it would also be nice to have a hack around it)
Steps
Try to build fls with cargo +nightly b -Zbuild-std --target=x86_64-unknown-linux-gnu
Possible Solution(s)
No response
Notes
No response
Version
cargo 1.66.0-nightly (73ba3f35e 2022-09-18)
release: 1.66.0-nightly
commit-hash: 73ba3f35e0205844418260722c11602113179c4a
commit-date: 2022-09-18
host: x86_64-unknown-linux-gnu
libgit2: 1.5.0 (sys:0.15.0 vendored)
libcurl: 7.83.1-DEV (sys:0.4.55+curl-7.83.1 vendored ssl:OpenSSL/1.1.1q)
os: Arch Linux Rolling Release [64-bit]

Can you say more about why there is a dependency on compiler_builtins? Generally that shouldn't ever be used, as that is an internal detail of how the compiler and the standard library work, and there can only be one instance of it.

fls is a program that isn't linked against libc, but LLVM still emits calls to certain functions which compiler_intrinsics provides implementations of. I could copy+paste the implementations in compiler_intrinsics into my own crate, but it would be much nicer to have some code reuse.


Fix doctest for #4581

#4581 introduced doc test regression. This PR fixes it.

Duplicating with #5182.


A vkGetQueryPoolResults() stride of zero is probably not what you want?

While looking into another issue, I noticed this:
https://github.com/Ipotrick/Daxa/blob/b988e42202e296c3b393b6d0c84c9ad1aaf3aa8a/src/impl_timeline_query.cpp#L31
I don't think using stride=0 for vkGetQueryPoolResults() when count>1 is what you want since then the last result value written will go to slot zero and overwrite all the other results.

@MatejSakmary is looking into it.

I fixed the issue. Thank you for letting us know :)

Wow, that was quick. I wonder if line 29 is also wrong: count * sizeof(u64), for the size. Should this be count * sizeof(u64) * 2?

Principle Engineer at NVIDIA commenting on our library? Awesome.
Thank you for reviewing our code! You're right, that should be * 2. I'm surprised that the validation layers didn't catch these things, at least with a warning!! Matej is fixing it right now

Fixed, thank you again! Very surprised validation didn't complain at all...

Interesting note @pdaniell-nv, we tested after making the stride change you suggested, and somehow the whole array was still written out. I would guess that internally it's ignoring the size parameter, which can be done since it can just multiply stride * queryCount to get the size to write out. I would have guessed that validation checks whether the dataSize provided is big enough to fit stride * queryCount

What version of VVL are you using? I think the latest <IP_ADDRESS> should catch the size bug.
The reason I happened to be looking at this is because of another issue reported to me with Renderdoc and GTX 980. Running the "daxa_test_2_daxa_api_3_command_list" test in Renderdoc causes a device lost. I'm looking into that now, and it appears to be a driver bug.

Oh nvm VVL version 1.3.231 catch the error. I didn't see this because I didn't use vkconfig to properly enable the validation layers. I need to get into the habit of enabling them using vkconfig more...

What version of VVL are you using? I think the latest <IP_ADDRESS> should catch the dataSize bug.
The reason I happened to be looking at this is because of another issue reported to me with Renderdoc and GTX 980. Running the "daxa_test_2_daxa_api_3_command_list" test in Renderdoc causes a device lost. I'm looking into that now, and it appears to be a driver bug.

Is that bug related to device local host visible memory by any chance?

Is that bug related to device local host visible memory by any chance?

Yes it is.

Ah, thanks for taking a look at this!


Remove input component

Removed the Input component, which was unnecessary because it offered very little functionality/convenience for the extra API. Removed tests and references in the readme.

Coverage decreased (-0.08%) to 98.512% when pulling ceba6d8ee9a762c3c6376f37d832836249c506a1 on Remove-Input-Component into 208afbcd7314a2bb85cd880833e03aa3d7da2827 on master.

Coverage increased (+0.2%) to 98.808% when pulling be5c361d66dd3e9b95b798e00dcfab6b3c2eecca on Remove-Input-Component into 208afbcd7314a2bb85cd880833e03aa3d7da2827 on master.


copying backed AnnData overwrites backing file of the original object with new file

When copying a backed AnnData object, this is what happens:
In [3]: test = ad.read_h5ad("rna.h5ad", backed=True)

In [4]: test2 = test.copy("rna2.h5ad")

In [5]: test2.filename
Out[5]: PosixPath('rna2.h5ad')

In [6]: test.filename
Out[6]: PosixPath('rna2.h5ad')

I don't know if this is intended, but it's certainly counterintuitive. I'd be happy to take a stab at a PR to fix this if it is indeed a bug.

Yeah, that looks wrong. Thanks for the report!


Web support

New flag --wasm with some functionality:

WASM-specific implementation file
Acts as if --dart-decl-output is specified, fallback path is used if not supplied by user

See #315.

👀

This PR might have to be split soon to address the issue of shimming threads and ReceivePorts for web.

It's been a while, but there should be a better way to do this now. Here's a sneak peek.

Has that been implemented? Looking forward to it!

It's not merged yet, but it mainly revolves around spawning web workers.


[Databricks] Fix issue for using single notebook task launch without taskgroup

The latest Databricks Jobs API 2.1 offers a consistent response for
both single task and multi-task job run submit API which fixes the current
issue mentioned in the ticket.
The PR also adds an example DAG for running the DatabricksNotebookOperator
alone without the DatabricksWorkflowTaskGroup operator.
closes: #160

Like @tatiana said, once there are unit tests I'm glad to approve.

@dimberman I have added them now, please check.


Track DOP & CTFP in dbo.all_server_stable_info

Add following more metrics in dbo.all_server_stable_info -

[ ] DOP
[x] Instant File Initialization
[ ] CTFP
[ ] Has Memory Dumps

Instant File Initialization can be found in dbo.services_all_servers.


not saving prediction or model patch

Describe the issue
Hi I create a very simple repo and create an issue.
docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock \
  -v $(pwd)/keys.cfg:/app/keys.cfg \
  sweagent/swe-agent-run:latest \
  python run.py --image_name=sweagent/swe-agent:latest \
  --model_name azure:gpt4 \
  --data_path https://github.com/viciaky/test/issues/1 \
  --config_file config/default_from_url.yaml  --skip_existing=False

it showed the correct result but never save in prediction jsonl and model patch
Error:
INFO     Found submission:
INFO     Saved trajectory to trajectories/root/azure-gpt4__viciaky__test__default_from_url__t-0.00__p-0.95__c-3.00__install-1/viciaky__test-i1.traj
INFO     Saved predictions to trajectories/root/azure-gpt4__viciaky__test__default_from_url__t-0.00__p-0.95__c-3.00__install-1/all_preds.jsonl
Traceback (most recent call last):
File "/app/run.py", line 144, in main
save_patch(traj_dir, instance_id, info)
File "/app/run.py", line 271, in save_patch
patch_output_file.write_text(model_patch)
File "/usr/local/lib/python3.9/pathlib.py", line 1283, in write_text
raise TypeError('data must be str, not %s' %
TypeError: data must be str, not NoneType
WARNING  ❌ Failed on viciaky__test-i1: data must be str, not NoneType
Suggest an improvement to documentation
No response

I looked at .traj file
here is the info, and the "submission" is null. i am using azure gpt4 endpoint. is there any configuration i am missing here?
"info": {
    "exit_status": "submitted",
    "submission": null,
    "model_stats": {
      "total_cost": 0.11188000000000001,
      "instance_cost": 0.11188000000000001,
      "tokens_sent": 10273,
      "tokens_received": 305,
      "api_calls": 1
    }
  }

Thanks for the report, this was probably fixed in https://github.com/princeton-nlp/SWE-agent/pull/242. Let me know if switching to the latest version didn't solve this!

@klieret I'm using v0.4.0 and I seem to have the same kind of issue:
...
         Given the complexity of the issue and the lack of explicit latency handling in the examined files, it may be necessary to consult with the development team or documentation to understand how latency is currently managed for MIDI regions and to determine the best
         approach for implementing any required adjustments.

INFO     🎬 ACTION (primary)
         submit

INFO     Found submission:

INFO     Saved trajectory to trajectories/root/gpt4__issue__default__t-0.00__p-0.95__c-10.00__install-1/967ef2.traj
INFO     Saved predictions to trajectories/root/gpt4__issue__default__t-0.00__p-0.95__c-10.00__install-1/all_preds.jsonl
Traceback (most recent call last):
  File "/app/run.py", line 150, in main
    patch_path = save_patch(traj_dir, instance_id, info)
  File "/app/run.py", line 281, in save_patch
    patch_output_file.write_text(model_patch)
  File "/usr/local/lib/python3.9/pathlib.py", line 1283, in write_text
    raise TypeError('data must be str, not %s' %
TypeError: data must be str, not NoneType
WARNING  ❌ Failed on 967ef2: data must be str, not NoneType
INFO     Beginning environment shutdown...
INFO     Agent container stopped
INFO     Found image sweagent/swe-agent:latest with tags: ['sweagent/swe-agent:latest'], created: 2024-04-15T19:20:51.646667378Z for linux arm64.
DEBUG    Starting container with command: docker run -i --rm --name sweagent-swe-agent-latest-7e58b0d4a9 sweagent/swe-agent:latest /bin/bash -l -m
INFO     🌱 Environment Initialized

Could you send me the full ommand that you ran?
Also it looks like you're running from the swe-agent-run docker container, right? There's no v0.4.0 docker container yet, so I'm a bit confused.

In fact, on the latest swe-agent-run docker container line 150 also doesn't correspond to the one from the traceback you sent. I believe you might be running on an old container.

Oh! I'm new to Docker, so I didn't know there was a matching docker container version.
I seem to be using the latest version:
docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock -v ./:/app/studio -v /Users/maximedupre/Desktop/SWE-agent/keys.cfg:/app/keys.cfg -v /Users/maximedupre/Desktop/docker-volume:/app/trajectories/root sweagent/swe-agent-run:latest python run.py --image_name=sweagent/swe-agent:latest --model_name gpt4 --per_instance_cost_limit 10.00 --data_path studio/issue.md --repo_path studio --config_file config/default.yaml --skip_existing=False

Looks like we can close this? Thanks @klieret


Improve Dark Mode

Major improvements in new version 0.4.10. Still work left to do but closing this for now.


Go 1.16.6 and Go 1.15.14 are released

From the release announcement:

Hello gophers,
We have just released Go versions 1.16.6 and 1.15.14, minor point releases.
These minor releases include a security fix according to the new security policy (#44918).

crypto/tls clients can panic when provided a certificate of the wrong type for the negotiated parameters.
net/http clients performing HTTPS requests are also affected. The panic can be triggered by an attacker
in a privileged network position without access to the server certificate's private key, as long as a trusted
ECDSA or Ed25519 certificate for the server exists (or can be issued), or the client is configured with
Config.InsecureSkipVerify. Clients that disable all TLS_RSA cipher suites (that is, TLS 1.0–1.2 cipher
suites without ECDHE), as well as TLS 1.3-only clients, are unaffected.

This is issue #47143 and CVE-2021-34558. Thanks to Imre Rad for reporting this issue.
View the release notes for more information:
https://golang.org/doc/devel/release.html#go1.16.minor
You can download binary and source distributions from the Go web site:
https://golang.org/dl/
To compile from source using a Git clone, update to the release with
"git checkout go1.16.6" and build as usual.
Thanks to everyone who contributed to the releases.
Cheers,
Dmitri, Filippo, and Alex for the Go team

Two Dockerfiles to go:

/stable/build/alpine-x86/Dockerfile
/stable/build/alpine-x64/Dockerfile

Two Dockerfiles to go:

/stable/build/alpine-x86/Dockerfile
/stable/build/alpine-x64/Dockerfile

GH-363 was opened yesterday, then closed today when a stable upgrade match for the 1.16.5-alpine3.12 container image wasn't found. I thought this was another bug with Dependabot, but checking https://hub.docker.com/_/golang?tab=tags indicates that there isn't a Go 1.16.6 image based on the alpine3.12 container image.
These are the matches:

golang:1.16.6-alpine3.14
golang:1.16.6-alpine3.13
golang:1.16.6-alpine

Though Alpine Linux 3.12 is supported until 2022, it may be worth updating to 3.13 or even 3.14. The other option is to wait and see if a 1.16.6 release is made soon based on a 3.12 image. My guess is that it won't be.


Use canonical import path

Yay go!  Someone changed a canonical import path and broke consumers.  Awesome!  We have a transitive dep on this and go get is busted.

Thanks,
Do we even use this in any CoreOS projects anymore? Shouldn't this be merged/deprecated in favor of https://github.com/coreos/pkg/tree/master/capnslog ?

Can I get a merge on this?  I can't 'go get' skynds without it.
@philips

This code is certainly deprecated but no harm in merging. :)


Flex 2888 fix failing sss nightly tests

This pull request makes the build fail.

This pull request makes the build fail.

This pull request makes the build fail.

This pull request makes the build fail.

This pull request makes the build fail.


[538] Fix Download main branch coverage artifact

Context
Workflow failures: https://github.com/DFE-Digital/apply-for-teacher-training/runs/5568042847?check_suite_focus=true
Changes proposed in this pull request
The workflow name must be updated in the step
Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

 Fix coverage test


Pimple 1.0 Requirement

Currently, this requires a Pimple 1.*, thus blocking many other up-to-date packages from being installed that rely on Pimple 2 or 3.  If no code changes are needed, please update the packagist, otherwise I would really appreciate the tweak!

It will change in Silex 2.0 where Pimple 3 is required.
Pimple changed it way of registering services eg. share is implicit and therefor you cannot just use a newer Pimple version with Silex 1.x


search-guard-5 not on maven repository

ElasticSearch 5.0.0
Search Guard 5.0.0-8
When I try to run elasticsearch-plugin install I get the following error.
Full command: /usr/share/elasticsearch/bin/elasticsearch-plugin install -b com.floragunn:search-guard-5:5.0.0-8
Exception in thread "main" java.io.FileNotFoundException: https://repo1.maven.org/maven2/com/floragunn/search-guard-5/5.0.0-8/search-guard-5-5.0.0-8.zip
I checked repository and floragunn doesn't exist under com folder.

Because it's not released yet :-) Expect it by end of this week.

Thanks @floragunncom, looking forward to it.


Cleanup management apis branch

Hey @varvusc, do you know how should I serialize the iOS device token on my iOS project to send it to my asp.net core backend webapi that will create an installation for Azure Notification Hub on the backend?
I'm trying to do it this way,
public override async void RegisteredForRemoteNotifications(UIApplication application, NSData deviceToken)
        {
            if ( deviceToken == null) return;

            var deviceInstallation = new DeviceInstallation
            {
                InstallationId = installationId.Value.ToString(),
                Handle = deviceToken.GetBase64EncodedString(NSDataBase64EncodingOptions.None),
                Platform = NotificationPlatform.Apns
            };

            //... Here I post this deviceInstallation object using an HttpClient....
        }

However I'm receiving an error from the NotificationHubClient on the backend asp.net core api whe I try to call _hub.CreateOrUpdateInstallationAsync(installation);

@ederbond can you file an issue with this question?


Make it compatible with @editorjs/list

update Line 106  in the constructor:
        //this.data = data && Object.keys(data).length ? data : initialData;
        this.data = initialData;
        if(data && data.items && data.items.length > 0){
            this.data.style = data.style;
            const item0 = data.items[0];
            if(typeof item0 === "object")
                this.data.items = data.items;
            else { // compatible with @editorjs/list
                const items = [];
                data.items.forEach(di => {
                    items.push({
                        content: di,
                        items: []
                    });
                });
                this.data.items = items;
            }
        }

I'm not involved in development, but .. what is "compatible with"? You're suggesting a code change, but I don't understand the advantage of the code change.

I'm not involved in development, but .. what is "compatible with"? You're suggesting a code change, but I don't understand the advantage of the code change.

The key is the difference between @editorjs/list and editor-js/nested-list.
I have already used @editorjs/list in my website. So if I wanna support nested-list instead of @editorjs/list, I must make sure the editor can also display the old data (in @editorjs/list format) correctly.
The code above will upate the old data in @editorjs/list format to editor-js/nested-list format.

Well that sounds pretty useful.

As described in https://github.com/editor-js/nested-list/issues/75#issuecomment-2259775020, I take issue with this approach.
One clear advantage of a block-based format over plain (sanitized, white-listed) HTML, and indeed the reason we went for a block-based format, is that the data format is well-known and fairly limited, making it easier for other tools than editor.js itself to parse the content and format it for other contexts.
For example, our back-end converts editor.js documents for display in Excel cells (plain-text with simple "formatting" such as prepending bullet points with *), to extract the plain text only for search indexing, and rendering to PDF files.
This parsing becomes much more difficult if, for any given type discriminator, different incompatible schema are used. While it is possible to work with, we then have to drop down from a nice, strongly-typed deserialization-based API to a much more verbose and bug-prone JSON-token based API.


Add vsphere-iso Packer builder support

Hi!
I added the support for creating images on vSphere environments using Packer.
The existing build chain for ESXi uses the vmware-iso Packer builder which is not fully compatible with vCenter. Specifically, I encountered the following bugs while deploying:

The builder is not able to use virtual switches directly created by vCenter, but instead it creates new ones with the same name on the ESXi host, resulting in no network connectivity during build time
The guest additions (VMware tools) are not automatically installed when creating Windows images. This prevents Packer to retrieve the IP address of the VM since it does not get exposed through APIs without having the VMware tools installed, and therefore it prevents Packer to connect to the VM and execute additional commands after the boot phase.

To solve those issues I ported the Packer build configuration to the Packer builder vsphere-iso which is fully compatible with vCenter (Tested on the latest version of vCenter).
This PR contains the following new files:

ESXi/Packer/ubuntu2004_vsphere.json: vsphere-iso Packer config file for Ubuntu 20.04
ESXi/Packer/windows_10_vsphere.json: vsphere-iso Packer config file for Windows 10
ESXi/Packer/windows_10_vsphere.json: vsphere-iso Packer config file for Windows Server 2016
ESXi/Packer/variables_vsphere.json: variables used by the new config
Packer/answer_files/10_vsphere/Autounattend.xml: a modified version of the Autounaddend.xml that launches a script to install the VMware tools at boot time when a new Windows 10 image is created
Packer/answer_files/2016_vsphere/Autounattend.xml: a modified version of the Autounaddend.xml that launches a script to install the VMware tools at boot time when a new Windows Server 2016 image is created
Packer/scripts/vmtools.cmd: script that installs the VMware tools and launched by the Autounattend.xml files

The command that needs to be used to run Packer is the same as the one used when building the images for ESXi but changing the paths to the new configuration files (e.g., PACKER_CACHE_DIR=../../Packer/packer_cache packer build -var-file variables_vsphere.json ubuntu2004_vsphere.json)
Signed-off-by: Sebastiano Mariani<EMAIL_ADDRESS>

Hi @clong!
I had to add the 2 additional answer files because when deploying a Windows VM on vCenter the VMware Tools are not installed by default. Without VMware tools installed, the IP address of the VM is not correctly exposed through the APIs, and therefore Packet won't be able to get the IP and connect back to that VM and execute post-installation scripts.
In the 2 new answer files, I added the part to automatically install those tools. Specifically, those files are identical to DetectionLab//Packer/answer_files/10 and DetectionLab//Packer/answer_files/2016 respectively, except for the following part:
        <component name="Microsoft-Windows-Deployment" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS" xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
            <RunSynchronous>
                <RunSynchronousCommand wcm:action="add">
                    <Order>1</Order>
                    <!-- Install VMware Tools from windows.iso -->
                    <Path>a:\vmtools.cmd</Path>
                    <WillReboot>Always</WillReboot>
                </RunSynchronousCommand>
            </RunSynchronous>
        </component>

This part executes a custom script I wrote to install the VMware tools (which is mounted at boot time as a floppy_file in the Packer config)

Makes sense -- PR looks good, thank you!

Makes sense -- PR looks good, thank you!


Support filtering the repositories page list

Empty filter

Filtered view

@mattgraham what do you think?

Continued in #657


Link to option descriptions

Adding link to detailed descriptions of each rule level option in Select Type of Rules to Create page

I am a WDAC feature team member. Please approve this PR.

Docs Build status updates of commit dce4f35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/configci/Set-RuleOption.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@brbrahm Please change the target branch of the PR from live to master in order to proceed with the review. Thanks.

@dariomws306 @tseward
Peer review needed for this PR. Thanks.


Button demo fails

The first issue that needs to be solved before running the project. Steps to reproduce:

Clone the project
cd demos\button
GOOS=js GOARCH=wasm go build
mv button button.wasm
basic-http-server

Note: basic-http-server is a basic, unsecure http server that's great for local development (not production). You can get it if you have rust installed with cargo install basic-http-server. If you don't want to install rust or basic-http-server, any http server will do. An http server is needed to get around browser XSS security.
Open the browser, developer tools, see the following error:
panic: runtime error: invalid memory address or nil pointer dereference
wasm_exec.js:52 [signal 0xb code=0x0 addr=0x0 pc=0x0]
wasm_exec.js:52
wasm_exec.js:52 goroutine 1 [running]:
wasm_exec.js:52 github.com/vecty-material/material/icon.(*I).iconDetails(0x45e000)
wasm_exec.js:52 	C:/Users/User/workspace/material/icon/icon.go:72 +0x4
wasm_exec.js:52 github.com/vecty-material/material/icon.(*I).Render(0x45e000)
wasm_exec.js:52 	C:/Users/User/workspace/material/icon/icon.go:31 +0x1a
wasm_exec.js:52 github.com/hexops/vecty.renderComponent({0xa17258, 0x45e000}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1040 +0x39
wasm_exec.js:52 github.com/hexops/vecty.render({0x3bd50, 0x45e000}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1001 +0xa
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45d5e0, 0x467c00)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:422 +0x154
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcile(0x45d5e0, 0x0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:223 +0x49
wasm_exec.js:52 github.com/hexops/vecty.render({0x3bd00, 0x45d5e0}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:997 +0x6
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45ddc0, 0x468158)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:422 +0x154
wasm_exec.js:52 github.com/hexops/vecty.KeyedList.reconcile({0x45ddc0, {0x0, 0x0}}, 0x45d880, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:727 +0x33
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45d880, 0x468608)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:419 +0x14c
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcile(0x45d880, 0x0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:223 +0x49
wasm_exec.js:52 github.com/hexops/vecty.render({0x3bd00, 0x45d880}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:997 +0x6
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45dce0, 0x468b60)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:422 +0x154
wasm_exec.js:52 github.com/hexops/vecty.KeyedList.reconcile({0x45dce0, {0x0, 0x0}}, 0x45db20, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:727 +0x33
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45db20, 0x469010)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:419 +0x14c
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcile(0x45db20, 0x0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:223 +0x49
wasm_exec.js:52 github.com/hexops/vecty.render({0x3bd00, 0x45db20}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:997 +0x6
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45dc00, 0x469520)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:422 +0x154
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcile(0x45dc00, 0x0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:223 +0x49
wasm_exec.js:52 github.com/hexops/vecty.renderComponent({0xa15958, 0x434050}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1063 +0x4b
wasm_exec.js:52 github.com/hexops/vecty.render({0xa15990, 0x434050}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1001 +0xa
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcileChildren(0x45d500, 0x469bb0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:422 +0x154
wasm_exec.js:52 github.com/hexops/vecty.(*HTML).reconcile(0x45d500, 0x0)
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:223 +0x49
wasm_exec.js:52 github.com/hexops/vecty.renderComponent({0x3c308, 0x444040}, {0x0, 0x0})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1063 +0x4b
wasm_exec.js:52 github.com/hexops/vecty.renderIntoNode({0x2144c, 0xa}, {0x3ceb8, 0x40e0b0}, {0x3c308, 0x444040})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1238 +0xa
wasm_exec.js:52 github.com/hexops/vecty.RenderBody({0x3c308, 0x444040})
wasm_exec.js:52 	C:/Users/User/go/pkg/mod/github.com/hexops/vecty@v0.6.0/dom.go:1190 +0x1a
wasm_exec.js:52 main.main()
wasm_exec.js:52 	C:/Users/User/workspace/material/demos/button/button_demo.go:22 +0x3

The following is causing the crash because c.MDC is nil
func (c *I) iconDetails() (sizeClass string, isIconCode bool) {
	sizeClass = c.MDC.RootElement.Node().Get("SizePX").String()
...

c.MDC is set by Apply but Apply is not called before 'iconDetails'
func (c *I) Apply(h *vecty.HTML) {
	sizeClass, isIconCode := c.iconDetails()
	switch {
	case c.MDC == nil:
		c.MDC = &base.MDC{}
	}
...

From what I understand Apply is called when c is rendered.
...
	return elem.Italic(
		vecty.Markup(
			c,
			vecty.MarkupIf(rootMarkup != nil, *rootMarkup),
		),
		vecty.If(!isIconCode, vecty.Text(c.Name)),
	)
...

And that's as far as I have got.

Also there are other things that cause the button demo to crash.
I can get the demo to run if I comment out all the following:
...sections from Render
...
			&common.ToolbarHeader{
				Title:      "Buttons",
				Navigation: common.NavBack,
			},
...

...
					&formfield.FF{
						Label: "Disable buttons (excluding links)",
						Input: &checkbox.CB{
							Input: vecty.Markup(
								prop.ID("toggle-disabled"),
							),
							OnChange: func(thisCB *checkbox.CB, e *vecty.Event) {
								checked := e.Target.Get("checked").Bool()
								for _, b := range c.buttons {
									if b.Href != "" {
										continue
									}
									b.Disabled = checked
									vecty.Rerender(b)
								}
							},
						},
					},
...

... section from renderBtnFieldSet
...
					Icon: &icon.I{
						Name: "favorite",
					},
...

... line from button Render
...
	return elem.Button(
		vecty.Markup(
			c,
			//vecty.MarkupIf(rootMarkup != nil, *rootMarkup),
		),
		ico,
		base.RenderStoredChild(c.Label),
	)
...

Note: this code is taken from the following two repositories:
https://github.com/agamigo/vecty-material
https://github.com/agamigo/vecty
The code in this repository should essentially be the same, but combined into one repository. However, the principle difference is that the old code uses the gopherjs API, which is now deprecated (replaced with syscall/js).
You can see what the code was before:
https://github.com/agamigo/vecty-material/blob/master/icon/icon.go#L72
I think one mistake is c.MDC.RootElement should be replaced with c.RootElement. I'm not exactly clear how InternalObject worked, because it seems that it picked out RootElement which is magical.

I'm going to run through the demos and comment out stuff until each one works. I'll then open issues for each problem. See how much you can fix; I'll be busy tomorrow but might work on some stuff on Sunday.

In iconDetails() I tried sizeClass = c.RootElement.Node().Get("SizePX").String() but that didn't work either
But I got it to run by doing the following.
Commented out the following line from iconDetails()
...
	//sizeClass = c.MDC.RootElement.Node().Get("SizePX").String()
...

Then I had to comment out the following line from icon Render()
...
	return elem.Italic(
		vecty.Markup(
			c,
			//vecty.MarkupIf(rootMarkup != nil, *rootMarkup),
		),
		vecty.If(!isIconCode, vecty.Text(c.Name)),
	)
...

Leaving this line in
	//sizeClass = c.MDC.RootElement.Node().Get("SizePX").String()

Causes the following error
panic: runtime error: invalid memory address or nil pointer dereference wasm_exec.js:51:14
[signal 0xb code=0x0 addr=0x0 pc=0x0] wasm_exec.js:51:14
<empty string>

if you have time, see if you can get the other demos working. Also, we need formfield working because that's a major component.

Thanks for your help so far; much appreciated!

what is the purpose of the code under /material/material?

I have narrowed it down a bit. With these changes the button demo runs without commenting out any lines.
Here is what I have commented out to get it to run...
button Render()
...
	return elem.Button(
		vecty.Markup(
			c,
			//vecty.MarkupIf(rootMarkup != nil, *rootMarkup), //Comment this out and it runs
		),
		ico,
		base.RenderStoredChild(c.Label),
	)
...

formField Render()
...
	//inputID := applyer.FindID(c.Input) //Comment this out to get it to run
	return elem.Div(
		vecty.Markup(
			c,
		//vecty.MarkupIf(rootMarkup != nil, *rootMarkup), //Comment this out to get it to run
		),
		//c.Input,  //Comment this out to get it to run
		elem.Label(
			vecty.Markup(
			//vecty.MarkupIf(inputID != "", prop.For(inputID)), //Comment this out to get it to run
			),
			vecty.Text(c.Label),
		),
	)
...

icon Render()
...
	return elem.Italic(
		vecty.Markup(
			c,
			//vecty.MarkupIf(rootMarkup != nil, *rootMarkup), //Comment this out and it runs
		),
		vecty.If(!isIconCode, vecty.Text(c.Name)),
	)
...

icon iconDetails()
...
	//sizeClass = c.MDC.RootElement.Node().Get("SizePX").String() //Comment this out and it runs
	switch sizeClass {
...

To get the checkbox_demo to run I had to do the following...
checkbox_demo.go
...
func (c *checkboxDemoView) Render() vecty.ComponentOrHTML {
...
			elem.Section(
				vecty.Markup(
					vecty.Class("hero"),
				),
				//c.checkboxes[HERO_ID], // Comment this out to make it run
				elem.Label(
					vecty.Markup(
						prop.ID("hero-checkbox-label"),
						prop.For(HERO_ID),
					),
					vecty.Text("Checkbox"),
				),
			),
...

index.html
...
  <body>
    <script src="https://material-components-web.appspot.com/assets/material-components-web.js" async=""></script>
    <script> //  src="https://rawcdn.githack.com/golang/go/04d8d249600bf7b350454175c521e0c251785956/misc/wasm/wasm_exec.js"></script>
    <script src="https://......./wasm_exec.js"></script>
    <script>
      (async () => {
        const resp = await fetch('checkbox.wasm');
        if (!resp.ok) {
          const pre = document.createElement('pre');
          pre.innerText = await resp.text();
          document.body.appendChild(pre);
          return;
        }
        const src = await resp.arrayBuffer();
        const go = new Go();
        const result = await WebAssembly.instantiate(src, go.importObject);
        go.run(result.instance);
      })();
    </script>
  </body>
...


Update UseCases and NFRs of DeveloperGuide

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (c17d34b) compared to base (e3c4f9c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


switching to git directly for getting an event's diff

I've had an idea about switching to git directly for getting a push event's diff (and list of changed files). Maybe such feature would warrant v1.5.0 tag also.
I'm just not sure how use git to list a diff for a PR. Determining the head and base commits in that context seems non-trivial.
Originally posted by @2bndy5 in https://github.com/cpp-linter/cpp-linter/issues/1#issuecomment-1225379935

Do you want to get push event diff using git instead GitHub API? it's a good idea if we can use git directly, and support other Non-GitHub SCM like Bitbucket and GitLab easily. This can be considered after v1.5.0 is released.

posted by @shenxianpeng

Do you want to get push event diff using git instead GitHub API?

Yes. I've been playing around with this idea locally using git status. It is very possible for push events, but it isn't as easy for PR'd branches,

support other Non-GitHub SCM like Bitbucket and GitLab

That's the main intention. It would also allow better usage of the pkg in local dev env, namely the files-changed-only and lines-changed-only options. Although, I think it would only make sense to support push event's locally because PRs tend to be specific to the SCM host (ie GitHub, GitLab, etc)

Switching to git for getting event diff, I assume we need to git checkout all history, so it should have two problems

users must allow to checkout all history
if the repo is too big git checkout all history is impossible

Because adding comments or annotation also needs to call API, probably calling the API to get the event diff is still the best way.

users must allow to checkout all history

Only for PRs, but I haven't assessed the best way to address that event. This will be less of a problem in local dev context. If it is a problem, then we can try to use git to accommodate for shallow history.

if the repo is too big git checkout all history is impossible

I have rarely seen this occur. The only time that I had a problem during local checkout was when the repo itself was extremely large (like Google's Material Icons repo). Even then, the Github runner is better able to do a checkout of any repo hosted on Github with ease (likely because they share the same servers).

Because adding comments or annotation also needs to call API, probably calling the API to get the event diff is still the best way

thread-comments requires REST API. There's no way around that.
file-annotations currently does not require the REST API, but the code to do so is there and tested if we need to use the REST API.

Using git directly won't require a GITHUB_TOKEN supplied because the token is specific to the REST API. Again, I'm not sure how to address PR events using git only. I think I could get the head and base commits from the event payload of a PR event, then just use git dif <head>...<base>. This applies to the following options (only for private repos):

files-changed-only
lines-changed-only

I have rarely seen this occur.

For example, when I clone llvm-project and linux repos.
-sh-4.2$ time git clone git@github.com:llvm/llvm-project.git
Cloning into 'llvm-project'...
remote: Enumerating objects: 5005074, done.
remote: Counting objects: 100% (2813/2813), done.
remote: Compressing objects: 100% (485/485), done.
remote: Total 5005074 (delta 2509), reused 2441 (delta 2326), pack-reused 5002261
Receiving objects: 100% (5005074/5005074), 1.96 GiB | 51.08 MiB/s, done.
Resolving deltas: 100% (4098747/4098747), done.
Checking out files: 100% (119993/119993), done.

real    3m53.050s
user    5m40.690s
sys     0m32.289s

-sh-4.2$ time git clone git@github.com:torvalds/linux.git
Cloning into 'linux'...
remote: Enumerating objects: 8978158, done.
remote: Total 8978158 (delta 0), reused 0 (delta 0), pack-reused 8978158
Receiving objects: 100% (8978158/8978158), 3.71 GiB | 62.09 MiB/s, done.
Resolving deltas: 100% (7452118/7452118), done.
Checking out files: 100% (78011/78011), done.

real    5m23.826s
user    7m36.899s
sys     0m59.142s

-sh-4.2$ du -h --max-depth=1
3.6G    ./llvm-project
5.4G    ./linux

I also see some Git repos mixed code and binaries together (for some repos migrate from SVN to GIT), git clone with --depth 1 also needs 7GB, if clone all history, it will be 21 GB, so it will speed much more time than the above examples.
The main concern is we don't know how users use git, so checkout with all history will have performance issues and takes extreme space.
Also, supporting and maintaining other SCM's REST APIs might help us explore commercialization.

supporting and maintaining other SCM's REST APIs

I'm trying to avoid having to do this because I envision a "spaghetti code" solution (riddled with if blocks). If the SCM site's event payload is somewhat uniformed, then we might be able to do it easily. Currently, I'm constructing the REST API URLs manually in the code, but most of the REST API URLs I'm using should be available in the event payload's JSON (though I suspect the field's keys will vary depending on the SCM site used).
I don't think we should be held accountable for the size of the user's repo. The full history would only be required for PR events when using git.
This implementation depends on knowing how to get the diff (including filenames with paths relative to the repo's root) for the push/PR event. We may not need to use git in the CI runners, but it would help to use git locally when not using a CI runner. More importantly, I was hoping to stop needing the GITHUB_TOKEN (as objected to in cpp-linter/cpp-linter-action#55) because it could potentially compromise user security (in many ways).

Well, I'm rather inexperienced with using git directly, but I think I got it working on the use-git-directly branch. I've often preferred to use tools like gitkraken to do complex git commands because I always tend to mess things up when I use git manually in CLI.
I had some trouble with getting the diff in CI because the default for actions/checkout action is an extremely shallow history. Meaning that the reported diff was showing everything in the repo as a new file. I tried using
subprocess.run(["git", "fetch", "--depth=3"], check=True)

but that didn't seem to work. So, I had to set the depth using the action
      - uses: actions/checkout@v3
        with:
          fetch-depth: 3

I haven't added any unit tests to verify the integrity of the diff reported yet. And, there was some regex parsing error (specifically when getting the file name) when the depth was 1 (still don't know why)...
I think it would be safer to use git directly from a local machine (eg. during a pre-commit hook) which should allow using the lines-changed-only and files-changed-only options without needing the Github REST API.

As for compatibility with non-GitHub SCM, I'm not sure yet how we could abstract the REST API usage for others. I've been looking at GitLab's REST API, and the response schema is wildly different because the runners for GitLab are less "pre-configured". I still don't know how to get the JSON payload describing what event triggered the GitLab CI run.

Please don't close this.
I still have a branch for this but it seems to only work for local clones of a repo. In the CI, the depth needs to be >= 3 (not shallow).

I went with a different approach concerning get_list_of_changed_files()...

If executed on a CI runner, then get the diff format from REST API.
If executed from a local dev env, then use git status --verbose.

This should ensure that we are getting the "patch" from REST API calls. And, this allows the same diff parsing algorithm used for either CI env or local env. Essentially, this approach doesn't fully satisfy my original idea, but working with shallow checkouts in the CI has proved rather painful when using git directly in CI.
In the end, we should be able to now use --lines-changed-only ad --files-changed-only options from a local env. I still want to investigate how this will affect using cpp-linter as a pre-commit hook, but I'm optimistic since pre-commit temporarily stashes unstaged files (which should not show up in git status -v).

I just realized that by using the diff format from REST API, we will not be getting the blob_url field that we current use to download files when the user has not added the actions/checkout step. I guess I could manually assemble a link that would act as the blob_url field instead.

I just found out about pygit2. It is a python binding for the C library that git uses under the hood (called libgit2).
I'm currently working on changing the current solution for this issue (using git CLI) into using pygit2.
PS - I'm also implementing some improvements I discovered when experimenting with cpp_linter_dart, so stayed tuned for another PR.


fix extra json marshalling of error cases #12

Attempted fix for #12
It compiles, but I'm not sure how to test it.

Thanks! You can try loading the compiled binary with (pods/load-pod "./pod-babashka-fswatcher") and see https://github.com/babashka/pod-babashka-fswatcher/blob/main/test/script.clj as example. Then you should be able to hit it with your errors.

Thank!  I restarted my computer and can no longer reproduce the fs watcher errors, so i'm not sure how to test the error code paths.  I think if someone who knows golang can sanity check this commit, then it's probably no harm to merge.

Interesting, will find some time to review it!

@aiba could you send us the code that was crashing it? I'd wanna look into if its indeed a bug which needs addressing.

I would want to add it to the tests even if it doesn't crash it now, just to be extra sure!

I was able to reproduce and confirm that this PR fixes my issue.
Now the fs-watch handler function (in clojure) receives {:error "too many open files"} which was apparently the issue for me.
If you want to reproduce this, all you have to do is reach the open files limit on a watched directory.  (I'm still not sure how to artificially create this situation.  I seem to just wait for it to happen.)

Thanks, that is sufficient.


Create a simplified shell script for generating VASP identities.

Create a simplified shell script for generating VASP identities.

Closing this issue, because claim identities are not actual anymore. On the other hand tooling for VASP Contracts creation was added,


corrected the joern-parse command

joern-parse takes either "-o" or "--output" before the passing the filename argument and  "--out" returns an error.  :-) (It's a small one, but though was crucial)

@epicosy  please take a look . Thank you


adding butterflypack

Hi, I noticed that butterflypack has been a level 0 package since E4S Release 21.08. I'm adding it to DocPortal now.
I plan to make it a level 2 package real soon.

@maherou Mike, this PR has been opened for a while. Can someone take a look?


Register doctrine behavior

Hi,
Could someone explain how to add  Sluggable, Translatable, Timestampable, Loggable, Tree and Sortable behaviors in Silex?
I'm trying to achieve:
https://github.com/Atlantic18/DoctrineExtensions/blob/v2.4.x/doc/translatable.md#translation-entity
to have "page" table for non translatable part, and page_translations for translatable parts of a table.
Any help would be appreciated.

I found this Stackoverflow article helpful for this:
https://stackoverflow.com/questions/10676242/using-doctrine2-sluggable-extension-with-silex

I found this Stackoverflow article helpful for this:
https://stackoverflow.com/questions/10676242/using-doctrine2-sluggable-extension-with-silex

Tnx, but Silex is dead. Symfony 4 is basically what i was trying to achieve using silex.


【witness】inject one tikv failure for 10m, pitr task became to paused

Bug Report

What version of TiKV are you using?
./tikv-server -V
TiKV
Release Version:   6.6.0-alpha
Edition:           Community
Git Commit Hash:   c9cebe6cd44255018202d2e56023df096038bc09
Git Commit Branch: heads/refs/tags/v6.7.0-alpha
UTC Build Time:    2023-02-13 11:16:01
Rust Version:      rustc 1.67.0-nightly (96ddd32c4 2022-11-14)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
2023-02-14T06:23:02.448Z	INFO	k8s/client.go:132	it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
What operating system and CPU are you using?

Steps to reproduce
https://tcms.pingcap.net/dashboard/executions/plan/1562223
1、br restore data
2、enable witness
3、enable pitr
4、run tpcc run
5、inject one tikv failure for 10m
6、pitr task became to paused
What did you expect?
inject one tikv failure for 10m, pitr task should be normal
What did happened?
inject one tikv failure for 10m, pitr task became to paused

/type bug
/severity critical
/assign ethercflow


Build suitesparse from source

This adds feature flags for suitesparse_ldl_sys and suitesparse_camd_sys to build SuiteSparse from source and statically link it. This should be easily extendable to more components later on if more parts are wanted. We might want to add this feature flag to the sprs_suitesparse packages.
The build script for SuiteSparse reimplements the Makefiles, as these were hard to reuse, I've added CI which should ensure we won't break this.
The targeted version of SuiteSparse is v5.8.1, and parts of this will be uploaded to crates.io. This should be compatible with the licenses of the included components.

Another question: I guess you'll want to be the one uploading the suitesparse-src crate to crates.io?

Another question: I guess you'll want to be the one uploading the suitesparse-src crate to crates.io?

I don't really mind. You may add yourself as an author and publish. Might be easier if you are the owner of all sprs related material.

As far as I can tell these are not breaking changes for the CAMD stuff, but LDL requires a version bump since I've removed some version constants which were probably incorrect on some platforms and libraries.

I don't really mind. You may add yourself as an author and publish. Might be easier if you are the owner of all sprs related material.

Ok I'll do it that way then.

As far as I can tell these are not breaking changes for the CAMD stuff, but LDL requires a version bump since I've removed some version constants which were probably incorrect on some platforms and libraries.

Noted, I'll push the updated version soon.

Thanks for all the good work!


Allow Artisan causing errors when pawns try to craft wooden type floors.

If a pawn is set to disallow Artisan Crafting with the mod, they cannot craft any wooden floors, even though the floors should not be marked as "Artisan" since they don't have a quality level like a chair or table does.
When a pawn is set to not allow Artisan Crafting, it throws this error:
When trying to right click force work on floors:
https://git.io/fAFEW
Pic: https://i.imgur.com/crmUl6f.png
When pawn naturally tries to work on floors:
https://git.io/fAFEl
I'm not sure why, If I can provide more info or help in any way, please let me know. I'd love to use both these mods without having to allow all my workers to construct artisan structures.
These errors were generated when I had a ton of mods, but I got the same errors when I loaded only this mod and Hugslib:
When Force: https://git.io/fAFgL
When they try to build them naturally: https://git.io/fAFgq

Thank you for the report, fixed in v1.1.5


Fix minor typo

@yihezkel : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The typo fix looks good.
Publishing in this repository is suspended until Tuesday, September 22; merging will resume at 7 AM Pacific Tuesday.
This PR is ready to merge on 9/22.


Update the mappers to consume MEA from the new topics

With the new MQTT topic scheme, the mappers will have to consume messages from the te/#  and no more the tedge/#.
Once implemented the automatic conversion from the old to new topics, the c8y, az and aws mapper must be updated accordingly.

This has to done for measurements, events and alarms.
The payload of these messages is unchanged with an exception for the severity of an alarm (previously attached on the topic, now inside the message payload)
See this issue for the details.
For c8y, the auto-registration process must be adapted too. Hence, this task might depend on the implementation of an inventory / digital twin representation.

As first step, this task can address only auto registration using the te/device/+/service/+ scheme.
The inventory / digital twin representation can be used as a second step when available.

c8y-mapper specific topics info is here https://github.com/thin-edge/thin-edge.io/pull/2030/files?short_path=9695a2a#diff-9695a2a09b64f1cfa0ed7f9e9ff632abdc04a7fd3dc4c3849cf5b53a461e4add

Tasks:

[x] Measurements for c8y are consumed from te/+/+/+/+/m/+
[x] Measurements are published on te/+/+/+/+/m/+ by collectd mapper
[ ] Forward measurement type to c8y.
[ ] Events for c8y  are consumed from te/+/+/+/+/e/+
[ ] Alarms for c8y  are consumed from te/+/+/+/+/a/+
[ ] Azure mapper consumes MEA from te topics.
[ ] AWS mapper consumes MEA from te topics.
[ ] Health check and status for c8y on te/+ (here the topics have to be properly defined)

To be done only later:

[ ] Restart operation
[ ] Software List and Update operations


Logging help

Hi Aaron,
I'm trying to track down an issue after a site redirect where only a white screen displays.  Current log shows that it loaded the URL, but i'd really like to see what else is happening under the hood when the redirect fails.  Can you point me in a direction to debug properly?
Thanks!

Forgive me, just discovered the other thread :)


Module Structural Improvements & Testing

Have found great use as an adhoc tool for quick console helpers. Figured I'd try again after losing some changes and tests I tried to send you the first time (lost local repo).
This includes some testing framework and structure I've pulled from the fantastic PSFramework that includes analytics tests and more.
Would like to see if this seems an improvement, as MIT licensing also opens it up for easier reuse for me and others. Thanks for this cool tool. I plan on some future tweaks to add a banner title option and description of the selection etc, but figured I'd start with this request.

Using fantastic framework PSFramework, included some validation and analyzer checks.
Pester tests for variety for input and and return situations to validate functionality
Aligned with powershell naming conventions, but still provided alias output
licensing MIT mentioned again to allow easier use for various purposes.

This is a start at least. Did some testing and everything is working smoothly (not with strict mode , it's off). Will submit as pull request and see if these changes are accepted. If so, i think an updated  PSGallery build would be good to include in here as well.

Just following up to see if this came through to you? The license is esp crucial for many of us who have strict requirements on licensing, so I'm hoping that this addition will help improve for other who could then use. If you have any questions let me know! Cheers!

Any feedback? I know you've probably been busy but just wanted to see if you could take a few minutes and take a peek at the new structure I provided (using PSFramework)

Hi Sheldon,
Really sorry for late answer, but I had some time off. I'm checking it
right now.
Best regards
pon., 18 cze 2018 o 19:01 SheldonH<EMAIL_ADDRESS>napisał(a):

Any feedback? I know you've probably been busy but just wanted to see if
you could take a few minutes and take a peek at the new structure I
provided (using PSFramework)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chrisseroka/ps-menu/pull/3#issuecomment-398124320,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAahg3G7Cb0nurv5k26aTc_mMucGJxniks5t99zKgaJpZM4Ug40L
.

In general I must say that the code is much more complicated. I see the value of PSFramework but rather for bigger projects that this one.  I would prefer to keep it simple.

@chrisseroka  understood. Would you be ok with at least adding the MIT license, and I can just create a separate project to extend with some of the additional test methods, title, and framework stuff? If that's ok with you I could publish that separately, with attribution to you as original creator of course. Probably call it something like PSF-Menu or something similar but different.
Cool with you?
Thanks for your time!

Sure, that's OK. I will add MIT license with other changes, but you can
already create separate project
śr., 27 cze 2018 o 15:56 SheldonH<EMAIL_ADDRESS>napisał(a):

@chrisseroka https://github.com/chrisseroka understood. Would you be ok
with at least adding the MIT license, and I can just create a separate
project to extend with some of the additional test methods, title, and
framework stuff? If that's ok with you I could publish that separately,
with attribution to you as original creator of course. Probably call it
something like PSF-Menu or something similar but different.
Cool with you?
Thanks for your time!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chrisseroka/ps-menu/pull/3#issuecomment-400680526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAahgwuDppsdwLHo8rnu-RGpDyI0-Vsmks5uA472gaJpZM4Ug40L
.

Much appreciated! Thanks for the inspiration!


[Task] Flags for actions

This PR closes #113

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: