Leak in X509_verify_cert?

I get the leak below with the sanitizer. I've been double checking the code that I use for this and I do not see anything specific, any help appreciated if it is in my side. Looking at the trace I see some cache wording which might be the reason but not sure. The following link points to the part where I call the verify method. The interesting part is that this is not reported always and that it does not show up with valgrind.
https://gitlab.gnome.org/GNOME/glib-networking/blob/wip/nacho/openssl/tls/openssl/gtlsfiledatabase-openssl.c#L619
Direct leak of 64 byte(s) in 2 object(s) allocated from:
    #0 0x7efd6f381c48 in malloc (/lib64/libasan.so.5+0xeec48)
    #1 0x7efd68fd7fd7 in CRYPTO_malloc (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x63fd7)
    #2 0x7efd6905c96e in sk_new (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0xe896e)
    #3 0x7efd69088c4a in asn1_template_noexp_d2i (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x114c4a)
    #4 0x7efd69088d80 in asn1_template_ex_d2i (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x114d80)
    #5 0x7efd69088042 in ASN1_item_ex_d2i (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x114042)
    #6 0x7efd690888ca in ASN1_item_d2i (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x1148ca)
    #7 0x7efd690a8426 in X509V3_EXT_d2i (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x134426)
    #8 0x7efd690af423 in x509v3_cache_extensions.part.6 (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x13b423)
    #9 0x7efd690afa2f in X509_check_issued (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x13ba2f)
    #10 0x7efd6909e264 in check_issued (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x12a264)
    #11 0x7efd6909e4ea in get_issuer_sk (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x12a4ea)
    #12 0x7efd6909f913 in X509_verify_cert (/home/nacho/checkout/gnome/glib-networking/build/tls/openssl/../../../../../../../../opt/gnome/lib/libcrypto.so.1.0.0+0x12b913)
    #13 0x7efd695e5b41 in g_tls_file_database_openssl_verify_chain ../tls/openssl/gtlsfiledatabase-openssl.c:619
    #14 0x7efd6ef5f187 in g_tls_database_verify_chain ../../../../checkout/gnome/glib/gio/gtlsdatabase.c:525
    #15 0x7efd695dde64 in verify_peer_certificate ../tls/openssl/gtlsconnection-openssl.c:335
    #16 0x7efd695de28e in g_tls_connection_openssl_handshake ../tls/openssl/gtlsconnection-openssl.c:382
    #17 0x7efd695e06ee in g_tls_server_connection_openssl_handshake ../tls/openssl/gtlsserverconnection-openssl.c:156
    #18 0x7efd695ed837 in handshake_thread ../tls/base/gtlsconnection-base.c:788
    #19 0x7efd6ef54d9c in g_task_thread_pool_thread ../../../../checkout/gnome/glib/gio/gtask.c:1331
    #20 0x7efd6e991c29 in g_thread_pool_thread_proxy ../../../../checkout/gnome/glib/glib/gthreadpool.c:307
    #21 0x7efd6e99164f in g_thread_proxy ../../../../checkout/gnome/glib/glib/gthread.c:784
    #22 0x7efd6e6f0593 in start_thread (/lib64/libpthread.so.0+0x7593)
    #23 0x7efd6e423e6e in clone (/lib64/libc.so.6+0xf9e6e)

Nothing obvious springs to mind as to what could be causing this. Do you reuse the X509_STORE_CTX in any way across multiple calls to X509_verify_cert()?

I do not, the X509_STORE_CTX is created right above and freed right after:
https://gitlab.gnome.org/GNOME/glib-networking/blob/wip/nacho/openssl/tls/openssl/gtlsfiledatabase-openssl.c#L603 <- created
https://gitlab.gnome.org/GNOME/glib-networking/blob/wip/nacho/openssl/tls/openssl/gtlsfiledatabase-openssl.c#L622 <- freed

Any chance you can get line numbers in the stack above? It might help narrow things down.
I'm assuming you are using OpenSSL 1.0.2 right?
The original allocation seems to come via a call to x509v3_cache_extensions. That's defined here:
https://github.com/openssl/openssl/blob/5a6fbf616e1da3ac8c8bc6a30dbcd9844f6726c7/crypto/x509v3/v3_purp.c#L391
This function decodes various ASN.1 things from the cert and caches them in a more easily usable form inside the X509 object.
The first thing we do is check that we've not already cached this stuff:
https://github.com/openssl/openssl/blob/5a6fbf616e1da3ac8c8bc6a30dbcd9844f6726c7/crypto/x509v3/v3_purp.c#L401-L405
And then when we're finished caching things we set the flag to make sure we don't do this again:
https://github.com/openssl/openssl/blob/5a6fbf616e1da3ac8c8bc6a30dbcd9844f6726c7/crypto/x509v3/v3_purp.c#L541-L542
Things that spring to mind of things that could go wrong with this:

If the X509 cert doesn't get freed by the application then obviously anything we cache will get leaked (along with the cert itself)
If somehow the flag indicating that we've already cached data doesn't get set properly, or later gets reset, then we could end up attempting to cache the data a second time and overwrite what was already there (and hence leak it)
If somewhere else in the code we reset one of the cached values to a new value without freeing the old one

If we knew which particular cached value was causing the leak then that might (maybe) help narrow down which of the above it is. Line numbers on the stack would be very helpful for that (along with knowing which specific version of OpenSSL you are using).

This specific stack trace was taken from 1.0.1k but I also reproduced with the openssl version from fedora 28, 1.1.0.
I can rebuild my openssl with whatever version you prefer in order to try to get some more info.

Generally the later the version the better, so 1.1.1 or 1.1.0 would be ideal.

Here it is the trace with the same version as in fedora. 1.1.0h
Interestingly I just tested 1.1.0i and I do not get this leak anymore. I guess we can close this ticket but just pointing it out in case you want to double check.
Direct leak of 120 byte(s) in 3 object(s) allocated from:
    #0 0x7efca63e5c48 in malloc (/lib64/libasan.so.5+0xeec48)
    #1 0x7efca00033bb in CRYPTO_malloc crypto/mem.c:99
    #2 0x7efca00033ee in CRYPTO_zalloc crypto/mem.c:107
    #3 0x7efca0069851 in OPENSSL_sk_new crypto/stack/stack.c:108
    #4 0x7efca006982d in OPENSSL_sk_new_null crypto/stack/stack.c:101
    #5 0x7efc9ff0f705 in asn1_template_noexp_d2i crypto/asn1/tasn_dec.c:557
    #6 0x7efc9ff0f582 in asn1_template_ex_d2i crypto/asn1/tasn_dec.c:498
    #7 0x7efc9ff0e77e in asn1_item_embed_d2i crypto/asn1/tasn_dec.c:177
    #8 0x7efc9ff0e5c8 in ASN1_item_ex_d2i crypto/asn1/tasn_dec.c:123
    #9 0x7efc9ff0e55c in ASN1_item_d2i crypto/asn1/tasn_dec.c:113
    #10 0x7efca009da0b in X509V3_EXT_d2i crypto/x509v3/v3_lib.c:210
    #11 0x7efca009db64 in X509V3_get_d2i crypto/x509v3/v3_lib.c:269
    #12 0x7efca007bf14 in X509_get_ext_d2i crypto/x509/x509_ext.c:105
    #13 0x7efca00a249f in x509v3_cache_extensions crypto/x509v3/v3_purp.c:468
    #14 0x7efca00a2d2d in X509_check_issued crypto/x509v3/v3_purp.c:762
    #15 0x7efca0080d20 in check_issued crypto/x509/x509_vfy.c:333
    #16 0x7efca0080c98 in find_issuer crypto/x509/x509_vfy.c:317
    #17 0x7efca0080e02 in get_issuer_sk crypto/x509/x509_vfy.c:356
    #18 0x7efca0085ccb in get_issuer crypto/x509/x509_vfy.c:2876
    #19 0x7efca008604f in build_chain crypto/x509/x509_vfy.c:3011
    #20 0x7efca00808b1 in verify_chain crypto/x509/x509_vfy.c:216
    #21 0x7efca0080c1b in X509_verify_cert crypto/x509/x509_vfy.c:295
    #22 0x7efca05e4fd4 in g_tls_file_database_openssl_verify_chain ../tls/openssl/gtlsfiledatabase-openssl.c:619
    #23 0x7efca5fc3187 in g_tls_database_verify_chain ../../../../checkout/gnome/glib/gio/gtlsdatabase.c:525
    #24 0x7efca05dd1a8 in verify_peer_certificate ../tls/openssl/gtlsconnection-openssl.c:335
    #25 0x7efca05dd5d2 in g_tls_connection_openssl_handshake ../tls/openssl/gtlsconnection-openssl.c:382
    #26 0x7efca05dfa32 in g_tls_server_connection_openssl_handshake ../tls/openssl/gtlsserverconnection-openssl.c:156
    #27 0x7efca05eca6b in handshake_thread ../tls/base/gtlsconnection-base.c:788
    #28 0x7efca5fb8d9c in g_task_thread_pool_thread ../../../../checkout/gnome/glib/gio/gtask.c:1331
    #29 0x7efca59f5c29 in g_thread_pool_thread_proxy ../../../../checkout/gnome/glib/glib/gthreadpool.c:307

Probably this is #6121 which was fixed between those two releases. That has been fixed in both 1.1.0 and 1.0.2 so I think this should be closed.


[Feature request] Change behavior on session cancel

Currently, sessions that are cancelled while time is still left are counted towards daily stats. E.g. when the timer is cancelled when 10 mins is still left - it still increases the completed sessions counter.
While I can see the cases when this is desirable, I can also suggest scenarios where user would not want to count session as completed if the timer didn't reach 0. AFAIR, as per the original Pomodoro flow, the interrupted pomodoros should be "abandoned".
Looking through the issues I've found #181 that suggests this was the behavior in the previous versions.
What I want to suggest is adding a setting to control this - either a flag (e.g. "do not count interrupted sessions") or a threshold slider to specify when the session can be considered completed.

Similar to #234.


Add details about quotes in metadata

Addresses #528, copying text from the internal article.
Preview link

#sign-off


Cleaning and downward compatibility

Small cleaning of some warnings raised during tests:

Catch external objects extrapolation warnings in tests
Correct some deprecation warnings in Python 3.9 (Invalid escape sequence, np.float)

Make it possible to load external objects keeping missing values, this is needed for a library I will make public soon for doing quality check over external data of Vensim models. I added some "Downward compatibility" test in unit_test_external

Coverage increased (+0.02%) to 94.904% when pulling 82b283616efc6025f22d79c8f301b5a8e8c1bbd5 on enekomartinmartinez:cleaning_downward_compatibility into 7ff88f2aa471e4b67cf35e000176b5f642c3df04 on JamesPHoughton:master.

Hi @JamesPHoughton ,
I have made some extra change:

solve bugs with case sensitivity of sheet names with openpyxl (Vensim is not case sensitive while openpyxl is)
solve bugs when converting read data with openpyxl with strings and numbers (strings -> np.nan)
Add testing with Python 3.9 to the CI
If you can merge soon this PR will be nice, as I want to make public the new library for quality check of external data next Monday, otherwise, the continuous integration in the newrepository will fail.


Back navigation

Sometimes during browsing, it is useful to be able to navigate to a previous page. Currently it seems to be impossible.

@alex-dorokhov, Are you meaning me to navigate to the previous page by hotkey?

@jet8a, at least by a hotkey, yes.


Previous/Next Links are missing context

Problem
Another accessibility issue.
Link fails to be independently useful - WCAG 2.4.4 Link Purpose (In Context) (Level A)
Reproducible Project
https://docs.readthedocs.io/en/stable/guides/platform.html
Next
Expected Results
I'm not sure if you have a CSS class to hide content like many tools do, but essentially you want:
Next Page: Autobuild Documentation for Pull Requests

Would adding an aria-label here be sufficient? aria-label="Next Page"?

Well the problem is mostly that there is no context around Next. You could use aria-label, but ideally it would contain the title for the string. So aria-label="Next Page: Autobuild Documentation for Pull Requests" or  aria-label="Next Page: $title" if $title were a variable name for the title of the next article.
You're already doing essentially this for the title attribute to provide the hover effect. We just want the same affordance for assistive technology users.


Noty: Uncaught TypeError: Cannot read property 'options' of undefined

Hi there
When using the uncompressed version of Noty (I'm having to to debug another issue) I get the error:
Uncaught TypeError: Cannot read property 'options' of undefined

This is triggered by line 43 jquery.noty.js
this.options = $.extend({}, this.options, this.options.layout.options);

Further up $.noty.layouts is used to set the this.options.layout property... but $.noty.layouts is always empty.

I'm using an older version of jQuery, 1.7.1 but that wouldn't cause this error. I'm using Noty 2.3.7. Below are the options I'm using.
        n = noty({
            text: 'NOTY - a jquery notification library!',
            layout: 'topRight',
            timeout: 2000,
            theme: "relax",
            type: 'success',
            animation: {
                open: 'animated fadeInDown',
                close: 'animated fadeOutUp',
                easing: 'swing',
                speed: 1000
            }
        });

Any ideas?

This could be down to the fact that I'm using a really old version of jQuery and can't change that.

I get this too and I'm using v2.1.4

Same error here. Also using 2.1.4

Fixed it. I'm using bower. So I had to use noty/js/noty/packaged/jquery.noty.packaged.js instead of noty/js/noty/jquery.noty.js

@CreepGin yes , I'm useing requirejs ,use your way ,it works,thks!


When searching for a model on huggingface, the tag does not work, and the keyword is matched only by the model name.

The current problem is described in the title. I hope that the tag can be matched when searching in the future. In this way, the name of the model can be simplified and the tag can be richer.

cc @julien-c @gary149

excuse me？


Mapping for turtle lexer missing in lexers cache file

Hello,
Please update the lexers cache file to include a mapping for the turtle lexer.
Background: I'm writing an asciidoc document that contains source examples in Turtle (https://www.w3.org/TR/turtle/). Pygments supports highlighting for Turtle. However, when converting the document to html using asciidoctor (which uses pygments.rb) the Turtle examples are not highlighted. I've already filed an issue with asciidoctor, including an example, and it turned out that the missing mapping of the turtle lexer in pygments.rb was the cause. For details, see https://github.com/asciidoctor/asciidoctor/issues/2001 That issue is now closed, since a workaround is available. I created this issue so that the workaround will hopefully no longer be required after the next release of pygments.rb.

Done by #180


bug test: change index shard number in text chunking bwc test

Description
PLEASE DO NOT MERGE THIS PR!
This PR is only used to test the index creation bug according to index shard number.
Issues Resolved
Bug test
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The only difference for this PR from https://github.com/opensearch-project/neural-search/pull/661 is the index setting about shard number and replica.

pushed one commit to reopen this pull request

Closing this pull request because BWC test issue gets fixed.


android: header should be smaller in landscape mode

Short description of the problem:
Native Android applications have several layout optimizations that kick in once the application is in "landscape" mode. One of this examples, is how headers become smaller.
What behavior are you expecting?
I'm expecting landscape applications that follow MD to change the height of the header in accordance to native android applications.
Steps to reproduce:
This behavior can be seen in every native Android application, for example: Gmail, Contacts, Dropbox, just to name a few. Simply open the application and turn your phone. Tablets also benefit from this behavior.
Which Ionic Version? 1.x or 2.x
2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.36
Ionic App Lib Version: 2.0.0-beta.19
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v6.3.0
Xcode version: Xcode 7.3.1 Build version 7D1014

I think you mean 'landscape' FYI.

@daveshirman yeah, i fixed the description already.

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to driftyco/ionic-feature-requests#154


[Feature] 在数据量较大的前提下，期望同时兼容展示不同数据的散点图和折线图

What problem does this feature solve?
我理解这是xAxis的type设置为category造成的，但若将xAxis的type设置为value，折线图就变成了一条直线，达不到预期的效果。所以，才会有这需求：期望同时正确的展示不同数据的散点图和折线图。
What does the proposed API look like?
期望同时正确的展示不同数据的散点图和折线图。

There seems to be some issue with passing the data to axis but works if you use a dataset: Example


cclient/serializer/json:find_transactions - serialize response & deserialize request

This needs implementation, touches:
cclient/serializer/serializer.h
cclient/serializer/json/json_serializer.c
cclient/serializer/json/find_transactions.{c,h}
cclient/serializer/json/tests/find_transactions.c

fixed in #995


[Example] Dart - Adding an image as an overlay

Add an example as an executable script that adds an image as an overlay to an existing image in Dart.
You can start off by replicating this folder and example from Node:
https://github.com/cloudinary-community/cloudinary-examples/tree/main/examples/node-transformations-effects
Particularly the image-overlay.js file, but in Dart.

Hi I'd like to give this issue a try.

its all yours!


Set frame rate of video extracting

This value means how many image files generated per second.
To reduce the number of image files, the value must be less than
the video FPS.

This PR is trying to fix #194. To reduce the number of image files, this PR use frame rate value(FPS) Instead of using step value of frame.
@nmanovic , PTAL

nm/rest_api should replace develop very soon. Could you please submit your changes into nm/rest_api branch?

Let me clarify my vision for the feature:

Need several extra fields:

start frame. It should be 0 by default, >=0, less than stop frame. It will be good if you can specify it as frame number of as time
stop frame. It should be empty by default (corresponds to the end), >=0, more than start frame. It will be good if you can specify it as frame number of as time
step. It should be empty by default (corresponds to the minimum possible step), >0. It will be good if you can specify it as frame number of as time

Inside dump file you should have exact correspondence between the video file and dumped frames. For example, if you annotate only 1 frame from 30 frames you should be <frame000000>, <frame000029>, ... inside the annotation file.

As I said previously the patch should be submitted into nm/rest_api branch. It will be merged into develop branch very soon.

start frame. It should be 0 by default, >=0, less than stop frame. It will be good if you can specify it as frame number or as time

May be for unification the default value for start frame should be also empty.

One more important note. The same approach can work not only for a video file. It can work for a set of images or an archive. All these parameters above should be as a part of rest api and go to DB as well.

@zliang7 , should we expect a new patch for the issue or just close the PR?

@nmanovic , it's OK to close this PR. I will try to submit again after your restful api PR get merged. But before that, I need some time to understand your huge change to rebase/change this one.
I still have some questions about your thoughts. Instead of setup a meeting to discuss, I prefer to discuss in the issue page. So everyone can see it and join the discussion, since
cvat is an opensource project. Please see my question at #194

OK. Let's make one more iteration with the PR. I will close it for now.


Update ethnic_groups.html

Add section on 2001 Census groups.

@PanosParalakis I've emailed this to Rachel and Richard to check. Hopefully we can publish today. I'll let you know. 👍


Removes defer usage from TaskProcessor

This PR removes usage of defer.js from TaskProcessor (and related classes and specs).

Given that this PR doesn't actually address the defer pattern, we're closing this PR. We plan on fixing this when we revisit Resource.js.


Look Into Angular Material's Virtual Repeat For Performance

Virtual Repeat could increase our performance drastically, and comes included with angular Material:
https://material.angularjs.org/latest/demo/virtualRepeat
@julianpoy I'd love to hear your input on using virtual repeat

This requires very strange objects, a very specific container, and cannot be within another directive. We cannot use this sadly :'(


Caps Lock is ignored.

After an update, Caps Lock key stopped working. It produces no keycode. I have it set up as F19 to switch keyboard layouts.
Reinstalling and rebooting didn't help.

stopped working after update to 90.67

@max107 I'm seeing that exact same error in my logs right after the update to 90.67 as well

when I have updated to 0.90.67, the caps lock isn't working well any more...so I have to downgraded to the 0.90.64

@zealson Where i can get link to 90.64?

@tekezo where is can download 0.90.64 version?

Having the same Caps lock issue. Verified working when Karabiner unloaded. Just started with 67. Thanks!

I don't have any warning in log, but my Caps Lock also stop working after computer sleep.

Foud the working version here:
https://pqrs.org/osx/karabiner/files/Karabiner-Elements-0.90.64.dmg

MACOS Sierra 10.12.1 (16B2555) I have to force quit karabiner_grabber to get my caps lock to work. Equally interesting is that even using force quit none of the karabiner processes actually stop

Updated to the new version. Caps lock is now working again.

It's still not working,why close this issue,I've updated to 0.90.68, on macOS Sierra  10.12.1,the caps lock feature and LED all can't working normal again,I've to downgraded to 0.90.64 second time...

zealson, it's working for me, there is no issue now on my end, so it's closed. I also have the latest Sierra.

I'm sorry and don't know why I still be in this problem,today morning I saw your reply said it's caps lock is working,then I've updated it from 0.90.64 to 0.90.68,then I found it's not working,and the problem is always here,I also have rebooted my mac ,and caps lock feature and led can't working well with the lastest karabiner,  finally I have downgraded 0.90.64,OK,all things going on right way!

On 0.90.79 caps locks mapping doesn't work anymore. I have mapped to left-control but even so I works as caps lock.

Still not working for me on Sierra 0.90.92.
@Lerg are you sure this should be closed?

You can open a new issue. This should remain closed, because it's working for me, I won't be able to contribute to it.


Decide on iOS plotting library

Let's take a close look at one of these:
https://github.com/kevinzhow/PNChart-Swift
https://github.com/philackm/Scrollable-GraphView
https://github.com/i-schuetz/SwiftCharts
https://github.com/danielgindi/Charts

@tmcneely, what did you decide on?


Lag on android

The animations run smooth but if i try to change bottom tabs at all while the skeleton is running it takes like ~5 seconds sometimes. Any ideas?

For me i feel like first render component has a delay like 3 seconds and the animation start on android

Same for me too


Model export / import

Is your feature request related to a problem?
After using quite intensive Label Sleuth for a while in text classification projects that require consecutive generation evaluation of multiple models that suffer significant precision accuracy variation through model generations I realized that if I forget to export the model I was just finishing to evaluate and I step towards the next generation by using the "Label Next" workflow I will be never be able to export the evaluated model since the generation of a new one is already started. So, in a concrete case I "lost" a 90% precision model by not exporting it immediately after the evaluation process since all the consecutive models to that one dropped to 75-85% maximum.
So I propose a two-step enhancement process (if it's doable in a single software iteration even better):
What is the expected behavior?

Step one: Automatic model export at the end of a evaluation process. Once the "Submit" link is clicked the application should either directly or through a modal "Do you want to export the evaluated model? Yes / No" dialog export the model in the same format is exported through the left-frame "Download model" option BUT with a slightly enhancement to the model zip filename that describes the precision, instead the current format: model-category_Birds-version_1-27_1_2023.zip to model-category_Birds-version_1_70_pct_precision-27_1_2023.zip. In the first step it would suffice an automatic model export (without modal dialogue). Please see the attached mockup:

Second step: Model re-import. Continuing the above recommendation, once a high precision model was generated / evaluated / exported it makes sense IMHO to be able to import it in the workspace in order to attempt even further precision enhancement starting from the current one or to continue the labelling process using a different label category (in my case I am using multiple labels in the workspace). That would require a more complex development since from my analysis on the workspace-related files there are several places where json content should be modified in order to "return" to an older model generation. Apart from this (this is just my personal assumption, maybe I am wrong), the workspace configuration should fit the model, i.e., if the model was exported from a configuration using Naive Bayes over BOW it would make sense NOT to allow import in a workspace based on SVM Ensemble. Maybe checking the workspace id to be same in the current workspace and the imported zip file would be required. The user should be informed through a dialogue that he has to take the precaution that the workspace and the to-be-imported model should fitin terms of dataset / model algorithm.

Thank you
Radu

hi @credo99, thanks for reaching out and suggesting these improvements.
Adding a button in the precision evaluation screen sounds like a good idea and we will implement it soon.
As for the precision "drop" between models, note that the precision given by the system is merely an estimation based on 20 elements. For a better estimation, it's possible to increase the sample size for estimating precision using the system configuration .
As for 2, each category has its own model that improves as more labeled data is collected. So we are not sure we understand the use case for importing an older model to improve its quality further, can you elaborate more on the use case?

Hi again, I saw that another enhancement suggestion from martinscooper (https://github.com/label-sleuth/label-sleuth/issues/356) point somehow in the same direction of a future version of label-sleuth that would allow multilabelling, in case this (multilabelling) is on your roadmap please merge the ideas originating from our suggestions so that redundant functionalities should be avoided. Thanks

Hi, regarding the suggestions for multi-labeling, I would like to attach a brief functional requirements set and also some UI suggestions (that of course should be considered only as recomendations, the final implementation is totally under your guidance). These requirements come from my work in the last 5 years with multi-labelling (or multi-classification) tools / environments. I have not included in the requirements the option for loading datasets that are already human-labelled AND tagged as label-sleuth-labelled that would trigger an automatic model generation process from Label Sleuth (as per my email conversations with Yannis). I have kept the requirement for model version export after a new version is generated as per my previous request, it is even more important when one works with tens or hundred of labels and misses a manual export just after a new version is generated, otherwise one should have to wait a tremendous time after a subsequent model version is generated. Please tell me how to attach a pdf file here since I see only image or movie attachment options. Thank you

hi @credo99, I was under the impression that you can upload a pdf by dragging it to the comment box. If that doesn't work, another option is to send your document in the Slack workspace and continue the discussion there.
In any case perhaps it might be better to try and open issues for specific sets of suggestions/requirements as this would make it easier to discuss each issue / feature request separately.

Hi, I am ading here the requirements document, it contains basically a workflow description for multi-labeling. Thanks. Radu
Multilabel-Requierements.pdf


[WIP] [ExternalNode] Implement SupportBundleCollection on Controller

Add internal objects to sync the suport bundle collection request from
Controller to Agent.
Implement support bundle collection on Controlelr side.

Signed-off-by: wenyingd<EMAIL_ADDRESS>

/test-all
/test-ipv6-all
/test-windows-all

Seems that we also need to update pkg/apis/controlplane/v1beta2/conversion.go, like other internal objects?

Thanks for catching it, updated.

/test-all
/test-windows-all
/test-multicluster-e2e

/test-all

LGTM, typo in commit message: Controlelr

updated.

Update commit message only.

/test-all


Fixed typo

Changed "opposite directory" to "opposite direction"

@banzaisi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.
@banzaisi Thanks for submitting the fix.


Codestyle black

Start a conversation around adopting black for code style. This PR includes,

Run black against sanic module
Added black check in tox, black --check --verbose sanic

Codecov Report

Merging #1365 into master will decrease coverage by 0.05%.
The diff coverage is 82.83%.

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage    81.5%   81.44%   -0.06%
==========================================
  Files          17       17
  Lines        1692     1692
  Branches      321      321
==========================================
- Hits         1379     1378       -1
  Misses        246      246
- Partials       67       68       +1

Impacted Files
Coverage Δ

sanic/views.py
94.73% <ø> (ø)
:arrow_up:

sanic/reloader_helpers.py
15.9% <0%> (ø)
:arrow_up:

sanic/config.py
91.93% <100%> (ø)
:arrow_up:

sanic/worker.py
82.64% <100%> (ø)
:arrow_up:

sanic/testing.py
94.8% <100%> (ø)
:arrow_up:

sanic/log.py
100% <100%> (ø)
:arrow_up:

sanic/constants.py
100% <100%> (ø)
:arrow_up:

sanic/exceptions.py
95.06% <100%> (ø)
:arrow_up:

sanic/__init__.py
100% <100%> (ø)
:arrow_up:

sanic/helpers.py
92.3% <100%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619bb79...cd5bdec. Read the comment docs.

I am in favor of "uncompromising" consistency.

@yunstanford can't we add some more rules regarding isort and flake8, as mentioned by the black documentation itself? Also, I started a forum discussion regarding this some days ago, it might worth looking as well.

@vltr will take a look, thanks!

Thanks, @yunstanford !

@vltr i'm fine with isort, does it provide any check command like black ? or just always run isort against the repo ?
And also why do we want to ignore C901 ?

Oh, C901 I think is residual from my old days with Twisted, just ignore it (in the forums I put just a sample, not a solution for Sanic).
As for isort, it plays well with some editors, as black respects its rules. It can also be used as a command line check, exactly like black. Here's the command line I use inside my tox.ini files:
    isort --verbose --check-only --diff --recursive src tests setup.py


Missing toFront() / .toBack()

element.toFront(), element.toBack() and paper.top from Raphael have no obvious correspondent in Snap.
They are useful util methods. An workaround with attr() and z-index may work, but built-in methods to handle this would be very welcome.

thanks Dimitry, your method works!

Hi!
I've tried toFront and toBack and it did not work for me. Below is my minimal example where I would like that when cursor is going over a box it scales it and brings it to the front. Any idea ?
var s = Snap('#test');
var  g = s.g(s.rect(50,50,150,50).attr({fill:'blue'}),
	 s.text(75,80, 'Hello World'));
g.hover(enter_box, leave_box);

var  g = s.g(s.rect(70,60,150,60).attr({fill:'green'}),
	 s.text(80,90, 'How good is Snap!'));
g.hover(enter_box, leave_box);
function enter_box() {
var bbr = this.getBBox();
this.animate({transform: (new Snap.Matrix()).scale(2, 2, bbr.cx, bbr.cy)}, 100);
}
function leave_box() {
this.animate({transform: 's1'},100);
}

Decade late here, but remixing Dmitry's answer to account for groups.  If an element is already in a group, it should be sent to back / front only in its group, not broken out into the svg.
Snap.plugin(function (Snap, Element, Paper, glob) {
    var elproto = Element.prototype;
    elproto.toFront = function() {
        if( this.parent().type == "g" ) {
            this.appendTo(this.parent());
        } else {
            this.appendTo(this.paper);
        }
        return( this );
    };
    elproto.toBack = function() {
        if( this.parent().type == "g" ) {
            this.prependTo(this.parent());
        } else {
            this.prependTo(this.paper);
        }
        return( this );
    };
});


picture environment

Any chance of katex supporting the picture environment in the foreseeable future.

That's kind of cool.  I don't think we'll support this in the short term.  I'd like us to have a feasible way developing this an extension as opposed to doing in directly in KaTeX proper.  The rationale being that this feature will probably increase KaTeX's size considerably, but probably won't be used by very many people.

Agreed, this would be a cool extension! But it would likely big, so would make sense as one. (And it would probably need a champion to make it happen, as it's probably quite a bit of work.)

Note \includegraphics has been added in #1620.

This should probably be part of contrib.  I think this could be split up into multiple PRs:

add support for parsing things like (2,3)
add basic support for \begin{picture}
add support for \put and one basic command, maybe \line
add the rest of the commands, \circle, \oval, etc.

In principle, #2085's delimiter parsing should make parsing things like (2,3) relatively easy (though I haven't looked at it closely enough to be sure). \def\put(#1,#2)#3...


buildah: 1.11.6 -> 1.12.0

Motivation for this change
Changelog: https://github.com/containers/buildah/releases/tag/v1.12.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

looks like i got my PRs mixed up, sorry :)


https certificate currently fails for mobile devices

Above was tested on Android
Chrome 42.0.2311.111
Android 5.1.0
Also tested on iPad safari but don't have the version information for that now.

Man, it turns out the internet actually is quite helpful about this issue. This should be resolved now. I tested it on iPhone Safari, which used to give me trouble. Could you double-check on Android? Apparently that's the most demanding of the bunch.

Works great now!


Nothing happens when trying to run python inputs on Mac

I am using a MacBook Pro (Retina, 13-inch, Early 2015) with OSx 10.11.3
I installed script and run atom from terminal (with sudo just to be sure that wasn't the problem) but I can't get python files to run.
I tried with php and it works fine.
I do have python installed on my Mac.
I searched though the issues but I can't find anyone having the same problem.
EDIT: I just realised that all the files i tried so far have and input in them. Without input works fine.

Link to #743

I'm having the same issue! Please help!


PLT-1219 Remove offchain logic for MustProduceAtLeast and MustSpendAtLeast

Offchain use of MustProduceAtLeast and MustSpendAtLeast now checks if we have produced/spent at least the given amount when we create the Tx, and throw an error if it isn't the case. (see PLT-665 for the rationale behind this change)

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[ ] Reference the ADR in the PR and reference the PR in the ADR (if revelant)
[x] Reviewer requested

Given my Address PR, I'm all for removing slOwnPaymentPubKeyHash and slOwnStakingCredential.

It's great to see synergies on apparently disconnected PR :)


[Operator] Why not using appVersion for collectorImage as well?

Hello,
I noticed that currently .Chart.AppVersion is the default value for the opentelemetry-operator.image
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/templates/_helpers.tpl#L150
Keeping in mind that the operator and the collector should have the same version https://github.com/open-telemetry/opentelemetry-operator?tab=readme-ov-file#opentelemetry-operator-vs-opentelemetry-collector.
Why not using appVersion as default for collectorImage as well?
Or simply why the values.yaml has the collector image set?
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/values.yaml#L45
If I'm not wrong, if we don't set the  --collector-image flag https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/templates/deployment.yaml#L51
The operator will take care of deploying a collector with the same version as itself, isn't it? So why is needed to set a value for the collector by default?

The operator will take care of deploying a collector with the same version as itself, isn't it? So why is needed to set a value for the collector by default?

I'd rather do this instead of reuse appVersion.

The operator will take care of deploying a collector with the same version as itself, isn't it? So why is needed to set a value for the collector by default?

I'd rather do this instead of reuse appVersion.

Yeah, probably it makes more sense. So there is no reason to have a default value in the values.yaml, right? Do you agree to delete the default value?

Yes I think that is a safe, un-breaking change that will make operator upgrades easier

I'm going to check if the operator works as expected in case of not using the flag --collector-image

I'm going to check if the operator works as expected in case of not using the flag --collector-image

Seems that it works as expected, I deployed the operator setting an empty tag:
collectorImage:
    repository: ghcr.io/otel/opentelemetry-collector-contrib
    tag: ""

(k8s|kind-kind:otel-test) ~/Projects/Personal/opentelemetry-helm-charts/charts/opentelemetry-operator: k describe pod simplest-collector-54bb659675-m7jfg | grep Image
    Image:         ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector:0.99.0
    Image ID:      ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector@sha256:bba8474ea69d11f0450e38c50040efea47f4190723a9fb64cc9d44939b4ade4c

Oh, I was not aware of this https://github.com/open-telemetry/opentelemetry-helm-charts/issues/1153.

Taking into account the https://github.com/open-telemetry/opentelemetry-helm-charts/issues/1153 I tried with  --collector-image=ghcr.io/otel/opentelemetry-collector-contrib rather than  --collector-image=ghcr.io/otel/opentelemetry-collector-contrib:0.99.0 and it doesn't work, so I proceed with closing the issue.

Taking into account the https://github.com/open-telemetry/opentelemetry-helm-charts/issues/1153 I tried with --collector-image=ghcr.io/otel/opentelemetry-collector-contrib rather than --collector-image=ghcr.io/otel/opentelemetry-collector-contrib:0.99.0 and it doesn't work, so I proceed with closing the issue.

Taking into account the https://github.com/open-telemetry/opentelemetry-helm-charts/issues/1153 I tried with --collector-image=ghcr.io/otel/opentelemetry-collector-contrib rather than --collector-image=ghcr.io/otel/opentelemetry-collector-contrib:0.99.0 and it doesn't work, so I proceed with closing the issue.

I noticed that I was using a wrong collector URL to test the flag. I used ghcr.io/otel/opentelemetry-collector-contrib rather than otel/opentelemetry-collector or otel/opentelemetry-collector-contrib. Now it works properly. So I think it is safe to delete the tag version.


cleanup: remove istio_authn generator

Change-Id: Ibd951922e020110cc5f7cd25bfa10202c7b9bbbc
The code for istio_authn has been gone since 1.21.

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cdcd2887bbd4bc5f1fb5fc6661a78ab5d76afe8d
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cdcd2887bbd4bc5f1fb5fc6661a78ab5d76afe8d
link
true
/test lint

release-notes_istio
cdcd2887bbd4bc5f1fb5fc6661a78ab5d76afe8d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Golang wrapper for timezone lookup

Thanks for compiling this data, it has been really useful.
I am using it on a project written in Golang, the source of the timezone lookup API is at: https://github.com/evanoberholster/timezoneLookup
Feel free to add it to the list of libraries if it will be useful.
Cheers!

I've done something similar for my needs https://github.com/ugjka/go-tz


Cannot install nvim-web-devicons properly on Nvim 0.7.2

I try to install nvim-web-devicons using Packer on Nvim 0.7.2 (cannot upgrade to newer Nvim version due to machine limitation):
use {'nvim-tree/nvim-web-devicons'}

As soon as I run :PackerSync to install it, this message appears everytime I open Nvim:

Line 26 of my init.vim contains the end marker for LUA section - EOF:

Note that the problem appears even when I don't call require('nvim-web-devicons').setup().
Also, I cannot run :NvimWebDeviconsHiTest, as the following stacktrace:

Any help would be appreciated!

0.7.2 is pretty dated, and although we state in documentation (https://github.com/nvim-tree/nvim-web-devicons?tab=readme-ov-file#requirements) that we are supporting this version it clearly isn't the case. We should update documentation @alex-courtis (I suggest we support 0.9 and, 0.10 and nightly)
Out of interest, what's your machine limitation prohibiting you from upgrading?

My company's server is running on a very dated OS, so new versions of Nvim cannot run due to GLIBC version being old. Compiling Nvim from source is also not an option because the gcc toolkit is outdated too -> Install newer gcc and a thousand of its dependencies is a pain (have to find out which version can run on my version of GLIBC). And no internet connection due to privacy reasons, so there's that ... .
Anw, thank you for your prompt response.


Naming and message type of the topic joint_states/target

@joaomoura24 and I have been discussing that the topic joint_states/target maybe should be renamed to joint_states/command to remain consistent with conventions in robot control. Additionally, the topic joint_states/target uses a sensor_msgs/JointState message type which is usually reserved for reading joint_states, not for commanding. Perhaps a more standard message type should be used for commanding joints such as std_msgs/Float64MultiArray.

Thanks @JuanDelAguila
I think the best thing is to create a flag that the user can set in the robot yaml configuration file, e.g. target_message_type: 'JointState'  # or 'Float64MultiArray'. First you will need to implement extractor methods, e.g.

@staticmethod
def get_target_from_joint_state_msg(msg: JointState):
    # TODO: convert JointState to list
    return q

@staticmethod
def get_target_from_float64multiarray(msg: Float64MultiArray):
    # TODO: convert Float64MultiArray to list
    return

then after the following if-statement
https://github.com/ros-pybullet/ros_pybullet_interface/blob/5b05fa2f477823d231f956abe08a8c59fd30f8a2/ros_pybullet_interface/src/rpbi/pybullet_robot_joints.py#L135-L136
you can set the extractor function as a class variable, e.g.
if self.target_message_type == 'JointState':
    self.get_target_from_msg = self.get_target_from_jointstate
elif # TODO...

then call this function inside the set_target method.


incorrect monitor scaling (macOS) (HiDPI)

% ./examples/microui_demo/microui_demo
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: CGRectContainsRect(CGRectMake((CGFloat)INT_MIN, (CGFloat)INT_MIN, (CGFloat)INT_MAX - (CGFloat)INT_MIN, (CGFloat)INT_MAX - (CGFloat)INT_MIN), frame). self=<NSWindow: 0x14d0046c0> frame={{89,<PHONE_NUMBER>}, {1262, 946}}'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000186e00300 __exceptionPreprocess + 176
	1   libobjc.A.dylib                     0x00000001868e6cd8 objc_exception_throw + 88
	2   Foundation                          0x000000018878c978 -[NSMutableDictionary(NSMutableDictionary) initWithContentsOfFile:] + 0
	3   AppKit                              0x000000018a8fbbac -[NSWindow _reallySetFrame:] + 852
	4   AppKit                              0x000000018a8fb57c -[NSWindow _oldPlaceWindow:fromServer:] + 188
	5   AppKit                              0x000000018a8fab88 -[NSWindow _setFrameCommon:display:fromServer:] + 1984
	6   microui_demo                        0x00000001049e37a4 RGFW_window_move + 316
	7   microui_demo                        0x00000001049e09a0 RGFW_createWindow + 1816
	8   microui_demo                        0x00000001049e014c r_init + 84
	9   microui_demo                        0x00000001049e182c main + 40
	10  dyld                                0x0000000186924274 start + 2840
)
libc++abi: terminating due to uncaught exception of type NSException
zsh: abort      ./examples/microui_demo/microui_demo

Wrong 2nd parameter for the CGRectMake?
M1, Sequoia 15.1.1

Does the gl33 example have a similar error? I assume this problem has to do with the window attempting to scale to the monitor.

@OleksiyPuzikov  Would you mind providing some more context? Specifically, I would like to know your monitor size and if you are using any scaling settings.
I don't get this specific error when I test the example, but the scaling is still very off.

@OleksiyPuzikov I don't think they have, but see if the latest commits fix the error.

@ColleagueRiley

with the recent commit the crashes are no longer there, but the scaling in the microui example seems to be wrong.
I'm on a M1 MacBook Air laptop, no special settings whatsoever. However, with this being Retina display (as with most Mac notebooks) - don't you need to set a flag or take into account or something for HiDPI?

Having said that, I'm not planning to use the microui at the moment, so perhaps you'd postpone fixing that part, if it's not causing other issues reported by other users.
Thanks for your work!

@OleksiyPuzikov

don't you need to set a flag or take into account or something for HiDPI?
I actually didn't realize this.

96 DPI screens are regarded as comfortable for most people to read ~12pt font on, and is about where most "low-DPI" monitors fall. HiDPI screens are around 192 DPI and greater, with some screens falling in the middle ("medium PPI").
source

I use 92 for my calculations, which is probably what's going wrong. To fix this I will need some way to check if the monitor is HiDPI and then adjust for it. Hopefully this fixes the scaling issue.
How does it look for the gl33 example?

How does it look for the gl33 example?

@OleksiyPuzikov
Yep, that scaling looks a bit off...
If you want to test a fix yourself, change the 96 value to 192
https://github.com/ColleagueRiley/RGFW/blob/ef00e8fde3c73f1aeb3fa355370b8e5d73f671b3/RGFW.h#L8113

This suggestion makes the initial window size smaller for both gl33 and microui. Otherwise no changes.

@OleksiyPuzikov
You could also add printf("%f %f\m", monitor.scaleX, monitor.scaleY); these values should both be 1.0.

Numbers that make both scales 1.0 are 128 and 127, and this is how the microui application look like after launching:

@OleksiyPuzikov What I meant is that the scale value should be 1.0x1.0 if you do not have any scaling settings on. I'm not sure exactly what's wrong with my math for scaling, but it should be
(screen_width_pixels / screen_width_in) / dpi, the default dpi is 98 on most systems, and I believe with hidpi it should be 192.

I think I am running into this issue as well. I have a mac laptop and an external monitor. It looks like this on the laptop monitor:

and like this when I drag the window onto the desktop:

I am not resizing the window in anyway, just moving it from built in display to external display.
It seems you can work around this in glfw doing:
int width, height;
glfwGetFramebufferSize(window, &width, &height);
glViewport(0, 0, width, height);

Not sure how that works - I might have a look too.
The example code is here if you want to have a look: https://github.com/robrohan/desktop-template

@robrohan Thanks for your input on this issue! I believe the GLFW work around is the same as:
glViewport(0, 0, win->r.w, win->r.h);

By the way, do you know if either monitors are HiDPI?
Can you also print your terminal with RGFW_DEBUG enabled?

Yeah my laptop is high, external monitor is not:

I have it working though - not sure where to put if for a PR, so I'll just explain...
I added a new objective C message send define (around line 6725)
#define objc_msgSend_id_double		((double (*)(id, SEL))objc_msgSend)

Then then the function:
	double RGFW_getDisplayScaleFactor(RGFW_window *win) {
		id screen = objc_msgSend_id(win->src.window, sel_registerName("screen"));
		CGFloat scale_factor = (CGFloat)objc_msgSend_id_double(screen, sel_registerName("backingScaleFactor"));
		return scale_factor;
	}

Which uses the window's display to query the pixel's scale factor.
Then in the render loop:
        double scale = RGFW_getDisplayScaleFactor(win);
        int scale_width = win->r.w * scale;
        int scale_height = win->r.h * scale;
        ...
        glViewport((GLint)0, (GLint)0, (GLint)scale_width, (GLint)scale_height);

And now I can drag the window between the screens and all is well.
Not sure where you want to put that, but currently it'll only work on mac on my local. If you point me where you want it I can add it in a PR.

@robrohan RGFW already has a way of getting the scale factor:
#define objc_msgSend_id_double		((double (*)(id, SEL))objc_msgSend)

Should be changed to:
#define objc_msgSend_id_double(x, y)		((double (*)(id, SEL))objc_msgSend)((id)x, (SEL)y)

RGFW has adopted this syntax to prevent casting errors with C++.
RGFW_monitor m = RGFW_window_getMonitor(win);

However, this uses the CGDisplay API rather than the Cocoa API, so there may be some differences.
I also noticed that your window looks unfocused in the screenshot, this looks like the issue I just solved earlier today, so make sure you're using the most recent version of RGFW.

Interesting, I didn't know that was there. But I don't think it's doing the same thing. Here are two screen shots of me moving the window between the monitors. scale: 2 is high def, scale: 1 is normal.

Maybe I need to do something more, but I am calling them all in the render loop:
#ifdef __APPLE__
        RGFW_monitor monitor = RGFW_window_getMonitor(win);
        printf("monitor scale: %f %f\n", monitor.scaleX, monitor.scaleY);
        printf("physical: %fx%f\n", monitor.physW, monitor.physH);

        scale = RGFW_getDisplayScaleFactor(win);
        scale_width = win->r.w * scale;
        scale_height = win->r.h * scale;
        printf("scale factor: %f\n", scale);
#endif

Oh, I think I see what that means - I think scaleX/scaleY in that context is if I bumped the zoom level like changing this:

Whereas the thing I am doing is the actual pixel density of the monitor I think.

@robrohan Thank you for all of the information, this is very helpful.
They should be doing the same thing, but I've been having issues with my method of scaling windows.
As you can see from earlier in the issue, there seem to be some weird results from my method.
I'm pretty sure the scaling should take account for the window size and the scaling option by the OS.

I think you can do CGFloat scaleFactor = CGDisplayScaleFactor(displayID); in that monitor setup to do the same thing

Oh, I didn't find that yet...

@robrohan I thought CGDisplayScaleFactor was a real function you were referring to 🤔

Ah sorry, yeah nah - just as vague placement idea. On a side note, this youtuber I like to watch from time to time was digging into RGFW if you didn't see it you might like watching someone play with your project: https://youtu.be/7ZJ9pJJnxfI?si=qSJu0uPEQryINFJm&t=4543

@robrohan Yeah, that was really cool. I actually was able to watch some of that live.
Right now I'm wondering what the difference between the monitor's scale and backingScaleFactor is and if backingScaleFactor should replace my CGDisplay code.
To catch you up on this issue:
CGDisplay does not have a way to get the scale factor directly, nor do any of the other platforms. Instead you need to calculate it.
First you calculate the DPI by dividing the monitor's width by the physical size of the monitor in inches.
The PPI is then divided the "default" DPI, thus getting a scale factor.
This is where problems for hiDPI monitors comes around because the default "DPI" for non-hiDPI is 96  whereas on hiDPI, it's 192.
Although problematically, without any scaling set the scale factor should be 1. This does not appear to be the case even if the default DPI on macOS used is 192 rather than 96.


SocialX app crashes for no reason

Describe the bug
The app crashes at random points for no reason, just like last big version (back in May.) Sometimes it'll just happen when going on a page (like the feed or profile), and sometimes it'll happen when attempting to post (which is more prevalent).
To Reproduce
Steps to reproduce the behavior:

Use the app, click around, try to post
It crashes

Smartphone (please complete the following information):

Device: LG K20V (VS501)
OS: Android 7.0
Software Version: VS5011AA

Can you pinpoint some actions that cause these crashes? Or are they completely random?

@alexsirbu04 A lot of randomness involved, but it usually happens after switching pages (e.g. to view your Feed/Profile/etc), or while posting.

@1000goalgaming  are the crashes still appearing?


Update AI Studio document page toc.yml which has wrong hyperlink to ariticle

the wrong indentation  (missing two spaces) cause the toc hyperlink not pointing to the actual documentation.
https://learn.microsoft.com/en-us/azure/ai-studio/how-to/develop/create-hub-project-sdk look at left toc, create-manage-compute link, it's pointing to the wrong url

@sdgilley
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@c2js - thanks for your contribution and apologies that I didn't see it earlier.
In the meantime, I believe the TOC has been fixed in a different PR, when some items also moved.  I don't see the behavior you describe. I'm going to close this, but please re-open if you still see a problem!
#please-close


Rigidbodies never sleep

Whenever a rigidbody begins sleeping, it immediately gets woken up. I've tried debugging, and I'm guessing the problem is that the change of external forces needs to be checked if they're above the sleeping threshold. I'm not exactly an expert when it comes to physics engines, so I cannot exactly say where the fault lies.

I think this issue might've been introduced by automatically inserted apply_deferred systems added in Bevy 0.13. The sleeping logic was previously relying on some rather questionable and precise scheduling, and there might be some new apply_deferred systems that break it. I'll try to look into this more to verify.
Either way, I think the sleeping logic should be partially rewritten as it's currently not very robust or optimal. I have plans to experiment with "simulation islands", which would both increase parallelization and help handle sleeping properly.

This was partially fixed by the solver rework (#385) in Avian 0.1. Bodies should now fall asleep again, but only if they're not interacting with other dynamic bodies. I'll close this, and open a separate issue for simulation islands soon


fix orphan check for deleted branch

Modify the deleted branch orphan check to check for the new table instead.
Regression from 6e19484f4d3bf372212f2da462110a1a8c10cbf2
Resolves https://codeberg.org/forgejo/forgejo/issues/1522

(cherry picked from commit c1d888686fe445e4edecb9d835c5b3893b574b75)

I was unable to create a backport for 1.21. @earl-warren, please send one manually. :tea:
go run ./contrib/backport 27310
...  // fix git conflicts if any
go run ./contrib/backport --continue


Slideshow accepts new files via a drag and drop but nothing happens

Browser: Vivaldi | 5.3.2679.68 (Stable channel) (x86_64)
Test server: https://hochstenbach.solidcommunity.net:8443
In the slideshow menu I can drop a new image file.  When I click OK the image file gets opened in a new tab (with URL file:///Users/patrickhochstenbach/Desktop/Images/optimism.jpeg)  but nothing changes on the pod.
I would expect:

If there is nothing that can be uploaded, then the pod shouldn't tell me something can be uploaded.
If there is something that can be uploaded, then the pod should accept the upload and present it.

Can you be more precise with your problem.
CSS or NSS which server ?
I just uploaded on bourgeoa.solidcommunity.net/public/hochtenbach/ without any problem. (.jpg or .jpeg file - file deleted after without any problem)

@phochste -- A screenshot will likely be helpful, with clear indication of where you're dropping the image file, as "drop zones" may vary, and if you are drop the file outside the "upload" drop zone, your experience may be as expected -- which may be because the drop zone is not be as intended.  Along similar lines, your OS (name and version, which you did not provide, but it appears to be some version of macOS, based on the URL shown in the new Vivaldi tab) can matter as much as your browser (name and version, which you did provide).

I'm running Vivaldi on OSX Big Sur and I am testing the Solid NSS test server. I didn't notice the slideshow button before and tried to use it.

Apparently I can drag and drop an image file in this region and get a JavaScript alert message asking me to confirm that I want to upload. When I click 'OK' only a new tab gets opened with my local file. I was wondering why I get a dropzone there, and is that a feature?

What you are seeing  I think is the default drop action of a web browser, to navigate to display the thing dropped.    That message is to protect users from losing the state of their current web page.  The "Cancel"  is to protect the current tab by putting the dropped thing inn a new one.  The "OK" lets the event handler drop though to one provided by the page or if none the bowser default.
In your case it looks like the slideshow pane doesn't have a handler, so you dropped though to the browser default, and you were lucky it opened in a tab and didn't overwrite the current tab.
I propose we should enhance the slide show pane so that it accepts dropped things. (And maybe suppresses  the favicon but that is another issue.?)

As a starting point, slideshow pane is in solid-panes:
https://github.com/SolidOS/solid-panes/blob/main/src/slideshow/slideshowPane.js


Added car.js

I added co2eq/car.js and modified co2eq/transportation.js
To make this pull request small, car.js now only contains functions with generic car models (specified by the size and the engine type). The data is from https://docs.google.com/spreadsheets/d/1f1j9EeVn9czOZBJKLXvgPwnmldakxuJ7/edit#gid=439900614
Specific car models with brand name and year(data from Climobil) must be added to this .js file later.

From Issue #246

This is great. type probably needs to be changed to engineType.
@FelixDQ given that

we have another input type for fuel (or electricity), how do you think we could structure so we can take that as possible variable (the source that @ayakoaohara is using has both options possible :-)), so someone can input the gCO2/km/passenger with or without fuel
how would you structure the file to add the brand/model/year combination? There is also the options with this one to get the gCO2/km/passenger with or without fuel from the sources.

This is just so @ayakoaohara can keep on doing her amazing work!!

This is great. type probably needs to be changed to engineType.
@FelixDQ given that

we have another input type for fuel (or electricity), how do you think we could structure so we can take that as possible variable (the source that @ayakoaohara is using has both options possible :-)), so someone can input the gCO2/km/passenger with or without fuel
how would you structure the file to add the brand/model/year combination? There is also the options with this one to get the gCO2/km/passenger with or without fuel from the sources.

This is just so @ayakoaohara can keep on doing her amazing work!!

We can add a parameter footprintIgnoreFuel that the model could use to calculate the footprint, but let's do that in a separate PR.
The brand/model/year combinations should be supplied in a json file similar to airports.json which car.js can use to calculate the footprint.

Thank you for reviewing!
In this pull request, I can write a car model (size, engineType, brand, id, activityType, dateTime, durationHours, distanceKilometers, transportationMode, and pathLonLats).
I can go ahead and delete CAR_CATEGORIES currently in car.js (maybe rename the file to co2eq/car/index.js), and create co2eq/car/cars.json that contains the car categories (only generic categories for now). This way, cars categories with brand/model/year combinations can be added to this .json file later.
After that, in a separate pull request, I could go ahead and write footprintIgnoreFuel to co2eq/car/index.js.
Let me know how this sounds.

That sounds great!

I wrote co2eq/car/cars.json with generic car categories, and I have a question about where to find additional gCO2/km carbon intensity data.
For when engineType is present & size is missing, there are categories defined only by the engineType.
For when engineType is missing (unkown) & size is present, there are categories defined only by the size.
For when both are missing, there is a category called "average"
For when both inputs are available, there are categories defined by both size and engineType.
Although gCO2/km is available for categories defined by engineType and categories by both size and engineType, I couldn't find gCO2/km for an "average" car and for a car only defined by its size on https://docs.google.com/spreadsheets/d/1f1j9EeVn9czOZBJKLXvgPwnmldakxuJ7/edit#gid=1278401347. Is there a suggestion on where to find the data for these?

Hi @ayakoaohara , thanks for your continued investigation! The work you're doing is amazing.
Hopefully this helps: https://docs.google.com/spreadsheets/d/1f1j9EeVn9czOZBJKLXvgPwnmldakxuJ7/edit#gid=159468561 ?

Thank you for the helpful link.
To clarify, should data on kgCO2e be used, or kgCO2? The numbers that I used in the initial version of car.js in this pull request was kgCO2, so I will change them to kgCO2e if that is ideal!

KgCO2e is what we're looking for! 😊
On Fri, Nov 29, 2019, 02:36 ayakoaohara<EMAIL_ADDRESS>wrote:

Thank you for the helpful link.
To clarify, should data on kgCO2e be used, or kgCO2? The numbers that I
used in the initial version of car.js in this pull request was kgCO2, so I
will change them to kgCO2e if that is ideal!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tmrowco/tmrowapp-contrib/pull/258?email_source=notifications&email_token=AAT333SX7XQCI7VFDJYRNETQWBWYRA5CNFSM4JR657WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNU2DY#issuecomment-559631631,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT333RN6NSTZPB4SFXUMYLQWBWYRANCNFSM4JR657WA
.

Sorry for the delayed responses, and thank you for answering my questions:)
I added a directory co2eq/car, and added index.js and cars.json (previously co2eq/car.js). The data in cars.json is kgCO2/km from https://docs.google.com/spreadsheets/d/1f1j9EeVn9czOZBJKLXvgPwnmldakxuJ7/edit#gid=1278401347 index.js
I also modified carbonIntensityGeneric() (co2eq/car/index.js) so it would be consistent with keys defined in cars.json. (I am planning to write a wrapper function so that it can calculate kgCO2/km with missing parameters (size, engineType, or brand)).

Thank you for the review! I just updated the files so they would align with your comments. If you could check them again, that would be great.

Hi @ayakoaohara ! I'll let @corradio check the code :-)
Last thing: because of it seems that small, medium, large categorisation is ill-defined (a developer or a user would not clearly understand what each category encompasses), we think it's wiser to use the Euro Car Segments (I've input the values here: https://docs.google.com/spreadsheets/d/1f1j9EeVn9czOZBJKLXvgPwnmldakxuJ7/edit#gid=227529294 ), as it can be linked back to individual models (if we need to), and is more widely used by the  EU and manufacturer associations.
We would also use euroCarSegment instead of size, where the values are the Segment letter.
Hopefully that makes sense to you as well!

Great! I will change the code to use euroCarSegments, rather than size. Thank you for reviewing!

I have a question on which engine types to include in the code.
Currently, the list in co2eq/car/cars.json has diesel, petrol, hybrid, cng, lpg as engine types. Should I also include "Plug-in Hybrid Electric Vehicle" and "Battery Electric Vehicle" as inputs for engine types in cars.json?

Yes, let's include them as well!

Thank you for the reviews! In co2eq/car/cars.json, I erased size as category and added euroCarSegment. In addition, "plugInHybridElectric" and "BatteryHybrid" are included as engineTypes.

That's amazing @ayakoaohara !
We're almost there!
As the euroCarSegment takes different values, and because we want to avoid typos when developers will create activities, we tend to define the possible values in this file:
https://github.com/tmrowco/tmrowapp-contrib/blob/master/definitions.js
I therefore suggest adding a few constants for both euroCarSegment and engineType:
const EUROCARSEGMENT_DUALPURPOSE4X4 = 'dualPurpose4x4';
...
const ENGINETYPE_DIESEL = 'diesel';

This ensure that we can change the constants later on.
Question for you @martincollignon : for euroCarSegment values, should we use descriptions (i.e. dualPurpose4x4) or should we use the letters (A ... as defined in https://en.wikipedia.org/wiki/Euro_Car_Segment)?
What do you think is the most intuitive for a developer that knows about those segment?

Let's use A,B, etc. Also easier to avoid spelling errors.
On Wed, Dec 4, 2019, 10:08 Olivier Corradi<EMAIL_ADDRESS>wrote:

That's amazing @ayakoaohara https://github.com/ayakoaohara !
We're almost there!
As the euroCarSegment takes different values, and because we want to
avoid typos when developers will create activities, we tend to define the
possible values in this file:
https://github.com/tmrowco/tmrowapp-contrib/blob/master/definitions.js
I therefore suggest adding a few constants for both euroCarSegment and
engineType:
const EUROCARSEGMENT_DUALPURPOSE4X4 = 'dualPurpose4x4';...const ENGINETYPE_DIESEL = 'diesel';
This ensure that we can change the constants later on.
Question for you @martincollignon https://github.com/martincollignon :
for euroCarSegment values, should we use descriptions (i.e. dualPurpose4x4)
or should we use the letters (A ... as defined in
https://en.wikipedia.org/wiki/Euro_Car_Segment)?
What do you think is the most intuitive for a developer that knows about
those segment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tmrowco/tmrowapp-contrib/pull/258?email_source=notifications&email_token=AAT333URPELK2MHT6HL7ML3QW5XPTA5CNFSM4JR657WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4IBKA#issuecomment-561545384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT333T3WETWCT7XOLU5KVTQW5XPTANCNFSM4JR657WA
.

great, then let's adjust the constants as well
On Wed, Dec 4, 2019 at 10:47 AM martincollignon<EMAIL_ADDRESS>wrote:

Let's use A,B, etc. Also easier to avoid spelling errors.
On Wed, Dec 4, 2019, 10:08 Olivier Corradi<EMAIL_ADDRESS>wrote:

That's amazing @ayakoaohara https://github.com/ayakoaohara !
We're almost there!
As the euroCarSegment takes different values, and because we want to
avoid typos when developers will create activities, we tend to define the
possible values in this file:
https://github.com/tmrowco/tmrowapp-contrib/blob/master/definitions.js
I therefore suggest adding a few constants for both euroCarSegment and
engineType:
const EUROCARSEGMENT_DUALPURPOSE4X4 = 'dualPurpose4x4';...const
ENGINETYPE_DIESEL = 'diesel';
This ensure that we can change the constants later on.
Question for you @martincollignon https://github.com/martincollignon :
for euroCarSegment values, should we use descriptions (i.e.
dualPurpose4x4)
or should we use the letters (A ... as defined in
https://en.wikipedia.org/wiki/Euro_Car_Segment)?
What do you think is the most intuitive for a developer that knows about
those segment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/tmrowco/tmrowapp-contrib/pull/258?email_source=notifications&email_token=AAT333URPELK2MHT6HL7ML3QW5XPTA5CNFSM4JR657WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4IBKA#issuecomment-561545384
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAT333T3WETWCT7XOLU5KVTQW5XPTANCNFSM4JR657WA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tmrowco/tmrowapp-contrib/pull/258?email_source=notifications&email_token=AAMUIKBOH7K3NWPJ5D262UDQW54BVA5CNFSM4JR657WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4LWYY#issuecomment-561560419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMUIKGKMUFJOUIFXFRPJ3DQW54BVANCNFSM4JR657WA
.

--
Olivier Corradi
Founder, CEO
https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio
tmrow.com

Sorry about this, I selected "update branch" by mistake.

Thank you again for reviewing the code in detail.
In definitions.js, I added new definitions,  Euro car segments (EUROCARSEGMENT_A, EUROCARSEGMENT_B,...) and engine types. In addition, values corresponding to "euroCarSegment" in co2eq/car/cars.json now has letters A, B,.., rather than descriptors (mini, dualPurpose4x4,...).
I also edited co2eq/index.js so that the function will refer to "euroCarSegment" field, rather than the old "size" field.

Sweet! Now to the last part: deciding when the model should run.
@FelixDQ has prepare the following PR (https://github.com/tmrowco/tmrowapp-contrib/pull/262) which allows each model to express when they have sufficient data to run.
Would you be able to make the same changes to this particular model?
Then we should be good to go!

I'm very glad to receive feedback as well! The modelCanRun() that I added in co2eq/car/index.js tests for the input's activity type and transportation mode. Let me know if modification is needed.

Amazing @ayakoaohara ! This was amazing. Let us know if you want to take a stab on the climobil data ;-)

Thank you for the detailed feedback! I would be glad to work on the climobil data. I will open a pull request, once I write a code for it.


Remove lots of spaces and text from the github output

https://docs.google.com/document/d/1ViRu34v5zX9kpOfL0xgHohc0BrOJikjLYlP3GIy5Pfs/edit?usp=sharing
Removes 1000 char via various optimizations

Example of the final output below

Check out my proposal for the Hatch! Click here to preload the Hatch Configuration Dashboard with my parameters if you think you can do better.

Graphical Summary

Graph Descriptions

Top Left, Impact Hour Rate vs wxDai Collected: The Impact Hour Rate determines the Minting Rate for Builders, making 1 Impact Hour equivalent to sending this amount of wxDai to the Hatch.
Top Right, Proposal Acceptance Criteria: Shows the range of possibilities for DAO vote outcomes and whether they succeed or not given the Support Required & Minimum Quorum I chose.
Bottom Left, Backer's Rage Quit % vs wxDai Collected: The Backer's Rage Quit % is the percent of wxDai that the Backers sent to the Hatch that would be returned if they decide to Ragequit.
Bottom Right, Redeem-ability of the DAO's wxDai: Shows who has rights to the wxDai held by the DAO. All of the DAO's funds are collectively governed but some can be withdrawn if token holders Ragequit. This shows the results of my parameter choices at the 3 different goals.

Simulated Outcomes

Hatch Strategy
We need to put lots of text here
DAO Strategy
We should give them the space to explain their thoughts
Hatch Details

Trusted Seed members can send wxDai to the Hatch for 15 days.

The target goal will be 2500000 wxDai, with a minimum of 100000 wxDai necessary for the TEC Hatch DAO to be launched and a cap at 50000000 wxDai.

Backers will need to send in 0.0001 wxDai to mint 1 TECH.

The membership ratio is set at 10 wxDai/CSTK, so a Trusted Seed member with the minimum CSTK Score of 1125 CSTK can send up to 11250  wxDai to the Hatch.

DAO Details

Proposals will be voted on for 3 days. They will require at least 60% support, and a minimum of 2% of the TECH Tokens will have to vote yes for a proposal to pass.

TECH token holders will have 1 hours to exit the DAO if they don't like the result of a vote (as long as they didn't vote yes) before it is executed.

There will be a minimum of 8 hours between proposals so people always have time to exit safely if they voted yes on a previous vote, this means we can have at most 1095 votes per year.

To prevent griefing attacks, it will cost 1000 wxDai to make a proposal.

If you have Impact Hours, you can see what you will get with my configuration in the Impact Hour Results table on the Dashboard.
My Hatch Configuration

Parameter
Value

Target Goal (wxDai)
2500000

Maximum Goal (wxDai)
5000000

Minimum Goal (wxDai)
700000

Impact Hour Rate at Target Goal (wxDai/IH)
60

Impact Hour Rate at Infinity (wxDai/IH)
180

Hatch Membership Ratio (wxDai/CSTK)
10

Hatch Period (days)
15

Hatch Minting rate (TECH/wxDai)
10000

Hatch Tribute (%)
5

Support Required (%)
93

Minimum Quorum (%)
2

Vote Duration (days)
3

Vote Buffer (hours)
8

Ragequit (hours)
18

Tollgate Fee (wxDai)
1000


Readme doesn't explain the project

The readme file is severely lacking. It does not explain how this repository will be used.

I just made an edit to the ReadMe to resolve the issue as a pull request. I requested that Zach review it.


AVRO-3759: Add extra types for RecordSchema, EnumSchema, FixedSchema and DecimalSchema

AVRO-3759
What is the purpose of the change

Adds extra types for RecordSchema, EnumSchema, FixedSchema and DecimalSchema

Verifying this change

Existing tests are updated to the API change

Documentation

Does this pull request introduce a new feature? no

I've created this PR for discussion.
So far I am not convinced that the change is really an improvement.

CC @ftelnov


Port part of nofib benchmarks to hkmc2

Cool work!
But what's with all the reverted commits? Do you want to submit these improvements in separate PRs?
Also, can you please add some spacing between things? At least one empty line between each definition – unless, of course, they are mutually recursive. And least two empty lines between the prelude import and the definitions and between the definitions and their final use. Otherwise, the result is barely legible.

Regarding groups of mutually-recursive data structures, please do separate them with empty lines by using the recent :... diff-test feature.
Example output:
:...
//│ ————————————————————————————————————————————————————————————————————————————————

fun foo() = bar()

fun bar() = if false then foo() else 42

foo()

//│ = 42
//│ ————————————————————————————————————————————————————————————————————————————————

Thanks for the comments! I will make the changes to add empty lines now and also do some further cleanup (delete the lcss.mls in the previous compiler project, delete the 0 at the beginning of files, etc.), after that I will turn this draft PR (which I made to see if floating point numbers cause flakiness to the test output) to be ready to review.
The reverted commits are about my changes to difftests so that only changed files will be tested (otherwise all files are tested, which, if I remember correctly from our meeting, is intended?)

The reverted commits are about my changes to difftests so that only changed files will be tested (otherwise all files are tested, which, if I remember correctly from our meeting, is intended?)

It's not specifically intended. It's just a known bug. We haven't bothered to fix it because nowadays we just use the watcher to test things. I hope you do as well. Right?

It's not specifically intended. It's just a known bug. We haven't bothered to fix it because nowadays we just use the watcher to test things. I hope you do as well. Right?

Oh I now remember that we mentioned about the watcher during our meeting, I do use the watcher when I make changes to the tests, but it seems that under the watcher mode (~test), still all tests are run when cmd+s is pressed, as shown in the following gif. 😮 Or did I miss anything?

OMG I can't believe you've done all this work without using the proper testing approach that tests the CURRENT file only when you save. It's just ~hkmc2JVM/Test/run.

OMG I can't believe you've done all this work without using the proper testing approach that tests the CURRENT file only when you save. It's just ~hkmc2JVM/Test/run.

😵Ah now I see! Thanks a lot!

I have made further cleanup and added empty lines. One minor thing that I notice is that adding empty lines between nested functions does not interact well with editor's auto trimming of white spaces.

Please turn auto-trimming off in your editor. I like to keep indentations in place so I don't have to reinsert them all the time. There is no reason to trim it.

I am not sure whether this should be a concern (→ below stands for whitespaces):
fun foo() =
  fun bar() = 1
→ // no problem
  fun baz() = 0
  baz()

fun foo() =
  fun bar() = 1
// without starting white spaces, `foo()` is considered by the compiler to end here
  fun baz() = 0
  baz()

Are you saying that your editor ALSO de-indents comments? That would be madness.
In any case, you're welcome to fix this, but please don't use de-indented comments. They look terribly confusing.

Can we merge this PR now? Or is there something else you wanted to fix?

Can we merge this PR now? Or is there something else you wanted to fix?

Yes, I think it's ready now. Thanks!


Create policy class

Added in basic representation of Policy class.
Currently only supports adding of new policies via newPolicy (args)
Added in basic skeleton for AssignedPolicy class.
Todo:
Integrate AssignedPolicy class into client class
Delete commands for Policy
Edit commands for Policy
Will need to figure out how to switch list views between policies and persons

LGTM!


Update Mondo Outreach page with April 5, 2024 recording

Hi @twhetzel, please update the Mondo Outreach page with the recording from April 5, 2024 with guests from OMIA. The recording is in the drive.
@sabrinatoro does "Use of Mondo in OMIA" work for the topic of the April 5th outreach call?

I don't remember the title of their presentation. Can we use the following title?
Online Mendelian Inheritance in Animals (OMIA)

Link updated.


Allow nested Route::group to override parent namespace

Currently if namespace is defined in nested Route::group, the namespace is appended with the parent.
It will be good if namespace can be overwritten in child if it start with '\'.
Route::group([
    'namespace' => 'Admin\Controllers',
], function () {
    ...
    Route::group([
        'namespace' => '\Admin\Submodules\Controllers',
    ], function () {

   });
    ...
});

I don't really want to support this.


[Bloom] Broken Player

OS: Win 10, latest
Spotify version: latest
Spicetify version: 2.9.9
Theme name: Bloom

can you check it again after upgrading the spicetify-cli


Upgrade module to v2

Closes #60

Once this is approved and merged, we can tag it as v2 and cut a release manually.


Diacritical problems on older devices

Hi!
I've been using you library for a while now without any problems, but now I have a project in which, some of the texts have diacritics. I don't know the exact android version on which it runs OK and from which it has problems, but it seems like pre-L devices don't show the diacritical characters with the custom font.

Sorry, seems like the font I was using had problems. Changed it to another and it works


Cropping the detected face with dlib

Hi Serengil! I've noticed that DlibWrapper.py can be improved cause in some edge cases it fails. More specifically, there are edge cases where the bounding box is partially outside the image window (that explains the fact that some coordinates of the bounding box in dlib have negative values). In these cases, cropping the detected face based on the box coordinates either fails or returns odd results.
So, instead of this command

detected_face = img[top:bottom, left:right]

we should get the detected face with the following command

detected_face = img[max(0, top): min(bottom, img_height), max(0, left): min(right, img_width)]

thank you for your contribution. I can do it but why don't you send a PR? In that way, you will be displayed in the contributors.

ok, i will send a PR, thank you!


Feature/refactor

@alirizwan are you working on integrating last features from develop-refactor branch? (such as subscriptions). Which is the current state?

Wow, there's a lot of work made here. Can I ask why this pull request has not been applied? Thanks.

This is v1.0 in making. I’m just testing and trying to write enough test coverage for future versions.
Sent from my iPhone
On Feb 13, 2021, at 2:45 PM, Irving A. Bermúdez S<EMAIL_ADDRESS>wrote:

Wow, there's a lot of work made here. Can I ask why this pull request has not been applied? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/almost-full-stack/graphcraft/pull/36#issuecomment-778621701, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAUKBTIMNWU4M7J6NAHY3DS6Z7AXANCNFSM4JPK7NPQ.

But this is published as graphcraft@beta
Sent from my iPhone
On Feb 13, 2021, at 2:45 PM, Irving A. Bermúdez S<EMAIL_ADDRESS>wrote:

Wow, there's a lot of work made here. Can I ask why this pull request has not been applied? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/almost-full-stack/graphcraft/pull/36#issuecomment-778621701, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAUKBTIMNWU4M7J6NAHY3DS6Z7AXANCNFSM4JPK7NPQ.

But this is published as graphcraft@beta
…
Sent from my iPhone On Feb 13, 2021, at 2:45 PM, Irving A. Bermúdez S<EMAIL_ADDRESS>wrote:  Wow, there's a lot of work made here. Can I ask why this pull request has not been applied? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAUKBTIMNWU4M7J6NAHY3DS6Z7AXANCNFSM4JPK7NPQ.

Thanks. If I see anything wrong while using it i let you guys know.
Cheers,

Looks great. Would be nice to see this merged 👍

@alirizwan do you intend to merge this and release a v1?

h

Indeed. I will release this over the weekend. Just some final tests to be done.


Rename license file

The flambda issue is tracked in #7

I also had to disable 32-bits tests - It would be nice to re-enable them, this is tracked in #5


Add option to pre-load modules on first query

Sometimes there is a performance reason to have some modules pre-load on first query, to avoid waterfalls of module loading.

v2.6.0


feat(apps/dev/prow): add gcs credential secret and use it in release

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve


[grpc] update to 1.37.0

Library name: grpc
New version number: 1.37.0
https://github.com/grpc/grpc/releases/tag/v1.37.0

Duplicate of #15798

Depends on #17140


Passing props to every scene

Version
Tell us which versions you are using:

react-native-router-flux v4.0.0-beta.21 (v3 is not supported)
react-native v0.47.0

I am trying to migrate to react-native-router-flux v4
We used to pass a few props to the "<app />" component and theses props where passed to each Scene of our app :
import scenes from '../scenes/scenes';

class App extends Component {
  render() {
    return (
      <Router
        {...this.props}
        scenes={scenes}
      />
    );
  }
}

function mapStateToProps(state, ownProps) {
  return {
    global: state.global,
    userData: state.userData,
    ...ownProps,
  };
}

function mapDispatchToProps(dispatch) {
  return bindActionCreators({
    ...globalActions,
    ...completeActions,
  }, dispatch);
}

export default connect(mapStateToProps, mapDispatchToProps)(App);

Here is how the scenes are declared :
const scenes = Actions.create(
  <Modal>
    <Scene
      key="pageSplash"
      component={SplashViewContainer}
      title="Loading"
      initial
      hideNavBar
    />
    <Scene
      key="pageAccount"
      component={AccountUserView}
      titleKey="account"
      type={ActionConst.RESET}
    />
  </Modal>

As far as I can see, props are correctly set in  but never reach any Scene. It worked with react-native-router-flux v3, but not anymore.
Is there something I am missing ?

<Scene {...this.props} key="login" component={RNHighScores} title="Login" initial={true} />
I think  you should pass props to the scene.

I didn't have to that in v3 and I was hoping wouldn't have to do this. My scenes are imported from several files and there are a bunch of scenes so it would be quite time consuming.
Thanks for your answer.

You have to move scenes into Router for this, or pass params as second argument for Actions.create


cursor: return invalid after seeking out of bound

Signed-off-by: youjiali1995<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close https://github.com/tikv/tikv/issues/3378
Problem Summary:
Cursor uses min_key/max_key to reduce the cost of seeking when the sought key is out of bound. Even though I think this optimization can't be widely applicable, I still keep it. However, valid() may return true even if seek() returns false which is dangerous. We should make them consistent.
What is changed and how it works?
Proposal: xxx
What's Changed:
Use the in_bound field to indicate that the previous seek() has returned false and valid() returns false in this case.
Related changes
Check List
Tests

Unit test

Release note

No release note

Ping @youjiali1995


Terminal causes hard disk to spin up

Windows Terminal version
1.11.3471.0
Windows build number
19044.1466
Other Software
No response
Steps to reproduce

Have a setup like Windows on SSD and HDD for data
Wait when Windows spins down HDD
Launch Terminal
Hear HDD spinning up

Expected Behavior
HDD remains standby
Actual Behavior
HDD spins up. Besides making PC louder, this issue introduces delay to the terminal startup

What shell are you running in the Terminal? Is there anything in that shell's startup that might be kicked off just by launching the shell? Does this repro in a vintage console window? Is the HDD you're C:\ drive?

What shell are you running in the Terminal?
By default it runs PowerShell.

Is there anything in that shell's startup that might be kicked off just by launching the shell?
I think no. I didn't modify the defaults.

Does this repro in a vintage console window?
No with cmd.exe, yes with powershell.exe.

Is the HDD you're C:\ drive?
C: is SSD, and D: is HDD.

yes with powershell.exe.

Great, then this sounds like an issue with PowerShell, not the Terminal. I'd suggest filing this over at https://github.com/PowerShell/PowerShell, they'll be more able to help figure this one out. Thanks!


[improve][client] Add readAllExistingMessages API for TableView

PIP:  https://github.com/apache/pulsar/pull/21166
Motivation
In the context of utilizing the TableView component, there are instances where we aspire to consistently retrieve the most up-to-date value associated with a given key. To accomplish this, we can employ an API that allows us to wait until all data has been fully retrieved before accessing the value corresponding to the desired key.
Modifications
Add an API waiting for data update completion.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

What if we keep producing the messages to the TableView (potentially by another instance) while readingAllExistingMessages?
In that case, the method may never finish. Maybe it would be possible  to add a stop mechanism based on i.e. comparison to the latest MessageId available during start of the synchronization?
Something like:

read latest message ids from partitions
start reading until the fetched message ids

Ok, I see it was already spotted in another PR.


refactor: Migrate to urfave/cli command structure

Integrate urfave/cli for command line argument parsing

Replace flag package with urfave/cli for better CLI experience
Add serve command with appropriate flags and validation
Add version information via ldflags at build time
Implement automatic GOMAXPROCS configuration
Validate signal account format using regex
Validate signal API URL scheme and structure
Use JoinPath for constructing API endpoint URLs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#27
#26  👈 (View in Graphite)
#25
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 21, 5:12 PM EST: A user merged this pull request with Graphite.


fix: BulkDownloadModal Validation - Reformat query

Pull Request
JIRA Ticket
none
Description
Updating syntax
Notes
Tests
Works in sandbox
When on the CG SamplesView page, select some samples and open the BulkDownloadModal.  The modal should open without giving an error.

Might be nice to have a test


[BUG] - White on white text

I'm seeing some white on white text?? Not sure whats causing this other than maybe my chrome theme (set to dark). Maybe this is something on my end.

This should be fixed by now in the latest version. 0.3.1. Could you update and try again?

Works like a charm!


Test-DbaPowerPlan suddenly failing?

Is this a feature OR bug:
bug
System Details
User reports:
There are no firewall restrictions between the machine I run dbatools to my database servers.
If I run for example Test-DbaPowerPlan -ComputerName "SERVER" I get the following error:
Get-CimInstance : The WinRM client cannot process the request. Default authentication may be used with an IP address under the following conditions: the transport is HTTPS or the destination is in the TrustedHosts list, and explicit credentials are provided. Use winrm.cmd to configure TrustedHosts. Note that computers in the TrustedHosts list might not be authenticated. For more information on how to set TrustedHosts run the following command: winrm help config.
At line:95 char:21
I'm about to submit a PR to fix

resolved


Added new metric for consumers connected to provider

This PR creates a new metrics for  all the consumers connected to the   provider with additional metadata.
sample metric:
ocs_storage_consumer_metadata{capacity="500",granted_capacity="500",state="Ready",storage_consumer_name="ocs-storageconsumer"} 1
JIRA: ODFMS-58
Signed-off-by: Kaustav Majumder<EMAIL_ADDRESS>

/cc @aruniiird @weirdwiz

/test ocs-operator-bundle-e2e-aws


Additionally test host firewall + KPR disabled in E2E tests

Let's additionally enable host firewall on a couple of existing matrix entries associated with KPR disabled, so that we can additionally cover this configuration and prevent regressions.
Currently depends on an unreleased version of the Cilium CLI

/ci-e2e

/ci-e2e

/ci-e2e-upgrade

/test

/ci-e2e-upgrade

@brb Do you have any preference about which matrix entries should be switched to enable host firewall? I've currently just picked the first two, but open to change.

LGTM (as long as we have a config KPR=off, host-fw=off, kube-proxy=iptables, which is the 3rd config).


Add RxSwift section and a sample app

Thanks for your contribution
Let's hold off creating a new category until there are many more projects
Will add RxSwift to the app description

Actually I will move it to a section called Reactive Programming


Clean up zopen-xxx services and associated docs

zopen-versions fixed so it now works
zopen-query cleaned up so the documented functions work - others highlighted for future improvements
zopen doc page fixed to point to the right underlying tools and some wordsmithing

/run tests