BUG: read_parquet arguments filters didn't take effect

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[X] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import modin.pandas as mpd
import pandas as pd

df = pd.DataFrame([{"col_a": 1, "col_b": "a"},
                   {"col_a": 2, "col_b": "b"},
                   {"col_a": 3, "col_b": "c"}])
df.to_parquet("test.parquet")

pdf = pd.read_parquet("test.parquet", filters=[[("col_a", "==", 1)]], columns=["col_b"], engine="pyarrow")
print(pdf.shape)  # (1, 1) <- expected result

mdf = mpd.read_parquet("test.parquet", filters=[[("col_a", "==", 1)]], columns=["col_b"], engine="pyarrow")
print(mdf.shape)  # (3, 1)

Issue Description
Hi Modin team, I am facing the problem when using modin.pandas.read_parquet with argument: filters. Example above shows read_parquet with pandas filter that return result was what i expected but modin.pandas.read_parquet do not. How can i fix this issue? Is there any suggestion for this? Thanks a lot!
Expected Behavior
modin.pandas.read_parquet returns exactly same what pandas do.
 Needs further investigation.
@pyrito could you please take a look? IIRC it was you who last touched parquet-related code...

@vnlitvinov yup, I just took a look. It looks like we just straight up don't support the filters kwargs since we read based on row group chunks. We could add support to handle this naively now and then think of a smart way to filter out rows in parallel. I can't think of a straightforward way off the top of my head.


HMR doesn't work with @import style in sass

Describe the bug
HMR doesn't work with @imported modules in sass. If the imported sass is edited, it's style is not hmr.
Reproduction
https://github.com/csr632/test-vite/tree/sass

npm run dev
edit nested.scss

The new style is not applied.
System Info

required vite version: vite v1.0.0-beta.11
required Operating System: MacOS
required Node version: v12.16.2

https://github.com/vitejs/vite/pull/313

Duplicate of #9


Front camera

Hi. How can i use front camera ?

Looks like a dup https://github.com/AmolGangadhare/flutter_barcode_scanner/issues/46

Please refer to #46 for further updates.
Thanks


sqlalchemy: support TINYINT type

Description
Adds support for the Databricks TINYINT type.
To use the TINYINT users can:
from databricks.sqlalchemy.dialect import TINYINT

SampleTable = Table(
    "some_table_name",
    metadata_obj,
    Column("small_number",TINYINT),
)

Related Tickets & Documents
Closes #123
Related to #108 since we'll need to implement BINARY in a similar fashion.

In this PR, I also want to update  examples/sqlalchemy.py tos how how to use the TINYINT type. When I tried this I'm seeing this exception ModuleNotFoundError: No module named 'sqlalchemy.orm'; 'sqlalchemy' is not a package which seems like an environment problem. Going to revisit this after I open a PR for reusing TCP connections.

Hello! I think we are facing an issue that would be fixed by this PR. Would it be possible to merge it?

Ping @susodapop in case you didn't see my previous comment 😄
Do you have any plans to add support for TINYINT?

Hey @gdippolito I'm dropping this PR in favour of #265 which will merge and be released next week. Thanks for your patience in this regard. We've completely rewritten our dialect and incorporated this addition into that effort.


Fix sources for modern ssh

...to allow the app to be compiled under actual linuxes.
Resolves #508

I can confirm that this fixes:
In file included from /Users/poreilly/code/blackbird/src/exchanges/exmo.cpp:7:
/Users/poreilly/code/blackbird/src/utils/hmac_sha512.hpp:11:12: error: variable has incomplete type 'HMAC_CTX' (aka 'hmac_ctx_st')
                HMAC_CTX ctx;
                         ^
/usr/local/Cellar/openssl@1.1/1.1.1h/include/openssl/ossl_typ.h:102:16: note: forward declaration of 'hmac_ctx_st'
typedef struct hmac_ctx_st HMAC_CTX;
               ^
1 error generated.


Not able to enable calico-typha after editing cluster config

Expected Behavior

Per the calico documentation calico/typha can be enabled on existing cluster by editing cluster configuration and appending typhaReplicas: 3 to calico : https://kops.sigs.k8s.io/networking/calico/#configuring-calico-to-use-typha
Current Behavior

After applying those changes in existing on premise k8s cluster and running rolling update we don't see calico-typha pods created, nothing is changed.
Steps to Reproduce (for bugs)

using kops edit cluster configuration:
kops edit cluster
update calico section and append with typhaReplicas: 3 to enable calico-typha per kops/calico docs
run rolling update of the cluster

Context

We have on premise kubernetes cluster and we are having cases when we have more than 50 nodes in the cluster. For those cases we are seeing network related issues.
Your Environment

Calico version
v3.9.5
Orchestrator version (e.g. kubernetes, mesos, rkt):
 Kubernetes v1.16.9
Operating System and version:

NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
VERSION_CODENAME=stretch
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/```

Hi @vladh91, sorry for the delay! Which version of kops are you using?

Sounds like this is more than likely a kops code or docs bug rather than a Calico bug

Close this issue. @vladh91 you can reopen if you are certain it is a Calico bug.


Updates

Docs Build status updates of commit 3d2276b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamics-gp/financials/AnalyticalAccounting.md
:warning:Warning
View
Details

dynamics-gp/installation/SystemSetup.md
:warning:Warning
View
Details

dynamics-gp/distribution/Invoicing.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/invoicing-part-2.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/invoicing-part-3.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/invoicing-part-4.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/manufacturing-setup-part-1.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/ProjAcctAdministration.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/ProjAcctCostManagement.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/purchase-order-processing.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/purchase-order-processing-part3-receipts.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/purchase-order-processing-part6-utilities.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/sales-order-processing.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/sales-order-processing-part3-allocation-fulfillment-purchasing.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/sales-order-processing-part5-inquiries-reports.md
:white_check_mark:Succeeded
View

dynamics-gp/distribution/sales-order-processing-part6-utilities.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/analytical-accounting-part3.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/BankReconciliation.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/CashFlowManagement.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/fixed-assets.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/PayablesManagement.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/receivables-management.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/receivables-management-part2-transaction-entry.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/receivables-management-part3-transaction-activity.md
:white_check_mark:Succeeded
View

dynamics-gp/financials/receivables-management-part4-inquiries-reports.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.

dynamics-gp/financials/AnalyticalAccounting.md

Line 421, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'media/b5a63aac5022ab48480513880201f344.jpg'.

dynamics-gp/installation/SystemSetup.md

Line 10192, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'media/RPTSCH0001.PNG'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Feature/589 task level notes

Changes
Add optional relationship between Task and Note
We want to add task-level notes.
We are going to use the existing Note model with an optional relationship to a Task.
Add new note from task page
This allows users to add a new note from the task page which is associated to the task.
For now, the only difference is that the note has a task ID. The following commits will update any behaviours.
Add method to distinguish task-level note
Add a helper method so that we can easily find out if a note is a task level note.
Users get redirected to the task page after creating a task level note
Users should be redirected back to the task page where they started adding their task level note.
Update the redirect in the controller so that it is variable backed on the note type.
Only show project level notes on the notes page
Currently, we show all notes on the notes page. Now that we have task level notes, we want to only show project level notes on the notes page.
Add a scope for project level notes, and surface these only.
Show task level notes
We want to display the task level notes on the page of the task itself.
Users can edit task level notes
Add a link to edit notes onto the task page. Update the redirect destination to match note creation.
Users can delete task level notes
Users should be redirected to the task page when deleting a task level note, as they are when creating or updating it.
Make sure the back links work for notes and task level notes
We want to make sure that the "Back" links take the user to the correct place:

The notes index page when returning from editing or creating a project level
note.
The individual task page when returning from editing or creating a task level
note.

Add a helper so that we can change the destination based of the type of note.
Checklist

[ ] Attach this pull request to the appropriate card in Trello.
[x] Update the CHANGELOG.md if needed.

 Add task level notes


Is this a Typo error

In document https://docs.microsoft.com/en-us/azure/security/azure-security-disk-encryption-prerequisites
Under Supported operation systems it mentions "For Windows Server 2008 R2, you must have .NET Framework 4.5 installed before you enable encryption in Azure."
Should it be "From Windows Server 2008 R2" instead of "For Windows Server 2008 R2"?

I think current version is correct.
Windows Server 2012+ was shipped with .NET Framework 4.5 by default. For 2008 R2 one had to install it.


Update Flutter version to 3.16.2

This ensures latest security fixes and framework updates.
[changelog]
updated: fvm version to 3.16.2

This will only update the example project, this won't force 3.16.2 onto package consumers WHICH is good. We cannot force all projects to be on the latest flutter for various reasons.


Incomplete or empty template error with theme/partials/article_metadata.html

Hi,
I'm exploring if I can migrate my blog from jekyll to hugo. Your template looks awesome but I'm getting an error that I'm hoping you have some clue as to what could be causing it.
The repo for my jekyll blog is at https://github.com/lcolladotor/lcolladotor.github.com. I can successfully (or so it would seem) run hugo import jekyll . ../hugoblog/ (when at the cloned repo). Now, when I try to use hugo-academic as the theme I get the following error:
$ hugo server --theme=academic
Started building sites ...
ERROR: 2017/01/19 00:50:57 general.go:236: theme/partials/article_metadata.html is an incomplete or empty template
Built site for language en:
0 draft content
0 future content
0 expired content
135 regular pages created
167 other pages created
0 non-page files copied
190 paginator pages created
150 tags created
13 categories created
total in 207 ms
Watching for changes in /Users/lcollado/Dropbox/Code/hugoblog/{data,content,layouts,static,themes}
Serving pages from memory
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to stop

I do not get that error when using themes/academic/exampleSite/* as described in the docs for your theme. If I diff the two article_metadata.html files, they are identical. So it doesn't sound to me like it's incomplete or empty as the error describes. My main guess is that hugo import jekyll is not working completely properly. But I don't know if that's the case or something else is going on. And like I said, I'm hoping you have an idea as to what is going on.
Thanks,
Leo

$ hugo version
Hugo Static Site Generator v0.18.1 BuildDate: 2016-12-29T12:12:41-05:00

Good to see that you're using the latest version of Hugo. If you can provide a link to your Hugo repo aswell, someone might be able to check for any obvious file structure issues.
Your best bet is probably posting this on the Hugo Forums though. Also, there are many related posts there on this topic of Jekyll conversion, which might be helpful.

Ok, so it looks like a jekyll conversion issue and not something related to the hugo-academic theme then?
Thanks! I'll post at the Hugo Forums.

It appears it might be a general Hugo problem with your file structure and or how you installed the Academic theme, probably not directly related to the Jekyll conversion but possibly. It would be helpful to see your Hugo repo for checking those things.

Ok. Here is the exact sequence of commands that reproduces the problem:
Un-evaluated code:
git clone git@github.com:lcolladotor/lcolladotor.github.com.git
hugo import jekyll lcolladotor.github.com hugoblog
cd hugoblog
git clone https://github.com/gcushen/hugo-academic.git themes/academic
hugo server --theme=academic
hugo version
git clone https://github.com/spf13/herring-cove.git themes/herring-cove
hugo server --theme=herring-cove

Evaluated code
$ git clone git@github.com:lcolladotor/lcolladotor.github.com.git
Cloning into 'lcolladotor.github.com'...
remote: Counting objects: 1027, done.
remote: Total 1027 (delta 0), reused 0 (delta 0), pack-reused 1027
Receiving objects: 100% (1027/1027), 12.31 MiB | 6.66 MiB/s, done.
Resolving deltas: 100% (519/519), done.
Checking connectivity... done.
$ hugo import jekyll lcolladotor.github.com hugoblog
Importing...
WARN: 2017/01/19 10:35:12 import_jekyll.go:390: Failed to parse filename '.DS_Store': filename not match. Skipping.
WARN: 2017/01/19 10:35:12 import_jekyll.go:390: Failed to parse filename '.DS_Store': filename not match. Skipping.
Congratulations! 137 post(s) imported!
Now, start Hugo by yourself:
$ git clone https://github.com/spf13/herring-cove.git hugoblog/themes/herring-cove
$ cd hugoblog
$ hugo server --theme=herring-cove

$ cd hugoblog/
$ git clone https://github.com/gcushen/hugo-academic.git themes/academic
Cloning into 'themes/academic'...
remote: Counting objects: 1232, done.
remote: Compressing objects: 100% (54/54), done.
remote: Total 1232 (delta 14), reused 0 (delta 0), pack-reused 1175
Receiving objects: 100% (1232/1232), 2.48 MiB | 0 bytes/s, done.
Resolving deltas: 100% (680/680), done.
Checking connectivity... done.
$ hugo server --theme=academic
Started building sites ...
ERROR: 2017/01/19 10:35:32 general.go:236: theme/partials/article_metadata.html is an incomplete or empty template
Built site for language en:
0 draft content
0 future content
0 expired content
135 regular pages created
167 other pages created
0 non-page files copied
190 paginator pages created
150 tags created
13 categories created
total in 275 ms
Watching for changes in /Users/lcollado/Dropbox/Code/hugoblog/{data,content,layouts,static,themes}
Serving pages from memory
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to stop
^C
$ hugo version
Hugo Static Site Generator v0.18.1 BuildDate: 2016-12-29T12:12:41-05:00

and well, doesn't work:

Note that:
$ git clone https://github.com/spf13/herring-cove.git themes/herring-cove
Cloning into 'themes/herring-cove'...
remote: Counting objects: 159, done.
remote: Total 159 (delta 0), reused 0 (delta 0), pack-reused 159
Receiving objects: 100% (159/159), 6.56 MiB | 3.24 MiB/s, done.
Resolving deltas: 100% (62/62), done.
Checking connectivity... done.
$ hugo server --theme=herring-cove
Started building sites ...
Built site for language en:
0 draft content
0 future content
0 expired content
135 regular pages created
167 other pages created
0 non-page files copied
0 paginator pages created
150 tags created
13 categories created
total in 131 ms
Watching for changes in /Users/lcollado/Dropbox/Code/hugoblog/{data,content,layouts,static,themes}
Serving pages from memory
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to stop

does seem to work:

I don't see console errors for both themes.
Since the above code reproduces the problem and it's all public, I don't think that you need a repo with the contents of hugoblog. If you think otherwise, I'll upload them to a gist.
Best,
Leo

I ask for your Hugo repo because there are many important things that I cannot see here. For example, it appears that you didn't follow all the installation steps for Academic that are in the Github Readme. Academic is a framework rather than just a theme, so you need to follow Academic's installation guide and copy/edit the config config.toml etc. from the example site.

Ahhhhh... I see. You are referring to https://github.com/gcushen/hugo-academic/blame/master/README.md#L32. I'm obviously new to hugo and I didn't understand why cloning the theme wasn't working (like it works for other themes). I see that's why you refer to Academic as a framework.
I also didn't understand why you wanted the Hugo repo, since the commands above would just give you that. But I see now that there's a lot of editing config and content files to get Academic to display the content, making sense why you would want to see the Hugo repo (as it wouldn't be easy to reproduce all my edits).
I've played a little bit more after reading in more detail http://gcushen.github.io/hugo-academic-demo/post/getting-started and looking at the exampleSite files. Looks like I can get it to work.
I suggest highlighting that Academic is a framework, not a theme which requires editing configuration files in the README.
I'll close this issue since I believe I can get Academic to work properly now.
Best,
Leo

I just wanted to let you know that I was able to get everything to work. Thanks!
See https://github.com/lcolladotor/lcolladotor.github.com/commit/a460f5502343800b0de5f71f6c652a5f81c3b165 for the details and the live website at http://lcolladotor.github.io/

@lcolladotor great to hear that you got it working! I just took a quick look at your site and wow... nice to see a site with so much interesting content! Since you have so much content and you're using a lot of the advanced features of Academic, I would love to hear from you if you have any more suggestions or feedback - just open an issue on Github, tweet me at GeorgeCushen, or send an email via the link on my website :)


'RandomModel' object has no attribute 'action_spec'

Hi, I am having this error when running with a RandomAgent.
My code :
[...]
agent = RandomAgent(
    states=environment.states,
    actions=environment.actions
)
[...]

Stacktrace :
Traceback (most recent call last):
  File "/Users/Deathn0t/Desktop/tensorforce-0.4.3/tests/rdm_mathfun.py", line 48, in <module>
    # Create the runner
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/agents/random_agent.py", line 73, in __init__
    batching_capacity=batching_capacity
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/agents/agent.py", line 80, in __init__
    self.model = self.initialize_model()
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/agents/random_agent.py", line 85, in initialize_model
    batching_capacity=self.batching_capacity
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/random_model.py", line 54, in __init__
    reward_preprocessing=None
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 217, in __init__
    self.setup()
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 290, in setup
    independent=independent
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 1193, in create_operations
    independent=independent
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 1019, in create_act_operations
    deterministic=deterministic
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorflow/python/ops/template.py", line 464, in __call__
    result = self._call_func(args, kwargs)
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorflow/python/ops/template.py", line 406, in _call_func
    result = self._func(*args, **kwargs)
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/random_model.py", line 62, in tf_actions_and_internals
    action = self.action_spec[name]
AttributeError: 'RandomModel' object has no attribute 'action_spec'

originally defined at:
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 245, in setup
    self.setup_components_and_tf_funcs()
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorforce/models/model.py", line 546, in setup_components_and_tf_funcs
    custom_getter_=custom_getter
  File "/Users/Deathn0t/anaconda3/lib/python3.6/site-packages/tensorflow/python/ops/template.py", line 153, in make_template
    **kwargs)

Just fixed it, due to a minor typo.


Add autoCapitalize prop

Similar to autofocus, placeholder and maxLength that are passed to the input field, it would be nice to have an autoCapitalize prop (and maybe some other input props?).

IMO auto capitalize is something which should be handled by the parent component itself and you can set the state after capitalizing and pass it to react tags.

I meant it more as a way to control the input methods on the field, specifically to disable autocapitalize on mobile devices’ software keyboards, more than to do some processing on the input which can be done later as you suggest.
In general I think you should be able to control all valid properties for the input field.

On Aug 31, 2018, at 1:57 PM, Aakansha Doshi<EMAIL_ADDRESS>wrote:
IMO auto capitalize is something which should be handled by the parent component itself and you can set the state after capitalizing and pass it to react tags.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I get your point but I am not very sure if we should add autocapitalize prop, @prakhar1989 what do you think ?


Free BigMac Coupons not present anymore.

At first, thanks for your project, i really like it and i implemented your website into my private discord bot (i hope its fine). But i wanted to ask if there is a reason for the free Big Macs not being present anymore. Did they patch it?
Thanks for your beautiful project tho!
Would contribute but they only language i can really read is python :)

Hey, glad to hear you like my project.
No problem, feel free to use my site however you like. Note, however, that I can't guarantee you that I won't break something in the future that might affect your bot.
The free coupons were unfortunately just a short-lived promotion that has been over for just under a week. I will work on increasing the number of coupons further though.
Python is also a cool language, but unfortunately I had never really gotten into it in depth.


Port isn't changed when switching account types

Describe the bug
With PR #5085 merged it's possible to start account setup, but then before finishing the setup go back and change the account type. This will keep the original port number.
To Reproduce
Steps to reproduce the behavior:

Go to settings and click "Add account" or use the onboarding flow to add an account
Enter email address and password for a domain that needs to be manually configured
Select "IMAP"
Enter correct server settings and press "Next"
Use back button twice to go back to the account type selection screen
Select "POP3"
Notice that the 'Port' input field still contains the port configured in step 4

Expected behavior
Use the default port number for the selected account type.
Environment (please complete the following information):

K-9 Mail version: 1259d372b6ae7f2f9cfdc5cdbfd373f0a0691d8b

I've done some testing of this and found it applies to other fields as well, e.g. username/password. Effects both incoming and outgoing.
It's due to the way account settings are saved at each step and then restored upon returning to each screen.
I could reset the port every time you go from AccountSetupAccountType -> AccountSetupIncoming but I don't think that's a complete solution.
In my opinion if you make some changes on the incoming/outgoing setup and then go back to account type selection, then go into the incoming screen again it should not have any of your changes and instead have the defaults for all fields like the first time you navigated to the incoming screen. I'm currently working on how to achieve this.

I've done some testing of this and found it applies to other fields as well, e.g. username/password. Effects both incoming and outgoing.
It's due to the way account settings are saved at each step and then restored upon returning to each screen.
I could reset the port every time you go from AccountSetupAccountType -> AccountSetupIncoming but I don't think that's a complete solution.
In my opinion if you make some changes on the incoming/outgoing setup and then go back to account type selection, then go into the incoming screen again it should not have any of your changes and instead have the defaults for all fields like the first time you navigated to the incoming screen. I'm currently working on how to achieve this.


I started thinking wishing hono/jsx/dom would be more compatible with React.
Using a bundler such as Vite to create an alias with hono/jsx/dom in react will work with some React libraries.
resolve: {
  alias: {
    react: 'hono/jsx/dom'
  }
}

For example, React DnD works: https://github.com/usualoma/hono-jsx-dnd
However, when I tried other UI libraries, they all failed to work.

react-toastify
spinners-react
Radix UI Primitives

The errors will occur if the following are not exported:

createRef
Fragment
forwardRef
Children
etc

Also, even if there is an API, the behavior is different, resulting in an error.
However, it would be great if these libraries were available so that more people could use hono/jsx.

@usualoma
How do you think about this thing? Now, I'm trying to create a Twitter clone with HonoX. I'm referring to the following repository:
https://github.com/Micheal-Earl/mitwi
It is built with Fresh, a preact-based framework on Deno. The interesting point is that it uses React libraries such as react-toastify and spinners-react. The project makes the alias react to preact. I think this is a good idea, and I noticed that we can do the same thing with hono/jsx/dom.
I think that project is a good reference. If we can make the same functions with that project, Hono/HonoX will be used by more developers.

However, I think there is an option not to do this, maybe just keep the hono/jsx/dom implementation to a minimum and use React when creating full-stack pages with HonoX or other UIs. We should discuss which way to go.

Yes, let's try a little work. Please wait a moment!

Work in progress... #2553

I second this.
One of the benefits of using  React TSX/JSX is the ecosystem.
Is it possible not to focus on compatibility, and instead just straight up figure out how to use it directly? Or at least as a first party plugin?

I also noticed this. It’s still hard to make Cloudflare pages and next.js works together.
It’s good that hono(x) provide a new way.
I tried using resolve.alias from vite/rollup to replace react with hono/jsx.
But I tried every react packages they won’t work.(can’t find module).
And I don’t know why, looks like hono/jsx has every hook those packages require. will leave this question to someone more competent.

Ah i see, looks like current solution is just make hono serves react component on static pages but no hono SSG support…
So, react packages will not works with honoX, am I correct?

This was fixed though there may be some backlogs. So closing now. If you have any questions, please write them on Discussions. Thank you.


Slow down downloads

Provide us a use case of the feature
My account got disabled after using instaloader without prior warning, apparently due to bulk loading of data (violation of community guidelines). Not clear yet, if the reactivation works.
Describe the solution you'd like
The documentation should warn about the danger of using the --login option and provide a means to slow down the download in order to avoid getting flagged (I don't know the thresholds, e.g. data size or number of downloads within a given time)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
How do you achieve the here-described goal without the feature you are requesting?
If the feature request is accepted, would you be willing to submit a pull request?
No

Additional context
I wanted to download the profile of my daughter, since her account has been hacked and I wanted to save at least the content. I accidentally used the "@" option, e.g. started downloading the content of followers. No recovery methods work and impossible to contact instagram/meta, but that's a different story.

Sorry, I just see that it has already been discussed, see https://github.com/instaloader/instaloader/issues/828 and https://github.com/instaloader/instaloader/issues/1817

Just got an account banned too, I'm unsure where I read it, but I'm pretty sure it was common knowledge not to use your main account. Always created burners for this and even then it's still hit or miss when Instagram might ban/restrict your account, they used to be light then, you'd only need to provide a phone number and a code sent to it, now they asked for a picture of myself holding a paper with some numbers my name and the @ of the account, ultimately account got permanently banned because I refuse to do that.
I think that even if there'd be some way to limit the down the downloads, which Instaloader already does, it's still unknown how Instagram / Meta can tell that you're using a third party app, sometimes I was able to download thousand of pictures without any issues, other days I'd get banned after less than a hundred pictures. There isn't really a way to prevent those bans unless one knows for certain how Instagram identifies your third party app.

Apparently, my account has been disabled permanently. This shows that the "investigation" by meta is very superficial and did not look at all into my information that the account had been hacked (which I added to the picture that I had to upload). Well, not really a problem for me, as I did not post any contents and did not have any followers, since my main objective was to see from time to time what my daughter was posting. But it shows that instaloder should definitely add a big warning sign to the --login option.

Instaloader already limits the download rate, and you can even experiment with overriding the rate controller if the default behavior does not fit your needs.

NEED URGENT HELP?!!
NOTE:MESSAGE ONLY THIS ACCOUNT
#🇬🇧Expert Here To Assist In Any Cyber Issues General_Hacking_Recovery_Spy_Blackmail_Stolen,Lost BTC_Hacked Phones ☎ 📥
🌎Facebook hacking - recovery
🌎Instagram hacking - recovery
🌎Snapchat hacking - recovery
🌎Lost money(investment scams) recovery
🌎Cheating partner spy (online)
🌎Crypto wallet hacking
🌎Phone hacks📱
🌎Message hacks & tweaks
For swift response send a message to my social media accounts, we are active 24/7 to solve all your Online ETHICAL HACKING issues
INSTAGRAM 📥 spygency.1
EMAIL 📧<EMAIL_ADDRESS>


ISPN-14435 Backwards compatibility broken with InvalidMagicIdException

https://issues.redhat.com/browse/ISPN-14435

Rerunning CI, looks like it got the OOM as well 😢

Is testDistExecPutGet([D]) – org.infinispan.client.hotrod.ExecTest related ?

@tristantarrant it is not related. It looks like a deadlock caused by the script test-put-get-dist.js being executed in all nodes at the same time.
Caused by: org.infinispan.util.concurrent.TimeoutException: ISPN000299: Unable to acquire lock after 10 seconds for key dist-key and requestor GlobalTransaction{id=60, addr=ExecTest-NodeA, remote=true, xid=Xid{formatId=131077, globalTransactionId=00000000000000000000FFFF0A00956600008A7D63BC12200000007E31,branchQualifier=00000000000000000000FFFF0A00956600008A7D63BC12200000007F0000000000000000}, internalId=-1}. Lock is held by GlobalTransaction{id=59, addr=ExecTest-NodeB, remote=false, xid=Xid{formatId=131077, globalTransactionId=00000000000000000000FFFF0A00956600008A7D63BC12200000007A31,branchQualifier=00000000000000000000FFFF0A00956600008A7D63BC12200000007B0000000000000000}, internalId=-1}

Merged, thanks


Method $.isNotEmpty() is not available for collection

Please, restore $.isNotEmpty() for collection, because they are used at tests

@julyaaaaa Class ElementsCollection already has method isEmpty(). Isn't it enough?
P.S. I insist that using such methods in tests is a bad practice.

Some cases, it is need to check that some collections are not empty and method isNotEmpy() was a convenient solution for such cases.


Add Proxy Support

Hello, I just found this crate this morning and consider use it for my project recently. But after quick skim it seem like no proxy support (which is necessary part for me). So I try to add it.
I'm not familiar current codebase so some decision may be little weird. Here is something I'm not so sure:

Custom Proxy struct as thin wrapper of reqwest::Proxy, because...

Seem this crate try to hide reqwest as implement detail, so I follow that.
Some request::Proxy methods may not suit for this case (e.g., request::Proxy::no_proxy())

Proxy::new() return an Option but not Result, because ...

I'm not sure which Error type should be used for Client creation phase. So just use Option for now but this may not good enough.

How your feel? Please let me know. Thanks.
BTW, thanks for your cool project!

CAUTION: I believe this code can works but currently it only pass cargo check and I'm not actual run it yet. Because I don't have test environment right now. Feel free to test it by youself or I will test it later.

I test it today manually and it works.
User can create a client with proxy like this:
use graph_rs_sdk::{
    identity::ConfidentialClientApplication, GraphClient, GraphClientConfiguration, Proxy,
};

fn main() {
    const TANENT_ID: &str = "xxx";
    const CLIENT_ID: &str = "yyy";
    const CLIENT_SECRET: &str = "zzz";

    let confidential_client_application = ConfidentialClientApplication::builder(CLIENT_ID)
        .with_client_secret(CLIENT_SECRET)
        .with_tenant(TANENT_ID)
        .build();

    let proxy = Proxy::new("http://myporxy.com:3128").unwrap(); // <- here

    let graph_client: GraphClient = GraphClientConfiguration::new()
        .client_application(confidential_client_application)
        .proxy(proxy)  // <- here
        .into();

    // do something with graph_client ...
}

I test it today manually and it works.
User can create a client with proxy like this:
use graph_rs_sdk::{
    identity::ConfidentialClientApplication, GraphClient, GraphClientConfiguration, Proxy,
};

fn main() {
    const TANENT_ID: &str = "xxx";
    const CLIENT_ID: &str = "yyy";
    const CLIENT_SECRET: &str = "zzz";

    let confidential_client_application = ConfidentialClientApplication::builder(CLIENT_ID)
        .with_client_secret(CLIENT_SECRET)
        .with_tenant(TANENT_ID)
        .build();

    let proxy = Proxy::new("http://myporxy.com:3128").unwrap(); // <- here

    let graph_client: GraphClient = GraphClientConfiguration::new()
        .client_application(confidential_client_application)
        .proxy(proxy)  // <- here
        .into();

    // do something with graph_client ...
}

Nice, i'll take a look at your PR and review it hopefully within a couple of days but it may be a little longer. Thanks for taking the initiative.

I'm not familiar current codebase so some decision may be little weird.

The fact that you just found this crate and were able to find where to add the proxy support and the features for socks means your doing good haha.

  * Some `request::Proxy` methods may not suit for this case (e.g., [`request::Proxy::no_proxy()`](https://docs.rs/reqwest/latest/reqwest/struct.Proxy.html#method.no_proxy))

Yeah that one im not sure what the use case would be. But regardless I don't think... its an issue? I could see this being a use case if someone wants to proxy specific requests to one proxy while others may go to a different proxy. So they setup an exclusion list of proxy servers for some requests. I've havn't used proxies much so thats just a guess on my end. Regardless I think its fine that they can do that.

* `Proxy::new()` return an `Option` but not `Result`, because ...

  * I'm not sure which Error type should be used for Client creation phase. So just use `Option` for now but this may not good enough.

Yeah I think this one is solved by allowing the user to pass the reqwest::Proxy object instead as I mentioned in the pr review. That way the user has to deal with any issues regarding the proxy before adding to the configuration.

BTW, thanks for your cool project!

Thanks! I appreciate it.

Thanks for suggestion. I force push a new commit to fix all issues you list here.
Here is new examples:
use graph_rs_sdk::{
    identity::ConfidentialClientApplication, GraphClient, GraphClientConfiguration, http::Proxy,
};

fn main() {
    const TANENT_ID: &str = "xxx";
    const CLIENT_ID: &str = "yyy";
    const CLIENT_SECRET: &str = "zzz";

    let confidential_client_application = ConfidentialClientApplication::builder(CLIENT_ID)
        .with_client_secret(CLIENT_SECRET)
        .with_tenant(TANENT_ID)
        .build();

    let proxy = Proxy::all("http://myporxy.com:3128").unwrap(); // <- here

    let graph_client: GraphClient = GraphClientConfiguration::new()
        .client_application(confidential_client_application)
        .proxy(proxy)  // <- here
        .into();

    // do something with graph_client ...
}

This new commit also change feature flag socks-proxy to socks to match how you mapping reqwest feature names to local feature names.

@visig9 Released in crate version 2.0.1 https://crates.io/crates/graph-rs-sdk/2.0.1


@7.5.1 - devdeps, test grid

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.078%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
67

Relevant Lines:
67

💛  - Coveralls


Using column references in json_extract_path doesn't work

Elixir version
1.16.2
Database and Version
PostgreSQL 14.9
Ecto Versions
ecto: 3.11.2, ecto_sql: 3.11.3
Database Adapter and Versions (postgrex, myxql, etc)
postgrex: 0.18.0
Current behavior
json_extract_path or [] variant doesn't support referencing columns from other tables. The Ecto query below fails to compile:
create table(:test_posts) do
  add(:text, :text)
  add(:user_id, references(:users))
end

create table(:test_users) do
  add(:post_stats, :jsonb)
end

from(u in TestUser, join: p in assoc(u, :posts), select: %{stat: u.post_stats[p.id]}) |> Repo.all

Expected behavior
It would be very convenient if we could pass references to other columns in json_extract_path. I'm not sure about other DBs but for PostgreSQL I can see that json_extract_path transforms to this SQL:
users.post_stats #> '{"my", "path", "inside", "json"}'

Because it uses such syntax of array (as a '{}' string) it's clear why it doesn't work today. However, PostgreSQL supports another syntax where it's possible to reference columns:
users.post_stats #> array['my', 'path', test_posts.id, 'inside', 'json']::text[]

I'm wondering if anything stops us from using the array[] syntax and allow referencing columns from other tables? If no, I can try to work on the fix.

Hi,
I think there is a good chance we can do this. The main things I can think of that we'd need to be careful about:

Does it work for both json and jsonb. Right now json_extract_path is agnostic between those types and we probably want to keep it that way.
Does it work for the same postgres versions as the array string.
We do some validation in Ecto to make sure the extraction path is valid by comparing against the fields in the embedded schemas. So we probably have to make some adjustments to ignore the validation if a column is provided.

One more thing we should probably think about is dynamic paths.
Since the query bindings are compile-time constructs I don't think we can allow them in runtime evaluated paths unless we use dynamic. We might want to evaluate how large a change that would be.
For example if it was prohibitively large then we'd need to decide if we want to allow bindings in compile-time paths only even though users would probably really want them in runtime paths.


External Resources Styles effect Grafana's elements

When using some external css via  External Resources it sometimes overrides Grafana components.
For example, using Materialize CSS link https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0/css/materialize.min.css
Results in the following 'bug' in Grafana (it affects other elements as well)

But when i copy-paste the content of the CSS lib (non-minified version) into the Styles editor it works as expected.
Grafana v10.2.2

@tomikos External CSS are loaded in the Global context. CSS Styles in the Editor are only used inside the dynamic Text panel.
We don't control how external CSS is implemented and it may override Grafana styles with the same names.

@tomikos External CSS are loaded in the Global context. CSS Styles in the Editor are only used inside the dynamic Text panel.
We don't control how external CSS is implemented and it may override Grafana styles with the same names.

even when loading CSS libs from the JavaScript editors?

@tomikos Any libraries are loaded in the Global context.


Dapplo.ActiveDirectory package does not publish Dapplo.Log dependency

This causes issues in #4 when trying to load Dapplo.ActiveDirectory inside a PowerShell cmdlet.

This confuses me, according to https://www.nuget.org/packages/Dapplo.ActiveDirectory the dependency is specified.

Did you manage to solve this on your side?

We put a pause on PowerShell cmdlet development and will pick back up in Q1 2020.  Have to get revenue generating / cost saving projects done before end of year.
Plan is to hit PowerShell cmdlet development hard in Q1.  Will follow up then.

Okay, just let me know when you have time to look at it, and get back to me.


Fix find_site with custom public cms path.

When having multiple sites under the same hostname, find_site will do
some regex to find the correct site by path. This regex does not take
into account a custom public cms path.

this change is fantastic! @GBH any chance to merge and release new gem?
This seems to get similar outcome as comfy-blog - though comfy-blog does not currently work - so it's a double win!

Merged! We did it guys!


imporve grafana yamlfile

Signed-off-by: xin.li<EMAIL_ADDRESS>Please provide a description of this PR:
Please check any characteristics that apply to this pull request.
Imporve grafana yamlfile

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

this is autogenerated from manifests/addons/ script

Understood, thanks


Support recursive template extension.

From the django 1.9 release
notes:

Django template loaders can now extend templates recursively.

...

Django template loaders have been updated to allow recursive template
extending. This change necessitated a new template loader API. The old
load_template() and load_template_sources() methods are now
deprecated.

Prior to this patch, when a template is recursively extended the latest
template in the template loaders is displayed regardless of the template
origin since the proper template can no longer be disambiguated by
template_name.

Current coverage is 76.63% (diff: 19.04%)

Merging #885 into master will decrease coverage by 0.36%

@@             master       #885   diff @@
==========================================
  Files            30         30
  Lines          1635       1648    +13
  Methods           0          0
  Messages          0          0
  Branches        244        245     +1
==========================================
+ Hits           1259       1263     +4
- Misses          302        311     +9
  Partials         74         74

Powered by Codecov. Last update 637b0b7...aff9e3e


TOML local date not supported

Acc. to https://toml.io/en/v1.0.0#local-date a local date looks like this:
ld1 = 1979-05-27
However, the TOML Viewer & Editor at https://guifier.com/toml reports an error
Error: SyntaxError: Expected "T" but "\n" found.
Expected behavior: the local date is shown and can be edited.

Hi @MoritzRitter
Thank you for helping finding these issues and bugs. really appreciate it
this should be an issue in the toml parser library we are using.
I have to debug it and see exactly whats the cause of this issue.
I will inform asap

The issue arises because the toml package on npm is no longer maintained and only supports TOML specification version 0.4.0, which is outdated.
I will try to find an alternative library and replace it.

Hi @MoritzRitter,
I've replaced the TOML library with smol-toml, which supports TOML v1.0.0. Additionally, I've implemented a Date field type, allowing the TOML string to be rendered as a date input.

You can check it out here:
https://guifier.com/toml/
It now successfully parses the toml date values.

I will check that asap

Currently, when editing the date, it gets parsed into this format:

The smol-toml library includes the time by default when handling dates. Based on their documentation, I couldn’t find a way to adjust the parsing behavior to output this specific date format:

Does this work for you?

Thanks for checking! Let's put it like this: I would need a local date without timezone info etc. And this is not what we have at the moment. But I can work around it. Much better than a parsing error!

Got it! Since this is related to the smol-toml library, I’ve opened an issue in their repository. Hopefully, they already have this feature or are willing to implement it.

Hi @MoritzRitter I fixed the issue
now it works as expected even if the date is edited from the UI

Hi @maliknajjar Thanks for the update. There seems to be a new problem with the preservation of multi-line basic strings (acc. to https://toml.io/en/v1.0.0#string):
When I add such a string like in this example:

then it is already now displayed in the widget omitting the new lines.
And when I then edit the date (or any other object) using the widgets on the right, then the string is converted to a basic string:

While the content is probably still the same, this seems not to be the behavior that the user wants. Would you agree?

Hi @MoritzRitter, I created a seperate issue for this
https://github.com/maliknajjar/guifier/issues/7
you can follow it there


build: add dev helmfiles

Description
What this PR does / why we need it:
This PR introduces dev versions of the helmfiles for quickstart and HA ratify.
The dev versions will be updated as code changes on the main branch. All documentation will point to the non dev versions to be compatible with the previous release. At release time, the prod versions will be synced with the dev version so they are compatible with the new release.
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1010
Fixes #998
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] Ran helmfiles locally

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

TODO: add document on how/when to use dev version of the helmfiles


CodeMirror Options plugin incompatibility

The CodeMirror Options plugin has an option to make syntax highlighting consistent between preview and edit mode with the Editor Syntax Highlight plugin. This unfortunately makes Code Block Enhancer (and Code Copy) incompatible with it.
I've opened an issue in all respective repos, hopefully you three can find a solution to this.

It may be that CodeMirror Options plugin rewrites the logic of rendering markdown code blocks, so it will not take effect.


Deleted relevant code in Ribasim python and core/src

Fixes #1191

I feel like the name of this PR can be more descriptive than the description of the first commit (:


Possibility to avoid adding system-out to the JUnit report

As integration tests can give a quite cumbersome system-out, if we execute a large number of tests the generated XML can exceed the memory limit. There should be the possibility to not populate the system-out but only the error node

same issue

@vyendn3 @lhimo
Any solution to avoid prints while create jUnit report?


⚠ Processors has degraded performance

In 2011c88, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 138 ms

Resolved: Processors performance has improved in 14e9c49.


HANS-298: HL7v2 improvements stacked

I suspect it's going to be easier to scrap this branch and rebuild it on top of the new xxx-make-tests-simply-runnable, but otherwise this looks fine to me.


Peer banning overload that doesn't have banning time parameter

Peer banning is used 95% of the time with default banning time from connection manager. That introduces dependency on connection manager in every component that uses banning.
We can simplify design of a lot of components a lot if we add an overload to peer banning which won't accept banning time and use default banning time instead.

issue resolved


Changes in UI of Profile Page #391,#383

Fixes #391, #383.

This fixes 383 too. Right?

Yes.

@syedjahangirpeeran There are a few build errors


Move Kyma-dashboard to busola

Description
Prepare simplification to improve release process for busola by unification of kyma-dashboard repository with busola.
Reasons

One release instead of two
One busola-web image with different configuration instead of 4 images in total
Bugs for kyma-dashboard can be catched at busola development instead when bumping busola in kyma-dashboard

Execution

[x] Add ability to configure different path for configuration - https://github.com/kyma-project/busola/issues/3299
[x] Add dockerfile to build busola with all configuration inside. Proposal: create kymadirectory in busola - https://github.com/kyma-project/busola/pull/3321, https://github.com/kyma-project/busola/pull/3332
[x] Add github actions to build new image type
[x] Add integration tests from kyma-dashboard - https://github.com/kyma-project/busola/pull/3333
[x] Allow adjusting environment in busola k8s kustomize - https://github.com/kyma-project/busola/pull/3344
[x] Adjust environments to pickup correct environment
[x] Add documentation https://github.com/kyma-project/busola/pull/3347, https://github.com/kyma-project/busola/pull/3402
[x] Add test to check k8s configuration covered by smoke tests
[x] Cleanup old unneeded files https://github.com/kyma-project/busola/pull/3404

Cleanups and known issues

[x] When there is no yaml for specific resource, busola by default serves js and consume it. Which results in high cpu usage and many warnings, errors in console. https://github.com/kyma-project/busola/pull/3373
[x] Unify cypress commands in tests https://github.com/kyma-project/busola/pull/3388, https://github.com/kyma-project/busola/pull/3407
Attachments

Known issues:

When there is no yaml for specific resource, busola by default serves js and consume it. Which results in high cpu usage and many warnings, errors in console.

Sync of Kyma Dashboard: https://github.com/kyma-project/busola/pull/3352

Done


[SPARK-44804][SQL] SortMergeJoin should respect the streamed side ordering

What changes were proposed in this pull request?
In each partition, SortMergeJoin will compute one by one from the streamed side, so we could respect the streamed side ordering to remove unnecessary sort.
For example, when REQUIRE_ALL_CLUSTER_KEYS_FOR_CO_PARTITION is false:
SELECT *
FROM (
    SELECT t1.*, row_number() over(partition by a order by b) rn
    FROM values(1, 1) t1(a, b)
) t1
JOIN values(1) t2(c)
ON a = c
JOIN values(1, 1) t3(d, e)
ON a = d
AND b = e

Before this PR:
AdaptiveSparkPlan isFinalPlan=false
+- SortMergeJoin [a#220, b#221], [d#223, e#224], Inner
   :- Sort [a#220 ASC NULLS FIRST, b#221 ASC NULLS FIRST], false, 0
   :  +- SortMergeJoin [a#220], [c#222], Inner
   :     :- Window [row_number() windowspecdefinition(a#220, b#221 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS rn#218], [a#220], [b#221 ASC NULLS FIRST]
   :     :  +- Sort [a#220 ASC NULLS FIRST, b#221 ASC NULLS FIRST], false, 0
   :     :     +- Exchange hashpartitioning(a#220, 5), ENSURE_REQUIREMENTS, [plan_id=93]
   :     :        +- LocalTableScan [a#220, b#221]
   :     +- Sort [c#222 ASC NULLS FIRST], false, 0
   :        +- Exchange hashpartitioning(c#222, 5), ENSURE_REQUIREMENTS, [plan_id=98]
   :           +- LocalTableScan [c#222]
   +- Sort [d#223 ASC NULLS FIRST, e#224 ASC NULLS FIRST], false, 0
      +- Exchange hashpartitioning(d#223, 5), ENSURE_REQUIREMENTS, [plan_id=104]
         +- LocalTableScan [d#223, e#224]

After this PR:
AdaptiveSparkPlan isFinalPlan=false
+- SortMergeJoin [a#220, b#221], [d#223, e#224], Inner
   :- SortMergeJoin [a#220], [c#222], Inner
   :  :- Window [row_number() windowspecdefinition(a#220, b#221 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS rn#218], [a#220], [b#221 ASC NULLS FIRST]
   :  :  +- Sort [a#220 ASC NULLS FIRST, b#221 ASC NULLS FIRST], false, 0
   :  :     +- Exchange hashpartitioning(a#220, 5), ENSURE_REQUIREMENTS, [plan_id=93]
   :  :        +- LocalTableScan [a#220, b#221]
   :  +- Sort [c#222 ASC NULLS FIRST], false, 0
   :     +- Exchange hashpartitioning(c#222, 5), ENSURE_REQUIREMENTS, [plan_id=98]
   :        +- LocalTableScan [c#222]
   +- Sort [d#223 ASC NULLS FIRST, e#224 ASC NULLS FIRST], false, 0
      +- Exchange hashpartitioning(d#223, 5), ENSURE_REQUIREMENTS, [plan_id=104]
         +- LocalTableScan [d#223, e#224]

Why are the changes needed?
Remove unnecessary sort to improve SortMergeJoin performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

Thanks @wangyum , I have updated the code.

cc @cloud-fan @sunchao


What languages do XLNet support ?

Does this pre-trained model support other languages besides English?

Currently not, but have a look at this issue #3 .
I would really like to see a large multi-lingual model 🤗


Fix link

Codecov Report

Merging #1182 into master will not change coverage.

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   96.92%   96.92%
=======================================
  Files          49       49
  Lines        2279     2279
=======================================
  Hits         2209     2209
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe539ee...356fe18. Read the comment docs.


Fix broken guide links

Fixes a couple broken links in the guides section. The bytepack/IntroToiOSReverseEngineering is completely broken as well (repo no longer exists) but I wasn't sure if its been moved. I can update the link or remove it if someone wants to advise what to do.

Ah, makes sense. In that case, I would suggest either adding a link to the generated site at the top of the README or setting the "website" property on the repo so that the generated site is easier to find. I'll close this PR.


Get a Progress or ProgressReporting object as a return from generate data

Is it possible to change handing the progress from a callback closure passed in the generate function of PDFGenerator to be a return value
for better understanding what I mean I would suggest watching this wwcd session:
Best Practices for Progress Reporting
https://developer.apple.com/videos/play/wwdc2015/232/

Yes, this is a great input! Thank you for that!
Definitely going to take a look at it, as the current progress reporting is pretty bad

Hi there, it's been a while but I hope you are still interested in this feature.
I had to remove the static functions from the PDFGenerator (I wanted to do that anyways) but it should now have an instance of progress available.
Feel free to checkout the branch feature/155-progress-reporting and let me know about your thoughts

I took a quick look at the progress reporting branch and it looks amazing. thank you a lot for this great work.
There is one thing that I would like your advice about:
I noticed that you're using init(totalUnitCount unitCount: Int64) to initialize the Progress sometimes. I also read from the apple documentation before

The initializer is passed the current progress object, if there is one, and the value of the totalUnitCount property is set.

Do you think that might cause a problem while running multiple instances of the builder at the same time?
By the way I personally like to initiate the progress object without any parameters Progress() which will set the parent progress to nil (a longer version would be init(parent parentProgressOrNil: Progress?, userInfo userInfoOrNil: [ProgressUserInfoKey : Any]? = nil)) and then add children through the method func addChild(_ child: Progress, withPendingUnitCount inUnitCount: Int64)

Thats a good question. I just took another look and there is a static factory method  Progress.discreteProgress(totalUnitCount: Int64) where the parent is set to null.

Creates and returns an NSProgress instance with the specified totalUnitCount that is not part of any existing progress tree. The instance is initialized using init(parent:userInfo:) with the parent set to nil.

I just changed all initialiser to use discreteProgress and it seems to work fine.
About the threading issue:
I guess if each TPPDF PDFGenerator runs in it own thread it should not collide. As the framework does not actually provide any async methods for now, this is a responsibility of the user

Alright I will merge this into develop for now and if there are more issues, it can be reopened


[Ben] Job Name case insensitive, letters after @ must be lowercase in email

I must have been high, job doesn't have an email field.


MINOR: port more tests to TopologyTestDriver

Continue the work of #242 , #245 , and #246 by porting the rest of the integration tests that don't use Schema Registry.
The Schema Registry tests will get ported in a later PR.

Trying to compress this process, since we're in the groove of reviewing these tests now. I've ported all the remaining tests, except the SR ones.
I realized this time around that I've been forgetting to remove unnecessary configs, and also forgetting to close the TopologyTestDriver at the end of the tests, so I've gone back and patched the tests I'd already written.

\cc @miguno

@vvcephei : I have an in-progress PR (https://github.com/confluentinc/kafka-streams-examples/pull/235) that adds two new examples, with implementations for Java and Scala, to this repo. I have already begun refactoring them to use the Topo driver, but I'd prefer to pause the PR until you are done with these changes so that I am not duplicating code, get merge conflicts, etc.
Would you mind pinging me once you feel that the test migration (to use topo driver) is completed?  Then I can pick up "my" PR again.

@miguno , sure! Sorry for stirring the pot, but hopefully these changes make maintaining these examples a lot easier.

Ok, it looks like the build might be fixed now. I'm reverting all the junk I've tried to fix it, and we'll see if we get a clean build now.

The build passed! Time to take the money and run...

downstream merge complete.


Add initializer for 'mNoiseFloor'

Add initializer for 'mNoiseFloor'

Initialize class Mac's member variables in its constructor

Codecov Report

Merging #1708 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1708      +/-   ##
=========================================
+ Coverage   66.87%   66.9%   +0.03%
=========================================
  Files         171     170       -1
  Lines       21277   21246      -31
  Branches     2610    2610
=========================================
- Hits        14228   14214      -14
+ Misses       6140    6127      -13
+ Partials      909     905       -4

Impacted Files
Coverage Δ

src/core/mac/mac.cpp
75.23% <100%> (-0.9%)
:arrow_down:

examples/platforms/posix/misc.c
0% <0%> (-66.67%)
:arrow_down:

examples/platforms/posix/random.c
84% <0%> (-12%)
:arrow_down:

src/core/net/netif.cpp
57.64% <0%> (-4.12%)
:arrow_down:

examples/platforms/posix/uart-posix.c
59.55% <0%> (-3.38%)
:arrow_down:

src/core/net/ip6_mpl.cpp
92.3% <0%> (-2.31%)
:arrow_down:

src/core/thread/mle_router.cpp
77.99% <0%> (-1.55%)
:arrow_down:

src/core/common/message.cpp
94.48% <0%> (-1.38%)
:arrow_down:

src/core/net/udp6.cpp
82.85% <0%> (-0.96%)
:arrow_down:

src/core/net/ip6.cpp
54% <0%> (-0.95%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7af1d4...bd9a0f9. Read the comment docs.


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: martinallen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Importing gopacket and doing nothing uses 8.2MB of RES mem

Subject says it all.  Is this by design?  Makes the use of gopacket difficult in resource constrained systems.
To reproduce:
import these packages
"github.com/google/gopacket"
_ "github.com/google/gopacket/afpacket"
_ "github.com/google/gopacket/layers"
_ "github.com/google/gopacket/pcap"
Just sleep in main.  Then run htop and check RES memory.

Known issue, caused by creating a bunch of decoder redirects and enums (mostly the stuff in enums.go, I think)?  Unfortunately, not really fixable without backwards-incompatible changes.  You'll probably get the same just with:
_ "github.com/google/gopacket/layers"

Yikes!  Thank you!  Not sure what the norm here is.  Let me know if someone will close or I should close or leave open as known issue.


Fix APC tests and add APCu support

The APC support has been broken for a while now (see here and here) but since sfAPCCacheTest is often skipped, it's been overlooked.
The issue is that APC has been dropped in more recent versions of PHP and the user cache part of it is now provided by APCu. However, the functions have been changed (eg: apc_get() to apcu_get(), and while there was a compatibility layer for a while it doesn't seem to be maintained anymore. These days one needs to use APC or APCu, often as a requirement by the PHP being used. In other words, sfAPCCache, as is, no longer works in recent versions of PHP where only APCu is available.
This PR fixes the issues with APC inconsistencies when using with negative TTLs, and also adds a new sfAPCuCache that is a drop-in replacement for sfAPCCache. It's pretty minor changes from sfAPCCache, and while it is duplicated code, it's likely one of the cleanest ways to address this without overcomplicating things. sfAPCCacheTest loads the right one according to which extension is present (apc vs apcu).
Lastly, not sure if we should now drop the line bellow allow travis.yml to run the tests with APC (&APCu) again.
https://github.com/FriendsOfSymfony1/symfony1/blob/6f521e9ef9e800c655313a5f21ac3f55552fbcf4/.travis.yml#L36

Error: Class name must be a valid object or a string
(in test/unit/cache/sfAPCCacheTest.php on line 26)

Should be good now. @alquerci You might want to set all APCU_VERSION on docker-compose.yml now to get this to run.

What about the factory configuration to update by developers?
Who is responsible to choose the good APC implementation, the framework or developers?

The choice between apc or apcu always needs to be a deliberate choice by the developer (according to what's available on the environment), just like they could choose to use sfMemcacheCache instead.

What about doing an iteration on the enabled switch as it was added to fix the issue (perhaps) that this PR is fixing (e.g. 5a0adce) ? cc @jeromemacias is it?

I think it would mostly just add complexity with little or no benefit? Personally I find the current approach to be the cleanest, as one decides to use one or the other (eg: on factories) without having to introduce a new setting.
Then again, it's not clear to me why that enable switch was added to sfAPCCache as there's already a sfNoCache driver for that purpose.

Nice investigation.
Since PHP 7.2 this warning is triggered
Warning: session_id(): Cannot change session id when headers already sent in /app/lib/storage/sfCacheSessionStorage.class.php on line 262

I would still prefer sfFileCache was used here

It seems a good track, but apply this modification does not fix the issue.

It seems a good track, but apply this modification does not fix the issue.

Yes, replacing the use of sfAPCCache doesn't fix the test — it's just an additional improvement to reduce dependencies on something (APC) that is not being tested.
The proposed solution is to use output buffering with ob_start() — I tried and it works. What do you think of the idea?

The proposed solution is to use output buffering with ob_start() — I tried and it works. What do you think of the idea though?

Yeah, let's go it.

* What about doing an iteration on the enabled switch as it was added to fix the issue (perhaps) that this PR is fixing (e.g. [5a0adce](https://github.com/FriendsOfSymfony1/symfony1/commit/5a0adceb79d44b76f3ad7d39d041133fafe065f7)) ? cc @jeromemacias is it?

Sorry, I don't remember exactly why I did this change, but I think it's hard to be sure at 100% that the environement have APC installed and well configured so in some cases we cannot tell to use sfNoChache adapter. I's easier for me to say "Use APC if available".
By the way, this PR looks good to me.

Sorry, I don't remember exactly why I did this change, but I think it's hard to be sure at 100% that the environement have APC installed and well configured so in some cases we cannot tell to use sfNoChache adapter. I's easier for me to say "Use APC if available".

Alright.
For comparison with latest Symfony cache version.
https://github.com/symfony/symfony/blob/4274a1f/src/Symfony/Component/Cache/Adapter/ApcuAdapter.php#L30

Closing this in favor of #267 to get it from a different branch.


Get UIViewController in v0.7.0

Is there an equivalent to the func introspectViewController planned in the upcoming release?

I wasn’t planning on it, but if it’s helpful I will. Can you tell me more about how it’s useful in your case?

In the current version I am using the access to the  UIViewController to

access the sheetPresentationController and modify prefersGrabberVisible, and
modify hidesBottomBarWhenPushed as there is a Bug and toolbar(.hidden) is only available in iOS 16+

Cool, thanks for the explanation. You can definitely add your own extension, but the goal is for the library to contain as many core components as possible so consumers don't need to implement much themselves.
For the sheetPresentationController  use case, you can now do:
public struct ContentView: View {
    @State var isPresented = false

    public var body: some View {
        Button("Present", action: { isPresented = true })
            .sheet(isPresented: $isPresented) {
                Button("Dismiss", action: { isPresented = false })
                    .introspect(.sheet, on: .iOS(.v15, .v16, .v17)) { (controller: UISheetPresentationController) in
                        controller.prefersGrabberVisible = true
                    }
            }
    }
}

As for the hidesBottomBarWhenPushed bit, I was under the impression that changing that property has never really worked. I'll take it for a spin and see if that's different now with this new module.

In the current version I am using the access to the UIViewController to

access the sheetPresentationController and modify prefersGrabberVisible, and
modify hidesBottomBarWhenPushed as there is a Bug and toolbar(.hidden) is only available in iOS 16+

But, as I read the documentation, I can add my own extension, right?
@_spi(Internals) import SwiftUIIntrospect
import UIKit

public struct ViewControllerType: IntrospectableViewType {}

public extension IntrospectableViewType where Self == ViewControllerType {
    static var viewController: Self { .init() }
}

#if canImport(UIKit)
    public extension iOSViewVersion<ViewControllerType, UIViewController> {
        static let v15 = Self(for: .v15)
        static let v16 = Self(for: .v16)
    }
#endif

It needs to be @_spi(Advanced)

@michzio

But for me your extension doesn't work in predicatable way.

That's because you need to override the default scope for the view, as you're looking up the ancestor tree, not down the receiver.
Try this:
import SwiftUI
@_spi(Advanced) import SwiftUIIntrospect

public struct ViewControllerType: IntrospectableViewType {
    public var scope: IntrospectionScope { .ancestor }
}

extension IntrospectableViewType where Self == ViewControllerType {
    public static var viewController: Self { .init() }
}

#if canImport(UIKit)
extension iOSViewVersion<ViewControllerType, UIViewController> {
    public static let v13 = Self(for: .v13)
    public static let v14 = Self(for: .v14)
    public static let v15 = Self(for: .v15)
    public static let v16 = Self(for: .v16)
    public static let v17 = Self(for: .v17)
}

extension tvOSViewVersion<ViewControllerType, UIViewController> {
    public static let v13 = Self(for: .v13)
    public static let v14 = Self(for: .v14)
    public static let v15 = Self(for: .v15)
    public static let v16 = Self(for: .v16)
    public static let v17 = Self(for: .v17)
}
#endif

@honkmaster this is now implemented in master and will be part of the next release (0.9.0).


Add Asturian diacritics

Summary of the Pull Request

PR Checklist

[x] Closes: #24897
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Pull Request will add Asturian characters to the Spanish language character set in Quick Accent. This pull request adds the lowercase ḥ and lowercase Ḷ Asturian characters and the uppercase characters can be accessed by using the shift key. Updates were made to the languages.cs file.

Hey @Aaron-Junker, can I get a review for these current changes?


STAGING changes to docs for OneGet Provider

Good catch Neil - staging the changes in the other docs now.
Do we want to call out "If you've already installed Docker, you can skip to step 2"?

@enderb-ms


Is the theme update process ok?

Hello!
Just a question - I released a new version of my theme yesterday (approximately before 11 hours), but until now it didn't appear on the theme overview page (https://getgrav.org/downloads/themes) with the new version 0.1.4. The same in my Grav installations, neither in web interface nor when I try with gpm on the cli (with or without -f option).
So I would like to ask if the theme update process is ok?
Thanks in advance & Kind regards,
Ralf

Ugg.. well it was a plugin that was causing the whole script to error out.  I've commented it out until we can find what the solution is. Should pick up your new release in 20 mins or so.


Dataset download

Hey!
I've tried recreating the steps to download the dataset, but apparently the structure of the website has changed, such that the SQL query does not return anything. Can you make the dataset available otherwise, or do you know how to still attain it?
Regards!

Hey! Sorry for the late answer, thank you very much for taking your time to help me out!
I will try to download the files today, you are of great help to me!
Amazing work :)

Hey Vincent, thanks again for your help, it worked flawlessly! I had to remove the proxies in the download script for me, but other than that, it was just as described.
Am I correct that you also changed the architecture of the networks?

Hello, Samiede,
Sorry for answering late. It seems that I forgot adding a convolutional layer. But I think that's OK. You can try to add it.

Hey Vincent, thanks for your answer!
Yes, I've added it in my implementation, though I have problems with the generator: it only produces somewhat regular patterns of noise. It might be because I don't use the ResBlocks in the discriminator, as the implementation details for my use case does not permit Skip Connections for the discriminator. Maybe the discriminator is not able to provide the right feedback to the generator.
It also predicts the exact same probability for fake and real images. Maybe you have some insight on what I did wrong? The implementation of the GAN algorithm did work for me with the DCGAN networks, but the Resnet ones seem to get out of hand.
If you have the time and interest, here is the link to my repository
https://github.com/samiede/LRPGAN
Thank you very much for your time so far!

Well done! Since I have a lot of work to do. So maybe I don't have much time going through your work. As you mentioned that you got noise from G. Maybe it caused by model collapsing. Please find some tricks to solve this kind of problem.
I'm not good at solving this kind of problems because I'm a newbie in this area haha.

Alright, I understand :)
Yes me too, it's the first time working with GANs for me, so interpreting failure is not easy!
Thank you for your time! 👍

I'm happy to help! Good luck!

could you put some image and conditional code as demo. The dataset is too big to download in a moment.

could you put some image and conditional code as demo. The dataset is too big to download in a moment.

Please open a new issue since this issue is already closed.

@samiede Hi~, when i download the dataset, i get error in https://github.com/VincentXWD/create-girls-moe-pytorch/issues/7
Do you face that problems before? and how do you solve it ?
I wonder if you could provide your downloaded dataset to me? I will be very appreciate~


Not able to create multiple OCI datasources

We have resources under multiple tenants each by its own OCI profile name in oci config. The plugin defaults to the DEFAULT profile. Is there a way we can pull metrics from other profiles as well. If there is no option at the moment, adding profiles as an option would help.

HI @simmalra Please have a look into https://github.com/oracle/oci-grafana-metrics/pull/106. I have changed it so that it can work multiple profile. It is still on developing phase. But you can have a look and try.
If you need any help or clarification feel free to let me know.

@chillaxd  I deploying latest #106 to my grafana system and updated datasource settings. Do we have new variable added to link tenancies to chose from list (or) How to select the required tenancy from dashboard

Hi @vmuthadi-winfo sorry for late response. For tenancies, currently plugin will require tenancies file path of which you can get in datasource configuration.
I have attached the sample screenshot of the datasource configuration. Format of the tenancies file will be
<tenancy_name>,<tenancy_ocid>
and please remember create the oci profile with <tenancy_name>
Please let me know if you need any further help.

.

@chillaxd Thanks for the update. I am able to configure the data source successfully, but I would like parameterize the tenancy. I can choose the tenancy from the list under panel but I am looking at templatizing where in I get error. Below are screenshots

Could not identify the correct variable name and also unable it use variables like regions(),etc.,

HI @vmuthadi-winfo unfortunately I have not implemented the variable features in the new plugin yet. So that's why it is giving error.

@YogiTiwari Currently the plugin still only supports a single tenancy per plugin instance. However there is ongoing work to update the plugin to support accessing multiple tenancies from a single plugin instance. Although in your case it looks like you are creating distinct plugin instances.
So for your use case, you have cross tenancy permissions setup to allow compartment list and metrics access to tenancy B (where Grafana is NOT installed) from tenancy A (where Grafana IS installed), correct? The reason I ask is that supporting multiple tenancies from the plugin is slightly different depending on whether one is using a local OCI configuration file or instance principals and so I just wanted to confirm your particular use case.
Finally, in the information you shared you didn't show the compartments being listed for tenancy B from tenancy A. Did you try that via the OCI CLI from the instance in tenancy A? Also I would suggest that you confirm the policy to allow compartment read access within tenancy B from tenancy A has been applied in tenancy A. Where the single tenancy version of the policy would be:
allow group grafana to read compartments in tenancy

Hi,
We were missing a pemission in the policy.
Earlier we missed  read tenancies in tenancy

Okay, glad you resolved it.


child_process and fs module error in D3 latest version.

Latest version 4.10.2 uses d3-request which internally uses xmlhttprequest module and there we are getting below error for child_process and fs module.
Module not found: Error: Cannot resolve module 'child_process' in ../node_modules/xmlhttprequest/lib
22:23:09  @ ./~/xmlhttprequest/lib/XMLHttpRequest.js 15:12-36

Now reverting back the d3 version to 4.10.0 solved my problem and now my project does not have dependency on these modules.
Please check and correct this issue in latest version of D3 (4.10.2).

Closing as duplicate of d3/d3-request#24. It looks like you were depending on unsupported entry points in the package.json; you’ll need to reconfigure your bundler to consume the code intended for browsers rather than for Node, preferably by consuming the ES modules (the module field in the package.json).


Write Tests for FutarchyChallenge

Added requires to constructor
Cleaned up winnerRewardAmount()

Other than spelling, looks good to me! 👍

@emaG3m this looks awesome!! just a few comments on restructuring some of the tests, but the tests themselves are looking great. love the smart contract mock patterns!

lookin good 👍

👍


LNL: Release event updates

This pull request releases a comprehensive set of P-Core events. E-Core and uncore updates will be submitted in a follow-up pull request.

All events reviewed and approved prior to submission.


Bump kube-prometheus-stack chart to latest

Description of your changes
Pushes kube-prometheus-stack chart to the latest version.
Also testing new e2e workflow.
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
With e2e workflow.

/test-e2e

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hasheddan looks like you need to sign updated CLA

Hmm, the CLA is acting a bit weird - I just clicked it and signed it and that turned it green.  I don't think @turkenh signed it also yet 🤔

Hmm, actually @turkenh signed it Oct 17, 2022 12:10:04 PM, so that was possibly after the CLA bot first posted at https://github.com/upbound/platform-ref-gcp/pull/38#issuecomment-1281198161.
So maybe me clicking the link and signing it just gave it the "kick" to look and see that @turkenh did in fact sign it a few days ago?

Hmm, actually @turkenh signed it Oct 17, 2022 12:10:04 PM, so that was possibly after the CLA bot first posted at #38 (comment).

Yes, I signed already and things are looking good on my end.


CUDA for ppc64le / aarch64

Comes from https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/725
Let's summarize how CUDA is doing in ppc64le / aarch64 as of today.
PowerPC

CUDA <10.2 is not supported. We never had cudatoolkit there (see #12)
CUDA 10.2 is available and all the infra is there (docker images, nvcc, and cudatoolkit itself). We just did not roll out the migrator yet. See here for manual instructions (not recommended).
CUDA >= 11 is on hold because CentOS8 is "required" and there are no plans to support it just yet. A hybrid image could be created on COS7, but that might pose licensing issues. More info

ARM
Basically no support yet. CUDA offers aarch64 support since v11.0, and we also have to distinguish between the SBSA compliant builds, and the custom L4T (Jetson) variants.

SBSA packages are being tackled in #59.
Docker images have not been added yet, but being CUDA 11, they will require CentOS 8 too, so basically we have the same limitations as in PPC.

In short, adding support for CUDA 11+ on non-x64 archs will require substantial work due to the CentOS 8 issue, which is being discussed here.

The current plan based on previous discussion is just to use CentOS 7 images for the builds (even for newer CUDA versions). Please see this comment ( https://github.com/conda-forge/conda-forge.github.io/issues/1432#issuecomment-854891454 ) for details.

That's not what we discussed in the core gitter chat. In the core gitter chat, we agreed to use CentOS 8 images with CentOS 7 sysroot.

So we would build the images as usual but then use cdt_name=cos7 and sysroot_*=2.17 on our recipes, or is there anything else involved? Is this being tackled by somebody or is it more like "would be nice to have"? I have some free time I can use to do this if some instructions are provided! :)

So we would build the images as usual but then use cdt_name=cos7 and sysroot_*=2.17 on our recipes, or is there anything else involved?

Yes

Is this being tackled by somebody or is it more like "would be nice to have"?

It'd be nice to have, but nobody is working on it.

I guess it'll make sense to wait until the split packages are ready since this would only benefit 11.0 - 11.2, and these are not going to be part of the build matrix down the road, right?

That's not what we discussed in the core gitter chat. In the core gitter chat, we agreed to use CentOS 8 images with CentOS 7 sysroot.

Ok. Have submitted a CentOS 8 based ARM image PR ( https://github.com/conda-forge/docker-images/pull/189 )

use cdt_name=cos7 and sysroot_*=2.17 on our recipes

With the new images added, does it still hold, or should we use cdt_name=cos8 + sysroot_*=2.17?

Yeah the original sounds right. We are just reusing CentOS 7 things on CentOS 8 images. Though will let Isuru confirm 🙂

Hmmm if it's not cos8 it could be problematic, as we've set it in nvcc-feedstock and then a few other places:
https://github.com/conda-forge/nvcc-feedstock/blob/408c93112830bfbd8707ea5bc8a4be7cb6b94462/recipe/conda_build_config.yaml#L108-L114

Hmmm if it's not cos8 it could be problematic, as we've set it in nvcc-feedstock and then a few other places:
https://github.com/conda-forge/nvcc-feedstock/blob/408c93112830bfbd8707ea5bc8a4be7cb6b94462/recipe/conda_build_config.yaml#L108-L114

Hi @isuruf, should I fix the cos8 usages, and then send a PR to fix the repodata? Or you'd prefer to mark them as broken instead?

I just checked: cdt_name does not go into the repodata. It is only used to calculate the hash (for build string).

It should be changed to cos7. No need to mark them as broken

I think we have everything done here for ppc64le/aarch64. Feedstock maintainers are free to enable the support via cbc.yaml. A migrator is being added in https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/2001. For any follow-up discussion please feel free to open new issues. Thanks everyone!


Capturing additional AFDS claims beyond the standard Django auth user model

If I wanted to send additional claims (e.g. employee number, department, title, device name, that sort of thing) and affiliate them with the Django auth user that your package creates and authenticates, how would you recommend that I go about doing that? I've seen several guides for extending the vanilla Django auth user model, but what would be the best way to streamline the process with django_auth_adfs?

Mapping claims to a user’s properties is possible by configuring this setting: http://django-auth-adfs.readthedocs.io/en/latest/configuration.html#claim-mapping
If you need a boolean field to be set, use this setting: http://django-auth-adfs.readthedocs.io/en/latest/configuration.html#boolean-claim-mapping

Understood. But I'm talking about fields that don't exist in the Django auth user model. For example, if I just add a claim, let's call it "myClaim", and map it in the settings, I'll get this message.

User model has no field named 'myClaim'. Check ADFS claims mapping.

What would be the best way to extend the default user model in a way that captures these claims as the come into django_auth_adfs?

These are 2 separate things.
First you need to figure out how to extend the default user model with extra fields. This article seems to explain is quite well: https://simpleisbetterthancomplex.com/tutorial/2016/07/22/how-to-extend-django-user-model.html#abstractuser
Next, when you create a model with extra fields, you'll need to map whatever claims you configured on the ADFS server to the fields in your user model. As explained in the CLAIM_MAPPING setting's documentation

I had already seen the doc you linked and was started down a much more complicated path. But I clicked it anyway and it took me to the section "Extending User Model Using a Custom Model Extending AbstractUser".

Custom User Model from AbstractUser: The way Django handles auth is a perfect fit for your project but still you want to add extra attributes without having to create a separate Model.

That sounded like what I was trying to do, so I gave it a shot. And then I mapped the additional claims in the CLAIM_MAPPING section, like you said. And of course, it worked!
THANK YOU!

Good to hear.
I'll keep this open until I find time to update the docs. Along with #23

It's been added to a new FAQ section of the docs.
https://django-auth-adfs.readthedocs.io/en/latest/faq.html


Error: connect ECONNREFUSED <IP_ADDRESS>:80

This happens when cloning the repo fresh and trying to run.

If you are developing in local, remember to create a .env file. See template.env

Yeah, I did that. It appears that this happened because some environment variables were not included by default in heroku.env. I've made a PR to add that env variable in.

Yeah, I did that. It appears that this happened because some environment variables were not included by default in heroku.env. I've made a PR to add that env variable in.

Cool


Add Azul/Smiles partners, fix some typos

Adds Smiles/Azul, and fixes some typos called out in pfei-sa/seats-aero-viz/issues/2
This "works on my machine" but would recommend the maintainer validate it as well 🙃

@pfei-sa 👋 thanks for reviewing the PR! Anything extra I (or you) need to do to get it deployed to the streamlit cloud instance?

Not sure why auto deployment didn't work. It should be updated now!


Facebook Share doesn't work

The Facebook Share btn doesn't work.
Is anyone having the same problem? I have also added Twitter, Pinterest and Linkedin and they all work except for Facebook.

Are you running on localhost?
Take a look at #102

Yes, I will check once it's deployed.
Thank you!

Did it work, NancyLuLay, after deployment? I am having the same problem , facebook is not working for me as well.


build(npm): disable package-lock.json

Greenkeeper does not play as nicely with package-lock.json as we would like, so this disables it for the timebeing

yea, I know greenkeeper lockfile exists, but the way it works requires putting secrets in places I really don't want to. I also had mixed success getting it working in other projects. We can revisit at some point, but this'll do for now.


fix: SqlaColumn.type overflow on mysql

CATEGORY

[x] Bug Fix

SUMMARY
Hitting a new error when loading examples around a datatype that exceeds
the 32 chars limit on SqlaColumn.type
Type looks like 'VARCHAR(255) COLLATE utf8mb4_general_ci' suffix which is too
verbose and not needed in that context. Adding mysql-specific code that strips out the collation information.

Codecov Report

Merging #7606 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##           master   #7606      +/-   ##
=========================================
+ Coverage   65.59%   65.6%   +0.01%
=========================================
  Files         435     435
  Lines       21694   21704      +10
  Branches     2387    2387
=========================================
+ Hits        14230   14239       +9
- Misses       7343    7344       +1
  Partials      121     121

Impacted Files
Coverage Δ

superset/connectors/sqla/models.py
81.98% <100%> (ø)
:arrow_up:

superset/db_engine_specs.py
67.44% <90%> (+0.2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722043c...f0b75be. Read the comment docs.


Differences between API documentation and JSON response

Hi, the example output at https://genome.github.io/civic-api-docs has some significant differences with what is actually returned. I've attached a file listing the differences, and another file with the outputs for each command (actualJSON.txt). Obviously some needed to be truncated, but all the fields should probably be shown.
Also some of the commands are mistyped, and are to https://civic.genome.wustl.edum instead of https://civic.genome.wustl.edu
actualJSON.txt
differences.txt

Thanks for the report Jake, I'll get this fixed!

+1 for this bug - would it be possible to fix it so all data is returned? thanks!

Hi @igersh, thanks for the report!
I will definitely update the documentation to include the most current and accurate example responses, that's something that's slipped under the radar so far, but I will make sure to get done in the coming week!
As for including full evidence item information in the /variants index endpoint, that is unfortunately not likely in the near future. The basic design of the CIViC API involves two type of endpoints: index and detail. The index endpoints (such as /variants, /genes, and /evidence_items provide a way to page through all entities in the database and get summary information about them. The detail endpoints (like /variants/:variant_id) provide a method to drill down and see full, detailed view of a single entity.
This was a deliberate decision made to improve API performance. If, for instance, the /variants endpoint returned not only all of the variants, but also the complete evidence records for each variant, you could imagine the JSON response becoming large and unwieldy very quickly.
Right now, the recommended way to retrieve all the evidence records for a variant are by calling either https://civic.genome.wustl.edu/api/variants/:variant_id/evidence_items or https://civic.genome.wustl.edu/api/variants/:variant_id. The former will return only the evidence records for the variant id given, while the later will also include the variant record itself.
Let me know if you have any questions or run into any other issues while using the API! I will update this issue when a new version of the documentation is live.
Thanks again for your interest in CIViC!
Adam

Thanks Adam for looking into this - @igersh and I have been indexing CIViC on SolveBio (www.solvebio.com). We'll revert back to looping through the variants to grab the evidence id connections. Otherwise, the API has been very straightforward and easy to use!

@dandanxu, that's good to hear! Would it be helpful if we included the CIViC variant ID in the evidence records directly? That would enable you to use the /api/evidence_items endpoint to page through all of the evidence items in bulk, and then connect them to the variants afterwards.

Yes! It would very much =). Really, any way to map between the IDs between the variant and the evidence, without looping through all of the variants individually would be useful.

@dandanxu This change is now live! All evidence record responses will contain a variant_id which can be used to link it directly to a CIViC variant.
@jakelever Thanks for the initial report! I am working on the finishing touches to some revamped (more complete) documentation and it should go live later this evening or tomorrow.


fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml

The gcloud-secrets CLI will create these files with 0600 permissions, and does not document an option to change the mode. This patch uses the chown/chmod CLI utilities rather than --chown and --chmod flags because their support is not universal across docker versions or distributions which do not include buildkit (the cloudbuild environment provides one such distribution).

This change was validated by completing the following build successfully: https://console.cloud.google.com/cloud-build/builds;region=global/9a0cc20f-7604-4c23-a9a4-d76197f17e46?&project=web-based-gtfs-validator


Sorting contacts

Currently when syncing with contacts, it seems the order is arbitrary. It would be great if the contacts where sorted alphabetically.

yes! thank you to remind me that!
It should be an easy fix with the lib underscore-min.js already loaded.

obviously the task is for me a bit more complex than i through, i may need some help from a cozy front dev

If you are using underscore's collection to manage the list of contact you can use sortBy : http://underscorejs.org/#sortBy
_.sortBy(yourContactListFiltered, 'name');

yeah i know, it's really not easy to read,
in fact the basic is:
cozysdk.run('Contact', 'all', {}, function (err, res)

and the template for the sidebar
		var template =
		'
' + altUpics +
		'	' + res[i].key.fn + '

' +
		'' +
		adrsidebar +
		'

';

		HTML = HTML + template;

where  res[i].key.fn are the name, i think it sort by id for now but not by key.fn...

Just as a reminder since I don't have much time and will continue on this later`.
Breakpoints here : https://github.com/RobyRemzy/cozy-map/blob/db21da17f3683c8e046af35b8b6d4b0a79872aa3/src/app.js#L710
In console enter this
var a = _.filter(res, function (num) {return num.key.datapoints[2] && num.key.datapoints[2].name == 'adr';})

Need to check all the values in the datapoints tab instead of just "2" but it's returning me a contact, should return all then just do something like:
_.sortBy(res, 'name'); // I think it's not directly name and we will need to use a function here too ;)