How can Disruptor run consumers in parallel?

Producer -> Consumer1 -> Consumer2 -> Consumer3.
Consumer1 depends only on producer, so we should be able to have, for example, 4 instances of Consumer1.  Consumer2 depends on Consumer1, Consumer3 depends on Consumer2.
Every consumer changes data in onEvent(CustomEvent event, long sequence, boolean endOfBatch).
I have arrived to this pipeline which does not utilize any parallelism:
public class Consumer implements EventHandler<CustomEvent> {
    private RingBuffer<CustomEvent> ringBuffer;

    public Consumer(RingBuffer<CustomEvent> ringBuffer) {
        this.ringBuffer = ringBuffer;
    }

    private Random random = new Random();

    public void onEvent(CustomEvent event,
                        long sequence,
                        boolean endOfBatch) {
        // Consumer consumes the data from the custom event
        System.out.println("Data: " + event.getData());
        event.setData("new data, dude! " + random.nextLong());
        System.out.println("Changed data to: " + event.getData());

        try {
            Thread.sleep(1500);
        } catch (InterruptedException e) {
            e.printStackTrace();
        }

        if (endOfBatch)
            System.out.println("end of batch (local to this consumer)");
    }
}

public class Producer {
    private final RingBuffer<CustomEvent> ringBuffer;

    public Producer(RingBuffer<CustomEvent> ringBuffer) {
        this.ringBuffer = ringBuffer;
    }

    public void publishDataToConsumer(String data) {
        long sequence = ringBuffer.next();
        try {
            CustomEvent event = ringBuffer.get(sequence);
            event.setData(data);
        } finally {
            ringBuffer.publish(sequence);
        }
    }
}

public class CustomEvent {
    private String data;

    public String getData() {
        return data;
    }

    public void setData(String data) {
        this.data = data;
    }
}

public class Main {
    private static final int BUFFER_SIZE = 1024 * 8;
    private static final int NUM_EVENT_PROCESSORS = 3;

    public static void main(String[] args) {
        Executor executor = Executors.newFixedThreadPool(NUM_EVENT_PROCESSORS);
        Disruptor<CustomEvent> disruptor = new Disruptor<>(CustomEvent::new, BUFFER_SIZE, executor);

        RingBuffer<CustomEvent> ringBuffer = disruptor.getRingBuffer();
        Producer producer = new Producer(ringBuffer);

        Consumer consumer1 = new Consumer(ringBuffer);
        BatchEventProcessor<CustomEvent> batchConsumer = new BatchEventProcessor<>(ringBuffer, ringBuffer.newBarrier(), consumer1);

        Consumer consumer2 = new Consumer(ringBuffer);
        BatchEventProcessor<CustomEvent> batchConsumer2 = new BatchEventProcessor<>(ringBuffer, ringBuffer.newBarrier(batchConsumer.getSequence()), consumer2);

        Consumer consumer3 = new Consumer(ringBuffer);
        BatchEventProcessor<CustomEvent> batchConsumer3 = new BatchEventProcessor<>(ringBuffer, ringBuffer.newBarrier(batchConsumer2.getSequence()), consumer3);

        ringBuffer.addGatingSequences(batchConsumer3.getSequence());
        disruptor.handleEventsWith(consumer1).then(consumer2).then(consumer3);

        disruptor.start();
        producer.publishDataToConsumer("Some piece of Data");

        try {
            Thread.sleep(1000);
        } catch (InterruptedException e) {
            e.printStackTrace();
        }

        batchConsumer.halt();
        batchConsumer2.halt();
        disruptor.shutdown();
        System.exit(0);
    }
}

Now, this implementation processes only one message from Producer at a time. However, with 4 CPU cores, I want 4 instances of Consumer1 to process in parallel up to 4 messages from Producer.
How can LMAX disruptor use parallelism, that means have 4 instances of Consumer1?

If the last consumer in the chain was the one that you wanted to make parallel, then you could replace consumer3 with a WorkerPool, but that won't work for consumer1.  You could create 4 instances of consumer1 and use a hash on the sequence value to distribute the messages across the 4.  I.e. each consumer would have to have an index (0-3) and mod (or mask if the number of handlers is a power of 2) the incoming sequence.  E.g.
public class Main {
    private static final int BUFFER_SIZE = 1024 * 8;
    private static final int NUM_EVENT_PROCESSORS = 3;

    public static void main(String[] args) {
        Disruptor<CustomEvent> disruptor = new Disruptor<>(CustomEvent::new, BUFFER_SIZE, Thread::new);

        RingBuffer<CustomEvent> ringBuffer = disruptor.getRingBuffer();
        Producer producer = new Producer(ringBuffer);

        ParallelConsumer consumer1_0 = new ParallelConsumer(0, 4);
        ParallelConsumer consumer1_1 = new ParallelConsumer(1, 4);
        ParallelConsumer consumer1_2 = new ParallelConsumer(2, 4);
        ParallelConsumer consumer1_3 = new ParallelConsumer(3, 4);

        Consumer consumer2 = new Consumer();
        Consumer consumer3 = new Consumer();

        ringBuffer.addGatingSequences(batchConsumer3.getSequence());
        disruptor.handleEventsWith(consumer1_0, consumer1_1, consumer1_2, consumer1_3)
            .then(consumer2).then(consumer3);

        disruptor.start();
        producer.publishDataToConsumer("Some piece of Data");

        try {
            Thread.sleep(1000);
        } catch (InterruptedException e) {
            e.printStackTrace();
        }

        batchConsumer.halt();
        batchConsumer2.halt();
        disruptor.shutdown();
        System.exit(0);
    }
}

public class Consumer implements EventHandler<CustomEvent> {
    private final int id;
    private final int total;
    public Consumer(int id, int total) {
        this.id = id;
        this.total = total;
    }

    private Random random = new Random();

    public void onEvent(CustomEvent event,
                        long sequence,
                        boolean endOfBatch) {
        if (sequence % total == id) {
            // Consumer consumes the data from the custom event
            System.out.println("Data: " + event.getData());
            event.setData("new data, dude! " + random.nextLong());
            System.out.println("Changed data to: " + event.getData());

            try {
                Thread.sleep(1500);
            } catch (InterruptedException e) {
                e.printStackTrace();
            }
        }

        if (endOfBatch)
            System.out.println("end of batch (local to this consumer)");
    }
}

A couple of points on your code:

You don't need to construct the BatchEventProcessor instances, the disruptor will do that internally.
You don't need to pass the RingBuffer into the constructor of the consumer.
Please don't use an executor, use a thread factory instead.  In this example I've just used the Thread's constructor, but you can apply additional smarts there.

Closing due to inactivity.

Hello. You haven't mentioned the implementation of ParallelConsumer. Also while using your code, the ringbuffer doesnot seems to move in circular motion and stuck on ringbuffer.size. For example if ringbuffer size = 1024, It will stuck at 1023 without any error or logs and waiting for something.


[web] Container width works different in web compare to ios.

Here is my code,  I set the width property of the container to be 100.  in ios platform the container's width is 100, which is same as expected. But in web, the code "width: 100" doesn't work. The Container will be as big as possible.
void main() {
  runApp(JustApp());
}
class JustApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Container(
          width: 100,
          color: Colors.red,
          child: Text("test"),
        ),
      ),
    );
}

Please include the output of flutter doctor -v

Hello @Swifree !
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the issue, if you have any more information for us; we will reopen it right away!
Thank you for your contribution.
P.S. If anyone still experience the same problem, please file a new issue with the information required in the template.
All system setups can be slightly different so it’s always better to open new issues and reference related issues.


CVE-2018-0787-- Service-Fabric appears to be vulnerable too

Do we have a fix for this already without the middleware taking care of the checks ?
Ref:
https://github.com/aspnet/Announcements/issues/295#configuration

I'm not sure I understand what the issue is. Can you rephrase your question so the intent is clear?

CVE-2018-0787: ASP.NET Core Elevation Of Privilege Vulnerability
Microsoft.AspNetCore.Server.Kestrel.Core | 2.0.0, 2.0.1 were termed to be vulnerable as documented here- https://github.com/aspnet/Announcements/issues/295#configuration
Considering Kestrel serves micro-services that are deployed on Service Fabric- It appears to be vulnerable too. The recommended mitigation is to introduce a middleware (provided in the above link) or to proxy it via IIS
The ask is: Do we plan to introduce a fix which fixes it natively as opposed to introducing a middleware which takes care of it ?
Note: Since there is a CVE already assigned & the issue is out for quite sometime now, I raised a issue here than writing in to<EMAIL_ADDRESS>

So we don't use Kestrel natively in the product. It's something that is configured to run as a service if you want to use it as your hosting engine. You're welcome to use any ASP.NET hosting service if you desire, if you choose to you a vulnerable version of Kestrel then you should follow the mitigations.
This is a fault in Kestrel so I'm not sure I understand what "native fix" you're suggesting.

Closing as it appears this is not directly a Service Fabric issue, but a vulnerability in a component optionally available for service developers.


[XLA] Unintuitive behavior of jit_scope

As far as I can tell, the implementation of MarkForCompilation relates to jit_scope (_XlaCompile attribute) does the following steps:

Remove the nodes whose _XlaCompile attribute is set to false from the compilation candidates (using CompilationDisallowedByXlaCompileAttr).
Create a cluster for each candidate using _XlaScope as the scope (absl::nullopt otherwise).
Cluster the one-node clusters and set is_xla_compile_attr_true to true if any node in the cluster has _XlaCompile true.
Add the kXlaClusterAttr to node if the is_xla_compile_attr_true of its cluster is true (as in ShouldCompileClusterImpl).

The problem of the above steps is that if we want to only cluster part of the model, for example:
def stage1(input):
  # stage 1 of the model

def stage2(x):
  # stage2 of the model

def loss(x):
  # ...

x = stage1(input)
with tf.xla.experimental.jit_scope():
  x = stage2(x)
l = loss(x)
train_op = optimizer.minimize(l)

# ...

The unlabeled part of the model may still be clustered and compiled. In practice, such situation happens a lot in the backprop part of the model, where the unlabeled loss gradient ops are clustered with the gradient ops inside jit_scope. I wonder if this is the expected behavior and I think that it is different from the intuitive idea that only the ops in jit_scope are compiled.
One walkaround to this problem is adding a global jit_scope(compile_ops=False):
with tf.xla.experimental.jit_scope(compile_ops=False):
  x = stage1(input)
  with tf.xla.experimental.jit_scope():
    x = stage2(x)
  l = loss(x)
  train_op = optimizer.minimize(l)

Following are the comparison between the origin result and the walkaround
without the global jit_scope(compile_ops=False):

with the global jit_scope(compile_ops=False):

The red part of the timeline is the XlaRun op.
I think that to solve this problem, we only need to remove the unlabeled ops from the compilation candidates when global jit level is not set. It will be great if the XLA team would like to share some idea on the current behavior of jit_scope.
Also, is global_jit_level designed to be override the jit_scope? It seems that if global_jit_level is set, it will ignore the _XlaScope attribute and use _XlaInternalScope instead. In this way, if one want to compile the whole model, is he or she allowed to separate the cluster arbitrarily?
Thank you for your time on this issue :).
Gently ping @sanjoy @cheshire @tpopp .

@zhuzilin
Request you to fill issue template.
Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version.
Please, share colab link or simple standalone code to reproduce the issue in our environment.It helps us in localizing the issue faster.Thanks!

@ravikyram
I believe this issue should be classified into the "other" category because it mainly relates to the internal structure of XLA. And because it relates to timeline, I'm not sure it can be easily reproduced through colab and I think the content has already localized the issue... As for the tensorflow version, I think the implementation mentioned exists from at least 1.15.

This is all running without autoclustering, right?

In practice, such situation happens a lot in the backprop part of the model, where the unlabeled loss gradient ops are clustered with the gradient ops inside jit_scope

To me it actually kind of makes sense: the computation is marked as "best-effort compile", so the gradient over the computation is also "best-effort compile"?.. Am I missing something?

It seems that if global_jit_level is set, it will ignore the _XlaScope attribute and use _XlaInternalScope instead

Yes, using explicit JIT scopes when autoclustering is on does not really make sense.
Also just to set expectations now we are mostly focusing on explicit compilation with tf.function(experimental_compile=True) as a preferred API for using XLA in TF.

@cheshire
Thank you for your explanation :).

To me it actually kind of makes sense: the computation is marked as "best-effort compile", so the gradient over the computation is also "best-effort compile"?.. Am I missing something?

Here is where the misunderstanding emerges. The doc for jit_scope says:

Enable or disable JIT compilation of operators within the scope.
...
The compilation is a hint and only supported on a best-effort basis.

It may be wrongly interpreted as "XLA will try to compile the whole scope, but because XLA may not support compiling all of the scope, it will be regard as a hint." instead of "XLA will may merge the ops in the scope with ones out of it for better performance." Also, it will be a little confusing that the compilation result will be different for ops in one place if we add a jit_scope at the other. The current behavior will be inconvenient for those who are using jit_scope to debug if any part of model is unsuitable to  XLA and has led to negative optimization, because the problem part may always been clustered and compiled. I think that it will be more consistent with the design of tensorflow api that a "scope" would only have influence to things inside it.
I understand that we hope to have better performance by creating larger clusters. If there is little motivation to change the design of jit_scope, can I help to clarify this possible misunderstanding in the doc and provide an example for the users who only hope to compile the ops inside a certain scope?

@zhuzilin For the doc, would you want to send a PR with examples? :P
From a different angle, is tf.function(experimental_compile=True) unsuitable for your purposes?

@cheshire
I'd love to send a pr :). As for tf.function, many legacy models in our team are till using tf1.x... So we cannot use it for now...

@cheshire
There is another question relates to jit_scope. In _MaybeCompile(), we have:
def _MaybeCompile(scope, op, func, grad_fn):
  """Compile the calculation in grad_fn if op was marked as compiled."""
  scope = scope.rstrip("/").replace("/", "_")
  if func is not None:
    xla_compile = func.definition.attr["_XlaCompile"].b
    xla_separate_compiled_gradients = func.definition.attr[
        "_XlaSeparateCompiledGradients"].b
    xla_scope = func.definition.attr["_XlaScope"].s.decode()
  else:
    try:
      xla_compile = op.get_attr("_XlaCompile")
      xla_separate_compiled_gradients = op.get_attr(
          "_XlaSeparateCompiledGradients")
      xla_scope = op.get_attr("_XlaScope").decode()
    except ValueError:
      return grad_fn()  # Exit early

  if not xla_compile:
    return grad_fn()  # Exit early
  ...

I wonder if the latter "Exit early" (jit_scope(compile_ops=False) won't have influence to the grad fn) is the expected feature or a bug? Thank you.


Change "/run-e2e" to use GitHub's Checks API

Change "/run-e2e" to use GitHub's Checks API instead of emojis so that PRs are blocked in case of failed tests.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks
https://docs.github.com/en/rest/guides/getting-started-with-the-checks-api

There seem to be some GitHub Actions in the marketplace, for example this one: https://github.com/marketplace/actions/github-checks

I have been checking GitHub Checks API and I think that it doesn't match our requirements. This API allows dynamic checks creation with custom messages, reports, etc... the problem is that those checks are not considered part of the PR checks, I mean, we cannot block the PR with it.
Maybe I have missed something, but I think that GH is not ready for this... 😢
I have another option that could work, the workflow could add a label to the PR, and we could use that label to block the PR, I mean, the e2e workflow could add/remove a label in the PR with for example e2e failed (and another informative like e2e passed ) and we could add other check that monitors that label. With this approach, we could block the PR.
WDYT @tomkerkhove ?

the problem is that those checks are not considered part of the PR checks, I mean, we cannot block the PR with it.

Normally you can link them to the PR as per the docs above. Did you give this a try?
The alternative is another approach but feels a bit like a hack, ideally we rely on checks IMO. If we link the running workflow job to the PR it should also work imo.

Maybe I miss the part of the PR... Could you send me that link?

It is in the issue above: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

The closest thing that I found yesterday was this.
We can create a check for a specific commit hash, but despite that either if the commit is in the PR, the check is not attached to the PR checks.
Anyway, I'll take another look

Creates a new check run for a specific commit in a repository. Your GitHub App must have the checks:write permission to create check runs.

Was this the case?
Let me ask around


CORE-31430 Fix issue where identity would only be requested on viewStart

Description
This solves the problem brought up in https://github.com/adobe/alloy/issues/69. That is, if the ECID is not available on the client and the website executes event commands that do NOT have type: viewStart, then the first request would be sent but no ECID requested. The response therefore did not have an ECID and subsequent requests would never be sent (they were stuck in the queue waiting for an ECID). This PR fixes the problem by requesting the ECID on the first event regardless of whether it is type: viewStart.
This PR also gives components greater control over whether a response is expected by exposing an expectResponse method on the event rather than basing the response expectation on the existence of a query object. We were going to need this anyway when gateway becomes less reliant on the query object for sending data back from the server.

Related Issue
https://jira.corp.adobe.com/browse/CORE-31430
https://jira.corp.adobe.com/browse/CORE-31429

Motivation and Context

Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] (all tests pass, but we need functional tests) I have added/removed/modified tests to cover my changes and all tests pass.
[X] I have run the Sandbox successfully.

It may be a good idea to log a debug message when the identity component is holding up a request.  I could see there being other reasons why this might happen.

Yeah, logging a message would be good. I'll do that right now.


Code sample for "active" Button include "outline" classes

Small thing. I was looking through the Button component variations and noticed that the "active" style's code samples include classes present in the "outline" style. For example:
<button class="button button--outline button--active button--primary">
  Primary
</button>

Removing the button--outline class appears to retain the active style, any reason it should be left in there?

Created a PR #279
Can check for build here -> https://deploy-preview-279--infima.netlify.app/docs/components/button#active
Thanks !


Stay in a queue

Hi,
I've written a program which works perfectly well to seek inforamtions on a website. But when too many people are on this site, a queue is set in order to avoid crashes of the server.
The issue is that the script stays in the queue forever.  However, if we launch the site in a private navigation tab, it starts from afresh.
So, I assume that is a question of Session or Cookies (it's not related to the IP).
Does anyone have an idea of how to solve this issue ? I think it should be by using some Session/cookies function but I don't know how to do that.
Thanks,
Djokx.

@Djokx are you using the requests library in your project? This is a repository for a Python library called requests, not a repository to request help for arbitrary problems. If you are using this library, could you share some code so we can help you debug whatever problem it is that you're running into? It's not apparent what this has to do with this library at the moment.

Hi, and thanks for the reply
So here's the function I use:
session = requests.session()
def CompteMot(mot, site):
global session
r = session.post(site)
P = r.text.upper();
return P.count(mot)
And I have now these errors after a few loops in a while loop in which this function is called :
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 376, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen
body=body, headers=headers)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 378, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.4/http/client.py", line 1171, in getresponse
response.begin()
File "/usr/lib/python3.4/http/client.py", line 351, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.4/http/client.py", line 321, in _read_status
raise BadStatusLine(line)
http.client.BadStatusLine: ''
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/requests/adapters.py", line 370, in send
timeout=timeout
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 609, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/util/retry.py", line 245, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/packages/six.py", line 309, in reraise
raise value.with_traceback(tb)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen
body=body, headers=headers)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/connectionpool.py", line 378, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.4/http/client.py", line 1171, in getresponse
response.begin()
File "/usr/lib/python3.4/http/client.py", line 351, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.4/http/client.py", line 321, in _read_status
raise BadStatusLine(line)
requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', BadStatusLine("''",))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/scripts/ScriptReq.py", line 155, in VerifyNbMot
Nb_mots = CompteMot(mot, site)
File "/home/scripts/ScriptReq.py", line 58, in CompteMot
r = session.post(site)
File "/usr/local/lib/python3.4/dist-packages/requests/sessions.py", line 511, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python3.4/dist-packages/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.4/dist-packages/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.4/dist-packages/requests/adapters.py", line 420, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', BadStatusLine("''",))

So it looks like the server is closing the connection without sending a response. Your best bet is to read about retries and set them up. Otherwise this isn't a bug. If you need assistance and are looking for the correct place to ask questions, please head on over to StackOverflow.


Fix: HttpClientFactory: resolving a typed client is significantly slower that resolving a named client.

See commits for details.

BenchmarkDotNet=v0.10.13, OS=Windows 10.0.18362
Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical cores and 4 physical cores
.NET Core SDK=3.0.100-preview6-012264
  [Host]     : .NET Core 3.0.0-preview8-27919-01 (CoreCLR 4.700.19.36901, CoreFX 4.700.19.36803), 64bit RyuJIT
  Job-PYIOAJ : .NET Core 3.0.0-preview8-27919-01 (CoreCLR 4.700.19.36901, CoreFX 4.700.19.36803), 64bit RyuJIT

Runtime=Core  Server=True  Toolchain=.NET Core 3.0
RunStrategy=Throughput

Before:

Method
Mean
Error
StdDev
Median
Op/s
Scaled
ScaledSD
Gen 0
Allocated

'use IHttpClientFactory with named client'
13.87 us
0.2708 us
0.3521 us
13.84 us
72,116.5
1.23
0.08
7.8125
3.18 KB

'use IHttpClientFactory with typed client'
500.04 us
17.8916 us
52.1905 us
515.59 us
1,999.9
44.26
5.34
-
8.63 KB

'new HttpClient'
11.34 us
0.2386 us
0.6922 us
11.28 us
88,183.9
1.00
0.00
7.8125
2.66 KB

After:

Method
Mean
Error
StdDev
Op/s
Scaled
ScaledSD
Gen 0
Allocated

'use IHttpClientFactory with named client'
11.065 us
0.2203 us
0.4549 us
90,376.9
1.88
0.09
7.8125
3.17 KB

'use IHttpClientFactory with typed client'
13.362 us
0.2660 us
0.6059 us
74,839.8
2.27
0.11
7.8125
3.28 KB

'new HttpClient'
5.877 us
0.1116 us
0.1194 us
170,146.8
1.00
0.00
6.8359
2.67 KB

/cc @damianh


[#3676] Fix regression issue preventing file browser refresh.

https://github.com/hydroshare/hydroshare/issues/3676 Fixes a regression issue preventing file browser to refresh automatically after an aggregation is created.

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Create a resource.
Create an aggregation on this resource.
Undo this aggregation by right-clicking on the file and selecting "Remove content type".
Restore the file's content type by right-clicking it and selecting an option under "Setcontent type".
At this point verify that your changes were applied automatically without the need to refresh the page.

@pkdash Thanks, I can confirm this works as intended. I tested it extensively.

@sblack-usu, @dtarb Let me know if this merits a patch to www

@Maurier given that the next release is imminent this is probably best just including in the next release.  But I am a bit unclear how this impacts users.  If it is hampering users, and the next release will drag on, it may warrant a hotfix.  I suggest discussing on the Monday call.

This fix addresses issues such as https://github.com/hydroshare/hydroshare/issues/3671
In short, the browser was not automatically reloaded after adding metadata to a file, so a user would not see the metadata form on the right panel until the page is refreshed. These changes fix that so that the metadata form is displayed without refreshing the page.
@pkdash should be able to weight in in the call since he's the one who brought this to my attention.

Thanks.  I had not connected this with #3671, but it makes sense now and am glad it is getting fixed.


App name that starts with digit is invalid

I created an app like this deis create 201612-demo
I can see the app in Deis when using deis apps:list:
=== Apps
20161215-demo
But Kubernetes doesn't like the digits so doesn't create the pods and deis can't delete the app.
So there are two bugs:

Deis shouldn't allow an app to be created that starts with a digit
Deis can't delete an app that starts with a digit.

This is workflow 2.9.0 on k8s 1.4.5.

This was fixed recently in master and will be in the v2.10 release:
https://github.com/deis/controller/issues/1160
https://github.com/deis/controller/pull/1163
Both bugs are resolved by this. Workflow now doesn't allow an app to be created that starts with a digit, therefore Workflow doesn't need to delete apps that start with digits :)


Added JsonConverter to parse Json files to a format such that JsonIntermediateToAvro converter can parse

Based on an offline conversation, please rename to JsonStringToJsonIntermediateToAvroConverter

Fixed the Converter name, boxed type and specific comment on gobblin.converter.avro.JsonIntermediateToAvroConverter

LGTM


What's meaning of post_center_range?

Hi, Thank you for answering my questions, I have a question that in config files, there is a parameter called post_center_range in bbox_coder fields. And it's been used as followed image:

What's the purpose of this?

Thanks for your interest. This param is in the form (x_min, y_min, x_min, y_min, x_max, y_max, x_max, y_max) and is used to filter out boxes out of the range. It's in fact not useful since the range is larger than the perception range.
Moreover, the bboxes are computed with predicted polylines via (x_min, y_min, x_max, y_max).


Waiter timeout

working with cloud front distributions and ssl certificates sometimes take a few minutes to successfully deploy.
Recently i've been getting the error after around 30 seconds:
Error: {"state":"TIMEOUT","reason":"Waiter has timed out"}

Which I believe is due to the maxWaitTime of 30 seconds passed to:
waitUntilStackChangeSetCreateComplete()
waitUntilStackUpdateComplete()
waitUntilStackCreateComplete()

like so:
{ client: cfn, maxWaitTime: 30, minDelay: 10 }

Does this sound right or do you think the issue lies somewhere else?

We're also seeing this error since this morning, with no changes to any of our GitHub workflows. It looks like it was one of the two recent PRs that may have caused this.

+1 here
locking action to @v1.2.0 instead of @master resolved the issue for me

We've pinned to 27513cdf512c25b03c3b2d771032a7d3ed8b02c9 – everything after that seems to have issues for us, so it's likely the SDK v3 change that has caused this.

Drastically increased the timeout values to stop the immediate issue.  Create and update stack operations will now timeout at 12 hours.  We can adjust the numbers again but this should at least get us past the 30 second issue.


Contextual parsing for F#

Thanks for this extension, I think it is really useful!
This adds contextual parsing for F#, which uses // for single line comments, and (* ... *) for comment blocks.

Thanks!


Updating legacy-plugin-chart-heatmap to fix an issue with heatmap

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Heatmap with null values errors with An error occurred while rendering the visualization: TypeError: Cannot read property 'toString' of null fixed the issue in superset-ui-plugins and updating to pick up that change.
TEST PLAN
Create heatmap for data where x or y field contains nulls
Verify the chart has no errors
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@etr2460 @graceguo-supercat

Codecov Report

Merging #7787 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7787   +/-   ##
=======================================
  Coverage   65.87%   65.87%
=======================================
  Files         459      459
  Lines       21986    21986
  Branches     2415     2415
=======================================
  Hits        14484    14484
  Misses       7381     7381
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5994e43...b00207b. Read the comment docs.


[epic] Migrate /retirements pages

This epic will be used to track tasks related to migrating /retirements/[beneficiary_address] ("retirements list") and
/retirements/[beneficiary_address]/[retirement_index] ("single retirement page") to Carbonmark.
The overall design is in progress.
Requirements

[ ] #1018
[ ] #1004

Closing this in favour of using milestones


cleaning up docs directory

Resolves #758

Put up a PR to this branch that I think should fix the CI issue: https://github.com/risc0/risc0/pull/885

I won't be on github much next week; I'm gonna pass this back to @tzerrell to take over the line


Support for define local parameters?

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request

Current behavior
Lack of control over local parameters? Or how to..
Expected behavior
Possibility to define local parameters (in params section) and forward the query to one of them.
But together with not passing the query and defType parameters:
{
  "params": {
    "userQuery": <query>,
    "echoParams": "none",
    "wt": "json",
    "indent": "off"
  },
  "sort": "score desc",
  "fields": [
    "*,score"
  ],
  "limit": 10,
  "offset": 0
}

Alternatively, possibility to remove query and defType parameters and ability to add custom query string parameter to url when searching.
Use case
I have a complex query with subqueries where I'd like to pass user query:
{
"q": "_query_:\"{!edismax qf=$qfQuery mm=$mmQuery pf=$pfQuery bq=$boostQuery v=$userQuery}\"",
"boostQuery": "_query_:\"{!edismax qf=$boostQueryQf mm=100% v=$userQuery}\"^100000"
//...
}

Currently written as RequestHandler in solrconfig.xml but still userQuery with query input must be forwarded to handler.
Environment

Connect to a SOLR version: 6.6.0
Connect to a SOLR in cloud mode? [ ] Yes [x] No
I'm coding using platform:  Windows
Using .net version: netcoreapp1.1
Using SolrExpress package: SolrExpress.Solr5
Using SolrExpress package version: 5.0.0-BETA1

Hi @artziem , this issue is partially resolved in v5-BETA2.
First part
First part of you issue is remove defType and other thinks.
You can do this using new options (SetQueryParser, SetStandardQuery and SetDefaultField), like bellow:
services
	.AddSolrExpress<TechProduct>(builder => builder
		.UseOptions(options =>
		{
			options.SetQueryParser = false;// Don't create default parameter QueryParserParameter using value defType=edismax
			options.SetStandardQuery = false;// Don't create default parameter StandardQueryParameter using value q.alt=*:*
			options.SetDefaultField = false;// Don't create default parameter DefaultFieldParameter using value df=id
		})
		// ...  Other settings
	);

Second part
For version 5, you can use AnyParameter and set your local variable, in this case you lost query generations and fail fast feature.
Do something like this:
documentCollection
	.Select()
	.Any("$userQuery", "some value here")
	// ... other parameters
	.Execute();

But, in v5.1 I will create a specific parameter to do this

Many thanks. Works like a charm, even with multiple Any.
($ sign is unnecessary in parameter definition, only when refers to param)

Hi @artziem , please check version 5.1

Hi @diegobrum. By 5.1 you mean nuget version 5.0.1? I'm getting an error:
System.NullReferenceException: 'Object reference not set to an instance of an object.'

   at SolrExpress.Search.Parameter.Extension.ILocalParameterExtension.Name[TDocument](ILocalParameter`1 parameter, String name)
   at SolrExpress.Search.Parameter.Extension.ParametersExtension.LocalParameter[TDocument,TValue](DocumentSearch`1 documentSearch, String name, String value)
   at Project.Domain.Services.ProductService.Search(String query, Int32 resultsPerPage, Int32 pageNumber) in C:\Sources\Project\Project.Domain\Services\ProductService.cs:line 148
   at Project.Tests.Domain.Services.ProductServiceTest.Search_ExpectSuccess() in C:\Sources\Project\Project.Domain.Tests\Services\ProductServiceTest.cs:line 207

Usage:
var solrResultCollection = serviceProvider.GetRequiredService<DocumentCollection<ProductResult>>();
solrResultCollection
    .Select()
    .Handler("search")
    .LocalParameter<ProductResult, string>("mainQuery", query)
    .Execute()
    .Document(out IEnumerable<ProductResult> documents);

Probably ILocalParameter implementation is not register in DI container. I'm using SolrExpress.DI.CoreClr.
Also, it is necessary to specify type arguments on calling LocalParameter?

Hi @artziem
Please see 5.1.1 and issue #234
And it's not necessary to specify type arguments, this bug was fixed too :)

Yeah, its working now. Thanks for fixing.


Refactoring - Enemy.cs

Refactoring do script Enemy.cs.
Arquivo encontra-se em Assets/Scripts/Enemy/Enemy.cs

https://github.com/ES2-UFPI/SwordAndPan/pull/83/commits/f60248b3d91c025d7bdd6b69bd7fecfaebd170b5


Automatically set default langauge #63

Shouldn't we add a test / check in incase the language is not included in our locale files?

Or nvm it should default to et.

Will look into this a bit more, some users have their Chrome, for ex, set to English, but are Estonian speakers. So even if navigating to koroonakaart.ee/et it still overides and goes to English (feedback from my team). Not sure how to approach it, need to think a bit more.

@muhammednagy  Perhaps we should add a check to make sure that this only applies when koroonakaart.ee is the domain, koroonakaart.ee/et should still redirect to Estonian, /RU to russian, and /en to English I guess.

okay will do update it to do that.
Thanks for the feedback!

oh nvm @keeganmcbride
seems like @Kypsis  already fixed it.
didn't think about that sorry.


Stack has already been built into C#, might as well use it.
same functionality while removing 200 LOC that we won't have to worry about anymore.

All measurements here are done in server build in release build and measured using the Stopwatch class
Side by side test
measured using functions like this
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter())
{
    writer.WriteByte(1);
}

New pool class is about 2 times slower (reader seems to be closer as master calls a SetBuffer method)
 - WriterPoolGetMaster                          17
 - WriterPoolGetPR2414                          36

 - ReaderPoolGetMaster                          25
 - ReaderPoolGetPR2414                          36

Update Loop
Tested by spawning different number of objects with a different number of connections.


Feature/2975/ims prov

Merging IMS Provisioning Playbook

@an-lam - note the hierarchy in the last merged pull request, thus you will want to merge them in for this pull request.
On another note, it seems like this pull request is more a work in progress, I encourage others to consider a Draft Pull Request which later can be converted to a Pull Request indicating its no longer a work in progress.


[Issue]: Get "https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt": write tcp <IP_ADDRESS>:59499-><IP_ADDRESS>:443: wsasend: An existing connection was forcibly closed by the remote host.

What happened?
I cant install any node,js version (tried 21,20,19,18). I tried also 1.1.11 and 1.1.10 of nvm. See error output beneath.
If i install nvm in the same LAN on my laptop it works... Also with Windows Firewall off, it doesn't work on my Workstation...
and i also have no proxy active or any kind
if i manually open "https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt" in a browser it shows me the list of versions....
PS C:\flowGit\crypto-projects\solana-hashlips-candy-nft\4-mint\candy-nft-mint-v3_2> nvm install 18

Could not retrieve https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt.

Get "https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt": write tcp <IP_ADDRESS>:59499-><IP_ADDRESS>:443: wsasend: An existing connection was forcibly closed by the remote host.

What did you expect to happen?
installing node.js version
Version
1.1.11 or newer (Default)
Which version of Windows?
Windows 10 (Default)
Which locale?
Western European
Which shell are you running NVM4W in?
PowerShell
User Permissions?
Administrative Privileges, Elevated
Is Developer Mode enabled?
No (Default)
Relevant log/console output
No response
Debug Output
PS C:\flowGit\crypto-projects\solana-hashlips-candy-nft\4-mint\candy-nft-mint-v3_2> nvm debug
flow is not using admin or elevated rights.

C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
Windows Version: 10.0 (Build 19045)

Windows Developer Mode: UNKNOWN (user cannot read registry)

NVM4W Version:      1.1.12
NVM4W Path:         C:\Users\flow\AppData\Roaming\nvm\nvm.exe
NVM4W Settings:     C:\Users\flow\AppData\Roaming\nvm\settings.txt
NVM_HOME:           C:\Users\flow\AppData\Roaming\nvm
NVM_SYMLINK:        C:\Program Files\nodejs
Node Installations: C:\Users\flow\AppData\Roaming\nvm

Total Node.js Versions: 1
Active Node.js Version: v22.0.0

IPv6 is enabled. This can slow downloads significantly.

PROBLEMS DETECTED
-----------------
Connection to nodejs.org cannot be established. Check your proxy (none) and your physical internet connection.

Find help at https://github.com/coreybutler/nvm-windows/wiki/Common-Issues

Anything else?
No response

I think the root cause is spelled out in the debug function. The bottom line is your environment cannot connect to nodejs.org. You stated you're using admin/elevated privileges, but the debug console states otherwise.
This line suggests you're behind a proxy.
Get "https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt": write tcp <IP_ADDRESS>:59499-><IP_ADDRESS>:443: wsasend: An existing connection was forcibly closed by the remote host.
Are you sure there is no proxy? Remember, even though you may not have a proxy setup on your computer, that doesn't mean there isn't a corporate proxy blocking traffic.

thanks for the response.
nodejs.org is reachable via browser. Also "https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt" as mentioned.
im in my private LAN, and i have full control over all my networking. In fact i made it all by self. So i know im not behind a proxy. i checked also windows, there is no proxy no firewall active.
And as said my laptop is in the same network and there it works, but my laptop has windows 11. this computer here has windows 10.
Same problem also with admin powershell:
Running NVM for Windows with administrator privileges.

Administrator: Windows PowerShell
Windows Version: 10.0 (Build 19045)

NVM4W Version:      1.1.12
NVM4W Path:         C:\Users\flow\AppData\Roaming\nvm\nvm.exe
NVM4W Settings:     C:\Users\flow\AppData\Roaming\nvm\settings.txt
NVM_HOME:           C:\Users\flow\AppData\Roaming\nvm
NVM_SYMLINK:        C:\Program Files\nodejs
Node Installations: C:\Users\flow\AppData\Roaming\nvm

Total Node.js Versions: 7
Active Node.js Version: v18.20.2

IPv6 is enabled. This can slow downloads significantly.

PROBLEMS DETECTED
-----------------
Connection to nodejs.org cannot be established. Check your proxy (none) and your physical internet connection.

I installed the node.js versions now manually thats why I have now "Total Node.js Versions: 7" ;)

I'm not sure what to say, because NVM4W doesn't do anything special when it comes to network requests. It issues standard HTTP requests for downloads, and that's it. I'm not aware of anything specific to Win10 vs Win11 that would cause this type of issue... and I know it works on Win10.
I suppose firewalls could play a factor, but you said you didn't have a firewall enabled. I'm not sure why nodejs.org would forcibly close the connection, but it looks like it is indeed nodejs.org (remote host) closing the connection (not NVM4W).
I can't really see anything in the info provided hinting that NVM4W can actually do anything about this... especially if it is working on another machine.

I thought about maybe is the error misleading or wrong, and it happens something different in the background.
look this issue https://github.com/coreybutler/nvm-windows/issues/1123 he had the same error and it was something different than a connection issue.
well i will dive deeper with my opensense and track the connection

ok the connection is perfect there is no issue... so i assume there is no problem going on on the network level..

The problem is An existing connection was forcibly **closed by the remote host**., meaning nodejs.org is closing the connection. NVM4W doesn't control that.
Can you run nvm ls available? This makes a request to a different endpoint on nodejs.org.

The problem is An existing connection was forcibly **closed by the remote host**., meaning nodejs.org is closing the connection. NVM4W doesn't control that.
Can you run nvm ls available? This makes a request to a different endpoint on nodejs.org.
ah yeah you're right

i tried your hint, same result :(
PS C:\Users\flow> nvm ls available
Could not retrieve https://nodejs.org/dist/index.json.
Get "https://nodejs.org/dist/index.json": write tcp <IP_ADDRESS>:52879-><IP_ADDRESS>:443: wsasend: An existing connection was forcibly closed by the remote host.

Something has to be happening on the network (including the remote end) to cause nodejs.org to close your connection. The code for downloading the index.json file is here (req, err := http.NewRequest("GET", url, nil). It's a standard Go HTTP request with absolutely nothing special about it. We can't get any more fundamental than that in Go. Plus, I can't recreate this error and I haven't seen anyone else post anything like this.
Ultimately, I don't think this is NVM4W issue. Since it works on one machine and not the other, I would recommend using something like Wireshark on both machines to compare the successful requests to the failed ones (to nodejs.org).


Create Use Case Diagram

Create the use case diagram of the project using UML. Add a shared link of the editable document of the diagram and add an image file of the diagram to the project docs.

Use case diagram created, here is the shared link I added Use diagram as an image to the prj docs it is  here


Add consistent table order in iptables-restore output and expand builder test coverage

Please provide a description of this PR:
Fixes #51491
I also fixed some comments/error messages  in the existing tests

@leosarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
79858b9606fe9eeac18f711e14ce1fc7deda2d5a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test unit-tests

LGTM! ty

ty a lot for the review :+1:


No longer able to create scalar date market

When trying to create scalar date market, following error appears:
Struct: failed on market_type: {"_enum":{"Categorical":"u16","Scalar":"RangeInclusive<u128>"}}:: Enum(Scalar):: Tuple: failed on 0:: Number needs to be an integer <= Number.MAX_SAFE_INTEGER, i.e. 2 ^ 53 - 1

@yornaath Needs to be fixed in the SDK


Default the OCP image to 4.10.15

Fix a problem when auto-configuring Azure, that we miss the infraId.
Automatically fill the Network podCIDR and serviceCIDR.
Fill the pull secret name if missing

Signed-off-by: Joshua Packer<EMAIL_ADDRESS>
Description of the change(s):

Fix a problem where 4.11 is being presented as the default OCP release

Why do we need this PR:

You can't do the simple deploy flow, it's broken. Real fix will be in acm-1420

Issue reference:

acm-1417

Test API/Unit - Success
?       github.com/stolostron/hypershift-deployment-controller/api/v1alpha1     [no test files]
?       github.com/stolostron/hypershift-deployment-controller/pkg      [no test files]
ok      github.com/stolostron/hypershift-deployment-controller/pkg/client       0.052s  coverage: 87.5% of statements
?       github.com/stolostron/hypershift-deployment-controller/pkg/constant     [no test files]
ok      github.com/stolostron/hypershift-deployment-controller/pkg/controllers  0.214s  coverage: 77.6% of statements
ok      github.com/stolostron/hypershift-deployment-controller/pkg/controllers/autoimport       0.042s  coverage: 60.6% of statements
ok      github.com/stolostron/hypershift-deployment-controller/pkg/helper       0.041s  coverage: 62.5% of statements
ok      github.com/stolostron/hypershift-deployment-controller/test/integration 21.230s coverage: [no statements]

/lgtm


listName attributes missing from fields.json ?

Based on the documentation and documentation example from here:
https://docs.ted.europa.eu/eforms/latest/codelists/index.html#_codelists_in_eforms_notice_xml
ProcurementTypeCode should have list name of "contract-nature" there are many fields in fields.json which do not have listname attribute set in the path, but they have code list defined as a value.
Even the example shown in the documentation is missing attribute name?
one example:
https://github.com/OP-TED/eForms-SDK/blob/develop/fields/fields.json#L11433-L11485
Schema:
https://github.com/OP-TED/eForms-SDK/blob/230557b69cb5e0ff30794b0113132dc2418675c4/schemas/common/UBL-CommonAggregateComponents-2.3.xsd#L3773-L3783
How can we programmically detect what list name should be used in each field?
Eforms code list example:
https://github.com/OP-TED/eForms-SDK/blob/develop/codelists/contract-nature_eforms-contract-nature.gc#L6
Now those eforms code lists have name "eforms-something-foo-bar" but the listName in the data should be "something-foo-bar"? Does this rule apply to all eforms specific code lists?
Could there be a field in the config that tells the name of the code list to be used in the data? Or does the data have different listName even if the value is selected from the same code list per schema location?

Hi,
From the referred example, we may extract the following lines.
{
    "id" : "BT-23-Part",
    "parentNodeId" : "ND-PartProcurementScope",
    "name" : "Main Nature",
    "btId" : "BT-23",
    "xpathAbsolute" : "/*/cac:ProcurementProjectLot[cbc:ID/@schemeName='Part']/cac:ProcurementProject/cbc:ProcurementTypeCode[@listName='contract-nature']",
    "xpathRelative" : "cbc:ProcurementTypeCode[@listName='contract-nature']",
    "type" : "code",
    "legalType" : "CODE",

    --- removed lines ---

    "codeList" : {
      "value" : {
        "id" : "eforms-contract-nature",
        "type" : "flat",
        "parentId" : "contract-nature"
      },
      "severity" : "ERROR"
    },

For "codelist", "id" is referring to the identifier of the codelist to be used for value selection and "parentId" to the listName attribute value to report when the listName attribute exists (i.e. element of type code in the XSD) and the value shall defer from the one of "id".
KR

Ok good to know.
And this rule

For "codelist", "id" is referring to the identifier of the codelist to be used for value selection and "parentId" to the listName attribute value to report when the listName attribute exist

Applies universally to all fields in the field.json right?

Do not miss the end of the sentence:

For "codelist", "id" is referring to the identifier of the codelist to be used for value selection and "parentId" to the listName attribute value to report when the listName attribute exists ... and the value shall defer from the one of "id".

meaning that, when it exists, the listName attribute shall have:

the "id" value, or
when "parentId" is specified in the json file, the "parentId" value.

The rule applies everywhere except for the few cases where the listName attribute is associated to a field (BT-03-notice, BT-26(a)-Lot, BT-26(a)-Part, BT-26(a)-Procedure).

Ok, makes sense now. Thank you


perf(rspack_core): add cache to depended_modules in code splitter

Summary
Code splitting has a hot path on depended_modules, this PR caches the result.
In a project a with 20k modules, code splitting time is reduced from 6s to 2s.
Related issue (if exists)

Types of changes

[ ] Docs change / Dependency upgrade
[ ] Bug fix
[x] New feature / Improvement
[ ] Refactoring
[ ] Breaking change

Checklist

[ ] I have added changeset via pnpm run changeset.
[ ] I have added tests to cover my changes.

@hyf0 this has a better perf improvement, please take a look.


Release a new version of Redux

Version 4.0.0 has been released back in April, which is half a year ago at the time of writing. It would be great to have Redux 4.1.0 to be published with all additions since April 2018 😄

@timdorr Could you please comment on the closing of this issue? Was this the appropriate to make this request?

There is no schedule for the releases. It will be done whenever I have time to run through it (I like to take care with releases, as it will mess up a lot of people's day if a bad release goes out). Asking doesn't affect this timeline.


LU should allow invalid data to save

LU
All up view and form view (without hoisted lu section)
To allow invalid data to save, before we have hoisted lu sections, it's should be as simple as .

[ ] update the logic to allow save even with validation errors

LG
All up view

[x] update the logic to allow save even with validation errors

In-line LG editor

[x] update lg parse to be robust when invalid content are given

[x] done in C#
[x] migrate to js

[x] migrate to new version of lg parser

As part of the linting effort we will close this out

addressed in #1667


filter Pickups Only within a radius

Thanks for this wonderful project.
I've seen that you have a function to  filter Pickups Only.
There is no option to set this on the website so to include it in a search.
When I set this variable to true on what basis will it filter?,  on the whole country or is it possible to include a zip code
to only show items near me

On ebay.de you can define a zip code and a max. radius for your search.  This is then encoded to the url.
But I have not found something similar on ebay.com
ebay.de example url:
https://www.ebay.de/sch/i.html?_localstpos=10115&_fcid=77&_sadis=50&LH_Distance=2&_fspt=1&_fpos=10115&_clu=2&gbr=1&_stpos=10115&_from=R40&_sacat=0&_sop=10&_nkw=smartphone&_dcat=9355&LH_PrefLoc=0&rt=nc&LH_BIN=1

Zip: 10115
Radius: 50
What you can try is to rip out the url parameter and check if they are working on ebay.com

Thanks a lot!


odin language support

Support for Odin. Tested locally with a small program, appears to work well.

Thanks!


SAK-40254: Portal > Improve messaging and styling of the 'Join Page'

https://jira.sakaiproject.org/browse/SAK-40254
The information and messaging displayed on the default 'Join Page' is very minimal and should be improved. The linked PR changes the style of the form to match the xlogin form, including using the new logo. See attached screenshots.

Updated wording for the buttons and background: $body-background-color;

@ottenhoff, are you good with the revision here?

Yes


Localization for Turkish

Firstly, thanks for the great work @mikecao. I'm so happy to use the app for our websites.
I translated the app into Turkish after saw your i18n commits.

Wow! This looks great. Thanks for helping out. It looks like you're missing one string though, message.delete-warning.

It seems OK now.


Add hfun_badges to generate badges for each package

This PR fixes #4. (x-ref: https://github.com/JuliaPackageComparisons/JuliaPackageComparisons.github.io/pull/41#issuecomment-1884545671)
I have not registered all mentioned packages to pkginfos dictionary yet. This should be updated in other PRs.
Screenshots:

That is amazing! I also love how the badges automatically pull in links to documentation in a familiar format, which is an issue I was wondering how best to solve. This looks really really good.
It currently looks like quite the manual process, but I guess packages and pages will be added less frequency in the future, so that a manual solution is good enough. Also, perfect is the enemy of the good, and a good solution today is a lot better than a perfect solution in a year when this project has lost relevancy.
Is there anything missing in this PR the way you see it?

Is there anything missing in this PR the way you see it?

This is ready to merge!
(I can rebase and add badges to the quaternions page, but that can be separated into another PR :smile: )

LGTM


?random  and  ?image=n not working as i thought it would

I don't mean this great tool isn't working right, i only intend to share my experience and trouble.
It looks like when you create a massive (50?) amount of posts with laravel's factory tool the ?random way isn't generating different pictures but the same over and over, probably because they all load at the same time.
An alternative i found was to use ?image=n, with n being a number between 0 and (i believe) 1083 using the php line
'img_url' => 'https://picsum.photos/960/640/?image=' . random_int( 0 , 1083 )
where the function random_int generates a random integer between those values and something like https://picsum.photos/200/300?image=34 persists in the database.
Perfect!!....but....;
the sequence of image's numbers is not perfect, so there are numbers pointing to nowhere (e.g.: https://picsum.photos/960/640/?image=708), and i have to delete manually those records  from the database.
Any suggestions to prevent that from happening?
If not, my suggestion would be preventing that list from having gaps, and problem solved!!
Further than that, thanks a lot for the tool!!!, it's GREAT!!!!

Hi, i've fased with same problem. Here is the link to a json object which contains all images on this service. So you can create an array with ids and get random id from it.
 You should be able to bypass it by passing along a random parameter, eg:
'img_url' => 'https://picsum.photos/960/640/?random=' . rand()

The ID's just happen to be numbers, there's no guarantee for all of them in the sequence to exist, hence why there is a /list endpoint to use if you want a list of all the images, to pick from or similar.
So another option would be to grab that first, and then use the list to get a list of images.

Thanks a lot for your help, i found the solution moving to unsplash


[kotlin] remove constructor method from generated code

Thanks for this great tool.
In data class in Kotlin, usually constructors are not needed.
Therefore in this PR I removed constructors from generated code.
I guess nothing will affect and it will be more Kotlin like code.
If I was missing something please tell me.
Refs
https://kotlinlang.org/docs/reference/data-classes.html

Thanks @omuomugin !

Maybe I am missing something here, but I do not think that the constructor was redundant.
The constructor was accepting a Map<String, Any>, which allowed us (using graphql-java) to just throw env.arguments in there.
Using<EMAIL_ADDRESS>our code looked sth like this:
// generated
data class QueryWikisArgs(
    val page: Int = 0,
    val size: Int = 20
) {
  constructor(args: Map<String, Any>) : this(
      args["page"] as Int? ?: 0,
      args["size"] as Int? ?: 20
  )
}

// our resolver/fetcher
val wikis: DataFetcher<List<WikiDto>> = DataFetcher { env ->
        val queryArgs = QueryWikisArgs(env.arguments)    //   <-- does not work with data class without a constructor
       ...
}

Our old code does not work without the constructor.
Using<EMAIL_ADDRESS>our code would look like:
// generated
data class QueryWikisArgs(
    val page: Int = 0,
    val size: Int = 20
)

// our resolver/fetcher
val wikis: DataFetcher<List<WikiDto>> = DataFetcher { env ->
        val page = env.arguments["page"] as Int? ?: 0,
        val size = env.arguments["size"] as Int? ?: 20
        val queryArgs = QueryWikisArgs(page, size)
       ...
}

That kinda defeats of the code generator, because changes in our schema still require manual work and type casts in our code afterwards.
Maybe I am just not aware of some Kotlin language feature related to data classes?


Could not retrieve/persist child entity !!!

We are migrating spring boot rest service to drop wizard rest service.
also we are using Mongo DB with Jackson.
In a Entity(parent) we are Associating a child entity, But we could not Save/Retrieve the child object using "DBRef<AddressData, String> addreddData;"
While retrieving the Json response is shown below,
{
"id": "57eb58a0cb101eff0cefec9f",
"userid": "13",
"username": "johnbecker",
"password": "pass1234",
"firstname": "John",
"lastname": "Becker",
"addreddData": {
"id": {
"time":<PHONE_NUMBER>000,
"new": false,
"inc": 217050270,
"timeSecond":<PHONE_NUMBER>,
"machine": -888135937
},
"collectionName": "address",
"collectionKey": {
"name": "address",
"type": "model.AddressData",
"keyType": "java.lang.String"
}
}
}
Similarily while saving Parent entity is persisting instead child entity is empty even though we are passing proper input JSON
{
"userid": "13",
"username": "johnbecker",
"password": "pass1234",
"firstname": "John",
"lastname": "Becker",
"addreddData": {
"addressid": 13,
"city": "Delhi",
"country": "India",
"state": "Delhi",
"street": "9th main road"
}
}
My Parent Entity :
`import org.hibernate.validator.constraints.NotEmpty;
import net.vz.mongodb.jackson.DBRef;
import net.vz.mongodb.jackson.Id;
import net.vz.mongodb.jackson.MongoCollection;
import net.vz.mongodb.jackson.ObjectId;
@MongoCollection(name = "user")
public class UserData {
@Id
@ObjectId
public String id;

@NotEmpty
public String userid;

@NotEmpty
public String username;

@NotEmpty
public String password;

@NotEmpty
public String firstname;

@NotEmpty
public String lastname;

@ObjectId
public DBRef<AddressData, String> addreddData;

}`
My Child Entity :
`import org.hibernate.validator.constraints.NotEmpty;
import net.vz.mongodb.jackson.Id;
import net.vz.mongodb.jackson.MongoCollection;
import net.vz.mongodb.jackson.ObjectId;
@MongoCollection(name = "address")
public class AddressData {
@Id
@ObjectId
public String id;

@NotEmpty
public int addressid;

@NotEmpty
public String street;

@NotEmpty
public String city;

@NotEmpty
public String state;

@NotEmpty
public String country;

}`
Please suggest some solution for retrieving/persisting the record in child object.

Sorry for the late response but this doesn't sound like an issue with dropwizard and may a more appropriate post in dropwizard-users list


update code

Would you please tell me when you are going to release the code? Thank you!

linked to #1 , please see the update on this issue


Abhinav/dev branch

#244 #243 #242….. #237 #241

This is the django webapp that Abhinav developed to simplify the process of installing and setting up OEA.
It's still in its early stages.
Approved.


Adding external barcode reader for PDF417 barcodes

Hi @ericblade , I saw your comment in https://github.com/serratus/quaggaJS/issues/70#issuecomment-396465816 where you mentioned that it could be possible to wire up js-zxing-pdf417 to quagga with the help of an external decoder. I am interested in using quagga to read pdf417 barcodes off of scanned documents that users will upload.
The quagga2 readme mentions that a qr-reader has been integrated in a separate repo, but the qr-reader doesn't use the BarcodeReader prototype for integration. I am wondering if making a PDF417 reader should follow the same path that the qr-reader is doing, considering that both qr and pdf417 are 2D barcodes?

I believe that BarcodeReader is going to be probably mostly only useful for 1D barcodes, although if it were extended to be able to detect the area that 2D barcodes occupy, that would be a great improvement, as I'm sure providing just the imagedata that actually needs to be decoded would make it easier for any decoder to figure out.
So, yeah, I think probably best to wire it like the prototype QR reader, which simply takes the entire image data, and passes it to a separate library that figures it out from the entire image.
That said, if you are able to get any useful output from BarcodeReader as to where the rectangle that contains the barcode is, that would probably improve your chances of getting a good read.

Thanks for the clarification! Can you explain more about "extending BarcodeReader to detect the area that 2D barcodes occupy":

Is this a change that I would commit to the quagga2 repo?
Assuming it is, then I assume all relevant changes would only need to be made in barcode_reader.ts, right?
Assuming yes, can you provide some insight as to what the 5 protected functions in the BarcodeReader class are doing? (there's no documentation, so it's not entirely clear what role _nextUnset or _matchPattern is supposed to do)
It seems public decodePattern(pattern: Array<number>) is the only function that we would override if we are going to create our own plugin on top of BarcodeReader. Assuming that the 2D processing is implemented, would that function signature change to something like public decodePattern(pattern: Array<Array<number>>)? Or should we add an entirely new function in BarcodeReader that users can override (eg public decodePattern2D(pattern: Array<Array<number>>)?

@ericblade Hi, just following up on the above questions. Even if you don't have a complete answer for every question, even a partial answer for each question (eg knowledge of some functions) would be hugely helpful.

@hareharey sorry, I didn't notice the first reply!  Thanks for getting my attention again
One of the more important features in Quagga, I think, is the Locator in src/locator/barcode_locator , which figures out where in an image a barcode-like area is found, which I'm pretty sure if found, then goes through some processing to send only that area through to the decoder.
I was thinking if the locator could locate 2D barcodes as well as 1D, then even if we don't have any built in BarcodeReader classes that can handle it, we could at least make the job for whatever does read the code easier.  Maybe my psuedo-solution of just passing the entire image to an external 2D reader would be fine, too.
I don't really know anything about 1D vs 2D codes, or if there is any standard delineation around them.
I also don't know if any of the pieces of BarcodeReader would be useful in decoding them.  I honestly don't think, with such a good library as zxing-js available, that we would gain a lot by implementing a whole Reader/Decoder system, but there might be value to a Locator.  There definitely is value in the locator in 1D barcodes, I tried a lot of barcode systems before quagga, and quagga was the only one that consistently was able to decode sideways and diagonal 1D codes

I am also interested in PDF417 barcodes.
It is important to distinguish between the more common types of barcodes:

1-dimensional barcodes
1-dimensional "stacked" barcodes.  This includes PDF417, Code 49, and Code 16k.  Effectively there are a series of small height bar codes that are stacked on top of each other.  They have leading and trailing signatures that are the full height of the stacked bar codes.   These signatures likely violate the standard "quiet zone" of a normal 1D barcode as they are in the zone and have their own quiet zone.
True 2-dimensional bar codes, such as QR Codes, Data Matrix, Code One, and Aztec codes.  These have special markers that help identify and locate the barcode.

The challenge with PDF417 may include increasing the resolution of the scanning (eliminating half-sample and decreasing the patch size) so that the individual bar codes that are stacked are recognized, changing the recognition of the quiet zone, and detecting the prefixing and suffixing signature.


Run code restyle on ToT

Problem
What is being fixed?  Examples:

Fix restyle error reported on the master ToT

Change overview
no logic change, run code restyle on ToT and merge the update
Testing
How was this tested? (at least one bullet point required)

Checkout the latest ToT
Run restyle "sudo ./scripts/helpers/restyle-diff.sh"
Verified by CI restyle

Hotfix because other things will fail restyled if they are based on current tip.


No develop branch?

I get kind of nervous when making pull requests into master instead of develop. Any chance we can have develop branches to develop against?

@nii236, you can push to any branch in your personal account and then sync to master.


[solidity] Fix wrong check on recursive-process-input CLI option.

Fix the check for the validity of --recursive-process-input to make sure that it is only selected when --recursive-process is also selected.

Sorry. My brain must have short circuited when I fixed that clippy lint


Ensure that API filters are the first executed

Hi,
I encountered an issue with Laravel route group filters and dingo API basic authentification provider today.
Let's suppose that we are requesting /api/foo/bar with a valid HTTP basic authentification header and that we have this routes.php file :
Route::api(
    [
        'version' => 'v1',
        'prefix' => 'api',
        'protected' => true,
    ],
    function () {
        Route::group(
        [
            'prefix' => 'foo',
            'before' => 'foo',
        ],
        function () {
             Route::get(
                 '/bar',
                 [
                     'as' => 'foo.bar',
                     'uses' => 'FooController@bar'
                 ]
             );
        }
    }
);

In that case, I observe that the foo filter is executed before the user basic authentification one. But with this behavior, I can't do any user validation in foo filter because no user is logged in yet.
I think that every API filters should be executed before any others to avoid this issue.
Laravel has this routing behavior (in a short form ^^) :
$action = Route::parseAction($routeData);
$groupAction = $groupData + $action;
$fullAction = Route::parseAction($groupAction);

So the API filters must be deleted (if exist) and placed in the beginning of filters array in every Route::parseAction() call.

Cheers mate, sorry it took so long to merge!

This should resolve #387, nice one!


strava implements export

Codecov Report

Merging #12 (4daa54a) into main (f0528e8) will increase coverage by 0.12%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   55.27%   55.39%   +0.12%
==========================================
  Files          34       34
  Lines        1791     1816      +25
==========================================
+ Hits          990     1006      +16
- Misses        703      709       +6
- Partials       98      101       +3

Impacted Files
Coverage Δ

strava/activity.go
67.88% <60.86%> (-0.83%)
:arrow_down:

strava/strava.go
76.19% <100.00%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0528e8...4daa54a. Read the comment docs.


Move all plugins to depend on this version of the COWorkflows plugin

Working with many versions of the COWorkflows plugin is a mess.
Modify all plugins to use this version. Ensure all changes from non-public other COWorkflow repos into this repo.

Only works for the "newer" plugins. But we can do it with them.


Update mappedfile.c: fix large files support on Windows

changed GetFileSize call to GetFileSizeEx to support files larger then 4 GB (2^32 bytes)

Fixed in https://github.com/NiraOfficial/niraclient-c/commit/19c4ece9294ee799b77ed6280966e6d434342edf
Thanks!


Labels appears under "Beta configuration" instead of "Configuration"

When listing a session created with labels, they appear under "Beta configuration" instead of "Configuration"
actual
-------------------------------------------------------------------------------
Session: 372af41d-015d-4d17-894a-281759a69074
Configuration:
        Synchronization mode: Default (Two Way Safe)
        Maximum allowed entry count: Default (2⁶⁴−1)
        Maximum staging file size: Default (18 EB)
        Symbolic link mode: Default (Portable)
        Ignore VCS mode: Default (Propagate)
        Ignores: None
Alpha configuration:
        URL: C:\Users\Toilal\projects\a
        Watch mode: Default (Portable)
        Watch polling interval: Default (10 seconds)
        Probe mode: Default (Probe)
        Scan mode: Default (Full)
        Stage mode: Default (Mutagen Data Directory)
        File mode: Default (0600)
        Directory mode: Default (0700)
        Default file/directory owner: Default
        Default file/directory group: Default
Beta configuration:
        URL: C:\Users\Toilal\projects\b
        Watch mode: Default (Portable)
        Watch polling interval: Default (10 seconds)
        Probe mode: Default (Probe)
        Scan mode: Default (Full)
        Stage mode: Default (Mutagen Data Directory)
        File mode: Default (0600)
        Directory mode: Default (0700)
        Default file/directory owner: Default
        Default file/directory group: Default
        Labels:
                test: abc
Alpha:
        Connection state: Connected
Beta:
        Connection state: Connected
Status: Watching for changes
-------------------------------------------------------------------------------

expected
-------------------------------------------------------------------------------
Session: 372af41d-015d-4d17-894a-281759a69074
Configuration:
        Synchronization mode: Default (Two Way Safe)
        Maximum allowed entry count: Default (2⁶⁴−1)
        Maximum staging file size: Default (18 EB)
        Symbolic link mode: Default (Portable)
        Ignore VCS mode: Default (Propagate)
        Ignores: None
        Labels:
                test: abc
Alpha configuration:
        URL: C:\Users\Toilal\projects\a
        Watch mode: Default (Portable)
        Watch polling interval: Default (10 seconds)
        Probe mode: Default (Probe)
        Scan mode: Default (Full)
        Stage mode: Default (Mutagen Data Directory)
        File mode: Default (0600)
        Directory mode: Default (0700)
        Default file/directory owner: Default
        Default file/directory group: Default
Beta configuration:
        URL: C:\Users\Toilal\projects\b
        Watch mode: Default (Portable)
        Watch polling interval: Default (10 seconds)
        Probe mode: Default (Probe)
        Scan mode: Default (Full)
        Stage mode: Default (Mutagen Data Directory)
        File mode: Default (0600)
        Directory mode: Default (0700)
        Default file/directory owner: Default
        Default file/directory group: Default
Alpha:
        Connection state: Connected
Beta:
        Connection state: Connected
Status: Watching for changes
-------------------------------------------------------------------------------

Thanks for reporting this.  The intention was for the labels to appear after the beta configuration, but the labels had an extra level of indentation and thus looked like they were appearing as part of the beta configuration.
I've moved the printout of labels to right after the session identifier and included labels in short listings as well.  I'll tag a release in a few minutes with the fix.

v0.9.0-beta3 is now available and should fix the issue.  Thanks again!


Calico pod cannot register

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
Kubernetes 1.29.7 + calico CNI
What did you expect to happen:
Calico able to register
Defaulted container "calico-node" out of: calico-node, flexvol-driver (init), mount-bpffs (init), install-cni (init)
Error from server: Get "https://<IP_ADDRESS>:10250/containerLogs/calico-system/calico-node-qpmx6/calico-node": http: server gave HTTP response to HTTPS client

is there a calico pod attempting to run on one of the kubemark nodes?


remove-metrics-ready content

Removing metric ready content in user docs per notion
What are you changing in this pull request and why?

Checklist

[ ] Review the Content style guide and About versioning so my content adheres to these guidelines.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry _redirects
[ ] Ran link testing to update the links that point to the deleted page

made commits as Matt suggested and merging pr as pr is approved and to avoid the back and forth.


Erro ao criar conteiner

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing 😞

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain biomassiv.es has exceeded the max emails per hour (101/100 (101%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext4.iad.github.net ([<IP_ADDRESS>]:58843 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by chi-server32.websitehostserver.net with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.89)
(envelope-from<EMAIL_ADDRESS>id 1eMLDE-0013Rx-KM
for<EMAIL_ADDRESS>Tue, 05 Dec 2017 15:57:12 -0600
Date: Tue, 05 Dec 2017 13:56:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1512510992;
bh=5uDReQc9wxZVn6djy9yGl3MFjVSWQ/MeO2zM0UeKoyE=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=OHgBsJ2rD5jzp3w8Z+430sJn34fexpN1E/ci8QpQIQayINXNvwbqmR69OGRJJOar7
FSSMFdHZADqEwJKD0npvC94XcXlfs7kYqolCt337JFQdajL9GnqcgyT4zdGNPhps8s
hNMYs4Q50iHOAVjeu5Ni0SfdtqV0+Nj5o9LrK4qM=
From: French Ben<EMAIL_ADDRESS>Reply-To: docker/kitematic<EMAIL_ADDRESS>To: docker/kitematic<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [docker/kitematic] Erro ao criar conteiner (#3351)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5a271610ce33c_27303f99b36eaf28108984";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: FrenchBen
X-GitHub-Recipient: biomassives
X-GitHub-Reason: subscribed
List-ID: docker/kitematic <kitematic.docker.github.com>
List-Archive: https://github.com/docker/kitematic
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AELU4o7mxZPfkZiTr4t3EhMqyZDF1fQgks5s9bwQgaJpZM4Qqn2s
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>----==_mimepart_5a271610ce33c_27303f99b36eaf28108984
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
No information provided or steps to replicate - Closing =F0=9F=98=9E
-- =
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/docker/kitematic/issues/3351#issuecomment-349454847=
----==_mimepart_5a271610ce33c_27303f99b36eaf28108984
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
No information provided or steps to replicate - Closing =F0=9F=98=9E
&m=
dash;You are receiving this because you are subscribed to this thre=
ad.Reply to this email directly, view it on GitHub, o=
r mute the thread.

=
----==_mimepart_5a271610ce33c_27303f99b36eaf28108984--

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain biomassiv.es has exceeded the max emails per hour (102/100 (102%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o6.sgmail.github.com ([<IP_ADDRESS>]:24485)
by chi-server32.websitehostserver.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.89)
(envelope-from<EMAIL_ADDRESS>id 1eMLDH-0013TD-Gx
for<EMAIL_ADDRESS>Tue, 05 Dec 2017 15:57:15 -0600
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=G5JP5j7gOHQKd06QN4LtCG5dI7A=; b=c5Q7MtlV4MZqdVQW
uKt/gXrjtjWXs7dDU9zF0MF5gZo6Kevk7HUCTcXNVgFmMlRgzHN5N48BpvwTF+wr
u3VKVq7mg9iKA26ogJk8N5/JAaVHg74FmiWXFdHrPzbmZMbOy6DUY+dYiyxMqiiN
kxslaFkVu5IK2/f/m0ozhPTw3Zg=
Received: by filter0523p1las1.sendgrid.net with SMTP id filter0523p1las1-28298-5A271613-43
2017-12-05 21:56:35.856539168 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id TpPABFCXR9m1BtMMnXlVCQ
for<EMAIL_ADDRESS>Tue, 05 Dec 2017 21:56:35.547 +0000 (UTC)
Date: Tue, 05 Dec 2017 21:56:35 +0000 (UTC)
From: French Ben<EMAIL_ADDRESS>Reply-To: docker/kitematic<EMAIL_ADDRESS>To: docker/kitematic<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [docker/kitematic] Erro ao criar conteiner (#3351)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5a2716136ca2d_492b3ffdcde6ef285517";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: FrenchBen
X-GitHub-Recipient: biomassives
X-GitHub-Reason: subscribed
List-ID: docker/kitematic <kitematic.docker.github.com>
List-Archive: https://github.com/docker/kitematic
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AELU4uWh3IOxx7B_CcKBJANzJynQke1Cks5s9bwTgaJpZM4Qqn2s
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: ZlaDthyue/4HG+EgTb7JoZYs48JNb2iQtCcPV6oIs9Ww+n9VNVXyQetGxHlV6qRo4ncZ2citz/vrpI
7bt0AwIboo1wM1KrQbktm/vKuSMg0Cnu6/lmqfv1UfDHllx15NPSDb7UWPWigINm3tmvJQHt21SwOo
QCD7KK3lbnm8ZjrEBx7qajPMUtXaValcf8wVmwG1mB0GYSlXC670/phP/Q==
----==_mimepart_5a2716136ca2d_492b3ffdcde6ef285517
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3351.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/docker/kitematic/issues/3351#event-1373626160
----==_mimepart_5a2716136ca2d_492b3ffdcde6ef285517
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3351.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5a2716136ca2d_492b3ffdcde6ef285517--


Short audio files don't get played completely

I am creating a mapping for some drum kit library, and noticed that very short files don't get played out correctly. This happened under Linux, against JACK backend, using sfizz-git, branch "development", commit ID ce2170c88d.
I have attached a ZIP archive testdata.zip with an example .sfz and 3 short files of pink noise to show the effect.
The 0.2s and 0.1s duration files get played out correctly; the 0.05s file is only played partially.
This is also seen in the enclosed screenshot from a jack_capture run of that session.

Even though this might look like a "synthetic" test, there are in fact very short (hihat) samples that have roughly the same duration.
I assume this is not some kind of automatic "noise gate" kicking in?
If more info is needed, let me know. Thanks.

There is some form of noise gate but it should not be active here. Thanks for the report !

This is possibly another case of the short sample being interpreted as a wavetable.
Can you try with oscillator=off?

Can you try with oscillator=off?
Yes, that seems to be it! I added "oscillator=off" after the  tag in several problematic .sfz drumkit files, and in all cases the swallowed or truncated samples now play correctly. So I guess it's an "intelligent" feature that one should be aware of.
The documentation is not very clear about this opcode: https://sfzformat.com/opcodes/oscillator
I wonder whether its default should be off? Anyway, thanks for the hint, most welcome!

It is behavior which imitates cakewalk sfz.
There is a paragraph which mentions this.

Ok, understood..thanks for digging this out.
I still feel like there might be some more drumkit SFZ writers like myself who will find this irritating.
E.g. synthetic Hi-hat samples can be pretty short. Well, whatever, I learnt my lesson :-).

In the end I'm not sure that this feature does us a great service.
It breaks expectations of a user coming from sforzando.
On the other hand sforzando has never implemented the wavetable feature. (not that I know anyway)

Then again @jpcima sfizz could still support wavetables with oscillator=off as default.

In cakewalk dropzone, this definitely is a drag-and-drop feature.
Most sound files which are wavetables don't contain a discriminating feature that identifies them with certainty.
But we could use the audio size in frames. Wavetables will extremely likely be a power of 2.
It reduces significantly, although not totally, the probability of error.

In cakewalk dropzone, this definitely is a drag-and-drop feature.
Most sound files which are wavetables don't contain a discriminating feature that identifies them with certainty.
But we could use the audio size in frames. Wavetables will extremely likely be a power of 2.
It reduces significantly, although not totally, the probability of error.

Honestly if this is confusing where < XXX samples, I think a rule that says  < XXX samples AND a power of 2 is even more confusing for non-developers.
I'd be more keen to disable the auto-detection entirely and let users verbosely decide to read the file as a wavetable.

I'll put in a vote to disable the auto-detection. It caused me a lot of confusion at one point.
Using wavetables is a deliberate and specific choice, so having to enable them manually seems reasonable.

I'd be more in favor of disabling the auto-detection entirely and let users decide to read the file as a wavetable.

Another possibility, it's oscillator=off as default, and oscillator=auto in case of importing audio files.
This preserves the drag-and-drop functionality.

For DnD function, why do we need auto? Could not the importer set the oscillator mode to on if the sample is heuristicly determined to be a wavetable?

heuristicly determined

it's what oscillator=auto does.

size < 3000 frames
has wavetable chunks in the audio file


Is VRTK plugin for Unity SteamVR compatible?

NOTE: Any issue that does not follow the below template will be immediately closed and not re-opened until the template structure is adhered to.

Precheck

Do not use the issues tracker for help or support (try VRTK Slack channel, Stack Overflow, etc.)
For proposing a new feature, please check existing open and closed issues before creating a duplicate
For bugs, do a quick search and make sure the bug has not yet been reported
Finally, be excellent to each other, and party on dudes!

Environment

Source of VRTK (Unity Asset Store or Github)
Version of VRTK (Unity Asset Store/Github release number) (Github master commit hash)
Version of Unity3D (e.g. Unity 5.4.4f1)
Hardware used (e.g. Vive/Oculus)
SDK used (e.g. OpenVR/SteamVR/Oculus Utilities)

Steps to reproduce
Attempt to recreate the issue in a VRTK example scene and provide steps to reproduce in a clear text step by step list. Include code samples, errors and stacktraces if appropriate.

Do not upload custom projects with custom code to demonstrate the issue.

Expected behavior
Briefly describe what you expect should happen
Current behavior
Briefly describe what is actually happening
Hi
Good morning, I am interested in working with VRTK and with a VR hardware SteamVR compatible named Cybershoes (more info here)
https://www.kickstarter.com/projects/cybershoes/cybershoes-step-into-vr/description
For it, Could I use the VRTK an with this VR compement device?
Thanks for your time
Alejandro Castan

GitHub Issues are for bug reports. direct your questions in the slack channel at http://invite.vrtk.io


Color Table Window Overhaul May 2023

Description
Resolves #18490
Resolves #18674

Type of change

[x] Bug fix~~
[x] New feature~~
[ ] Documentation update~~
[ ] Other

How Has This Been Tested?

Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[ ] I have commented my code where applicable.~~
[ ] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.~~
[ ] I have added debugging support to my changes.~~
[ ] I have added tests that prove my fix is effective or that my feature works.~~
[ ] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.~~
[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Pending discussion in a special topics meeting to get team approval and feedback on new CT window design.


Import TGF format

https://en.wikipedia.org/wiki/Trivial_Graph_Format

[x] find TGF files from the wild internet
[x] have a Junit test which reads TGF and write GraphML (depends on GraphML stuff, of course)
[x] add some simple tests (parse several files and verify validation errors are found)
[x] Adapt to new finding: edges are optional, even empty graph is valid

Testing in #44


Add Alexander Vladimirov to contributors list.

Ready for review.

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The tutorial was fine and easy to use. I did not have Confidence to join any open-source projects, because not to mess anything. Had job as a Java developer  but had to quit for personal reasons. Two years has passed and no luck. But I'm looking forward to change that, Step by step. :)


Audit inline docs to ensure js blocks are labeled as such

This is an example of a block that is correctly labeled.
And this is an example block that needs the javascript label added. I'm not sure if json is a valid label...but I'll try that out!
Given enough time, I'll open a PR for this. But I'm continuing to prioritize work on the technical side of the www at the moment.

Closing in favor of the central API doc tracking issue #447


Cannot spawn Arbiter's thread: "actix-rt|system:0|arbiter:56"

Discussed in https://github.com/meilisearch/MeiliSearch/discussions/1821

Originally posted by Aniket-IN October 16, 2021
Hi, I'm new to MeiliSearch,
I got MeiliSearch up and running on my local machine, it works great.
Database path:          "./data.ms"
Server listening on:    "http://<IP_ADDRESS>:6002"
Environment:            "development"
Commit SHA:             "2e2eeb0a424408e27f4223e58afec303c53e1419"
Commit date:            "2021-10-12T14:47:06+00:00"
Package version:        "0.23.1"

But when I tried to setup on the server (Linux), its returning this error.
[2021-10-16T15:10:02Z INFO  actix_server::builder] Starting 64 workers
thread 'main' panicked at 'Cannot spawn Arbiter's thread: "actix-rt|system:0|arbiter:56". Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-rt-2.2.0/src/arbiter.rs:154:17

I have no clue, What's wrong, I have tried changing the port but still same :(
Tho my data.ms folder is generated successfully. I think only the web server failing to start.
Any help would be appreciated..
Thanks in advance :)

Hello @Aniket-IN
Can you try to remove the data.ms folder, start MeiliSearch again, and re-import your data? Sorry for the inconvenience 😕

Hi @curquiza ,
That is the first thing I tried but no luck :(

Closing this issue since it's old, feel free to reopen if you or someone else still have the issue of course with the latest version of MeiliSearch.


[1.43.x] Issue - #3669 AbstractProcessInstance.java : Recursively getNodeInstances for the p…

…ending Human tasksduring reconnect
In case of a Embedded Subprocess, the NodeInstance would be of type CompositeContextNodeInstance and so inorder to process the work item, it needs to be recursively scanned for any HumanTasks inside the embedded subprocess

Many thanks for submitting your Pull Request :heart:!

Fixes #3669
https://github.com/apache/incubator-kie-kogito-runtimes/issues/3669

**In case of a Embedded Subprocess, the NodeInstance would be of type CompositeContextNodeInstance and so inorder to process the work item, it needs to be recursively scanned for any HumanTasks inside the embedded subprocess
**

Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Your code is properly formatted according to this configuration
[x] Pull Request title is properly formatted: Issue-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

Fix: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3670

superseeded by https://github.com/apache/incubator-kie-kogito-runtimes/pull/3673 in main branch