Popup content via Ajax with HTML and Javascript code

Hi @walkermatt, this is not really an issue but more a tutorial.
For many times i have modded your OL Popup script with an XMLHttpRequest (Ajax):
https://github.com/walkermatt/ol-popup/issues/217
This i am used in a few of my OSM OL websites.
Yet i had a problem, when the Ajax content have HTML and Javascript inside. More specifically, I had the problem of editing the popup content after insertion (innerHTML successfully completed) via javascript.
I am currently creating such an Ajax popup map, which can also be used by others. The idea is that data stored on the server is loaded into the popup via Ajax and can then also be edited there via Javascript. Example:
One of the data consists of a number (0-100). This number is to be converted by Javascript (Object) into a word. {"0": "word"}. Now I had thought that I embed a javascript function in the popup HTML content that is created on the server. Which will be triggered as soon as the popup content is loaded. But this does not work without further effort.
But there is a problem. Javascript code that is embedded in HTML code and sent via Ajax and inserted via innerHTML is not executed. There is one exception: Pure javascript code written inside eval() and inserted via Ajax and innerHTML will be executed.
It is possible to realize the thing without executing 2 x XMLHttpRequest - with HTML code and Javascript code separately. For this the OL popup code must be extended a bit.
The thing is that I don't know how an OL Popup Ajax Map user wants to edit the popup content with javascript. He could already adjust the HTML content via PHP, but that's going too far, because I don't want users to edit in the (Ajax) PHP code.
I made the whole map software as simple as possible. It is a bit complex, but not more than necessary.
I made the Ajax PHP code very simple. There is a single text file, which can be used to control the rough structure (order) of the arrangement of the data in the popup. Furthermore there is a custom-style.css which can be used to style the popup content.
It would be possible to execute the custom-style javascript code using setInterval() and clearInterval(). So by checking when the popup content is completely loaded, and then the custom-style JS code is executed. I had already coded this, but I didn't like it.
I came across eval() while searching. However, this has to be included absolutely separately via Ajax and innnerHTML - with a single XMLHttpRequest.
The solution is to extend the ol-popup script and append an additional div-box ol-popup-content-customscript (with display:none) to the div-box ol-popup. Into this additional div-box a eval() is inserted via popup.show while filling the popup via Ajax. This eval() triggers a function - the custom-style function - eval(typeof popuploadcustomscript === 'function' ? popuploadcustomscript() : 'ERROR'). The function popuploadcustomscript is located in the file custom-style.js, and inside the function the user javascript code.
The div-box ol-popup-content-customscript gets display:none, because eval() inserts an undefined.
index.html/php
<script src="custom-style.js"></script>

custom-style.js
function popuploadcustomscript() {
// user-created Javascript code here, like ... {"0": "word"}
}

ol-popup-400.js (expanded code places)
        var element = document.createElement('div');

        options.element = element;

        var _this = possibleConstructorReturn(this, (Popup.__proto__ || Object.getPrototypeOf(Popup)).call(this, options));

        _this.container = element;
        _this.container.className = 'ol-popup';

        _this.closer = document.createElement('a');
        _this.closer.className = 'ol-popup-closer';
        _this.closer.href = '#';
        _this.container.appendChild(_this.closer);

        var that = _this;
        _this.closer.addEventListener('click', function (evt) {
            that.container.style.display = 'none';
            that.closer.blur();
            evt.preventDefault();
        }, false);

        _this.content = document.createElement('div');
        _this.content.className = 'ol-popup-content';
        _this.container.appendChild(_this.content);

// ### CUSTOMSCRIPT CODE ↓↓↓
	_this.content_customscript = document.createElement('div');
        _this.content_customscript.className = 'ol-popup-content-customscript';
        _this.container.appendChild(_this.content_customscript);
// ### CUSTOMSCRIPT CODE ↑↑↑

// ...

        value: function show(coord, html) {
            if (html instanceof HTMLElement) {
                this.content.innerHTML = "";
                this.content.appendChild(html);
// ### CUSTOMSCRIPT CODE ↓↓↓
		this.content_customscript.innerHTML = eval(typeof popuploadcustomscript === 'function' ? popuploadcustomscript() : 'ERROR');
// ### CUSTOMSCRIPT CODE ↑↑↑
            } else {
                this.content.innerHTML = html;
// ### CUSTOMSCRIPT CODE ↓↓↓
		this.content_customscript.innerHTML = eval(typeof popuploadcustomscript === 'function' ? popuploadcustomscript() : 'ERROR');
// ### CUSTOMSCRIPT CODE ↑↑↑
            }
            this.container.style.display = 'block';
            this.content.scrollTop = 0;
            this.setPosition(coord);
            return this;
        }

Thats all!
When the popup content is loaded completely, the custom-style Javascript will be executed.

 The corret solution:

In the external content put Javascript code in a <script> tag normaly.
eval() this Javascript code in the OL Scricpt in the popup.show function.

Example:
create-ajax-content.php
<?php
echo 'many HTML code';
// ...
echo '<script>';
echo 'popuploadcustomscript()'; // or you external JS code that should be execute.
echo '</script>';
?>

ol-script.js (expanded code places)
        value: function show(coord, html) {
            if (html instanceof HTMLElement) {
                this.content.innerHTML = "";
                this.content.appendChild(html);
            } else {
                this.content.innerHTML = html;
            }
            this.container.style.display = 'block';
            this.content.scrollTop = 0;
            this.setPosition(coord);
// ### STYLESCRIPT CODE ↓↓↓
			eval(this.content.getElementsByTagName("script")[0].innerHTML);
// ### STYLESCRIPT CODE ↑↑↑
            return this;
        }

The eval(this.content.getElementsByTagName("script")[0].innerHTML) will execute the 'popuploadcustomscript(). Have you more <script>-tags in you external HTML code, you must change the Array position [0]`, or use any other methods.
I have the function popuploadcustomscript() saved in a custom-style.js and have it embedded in my index.php.


Build release branches on Travis

Build release branches on Travis

Definition of Done

[x] There are no TODOs left in the code
[x] The continuous integration build passes

Coverage remained the same at 85.552% when pulling f5e9c7b40d973afd27ad86e57b60bfa06b6f30b2 on dmitry-timofeev:build-release-branches into 02a1a9bf80671fe2ae17bfd7fbe93851d8aed3f9 on exonum:master.


build protobuf version compatibility error

Under Ubuntu 18.04, everything fine until "make build", where it crashes due to protobuf incompatibility (errors), in both scenarios: with either a (i) globally installed K, or (ii) a K submodule. Perhaps specify the precise protobuf version that should be used? [building from scratch]

Hi!
Same problem (?) for me, but I think the solution is:
sudo apt-get install libprotobuf-dev.


Add tests

Add tests

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[BUG] warning MSB3277: There was a conflict between "Azure.Core, Version=<IP_ADDRESS>... nd "Azure.Core, Version=<IP_ADDRESS>

Library name and version
Azure.Core <IP_ADDRESS>  and <IP_ADDRESS>
Describe the bug
Couldn't build my project. Thanks for your help.
Got this error - Microsoft.Common.CurrentVersion.targets(2352,5): warning MSB3277: There was a conflict between "Azure.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8" and "Azure.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8".
Microsoft.Common.CurrentVersion.targets(2352,5): warning MSB3277:     "Azure.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8" was chosen because it was primary and "Azure.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8" was not.
Expected behavior
I could use <IP_ADDRESS> and project should build successfully.
Actual behavior
Project couldn't build.
Reproduction Steps
Project A has transitive package reference to Azure.Core <IP_ADDRESS>. Class library project B has transitive package reference to Azure.Core <IP_ADDRESS>. Project A references project B.dll. Error occurs when project A is building.
Environment
No response

Hi @da-ms-22.  Thank you for reaching out and we regret that you're experiencing difficulties.  The root cause of this is how .NET resolves dependencies and is not something that the Azure SDK packages can influence nor control.  Mitigation should be to add a direct reference for Azure.Core v1.30.0 to "Project A", which will allow it to take precedence over the conflicting transitive dependencies and hoist the version used.
I'm going to mark this as addressed, but please feel free to unresolve if you'd like to continue the discussion.

Thank you. Adding a direct reference for Azure.Core v1.30.0 to "Project A" solved the issue.


Explicit system ordering

What problem does this solve or what need does it fill?
Ensuring that one system A has run before the next system B is an extremely common pattern, allowing us to ensure that the data in B has been pre-processed appropriately before we handle it.
As discussed in the alternatives section, there are three ways to get similar behavior: implicit declaration order, stages and system chaining. All of these are inadequate for the common case where you simply care that A has completed before B begins.
Describe the solution would you like?
Option 1.  Remove the implicit guarantee that systems added first within a stage run before those added after it. This encourages people writing confusing, brittle code that can't be refactored safely. In its place, add a data-structure that unambiguously specifies the dependency graph of conflicting access to data within a stage, ideally verified at compile-time.
The total order created by the system registration order is sufficient, but not necessary, to ensure that we can always find a deterministic system ordering. While this total ordering is intuitive for small programs, it becomes unwieldy for games with more than one file adding systems to the same stage and the overspecification can cause unpredictable changes to unrelated systems.
Instead, we can get away with constructing a directed acyclic graph, with all systems within the stage as a node.  In order for a system to be scheduled, each of its parents must be complete. But much of this graph can be constructed automatically: only key relationships between systems that share conflicting component / resource access need to be disambiguated.
This ensures that ordering constraints of each stage is well-documented in a single place, trivial to helpfully visualize, easy to consume for new schedulers and must be manually changed when important new behavior is modified.
If we ensure that systems are static (and instead toggle optionality with run criteria and custom schedulers), this graph can be constructed and verified unambiguous at compile time, making it a powerful dev tool to prevent painful ordering-driven logic bugs and identify system parallelism bottlenecks.
Option 2. Add a good way to examine and modify the system registration order, in order to detect and fix problems created by system ordering. Adding systems before or after another system could then, at game startup, simple squish into the registration order in a postprocessing step, bumping later entries down. Of course then, if you have multiple systems being added after the same system that was inserted in the ordinary way, you've reproduced the pattern and probably need to rely on registration order of the ordered systems as well :(
Describe the alternative(s) you've considered?

Implicit declaration order: simply declare the systems in order, and the scheduler makes sure they obey certain rules. This is very hard to follow, prone to being accidentally broken in mysterious ways, and forces us to record and verify the declaration order in our scheduler. The problems with this get much worse as the project grows, and systems are added in plug-ins, with the timing interacting in mysterious ways based on the arbitrary order that the plug-ins themselves are added.

Stages: You can ensure that one system runs after another by ensuring that they're in distinct stages. But this introduces a serious parallelism hit: rather than only waiting for your dependencies to complete, you're also stuck waiting for all the other systems in that stage to complete. On larger projects, I could also see this producing a messy proliferation of stages whose purpose and relation becomes unclear.

System chaining: This pattern seems much better suited to simple utility functions added on to systems. You do not seem to be able to delay execution, or ergonomically create branching dependencies in either direction.

Additional context
This is closely related to the discussion in https://github.com/bevyengine/bevy/pull/1021, Stages v2. Having an explicit way to ensure system ordering would make the process of entering and exiting states much cleaner, and this feature will need integration with the .with_run_criteria discussed there.

If we decide that both of these behaviours could be desirable for different use cases (simple vs. complex games for example), we could enforce explicit dependencies with a flag of some fashion. I think that the natural place for that to go would be at the stage level, as the complexity of various stages (e.g. UPDATE vs. LAST) could vary significantly even within the same complex game.

Remove the implicit guarantee that systems added first within a stage run before those added after it.

This isn't quite true. Execution order is "arbitrary" for systems by default. It is defined by registration order only for systems that conflict.
I'm pretty well convinced at this point that the design @Ratysz has suggested (both on the discord and in his blog post) is the right call. Your suggestion sounds pretty similar.
In a nutshell (@Ratysz correct me if im wrong)

Within a stage, Systems run in parallel by default (in arbitrary order). Systems with no conflicts and no manual dependencies run first
When a system finishes executing, we greedily run new systems whose constraints have been met
Repeat until the schedule is finished

Heuristics can also be added to ensure that high-cost systems run first in contexts where cores are saturated (both in (1) and in (2))
This does get a little interesting when we throw with_run_criteria and SystemSets into the mix (as discussed in #1021), but I think in general thats solved by evaluating execution criteria at the beginning of the stage (which also makes sense because it makes execution logic more predictable).

In a nutshell [...]

Yes, that's pretty much the gist of it; here is a non-gist of it from a while ago.
That specific implementation suffers from being a third-party library - mostly the Arc<Mutex<Box<dyn System>>> travesty that requires locking to check for conflicts. An integrated version will be easily able to avoid that and only lock for actually running the system, if even that - the algorithm's guarantees of single active access to system's state and lack of component+resource conflicts, failsafed with component and resource borrow checking, should be sufficient to let us do lock-free unsafe access.

[...] solved by evaluating execution criteria at the beginning of the stage [...]

Yes; in the linked implementation, what I would try for accomodating that is changing this:
scope.spawn(async move {
    listener.await;
    system
        .try_lock()
        .unwrap_or_else(|| unreachable!())
        .run(world, resources);
    sender.send(id).await.unwrap();
});

to this:
if system.run_criteria_satisfied() {
    scope.spawn(async move {
        listener.await;
        system
            .try_lock()
            .unwrap_or_else(|| unreachable!())
            .run(world, resources);
        sender.send(id).await.unwrap();
    });
} else {
    scope.spawn(async move {
        listener.await;
        sender.send(id).await.unwrap();
    });
}

This maintains the disabled system's presence for dependency resolution purposes.
Other constraints can also be supported, either in a similar preemptive fashion, or by adding them to the conflict check. We could even support opt-in registration order preservation on a per-system basis.
I would put this all together into a PR, but at this point it would be a draft PR to a draft PR.

@Ratysz  yeah you might want to wait for me to wrap up the SystemSets impl / us all to (hopefully) agree on that impl.

if system.run_criteria_satisfied()

Just keep in mind that run_criteria is a system too, so it needs world/resource access and it shouldn't run in parallel unless it is properly scheduled.

But I also doubt I'll change the current SystemStage much/at all, so you could probably get started on non-systemset scheduling now if you don't want to wait.

This will be closed by #1144.


Allow online custon layers

@xgui3783 It works and ready to merge

Can you add the feature to release notes?

Yes, I will add.

three things:
1/ the custom layer does not need to be nifti. It can be precomputed, swc, etc.
2/ if you want to push changes without triggering CI ,you can add [skip ci] to the start of the commit message. (In this case, release notes does not need to trigger CI (at least not yet)
3/ can you resolve the merge conflicts?

@fsdavid re dc06157, it does not need to be precomputed either.
It's better that we clarify the release notes to say that it supports arbitrary layer based on URL parameter.


Specifying Camera doesn't work

Was trying to download all footage from one camera named "Garage"
When passing in the --cameras flag with "Garage" the script runs, prints out the list of cameras and then terminates.
No files downloaded.
Listing "all" for camera tag starts the download. Confirmed files are available to download.
Protect Versions 1.18.1
Downloader Version 2.0.2

Hi there!
The --cameras option takes either the input all or a comma-separated list of camera IDs, but not names. In the camera list you should see both, the name as well as it's ID.
Try using something like --cameras="a1b2c3d4e5f6abcdef123456, and replace a1b2c3d4e5f6abcdef123456 with the ID of your Garage camera - that should work.

Interesting, there should be a different flow around this, as you won't be able to get the ID's until first run, only to have to rerun the program.

Yeah, I agree. Could be easier. I might add something in one of the next versions that makes camera selection more straightforward.
But: you can also always get the camera ID(s) from the Protect Web UI. Open it in a web browser and log in. On the left side, click on Devices. Then select one of your cameras from the list. Now the browser address bar looks something like this: https://<ip-of-protect-server>/protect/devices/a1b2c3d4e5f6abcdef123456. That last part there is the camera ID you're looking for. From there just copy+paste it to your command line.


Colab Credits

I no longer have colab credits and the notebook will not open without them apparently. can you post the notebook in the repository so i can run it on another service. (im using runpod)

@7uk3y wait you cannot even donwload the notebooks? :( Well we have some hosted on HF: https://huggingface.co/datasets/unsloth/notebooks/tree/main
Mistral for eg: https://huggingface.co/datasets/unsloth/notebooks/blob/main/Alpaca_%2B_Mistral_7b_full_example.ipynb

Closing this for now - hope it's solved!


Added the message type for an environment, which will be suggested as a

construct in the client spec.
Signed-off-by: Fredrik Skogman<EMAIL_ADDRESS>Summary
During the work on trust root, verification and bundles the concept of an environment has been proposed. This PR shows the construct as a protobuf message.
Release Note
N/A
Documentation
N/A

To clarify the concept of a policy more, I'm inclined to materialize a message for that too in this PR. cc @joshuagl @znewman01

See also https://docs.google.com/document/d/1wDwiGF3LZ81P5cCTYv-TaAzFWpkPCz4EYcaHVkBPfuM/edit (may need to join<EMAIL_ADDRESS>for access)

@kommendorkapten Do we still need this or can this be closed?

Forgot about this @haydentherapper, I'm closing this now and re-opening when it's ready.


Publish header with toolchain versions

This change is an attempt to resolve wasi-libc#490 but at the wasi-sdk level. It adds a version.h header file to
share/wasi-sysroot/include/<target>/wasi so that users have programmatic access to some extra information to output better error messages, e.g. This version.h looks something like:
// Generated by wasi-sdk's `version.py` script.
#ifndef VERSION_H
#define VERSION_H

#define WASI_SDK_VERSION "24.6g754aec3d6f58+m"
#define WASI_LIBC_VERSION "b9ef79d7dbd4"

#endif

It is a bit strange that we're adding to wasi-libc's include files from wasi-sdk (it would be cleaner if it happened in wasi-libc directly) but wasi-sdk actually has the information available.

Thanks very much for looking into this! This would solve our problem very neatly!
To be clear, would I want to include <version.h> or would it be located elsewhere?

I think you would include <wasi/version.h>.   We certainly wouldn't want to call the file version.h if it was in the default include path, as that would be asking for trouble.

To be clear, would I want to include <version.h> or would it be located elsewhere?

@grynspan, I think it would be wasi/version.h?

It is a bit strange that we're adding to wasi-libc's include files from wasi-sdk (it would be cleaner if it happened in wasi-libc directly)

yes.
i'm against this because it introduces an incompatibility between wasi-sdk and direct use of wasi-libc.
(programs including this header won't build for the latter)

If we did this exclusively in wasi-libc it could look like: https://github.com/WebAssembly/wasi-libc/pull/534.

Could the two be combined? Such that -libc provides its version and -sdk provides its version?


React: Support for defaultValue in HTMLAttributes

https://facebook.github.io/react/docs/forms.html#default-value

Can you make this change on react-addons.d.ts and react-global.d.ts as well?

@pspeter3 @vsiao could you review this PR too?

ok, might as well add defaultChecked as well. Please also follow the instructions in the README located at https://github.com/borisyankov/DefinitelyTyped/tree/master/react to keep the .d.ts files in sync, as @jbrantly said.

:+1:

+1 from me

@vsiao @pspeter3 @jbrantly thanks!
@maglar0 thanks mate!


Editor Tools UI Improvements

Closes #15

Amazingly enough I think this is finally ready for merging in! I rebased it, fixed linting errors introduced from rebasing, and tested it pretty thoroughly which came up with a single bug which I fixed.
I just squashed a few commits from my post-rebase stuff as that made sense, but other than that I feel like it doesn't really seem like it's easy to sensibly squash any more commits. I guess it is also just a really big PR so maybe we just do the "Rebase and Merge" now and add 45 commits to the master branch. It is also 2000 lines changed so I think it's fair, and as I said I can't see any sensible way to squash the commits, if so, it would be a huge job with maybe separating all the changes to each file and have a commit for each file which I guess we could do with a git reset master which would do a soft reset and then do a commit per file... but... I think I vote for just rebasing this in now.


Integration with data_getters repo

Hi, I created a new repo following the cookiecutter instructions, and then tried to install data_getters repo as I need to access GtR research project data.
Installing data_getters results in a lot of warnings and errors (please see here)
This seems to be a python version clash, as the ds-cookiecutter is setup with python==3.8, but the data_getters installation does work with python==3.7
Please let me know how to best go about this - is it OK to simply use the ds-cookiecutter with python 3.7?

Firstly, yes you can use 3.7 - one of the benefits of having a cookiecutter rather than managing things through a framework/library is that they are 'hackable' (perhaps a good thing to have in our docs is what things we deem reasonable to be hacked/customised).

I'm going to close this issue because I don't think it is a problem with the cookiecutter. The problem likely relates to the complex dependencies of data_getters which pulls in all the dependencies from nesta due to our old monolithic architecture.
I've opened #69 to capture the need to better communicate the hackability of the cookiecutter.

Sounds good, thank you very much!


Move wayland client to UWAC

In this PR instead of reimplementing all wayland tricks, we rely on the UWAC library that do it for us.
With this PR the wayland client works better, it still remain an issue with keyboard handling (how to choose a RDP locale from the mmap file of wayland...).

@hardening to build with uwac we need the lib somehow on the build systems otherwise the detection should disable wayland.

Ok so that means that my cmake detection is crappy. Working on this.

@hardening the build works again but now we wouldn't do any test builds of the wayland client because uwac isn't available. - right?

@bmiklautz yeah right you caught me :)

@bmiklautz so this is the version with UWAC bundled in FreeRDP itself. Would be nice if xkbcommon could be installed on the builder...

@hardening it's on the list I take care of it as soon as I can :).

@freerdp-bot test.

@hardening would you rebase this to the latest master?

@freerdp-bot test.

@freerdp-bot I think you failed the last test, would you retry ?

@hardening This pull does not build properly on my debian jessie system. I have wayland libs installed, but they are not detected (see comments above).
Further the failed wayland detection does not disable all uwac related components (or abort the cmake run) and the compilation aborts with missing -luwac messages.

@akallabeth I have fixed the detection, but after deinstalling wayland libs I can't reproduce the compilation bug: for me the wayland client and libs are correctly skipped. Anyway my debian, VM is a wheezy not a jessie.

@freerdp-bot what's wrong with this PR, don't you want to test wayland ?

@freerdp-bot test

@hardening can build the library on my machine now, the issues are (mostly) resolved, but you need to add ${CMAKE_BINARY_DIR}/uwac/libuwac to the include path, as the protocol headers are generated there for out of tree builds.

Looks good for me.
Except my comments +1.

@hardening nice work! - I gonna add some versioning and pkg-config for it \o/


module 'mnist'  not found

I ran the example and loaded the mnist model, but
Successfully loaded /home/yusheng/workspace/caffe/examples/mnist/lenet_iter_10000.caffemodel
Out[2]:
module 'mnist' not found
Out[2]:
conv1: 20 1 5 5
Out[2]:
conv2: 50 20 5 5
Out[2]:
ip1: 1 1 800 500
Out[2]:
ip2: 1 1 500 10
what does the "module" mean ?
Eventually, when I ran this line "net:forward(images[1]:view(1,28,28)):max(1)" and it crashed
.../workspace/torch/install/share/lua/5.1/nn/Sequential.lua:39: bad argument #1 (field padding does not exist)
stack traceback:
[C]: in function 'updateOutput'
.../workspace/torch/install/share/lua/5.1/nn/Sequential.lua:39: in function 'forward'
[string "_,y = net:forward(images[1]:view(1,28,28)):ma..."]:1: in main chunk
[C]: in function 'xpcall'
...ng/workspace/torch/install/share/lua/5.1/itorch/main.lua:177: in function <...ng/workspace/torch/install/share/lua/5.1/itorch/main.lua:143>
...ng/workspace/torch/install/share/lua/5.1/lzmq/poller.lua:75: in function 'poll'
...workspace/torch/install/share/lua/5.1/lzmq/impl/loop.lua:307: in function 'poll'
...workspace/torch/install/share/lua/5.1/lzmq/impl/loop.lua:325: in function 'sleep_ex'
...workspace/torch/install/share/lua/5.1/lzmq/impl/loop.lua:370: in function 'start'
...ng/workspace/torch/install/share/lua/5.1/itorch/main.lua:344: in main chunk
[C]: in function 'require'
[string "arg={'/home/yusheng/.ipython/profile_torch/se..."]:1: in main chunk
Could you help me solve this problem ?

module 'mnist' not found is just a warning. You have to update nn and cunn to get rid of the padding error:
luarocks install nn
luarocks install cunn

I've updated and worked , but
Successfully loaded /home/yusheng/workspace/caffe/examples/mnist/lenet_iter_10000.caffemodel
module 'mnist' not found
conv1: 20 1 5 5
conv2: 50 20 5 5
ip1: 1 1 800 500
ip2: 1 1 500 10
ConfusionMatrix:
[[     972       0       0       0       0       0       3       1       4       0]   99.184%
[       0    1131       1       1       0       0       1       1       0       0]   99.648%
[       0       1    1025       1       1       0       0       1       3       0]   99.322%
[       0       0       1    1001       0       4       0       1       3       0]   99.109%
[       0       0       1       0     977       0       2       0       0       2]   99.491%
[       2       0       0       8       0     880       1       0       1       0]   98.655%
[       3       1       0       1       3       4     945       0       1       0]   98.643%
[       0       3       7       2       0       0       0    1016       0       0]   98.833%
[       3       0       2       0       0       2       0       1     964       2]   98.973%
[       1       0       0       5       5       3       1       2       3     989]]  98.018%

average row correct: 98.987424373627%
average rowUcol correct (VOC measure): 97.996342182159%
global correct: 99%

Can I ignore "module 'mnist' not found" this warning ?

yes you can ignore it.


Order for exception filters

Hi,
According to the docs filters that implement IOrderedFilter are executed in ascending order, but it seems that the exception filter with the highest order number is executed first.
Is this because the exception filter is an “after-stage” filter and therefore the order is descending?
Is there a bug in the docs?
Is it ensured that “after-stage” filters will be executed in descending order?
Thanks,
Mike

/cc @rynowak

Is this because the exception filter is an “after-stage” filter and therefore the order is descending?

Yes

Is it ensured that “after-stage” filters will be executed in descending order?

Yes
@danroth27 - maybe we should correct the docs. I've always liked the way the in-code docs phrase this https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IOrderedFilter.cs#L33

Also async filters have their after method executed in descending order. That’s what puzzled me.

https://github.com/aspnet/Docs/issues/1267

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


use verifier for test

Issues

[ ] My PR addresses the following Helix issues and references them in the PR description:

(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)
Tests

[ ] The following tests are written for this issue:

(List the names of added unit/integration tests)

The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Documentation (Optional)

In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)
Commits

My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Code Quality

My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)

Failure test for commit #4 TestResourceChangeDetector.testResetSnapshots:453 expected:<0> but was:<1>


validate medication qty multiplicity

https://github.com/edenlabllc/ehealth.api/issues/1116

Changes Unknown when pulling 15a31bac73363025413caf356177f265047706b8 on medication_dispenses_validation#1116 into ** on master**.


Possibility to define runtime dependencies

What is the problem you're trying to solve
The proposal is to enhance containerd with a build-in functionality that installs dependencies defined in the config.toml at startup.
Dependencies are image references that contain binaries that should be installed on the host OS.
Benefits
Projects that integrate with containerd can have multiple dependencies in addition to containerd itself.
Communicating with the containerd daemon either requires the use of an unsupported client (ctr) or an external tool. Having to pre-provisioning this external tool on the OS makes integration with containerd harder.

Possibly requires a custom OS image or download via package / public internet.
Rather we would like to use only the existing distribution infrastructure (container registries).

With the proposed enhancement it is not required to use another tool (ctr / custom grpc client / CRI client) to talk to the containerd daemon and load dependencies.
Please also see the concrete use case below.
Describe the solution you'd like

Containerd has a build-in plugin that allows the configuration in config.toml of runtime dependencies.
Containerd initialises the plugin at startup
The plugin uses existing functionality client.Pull to pull the image and client.install to install the contained binaries on the host OS

The configuration could look like this
[plugins]
  [plugins."io.containerd.internal.v1.opt"]
    path = "/usr/local"
  [plugins."io.containerd.internal.v1.runtime-dependencies"]
    [plugins."io.containerd.internal.v1.runtime-dependencies".dependencies]
      [plugins."io.containerd.internal.v1.runtime-dependencies".dependencies."gardener"]
        image_ref = "docker.io/<abc>/containerd-runtime-dependencies:latest"
        path = "/opt/"
        replace = true
      [plugins."io.containerd.internal.v1.runtime-dependencies".dependencies."other"]
        image_ref = "docker.io/<abc>/containerd-runtime-dependencies:latest"
        replace = true
        libs = false

The images need to contain binaries under /bin according to managed-ops.
Use case
Higher level integrators especially in the Kubernetes ecosystem, can potentially use  containerd to bootstrap a Kubernetes node.
To talk to containerd, either

ctr client
or a dedicated client using the containerd libs
or the CRI of containerd
can be used.

Using ctr for node boostrapping is problematic. Thectr client is an an unsupported debug and administrative client for interacting with the containerd daemon and not backwards compatible.
Using  a dedicated client to talk to the containerd grpc API is not ideal as this would require to

preinstall this client on the Host OS
need to take care about backwards compatibility ourselves
duplicate functionality from ctr

In the context of Kubernetes, using the containerd CRI is preferred , as CRI is a stable and backwards compatible interface.
However, talking to the CRI GRPC service requires a client (cannot be done via curl etc. that are preinstalled on most linux OS).
This presents another challenge, as we either have to preinstall the CRI client  (e.g community-maintained CRI  crictl) on every host OS  or install the binaries from another source (from public internet, packages).
Pre installing the CRI client on the OS is not feasible as this requires custom OS builds / custom images.
Also installing the CRI client  from another source requires using another distribution infrastructure  besides the already used container registries to manage all the dependencies. This is especially problematic when the node has no public internet access.
This is why I propose to enhance containerd with a build-in functionality that installs dependencies defined in the config.toml at startup. This allows to use only one distribution infrastructure and potentially eases integration with containerd.
Additional context

I created a draft PR that demonstrates how this plugin could look like
Also see corresponding Slack thread in sig-node

Is there another way how features can be proposed to the containerd maintainers?
It would be a very helpful functionality for use and I am willing to contribute the code.

IMO managing OS level dependencies should not be in scope of containerd daemon.
And the runtime dependency plugin will work for the given use case, but likely not flexible (like when we have to pull an image from non docker.io registry or pass credentials?).
I'd rather go with bundling cri (with each containerd release) or crictl, depending on how you bundle containerd itself (or even writing your own client). Though I understand the disadvantages you mentioned.

Thanks for your response!

And the runtime dependency plugin will work for the given use case, but likely not flexible (like when we have to pull an image from non docker.io registry or pass credentials?)

Ok thanks, I was not aware that the configuration of registries and credentials is only part of the config of the CRI plugin.

I'd rather go with bundling cri (with each containerd release)
To my understand containerd/cri is already a buildin plugin -  or am I misunderstanding something?

or crictl, depending on how you bundle containerd itself (or even writing your own client)

Thats the problem for us. We would have to preinstall such clients on every OS because we cannot use the image registry - as the client for communicating with CRI is not available yet.
Its kind of a chicken and egg problem.
Is this proposed functionality something that could be build into the containerd/cri plugin itself?
As such it would be only for the Kubernetes use-case.

To my understand containerd/cri is already a buildin plugin - or am I misunderstanding something?

oh, sorry, I mistyped. Meant to be ctr.

IMO managing OS level dependencies should not be in scope of containerd daemon.

There is already a plugin with the managed-opt that extract binaries as dependencies to the OS to the /opt directory.
The runtime dependency plugin, standalone or as part of containerd/cri plugin, would only reuse existing functionality such as pulling from the registry and the managed-opt plugin.
To me it seems like containerd is already "managing OS level dependencies" - the proposed plugin would only solve an integration problem.
Just wanted to put this out there, but of course I understand that containerd  has a certain scope it wants to adhere to.

Could you just use ctr run --rm -t private.registry/crictl-image:latest --some-options some-args ?

Could you just use ctr run --rm -t private.registry/crictl-image:latest --some-options some-args

Hi, yes that would work for the meantime but:

Using ctr for node boostrapping is problematic. The ctr client is an an unsupported debug and administrative client for interacting with the containerd daemon and not backwards compatible.

@mikebrow sorry for pinging you directly - we talked about it in the containerd slack.
Is that  functionality that you would find useful in the CRI plugin?
If yes, this issue could be transferred.
If no, I would close this issue and the respective draft PR.
Thanks!


Compare SIFT repeatability SIFT.

SIFT OpenCV vs. SIFT vlfeat vs. popSIFT

@lcalvet Do we have the results, at least for opencv vs vlfeat?

@lcalvet: This is done, isn't it?


.github: run conformance tests

Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

LGTM
@nalind @flouthoc @TomSweeneyRedHat PTAL

is there any interest in this PR or should I close it?

@giuseppe I think we should have it in upstream cause sometimes its pain to run conformance test locally. @nalind @rhatdan PTAL

/lgtm
/approve


make manifest a public muxrpc API

Context
Manifest bootstrapping has been a muxrpc feature since Dec 2017, but its usage hasn't been effectively enabled in the SSB ecosystem, and that's because secret-stack actually just assumes the remote peer has the same manifest as the local peer. Anyway, this feature has been possible for others to use because secret-stack implements it as a muxrpc API.
Problem
One specific solution to a specific problem in go-ssb has been to use manifest bootstrapping on remote peers (possible and often JS peers) in order to know what muxrpc methods can be called.
Unfortunately, upon go-ssb attempting to call manifest() on a remote JS peer, we got the following error logged in go-ssb:
Apr 16 14:30:55 hermiesclub gossbroom[18542]: level=warn remote="IPADDR:PORT|@SSB
FEED=.ed25519" call=manifest reqID=1 event="manifest request failed to read" err=
"muxrpc CallError: Error - method:manifest is not in list of allowed methods"

Solution
We need to make the manifest muxrpc method publicly accessible to "anonymous" peers. I tested this change in production and the above go-ssb error does not show anymore.

cc @cryptix

Unfortunately, upon go-ssb attempting to call manifest() on a remote JS peer, we got the following error logged in go-ssb:

Nice! I wonder if this explains some of the odd behavior I've seen in SSB-Client using the auto manifests with anonymous peers. 🤦  Great job all.

@christianbundy Thanks for popping up again, always nice to see you again. Is that an approve? Y'all fine if I merge and release a new version?


hdp-select all packages by hand

Fixes #1061
Head

[x] namenodes
[x] zookeeper via #1062
[x] journalnode
[x] hbase-master
[x] resourcemanager
[x] oozie
[x] hive

Worker

[x] datanode / nodemanager
[x] regionserver

Per our 1 Feb 18 code review, we probably no longer want the hdp-select changes on our side, with hardcoded strings.  We should push hwx to fix their hdp-select.
This PR should be cut down to just the linting fixes.

I'll preserve this PR and open a new one for lints so that we can refer to this case in the future.


CANopen

Hello ,
How can I get the CANOpen..?
Where should I learn that....?
Thank you.

CANOpen protocol is similar to CAN protocol, but it has more subtlety than regular CAN.

In a CANOpen network, each node has a communication ID, called COB-ID
The lowest COB-ID is the network master : other nodes are not slaves but they cannot do all of what the master can do
The CAN ID of the CANOpen frames contain the COB-ID as last bits
The network nodes do not know about the frames/message list  --> At the beginning of every node power up, the master must send them some information about the messages they will receive or should send (through SDO).
There are 3 main protocols : LSS, SDO and PDO

LSS is for communication setup
SDO is Service Data Object : it is used at the beginning of the transfer to setup communication between nodes
PDO is Protocol Data Object : it is used to send information, based on an object dictionary. Each object in the dictionary is a variable with an ID.

There are many other things which are special to CANopen (I cannot explain everything here)

Currently, cantools does not support CANOpen : if you want to use CANOpen, you must add your own code on top of cantools in order to make the adaptation.
You could maybe create a dbc file with a CANOpen template using CANdb++ software (if you have it)  : it would help by creating some protocol signals automatically, then you could use cantools as a way to fill each signal.
If you want to learn about CANOpen, please look at the following websites :
Wikipedia
CiA website
CSS Electronics

I suppose this feature is not applicable to cantools in its current form. closing...


can you add stockholm, sweden

Hi! I added it in the latest version, you can find it here: https://github.com/fedecalendino/alfred-world-clock/releases/tag/v1.9.3
And it should be available on Alfred's galley in a few days.
Cheers!


Run nekbone with no markup and compare balancer and governor performance

estimate 3

Run first with manual mark up and check that balancer works. After that modify existing nekbone scripts on mcfly to use the edit distance filter and no user mark up of the application.  Run twice under a power cap that is a similar fraction of TDP as good experiments we have done on KNL, once with the governor and once  with the balancer.  Inspect the reports and determine if the balancer was able to provide a benefit with no markup.
Done criteria:

Reports generated and compared
Collateral for the review meeting is generated

Parent story: #1180

cmcantal@mcfly:~/output/43973_nekbone]$ grep -A10 Epoch *180*report
nekbone_power_balancer_pwr_180.0_0.report:Epoch Totals:
nekbone_power_balancer_pwr_180.0_0.report-    runtime (sec): 467.834
nekbone_power_balancer_pwr_180.0_0.report-    sync-runtime (sec): 467.829
nekbone_power_balancer_pwr_180.0_0.report-    package-energy (joules): 87144.7
nekbone_power_balancer_pwr_180.0_0.report-    dram-energy (joules): 11294.7
nekbone_power_balancer_pwr_180.0_0.report-    power (watts): 186.275
nekbone_power_balancer_pwr_180.0_0.report-    frequency (%): 93.7494
nekbone_power_balancer_pwr_180.0_0.report-    frequency (Hz): 1.96874e+09
nekbone_power_balancer_pwr_180.0_0.report-    network-time (sec): 75.4461
nekbone_power_balancer_pwr_180.0_0.report-    count: 2000
nekbone_power_balancer_pwr_180.0_0.report-    epoch-runtime-ignore (sec): 0
--
nekbone_power_balancer_pwr_180.0_0.report:Epoch Totals:
nekbone_power_balancer_pwr_180.0_0.report-    runtime (sec): 467.831
nekbone_power_balancer_pwr_180.0_0.report-    sync-runtime (sec): 467.828
nekbone_power_balancer_pwr_180.0_0.report-    package-energy (joules): 80625
nekbone_power_balancer_pwr_180.0_0.report-    dram-energy (joules): 12533.4
nekbone_power_balancer_pwr_180.0_0.report-    power (watts): 172.339
nekbone_power_balancer_pwr_180.0_0.report-    frequency (%): 85.2738
nekbone_power_balancer_pwr_180.0_0.report-    frequency (Hz): 1.79075e+09
nekbone_power_balancer_pwr_180.0_0.report-    network-time (sec): 72.5406
nekbone_power_balancer_pwr_180.0_0.report-    count: 2000
nekbone_power_balancer_pwr_180.0_0.report-    epoch-runtime-ignore (sec): 0
--
nekbone_power_governor_pwr_180_0.report:Epoch Totals:
nekbone_power_governor_pwr_180_0.report-    runtime (sec): 456.508
nekbone_power_governor_pwr_180_0.report-    sync-runtime (sec): 456.503
nekbone_power_governor_pwr_180_0.report-    package-energy (joules): 81931.6
nekbone_power_governor_pwr_180_0.report-    dram-energy (joules): 11257.1
nekbone_power_governor_pwr_180_0.report-    power (watts): 179.476
nekbone_power_governor_pwr_180_0.report-    frequency (%): 89.2044
nekbone_power_governor_pwr_180_0.report-    frequency (Hz): 1.87329e+09
nekbone_power_governor_pwr_180_0.report-    network-time (sec): 54.5483
nekbone_power_governor_pwr_180_0.report-    count: 2000
nekbone_power_governor_pwr_180_0.report-    epoch-runtime-ignore (sec): 0
--
nekbone_power_governor_pwr_180_0.report:Epoch Totals:
nekbone_power_governor_pwr_180_0.report-    runtime (sec): 456.512
nekbone_power_governor_pwr_180_0.report-    sync-runtime (sec): 456.506
nekbone_power_governor_pwr_180_0.report-    package-energy (joules): 81932.1
nekbone_power_governor_pwr_180_0.report-    dram-energy (joules): 12337.2
nekbone_power_governor_pwr_180_0.report-    power (watts): 179.476
nekbone_power_governor_pwr_180_0.report-    frequency (%): 90.3925
nekbone_power_governor_pwr_180_0.report-    frequency (Hz): 1.89824e+09
nekbone_power_governor_pwr_180_0.report-    network-time (sec): 72.1127
nekbone_power_governor_pwr_180_0.report-    count: 2000
nekbone_power_governor_pwr_180_0.report-    epoch-runtime-ignore (sec): 0

Without balancing power between sockets in a single node, the balancer is not very effective on dual socket Xeon systems for the purpose of mitigating manufacturing variation.


Publish Results produced by failed TaskRun

Publish Results produced by failed TaskRun https://github.com/tektoncd/pipeline/issues/3749
Changes
Prior to this change we skipped the code to publish TaskRun Result when a TaskRun fails. This commit changes to publish TaskRun Results produced by failed TaskRuns
/kind feature

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

NONE

/retest

/kind feature

+1 for this pull request

doing a clean up of stale pull requests - feel free to reopen if you pick up this work again
/close


Horizontal rule is not being rendered from a number of Content Block patterns

In v1.5.0-rc.0 for the following content block patterns:

ContentBlockMixed
ContentBlockSimple
ContentBlockSegmented
ContentBlockMedia

The horizontal rule is not being rendered at the pattern level.

@kexuibm based on the designs the horizontal rule has to be applied at the section level because unlike the blocks, link list and such it spans the full 12 columns to the end of the grid. We created an prop you can pass into the Layout sub-pattern that adds a modifier with the horizontal rule within 1.5.0-rc.0 I believe. Here's an example of how to use it, and the storybook for you to further review. Applying it this way will also help keep your page in alignment with the grid as well.
<Layout nested={true} type="2-1" border={true}>

    <ContentBlockSimple ... />

    <LinkList ... />

</Layout>
<Layout nested={true} type="2-1" border={true}>

    <ContentBlockMixed ... />

</Layout>
<Layout nested={true} type="2-1" border={true}>

    <ContentBlockSegmented ... />

</Layout>

http://ibmdotcom-react.mybluemix.net/?path=/story/patterns-sub-patterns-layout--default


Exclude locales

Hi,
Is it possible to exclude certain locales? Just as mentioned in this issue, not all languages are supported by the underlying model.
Specifically, I'm having issues with Albanian sq and the Vertex model, but would be happy to just be able to exclude this from arb_translate for now, without having to delete the .arb file from the directory.

I've added option to exclude locales in the new version (0.1.3). You can use --exclude-locales sq,es command line param or arb-translate-exclude-locales: ["sq", "es"] option in l10n.yaml


Bumped the Golang version to 1.19 in pre-requisite documentation

Description of the change:
Go.mod is using golang 1.19 and pre-requisite is using 1.18. So Incrementing the developer guide to meet the golang version.
Bumped the Golang version.
Motivation for the change:
#6385
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[x] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

Closes #6385

you're welcome @varshaprasad96

@ukumar009 Looks like the DCO check is failing. Once that is fixed we can merge this PR in. You should be able to follow the steps given in https://github.com/operator-framework/operator-sdk/pull/6386/checks?check_run_id=12461023493 to resolve this failure

@ukumar009 Looks like the DCO check is failing. Once that is fixed we can merge this PR in. You should be able to follow the steps given in https://github.com/operator-framework/operator-sdk/pull/6386/checks?check_run_id=12461023493 to resolve this failure

Thank you @everettraven I fixed the DCO issue now.

Overriding the docs link checker failures as I was able to access all the "failed" links. Merging.


Enable plugins folder

Purpose

This PR creates a "plugins/" folder that will be used to store code and utilities common to all DAGs

Proposed Changes

[ADD] "plugins/" folder to the Airflow custom containers under /opt/airflow/plugins

Issues

https://github.com/unity-sds/unity-sps/issues/96

Testing

Tested the execution of the "karpenter_test" DAG when using the "unity_sps_utils" library loaded from the plugins folder.

Thanks Luca. I'm seeing a failure in the unit tests during dag validation:
ModuleNotFoundError: No module named 'unity_sps_utils'

That module should be part of the "plugins/" folder. Which version of the Docker image is used by the unit tests? It will probably need to be rebuilt.

The unit tests do not utilize a docker image, they are simply static tests.
If we were to use a dag directory structure like this, it seems like we could still utilize our static unit tests:

We could... Let me see if I can make the changes.

But it does becomes messy with the "dags/" and "dags-catalog/" folder because we would need to copy selected portions of that "dags/" folder to "/opt/airflow/dags", and not others.

Another option could be to have the custom dag utils/plugins be python package which is pip installed in the Dockerfile. For all of the other dependencies in our DAGs, they are made available to pytest through pip install as part of our pyproject.toml:
https://github.com/unity-sds/unity-sps/blob/develop/pyproject.toml#L34-L45


Non default profile settings treats some settings inconsistently when in remote setup

Type: Bug
I use vscode in remote setups wsl, ssh, and devcontainer. I also use a (non-default) work settings profile when I'm at work. Common use of non default profiles would usually include customizing family of settings such as: "http.proxy", "remote.SSH", "dotfiles.", "dev.container". Right now, several of them cannot be applied to non default profiles (for instance most "remote.ssh" settings); and some other settings are applied inconsistently when in different remote setup, specifically, the setting "http.proxy" do not seem to be picked up from a non-default profile when working with a wsl or devcontainer setup, and it seems to be impossible to customize its value in any one of the settings.json files: both in remote settings.json and current profile settings the setting "http.proxy" is inactive and hovering on it displays the message "This setting has an application scope and can be set only in the user settings file.". (In both the above cases, the http.proxy setting could be customized in the default settings profile, but this kind of contradict the main uses of defining non-default settings profile: IMO the first candidate settings that benefit from this feature is http.proxy). I also use an SSH remote setup with my workplace profile settings, but the actual behavior of the http.proxy is totally different from the devcontainer and wsl cases: the http.proxy can be specified in the remote's settings.json (which is a good thing since the remote could have different network settings), but at the same time it cannot pick up the value from the non default profile setttings.json (the setting is inactive with hover message "This setting cannot be applied in this window. It will be applied when you open a local window."), nor does it read the value from the default settings profile (the setting is inactive with 2 messages: "This setting cannot be applied while a non-default profile is active. It will be applied when the default profile is active." and
"This setting cannot be applied in this window. It will be applied when you open a local window".
The only case with predicatble behavior is in non remote setup, the http.proxy setting is picked up from the currently active profile settings.json. This should be exactly what should happen in any kind of remote setup when the remote settings.json file does not overrite the http.proxy setting; also, the http.proxy should be overridable from the remote settings.json file in any remote setup.
VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:22:44.506Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 5.15.0-58-generic

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz (16 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.73GB (0.65GB free)

Process Argv
--crash-reporter-id c5a1a827-bcc3-4406-8db9-b4ae3a1d12c9

Screen Reader
no

VM
0%

Item
Value

Remote
Dev Container: milo-development-environment

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz (16 x 2495)

Memory (System)
7.62GB (4.87GB free)

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz (16 x 2495)

Memory (System)
7.62GB (4.87GB free)

VM
0%

Item
Value

Remote
Dev Container: onboard-fleet-sp-C++

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz (16 x 2495)

Memory (System)
7.62GB (4.87GB free)

VM
0%

Item
Value

Remote
SSH: Aragorn2

OS
Linux x64 5.15.0-58-generic

CPUs
Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (48 x 2099)

Memory (System)
125.77GB (24.24GB free)

VM
6%

Extensions (22)

Extension
Author (truncated)
Version

language-x86-64-assembly
13x
3.0.0

Bookmarks
ale
13.3.1

language-gas-x86
bas
0.0.2

file-icons
fil
1.0.29

codespaces
Git
1.13.10

remotehub
Git
0.52.0

vscode-drawio
hed
1.6.6

better-shellscript-syntax
jef
1.4.2

vscode-boost-jam
mlo
0.0.2

jupyter-keymap
ms-
1.1.0

remote-containers
ms-
0.283.0

remote-ssh
ms-
0.99.2023030315

remote-ssh-edit
ms-
0.84.0

remote-wsl
ms-
0.76.1

vscode-remote-extensionpack
ms-
0.24.0

azure-repos
ms-
0.28.0

remote-explorer
ms-
0.3.2023021509

remote-repositories
ms-
0.30.0

remote-server
ms-
1.1.2023022709

conanlight
Son
1.4.0

vscode-icons
vsc
12.2.0

azure-account
ms-
0.11.3

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyonecf:30548226
pyindex848:30662994
nodejswelcome1:30587005
3biah626:30602489
pyind779:30671433
89544117:30613380
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30672706
vsccsb:30677849
funwalk2cf:30676044

@jvillemure It seems these settings are application scoped settings and they can be read/set only in default profile settings file. Having these settings in the profile settings file will not have any impact. Please let me know if you are seeing otherwise. It would be great if you can provide me a specific example in this case to drill down deeper.

@sandy081 I think it will make things clear if I explain in details my actual use case for using settings profile. An important fact I forgot to mention is that I also use the settings sync feature, since long ago when it was released. I was a quick adopter of settings sync, I really liked the fact that I did not need to manually keep my preferences up to date between the computers I use; especially, I regularly look for and try new settings that comes with new vscode releases or extensions. This saves me a lot of manual work to sync my preferences across my few personal computers, work computer (most of it, like 90%), or other (say, a friend's) computers I would borrow for a specific task. For personal uses, I would always use exactly the same settings and extensions, and settings sync was just perfect for that. In contrast, at workplaces, it has never been the case that I could actually bring my use my own personal settings in the same way as I would at home; sometimes also, there are extensions that find some uses at work, but never at home (and vice versa). I'd expect that this duality home/work is the norm for anyone using vscode at work. There is usually a small subset of my user settings that need to be changed or set to be able to use it at workplace. To make things worst, most of this subset of settings cannot satisfy both homeplace and workplace at the same time and choosing one will imperatively 'sacrifice' the other use.
Example of settings: most things related to network, connectivity, telemetry, update settings, etc
"http.proxy*": at work, not setting this to the vpn's http proxy basically means I don't receive any upgrades, extensions upgrades, can't build containers, and loose a fair amount of functionality. Conversely, my home computer is not on my work vpn so the proxy does not resolve, so this setting needs to be unset.
"remote.SSH.*": in my previous workplace, most settings needed non default values; typically I could also never "useLocalServer": true, although this would be what I use at my home setup.  In short, couldn't use most of the default I would use at home.
"dotfiles.repository": need to use corporate git at work, but at home I need my personal github.
"dev.containers.defaultExtensions": I don't use the same extensions at home, than those at work, but it doesn't support non default profiles.
"dev.containers.repositoryConfigurationPaths": anything with a path in it is subject to change from work to home (although this setting here I can specify an array with paths from both machine, but it's more a workaround).
"terminal.external.windowsExec": this one is not really important for my case: is use "wt" anywhere, but again this could potentially differ in an other workplace.
Settings sync came long before profile settings, so at that time I had to make a choice form 3 alternatives:

give precedence to home settings. every workday, I would need to manually toggle comments in my settings.json to use the work settings. (for extensions, install and sync extension for both home and work)

give precedence to work settings. when developing at home, I would need to manually toggle comments in my settings.json to use my personal settings; though sometimes I could have some basic uses of vscode at which do not need to toggle home/work settings. Also, before I'm done I must not forget to  manually toggle back the work settings. (for extensions, install and sync extension for both home and work)

stop using settings sync.

Option 1) is bad since I mostly use vscode at work. Option 2) is actually what I have been doing ever since I start using the experimental 'Settings Profile' feature not long ago. Since I mostly use work computer, and that in the end there is only a rather very small and bounded subset of incompatible settings, option 2) has been good enough for long time and I never envisaged to adopt option 3).
So I started using the settings profile feature as it was in the experimental phase, and it did solve well my use case: when hired in a new workplace (with a corporate laptop, or remote desktop), I would bring my own settings, extensions, keybindings, etc which is my default profile. Then if I needed, I create a new work profile by copying my default profile, and change the few settings that are workplace specific.

@jvillemure Thanks a lot for using settings sync and profiles feature and also explaining your use case for both features. As you also know we have fixed #176678 already and we are discussing about what best we can do to support #176132.
Focusing on this issue, can you please let me know what else you are missing or seeing difference from old and current behaviour other than above 2 issues. I am sorry if you already said it and I missed in the previous comment?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


File uploading error

Updated atom into 0.129 I get this error every time I try to upload a file:
Uncaught TypeError: Cannot read property 'getPath' of undefined
../.atom/packages/SFTP-deployment/lib/filesystem/FileManager.js:98

Hi guys,
Sorry for the long period of inactivity.
We are currently working on a new version : better code, more stable, and bug fixes.
This bug will be fixed at the next release.
Thank you for using our work ! :)

Hi guys,
A new version (1.0.0) was published tonight.
Feel free to reopen if the problem is still there.
Enjoy ! :D


Remove [-1, 1] constraint for atan

Problem Statement
For atan we currently check in https://github.com/crate/crate/blob/0f47b8185b6681f06f3798c5392d11646a377d46/server/src/main/java/io/crate/expression/scalar/arithmetic/TrigonometricFunctions.java#L43 if the input is in [-1, 1] range.
So select atan(pi()) for example, raises an error.
This breaks trigonometric identities, for example:
tan(atan x) = x, for all real numbers x
atan(tan x) = x, for x ∈ (-π/2, π/2)
Query ran at 2024-02-28T15:22:54.801Z on CrateDB 5.5.2
select
  atan(tan(-1));

SQLParseException[input value -1.5574077246549023 is out of range. Values must be in range of [-1.0, 1.0]]

In PostgreSQL (taking into account floating point precision) this is respected:
select tan(atan(2)); -> 1.999999999998
select atan(tan(pi() / 2)) = pi() / 2; -> true
select atan(tan(-1)); -> -1
select atan(pi()); -> 1.262627255678

This is also true in Python (and most likely in most places)
>>> math.tan(math.atan(math.pi))
3.141592653589794

Possible Solutions
Remove check.
Considered Alternatives
No response

Found this while running Tableau connector-sdk tests


Change text on posting jobs on mailing lists

There's a small suggestion I'd like to make

@andyfaff please do:)

When I first sat down this morning it didn't seem to scan right. That was before I had a cup of tea though, it looks ok now.

Tea or coffee makes everything look better:)


1.5.x State Script Clarification

1.5.x version of https://github.com/mendersoftware/mender-docs/pull/42


There are action events stored in the event datastore without a TTL.

The issue was due to action event being expired but not the channel event set used to manage event control flow.


How to use the offline version? Index.html in the root directory after code download cannot be used

How to use the offline version? Index.html in the root directory after code download cannot be used

Could you describe your code downloading? Just git clone or download index.html

nothing。。。

You need to compile source files using  npm run build and you can find all compiled files in dist folder.


unicore-spring-boot-starter update

Coverage remained the same at 18.554% when pulling 41d8a502a6ae5f34818fb1022bab9b0b6b25b69b on unicore-libs-update into 1c196bb733b6e066186bd14e9803fb26f8071dd6 on master.


Group chat - Unable to search for members when inviting group members

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to a group chat.
Click on the chat header.
Click Members.
Click Invite member.
Search with a valid term.

Expected Result:
The results are not filtered. Nothing happens after searching for a member.
Actual Result:
The relevant results will come up.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/772a3be9-b923-4df4-a132-4bb621f38c3d

View all open jobs on GitHub

We think that this bug might be related to #vip-vsb

I can repro this, not responding to the input at all:
https://github.com/user-attachments/assets/0c9a36fc-19b5-4213-af98-8a250eef45bf
Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409? @TMisiukiewicz @adhorodyski @mkhutornyi?

FWIW, from testing this it seems isolated to group chat > members > invite members and the bug is not on production.

Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409?

Git bisect led me to the same PR https://github.com/Expensify/App/pull/46409, creating a revert PR in a moment

It's a pretty big PR that. Do we know why there's a problem here with the groups members page only? I'm wondering if we want to get a fix up for that, instead of a full revert.

In fact, I think we should probably not block on this. The perf gains in the core flows (start chat, submit expense etc) aren't worth reverting for this bug in the groups members page which aren't really utilised much right now.

Removing getSearchText speeds up creating option list by around 40%. In the context of a trace provided for a linked issue, it reduces accumulated createOption time from 5.7s to 4s (~42% improvement)

So maybe we demote, and @adamgrzybowski @TMisiukiewicz can look into the fix as a Daily?

@trjExpensify I'll take care of it today 👍

@trjExpensify me or the other Adam? 😄 @adhorodyski

Adam H, my bad!

haha sure thing, please see https://github.com/Expensify/App/pull/47051 - I believe this should be enough to avoid reverting:)

PR open ✅

PR is on staging!

This was deployed to prod on the 16th per https://github.com/Expensify/App/issues/47356 -- updating with payment labels!

Summarizing payment on this issue:

Contributor: @TMisiukiewicz no payment due (agency)
Contributor+: @hoangzinh $250 via Upwork - I extended an offer, please accept when you get a chance! https://www.upwork.com/nx/wm/offer/103711752

Upwork job is here: https://www.upwork.com/jobs/~01377f35a0f0d576f7

Thanks @hoangzinh, all paid!


Unable to create a project using cubecell_board

When I download arduino-blink project I am not able to download dependencies through platformio.
and not able to compile:
Output:
MissingPackageManifestError: Could not find one of 'package.json' manifest files in the package

Build:

Processing cubecell_board (platform: heltec-cubecell; framework: arduino; board: cubecell_board)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
MissingPackageManifestError: Could not find one of 'package.json' manifest files in the package

Do you have any idea on how to solve this ?
Thanks!

Solved by adding this to my platformio.ini
platform_packages =
<EMAIL_ADDRESS>

Solved by adding this to my platformio.ini
platform_packages =
<EMAIL_ADDRESS>


Query return on Select

hi there is there any way for it to return on .select query? example
Person.where(name: "Jason").select(:name, :hashid)

Hi @hleow0707,
The hashids aren't stored in the database so there's no way to select them directly. But hashid is just a computed property derived from the id. So for the example above, to use a select to limit the columns retrieved, you would want to grab the name and id. That would make the hashid attribute available without any additional queries.
person = Person.where(name: "Jason").select(:id, :name).first
# Post Load (0.3ms)  SELECT id, name FROM posts LIMIT 1
#=> #<Person id: 1, name: "Jason">
person.hashid
# (no additional query needed)
#=> "NYyt0N"

Hope that helps! Cheers.


Kk sap event mesh

SAP Event Mesh connector

@mayankmendix I've made the requested corrections. Let me know when we're ready to publish.


preprocess error

Hi, thanks for your sharing!
I have a problem when preprocessing.
The error as follow:
nnFormer_plan_and_preprocess：未找到命令
Can someone tell me how to solve this problem? Thank you!

Yes, I will have a try. Thank you very much!
And I have another problem. Training set has 80 patients in the ACDC_dataset.json.
Is the training set : test set 8:2?

No, actually this code is based on the foundation of nnunet. So in the Json file, the 'numTraining' contains both training nums and validation nums.


what's a resource?

I did not find a definition. If you mean to use a def from another doc, that needs a ref.

this was addressed in PR #180


Added StagingWorkflow (e.g. for streamlined use in gulp/grunt)

Implemented
New code to create a streamlined staging function by collating together all API call required to:

Create a minPack from the original binary folder
Apply a minPack to a test folder
Check the minPack from the test folder against the original binary folder
Clean up (remove redundant files) in the original binary folder
A Promise is returned which when resolved provides the minPack to allow is to be persisted for future use

Documentation

Added the new function to the usage section (gulp example)
Added the new function to the API section

Testing

Added test cases to cover 100% of the new code

Pull Request Test Coverage Report for Build 12

42 of 42 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.005%) to 99.654%

Totals

Change from base Build 10:
1.005%

Covered Lines:
201

Relevant Lines:
202

💛  - Coveralls


Add emoji to conversation auto titles

Pull Request Template
⚠ Before Submitting a PR, Please Review:

Please ensure that you have thoroughly read and understood the Contributing Docs before submitting your Pull Request.

Summary
Add an emoji to the start of the auto conversation title, it's quite cute and visually helpful to differentiate between the conversations.  New auto-titler prompt:
Write a concise title for this conversation in the given language.
Title in 5 Words or Less. No Punctuation or Quotation.
Must be in Title Case, written in the given Language.
Find an appropriate emoji to start the title.
Examples:
🌿 Sustainable Gardening Tips
🚀 Space Exploration Future Plans
🎨 Modern Art Movement Analysis
🏋 Effective Workout Routines Explained
🍳 Quick Healthy Breakfast Ideas

Change Type

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Both a new look, and claude 3.5 generated the training list which may nudge the titler away from the way it worked before.

If you don't approve of this, is there a simple way for those using docker to update prompts for themselves?
Testing
Tested on my server, look nice!
Checklist
Please delete any irrelevant options.

[x] I have performed a self-review of my own code
[x] My changes do not introduce new warnings

👍👍❤❤🎇🎇🧨😍


[EngSys] unpin chai version @4.3.0

Resolves issue https://github.com/Azure/azure-sdk-for-js/pull/29414
also removing "esm" dev dependency that is no longer used.

API change check
API changes are not detected in this pull request.


main > dev

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


UDP connections do not close the underlying file descriptor

Describe the bug
In udp connection case, after React callback has been finished, the udp connection does not close the
underlying fd. This makes problem with too many open files error for long runs

Why would you expect gnet to close the underlying fd after gnet.React when the server is still running? I'm pretty sure that a UDP server doesn't create a fd every time it receives a packet from a client.

Why would you expect gnet to close the underlying fd after gnet.React when the server is still running? I'm pretty sure that a UDP server doesn't create a fd every time it receives a packet from a client.

yes, sorry i had problem in our tcp connection which was on our client side not closing properly.

yes, sorry i had problem in our tcp connection which was on our client side not closing properly.


No document for sys.dm_os_enumerate_filesystem

I can find the document for sys.dm_os_enumerate_fixed_drives, but I cannot find the document for sys.dm_os_enumerate_filesystem
ref: sql-doc github

@hochun836 -- Ho, thank you for your feedback.  I am investigating.

This is correct. It is not documented.

@rwestMSFT -- Randolph, thank you for commenting.  Is sys.dm_os_enumerate_filesystem purposely undocumented?

No, it was not intentional. I've added it to my backlog. It may take weeks or months to get it documented.

AB#90630
Closing because we're tracking this internally. Thanks again, @hochun836, and to @WilliamAntonRohm for following up.

Update: we will not be documenting this stored procedure for the foreseeable future, because it is for internal use, and is not supported.


Upgrade Ruby to 2.2.3

It's good to upgrade, in order to keep ruby secure and up-to-date.
This upgrade involves:

removing the 'debugger' gem which isn't compatible with ruby 2.1 and above
upgrading the 'raindrops' and 'kgio' gems so they compile under the new ruby version

/cc @alext @boffbowsh

:100: Yay, this is the last thing running on ruby 2.0.0.  Good to see it upgraded.


Add RSA Signature Scheme in core/signatures

This requires:

[x] Add RSA implementation of Signer and Verifier in core/crypto/signatures.
[x] Add entry point to core/crypto/signatures/factory.
[ ] Add client ability to generate RSA keys and store them in KeyStore.

Implementing this feature will be done with (at least) three Pull Requests.

For the time being, we will not allow client to use RSA keys to sign updates.


more complex dependencies are not found

First of all, I just want to say I love the library and I use it a lot to make sure our code quality is high and we don't share unwanted dependencies.
I have found an issue with non "normal" imports when used in a project.
Specifically, what Typescript calls Re-Exports
In the attached example a -> b -> c -> a but the library misses this because c re-exports from b.
If you were to uncomment the import and export you'd see that it indeed fails the test :)
keep up the great work!
test.tar.gz

it seems that modifying the code in extractGraph will make it work like so:
if (ts.isExportDeclaration(x) || ts.isImportDeclaration(x)) {
const normalizedSourceFileName = path.relative(rootDir, sourceFile.fileName)

const specifier = x.moduleSpecifier
if (!specifier) {
	return
}

but I'm not familiar enough with the TS AST to know if it really covers all bases.


Correct absolute assets path on all builds?

What is the correct path for assets reference on ALL build?
In css I use some image like:
background-image: url(/assets/imgs/icons/close.svg);

This works with ionic serve and ionic cordova run android -lc but not with ionic cordova run android --prod.
I also have problems with relative path. Look at this lines and comments. Tested in ionic serve mode (also with cleared cache)
/* These lines doesn't work. */
-webkit-mask-image: url(assets/imgs/icons/close.svg);
-webkit-mask-image: url(./assets/imgs/icons/close.svg);

/* These lines works. */
-webkit-mask-image: url(/assets/imgs/icons/close.svg);
-webkit-mask-image: url(../assets/imgs/icons/close.svg);
-webkit-mask-image: url(../../assets/imgs/icons/close.svg);
-webkit-mask-image: url(../../../assets/imgs/icons/close.svg);
-webkit-mask-image: url(../../../../assets/imgs/icons/close.svg);
/* and so on. why? */

I'm looking for a always-working-path in every style-file. Also for src-references in html-tags and http-get, to load assets.
Some console prints of the prod build viewed with chrome developer tools remote device inspector.
Filed to load resource:
file:///android_asset/www/assets/fonts/roboto-regular.woff2
...
Failed to load resource:
file:///assets/imgs/icons/close.svg

Don't know why the font is missing? Is it a ionic request?
In production build, the icon resources from assets can't load. (css url(path))

Finally the path ../assets works on production build. What's your experience? Am sure that's not all. I'll stumble again over this issue. Is there a official documentation about this problem?


perf(allocator): use capacity hint

#4584  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucab and the rest of your teammates on  Graphite

@lucab does Vec::extend not already ensure sufficient capacity from the size hint before it starts pushing? That's a genuine question, not a criticism! I don't know the answer. But if extend doesn't, it should!

@overlookmotel unless I misunderstood the code, it performs a check-and-resize step for each element to push: https://docs.rs/allocator-api2/latest/src/allocator_api2/stable/vec/mod.rs.html#2758-2785

Thanks for coming back. Interesting. That's pretty damn inefficient!
That said, I guess it has to check on each turn of the loop, if the iterator isn't "trusted". I think it's legal (although unfortunate) for an iterator to provide an incorrect size hint (or one that's an estimate).
std has the concept of a "trusted iterator" which promises its size hint is 100% accurate, and then extend can just do 1 capacity check at the start, and not on every turn of the loop. But I'm not sure if that facility is available in "userland" - I think might require some nightly features.
I hope to replace our current Vec implementation with something new (https://github.com/oxc-project/backlog/issues/18), and can try to improve this situation at same time.
Or if you're interested, and up for a bit of an unsafe code brain-bender, would you like to look into it? That's quite a sizeable project though!
NB: https://github.com/oxc-project/backlog/issues/35 is also relevant, though I'm guessing we'll probably only use a chunked vec type to replace some Vecs, but not all of them, so we'll likely still need a standard Vec type.


fix: make sidebar menu arrow position fixed

Should fix https://github.com/facebook/docusaurus/issues/4565

Before
After

@lex111 could you resolve the conflicts and self-merge (forgot if you have permissions).

@Simek reported that there is a new border on code items in the TOC, is this on purpose?
https://reactnative.dev/docs/scrollview
VS
https://deploy-preview-2573--react-native.netlify.app/docs/scrollview

This border is almost invisible in the dark theme BTW.
I don't have a strong feeling about adding a border or not in this case, but maybe it is preferable to keep former behavior (no border) as nobody complained about it?

Border is needed, this one works fine with default styles (as
intended). Of course, in the case of large customizations, it may not
fit, but then you can just manually remove it in custom CSS file,
right?
2021-05-06 11:45 GMT+03:00, Sébastien Lorber @.***>:

@Simek reported that there is a new border on code items in the TOC, is this
on purpose?
https://reactnative.dev/docs/scrollview
VS
https://deploy-preview-2573--react-native.netlify.app/docs/scrollview

This border is almost invisible in the dark theme BTW.
I don't have a strong feeling about adding a border or not in this case, but
maybe it is preferable to keep former behavior (no border) as nobody
complained about it?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/facebookincubator/infima/pull/106#issuecomment-833349412

Border is needed

Can you explain why?

To better separate background color of inline code from foreground of page. This is common design pattern, so nothing unusual here.

To better separate background color of inline code from foreground of page. This is common design pattern, so nothing unusual here.

So it's not needed, (it's only a visual improvement in some cases). Also I wonder why this UI change has been smuggled in non-related sidebar fix?

There is a PR about inline code blocks.
I suggest we move the discussions on the appropriate PR:   https://github.com/facebookincubator/infima/pull/113


[requires.io] dependency update on develop branch

@pbteja1998 Can you add coderplex-bot as user for requires.io PR's instead of your account. I will share coderplex-bot credentials in discord with you.

@vinaypuppal ok Sure...

Release 2.0 Release Notes
@rrmerugu The above are the release notes for Django 2.0 . Do you think we should upgrade to 2.0 or stay in 1.11.7

It seems like build has failed with the existing code if we use Django 2.0

First of all 1.11 is the LTS so we can bet on it for support and updates.
while I understand the concept of using the latest tech in space. but generally it takes a while for all the supporting app around the Django to support the latest 2.0. So its ideal to stick with LTS (Django 1.11 in this case) to avoid any such support issues.
`
Django 2.0 will be the last release series to support Python 3.4. If you plan a deployment of Python 3.4 beyond the end-of-life for Django 2.0 (April 2019), stick with Django 1.11 LTS (supported until April
2020) instead. Note, however, that the end-of-life for Python 3.4 is March 2019.
Reference: https://docs.djangoproject.com/en/2.0/releases/2.0/#python-compatibility
`

Yeah, you are right...

@rrmerugu  I added rq filter to django in requirements.txt. Basically what it does is, if any new django version greater than the present version and less than 2.0 is found, then requires.io notifies with pull request, otherwise it still shows that the requirements are up to date.

You can approve merge this now.

sounds good, but we don't need to support multiple version of Django, this project is not a library, which would be used as a part of another application, since this is a standalone application that can run on its own and destined to run on a single environment, we can stick with one version.

Ok, then I will add filter to be equal to 1.11.7, otherwise the requires.io badge will show outdated even though all the requirements are up to date.


AMI ID requirement conflict between Karpenter and Launch Template

Description
Background:
Using EKS Managed Node groups (created with terraform-aws-modules/eks/aws) also creates launch templates. However, the launch templates do not contain AMI IDs and attempting to add IDs generates an error. That is, adding AMI IDs to a launch template is not allowed.
Error: updating EKS Node Group (NameOmitted) version: InvalidParameterException: You cannot specify an image id within the launch template, since your nodegroup is configured to use an EKS optimized AMI.

Observed Behavior:
Karpenter fails to provision a new node and reports amiIdList cannot be empty when trying to use the template.
2023-07-31T17:38:00.634Z	ERROR	controller	Reconciler error	{"commit": "34d50bf-dirty", "controller": "machine.lifecycle", "controllerGroup": "karpenter.sh", "controllerKind": "Machine", "Machine": {"name":"gpu-47gfh"}, "namespace": "", "name": "gpu-47gfh", "reconcileID": "8af39500-12d6-4244-a6d4-58e5de1af7c3", "error": "creating machine, creating instance, creating fleet InvalidParameterValue: Parameter 'amiIdList' cannot be empty.\n\tstatus code: 400, request id: f6506f26-5d40-426a-ae26-859b692bb7a4 (f6506f26-5d40-426a-ae26-859b692bb7a4)"}

Per what I understand from the documentation, AWSNodeTemplate should default to the correct image, even if one isn't supplied.
Expected Behavior:
Karpenter should provision a new node based on the template.
Reproduction Steps (Please include YAML):
apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: gpu
spec:
  requirements:
    - key: karpenter.sh/capacity-type
      operator: In
      values: [ "spot" ]
    - key: node.kubernetes.io/instance-type
      operator: In
      values:
        - p4d.24xlarge
  providerRef:
    name: gpu-spot
  taints:
    - effect: NoSchedule
      key: nvidia.com/gpu
      value: "true"
  ttlSecondsAfterEmpty: 60
---
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  name: gpu-spot
spec:
  subnetSelector:
    Name: "some-subnet-*"
  launchTemplate: gpu_spot-01234567890

Versions:

Chart Version: v0.29.2
Kubernetes Version (kubectl version):

% kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.27.3
Kustomize Version: v5.0.1
Server Version: v1.27.3-eks-a5565ad

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Direct support for launch templates in Karpenter is deprecated: launchTemplate: gpu_spot-01234567890. There are many rough edges with user-managed launch templates, so we haven't done any improvements to this since it was initially launched in 2021. You'll also find that it's been removed from our docs for >1 year.
I'd recommend moving towards AMIFamily driven launch templates: https://karpenter.sh/docs/concepts/node-templates/#specamifamily

Thanks for getting back to me @ellistarn. It looks like the recommended approach has Karpenter creating its own launch templates, which would mean that the ASG created in Terraform is not going to be used. In other words, I shouldn't create managed node groups at all and let Karpenter do it instead. Is that correct?

Thanks for getting back to me @ellistarn. It looks like the recommended approach has Karpenter creating its own launch templates, which would mean that the ASG created in Terraform is not going to be used. In other words, I shouldn't create managed node groups at all and let Karpenter do it instead. Is that correct?

Correct. Karpenter has no dependency on ASG, and launches nodes directly using the fleet API.


Classification prediction output

Classification prediction output should be more user friendly.
Currently the output of sdf_predict() for classification models is very hard to work with. It should be possible for us to return something nicer, e.g. for multiclass we can have a predict column with predicted labels and a column for each label for probabilities.
Affected issues:
https://github.com/rstudio/sparklyr/issues/907 - order of probabilities in output vector is confusing
https://github.com/rstudio/sparklyr/issues/928 - difficult to get predicted labels
https://github.com/rstudio/sparklyr/issues/762 - inconsistent prediction output column names
https://github.com/rstudio/sparklyr/issues/605 - ft_index_to_string() doesn't behave as expected

Absorbing this story into https://github.com/rstudio/sparklyr/issues/944. It'll take longer to implement but should save time in the long term.


Minor: Add URL to log for Connect RestClient

I was using Kafka Connect (Confluent Image) to run an Iceberg Sink connector on 2 different AWS environments (running on ECS) and same Kafka cluster.
One of the connectors was working fine, but the other was continuously getting error below:

{"error_code":500,"message":"IO Error trying to forward REST request: java.net.SocketTimeoutException: Connect Timeout"}

After hours of debugging, I found that the Connect in second AWS environment was trying to reach out to the Connect in first AWS environment (apparently, that was the leader) and our firewall was dropping the request. By fixing the firewall, issue solved.
By having the URL in the error log message, we could easily find issue by looking at which IP it's trying to reach.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks @farbodahm! LGTM


feat: add CreateExitSpanWithContext

resolve #125

Codecov Report

Merging #126 (6a9dfde) into master (ddc26b2) will increase coverage by 0.25%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   69.33%   69.59%   +0.25%
==========================================
  Files          17       17
  Lines         887      888       +1
==========================================
+ Hits          615      618       +3
+ Misses        224      223       -1
+ Partials       48       47       -1

Impacted Files
Coverage Δ

trace.go
82.47% <69.23%> (+2.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc26b2...6a9dfde. Read the comment docs.

Quick pull request, thanks.


In final phase of test_body_motion, move and cull AABB for body once instead of for every shape

As briefly discussed on RocketChat, two lines (moving body_aabb and calling _cull_aabb_for_body) were moved into a loop over shapes in https://github.com/godotengine/godot/commit/66c6dfb3fd89d34ca9e35276113d3f105717e03d for 2D and (for consistency?) in https://github.com/godotengine/godot/pull/46148 for 3D. This PR moves those lines back to their original position, where they likely belong, as "repeatedly moving the AABB, once for each shape" does not seem to be logical.
There are no regressions when running the test projects from https://github.com/godotengine/godot/issues/16250, https://github.com/godotengine/godot/pull/35945#issuecomment-660652478, https://github.com/godotengine/godot/issues/45971, https://github.com/godotengine/godot/issues/45971#issuecomment-780217011, https://github.com/godotengine/godot/issues/46134 (after updating them to run under master). With more effort, more of the test projects linked in https://github.com/godotengine/godot/pull/46148 could be tested.

Thanks!


[occm] Disable openstack-cloud-controller-manager CI job

What this PR does / why we need it:
There are issues when v1.21 openstack-cloud-controller-manager is talking to v1.19 k8s cluster. Disable the job for now to not block upstream contribution. More information here: https://kubernetes.io/docs/setup/release/version-skew-policy/#kube-controller-manager-kube-scheduler-and-cloud-controller-manager
We have to manually test the PR when doing review.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/lgtm

/approve

@lingxiankong any idea on timeline on upgrade of cluster to 1.20/1.21 ?

@lingxiankong any idea on timeline on upgrade of cluster to 1.20/1.21 ?

One of my workmates is working on this but may need some time until all the functional tests pass, but there is another issue I realized yesterday, there is a single cluster that runs our CI jobs for all the supported branches, e.g. the cluster is v1.21, but we may run CI jobs for our release-v1.19 and release-v1.20 which is not preferable, unless we create 3 clusters at the same time but I need to apply that resources from our company which also takes some time.
I'm currently thinking about other potential approaches for openstack-cloud-controller-manager CI with the current openlab resources, but no luck yet.


Lambda

I have trouble using this inside AWS Lambda. Anyone had any success with it?

I figured it out. Buzz me if you have questions.


Roll js and quiver

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
Roll packages to pick up a new version of package:quiver that no longer depends on a deprecated Dart API.
List which issues are fixed by this PR. You must list at least one issue.
Related to https://github.com/dart-lang/sdk/issues/49529
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
n/a
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Had to update the quiver one due to https://github.com/google/quiver-dart/pull/717

Autoroller already fixed this, so closing:
https://github.com/flutter/flutter/pull/117357/files

Hmm, no that roll didn't pick up quiver for some reason (which is the critical one I need rolled)

Ugh, screwed up this PR. Will open a clean one.


A11y improvements for IDP service & update embed.go

Please do not merge before we've figured this out in the web team => need to discuss how we can deploy these with an updated a11y-branch for the re-audit
Description

Updated a11y feedback
Committed embed.gos for accounts and settings since Dependabot PRs were merged but no binaries were ever added

Related Issue

Fixes https://github.com/owncloud/web/issues/5376
Fixes https://github.com/owncloud/web/issues/5377

@kulmann should we merge this for the release next week and cherrypick the commit when going for the second a11y-audit?

@pascalwengerter @kulmann Include in the release? then we should merge now.

@pascalwengerter @kulmann Include in the release? then we should merge now.

Good to go from my side, waiting for feedback/review from Benedikt ;)