Zoom handles wrong slide #2827 - reopen

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.3.1

Platform/Target and Browser Versions: Chrome - Version 80.0.3987.87 (Offizieller Build) (64-Bit)

Live Link or JSFiddle/Codepen or website with isssue: https://stackblitz.com/edit/swiper-demo-39-zoom

What you did
Configured Swiper to simulate touch and use zoom with toggle.

Initialize Swiper
Double click on slide to zoom in (manually)
Call mySwiper.slideNext() or mySwiper.slideTo() to switch to the next slide
Call mySwiper.zoom.in()

Expected Behavior
The current slide should be zoomed.
Actual Behavior
The previous slide is zoomed
(mostly copy and paste from #2827)

I've been having this same exact issue. Only reproducible using the method zoom.in() Which is what i need to use

Fixed by #3451


policy: Don't nil an empty selectors map.

[ upstream commit 03bfb2bece5108549b3d613e119059758035d448 ]
Turns out unit testing did not need this any more and this actually caused a runtime panic.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-backport-1.9


Do you plan to support REJECT LIMIT option to import?

When importing, you can specify the allowed number of bad lines, whether this parameter will be supported during import.

No plans to add it right now, since this parameter makes more harm than good - it hides errors and various problems with data. Also, getting faulty rows back from server is a bit complicated and requires a reader process which will not block.
In most cases, it's much better to fix the data source or add a proper external data validation, which is not related to Exasol.


Word breaks () and soft hyphens ().   QuirksMode covers this, but is a bit out ...

Word breaks (<wbr/>) and soft hyphens ().
QuirksMode covers this, but is a bit out of date: http://www.quirksmode.org/oddsandends/wbr.html

This issue was imported from Google Moderator
Moderator votes: +9
Issue added by Callum on 2011-10-11
To vote this issue up or down, simply include +1 or -1 in your comment.

The <wbr> part duplicates #1032.

The soft hyphens part duplicates #1218.


add: unicode test cases for cross-sheet names

This PR adds additional corner cases tests for unicode names in worksheets being referenced in the same workbook.
All the tests pass in nodejs and (should) with browser (minus the Windows exceptions).
Provides tests for the fix @mohammedsahl added (#2046)

Looks good!  Running the browser suite now, @janiewang26 https://app.saucelabs.com/open_sauce/user/sheetjs/tests/vdc shows the tests and https://app.saucelabs.com/open_sauce/user/sheetjs/builds shows the most recently finished builds.  Once all the tests pass, merge the changes

The travis fails are due to the test_files not having been updated.  I can do this after merging


Rollback should rollback all changes, even if invalid

If a cset value is changed from a valid value to an invalid one an error is set within addError but this is not considered a CHANGE. Running rollback() on a cset should revert all changes, even the invalid ones.

I am not able to reproduce this.  rollback is reverting everything for me.  Can you provide more info on your usage?


News lines in the analysis

As I spoke to @Irio, this version goes through toll expenses to be later merged with car rental expenses.

HI @rodolfo-viana and @jtemporal
I'll return to this PR to refactor the suggestions made by @jtemporal and then add it to the project ;)

Closed as after  merging Jarbas and Rosie in we no longer store notebooks


UI Issues DS #2

**Rancher Versions:**4/14
Issues:

[x] Can't add container when I first get in.  Null stack

[x] Container details - Clicking around tabs is causing crash.

[ ] Main Scaling Group page - When I have show system checkbox on all scaling groups change from Up to Date to  Checking upgrades....

[ ] Can we add an image or something to create new account email?

[ ] New Host key Name title is all lower case.  First letter should be upper case

[ ] Add Host Favorites - when I move my mouse over favorite or browse, a line appears but it's not aligned

[x] Preferences - the Table Rows Per Page and the Save are not aligned and look strange

[ ] Main host page - Images and tooltips for different view is missing

Version - 6/2
Host is being redone, all other issues have been worked on.


Context support in Column-display annotation

This PR addresses the context issue in column-display annotation. It handles context-specific formatting now.
Once we merge this PR the record2 test-cases in Chaise will fail. I will fix them after merging this PR.

It looks fine to me.


[Request] RSS for my RSSs

Love this, it would be great to generate a consolidated RSS feed that could be used elsewhere (like my newsletter app, etc, but maybe there’s a better tool to do that)

The app focuses on the final reading experience so I didn't support RSS as an output format. I wonder if this is what you are looking for: http://www.rssmix.com/ ?


Request for new terms related to rice development stages

Hi,
We are trying to incorporate PO terms for rice development stage in our single-cell studies. Especially the inflorescence meristem development stages are critical for the agronomical traits in rice and other cereals.
Would it be possible to adopt the definition system from the Oryzabase organs and stages page?
Thanks,
Shiyu

Hi Shiyu, I am happy to take a look at these, but the link above just goes to the general search page.
Could you please provide a list or a spreadsheet of the terms you are requesting, with the proposed definitions?

Hi,
Thank you for considering.
The list of developmental stages is on this database page.
I've attached the list in the file Oryzabase_developmental_stages.xlsx
More detailed descriptions can also be found in this paper.
Best,
Shiyu


Set PR labels

Labels can only be set by users with push permissions, so we do this as a separate task using the admin token instead of the user's token.

@Floppy is this PR ready to go in? (Dependabot has been opening manifesto proposals again :)

It wasn't working for some reason. I need to take a look at it and find out why. Will try to do that soon!


graceful stop

each ctrl-c will crash, do not know why
Server config: ServerConfig(service_port=22345, manage_port=18080, log_level='warning')
[2024-10-17 01:37:55.847] [infini] [info] Can't find or failed to open the specified device, try to open the default device
[2024-10-17 01:37:55.851] [infini] [info] Memory pool size:<PHONE_NUMBER>4 bytes, block size: 32768 bytes, total blocks: 524288, it may take a while
[2024-10-17 01:38:02.469] [infini] [info] Memory pool allocated at 0x7f5354000000
[2024-10-17 01:38:03.235] [infini] [info] register server done
[2024-10-17 01:38:32.952] [infini] [info] new connection...
[2024-10-17 01:38:32.968] [infini] [info] HEADER: op: E, body_size :24
[2024-10-17 01:38:32.968] [infini] [info] do rdma exchange...
[2024-10-17 01:38:32.973] [infini] [info] gid index: 3
[2024-10-17 01:38:32.974] [infini] [info] RDMA exchange done
[2024-10-17 01:38:33.240] [infini] [info] HEADER: op: D, body_size :20
[2024-10-17 01:38:33.240] [infini] [info] do rdma write keys: 3, remote_block_size: 4096
[2024-10-17 01:38:33.240] [infini] [info] response error code 202
[2024-10-17 01:38:50.407] [infini] [info] destroy cuda stream
[2024-10-17 01:38:50.409] [infini] [info] QP destroyed
^CTraceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/root/infinity/infinistore/server.py", line 112, in <module>
    main()
  File "/root/infinity/infinistore/server.py", line 108, in main
    loop.run_until_complete(server.serve())
  File "uvloop/loop.pyx", line 1511, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1504, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1377, in uvloop.loop.Loop.run_forever
  File "uvloop/loop.pyx", line 555, in uvloop.loop.Loop._run
  File "uvloop/loop.pyx", line 474, in uvloop.loop.Loop._on_idle
  File "uvloop/cbhandles.pyx", line 83, in uvloop.loop.Handle._run
  File "uvloop/cbhandles.pyx", line 63, in uvloop.loop.Handle._run
  File "/data00/anaconda3/lib/python3.11/site-packages/uvicorn/server.py", line 68, in serve
    with self.capture_signals():
  File "/data00/anaconda3/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/data00/anaconda3/lib/python3.11/site-packages/uvicorn/server.py", line 328, in capture_signals
    signal.raise_signal(captured_signal)
KeyboardInterrupt
Segmentation fault (core dumped)

	rm -rf ../infinistore/$(PYBIND_TARGET)
	cp $(PYBIND_TARGET) ../infinistore/

use this to fix this.


drivers:mtd:w25qxxxjv.c: use different protect bits and address lengts

Different w25qxxxjv chips has different protect bits (3 or 4 bits) and different address lengths (3 or 4 bytes).
Testing
Tested with w25q256jv on stm32H743.
fstest
End of loop memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena       cd850    cd850
ordblks         4        4
mxordblk    75600    75600
uordblks    2a3c0    2a3f0
fordblks    a3490    a3460

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena       cd850    cd850
ordblks         4        4
mxordblk    75600    75600
uordblks    2a3c0    2a3c0
fordblks    a3490    a3490

nsh>smart_test -s 100 /mnt/log0
Creating file /mnt/log0 for write mode
Writing test data.  2000 lines to write
1999
Done.
Performing 100 random seek tests
100
Append test passed
Creating circular log with 40000 records
Performing 0 circular log record update tests

Pass

@AlexanderVasiljev could you squash the patchset into one or two?

@AlexanderVasiljev could you squash the patchset into one or two?

Of course, I will do it after all checks.


knex.raw returns promise

Environment
Knex version:0.20.13
Database + version: pg 12
OS: ubuntu
can i use the below code 0.20.13
promises.push( db.raw('SELECT 1'));
then using await Promise.all(promises) where promises is an array
in the webstorm debugger it is showing it as an raw object not promise also i tried below its not going inside then nor inside catch
db.raw('SELECT * from school_event_mapping limit 1').then((row)=>{
console.log('koknnoko',row.rows);
}
).catch((e)=>{
console.error('error--catc',e);
});
so does knex.raw() returns promise here db = require('nex')({config})

@tarunsinghh Check the documentation for raw, you would typically use it as a parameter inside more typical query-building structure: https://knexjs.org/#Raw

@kibertoad  iam making a healthcheck api,how do i then write select 1 in knex that will return promise

also @kibertoad  The knex.raw may also be used to build a full query and execute it, as a standard query builder query would be executed. The benefit of this is that it uses the connection pool and provides a standard interface for the different client libraries.
knex.raw('select * from users where id = ?', [1]).then(function(resp) { ... });,   so what Iam doing wrong

@tarunsinghh Probably you are not awaiting your promise or something along these lines. I just tried
    const x = knex.raw('SELECT * from school_event_mapping limit 1').then((row)=>{
        console.log('koknnoko',row.rows);
      }
    ).catch((e)=>{
      console.error('error--catc',e);
    });

and x is definitely a Promise there. Do you instantiate db correctly?

@tarunsinghh You can use heartbeat util from here, if you want: https://github.com/kibertoad/knex-utils/blob/master/lib/heartbeat.utils.js

@kibertoad
My problem is :-
I am writing a healthcheck api , i have a function
function check() {
try {
info = await healthCheck()
} catch (error) {
logger('healthcheck failed', error)
return sendFailure(res, { error: error.causes })
}
return sendSuccess(res, { info, verbatim: healthChecks.verbatim })
}
}
and in healthcheck function Iam performing certain checks like pinging mongo, postgres, redis and it looks like
function healthcheck() {
let promises = [];
promises.push(mongoConnection.command({ping: 1})); // this is a promise,working fine
promises.push(db.raw('select 1'));  // have doubt on this whether db.raw('select 1') is promise or not
promises.push(redis.client.ready === true ? Promise.resolve('redis connected') : Promise.reject(new Error('not ready'))); //working fine
return Promise.all(promises);
}
so my whole doubt is on the line promises.push(db.raw('select 1')); whether db.raw('select 1') is a promise or not, if not what change i will have to do in the above code to make it work ?


Job with a delay set gets executed immediately

Setting a delay doesn't actually delay the execution of the job. I've only tested this in development mode so not sure if it's also a problem in the hosted version? With the following enqueue the job gets executed immediately:
import reminderQueue from "./queues/reminder";

// pages/api/setupReminder.js
export default async (req, res) => {
  const email = req.body;
  await reminderQueue.enqueue(email, {
    id: email,
    delay: "1m",
    repeat: {
      every: "1m",
      times: 1,
    },
  });
  res.status(200).end();
};

Full repro here: https://github.com/maxfi/quirrel-dev-water-reminder-demo

Hmm, that doesn't seem right. Thanks for providing a repro, will look into it.

Found the offender: https://github.com/quirrel-dev/quirrel/blob/b72891d98b819d200151d7df33e5778411045daf/api/src/scheduler/jobs-repo.ts#L150
I guess this should have been caught by one of the functional tests, but apparently not this specific combination of delay and repeat.every ...
Will provide a PR immediately.

Awesome. Thanks @Skn0tt. 🙏

Fixed in v0.10.1.


Logs observed as Cache 'layouts' created in EhcacheManager. when doing a login operation

How to reproduce:

Set oracle java version "11.0.13" 2021-10-19 LTS
Get the pack https://wso2.org/jenkins/view/products/job/products/job/product-is/4156/
Up the pack
Login to console

When doing a login to the console observed below logs which havent noticed in prior builds .
Are these logs required ? pls verify
[2022-07-19 21:23:18,567] [4927ff8a-de47-4f19-ab97-1ed4a6a23395]  INFO {org.ehcache.shadow.org.terracotta.offheapstore.paging.UpfrontAllocatingPageSource} - Allocating 10.0MB in chunks
[2022-07-19 21:23:18,692] [4927ff8a-de47-4f19-ab97-1ed4a6a23395]  INFO {org.ehcache.core.EhcacheManager} - Cache 'layouts' created in EhcacheManager.
[2022-07-19 21:23:18,705] [4927ff8a-de47-4f19-ab97-1ed4a6a23395]  INFO {org.ehcache.jsr107.Eh107CacheManager} - Registering Ehcache MBean javax.cache:type=CacheStatistics,CacheManager=urn.X-ehcache.jsr107-default-config,Cache=layouts

Environment information (Please complete the following information; remove  any unnecessary fields) :
IS 6.0.0
h2 default
jdk 11
ubunti 20

Closing since this cache will be used to keep the compiled layouts with layout customisation feature. These logs appear when a layout cache is initialised and therefore, intentional.


Error with packaging when deploying from a non-C: drive

Describe the bug
When running the command pattern "AWS: Deploy SAM Application" it fails on step Building function '[function name]' because of a script pointing to C: mount while the project is on a D: folder. We get error 'ValueError: path is on mount 'C:', start on mount 'd:''.
To Reproduce

Create a folder in D: or any drive other than C:
Create a workspace there
Create SAM application using command 'AWS: Create new SAM application'
Detect SAM CLI using command 'AWS: Detect SAM CLI'
Run locally the application to check it compiles and runs successfully
Try to deploy the application using command 'AWS: Deploy SAM application'

Expected behavior
SAM Application is successfully deployed.
Screenshots

Please see the full console dump in the Additional context section -

Computer (please complete the following information):

Windows Version: Windows 10 Pro v. 1903 x64
Visual Studio Version: 1.45.1
AWS Toolkit for Visual Studio Version: 1.10.0
SAM Version: 0.52.0

Additional context
Full console dump:
Starting SAM Application deployment...
Building SAM Application...
Error with child process: Building function 'CronLFunction'
,Running NodejsNpmBuilder:NpmPack
,Running NodejsNpmBuilder:CopyNpmrc
,Running NodejsNpmBuilder:CopySource
,Running NodejsNpmBuilder:NpmInstall
,Running NodejsNpmBuilder:CleanUpNpmrc
,Traceback (most recent call last):
  File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\runpy.py", line 193, in _run_module_as_main
  File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\runpy.py", line 85, in _run_code
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\__main__.py", line 12, in <module>
    cli(prog_name="sam")
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\decorators.py", line 73, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\lib\telemetry\metrics.py", line 96, in wrapped
    raise exception  # pylint: disable=raising-bad-type
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\lib\telemetry\metrics.py", line 62, in wrapped
    return_value = func(*args, **kwargs)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\commands\build\command.py", line 129, in cli
    mode,
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\commands\build\command.py", line 195, in do_cli
    modified_template = builder.update_template(ctx.template_dict, ctx.original_template_path, artifacts)
  File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\lib\build\app_builder.py", line 161, in update_template
    artifact_relative_path = os.path.relpath(built_artifacts[logical_id], original_dir)
  File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\ntpath.py", line 562, in relpath
ValueError: path is on mount 'C:', start on mount 'd:'
An error occurred while deploying a SAM Application. Check the logs for more information by running the "View AWS Toolkit Logs" command from the Command Palette.

I created this issue first in VS Code AWS toolkit but it seems is aws-sam-cli related. Also, there is a similar issue #1336 but solves it in a different part.


add/update results section

As discussed.  Below is a screenshot of the rendered output for context:

FYI @antje-s we need de-dwd-global-discovery-catalogue to be added to the Global Registry.

oh I just realised that Saudi Arabia is missing in the tables

I don't see Saudi Arabia anywhere in https://codes.wmo.int/wis/topic-hierarchy/_centre-id ?  Do they need to be registered? cc @amilan17

FYI @antje-s we need de-dwd-global-discovery-catalogue to be added to the Global Registry.

Shouldn't this be done ‘automatically’ via the official registration process?

FYI @antje-s we need de-dwd-global-discovery-catalogue to be added to the Global Registry.

Shouldn't this be done ‘automatically’ via the official registration process?

Correct.  Not sure of its status in the WMO Global Registry @chenxiaoxia2019 @amilan17

FYI @antje-s we need de-dwd-global-discovery-catalogue to be added to the Global Registry.

Shouldn't this be done ‘automatically’ via the official registration process?

Correct. Not sure of its status in the WMO Global Registry @chenxiaoxia2019 @amilan17

Hi, Tom. The GDC (DWD) was added to the Global Registry. Additionally, GDC (KMA) was removed as they decided not to provide such service.

FYI this PR has been updated with updated structure for GB testing and a sample report for fr-meteofrance-global-broker.
A PDF is included for reviewing in context.
Based on the initial "reports" GB, GC, GDC, the expectation will be for additional reports to created from the templates (per global service).


cargo web start fails

Question
please resolve this issue i m facing while doing cargo web start
cargo web start
Compiling yew v0.14.1 (https://github.com/DenisKolodin/yew#c33fe73f)
Compiling ryu v1.0.3
Compiling anyhow v1.0.27
Compiling proc-macro-nested v0.1.3
error: failed to run custom build command for yew v0.14.1 (https://github.com/DenisKolodin/yew#c33fe73f)
--- stderr
thread 'main' panicked at 'Yew requires selecting either the web_sys or std_web cargo feature', /home/alifya/.cargo/git/checkouts/yew-cffb4df3674cc4fb/c33fe73/build.rs:9:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
error: build failed
What I've tried (optional)

Hello :wave:,
Yew currently supports two different web crates, one is called web_sys and the other std_web. The first one is the more modern one, and is probably going to be the main crate in the Rust web ecosystem. The error message 'Yew requires selecting either the web_sys or std_web cargo feature' tells you that yew wants you to pick one through Cargo feature flags.
To fix this, you will need to add the following to your Cargo.toml:
yew = { features = ["web_sys"], version = "0.14.1" }

Replace web_sys with std_web if you want to use the other one, but if you are just starting out, you won't need that.

Thanks @TheNeikos!


Move application class to separate package (#288)

Do the same fix for oracle-xe module

Could you please add the reason for the change into commit message (what is the issue with original package)?


Prevent InstantJobRegistry from altering the content of JobRegistry

Pull request description
InstantJobRegistry role is to trigger jobs not to mess with the registry.
It's not its responsibility and may potentially generate issue in the context of #108 and job definition unicity.
This PR:

removes the update of the registry storage when a previously unregistered job is triggered and add a unit test to protect us from reappearing later.
includes as a free bonus track the removal of an unused JobRegistry method.

PR meta checklist

[x] Pull request is targeted at main branch for code
[ ] Pull request is linked to all related issues, if any.

Code PR specific checklist

[x] My code follows the code style of this project and AspNetCore coding guidelines.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] I have updated the appropriate sub section in the CHANGELOG.md.
[x] I have added, updated or removed tests to according to my changes.

[x] All tests passed.

@linkdotnet Changelog has been updated

Awesome - feel free to merge.


Suppress filters on variables with non-fixed-size types.

re: Discussion https://github.com/Unidata/netcdf-c/discussions/2554
re: PR https://github.com/Unidata/netcdf-c/pull/2231
re: Issue https://github.com/Unidata/netcdf-c/issues/2189
After some discussion, the issue of applying filters on variables
whose type is not fixed size, was resolved as follows:

A call to nc_def_var_filter will ignore such filters, but will issue a log warning.
Loading (from an existing file) a variable whose type is not fixed-size and which has filters, will cause the variable to be suppressed.

This PR enforces those rules.
Misc. Other changes

Add a test case to test the vlen change.
Make some minor clean-ups in various cmake and automake files.
Remove unused test

Good point, I should make sure it is mentioned in docs/filters.md

Thanks @DennisHeimbigner !


Form select. Don't work first click after selection.

Select elemtets: list can't be dropped down by first click fresh from pick one. Only second click by arrow make an action.

bad english. I know ;)

I believe we corrected this in a recent commit. I'll double check, but I think in the next release this is resolved.


With this PR or on master? It does, that has actually been a complaint a couple of times.

EVCC loadpoint doesn't try to enforce state in off state.

With this PR or on master? It does, that has actually been a complaint a couple of times. See syncCharger.

This is forked from master and I haven't changed the loadpoint etc.
I mention this, because I think it requires OCPP chargers implementation to handle these "unwanted" sessions during intialization.

The loadpoint will call Enable(true/false) as often as necessary. That will obviously not help if the charger can't do anything sensible with it.

@andig, I have two different concepts and would like your opinion.
Transaction will be stateful object that has 5 distinct states:

Unknown
RequestedStart
Running
Suspended
RequestedStop
Finished

Allowed transitions I think will be self explanatory.

Transaction is implemented in this way that there is one single channel StatusChanged used to signal that transaction state has changed. Every other goroutine that wishes to wait for transaction state, has to subscribe to this channel and then check if state matches what it expects.
There is multiple channels. Every one represents entering mentioned before state.

@tarelda anything I can help with? Shall we close this PR for time being or is this something you would like to get merged?

@tarelda anything I can help with? Shall we close this PR for time being or is this something you would like to get merged?

I am working on it in the meantime. I had issue finding more free time to work on this lately, so it is not finished yet.

@andig I am sorry that it goes so slow, but I am very busy lately.
What I did so far beside making more bugs:

Transaction state is strictly tracked and enforced.
I temporarily split codebase into multiple files to have easier time working out quirks.
Reworked most of the updates etc

What I am working on to resolve:

Strict state enforcement causes inability of evcc to stop transaction that wasn't started by it. Unforunately main control process can handle it so as at least temporary workaround I will spawn some kind of controlling goroutine to do the cleanup.
I noticed that my charger has issue with disconnecting due to lack of hearbeats. I think I will spawn watchdog to request hearbeats when there is no communication for extended period of time. AFAIR exact procedure is mentioned somewhere in the OCPP spec.

Transaction state is strictly tracked and enforced.

You mean the ability to distinguish state B and C? Or transaction yes/no? I thought we can to the latter already. For the former- which logic do you apply?

Strict state enforcement causes inability of evcc to stop transaction that wasn't started by it.

I don't think we can do that today. Is Ocpp even able to detect a running transaction when the CS starts?

so as at least temporary workaround I will spawn some kind of controlling goroutine to do the cleanup.

If you could explain which changes to the logic are necessary then I can help with the implementation.

This is uber ugly implementation, but it does the job.

Transactions that are not started with Enable(True) are all stopped.
Charger can only be enabled where there is no concurrent transaction.
Charger can't be enabled where it is in Available, Faulted, Unavailable state.
Failed enable is properly cleaned up.

Unlock connector in EV.
Disconnect EV.

I'd suggest to close this PR and open a discussion instead for what functional changes are are needed to better support different chargers. The implementation/PR ist only the last step.
Happy to reopen any time when we have more understanding of what we need to change.

@andig This is not charger specific support. This PR came to life because you closed #5055 and work on this PR found yet another related issue https://github.com/evcc-io/evcc/pull/5130#issuecomment-1331023127 - EVCC tries to enable disabled charger in api.StatusA.

This is not charger specific support.

I understand that. What I don't understand is what this PR is trying to achieve.

If you could explain which changes to the logic are necessary then I can help with the implementation.

Maybe its easier to understand if you open one PR per issue you see. As-is there's nothing I can contribute.

@tarelda Did you make progress? Anything I could do to improve ocpp integration? Seems we're still not at the level we need: https://github.com/evcc-io/evcc/discussions/3806#discussioncomment-4748884

@andig I use 16d3877 on my personal system. It's ugly, but it does the job, but I don't have time up to April to commit more time into it.
Regarding #3806, I think issue lies in lack of testing. Sidenote, I don't think there will be any major progress without ability to do full packet communication debug dumps.

@tarelda thank you for the update. Tried request better logging once more: https://github.com/lorenzodonini/ocpp-go/issues/150#issuecomment-1416418360

@tarelda OCPP logging is now merged as of https://github.com/evcc-io/evcc/pull/6443. Hope this helps!


segmentation fault after train a few steps

segmentation fault appears after train a few steps when batch size >16, everything is ok when batch size <= 16.
same issue exist when using dp training.
I use faulthander to track core dump happen in which step, then the logs shows that as follows:
Current thread 0x00007fba40fe94c0 (most recent call first):
File "xx/TTS/monotonic_align/init.py", line 40 in maximum_path
File "xx/TTS//models/models.py", line 822 in forward
File "xx/miniconda3/envs/pytorch2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501 in _call_impl
File "train_multilang_speaker_1gpu.py", line 175 in train_and_evaluate
File "train_multilang_speaker_1gpu.py", line 142 in run
File "train_multilang_speaker_1gpu.py", line 50 in main
File "train_multilang_speaker_1gpu.py", line 407 in
It seems related to monotonic_align, did anyone can help to solve it?
Thanks.

@zhufeijuanjuan did you solve the problem?
I've encounter the same problem

@zhufeijuanjuan did you solve the problem? I've encountered the same problem

Not handled yet. Decrease batch size can avoid this issue.

Maybe problem with mp.spawn or pytorch installation
I've created new environment with python3.11, pytorch2, because python3.10 has many sigsegv problems in pytorch repository. Then changed this line with
  children = []
  for i in range(n_gpus):
      subproc = mp.Process(target=run, args=(i, n_gpus, hps))
      children.append(subproc)
      subproc.start()

  for i in range(n_gpus):
      children[i].join()

And now there's no errors

Also found with python -X faulthandler that there is error in cython monotonic_align. I just rewrite that in numba. It's slightly slower, but works without error

@elch10 Respect!!!
so you mean update python, pytorch and rewrite monotonic_align can solve this issue?

Yeah, of course, no errors


Node.move_child places at wrong position

extends Control

func _ready():

    var c0 = Control.new()
    c0.set_name("Control0")
    add_child(c0)

    var c1 = Control.new()
    c1.set_name("Control1")
    add_child(c1)

    var c2 = Control.new()
    c2.set_name("Control2")
    add_child(c2)

    var c3 = Control.new()
    c3.set_name("Control3")
    add_child(c3)

func _process(delta):
    set_process(false)
    move_child($Control3,$Control0.get_position_in_parent()+1)
    move_child($Control3,$Control1.get_position_in_parent()+1)#this line is moving Control3 to the last pos but it should be after Control1

    for n in get_children():#This also print wrong order remove line 22 and see
        print(n.get_position_in_parent())

As a workaround I use this
remove_child(c3)
_add_child_below_node($Control1,c3)

Can we rename _add_child_below_node to add_child_below_node ?

Please don't forget to mention your Godot version, I don't want to have to infer it from the usage of $Control3 in your code snippet... There's a reason why we have an issue template.

I don't think there is a bug in the first place.
Your _ready gives the following:
pos 0: Control0
pos 1: Control1
pos 2: Control2
pos 3: Control3

Then the first move_child evaluates to move_child($Control3, 0 + 1), so:
pos 0: Control0
pos 1: Control3
pos 2: Control1
pos 3: Control2

And the second move_child evaluates to move_child($Control3, 2 + 1) (yes, you moved $Control1 too by inserting a node before it :)):
pos 0: Control0
pos 1: Control1
pos 2: Control2
pos 3: Control3

So all good, the bug is in your logic.

Can we rename _add_child_below_node to add_child_below_node ?

Sounds good. I'll edit the issue for that.

Is _add_child_below_node even exposed to GDScript?

It seems to be, for UndoRedo to function I guess.
$ grep -rI _add_child_below_node

editor/scene_tree_dock.cpp:
editor_data->get_undo_redo().add_do_method(parent, "_add_child_below_node", node, dup);

scene/main/node.cpp:
ClassDB::bind_method(D_METHOD("_add_child_below_node", ...

Yes, but methods that begin with underscore are not exposed to GDScript/documentation unless they are virtual. @reduz maybe we should have a warning in debug builds when someone tries to call these?

Taking a look

@saltares seems like you forgot to make a PR?


typos in scripts not throwing error in scheduler

Found out through extensive trial and error that -Command scripting MUST start with '.' or exit codes do not propagate up to task scheduler.
 It seems like a useful tip, easy to miss in the samples given. I missed and got null back.

The test is hard: Put a "try {" in the header and a "}catch{" in the footer. Which seems bizarre.

Under construction: D:\qt_projects\filmcab\simplified\tests\test_return_error_code_on_sql_error.ps1
Need this in ONE place, in footer. All the different errors we'll see!

Working.


Feature Request: Use ExtensionContext.storagePath for symbol cache

I'm not a big fan of having internal, developer environment specific files being stored in my repo/workspace. While it's easy enough to put .vscode_cobol into the ignore files, it would be nicer to use the space vscode already reserves for extensions to write private state via ExtensionContext.storagePath.
I know we previously tried and didn't like Memento, but maybe ExtensionContext.workspaceState can provide some support for routing the the right storage location.
Maybe it's easier to have it in the repo to quickly delete things, so maybe hide this in a config option.

This would be a major change of scope.  It would mean everything would be visible to everything.
While also causing clashes in cache, as each program is scoped to the workspace.
In effect you could only have one version of a program per extension install.
Sorry it just doesn't work... Plus people the directory into SVN/git.
My long term plans are to move the encoded/compressed JSON files into one sqlite dB.
With one table per program.. but this just an idea.

I'm not so sure about the change in scope. The storagePath is unique to the workspace folder, so it's essentially the same thing as the location you put .vscode_cobol today. This is exactly how the c++ extension works: https://github.com/microsoft/vscode-cpptools/blob/e17ff5e93ef4061472328d4afff86d152e5fcb03/Extension/src/LanguageServer/client.ts#L731-L746

It still does help people place it svn/git along side the source.

I understand some of the value of storing it in the repo, if the file format is stable from version to version. However, I still stand by there being a config option for this preference as it introduces a possible environment specific place for bugs in the cache. I have to explain to team members to try clearing/recommitting the cache when things don't appear to be working.

How would you delete it if it was hidden in this store?

Either

Share the platform and user specific location for the user to manually delete (Ex: ~/.config/Code/User/workspaceStorage/003a9bf85795627b1e3e1b582a807e5c/bitlang.vscode_cobol/
Expose the delete/clear cache command you used to have in the extension

This is akin to the debate about things like committing the node_modules folder. Besides, don't the cache files have things like platform specific paths in them? Doesn't that make them less portable between developers and platforms?

If you set "coboleditor.cache_directory_strategy" to "storagepath" then it will use the storage path area.
The default is "workspace" but you can set in the user settngs etc..

Thanks for the option to adjust the storage path with 639ceb985fec7f864c981a850a79871fb18805c8 and to delete the cache via extension command in a0e3e6174b71018c04b91c9c3ac44a4e5cf36e23 - along with all the changes you've done to the caching!


Can't remove annotation done by other user when logged in as admin

I attached a normal user to a project and added an annotation which I then cannot seem to remove as admin (it was not yet clicked as approved)
See attached for console log showing the error

Should the admin user not be able to do this?

I have the same issue

I have the same issue

Same Here


Update sqerl to latest version to address increased transaction rate

Recent changes to sqerl resulted in users seeing double their previous
transaction rate.  This was caused by a SET statement_time command
being sent before every query.  The newest version of sqerl only sends
the command on startup.
ChangeLog-Entry: Eliminate unnecessary postgresql transactions caused
by new version of sqerl.

:+1:


iOS 14 beta note added

Related to #4

Thank you!

Exposure Notifications support added in iOS 14 Dev Beta 4.


VERY USELESS THINGS

I moved this from here: https://github.com/MicrosoftDocs/visualstudio-docs.it-it/issues/16
The comments below were machine-translated
@enzonoseda commented 12 hours ago
In so many years of programming, I have always wondered what these bogus examples of "how to make a program" useless because "console" applications are useless. Unnecessary because in this way people who would like to learn something do not learn anything and are rather distanced from the art of programming.
If you want to do TRAINING on programming, create a simple WINDOWS project that manages a small database (for example "geometric figures") that allows you to calculate and draw the essential elements such as a triangle, to calculate the area, sides, angles, bisector, perimeter etc. and then allow you to print a page and save it as a PDF as well as allowing you to save the image. In short, a REAL complete PROGRAM that allows you to understand all aspects of programming.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc5022ad-0de6-a16f-3f79-394f57f78903
Version Independent ID: ecc54693-3334-34f6-ff75-0a0413be4bec
Content: Create your first console app with Visual Basic - Visual Studio
Content Source: docs/ide/quickstart-visual-basic-console.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @ornellaalt
Microsoft Alias: ornella

@CeciAc -- Cecilia, thank you for forwarding this issue.  Please convey the following to @enzonoseda (machine-translated):
@enzonoseda, grazie per il suo suggerimento dettagliato. Per aggiungere questo, utilizzare l'opzione "Suggerisci una funzionalità" nella Visual Studio Developer Community. Saremmo felici di averlo registrato, dove gli altri possono vederlo e votarlo. Per altre informazioni su questo problema funziona nella community di sviluppatori, vedere la pagina Suggerisci una funzionalità.
cc @ornellaalt for awareness


VS Code: JavaScript heap out of memory

Hi,
I have installed the latest version 1.0.1.
After installation, I open the stimulus controller and then the associated HTML.erb view of that controller. After a minute it the StimulusLSP server crash and gives below log in the output panel.
I have tried to increase the export NODE_OPTIONS="--max-old-space-size=5120", still it crash. I do have lot of Javascript files (legacy code with JQuery etc.) . Assuming it is parsing them all, can we set the specific folder(s) like javascript/controllers/ for StimulusLSP extension?
Here is the log from Output Panel:
<--- Last few GCs --->
[187504:0x2390002fc000]    83267 ms: Scavenge (reduce) 3935.0 (4064.7) -> 3934.5 (4064.9) MB, 10.87 / 0.00 ms  (average mu = 0.492, current mu = 0.226) allocation failure;
[187504:0x2390002fc000]    84124 ms: Scavenge (reduce) 3935.5 (4065.2) -> 3935.1 (4065.2) MB, 849.67 / 0.00 ms  (average mu = 0.492, current mu = 0.226) allocation failure;
<--- JS stacktrace --->
FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory
[Error - 10:55:51 AM] Server process exited with signal SIGABRT.
[Error - 10:55:51 AM] Server initialization failed.
Message: Pending response rejected since connection got disposed
Code: -32097
[Info  - 10:55:51 AM] Connection to server got closed. Server will restart.
true
[Error - 10:55:51 AM] Stimulus LSP client: couldn't create connection to server.
Message: Pending response rejected since connection got disposed
Code: -32097
[Error - 10:55:51 AM] Restarting server failed
Message: Pending response rejected since connection got disposed
Code: -32097
[Trace - 10:55:51 AM] Sending request 'initialize - (0)'.
Params: {
"processId": 186735,
"clientInfo": {
"name": "Visual Studio Code",
"version": "1.89.1"
},

Hey @shanlalit, thanks for reporting! I guess I have to somehow optimize when and how we analyze source files. I changed this behavior between 0.3.0 and 1.0.0 to be able to more accurately analyze the codebase, but I guess we need to be smarter about it.
Is there any way for you to downgrade to 0.3.0 in the meantime?

Thanks for acknowledging, I switched to 0.3 for now.
On Thu, 16 May, 2024, 5:15 pm Marco Roth, @.***> wrote:

Hey @shanlalit https://github.com/shanlalit, thanks for reporting! I
guess I have to somehow optimize when and how we analyze source files. I
changed this behavior between 0.3.0 and 1.0.0 to be able to more accurately
analyze the codebase, but I guess we need to be smarter about it.
Is there any way for you to downgrade to 0.3.0 in the meantime?
—
Reply to this email directly, view it on GitHub
https://github.com/marcoroth/stimulus-lsp/issues/283#issuecomment-2115009720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABU5YDGYKZJ3UCPZ6B3KLZCSL3ZAVCNFSM6AAAAABHZPGT42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGAYDSNZSGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for confirming, @shanlalit and sorry for the inconvenience!

Having the same issue (downgrading worked fine). We have ~150 controllers in the app

Having the same issue (downgrading worked fine). We have ~150 controllers in the app

Also having this issue

For those using neovim and Mason to install this, you can run :MasonInstall<EMAIL_ADDRESS>to get up and running in the meantime.


Don't trim whitespace-only lines

The only thing holding me back from adopting swift-format is the inability to allow trailing whitespace in whitespace-only lines. This is my favorite Xcode feature!

Can we change PrettyPrinter to keep the surrounding context's indentation for empty lines, or would that be a breaking change? Can we add something that's based on a configuration to PrettyPrinter? I would love to get the ball rolling if someone can point me to the right place to implement this.

Synced to Apple’s issue tracker as rdar://135215957

This is my favorite Xcode feature!

Out of interest, what's your use case for keeping whitespace on blank lines only?

Out of interest, what's your use case for keeping whitespace on blank lines only?

I love being able to arrow down/up or click on empty lines that are already correctly indented. Makes the editing experience feel more "solid" if that makes sense.

My personal feeling on this is that editors that want to provide that functionality should provide a "virtual cursor" where the user can navigate to a location outside the document's horizontal bounds, but only if they start typing there does it insert the spaces. (Naturally, that's out of scope for this project.)
Always inserting spaces to fill up otherwise blank lines just feels wasteful.

Always inserting spaces to fill up otherwise blank lines just feels wasteful.

I completely agree with this opinion.
However, in Xcode, if we turn off the Including whitespace-only lines option and perform automatic indentation (Command + I), it still inserts spaces according to the indent level even on empty lines.
In my opinion, if we would like the formatting to behave exactly like Xcode, it might be better to also insert spaces on empty lines according to the indent level. But if the intention is to reduce unnecessary actions, it may be more appropriate to only adjust lines that have incorrect amounts of whitespace to match the indent level. 🤔

IMO matching Xcode is a non-goal here. If there's general interest, we should definitely consider adding it. The next question there is whether we need both options ("remove trailing whitespace" and "indent blank lines"), or whether just the latter is enough. My preference would be just the latter.

My personal feeling on this is that editors that want to provide that functionality should provide a "virtual cursor"

I feel somewhat similar, though it's entirely possible that someone could be using very lightweight editors without this sort of feature. It would also mean that the editor has to understand how to indent (though maybe that's as simple as "match previous line").


changed fromDate to fromJSDate

Since cql fromDate has been changed to fromJSDate in cql-execution, it must be renamed in bonnie.
Pull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[ ] JIRA ticket for this PR:
[ ] JIRA ticket links to this PR
[ ] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[ ] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass (remember to update Gemfile when applicable)
[ ] Test fixtures updated and documented as necessary ( see internal wiki )
[ ] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

Branch
Back End Coverage
Front End Coverage

master
[Paste Output Here]
[Paste Screenshot Here]

[New Branch]
[Paste Output Here]
[Paste Screenshot Here]

[ ] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA test links:
[ ] Justification for using JIRA tests:
[ ] JIRA tests have been added to sprint

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Looks good. Would just use a gemfile.lock update after getting the cql_qdm_patient api merged.


URL encode in get/delete request

so We can use + in request url

In rest-client, it's the caller's responsibility to encode characters that are invalid within a URI using e.g. URI.escape. Doing this automatically turns out to be a source of lots of hard to find bugs.


click.testing.CliRunner ignoring patched functions using mock.patch

Not sure if this is expected behaviour but I would appreciate some guidance about how to make this work.
I have a command like application that internally does things I don't want it to do while running unit tests. Therefore I'm using mock.patch to replace those implementation details. As the application is composed by commands and subcommands, using click.testing.CliRunner is very useful to us instead of calling the functions directly, specially because of the passed context between commands.
What we realised is that it seems that click.testing.CliRunner is ignoring patched functions using mock.patch. To showcase this behaviour I created the following sample that more or less describes what I'm trying to achieve: Ruenzuo/click_mock_patch.
Specifically this is the test that fails:
def test_app_should_not_raise(self):
        with patch('helpers.helper.do_something_useful', return_value = None):
            self.runner.invoke(entry_point, ['--opt1', 'Hi', '--opt2', 'You', 'cmd'], None, None, False)

The patch is working fine, if I debug the tests, inside the with patch context, the do_something_useful function returns None instead of raising (it's original implementation).

This had nothing to do with click, it was just my lack of understanding of "where to patch". Updated code works.


New information to readme file

Add best case of time complexity of any search to readme file

Add best case time complexity to any search


Scroll into view dynamically added and selected option

If you add options to a select with js and change it's value, selected item won't scroll into view at first. Please take a look at the fiddle:
http://jsfiddle.net/0e38edu8/
Clicking on select, selected item won't scroll into view, unless you close and reopen it. Any workaround for this?
HTML
<select id="mySelect"></select>

JS
for (var i = 0; i < 100; i++) {
    $('#mySelect').append($('<option>', {
        value: i,
        text: i
    }));
};
$("#mySelect").select2({width: 100});
$("#mySelect").val("95").trigger("change");

Please, send us a JSFiddle example code simulating this scenario (with runnable code and steps described there, to allow us to follow this steps and check the situation). It is much more easy to understand and help to provide some solution or workaround. You are free to reopen when the JSFiddle are done.


Discussion: Scope of wmi_exporter

Background
With the contribution of #320, we need to make a decision on what scope we want the wmi_exporter to have.
Up until now, we've exclusively provided metrics extracted from WMI, and avoided adding other potentially useful metrics or gathering methods as out-of-scope.
This has allowed us a clear focus and way-of-working, and high similarity between different collectors leading to ease of contributing new ones.
On the down side, WMI isn't exactly easy to work with, has a non-trivial impact on host performance and we've seen a wide variety of weird bugs where the user needs to repair registry configurations or similar.
Alternatives
As I see it, we have two choices:

Stay with exposing only data gathered through WMI. This means turning down #320 and similar proposals, and suggesting they be separate, dedicated exporters instead.
Become a generic "Windows exporter", taking in anything useful, through any interface available.

On the Linux side, the Prometheus ecosystem strongly leans towards alternative 1, with hundreds of specific exporters, and individual machines often running several ones.
Way forward
We don't have any formal decision-making process for wmi_exporter at this time, so I would like to gather input both from maintainers and users on this topic before we come to some conclusion. I'll add my personal thoughts as a comment below.

I'm undecided as of yet, and looking forward to hearing others' thoughts.
On one side (and probably coloured by the majority of my systems being Linux-based) I personally prefer having small, well-defined exporters and deploying them where relevant (alternative 1). There is typically less configuration per exporter (or none at all), the code tends to be simpler, and bugs/crashes in a single exporter have a smaller impact on overall monitoring.
On the other hand, we've seen that a lot of our users typically don't have a configuration management system at all, and having to deploy multiple exporters could possibly lead to not being able to use Prometheus at all.
Additionally, there seems to be relatively few developers in the Windows/Prometheus intersection. Would we be able to sustain multiple projects?
cc: @martinlindhe @brian-brazil

An additional thing to consider is that a "Windows exporter" nominally includes every possible application that runs on Windows, so you'd end up as an uberagent.

Hi i'm new to the prometheus, and even Go, i just came here for some windows metrics :)
But i'd like to tune in as a user if I may.
This was the most relevant exporter when i searched for a "windows exporter". WMI/CIM is highly generic, so one could argue that this exporter already is a "generic Windows exporter".
Adding export features that has a significantly other lifecycle than windows can be hard to maintain, which is why i was suprised to see MSSQL / Vmware support - even through WMI. - So uberagenting will most likely have a negative impact on the exporter as a whole.
I would prefer focus on roles/features that are lifecycle bound to windows (DNS / AD / and so on), and keep to apis that are updated with windows . WMI / HCS / etc

That's kinda like saying that the JMX exporter should monitoring all JVM-based applications, rather than sticking to just JMX. Just like with WMI, the JMX exporter allows you to access anything you can via JMX.

Fork the project.
Wmi exporter and a generalised Windows exporter, there is a lot of potential to be had here which will only increase the popularity of Prometheus.

@VR6Pete I'm not sure I follow? You mean splitting it into "two" (or more), or abandoning the current?
As I mentioned, on of the things that worry me is that I'm not sure there is a sufficient developer base to spread resources thinner. So for that reason, there might be cause to try to keep things together.
On the other hand, the "uberagent" approach, if we drop the WMI requirement, will have quite the risk to become unmaintainable anyway due to technology sprawl.

@lars-nielsen Thanks for the feedback!

I would prefer focus on roles/features that are lifecycle bound to windows (DNS / AD / and so on), and keep to apis that are updated with windows . WMI / HCS / etc

This is another possible angle. As you note, we currently accept anything that registers a WMI provider. Another way would be to focus on the OS roles/features, regardless of the way they expose their stats.

As a user on Windows I prefer having one exporter for everything which is "service-level", e.g. not specifically application metrics.
However, I think that metrics which are available via performance counters should rather be collected via those since I believe that these have less overhead and they don't suffer from the 16-minute-lockup and similar WMI issues.
As for future development, I think that having some configuration language for the collector which allows to define any WMI and perfmon metrics to expose would be great and pretty future-proof.

@avonwyss Yes, those WMI issues are part of the background here. Not just the lock-ups, but also scrapes getting data smeared out over a long period, as well as the occasional "Invalid class/query".

Having hard requirement of WMI is not good as we know that WMI calls are expensive. If feasible we can re implement some of the common collectors to use perf counters instead of WMI and can go away with hard WMI requirement.
and in my opinion having single exporters for all the collectors is good compared to having multiple small exporters as all the collectors are optional and they are as good as having multiple exporters in single repository.

I think it'd be very helpful for the Windows community (users, customers, developers, partners) to have a single exporter for all OS level metrics that include system, hyper-v, and containers.

This software came to be and got its rather uninspiring name just from the need to export some Windows metrics to Prometheus. At the time I looked around on what was available and was not yet aware of the performance and stability issues of WMI that we've seen since.
For the usefulness of the project I think we should maybe not draw a hard line at WMI. Maybe "os level metrics" or something could be a better stated goal.
However, we need to stay focused and not bolt just anything on.
I don't think forking is a good way forward as dev resources are already spread thin.
For example https://github.com/leoluk/perflib_exporter should maybe have become part of our exporter rather than a separate thing.

Expressed above is my personal opinions here. As I'm not much involved in the project atm, I don't think my words should have more weight here, and I am happy with decisions made by @carlpett and @brian-brazil

It's not my project, I just chime in every now and then :)

So, activity seems to have tapered off here, so it seems we can reasonably now summarize the concerns raised and opinions:

Most comments seem to favour a third option, somewhere between the two ones initially posted: Stop being WMI-exclusive, but restrict the scope to only be "OS components". This should then provide a guideline for what new functionality to accept and what falls outside. Pure application metrics, for example, would not qualify, while Windows Server roles would.
This would mean green light for the container metrics contributed in #320, as well as looking into how we can start utilizing performance counters and other similar alternatives to address our WMI issues (such as #270, #259, #89 etc).

Let me know if you feel the above does not accurately represent a summarization of the comments (by necessity it does not align with all comments, but I have tried to create a full picture). If there is no major disagreement at the end of the week, this would be our new scope going forward.

Well, that seems to settle it :smile:


Support for commas in numbers?

I'm not a JS expert, but when I try to use data-to="25,000" as a data attribute I get a value of 'NAN' which makes sense. Curious how I could get commas in there?

https://github.com/mhuggins/jquery-countTo/issues/36
https://github.com/mhuggins/jquery-countTo/issues/31
https://github.com/mhuggins/jquery-countTo/issues/20
https://github.com/mhuggins/jquery-countTo/issues/19
https://github.com/mhuggins/jquery-countTo/issues/2

Whoops, sorry!


Meshes with multiple texture maps fail to load properly w/ WebGL backend

Describe the bug
Meshes that have multiple texture maps do not load correctly with WebGL backend. It appears that only one of the texture files is loaded, and the other ones are discarded. This manifests as having many triangles appear black:

The issue only appears to affect WebGL as the OpenGL android backend is fine. We have not tested Metal backend for this issue.
To Reproduce
Load a mesh with multiple texture files into a filament web viewer and observer. Here is an example
rv.glb.zip
Expected behavior
Expected all texture maps to be properly loaded
Screenshots
You can test out the problem live here. Here is the mesh loaded with ThreeJS
https://poly.cam/capture/FF23A840-11F2-4768-8EDF-C103A301DBC9
And here it is loaded with filament:
https://poly.cam/polykit/FF23A840-11F2-4768-8EDF-C103A301DBC9
This mesh's texture is split up into 2 texture maps:

df0e-ef47-494b-a6ec-8e4b3c146524.png">
Logs
If applicable, copy logs from your console here. Please do not
use screenshots of logs, copy them as text.
Desktop (please complete the following information):

OS: All tested
GPU: All tested
Backend: WebGL

Additional context
Add any other context about the problem here.

It works fine in our instance of the viewer at google.github.io/filament:

Maybe there's something different about how you setup the viewer?
@prideout Any idea? Hard to debug since it's fine on our end.

It works fine in our instance of the viewer at google.github.io/filament:

Maybe there's something different about how you setup the viewer?
@prideout Any idea? Hard to debug since it's fine on our end.

Thanks for checking this out and clarifying @romainguy , that narrows things down for us quite a bit! @prideout if you do have any suggestions for where we should look on our end please let us know! We'll try to track down the issue on our side and will update the ticket.
Unrelated to this issue, I'd like to an offer a suggestion to make the default color grading linear. We were struggling to identify why the render quality of our meshes always looked worse in filament than in threejs but it turns out that making this small change improved rendering quality of meshes substantially. Maybe you are already aware, just fyi.

Thanks again for the ongoing development work!!

I strongly disagree with making linear the default tone mapping and I would argue against using the term "rendering quality" here. The problem is whether the meshes have been authored for linear presentation, whether the used already tone mapped textures, etc. Linear is strictly "worse" for the common use case of Filament (PBR rendering using dynamic lights). Linear only makes sense for unlit subjects and/or photogrammetry.

BTW I would also recommend you don't use ULTRA quality for your use case, especially for linear rendering. ULTRA is only useful if you use non-linear tone mapping and/or color grading features (curves, etc.). You'll save quite a bit of memory and performance sticking with the default setting.

BTW I would also recommend you don't use ULTRA quality for your use case, especially for linear rendering. ULTRA is only useful if you use non-linear tone mapping and/or color grading features (curves, etc.). You'll save quite a bit of memory and performance sticking with the default setting.

Awesome, thanks for the tip!

I strongly disagree with making linear the default tone mapping and I would argue against using the term "rendering quality" here. The problem is whether the meshes have been authored for linear presentation, whether the used already tone mapped textures, etc. Linear is strictly "worse" for the common use case of Filament (PBR rendering using dynamic lights). Linear only makes sense for unlit subjects and/or photogrammetry.

Thanks for clarifying. This was not on our radar because all of our meshes are photogrammetry and/or unlit. Could be a useful suggestion to add to the docs though that linear mapping will work best for photogrammetry scans given that photogrammetry is an increasingly common way of authoring 3D content (will probably be the most common form soon) and it's not-obvious given that other renderers like ThreeJS and SceneKit seem to default to linear

For reference, here's a PBR scene in linear:

And the same scene with a non-linear tone mapper:

Note how the sun is clipped in the first image, and how blue hues in the sky are completely distorted. You also get a "washed out" appearance on the rest of the image.

Greetings @romainguy, I am the Polycam engineer in charge of fixing this issue and work with @cpheinrich. So after a bit of digging and debugging I found out the root of the problem is that we aren't calling filament::gltfio::StbProvider::updateQueue(). This is leading to decodeSingleTexture() only being called once and thus only 1 of the multiple textures is loaded. That also explains why we are only seeing this problem on web as the other platforms do support multithreading and go through different code paths inside filament and use the job system for texture decoding. Below is the revised code for our mesh loading that fixes the problem:
  asset_ = asset_loader_->createAsset(bytes, size);
  auto resource_loader = gltfio::ResourceLoader({.engine = engine_, .normalizeSkinningWeights = true});
  resource_loader.addTextureProvider("image/jpeg", texture_provider_);
  scene_->addEntities(asset_->getEntities(), asset_->getEntityCount());
  while(texture_provider_->getDecodedCount() < texture_provider_->getPushedCount()) {
    texture_provider_->updateQueue();
  }
  asset_->releaseSourceData();

The while loop is new and fixes the problem. Before I commit this code, I'd just like to verify that I am using updateQueue() correctly and my logic is sound. Thanks again for your help!

Hi @omri-polycam Normally I'd expect to see a resourceLoader.asyncBeginLoad() after the resource loader is constructed.  Then, you'd call resourceLoader.asyncUpdateLoad() in loop (or in a timer, if you want to yield to the UI).  By calling updateQueue() on the texture plugin directly, you're bypassing the resource loader layer.
Sounds like you're using emscripten, since you're not using our JavaScript bindings or our Web Component.  That's fine, but they do simplify some of this stuff so you can look at their implementation for inspiration.  For example, here's how our JavaScript bindings do this (you can mentally translate the JS to C++)
https://github.com/google/filament/blob/main/web/filament-js/extensions.js#L554

HI @prideout ! Thanks for the advice. I'll add the initial asyncBeginLoad() and modify the loop to call asyncUpdateLoad() until asyncGetLoadProgress() >= 1.0f.

Thanks a lot for your help @romainguy and @prideout!  Calling out that this was indeed an issue in our implementation of the filament web viewer and not an issue in the filament library. We've got it fixed on end now per the comments above.

Glad you were able to fix it! Don't hesitate if you run into more issues and/or if you have questions.


Web machine small fixes for riak_kv_wm_object

@ThomasArts Is the cost of the maybe_decode_uri in service_available/2 significant?  am I right in thinking if all buckets and keys our plain ascii with no spaces, this could be disabled using the riak_kv, http_url_encoding environment variable - and the cost of this decoding could be avoided (and the header X-Riak-URL-Encoding used for exceptional cases).  Some keys can be quite long (60-100 characters).


Revert "drivers: move eeprom_slave driver to tests directory"

This reverts commit cabbd916cfba20f39a91922b740d914f38a21b2d.
This functionality is considered to be useful enough that it should be restored as a stable Zephyr API.
Closes #30557

Any volunteers to own this thing?  Needs a CODEOWNER entry.  Maybe @brix since it's pretending to be an EEPROM?

@sslupsky please verify this.

Any volunteers to own this thing? Needs a CODEOWNER entry. Maybe @henrikbrixandersen since it's pretending to be an EEPROM?

@pabigot Sure. You can put me as code owner.

@henrikbrixandersen thanks, updated.


Automated cherry pick of #9622

Cherry pick of #9622 on release-6.3.
/cc  @M-ZubairAhmed
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 30efffcff2cc8c91021d0a6404550f439674b3b6


os/network-config-with-networkd: add supported ways to disable IPv6

Document the systemd-approved way to disable IPv6 since the upstream fix for coreos/bugs#1419 was closed.

LGTM!


S3 signature is not calculated correctly

Hi,
I am testing with S3 compatible storage (Minio) and I am experiencing issues where I am getting 403 Forbidden during authentication. Error code is SignatureDoesNotMatch.
I have found 2 causes:

if endpoint contains port other than 80 or 443, the port must be included in the host header
if the path ends with a path separator it must not be url encoded (I verified this issue also with AWS S3)

Best,
Martin

Actually it has not been fixed correctly as I still can't connect to my local minio instance due to incorrect signature

How are you connecting? I've added a factory method for Minio for convenience, it works on my local network with custom port.

I did use the new factory. I am going to investigate tomorrow and if I find the root cause, I will share.

My appologies, I executed my integration tests with incorrect configuration yesterday.
Everything seems to work well now, so I am closing the issue.


A rough idea: an alternative to watchSignal

For fine-grained refreshing control of Flutter widgets, this is a great package 👍
In the Flutter layer, using watchSignal to bind the signal is very clever, but I feel like there might be some room for improvement, for example:
After the first watchSignal, context has been added to _subscribers. Every subsequent watchSignal call will trigger _subscribers.removeWhere, iterating through the map. When there are many watchSignal calls, it might impact performance.
T watchSignal<T>(BuildContext context, ReadonlySignal<T> signal) {
  if (context is Element) {
    ....
    if (!_subscribers.containsKey(key)) {
      ....
    } else {
      // Clear out any garbage collected widgets
      _subscribers.removeWhere((key, value) => value.target == null); // <======
    }
  }
  ....
}

My idea: Create a new widget (Obx or any other name)
class Obx extends StatefulWidget {
  const Obx(this.builder);
  final Widget Function() builder;
  @override
  State<Obx> createState() => _ObxState();
}

class _ObxState extends State<Obx> {

  late Widget child;
  EffectCleanup? fn;

  @override
  void initState() {
    super.initState();
    fn = effect(() {
      child = widget.builder();
      setState(() {});
    });
  }

  @override
  Widget build(BuildContext context) {
    return child;
  }

  @override
  void dispose() {
    fn?.call();
    super.dispose();
  }
}

Usage
Obx(() => Text('${counter.value}')),
// Builder(builder: (context) => Text('${counter.watch(context)}')),

Its advantages include several points:

No need for watchSignal, just wrap an Obx above the required widget.
Obx internally caches the child widget and creates the child before the build phase, reducing time consumption during build.
The child is only rebuilt when necessary.
Performance and memory usage should be better than watchSignal.

It's just a rough idea, and there might be some scenarios not considered.

I kinda ended up at the same place  for my package with a minor difference. Wouldn't calling setState in initState cause 1 unnecessary rebuild? This is what I did (My version of subscribe doesn't fire immediately):
@override
  void initState() {
    final derived = Signal.derived(() => widget.builder());

    child = derived.value;

    unsub = derived.subscribe((value) {
      child = value;
      setState(() {});
    });

    super.initState();
  }

I like this, I think it should be called Watch though for the Widget name.
Then you can use the .watch(context) for mapping values if needed still and simple flows.
But for most things Watch can cover this use case:
https://github.com/rodydavis/signals.dart/discussions/26

Instead of setState I can call markNeedsRebuild if mounted

Ok here is my first draft that works:

/// [Watch] Widget that will rebuild when any single
/// inside the builder changes
class Watch<T extends Widget> extends StatefulWidget {
  const Watch(this.builder, {super.key});

  /// The widget to rebuild when the signal changes
  final T Function() builder;

  @override
  State<Watch<T>> createState() => _WatchState<T>();
}

class _WatchState<T extends Widget> extends State<Watch<T>> {
  late final signal = computed(() => widget.builder());
  late Widget child = signal.value;

  EffectCleanup? fn;

  @override
  void initState() {
    super.initState();
    fn = effect(() {
      child = signal.value;
      if (mounted) {
        (context as Element).markNeedsBuild();
      }
    });
  }

  @override
  void dispose() {
    fn?.call();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return child;
  }
}

Using a computed I can rebuild the widget for the first frame and listen for future ones in the effect.
It honestly makes the example cleaner too:
import 'package:flutter/material.dart';
import 'package:signals/signals_flutter.dart';

final brightness = signal(Brightness.light);

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
          seedColor: Colors.deepPurple,
          brightness: Brightness.light,
        ),
        brightness: Brightness.light,
        useMaterial3: true,
      ),
      darkTheme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
          seedColor: Colors.deepPurple,
          brightness: Brightness.dark,
        ),
        brightness: Brightness.dark,
        useMaterial3: true,
      ),
      themeMode: brightness.watch(context) == Brightness.dark
          ? ThemeMode.dark
          : ThemeMode.light,
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final counter = signal(0);

  void _incrementCounter() {
    counter.value++;
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
        actions: [
          Watch(() {
            final isDark = brightness() == Brightness.dark;
            return IconButton(
              onPressed: () {
                brightness.value = isDark ? Brightness.light : Brightness.dark;
              },
              icon: Icon(isDark ? Icons.light_mode : Icons.dark_mode),
            );
          }),
        ],
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Watch(() {
              return Text(
                '$counter',
                style: Theme.of(context).textTheme.headlineMedium!,
              );
            }),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

If you notice at the top I still need the .watch(context) for MaterialApp. But maybe that could be solved by just wrapping it with Watch.

I created a SignalWidget for cases like that where wrapping becomes unwieldy.So you'd just replace StatelessWidget with SignalWidget:
abstract class SignalWidget extends StatefulWidget {
  const SignalWidget({super.key});

  @override
  State<StatefulWidget> createState() => _SignalStatefulWidgetState();

  @protected
  Widget build(BuildContext context);
}

class _SignalStatefulWidgetState extends State<SignalWidget> {
  @override
  Widget build(BuildContext context) {
    return Watch(() => widget.build(context));
  }
}

Still trying to get it working with FutureSignal, not working the way I want yet

Got it working, I will include the SignalWidget too, although I think it could also be named: SignalWatcher, or WatchWidget

Here is the PR: https://github.com/rodydavis/signals.dart/pull/28

I'll probably come back to it tonight

Oh gotcha, I see the bug now. Working on it!

Solved it with WatchBuilder:
https://github.com/rodydavis/signals.dart/pull/28/files#diff-f317628c56da5a62f8ee2f03dfdd6cf405cb80dfda657dceeccf949fa9695961
Watch is more efficient and can do less rebuilds since it will not check for didChangeDependencies, in addition it does not require the context:
https://github.com/rodydavis/signals.dart/pull/28/files#diff-59f6338dfef6bb1ef2ea6668e1a06000e7b77e9412e2900ecaf74b5727623032
Thinking that both maybe fine to include here. Thoughts?

I don't like putting the responsibility on the user on knowing which one to use. I'm choosing to always require a context in the Watch builder for my pkg. This is what I ended up with:
class _WatchState extends State<Watch> {
  void Function()? unsub;

  @override
  void reassemble() {
    // clear the old effect on hot reload
    unsub?.call();
    super.reassemble();
  }

  @override
  void dispose() {
    unsub?.call();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    late Widget child;
    unsub?.call();
    unsub = Signal.createEffect(() {
      child = widget.builder(context);
      if (mounted) setState(() {});
    });
    return child;
  }
}

I don't like putting the responsibility on the user on knowing which one to use. I'm choosing to always require a context in the Watch builder for my pkg. This is what I ended up with:
class _WatchState extends State<Watch> {
  void Function()? unsub;
  late Widget child;

  @override
  void reassemble() {
    // clear the old effect on hot reload
    unsub?.call();
    super.reassemble();
  }

  @override
  void dispose() {
    unsub?.call();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {

    unsub?.call();
    unsub = Signal.createEffect(() {
      child = widget.builder(context);
      if (mounted) setState(() {});
    });
    return child;
  }}

Caching the child idea is a bit risky and quite challenging to do correctly. There are some issues here; we've already addressed the didChangeddependencies problem, but there might be other data dependencies within the builder() function that aren't of type Signal, and they also need refreshing upon changes. However, due to caching, this situation might pose a problem.
Stepping back, without caching the child, directly invoking widget.builder() each time during build won't pose issues. All we need to do is setState after detecting a change in the signal.

directly invoking widget.builder() each time during build won't pose issues. All we need to do is setState after detecting a change in the signal.

I think my solution above does this. The child is reassigned every time build is ran as the effect is synchronous and runs immediately.

This is what I am thinking based on the comments:
import 'package:flutter/material.dart';

import '../signals.dart';

/// [Watch] is a drop-in replacement for [Builder] that will rebuild
/// when any signals inside the builder change
class Watch<T extends Widget> extends StatefulWidget {
  const Watch(this.builder, {super.key});

  /// The widget to rebuild when any signals change
  final T Function(BuildContext context) builder;

  @override
  State<Watch<T>> createState() => _WatchState<T>();
}

class _WatchState<T extends Widget> extends State<Watch<T>> {
  late Widget child;
  EffectCleanup? fn;
  bool _initialized = false;

  void init() {
    fn?.call();
    fn = effect(() {
      child = widget.builder(context);
      if (mounted) {
        (context as Element).markNeedsBuild();
      }
    });
  }

  @override
  void reassemble() {
    super.reassemble();
    init();
  }

  @override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addPostFrameCallback((_) {
      init();
      _initialized = true;
    });
  }

  @override
  void dispose() {
    fn?.call();
    super.dispose();
  }

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    child = widget.builder(context);
    if (mounted) {
      (context as Element).markNeedsBuild();
    }
  }

  @override
  Widget build(BuildContext context) {
    if (!_initialized) {
      return widget.builder(context);
    } else {
      return child;
    }
  }
}

It will rebuild on theme and other builder changes, and update every time the signals in the builder change.

Also removed WatchBuilder in favor of just Watch

Thinking about deprecating context.watch in favor of Watch but i still think it has value

This is a little cleaner:
import 'package:flutter/material.dart';

import '../signals.dart';

/// [Watch] is a drop-in replacement for [Builder] that will rebuild
/// when any signals inside the builder change
class Watch<T extends Widget> extends StatefulWidget {
  const Watch(this.builder, {super.key});

  /// The widget to rebuild when any signals change
  final T Function(BuildContext context) builder;

  @override
  State<Watch<T>> createState() => _WatchState<T>();
}

class _WatchState<T extends Widget> extends State<Watch<T>> {
  Widget? child;
  EffectCleanup? fn;

  @override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addPostFrameCallback((_) => init());
  }

  @override
  void reassemble() {
    super.reassemble();
    init();
  }

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    rebuild();
  }

  @override
  void dispose() {
    fn?.call();
    super.dispose();
  }

  void init() {
    fn?.call();
    fn = effect(rebuild);
  }

  void rebuild() {
    final result = widget.builder(context);
    if (result == child) return;
    child = result;
    if (mounted) {
      (context as Element).markNeedsBuild();
    }
  }

  @override
  Widget build(BuildContext context) {
    if (child == null) {
      return widget.builder(context);
    } else {
      return child!;
    }
  }
}

Just a note for future reference, when accessing an inherited widget will cause a lot of rebuilds and it's not the signal or effect causing it:
https://github.com/flutter/flutter/issues/89127


Error while testing alert

PS E:\ELK\elastalert2-master> elastalert-test-rule examples/rules/example_frequency.yaml
Traceback (most recent call last):
File "C:\Program Files\Python310\Scripts\elastalert-test-rule-script.py", line 33, in
sys.exit(load_entry_point('elastalert2==2.3.0', 'console_scripts', 'elastalert-test-rule')())
File "C:\Program Files\Python310\Scripts\elastalert-test-rule-script.py", line 25, in importlib_load_entry_point
return next(matches).load()
File "C:\Program Files\Python310\lib\importlib\metadata_init_.py", line 162, in load
module = import_module(match.group('module'))
File "C:\Program Files\Python310\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\test_rule.py", line 15, in
from elastalert.config import load_conf
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\config.py", line 9, in
from . import loaders
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\loaders.py", line 16, in
from . import ruletypes
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\ruletypes.py", line 6, in
from blist import sortedlist
ImportError: cannot import name 'sortedlist' from 'blist' (C:\Program Files\Python310\lib\site-packages\blist_init.py)
PS E:\ELK\elastalert2-master>

Please do not post errors related to Yelp's ElastAlert project. This project is for ElastAlert 2 only.

I got this error using alert2, as mention in first time user guide

You are still using the old elastalert. This is clear from several of the error lines you pasted:
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\ruletypes.py", line 6, in
from blist import sortedlist

Please review the project guidelines as mentioned in #11.

I uninstalled and installed python and removed old elastic alert, I will
try to clear out everything again and check again tomorrow. Thanks will
confirm
Thanks,
Amal
On Thu, Mar 3, 2022, 20:14 Jason Ertel @.***> wrote:

You are still using the old elastalert. This is clear from several of the
error lines you pasted:
File "C:\Program Files\Python310\lib\site-packages\elastalert-0.2.4-py3.10.egg\elastalert\ruletypes.py", line 6, in
from blist import sortedlist
Please review the project guidelines as mentioned in #11
https://github.com/jertel/elastalert2/discussions/11.
—
Reply to this email directly, view it on GitHub
https://github.com/jertel/elastalert2/issues/753#issuecomment-1058727878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVVDTXQG3AHBN4U5DLQU7LU6FPVVANCNFSM5P3NTX5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

i tried removing that package and clone the current git and i am getting and error with python elastalert/elastalert.py
PS E:\ELK\elastalert2-master> python elastalert/elastalert.py
Traceback (most recent call last):
File "E:\ELK\elastalert2-master\elastalert\elastalert.py", line 32, in
from elastalert.alerters.debug import DebugAlerter
File "E:\ELK\elastalert2-master\elastalert\elastalert.py", line 32, in
from elastalert.alerters.debug import DebugAlerter
ModuleNotFoundError: No module named 'elastalert.alerters'; 'elastalert' is not a package
PS E:\ELK\elastalert2-master>

There are two supported methods of running ElastAlert 2, documented here

Use the official Docker container
Use the official Python pip package.

You mentioned using git to clone the repo with the ElastAlert 2 source code. This is not recommended, but it can be done, provided you are experienced with Python development.

thank that helped, i am getting an error  ERROR:elastalert:Uncaught
exception running rule Example frequency rule: (501, b'5.1.7 Invalid
address', 'ElastAlert')
PS E:\ELK\elastalert2-master> python -m elastalert.elastalert --config
E:\ELK\elastalert2-master\examples\config.yaml --verbose --rule
example_frequency.yaml
INFO:elastalert:1 rules loaded
INFO:elastalert:Starting up
INFO:elastalert:Disabled rules are: []
INFO:elastalert:Sleeping for 60.0 seconds
INFO:elastalert:Queried rule Example frequency rule from 2022-03-10 15:28
Eastern Standard Time to 2022-03-10 15:43 Eastern Standard Time: 270 / 270
hits
INFO:elastalert:Queried rule Example frequency rule from 2022-03-10 15:43
Eastern Standard Time to 2022-03-10 15:51 Eastern Standard Time: 141 / 141
hits
ERROR:elastalert:Traceback (most recent call last):
File "E:\ELK\elastalert2-master\elastalert\elastalert.py", line 1298, in
alert
return self.send_alert(matches, rule, alert_time=alert_time,
retried=retried)
File "E:\ELK\elastalert2-master\elastalert\elastalert.py", line 1375, in
send_alert
alert.alert(matches)
File "E:\ELK\elastalert2-master\elastalert\alerters\email.py", line 115,
in alert
self.smtp.sendmail(self.from_addr, to_addr, email_msg.as_string())
File "C:\Program Files\Python310\lib\smtplib.py", line 887, in sendmail
raise SMTPSenderRefused(code, resp, from_addr)
smtplib.SMTPSenderRefused: (501, b'5.1.7 Invalid address', 'ElastAlert')
ERROR:elastalert:Uncaught exception running rule Example frequency rule:
(501, b'5.1.7 Invalid address', 'ElastAlert')
=================================================================================
(Required)
A list of Elasticsearch filters used for find events
These filters are joined with AND and nested in a filtered query
For more info:
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl.html
filter:

term:
monitor.status: "down"

(Required)
The alert is use when a match is found
alert:

"email"

(required, email specific)
a list of email addresses to send alerts to
smtp_host: "smtp-relay.courts.phila.gov
http://smtp-relay.courts.phila.gov"smtp_port: 25email:
@.** @.**>"
Regards,
Amal
On Thu, 10 Mar 2022 at 14:11, Jason Ertel @.***> wrote:

There are two supported methods of running ElastAlert 2, documented here
https://elastalert2.readthedocs.io/en/latest/running_elastalert.html

Use the official Docker container
Use the official Python pip package.

You mentioned using git to clone the repo with the ElastAlert 2 source
code. This is not recommended, but it can be done, provided you are
experienced with Python development.
—
Reply to this email directly, view it on GitHub
https://github.com/jertel/elastalert2/issues/753#issuecomment-1064400573,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVVDTX7KUGYJQXGMQZQUJDU7JCOBANCNFSM5P3NTX5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


[WFLY-9589] Upgrade JBossXACML to 2.0.10

PR for https://issues.jboss.org/browse/WFLY-9589.
Upgraded JBossXACML to 2.0.10.Final.

Guys,
Can anyone please check and verify this PR ?

This is ok to test

This artifact does not exist. Did you forget to release it in nexus?

@deesharm Our testsuite runs fail to find the artifact, have you remembered to deploy it?

Hi @stuartwdouglas , @kabir,
I checked this again, and it seems that the artifact is missing. I think there were some issues with the build, the first time i checked. My Bad!
So, better we can close this PR, and i will open a new PR when we have the artifact available.
I am closing this PR.


Clean up LayerManager

Before
├─ initialize layers - composite: 5.77 iterations/s ±8.85%
├─ update layers - composite: 15.3 iterations/s ±2.17%
After
├─ initialize layers - composite: 6.17 iterations/s ±11.48%
├─ update layers - composite: 17.8 iterations/s ±3.00%
Change List

Use flat arguments in recursive private methods
Avoid unnecessary small object/string creation in loops
Fix an issue where layer finalization is blocked by error

Coverage increased (+0.03%) to 83.111% when pulling 5cb03cce44a9d9f309f18fcb215681712704263f on x/layer-manager-perf into 742cff9b1e82429c0da7f4d8f923bc9d19a8fb89 on master.


No errno support

As near as I can see, there's no support for the use_errno (or use_last_error
for that matter) parameters.  It seems like a simple command line switch could
add this in pretty easily, unless I'm missing some good reason not to.

If no one's got time to work on it, I could probably write the patch myself,
but I wouldn't want to start doing so if there's a specific reason to not
include it.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 31 May 2013 at 12:23

I have no idea what the original poster is describing, and the OP isn't connected to this report when it got moved to GitHub.


Reverse Integer Problem Solution in leetcode

What does this PR do?
It is the soultion of Reverse Integer problem in leetcode
How can this be manually tested?
copy the code and run it

@Mithileshmishra Codes are not relevant to the repo! Plus do not spam in same repo! Your last PR was also reverted! Keep in mind about the contents of the project , instead of code if you have any book, documents, ppt, or learning tutorial links add those


plain-craft-launcher: Add version 2.7.1

Plain craft launcher is a popular Minecraft launcher.

[x] I have read the Contributing Guide.

Guess this belongs to games bucket:
https://github.com/Calinou/scoop-games.


otAddUnicastAddress Doesn't Hold onto External Pointers

This updates the otAddUnicastAddress and otRemoveUnicastAddress functions so that clients of OpenThread don't have to try to manage the lifetime of the memory for as long as OpenThread has a reference.
The Netif class now maintains a list of externally set unicast addresses, the size of which is defined by OPENTHREAD_CONFIG_MAX_EXT_IP_ADDRS.
Tested with the ot-cli tool.

I ran afoul of the existing behavior when I was first implementing the NCP code, and we ended up discussing it a bit back then. The justification for the existing design was that it left it up to the client how much memory to dedicate to the IPv6 addresses.  We also had some vague notion that it could, by leaving it up to the client, allow the NCP code to be able to send independent INSERTED and REMOVED messages. It turns out it wasn't very helpful.
Thinking about it again, I think we would likely be better off with the approach you are using here. The benefits of the previous method are slim and most engineers would expect this API to behave like you are making it behave.
So, ultimately, 👍 .
But I'd like to get #364 merged into master first and then rebase this change against that. #364 enables the unit tests to be run against the NCP code. If this code passes with those unit tests, then I think we will be good.

LGTM :+1:

LGTM 👍


Add SimpleDate to METADATA.jl

It would be great if you could send a pull request to METADATA.jl.
I'm writing a TOML parser, and would like to rely on it.
Thanks for your work!

Going through my issues backlog, closing old stuff...


Password reset email not sending

I’m using the default endpoint ‘/rest-auth/password/reset/‘ and posting an email address. But the email never sends, and no error is given in the console or else ware.
It even says “password reset email sent”. I have already determined that it’s not an email backend issue because when I sign up for an account, an email is sent

I'm having the same issue

The weird thing is that it was working when I first set it up...I’ll create a new project from scratch and let you know @soccer99

@cmelone  I finally found the issue after following the long trail of imports through the project.
There were three issues on my setup:
One, I didn't have password_reset_email.html, the email template, in my Django python module, nor in my project templates directory.  I added it into my project in templates/registration/
Two, the django.contrib.auth.forms.PasswordResetForm, which is used by rest_auth, filters out users that don't have a password set.  So if you login using a social authentication method, you won't have a password set on your user object and an email won't be sent out.
Three, after solving the first two issues, I finally got an error that was saying I didn't have a url route that resolved 'password_reset_confirm', since I have a spa I had to create a custom route for my project that had the same url parameters as the original (?P<uidb64>[0-9A-Za-z_\-]+)/(?P<token>[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20}).
I plan on creating a custom PasswordResetSerializer (original: rest_auth.serializers.PasswordResetSerializer) that doesn't use the Django PasswordResetForm and handle the "passwordless" users another way.
Hope this helps!

@soccer99 I had the template, and made sure that the email was in the system, but I am still not sure why the email isn't being sent. There is  not even an error message. Did you set up the password reset view manually in views.py. I'm glad you resolved your issue.

@soccer99

Two, the django.contrib.auth.forms.PasswordResetForm, which is used by rest_auth, filters out users that don't have a password set. So if you login using a social authentication method, you won't have a password set on your user object and an email won't be sent out.

Mind sharing how you decided to solve this issue?

@maxim25 While i'm not using the social authentication method, I would imagine it involves calling user.set_unusable_password() at some point during or after user creation.


Bigtable:  Add 'instance_type', 'labels' to 'Instance' ctor

Added optional type and labels to instance
Toward #5454.

Lint failure:
tests/unit/test_instance.py:162:1: W293 blank line contains whitespace

@sduskis This PR will conflict with #5622.

I'm ok with conflicting PRs.  The one that will be merge first wins, and the second one will have to fix the merge conflict.


Serialize directly to model classes

TL;DR
Gets rid of the Sdk... classes in the translator.py module. This should be the last place flytekit is explicitly using the old classes.
Previously the translator module converted from the new Python classes (PythonFunctionTask, PythonFunctionWorkflow, LaunchPlan) into the SdkXyz classes, and then relied on the serialize() call within each of those Sdk classes, invoked by serialize.py to convert them into model objects.  Now translator will go directly to the model, and the serialization step will just call to_flyte_idl()
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description

Remove most of the common dependencies in translator.py and replace with the model classes.
Python objects get converted to the same model classes as the output of their respective serialize calls earlier, namely

Tasks -> flytekit.models.task.TaskSpec
Launch Plans -> flytekit.models.launch_plan.LaunchPlan
Workflows -> flytekit.models.admin.WorkflowSpec

Realized that we were actually still relying on the two AuthRole settings in the serialization step. These were being read in the property field for auth_role in the SdkLaunchPlan class itself.
Handling for reference tasks/workflows is actually not great when it comes to getting the model representation. I'm currently using None.  That is, whenever a reference entity is run through translator.py, a None is returned and cached in the ordered dict.  This is useful because the translator is used in one other place - in dynamic tasks.  The runtime dynamic task compilation will look for these Nones and reject them.  Using None as a sentinel value is not good, but I think this PR has enough going on so will address that in a future PR.

Tracking Issue
https://github.com/flyteorg/flyte/issues/822
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

this looks awesome