Added Policy file details Page.

Signed-off-by: Himanshi Chhabra<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?

Add Policy details page
Added content tab
Added Included Policy locks and run list accordion.

:chains: Related Resources
:+1: Definition of Done

Added UI for the Policy details page.
Added UI for  Policy file content tab
Added cypress test cases for the detail page.

:athletic_shoe: How to Build and Test the Change
PFA Video
STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file  tab:

Go To  Infrastructure -> Chef Servers -> click server name-> click on org name -> policyfile tab.
Will see the policy file if available else will see no preview.
if available click on policy file name -> will see details page
click on Included Policy file accordion -> List of included Policy
Click on Run list accordion -> will see list of run list

:white_check_mark: Checklist
All PRs must tick these:

[x] I have read the CONTRIBUTING document.
[x] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[x] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[x] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[x] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[x] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[x] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[x] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Video for POlicy file details Page:

https://user-images.githubusercontent.com/61003053/125118166-f15a0d80-e10c-11eb-923e-8490553549ff.mp4

No preview if we don't have included Policy.

Hi @himanshi-chhabra , In Metadata label and text have more space. Can possible to make label text closer.

Hi @himanshi-chhabra , In Metadata label and text have more space. Can possible to make label text closer.
Add letter spacing to header.

@chaitali-mane Updated the changes.
Also removed the space


Fix TapGestureRecognizer _initialButtons

Change the _initialButtons by any PointerDownEvent, but that only use for the primary pointer created by the first PointerDownEvent.

I signed it!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ Googlers: Go here for more info.

I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

I signed it!

I signed it!

I signed it!

I signed it!

Hi @CimZzz, thanks for contributing to flutter!
Can you point to an issue that this pr is trying to fix? If there is no existing one, feel free to create a new issue.
It will be easier for the reviewer to review this pr.

@CimZzz - are you planning to continue with this PR, and the feedback from @chunhtai and @Piinks ?

I am going to close this PR for now. Feel free to reopen if you find some time to follow up on the comments.


Operator precedence

On the following line of documentation:
https://github.com/HaxeFoundation/HaxeManual/blob/7f11818fabd74a0c6773c068314588412e96a3c1/HaxeManual/02-types.tex#L142
% have lower precedence than * and / whereas in C these three have the same

I may be misunderstanding the definition of the word "precedence" here. My understanding is that lower precedence means that the operator would be executed later in the sequence of expression resolution. In this issue on the main Haxe repository, it seems as though modulo has a higher precedence according to this definition. Indeed, modulo is listed above multiply/divide in the table which is stated to be ordered in descending precedence.
The same could be said for the bitwise operators mentioned two lines below (they are higher, not lower precedence than comparison operators).
Am I misunderstanding the documentation? If not, I will go ahead and submit a PR fixing this issue.

Yes that seems backwards...


Provide template/blueprint automation for push notifications

Otherwise would be tricky for the user to take care of the incoming events

Fixed with version 1.0.6 (https://github.com/user2684/imou_life#motion-detection)


missing in SeedData.cs and Program.cs :

using RazorPagesMovie.Data;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03221075-5dfa-d1b6-0552-3fe88abe1d03
Version Independent ID: b8c7d824-35ca-68fb-e3be-839ae886657c
Content: Work with a database and ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/sql.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's there in the 3.0 and 3.1 version. You were looking at the 2.1 version


Pick up etcd v3.5.7

Pick up the latest etcd patch release. This version fixes a bunch of critical security vulnerabilities.
Ref: https://quay.io/repository/coreos/etcd?tab=tags
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

/test

/ci-l4lb

@michi-covalent heads up this looks like it broke etcd mode for Cilium 1.12: https://github.com/cilium/cilium/issues/23760

struggle


⚠ Bofrost.de has degraded performance

In 3feb118, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1029 ms

Resolved: Bofrost.de performance has improved in df59a5e after 9 minutes.


standalone LSP support?

hey, thanks for volar it's very nice
Is it possible to run volar as a standalone LSP server? (for use with eg. vim/emacs/sublimetext LSP clients)
I image the functionality would be not 100% complete with the VS code plugin but just wondering if it's possible?
thanks!

Yes volar is designed for this, we have vscode-vue-languageservice and this is a standalone vue language service api base on LSP for any node.js environment not only IDE.
I don't have time to focus on this temporarily. but you can comment which second IDE should we support first.

cool that's good to hear :+1:
I don't any IDEs in mind. but at least in my case, I use neovim with the builtin LSP client
for example to use that with the typescript LSP, you can call a command line program that takes LSP commands from stdio
local config_typescript = {
    cmd = {"typescript-language-server", "--stdio"},
    root_dir = util.root_pattern("package.json", "tsconfig.json", ".git"),
    filetypes = {
        "javascript",
        "javascriptreact",
        "javascript.jsx",
        "typescript",
        "typescriptreact",
        "typescript.tsx"
    }
}

I will check it when I free, and now the main work is refactor this project. thanks for sharing :)


Refactoring Template

I have just done some refactorings - for clarity I have done separate commits for each step

I would suggest to use {speed} instead of {rate} because I think this is more common wording for users this. playbackRate is a more technical term.

I had the same idea, but I wanted to commit this PR before suggesting it.
In my case, I used the syntax {speed?} with this explanation for the dropdown:
            { label: 'rate • 1.75x', value: '{rate}' },
            { label: 'rate? (!=1) •  1.75x ', value: '{rate?}' },

Probably, for example, you should choose a multiple of 1minute. And the progress in the examples is tied to it it will be more clear to the user and done = 10sec it will be beautiful and more visual. and speed is also a multiple of 2x
youtube.com/watch?v=9xp1XWmJ_Wo

Do you mean for the example values? Yes, using multiples of 1 minute would make it easier for the user to understand. Aligning the progress with these values would also enhance clarity and make the visuals more appealing, especially if done in increments like 10 seconds. Using speed as a multiple of 2x would be visually intuitive as well.

and probably this line is too overloaded: { label: '-2:24 -0:48 -13% • 15:36 5:12 87% • 18:00 6:00 • 3x', value: '{left} {left^} {left%} • {done} {done^} {done%} • {duration} {duration^} • {speed} {speed*}' }, I tried dividing it into groups like {left} {left^} {left%} - but it didn’t help much

Yes, the line is overloaded. My intention was to provide all possible values so users could remove what they don't need. The idea was that by experimenting with different values, users might better understand how each value affects the output.

also this line seems useless to me { label: 'For a custom template, you can use these fields:', value: ' ' },

My idea was to differentiate between the template section and the part where users can create their own templates. Since it wasn’t possible to add disabled separators, I used this as a workaround.
Maybe if you like my draft with the "template" / "custom pattern" then this is not needed.

because upon initialization the field is already empty. And if it is full, then the hint will not be displayed at all
I updated the template but it doesn’t work for me either. But I think it’s difficult to achieve something better

It would be helpful to have a "datalist"-like help tooltip that's always visible while the user types their custom pattern. Maybe tweaking the datalist to remove the filtering on values in the input field would achieve this. ( property on datalist nofilter:true)


[CSHARP-280] Integration tests for timer-based reconnections

Integration tests for timer-based reconnections

Rebased 01c6d207e336b07cba48bec1d9dceac838ddec08 and merged


make String.f32() and String.f64() partial

and fail if the string at the given offset contains an invalid F32/F64
which includes the empty string and trailing characters.
previously they were returning 0 in their respective return-type. So it was impossible to find out if parsing failed.
fixes #3026

Hey, everything succeeded but the docker build check failed because it cant find some makefile. That is unrelated to this PR and needs some separate investigation.

@mfelsche its because your PR isnt against the latest master.

Please do not merge this prior to the 0.27.0 release. There's no release notes with "before and after" code for the breaking change and I don't want to hold up the release that I am planning on doing within 4-5 hours.

@SeanTAllen here are my release notes:
This change changes the methods builtin.String.f32(offset: ISize) and builtin.String.f64(offset: ISize) to be partial and fail on input that cannot be parsed as a floating point number. This is the current behavior already for parsing integers from Strings.
Previously the methods for parsing floats would just return 0.0 on invalid input, overflow or when the given offset was beyond the bounds of the String it was invoked on. As 0.0 is a valid float, there was no real way to determine if the parsing failed or if 0.0 is a legit parsed value. These examples try to show the behavior of Pony prior to 0.27.0:
// true with Pony 0.26.0 and older
"".f32() == F32(0)
"ABC".f64() == F64(0)
"0.123".f64(10) == F64(0)

The following example shows the new behavior with Pony 0.27.0 and newer:
// these expressions will error with Pony 0.27.0 and newer
try "".f32()? end
try "ABC".f64()? end
try "0.123".f64(10)? end


Bumped version to 0.10.1

Codecov Report

Merging #38 (2b66943) into main (04f7c30) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          371       371
  Branches        44        44
=========================================
  Hits           371       371

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Feature]: Add a python file to update requirements.txt automatically.

Description:
This PR introduces a script to automate the generation and update of the requirements.txt file for the project. The script analyzes the imports in all Python files, filters out standard library modules and custom project-specific modules, and identifies any external packages that are not listed in requirements.txt. If any missing packages are found, it installs them and appends them to the requirements.txt file.
Additionally, this PR integrates the use of pipreqs as an alternative, streamlined solution to automatically generate the requirements.txt file based on actual imports within the project files.
Key Features:

Imports Analysis: Scans all Python files in the project to identify the imported modules.
Package Installation: Automatically installs missing packages and adds them to the requirements.txt file.
Exclusions: Excludes standard library modules and custom project-specific modules to avoid unnecessary dependencies.
pipreqs Integration: Provides a simplified method to generate requirements.txt using pipreqs.
Idempotency: If no missing packages are found, no changes are made to the requirements.txt file.

Benefits:

Ensures requirements.txt is always up-to-date with the project's dependencies.
Reduces manual effort in managing external package dependencies.
Avoids unnecessary bloat from including standard or internal project modules.

Workaround:

Integrate to trigger the program once a new package has been installed or any changes done to existing packages (update/removal)
would like to contribute to this issue as well.

@suryanshsk please check the pr and let me know any help/ changes needed. ;)


Text composables: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-classes-and-objects?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-classes-and-objects#6
In which task and step of the codelab can this issue be found?
7
Describe the problem
Not a code problem. But very confusing wording. It says that, "However, in Kotlin, all the classes are final, which means that you can't extend them, so you have to define the relationships between them."
And later, "The open keyword informs the compiler that this class is extendable, so now other classes can extend it."
I'm new to Kotlin, but so are the people taking this codelab, and it looks contradicting to a newbie like me.
A rewrite that would make sense to me would be, "However, in Kotlin, all the classes are final, which means that you can't extend them [by default] [...]"
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Thank you for reaching out to us.
To be published.


[aarch64] Contents of data folder cloning recursively with every start

So this happened with the latest aarch64 and the previous one. I have tried vanilla and paper on the latest versions.
When the server starts for the first time it creates the folder and data correctly, but after a restart (manual or a crash) as everything gets loaded I have noticed that the mods folder inside _data contained a copy of  _data, eventually the disk space is eaten.
 Just to confirm, can you provide an example of how you’re starting the container?

Using this command:
docker run --restart always -d -p 25565:25565 --name mc itzg/minecraft-server:aarch64

With this env vars
EULA | TRUE
PATH | /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/lib/jvm/java-1.8-openjdk/jre/bin:/usr/lib/jvm/java-1.8-openjdk/bin
LANG | C.UTF-8
JAVA_HOME | /usr/lib/jvm/java-1.8-openjdk/jre
JAVA_VERSION | 8u201
JAVA_ALPINE_VERSION | 8.201.08-r1
UID | 1000
GID | 1000
JVM_XX_OPTS | -XX:+UseG1GC
MEMORY | 1G
TYPE | VANILLA
FORGEVERSION | RECOMMENDED
SPONGEBRANCH | STABLE
LEVEL | world
PVP | true
DIFFICULTY | normal
ENABLE_RCON | false
RCON_PORT | 25575
RCON_PASSWORD | minecraft
LEVEL_TYPE | DEFAULT
SERVER_PORT | 25565
ONLINE_MODE | TRUE
CONSOLE | true
SERVER_NAME | VIVA KOLCHA
REPLACE_ENV_VARIABLES | FALSE
ENV_VARIABLE_PREFIX | CFG_
UDEV | off
ICON | https://i.imgur.com/MgmHuF7878.png
VERSION | LATEST
SPONGEVERSION |
GENERATOR_SETTINGS |
WORLD |
MODPACK |
MODS

Using portainer to facilitate everything it adds a ton of env vars.

@jalu14 , I haven't been able to recreate this both with a fresh container and looking at one of my long running containers. You may want to double check the volume mounts you have setup in portainer.
The following step in the startup would likely result in the observed behavior if you have "the wires crossed":
# If any modules have been provided, copy them over
mkdir -p /data/mods
if [ -d /mods ]; then
  echo "Copying any mods over..."
  rsync -a --out-format="update:%f:Last Modified %M" --prune-empty-dirs --update /mods /data
fi

Talking with another user I discovered that it is easy to create duplicate mounts of /data and /mods. I'll try to devise a way for the startup logic to detect that case and avoid the recursive copying of content into /data.

I ended up deleting the recursive folder with the console every now and then, not much of a hassle, still I can't gather enough info to help you, sorry about that.


Added nested attributes example for README

Hi,
This PR includes an example for README section related to nested attributes.
Hope this adds more clarity to the README section.
Thanks

Thanks, @ahmad19! Hope this helps others too.


Investigate ways to make multi_gpu_model faster.

Investigate ways to make multi_gpu_model faster by trying different aggregation methods (e.g. compute predictions and loss on each device then average gradients across devices, use input pre-fetching, etc).
Note created by @fchollet in the "Requests for contributions".

Hey @gabrieldemarmiesse, is this issue still open for contribution?

Hi @pranavdurai10  not really, multi-backend keras is deprecated and shouldn't be used anymore. Please use tf.keras instead.


Assertion `thtensor' failed.

I might do something very wrong but after a seemingly successful compilation I get this error when I want to start translation simply by
./cli/translate --model model.t7
$ Error: Assertion `thtensor' failed.  at .../CTranslate/src/th/Obj.cc:378
Any quick help would be much appreciated.

Could you describe model.t7? Is it released with the release_model.lua script?

Oops, my mistake, I forgot to do that... So it is a non-issue, sorry.


Edited VPNs

Removed Tunnelbear
Tunnebear got bought by McAfee a while back, and they don't have that good of a reputation when it comes to privacy and bloatware.
Added Windscribe

+1, windscribe is a great budget vpn.

Can confirm. Windscribe has amazing speeds and up until not long ago they offered a lifetime subscription.
They also have a safety firewall and many other features.
I have never had any issues.


Looser docker-py test matcher for parallelization

Previous one was only catching TestFoo, not FooTest. Python uses both.
Will expose a broken the test.
Found in https://github.com/weaveworks/weave/pull/1367
Depends on #1367

According to the docs, FooTest shouldn't match.
The test that @rade noted was test_valid_no_config_specified, for which we would just want to change Test to  [Tt]est in the regex.

Right, ok. Probably worth fixing in docker-py then. The regex is matching class names, not the method names.

On closer inspection, the test is using pytest unittest integration, so maybe matching class .*TestCase is closer to what we want.


merge stable into master

to prevent 2.074.0.html -> 2.074.0.dd -> ../tools/changed -o
2.074.0.dd chaing when 2.074.0_pre.dd is already present

Mmh, doesn't integrate to well w/ the changelog preview, but should be fine as master.


IndexedDB improvements

Dealing with raw data in the browser is a giant hassle. Some improvements:

Use msgpack instead of JSON for storing data in IndexedDB.
Use transferable objects to speed up communication between web worker and main thread.

After some further evaluation, it seems that none of these suggestions are viable.
JSON is heavily optimized by browsers, and converting between string and ArrayBuffer is not worth it.

Actually, this implementation might be fast enough: https://github.com/kawanet/msgpack-lite

Done in commit https://github.com/fortunejs/fortune/commit/be0dd980ea5ef533931bde10d526fe0b64a8cb2b.


Add log stream to deployment

Related to https://github.com/Azure/webapps-deploy/issues/119
Currently, when using this GitHub Action, no real-time deployment logs are shown, so it looks like the action is hanging. You won't see anything except for Package deployment using ZIP Deploy initiated. until the very end, where a link to the log files is shown:

When using Azure's VS Code extension to do a deployment, a real-time log stream is shown, so that you know exactly what the Azure service is currently doing. Could this please be added to this GH Action as well?

HI @dennisamelin, can you please try enabling step debugging to get verbose logs - https://docs.github.com/en/actions/managing-workflow-runs/enabling-debug-logging#enabling-step-debug-logging

That works, but it'd be great to have this just for the webapps-deploy step. ACTIONS_STEP_DEBUG sets it for every step in the job, which is a bit overkill. I really like how the VS Code extension mentioned above is doing it currently, providing real-time updates on what's happening. Might be something to consider for the future? 😊


Why do you use infinitely long cylinders and cones?

Hi, thanks for your excellent work! But I'm confused that why you use infinitely long cylinders and cones when computing the sdf. Why there is no "height" parameter associated with these two types of primitives? I think they need to be bounded to form the final shape. Could you please explain this for me? Thank you in advance!

Hi Jiale,
Thanks for your interest.
There is no particular reason for infinitely long cylinders and cones. This is more a less a legacy issue (it is much easier to implement when cylinder and cone are unbounded). You are right, the individual cylinders and cones are not bounded shapes, but when intersecting with boxes or other types of primitives, the intersection result becomes bounded.
Hope this helps,
Daxuan

Thank you! I also notice that there is a sdfPlane function in sdfs.py but I didn't find it was used elsewhere. So I guess this function is useless for this project right?

Yes, the sdfPlane is not used in the final project. It was implemented only for debug proposes.


fixing minor typo in node's documentation

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Fixed typo in documentation.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 69.133% when pulling 6dd6432943243948713ddf458e57d8d7095b3a7a on matthiasradde:lang-de-fixtypo into 7068c175f288c4f7860380e1d4a315b9223b2777 on node-red:master.

Coverage remained the same at 69.133% when pulling 6dd6432943243948713ddf458e57d8d7095b3a7a on matthiasradde:lang-de-fixtypo into 7068c175f288c4f7860380e1d4a315b9223b2777 on node-red:master.

strange: I have signed the Contributor License Agreement, but it is not checked here.

strange: I have signed the Contributor License Agreement, but it is not checked here.

The commit was not made with an email address that is linked to your github account.
The commit was from your ...meule.com address and github only knows your gmx.net address.
You have 3 options

add the other address to your github account
resubmit a new pull request with the commit done with your gmx.net address
edit the email address linked to the  commit on your machine and force push the change to your fork and it should update this pull request.

Options 1 & 2 are probably easiest

The commit was not made with an email address that is linked to your github account.
The commit was from your ...meule.com address and github only knows your gmx.net address.
You have 3 options

add the other address to your github account
resubmit a new pull request with the commit done with your gmx.net address
edit the email address linked to the  commit on your machine and force push the change to your fork and it should update this pull request.

Options 1 & 2 are probably easiest

Thank you - forgot that I created the commit with my bussins-email-account.
I've added the ...meule.com-email-address to my github-account - hopefully it is working now. Otherwise I will try the other options.

Thank you - forgot that I created the commit with my bussins-email-account.
I've added the ...meule.com-email-address to my github-account - hopefully it is working now. Otherwise I will try the other options.

thanks

thanks


File not found error

When running a build I get this error :
pieter$ haxe build.hxml
/usr/local/lib/haxe/std/neko/_std/sys/io/File.hx:30: characters 20-51 : /usr/local/lib/haxe/lib/modular-js/js/enum_stub.js: No such file or directory
/usr/local/lib/haxe/lib/modular-js/0,9,1/src/modular/js/JsGenerator.hx:145: characters 3-64 : Called from
/usr/local/lib/haxe/lib/modular-js/0,9,1/src/modular/js/JsGenerator.hx:384: characters 3-40 : Called from
/usr/local/lib/haxe/lib/modular-js/0,9,1/src/modular/js/JsGenerator.hx:438: characters 46-77 : Called from
<null pos>:1: character 0 : Called from
Aborted

You can see that /usr/local/lib/haxe/lib/modular-js/js/enum_stub.js is not found, but when I look at the filesystem it seems that the root path to modular-js is incorrect because /usr/local/lib/haxe/lib/modular-js/0,9,1/js/enum_stub.js does exist.
Is this a bug in modular-js?

Does this solve your issue? https://github.com/explorigin/modular-js/pull/4  It's been some time since I worked with Haxe so I'm a bit rusty.

Yes, this PR solves by issue indeed, thanks!


How stupid/difficult would it be to make this work without a local discord client?

The MacOS Discord client is a fun electron app that uses a lot of idle battery, so I try to avoid having it open.
From my understanding, rich presence can only be configured via an RPC call to a local discord client, and theres no API endpoint that can handle it.
So, does it seem feasible to run a discord client on a linux server or something, then port forward the RPC socket, and then slightly modify apple-music-discord-rpc to communicate with the remote instead of via localhost?

I was hoping to mimic what Spotify does, but they are a Connection that Discord enabled, so they get special treatment i guess.
It also looks like all the RPC calls are made via the discord gaming SDK, so its probably not feasible to just change the code to talk to a remote.
I think the most realistic solution is to add some local firewall rules that automatically forward all traffic on localhost on ports  [6463, 6472] to a remote Discord client.


PHP: ability to change port

I'm using a PHP container as a backend, my frontend runs on port 8080 by default so I need to change apache port for the backend, I'm able to do that with this command :
    "onCreateCommand": "sudo perl -0777 -i -pe 's/Listen 80\nListen 8080/Listen 5000/' /etc/apache2/ports.conf"

But I still get port 8080 reserved by vscode which causes problems with my frontend, I have to manually remove it from vscode everytime before running my frontend container.
It is reserved because of this setting in the base .devcontainer.json :
    "forwardPorts": [
        8080
    ],

Removing this setting from the base image will solve the problem, apache port will get auto-forwarded anyways so it's not really needed.

Closing as completed with https://github.com/devcontainers/images/pull/498

How do I update the image I have? when I rebuild the container I get the same image even if I remove the base images before building the container.

That's strange. Can you remove the images from your docker cache and retry?

I removed the images with :
docker image prune -a -f

But still got the old image, I had to run this command to remove the build cache :
docker builder prune -a -f

The new php-8 container had the port removed after I commented the forwardPorts option, but the php-7.4 container still had the port 8080 forwarded, I guess you don't update the old images.


[bug] images do not get "registered" with factory

It seems that before images can be downloaded from the factory, they first need to be registed by making a get request towards the factory.
It would be best to implement this behavior where it's relevant. but the most logical place would likely be "genconfig", as that ensures the config build from said images references images that actually exist.
Maybe it would even be best to fetch the image strings from the factory directly, to ensure they are properly registered?
One might hit this when one has a order of extentions that does not match the website order (which would always trigger this) and/or is the first one to use a certain kernel argument and/or if one is the first to use a certain meta and/or if one is the first to pull a certain image at all.

The get request is documented here:
https://github.com/siderolabs/image-factory

Issues you hit when a image is not "registered" are shown here:
https://github.com/siderolabs/image-factory/issues/61
Though thoroughly underdocumented.

Ah I didn't know about this. Seems like I need to change the way the schematic ID is getting parsed. I'll tackle this tomorrow. My plan is to use do a POST request to get the ID instead like the recommendation. It will also mean that it will require internet connection to generate the ID and will possibly fail in case the server is offline. Thanks for the report!

Ah I didn't know about this

yeah me neater, was breaking my head on this for 2 days and couldn't figure it out till the dev explained it's a registration/creation based API...

Seems like I need to change the way the schematic ID is getting parsed.

Cool, agreed, thanks for the quick response!

My plan is to use do a POST request to get the ID instead like the recommendation

That should work

It will also mean that it will require internet connection to generate the ID and will possibly fail in case the server is offline. Thanks for the report!

Think the old design is fine as long as it's an optional "offline mode"

Thanks for the report!

No problem!

Seems like the image factory is down this whole day so I can't do anything now :cry:

Seems like the image factory is down this whole day so I can't do anything now 😢

It's online for me at least...

I'm unsure if ofline should be in flags or config because basically you'll only want online mode except when u/the server is down or u don't want to spam the server too much. Usually you want to register the id only once to the server so u can pull it. I need to rethink this thoroughly.


gio: mark content_type_guess parameter as filename

Ideally this needs to be fixed upstream

I see, what would that fix look like?

Like here: https://gitlab.gnome.org/GNOME/glib/-/blob/62a88d9f38c77f140fb7f6d714fb4445277ce5e4/glib/gfileutils.c#L210

Upstream MR: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2411


Update generator-cf architecture to latest

Gulp workflow was broken when parsing ES6 syntax. This fixes it.
Removals

Removes references to non-existent files.
Removes build and default gulp tasks and merges them into gulpfile.js.

Changes

Converts gulp task format to handle gulp 4.
Brings in latest ESLint 4 rules and fixes.
Changes to using uglifyjs-webpack-plugin instead of gulp-uglify.
Bumps versions of grunt-contrib-uglify, grunt-eslint, browser-sync, gulp, gulp-autoprefixer, gulp-changed, gulp-clean-css, gulp-eslint, gulp-header, gulp-imagemin, gulp-less, gulp-sourcemaps, parallelshell, webpack, and webpack-stream.

Testing

Pull down this branch.
Run NPM Install
Follow the testing instructions in https://github.com/cfpb/generator-cf#contributing
(Choose gulp workflow.)

Works for me! I noticed there are two deprecation warnings still, is it worth fixing here?

I'll do that in its own PR so we can have this working again.


Incomplete copy on current intervention for limited action - State

summary
The copy in Current Intervention seems to be incomplete for the "Limited Action" case.

expected result
The phrase should be complete. I don't know what the copy should be
actual result
The copy in Current Intervention is incomplete for the "Limited Action" case.
environment

Web
Chrome in Desktop

link

https://covidactnow.org/us/sd

screenshot

FYI- That text lives here: https://github.com/covid-projections/covid-projections/blob/ceca57be90e701cb3e5825dd52ef56637b4639c0/src/enums/interventions.js#L28
Looks like it got messed up here:
https://github.com/covid-projections/covid-projections/commit/e090b5e027ab8890805e34b96e632475ab9296b8#diff-313969129a79cffa5de570b09042ece6R28
Old text was “Public advocacy around “social distancing” and enhanced hygiene. Minimal mandated restrictions.”

Per @schlosser this section is going away soon.  Assigning to @schlosser for now.

And it's gone!


⚡ Standardization of rep

Hi @c4ssiopei4, We need to adjust a few things first to move forward, OK? ✨
First, we need to adjust the readme.md to match our template's default.
I ask that these changes be standardized with the other repositories, see an example; this is also important because it helps other potential users who would also like to contribute! 😁
Let me know if something isn't possible or if you have any questions! 🙂

Done!

Thanks! 💜


Consider the indirect owner-relationship between pod and workload

Signed-off-by: mingzhou.swx<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Consider the indirect owner-relationship between pod and workload, such as
pod -> replicaset -> deployment

Codecov Report

Merging #48 (885fc2d) into master (149e5a4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   20.12%   20.10%   -0.02%
==========================================
  Files          21       21
  Lines        2465     2467       +2
==========================================
  Hits          496      496
- Misses       1896     1898       +2
  Partials       73       73

Flag
Coverage Δ

unittests
20.10% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...chrelease/workloads/statefulset_like_controller.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149e5a4...885fc2d. Read the comment docs.

/approve


Refactor Endpoint API

This contains #3025, and fixes for Windows.
Also:

msbuild is now used to build tests
many more of the windows projects work

I don't see any redflag with that.

Feel free to merge... It's green enough


[flutter_tool] Build shaders as .iplr and use FragmentProgram.fromAsset for ink_sparkle

@jonahwilliams Switching over to FragmentProgram.fromAsset for ink_sparkle is going to break the internal build, so I'd suggest we land a simple change like this before the one you have going to hopefully make the internal fix simpler/easier.

That SGTM

This is going to be easier to roll internally after we use a flag rather than the output file extension to indicating wrapping in the .iplr format, so I am switching this back to draft until that's done.


Allow assignment of 911 calls to departments

Describe the feature
When creating a 911 call some of them would be for example for Fire/EMS and it would be good to have the ability to specify which call would be routing where. When you call 911 you're asked what service you're calling for so this would line up.
To extend this functionality it would be good if Dispatch could assign a division, for example if its a call requiring detectives it can be assigned to that division.
You can then use the API to filter calls displayed to each user!
Additional Context
No response

Would this then also filter the 911-calls list, or a toggle button for that?
For example:

Unit is EMS/FD -> will only see EMS/FD calls
Unit has X division -> will only see X division calls

Would this then also filter the 911-calls list, or a toggle button for that?
For example:

Unit is EMS/FD -> will only see EMS/FD calls
Unit has X division -> will only see X division calls

Oooh yes it would be good if they were filtered, but probably needs to be behind a button like you say!

Another quick question: Would this show in the active-calls table? ifso, I think 2 columns would take up to much space for example:

Location
Department
Division
....

bla bla
blablabla
bla bla
....

Do you have any suggestions?

Another quick question: Would this show in the active-calls table? ifso, I think 2 columns would take up to much space for example:
Location	Department	Division	....
bla bla	blablabla	bla bla	....
or even 1 column
Location	Department/Division	....
bla bla	bla bla	....
Do you have any suggestions?

I like the call info modal idea! Just the real basics in the table then each call has a modal option?

I like the call info modal idea! Just the real basics in the table then each call has a modal option?

Yep!

Yet another quick question: Would this allow multiple departments/divisions to be connected to the call or only 1? @jxckUK

Yet another quick question: Would this allow multiple departments/divisions to be connected to the call or only 1? @jxckUK

I think that should be something defined either by the admin of the CAD or on a call by call basis?

I think that should be something defined either by the admin of the CAD or on a call by call basis?

hm, yeah. Will have be multiple so the dispatcher can decide

I like the call info modal idea! Just the real basics in the table then each call has a modal option?

Decided to take to manage 911 call modal and make everything readOnly
https://user-images.githubusercontent.com/53900565/151690943-ca67de15-699e-41a6-bf2d-a39c46503681.mov

Working filters:
https://user-images.githubusercontent.com/53900565/151695959-3b9fb34b-d362-465a-8b4e-a4df12eb5f9d.mov

Done 🚀! Let me know if there are improvements to be made!

Done 🚀! Let me know if there are improvements to be made!

Awesome stuff! - just a couple of things from initial usage:

Is this supported in the API (creating 911 calls and setting department/division using IDs?
It would be ideal if when you're selecting departments and divisions that once you select a department only divisions from that department can be selected? Just to reduce UI clutter?

Is this supported in the API (creating 911 calls and setting department/division using IDs?

Yep

It would be ideal if when you're selecting departments and divisions that once you select a department only divisions from that department can be selected? Just to reduce UI clutter?

Sure, I'll work on this later today!


Better handle glitch tracing in CollectAudioLogs

Today using CollectAudioLogs for glitch tracing requires knowing not to enable time travel tracing, and that additional system information isn't required. Also, because glitch logging is included for all tracing, audio logging is limited to 30 to 60 seconds of data (stream creation logging ages out very quickly).
So, it may be useful to define a CollectAudioGlitchLogs.cmd, which launches CollectAudioLogs with some additional parameters so that we better target collection. Alternatively, the CollectAudioLogs could ask the user if the log collection is for diagnosing glitches.

I suggest three parameters and three .cmd files:
Parameters

-diagnostics

-repro

-timetraveltrace

I-cannot-recreate.cmd - passes -diagnostics

I-can-recreate.cmd - passes -diagnostics, -repro, and -timetraveltrace

I-can-recreate-audio-glitch.cmd - passes -diagnostics and -repro

People who want other combinations can call the .ps1 directly

Fixed with PR #10


dbus: don't search for units in current-system

Motivation for this change
Continuation of #22343. With this dbus always follows configuration files properly regardless of environment: upstream configuration -> NixOS's -local.conf -> other services and cofngiurations, including system path.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Tested in a VM together with #22343 and with strace to confirm that dbus reads all configuration files like before. cc @layus

Is this really a mass rebuild? I guess it'll mostly affect a bunch of linux-specific stuff

Hm, I thought that systemd depends on dbus (don't judge me, I wouldn't be surprised if it depends on gtk :D) but it seems to be false. Still, it affects GTK and Qt at least -- I usually classified this as a mass rebuild.

Hi abbradar,
have you understood the deleted comment ?

this package installs nothing into those dirs and they create a dependency

Wat was the purpose of the removed --datadir option ?

@layus If I interpreted it properly it meant that without this flag an extra dependency (presumably between multiple outputs as it was added as part of that work) was created. I assumed that it was from dbus.lib to dbus.out but I don't see such a dependency with this patch -- and nothing else of interest. @vcunat -- if that interpretation seems wrong please correct me!
datadir in Makefile was removed because it's not needed now -- it was because otherwise all data files would be installed to /run/current-system/sw/share, not to $out/share.

I think the same; the dependency isn't created now.  Still, I wonder if some code in nixpkgs is relying on /run/current-system/sw/share being searched for dbus units.

@vcunat There is I think, and dbus.nix handles that by adding config.system.path to dbus paths.

Then what is the point of the services.dbus.packages option ?

@layus To avoid installing to environment everything that installs a dbus service. IMHO we most if not all system services to be installed like that, but this directory was added historically.

At the end of the day, It adds confusion to search both services.dbus.packages and config.system.path. If we have services.dbus.packages, why even look into config.system.path ? You may want a package in the system path and another in dbus config.

I agree but it may be very difficult to get rid of this (unknown number of modules depends on this) and this will break users configuration (off the top of my head -- blueman installed to environment.systemPackages will break). Also one may argue that this is convenient for users (not sure about this one).

agreed, indeed. Until someone complains :-).
Curious you should mention blueman. I was trying to install it and could not make it work with dbus...

See https://github.com/NixOS/nixpkgs/pull/22353 -- with this OBEX and even networking finally works for me out of the box.

This worked okay in a VM so let's merge this in few days.

It seems that this is not the end of the story, but at least it helped to uncover an old bug :D
Currently it manifests itself as inability to start services as root. After investigation in the dbus source code this is my prelimitary understanding: the reason is that dbus-daemon-launch-helper uses hardcoded service.conf path and a trimmed version of configuration parser which doesn't support <include>. Therefore we don't have system-local.conf included for purposes of this helper. The problem was masked before because datadir was set to /run/current-system/sw/share, so dbus services that were installed into environment worked fine. It was still broken though because that didn't work for services.dbus.packages.
The first strategy that comes to mind is to set datadir to /etc and place there specially modified system.conf which contains all <include>s by itself. I'll try to implement this -- sadly this will cause another dbus rebuild. I'll also make sure to comment this so we remember this problem later. Sorry for the trouble!


about  the transformer config in CogVideoX1.5-5B-I2V

hi, I'm trying to run the cogvideox_image_to_video_sft.py using the disney dataset, but I find that the sample_width and sample_height in transformer config is 300 and 300, which is different from my preprocessed latents shape (w=90,h=60), should i change the sample_width, sample_height  and sample_frames in the transformer config?

300 for sample height and width is correct for CogVideoX 1.5. Instead of using a frame/height/width adaptive RoPE, they slice a section of the rope embeddings. You can refer to the implementation of get_3d_rotary_pos_embed in Diffusers for an example on how they slice.
On your end, I don't think you have to modify in the config.


Support/375 refactor rewrite logging

The PR only contains code changes to establish RewrittenQuery as a response wrapper for the output of rewriters. It does not include functional changes

Part of #375


[Apple Mail] Add menu bar command

Extension
https://www.raycast.com/yug2005/mail
Description
Would love to have a menu bar item that says how many unread emails are available. The context menu should include all mails in the inbox, and a text that says when it was last checked.
Who will benefit from this feature?
No response
Anything else?
No response

@raycastbot assign me

Hey @catdevnull I think it'd be more consistent if we keep the UI elements for the menu bar context the same as you see in "See Recent Mail" command. I agree with other propositions regarding count etc. What do you think?

I personally don't use the "see recent mail" command as it seems to always be outdated for me.. I'm not sure why. At first I thought it only showed unread email, but I guess that's not the case. But it's not showing emails that are in my inbox for some reason.
If it were to work properly, that would work for me :)
Thanks for working on this!

@raycastbot rename this issue to "[Apple Mail] Add menu bar command"

not stale


[FEATURE] Add a method to digital sign document

White paper on "digital signature for PDF Documents":
http://itextpdf.com/book/digitalsignatures20130304.pdf

To me, it would be sufficient to have a method to add the empty space in the PDF dictionary, calculate the external hash, and then to embed an externally-calculated PKCS#7 signature into it. I'd love to try and implement it, but unfortunately I won't have time to try it anytime soon.

@alexvdev do you mean with PDFKIT or another pdf-generating engine?

+1

+1

+1

+1

Any updates on this :) ? It has been a century .

https://github.com/vbuch/node-signpdf might help


added shard command

@erocs

@ProgrammerDan
This should be fine.

Yeah it seems it was actually online and I replaced it (woops). Should be totally safe to merge, I actually used it last night, bravo.
Once you fix the conflict (probably pom.xml) go ahead and merge.

How was it online? I never merged it?

Nevermind. Apparently /server just prints this same list basically.

Any reason you haven't rebased and merged yet @rourke750 ? :D

Cause I think I did it locally. Lol I'll push when I get the chance.


Question about Cache-Breaker

Hey,
thank for your awesome project. Helps me a lot getting started.
I have some questions about the Cache-Breaker:
Why is it needed?
And how do I disable it for using it in a production system?
Also do you have any other things to do that you think are necessary before using drywall in production?
Thanks in advance for you help

Why is it needed?

Sometimes browsers will cache assets (css/js) and an easy way to break that is by appending a unique query parameter to those paths.

And how do I disable it for using it in a production system?

This is actually where you'd wan't something like this. You'd want to be certain that your end users are getting the most updated versions of the assets. The are better ways of doing this. One I just found by searching is grunt-cache-bust.

Also do you have any other things to do that you think are necessary before using drywall in production?

Be sure to checkout Frame, it's the guts of Drywall, but without a front-end, and it has good test coverage. It's what I'd reach for today most likely.


fix: clear selections

:tada: This PR is included in version 1.2.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


adding FunctionActivitySource to Worker; refactoring AppInsights support

This change:

moves the FunctionActivitySource into the core worker project and provides OTel versioning capabillities for the future.
updates the handling of this Activity in the App Insights package
makes the App Insights handling richer (now sends Exceptions, sets Dependency status, for example)
removes a bunch of other custom App Insights code we had to simplify some of our behavior
sets "WorkerApplicationInsightsLoggingEnabled" capability for when functions host can handle this (soon)

Note that after this change you can start wiring up OpenTelemetry exporters in the worker as well and bypass our ApplicationInsights package completely. For example:
funcBuilder.Services.AddOpenTelemetry()
    .WithTracing(traceBuilder =>
    {
        traceBuilder.AddSource("Microsoft.Azure.Functions.Worker")
            .AddHttpClientInstrumentation()
            .AddAzureMonitorTraceExporter(o => o.ConnectionString = aiConnStr)
            .SetSampler<AlwaysOnSampler>();
    })
    .StartWithHost();

funcBuilder.Services.AddLogging(loggingBuilder =>
{
    loggingBuilder.AddOpenTelemetry(options =>
    {
        options.AddAzureMonitorLogExporter(o => o.ConnectionString = aiConnStr);
    });
});

@jviau re: versioning
I was planning to get this in as GA inside the Worker assembly without any preview. (The ActivitySource; not the App Insights stuff). I was intentionally keeping this initial Activity small -- with really only a single tag added plus the schema. I figured the only real changes I see coming are:

add new tags to make things richer -- which I wouldn't see as "breaking"
some tag needs to change due to the otel schema changing. This is factored in (i.e. "faas.execution" -> "faas.invocation" mapping would already happen and customer would choose the schema they want to run with in WorkerOptions).
we'd need to change the Activity name or kind? We can hide this behind the schema selection as well.

We're getting lots of requests for this to be "official" -- so I didn't want to sit in Preview for a long time. I know changes will come which is why I chatted with @lmolkova about how everyone else is handling schema changes.
We can certainly move to an external diagnostics assembly -- it'd be more flexible. But I'm sure even after we GA that we'd get more changes coming in the future. Maybe it'd be easier to bump that one's major we have to do a major overhaul?
Curious how others feel -- @fabiocav / @lmolkova / @RohitRanjanMS


Variants - core dump

Hello Jared,
Thanks for the great tool - I hope I can get it working as it looks very promising!
I compiled nanopolish using GCC-5.2 and make. I received the error immediately after execution.
Execution
nanopolish variants --consensus nanopolish_ACall/polished.0-4120.fa -w 0-4120 -r nanopolish_ACall/arturo_all_reads.fa -b nanopolish_ACall/NB01.consensus.sorted.bam -g nanopolish_ACall/drafts/NB01.consensus.fasta --min-candidate-depth 100 --models-fofn nanopolish_models.fofn
Stderr
#CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO
TODO: train model
TODO: filter data
nanopolish: src/common/nanopolish_fast5_map.cpp:84: void Fast5Map::load_from_fasta(std::__cxx11::string): Assertion `read_to_path_map.find(seq->name.s) == read_to_path_map.end()' failed.
Aborted (core dumped)
Core dump
registering model t.007-base
registering model t.007-ONT
#CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO
TODO: train model
TODO: filter data
nanopolish: src/common/nanopolish_fast5_map.cpp:84: void Fast5Map::load_from_fasta(std::__cxx11::string): Assertion `read_to_path_map.find(seq->name.s) == read_to_path_map.end()' failed.
Program received signal SIGABRT, Aborted.
0x0000003bef832495 in raise () from /lib64/libc.so.6
(gdb) bt
#0  0x0000003bef832495 in raise () from /lib64/libc.so.6
#1  0x0000003bef833c75 in abort () from /lib64/libc.so.6
#2  0x0000003bef82b60e in __assert_fail_base () from /lib64/libc.so.6
#3  0x0000003bef82b6d0 in __assert_fail () from /lib64/libc.so.6
#4  0x000000000048db21 in Fast5Map::load_from_fasta (this=this@entry=0x7fffffffa1d0, fasta_filename=...) at src/common/nanopolish_fast5_map.cpp:84
#5  0x000000000048ef36 in Fast5Map::Fast5Map (this=0x7fffffffa1d0, fasta_filename=...) at src/common/nanopolish_fast5_map.cpp:38
#6  0x00000000004a1955 in AlignmentDB::AlignmentDB (this=0x7fffffffa120, reads_file=..., reference_file=..., sequence_bam=..., event_bam=..., calibrate_reads=) at src/alignment/nanopolish_alignment_db.cpp:35
#7  0x00000000004159ad in call_variants_for_region (contig=..., region_start=4120, region_end=-2) at src/nanopolish_call_variants.cpp:797
#8  0x00000000004172cf in call_variants_main (argc=, argv=) at src/nanopolish_call_variants.cpp:1012
#9  0x0000000000408860 in std::function<int (int, char**)>::operator()(int, char**) const (__args#1=0x7fffffffa710, __args#0=15, this=0x9abf50)
at /broad/software/free/Linux/redhat_6_x86_64/pkgs/gcc_5.2.0/include/c++/5.2.0/functional:2271
#10 main (argc=16, argv=0x7fffffffa708) at src/main/nanopolish.cpp:59
Prior commands
bwa mem -x ont2d nanopolish_ACall/drafts/NB01.consensus.fasta nanopolish_ACall/arturo_all_reads.fa | samtools sort -o nanopolish_ACall/NB01.consensus.sorted.bam -T nanopolish_ACall/NB01.consensus.sorted.tmp -
Files
head -n 1 nanopolish_ACall/arturo_all_reads.fa
'>channel:1D_000:template GP1B9_B89_20170301_FNFAB30680_MN16958_sequencing_run_2nd_Attempt_AC_Samples_48030_ch245_read8000_strand arturo_all_source/fast5_all/GP1B9_B89_20170301_FNFAB30680_MN16958_sequencing_run_2nd_Attempt_AC_Samples_48030_ch245_read8000_strand.fast5'

Hi,
Your fasta has duplicated entries, which prevents nanopolish from creating a read-to-fast5 map. Your reads are probably all named channel:1D_000:template but they should be named like <unique-id>:1D_000:template. What basecaller/extraction program did you use?
Jared


Model is not being saved when supplying ID, Does not save, Reports Success

func foo(objects: [Int:[Int]]) {
  for object in objects {
    let new_object = MyObjectModel(id: object.key, object.value)
    let result = createNewObject(db, new_object)

    result.whenSuccess( {object in
      print(object.id)
      print(object.indexList)
    })

    result.whenFailure ({error in
      print(error.localizedDescription)
    })
  }
}

func createNewObject(_ db: DatabaseConnectable, _ new_object: MyObjectModel) -> Future<MyObjectModel> {
  return new_object.save(on: db)
}

//MyObjectModel.swift
import Vapor
import Foundation
import FluentPostgreSQL

final class MyObjectModel: Codable {
  var id: OtherObject.ID? //Type = Int
  var indexList: [ADiffObject.ID] //Type = Int
  var createdAt: Date?
  var updatedAt: Date?

  init(id: OtherObject.ID, _ indexList: [ADiffObject.ID]) {
    self.id = id
    self.indexList = indexList
  }
}

// MARK: Required Extensions
extension MyObjectModel: PostgreSQLModel{}

extension MyObjectModel: Content {}
extension MyObjectModel: Migration {}
extension MyObjectModel: Parameter {}

extension MyObjectModel: Timestampable {
  static var createdAtKey: WritableKeyPath<MyObjectModel, Date?> {return \.createdAt}
  static var updatedAtKey: WritableKeyPath<MyObjectModel, Date?> {return \.updatedAt}
}

// MARK: Relationships
extension MyObjectModel {}

No Data is Saved to the Database, The Table is empty. I have dropped the table and let it get recreated. Result is the same. no data in table despite reporting success.
The when.Success Handler fires  and prints:
    /// 275940
    /// [31, 43, 39, 75, 30, 319, 163, 1113, 28, 90, 34]
    /// 275938
    /// [31, 280, 39, 41, 28, 43, 75, 78, 30, 115, 42333]
    /// 275939
    /// [31, 280, 39, 28, 178, 43, 34, 29, 75, 42333]
    /// 279987
    /// [4077]
    /// 275946
    /// [336, 90, 31, 128, 43, 368]

Note: For Some Reason I could not get the "code block" to format correctly

I'm also seeing this issue. I wouldn't expect to be able to save a new model with an arbitrary ID but I would expect it to return an error–not success.

@ezfe @brntphish you need to use model.create() instead of model.save() when supplying the ID. Fluent uses the presence of an ID to determine whether to do a update or create

@0xTim Ah, then shouldn't save return an error if you supply an ID that doesn't exist yet?

@ezfe depends on the DB - normal you want to hand that off to a DB

@0xTim Isnt that kinda counter intuitive...... I mean that would indicate I have to query the db before I need to add an entry to see if it exists (since an error is not reported and I cant read to the error to know "it would create a duplicate key") and swap from create to update
like wise if I called update on a row that didnt exist it would not get created.
Use case, a json file of employees with employee numbers provided daily with lots of info for each record that changes, as well as new employees.
Read each json entry as an employee
Get employee number as pk
create or update (in order to determine if I should create or update, I am forced to query to determine the method needed)
I think this is confusing and should be handled more quietly kinda like a hybrid between SQL insert (Fluent create) and and SQL update(Fluent update)
We need a single method that will If Exists Update, else Create ..... maybe an upsert command  (update or insert)

UPDATE: (Feel Free to Close)
put here for others that have the same issue.
apparently this now exists as :
object.create(orUpdate: true, on: req)

My solution to this problem was to define a willCreate on PostgreSQLModel that deletes the ID field
extension PostgreSQLModel {
    func willCreate(on connection: PostgreSQLConnection) throws -> EventLoopFuture<Self> {
        if self.id != nil {
            throw Abort(.forbidden, reason: "Cannot create model with ID")
        }
        return Future.map(on: connection) { self }
    }
}


Standard User - When creating custom RKE2 cluster, if i view the config of cluster, I am not a cluster owner on member roles page

Rancher Server Setup

Rancher version: v2.6-head -9d2e086
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1 with multiple nodes

Proxy/Cert Details:

Describe the bug

As a standard user, create the cluster, but some binding is missing cause when I try to view the member roles of the cluster, there is no one listed.
note: when I log out and log back in, I can no longer see the clusters.
To Reproduce

Log in as standard user
Create a custom RKE2 cluster (Errors will be hit but a cluster is made in the background)

Result
View the config of the cluster and check the member roles. It will be empty.
Expected Result

View the config of the cluster and check the member roles. It should have myself as a cluster owner.
Screenshots

Additional context

Validated with v2.6-head - 6cb1847
8/11 4pm
UI fixes were introduced to show cluster owner


unorganized navbar

The current navbar is unorganized and elements are overlapping with eachother.
I would like to make this navbar organized and responsive as well.

please assign this issue to me under GSSoC-extended.

The navbar can be enhanced..I would love to enhance it please assign this task to me


[SPARK-44086][SQL][TESTS] Move DataFrameFunctionsSuite to sql - slow

What changes were proposed in this pull request?
Move DataFrameFunctionsSuite to sql - slow
Why are the changes needed?
1, recently DataFrameFunctionsSuite is frequently updated for the new functions, while sql - other is quite flaky and it's likely to get stuck or failed before DataFrameFunctionsSuite is actually tested (see https://github.com/apache/spark/commit/61a195d33936d6059933de017fa251dac961021e and https://github.com/apache/spark/commit/37f9beaba7e8bdf9f417453d7dab0b7773b55200), so it is hard for the reviewers to judge whether all related tests pass;
2, sql - other is actually much slower than sql - slow, so I think it is fine to move a suite to sql - slow;
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
updated GA

this test suite is now run in sql - slow

cc @beliefer @LuciferYang @panbingkun

LGTM. @zhengruifeng Thank you!

late lgtm

thank you all!


Optimize SVGs

I’ve lost count of the times @ZeLonewolf has asked me to optimize the product of my meticulous button-mashing in Inkscape into more compact SVG markup. npm run code_format now runs all the SVG icons through SVGO’s default preset list of optimization plugins. I haven’t really explored the plugins and their configuration options, so please scrutinize each of the resulting SVGs for perceptible differences.

By the way, I’m not entirely sure why we need this optimization, since the SVGs get compiled down into the spritesheet at build time anyways. But as long as the maintainers expect optimization, it should be applied automatically, so that the contributor doesn’t have to remember to save as Optimized SVG instead of just saving in Inkscape.

I’m not entirely sure why we need this optimization

Because extra, unnecessary code is where bugs go to hide :)

npm warns:
npm WARN deprecated<EMAIL_ADDRESS>This SVGO version is no longer supported. Upgrade to v2.x.x.
Should we be using a newer one?

I specified ^2.8.0. Not sure how you’re getting v1.3.2.

Looks like spritezero is the culprit for that warning message.  I looked in node_modules and it's clearly got the newer version in there so, I think we can ignore that message.

There’s a very subtle difference in style/icons/shield40_us_us_2.svg that I feel uneasy about: the optimized SVG seems to be offset ever so slightly to the left, making the numerals appear uncentered. The effect is present on the map but not when viewing the SVG directly in a browser. I can reproduce this issue on a 2× display; it’s possible that it doesn’t reproduce on a 1× display.

Looks completely normal in Inkscape:

However, in the sprite sheet generated from this branch, you can see that it's cut off slightly on the left side (where it jams into the KY parkway shield):

Seems like spritezero is somehow not properly detecting the edge of the graphic.

The problematic optimization is convertPathData, which I've disabled in 1000314 and re-processed the icons.  Needs a review to confirm we're seeing the expected behavior.

Thanks! I still don’t quite grok all that these plugins are doing, other than being impressed at their ability to resolve transforms. I suspected it might have to do with a lack of precision, since Inkscape’s optimizer defaults to five decimal places while SVGO defaults to three. But I was unsuccessful in configuring the plugin – probably didn’t do it correctly. Maybe at some point we’ll figure it out, but in the meantime, the optimized code looks reasonable compared to Inkscape’s output.


[kinflate] use namePrefix in every reference/direct link

I have some following resources:
one ingress, one svc
---
apiVersion: v1
kind: Service
metadata:
  labels:
    k8s-app: webapp
  name: webapp
spec:
  ports:
  - name: http
    port: 5000
    protocol: TCP
    targetPort: 5000
  selector:
    k8s-app: webapp
  type: ClusterIP

and
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: webapp
spec:
  rules:
  - host: webapp-example.com
    http:
      paths:
      - backend:
          serviceName: webapp
          servicePort: 5000

In this case, using namePrefix isn't practical because I have to edit manually the svc:
- backend:
          serviceName: $namePrefix-webapp
          servicePort: 5000

I would expect a replacement in the serviceName too

this could extend also to how application are parametrized
e.g
env:
  - name: REDIS_HOST
    value: redis://$namePrefix-redis.namespace.svc.cluster.local


fixed paragraph getting outside of box

The paragraph text is getting outside of container .

fixed the issue closes #56  kindly assign me my another issue #55.


WIP: Add million query

This merge request adds all resources + unit tests for processing the TREC Million Query Tracks 2007, 2008, and 2009.
This will enable the regressions mentioned in #1034.
Attention, the Million Query tracks have only used prels, and I have converted them to "inofficial" qrels for simplified evaluation with trec_eval/ndeval.
The transformation from prels to qrels was performed with:
cat prels.mq.1-10000.txt| awk '{print $1 " 0 " $2 " " $3}' > qrels.mq-inofficial.1-10000.txt
cat prels.mq.10001-20000.txt| awk '{print $1 " 0 " $2 " " $3}' > qrels.mq-inofficial.10001-20000.txt
cat prels.mq.20001-60000.txt| awk '{print $1 " 0 " $2 " " $3}' > qrels.mq-inofficial.20001-60000.txt

I think this is ok as long as we explicitly mention that. (Still, it is interesting to try algorithms in such scenarios, especially as those "inofficial" qrels match the ground truth that is used in LETOR 4.0).
Should we add regressions on the new million query resources within this issue or within a next issue?
The following command produces a run file for Million Query 2007, and evaluates it (Index is created with the command mentioned in the gov2 regression):
target/appassembler/bin/SearchCollection -index lucene-index.gov2.pos+docvectors \
 -topicreader Web -topics src/main/resources/topics-and-qrels/topics.mq.1-10000.txt \
 -bm25 -output run.gov2.bm25.mq2007.1-10000.txt

./eval/ndeval/ndeval src/main/resources/topics-and-qrels/qrels.mq-inofficial.1-10000.txt run.gov2.bm25.mq2007.1-10000.txt

Attention, the Million Query tracks have only used prels, and I have converted them to "inofficial" qrels for simplified evaluation with trec_eval/ndeval.

I'm actually not familiar with this...
Is this generally accepted practice? If so, can you add a reference? We can use that as justification...

I don't think that the conversion from prels to qrels is accepted practice.
In fact, they explicitly recommend against it, since prels explicitly includes only a sample of judgments, and no complete relevance judgments like typically assumed for qrels (see the Prels section).
The only reference that is doing that conversion is LETOR 4.0 (but there the case is slightly different since the task is to rerank only judged documents).
I am also fine if we remove those "inofficial qrels".
In that case, we must use mtc_eval for evaluation.
I often preferred to work with those "inofficial qrels" and trec_eval, because mtc_eval is not easy to use (difficult to compile nowadays, segmentation faults at runtime).

Yes, please remove the inofficial qrels and I think this should be ready for merging.

I have removed the inofficial qrels.

Thanks for your contribution!


[it] Readme.md Added words

lgtm

Good morning @lamberta,
the CI/labeler chesk failed on this file.
I just added some words as usual.
Can you explain me why did it fail? (To avoid similar mistakes in the future).
Thank you.
G.


data channel: fixed memory and ref leak in data_channel_close

:+1:

added another fix to this PR while I'm at it

Merged.


Adding native federation to Angular 17.1.1 breaks live reloading of library changes

My project follows a structure where the apps are thin and they pull in libraries. So most of the code for the host or remotes exist in libraries, not the apps.
When I add native federation to an Angular 17.1.1 project, I'm finding that when running the serve command, changes to the libraries is not reflecting. For instance, after changing a component in a library, I see the following:
No output file changes.

Unchanged output files: 4
Application bundle generation complete. [0.073 seconds]

Even if I refresh the page, the changes are not present. I suspect it may have something to do with the cache, but I'm not sure.
Repro is here
https://github.com/franktroia/nf-library-bug
If you run "ng serve test-app" and adjust the test-lib.component.ts, you will see that the library does not reload.
I should also note that reloading of library changes work fine without native federation added. For instance, here is the commit before native federation is added. Here it is working.
https://github.com/franktroia/nf-library-bug/commit/c56f0cd0642b25ae19959460a03c81fd6861d3f0
Any help would be appreciated!

I've been reviewing the plugin and documentation found that adding the libraries package ("@lib/test" from the repro) to the skip array in federation.config.js fixes the issue.
However, is this the right approach for a development environment? I was hoping that all my feature libraries and shared libraries could be iterated during development. I think I'm missing something. Any thoughts?

So, currently, you need to do F5 by yourself.


Avoid allocating instance buffer for PointLight2D shadows when there are no instances

Fixes: https://github.com/godotengine/godot/issues/100609
The problem arises when shadows are enabled, but there are no occluders. The shadow rendering path tries to allocate a zero sized buffer which isn't allowed. The solution is to just not allocate the buffer when there are zero instances. That necessitates also skipping the render loop since we can't bind a buffer that doesn't exist. We still have to create the render pass though to clear the shadow atlas.

Thanks!


Roller Mechanism incorrectly displays a second roller representing its containment position

Roller mechanism should not display as a double image as shown below.
https://twotech.twohoursonelife.com/2263-Roller-Mechanism

Note: this issue is not present on Onetech:
https://onetech.info/2263-Roller-Mechanism

The game already handles this scenario, and twotech should be assumed to be an unrelated program. Twotech should implement the same mechanism that the game does to hide the sprites.

The game isn't exactly hiding the sprites. It's using a work around (in a possibly unintended way).
Essentially the object is animated, but all that animation does is continually completely fade out the sprite. Animations are stored separately, and as far as I can see, not part of the data twotech processes. A much larger change would need to be implemented to give it access to that data, as well as a way to process that into showing the first frame for example.


add tnmc

@thecuong3298 First stage of verification passed, official domain is tump.edu.vn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://benhvien.tump.edu.vn/contact

@thecuong3298 Please provide us with: an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course

@thecuong3298 You might miss my previous comment. Please react.

@thecuong3298 I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Exporter sql api ssl configuration m

@javitonino this is the merge of exporter_sql_api_ssl_configuration branch, which comes from 3.13.x, into exporter_sql_api_ssl_configuration_m for master. It shows too many commits but changes are accurate (everything but a NEWS change that I prefer to keep to avoid merging issues).
I'll merge & deploy this tomorrow unless you have complaints :-)

forget this, cherrypicking...


[Tizen] Split the package into crosswalk-bin and crosswalk-libs.

This is a big pull request, but hopefully both commits here do a good job at
explaining what is going on.
The TL;DR version is that instead of building one single Crosswalk RPM, we
split it into crosswalk-libs (containing all Chromium shared libraries, such as
libbase.so and libcontent.so) and crosswalk-bin (containing the actual
xwalk binary). This is done so that crosswalk-libs does not depend on any
Tizen-specific library and everything in src/xwalk only requires
crosswalk-bin to be rebuilt. The consequence is that crosswalk-libs almost
never needs to be built by developers and crosswalk-bin takes only a few
minutes to build.
In order to do this, we had to do some hacks:

We now build Crosswalk for Tizen with -Dcomponent=shared_library. Since the
libraries are private, they are installed into a private directory so that
other packages cannot use it.
To know which Chromium libraries we need to build for crosswalk-libs, a new
script was added that parses Crosswalk's build dependency graph and outputs
all the targets which are not in src/xwalk.
Conversely, to avoid rebuilding the Chromium libraries in crosswalk-bin, we
apply one big patch that converts several targets in Chromium from 'type': '<(component)' to 'type': 'none' so that they are cause any files to be
built or any dependencies to be processed. Maintaining this patch is costly,
but it did not require many changes when transitioning from M39 to M40.

Building Crosswalk should now require one to specify the spec file to gbs, like
this: gbs build --spec crosswalk-bin.
Please check the commit messages of the two commits in this pull request for
more information on what has been done.
BUG=XWALK-2571

@darktears @pozdnyakov @baleboy @halton @baillaw @kooltux
An earlier version of this patch was already tested by the Eurogiciel people, and I've just tested this version on a Tizen Common daily release.

I lack the knowledge to review the actual change, but in general this is fine by me.

lgtm

lgtm

The version I've just pushed is the same one with the conflicts resolved. I'm going to merge it.


Add support for Azure, OpenAI, Palm, Anthropic, Cohere Models - using litellm

I'm the maintainer of litellm https://github.com/BerriAI/litellm - a simple & light package to call OpenAI, Azure, Cohere, Anthropic, Replicate API Endpoints
This PR adds support for models from all the above mentioned providers (by creating a class liteLLMChatGPTBot)
Here's a sample of how it's used:
from litellm import completion

## set ENV variables
# ENV variables can be set in .env file, too. Example in .env.example
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion("command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

cc @iuiaoin can i get a review on this

@ishaan-jaff Thanks for your pull request! I got a comment for you

@ishaan-jaff LGMT，approved. Yet seems ci failed

@iuiaoin fixed lint errors


crypto/x509 and S/MIME: fix purpose inconsistencies, add missing smime_encrypt

Fix inconsistent doc vs. implementation for purposes smine_sign and smime_encrypt
Add missing purpose smime_encrypt in x509_vpm.c

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago


References to re-named entities do not update until file is reloaded

This might be by design, but in case it's not...
I noticed that entities that I've renamed work OK and update immediately,
but references retain the prior name until I save and reload the file.
I don't remember if it was this was in the old UI.

Ah yes, I reload the current composite entities but forgot ofc that ones that point across composites will also need updating. Thanks for spotting!


📝 Update includes in docs/pt/docs/advanced/additional-responses.md

#12554

Thanks for the effort! :cake:
This was handled in another PR, so I'll close this one now. :coffee:


How to log by epoch for both training and validation on 1.0.0rc4 / 1.0.0rc5 / 1.0.0

What is your question?
I have been trying out pytorch-lightning 1.0.0rc5 and wanted to log only on epoch end for both training and validation while having in the x-axis the epoch number. I noticed that training_epoch_end now does not allow to return anything. Though I noticed that for training I can achieve what I want by doing:
def training_epoch_end(self, outputs):
    loss = compute_epoch_loss_from_outputs(outputs)
    self.log('step', self.trainer.current_epoch)
    self.log('loss', {'train': loss})

It sets the step to be the epoch number and used for the x-axis just as I wanted. I have not found in the documentation if this is how it is intended to be logged. I am also a bit confused about the result objects. Nevertheless, this code seems quite simple and logical, so I thought this could be one of the possible intended ways of logging per epoch.
I tried to do the same for validation as follows:
def validation_epoch_end(self, outputs):
    loss = compute_epoch_loss_from_outputs(outputs)
    self.log('step', self.trainer.current_epoch)
    self.log('loss', {'valid': loss})

However, in the case of validation the x-axis is the number of batches in validation and an additional step graph appears in tensorboard.
Based on this I have some questions. Is this an intended way of logging per epoch? If yes, is the idea that the same behavior is obtained for both training and validation? If this is not the intended way of logging per epoch, where can I read about how this is planned for version 1.0.0?
What's your environment?

OS: Linux
Packaging: pip
Version: 1.0.0rc5

using
self.log('metric_name', metric_value, on_step=False, on_epoch=True)

both in training_step and training_epoch_end, it will log the metric against the global_step. It will also log the epoch values separately so you can create a new panel in your logger UI (for eg Wandb) and put epoch on the x-axis and metric_name on the y-axis.

@ndrplz @rohitgr7 thank you for your responses. In the documentation I have read that on_step and on_epoch are automatically set depending on the context. So from my understanding logging from the *_epoch_end is equivalent to that.
The self.logger.experiment workaround certainly could work. However, one of the motivations I had for creating this issue was in part trying to figure out if this is an unintended behaviour and maybe help out to make pytorch-lightning more consistent. If there is code that treats step in a special way when logging from training_epoch_end, I would figure that it would make sense that validation_epoch_end also has this behaviour.

treats step in a special way when logging from training_epoch_end

you will get an error in such case.

@rohitgr7 I am not sure what you mean that I will get an error. I have tried this and I don't get any errors. By default pytorch-lightning logs to tensorboard so I am using that. When I do this I get both losses in the same graph. For training the values used for the x-axis is the epoch (as I want) but for validation it is the number of batches, so the two curves don't align. I have also tried with v1.0.0 that was released today and I get the same behaviour.
This is related to https://github.com/PyTorchLightning/pytorch-lightning/blob/1.0.0/pytorch_lightning/trainer/connectors/logger_connector.py#L84-L90 . When log_metrics is called for training the value of the step argument is None so the if statement evaluates to True and the step gets assigned the value that I gave. But for validation the step argument has as value the number of batches so the value of step is not overridden.

by step, I thought you mean self.log(..., on_step=True) in *_epoch_end.
By default, all the logs are logged with step=global_step for consistency although epoch is also logged alongside. So you can alter or create a new log frame in your logger UI (for eg Wandb) and put epoch on the x-axis and metric_value on the y-axis.

you want to log by step=epoch in both train_epoch_end and step=number_of_batches in validation_epoch_end?

No, I want step=epoch for both train_epoch_end and validation_epoch_end. What you say is the unexpected behaviour I am getting that I don't want.
Also I expect this to work with the defaults (tensorboard) and without needing to select what the x-axis should be.

ok got it, let me check.

Maybe there is a bug in line https://github.com/PyTorchLightning/pytorch-lightning/blob/1.0.0/pytorch_lightning/trainer/connectors/logger_connector.py#L202. The step argument should not be given. Anyway it will get the global_step value because of line https://github.com/PyTorchLightning/pytorch-lightning/blob/1.0.0/pytorch_lightning/trainer/connectors/logger_connector.py#L90.
Also in https://github.com/PyTorchLightning/pytorch-lightning/blob/1.0.0/pytorch_lightning/trainer/connectors/logger_connector.py#L90 it does not make sense to have step = step if step is not None ... since it is inside an if that checks if step is None.

yeah good catch, verified this is a bug. Mind send a PR?
step = step if step is not None ..
yeah this can be improved.

Yes, I can create a pull request for this.

This:

def training_step:
   return loss

def training_epoch_end(outs):
    self.log('avg_loss', outs.mean())

is the same as:
def training_step:
   self.log('avg_loss', on_step=False, on_epoch=True)
   return loss

If you still need to log something on epoch end, then just call self.log

def training_epoch_end(outs):
    some_val = ...
    self.log('some_val', some_val)

@williamFalcon thank you for the response. Please note that I am not interested in logging validation in each step. I completely agree, this does not make sense. I only want to log validation values on validation_epoch_end. In my example it is for loss but that is not important, the same question holds for some_val.
Furthermore, if for both training and validation values are only logged at epoch end as in the example, then both can be plotted on the same graph precisely showing the change in distribution over time. Both can be plotted in the same graph because the values correspond to the same points in time (epoch end). This is already done automatically by PL with my example snippets at the top but removing the self.log('step', .... The issue is that I want to override the step to be batch instead of global_step. This overriding of step works for training but not for validation. If users are allowed to override step for training for consistency it makes sense that it can also be overridden for validation.

To clarify a bit further, I want to do
def training_epoch_end(self, outputs):
    some_val = ...
    self.log('step', self.trainer.current_epoch)
    self.log('some_val', {'train': some_val})

def validation_epoch_end(self, outputs):
    some_val = ...
    self.log('step', self.trainer.current_epoch)
    self.log('some_val', {'valid': some_val})

Expecting to get a graph where I see 'some_val` for both training and validation which would look like

It is useful for me to observe in a single the same value for both training and validation for comparable time intervals. I also want the x-axis because of several reasons. One of them is that I want to use GradientAccumulationScheduler which means that in each epoch the number of steps can be different. If I use number of steps then the points in the x-axis would not be uniformly distributed.

@mauvilsa I guess you wanted to write that you want the x-axis to mark the epoch not the batch :)

I've been running into the same problem since I updated to 1.0.0. For some reason, the metrics I log in my validation step no longer have an epoch associated with them. I am using the CSVLogger and the epoch value for any of validation metrics is empty while the step value is present.

This has now come up multiple times and I have a strong opinion here. To me, it is 100% clear that logging on epoch makes no sense. Note the emphasis on logging, which I see as separate of "visualization".

Do not confuse a logger with a plotting/graphing tool.
Set val_check_interval < 1 and your plot now shows multiple values per one epoch in the plot. Is that what you want? "But why would I want to validate more than once per epoch?". You almost ALWAYS want to do that, because your datasets are huge and an epoch takes a long time.
Changing the abscissa and ordinate can make sense, but it SHOULD NOT be something a user has to decide before the training. Modern loggers (not TensorBoard) have solved this problem a long time ago: You log your metric as a function of step, and you log the epoch as a function of step. Then in the UI, you can map the abscissa of your metric plot to the epoch. In fact, you would be able to do that with ANY metric that is monotoncially increasing. You can find this in e.g. wandb.
If I run 2 experiments, where the difference is the dataset, and the datasets are not equal size, there are two ways to compare: 1. compare the validation losses at epoch intervals. 2. compare validation losses after n steps. Both ways of comparing are valid, only the interpretation changes. With your proposed change, you eliminate the 2nd.
...

These are just a couple of reasons, I could probably give you 20 more.
I see two options: 1. make a feature request in TensorBoard 2. Let TensorBoard go

@awaelchli thank you very much for your comment, it certainly adds value to the discussion. I am not much concerned about plotting or tensorboard in particular. I added the plot just to clarify the issue. For me logging is just about storing values at certain points during training. Surely with a huge dataset people might want to validate more than once per epoch. Also I have no issue in associating values to steps, certainly that makes sense in many cases. However, as I mentioned in a previous comment, I am using GradientAccumulationScheduler which means that each epoch does not have the same number of steps, thus a simple thing to do is associate values to epochs.
Could I do something different while using GradientAccumulationScheduler? Probably I can. But for me this is not the main point of this discussion. The main point is that pytorch-lightning should give freedom to the user to do as they need depending on the case. Being able to override step when logging is a nice feature to have to provide flexibility to the users. The issue is that right now the behavior of pytorch-lightning is inconsistent. The step can be overridden for training, but it does not work for validation.

Set val_check_interval < 1 and your plot now shows multiple values per one epoch in the plot.

good point.
But still, if someone adds step in the .log, IMO we should still replace the step with this value on the x-axis? WDYT?

But still, if someone adds step in the .log, IMO we should still replace the step with this value on the x-axis? WDYT?

as long as the default behaviour we have right now is not changed, I have not objections.

@awaelchli by default, it does not allow changing step in validation_epoch_end, that's what the PR is trying to solve but 1 test is failing there.

The issue is that right now the behavior of pytorch-lightning is inconsistent. The step can be overridden for training, but it does not work for validation.

Yes, this is because in validation, we typically don't want to increase step and accumulate instead. If this is an optional feature to be added, I have no objections.

@awaelchli yes, this is just an optional feature. Maybe could you please comment in pull request #4130 saying that you don't have objections or better yet review it? Still in that pull request we need feedback to decide about what to do with a line already in the code that automatically logs epoch which with the change makes the unit tests fail.


User Agent Settings

I can't figure out, how to set the User Agent.
WhatsApp for example does not work with the default settings of Nativefier.
when I flag -u nothing changes
like -u "Chrome"
what are the values that go after the -u flag?

You have to enter in a user agent string after the -u flag. For example:
$ nativefier google.com -u "Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2228.0 Safari/537.36" ~/Desktop

You can google around to find example user agent strings, I simply copied it from http://www.useragentstring.com/pages/Chrome/

I get it ;) thanks - i tought there would be shorthands


small bug in yumi_gripper.py

In yumi_gripper.py, the names of some parameters are not correct: tcp_jntid should be tcp_jnt_id

Fixed. Thanks!


add support for Harmony

add Harmony mainnet and testnet info
add Harmony multicall smc address

@jhd2best Thanks for your PR! Could you also add an image here: https://github.com/snapshot-labs/snapshot.js/tree/master/src/networks image from Twitter will work well.

@bonustrack already added logo in networks dir.


Blob upload input stream overwrite bug

API change check
API changes are not detected in this pull request.

/azp run java - storage - tests

/check-enforcer override


Fix jsFiddles that rely on prettyPrint

Some jsFiddles (don't know how many) rely on a prettyPrint library that was hosted at http://public.werelate.org/prettyprint.js. That now returns a 403 which breaks any jsFiddle that relies on it.

Looks like the prettyprint.js library that was being used is this one: https://github.com/padolsey-archive/prettyprint.js
I wonder if there is a CDN hosting this somewhere.

http://james.padolsey.com/javascript/prettyprint-for-javascript/

It's not on any CDN that I could find. Let's use RawGit for now. The jsFiddles traffic will be very light.


Organizations are listed twice in queried data (both times with the same identifier)

When creating a list of organizations related to the corpus (such as publishers), we see an authority with the same identifier twice.
Checking with the following SPARQL query revealed several things which could cause duplicate rows in the output

there are several labels in different languages
organizations are additionally typed as persons

Especially the latter likely caused the creation of two authority records in the integrated data (see first two result rows).
prefix schema: <http://schema.org/>
prefix bf: <http://id.loc.gov/ontologies/bibframe/>

SELECT *
WHERE {

  graph ?g { ?identifierEntity rdf:value "14587602" . }

  OPTIONAL { graph ?g { ?authority bf:identifiedBy ?identifierEntity ;
                             schema:name ?schemaLabel . }
  }

  OPTIONAL { graph ?g { ?authority bf:identifiedBy ?identifierEntity ;
                             rdfs:label ?rdfsLabel . }
  }

  BIND(lang(?schemaLabel) as ?schemaLabelLanguage)
  BIND(lang(?rdfsLabel) as ?rdfsLabelLanguage)

  {
    SELECT ?authority (GROUP_CONCAT(DISTINCT ?type; SEPARATOR=",") AS ?types)
    WHERE {
      ?authority rdf:type ?type ;
                 bf:identifiedBy/rdf:value "14587602" .
    }
    GROUP BY ?authority
  }
}

This was fixed in #182
For the last corpus versions the dump for KBR persons and the dump for KBR organizations was named wrong which caused a switching (persons were organizations and organizations were persons).
A separate dump of KBR Belgians was annotated correctly, thus certain KBR authorities got a correct type annotation via the KBR Belgian dump and a wrong via the other dumps.


feat(showcase): use url of first valid image file extension found

Updates the showcase logic to use the url of the first valid image file extension found in the attachments array.
Closes #51

Merged in https://github.com/40-percent/40percent-bot/pull/53


Compbiomed devel

Vignette - Updated new fxn names, deleted PBMC analysis section, which will go into tutorial
semi_pheatmap - Labels were off when unsupervised clustering was on, fixed

Pull Request Test Coverage Report for Build 582

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 95.559%

Totals

Change from base Build 581:
0.003%

Covered Lines:
2496

Relevant Lines:
2612

💛  - Coveralls


[FEATURE] facilities for post-processing editing of meta.yaml

Is your feature request related to a problem? Please describe.
A lot of issues might be addressed by some post-processor functionality (or a guide for post-processing) the meta.yaml files produced by grayskull. This would be particularly useful for CI setups I think.
Describe the solution you'd like
After meta.yaml is processed, edit the file using python code or CLI so as to add certain values to certain fields.
Additional context
#253 #243

Closing this in favor of souschef