Facebook/Google login

Hello,
Thank you for this excellent tool. I was wondering if you can provide an example using Facebook or Google login.
I tried but I faced CORS issues.
Thanks for your help !

Currently, I don't have the resources for it. But the lib should work with every AuthServer that is supporting implicit flow or password flow.

file auth.config.ts
import { AuthConfig } from 'angular-oauth2-oidc';
export const authConfig: AuthConfig = {
issuer: 'https://accounts.google.com',
redirectUri: window.location.origin + '/oauth2callback',
clientId: '<you_app_client_id>',
dummyClientSecret: '<you_app_client_secret>',
strictDiscoveryDocumentValidation: false,
scope: 'openid profile email',
showDebugInformation: false
}

can you provide working example?


NumPy compatibility enhancements

PR types

Others
PR changes

Others
Describe

This pull request includes several changes to improve code consistency and readability in the paddlespeech/s2t/models directory. The changes primarily focus on updating data type usage, reformatting code for better readability, and organizing import statements.
Data Type Updates:

Updated the data type from np.bool to bool in modeling_wav2vec2.py for spec_aug_mask and mask_time_indices. [1] [2]

Code Reformatting:

Reformatted various function definitions and calls to improve readability by adjusting spacing and line breaks in wavlm_paddle.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]

Import Statement Organization:

Reorganized import statements to follow a consistent style in wavlm_paddle.py.

reference

https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Why change np.int to int? In terms of compatibility, I prefer using np.int because it's easier to maintain version compatibility with NumPy than with Python if the default types change. Or maybe you have other considerations?


Remove Class DNU when references are found

When removing a class, the RB remove class command fail with an exception if references are present.
Should handle the exception with the appropriate dialog

Hnadle browsing according to RB. In progress on the Pharo5 branch


New version: JetBrains.RubyMine.EarlyAccess version 221.5080.4

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 465
Microsoft Reviewers: Open in CodeFlow

/azp run


README

README file
The read me file needs to be of a good quality standard with description, screenshot, and link to deployed application.

Added description


Can't get connector to run on a raspberry pi zero

I can't get this running on a pi zero.
Docker installs ok (I tried suggestions on the internet to downgrade docker but connector still won't run) so not sure if this is a docker issue or mi connector container issue as I'm not too familiar with docker. I can get it running on a pi 3 but I only need this to be in my IOT Vlan so can't justify the cost of a pi3/4 just for this app.
Any ideas?

Update - the container keeps restarting and the logs show a segmentation fault.
@fison67 is it possible to get a container built for arm6? Alternatively a manual install version that does not require docker?

I didn't make a armv6 docker image.
Only support amd64, arm64, armv7.
If you want manual install, pull a files from docker container.
/usr/src/app

Thanks - I used an arm7 device instead.


Common API

The main idea is to come upt with a solution to mimic what HIP does for CUDA.
Ideally, we could run any TRT apps with MGX without any code change. But we could also do something similar what hipify does to convert the code to a Common API.

I created a separate issue for the initial stage: #187

We started working on a C++ API equivalent to TensorRT's API. The only difference between the APIs, for now, is the namespaces (nvinfer1 -> mgxinfer1 and nvonnxparser -> mgxonnxparser). We can consider even keeping the same namespace later on. The code can be found here. At the moment, the new API is just a wrapper around the existing MIGraphX API. No modification of MIGraphX internals was needed. With this, we can successfully run the MNIST TensorRT sample.

TensorRT has specific object lifetime rules. Some classes are factories for others and need to outlive them. Some return pointers to internal objects whose lifetime is not managed by the user. For now, we don't focus too much on these rules and just use smart pointers to ensure there are no dangling references.

Dynamic shapes are handled differently between the two APIs. TensorRT expects the dynamic shapes after parsing, but before compilation, whereas MIGraphX expects the shapes during parsing. A workaround would be to replace the specific instructions after parsing. As discussed with the AMD team, the dynamic shapes support in MIGraphX is currently lacking, so we'll focus on that a bit later.

The TensorRT ONNX parser is open source with an Apache 2.0 license. This could prove useful later on with more complicated scripts that modify the network after creating it from an ONNX file.


Missing dot

Hi, I have this set up:
$(document).ready(function(){       $("#monogram").inputmask("(aa)|(a.a.)|(aaa)|(aa.a.)|(a.aa.)",{ showMaskOnHover: false, placeholder: " ", casing: "upper" });     });
Once the user use it here https://goo.gl/Zu9sz2 and writes "D.P" mask automatically shows the second dot. But once the input is not active it's without the dot. Am I doing something wrong? It should be with both dots or without any.
Second problem is how can I add Czech characters like "ščřžýý"? Thanks a lot for your help.

@danielpiterak ,
I will have a look at the first.
For the second you need to extend the regex definition in the a definition. You may send a PR for it.

@danielpiterak ,
A quick fix is to just add the clearMaskOnLostFocus: false option.
This disables the clearOptionalTail function, which causes the removal of the dot.


Update AutoDiff to handle vector functions with multiple real scalar inputs

I also made a couple of additional updates to some methods (e.g., log and exp functions can now handle any base).

Codecov Report

Merging #25 into master will decrease coverage by 2.07%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage    99.3%   97.22%   -2.08%
==========================================
  Files           1        1
  Lines         143      144       +1
==========================================
- Hits          142      140       -2
- Misses          1        4       +3

Impacted Files
Coverage Δ

AnnoDomini/AutoDiff.py
97.22% <76.92%> (-2.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7cc3a...5470d0c. Read the comment docs.


Payment Status Does Not Update After Payment

Brief Description: after paying for a purchase, the status of the purchase still shows as pending, and does not update even though the seller sees the same purchase as paid for.
See client issue: https://github.com/OpenBazaar/OpenBazaar-Client/issues/1019

This can only happen if the libbitcoin server doesn't return for either one.

I'm also experiencing this issue. I've made a payment to a merchant, and although the payment is showing with >6 confirmation on the blockchain, Open Bazaar is reporting 'Payment pending'.
I believe this also prevents the merchant from seeing my shipping address, as they had to contact me via chat to retrieve it. The shipping tab shows entirely blank.

This may or may not be related, though, the result is the same for me. However, I get an error...
`Unhandled error in Deferred:
2016-04-12 05:57:26+0000 [-] Unhandled error in Deferred:
Traceback (most recent call last):
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1194, in run
self.mainLoop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1203, in mainLoop
self.runUntilCurrent()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 825, in runUntilCurrent
call.func(*call.args, **call.kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/task.py", line 239, in call
d = defer.maybeDeferred(self.f, *self.a, **self.kw)
---  ---
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 150, in maybeDeferred
result = f(*args, **kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 36, in poll
while self.poll_once():
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 45, in poll_once
self._cb(data, more)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 126, in frame_received
self.on_raw_message(id, command, data)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 54, in on_raw_message
self.trigger_callbacks(id, *res)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 89, in trigger_callbacks
self._subscriptionstx_id
File "/home/openbazaar/OpenBazaar-Server/market/contracts.py", line 1400, in history_fetched
c.payment_received()
File "/home/openbazaar/OpenBazaar-Server/market/contracts.py", line 870, in payment_received
if self.db.purchase.get_status(order_id) == 0:
exceptions.AttributeError: 'Database' object has no attribute 'purchase'
2016-04-12 05:57:26+0000 [-] Unhandled Error
Traceback (most recent call last):
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1194, in run
self.mainLoop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1203, in mainLoop
self.runUntilCurrent()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 825, in runUntilCurrent
call.func(*call.args, **call.kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/task.py", line 239, in call
d = defer.maybeDeferred(self.f, *self.a, **self.kw)
---  ---
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 150, in maybeDeferred
result = f(*args, **kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 36, in poll
while self.poll_once():
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 45, in poll_once
self._cb(data, more)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 126, in frame_received
self.on_raw_message(id, command, data)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 54, in on_raw_message
self.trigger_callbacks(id, *res)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 89, in trigger_callbacks
self._subscriptionstx_id
File "/home/openbazaar/OpenBazaar-Server/market/contracts.py", line 1400, in history_fetched
c.payment_received()
File "/home/openbazaar/OpenBazaar-Server/market/contracts.py", line 870, in payment_received
if self.db.purchase.get_status(order_id) == 0:
exceptions.AttributeError: 'Database' object has no attribute 'purchase'`

I'm also getting this error that seems related...
016-04-12 06:16:56+0000 [-] [ERROR] Libbitcoin server timed out. Refreshing socket and resending requests.
Unhandled Error
Traceback (most recent call last):
File "openbazaard.py", line 266, in start
int(args.heartbeatport), time.time())
File "openbazaard.py", line 198, in run
reactor.run()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1194, in run
self.mainLoop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1203, in mainLoop
self.runUntilCurrent()
---  ---
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 825, in runUntilCurrent
call.func(*call.args, **call.kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/client.py", line 103, in _reconnect
return ClientBase._reconnect(self)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 95, in _reconnect
self._socket.close()
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 54, in close
self.loop.stop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/task.py", line 202, in stop
assert self.running, ("Tried to stop a LoopingCall that was "
exceptions.AssertionError: Tried to stop a LoopingCall that was not running.
2016-04-12 06:16:56+0000 [-] Unhandled Error
Traceback (most recent call last):
File "openbazaard.py", line 266, in start
int(args.heartbeatport), time.time())
File "openbazaard.py", line 198, in run
reactor.run()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1194, in run
self.mainLoop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 1203, in mainLoop
self.runUntilCurrent()
---  ---
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/base.py", line 825, in runUntilCurrent
call.func(*call.args, **call.kw)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/client.py", line 103, in _reconnect
return ClientBase._reconnect(self)
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmqbase.py", line 95, in _reconnect
self._socket.close()
File "/home/openbazaar/.local/lib/python2.7/site-packages/obelisk/zmq_fallback.py", line 54, in close
self.loop.stop()
File "/home/openbazaar/.local/lib/python2.7/site-packages/twisted/internet/task.py", line 202, in stop
assert self.running, ("Tried to stop a LoopingCall that was "
exceptions.AssertionError: Tried to stop a LoopingCall that was not running.

Alright, the two errors above have been attributed to a now fixed issue (https://github.com/OpenBazaar/OpenBazaar-Server/commit/879dfd37d8a34b602c63dface6c6f02e6319c585#commitcomment-17071666) and libbitcoin server availability... I have no more issues here :)

Is this is still an issue @jjeffryes and @cpacia ? Please close if it's not.


MD5 checker does not display on FurAffinity "Modern" template

The sourcing script does not display MD5 checks or the "Upload to e621" button when viewing FA posts with the Modern template enabled.
Example URLs tested by toggling between Classic and Modern under Account Settings :
https://www.furaffinity.net/view/24356189/
https://www.furaffinity.net/view/26348050/
Additional info:
Prior to adjustments for compatibility with the e621 update, MD5s were displayed to the left of the Views/Comments/Favorites/Rating section in the top right of a post page, displacing the text. For the purpose of convenience, retaining placement in the top right would prevent unnecessary page scrolls to check MD5s.

Solved in commit b00f29d5443fc466dbebe1345b587f515221845f.
Changing selectors was all that was required.


[PDI-13987] “Text file output” step writes field to the file with different encoding (binary data with different encoding, lazy conversion)

update output Row and input Row meta for 2 and more sources
fixed writing encode for "fast data dump" off

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/step/BaseStep.java
  engine/src/org/pentaho/di/trans/steps/textfileoutput/TextFileOutput.java
  engine/test-src/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.01%:small_red_triangle_down:
Complexity Change: -1.06%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .04%
Complexity Change: -.07%:small_red_triangle_down:
Instruction Change:  + .05%

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 3.12%
Complexity Change:  + 3.16%
Instruction Change:  + .28%
Line Change:  + .74%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapinput.LDAPInputMeta

Branch Change: -1.61%:small_red_triangle_down:
Complexity Change: -.97%:small_red_triangle_down:
Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:
Instruction Change: -.18%:small_red_triangle_down:
Line Change: -.48%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2.04%:small_red_triangle_down:
Complexity Change: -2.04%:small_red_triangle_down:
Instruction Change: -.32%:small_red_triangle_down:
Line Change: -.81%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileoutput.TextFileOutput

Branch Change:  + 4.47%
Complexity Change:  + 3.38%
Instruction Change:  + 3.31%
Line Change:  + 3.78%
Method Change:  + 3.85%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/test-src/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputTest.java

:heavy_exclamation_mark: '(' is preceded with whitespace. at Line: 626 Column: 47

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/step/BaseStep.java
  engine/src/org/pentaho/di/trans/steps/textfileoutput/TextFileOutput.java
  engine/test-src/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .04%
Complexity Change: -.07%:small_red_triangle_down:
Instruction Change:  + .05%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change:  + .09%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .31%
Instruction Change:  + .06%
Line Change: -.23%:small_red_triangle_down:
Method Change: -1.02%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileoutput.TextFileOutput

Branch Change:  + 4.47%
Complexity Change:  + 3.38%
Instruction Change:  + 3.31%
Line Change:  + 3.78%
Method Change:  + 3.85%


Customizing Relay State

Currently, Samly only sets random relay state value.
However, our product requires setting a specific value, such as a URL, as the relay state.
This Pull Request adds support for setting a specific relay state value, through configuration setting.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create a notification when an exporting compile fails

Description
closes #3983
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] ~End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )~

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in d92ca63e19830d6a8eb947fe5919bbddc6995722

Processing #4014.


oauth: initial scaffolding

Description
Fixes https://github.com/dust-tt/dust/issues/6122
Scaffolding of the new oauth "core/front" service
types

OAuthAPI standard client library to interact with the oauth service

createConnection creates a new pending OAuthConnectionType
finalizeConnection finalizes the connection based on the received authorization code

front

lib/api/oauth.ts exposes:

createConnectionAndGetRedirectURL used by the setup front endpoint (egress setup redirect)
finalizeConnection used by the finalize endpoint (ingress return of the user)
very pragmatic / succinct strategies per provider to generate URLs and extract connectionId and code from return URLs. See  PROVIDER_STRATEGIES.

pages/w/[wId]/oauth/[provider]/setup.tsx page to redirect users for setup (authenticated with Authenticator)

pages/oauth/[provider]/finalize.tsx return page authenticated (but no Authenticator as URL must be fixed)

core/oauth

new oauth binary that exposes the Connection creation and finalization endpoint
oauth/store.rs interface to the new DB
oauth/connection.rs generic implementation, will enforce distributed locking for refresh
oauth/providers/... provider specific strategies to finalize and refresh tokens
As discussed Connection.connection_id is generated from the row_id and the secret of the Connection which is entirely abstracted by the store and helper functions in connection.rs

Not implemented yet:

token refresh
per provider finalization
salting of DB

Right now it's possible to run an end-to-end "setup" flow with Github on a new dust-data-sources-test app:

(i) visit http://localhost:3000/w/UriWRtz9C3/oauth/github/setup?useCase=connection
(ii) gets redirected to Github + setup there
(iii) gets redirect back to front on http://localhost:3000/oauth/github/finalize?installation_id=52689080&setup_action=update&state=con_Td1Rn5QaMW-29b3168580746bd5f61c432c1c331c21e8be3b6ac078fb8c2135e3a367b57089 which calls into oauth to finalize and go all the way the GithubConnectionProvider dummy implementation:

Finalize for "github"/con_Bfj3oHJlRZ-eb8b9e42e66c498da062d16db349d33a4198026b4bd8e01281ea98b72f6761f2

Next steps (while entirely in development, without deploying anything)

Implement salting of DB
Implement connection.rs generic logic
Implement refresh of tokens
Implement GithubConnectionProvider all the way to and end-to-end functioning system
Implement Notion and Confluence end-to-end

Will start tracking the env-variable we will have to rely on in https://www.notion.so/dust-tt/Remove-Nango-72fdcee1b51a49d3bcb4dd5a2fb93bf0?pvs=4#528cf403fd5f44b9b2b10aac172d49cc
Risk
None. Service is not built, front endpoints are not tied to anything and will just error safely in prod. oauth is not deployed.
Deploy Plan

N/A

@PopDaph @lasryaric merging to continue working on it, please review and comment if you see anything you'd like changed :pray:


INVERTED,LAGGY AND WRONG POTISION PS MOVE CONTROLLS IN STEAMVR

When I start the calibration tool and configure everything the tracking pose is working smoothly, but when I move the first controller foward, it moves left and the seccond controller is inverted. In SteamVR its inverted, laggy and at the wrong position.
My setup:
deepoon e2 (works perfect)
2 ps3eye cameras :    First is 163 cm high and the seccond is 160 cm high. The distance of each other is 180 cm. and my free space from the cameras are 220x140 cm
I tried:

Recalibrating the controllers. (On the magnemeter recalibration I calibrated 1 minute after 100% to fill all sphere with dots)
Turning off the lightes in my room and recalibrated color calibration and traking pose with the calibration mat
In SteamVR Start+Select with all combinations possible.

video (MY HMD DOESN'T WORKING AT THIS VIDEO AND THE CONTROLS ARE started+selected on the head):
https://www.youtube.com/watch?v=qYULxC94c2w&feature=youtu.be
[PsMove appdata content.zip] - uploaded before capturing the videos
(https://github.com/cboulay/PSMoveService/files/1485514/PsMove.appdata.content.zip)

please help me fast

Fixed! I buyed another camera and maded the calibration again at correct angle and added 10fps.

wait so all you did was add another camera and it worked fine? Did you add it to the back of the setup?


Write some User Stories

Already adding User Stories by 3 roles which is Event Organizer, Event Participant and Admin (Platform Manager)


Update disaster-recovery-using-vmware-site-recovery-manager.md

AVS service limits have been consolidated in one location: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#azure-vmware-solution-limits

@rvandenbedem : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Roll Flutter Engine from 85516ecc0e4c to e68ce717ac0a (1 revision)

https://github.com/flutter/engine/compare/85516ecc0e4c...e68ce717ac0a
2023-05-03<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Missing Dependencies, Generators, etc.

Adding the lgi luaPackage unfortunately does not add the required library, gobject-inspection, or the used tool, cairo. I think you need to add those to the propagatedBuildInputs.
Additionally, since you use install in your installPhase, the child objects don't get added to the derivation.
Lastly, the call to require("generators/" .. args[1]) isn't portable, since that calls from the runtime directory, instead of the current working directory.
This is a really cool project, and I'd like to use it myself, but it's missing a little. I'd recommend adding a devShell to the flake and building it as an app so you can use nix run, but those are extensions on the project.
Edit: Not sure at all about the second and third points anymore, but the first one looks to work with just buildInputs.

Thanks, for the hints! I'll look into the points and try to make it easier to use. I'm using it myself without problems but that might be due to my specific setup. If you are more experienced with nix than me and want to give it a try, I'd also welcome PR's ;)

I added the generators to the flake output. nix build now creates a result with the correct files. I haven't been able to fix nix run yet, keep getting this  error:
(process:2139067): GLib-GObject-WARNING **: 10:24:57.368: cannot retrieve class for invalid (unclassed) type '<invalid>'

(process:2139067): GLib-GObject-WARNING **: 10:24:57.369: cannot retrieve class for invalid (unclassed) type '<invalid>'
/nix/store/j3v13kmaby3w18sb4g8xdz2qpmarvv66-lua-5.2.4/bin/lua: ...h7r2hidljs53zn7w-lua-5.2.4-env/share/lua/5.2/lgi/ffi.lua:84: bad argument #1 to 'cast' (lgi.record expected, got nil)
stack traceback:
        [C]: in function 'cast'
        ...h7r2hidljs53zn7w-lua-5.2.4-env/share/lua/5.2/lgi/ffi.lua:84: in function 'load_enum'
        ...3zn7w-lua-5.2.4-env/share/lua/5.2/lgi/override/cairo.lua:45: in main chunk
        [C]: in function 'require'
        ...dljs53zn7w-lua-5.2.4-env/share/lua/5.2/lgi/namespace.lua:183: in function <...dljs53zn7w-lua-5.2.4-env/share/lua/5.2/lgi/namespace.lua:155>
        (...tail calls...)
        ...wallpaper-generator-1.0/bin/.wallpaper-generator-wrapped:4: in main chunk
        [C]: in ?

@houstdav000 Do you have any ideas what causes this? I't running fine in the CI, but I get this error locally and can't figure out what the problem is.

That's the exact same error I kept running into and have been trying to figure out. I think it's that the runtime can't find the required C libraries from Cairo and gobject-introspection, considering the failing line is the require statement. Thing is that I'm unsure how to patch Lua require statements to get it to work, and that's what I was playing around with. Just adding the packages to the path or adding the lib folders with a fill indicator to LUA_CPATH didn't fix it, which makes me wonder if the require statements need to be rewritten to specify versions or something like that.
I tried looking at other default.nix or flake.nix files for ideas on how to solve this, but couldn't find a single other example of someone writing and packaging a custom script...
I originally got it to work when writing a devShell and invoking either main.lua or nix run from the package with that environment dynamically loaded by nix-direnv, which needs more inspection to me.
I might have some more time to look at it on Friday

Would be really nice if you find the time, I'm at a loss here. What puzzles me even more, is that it works just fine in the CI, see here: https://drone.lounge.rocks/pinpox/wallpaper-generator/30

I went to go take another look at this and it...seems to work. I do not understand why though

I can confirm it seems to work now

I don't know what to tell you. I'm on NixOS and everything
> nix run github:pinpox/wallpaper-generator -- harmonograph
Running generator: harmonograph

Wait, I see now, it's not using gobject-introspection, it's using glib! That must be the dependency instead

Try replacing gobject-introspection in /flake.nix with glib and lmk if that works

Modified flake.nix like this:
diff --git a/flake.nix b/flake.nix
index 6224912..ba7c5fc 100644
--- a/flake.nix
+++ b/flake.nix
@@ -28,7 +28,8 @@
           pkgs.luaPackages.luafilesystem
           pkgs.luaPackages.argparse
           pkgs.cairo
-          pkgs.gobject-introspection
+          # pkgs.gobject-introspection
+          pkgs.glib
         ];

       in rec {

But still get the error:
✦ ×  nix run '.' -- harmonograph
warning: Git tree '/home/pinpox/code/github.com/pinpox/wallpaper-generator' is dirty

(process:325220): GLib-GObject-WARNING **: 10:45:28.860: cannot retrieve class for invalid (unclassed) type '<invalid>'

(process:325220): GLib-GObject-WARNING **: 10:45:28.863: cannot retrieve class for invalid (unclassed) type '<invalid>'
/nix/store/h7hxlq55l6v4gmxy1sx8wkllqdas0dw6-lua-5.2.4/bin/lua: ...psk3gbi0h5156p5h-lua-5.2.4-env/share/lua/5.2/lgi/ffi.lua:84: bad argument #1 to 'cast' (lgi.record expected, got nil)
stack traceback:
        [C]: in function 'cast'
        ...psk3gbi0h5156p5h-lua-5.2.4-env/share/lua/5.2/lgi/ffi.lua:84: in function 'load_enum'
        ...56p5h-lua-5.2.4-env/share/lua/5.2/lgi/override/cairo.lua:45: in main chunk
        [C]: in function 'require'
        ...i0h5156p5h-lua-5.2.4-env/share/lua/5.2/lgi/namespace.lua:183: in function <...i0h5156p5h-lua-5.2.4-env/share/lua/5.2/lgi/namespace.lua:155>
        (...tail calls...)
        ...wallpaper-generator-1.0/bin/.wallpaper-generator-wrapped:4: in main chunk
        [C]: in ?

        ```

Hmm, looking through an strace, I can see library loads from glib, libffi, cairo, and gobject-introspection. So if all of those get loaded as libraries, let me check nixpkgs a little to see what dependencies they define for cairo and gobject-introspection.


FP mitigation on flashbot bot

Could we filter out just plain EOA to EOA value tx on the flashbot bot? I understand it has caused some FPs downstream on the attack detector.

Fixed.


WIP feat(rust): create ockam_transport_core crate for generic transport code

WIP Rebase of feat(rust): create ockam_transport_core crate for generic transport code

Need to run the gradle jobs which creates the GitHub Actions for a new crate.

@metaclips This adds a new crate, so it will be a good opportunity to pair and make sure we get everything set up properly for it. New Actions, updating community metric script, etc. Let's find some time to chat about it.


Range

I got email:

Dear Mr. Nagórski,
we are trying to serialize using the ExtendedXmlSerializer.
Unfortunately the latest version we can use is 2.0.0. Its working great
in general. But we have a problem to serialize Range. Serialization
is working fine, but not the deserialization.
We would appreciate it very much, if You had a quick look at the
problem, maybe you have an idea for a fix or workaround. Thank you very
much!
Here is how we build the Serializer:
IExtendedXmlSerializer XmlSerializer = new ConfigurationContainer()
.ConfigureType().EnableReferences(m => m.Id)
.Type().CustomSerializer(new
JahrMonatSerializer())
.Type<Range>().CustomSerializer(rangeSerializer).Name("RangeInt").Create();
And here is the custom serializer:
public class RangeIntSerializer : IExtendedXmlCustomSerializer<Range>
{
public Range Deserialize(XElement element)
{
return new Range(
int.Parse(element.Member(nameof(Range.Min)).Value),
int.Parse(element.Member(nameof(Range.Max)).Value));
}
    public void Serializer(XmlWriter writer, Range<int> obj)
    {
        writer.WriteElementString("Min", obj.Min.ToString());
        writer.WriteElementString("Max", obj.Max.ToString());
    }
}

When we try to deserialize:
x =  XmlSerializer.Deserialize(reader) as ...
For the case, that reader is at a "RangeInt", it cannot find the right
deserializer and returns null. So, it cannot find the custom
serializer's deserialzer for "RangeInt".
The execption is:
"Der Wert darf nicht NULL sein.\r\nParametername: key"  -> "The value
should not be NULL. \r\nParametername : key"
Here is what the xml for RangeInt looks:
...
    <RangeInt xmlns="clr-namespace:

XXXX.YYY.PersDataTypes.Basic;assembly=XXXX.YYY.PersDataTypes.Basic">
0
9999999

...
Kind Regards
Till Späth

Greetings!  Hopefully Till can meet us on here.  I will also reply to the email.
The first issue here is that I understand you are only able to use 2.0.0.  Obviously we are on v3 now and so much has happened since v2.
However, you should be able to serialize the Range object by making use of the EnableParameterizedContent method.  I have created a passing test in our suite to demonstrate this here:
https://github.com/ExtendedXmlSerializer/home/blob/81da0607e13191e6d9aa7fbc5ad4cb5117c41a8d/test/ExtendedXmlSerializer.Tests.ReportedIssues/Issue435Tests.cs#L10-L29
The other complication is that I am not sure which Range you are referencing.  I made a place holder struct in the test that contains the properties that are mentioned in the email.
Please let me know if you have any further questions/concerns and I will try my best to assist.  I am not if you are somehow able to use v3, but that would be ideal, too. :)

Thank You very much for your quick help! It solved our problem.
It works with .EnableParameterizedContent() in combination with EnableImplicitTyping().
... .Type<List>().Name("ListInt").EnableImplicitTyping(typeof(List)).EnableParameterizedContent();
(List instead of Range, but issue was the same)

Woohoo!  Great to hear.  These are the kind of problems I like. :)  Please feel free to ask any additional questions you might have here on GitHub and I can do my best to get you situated.  Even though we are on v3 now there is still a lot of functionality that is shared with v2, so we might be able to help you out.  Open a new issue here and we'll see how we do. 👍  Closing this for now.


[RFC] Expose Irmin_value_store functor

This provides the Irmin Contents/Node/Commit APIs on top of a Git-type store. This is useful for backends that want to store data using the Git object format, to be able to sync with Git, but without using Git's filesystem layout and locking.
The irmin-indexeddb git-format branch uses this to store data in Git format.
However, I'm not sure if this is the right way to expose the API. Comments?

Looks very good to me thanks!
I'll merge that once I have a bit more time to review properly..

Looking good, and as you use it already it's better to be merged. Sorry for the delay!


WebRequest tests should be rewritten to use a new runspace rather than a job

Because the test httplistener is run as a job, the job may be still starting when the tests are run which may cause the tests to fail on busy systems. we should avoid using jobs for performance reasons and ensure that the listener is responding before we return to run the tests.

This appears to be impacting test runs on CentOS with current tests

merged and closed


Label formatter registering is happening too late on startup

Not sure if making a big fat static would help.

We will not change this since in the October the Open Recent menu item will be created from the renderer side only once the formatter have been registered.


The action fails since the last release (1.7.0)

Looking at known-good-versions-with-downloads.json file we can see that version 113.0.5672.0 is indeed listed as "good", yet the action fails:
Run browser-actions/setup-chrome@v1
  with:
    chrome-version: 113.0.5672.0
    install-dependencies: false
    install-chromedriver: false
    no-sudo: false
Setup chrome 113.0.5672.0
Attempting to download chrome 113.0.5672.0...
Error: Version 113.0.5672.0 not found in known good versions

This happens since the last setup-chrome release (v1.7.0)

Thanks for your report. The setup-chrome v1.7.0 supports installing ChromeDriver. It chooses the version which includes both the browser and chrome driver download URL (https://github.com/browser-actions/setup-chrome/pull/548) when you specify the version number. The action throws the error If the specified version does not includes both. I think the action should install the version 113.0.5672.0 if the user doesn't require ChromeDriver.
Please pick up a version which includes both chrome and chromedriver from the known-good-versions-with-downloads.json file or please use the previous version (v1.6.2) as a workaround until we fix the issue.


Change Drupal user roles based on Auth user roles

I want to change roles for some users and assign them as administrators.
I mean, when a specific user logs in Drupal, his role is set automatically to administrator based on the Auth role previously assigned.
I completed Claim for role mapping in Auth0 advanced configuration at Drupal configuration with "roles" (without quotes) and "admin|administrator" in Mapping of Claim Role Values to Drupal Roles field.
Also, I activated Authorization extension module inside of Auth0, created a role admin and assigned this role to a few users.
Then I went to Rules menu (out of Authorization extension module) and created the same rule as is described here: https://github.com/auth0/auth0-drupal/issues/123 but in my case I tried different Urls.
What namespace should I use there? Because I tried many Urls with any good results. Drupal tell me: 'no changes to role detected'.
Also I tried adding "roles" to app_metadata but nothing changed.
I read what @joshcanhelp posted in the link above but honestly, I didn't understand.
I hope you can help me soon.
Environment
Please provide the following:

Module version: 8.x-2.3
Drupal version: 8.6
PHP version: 7.2
Additional modules: Authorization extension module.

@ozeberle - Apologies for the trouble here. We have a whole document on namespacing here:
https://auth0.com/docs/tokens/concepts/claims-namespacing
Just make sure what you have in the Drupal admin for the claim matches what you're using in the Rule exactly.
Roles in the example in the PR you linked to are using user_metadata, not app_metadata. Those are 2 different fields.
Also ... if you're seeing the "no changes to role detected," are you sure the one for the user is different than the one already saved in Drupal? No change might mean the roles are the same.


Automated cherry pick of #3115: redfish api support

Cherry pick of #3115 on release/2.12.
#3115: redfish api support

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@0615430). Click here to learn what that means.
The diff coverage is 1.93%.

@@              Coverage Diff               @@
##             release/2.12   #3263   +/-   ##
==============================================
  Coverage                ?   7.06%
==============================================
  Files                   ?     482
  Lines                   ?   78460
  Branches                ?       0
==============================================
  Hits                    ?    5540
  Misses                  ?   72459
  Partials                ?     461

Flag
Coverage Δ

#aFlag
7.06% <1.93%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guestdrivers.go
18.18% <ø> (ø)

pkg/compute/models/loadbalancernetworks.go
0.84% <ø> (ø)

pkg/cloudcommon/db/external.go
0% <ø> (ø)

pkg/compute/models/guests.go
0.63% <ø> (ø)

pkg/baremetal/utils/ipmitool/ipmitool.go
0% <0%> (ø)

pkg/baremetal/manager.go
0.58% <0%> (ø)

pkg/baremetal/tasks/baseprepare.go
0% <0%> (ø)

pkg/baremetal/tasks/base.go
14.81% <0%> (ø)

pkg/compute/models/networks.go
0.63% <0%> (ø)

pkg/util/httputils/fs.go
0% <0%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0615430...260dd06. Read the comment docs.

/lgtm
/approve

/lgtm
/approve


Add JavaScript expressions support

The Astro component template supports JSX-like syntax for JavaScript expressions.

  {myFavoritePokemon.map((data) =>
{data.name}
)}

As you can see, this isn't supported yet by this plugin. Can we add this feature? I'm new to treesitter development but I'm happy to help if I'm given some resources or direction on how to do this.

Highlighting JSX does work:

Try https://github.com/virchau13/tree-sitter-astro#parser-dependencies

Sweet, I didn't have tsx installed yet so :TSInstall tsx did the trick!


Most of the extensions that I daily use stopped working (today)

Issue Type: Bug
I did not do anything special than my everyday use.
Just opened visual studio code as usual and worked for a while. Then "most" of the extensions were no longer working. First I noticed "Beautify" don't formats and googled it out, basically found nothing.
Also today visual studio was updated and its kind of suspicious to this two happen same day.
I tried disabling the extensions that Im not sure about but it didn't help.
VS Code version: Code 1.57.0 (b4c1bd0a9b03c749ea011b06c6d2676c8091a70c, 2021-06-09T17:18:42.354Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.88GB (2.62GB free)

Process Argv
--crash-reporter-id 70f8157b-03d0-44f7-8c6e-48b887e71ec1

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

better-comments
aar
2.1.0

increment-selection
alb
0.2.0

html-end-tag-labels
ant
0.6.0

regex-copy-or-cut
ara
1.0.0

bracket-pair-colorizer
Coe
1.0.61

vscode-html-css
ecm
1.10.2

fold-unfold-all-icone
Fer
0.0.3

auto-close-tag
for
0.5.10

auto-rename-tag
for
0.1.6

beautify
Hoo
1.5.0

color-highlight
nau
2.3.0

material-icon-theme
PKi
4.7.0

LiveServer
rit
5.6.1

selectline-statusbar
tom
0.0.2

highlight-matching-tag
vin
0.10.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30294714
vscoreces:30290705
pythondataviewer:30285071
vscus158:30286553
vscgsv2:30307504
vscorehov:30309549
vscod805:30301674
binariesv517:30312825

Can you please check if extensions those are not working are enabled or not? Please go to extensions view and provide a screenshot of them? Please check if there are any errors seen in the developer tools console.

https://github.com/microsoft/vscode/issues/125989
Did you see the Extension host terminated unexpectedly pop-up dialog ?

#125989
Did you see the Extension host terminated unexpectedly pop-up dialog ?

No I didn't

Can you please check if extensions those are not working are enabled or not? Please go to extensions view and provide a screenshot of them? Please check if there are any errors seen in the developer tools console.

Its working now but didn't worked at the time that I faced with the issue. I still don't know what did happen, also I restarted my computer before opening issue but it didn't help. Some random stuff happening to vscode lately


[Codegen 110] Add a nullLiteralTypeAnnotation: string property into the Parser object

Summary:
Part of #34872

[Codegen 110] Add a nullLiteralTypeAnnotation: string property into the Parser object and implement it in the FlowParser (returning
NullLiteralTypeAnnotation) and in the TypeScriptParser(returning TSNullKeyword). Replace them in the parsers/flow/components/events.js and parsers/typescript/components/events.js.

Changelog:
[Internal][Added]: Add nullLiteralTypeAnnotation property in Parser object
Test Plan:
yarn test react-native-codegen

/rebase


Is SoftEtherVPN suitable deploy as SDWAN? Or How to reuse it to build SDWAN?

All of us can see that SoftEtherVPN is still valuable and powerful in  many application scenario.  We can notice SDWAN becomes more and more hot. SoftEtherVPN  and SDWAN looks the same in many aspects, such as enterprise branch interconnection and cloud network collaboration.  So comes my question: Is seVPN  suitable to use as SDWAN,  or how to reuse it to build a SDWAN system?

generally, answer might be either "yes" or "no" depending on details.
yes, it is suitable to be used as SDWAN generally
no, it might not be suited in some particular questions


Add statistics use case

I built it using Gradle 2.1.0 , because “2.1.0-rc1” is incompatible with my Android Studio.

👍 thank you!!

Thanks Kaerdan,
We kept Task.java in data/ for consistency with todo-mvp but since you added another model, can you please move it to statististics/domain/model and move Task.java to tasks/domain/model?

Done.
I have a small related question, why it was decided not to extract domain into separate package? I think it can help to understand app architecture.

Looks good to me! @flipper83?

👍 good to me!

prod was broken in this PR. Fixed in #122


adding first version of the 2.2 exercise

@UndeadFairy I left some comments using ReviewNB, I hope you can see them properly.

Understand the point, I was also contemplating if it is not too much, but I thought of finishing with some nice visualization (usually students like to see something visual) and as hint what comes next. Maybe just single band visualisation would be better here?

View entire conversation on ReviewNB

Yes, I think that visualization without particular processing would be fine, especially if it involves using metadata from the file needed for scaling.

View entire conversation on ReviewNB


Using a MAZeroingWeakRef with a ViewController causes subviews not to load from nib iOS 4.x

When using MAZeroingWeakRef with a UIViewController as the target the VC's view's subviews do not get loaded from the nib.  This only happens if the MAZeroingWeakRef is created before the VC's viewDidLoad: method is called (for example in the initWithNibName:bundle: method) and you are running iOS 4.x.
I have created a simple example project that will demonstrate this:
https://github.com/rcancro/MAZWRTestApp
For a work around I've found that you can either force viewDidLoad: to be called before creating the MAZeroingWeakRef (by doing something like self.view.hidden = NO;) or create an init function for the ViewController that calls through to initWithNibName:bundle: passing in the nib name.
There are more details on the project's github page.

Right, that completely makes sense when it is explained!  :)
I added the code you provided, and it worked when I made the slight modification to the line in CreatePlainCustomSubclass:
class_addMethod(subclass, @selector(class), (IMP)CustomSubclassClass, method_getTypeEncoding(classForCoder));

(I changed the selector from classForCoder to class).
I think for the time being I'll use the work around that I came up with -- to implement the VC's init method and explicitly call initWithNibName:bundle: with the class's name.  But it makes me feel a lot better to understand what is going on.
Thanks again for the help and the awesome code!!

Glad to hear that the workaround worked. Not sure if I want to incorporate it into the code, but it's something to think about. Thanks for reporting the problem.

Ran into the same issue...I think we should keep this open until it's actually fixed in the code.

If more than one person has hit it, that's starting to make a good case to apply the workaround. Can you verify that this workaround fixes your case as well?

It did from what I could tell, but your secretiveness && debugging statement made me nervous, so I modified my viewcontroller code to not use MAZeroingWeakRef before the view is loaded, which fixed things as well.


upgraded Scala zinc compiler to version 1.2.5

Context
This PR fixes https://github.com/gradle/gradle/issues/2158

Uses the latest zinc compiler (1.2.5)
Additionally introduces Scala compiler daemon that remains warm across build, improving further incremental compilation times

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Great contribution. :)

This is a great PR, thanks for the work @pedjak
I'd argue against a raw integration with Zinc with the arguments I added in https://github.com/gradle/gradle/issues/2158, and instead propose that the same thing is achieved with Bloop's build server.
This will ensure, among other things described in the above ticket, that Gradle will work with Scala 3.0 as well as Scala 2.0 and all its supported runtimes.
An integration via Bloop is the recommended solution because there is likely to be a Zinc 2.0 version that will be breaking many parts of the API/design of the incremental compiler, with the purpose of improving it further. The BSP integration will make sure that no matter what internals are changed, Gradle users can still benefit from the best Scala experience.

An integration via Bloop is the recommended solution because there is likely to be a Zinc 2.0 version that will be breaking many parts of the API/design of the incremental compiler, with the purpose of improving it further. The BSP integration will make sure that no matter what internals are changed, Gradle users can still benefit from the best Scala experience.

@jvican, I see that more as mid/long-term goal here, in particular because of this statement in the docs:

At the moment, Bloop 1.2.5 partially implements version 2.0.0-M2 and Bloop v1.0.0 implements version 1.0.0

Also looking further at the docs, no build tools (even sbt) provides "built-in compile" integration with Bloop. bsp4j contains no examples or tests either, so it is very hard to understand how to use the server.
Good docs/examples are the key here. It took me a huge amount time to understand how the actual zinc api works. Reading the source code of Maven and InteliJ plugins was the only available doc, Zinc project was not of any help.
This PR brings significant speed improvements over the currently used Zinc version and this is what at least developers in my organization desperately want. Integration with Bloop should start as "incubating", deprecating and removing the current one eventually.
BTW, would you like to say that BSP API is not going to change over the time?

@jvican, I see that more as mid/long-term goal here, in particular because of this statement in the docs:

1.2.6 will just bump up to a stable 2.0.0 BSP, which is 2.0.0-M2 with only a few amendments to some APIs. That version of BSP is being already battle-tested in our metals integration by a few thousand  Scala users.
It is true however this is not something immediate we can ship right now, but it's something we could ship during the next two months. I'm not sure what policy will gradle maintainers follow and when the next gradle release will happen (if it's to happen soon I would certainly encourage merging this temporarily), but if we can make the deadline I would recommend we try the bloop-based integration, which is where all Scala integrations are headed anyways).
That being said:

Also looking further at the docs, no build tools (even sbt) provides "built-in compile" integration with Bloop.

Metals and fury (a build tool) are using the built-in compile via BSP, so is IntelliJ. The idea is that we want to share the build server across all users so that the dev experience is the best.

bsp4j contains no examples or tests either, so it is very hard to understand how to use the server.

Tests are available in two different subdirectories of the same repo:

https://github.com/scalacenter/bsp/tree/master/tests/src/test
https://github.com/scalacenter/bsp/tree/master/testkit/src/main/scala/ch/epfl/scala/bsp/mock

There is a PR contributed by JetBrains to add property tests too: https://github.com/scalacenter/bsp/pull/84
https://github.com/scalacenter/bsp/tree/master/tests/src/test

BTW, would you like to say that BSP API is not going to change over the time?

Sure, that's exactly one of the reasons why it's a protocol. There's extreme care in not breaking APIs and evolving the project in a backwards compatible way, just as LSP.

Metals and fury (a build tool) are using the built-in compile via BSP, so is IntelliJ. The idea is that we want to share the build server across all users so that the dev experience is the best. To give more context, I'm also right now implementing built-in compilation for sbt.

Do I understand correctly that InteliJ just supports importing BSP project, but not "built-in compile", or this table is not up-to-date?
And speaking about examples - we need some real-world things, even BloopSuite is disabled at the moment.

Do I understand correctly that InteliJ just supports importing BSP project, but not "built-in compile", or this table is not up-to-date?

The table you're looking for is https://scalacenter.github.io/bloop/docs/ides/overview IntelliJ supports compilation because it shows build diagnostics in the IDE. The other table is only for build tools.

And speaking about examples - we need some real-world things, even BloopSuite is disabled at the moment.

Plenty of real-world things in https://github.com/scalameta/metals and the scala-plugin in intellij. Tests of concrete clients are not enabled in the bsp repository on purpose.
--
On an unrelated note, @pedjak I'm not saying the bloop integration should be implemented by you -- it's totally fine you haven't looked at Bloop before, it's more or less a recent development anyway. I'm just pointing out I consider gradle to be an important client and would like to provide a more bullet-proof integration than having a custom zinc integration. This change will likely need direct help from the gradle team + me, as bloop author and zinc maintainer, so it's not something you should worry about.
I've been chatting with @oehme over the past months about how to approach this change. As I said before, it doesn't necessarily need to block this PR. I guess it will all depend on what are Gradle team's intentions.

On an unrelated note, @pedjak I'm not saying the bloop integration should be implemented by you -- it's totally fine you haven't looked at Bloop before, it's more or less a recent development anyway. I'm just pointing out I consider gradle to be an important client and would like to provide a more bullet-proof integration than having a custom zinc integration. This change will likely need direct help from the gradle team + me, as bloop author and zinc maintainer, so it's not something you should worry about.

Sure, I would not mind helping either :)

Hi @jvican maybe it would be better to file an issue for bloop integration and move this discussion there. Thanks.

Would the bloop integration introduce a new daemon instead of reusing the Gradle daemon?

Yes, bloop is a build server shared by many clients. It can be used from IntelliJ, editors using Metals, in-house developer tools and any kind of build tool. The idea is that the build server outlives the lifetime of the clients. You can read more about it in https://scalacenter.github.io/bloop/ and, more concretely, https://scalacenter.github.io/bloop/docs/what-is-bloop

I know everyone is excited for Bloop, but I could use this PR right now in a project that builds with Gradle and Zinc, which I'm trying to upgrade to Scala 2.12. Any good reason not to merge the PR?

Hi, curious if this is slotted for 6.0?   We would like to upgrade to 2.12 and as @deanwampler mentioned, could really use this PR for now while the direction to use bloop is being hashed out.  It looks like @pedjak put in a decent amount of work in this too, so would be good for it to be brought to fruition.

Thanks a lot for your PR @pedjak . I have spent some time today reviewing, as well as fixing some left-over tests. We're still not in a position to be able to merge, for different reasons:

this implicitly mandates users to use Zinc compiler 1.2.0+
this effectively removes support for Scala 2.9
there are lots of tests failing with "unable to delete file" under Windows, which indicates that at least a file handle is leaking

For the breaking chances (Zinc 1.2, Scala 2.9) I've added documentation, and we have to decide whether it's fine to ship in 5.5 or we should wait 6.0. Currently we're leaning towards 5.5 given the bugfixes and improved performance, but it may be a problem for some users.
Progress can be followed on this branch, based on your PR.

Thanks @melix for taking this. If I can help any further with the tests, do let me know. I do not have any Windows instance where I could try them.
Zinc 1.x in general removed the support for Scala 2.9, so I am not sure how many users are really affected.
This PR introduces Zinc 1.2.5 as the default, but I do think that the older 1.x versions have the compatible API, so users can change the default version by declaring the requested version in zinc configuration as before. Perhaps we can add a few tests verifying that we can use 1.0.x and 1.1.x versions?

I have checked with 1.0.x and 1.1.x and it breaks, the API is different.

I got an error when disabling incremental compilation by force = true
Process 'command '/home/klass/.sdkman/candidates/java/8.0.191-oracle/bin/java'' finished with non-zero exit value 1
    tasks.withType(ScalaCompile) {
        scalaCompileOptions.with {
            force = System.getenv('FORCE_COMPILE') == '1'
        }
    }

this env flag was working before

Hi @melix - just wondering if this is still slated for at the very least 6.0?  I ask because many popular scala libraries maintainers are looking to discontinue published builds for anything lower than 2.12, basically leaving gradle+scala users unable to upgrade to new versions of dependencies.  One in particular being akka - of course one of the most (if not the most) popular library in the scala world.

I didn't have time to continue on this, but I agree it would be good to target 6.0.

Here is an updated PR based on @melix's changes: https://github.com/gradle/gradle/pull/9573

That's great!


(Experiment) Remove integrated REPL

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci Please smoke test

Well, I guess this won't work, because there's no way to just run lldb tests.

Nevermind, I guess this is because it doesn't compile.

https://github.com/apple/llvm-project/pull/1188
@swift-ci Please smoke test

👍🏻


client.RefreshCoordinator doesn't seem to work with MockBroker

So I have this piece of software I'm working on. It seems to work nicely with a regular
sarama.NewConsumerGroupFromClient.
However, I'm trying to create a test using the MockBroker. As soon as I try to run the function that uses sarama.NewConsumerGroupFromClient, the test just hangs (until the --timeout is reached. It's not coming back from RefreshCoordinator.
I found in the client.go, regarding RefreshCoordinator "This function only works on Kafka 0.8.2 and higher.". As soon as I deactivate it, my test continues to run.
It still fails because sarama.ConsumerGroup.Messages() seems to error on return. This might, however be unrelated.
Is MockBroker not working anymore? Any help would be highly appreciated.
Logger output:
Jul 24 20:52:16 INFO stream.go:88 client/coordinator requesting coordinator for consumergroup c9404a39-7df8-4a42-6e17-965bb416e245 from <IP_ADDRESS>:41211
Jul 24 20:52:16 INFO stream.go:88 *** mockbroker/1/0: ignored (*sarama.request)(0xc4201d9e00)({\n correlationID: (int32) 1,\n clientID: (string) (len=10) "bloom.test",\n body: (*sarama.ConsumerMetadataRequest)(0xc4201408a0)({\n  ConsumerGroup: (string) (len=36) "c9404a39-7df8-4a42-6e17-965bb416e245"\n })\n})
Jul 24 20:52:46 INFO stream.go:88 client/coordinator request to broker <IP_ADDRESS>:41211 failed: read tcp <IP_ADDRESS>:34176-><IP_ADDRESS>:41211: i/o timeout
Jul 24 20:52:46 INFO stream.go:88 Closed connection to broker <IP_ADDRESS>:41211
Jul 24 20:52:46 INFO stream.go:88 client/coordinator requesting coordinator for consumergroup c9404a39-7df8-4a42-6e17-965bb416e245 from <IP_ADDRESS>:43195
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/1/0: invalid request: err=EOF, (*sarama.request)(<nil>)
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/1/0: connection closed, err=<nil>
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/2/0: connection opened
Jul 24 20:52:46 INFO stream.go:88 Connected to broker at <IP_ADDRESS>:43195 (registered as #2)
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/2/0: served &{0 bloom.test 0xc4201f8810} -> &{0 map[test:map[0:0xc4201d8a50]]}
Jul 24 20:52:46 INFO stream.go:88 client/coordinator request to broker <IP_ADDRESS>:43195 failed: kafka: insufficient data to decode packet, more bytes expected
Jul 24 20:52:46 INFO stream.go:88 Closed connection to broker <IP_ADDRESS>:43195
Jul 24 20:52:46 INFO stream.go:88 client/brokers deregistered broker #2 at <IP_ADDRESS>:43195
Jul 24 20:52:46 INFO stream.go:92 [client/coordinator no available broker to send consumer metadata request to]
Jul 24 20:52:46 INFO stream.go:88 client/brokers resurrecting 1 dead seed brokers
Jul 24 20:52:46 INFO stream.go:88 client/coordinator retrying after 250ms... (3 attempts remaining)
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/2/0: invalid request: err=EOF, (*sarama.request)(<nil>)
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/2/0: connection closed, err=<nil>
Jul 24 20:52:46 INFO stream.go:88 client/coordinator requesting coordinator for consumergroup c9404a39-7df8-4a42-6e17-965bb416e245 from <IP_ADDRESS>:41211
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/1/1: connection opened
Jul 24 20:52:46 INFO stream.go:88 Connected to broker at <IP_ADDRESS>:41211 (unregistered)
Jul 24 20:52:46 INFO stream.go:88 *** mockbroker/1/1: ignored (*sarama.request)(0xc4201f6d20)({\n correlationID: (int32) 2,\n clientID: (string) (len=10) "bloom.test",\n body: (*sarama.ConsumerMetadataRequest)(0xc4201f89c0)({\n  ConsumerGroup: (string) (len=36) "c9404a39-7df8-4a42-6e17-965bb416e245"\n })\n})
✘

The MockBroker does not automatically respond to all possible messages: you must provide it with the messages and responses you expect it to see for testing purposes. From the documentation:

If a MockBroker receives a request that it has no programmed response for, then it returns nothing and the request times out.

This is likely what is happening to you.

Hey @eapache ,
thank you for your quick response! I will look into that
So, generally speaking, it should work with the current version, right?

I'm not aware of any reason it wouldn't.

Thank you!

@eapache ,
would you happen to have an example? :S Including sending and receiving messages?
I tried to follow broker_test.go but didn't really get anywhere.
Thanks!


mod_pv_db.txt doesn't work on rom_steam_xx/rom

I need use rom_steam_xx to supports game read different mod_pv_db on different language
but when i change my pv_db file name to mod_pv_db then game doesn't read mod_pv_db file
and when i change pv_db file name to mdata_pv_db, end_pv_db, patch_pv_db and patch2_pv_db, every thing work fine so i don't think it's because i put pv_db file in wrong folder
e.g
rom_steam_tw/rom/mod_pv_db.txt → doesn't work
rom_steam_tw/rom/patch2_pv_db.txt → work
(sorry i'm not good at english, maybe I didn't explain clearly)

I getcha. I'll take a look at this when I have the opportunity.

Fixed with DML v0.0.12 release.


Heroku not automatically building from Github

See https://status.heroku.com/

We can deploy by pushing to heroku's git for now:
heroku git:remote -a metaforecast-backend
git push heroku master

Automatic deployments on Heroku are currently working.


Removed visible credentials

Fixes https://github.com/coreos/fleet/issues/1607

In general it looks good.
Ideally the subject line should be prefixed by a subsystem name, e.g. "docs: ", but in the case of documents, I'd suppose, that's not a strict rule.
BTW Reading this document, I start to think that this is not the only place where AWS keys are exposed. But sometimes I have to admit, I can't fix everything. ;-)
So if there's no objection, I'll merge it tomorrow.

Merged https://github.com/coreos/fleet/pull/1608. Thanks.


Docker image

Hi Osmo team, do you have any guidance with the docker image to run app from this repo?
With 16-alpine getting this error:
#15 18.53 lerna ERR! yarn run build stderr:
#15 18.53 error - Failed to load SWC binary

any updates folks?

Are you talking about running the frontend in a container?

Are you talking about running the frontend in a container?

yes

https://nextjs.org/docs/deployment#docker-image


[Main] Ideal Nav v2

Background
Now that we've lived with Ideal Nav for a week, we've experienced the following issues with the core design:

Accessing a workspace via the 🔧 resulted in a "lateral," global switch of someone's workspace. This was confusing because we created one known, obvious way to switch a worked – the workspace switcher – and then one secret, confusing way to "laterally" switch a workspace by choosing it in Settings.
Account settings was accessed via an avatar in the top right, whereas workspace settings was accessed in the 🔧 bottom tab. Though now that we're deprecating "lateral" switching, separating these two types of settings pages is no longer necessary. Let's combine them in one central place.
Finally, while we aspire to have feature-rich global search, today our "search" is merely a chat switcher. As a result, it doesn't deserve the prominence that we've given it.

Summary of changes
All in all these and other experiences have encouraged us to tweak the core Ideal Nav designs via the following v2 changes:
Header

The workspace switcher, workspace name and page name all share the same line in the header.
Additionally, the search input becomes a magnifying glass icon is only appears the header for the Chats tab (as again, the only "search" we have is a chat switcher).

Bottom Tab

The 🔧 is replaced by a 28x28 user avatar, which reveals a new Settings page that combines account settings as well as workspace settings

Settings

The new combined Settings page has three main sections: Account, Workspaces and General.

A 100x100 user account avatar appear at the top of the Settings, with a "share code" icon in the top left and a "status" icon in the top right. The "share code" icon replaces the previous push row, while "status" displays a user's status, should one exist. Tapping the "status" icon takes the user to https://new.expensify.com/settings/profile/status.

Account is the first section in Settings, and includes nav items for Profile, Wallet, Preferences and Security

Workspaces is the second section in Settings, and includes nav items for Workspaces, Subscription, and Cards & Domains.

General is the last section in Settings, and includes nav items for Switch to Expensify Classic, Help, About and `Sign out.

Workspaces

The Workspaces page has two states, depending on whether a user is a member of a workspace or not.

When viewing a specific workspace's settings, we launch a full screen experience, which pushes the workspace setup pages in the the LHN. No bottom tabs appear in this view.

To exit out of the full screen workspace editor, a user would click the back caret in the LHN header, which takes them to https://new.expensify.com/settings/workspaces.
Mobile views shown below for extra clarity.

Individual Issues
[This space can be used if we opt to break up this initiative into individual issues and corresponding PRs]

Note: This issue is for internal use and the corresponding implementation to be handled by SWM.

Nice!!

Bottom Tab

The 🔧 is replaced by a 28x28 user avatar, which reveals a new Settings page that combines account settings as well as workspace settings

What about the active state of the settings bottom tab. We're giving the avatar a green ring, right @shawnborton?

That's right, I can update the images above.

Perf, thanks!

Updated.
Though @Expensify/design one thing I realized - if the default avatar is green, the green active ring is hard to see. Maybe we should create some separation like so?

Right on, I'll update the shots assuming Jon doesn't have any strong pushback either.

Okay, updated all the screens.

Nice work! @mountiny This one is ready for SWM.

Will coordinate with them on Monday, thanks!

Looks great to me @shawnborton . Alternatively we can add a 5% scrim on top of their avatar that won't actually mess too much with their picture, but will allow us to always have the circle be different. Just an alternative, but still think what you have above looks awesome.

Hey, I'm from SWM and I will work on this.
FYI: I'm going OOO from Wednesday, then @WojtekBoman will take over this issue.

Nice, I've assigned you @kosmydel. @WojtekBoman can comment when he's taking over and we can assign him as well. :)

Try this file here.

Hello! I'm going to work on it today :)

@shawnborton @dannymcclain How do we want to display RBR/GBR on the Profile icon in the bottom tab?

I think I would expect something like this for consistent placement across the two:

cc @dubielzyk-expensify too
I updated the Figma here with the screens you'd need.
But the thinking is that we give the bottom tab icon a wrapper of 28x28. The icon size for non-avatar icons is 24x24 yet the avatar goes up to 28x28 to be a little bigger. The chat icon is centered within that 28x28 area. Then the red dot is just anchored to the top-right of that 28x28 bounding box, with a 2px outer border.

@shawnborton that looks good to me.

@shawnborton @dannymcclain I'm curious if we should show a dot when an icon is selected? I'm asking because currently the dot is hidden when we select a specific tab and we don't handle this case. If so, do we want to display a green dot on the
selected chat tab icon? Both icons will be green in this case

As in, if there is a green brick road dot somewhere in the chats list, then we should show it on the Chats icon in the bottom tabs? I guess that makes sense, and I think even if the chat icon and dot icon are both green, it would still look okay:

Agree—I think the dot in the tab would show as long as there is an item in the tab that has a dot.
So if I have a green-dotted-chat, the chat tab would get a green dot. Selecting the chat tab would still show the green dot until I took whatever action was necessary to make the dot go away on the green-dotted-chat.

Sorry if I missed this, but I'm also assuming that red dot takes precedence over the green dot if both were to appear?

Sorry if I missed this, but I'm also assuming that red dot takes precedence over the green dot if both were to appear?

Yeah, the RBR always takes priority over the GBR. Like we never show both on a chat row for example, so I think that same logic applies here on any given bottom tab for example.

I'd like to confirm one more thing related to the opening the Workspace Settings from the deeplink :) Where should we navigate after pressing the back button in this case? I think we should open the Settings screen, but before I start implementing the logic for that I wanted to confirm it's correct :)
https://github.com/Expensify/App/assets/47774969/c059ebc7-c09c-4fc2-b2b9-cd150ca658ef
There's only one case where we should be redirected to the Home page from Workspace Settings, when we create a new workspace using the Workspace Switcher, right?

Is this the correct design of the bottom tab for anonymous users?

Hmm I wonder if we should just replace the Search icon in the top right with the Sign In button, and leave a generic avatar in the bottom tabs? I think that might look cleaner.

Ok, sounds good :) So maybe I will ask also about the case when the avatar in the bottom tab is loading. In this case we display a skeleton and it can be selected. Here's what it looks like:
https://github.com/Expensify/App/assets/47774969/6c1d27ec-b1d5-4bbb-bedd-df62c2f83398
Is it ok for you?

I think that feels good. The ellipse shape does feel like it has rough edges though - any idea how to fix that?

I'll check it :)

Hmm I wonder if we should just replace the Search icon in the top right with the Sign In button, and leave a generic avatar in the bottom tabs? I think that might look cleaner.
100% with you. Feels a bit weird with the Sign in button in the bottom nav

@hayata-suenaga Is it possible to create a new workspace in OldDot and open it in NewDot? Some time ago I fixed this issue and I'd like to check if it works with the new navigation, but currently I don't see an option to create a new workspace for free in OldDot. Does this functionality still exist?

We recently got rid of the free workspace option. I'm checking on this with the internal engineering team. (internal link)

If you enable chat reports in a collect policy in Old Expensify, you can still see a workspace that is created on Old Expensify in New Expensify.

Not overdue, onto payment soon.

No payments are due here, so what else are we waiting on? Do we have a full set of regression tests added to TestRail? If so, I think we just lack a project wrap up and we're good.

Ah thanks, that's not captured in the payment summary above. Is there an existing Upwork job for you?

Looks like we have regressions to account for as well.

Payment summary: $250 to @mkhutornyi for PR review and testing.

I agree @mkhutornyi this PR was quite a huge. we should at least have the standard rate.
@JmillsExpensify I'm sorry I should have provided a note about it before 🙇

Cool, updated!

@mkhutornyi I just sent you an offer on Upwork.

I believe @mkhutornyi is out for medical reasons. We cam make this weekly unless you have confirmed its paid up @JmillsExpensify

@JmillsExpensify @mkhutornyi can this be closed?

Yes!


Migration to Android V2 embedding

Really like this library.
Just in newer versions of flutter, it complains that this plugin uses a deprecated version of the Android embedding:
The plugins `flutter_interactive_keyboard` use a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if these plugins support the Android V2 embedding. Otherwise, consider removing them since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

Shouldn’t be very hard for this plugin, cause it is primarily for iOS.

I'm getting the same error

@mcrovero

Here's a fork where this migration was done : https://github.com/braverhealth/flutter_interactive_keyboard


npm install fails

npm install fails with the following error message:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| ^15.0.0-0
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| ^15.0.0
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| ^15.0.0
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| 0.14.x || ^15.0.0-0
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>

Hello, @Rokotyan Can you tell me your version node, npm and webpack?
"npm start" doesn't work after install?

Thank for a quick response @anorudes. Below are the versions of the global installs:
node 4.2.4
npm 2.14.12
webpack 1.13.0
npm start fails with : sh: rimraf: command not found

try "npm install rimraf -g"

Getting more errors:
/Users/nikitarokotyan/Downloads/redux-easy-boilerplate-master/node_modules/babel-core/lib/transformation/file/options/option-manager.js:220
          throw new ReferenceError(messages.get("pluginUnknown", plugin, loc, i, dirname));
          ^

ReferenceError: Unknown plugin "transform-object-rest-spread" specified in "/Users/nikitarokotyan/Downloads/redux-easy-boilerplate-master/.babelrc" at 1, attempted to resolve relative to "/Users/nikitarokotyan/Downloads/redux-easy-boilerplate-master"

Let me know if there is a way for me to help solving the issue.

@Rokotyan Can you update npm to 3 version, node to 5 and global webpack to 2 (not sure what need)? :)

Its dep depency, not compatible with 15. As it is
On May 13, 2016 18:55, "anoru"<EMAIL_ADDRESS>wrote:

@Rokotyan https://github.com/Rokotyan Can you update npm to 3 version,
node to 5 and global webpack to 2 (not sure what need)? :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/anorudes/redux-easy-boilerplate/issues/77#issuecomment-219084557

I tested: after "rm -rf node_modules" and "npm install" - boilerplate working. Most likely the problem with version node or npm

@Rokotyan add me in skype - void-anoru, we both from Russia =)

Ill add you too :)
On May 13, 2016 19:16, "anoru"<EMAIL_ADDRESS>wrote:

@Rokotyan https://github.com/Rokotyan add me in skype - void-anoru, we
both from Russia =)
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/anorudes/redux-easy-boilerplate/issues/77#issuecomment-219089956

Ok, it looks like newer versions of npm don't care about unmet dependencies and just keep installing things. Installing node 5.0 via nvm did the job. It would be nice if you could add it to the readme to avoid further confusion.
Terminal command I've used:
nvm install 5.0
nvm use 5.0

I'm glad that it's working now :)


Possible optimisation

[ ] push dependencies (instead of pull)
[ ] tree-based reduction to resolve dependencies when task has a large number of dependencies
[ ] push status
[ ] push cancellation
[ ] heart-beat using keep-alive (either TCP or Grpc)

push dependencies (instead of pull) => needs a proper discussion and to get measurements.
Performance impact of dependencies pulling depends on whether the dependencies are already finished upon first dependency check. We need to observe what happens on real situation.

tree-based reduction to resolve dependencies when task has a large number of dependencies => yes !

heart-beat using keep-alive (either TCP or Grpc) => Yes !
Probably the first item to implement since it is not very complex and will have a huge impact. It will allow to use batch operation in the DB.


Comment character limit

The API documentation mentions a character limit of 3000 bytes  for analyzing comments, however this comment suggests that the character limit is 3000 characters (using Unicode it could mean up to 12000 bytes).
Is the actual limit in bytes or characters? If it is in bytes, would you consider raising the limit to characters? I have an application that analyzes comments from a chat-based system, that allows up to 2000 unicode characters per comment. Having to go around the limitation of 3000 bytes per comment would be very unfortunate, as I'd have to split comments across multiple requests to fully cover the comment.
And as the API does not allow batch requests, this does mean that other comments get queued up and may be stalled on high activity.

HI - sorry for the slow response, we've been discussing this however and it's a bit complicated. The 3000 character limit applied to an earlier model, and limits actually vary from model to model. At present we do have a 20K bytes limit for anything sent through our API, and this will return an error message if exceeded. Our popular TOXICITY model does truncate the input at approximately 1500 tokens, but there's no easy way for a client to see the tokenization results so what that translates to in terms characters is a little difficult to say. We will try to document this better in future models and will update our documentation to make this unclear situation more discoverable.
If you are asking with respect to a particular model attribute, or with respect to a particular input, I might be able to give more details.

Would it be possible to raise the token limit for the toxicity model? As an alternative it would probably useful to return the amount of consumed bytes as part of the response, if not fully consumed.


Port over to bevy v0.15

Port over to bevy v0.15
Migration guide: https://bevyengine.org/learn/migration-guides/0-14-to-0-15/
Port status

[x] build with default features
[x] build with physics + tiled + avian features
[x] build with user_properties feature
[x] update examples
[x] take advantage of required components to rework public types
[x] fix rendering
[x] figure out what to do for TypeInfo::Set and ReflectMut::Set

Dependencies

Name
Status
PR / Branch

bevy
0.15
✅

bevy_ecs_tilemap
On-going PR
https://github.com/StarArawn/bevy_ecs_tilemap/pull/568

bevy_rapier2d
On-going PR
https://github.com/dimforge/bevy_rapier/pull/595

avian_2d
Merged in main
https://github.com/Jondolf/avian/commits/main/

bevy_inspector_egui
0.28
✅

Waiting for remaining dependencies to be merged


One Create Function API call and Update Connection String Prompt

This PR fixes #18932 and fixes #18930.
I found that due to this prompt (when a user has no azure function project open):

The user would be able to create an azure function project by us calling the createFunction first to create a dummy Azure Function Project in order to get certain parameters for the SQL Input/Output Binding (which requires the binding type and project folder path).
After some discussion, we want to directly create a SQL template binding instead of the above process. As such I needed to refactor the code:

Find the Azure Function Project
a. Azure Function Found (show multiple in quick pick selection or if one found then use path)
b. No Azure Function Found in the workspace (show a warning: 1. Create Azure Function Project 2. Learn More) isCreateNewFunction = true.

Prompt For Binding Type

Based on the entry point of the user:
a. Command Palette:

Prompt for Connection Profile, Prompt for Database, Prompt for Object Name
b. Right click on table:
Construct object name via connectionInfo schema and table name

Get connectionString via the Connection Profile

Prompt for Azure Function Name (based on objectName)

Set TemplateID based on selectedBinding.type

promptAndUpdateConnectionString - (isCreateNewFunction = false, not creating a new function project)
a. Prompts user for Connection String Setting Name
b. Prompts user to enter Password manually into connection string

Create Function API - settings {
langauge: C#
targetFramework: netcoreapp3.1,
templateID - selectedBinding.type,
functionName,
folderPath - project file folder path,
SQL template settings {
connectionStringSettingName,
selectedBinding type,
object (if input binding),
table (if output binding)
}
}

if (isCreateNewFunction)
a. we are now able to get the projectFile Path and therefore able to set the local.settings.json with the connectionString and prompt the user to enter the password manually into the connection string

Design prototype

1st Scenario (user has no azure function project folder):
user clicks Create Azure Function Project

user chooses binding type

user enters azure function name

user enters namespace

due to issue (https://github.com/microsoft/azuredatastudio/issues/18780) we have to set the azureFunctionWebJobStorage and in doing so we remove the prompt in the issue but get an overwrite message the user would have to press yes:

user asked to include password for connection string

if yes to above - we finish creating project and adding connection string to local.settings.json
if no - user shown to enter password:

if user enters valid password then we add it to the connection string
if escape we show warning:

2nd Scenario (user has an azure function project):
user chooses binding type

user enters azure function name

user selects existing connection string setting or creates new

If user clicks create new setting name:

user asked to include password for connection string

if yes to above - we finish creating project and adding connection string to local.settings.json
if no - user shown to enter password:

if user enters valid password then we add it to the connection string
if escape we show warning:

user enters namespace

creates the azure function with SQL binding

Converting to draft as this will go in after the release.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 104 (4.81%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 42.212%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/sql-bindings/src/common/utils.ts
1
3
33.33%

extensions/sql-bindings/src/services/azureFunctionsService.ts
0
97
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/sql-bindings/src/services/azureFunctionsService.ts
3
6.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
27755

Relevant Lines:
61520

💛  - Coveralls


Error 404 Bad Request

In the console, at every playback request I find myself via youtube, spotify, and soundcloud it gives me bad request error 400 why?

Duplicate of #195


TP-328: Support negative SIDs

HMRC has proposed allowing SIDs for the data models to vary from
9,999,999,999,999,999,999 to -9,999,999,999,999,999,999. A key
aspect of this is to allow negative SIDs which could be used to
distinguish UK data from historically EU data. As it is
unlikely that so many measures will be introduced at once it has
been proposed that instead a signed 32-bit integer is used,
allowing a range from -2,147,483,648 to +2,147,483,647. This still
allows orders of magnitude more of each data type than currently
allowed by the EU and can be easily updated to a 64-bit integer in
future if required.
This commit implements this by adding a new field called SignedIntSID
which replaces the NumericSID field most models used. This is similar
to the NumericSID field, but it has no validators and inherits from
IntegerField instead of PositiveIntegerField. NumericSID is kept
so that old migrations still work. The XSD has been updated to match
these new limits.

Codecov Report

Merging #98 into master will increase coverage by 0.03%.
The diff coverage is 15.15%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   67.19%   67.23%   +0.03%
==========================================
  Files         123      123
  Lines        6487     6491       +4
  Branches      414      414
==========================================
+ Hits         4359     4364       +5
+ Misses       2028     2027       -1
  Partials      100      100

Impacted Files
Coverage Δ

additional_codes/models.py
13.55% <0.00%> (ø)

certificates/models.py
16.66% <0.00%> (ø)

footnotes/models.py
20.31% <0.00%> (+0.61%)
:arrow_up:

geo_areas/models.py
12.96% <0.00%> (ø)

measures/models.py
27.89% <0.00%> (ø)

quotas/models.py
22.22% <0.00%> (ø)

quotas/serializers.py
1.19% <0.00%> (+0.01%)
:arrow_up:

common/models.py
50.00% <62.50%> (+1.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce27083...4a7ed10. Read the comment docs.

Just too late! I was going to ask about naming migrations. Perhaps it's not important.

Sorry!


Updates tests

Windows still failing. Keeping commented out

I think we're trying to fix something that never worked. Integration tests for windows and and linux are disabled for v4 on the current isar repo.


Update plan-for-government-gcc.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1500
Updated note

@AndreaBarr @yogkumgit this can be closed thank you.


Bot account settings: Testers

Add Discord users on the "Application Whitelist"

Just sent an invite to people some.


'Subscript' object has no attribute 'id'

I have a fastapi application running on uvicorn.
tried to transform the main.py which holds the fastapi app inside a module called backend.
with pyggest transform backend
It gives below error:
Enter the name of the main file: main.py
'Subscript' object has no attribute 'id'

This will be addressed in the next release. If you can provide more info, that would be extremely helpful.
Thank you.


Style/SignalException is bit too inclusive about the fail scope

I am glad that the great debate about raise/fail is finally over, having to refactor my code in the process (see #2732).

There's no way we can possibly detect every situation where fail calls something other than Kernel#fail. But maybe we can filter out some trivial cases, like this one. Maintainers, what do you think?

I think it's not a good idea to shadow Kernel methods. Maybe this deserves a cop. ;-)
This is the first time someone reports such an issue in 3 years, so I'm not sure whether it's worth investing any efforts here. On the other hand - trivial cases should be easy to handle.

trivial cases should be easy to handle.

The question is, if someone wants to define a custom fail method, what are the chances they will only use it in the file which defines it?

The consumers of my utility class use Foo.fail instead of (Kernel.)fail, therefore it's not really an issue as there's no namespace conflict. As you can see, my utility class is made of static methods, but some methods in Foo may call the fail method defined in its scope which triggers this issue in RuboCop.
If this deserves a cop, I'm OK with it.

I should have read the example code. :-) This would be easy to fix.

What if we don't flag any call to fail with an explicit receiver?

What if we don't flag any call to fail with an explicit receiver?

Uhh... that's what we already do. Forget what I said.


How to set rootDir as process.cwd() + '/..'

My application was setup as a mono repo. This is the structure:
\mono-repo
|--core
|--app1
|--app2

I run jest at app2. But I also want to run all tests from core. So here is my config
{
    rootDir: process.pwd() + '/..',
    roots: [ 'core', 'app2' ],
}

But it didn't work.
Could you give me any idea for this case?

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. Thank you :)

it has been solved? @tampham47


typos src/EntityFramework/Core/

@divega anything else to do here?

@bricelam, @ajcvickers any thoughts on squashing and merging this PR?
FYI, I marked it as approved after I reviewed extensively 3 weeks ago, and I am pretty confident no unintentional breaking changes have slipped into it. But on the other hand there are so many little changes in it and we are so close to 6.3 RTM that we could postpone until after as well.

@divega Merged.
@nschonni Thanks!


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Thank you for bringing up the issue. I've added a license to the project.