Unknown provider: PermissionStrategiesProvider

Hi,
I just updated to 2.2.0, now when using the permission attribute directive like so,
<div permission only="'loggedIn'">
I get:
Unknown provider: PermissionStrategiesProvider <- PermissionStrategies <- permissionDirective
Missing module? I do not see a PermissionStrategies anywhere in angular-permission.js.

I have the same problem.
Please fix it urgently

Now I have a new error:

I do not get the above error and I do now see the deprecation warnings now, however, I get:
TypeError: permissionNames.map is not a function

I am using 'permission permission-only', and the contained elements are not showing, even if the permission is present.

I just switched to using the **new syntax **permission-only=[...] vs just only=[...] and it appears to be working with no console errors.

Yes, you are right. It is working. The issue in my case is, that the element I have 'permission-only' on is outside of my root ng-view ina directive, so once the role gets updated, there was no update of the directive.
Maybe some scope.$on feature could be added as a feature, so that the ui gets updated if the roles change.

Maybe some scope.$on feature could be added as a feature, so that the ui gets updated if the roles change.

+1!!


Database Migrations

I'm thinking about moving away from EF and using TinyORM for a personal project of mine. Mostly for performance reasons, but also to have better control over everything and less magic happening.
EF as opposed to TinyORM also handles database migrations. I understand that this isn't really the focus of TinyORM, and that the mapping is supposed to be more dynamic and explicit. But if I'd be looking for some tool that would complement TinyORM and handle maintaining of database schema and database migrations, what would you recommend?
Do you have any personal experience with some of the tools out there, like the Database projects in VS, for example? I know that it's also possible to use EF migrations without using the rest of the full-featured framework, but I just wanted to pick your brain to see if you know about some db migrations library out there with similar principles as TinyORM (simple, fast, minimal), or your opinion on this matter in general.
Thanks for any feedback, sorry if this is a bit too off-topic.

@tompazourek At work we have built a custom schema extractor - a codegen which brings TSQL schemas into c# land, and improves both the TSQL-writing-from-c# experience, and the correctness of dynamic TSQL as the database schema evolves.

@sdrapkin That sounds like an interesting approach, thanks for sharing. May I ask how you handle versioning of the database schema, and migrating to newer versions of the schema?

@tompazourek Schema migrations are done as TSQL change scripts, checked in along with the c# code that leverages the schema changes, and versioned alongside with the code (ex. TFS). The scripts are either written manually (simple changes, such as add-a-new-column to a table), or generated with schema-diff'ing tools (more complex changes).

Thanks for your insights. Closing this now.


Remove deprecated method className() for branch 2.2.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

yii2-gii has the option to use the class constant or not in the model generator (https://github.com/yiisoft/yii2-gii/blob/master/src/generators/model/Generator.php#L53).
It won't cause immediate problems since the composer.json specifies "yiisoft/yii2": "~2.0.46" but this PR will brake that setting in the future.
I think it would be good to have a central place to keep track of these breaking changes. We could, for example, create an issue in the yii2-gii repo and add a Yii2.2 milestone.
@samdark What do you think about it?

Yii2-GII tiene la opción de utilizar la constante de clase o no en el generador de modelos (https://github.com/yiisoft/yii2-gii/blob/master/src/generators/model/Generator.php#L53). No causará problemas inmediatos ya que el composer.json especifica, pero este PR frenará esa configuración en el futuro. Creo que sería bueno tener un lugar central para hacer un seguimiento de estos cambios de última hora. Podríamos, por ejemplo, crear un problema en el repositorio yii2-gii y agregar un hito Yii2.2. ¿Qué opinas al respecto?"yiisoft/yii2": "~2.0.46"

If it is a good suggestion create the 2.2 branch. in all yii2 repositories, and run tests with the 2.2 branch, and update all changes.

This creates also a lot of problems with 3rd party extensions, making it quite impossible to upgrade existing apps.
Could we just keep in BaseObject.php (for now):
    public static function className()
    {
        return get_called_class();
    }

Maybe with an additional Yii::info(...) call.

@schmunk42 if we do that, then we will have problems as there will always be extension lagging.
That change can be fixed with simple search/replace and any extension unwilling to do that shouldn't really be considered as maintained.
Best option is letting extensions update themselves for that change

shouldn't really be considered as maintained.

I basically agree, but it's the reality.
There are also cases where this might be patched in an extension, but you still need an older version due to other constraints.
It's a fine line between BC and using more clean code.
But this is a huge blocker for existing projects. And makes it impossible just to test 2.2 for a lot of existing stuff.
In our case we'd have to override BaseObject in a very ugly way, since we can't fork a dozen repos just for a search and replace.
How about something like:
if (YII_ENABLE_20_BC_MODE) {
    public static function className()
    {
        return get_called_class();
    }
}

it has not to stay there forever, but would give developers the opportunity to have a more graceful way of upgrading.
PHP usually does the same for x.0 versions, hence the bigger problems with 8.1 and 8.2 atm.

shouldn't really be considered as maintained.

I basically agree, but it's the reality. There are also cases where this might be patched in an extension, but you still need an older version due to other constraints.
It's a fine line between BC and using more clean code.
But this is a huge blocker for existing projects. And makes it impossible just to test 2.2 for a lot of existing stuff. In our case we'd have to override BaseObject in a very ugly way, since we can't fork a dozen repos just for a search and replace.
How about something like:
if (YII_ENABLE_20_BC_MODE) {
    public static function className()
    {
        return get_called_class();
    }
}

it has not to stay there forever, but would give developers the opportunity to have a more graceful way of upgrading. PHP usually does the same for x.0 versions, hence the bigger problems with 8.1 and 8.2 atm.

For now we can keep it in BaseYii without deprecesiacion giving everyone time to change.

How about something like:

   public static function className()
   {
     return get_called_class();
}
}```

I think we can keep without adding the constant check. But with deprecation to warn people that it is going away!

shouldn't really be considered as maintained.

I basically agree, but it's the reality. There are also cases where this might be patched in an extension, but you still need an older version due to other constraints.
It's a fine line between BC and using more clean code.
But this is a huge blocker for existing projects. And makes it impossible just to test 2.2 for a lot of existing stuff. In our case we'd have to override BaseObject in a very ugly way, since we can't fork a dozen repos just for a search and replace.
How about something like:
if (YII_ENABLE_20_BC_MODE) {
    public static function className()
    {
        return get_called_class();
    }
}

it has not to stay there forever, but would give developers the opportunity to have a more graceful way of upgrading. PHP usually does the same for x.0 versions, hence the bigger problems with 8.1 and 8.2 atm.

For now we can keep without deprecated giving everyone time to change.

How are people going to notice that the function will be going away without deprecation?

shouldn't really be considered as maintained.

I basically agree, but it's the reality. There are also cases where this might be patched in an extension, but you still need an older version due to other constraints.
It's a fine line between BC and using more clean code.
But this is a huge blocker for existing projects. And makes it impossible just to test 2.2 for a lot of existing stuff. In our case we'd have to override BaseObject in a very ugly way, since we can't fork a dozen repos just for a search and replace.
How about something like:
if (YII_ENABLE_20_BC_MODE) {
    public static function className()
    {
        return get_called_class();
    }
}

it has not to stay there forever, but would give developers the opportunity to have a more graceful way of upgrading. PHP usually does the same for x.0 versions, hence the bigger problems with 8.1 and 8.2 atm.

For now we can keep without deprecated giving everyone time to change.

How are people going to notice that the function will be going away without deprecation?

You are so right.

@schmunk42

This creates also a lot of problems with 3rd party extensions, making it quite impossible to upgrade existing apps.

I agree with this, but could we do the following:
public static function className()
{
        return static::class;
}

Then we have at least some benefits of the newer PHP version 😅.


tus-server.upload.complete event (Symfony)

Hello,
Fire event Symfony
I can't fire events using symfony especially : tus-server.upload.complete, the one that i need.
To Reproduce

Uppy:

<script>
    const uppy = Uppy.Core(
        {
            debug: true,
            autoProceed: false,
            restrictions: {
                maxNumberOfFiles: 1,
                minNumberOfFiles: 1,
                allowedFileTypes: ['video/*', '.mkv']
            },
            allowMultipleUploads: false
        })
        .use(Uppy.Dashboard, {target: '#uppyUploader', inline: true})
        .use(Uppy.Tus, {
            endpoint: "http://localhost/tus/12",
            chunkSize: 20000,
            resume: true,
            limit:1
        });
    uppy.on('upload-success', (file, response) => {
        uppy.setFileState(file.id, { uploadURL: `/redirect/12` });
    })
</script>

Server side:
Controller

public function server(TusServerService $tusServerService, Entity $entity): Response{
    $server = $tusServerService->getServer($entity);
    return $server->serve()->send();
}

Service
public function getServerClip(Clip $clip): TusServer{
    $server = new TusServer();
    $server
        ->setApiPath('/tus/'.$clip->getId()) // tus server endpoint.
        ->setUploadDir($this->params->get('kernel.root_dir') . '/../web/uploads/clip/') // uploads dir.
        ->event()->addListener('tus-server.upload.complete', function (TusEvent $event) {
            // ...
        });
    return $server;
}

The event is not called after the upload....
What's going wrong ?

@giloo973 You are calling a method called getServer in the controller but in service, I see the listener is attached in getServerClip method. Is it a mistake while pasting the code here or are you attaching listener to one server object and using another?

Sorry my mistake ! But in my controller it’s getServerClip which is called.
The upload of the file is good, I get the uploaded file in the right folder. But the event is never called

@giloo973 The code to attach event looks fine to me. I assume that the event is being fired but is being killed because of some error. Did you check the error logs? It is hard to say anything without additional info.

I know.. the log file is empty... I will investigate again I’ll let you know


feat(dbm-services): switchlogs support app field filter

关联研发信息
dev_branch: feat/switchlogs_app_field_filter/#2771
target_branch: v1.3.0


打开NFT市场不显示任何信息

进入NFT市场提示提示NO Listings

closing this issue. reason: no pull request for collection referenced. please open a pull request with your ordinals collection in /ordinals-collections/collections/name-of-your-collection/meta.json and inscriptions.json


Update to Gradle 7

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Update to Gradle 7
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-java/issues/67
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock if you don't mind this one please, thank you

@vamshin @dblock sorry guys, mind taking a look? thank you

@vamshin @dblock could we merge this one? thank you!


fix: cloud account status stop at queuing after mannual sync

这个 PR 实现什么功能/修复什么问题:
修正：cloud account检测连接后停留在queuing状态
是否需要 backport 到之前的 release 分支:
NONE
/area region

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@7d76121). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #2270   +/-   ##
================================================
  Coverage                  ?   7.56%
================================================
  Files                     ?     410
  Lines                     ?   63612
  Branches                  ?       0
================================================
  Hits                      ?    4812
  Misses                    ?   58389
  Partials                  ?     411

Flag
Coverage Δ

#aFlag
7.56% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/cloudproviders.go
1.08% <0%> (ø)

pkg/compute/models/cloudproviderregions.go
0.38% <0%> (ø)

pkg/compute/models/cloudaccounts.go
0.99% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d76121...b73714e. Read the comment docs.


Custom dex

Hi
I see that many are requesting a dex for this game and a dex for that game, and a dex with all forms and so on.
I dont know how easy or difficult it is to make a new standard dex, but I do believe that however many you make you won't make everyone happy.
My suggestion is add an option to make custom dexes so that everyone can make their own personal dex with whatever they want in it.

Make every sprite available
Let us sort them ourself, do we want alolan forms for them self or do we want them on their dexnumber.
Allow them to choose how many rows/column.  Today it is 5x6. If we can change it to 5x5 we can use it with Pokemon Go or 3x3 so that I can check my TCG evolutiondex.
Sort/show only unmarked pokemon

Thanks for the work so far. It has been a huge help these last couple of games.

thanks for the feedback @Dandriii! i believe your requests are encompassed by these other tickets, so i'll be closing this one. feel free to recomment if you think i've missed something!

Make every sprite available - Not sure what you mean by this?
Let us sort them ourself, do we want alolan forms for them self or do we want them on their dexnumber: #328
Allow them to choose how many rows/column. Today it is 5x6. If we can change it to 5x5 we can use it with Pokemon Go or 3x3 so that I can check my TCG evolutiondex. #327
Sort/show only unmarked pokemon #136


Please fix issues reported by adapter checker

❗ [E184] "common.subscribe" will be removed with js-controller >= 6. Please remove from io-package.json and adapt code if required.
👀 [W105] Missing suggested translation into uk of "common.titleLang" in io-package.json.
👀 [W109] Missing suggested translation into uk of "common.desc" in io-package.json.
👀 [W145] Missing suggested translation into uk of some "common.news" in io-package.json.
👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".

replaces be #363


how to add features (sub-modules) in angular-meteor (using angular2)

I have just gone through tutorial of angular-meteor (socially) and angular 2 (https://angular.io/docs/ts/latest/guide/router.html). In the angular2 guide, they have mentioned how to create submodules (features) and then how it can be easily imported into the app.module.ts. But the issue here is that in meteor-app there is no such app.module.ts and instead they have app.main.ts and in it there is the bootstrap class which tells the entry point in the app. It takes only a component and providers. Please tell me how can we add submodules (features) in the angular-meteor.

I guess the socially tutorial is outdated and for RC4.
To use RC5:
Bootstrapping in main.ts:
import {platformBrowserDynamic} from "@angular/platform-browser-dynamic";
import {AppModule} from "path-to-your-module/app.module";

platformBrowserDynamic().bootstrapModule(AppModule);

index.html example:
`

`
Modules are created like this:
@NgModule({
    imports: [],
    declarations: [AppComponent],
    bootstrap: [AppComponent]
})
export class AppModule {}

Read futher details about modules and it's imports, declarations, etc. here:
https://angular.io/docs/ts/latest/guide/ngmodule.html
RC6 seems not to be supported until now.

Thank you for pointing me to rc4 issue. Now I have create a new app with the updated package.json to install the new dependencies.
`
"@angular/common": "2.0.0-rc.6",
"@angular/compiler": "2.0.0-rc.6",
"@angular/compiler-cli": "0.6.0",
"@angular/core": "2.0.0-rc.6",
"@angular/forms": "2.0.0-rc.6",
"@angular/http": "2.0.0-rc.6",
"@angular/platform-browser": "2.0.0-rc.6",
"@angular/platform-browser-dynamic": "2.0.0-rc.6",
"@angular/router": "3.0.0-rc.2",
"@angular/upgrade": "2.0.0-rc.6",

"angular2-meteor": "0.6.2",
"angular2-meteor-auto-bootstrap": "0.6.0",
"angular2-meteor-polyfills": "0.1.1",
"angular2-meteor-tests-polyfills": "0.0.2",

"es6-shim": "0.35.1",
"meteor-node-stubs": "0.2.3",

"core-js": "^2.4.1",
"reflect-metadata": "^0.1.3",
"rxjs": "5.0.0-beta.11",
"systemjs": "0.19.27",
"zone.js": "^0.6.17",

"angular2-in-memory-web-api": "0.0.18",
"bootstrap": "^3.3.6"`

Then I created a new app.module.ts in the client folder. Its code is below:
`
import { NgModule }      from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
@NgModule({
  imports:      [ BrowserModule ]
})

export class AppModule { }

`
But now it is throwing the error that NgModule can't be found. Please guide

As mentioned, RC6 is not supported yet.
"@angular/common": "2.0.0-rc.6",
"@angular/compiler": "2.0.0-rc.6",
"@angular/core": "2.0.0-rc.6",
"@angular/forms": "2.0.0-rc.6",
"@angular/http": "2.0.0-rc.6",
"@angular/platform-browser": "2.0.0-rc.6",
"@angular/platform-browser-dynamic": "2.0.0-rc.6",

should be
"@angular/common": "=2.0.0-rc.5",
"@angular/compiler": "=2.0.0-rc.5",
"@angular/core": "=2.0.0-rc.5",
"@angular/forms": "=2.0.0-rc.5",
"@angular/http": "=2.0.0-rc.5",
"@angular/platform-browser": "=2.0.0-rc.5",
"@angular/platform-browser-dynamic": "=2.0.0-rc.5",

Don't forget to clean out the node_modules directory and reinstall with "meteor npm install".

Thank you for quick reply.
I remove my node_modules directory. Changed the package.json code with this one
`
"@angular/common": "^2.0.0-rc.5",
"@angular/compiler": "^2.0.0-rc.5",
"@angular/core": "^2.0.0-rc.5",
"@angular/forms": "^2.0.0-rc.5",
"@angular/http": "^2.0.0-rc.5",
"@angular/platform-browser": "^2.0.0-rc.5",
"@angular/platform-browser-dynamic": "^2.0.0-rc.5",
"@angular/router": "^3.0.0-rc.2",

`
But still unable to import NgModule in my meteor app
import { NgModule }      from '@angular/core';
it is throwing this error

Module '"/home/mista/meteor-app/socially/node_modules/@angular/core/index"' has no exported member 'NgModule'.at line 1 col 10

Ok, than it's a problem with the typescript typings.
Look up the "moduleResolution" in tsconfig.json. It should be:
 "moduleResolution": "node",
to make typescript look in your node_modules directory for typings files.

"moduleResolution": "node",  this is already there in tsconfig.json.
Below is my tsconfig.json
`
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"isolatedModules": false,
"moduleResolution": "node",
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"removeComments": false,
"noImplicitAny": false,
"sourceMap": true
},
"exclude": [
"node_modules"
],
"compileOnSave": false
}
`
I want to point out that i can easily import  this import { Component } from '@angular/core'; from the core module

Also set "experimentalDecorators" to true and set the "filesGlob" Array to the same as in my example:
{
  "compilerOptions": {
    "experimentalDecorators": true,
    "module": "commonjs",
    "target": "es5",
    "isolatedModules": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "removeComments": false,
    "noImplicitAny": false,
    "sourceMap": true
  },
  "filesGlob": [
    "client/**/*.ts",
    "imports/**/*.ts",
    "server/**/*.ts",
    "typings/**/*.d.ts"
  ],
  "exclude": [
    "node_modules"
  ]
}

I have added "fileGlod" but it is still showing the same error. It is throwing error for these two modules
`
import { NgModule }      from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';

`
However i can easily import other modules like
import { FormsModule } from '@angular/forms';

Try not using the "^"operator but "=" in the package json (to really get RC5) and delete the nodes_module@angular directory before using "meteor nmp install" again...
"@angular/core": "=2.0.0-rc.5",
If that doesn't work, I'm running out of ideas :)

Ahh one more:
use the newest version of angular-meteor:
"angular2-meteor": "^0.7.0-beta.1",

I am sorry but still error is there.
To be safe I am deleting the node_modules directory, implementing the changes you mentioned and then ran meteor npm install but still the same issue.
Could you please tell me how are you using angular2-meteor? Are you able to use NgModule and easily create submodules and also include routing in it as they mentioned.

Yes I'm using feature modules as well as a core module and shared module as described in the angular docs. I do routing in the responsible feature module.

Is it possible that you can share your package.json or some example repo which I can see to figure out what wrong I am doing.
Before I have developed web-app using turbogears2 (python mvc framework). But after reading about meteor and angular2 and going through various videos i wanted to use angular2-meteor. In one of the video Urigo mentioned that angular2 and meteor team are working together to create this framework. Since last 10 days i ( and my team also)  have been learning curiously angular2 and meteor. I have tried tutorials of both angular2 and angular2-meteor, they worked fine but when we are combing things, it is throwing error. We want to use this angular2-meteor. Please suggest

Here's my whole package.json:
{
  "name": "sbs",
  "private": true,
  "scripts": {
    "start": "meteor run"
  },
  "dependencies": {
    "@angular/common": "=2.0.0-rc.5",
    "@angular/compiler": "=2.0.0-rc.5",
    "@angular/core": "=2.0.0-rc.5",
    "@angular/forms": "^2.0.0-rc.6",
    "@angular/platform-browser": "=2.0.0-rc.5",
    "@angular/platform-browser-dynamic": "=2.0.0-rc.5",
    "@angular/router": "^3.0.0-rc.2",
    "angular2-meteor": "^0.7.0-beta.1",
    "angular2-meteor-polyfills": "^0.1.1",
    "bcrypt": "^0.8.7",
    "bootstrap-sass": "^3.3.7",
    "bootswatch": "^3.3.7",
    "meteor-node-stubs": "^0.2.3",
    "ng2-bootstrap": "^1.0.24",
    "reflect-metadata": "^0.1.8",
    "rxjs": "^5.0.0-beta.11",
    "zone.js": "^0.6.17"
  },
  "devDependencies": {
    "tslint": "^3.14.0",
    "typescript": "^2.0.2"
  }
}

my complete app.module.ts:
import { NgModule }         from '@angular/core';

//Imports
import {BrowserModule}      from '@angular/platform-browser';
import {SharedModule}       from '../_shared/shared.module';
import {CoreModule} from '../_core/core.module';
import {routing}            from '../_app/app.routing';
//Feature imports
import {DashboardModule}    from '../dashboard/dashboard.module';
import {ModuleSelectorModule} from '../module-selector/module-selector.module';
import {ItemModule} from '../item/item.module';
import {UserModule} from '../user/user.module';

//Declarations
import {AppComponent}      from './app.component';

@NgModule({
    imports: [
        BrowserModule,
        SharedModule,
        CoreModule,
        routing,
        // Feature modules:
        DashboardModule,
        ModuleSelectorModule,
        ItemModule,
        UserModule
    ],
    declarations: [
        AppComponent
    ],
    bootstrap: [AppComponent]
})
export class AppModule {}

Thank you very much for sharing this. I will keep on working on it

@neeraj1928 https://github.com/Tallyb/meteor-angular2.0-socially/tree/rc5 (note: RC5 branch!) has a project that works. It has lot of issues that I did not work out (layout, ngmaps etc.) but it can bootstrap.
check your meteor npm and node versions (meteor npm -v, meteor node -v)

meteor npm -v  is 3.10.6  and meteor node -v is 4.5.0.
Thank you for sharing this branch. I will go through it.

@Tallyb I am trying to bootstrap your given branch. But it is throwing this error
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'typings install'. npm ERR! Make sure you have the latest version of node.js and npm installed.
version of node installed in my system is 'node/6.5.0' (node --version) but when i run meteor node --version it show 4.5.0. How to update node inside meteor?

@neeraj1928  you cannot upgrade inside meteor.  It seems to be like a typings issue. Do you have typings install? which version?

typings version is 3.10.6 (meteor npm typings -v)

nay, this is meteor npm version. what happens in "typings -v"?

npm typings -v shows 3.10.3

no npm - just typings

sorry, it is not installed (command not found is showing).  Should i install it with sudo apt-get install typings

ok - this seems to be the problem.
` npm install -g typings

@Tallyb Thank you very much. I installed typings and now I can boostrap your branch. Thank you very much. Just one more thing, could please suggest good package to add material design to my project.

And could you also tell what error made you think that this is the issue of typings?

@neeraj1928  Angular2-material is the most appropriate. I installed ng2-material to use layout directives. I do not think there is anything better.
PS - care to star my project?

it says the problem here is the typings:  Failed at the<EMAIL_ADDRESS>postinstall script 'typings install'

ok. Thank you very much for your support


Add sites 'xlthlx.com' and 'piccioni.london'

This PR is:

*[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

*[x] I used the uncompressed size of the site
*[x] I have included a link to the GTMetrix report
*[x]  The domain is in the correct alphabetical order
*[x] This site is not a ultra lightweight site
*[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

*[x] Check to confirm

- domain: piccioni.london
  url: https://piccioni.london/
  size: 374
  last_checked: 2022-06-27

- domain: xlthlx.com
  url: https://xlthlx.com/
  size: 434
  last_checked: 2022-06-27

GTMetrix Report for piccioni.london: https://gtmetrix.com/reports/piccioni.london/utAlSP03/
GTMetrix Report for xlthlx.com: https://gtmetrix.com/reports/xlthlx.com/YNc05KUD/

Thanks for your submission! Do you mind fixing the alphabecial ordering?

Thanks for your submission! Do you mind fixing the alphabecial ordering?

Thanks, Garrit, sorry about that, I'm going to fix it now.


position absolute / table

Why is position absolute by default? All list is almost in the center of the browser, I need to use it inside table to load tr>td, but seems I can't. Tried to do a lot of CSS hacks, but still... Maybe anyone has any suggestions?
I need to make infinite scrolling inside table to load all the data. This seems to work perfectly, but I can't fix CSS.
cc @rwjblue @stefanpenner @taras @lukemelia @twokul @krisselden

This also breaks our tooltips, which render behind our collections. Ember collections are built to use position: absolute and transform: matrix3d to stack things. This is bad. Everything in the collection could be in-flow, but to make infinite scroll work, it's been implemented with this hack. Although it works in isolation, it does not work in the wild where people use absolute to make this float over other things.
Also, the list is in reverse order in the dom which probably breaks accessibility. We literally can't use this library :( I also fear that it promotes really bad html and css, and makes unsuspecting developers add all kinds of z-index hacks trying to work around it. Maybe it should be deprecated to avoid spread these bad practices. Anger.

@andrewzamojc-pd Did you try html-next/vertical-collection?


Simplify app-configuration tests

Could you please review @radcortez ?
I still wonder why the test application outputs these warnings?
[INFO] 2022-12-06 22:56:05,053 WARN  [io.qua.config] (main) Unrecognized configuration key "quarkus.azure.app.configuration.secret" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
[INFO] 2022-12-06 22:56:05,055 WARN  [io.qua.config] (main) Unrecognized configuration key "quarkus.azure.app.configuration.id" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
[INFO] 2022-12-06 22:56:05,056 WARN  [io.qua.config] (main) Unrecognized configuration key "quarkus.azure.app.configuration.endpoint" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo

Hum, it seems we have a bug reporting the Unrecognized properties in the static Config when the mapping is runtime only, and the configuration is only available at runtime. I'll have to check and fix this on the Quarkus side.

Is this good to merge @agoncal ?

Thanks @ppalaga @radcortez

@all-contributors please add @ppalaga for code

@all-contributors please add @radcortez for review


Segwit address calculation for different networks

Hello,
Thanks for adding support for SegWit.
As I have tested
For pubkey: 02ef43bcd42dd7dd37015e8bc76312e4c52c2d3920c16cab185499f12b02740458
1- GetSegwitAddress(Network.Main) returns p2xtf4PnGQFMtEgRREb3UcNLDHx3YwzdNjLW
2- GetSegwitAddress(Network.TestNet) returns p2xtf4PnGQFMtEgRREb3UcNLDHx3YwzdNjLW
3- GetSegwitAddress(Network.SegNet) returns QWywvQ6dAwCfEM8yRJew4Z98X7SgtCcUoxZN
As I understand from https://github.com/bitcoin/bips/blob/master/bip-0142.mediawiki the return values should be:
1- GetSegwitAddress(Network.Main): p2xtf4PnGQFMtEgRREb3UcNLDHx3YwzdNjLW
2- GetSegwitAddress(Network.TestNet): QWywvQ6dAwCfEM8yRJew4Z98X7SgtCcUoxZN

@bijakatlykkex Yes, TestNet and SegNet have to use the same base58Prefix. I think the following lines are missing for the testnet initialization:
base58Prefixes[(int)Base58Type.WITNESS_P2WPKH] = new byte[] { 0x3 };
base58Prefixes[(int)Base58Type.WITNESS_P2WSH] = new byte[] { (40) };

Indeed. Actually BIP142 will likely not be used in the future, but I'll fix it nevertheless.
Problem is that my current dev environment is in limbo and I need to install visual studio 2015. But my msdn account is bugged and microsoft fixing it... long story short, I'll fix it in 1 or 2 days :p

Thanks for the comments. But actually as I understand, SegWit is not a different network. We either have main or testnet; and segwit addresses are just one type of address in these networks.

There is the Segnet network right now (https://segnet.smartbit.com.au/)
It will probably disappear at one point.
Yes, Testnet addresses should be the same than Segnet one, this is a bug I need to fix.

fixed it


tlssig test takes huge amount of time

Describe the bug
 Cloudflare:
  x25519_kyber768 @ oqsprovider
kex=X25519Kyber768Draft00
  x25519_kyber512 @ oqsprovider
kex=X25519Kyber512Draft00
Test project /Users/ur20980/src/oqs-provider/_build
    Start 1: oqs_signatures
1/6 Test #1: oqs_signatures ...................   Passed    3.99 sec
    Start 2: oqs_kems
2/6 Test #2: oqs_kems .........................   Passed    0.24 sec
    Start 3: oqs_groups
3/6 Test #3: oqs_groups .......................   Passed    0.38 sec
    Start 4: oqs_tlssig
4/6 Test #4: oqs_tlssig .......................   Passed  271.71 sec
    Start 5: oqs_endecode
5/6 Test #5: oqs_endecode .....................   Passed    8.92 sec
    Start 6: oqs_evp_pkey_params
6/6 Test #6: oqs_evp_pkey_params ..............   Passed    1.27 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 288.36 sec

All the other tests take within 1 to 10 seconds. oqs_tlssig test takes about 272 seconds. It used to run on par with the other tests. I think something is wrong here.
This is with OpenSSL master.
To Reproduce
Configure, build, and run scripts/runtests.sh. Observe the timing.
Expected behavior
Here's the timing from the Macports-installed OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 Jun 2024):
 Cloudflare:
  x25519_kyber768 @ oqsprovider
kex=X25519Kyber768Draft00
  x25519_kyber512 @ oqsprovider
kex=X25519Kyber512Draft00
Test project /Users/ur20980/src/oqs-provider/_build
    Start 1: oqs_signatures
1/6 Test #1: oqs_signatures ...................   Passed    4.30 sec
    Start 2: oqs_kems
2/6 Test #2: oqs_kems .........................   Passed    0.33 sec
    Start 3: oqs_groups
3/6 Test #3: oqs_groups .......................   Passed    0.47 sec
    Start 4: oqs_tlssig
4/6 Test #4: oqs_tlssig .......................   Passed    3.22 sec
    Start 5: oqs_endecode
5/6 Test #5: oqs_endecode .....................   Passed   10.40 sec
    Start 6: oqs_evp_pkey_params
6/6 Test #6: oqs_evp_pkey_params ..............   Passed    1.07 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =  19.81 sec

Environment (please complete the following information):

OS: MacOS Sonoma
OpenSSL version: OpenSSL 3.4.0-dev  (Library: OpenSSL 3.4.0-dev )
oqsprovider version: 0.6.2-dev

Please run the following commands to obtain the version information:
$ openssl3 version
OpenSSL 3.4.0-dev  (Library: OpenSSL 3.4.0-dev )
$ openssl3 list -providers
Providers:
  default
    name: OpenSSL Default Provider
    version: 3.4.0
    status: active
  legacy
    name: OpenSSL Legacy Provider
    version: 3.3.1
    status: active
  oqs
    name: OpenSSL OQS Provider
    version: 0.6.2-dev
    status: active
  pkcs11
    name: PKCS#11 Provider
    version: 3.3.1
    status: active
$
$ openssl version
OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 Jun 2024)
$ openssl list -providers
Providers:
  default
    name: OpenSSL Default Provider
    version: 3.3.1
    status: active
  legacy
    name: OpenSSL Legacy Provider
    version: 3.3.1
    status: active
  oqs
    name: OpenSSL OQS Provider
    version: 0.6.2-dev
    status: active
  pkcs11
    name: PKCS#11 Provider
    version: 3.3.1
    status: active
  vigenere
    version: 1.2
$

Wow -- so the only thing changed between the two runs above is the OpenSSL version (3.3.1 vs. master)? Same oqsprovider/liboqs code? Same platform (OSX)? Any difference in baseline openssl speed (performance) tests?

If you name a specific test(s), I'd be happy to run it and report. Offhand, I'd say - no. But I'd be happier if I could give you specific numbers.

I cannot -- as I have no clue which part of OpenSSL could trigger this. I just thought you might have run openssl speed in both of your configurations to see whether there are obvious deviations,  @mouse07410 . Another question: Is this aarch64 or x64?
@levitte @romen As I cannot reproduce this on my machine (x64, Ubuntu) -- have you heard of any such, probably platform-dependent performance degradation of openssl "master"?

@mouse07410 FWIW, I now re-ran your setup (openssl 3.3.1 vs master) on a Mac M1 running MacOS 13.5, not yet Sonoma without problem:
Test setup:
LD_LIBRARY_PATH=/Users/baentsch/git/oqs-provider/.local/lib
OPENSSL_APP=/Users/baentsch/git/oqs-provider/openssl/apps/openssl
OPENSSL_CONF=/Users/baentsch/git/oqs-provider/scripts/openssl-ca.cnf
OPENSSL_MODULES=/Users/baentsch/git/oqs-provider/_build/lib
DYLD_LIBRARY_PATH=/Users/baentsch/git/oqs-provider/.local/lib
Version information:
OpenSSL 3.4.0-dev  (Library: OpenSSL 3.4.0-dev )
Providers:
  default
    name: OpenSSL Default Provider
    version: 3.4.0
    status: active
    build info: 3.4.0-dev
    gettable provider parameters:
      name: pointer to a UTF8 encoded string (arbitrary size)
      version: pointer to a UTF8 encoded string (arbitrary size)
      buildinfo: pointer to a UTF8 encoded string (arbitrary size)
      status: integer (arbitrary size)
  oqsprovider
    name: OpenSSL OQS Provider
    version: 0.6.2-dev
    status: active
    build info: OQS Provider v.0.6.2-dev (bf10e6e) based on liboqs v.0.10.2-dev
    gettable provider parameters:
      name: pointer to a UTF8 encoded string (arbitrary size)
      version: pointer to a UTF8 encoded string (arbitrary size)
      buildinfo: pointer to a UTF8 encoded string (arbitrary size)
      status: integer (arbitrary size)
Cert gen/verify, CMS sign/verify, CA tests for all enabled OQS signature algorithms commencing:
........................................................
External interop tests commencing
 Cloudflare:
  x25519_kyber768 @ oqsprovider
kex=X25519Kyber768Draft00
  x25519_kyber512 @ oqsprovider
kex=X25519Kyber512Draft00
Test project /Users/baentsch/git/oqs-provider/_build
    Start 1: oqs_signatures
1/6 Test #1: oqs_signatures ...................   Passed    5.90 sec
    Start 2: oqs_kems
2/6 Test #2: oqs_kems .........................   Passed    0.69 sec
    Start 3: oqs_groups
3/6 Test #3: oqs_groups .......................   Passed    0.90 sec
    Start 4: oqs_tlssig
4/6 Test #4: oqs_tlssig .......................   Passed    4.47 sec
    Start 5: oqs_endecode
5/6 Test #5: oqs_endecode .....................   Passed   10.02 sec
    Start 6: oqs_evp_pkey_params
6/6 Test #6: oqs_evp_pkey_params ..............   Passed    1.61 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =  23.59 sec

My experience on M2 chip is similar, but the delay is not as drastic.

So what was the platform you used initally (HW/OS/compilers/openssl config/build flags)? How can we reproduce your results?
One more thought: If the consideration were right that this has to do with some changes in the openssl crypto in "master", what about you build oqsprovider (rather the underlying liboqs) completely without use of openssl primitives (setting cmake config variable OQS_USE_OPENSSL=OFF) and see whether the results persist? Another suggestion would be you build openssl v3.3.1 also from source -- if the slowdown happens then too, it has to do with the config/compilation environment and neither oqsprovider nor openssl code.

--debug passed to the config script

That's IMO a substantial enough difference between a "release" level/MacPorts OSSL 3.3.1 and your own build 3.4.0-dev I'd argue.
-> Please try running 3.3.1 also "manually" built and configured like the 3.4.0-dev and I bet it'll be as slow as 3.4.0-dev. And/or config 3.4.0/master without --debug.
Another suggestion: You may want to run the ctests with the verbose option to see whether there's actually any marked difference in per-algorithm runtime (each one is output if run verbose): That would be another indication whether there are algorithm-specific primitives triggering this slowdown or a general/"systematic" problem with the TLS sig logic.

Would you mind posting the exact command (and what dir I should execute it, and what env vars it requires)?

Easiest if you run scripts/runtests.sh -V (passes that arg to ctest).

@levitte @romen As I cannot reproduce this on my machine (x64, Ubuntu) -- have you heard of any such, probably platform-dependent performance degradation of openssl "master"?

Unfortunately, no.
I'd suggest raising an issue with OpenSSL.


Extract global name "STORYBOOK_ANGULAR_ARG_TYPES"

Right now, STORYBOOK_ANGULAR_ARG_TYPES is used multiple times.
Should be excluded as constant

Fixed in #6


A little help please :)

I've been folowing instructions.. but have not a result except

a white screen and a toggle button that doesn't seems to do anything
Also.. a question.. Is this a "web-based-helbreath?"
Best regards from Argentina.

This is the UI that is loaded within the HB client. It won't do anything within a browser context.


Allow dots  to be used when cilium install is executed

Proposal / RFE
Is your feature request related to a problem?
Yes
Describe the solution you'd like
Support using cilium cli where the cluster has dot in the name other command like cilium connectivity test can connect and work fine.
(⎈ |eks1.dev.xxxx.xx.aws:default)➜  cilium cilium install hubble
ℹ  using Cilium version "v1.9.8"
🔮 Auto-detected cluster name: eks1.dev.xxxx.xx.aws
🔮 Auto-detected IPAM mode: cluster-pool
❌ Cluster name "eks1.dev.xxxx.xx.aws" cannot contain dots
↩ Rolling back installation...

Error: Unable to install Cilium: invalid cluster name, dots are not allowed

+1 for this feature 👍


[incubator/couchdb] Add a chart for Apache CouchDB

This PR adds a chart that deploys Apache CouchDB as a StatefulSet. It defaults to using the image from the official Docker repository as the primary container in each Pod, and attaches a second sidecar container to help the Pods in the StatefulSet discover and connect to one another. Some other notable features include:

Use of a Secret to supply initial admin username and password
Ability to customize the server configuration through a ConfigMap
Optional use of PVCs for persistence

I've tried to adhere to the contribution guidelines but do let me know if you see anything amiss.

Hopefully the CLA is sorted:

Hi folks, hope you all had a blast down in Austin. Let me know if there's anything else I can do here to jumpstart the review process.


Cannot conda install on windows

Hi!
I can't install this package on windows using conda (mamba). The culprit is python-magic dependency, which is only available on osx & linux (https://anaconda.org/conda-forge/python-magic).
From the pyproject.toml it seems that python-magic is a dev dependency, so maybe it could be removed from the conda package dependencies?
Looking for: ["earthaccess[version='>=0.5.0']"]

conda-forge/win-64                                          Using cache
conda-forge/noarch                                          Using cache
Could not solve for environment specs
Encountered problems while solving:
  - nothing provides python-magic >=0.4 needed by earthaccess-0.5.0-pyhd8ed1ab_0

The environment can't be solved, aborting the operation

Good timing, @psarka we just released v0.5.1 that removes python-magic from the core dependencies. Can you give it a try and tell us if it works with
mamba install -c conda-forge earthaccess=0.5.1

if mamba is not available you can use conda

If it works and you have a conda environment file you have to specify
name: test
channels:
- conda-forge
dependencies:
- python=3.9
- earthaccess>=0.5.1

It does, thank you very much! ❤


Include wordclass into weighting scheme

Currently, the weighting script for dictionary entries does not distinguish lemmas with ambiguous wordclass designations. This can result in suboptimal weights, and should be easily fixable in the the weighting script (extended from #163):
 ~/giella/langs/crk/tools/shellscripts/wolvengrey-weight.sh

The following script creates a lemma+POS frequency count of the A-W corpus:
cat ~/giella/art/corp/crk/ahenakew_wolfart.vrt | egrep -v '^<' | hfst-optimized-lookup -q src/analyser-gt-norm.hfstol | gawk 'BEGIN { FS="\n"; RS=""; } { split($1,f,"\t"); printf "%s", f[1]; if(f[3]=="+?") printf "\t+?"; else for(i=1; i<=NF; i++) { split($i,f,"\t"); printf "\t%s", f[2]; } printf "\n"; }' | tools/shellscripts/fst-horiz-tab2cg-vrt.sh | vislcg3 -g    src/syntax/disambiguator.cg3 | vislcg3 -g src/syntax/functions.cg3 |    tools/shellscripts/cg-vrt2horiz-tab2min-morph.sh | less | gawk -F"\t" 'NF>=2 && $2!="" && $0 ~ /^[^<]/ { sub("(((IC)|(PV/[^ ]*)|(Rdpl[SW])) )+","",$2); match($2,"(^[^ ]+) ((N (A|I)( D)?)|(V (II|AI|TI|TA))|(Ipc)|(Pron)|(Num))",f); gsub(" ","",f[2]); if(f[1]!="") print f[1], f[2]; }' | sort | uniq -c | sort -nr > ~/giella/art/corp/crk/ahenakew_wolfart_lemma+pos_freq-sorted.txt

The result is stored in: ~/giella/art/corp/crk/ahenakew_wolfart_lemma+pos_freq-sorted.txt and eventually also on sapir.

This has been turned obsolete with the new relevance ranking.


Merge Conflict Occur

During merging the django3 branch into the master, a conflict error occurred.

Issue has been resolved.


Turn off browser autocomplete for search DAG

Currently when you are searching for a DAG in the Airflow UI, the browser (like Chrome) will provide typeahead based on your search history which blocks the typeahead support from Airflow UI. Therefore, turning off the autocomplete from the browser to respect the recommendation from airflow UI.

@ArgentFalcon @andrewsta
@lyft/dp-tools-viz

oh cool. I didn't know you could do that

👍

do we have a list of prs that are not in both branch(data-platform-upgrade and airflowinfra)?

👀 I doubt it. We should also open this against airflowinfra


caches

We need this for LUCI to recognize these directories in the recipe are actually cache dirs that are meant to be reused on the bots.

lgtm!


Marker Interfaces for indexing strategies

While trying the pdo adapter I ran into an issue due to a wrong indexing strategy used by the adapter.
I wanted to use pdo_pgsql but did not configure the indexing strategy so the factory used the MySql indexing strategy as a default.
I got a syntax error:
Fatal error: Uncaught Prooph\EventStore\Adapter\Exception\RuntimeException: Error during createSchemaFor: 42601; 7; ERROR:  syntax error at or near "`"
LINE 1: CREATE TABLE `_878c0b7e51ecaab95c511fc816ad2a70c9418208` (
                     ^ in /var/www/html/vendor/prooph/event-store-pdo-adapter/src/PDOEventStoreAdapter.php:354

We should either remove the default to force the user to set a strategy or mark the strategies with vendor specific interfaces so that the PdoAdapter can check if an indexing strategy is used that can work together with the used database vendor.

done by eb2094a147d4fb78bfac32f57583dabf678fac1b


Enable user defined and JSBSim Magnetometer XML Input Mapping

Proposal Description

Enable the user to map JSBSim variables to the bridge input properties via airframe configuration files as per previous.
Provide an example model of varying magnetometer bias based on throttle input in px4_default_mag_sensor.xml.
Does not modify the default behavior of any airframe
NOTE: Stable JSBSim magnetometer startup behavior dependent on https://github.com/JSBSim-Team/jsbsim/issues/332

To Test

Build separate branch of JSBSim: https://github.com/mvacanti/jsbsim/tree/pr-update-mag-startup
Modify configs/quadrotor.xml to map desired variables
Modify models/quadrotor.xml to include default_px4_mag_sensor.xml system file

I am done with my work, are you OK with the way I handled the open issue with JSBSim?

@mvacanti Yes, but does this mean that it would fail for other jsbsim distributions?

@Jaeyoung-Lim on the current JSBSim release it does not fail outright when using the magnetometer system file, for the first several seconds it creates an EKF magnetometer error that prevents arming due to erroneous startup data followed by a step-change. Once that clears it works fine. I have a PR for JSBSim that will be rolled into the next bug-fix release. The default behavior (no magnetometer JSB system) is unaffected by either.

@mvacanti Thanks, looks like your fix went into jsbsim! merging!


add initial modal bi-encoder app

Add initial modal bi-encoder app
Features
FastAPI app

deployable on Modal
endpoints include /encode and /cosine_similarity
will include finetune endpoint in next PR

README

Summary
Installation instructions
Usage instructions and example calls for both local/modal deployment

Future features
Finetune endpoint

finetune the sentence transformer model given input data
Will be based on code here: https://www.sbert.net/docs/training/overview.html#loss-functions

from sentence_transformers import SentenceTransformer, InputExample, losses
from torch.utils.data import DataLoader

#Define the model. Either from scratch of by loading a pre-trained model
model = SentenceTransformer('distilbert-base-nli-mean-tokens')

#Define your train examples. You need more than just two examples...
train_examples = [InputExample(texts=['My first sentence', 'My second sentence'], label=0.8),
    InputExample(texts=['Another pair', 'Unrelated sentence'], label=0.3)]

#Define your train dataset, the dataloader and the train loss
train_dataloader = DataLoader(train_examples, shuffle=True, batch_size=16)
train_loss = losses.CosineSimilarityLoss(model)

#Tune the model
model.fit(train_objectives=[(train_dataloader, train_loss)], epochs=1, warmup_steps=100)

will create a new src/datasets.py file to handle importing data
modify existing /encode and /cosine_similarity endpoints to be able to use the new finetuned model
figure out how to make the finetuned model downloadable locally and on modal

outdated PR, see here for the updated one: https://github.com/567-labs/fastllm/pull/28


lighthouse: 3.5.1 -> 4.0.1

Description of changes
Release notes.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It might be worth going for the 4.0.2-rc0 over this version now, because it has a hotfix for the high cpu bug in 4.0.1

@ekimber I've updated to 4.1.0 instead.


Always process each prefix when programming routes

bug fix.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 19 (78.95%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 68.147%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sysrib/server.go
14
18
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
3222

Relevant Lines:
4728

💛  - Coveralls


User namespaces on Funtoo/Gentoo

Description of problem:
Cannot use user namespaces on Funtoo/Gentoo.
docker version:
Client:
 Version:      1.10.0
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   590d510
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.0
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   590d510
 Built:
 OS/Arch:      linux/amd64

docker info:
Containers: 4
 Running: 0
 Paused: 0
 Stopped: 4
Images: 1
Server Version: 1.10.0
Storage Driver: zfs
 Zpool: system
 Zpool Health: ONLINE
 Parent Dataset: system/docker
 Space Used By Parent: 6516736
 Space Available:<PHONE_NUMBER>32
 Parent Quota: no
 Compression: on
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: host bridge null
Kernel Version: 4.5.0-rc4
Operating System: Linux
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.706 GiB
Name: cylae
ID: --------------------------
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support

uname -a:
Linux cylae 4.5.0-rc4 #2 SMP PREEMPT Sat Feb 20 22:42:48 CET 2016 x86_64 Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz GenuineIntel GNU/Linux

Environment details (AWS, VirtualBox, physical, etc.):
OS: Funtoo Linux (current)
Steps to Reproduce:

Start docker daemon with option "--userns-remap=default"
docker pull alpine
docker run -it alpine /bin/sh

Actual Results:
Timestamp: 2016-02-21 01:57:13.003810235 +0100 CET
Code: System error

Message: stat /run/lxcfs/controllers/name=openrc/docker: permission denied

Frames:
---
0: setupRootfs
Package: github.com/opencontainers/runc/libcontainer
File: rootfs_linux.go@40
---
1: Init
Package: github.com/opencontainers/runc/libcontainer.(*linuxStandardInit)
File: standard_init_linux.go@57
---
2: StartInitialization
Package: github.com/opencontainers/runc/libcontainer.(*LinuxFactory)
File: factory_linux.go@240
---
3: initializer
Package: github.com/docker/docker/daemon/execdriver/native
File: init.go@35
---
4: Init
Package: github.com/docker/docker/pkg/reexec
File: reexec.go@26
---
5: main
Package: main
File: docker.go@18
---
6: main
Package: runtime
File: proc.go@111
---
7: goexit
Package: runtime
File: asm_amd64.s@1721
docker: Error response from daemon: Container command could not be invoked..

Expected Results:
/bin/sh prompt in container
Additional info:

cgmanager and lxcfs are setup on the host correctly, lxd is also working perfectly.
The error above shows the cgroup OpenRC puts the docker daemon into (automatically) in its own controller, so maybe the OpenRC controller it not handled by docker?

I can manually bypass this first error by applying chmod o+rx on /run/lxcfs/controllers/name=openrc/docker from top to bottom. This, however, then leads to the next error:
Timestamp: 2016-02-21 12:00:06.341250015 +0100 CET
Code: System error

Message: can't create pivot_root dir , error mkdir /var/lib/docker/165536.165536/zfs/graph/395e2ecc9815703acef008ea43c6311d4614695b19a030c22209031ca0d6bc60/.pivot_root975280611: permission denied

Frames:
---
0: setupRootfs
Package: github.com/opencontainers/runc/libcontainer
File: rootfs_linux.go@69
---
1: Init
Package: github.com/opencontainers/runc/libcontainer.(*linuxStandardInit)
File: standard_init_linux.go@57
---
2: StartInitialization
Package: github.com/opencontainers/runc/libcontainer.(*LinuxFactory)
File: factory_linux.go@240
---
3: initializer
Package: github.com/docker/docker/daemon/execdriver/native
File: init.go@35
---
4: Init
Package: github.com/docker/docker/pkg/reexec
File: reexec.go@26
---
5: main
Package: main
File: docker.go@18
---
6: main
Package: runtime
File: proc.go@111
---
7: goexit
Package: runtime
File: asm_amd64.s@1721
docker: Error response from daemon: Container command could not be invoked..

Sadly, no amount of chmod on that path seems to be able to solve this.

/cc @estesp

The second error is fixed in the Docker 1.10.1 bug fix update via #20045.
The first error as you found shows that there is no way to have a non-root user mount filesystems on a path that is inaccessible to that user.  This would be true for user namespaced processes inside or outside of Docker and is simply a file permissions issue that lxcfs isn't handling or aware of.  Note that the syscalls that give you that error only need x permissions on the path traversed, so chmod o+x is sufficient.

Thank you for the explanation, after upgrading to 1.10.2 (and rebooting), all that is still required to get it to run is sudo chmod o+x /run/lxcfs/controllers. On that note: If lxcfs is not handling is / aware of it, I would like to know what - from dockers standpoint - is the most favorable long-term solution:

Make lxcfs aware of the issue and request to have /run/lxcfs/controllers made traversable for anyone (are there any security issues with having the path traversable that you are aware of?)
Change docker so it does not need the path traversable (I don't know if this is feasible, I'm just bringing it up because lxd does not seem to need it)
Have docker detect that lxcfs is running and make the path traversable at daemon startup

Currently, I will just have a startup script accompanying lxcfs to make the path traversable.

/run/lxcfs is private to lxcfs - the paths which containers should bind mount are under /var/lib/lxcfs.

This should be fixed by https://github.com/lxc/lxcfs/pull/124.

@brauner Thank you for that, WFM.
For any other Gentoo/Funtoo users that cannot wait for the PR to be accepted:

Get the PR as a patch into /etc/portage/patches/sys-fs/lxcfs/124.patch
Get yourselves a development, user-patches enabled ebuild of lxcfs, e.g. mine
Emerge the ebuild (remember to stop the lxcfs service)
Reboot (may not be necessary depending on your setup. For myself, I got ConsoleKit2 permission denied errors until I rebooted - just relogging did not work for me).

docker version
Client:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:
 OS/Arch:      linux/amd64

docker info
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 1.12.0
Storage Driver: zfs
 Zpool: error while getting pool information strconv.ParseUint: parsing "": invalid syntax
 Zpool Health: not available
 Parent Dataset: system/docker
 Space Used By Parent: 11116544
 Space Available:<PHONE_NUMBER>2
 Parent Quota: no
 Compression: off
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.6.4-gentoo
Operating System: Linux
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.707 GiB
Name: -----
ID: -----------------------
Docker Root Dir: /var/lib/docker/362144.362144
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

uname -a
Linux cylae 4.6.4-gentoo #2 SMP PREEMPT Sat Jul 16 10:27:08 CEST 2016 x86_64 Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz GenuineIntel GNU/Linux

Environment details (AWS, VirtualBox, physical, etc.):
LXCFS: Commit https://github.com/lxc/lxcfs/commit/8e365eef40af04483af61d2b393bc4ddb5350c4e with PR https://github.com/lxc/lxcfs/pull/124

Looks like this is fixed, or will be soon, so I'll go ahead and close this; thanks all!


PS weight fix for master

Some stuff still needs to be resolved and tested in a CMSSW_11_2_0_preX area and some other questions need to be resolved, so this is still a WIP

Tested in CMSSW_11_2_X_2020-11-04-1100 and using the --condition auto:mc flag for the cmsDriver.py (I doubt this makes a difference for our change, but just in case)

I made some non-trivial changes so I merged this manually. I'll close the PR.


Closes #148 | Create dataset loader for CC-100

Closes #148
Notes for reviewer
Because this dataset is multilingual, I added the cc100_source/seacrowd_ssp subset, which combines all the languages. This is needed because the test requires it. Without it, I ran into this problem running the test:

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

As far as I remember, the default config that loads everything is already optional. Not sure how strict we are in enforcing it though. Based from a previous PR https://github.com/SEACrowd/seacrowd-datahub/pull/170 I think we should remove that config. Confirming if this is correct cc: @sabilmakbar

Hi @ilhamfp , just let us know if you need help implementing the changes! 🙇

LGTM and tested!


Update notification for removing component

Fixes #1993. (Previously reviewed in #2012 and corrected based on comment in this new PR)
Local Test
→ rustup update
info: syncing channel updates for 'stable-x86_64-apple-darwin'
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: latest update on 2019-09-25, rust version 1.39.0-nightly (6ef275e6c 2019-09-24)
info: downloading component 'clippy'
info: downloading component 'rustfmt'
info: downloading component 'rustc'
 60.1 MiB /  60.1 MiB (100 %)   7.6 MiB/s in  7s ETA:  0s
info: downloading component 'rust-std'
172.7 MiB / 172.7 MiB (100 %)   7.9 MiB/s in 22s ETA:  0s
info: downloading component 'cargo'
info: downloading component 'rust-docs'
 11.8 MiB /  11.8 MiB (100 %)   7.6 MiB/s in  1s ETA:  0s
info: downloading component 'rust-src'
info: removing previous version of component 'clippy'
info: removing previous version of component 'rustfmt'
info: removing previous version of component 'rustc'
info: removing previous version of component 'rust-std'
info: removing previous version of component 'cargo'
info: removing previous version of component 'rust-docs'
info: removing previous version of component 'rust-src'
info: installing component 'clippy'
info: installing component 'rustfmt'
info: installing component 'rustc'
 60.1 MiB /  60.1 MiB (100 %)   7.6 MiB/s in  8s ETA:  0s
info: installing component 'rust-std'
172.7 MiB / 172.7 MiB (100 %)  15.2 MiB/s in 10s ETA:  0s
info: installing component 'cargo'
info: installing component 'rust-docs'
 11.8 MiB /  11.8 MiB (100 %)   2.3 MiB/s in  4s ETA:  0s
info: installing component 'rust-src'
info: checking for self-updates

  stable-x86_64-apple-darwin unchanged - rustc 1.37.0 (eae3437df 2019-08-13)
   nightly-x86_64-apple-darwin updated - rustc 1.39.0-nightly (6ef275e6c 2019-09-24)

@thedrow, thanks for explaining. aaad735 updated to use a different approach w. update_from_dist param.

Tiny note that 5d2b43d simply rename to explicit_modify param, which seems more explicit than previous ~update_from_dist~.

Alternatively call it implicit_modify and it'll be good as-is :D

Thank you, @kinnison. implicity_modify indeed sounds fit, and less risk not having to change the logic inversion in calling code & break something accidentally.
1844a92 updated to use implicity_modify.


Error compiling with GCC 9 on Linux

When compiling with GCC 9 on Linux I get these errors:
Libs/Anvil/src/misc/types_struct.cpp: In constructor ‘Anvil::FormatProperties::FormatProperties()’: Libs/Anvil/src/misc/types_struct.cpp:1168:26: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct Anvil::FormatProperties’ with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]  1168 |            sizeof(*this) );       |                          ^ In file included from Libs/Anvil/include/misc/types_classes.h:25,                  from Libs/Anvil/include/misc/types.h:286,                  from Libs/Anvil/include/misc/descriptor_set_create_info.h:26,                  from Libs/Anvil/src/misc/types_struct.cpp:22: Libs/Anvil/include/misc/types_struct.h:1272:20: note: ‘struct Anvil::FormatProperties’ declared here  1272 |     typedef struct FormatProperties       |                    ^~~~~~~~~~~~~~~~ Libs/Anvil/src/misc/types_struct.cpp: In constructor ‘Anvil::SparseImageAspectProperties::SparseImageAspectProperties()’: Libs/Anvil/src/misc/types_struct.cpp:3792:26: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct Anvil::SparseImageAspectProperties’ with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]  3792 |            sizeof(*this) );       |                          ^ In file included from Libs/Anvil/include/misc/types_classes.h:25,                  from Libs/Anvil/include/misc/types.h:286,                  from Libs/Anvil/include/misc/descriptor_set_create_info.h:26,                  from Libs/Anvil/src/misc/types_struct.cpp:22: Libs/Anvil/include/misc/types_struct.h:2854:20: note: ‘struct Anvil::SparseImageAspectProperties’ declared here  2854 |     typedef struct SparseImageAspectProperties       |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Can confirm still an issue; the offending code is the memset in these structs' empty initializers; I think in C++11 forward these can just be empty, as the struct is zero-initialized by default; or like I did just set each member to its empty initializer:
`Anvil::SparseImageAspectProperties::SparseImageAspectProperties()
{
aspect_mask = {};
flags = {};
granularity = {};
mip_tail_first_lod = {};
mip_tail_offset = {};
mip_tail_size = {};
mip_tail_stride = {};
// memset(this,
//        0,
//        sizeof(*this) );

}
AndAnvil::FormatProperties::FormatProperties()
{
buffer_capabilities = {};
linear_tiling_capabilities = {};
optimal_tiling_capabilities = {};
// memset(this,
//        0,
//        sizeof(*this) );
}
`
@dmarian if you were still trying to build. If any maintainers would like a pull request, I don't mind putting one together, but I imagine ya'll probably have a better notion of what you'd prefer to do here than I.


Coyote Badger Launch Error - Windows Desktop

I received the following error after trying to run the initiation code on my Windows Dekstop (MS Windows 10 Home - x64 - Intel i7)
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
docker: Error response from daemon: create %cd%/projects: "%cd%/projects" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.
I was able to get Coyote Badger to run on port 5000 by removing the ":" from the string %cd%/_projects:/opt/coyotebadger/_projects
The initiation code that I tried to use here was -
docker build . -t coyotebadger:latest
docker run -it --rm --name coyotebadger --ipc="host" --shm-size="1gb" --memory="2g" --cpus="2" -v %cd%/_projects/opt/coyotebadger/_projects -p 5000:5000 coyotebadger:latest
However, this made it impossible for Coyote Badger to properly run when I opened http://localhost:5000/ in Mozilla Firefox.
It looks like deleting the ":" made it impossible to recognize the directory (this should have been unsurprising, but I was just fooling around a bit to see if I could get this to work).
Here is the error that I received. Let me know if you need me to get any additional information on this issue. While this is lower priority for me than getting Coyote Badger working on Apple M1 chips, I'd also like to be able to run Coyote Badger on my windows Desktop.
FileNotFoundError: [Errno 2] No such file or directory: '/opt/coyotebadger/_projects'
Traceback (most recent call last)
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2464, in __call__

return self.wsgi_app(environ, start_response)

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2450, in wsgi_app

response = self.handle_exception(e)

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1867, in handle_exception

reraise(exc_type, exc_value, tb)

File "/usr/local/lib/python3.8/dist-packages/flask/_compat.py", line 39, in reraise

raise value

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2447, in wsgi_app

response = self.full_dispatch_request()

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1952, in full_dispatch_request

rv = self.handle_user_exception(e)

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1821, in handle_user_exception

reraise(exc_type, exc_value, tb)

File "/usr/local/lib/python3.8/dist-packages/flask/_compat.py", line 39, in reraise

raise value

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1950, in full_dispatch_request

rv = self.dispatch_request()

File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1936, in dispatch_request

return self.view_functions[rule.endpoint](**req.view_args)

File "/opt/coyotebadger/coyote_badger/app.py", line 56, in index

projects = Project.get_projects()

File "/opt/coyotebadger/coyote_badger/project.py", line 82, in get_projects

for item in os.listdir(PROJECTS_FOLDER):

FileNotFoundError: [Errno 2] No such file or directory: '/opt/coyotebadger/_projects'

Oh awesome! I also don't have a Windows computer so have never been able to test it on there easily. This looks like it should be a pretty simple fix though. I'll get M1 stuff working first and then—if you wouldn't mind doing a Zoom for like 30 min at some point in the next few weeks—I'll make sure it works on your PC as well.

Should be fixed in v2.1.1.


add lazy loading to imgs

I've added the loading="lazy" attribute to a number of img elements throughout the theme to help improve the page initial load speed

Hi @Iliain thanks for this, unfortunately Github didn't notify me of it, or it did and it went missing somewhere along the line.
I opened up #12 to track some work on this but I reckon what you've done is fine for now and solves an immediate problem.
I'll run through the PR and you'll get an update when it is merged. It'll be initially tagged as a 1.0.x tag.
Cheers
james

Thanks @Iliain - this has been tagged as v1.0.5
I'll keep #12 open which when done will migrate the use of <img> tags to just use the template provided by the image itself, there is a little bit of work to do there to get the alt text provided by another module automatically applying.


0.8indev connection is not responsive under stress test

I have tried my stress test with 50 clients and server running at localhost. After approx. 20 clients connects the server and client is becoming less responsive, server issues many disconnects by Timeout.
When I ran the same test with commit e6c2c64 then it runs well. I suspect the blocking sockets may be the problem?
Library version: 0.8indev commit dc2521c1f1
Framework: .NET Core
OS: Windows

I have tried commit
4d623a90a4 added auto recycle, try using blocking sockets (third time)
It seems to behave a bit better than dc2521c but still has same problems.
I have tried one commit before
7a9a45cb09 Better fix for #235
And it runs well.

I have tried dec56ec but with socket.ReceiveTimeout = 100000 and it seems running ok.

I think one performance bottleneck is that socket.ReceiveFrom ends very often with SocketException SocketError.TimedOut. The exceptions are a bit expensive. When I put the code:
if (socket.Available == 0 && !socket.Poll(100000, SelectMode.SelectRead))
    continue;
result = socket.ReceiveFrom(receiveBuffer, 0, receiveBuffer.Length, SocketFlags.None, ref bufferEndPoint);

Then the performance is back. Works well even for blocking socket. I think this double poll is better than throwing exception.
Suggestions:

Do not log SocketError.TimedOut.
Do the socket socket.Poll before read. If it is a performance degradation for high message rate, then make a switch for those who has lower message rates.
If you need ReceiveTimeout, SendTimeout for .NET Core only, then

Do use them for #if NETCORE only and use the socket.Poll for #if NETCORE too. (Or maybe some #if NETCORE_LINUX).
Do not use them for other platforms. Then you do not need to use socket.Poll for other platforms, too.

@xmedeko higher frequence will be better for latency.

I do not see any latency increase with high Poll time wait (have tried 5sec = 5000000). It returns as soon as read data are available.


Question: How to use GraphQL with clean architecture

Hi @petrspelos,
during some investigation, I noticed it may be easier for frontend implementation to use GraphQL instead of standard rest. At least for querying it does make sense in some way.
The question is how would such implementation look like if it is even possible to go this way without going against clean architecture principles.

https://github.com/graphql-dotnet/graphql-dotnet

@petrspelos

Ok, lets close this one and open one for implementation, we will do it as an experiment and we will see if that will go to production or not.


Enable one cpu build for CI

This change switch CI build process from all CPUs to single CPU

@napetrov What is level of confidence that all machines in CI supports at least avx2?
If all of them support - it is approved

@SmirnovEgorRu - actually current implementation of one CPU target build get both defined and minimal supported versions.  So even in case we will not have AVX2 system dispatcher will fail-back to lowest one.
Also at this stage we do not run tests/examples so change itself is safe as build will succeed even on system without AVX2 support.

@napetrov in this case, I think we need to build only minimum supported version w/o avx2 to speedup CI


Update outdated dependencies

In particular, update the html-validate dependency to avoid using outdated rules on Netlify.

Thanks for this @cmbuckley. I'll merge this in over the weekend and make a new release. Need to write up some release notes first because the html-validate update will introduce breaking changes.

Thanks for a quick merge and for raising netlify/plugins#223 so quickly too 😄


How to use use_salt_as_remember_token?

I'm on version 2.0.1 of devise and rails 3.1.3.
For authentication I'm using a custom strategy so i don't need database_authenticatable. In the devise initializer I see a comment:
# If true, uses the password salt as remember token. This should be turned
# to false if you are not using database authenticatable.
config.use_salt_as_remember_token = true

I'm not using database_authenticatable so I set it to false and get a deprecation message:
[DEVISE] Devise.use_salt_as_remember_token is false which is no longer supported. Devise now only uses the salt as remember token and the remember_token column can be removed from your models.

Which of these messages is more correct?

Leave it to true. It will be removed in the next release. You have to define your own remember me token setup though.


Replace moment with date-fns

Summary
This is a follow-up to #3186, #3244, #3247, and #4082.
This PR solves a few issues...
Timezone issues in date formatting
Addresses #4095 by revamping how we deal with timezones from start to finish.
Usage of @wordpress/date
We currently use the @wordpress/date package for date formatting in the editor.
This causes a couple of issues:

We load it as an external (meaning it is not part of the actual bundle) because it is GPL licensed...
...which means it itself loads moment as an external since it's a dependency.
An additional hurdle for decoupling the app from WordPress (#2918)

Moment.js is (too) large
We only need a small set of features for date-related functionality in the editor/dashboard. Moment.js is too big for that, and there are more lightweight alternatives available.
This PR reduces assets/js/stories-dashboard.js bundle size by 20KB.
While assets/js/edit-story.js is getting 11 KB bigger, we now prevent WordPress from loading @wordpress/date (200KB) as an external script, which in turn loads moment.js as an external script (60KB). So in total, we now load 250 KB less JS for the editor!
Moment.js is in maintenance mode
As per https://momentjs.com/docs/#/-project-status/, Moment is considered a legacy project in maintenance mode. It is not dead, but it is indeed done.
Time to use more modern and up-to-date alternatives!
Lack of translation
Phrases like %s ago and %s from now that can be seen in the dashboard (using getRelativeDisplayDate) are currently not translatable.
This PR fixes this in a clever way by using all the locale information provided by the platform (WordPress) to create a new locale for date-fns with all the necessary translations.
This way we avoid importing a ton of separate translation files.
Relevant Technical Choices

uses date-fns and date-fns-tz, moving all date logic to assets/src/date

To-do

[x] Tests

User-facing changes
Some minor wording changes when displaying relative dates (e.g.  "1 hour ago"), but otherwise no user-facing changes.
Testing Instructions

Editing media in the editor should still show the creation date.
Dates in the dashboard should still be shown correctly.
wp-includes/js/dist/date.min.js is no longer loaded in the editor

Fixes #4095

@BrittanyIRL @barklund @spacedmonkey Since 1.0.0 is now out of the door, I would love to get this in & get your review before that.
I like to look at it as performance optimization & refacotirng that happens to fix some bugs

The publishing date/time dropdown in the editor doesn't respect the date format settings.

The dropdown uses __( 'd/m/Y ' ), probably to make sure the format is short enough to fit into the dropdown. The full month name would be too long, for example.


BVAL-634 Defining empty default value for @OverridesAttribute#name() …

…so it behaves as described in its docs and the spec

Merged, thanks!


incorrect use of resultWrapper from the api.json

In the json metadata an Operation has an output, which is a ShapeRef. The ShapeRef sometimes has a shape and a resultWrapper and it looks to me like the produced Go types are incorrect. My understanding is that the shape is the name of a shape but the resultWrapper is just the name of a field in the response from which to extract the data to populate the shape. The bug in the generated Go code is that the type returned by the generated method has the name of the wrapper instead of the name of the output shape. For example, from CloudFormation.api.json:
    "DescribeStackEvents":{
      "name":"DescribeStackEvents",
      "http":{
        "method":"POST",
        "requestUri":"/"
      },
      "input":{"shape":"DescribeStackEventsInput"},
      "output":{
        "shape":"DescribeStackEventsOutput",
        "resultWrapper":"DescribeStackEventsResult"
      }
    },

The produced function is:
func (c *CloudFormation) DescribeStackEvents(req *DescribeStackEventsInput) (resp *DescribeStackEventsResult, err error) {

yet the return type should be resp *DescribeStackEventsOutput, which is also generated but not used anywhere.

One of the things we are working to fix is to make the names consistent for structs on operations. We are going to make it so the root shapes you pass into the operation will have the "Input" suffix and the struct returned will have an "Output" suffix. Once we complete that there will just be a DescribeStackEventsOutput and there will not be a generated DescribeStackEventsResult

This report will no longer be valid once the develop branch is merged into master. I am going to mark this as closed since this report describes the old generator code. The new generator code in develop should generate the right types. Thanks for reporting this.


Update API Call for #131

Changed how SutroDataApiClient calls the Sutro GraphQL endpoint by wrapping with a query object

This PR should fix issues in #131 relating to the API not retrieving data. This does not fix the config flow 500 error.


easy-rsa does not have a gen-client-keys\conf script

I cannot find a version of easy-rsa that contains the gen-client-keys and gen-client-conf scripts that are called in profile_controller when generating client VPN profiles. Do you know which version had this?

I'm going to try and modernize this to use easyrsa3. I'll open a PR when I get it working.

I am adding both scripts in this tree, please have a look.

I have added both scripts.


Add rdkit

Compile latest version from source. Include inchi and postgresql extension

RDkit 2015_09_2 is compiled using RDK_INSTALL_INTREE=OFF to install it in /usr.


Start/stop Climatisation not working v1.0.42-RC2

Describe the bug
I've a skoda citigo eiv and I've this switch in home assistant: switch.e_citigo_sty_61_e1f_electric_climatisation
The switch desn't work anymore when pressed it says 'Vehicle' object has no attribute 'set_climater'
Latest working release
Debug logs
2021-06-30 23:37:21 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [2976384696] 'Vehicle' object has no attribute 'set_climater' Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service await hass.services.async_call( File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call task.result() File "/usr/src/homeassistant/homeassistant/core.py", line 1526, in _execute_service await handler.job.target(service_call) File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service await self.hass.helpers.service.entity_service_call( File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call future.result() # pop exception if have File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 760, in async_request_call await coro File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call await result File "/config/custom_components/skodaconnect/switch.py", line 51, in async_turn_on await self.instrument.turn_on() File "/usr/local/lib/python3.8/site-packages/skodaconnect/dashboard.py", line 411, in turn_on await self.vehicle.set_climatisation('electric') File "/usr/local/lib/python3.8/site-packages/skodaconnect/vehicle.py", line 538, in set_climatisation return await self.set_climater(data, spin) AttributeError: 'Vehicle' object has no attribute 'set_climater'
Installation:

Home Assistant variant:  Hass OS

Fixed in library version 1.0.43


QR Code standalone not working on metamask mobile

The QR Code on desktop is not working for metamask when I try to scan it with my phone, I scan the QR with metamask mobile app and nothing happens. I'm using the standalone modal, I even tried it on the example provided in the web3modal repo, the react-standalone example.
Originally posted by @glitch-txs in https://github.com/WalletConnect/web3modal/issues/775#issuecomment-1365649761

just read this https://github.com/WalletConnect/web3modal/issues/747#issuecomment-1336136661 my bad


Missing examples 'opengl' and 'subclass' build support in makefile

The makefile in the root level of the project currently does not support the opengl and subclass examples. I ask that these two example projects be included in the makefile for building and running.
Thank you.

I'm not even sure how much I want to keep those make tasks in there, but you are free to add them. They are similar to the others.


Support for generating IBANs for countries when bban doesn't start with bank_code

It's not possible to generate IBAN for countries where bban doesn't start with bank_code, e.g. Italy - http://www.xe.com/ibancalculator/sample/?ibancountry=italy
Do you intend to support generating ibans for all countries?
On [9]: iban = IBAN('IT60 X054 2811 1010 0000 0123 456')

In [10]: iban.country_code
Out[10]: 'IT'

In [11]: iban.bank_code
Out[11]: '05428'

In [12]: iban.account_code
Out[12]: '000000123456'

In [13]: iban.branch_code
Out[13]: '11101'

In [14]: IBAN.generate(country_code=iban.country_code, bank_code=iban.bank_code+iban.branch_code, account_code=iban.account_code)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-14-4145eaaa1945> in <module>()
----> 1 IBAN.generate(country_code=iban.country_code, bank_code=iban.bank_code+iban.branch_code, account_code=iban.account_code)

~/.virtualenvs/swift/lib/python3.5/site-packages/schwifty/iban.py in generate(cls, country_code, bank_code, account_code)
    111         account_code = account_code.rjust(account_code_length, '0')
    112         iban = country_code + '??' + bank_code + account_code
--> 113         return cls(iban)
    114
    115     def validate(self):

~/.virtualenvs/swift/lib/python3.5/site-packages/schwifty/iban.py in __init__(self, iban, allow_invalid)
     67
     68         if not allow_invalid:
---> 69             self.validate()
     70
     71     def _calc_checksum_digits(self):

~/.virtualenvs/swift/lib/python3.5/site-packages/schwifty/iban.py in validate(self)
    115     def validate(self):
    116         self._validate_characters()
--> 117         self._validate_length()
    118         self._validate_format()
    119         self._validate_checksum()

~/.virtualenvs/swift/lib/python3.5/site-packages/schwifty/iban.py in _validate_length(self)
    130     def _validate_length(self):
    131         if self.spec['iban_length'] != self.length:
--> 132             raise ValueError("Invalid IBAN length")
    133
    134     def _validate_format(self):

ValueError: Invalid IBAN length

Hey @sedlar, sorry for the late reply. This is actually a bug in schwifty, because the IBAN.generate-method cannot handle IBANs which are composed of other things than country-code, check-sum, bank-code, branch-code and account-code. The italian BBANs have a format specification that looks like this 1!a5!n5!n12!c. So there seems to be one character prefixed to the BBAN which I don't know the meaning of. Is it static? Is it always X. Can you maybe shed some light on this?

Hi @mdomke, thanks for reply. The X character is national checksum digit. I have found the description of the algorithm to compute it in https://docs.oracle.com/cd/E18727_01/doc.121/e13483/T359831T498954.htm. Descriptions of some other country specific checksum can be found also in https://github.com/globalcitizen/php-iban/issues/39.

Hi @sedlar thank you for the information. I'll try and see if I can implement something with respect to country specific check digits, but I can't promise anything time wise.

Hi, for IBAN IT there is an error in the 'iban_registry.json' file, that is:
"IT": {
     "iban_spec": "IT2! n1! a5! n5! n12! c",
     "iban_length": 27,
     "bban_length": 23,
     "bban_spec": "1! a5! n5! n12! c",
     "positions": {
       "branch_code": [
         6
         11
       ]
       "account_code": [
         11
         23
       ]
       "bank_code": [
         0,
         6
       ]
     }
   }
referring to wikipedia wikipedia
the bank_code cpm takes the CIN, so the index was modified to include the character 0.

This is fixed by #26


Support for safe area based layouts

This is a major restructuring of how the library works. iOS 11 demands layout to be done with respect to safe area layouts, and those break completely when transforms are applied.
The goal here is to ensure that this never happens, by removing transforms entirely in favour of snapshot views, so that views are laid out as if with safe areas intact

Looks great. Way better than the hacky solution I came up with...(I hate the status bar). Also DeckSnapshotUpdater is exactly what I need.
One small thing I noticed. The view controller life cycle methods for both presenting and presented controllers aren't being called during the transition. Here's a fix that seems to work:
// DeckPresentingAnimationController

func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
   guard
     let presentingViewController = transitionContext.viewController(forKey: .from),
     let presentedViewController = transitionContext.viewController(forKey: .to)
     else { return }

   presentingViewController.beginAppearanceTransition(false, animated: true)
   presentedViewController.beginAppearanceTransition(true, animated: true)

   let containerView = transitionContext.containerView
   containerView.addSubview(presentedViewController.view)
   presentedViewController.view.frame = CGRect(x: 0, y: containerView.bounds.height, width: containerView.bounds.width, height: containerView.bounds.height)

   let finalFrameForPresentedView = transitionContext.finalFrame(for: presentedViewController)

   UIView.animate(
     withDuration: transitionDuration(using: transitionContext),
     delay: 0,
     options: .curveEaseOut,
     animations: {
       presentedViewController.view.frame = finalFrameForPresentedView
     },
     completion: { finished in
       transitionContext.completeTransition(finished)
       presentedViewController.endAppearanceTransition()
       presentingViewController.endAppearanceTransition()
     }
   )
 }

 // DeckDismissingAnimationController

 func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
   guard
     let presentingViewController = transitionContext.viewController(forKey: .from),
     let presentedViewController = transitionContext.viewController(forKey: .to)
     else { return }

   presentingViewController.beginAppearanceTransition(false, animated: true)
   presentedViewController.beginAppearanceTransition(true, animated: true)

   let containerView = transitionContext.containerView

   let offscreenFrame = CGRect(x: 0, y: containerView.bounds.height, width: containerView.bounds.width, height: containerView.bounds.height)

   UIView.animate(
     withDuration: transitionDuration(using: transitionContext),
     delay: 0,
     options: .curveEaseOut,
     animations: {
       presentedViewController.view.frame = offscreenFrame
     },
     completion: { finished in
       transitionContext.completeTransition(finished)
       presentedViewController.endAppearanceTransition()
       presentingViewController.endAppearanceTransition()
     }
   )
 }

Good catch, thanks! Adding to the PR


Update code PairDevice calls to work with network params.

Problem
The setup code PairDevice functions had no way to pass in commissioning parameters, which meant it wasn't possible to commission BLE devices by code.
Change overview

Adds a function to the auto commissioner to allow adding commissioning parameters incrementally
Add commissioning parameters as a function parameter to the pair device calls for setup codes
Adds pairing options to chip tool to allow this path

Testing
Chip tool commissioning M5 over BLE

This PR aligns all high-level commissioning pathways to use the auto commissioning state machine. In the case of a cli based human driven command this might make sense but it also forces the commissioner using the payload string APIs to gather network credentials for all possible networks prior to commissioning.
It remains desirable for some use cases to only have PASE setup and to trigger commissioning at some point later.
For example, what if you don't have Thread credentials available? What if you want to present an error when you realize that someone/something is trying to commission an accessory that your network cannot support? How do you even query what network technologies the accessory has without attempting to provision it with something.
At least for now, we should allow the caller to specify auto commissioning when using the payload APIs and update SetupCodePairer to also just perform PASE if requested by the caller.
As an aside, pretty sure this breaks CHIPTool on iOS but that thing gets no love these days.
@msandstedt thoughts?

I would be open to the idea that the setup code pairer triggers a pase connection only in all cases (BLE and on-network), and commission is called separately. But the accessor functions for that should be renamed to make that clear.

Proposal:

I fix Michael's thing and remove the "add" command in the auto commissioner
PairDevice commands using the setup code pairer trigger commissioning using network credentials provided apriori. Once https://github.com/project-chip/connectedhomeip/pull/13829 goes in, you can just provide thread and wifi and the commissioner will select the appropriate one.
We add additional EstablishPASEConnection functions based off the setup code that trigger PASE only for folks that want that. That way we have all the combos.

Was the intent to have set up code pairer do pase only? Because that's not how it was written originally. In the original instance, setup code pairer triggered commissioning and it is named as such.

You're completely right about this. The meaning of Pairing got separated from Commissioning and CASE at some point and now they're being aligned again so that explains the weirdness with naming all over the place.
It used to mean "PASE is ready and node is Commissioned" after which it was up to the commissioner to actually trigger the CASE (via get Connected Device) after providing network credentials. But that's old stuff now so let's ignore it.
Your proposal for the most part sounds acceptable.

PairDevice commands using the setup code pairer trigger commissioning using network credentials provided apriori. Once Check feature map for network technology #13829 goes in, you can just provide thread and wifi and the commissioner will select the appropriate one.

I think the problem here is that it's a little bit backwards to handover everything before even starting to commission.

We add additional EstablishPASEConnection functions based off the setup code that trigger PASE only for folks that want that. That way we have all the combos.

This sounds good. Unfortunately, I'm not sure how to exercise this from the cli tooling. So that's something we'll have to think about.

I would be open to the idea that the setup code pairer triggers a pase connection only in all cases (BLE and on-network), and commission is called separately. But the accessor functions for that should be renamed to make that clear.

In my mind, the primary reason to include PASE with discovery (the SetUpCodePairer's current primary role seems to be discovery) is the ambiguity around the discriminator.  Location of a node with a matching discriminator does not guarantee you've found the node you're looking for.
But if the code that discovers also establishes PASE, then it can hand back a session to the commissioner and commissioner will have very high confidence that it is talking to the node it intends, because successful establishment of PASE means both nodes have the same shared secret.  Furthermore, we always have to establish PASE, so this doesn't introduce more branching in the discoverer.
However, I find it odd that the SetUpCodePairer would have to do any other commissioning steps.  It seems like instead of the SetUpCodePairer consuming a commissioner, it should provide a delegate interface so that it can signal the commissioner when its done.  This would leave the commissioner to make any further commissioning decisions.

This PR forces getting network credentials before doing discovery and finding out whether they are even needed.
That's not acceptable, unfortunately. We have to allow commissioners using SetUpCodePairer to do discovery and set up PASE and only then deal with getting network credentials as needed.

Yes, it will not be possible to realize many necessary product flows unless network credentials can be provided dynamically, as needed.  And in many cases this will be after discovery.
However, sorting that out seems like a heavy lift for our feature cut deadline.  If this is a critical feature (in my view it is), can't we bring this through the necessary gatekeeping to potentially continue development and really solve the problem?

OK, I updated this to be a bit more specific about what each part of the API does. I don't really love the "PairDevice" nomenclature we have going on, but we're kind of past the point of fixing that - it's deeply embedded into the stack.
I added an option to establish a pase connection though the setup code parier. That gets hooked up thorough chip tool by not specifiying a network technology. I really don't love that, but I also don't really want to rework chip tool to provide an entirely separate command for establishing a pase connection only. I would argue that chip tool is example code anyway, and that can probably be done after TE8.

If you want to get information about the device, you can establish a pase connection, read whatever, fill in the required parameters and then commission. This is the same as before, just that the device isn't hanging out in a half-commissioned state with no failsafe running.


Always linkify review action in review log (no bug)

Any clue why that wasn't the case before? Is there a corner case where we don't want it to be linkified?

I think that was necessary back in the time when a deleted version would also delete the corresponding review entry, which is no longer the case (was fixed in bug 544486).
Right now it doesn't make sense to make the linkification (which is in part of the first array entry) dependent of the second array entry.

Thanks for the explanation! And thanks for your work ;)
r+


⚠ ClamAV has degraded performance

In d95b698, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in ba5f6a1.


gRPC API

Research gRPC API of https://docs.gitlab.com/ee/administration/gitaly/ service, describe it in a document.

I have created wiki page for the API description.


Finalizing the site organization

https://www.lucidchart.com/invitations/accept/0be7b826-9765-4e8f-a2a8-60c87a50aa0a
I used card sorting method to simplify what is in the header and what goes on each page. Feedback is always welcomed!