Issue while running the [dbo].[QDSCacheCleanup] to purge Query Store

Hi,
There is an issue while trying to purge Query store.
Ran below, and the proc is running for hours and it ran for more than 10 or 12 hours and finally I cancelled it.
Please advise if there is anything we can do to fix.
EXECUTE [dbo].[QDSCacheCleanup]
@DatabaseName = 'DB'
,@CleanAdhocStale = 0
,@CleanStale = 1
,@Retention = 12
,@MinExecutionCount = 2
,@CleanOrphan = 1
,@CleanInternal = 1
,@CleanStatsOnly = 0

@SQLozano
I have run the clean up few times in production and it never seems to complete
sys.query_store_runtime_stats is having 736056 rows
Size of the Query store used is around 10 GB out of total of 20 GB
On running the  @verbosemode = 1 on UAT server (where query store size is 1 GB) it seems to be running for a long time. However, I can see that it is performing some thing.
Is there any way we can fasten this process up?

I am having a similar issue and I think the problem is the performance of the Microsoft stored procedures that perform the cleanup, and not an issue with QDSCacheCleanup directly.
sys.query_store_query = 1,346,106
sys.query_store_runtime_stats = 1,394,532
I propose a new parameter (I suggest a default of 50,000 as between that and 100,000 seems to be the tipping point for long execution times):
@MaxCleanupQueryCount INT = 50000
Plus a variable @CleanUpQueryCount to hold a counter that is incremented each loop.
The Loop Condition is then updated to evaluate the new parameter:
WHILE (SELECT COUNT(1) FROM #DeleteableQueryTable) > 0 AND (@MaxCleanupQueryCount = 0 OR @CleanUpQueryCount < @MaxCleanupQueryCount)
https://github.com/channeladvisor/qdstoolbox/blob/115f671a49ca9910f6dc73ecf8de18b571ecdd7b/QDSCacheCleanup/3-dbo.QDSCacheCleanup.Procedure.sql#L913
https://github.com/channeladvisor/qdstoolbox/blob/115f671a49ca9910f6dc73ecf8de18b571ecdd7b/QDSCacheCleanup/3-dbo.QDSCacheCleanup.Procedure.sql#L956
This will allow a fixed number of queries to be removed each time and prevent the long execution times.

I picked up that this statement can take up to 300ms to run with a high volume of data, so adding an index on [ForcedPlan] will help (it has in my testing):
https://github.com/channeladvisor/qdstoolbox/blob/115f671a49ca9910f6dc73ecf8de18b571ecdd7b/QDSCacheCleanup/3-dbo.QDSCacheCleanup.Procedure.sql#L916


Show filename change from previous page

On Getting Started uses main.js, and on  Asset Management we need to show that changed to bundle.js.

Thanks!


Make track panel state of species indepedent

Type

[x] Bug fix
[ ] New feature
[ ] Improvement to existing feature

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-276
Description
The genome browser for a species should be display the track panel just as how the user left it before going to a different view. The track panel open/close state and the track panel modal state is made independent with this PR.
Views affected
Genome Browser
Other effects

[ ] I have checked any requirements for Google Analytics
[ ] I have created any required tests
[ ] The PR has as its final commit a WASM/JS update commit if any Rust files were updated.

I wonder which model of state is better — the current one:

or the one where root-level keys are genome ids:

For me, the second one is more natural (also, it's easier to generate a template with default values for every new species)

@azangru The model you suggested is neater and makes more sense. I'll change the track panel state to this model.


Regression: HTML character references are incorrectly escaped in some cases

https://tc39.github.io/ecma262/#prod-UnicodeIDStart currently renders as follows:
UnicodeIDStart::
    any Unicode code point with the Unicode property “ID_Start”

PR: #117


CSV Results don't correspond to graph plot values.

[X] I'm up-to-date with the latest release:
pip install -U talos

[X] I've confirmed that my Keras model works outside of Talos.

X shape - (94776, 641)
Y shape - (94776,)
p = {'lr': [3.2],
'first_neuron':[10],
'shape':['triangle'],
'hidden_layers':[1],
'batch_size': [8096],
'epochs': [25],
'dropout': [0.1],
'kernel_initializer': ['normal'],
'optimizer': [Nadam],
'losses': [binary_crossentropy],
'activation':[elu],
'last_activation': ['sigmoid'],
'classweights':[{0:1, 1:0.5}]
}
def keras_model(x_train, y_train, x_val, y_val, params):
model = Sequential()
model.add(Dense(params['first_neuron'], input_dim=x_train.shape[1],
                activation=params['activation'],
                kernel_initializer=params['kernel_initializer']))

model.add(Dropout(params['dropout']))

model.add(Dense(1, activation=params['last_activation'],
                kernel_initializer=params['kernel_initializer']))

model.compile(loss=params['losses'],
              optimizer=params['optimizer'](lr=lr_normalizer(params['lr'],params['optimizer'])),
              metrics=[precision_acc,recall_acc])

history = model.fit(x_train, y_train,
                    validation_data=[x_val, y_val],
                    batch_size=params['batch_size'],
                    callbacks=[live()],
                    epochs=params['epochs'],
                    verbose=0,
                    class_weight=params['classweights'])

return history, model

The dataset is an unbalanced binary problem.
Here is the csv output line for the above dictionary:

round_epochs
val_loss
val_precision_acc
val_recall_acc
loss
precision_acc
recall_acc
lr
first_neuron
shape
hidden_layers
batch_size
epochs
dropout
kernel_initializer
optimizer
losses
activation
last_activation
classweights

25
0.623747
0.833902
0.265479368
0.400902
0.866431
0.277613
3.2
10
triangle
1
8096
25
0.1
normal
<class 'keras.optimizers.Nadam'>
<function binary_crossentropy at 0x000001B7AC1A6488>
<function elu at 0x000001B7AC1C8EA0>
sigmoid
{0: 1,1: 0.5}

And here are the actual plots generated during the scan:
https://imgur.com/a/UTSutSL
As you can see - the CSV values for precision and recall do not match up to the final values on the graph.  In fact, it looks like maybe the values in the CSV results file are actually the max() Y values that the graph hits (so epoch ~3 for recall, and epoch ~22 for precision).
Obviously the data dictionary is just a single test for this example, but the same holds when doing thousands of iterations.   I have also tried different configurations of the model, but still end up with these types of results.  I'm assuming that the graph is the accurate source, and that the data saved to the csv is not correct.
Or am I doing something wrong?

Solved!
I had a look through the code and it turns out "last_epoch_value" parameter must be set to True to log the final value.
From Scan.py
last_epoch_value : bool
Set to True if the last epoch metric values are logged as opposed
to the default which is peak epoch values for each round.
I would propose that it should default to True rather than the current False. The result metric values logged in in the output CSV file are irrelevant/misleading under the last_epoch_value= False setting.

Thanks. In the latest versions it's True by default. Closing here.


Provide „toggle task“ command in mobile toolbar

Obsidian‘s default toolbar button only toggles the checklist item „defaulty“. Check if obsidian tasks can provide its own toolbar button.

According to koala on Discord it's not yet possible.

Workaround: swipe-down on mobile can be programmed to toggle the task in edit mode.

According to lished on discord this is now possible with update 0.12.2:

You can now specify an editorCallback or editorCheckCallback in a command that will register your command as an editor command, which will allow it to be added to the editor toolbar on mobile.

The command is there with 16e0a281fa76e55a9f4d9641dfc6a8929dab3607, but the symbol is a question mark.

Fixed in release 1.3.0


Update protonmail-bridge to 1.0.4

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Okay thank you 👍


Support for ASLR and DEP

I am auditing DLL's we are using in a project and noticed the Bouncy Castle C# API (checked version 1.8.2) is not using ASLR or DEP. Using a tool like PESecurity I see:
PS C:\Users\dskidmor\Downloads> Get-PESecurity -file .\BouncyCastle.Crypto.dll

FileName         : C:\Users\dskidmor\Downloads\BouncyCastle.Crypto.dll
ARCH             : I386
ASLR             : False
DEP              : False
Authenticode     : False
StrongNaming     : True
SafeSEH          : N/A
ControlFlowGuard : False
HighentropyVA    : False

However, I tried out building the project myself using Visual Studio 2017 and my copy does support ASLR and DEP:
PS C:\Users\dskidmor> Get-PESecurity -file bc-csharp\crypto\bin\Debug\lib\net20\BouncyCastle.dll

FileName         : C:\Users\dskidmor\bc-csharp\crypto\bin\Debug\lib\net20\BouncyCastle.dll
ARCH             : I386
ASLR             : True
DEP              : True
Authenticode     : False
StrongNaming     : True
SafeSEH          : N/A
ControlFlowGuard : False
HighentropyVA    : False

I don't know much about the build infrastructure of the project, but are releases built with an older toolchain or with these features disabled? Would it be possible to turn on these security features in a future release?

Releases up to 1.8.2 were built with an old toolchain, yes. Future official releases will be switching to modern tools (see https://github.com/bcgit/bc-csharp/pull/68), and should have these enabled.


Config2 Enum Representation

Add Config 2 to RegisterMask and RegisterPosition (+all needed small size enum types, like on/off etc.)

Finished


feat: leapfrogai ui registry1 flavor

Description
Add a flavor override to the LeapfrogAI UI Zarf package that uses an IronBank hardened Node 18.x image.
Describe alternatives you've considered
N/A
Additional context
Uses:
- Node 18 (upstream) (possible IronBank)
- Chainguard Node-Latest (upstream) (possible IronBank)

@justinthelaw following the linked PRs and threads here I think this was resolved in https://github.com/defenseunicorns/leapfrogai/pull/920. Is this issue safe to close?

@nywilken the registry1-flavored UI integration is separate from the API integration, and was not completed prior to feature freeze


Dedicate one set of chat handlers per room

Description

Makes chat handlers non-singletons in Jupyter AI. Each chat handler is dedicated to at most 1 YChat instance.
Makes YChat an instance attribute instead of a local variable that gets forwarded across methods.
Reverts most changes to chat handlers (except for the base class).

Demo
https://github.com/user-attachments/assets/ecd8e027-b5da-4f49-9edf-6f0c5eb71d73

@brichet Addressed your comments. As for the ychats_by_room dict, we can remove that later. It has a tiny memory footprint, and there could be a future use-case for caching get_room() calls.


Cannot read property 'done' of undefined

Issue Id: 5e664130-e668-3ea9-7422-a3cbaa901748Versions - 1.9.0Stack TypeError: Cannot read property 'done' of undefined/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#L302:92 (done)/vs/base/common/callbackList.ts#L63:26 (apply)/vs/base/common/event.ts#L118:26 (call)/vs/workbench/parts/preferences/browser/preferencesWidgets.ts#L338:49 (fire)/vs/base/browser/ui/widget.ts#L16:102 (listener)

Fixed in latest


[iOS] Add missing ARC flag to the simulator build.

Fix iOS simulator build (missing flag after ARC was enabled in #42503).

Thanks!


Ember should use #! instead of html5 push feature

Scenario

open devtools
choose a tool and open it
copy the url and send it to a friend
user opens the url
github pages complain that the page doesn't exists

Cause
ember use HTML5 history push by default so auto prefix tool for example has the url http://www.blazeboy.me/devtools/autoprefixer, github can't redirect user the index.html and can't be configured to do so.
Solution
We should use the #! notation instead so the autoprefixer tools should has http://www.blazeboy.me/devtools/index.html#!autoprefixer instead of http://www.blazeboy.me/devtools/autoprefixer
also the whole app should has a switch in environment files to fix/ignore fix.

I wonder if you can use 404 page to redirect to index.html/
Read here

interesting, i didn't know that workaround, yes i think it could work.
https://help.github.com/articles/custom-404-pages/
https://github.com/lionello/lionello.github.io/commit/c175f6524a53e29aea1890c8a758afd0e8944852

it didn't work, github can't find urls such as index.html/autoprefixer i think we'll need to fallback to the previously suggested workaround, using #! instead, any other ideas we can try?

it turns out that this is a simple configuration key in the environment :D


Getter for reporter's last submission timestamp

Will be useful for indicating to pytelliot when a reporter has completed the reporter lock wait.

This was added, look at the oracle contract.

ok, thanks. I must've missed it.


Updates to footsteps panel in ui.

Looks very nice, great job!  There are a couple things I want to discuss with @rdeits in order to review this, but I may not have time to get to it today.  Is it ok if we keep this one open for a little while?  Do you guys have a workaround that you can use to set the ihmc controller parameters in the meantime?

No problem. I guess we could use my branch for the moment.

@patmarion
Please, refer to this video. It shows what we would like to achieve in the ui. We would like both to separate in two the planning parameters (just one list is too long and does not fit in the window) and to be able to set the ihmc params.
The panel I show you in the video is the result I get with the code on my branch. I understand what are your doubts. I would say that you are correct when you say "I think it is a bug to not include these parameters in this parameter set". Could you modify the ui at my place to achieve similar results with the best strategy?

Thanks for posting the video.
I understand the desire for having a more compact list of properties.  Perhaps there is something we can do in the UI presentation to achieve that without splitting the parameters into separate groups at the code layer.  The problem with this pull request is that by separating parameters into groups it is breaking the "presets" feature which is something we use for Atlas and you may want to use in your lab too.
And just to repeat a comment I made in the other PR, I'm not convinced (but maybe I could become convinced) that splitting parameters into planning and control groups is a good idea, to the user (and task planner) they are all parameters that affect walking behavior.  The fact that some parameters are only read by the controller seems like an implementation detail.
I'll think about UI designs that could achieve our goals.  I hope in the meantime you guys can find a workaround so you can be productive, I don't want to block you, but as it stands this PR is breaking some functionality so I don't want to merge it as is.  Perhaps the simplest modification to move forward is just adding the IHMC parameters to the list, making the UI even longer, but hopefully soon we can find a satisfying redesign to resolve it.


[ISSUE #6679]SubscriptionData may not be updated when the client's system time is rolled back

Which Issue(s) This PR Fixes

Fixes #6679
Brief Description

Fix SubscriptionData may not be updated when the client's system time is rolled back

Codecov Report

Merging #6680 (d1de8b3) into develop (7903c70) will increase coverage by 0.33%.
The diff coverage is 100.00%.

:exclamation: Current head d1de8b3 differs from pull request most recent head 101543c. Consider uploading reports for the commit 101543c to get more accurate results

@@              Coverage Diff              @@
##             develop    #6680      +/-   ##
=============================================
+ Coverage      43.04%   43.38%   +0.33%
- Complexity      9019     9325     +306
=============================================
  Files           1109     1116       +7
  Lines          78591    81261    +2670
  Branches       10226    10948     +722
=============================================
+ Hits           33831    35255    +1424
- Misses         40527    41666    +1139
- Partials        4233     4340     +107

Impacted Files
Coverage Δ

...cketmq/client/impl/consumer/RebalancePushImpl.java
49.18% <100.00%> (ø)

... and 39 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is there a possibility that introducing changes to Subversion will disrupt other functions?

Is there a possibility that introducing changes to Subversion will disrupt other functions?

The generation of subversion only made changes to the client side, and no changes were made to the broker side.
The expiration and removal of SubscriptionData is handled through the newly added lastUpdateTime.

Heatbeat does not update the timestamp of subscriptionData. It updated at pullRequest. so the consumer group will not be removed in removeExpireConsumerGroupInfo. The above modification is correct, IMO.


fix: small typo

Pull Request Test Coverage Report for Build 755095263

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.719%

Totals

Change from base Build 751583763:
0.0%

Covered Lines:
111

Relevant Lines:
128

💛  - Coveralls

Thank you ❤.

Pull Request Test Coverage Report for Build 755095263
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.719%

Totals

Change from base Build 751583763:
0.0%

Covered Lines:
111

Relevant Lines:
128

💛  - Coveralls


⚠ Bofrost.ch has degraded performance

In 067cad7, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 1593 ms

Resolved: Bofrost.ch performance has improved in aa98bad after 6 minutes.


Routes with dots cause 404

An example route
{
    "path": "/task/:id",
    "page": "./task",
    "chunk": "main",
    "data": {
      "task": "GET http://example.com/api/task/id"
    }
 },

Will take a url /task/1234 and make a request to http://example.com/api/task/1234
But an id with . in it eg /task/123.3 results in a 404 error

Can you try doing (nothing needed to be installed)
"path": "/task/:id(.*)",

I had a similar issue with trying to add / to the pathname in my react-starter-kit project (both use universal-router).  Now I can put / . < > * all in my route
Here is a link to my pull request documenting it
https://github.com/kriasoft/universal-router/pull/112


Unable to cancel App Shutdown from Window Closing

Describe the bug
I have an application that prompts the user to confirm when they try and close the apps main window.
I'm currently doing this using Avalonia.Xaml.Behaviors to wire up the Closing event to an async RelayCommand in the viewmodel.
When you close the window with the red X this works as desired.
However, on macOS when you close the app from the menu bar or from the dock this does not work.
The closing event is raised but the app closes when the first await is fired (even if e.Cancel = true; is set).
To Reproduce

Create a new Avalonia Project
Wire up the MainWindow Closing event to a new method in the code behind
Set body of the Closing method to:

e.Cancel = true;

Run the app on macOS and try closing the window directly (it shouldn't close)
Close the app from the menu bar or the dock (it will close)

Expected behavior
All methods to gracefully close the app should be cancellable.
Environment

OS: macOS 13.6
Avalonia-Version: 11.0.9

Additional context
You can cancel the app shutdown from the ShutdownRequested event however the remarks for this event reads:
This event provides a first-chance to cancel application shutdown; if shutdown is not canceled at this point the application will try to close each non-owned open window, invoking the Closing event on each and allowing each window to cancel the shutdown of the application.

I have the same issue but on windows.
I use ShutdownRequested event and set e.Cancel = true;.
When I click the red cross button main window closes, but app continues to work.
I also have another problem.
When I call save project method and then I click the red cross or shutdown my app in another way I want to wait for saving finished. I think I should do this in OnShutdownRequested (handler) but the handler blocks saving process. What should I do? Maybe I should call save method in some different way?

@THE-KONDRAT if you want to prevent a Window from closing, why not override OnClosing in the Window or listen to the Closing-Event?

@THE-KONDRAT if you want to prevent a Window from closing, why not override OnClosing in the Window or listen to the Closing-Event?

I'm sorry but where should i override this event?
I want to control both the cross button click and manual shutdown request.
I thought i should use IClassicDesktopStyleApplicationLifetime (in my case) in app.axaml.cs.

In MainWindow.axaml.cs

In MainWindow.axaml.cs
Ok. That works.

And how can i wait another method inside OnClosing?

something like that should work
private bool _canClose;

protected override void OnClosing(WindowClosingEventArgs e)
{
    if (!_canClose)
    {
        // cancel closing
        e.Cancel = true;

        _canClose = await DoAsyncStuff(); // async stuff should return bool here
        if (_canClose) this.Close(); // request close again if above was successful
    }
    base.OnClosing(e);
}

Thanks! This also works. Maybe someone find this usefull.
protected override async void OnClosing(WindowClosingEventArgs e)
{
    var context = Ioc.Default.GetRequiredService<ApplicationContext>();
    if (!context.CanClose)
    {
        e.Cancel = true;
        await context.WaitForAsync(nameof(context.CanClose), q => q.CanClose);
        if (context.CanClose) this.Close();
    }
    base.OnClosing(e);
}

Just to clarify, this is not what this issue is about.
The issue I'm having is when the app is being closed by the OS (not when clicking close on the window).
If you wire up the OnClosing the same as above, but on macOS you close the application from the menu bar or by right clicking it on the dock. The OnClosing event will fire but the app will close regardless.

@nixtar I'm aware of that, and this is why I didn't close it.

From how it looks, this functionality was broken for two years since https://github.com/AvaloniaUI/Avalonia/pull/7400

Finally got a chance to test this with 11.1.0-beta2 and am happy to confirm it now works as expected. 👍


markup/highlight: Make lineNumbersInTable = false default

Closes #9596

Please hold this merge until https://github.com/gohugoio/hugo/issues/9596#issuecomment-1062487823 is resolved.

Closing. See comments on https://github.com/gohugoio/hugo/issues/9596. Firefox...


Window Focus/Visible Events

lovr.focus and lovr.visible are also called for the desktop window now.  They have a second parameter, display, indicating whether the event came from the headset or the window.
Add lovr.system.isWindowVisible and lovr.system.isWindowFocused.

Minor TODO: simulator could emit visible and mounted events.

:+1:  Works well


Creating PDF from HTML missing alignments

Hi,
Using jspdf to generate PDF out of html.

When converted to PDF everything on HTML comes as left aligned.
screenshot if PDF is attached and also the file.

New Patient Form (3).pdf
How to preserve the styles & formatting.

Which HTML method do you use? Note that addHTML and fromHTML are deprecated. Use html() instead.

@ckudikala-eprosoft hello. Could you please update the issue with the required Information?


Dependency Mapping between AWS and Kubernetes resources

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

I am trying to solve following use case -

Create an AWS RDS instance using - pulumi-go-aws and once the RDS instance is created completely , create and Kubernetes secret with RDS endpoint , username and password details.
Upload this code into a github repo and a pulumi-stack.yaml.
Using pulumi-kubernetes operator , deploy pulumi-stack.yaml to create stack.

When I tried this activity assuming, pulumi will take care of the dependency mapping, I got a different behaviour.
The Kubernets secret which got created had garbage values , which means the kubernetes secret creation did not depend on AWS instance creation.
Is this  possible to achieve this without implementing additional concurrency behaviour inside the code?
attaching a sample code where which refers the similar case with AWS Security Group example.
package main

import (
	"encoding/base64"
	"fmt"

	"github.com/pulumi/pulumi-aws/sdk/v4/go/aws"
	"github.com/pulumi/pulumi-aws/sdk/v4/go/aws/ec2"
	corev1 "github.com/pulumi/pulumi-kubernetes/sdk/v3/go/kubernetes/core/v1"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi/config"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {
		region := config.Require(ctx, "region")
		vpcID := config.Require(ctx,"vpcID")
		sgName := config.Require(ctx,"securitygroup-name")
		config := config.New(ctx, "")
		roleToAssumeARN := config.Require("roleToAssumeARN")

		provider, err := aws.NewProvider(ctx, "privileged", &aws.ProviderArgs{
			AssumeRole: &aws.ProviderAssumeRoleArgs{
				RoleArn:     pulumi.StringPtr(roleToAssumeARN),
				SessionName: pulumi.String("PulumiSession"),
				ExternalId:  pulumi.String("PulumiApplication"),
			},
			Region: pulumi.String(region),
		})

		if err != nil {
			return err
		}

		// Create a security group
		group, err := ec2.NewSecurityGroup(ctx,sgName,&ec2.SecurityGroupArgs{
			Description: pulumi.String("creating test sg for pulumi iam-role poc"),
			VpcId: pulumi.String(vpcID),
			Ingress: ec2.SecurityGroupIngressArray{
				ec2.SecurityGroupIngressArgs{
					Protocol:   pulumi.String("tcp"),
					FromPort:   pulumi.Int(80),
					ToPort:     pulumi.Int(80),
					CidrBlocks: pulumi.StringArray{pulumi.String("<IP_ADDRESS>/0")},
				},
			},
		},pulumi.Provider(provider))

		if err != nil {
			return err
		}

		fmt.Println(" Creating a K8S secret... ")
		k8sSecret,err := corev1.NewSecret(ctx,"secret"+"-"+ctx.Stack(),&corev1.SecretArgs{
			Data: pulumi.ToStringMap(map[string]string{
				"security-group-name": base64.StdEncoding.EncodeToString([]byte(fmt.Sprint(group.Name))),
				"security-group-arn":  base64.StdEncoding.EncodeToString([]byte(fmt.Sprint(group.Arn))),
			}),
		})
		if err != nil{
			return err
		}
		ctx.Export("SecretRef",k8sSecret.Metadata.Name())
		return nil
	})
}

Affected area/feature

Hi there, it appears the issue you're having is that group.Name and group.Arn are not strings, but are a "string output". You're masking this issue through the use of fmt.Sprintf. You can read more about how to work with outputs in our docs.
It appears the Data arg doesn't support Pulumi types, so this might have to be wrapped in an Apply function possibly.
Closing as this isn't a provider issue.


Upgraded to Angular 2.1.0

Updated to 2.1.0, this is a drop-in replacement.

Thanks very much @ykoehler 👍


Loop Sound

Maybe we should put the sound to play 2 or 3 times, just to more feedback.

Currently, I'm well satisfied with only once time.
We can keep the issue open to see if other people's can give feedback.


[INFINITY-3076] Fix uninstall documentation link in hello-world postUninstallNotes.

PR to backport #2185 to 0.30.X

Merging as CI failures are unrelated


adding csv file with updated and edited gsp names and ids

Pull Request
Description
I've made a finalised csv file with gsp_id and region_name to update the database and added the reference to the file in update_region_name.py file in the scripts folder.
There were a few lingering duplicate gsp's that I identified with "Zone 1" and "Zone 2". They are the following:

Willesden
Beddington
Ferrybridge
Kirkby
Littlebrook
Walpole

The following gsp_name's didn't have a matching previous name:

G_EXTRA_12
QUOI_P

I wasn't sure how to look these locations up quickly.
This fixes #34
Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

@all-contributors please add @rachel-labri-tipton  for code


Workflow improvements 3

Following on from #2998, this again attempts to enable Arm64 testing given the Cargo and GitHub limitations discovered on previous attempts.
Specifically, this update adds the generated arm64.yml workflow that tests all crates using --no-run so that at least all code cross-compiles targeting Arm64. Workarounds:

--no-run is required since GitHub doesn't provide Arm64 runners
Cargo doesn't reliably support cdylib dependencies - https://github.com/rust-lang/cargo/issues/9661

Number 3000! 🎉🎉


Tweak testing instructions

Skipping directory isn't in the test output, but SKIP is.

@facebook-github-bot shipit


delete tokens

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Hello, we would like to delete our tokens, because we found some issues with the previous one, and we cannot add a new token with the same name.
Previous pull requests:
https://github.com/solana-labs/token-list/pull/24575
https://github.com/solana-labs/token-list/pull/23953

Hello, we would like to delete our tokens, because we found some issues with the previous one, and we cannot add a new token with the same name.
Previous pull requests:
https://github.com/solana-labs/token-list/pull/24575
https://github.com/solana-labs/token-list/pull/23953


Correct obvious mistake in comments of query

Replace 'Deletes' with 'Find' in the .find method's comment block.

Thanks!


🐛Bug: Multiple popovers open at the same time

Describe the bug
Multiple Popover open at the same time, even if they are supposed to close when clicked outside.
To Reproduce

Open Stackblitz below
Click any row "actions" icon
Click another row "actions" icon while first still open
Now multiple popovers are open

Bonus : Click "close" button closes only one. Click inside one closes all others. Click outside closes all.
#367

if your code isn't private you just do stackblitz.com/github/lolcabanon/<YOUR_REPO_NAME> and it will spin up a stackblitz with it!

It is, but here's a stripped out clone : https://stackblitz.com/github/lolcabanon/melt-ui_367
I suspect the library svelte-headless-table which I used to build the table has a role to play, since it uses a lot of e.preventDefault() and e.stopPropagation(). I added some stuff to it recently, so I noticed it after my last comment on thread #367.
Expected behavior
Other popover would close when another open (as it works in other places)
Screenshots

Desktop :

OS: Manjaro Plasma
Browser : Chrome 116

Additional context
See https://github.com/melt-ui/melt-ui/issues/367#issuecomment-1671950804

Hey @TGlide ! Thanks for looking into my issue!
Weirdly enough, the PR solved the issue on the demo I shared yesterday... But not in my main project (which is work for a client I cannot share as is) ^^ Just updated pn i @melt-ui/svelte@latest @melt-ui/pp@latest and I can still open many popovers...
Also tried it on the same page but outside the table (see https://stackblitz.com/github/lolcabanon/melt-ui_367 for context) and in another page without the table : it is also happening. (Firefox & Chrome)
Once again, I feel like I cannot provide reliable reproduction... This can stay closed for the moment, and I'll keep you updated if I find something useful!

Hey @TGlide ! Thanks for looking into my issue!
Weirdly enough, the PR solved the issue on the demo I shared yesterday... But not in my main project (which is work for a client I cannot share as is) ^^ Just updated pn i @melt-ui/svelte@latest @melt-ui/pp@latest and I can still open many popovers...
Also tried it on the same page but outside the table (see stackblitz.com/github/lolcabanon/melt-ui_367 for context) and in another page without the table : it is also happening. (Firefox & Chrome)
Once again, I feel like I cannot provide reliable reproduction... This can stay closed for the moment, and I'll keep you updated if I find something useful!

Oh, that's quite odd! Yes, if you manage to create a reproduction, please let me know!

@TGlide Just letting you know 5d41f20 fixed this issue on my end! Thanks a lot :) You guys are unreal :astonished:


Fix "find and replace" initializing with wrong size

Regression.

Update:
Added fix #14812.

We discussed this on IRC, @reduz and @groud mentioned that the anchoring code should be removed now that the script editor is made a VBoxContainer, and that should remove the need for the hackish call to the grandparent's minimum_size_changed.

Removing the anchoring will work more or less, this hack fix that particular situation:

When the FindReplaceBar appear, the tab_container only update when a NOTIFICATION_RESIZED occurs.
If you don't mind with that I can remove and let this way or I can do the "signals changes".

Then the problem is probably a little bit deeper than that. The HBoxContainer should emit a resized signal when it's content is made visible. That's probably where the problem lies.

@groud Agree, but I notice that it's doesn't happen, if we expect this behaviour then we have another bug. I'll look this asap.

Ok, I found the problem, TabContainer was not a Control.

Ok, I found the problem, TabContainer was not a Container.

That was quite unexpected... The change makes sense I guess.

Yeah, I'm surprised too. :)

Don't merge yet, I'll make some tests.

I'll check for possible regressions here.

This regressed visual scripting editor.

Subject: [PATCH] Fix regression from "Fix "find and replace" initializing with
 wrong size".

---
 modules/visual_script/visual_script_editor.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/visual_script/visual_script_editor.cpp b/modules/visual_script/visual_script_editor.cpp
index 6df0b5036b5..532d79423cb 100644
--- a/modules/visual_script/visual_script_editor.cpp
+++ b/modules/visual_script/visual_script_editor.cpp
@@ -3481,6 +3481,7 @@ VisualScriptEditor::VisualScriptEditor() {

 	graph = memnew(GraphEdit);
 	add_child(graph);
+	graph->set_v_size_flags(Control::SIZE_EXPAND_FILL);
 	graph->set_anchors_and_margins_preset(Control::PRESET_WIDE);
 	graph->connect("node_selected", this, "_node_selected");
 	graph->connect("_begin_node_move", this, "_b

Thanks.


Execute javascript after page load

Hi.
I'm learning javascript right now so I'm sorry if this is a stupid question:
I have this page: http://stage.aare.guru/
Its a very simple page, where the data is loaded trough a json and then bound to a ID within the html markup.How would I wove this into barba.js so my code still works?
I installed barba.js but if I just add Barba.Pjax.start(); of course my code dowsn't execute anymore.
Which part of your doc's contains this?
I guess I have to wrap it somehow into the barba code:
var Homepage = Barba.BaseView.extend({
  namespace: 'homepage',
  onEnter: function() {
      // My Code right?
     $.ajax({
         url: "http://aareguru.existenz.ch/current.php",
         dataType: 'json',
         success: function( data ) {
              var currentReadable = moment.unix(currentUnix).format();
              $( "#nowUnix" ).text( currentUnix );
             //  and so on and so on
        }
     });
  },
});

Homepage.init();

That doesn't work. But I guess it should be something like this right?

Make sure that the data-namespace is correctly added to your .barba-container and that the namespace match the one you have in the barba view

Ahh. I mapped the namespace to the ID not the class. Thank you.


Try isonet background estimation

@uermel suggested using isonet's background estimation method.
the issue with the current approach borrowed from TomoTwin is that if the image is primarily biological material of interest, then the median is actually exactly not the right thing to label as background....

Closing for now because we have removed background estimation because it is not a critical feature.


When password has expires Authenticate still returns true

Hi Brok,
Doing a spot of digging into the code. Just found that when a users password has expired, the Authenticate method still returns true.
Looking at the code in LoginController.Index this is by design.
Truth be told, I don't like that design! It seems an unsafe default - just saying. It took me by surprise as I had in my head that Authenticate was another name for CanLogin...
C

Well, how could you validate the credentials to allow them to change the password if it's expired? This is something that is up to the hosting app to check after authentication -- as the samples show.

Agreed. It just took me by surprise.
I think I would have preferred the Authenticate method to have returned an AuthenticateFailureType enum
That way for the simple case where consumer code just wants to know if the user is allowed to login:
if (userAccountService.AuthenticateWithEmail(...) == AuthenticateFailureType.None) {
  // allow login
} else {
 // disallow login
}

Or for the more sophisticated consumer:
switch (userAccountService.AuthenticateWithEmail(...).FailureType)
{
    case AuthenticateFailureType.None:
        // handle login success
    case AuthenticateFailureType.InvalidCredentials:
        // handle failure
    case AuthenticateFailureType.PasswordExpired:
        // handle failure
    case AuthenticateFailureType.TwoFactorAuthCodeRequired:
        // handle failure
    case AuthenticateFailureType.TwoFactorAuthCertRequired:
        // handle failure
    case AuthenticateFailureType.PasswordResetRequired:
        // handle failure
}

Sure -- but this grew over time into that list. Thus the extension methods on the UserAccount. shrug

Seems a shame not to change things so that it could return an enum.
I think it would provide a much simpler api to the consumer - a single query method to call rather than have to fish around in all the properties and extension methods of the UserAccount.
C

I'd be ok making that change -- in a vNext (since it's a breaking change). This then gets into the question of ASP.NET 5 and their new (new new) Identity library (since v3 isn't compat with v2 -- so much for them finally getting it right) -- I'm wondering if MR offers anything beyond what's in AspNet5.

Also by returning an enum, the api would afford to take on extra reasons for not allowing login without all consumers necessarily having to be adjusted to check for this new reason.

Ah so I didn't know about this new new Identity library!

I do prefer the most of the design choices in MR over what I have seen in Identity 2.0

So Brock are you happy for an API change as mentioned: https://github.com/brockallen/BrockAllen.MembershipReboot/issues/487#issuecomment-72376170

Perhaps put this on a branch to review, chat about it, etc.

OK makes sense

Also, feel free to ping me on skype.

Thanks Brock

Fixed via PR.


Update feed-reader so it fix an edge case in #82

As spectated in https://github.com/wonderfulsoftware/webring/pull/82#issuecomment-1024415464, the feed-reader package now release 5.0.0-rc3 which should fix the edge case.
Since I'm not familiar with node.js development, this PR only update the package.json file, while leaving yarn.lock untouched. Please consider updating the build environment.

It works, thank you!


Why does inference take a lot longer on the first scan?

Hi,
When running inference, the first scan always takes a lot longer (0.5-0.7 sec) compared to all other scans (0.01 sec), is there a way to fix this?
If not, I was wondering if you have any suggestions on how to implement live inference? For example, continuously infer new scans in the data directory. Currently I'm just running the inference script over an over, but because the first scan alway takes so long, the performance isn't great.

Hi there,
I don't think there is a way to fix this if you re-run the script every time, because the first time the inference happens, Pytorch has to send the model to the GPU, and do some benchmarking of the ops being run in the model.
Just to be clear, what you would like is that every time a new scan shows up in the pointed directory it gets inferred and sends the result to a different directory? If this is the case, then the best way to do it is to have a separate thread analyzing the directory, and if you have new frames or not and pushing to a queue, and then have the for loop for the inference popping from the queue, and blocking when there are no scans. Something KIND OF like this.
I am a big fan of TCP sockets, this may be a good way to do it (kind of how ROS works). You can make an infer script that loads the pytorch model and waits for TCP messages, and then have another, much simpler script that basically does the check for new scans and pushes them to the other script through TCP, and returns the result. The advantage of this is that you could even run the inference in a remote computer and have multiple clients sending requests. This is how cloud inference works in a way, and it would even allow you to batch scans from different users, and fully utilize the GPU, for faster overall processing. This may be like killing a bird with a cannon, but it could be a nice solution for scaling up afterwards :)

Great, thanks for the suggestion! I will try it out.


searchType: table fails with error in console

This could easily be a syntax mistake on my part, but providing details in case it's not.
Table is in /testTable.md, contents:
# Hello

| theDate    | theValue |
| ---------- | -------- |
| 2021-07-11 | 2        |
| 2021-07-12 | 4        |
| 2021-07-20 | 10       |

Tracker is in /testTracker.md, contents:
```tracker
searchType: table
searchTarget: testTable[0][0], testTable[0][1]
xDataset: 0
line:
    yAxisLocation: none, left
    lineColor: none, red
    showLegend: true
```

This gives the following error in console when viewing testTracker.md:
main.ts:469 Uncaught (in promise) TypeError: Cannot read property 'getParentTarget' of null
    at _l.eval (eval at <anonymous> (app.js:1), <anonymous>:15:167456)
    at Generator.next (<anonymous>)
    at o (eval at <anonymous> (app.js:1), <anonymous>:15:165)

I'm using Obsidian v0.12.10 and Tracker v1.8.2.

Thanks for the report.
Will check it when I back home.

Hi @davecahill,
I got the same error messages while filling the field searchTarget.
And after the code block was completed, a chart was generated as expected and no more error messages in the console.
If you cannot get chart rendered, please check this example prepared for you.
I will suppress the error messages and release the fix in next version.

Thanks for looking into this @pyrochlore ! My graphs are working now, much appreciated. I couldn't find any differences between the example and the markdown I had, but I'm happy to let that mystery slide since everything works great. :)

Will close this issue.
More suggestions or reports are welcome.


GAME BREAKING BUG [1.18.2] [MINING MASTER 3.0.5]

Describe the Bug
I will start off by saying that I am a Modpack Developer and currently developing the 1.18.2 update for my Modpack Vanilla Plus by Cama.
Our team agreed that the mod Mining Master is a really good mod to have installed on our pack since Apotheosis makes End Game Enchanting a thing and to balance that out, we re-work Start Game Enchanting (your mod).
We are currently in the Server Testing portion of our mod and found out that, when a player applies an ability to an item (Frost on Sword or Smelting on a Pickaxe), that effect is applied for every single player Globally and it works if they use their fist.
This is extremely game-breaking, and causes a lot of issues as you can probably tell. Every single player has access to the abilities that are only supposed to be specific to one item.
Not only does this affect players, but any sort of mod that adds things that interact with the world as though players do. CREATE MOD for example will drop smelted items instead of the normal drop if just one player has a smelting thing on their pickaxe.
I have no clue how to reproduce this bug, I am providing a link to download my MODPACK in the form of a ZIP file used on CurseForge and a link to download the SERVER FILES for my MODPACK. I will include LOGS (Debug and Normal). There is no crash report so I cannot send that. In order to find this bug, you will have to actually open a server.
I apologize that I cannot help or provide any further information. This is all I got. I don't know if there are any mod conflicts either.
Also, I wanted to point out that you have not updated the drop-down for version selection on GitHub. I put the current version in the TITLE of this BUG REPORT.
Reproduction Steps

Join a multiplayer server on my modpack

Expected Result

Special Enchanted Abilities on Items should be specific to the ITEM and NOT GLOBAL FOR EVERY PLAYER

Screenshots and Videos
No screenshots or Videos.

If you wouldn't mind doing additional tests: Could you consider taking out every other enchanting-related mod in the modpack and seeing if this effect still happens? Narrowing down the issue/conflict to another mod would help a lot!

I can definitely try that tomorrow. I have been working my a** off on this modpack and I hate testing a series of mods but it will help you and also help us. I can work on this tomorrow!

I really appreciate it! My theory is that there’s something off with the loot modifier, but I have honestly no idea what should cause it. The loot modifier should only apply if the block is being mined with a tool with the enchantment, so no idea why it would check ALL players on the server for that enchantment. I probably won’t be able to take a look until end of this week or early next week, but I’ll do my best to get to it ASAP!

I tried disabling Enchantment Mods but I wasn't getting any results. I'm sorry that I couldn't be more help. Hopefully, you guys can figure this one out!

Of course! Thank you for testing that out!

Upon further testing, it seems that the bug is entirely random. There were times in a single-player world where the issue occurred and other times it didn't. This makes troubleshooting extremely difficult :\
Next time it happens, I will send logs.

I'm curious, based on your initial report, I don't understand how this could happen in single-player. Could you elaborate on how this bug shows itself in single-player?

Apologies for the late response. I will do some more testing and see if I can re-produce this bug again. It's happening at random it seems.

I haven't noticed this issue in newer updates. It may have been a conflict with another mod.

Experiencing this in 1.19.2. Applied Grace V to a chestplate and now any entity (including mobs) that touches water receives the Dolphin's grace effect for 30 seconds, even after the offending piece of armor has been destroyed.
Here's a spark readout from my testing which includes a full list of involved mods: https://spark.lucko.me/ruH0bM5ND8
Specifically, I'm running this modpack: https://www.curseforge.com/minecraft/modpacks/grindergard-revolution
I can't imagine why there would be even a player-level flag getting set for this, but I'll try to dig around with NBTExplorer in the world save and see if there's something in the world or player data related to this as that's the only other thing I can think to check.

Update: Restarting the server ends the bug, but it crops up on an enchant-by-enchant basis. The first time silk touch was applied to a tool using spider kunzite, all blocks began dropping themselves when broken with a bare hand or with breakage like leaf decay. I haven't had a chance to test extensively yet, but it appears to be tied to the first time an enchant is applied rather than every time.

So I'm not really sure how his works, but is something like this the problem?
        if (livingEntity.isInWater()) {
            for (int i = 0; i < nbtList.size(); i++) {
                CompoundTag idTag = nbtList.getCompound(i);
                // You check if the entity has an item with the relevant enchant
                if (idTag.getString("id").equals(MMEnchantments.GRACE.getId().toString())) {
                    if (livingEntity.hasEffect(MobEffects.DOLPHINS_GRACE) && playerEntity != null && !playerEntity.isCreative() && rand.nextInt(100) == 0) {
                        stack.hurtAndBreak(1, livingEntity, (onBroken) -> {
                            onBroken.broadcastBreakEvent(EquipmentSlot.CHEST);
                        });
                    }
                    if (((LivingEntityAccess) livingEntity).getGraceRecharged()) {
                        livingEntity.addEffect(new MobEffectInstance(MobEffects.DOLPHINS_GRACE, 120 * idTag.getInt("lvl")));
                        ((LivingEntityAccess) livingEntity).setGraceRecharged(false);
                    }
                }
            }
        } else if (!livingEntity.isInWater() && livingEntity.isOnGround() && !((LivingEntityAccess) livingEntity).getGraceRecharged()) {
            // You do not check for the relevant enchant and just give everyone the grace effect?
            ((LivingEntityAccess) livingEntity).setGraceRecharged(true);
        }

Interesting... thank you for these updates! I'm in a bug-fixing grind for MM right now, so I'll look into this a bit!

I have pretty good reason to believe that this was actually tied to the same issue as #49. I've resolved that for the next version that will be released. I'm going to close this issue for now as resolved. If the issue persists in the next Mining Master release, please feel free to reopen this issue. Given that it's so hard to test this bug since it shows up so sporadically, it's hard to say. But your info about it happening when enchanting (I'm assuming using the gems in a smithing table, given the issue I discovered) seems to point to the bug I just resolved.


Change egg hatching text

Short Description: Clearify the egg hatching text
Fixes:

changed egg hatching text

@Jasperrr91 i agree! it's just weird :+1:


Returning list of op names in get_graph_ops and extended error atoms to all TF error codes

So this PR covers the changes you had last requested @josevalim. Other than that I have just removed some unused code from before. Also ensured I am using enif_make_binnary wherever needed instead of enif_make_string:

Extending the error coverage: The C function error_to_string handles that now and an example of a faulty graph reading attempt would look like this:

iex(1)> graph = Tensorflex.read_graph "Makefile"
{:error, :invalid_argument}

Returning list of all operations in graph instead of directly printing them: This has also been taken care of, and now the function is called get_graph_ops which returns a List of strings (op names in the graph). An example is as follows:

iex(1)> graph = Tensorflex.read_graph("classify_image_graph_def.pb")
2018-05-17 23:36:16.488469: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that    this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA 2018-05-17 23:36:16.774442: W             tensorflow/core/framework/op_def_util.cc:334] OpBatchNormWithGlobalNormalization is deprecated. It will cease to work in   GraphDef version 9. Use tf.nn.batch_normalization().
Successfully imported graph
#Reference<0.1610607974.1988231169.250293>

iex(2)> op_list = Tensorflex.get_graph_ops graph
["softmax/biases", "softmax/weights", "pool_3/_reshape/shape",
 "mixed_10/join/concat_dim", "mixed_10/tower_2/conv/batchnorm/moving_variance",
 "mixed_10/tower_2/conv/batchnorm/moving_mean",
 "mixed_10/tower_2/conv/batchnorm/gamma",
 "mixed_10/tower_2/conv/batchnorm/beta", "mixed_10/tower_2/conv/conv2d_params",
 "mixed_10/tower_1/mixed/conv_1/batchnorm/moving_variance",
 "mixed_10/tower_1/mixed/conv_1/batchnorm/moving_mean",
 "mixed_10/tower_1/mixed/conv_1/batchnorm/gamma",
 "mixed_10/tower_1/mixed/conv_1/batchnorm/beta",
 "mixed_10/tower_1/mixed/conv_1/conv2d_params",
 "mixed_10/tower_1/mixed/conv/batchnorm/moving_variance",
 "mixed_10/tower_1/mixed/conv/batchnorm/moving_mean",
 "mixed_10/tower_1/mixed/conv/batchnorm/gamma",
 "mixed_10/tower_1/mixed/conv/batchnorm/beta",
 "mixed_10/tower_1/mixed/conv/conv2d_params",
 "mixed_10/tower_1/conv_1/batchnorm/moving_variance",
 "mixed_10/tower_1/conv_1/batchnorm/moving_mean",
 "mixed_10/tower_1/conv_1/batchnorm/gamma",
 "mixed_10/tower_1/conv_1/batchnorm/beta",
 "mixed_10/tower_1/conv_1/conv2d_params",
 "mixed_10/tower_1/conv/batchnorm/moving_variance",
 "mixed_10/tower_1/conv/batchnorm/moving_mean",
 "mixed_10/tower_1/conv/batchnorm/gamma",
 "mixed_10/tower_1/conv/batchnorm/beta", "mixed_10/tower_1/conv/conv2d_params",
 "mixed_10/tower/mixed/conv_1/batchnorm/moving_variance",
 "mixed_10/tower/mixed/conv_1/batchnorm/moving_mean",
 "mixed_10/tower/mixed/conv_1/batchnorm/gamma",
 "mixed_10/tower/mixed/conv_1/batchnorm/beta",
 "mixed_10/tower/mixed/conv_1/conv2d_params",
 "mixed_10/tower/mixed/conv/batchnorm/moving_variance",
 "mixed_10/tower/mixed/conv/batchnorm/moving_mean",
 "mixed_10/tower/mixed/conv/batchnorm/gamma",
 "mixed_10/tower/mixed/conv/batchnorm/beta",
 "mixed_10/tower/mixed/conv/conv2d_params",
 "mixed_10/tower/conv/batchnorm/moving_variance",
 "mixed_10/tower/conv/batchnorm/moving_mean",
 "mixed_10/tower/conv/batchnorm/gamma", "mixed_10/tower/conv/batchnorm/beta",
 "mixed_10/tower/conv/conv2d_params", "mixed_10/conv/batchnorm/moving_variance",
 "mixed_10/conv/batchnorm/moving_mean", "mixed_10/conv/batchnorm/gamma",
 "mixed_10/conv/batchnorm/beta", "mixed_10/conv/conv2d_params",
 "mixed_9/join/concat_dim", ...]

Comments added. Other than that, it looks great to go! :+1:
What next steps do you have in mind? :)

Thanks for the feedback @josevalim!
I have been thinking about the next steps, and the logical progression of adding functions should eventually get to the point where we can run the loaded graph against our own inputs and generate prediction outputs. For this to work, a lot of functions need to be added first: particularly ones that will allow us to read Tensors supplied by the user. I am thinking over how I would accomplish this and then I will submit a PR for review. These TF_Tensor functions are very important and they would have to encompass a wide variety of inputs.
I might also keep importing graph based functions from Tensorflow as and when required (like the operation list function get_graph_ops) After that, I think some more graph based functions will be needed that will use both the tensor functionality and the graph functions. Finally, we will need to add support for creating and running Sessions.

@anshuman23 agreed! :heart:
Let's go with this plan and continue exploring the API and the "user story" but note that at some point we will have to "sit down" and write documentation and tests.
Also, can you please send an e-mail to the beamcommunity mailing list with your progress so far and your plans for the next week? What is coming next can be a very quick digest, like this one that you just sent!

Thanks @josevalim, and I completely agree on taking time out to write documentation and tests. I will incorporate that into my plans as well. :)
Yes, I'll send that email right away. Thanks again for all the help!


Create a changelog

Currently all releases are made without any notes to show what's included in each release. Also there is no CHANGELOG.md file in the project that basically shows the same thing.

Better would be just to add notes here: https://github.com/bitovi/syn/releases


Update Cli.FunctionalTests for latest 2.2-preview3

Also remove expected files for 2.1.  Previously, a single test project was used to test both 2.1 and 2.2.  Now, the tests are branched into release/2.1 and release\2.2.

Do not merge until verification build has passed: https://dnceng.visualstudio.com/internal/_build/results?buildId=24660&view=logs

@natemcmaster : Tests passed, should be ready to merge once you approve.


Add FunC section

TODO new section

No k đc

https://github.com/ton-community/awesome-ton/blob/aa62b1b2d0c429a12042bfa2cc9c24e1a6426c73/contributing.md


FLIP: FCL Tx Payer Service

FLIP: FCL Tx Payer Service

Great stuff @JeffreyDoyle ! Most of my comments were abound the non-tech aspects. I want to make sure we make this FLiP extremely clear to ALL parties (PMs, engineers, business people). The beginning part of this we could workshop it a bit to make this really clear. The what and the why here should be super super clear to get interest from outside parties.
May be good to get @laynelafrance's eyes on this too from a functional perspective. @laynelafrance can you read this from the POV of 'I am a freelance product person and I am trying to understand why I would do this and the longevity of if I make this into a business.'

If there will be rate limits, blacklists, and transaction verification, etc will be needed anyway, do you really need the API_KEY there?
If we remove API_KEY, this removes the need to have backend communication between Dapp and TPaaS. Also, TPaaS can provide more analytics to Dapp.
Also I think some Dapps may want to support something like sponsor transaction costs if the user doesn't already have enough flow to cover the transaction cost (or below some balance threshold).

In the light of those, wouldn't be beneficial for TPaaS to host an access API? Work as like wallets, replace payer signature if come conditions met ( rate limits, blacklists, transaction verification, flow balance, etc), so by using their access node, you may have access to analytics and transaction payment just by pointing your access API URL to theirs.

Or at least if the wallet is sponsoring the transaction fee why should Dapp pay to TPaaS? It can be another service call before sending the transaction, so TPaaS can replace the signature only if necessary.  (I think in that case just a new FCL config for TPaaS endpoint should be enough)

@JeffreyDoyle submitted a few changes. I think you can leave out any additional 'definition of done' things. This should be outlined in the overall FLiP process. Anything specific to this exact project, you already outlined in the FLiP itself.

@JeffreyDoyle left a new review!

@JeffreyDoyle Is there any movement on this?


deps: Update from tokio 0.2 to 1

The stream interface was moved to the tokio-stream crate. Bytes was removed from the tokio public interface (and breaks usage of StreamExt::collect).

@jmaygarden All set: https://crates.io/crates/saltlick/0.5.0. Thanks again!

@jmaygarden All set: https://crates.io/crates/saltlick/0.5.0. Thanks again!

My pleasure! Also, I have a fork that replaces sodiumoxide with crypto_box and crypto_secretstream since they are being actively maintained. Would you be interested in a PR of that?

My pleasure! Also, I have a fork that replaces sodiumoxide with crypto_box and crypto_secretstream since they are being actively maintained. Would you be interested in a PR of that?

Very much interested, yes! I'd love to remove the extra C library steps.

Hey @jmaygarden - I'd still be really interested in getting crypto_box and crypto_secretstream integrated. Even if your branch isn't production ready, would you mind throwing it up on your branch? I can take it from there. Thanks!

Hey @jmaygarden - I'd still be really interested in getting crypto_box and crypto_secretstream integrated. Even if your branch isn't production ready, would you mind throwing it up on your branch? I can take it from there. Thanks!

I opened a PR: https://github.com/saltlick-crypto/saltlick-rs/pull/62


The integration test for Boot 3.0 upgrades should build the migrated project

Call mvn clean verify and fail the test if the build does not succeed

closed with #333


tail: moving to clap arg management

The file does not compile yet, because I do not understand how to extract the remaining files arguments. Earlier it was let files = given_options.free;. I cannot find the corresponding property in clap. Please help me find it.
I have removed the fn obsolete as it seems to be a specific getopts related hack. Please correct me if otherwise.
I have removed the usage/version if-checks because afair they are handled automatically by clap, but correct me if I'm wrong.

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted :sweat_smile:

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted :sweat_smile:

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted

Test locally ? :)
from my experience, getopts => clap are not platform-specific.

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted

Test locally ? :)
from my experience, getopts => clap are not platform-specific.

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted

Test locally ? :)
from my experience, getopts => clap are not platform-specific.

Hah, right, I am always a bit over-enthusiastic to push commits as soon as possible :sweat_smile:

On a side note, is there a way to disable the CI builds on a commit I already know is going to fail? I feel like a lot of Travis CPU time is being wasted

Test locally ? :)
from my experience, getopts => clap are not platform-specific.

Hah, right, I am always a bit over-enthusiastic to push commits as soon as possible :sweat_smile:

Yay, everything's green, please merge @sylvestre ^_^

Yay, everything's green, please merge @sylvestre ^_^

Thanks, I've made them both alphabetical. Also I already rebased the branch earlier today, and GitHub says "This branch has no conflicts with the base branch", so hopefully that should be fine.

Thanks, I've made them both alphabetical. Also I already rebased the branch earlier today, and GitHub says "This branch has no conflicts with the base branch", so hopefully that should be fine.

https://github.com/uutils/coreutils/pull/1683/files has recent changes ?!
maybe squash all your patches and do a force push?

https://github.com/uutils/coreutils/pull/1683/files has recent changes ?!
maybe squash all your patches and do a force push?


Malformed entry error appears when following installation instructions in a docker container.

I found a similar issue reported previously by someone else but it seems to have already been resolved.  Unfortunately, their solution didn't work for me.
| link to the mentioned discussion
| link to the mentioned documentation

Required Info

Camera Model
D455

Operating System & Version
Windows 10 subsystem for Linux (Ubuntu 22)

Kernel Version (Linux Only)
<IP_ADDRESS>-microsoft-standard-WSL2+

Platform
PC

Language
bash

Issue Description.
terminal commands + output messages:
# apt-get update
E: Malformed entry 1 in list file /etc/apt/sources.list.d/librealsense.list (Component)
E: The list of sources could not be read.

It seems that some important linux packages ("lsb-release" & "tee") weren't working properly in the docker container. Reinstalling them fixed this issue.

I'm pleased to hear that you found the solution.  Thanks very much for the update!


hi why use load_state_dict twice?

hi
I see in se_densenet_full.py, it use model.load_state_dict(state_dict, strict=is_strict)
And in test_se_densenet.py, it use
model = se_densenet121(pretrained=pretrained)
net_state_dict = {key: value for key, value in model_zoo.load_url("https://download.pytorch.org/models/densenet121-a639ec97.pth").items()}
model.load_state_dict(net_state_dict, strict=False)
why?

@2018hello It's redundant codes while model instance just need load weight file only once, please remove redundant codes, I will take it if you can make a pull requests.


nixos/tests: extend grafana test, nixos/grafana: use group grafana instead of nogroup

Motivation for this change
#64281
Things done
This extends the grafana test with configurations for postgresql and mariadb.
Also the user grafana is now in the group grafana, because nogroup was used before.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS (x86_64-linux & aarch64-linux)
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/cc @aanderse

@GrahamcOfBorg test grafana

@GrahamcOfBorg test grafana


Stop shift from cancelling follow as ghost

About the PR

When following something as a ghost, you can now press shift without being detached from the target.
Why / Balance

Fixes #23918
Fixes #22998
Technical details

Added a check to make sure that the movement input actually includes a directional button.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Pressing shift as a ghost no longer cancels following your target

does this fix pointing unfollowing too?

does this fix pointing unfollowing too?

It should, since I'm pretty sure that was caused by shift being held as part of the pointing keybind.


Add terms to spellcheck dictionary

This PR adds AI-related terms (Codestral, Nemo, Codellama) to the spellcheck dictionary to resolve build failures due to spellcheck errors.

i am curious as to why the CI/CD didn't fail due to the missing words, only one of them is from me, the other two already existed in the project


Not possible to access objects which do not have username and service parameters

At least in with git gnome keyring helper the github credentials are stored with user, server and protocol parameter so it's not possible to access password with hard coded username and service search parameters.
I was planning to overcome this issue by extending current interface with FreeGet and FreeSet functions which take instead of username and service the map of parameters.
What do you think about this approach?

@heppu Did you get around to implementing this? I noticed the same when trying to get the Github.com credentials for some git stuff I was doing using credential-osxkeychain...


Add support for labels on services

This fixes #342

[x] Chart version not bumped (the versions are all bumped and released at the same time)
[x] README.md updated with any new values or changes
[x] Updated template tests in ${CHART}/tests/*.py
[ ] (Not Required) Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

jenkins test this please


Exceptions when viewing diff's (repost of bug from atom/atom)

Hello
It seems git-plus is causing some exceptions to be thrown since the new experimental syntax highlighting was added. The atom developers managed to reproduce and pin it down and requested that we post the issue here [1].
 I guess the new grammar is producing unmatched close tags prematurely and illegally. This comment has an explanation. I think the atom api is becoming more fault tolerant so we can get away with this but I think it should be corrected if possible.
I need to admit I don't fully understand what is going on with the code for the diff grammar. Can you explain diff.js for me and/or point me to some resources?

I'll investigate it as soon as I get a chance. Unfortunately there aren't a ton of good references for the way grammar stuff works; I was able to come up with this because of the work I did on the semanticolor package.
TextMate grammas: https://manual.macromates.com/en/language_grammars
If you have syntax highlighting off, the diff.json grammar is only used. That shouldn't give any errors because it works like any other Atom grammar.
The diff.js grammar is more tricky because it's trying to do things that are more tricky. It uses the diff.json grammar as a base but also attempts to parse the file for the extensions of the code files that changed, in order to load the applicable grammars for them and have those run on the code. Then it has to merge the two results together. Apparently there are edge cases I missed. Definitely something I want to get working properly.


GUI shows wrong converted timestamp

CrateDB version:
3.2.1
Environment description:
docker: crate:3.2.1
Problem description:
gui shows timestamp as human readable date, but that is wrong:

Steps to reproduce:
create a table with a field of type TIMESTAMP and insert<PHONE_NUMBER>, i should see 2018-11-08T17:57:34 instead of 1970-01-18T19:02:51.981Z

@seut got it, thanks 🙈 🙄 👍


Added CLI command to deploy selected services/modules in production

In production, each service may be in different containers. To avoid
editing config to choose what to deploy, added the --modules/-m command
to the CLI
comma separated module names passed as values or the all keyword
If all is passed, or -m is not passed, all modules deployed
Updated deploy method to take list of module names
Overloaded recursiveDeploy to take list of module names
Organised imports, formatting and added javadoc

Hello Abhilash, thanks for checking the code. Regarding the documentation, we can add it to the Javadoc for Deployer.java. We can also add it to the README in a separate section called JAR Based. If you think this is fine, I'll make the changes. Is
java -jar ./fatjar.jar  --host $$(hostname) -c configs/config.json -m all

enough, or would you prefer having the $$AUTH_JAVA_OPTS and the logging arg also. If the latter is needed, could you give some details on it? I don't think it's mentioned in the README anywhere.

Hello Abhilash, thanks for checking the code. Regarding the documentation, we can add it to the Javadoc for Deployer.java. We can also add it to the README in a separate section called JAR Based. If you think this is fine, I'll make the changes. Is
java -jar ./fatjar.jar  --host $$(hostname) -c configs/config.json -m all

enough, or would you prefer having the $$AUTH_JAVA_OPTS and the logging arg also. If the latter is needed, could you give some details on it? I don't think it's mentioned in the README anywhere.

yeah we can have the whole thing,

AUTH_JAVA_OPTS: - variable containing any java options to be passed to auth server java app. Eg:  max heap size - -Xmx4096m
-Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.Log4j2LogDelegateFactory  option basically setting vertx logging java system property,  so that vertx components & libraries (rabbitmq client, vertx pgclient, eventloop logs, io.netty lib etc.) also logs using log4j2, refer docs

The command then is actually this  (the extra dollar is to just escape the $ in docker-compose file)
java $AUTH_JAVA_OPTS  -Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.Log4j2LogDelegateFactory -jar ./fatjar.jar  --host $(hostname) -c configs/config.json -m iudx.aaa.server.admin.AdminVerticle,iudx.aaa.server.token.TokenVerticle,iudx.aaa.server.registration.RegistrationVerticle,iudx.aaa.server.auditing.AuditingVerticle

where ./fatjar is place holder which can be ( generated by using the command mvn clean package -Dmaven.test.skip=true, generating the jars into target/ folder)
iudx.aaa.server-cluster-0.0.1-SNAPSHOT-fat.jar  -  vertx clustered jar file, containing micrometer metrics
or iudx.aaa.server-dev-0.0.1-SNAPSHOT-fat.jar - vertx non-clustered and does not contain micrometer metrics

You can add the system property in pom exec plugin and can use when bringing up using mvn clean compile exec:java@aaa-server . The needed change is here. Referred this stackoverflow answer for the change

I have added the required documentation to the Javadoc as well as the README.
Regarding the pom change for the logging, could you make a separate PR to this repo only (since it's not too related with this feature). I've omitted the logging argument from the docs because we won't need it even when running as a JAR once it's in the POM right?
If the doc changes are OK, the PR can be ready for review and merge.

I have added the required documentation to the Javadoc as well as the README.
Regarding the pom change for the logging, could you make a separate PR to this repo only (since it's not too related with this feature). I've omitted the logging argument from the docs because we won't need it even when running as a JAR once it's in the POM right?
If the doc changes are OK, the PR can be ready for review and merge.

Hi bryan ,in jar based deployment we will have to yet specify the system property -Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.Log4j2LogDelegateFactory  in cmd line. The changes in the pom here, https://github.com/ThorodanBrom/iudx-aaa-server-1/pull/2  will be including that system property while deploying using mvn exec only.

Added the PR https://github.com/datakaveri/iudx-aaa-server/pull/110, Regarding the pom change for the logging.

Hello Abhilash, I've added the suggestions. We'll need to see if it's possible to force the server to use log4j2 always, since it's how we want the logs to be formatted. It would be one less thing to worry about when deploying, and I do not think it is something we need to keep customizable (correct me if I'm wrong here).
I've kept the note about zookeeper quite brief for now. I think that going forward we may need to add details on why zookeeper or hazelcast is used and maybe why running in clustered mode is advantageous etc. This ideally should be part of our developer docs since it's common for all IUDX services. The README here can then link to the devdocs for an overview of clustered Vert.x + zookeeper/hazelcast

So the java system property makes the vertx internal components to use log4j2 as backend. There is not customizing of log format , you can customise the log level and auth url using env variables


Resume Error Tracking

Sentry was either disabled or minimised, return it to better use and track error in PR from #727

@Velua as this pr is merged, I assume that the auto close feature has failed us once again. Closing manually now, please reopen if it was meant to be open.
Also reference added to the EPIC Sentry Issue #999


Set grid with only y

If set grid [10, 10] at draggable, it works fine.
But when set grid [0, 10], it works weird.
https://codesandbox.io/s/react-draggable-grid-y-bug-muj09

grid values don't make sense at 0 and should probably error when you set them to 0. Try [1, 10].


Fix dupe versions

fix duplicate versions and adjust legal reason logic in cte

bcgov/range-web#791


VS Code_Bundle and SQL Based_Parameterization_Debugging Failing.

Describe the Bug with repro steps
For Bundle Based:
1.Create a project in Bundle based and stateful workflow.
2.Open the Designer, Add HTTP trigger , Azure function, Office (send an email), Service Bus (Send message) and response (In response add parameters token).
2.Add new file as parameters.json.
3.Edit the connection.json value with parameters from parameters.json
4.Saving the Workflow : After saving the workflow the parameters.json file is automatically empty.

Actual : The debug should be work fine without any error.
For SQL Based:
Scenario 1:
1.Create a project in Bundle based and stateful workflow.
2.Open the designer and add http trigger and azure function.
3.Add response (In response add parameters token).
4.Add new file as parameters.json.
5.Edit the connection.json value with parameters from parameters.json
6.Save and debug the workflow : Debugging and running is working fine.
Scenario 2:
1.Repeat steps of scenario first and add Office (send an email) action.
2.Save and debug the workflow : Debugging and running is working fine.
Scenario3.
1.Repeat steps of scenario 1 and scenario 2 and add Service Bus (send message) action.
2.Save and debug the workflow : Debugging is fine but getting an error in running time.

Workflow JSON
No response
Screenshots or Videos
No response
Browser
VS Code
Additional context
Actual: The workflow is not running fine.
Expected : After editing the connection.json file the workflow should be running fine.

@ccastrotrejo Issue fixed. Not reproducible in the latest vsix (2.0.26).


Fix this esp not show when ur on a car or a player on a car

Fix this esp not show when ur on a car or a player on a car

Fic it yourself blackie


images with clipsToBounds getting undone when paged off screen.

So I have several pages in the MXSegmentedPager all with many images loaded in cells in tableViewControllers. When they first load, clipsToBounds is properly enabled and things look fine. As soon though as a page is past the one immediately left or right of the visible one, it seems this is set to false and I can't figure out how to turn it back on at the cell level. The cells don't need to be reconfigured so they never call their configure UI methods. Is there a method that shows when a page in the pageController has just become visible, like viewWillAppear or something similar?

Hi, I'm not sure to understand your issue. As it hasnt been followed for a while, I will close it.
Please dont hesitate to reopen if you are still struggling.


1.x check code coverage

incremental progress toward #262

blocked on #264

this is causing breakage in unit tests for some reason. Needs to be decomposed to find root cause


Support xid types in postgres

Hello there!
I am using watermill in my project with the SQL It creates a set of tables where the different elements publish and subscribe for events.
Watermill can create the tables for you but I prefer to have all the database changes centralized using the same tool.
One of the types that watermill uses is xid8. I've tried
type = sql("xid8")

Is it possible to create a table with this type? Do I have to wait for this type to be supported?
Thanks in advance!

Hey, @enrique-fernandez-polo
As mentioned in https://github.com/ariga/atlas/issues/2769, there is no special handling for each external/user-defined type. You should use sql(…) for any type that is not supported by the HCL syntax.

Hello!
Then I guess the error Error: create table "watermill_deployments": postgres: unsupported type: "xid8" Comes from the postgres instance not atlas?

I am confused with this issue. I get the error generating the migrations if use hcl syntax and sql syntaxt but If I connect to the database I can execute the SQL query to create the table.
table "test" {
  column "transaction_id" {
    type = sql("xid8")
  }
}

create table "test"
(
  transaction_id xid8 not null
)

If I execute the create table in the database I do not get any error.


Conv2D operator with SAME padding when Stride > kernel size showing unexpected results

System information

Have I written custom code -- YES, only to demonstrate the problem (source code is below):
OS Platform and Distribution (Linux Ubuntu 16.04):
TensorFlow installed from (binary (PIP)):
TensorFlow version (1.4.0):
Python version (2.7.12):
Bazel version (N/A):
GCC/Compiler version (N/A):
CUDA/cuDNN version (N/A):
GPU model and memory (N/A -- CPU only):
Exact command to reproduce (See Source Code Below):

Describe the problem
There is an inconsistency between the convolution documentation on padding with 'SAME' located here and the behavior of the tf.nn.conv2d operator. In the example below I create a 3x1 input with values [[1.0][1.1][1.2]] and a 1x1 filter of value [1.0]. I specify the stride to be 1x3x1x1 which should result in only a single element be output and the padding to be 'SAME'. From the padding calculation in the above link:
pad_along_height:
in_height ( = 3) % strides[1]( = 3) == 0 so
pad_along_height = max(filter_height ( = 1) - strides[1] ( = 3), 0)
pad_along_height = max(-2, 0) = 0

pad along_width:
in_width ( = 1) % strides[2] ( = 1) == 0 so
pad_along_width = max(filter_width( = 1) - strides[2] ( = 1), 0
pad_along_width = max(0,0) = 0

My hypothesis is that pad_along_* is not using the max(x,0) and as a result, pad_along_height = -2. Therefore pad_top = -1 and pad_bottom = -1. If that was the case, then our input is reduced to only the middle element [1.1] which explains why the TF result of the code below is 1.1 rather than the expected 1.0 (value of first input).
If I change the padding to be VALID (no padding) then this code below gives the result of 1.0 or if i instead change the stride to 1,2,1,1 i get the expected value of 1.0 (although in this case my hypothesis proposes that pad_bottom is still -1).
Source code / logs
import tensorflow as tf
import numpy as np

i = tf.constant((np.ones(3) + np.arange(3) * 0.1).reshape(1,3,1,1), dtype=tf.float32, name='input')
f = tf.constant(np.ones(1).reshape(1,1,1,1), dtype=tf.float32, name='filter')

conv = tf.nn.conv2d(input=i, filter=f, strides=(1,3,1,1), padding='SAME')

with tf.Session() as sess:
    out = sess.run(conv)
    print out

Output:
[[[[ 1.10000002]]]]

I believe that max(0, pad) works well, see:
https://github.com/tensorflow/tensorflow/blob/69620e12bf3403a11a47b26006ebb22656a9f036/tensorflow/core/framework/common_shape_fns.cc#L42-L44
And I find the stride information isn't packed into args in LaunchDeepConvOp, perhaps the problem is here but I am still not sure about it:
https://github.com/tensorflow/tensorflow/blob/69620e12bf3403a11a47b26006ebb22656a9f036/tensorflow/core/kernels/conv_ops.cc#L158-L169

This only occurs on the CPU, not the GPU. The fact the CPU and GPU results differ is a serious issue.
/CC @yzhwang @rmlarsen

@Oewyn Thanks for reporting the issue.
I believe the issue is due to code here:
https://bitbucket.org/eigen/eigen/src/b6e6d0cf6a77518580b5c7070beda7101118067c/unsupported/Eigen/CXX11/src/Tensor/TensorImagePatch.h?at=default&fileviewer=file-view-default#TensorImagePatch.h-266
And you are right on how to fix this too. We have noticed this internally too and have fixed the internal Eigen by adding the max(0, x), but since the OSS TensorFlow depends on the OSS Eigen which is hosted on bitbucket, I haven't yet create a pull request to make my change there. I will try to do so today.

@yzhwang @gunan I created a PR #16705 to update the Eigen library to 2355b229ea4c. Please take a look.

Thanks @gunan and @yongtang !


Arm datadog release

release for issue: https://github.com/Azure/sdk-release-request/issues/1603

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer override


Update @actions/core dependency to >=1.10.0 to avoid deprecation warning

In a GitHub action where I use cypress-io/github-action@v4, I'm seeing this warning:
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I think this would be addressed by upgrading @actions/core in package.json.
There is one usage of the setOutput method in the codebase, here.

The warning says "The set-output command is deprecated and will be disabled soon." which makes it sound urgent, however the text in the link https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ quotes the date of June 1, 2023:
"October 11, 2022
To avoid untrusted logged data to use set-state and set-output workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output.
Starting today runner version 2.298.2 will begin to warn you if you use the save-state or set-output commands via stdout. We are monitoring telemetry for the usage of these commands and plan to fully disable them on 31st May 2023. Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error."
Nevertheless it would be good to have cypress-io/github-action updated soon to avoid the warning appearing.

is this fixed or still wip?

is this fixed or still wip?

there are no pull requests addressing the issue currently
the package.json version of @actions/core has not been updated either
https://github.com/cypress-io/github-action/blob/master/package.json#L35

Possible fix in #621

@MikeMcC399 Seems like I did not know that I also need to rebuild dist files. Fix is in #638

@MikeMcC399 I used piotrekkr/github-action@update-dist-files and I didn't get any warnings in GitHub from cypress action

@piotrekkr

Thanks for the follow-on PR #638!
I checked again using the merged version and everything is fine with uses: cypress-io/github-action@v4! No more warning message.


Upgrade pants from 2.14 to 2.15

Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:

pantsbuild milestone (which includes PRs since #5713)
https://github.com/StackStorm/st2/labels/pantsbuild label (which also includes preparatory PRs that came before adding pantsbuild)

Overview of this PR
This updates to pants to 2.15.0rc4 which requires:

regen the pants-plugins lockfile
several changes to our fmt and lint plugins in pants-plugins.

The required plugin updates are described in the pants Plugin upgrade guide.
As soon as the pants 2.16.0rc0 comes out, I will be switching to that one as we need some of the features in 2.16 like the new stevedore backend, and improvements to exporting virtualenvs based on lockfiles. That does not look like it will require extensive plugin upgrades like the 2.15 upgrade does.
The Fmt/Lint plugin API changed in pants 2.15
It now requires a Subsystem with a SkipOption. I took advantage of this to consolidate the constants and all the address and pex request definitions in the Subsystem subclass.
It now requires 2 rules instead of 1: to partition, then fmt/lint. That means the structure of the rule requests had to change slightly. The tests also had to account for the modified rules.
Refer to the Plugin upgrade guide for more details.

Aargh. Something isn't working in my update. Tests pass, but actually running the linters gets caught in some weird loop.


[docs] Fix import of StreamSink

Changes
Fixes #1755
Checklist

[x] An issue to be fixed by this PR is listed above.
[inapplicable] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
[x] ./frb_internal precommit --mode slow (or fast) is run (it runs code generator, does auto formatting, etc).
[x] If this PR adds/changes features, documentations (in the ./website folder) are updated.
[ ] CI is passing. Please refer to this page to see how to solve a failed CI.

@all-contributors please add @Dampfwalze for doc