benchmark script for simple_gla vs mamba2 kernel

Follow-up https://github.com/sustcsonglin/flash-linear-attention/pull/49
Amazingly, it seems like chunk_simple_gla is much faster than mamba_chunk_scan_combined:
$ python ./benchmark_simple_gla_vs_mamba2.py

Performance:
         T  chunk_simple_gla  mamba2_ssd
0     64.0          0.084992    0.840208
1    128.0          0.100352    0.847920
2    256.0          0.100368    0.848896
3    512.0          0.174080    0.873472
4   1024.0          0.399360    0.880208
5   2048.0          0.776352    1.596416
6   4096.0          1.526784    3.160064
7   8192.0          3.067904    6.251520
8  16384.0          6.220800   12.452864

I left many TODO and NOTE in the benchmark scripts, including:

[ ] Testing more input shapes
[ ] Tuning block size
[ ] analyze impact of input memory layout

More importantly:

[ ] more detailed profiling to understand why exactly it is faster.

Maybe mamba-2 kernel incurs more memory IO (less "fused")? And why the short-sequence performance (T<256) differs by so much?

@learning-chip Great job! Appreciate your quick actions.

@learning-chip  Mamba2’s official kernel involves three main steps: 1) computation of each chunk’s last hidden state, 2) recurrence at the chunk level, and 3) output computation.
For steps 1) and 2), it stores/loads the hidden state in FP32, which incurs significant I/O costs.
FLA’s implementation fuses steps 1) and 2), avoids materializing the FP32 hidden state after step 1) and stores only the BF16 hidden state after 2), thus reducing I/O costs.


open configuration files on macOS has random results

On macOS, the command open ....conf is not safe, because it depends on installed softwares.
It should be forced to open textedit.app

the answer is here:
https://apple.stackexchange.com/questions/25844/can-i-open-files-in-textedit-from-the-terminal-in-mac-os-x?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa


Add dummy data to placeholders

As it stands since they have no AC, HP or initiative, it is not possible to modify a placeholder monsters' hp or keep track of it's initiative in the "run encounters" section. If dummy values were added (0 10 whatever), those could be modified when running the encounter to fit the needs.
https://github.com/Asmor/5e-monsters/blob/7bad71abb15f59f0b69efb88676979b6278fa1ad/scripts/data/monsters.js#L12-L45

This is now resolved!


Update scalability tests to gather kruize metrics

Update scalability tests to gather kruize metrics

@kusumachalasani - As discussed, I see the below messages from the metrics script, please comment out if not required.
Unable to use a TTY - input is not a terminal or the right kind of file
Unable to use a TTY - input is not a terminal or the right kind of file
RUNNING THE JOB TO COLLECT KRUIZE INCREASE METRICS..


Should we change #trigger to be #al_trigger

Or "alkiln_trigger" or "kiln_trigger". That might future-proof it against other developments in docassemble.
E.g.
  post: |

Context: It's complex to explain, but sometimes we need the developer to include an element on the page that stores the page's "trigger" variable. See #452 about when that value is relevant. See #256 for more about how we found we need it.

My current conclusion is that we keep it as is. This is meant to be used by non-Assembly Line projects too, so "al_trigger" would be confusing for projects not using Assembly Line.


[Add New] : Toss Winner

Is your feature request related to a problem? Please describe.

Heads or Tail winner.
In this game Computer and User  will be played.

Describe the solution you'd like

In this game User can Random selection of the Head or Tails.
In this project more exiting...
please assign me... :rocket:

@Sulagna-Dutta-Roy , This is level3 issue .

As per the guidelines:
Level1: Entry Level Projects
Level2: Intermediate
Level3: Advanced
Even though I checked it's a very simple project so I added level 1. Considering it to level 2. Thanks @sivaprasath2004


Incompatible with Adafruit Huzzah ESP8266 board

There was a regression that broke building for the Huzzah ESP8266 board, around commit 2e2a87da308c88ae1a68184074627adef6b0724a
FireThing.cpp 'D1' was not declared in this scope
If you have this board, checkout the repo and then cherry-pick the fingerprint commit:
git checkout 7226a6b7dd9dbb5ea7c08c3b2d86f1d104b91fad
git cherry-pick 058744e21184e84c791536e296c57a6ca1e40373

Then it will compile successfully.

weird that travis didn't catch this. We should split the firethings/modem project from the rest of the library to avoid having them bleed on each other.


feat: include models for pageview engagement

This includes models to support engagement dropoff analyses and page view completeness, i.e. how many learners viewed all pages in a section or subsection.
fact_navigation_dropoff is a model with two different aggregation levels: total views are counted for each section and subsection.
fact_navigation_completion counts the number of pages in each section and subsection and joins that to data about page visits. Aggregations can use the page_count column to compare against the number of unique pages a learner has visited. If the numbers are equal, then the learner has visited every page in the section.
Here is an example query of how fact_navigation_completeness can answer the question "which learners viewed all pages in a subsection?":
SELECT
    subsection_with_name,
    actor_id,
    page_count,
    countDistinct(block_id) AS pages_visited,
    page_count = pages_visited AS visited_all_pages
FROM reporting.fact_navigation_completion
GROUP BY subsection_with_name, actor_id, page_count
HAVING visited_all_pages = 1

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@SoryRawyer 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Generating max_num_tokens.csv for Different Hardware Environments

In the part of the experimental model for finding the optimal placement strategy, there are three files in the simdistserve/estimators/profile_data directory, one of which is named max_num_tokens.csv. I am very curious about how this file is generated in different environments, because the other two JSON files can be generated based on the code in evaluation/0-test-single-forward-performance. However, I have not found a method for generating this CSV file. Based on my understanding, this file should be associated with different hardware or GPU environments, and the profiles in different environments should be different. I am eagerly awaiting your response. Thank you very much!

I met the same problem.


Support for robots and scenes

Like the title says. This adds support for scenes which because a binary_switch basically (can only be turned on) and robots which are binary_sensors. The robot functionality doesn't seem to work in Home-Assistant because the "on" state doesn't get sent back from pubnub, only the off state. This means the sensors never turn on. I think this may be a bug on Wink's side, so it is worth adding to python-wink just in case it starts working.
Unfortunately neither of these come back with the standard devices, which means the API fetching logic needed changed a bit to grab them.
Also added the ability to pull back the current color_model from light_bulbs. This will allow me to fix a bug in Home-Assistant where Color bulbs will display as whatever color they were last even if they are set to temperature mode.

Coverage decreased (-0.3%) to 93.89% when pulling fbc4945ec20d0e84bc0c10cc124ff1c4518f404a on w1ll1am23:robots_and_scenes into 8dd90ed249decb3eb71641c4d6d9ecb0bf638ced on python-wink:master.

Coverage decreased (-0.3%) to 93.89% when pulling 3399751faf5aef1d4fe54f3c21765c9277c25213 on w1ll1am23:robots_and_scenes into 8dd90ed249decb3eb71641c4d6d9ecb0bf638ced on python-wink:master.

Coverage decreased (-0.3%) to 93.89% when pulling 4ad77ce22fb452711ab7f30174c65c47c2cdbea9 on w1ll1am23:robots_and_scenes into 8dd90ed249decb3eb71641c4d6d9ecb0bf638ced on python-wink:master.


release 5.1.0 shows 5.0.3 in manifest.json

I found that the plugin would not update past 5.0.3.  It looks like manifest.json in the 5.1.0 release still has the version set as 5.0.3.  I think this will keep Obsidian from seeing the current release as an update to existing installations of 5.0.3.

Wow, can't believe 5.1.0 being such an important bug-fix release, and nobody complained about being unable to use it so far!


how to get the 60+29 shape_coef and exp_coef datasets

how to get the 60+29 shape_coef and exp_coef datasets, if change to 60+29 model, the reconstruction 3d face can close the eye?

Whether eyes closed depends mostly on the training data, then the expression dim.


Remove PassMark.DiskCheckup 3.5.1006.0 to PassmarkSoftware.DiskCheckup 3.5.1006.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Resolve #192350

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest

Microsoft Reviewers: Open in CodeFlow

URL: https://www.passmark.com/downloads/diskcheckup.exe
OK
(Automated message - build 923)

URL: https://www.passmark.com/downloads/diskcheckup.exe
OK
(Automated message - build 923)

#192373


yyyy only form

When I set the format to 'yyyy' I get the following error:
ERROR TypeError: Cannot read property '0' of null
at UtilService.push.../../node_modules/angular-mydatepicker/fesm5/angular-mydatepicker.js.UtilService.getDateValue (angular-mydatepicker.js:218)
at UtilService.push.../../node_modules/angular-mydatepicker/fesm5/angular-mydatepicker.js.UtilService.isDateValid (angular-mydatepicker.js:146)
at AngularMyDatePickerDirective.push.../../node_modules/angular-mydatepicker/fesm5/angular-mydatepicker.js.AngularMyDatePickerDirective.writeValue (angular-mydatepicker.js:2617)
at setUpControl (forms.js:2057)
at<EMAIL_ADDRESS>(forms.js:5281)
at<EMAIL_ADDRESS>(forms.js:5882)
at<EMAIL_ADDRESS>(forms.js:5803)
at checkAndUpdateDirectiveInline (core.js:22085)
at checkAndUpdateNodeInline (core.js:23353)
at checkAndUpdateNode (core.js:23315)

There must be also d and m letters in the date format string.

Right, but if we want to use this as a Date of Birth collection, in some countries you can only collect year.
'yyyy' is a valid date format as is 'mm yyyy' is also common for DOB.

That is good point :-) I will investigate this next weekend and check how easy is change current functionality.

@kekeh
Also in one of our project the requirement is like 17 January.
Format - d mmm.
It will be better, if we have that support in library. :)

@ShrikantAdhav  I would also need that functionality.
@kekeh Can you investigate if this is something you could easily add? I think it was already available in the previous datepicker for Angular < 7

@kekeh more specifically, in the previous datepicker I could pass as dateFormat option the value dd/mm. In this package, we end up with errors.
Stackblitz to reproduce: https://stackblitz.com/edit/angular-9-1-0-angular-mydatepicker

Now you can give more date formats to the dateFormat option. For example yyyy, mm/yyyy and mmm yyyy.
This is implemented in 0.5.6 version.


JSON formatting issues with the Shopify Github Integration

Describe the bug
When using the shopify github integration, I am getting back file urls as an escaped string. Then when running prettier, it is removing the \ from the url.
Unformatted source
shopify:\/\/shop_images\/Logo_2bb829935e.webp

Expected output
shopify:\/\/shop_images\/Logo_2bb829935e.webp

Actual output
shopify://shop_images/Logo_2bb829935e.webp

Debugging information

OS [e.g. Windows, Mac, Linux]
Version [e.g. 0.1.0]

Additional context
Here is my prettier config:
//.prettierrc.json
{
  "printWidth": 120,
  "singleQuote": true,
  "overrides": [
    {
      "files": "*.liquid",
      "options": {
        "singleQuote": false
      }
    }
  ],
  "plugins": ["@shopify/prettier-plugin-liquid", "prettier-plugin-tailwindcss"]
}

Closing as duplicate

Hey @charlespwd , so it's completely fine to let prettier format the json file (unescaping forward dashes) when working with local themes, right?

Wish this wasn't closed. Had the same issue, took a while to find this because it wasn't listed as an open issue.
Even if Shopify has an internal issue to track this, it's helpful to keep it open for the general public to track until it is fixed.

Fair!


Issue when pressing enter key to apply suggestion.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.75.0
OS Version: macOS 13.0

Steps to Reproduce:

After pressing enter key on a suggestion, the editor breaks to the new line and does not apply the suggested word.

What value does your editor.acceptSuggestionOnEnter setting have?

/duplicate of https://github.com/microsoft/vscode/issues/173387#issuecomment-1421048871

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


can improvize the marque effect of the top  sentence

I am willing to change the marque effect of the below sentence , with different fonts, design,effects

Kindly assign the work to me @GVishnudhasan under gssoc'24 extd label

Will I recieve points
On Fri, 11 Oct, 2024, 11:36 pm Vishnudhasan Govindarajan, <
@.***> wrote:

Closed #62 https://github.com/GVishnudhasan/NoDueProject/issues/62 as
completed via #77 https://github.com/GVishnudhasan/NoDueProject/pull/77.
—
Reply to this email directly, view it on GitHub
https://github.com/GVishnudhasan/NoDueProject/issues/62#event-14612639415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEPVYDN2RV2UA3VX373LQH3Z3AHQZAVCNFSM6AAAAABPUANHU6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGYYTENRTHE2DCNI
.
You are receiving this because you were assigned.Message ID:
@.***>


Does php-grpc support retries?

I could not find any documentation on how to leverage the rpc retry functionality.
Is this supported?
Thank you.

Hi,
sorry for missing this ticket earlier. This is server library, as far as you client support retries you can use them.

You can read how to write clients here https://spiral.dev/docs/grpc-client
Retry is not part of default GRPC package but you can easily write it by yourself.


[General, not an issue actually] Wondering how prompt engineering is done

Hi!
Thanks for this wonderful work! I'm trying to build a website as well and know little about HTML or JS. I'm wondering if you have used any prompt or pre-request like 'use HTML or JS' when you use GPT-4 to generate codes? Also, do you need to specify variables' names or it can generate variable names that are readable for you automatically?
I know this is more of curiosity than an issue. My apology if this thread doesn't fit the issue category here.
Thank you again!
Best regards,

I asked it to generate an HTML page for the requested physical simulation but did not specify JS (just because I didn't have any prior knowledge of web development). I didn't specify variable names. All the prompts are written in Chinese. GPT-4 understood my requests and created the corresponding variables automatically.
I added an example of the prompt for the XY model in the repo.

I asked it to generate an HTML page for the requested physical simulation but did not specify JS (just because I didn't have any prior knowledge of web development). I didn't specify variable names. All the prompts are written in Chinese. GPT-4 understood my requests and created the corresponding variables automatically.
I added an example of the prompt for the XY model in the repo.

Thank you very much! Would you mind if I leave this issue open for a while, since I'm going to play with the process recently?
Thank you again for your time!


pyo3-build-config: Add python3-dll-a crate support

Automatically generate python3.dll import libraries
for Windows compile targets in the build script.
Adds a new PyO3 crate feature auto-abi3-import-lib enabling
automatic import library generation.
Closes #2231
WIP: The documentation is still a TODO

Last thing that would be nice to see IMO would be a check for this in CI. I think it could probably be done similarly to the other cross compilation check -

I'll try to figure out how to do it, but it'll probably take some time. I've only used GitLab CI before, and GitHub Actions are a complete mystery to me. Everybody just calls somebody else's actions, and those actions call somebody else's actions, and it's difficult for me to figure out where the resulting shell commands even come from...

I think it'll be something like this:
      - name: Test windows python3-dll-a cross compilation
        if: ${{ matrix.platform.os == 'ubuntu-latest' && matrix.python-version == '3.9' }}
        uses: messense/maturin-action@v1
        with:
          target: x86_64-pc-windows-msvc
          args: --release -i python3.9 --no-sdist -m examples/maturin-starter/Cargo.toml --cargo-extra-args="--features=pyo3/generate-abi3-import-lib"

(might need env: PYO3_NO_PYTHON too? Not sure if maturin will set it.)

That's the issue with using maturin: it has its own cross-compilation logic and abi3 bindings handling logic, which get special treatment. It used to set PYO3_NO_PYTHON and alter RUSTFLAGS accordingly, but apparently it does not do that anymore after https://github.com/PyO3/maturin/pull/851 was merged.
I'd rather start with plain cargo build --target ... and proceed from there, if that's possible.

I'd rather start with plain cargo build --target ... and proceed from there, if that's possible.

While I understand aiming for simplicity to be able to follow things and understand errors, I also think that a CI job should be as close as possible to what actual usage will look like. Which I expect to go through Maturin most of the time (definitely, in the case where I would like to use this: building Windows wheels using MinGW in GitLab CI which I currently do by checking in the import libraries into source control). Or putting it differently, if Maturin's abi3 handling logic interferes with using this features, this might become a problem for the intended use cases which a Maturin-based CI job would only surface early (which seems a good thing to me).

cc @messense - I'd be interested in your opinion on how we might be able to test this (if you get a chance to see this considering the situation in Shanghai, no worries if you are unable to comment atm)

While I understand aiming for simplicity to be able to follow things and understand errors, I also think that a CI job should be as close as possible to what actual usage will look like. Which I expect to go through Maturin most of the time (definitely, in the case where I would like to use this: building Windows wheels using MinGW in GitLab CI which I currently do by checking in the import libraries into source control).

Well, in my tests both cargo build and maturin build commands work (for the current version of maturin =0.12.12). I wouldn't submit this if they didn't. But, maturin's cross-compilation approach changes from version to version, and it is currently in the process of eliminating its internal PYO3_NO_PYTHON use, which will hopefully simplify things a lot.

Definitely, in the case where I would like to use this: building Windows wheels using MinGW in GitLab CI which I currently do by checking in the import libraries into source control).

This is my main use case as well, and this works with just maturin build --target x86_64-pc-windows-gnu.
My original point was that, preferably, both commands should be tested, because I've encountered the situations where one of them works and the other one doesn't, like https://github.com/PyO3/maturin/issues/824#issuecomment-1066784006. Solving issues like that is hard when no additional information is available.

My original point was that, preferably, both commands should be tested

This certainly sounds like a good idea if even more work to implement.

I'll try to figure out how to do it, but it'll probably take some time. I've only used GitLab CI before, and GitHub Actions are a complete mystery to me.

I can work on adding tests to CI by pushing to your branch once this PR is rebased.

I'll try to figure out how to do it, but it'll probably take some time. I've only used GitLab CI before, and GitHub Actions are a complete mystery to me.

I can work on adding tests to CI by pushing to your branch once this PR is rebased.

I've rebased the PR branch on the current main. This would be a huge help, thanks!
Cross and native compilation to *-pc-windows-gnu targets should work out of the box, and cross-compilation to *-pc-windows-msvc I've only tested with rust-lld as the linker. I don't know how to run link.exe on Linux.
*-msvc targets also need LLVM binutils for llvm-dlltool and the MSVC runtime import libraries to link, as usual.
I don't use the native MSVC toolchain myself, so I can't help much here.


Enable enableProguardInReleaseBuilds in build.gradle

From @ansarizafar on September 21, 2016 13:7
It seems that current build setup for android  is not using Proguard. Please enableProguardInReleaseBuilds for release build to shrink the size of APK.
Copied from original issue: NativeScript/NativeScript#2782

Hi @ansarizafar,
We have provided an <app_name>/app/App_Resources/Android/app.gradle file, for the purpose of changing the native configuration of a NativeScript project. You can enable proguard just as described in the official documentation, but there is a reason we haven't enabled it by default:

Most of the optimizations of proguard come from the fact it excludes classes, it sees as unnecessary and renames methods and classes.
Because of the nature of NativeScript, currently we need to call and create classes and call methods at runtime, and to do that we use their full qualified names. There is a way to customize proguard to keep certain classes (look under Customize which code to keep in the docs)

Having said that, I managed to make a working example of the hello world application and the final results were:

no proguard / debug (13.1 mb)
with proguard enabled / debug (12.7 mb)

This result is understandable, because nativescript doesn't contain a lot of java code to begin with.

I'm closing this issue, because anyone that wants to use proGuard can do it. The configuration possibilities are in place.

Warning: Exception while processing task java.io.FileNotFoundException: D:\sourc
ecode\fc\NativeScript\platforms\android\build\intermediates\proguard-rules\F0F
1F2F3F4F5F6F7F8F9F10F11F12F13F14F15\release\aapt_rules.txt (The system cannot fi
nd the path specified)
:transformClassesAndResourcesWithProguardForF0F1F2F3F4F5F6F7F8F9F10F11F12F13F14F
15Release FAILED
FAILURE: Build failed with an exception.

How to resolve the issues by using proguard in nativescript


Added Bicol University (bicol-u)

Will be adding more information about request in the comments to this pull.

Official Website URL: https://bicol-u.edu.ph/
College of Science Programs offered (Includes Information Technology and Computer Science): https://bicol-u.edu.ph/category/college-of-science-news-and-events/

@gavin-cii First stage of verification passed, official domain is bicol-u.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@gavin-cii Pull request merged. Thank you.


Monetize.js and Dropbox signin failed in Firefox Marketplace version

New windows open for authentification.
But they remain blank once login done and nothing happen too in stackedit one until timeout
Firefox Aurora 35.0a2 (2014-11-04)

Closing as too old.


fix(rule): fix false-positive result

Completely rewrite sentence parser https://github.com/azu/sentence-splitter/releases/tag/3.0.0
fix #2

It include potential BREAKING CHANGE.
We put it as major version. :shipit:


player.log file shared as requested

Player.log

Pretty hard without a context. Can you please explain what happened?

Well, don’t use umm 0.27.12. Check all warnings about it on Reddit, nexus and install page here on wiki.


[Doc Guidelines] Requirements to build your application

Describe the Issue
Warren to provide a structure and guidelines for the Requirements to build your application Technical documentation
Acceptance Criteria

[ ] Provide guidelines and/or a list of items to structure that document.

https://github.com/bcgov/public-cloud-techdocs/pull/13


feat(deps): update action from node16 to node20

BREAKING CHANGE:

Closes #968

This PR migrates the Cypress JavaScript GitHub Action cypress-io/github-action to run under node20 instead of under node16. This is a BREAKING CHANGE.
Strategy
node20 is provided as an option in GitHub runners through release v2.308.0 from August 14, 2023. The release notes say:

Actions Runner follows a progressive release policy, so the latest release might not be available to your enterprise, organization, or repository yet.

In practice this means that GitHub-hosted runners pick up the new version within a few days whilst GitHub self-hosted runners may take longer. The GitHub documentation runs.using has yet to be updated to list node20 as an option (status Aug 16, 2023).
Changes made to migrate to node20 are kept to the minimum to reduce migration risks. Related updates, such as migrating npm package-lock.json files from lockfileVersion 2 to 3 are deferred.
Initially, the documentation for cypress-io/github-action will continue to recommend using v5 whilst offering v6 for "early adopter" users needing node20 support.
Since Node.js 16 plans to transition into end-of-life on September 11, 2023, this may then be a convenient time to change the recommended action version from v5 to v6, updating the documentation accordingly.

This PR is feature-complete and passes all tests 🙂

I submitted PR https://github.com/cypress-io/github-action/pull/996 to flush out unpublished documentation changes and examples and I suggest that this is merged first before merging this migration PR. I will leave this PR temporarily in draft state for this reason.

I squashed the changes as I wanted to reduce the risk when merging this PR, which is out of my control. It must generate a new major version as a BREAKING CHANGE.

Looks like the action uses semantic-release, so the standard commit format for a breaking change will work.

@AtofStryker
The release process is described in the CONTRIBUTING document. There is a separate section on Merging pull requests.

Is the version to be published pulled from the changelog?

No. The content of CHANGELOG.md has no influence on which version is used for the release.

I am not too familiar with the semantic release action. Or do we need to semver a breaking change in the commit?

The commit https://github.com/cypress-io/github-action/pull/995/commits/affa1e6bef18dda4b414b996833b35a1527d7383 in this PR already includes the BREAKING CHANGE: notation:

@MikeMcC399 squashing and merging usually grabs the PR title, but I believe the commit would still be in the footer so it should work. Do we want to rebase merge to be sure or do you feel it's unnecessary?

@AtofStryker

squashing and merging usually grabs the PR title, but I believe the commit would still be in the footer so it should work. Do we want to rebase merge to be sure or do you feel it's unnecessary?

There are different options in a repo as to how squash and merge is set up and they aren't visible to me as Contributor, however when you click on Squash and Merge it shows you what the commit looks like before you execute it. To be doubly sure, just check that it has BREAKING CHANGE: in the body, but I think anyway @semantic-release/commit-analyzer will parse the attached commit correctly.
I don't think a rebase merge is necessary, although again as a Contributor I never get to personally do any commits into the master branch, so I can only comment theoretically!
Here's what it looked like in my test repo:
[11:30:32 AM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:30:32 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat(deps): update action from node16 to node20 (#11)

BREAKING CHANGE:

Update action from node16 to node20
update @types/node to 20.5.0
[11:30:32 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The release type for the commit is major
[11:30:32 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 3 commits complete: major release
[11:30:32 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:30:32 AM] [semantic-release] › ℹ  The next release version is 6.0.0

@MikeMcC399 just merged in with commit messages on. Will try to monitor the job to verify release!

@AtofStryker
Many thanks! It all went as planned! 🚀 💪🏻


Strengthen guidance on helper methods

CC: @ffmathy, @vbfox
This is intended to mitigate some of @ffMathy's concerns expressed in #71

:+1: LGTM


Is a new release planned?

I don't really understand commits and releases history but I wanted to test the Logmatic handler and it is not in v1.23.0. Will it be possible to have it?

You could either depend on dev-master or 2.0.x-dev until a release is published.

Not using monolog-bundle :/

Yes, 1.24.0 is almost ready, just a few issues left in https://github.com/Seldaek/monolog/milestone/5 - LogmaticHandler is only in master branch though so it will come out with 2.0 which is a bit further out but hopefully coming soonish too.


[🐛 BUG]: Jobs healthcheck receive invalid status

No duplicates 🥲.

[X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?
A bug happened!
Healthchecks at url like /health?plugin=http,jobs return HTTP status 200 and error in text. Expected status 500.
Version (rr --version)
rr version 2023.1.3 (build time: 2023-05-11T12:32:01+0000, go1.20.4), OS: linux, arch: amd64
How to reproduce the issue?
Simple config:
version: "3"

server:
    command: "php public/index.php"
    relay: pipes
    env:
        -   APP_RUNTIME: Baldinof\RoadRunnerBundle\Runtime\Runtime
    user: www-data
    group: www-data

rpc:
    listen: tcp://<IP_ADDRESS>:6001

status:
    address: <IP_ADDRESS>:2114

jobs:
    pool:
        allocate_timeout: 120s
        command: "php public/worker.php"
        num_workers: 3
    pipelines:
        test:
            driver: memory
            config:
                priority: 10
                prefetch: 10

GET <IP_ADDRESS>:2114/jobs with HTTP 200:
plugin: jobs: pipeline: test | priority: 10 | ready: false | queue: test | active: 0 | delayed: 0 | reserved: 0 | driver: memory | error:

GET <IP_ADDRESS>:2114/health?plugin=http,jobs with HTTP 200:
plugin: http,jobs not found

Documentation says:

The health check endpoint will return HTTP 200 if there is at least one worker ready to serve requests. If there are no workers ready to service requests, the endpoint will return HTTP 500. If there are any other errors, the endpoint will also return HTTP 500.

But actually it returns 200.
After some time i had an error, look at relevant log output
Relevant log output
{"time":"2023-05-25T12:01:08.896604907Z","level":"ERROR","msg":"plugin returned an error from the Serve","!BADKEY":"static_pool_allocate_workers: WorkerAllocate: failed to spawn a worker, possible reasons: https://roadrunner.dev/docs/known-issues-allocate-timeout/2023.x/en","id":"*jobs.Plugin"}
error: static_pool_allocate_workers: WorkerAllocate: failed to spawn a worker, possible reasons: https://roadrunner.dev/docs/known-issues-allocate-timeout/2023.x/en
plugin: *jobs.Plugin

Hey @embargo2710 👋🏻
I'm not quite sure what do you mean, because there are no status plugin in your configuration. It returns 200 if there are at least 1 worker ready to server. You have checked 2 plugins, you have a worker which can serve a request (http).

 It returns 200 if there are at least 1 worker ready to server. You have checked 2 plugins, you have a worker which can serve a request (http).

Sorry, i just missed to add status plugin config, request body was updated.
I have Jobs plugin and mayby it's not working. Look at the /jobs output: plugin: jobs: pipeline: test | priority: 10 | ready: false - ready is false. Why ready is false? There is a plugin, it has metrics/statistics. Plugin are ready or not?
/health?plugin=http,jobs tells that jobs not found, but it actually used in config and return metrics.

How do I finally know that the "Works" plugin is really healthy?
Can change the way a healthy Roadrunner is determined? Instead of "at least 1 worker is ready" to "at least 1 worker in each of the pools is ready"

I have Jobs plugin and mayby it's not working. Look at the /jobs output: plugin: jobs: pipeline: test | priority: 10 | ready: false - ready is false. Why ready is false? There is a plugin, it has metrics/statistics. Plugin are ready or not?

It's not ready because it's paused, so the memory driver is not ready to handle requests. You should resume it to start consuming. (PHP API)

/health?plugin=http,jobs tells that jobs not found, but it actually used in config and return metrics.

There is no health check for the job plugin inside the /health endpoint. So you see the reasonable message: jobs not found.
/jobs endpoint is dedicated to check the status of the drivers -> plugin: jobs: pipeline: test | priority: 10 | ready: false

How do I finally know that the "Jobs" plugin is really healthy?

There are 2 cases. First case - worker is ready. Second case - driver is ready. Since this is different from checking, let's say, http plugin where you only check for workers, for the jobs RR should check additional condition.

Can change the way a healthy Roadrunner is determined? Instead of "at least 1 worker is ready" to "at least 1 worker in each of the pools is ready"

Just send 2 requests (for each plugin you need), get responses and make a decision in your application.

Healthchecks of the worker for the jobs plugin (for the pool of workers) will be released soon.

But, if you still wanted to get the simple task in Go 😃, you may implement (basically copy-pase and write tests) for the Health/Readiness checks for the jobs plugin, here is the sample: https://github.com/roadrunner-server/http/blob/master/status.go

I am preparing with all my body and mind for development on Go and RR. Soon.

When it's ready, it'll be in a structured JSON format.

Will this strange behavior change for the better with new healthchecks?

Maybe i found another bug:
http:
    address: :8080
    fcgi:
        address: tcp://:9000
    pool:
        debug: true

My PHP app returns ok in dummy controller, but /health?plugin=http returns plugin: http, status: 503, because 0 workers are ready in debug mode

https://roadrunner.dev/docs/php-developer/2023.x/en#debug-mode

Yes, already rid. In debug mode, the http plugin is always unhealthy. It turns out that I will not be able to run it in a k8s in this mode without additional changes.

If you wanted to use k8s, you might just send the ./rr reset requests to reset the pool of worker and load new code. But, just to clarify, you created a k8s cloud, set the mode=debug, then get into the pod and changing the code on-the-fly? Or what is the reason to put the RR in the debug mode into the k8s?

Tasks can be very different. Reloading code on the fly in a cluster is one of them. This can help when investigating incidents or experimenting under load.
Obviously, the health indicator should return the actual state of health. Running in debug mode does not make the plugin or server unhealthy.

Health - the ability to process requests or tasks. The "Jobs" or "Server" plugin can do its job in debug mode.

It seems that the "at least 1 worker" logic will not change and i just have to live with it in debug mode.

Not actually. You are talking about readiness checks. RR in the debug mode is designed to

Health - the ability to process requests or tasks. The "Jobs" or "Server" plugin can do its job in debug mode.

Not really. You're talking about readiness (ready to accept a request), which is a different check, in k8s you can find both (ready+health(live): https://cloud.google.com/blog/products/containers-kubernetes/kubernetes-best-practices-setting-up-health-checks-with-readiness-and-liveness-probes).
RR in debug mode is not designed to be ready or healthy to accept a request in k8s. Debug mode is designed to have an easy way to develop under RR (have code auto-reload on request). What is the goal of putting RR in debug mode in K8S? It's not an easy way to `sh' into the pod and develop in the pod to have a live code reload.


RFC: Simplify middleware signature

This was proposed numerous times before (#784, https://github.com/happypoulp/redux-tutorial/issues/48), and I still hear about the Redux “obnoxious” middleware signature. I think the complaint comes from the fact that most middleware never uses store argument so it’s far from being clear why it’s required.
I’m not a big fan of changing things, but we have barely made any breaking changes since the release, and since we have an overhaul for store enhancers in #1702, I realized that if I was working on Redux 1.0 today, I’d keep the middleware signature simpler. I’m happy to release 4.0 alpha and keep it as next version for several months to let middleware authors catch up.
The signature I’m proposing is:
const logger = (next) => (action) => {
  // ...
}

Note that most middleware only care about the next argument so this is why it should be the first rather than store. You can then get store if you need to read the state or dispatch from the beginning of the chain—both are advanced use cases:
const thunk = (next, store) => (action) => {
  // ...
}

As a migration strategy, I suggest a compat library:
import { createStore, applyMiddleware } from 'redux'
import { wrapCompatMiddleware } from 'redux-compat'

const store = createStore(
  reducer,
  applyMiddleware(
    thunk, // new-style middleware
    wrapCompatMiddleware(logger), // middleware that hasn't been updated yet
  )
)

This will let consumers jump into 4.x right away but since they’d have to add a tiny compat package, that would put some pressure onto middleware authors to update their middleware for 4.x.
Finally, we can avoid doing this at all. However I don’t see another round of breaking changes like 4.x, so this is the only opportunity where I’m ready to do it. I’ve been telling people for months that “it’s just currying” but I can’t give a compelling reason for it other than “we just happened to choose this style”. And I do think this style is confusing to beginners, just like the original style of applying enhancers was. I think we improved it in 3.1.0, and I think we can improve this as well.
What do you think?

What would be the considerations for the long-term management of redux-compat?
Since the nature of compat libs like this is to help across versions, how would you manage this if wrapCompatMiddleware needs to behave differently for some later inter-version compatibility?
Maybe we have redux-compat-compat? :-P

What would be the considerations for the long-term management of redux-compat?
Since the nature of compat libs like this is to help across versions, how would you manage this if wrapCompatMiddleware needs to behave differently for some later inter-version compatibility?
Maybe we have redux-compat-compat? :-P

I'm unconvinced. This would inconvenience "ordinary" users for a minor gain for middleware authors.
There are far more users than middleware authors, and this only comes up when you first create a new middleware.

I know this is only a single sample but we have 5 custom middlewares of various complexity (some for analytics, some for integrating with third party plugins that hijack window, etc) and we use the store argument in 4 of them.
I like that the signature is explicit and is really only "ugly" when using arrows, IMO.

Is the only reason for the change to make it less confusing to those that are new to redux?
Personally, I think it's more confusing to have an API change that makes tutorials inconsistent.
Right now you can just google currying or memorize that middleware starts with const middleware = store => next => action => {...}. Sorting out different versions of tutorials is much more confusing.

I have played with this before (#651) too so I'm gonna share my 2 cents.
To avoid changing the signature but also allowing beginners (or people with a "personal dislike" for currying ;-)) to write simple middleware functions, you could use lodash curry (or something similar) to wrap every middleware function. (I haven't tested this now, but I remember doing it some time ago).
Sort of like:
import curry from 'lodash/curry'

// .. then

chain = middlewares.map(middleware => curry(middleware)(middlewareAPI))

(you could also check function arity (length) to wrap it or not, but I think wrapping anyways won't hurt)
Then users could keep authoring middleware with the current signature or just do
function myMiddleware (store, next, action) {
  // ..
}

Note this is practically the same as just wrapping it yourself when authoring, like:
import curry from 'lodash/curry'

function myMiddleware (store, next, action) {
  // ..
}

export default curry(myMiddleware)

On a pragmatic level, I think this change is not at all worth the requirement of migration.
On a more abstract level, the middleware signature feels consistent in the "spirit" of the library. It's just a curried function; there's nothing special or "obnoxious" about it. It may be confusing to beginners with no exposure to FP-style JS, but that's no different than people trying to learn all the popular JS libraries at once. Once thing at a time. It's up to the docs to point people in the right direction if they don't have the necessary information.

OK, seems like this is controversial so not worth it.


Error running action on self-hosted windows 11 runner

2022-12-23T12:13:53.9455463Z ##[group]Run<EMAIL_ADDRESS>2022-12-23T12:13:53.9456069Z with:
2022-12-23T12:13:53.9456472Z   set-as-default: true
2022-12-23T12:13:53.9456959Z   wsl-shell-command: bash -euo pipefail
2022-12-23T12:13:53.9457872Z   wsl-conf: [automount]
enabled = true
root = /
options = "metadata,umask=077"
[interop]
enabled = false
appendWindowsPath = false
[network]
hostname = wsl

2022-12-23T12:13:53.9458777Z   additional-packages: curl git make python3-dev python3-pip python3-venv qemu-user-static xvfb
2022-12-23T12:13:53.9459588Z   distribution: Debian
2022-12-23T12:13:53.9460210Z   use-cache: true | false
2022-12-23T12:13:53.9460875Z   update: false
2022-12-23T12:13:53.9461477Z env:
2022-12-23T12:13:53.9462049Z   FORCE_COLOR: 1
2022-12-23T12:13:53.9462450Z ##[endgroup]
2022-12-23T12:13:56.2638308Z ##[group]Verify Windows Environment
2022-12-23T12:13:57.2631640Z ##[endgroup]
2022-12-23T12:13:57.2632584Z ##[group]Install Distribution
2022-12-23T12:13:57.2636452Z [command]C:\Windows\system32\wsl.exe --set-default-version 1
2022-12-23T12:13:57.2638014Z T�h�e� �o�p�e�r�a�t�i�o�n� �c�o�m�p�l�e�t�e�d� �s�u�c�c�e�s�s�f�u�l�l�y�.�
2022-12-23T12:13:57.2638885Z �
2022-12-23T12:13:57.2639430Z �
2022-12-23T12:13:57.2670633Z �::debug::isExplicit: 1.0.0
2022-12-23T12:14:03.3153367Z [command]C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -Sta -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.FileSystem } catch { } ; if ((Get-Command -Name Expand-Archive -Module Microsoft.PowerShell.Archive -ErrorAction Ignore)) { Expand-Archive -LiteralPath 'C:\actions-runner\_work\_temp\2db4332d-3ca5-4ceb-b380-82e52b32250d' -DestinationPath 'C:\actions-runner\_work\_temp\872b8560-a398-43f1-87cf-9831bafac869' -Force } else {[System.IO.Compression.ZipFile]::ExtractToDirectory('C:\actions-runner\_work\_temp\2db4332d-3ca5-4ceb-b380-82e52b32250d', 'C:\actions-runner\_work\_temp\872b8560-a398-43f1-87cf-9831bafac869', $true) }"
2022-12-23T12:14:04.8639005Z Expand-Archive :  is not a supported archive file format. .zip is the only supported archive file format.
2022-12-23T12:14:04.8835771Z At line:1 char:210
2022-12-23T12:14:04.8871048Z + ...  Ignore)) { Expand-Archive -LiteralPath 'C:\actions-runner\_work\_tem ...
2022-12-23T12:14:04.9001852Z +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-12-23T12:14:04.9024477Z     + CategoryInfo          : InvalidArgument: (:String) [Expand-Archive], IOException
2022-12-23T12:14:04.9027686Z     + FullyQualifiedErrorId : NotSupportedArchiveFileExtension,Expand-Archive
2022-12-23T12:14:04.9028573Z
2022-12-23T12:14:04.9106813Z ##[endgroup]
2022-12-23T12:14:05.8776771Z ##[error]The process 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe' failed with exit code 1

Can you update the installed PowerShell version?
On the GitHub hosted runners there is PowerShell 7.2.7 / 7.2.8 installed.
I guess you have an older version like 5.1.
With the version on the GitHub hosted runners extracting files where the filename does not end in .zip works without problem.
On a local Windows where PowerShell 5.1 is installed I get the same error, so I guess this is a change in the Expand-Archive PowerShell cmdlet that is used to extract the archive files.
Maybe I'll add some code to rename the files that are tried to be extracted so they end in .zip and thus work with those older PowerShell versions, but as a quick work-around upgrading your PowerShell version should hopefully work.

Your are right, even if this is a Windows 11 with all updates, running $PSVersionTable from inside pwsh reports 5.1. For the sake of automation, I am now trying to find the commands to upgrade it... as I do not fancy "manul web store operations.". The more I did on what happens on Windows ecosystem I realise that instead of learning from others (linux, macos), they managed to mess everything... at least from the automation point of view.

Based on https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?WT.mc_id=THOMASMAURER-blog-thmaure&view=powershell-7.3&viewFallbackFrom=powershell-7 running winget install --id Microsoft.Powershell --source winget should upgrade it and at least reported as successful. Still version reported is the same, even after exiting the session and starting a new one. Basically it did install it but not sure where... as it did not replace the older one. I will now try a reboot...

So if I run pwsh, it starts v7, but app links from taskbar start the old v5 one. One dilemma sorted.
Now the real issue is that when I installed the self-hosted github-runner, I installed it using default options, which is to run as a service using the NT AUTHORITY\NETWORK SERVICE instead of the local user I also have on that machine.
While I do have working WSL2 installation under my username, the service account is not able to see it, and wsl reports "Windows Subsystem for Linux has no installed distributions.". Even worse, the attempt to install Ubuntu fails with:
wsl --install --distribution Ubuntu-20.04   && exit 0
Installing: Ubuntu 20.04 LTS

An error occurred during installation. Distribution Name: 'Ubuntu 20.04 LTS' Error Code: 0x803fb008

Full log at https://github.com/ansible/vscode-ansible/actions/runs/3768139630/jobs/6406318147#step:3:115
Not sure what else to try, maybe to uninstall the runner and attempt to configure it to run under my user account. At least for that one I was able to install wsl2 manually. As NT AUTHORITY\NETWORK SERVICE is a special account, if I remember well I have no chance to login as it and probably that account does not even have access to Windows GUI, so I kinda doubt I would be able to run my test suite under it.

The original issue with PowerShell 5 should now be fixed hopefully.
Could you maybe test again whether it indeed works now without PowerShell 7 available?
Don't for get for this test to remove the caches or to disable caching, or the extraction is not even tried.
Regarding the question of how to run or install a custom runner, I fear I cannot tell you much, sorry.
I never worked with self-hosted runners.


Web client 🌍

Now that we have deeplinks (see https://github.com/joreilly/Confetti/pull/1214), it would be awesome to serve a web client as well so that clicking a deeplink still displays data if the app is not installed.
Plus maybe a good showcase for Compose web and Web Assembly?
If you have any idea how to build this, please leave a reply below or join us in the #confetti channel of the KotlinLang slack (get your invite here)

Just to note here that I've been looking at building Wasm based Compose for Web client (in branch right now until all dependencies are available0

Initial version of this has now been merged


Rearrange indico sections, add registration handling for online

First commit moves the indico guide to a new file, no changes
Future commits modify that and add pages for in-person, online, hints
Of these only online has very much useful information so far.  And it may not be correct, it is a starting point
Review

Worth a read but this is a work in progress.  indico/setup.md does not need
reading, there are no changes in it.

Thanks!


Windows: make PrintScreen work

There are two "print" keys in Windows - a legacy (unused?)
PrintScreen key and the currently common PrintScreen key.
Unfortunately, KMonad uses same name for both of them
and only exposes the legacy print key. This fixes it by
renaming the legacy one as KeyPrintLegacy and exposing
it as prntl and exposing PrintScreen as prnt for
consistency across OSes.
Fixes: https://github.com/kmonad/kmonad/issues/489

What I am not sure about is whether to keep lagacy print key. Does anyone use that key? Should we remove it and add it only when a user asks for it?

@6gk @whitbur would any of you be willing to test this/offer an opinion as to how we should handle KeyPrintLegacy?

I'll test this version tomorrow (not on windows + about to go to bed), but the commit Muhammed posted in the issue I made solved my issue flawlessly (commits appear similar, but I'm half-asleep).
And I'ven't a clue about KeyPrintLegacy -- The key does nothing for me, which leads me to doubt there's any use for it in modern Windows.  Removing it shouldn't bring any harm, but same with keeping it. (I might've misunderstood you though?)

I tested this on Windows 10, validated that taking a screenshot using the PrintScreen key before did not work and that with this commit I am able to take a screenshot. Looks good to me.
On KeyPrintLegacy my opinion's the same as it was on #489. I don't see any reason to keep it around, I can't imagine anyone is using it. Personally I don't think it's worth the minor additional complexity to support it, so I would remove it from the commit. I'd still support shipping this PR as is if others do feel it's important, though.

Thanks to you two!  @MuhammedZakir I'd prefer the cleaner approach then—let's remove KeyPrintLegacy and see if anyone complains :)

@slotThe: Done.

Great, thank you!


Set Float Voltage or Output Current

Hi,
Just stumbled across this.  Been trying to create something like this for a while, but did not have the technical skills, and was trying to use standard modbus utilities.
The biggest limitations of Charge Controllers like this is once set to Li-ion, you can't set them to charge to 28.8 then float at 27.2.
Is it possible to change the Floating voltage  and possible charging amps on the device using this?  If possible, we could use HA Automation in conjunction with a smart BMS to reduce the charging voltage to float the batteries, or reduce the charging amperage.   Essentially replicating Victron DVCC functionality.

If you take a look at the communications documents that I posted, you will find that there is no command to set the parameters you are looking to change via the modbus interface. While some parameters can be set this way, it doesn't look like your use case is among them.
Perhaps try the manufacturers directly; I found them to be very responsive via email during Chinese working hours.

Thanks for the update.  I'll give them a try.  I've implemented this project into my HA, and it's working great.  Thanks for all your hard work!


Added on_training_started feature.

By default, PrintLayerInfo is added, which prints the usual layer information for non-CNN.  For CNN, if verbosity >= 2, print additional information about image coverage and capacity.  If verbosity >= 3, even more information about receptive field size and real filter size.  For more, see link to work by Xudong Cao.

Thanks!  I'd love to see some introductory documentation for this, especially maybe in the form of a notebook.  Feel free to create an examples/ directory in the root and add one there.  Would be great!


Lazy may signal an error, causing emacs to stop loading the init.el

If a directory of lazy-files-alist does not exists, when lazy try to add a watch file-notify-add-watch signals an error, which is not handled.
Adding a condition (like a when as the example bellow) avoid the problem, but it's not a good solution. Maybe there is a way to catch the signal before it's thrown to init.el?
(defun lazy--add-file-notify-watch (dirs)
  "Add DIRS to the notifications system: `filenotofy'.
Push the returned file descriptor `lazy-file-descriptors' list."
  ;; iterate over the directories list
  (dolist (dir dirs)
    ;; add only if directory exists
    (when (file-exists-p dir)
      ;; add descriptor to the `lazy-file-descriptors' list
      (push
       ;; add a file-notify watcher
       (file-notify-add-watch dir
                              '(change attribute-change)
                              'lazy--file-notify-callback)
       ;; descriptors internal list
       lazy-file-descriptors))))

Seems like a 'late time decision' problem, how about ensure the directory files exists (or create them) before the `lazy--add-file-notify-watch' call?

I don't think that ignoring the directory is a bad idea, it would add a defined behavior. The directory may be removed after the setup, as an example.
Also, the default directories does not ensure that either. Maybe it should check when defining?
(defcustom lazy-files-alist
  (list
   ;; lisp directory
   (cons "lisp-loaddefs.el"
         (expand-file-name "lisp/" user-emacs-directory))
   ;; site-lisp directory
   (cons "site-lisp-loaddefs.el"
         (expand-file-name "site-lisp/" user-emacs-directory)))

See: https://github.com/esac-io/lazy/commit/b882ea47a3805bd137051fda911c86a74b1e6ae3


What type role should NF's parameter have?

Currently, we let GHC infer
type role NF representational

I think there's a minor potential problem here. Suppose we have
data T = ...
newtype U = U T

instance NFData T where ...
instance NFData U where ... -- Something *different*

We can coerce from NF T (which is in T-normal form) to NF U (which claims to be in U-normal form). It's not quite clear to me whose problem this is. Should whoever defined U be expected to hide its constructor? Or should we have type role NF nominal?
In practice, I suspect this to come up rather rarely, since types are generally expected to have just one notion of normal form, but there could be exceptions out there.

Hey @treeowl, I added you to the repo. I think nominal is more correct, so feel free to commit this change.

@ezyang, thanks! I don't really feel strongly about it, but it seems to be the safer choice.

@ezyang, I opened up a pull request for this. I also added a function to work around the role annotation locally. For now, I put it in a separate Data.NF.Coercion module. Does that make sense to you, or should it go in Data.NF?


Add timeouts to gRPC streams

Streams should be closed after long periods of inactivity

Not needed anymore. TCP KeepAlive should be enough.


Fix booleans not being flattened

Fixes #104.
Another reason I don't love how flattening is implemented is that this was missed without warning.
Test case:
before {myBoolean, boolean, true {true} false {false}} {myVar, select, a {a} b {b}} after

Before:
{myVar, select, a {before {myBoolean, boolean, true {true} false {false}} a after} b {before {myBoolean, boolean, true {true} false {false}} b after}}

After:
{myBoolean, boolean, true {{myVar, select, a {before true a after} b {before true b after}}} false {{myVar, select, a {before false a after} b {before false b after}}}}

Just to check, what happens when we have multiple nested select/booleans?
{myVar, select,
  a {before {myBoolean, boolean,
    true {{myVar2, select,
        a {a2}
        b {b2}
        }
    }
    false {false}} a after
  }
  b {before {myBoolean, boolean, true {true} false {false}} b after}
}

With the number in the identifier removed:
{myVar, select, a {{myBoolean, boolean, true {{myVar, select, a {before a2 a after} b {before b2 a after}}} false {before false a after}}} b {{myBoolean, boolean, true {before true b after} false {before false b after}}}}


Failed to load images.

Location: https://quarx.info/docs/
Missing Images:

https://quarx.info/images/1.jpg
https://quarx.info/images/2.jpg
https://quarx.info/images/3.jpg
https://quarx.info/images/4.jpg

Thanks for the catch - all fixed now :)

@mlantz you missed the <a> tags.
Clicking on the images results in Failed to load image: https://quarx.info/images/{image_id}.jpg

blast! thanks :)


Scipy failed to import

Hello,
I've been trying to run the align_dataset_mtcnn on the dataset, and I keep getting errors like this:
Traceback (most recent call last):
File "C:/Users/Kiki/facenet/src/align/align_dataset_mtcnn.py", line 29, in
from scipy import misc
File "C:\Python36\lib\site-packages\scipy\misc_init_.py", line 53, in
from scipy.interpolate.pade import pade
File "C:\Python36\lib\site-packages\scipy\interpolate_init.py", line 176, in
from .interpolate import *
File "C:\Python36\lib\site-packages\scipy\interpolate\interpolate.py", line 20, in
import scipy.linalg
File "C:\Python36\lib\site-packages\scipy\linalg_init_.py", line 175, in
from .misc import *
File "C:\Python36\lib\site-packages\scipy\linalg\misc.py", line 5, in
from .blas import get_blas_funcs
File "C:\Python36\lib\site-packages\scipy\linalg\blas.py", line 155, in
from scipy.linalg import _fblas
ImportError: DLL load failed: The specified module could not be found.
So I checked many times and scipy is definitely installed.

Why is this closed?  _fblas is now fblas and this error is still occuring.


Use test io runtime in munit

I'm wondering if we should use the same Http4sSpec.TestIORuntime in all tests / suites.

Another flaky test:
X org.http4s.client.blaze.Http1ClientStageSuite.Not expect body if request was a HEAD request  0.017s munit.FailException: /home/runner/work/http4s/http4s/blaze-client/src/test/scala/org/http4s/client/blaze/Http1ClientStageSuite.scala:256 assertion failed
255:      // connection reusable immediately after headers read
256:      assert(tail.isRecyclable)

Different from https://github.com/http4s/http4s/issues/4151

Another flaky test:
X org.http4s.client.blaze.Http1ClientStageSuite.Not expect body if request was a HEAD request  0.017s munit.FailException: /home/runner/work/http4s/http4s/blaze-client/src/test/scala/org/http4s/client/blaze/Http1ClientStageSuite.scala:256 assertion failed
255:      // connection reusable immediately after headers read
256:      assert(tail.isRecyclable)

Different from https://github.com/http4s/http4s/issues/4151

Incorrectly autoclosed when cats-effect-3 branch was merged.

Incorrectly autoclosed when cats-effect-3 branch was merged.


Fixed mypy latest release errors

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.616%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3028

Relevant Lines:
3456

💛  - Coveralls


AD 2.0 add in manifest

Signed-off-by: Amit Singh<EMAIL_ADDRESS>Description
AD 2.0 main ref addition
Issues Resolved
Following https://github.com/opensearch-project/opensearch-build/issues/312 and https://github.com/opensearch-project/opensearch-build/pull/311
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1822 (c47b6d4) into main (b659b11) will increase coverage by 5.47%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #1822      +/-   ##
=============================================
+ Coverage     94.52%   100.00%   +5.47%
=============================================
  Files           176         6     -170
  Lines          3617       105    -3512
  Branches         27        19       -8
=============================================
- Hits           3419       105    -3314
+ Misses          194         0     -194
+ Partials          4         0       -4

Impacted Files
Coverage Δ

src/run_checkout.py

src/system/console.py

src/ci_workflow/ci_target.py

src/ci_workflow/ci_check_npm_package_version.py

src/build_workflow/builder_from_source.py

src/manifests/input_manifests.py

src/test_workflow/test_component.py

...c/test_workflow/dependency_installer_opensearch.py

src/test_workflow/integ_test/service_opensearch.py

src/manifests/manifest.py

... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b659b11...c47b6d4. Read the comment docs.


Fix wrong submatrix indexing

When j > i (0, 0) is not the current time position. For example,
> bias
tensor([[-5, -4, -3, -2, -1,  0,  1,  2,  3,  4],
        [-6, -5, -4, -3, -2, -1,  0,  1,  2,  3],
        [-7, -6, -5, -4, -3, -2, -1,  0,  1,  2],
        [-8, -7, -6, -5, -4, -3, -2, -1,  0,  1],
        [-9, -8, -7, -6, -5, -4, -3, -2, -1,  0]])

so if you crop from (0, 0) as:
> bias[:2,:3]
tensor([[-5, -4, -3],
        [-6, -5, -4]])

but this is wrong, and it should be
> bias[-2:,-3:]
tensor([[-1,  0,  1],
        [-2, -1,  0]])

@taemincho oh yes, this would matter in the transformer-xl setting! 🙏

@taemincho oh actually, i think it wouldn't matter, because the softmax is translation invariant

that's ok, let's just keep the change, less confusion haha


GatsbyJS example

Does anyone have an example showing how you use Material-UI v1-beta with GatsbyJS?

You should be able to use Material-UI with GatsbyJS like with any other React component library. Let us know if you find some interesting resource, that could potentially help others.


minibatch preprocessor improvements

This PR makes two improvements to the preprocessor code

Check for all character types for dependent col
Create temp table for standardization.

See the commit for more details

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/448/


Research using a different database engine

As the site gets more popular and records more data, I may need to switch it off SQLite to a different/proper database engine.

This is pending completion and merging at le717/vss365-today-api#1.


Allow GitCommitChecker to check subdependencies too

Normally the Swift package manager dependencies come from git repositories, so I'm planning to heavily use GitCommitChecker for checking for Swift updates.
However, GitCommitChecker is only useful for checking updates for direct dependencies, since it looks at dependency.requirements to find the git repo source, and only direct dependencies have explicit requirements.
I'm looking into refactoring this class so that it accepts a custom git source and can be potentially used for checking updates for indirect dependencies too.

I expanded this PR to add support in GitCommitChecker for checking subdependencies. We did not need so far because in other package managers, git dependencies can only be defined at the top level, otherwise they are registry dependencies. But for Swift, most times subdependencies are also git dependencies.
GitCommitChecker now looks for a git source, not only in Dependency#requirements (which are specific to top level dependencies), but also in Dependency#subdependency_metadata.


Not sure if related to this but I've noticed that isValid on formState doesn't update when using external validation schema (yup in this case) and onUpdate mode.

Not sure if related to this but I've noticed that isValid on formState doesn't update when using external validation schema (yup in this case) and onUpdate mode.
Here's a codesadbox: https://codesandbox.io/s/react-hook-form-seterror-ftvrr
This example has two fields, each required. They start off as filled in via defaultValue and the form is valid. Now try to edit the form and clear the password confirmation input. The form is still valid. If you press the TEST button the form becomes invalid.
Now if you change the mode to onChange or onBlur it works as expected, clearing the input causes the form to become invalid.
Originally posted by @bowd in https://github.com/bluebill1049/react-hook-form/issues/92#issuecomment-508660645

there is no onUpdate mode

I dont think isValid is set up correctly for validation with schema, looking into the problem.

@bowThink I have fixed the issue.
https://codesandbox.io/s/react-hook-form-seterror-wysuq

looks like this is fixed now.
https://codesandbox.io/s/react-hook-form-seterror-wysuq

fixed: there is a bug where errors not clear after submitting.

but there is no onUpdate mode
and one of your fields doesn't have the required attribute.

Sorry I made a mixup with onChange / onUpdate. Actually, I'm still having an issue. So, first of all, I did have required because I changed the example to use yup and provided a validation schema, not inline require on the register method.
But now I'm seeing some behavior that's a bit inconsistent.
Let's look at this one: https://codesandbox.io/s/react-hook-form-seterror-mo8sh.
What I want to achieve is to have two inputs and a button that only shows up when the form is actually filled and valid. In this case I have hidden the submit button behind a formState.isValid.
When the page loads you see the inputs and isValid is false. After you write in the first input isValid becomes true even if the 2nd input is empty. If you click in and out of it it gets an error but the form still has isValid = true even if there are errors shown in the console.
P.S. I updated the sandbox to the latest pulished version of the library.

thanks @bowd i think this fix the issue
https://codesandbox.io/s/react-hook-form-seterror-n2dvh
can you check?

@bluebill1049 it works in your sandbox but I don't see any difference at all from the one I shared. What did you change to make it work?

cool, it works :) I will commit my change and publish it today 👍

published<EMAIL_ADDRESS>thanks for report the issue

hey, @bowd let me know if I have fixed the issue and we can close this :)

There's still a problem. When adding defaultValue to the example above formState.isValid stays false until you actually click (touch) one of the inputs. If the form is actually valid based on all the defaultValues I think the state should reflect that. I've tried forcing a manual triggerValidation in an effect and it's still not valid until I blur an input.
https://codesandbox.io/s/react-hook-form-seterror-5b464

triggerValidation should do the the job, let me check. sorry about the bug haven't spend enough love with Yup and schema validation

No worries, I appreciate you being so responsive and on top of things 🚀. Code is always gonna break that's the nature of it, the people behind it are important.

@bowd looks like it's working: https://codesandbox.io/s/react-hook-form-seterror-rfdgd
could you please help on a quick test?

So it does work in the sense that when defaultValue is set on all fields and you do kickoff the triggerValidation manually all looks ok. But this doesn't really work well if you have a partially filled form or an empty form, because it shows all errors from the start even if you haven't touched the field, which isn't ideal. The current workaround in my case would be to only trigger the triggerValidation and what would be an "edit" form where I know I'm preloading with values that make a valid form.
In an ideal world maybe there should be a decoupling between the errors on the field level and the isValid state of the form. So that, for example, I would be able to tell that the form is not valid while still not necessarily showing any errors yet. Otherwise, I think I could use touched to only show errors on fields that have been touched. Which is actually the best approach for now, so I would say that the fix is good and we can close this :+1:

thanks a lot for your testing @bowd, I will write some unit tests and publish it tomorrow. will keep you in the loop.

@bowd fix has been merged, will test tmr morning again and release

@bowd https://github.com/bluebill1049/react-hook-form/releases/tag/v3.17.5 once you happy with it please close the issue 🙏

it's release 👍 let me know if things work out for you and we can close this issue 🙏

All is well, you can close the issue. Thanks!


Add US End Of Year Giving Tuesday Banner

What does this change?
This adds the US EOY Giving Tuesday moment banner ready for the upcoming moment, which will be  hooked up to the RRCP in this PR
Images

mobile
tablet
desktop
Wide

Looks good to me! Have we deployed this to code for design feedback yet?

Yes this had been deployed to code on Friday for feedback but am just checking in again on the design end


Update index.tsx

The change prevents the duplication of products featured on the home page.

Adds extra complexity. Resolved at agnosticbranch. Thank you!

Adds extra complexity. Resolved at agnosticbranch. Thank you!


added no guess game

Added a new card for guess the number game
issue no #102

@Priyanshi662 please review.

@Priyanshi662 please do review.

@Priyanshi662 Can you please assign this PR to me so that it can be counted  in JWoC leaderboard. Thanks


(WIP) Adding compaction to HoodieClient example

@bvaradar It's difficult to add async compaction code path using SparkLauncher since one needs a spark installation for that. For now, I've just added schedule() and compact(), another way is to start 2 threads doing ingest and compact but that's not the preferred way to use our API's so haven't added that anyways.

@n3nash : This should be good. We can merge it after the checks are green.

@bvaradar The build is failing due to OOM on jenkins. How did you fix it last time ?

@n3nash are you planning on resuming this?


Fix Checkstyle suppressions on Windows

This PR fixes a minor issue where the Unix-like path separators were used for Checkstyle suppression filter.
Due to this, the intended Checkstyle suppressions didn't work on Windows.
The Checkstyle plugin is only actually used in the time project, so the issue remained uncovered for some time.

@armiol PTAL.


Add  where necessary

Hi, this allows the software to build on Qt 5.15.0

I confirm changes by @jpcima fix the build for Qt 5.15
@laserpants I suppose the project is abandoned for some reason, but could you see the PR? Thanks in advance


DX-766 feat: add allowed admins prompt into application init flow

Summary
We add a prompt for the user to enter allowed admins (as a list of emails), to limit the ability of launching a liveview instance to these admins only.

An actual update to wukong-ci-mock's .wukong.toml showed the config reflected in ApplicationConfig on Wukong prod.

Ticket: https://mindvalley.atlassian.net/browse/DX-766
What's Changed

Prompts for allowed admins in application init flow.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add option to throw on duplicate operation name in named-operations-object

Is your feature request related to a problem? Please describe.
The named-operations-object plugin creates an object referencing all operations by name. This gives the impression that each operation is unique and only has one definition. But there might be multiple operations defined with the same name.
Describe the solution you'd like
I propose adding an option to the named-operations-object plugin that enables throwing an error when a duplicate definition is found.

Opened a PR here: https://github.com/dotansimha/graphql-code-generator-community/pull/775

Released<EMAIL_ADDRESS>


which dataset is the pretrained model pretrained from?

which dataset is the pretrained model pretrained from?
Also, is your code the implementation of any paper? If yes, what paper?
Thanks for your sharing!

Hello, thank you for your interest in this project. We will clean our training codes and datasets recently.  Our new version be released at: https://github.com/TARTRL/Deepfake_Dection
Our implementation has no related paper.
The new version of the project will be released once ready.


add validation decorators

I have started the code for more validation on the client side.
Wanted to check if it's in the right direction before spending more time on it.

I could be wrong but to me decorators are useful when one can be shared in multiple places or make the code structure less messy. If each decorator is only working for a specific function then why not just use a function instead

I could be wrong but to me decorators are useful when one can be shared in multiple places or make the code structure less messy. If each decorator is only working for a specific function then why not just use a function instead

I know it's syntax abuse and I had it as a function first. I thought it may be cleaner as it adds one line to the main function. I can rewrite it as a function.

what's the status of this pr ? is it ready to be merged yet ?

what's the status of this pr ? is it ready to be merged yet ?

Haven't gotten any chance to work on it, as there were more urgent issues. In particular, the traffic-light PR should be ready, just waiting for reviews.


Generating lots of redundant calls

My app uses the ZeroClientProvider to connect to infura and query the transaction logs; initialization logic:  https://github.com/channel/channel.github.io/blob/master/app/src/scripts/initialize.jsx#L27
The trouble I'm facing is that for each web3 LogFilter.get() request I make, the block tracker enqueues a getLogs request that never stops polling. As time goes on the amount of data being fetched grows and grows. You can see the pattern in the network tab at https://channel.github.io
My hack solution is to add self._blockTracker.stop() right after this line: https://github.com/MetaMask/provider-engine/blob/master/index.js#L37
I figure there's something off with the way requests are being queued up - not sure if this is the right place to report the issue but figured it was worth a shot.
I've attached a screenshot showing the tracker doing it's polling, and then (while the page is idle) making a bunch of getLogs requests, presumably once a new block comes in:

I just found the same thing! I have a feeling this is about to be my top priority for the coming week.
https://github.com/MetaMask/metamask-plugin/issues/1458

my guess is you refreshed your dapp many times, and it installed new filters without uninstalling them. the problem is really that the life cycle of the filters is not tied to the dapp. we've just made this change in metamask.

I'm using the ZeroClientProvider (zero.js) directly and connecting to infura for users that don't have metamask installed - the screenshot above is from my app window, not inpage.js. I'm also calling Filter.get(callback) so I don't think I need to uninstall anything, right? I thought I only need to uninstall for Filter.watch.

I believe this behavior had me incorrectly blaming the ENS-Registrar-Dapp for the polling leak, when they also only use Event.get(), no .watch():
https://github.com/ethereum/ens-registrar-dapp/issues/153
I'm not sure this is a problem with eth-block-tracker, though, this looks much more like a web3-provider-engine/subproviders/filter bug.

Here's what it looks like right now when we call Event.get:

Okay so looks like two bugs to me:

BlockTracker walking is slow and inefficient at times.
Web3's contract abstraction treats get as a subscription, and regardless of fromBlock and toBlock parameters, it is continuously requesting new logs for the filter.

Okay so part of that before was because I had the filter subprovider in the client.  Moving it out, here's the division of labor right now, when a user creates an Event object and calls get() on it (the exact order of events between client and providerEngine I haven't gotten to yet):
Client says: sendAsync  eth_newFilter [Object]
Client says: sendAsync  eth_getFilterLogs ["0x01"]
ProviderEngine returns a filter ID.
ProviderEngine calls getLogs to the RPC for that range, returns
ProviderEngine continues block walking, and on each new block, calls an updated getLogs() to the RPC for the new block with the other params.

Alright, I've tracked this down to a bug in web3.js.
Every time you create an Event object, it registers a Filter in MetaMask's provider, and never unsubscribes it.
For this reason, until this is fixed in web3, for getting some logs, I have to recommend using other methods of fetching logs.
The lowest level approach looks like this:

    web3.currentProvider.sendAsync({
      method: 'eth_getLogs',
      params: [options],
    }, callback);

Where options is a filter options object.
I think there may be a nice place for a convenience library around that method now, that only requests what you ask for.
Leaving this open for now because I want more time for us to consider if there's anything we can do at this layer to mitigate this problem.

Nice work. I remember adding a calls to Filter.stopWatching() in my code, both right after the Filter.get() call and within its callback function, but the problem didn't go away. Web3 looks like it properly deregisters if I call that method. I'm wondering if the issue might not be isolated to Web3?

It might not be. I think we are at least partially responsible for the poor performance here, but there is a bit of a perfect storm that's come together here.
Partly leaving this open because I'm suspicious there are other things at play still.

Solution to this problem described in https://github.com/MetaMask/provider-engine/issues/150, closing


Exec cmd failed silently

I'm trying to execute a onepassword cli command and it doesn't work even though exit code return 0
func main() {
	cmd := "op item create --format=json --vault=znylw5l33x7v3onqaxuaqxaaai --category=\"API Credential\" --title=test credentials=secretivepassword notes=lala "
	p := script.Exec(cmd)
	//p.Wait()
	num, err := p.Stdout()
	if err != nil {
		log.Fatal().Err(err).Msg("failed at executing")
	}
	log.Info().Int("num", int(num)).Msg("output")
}

If I add p.Wait() in there I will get error which is
{"level":"fatal","error":"io: read/write on closed pipe","time":"2022-12-05T22:23:03-08:00","message":"failed at executing"}

How can I debug or fix this?
If I copied the exact thing into my terminal, it would work correctly.

If I use the exec command, then it works properly
func main() {
	out, errout, err := Shellout("op item create --format=json --vault=znylw5l33x7v3onqaxuaqxaaai --category=\"API Credential\" --title=test credentials=secretivepassword notes=lala ")
	if err != nil {
		log.Info().Err(err)
	}
	fmt.Println("--- stdout ---")
	fmt.Println(out)
	fmt.Println("--- stderr ---")
	fmt.Println(errout)
}

const ShellToUse = "bash"

func Shellout(command string) (string, string, error) {
	var stdout bytes.Buffer
	var stderr bytes.Buffer
	cmd := exec.Command(ShellToUse, "-c", command)
	cmd.Stdout = &stdout
	cmd.Stderr = &stderr
	err := cmd.Run()
	return stdout.String(), stderr.String(), err
}

I think you're running into #148 here—clearly the program is returning some error, but we're not seeing it. Let me check back with you here once that issue is fixed, and we'll see if that sheds any light on the problem.

Could you check your program against script v0.21.4 and see if it now works as expected? (Or at least, if it doesn't, that you can see any error reported by the op command.)

@bitfield  This is very interesting. It might have something to do with onepassword cli. I tried this script version and still the same problem
package main

import (
	"github.com/bitfield/script"
	"github.com/rs/zerolog/log"
)

func main() {
	cmd := `op item create`
	p := script.Exec(cmd)
	exitCode, err := p.Stdout()
	if err != nil {
		log.Fatal().Err(err).Msg("failed at executing")
	}
	log.Info().Int("num", int(exitCode)).Msg("output")
}

Output with
{"level":"info","num":0,"time":"2022-12-07T08:42:16-08:00","message":"output"}

and If I run this with just my terminal this is what I got
❯ op item create
[ERROR] 2022/12/07 08:44:30 Provide the item category with '--category' flag

ping! @bitfield, Is there any update on this bug? Here is the minimal code to reproduce it, and the output using the op cli in the terminal vs using script package. Tried to debug it this for a while to see what's wrong but I cannot figure it out
minimal code to reproduce
package main

import (
	"github.com/bitfield/script"
	"github.com/rs/zerolog/log"
)

func main() {
	cmd := `op item create`
	p := script.Exec(cmd)
	exitCode, err := p.Match("hello").Stdout()
	if err != nil {
		log.Fatal().Err(err).Msg("failed at executing")
	}
	log.Info().Int("num", int(exitCode)).Msg("output")

}

op cli output in terminal
❯ op item create
[ERROR] 2022/12/08 09:31:09 You are not currently signed in. Please run `op signin --help` for instructions

script package output
❯ go run main.go
{"level":"info","num":0,"time":"2022-12-08T09:31:38-08:00","message":"output"}

Notes: bitfield/script exit 0 as if there is no error

I don't have anything useful for you at the moment; I can point out a couple of problems with your program, though.

The p.Match("hello") stage will automatically filter out any output lines from op that don't contain "hello". That's probably not what you want if you want to see any error message printed by the command.
The first value returned by Stdout is not the exit status, but the number of bytes successfully written to the output. You can get the exit status of the last Exec command run by the pipe with ExitStatus:

func main() {
	cmd := `op whoami`
	p := script.Exec(cmd)
	_, err := p.Stdout()
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(p.ExitStatus())
}

For me, this prints:
[ERROR] 2022/12/08 18:03:38 no account found for filter
2022/12/08 18:03:38 exit status 1
exit status 1

... which is roughly what I'd expect. I can't try op item create because it prompts me to link to an account, but I don't have one. But see what the above program produces for you when you run op item create.

@bitfield my bad on this. you don't need to do the match, and you do not need to login to reproduce it. The whole point is to not login and run this exact program and see script exit 0 instead of erroring out
package main

import (
	"github.com/bitfield/script"
	"github.com/rs/zerolog/log"
)

func main() {
	cmd := `op item create`
	exitCode, err := script.Exec(cmd).Stdout()
	if err != nil {
		log.Fatal().Err(err).Msg("failed at executing")
	}
	log.Info().Int("num", int(exitCode)).Msg("output")

}
}

{"level":"info","num":0,"time":"2022-12-08T10:11:32-08:00","message":"output"}

@bitfield script should have been erroring out like the op command did like this

❯ op item create
[ERROR] 2022/12/08 10:14:09 You are not currently signed in. Please run `op signin --help` for instructions

Yes, it looks as though the op item create command is returning zero exit status and producing no output in this case, doesn’t it? I have no idea why that would be—is the source for that tool available?
Evidently op whoami does return a non-zero status and print its error, as expected, and script handles that correctly. So if this is a bug in script itself, I’m puzzled about what it could be.

@bitfield true, true . yeah you can close this if you want. Pretty sure this is a op problem. Thank you for answering all the questions

I'll leave it open for now just in case anyone else has problems with automating op and comes here to find out why! This is something I'd raise with the OnePassword support team, since presumably their tool is meant to work correctly in this situation, but doesn't.


Add 'is_iban' validation

Added is_iban to the validation rules in the schema. This new rule ensures the validation of International Bank Account Numbers (IBAN). This will ensure data consistency and validation accuracy for international transactions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

15 of 15 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 96.776%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
2822

Relevant Lines:
2916

💛  - Coveralls


Deduplication hashcode fields configuration UI

Description
This is a first try to implement an actual UI/API to configure deduplication hash code generation.
It could enable people to play around with their duplicate matching and maybe improve things a bit more.
Sometimes it's obvious that a finding is a duplicate of another scanner, and you can tell that it's just 1 field that messes up the hash matching.
Improvements

Maybe improve the first-loading mechanism, it's a bit of a dirty trick, on the first time you load the page of dedupe configs, I load the settings.dist.py and see if they are missing, and create one for each that has been configured. It won't create one for a scanner that isn't configured specifically to use x or y fields. (but should give the user the whole list of scanners, if they'd like to set one up that was completely "default")

@Gby56  I have some bad news https://documentation.defectdojo.com/proprietary_plugins/tuner/#deduplication-settings, but I may have a solution. Would you please email me<EMAIL_ADDRESS>


Regression from 0.25.1: TypeError: url.match is not a function

Describe the bug
After update to 0.25.0 to 0.25.1 (also present in 0.25.2), the test suite complains with
TypeError: url.match is not a function
Can confirm it does not happen in 0.25.0
Setup:

happy-dom: 7.7.0 (latest)
vite: 3.2.3 (latest)
config used: https://github.com/belgattitude/nextjs-monorepo-example/blob/e3f1e4d58853538531f5d068a616b21a26088588/apps/nextjs-app/vitest.config.ts

Investigation
Haven't tried on jsdom, but with happy-dom seems the url is passed as URL object, not a string. As per MDN it should be a string.
Here an example that makes the tests passes. I modified the happy-dom URL constructor like this:

And it worked. So I guess it's related
Notes
CI log, see https://github.com/belgattitude/nextjs-monorepo-example/pull/2912

Reproduction
Sorry I don't have a minimal reprod example yet, but you'll can find a failing PR here:
https://github.com/belgattitude/nextjs-monorepo-example/pull/2912
To install
git clone https://github.com/belgattitude/nextjs-monorepo-example.git
cd nextjs-monorepo-example
git switch reprod-regression-vitest
yarn install
cd apps/nextjs-app
yarn test-unit

It's a monorepo, the app failing is based on nextjs. All deps to latest (happy-dom, vite). Can confirm it does not break with version 0.25.0
Let me know if I can help to make it easier for you.
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
    Memory: 6.74 GB / 15.29 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 4.0.0-rc.28 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.19.3 - ~/.nvm/versions/node/v16.17.0/bin/npm
  Browsers:
    Chrome: 107.0.5304.110
    Firefox: 106.0.5

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@sheremet-va just to mention after reading https://github.com/vitest-dev/vitest/issues/2305.
This one is not exactly related to https://github.com/capricorn86/happy-dom/issues/569 (the base url parameter) as in the msw issue. That said the fix you've provided works perfectly:
// setupVitest
import { URL } from 'node:url';
globalThis.URL = URL;

The issue here seems to come from invalid argument: (ie new URL(new URL("https://xyz")) rather than new URL("https://xyz"). I guess it's not related to vitest, but worth to mention in case you've missed it.
Thanks a lot


Influx does not support new windows very well

This is how influx records are shown when displaying a note in a new window instead of the main one.

Seems to be an issue with Obsidian that it doesn't handle jss in popout windows. Awaiting clarifications; https://discord.com/channels/686053708261228577/716028884885307432/1026115305098973354


STY: Modify grid setup to follow other tears functions

Simplified plotting.plot_multi_factor_quantile_returns and bused GridFigure class in tears API to follow other alphalens tears functions.

Thanks @MichaelJMath!

Oh, I've just noticed you used colormap "RdYlGn" in the heatmap. We recently switched to "coolwarm" due to this issue #233


Include the fedora.linux_system_roles.firewall role to manage firewall

Currently, the sql.server role does not configure firewall, README says that user is responsible for opening ports.
The role must instead include the firewall role to open required ports.
    - name: Open firewall ports for TCP connection to SQL Server
      vars:
        firewall:
          - port: "{{
              '1433' if mssql_tcp_port is not defined else mssql_tcp_port
              }}/tcp"
            zone: public
            state: enabled
            permanent: true
            runtime: true
        when: >-
          ('running' in
          ansible_facts['services']['firewalld.service']['state']) or
          ('enabled' in
          ansible_facts['services']['firewalld.service']['status'])
      include_role:
        name: fedora.linux_system_roles.firewall

What if role opens a different port other than the one configured in SQL Server already? Should the role close the previous port or keep this responsibility on user?

Fixed by #77 and #91


[forwardport] monitoring cannot start when runAsNonRoot is set

[forwardport] https://github.com/rancher/rancher/issues/20884

Duplicate of https://github.com/rancher/rancher/issues/23301


[HOLD for payment 2024-07-30] Pay mollfpr for review of 40285

This issue is just a placeholder to handle C+ payment for review of https://github.com/Expensify/App/pull/40285, which was done as part of a larger issue.
Issue OwnerCurrent Issue Owner: @thesahindia

@roryabraham this is $250 right?

$250 approved for @mollfpr


Getting ready for beta release

Tasks remaining:

[x] Create area for user datasets. DONE.  It's /global/cfs/cdirs/desc-co/registry_beta
[x] Add table to keep track of schema version.  Fields may include major, minor, patch, description, etc. and definitely should include git hash. A row will be added by the create script and by any (future) script which updates the schema in place
[x] Update CI to exercise more features
[x] Create database (i.e. Postgres schema) registry_beta for users to register their datasets
[ ] Create database (i.e. Postgres schema) registry_example.  Populate with a variety of dataset, execution and dependency entries so users can exercise query API.
[x] Update code to use registry_beta as default
[x] Finish initial documentation.  Perhaps include notebook?
[x] Make a release
[x] Prepare presentation for CO on June 28
[x] Publicize more generally and also contact likely beta testers

The beta release happened some time ago.   We should still create a database schema with some example entries, suitable for trying out queries, and available for people to add their own entries with the tutorial notebook.


[Fix] Update for cudf v21.10 API changes

rerun tests

rerun tests

rerun tests

@raydouglass I think this last failure is because test.sh is trying to clone branch-21.10 from https://github.com/BlazingDB/blazingsql-testing-files.git, but it doesn't exist.

rerun tests


Question on README.md

Question regarding word meaning disambiguation

No, the meaning of the word does not matter. Words will not be counted more than once even if the player knows multiple meanings. See the linked Rules in README for more precise instructions.

The point of checking the word in the dictionary is to see if the word exists (not to return the meaning of the word.)


test(ui-library): improve u_font unit test

Description

Simplified unit test to be more efficient in both the reading and writing of it.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🧪 Tests
[ ] 🗑 Chore

cc @drepram 🔨


Return the genesisHash in the htr_getConnectedNetwork RPC method response

We want this information so that the dApp and the Wallet can be sure that they are in the same network, this is specially important for testnet networks.
The fullnode doesn't yet have an API to return this information, we need to create it, I've created an issue to do it in the hathor-core:
https://github.com/HathorNetwork/hathor-core/issues/1103

Update: The genesisHash was already implemented in the /version API, but still pending a deploy of the hathor-core


Resource Warning due to the PyVCF library

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Package Version: Latest Version
Operating System: Macintosh

Expected Behavior
No Resource warnings while running the tests.
Current Behavior
Resource warning due to the unclosed 'vcf file' in PyVCF.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Run the command python -m unittest, and you will receive the following warnings:

I have opened an issue in PyVCF in this regard.


workloads/pcmark: Add PCMark 3.0 support

Add support for PCMark for Android version 3.
Use a 'version' Parameter to maintain support for v2.

Out of interest, what devices has this been tested on? We ran in to issues with PCMark 2 on S21 devices as the UI layout wasn't in line with the buttons on screen.

Out of interest, what devices has this been tested on? We ran in to issues with PCMark 2 on S21 devices as the UI layout wasn't in line with the buttons on screen.

That's interesting, I've been testing it on a Pixel 4 and both PCMark 2 & 3 seem to work fine there. Now I tried running it on a S9+ with Android 11, both of the versions used UI automation to install the Work benchmark properly but then neither actually ran it. They just kept sitting there on the main screen. Maybe there's some issue with the UI automation part in general?
Either way since it's the case on PCMark 2 as well it doesn't seem to be related to supporting v3 or this PR so maybe you should open a separate issue for that?

Either way since it's the case on PCMark 2 as well it doesn't seem to be related to supporting v3 or this PR so maybe you should open a separate issue for that?
Testing this on my device both versions execute successfully so I'm happy to merge this for now.

@scojac01 If you are still having some issues with this workload on another device, as suggested could you open another issue and attach UI dumps of where it is getting stuck?

Either way since it's the case on PCMark 2 as well it doesn't seem to be related to supporting v3 or this PR so maybe you should open a separate issue for that?

Testing this on my device both versions execute successfully so I'm happy to merge this for now.
@scojac01 If you are still having some issues with this workload on another device, as suggested could you open another issue and attach UI dumps of where it is getting stuck?

Hi, I'll open this up later yeah. We currently have a work around that requires having the full UL licence so it's not a blocker for us but it could become an issue for those without this.


Updated the bundle to clarify the intent better per #30.

Added SAN type for other name and removed (unused) DNS. When matching a SAN, it's now clear if the verifier should expect a regular expression or match against an exact value.
Signed-off-by: Fredrik Skogman<EMAIL_ADDRESS>Summary
Fixes #30
Release Note
None
Documentation
None
cc: @haydentherapper @woodruffw @znewman01

@kommendorkapten BTW, feel free to merge this ahead of #36, and I'll take care of deconflicting there 🙂


Updated the semantics version

Updated the semantics version to support EiffelEvents from eiffel repo topic-drop4 branch

Coverage decreased (-0.2%) to 67.311% when pulling b7a4ff5494447478f7fa8b115acd771a46a3a395 on SantoshNC68:changes into 034fa882583548f506bb244523007ec536fa2e9c on Ericsson:master.

Coverage decreased (-0.2%) to 67.311% when pulling e339a5565e331a0836df8210d493c25330716a0c on SantoshNC68:changes into 034fa882583548f506bb244523007ec536fa2e9c on Ericsson:master.


Update pigz check

update pigz check so it will return exitcode 0 for ProcessRunner. update 2 incorrect calls to ProcessRunner().
Fixes #356

Thanks for PR.
Will merge it after doing DOC update.