Norx get

The no Rx get.

#506 #465

Here are some numbers for a row get (lolomo, 0, {to: 9}, item, summary)
Master with primed cache: 1
Master with no cache: 1
NoRX with primed cache: 1.52
NoRX with no cache: 1.2
It appears that set is probably one of the bigger slow downs in the no cache scenario.

I just realized that these numbers are misleading. Let me rerun the no
cache runs, as they are incorrect.
On Mon, Aug 31, 2015, 5:06 PM Michael Paulson<EMAIL_ADDRESS>wrote:

Here are some numbers for a row get (lolomo, 0, {to: 9}, item, summary)
Master with primed cache: 1
Master with no cache: 1
NoRX with primed cache: 1.52
NoRX with no cache: 1.2
It appears that set is probably one of the bigger slow downs in the no
cache scenario.
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/falcor/pull/508#issuecomment-136532293.
--
You received this message because you are subscribed to the Google Groups
"Falcor" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to<EMAIL_ADDRESS>To post to this group, send email to<EMAIL_ADDRESS>To view this discussion on the web visit
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/508/c136532293%40github.com
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/508/c136532293%40github.com?utm_medium=email&utm_source=footer
.

@steveorsomethin It turns out its about 20 - 40% faster with out of cache requests and 50-70% faster in cache requests compared to our last release.  I think we can squeeze and extra 5 - 10% out with simple API change.  I am going to do some extra unit testing around get to ensure that we have no holes.

@jhusain @ktrott @sdesai I am going to merge this unless there are any objections.

I noticed the latest set of get changes (in master) seem to be throwing, handling the get request for the browser build (falcor-http-datasource/onXhrLoad). Was just about to file an issue.
I think we should resolve that, before merging in more changes around Get (unless it's fixed in this branch/PR, by virtue of the rx removal/refactor).
Looks like somewhere along the chain onNext, onError, onComplete functions aren't being normalized to an observer object, which is what onXhrLoad is expecting. The "Getting Started" snippet, falcor-express-demo shows this bug.

@sdesai sounds like a great integration test.  Ill see what I can find.

@sdesai could you file a ticket with step by step instructions for repro.  If I get a change I'll see if its still broken.

Will do. It's basically the "Getting Started" section, with a local dist build (as opposed to the hosted version off github)

This will take some time to make this work again due to a small issue, I'll take care of that some time into the future

@sdesai I have found the root cause of #512 and have a PR to add a unit test to master #515.  Is this safe to merge?  If so, please go for it, else once that problem is fixed could you please merge this?  Thanks.

@jhusain - I'm fine merging this in now that we've addressed #512 - my concern was introducing more flux with the basic integration test being broken.
I don't have enough context yet to review the implementation. Can you take a look at it and we'll merge it in if it looks good.

Looking now.
JH
On Sep 4, 2015, at 4:27 PM, Satyen Desai<EMAIL_ADDRESS>wrote:
@jhusain https://github.com/jhusain - I'm fine merging this in now that
we've addressed #512 https://github.com/Netflix/falcor/issues/512 - my
concern was introducing more flux with the basic integration test being
broken.
I don't have enough context yet to review the implementation. Can you take
a look at it and we'll merge it in if it looks good.
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/falcor/pull/508#issuecomment-137877648.
--
You received this message because you are subscribed to the Google Groups
"Falcor" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to<EMAIL_ADDRESS>To post to this group, send email to<EMAIL_ADDRESS>To view this discussion on the web visit
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/508/c137877648%40github.com
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/pull/508/c137877648%40github.com?utm_medium=email&utm_source=footer
.


Dev - Frobot Test 1

[ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
[ ] This pull request is on the dev branch.
[ ] I used gofmt for formatting the code before submitting the pull request.

A pull request comment

The full scan results are available
Note: no context was provided, so no policy could be determined to scan against.
You can get a list of custom violations by providing one of the command options: --watches, --repo-path or --project.
Read more about configuring Xray policies here: https://www.jfrog.com/confluence/display/JFROG/Creating+Xray+Policies+and+Rules
Below are all vulnerabilities detected.
Vulnerabilities
| SEVERITY | IMPACTED PACKAGE | IMPACTED PACKAGE  VERSION | TYPE | FIXED VERSIONS | COMPONENT | COMPONENT VERSION | CVE |
| --- | --- |  --- | --- |  --- | --- | --- | --- |
| High | github.com/mholt/archiver/v3 | v3.5.1-0.20210618180617-81fac4ba96e4 | Go | | github.com/jfrog/jfrog-client-go github.com/jfrog/jfrog-cli-core/v2 | v1.8.0 |

SEVERITY
IMPACTED PACKAGE
IMPACTED PACKAGE VERSION
FIXED VERSIONS
COMPONENT
COMPONENT VERSION
CVE

github.com/mholt/archiver/v3
v3.5.1-0.20210618180617-81fac4ba96e4

github.com/jfrog/jfrog-client-go github.com/jfrog/jfrog-cli-core/v2
v1.8.0


Updated Linode (Akamai Connected Cloud) support (including cloud-init)

Updated Linode (Akamai Connected Cloud) support (including cloud-init)
Description

cloud-init support is a new feature available in 2023.
The main entry point (create_node) had an arrangement of non-keyword parameters that were not consistent with other libcloud drivers. This has been fixed.
One remaining function (already available in the API) was exposed to also be consistent with other drivers.

Status

done, ready for review

Checklist (tick everything that applies)

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

Thanks for the contribution.
When you get a chance, can you please add some test case for those changes? Thanks.

It also seems like that it may be a good idea to rename the driver in the future (Akamai Connected Cloud)?
We can still leave (deprecated) "linode" alias in place for the foreseeable future to make the change backward compatible.

Acknowledged @Kami . I'll work on that.
Regarding the name change, we haven't been directed to do that right now by the company, particularly as the API endpoint (api.linode.com) is unable to change for the forseeable future.

okie dokie @Kami  I've pushed those tests. Take a 2nd look?

NOTE: I do want to remove (or cleanup) this comment: https://github.com/apache/libcloud/pull/1946/commits/d8add44eec876cae1103b99d545a747a0e33a4bc#diff-e2e26eb0ef50c4cf2bf6b12658cd644d7ca1fe06cd2a3bc307d607149c83a2a4R976
Looking for feedback before I do that.

@mraygalaxy2 Thanks for adding the tests and addressing some very old API inconsistency in the create_node() method.
I think it would be good to document that breaking API change in the upgrade notes file (https://github.com/apache/libcloud/commit/d8add44eec876cae1103b99d545a747a0e33a4bc#r127271125).
Besides that, LGTM.

@Kami Thank you, sir. I'll push a change right now to update that document.

@mraygalaxy2 Thanks. There is one more small thing which I thought I already commented on in the past (https://github.com/apache/libcloud/pull/1946/files#r1324941487), but maybe I forgot to :)

Also tell me if those those docs/upgrade_notes.rst and CHANGES.rst changes look ok. I'm happy to clean them up if there's a mistake.

Thanks for addressing the review feedback.
I made some small changes and merged it into trunk:

Reword upgrade notes entry a bit - 01c7e61de89144205a2dcc1db31239bb527b725c
Default ex_userdata to None instead of False since this makes more sense for an argument which is not a boolean - bb0dba7d0fdc24bf4b21209a6e4267dd6c773a6d
Add test case for ex_userdata argument - bb0dba7d0fdc24bf4b21209a6e4267dd6c773a6d

Thank you so much, @Kami for the changes! Much appreciated.


Add architecture and execution model in docs.

Add architecture and execution model in docs.

LGTM
but it looks like rebase is needed.

good!


Add dfx start/replica options for bitcoin, canister http features

Document new dfx command-line options for bitcoin integration and http requests.
See:

https://github.com/dfinity/sdk/pull/2165
https://github.com/dfinity/sdk/pull/2173

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[x] You have updated the .github/CODEOWNERS file according to your changes.
[x] You have registered new documents to /sidebars.js if any.

Should this be converted to a draft and only released once the changes get published in the next dfx version?


Implementation for no sql

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
no code

Description
sql is good but do you know any implemention for no sql ??!
Wanted Solution
no code
Wanted Code
no code

Alternatives
No response
Operating System
Linux, Windows, macOS, Other
Operating System Details
No response
SQLModel Version
no version
Python Version
any version
Additional Context
No response

https://github.com/tiangolo/sqlmodel/issues/63#issuecomment-916632210
Much NoSQL functionality can be had with json fields in postgres/SQLite.


Simplify F.fmod test

Simplifies test_fmod using testing.FunctionTestCase
Refer to #6071

LGTM. Jenkins, test this please.

pfnCI, please.
(Sorry, but master branch was updated since the test request, and failed to fetch code, so I'd like to trigger the new CI targets again.)

Jenkins CI test (for commit 510507ccacc0c28393a91a408c1b4dd8aa367c5a, target branch master) failed with status FAILURE.

Jenkins failure seems unrelated. Merging.


Fix handling of binary files when using ripgrep scanner

This PR is a follow-up of https://github.com/atom/atom/pull/19348
By pure chance I've found an issue when handling files that have lines with binary content while testing the ripgrep scanner on the gecko-dev repository.
The main problem is found when a file has lines with non-UTF characters it returns a base64 representation of that line in the json output (to not break the JSON formatting). There's more information about it here.
Before this PR, we were not handling this scenario and the parser miserably failed 😅

In case anyone is wondering whether there's anything possible in these JSON objects other than text and bytes, there isn't.


Adds crop selection presets (square, 3:2, 4:3, 5:4, 7:5, 16:9)

Please check if the PR fulfills these requirements

[ ] It's submitted to right branch according to our branching model
[ ] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

I also need this feature. Is it possible to push it on master?


Expected/actual output is poor without color

Example:

% mocha --compilers coffee:coffee-script -C

  ���������

  ��� 1 of 3 tests failed:

  1) filterdata should work for nested hashes:

      actual expected

      1 | {
      2 |   "outer": {
      3 |     "middle": "value"
      4 |   }
      5 | }{}

In this very simple example you should be able to tell that there is a non-empty hash and an empty hash. Looking at just this output you cannot tell which of the two is expected and which is actual.
Maybe you could do diff-style +/- when color is off.

This should be much better nowadays.


Convert complexity breakdown into top 10 and full table on another tab.

Similar to the cost approach.

WIP

Looks nice - we should use the same color scheme on asset costs.


fix: stuck upload on bytes endpoint

Checklist

[x] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[x] I have filled out the description and linked the related issues.

Description
Fixes issue #2946 reintroduced in #3895.

Closed in favor of #3939


Content Type header is sent with semicolon

Hey guys,
We are having a weird issue in which superagent requests content type are received with semicolon: application/json; which causes our RoR (Ruby on Rails) servers fail the request.
Is it a know issue?
Thanks!

Superagent doesn't add the semicolon. Maybe you have a proxy that does it?
Anyway, the semicolon is a valid part of the syntax, so if server can't parse it, then it's server's bug.


Disable appending project_name to beta URL

From the README:

Mutagen Helper appends the project_name to the beta URL.

Is there any way to disable this? I need to sync my folder to the root of the beta URL, not a subfolder.

Use append_project_name_to_beta: false as mentioned at the end of the Readme. I'll list all available options as soon as possible, the docs are still confusing for now.

Ah didn't notice that, thank you 🙂


Support this._super.foo

Adds an interim hack to maintain compatibility with this._super.foo.

LGTM

Added a deprecation warning + test.

LGTM @jgwhite merge when you feel ready


Finish docs cleanup

@willnorris completed much of this work in the week following LFNW. This issue is about mapping out the remaining tasks so people who want to work on finishing the doc restructuring (inc myself) have a clear path forward.

Finish consolidating /website/content/*.html into /doc/, which will require some merging.
[ ] code.html
[ ] community.html
[ ] contributors.html
[ ] download.html
[ ] index.html

@willnorris it would be awesome if you could brain-dump any remaining work you specifically remember. Feel free to add items directly above or just comment and I'll incorporate them. Also correct anything that seems wrong (I just wanted to get the ball rolling).

Reviewing the current status, I realize that all the remaining pages are at the top level, and so it's not clear where they could be moved to. The only possible improvement would be to translate them to markdown, for consistency with /doc. Closing this.


Create functions for multiple news streams

It will be helpful incase you can parse news in batches whenever it's called and also in case if you can dissect the news based on tradingsymbol

Hi,
Thanks for the feedback. I will look into implementing it in Future iterations.


[Question] Extending mime-type detection.

Hello again,
I'm looking to use this library as part of an amazon lambda job for detecting that uploaded files are the correct type.
I've been successful and deploying a simple lambda job that will detect the mime-type of a file uploaded to it for some cases, but in other cases I receive more generic variants, such as 'application/octet-stream' and 'application/zip' for various legacy and current ms office formats. When I run these files using mmmagic locally, the current ms office formats come back correctly. (The legacy ones still have trouble.)
From what I can tell, it's possible to customize libmagic to use custom detectors as part of a /etc/magic file, but I'm unsure how that works or if this library is capable of utilizing this. Does the library support this, and if so is it possible to customize these in a more lambda-friendly way?

OK I've looked at the documentation and tried using the magic.mgc file from my local in my aws lambda function; I copied the file from /usr/share/misc/magic.mgc into my lambda zip distribution. Then I referenced the file from the lambda function and it didn't work.
So a few questions:
1.) Should detecting various microsoft formats work out of the box with the bundled magic.mgc library? If so, why am I seeing different results on lambda? (Not necessarily asking you to investigate, but just maybe provide a guess?)
2.) If not, then why can my local use the library correctly to detect various ms office formats, but when I transfer this to lambda, the values muck up?
One last note: using false for the parameter leads to even worse results, where PDFs aren't even detected and the application/zip files are now instead being application/octet-stream. Is there something that I can look for that might interfere with this library, to your knowledge?

The one thing that will be necessary if you want to use your own magic file is it has to be generated using the same version of libmagic/file (especially for compiled magic files). So as of this writing that would mean libmagic/file 5.32.
As to why you are getting different results, perhaps different versions of mmmagic are being used?

Do you know of any way that I could tell if the same version of libmagic is being used or not? The npm package is the same, so I would expect it to use the node bindings that are part of the mmmagic library, and shouldn't this always be the same version?
I'm perfectly fine using the mmmagic file of the library, but it doesn't appear to be working on lambda correctly, and I'm unsure why.

Ok I figured out the issue. Lambda was receiving the files as text and not binary, and there was some additional configuration information needed to force the file to processed correctly.
For those who are interested, I had to add a binary media type to force lambda to return the file as a base 64 encoded string. Then I had to decode the input body into a buffer in node from a base64 string before passing it into the magic library.


Allow plugin to use the AWS Profile specified

Adds a getCredentials() method used in the options() to check if a profile is set in serverless.yml and use it if set, otherwise set credentials to null and fallback to default. Not fully tested.

@sbstjn Anything else I can do to get this merged in?

Thanks for the PR! A friendly reminder was all you needed ;)

v0.1.6 should be on NPM in a few minutes …

It's not that simple :( The declarations for s3 (vendor/s3.d.ts) need to be updated first ;(


feat: update to newer lifecycle and pack versions

Summary

update to newer version of lifecycle and pack
Use Cases

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Thanks to @natalieparellano who figured out the part about how to use the registry in the scripts.
I had to put the docker stop where it is as anywhere later and it did not seem to run. I suspect something to do with how the go test results are output but not sure.

I had to put the docker stop where it is as anywhere later and it did not seem to run. I suspect something to do with how the go test results are output but not sure.

Yeah, the util::print::success and util::print::error functions exit after printing, so that makes sense. Ideally we would refactor this to be clearer (e.g. using trap or similar), but it should work for now.
More generally, can you help me understand why we now need a registry? What is different from the other builder tests that run directly against the docker engine?

can you help me understand why we now need a registry

When extending images, we use kaniko, which requires a manifest (or more specifically, a v1.Image implementation) so we need the image to exist in a registry in order to pull the data.

When extending images, we use kaniko, which requires a manifest (or more specifically, a v1.Image implementation) so we need the image to exist in a registry in order to pull the data.

Ah. I didn't realize that. So it would be more accurate to say that we have always needed a registry for this builder, we just hadn't added it yet.

@robdimsdale

Ah. I didn't realize that. So it would be more accurate to say that we have always needed a registry for this builder, we just hadn't added it yet.

Correct, except that because of an earlier bug in pack it at least seemed to run/work before.

Ah ok. Thanks. I'm not as familiar with extensions so I'm just trying to follow along.


Dashboard CSS dfle not found error

Dashboard.module.css was imported to the code when it was not created.

Issue fixed


Unconventional use of floating action button

Using a floating action button on each card (as on demo page) is a discouraged practice by MD standards. :)
"Only one floating action button is recommended per screen to increase its prominence. It should represent only the most common action."
Source: https://www.google.de/design/spec/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button
A fix would be to simply use a second link on the card as in the first example here -> http://materializecss.com/cards.html

Fixed in #24 thanks @not-much-io :+1:


New Issue Templates Added

Hey there!
Added the issue templates. Faced some initial hurdles as it was my first time with this, but all sorted now. Funny thing - stumbled upon your YouTube video while researching. It's super helpful!
Thanks for the learning curve. Awaiting feedback!

This pull request closes #1

Thank you so much for your contribution. 😊


[6.0] Don't enforce unique filenames for documentation extensions

Explanation: Excludes documentation extension files from DocC's check that all documents in a catalog must have unique filenames. Previously, one of the doc extensions' content would be dropped (and a diagnostic would be emitted about a redeclared file), which can be confusing when the extensions are for separate symbols with the same name. However, since documentation extensions' filenames have no impact on the URL of those pages, there's no need to enforce unique filenames for them.
Scope: Only impacts documentation extension files with the same filename.
Issue: rdar://117174884
Risk: Low. Excludes documentation extension files (defined as articles starting with an H1 containing link) from DocC's check that all documents in a catalog must have unique filenames.
Testing: Added a unit test ensuring that warnings are no longer emitted and all documentation extension content appears in its correct place. Also tested manually with a small test project and catalog by building a docc executable using this branch, setting DOCC_EXEC to point to it, then running swift package generate-documentation and checking that no warnings were emitted and all documentation extension content appears in its correct place.
Reviewer: @d-ronnqvist
Original PR: https://github.com/apple/swift-docc/pull/863

@swift-ci Please test


fixed-wing offboard control

Hello,
I'm looking for fixed-wing offboard example on ROS2.
When I applied this code to the fixed wing, it doesn't work.
Should I use MAVLink(mavros) instead of ROS2 message(px4_msgs) in the fixed-wing offboard control?

When I applied this code to the fixed wing, it doesn't work.

@gspark87 Could you elaborate on what "doesn't work" mean?

@Jaeyoung-Lim Thank you for reply.
I modified it as below by referring to your code. It doesn't work as intended to fixed-wing(FW).
env) ubuntu 22.04 / ROS2 humble / PX4 1.15.0alpha
    def cmdloop_callback(self):
        # Publish offboard control modes
        if MODE == 'POS':
            offboard_msg = OffboardControlMode()
            offboard_msg.timestamp = int(Clock().now().nanoseconds / 1000)
            offboard_msg.position=True
            offboard_msg.velocity=False
            offboard_msg.acceleration=False
            self.publisher_offboard_mode.publish(offboard_msg)
            if self.nav_state == VehicleStatus.NAVIGATION_STATE_OFFBOARD:
                trajectory_msg = TrajectorySetpoint()
                trajectory_msg.position[0] = 100.0
                trajectory_msg.position[1] = 100.0
                trajectory_msg.position[2] = -60.0
                self.publisher_trajectory.publish(trajectory_msg)

        if MODE == 'ATT':
            offboard_msg = OffboardControlMode()
            offboard_msg.timestamp = int(Clock().now().nanoseconds / 1000)
            offboard_msg.position=False
            offboard_msg.velocity=False
            offboard_msg.acceleration=False
            offboard_msg.attitude=True
            self.publisher_offboard_mode.publish(offboard_msg)
            if self.nav_state == VehicleStatus.NAVIGATION_STATE_OFFBOARD:
                quat = navpy.angle2quat(45.0, -20.0, 30.0, input_unit='deg', rotation_sequence='ZYX')
                att_msg = VehicleAttitudeSetpoint()
                att_msg.q_d = [quat[0], quat[1][0], quat[1][1], quat[1][2]]
                att_msg.thrust_body = [0.6, 0.0, 0.0]
                self.publisher_attitude.publish(att_msg)

Could you elaborate on what "doesn't work" mean?

Problem

In offboard position control, FW do not fly to position setpoint.
The type_mask(position) exist in MAVLink message, but not in px4_msgs.

In offboard attitude control, FW does not maneuver to desired quaternion.
The trust_body command works and can also be seen that the thrust changes in QGC.
There is an offboard button in QGC of Multicopter, but not in fixedwing.
I changed the offboard mode using px4_msgs. Why offboard button doesn't find on FW in QGC?
self.vehicle_command(VehicleCommand().VEHICLE_CMD_DO_SET_MODE, 1.0, 6.0)

Either should work,

In PX4 User Guide, It seems like only Copter is available for ROS2 Messages such as px4_msgs::msg::TrajectorySetpoint and px4_msgs::msg::VehicleAttitudeSetpoint.
https://docs.px4.io/main/en/flight_modes/offboard.html

if you are interested in creating a specific example, I would be interested in collaborating.

When the probelm is resolved, I will share it.

@gspark87 The current implementation for fixedwing offboard trajectory following requires you to provide the velocity setpoints, which interprets it as ground speed.
To use position-only setpoints for offboard mode, you can use https://github.com/PX4/PX4-Autopilot/pull/21376

Note that you additionally need to populate the velocity setpoints with nan values for it to get ignored, since the messages from python get initialized as zeros(which are valid).

Fixedwing offboard position control was solved immediately by velocity setpoints with nan.
trajectory_msg = TrajectorySetpoint()
trajectory_msg.position[0] = -100.0      # North
trajectory_msg.position[1] = -100.0      # East
trajectory_msg.position[2] = -60.0        # Down
trajectory_msg.velocity[0] = math.nan   # solved
trajectory_msg.velocity[1] = math.nan
trajectory_msg.velocity[2] = math.nan
self.publisher_trajectory.publish(trajectory_msg)

Have you tried setting the body relative euler angles?

As you advised, I used body angle roll_body, pitch_body instead of quaternion q_d, so it was solved.
But, yaw_body is not working.

This seems like a bug in QGC that might be worth raising.
You can also simply type commander mode offboard in the px4 shell if you are running SITL

Thanks for letting me know.

But, yaw_body is not working.

@gspark87 You might want to raise this directly in the PX4 repository, since this is more related to the flight control side, rather than this repository.

@Jaeyoung-Lim Happy new year!

May I ask you what you are trying to do with just position and attitude references?

I am trying to fly autonomously with reinforcement learning.
I was testing setpoint interfaces one by one, considering the communication of RL agent and PX4.

Here is the code I tested.
https://github.com/gspark87/px4_offboard/

@gspark87 It appears you have made a copy of the code in this repository and removed the licenses. Could you explain why you have removed the license headers?

@Jaeyoung-Lim
I'm sorry, added the license in this code.
Is it okay if I do this?


Refactor Register

#4460

@Tishasoumya-02 The refactor looks good here, but the actual component seems like it was broken before refactoring.
It is unable to actually succeed in a form submission due to the backend call return an error as the form doesn't send a password value or the sendPasswordReset option. If you could write a test that should pass (i.e. the form sends successfully and the toast appears) but actually fails that would be great and we can go from there on getting this merged.
cc @sneridagh @nileshgulia1 For visibility
Returned error
{
  "error": {
    "errors": [
      {
        "field": "username",
        "message": "Property 'User Name' is required."
      },
      {
        "field": "sendPasswordReset",
        "message": "You have to either send a password or sendPasswordReset."
      }
    ],
    "message": "Error in fields. Property 'User Name' is required. You have to either send a password or sendPasswordReset.",
    "type": "WrongParameterError"
  }
}

@plone/volto-team Updated to the lastest main. Happy for this to be merged?

I restarted failed checks, which I think are flaky.
I also created a new issue from @JeffersonBledsoe's comment in https://github.com/plone/volto/issues/6233.
This PR is concerned only with refactoring.

@Tishasoumya-02 I'm not clear what that error has to do with this PR. Can you elaborate?
Also please do not paste images of error messages. Paste the entire text into a comment surrounded by triple backticks to format it.
```
error message
```

Sorry for the noise ! I was getting this error every time I was trying to create a new document, after make clean then make install , it started working !

@Tishasoumya-02 I'm not clear what that error has to do with this PR. Can you elaborate?
Also please do not paste images of error messages. Paste the entire text into a comment surrounded by triple backticks to format it.

error message

Yes, will keep in mind! Thanks :)


Improve UX of import wallet screen

Improve UX of import wallet screen and fix inconsistencies.

Fixed by #281, create for tracking purposes


Could you help remove the high severity vulnerability introduced in your package?

Hi ,@alexander-fenster @summer-ji-eng , I’d like to report a high severity vulnerability in your package:
Issue Description
A vulnerability (high severity) CVE-2020-7768 in package @grpc/grpc-js<1.1.8 is transitively referenced by<EMAIL_ADDRESS>We noticed that such vulnerability has been removed since<EMAIL_ADDRESS>However, google-gax's popular previous version<EMAIL_ADDRESS>(240,523 downloads per week) is still transitively referenced by a large amount of latest versions of active and popular downstream projects (about 780 downstream projects, e.g., @xapp/ovai-cli 1.33.21, @sentrei/common 1.131.0, @sentrei/web 1.131.0, @xapp/stentor-service-analytics 1.33.20, @sentrei/ui 1.131.0<EMAIL_ADDRESS>and<EMAIL_ADDRESS>etc.). As such, issue CVE-2020-7768  can be propagated into these downstream projects and expose security threats to them.
These projects cannot easily upgrade google-gax from version 1.15.3 to >=2.6.2-beta.0 . For instance<EMAIL_ADDRESS>is introduced into the above projects via the following package dependency paths:
(1<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>(2<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>........
The projects such as @fbg/logger and google-pubsub-wrapper which introduced<EMAIL_ADDRESS>are not maintained anymore. These unmaintained packages can neither upgrade google-gax nor be easily migrated by the large amount of affected downstream projects.
On behalf the downstream users, could you help us remove the vulnerability from package<EMAIL_ADDRESS>Suggested Solution
Since these unactive projects set a version constaint ~1.15.* for google-gax on the above vulnerable dependency paths, if google-gax removes the vulnerability from 1.15.3 and releases a new patched version<EMAIL_ADDRESS>such a vulnerability patch can be automatically propagated into the 780 affected downstream projects.
In<EMAIL_ADDRESS>you can kindly try to perform the following upgrade:
@grpc/grpc-js ~1.0.3 ➔ ~1.1.8;
Note:
<EMAIL_ADDRESS>(>=1.1.8) has fixed the vulnerability CVE-2020-7768
Thank you for your help.
Sincerely yours,
Paimon

Thanks for the feedback. We will take a look and keep posted here.

@summer-ji-eng Thanks for your help. As a popular library version (240,523 downloads per week), if gax-nodejs can release a patch versoin<EMAIL_ADDRESS>it can definitively remove the security threats to ten thousands of dependency paths.
Best regards

@paimon0715  We released to v1.15.4 with latest @grpc-grpcjs. Close this issue. Feel free to reach out if you have further question.
Thanks @alexander-fenster helping on publish this new version.


Improve ci and get working with win32.

looks good. Is there a good reason to build release builds? maturin develop --release

looks good. Is there a good reason to build release builds? maturin develop --release

That's what I've been doing for local development. Presumably the builds are slower and the tests are faster. Maybe at some point we should have some benchmark testing of lengthy programs which gets run separately so we can eyeball if changes make things slower.

That's what I've been doing for local development. Presumably the builds are slower and the tests are faster. Maybe at some point we should have some benchmark testing of lengthy programs which gets run separately so we can eyeball if changes make things slower.

my concern is that if there are any debug_assert!()s, they won't fire in release builds.

my concern is that if there are any debug_assert!()s, they won't fire in release builds.

Squash merged separately.

Squash merged separately.


Measure snapshot

Why
A measure can have either an explicit or implicit end date, where the implicit version is specified by the regulation. Our previous algorithm for finding the implicit end date was not correct, because it reported lots of EU measures as still being in force when clearly (as enforced by ME32) they could not be.
What
This commit fixes the algorithm, and also ensures that when the value is requested from a measure for which it was not pre-loaded, it is calculated in the same way.
The new algorithm has been found through examination of the existing data and comparison with the Online Tariff service as a known good source. E.g. I found EU measures that the system considers still active using:
Measure.objects
.with_effective_valid_between()
.filter(
    sid__lt=20000000, # exclude UK measures
    db_effective_valid_between__contains=date.today(),
)

With this new algorithm, the above query returns a small number of measures which it would make sense if still active e.g. measures on Meursing codes. There are still some anomalies, but the situation is much improved.

Codecov Report

Merging #435 (97c44b2) into master (8c54297) will increase coverage by 0.06%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   91.22%   91.28%   +0.06%
==========================================
  Files         279      279
  Lines       16930    16967      +37
  Branches     1383     1382       -1
==========================================
+ Hits        15444    15489      +45
+ Misses       1239     1234       -5
+ Partials      247      244       -3

Impacted Files
Coverage Δ

measures/business_rules.py
88.26% <75.00%> (-0.44%)
:arrow_down:

common/filters.py
75.80% <100.00%> (-0.20%)
:arrow_down:

common/tests/factories.py
99.66% <100.00%> (+<0.01%)
:arrow_up:

common/util.py
85.13% <100.00%> (+2.91%)
:arrow_up:

exporter/sqlite/plan.py
96.42% <100.00%> (-0.24%)
:arrow_down:

measures/filters.py
64.93% <100.00%> (-0.45%)
:arrow_down:

measures/models.py
96.11% <100.00%> (+1.84%)
:arrow_up:

measures/querysets.py
100.00% <100.00%> (ø)

measures/tests/test_business_rules.py
96.73% <100.00%> (-0.04%)
:arrow_down:

measures/tests/test_models.py
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c54297...97c44b2. Read the comment docs.


Adding homebrew breaks dev container

I'm trying to get our organization onto dev containers / code spaces on github to make onboarding quicker. I've set-up a codespace on github, running it locally on my Mac M1 the creation breaks by simply adding:
{
  // (...)
  "features": {
    "homebrew": "latest", // <----------------------------------- here
    "kubectl-helm-minikube": "1.23"
  }
}

leading to
[2022-06-04T13:58:16.932Z] (*) Script: homebrew-debian.sh automatic true false
[2022-06-04T13:58:16.935Z] (!) Architecture aarch64 unsupported

Question

Is there a way around this so devs can use homebrew inside their dev environment?
Since using mac and the new m1 machines is pretty dominant, is there a way to clearly state which features would only work on code-spaces, specific architectures?

Thank you!
Specs
I have also tried disabling / enabeling buildkit, which lead to weird situations like this here (root): https://github.com/microsoft/vscode-dev-containers/issues/1479

VSCode Version:

1.67.2 (Universal)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5

Local OS Version: macOS Monterey Version 12.4
Local chip architecture: Apple Silicon
Reproduces in: Remote - Containers
Name of Dev Container Definition with Issue: Feature homebrew

Steps to Reproduce:

Create an empty folder
Open it in VS Code
Run Remote Containers: Open Folder in Container
When adding homebrew build fails

https://user-images.githubusercontent.com/2397125/172005207-09124b51-a6b6-434c-9dc7-7a5b9cf0a098.mp4
Log of Fail-State
[2022-06-04T13:57:40.490Z] Remote-Containers 0.234.0 in VS Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5).
[2022-06-04T13:57:40.490Z] Start: Resolving Remote
[2022-06-04T13:57:40.495Z] Setting up container for folder or workspace: /Users/worker/development/twinwin_workspace/docker_from_docker_test
[2022-06-04T13:57:40.501Z] Start: Check Docker is running
[2022-06-04T13:57:40.501Z] Start: Run: docker version --format {{.Server.APIVersion}}
[2022-06-04T13:57:40.588Z] Stop (87 ms): Run: docker version --format {{.Server.APIVersion}}
[2022-06-04T13:57:40.588Z] Server API version: 1.41
[2022-06-04T13:57:40.588Z] Stop (87 ms): Check Docker is running
[2022-06-04T13:57:40.589Z] Start: Run: docker volume ls -q
[2022-06-04T13:57:40.653Z] Stop (64 ms): Run: docker volume ls -q
[2022-06-04T13:57:40.659Z] Start: Run: docker inspect --type container 416c97a522a4569864783308c8f442e5bce34f9ab30aae33a8d3d78d154a047b
[2022-06-04T13:57:40.730Z] Stop (71 ms): Run: docker inspect --type container 416c97a522a4569864783308c8f442e5bce34f9ab30aae33a8d3d78d154a047b
[2022-06-04T13:57:40.730Z] Start: Run: docker ps -q -a --filter label=vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --filter label=vsch.quality=stable
[2022-06-04T13:57:40.805Z] Stop (75 ms): Run: docker ps -q -a --filter label=vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --filter label=vsch.quality=stable
[2022-06-04T13:57:40.806Z] Start: Run: /Applications/Visual Studio Code.app/Contents/MacOS/Electron /Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js up --user-data-folder /Users/worker/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data --container-data-folder .vscode-server/data/Machine --container-system-data-folder /var/vscode-server --workspace-folder /Users/worker/development/twinwin_workspace/docker_from_docker_test --workspace-mount-consistency cached --id-label vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --id-label vsch.quality=stable --log-level debug --log-format json --config /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --mount type=volume,source=vscode,target=/vscode,external=true --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root true
[2022-06-04T13:57:40.898Z] remote-containers 0.234.0.
[2022-06-04T13:57:40.898Z] Start: Resolving Remote
[2022-06-04T13:57:40.899Z] Start: Run: git rev-parse --show-cdup
[2022-06-04T13:57:40.906Z] Stop (7 ms): Run: git rev-parse --show-cdup
[2022-06-04T13:57:40.907Z] Start: Run: docker ps -q -a --filter label=vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --filter label=vsch.quality=stable
[2022-06-04T13:57:40.981Z] Stop (74 ms): Run: docker ps -q -a --filter label=vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --filter label=vsch.quality=stable
[2022-06-04T13:57:40.982Z] Start: Run: docker build -f /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer/Dockerfile -t vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5 /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer
[2022-06-04T13:57:41.157Z] Sending build context to Docker daemon   42.5kB

[2022-06-04T13:57:41.200Z] Step 1/14 : FROM mcr.microsoft.com/vscode/devcontainers/base:0-bullseye
 ---> 0281bee16158
Step 2/14 : ARG INSTALL_ZSH="true"
[2022-06-04T13:57:41.201Z]  ---> Using cache
 ---> ec32c22c202c
Step 3/14 : ARG UPGRADE_PACKAGES="false"
[2022-06-04T13:57:41.201Z]  ---> Using cache
 ---> 9732f31c9244
Step 4/14 : ARG ENABLE_NONROOT_DOCKER="true"
 ---> Using cache
 ---> 31aeb002aef3
Step 5/14 : ARG USE_MOBY="true"
[2022-06-04T13:57:41.201Z]  ---> Using cache
 ---> 5c628e8fc7a7
Step 6/14 : ARG CLI_VERSION="latest"
[2022-06-04T13:57:41.201Z]
[2022-06-04T13:57:41.201Z]  ---> Using cache
 ---> 65d7b3d88ab1
Step 7/14 : ENV DOCKER_BUILDKIT=1
 ---> Using cache
 ---> fabb24ebdfff
Step 8/14 : ARG USERNAME=automatic
[2022-06-04T13:57:41.201Z]  ---> Using cache
 ---> 39bceba9010f
Step 9/14 : ARG USER_UID=1000
[2022-06-04T13:57:41.202Z]  ---> Using cache
 ---> 56559f96b555
Step 10/14 : ARG USER_GID=$USER_UID
 ---> Using cache
 ---> 74188aabc5f9
Step 11/14 : COPY library-scripts/*.sh /tmp/library-scripts/
[2022-06-04T13:57:41.202Z]  ---> Using cache
 ---> 91665a223199
[2022-06-04T13:57:41.202Z] Step 12/14 : RUN apt-get update     && /bin/bash /tmp/library-scripts/common-debian.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" "${UPGRADE_PACKAGES}" "true" "true"     && /bin/bash /tmp/library-scripts/docker-debian.sh "${ENABLE_NONROOT_DOCKER}" "/var/run/docker-host.sock" "/var/run/docker.sock" "${USERNAME}" "${USE_MOBY}" "${CLI_VERSION}"     && apt-get autoremove -y && apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/library-scripts/
[2022-06-04T13:57:41.202Z]  ---> Using cache
 ---> 223326901b6c
Step 13/14 : ENTRYPOINT [ "/usr/local/share/docker-init.sh" ]
[2022-06-04T13:57:41.202Z]  ---> Using cache
 ---> 91314cc56172
Step 14/14 : CMD [ "sleep", "infinity" ]
[2022-06-04T13:57:41.202Z]  ---> Using cache
 ---> 8d0035aec51d
[2022-06-04T13:57:41.202Z] Successfully built 8d0035aec51d
[2022-06-04T13:57:41.204Z] Successfully tagged vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5:latest
[2022-06-04T13:57:41.259Z]
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
[2022-06-04T13:57:41.263Z] Stop (281 ms): Run: docker build -f /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer/Dockerfile -t vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5 /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer
[2022-06-04T13:57:41.267Z] Preparing to parse declared features and fetch remote features.
[2022-06-04T13:57:41.267Z] Detected local feature set. Continuing...
[2022-06-04T13:57:41.267Z] Detected local feature set. Continuing...
[2022-06-04T13:57:41.267Z] Start: Run: docker inspect --type image vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5
[2022-06-04T13:57:41.324Z] Stop (57 ms): Run: docker inspect --type image vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5
[2022-06-04T13:57:41.325Z] local container features stored at: /Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/node_modules/vscode-dev-containers/container-features
[2022-06-04T13:57:41.326Z] Start: Run: tar --no-same-owner -x -f -
[2022-06-04T13:57:41.335Z] Stop (9 ms): Run: tar --no-same-owner -x -f -
[2022-06-04T13:57:41.335Z] Start: Run: docker build -t vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5-features --build-arg BASE_IMAGE=vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5 --build-arg IMAGE_USER=root /var/folders/xd/vr043n690wn290nhxq9s57z00000gn/T/vsch/container-features/0.234.0-1654351061263
[2022-06-04T13:57:41.515Z] Sending build context to Docker daemon  294.9kB

[2022-06-04T13:57:41.540Z] Step 1/9 : ARG BASE_IMAGE=mcr.microsoft.com/vscode/devcontainers/base:buster
Step 2/9 : FROM $BASE_IMAGE
[2022-06-04T13:57:41.540Z]  ---> 8d0035aec51d
Step 3/9 : USER root
[2022-06-04T13:57:41.540Z]  ---> Using cache
 ---> 30def6a4b210
Step 4/9 : COPY . /tmp/build-features/
[2022-06-04T13:57:41.612Z]  ---><PHONE_NUMBER>57
Step 5/9 : RUN cd /tmp/build-features/local-cache && chmod +x ./install.sh && ./install.sh
[2022-06-04T13:57:41.619Z]  ---> Running in 2e0cb1bc9706
[2022-06-04T13:57:41.765Z] (*) Script: kubectl-helm-debian.sh 1.23 latest latest
[2022-06-04T13:57:41.774Z] Running apt-get update...
[2022-06-04T13:57:41.852Z] Get:1 http://security.debian.org/debian-security bullseye-security InRelease [44.1 kB]
Get:2 http://deb.debian.org/debian bullseye InRelease [116 kB]
[2022-06-04T13:57:41.899Z] Get:3 http://deb.debian.org/debian bullseye-updates InRelease [39.4 kB]
[2022-06-04T13:57:41.933Z] Get:4 https://packages.microsoft.com/repos/microsoft-debian-bullseye-prod bullseye InRelease [10.5 kB]
[2022-06-04T13:57:41.938Z] Get:5 http://security.debian.org/debian-security bullseye-security/main arm64 Packages [152 kB]
[2022-06-04T13:57:41.999Z] Get:6 http://deb.debian.org/debian bullseye/main arm64 Packages [8070 kB]
[2022-06-04T13:57:42.106Z] Get:7 https://packages.microsoft.com/repos/microsoft-debian-bullseye-prod bullseye/main arm64 Packages [11.7 kB]
[2022-06-04T13:57:43.526Z] Get:8 http://deb.debian.org/debian bullseye/non-free arm64 Packages [69.6 kB]
[2022-06-04T13:57:43.538Z] Get:9 http://deb.debian.org/debian bullseye/contrib arm64 Packages [40.8 kB]
[2022-06-04T13:57:43.545Z] Get:10 http://deb.debian.org/debian bullseye-updates/main arm64 Packages [2600 B]
[2022-06-04T13:57:44.170Z] Fetched 8557 kB in 2s (3597 kB/s)
Reading package lists...
[2022-06-04T13:57:44.443Z]
[2022-06-04T13:57:44.466Z] Reading package lists...
[2022-06-04T13:57:44.734Z]
[2022-06-04T13:57:44.745Z] Building dependency tree...
[2022-06-04T13:57:44.823Z]
Reading state information...
[2022-06-04T13:57:44.901Z] ca-certificates is already the newest version (20210119).
coreutils is already the newest version (8.32-4).
coreutils set to manually installed.
curl is already the newest version (7.74.0-1.3+deb11u1).
The following additional packages will be installed:
  gnupg gnupg-l10n gnupg-utils gpg gpg-agent gpg-wks-client gpg-wks-server
  gpgconf gpgsm gpgv
[2022-06-04T13:57:44.902Z] Suggested packages:
  dbus-user-session libpam-systemd pinentry-gnome3 tor parcimonie xloadimage
  scdaemon
[2022-06-04T13:57:44.937Z] The following NEW packages will be installed:
[2022-06-04T13:57:44.937Z]   bash-completion
[2022-06-04T13:57:44.937Z] The following packages will be upgraded:
  dirmngr gnupg gnupg-l10n gnupg-utils gnupg2 gpg gpg-agent gpg-wks-client
[2022-06-04T13:57:44.938Z]   gpg-wks-server gpgconf gpgsm gpgv
[2022-06-04T13:57:44.986Z] 12 upgraded, 1 newly installed, 0 to remove and 16 not upgraded.
Need to get 8524 kB of archives.
After this operation, 1560 kB of additional disk space will be used.

 Architecture aarch64 unsupported
[2022-06-04T13:58:17.075Z] The command '/bin/sh -c cd /tmp/build-features/local-cache && chmod +x ./install.sh && ./install.sh' returned a non-zero code: 1
[2022-06-04T13:58:17.095Z] Stop (35760 ms): Run: docker build -t vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5-features --build-arg BASE_IMAGE=vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5 --build-arg IMAGE_USER=root /var/folders/xd/vr043n690wn290nhxq9s57z00000gn/T/vsch/container-features/0.234.0-1654351061263
[2022-06-04T13:58:17.098Z] Error: Command failed: docker build -t vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5-features --build-arg BASE_IMAGE=vsc-docker_from_docker_test-3c44298c373e4c326e12a70d1cfeadb5 --build-arg IMAGE_USER=root /var/folders/xd/vr043n690wn290nhxq9s57z00000gn/T/vsch/container-features/0.234.0-1654351061263
[2022-06-04T13:58:17.098Z]     at IR (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:221:995)
[2022-06-04T13:58:17.098Z]     at zy (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:221:933)
[2022-06-04T13:58:17.098Z]     at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2022-06-04T13:58:17.099Z]     at async $R (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:226:2007)
[2022-06-04T13:58:17.100Z]     at async Zy (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:226:3112)
[2022-06-04T13:58:17.100Z]     at async BR (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:226:12448)
[2022-06-04T13:58:17.100Z]     at async qR (/Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js:226:12204)
[2022-06-04T13:58:17.106Z] Stop (36300 ms): Run: /Applications/Visual Studio Code.app/Contents/MacOS/Electron /Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js up --user-data-folder /Users/worker/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data --container-data-folder .vscode-server/data/Machine --container-system-data-folder /var/vscode-server --workspace-folder /Users/worker/development/twinwin_workspace/docker_from_docker_test --workspace-mount-consistency cached --id-label vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --id-label vsch.quality=stable --log-level debug --log-format json --config /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --mount type=volume,source=vscode,target=/vscode,external=true --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root true
[2022-06-04T13:58:17.106Z] Exit code 1
[2022-06-04T13:58:17.108Z] Command failed: /Applications/Visual Studio Code.app/Contents/MacOS/Electron /Users/worker/.vscode/extensions/ms-vscode-remote.remote-containers-0.234.0/dist/spec-node/devContainersSpecCLI.js up --user-data-folder /Users/worker/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data --container-data-folder .vscode-server/data/Machine --container-system-data-folder /var/vscode-server --workspace-folder /Users/worker/development/twinwin_workspace/docker_from_docker_test --workspace-mount-consistency cached --id-label vsch.local.folder=/Users/worker/development/twinwin_workspace/docker_from_docker_test --id-label vsch.quality=stable --log-level debug --log-format json --config /Users/worker/development/twinwin_workspace/docker_from_docker_test/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --mount type=volume,source=vscode,target=/vscode,external=true --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root true
[2022-06-04T13:58:17.108Z] Exit code 1

Hello 👋
I agree it would be great for us to figure out a way to convey architecture compatibility for 'features', before installation. Today, we have added the install message you shared ((!) Architecture aarch64 unsupported) to the scripts that do not yet support multiple architectures.
The homebrew script is currently community-supported.  It was originally contributed by @andreiborisov (per our contribution guide, and we encourage anyone in the community to add feature gaps they identify.
Here is an example of a 'feature' script that is architecture-aware: https://github.com/microsoft/vscode-dev-containers/blob/main/script-library/rust-debian.sh#L130-L142

I think being very clear in the UI what can run where (like docker desktop does in their UI on containers; highlighting the architecture) would be a big benefit. Including a zero config option that remote dev containers executes under rosetta; starting docker with the appropriate flag by default on m1 macs.
Why? Basically, I‘m looking for a process where the most junior engineer just needs two things:

VSCode
Docker Desktop

Than clone a repository and as „Open in Container“ and the rest just works (be it slower due to compat mode)
During container creation (again VSCode UI), flagging what can run where would help devs clicking together environments more consciously. Avoiding frustration when “sharing their work”.
Regarding working up-stream on ensuring that things like homebrew run well is a job for homebrew & co. But signaling

„Hey, if you add this, the dev container will not run on none x86 machines like raspberry pi (i.e. I do none-profit teaching sometimes) and in compatibility mode on m1 macs“

…would be a huge win in usability and trust. Love the concept of devcontainers. Thank you for building this.

Asking to close this, as we migrated Homebrew to the new feature spec.
@D1no please, try the new feature: https://github.com/meaningful-ooo/devcontainer-features/tree/main/src/homebrew and report again if the issue persists.

Same issue here with the proposed solution :(
	"features": {
		"docker-in-docker": "latest",
		"kubectl-helm-minikube": "1.21",
		"git": "latest",
		// "homebrew": "latest",
		"ghcr.io/meaningful-ooo/devcontainer-features/homebrew:2": {}
	}
}

 > [dev_containers_target_stage 4/6] RUN cd /tmp/build-features/homebrew_4 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh:
[2023-02-08T21:26:02.236Z] #0 0.394 ===========================================================================
#0 0.394 Feature       : Homebrew
#0 0.394 Description   : Installs Homebrew
#0 0.394 Id            : ghcr.io/meaningful-ooo/devcontainer-features/homebrew
#0 0.394 Version       : 2.0.3
#0 0.394 Documentation : https://github.com/meaningful-ooo/devcontainer-features/tree/main/src/homebrew
#0 0.394 Options       :
#0 0.394     SHALLOWCLONE="false"
#0 0.394 ===========================================================================
#0 0.401 (!) Architecture aarch64 unsupported
#0 0.403 ERROR: Feature "Homebrew" (ghcr.io/meaningful-ooo/devcontainer-features/homebrew) failed to install! Look at the documentation at https://github.com/meaningful-ooo/devcontainer-features/tree/main/src/homebrew for help troubleshooting this error.
------


Website down

https://ketchuphq.com/ is offline

It appears to be back down again.

Site is down again @octavore , maybe use something like Heroku.com for hosting?

thanks! I suspect there's a bug related to renewing the SSL certificate and restarting the http handlers - will take a look!


CornerRadius page

Description
Adds a new page on CornerRadius. It is navigated through a new group in the Navigation Menu called "Tips and Guides".
Motivation and Context
Fixes #375
How Has This Been Tested?
Manual tests.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Everything is subject to change as feedback is received through the pull request. It's a work in progress.

Thanks @chingucoding for all the feedback!

Thank you for submitting this draft, @Chips1234! I've added a few comments.

Alright, I'll take a look at it. Thanks

Rather than creating a new category, I wonder if this page should be added to the Styles category?

Rather than creating a new category, I wonder if this page should be added to the Styles category?

Agreed - and @chingucoding mentioned that here: https://github.com/microsoft/Xaml-Controls-Gallery/pull/507#discussion_r460001278  - this has already been moved to the Styles category. Maybe looking at an outdated version of the PR?

Yes, it have been moved to “style”

From: Steven Moyes<EMAIL_ADDRESS>Sent: Tuesday, July 28, 2020 1:02:53 PM
To: microsoft/Xaml-Controls-Gallery<EMAIL_ADDRESS>Cc: Eric Tian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/Xaml-Controls-Gallery] CornerRadius page (#507)
Rather than creating a new category, I wonder if this page should be added to the Styles category?
Agreed - and @chingucodinghttps://github.com/chingucoding mentioned that here: #507 (comment)https://github.com/microsoft/Xaml-Controls-Gallery/pull/507#discussion_r460001278 - this has already been moved to the Styles category. Maybe looking at an outdated version of the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Xaml-Controls-Gallery/pull/507#issuecomment-665250436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RQA6FWOY6FXPLDJVKLR54VG3ANCNFSM4PGK5B3Q.

@YuliKl @stmoy Are there any things that need addressing in that PR (aside from the merge conflict)?

@YuliKl @stmoy Are there any things that need addressing in that PR (aside from the merge conflict)?

Yes, I’ll fix the merge conflicts soon.

From: Marcel Wagner<EMAIL_ADDRESS>Sent: Wednesday, January 13, 2021 9:22:47 AM
To: microsoft/Xaml-Controls-Gallery<EMAIL_ADDRESS>Cc: Eric Tian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/Xaml-Controls-Gallery] CornerRadius page (#507)
@YuliKlhttps://github.com/YuliKl @stmoyhttps://github.com/stmoy Are there any things that need addressing in that PR (aside from the merge conflict)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Xaml-Controls-Gallery/pull/507#issuecomment-759597846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RXJTQ265PSNO5HMH7TSZXJGPANCNFSM4PGK5B3Q.

Yes, I’ll fix the merge conflicts soon.

From: Marcel Wagner<EMAIL_ADDRESS>Sent: Wednesday, January 13, 2021 9:22:47 AM
To: microsoft/Xaml-Controls-Gallery<EMAIL_ADDRESS>Cc: Eric Tian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/Xaml-Controls-Gallery] CornerRadius page (#507)
@YuliKlhttps://github.com/YuliKl @stmoyhttps://github.com/stmoy Are there any things that need addressing in that PR (aside from the merge conflict)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Xaml-Controls-Gallery/pull/507#issuecomment-759597846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RXJTQ265PSNO5HMH7TSZXJGPANCNFSM4PGK5B3Q.


Documentation update - Vendor publish

Hi  ,
Im starting with your package and i get a little mistake in the documentation , with vendor publish hehe .
php artisan vendor:publish --tag="laravel-model-filter-config" will be
php artisan vendor:publish --tag="model-filter-config"
And
php artisan vendor:publish --tag="lacodix-filter-translations" will be
php artisan vendor:publish --tag="model-filter-translations"

Hi
thanks for your comment, I just updated the docs...
I also added a new feature few days ago that also missed in the docs: hiding filters programmatically...
https://www.lacodix.de/docs/laravel-model-filter/v1/basic-usage/filter-visibility
just needed it in a own project where not all filters should always be visible decided by Laravel Penant
If you think there is something missing, or something not working as expected, please contact me again...


Send first echo request at startup delay

Send the first echo request at startup after specified delay (default 0ms).
This is useful to receive initial status quicker when using longer send interval setting.
Such as processes waiting on dpinger to start.  But once started, don't need such frequent status.

This change introduces a race condition in thread startup. If the desire is to send a probe as soon as possible, there are better ways to address this. I had such an approach in an early version of the code, but removed it as being not worth the effort given that most will be using 250ms probes. If you can explain your use case it would be helpful... What parameters are you starting dpinger with? Are you using long probe times?  Thanks.

The desire is to control when the first probe is sent, independently from the send interval.
Most people using x doesn't nullify and make useless y (PC/MAC, iPhone/Android, Ford/Chevy/Dodge), especially for software.
The use case was describe in the commit message.  Quicker initial status when longer send interval is desired.  So that for instance the starting of a process isn't unnecessarily delayed waiting for the longer send interval.
Yes I am using longer probe times than the default (5 seconds, it suits my needs).  But a 5 second initial probe delay does not.
Could you please be so kind as to describe the race condition?
If my solution doesn't meet your requirements could you please include such an option?
Thanks.

I see the use case for shortening or eliminating the initial delay. I don't see a use case for lengthening it. An early version of dpinger had code to eliminate the delay--I'll look at putting it back in. Thanks.

This has been addressed. Thank you again @NOYB.


Update dev instructions to use starter site

Instead of make local, recommend that we use make starter for dev installs
Purpose / why
Starter seems to be the recommended way to install now, and is easier to work with for new installs
What changes were made?
install instructions changed from make local to make starter
Verification
Create a new site with make starter as described in the changed documentation.
Note: make starter does not currently allow installing from an existing codebase without a few extra steps not described here, but I have a PR (https://github.com/Islandora-Devops/isle-dc/pull/336) that will allow it to. If necessary I can update these docs to include the extra steps, but ideally that PR would go through first so that won't be necessary.
Interested Parties

@Islandora/documentation

Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:

[ ] Does this PR link to related issues?
[ ] Does the proposed documentation align with the Islandora Documentation Style Guide?
[ ] Are the changes accurate, useful, free of typos, etc?

Person Merging
The person merging should ensure the following:

[ ] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[ ] If pages are renamed or removed, have all internal links to those pages been fixed?
[ ] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

We will be waiting this PR to be merged before we do this one
https://github.com/Islandora-Devops/isle-dc/pull/336

@ysuarez, https://github.com/Islandora-Devops/isle-dc/pull/336 was merged. Is this good to merge now?


Fix all duplicated called bugs

This PR will close #82.
This is a follow-up to #124. Similar to the issue, I modified all updateDB()s in numgen and datacalc.
Situation

Add database A and B in dbmgr.
Set A as a store of numgen.
Set A and B as sources of datacalc.
Remove A from dbmgr.

Before step 4

After step 4

There is no duplicated message.

I will re-open this PR after resolving Pylint warnings.

I applied reviews.

I applied the reviews.

Ok! I appied it again.


The big name | ID | UUID | version ID discussion

In many PRs we're now running into very differing views on when and how to use object identifiers. We, for all different areas/task teams, have to settle on one general way to use object identifiers (OID).
This discussion here does not address each object's need to implement a given type of OID, just the relationships between OID attribute name and value, and the general OID usage.
This discussion starts also based on the assumption that OID usage will not depend on a GA4GH provided arbitration system. However, this does not mean that such services won't be implemented.
Issues in which the proposed OID differ can be separated into

uniqueness (global/local/none)
content dependency (partial/full content hashing)
generation (machine vs. readable/legacy)

This opens following attributes for discussion:

id

required (exception to the "object's need for OID type not discussed here")
locally unique
usually something "readable" (GSM2492834, BRCA-2015-DCIS0012 ...)
main type for (local) references

guid

UUIDv4
assumed to be globally unique without central arbitration, due to its structure
computer generated at creation
global references (though no guarantee that not duplication of another object)

name

not necessarily "clean"; possibly descriptive ("patient_25, PB")
important for legacy data & "human parsing"
not recommended for object references

versionID

(partial/complete) object hash
version management (e.g. combined with time stamps)
global references with absolut uniqueness

The main points which I predict tobe discussed here are the abstaining from using name for referencing (which is different from some PRs) and the guid/UUID types.
[
In principle, this could be collapsed by using guid type identifiers for id. However, this would provide many headaches for both legacy data & privacy (e.g. you may want to pass on datasets with your locally unique identifiers, without allowing easy global identification of data references with respect to other resources).
]

Thanks for kicking this off  @mbaudis, this is a key topic. I think you've summarised things very well here.
Collapsing the GUID and ID would be problematic for implementers I think, as it is useful to have control of the ID structure. Certainly it would give us major headaches in the reference server. For example, we use variant IDs of the form base64encode(datasetName:variantSetName:variantName), where variantName is something like chr:pos:alt. When we get a GET variant request for a given ID, we then use this structure to find the right dataset, variantSet and variant. If we didn't have this structure, we would have generate a GUID for every variant and read, and to maintain a global index of all GUID -> variant/read mappings, which would be rather large.
I don't think IDs should necessarily be seen as human readable, since they are server generated. In the reference server we've base64 encoded the values to discourage clients from using the ID structure outlined above, since it's not (and shouldn't be) part of the API.

My view:

ID. Unique within a repository. Repo dependent. Not necessarily readable. Not stable. Example: an auto-incremental primary key in SQL.

Query-able name, e.g. reference name and sample name. Users are interested in putting them in an API query.

Display name, e.g. read group name, library name and read name. These names don't appear in any query. Just for display purpose.

Accession number plus version number. Stable identifier. See this paper. Accession numbers are widely used among bio databases and working well in practice.

Content digest. Computed from content in a pre-defined way.

@jeromekelleher I'll change the "readable" to something like "representing some local systematics". The emphasis for human readability should be put on name and description (not mentioned yet, since not strictly "OID".
@lh3 We had already separate attributes for accessions and description envisioned in metadata. I'll extend the proposal to accommodate those.
As per @diekhans, I'll move this discussion ASAP to the documentation branch.

Hello all,
I had dinner with David Glazer and other Google people on Tuesday night, and this topic came up with respect to columns/callsets
in VariantSets.  I came up with a new approach, which after some refinement in discussionI think has guarded approval at least as
an approach worth discussing.
Currently for a CallSet in a VariantSet there is something like
ID columnId ;	// system generated unique id
string name ;	// user defined text
ID sampleId ;	// should be system generated unique id
map{string,string} attributes ; // other metadata
Note that I have used the type ID for ids over which the user should have no control, which arguably should be opaque to end users.
These are strings now.  You can imagine ID as a typedef to string.
The revised proposal is
Label columnLabel ; // required, user-defined, unique within the variant set
ID sampleId ; // optional
ID methodId ; // an id for a “method" object that can hold metadata about how the calls were made, optional
The new concept is Label, which is a string of printable characters, possibly with restricted syntax e.g. [a-zA-Z][a-zA-Z0-9_]* like programming language identifiers.  The aim is that this should be a reasonable thing for users to look at and use, e.g. to display as column headings, or use in queries.
This replaces both columnId, which is server-unique and not under user control, and name, which is user-defined and can’t be relied on to be unique.
We are OK to require the labels to be unique, because the scope is limited to the CallSet, so long range clashes are not a problem.  The semantics of merging VariantSets can be specified as part of the merge operation - both options of maintaining uniqueness by adding suffixes if necessary or forcing merge when the labels coincide have merit in different circumstances.
Because the labels must be unique, they can be used as a key for retrieval of CallSet columns in the VariantSet.
Having them separate from the sampleId means that you can have two CallSet columns for the same sample in one VariantSet, which is nice to be able to compare call sets made in different ways from the same sample (e.g. Illumina versus CG, or different callers).
Having a methodId that references an external Method object, which contains a metadata map, allows columns to share the same information about how they were called.
In fact, we think it would make sense for the VariantSet itself to have an optional methodId, which would then act as a default for all its callsets, covering the standard case where all callsets are made the same way.
It is good for both sampleId and methodId to be optional, so that lightweight VariantSets can be made by importing VCF files or the equivalent, without having to create lots of other empty objects first.  We should not underestimate the importance of lightweight use of the object representation and API - a large amount of sequence data handling is done in small labs with LIMS that will autopopulate Sample objects, or in exploratory analysis, and we would like users not to have to manage unnecessary appendages.
I guess I should make a pull request.
I think the same approach using Label with uniqueness within a limited scope could be used in other places, e.g. for References in a ReferenceSet.
Richard

On 23 Sep 2015, at 07:57, Michael Baudis<EMAIL_ADDRESS>wrote:
@jeromekelleher https://github.com/jeromekelleher I'll change the "readable" to something like "representing some local systematics". The emphasis for human readability should be put on name and description (not mentioned yet, since not strictly "OID".
@lh3 https://github.com/lh3 We had already separate attributes for accessions and description envisioned in metadata. I'll extend the proposal to accommodate those.
As per @diekhans https://github.com/diekhans, I'll move this discussion ASAP to the documentation branch.
—
Reply to this email directly or view it on GitHub https://github.com/ga4gh/schemas/issues/418#issuecomment-142514069.

--
The Wellcome Trust Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is 215 Euston Road, London, NW1 2BE.

(program note: @richarddurbin opened PR #427 indeed!)
@mbaudis I enter this late so please disregard with my apologies if this is well-trodden ground:
Was consideration given to a URI scheme for guids, as a way of preserving some degree of human readability? That is, a global domain prefix to the locally unique id. Once upon a time there was a whole consortium project just about this, LSID.

@mlin The guid type hasn't been discussed in this direction. Since we assume no need for a central authority for ID management or even repository tracking, anonymous collision free UUIDs seem like the best way to guarantee object identity and allowing object retrieval from a variety of alternative resources.
However, we should also add the option to expose fully a qualified URI per object, which would then depend on the local resource.

We don't yet have a conceptual model for global object
identification, so actually format of the ids is a bit
pre-nature.
Any method for global identification should to be linked with
provenance information. Identifying the origin of data is an
important use case for GUIDs.
Michael Baudis<EMAIL_ADDRESS>writes:

@mlin The guid type hasn't been discussed in this direction. Since we assume no
need for a central authority for ID management or even repository tracking,
anonymous collision free UUIDs seem like the best way to guarantee object
identity and allowing object retrieval from a variety of alternative resources.
However, we should also add the option to expose fully a qualified URI per
object, which would then depend on the local resource.
—
Reply to this email directly or view it on GitHub.*


OnServerDisconnect Not Fired for Host Client

Describe the bug
For remote clients, StopClient eventually triggers a DisconnectMessage on the server, which eventually calls virtual OnServerDisconnect.  This is typically the place to override if the server needs to save player data.  Host client doesn't do that.
To Reproduce
Steps to reproduce the behavior:

Enable Debug Logging in Network Manager of any example
Play as LAN Host, then click Stop
BUG Observe in log that OnServerDisconnect isn't fired

Expected behavior
OnServerDisconnect should fire, as that's the typical override where player data would be saved to a server-side data store for all players
Desktop (please complete the following information):

Mirror branch: master

Additional context
This is StopHost today
public void StopHost()
{
    OnStopHost();
    StopServer();
    StopClient();
}

First, I think those are out of order: we should unwind the client before tearing down the server.
Second, switching the order doesn't cure the problem, OnServerDisconnect is still never reached.
We have code for the special case for starting up a Host client, and I suspect we'll need a counterpart for that to taking the host down before taking the server down.

nice find

server-only + client, client disconnects: OnServerDisconnect(client) is called
server-only + client, server stops: OnServerDisconnect(client) is called
host + client, client disconnects: OnServerDisconnect(client) is called
host + client, host stops: OnServerDisconnect(client) is called
host, host stops: not called

OnServerDisconnect call stack when it works:
        ```
        NetMan:OnServerDisconnect(NetworkConnection) (at Assets/Mirror/NetMan.cs:10)
        Mirror.NetworkManager:OnServerDisconnectInternal(NetworkConnection, DisconnectMessage) (at Assets/Mirror/Runtime/NetworkManager.cs:1096)
        Mirror.<>c__DisplayClass6_0`2:<MessageHandler>b__0(NetworkConnection, NetworkReader, Int32) (at Assets/Mirror/Runtime/MessagePacker.cs:144)
        Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:219)
        Mirror.NetworkConnection:InvokeHandler(DisconnectMessage, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:247)
        Mirror.NetworkServer:OnDisconnected(NetworkConnection) (at Assets/Mirror/Runtime/NetworkServer.cs:492)
        Mirror.NetworkServer:OnDisconnected(Int32) (at Assets/Mirror/Runtime/NetworkServer.cs:486)
        UnityEngine.Events.UnityEvent`1:Invoke(Int32)
        Mirror.TelepathyTransport:ProcessServerMessage() (at Assets/Mirror/Runtime/Transport/TelepathyTransport.cs:162)
        Mirror.TelepathyTransport:LateUpdate() (at Assets/Mirror/Runtime/Transport/TelepathyTransport.cs:121)
        ```

when connecting a host, StartHostClient() calls NetworkClient.ConnectLocalServer(), which manually invokes the Connect message:
            NetworkServer.OnConnected(NetworkServer.localConnection);
            NetworkServer.localConnection.Send(new ConnectMessage());

we need to do the same in stophost for disconnected


Esc/clear on a fullscreened instance un-fullscreens

Should probably use IPC to ask electron to fullscreen, or just stick to F11 and don't override

Partial resolution to use native F11 implemented.


add travis for arduino/esp8266

This add travis jobs for the following combination of arduino and esp8266 cores:

Arduino
ESP8266

1.6.8
2.1.0

1.6.8
2.2.0-rc1

nightly
master

This will hopefully helps to to catch future breakage.
Fixes #56.

Merging, since this pass with stable.


Installer does not fall back to non-sudo installation

A run of the Linuxbrew install command promises to fallback to $HOME/.linuxbrew. But it does not. I am on a RHEL6 machine. Could it be that the sudo test in the install script gives a false positive?
$ sh -c "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/install/master/install.sh)"

The output is:
==> This script will install:
/home/linuxbrew/.linuxbrew/bin/brew
/home/linuxbrew/.linuxbrew/share/doc/homebrew
/home/linuxbrew/.linuxbrew/share/man/man1/brew.1
/home/linuxbrew/.linuxbrew/share/zsh/site-functions/_brew
/home/linuxbrew/.linuxbrew/etc/bash_completion.d/brew
/home/kmonisit/.cache/Homebrew/
/home/linuxbrew/.linuxbrew/Homebrew
==> The following new directories will be created:
/home/linuxbrew/.linuxbrew/bin
/home/linuxbrew/.linuxbrew/etc
/home/linuxbrew/.linuxbrew/include
/home/linuxbrew/.linuxbrew/lib
/home/linuxbrew/.linuxbrew/sbin
/home/linuxbrew/.linuxbrew/share
/home/linuxbrew/.linuxbrew/var
/home/linuxbrew/.linuxbrew/opt
/home/linuxbrew/.linuxbrew/share/zsh
/home/linuxbrew/.linuxbrew/share/zsh/site-functions
/home/linuxbrew/.linuxbrew/Cellar
/home/linuxbrew/.linuxbrew/Caskroom
/home/linuxbrew/.linuxbrew/Homebrew
/home/linuxbrew/.linuxbrew/Frameworks

Press RETURN to continue or any other key to abort
==> /usr/bin/sudo /bin/mkdir -p /home/linuxbrew/.linuxbrew
[sudo] password for kmonisit:
Sorry, try again.
[sudo] password for kmonisit:
Sorry, try again.
[sudo] password for kmonisit:
Sorry, try again.

Here's the relevant code:
https://github.com/Linuxbrew/install/blob/7d3b60c1e3dc1efcf902d1da932639f517813221/install#L94-L99
What does the following output:
sudo -v
echo $?

If all else fails, you can try these alternative installation instructions: https://docs.brew.sh/Linuxbrew#alternative-installation

This PR (in progress) was meant to address this issue: https://github.com/Linuxbrew/install/pull/47

$ sudo -v
$ echo $?
0
$ sudo -l mkdir
~❯ echo $?
1

So sudo -l mkdir throws a false positive as far as the installer is concerned?

sudo -v is saying that you do have sudo access, without needing a password. It appears to be wrong though, because sudo -l mkdir is saying that you do not have sudo access. Do you have sudo access?

No I do not have sudo access.

For now then, use the alternative installation instructions: https://docs.brew.sh/Linuxbrew#alternative-installation
PR #47 should hopefully address this issue when it's merged.

PR https://github.com/Linuxbrew/install/pull/47 has been merged. The usual installation instructions should work for you now. Would you be able to test it for us?

Consider installing Linuxbrew in /home/linuxbrew/.linuxbrew/ if possible so that you can use precompiled binary packages (known as bottles) for non-relocatable formula like util-linux. If it's an option for you, you could open a ticket with your information systems department to ask that they create a linuxbrew role account with home directory /home/linuxbrew.
The precompiled binary bottles of non-relocatable bottles can only be used if you install in /home/linuxbrew/.linuxbrew, otherwise they have to be built from source. See the documentation below. On macOS the default installation directory is /usr/local. On Linux the default installation directory is /home/linuxbrew/.linuxbrew.

http://docs.brew.sh/Installation.html#alternative-installs
http://docs.brew.sh/FAQ.html#why-do-you-compile-everything
http://docs.brew.sh/Bottles.html#cellar-cellar

PR #47 has been merged. The usual installation instructions should work for you now. Would you be able to test it for us?

I just tested this on a fresh CentOS 6.10 virtual machine. It will now fall back to $HOME/.linuxbrew installation.

Glad to hear it. Thanks for following up, Kit.

Somehow this does not work for me. I don't know if I am just doing something wrong, or that it is because I have something different with my machine, or that some other commit made it stopped working.
Executing:
 sh -c "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/install/master/install.sh)"

Error:
Failed during: /usr/bin/sudo /bin/mkdir -p /home/linuxbrew/.linuxbrew

Tried both pressing return three times and C-D.
MX Linux 19 (Debian 10).

What's the output of running /usr/bin/sudo /bin/mkdir -p /home/linuxbrew/.linuxbrew interactively at the command line?

Well, first I get:
[sudo] password for hielke:

Then I hit C-D
and get:
sudo: no password was provided

Exit code 1.
What do you check for it to fail?

I think I understand what is happening. You are checking sudo -l mkdir to check if I am allowed to run sudo. I am allowed to run sudo, but I don't want to install linuxbrew with the sudo rights. (I just don't like that.)
So, it seems almost like a design choice that whenever a user has sudo rights, but decides to not grant linuxbrew the sudo rights it just refused to install. Is this indeed intended?

So, I looked at the code and some related issues. It seems there are two tests sudo -l and sudo -v and it seems that picking one will not cover all cases, as sometimes the on succeeds when it should not and sometimes the other succeeds when it should not.
I would therefor suggest to use both and only skip the prompt about the different ways of installation if both succeed. If one or the other fails, it should prompt for the password with the different options.
If you think this is a good idea. I can see if I can make a PR.

I am allowed to run sudo, but I don't want to install linuxbrew with the sudo rights. (I just don't like that.)

I strongly recommend installing Homebrew in its default installation directory of /home/linuxbrew/.linuxbrew. You can create the directory /home/linuxbrew yourself if you like, and ensure that your current user has permissions to write to it, and then the installer will not need sudo to run. The following is copy-pasted informational text as to why the standard installation directory is preferred.
Consider installing Linuxbrew in /home/linuxbrew/.linuxbrew/ if possible so that you can use precompiled binary packages (known as bottles) for non-relocatable formula like util-linux.
Another possible workaround for you is brew install --force-bottle util-linux, but no promises.
If it's an option for you, you could open a ticket with your information systems department to ask that they create a linuxbrew role account with home directory /home/linuxbrew.
The precompiled binary bottles of non-relocatable bottles can only be used if you install in /home/linuxbrew/.linuxbrew, otherwise they have to be built from source. See the documentation below. On macOS the default installation directory is /usr/local. On Linux the default installation directory is /home/linuxbrew/.linuxbrew.

http://docs.brew.sh/Installation.html#alternative-installs
http://docs.brew.sh/FAQ.html#why-do-you-compile-everything
http://docs.brew.sh/Bottles.html#cellar-cellar

It's just a matter of principle. It's good to be informed, but just give a user a choice.
I have linuxbrew installed on my own pc and on a shared server. I don't have sudo rights on the shared server, so I install in the home directory. While I do have sudo rights on my own pc, I don't want to deviate from the way I organize my stuff on the server. If there is a difference I might face unexpected surprises if something worked on my pc, but not on the server.
I don't mind if you decide differently and keep it the way it is now, but this is just my perspective.

Pressing Ctrl-D at the sudo password prompt is meant to install in the user's home directory. If that doesn't work for you, and if you're able to find a fix, a PR to fix it would be most welcome.


train it on custom dataset

Hi , how can we train it on custom dataset ? please suggest

I want to know as well, please help me

Same, could you please le us know ?


Broken Anthropic System Message for Amazon Bedrock

Describe the bug
Similarly to #2123, the current message parsing logic does not extract the system message from the message list to be used as a separate parameter.
To reproduce, use the existing example from examples/claude-vs-gpt-image/promptfooconfig.yaml with the bedrock:anthropic.claude-3-sonnet-20240229-v1:0 provider.
The associated API call returns the following error:
API call error: ValidationException: Malformed input request: #: subject must not be valid against schema {"required":["messages"]}#/messages/0/role: system is not a  valid enum value, please reformat your input and try again.

System information (please complete the following information):

Promptfoo version: 0.96.1

Hi @maximcherny, thanks for catching this, and apologies for the disruption! I just issued a fix in release 0.96.2. Could you give it a try and let me know if it resolves the issue on your end? Feel free to reach out if you notice anything else or need further support.

Thanks so much @mldangelo and apologies for the delay.
If I test with the latest HEAD at 05f324d6deb69581f93bab59e3a27231532f788e and only this provider bedrock:anthropic.claude-3-sonnet-20240229-v1:0 I am now getting the following error:
[FAIL] Error: OpenAI API key is not set. Set the OPENAI_API_KEY environment variable or add `apiKey` to the provider config.

npm run local -- --version
><EMAIL_ADDRESS>local
> ts-node --cwdMode --transpileOnly src/main.ts --version

0.97.0

I am not sure why this config setting would be required for the provider I am using?

Correction - if I change the defaultTest provider for the llm-rubric assertion everything works as expected, as per the troubleshooting docs, thanks again for fixing this.


secure login before firefox start

I don't know if it's really an issue but as I use this container with a reverse proxy (at work), I wanted to know if it's possible to secure the access with login and password...
Indeed, if I leave the container as it is, anyone can access to "my" firefox via the url, it's not very "safe"...?
Thanks

I guess this could be achieved by your reverse proxy ?  Which one are you using ?

The one integrated on DSM Synology...

You could set a VNC password (https://github.com/jlesage/docker-firefox#vnc-password), but that's not very secure (password only, limited to 8 characters).
If the reverse proxy integrated in Synology doesn't allow you to set a username/password, I would recommend that you try to use another one.

Ok thanks, i will try vnc pwd...

Closing this issue.  Please reopen if needed.


i18n(ko-KR): update configuration.mdx

Description

update configuration.mdx
#1874

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
reference/configuration.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[Improve] Improve  lark alarm docs

When setting the flying book alarm, an error was reported, indicating that the url was incorrect,As shown in the figure：

We run the local environment, debug the code, and find that the larkProxyUrl variable is getting a null value. Null values are resolved by setting the property streampark.proxy.lark-url

Go to our yaml file and add streampark.proxy.lark-url to compile and debug the flybook alarm again. Messages can be sent normally.

Alarm information from the flying book Group test

@caicancai

Thank you for your contribution. LGTM+1
cc @wolfboys @RocMarshal


[Garden] Bridge task topics

Bridged a few more topics from gz to ROS2:
/vrx/contacts
/vrx/stationkeeping/goal
/vrx/stationkeeping/mean_pose_error
/vrx/stationkeeping/pose_error
/vrx/task/info

Data should be printed when you do a ros2 topic echo on these topics. For /vrx/contacts, I tested by manually moving the wamv to collide with the buoys.

The station keeping topics are only relevant when the station keeping task is running. Is there any way to enable these topics only when the StationKeepingScoringPlugin is running?

When does the station keeping task start running? Do we want to hide topics completely and launch the bridge process only when the task starts?

The station keeping topics are only relevant when the station keeping task is running. Is there any way to enable these topics only when the StationKeepingScoringPlugin is running?

When does the station keeping task start running? Do we want to hide topics completely and launch the bridge process only when the task starts?

Oh, I meant that there might be some worlds where the station keeping plugin isn't running. Then, we shouldn't see any station keeping topics.

ohh I see. One idea is to keep track of the worlds in the python script and only bring up the bridges if that world has station keeping task. I can take a look at this

ohh I see. One idea is to keep track of the worlds in the python script and only bring up the bridges if that world has station keeping task. I can take a look at this

I think that will work, we'll need to modify the worlds list when running the competitions because we use extra worlds that aren't public, but I think it sounds reasonable.

Part of #514 .


Error when updating bandwidth under Harvest Configuration

Hi,
I recently test run version 1.6.2 and facing some issues. One of the issue is that I am getting NullPointer Error whenever I updating the Harvest Configuration > Bandwidth. Mind helping me troubleshoot this problem ?
wct-core..txt

Hi,
Sure, was this a fresh install or an upgrade from 1.6.1 or 1.6.0? And does the HEATMAP_CONFIG table exist in your db?
Cheers,
Ben

Hi obrienben,
It is a fresh install of version 1.6.2. The HEATMAP_CONFIG table do exist. I attach here with my DB in mysql. Also note that I remember manually adding some of the extra field that was missing from the original sql file from Github according to the Data Dictionary pdf to solve a lot of the java error on missing field issue.
calvin_db_wct.sql.txt

Hi Calvin,
Looking at the database dump you attached, there is no data in the HEATMAP_CONFIG table. At the least there should be three rows which get added from the following file during setup https://github.com/DIA-NZ/webcurator/blob/master/wct-core/db/upgrade/upgrade-mysql-1_6-to-1_6_1.sql.
Can you try renaming your database and re-creating a new one, and running the following scripts, in this order (assuming mysql):

wct-core/db/setup/mysql-create-wct.sql

wct-core/db/sql/wct-schema-1_6-mysql.sql

wct-core/db/sq/wct-indexes-1_6-mysql.sql

wct-core/db/sql/wct-mysql-bootstrap.sql

wct-core/db/sql/wct-qa-data-1_6-mysql.sql

wct-core/db/upgrade/upgrade-mysql-1_6-to-1_6_1.sql

wct-core/db/sql/wct-schema-grants-1_6_1-mysql.sql

Which setup scripts to run has needed better clarity for a while now in the documentation

Hi obrienben,
Thanks for the walkthrough. The error no longer appears.


STORM-2224 Exposed a method to override in computing the field from given tuple in FieldSelector

@harshach Pinging for review.

+1

+1

This PR is merged into master and 1.x-branch.


[Bug]: dialog breaks focus flow if something is rendered on input change

Environment
Radix Vue version: 1.1.3

Link to minimal reproduction
https://codesandbox.io/p/sandbox/radix-vue-select-forked-y4j783?file=/src/App.vue:28,38
Steps to reproduce

Open dialog
Type something in the input
Press Tab
Dialog content is focused

Describe the bug
I have input and icon after it that should be shown on input change.
If you type something in the input and want to focus the next input by pressing Tab - the focus switches to the dialog content but not input.
Expected behavior
Next input should be focused when you press Tab.
Conext & Screenshots (if applicable)
No response

It happens here:

Thanks for the issue @enkot ! Yeah the MutationObserver is the culprit here. I will look into this, and see if I can find a proper solution for this 😁

@zernonia Thanks for the quick feedback and fix 💪

No problem @enkot ! thanks for logging the issue! Truly appreciate it!! ❤


feat(raw): allow folder creation inside user folder

Fix [ANT-2072]

The issue we have is that we don't have commands to create/delete folders and also to delete a file.
I think if we want to support these endpoints for variants, I have no other choice than creating a command AlterFileSystem or something like this that allows this


nfts.AlreadyExists drop page mint

not sure if already reported, this still shows

yeah, the nft did not mint
did not happen on production, but on canary

@exezbcz how about try again? and give me the address, will check

Could not reproduce

@preschian

did not happen on production, but on canary

tried on production
its hard to reproduce, cannot find a way how to make it consistently appear
address: 1cQB9WUTtwyH3H4Ksn7pLfJvMLCxtzQHbUNhZtVBasoX3X9

same

/ahk/drops/reflection
DYc9cY7q7UA3Rq97HtiobrLNbMbZgepATJtn3fzPE2jf5v6

For @hassnian case. Db and on-chain data were different. It seems like you will be stuck to mint NFT with sn 32. Could you try again on Canary and monitor the request parameters to fxart? I will edit it on the DB side if it is still stuck. But I'm not sure what the root cause is. Meanwhile, 32 is already claimed: https://canary.kodadot.xyz/ahk/gallery/377-32.

For @exezbcz, could you try again on Canary? I assume this one is a fields drop? Next mint should get one of these IDs.


Stop fetching allready fetched protos with same version again.

Why is it issue:

It can cause issues / slowdown / need for SSH key in CI

Example / reproducer:
λ protofetch fetch -f
[2022-07-29T11:44:55Z WARN  protofetch::cli] Git user Zdeněk Hřebíček found but no password found for git auth, which is used for fetching via https. If you are using https please pass as command line, GIT_PASSWORD env variable or add to git config.
[2022-07-29T11:44:55Z INFO  protofetch::fetch] Resolving git@github.com:open-telemetry/opentelemetry-proto
[2022-07-29T11:44:58Z INFO  protofetch::fetch] Locking git@github.com:open-telemetry/opentelemetry-proto at Arbitrary { revision: "v0.18.0" }
[2022-07-29T11:44:58Z INFO  protofetch::cli::command_handlers] Wrote lockfile to protofetch.lock
[2022-07-29T11:44:58Z INFO  protofetch::fetch] Fetching dependencies source files...
[2022-07-29T11:44:58Z INFO  protofetch::proto] Copying proto files from logs-gateway descriptor...

λ protofetch fetch
[2022-07-29T11:45:00Z WARN  protofetch::cli] Git user Zdeněk Hřebíček found but no password found for git auth, which is used for fetching via https. If you are using https please pass as command line, GIT_PASSWORD env variable or add to git config.
[2022-07-29T11:45:00Z INFO  protofetch::fetch] Fetching dependencies source files...
[2022-07-29T11:45:00Z INFO  protofetch::proto] Copying proto files from logs-gateway descriptor...

Issues it that it always runs this:
[2022-07-29T11:44:58Z INFO  protofetch::fetch] Fetching dependencies source files...

The issue is non-existent we just need better documentation and logging.
Reproduced it is ok
λ protofetch fetch -f
[2022-07-29T11:56:28Z WARN  protofetch::cli] Git user Zdeněk Hřebíček found but no password found for git auth, which is used for fetching via https. If you are using https please pass as command line, GIT_PASSWORD env variable or add to git config.
[2022-07-29T11:56:28Z INFO  protofetch::fetch] Resolving git@github.com:coralogix/cx-api-tags
[2022-07-29T11:56:40Z ERROR protofetch] Error while fetching repo from cache: Git error: Failed to retrieve list of SSH authentication methods: Failed getting response; class=Ssh (23); code=Auth (-16)
λ protofetch fetch
[2022-07-29T11:57:00Z WARN  protofetch::cli] Git user Zdeněk Hřebíček found but no password found for git auth, which is used for fetching via https. If you are using https please pass as command line, GIT_PASSWORD env variable or add to git config.
[2022-07-29T11:57:00Z INFO  protofetch::fetch] Fetching dependencies source files...
[2022-07-29T11:57:00Z INFO  protofetch::proto] Copying proto files from eng-svc-tags-api descriptor...


fix(boilerplate): TS version lock

Describe your PR

Closes #2564 until TS Node fixes their issue with TypeScript 5.3.2
We know TS 5.2.2 worked fine as that's the version we tested Ignite 9 on for months

:tada: This PR is included in version 9.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: