Added Primary Color to MatSelect Label

Before

After

The icon of the select still need to change the color (or not), but this should be revised in the material design guide lines.
I just didn't do it because the "icon" is an image from a svg and I have no ideia how to change the color of that

Hi @EduVencovsky thank you for pull request. Very nice you go through the theming bugs! 👏 Looks good but I think it would be nice to fix the "arrow" while we are at it.
Decoding the inline SVG it looks like this.
url("data:image/svg xml,<svg width="10px" height="5px" viewBox="7 10 10 5" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <polygon id="Shape" stroke="none" fill="#6200ee" fill-rule="evenodd" opacity="1" points="7 10 12 15 17 10"></polygon>
</svg>") no-repeat center
´´´
I'm not sure the best way to do this, either if we manipulate the fill value based on the current theme or try to find a font to replace it so we can style with css. Suggestions?

@lindespang the first thing I thought was to just change the fill color, but it would be better if there was a way to change the color this without changing the url string. We could place an icon there too, but then it would be a little different material design guide lines.


Category Page & Workers Homepage

What is the change?
Category Screen UI and Workers Home page Screen
Related issue?
issue: #33
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this ([x]).

[x] I've checked there aren't other open Pull Requests for the same update/change?

[x] I've made corresponding changes to the documentation?

[x] My submission doesn't break any existing feature.

[x] I've tested this code locally before submission?

Screenshots:

@msramesh2k1 Good work!!


Upgraded OTEL libraries and examples

[X] Do only one thing
[X] Non breaking API changes
[X] Tested

What did this pull request do?

Upgraded all libraries
Upgrade examples to Go 1.20
Fixed OTEL issues with newest OTEL libraries
Executed examples

User Case Description

Allowing it to work with other OTEL changes

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

So I am not as used to Github Actions but when I run these commands it works fine but in Github Actions appears to fail:
go vet -stdmethods=false $(go list ./...)
  go vet -stdmethods=false $(go list ./...)
  go install<EMAIL_ADDRESS>  test -z "$(gofumpt -l -extra .)"

Have you seen this before or do you see an actual error that I have not been able to see so far?

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

So I am not as used to Github Actions but when I run these commands it works fine but in Github Actions appears to fail:
go vet -stdmethods=false $(go list ./...)
  go vet -stdmethods=false $(go list ./...)
  go install<EMAIL_ADDRESS>  test -z "$(gofumpt -l -extra .)"

Have you seen this before or do you see an actual error that I have not been able to see so far?

I will check it later.

@Ahbrown41 It was just a simple formatting issue, so I went ahead and fixed it directly on your branch. Thanks for your PR:D.

Can we please get a release of this? Without users of this are stranded on outdated otel versions.

Brilliant, thank you!! :heart_decoration:


Add basic REST API usage example to README.md

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Please sign off your commit (see CONTRIBUTING.md)

Signed-off-by: Daniel Middleton<EMAIL_ADDRESS>


Removing X objects from redis server with jedis client using the same prefix key as pattern

Hello!
What is the best practice of deleting\removing many object\values from the redis server using jedis client?
I have a fix prefix for my keys, is there a pattern usage for del command?
Thanks in advance,
Lavi
Jedis version:
2.6.3
Redis version:
3.0.6
Java version:
1.6

Please address this to the mailing list http://groups.google.com/group/jedis_redis


Title: Styling Discord clone

Is your feature request related to a problem? Please describe.
The buttons are not styled properly. They lack padding. Also the color isnt matching the real app.
Describe the solution you'd like.
I'd style the buttons properly and add some padding to them. Also i'll find the best color matching the real app.
Describe alternatives you've considered.
No response
Add any other context or screenshots about the feature request here.
No response

assigned to u @Adbnemesis


Cannot sort controllers

I have 3 controllers implemented in 2 projects (one is a shared library, another is an ASP.NET Core application implementing a REST API):
In the shared (PingController) library:

Xxx.Yyy.Common.Controllers.Ping.PingController

In the REST API (Demo) application:

Xxx.Yyy.Microservices.Demo.Controllers.HealthChecksController
Xxx.Yyy.Microservices.Demo.Controllers.SamplesController

The Demo application references the PingController library, so there are 3 controllers in the REST API. I want them to be sorted by (1) controller name, (2) relative route, and (3) HTTP verb/method as:

HealthChecks
Ping
Samples

In Swagger initialization I use:
options.OrderActionsBy(
    apiDesc =>
        $"{apiDesc.ActionDescriptor.RouteValues["controller"]}_{apiDesc.RelativePath}_{apiDesc.HttpMethod}"
);

However, while the endpoint methods within the controllers are sorted fine, the controllers are displayed as:

Not sure if this is a bug or if there is something I'm not doing right, but I'm following the example that should be working.
Environment:

Visual Studio 2022
.NET 8
Swashbuckle.AspNetCore 6.5.0
Swashbuckle.AspNetCore.Annotations 6.5.0
Swashbuckle.AspNetCore.Filters 8.0.1
Unchase.Swashbuckle.AspNetCore.Extensions 2.7.1.

@changweihua A problem with this approach is that I would need to redefine the ApiControllerTagDescriptions class for every microservice project (since the names of the controllers would be different). Then you'd need to always remember to keep them in sync and once someone decides to rename a controller, add a new one, or remove an existing one, they'd need to remember to update this class (and I'm sure it will be forgotten). Also, I'm building a common framework that does the startup initialization including Swagger setup, and this framework would need to receive the controller names from the project using it, and it'll be too clunky. Don't want to have such tight coupling between the models. I have a feeling that the OrderActionsBy should be working and if it's not because of a bug, maybe someone can see if it can get fixed. Not sorted controllers is not the end of the world, but if would be nice if this can get fixed.

I think OrderActionsBy only works within a controller/tag group and that the top-level is sorted by controller or tag name. You can also try TagActionsBy instead of a filter, but be advised that a single tag will replace the controller name, and multiple tags will cause the controller to be duplicated in the UI.
I think the docs are out of date w/r/t how swagger-ui actually does it's sorting as it says it sorts both groups and within groups and that it'd effect the group order, yet I too have seen this doesn't jive and had to customize the behavior (see below). Reading through issues and commits on the swagger-ui github, I think it may have once worked as expected but that they changed the default behavior at some point.
If you are only worried about your UI (and not someone else's who has loaded your spec, nor the order in third party tools you pass the spec to) you can use additional properties on the SwaggerUIOptions.ConfigObject to control how the UI does the sorting
// controller or tag level (top level group in UI)
options.ConfigObject.AdditionalItems["tagsSorter"] = "alpha";
// within a controller, operations are the endpoints. You may not need this one
options.ConfigObject.AdditionalItems["operationsSorter"] = "alpha";

"alpha" is alphabetic (by path or tag, applicable to both settings)
"method" is by http method (valid for operations only)
default/omitted is default order from spec doc

You can also supply a javascript function if embedding the UI yourself which tells me there might be a way to do it here if you use a stringified function similar to the interceptor properties, or perhaps inject a JS file with the function and pass the function's name via the property. That's just a guess though, never tried it myself.
You can see the built-in sorters here

@pinkfloydx33 How and where do you call options.ConfigObject.AdditionalItems? ConfigOptions does not seem to appear inside of the Swagger config call:
services.AddSwaggerGen(options =>
{options =>
{
    options.SwaggerDoc(...);
    options.EnableAnnotaztions();
    ...
}
});

It's on the configuration for SwaggerUIOptions which you can either use when calling UseSwagger/MapSwagger or on its own as services.Configure<SwaggerUIOptions>(o =>...)

Ah, sweet. I can't believe it, but it worked!!! Thank you so much. If anyone is interested, the code is:
services.Configure<SwaggerUIOptions>(options =>
{
    // Controller or tag level (top level group in UI)
    options.ConfigObject.AdditionalItems["tagsSorter"] = "alpha";

    // Within a controller, operations are the endpoints. You may not need this one
    options.ConfigObject.AdditionalItems["operationsSorter"] = "alpha";
});


Add additional properties handling

info on additional properties
https://github.com/OAI/OpenAPI-Specification/issues/668
additionalProperties	Schema Object	For an object, if this is given, in addition to the properties defined in properties all other property names are allowed. Their values must each match the schema object given here. If this is not given, no other properties than those defined in properties are allowed.
i also added the x-example (doesn't seem to hurt)

I fixed the tests on master. So just update your branch and it should be good.


Allow orb to properly parse pondertext

resolves the issue brought up here:
https://kolmafia.us/threads/orb-pondering-prefix-trimming.27561/
by accounting for the "some" and "the" articles, as well as providing for support for monsters like "the gunk" whose names unfortunately begin with an article.

Worth noting that the monster manual now includes the article for every monster in HTML comments - might be something we could build into a tool for this sort of thing

I was about to post a thread asking for a monster.article proxy record;
manuel will make spading this easier
On Mon, May 23, 2022, 3:54 PM Samuel Gaus @.***> wrote:

Worth noting that the monster manual now includes the article for every
monster in HTML comments - might be something we could build into a tool
for this sort of thing
—
Reply to this email directly, view it on GitHub
https://github.com/kolmafia/kolmafia/pull/772#issuecomment-1135079561,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASZNQVI6ASMEEWDOC4IFIT3VLPO6PANCNFSM5WUTWRDA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Handle encrypted NameId (EncryptedId) on LogoutRequest

https://github.com/bergie/passport-saml/pull/197 seems stale so I took a stab at fixing the issue here. This patch handles encrypted NameId on idp -> sp LogoutRequests. Fixes #196

@josecolella Could you peer-review this?

@siren Could you please add a test for this? Also, the head of master has all its tests cleaned up, so if you rebase or merge master into your branch, everything should work.

this is now obsolete, see https://github.com/bergie/passport-saml/pull/408


crypto:hmac is being removed in Erlang 24

This library is failing  to work on Erlang 24.
Erlang 24 which is released in and is removing crypto:hmac which this project uses.
This project should update to use the new crypto api so projects depending on it don't fail to build.
Here is the notes from Erlang 24 http://erlang.org/doc/general_info/scheduled_for_removal.html#otp-24
This is how plug_crypto handled this situation - https://github.com/elixir-plug/plug_crypto/pull/20/files

I see the code is trying too cover for this:
  Create an HMAC-SHA256 for `key` and `message`.
  """
  if System.otp_release() >= "22" do
    def hmac_sha256(key, message) do
      :crypto.mac(:hmac, :sha256, key, message)
    end
  else
    def hmac_sha256(key, message) do
      :crypto.hmac(:sha256, key, message)
    end
  end

but for some reason I'm seeing it fail 🤔 will try to look into it and share any findings here.

Oh I see,  that was not cut in the new version yet: https://github.com/aws-beam/aws-elixir/blob/v0.7.0/lib/aws/util.ex#L7

Anyone out there going through the same thing, this should get the job done:
{:aws, git: "https://github.com/aws-beam/aws-elixir.git", branch: "master"},


read serial number, probe device on startup, improve timing, ...

I made a number of changes, the service is working great for me so far:

reading the manufacturer and the serial number

the hex representation of the serial number actually corresponds to the meter number that is printed on my meter, but I did not want to assume this for all devices

the "connection" string now also contains the port
improved the timing

it would have been possible to end up with an endless loop, the timeout of receiving messages is now checked at the start of the loop
when there are no bytes available from the serial port, the loop is restarted immediately instead of reading 0 bytes and parsing the same bytes again

read total meter value and report it as Ac/Energy/Forward

Reverse not implemented because I don't know which field it would be - my meter doesn't report it

fixed Ac/Voltage reporting
removed unused setup entries and added some default for values, especially report Energy/ values as None as to not mess up systems evaluating the value when it is suddenly reported as 0

thank you, merged.


Login and installations

This is based on investigating the website requests.

Very nice ! thank you ! now lets wait for max to come, or somebody can make pypi package and redirect it for a some time :>

I have edited airzone-homeassistant from max, but i have this errors when i try to list zones. It is giving None when i list zones from system/site:
2021-08-22 14:06:07 ERROR (SyncWorker_2) [custom_components.airzonecloud.climate] Site(name=Home, status=None)
2021-08-22 14:06:07 ERROR (SyncWorker_2) [custom_components.airzonecloud.climate] System(name=Sistema 2, mode=None, eco=None, velocity=None, airflow=None)
2021-08-22 14:06:07 ERROR (SyncWorker_2) [custom_components.airzonecloud.climate] None
2021-08-22 14:06:07 ERROR (MainThread) [homeassistant.components.climate] Error while setting up airzonecloud platform for climate
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
await asyncio.shield(task)
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/airzonecloud/climate.py", line 63, in setup_platform
entities.append(AirzonecloudZone(zone))
File "/config/custom_components/airzonecloud/climate.py", line 76, in init
print("init zone {} ({})".format(self.name, self.unique_id))
File "/config/custom_components/airzonecloud/climate.py", line 87, in name
return "{} - {}".format(self._azc_zone.system.name, self._azc_zone.name)
AttributeError: 'NoneType' object has no attribute 'system'

Hi, do we have any news regarded to this PR? Was it working? Is it there an available package with the changes?

https://github.com/max13fr/AirzoneCloud/issues/7#issuecomment-908217084

AFAIK your comment is related to the Local API, this is for Cloud, they are different things, isn't it?

Hello,
Can someone confirm this branch works ok with the latest AirZone API that was released 16th of November?
Kind Regards,

Hello,
No unfortunatelly, they changed the objects tree & call API are all differents, now it's Installation -> Group -> Device.
I'm currently writing an alpha version to use the new API (but my time is lacking as I need to work on free time the night & the weekend).
Max

that's good, thanks for it. I'm happy to support you if you want me to do any testing.
Checked with technical support today and they do not have in mind to have an 'official' home assistant integration, at least is not in their roadmap. The fact that Hass is 'open-source' kind of challenge the integration.
cheers!

Just released the new version using the new Airzone API : https://developers.airzonecloud.com/docs/web-api/
You can try it, just set your email & password in config_test.json then try (inspired by this PR) :
./test.py

It should list all your installations, groups and devices.
I close this PR as it's outdated.
Max


App not getting to sessionAuthenticationSucceeded on initial load of app

Something strange is going on where when I first load the app, sign in, it does not hit the sessionAuthenticationSucceeded method in my ApplicationRoute. It should take me to a route called /users/home but its not reaching the transition. Now if I manually enter the url in the browser /users/home, log out, and log back in, the transition works.
Anyone have any idea why this is happening?

The sessionAuthenticationSucceeded event is only triggered when the session goes from unauthenticated to authenticated after the app has started. When the app already starts with an authenticated session, the event is not triggered.

The app doesn't have an authenticated session when it's started, so it's going from unauthenticated to authenticated.

Hm, can you add some info to reproduce the problem?

Authenticate method in authenticators/custom.js:
  authenticate: function(credentials) {   	return new Ember.RSVP.Promise(function (resolve, reject){   		var loginPromise = Ember.$.post('/login', {'email':credentials.identification, 'password':credentials.password} );   		loginPromise.then(function (data){   			resolve({   				token: data.user.api_key,   				userData: data.user   			});   		}, function(error){   			reject(error);   		});   	});   }
Application Route:
var ApplicationRoute = Ember.Route.extend(ApplicationRouteMixin, {   actions: {     sessionAuthenticationSucceeded: function() {       this.transitionTo('users.home');     } } });
Login Controller:
import LoginControllerMixin from 'simple-auth/mixins/login-controller-mixin'; export default Ember.ObjectController.extend(LoginControllerMixin, { 	authenticator: 'authenticator:custom', 	needs: ['application'], 	model: {} });
environment.js:
ENV['simple-auth'] = { authenticationRoute: 'index', session: 'session:custom', routeAfterAuthentication: 'users.home'}
Sorry, I don't know how to format blocks of code on github

I feel like it's a pretty standard set up of simple-auth. Nothing out of the ordinary.

Any word on this?

Are you using local storage?
ENV['simple-auth'] = {
  store: 'simple-auth-session-store:local-storage'
}

If so, I have seen a similar issue with an iPhone 5 w/ iOS7 mobile safari.  That browser is not HTML5 compatible and causes a JavaScript exception to be thrown when localStorage.setItem(this.key, data); is called.
try{
    localStorage.setItem("testKey","testValue)");
    // localStorage is supported
} catch (e){
    // private mode identified... - getting QUOTA_EXCEEDED_ERR: DOM Exception 22
    isHTML5Compatible = false;
}

If the browser does not support local storage, you may want to try using cookies instead.
ENV['simple-auth'] = {
  store: 'simple-auth-session-store:cookie'
}

@marcoow What would be the best to make sure that a request made from an initializer fires after ESA (Devise) has setup the session? I've tried using after: ["simple-auth", "simple-auth-devise"] on the initializer but that doesn't work. As the sessionAuthenticationSucceeded event is not fired upon initial app start I can't use that as a hood either. Is there a proper way to do that?

@ur5us: When the session is authenticated on app startup, its isAuthenticated property should already be true after the 'simple-auth' initializer has run and thus requests should already have the Authorization header after both the 'simple-auth' and the 'simple-auth-devise' initializer have run.

@marcoow I thought so too but it doesn't work for me. Probably I'm doing something wrong but using after: ... seems to be straight forward.

In your initializer the session should be authenticated if it was successfully restored from a persisted session. If it's not, please open a new issue.

@marcoow I'll try to isolate it. Also, it looks like it works for a production build of Ember but not when running dev mode.

@ur5us: any updates on this?

@marcoow the reason is that this.trigger('sessionAuthenticationSucceeded'); in setup triggers the event on the session, and not on the ApplicationRoute.

Ah, my issue was that I had beforeModel defined on my ApplicationRoute and forgot to add this._super(transition);.

closing this, please reopen if there's still an issue.


Convert VSCode selection to visual mode selection

I know there's a way to go from visual mode selection to VSCode selection, but I was wondering if there's any command to go the other direction.  Having a command to convert a VSCode selection to a visual mode selection would make such a task straightforward

The fact it doesn't do this automatically basically makes this extension unusable for me.

This may be a duplicate of https://github.com/asvetliakov/vscode-neovim/issues/395 (though I grant that your title is better).
There is a PR open to (ostensibly) fix it, though it hasn't been merged yet.

Duplicate of #395

Since that issue is closed, no longer a duplicate.


export database data request

can i have an exported csv/textfile of your mongodb database for this project? i want to use it too. thx

Sure, but I have collected from https://sunnah.com/
I am not sure when I can manage time to get the backup and share with you. You can use their api or scrap.


Avoid segmentation fault when reconnecting to MG400 (which occurs only in debian package)

When packaging the ros2 packages of this repository and its mg400_node, mg400_node gets segmentation fault when reconnecting to MG400. There is no error at the first connection. In addition, this doesn't happen when building locally with colcon build.
The cause of this error is not clear yet, but to avoid this for now, this PR moves the steps of loading plugins etc (which causes the segmentation fault) from on_activate to on_configure and keep them even after disconnecting from MG400.

OK.
I'm going to fix it soon.


Obtaining field's object for displaying validation error message

I would like to do sync validation, but I have no ideas how to obtain the field's object
validate.js
const validate = (values) => {
    const errors = {};

    if (!values.firstName) {
        errors.firstName = 'Firstname is required';
    } else if (values.firstName.length < 5 || values.firstName.length > 10) {
        errors.firstName = 'Firstname must be between 5 - 10';
    }
    return errors;
}

export default validate;

SimpleReduxForm.js
import React, { Component } from 'react'
import { connect } from 'react-redux'
import { reduxForm, Field } from 'redux-form'
import validate from './validate'

const fields = [ 'firstName', 'lastName', 'age' ]

@reduxForm({
    form: 'simpleReduxForm',
    fields,
    validate
})
export default class SimpleReduxForm extends Component {
    render() {
        const { handleSubmit, invalid, pristine, submitting } = this.props
        const { fields } = this.props
        console.log(fields)
        return (

                <form onSubmit={ handleSubmit(this.handleFormSubmit) }>

                    <Field name="firstName" component="input" type="text" />
                    <Field name="lastName" component="input" type="text" />
                    <Field name="age" component="input" type="number" />

                    <input type="submit" value="Submit" disabled={ pristine || invalid || submitting }/>
                </form>

        )
    }
}

The output of console.log(fields) from the source code above as below

It's just an array not object

I have seen sample coding from the documentation as below but I have no ideas how to get mine to work
const { fields: { firstName, lastName } } = this.props

...
{ firstName.touched && firstName.error &&
{ firstName.error }
 }

Sample Coding

Please advise, thanks
P.S.  "redux-form": "^6.1.0"

Please read the docs and look at examples:
http://redux-form.com/6.0.5/examples/syncValidation/

Closing due to non response. Support lifecycle: read docs -> ask stack overflow questions (post here with link if you wish) -> gain understanding -> contribute your expertise :). Hoping you figured it out, but let us know if not :).


Condition for counter variable?

Hey,
I am using a counter variable for version numbers but I'm quite unhappy with the fact that the counter variable is increased for every single run of the pipeline, even pull request build validation runs.
Is it possible to use a condition for a counter variable e.g. that it is only increased for runs of the master branch or runs where the build reason isn't a pull request?
Cheers,
Robin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@RobinZergiebel Thanks for your question. While we look into changes to the article, consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@RobinZergiebel I think your best bet is to create a custom variable. Please see our FAQ. If that doesn't answer your question, I'd recommend posting in our Developer Community.


Update README.md

Fixed the handling of the searchParams return type and convert it from String to Number in order to increment it. Default to 0 if parameter not defined yet. The handling of the empty page String in the setSearchParams feels cleaner than initializing the page to 0, as the parameter is mostly used after the first page.

+1
I think this would be a good addition to the docs. Or at least indicate in the docs that a parseInt might be needed/ recommended.


Style/IfUnlessModifier funky autocorrect when if/unless modifier already exists

Autocorrect produces a bit of a weird result for IfUnlessModifier when an if/unless is already being used in the wrapped expression
if opts[:yield_in_batches]
  yield(batch) if batch.present?
end

$ rubocop --only IfUnlessModifier check.rb --auto-correct
$ cat check.rb
yield(batch) if batch.present? if opts[:yield_in_batches]

Seems like it compiles properly, but it would be nicer to combine the expressions if possible

Looks like this is handled by https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/nested_modifier.rb so closing

RuboCop 0.35.1 corrects the code to
yield(batch) if opts[:yield_in_batches] && batch.present?

Seems you're running an older version.

@jonas054 might be something with the parser version (I'm running 2.1.3 locally)

Oh I think it might be that I disabled https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/nested_modifier.rb so that isn't fixing things again after the first autocorrect

This conversation looks a bit strange now, because I deleted my comment (that @jbodah probably was running an older version) when I saw that he closed the issue himself.
Good that you resolved it, anyway!


BibTeX syntax: "%" is not a comment character

The percentage character is treated as inline comment in the current BibTeX syntax (see the percentage_comment  rule, the test entry and result). However it doesn't match BibTeX's behavior. The BibTeX doc (§4, item 14, p. 14) says:

LaTeX’s comment character ‘%’ is not a comment character in the database files.

And it's verified with the following example.
Biber treats percentage characters differently (see https://tex.stackexchange.com/a/262282/82731) but I think it's more reasonable to be compatible with traditional BibTeX.
A minimal example to reproduce the issue
main.tex
\documentclass{article}

\bibliographystyle{plain}

% \usepackage{biblatex}
% \addbibresource{test.bib}

\begin{document}

\cite{glasbook}

\bibliography{test}

% \printbibliography

\end{document}

test.bib
@book{glasbook,
  author  = {Glasserman, Paul},
  title   = {Monte {C}arlo %methods in
             financial engineering},
  series  = {Applications of Mathematics (New York)},
  %volume  = {53},
  note    = { Stochastic Modelling and Applied Probability},
  address = {New York},
  year    = {2004},
  pages   = {xiv+596},
  isbn    = {0-387-00451-3 {toto}},
  url     = {http://www.example.com/some-%AC-encoded-%2C-character}
}

BibTeX gives an error:
You're missing a field name---line 6 of file test.bib
 :
 :   %volume  = {53},

If the line %volume  = {53} is deleted, BibTeX produces the following into the .bbl file in which the commented } causes a unmatched brace error in the next LaTeX run.
\begin{thebibliography}{1}

\bibitem{glasbook}
Paul Glasserman.
\newblock {\em Monte {C}arlo %methods in financial engineering}.
\newblock Applications of Mathematics (New York). New York, 2004.
\newblock Stochastic Modelling and Applied Probability.

\end{thebibliography}

./main.bbl:9: Missing } inserted.
<inserted text>
                }
l.9 \end{thebibliography}

Biber ignores the line %volume  = {53} but produces the contents following the percentage character in title field into the .bbl output, which results in an error in the next run of latex.
      \field{title}{Monte {C}arlo %methods in financial engineering}
      \field{year}{2004}
      \field{pages}{xiv+596}

Runaway argument?
{Monte {C}arlo \field {year}{2004} \field {pages}{xiv+596} \range {pa\ETC.
./main.tex:9: File ended while scanning use of \field.
<inserted text>
                \par
l.9 \begin{document}

./main.tex:9:  ==> Fatal error occurred, no output PDF file produced!

VS Code Version: 1.81.1
OS Version: macOS 13.4.1
LaTeX-Workshop version if you use it: v9.13.4

Also note the PEG from https://github.com/aclements/biblib is worth reference. It's the most accurate to the original BibTeX AFAIK.

Fair enough, I am reverting #46.

BTW, how can I generate the test results if when further contribute to the grammar (e.g., add @preamble support)?

See https://github.com/jlelong/vscode-latex-basics#test
If a given fixture file does not have an associated test result file, it is automatically generated when running npm test.

If a given fixture file does not have an associated test result file, it is automatically generated when running npm test.

I see. Thanks!


YARN-11212. [Federation] Add getNodeToLabels REST APIs for Router.

JIRA:YARN-11212. [Federation] Add getNodeToLabels REST APIs for Router.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 42s

trunk passed

+1 :green_heart:
compile
4m  4s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 31s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

+1 :green_heart:
javadoc
2m  0s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
20m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 32s

the patch passed

+1 :green_heart:
compile
3m 49s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 49s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 44s

the patch passed

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 33s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 21s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

226m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 053cfa627c7d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 40bf99456619f83c7c703e3f8941d5cd923a0804

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/1/testReport/

Max. process+thread count
1511 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 27s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 40s

trunk passed

+1 :green_heart:
compile
4m  6s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 30s

trunk passed

+1 :green_heart:
mvnsite
2m 10s

trunk passed

+1 :green_heart:
javadoc
2m  0s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

trunk passed

-1 :x:
shadedclient
17m 55s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 23s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
compile
3m 32s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
3m 32s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
3m  5s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
3m  5s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 14s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
javadoc
0m 22s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 22s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
shadedclient
21m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 12s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
0m 28s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

216m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 766e70d24cc1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5c9ac189c193852ad43a4bf1f4729d9145fab8d2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/2/testReport/

Max. process+thread count
965 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
22m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 43s

trunk passed

+1 :green_heart:
compile
4m 11s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 36s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 29s

trunk passed

+1 :green_heart:
mvnsite
2m  3s

trunk passed

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
21m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 22s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
compile
3m 36s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
3m 36s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
3m 14s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
3m 14s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 15s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

-1 :x:
mvnsite
0m 29s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
javadoc
0m 21s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
0m 22s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
shadedclient
21m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 48s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
0m 28s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

229m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b1d70276ed04 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 979c54f9e7ba341f8952f357fed4b76fefd2b424

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/3/testReport/

Max. process+thread count
938 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  2s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 33s

trunk passed

+1 :green_heart:
compile
4m 14s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 28s

trunk passed

+1 :green_heart:
mvnsite
2m  6s

trunk passed

+1 :green_heart:
javadoc
2m  1s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
20m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
compile
3m 32s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
3m 32s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
3m  6s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
3m  6s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 13s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3)

-1 :x:
mvnsite
0m 26s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
javadoc
0m 25s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 25s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
shadedclient
23m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 52s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
0m 33s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

222m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d0365e6b0aef 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b41ae25829a00d2f535645c95d72a539bc0a1b2b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/4/testReport/

Max. process+thread count
945 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  7s

Maven dependency ordering for branch

-1 :x:
mvninstall
24m 20s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
4m  6s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 30s

trunk passed

+1 :green_heart:
mvnsite
2m  9s

trunk passed

+1 :green_heart:
javadoc
1m 59s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
20m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
3m 47s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 47s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 14s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 41s

the patch passed

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 16s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 21s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

222m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4660dc31bb96 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 36448f7538ea8847cd5edf4d90de9cb5945e329d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/5/testReport/

Max. process+thread count
1561 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 31s

trunk passed

+1 :green_heart:
compile
4m  6s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 28s

trunk passed

+1 :green_heart:
mvnsite
2m 12s

trunk passed

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
20m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 32s

the patch passed

+1 :green_heart:
compile
3m 47s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 47s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 11s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  8s

the patch passed

+1 :green_heart:
shadedclient
20m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 40s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 18s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

224m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1f6bd565eab6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3dfb537a5a73231564dafdae4a49185e5e16d5ca

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/6/testReport/

Max. process+thread count
1512 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 44s

trunk passed

+1 :green_heart:
compile
4m 13s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 29s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
2m  0s

trunk passed

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
20m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
4m  0s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
4m  0s

the patch passed

+1 :green_heart:
compile
3m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
20m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
99m 56s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

226m 36s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 68d482def738 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f151b8891a1c9def5fe9d10674322fd895f64928

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/7/testReport/

Max. process+thread count
1512 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  7s

trunk passed

+1 :green_heart:
compile
4m 23s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 34s

trunk passed

+1 :green_heart:
mvnsite
2m  2s

trunk passed

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
21m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
3m 50s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 50s

the patch passed

+1 :green_heart:
compile
3m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

the patch passed

+1 :green_heart:
shadedclient
21m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
101m 10s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 20s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

231m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fd36db27c930 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c996ef6b2e9f681b8b887cbad4afe707eafe81d6

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/8/testReport/

Max. process+thread count
1474 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri please help me review the code again, thank you very much!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 35s

trunk passed

+1 :green_heart:
compile
4m 16s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 32s

trunk passed

+1 :green_heart:
mvnsite
2m 10s

trunk passed

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
20m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
3m 47s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 47s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 35s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 29s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

227m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fb44522d977c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a75a5ee98a8fe55cfdc6da30d1bfe2229d30733b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/9/testReport/

Max. process+thread count
1720 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Please help me review the code again, thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  2s

trunk passed

+1 :green_heart:
compile
4m  2s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 57s

trunk passed

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
21m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
4m  7s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
4m  7s

the patch passed

+1 :green_heart:
compile
3m 17s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 13s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
113m 22s

hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
unit
3m 28s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

241m 53s

Reason
Tests

Failed junit tests
hadoop.yarn.server.router.webapp.TestFederationInterceptorRESTRetry

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2fe70bb96d42 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4a4e41f49db98a9abe8debaa4e0cf0eda591e7e8

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/10/testReport/

Max. process+thread count
1745 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 16s

trunk passed

+1 :green_heart:
compile
4m  8s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
3m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 33s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

+1 :green_heart:
javadoc
2m  0s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
20m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 32s

the patch passed

+1 :green_heart:
compile
3m 48s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 48s

the patch passed

+1 :green_heart:
compile
3m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 11s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  8s

the patch passed

+1 :green_heart:
shadedclient
20m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 47s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
3m 27s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

224m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4614

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 06ccb7ed1d97 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc89ebeafd28e74c838607d26af45617120c79fa

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/11/testReport/

Max. process+thread count
1728 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4614/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Please help me to review the code again, thank you very much!

@goiri Thanks a lot for your help reviewing the code, I'll follow up with YARN-11220 after this pr is done.

@goiri Thanks for your help reviewing the code!


Enable react-hooks/exhaustive-deps eslint rule

Also changes the eslint ecmaVersion to 2018 although this doesn't require any code changes.
These changes align us with the web console code changes made by https://github.com/openshift/console/pull/12821

/lgtm


Linux

Because I cannot effort Windows or OsX

This is fantastic! I'm really excited to add NSS support to smimesign. I'm just getting back from vacation today and have a lot of catching up to do. I'll try to review this PR this week.

Would love to be able to use smimesign on Linux to sign and verify commits.  What is the status of this PR?

It looks like the user that opened this PR has deleted their GitHub account. Finishing this up is on my list, but I'm not sure when I'll have time to work on it.

Is there any assistance that would help with finishing up?  As I said, definitely motivated to be able to sign and verify on Linux.

If you're interested, you could copy this branch and make a new PR, addressing the feedback I've provided so far. The other half of the problem is that I haven't taken the time to familiarize myself with the NSS APIs. I'll still need to do this in order to fully review this branch. This part would still be blocked on me having some spare time or finding someone with the expertise to review these changes.

Closing in favor of #13.


Update 10907.xml

First commit, testing

Finished with almost all the lines except for the ones about the stones.

Done with line breaks

Done with the gems

Done with the gems

it's actually ore from what Lauren is saying.


Improve handling for hashing unknown packages

Original issue: https://github.com/dependabot/dependabot-core/issues/7907
Dependabot attempts to resolve package hashes from PyPI, but some packages are hosted on private registries. To address this, we iterate though the index URLs set in dependaboy.yml and pass them to the native helper until a match is found.

@jurre Since this change, in our dependabot-script implementation, I've been getting this error. Any idea what this change actually depends on or expects as far as configuration, in order to successfully setup the python updater?
E, [2024-06-04T13:31:42.916676 #7] ERROR -- : Dependabot encountered an error processing <project> : pip: / : undefined method `replaces_base?' for an instance of Hash.
E, [2024-06-04T13:31:42.916718 #7] ERROR -- : [
    "/home/dependabot/dependabot-script/vendor/ruby/3.3.0/gems/dependabot-python-0.259.0/lib/dependabot/python/file_updater.rb:123:in `any?'",
    "/home/dependabot/dependabot-script/vendor/ruby/3.3.0/gems/dependabot-python-0.259.0/lib/dependabot/python/file_updater.rb:123:in `pip_compile_index_urls'",
    "/home/dependabot/dependabot-script/vendor/ruby/3.3.0/gems/dependabot-python-0.259.0/lib/dependabot/python/file_updater.rb:118:in `updated_requirement_based_files'",
    "/home/dependabot/dependabot-script/vendor/ruby/3.3.0/gems/dependabot-python-0.259.0/lib/dependabot/python/file_updater.rb:36:in `updated_dependency_files'",
    "/home/dependabot/dependabot-script/updater.rb:153:in `block (2 levels) in update'",
    "/home/dependabot/dependabot-script/retries.rb:52:in `with_retries'",
    "/home/dependabot/dependabot-script/updater.rb:105:in `block in update'",
    "/home/dependabot/dependabot-script/updater.rb:99:in `each'",
    "/home/dependabot/dependabot-script/updater.rb:99:in `update'",
    "./dependabot.rb:70:in `block (3 levels) in <main>'",
    "./dependabot.rb:67:in `each'",
    "./dependabot.rb:67:in `block (2 levels) in <main>'",
    "./dependabot.rb:58:in `each'",
    "./dependabot.rb:58:in `block in <main>'",
    "./dependabot.rb:34:in `each'",
    "./dependabot.rb:34:in `<main>'"
]

Ok, I'm guessing that since #8967, the Array of Hash for credentials is no longer valid, but still used by dependabot-script. Investigating how to setup the credential using the class...

Yep, that was it. Fixed it, https://github.com/dependabot/dependabot-core/pull/8967#issuecomment-2147695894


"Column of this field must be a BelongsToMany relation" on grid select

Laravel Version: 5.5
PHP Version: 7
Laravel-admin: 1.6.5

Description:
I have a grid column showing a select of available options from relationship. (Grid im showing in screenshot has belongsTo relationship with the table from where is getting available options).
$grid->estado_id('Estado')->select(EstadoAnalisis::all()->pluck('nombre', 'id'))->sortable();

This works well, but when I try to change select option to update relation into database, it returns an exeption:
Column of this field must be a 'BelongsToMany' relation.

Why is using MultipleSelect as field without even been html multiselect? I dont know when and why is loading this MultipleSelect when PUT request is sent.
Thanks.

Ok, I found where is the problem.
Inside src/Form.php , we have this:
protected function setFieldOriginalValue()
    {
//        static::doNotSnakeAttributes($this->model);

        $values = $this->model->toArray();

        $this->builder->fields()->each(function (Field $field) use ($values) {
            $field->setOriginal($values);
        });
    }

When $field->setOriginal($values) function is called, it's going to src/Form/Field/MultipleSelect.php function instead of src/Form/Field/Select.php one.
Replacing $field->setOriginal($values)  for src/Form/Field/Select.php setOriginal() function's code works well, like this:
    protected function setFieldOriginalValue()
    {
//        static::doNotSnakeAttributes($this->model);

        $values = $this->model->toArray();

        $this->builder->fields()->each(function (Field $field) use ($values) {
//            $field->setOriginal($values);
            if (is_array($this->column)) {
                foreach ($this->column as $key => $column) {
                    $this->original[$key] = array_get($values, $column);
                }

                return;
            }

            $this->original = array_get($values, $this->column);
        });
    }

Anyone knows why?

@z-song any thoughts?

Ok, I think i found the issue.
In the form, I have a listbox, but on edit state it's empty. Because of being empty, the other select throws "Column of this field must be a BelongsToMany relation" I don't know why.


Please clarify "How to create logs"

I believe there is an error in this introductory line. Or at least it could be clarified.
> To create logs, implement an ILogger object from the dependency injection container
I was thrown off for longer than I like to admit by this.
My build kept failing at runtime because my _logger was null.
I did implement it the way the sentence suggest:
MyController(ILogger logger) ...
However for it to work, it needs to be ILogger<MyController>
The example does this, but I missed that initially, and just read the sentence over and over again.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7184a308-a254-9350-a5cd-5bced1f369ae
Version Independent ID: 726e3bf1-f367-d733-8933-bccc04da0e16
Content: Logging in ASP.NET Core
Content Source: aspnetcore/fundamentals/logging/index.md
Product: aspnet-core
GitHub Login: @ardalis
Microsoft Alias: tdykstra

Thanks on behalf of the next guy, @guardrex :) . I'm sure this little change would have saved me some time :)


API returns the data type int and not a GUID for G / L Entry property id.

Maybe I'm making an error, but it seems that the API returns the data type int and not a GUID for G / L Entry property id.
I use the API endpoint: https://api.businesscentral.dynamics.com/v1.0/{tenant}/api/beta/
and the company I use is Cronus demo account.
Is it correct that I am using this G / L Entry ID GUID to retrieve dimension lines via the method:
GET / business center / companies ({id}) / dimensionLines? $ Filter = parentId eq ({id})
This does not work if the G / L Entry Object ID is not a GUID.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d38b12d6-3fd3-5667-9f33-3777baa8c750
Version Independent ID: d6fd3545-94f5-ec09-cfe9-d99329a4096c
Content: generalLedgerEntries resource type - Dynamics NAV
Content Source: dynamics-nav/fin-graph/resources/dynamics_generalLedgerEntries.md
Service: dynamics365-financials
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

This is not supported for G/L entries. We're only supporting dimensions for gen. journal line.
But please let me know what your usecase.

I want to get information on what dimensions are used for in relation to the finance postings.
Journal & Journal line are a mediate step before the will be posted ad G/L Entries right?
And I can surely see the dimension values are supported when I get JournalLines, but is that information for finance postings not supported ? and will it be supported in the near future ?

basically I want you extract data from your API, that enables the user to create financial posting reports where they can filter on their dimensions

@henrikwh can you reply on my comments?

Thanks Michael.
We will investigate the possibility to expose dimensions on the generalLedgerEntries api in the future.
To unblock you for now, we're shortly releasing the possibility to create your own apis. PageType = API will be avaliable. From there, you can expose whatevery you want. You can publish the extension as a per tenant extension.


feat: update Prettier config

:tada: This PR is included in version 6.20.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix inverse primary button border

Quick fix to the inverse primary button border color so it renders properly.

💯
Don't forget to version bump!

Funny story:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@">=5" from<EMAIL_ADDRESS>npm ERR! node_modules/babel-loader
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution


Use resolved node in summary switch

Description

Fixes so that readonly correctly resolves for repeating group summary.
Tested in krt-1230a-1 and everything resolves correctly now:

Related Issue(s)

closes #747

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[ ] Cypress E2E test(s) have been added/updated
[?] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[x] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[x] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Changes/additions to component properties

[ ] Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
[x] No changes made

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[x] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

A little late, but I would have loved to have cypress tests that asserts this functionality. @bjosttveit Did you test in frontend-test and/or did you find a way to reproduce it there? Having tests for this would be nice, especially when I'm working on some larger refactoring in Summary at the moment.

I only tested in the app linked in the issue, I dont think frontend test has any cases for dynamic read-only, but that could probably be tested by using the interceptLayout thing?

Ah, never mind then. I don't think we should have to go into such detail to create separate tests to show that expressions work everywhere. Very soon the code will just transparently handle expressions everywhere anyway.


New package: Juna v0.1.0

Registering package: Juna
Repository: https://github.com/WenyinWei/Juna.jl
Created by: @WenyinWei
Version: v0.1.0
Commit: a294d1e20db7f9d6896c0e16c877e992deeae40d
Git reference: HEAD
Release notes:

Juna, short for Julia dynamics, is an efficient toolset for dynamical systems and chaos research.

Closing in favor of https://github.com/JuliaRegistries/General/pull/115920


React Router 4 issues

[ ] scroll (react router scroll will not be updated for RR4)
[ ] wait for official ControlledRouter (investigate why setImmediate must be used in provider and SignOut
[ ] https://github.com/ReactTraining/react-router/issues/3877 and https://github.com/ReactTraining/react-router/issues/3905
[ ] NavigationCardStack state from URL (jmurzy is working on that)
[ ] Android back button

Otherwise, React Router 4 is fresh air for React routing.

https://gist.github.com/ryanflorence/a9019d1a9be6b0e9217f41c8280bfa26

Hmm, react-router 4.0.0-alpha.4 sucks on redirects. Do not update until they fix it.

Changing decision. RR4 only for the browser.


Add admin functions for wiping a version from web instances

This is exposed to project owners, but an admin function here would be really helpful for debugging purposes. The existing view for wiping versions will likely need to be broken out to a reusable view for the admin function.

@agjohnson, I would like to work on this issue. Could use please elaborate it little more.

Hi @agjohnson, I'm new here! This enhancement is not completely clear to me, so I wanted to ask a few things:

Are you talking about a ModelAdmin action here by admin function or something different from out-of-the-box Django admin actions?
If yes, is it about adding the action to readthedocs.builds.admin.BuildAdmin or to readthedocs.projects.admin.ProjectAdmin (more likely I believe)?

@ajatprabha we are looking for a django site admin feature, on VersionAdmin.


Corrected spelling in the docs

I touched many files so please review and place comments

Wow, thank you @vherrin very much! That's fantastic! Sorry for my poor English!

not a problem and thanks for merging!


build: add tooling to avoid jit issues with empty NgModule definitions

Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like #13792.
Fixes a similar issue as #13792 in the LayoutModule which was caught after the new changes to the rule.

Didn't we chat about it just being something that should work, but we have no idea how the given team ran into issues with it.
or did @mmalerba already get a response about why this happened?

I see, it just feels a bit odd to enforce something that is technically supported by Angular, but broke for someone potentially doing something unexpected we don't are aware of.
It would be just good to understand what could happen if we don't enforce it.

I did talk to them, they mentioned that they might have had Ivy enabled at the time, but Misko didn't think it seemed like an Ivy issue. It's also possible it was a change Angular merged but didn't release yet, or maybe the team was just doing something really crazy. Whatever the reason, I don't think it hurts for us to specify the {}


Remove empty Docker engine arguments

#1382

@joshwget can we have some docs for how these kinds of config merges should happen? and a test so we don't accidentally break it if we re-write that code?

I included two tests that cover this pretty well. Docs on map/list merging are definitely needed, but it's a bit more general than this PR so it might be better to address independently.

LGTM 👍