Helm install,  don't create: ExternalName if  forge.localPostrgresql == false

Current Behavior
If forge.localPostrgresql == false, then helm create automatically create: ExternalName service.
Expected Behavior
Don't create any service for Postgres database, the current behavior is problematic, because as far as I know, we can't use Postgress database ran on the same cluster, because Kubernetes will not resolve DNS request and provide all of them to host system.
Instead of creating Externall name, use directly all data provided in values file in flowforge container similar like in: goauthentik => https://github.com/goauthentik/helm
Steps To Reproduce
Based on https://flowforge.com/docs/install/kubernetes/ , I tried to:
0. Using CloudNativePG Helm Chart ( https://github.com/cloudnative-pg/charts ) run kubernetes in different namespace
1.
2. Executed command:

helm repo add flowforge https://flowforge.github.io/helm
helm repo update

Exexuted command:

kubectl label node  role=management
kubectl label node  role=projects
for my nodes in microk8s

Created like that values file:
forge:

entryPoint: forge.<censored, my domain>
domain: <censored, my domain>
https: false
localPostgresql: false
projectNamespace: flowforge
postgres:
host: postgresql-pvc-rw.psql
dbUsername: forge
dbName: flowforge
dbPassword:
port: 5432
telemetry:
enabled: false
fileStore:
enabled: false

postgresql-pvc-rw.psql << name of service from step 0 and name of namespace/
and executed:

helm upgrade --atomic --install flowforge flowforge/flowforge -f valuesforge.yaml

Environment

FlowForge version: v1.8.1
Node.js version: Unknown, helm version:
npm version: Unknown, helm version:
Platform/OS: Ubuntu 20.4
Browser: None.

We removed an ExternalName service type from our Helm chart. At this moment connection to the database host is performed directly from the pod. Database hostname is customized via the postgresql.host chart value. This approach allows one to connect to the Kubernetes resource in a different namespace without a need to specify its FQDN.
This feature will be introduced to the public in the next chart release which should take place on the 14th of March 2024.


az provision fails with "ContainerAppInvalidSchema"

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
Follow all steps up to and then run az provision
Any log messages given by the failure

Expected/desired behavior
Provision complete successfully.
OS and Version?
Windows 11
Mention any other details that might be useful

I commented out everything to do with redis and was able to deploy.  I cannot tell yet where the problem lies with the redis configuration.


where is your dataset ?

I just read your paper, it is a wonderful job for me to continue learning. However, the dataset you have pointed out is invalid. Please tell us  the valid link of dataset. Thanks for your consideration!

Hi xiaoqun, thank you for your interest in our work. You can find the URL of our dataset in the footnote of page 6 of our paper, which is https://drive.google.com/drive/folders/1-I3a3lM6v_ANU6uu_AUmpNYt7rGu3kzt.

OK! It's my fault, I get it! Thank you!


Upgrade rancher logging to latest upstream

As of today the latest is https://github.com/banzaicloud/logging-operator/releases/tag/3.13.0
This contains bug fixes that our users will likely benefit from.  If a newer version is available when this issue is picked up we should consider it.

When we do this we should also start mirroring images from ghcr, these images have support for more cpu arches.

Reopening for a few more checks

PASS verified in 2.6-head Commit ID f487c88
Clean Install Test

Installed logging 100.0.0 3.15.00
configured cluster output & flow
verified logs were flowing to the elastic search output

Upgrade Test

upgraded released chart version 100.0.1 3.12.00 through rancher to chart 100.0.1 3.15.00
edited yaml: loggingOverlay.spec.fluentbit.grace=1 (newly exposed value)
verified logs resumed flowing after update

Clusters types tested
Upgrade from 3.12.00 to 3.15.00

DO RKE2 cluster
DO RKE1 cluster
Custom cluster with k8s version 1.22.3

Clean install of 3.15.00

GKE cluster
K3S cluster
EC2 RKE2 cluster
Custom cluster
EKS cluster


[Core] Update package.json to prevent building the lib after install

Right now the library builds every time you npm install. This is because of a bizarre decision ages ago to make the prepublish run after doing npm install :smile:
My go-to solution for this is to use a little package called in-publish, which allows you to ensure you're actually publishing when running the prepublish script:
"prepublish": "in-publish && npm run build || not-in-publish"

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This is because of a bizarre decision ages ago to make the prepublish run after doing npm install :smile:

What the heck??? I never knew about that. No wonder that's happening...
I'm fine with this approach for now. I think we're going to need an actual release.sh or release.js script for 0.15.0. At that point we shouldn't need to use prepublish in package.json and we could probably drop the in-publish dependency.
I'm fine with merging this as is, but if you wanted to just start a scripts/release.js that does runs the build and publishes until we can sort out the other stuff, that's fine by me too. I'll let you decide. :smile:

@newoga If you detail what you want the release.sh to do, I can write it immediately :+1:
Read this for entertainment: https://github.com/npm/npm/issues/3059

@newoga If you detail what you want the release.sh to do, I can write it immediately :+1:

@nathanmarks For now, it can literally just do what the npm scripts do (remove lib, run build, and publish). Then we can we can remove all the publish related scripts in package.json and then Hai can just use the release script.
Later, the release.sh might be a little bit more sophisticated depending on how the new build works for the new import paths.

@newoga We could... although, in terms of releasing it would mean the current layer of protection in front of npm publish is gone. This doesn't affect me personally, so whoever cuts the releases should be making the decision to not use npm publish.

That's true. I don't think we have any alternative options. I think
@hai-cea would be fine running the release script if we told him to use it.
I've seen other projects make the top level package.json something like
material-ui-build and set private to true so that it can't be published.
Then the release script would be responsible for publishing the right
package with a corresponding package.json.
I think the recompose library does this (sorry I would link but I'm
emailing now).
On Mar 10, 2016 11:27 PM, "Nathan"<EMAIL_ADDRESS>wrote:

@newoga https://github.com/newoga We could... although, in terms of
releasing it would mean the current layer of protection in front of npm
publish is gone. This doesn't affect me personally, so whoever cuts the
releases should be making the decision to not use npm publish.
—
Reply to this email directly or view it on GitHub
https://github.com/callemall/material-ui/pull/3632#issuecomment-195169624
.

@newoga I think we should just merge this for now and shelve the release script idea until we have a better idea of how we'd setup, and what works for @hai-cea

I think we should just merge this for now and shelve the release script idea until we have a better idea of how we'd setup,

That's fine by me :+1:


can not download libraspberrypi-dev

hello
when excute ./install ,it going wrong, the log is can not update libraspberrypi-dev, where can i download this lib?i use this deb http://mirrors.tuna.tsinghua.edu.cn/debian bookworm main

Unable to locate package libraspberrypi-dev


Version update for Spark 1.5.0.

Merged build triggered.

Merged build started.

Test build #41387 has started for   PR 8365 at commit f22b47c.

Merged build triggered.

Merged build started.

LGTM. I think some of these should only be at the tag 1.5.0-rc1 or 1.5.0-rc2 etc. and not in branch-1.5 itself. But I think you can send another PR to restore these to 1.5.1-SNAPSHOT after the RCs ?

LGTM, although I haven't searched the code base to see whether any other places need the same treatment.

I also added the CHANGES.txt file now.

Merged build triggered.

Merged build started.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41388/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41389/
Test FAILed.

Test build #41387 has finished for   PR 8365 at commit f22b47c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41387/
Test FAILed.

Merged build finished. Test FAILed.


Support for MSK IAM without awsProfileName

awsProfileName is mandatory in kafka-ui but instead it should be optional and allow 'Instance profile credentials: used on EC2 instances, and delivered through the Amazon EC2 metadata service.'
ie ./bin/kafka-console-producer.sh can load creds like:
[2021-10-25 01:42:53,532] DEBUG Loading credentials from aws_msk_iam_auth_shadow.com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper@60cb7374 (aws_msk_iam_auth_shadow.com.amazonaws.auth.AWSCredentialsProviderChain)
[2021-10-25 01:42:53,532] DEBUG Loading credentials from aws_msk_iam_auth_shadow.com.amazonaws.auth.AWSCredentialsProviderChain@4d8c44cd (aws_msk_iam_auth_shadow.com.amazonaws.auth.AWSCredentialsProviderChain)

@tooptoop4 have you been able to solve the issue?

yes describeclusters fixed it

Has anyone found a policy that limits access to the cluster as much as possible and still gets the data to show up?
So far this is as most restrictive as I have gotten it while having kafka-ui still work as read only:
      "kafka-cluster:Connect",
      "kafka-cluster:Describe*",
      "kafka-cluster:CreateTopic"

@ekeric13 would be a good idea to ask around in our discord instead of a closed issue :)

Yeah I think I asked their and got a response lol


bump golangci-lint and enable gosec

Codecov Report
Base: 36.27% // Head: 36.37% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (08b77d0) compared to base (9df60ef).
 Consider uploading reports for the commit 16a6b67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   36.27%   36.37%   +0.10%
==========================================
  Files           6        6
  Lines         681      679       -2
==========================================
  Hits          247      247
+ Misses        410      408       -2
  Partials       24       24

Impacted Files
Coverage Δ

cmd/dnspyre/plot.go
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update to torch 1.8

mmcv just released support for torch 1.8, all other dependencies are ready, we're ready to update

[ ] update setup.cfg
[ ] fix potential breaking changes

I've been working on this. It is an important change, as 1.8 offers better compatibility with cuda 11.1 and Ampere GPUs (including RTX 30 Series).
I would suggest using torch<1.9. There do not seem to be any breaking changes in 1.8.1 that I've come across.
To build a docker image, it is essential for MMCV to know about the target GPUs. This is communicated with the following environment variables.
FROM pytorch/pytorch:1.8.1-cuda11.1-cudnn8-devel
ARG FORCE_CUDA="1"
ARG MMCV_WITH_OPS=1
ARG CUDA_HOME="/usr/local/cuda"

# For all of the cuda archs:
# ARG TORCH_CUDA_ARCH_LIST="5.2 6.0 6.1 7.0 7.5 8.0 8.6+PTX"

ARG TORCH_CUDA_ARCH_LIST="7.5 8.0 8.6+PTX"

WORKDIR /workspace
RUN apt-get update && apt-get install -y --no-install-recommends git build-essential gcc vim && \
    rm -rf /var/lib/apt/lists/

# We get a conflict unless we pin pyyaml
RUN pip install --no-cache-dir pyyaml==5.3

RUN pip install --no-cache-dir mmcv-full==1.3 -f https://download.openmmlab.com/mmcv/dist/cu111/torch1.8.1/index.html
RUN pip install --no-cache-dir mmdet

RUN pip install -e git+https://github.com/rwightman/efficientdet-pytorch#egg=effdet

RUN pip install --no-cache-dir ipywidgets jupyterlab
RUN pip install --no-cache-dir fastapi "flake8 >=3.8.3,<4" pytest "pre-commit >=2.8.2,<3"

# NOTE FORK! Replace when icevision is  updated
RUN pip install -e git+https://github.com/adamfarquhar/icevision.git#egg=icevision[all]
RUN pip install --no-cache-dir git+git://github.com/airctic/icedata.git

The only problems that I've seen are related to icevision 0.7, not torch 1.8.1.

I see that on your fork you updated pytorch-lightning version, do we also need to update fastai?

I've not tried this yet.  I wanted to check with you and others if there are any expected problems.  Why  was 2.1.4 was pinned?

If I recall correctly it's because of this:

aaah, we can't update yet, fastai is still on 1.7: https://github.com/fastai/fastai/blob/master/settings.ini#L17

aaah, we can't update yet, fastai is still on 1.7: https://github.com/fastai/fastai/blob/master/settings.ini#L17

There is support for Pytorch 1.9 for fastai > v2.4, is it possible to relax icevision's pytorch pinning to allow Pytorch 1.9 to be installed? I.e. change this line:
https://github.com/airctic/icevision/blob/b6c750f2ca5acfafd0e46e172a817af7a6892f18/setup.cfg#L28
Crossreferencing downstream issue https://github.com/PyTorchLightning/lightning-flash/issues/711, where pytorch 1.8.1 is being installed due to icevision's pytorch pin.

I'm not sure icevision is currently fully compatible with 1.8; @weiji14 are you able to run all tutorial notebooks and tests  after the update? If so, feel free to open a PR

I'm not sure icevision is currently fully compatible with 1.8; @weiji14 are you able to run all tutorial notebooks and tests after the update? If so, feel free to open a PR

Ok, I thought the CI was using pytorch 1.8, but will try out a few things locally and see how it goes. Will open a PR tomorrow.

I would also love to be able to install lightning-flash correctly without conda downgrading my torch install.
BTW this strict dependency also causes torch to be downgraded to the CPU version even if the GPU version is installed when I install or update lightning-flash[image]. 😢

ImportError: /usr/local/lib/python3.7/dist-packages/torchtext/_torchtext.so: undefined symbol:   getting this error while running the object detection notebook it is related with PL, also I tried some solutions for this, but got torchvision nms error please suggest me any solution to install icevision?

This is done.


Fix merge bug

Now cc mode is enabled automatically when cc feature is compiled. The toggle function will be applied after the sev feature is added.

pub fn VcpuWait() -> TaskId {

   #[cfg (feature = "cc")]

   if is_cc_enabled(){

       return Self::VcpuWait_cc();

   }

   let mut next: TaskId = TaskId::New(0, 0);

   HyperCall64(HYPERCALL_VCPU_WAIT, 0, 0, &mut next as *mut _ as u64, 0);

   assert!(next.PrivateTaskAddr() != 0);

   assert!(next.SharedTaskAddr() != 0);

   return next;

}

So we could have the "cc" feature enabled, while having ENABLE_CC set to false?
What's the semantic here?
Also, if the ENABLE_CC is meant to be a toggle switch, shouldn't it read value
from config? Right now it can only be toggled via modifying the source code an
recompiling.

The @shrik3 semantics are as follows: quark supports cc functionality when cc features are enabled. When user deploys the pod, he can add the keyword Confidential-Workload to the yaml file. This keyword will cause fn is_cc_enabled to return true.


Quoting a message with a thanks isn't ignored by bot

When quoting a message from another user (that gave a rep point in the message), YAGPDB sees that as a que to give reputation again regardless of reply content.
Names, avatars and message timestamps have been anonymised to uphold end-user privacy.

Resolved with Discord's modification of Quote to Reply.

User mentions may still be picked up in > intents before intended 'thanks' through targeting of first mention but remain negligible with the feature replacement.

https://github.com/jonas747/yagpdb/blob/60a4149846515aa15642a0974deff45d8b9d08ae/reputation/plugin_bot.go#L35
https://github.com/jonas747/yagpdb/blob/60a4149846515aa15642a0974deff45d8b9d08ae/reputation/plugin_bot.go#L48-L55


Add PhpUnitMethodCasingFixer

Closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/3302
 class MyTest extends \PhpUnit\FrameWork\TestCase
 {
-    public function test_my_code() {}
+    public function testMyCode() {}
 }

[x] Implement base fixer
[x] Take care of @depends
[x] Run after PhpUnitTestAnnotationFixer
[x] Deprecate PhpUnitTestAnnotationFixer case config

@kubawerlos thank you very much for the review.
Just note that I stole almost 90% of the code from PhpUnitTestAnnotationFixer so all your feedback should be addressed there too, and I don't know if I should fix there too or open another PR.

@Slamdunk I think no need to fix it here - maybe in separate PR it's worth to give try to initialize this fixer in PhpUnitTestAnnotationFixer and proxy the fixing.

Thank you @Slamdunk.

this tripped https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/jobs/419018045#L1863
should be an easy fix

i will handle it

ref #3979

Thanks for your work @Slamdunk, exactly what I needed. Snake case in tests ftw ;-)


toggle auto-filter

filter view previously didn't auto search when you choose from history,
I really liked being able to click enter on a filter then add/remove/change it and then apply it
Can we allow the user to choose whether to auto filter when clicking enter or just fill the prompt?
Also, when we just fill the prompt, the cursor is at the start of the line (we had this before, remember we had this issue before? @Ramilito)
So when the feature of auto-filter is turned off, I want the cursor to be at the end of the filter term.
Thanks buddy.

Fixed! the default is enabled though so put this in your config:
        filter = {
          apply_on_select_from_history = false,
        },

Thanks buddy.

Anytime!


HOWTO Mark messages as "read"

Hi, while running the echo sample, I noticed the messages are not marked as "read" (double blue ticks). How can this be done?
Also I think the async_echo.py sample is not working on Windows platform. It threw some kind of NotImplementedError exception, because I think the implementation of asyncio is different on Windows platform?
File "D:/PycharmProjects/WhatsAppWeb/sample/async_echo.py", line 48, in start
loop.add_signal_handler(SIGINT, stop)
File "C:\Users\XXXX\AppData\Local\Programs\Python\Python36-32\lib\asyncio\events.py", line 499, in add_signal_handler
raise NotImplementedError
NotImplementedError

This may not be exactly what you're looking for, but if you directly execute this script using the driver, it will mark the messages as read:
var originalID = Store.Chat.models[0].id;
Store.Chat.models[0].id = arguments[0];
Store.Chat.models[0].sendSeen();
Store.Chat.models[0].id = originalID;

The arguments[0] is the chatID of the Chat that you want to mark as read.

@Tschipp : I am using echo.py example and unable to understand where should i put your provided sample code.
Can you please help?
import time
from webwhatsapi import WhatsAPIDriver
from webwhatsapi.objects.message import Message
import requests

driver = WhatsAPIDriver(loadstyles=True,profile="/Users/tapankumarthapa/Library/Application Support/Firefox/Profiles/2qw4xd77.xxxxxxx")
print("Waiting for QR")
driver.wait_for_login()

print("Bot started")
wa_server_number = 'xxxxxx'

while True:
    time.sleep(3)
    print('Checking for more messages')
    for contact in driver.get_unread():
        for message in contact.messages:
            if isinstance(message, Message):  # Currently works for text messages only.
                print("Phone:" + message.sender.id + "Message:" + message.content)
                requests.post('http://xxxxxxxx/api/wa_receive', data={'wa_number': message.sender.id,
                                                               'wa_message': message.content,
                                                               'wa_type': 'text',
                                                               'wa_server_number': wa_server_number})
                #contact.chat.send_message(message.safe_content)

~~~python

@Tschipp thank you...

You might also want to try
https://github.com/mukulhase/WebWhatsapp-Wrapper/blob/9a87f5d69bad42f7d5b4677a179b09df959c3b62/webwhatsapi/__init__.py#L453
Would be great if you could post working code here after testing.

I have an update:
This code seems to be working better:
var chat = Store.Chat.get(arguments[0]);
chat.sendSeen();
 chat.markSeen();

You would need to call this JS code directly from the selenium webdriver. arguments[0] is the id of the chat that you want to mark as read.

Duplicate of #73


Show total time of today's work and/or list of previous time entries

I mostly use toggl to check my own productivity, so it would be very useful to see today's total time right in the popup of the extension.
A small list of previous time entries done today would be even better. That way you can also easily decide what tasks to continue. The layout of the desktop app did a pretty good job in that sense, just that you don't need a list of all task from the last few days/weeks. Today would be enough.

This has actually been discussed and we have thought about adding 5 latest entries under the timer.

That sounds pretty good! Having the total time of the current day would still be nice to have.

These features exist now 🎉 , closing.


Submit request to get uP C++ contributors added to contributor group in organization

Done :-)

Looks like we've got this figured out


Set ReadHeaderTimeout to 60s to mitigate Slowloris

Go 1.18 added this new timeout and gosec now fails if it's unset.
Leaving this timeout unset exposes the server to a Slowloris attack,
where an attacker keeps many connections open by periodic updates to
HTTP request headers. This can eventually result in being unable to open
new connections because of too many open files.
The 60s value is copied from nginx:
nginx.org/en/docs/http/ngx_http_core_module.html#client_header_timeout
Relates-to: submariner-io/shipyard#900
Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

I verified this fixes the linting error.

And E2E is passing, so I'll go ahead and send the other similar PRs to other repos.


Allow to reinstate a revoked key

Currently, it is not possible to reinstate a revoked key .. let's say you revoked the wrong client by mistake ... or any other situation you might have.
It would be great to minimally allow the same client (name) to be created if the old one was revoked for any reason.

You can issue a new certificate for an existing CN if the previous certificate has been revoked and if you remove the old certificate's .crt, .key and .req files from your container's pki.
CLIENT="your_client_name"
OVPN="your_container_name"
docker exec -it "$OVPN" rm "/etc/openvpn/pki/issued/$CLIENT.crt"
docker exec -it "$OVPN" rm "/etc/openvpn/pki/private/$CLIENT.key"
docker exec -it "$OVPN" rm "/etc/openvpn/pki/reqs/$CLIENT.req"

#251 add a script that can optionally remove those files when you revoke a certificate.
If the files are removed, you'll be able to generate a new certificate :
docker exec -it "$OVPN" easyrsa  build-client-full "$CLIENT"
Please note that this will generate a new certificate and therefore a new .ovpn configuration file you'll have to use for this client. You can't reinstate a revoked certificate using easyrsa, because allowing to reinstate revoked certificates is pretty much the opposite of the way pkis are supposed to work.
There is probably a way to do it anyway if you hack through easyrsa files, but you might also end up with a broken pki.

Closing in favor of solution merged in #251


Change layout dynamically based on range of selected dates

Timeline chart is not useful when looking at data over 3+ days

Done in 1057ae4f9d851a3f49eecb9d1b239135d1f86ba9


Snackbars/Toast

Looks like Snackbars have been updated lately to include desktop/tablet specifications. Now that we have this to work with let's try to get something rolled in for this before launch.
I'll try and take a stab at it myself here in a bit, doesn't look like it should take too long.

Re-opening for purely tracking the addition since the PR is about to change.

Up?

I've done a snackbar following exactly Material design spec with pure css (using flexboxes and translation for animations):
Desktop

Mobile / Tablet

I don't know if it's possible to help...

Added in PR #1519


Perhaps add a link to the talk on YouTube?

Hi,
I got interested in Polonius as a way to better understand the borrow checker. I tried to read the blog post but didn't manage to really understand. The great talk https://youtu.be/_agDeiWek8w helped me understand the motivation and the basic principle. Perhaps add a link to it to the README?
Thanks!
Noam

We could, but it’s already in the book linked in the readme, and it contains a lot more more documentation as well as a link to that talk (https://rust-lang.github.io/polonius/see_also.html) and to blog posts for example.

@lqd I think it's very hard to find the talk right now. If I want to get an idea about what Polonius is, I would go to the blog post, not to the book, since the README says:

It implements the analysis described in this blogpost. Details are in the Polonius book.
I would first go to the blog post to understand, not to the book to get the details. And even following the book link, it's under "See Also".

I think that perhaps the best thing for me would have been if @nikomatsakis added a note at the beginning of the blog post, saying that for a gentler introduction you could watch the talk. Then I would have immediately found it, since the README forwards to the blog post for an introduction.

How about changing the first link like this: "it implements the analysis described in these blogposts and talks", pointing to the See Also page ?

@lqd the "see also" page lists quite a lot of links, most of them for people already familiar with the general idea. I like how there is a specific link for the introduction. That's why I like either having just two links ("described in this blog post and in this link") or adding a link to the talk at the beginning of the blog post.

Why not. I'd like to avoid bothering niko for this though, so I'd gladly merge a PR with the first suggestion.

@lqd Cool! How is this PR? https://github.com/rust-lang/polonius/pull/192

Great, thank you! Let's close this then.

@lqd thank you! It's good to feel that I made a tiny contribution to making this more accessible.


Create gift cards when fulfilling order

Create gift cards when fulfilling order with gift card products, create BOUGHT events.
Send non-shippable gift cards to the customer, create SENT_TO_CUSTOMER events.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3899 Create gift cards when fulfilling gift card order


remove storage preview extension

This checklist is used to make sure that common guidelines for a pull request are followed.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@rmstorage#subdirectory=src/$EXT&egg=$EXT"


test/K8sServices: Fix externalTrafficPolicy=Local with kube-proxy (on GKE)

This commit fixes the test harness for externalTrafficPolicy=Local in
the case where we are accessing a node IP without a local backend from a
node with host reachable services enabled.
This is a known incompatibility between our kube-proxy replacement and
upstream kube-proxy. The existing test harness assumed that we only need
to handle this case if we are running without kube-proxy. This
assumption however is wrong, as we are running these tests in hybrid
mode, where we are running with both kube-proxy and Cilium's kube-proxy
replacement.
This has not been hit in our existing test suites up until recently,
because we did not have a test setup with both kube-proxy and the
kube-proxy replacement enabled at the same time. As GKE has been
upgraded to Linux 4.19, it is now using the described hybrid setup which has
caused the tests to break.
The test matrix as of writing now looks as follows:

Test Suite
kube-proxy
kube-proxy replacement

K8s-1.18-kernel-4.9
Yes
No  (Kernel 4.9.x)

K8s-1.17-Kernel-4.19
No
Yes (Kernel 4.19.57)

K8s-1.12-Kernel-netnext
No
Yes (Kernel 5.8.0-rc1+)

Cilium-PR-Ginkgo-Tests-k8s
Yes
No  (Kernel 4.9.x)

Cilium-PR-K8s-GKE
Yes
Yes (Kernel 4.19.112+)

Fixes: 67f85e3 ("tests: enable additional externalTrafficPolicy=Local tests")

test-me-please

Coverage decreased (-0.02%) to 36.664% when pulling f9dc804f83c23f52bf668bad6b61c31b00aad8b7 on pr/gandro/ci-fix-externaltrafficpolicy-local-tests-on-gke into 3de518a79c968c0e11964c5726dd9f7bb4fed9fc on master.

gke seems to be failing due to unrelated cause, will restart

test-gke

test-gke

test-gke

test-me-please

test-gke

test-me-please

Rebased on https://github.com/cilium/cilium/pull/12725 - as GKE can not pass otherwise.
Naturally blocked on https://github.com/cilium/cilium/pull/12725 getting merged first.

test-me-please

#12725 is merged, please rebase

test-gke

Looks like GetCiliumPodOnNode returned an empty string on GKE?

test-me-please

GKE hit  Suite-k8s-1.15.K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running which seems unrelated.

test-gke

Again hit  Suite-k8s-1.15.K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running

I'm merging this. It seems like it did fix the externalTrafficPolicy=Local issue on GKE (it passed two times) as well as all other CI. The GKE failure in the Chaos test is unrelated.


OAK-11247: Migrated groovy test files to Java

Migrated Groovy test files in oak-pojosr package to Java.
Asserts were changed to use junit assert methods imported statically.

use PaxExam to build ITs that accurately reflect running oak in a OSGi setup like we have it in Adobe AEM. but maybe that's too much of an effort compared to the gain.

I'm fine to take that task with me but I think that's a broader scope of the task. Specially from reviewer's point of view it would need to invest more time and effort to go over the changes. If it's fine for you I'll create a new ticket asking to change that test to use PaxExam.

@AngelaFabregues - paxExam is abandoned; we should not use it in "new" code (see https://mvnrepository.com/artifact/org.ops4j.pax.exam/pax-exam)

@reschke I suppose you wanted to mention @anchela  😅
At least the pax exam repo seems somehow mantained https://github.com/ops4j/org.ops4j.pax.exam/activity
I ran the integrationTesting locally and it went through without issues

@anchela - time to merge?

yep


Fallback style Recaptcha not firing callback.

Hello,
On my application, the submit button is disabled until the captcha is solved.  (Don't worry, there's ALSO back end validation)
However, it has come to my attention that visitors on a 56k modem will often meet the 'fallback' style captcha.
This fallback style captcha doesn't seem to fire a callback, and thus the submit button is never enabled.
Please see #63 for an old report.
Here is a code snippet to reproduce the issue.  (written by @defualt)

As you can see, the recaptcha_callback is never called.

Closing old issues that are not related to the PHP client code.


[Suggestion] Ideas about ReviewNB

I have come across https://www.reviewnb.com/ (see GH https://github.com/ReviewNB) some time back and didn't know what it was for but I recently looked into it and installed it as a GH.
It helps to review notebooks in PRs when we make changes to such files.
Also, it may be an idea to integrate nbqa (maybe long shot) into ReviewNB - worth playing around with the idea.

Hi @neomatrix369 - the only notebooks we have are for testing purposes, and they're not  often changed, so IMO we can (for now) hold off from integrating reviewnb

Also, it may be an idea to integrate nbqa (maybe long shot) into ReviewNB - worth playing around with the idea.

Hi @neomatrix369 - the only notebooks we have are for testing purposes, and they're not often changed, so IMO we can (for now) hold off from integrating reviewnb

Okay. makes sense, no point just pilling up new tools/analysers if the usage isn't justifiable for it.

Also, it may be an idea to integrate nbqa (maybe long shot) into ReviewNB - worth playing around with the idea.

Not sure what you mean, can you elaborate please?
I mean making ReviewNB use nbqa when their users review notebooks. Here's what the workflow could look like:

when nbqa is enabled in ReviewNB config
user reviews a notebook PR
user sees annotations/warnings by nbqa about the formatting of the notebook as part of the review

It's roughly what I'm envisioning, of course their maintainer might have other plans or workflow in mind. But it's a good way to introduce nbqa to new ReviewNB users.

OK, I see - convincing reviewnb to incorporate this into their review process would be too awesome to be true, but I can't really see it happening (for one thing, users wouldn't necessarily agree to their choice of formatter/linter), and because they seem to be focused on clear and understandable diffs between notebooks, rather than on the contents of the notebooks themselves. And their source code isn't open source so we can't extend it, as far as I can tell

OK, I see - convincing reviewnb to incorporate this into their review process would be too awesome to be true, but I can't really see it happening (for one thing, users wouldn't necessarily agree to their choice of formatter/linter), and because they seem to be focused on clear and understandable diffs between notebooks, rather than on the contents of the notebooks themselves. And their source code isn't open source so we can't extend it, as far as I can tell

Let's see if we can come up with something is the meanwhile I'll continue to be an "ideas" hamster running on the mill!

:rofl: sure, please do keep the ideas coming!

@MarcoGorelli I'll try to propose the idea to them and leave it to them to integrate it, we don't lose anything for asking


fix: adapt react package import paths missed during migration

This PR fixes the remaining mistaken imports in the React package.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@0f2f401). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage        ?   93.18%
=======================================
  Files           ?      315
  Lines           ?    25381
  Branches        ?     2062
=======================================
  Hits            ?    23652
  Misses          ?     1696
  Partials        ?       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Idempotent db seed

Fix endless do nothing in db_seed.js.
Check that tables exist in the database and do not overwrite data. Or overwrite if forced by env variable FORCE_DB_INIT.
Add autoinitialization of db to container entrypoint.

@knopki wow, this is really a relief :+1:


Add ability to exclude fields in union macro

Especially helpful for tables with many uncommon fields.

@birdsong thanks! This is great! Do you mind just updating the README.md file with the new argument? You can find the existing docs here: https://github.com/fishtown-analytics/dbt-utils/blob/master/README.md#union_tables-source
Pending that, approved!

Merging! Thanks for the updates :)


methotrexate binding

def: Interacting selectively with methotrexate, an
antineoplastic antimetabolite with immunosuppressant
properties. It is an inhibitor of tetrahydrofolate
reductase and prevents the formation of
tetrahydrofolate, necessary for synthesis of
thymidylate, an essential component of DNA.
is-a: GO:0005488 ! binding
Reported by: lenov
Original Ticket: "geneontology/ontology-requests/3125":https://sourceforge.net/p/geneontology/ontology-requests/3125

thanks www.movied.org


Update the development docs

This is a first pass but should help clean up / clarify certain parts.
Next I plan to run yarn copy-api-types and use them to update the action_api.md file, but wanted to discuss that first.

Hi @phillipperalez , I have made a commit to respond to your comments.
Shall I run the copy-api-types command and commit those updated files, along with corresponding changes to the action_api.md file?

Sure that would be good. Added @ronnieplooker to take a look at the wording too

Thanks for the review, @ronnieplooker! I have added links to the official docs as you suggest. I definitely understand your point about having content in both places. I think there is an overlapping set of info... the official docs are good for overview and "how it works", but we still need GitHub for detailed development stuff. It's definitely far from perfect (or even complete), but since I've been working on it recently I figured I would at least make a pass over it and improve what I could.

I'm not sure why it says that there is a conflicting file (is that compared to the master branch) or what checks it is expecting to complete...
Can we merge this?

Hey team, I have made a few final additions just to touch on interactive forms and OAuth login forms. I think that covers everything for now. I am ready to call this PR 100% done! Let's go ahead and merge if you agree. Thanks!

Submitted a minor comment. Otherwise, LGTM, but I'll let @phillipperalez formally approve. I think a good next step for me is to update the official docs and see what should stay and what should be redirected to GitHub. Thanks for these updates, Victor!


SSL Certificate pinning

Hello,
is it possible to pin a self signed SSL certificate? We using a external API and this API has a self signed certificate. The API provider can't change it to a valid certificate. We don't want to disable the SSL verification for this API call because it contains secret information. Disabling the verification is against our company security guidelines.
So what can I do?
I've been trying to solve it like this:
result = RestClient::Request.execute({
   method: :get,
   url: "https://specialAPI",
   ssl_ca_file: File.read(File.join(Rails.root, 'certificates', 'api.pem')),
   verify_ssl: OpenSSL::SSL::VERIFY_PEER,
   timeout: 5,
})

But I still get this error message:
SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed:

I think there is a Ruby OpenSSL option for this called "ssl_cert_file" but I think this option will be dropped from your library.
Regards,
Alexander

ssl_ca_file should be a file path, not the file contents.
So from your example it should be:
ssl_ca_file: File.join(Rails.root, 'certificates', 'api.pem'),

You can also use ssl_verify_callback to pass a function that implements whatever verification method you would like.


Does not work for go-1.8, "unrecognized profile format"

Thanks for letting me know. I will look into the new data structure layout.

@zoobenthos I was not able to reproduce this using Go 1.8 on macOS 10.12. Do you have a stack trace? From what I have seen, unrecognized profile format errors usually means a broken or outdated version of pprof itself.

Please look at my example: https://github.com/zoobenthos/goprofui_test
make
./test
browse localhost:6060
Profiling does not work for me (macOS 10.12.3, go-1.8, standard golang.org distribition https://storage.googleapis.com/golang/go1.8.darwin-amd64.pkg)
How to detect broken pprof?

Hm... your test binary worked just fine for me. To see if pprof is working you can import it per the docs.
That said, since its a std lib package you may want to try a complete clean out of your $GOPATH and reinstall Go.

I have reinstalled go-1.8 from scratch, removed all $GOPATH and clone only my example to $GOPATH/src/.
No, this does not working. Mystic. I mean FlameGraph only, plots working nice, I'm interested in working FlameGraph profiling.

Ah, okay thanks for clarifying. I didn't know flame graphs were your problem.

Hey I was able to replicate the issue. We are going to need to update internal/profile/profile.go for 1.8

@julia-allyce #4 works for web example and @zoobenthos test code.

Thanks @damienstanton! Just merged your pull request.


Customization

Chalkbeat customization for fonts and colors

I need to pay better attention to what I'm doing.


[BCF-3392]  - ContractReaderByIDs Wrapper

Adding a wrapper for this feature instead of making interface changes since not all use cases might want this

Main concern is double versioning since ContractReader changes might break this interface so we would have to version both CR and this wrapper. Right now there are no further planned changes to the interface, so at least we should be safe until new chain family impl. starts.
Had to change the fakeChainReader tester to support multiple addresses for same contract

I don't know if I fully grok the reason for the feature request, but the change looks good 👍


Fix FileNotFound during integration tests due to renamed ".cake" file

Resolves #397

@Jericho your changes have been merged, thanks for your contribution 👍


Monitoring: Hide Operator

Since I had deleted and restored my hideO branch and the Parent PR  https://github.com/IBM/ibm-monitoring-grafana-operator/pull/140 is already merged , I am raising this fresh PR request.

/retest


Stream settings: Remove css bug in mobile-view. Fixes #7712

Fixes #7712

@brockwhittaker please review

Not seeing a fix for this in here:

The buttons are now permanently lower when they shouldn't be on full screen and the @media breaks don't seem to work for the buttons below. I don't think you should have to add any markup like this:

To make it work. I'd recommend wrapping problematic elements in something (if you even need to), and then changing their ability to fall in block on responsive screens only with media queries so we don't change how this looks at normal widths.

@brockwhittaker  I have made size of the text boxes variable depending on screen size. Please review this.

Hey @shreyanshdwivedi, I don't necessarily think this was the right approach as it involved too much hard coded CSS and too many elements being created. I opened #7758. I'd encourage you to look at how I resolved the responsiveness issues. Thanks for your work on this!


No

No
Originally posted by @rellyrell7898 in https://github.com/DandelionSprout/adfilt/issues/803#issuecomment-1505002264

?

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

?


:space_invader: added mixin and examples for a spinner field

also made the style a general mixin (no longer only button-specific)

Should the first in the series appear with orange highlighting?

the JS there is very basic... it just starts the spin on change and waits two seconds then removes... some of the examples are a bit more elaborate, disabling the fields and such... in short: the JS is for entertainment purposes only... what browser are you using?

Very entertaining! Chrome.

Firefox does the same and a little bit in the Topics category too (the orange is not covered, which is maybe your intent?).

try again (moar commitz)

arigatou. Chrome is consistent across all spinners; although still present in Firefox.


Saving card abilities in files

Have the possibility to more easily (i.e. without coding) modify card abilities, such as "ranged", "heal 1 at end of turn", "summon 2 xx creatures when played". Modify these by using some human readable file format, such as XML, JSON, or make our own.
It could be possible to declare some abilities in an ability file.
Some examples of possible ability files:
ranged.ability (Custom format)
setResource( DENY_COUNTERATTACK, 1 )

ranged.ability (XML)
<ability type="resource">
      <parameter>DENY_COUNTERATTACK</parameter>
      <parameter>1</parameter>
</ability>

summon-2-BodyMan.ability (XML)
<ability type="EffectComponent">
<parameter method="Effects.toSelf">
     <parameter method="Effects.toPlayer">
           <parameter method="Effects.summon">
                  <parameter>2</parameter>
                  <parameter>Body Man</parameter>
           </parameter>
    </parameter>
</parameter>
</ability>

See http://www2.zomis.net/tcg-creation/132/alternatives-for-storing-cards?show=167#a167

Another option that has emerged recently is to use JSON-like structure within JS:
http://chat.stackexchange.com/transcript/message/21374847#21374847
http://chat.stackexchange.com/transcript/message/21375057#21375057

Referencing #199

Implemented with #180

Even better implemented with #222


fixRightEdge and fixLeftEdge bug?

Example is the first demo from the website:
https://jsfiddle.net/TradingView/v0p52anL/
just change this:
timeScale: {
		borderColor: 'rgba(197, 203, 206, 1)',
	},

to this:
timeScale: {
		borderColor: 'rgba(197, 203, 206, 1)',
		fixRightEdge: true,
		fixLeftEdge: true,
	},

It zooms in. How to fix it?

Hi @kritsky, thanks for opening this issue.
Can you tell us what behaviour you expected in this case?

The same view as by default.
And that users can't scroll to the future and the past from the first data.

Yeah, looks strange.


Add Loader During Page Navigation

Description
Add a global loading spinner that appears when navigating between pages in the Next.js app. This will enhance the user experience by providing feedback during page transitions, especially when there is a delay in loading the new page or fetching data.
Current Behavior
Currently, there is no visual indication of loading when navigating between pages in the Next.js app, which can lead to confusion, especially on slower connections or when pages involve data fetching.
Expected Behavior

A loading spinner should be displayed whenever a user navigates between pages.
The spinner should be globally present and disappear once the new page is fully loaded.
The loading spinner should be placed in a reusable component and easily customizable.

Requirements
Global Loading State:

Use next/router's router.events to detect when navigation starts and ends.
Track the loading state using React's useState and useEffect hooks in a central location like _app.tsx.

Loader Component:

Create a Loader.tsx component that displays a spinner (or another loading animation).
Optionally, include a message like "Please wait..." alongside the spinner.
Ensure this component is well-typed using TypeScript and handles optional props (like message).

Page Navigation Tracking:

Use router.events.on('routeChangeStart') and router.events.on('routeChangeComplete') to detect when navigation starts and ends.
Trigger the loading state during these events.

Styling:

Style the loader with a centered spinner and a background overlay that slightly dims the page to indicate it's loading.
Ensure the loader is responsive and looks good on all devices.

Accessibility:

Add ARIA attributes to ensure the loader is accessible, especially for screen readers.

Performance Considerations:

Ensure the loader does not add unnecessary overhead or block rendering.
Use Next.js optimally to prefetch data when necessary to reduce loading times.

assign me this task

also this issue to be fixed under hackOctoberFest and GSSOC-Extd label under any Level

Assigned to both of you @avishek999 and @harish08102004
Work on it and update me!

@Rakshit-gen can you please specify  at what pages do you need the loader and do i need add my own creds in .env??

On every page wherever you find it necessary @avishek999
And yes you have to create your own .env file

@avishek999 any updates?

@avishek999 any updates?

hello @Rakshit-gen can i work on this isse?

Sure @Sourabh782

hello @Rakshit-gen can you check this?

or should i change design


App disappears when a specific song is playing.

Description
The app completely disappears from the menu bar every time a specific song is playing in Spotify. When the song is paused, the SpotMenu icon appears as expected. But when the song is played again, all signs of the app in the menu bar disappear. I’m reporting this in case it’s part of a broader issue, e.g., something to do with the French accented characters in the track name?
Steps to Reproduce

Play this song in Spotify:
https://open.spotify.com/track/27cvNIRYgNqDGki4r49lxF?si=7lOvm7xUTXClGpL8q022lQ

My preferences are as follows:

Versions
SpotMenu version: 1.8.0
You can get this information by highlighting SpotMenu.app (most likely in your Applications folder) in finder and pressing space.
MacOS version: 10.13.3

Hey 👋🏻
Thanks for reporting the issue. This is most likely the same problem that is addressed in these issues:
#77, #71, #16

Thanks!


Swagger LintDiff false positives for EvenSegmentedPathForPutOperation

There look to be 8 false positives for EventSegmentedPathForPutOperation in this PR check:
https://github.com/Azure/azure-rest-api-specs/pull/28023/checks?check_run_id=22174134612
It is using Swagger LintDiff via openapi-validator v2.2.0.
It looks like that rule was modified on January 8th by @rkmanda.
https://github.com/Azure/azure-openapi-validator/pull/632
That repo is lacking git tags, so I'm not sure if the version in use contains those changes.

I believe this is a dup of https://github.com/Azure/azure-openapi-validator/issues/646


IndexError when using geographic data

Hey,
I'm reporting a bug occurring when using hvplot with geo=True option or crs= option
ALL software version info
hvplot version : 0.7.3
xarray version 2022.3.0
geoviews version 1.9.5
Description of expected behavior and the observed behavior
without option the dataset is showing fine xr.open_dataset('bug.nc').band_data.hvplot(x='x',y='y')

Complete, minimal, self-contained example code that reproduces the issue
If I add the  geo=Trueoption or crs= option or both the following error occur
 xr.open_dataset('bug.nc').band_data.hvplot(crs=cartopy.crs.epsg(2154))
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/IPython/core/formatters.py:973, in MimeBundleFormatter.__call__(self, obj, include, exclude)
    970     method = get_real_method(obj, self.print_method)
    972     if method is not None:
--> 973         return method(include=include, exclude=exclude)
    974     return None
    975 else:

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/core/dimension.py:1316, in Dimensioned._repr_mimebundle_(self, include, exclude)
   1309 def _repr_mimebundle_(self, include=None, exclude=None):
   1310     """
   1311     Resolves the class hierarchy for the class rendering the
   1312     object using any display hooks registered on Store.display
   1313     hooks.  The output of all registered display_hooks is then
   1314     combined and returned.
   1315     """
-> 1316     return Store.render(self)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/core/options.py:1405, in Store.render(cls, obj)
   1403 data, metadata = {}, {}
   1404 for hook in hooks:
-> 1405     ret = hook(obj)
   1406     if ret is None:
   1407         continue

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/ipython/display_hooks.py:282, in pprint_display(obj)
    280 if not ip.display_formatter.formatters['text/plain'].pprint:
    281     return None
--> 282 return display(obj, raw_output=True)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/ipython/display_hooks.py:252, in display(obj, raw_output, **kwargs)
    250 elif isinstance(obj, (CompositeOverlay, ViewableElement)):
    251     with option_state(obj):
--> 252         output = element_display(obj)
    253 elif isinstance(obj, (Layout, NdLayout, AdjointLayout)):
    254     with option_state(obj):

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/ipython/display_hooks.py:146, in display_hook.<locals>.wrapped(element)
    144 try:
    145     max_frames = OutputSettings.options['max_frames']
--> 146     mimebundle = fn(element, max_frames=max_frames)
    147     if mimebundle is None:
    148         return {}, {}

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/ipython/display_hooks.py:192, in element_display(element, max_frames)
    189 if type(element) not in Store.registry[backend]:
    190     return None
--> 192 return render(element)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/ipython/display_hooks.py:68, in render(obj, **kwargs)
     65 if renderer.fig == 'pdf':
     66     renderer = renderer.instance(fig='png')
---> 68 return renderer.components(obj, **kwargs)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/renderer.py:410, in Renderer.components(self, obj, fmt, comm, **kwargs)
    408 doc = Document()
    409 with config.set(embed=embed):
--> 410     model = plot.layout._render_model(doc, comm)
    411 if embed:
    412     return render_model(model, comm)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/viewable.py:455, in Renderable._render_model(self, doc, comm)
    453 if comm is None:
    454     comm = state._comm_manager.get_server_comm()
--> 455 model = self.get_root(doc, comm)
    457 if config.embed:
    458     embed_state(self, model, doc,
    459                 json=config.embed_json,
    460                 json_prefix=config.embed_json_prefix,
    461                 save_path=config.embed_save_path,
    462                 load_path=config.embed_load_path,
    463                 progress=False)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/viewable.py:512, in Renderable.get_root(self, doc, comm, preprocess)
    495 """
    496 Returns the root model and applies pre-processing hooks
    497
   (...)
    509 Returns the bokeh model corresponding to this panel object
    510 """
    511 doc = init_doc(doc)
--> 512 root = self._get_model(doc, comm=comm)
    513 if preprocess:
    514     self._preprocess(root)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/layout/base.py:122, in Panel._get_model(self, doc, root, parent, comm)
    120 if root is None:
    121     root = model
--> 122 objects = self._get_objects(model, [], doc, root, comm)
    123 props = dict(self._init_params(), objects=objects)
    124 model.update(**self._process_param_change(props))

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/layout/base.py:112, in Panel._get_objects(self, model, old_objects, doc, root, comm)
    110 else:
    111     try:
--> 112         child = pane._get_model(doc, root, model, comm)
    113     except RerenderError:
    114         return self._get_objects(model, current_objects[:i], doc, root, comm)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/pane/holoviews.py:239, in HoloViews._get_model(self, doc, root, parent, comm)
    237     plot = self.object
    238 else:
--> 239     plot = self._render(doc, comm, root)
    241 plot.pane = self
    242 backend = plot.renderer.backend

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/panel/pane/holoviews.py:312, in HoloViews._render(self, doc, comm, root)
    309     if comm:
    310         kwargs['comm'] = comm
--> 312 return renderer.get_plot(self.object, **kwargs)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/bokeh/renderer.py:73, in BokehRenderer.get_plot(self_or_cls, obj, doc, renderer, **kwargs)
     66 @bothmethod
     67 def get_plot(self_or_cls, obj, doc=None, renderer=None, **kwargs):
     68     """
     69     Given a HoloViews Viewable return a corresponding plot instance.
     70     Allows supplying a document attach the plot to, useful when
     71     combining the bokeh model with another plot.
     72     """
---> 73     plot = super(BokehRenderer, self_or_cls).get_plot(obj, doc, renderer, **kwargs)
     74     if plot.document is None:
     75         plot.document = Document() if self_or_cls.notebook_context else curdoc()

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/renderer.py:243, in Renderer.get_plot(self_or_cls, obj, doc, renderer, comm, **kwargs)
    240     defaults = [kd.default for kd in plot.dimensions]
    241     init_key = tuple(v if d is None else d for v, d in
    242                      zip(plot.keys[0], defaults))
--> 243     plot.update(init_key)
    244 else:
    245     plot = obj

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/plot.py:991, in DimensionedPlot.update(self, key)
    989 def update(self, key):
    990     if len(self) == 1 and ((key == 0) or (key == self.keys[0])) and not self.drawn:
--> 991         return self.initialize_plot()
    992     item = self.__getitem__(key)
    993     self.traverse(lambda x: setattr(x, '_updated', True))

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/geoviews/plotting/bokeh/plot.py:111, in GeoPlot.initialize_plot(self, ranges, plot, plots, source)
    109 def initialize_plot(self, ranges=None, plot=None, plots=None, source=None):
    110     opts = {} if isinstance(self, HvOverlayPlot) else {'source': source}
--> 111     fig = super(GeoPlot, self).initialize_plot(ranges, plot, plots, **opts)
    112     if self.geographic and self.show_bounds and not self.overlaid:
    113         from . import GeoShapePlot

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/bokeh/element.py:1409, in ElementPlot.initialize_plot(self, ranges, plot, plots, source)
   1407 # Initialize plot, source and glyph
   1408 if plot is None:
-> 1409     plot = self._init_plot(key, style_element, ranges=ranges, plots=plots)
   1410     self._init_axes(plot)
   1411 else:

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/bokeh/element.py:496, in ElementPlot._init_plot(self, key, element, plots, ranges)
    489 """
    490 Initializes Bokeh figure to draw Element into and sets basic
    491 figure and axis attributes including axes types, labels,
    492 titles and plot height and width.
    493 """
    494 subplots = list(self.subplots.values()) if self.subplots else []
--> 496 axis_types, labels, plot_ranges = self._axes_props(plots, subplots, element, ranges)
    497 xlabel, ylabel, _ = labels
    498 x_axis_type, y_axis_type = axis_types

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/holoviews/plotting/bokeh/element.py:407, in ElementPlot._axes_props(self, plots, subplots, element, ranges)
    405 # Get the Element that determines the range and get_extents
    406 range_el = el if self.batched and not isinstance(self, OverlayPlot) else element
--> 407 l, b, r, t = self.get_extents(range_el, ranges)
    408 if self.invert_axes:
    409     l, b, r, t = b, l, t, r

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/geoviews/plotting/plot.py:73, in ProjectionPlot.get_extents(self, element, ranges, range_type)
     71     extents = None
     72 else:
---> 73     extents = project_extents(extents, element.crs, proj)
     74 return (np.NaN,)*4 if not extents else extents

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/geoviews/util.py:102, in project_extents(extents, src_proj, dest_proj, tol)
    100     geom_in_src_proj = geom_clipped_to_dest_proj
    101 try:
--> 102     geom_in_crs = dest_proj.project_geometry(geom_in_src_proj, src_proj)
    103 except ValueError:
    104     src_name =type(src_proj).__name__

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/cartopy/crs.py:805, in Projection.project_geometry(self, geometry, src_crs)
    803 if not method_name:
    804     raise ValueError(f'Unsupported geometry type {geom_type!r}')
--> 805 return getattr(self, method_name)(geometry, src_crs)

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/cartopy/crs.py:941, in Projection._project_polygon(self, polygon, src_crs)
    939     is_ccw = True
    940 else:
--> 941     is_ccw = polygon.exterior.is_ccw
    942 # Project the polygon exterior/interior rings.
    943 # Each source ring will result in either a ring, or one or more
    944 # lines.
    945 rings = []

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/shapely/geometry/polygon.py:99, in LinearRing.is_ccw(self)
     96 @property
     97 def is_ccw(self):
     98     """True is the ring is oriented counter clock-wise"""
---> 99     return bool(self.impl['is_ccw'](self))

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/shapely/algorithms/cga.py:14, in is_ccw_impl.<locals>.is_ccw_op(ring)
     13 def is_ccw_op(ring):
---> 14     return signed_area(ring) >= 0.0

File ~/miniconda3/envs/baleine/lib/python3.9/site-packages/shapely/algorithms/cga.py:7, in signed_area(ring)
      3 """Return the signed area enclosed by a ring in linear time using the
      4 algorithm at: https://web.archive.org/web/20080209143651/http://cgafaq.info:80/wiki/Polygon_Area
      5 """
      6 xs, ys = ring.coords.xy
----> 7 xs.append(xs[1])
      8 ys.append(ys[1])
      9 return sum(xs[i]*(ys[i+1]-ys[i-1]) for i in range(1, len(ring.coords)))/2.0

IndexError: array index out of range
:Image   [y,x]   (band_data)

the same error is happening with xr.open_dataset('bug.nc').band_data.hvplot(geo=True)
I can give you the bug.nc netcdf file if you wish.

Yes it would be nice if you could share this NetCDF file (EPSG 2154, thanks for the memory 🇫🇷).

I am getting the same error. Using an xarray DataArray in CRS 'epsg:3857'. Works fine with rasterize=True and Project=False. Fails with Project=True.

@hxawax I can get your plot working by declaring explicitly x and y:
import xarray as xr
import hvplot.xarray

ds = xr.open_dataset('bug.nc')
ds.band_data.hvplot(x='x', y='y', crs=cartopy.crs.epsg(2154))

(I think what happens when you don't declare them explicitly is that hvPlot assumes you want to plot (y, x) since this is the convention for arrays. The axes being now messed up their extents is also messed up which lead to the error message)

@kearney-sp did you experience exactly the same issue due to not declaring explicitly x and y? If not, could you please provide an example to reproduce your issue?

@maximlt I was declaring x and y explicitly when I got the error. I will see if I can create a reproducible example, or at least just paste the code snippet (it's part of a much larger app). Thanks.

Thanks, that'd be much appreciated @kearney-sp !

I sometimes have the same error, below you can find an MRE, and this are the package versions I am using (please let me know if some relevant ones are missing).
I believe I only get this error with some CRSs but not with all of them.
geoviews             1.9.5
holoviews            1.14.9
xarray               2022.3.0

import xarray as xr
import rioxarray as rxr
import cartopy.crs as ccrs
import geoviews as gv
import holoviews as hv
import hvplot.xarray

da = xr.DataArray(np.arange(1_000_000).reshape(1000,1000),
                  coords=dict(x=np.linspace(577200, 867600, 1000),
                              y=np.linspace(-1802100, -2036700, 1000))
                 )

da = da.rio.write_crs(32635)
crs = ccrs.epsg(32635)
da.hvplot(x="x", y="y", crs=crs, rasterize=True, cmap='cividis')

Good catch @Hoxbro ! There's a very good chance that's what's going on.
I agree with you that a better error message would be very helpful.

This looks like the same error that is showing up in #951 (leading me to believe even more firmly that that issue has to do with bad hvplot misunderstanding the crs of the bounds).

Having finally circled back to this, I think that in order to raise a more informative error there would need to be a change on the holoviews side.

Are you sure the change is needed in Holoviews?
Because I did some initial work to give a more informative error message in holoviz/geoviews#581 but never finished it.

Oh sorry I mean "not on hvplot" yeah it's more likely that it would happen on geoviews.

You are more than welcome to continue the work on the PR or rewrite it if that is easier 😅


Embedded images not displayed

I'm really not sure if this is a Vienna bug or IPython/RSS bug, but thought I would start here.
I've subscribed to a blog with embedded images. See all images (but bottom few w/ people) in this post: http://ocefpaf.github.io/python4oceanographers/blog/2014/03/31/itaguare/
Image URLs look like, for example:
data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEASABI...<etc.>

These are not displayed by Vienna. Instead I see the small blue ? symbol.

This bug has re-appeared. The previous embedded image began with the following text: data:image/jpeg;base64,. That same blog (see link here) is now serving images that begin with: data:text/html;base64, and I'm getting the following error from Vienna

Fixed by #628


Fork cw3 package?

We've added some new interfaces that are shared across both the cw3-dao and cw3-flex-multisig contracts... it might make sense for use to for the cw3 spec package. https://github.com/CosmWasm/cw-plus/tree/main/packages/cw3
Open to people's thoughts here. This is not urgent, but could reduce code duplication between  cw3-dao and cw3-flex-multisig.

Closing for now, will add similar packages when our design is closer to final.


Fix incorrect description

30 mins is old description since there is ScaleDownPeriod.

Good catch! Thanks @meganemura


Programming exercises: Add hint that JetBrains Toolbox needed when setting IDE Preferences

Is your feature request related to a problem?
When cloning a repository multiple options are given:

Depending on the user's settings, the middle button shows: Open in VS Code / IntelliJ / PyCharm / CLion / XCode
If you have chosen any of the JetBrains products, e.g. IntelliJ, and do not have the app "JetBrains Toolbox" installed, and try pressing the button, nothing happens.
Describe the solution you'd like
Maybe add a hint in the settings where you can choose your IDE preferences, that without the JetBrains Toolbox installed, cloning won't work with the "Open in ..." button.

Describe alternatives you've considered
No response
Additional context
No response

So in the settings the little question mark button explains exactly that. but i agree its not that prominent for the user so ill move it into the normal description

Oh I'm sorry, I missed that indeed


oss-directory validation for RetroPGF requirements

What is it?

This might include checking that artifacts have certain levels of activity (e.g. commits older than 90 days)
This might include checking permissions (e.g. user submitting is a member of the org listed)

With gitcoin for their OSS round, we devised a four point check:

was the first commit more than 90 days ago
has there been a recent commit in the last 30 days
have there been more than 10 days of activity in the last 90 days
does the project have more than one contributor
Verify that Github Repo referenced has verification funding.json

FYI, I created a hacky script to do some of these checks for the BuidlBox dataset. It worked pretty well (scanned about 8K projects).
https://github.com/opensource-observer/insights/blob/main/scripts/github.py

For now at least, we need to take a final version of this model and adding a field in here

Here are the checks we want
green check marks

was the first commit more than 90 days ago
more than >20 days commits activity

report in a comment:

(report date of first commit)
(report days of activity)
(report last commit)
(report which license for each repo)
(report num distinct contributors)

Cleaning up some reviewer UX here
https://github.com/opensource-observer/oso/pull/1527

Pretty print the external-prs results
https://github.com/opensource-observer/oso/pull/1529

Going to P2 this based on current traffic. It doesn't look like the inbound traffic to oss-directory is too onerous on the GitHub validation side.
We still want to do these spam checks when we eventually move to a world where we do user-defined projects in the OSO app. Will rescope this issue


Mobile view for contributors site not scaling properly

What feature do you want to see added?
As pointed out in the advocacy & outreach gitter channel, the mobile formatting of the contributor spotlight site could be improved. The feature box for the contributor seems to go off the page, and in the contributor page the text sticks to the center of the page.

Would it be possible to update the mobile formatting so that the presentation is closer to the regular jenkins.io site?
Upstream changes
No response

I will fix this later this week

No worries, thanks very much @krisstern!

Hi @kmartens27 Job done in #32. It will look a lot nicer afterwards on mobile...


Make "Skipping target incompatible node" message tied to verbosity

Looks like we currently eprintln! "Skipping target incompatible node" in a few places, which ends up polluting the terminal regardless of verbosity level.
I can implement this if desired!

Definitely desired! We've love a patch. One approach is to turn that message into a proper event, and then it's easy to have it obey verbosity. Alternatively, you could make console_message obey verbosity. The former is probably the right thing to do, but I'm not totally sure.


fix: increase fragment timeout during OTA update to 2 minutes

fixes: #4407

@zwave-js-bot automerge


Debt - Explorer & Open Editors Context menu needs to adopt menu contribution support

The TFSVC extension should be able to contribute to the "rename" group.

After discussing with @bpasero the following needs to be done:

All actions need to be transitioned into commands. Some of these commands need to get a hold of the active tree which should be done using the listService
Context keys need to be managed by the explorer when selection changes in order to show / hide the actions. e.g context key if the selected file is a folder
Need to use groups to preserve the sorting of actions


UTF-8 conversion uses deprecated codecvt_utf8_utf16

For Edge, built with clang and libc++, std::codecvt_utf8_utf16 with std::wstring behaves poorly. Example conversions would be:

C:\Users\jasbray\AppData\Local\Temp\ to C\sr\aba\pDt\oa\
C\sr\aba\pDt\oa\ to C

The fix for edge was to use u16string for the conversion, which behaves properly in libc++. See #186 Unfortunately, this is known to not work in MSVC.
@maxgolov mentioned that the proper fix is probably to use the win32 API to handle this, since the conversion is windows specific anyways.

Closing, since the impacting part for Edge has been removed, and further cleanup can be tracked in #262


feat: Other Website Downloader/Extractor

Todo:

[x] Implement base extractor class
[x] Twitcasting extractor
[x] Twitter spaces extractor
[ ] Twitch extractor
[ ] Mildom(?) extractor
[x] All around ffmpeg downloader
[x] ihateani.me API wrapper (for Twitch/Twitcasting/Twitter Spaces)

close #10

shut up Gitguardian

Idea: Use Streamlink again so I can download Twitch stream (and maybe more)


Application Updater

A generic application updater using toolkit controls and XML files.

Could use either wizard control (when implemented) or standard winform.


Use HTTPS to connect to rubygems.org server

Just like the default middleman Gemfile.tt

Coverage decreased (-0.1%) to 94.83% when pulling e291cbfd965a4f2f6416355ca2c9927913644240 on cllns:use-https-for-gemfile into ebfd1cc6f0adc60f7b7306288a0e21a251177928 on middleman:master.


gns3-gui,gns3-server: 2.2.47 -> 2.2.49

Description of changes
To merge after #326646

https://github.com/GNS3/gns3-gui/releases/tag/v2.2.49
https://github.com/GNS3/gns3-server/releases/tag/v2.2.49

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 326662 run on x86_64-linux 1

4 packages built:

gns3-gui
gns3-gui.dist
gns3-server
gns3-server.dist


Should report a missing file from tsconfig.json

Like tsc would do:
$ tsc
error TS6053: File 'FooBar.ts' not found.

tsconfig.json:
{
  "compilerOptions": {
    "target": "ES5",
    "noImplicitAny": true,
    "removeComments": true,
    "declaration": true,
    "sourceMap": true,
    "out": ".tmp/app.js"
  },

  "files": [
    "FooBar.ts"
  ]
}

Thanks for the suggestion, I'll try to take a look at this soon.


Changing bsh.prompt has no effect.

After beanshell/beanshell@014e83b changing bsh.prompt has no effect.
BEFORE
bsh % bsh.prompt="hello>";
hello>

NOW
bsh % bsh.prompt="hello";
bsh %

Resolved:
Can now change bsh.prompt and overwrite getBshPrompt again.


Add read message builder

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Codecov Report
Patch coverage has no change and project coverage change: -25.31 :warning:

Comparison is base (192de17) 66.49% compared to head (6eb6794) 41.19%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #785       +/-   ##
===========================================
- Coverage   66.49%   41.19%   -25.31%
===========================================
  Files         231      174       -57
  Lines       22881    18888     -3993
===========================================
- Hits        15214     7780     -7434
- Misses       6874    10772     +3898
+ Partials      793      336      -457

Flag
Coverage Δ

?

go-1.17.x
40.89% <0.00%> (-25.19%)
:arrow_down:

go-1.19.x
41.25% <0.00%> (-24.80%)
:arrow_down:

go-1.20.x
?

integration
?

macOS
41.25% <0.00%> (-0.05%)
:arrow_down:

ubuntu
40.89% <0.00%> (-0.45%)
:arrow_down:

unit
41.19% <0.00%> (-0.19%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/topic/topicreaderinternal/message.go
14.92% <0.00%> (-51.75%)
:arrow_down:

... and 170 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Enable ingress in remote profile

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
af5c43648636d8a9257d1c890024b4fefcf11737
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #554


Violation - The builder (build creator) is not a member of the delivery team

@anjahoffmann the builder could also be a robot and is not clear how to figure it out.
I will close than this issue, if you are not ok with it, come back to me or reopen it.


[QUESTION] RSS widget improvement

Question
I am working on adding two options to RSS widget (I plan a PR):

Optionally don't display item descriptions (only titles)
The ability to display the both date and time, not just the date

But my question is:
Should I change the following fragment in the original widget code:
axios.get(this.endpoint)
  .then((response) => {
    this.processData(response.data);
  })
  .catch((error) => {
    this.error('Unable to RSS feed', error);
  })
  .finally(() => {
    this.finishLoading();
  });

to this one:
this.makeRequest(this.endpoint).then(this.processData);

Seems much cleaner for me :) I am new to Dashy, maybe makeRequest method was added after RSS Widget was created?
Category
Widgets
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Yeah, you're right, it should be that :)
I added makeRequest after I'd already created several of the widgets, and it looks like I forgot to refactor that

I am working on adding two options to RSS widget (I plan a PR):

Optionally don't display item descriptions (only titles)

Was this added as a feature? I was looking for the option in the docs and didn't see it.


can't install sqlite3 with tarball

Issue Summary
I install sqlite3 on windows10 .But npm install<EMAIL_ADDRESS>failed for bad network. download napi-v6-win32-unknown-x64.tar.gz for 5.1.1 . It doesn't work.
Relevant logs or output
npm install napi-v6-win32-unknown-x64.tar.gz
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path C:\Users\zcmky\AppData\Local\npm-cache_cacache\tmp\lK91pL/package.json
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, open 'C:\Users\zcmky\AppData\Local\npm-cache_cacache\tmp\lK91pL\package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
Version
5.1.1
Node.js Version
21.1.0
How did you install the library?
window10

anyone can help me?


Issue upgrading to SPFx 1.4.x

Category

[X] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Observed Behavior
Upgrading from SPFx 1.3.x to version 1.4.x you will get the following compilation errors:
Error - typescript - node_modules/@microsoft/sp-lodash-subset/node_modules/@types/lodash/index.d.ts(19507,14): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error - typescript - node_modules/@types/es6-collections/index.d.ts(76,10): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
However, if you update the tsconfig.json file with the parameter:
"skipLibCheck": true
The compilation works properly. Thus, I'm wondering if there are any regression issues in version 1.4.x.
Steps to Reproduce

Create a SPFx solution with SPFx 1.3.0
Update to 1.4.1
Execute gulp build
You will see the errors above
Add the skipLibCheck parameter to tsconfig.json
Build again: it works

As there are no official upgrade paths from one version to another with SPFx we're on our own here :)
I've seen different config files change, and you have to diff with a fresh project to know what to change in order for something to build properly. Having an auto-upgrade to fix all config changes would be awesome.

Had the error too, solved it when I created a fresh new project and copied the new tsconfig. Would be cool to have a list of config changes to manually replicate when we upgrade the project

As we nowadays have upgrade tooling as CLI for Microsoft 365, that is the one which should be used for these. Closing this one as it seems outdated. If issue is still relevant, please open an new issue.


Add permission to break mine blocks

Issue solved in commit: https://github.com/joserodpt/RealMines/commit/20640b473572a36a04c337a5a093177d18063041
Format: realmines.minename.break
Toggle present in the block's gui.


feat(autocapture-browser): Adding async request/response pattern to Autocapture messenger

Summary
Use unique IDs and a callback map to allow clients to use a request/response pattern for communication to the opener window

@Mercy811 , tag you as reviewer as well, since I know you are working on integrating the autocapture plugin to the Browser SDK.


Make configuration settings more discoverable

Most of what people want is in Configuration Settings and they're not show at TOC level and they should be: https://docs.mattermost.com/guides/administrator.html#administration
People need this:

But people get this:

Fixed in Increased ToC maxdepth to 3 in admin section #1097


custom matcher - Computed imports are not allowed

I'm trying to write a custom matcher using the example in the readme.
i've tried the following,
local test = import "lib/jsonnetunit/jsonnetunit/test.libsonnet";
local deploy = import "templates/deployment-app.libsonnet";

local setMatcher(actual, expected) = import "lib/jsonnetunit/jsonnetunit/matcher.libsonnet" {
    satisfied: true,
    postitiveMessage: "test positive msg",
    netagiveMessage: "test negative msg",
};

test.suite({

but get a Computed imports are not allowed error.
My goal is to be able to assert that a list of objects contains one with a matching "name" and "value". without having to assert the entire list of objects as it is large and some of the k/v's are not in the scope in the this unit test.
env: [
  { "name": "ENVVAR1", "value": "VAL1" },
  { "name": "ENVVAR2, "value": "VAL2" },
  ...
]

i.e 'assert that AN object in the array contains "ENVVAR1" = "VAL1"'

If the import is on its own line at the top of the file, this works fine.


added namespace qualifier to Process

When also using Guard::Process, Guard::Shotgun raised errors such as
NoMethodError: undefined method 'getpgid' for Guard::Process:Class due to a naming conflict.
This changeset ensures that Guard::Shotgun uses the Process class from stdlib.

Thanks @Mask!


Implement Update tool Admin API

Description:

A new service to be developed which can be used to update release versions in the update tool database.
This will be secured with mutual auth.
Admin API will have POST “/distribution”. This should update following

New distribution released
New dependency of the release

Action Items:

Create a dummy service to add distribution. -> Will return 200 “API Works”
Create a new AdminAPI service in ballerina-registry repository - it will be a new module
Move the implementation of add Distribution into admin API
Get the functionality to work
Write unit tests for the service

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

close this item as we have another issue


Allow ExecutorProvider to be passed in to PubSubTemplate

In #50, some suggested polishing changes surfaced a bigger issue. We might want to either use the default ExecutorProvider (with 4 threads by default) or, instead, allow the user to specify their own ExecutorProvider implementation.
We should look into injecting the ExecutorProvider into the PubSubTemplate which, right now, isn't possible in SI, since PubSubMessageHandler uses new PubSubTemplate() instead of injecting it.
Another issue is that re-using the same ExecutorProvider does not guarantee that only one Executor is generated, thereby reducing the number of created threads, which was the motivation behind the reuse.

As mentioned in the comments on the PR #50. We should probably just create a PublisherFactory abstraction and make PubSubTemplate depend on it.

The same should probably also apply for the Subscriber in PubSubInboundChannelAdapter.

The PubsubTemplate is based now on the PublisherFactory, where the DefaultPublisherFactory is supplied with the ExecutorProvider, so, I consider this issue as fixed.
(Can't find the commit, but fix is in the place any way...)

FTR the fix is #61 (GitHub doesn't appear to understand "Fixes #x, #y" notation)


Possible options for images background position?

default value is center, but i write follow options, they don't work:
left
right
center left
center right
and background size I choose manual. it is a picture with 900*580px
Mac. Atom 1.20

these options works on windows。

this is CSS related and EB cannot do anything with it.
mdn
w3


Queue [Python]

This issue is about Queue.

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

The contributors most likely able to help are:
@manish1997
Possible duplicate or related issues are:

#345: Gradient Descent [Python]
#478: Algo/largest_sum_contiguous_subarray [C++]
#391: Shell Sort [Java]
#428: Add badges to README.md
#427: Sleep Sort [Golang]

Can I be assigned to this issue if no one's working on it?

go for it - i am not going to be able to meet the required 'submit a PR within a week of issue creation'


fix(preset-attributify): adjust check prefixOnly order

close #2037
~Validate prefixOnly option in advance. Update the test, found that there was a bug before😅.~

This is not fixing issue #2037.

Modified lines are added in v0.48.0, so it's unrelated to the issue, And the tests are correct. This is expected behaviour for prefixedOnly option. It will only apply to attributes, not classes defined in class attribute.

Both 0.46.5 and 0.47.0 versions behave the same with the config in the first comment of the issue. This is expected behaviour for the default splitter and it will be applied if strict mode is not enabled or presetAtrributify is completely disabled, like in the first comment.

The real issue in this comment. And it's not even related to these lines. It's related to these lines in following order:
https://github.com/unocss/unocss/blob/53a3164c96f59451d9b773cd976642bbd70dfec4/packages/preset-attributify/src/extractor.ts#L43-L49
https://github.com/unocss/unocss/blob/a3c8bed20e8182f99ed217283e3da6a3836991e5/packages/core/src/utils/helpers.ts#L12-L14
We should return false if the selector ends with colon : character.

I also realized that the test was correct, forgive my carelessness. I have located the error? Allow me to fix it later due to time difference


chore: bdd-gh-1576061308 to 0.0.1

chore: Promote bdd-gh-1576061308 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


About the original cobb angle calc

Very nice work man!
I wanted to ask you about the original source of the cobb_angle_calc function. You mention it was transferred from Matlab. As far as I understood the code, the angle1 seems to be the maximun angle. It is not main thoracic or proximal thoracic or thoracolumbar.
The second and the third are computed diferently in case the spine has a shape of s. If the shape is not an s, the second is the angle among the first vertebra and the upper vertebra of the first angle, and the third is the angle among the lowest vertebra and the lower vertebra of the first angle.
Right?
When the spine has a shape of s, and the first angle belongs to the lower side of the image, it takes as second angle the maximun possible angle among the top vertebra and the upper vertebra of the first angle. Afterwards, the next angle is the second maximun.
If the spine has a s shape only, it takes as second angle the maximun possible angle in the top, and as third the maximun possible angle at the bottom.
That may mean that these angle1 angle2 angle3 are not main thoracic, proximal thoracic and tharocolumbar since they may change..
Does this makes sense?

I mailed them, thanks a lot!


Not update on platformio - libray.json problem

Hello,
The version on PlateformeIO is 0.1.5 and not the last one.
I have a workaround.
Can you, please, update it ?
Thanks.

I am updating libraries and moving them to their own repo. This makes handling issues easier.
Will check on this asap

PLatform IO probably takes the copy from my combined repo https://github.com/RobTillaart/Arduino
I updated the DHTNEW lib there too, so now wait until it is picked up by platformIO
Feel free to (re)register the lib yourself, I never registered any of my libs @ platformIO,
https://docs.platformio.org/en/latest/core/userguide/lib/cmd_register.html#cmd-lib-register

Hello,
thanks a lot but I still have a problem. Only the library.json is downloaded, I tried several time.
I also tried to register the library on PlatformIO but it looks like some informations are missing in library.json.
user@prometheus DHTNEW_ID5548 % platformio lib register https://github.com/RobTillaart/Arduino/blob/master/libraries/DHTNEW/library.json
Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)
user@prometheus DHTNEW_ID5548 % platformio lib register https://github.com/RobTillaart/Arduino/blob/master/libraries/DHTNEW/library.properties
Error: Invalid manifest fields: {'description': ['Length must be between 1 and 1000.'], 'version': ['Missing data for required field.']}.
Please check specification -> https://docs.platformio.org/page/librarymanager/config.html
user@prometheus DHTNEW_ID5548 % platformio lib register https://github.com/RobTillaart/DHTNew/blob/master/library.json                  Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)

Seems like I made an syntax error in the json file. Need to check the specification.
Thanks for the error msg and reporting

First I look at the second part of the error message:
description field
verified against - https://docs.platformio.org/en/latest/librarymanager/config.html#description
The description field is a string,
the length is smaller than 255
the length is 95 so between 1 and 1000 (the error message)
So it seems to me that the error message does not mention the real/correct cause
version field
https://docs.platformio.org/en/latest/librarymanager/config.html#version
The version field is a string
The length is smaller than 20
The format is according the semantic versioning rules, three numbers separated by dots .

I agree and I don't understand the message.
I compared with another projet and I can't find any problem.

Same bug is mentioned - https://github.com/platformio/platformio-libmirror/issues/173
but in that case the version field was indeed not available

installed platformio on my computer - c:\users\Rob.platformio\penv\Lib\site-packages
in that folder there are the following python scripts:
platformio\package\exception.py  holds the Invalid fields text message [line 34]
printed after a ManifestValidationError
platformio\package\manifest\schema.py raises this ManifestValidationError [line 41, 53]
these lines are probably used by ManifestSchema(baseSchema)   [line 150]
this is called in platformio\commands\lib.py  [line 505]
that calls  ManifestParserFactory.new_from_url(config_url)  which is in parser.py
and that loads the file.

No clue from the code..
The other error
platformio.exe lib register https://github.com/RobTillaart/Arduino/tree/master/libraries/DHTNEW/library.json
returns  Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)
platformio.exe lib register https://github.com/RobTillaart/DHTNew/library.json
just crashes in a long stacktrace resulting in a 404 error
platformio.exe lib register https://github.com/RobTillaart/DHTNew/blob/master/library.json
Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)
So at least after a few hours I am able to reproduce the other error

DId a rewrite of the library.json file - https://github.com/RobTillaart/DHTNew/pull/10
but still got the same error ..

OK, I noticed now that you did use the library.PROPERTIES file in the second error message while platformio expects you to give library.JSON file.
WRONG parameter ==> So that one is solved

I tried both, JSON and PROPERTIES, and I get different errors.
As mentioned in URL below, register can take library.json, library.properties or module.json. Only one is needed to register.
https://docs.platformio.org/en/latest/core/userguide/lib/cmd_register.html#description
% platformio lib register https://github.com/RobTillaart/Arduino/blob/master/libraries/DHTNEW/library.json
Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)

Im new to platformIO too. But the error message given on the properties file are sbout missing json fields. So the tools used are not that robust yet.
The other error is still strange, will investigate coming days.

I tried both, JSON and PROPERTIES, and I get different errors.
As mentioned in URL below, register can take library.json, library.properties or module.json. Only one is needed to register.
https://docs.platformio.org/en/latest/core/userguide/lib/cmd_register.html#description
% platformio lib register https://github.com/RobTillaart/Arduino/blob/master/libraries/DHTNEW/library.json
Error: Could not parse manifest -> Expecting value: line 6 column 1 (char 5)

As far as I understood the register code, the error message came from parsing the library properties file as if it was a library.json file.
The "line 6" error is still there, as said 3 post back, will be working on it later when time permits.

Had a quick check with two repo's that have a different library.json file than mine
platformio.exe lib register https://github.com/PaulStoffregen/OneWire.git
platformio.exe lib register https://github.com/milesburton/Arduino-Temperature-Control-Library.git

both gave the same "Line 6" error message on a completely other repository, other file.
So I think you should file an issue at the platformio.org site as the library.json file follows the documentation and the error is seen on at least 3 different instances of the file.
Please let me know if you get a solution from platformio people.

You get the library working when referring directly to it in your projects platform.ini file:
lib_deps =   https://github.com/RobTillaart/DHTNew

@fmatray
Can you confirm the solutionof alrabe?

As I got no feedback I assume the problem is solved.