No migrations to rollback

I am tearing my hair out here. Given I have the following Symfony commands:
<?php declare(strict_types=1);

namespace MicronResearch\Tenancy\Command;

use Phinx\Console\PhinxApplication;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class MigrateLandlord extends Command
{
    protected Application $phinx;

    public function __construct(Application $phinx = null)
    {
        parent::__construct();
        $this->phinx = $phinx ?? new PhinxApplication();
    }

    protected function configure(): void
    {
        $this->setName("landlord:migrate")
            ->setDescription("Migrate the Landlord database");
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $this->phinx = new PhinxApplication();

        $arguments = [
            'command' => 'migrate',
            '--environment' => 'landlord',
            '--configuration' => dirname(dirname(__DIR__)) . '/phinx.php',
            '-vvv'
        ];

        return $this->phinx->run(new ArrayInput($arguments), $output);
    }
}

<?php declare(strict_types=1);

namespace MicronResearch\Tenancy\Command;

use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ResetLandlord extends MigrateLandlord
{
    protected function configure(): void
    {
        $this->setName("landlord:reset")
            ->setDescription("Reset the Landlord database to a clean migration");
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $arguments = [
            'command' => 'rollback',
            '--target' => 0,
            '--environment' => 'landlord',
            '--configuration' => dirname(dirname(__DIR__)) . '/phinx.php',
            '-vvv'
        ];

        $this->phinx->run(new ArrayInput($arguments), $output);

        return parent::execute($input, $output);
    }
}

I cannot figure out why phinx refuses to see the migrations that have been applied to roll them back!
$ ./tenancy landlord:migrate
Phinx by CakePHP - https://phinx.org.

using config file phinx.php
using config parser php
using migration paths
 - /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations
using seed paths
 - /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Seeds
using environment landlord
using adapter mysql
using database landlord
ordering by execution time
Migration file
    /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php
    /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php
Valid migration file /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php.
Loading class MicronResearch\Tenancy\Migrations\CreateTenantsTable from /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php.
Running MicronResearch\Tenancy\Migrations\CreateTenantsTable.
Valid migration file /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php.
Loading class MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable from /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php.
Running MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable.
CREATE TABLE `migrations` (`version` BIGINT(20) NOT NULL, `migration_name` VARCHAR(100) NULL, `start_time` TIMESTAMP NULL, `end_time` TIMESTAMP NULL, `breakpoint` TINYINT(1) NOT NULL DEFAULT 0, PRIMARY KEY (`version`)) ENGINE = InnoDB CHARACTER SET utf8 COLLATE utf8_general_ci;

 ==<PHONE_NUMBER>0001 MicronResearch\Tenancy\Migrations\CreateTenantsTable: migrating
START TRANSACTION;
 -- createTable('tenants')
CREATE TABLE `tenants` (`id` INT(11) NOT NULL AUTO_INCREMENT, `uuid_bin` BINARY(16) NOT NULL, `uuid` VARCHAR(36) NOT NULL, `code` VARCHAR(127) NOT NULL, `name` VARCHAR(255) NOT NULL, `is_active` INT(1) NOT NULL DEFAULT 1, PRIMARY KEY (`id`)) ENGINE = InnoDB CHARACTER SET utf8 COLLATE utf8_general_ci;
    -> 0.0082s
COMMIT;
INSERT INTO `migrations` (`version`, `migration_name`, `start_time`, `end_time`, `breakpoint`) VALUES ('00000000000001', 'MicronResearch\Tenancy\Migrations\CreateTenantsTable', '2021-07-23 17:13:39', '2021-07-23 17:13:39', 0);
 ==<PHONE_NUMBER>0001 MicronResearch\Tenancy\Migrations\CreateTenantsTable: migrated 0.0140s

 ==<PHONE_NUMBER>0002 MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable: migrating
START TRANSACTION;
 -- createTable('tenant_connections')
CREATE TABLE `tenant_connections` (`id` INT(11) NOT NULL AUTO_INCREMENT, `tenant_id` INT(11) NOT NULL, `name` VARCHAR(255) NOT NULL, `driver` VARCHAR(255) NOT NULL DEFAULT 'mysql', `host` VARCHAR(255) NOT NULL, `database` VARCHAR(255) NOT NULL, `username` VARCHAR(255) NOT NULL, `password` VARCHAR(255) NOT NULL, `port` INT(12) NOT NULL DEFAULT 3306, `options` TEXT NOT NULL DEFAULT 'charset=utf8mb4', PRIMARY KEY (`id`)) ENGINE = InnoDB CHARACTER SET utf8 COLLATE utf8_general_ci;
    -> 0.0114s
 -- Altering table tenant_connections
ALTER TABLE `tenant_connections` ADD  FOREIGN KEY (`tenant_id`) REFERENCES `tenants` (`id`) ON DELETE CASCADE ON UPDATE CASCADE;
    -> 0.0207s
 -- Altering table tenant_connections
    -> 0.0000s
COMMIT;
INSERT INTO `migrations` (`version`, `migration_name`, `start_time`, `end_time`, `breakpoint`) VALUES ('00000000000002', 'MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable', '2021-07-23 17:13:39', '2021-07-23 17:13:39', 0);
 ==<PHONE_NUMBER>0002 MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable: migrated 0.0418s

All Done. Took 0.0822s

Works fine and creates the correct tables and migrations in the right table.
$ ./tenancy landlord:reset
Phinx by CakePHP - https://phinx.org.

using config file phinx.php
using config parser php
using migration paths
 - /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations
using seed paths
 - /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Seeds
using environment landlord
using adapter mysql
using database landlord
ordering by execution time
Migration file
    /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php
    /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php
Valid migration file /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php.
Loading class MicronResearch\Tenancy\Migrations\CreateTenantsTable from /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000001_create_tenants_table.php.
Running MicronResearch\Tenancy\Migrations\CreateTenantsTable.
Valid migration file /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php.
Loading class MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable from /Volumes/Micron Research/Projects/mars-three/api/libs/micron/tenancy/src/Migrations/00000000000002_create_tenant_connections_table.php.
Running MicronResearch\Tenancy\Migrations\CreateTenantConnectionsTable.
No migrations to rollback

All Done. Took 0.0171s

This command never works and always tells me there are no migrations to rollback, even though it is the exact same config and the records are present in the database.
Even if I run rollback as a phinx command on the cli with the right config and settings, I still get 'no migrations to rollback'.
If anyone has any insight I would greatly appreciate it.

I will point out that my migrations use up and down methods as I have custom sql (if it's MySQL) to run that isn't possible to run in the change method.

I had my migrations simply named as they are not date specific, so the files are not using real dates as shown above. Technically speaking they are real dates, so why would this fail?

:( I'm seeing this behavior as well with phinx 0.9.2.

I am unable to replicate this bug on the latest version:
mpeveler@Bishop:~/github/phinx$ bin/phinx status
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
ordering by creation time

 Status  [Migration ID]  Started              Finished             Migration Name
----------------------------------------------------------------------------------
   down<PHONE_NUMBER>1821                                            Foo
   down<PHONE_NUMBER>1823                                            Bar

mpeveler@Bishop:~/github/phinx$ bin/phinx migrate
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
using adapter sqlite
using database phinx_test.sqlite3
ordering by creation time

 ==<PHONE_NUMBER>1821 Foo: migrating
 ==<PHONE_NUMBER>1821 Foo: migrated 0.0188s

 ==<PHONE_NUMBER>1823 Bar: migrating
 ==<PHONE_NUMBER>1823 Bar: migrated 0.0145s

All Done. Took 0.0362s
mpeveler@Bishop:~/github/phinx$ bin/phinx status
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
ordering by creation time

 Status  [Migration ID]  Started              Finished             Migration Name
----------------------------------------------------------------------------------
     up<PHONE_NUMBER>1821  2024-12-03 03:18:28  2024-12-03 03:18:28  Foo
     up<PHONE_NUMBER>1823  2024-12-03 03:18:28  2024-12-03 03:18:28  Bar

mpeveler@Bishop:~/github/phinx$ bin/phinx rollback --target 0
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
using adapter sqlite
using database phinx_test.sqlite3
ordering by creation time

 ==<PHONE_NUMBER>1823 Bar: reverting
 ==<PHONE_NUMBER>1823 Bar: reverted 0.0189s

 ==<PHONE_NUMBER>1821 Foo: reverting
 ==<PHONE_NUMBER>1821 Foo: reverted 0.0154s

All Done. Took 0.0369s
mpeveler@Bishop:~/github/phinx$ bin/phinx status
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
ordering by creation time

 Status  [Migration ID]  Started              Finished             Migration Name
----------------------------------------------------------------------------------
   down<PHONE_NUMBER>1821                                            Foo
   down<PHONE_NUMBER>1823                                            Bar

It's possible it's been fixed, though I don't think there's been any explicit changes to target handling, so I'm not sure. Going to mark as closed for now.


Errors: Typo fix

Removed extra "a" from Line 77: "transaction matches [a] an error number defined in the IDL"

Thanks!


[SU-5] Disable save column settings if workspace is read only or locked

Fixup for #2878.
Saving column settings requires updating workspace attributes. If the user does not have write access to the workspace or the workspace is locked, that API request will fail. This disables the save button and adds a tooltip for those cases.

@nawatts it looks like there is a deployment/test issue

@nawatts I approved this because I think it solves the problem. However, the spinning overlay and disabled button are a bit ugly when you open the dialog. I could see changing the code so that the Data tab loads the WorkspaceDetails as an async call, and passes the Workspace Details to the dialog (if they have returned). Or perhaps some caching, as it seems this data is loaded every time the dialog is displayed.

The spinner overlay seemed to be a pattern in most every modal I've seen so far (for example, share workspace or delete workspace). Likewise with loading data from the API close to where it's used. Alternatively, here, the workspace could be plumbed through from EntitiesContent or DataStepContent.

I personally have spinner fatigue (for example, see https://broadworkbench.atlassian.net/browse/WOR-185 for what happens when we use spinners on every Ajax load), but it's true, you are following existing examples. If the relevant data is already available in the container that spans the dialog, definitely just pass it in. But if it's going to be more complicated than that, I'm fine with you sticking with your current solution.

Plumbed the workspace through for getting the access level and locked status. That at least takes care of the save button switching from disabled to enabled. Still need to refresh the saved column settings to make sure they're up to date though.
One thing we could possibly try is changing the spinner component to only render after ~100ms so that they stay out of the way when API requests are fast.

@cahrens you approved earlier, but there have been several changes since. What do think of this in its current state?

@cahrens you approved earlier, but there have been several changes since. What do think of this in its current state?

@nawatts Watching how this PR has evolved, it's an excellent example of the trade-offs between passing state through multiple components to avoid an extra fetch vs. isolating the state needed in a component. I really am on the fence about which approach is better, and like you said, we have to have a spinner on the dialog anyway (the initially disabled button might not be a big deal given the spinner).
So if you would prefer to revert to https://github.com/DataBiosphere/terra-ui/pull/2886/commits/33ba4675194fa98c6bccb66b0b3e62ead7dc72a7, that's fine with me-- go with whichever approach you think is cleanest.


[Lake][Data Quality] Add pydantic to validate schema at the lake-level

Background / motivation
The current table schemas use types but are poorly validated. We also can't leverage validation wrappers because it's just using a generic type.
Rather: let's implement a validation tool like pydantic to validate data through our system, and in our lake
DoD

[ ] Update table schema definitions to use pydantic
[ ] Update lake validate cli to validate lake schema vs. expected schema

We're not going to do the pydantic working any longer, since we updated our schema and tables recently


[WIP] Realtime client tests

Thanks for the WIP update.

Little update
I was implementing the test for RTC1e(realtimeHost and restHost changes) and I faced some problems:

Weird test results;
No error when the WebSocket tries to connect an invalid host.

tl;dr
⚠ Important rule for async tests:
We must ensure the test does not finish until the asynchronous call is done and the best solution for those cases is: XCTestExpectation.

I suspected the problem was the asynchronous code. So I created a new project and made some tests.
First test:
describe("quick") {
  it("does it performs well with background work") {
    dispatch_async(dispatch_get_main_queue()) {
        expect(false).to(equal(true))
        NSLog("Done")
    }
  }
}

And my surprise was: Test Case '-[ProjectTests.ProjectTests quick__does_it_performs_well_with_background_work]' passed (0.002 seconds).
I need something in order to block the test from finishing before the async code does
Second test:
describe("async") {
  it("does it performs well with background work") {
    var done = false

    dispatch_async(dispatch_get_main_queue()) {
        expect(false).to(equal(true))
        NSLog("Done")
        done = true
    }

    // Wait until finished
    while !done {
        CFRunLoopRunInMode(kCFRunLoopDefaultMode, CFTimeInterval(0.1), false)
    }
  }
}

Result: [ProjectTests.ProjectTests quick__does_it_performs_well_with_background_work] : failed - expected to equal <true>, got <false>
Success!
Now the test works with asynchronous code but I think using a while loop isn't the best approach.
I investigate more about it and Xcode testing suite has a nice feature for those cases 🙈.
The code:
describe("async") {
  it("does it performs well with background work") {
    let expectation = self.expectationWithDescription("async")

    CFRunLoopPerformBlock(CFRunLoopGetMain(), kCFRunLoopCommonModes) {
        expect(false).to(equal(true))
        NSLog("Done")

        expectation.fulfill()
    }

    self.waitForExpectationsWithTimeout(10.0, handler: nil)
  }
}

@ricardopereira FYI, in Ruby we had similar issues in regards to ensuring the test waits before completion.  Fortunately, Ruby is quite flexible, and what I was able to do was wrap our test blocks / closures with an EventMachine block that will wait until the EventMachine reactor (evented system) is explicitly killed, see https://github.com/ably/ably-ruby/blob/master/spec/support/event_machine_helper.rb#L67-L104 if it means anything to you.
I also recently realise that we were not closing connections explicitly automatically at the end of tests, so added https://github.com/ably/ably-ruby/commit/1abbc8c1bd67790d67c13e2209027837bc17ffc5 to ensure a connection is closed from one test before the next test starts

@mattheworiordan merge please.


Warning for log-level

Describe the bug
When setting the log level, I receive the following error:
Invalid 'log-level' , default to [Warning]

To Reproduce

Run the mailchain application with any of the following:./mailchain serve --log-level=debug
./mailchain serve --log-level debug
./mailchain serve --log-level=Debug
./mailchain serve --log-level Debug

See error: WARN[0000] Invalid 'log-level' , default to [Warning]

What version of Mailchain are you using ?
Version: v0.0.2
Expected behavior
It should accept the arguement with --log-level debug or --log-level=debug
Desktop (please complete the following information):

Mac, OS X 14.4

Also the config flag does not work


Update the game over message

Update the game over message so people know how to play again!

initial thoughts on the pull request.

initial thoughts on the pull request.

initial thoughts on the pull request.

zzz

initial thoughts on the pull request.


adding some changes and  new faq

please review this my PR , i hope it can be merged

thanks @tzarebczan , collabs again. hooray. please review my referenced PR sir.


Try not to clash with macro names

OS_* macros might clash, rename to TERMCOLOR_OS_*
Signed-off-by: nabijaczleweli<EMAIL_ADDRESS>

Awesome! Thank you. :)


LA_ICQ: enable support in sample_encode

./sample_encode h264 -i xxx.yuv -o xxx.h264 ...... -laicq ICQQualityFactor -lad LookAheadDepth
ICQQualityFactor should be in [0, 51]
LookAheadDepth should be in [10, 100]
Change-Id: I84cc422460dbfc9dc1b0023265aec0e37e17da01

I have changed the title and codes have been rebased.

I have updated the codes. Please help to review it. Thanks! @dvrogozh @onabiull

I have had the codes rebased.


[Chapters of the book] Improvements in CTA

Description

1> The icon is very small, make it bigger

2> There are 2 duplicate CTA's we need to keep only 1.
Expected Behavior

Screenshots/Logs

Environment:

Meshery Version:
Kubernetes Version:
Host OS:
Browser:

@leecalcote @Nikhil-Ladha should be make the second CTA redirect to slack?  as both are redirecting to same place.

I would love to work on this @legendarykamal .

@sam1code it'd be good to see the other four that you have assigned completed first (or at least of all them under PR review).

Yes only one remaining I'll be creating pr of the kat one in some times

Can I work over this if it still exist?

You can work on this issue @AbhishekTiwari23 .
Though, not that the requirement is to change to callout to "Layer5 Dlack Workspace" with the slack icon (whitewashed) in the beginning (just like now).

@legendarykamal sir, can you please share the ink for that page where I have to make changes.
It will be thankful for me.

Is it this one ?

Oh, now I get it. I apologise for the inconvenience

Hello @legendarykamal @Nikhil-Ladha, sir, this is my first time when am contributing to this repo, and I am trying but not able to set it up on localhost. Can u please guide me? I followed all the steps of contributing.MD file, and there are no steps mentioned for this. I will be thankful if you guide me.

Just navigate to the site directory and execute the npm install and npm start commands. That should do the job.

https://user-images.githubusercontent.com/97469132/196407085-ad1a9945-4ba7-45a6-b3cc-35f61babc3f7.mov
Is it fine?

@debo19 I forgot your suggestion for the callout on this page, can you please re-iterate here?

Just change the content on the second callout to point to something else like layer5.io/projects or layer5.io/learn/learning-paths

@UtkarshMishra12

@AbhishekTiwari23 are you still working on this?

Is this issue still valid? @legendarykamal

@UtkarshMishra12 not able to reproduce. Closing. Open again if you feel this issue needs more attention.


feat(circus): enable writing async test event handlers

Summary
While jest-circus provides handleTestEvent(event, state): void interface, it is not helpful for some scenarios inherent to end-to-end testing, as in case of Detox.
I'll illustrate that by a couple of examples:
Decide the fate of a test artifact
Let's say we have those in our <setupFilesAfterEnv>.js file:
beforeEach(async () => {
  await startVideoRecording();
});

afterEach(async () => {
  await endVideoRecording();

  if (isTestPassing()) {
    await removeVideoRecordingFromDevice();
  } else {
    await pullVideoRecordingFromDeviceAndSave();
  }
});

The problem here, that inside afterEach hook, you can't know for sure whether the entire test is passing or failing, because you are still executing its part, albeit a mere and probably the last hook.
If we move our logic to handleTestEvent provided by jest-circus, then everything is fine...
class DetoxCircusEnvironment {
  async handleTestEvent(event) {
    if (event.name === 'test_start') {
      await startVideoRecording();
    }

    if (event.name === 'test_done') {
      await endVideoRecording();

      if (event.test.errors.length === 0) {
        await removeVideoRecordingFromDevice();
      } else {
        await pullVideoRecordingFromDeviceAndSave();
      }
    }
  }
}

... except for the fact that you can't simply make handleTestEvent asynchronous. :slightly_smiling_face:
And this is what this pull request is trying to solve.
Take a screenshot right after an error happens
If you want to take a screenshot right after a failed expectation or any other error, theoretically, you could write something like this:
it('should fail somewhere', () => {
  try {
    await expect(element(by.id('unexisting'))).toBeVisible();
  } catch (e) {
    await device.takeScreenshot('failure');
    throw e;
  }
});

You could even write a wrapper for it, e.g. safeIt or monkey-patch it. But then, there are also beforeEach, afterEach, beforeAll and afterAll hooks, which can be renamed to safe... or monkey-patched as well. In theory, there are also test, test.each and some other functions, and one could take them into the account too.
But is it the right solution, when jest-circus provides the API for handling test failures?
class DetoxCircusEnvironment {
  async handleTestEvent(event) {
    if (event.name === 'test_fn_failure') {
      await takeScreenshot('testFailure');
    }

    if (event.name === 'hook_failure') {
      await takeScreenshot('${event.hook.type}Failure');
    }
  }
}

Again, here we hit the limitation that you can't make it actually await before proceeding.
That leaves us with a chance that another afterEach hook or next E2E test is going to run while our spawned child process is making a screenshot on iOS or Android. Having a race condition, even if a hypothetical one, is not something that we would want to have when speaking of consistent post-error screenshots. I would prefer to know for sure that we await for such artifact actions to be completed before proceeding any further.
Conclusion
Making handleTestEvent asynchronous will simplify and improve a few essential things in Detox: user setup and better post-test artifacts.

No need to call detox.beforeEach and detox.afterEach (or adapters) inside user code. Detox will take care of that itself via jest-circus. The setup part will be able to shrink significantly to:

jest.setTimeout(120000);

beforeAll(async () => {
  await detox.init(config);
}, 300000);

afterAll(async () => {
  await detox.cleanup();
});

Ubiquitous and consistent error handling as a test scenario goes, compare:

Current Jest Circus: https://jenkins-oss.wixpress.com/job/multi-detox-pr/1862/
Forked Jest Circus: https://jenkins-oss.wixpress.com/job/multi-detox-pr/1861/
In this build, I deliberately fail two tests, one in beforeEach hook, second — in it test function, and with my fork of jest-circus I become able to get distinct post-error screenshots for both those tests:

Test plan

I have tested the change with Detox e2e test suite, and superficially it works OK and I receive what I expect there. The test runner completes without any weird or suspicious messages, and the failures can be seen only in places where I expect them to be.

I have run yarn on the entire jest monorepo, and it has not yielded any errors.

Still, I think, I might need your guidance on how better to test this change. Your ideas are very welcome.
Looking forward to our collaboration,
Yaroslav.

Codecov Report

Merging #9397 into master will decrease coverage by <.01%.
The diff coverage is 12%.

@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
- Coverage   64.75%   64.74%   -0.01%
==========================================
  Files         280      280
  Lines       11986    11989       +3
  Branches     2956     2956
==========================================
+ Hits         7761     7762       +1
- Misses       3592     3594       +2
  Partials      633      633

Impacted Files
Coverage Δ

...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts
0% <0%> (ø)
:arrow_up:

packages/jest-circus/src/globalErrorHandlers.ts
17.64% <0%> (ø)
:arrow_up:

packages/jest-circus/src/run.ts
0% <0%> (ø)
:arrow_up:

packages/jest-circus/src/index.ts
68.05% <25%> (ø)
:arrow_up:

packages/jest-circus/src/state.ts
75% <50%> (-9.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc86f50...9d38078. Read the comment docs.

@SimenB, so, how do you think, will adding such kind of a test suffice or we need something more?
import {runTest} from '../__mocks__/testUtils';

test('test event handler should be able to be async and pause the flow', () => {
  const {stdout} = runTest(`
    describe('slowdown via testEventHandler', () => {
      let t0;
      beforeEach(() => { t0 = Date.now() });
      it(':slowdown(1000):', () => {});
      afterEach(() => expect(Date.now() - t0).toBeGreaterThan(1000));
    });

    describe('no slowdown', () => {
      let t0;
      beforeEach(() => { t0 = Date.now() });
      it('fast test', () => {});
      afterEach(() => expect(Date.now() - t0).toBeLessThan(100));
    });
  `);

  expect(stdout).toMatchSnapshot();
});

The idea is to add a couple of lines to __mocks__/testEventHandler.ts that make it sleep for extra 1000ms on test_fn_start if test.name === ':slowdown(1000):. This way we prove the hook can pause the flow due to its first-class asynchronousity.

cc @scotthovestadt for FB implications

🎉
I'd like to see a test or two plus documentation updates (look at #8344 for where to update docs) before landing this.
One thing when we don't

Codecov Report

Merging #9397 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
- Coverage   65.09%   65.07%   -0.02%
==========================================
  Files         287      287
  Lines       12144    12149       +5
  Branches     3009     3007       -2
==========================================
+ Hits         7905     7906       +1
- Misses       3604     3608       +4
  Partials      635      635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3aa106...64185cd. Read the comment docs.

Codecov Report

Merging #9397 into master will decrease coverage by 0.01%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
- Coverage   65.09%   65.07%   -0.02%
==========================================
  Files         287      287
  Lines       12144    12149       +5
  Branches     3009     3009
==========================================
+ Hits         7905     7906       +1
- Misses       3604     3608       +4
  Partials      635      635

Impacted Files
Coverage Δ

...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts
0% <0%> (ø)
:arrow_up:

...circus/src/legacy-code-todo-rewrite/jestAdapter.ts
0% <0%> (ø)
:arrow_up:

packages/jest-circus/src/globalErrorHandlers.ts
17.64% <0%> (ø)
:arrow_up:

packages/jest-circus/src/run.ts
0% <0%> (ø)
:arrow_up:

packages/jest-circus/src/eventHandler.ts
7.05% <100%> (ø)
:arrow_up:

packages/jest-circus/src/index.ts
68.05% <25%> (ø)
:arrow_up:

packages/jest-circus/src/state.ts
75% <50%> (-9.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3aa106...64185cd. Read the comment docs.

Codecov Report

Merging #9397 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
- Coverage   65.09%   65.07%   -0.02%
==========================================
  Files         287      287
  Lines       12144    12149       +5
  Branches     3009     3009
==========================================
+ Hits         7905     7906       +1
- Misses       3604     3608       +4
  Partials      635      635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3aa106...f3a8af0. Read the comment docs.

@SimenB , how do you think are we ready now to get merged?

This is amazing! 🥇

Hey guys, is there anything missing you want us to take care of? Or can this be merged?
Thanks!

Codecov Report

Merging #9397 into master will decrease coverage by 0.01%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
- Coverage   64.92%   64.91%   -0.02%
==========================================
  Files         288      288
  Lines       12184    12189       +5
  Branches     3022     3022
==========================================
+ Hits         7911     7912       +1
- Misses       3635     3639       +4
  Partials      638      638

Impacted Files
Coverage Δ

packages/jest-circus/src/globalErrorHandlers.ts
17.64% <0.00%> (ø)

...circus/src/legacy-code-todo-rewrite/jestAdapter.ts
0.00% <0.00%> (ø)

...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts
0.00% <0.00%> (ø)

packages/jest-circus/src/run.ts
0.00% <0.00%> (ø)

packages/jest-circus/src/index.ts
68.05% <25.00%> (ø)

packages/jest-circus/src/state.ts
75.00% <50.00%> (-9.62%)
:arrow_down:

packages/jest-circus/src/eventHandler.ts
7.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd98198...3ee2a23. Read the comment docs.

Okay, so, I hope I have addressed all the review comments at the moment.
@SimenB, let me know if I need to fix anything else here.

@SimenB, I am not sure to whom the question is addressed, but from my side, it looks like an extension to the existing contract, which does not break anything that existed before.
The only caveat I personally see here is maybe some potential TypeScript errors (that explicit state, action typing) if somebody was using a custom environment. As we see these errors won't necessarily emerge, but we have witnessed one case like this.

Right, that's my thinking as well. We're now supporting something we didn't support before, so it shouldn't break anyone.
Allright, then I'm thinking I'll merge and release this tomorrow unless somebody thinks we should not 🙂
(Last ping, I swear) @cpojer @DiZy @scotthovestadt

Thanks for the great PR and patience @noomorph!

@noomorph available in https://github.com/facebook/jest/releases/tag/v25.3.0, looking forward to seeing what you build with it. 🙂

Thrilled to see the release, thanks much! Now the ball is in my court, right. Stay tuned :-)


not working in console?

Why does this not work?
class Program
{
    static IKeyboardMouseEvents _hook;

    static void Main(string[] args)
    {
        _hook = Hook.GlobalEvents();
        _hook.KeyDown += _hook_KeyDown;

        Console.ReadLine();
    }

    private static void _hook_KeyDown(object sender, System.Windows.Forms.KeyEventArgs e)
    {
        Console.WriteLine("key {0}", e.KeyCode);

    }
}

https://github.com/gmamaladze/globalmousekeyhook/issues/3 -looks like this is issue #3


Candidates are now ordered by votes when creating a spreasheet

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.92%. Comparing base (5509259) to head (4f583c4).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   94.92%   94.92%
=======================================
  Files          14       14
  Lines         532      532
  Branches       82       82
=======================================
  Hits          505      505
  Misses         26       26
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issue with tabbed navigation

We are using braintree.js (custom integration) and are running into the following problem:
We are using a tabbed layout for the CC parts and Paypal part. So clickes on a PayPal icon and sees the Paypal button to login or he clicks on a CC symbol and sees the CC fields like number, expiration date,...
Now, when a user has entered both details (logged into Paypal and filled out all CC fields) of course we're running into a problem, because the form only has a single payment_method_nonce field. I tried to fix that by remembering the nonce in a data attribute on the payment method containers and setting it dynamically based on what payment method is selected, but that doesn't work - probably because the payment method nonce is the same for both payment methods.
Can you think of any hack how to work around our problem?

@clupprich have you seen the comments for issue #29? Maybe one of the hacks mentioned there would be useful for you as well.

Custom integrations do their best to figure out which payment method a user wants, so what you're seeing is intended behavior. A couple of us looked at this issue and had a couple of workarounds:

Prevent your users from going back to the credit card tab if they've already logged in with PayPal. If they cancel PayPal, then the user can switch tabs again.
Here's a bit of sample code that might help:
// This is a "fake" function that is called when tabs are switched.
function switchTabs(switchTo) {
  // Don't switch tabs if we already have a nonce.
  var alreadyHasNonce = !!$('input[name="payment_method_nonce"]').val();
  if (alreadyHasNonce) {
    return;
  }

  // Continue switching tabs...
  // ...
}

// ...

braintree.setup('YOUR_TOKEN', 'custom', {
  // ...
  paypal: {
    container: 'your-paypal-container',
    onCancelled: function () {
      // Clear the nonce if PayPal has been canceled.
      $('input[name="payment_method_nonce"]').val('');
    }
  }
});

If you're looking to have very tight control over your Braintree integration, you can use direct tokenization. When doing this, take care to never send card data to your server (removing the name attribute from sensitive inputs usually solves this). This is a little more code, but we're happy to send an example if this sounds interesting.

For what it's worth, this is a problem we are currently investigating.
Hope this helps!

Hej @EvanHahn! Thanks for getting back to me! We've in fact tried method 1 (disabling CC) yesterday and that's what we will go for for now. Option 2 is probably even better, but will take us a bit more time and QA to get done right and tested. Thanks for the great response (as always)! :)

Glad we could help. I'm going to close this issue for now but feel free to reach out again if needed!


Arduino IDE Keeps requesting ESP8266 Weather Station updates, but already updated

Hi Daniel,
If you use the Arduino IDE you will get a constant request to update your library from 1.1.1 to 1.1.2 and when you do update to 1.1.2 it still keeps requesting an update. It looks like something has not been set correctly in the IDE or Library Update process to signal that once the update has been completed there is no further update required.

you hare not up to date, there is a versione 1.1.3, click on select versione, select the latest version and install

I'm using Arduino IDE 1.8 and it does not show 1.1.3 as an update. I can see the JSON has been updated on GitHub, but it's not being downloaded via the IDE. Maybe the Weather Station is only supported for earlier IDE versions.

Resolved, I had two versions of the ESP8266_Weather_station, removed old version, now shows 1.1.3, thanks for the hint.


ItemAppearing/ItemAppeared Event/Commad not calls for the first Time

ItemAppearing/ItemAppeared Event/Commad not calls for the first Time.Once swiped Everything work Ok Then

thx, i will take a look

Just validated. Works fine


flutter.engine: improvements

Description of changes
As suggested by @tomberek in #212328, let's use the builtins.storePath for the toolchain. Also incorporates another change, adds an outName attribute to the engine to easily know where in $out/out/ the engine is at instead of duplicating the logic. Other changes will be added as well, such as:

[x] Optimize space used in $out of engine builds (takes ~30GB currently, goal is 10GB)
[x] All binaries should have no missing solibs
[x] Unit test execution
[x] Disable artifact fetching for engine enabled Flutter
[x] Use Engine's Dart & wrap it to be compatible with Nixpkg's

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ref https://github.com/flutter/flutter/issues/150322 for engine size reduction.

Engine is now 2.7GB on aarch64.

@ofborg build flutterPackages-source.stable

This PR is now ready, can be tested by building flutterPackages-source.stable.engine

@ofborg build flutterPackages-source.stable

Builds locally, Ofborg has issues with FOD on x86_64-linux but that builds. I don't want this PR to sit forever so just going to merge.


Audio problem

Platform:
Kap Version: <IP_ADDRESS>
Steps to reproduce
Current behaviour HI i'm using the app to record the screen with system audio but its only record the video without any audio.
Expected behaviour supposed to record video as well as system audio
Workaround
please fix the problem

#145
Please search issues before posting a duplicate.

+1

ok, great!


Can't get custom watch config to run

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
I created a custom watch.config.js just like the default config , added it in package.json in config as ionic-watch when running ionic serve for example the config file is not loaded. Other configs do get loaed. For example I customized the copy.config and it worked beautifully. Even running with the --watch flag I could not get it to load that config
What behavior are you expecting?
I would expect for the config to be picked up. Maybe I am doing something wrong?
Steps to reproduce:

Create a custom watch.config file. Eventually prepend a console log to see it in the console
Alter package.json and add ionic_watch in config
Run ionic serve

insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Seems to work fine now. I did a reinstall and apparently that helped

How did you fix this exactly? My ionic_watch config is not being picked up either.

@AlexandruCiobanu What do you mean by reinstall? I'm also having this problem.


default_version ?

Cookbook version
3.0.0
Chef-client version
12.20.3
Platform Details
oracle linux 7.4
Scenario:
my install fails because there's a newer version :
      yum_package[docker-ce] (/var/chef/cache/cookbooks/docker/libraries/docker_installation_package.rb line 19) had an error: Chef::Exceptions::Package: Installed package docker-ce-17.12.0.ce-1.el7.centos is newer than candidate package docker-ce-17.09.0.ce-1.el7.centos

Steps to Reproduce:
run chef docker_service without a version
docker_service 'default' do
  action [:create, :start]
  install_method 'package'
  package_name 'docker-ce'
end

Expected Result:
Not having to specify a version, it should default to the latest ?
Actual Result:
run fails

I also have the use case that I need the latest version in the (cached) repository.
Otherwise it is fighting the automatic security updates performed weekly.


Migrate Nuxt loading bar to custom loading component

This is mainly important for consistency with regards to the notch fullscreen loading

Also change loading indicator to use "pulse" (https://tobiasahlin.com/spinkit/ whatever the 5 bar one is).

https://nuxtjs.org/api/configuration-loading-indicator/
https://nuxtjs.org/api/configuration-loading/


[ new ] add tyttp adapter node

It is required for external projects which would like to use tyttp on node. Also required for tyttp-json tests.

Is there anything stopping this PR from being merged. I agree that making tyttp-adapter-node available directly without having the source code for would make it more convenient. :-)

Sorry, I forgot about this.


gridsome develop command fails

Description
The gridsome develop commands fails
Steps to reproduce
While running gridsome develop it is showing me below mentioned error
Expected result
Gridsome based app should be displayed properly. but it wasn't working
Actual result
error  in ./src/pages/Index.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "cover_image" on type "Post".

GraphQL request:24:9
23 |         description
24 |         cover_image (width: 770, height: 380, blur: 10)
   |         ^
25 |         path
    at Object.module.exports (/Users/sk/Design/mine/vue-blog/node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js:33:23)

 @ ./src/pages/Index.vue?vue&type=custom&index=0&blockType=page-query 1:0-331 1:347-350 1:352-680 1:352-680
 @ ./src/pages/Index.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/templates/Post.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "cover_image" on type "Post".

GraphQL request:71:5
70 |     content
71 |     cover_image (width: 860, blur: 10)
   |     ^
72 |   }
    at Object.module.exports (/Users/sk/Design/mine/vue-blog/node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js:33:23)

 @ ./src/templates/Post.vue?vue&type=custom&index=0&blockType=page-query 1:0-330 1:346-349 1:351-678 1:351-678
 @ ./src/templates/Post.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.

Environment
System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  Binaries:
    Node: 12.13.1 - ~/.nvm/versions/node/v12.13.1/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.12.1 - ~/.nvm/versions/node/v12.13.1/bin/npm
  Browsers:
    Chrome: 83.0.4103.116
    Edge: 83.0.478.61
    Firefox: 78.0.2
    Safari: 13.1.1
  npmPackages:
    @gridsome/plugin-google-analytics: ^0.1.0 => 0.1.1
    @gridsome/remark-prismjs: ^0.2.0 => 0.2.0
    @gridsome/source-filesystem: ^0.6.0 => 0.6.2
    @gridsome/transformer-remark: ^0.3.0 => 0.3.4
    gridsome: ^0.7.0 => 0.7.19
  npmGlobalPackages:
    @gridsome/cli: 0.3.3

Are you using Ghost as your source?

@sriramgroot can we close this issue here, since it's an issue in the starter kit?

Are you using Ghost as your source?

@Sergix No iam not using Ghost

@sriramgroot What is your source for the Post content type? If it's Markdown, can you confirm that you have cover_image in your frontmatter?


Format configuration variables as a table

I dig it, no sweat emojis required! README upgrades ftw!

Totally unrelated, @sapegin do you still have this "pimp-prompt.jpg" image handy? Looks like it went 404 and GitHub is complaining
http://wow.sapegin.me/image/0Z1C1U00281j/pimped-prompt.jpg
TIL the GitHub proxy really is a proxy! I thought they just cached in perpetuity


Caught up with SvelteKit.

Updated template generated files
Use NodeNext module resolution.

@dgrebb there was some slight finessing to do with supporting SvelteKit 2. I've caught up some of the stock generated files (they don't impact the distributed library, but it is worth tracking them). I've also included the new default NodeNext module resolution.
OK to merge?

@accuser sorry I jumped the gun on the other PR :/


Add output address invariants

Change address appears at most once in outputs
Recipient address appears exactly once in outputs

We did this.


Support selecting which methods to override when adding a provider to the chain

The subprovider should receive the list and be able to veto if removing some of those would cause the module useless and/or broken. The veto would be an error message and not a silent force continue.

we no longer track a list - so this would represent a significant shift in the subprovider definition. currently subproviders have complete freedom to handle or skip rpc requests
understanding who handles what is all about positioning of the subproviders in the stack
i vote to close this issue

My idea would be a simple interface, such as a whitelist or blacklist (array of strings) to the subprovider constructor.
There are (or about to be) providers with overlapping methods.

maybe try to capture it over in https://github.com/MetaMask/provider-engine/issues/31
trying to get our goals together to improve the design over there.

i've started work on a more composable rewrite here:
https://github.com/kumavis/json-rpc-engine
https://github.com/MetaMask/eth-json-rpc-middleware
https://github.com/kumavis/eth-json-rpc-filters
you can specify methods to implement by wrapping in createScaffoldMiddleware which is nicely composable
https://github.com/kumavis/json-rpc-engine/blob/master/src/createScaffoldMiddleware.js
createScaffoldMiddleware({
  eth_abc: otherMiddleware(),
  eth_xyz: staticValue,
})


Unit Test

Incorporating unit tests into the package would greatly benefit the open-source community. With automated testing, contributors could confirm that their code works as intended without testing every aspect manually. This would lead to faster and more efficient contributions and ultimately result in a higher-quality package for everyone.

Thank you for your advice, unit testing for this package has been added


Add dockerfile for cross itself

This adds a dockerfile which has cross and docker already installed and can be directly used to cross compile and test. It mostly adopts a comment in #260.
It uses docker in docker (#387) so to work correctly it must be run with the docker socket mounted as volume.
$ docker run -v /var/run/docker.sock:/var/run/docker.sock cross
root@1e27ac2ed941:/# git clone https://github.com/cross-rs/cross
root@1e27ac2ed941:/# cd cross
root@1e27ac2ed941:/cross# cross build --target aarch64-unknown-linux-gnu

Although the README already describes how to achieve this, a provided Dockerfile that can be downloaded from Docker Hub in the best case would be much easier than writing your own. Especially when using a CI pipeline inside Docker, where creating a custom Dockerfile is not that easy, this could be a big help.
The directory of the Dockerfile may not be the best choice since only compile targets are in this directory but it was the best fit.

The checksum check is now implemented (md5) and it only checks the docker binary inside of the tarball since this is the only file which is needed.

@ByteDream could you rebase and add a changelog entry? So we could trigger CI and see if it'll succeed.

Closed since #878 as merged.


Improve UX for switching Base URL / Drive

Notion has a Workspace switcher, like so:

I'd like something similar.
Considerations

We have 'base URL' and 'drive' concepts, perhaps these should be merged / renamed (Workspace?)
When a user is created, it might make sense to provide that user with their own drive
Maybe add a button for creating a Drive.
The current Base URL setting does not update views. I think the state needs to reside in the Settings context object
When opening a Drive, perhaps show a button 'set as current drive'
Being able to switch between drives, means storing mutliple. Maybe store an array to localstorage?

Fixed!


获取room avatar报错

wxhook_1  | TypeError [ERR_INVALID_URL]: Invalid URL
wxhook_1  |     at new NodeError (node:internal/errors:371:5)
wxhook_1  |     at onParseError (node:internal/url:536:9)
wxhook_1  |     at new URL (node:internal/url:612:5)
wxhook_1  |     at Function.fromUrl (/node_modules/file-box/dist/src/file-box.js:88:31)
wxhook_1  |     at PuppetPadlocal.roomAvatar (/node_modules/wechaty-puppet-padlocal/dist/puppet-padlocal.js:827:41)
wxhook_1  |     at async Object.exports.create (/libs/Group.js:18:21)
wxhook_1  |     at async refreshGroupInfo (/callbackServer/router/bot.js:32:5)
wxhook_1  |     at async Wechaty.<anonymous> (/callbackServer/router/bot.js:98:3)

Fixed, will be released in<EMAIL_ADDRESS>


[Group] Yaml test files for group messaging demonstration

Problem

Chip-tool cannot send group messages yet.

Change overview

Add yaml tests to simplify testing group messaging
No functionnal changes

Testing

Manual test with efr32 to validate that two configured devices can receive group messages

Fast tracking, given this is adding tests.


Create Group for external testers

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
Create new group for external testers

Question Description

   app = Spaceship::ConnectAPI::App.find("#{options[:bundle_identfier]}")
    number = latest_testflight_build_number(
      app_identifier: ""#{options[:bundle_identfier]}""
     )
    build_array = Spaceship::ConnectAPI::Build.all(app_id: "#{options[:app_id]}", version: '1.0.0', build_number: number)
    first_build = build_array.first
    my_groups = first_build.app.get_beta_groups(filter: {name: "GROUP1"})
    first_group = my_groups.first
    Spaceship::ConnectAPI.add_beta_groups_to_build(build_id: first_build.id, beta_group_ids: [first_group.id])

those lines get build already created, and add latest Distributed build into it,
But if I don't have a group I have to create it, so I can create it ..!?

Ping @max-ott

@janpio If we are not able to create group, can we add a "Individual Tester"

I did not say that, and I do not know.
I only know the normal fastlane pilot CLI: https://docs.fastlane.tools/actions/pilot/#add-a-new-tester

Digging a bit more into this...I see that when I manually create an external group in ITC, it makes a POST request to https://appstoreconnect.apple.com/iris/v1/betaGroups/ID, with the following payload: {"data":{"type":"betaGroups","attributes":{"name":"GROUP_NAME"},"relationships":{"app":{"data":{"type":"apps","id":"APP_ID"}}}}}.
When I do fastlane pilot import or fastlane pilot add it does not make this call if the group does not exist nor makes the POST request to associate the user with any group (because the group does not exist).
Hope this helps - I'll dig a bit into the code as well

Might something like this work?
def create_beta_group(app_id: nil, group_name: nil)
        body = {
          data: {
            type: "betaGroups",
            attributes: {
              name: group_name
            },
            relationships: {
              app: {
                data: {
                  type: "apps",
                  id: app_id
                }
              }
            }
          }
        }

        Client.instance.post("betaGroups", body)
      end

Might something like this work?
def create_beta_group(app_id: nil, group_name: nil)
  body = {
    data: {
      type: "betaGroups",
      attributes: {
        name: group_name
      },
      relationships: {
        app: {
          data: {
            type: "apps",
            id: app_id
          }
        }
      }
    }
  }

  Client.instance.post("betaGroups", body)
end

https://developer.apple.com/documentation/appstoreconnectapi/create_a_beta_group

Its not working also, it gave me an error.


First Contribution

Hacktoberfest! 🎊🎈
🎉 Have you read the Contributing Guidelines? 🤔
(Write your answer here.)
📝 Description
(Write your answer here.)
Fixes #issue_no 🔧

✅ Checklist

[ ] I've read the contribution guidelines. 📚
[ ] I've checked the issue list before deciding what to submit. 🔍
[ ] I've edited the README.md and linked to my code. 📄

🔗 Related Issues or Pull Requests
(Write your answer here.)

Hi there!
I am the Mentor of this project .
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:
Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.
Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!


Add /icon.png endpoint for getting the icon for a given realm with REALMS_HAVE_SUBDOMAINS

See https://github.com/zulip/zulip-electron/pull/140#discussion_r112591533 for context.

I think we've decided not to do this, in favor of the GET /api/v1/server_settings endpoint, which provides that and other data one might want.


Add prefixed based routing to Cloud Foundry

Hey folks,
In addition to adding prefixed based routing, we've also cleaned up the copilot snapshot test. We've moved golang protobuf forward from v1.0 to v1.1.0 for the copilot proto dependencies. If you'd like, we can move everything else in istio forward in a separate PR (just let me know).
Thanks,
Utako

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: utako
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @utako. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@utako: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0dd8818dd29796b778e1026e03b2ce225e039f62
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utako: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f7305f84b8b23ad4c984dd4d065d2eefb3d85f9a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utako: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f7305f84b8b23ad4c984dd4d065d2eefb3d85f9a
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
f7305f84b8b23ad4c984dd4d065d2eefb3d85f9a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utako: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
f7305f84b8b23ad4c984dd4d065d2eefb3d85f9a
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
529604ee52097d12ffe38003a445b9fda666b973
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utako: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
529604ee52097d12ffe38003a445b9fda666b973
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
529604ee52097d12ffe38003a445b9fda666b973
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo-envoyv2-v1alpha3

/test istio-pilot-e2e

/test istio-pilot-e2e

@utako: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
529604ee52097d12ffe38003a445b9fda666b973
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@utako: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
529604ee52097d12ffe38003a445b9fda666b973
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

Merging due to stuck cla bot


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://github.com/rsteube/carapace-bin/releases/latest
Publisher: @rsteube
Package Name: Carapace
Description: multi-shell multi-command argument completer
Package Version: v0.22.0
Installer URL: https://github.com/rsteube/carapace-bin/releases/download/v0.22.0/carapace-bin_windows_amd64.tar.gz

Blocked by https://github.com/microsoft/winget-cli/issues/2899

@Trenly changed it to zip

@Trenly can you remove the blocked tag?

[Policy] reset feedback


Add company data details support to checkout

Here's the design.
, also available in Figma, under the name "Checkout - Step 3. Payment".
Assumptions:

You can type the name of the company in the Shipping area;
You can type the name of the company in Payment area, you can also select that you want to generate an invoice (checkbox), after ticking the checkbox new field "Tax identification number" appears.

@kacperknapik is that enough?

@filrak can you take care of this one? If support needed I'll cover the backend part - no worries, I can do the backend Today or Tomorrow probably


feat: manual-edits.json file added to dropdown

Another random note, this code can be a bit sensitive to changes, so definitely test stuff like editing code and making sure new typescript imports are recognized and dynamically imported etc. also that the cursor is stable when editing.
We could potentially incorporate that into a playwright test later


[JBEAP-24913, #216] Additional options for update/revert apply operations

[#216] Additional options for update/revert apply operations,
Issue: https://issues.redhat.com/browse/JBEAP-24913
Upstream: #363

superseded by #583


Add support for transaction based feedback.

Add support for passing transaction ID to record_llm_feedback_event API

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop-ai-limited-preview@510f747). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             develop-ai-limited-preview    #1058   +/-   ##
=============================================================
  Coverage                              ?   77.55%
=============================================================
  Files                                 ?      191
  Lines                                 ?    20204
  Branches                              ?     3511
=============================================================
  Hits                                  ?    15669
  Misses                                ?     3598
  Partials                              ?      937

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ListItemText] Fix variant mapping in primaryTypography

fixes #33255
Codesandboxes
before
after

[x] I have followed (at least) the PR section of the contributing guide.

Amazing! Thank you for this @iamxukai! I hope it fixes my problem 😄


[Enhancement] Add a note to an image

Something that might be handy is the ability to add a note to an image.
I would imagine this would just be another column in a table in the database to store it. It could then be displayed along with the prompt information, etc when selecting an image and perhaps searchable using the filter.

Where should the note be displayed in a full screen view?

Didn't realise there could be a section for it in metadata. Not sure if it would work how I envisage it as I'm assuming it would put the same note in all images generated if generating more than 1 at a time? I was thinking more of something I could add as I go through the pics imported into the program so they could be easily found later. I've been playing around with Reactor a lot lately and there doesn't appear to be anything placed in the metadata of the image (using Auto1111) that lists it was used and with what image.
I'll have a look into notes in metadata and see what I can find.

I've searched around and I cannot find where/how to put specific notes in metadata. Did you mean during generation or using some other application to add it post generation?


Improve code generation process for reusing common types

The data model contains common and error subpackages which contain objects shared across the different OBIE schemas.
As a developer tasked with running the code generator, I would like to be able to easily reuse the common and error objects (or update them as required) with minimal manual steps.
Investigate if this can be achieved, if it proves too difficult then update the README to better document the approach.

There's no quick win here, we will continue having to do this as a manual step.
With the changes to use the common FR IntelliJ java code formatting, noticing and applying these changes becomes easier as there is no additional noise in the diff when we re-run the code generator.


assertion failed when takeSnapshot: '!renderObject.debugNeedsPaint': is not true.

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
'package:convenient_test_dev/src/utils/snapshot.dart': Failed assertion: line 31 pos 10:
'!renderObject.debugNeedsPaint': is not true.

When the exception was thrown, this was the stack:
#2      _captureImageFromElement (package:convenient_test_dev/src/utils/snapshot.dart:31:10)
#3      takeSnapshot...


Added support for coroutines

This change bumps Kotlin version to 1.1.1 and adds support for coroutines.
There was a fix in Mockito that made it work with Kotlin coroutines (https://github.com/mockito/mockito/pull/1032), so its version has also been bumped.
A new test case was added to ensure that suspending functions are well handled.

This breaks compatibility with Kotlin 1.0.7, as coroutines were added on 1.1

I don't think this is really necessary, apart from updating the Mockito version.
You're basically only including the kotlinx:kotlinx-coroutines-core as an extra dependency which is something the users can do themselves, right?
For current users, explicitly depending on Mockito 2.8.29 and enabling coroutines should do the trick as well.

Fair enough. So I'll just leave this as a reference for anyone having the same problems that I did:
If you are getting exceptions like this:
org.mockito.exceptions.misusing.InvalidUseOfMatchersException:
Invalid use of argument matchers!
2 matchers expected, 1 recorded:
-> at com.nhaarman.mockito_kotlin.MockitoKt.eq(Mockito.kt:114)

This exception may occur if matchers are combined with raw values:
    //incorrect:
    someMethod(anyObject(), "raw String");
When using matchers, all arguments have to be provided by matchers.
For example:
    //correct:
    someMethod(anyObject(), eq("String by matcher"));

For more info see javadoc for Matchers class.

and your matchers are all correct but you are mocking the call of a suspending function, you'll need to force your Mockito to a newer version because coroutines were not supported.
Support to coroutines was added to Mockito on 2.8.27 which is only available on https://bintray.com/mockito/maven/mockito-development for now, so you'll need to add it as a maven repository of your project. Mockito's next 'Notable' release (currently at version 2.8.9) should include this changes, so you won't need to add this repository.
If you have any doubts, take a look at the changes made on this PR.


Build error on Windows machine.

I've failed to install kite on Windows because SIGUSR2 doesn't exist.
Maybe there is no easy fix.
C:\go>go get github.com/koding/kite
# github.com/koding/kite
src\github.com\koding\kite\logger.go:105: undefined: syscall.SIGUSR2

Hi @jiapengjp
Currently there is no Windows support for Kite. Only Mac OS X and Linux are supported. Though supporting would be easy, we just need some time to dig and fix the necessary problems.


Fullscreen osu!

the cat doesn't move when i have osu! on fullscreen and i cannot find a solution online please help

If you're using Windows 10, please run both osu! and bongo.exe with Windows 7 Compability mode.

Works fine for me on Windows 10 without compatibility mode.

@uRandomAlex Thank you! I will update the README then.

If you're using Windows 10, please run both osu! and bongo.exe with Windows 7 Compability mode.

How do i run osu! and bongo.exe with Windows 7 Compability mode?


Allow setting different responses per request #31

issue: #31
Following is the summary of the changes done in the PR so far:

As part of this PR, I've introduced a new way to handle Random/Repeatable responses.
I've used burst terminology for repeatable responses.

Changed Items:

Changed response field in an imposter to responses (array of response)

Added Items:

Added burst field in response schema under imposter schema

this new field has a +integer value, which represents no of times a response should be repeated.
valid only in BURST mode, ignored in RANDOM mode
in BURST mode if ignored/missing, the default value is 1

Added responseMode field in request schema under imposter schema

this new field can have two string values RANDOM or BURST
default value is RANDOM
any other values will be ignored and default values will be selected instead
if the field is missing/ignored, the default value will be considered

Input required:

Migration strategy for existing imposter schema to new schema (response -> array of response)
Determining default value for responseMode which is currently RANDOM

What do you think about moving the responseMode to the imposter's level or to make the response field an object with mode and payloads fields within?

>> I'd go with 2nd option rather than the 1st one.

Have you tested your implementation with concurrent requests? I might be wrong (as I said I had no time to do some tests neither look at it in-detail), but looks like you're increasing the requests counter with no protection against concurrent requests (ergo potential data races).

>> Nope, this is a miss from my end. I'll incorporate this one.

What do you think about moving the responseMode to the imposter's level or to make the response field an object with mode and payloads fields within?

I'd go with 2nd option rather than the 1st one.

I'm still wondering about how big that change is. In comparison with tools like Mountebank, in Killgrave is much simpler to define your imposters, so with this kind of change (forcing the user to define an array, etc) we're losing the added value that Killgrave brings into the ecosystem.
That being said, do you think it could work to either:

Make the imposters parser work with both schemas (older and newer).
Base this new feature in a completely new field (response vs responses or similar).

What do you think? cc/ @aperezg

Have you tested your implementation with concurrent requests? I might be wrong (as I said I had no time to do some tests neither look at it in-detail), but looks like you're increasing the requests counter with no protection against concurrent requests (ergo potential data races).

Nope, this is a miss from my end. I'll incorporate this one.

No worries at all, that's why code reviews are for. Feel free to ping me if you have any question related with that.
Agains, thanks a lot for your engagement with the project and your valuable contributions 🙏🏻

@aperezg, sorry for the late submission. I've fixed the code for concurrent requests. Please review and let me know any suggestions/issues.

@aperezg,  we have to discuss one question - How to deal with the schema change? (responses instead of response in the imposter file.)
Here are few ideas:

Make current code to work with both imposter schemas. (@joanlopez's idea)
Write a one-time utility to convert imposter from previous version to the current one

Any other ideas would be appreciated.
Thank you

Hello @infinite-spectrum, sorry for the late response 🙏 so for continue with the PR, I think that the best idea would be that joan said, support the responses and response :)


Text always readable

Implement a contrast tester so the text color can be replaced when the tones get too dark.
http://jxnblk.com/colorable/

Working on master brunch and deployed to heroku


Modify events of Tone.Part while it plays

Using Part I set up a very basic loop with a bunch of steps via triggerAttackRelease. Is there a way to change the note and time of these steps in the loop on the fly while the loop is playing? (Imagine having slider inputs to change the values) Looks like Part doesn't have methods to modify its events. Could you point into the right direction how to achieve this?
Thanks in advance!

Don't know if it's exactly what you need but I do this with a self calling function that uses Tone.Transport.schedule. It doesn't natively give you all the stuff that comes with Tone.Part but you can get there with some math.
Got a working example here if it's of any use :)

@brokyo Thanks, that is exactly what I was looking for. Here is a minimal example for everyone else interested:
// changing these values directly affects the loop
var notes = [
   'C2', 'G2', 'C3'
]
// changing these values directly affects the loop
// ( 0 ... 1 in the bar )
var times = [
   0.25, 0.333, 0.85
]

Tone.Transport.scheduleRepeat( function( time ){
    synth.triggerAttackRelease( notes[0], '16n', '+' + times[0].toNotation(), 0.5 );
    synth.triggerAttackRelease( notes[1], '16n', '+' + times[1].toNotation(), 0.5 );
    synth.triggerAttackRelease( notes[2], '16n', '+' + times[2].toNotation(), 0.5 );
}, '1m' );

Tone.Transport.start();


Kerberoasting vs. Golden Ticket

Hey team,
I might be misreading this, but the following sounds a lot more like Kerberoasting detection than Golden Ticket:
https://docs.microsoft.com/en-us/defender-for-identity/domain-dominance-alerts#suspected-golden-ticket-usage-encryption-downgrade-external-id-2009
The giveaway line is this one:

"In a Golden Ticket alert, the encryption method of the TGT field of TGS_REQ (service request) message from the source computer was detected as downgraded compared to the previously learned behavior."

which reads similar to this line from the MITRE ATT&CK technique for Kerberoasting:

"Adversaries possessing a valid Kerberos ticket-granting ticket (TGT) may request one or more Kerberos ticket-granting service (TGS) service tickets for any SPN from a domain controller (DC). Portions of these tickets may be encrypted with the RC4 algorithm, meaning the Kerberos 5 TGS-REP etype 23 hash of the service account associated with the SPN is used as the private key and is thus vulnerable to offline Brute Force attacks that may expose plaintext credentials."

Is this correct or am I missing something?
Tareq

Thanks for your comment. We'll investigate and get back to you.

Hello,
Just checking if there was any update on this one? I need clarification on what the rule is doing so we can write Playbooks for it.
Tareq

Still investigating.

Hello,
I don't suppose there are any updates on this?
Tareq

@TareqAlKhatib -  Sorry for the delay. I was able to get this response from the product group:

I can see the confusion -- The TGS request comes without valid TGT, meaning it was signed by the attacker and not the KDC, and this is an indication he has KRBTGT to create his own TGT.
Once attacker has KRBTGT he has no reason to create tickets for offline bruteforce, like in Kerberoasting, but for lateral movement. And this is what we trigger. We trigger a flavor of golden ticket.

In light of this, the documentation won't be updated. Thanks again for your question.


Add feedback and broken site form to android

Task/Issue URL: https://app.asana.com/0/361428290920652/688515420618259
Tech Design URL: N/A
Description:
Add a native feedback form for general and broken sites feedback.
Note: the UI uses native text fields, I will be validating that with design and expect to do a final pass to polish.
Steps to test this PR:
TEST 1: Broken site:

From the browser page, select the "Report Broken Site"
Note that the url is filled in and submit button active
Submit the feedback
Ensure it appears in https://app.asana.com/0/569473074191537/717268129349527
Check the url and device details in the Asana task are correct
Now delete it from Asana!

TEST 2: Broken site validation:

From the browser page, select the "Report Broken Site"
Note that the url is filled in and submit button active
Delete the url
Note that the submit button is now inactive
Note: we only do basic "empty" validation here (the same as extensions) as a user may just want to enter text e.g "facebook"

TEST 3:  Feedback Message:

From the settings page, select "Leave Feedback"
Note that the submit button is inactive
Enter message text
Submit the feedback
Ensure it appears in https://app.asana.com/0/413877547933099/717275776651708
Check the message and device details in the Asana task are correct
Now delete it from Asana!

Internal references:
Software Engineering Expectations
Technical Design Template

@brindy I made some small final copy and layout changes, feel free to rereview.


Make rustpython-vm compatible with non-js wasm32-unknown & add tests

Ideally the test crate shouldn't take long to compile, since it's the same target with only a few crates configured differently.

Hmm, is there a reason we need to have wasm32-unknown-unknown checked in exotic_targets when we have the wasm job? Is that a holdover from before we had the wasm job?

I recently added it there without specific reason. Do you think it belongs to wasm job? That makes sense.

I added the build to prevent the target's build error.
wasm build job was not fully covering the top-most crate rustpython build
See #3634

Oh, I see. But that's not supported anyway, right? You can't compile a cli application to wasm w/ js-interop, there's no syscalls or argv or anything.

there was wasm32-unknown use case without js interop.
the top crate is now more useful than vm because user must manually construct interpreter using vm and stdlib since we seprated stdlib crate. rustpython crate suggests a convenient way to construct one without knowing the details.

cc @lastmjs


test_stat_significance()['p_value']

Is there any change in the way test_stat_significance()['p_value'] default behavior works? I can see complete opposite values in dowhy 0.10 version compared with 0.9.1 version?
Using the same dataset with exact causal model and refutation model giving different p value results. Earlier (0, 0.001) with 0.9.1 version and now (0.999, 1) in 0.10 version.
causal_estimate = model.estimate_effect(identified_estimand,
method_name=model_name)
causal_estimate.test_stat_significance()['p_value']
Expected behavior
pvalues showing complete opposite with same dataset and parameters.
Version information:

DoWhy version 0.10

Additional context
Add any other context about the problem here.

That might be a bug. Can you share a minimum working example so I can reproduce the error?

`
from dowhy import CausalModel
testcausal.csv
model=CausalModel(
data = df,
treatment='v0',
outcome='y',
common_causes = ['W0','W1','W2','W3','W4']
)
identified_estimand = model.identify_effect(proceed_when_unidentifiable=True)
causal_estimate = model.estimate_effect(identified_estimand,
method_name='backdoor.propensity_score_stratification')
pvalue1 = causal_estimate.test_stat_significance()['p_value']
pvalue1`
df is attached csv file.
pvalue using 0.9.1 version = (0,0.001)
pvalue using 0.10 version = (0.999,1)

Thanks for the sharing the full example. Yeah, this was a bug introduced due to the refactor in this function. I have added a patch. will release a patch version soon.


unused constructor removed

I found a constructor with about 30 line which defined many variables and other function calls. It was never used and I removed that constructor from the code.
What's in the PR

...

How to test manually

...

Automatic testing

[ ] PR includes unit tests

Documentation

[ ] PR updates documentation

Same comment as in #169.


VM pools are displayed for non permitted users during manual/auto refresh

After creating a new pool with "Maximum number of VMs per user" set to more than 3 vms, every logged non admin user in web-ui will view this new pool's VMs as part of his VMs list dashboard, even though they are not assigned to him.
Only after hard refresh (ctrl+F5) those new pool VMs are dismissed from user's VMs list dashboard
For reproducing:

Logged in to web-ui as a specific user with only UserRole permission on global level.
Create a new pool via webadmin with  "Maximum number of VMs per user" set to 3.
on web-ui logged as a specific user: manually refresh or wait for auto refresh and check the VMs list dashboard.

Actual result:
The new pool and one one pool VM will be displayed on VMs list dashboard. For example in case new pool name is eee-pool5, the following will be displayed on dashboard till hard refresh:

Expected result:
Only new pool card should be displayed without displaying any of the new pool VMs, since those pool VMs  are not assigned to this logged user.

Note that if  Pool's "Maximum number of VMs per user" value is set for 4, then 2 pool VMs are displayed for non admin users on web-ui dashboard etc..

1. Logged in to web-ui as a specific user with only UserRole permission on global level.

that means you have operational permissions to every single VM in the system.
It shouldn't be assigned like that
If you do that then the bug is the other way around:) you should always see all the VMs.

that means you have operational permissions to every single VM in the system.
It shouldn't be assigned like that
If you do that then the bug is the other way around:) you should always see all the VMs.

This issue is reproduced when UserRole is assigned on cluster level as well.
In addition, UserRole on system level means that you have operational permissions to every single VM in the system except pool vms (checking the permissions on webadmin shows that inheritance is not done for pool vms until they are assigned)

This issue is reproduced when UserRole is assigned on cluster level as well.

yes, because then you granted operational permission to every single VM in that Cluster. Again, it's not what you typically want.
Inheritance works as per https://www.ovirt.org/develop/developer-guide/action-permissions-overview.html

Folks, if you still think this is an issue, then it should be fixed in the API. The API returns the VMs which shouldn't and the UI displays them. The query we use in the UI to fetch the VMs or just one single VM is correct.
If this is not the issue, we should to make some changes in the webadmin regarding assigning permissions, to make sure (or at least better to inform) the admin assigns permissions the correct way to the correct entities.

@hstastna partially correct since hard refresh does return a different result (without those vms) so we are not consistent.
In addition, the "allocated vms per user" counetr should reflect those vms that are shown on web-ui and it's currently not.
And as I mentioned above, this specific issue is not reproduced on previous web-ui version so it's still a regression on web-ui side.
We just need to decide how to handle this...

I'm joining Scott on the issues he raised. I'm in the middle of automating VM Pools basic sanity tests and cannot proceed, because on the latest 4.4.4 user cannot allocate a VM from VM Pool if the pool has only 1 VM (it's free, no other user has it).
Steps:

In AdminPortal create VM Pool with 1 VM, 0 prestarted VMs and 1 VM per user.
Add user with system UserRole and PowerUserRole.
Login as the user and go to VM Portal.
Try to allocate 1 VM from the VM Pool.

Results:
VM Pool is not present and user cannot allocate the VM. However, user sees the VM from the VM Pool in Off state, even though he didn't allocate it. User can run the VM. Refreshing (both hard and VM Portal) does not fix the issue.
Reproduced 100% on d/s: ovirt-engine-<IP_ADDRESS>-0.10.el8ev

I'm joining Scott on the issues he raised. I'm in the middle of automating VM Pools basic sanity tests and cannot proceed, because on the latest 4.4.4 user cannot allocate a VM from VM Pool if the pool has only 1 VM (it's free, no other user has it).

@isaranova the specific scenario you described here (pool with one VM pool) is not reproduced to me. can you please attach screenshots/videos? Thanks

Seems like it was a broken hosted-engine environment - I retested on 3 different new rebuilt environments and cannot reproduce the issue anymore. Sorry for false report.

This was reproduced to me on oVirt version 4.3.11 as well (web-ui version 1.6.0-1) and therefore it's not a new regression.

This was reproduced to me on oVirt version 4.3.11 as well (web-ui version 1.6.0-1) and therefore it's not a new regression.

Since this issue happens on a very specific timing when a new pool is still created and refresh is done on web-ui and since it is not a new regression then I suggest to avoid fixing it for now.

Since this issue happens on a very specific timing when a new pool is still created and refresh is done on web-ui and since it is not a new regression then I suggest to avoid fixing it for now.


Optimize remote-desktop related host commands

Optimize remote-desktop related host commands, currently all remote-desktop related commands are run with process and run periodically. Need to optimize, save last activity and run if last activity was not success

I created environment with mate2go BP, waited for about half an hour, but desktop icon and ability to remote desktop in CC didn't appear -https://masterbazaar.subutai.io/users/278/environments/11847
@zubaidullo @Dilshat

@amol4anoff are you sure, you BP is fully installed?

This one - Fixed. Tested in master.


Remove <h1> tags from project logos

It seems that the tide has turned and that the project logos should probably be simple links and not <h1> headings. In other words we are returning to only one <h1> per page — the unique (to the website) title of the page.
"Wrapping the logo in an h1, resulting in the h1 being the site name, is not right. Because then, every single page on a site starts with the same h1 text. This is confusing for screen reader users and not informative for search engines."
Source: a11yproject.com/posts/how-to-accessible-heading-structure/ (Jan 3, 2022)
It is not yet clear to me whether the h1 elements should be replaced with something else (such as h2 elements) or whether it is better to leave the logos as simply links: there does not seem to be much agreement.

Deployed


Use block when arm exceeds max_width

This PR closes #1282, #1365 and #1460.

Looks good, thanks, but needs a rebase.

Rebased.


Add timeout for /is_synced endpoint in sidecar.py

In out prod environment we could observe that requests piling up as there is no timeout in default requests get method. Here we timeout and close the connection timely to avoid the piling up.
This is an alternative way to fix the issue mentioned here https://github.com/oxheadalpha/tezos-k8s/pull/562

please see my latest comment
I have  updated the comment with right probe filed name, please have a review


HARP-6487: Provide h/vPlacement attributes support for point labels.

Introduce new Theme style attributes for 'labeled-icon':

hPlacement : Left | Center | Right,
vPlacement : Above | Center | Below.

The first one works in opposite way to hAlignment, while the second
has the same meaning. Both attributes takes precedence over the
h/vAlignment if set, otherwise alignment attributes may specify
text placement over the point anchor, although this attributes are
from now marked as deprecated.
Signed-off-by: Krystian Kostecki<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1407 into master will decrease coverage by 0.16%.
The diff coverage is 77.9%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   54.98%   54.81%   -0.17%
==========================================
  Files         266      255      -11
  Lines       23761    23521     -240
  Branches     5328     5289      -39
==========================================
- Hits        13064    12894     -170
+ Misses      10697    10627      -70

Impacted Files
Coverage Δ

@here/harp-datasource-protocol/lib/Techniques.ts
71.96% <ø> (ø)
:arrow_up:

@here/harp-datasource-protocol/lib/Theme.ts
100% <ø> (ø)
:arrow_up:

...re/harp-datasource-protocol/lib/TechniqueParams.ts
51.21% <ø> (ø)
:arrow_up:

...harp-text-canvas/lib/typesetting/PathTypesetter.ts
10.97% <ø> (ø)
:arrow_up:

...harp-text-canvas/lib/typesetting/LineTypesetter.ts
67.06% <ø> (ø)
:arrow_up:

@here/harp-mapview/lib/text/Placement.ts
83.95% <70%> (+0.08%)
:arrow_up:

@here/harp-mapview/lib/text/TextStyleCache.ts
57.43% <75.75%> (+6.05%)
:arrow_up:

@here/harp-text-canvas/lib/rendering/TextStyle.ts
79.51% <81.39%> (-0.25%)
:arrow_down:

...re/harp-text-canvas/lib/rendering/TextMaterials.ts
42.85% <0%> (-34.07%)
:arrow_down:

@here/harp-mapview/lib/Utils.ts
59.56% <0%> (-7.59%)
:arrow_down:

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b1f8b...6113e93. Read the comment docs.


 You are allowed to choose exactly one element from each row to form an array. Return the kth smallest array sum among all possible arrays.

Hi, Please read the Important Announcement.
PR can only be made after the issue is assigned to you.


Services are not headless anymore

From version 2.1.13 to 2.1.14 the cassandra services created are not headless anymore.
I don't know if the change was intended... anyway is a big breaking change that should go in a major.

I closed #84 as the behavior noted there is explained by the service not being created headless in 2.1.14 now.  Will defer to this issue since it points more directly to the cause.  =)

@zanettea hmm it wasn't intended and I think we thought it was headless by default 😕. Going to make a PR to revert it ...

@zanettea can you confirm PR #86 fixes it ? You can overwrite the image installed by helm by adding --set image.tag=headless-service to the helm install command

@zanettea 👆

@zanettea as I didn't get any response I'll merge that PR which solves the issue described.


Undo recipe

I created this recipe because the section TaskCancellation got me most of the way to creating simple undo functionality but it left a few things out.  Granted this recipe is very similar to the task cancellation section so I understand if it isn't different enough.  I figured undo was a common enough problem that having another example could be useful.
Excellent library btw, I was shocked at how easy it was to implement the ability to undo a task.

Sorry for the delay. Looks like a special case of debouncing but it's a good demo for optimistic updates (using a delay).

Excellent library btw, I was shocked at how easy it was to implement the ability to undo a task.

Thanks!


Error in latest build 1.19.57

I receive the following error when using the updated version 1.19.57:
**Error 12, Variable 'LNFILECOUNT' is not found.
get_filesfromdirectory, 5208
DO c:\vfputils\thor\tools\components\foxbin2prg\foxbin2prg.exe WITH "SHOWMSG-PRG2BIN", "C:\Source\Repos\brokerWOLF\lwapp"
FoxBin2Prg: [C:\VFPUTILS\THOR\TOOLS\COMPONENTS\FOXBIN2PRG\FOXBIN2PRG.EXE] (EXE Version: v1.19.57)
lcInputFile_Type  = [D]
tc_InputFile = [C:\Source\Repos\brokerWOLF\lwapp]
Source file: C:\Source\Repos\brokerWOLF\lwapp**
As you can see, the parameter name is 'tnFileCount' but line 5208 is using '@lnFileCount'.

Thanks for reporting this, I found the same issue.

Will be fixed in next release.


DllNotFoundException: Failed to find library "tesseract41.dll" for platform x64.

DllNotFoundException: Failed to find library "tesseract41.dll" for platform x64.
IF anyone have this issue
please install   Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019
below link
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

I upgrade from 4.1.0 beta to 4.1.1, then meet same error, but install Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019 not work for me.


help notifications

Hello, Can you give me a link that explains how the notifications works, how to send command from a module to another... Do we have to change something in the main .js file of both modules...
Ex. can I ask jarvis in Googleassistant  to 'GO TO PAGE x' with page_selector ?

any module in the module name.js can do
this.sendNotification(string,value)

where string is the notification identifier, and value is the value that goes with it.
any module receiving the notification (all)
can ignore it, or process it, assuming it understands the value


Fix PSUseShouldProcessForStateChangingFunctions

Type of Change

[x] Bug fix (non-breaking change, fixes #4300 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Add SupportsShouldProcess to all cmdlets identified by the PSScriptAnalyzer rules
Approach

Add [CmdletBinding(SupportsShouldProcess)] and then wrapping any acting code in if ($Pscmdlet.ShouldProcess($SqlInstance, "Doing action on")) {
Commands to test

Invoke-ScriptAnalyzer .\functions\ -IncludeRule PSUseShouldProcessForStateChangingFunctions There should only be two cmdlets that haven't been addressed yet. Import-DbaCsvtoSql and New-DbaScriptingOption

this is awesome! thank you so very much. will merge once we get some tests passing - github still hasn't enabled webhooks yet

Anytime, Completely understand! Really trying to knock these PSScriptAnalyzer Rules down so that we can add that as a Pre PR check.

Looks like I may need to rebase before this PR goes through.

awessssssssssssssssssssssssssssssome! all tests pass 👍 👍 👍 👍


Add scripts for creating and deleting kind clusters

The following changes are implemented here to enable users to create and delete kind clusters for dev testing.

This moves the functions that create kind clusters out of the CI script and into its own script to allow running locally for a dev workflow. Additional checks were added to prevent the script from clobbering user's existing kube config and warn about multiple insecure-registry configurations.
Modify contexts to use cluster[0-9] to be consistent with the docs.
Add delete clusters script.

/lgtm