V2/diagram UI

Summary
After discussions with end-users, it was uncovered that some external tooling may be consuming Threat Dragon's threat model JSON.  For that reason, we should not make any breaking changes to the JSON schema (only additive).
Description for the changelog
Reverting breaking schema changes
Other info
Thanks again to Simone S for the insight!

@jgadsden - FYI: rolling back the breaking changes to the schema in v2 as a priority so that we don't get too far down the rabbit hole. :)

Sounds good to me @lreading - if we are backwardly compatible then that should be OK. We added a UUID to the individual threats that does not break <1.5.0 so all should be good.


A adult/porn subscription list

Hey i just wondering if someone here made a porn/adult subscription list for uBlockList. I'de like to have one for me please !

Hey there! I don't think this is in the scope of this repository.
But anyways, I just did a quick check on multiple search engines including: Google, DuckDuckGo, Bing, Brave, Ecosia and some SearXNG instances.
All of them seem to have a "Safe search" functionality that filters "adult content", though the SearX one doesn't seem to be as good.
Do you have a reason why those tools aren't enough for you?

hey Aug !
Safe Search is a great tool, but you can disable it. With Stayfocusd, i can disable safe research options, but on the page you can disable safe research directly (the button appear on the top right of the page)
Like maybe it can be deleted by UBlock ?


add max timeout to requests

Describe the bug
Clicking on the 3 month range in Analytics V2 causes timeouts that can bring an EC2 instance down. It happened to markedrestaurant.com:

To Reproduce
visit https://markedrestaurant.com/v2/dashboard?start_date=2022-12-01&end_date=2023-02-28&interval=3+months&page= multiple times in new browser tabs
Expected behavior
We should timeout requests at the rack layer so multiple failing requests don't bring the EC2 instance down.
logs
When the analytics dashboard V2 is rendered, we see over 1 million object allocations:
I, [2023-02-04T12:30:46.946519 #385]  INFO -- : [448daf50-f1bb-4787-8a3e-985b1bd9e1ce] Processing by Comfy::Admin::V2::DashboardController#dashboard as HTML
I, [2023-02-04T12:30:53.874555 #385]  INFO -- : [448daf50-f1bb-4787-8a3e-985b1bd9e1ce]   Rendered comfy/admin/v2/dashboard/dashboard.html.haml within layouts/comfy/admin/cms (Duration: 6916.9ms | Allocations: 1669282)
I, [2023-02-04T12:30:53.889954 #385]  INFO -- : [448daf50-f1bb-4787-8a3e-985b1bd9e1ce]   Rendered layout layouts/comfy/admin/cms.html.haml (Duration: 6932.3ms | Allocations: 1676767)
I, [2023-02-04T12:30:53.890353 #385]  INFO -- : [448daf50-f1bb-4787-8a3e-985b1bd9e1ce] Completed 200 OK in 6944ms (Views: 2838.0ms | ActiveRecord: 4098.7ms | Allocations: 1680244)

to put it into perspective, the root page on markedrestaurant.com needs only 12K object allocations to render:
I, [2023-02-04T12:33:42.017716 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10] Started GET "/" for <IP_ADDRESS> at 2023-02-04 12:33:42 +0000
I, [2023-02-04T12:33:42.027801 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10] Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>/<IP_ADDRESS>, ::1
I, [2023-02-04T12:33:42.033672 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10] Processing by Comfy::Cms::ContentController#show as HTML
I, [2023-02-04T12:33:42.086706 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10]   Rendered inline template within layouts/website (Duration: 4.1ms | Allocations: 1383)
I, [2023-02-04T12:33:42.109212 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10]   Rendered layout layouts/website.html.erb (Duration: 26.6ms | Allocations: 8737)
I, [2023-02-04T12:33:42.109886 #385]  INFO -- : [bc9d8096-95af-464e-9bb1-fb9d08dadc10] Completed 200 OK in 76ms (Views: 23.3ms | ActiveRecord: 40.5ms | Allocations: 12471)

after experiencing 2 outages for markedrestaurant.com -- I am escalating this beyond this bug fix into investigating a possible memory leak.
I observed markedrestaurant's Violet consume more than 1.89GB memory. The EC2 T3.small hosting the site has a maximum of 2GB RAM.
I am temporarily bumping EC2 instance size to T3.Medium which will give us 4GB of RAM which will restore service while we investigate.

On a related note, Given the compute requirements for restarone.solutions we attach a 4GB EBS volume for swap memory to the EC2 T3.small instance -- it is possible that markedrestaurant is reaching restarone.solutions in memory and compute requirements.
It is worth noting that since the latest Violet release (https://github.com/restarone/violet_rails/releases/tag/0.9.90) markedrestaurant is the only system experiencing issues (which softens the case for a memory leak, since other sites are fine)


Add Roadmap

Add a Roadmap were we could share with some of the high level tasks that will be done?
Probably add either to the wiki or the docs folder that will be created.
Originally posted by @jcfr in https://github.com/KitwareMedical/SlicerPipelines/pull/14#discussion_r803157593

Added the start of a roadmap.
https://github.com/KitwareMedical/SlicerPipelines/wiki/Roadmap


move to rc1

Also moved gradle plugin to 3.0.0-rc2 and paging to alpha 3.
This CL also adds a run_all_tests.sh shell script that runs all tests
in all projects

CI FTW

i don't see any comments from the CI :/. is it not setup to send comments?


Make app available as a webhook

WHAT

Make bot available as a webhook

WHY

Not to use websocket for reducing running cost.

hmm..., something needs to change. 🤔
{"severity":"ERROR","message":"failed to respond to a interaction request","error":{"message":"[404] The resource at the location specified doesn't exist.","name":"Error","stack":"Error: [404] The resource at the location specified doesn't exist.\n    at Object.runMethod (https://deno.land/x/discordeno@13.0.0-rc42/rest/runMethod.ts:6:11)\n    at sendInteractionResponse (https://deno.land/x/discordeno@13.0.0-rc42/helpers/interactions/sendInteractionResponse.ts:98:35)\n    at Object.converted.<computed> [as sendInteractionResponse] (https://deno.land/x/discordeno@13.0.0-rc42/bot.ts:181:13)\n    at EventPollStartExecutor.afterExec (file:///src/src/command/eventpoll/eventpoll_start.ts:163:36)\n    at async processCommand (file:///src/src/webhook/middleware/command.ts:28:19)\n    at async file:///src/src/webhook/middleware/command.ts:70:28\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async Application.#handleRequest (https://deno.land/x/oak@v10.6.0/application.ts:193:17)"}}

hmm..., nothing changed by the previous commit. 🤔
{"severity":"ERROR","message":"failed to respond to a interaction request","error":{"message":"[404] The resource at the location specified doesn't exist.","name":"Error","stack":"Error: [404] The resource at the location specified doesn't exist.\n    at Object.runMethod (https://deno.land/x/discordeno@13.0.0-rc42/rest/runMethod.ts:6:11)\n    at editInteractionResponse (https://deno.land/x/discordeno@13.0.0-rc42/helpers/interactions/commands/editInteractionResponse.ts:3:35)\n    at Object.converted.<computed> [as editInteractionResponse] (https://deno.land/x/discordeno@13.0.0-rc42/bot.ts:181:13)\n    at EventPollStartExecutor.afterExec (file:///src/src/command/eventpoll/eventpoll_start.ts:163:36)\n    at async processCommand (file:///src/src/webhook/middleware/command.ts:28:19)\n    at async file:///src/src/webhook/middleware/command.ts:70:28\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async dispatch (https://deno.land/x/oak@v10.6.0/middleware.ts:16:13)\n    at async Application.#handleRequest (https://deno.land/x/oak@v10.6.0/application.ts:193:17)"}}


Fix the behaviour of the new project field for Kind installation

Reference: https://github.com/kubev2v/forklift-console-plugin/pull/1409#issuecomment-2551625234 - comment  (1).

Enable the ProjectNameSelect component to run on Kind (non OCP) installation, the same as supported for the console namespaces menu.
Fix the namespace default value for upstream (konveyor-forklift for u/s,  openshift-mtv for d/s )

Screenshots for kind installation, current is set to all-namespaces
Before

After

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.21%. Comparing base (13484d0) to head (3dcb635).
Report is 164 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   36.81%   36.21%   -0.60%
==========================================
  Files         158      159       +1
  Lines        2548     2579      +31
  Branches      599      589      -10
==========================================
- Hits          938      934       -4
- Misses       1428     1643     +215
+ Partials      182        2     -180

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add FedRAMP environment support

adds the config parameter to support initializing the framework for the FedRAMP environment

@jeremywillans, I had to modify what you did in order for it to work. The FedRamp toggle was not being passed to the SDK properly so wasn't initializing using proper service URLs.
This is what I did in the framework.js file that allowed it to work correctly.
    let config = {       config: {       },       credentials: {         access_token: this.options.token       }     };     // add fedramp param if defined     if (this.options.fedramp) {       config.config.fedramp = true;     }


Support Directory project path argument

MSBuild today supports finding proj files by scanning CWD or through an unnamed argument which is the path/to/a/*.proj. It should also support path/to/a/projectdirectory/.

We'd just need to change this check to be if-no-project-file-OR-if-given-a-directory.

Also, we need to be careful on cross platform that Directory.Exists() works as expected if the path contains trailing slashes or something.


Updates CameraCache to handle Main Camera / Playspace destruction

Overview
Updates CameraCache to generate a main camera if no cameras are found in the scene. Previously, this would cause multiple null reference exceptions.
Destroying the playspace (accidentally or intentionally), adding the Toolkit to a completely empty scene or destroying the main camera are all common scenarios that the toolkit should be able to handle.
After creating the camera everything proceeds normally including the creation of a MixedRealityPlayspace transform and camera event system. DontDestroyOnLoad settings are also observed.
Testing Goals

In editor, you should be able to delete the camera and/or the playspace at any time without causing issues. The goal is to find a scenario where deleting one or both causes an error.
On device we should test scenarios where we load a scene with an MRTK instance but no camera or playspace, or else create a new MRTK instance in an empty scene.

Fixes #4046

Refresh(Camera.main) on line 23 in CameraCache will still throw a NRE. Check my Fork's PR for proper support.

Refresh(Camera.main) on line 23 in CameraCache will still throw a NRE.

Which line causes the NRE? I'm not sure I see anything in Refresh that'd be trying to access something on the null.

The only thing I don't like about the most recent changes is that in the default scene that ships with the toolkit, it will create a duplicate second camera

@keveleigh Can we try to get this into RC1 refresh?

/azp run mrtk

/azp run

I wasn't able to repro this issue either.

Sorry I meant a the demo scene when starting a new unity project

Sorry I meant a the demo scene when starting a new unity project, or whatever Unity calls it.

SampleScene.unity?
Are you referring to the old bug where that scene's camera wasn't properly tagged as MainCamera? It was fixed by Unity in 2018.3.


Convert to project json

You're storing the packages folder in the repo?

Hmm I wonder if this was added after I had moved the packages folder https://github.com/NancyFx/Nancy.Bootstrappers.Autofac/pull/33/files#diff-a084b794bc0759e7a6b77810e01874f2R31 =/


Moved test out of run_in_graph_and_eager_mode n rrelu.

see #1328

@fsx950223
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

LGTM Thanks!


Add Service Principal Details to Device Flow Auth

One of the less trivial parts of getting the code to work in the Use Device Flow Authentication section is what to use for application ID. You can't just generate a service principal with the default settings and use that. There are three things I think that the service principal needs that I struggled for hours to determine.

The service principal needs delegated API permissions to the resource end point you are trying to use.
The service principal needs to have the Access token checkbox checked in the advanced settings >> implicit grant section (that's the path in the App registrations (Preview) blade, unclear how to do it in the app registrations current view).
The service principal needs Default client type set to yes (under advanced settings as well).

If any of these requirements aren't met you get an unhelpful message that some unknown error occurred.
The reason I say I think these are the requirements is because it was trial and error to get here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b1e7e7d-3e45-61c7-664c-b29116fe3f14
Version Independent ID: 186aaf08-938a-c05b-68db-0f0efe5dd60f
Content: Authentication with the Azure SDK for Go
Content Source: azure-go-sdk-conceptual/azure-sdk-go-authorization.md
Sub-service: authentication
Technology: azure-sdk-go
GitHub Login: @sptramer
Microsoft Alias: sttramer

@slynickel Thanks for the feedback - I'll make sure that these improvements to the document go on the backlog and I take a closer look into what the service principal/application authentication requirements are. They may have changed since the article was originally written.


I get the empty result alwyas when i call the api 'getResourcesByLocale'

Describe the bug
I get the empty result alwyas when i call the api 'getResourcesByLocale'
that's my code:
    Crowdin.getResourcesByLocale('en', (data) => {
        var response = JSON.parse(data);
        console.log(response);
        Crowdin.getResourcesByLocale('ja', (data) => {
          var response = JSON.parse(data);
          console.log(response);
      })
    })

and here is the result's image

sometime it can work and i got the translation on result's 'string' parm,but mostly it give me empty result.
is the feature still unstable or something else?

@liantianyun Could you specify platform?

@liantianyun Could you specify platform?

andorid

@liantianyun Thank you. We will check the issue or contact you in case other questions.

@liantianyun Thank you. We will check the issue or contact you in case other questions.

thank you. i'm looking forward to your replay because i about to use it

@liantianyun Thank you. We will check the issue or contact you in case other questions.

there is a another question.i update and release the translation on

but i got the updated data until this time

@liantianyun Thank you. We will check the issue or contact you in case other questions.

hi。It seems that this problem has not been repeated today. The difference is that I used the simulator yesterday and the real machine today. You can try to locate what causes the simulator to not work normally, but I can already use it normally


How to remove Topolvm completely from a Kuberenetes cluster?

Discussed in https://github.com/topolvm/topolvm/discussions/644

Originally posted by saeedkaz January 22, 2023
We had a Topolvm on our cluster. First I removed all data from it. After that, we tried to remove Topolvm from our cluster but it wasn't successful. I did the following steps First I reduce the replica set of Topolvm to 0 but it was unsuccessful and I get the following error.
MountVolume.SetUp failed for volume "kube-api-access-gvxr4" : object "namespace-test"/"kube-root-ca.crt" not registered
After that, I deleted the webhook with no success. After that, I deleted the lines about Topolvm in the scheduler which make the cluster unstable.
I am looking for a way to cleanly and completely remove Topolvm from the cluster

we discussed this issue in #644


vm eviction rates are per hour

The documentation did not provide insight into how to how to interpret eviction rates in absolute terms (i.e. beyond comparing between different VM types).
This commit moves information from the Q&A section [1] to the documentation.
[1] https://learn.microsoft.com/en-us/answers/questions/1193700/how-to-interpret-spotevictionrate-in-azure-resourc?page=1&source=docs#answer-1192845

@ju-shim
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@Court72 - this is good to go, sorry for the delay reviewing


Inappropriate driver is taken on using v1.3.0

[X] Programmer/board type: Stlink/v2
[x] Programmer firmware version:
[X] Operating system: Windows 7
[X] Stlink tools version and/or git commit hash: v1.3.0
[X] Stlink commandline tool name: st-util
[X] Target chip (and optional board): STM32L082

On using "st-util" of v1.3.0, we face issue on connecting with GDB tool. We see an inappropriate driver is considered instead of ST-Link driver. The driver information has been viewed using "st-info --serial".
Output:
GDB error
warning: while parsing target memory map (at line 1): Can't convert length="0xzx" to an integer

STLink driver issue
C:\stlink\bin>st-info.exe --serial
libusb: info [windows_get_device_list] The following device has no driver: '\\.\
USB#VID_147E&PID_2016#6&32FEB3AB&0&3'
libusb: info [windows_get_device_list] libusb will not be able to access it.
493f72063f7853533956193f

Attached the screenshot of driver highlighted with red rectangle.
Later we cloned the source of v1.5.1 and build them, the st-util here works as expected and proper driver is seen.
Thank you,
Dhinesh

@dhineshkumarmcci: Would it be possible for you to find out which is the first version to work as expected? (v1.3.1, v1.4.0, v1.5.0) That would help to allocate, archive and link this issue correctly within the project.

@Nightwalker-87, Think this is the same issue as #438

Well, they may be related, but the error message is different.

@dhineshkumarmcci: Can you please test the versions mentioned before, each with a clean build?

Let me finally address this issue with a comprehensive solution:

GDB error: This is a bug in the stlink toolset when using the MinGW development toolset. It has been fixed in PR #578.
Driver issue: A short web search reveals that this seems to be a common driver issue on windows where \Driver\WUDFRd fails to load. As the cited error also appears with several other usb devices, it is obviously not related to the stlink toolset. Should it be related to libusb, this bug may have been fixed in a later version of this external library:

v1.0.21 is used in Release v1.4.0
v1.0.22 is used in Releases v1.5.0 and v1.5.1

Hence this topic is now fully resolved, I am closing this issue now.


search_pubs() result size limited to 1000

I've noticed that, when I search for a general topic that has more than 1000 results associated with it, the generator ends at 1000. I'm wondering if this is a restriction on the google scholar side of things or if anyone else has noticed this issue.

That is the limit of the number of publications returned by Google Scholar

Just to clarify, we can't get more than 1k results and that's can't be fixed, so the only options we have are to use year_high, year_low filters, and to tailor the query to be more precise?

Scholarly operates on top of Google Scholar's web interface. If you can get it by searching the web, you can get it from scholarly. If it is not possible to get it from the web, then you cannot get it from scholarly either.


version bump to 0.38.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge/core

The recipe that passed when labbench was originally released is now failing with cryptic error messages. Is there a way to get debug info? Should I worry about this?
No packages are being built for aarch64 for this pure-python module, even though manual installs of all of the dependencies proceeds without any problems on my Mac. Any hints on how I can troubleshoot this?

Thanks in advance for any tips on this!

You need to update the checksum here. The error message is telling you that. You can click in the sdist on PyPI and then on view hashes:

You need to update the checksum here. The error message is telling you that. You can click in the sdist on PyPI and then on view hashes:

Thanks for the quick reply, and accommodating the easy answer on hashes my first maintenance update!
Do you have any insights about ways to trigger builds for ARM platforms?

You can make this pacakge noarch: python since it's a pure-python package and the packages will be installable on all platforms.

The way I had it is the recommended way. You can ignore the linter

@isuruf thanks for being so responsive! The reason that it wasn't noarch before was to support a windows-only dependency on the comtypes library, which doesn't exist on all platforms. What I've just committed removed comments that tag that as windows-specific.
If necessary, I can leave it this way, with comtypes as an optional dependency. Is there a better way of specifying windows-specific dependencies that is still compatible with noarch?

Is there a way to specify windows-specific dependencies that is compatible with noarch?

Yes, see https://github.com/conda-forge/labbench-feedstock/pull/2/commits/3771cf46f3f14d40b11716fd2d908382e0cb0251

Ahhh I see and then I blew away that change. I apologize for missing it, am reverting back to your version.

Are any further edits needed to support OS X?

You should also reapply https://github.com/conda-forge/labbench-feedstock/pull/2/commits/9009bda50559f50ea140ce4cca47d8ca7e2b1275

@h-vetinari - implemented that change in #3 with a version bump. Thanks for being so friendly in accommodating my newness here!


[Improvement][Code Style] Fix code format

Describe the question
You can find the DolphinScheduler's code style related configuration here.
Currently, there is a lot of old code that doesn't follow this rule, you can try to format them.
This is an easy work, you can use IDEA to do this.
Which version of DolphinScheduler:
-[dev]

@ruanwenjun Hello, I think I can do the job. Could you please assign it to me

@MonsterChenzhuo Hi, I assign this issue to you, look forward to your contribution.

I can try this issue，could you assign it to me?

Does this issue fixed?

Does this issue fixed?

I execute the checkstyle maven plugin, it executes success, I will close this issue.


Export ignore phpstan.neon.dist

Eh just see this now, but I fixed this in https://github.com/composer/installers/commit/86d774d411ce6455bd076641d12d604e4d484b96 - thanks though.


Add spm support

A nicer package manager: http://spmjs.io
Documentation: http://spmjs.io/documentation
http://spmjs.io/package/selectize

It is a package manager based on Sea.js which is a popular module loader in China.
spmjs focus in browser side. We supply a complete lifecycle managment of package by using spm.

If you need ownership of selectize in spmjs, I can add it for your account after signing in http://spmjs.io.

Thanks for the contribution but I can't keep track of all the package managers out there, and don't have the time to support them all


Zeroshot writing qual

add script in bin/ to do a zero-shot writing quality eval of sorts
improve docs significantly

getting the JSON to serialize and appropriately print stats too a while to figure out


500 error when content template has no RLP tag

If the sulu.rlp tag is required then there should be some kind of validation - or the URL should be automatically generated if this tag is absent based on the node-name.

Can we solve this by making the URL/RespourceLocator mandatory? (why is this in the "ready" column?)

Because we already said that this is solved by a better template validation. Means for me that the resource locator is mandatory for the pages, but not for the snippets.

@wachterjohannes Please make this fertig.


IRREPLACEMENTS IN THE JOBS PAGE

Description

FOOTER IS NOT PLACED PROPERLY
@aditya-bhaumik can you assign this to me??
Steps to Reproduce
change in margin top of both top container and copyright
this changes in css file could help in correcting it

Expected Behavior
No response
Actual Behavior
No response
Screenshots
No response
Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

this issue has been solved, so we are closing this issue.


feat(drag-drop): move into cdk

Moves the drag-drop module from cdk-experimental to cdk.

Do you want to get your other outstanding PRs in first?

Yeah that would be easiest since all of them are targeted to patch.

This one should be good to go now.


mingw compilation failures.

@Alexpux faced some compilation issues when compiling with mingw.
The master pull request is #786
He raised the point to back-port the changes to RB-1.1

@hodoulp there are more patches needed for 1.1. See - https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-opencolorio

The changes are also valid ones for the RB-1.1 branch.
However, the define order to declare OCIOEXPORT & OCIOHIDDEN are slightly changed in the new include/OpenColorIO/OpenColorABI.h.in file (which is part of the OCIO public API). It should not have any impacts on the C++ ABI compatibility.
If accepted, I would suggest to move to the next release version to 1.2 (instead of 1.1.2) to highlight the backward compatible change so that devs could adjust their code if they developed a workaround.
Any comments/suggestions?

@Alexpux From your patch list:

1, 5, 6, 7 & 8  are already in PR #786
2, 3, & 4 are not clear for me (i.e. back-port or not)

The goal of RB-1.1 is only to fix bugs, and not to add new things (i.e. new compiler or platform support for example). At least that's my understanding of the branch.

@hodoulp
Patch 002:

mingw not sippor fPIC flag
fix between MSVC/MINGW
install OpenColorIO.cmake and *-target.cmake int right location to be able find by cmake from other modules.  Right location is PREFIX/lib/cmake/OpenColorIO

Patch 003 - mingw alreaady have right strtok_r function
Patch 004 - Fix conditions in cmake that only for MSVC compiler

There are no any new things

Hi @Alexpux

The TSC welcomes any contribution to increase the platform/compiler support for the OCIO v1 release if it has no impact of the public API (and the C++ ABI compatibility) and knowing that the TSC does not commit itself to maintain to the new platform/compiler. The same rule also applies to the master branch i.e. OCIOv2.

So you can create a pull request for a better support of mingw in RB-1.1.


Linux Instructions step 3 fails

Swift version 3.0-dev (LLVM c191431197, Clang c6195325c5, Swift add621a959)
Ubuntu 16.10
Hello,
i want compile the libdispatch libray
3."Clone, build and install the libdispatch library. The complete instructions for building and installing this library are here, though, all you need to do is just this $ git clone --recursive -b experimental/foundation https://github.com/apple/swift-corelibs-libdispatch.git && cd swift-corelibs-libdispatch && sh ./autogen.sh && ./configure --with-swift-toolchain=/usr --prefix=/usr && make && make install"
the compiling process isn't running correctly
Log:
http://pastebin.com/nyqigx1K

@donutloop  I will point out two things:

Your log above says you're on Ubuntu 16.10. I'm not sure if libdispatch supports ubuntu 16.10 quite yet.
You specified --with-swift-toolchain=/usr --prefix=/usr, did you really install your swift drop in root (/)?

I will ask the libdispatch guys to comment on this as well.

yes , i use ubuntu 16.10

yes

i have exactly the same issue

@dgrove-oss any advice on compiling libdispatch on Ubuntu 16.10?

Looks to me like you are compiling with gcc, not clang.   Did you install the clang package?  libdispatch assumes all the swift prerequisite packages are installed.
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src/common -I./include -Wall -Wextra -Wno-missing-field-initializers -Werror -g -O2 -std=c99 -D_XOPEN_SOURCE=600 -fvisibility=hidden -g -O2 -MT src/linux/libkqueue_la-platform.lo -MD -MP -MF src/linux/.deps/libkqueue_la-platform.Tpo -c src/linux/platform.c  -fPIC -DPIC -o src/linux/.libs/libkqueue_la-platform.o

Closing as it looks like the prerequisites haven't been installed, and Ubuntu 16.10 is not officially supported.


Update README.md

I'm no native speaker and haven't read the whole readme, just thought that this is still better than nothing.
I'll open follow-up PRs when I have the time to read more. Sounds definitely interesting. :clap:

@despairblue thanks! May be closed.


Subscription plans are duplicated

Describe the bug
There are duplicates in available plans.
To Reproduce
Steps to reproduce the behavior:

Log in as a user
Go to Subscriptions page
Click on Edit subscription
See duplicated plans

Expected behavior
Plans should not be duplicated. There should be only 3 different plans available.

Can't reproduce for now. It seems that stripe API do not create new products when same name is provided, but return existing ones instead.


Fix user-reported bugs on /docs/guides/crosswalk/aws/eks/

Problem
This page has a high blended score (2045) for traffic, bounce rate, and negative feedback.
Users report "cluster.provider" and "cluster.kubeconfig" don't work as expected in this guide.
Also, the example app is not consistent with the GKE example in /docs/tutorials/kubernetes/gke/ (not clear why we chose to use different examples or why one is a 'tutorial' and one is a 'guide').
Proposed Solution

[ ] Test for "cluster.provider and cluster.kubeconfig don't work"
[ ] Adapt Guestbook app example from /docs/tutorials/kubernetes/gke/

As we update this doc, it'd be good to pull its examples into example-programs using make new-example-program and the example-program shortcode. ✨


Osram Motion Sensor unknown ZHAPresence and ZHATemperature Sensor

The Sensor works correctly , Just noticed the warning.
/sensors/37: warning: unknown ZHAPresence sensor {"config":{"battery":80,"duration":12,"enrolled":0,"on":true,"pending":[],"reachable":true},"ep":1,"etag":"47ee580cdd75b0524eeef5a4b4bfd818","lastannounced":null,"lastseen":"2021-12-05T23:21Z","manufacturername":"CentraLite","modelid":"Motion Sensor-A","name":"Garderobe Bewegungsmelder","state":{"lastupdated":"2021-12-05T22:40:44.265","presence":false},"swversion":"����������������","type":"ZHAPresence","uniqueid":"00:0d:6f:00:0b:b2:fd:a5-01-0500"}
[06/12/2021, 00:25:00] [Deconz] Phoscon-GW: /sensors/38: warning: unknown ZHATemperature sensor {"config":{"battery":80,"offset":0,"on":true,"reachable":true},"ep":1,"etag":"91ec474fe0d5cbb00c8f42dd73dc8e26","lastannounced":null,"lastseen":"2021-12-05T23:21Z","manufacturername":"CentraLite","modelid":"Motion Sensor-A","name":"Garderobe Bewegungsmelder","state":{"lastupdated":"2021-12-05T23:21:03.180","temperature":2060},"swversion":"����������������","type":"ZHATemperature","uniqueid":"00:0d:6f:00:0b:b2:fd:a5-01-0402"}

You can safely ignore these warnings.  I should probably remove these, as there's nothing to whitelist for these types of sensors.


Couldn't implement publisher ads

Can anyone help? I did everything correctly but ads doesn't show up and what can be a reason?Admob ads work but publisher ads not

Currently experiencing the same behavior. PublisherBanner component doesn't show anything for either test ads or real ads from the ad inventory. Ad mounts, onAdLoaded is called but nothing shows. Would be interested to know if others are having the same experience and if/how you've managed to solve it


[RHOAIENG-14520] Change supervisord files location for rhel images

This is a completition change for the opendathub-io/notebooks#747 (merged into this downstream in<PHONE_NUMBER>4f926a21c5d17c99bf8b8abc50d70c). We missed these two files because we don't have rhel based images in the upstream repository.
https://issues.redhat.com/browse/RHOAIENG-14520

We don't need any image build for this change.
/override ci/prow/images

/lgtm

let's move this on
/approve


Pipeline: Add 'prerelease' option to tinylicious-build

Changing Tinylicious port number, day 3:
Need the ability to publish a prerelease Tinylicious to pick up a prerelease 'service-utils' to avoid node-gyp attempting to run 'make' on the VM that lacks the 'build-essential' apt pkg.

The tinylicious version number doesn't support prerelease.   We don't use a separate branch release work flow, and every publish version is an "released" version.  On drawback of that is yes, it can't depend on prerelease server builds, but the thought is that tinylicious can trail update server packages.   Should we keep tinylicious on a older build of server packages that doesn't have this problem.  Or we can wait until the server package is released before doing the port change.

Thanks for the explanation.  I was only trying to move Tinylicious forwards because the pre-existing package.json depends on a prerelease package.
I'll instead try rolling that package backwards to the last released version (#5784).


Shuffle external links list (:elinks checker)

Detailed description
Shuffle the list of links to test. The set will normally be sorted per item they were collected in and in many situation trend towards having the same origin repeated multiple times in a row.
Same-origin distance distribution (number of other links between links to the same origin) in my set of 2000+ links from 500 items before to change:
Min.   1st Qu.  Median    Mean   3rd Qu.    Max.
 1.0       2.0    10.0   135.8     103.8  2089.0

Same-origin distance distribution after to change:
Min.   1st Qu.  Median    Mean   3rd Qu.    Max.
 1.0      15.0    52.5   207.0     202.0  1842.0

It’s not perfect but it’s an improvement.
Related issues

#1418

I like it! (Also props for adding statistical evidence ❤)
I’m not sure whether it makes sense to add a test — randomness is rather hard to test for…


Convert changelog to Markdown

Description of change
This converts the changelog (including news fragments) to use Markdown instead of reStructuredText.
We decided to make this change as we find Markdown easier to use and switching to it should lead to fewer formatting mistakes.
All future news fragments will need to be formatted using Markdown and use the .md extension. (This includes any in any currently open PRs.)
Checklist

[ ] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Do any added or updated endpoints appear in the API documentation? See docs/Maintaining the API documentation.md for more details
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Rebasing to incorporate existing news fragments now on develop.


[WinForms] Deprecate Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl quirk

Deprecate Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl quirk
Deprecate Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl quirk
Version introduced
3.0
Old behavior
In the .NET Framework 4.6.2 and previous versions the RichTextBox control would instantiate the Win32 RichEdit control v3.0 (versions differences), and for applications retargeting to .NET 4.7.1, the RichTextBox control would instantiate RichEdit v4.1 (msftedit.dll).
Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl was introduced to allow applications targeting .NET 4.7.1 and later to opt-out of the new RichEdit v4.1 and use the old RichEdit v3 instead.
New behavior
The switch is deprecated, only new versions of RichEdit control are supported.
Reason for change
.NET Core 3.0 is a new moderm development platform, and it brings significantly simpler servicing scenarios, thus allowing for removal of quirks targeting specific legacy use cases.
Recommended action
Remove the switch.
Ensure the code dependent on the switch contiues to work correctly.
Category

Windows Forms

Affected APIs
Not detectable via API analysis

Issue metadata

Issue type: breaking-change

/cc: @OliaG  @merriemcgaw


Allow naming file with single extension method after the target of the extension

When a file contains a single top-level extension function should allow naming the file after the fully qualified function, just like is allowed for extension properties
Steps to Reproduce
Given a class like this:
    class Foo {
        enum Status { A, B }
    }

If I create a file that only has a single extension method on Foo.Status like this:
    fun Foo.Status.image() {}

Observed Behavior
Ktlint demands that the file be named Image.kt which is not descriptive and may even conflict if I had multiple similar functions in the same directory
Expected Behavior
I should be able to name the file based on the target of the exension, so in this case FooStatusImage.kt.
Note that this is the behavior when it is an extension property, but not when it is an extension function.
Your Environment
ktlint 0.46.1

I like the suggestion for the expected behavior. So either the name of the function Image.kt or FooStatusImage.kt should be acceptable names.
For now, you can work around this by suppressing the rule for this file specifically:
@file:Suppress("ktlint:filename")

fun Foo.Status.image() {}

In my particular case I worked around it by converting it from a function to a property since it probably should have been a property all along

In my particular case I worked around it by converting it from a function to a property since it probably should have been a property all along

That works sometimes but in general it can't be a solution.
In my case, the rule wants to name my file Plus.kt
operator fun PaddingValues.plus(other: PaddingValues): PaddingValues {
  val self = this
  return object : PaddingValues {

    override fun calculateLeftPadding(layoutDirection: LayoutDirection): Dp {
      return self.calculateLeftPadding(layoutDirection) + other.calculateLeftPadding(layoutDirection)
    }

    override fun calculateTopPadding(): Dp {
      return self.calculateTopPadding() + other.calculateTopPadding()
    }

    override fun calculateRightPadding(layoutDirection: LayoutDirection): Dp {
      return self.calculateRightPadding(layoutDirection) + other.calculateRightPadding(layoutDirection)
    }

    override fun calculateBottomPadding(): Dp {
      return self.calculateBottomPadding() + other.calculateBottomPadding()
    }
  }
}

I would question if this rule should be applied to file which does not contain any class at all. In earlier versions, this rule wasn't applied in this case and I would really like to keep it this way (for the already provided reasons here).

Yeah I'd prefer the rules to be split. Currently it's all or nothing but I'd like to apply some rules and others not.

When can we expect a new tag including this fix?

When can we expect a new tag including this fix?

I don't know. You can track the progress of what I planned to do in this release


running pretty smoth after rebooting my ubuntu 14.04

it's got crashed for the first time i run it,and after rebooting my ubuntu 14.04.1
it's seems to be normal

Closing this out since it seems to be normal now and no details are available about the crash.


[$250] The selected approver has no background color, and the search input field appears when there are less than 8 members to select

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726843553984039
Action Performed:
Prerequisite: Control workspace with 3 members added

Go to staging.new.expensify.com
On a control workspace enable Workflows in more features
Click Workflows > Add approval workflow
select any member

Expected Result:
The selected approver shows the checkmark, background color and search field only if there are more than 8 members showing.
Actual Result:
The selected approver shows the checkmark correctly but has no background color and search field displayed for less than 8 members
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/41f7784e-d87a-4351-85aa-135c0b087ed3
https://github.com/user-attachments/assets/aae484b1-78b1-4b22-9980-0f2c03b234fb
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839025702753796102
Upwork Job ID:<PHONE_NUMBER>753796102
Last Price Increase: 2024-10-02

Issue OwnerCurrent Issue Owner: @akinwale

Proposal
Please re-state the problem that we are trying to solve in this issue.

The selected approver shows the checkmark correctly but has no background color and search field displayed for less than 8 members

What is the root cause of that problem?
1. The selected approver shows the checkmark correctly but has no background color.

Page WorkspaceWorkflowsApprovalsApproverPage uses InviteMemberListItem to display its option. That component does not have pressableStyle={[[item.isSelected && styles.activeComponentBG]]} style:
https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/InviteMemberListItem.tsx#L51
as we did in TableListItem:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/TableListItem.tsx#L47
We can observe the TableListItem behavior in WorkspaceMembersPage, where all the selected options are highlighted.
2. Search field displayed for less than 8 members

We don't have shouldShowTextInput prop in:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L239
What changes do you think we should make in order to solve the problem?
1. The selected approver shows the checkmark correctly but has no background color.

In this:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/InviteMemberListItem.tsx#L51
we should add:
            pressableStyle={[[shouldHighlightSelectedItem && item.isSelected && styles.activeComponentBG]]}

The shouldHighlightSelectedItem is new prop to make sure the change does not break other pages. So in case of WorkspaceWorkflowsApprovalsApproverPage, use shouldHighlightSelectedItem as true.
2. Search field displayed for less than 8 members

In this:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L239
add:
    const shouldShowTextInput = flatMap(sections, (section) => section.data)?.length >= 8;

will fix the issue.
What alternative solutions did you explore? (Optional)

Proposal updated

Proposal
Please re-state the problem that we are trying to solve in this issue.

The selected approver shows the checkmark correctly but has no background color and search field displayed for less than 8 members

What is the root cause of that problem?
1. The selected approver shows the checkmark correctly but has no background color.

Page WorkspaceWorkflowsApprovalsApproverPage uses InviteMemberListItem to display its option. That component does not have pressableStyle={[[item.isSelected && styles.activeComponentBG]]} style:
https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/InviteMemberListItem.tsx#L51
as we did in TableListItem:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/TableListItem.tsx#L47
We can observe the TableListItem behavior in WorkspaceMembersPage, where all the selected options are highlighted.
2. Search field displayed for less than 8 members

We don't have shouldShowTextInput prop in:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L239
What changes do you think we should make in order to solve the problem?
1. The selected approver shows the checkmark correctly but has no background color.

In this:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/components/SelectionList/InviteMemberListItem.tsx#L51
we should add:
            pressableStyle={[[shouldHighlightSelectedItem && item.isSelected && styles.activeComponentBG]]}

The shouldHighlightSelectedItem is new prop to make sure the change does not break other pages. So in case of WorkspaceWorkflowsApprovalsApproverPage, use shouldHighlightSelectedItem as true.
2. Search field displayed for less than 8 members
2.1 Option 1:

Create new state to store all the available approver:

const [allApprovers, setAllApprovers] = useState()
const shouldShowTextInput = allApprovers?.length >= 8

In:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L116
call setAllApprover(approvers).

Then pass shouldShowTextInput={shouldShowTextInput} to:
https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L239

What alternative solutions did you explore? (Optional)
2.2 Option 2:

Note: With this solution, assume we have > 20 available approvers. Now the search input is displayed. Then we search any keyword so that the results 's length is less than 8. The search input is hidden.

In this:

https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L239
add:
    const shouldShowTextInput = flatMap(sections, (section) => section.data)?.length >= 8;

will fix the issue.

@akinwale we already have a couple proposals for review! 🎉

@akinwale have you been able to review the proposals above

We can move forward with @abzokhattab's proposal here.
🎀👀🎀 C+ reviewed.

@akinwale The selected proposal have a few issues:

The search input of the approver selector doesn't hide if the policy has fewer than 8 members.

With this requirement, it leads to the search input is displayed when the input is empty, and then hidden if the input is not empty.

The selected approver has no background color.

With this requirement, the solution only highlights the selected approver when the page is initially loaded. However, I believe the expectation is for the selected approver to remain highlighted consistently, not just upon initial load. cc @dannymcclain since you reported the bug.

Right, basically any time a list item like this is in the selected state it should have a background color. Think of the checkmark and background color as being inseparable.

@akinwale I believe you should reassess the proposals in light of the above comment.

@akinwale What do you think about my thoughts?

@akinwale are you able to address @truph01 comments?

I will re-evaluate and provide feedback.

@akinwale just a friendly bump on this one...

Waiting for evaluation from @akinwale

@truph01 Could you post a video demo of your solution?

@akinwale Here is my video demo:
https://github.com/user-attachments/assets/217f61bc-cdb9-4b21-8e57-53de77ae994d

After a second review, we can move forward with @truph01's proposal here.
cc: @carlosmiceli

PR is ready

I'm going ooo until Oct 18. Given that the PR has not deployed to production yet starting the 7 day waiting period I'm going to keep this assign to only me and I can process payment when I return
Payment Summary [date, TBD]:

Fix: @truph01 [$250, if no regressions] OFFER
PR Review: @akinwale [$250, if no regressions] OFFER

PAYMENT SUMMARY FOR OCT 30

Fix: @truph01 [$250, if no regressions] OFFER
PR Review: @akinwale [$250, if no regressions] OFFER
please complete checklist above

[x]  [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

[x]  [@akinwale] Determine if we should create a regression test for this bug.
[x]  [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps
Workspace with fewer than 8 members

Launch Expensify
Navigate to the settings of a control workspace with fewer than 8 members.
Enable Workflows in more features.
Navigate to Workflows > Add approval workflow
Select any member
Verify that a checkmark is shown beside the selected approver, the selected item has a background colour, and that the search field is not displayed

Workspace with 8 members or more

Launch Expensify
Navigate to the settings of a control workspace with 8 members or more.
Enable Workflows in more features.
Navigate to Workflows > Add approval workflow
Select any member
Verify that a checkmark is shown beside the selected approver, the selected item has a background colour, and that the search field is displayed

Do we agree 👍 or 👎?

@truph01 and @akinwale - payments sent and contracts ended - thank you! 🎉


Missing dependency

There is no 'delegator.py' in dev dependencies section of pyproject.toml

Current state of the project is: "broken"!
Please, feel free to fix it.


Documentation

Hi,
Kite is looking like a great framework but the documentation could do with a little love, once I am finished my current work I will try and create a walk through for setting up Kite and Kontrol with Docker.  Should be next week sometime.

thanks nicholas! yes it can use some love indeed.


Cloudflare pages support

Hello,
I'm in the process of developing a Remix.js application intended for deployment on Cloudflare Pages. I'm interested in confirming whether this library is compatible with the deployment platform. As of now, I'm attempting to display the request output upon refreshing the page, but I'm encountering a lack of results. I'm uncertain if this issue stems from a mistake on my end or if there's another underlying reason for this behavior.
export const sitemap: SitemapFunction = async ({ config, request }) => {     console.log({ request }); }

This library should work with cloudflare pages, the error in the code is because you need to return an object with the required properties defined in the return type of SitemapFunction


AO-8444: general improvements

remove targets for releasing from the Makefile
move version related variables/methods to the util package
print the message body of all RPC calls in the debug level

Codecov Report

Merging #70 into master will decrease coverage by 0.03%.
The diff coverage is 82.6%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage      84%   83.97%   -0.04%
==========================================
  Files          33       33
  Lines        3132     3151      +19
==========================================
+ Hits         2631     2646      +15
- Misses        423      427       +4
  Partials       78       78

Impacted Files
Coverage Δ

v1/ao/internal/reporter/reporter_grpc.go
66.27% <100%> (+0.52%)
:arrow_up:

v1/ao/internal/reporter/oboe.go
91.14% <100%> (ø)
:arrow_up:

v1/ao/internal/reporter/methods.go
96.66% <60%> (-3.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28993a7...d302660. Read the comment docs.


Improve user roles

It is unclear how to set users to roles.  Accounts are automatically assigned the same permissions if they are logged in.  Allow configuration of roles and permissions for each account.
Admin account should be part of the file config (e.g. the way editors are).  Other account roles should live in the DB and be configurable by the web GUI or by a command line script.

Roles:
Admin - Lives in Repo config, not DB.  Has access to everything
Editor - Can create posts + everything View Only use can do
View-Only - Can view and subscribe to posts / tags
Add Role column to user table.  Permissions per role will be hardcoded


I accidentally hid the appbar and keyboard

I accidentally hid the appbar and keyboard,  now i cant chat or undo these things, as both of them are blocked... any way to undo this ?

Pull the hamburger menu from the left side, there you can unhide both appbar and keyboard


flatpak-managed-install.service fails to start properly when update.onactivation set to true (v0.2.0)

When starting up my laptop, I get an error that  flatpak-managed-install.service fails to start. When I pull up the service logs, it says it couldn't reach dl.flathub.org. My first guess is that it was trying to start before the network was active (I'm on a laptop with Wi-Fi), but the same thing happened in a virtual machine. Restarting the service using systemctl fixes the issue.
My config:
inputs = {
    nix-flatpak.url = "github:gmodena/nix-flatpak/?ref=v0.2.0";
}

...

services.flatpak = {
		enable = true;

		# Enable automatic updates
		update = {
			onActivation = true;

			# Check for updates daily
			auto = {
				enable = true;
				onCalendar = "daily";
			};
		};

		# Add remote(s)
		remotes = [
			{ name = "flathub"; location = "https://dl.flathub.org/repo/flathub.flatpakrepo"; }
			{ name = "kdeapps"; location = "https://distribute.kde.org/kdeapps.flatpakrepo"; }
		];

		# Install Flatpaks. For details, see https://github.com/gmodena/nix-flatpak
		packages = [ ...];
        };
};

systemd logs:
➜  nix-configuration git:(main) ✗ systemctl status flatpak-managed-install.service
× flatpak-managed-install.service
     Loaded: loaded (/etc/systemd/system/flatpak-managed-install.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Wed 2024-01-31 19:03:10 EST; 14min ago
TriggeredBy: ● flatpak-managed-install.timer
    Process: 1035 ExecStart=/nix/store/5ha0n1hqf2ialvy84k8hx52aavmv4gl2-flatpak-managed-install (code=exited, status=1/FAILURE)
   Main PID: 1035 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 25ms

Jan 31 19:03:10 legion systemd[1]: Starting flatpak-managed-install.service...
Jan 31 19:03:10 legion 5ha0n1hqf2ialvy84k8hx52aavmv4gl2-flatpak-managed-install[1044]: error: Can't load uri https://dl.flathub.org/repo/flathub.flatpakrepo: While fetching https://dl.flathub.org/>
Jan 31 19:03:10 legion systemd[1]: flatpak-managed-install.service: Main process exited, code=exited, status=1/FAILURE
Jan 31 19:03:10 legion systemd[1]: flatpak-managed-install.service: Failed with result 'exit-code'.
Jan 31 19:03:10 legion systemd[1]: Failed to start flatpak-managed-install.service.

Hey @8bitbuddhist,
Are you tracking main or a release?

Hey @8bitbuddhist,
Are you tracking main or a release?

I'm using v0.2.0

I just tried rebooting without onActivation and the service started up just fine. And I have daily updates configured anyway, so it's not like this is a major issue for me. Thanks for your work on this!

I'm also seeing this issue.

I did some more testing, and I get the bellow when I have nothing in services.flatpak.update... set:
[FAILED] Failed to start flatpak-managed-install.service.
See `systemctl status flatpak-managed-install.service` for details.

but when I have anything set in services.flatpak.update... then I also get:
[FAILED] Failed to start Home Manager environment for reedclanton.
See `systemctl status home-manager-reedclanton.service` for details.

I was able to replicate on a nixos 23.11 vm. Working on a fix.

Hey @8bitbuddhist @ReedClanton. I think the issue was an incorrect dependency
on systemd unit boot order. I required the flatpak-managed-install to start after network.target was
reached, but that alone does not guarantee that connectivity has been established.
There a tentative fix in the linked PR (#37). Tagged as WIP since I'd like to do a bit more testing.

@gmodena Stupid question, how would I test this in my setup? What URL would I change inputs.nix-flatpak.url to in my flake.nix?

@gmodena Stupid question, how would I test this in my setup? What URL would I change inputs.nix-flatpak.url to in my flake.nix?

nvm, figured it out. I used inputs.nix-flatpak.url = "hithub:gnodena/nix-flatpak/fix-boot-activation";

@gmodena & @8bitbuddhist No more failures during boot! Seems like it fixed it. Also, pretty sure that getting ride of those failures decrease my boot time!

thanks for testing the patch @ReedClanton !

Hey! I don't know if this is related but,
I have imported and set the flatpaks I would install (e.g. obs), the first few times it worked
However, now it just does not seem to do "anything", journalctl -f reports nothing....
Note.. this is with HM

I can't find latpak-managed-install.service but that is probably cause it's an HM module


pressurement cluster again

Problem
What is being fixed?  Examples:

Pressure measurement cluster is not moved from existing implementation

Change overview

Pressure measurement cluster moved into seperate xml

Testing
How was this tested? (at least one bullet point required)
superseeds #7228

@bzbarsky-apple here is the second attempt, lets see if we can get it merged before the repo runs away again ;)

@janusheide This PR removes the pressure management cluster from various apps (e.g. all-clusters-app).  Is that intended?

@janusheide I tried to fix this up, but I don't have write permissions to git@github.com:Grundfos/connectedhomeip.git
The fixup goes like this:

git rebase -i to drop the two "add generated stuff" commits.
In the "moved xml file to proper folder" commit, drop all changes except the actual renaming of the .xml file.

With that, you are done.  You can run regeneration if you want, but there should be no changed to generated files (and ther are not for me), because the XML is just moving around with no other changes.

I opted to go back to the first commit, which did not contain any auto generated stuff, fix that and force push to the branch, simpler and requires no merging work.

ZAP ci error seems real. The zap configuration file for all-cluster-app (and any that had the pressurment cluster enabled) need to be update also

I am unable to fix this as the zap tool got broken here after a recent update...

@jmartinez-silabs too me the zap ci error looks like an error caused by the zap tool, do you have an idea of what needs to be done to fix this?

@janusheide The ZAP error shows that it fails to do the generatoion of files for all-clusters-app base on this .zap configuration.
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
It probably also fails for you localy when you run any generation script. Does any example/controller work?
scripts/tools/zap_regen_all.py
From what I see from the diff files you moved some definitions from one xml file to another. the Pressure Measurement was in another domain and i don't see any change to the configuration files (.zap) Seems like the .zap file is still configured to enable the clusters Pressure Measurement in the Measurement & Sensing domain that doesn't exist anymore.
Verify tha the zap files are correctly configured based on your changes
run ./scripts/tools/zap/configure.sh and open the examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

/rebase

@jmartinez-silabs @Damian-Nordic @jepenven-silabs @msandstedt @saurabhst Please take a look?

@janusheide Was the change of ScaledTolerance from int16s to int16u purposeful?

@bzbarsky-apple according to the spec https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/PressureMeasurement.adoc scaled tolerance should be unsigned.
It was unsigned in the zcl raw imported version spec.
https://github.com/CHIP-Specifications/connectedhomeip-spec/commit/5c8e240d94823460e2fbb417ee1811c5597f97cc#diff-1e1868167ee2036591c2cdd83f795b6890f2627f56bbd44169dcd47372d10d79
So it looks like the spec and impl diverted before and now they are the same. To me it makes sense that it is alway positive, but from the definition of the scaled tolerance it looks like a tolerance of +42 and -42 would give the same range, but in different orders.

@janusheide OK, great.  I just wanted to make sure that was a purposeful change, since the PR description just talked about moving to a separate XML; not saying we shouldn't have made it in general.


Adding language support note.

I believe that we should specify in our documentation which languages we provide support in. This will help to avoid future issues with non-supported languages.

I'm not entirely convinced that this is necessary. I will leave this to you guys to decide.

Seems good

It doesn't hurt to mention it there, but I wouldn't add that as a callout, and maybe just mention it in a brief sentence "support is provided in English only" under the Support resources section.


CASMMON-129: Create listing of Grafana Dashboards by Component

Backport of https://github.com/Cray-HPE/docs-csm/pull/1434

I just backported the same list of dashboards as was included in the original csm-1.2 PR. An SME should review this list to make sure that all of the listed dashboards existed in csm-1.0. This PR should not be committed until this review has happened.


Use the Atom Beta executable to verify startup snapshots when building Beta

Fixes this error on Circle: https://circleci.com/gh/atom/atom/5167
/cc @as-cii @iolsen

Help understand


Blank screen except for a cursor.

Discussed in https://github.com/hyprwm/Hyprland/discussions/896

Originally posted by Si-Ki October 22, 2022
Hyprland version: hyprland-bin form aur 0.16.0 beta-1
I wasn't sure if this classifies as a bug, so posting this here instead of creating an issue,
I install hyprland,
I make this file, and run it
hyprland starts, I see cursor, nothing else,
I can launch alacritty, but can't see it (sure that it launched cuz I wrote "killall Hyprland" and it worked, the screen was black all the time, the cursor changed to a caret)
Log here,
sorry for any stupid mistakes I might have made, and thank for helping @vaxerski

@Dickby this looks to me like your matrix PR broke GLES2 compat
[wlr] [GLES2] GL_INVALID_VALUE in glUniformMatrix(matrix transpose is not GL_FALSE)
[wlr] [GLES2] GL_INVALID_VALUE in glUniformMatrix(matrix transpose is not GL_FALSE)
[wlr] [GLES2] GL_INVALID_VALUE in glUniformMatrix(matrix transpose is not GL_FALSE)
[wlr] [GLES2] GL_INVALID_VALUE in glUniformMatrix(matrix transpose is not GL_FALSE)
[wlr] [GLES2] GL_INVALID_VALUE in glUniformMatrix(matrix transpose is not GL_FALSE)

@Si-Ki can you try compiling with LEGACY_RENDERER? (see wiki)

fuck, I was waiting at the discussion page... posted as you asked here
also, I go compile with that flag, might take a long time, thanks @vaxerski

Compiled with legacy_renderer, log(when ran with startw file here, still the same results...  Also, no need to ping me every single time.

ok, cool

we should make GLES2 have the matrix transposed by us tho @Dickby

Should be fixed on HEAD with LEGACY_RENDERER.

@vaxerski , i found this issue just now! I'm really sorry for causing this issue and not responding.
I was quite busy at that time.


[feature request] Add optional 'directory/path' parameter to save available pretrained models.

I may be wrong but I could not find any simple way of specifying where the pre-trained models from torchvision.models are saved.
By default, they are saved in the ...\.torch\models\ directory.
It would be very helpful to have an optional parameter to set the download path for the pre-trained models. (something like model_dir parameter in torch.utils.model_zoo.load_url())
If there is an existing way to do this already, please correct me in the comments.

The documentation is a bit confusing in this regard, to be honest. As documented here (the same function you mentioned), the TORCH_HOME environment variable can be used for this. Since torchvision uses this function (e.g., here) models will be downloaded to $TORCH_HOME/models.
Still, it feels like a workaround. I agree that a model_dir argument would be nice in this case.

Thanks for the feedback,
I agree that having a better documentation for TORCH_MODEL_ZOO env var would be great. Could you send a PR improving the doc?
Thanks!

Thanks a lot @fadel.
This is exactly what I was looking for.
Also, the changes made to the docs in the above pull request aren't reflected in the documentations webiste YET: https://pytorch.org/docs/stable/torchvision/models.html
@fmassa Could you please tell me if having model_dir directly as a parameter in torchvision.models alongside pretrained be a good idea or would that be counter-intuitive?

@rsk2327 I had submitted a PR regarding this but as you can see it is still open. Meanwhile, you can save it in the desired directory using the environment variable TORCH_HOME.

I am just coming from issue #2299 , and inclined to agree with adding an extra parameter for controlling the model-path of both downloading and loading.
As @fmassa explained in #2299 , using TORCH_HOME makes our code agnostic to the model-path . After thinking it over, I find it convenient for the novice, as it makes the users don't need to consider the model-path for both downloading and loading.
But it lead to much more inflexibility for those familiar with Pytorch and Python
For this reason, I have worked out a compromise as a temporary solution. (Many codes are following the source codes in torchvision)
For downloading:
from urllib.parse import urlparse
import torch.utils.model_zoo as model_zoo
import re
import os
def download_model(url, dst_path):
    parts = urlparse(url)
    filename = os.path.basename(parts.path)

    HASH_REGEX = re.compile(r'-([a-f0-9]*)\.')
    hash_prefix = HASH_REGEX.search(filename).group(1)

    model_zoo._download_url_to_file(url, os.path.join(dst_path, filename), hash_prefix, True)
    return filename

Downloading demo
model_urls = {
    'vgg11': 'https://download.pytorch.org/models/vgg11-bbd30ac9.pth',
    'vgg13': 'https://download.pytorch.org/models/vgg13-c768596a.pth',
    'vgg16': 'https://download.pytorch.org/models/vgg16-397923af.pth',
    'vgg19': 'https://download.pytorch.org/models/vgg19-dcbb9e9d.pth',
    'vgg11_bn': 'https://download.pytorch.org/models/vgg11_bn-6002323d.pth',
    'vgg13_bn': 'https://download.pytorch.org/models/vgg13_bn-abd245e5.pth',
    'vgg16_bn': 'https://download.pytorch.org/models/vgg16_bn-6c64b313.pth',
    'vgg19_bn': 'https://download.pytorch.org/models/vgg19_bn-c79401a0.pth',
}

path = 'D:/Software/DataSet/models/vgg'
if not (os.path.exists(path)):
    os.makedirs(path)
for url in model_urls.values():
    download_model(url, path)

For loading:
import glob
import os
def load_model(model_name, model_dir):
    model  = eval('models.%s(init_weights=False)' % model_name)
    path_format = os.path.join(model_dir, '%s-[a-z0-9]*.pth' % model_name)

    model_path = glob.glob(path_format)[0]

    model.load_state_dict(torch.load(model_path))
    return model

Loading demo
model_dir = 'D:/Software/DataSet/models/vgg/'
model = load_model('vgg11', model_dir)

Hope it helpful~


cudatext: 1.163.0 -> 1.163.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cudatext is: "Cross-platform code editor"
meta.homepage for cudatext is: "https://cudatext.github.io/"
meta.changelog for cudatext is: "https://cudatext.github.io/history.txt"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.163.1 with grep in /nix/store/z2s9n46mg369cbgzxg3nzwb3qn4kv6h1-cudatext-1.163.1
found 1.163.1 in filename of file in /nix/store/z2s9n46mg369cbgzxg3nzwb3qn4kv6h1-cudatext-1.163.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cudatext
cudatext-gtk
cudatext-qt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z2s9n46mg369cbgzxg3nzwb3qn4kv6h1-cudatext-1.163.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cudatext https://github.com/r-ryantm/nixpkgs/archive/d1a304948573229357f5ce2bf44b51d37e551316.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z2s9n46mg369cbgzxg3nzwb3qn4kv6h1-cudatext-1.163.1
ls -la /nix/store/z2s9n46mg369cbgzxg3nzwb3qn4kv6h1-cudatext-1.163.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

cudatext
cudatext-gtk

Maintainer pings
cc @sikmir for testing.

1.163.2 is out


mate.marco: 1.20.1 -> 1.20.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/marco/versions.
These checks were done:

built on NixOS
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/marco-message had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/marco-window-demo had a zero exit code or showed the expected version
/nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/marco passed the binary check.
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/marco-theme-viewer had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-message-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-window-demo-wrapped had a zero exit code or showed the expected version
/nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-wrapped passed the binary check.
Warning: no invocation of /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-theme-viewer-wrapped had a zero exit code or showed the expected version
2 of 8 passed binary check by having a zero exit code.
0 of 8 passed binary check by having the new version present in output.
found 1.20.2 with grep in /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2
directory tree listing: https://gist.github.com/5f84e537102f55b7305fa05523d6ae45
du listing: https://gist.github.com/0c776c9cc3cd0b81c377dca02c0ce516

meta.description for mate.marco is: '"MATE default window manager"'.
cc @romildo for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 75dc4a5b67c4cecc75f99c5f26bcac3d4958c4c3 && nix-shell --pure -I nixpkgs=. -p mate.marco

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mate.marco
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: mate.marco
Partial log (click to expand)
shrinking /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-wrapped
shrinking /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-window-demo-wrapped
shrinking /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-message-wrapped
shrinking /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin/.marco-theme-viewer-wrapped
shrinking /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/lib/libmarco-private.so.1.0.0
gzipping man pages under /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/lib  /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2/bin
patching script interpreter paths in /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2
checking for references to /build in /nix/store/3d7i93si0k0hw4rnizj1wbfxc05p0rib-marco-1.20.2...

Success on aarch64-linux (full log)
Attempted: mate.marco
Partial log (click to expand)
shrinking /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/bin/.marco-message-wrapped
shrinking /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/bin/.marco-window-demo-wrapped
shrinking /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/bin/.marco-wrapped
shrinking /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/bin/.marco-theme-viewer-wrapped
gzipping man pages under /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/lib  /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2/bin
patching script interpreter paths in /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2
checking for references to /build in /nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2...
/nix/store/5gr6zsxvs17k1mf6nf47dim1cm96fz9j-marco-1.20.2


langchain[patch]: support binding oustide create_react_agent

Hi @baskaryan, any news on this PR or on #16010?

Closing following discussion with @baskaryan.


the default configuration entries cannot be deleted.

i don't need "Eslint", but i can't remove it form my settings.

fixed


I’m getting a ‘command insertImage no found’ error when I try to insert an image.

That sums it up.  I select the Insert Image icon on the Docs Authoring ribbon, and I get a ‘command insertImage no found’ error when I try to insert an image. I tried reinstalled the authoring pack; same result.
But other buttons still work, such as inserting links, or bold or italic.
What to do?
thanks!

@maggiesMSFT Thank you for reporting this issue. Sorry for any inconvenience and we are working on addressing this bug. This issue has been fixed with this PR #445. We will be releasing as soon as possible.

Hi, @bharney0 -- thanks! Looking forward to the fix.


Outgunned under v12.328

Permissions for players seem totally messed.. Here's a list of things they can't do we've discovered so far:

Create Actors (even when in User Permissions all of this is set)
Edit Items on the sheet. Gear is the best example. They can create an item but not edit its title (on the window) or see the mag glass to edit it off their sheet.

I've mitigated #1 by creating a character entry for them, but #2 really cramps our style...
Thanks..

Heya
Issue 1 - I think this is a Foundry issue, not an Outgunned issue (although there is probably a way to code a solution).  If you go in to Foundry > Game Settings > User Management > Configure Permissions you can set it so players can create actors/
Issue 2 - I've got a fix ready so players can edit Gear, Gun, Ride, Experience names.  The other items I'm proposing to restrict to GMs as these are things that are game settings.
Let me run it past my co-authors and hopefully this can be released quickly.

On Issue 1, I've set those permissions already and still no create entitlements for players as described.

Thanks - Issue 2 I've released a new update (Beta 2) - please let me know if this fixes it.
Issue 1 - I've tested this without modules and it works for me.  What modules are you using and do you still get the issue if you deactivate them.   If it's a module conflict I may have a lead on the problem and will do more testing when I'm home on Monday.
Do you self host or does someone else host for you?  Just trying to think of permissions areas and what the system may be interacting with to narrow down the problem.
Cheers
Simon

Host myself, as I run the NODE.JS version on my own in-home server. With no modules active, here's what I get as a player when attempting to create a character:

Ok, the permissions issue has now shown up in Pathfinder, so clearly its a Foundry issue....

The error is logged on Foundry Github - https://github.com/foundryvtt/foundryvtt/issues/11311
I will keep the issue open until it's fixed and will aim to test when it gets patched.

Running 2.03 now, the player can create & edit (via the popup) but after that, no edit possible other than to delete. Here's my test player and his sheet:

Is this by design? I'll just make sure to warn my players before they start editing items..

Additionally, player cannot edit cost on the item/gear window:

Additional, additional: if I LOCK the sheet then the magnifying glass appears and I can edit all values on the item/gear popup.. Again, by design?
Thanks!

New release (2.04) will allow players to edit all data points for Guns, Rides and Gear - hopefully this resolves the issues you've flagged (but please let me know if they don't - I won't close this until you say so).
Locking the sheet then opening the item via the magnifying glass will allow you to edit all values (so yes, by design) - it would be possible to code it so that you can only edit an item that is on a character sheet if the character is unlocked if there is a need for this.

2.04 solves the edit issue, thanks.


Fix Cargo clippy

This commit doesn't fix all the cargo clippy warnings, but drastically
reduces them (from 107 warnings to 11).
Some of the most popular warnings:

https://rust-lang.github.io/rust-clippy/master/#redundant_clone
https://rust-lang.github.io/rust-clippy/master/#needless_borrow
https://rust-lang.github.io/rust-clippy/master/#redundant_closure

I'd try rebasing #344 on top of this one, maybe it's easier...

Right i didn't notice #344 conflicted.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Le mercredi 22 décembre 2021 à 5:06 PM, Daniela Brozzoni @.***> a écrit :

I'd try rebasing #344 on top of this one, maybe it's easier...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because your review was requested.Message ID: @.***>


tracking requests fails

telpad, once tweaked to send request tracks via telemetryClient.TrackRequest(),

[ ] complains about the missing id in the json payload of the request and, when fixed,
[ ] the duration format is rejected by the server.

See #2 for a solution that works for me.

I have just had the same with most recent version of this SDK. Here is what we get from app insights server (I have formatted JSON to read easier):
Response: 206 -

{
    "errors": [
        {
            "index": 1,
            "message": "109: Field 'id' on type 'RequestData' is required but missing or empty. Expected: string, Actual: ",
            "statusCode": 400
        },
        {
            "index": 3,
            "message": "109: Field 'id' on type 'RequestData' is required but missing or empty. Expected: string, Actual: ",
            "statusCode": 400
        }
    ],
    "itemsAccepted": 3,
    "itemsReceived": 5
}

This ought to be fixed with ba3b5aa


Gamut Mapping Playground (multiple errors)

The gamut mapping playground has a bunch of console errors (about vue, and undefined objects).
https://apps.colorjs.io/gamut-mapping/
It still seems to work in Firefox, but is totally broken in Chrome.

Chrome Canary 132:

Firefox Nightly 133:

Fixed in https://github.com/color-js/apps/pull/10


Proform Pro 5000

Has the solution been tested on Proform Pro 5000 treadmills (current model)?  I'm looking to use this on a Raspberry Pi, it would be good to know if there has been success on this model?

I haven't heard either way from anyone, jump in and try!

Thanks, i have done as suggested have the application running.  Wifi was selected during the initial config and the IP address  (taken from the built in iFit tablet) and entered, result was ECONNREFUSED.  I deleted the settings config and attempted again, this time leaving the IP blank and allowing it to search for iFit and nothing was found.  Any ideas?


pallet::call macro does not preserve lint attributes

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug
The pallet procedural macro does not preserve any attributes on fns in a #[pallet::call] impl. This means that it is impossible to add a #[allow(lint)] or #[deny(lint)] attribute to a given call and have it be known/respected by the compiler.
It may make sense to filter unknown attributes from call fns in most cases, since they could be other procedural macros which could change things in ways that would break the expected contract of a call. However, I think that for developer ergonomics the lint macros should still be passed on to the compiler.
I believe that preserving allow, deny, and warn attributes is a fairly straightforward addition to the proc macro.
The workaround is to just use a global #![allow(lint)] for the entire crate, but that is less than ideal as it can mask new instances of a warning that a developer may care about.
Steps to reproduce
No response

@sam0x17


Fixes for adapter saildiff execution & TestCaseIds on globalsetup exception

Description
Fixes: https://github.com/paulegradie/Sailfish/issues/167
Fixes a recent bug introduced preventing test adapter saildiff execution

Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 5.18%. Comparing base (eacadc8) to head (7fb922e).

Files
Patch %
Lines

.../Sailfish/Extensions/Types/TrackingFileDataList.cs
0.00%
7 Missing :warning:

...e/Sailfish/Contracts.Public/Models/TestCaseName.cs
0.00%
4 Missing :warning:

...urce/Sailfish/Execution/SailfishExecutionEngine.cs
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #168       +/-   ##
==========================================
- Coverage   66.04%   5.18%   -60.86%
==========================================
  Files         309     232       -77
  Lines        8196    6745     -1451
  Branches      955     841      -114
==========================================
- Hits         5413     350     -5063
- Misses       2480    6381     +3901
+ Partials      303      14      -289

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fatal exception when trying to silentInstallApp

We have been testing a solution to silent install an app, and keep seeing this error appear in the logcat.
The WSO2 Agent App, and the WSO2 EMM System Service are signed by vendor with firmware signing key, the device is a COPE device, and the application we are trying to silent install is not signed by vender firmware signing key- as we thought that was the way it should be by following documentation.
The APK seems to build fine- why we're getting the  java.lang.NoClassDefFoundError is confusing.
W/dalvikvm( 2353): Unable to resolve superclass of Lorg/wso2/emm/system/service/utils/AppUtils$1; (31)
W/dalvikvm( 2353): Link of class 'Lorg/wso2/emm/system/service/utils/AppUtils$1;' failed
E/dalvikvm( 2353): Could not find class 'org.wso2.emm.system.service.utils.AppUtils$1', referenced from method org.wso2.emm.system.service.utils.AppUtils.silentInstallApp
W/dalvikvm( 2353): VFY: unable to resolve new-instance 1967 (Lorg/wso2/emm/system/service/utils/AppUtils$1;) in Lorg/wso2/emm/system/service/utils/AppUtils;
D/dalvikvm( 2353): VFY: replacing opcode 0x22 at 0x0004
W/dalvikvm( 2353): Unable to resolve superclass of Lorg/wso2/emm/system/service/utils/AppUtils$1; (31)
W/dalvikvm( 2353): Link of class 'Lorg/wso2/emm/system/service/utils/AppUtils$1;' failed
D/dalvikvm( 2353): DexOpt: unable to opt direct call 0x3c3b at 0x06 in Lorg/wso2/emm/system/service/utils/AppUtils;.silentInstallApp
W/dalvikvm( 2353): threadid=10: thread exiting with uncaught exception (group=0x41840ba8)
E/AndroidRuntime( 2353): FATAL EXCEPTION: IntentService[EMMSystemService]
E/AndroidRuntime( 2353): Process: org.wso2.emm.system.service, PID: 2353
E/AndroidRuntime( 2353): java.lang.NoClassDefFoundError: org.wso2.emm.system.service.utils.AppUtils$1
E/AndroidRuntime( 2353): 	at org.wso2.emm.system.service.utils.AppUtils.silentInstallApp(AppUtils.java:57)
E/AndroidRuntime( 2353): 	at org.wso2.emm.system.service.EMMSystemService.silentInstallApp(EMMSystemService.java:608)
E/AndroidRuntime( 2353): 	at org.wso2.emm.system.service.EMMSystemService.doTask(EMMSystemService.java:280)
E/AndroidRuntime( 2353): 	at org.wso2.emm.system.service.EMMSystemService.onHandleIntent(EMMSystemService.java:158)
E/AndroidRuntime( 2353): 	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
E/AndroidRuntime( 2353): 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 2353): 	at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime( 2353): 	at android.os.HandlerThread.run(HandlerThread.java:61)
I/Process ( 2353): Sending signal. PID: 2353 SIG: 9
I/ActivityManager(  522): Process org.wso2.emm.system.service (pid 2353) has died.
D/ActivityManager(  522): send app_CRASH broadcast, packageName:org.wso2.emm.system.service
W/ContextImpl(  522): Calling a method in the system process without a qualified user: android.app.ContextImpl.sendBroadcast:1162 com.android.server.am.ActivityManagerService.onVideoPlayerCrashed:3715 com.android.server.am.ActivityManagerService.handleAppDiedLocked:3745 com.android.server.am.ActivityManagerService.appDiedLocked:3883 com.android.server.am.ActivityManagerService$AppDeathRecipient.binderDied:1046```

We have the same Problem on Android 4.4.2.
I´m not realy familiar with Android and Java but I debug a little bit around this Problem.
I think here is a Problem with the "Hidden API / Internal API" which is used to Install the App.
 java.lang.NoClassDefFoundError: org.wso2.emm.system.service.utils.AppUtils$1
In the AppUtils.java Class on line 57
 PackageInstallObserver observer = new PackageInstallObserver()
This Class is inside the HiddenAPI but not in Android 4.4.2 Hidden API
The Package-Namespace of this Class is  => android.app
But in the Android 4.4.2 Repository is no PackageInstallObserver Class.
https://github.com/android/platform_frameworks_base/tree/android-sdk-4.4.2_r1.0.1/core/java/android/app/
In Android Lollipop the class can be found in this Namespace.
https://github.com/android/platform_frameworks_base/blob/lollipop-release/core/java/android/app/PackageInstallObserver.java
I think its a Compatibility Problem between the SDK´s / API´s.

In Android 4.4.2 we must use the PackageManager Class to do this.
https://github.com/android/platform_frameworks_base/blob/android-cts-4.4_r4/core/java/android/content/pm/PackageManager.java
Here is the working implementation:
https://github.com/paulononaka/Android-InstallInBackgroundSample/blob/master/app/src/main/java/com/github/paulononaka/installapkinbackground/apihelper/ApplicationManager.java#L302
I'll implement this in a fork this fallback should be thrown this exception

Looks like we are both attempting to do the same thing. I replaced the use of  android.app.PackageInstallObserver with android.content.pm.IPackageInstallObserver;  I'll report back if the fix I put in works at this fork: https://github.com/kelleyduran/product-emm

Thank you for share this Solution!
It works great on my 4.4.2 Test-Device!
I can cleanly Install and Uninstall Apps.
I do not understand why this was so badly implemented...
In the Agent application the abstraction is very beautifully done.
https://github.com/wso2/product-emm/tree/master/modules/mobile-agents/android/client/client/src/main/java/org/wso2/emm/agent/services/operation
I also see chances for more compatibility and features here....
For example it is possible to Hide / Unhide apps via the PolicyManager...
http://stackoverflow.com/questions/19114439/android-hide-unhide-app-icon-programmatically
But it's just not implemented
https://github.com/wso2/product-emm/blob/master/modules/mobile-agents/android/client/client/src/main/java/org/wso2/emm/agent/services/operation/OperationManagerOlderSdk.java#L511

Hi @kelleyduran  Could you please be of any help for #376 issue. Thank you.


logOn fail 85

Hello, i have couple of questions
I used steam desktop authhenticator to get  "identity_secret","device_id" then i added those to my config..  but at the and im getting 85 logon fail.. and our code was working before steam mobile guard.
"authCode"        : "", <-- we leave this empty
"steamid"      : "XXXXXXXXXXXXXX",
"secretuser"      : "K+XXXXXXXXXXX=",
"deviceid"		  : "3xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
function reWebLogOn(steam, callback) {
steam.webLogOn(function(newCookie){
helper.msg('webLogOn ok');
	offers.setup({
		sessionID: currentSessionId,
		webCookie: newCookie
	}, function(){
		if (typeof callback == "function") {
			callback();
		}
	});
	var steamcommunityMobileConfirmations = new SteamcommunityMobileConfirmations(
		{
		  steamid:         config.steamid,
		  identity_secret: config.identitySecret,
		  device_id:       config.deviceId,
		  webCookie:       newCookie,
		});

		steamcommunityMobileConfirmations.FetchConfirmations((function (err, confirmations)
	{
		if (err)
		{
			console.log(err);
			return;
		}
		console.log('steamcommunityMobileConfirmations.FetchConfirmations received ' + confirmations.length + ' confirmations');
		if ( ! confirmations.length)
		{
			return;
		}
		steamcommunityMobileConfirmations.AcceptConfirmation(confirmations[0], (function (err, result)
		{
			if (err)
			{
				console.log(err);
				return;
			}
			console.log('steamcommunityMobileConfirmations.AcceptConfirmation result: ' + result);
		}).bind(this));
	}).bind(this));

	});

}

I have no idea how "steam mobile guard" works. Also I don't see any usage of node-steam API in your snippet, so you're probably posting to the wrong repo anyway.


Fix requested output names

@krishung5 The problem was that for decoupled models the requested_output_names is always empty since the request object is released before and it was the reason why the test was failing.


Add unicode-ident workaround

Update MSRV in README
Add unicode-ident workaround
Update to the sparse path

Resolves: #267

See https://github.com/dtolnay/unicode-ident/pull/28 for the upstream change so this workaround is not required (for newer versions).