Should we add CSS clear both to .archive-pagination

I find that every time I build a theme I add
.archive-pagination { clear: both; }

Does it make sense to make this part of the theme by default?
I'm trying to come up with a time when one wouldn't want this and I'm not coming up with anything.

Just an idea to avoid extra css
https://github.com/salcode/bootstrap-genesis/pull/124

Yes, seems to be the answer.  See #156


ParBilinearForm::Update question

Do we need to update Xaux and Yaux in the ParBilinearForm::Update?
Somehow my code has the following in the ParBilinearForm::Update
   if (Xaux.ParFESpace() != NULL)
   {
       Xaux.Update();
       Yaux.Update();
   }

Maybe that is not necessary any more? I thought we always need to update the ParGridFunction after fespace is updated.

Looking at the current code in master, the update of Xaux, Yaux, and Ytmp happens here: https://github.com/mfem/mfem/blob/f00eb000ed2142a6d0242656fbf6581825bbfde4/fem/pbilinearform.cpp#L350-L355
However, this if check is not handling correctly the case where the FE space was modified in-place, i.e. the pfes pointer did not change but the underlying FE space changed (e.g. its mesh was refined). To handle this case we should modify the if statement to be
   if (Xaux.ParFESpace() != pfes || Xaux.GetSequence() < pfes->GetSequence())

where we need to define the new method GridFunction::GetSequence to return the GridFunction::fes_sequence field.

I ended up fixing the issue in a slightly different way in #3417.
@tangqi, can test #3417 with your code (removing your modification in ParBilinearForm::Update) if it's not too much trouble?
Thanks!

Thanks a lot. It works well with my code.


Wrong digest header creation when server has qop="auth,auth-int"

I always get "401 unauthorized" when trying to log in to a server which writes qop="auth,auth-int" in its answer. The problem doesn't exist with Curl.
I debugged the requests code and probably found the problem in auth.py. The function build_digest_header in class HTTPDigestAuth calculates
noncebit = "%s:%s:%s:%s:%s" % (nonce, ncvalue, cnonce, qop, HA2)
and gives back
base += ', qop="auth", nc=%s, cnonce="%s"' % (ncvalue, cnonce)
to the server.
So in our client digest calculation we use qop="auth,auth-int", which we take from the server response, and make the server use qop="auth" in its calculation by giving back this header.
While debugging I can log in correctly if I change noncebit on the fly to
noncebit = "%s:%s:%s:%s:%s" % (nonce, ncvalue, cnonce, "auth", HA2)
This would be my suggestion for the solution. Theqop for the calculation should be the same as we give back in our header.

We do not use qop=auth-int, we don't support it. When given multiple qop values like that in an auth challenge we're allowed to select one, and we have: auth.
You're right, however, about the fix. If we've chosen auth that's what we should use in our calculation. The simplest fix should be to pull the calculation of noncebit down into the only place it's used.
That said, can RFCreader @sigmavirus24 confirm that this is correct WRT the specs?

That said, can RFCreader @sigmavirus24 confirm that this is correct WRT the specs?

Is this the new requests/urllib3 thing? If so, I thoroughly approve.

Thank you for your quick responses.
Would pulling down noncebit also fit for qop="auth,auth-int"? Wouldn't we still calculate with the wrong qop in case we match the condition "'auth' in qop.split(',')" as we would do with qop="auth,auth-int"?
I think we should not calculate with the qop we read from the response and instead with the one we write into the header (the constant "auth").

@berndschultze Sorry, I was insufficiently clear. I agree. What I meant was pulling that line into the auth block and changing it to always specifically use auth.

@Lukasa You are right, I misunderstood. Thanks again.

I went back through RFC 2617 (which is still the definition of Digest Access Authentication, although parts were updated (not obsoleted) by 7235). tl;dr the ABNF says unambiguously:
      qop-value         = "auth" | "auth-int" | token

Where token is one or more letters (a-zA-Z), digits (0-9), and US-ASCII visible characters (excluding (),/:;<=>?@[\]{} and "). In otherwords, technically the server is doing the wrong thing but we can handle it because a , should never be part of the qop-value so it should be safe to approach this by following roughly this logic:
if 'auth' in set(qop_value.split(',')):
   qop = 'auth'
else:
   return None  # or whatever we return when we're not doing 'auth'

@berndschultze if you want to test out #2415 and let us know how that goes, that'd be awesome.


Distillation Enhancement

I don't find the tea config and tea ckpt, will you upload it soon?

The tea models for our distilled t/s/m are no-distilled s/m/l respectively, which have not been released yet. Thanks for the question, and we will release them in the next update. Meanwhile, you can also use the released distilled s/m as the teacher to distill t/s, which we believe can provide a better result.

Thank you for your work!


what is detailed operation of collapse window reshape and fc

i am intereted in your great work. However, in the network architecture figure in the paper, i am confused about  the detailed operation of "collapse window reshape and fc", would you please explain the procedure in detail. Thanks a lot!

Hi there,
Thanks for your interest! Have a look at the following code pointers:

For each MS-G3D block, we first expand the joint features by "unfolding" it (i.e. sliding temporal window, (N,C,T,V) --> (N,C,T,window_size*V)): https://github.com/kenziyuliu/MS-G3D/blob/master/model/msg3d.py#L43
We perform multi-scale graph convolutions on the spatial-temporal graphs (effectively a larger graph):

https://github.com/kenziyuliu/MS-G3D/blob/master/model/ms_gtcn.py#L55
https://github.com/kenziyuliu/MS-G3D/blob/master/model/ms_gtcn.py#L103
https://github.com/kenziyuliu/MS-G3D/blob/master/model/ms_gtcn.py#L106

The expanded features from unfolding the temporal windows are projected back to each frame with the FC layer (implemented with 1x1 conv, (N,C,T,window_size*V) --> (N,C,T,V):

https://github.com/kenziyuliu/MS-G3D/blob/master/model/msg3d.py#L54
https://github.com/kenziyuliu/MS-G3D/blob/master/model/msg3d.py#L65

(N=batch size, T=number of frames / number of windows, C=number of feature channels, V=number of nodes)
This would be much easier to understand if you try tracing the dimensions of the tensors. Hope this helps.


[SPARK-21672][CORE] Remove SHS-specific application / attempt data …

…structures
What changes were proposed in this pull request?
In general, the SHS pages now use the public API types to represent applications. Some internal code paths still used its own view of what applications and attempts look like (ApplicationHistoryInfo and ApplicationAttemptInfo), declared in ApplicationHistoryProvider.scala.
This pull request removes these classes and updates the rest of the code to use status.api.v1.ApplicationInfo and status.api.v1.ApplicationAttemptInfo instead.
Furthermore status.api.v1.ApplicationInfo and status.api.v1.ApplicationAttemptInfo were changed to case class to

facilitate copying instances
equality checking in test code
nicer toString()

To simplify the code a bit v1. prefixes were also removed from occurrences of v1.ApplicationInfo and v1.ApplicationAttemptInfo as there is no more ambiguity between classes in history and status.api.v1.
How was this patch tested?
By running existing automated tests.

Can one of the admins verify this patch?

@vanzin

Please clean up all of the template from the PR description.
ok to test

ok to test

PR description was cleaned, thanks for catching it.

ok to test

Test build #84618 has started for PR 19920 at commit 29d8735.

@shaneknapp any idea why the PR builder is not testing this?

err, ignore that

Test build #84620 has started for PR 19920 at commit 9d46804.

Test build #84618 has finished for PR 19920 at commit 29d8735.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84618/
Test PASSed.

Test build #84620 has finished for PR 19920 at commit 9d46804.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84620/
Test PASSed.

Merged build finished. Test PASSed.

Test build #84650 has started for PR 19920 at commit 68eb3b9.

Test build #84650 has finished for PR 19920 at commit 68eb3b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84650/
Test PASSed.

Merging to master.

Thanks for your help @vanzin


refresh schedule when user clicks cancel or clear the searchbar

the original issue was https://github.com/driftyco/ionic-conference-app/issues/95
afterthat, clear event callback was implemented in https://github.com/driftyco/ionic2/commit/53dd312b39c508a4c893d3c78d5e082ed12db168
this pull request is just utilize the new callback and refresh the schedule list

Thank you for the PR, but the queryText is already cleared by the clear button and I think the clear should trigger the input event. This way we can use one event to update the schedule, and if the user doesn't want the clear included they can use (keyup). Created an issue here for this: https://github.com/driftyco/ionic2/issues/818


feat: factory reset v2

@ronny-standtke omnect-device-service meanwhile sends results as json in body. I guess we should pass the result back to the ui? Can you take care of in your PR? You can take have a look into web_service.rs of ods if merged: https://github.com/omnect/omnect-device-service/pull/116


upgrade babel's  configuration file so that remove babel…

Removing Babel's Stage Presets
Upgrade the Babel configuration file to match the Babel update

Try also to run yarn build and commit size snapshot. We'll see how the size is changed with class properties in loose mode.

I've tried it before submitting, and after doing it once, after comparing it with the current version, it turns out that the values are the same as before.


please add to docs the version of kustomize used

ideally, each release of kustomization (one that is seaprate tool from kubectl) to be accompanied with release of providers. it got transformers stuff recently - cool

PRs welcome.

Closing since this clearly is not priority for anyone.


Fix Prettier issues

Closes #7.
modicon.xml has been changed manually before applying Prettier:
$ prettier -w '**/*.{md,xml}'

Better to merge this one after #6. Ideally, we need to rebase this branch after merging #6, so we could check this PR against CI as well.

Force-pushed to rebase.


Enable USB Sharing for guest OS running under Apple Virtualization

I am running Debian 12 guest OS with Ventura running on Mac M2 silicon. Because I need Rosetta to run some amd64 apps, I have to use Apple Virtualization. However, presently USB sharing isn't available under Apple Virtualization in UTM. This is something I could immediately use. It would be a valuable enhancement.
If there are any workarounds that still allow me to use Rosetta in the guest OS, I'd be happy to know about them.

I think this is duplicate of #3778
Apple Virtualization uses the Virtualization.framework which currently does not support USB passthrough unfortunately.
QEMU uses Hypervisor framework so it does allow USB sharing. For now that's the only option to get USB devices working with VM.

Duplicate of #3778


fix: aliased internal modules that look like core modules

What
Posting this PR a little prematurely to get feedback. Added a couple commented-out tests to show the issue. I think this could be merged as-is, but I'd prefer to sort out the resolver behavior first for consistency.
Update isBuiltIn to return false if a path is returned from a resolver.
Previously an alias like 'constants/foo' would be classified as a builtin rather than internal since 'constants' is a core module of node. Fixes one of the issues mentioned in #1034.
Example
project
└── src
    └── constants
        └── index.js

{
  "settings": {
    "import/resolver": {
      "node": {
        "paths": ["/project/src"]
      }
    }
  }
}

Result:
// BEFORE
import { FOO } from 'constants/index'
import { isObject } from 'lodash'

// AFTER
import { isObject } from 'lodash'
import { FOO } from 'constants/index'

Coverage remained the same at 97.317% when pulling 533179590f1d93ceff71f8f84feea5a08f2db138 on echenley:ech/fix-isBuiltIn-local-aliases into 651829d6a2862b8fa2e33426421a5dba526e4cdb on benmosher:master.

When will this PR be merged?
I am waiting for this PR to be merged. :sob::sob::sob:


CB-7836: Configure Azure client to create V2 type storage account

See detailed description in the commit message.

retest this please


www.bingapis.com shouldn't be blocked

Pack Name: Unified

Domain(s):
www.bingapis.com

Your Config:

Client: Pi-hole
Version: 21.02.040

Details:
I don't see any reason for it to be blocked. WhatsApp group profile image web search also stops working.

Fixed.


ComboBox width

Sets the ComboBox width to be approximately the width of the 7/8ths-percentile  option description. The goal is to have at least 7 out of every 8 option descriptions not have to be line-wrapped on average.
I think this goes by bytes, not by chars or grapheme clusters, and certainly not by precise rendered width of anything, but if that kind of unicode weirdness only affects less than 1/8th of the option descriptions, I hope this is a good enough approximation.

Can you attach some screenshots of the situation before / after?

When I first opened this PR last year, most of my choice options were line-wrapped onto multiple lines. I made this PR and started using it myself instead of master, so I hadn't noticed, the problem seems to be fixed now. I went to make a screenshot of "before" and it seems fine:

I can close this PR now.


Build as previous noarch build failed in CI

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Fix #5

Mainly interested in this as it's a dep of https://github.com/conda-forge/unittest2-feedstock/blob/main/recipe/meta.yaml

@pmlandwehr @anguslees this is ready for review/merge. Thanks!

@conda-forge/core apologies to bother, but the maintainers of this feedstock do not seem to be active anymore. I added myself as a maintainer. It would be great if you could review/merge this PR. Many thanks!


[feature-request] Asciidoctor

Hi.
Are there any plans to support Asciidoctor syntax, just like markdown is supported now?
Thanks!

pug is using a high level transformer API via https://www.npmjs.com/package/jstransformer ; you can easily implement a transformer for asciidoc ; check for example https://www.npmjs.com/package/jstransformer-markdown


java.lang.IllegalArgumentException: Invalid params response from Beacon Node API

Description
I'm using Infura Eth2 API as a Beacon Node with --beacon-node-api-endpoint
Error Message
2022-04-25 22:46:47.406+00:00 | validator-async-4 | ERROR | RetryingDutyLoader | Failed to request validator duties for epoch 114852. Retrying after delay.
java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Invalid params response from Beacon Node API (url = https://eth2-beacon-mainnet.infura.io/eth/v1/validator/duties/attester/114852)
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:331) ~[?:?]
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:346) ~[?:?]
at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:632) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) ~[?:?]
at tech.pegasys.teku.infrastructure.async.SafeFuture.lambda$propagateResult$3(SafeFuture.java:145) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859) ~[?:?]
at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:883) ~[?:?]
at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2251) ~[?:?]
at tech.pegasys.teku.infrastructure.async.SafeFuture.whenComplete(SafeFuture.java:536) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.whenComplete(SafeFuture.java:32) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.propagateResult(SafeFuture.java:142) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.lambda$exceptionallyCompose$27(SafeFuture.java:367) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859) ~[?:?]
at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) ~[?:?]
at tech.pegasys.teku.infrastructure.async.SafeFuture.lambda$propagateResult$3(SafeFuture.java:145) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859) ~[?:?]
at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:883) ~[?:?]
at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2251) ~[?:?]
at tech.pegasys.teku.infrastructure.async.SafeFuture.whenComplete(SafeFuture.java:536) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.whenComplete(SafeFuture.java:32) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.propagateResult(SafeFuture.java:142) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.propagateTo(SafeFuture.java:264) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.ScheduledExecutorAsyncRunner.lambda$createRunnableForAction$1(ScheduledExecutorAsyncRunner.java:119) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: java.lang.IllegalArgumentException: Invalid params response from Beacon Node API (url = https://eth2-beacon-mainnet.infura.io/eth/v1/validator/duties/attester/114852)
at tech.pegasys.teku.validator.remote.apiclient.ResponseHandler.defaultBadRequestHandler(ResponseHandler.java:113) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.apiclient.ResponseHandler.handleResponse(ResponseHandler.java:72) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.apiclient.OkHttpValidatorRestApiClient.executeCall(OkHttpValidatorRestApiClient.java:404) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.apiclient.OkHttpValidatorRestApiClient.post(OkHttpValidatorRestApiClient.java:375) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.apiclient.OkHttpValidatorRestApiClient.getAttestationDuties(OkHttpValidatorRestApiClient.java:142) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.RemoteValidatorApiHandler.lambda$getAttestationDuties$7(RemoteValidatorApiHandler.java:164) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.of(SafeFuture.java:81) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.RemoteValidatorApiHandler.sendRequest(RemoteValidatorApiHandler.java:453) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.validator.remote.RemoteValidatorApiHandler.lambda$sendRequest$38(RemoteValidatorApiHandler.java:448) ~[teku-validator-remote-22.4.0.jar:22.4.0]
at tech.pegasys.teku.infrastructure.async.SafeFuture.of(SafeFuture.java:73) ~[teku-infrastructure-async-22.4.0.jar:22.4.0]
... 4 more
Frequency: About 50% of attestations are missed or failed.
Versions (Add all that apply)

Software version: teku/v22.4.0/linux-x86_64/-ubuntu-openjdk64bitservervm-java-11
Java version: openjdk <IP_ADDRESS> 2022-02-08
OS Name & Version: Ubuntu 20.04.4 LTS
Docker Version: -no-
Cloud VM, type, size: AWS 2GB ram, 1 vCPU, 60GB SSD

hmm, this could happen for quite a range of reasons.  The first thing to check though is that your validator client clock is in sync.
In general I would recommend against using Infura as a beacon node - the performance of a remote beacon node is always less than a local one because of the latency involved. In the future it will become even worse or even impossible to use Infura as a beacon node, particularly once proof of execution semantics are added to the protocol.
In the mean time though to diagnose this further we probably need to get some debug logs to get more detail on why the request is being rejected.  Can you try running with --logging debug please? It will generate quite a lot of log output so you may want to remove the option again once you've captured a few requests that are rejected like this.

I'm going to close this one as we don't have sufficient information to facilitate investigation.  If you're able to check the validator clock and grab the debug logs mentioned above please feel free to reopen.

I agree with you that It's not a good idea to use Infura as beacon node
same as your reason.
After I submitted this issue, I switched to Lighthouse. Firstly, it was
still unstable. Keep missing some attestations. Some, not all. Then I
run beacon node locally, starting with checkpoint-sync with Infura's
beacon node service. Then everything works together.
Still thank you for your reply.
On May 4, 2022, GitHub @.***> wrote:

Closed #5384 https://github.com/ConsenSys/teku/issues/5384.

—
Reply to this email directly, view it on GitHub
https://github.com/ConsenSys/teku/issues/5384#event-6545283977, or
unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAAJUMUNXAGTZOE72WBHCLDVIHCAHANCNFSM5UKH2ZJQ>.
You are receiving this because you authored the thread.Message ID:
@.***>


updated put endpoint

updated put endpoint
https://companieshouse.atlassian.net/browse/IDVA5-861
Type of change

[ x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


cyw43: Detect disassociation from infra.

It would be nice(also internally), to have a way, to detect, if we disassociated from the WiFi we were previously connected to. Be it due to signal loss or some other interference.

I also see problems when disassociated from a WIFI connection. Is there a workaround to reconnect. Where can I query if the connection still persists?

FYI: The way we solved it in tinygo was looking for a LINK packet with zero flag to indicate a disassociation had happened and then waiting for a JOIN packet to indicate it had succesfully reconnected.


Add support for PFCOUNT command

Add support for the PFCOUNT command in DiceDB similar to the PFCOUNT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up.
Thanks

@AshwinKul28 I can pick this up?

Addressed as part of https://github.com/DiceDB/dice/pull/422

@JyotinderSingh we can close this issue as implemented as part of PR here.


feat: tracers provided by the API become useable when provider registered

This is important to fix the load order issue as it relates to plugin setup. Currently, plugins can't be set up until after the tracer provider is created, and creating the tracer provider starts the resource detectors. If a resource detector like GCP uses a module that needs to be instrumented, the plugin may not be able to instrument it if it is loaded after the resource detectors run.
After this PR, plugins can be set up before the tracer provider. When they are constructed, they will acquire Proxy Tracers from the API. Then, when the tracer provider is registered, those proxy tracers become fully useable without the plugin having to acquire a new tracer.

I'm missing the whole picture, how the new proxy classes should be used outside of api. I checked the draft for new base plugin and they are not used there, is this still in progress ? If exporting them is intentional where are they going to be used yet and how? thx

The basic idea is that if a library has built-in instrumentation, we will not have as much control over load order. We might have the case where a library is required and it calls getTracer before the SDK is initialized. In that case, the tracer the library has acquired will become useable when the SDK is registered without that library having to call getTracer again.

@dyladan it could be merged once you resolve the conflicts

Build still needs to be fixed


Oidc key discovery support

Adding support for validating JWTs from OAuth2 providers using OIDC key discovery.
Description
A very popular way of getting JWTs to authenticate users are to get them from OAuth2 providers, and many use OIDC these days. OIDC is a protocol to discover the public signing keys for a JWT so that they can rotate/remove signing keys should they become compromised. This update extends the validation key getter methods to do this key discovery, per the instructions from the root package.
Motivation and Context
Allows JWTs issued by OAuth2 providers that use OIDC to be used and validated by Flagr.
How Has This Been Tested?
I have tested this using Azure Active Directory issued JWTs, and with Okta, a very popular OAuth2 provider used by companies to internally lock down access.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. (I'm unsure about this, I'm relatively new to Go)
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes. (I'm not sure how to unit test this since any statically created JWT would have it's signing key potentially removed over time)
[x] All new and existing tests passed.

I appreciate the comments, go's not my primary language. I considered using the package that you provided, but ultimately all I wanted was the verify part since Flagr's only validating a token's signing, not performing its own sign in flows.


Update firrtl to 1.3-20200227-SNAPSHOT

Updates edu.berkeley.cs:firrtl from 1.3-SNAPSHOT to 1.3-20200227-SNAPSHOT.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "edu.berkeley.cs", artifactId = "firrtl" } ]

labels: library-update

Nope. We don't want robots updating our managed versions.


Add QTc Calculator

IMCG will provide equations

The revisions to the AAD guidelines were approved on Friday at P&T. We will be moving to a manual QTc calculation process for new start dofetilide/sotalol with the following parameters:

If AF, pharmacist would enter longest and shortest QT intervals from EKG and calculator would produce an average of these values
If QRS > 120 msec, calculator would use modified Bogossian formula first and then apply the correct calculator based on HR)
If QRS < 120 msec, calculator would select calculator based on HR

If HR < 50, would use Fridericia formula
If HR 50-70, would use Bazett formula
If HR > 70, would use Framingham formula

Here are the formulas:
$$RR=\frac{60}{HR}$$
Bazett: $$QT_c=\frac{QT_{a*}}{\sqrt{RR}}$$
Fridericia: $$QT_c=\frac{QT_{a*}}{\sqrt[3]{RR}}$$
Framingham: $$QT_c=QT_{a*}+0.154(1-RR)$$
$$QT_{a*}$$ is the QT interval from the EKG, unless QRS > 120, then it's adjusted using the modified Bogossian formula
Modified Bogossian: $$QT_{a*}=QT-0.5(\mathrm{QRS\ duration})$$
flowchart TD
    C{Atrial Fibrillation?}
    C ------>|Yes| D[Average of
longest and shortest
QT from EKG]:::gray
    C -->|No| A{QRS?}
    A -->|>120 msec| I[/Correct QT using
Modified Bogossian/]:::calc
    I --> E
    A -->|<120 msec| E{Heart Rate?}
    E --->|< 50| F[Fridericia
formula]:::gray
    E --->|50-70| G[Bazett
formula]:::gray
    E --->|>70| H[Framingham
formula]:::gray

    classDef gray fill:#dedede,stroke:#333
    classDef calc fill:#FFE5B4,stroke:#FFA500

Correction
For AF scenarios, the average of the QT values should then get plugged into the correct calculator for HR (Fridericia, Bazett, or Framingham) to give the QTc. Otherwise, everything looks good to me initially. I will work on validating the calculator. I agree with the QRS > 120 msec cut-off for Bogossian correction.
flowchart LR
    AF[A fib?]:::gray
    AF -->|No| QRS1[QRS?]:::gray
    AF -->|Yes|QRS2[QRS?]:::gray

    QRS1 -->|<120 msec| NL
    NL[Use QT from EKG]:::start --> HR
    QRS1 -->|≥120 msec| NH
    NH[Correct QT using Mod. Bogossian]:::blue --> HR
    QRS2 -->|<120 msec| YL
    YL[Use average highest & lowest QT from EKG]:::calc --> HR
    QRS2 -->|≥120 msec| YH
    YH[Average highest & lowest QT from EKG;
Correct QT using Mod. Bogossian]:::green --> HR
    HR[Determine which
formula to use]:::gray -->|HR < 50| F[use Fridericia formula]
    HR -->|HR 50-70| G[use Bazett formula]
    HR -->|HR >70| H[use Framingham formula]

    classDef gray fill:#dedede,stroke:#333
    classDef calc fill:#FFE5B4,stroke:#FFA500
    classDef start fill:#a9e695,stroke:#2e691a
    classDef blue fill:#95dcfa,stroke:#1D7EA8
    classDef green fill:#d5f291,stroke:#63870e


fix(p2p): refine chain exchange peer selection logic

Summary of changes

(Part of https://github.com/ChainSafe/forest/issues/4346 investigation)
This PR refines the logic of determining remote peers to send chain exchange requests to, (aka full peers)
Changes introduced in this pull request:

treat a peer as a full peer only when its head information presents
filter out stateless peers whose head epoch is 0 from chain exchange targets
some minor refactoring in peer manager

Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 I removed this from queue so that you get the time to read my comments. If you think it's good as is - go forward and merge it.


skin apply issues

how to apply roblox skin
The Blox Strap says to apply a skin, but I'm not sure.
I would appreciate it if you could let me know

Can you please give us more information?
What do you mean by apply roblox skin?

What

What are you talking about? Where on earth is it saying that?

What are you talking about? Where on earth is it saying that?

Maybe hes talking about mods?


repeat pointer offset address in _blocksparse_softmax_fwd kernel

I don't understand why triton wrote this code in _blocksparse_softmax_fwd kernel?

becasue lane_n = tl.arange(0, ROW_SIZE) % BLOCK_SIZE, and this would lead lane_n become a repeate sequence whose max value is BLOCK_SIZE - 1, furtherly, this would lead different threads write different value to the same address, and I think it is out of control.
Dose anybody know why？

@ptillet need some help in this issue


[Request-For-External] Table 77 "Report Selections" - Procedure DrillDownToSelectLayout from Internal to Global

Describe the request
Can the procedure DrillDownToSelectLayout please be set from internal to global.
table 77 "Report Selections"
 procedure DrillDownToSelectLayout(var SelectedLayoutName: Text[250]; var SelectedLayoutAppID: Guid)
Additional context
We would like to use this functionality in our own report selection pages.
Internal work item: AB#535529

We have duplicated the purchasing and sales documents for our own modules. In these documents, reports independent of the standard should be called up. The report selection has therefore also been duplicated. In order to be able to use the new functionality in our report selections as well, we need it as a global procedure.


Add fit_transform to BaseTransformer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0dc639e) to head (c8d0136).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           38        38
  Lines          992       994    +2
  Branches        40        40
=========================================
+ Hits           992       994    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(deadline): Adds option to the RenderQueue to use cachefilesd

Implements: https://github.com/aws/aws-rfdk/issues/366
Testing
Started up a basic render farm using the RFDK examples, but modified the example to set the fsc mount option on the Amazon EFS and enable cachefilesd on the RenderQueue.
Used systems manager connection to remote in to the RenderQueue's ECS container host, and then:

Verified that cachefilesd is installed and running.
Verified that the /mnt/repo filesystem was mounted using the EFS helper which in-turn uses the NFSv4 mount driver, and that the fsc option was properly set on the NFSv4 mount point.

[root@ip-10-0-126-223 ~]# mount | grep nfs
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime)
<IP_ADDRESS>:/ on /mnt/repo type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,hard,noresvport,proto=tcp,port=20312,timeo=600,retrans=2,sec=sys,clientaddr=<IP_ADDRESS>,fsc,local_lock=none,addr=<IP_ADDRESS>,_netdev)

Ran a series of full copies of the /mnt/repo filesystem (approx 1.3 GB of data) to the local device both with and without cachefilesd running. The image below shows the throughput metrics on the Amazon EFS filesystem through these tests; as expected, the read throughput with cachefilesd is much lower than a full copy once the local cache has been populated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Looks great! My only concern is with the namespace for this option and underlying function names being generic as it has the following two effects:

Those aware of cachefilesd have to check the docs to know what the underlying tech is
If we find an even better caching option or choose to change the Repo's backing protocol (say to SMB) we'll have problems.

Maybe we could swap "enable_local_file_caching" for "enable_fsc_caching"?

Looks great! My only concern is with the namespace for this option and underlying function names being generic as it has the following two effects:
1. Those aware of cachefilesd have to check the docs to know what the underlying tech is

2. If we find an _even better_ caching option or choose to change the Repo's backing protocol (say to SMB) we'll have problems.

Maybe we could swap "enable_local_file_caching" for "enable_fsc_caching", etc?

Thanks for the feedback, Edwin. Variable/property naming is hard. ;-) On one hand... generic for those that don't know the details, or don't want to know/care... On the other hand... it is nice to know what is going on under the hood. I'm trying to strike that balance by going generic with the property name and providing details in the docstring (which shows up under quick-info-type IDE functionality). My thinking is also that if there's a different caching tech for a different filesystem, then we'd want to support that under the same option but detect the filesystem type if we can; it's all the same high-level functionality, regardless of how it's accomplished.
You're thinking that I'm missing the mark with it?


Tri grpc compatibility 3.2

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11544 (5647581) into 3.2 (8ca10c8) will decrease coverage by 4.85%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##                3.2   #11544      +/-   ##
============================================
- Coverage     69.73%   64.89%   -4.85%
+ Complexity      133       14     -119
============================================
  Files          1561     1505      -56
  Lines         83705    62605   -21100
  Branches      14915     9140    -5775
============================================
- Hits          58370    40625   -17745
+ Misses        20442    17764    -2678
+ Partials       4893     4216     -677

Impacted Files
Coverage Δ

...rg/apache/dubbo/rpc/protocol/tri/GrpcProtocol.java
0.00% <0.00%> (ø)

...ache/dubbo/rpc/protocol/tri/GrpcHttp2Protocol.java
100.00% <100.00%> (ø)

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../serialize/hessian2/Hessian2SerializerFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...istrycenter/processor/FindPidWindowsProcessor.java
5.40% <0.00%> (-81.09%)
:arrow_down:

... and 493 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How can I use factory for Azure

Can i use
$client = OpenAI::factory()     ->withBaseUri('{your-resource-name}.openai.azure.com/openai/deployments/{deployment-id}')     ->withHttpHeader('api-key', '{your-api-key}')     ->withQueryParam('api-version', '{version}')     ->make();
for Azure as described here?
I don't know exactly how to implement this with OpenAI PHP for Laravel.

Hi @DC-Sebastian
One way is to override the singleton in your service provider:
$this->app->singleton(ClientContract::class, static function (): Client {
    $apiKey = config('openai.api_key');

    if (! is_string($apiKey)) {
        throw ApiKeyIsMissing::create();
    }

    return OpenAI::factory()
        ->withBaseUri('{your-resource-name}.openai.azure.com/openai/deployments/{deployment-id}')
        ->withHttpHeader('api-key', '{your-api-key}')
        ->withQueryParam('api-version', '{version}')
        ->withHttpClient(new \GuzzleHttp\Client(['timeout' => config('openai.request_timeout', 30)]))
        ->make();
});

Here is the original implementation from the package provided.
https://github.com/openai-php/laravel/blob/main/src/ServiceProvider.php#L24
Hope this helps.

If extending the client contract, it's preferrable to use extend over singleton:
Below is a working example of an Azure OpenAI contract override:
        $this->app->extend(ClientContract::class, static function (): OpenAIClient {
            $apiKey = config('openai.api_key');
            $resourceName = config('openai.azure.resource_name');
            $deploymentId = config('openai.azure.deployment_id');
            $version = config('openai.azure.version');

            if (! is_string($apiKey)) {
                throw ApiKeyIsMissing::create();
            }

            return OpenAI::factory()
                ->withBaseUri(sprintf('%s.openai.azure.com/openai/deployments/%s/', $resourceName, $deploymentId))
                ->withHttpHeader('api-key', $apiKey)
                ->withQueryParam('api-version', $version)
                ->withHttpClient(new HttpClient(['timeout' => config('openai.request_timeout', 30)]))
                ->make();
        });

Ensure that you put in the correct details down to the api-version otherwise, you'll get a Resource not found error.


Add admin interface for reindexing a project search

Related issue - #4654

[x] On Project admin, a command that reindexes all active versions (project queryset and all attached active versions)
[x] On Version admin, a command that reindexes by version queryset instead
[ ] ~Drop management command, these aren't good interfaces for site admins and are mostly hidden~
[x] The management command seems to just do all versions active or not, we should probably test for active versions instead.
[x] There should also be an admin function to wipe the index for a version and for a project

This PR is in very initial phase.
I have just used the management command from admin interface.
Work is in progress.

I think we should keep the management command because it is used in these tests
    readthedocs.org/readthedocs/search/tests/test_views.py

Are the tests required for admin functions also?

@agjohnson
I don't know how to write the tests relating about elastic search.
Can you please give me some advice on this.

@ericholscher
Can this issue waits for sometime? I am learning elasticsearch (completed one udemy course and read the docs of elastic.... But it's not enough yet) and would love to try this again in a few days.
Also, I am looking forward to add "Auto-complete feature for search" in RTD.

Closing this.
#5343


Fix issue #15269

A possible solution to fix issue #15269.

Can one of the admins verify this patch?

@adamcavendish could you sign the CLA?

I signed it!

@drpngx Thx for reminding me of that

Jenkins, test this please.

I'm afraid of this, especially given how unpredictable the variable_scope reuse behavior is. @fchollet  @lukaszkaiser do you have a good enough understanding of this to be confident this does not break things in some obscure way? See more discussion on the issue #15269.

Thanks for the PR!
@martinwicke I don't know, but let's find out.
@adamcavendish without new unit tests, it is impossible to assess the effect of the fix or whether it does fix the issue. Please add a series of unit tests that assert that the new behavior is the one we expect (see discussion). These should be tests that would have been previously failing and would now be passing.

I second @fchollet : let's first add tests to make clear what's happening.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

My comment is still valid and has not been acted on:
"without new unit tests, it is impossible to assess the effect of the fix or whether it does fix the issue. Please add a series of unit tests that assert that the new behavior is the one we expect (see discussion). These should be tests that would have been previously failing and would now be passing."
Since it has been a while, I consider the PR abandoned and I will close the PR. Feel free to reopen later, with unit tests.


Test/modify procedures

:tada: This PR is included in version 2.0.1-beta.71 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Considering a first-class primitive type?

Strings and numbers aren't usually ideal since they don't have the formal typing semantics you usually want from enums.
Symbols work well in having the correct uniqueness property, so form a good recommended "default" for an enum.
The problem is that if you have a symbol of this type, you don't know at a runtime level that it comes from an enum, which enum set it comes from etc etc.
So I was wondering if it's worth considering a first-class primitive type for enumvalue say, which could behave like a symbol, but potentially have some extra features, including:

The ability to get the enum from the value, for example enum X { A, B } supporting some X.A.enum === X
The ability to have helper methods like is: X.A.is(X.A) === true, while X.A.is(X.B) === false
ADT unwrapping - enum X { A(), B } to support X.A(10).unwrap() === 10
ADT equality support (eg enum X { A(), B } could be defined to have Enum.A(5) === Enum.A(5) via the union of equality on its members)

Overall the code style might be closer to what users expect in imperatively operating on enum and ADT enum values.
For example consider the standard case of a Result type supporting simple is checks and unwrap:
enum Result {
  Ok(),
  Err()
}

const res = operation();
console.log(typeof res); // enumvalue
if (res.is(Result.Ok)) {
  return res.unwrap();
} else if (res.is(Result.Err)) {
  return res.unwrap();
}

I understand pattern matching also plays a large role here, but having imperative forms also seems useful. Alternatively a lot of these cases could also be handled with the original enum I suppose, but at least being able to get the enum class from the enum value is a useful feature we might not otherwise have.

In the earliest version of https://github.com/rbuckton/proposal-enum I planned to introduce a new typeof tag. However, plenary discussions related to Records and Tuples indicate that most implementers would rather avoid new primitive types due to the high implementation cost. As a result, https://github.com/rbuckton/proposal-enum moved to instead leverage existing primitive types and regular JS objects instead, which also happens to align more closely to the current emit for enums in TypeScript.

However, plenary discussions related to Records and Tuples indicate that most implementers would rather avoid new primitive types due to the high implementation cost.

Agree, it's looks not likely to add a new primitive type although it would be useful.

for example enum X { A, B } supporting some X.A.enum === X

This is useful but problematic when it is primitive. In JavaScript today, primitives are re-wrapped in each Realm. What will happen when you send X.A to another Realm? It looks like we need to "reconstruct" the enum like it is a built-in primitive constructor (like Boolean or Number) to make X.A.enum work.

X.A(10).unwrap() === 10

This reminds me of the Box in the R&T proposal. I think ADT can be a normal data property like { type: X.A.symbol, value: [10] }.

Enum.A(5) === Enum.A(5)

Implementers look like rejecting this idea (based on what happened to the R&T proposal)...

I still don't get why new primitive type would cause high cost (my impression is engine delegates said new primitive types would have performance penalty in === operations but I don't understand the reasons).
I also have a question about symbol, could shared struct allow to share symbols? It seems structured clone don't allow symbols.

I also don't understand it, but since all the browsers are in agreement, there will be no new primitive types unless they change their minds.
I suspect sharing identity would be a problem, and non-global symbols have identity.


Communication: Add emoji support to messages

Checklist
General

[X] I tested all changes and their related features with all corresponding user types on a test server.
[X] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[X] I chose a title conforming to the naming conventions for pull requests.

Client

[X] I strictly followed the client coding and design guidelines.
[X] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[X] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[X] I documented the TypeScript code using JSDoc style.
[X] I added multiple screenshots/screencasts of my UI changes.
[X] I translated all newly inserted strings into English and German.

Motivation and Context

Users currently cannot select and send emojis, limiting their expressive options in messages.
Description

Added an emoji button that opens an emoji picker, allowing users to select and send emojis in their messages.
Emojis now automatically convert as user types —for instance, ":)" changes to 🙂.

Steps for Testing

Prerequisites:

1 Instructor/Student
1 Course with Communication enabled

Log in to Artemis
Navigate to Communication section of a course
Open a random channel to send a message
Notice the emoji button on the input area, click on it to open the emoji picker
Select an emoji and send it to see it on the conversation.
Try automatic conversion: type something such as ":)", ":/", or ":D" and see their emoji versions on the input area.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

[x] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[ ] Test 2

Test Coverage

Screenshots

Summary by CodeRabbit
Release Notes

New Features

Introduced emoji insertion functionality in the markdown editor, allowing users to enhance their text with emojis.
Updated button actions for improved handling of user interactions.
Enhanced text handling capabilities to automatically convert emoticons to emojis.
Added support for emoji localization in both English and German language files.

Bug Fixes

Improved emoji picker display and interaction handling within the editor.

Tests

Expanded test coverage for the new emoji functionality, ensuring proper integration and behavior within the editor.

I added automatic conversion feature today. Now the characters such as ":)" turn into an emojis. I would appricate your reviews :)

I have tested this feature as an instructor on TS 4, everything works well in general and also exercise side, but this feature is not yet available on direct messages, it would be great to extend this feature to direct message section. And also a shortcut to a thumbs up emoji would be great as well as it is one of the commonly used emoji.

Thumbs up emoji shortcut already exists, you can test it with ":+1"
Are you sure about direct messages? I have just tested it on TS5 and I can send emojis:

It has been decided that the emoji panel should close after an emoji is selected. I would appreciate it if you could review it again with this in mind. :)


Virtual tab is not visible in table properties in Custom view

System information:

Operating system (distribution) and version Win10
DBeaver version 7.3.3 EA

Connection specification:

Database name and version MySQL

Steps to reproduce, if exist:
Select in MySQL context menu Connection view>Custom>Show system objects/Show utility objects
Expected: all properties tabs remain visible
Actua result: Virtual tab is not displayed

Additional question:.
Is it expected that  Connection view>Custom>Show only tables and Hide folders have different properties view?
Show only schemas and tables

Hide folders

About question - tool-tips are very helpful, I think

not reproducible anymore


Find GDAL and Proj data files

xref
We need to add logic similar to that used in Fiona to find GDAL and Proj data files, including those that are included in wheels.
This should probably be added to the _env.py::GDALEnv class
Revision: this at least partially requires GDAL C API calls to set GDAL_DATA as a config option and Proj data path via OSRSetPROJSearchPaths(), so this can't happen in GDALEnv.  Instead, it needs to be implemented within Cython and be called inside the with GDALEnv() block in core.py.

Resolved by #52


Intermittently unable to exit pager after git log

Windows Terminal version
1.19.240130002
Windows build number
10.0.22631.0
Other Software
No response
Steps to reproduce

create  a git repo
make about 50 commits so the git log needs to use pager
mkdir winterm-pager-repro; cd winterm-pager-repro; invoke-expression 'git init'; for($i = 0; $i -le 50; $i++) { echo 'abc' >> testfile.txt;  invoke-expression 'git add .'; invoke-expression "git commit -m "test commit $i"'; }
run 'git log' on the repo. make sure the pager is invoked and you have an option to enter q to exit pager and get back to prompt. please try this  10-15 times. this doesnt happen consistently but its happens consistently when tried multiple times.
if reproed, after entering 'q', the ':' at the end of page disappears, cursor continues to blink, but prompt wont be available. you will need to open a new tab or instance to continue.

Expected Behavior
upon hitting 'q', pager should exit and I should be back on the command prompt.
Actual Behavior
upon hitting 'q' to exit pager, command prompt doesn't reappear. only option is to open a new tab/instance.
in the image below, I should be able to hit q and get back to the prompt

when i hit 'q', the terminal gets stuck. there cursor continues to blink (not captured in screenshot below) but terminal doesnt respond to any key press. it is not frozen because i can select text with my mouse, close/open new tabs.

Few things I have tried to isolate the issue:

ran powershell without my profile and without loading any other module besides ps-readline, the issue still happens

#14288 sounds familiar, but we thought we fixed that a while back. Weird. Are you resizing at all in that process?

I have this issue happen to me often multiple times per day, and it's not just git log, but also git diff when it uses the pager. For the longest time I've suspected it might be a bug with Clink and Terminals used together, but I don't have any evidence to point to it conclusively. If this issue occurs, would a process dump of Terminals and/or Git and the pager (less) have any value to help debug it?

I got same problems. Any update on this?


issue_30_logging

Add diagnostic logging within SwarmDiscoveryUtil.discoverContainersViaCriteria() as a means to resolving Issue #30 ("NPE at SwarmMemberAddressProvider line 237").

Have you tested your built jar in your application that is having issues? I'd like to avoid doing release after release just for logging information until your problem is determined.

No.
I am unable to deploy code into our Swarm except by building the product with artefacts from maven and jcenter.
I have, however, reviewed the output this logging generates in the Travis CI build.  Extracts of those are appended as a comment to Issue #30.

If you already have access to your maven's build file, then you should be able to do something like this
<dependency>
    <groupId>com.sample</groupId>
    <artifactId>sample</artifactId>
    <version>1.0</version>
    <scope>system</scope>
    <systemPath>${project.basedir}/src/main/resources/yourJar.jar</systemPath>
</dependency>

My organisation does not run its own maven repo and, although I own entirely the application and its stack, I have only limited visibility to Jenkins and no access other than log visibility in the deployed test environments.
It would be great if I was set up to run a local daily Coker swarm, but no one in my team can do so at this stage.
Also, since our use-case warranted functional commits in RC11 I expect you guys would be eager to see positive results from such usage.
I am as high up as it gets in our organization’s Java team; whilst I do look to further improve our processes there are significant limits to what I can achieve in the next six or so hours.


Add support for parameter matched ports in URL mappings

Problem
Hathora cannot be used with Discord Activities unfortunately. Discord Activities requires every outbound connection from your client application to go through a Discord proxy (discordsays.com) where you map endpoints to their respective URLs. The endpoint mapping does not support ports other than the standard 80 and 443 and all Hathora edge services such as ping endpoints and the actual game rooms require specific ports to be used. An example URL for a game room looks like this: wss://86d96a.edge.hathora.dev:51738 where both subdomain and port can change frequently.
Proposed solution
Allow URL mapping targets to support port as well as hostname. The port should also support parameter matching for this to work.
Example:

I believe you can already add a port to the URL mapping!

It did not work for me, and their docs explain why here: https://discord.com/developers/docs/activities/development-guides#activity-proxy-considerations

You can use these ports: https://developers.cloudflare.com/fundamentals/reference/network-ports/#network-ports-compatible-with-cloudflares-proxy

You can use these ports: https://developers.cloudflare.com/fundamentals/reference/network-ports/#network-ports-compatible-with-cloudflares-proxy

That does not resolve this issue unfortunately. Hathora uses more than 6 different ports and none of them are on that list.

Our docs actually link to the wrong docs in cloudflare. The correct docs are here:
https://developers.cloudflare.com/rules/origin-rules/features/#destination-port, which states that all ports are allowed. however, there does seem to be a problem here. we're investigating further.

@devsnek any updates on the investigation you can share by chance? I'm super eager to get my game integrated as an activity and this is really my only blocker.

I am also having this issue, but with sub-domains! I dynamically generate new subdomains on my base domain for each kubernetes node added to a cluster. Without the ability to add parameters, I will have to write some code to constantly call the discord developer apis to update the URL mapping list, which seems like a bad idea.

I am also having this issue, but with sub-domains! I dynamically generate new subdomains on my base domain for each kubernetes node added to a cluster. Without the ability to add parameters, I will have to write some code to constantly call the discord developer apis to update the URL mapping list, which seems like a bad idea.

Parameters are already available for subdomains and they do work. They just don't work for ports yet.

Parameters are already available for subdomains and they do work. They just don't work for ports yet.

Just realized that today, not sure how I missed it in the docs. Unfortunately, we still have the same issues with ports as well, but are thinking of using HAProxy as a way to solve it for now

Any updates or guidance?

Unfortunately, this is ultimately a limitation of our proxy today. More info is documented here. We're working with Cloudflare to see what it could take to patch this behavior, but in the meantime (per the suggestion made by @sam-bunger about HAProxy), at the cost of an additional server "jump" you could route traffic to a server you own, i.e.
Request to discord Proxy: wss://1234.discordsays.com/hathora/51738
Maps to your activity at: wss://my-game.com/hathora/51738
Which you could remap: wss://abcd.edge.hathora.dev:51738
This is not ideal, but an extra server for proxying traffic should unblock you.
Again, we're working with Cloudflare to understand a long-term solution to improve this and will make an announcement over in the Discord Developers server in the #api-announcements channel if/when we're able to resolve this.

@matthova Thank you for the update and the potential workaround.
Unfortunately, adding a proxy in front of the Hathora game servers defeats the purpose of using Hathora for its multi-regional capabilities. Hathora is able to spin up a game room in 1 of 11 regions closest to the players. If I set up a proxy it would force players to connect to the proxy in some location that may not be ideal for them at all. The other option would be to setup proxies in front of all 11 regions that Hathora currently supports to maintain that regional support and offer players the best latency possible.
I have also heard mentions of Cloudflare Spectrum, is this something you have looked into?
https://developers.cloudflare.com/spectrum/reference/configuration-options/#ports
Is it possible to keep this issue open as it is still very much an issue that is preventing developers from using Hathora to develop Discord Activities?

Seconding to keep this issue open!


is this lru cache? can u make it lru without ttl feature?

is this lru cache? can u make it lru without ttl feature?

No, this is not an LRU cache, otter uses S3-FIFO as an eviction policy. But I don't really understand why you need LRU specifically, given that S3-FIFO and W-TinyLFU are simply more efficient on any workloads.
Otter already has to work without ttl, moreover, in this configuration it consumes memory as if it does not know how to work with ttl (expiration time and expiration policy will not be stored).

capacity := 10000
cache, err := otter.MustBuilder[int, int](capacity).Build()
if err != nil {
	panic(err)
}
key := 2
value := 3
cache.Set(key, value)
v, ok := cache.Get(key)
if !ok {
	panic("not found key")
}
if v != value {
	panic("not valid value")
}

@maypok86 just learn something new. thx!


packet corrupt

every time i download a movie i get lots of packet corrupt errors and it ends up downloading a file that doesn't open.

This is not a mov-cli issue.

ok


Updated findiff feedstock version to 0.10.0

So, I wrote a recipe for the latest version of findiff (https://github.com/conda-forge/staged-recipes/pull/23768), and then realised this feedstock already existed, so I am proposing an update here instead.
@conda-forge-admin please rerender

I see there are a bunch of other PRs failing for findiff updates. I do not quite understand what is failing, but note that the single-file recipe for version 0.10.0 on https://github.com/conda-forge/staged-recipes/pull/23768 passed all the checks.

Removing the patch (0001-exclude-tests-from-setup.py-for-conda-forge-compatib.patch) and references to it was enough to resolve the previous issues. Version 0.10.0 of findiff doesn't need this patch.

Yes, exactly. In my commits, I think I made 4 changes to lines of code, and removed the patch. The rest is automatic stuff.

@og113 I approved, and it should be good for you to go ahead and merge. Let me know if there's anything else to discuss. Thanks again for taking the lead on this.

@tnigon, thanks! However, I don't have write access to merge pull requests on this repo.

@og113 Ah, that makes sense. I'm not the repo owner, and I don't have control over the settings; but I will go ahead and merge for you! Sorry for the misunderstanding!

@og113 Do you think this branch should be merged with the latest automated PR so that all the checks are run? See all the PRs at: https://github.com/conda-forge/findiff-feedstock/pulls

@conda-forge-admin, please lint

That could be a good idea. Probably the reason the automated ones failed was just the same patch that needed dropping.


install.bash would not add the MySQL file to database

During the installation of the system, running install.bash, failed to add the MySQL data to the database. This is because the password does not seem to set correctly. To install, I had to reset the MySQL password and install it randomly

Hmmm, strange, I just tried it out on 14.04 and 15.04. Maybe the password was entered wrong?


Missing evaluation scores on Robosuite with cross embodiments settings

Hello, @gemcollector,
I have noticed that you have loaded the evaluation scores of most experiments. However, the detailed evaluation scores on Robosuite with cross embodiments settings are not provded, specifically in Figure 9. Could you upload the missing results, please?

I just found the detailed evaluation scores in Figure 8 are also not provided. Could you please upload these as well? I want to compare my method with these algorithms. 👀

Hi there,  I will upload the results in Figure 8 and Figure 9 this week. Please keep checking our repo, thanks!

Hi, I have updated the results. You can check the new results file :)

Thank you very much!


Fix spelling

Codecov Report

Merging #323 (0e0f811) into main (b18f9fb) will decrease coverage by 3.54%.
The diff coverage is 74.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   88.78%   85.24%   -3.54%
==========================================
  Files          52       52
  Lines        5715     5660      -55
  Branches      587      864     +277
==========================================
- Hits         5074     4825     -249
- Misses        513      714     +201
+ Partials      128      121       -7

Impacted Files
Coverage Δ

src/ott/geometry/epsilon_scheduler.py
94.28% <ø> (-0.16%)
:arrow_down:

src/ott/geometry/graph.py
31.87% <ø> (-60.00%)
:arrow_down:

src/ott/geometry/grid.py
91.53% <0.00%> (-0.07%)
:arrow_down:

src/ott/geometry/segment.py
100.00% <ø> (ø)

src/ott/math/fixed_point_loop.py
100.00% <ø> (ø)

src/ott/math/unbalanced_functions.py
100.00% <ø> (ø)

src/ott/problems/linear/linear_problem.py
100.00% <ø> (ø)

src/ott/solvers/linear/discrete_barycenter.py
87.62% <0.00%> (-0.13%)
:arrow_down:

src/ott/solvers/was_solver.py
95.34% <ø> (-0.11%)
:arrow_down:

src/ott/tools/gaussian_mixture/fit_gmm.py
75.60% <0.00%> (ø)

... and 48 more


Update head_custom.html adding google tag

Ive added a snippet of google tag manager that roy required so we have analytics on the dev.trywilco.com

I dont want to use segment snippet but google tag.


removed bourbon, cleaned up CSS, updated to frost-css/frost-theme

#MAJOR# to push this into release version

:thumbsup;


lifecycle-overrides are not supported in kops_cluster_updater

I want to use an existing IAM role
https://github.com/kubernetes/kops/blob/master/docs/iam_roles.md#use-existing-aws-instance-profiles
Can you add support to this flag
     --lifecycle-overrides strings   comma separated list of phase overrides, example: SecurityGroups=Ignore,InternetGateway=ExistsAndWarnIfChanges

I'll look into it, not sure when i will have the time though.

You should be able to achieve the same result using KOPS_LIFECYCLE_OVERRIDES env var https://github.com/kubernetes/kops/blob/b79157ff438733ecbb9bb9b92a9d0e1d1eba4434/cmd/kops/update_cluster.go#L135
Anyway, I think it should be easy to add.

Thanks

v1.23.3 should be available with lifecycle overrides support.


SpecialRoamingOverrideAllowed needed on Server 2019

Is SpecialRoamingOverrideAllowed needed on Server 2019 RDSH (Citrix UPM)?
What does this key do?

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Compute <-> pageserver protocol version 2

This is the same functionality as https://github.com/neondatabase/neon/pull/6718, with a bunch of cleanups and refactoring based on comments there. Main changes:

The new protocol version is now indicated by using pagestream_v2 command when the pagestream is started. The message tags of individual request are unchanged and are the same in both versions (per https://github.com/neondatabase/neon/pull/6718#discussion_r1566913662)
The requests now carry two LSNs: request_lsn and not_modified_since. This is more clear than the concept of a horizon from that previous PR. There are no magic values, a request must provide a valid LSN for both. Lsn::MAX is valid for request_lsn as long as `not_modified_since is a valid value, however. That can be used to fetch the latest version of the page. It's used by some tests, but not by the actual compute. The actual compute always passes a valid LSN for both.
This PR builds on top of  https://github.com/neondatabase/neon/pull/7376. It was awkward to push down both LSNs to all the functions in pgdatadir_mapping.rs, and the old logic for when the relsize cache could be updated depended on the 'latest' flag, so it was easier to refactor it away first.

TODOs:

add a test that demonstrates the original problem that this is designed to fix. That is, a read-only replica that gets "page has been garbage collected away" errors. (per https://github.com/neondatabase/neon/pull/6718#pullrequestreview-1884890827 and https://github.com/neondatabase/neon/pull/6718#pullrequestreview-1998728369)
make the test for old protocol version more clear that it's actually exercising the protocol (https://github.com/neondatabase/neon/pull/6718#discussion_r1565620715)
image-based tests for the backwards-compatibility (per https://github.com/neondatabase/neon/pull/6718#discussion_r1565357977)

If we're going to have a V2 of the protocol, can we then also include headers to the responses that indicate what the response was for? I.e. the bufferdesc for GetPage, the relnode+fork for getRelForkSize, etc.?
Asking, because right now, we don't have any info on which page we receive when we receive GetPageResponse: it is only implicitly known that the page response is for the oldest not-yet-acknowledged GetPageRequest. This means we don't have a good way to detect desynchronized state at the Compute side, and only detect this when we stop requesting new pages and use a different request instead.

Another benefit would be that the pageserver could process the requests and send responses out-of-order. Not sure how much it matters, and for that the client would need some further adjustment.
So that's a good idea, but I'm reluctant to do that right now, as fixing the issue with read-only nodes is quite urgent. It wouldn't be a huge amount of work to add some fields to the requests/responses, but it's work nevertheless.
I'm not too worried about changing the protocol again later, we have a good enough procedure for it now. It takes a while for old computes to expire, but still.

A ping(unique)->pong(same unique) request flow after every getPage would work, too, but it wouldn't allow us to detect the issues as easily, and would potentially consume more bandwidth than just adding the BufferDesc data to the response.

It would have to be BufferDesc + LSN to be unique enough. Note that a BufferDesc is actually pretty wide, a request ID generated with a 64-bit counter for example would actually be smaller.

Added one more test, to demonstrate the original error: https://github.com/neondatabase/neon/pull/7377/commits/34f75f590ca6318a7b82cb08e939877ec28636a8.

Replying to @problame's comment on the original PR:

Please add a test case that demonstrates the problem / regress-tests your solution.

added: https://github.com/neondatabase/neon/commit/34f75f590ca6318a7b82cb08e939877ec28636a8

Also, you are making a breaking change to the protocol.
Please provide a plan to orchestrate the rollout.

Push this PR
Wait for the new storage version to be rolled out everywhere, and for ~ one week to pass so that we are confident that we will not need to roll it back anymore
Change the neon.protocol_version=2 compute option on one region
If no issues, make neon.protocol_version=2 default so that it gets rolled out everywhere

Removing the old version:

Wait for all old computes that are still using protocol version 1 to expire
Remove any neon.protocol_version from all endpoint, project region configs.
Remove the code for protocol version 1 from storage and the neon extension.

A Slack channel (e..g, #proj-page_service-lsn-range-requests ) is probably most appropriate, as this touches multiple components.

We are coordinating this one the #escalation-2024-04-12-tried-to-request-a-page-version-that-was-garbage-coll channel now.


Wrong az command

The Azure CLI command listed below:
To view managed resources at the resource group scope:
Must be 'az stack group show' instead of 'az stack group list'. List is used to show all stacks and doesn't accept the --name parameter.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5f622312-3736-6fad-926d-10fd6124987d
Version Independent ID: d7bb5e0d-f165-0a3d-0db0-862ce839e8c4
Content: Create & deploy deployment stacks in Bicep - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/deployment-stacks.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@sjoerdhooft Thanks for your feedback. The document has been updated by content author. We will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


Update overview "view all..." links

Ensure all overview "view all..." links navigate correctly.
Also omit the "view all" links from the "filtered by OpenShift" overview pages. Only the following overview pages should show links.

OpenShift > All
Infrastructure > AWS
Infrastructure > Azure

https://github.com/project-koku/koku-ui/issues/1406

Codecov Report

Merging #1407 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   77.04%   77.03%   -0.02%
==========================================
  Files         216      216
  Lines        3790     3792       +2
  Branches      661      661
==========================================
+ Hits         2920     2921       +1
- Misses        779      781       +2
+ Partials       91       90       -1

Impacted Files
Coverage Δ

...ages/dashboard/awsDashboard/awsDashboardWidget.tsx
85.00% <ø> (ø)

.../dashboard/azureDashboard/azureDashboardWidget.tsx
85.00% <ø> (ø)

...oard/ocpCloudDashboard/ocpCloudDashboardWidget.tsx
84.21% <ø> (ø)

...ages/dashboard/ocpDashboard/ocpDashboardWidget.tsx
85.00% <ø> (ø)

...oard/awsCloudDashboard/awsCloudDashboardWidgets.ts
100.00% <ø> (ø)

...tore/dashboard/awsDashboard/awsDashboardWidgets.ts
100.00% <ø> (ø)

.../azureCloudDashboard/azureCloudDashboardWidgets.ts
100.00% <ø> (ø)

.../dashboard/azureDashboard/azureDashboardWidgets.ts
100.00% <ø> (ø)

src/store/dashboard/common/dashboardCommon.ts
100.00% <ø> (ø)

...oard/ocpCloudDashboard/ocpCloudDashboardWidgets.ts
100.00% <ø> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9165519...f08b399. Read the comment docs.


Use APIResponsivenessPrometheusSimple in legacy test configs.

Some scalability tests are failing after https://github.com/kubernetes/perf-tests/pull/915 was merged
https://k8s-testgrid.appspot.com/sig-scalability-experiments#storage
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-storage-scalability/1205162963401445380
https://k8s-testgrid.appspot.com/sig-scalability-node#node-throughput
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-node-throughput/1205121688543432710
[measurement call APIResponsiveness - APIResponsiveness error: unknown measurement method APIResponsiveness
measurement call APIResponsiveness - APIResponsiveness error: unknown measurement method APIResponsiveness]

/cc oxddr

/retest

/lgtm
/approve
/hold cancel


[ICON REQUEST]

Describe the icon you'd like to be added
A double check. In Material Icons it is called "done all".
Sample icon

@maxisme Thanks for the suggestion! It's been added to the library.

Amazing, Thank you so much!

Hey, I have noticed this icons height is quite a lot smaller than the rest? Is that on purpose? Thank you

Hi @maxisme! Yes, that is intentional because of the orientation of the icon. I follow a grid system when I built these icons, check out the screenshot below:

There is also a thing called optical alignment. If I start making all icons have the same size, the icons wouldn't be optically aligned. Check out this article https://medium.com/ringcentral-ux/eyeballing-or-optical-alignment-in-design-4ef5ab2d326f

Ahh okay! Makes sense! Thanks


with MPU6050 accelerometer

HI
i want to interface mpu6050 accelerometer with spark fun nano beacon in100,when i configured mpu6050 with nano beacon in Burn program mode,it just advertise a data 0x000000,no proper data received. As i2c is not supported in Run in ram mode, i want to confirm that whether mpu6050 is compatible with in100 or not? or Bosch, MEMS accelerometers(as it shown in git hub) will only support??

Hi Saranya K,
I will be responding to your email directly sent to<EMAIL_ADDRESS>Basically I will be asking for your config file and your schematic. I am currently reviewing the MPU6050 accelerometer to verify if it is compatible with the IN100.

Hi Saranya K,
I will be responding to your email directly sent to<EMAIL_ADDRESS>Basically I will be asking for your config file and your schematic. I am currently reviewing the MPU6050 accelerometer to verify if it is compatible with the IN100.

Hi,
i sent u all the details regarding the configuration,can you provide details regarding the compatability with mpu6050?


PM with non-existing  users

When composing a pm to non-existing user, it can be sent without any tip. Is that right?
Then it will give auto-completion when writing the non-existing user in "You and" text-box:

Woah, that's an interesting new bug; I reproduced it just now.  I'll try to get someone to track this down at the PyCon sprints tomorrow.

@hackerkid can you debug this?  The expected behavior is that trying to send to a username that doesn't exist should give an error in the compose box.  I think it's likely that this is somehow a regression introduced by your refactoring to remove global variables, so that's one possibility to check, but it might be easier to debug by just tracing the code.

@timabbott I am working on this.

@timabbott
I switched back to a very old commit fe77559  and tried to reproduce the issue. I was able to reproduce the bug there too.

The code for validating private_messsages is this
function validate_private_message() {
    if (exports.recipient() === "") {
        compose_error("Please specify at least one recipient", $("#private_message_recipient"));
        return false;
    }

    return true;
}

I am not sure whether there exist some other function to validate whether the PM recipient is valid or not. Am I missing something?

Ahh, OK, I think I understand what's happening here, and I think your'e right this is a very old bug.  The issue is an interaction with our local echo feature, where we display the message as soon as the user hits "send", before we've actually checked with the server that it will send successfully.
Here's a proposed way to fix this:

Add a check in validate_private_message that all of the users in the recipient list are members of the realm (I think you can do this using the data accessed by people.js).  This fixes the bug but creates another problem.
The problem with that approach is Zulip supports limited cross-realm communication, and if we did just that, it would become impossible to compose a message to users/bots in other realms.  Probably the right way to solve this is to have a function that checks whether an invalid recipient is a possible cross-realm recipient.  For now, that function should check whether the recipient is in settings.CROSS_REALM_BOT_EMAILS or settings.ADMIN_DOMAIN (you probably need to send
settings.CROSS_REALM_BOT_EMAILS to the frontend through page_params).

Does that make sense @hackerkid?  Let me know if you have any questions.

(BTW, thanks for doing that investigation -- it was actually very instructive for me as to the nature of the problem)

@timabbott Yeah. I am working on this.

@timabbott If only some recipients are invalid should the message be send to valid users or just report the error?

It should report the error; sending to just the valid users is unlikely to be what the user wants

@timabbott  By settings.ADMIN_DOMAIN do you mean that the message is valid if the recipients email has the the domain as ADMIN_DOMAIN?

Yep.
-Tim Abbott (mobile)
On Jun 8, 2016 11:24 AM, "Vishnu Ks"<EMAIL_ADDRESS>wrote:

@timabbott https://github.com/timabbott By settings.ADMIN_DOMAIN do you
mean that the message is valid if the recipients email has the the domain
as ADMIN_DOMAIN?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/930#issuecomment-224683021, or mute
the thread
https://github.com/notifications/unsubscribe/ACnm2iIQr7IW4cBq8MEDymxqSYztaaEOks5qJwjEgaJpZM4IuSNy
.


How do you make a plugin that interprets frontmatter config?

I'm wanting to do something like:
---
order: 1
title: My Title
forEmployeesOnly: true
# or:
newProperty:
  extraConfig:
    interpret this in a befoerModel hook to guard transitions
---

I have a service that I can use to determine the "employees only" stuff, but the goal is to:

remove from the sidenav (I can do this with an if condition in the template though, as long as the data is there)
prevent visiting that URL via a beforeModel hook check

Does the plugin system allow this?

You don't necessarily need a plugin to accomplish this. All the frontmatter is extracted and kept in the runtime data.
Since you are using the Docfy Ember, you can use the docfy service to find the page you are trying to access, look at the front matter, and then prevent it.
For the sidebar, you also have access to that info, therefore, just an if statement should solve that.
Let's use your example. So, for the sidebar, it might look something like this:
// stuff
{{#each child.pages as |page|}}
  {{#unless page.frontmatter.forEmployeesOnly}}

      <DocfyLink @to={{page.url}}>
        {{page.title}}
      </DocfyLink>

  {{/unless}}
{{/each}}
// stuff

And here how your route could look like:
import Route from '@ember/routing/route';
import { DocfyService } from '@docfy/ember';
import { inject as service } from '@ember/service';
import RouterService from '@ember/routing/router-service';
type Transition = ReturnType<RouterService['transitionTo']>;

export default class Docs extends Route {
  @service router!: RouterService;
  @service docfy!: DocfyService;

  beforeModel(transition: Transition): void {
    const url = this.router.urlFor(transition.to.name);
    const page = this.docfy.findByUrl(url);
    console.log(page?.frontmatter.forEmployeesOnly);
  }
}

I hope this helps.

You don't necessarily need a plugin to accomplish this. All the frontmatter is extracted and kept in the runtime data.
Since you are using the Docfy Ember, you can use the docfy service to find the page you are trying to access, look at the front matter, and then prevent it.
For the sidebar, you also have access to that info, therefore, just an if statement should solve that.
Let's use your example. So, for the sidebar, it might look something like this:
// stuff
{{#each child.pages as |page|}}
  {{#unless page.frontmatter.forEmployeesOnly}}

      <DocfyLink @to={{page.url}}>
        {{page.title}}
      </DocfyLink>

  {{/unless}}
{{/each}}
// stuff

And here how your route could look like:
import Route from '@ember/routing/route';
import { DocfyService } from '@docfy/ember';
import { inject as service } from '@ember/service';
import RouterService from '@ember/routing/router-service';
type Transition = ReturnType<RouterService['transitionTo']>;

export default class Docs extends Route {
  @service router!: RouterService;
  @service docfy!: DocfyService;

  beforeModel(transition: Transition): void {
    const url = this.router.urlFor(transition.to.name);
    const page = this.docfy.findByUrl(url);
    console.log(page?.frontmatter.forEmployeesOnly);
  }
}

I hope this helps.

it does! thanks!
I think because I don't want to make a route file for each generated page, I'll need to set up a router.on('routeWillChange', this.checkEmployeeStatus) or something like that.
I'm very excited for this. :D eeee
I'll report back with results

it does! thanks!
I think because I don't want to make a route file for each generated page, I'll need to set up a router.on('routeWillChange', this.checkEmployeeStatus) or something like that.
I'm very excited for this. :D eeee
I'll report back with results

Excellent. Let me know how it goes.

Excellent. Let me know how it goes.


Minimum participants select field

Acceptance criteria

Position on the top left corner of the home page.
Use a select field with a variant outlined.
Select field has a select item from 1 to 10 and its default selected value is 3.
If the participants are less than the number in the select field, the play button is disabled.
The select field has an icon on the left side of the field. Use the PeopleAlt icon and the color is brown[500].

This issue is fixed by this PR #12


Test case skip()ed, beforeEach() hook still executed, afterEach() missed

This with Mocha 3.1.2. Source test file:
"use strict";
describe('outer', function() {

  beforeEach(function() {
    console.log("A");
    this.skip();
  });

  afterEach(function() {
    console.log("Z");
  });

  describe('inner', function() {
    beforeEach(function() {
      console.log("B");
    });

    afterEach(function() {
      console.log("Y");
    });

    it('test case', function() {
      console.log("C");
    });
  });
});

Expected output: one of two things should happen. Either only "A" should be printed, or maybe "A", "B" and "Y".
Actual output: "A" and "B" are both printed, but not "Y":
  outer
    inner
A
B
      - test case

  0 passing (11ms)
  1 pending

In general, if I call skip(), then I would not expect that inner beforeEach blocks would be executed. If a beforeEach block is executed, then the corresponding afterEach blocks should also be executed, for symmetry.

I think the inner beforeEach will always run unless you call
 it.skip('test case', function() {
      console.log("C");
    });

the this.skip() functionality is fundamentally different than it.skip etc, if you want to know why, I can explain more. It's merely bad naming on the part of Mocha authors, I think.
I don't it's well specified or understand what will happen if you call this.skip() inside a hook. Ideally it would be named, this.continue() or something like that, because all it means is that "we are done here" let's move to the next item.

Looks like a dup of #2286. I'll be great to get #2623 merged as that might solve this too.

This is an issue for several projects I work on, so I'd like to see it stay open.

Looks like this issue might be related to this line of code:
https://github.com/mochajs/mocha/blob/ade8b90a46c641345b67c7979f855bcfbda900d5/lib/runner.js#L671-L673
Which I discovered when reporting this on a related issue here: https://github.com/mochajs/mocha/pull/2571#issuecomment-477407091
Commenting out the above code makes this work as expect, but I'm not sure if that code is needed for other features.

@juergba could you take a look at this and provide your opinion?

@plroebuck see above, I have a PR pending on this.

Commenting out the above code makes this work as expected

Yes, everybody has his own expectations, so first you would have to define/agree on a hook pattern before changing the code.

I think most people assume that, if their beforeEach() hook runs, then their afterEach() hook should also run.
In many cases tests will error if a beforeEach() hook runs and then it runs again without the afterEach() hook running (e.g. stubbing methods and then re-stubbing before unstubbing). This is the case with me, and mocha's current behavior means I have to do all my test reseting in both beforeEach() and afterEach() hooks, just in case.

@philipwalton see mochajs/mocha#3740. We have many identified issues, but it's not as trivial to determine the ramifications of proposed changes against a myriad of possible user settings and configurations (e.g., should it still run "afterEach" if test fails when --bail given).


[wip] Don't Create Duplicate Text Editor for new Config

[wip] Don't Create Duplicate Text Editor for new Config
Still looking into this a bit. We can create a new aiconfig doc with aiconfig scheme and that will go through our content provider to get the initial content. However, this now results in a significant bug where the new file isn't marked as dirty (even with changes), so I think there's some disconnection between the text document and editor :s

Stack created with Sapling. Best reviewed with ReviewStack.

-> #1342
#1337

I only investigated for about 15 mins, but it seems that registering this is designed for read-only content only: https://code.visualstudio.com/api/extension-guides/virtual-documents

The text document content provider API allows you to create readonly documents in Visual Studio Code from arbitrary sources.

It seems if we want to update, we can emit an event for onDidChange and update that, but that seems kind of weird for our use case since our editor is the one initiating the change itself: https://code.visualstudio.com/api/extension-guides/virtual-documents#update-virtual-documents
Perhaps a hack we can do is

Create new command
Find the .json text file editor window tab open with that name
Force close it
When we force close it, force the error not to show up (not sure how we'd do that)

I feel this wouldn't be ideal but could work

Closing in favour of https://github.com/lastmile-ai/aiconfig/pull/1351


probably mistaken implementation of RKD methond

Hi!
I am very grateful for your code. It helps me a lot.
I have 2 questions:
(1) In the paper of RKD method, the authors say: "RKD-D and RKD-A are applied
on the last pooling layer of the teacher and the student" in the Image classification section. However, in the code you provide,   the RKD method is applied to "logits". I think it maybe a mistake.
(2) what's the Tensorflow version used in these codes. could you please add a "requirement" file to this project?

Thank you for your comments.
(1) I checked paper again and I found what you say and you're right it is my mistake. I just confused due to this line : "We apply RKD-D and RKD-A on the final embedding outputs of the teacher and the student." in page 5. I'll correct this error and update the experiment results.
(2) I use TF.1.13 for all the experiments. Your suggestion is useful for my repo. I'll submit a "requirement "soon

I check the author's repository again, found that they use logits also.
I don't know which one is right, but implementation is more believable.

I checked the paper carefully, and I found that
"RKD-D and RKD-A are applied on the last pooling layer of the teacher and the student, as they produce the final embedding before classification."
and
"As the prototypical networks build on shallow networks that consist of only 4 convolutional layers, we use the same architecture for the student model and the teacher, i.e., self-distillation, rather than using a smaller student network. We apply RKD, FitNet, and Attention on the final embedding output of the teacher and the student."
It is very interesting. Because only difference is number of data, but it makes the authors change inputs of their algorithm.


[Breaking Change Request] Support abort() in HttpClientRequest in Dart:IO

Summary
With current APIs in Dart:IO, there is no way to abort the HttpClientRequest. Once HttpClientRequest has been sent, the request cannot be canceled until HttpClientResponse comes back. See the example below:
HttpClient client = new HttpClient();
client.getUrl(Uri.parse("http://www.example.com/"))
   .then((HttpClientRequest request) {
     // Optionally set up headers...
     request.write();
     // Optionally write to the request object...
     // Then call close.
     ...
     return request.close();
   })
   .then((HttpClientResponse response) {
     // Process the response.
     ...
   });

Abort() will allow users to stop waiting for HttpClientResponse, so users can abort the request if it takes too long.
The intended behavior

The future returned by close() will never complete if abort() is called prior to HttpClientResponse being available, which means then callback in the above will never fire.
Data cannot be sent through IOSink's API after abort().
In case of HttpClientResponse returning before abort, abort() will not make any effect.

Expected use case
HttpClient client = new HttpClient();
client.getUrl(Uri.parse("http://www.example.com/"))
   .then((HttpClientRequest request) {
     // Optionally set up headers...
     request.write();
     // Optionally write to the request object...
     // Then call close.
     Timer(Duration(seconds: 1), () {
       request.abort();
     });
     return request.close();
   })
   .then((HttpClientResponse response) {
     // Process the response.
     ...
   });

Expected impact
All classes extends or implements HttpClientRequest in Dart:IO will need to update accordingly.
Proposed Implementation
https://dart-review.googlesource.com/c/sdk/+/147339
Relative discussions
https://github.com/dart-lang/sdk/issues/22265

@lrhn @mit-mit @sortie

Please announce your breaking change using the breaking change process
https://github.com/dart-lang/sdk/blob/master/docs/process/breaking-changes.md

@franklinyow I tried to send email to<EMAIL_ADDRESS>But I got "the group you tried to contact (announce) may not exist".

I'm not sure what is the problem, it may be temporary because it has announcement earlier today.  Maybe wait a bit and try tomorrow.

@franklinyow I tried again with<EMAIL_ADDRESS>and still got back the same error. Any workaround for this?

lgtm, @franklinyow can you enquire with partner teams?

cc @Hixie @matanlurey @vsmenon for review and approval.

An abort method on the request object seems like an elegant solution.

Based on some discussion in draft cl, abort() now will accept two optional parameters. Users are allowed to provide customized exception and stackTrace, which will trigger onError() callback.
@Hixie @matanlurey @vsmenon

SGTM.

A friendly ping. @matanlurey @vsmenon
If it looks good, I can starting preparing fixing patch on packages and flutter. ^_^

lgtm

lgtm

Mark Approved
@zichangg Please go ahead


failOnPassedAfterRetry is true by default

Motivation:
When I run builds locally, I often don't care about flakiness and run the following command:
./gradlew clean build --parallel -Pretry=true -PfailOnPassedAfterRetry=false

However, it's difficult to remember failOnPassedAfterRetry and I end up copy/pasting this every time.
I propose that failOnPassedAfterRetry is false if unspecified.
To prevent our CI from ignoring such failures, our workflows are updated to set failOnPassedAfterRetry=true
Modifications:

The condition for determining failOnPassedAfterRetry is inverted

Result:

Users can now easily run builds ignoring flaky test failures

I think a conservative value would be a better choice as the default for this setting. How about setting your defaults in .gradle/gradle.properties?
# in $HOME/.gradle/gradle.properties
failOnPassedAfterRetry=false

I see, I didn't realize others weren't really using this feature.
Let me close this PR then and add a workaround for my local env. only