Allow using installed client certificate

In my configuration, I distinguish between external traffic originating from the internet and internal traffic within the local network. While internal traffic enjoys direct access to my services, external requests undergo additional authentication via mutual TLS (mTLS), terminated on my proxy.
I stumbled upon a demo showcasing how mTLS can be implemented in Swift. However, as I'm not proficient in Swift development, I'm uncertain about its feasibility.
Would it be possible for the app to show a list of installed profiles/certificates and utilize them in cases where the server mandates client authentication at the TLS layer?

I've received a few requests for this. I'm not an expert at all on the topic, so I'll have to research this first. It does seem useful though, so I'll look into it.

Hi,

Would it be possible for the app to show a list of installed profiles/certificates and utilize them in cases where the server mandates client authentication at the TLS layer?

@zindable As Apple limits the access to the OS Keychain that is not possible, but each app (or keychain group) can import them into their own keychain.
I´m currently trying to implement this feature here: Fork (WiP)

@Nils-witt awesome! Looking forward to a PR on this!

@zindable I pushed @Nils-witt's changes to TestFlight now. Could you give this a try?

I tried to add a certificate, but got certificateLoadError. I used the same p12 file with https://github.com/immich-app/immich and it worked.
The log did not contain anything certificate related :/

@Finkregh I've found in my testing that it dependents on details of the certificate.
I haven't tried this in Immich, but this app I using iOS API for this pretty much directly, so if it doesn't work it's highly likely it's because of Apple's framework. If you created the .p12 with openssl3, I believe you need to pass -legacy to make it work.
I found this out through trial and error trying to import a client cert first straight into macOS keychain and then into the app (the crypto framework is the same).
Can you give that a shot?

It works, nice!
In the Ui it's not clear how I can remove servers, Btw :)

A first version will be in v1.5.0 but I'll follow this up with a UI overhaul to make this a bit more streamlined, paired with some documentation on how to set this up properly in an install.

I'm having issues with this as well. I've seen from the logs that the certificate has been loaded properly, but I'm unable to get the login working anyway.
I have tried to debug everything, cert is valid and loaded correctly, yet logs don't help to understand if the certificate has been sent or not.
Any guesses?


Example on how differential IK may converge to a local constrained optimum

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.823%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1128

Relevant Lines:
1130

💛  - Coveralls


Basic pipeline using the PC

It seems we only use GEE to collect the data. See https://github.com/Clay-foundation/office/issues/11
This issue addresses #2
This is a draft for a pipe that uses the PC to create the zxy.tif tiles at a given zoom level on a time range, including a median reduction.
E.g. Given the region of Asturias and zoom level 11 we make the list of 77 tiles at that zoom level:

and then we ask for the latest data of 2023:
start_date, end_date = "2023-01-01", "2023-12-31"
collection = "sentinel-2-l2a"
reduction="none"
tiles_list = get_cover_tiles(asturias_roi,zoom, do_plot=True)
process_list(tiles_list,collection, start_date, end_date,cloud_cover=20,max_retries=5,reduction=reduction,at_most=10,verbose=False,folder="test_data")

or the median for the year, at most 100 scenes per tile
start_date, end_date = "2023-01-01", "2023-12-31"
collection = "sentinel-2-l2a"
reduction="median"
folder = "2023-median"
tiles_list = get_cover_tiles(asturias_roi,zoom, do_plot=True)
process_list(tiles_list,collection, start_date, end_date,cloud_cover=20,max_retries=5,reduction=reduction,at_most=100,verbose=True,folder=folder)

e.g.  11-988-748 left single shot, right median.

I haven't QA much, and there's still some work to Daskify this and upload to a Azure bucket directly.
Is this what you need @Clay-foundation/earthsight ?

Stale.


Mapping Error During Restore on iOS

I have an issue with Flutter SDK a mapping error occurs when I call the restore function, even though I have updated the SDK version to 7.3.1.
final Map<String, QEntitlement> entitlements = await Qonversion.getSharedInstance().restore();

The error message is:
Error: type '_Map<Object?, Object?>' is not a subtype of type 'String?'
This error only happens on iOS devices.

@aldiFoodLama One question about your implementation :)
Where you are calling the restore method? Didn't you have any problems with that before update to latest sdk version?
When i call await Qonversion.getSharedInstance().restore(); i am receiving this error:
{null, PlatformException(0, An unknown error has occurred, Qonversion Error Code: 0, null)}
But this only occurs in iOS, on Android it's working correctly.
Thank u ;)

Hi, guys!
I apologize for the inconvenience! The fix has just landed! Could you please update it to 7.3.2 and test it again?

I just test with latest version 7.3.2 and my error continue.

This is my implementation. I just calling restore after identify my user on qonversion.
But i am receiving this error.

Thank you, @suriksarkisyan, there are no mapping errors now.

@mpdevelopment39  Maybe try running 'flutter clean' or attempt to reinstall pod dependencies.

@aldiFoodLama One question about your implementation :)
Where you are calling the restore method? Didn't you have any problems with that before update to latest sdk version?
When i call await Qonversion.getSharedInstance().restore(); i am receiving this error:
{null, PlatformException(0, An unknown error has occurred, Qonversion Error Code: 0, null)}
But this only occurs in iOS, on Android it's working correctly.
Thank u ;)

@mpdevelopment39  Similar to yours, after call identify, I call the restore function. However, the restore function is manually invoked based on user interactions.


Delete-blocking relationships should apply to movement between groups

Delete-blocking relationships should apply to movement between groups

I added a TODO for this in 32cbe965e4c7cab1c4b3597ac7e77a77b61baef0. After verifying that Group cascade was already being handled correctly, I removed that TODO in 05a0e854bd8522e6c12dbc718226cf0c0edd0abb.


player.stv.tv

[x ] I've verified and I assure that I'm running youtube-dl 2019.04.01

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser.

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--geo-bypass-country', 'GB', '--ignore-config', '-v
', '-F', 'https://player.stv.tv/episode/3ikk/liberty-american-cookbook/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.04.01
[debug] Python version 3.4.4 (CPython) - Windows-XP-5.1.2600-SP3
[debug] exe versions: ffmpeg N-91691-g962c931-Reino, ffprobe N-91691-g962c931-Re
ino, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (GB) as X-Forwarded-For.
[generic] liberty-american-cookbook: Requesting header
WARNING: Falling back on generic information extractor.
[generic] liberty-american-cookbook: Downloading webpage
[generic] liberty-american-cookbook: Extracting information
ERROR: Unsupported URL: https://player.stv.tv/episode/3ikk/liberty-american-cook
book/
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp48z7ci
11\build\youtube_dl\YoutubeDL.py", line 794, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp48z7ci
11\build\youtube_dl\extractor\common.py", line 529, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp48z7ci
11\build\youtube_dl\extractor\generic.py", line 3320, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://player.stv.tv/episod
e/3ikk/liberty-american-cookbook/
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://player.stv.tv/episode/3ikk/liberty-american-cookbook/
Single video: https://player.stv.tv/episode/3jgl/liberty-american-cookbook/

Support for.
player.stv.tv
Thanks.

That I knew this would be a probability and the reason why I tried it with the following command --geo-bypass-country "GB" to ensure any geo restrictions are passed.
I checked again now for 'Country Codes ISO 3166-2' the code "GB" does actually cover all 3 countries and 1 province of UK. Of which one of the countries is Scotland where STV is located.
If you or another youtube-dl maintainer can add support for this site it would be appreciated.

support for this has been added and will be included in the next release.


Fix for not properly initialized elapsed time.

There is a recently introduced bug when elapsed time does not get properly initialized in case of a dumb terminal. This is a fix for this issue.

Thanks!

(Note to self: https://github.com/ninja-build/ninja/pull/1147 fixed %e in dumb terminal mode but broke it in smart terminal mode. This here fixes it in smart terminal mode too.)


Use miniforge instead of miniconda in the runner image

I've noticed "security" milestone here. How quickly this have to be done?

This week, please.


[EMBED MAKER] Suggestion | Pages

So when creating an embed it would be great to be able to decide how much would be inside an embed before adding reactions to see more pages you can look through. Just like using help command with the usemenus option for Red's help.
Then one could create their own help embeds for custom commands and the embed wouldn't endup being one long embed when enough command descriptions have been added.

The closest to this I intend to support is #134 People can handle their own content lengths, I don't intend on modifying provided embeds for people, and consider it to be out of scope for embedmaker.
I may reconsider this in the future.


Vim9: two syntaxes for dictionary is confusing

Problem
Vim9 script supports two syntaxes for dictionary; dictionary and literal dictionary, as same as Vim script. However, having two syntaxes for dictionary in one language is confusing sometimes, especially for beginners. I'm afraid these syntaxes make Vim9 script wired for learners.
var x = { 'foo': 1, 'bar': 2 }

var foo = 'x'
var bar = 'y'
var y = { foo: 1, bar: 2 } # {'x': 1, 'y': 2}
var z = { join(range(5)): 10 } # {'0 1 2 3 4': 10} but who needs this?

# Literal dictionary
var w = #{ foo: 1, bar: 2 }

I know the literal dictionary syntax was introduced to avoid the confusing key-evaluation behavior in Vim script. But we don't need to bring this behavior to the new language.
Specification suggestion
I suggest following changes.

Changing the dictionary syntax supports either string literal keys or name keys.

For example, both { 'a b c': 1 } and { foo: 1 } (exactly same as { 'foo': 1 }) are supported. Stop evaluating the keys as expression.

Dropping literal dictionary syntax #{ foo: 1 }, and treat # as comment leader anytime.

var x = { 'foo': 1, 'bar': 2 }
var y = { x: 1, y: 2 }

# We cannot var z = { join(range(5)): 10 }, so we have to
var z: dict<number>
z[join(range(5))] = 10

# Mixing literal keys and string keys is allowed
var w = { foo: 1, 'a b c': 2 }

This is exactly same as JavaScript and much more intuitive for many programmers. And this also makes the Vim9 compiler simpler.

Problem
Vim9 script supports two syntaxes for dictionary; dictionary and
literal dictionary, as same as Vim script. However, having two
syntaxes for dictionary in one language is confusing sometimes,
especially for beginners. I'm afraid these syntaxes make Vim9 script
wired for learners.

It's a good point that the #{} syntax is unlike any other popular
language.  Using {} for all dictionaries is "less weird".
There are three disadvantages:

Different from legacy script.  I think we can live with this, since
there are other differences, such as the comment character #.
Using {} both for literal keys and key expressions.  This can be a bit
tricky, a typo may give unexpected errors.
Separating {} used for a dictionary from {} used for a lambda.  The
last has "->" somewhere, otherwise they are very similar.  Again, a
typo can cause confusing error messages.

var x = { 'foo': 1, 'bar': 2 }

var foo = 'x'
var bar = 'y'
var y = { foo: 1, bar: 2 } # {'x': 1, 'y': 2}

I don't think it is acceptable to look for the context to see what "foo"
means, "foo" should always be used as a literal key.
It should be possible to indicate "foo" is a variable name, e.g.
var y = { '' .. foo: 1, '' .. bar: 2 } # {'x': 1, 'y': 2}
It's a bit clumsy, but it would not be used often.

var z = { join(range(5)): 10 } # {'0 1 2 3 4': 10} but who needs this?

That can actually work, since "join(range(5))" is not an ID.

Mixing literal keys and string keys is allowed
var w = { foo: 1, 'a b c': 2 }

This is a bit confusing and may lead to mistakes, but we need to allow
it for consistency.

This is exactly same as JavaScript and much more intuitive for many
programmers. And this also makes the Vim9 compiler simpler.

I actually don't like how JavaScript does this, it's not intuitive.
Someone who hasn't used this before needs to read documentation to find
out how this works.  But still, it's a popular language and this syntax
is used a lot.
It will make the compiler more complicated, actually.  Recognizing a
lambda gets tricky:
{a: bool, b: string -> a .. b}
Up to the "->" this very much looks like a dictionary.
--
hundred-and-one symptoms of being an internet addict:
262. Your computer has it's own phone line - but your daughter doesn't.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

This is exactly same as JavaScript and much more intuitive for many
programmers. And this also makes the Vim9 compiler simpler.

This is actually not correct.  Since 2015 JavaScript uses square
brackets for a key that is made from an expression:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#Computed_property_names
	var fooVar = 'foo'
	var barVar = 'bar'
	var d = {[fooVar]: 1, [barVar]: 2}

Somehow I haven't seen this used, an indication that this isn't commonly
used. Mostly the keys would be literal IDs, then it looks very common:
	var d = {foo: 1, bar: 2}

Just like the #{} dictionary we have now, but without the #.
If you need to you can use the [] notation for computed keys.
This seems like a good solution for Vim9 script.
--
hundred-and-one symptoms of being an internet addict:
268. You get up in the morning and go online before getting your coffee.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I guess var d = {(fooVar): 1, (barVar): 2} will work too.  Is the bracket-notation needed?

It will make the compiler more complicated, actually.  Recognizing a
lambda gets tricky:
{a: bool, b: string -> a .. b}
Up to the "->" this very much looks like a dictionary.

Thanks for this example, I missed this point. I think this lambda syntax is also
rare in languages and want to change this like TypeScript arrow functions.

This is actually not correct.  Since 2015 JavaScript uses square
brackets for a key that is made from an expression:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#Computed_property_names

I knew the syntax but I think we don't need to start with fat specifications. Even
for JavaScript it took 20 years to allow this syntax since it came out to the world.
Why don't we start with small syntaxes. Providing development tools like language server
and code formatter, and stable language specifications are much much more important for
users than implementing complex syntaxes.

I guess var d = {(fooVar): 1, (barVar): 2} will work too.  Is the
bracket-notation needed?

What other language does it like this?
One of the goals is to do things the same way as other popular
languages.  I think for dictionaries JavaScript comes closest.
They may also call them object literals.
Python also uses dictionaries, but there the key can be anything, not
only a string, thus that is different.
--
Ten bugs in the hand is better than one as yet undetected.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Just asking, it was not a proposal.

Possibly fixed by 8.2.2015:
vim9script
def Func()
    var d = {key: 123}
    echom d
enddef
Func()

However, the # sign can only be dropped in a :def function; not at the script level:
vim9script
var d = {key: 123}
echom d

E121: Undefined variable: key
E121: Undefined variable: d

However, the # sign can only be dropped in a :def function; not at the script level:

Talked too fast; 8.2.2017 also implemented the new syntax at the script level.

Right now, #{} is still parsed as a literal dictionary in Vim9 script.  Will it change?  That is, will #{} be parsed as a comment in the future?

Right now, #{} is still parsed as a literal dictionary in Vim9
script.  Will it change?  That is, will #{} be parsed as a comment
in the future?

Yes, I'm giving those who have started writing Vim9 scripts a chance to
adjust to the new syntax before disallowing the #{} syntax.
Although in a few cases the change has already broken some things, as
the changes to tests indicates.
I plan to remove the support for #{} in Vim9 script in a couple of
weeks.
--
He was not in the least bit scared to be mashed into a pulp
Or to have his eyes gouged out and his elbows broken;
To have his kneecaps split and his body burned away
And his limbs all hacked and mangled, brave Sir Robin.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Not sure, but I think the issue can be closed now; in 8.2.2082 the old syntax has been dropped, so there's nothing left actionable.
To summarize, here is the list of relevant commits which has progressively fixed the issue:

8.2.2015  Vim9: literal dict #{} is not like any other language
8.2.2017  missing part of the dict change
8.2.2082  Vim9: can still use the depricated #{} dict syntax
8.2.2090  Vim9: dict does not accept a key in quotes

Thank you for listing the related commits. Closing the issue.
Thank you all for discussion and Bram for accepting the spec changes.

Should we give a specific error for when using the old syntax #{}?  If we allow #{ as the start of a comment, Vim can give a confusing error message.  For example:
vim9script
def Popup(): string
    popup_create('', #{})
    return ''
enddef
defcompile

E1001: Variable not found: return

I understand the error, but it still looks weird the first time you read it.  A better error would be:
E1234: "#{" cannot be used in Vim9 script to create literal dictionary

I would argue that it will be more frequent for people to wrongly use the deprecate literal dictionary syntax (for example after copying some legacy code) then to try to write a comment starting with {.  And fixing this kind of issue will be harder than it could be if the error message is not as obvious as possible.

I would argue that it will be more frequent for people to wrongly use the deprecate literal dictionary syntax (for example after copying some legacy code) then to try to write a comment starting with {.

I mean a comment starting with { is certainly possible, but you should use a space between the comment leader and the text for better readability:
# { some comment
 ^

Should we give a specific error for when using the old syntax #{}?
If we allow #{ as the start of a comment, Vim can give a confusing
error message.  For example:
vim9script
def Popup(): string
    popup_create('', #{})
    return ''
enddef
defcompile

E1001: Variable not found: return

I understand the error, but it still looks weird the first time you
read it.  A better error would be:
E1234: "#{" cannot be used in Vim9 script to create literal dictionary

I would argue that it will be more frequent for people to wrongly use
the deprecate literal dictionary syntax (for example after copying
some legacy code) then to try to write a comment starting with {.
And fixing this kind of issue will be harder than it could be if the
error message is not as obvious as possible.

Yeah, this can be confusing.  Previously we detected #{ and did not
handle it as a comment.  That check was removed, but now we may get the
problem you found.  Instead of removing the check for #{ we can turn it
into an error.
--
A radioactive cat has eighteen half-lives.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Adding pop up dialog box for subscribing to newsletter

Related Issue
Fixes:  #3885
Description
Adding a basic popup dialog box for subscribing to newsletter.

Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

ok nice , but what does the text on the left side of the popup mean?

nice , but what does the text on the left side of the popup mean?

It is simple book cover of random book.


[data-source] scientific reports / posts & papers

We need a or multiple sources for data that provides:

title
short description
timestamp
link

for scientific publications

this twitter feed provides lots of official postings: https://twitter.com/i/events/1235661905152245761

I found https://www.coronatracker.com/country/de/ - they do provide regional news in various languages.
Looking at https://api.coronatracker.com/v3/analytics/trend/country?countryCode=DE&startDate=2020-03-13&endDate=2020-03-27 seems really promising

Maybe this is a interesting source: https://ncov2019.live/

These are some interesting APIs we should take a look at:

https://www.programmableweb.com/api/springer-open-access-rest-api-v20
https://www.programmableweb.com/api/smartable-ai-covid-19-stats-and-news-rest-api-v10
https://www.programmableweb.com/api/aylien-news

Closing as this is solved buy the current RSS fetching solution


Naming changes in installer.scripts

Renames:

tools/getlaunchers.py -> tools/update_launchers.py
Script.build -> Script.generate

We should really avoid using the phrase "build" in this package. That word is used often enough that it can get confusing what's being talked about. :)

I am -0 to generate since the verb is related to a generator.

The word "generate" IMHO cannot be confused with the python term "generator" as the latter does not really have any semantic meaning when spelled differently in any way shape or form...
On the other hand, if the name is concerning, I'd like to point out this doesn't build or generate or anything of the sort, anywhere here. It doesn't matter how many times you do it, you won't rebuild or regenerate a "script", because the results of the previous invocation were ephemeral, and the function name, both of them, might fool the casual reader into thinking that it is backed by a file.
It formats the _SCRIPT_TEMPLATE and returns a string.
How about Script.get_data?

Other naming options are "create" or "as_script".

Also, construct.

create sounds good to me.
Unless someone raises concerns with that name in the next day or so, I'm gonna swap to that.

It still feels weird that way. Think about the API you're providing, and imagine you're a new user:
import sys
import installer.scripts
s = installer.scripts.Script('foo', 'foobar', 'main', 'console' )
s.build(sys.executable, kind='posix')

What do you expect s.build() to do? Well, build sounds like it will act in the build stage, so we want to change that, right?
Okay, let's try again:
s.create(sys.executable, kind='posix')

"Okay, I've created it, now where is it?"
I still think get_data is clearer:
ret = s.get_data(sys.executable, kind='posix')

"Okay, I've gotten the data contents of the Script, I should probably check type(ret) and figure out how I should use it; it will probably be some data blob."
Mentioning the "data" somewhere in the method name seems like a useful way to avoid potential confusion later on.

OTOH, I still think ret = s.generate(...) is good enough too. If no one's a -1 on that, I'll just merge this PR. :)

Thanks for the reviews and thoughts everyone! ^>^


Bonefire: Error Potential infinite loop

I am at Bonfire: Smallest Common Multiple; and it gives me this potential infinite loop error. I checked my code localy and it does not have infinite loop and also gives correct output. But i can not pass the bonefire as i can not even submit code due to this error.
After that i went to one of my old code that is Bonfire: Chunky Monkey that i have already passed and also has nested loops. And as expected this error shows up again here is the screen shot:

This code has already passed before so i think this error is due to a recent update which is failing to detect infinite loop.
My code:
function chunk(arr, size) {
  var l = 0;
  var ansArray = [];
  while(l<arr.length){
    var arrTemp = [];
    size = l+size > arr.length ? arr.length - (l+size) : size;
    for(var i=0;i<size;i++){
      arrTemp.push(arr[l+i]);
    }
    ansArray.push(arrTemp);
    l = l+size;
  }
}

chunk([0, 1, 2, 3, 4, 5], 4);

@Dishant15
I think your code has bug.
see more at http://jsfiddle.net/s557g4x7/4/
the reason for infinite loop is $var l$ becoming negative during while loop,
F12 into debug to see the results in the console of the browser you use.
curious about why the first time this code pass tests

As @shl-kfy points out, your code legitimately has an infinite loop in it. If you're ever concerned that the protection is flagging a false positive you can add //noprotect to the top of the file, but you open yourself up to the possibility of locking up the page, which is what will happen in this case.
Thanks and happy coding!


Method missing with gitlab

Hi, got error with gitlab integration
ruby - 2.3
gitlab - 4.6.1
pronto - 0.9.5
> PRONTO_GITLAB_API_PRIVATE_TOKEN=$PRONTO_GITLAB_API_PRIVATE_TOKEN pronto run -f gitlab -c origin/develop

/Library/Ruby/Gems/2.3.0/gems/gitlab-4.6.1/lib/gitlab/objectified_hash.rb:28:in `method_missing': undefined method `map' for #<Gitlab::ObjectifiedHash:0x00007fc3bbac02e8> (NoMethodError)
Did you mean?  tap
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/gitlab.rb:5:in `commit_comments'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `block in existing_comments'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `each'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `flat_map'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `existing_comments'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/git_formatter.rb:6:in `format'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:67:in `block in run'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:66:in `each'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:66:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:61:in `block in run'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `chdir'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /Library/Ruby/Gems/2.3.0/gems/pronto-0.9.5/bin/pronto:6:in `<top (required)>'
	from /usr/local/bin/pronto:22:in `load'
	from /usr/local/bin/pronto:22:in `<main>'

I ran into the same error recently and by setting the api_endpoint in my pronto config for gitlab to https://gitlab.com/api/v4 resolved it.  The pull request(https://github.com/prontolabs/pronto/pull/298) to fix this is still unreleased https://github.com/prontolabs/pronto/blob/master/CHANGELOG.md

@Apelsinka223 Feel free to reopen the issue if you're getting the same error when using the newest version from master.

I am getting exactly the same problem, background info, I just got the release from the Github and updated gem locks. Any update on that issue?

I am also getting this with 0.9.5

@sobolevn could you check if that's still the case with 0.10.0?

@mmozuras well, I actually cannot update, since a lot of plugins (json, yaml, spell) relies on 0.9.5. I have opened several issues to upgrade the versions.


Enable Customized CSRF Protection in Spring Security for Server Webapp

References

Replaces #2922 (Based heavily on this older PR with updates)
Replaces #3001
Requires https://github.com/DSpace/dspace-angular/pull/977 when testing Angular UI

Description
Enables a customized version of Spring Security CSRF (aka XSRF) Protection which works both cross-domain (where client & backend are on separate domains) and via Shibboleth.  The CSRF Protection is custom because, while it still uses Cookies to save CSRF tokens, the CSRF tokens are always sent between the frontend & backend via HTTP Headers (this is what allows it to work cross domain).
As noted in this LGTM rule, Spring Security enables this CSRF protection by default and recommends it "for any request that could be processed by a browser client by normal users".  In this PR, I've also made sure to use standard names for XSRF headers/cookies based on Angular XSRF Protection best practices -- this makes the Angular UI implementation a bit easier.
Detail: How it Works

Server Webapp generates CSRF token & stores in a server-side cookie named DSPACE-XSRF-COOKIE.  By default, this cookie is not readable to JS clients (HttpOnly=true). But, it is returned (by user's browser) on every subsequent request to backend.
At the same time, Server Webapp also sends the generated CSRF token in a header named DSPACE-XSRF-TOKEN to client (e.g. Angular UI).
Client MUST look for DSPACE-XSRF-TOKEN header in a response from backend. If found, the client MUST store/save this token for later request(s).  For Angular UI, this task is/will be performed by a new XsrfInterceptor.
Whenever the client is making a mutating request (e.g. POST, PUT, DELETE, etc), the CSRF token is REQUIRED to be sent back to the Server Webapp in the X-XSRF-TOKEN header.

NOTE: non-mutating requests (e.g. GET, HEAD) do not check for an CSRF token. This is default behavior in Spring Security

In the Server Webapp, the X-XSRF-TOKEN header is received & compared to the current value of the server-side cookie named DSPACE-XSRF-COOKIE. If tokens match, the request is accepted. If tokens don't match a 403 is returned. This validation is done automatically by Spring Security.

In summary, the CSRF token is ALWAYS sent to/from the client & backend via HTTP headers. This is what allows the client and backend to be on different domains. The server-side cookie named DSPACE-XSRF-COOKIE is (usually) not accessible to the client. It only exists to allow the server-side to remember the currently active CSRF token, so that it can validate the CSRF token sent back (by the client) in the X-XSRF-TOKEN header.
Full List of Changes

Enables Spring Security's CSRF protection, using a custom DSpaceCsrfTokenRepository to send/receive the CSRF token (as described in detail above).

Also adds a custom DSpaceCsrfAuthenticationStrategy which ensures the CSRF token is only regenerated/changed when it is attempted to be used -- this is needed as the default AuthenticationStrategy ends up regenerating the token on every request when stateless authentication is used.
Adds/Updates ITs to prove this is working as expected....including verifying an error is thrown if an invalid CSRF token is sent.

Updates /logout endpoint to ONLY respond to POST requests (previously it allowed for GET or POST).  This aligns with the OWASP principle "Do not use GET requests for state changing operations". It also is recommended by Spring Security
Added custom DSpaceAccessDeniedHandler to allow us to customize the error message when an invalid/missing CSRF token is sent.
Updated all Cookies to use SameSite=None attribute. This is necessary to allow Cookies to be passed back and forth (by a user's browser) between client & server when they are on different domains.  Without this, the browser will block (or fail to send) these cookies back whenever the UI and REST API are on a different domain.
Updated HAL Browser code to support CSRF as described above. This means it now reads the CSRF token from the new DSPACE-XSRF-TOKEN header...storing it in a new MyHalBrowserCsrfToken cookie (alongside MyHalBrowserToken cookie used for the Auth token), and sending it back in a X-XSRF-TOKEN header.
Minor changes to AbstractBuilderCleanupUtil to list a few missing Builders.  Without them, I hit some odd IT errors.
Minor cleanup/reorg of WebSecurityConfiguration just to make it more readable. Added some inline comments.
Minor changes to ApplicationConfig to ensure URLs listed in rest.cors.allowed-origins configuration never end in a trailing slash.  Spring Security treats "http://example.org" and "http://example.org/" as different origins....which causes very odd behavior if you don't notice you added a trailing slash.
Minor fixes to Docker settings for dspace-shibboleth docker image.  This fixes an annoying bug where Apache settings on that image were overwriting the HTTP Headers generated by the DSpace REST API, causing odd errors to occur.

Instructions for Reviewers

Test HalBrowser (especially login/logout)
Test Authentication via Shibboleth
Test Authentication via Password
Test Angular UI functionality in general (Requires corresponding Angular PR)

Checklist

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

Merging as this PR is at +2, and the (smaller) corresponding Angular PR is at +1 and flagged as 1 Approval.


[Analytics] Add support for gravity IDs required for analytics in Eigen

see Eigen PR

The key here is that as a part of the message to AREmssion that you want to trigger the refine it would include the slug for the requesting object in the message to the RN bridge.

@anipetrov and I are wondering if this is ready to complete?

@katarinabatina @anipetrov Just switched back onto it now. From what I recall from a planning meeting, it was mentioned that only one other item was critical to complete, so seems I had paused this. Bashing it out now!


Added in basic chart rendering for best hikes at /hikes-chart.html

Will later add more styling features, more charts rendering elevation of different hikes, and perhaps dynamic data loading.

*will also add link that allows user to redirect to this html page from the home page!

good point! thanks for these comments - ill make it so that the label is consistently on the outside of the bar. thanks for your input!


The recipe is wrong.

The recipe for polarium dust in version 1.16.5 is set to "minecraft:snow_ball", but it should be "minecraft:snowball", so the recipe is not displaying correctly.

Known issue, it's not gonna get fixed, 1.16.5 is too old.


Fix error message typo

Remove unncecessary '

Pull Request Test Coverage Report for Build 283448245

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.715%

Totals

Change from base Build 283346244:
0.0%

Covered Lines:
19968

Relevant Lines:
45947

💛  - Coveralls


Adapt to changes in knitr

This doesn't affect what we send to the publisher.  The knitr package has made some slight changes that aren't backward compatible.  In a few days/weeks, I'd like to update the code so that it remains reproducible on a contemporary student's machine.  I need to

[x] add library(knitr) earlier in the Rmd file

[x] replace the old png & pdf files, because knitr has slightly changed it's numbering scheme within a chunk.

[x] explicitly tell knitr/rmarkdown to keep the md files, so they're visible on GitHub
---
output:
html_document:
  keep_md: yes
---

completed a few years ago.


fix(camera_models): set pinhole device correctly.

Bug fix for device setting in the pinhole model.

Looks good. Please go ahead, merge, and remove the branch if not needed anymore.


[Dependency Scanning] Revert: Remove Swift Overlay dependencies from the set of direct dependencies

Equivalent change to main's: https://github.com/apple/swift/pull/68775
Functionally reverts #67928.
We must still support potentially older drivers which are not ready for this change due to: apple/swift-driver#1438

@swift-ci test


[OTHER] Add background color in the resource card in light theme

What would you like to share or ask?
The resource card have no background color on light theme.

Add light-gray background color and a slight border same as the category page.

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (optional)

I am new to open source projects and would like to work on this one

@AlexMutig you're assigned, please do not forget to read & follow our Contributing Guidelines. Let us know if you need any assistance.


Weight mainstat free roll

Pull Request
Description
Previously the free roll given to mainstats were unweighted, which gives false weight to useless mainstats. E.g. a relic with healing boost on argenti would have a nonzero total weight.
Related Issue

https://discord.com/channels/800607517074784256/1177491834369474570/1208161718014967890
Type of Changes
Added

Changed

added weighting to the mainstat free roll
removed a useless field from relics to try and make them more read-only and less mutable

Fixed

Checklist

[x] I have added commit messages that are descriptive and meaningful.
[x] I have tested the changes locally.
[x] I have reviewed the code changes.

Screenshots

Fake relics, filtered for Argenti (all stats on the body are 0 value on argenti)
Before:

After:

Additional Notes

Good thinking, thanks for the improvement!


Allowed findByIds to use integer ids and added tests.

Hi Nodkz, i finally got round to this!
Ended up doing a Number.isInteger test in findByIds.
Also added some tests, but had to create my own model (PostModel) that had integers for _id.
Feedback very welcome, this is my first proper pull request.
Cheers
Kaho

Awesome work! Thanks a lot!
A new version will be automatically published in couple of minutes.


Add tests to symbolic that verify correctness, not strings

Note: don't remove the strings unless the new test is comprehensive.

shouldn't this issue be closed already?


Market/Themes In Development Environment Un-Rendered

Seems that the Market/Themes section goes un-rendered in a development environment via the HTTPS protocol, works fine under standard HTTP/1.1.

SSL will be supported soon.


Incorrect Version shown for - Microsoft.Configuration.ConfigurationBuilders.Azure

This line:
Specifies Version 1.x - but the latest DLL is version 2.x
	<add name="AzureKeyVault" vaultName="stm-poc-dot-kv-east-dev" vaultUri="https://stm-poc-dot-kv-east-dev.vault.azure.net" type="Microsoft.Configuration.ConfigurationBuilders.AzureKeyVaultConfigBuilder, Microsoft.Configuration.ConfigurationBuilders.Azure, Version=<IP_ADDRESS>, Culture=neutral" />

Thanks
Greg Bryniarski

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41d504b5-9f2f-eb73-ae04-9a322a5d1ed6
Version Independent ID: d085a763-307a-3e26-60db-abaf63b904d4
Content: Add Key Vault support to your ASP.NET project using Visual Studio - Azure Key Vault
Content Source: articles/key-vault/general/vs-key-vault-add-connected-service.md
Service: key-vault
GitHub Login: @ghogen
Microsoft Alias: ghogen

@gbryniarski Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks @gbryniarski ! I made a pull request to update this to the right version. https://github.com/MicrosoftDocs/azure-docs-pr/pull/185352


Add Mastodon to custom icons for project_urls

Use the mastodon icon for links titled “Mastodon”.

I haven’t tested this but I did check that the icon exists in the version of fontawesome in the repo.


Display homepage cards depending on network

Cards should not be displayed for networks that don't have State History

@tetogomez lets add an env var : STATE_HISTORY_ENABLED=true that can be used to toggle this
lets include this in the transactions history dropdown (show or hide)


web3torrent: Cancel and restart downloading doesn't work

Describe the bug :bug:
Cancel and restart downloading results in errors (see the screenshot)
To Reproduce
Steps to reproduce the behavior:

Update a large file.
Start download
Leecher gets stuck
Press cancel in leecher window
Start download again (see error)

Expected behavior
Should be able to redownload
Screenshots (if applicable)
Leecher error screen:

This could well be related to #1215

With this PR merged, the current behaviour is, when leechers cancels the download, wire is dropped but the channel is still running. I'm working to fix it.


Added animation for PredictionsView

The predictions view will now slide up, as shown in the attached video.
https://user-images.githubusercontent.com/4683017/113069943-45507000-9176-11eb-8756-da5632c69ab1.mov

@ellbosch thanks for doing this! There seems to be a delay with the bars moving to place on the initial animation:

This might be caused because there are 2 spring animations. If we could fix that, that's looking amazing!


Improve UI

Just a suggestion to add tab for changed apps,
It's annoying to search for the same app all the time.
Thanks:)

Thanks for the suggestion! I will release a new version with some improvements.
Closed with: https://github.com/Flo354/XposedAppLocale/commit/55df34df270d04dd7ddf21b826cc72d2ffa6ae16


Automate install of Kai client distributed as a zip file

Hi @dymurray, just to be sure cause I got a little confused, by kai client you mean the kai vscode plugin, correct ? if not could you please elaborate ?

@midays no, this is referring to the python client that is being delivered by the end of this sprint. To be honest, this work might be premature until we finish https://github.com/konveyor/kai/issues/330.
For now, I think we would want to ensure we understand https://github.com/konveyor/kai/pull/321 so that we know what deps we need to support pyinstaller in our automation


remove undefined test suite (#2898)

Description:
Related issue (if applicable): fixes #2898
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

This is not a proper fix, our test suite is located at tests (see the folder).


Question: Is completion supported for the kubectl plugin?

I installed both as kubectl plugin using krew and as regular terminal commands using this method. The completion is working for the terminal commands but not for the kubectl plugin. Is there a way to get completion to work for the kubectl plugin or is it simply not supported? (Just want to know if it is possible before I spend more time trying to make it work).

Sadly no. :(
kubectl plugins don't have a shell completion planned yet. https://github.com/kubernetes/kubernetes/issues/74178

/reopen
https://github.com/kubernetes/kubernetes/issues/74178 is closed, the feature is available

Krew does not have support for installing completion commands in PATH yet, so I'd say we tackle that first and worry about this case later (as most installations of kubectx aren't as a kubectl plugin).


asciidoctor template

Hi, I added PR with asciidoctor template #29. Please approve or reject it. In the latter case I'll just add it as a separate template project to my github account.

Sorry, @fiddlededee. It's already merged and published on npm. Thanks for the great template!


Pytorch version code released?

Hello!
I would like to thank you for this awesome work.
I just wonder that the pytorch version code will be released recently?
Thank you

@haloha123 yes, we have some PyTorch implementation already.
The official release will be in this repro (https://github.com/biboamy/music-repro) around 1 months.
(The music reprogramming was submitted to ISMIR last year and now under review at ICASSP)
If you have something urgent or would like to have some collaboration with us just feel free to send me an email. 👍🏼

Thank you for your reply, I look forward to see your work and code soon!

This Pytorch version is released. @haloha123
https://github.com/biboamy/music-repro
A Demo code can be considered here.
https://github.com/biboamy/music-repro/blob/main/training/demo.ipynb


I created a discussion group

If you have any questions, you can discuss them together
https://t.me/+U_NZ-vCPnV1hMTNl

There is one already https://t.me/thisisnotclash


Implement flat shading

Flat shading is nice if you want lighting but also want to see your triangle. Or if you want a retro look.

Mmm, in ThreeJS the MeshPhongMaterial has a .flatShading property. It feels like a different material to me, what do you think @Korijn ?

LGTM!

Or if you want a retro look

It can look absolute gorgeous. You can also makes things look out of place/jarring by having a flat shaded object in an otherwise phong shaded scene.

Mmm, in ThreeJS the MeshPhongMaterial has a .flatShading property. It feels like a different material to me, what do you think @Korijn ?

I don't think it matters much :) I'm fine with having it be a separate material.


stderr is redirected to stdout

$ zeus runner '$stdout.puts "out"; $stderr.puts "err"' > /dev/null
$ rails runner '$stdout.puts "out"; $stderr.puts "err"' > /dev/null
err

Any news on this matter? I just stumbled upon this when I was writing a script. Now I have to use rails runner to run my script in order for me to quickly see some warning conditions from a script generating CSV output directly to stdout :disappointed:

Long time since I've been using zeus but finally been using it again and this annoyed me enough so here we go #615 needs some cleanup but works locally for me to start out with.