Add option for setting crossOrigin attribute on images (#226)

This PR adds a stage option to Lightning for setting the crossOrigin: "Anonymous" attribute on images. This allows problematic platforms to disable the attribute and avoid CORS issues.

Hi @Moussa,
since this is more of a platform specific fix rather than an useful option I wonder if we can identify PS4 platform during runtime, similar to this:
Utils.isWeb = (typeof window !== "undefined") && (typeof sparkscene === "undefined");
Utils.isWPE = Utils.isWeb && (navigator.userAgent.indexOf("WPE") !== -1);
Utils.isSpark = (typeof sparkscene !== "undefined");
Utils.isNode = (typeof window === "undefined") || Utils.isSpark;

and make proper fix for PS4 specifically.
Best regards

@g-zachar That sounds reasonable, the PS4 is the only platform we've run into this issue with. I'll close this PR and re-open with the new approach 👍


feature: Log message when no listener for event

Fixes #168 . This adds a log message when a responder or subscriber receives an event that it does not have a listener for. Logging is based on the cote log option and can be overridden at the Component level.

Coverage decreased (-0.1%) to 99.857% when pulling 9dca449b09a09b3c403d2650bd6d1129bdf4c98c on otothea:feature/log-missing-event-types into 955b85394ab246f3aced81f22f93ba07dece27d5 on dashersw:master.

@otothea thank you! before I merge it, could you also add a section to the readme about this option?

@dashersw I added the line to the readme. Unfortunately the Travis CI build failed due to what looks like a memory issue. I'm not sure how to retry it.


Deploy Open SIEM solution terraform module

Describe the Issue

We have a terraform module with all the resources required to deploy Opensiem

Additional Context

Ticket #2253

Acceptance Criteria
-Deploy the module in the ECF Env and make sure OpenSIEM service is created and logs are feeding
.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Not working on OpenSIEM anytime soon.


Persistent config

 is a comment.
You will see these throughout the issue template. Make sure you do not type your comments
between these characters or we will not be able to see what you wrote!

4. Links
To create a hyperlink, type the [text you want to link](followed by the url in parenthesis)
-->
Is your feature request related to a problem? Please describe.

Yes - its frustrating when I lost my config over and over :)
Describe the feature that you would like to be added

Please add possibility to export/import config or move caonfig file to shared folder outside docker container so it will survive addon reinstall/switching branches
Describe alternatives you've considered

I was able to backup and restore my config few times, but not not always I remember to do it... It is also not easy for casual user.
Describe your use case for this feature

I think that better will be to use shared folder for config and cert files
Additional context

...

This actually has been done! It's now stored in the config folder with all your other configuration files

This actually has been done! It's now stored in the config folder with all your other configuration files


feat(roles): Add support for roles in groups in GMS

Details

Adds support for roles to be assigned roles by adding roleMembership aspect to the CorpGroup entity.
Updates policy engine to check for roles assigned to the groups of a given actor by:

Quering for group membership (native and non-native) when resolving roles for a given actor alongside user role membership.
Batch quering for each group membership type for their respective role memberships.
Finally, merge all groups together and check permissions based on that.

Fixes a bug in CreateGroupResolver which was not accounting for description to be an optional field when creating groups.

Tests

[x] Adds unit test in DataHubAuthorizerTest for new permission check. New test fails if policy engine logic does not account for group-level roles.
[x] Adds smoke test for the feature.
[x] Manual check in local deployment with a Loom Recording: https://www.loom.com/share/baa7e7ca835540e987dea740255ff209?sid=a3e2fdee-3b40-4af7-abf7-4997144607a6

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Failing CI is related to Airflow Plugin tests timing out. This is unrelated to the changes in this PR.
Merging the PR.


Added addProfile to MagickImage

Let me know if it has any error. I'll be glad to fix it.
I hope I could helped.

Thanks for helping out again. I have left some comments.


TFLite GPU execution failed

I trying to run one model on TFite mobile GPU using opencl and getting below error:

INFO: Initialized TensorFlow Lite runtime.
INFO: Created TensorFlow Lite delegate for GPU.
ERROR: Next operations are not supported by GPU delegate:
SPLIT_V: Operation is not supported.
First 294 operations will run on the GPU, and the remaining 40 on the CPU.
INFO: Initialized OpenCL-based API.
Applied GPU delegate.
Initialized session in 107237ms.
Running benchmark for at least 1 iterations and at least 0.5 seconds but terminate if exceeding 150 seconds.
ERROR: TfLiteGpuDelegate Invoke: Failed to read data from GPU (clEnqueueReadBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
ERROR: TfLiteGpuDelegate Invoke: Failed to upload data to GPU (clEnqueueWriteBuffer) - Execution status error for events in wait list
ERROR: Node number 334 (TfLiteGpuDelegateV2) failed to invoke.
count=138 first=73906 curr=1840 min=1414 max=73906 avg=3142.52 std=6057

Please help me to resolve this issue

Can you specify more details about what device you are trying this on? are you using a standard model?

Is it possible to share the model?

@aselle @impjdi I am using a standard model. My model contain Conv2D=>InstanceNorm=>relu. The problem is coming from instancenorm implementation.
InstanceNorm is implemented with combination of operators since Tensorflow doesn't have a single operator for this.
I have used Matmul to implement the reduce_mean to calculate Mean and Variance part of InstanceNorm.
I am running on mobile phone using tflite GPU. Tflite CPU its working fine

I am also sharing the part of the model with I am facing the problem. Please help me to find the reason for the issue and any alternative solution?
conv2d-instancenorm-relu.zip

Thank you for the network.  I forwarded the issue to our OpenCL specialist.

He has confirmed that https://github.com/tensorflow/tensorflow/files/4034657/conv2d-instancenorm-relu.zip works fine on his device.  What kind of device are you using?

@impjdi Thanks for your reply.
I am trying to run this on mobile device Honor20. Could you also please let me know in which environment it works fine?

Same on LG Nexus 5X
Running posenet_mobilenet_v1_100_257x257_multi_kpt_stripped.tflite downloaded from the tensorflow lite webpage just days ago.
With CPU it works pefectly fine
 java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: OpenCL library not loaded - dlopen failed: library "libOpenCL-pixel.so" not found
    Falling back to OpenGL
    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:171)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:275)

@joyalbin Apologies, forgot to follow up on this.  He usually tests it on a variety of phones.  I don't think we have Honor20 in particular but definitely have Kirin devices.  Is this now resolved or shall I ping him again?

@nerdaliciousCH the way I read the code is that you are supplying an external SSBO for inference, but it has wrong dimensions, i.e. not 257x257x3.

@nerdaliciousCH the way I read the message is that you are supplying an external SSBO for inference, but it has wrong dimensions, i.e. not 257x257x3.

So I use Android with Java and used the GpuDelegate provided by the tensorflow2 packages. When I don't add the delegate to the Intepreter and run on CPU alone (i.e. nlt providing any executor delegates), it works well. I have no code that is adapted to the device type besides when I create the tensorflow interpreter.
Do I have to create the input buffers differently when running on GPU? What struck me as odd is the OpenCL related part of the Exception. Could the size error be a consequence of that somewhere downstream the call stack?

@nerdaliciousCH

Do I have to create the input buffers differently when running on GPU?
No, you don't have to create the input buffers differently.  In fact, it should be just the same.
What struck me as odd is the OpenCL related part of the Exception.
Don't worry about OpenCL.  It's just a "FYI" message.
Could the size error be a consequence of that somewhere downstream the call stack?
Maybe, but it's hard to tell without seeing the code.  Are you calling interpreter->ResizeInputTensors at one point?

Hi. I also have a basic CNN model that is crashing with a similar error only when using GPU delegate (Runs fine on CPU and with NNAPI Delegate).
Strangely it only crashes on the Samsung S9 (Android 10) with a Exynos 9810. It doesn't crash on any other device that I have tested (Kirin and Snapdragon). I am using the Java TFLite API.
Here's a link to the model: link
Here's the error message:
2020-03-04 09:34:06.950 16795-16795/com.test.app E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.test.app, PID: 16795
    java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: TfLiteGpuDelegate Invoke: Failed to read data from GPU (clEnqueueReadBuffer) - Execution status error for events in wait list
    Node number 8 (TfLiteGpuDelegateV2) failed to invoke.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:154)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:314)
        at org.tensorflow.lite.Interpreter.run(Interpreter.java:275)

@impjdi
No resizing tensors in my code :(

@bilalsoomro Please sync to the latest git commit and try it out.  A fix should have been submitted.

Hi @impjdi, the latest build has fixed the issue.

Hello, have the same issue. All works fine on different devices except of Samsung. Model S730FM.
Exynos 7 Octa (Exynos 7870)
GPU - Mali-T830
Tried on different gpus: Adreno 615, Adreno 508, Adreno 509, Mali - G72, Adreno 540. Works well.
Tensorflow 2.3.0
 something went wrong: Internal error: Failed to run on the given Interpreter: Following operations are not supported by GPU delegate:     SUM: Operation is not supported.     226 operations will run on the GPU, and the remaining 103 operations will run on the CPU.     TfLiteGpuDelegate Invoke: Failed to clEnqueueNDRangeKernel - Out of resources     Node number 329 (TfLiteGpuDelegateV2) failed to invoke.
When i run on cpu without gpu delegate all code works well.
If anyone have idea how to handle it? Maybe there is some trick how to understand that gpu not support operations without running inference? If there a possibility check gpu compatability ?
According to this articles, Mali-T830 does'nt have support of opencl 2.0. Looks like possible reason of this behaviour.
https://en.wikipedia.org/wiki/Mali_(GPU)
https://en.wikipedia.org/wiki/Adreno

Same on LG Nexus 5X
Running posenet_mobilenet_v1_100_257x257_multi_kpt_stripped.tflite downloaded from the tensorflow lite webpage just days ago.
With CPU it works pefectly fine
 java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: OpenCL library not loaded - dlopen failed: library "libOpenCL-pixel.so" not found
    Falling back to OpenGL
    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:171)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:275)

java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: OpenCL library not loaded - dlopen failed: library "libOpenCL-pixel.so" not found Falling back to OpenGL TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size. Node number 237 (TfLiteGpuDelegateV2) failed to invoke.
I'm facing the same error on Pixel 2 XL (Android 11).
Actually, it was working fine with Android 10 on the same device but getting the same mentioned issue when I updated it to Android 11.
I'm using the following libraries for tensoreflow:
org.tensorflow:tensorflow-lite:2.0.0
org.tensorflow:tensorflow-lite-gpu:2.0.0
Is anyone got success to get rid of this issue? @nerdaliciousCH

Hi guys, I'm getting the same error in a new model that I'm testing in Huawei P10 Lite LX1A. In Samsung S9 it worked fine.
The P10 Lite has a Mali-T830 GPU, like @OleksandrGrument mentioned above. I'm also running with Tensorflow 2.3.0

This thread is diluted with multiple reports.  Can I get a TFLite model that reproduces this?  We'll see whether we have a Mali-T830 device at hand.  (FYI Due to COVID-19 closed offices, we don't have access to the devices anymore and may not be able to try out that particular (or a similar) device.)

This thread is diluted with multiple reports.  Can I get a TFLite model that reproduces this?  We'll see whether we have a Mali-T830 device at hand.  (FYI Due to COVID-19 closed offices, we don't have access to the devices anymore and may not be able to try out that particular (or a similar) device.)

@impjdi , here it is. Thank you in advance

@impjdi , here it is. Thank you in advance

@tgpsantos I've verified that your model works fine on a Pixel 4 OpenGL and OpenCL.  I'll ping the team whether anyone can reproduce this on any of their machines they have.

@tgpsantos I've verified that your model works fine on a Pixel 4 OpenGL and OpenCL.  I'll ping the team whether anyone can reproduce this on any of their machines they have.

@tgpsantos A teammate ran your model on a Huawei P9 (Mali T880MP4) and it worked fine, matching the CPU output.  Can you sync to the latest master branch and double-check?

@tgpsantos A teammate ran your model on a Huawei P9 (Mali T880MP4) and it worked fine, matching the CPU output.  Can you sync to the latest master branch and double-check?

Updated to from 2.3.0 to 2.4.0 and problem was solved. :) Thank you @impjdi and the team.
PS: I had no idea there was a new tflite release. Are they in-sync with python TF releases? If not, where can I learn about new releases?

Updated to from 2.3.0 to 2.4.0 and problem was solved. :) Thank you @impjdi and the team.
PS: I had no idea there was a new tflite release. Are they in-sync with python TF releases? If not, where can I learn about new releases?

TFLite GPU team is not really familiar with the different TF releases really; we work with the master branch's latest code only.

TFLite GPU team is not really familiar with the different TF releases really; we work with the master branch's latest code only.

Same on LG Nexus 5X
Running posenet_mobilenet_v1_100_257x257_multi_kpt_stripped.tflite downloaded from the tensorflow lite webpage just days ago.
With CPU it works pefectly fine
 java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: OpenCL library not loaded - dlopen failed: library "libOpenCL-pixel.so" not found
    Falling back to OpenGL
    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

    TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size.
    Node number 31 (TfLiteGpuDelegateV2) failed to invoke.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:171)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:275)

java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: OpenCL library not loaded - dlopen failed: library "libOpenCL-pixel.so" not found Falling back to OpenGL TfLiteGpuDelegate Invoke: ToTensorConverter: input data size does not match expected size. Node number 237 (TfLiteGpuDelegateV2) failed to invoke.
I'm facing the same error on Pixel 2 XL (Android 11).
Actually, it was working fine with Android 10 on the same device but getting the same mentioned issue when I updated it to Android 11.
I'm using the following libraries for tensoreflow:
org.tensorflow:tensorflow-lite:2.0.0
org.tensorflow:tensorflow-lite-gpu:2.0.0
Is anyone got success to get rid of this issue? @nerdaliciousCH @impjdi

Hi there,
I was experiencing the same issue with the following configuration:
OnePlus One
Adreno 330
Android 10
org.tensorflow:tensorflow-lite:2.4.0
org.tensorflow:tensorflow-lite-gpu:2.4.0
I downgrade to 2.1.0 and worked

I have the same error, but cannot update to newer TF version as I've made modifications and aren't compatible to the newer branch.
Can you share the difference between the two branches (2.3.0 & 2.4.0) that fix this error, maybe I could incorporate them in my version?
thnx

@hamlatzis @walterdumba Can you guys check with the latest versions of tensorflow and see if the issue still persists. Thanks!

Hi @joyalbin !
Could you check with TF lite 2.9/2.10/nightly version. There has lot of bug fixes in Tensorflow and TF Lite since 2.8 version.
Thank you!


feat: upgrade pulsar to 0.9 API

what's changed

add topologies
Pulsar supports three different cluster topologies, with two defined in clusterDefinition and one defined manually as creating the cluster:

pulsar-basic-cluster
Configured in the pulsar-cluster/values.yaml file
This cluster topology includes three components: broker, zookeeper and bookkeeper
pulsar-enhanced-cluster
Configured in the pulsar-cluster/values.yaml file
This cluster topology includes five components: broker, zookeeper, bookkeeper, proxy and bkrecovery
Unspecified topology (i.e. topology: nil)
In this case, you can individually configure the proxy.enabled and bkrecovery.enabled options
This cluster approach allows more flexible composition of the required components

replace clusterDefinition and clusterVersion with componentDefinition and componentVerison.
update Vars definition like serviceRef and service.

fix #686 as well.

@leon-inf @Y-Rookie May I ask you to review this pr for kb 0.9? After test, basic features are completed.

/cherry-pick release-0.9


Update Database

Successfully update the given database (for now use the provided test firesat database) using SPARQL Update.
Time estimate: 1D
Check story #12 for more details/context.

Matan completed this.


Http: Accept an optional type in json functions

Hi @orgads, thanks for the contribution! We generally just follow the community for these http types and none of them do this. Here's just one comment that explains why: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36868#issuecomment-512989650


feat: add module for package.json

farrow-schema has its subpath

farrow-schema/validator
farrow-schema/formatter

So exports in package.json will be needed.
If we need a real esm module in node.js, I prefer .mjs extension like what remesh do to(build.esm.js).
Note: Make sure it can run esm module in node.js natively.


Move react-dev-utils from devDependencies to dependencies

Motivation
hotfix https://github.com/facebook/Docusaurus/issues/697
Have you read the Contributing Guidelines on pull requests?
I did
Test Plan
https://github.com/facebook/Docusaurus/issues/697
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

I did this in #707 - thanks!!


Prettier / eslint: vue files

I think it would be cool to have prettier / eslint for all vue files
Probably related to https://github.com/jhipster/jhipster-vuejs/issues/597 and https://github.com/jhipster/jhipster-vuejs/pull/601

Yes, I will use the configuration created by vue-cli for eslint + prettier, so I guess it will be solved with that one.

@atomfrede Thanks for taking this and #597 on!


Re-add docs  and add samples for task based C# native modules

Offline discussion was that https://github.com/microsoft/react-native-windows-samples/pull/329 was the wrong change. We updated C# native modules to support Tasks, but samples still used ReactPromise. It was thought that docs were out of date, so docs were updated to refer to the old method used by samples instead of the other way around.

@dannyvv Any appetite for update the sample, or providing a snippet of what change needs to be made so we can put this up for someone else to act on?


Update electron to 1.6.18

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

This is a downgrade from the current version (2.0.0)
https://electronjs.org/releases


SOLR-16568: Update FasterXML Woodstox to 6.4.0

https://issues.apache.org/jira/browse/SOLR-16568

Description
The com.fasterxml.woodstox:woodstox-core dependency has 4 CVEs associated with v6.2.8:
CVE-2022-40156
CVE-2022-40155
CVE-2022-40154
CVE-2022-40153
Solution
Update the com.fasterxml.woodstox:woodstox-core dependency to 6.4.0 where there are no longer any vulnerabilities.
Tests
After running the existing tests, there is no need for any code changes for this upgraded version of woodstox.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Thanks @kiratraynor - the change looks good. I think the only thing this is missing is a solr/CHANGES.txt entry. I can add one or you can add one if you want.

@risdenk Thanks for the reply! I'm updating the solr/CHANGES.txt file now, adding the change to the 'Other Changes Section'. Let me know if this is incorrect.


Add offsets in user_regs_struct from sys/reg.h

@bors: r+

:pushpin: Commit db4273e has been approved by alexcrichton

:hourglass: Testing commit db4273ea2c2c867dfdd770760a188421e17c39ec with merge 8957530f81a986e296d4a3feb716e25c73bee748...

:broken_heart: Test failed - status-travis

I had to add sys/reg.h to libc-test/build.rs. Hopefully this will pass all the tests right now.

@bors: r+

:pushpin: Commit 1535ee8 has been approved by alexcrichton

:hourglass: Testing commit 1535ee87036f7d20ecec94dfc43fb9f633be78d7 with merge 46269c0cac8bf6ec3312344210334f6c2156a268...

@bors: retry

:hourglass: Testing commit 1535ee87036f7d20ecec94dfc43fb9f633be78d7 with merge 0c0d1bbe4ec3496d3903f53f35ea5cb2ed67deb5...

@bors: retry

It seems that sys/reg.h is only on x86 and x86_64. Restricted cfg.header to those platforms

@bors: r+

:pushpin: Commit 37b4e73 has been approved by alexcrichton

:hourglass: Testing commit 37b4e73a1035940a228bc7b3241eb516cf362125 with merge fb8ba53e32ac49f754f496946afcb3f90020b867...

:broken_heart: Test failed - status-appveyor

@bors: retry
On Jul 21, 2017 6:08 PM, "bors"<EMAIL_ADDRESS>wrote:

💔 Test failed - status-appveyor
https://ci.appveyor.com/project/rust-lang-libs/libc/build/1.0.982
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/libc/pull/686#issuecomment-317132441, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95GD5RmrFmfsVIkkZOJr-zkx7Fg2iks5sQS98gaJpZM4OfF32
.

:hourglass: Testing commit 37b4e73a1035940a228bc7b3241eb516cf362125 with merge cd325b1f0c67740d7ef9652f730946e416a59a82...

:broken_heart: Test failed - status-appveyor

Oh, there was no flag defined for x86. Fixed that.

@bors: r+

:pushpin: Commit 2a59767 has been approved by alexcrichton

:hourglass: Testing commit 2a5976727f841970ba4efcf6ec775ee1197e8f37 with merge b7a138bf10554a4e10338c95d79cf350969078be...

:broken_heart: Test failed - status-travis

@bors: retry
On Sat, Jul 22, 2017 at 11:23 AM, bors<EMAIL_ADDRESS>wrote:

💔 Test failed - status-travis
https://travis-ci.org/rust-lang/libc/builds/256396569?utm_source=github_status&utm_medium=notification
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/libc/pull/686#issuecomment-317194157, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KNM5G0_uKyIAFfKig6CvwHyf3ETks5sQiIagaJpZM4OfF32
.

:hourglass: Testing commit 2a5976727f841970ba4efcf6ec775ee1197e8f37 with merge 80947a362f665407e283913d2f5f86d801ea35b6...

:broken_heart: Test failed - status-travis

@bors: retry
On Sat, Jul 22, 2017 at 11:51 AM, bors<EMAIL_ADDRESS>wrote:

💔 Test failed - status-travis
https://travis-ci.org/rust-lang/libc/builds/256400980?utm_source=github_status&utm_medium=notification
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/libc/pull/686#issuecomment-317195725, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95J1qpiNTg5S51-2enguYcWZ2TmK8ks5sQih1gaJpZM4OfF32
.

:hourglass: Testing commit 2a5976727f841970ba4efcf6ec775ee1197e8f37 with merge 9bbfe4b0ee7cabd0455a1429c2fb37d6a7ef86fb...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9bbfe4b0ee7cabd0455a1429c2fb37d6a7ef86fb to master...

What about making a new release? I guess we'll need this in nix-rust/nix#666

Sure, instructions are in the README


SearchView popup not to be opened on tap

Currently, search View popup is opened on tap. Removed it so that user can call it from python instead.

Summary by Sourcery
Removed the automatic opening of the search view on tap, allowing users to control this behavior from Python instead.

Don't you think it should be the default behavior?

I think it should be decided by developer on Python side.

I think it should be decided by developer on Python side.

Ok, we could do it like that...


Placeholders matching must work if RouteIsCaseSensitive = false

Fixes / New Feature #2209
Proposed Changes

We are now performing case-insensitive matching for the path pattern, but we preserve the case for the placeholders. The verification of case sensitivity is not handled in this part of the code.
Adding several unit and acceptance tests to verify the behavior

@raman-m ready for review

@ggnaegi  Regarding the merged commit https://github.com/ThreeMammals/Ocelot/commit/fe029eb0d574ee8ec9d91618b5fa2023966f40b6, there has been an override of the name/title of the PR. The significant issue is the lack of reference to the fixed bug. In the future, please maintain the original commit name while prefixing it with the reference to the issue:
- Fixing issue 2209, adding extensive set of unit and acceptance tests (#2210)
+ #2209 Placeholders matching must work if RouteIsCaseSensitive = false (#2210)

As an Administrator, I will now proceed to rectify the commit name...

New commit in develop is https://github.com/ThreeMammals/Ocelot/commit/d41f8fa9436ba984ca12503bc9bd3be1db51d7de ❕


Global sum/prod memoization. Improves performance significantly on some ...

...global compiler benchmarks I tried.
I haven't tried enough examples to see if this is a good idea in general. I'm pushing this for future reference.

Not a bad idea. It is yet another memory leak. But, it is likely to be useful in general.

This is not correct. It uses the sam memo-table regardless of the function f.

I think it should be fine. The table is created only after f and zero are fixed:
let sum_generalized f zero =
  let tbl : (int * int, int) H.t = H.create () in
  ...

In particular, let sum = sum_generalized R.sum R.zero and let prod = sum_generalized R.prod R.one should have their own tables.

Ah, you're closed over particular definition of f and zero. Yes, this should work fine. We might have to update the local compiler a little to use it to full effect.

Obsolete as of https://github.com/frenetic-lang/frenetic/pull/453


Fix LZO decompression

Fixes https://github.com/fox-it/dissect.squashfs/issues/11

Would it be an idea to add some comments about which instruction encoding is used?
Including the first byte encodings

You seem to understand the algorithm better than me by now so feel free to make some suggestions 😄


intersect-gt-and-pred.py

Hi,
I follow your tutorial exactly, and when I run the main.py in mAP folder like below:
python main.py --output results_yolov4_tf，
I get:
Error. File not found: predicted/20.txt
You can avoid this error message by running extra/intersect-gt-and-pred.py
but there is no intersect-gt-and-pred.py file in extra.
I wonder where I'm wrong

@zcdliuwei i updated intersect-gt-and-pred.py in extra folder. u can pull newest code

@zcdliuwei i updated intersect-gt-and-pred.py in extra folder. u can pull newest code

Amazing ！！


MSB3073: The command "node scripts/run-pnpm-script "" build" exited with code -1. (OSOE-593)

Here's an example of the error:
https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/4388557195/jobs/7685183926#step:6:114
The cause of the error seems to be a missing script in the .bin folder of the Node.js Extensions NPM package installation, which in case of OSOCE is e.g. C:\Projects\Lombiq\Osoce\node_modules.nx\node_modules.bin.
The specific missing script varies. In the above build, postcss was missing, but there have been builds where sass was missing instead.
What to do
We need to investigate why pnpm install does not create these scripts properly at the given location. And then, we'll have to fix it.
Jira issue

Is this another random error that breaks the build?

Unfortunately, yes.

Isn't this a bug introduced by https://github.com/Lombiq/Orchard-Training-Demo-Module/issues/108?

Yes. We've fixed a similar bug there, though, and the original one still persists.

This was just a drive-by fix for a similar error - reopening.


Feat: add some helper to Info, like GetFooByName

Feat: add some useful helper to Info, like GetFooByName

add GetChannelByName(channelName string) *Channel
add GetGroupByName(groupName string) *Group
add GetUserByName(userName string) []*User

re-implement these function for speedup:

GetUserByID(userID string) *User
GetGroupByID(groupID string) *Group
GetIMByID(imID string) *IM
GetBotByID(botID string) *Bot
GetChannelByID(channelID string) *Channel

very unlikely to merge this.
these can all by implemented using a Reduce function for the different structures and is far less complicated and more flexible. ~ 10 lines of code per type.

@flw-cn I stand corrected, I was thinking of the https://api.slack.com/methods/users.lookupByEmail which is not lookup by username.
regarding the reduce functionality here is an example of a before (your code) and what I am suggesting:
// GetUserByName retrieves user(maybe more than one) information by user name
func (info *Info) GetUserByName(userName string) []*User {
	if info.name2user == nil {
		info.name2user = make(map[string][]*User, 32)
	} else if list := info.name2user[userName]; list != nil {
		return list
	}

	for i, user := range info.Users {
		info.name2user[user.Name] = append(info.name2user[user.Name], &info.Users[i])
	}

	return info.name2user[userName]
}

SelectUserBy(users []User, pred func(User) bool) (results []User) {
  for _, u := range users {
    if !pred(u) {
      continue
    }

   results = append(results, u)
  }
}

filtered := SelectUserBy(info.Users, UserByName)

the map you're creating by default is pretty memory intensive for larger teams and Info is being deprecated by slack because its costly to build. creating it by default is a bad choice and should be left up to the users of the library to decide if they want that sort of behaviour.

@james-lawrence Thank you for your patience!
I am beginning to agree with you a bit, that is, if the library is considered to be a simple slack API, then indeed possible to put that extra works on the user side.
As we discussed, the slack API does not provide users.lookupByName, channels.lookupByName and groups.lookupByName, so the library user has no choice but to send a message via slack.Client.SendMessage("CABCDEFGH", ...) instead of slack.Client.SendMessage("#topic", ...). user and group are similar to that.
So let's stand on the user's side, what is the easiest way to send a channel message?
Worse, we can't get a channel ID from Slack UI simply. So we must store that maps by myself. This means that we must wrap another layer base on the Slack API, which goes against the principle of out of the box.
I admit that my code doesn't look so neat, and the naming is a bit ugly, but it solves the problem and makes it easy for users to send and logging messages.
As for the memory waste you mentioned, because I use pointers instead of replicas, the added maps should not consume too much memory.
On the other hand, because of the existence of the maps, the time wasted by for range is reduced, so there is a saving in time. This is also in line with the principle of used space to exchange time.
Is this any propose to improve it and leading it possible to merge into the repository? I hope to hear from you.

closing due to age, and lack of activity.


FlatButton hover color is compatible with material design

The color theme seems not comply with material design, the hoverColor should be grey instead of lighter pink for primary theme.
I read the google spec again. The material-ui does comply with it. However, most implementation including google's own MDL use grey instead of color for hover effect. And color background hover looks not that good. So please consider. Thank you

Hi @jma7889 - fixed in #2488.


Ability to control going in and out of fullscreen

Is your feature request related to a problem?
It seems all actions such as play, mute, ... have been exposed but not fullscreen.
What solution would you like?
Maybe something like that?
youTubePlayer.toggleFullscreen
youTubePlayer.isFullscreen
configuration {
autoFullscreen: true
}
What alternatives have you considered?
If I use my own Swift view with a UIViewRepresentable WKWebView loading the video URL automatically goes to fullscreen.
Any additional context?
No response

Hi @kiddosai,
Unfortunately, there is no API for programmatically launching full-screen mode in either WebKit or the YouTube Player iFrame JS API.


Provide R2DBC-based Executor

Description
It would be great if we could use R2DBC as an execution engine which is the reactive alternative to JDBC.
The motivation behind this ticket is that applications using reactive programming require non-blocking drivers for a SQL database integration. Although most Liquibase integrations run migrations during startup, a fully reactive application does not want to pull in JDBC drivers for the sole reason of bootstrapping and configure another integration but rather wants to reuse the already configured R2DBC connection.
R2DBC is a specification initiative providing a standardized SPI for drivers and a vendor-independent interface similar to JDBC.
Right now, the following drivers are available:
H2

Postgres

Microsoft SQL Server

MySQL

More to come

Resources:
Javadoc: http://r2dbc.io/spec

Environment
Reactive Programming
Original
https://liquibase.jira.com/browse/CORE-3419
┆Issue is synchronized with this Jira Bug by Unito

Thanks @ladyka  for writing up this issue.  It's hacktoberfest so if you or someone you know would like to create the enhancement during this month that would be great!

Hey,
I was wondering if any thoughts had gone into this?
Having a look I think this may cause some breaking changes to the library as I think a few abstractions would need to be made as the setup is AbstractJdbcDatabase implements Database and ideally I would think we would need some AbstractDatabase class. The other issue I see is so many of these classes require the concrete JdbcConnection so is this class worth abstracting between the R2DBC and the JDBC.
I have an intrest in Postgres so was looking to make a ReactivePostgresDatabase implementation,

For a PR would you accept just a single implementation?
Would you need to dicuss the architecture before the PR?

Thanks


Configurable receiver max volume

For the volume range, some receivers use 0-80, some 0-100, and some 0-200 (displayed as 0-100 in 0.5 increments).
Allow the user to select this at config time, in the absence of some mapping by receiver model.

I'll start over based on the latest core integration and will add hardcoded mappings. Therefore, I'll close this.


 The missing symbols in the .a are most likely from the various flang support libraries that come in addition to libflang itself (these probably did not exist in earlier versions of LLVM yet)

Thanks @martin-frbg. Btw, to clarify: this is not about the upcoming F18 flang compiler which recently was merged to llvm master, but the deprecated (but unlike F18 functional) old version.
Which lines in exports/Makefile are you referring to? I'm not able to find ifort in that file.

https://github.com/xianyi/OpenBLAS/blob/430e8b45fe9b2ad6aae35912fbccc74dc74b2104/exports/Makefile#L153-L157
and perhaps the changes from my very recent PR #2647 apply to all current versions of flang and not just its AMD fork - LAPACK certainly needs to be built with -frecursive, and I had to drop the
flang optimization level to -O1 to make all tests in test/ctest pass.
(And if flang does not support OMP DEPEND, it probably should not advertise OpenMP 4.0 capability - these have been "#if defined(_OPENMP) &&  _OPENMP >= 201307L" for quite some time in OpenBLAS. Though I suspect flang will just do the same i.e. ignore the "TASK DEPEND" section, even if the ifdef condition is not met)

Thank you @martin-frbg. I opened a PR adding a flang compilation step to Github Actions that reproduces the test failures (first commit) and tries your suggestion of enforcing O1 (second commit).
One side-question: Is it possible to configure the build to fail once FATAL ERROR - COMPUTED RESULT IS LESS THAN HALF ACCURATE occurs for one of the tests?

IIRC for the level 2 and 3 BLAS tests you can change a flag in the header of the respective input file (sblat2.dat etc) to stop on error. The alterative would be to grep the output files (the .SUMM), I think the cmake build already does this to be able to flag the error in the build log. These tests are copied from Reference-LAPACK and it is usually more interesting to know all the failing tests rather than just that at least one of them failed.

Makefile build is definitely fixed by changing the "FLANG_VENDOR==AOCC" conditional in #2647 to a generalized "F_COMPILER==FLANG", in CMAKE builds the issue is probably masked by not setting an optimization level (unless -DCMAKE_BUILD_TYPE=Release is specified). Will test this later today.

BTW, is this issue related to the old LLVM Fortran frontend, or the new one (F18) that actually got merged into LLVM trunk recently?

Old frontend i.e. original flang project. If the f18 frontend goes by the name "flang" as well we will probably need to differentiate by version number. (I do not recall seeing it mentioned in the LLVM10
release announcement, and have not tried building the very latest from their git)

@Diazonium afaik the new f18 can't generate binaries yet, but only parse Fortran code. Not sure if it'd be ready by llvm 11 or later.

@martin-frbg is it possible that similar to https://github.com/flang-compiler/flang/issues/630 flang contains "correct" optimizations and OpenBLAS fortran code is buggy (causing the test failures)? Or do you think this is a bug in flang? If so, I'll open an issue in flang about the failing tests with O2 / O3.

The fortran code in question is a direct copy of Reference-LAPACK (a.k.a "netlib LAPACK") and compiles fine with other compilers, so I'd think at best flang would have to be extra strict in its interpretation of the standard.

Thank you for clarifying. I opened https://github.com/flang-compiler/flang/issues/905

Possibly a duplicate of their issue 599 (where it was suggested to add -Kieee to the compiler options)

Interestingly these BLAS tests pass in a pure Reference-LAPACK build, so it is probably something related to argument passing between fortran and C functions (reference being all fortran)

Actually this is now looking like some weird precision problem or a glitch in the comparison function, at least all of the tests that are failed for being "less than half accurate" show identical numbers in the "expected" and "computed" results printed. (Granted they are printed to limited precision, but I'd expect at least some of them to be way off the mark if the failure was real)

Possibly just the calculation of the machine precision going wrong - OpenBLAS still has BLAS tests from version ~ 3.5.0 of the reference BLAS with an ad-hoc calculation of epsilon while current reference implementation uses the f90 epsilon intrinsic

Worse yet, running the LAPACK testsuite (make lapack-test) as opposed to just the BLAS and CBLAS tests goes completely haywire on Ryzen3900 at least with the AOCC flavor of clang/flang - lots of test failures and segmentation faults, ultimately culminating in an infinite loop in the single-precision complex tests. A mixed gcc+flang build fails in the same way while clang+gfortran works. Still need to rerun the test with flang20190329

@martin-frbg are these lapack-test issues with -O1 or -O2?

O1, but I expect they will also be present at -O2.

Dropping flang optimization level to O0 rather than just O1 works around this (and the ctest failures as well). Not sure if this can be narrowed down to a specific subset of optimizations as my current understanding is that clang/flang has less fine-grained options than gcc/gfortran.

Meh. Half of the options on that list appear to be invalid with or without -llvm prepended and there does not appear to be an actual document of which is currently switched on at what level on the llvm website.

IMO, it is OK to have a "Known issues:" section in the release notes. If this is not readily fixable, or looks like a compiler bug, then perhaps it is not worth chasing the issue before 0.3.10.
Unless the bug was introduced recently, this went unreported for a very long time, suggesting that very few people actually use flang/AOCC-flang to compile OpenBLAS.
If a fix is found before 0.3.11, great, but in the long term flang will be eventually (LLVM 11? 12?) replaced with f18, which should be much better supported.
IMO 0.3.10 is already packed with many fixes and improvements, at some point a line should be drawn, and unsolved issues should go into a "Known issues" section of the release notes (as long as they are not regressions), instead of holding up the release

lapack-test is back to normal at -O1 after correcting the -frecursive to -Mrecursive and adding -Kieee
At  -O2 however a significant number (2700 each) of the LAPACK complex and double-complex tests fail  with a spurious parameter #4 had an illegal value error on entry to CLASCL/ZLASCL

Latest in this saga is that with -Mrecursive and -Kieee added it is only AOCC going wrong after all, and adding -fno-unroll-loops to its options makes it pass the lapack tests at -O2 as well.


File extensions menu

Hello,
under macOS, how do you display the file extensions menu, like on the following screenshot:

Thanks for your help.
S.

This is not supported.  I am still open to a PR that adds this. Relevant issue is https://github.com/mlabbe/nativefiledialog/issues/45

This is not supported.  I am still open to a PR that adds this. Relevant issue is https://github.com/mlabbe/nativefiledialog/issues/45

Thanks !

Thanks !


Unique and better naming for the apps

Reviews have been addressed and branch rebased + lock file regenerated.


remove duplicates of default registry dir implementations

extract DefaultRegistryDir into the separate package, so that it could be used /runtime/perfetto
btw, there is a possible bug if the storage folder has not cleaned up registry files, then status metrics and dashboard commands will fail to attempt to connect to not accepting port with the error:
Get "http://<IP_ADDRESS>:56018/debug/serviceweaver/status": dial tcp <IP_ADDRESS>:56018: connectex: No connection could be made because the target machine actively refused it.

and won't continue to the next service running
P.S. naming is hard, so open to suggestions of package names. Separate package due to import loop.

@spetrovic77 changes applied

GitHub says this branch is out-of-date with the base branch. Mind rebasing on top of main?

GitHub says this branch is out-of-date with the base branch. Mind rebasing on top of main?

Op, actually I realize I can do this on your behalf :) I'll merge this PR in just a sec.


permission at runtime

i am trying to solve a problem at runtime with getting access to items like the GPS location from the background task.
i get an exption that tells me i do not have permission but the app and the manifest are setup to handle this.
is the package running the background task as an isolated process or thread that needs its own grant ?
here is an error:
canAccessCellLocation: uid 10287 does not have android.permission.ACCESS_COARSE_LOCATION.
i did not have this error untill i used this package. if i run the same code other ways it works.

can you provide sa sample code, so we can investigate this?


Feature

Is your feature request related to a problem? Please describe

Describe the solution you'd like
It is better to improve the borders of the main division where the sub-division circuits information is visible to highlight the text area properly.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

Hi @Simer13 , please give a proper title and if you want to do UI changes, add your proposed design (figma link) in issue description


ecdsa-multikey v1.0.0

Version 1.0.0 of ecdsa-multikey:

Implementation of ECDSA key pair generation with curves P-256, P-384, and P-521
Implementation of ECDSA sign and verify methods
Tests for ECDSA key pair generation with curves P-256, P-384, and P-521
Tests for ECDSA sign and verify methods

@dlongley Can you please merge and release.


[Service Bus] Tests for token provider and AAD

Service Bus SDK allows user to authenticate in 3 ways

using connectionstring
using user provided token provider
using AAD

Our tests use the first method, so that is covered.
But we need tests for the other 2 methods. If not both, then atlease the AAD

@ramya-rao-a
Closing this with #1202 ?


certConf_cb

OpenSSL doesn't use this style of capitalization.  It should be "certconf" or "cert_conf" not "certConf"

[ahem] Openssl is quite mixed re naming styles... Just sayin'
EVP_DigestSignInit...

Can you find another one where the first letter of a multi-word thing is downcased?  Like I said, CertConf is better than initial lower-case.
Yes it has a mix of naming styles.  Don't add another.

I just grepped for it, to see what it is about (CMP). It's an ASN.1 field name, taken directly from RFC 4210, and I can understand why it was done this way, as it makes it easier to relate code directly to the standard. This isn't new, look at struct rsa_pss_params_st in include/openssl/rsa.h for an example that's been around for a while.

If we do make a policy on this, I think we do need to factor in the relationship with the standards that are put into code.

Ping @DDvO. Do we need to do anything here? Adding this to the 3.0 beta1 mileston because it has an API impact if we make a change.

I was not aware of this thread - good that @mattcaswell pinged me.
As mentioned during the contribution phase of the CMP chunks,
and as independently discovered by @levitte the camelCase of certConf_cb and various other such names
stems from the name conventions  in RFC 4210 etc. and have been retained for consistency with the standard.
So I suggest resolving this as  "not a bug" or "wont fix".

Seems like a reasonable answer.

This sounds like a slippery slope to me.
I would prefer them to use the standard naming convention and then have a comment that ties it back to the standards.

If the name certConf_cb is considered a bug then we have thousands of "bugs" in the code base
where names do not follow the (incomplete and patrly not very clear) coding guideline rules.
See also #10725.
BTW, util/check-format.pl so far only does very little checking on variable names
(it just reports the graphically very confusing single-letter names l, I, and O).

This sounds like a slippery slope to me.
I would prefer them to use the standard naming convention and then have a comment that ties it back to the standards.

IMO certConf_cb does not violate the present coding guideline - it says:

Except when otherwise required, avoid mixed-case names.

As mentioned there are many symbols in OpenSSL for which the same holds,
and just recently I came across several of them in include/openssl/x590.h:
int X509_CRL_set1_lastUpdate(X509_CRL *x, const ASN1_TIME *tm);
int X509_CRL_set1_nextUpdate(X509_CRL *x, const ASN1_TIME *tm);
const ASN1_TIME *X509_CRL_get0_lastUpdate(const X509_CRL *crl);
const ASN1_TIME *X509_CRL_get0_nextUpdate(const X509_CRL *crl);

int X509_set_serialNumber(X509 *x, ASN1_INTEGER *serial);
ASN1_INTEGER *X509_get_serialNumber(X509 *x);
const ASN1_INTEGER *X509_get0_serialNumber(const X509 *x);

const ASN1_TIME * X509_get0_notBefore(const X509 *x);
ASN1_TIME *X509_getm_notBefore(const X509 *x);
int X509_set1_notBefore(X509 *x, const ASN1_TIME *tm);
const ASN1_TIME *X509_get0_notAfter(const X509 *x);

So @mattcaswell and/or @slontis, I suggest again closing this as a non-bug.

I am going to close this.  If @slontis feels strongly then he should re-open it.)


[QUERY] Azure.ResourceManager.Communication v1 package is not visible in Nuget

Query/Question
How can we help?
Why Azure.ResourceManager.Communication 1.0.0 deprecated? I only see beta packages in Nuget.
Environment:

Name and version of the Library package used: Azure.ResourceManager.Communication 1.0.0
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): N/A
IDE and version : N/A

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

fixed


Require Java 8 and Jenkins 2.121.1, allow JDK 11 compile

Require Java 8 and Jenkins 2.121.1, allow JDK 11 compile
Just enough changes to allow Java 8, Java 11, and Jenkins 2.121.1.
Match with the changes made in git plugin 3.8.0 so that both git plugin and git client plugin require Java 8 and at least Jenkins 2.121.1, and they both can compile with Java 11.
Checklist

[x] I have read the CONTRIBUTING doc
[x] Unit tests pass locally with my changes
[x] I have added documentation as necessary
[x] No Javadoc warnings were introduced with my changes
[x] No findbugs warnings were introduced with my changes
[ ] I have interactively tested my changes

Types of changes

[x] Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

Submitted this pull request to the repository as a new branch.  Closing the pull request to the stable-2.7 branch because this pull request will be the basis for the 2.8.0 release of the plugin


Improve imdl torrent verify checks and output

[ ] show if files are present
[ ] show if files match piece hashes
[ ] show if md5sum matches
[ ] make sure the output isn't gross
[ ] show files in tree
[ ] show grid representing piece hash correctness
[ ] add color to output
[ ] show %/amount present, missing, and corrupted total and of each file
[ ] test output

[ ] report correct piece status if input files are too long
[ ] report correct piece status if input files are too short

Icons:

I/O error: !
Missing: ?
Not a file: ¿
MD5 mismatch: X
Too long: +
Too short: -
Good: ♡

Closing in favor of more specific issues.


Timex#to_naive_datetime/1 converts to UTC before creating a Naive Datetime

Hello,
I've just noticed that Timex#to_naive_datetime/1 converts the DateTime with a specific timezone to UTC before giving back a Naive DateTime.
Is this behaviour correct? If this behaviour is correct, I think this should be documented in the function documentation.
I can create a small PR to add this behaviour in the function documentation.
I originally expected the behaviour to just lose the time zone information before giving back a Naive DateTime.
Thanks!

This is something I intend to align with the standard library on, but due to backwards compatibility reasons I've left the legacy behaviour. The original intent way back was to try and make naive datetimes align with how people typically think about them (i.e. as a generalization, it was my observation that many people tend to assume that date/times without a timezone are UTC). In any case, the standard library behavior is more correct in this regard, so with Timex 4 I plan to break backwards compatibility there, barring significant pushback from users.
A PR improving the docs is always welcome!


after activating proxy always 'stop iteration'

Hi! As I posted in a previous issue, I am trying to obtain Google Scholar content through a proxy using your function 'use_proxy'. However, once I activate it, the other functionalities such as 'search_author', always return an empty iterator and this didn't happen before using the proxy with the same queries ...
I would appreciate any help.
Kind regards

If free proxies do not work, try using Tor instead:
sudo apt-get install -y tor
pip3 install -U PySocks

from scholarly import scholarly
# default values are shown below
proxies = {'http' : 'socks5://<IP_ADDRESS>:9050', 'https': 'socks5://<IP_ADDRESS>:9050'}
scholarly.use_proxy(**proxies)
# If proxy is correctly set up, the following runs through it
author = next(scholarly.search_author('Steven A Cholewiak'))
print(author)

Yes, free proxies didn't work, but I am able to use Tor as a proxy. Thank you.
Kinds regards


Error parsing magres file: po[R] is not a function

I've tried to load this magres file from the ccpnc database into MagresView2 and got the above error. The same file loads fine in MagresView1.  Could it be something to do with the way quantum espresso generates magres files?

It seems like the problem is caused by the blank lines inside the blocks. I can make the reader tolerant to them, though I'm not sure this is really following the magres file format specification. I'll fix this.

Should be fixed as of the latest commit; the Pages version is still building and uploading.


Raspberry Pi crashes when too much time has passed since the start of Open-CV stream.

A RAM problem maybe? Something gets stored in raspi's memory until it gets full, then, it crashes.

Turns out that the peer conection from the api didn't have 'receive only' mode activated. It was causing an error for some reason, where raspi's ram was getting full. Solved!


Support colspan

I'm pretty sure this will fall apart when people start using colspan (and rowspan) in this table...

On the other hand... in those pesky "tables as data structures" that wouldn't even be an alternative? 🤔

Fixed in e72f0f5bd5f9bda66cb6442343ae27963393db3b and 1573e26c6b78de2b85f1dba7aff0992af5e63b2f


Card features unable to save

While working on the Launchpad website. the photo cards feature will not save. This happens both when a picture is inserted and if you do not add a picture but just add text.

Site: https://pl-launchpad.vercel.app/admin#/collections/pages
I also put in an issue on the microgen repo: kinked here:

Fixed!


Access is denied error when saving/finishing battle

Upon finishing a battle or attempting a save, a pop-up indicating "Access is denied" will appear. In the latter scenario, it prevents the end user from saving their game entirely.

This is a game issue, not related to FFXVIFix. One workaround is turning off "Controlled folder access" in "Virus & threat protection"->"Ransomware protection".


Broken mobile build on windows?

I regularly build for android from a windows machine, and recently found this error on my build machine:
gomobile: go build -ldflags -w -trimpath -buildmode=c-shared -o C:\Users\corfe\AppData\Local\Temp\gomobile-work-312184635\lib\armeabi-v7a\libgo_.so goincremental failed: exit status 2
# pkg-config --cflags  -- gl gl
Package gl was not found in the pkg-config search path.
Perhaps you should add the directory containing `gl.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gl' found
Package gl was not found in the pkg-config search path.
Perhaps you should add the directory containing `gl.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gl' found
pkg-config: exit status 1

I checked various commits until I found this commit was the culprit (syncing before it, the problem goes away): https://github.com/hajimehoshi/ebiten/commit/75d34ab585a06ab2210ac1a9fee48c7bc1d914d0
I suspect file "internal/graphicsdriver/opengl/gl/package_x.go" isn't supposed to build on windows, but accidentally is.

Thanks.
package_x.go specified build tags and should not affect Windows, but let me check.

Reproduced this on my macOS.


Array fields seem to show something weird instead of parse objects

Cloud Code
I've got a class A which has field list of array type.
list is maintained by Cloud Code functions.
My function adds to list instances of Parse.User.
My function loads list in the following manner:
var q = new Parse.Query(A);
q.include("list");
q.find().then(...)

Sometimes, or more precisely for certain records, my function gets list filled with something other than Parse.User objects and, in turn, fails.
I'm used to get the errors like this:
Result: TypeError: Object #<Object> has no method 'getUsername'
Expected:
array fields should keep the Parse objects properly
Actual:
array field might keep something weird instead of the Parse object previously added and saved to the field.

Adjusted description.

@yaalaa can you give an example of one of the "weird" non Parse.User objects that gets returned in list?

{"objectId":"blablabla"} usually

Have you attempted to fix this invalid data? And if so do you see it again after querying? We had an issue with the beta dashboard data browser where some objects were getting changed to {"objectId":"someId"} but has since been fixed and was only with the web beta dashboard. We have not had any issues like this with the SDK.

Yep, I've just fixed arrays. No more invalid array for now, but.. maybe it's not over yet.
If you're interested of, I'd say the bad data was created about two weeks ago.
Glad to her the issue had already been fixed.
Will monitor my app's data for a while, of course.

@yaalaa that's good to hear. Feel free to open if you run into it again.

It has happened again.


Update location for Hanno

Just adding the correct location here for our own company, which we noticed somebody else has added.
This is a modified version of the Contributing Guidelines.
This pull request adheres to the repository's Code of Conduct

[x] This PR contains housekeeping (URL edits, copy changes etc)
[x] You know your alphabet - company is listed in alphabetical order in the README
[x] A company profile is included - Not essential but it really helps!
[x] The company directly hires employees - This may sounds odd but while awesome, this list is not for coding bootcamps, "teaching" positions a network (Teacher positions employed directly, such as Treehouse, are allowed), or networking sites for listing a CV looking for gigs
[x] The company added hires remote employees, or positions are available to remote workers and are clearly illustrated as such
[x] A company-profile has been included for each addition to the list
[x] I am an employee of the company mentioned and confirm all details are correct
[x] Remote status has details regarding how the culture includes remote employees, how the company integrated remote workers, etc
[x] Region details any restrictions to applicants based on geography
[x] How to apply details the best approach for new applications, link to open positions, and any other help available for job hunters
[x] Any missing parts from the profile, please use <Unknown> to allow for future completion

Hey @jonlay, you ticked all the boxes in the PR template but you don't have any company details listed, can you add a company-profile please? Thanks!

Hi @nylen, thanks for your contribution!
Our automated checks detected some problems with your pull request (as of commit eaa6a7b).  See below for details:
README.md: Broken link to company "Happy Bear Software": "/company-profiles/happybearsoftware.md"
happy-bear-software.md: No link to company profile from readme

2 problems detected

Please fix these issues and push a new commit to this pull request.

Hi @nylen, thanks for updating the pull request!  According to our automated checks, everything looks OK now (as of commit 9d5631d). :heavy_check_mark:


config: add migration team as tidb repo owners  to handle br package

ref https://github.com/pingcap/community/pull/620

@kennytm @zhangyangyu PTAL

/merge


Total number of tests executed and number of tests displayed in trx report are different . It seems after failure of one test case it does n't count further cases. Also the trx generated doesn't gets opened in visual studio

Attached the generated trx  and error screenshot after opening the trx in Visual Studio
Total Number of cases executed by vstest.console.exe

WHen trx opnened in Visual studio

Trx file which got generated.
uitestresults(1).zip
Specflow file generate and displayed the incorrect number of tests

Hey @akankshaaSaba,
Sorry, somehow I missed this issue. I'll try to take a look this weekend.
Is your codebase by any chance open source, so I can take a look at the tests?

Fixed in #9


Add example to QuickStart of how to get at logs

The title already is says it. The main purpose of this tool is to enable data collections, so the documentation should talk more about the logs — how to get them, and how to process them. Starting from the QuickStart page.

Added in ced0add00b2c66cef03751efc27e88b9e4d9e78e: https://clp-research.github.io/slurk/slurk_gettingstarted.html#examining-the-log-files


Update user study examples

Some things fell behind our changes:

things called 'bindings' just became inputs and outputs
Resource bindings moved into Runs
Clusters moved out of PipelineParams so there's probably no reason
to include PipelineParams here anymore.
The value field in a param in a Task was wrong, used to be
type, now it doesn't exist

/lgtm

YOUR APPROVAL MEANS NOTHING :angry:

noooooooo thats what i get for my snark :(

I1128 21:53:58.815] --- FAIL: TestHelmDeployPipelineRun (331.62s)
I1128 21:53:58.815] 	helm_task_test.go:175: Image to be pusblished: gcr.io/knative-boskos-04/kbuild-pipeline-e2e-img/go-helloworld-image-qahopvea
I1128 21:53:58.815] 	helm_task_test.go:141: Error from pinging service IP <IP_ADDRESS> : timed out waiting for the condition

noooes a flake!!

/test pull-knative-build-pipeline-integration-tests


chore: add --inspect-file-watcher for watcherService

Refs https://github.com/microsoft/vscode/issues/118613

Can I learn more about the rationale of this change? Why do we need to debug the watcher exactly?

When we get report of high cpu usage with file watcher, I don't have a way to get CPU profile.

@deepak1556 well at least for when chokidar is used the explanation is quite simple: chokidar does a full folder scan over all files and folders right on startup. The CPU should eventually settle though and not stay high. If it stays high, this would hint at slow polling being used which I think @aeschli is doing in remote, maybe he can clarify.

Thanks for the context!
For the cases with constant high cpu usage and is not remote scenario, what is usual flow of debugging ? I was mainly targeting this PR for those unknown scenarios.

@deepak1556 yeah for those cases we have no way of debugging, so we can use this change to create perf profiles I guess?

Yep thats correct


houdini vite plugin fail with latest sveltekit 2

Describe the bug
After creating fresh sveltekit project and initialize  houdini setup,  pnpm dev keep failing with error

pnpx create svelte@latest app
pnpx houdini@latest init

Note I have to change after init  as per kit upgrade docs
from
import { vitePreprocess } from '@sveltejs/kit/vite';

to
import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';

Severity
annoyance
Steps to Reproduce the Bug
vite dev

▲ [WARNING] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]

    tsconfig.json:2:15:
      2 │     "extends": "./.svelte-kit/tsconfig.json",
        ╵                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2:24:41 PM [vite-plugin-svelte] Your are using Svelte 5.0.0-next.26. Svelte 5 support is experimental, breaking changes can occur in any release until this notice is removed.
work in progress:
 - svelte-inspector is disabled until dev mode implements node to code mapping
 - hmr for .svelte files is disabled until hmr api is implemented

🎩 Generating runtime...
❌ failed to resolve "extends":"./.svelte-kit/tsconfig.json" in /Users/schintha/Developer/Work/SPA/temp/console3/tsconfig.json
error when starting dev server:
_TSConfckParseError: failed to resolve "extends":"./.svelte-kit/tsconfig.json" in /Users/aaa/Developer/Work/SPA/temp/console3/tsconfig.json
    at resolveExtends (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/vite@4.5.1/node_modules/vite/dist/node/chunks/dep-68d1a114.js:13660:9)
    at parseExtends (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/vite@4.5.1/node_modules/vite/dist/node/chunks/dep-68d1a114.js:13614:28)
    at parse$f (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/vite@4.5.1/node_modules/vite/dist/node/chunks/dep-68d1a114.js:13552:24)
    at async loadTsconfigJsonForFile (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/vite@4.5.1/node_modules/vite/dist/node/chunks/dep-68d1a114.js:14199:24)
    at async transformWithEsbuild (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/vite@4.5.1/node_modules/vite/dist/node/chunks/dep-68d1a114.js:13866:36)
    at async extract_load_function (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/houdini-svelte@1.2.34/node_modules/houdini-svelte/build/plugin-esm/index.js:172319:20)
    at async walk_routes (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/houdini-svelte@1.2.34/node_modules/houdini-svelte/build/plugin-esm/index.js:172558:41)
    at async svelteKitGenerator (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/houdini-svelte@1.2.34/node_modules/houdini-svelte/build/plugin-esm/index.js:173079:3)
    at async Promise.all (index 0)
    at async codegen_default (file:///Users/aaa/Developer/Work/SPA/temp/console3/node_modules/.pnpm/houdini-svelte@1.2.34/node_modules/houdini-svelte/build/plugin-esm/index.js:173647:3)
 ELIFECYCLE  Command failed with exit code 1.

Reproduction
No response

Workaround is to update the "dev" script to svelte-kit sync && vite dev, but would be great to have it fixed on the Houdini side.

@AlecAivazis  any plan to resolving this issue ?
without workaround:  svelte-kit sync && vite dev developers trying first time may struggle and face bad experience.
if there are any road blocks, may be we should document  this workaround.

I definitely plan on resolving it. My biggest hurdle right now is finding the time. if you have the time to explore a bit, let me know!

Just to update this issue with some conversations we've been having internally: since both of the bumps to support sveltekit 2 and svelte 5 will create major releases, we're going to wait until svelte 5 is ready before going to<EMAIL_ADDRESS>

Will Houdini 2 have any new features ?
I was thinking  SvelteKit 2 and and svelte 5 changes are unrelated, and would be big impact for migration

no<EMAIL_ADDRESS>will very likely be mostly version bumps. there might be some random clean up but we dont have anything major planned.
anyway, i'm going to close this ticket since #1300 and its related friends will use the latest sveltekit version


Use gitbook for docs

Reorganizing docs and displaying using gitbook. Eventual goal is be able to replace our github pages page with gitbook generated site.
ToDo:

[x] Setup page with details for each release (like we have for 0.4.9 on the wiki). Fill out relevant details back to at least 0.4.5
[x] Write more examples and docs for use of specific features, organize these in a folder so they can be pulled in in other locations by the gitbook
[x] Update the ui page with more recent screenshots
[x] Double check examples page and update to use an org repo
[x] One more pass over all docs to be sure everything is up to date (examples are working, etc)

if you want to view the current state of the docs, on this branch you can npm install -g gitbook and run gitbook serve. Docs should be available on localhost:4000

Good draft of this is done now, with a bunch of docs added for a few features, releases, updated ui images, etc. Let me know what you think

Some notes on this:

Changes to existing docs are just typo fixes, updating links, and a small bit of rewording. Most changes to the actual docs are additions of new docs
Created an intro.md which the gitbook uses at its landing page. This is almost the same as the README.md, but I wanted to have the flexibility of the gitbook homepage and README being different
Added a script that will build the latests swagger docs and split them up for the gitbook, build the gitbook, replace the favicon, and publish to gh-pages branch so that it is easy to update. This should only include the relevant files since the .bookignore excludes the actual source code


Updated project to be compatible with react-admin v3.2.

Dependencies upgraded.
Added KeyboardDateInput, KeyboardDateTimeInput and KeyboardTimeInput.
Docs updated.
Ported props from react-admin's DateInput component for consistency with the rest of react-admin input components.

@vascofg Are you planning to approve this PR? The current version 1.1.4 doesn't work with the last react-admin


wolfssl: fix hash

I decided to re-live my gentoo days, and have been trying to nixos-rebuild switch into nixos-22.11 without using substituters. WolfSSL fails to build because of a hash mismatch.
Description of changes
The previous hash corresponded to wolfssl-5.5.2, but it looks like everyone was getting cache hits on the built outputs and nobody noticed.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

wolfssl-diffs.txt
I was alarmed to see a hash mismatch on a security package, so I diffed and attached the old and new source derivations. The previous change to wolfssl was in f1f41c5da72593b9f69ffb894a1dbf238e059702, and indeed the version changes but the hash does not.

I was alarmed to see a hash mismatch on a security package, so I diffed and attached the old and new source derivations. The previous change to wolfssl was in https://github.com/NixOS/nixpkgs/commit/f1f41c5da72593b9f69ffb894a1dbf238e059702, and indeed the version changes but the hash does not.

The update 5.5.3 was incomplete.


Bug report: Generate PGP key pair operation doesn't work in standalone htm file.

Summary
When using CyberChef as single htm downloaded file, Generate PGP key pair operation doesn't work.
Example
When we click on Generate PGP key pair, it require helper file PGP.js which is not available.

Thanks for reporting this. I'll look into it.

It is now working in version 8.0.0s. This bug can be closed now.

Did this issue snook back in somewhere around 8.12.x?
https://github.com/mpepping/docker-cyberchef/issues/2


fix bugs for demo

Test plan - (Please fill in how you tested your changes)
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.
== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:
== NO RELEASE NOTE ==

cc @yma11 @yyang52 @winningsix

okay for me.


Update fs2-core to 3.0.5

Updates co.fs2:fs2-core from 2.5.7 to 3.0.5.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-core" } ]

labels: library-update, semver-major

Superseded by #129.


feat: add an api for other mods

Adds an api similar to GMD-API's.
The purpose of this API is to allow other mods to set/activate/get NONG songs from Jukebox.
For now only adding songs and setting them as active is available from the api.
At the moment, the only functionality this API offers is adding NONG songs and activating a song. More functions can be added later.

There is an issue with setActiveSong where is would not update CustomSongWidget's song info before starting to play a level(Reopening that screen updates it). To fix this setActiveSong needs the instance of CustomSongWidget, but I have no idea how to get it without introducing a global variable.

Only tested on Windows(wine).

Example:
After adding fleym.nongd as a dependency in mod.json, the mod will be able to do this:
#include <fleym.nongd/include/jukebox.hpp>

...

SongInfo song = {
    .path = "Z:\\home\\user\\Downloads\\music.mp3",
    .songName = "my song name",
    .authorName = "artist",
    .songUrl = "local",
};
jukebox::addNong(song, 945695);
jukebox::setActiveSong(song, 945695);

I've been wanting to do this for so long, big W. I'll look at the PR in a bit.

fire


Add Travis check for docker build & compose.

Expose various application.conf as env vars for wherehows-frontend.

Coverage remained the same at 0.0% when pulling f6f5c76ff53d8630241c3f61c0c219842c289de5 on mars-lan:travis into ec0b5ac309997d411ad3d28a36206b4b871d5444 on linkedin:master.

Coverage remained the same at 0.0% when pulling 7431f7eeb1dbe96d7c9544e7086ea8a1ef3c1d3a on mars-lan:travis into ec0b5ac309997d411ad3d28a36206b4b871d5444 on linkedin:master.

Coverage remained the same at 0.0% when pulling 7431f7eeb1dbe96d7c9544e7086ea8a1ef3c1d3a on mars-lan:travis into ec0b5ac309997d411ad3d28a36206b4b871d5444 on linkedin:master.


questions regarding coord2radial

Hi. I find the way you calculate radial is different from other similar works, e.g., EGNN.
Your strategy. the radial is the dot product of the coord differences.

def coord2radial(edge_index, coord):
    row, col = edge_index
    coord_diff = coord[row] - coord[col]  # [n_edge, n_channel, d]
    radial = torch.bmm(coord_diff, coord_diff.transpose(-1, -2))  # [n_edge, n_channel, n_channel]
    # normalize radial
    radial = F.normalize(radial, dim=0)  # [n_edge, n_channel, n_channel]
    return radial, coord_diff

EGNN's strategy. the radial is the squared distance between two nodes.
    def coord2radial(self, edge_index, coord):
        row, col = edge_index
        coord_diff = coord[row] - coord[col]
        radial = torch.sum(coord_diff**2, 1).unsqueeze(1)

        if self.normalize:
            norm = torch.sqrt(radial).detach() + self.epsilon
            coord_diff = coord_diff / norm

        return radial, coord_diff

I think your radial can represent the orientation of two multi-channel residues, and egnn's radial represents the distance. Is this reasonable? What do you think it represents? What's your motivation for defining it this way instead of following egnn?
The way you normalize the radial is quite interesting, you normalize it along the n_edge dimension (similar to "batch dimension").
Why? Have you tried removing normalization?
Best,
Zhangzhi

Thanks for the insightful questions.

Actually we adopt the inner-product radial due to its representation completeness. EGNN is designed for single-channel nodes, and we do not know whether the norm-based radial can fit arbitrary orthogonality-equivariant functions with multi-channel nodes. On the contrary, the representation completeness of the inner-product radial is explored already in "Equivariant graph mechanics networks with constraints" (Section 3.2).
As for the normalization, we found it is necessary to maintain numerical stability. If the normalization is removed, the training procedure will be unstable and easily produce NaN in the loss. But we didn't quite explore the benefit of different form of normalization. I have just tried the normalization strategy in EGNN, and the performance on CDR design did not exhibit significant change, so maybe either is OK.


Add an option to recipe to blacklist packages from buildcache

When building packages from a git branch, for example<EMAIL_ADDRESS>the package will be fetched from buildcache even if the branch has been updated in the meantime.
Is it possible to add an option to config.yaml or environments.yaml to exclude packages from the buildcache?

In cases like this, ideally you want to never push @branch builds to the build cache in the first place.
So should the option be applied here:
https://github.com/eth-cscs/stackinator/blob/master/stackinator/templates/Makefile.environments#L20-L24
We already try to exclude cuda and nvhpc from the build cache, because

copying them to the cache takes ~30 minutes sometimes
because they are binary blobs, installing them fresh each time takes hardly any more time than installing from the cache

However, this feature broke at some point - I could add support for optionally excluding packages by name when I fix the this?

Thank you. It's not an important feature, but nice to have. I'll have a look too, perhaps its possible to exclude packages installed via<EMAIL_ADDRESS>excluding package by name via an additional entry would be the 2nd best option.


Codeclimate

PR summary
This PR adds the compatibility to run as CodeClimate Engine.
Closes: #512
Todo

[ ] write unit tests
[ ] test in gitlab infrastructure
[ ] implement include_files
[ ] create a docker container with

FROM jamescooke/openapi-validator:$version
WORKDIR /code
ENTRYPOINT ["lint-openapi", "--config", "/config.json", "--codeclimate"]

[ ] get in touch with Code Climate and publish as community engine

PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:

[X] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)
[X] Dependencies have been updated as needed
[X] .secrets.baseline updated as needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

gitlab integration looks nice :)

https://gitlab.com/biletado/apidocs/-/merge_requests/1/diffs#416b6ad6e0af19ad0cea28667e2544b23b326dbd


Scrobbles not being saved, still (v4.4.1)

I checked the existing issues, including the closed issues: #2658 and #2609 seemed related, but they are fixed (I'm running 4.4.1) and I still have this issue
I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there
I have double checked and can reproduce the issue: I've been having this issue for several days and multiple reboots. I've removed and re-added the Last.fm authorization a couple of times.

If appropriate please attach the DEBUG information zip file that you can generate by following the instructions in the FAQ
OS:
Windows 10 Pro, Version 1703, OS Build 15063.540
Issue Descriptions:
Scrobbles show up on Last.fm with "Now Playing" but are not saved when the new song starts.
Steps to Reproduce:

Play song in GPMDP
Watch Last.fm profile

This happens with the player open, not minimized.
I run virtual desktops (Win 10 built-in) but in case it was related to the minimized issue, I stayed on the same screen as the player and this still happened.
The last songs successfully scrobbled were from a Google Play Music radio station, then I switched to playlists of my own music and then it stopped scrobbling.
debug_info.zip

I have the same issue.
v4.4.1 @ macOS Sierra 10.12.6.

it's seems to be specifically music that has been uploaded by the user
music that's played directly from google's own catalogue will play fine for me, but if i swap to anything i've had to upload, scrobbling does not work at all

yeah. seems that none of my uploaded tracks appeared on last.fm. but also not all tracks that I played from google store albums appeared on last.fm too.
attaching new debug_info 2.zip with unscrobbled google's songs just in case.

same issue
v 4.4.1 ubuntu 16.04 LTS (core  4.8.0-52-generic)

Same issue on Mac Sierra 10.12.6. GDMP version 4.4.1.
It does seem to be a problem with uploaded tracks. Google's catalog scrobbles.

{"message":"LASTFM ERROR","stack":"Error: getaddrinfo ENOTFOUND ws.audioscrobbler.com
It looks to me like its a DNS/network related issue hence why its so consistent between versions for you.

I get this issue from two different locations (work & home) which both have very permissive network setups. What should I be looking at? Is there some more detail in the logs I can use to figure out exactly what's failing? e.g. the specific URI being accessed when it fails

Could be a firewall? Its trying to connect to ws.audioscrobbler.com and the connection is reset, usually indicative of something killing the connection.

I don't see any rules in my firewall specific to GPMDP, and if I go to that URL in Chrome I get a web page that says "Please visit http://www.last.fm/api", so it doesn't appear to block that location in general.
I never got a popup from the firewall when first installing GPMDP, so I assumed it didn't need any specific ports opened. Presumably it's using the standard web/HTTP ports.

@miketotman-sd That error normally comes from firewalls / proxies / vpn's getting in the way.  For those issues please see #921
For issues where some tracks scrobble and others don't, this has been fixed in master 👍
Happy to continue debugging discussion here but closing out as #921 tracks these issues

But I'm not using a proxy, and from what I can see I don't have any firewall rules blocking this communication. And I can do last.fm scrobbling from this computer using other desktop apps like VLC.

Since I noticed this issue, I've only been listening to tracks from the Google library (mostly radio stations). Today I pushed play on a station I was listening to yesterday (I had not closed the client since yesterday). The tracks from yesterday had scrobbled, but the tracks played today did not scrobble. After re-starting the client, it started scrobbling again.

@pdubla restarting the client worked for me too, not sure why it stopped working.

seems that scrobbling for tracks from Google library stopped working each time when I left my Mac sleep overnight with GPMDP on background (I mean just close laptop for a night).
so I don't get how this is can be network-related issue.

To clarify, restarting the app on Windows fixed scrobbling, still broken on my Mac.

Having this issue on both Windows 10 (at home) & Mac Sierra 10.12.6 (at work) GDMP version 4.4.1. No help from restarting player or restarting the computer. Tracks from my own library don't scrobble (but show up as Now Playing) while tracks from the Google library do scrobble.

same situation as @Angryhead

Same issue as @Angryhead. Nothing has scrobbled since Oct 25 for me (it's Oct 30). I've listened to 6 albums since then. I'm logged in, authorized, it shows as Now Playing then doesn't show in recently listened to on Last.fm. Restarting PC, program doesn't help. No proxies. Windows 10 Pro x64 v1703

I'm still having the issue that tracks don't scrobble when they're from my own library. Non-library tracks have been working for me, even when not restarting the client.

I'm still having this issue and I think it has to do with this  lastfm-node issue
https://github.com/jammus/lastfm-node/issues/28

I'm still having this issue and I think it has to do with this lastfm-node issue

The fix for this hasn't been released yet, this issue doesn't occur on master

So it should fix this issue in 4.4.1? https://www.youtube.com/watch?v=CGL4QkpiOSk

Also on 4.4.1 on Mac and experiencing the same issue.

Would appreciate an updated build that fixes this issue, haven't had last.fm scrobbles since Oct :(


[sdk] [experimental] Read write set local execution

Motivation
This leverages the read-write set analysis to prefetch all the resources to reexecute a transaction locally.
Some details are also available in #8586
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Mostly smoke tests using existing transactions.
Can be run using
cargo run -p df-cli -- prefetched-replay --mode diem --rpc-url http://localhost:8080 execute-serialized-transactions mint-txs.hexl

where mint-txs.hexl is the output of raw transactions generated by transaction-generator (see #9113)
/cc @sblackshear @runtian-zhou @tzakian

@sblackshear Sorry it took a while but everything is now working well! I moved the transaction-generator part here: https://github.com/diem/diem/pull/9113

Sry where do we fetch the on chain configs needed for execution?

Hopefully, these should be part of the access paths set returned by the read-write-set analysis so they are fetched by fetch_accounts_storage

Sry where do we fetch the on chain configs needed for execution?

Hopefully, these should be part of the access paths set returned by the read-write-set analysis so they are fetched by fetch_accounts_storage

Hmm I don't think those access paths are returned by the read-write-set analysis cuz they are data read by the adapter and there's no way the read write set analysis could obtain such info by just looking at raw transactions. IMHO we should just hard code such data and put it somewhere.

Hmm I don't think those access paths are returned by the read-write-set analysis cuz they are data read by the adapter and there's no way the read write set analysis could obtain such info by just looking at raw transactions. IMHO we should just hard code such data and put it somewhere.

I think it is already hard coded in the read-write set analysis: https://github.com/diem/diem/blob/main/language/diem-tools/diem-read-write-set/src/lib.rs#L65-L66
Or do we need more than that?

Or do we need more than that?

Yea I think there's more than the prologue. The issue is around those on chain configs that gets loaded at system start up time that wasn't taken into account by the inferencer: https://github.com/diem/diem/blob/9bcbc2369472b62667c4604c78e8484a9190d6b6/language/diem-vm/src/diem_vm_impl.rs#L102