Thinq1 Mini-Split AC: TypeError: Cannot read property 'min' of null

Describe The Bug:
When enabling Thinq1 support, used against a LSN120HSV5 mini-split unit. It uses Thinq1
To Reproduce:
Enabling the plugin raises an error when trying to configure the device:
Expected behavior:
I was hoping to get control over this Thinq1 device
Logs:
9/2/2021, 7:09:53 AMLg Thinq Bridge starting
9/2/2021, 7:09:57 AMLg Thinq BridgeLoaded plugin 'homebridge-lg-thinq'
9/2/2021, 7:09:57 AMLg Thinq BridgeLoading 1 platforms...
9/2/2021, 7:09:57 AMLg Thinq BridgeLGThinQLoading accessory from cache: Master Bedroom
9/2/2021, 7:09:57 AMLg Thinq BridgeLGThinQLoading accessory from cache: Living Room
9/2/2021, 7:09:57 AMLg Thinq BridgeBridge is running on port 51846.
9/2/2021, 7:10:04 AMLg Thinq BridgeLGThinQRestoring existing accessory from cache: Master Bedroom
9/2/2021, 7:10:04 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 7:10:05 AMLg Thinq BridgeLGThinQAdding new accessory: Dining Room
9/2/2021, 7:10:05 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 7:10:05 AMLg Thinq BridgeWARNINGunhandled rejection: TypeError: Cannot read property 'min' of null

Plugin Config:
{
    "accessories": [],
    "platforms": [
        {
            "platform": "LGThinQ",
            "country": "US",
            "language": "en-US",
            "refresh_interval": 60,
            "auth_mode": "account",
            "username": "REDACTED",
            "password": "REDACTED",
            "thinq1": true,
            "refresh_token": ""
        }
    ]
}

Screenshots:

Environment:

Plugin Version: 1.1.2
Homebridge Version: 1.3.4 via hoobs 4.0.100
Node.js Version: 14.17.5
NPM Version: 6.14.14
Operating System: Raspbian via hoobs

$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

turn on homebridge debug mode, you can see some debug logging, please upload all

9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQFound device:  {"deviceId":"REDACTED-4d23-1f8f-aa61-60ab14f44252","deviceType":401,"modelName":"RAC_056905_WW","subModelNm":null,"sensorType":null,"alias":"Master Bedroom","deviceCode":"AI01","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"RAC_TYPE1","pccModelYn":"N","autoOrderYn":"N","drServiceYn":"N","ssid":"REDACTED","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"{\"deviceCode\":\"AI01\"}","newRegYn":"N","remoteControlType":"","fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20201208142938000","regIndex":0,"blackboxYn":"Y","groupableYn":"Y","controllableYn":"Y","combinedProductYn":"N","masterYn":"Y","snapshot":{"airState.windStrength":6,"airState.wMode.lowHeating":0,"airState.diagCode":0,"airState.lightingState.displayControl":1,"airState.wDir.hStep":0,"mid":862065947,"airState.energy.onCurrent":0,"airState.wMode.airClean":0,"airState.quality.sensorMon":0,"airState.miscFuncState.antiBugs":0,"airState.tempState.target":26,"airState.operation":1,"airState.wMode.jet":0,"airState.wDir.vStep":100,"timestamp":1630581272922,"airState.powerSave.basic":0,"airState.quality.PM10":0,"static":{"deviceType":"401","countryCode":"US"},"airState.quality.overall":0,"airState.tempState.current":26,"airState.miscFuncState.extraOp":0,"airState.reservation.sleepTime":0,"airState.miscFuncState.autoDry":0,"airState.reservation.targetTimeToStart":0,"meta":{"allDeviceInfoUpdate":false,"messageId":"gViT80JySWWmOonhB7ZpKg"},"airState.quality.PM1":0,"airState.quality.PM2":0,"online":true,"airState.opMode":0,"airState.reservation.targetTimeToStop":0,"airState.filterMngStates.maxTime":360,"airState.filterMngStates.useTime":220},"manufacture":null,"online":true,"platformType":"thinq2","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"11.74","modelJsonUri":"https://objectcontent.lgthinq.com/REDACTED-a6cb-4ad8-8028-13cffdb83d54?hdnts=exp=1689007282~hmac=95472632ce69 REDACTED 8286d0a6aed8b97054a29d137015525df","appModuleVer":"16.32","appModuleUri":"https://objectcontent.lgthinq.com/REDACTED-0404-4712-a5bc-2bc3d9e072b8?hdnts=exp=1685169055~hmac=8b53 REDACTED 3d075c761cc94be01589d82200ab3e93c3fa57","appRestartYn":"Y","appModuleSize":"13305760","langPackProductTypeVer":"52.8","langPackProductTypeUri":"https://objectcontent.lgthinq.com/REDACTED-1ce6-4ded-ac44-2d450cea341a?hdnts=exp=1693362382~hmac=e74e REDACTED 8d2915198852aa8b2bc8a5797a9a8cb92d8fc12e2ff6212","langPackModelVer":null,"langPackModelUri":null,"roomId":"","fwInfoList":[{"checksum":"00006742","partNumber":"SAA38690428","order":1}],"modemInfo":{"modelName":"RAC_056905_WW","appVersion":"clip_hna_v1.9.104","modemType":"QCOM_QCA4010","ruleEngine":"y"},"existsEntryPopup":"N","fwVer":null,"modemVer":null,"subDeviceCount":0,"firebaseLogKey":"P:SD","cardType":"Small","cardControl":"Base"}
9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQRestoring existing accessory from cache: Master Bedroom
9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQFound device:  {"deviceId":"REDACTED-7149-11d3-80b2-7440be93575f","deviceType":401,"modelName":"RAC_056905_WW","subModelNm":null,"sensorType":null,"alias":"Dining Room","deviceCode":"AI01","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"RAC_TYPE1","pccModelYn":"N","autoOrderYn":"N","drServiceYn":"N","ssid":"REDACTED","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"{\"deviceCode\":\"AI01\"}","newRegYn":"N","remoteControlType":"","fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20201208141858000","regIndex":0,"blackboxYn":null,"groupableYn":"Y","controllableYn":"Y","combinedProductYn":"N","masterYn":"Y","manufacture":null,"online":false,"platformType":"thinq1","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"7.12","modelJsonUri":"https://aic.lgthinq.com:46030/api/webContents/modelJSON?modelName=modelJSON_401&countryCode=KR&contentsId= REDACTED-7149-11d3-80b2-7440be93575f&authKey=thinq","appModuleVer":"16.32","appModuleUri":"https://objectcontent.lgthinq.com/REDACTED-0404-4712-a5bc-2bc3d9e072b8?hdnts=exp=1685169055~hmac=8b538678 REDACTED 61cc94be01589d82200ab3e93c3fa57","appRestartYn":"Y","appModuleSize":"13305760","langPackProductTypeVer":"52.8","langPackProductTypeUri":"https://objectcontent.lgthinq.com/REDACTED-1ce6-4ded-ac44-2d450cea341a?hdnts=exp=1693362382~hmac=e74ed08 REDACTED 198852aa8b2bc8a5797a9a8cb92d8fc12e2ff6212","langPackModelVer":"","langPackModelUri":"","roomId":"","fwInfoList":null,"modemInfo":null,"existsEntryPopup":"N","fwVer":"2.5.8_RTOS_3K","modemVer":null,"subDeviceCount":0,"firebaseLogKey":"P:SD","cardType":"Small","cardControl":"Base"}
9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQAdding new accessory: Dining Room
9/2/2021, 7:51:29 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 7:51:29 AMLg Thinq BridgeWARNINGunhandled rejection: TypeError: Cannot read property 'min' of null
9/2/2021, 9:10:00 AMlgthinqbridge stopping
9/2/2021, 9:10:00 AMLg Thinq BridgeShutting down
9/2/2021, 9:10:02 AMLg Thinq BridgeStopped
9/2/2021, 9:10:05 AMLg Thinq Bridge starting
9/2/2021, 9:10:08 AMLg Thinq BridgeInitializing HAP-NodeJS v0.9.4...
9/2/2021, 9:10:10 AMLg Thinq BridgeLoaded plugin 'homebridge-lg-thinq'
9/2/2021, 9:10:10 AMLg Thinq BridgeRegistering platform 'homebridge-lg-thinq.LGThinQ'
9/2/2021, 9:10:10 AMLg Thinq BridgeLoading 1 platforms...
9/2/2021, 9:10:10 AMLg Thinq BridgeLGThinQLoading accessory from cache: Master Bedroom
9/2/2021, 9:10:10 AMLg Thinq BridgeLGThinQLoading accessory from cache: Living Room
9/2/2021, 9:10:10 AMLg Thinq BridgeLGThinQExecuted didFinishLaunching callback
9/2/2021, 9:10:10 AMLg Thinq BridgePreparing Advertiser for 'Lg Thinq Bridge 76F6' using bonjour-hap backend!
9/2/2021, 9:10:10 AMLg Thinq BridgeSetup URI 'X-HM://0023ISYWY7B46'
9/2/2021, 9:10:10 AMLg Thinq BridgeStarting to advertise 'Lg Thinq Bridge 76F6' using bonjour-hap backend!
9/2/2021, 9:10:10 AMLg Thinq BridgeBridge is running on port 51846.
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQFound device:  {"deviceId":"REDACTED-4d23-1f8f-aa61-60ab14f44252","deviceType":401,"modelName":"RAC_056905_WW","subModelNm":null,"sensorType":null,"alias":"Master Bedroom","deviceCode":"AI01","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"RAC_TYPE1","pccModelYn":"N","autoOrderYn":"N","drServiceYn":"N","ssid":"REDACTED","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"{\"deviceCode\":\"AI01\"}","newRegYn":"N","remoteControlType":"","fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20201208142938000","regIndex":0,"blackboxYn":"Y","groupableYn":"Y","controllableYn":"Y","combinedProductYn":"N","masterYn":"Y","snapshot":{"airState.windStrength":6,"airState.wMode.lowHeating":0,"airState.diagCode":0,"airState.lightingState.displayControl":1,"airState.wDir.hStep":0,"mid":865718922,"airState.energy.onCurrent":0,"airState.wMode.airClean":0,"airState.quality.sensorMon":0,"airState.miscFuncState.antiBugs":0,"airState.tempState.target":26,"airState.operation":1,"airState.wMode.jet":0,"airState.wDir.vStep":100,"timestamp":1630584840435,"airState.powerSave.basic":0,"airState.quality.PM10":0,"static":{"deviceType":"401","countryCode":"US"},"airState.quality.overall":0,"airState.tempState.current":26,"airState.miscFuncState.extraOp":0,"airState.reservation.sleepTime":0,"airState.miscFuncState.autoDry":0,"airState.reservation.targetTimeToStart":0,"meta":{"allDeviceInfoUpdate":false,"messageId":"Qw4lpenXSqOK7QdHYBadTw"},"airState.quality.PM1":0,"airState.quality.PM2":0,"online":true,"airState.opMode":0,"airState.reservation.targetTimeToStop":0,"airState.filterMngStates.maxTime":360,"airState.filterMngStates.useTime":219},"manufacture":null,"online":true,"platformType":"thinq2","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"11.74","modelJsonUri":"https://objectcontent.lgthinq.com/REDACTED-a6cb-4ad8-8028-13cffdb83d54?hdnts=exp=1689007282~hmac=95472632ce REDACTED 1b368286d0a6aed8b97054a29d137015525df","appModuleVer":"16.32","appModuleUri":"https://objectcontent.lgthinq.com/REDACTED-0404-4712-a5bc-2bc3d9e072b8?hdnts=exp=1685169055~hmac=8b53867 REDACTED c761cc94be01589d82200ab3e93c3fa57","appRestartYn":"Y","appModuleSize":"13305760","langPackProductTypeVer":"52.8","langPackProductTypeUri":"https://objectcontent.lgthinq.com/REDACTED-1ce6-4ded-ac44-2d450cea341a?hdnts=exp=1693362382~hmac=e74ed0863 REDACTED 198852aa8b2bc8a5797a9a8cb92d8fc12e2ff6212","langPackModelVer":null,"langPackModelUri":null,"roomId":"","fwInfoList":[{"checksum":"00006742","partNumber":"SAA38690428","order":1}],"modemInfo":{"modelName":"RAC_056905_WW","appVersion":"clip_hna_v1.9.104","modemType":"QCOM_QCA4010","ruleEngine":"y"},"existsEntryPopup":"N","fwVer":null,"modemVer":null,"subDeviceCount":0,"firebaseLogKey":"P:SD","cardType":"Small","cardControl":"Base"}
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQRestoring existing accessory from cache: Master Bedroom
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQFound device:  {"deviceId":"REDACTED-7149-11d3-80b2-7440be93575f","deviceType":401,"modelName":"RAC_056905_WW","subModelNm":null,"sensorType":null,"alias":"Dining Room","deviceCode":"AI01","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"RAC_TYPE1","pccModelYn":"N","autoOrderYn":"N","drServiceYn":"N","ssid":"REDACTED-IOT","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"{\"deviceCode\":\"AI01\"}","newRegYn":"N","remoteControlType":"","fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20201208141858000","regIndex":0,"blackboxYn":null,"groupableYn":"Y","controllableYn":"Y","combinedProductYn":"N","masterYn":"Y","manufacture":null,"online":false,"platformType":"thinq1","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"7.12","modelJsonUri":"https://aic.lgthinq.com:46030/api/webContents/modelJSON?modelName=modelJSON_401&countryCode=KR&contentsId= REDACTED-7149-11d3-80b2-7440be93575f&authKey=thinq","appModuleVer":"16.32","appModuleUri":"https://objectcontent.lgthinq.com/6c1a78d3-0404-4712-a5bc-2bc3d9e072b8?hdnts=exp=1685169055~hmac=8b538 REDACTED 929b66403d075c761cc94be01589d82200ab3e93c3fa57","appRestartYn":"Y","appModuleSize":"13305760","langPackProductTypeVer":"52.8","langPackProductTypeUri":"https://objectcontent.lgthinq.com/5a0c1923-1ce6-4ded-ac44-2d450cea341a?hdnts=exp=1693362382~hmac=e74ed0863a REDACTED<PHONE_NUMBER>aa8b2bc8a5797a9a8cb92d8fc12e2ff6212","langPackModelVer":"","langPackModelUri":"","roomId":"","fwInfoList":null,"modemInfo":null,"existsEntryPopup":"N","fwVer":"2.5.8_RTOS_3K","modemVer":null,"subDeviceCount":0,"firebaseLogKey":"P:SD","cardType":"Small","cardControl":"Base"}
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQAdding new accessory: Dining Room
9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQAC still in development.If you got problem,plz report at https://github.com/nVuln/homebridge-lg-thinq/issues
9/2/2021, 9:10:17 AMLg Thinq BridgeWARNINGunhandled rejection: TypeError: Cannot read property 'min' of null

9/2/2021, 9:10:17 AMLg Thinq BridgeLGThinQFound device:  {"deviceId":"REDACTED-7149-11d3-80b2-7440be93575f","deviceType":401,"modelName":"RAC_056905_WW","subModelNm":null,"sensorType":null,"alias":"Dining Room","deviceCode":"AI01","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"RAC_TYPE1","pccModelYn":"N","autoOrderYn":"N","drServiceYn":"N","ssid":"REDACTED-IOT","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"{"deviceCode":"AI01"}","newRegYn":"N","remoteControlType":"","fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20201208141858000","regIndex":0,"blackboxYn":null,"groupableYn":"Y","controllableYn":"Y","combinedProductYn":"N","masterYn":"Y","manufacture":null,"online":false,"platformType":"thinq1","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"7.12","modelJsonUri":"https://aic.lgthinq.com:46030/api/webContents/modelJSON?modelName=modelJSON_401&countryCode=KR&contentsId= REDACTED-7149-11d3-80b2-7440be93575f&authKey=thinq","appModuleVer":"16.32","appModuleUri":"https://objectcontent.lgthinq.com/6c1a78d3-0404-4712-a5bc-2bc3d9e072b8?hdnts=exp=1685169055~hmac=8b538 REDACTED 929b66403d075c761cc94be01589d82200ab3e93c3fa57","appRestartYn":"Y","appModuleSize":"13305760","langPackProductTypeVer":"52.8","langPackProductTypeUri":"https://objectcontent.lgthinq.com/5a0c1923-1ce6-4ded-ac44-2d450cea341a?hdnts=exp=1693362382~hmac=e74ed0863a REDACTED<PHONE_NUMBER>aa8b2bc8a5797a9a8cb92d8fc12e2ff6212","langPackModelVer":"","langPackModelUri":"","roomId":"","fwInfoList":null,"modemInfo":null,"existsEntryPopup":"N","fwVer":"2.5.8_RTOS_3K","modemVer":null,"subDeviceCount":0,"firebaseLogKey":"P:SD","cardType":"Small","cardControl":"Base"}

can you help me download modelJsonUri in this device data, because you redacted it so I can't find a correct url to download it
didn't know why 2 your device is same model RAC_056905_WW, but different data

Yeah sorry about the over redaction, I thought the UUID would have personal info in it. I have 3 units, 2 of them the same, one of them different.
https://aic.lgthinq.com:46030/api/webContents/modelJSON?modelName=modelJSON_401&countryCode=KR&contentsId=d27c2920-7149-11d3-80b2-7440be93575f&authKey=thinq
https://aic.lgthinq.com:46030/api/webContents/modelJSON?modelName=modelJSON_401&countryCode=KR&contentsId=d27c2920-7149-11d3-80b2-7440be93575f&authKey=thinq
After closer inspection of the alias names, It appears that I might have mislabeled the Dining Room one here. And the 2 that are here are showing up in home bridge (not accepting commands, but that is another issue I will open separately). I don't see json output for the one not working. The one that is not here is an LSN180HSV5 model, using thinq1. It is working in the LG app and I did have it working with the LG Airco plugin, so I know it is possible.
I am a software engineer too and am happy to help debug this issue with you if you have the time.

I already published test version v1.2.0-test.8, please install and try

Genius. works well with this version. Thank you so much for taking this on! Where is your donate button?!


Sort archs and make the generate predictable

Sorry for the noise, I didn't pay attention to the order of the archs. It's now predictable so this shouldn't happen again.
This PR adds the "general" intrinsics (not bound to any arch).
Last part of https://github.com/rust-lang/rustc_codegen_gcc/pull/151.

It seems like these functions shouldn't be added then. Is it fine to still have the sorting predictable?

It seems like these functions shouldn't be added then. Is it fine to still have the sorting predictable?

Indeed. We can add them later if needed.
Yes, please, go ahead for the sorting.

Done!


[Feat]:  Change Dependabot to Renovate

Description
If you go to https://github.com/FrancescoXX/4c-site/blob/main/.github/dependabot.yml, which is the workflow for the dependabot that we have at the moment for the 4c site.
Solution
It would be better if we had Renovate instead due to the many configuration options it has. For more information, reference:
https://github.com/renovatebot/renovate
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@tobySolutions Can you please assign this to me? I would like to contribute to it.

@tobySolutions Can you please assign this to me? I would like to contribute to it.

Yeah, sure thing. Go ahead!

@tobySolutions I have added the configuration and workflow for renovate the PR. But will have to wait for the schedule run to test it. I tested locally and there were no errors.
Also, I see dependabot workflow is also present, do you want me to delete that?

@tobySolutions I have added the configuration and removed workflow (it is recommended to use renovate app instead).
I have installed the renovate app as described here in my forked repository. I can see the auto PR for dependency upgrade are getting created.

Please let me know after reviewing the renovate config file at what time we want to schedule and how frequent.

@tobySolutions I have added the configuration and removed workflow (it is recommended to use renovate app instead). I have installed the renovate app as described here in my forked repository. I can see the auto PR for dependency upgrade are getting created.
Please let me know after reviewing the renovate config file at what time we want to schedule and how frequent.

Hmm, give me a minute to tag @gptkrsh to this.


FIX: improve logging

Codecov Report

Merging #45 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   95.63%   95.58%   -0.05%
==========================================
  Files           9        9
  Lines         275      272       -3
==========================================
- Hits          263      260       -3
  Misses         12       12

Impacted Files
Coverage Δ

time_execution/backends/threaded.py
100% <100%> (ø)
:arrow_up:

time_execution/backends/kafka.py
100% <100%> (ø)
:arrow_up:

time_execution/backends/elasticsearch.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca416d...a7648ab. Read the comment docs.


[Bug] TypeError: e.localeCompare is not a function

Description
Fix Custom Comparator to Convert Boolean Type to Text
Related Issue
Closes AGE-419
Steps to Reproduce the Issue:

Create an evaluator, e.g., Exact Match.
Start a new evaluation with the evaluator.
Go to the Evaluation Results page.
Click on the Evaluator column with boolean values to rearrange the order.
See Error.

https://github.com/user-attachments/assets/8566b725-1cf2-4156-a6f3-3283d2738018

@bekossy
I couldn't reproduce it nor in oss neither in cloud 🤔


Add z-index to ensure links can be clicked.

Issue
Cloned slides and specific effects can cause links to be "unclickable", despite using the preventClicks option. This can be replicated using the following options:
{
    loop: true,
    effect: 'fade',
}

What this does
Adds z-index to the active slide. This is change is non-destructive.
Related issues
https://github.com/nolimits4web/swiper/issues/3471
https://github.com/nolimits4web/swiper/issues/1584
https://github.com/nolimits4web/swiper/issues/1152

@araphiel I can't reproduce the bug
https://stackblitz.com/edit/swiper-demo-22-fade-effect-byv4l4?file=index.html

@araphiel I can't reproduce the bug
https://stackblitz.com/edit/swiper-demo-22-fade-effect-byv4l4?file=index.html

@araphiel Adding a z-index to the active slide is causing a less smoother experience when we "touch move" to the previous slide.

this is an issue as everything is overlapped, if you place buttons on the slides you'll get wrong link click when using FADE


Codecov action out of date

Codecov bumped their major version. I believe this is why current jobs are failing on PRs. We need to bump the version and make other associated updates (env, args, etc.).

Merged into #367 to cleanup that CI.


Add Margot logo to bottom of base.html

In an email from Debra:

...we want to add the MARGOT research cluster logo and link to the bottom of the Cantus Database site.
Here's the link: https://uwaterloo.ca/margot/

assigning a priority of Medium because it will be very quick to implement


Regression in adding certain packages

Bug in adding the sonar package on the micro:bit yields the following error:
Uncaught TypeError: Cannot read property 'replace' of null
    at Function.b.fadeColour (https://pxt.azureedge.net/blob/f18fda6ee99e040d0478bb329470a321c7cb247c/blockly/blockly_compressed.js:1694:139)
    at appendNamespaceCss (https://pxt.azureedge.net/blob/7800799a7071ae92302fe70245ee15a1c64ae4b8/pxtblocks.js:2628:188)
    at createToolbox (https://pxt.azureedge.net/blob/7800799a7071ae92302fe70245ee15a1c64ae4b8/pxtblocks.js:3198:21)
    at Object.initBlocks (https://pxt.azureedge.net/blob/7800799a7071ae92302fe70245ee15a1c64ae4b8/pxtblocks.js:3341:22)
    at https://pxt.azureedge.net/blob/4f361dff26d397350d166a0e0319cad2712690d8/main.js:2137:40
    at <anonymous>

Seems related to the docs inline block changes.

Looks like packages with no colors break


Clean toc and reame

Hi Marcelo @zoccoler ,
I was just cleaning up intro pages and readmes, screenshots. Plus: I'm proposing weekday headlines in the TOC instead of a readme that just contains a single sentence.
Let me know what you think or merge it right away!
closes #9
Best,
Robert

Hi Robert @haesleinhuepf ,
I agree with the changes, thanks for fixing the documentation. Feel free to merge it.
Best,
Marcelo


[WIP] Experimenting with newline sensitivity changes

See discussion in #146
This PR changes the following:

Allow functions to be split across multiple lines:var foo = resourceGroup(
  mySubscription,
  myRgName)

Allow optional commas on object & array syntaxesvar foo = [
  'abc',
  'def',
]
var bar = {
  abc: 'def',
  ghi: 'jkl',
}

Allow single-line object & array declarations (when used with commas):var foo = ['abc', 'def']
var bar = {abc: 'def', ghi: 'jkl'}

See Installing Nightly if you're interested in trying this out.
Here's a demo of this during the last community call: https://youtu.be/R6SyuRhTmmc?t=1145s

Good stuff! Optional commas in arrays are great.
It can be used in decorators too, right ? @allowed(['slow', 'fast'])
:shipit:  please 🥇

So I think the options here are:

Reject the implementation
Accept the implementation as-is
Accept the implementation, just for functions (no objects & arrays)
Accept the implementation, but block commas on multiline objects & arrays

I'm leaning most heavily towards option 4 - it's purely additive, doesn't introduce 2 different ways of multiline arrays/objects, but still gives us the option to introduce this in future if we want to.

I'm leaning most heavily towards option 4 - it's purely additive, doesn't introduce 2 different ways of multiline arrays/objects, but still gives us the option to introduce this in future if we want to.

We had a discussion on this today, and reached consensus on option 4, with code fixes to switch between single- and multi-line declarations. It leaves the door open to doing option 2 in the future if we get community feedback for it; whereas option 2 would be an irreversible decision.
The remaining open question was regarding the formatter. I've proposed just fixing indention and spacing without deciding whether a declaration should or shouldn't be multi-line. We had agreement on wanting to pick a sensible opinionated default, and wanted to discuss whether we should pick a prettier-like approach. Personally I feel like we're unblocked on this PR (with a basic formatter implementation), and can try to get feedback on a community call in the future on a more sophisticated auto-formatter.

Thank you for these improvements ✅
A few things, with some comments.

Perhaps 1 or 2 of these may be interesting.
Also some use cases, that I did not expect, however appear to be fine.

Before

"convert object to single line" code action

not what I was expecting, however works fine

convert object to multiple lines

looks good, it's just not indented.

then format

now back to normal, with indenting

looks like convert to single line also puts different property values on new lines

it appears to build just fine

this all seems to work well, in these use cases.

error messages

I guess we can improve some messaging around the change i.e. I have to delete the comma.

then format, works well


Is it possible to set the maximum framerate?

I see screen distortions when streaming from my phone or when the Internet is bad. This is when I stream through WebRTC.
I suspect that the problem may be in a large number of transmitted frames and in the bitrate.
Is it possible to set the maximum frame rate in OvenLiveKit?
Linked with https://github.com/AirenSoft/OvenMediaEngine/issues/546

@albeliakov Hi. This ConnectionConfig will work! https://github.com/AirenSoft/OvenLiveKit-Web?tab=readme-ov-file#maxvideobitrate


Uncaught Error: Module did not self-register.

[Enter steps to reproduce:]

...
...

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Unknown macOS version
Thrown From: Atom Core
Stack Trace
Uncaught Error: Module did not self-register.
At ELECTRON_ASAR.js:166

Error: Module did not self-register.
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:740:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:180:18)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:20:18)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:1:688158)
    at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744622)
    at get_manager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744724)
    at Object.getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744850)
    at e.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:1087821)
    at KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1246932)
    at KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1244917)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:284329)

Commands
     -0:38.1.0 core:select-all (input.hidden-input)
  2x -0:37.5.0 core:copy (input.hidden-input)
  2x -0:34.2.0 tree-view:add-file (span.name.icon.icon-file-directory)
  4x -0:03.6.0 editor:consolidate-selections (input.hidden-input)

Non-Core Packages
atom-django 0.3.2
atom-flask 0.2.3
atom-terminal-panel 4.4.4
autocomplete-python 1.16.0
highlight-colors 0.9.0
highlight-selected 0.17.0
ide-python 1.5.0
kite 0.185.0
language-terraform 0.9.3
minimap 4.29.9
minimap-git-diff 4.3.1
minimap-highlight-selected 4.6.1
react 0.18.0
react-redux-snippets 0.1.6

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/20222. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Fix/link session context

Description
Sessions are not linked to a MethodContext if session is used but not created in the current method. This could happen if session was resused from a fromer setup or test method.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@Zsar There are Java formatting rules which are not needless and we should pay attention. IntelliJ IDEA do that in a good way.

Sadly I have not yet found a good way to mark my different comments with different priority. I do not care much about the formatting changes, so I'll just go and resolve the conversations pertaining to them.

@Zsar There are Java formatting rules which are not needless and we should pay attention. IntelliJ IDEA do that in a good way.

I feel I have to rebuke this, though, because there are a lot of issues with it.
There is no such thing as "the Java" formatting rules. Eclipse will format differently. Visual Studio Code will format differently. IntelliJ itself will format differently if, say, configured for a different project in the wrong scope. IntelliJ default might change at any time without notice! It might differ between two IntelliJ versions, even.
As a particular example, spending several lines on an empty block is most certainly needless. It can be done, it does little harm - but... no, there really is no need for that, not since punch carts went out of fashion.
Project level formatting, of course, is a thing and very much an established practice - but if we do not do that, format changes are arbitrary and nothing but noise.
Side notes:

Java does not exist in a vaccum. A lot of languages share large parts of its syntax and even semantics and are mutually considered in continued development. The very idea of "the Java" anything is harmful isolationism. Yes, in the early days of "this language will replace all others" Sun themselves exhibited that idea - but those days are long in the past. Like the colonies.
There is no standard feature set for formatters. I have yet to see two different formatters capable to produce identical output from non-trivial input. The notion that an IDE could provide our standard format is currently utopic. If we want a standard format, we have to bundle the formatter (e.g. as part of the CI pipeline or a git hook).


Pressing ctrl+z closes editor tab

Continuation of https://github.com/Microsoft/vscode/issues/40936 (could not reopen)
recording: https://i.imgur.com/jGiChM8.mp4

I opened a file, pressed "z", then I do "ctrl-z", as you can see it shows a close dialog. I cancel, remove the z with the back key, save using "ctrl-s", then I do "ctrl-z" again, now it closes it (since there's no pending changes

Then I open 2 files, and press "ctrl-z" on each, both get closed

I launched vscode from desktop (but I don't think opening from desktop or from terminal code . changes anything there). I'm not able to launch it with code --verbose since with reopening vscode, the issue doesn't happen anymore.
I'll try to  run vscode in verbose mode sometime (but I'm not often using terminal to launch it because of https://github.com/Microsoft/vscode/issues/13189#issuecomment-368322383)
Version 1.20.1
Commit f88bbf9137d24d36d968ea6b2911786bfe103002
Date 2018-02-13T15:31:21.019Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

@bpasero I tried , (just after rebooting too, like it happened this morning) but can't reproduce (with --disable-extensions or not, it's just hard to produce that bug, last time I had it was a few weeks ago, on another laptop)
For record, my extensions are:

Code Runner 0.8.7
Docker 0.0.25
EditorConfig fo VSCode
ESLint 1.4.7
JSON5 syntax 1.0.0
npm 0.3.3
npm intellisense 1.3.0
Python 2018.1.0

@caub so you could never reproduce when extensions are disabled? maybe some extension overwrites the keybinding for Ctrl+Z or you changed keybindings, can you check?

@bpasero It happens very rarely, I don't know how to reproduce this error
So it's not very annoying (except it loses you lose your edit history when it happens, since it close the file)
I just posted it, in case some other users experience it too (I would have added to my previous issue, but it was locked)

It happened again this morning, I launch it with extensions of course, in the devtools I only saw
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257 [Extension Host] TypeDefinition null

after restarting it's working normally

@caub can you see in the keybindings editor if any extension overrides this key combination?

none do

@caub does this still happen?

I didn't have it since that last time 2 months ago


Enhancement: gateway default port

Hello,
At the moment the "add gateway" dialog does not tell the user that the default port is 20000.
Many users won't have too much difficulty finding the correct IP address, but the port might not be as obvious. Giving a little help can't hurt.
The fix could be as simple as modifying the existing hint ("Port") to something more explicit like "Port (default is 20000)".
Other implementations are possible:

let the "Port" EditText be optional and use 20000 when it is empty
add a short explanation text at the bottom of the dialog
...

What do you think ?

Yep, nice hint. If you agree I would simply prefill the edittext with a default value.
I think initial value should be set in GatewayEditTextPreference#onCreateDialogView from OpenWebNet.OpenGateway.DEFAULT_PORT

I'm not sure that pre-filling it would be "The Right Thing To Do" :tm: .
If we pre-fill the text field the user will see this:

We lose the information that "20000" is a port (seems pretty obvious I know but anyway).
We could have both by:

adding the port number in the hint text, maybe using a format string to inject the value of OpenWebNet.OpenGateway.DEFAULT_PORT
modifying the dialog to accept an empty port, replacing it with the default value if it is empty.

I think that would give a better user experience.

You are right that we loose the information that is a port, so no prefilled value.
While I don't really like that port is set automatically if empty.
User should understand what is doing, so

or we modify the hint if we have enough space for "Port (default 20000)"
or probably is better to add a TextView below with "Default port is 20000" in italic and/or bold

What do you think?

I like the second idea: let's add a TextView below the dialog!
Could you provide me with the Italian translation of "Port (default 20000)" please ? :it:

Sure!

Porta (predefinita 20000)

Thanks ! :+1:

In fact i would need the translation for "Default port is 20000", it seems nicer.

In theory should be

La porta predefinita e' 20000

but I don't  like it, too long, this is better:

Porta predefinita: 20000

So also in english we should write:

Default port: 20000
Do you agree?

Would you like the English translation to be "Default port: 20000" then ?

yep!


Use application_choice polymorphic associations

Context
In the future, every application choice will have an application_experience or application_work_history_break. Through the exprienceable or breakable polymorphic columns.
This will allow the user to edit work experienceas or work history breaks for new application choices.
To enable this feature we must get the work expeirences and histories through the application_choice on the provider interface and vendor api.
We would look if the application_choice has the data we need and if not we go to the application_form.
Eventually when we migrate the data making every application_choice have work experiences or work history breaks, this logic will not be needed.
Changes proposed in this pull request
ApplicationChoice model
Work history components
Guidance to review
View someone's work history on review from the point of view of support/provider and vendor API.
https://github.com/user-attachments/assets/06879595-7295-4219-94ac-1b519a74cac4
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault
[ ] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Edit work experiences - Change db structure to accommodate work experience edits

If the work history is tied to the application choice, will it get lost when the application is carried over?
Could you have a look at the DuplicateApplication class (line 86) -- this might need to be updated.

Yes, they will get lost, I'll update the DuplciateApplication to carry over the work_experiences, volunteering and work histories to the application_choice as well.
They will need to come from the application_choice not the form though


Debug console in NodeJs does not display value returned via util.inspect.custom or toString

Environment details

VSCode Version: 1.21.1
OS Version: Win7 x64
Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce

Create the following javascript file in VSCode

const util = require('util');

class SomeObject{
    constructor(){
        this._varA = "some text";
        this._varB = 12345;
        this._varC = "some more text";
        this._varD = true;
        this._varE = 0.45;
    }

    [util.inspect.custom](depth, options) {
        return this.toString();
    }

    toString(){
        return "custom textual rapresentation of my object";
    }
}

var array = [];

array.push(new SomeObject());
array.push(new SomeObject());
array.push(new SomeObject());

console.log(array);

Run the code in debug mode and look at the debug console

Actual
This is displayed

Expected
In my opinion, this is not quite right. The inspect method is invoked as you would expect but the debug textual representation for the object instance is not shown to be the custom return string value.
Ideally, I believe the debug console should show the summary value of the object as: SomeObject { "custom textual rapresentation of my object" } while still providing the ability to drill down into the object (as it already does).
Additional Info
This started as a question on StackOverflow: https://stackoverflow.com/questions/49365663/how-to-change-string-representation-of-objects-in-nodejs-debug-console-view

Calling util.inspect to generate the preview when the object has overridden util.inspect.custom is a good idea.
I don't think we want to use it for every preview. Our preview should give a short high level view of the properties of an object, but util.inspect recurses and writes out every property of the object, and returns a multiline string where in the debug console, we can only show a single line.

@roblourens - anyway to override that one line would be great... I was not sure about inspect either. Maybe hooking on a toString() method if it exists would work better. I think that is the way it works in .NET + VisualStudio

I'm wondering if anyone has found a way/workaround for this. I'm debugging code that uses bignumber.js and hard to read the unformatted representations.

Also looking for a solution. As a Python turned TypeScript dev, I'm sorely missing Python's __repr__ magic method and PyCharms ability to display that as the textual representation of an object, if available. Having something similar in VSCode would be greatly beneficial for objects that have a bunch of properties, but there's a way to format some of them to give a good high-level view of what it is. When I have an array of over 200 object, this would be invaluable.
Perhaps a setting in VS Code that allow VSCode to call the toString method on an object to display in that one line?

please see the related item https://github.com/microsoft/vscode/issues/26234 which we plan to investigate in the August timeframe.

I believe this works fine with latest vscode insiders.
If you still see this not working please let me know and I will reopen

@connor4312 our investigation in #26234 showed that Custom Object Formatters need to be implemented by individual debug extensions. Therefore I'm reopening this issue for JavaScript.

Thanks for the tag. Merging this into https://github.com/microsoft/vscode/issues/102181 which is being revived by backlog issues.


Clean up special test collections/lists

Refactoring suggestions for MoreLinq.Test:

This pattern:

readOnly
    ? new UnenumerableReadOnlyList<int>(new[] { 1 })
    : (IEnumerable<int>)new UnenumerableList<int> { 1 };

Has come up often enough at this point that I think a future commit (or even this one) should consolidate it into a helper method of signature IEnumerable<T> GetUnenumerableList<T>(bool readOnly, params T[] items).

Unenumerable(ReadOnly)List should inherit from BreakingSequence.

Breaking(ReadOnly)Collection should be replaced with Unenumerable(ReadOnly)List.

Makes sense. The exact shape and form of the consolidation may become clearer and need debating when you submit a PR.

I'm currently leaning towards an extension method for 1): IEnumerable<T> ToUnenumerable<T>(this T[] enumerable, bool readOnly).


remove timeout_sec from region_backend_service

Fixes #53

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_whitespace
Failed whitespace check. More details below.

Checking for trailing whitespace
./CHANGELOG.md:9:* Remove timeout_sec from the google_compute_region_backend_service because it is ignored by GCP ([#53](https://github.com/terraform-google-modules/terraform-google-lb-internal/issues/53))
Error: Trailing whitespace found in the lines above.
Checking for missing newline at end of file

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate .
Success!
The configuration is valid.
terraform_validate ./examples/minimal
Error:
Invalid value for module argument
 on main.tf line 79, in module "test_ilb":
 79:   health_check =
local.health_check
The given value is not suitable for child module variable "health_check"
defined at .terraform/modules/test_ilb/variables.tf:73,1-24: attribute
"timeout_sec" is required.
terraform_validate ./examples/simple
Error:
Invalid value for module argument
 on main.tf line 44, in module "gce-ilb":
 44:   health_check =
local.health_check
The given value is not suitable for child module variable "health_check"
defined at ../../variables.tf:73,1-24: attribute "timeout_sec" is required.
terraform_validate ./test/fixtures/minimal
Error:
Invalid value for module argument
 on ../../../examples/minimal/main.tf line 79, in module "test_ilb":
 79:   health_check =
local.health_check
The given value is not suitable for child module variable "health_check"
defined at .terraform/modules/example.test_ilb/variables.tf:73,1-24: attribute
"timeout_sec" is required.
terraform_validate ./test/setup
Success!
The configuration is valid.


Eliminate references to the microk8s.upgrade command

The plan is to go with an microk8s.enable ha-cluster addon and not an upgrade command.

This does not need a review. this is "dead code" removal.


HTTP Proxy connection header fix.

HttpProxySocketFactory used to send CONNECT word 2 times.

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/oblac/jodd/blob/master/CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current behavior
At the moment HttpProxySocketFactory send wrong connect header to proxy.
New behavior?
It's fixed now to generate proper connect header and code made more readable.

Terrible sorry for long response :( Life.
@neroux Agree. thank you!


implement multi-factor auth

From @shurcooL in private email:

I have one concern that I've just realized. So I have a credit card  hooked up to my account, and I've realized the only thing stopping someone malicious from "hacking" into my account, changing my tipping amounts are my Twitter and GitHub passwords. I never made them secure enough to protect access to a credit card... So I should change them, but still, that feels like not the best way. I enter my Twitter login into my iPad, OS X, into browsers, etc.
Do you think that security is good enough as is, or should there be extra steps taken to prevent people messing with your account? Like a secondary password just for Gittip? Or two-step auth.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Closing in light of our decision to shut down Gratipay.
Thank you all for a great run, and I'm sorry it didn't work out! 😞  💃


[Bug] Group tooltip/dropdown window persistance

When manually changing the "group" of a signature with a filter applied, while the group is filtered out , the tooltip/dropdown window which shows changes being applied persists and does not go away. In order to get rid of the tooltip, the system you are viewing needs to be refreshed by clicking again on the system in the map.
I assume this is occurring because the "Signatures" window automatically jumps over to the "type" dropdown after specifying a "group", asking for the user to select the name of the type. Because the signature is automatically filtered out after specifying a group, wonky things start happening.
How to recreate the bug:

Filter out one or more groups in the "Signatures" window
Manually change the group to one of the options filtered out

Screenshots and gif of the bug in action:
Signature "HGW" before group is changed

Signature "HGW" after group is changed

Window persiting after changing group of signature "HZE"
The tooltip goes away after I click the system in the map window

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: You may reopen this issue if it has been closed in error.

Auto-generated response


Overlapping edges

In the following example an edge is being hidden behind another edge.   See the code in this JSFiddle.

If we move nodes C, D, E, and F you can see the hidden edge.

Can anyone take a look at this let me know if it is expected behavior or a bug?  I don't mind looking into the Dagre code, but I would rather not waste time if this is an expected result from the algorithm.

@ssmereka I know it's been a few years so you might not remember, but did you ever find a workaround for this?

@ssmereka I know it's been a few years so you might not remember, but did you ever find a workaround for this?

@NRWhittle I unfortunately do not remember.  I think it was still a problem, but the data we were displaying changed in a way that it was no longer an issue.

After some testing it I think it might be the graph's align property that's causing some overlap issues. This is a 3 node test case with rankDir = 'LR' and align = 'DR':

and then is what happens when I leave align as the default:

and then just for completeness, the same graph with rankDir being left as the default. With align = 'DR':

and with both rankDir and align as default:

Hopefully this might help anyone in the future seeing the same issues.


chore: update tslib

this PR updates the tslib dep to latest in the package.json file and yarn.lock, which fixes yarn bootstrap failing on node 18.
the other changes are simply a result of performing the yarn bootstrap command, so I can take them out of the PR if you want.

Pulled out the other ones into #2900; this is an ongoing problem, unfortunately.

do you wanna rebase this on main for me? not sure what to do specifically

do you wanna rebase this on main for me? not sure what to do specifically

There's no need for that; Github figures it out! other than the... other changes? No idea.

ok i did some manual edits and it should be good now


Fix bug for ID storage

Closes #110
Added a sampleNextId field to SampleDataUtil so that the next ID will be initialised correctly when sample data is loaded.

I think that bug was fixed previously already, it does not seem to happen anymore


haxe version.

hi, I'm having issues running your test.hxml file, what version of haxe is it meant to be using?
windows running 4.3.1 i get this
./hx_webserver/FormdataRequest.hx:38: characters 45-58 : Default argument value should be constant

and wsl running 4.2.5 gets the following
./hx_webserver/RouteMap.hx:33: characters 17-18 : Unexpected )

Try to use the haxelib release
haxelib install hx_webhserver 0.0.3

hmm okay, i'll check it out then (since I have moved to arch linux I'm not using the git version anymore, that's why i haven't got any issues)

hi @FurretDev, I didn't want to make a pr until i could get the tests running locally but it seems that might take a bit, if your interested in implimenting it I used the mime-db npm package to compile a more complete list of mime types. https://github.com/FurretDev/hx_webserver/compare/main...IanSSenne:hx_webserver:main if you want me to make this into a pr please let me know otherwise I'll just leave it be for the time being.
Have a good day :)

sorry for the delay in answering, go ahead and make a pr if you want, contributions are always welcome<3

i'm closing the issue due to inactivity :p


Using dropout layers

I would like to ask what is the proper way to use the dropout layers, I didn't find any suitable example which would describe it.
If we are about to use dropout layers should we use the dropout layers just for training and then replace them with affine transforms during testing similarly as it is done with batch normalization layers? Or is there something more we should in testing to account for earlier removed neurons in the training when the dropout was active?

Found in the resources: http://dlib.net/dlib/dnn/layers_abstract.h.html that one can even set value of dlib::multiply with dlib::dropout_(dropout_rate), so this must be the correct way of doing it. Thank you!


Trino Support

We're using Trino (previously called Presto) and it would be great to have first party support for Trino in dataframe.
With this little hack (delegating it to Postgre) it's already working for us but this is probably not a solution for all cases:
object Trino : DbType("trino") {

  override val driverClassName: String = "io.trino.jdbc.TrinoDriver"

  override fun buildTableMetadata(tables: ResultSet): TableMetadata = PostgreSql.buildTableMetadata(tables)

  override fun convertSqlTypeToColumnSchemaValue(tableColumnMetadata: TableColumnMetadata): ColumnSchema? =
    PostgreSql.convertSqlTypeToColumnSchemaValue(tableColumnMetadata)

  override fun convertSqlTypeToKType(tableColumnMetadata: TableColumnMetadata): KType? =
    PostgreSql.convertSqlTypeToKType(tableColumnMetadata)

  override fun isSystemTable(tableMetadata: TableMetadata): Boolean = PostgreSql.isSystemTable(tableMetadata)
}

Dear @PaulWoitaschek thanks for suggestions, we have a blocker in our plugins (symbol-processor) and could not provide for now free registration for any SQL sources, but I believe it will be a goal for next release, because it's a high demand there.
When we will finish the system redesign, we will provide a simple how-to in the spirit of your code snippet


Issue viewing gifs on reddit.com

ATTENTION! If you don't follow this template then your issue will be immediately closed.
Description of the problem
Unable to view gifs on reddit.com unless they are hosted by reddit. Gifs hosted on https://i.imgur.com/ for example do not load for me.
Url of the page where the problem occurs (not the image url)
reddit.com
Steps to reproduce the problem (include image url here)

Navigate to reddit.com
Hover over any gif hosted on https://i.imgur.com/
Profit? Don't profit? (There is a flicker, but no gif opens for viewing)

OS version, extension version (Chrome only, Firefox is not supported)
Windows 10 x64
Firefox doesn't have versions? Or you do not support the Firefox extension at all? The version listed in Firefox addons is 1.0.139. The Firefox version listed in Firefox options is Version 70.0.1
I am 100% new to github and apologise if I have done any of this wrong. I realise this is a free exstension you have created with your own free time. I really appreciate your hard work and I have to say, it is working so much faster and smoother than the previous one I had been using. Thank you!

Thanks. This is the forked version from the original which only support chrome. This repository is for firefox support.

OS version, extension version (Chrome only, Firefox is not supported)

I'm sorry, i forgot to edit that.
I will try to look in this issue

Thank you very much. I'm not sure why, but Firefox seems to run better on my pc, though I do occasionally switch back to Chrome.
If you could get it working I would be very grateful, but don't stress over it. :)


💅🏼  Set width of search input to almost 100%

closes TryGhost/Ghost#8630
Add width: 100% to .ember-power-select-search input class so the input field is full width.
Before:

After:

Coverage remained the same at 73.105% when pulling de600a4a22c5a927c5dcc2f6a21720214de5a8cb on AileenCGN:1.0.0-dev/ui-width-search-input into 3ff999e4aca2df29b5bef8668dbbf203e697dffe on TryGhost:master.


Setting it to async method

Setting it to async method

@haresh-suresh my main worry was about existing scripts not under our control using the previous version of the function (ie. https://github.com/draios/python-sdc-client/pull/111/files#diff-b7f06877dadbc7c6c5e53cde465bae46R310). Before the change, the async parameter was effectively set to False by default. Changing the default would change existing scripts. Is this anything to worry about?

@haresh-suresh my main worry was about existing scripts not under our control using the previous version of the function (ie. https://github.com/draios/python-sdc-client/pull/111/files#diff-b7f06877dadbc7c6c5e53cde465bae46R310). Before the change, the async parameter was effectively set to False by default. Changing the default would change existing scripts. Is this anything to worry about?

No, this shouldn't be a problem / worry. There is only consumer of this method. And that method call in cli is meant to be independent of the implementation here.
def post_analysis_file(cnf, file_location, retries=1, sleep_seconds=0):     ok, res = retry_api_call(retries, sleep_seconds, cnf.sdscanning.import_image, file_location)     return ok, res


Issue using plugin

If i have the plugin defined
plugins: ['karma-mocha-reporter']

I receive the following error (remove this line and all works just fine as expected)   Curious what functionality does the plugin supply

/home/merickson/code/angular/angular-sandbox/node_modules/di/lib/injector.js:9
      throw error('No provider for "' + name + '"!');
      ^

Error: No provider for "framework:mocha"! (Resolving: framework:mocha)

I am not sure if it's a problem with the reporter, because it is registered as reporter
'reporter:mocha'
It seems more like the testing framework mocha is missing. (karma-mocha)
Can you please share your complete config for further investigations.

Here you go (and karma-mocha is installed).  It all works fine so long as I dont reference it in the plugin.  Also included a screenshot of installed modules
// karma.conf.js
// Created: 5/9/2016 1:07 PM
// =============================================================================

module.exports = function(config) {
  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',

    // frameworks to use
    // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
    frameworks: ['mocha','sinon','chai-things','chai'],

    // list of files / patterns to load in the browser
    files: [
      'node_modules/angular/angular.js',
      'node_modules/angular-mocks/angular-mocks.js',
      'dist/bundle.js',
      'src/**/*.spec.js',
      'dist/_index.html',
    ],

    // list of files to exclude
    exclude: [
    ],

    // preprocess matching files before serving them to the browser
    // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
    preprocessors: {
      'src/**/*.html': ['ng-html2js'],
      'src/**/!(*.mock|*.spec).js': ['coverage']
    },

    ngHtml2JsPreprocessor: {
      // strip this from the file path
      stripPrefix: 'src/',
      // create a single module that contains templates from all the files
      moduleName: 'templates'
    },

    // test results reporter to use
    // possible values: 'dots', 'progress'
    // available reporters: https://npmjs.org/browse/keyword/karma-reporter
    reporters: ['mocha','coverage'],

    superDotsReporter: {
      icon: {
        success : ' ✔ ',
        failure : ' ✖ ',
        ignore  : ' ℹ '
      }
    },

    coverageReporter: {
      type : 'html',
      dir : 'coverage/'
    },

    // web server port
    port: 9876,

    // enable / disable colors in the output (reporters and logs)
    colors: true,

    // level of logging
    // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG
    logLevel: config.LOG_INFO,

    // enable / disable watching file and executing tests whenever any file changes
    autoWatch: true,

    // start these browsers
    // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
    browsers: ['PhantomJS'],

    // Continuous Integration mode
    // if true, Karma captures browsers, runs the tests and exits
    singleRun: true
  });
};

Could it be that your plugins section looks like this:
plugins: [
  'karma-mocha-reporter'
]

If so, karma only loads the reporter plugin but not the others, so karma-mocha is not loaded. So either you remove the plugin section from the config and karma takes care of loading all plugins. Or if you specify the plugins section, you have to enter all plugin names.

Yep, that seemed to be the issue.  Just had to specifically list all the plugins and all worked.
But, the reporter doesnt look much different than the existing mocha reporter karma-mocha?

I am not aware that karma-mocha ships it's own reporter. I thought it's only the test framework and the default karma reporter is used.

@4kochi yes, you are indeed correct.  My bad ;-)


Nuxt build error on version v0.3.1

When I run a npm run build on my site I get a Nuxt Build Error. The same error appears on Cloudflare Pages to. On version 0.2.2 the build was successful.
> npm run build

> build
> nuxt build

Nuxt 3.12.2 with Nitro 2.9.6                                                                                16:08:38
ℹ Using Tailwind CSS from ~/assets/css/tailwind.css                                                                  nuxt:tailwindcss 16:08:41
PS F:\miners online\website-v5> npm i

> postinstall
> nuxt prepare

ℹ Using Tailwind CSS from ~/assets/css/tailwind.css                                                                  nuxt:tailwindcss 16:08:57

 WARN  ENOENT: no such file or directory, scandir 'F:\miners online\website-v5\components\ui'                                          16:08:57

 WARN  Components directory not found: F:/miners online/website-v5/components/ui                                                       16:09:00

✔ Types generated in .nuxt                                                                                16:09:00

added 1 package, changed 1 package, and audited 1157 packages in 17s

287 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
PS F:\miners online\website-v5> npm run build

> build
> nuxt build

Nuxt 3.12.2 with Nitro 2.9.6                                                                                16:09:04
ℹ Using Tailwind CSS from ~/assets/css/tailwind.css                                                                  nuxt:tailwindcss 16:09:06

 WARN  ENOENT: no such file or directory, scandir 'F:\miners online\website-v5\components\ui'                                          16:09:07

 WARN  Components directory not found: F:/miners online/website-v5/components/ui                                                       16:09:09

ℹ Building client...                                                                                16:09:11
ℹ vite v5.3.1 building for production...                                                                                16:09:11
✔ Components metas parsed in 9311.63ms                                                                                16:09:20
ℹ ✓ 154 modules transformed.                                                                                16:09:22

 ERROR  x Build failed in 11.40s                                                                                16:09:22

[16:09:22]  ERROR  Nuxt Build Error: [vite:load-fallback] Could not load F:/miners online/website-v5/assets/css/themes.css (imported by virtual:nuxt:F:/miners online/website-v5/.nuxt/css.mjs): ENOENT: no such file or directory, open 'F:\miners online\website-v5\assets\css\themes.css'

  Error: Could not load F:/miners online/website-v5/assets/css/themes.css (imported by virtual:nuxt:F:/miners online/website-v5/.nuxt/css.mjs): ENOENT: no such file or directory, open 'assets\css\themes.css'

The components folder warnings is fine since I do not have any custom components.

The theming feature introduced a new tailwind file, which is a breaking change. You need to add the assets/css/themes.css file to your project. Or you can download a new starter template.

That fixed it, thanks for the help.


Fix failed Win unittest on colorama

This PR fixed the failed unit tests for Unix. Windows unitesting is failing because it runs uinttesting on colorama. I don't think those failed unittests are relevant to the application and when I create what seems like an identical environment locally, those unittests pass (both also with colorama version 0.4.6 not shown below).
CircleCI Win:
platform win32 -- Python 3.10.11, pytest-8.2.2, pluggy-1.5.0
rootdir: C:\Users\circleci\project
plugins: dash-2.14.1, mock-3.14.0
collected 241 items

python\tools\Lib\site-packages\pip\_vendor\colorama\tests\ansi_test.py . [  0%]
..                                                                       [  1%]
python\tools\Lib\site-packages\pip\_vendor\colorama\tests\ansitowin32_test.py . [  1%]
.................FF...                                                   [ 10%]
python\tools\Lib\site-packages\pip\_vendor\colorama\tests\initialise_test.py s [ 11%]
sssssssssF                                                               [ 15%]
python\tools\Lib\site-packages\pip\_vendor\colorama\tests\isatty_test.py . [ 15%]
......                                                                   [ 18%]
python\tools\Lib\site-packages\pip\_vendor\colorama\tests\winterm_test.py . [ 18%]
..FFFF.

Local Win:
platform win32 -- Python 3.10.11, pytest-8.2.2, pluggy-1.5.0
rootdir: C:\Users\jpasvolsky\pyenv\examples\tour_planning_3_10_11
plugins: dash-2.14.1, mock-3.14.0
collected 52 items

..\Lib\site-packages\colorama\tests\ansi_test.py ...                                                 [  5%]
..\Lib\site-packages\colorama\tests\ansitowin32_test.py .......................                      [ 50%]
..\Lib\site-packages\colorama\tests\initialise_test.py ssssssssss.                                   [ 71%]
..\Lib\site-packages\colorama\tests\isatty_test.py .......                                           [ 84%]
..\Lib\site-packages\colorama\tests\winterm_test.py ........                                         [100%]

===================================== 42 passed,

So until the failed colorama unitest is fixed, this PR should skip that test. If anyone has a better fix, let me know,

I reckon it could be fixed in the dwave-examples orb (who wrote/updates this?)

That was my first preference too but we need @randomir to update orb. I'd like to see if this fixes it until then and get the tests passing. Be happy to remove if orb can be used instead.


refactor RNNCellBase

What does this PR do?
Refactors the RNNCellBase API such that initialize_carry is an instance method.

Codecov Report

Merging #3053 (03d1f1c) into main (b3945f8) will decrease coverage by 0.01%.
The diff coverage is 95.58%.

@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   81.97%   81.97%   -0.01%
==========================================
  Files          55       55
  Lines        6031     6068      +37
==========================================
+ Hits         4944     4974      +30
- Misses       1087     1094       +7

Impacted Files
Coverage Δ

flax/linen/transforms.py
94.14% <ø> (ø)

flax/linen/recurrent.py
97.07% <95.58%> (-0.74%)
:arrow_down:

... and 2 files with indirect coverage changes

Closing this after this change landed


Blank page after login

After login on web ui

the application shows a blank page

but, it's possible to use the application changing the URL

same issue

Hmm, I just pushed the latest change for the UI. I
Can you guys try a fresh install by running rm -rf ~/osmedeus-base ~/.osmedeus and then run the install script again to have a clean installation?
Maybe try in the incognito to make sure the cache is clear as well

In my particular case it returning  wrong auth for a sec and then redirecting to blank page. Checked in several different deployments.

As of today this problem is not resolved on latest version v4.6.3


[example] Extruding a texture along a curve

This is an example that shows how to segment a curve and extrude a texture along it using a road as an example.

@JeffM2501 thanks for this great addition! 👍🙂


convertLength does not work for fromUnit !== 'px'

The file @material-ui/core/styles/cssUtils.js contains a method convertLength. It does not work if the provided length is not in px. This test …
it('should convert rem to px', () => {
  const convert = convertLength('16px');
  expect(convert('2rem', 'px')).to.equal('32px');
});

… will fail.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
import { convertLength } from "@material-ui/core/styles/cssUtils";
convertLength('16px')('2rem', 'px') // ==> '2rem'

Expected Behavior 🤔
import { convertLength } from "@material-ui/core/styles/cssUtils";
convertLength('16px')('2rem', 'px') // ==> '32px'

Looks like the method was badly ported over from https://github.com/KyleAMathews/convert-css-length.
I think this would make a great 'first issue', but not sure I'll take the time to handle it myself.
:v:

@stefanpl We have removed a bunch of logic from https://github.com/KyleAMathews/convert-css-length to focus on the use cases of the public responsiveFontSizes() helper. cssUtils is a private helper. What's your use case?

@oliviertassinari thanks for the quick answer. Broadly speaking, I'm trying to perform calculations on settings which can be provided in different units. I'd like to avoid using css's calc, since it's not widely (enough) supported in my target audience.

@stefanpl If you could look at what's wrong with our module and propose a fix, I think that we could accept it. We would still keep the module private, but you could use it at your own risk 😁.

I had a quick look, there is a return that has nothing to do here:
diff --git a/packages/material-ui/src/styles/cssUtils.js b/packages/material-ui/src/styles/cssUtils.js
index 69036c3198..7d81edfaba 100644
--- a/packages/material-ui/src/styles/cssUtils.js
+++ b/packages/material-ui/src/styles/cssUtils.js
@@ -33,7 +33,6 @@ export function convertLength(baseFontSize) {
         pxLength = toUnitless(length) * toUnitless(baseFontSize);
       } else if (fromUnit === 'rem') {
         pxLength = toUnitless(length) * toUnitless(baseFontSize);
-        return length;
       }
     }

diff --git a/packages/material-ui/src/styles/cssUtils.test.js b/packages/material-ui/src/styles/cssUtils.test.js
index f8f9f4510f..a013ff9b9f 100644
--- a/packages/material-ui/src/styles/cssUtils.test.js
+++ b/packages/material-ui/src/styles/cssUtils.test.js
@@ -41,6 +41,7 @@ describe('cssUtils', () => {
     it('should work as expected', () => {
       const convert = convertLength('16px');
       expect(convert('32px', 'rem')).to.equal('2rem');
+      expect(convert('2rem', 'px')).to.equal('32px');
     });
   });

@stefanpl If you want to work on a pull request, feel free too :)

I'll give the PR a try, if that is ok? :)


Git chapter revisions

Made changes to strcuture and added a list of common mistakes while brancing in teamwork.

@smith558 , can you please review changes to this chapter?

Accidentally reviewed this one too, so here are my notes on the chapter:
General

Cells with {admonition} code blocks do not seem to render at least for me.

Why Git

The bullet about "Data Integrity" is indefensible. Git does not checksum, lint, parse, or error-correct files on its own. You can use CI, hooks, or pre-push checks to do this, but that is a different (and advanced) thing which should be explained if we want to make this point.

Installing git

New git configuration explanation is excellent, really useful addition.

Your first repository

"Check your git configuration:" seems to just show nothing afterwards.
Spelling error: "Check agin git config --list to see if anything has changed." -> "Check git config --list again to see if anything has changed."
Tip about git flag combination uses the -a flag even though that hasn't yet been introduced (and possibly we should not introduce students to so early as it's generally a bad thing to do without experience).
Weird blank cell at the end (at least on my machine).

Commits

"A unique hash (SHA-1 checksum) in Git" should say "The unique hash (SHA-1 checksum) in Git"

Your remote repository

Do we need to really tell them how to rename their remote? Frankly I rarely have to do that, and more often than not it's more worth keeping origin as the default unless you have a good reason for changing it, just as it makes debugging easier.

Dealing with large files

One of the elements (3) in the Pre-Commit Git Hook section does not render properly.

Branching

LaTeX logo is accidentally double-escaped leading to it not properly rendering.
Commands below this demonstrating branches are in individual boxes with nothing separating them. They should either show the output, or be formatted into one code cell (or a multiline code fence within a markdown cell using triple backticks)

Common mistakes

(1.) Working directly on the main branch is bad when working in a team obviously, but we should really set them up with something like git-flow to give them a structure for working collaboratively rather than just telling them to use branches and making them figure it out for themselves. I see that we sort of talk about it in point 15, but maybe this should be moved up to be directly below point 1.
(2.) Similarly, not pulling latest changes is not a problem if you are on a branch which no-one else is working on, or one which is not tracked by a branch on the remote. If we really want to solve the problem described here, we also need to talk about rebasing etc. so they have a method for harmonising new commits on main with their branch prior to merging.
(10.) We shouldn't mention CI if we haven't introduced the concept before. That's just going to be very confusing, though it is absolutely a valid point.

@fwimp , thank you!
I am making changes accordingly.
BTW, Git does generate a checksum (that is one of the the core objectives of git) for each of the changesets (that covers all objects in  repo). The hash value represents this: https://git-scm.com/book/en/v2/Git-Internals-Git-Objects
Granted it does not do any linting etc, but that does not come under data integrity

OK, have made updates based on @fwimp's review

Re: integrity. I'd still say that git does not check to see whether the file is a valid file in any meaningful way. It checks to make sure that the git object is as it says it is, but does nothing about ensuring that the file is a valid file for its purpose. This is clearer in the rework thought so that looks good.
Feedback on the new version:
Your first repository

ll is equivalent to ls -al, not ls -ltr (which would be nearly equivalent to ll -tr, useful but not quite the same)
Still got that odd blank cell at the end, just above Fig. 9

Other than that, looks great! Not sure if @smith558 has anything to add?

@fwimp  I am a bit swamped today but following this conversation closely. 🙂 To be fair, I feel like you are more than well standing in for the reviewer, so I may just add something later.

@fwimp , I have addressed everything except the mystery code box - not sure what's going on, but I reckon its some obscure Jupyter book quirk (can be revisited later).
Please approve for merge.


[now dev] Add suppport for handle: miss

Codecov Report

Merging #3537 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
+ Coverage   14.51%   14.61%   +0.09%
==========================================
  Files         267      267
  Lines       10788    10800      +12
  Branches     1486     1492       +6
==========================================
+ Hits         1566     1578      +12
  Misses       9051     9051
  Partials      171      171

Impacted Files
Coverage Δ

src/util/metrics.ts
61.53% <0%> (-6.65%)
:arrow_down:

src/util/dev/router.ts
64.13% <0%> (-5.21%)
:arrow_down:

src/util/prefer-v2-deployment.ts
55.1% <0%> (-4.9%)
:arrow_down:

src/util/projects/get-project-by-id-or-name.ts
19.04% <0%> (-4.49%)
:arrow_down:

src/util/get-dist-tag.ts
66.66% <0%> (ø)
:arrow_up:

src/util/dev/builder.ts
65.88% <0%> (+0.59%)
:arrow_up:

src/util/get-update-command.ts
10% <0%> (+0.62%)
:arrow_up:

src/util/dev/server.ts
59.61% <0%> (+0.74%)
:arrow_up:

src/util/dev/builder-cache.ts
77.88% <0%> (+1.92%)
:arrow_up:

src/util/dev/yarn-installer.ts
83.33% <0%> (+3.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b6c47...d395f5e. Read the comment docs.


name' is unavailable: not available on iOS

name' is unavailable: not available on iOS
/Pods/NUIParse/NUIParse/Parsers/NUIPShiftReduceParsers/NUIPShiftReduceGotoTable.m:85:58: error: 'name' is unavailable: not available on iOS
return [(NSNumber *)[table[state] objectForKey:[rule name]] unsignedIntegerValue];
---> We are getting this issue while working on IOS 13.0 using XCode11 beta 6 version.
Please let us know the fix/update if any.

I ended up having to wipe every trace of xCode from my machine aside from the application itself and restart my machine in order to get past this error.

Is this issue resolved? I've cleared all processes and restarted the system as well. but I'm still not able to resolve this issue.

The only way I was able to move past this was to alter NUIPRule.h and NUIPRule.m and rename the name property to pname and replace any reference to it in the rest of the NUI classes. Not ideal but allowed my project to build again.

I fixed this issue adding a separate getter for the "name" variable. Details are in the my commit

NUIPShiftReduceGotoTable is missing import of NUIPRule.h

NUIPShiftReduceGotoTable is missing import of NUIPRule.h
There is #import <NUIParse/NUIParse.h>

NUIPShiftReduceGotoTable is missing import of NUIPRule.h
There is #import <NUIParse/NUIParse.h>

Nope
https://github.com/tombenner/nui/blob/v0.5.5/Demo/Pods/NUIParse/NUIParse/Parsers/NUIPShiftReduceParsers/NUIPShiftReduceGotoTable.h
https://github.com/tombenner/nui/blob/v0.5.5/Demo/Pods/NUIParse/NUIParse/Parsers/NUIPShiftReduceParsers/NUIPShiftReduceGotoTable.m

I am not an owner of this repo. Just fixed the issue and created a pull request from my repo. It is still waiting for review.
Pull request

I was talking about how to fix this error: all you need to do here is to add missing import in this file. Also this repo had a lot of changes made in non-master branch, so it's unlikely that any PR to master will go through

@Emailrus You are right.
#import "NUIParse.h" in NUIPShiftReduceGotoTable solves the problem. I did some extra work ))
So, the only way for now is manually update above mentioned class on the your computer.

In case if some is facing issue while running pod with @IlyaBoryanScopeTech solution
def nuiparse_overrides
    pod 'NUIParse', :git => "https://github.com/IlyaBoryanScopeTech/NUIParse.git"
end

target 'MyProject' do
    nuiparse_overrides

    pod 'NUI' # This podspec still references 'NUIParse' but is overridden above
    pod # ...
end

@hilalbaig Great advice! Thanks!

You can also use @hilalbaig's technique with https://github.com/tombenner/NUIParse.git now.


create_swapchain: TypeError: function takes exactly 3 arguments (5 given)

Hello,
i was trying the Swapchain example from your readme:
import glfw
from compushady import HEAP_UPLOAD, Buffer, Swapchain, Texture2D
from compushady.formats import B8G8R8A8_UNORM
import platform
import random

glfw.init()
# we do not want implicit OpenGL!
glfw.window_hint(glfw.CLIENT_API, glfw.NO_API)

target = Texture2D(256, 256, B8G8R8A8_UNORM)
random_buffer = Buffer(target.size, HEAP_UPLOAD)

window = glfw.create_window(
    target.width, target.height, 'Random', None, None)

if platform.system() == 'Windows':
    swapchain = Swapchain(glfw.get_win32_window(
        window), B8G8R8A8_UNORM, 3)
else:
    swapchain = Swapchain((glfw.get_x11_display(), glfw.get_x11_window(
        window)), B8G8R8A8_UNORM, 3)

while not glfw.window_should_close(window):
    glfw.poll_events()
    random_buffer.upload(bytes([random.randint(0, 255), random.randint(
        0, 255), random.randint(0, 255), 255]) * (target.size // 4))
    random_buffer.copy_to(target)
    swapchain.present(target)

swapchain = None  # this ensures the swapchain is destroyed before the window

glfw.terminate()

but i got his error:
  File "testing.py", line 18, in <module>
    swapchain = Swapchain(glfw.get_win32_window(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\venv\Lib\site-packages\compushady\__init__.py", line 199, in __init__
    self.handle = self.device.create_swapchain(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: function takes exactly 3 arguments (5 given)

i can't look deep enough into your code to determine what went wrong, any help is appreciated.
I am using Python 3.11, compushady 0.17.2, Windows 64 bit
If it is of any interest, i got here because i was looking foreward to play around with this repository but encountered this error:
https://github.com/HenBOMB/Py-Slime-Simulation/tree/main

Are you using the pypi package or you are compiling from sources? That error would make sense if you are using the 'samplers' branch

I used the PyPi version, just via pip install compushady
i just tried pip install git+https://github.com/rdeioris/compushady.git@main  which fails to build a wheel
then i installed the wheel posted in Issue #3, but on execution it throws the same error

Hi, there is a problem with the tarballs uploaded on pypi. You can manually clone the repo and just setup.py install it. I whould be able to upload new wheels on pypi (included the ones for python 3.12) by the end of the week

@mpumpa Pypi versions have been updated. I will wait for your confirmation before closing the issue.

yes, thank you. with version 0.17.3 it works as expected. Thanks for the help.


librespot cant connect to pulseaudio

Hi! So my issue:
I built librespot and installed it on my Pi. Im using pulseaudio. But when trying to use the pulseaudio backend i have issues. Here is the log:
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not write audio: Not connected to pulseaudio
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not write audio: Not connected to pulseaudio
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not write audio: Not connected to pulseaudio
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not write audio: Not connected to pulseaudio
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not write audio: Not connected to pulseaudio
27.07.20 17:51:19 (+0200)  spotify  [2020-07-27T15:51:19Z ERROR librespot_playback::player] Could not start audio: Connection refused

That goes on forever. Idk why it just not connects to pulseaudio and plays music.
My script:
#!/usr/bin/env bash

#Exit service if client-only mode is enabled
if [[ $CLIENT_ONLY_MULTI_ROOM == "1" ]]; then
  exit 0
fi

# Set the device broadcast name for Spotify
if [[ -z "$DEVICE_NAME" ]]; then
  DEVICE_NAME=$(printf "balenaSound Spotify %s" $(hostname | cut -c -4))
fi

# Set the system volume here
SYSTEM_OUTPUT_VOLUME="${SYSTEM_OUTPUT_VOLUME:-100}"

# Set the Spotify username and password
if [[ ! -z "$SOUND_SPOTIFY_LOGIN" ]] && [[ ! -z "$SOUND_SPOTIFY_PASSWORD" ]]; then
  SOUND_SPOTIFY_CREDENTIALS="--username \"$SPOTIFY_LOGIN\" --password \"$SPOTIFY_PASSWORD\""
  printf "%s\n" "Using Spotify login."
fi

# Start pulseaudio for librespot to use
pulseaudio --start --system=true

# Start librespot
exec /usr/src/librespot/target/release/librespot --name "$DEVICE_NAME" --bitrate 320 --cache /var/cache/raspotify --enable-volume-normalisation --volume-ctrl linear --initial-volume=$SYSTEM_OUTPUT_VOLUME $SOUND_SPOTIFY_CREDENTIALS --backend pulseaudio

Dockerfile:
FROM balenalib/%%BALENA_MACHINE_NAME%%-debian:buster
WORKDIR /usr/src

ENV PULSE_SERVER=tcp:audio:4317

RUN install_packages pulseaudio git build-essential libasound2-dev libpulse-dev libpulse0

# Install rust and cargo
ENV PATH=/root/.cargo/bin:$PATH

RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y

# Build librespot
RUN git clone https://github.com/librespot-org/librespot.git \
	&& cd librespot \
	&& cargo build --release --no-default-features --features pulseaudio-backend

COPY start.sh /usr/src/

CMD [ "/bin/bash", "/usr/src/start.sh" ]

Im building on balenaCloud, so things like installing packages are different, but its still apt.
https://www.balena.io/cloud/

Oh: N: [pulseaudio] main.c: User-configured server at tcp:audio:4317, refusing to start/autospawn.
I will investigate

ah. So basicly my actual server seems not to work. Hm i might need to find out what the cause is

Ah yeah this issue got resolved. Forgot to close it.


AlphaFold not working

I've been running Alphafold without many problems for a few months. It stopped executing tasks even the ones it used to be able to. Could you please help? :
Last 6 days alhphafold kept giving the same error message despite whatever protein sequence I ran. As a control I ran simple protein sequences that alphafold was able to predict before. Now it cannot do even these controls. Could you please help? Below is the error.
0%| | 0/7 [elapsed: 00:00 remaining: ?]
/usr/local/lib/python3.7/dist-packages/jax/_src/tree_util.py:201: FutureWarning: jax.tree_util.tree_multimap() is deprecated. Please use jax.tree_util.tree_map() instead as a drop-in replacement.
'instead as a drop-in replacement.', FutureWarning)
ValueError Traceback (most recent call last)
in ()
88 max_outer_iterations=3,
89 use_gpu=True)
---> 90 relaxed_pdb, _, _ = amber_relaxer.process(prot=unrelaxed_proteins[best_model_name])
91 else:
92 print('Warning: Running without the relaxation stage.')

having the same issue

Yes, we also encountered the same issue.  But when we use ColabFold (MMseqs2) in google, it has no problem.

Here is the error screen.

I also encountered this problem, looking forward to someone can solve it.

Same issue, too! Has the futurewarning arrived?

adding a flag to disable the relaxation stage in step 5. Running with run_relax=False can solve this problemn temporarily.

Thank you. Am trying that at the moment.
Regards,
Bruce

On 31 Jul 2022, at 6:08 pm, GaoSpark @.***> wrote:
adding a flag to disable the relaxation stage in step 5. Running with run_relax=False can solve this problemn temporarily.
—
Reply to this email directly, view it on GitHub https://github.com/deepmind/alphafold/issues/539#issuecomment-1200372401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWOLOXOR5KY4JE3GDSI5JNTVWYYADANCNFSM54IUFSMQ.
You are receiving this because you commented.

Bruce Milthorpe
@.***

Hi! Thanks so much for raising the issue. Closing this as there is a duplicate issue https://github.com/deepmind/alphafold/issues/383

Dear Hamish,
I wish all is well with you,
I could not use Alphafold because of this bug for the last two months or so. We have been paying for the Pro subscription all along. Is there a way to really solve this issue? Alphafold is not running even with simplest proteins right now. I am wondering what is wrong since it used to work with these simple proteins and it stopped all for good. Thank you!


Added new rules for CMP banners

Added rules for 3 websites.

@pritam2406 Thank you! This PR is getting pretty big. Let's stop where it's at. I have a refactor coming that I'll need help with, it'll allow us to submit handle CMPs with many different variants, and it makes them individually testable. I'll merge this as is and then make a new branch for that. Thanks again


Add duckdb-jfr-extension

I would like to add https://github.com/ocadaruma/duckdb-jfr-extension to the list.
Thanks,

That looks really cool :star_struck:


Is there a way to hide the password in the log?

I was wondering if there was a good way to hide the login password from the log?  Alternatively, could we disable logging for certain actions (like log in)?

+1

I ended up writing a wrapper for the RestClient that logs what I need to log, but is specific to the API I'm working with.
    # Private: Wrapper for the Gooddata REST client that performs logging and simplifies
    # setting REST parameters.
    #
    # method - Symbol speciying the REST method to use.  Curerntly only support :get and :put.
    # url    - Full URL to make the request against.
    # log    - Array that specifies whether requests and/or responses should be logged.
    #          Sometimes it is necessary to turn of response logging for large responses
    #          (e.g., data files).  (default: [:request, :response]).
    # &block - This method only works by specifying a block. It yeilds
    #          a RestParams object where the user sets the REST headers and values.
    #
    # Examples
    #
    #  rest_client :post, "#{url_base}/gdc/account/login" do |params|
    #    params.headers = {
    #      content_type: 'application/json',
    #      accept: 'application/json'
    #    }
    #
    #    params.values = {
    #      postUserLogin: {
    #        login: "#{username}",
    #        password: "#{password}",
    #        remember: 1
    #      }
    #    }
    #  end
    #
    # Returns a RestClient::Response when successful.
    def rest_client(method, url, log: [:request, :response], &block)
      params = RestParams.new
      yield params

      if Array(log).include? :request
        masked_values = params.values.to_json
        if params.values[:postUserLogin] && params.values[:postUserLogin][:password]
          masked_values = masked_values.gsub(/#{params.values[:postUserLogin][:password]}/,'******')
        end

        @rest_log.info "#{method.upcase}: #{url}"
        @rest_log.info "HEADERS: #{JSON.pretty_generate params.headers rescue params.headers}"
        @rest_log.info "VALUES: #{JSON.pretty_generate JSON.parse(masked_values) rescue masked_values}"
      end

      response = case method
      when :get
        RestClient.get url, params.headers
      when :post
        RestClient.post url, params.values.to_json, params.headers
      else
        raise "Unkown RestClient method #{method}"
      end

      @rest_log.info "RESPONSE (headers): #{JSON.pretty_generate response.headers rescue response.headers}"
      @rest_log.info "RESPONSE: #{JSON.pretty_generate JSON.parse(response) rescue response}" if Array(log).include? :response

      response
    end

    # Public: Simple class to hold headers and values for REST queries.
    class RestParams

      # Public: Initializes the REST parameters (headers and values).  Headers
      # and values may either be a hash or a JSON-formatted string.  Strings
      # are converted and stored as a hash.
      #
      # headers - The REST headers parameters.  May be a hash or a JSON-formatting string.
      # values  - The REST values parameters.  May be a hash or a JSON-formatting string.
      def initialize(headers: {}, values: {})
        self.headers = headers
        self.values = values
      end

      # Public: Returns the headers parameters as a hash.
      attr_reader :headers

      # Public: Returns the values parameters as a hash.
      attr_reader :values

      # Public: Setter for the headers.  Strings are parsed with JSON.  Otherwise,
      # it assumes the headers are stored as a hash.
      def headers=(val)
        @headers = val.is_a?(String) ? JSON.parse(val) : val
      end

      # Public: Setter for the values.  Strings are parsed with JSON.  Otherwise,
      # it assumes the values are stored as a hash.
      def values=(val)
        @values = val.is_a?(String) ? JSON.parse(val) : val
      end
    end

Heads up that OSVDB-117461 was filed for this.
That caused bundler-audit to recommend removing rest-client from an app's Gemfile.
$ bin/bundle-audit check
Name: rest-client
Version: 1.7.2
Advisory: OSVDB-117461
Criticality: Unknown
URL: http://www.osvdb.org/show/osvdb/117461
Title: Rest-Client Gem for Ruby logs password information in plaintext
Solution: remove or disable this gem until a patch is available!

Unpatched versions found!

It looks like logging is opt in, so if I'm correct you wouldn't be impacted unless you enabled it.

I don't have the time to implement a fix right now, but if someone is looking to jump in, this seems to be the point at which you'd have to implement log filtering: https://github.com/rest-client/rest-client/blob/master/lib/restclient/request.rb#L535

To elaborate on @derekprior's point, if I've been speed-reading the code correctly, rest-client doesn't log unless RestClient.log is set.

Repro:
ENV['RESTCLIENT_LOG'] = "stdout"
require 'rest-client'

RestClient.get<EMAIL_ADDRESS>
output:
RestClient.get<EMAIL_ADDRESS>"Accept"=>"*/*; q=0.5, application/xml", "Accept-Encoding"=>"gzip, deflate"
# => 404 NotFound | text/html 0 bytes

See referenced PR for a fix.

This is merged in release 1.7.3: https://github.com/rest-client/rest-client/releases/tag/v1.7.3
Thanks, everyone, for bearing with this report.


Amend liveness check port lookup to also check port bindings

Refs #128: Amend liveness check port lookup to also check port bindings (used for fixed port mapping) if no ports are exposed via the usual mechanism

LGTM


Publisher view is black android 9 samsung s9plus

In my android application whenever publish the video I am getting the black screen and getting error java.lang.runtime exception set parameters failed. I am using CustomVideoCapturer class. please help me.

Can you provide more details @surendrayalakala ?
Are you using the sample of this repo?
Have you done any modifications to it?

I'm also facing the same issue. Sometimes when I start publishing, session successfully connecting but the publisher camera preview gets black. And when I try to subscribe the same stream it shows the same black color on subscriber end. To make it work I have to kill the app and start publishing again.

@sagar-nickelfox can you provide some more details?
How is your use case? Are you conecting, going back and connecting again to an opentok session?
Are you reusing the publisher?
Which version of the sdk are you using?

Going to close this one. Please reopen if necessary.


New mouse step for low-level mouse down and mouse up actions

Building on the series of enhancements around Sikuli integration #361 and #365 for greater control of mouse, publishing a PR that adds a new mouse step.
This step lets user send a low-level mouse down or up event to the user interface. This can be used for complex UI mouse actions. For eg, when dragging and dropping UI elements -
// below drags the UI element left by 200 pixels
hover some_element.png
mouse down
target_x = mouse_x() - 200
hover (`target_x`,`mouse_y()`)
mouse up

Committed to master. Prior to packaged release, feature available from cutting edge version here -
https://github.com/kelaberetiv/TagUI#set-up


iOS doesn't focus input field when clicking on host

Tapping on the host outside the input field doesn't focus it any more on iOS.
The reason seems to be that iOS requires calls to focus() coming synchronously inside a click event (as discussed here, for instance).
Calling the focus() method from within a $timeout() call starting from version 3.1.0 seems to have broken this behavior.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.

IMHO, this issue should still be fixed. Keeping in mind that there is already a possible fix (see pull request), I'd appreciate if you could look into this, @mbenford .