[storage-file-datalake] 'Unable to extract accountName' exception when instantiating DataLakeServiceClient with an ADLS File System endpoint

Package Name: @azure/storage-file-datalake
Package Version: 12.0.0
Operating system:
[x] nodejs

version: 12.16.2

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[x] SDK API docs on https://docs.microsoft.com

Describe the bug
Instantiating a DataLakeServiceClient using an ADLS File System endpoint (e.g. https://{account}.dfs.core.usgovcloudapi.net) will fail and throw an exception with the error message: "Error: Unable to extract accountName with provided information."
To Reproduce

Follow the instructions documented at https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-directory-file-acl-javascript

Attempt to instantiate a DataLakeServiceClient using a ADLS file system endpoint

let dataLakeServiceClient = new DataLakeServiceClient(
  'https://{account}.dfs.core.usgovcloudapi.net',
  new DefaultAzureCredential()
);
let fileSystemClient = dataLakeServiceClient.getFileSystemClient("myfilesystemname");

You should receive an error:

Exception: Error: Unable to extract accountName with provided information.
Stack: Error: Unable to extract accountName with provided information.
at getAccountNameFromUrl (/node_modules/@azure/storage-file-datalake/dist/index.js:3538:15)
at DataLakeServiceClient.StorageClient (/node_modules/@azure/storage-file-datalake/dist/index.js:4631:28)
at new DataLakeServiceClient (/node_modules/@azure/storage-file-datalake/dist/index.js:7108:28)

Expected behavior
I should be able to provide the ADLS file system endpoint from my Storage Account and instantiate a new DataLakeServiceClient.
Additional context
Providing a blob service endpoint will return a MissingRequiredHeader RestError looking for a 'x-ms-blob-type' header.
getAccountNameFromUrl() does an explicit check for blob in the URL and will throw this exception: https://github.com/Azure/azure-sdk-for-js/blob/ef519c3c3f14f167e923d6f55fec8fb88cd315e1/sdk/storage/storage-file-datalake/src/utils/utils.common.ts#L549

I don't think there is anything wrong with the getAccountNameFromUrl you mentioned. As it's called with a blobEndpoint url that is transformed with the original URL.
And I can not recreate it. Note that

DefaultAzureCredential will first look for Azure Active Directory (AAD)
client secret credentials in the following environment variables:

AZURE_TENANT_ID: The ID of your AAD tenant
AZURE_CLIENT_ID: The ID of your AAD app registration (client)
AZURE_CLIENT_SECRET: The client secret for your AAD app registration

If those environment variables aren't found and your application is deployed
to an Azure VM or App Service instance, the managed service identity endpoint
will be used as a fallback authentication source.

How do you getDefaultCredential()?
Can you try this sample in your environment?
const { DataLakeServiceClient } = require("@azure/storage-file-datalake");
import { DefaultAzureCredential } from "@azure/identity";

// Load the .env file if it exists
import * as dotenv from "dotenv";
dotenv.config();

export async function main() {
  // Enter your storage account name
  const account = process.env.ACCOUNT_NAME || "";
  if (!account) {
    console.warn(
      "Account name not provided, but it is required to run this sample. Exiting."
    );
    return;
  }

  // Azure AD Credential information is required to run this sample:
  if (
    !process.env.AZURE_TENANT_ID ||
    !process.env.AZURE_CLIENT_ID ||
    !process.env.AZURE_CLIENT_SECRET
  ) {
    console.warn(
      "Azure AD authentication information not provided, but it is required to run this sample. Exiting."
    );
    return;
  }

  const defaultAzureCredential = new DefaultAzureCredential();
  const dataLakeServiceClient = new DataLakeServiceClient(
    `https://${account}.dfs.core.windows.net`,
    defaultAzureCredential
  );

  const fileSystemClient = dataLakeServiceClient.getFileSystemClient("myfilesystemname");
  await fileSystemClient.exists();
}

main().catch((err) => {
  console.error("Error running sample:", err.message);
});

You're correct, @ljian3377 that that is how we're obtaining a DefaultAzureCredential from within an Azure Function.
I omitted the getDefaultCredential(), but it's just an abstraction of the checks you have in your main and returns a DefaultAzureCredential(). For reference, here's that omitted method (it's the same as the sample you provided):
getDefaultCredential = () => {
  if (
    !process.env.AZURE_TENANT_ID ||
    !process.env.AZURE_CLIENT_ID ||
    !process.env.AZURE_CLIENT_SECRET
  ) {
    console.warn(
      "Azure AD authentication information not provided, but it is required to run this sample. Exiting."
    );
    return;
  }
  return new DefaultAzureCredential();
}

I did make an update to the original Issue for added context, I am accessing a storage account hosted at https://{account}.dfs.core.usgovcloudapi.net, but don't see how that would affect parsing the accountName.

@glennmusa did you try the same using an account in the public cloud vs gov?

@isamllr accessing the public cloud storage account works as documented.

Hi, ToBlobEndpointHostMappings and ToDfsEndpointHostMappings are exported by @azure/storage-file-datalake package.
Please add following mapping into ToBlobEndpointHostMappings and try again.
import {ToBlobEndpointHostMappings} from @azure/storage-file-datalake;
ToBlobEndpointHostMappings.push(["dfs.core.usgovcloudapi.net", "blob.core.usgovcloudapi.net"]);

//...

@ljian3377 We need to add national clouds suffixes into the default values of ToBlobEndpointHostMappings and ToDfsEndpointHostMappings.

@ljian3377 We need to add national clouds suffixes into the default values of ToBlobEndpointHostMappings and ToDfsEndpointHostMappings.

@XiaoningLiu  Are we able to enumerate all the possible hosts in the map? Or is it better if we simply replace the dfs part with blob.

Hi, ToBlobEndpointHostMappings and ToDfsEndpointHostMappings are exported by @azure/storage-file-datalake package.
import {ToBlobEndpointHostMappings} from @azure/storage-file-datalake;
ToBlobEndpointHostMappings.push(["dfs.core.usgovcloudapi.net", "blob.core.usgovcloudapi.net"]);

//...

Thanks for pointing that out @XiaoningLiu. This works.
We'll use this method for now and will keep an eye out for the implementation that includes the national cloud suffixes.
Appreciate the help @XiaoningLiu, @ljian3377, and @isamllr!

@XiaoningLiu Could you help provide a more complete list for this mapping.

I know of these three:
*.blob.core.usgovcloudapi.net
*.blob.core.chinacloudapi.cn
*.blob.core.cloudapi.de

According to @XiaoningLiu, also could add these three.
preprod.core.windows.net
core.microsoft.scloud
core.eaglex.ic.gov

Note that preprod.core.windows.net need to be put in front of core.windows.net.

The fix is now available in our July preview release. The GA release will be in August.

Already released the fix in 12.1.0-preview.1. It will be GA next release.

This should have been fixed in<EMAIL_ADDRESS>


fix: stop loading unsupported attributes into ManifestEntry

fixes https://github.com/MrBin99/django-vite/issues/100
django-vite v3's ManifestEntry is now a NamedTuple instead of a dict. So if there were any attributes in a manifest.json entry that were not explicitly named in ManifestEntry, it would throw an error.

Fixes: adds isDynamicEntry and dynamicImports to ManifestEntry.
Changed: also filters the data we insert into ManifestEntry so that only supported keys are loaded in, to prevent this from happening in the future.

This is really helpful, would be great if it could be merged in!

@MrBin99 @thijskramer
I'm open to signing on as a maintainer for this package. If you guys are interested in that possibility and want to talk it over, you can email me at<EMAIL_ADDRESS>

@MrBin99 @thijskramer
I'm open to signing on as a maintainer for this package. If you guys are interested in that possibility and want to talk it over, you can email me at<EMAIL_ADDRESS>
It would be great to add you as a maintainer! I'll check if I have the appropriate permissions for that, otherwise @MrBin99 has to add you.
Besides all that, I'll merge this PR and create a new release!

You bet. I'm glad to join the team! 😃


Add ElectronicDOS and XASSpectra properties

@ndaelman-hu
@JFRudzinski @Bernadette-Mohr only for you: I added properties/energies.py and a couple of properties, FermiLevel and ChemicalPotential. You can disregard the rest of the message.
I just finished this initial version. Mainly, you have to check properties/spectral_profile.py and properties/energies.py. I added some tests, but I have the issue that I would need some other sections in order to properly test the functionalities in ElectronicDensityOfStates, namely, I need ElectronicEigenvalues containing the info of the highest_occupied_energy and lowest_occupied_energy.
Besides these, I changed OrbitalsState and AtomsState to inherit from Entity. Do you mind giving your thoughts in here? I wanted to give an entity_ref that can be used to reference if a property is atomic or orbitally resolved, e.g., the projected DOS (but there might be others).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
153

Relevant Lines:
160

💛  - Coveralls

regard the rest of the messa

Thanks @JosePizarro3, I did see this. I will eventually use this as a basis and combine with the other energies that I had written down

@ndaelman-hu thanks for the comments
Would you mind checking again? I can also discuss the details on implementation is something is unclear.

@ndaelman-hu thanks for the comments
Would you mind checking again? I can also discuss the details on implementation is something is unclear.

Okay, will take a look somewhere this evening.

So, I brought up some additional edge cases to test for. The failing tests are what worry me most, though. Since it is all related to the pDOS, it could be tackled in a separate issue, but that has to be high on the priority list.
Regarding DOS in general, it really doesn't merit a fundamentally different treatment from other spectra. I think we can have a single class where name is used to specify the profile type.

Ok, tricky error in the conftest for fixing the testing for pDOS: I need to create a full Simulation object, and not simply let ModelSystem hang around. I will push something today so you can check the new generate_simulation_electronic_dos conftests (which returns the full Simulation, and not the ElectronicDensityOfStates section).

Ok, finished. @ndaelman-hu do you mind checking before going on holidays? Thanks!

Thanks @ndaelman-hu !
I am merging this and continue working on #52


Add Monitors for all components

See https://github.com/knative-sandbox/monitoring for context and usage.
I'm adding ServiceMonitors or PodMonitors for all components so that
Prometheus can scrape metrics from pods.

/assign @skonto for taking a look

@pierDipi how can I quickly test this? Run ./hack/run.sh build-from-source and then deploy? Do you have any sample setup to share with gist or something?

Yes, run ./hack/run.sh build-from-source and then deploy.
To generate traffic you can run ./hack/run.sh deploy-sacura

@pierDipi Did a test on minikube with the following commands:
./hack/run.sh build-from-source
./hack/run.sh deploy-infra
./hack/run.sh deploy
./hack/run.sh deploy-sacura

I compared metrics exposed at each component's endpoint on 9090 and metrics recorded at the Prometheus side:
kafka-broker-dispatcher-547cb8d667-fsln7  (kafka_producer_node_incoming_byte_total) OK
kafka-broker-receiver-57c949d997-9llzm   (kafka_producer_record_error_rate) OK
kafka-channel-dispatcher-5ff87488dd-4wvwc  (http_events_sent_total 0.0) OK
kafka-channel-receiver-76d8d4b8b9-5xcqr   (vertx_http_server_active_requests) OK
kafka-controller-5648bf66d6-qdqgz      (kafka_broker_controller_workqueue_work_duration_seconds_bucket) OK
kafka-sink-receiver-bbc58474b-wb7pg   (vertx_http_server_request_bytes_max) OK
kafka-webhook-eventing-7758bd958-nj67k  (kafka_webhook_eventing_go_alloc) MISSING

$ kubectl get podmonitors.monitoring.coreos.com  -n knative-eventing
NAME                       AGE
kafka-broker-dispatcher    13m
kafka-channel-dispatcher   13m
kafka-controller           13m
kafka-source-dispatcher    13m
$ kubectl get servicemonitors.monitoring.coreos.com  -n knative-eventing
NAME                     AGE
kafka-broker-receiver    14m
kafka-channel-receiver   14m
kafka-sink-receiver      14m

Targets discovered:

I have question here, does the user need to apply the monitoring manifests manually with kubectl -Rf .... If so let's document it. Are you planning to document the exposed metrics API and also provide some e2e tests?

does the user need to apply the monitoring manifests manually with kubectl -Rf .... If so let's document it
Are you planning to document the exposed metrics API and also provide some e2e tests?

Yes, I'll do this in a follow-up PR.

/lgtm Also if you dont mind pls expose at some point the webhook metrics. If not in this PR in some other.

/lgtm

/assign @matzew


pass "exclude" args to mksquashfs for storage-deficient devices

Motivation for this change
This is debatable and I do not claim that the current behaviour is wrong.  But: when building NixWRT images for storage-starved systems (one of my routers has 4MB flash) it is convenient to be able to say, for example, "exclude lib*.a and man pages" without having to hack  every derivation that currently installs them.
  squashfs = pkgs.callPackage <nixpkgs/nixos/lib/make-squashfs.nix> {
    storeContents = packagesToInstall ;
    excludeWildcards = [ "... lib*.a" "... man/man[1-9]" ];
  };

Maybe it's generally useful, maybe it's a bit niche.  If the latter, would you accept a more general patch to add any options at all to the mksquashfs call?
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Ping?

I'm adding another hack to make-squashfs.nix in https://github.com/NixOS/nixpkgs/pull/52967/commits/e9775e5ca42ddd069fccfde6aadd3d0dc30f24bc. If it is merged, you can implement your niche request by overriding comp argument:
  squashfs = pkgs.callPackage <nixpkgs/nixos/lib/make-squashfs.nix> {
    storeContents = packagesToInstall ;
    comp = "xz -Xdict-size 100% -wildcards ${stdenv.lib.concatStringsSep " " (map (f: "-e '${f}' ") excludeWildcards)}";
  };

Are there any updates on this pull request, please?

I'd say, this is pretty niche usecase. My PR https://github.com/NixOS/nixpkgs/pull/52967/files is merged, so workaround using comp argument can be used instead.
I regret now I've named the argument so narrow-scoped... It should have been called extraSquashfsArgs... But it should work here.


[tests] Enabled PCH for testing builds that have COMGR enabled (removed WORKAROUND_ISSUE_898)

This finally resolves #898. Additional info:

https://github.com/ROCmSoftwarePlatform/MIOpen/issues/898#issuecomment-1036629696
https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1469#issuecomment-1076778427

@junliume @shurale-nkn Please review and push though CI. Thanks!

@junliume IMO urgency of this is high.

@junliume IMO urgency of this is high.

CI is blocked due to resource limitation, working to resolve it :(

@atamazov  @shurale-nkn  this has to be reverted due to #1506

@junliume @aska-0096

@atamazov @shurale-nkn this has to be reverted due to #1506

No. The guilty PR is #1419. Please see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1419/files#r834358074

@junliume @aska-0096

@atamazov @shurale-nkn this has to be reverted due to #1506

No. The guilty PR is #1419. Please see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1419/files#r834358074

@atamazov thanks! Will re-open this one after #1481 is merged.


Query message Line # link starts at 0

SQL Operations Studio Version: master

Steps to Reproduce:

Run a query

Expected: Line numbers start at 1
Actual: Line number start at 0

This is a duplicate of https://github.com/Microsoft/sqlopsstudio/issues/2320.


RGB->HSB Conversion Issue

Within GetRGB of Q42.HueApi.ColorConverters.HSB is the following:
//Convert Hue into degrees for HSB
hue = hue / 182.04;
//Bri and Sat must be values from 0-1 (~percentage)
brightness = brightness / 255.0;
saturation = saturation / 255.0;

Note that both brightness and saturation are divided by 255. However the Philips Hue documentation states that both these values have maximums of 254. So shouldn't the above calculation divide by 254 instead of 255?
If so, then this logic applies throughout the ColorConverters.

This code was contributed by @CharlyTheKid in 2016 https://github.com/Q42/Q42.HueApi/issues/70
So not sure, sometimes the documentation is wrong and you can get a 255 value back even it the docs says you don't.

If I set a color via the official Philips Hue app and force the brightness slider to 100%, the reported brightness value is 254.
Based on my testing if I send #FF0000 (pure 'red' at RGB = 255,0,0) to the Hue lights (mine are Gamut C), the color reported back by the lights is #FE0000 (almost pure 'red' at RGB = 254,0,0). I don't think it is possible to convert HSB to RGB and get RGB = 255,0,0 without being able to hit 255 brightness.
After re-reading the API docs I found that brightness is 1-254, and saturation is 0-254. Here's the info (inside the light state object):

I thought I read somewhere that Philips made a conscious decision to make certain values NOT range from 0-255 for rounding simplification. Though that doesn't seem to make a ton of sense considering the above 1-254 and 0-254 ranges exist.
Any additional thoughts @CharlyTheKid?


Notifications: HTTP / webhook type

Current there are two notification types implemented: SMTP for email and Twilio for SMS.
As there are endless possibilities esp. for SMS providers, we should provide a possibility to send the notification to an HTTP / webhook endpoint (like actions v2), where it can be handled / relayed to the corresponding provider.
The endpoint can indicate a success / failure by the HTTP status code and the notification handler inside ZITADEL can treat it the exiting way and retry later on after a failure.
So simplify the authentication process / reduce the amount of possible ways of authentication on the external endpoint, the call / implementation should follow / reuse the actions V2 and sign the request.

relates to https://github.com/zitadel/zitadel/issues/7658


build: adds OIDC authentication for AWS

This is significantly more secure than using static tokens.

PR is blocked until upstream issues with std-action are resolved.


FIX: Fix Travis

Let's see if this works. From:
https://github.com/ContinuumIO/anaconda-issues/issues/1365

Coverage increased (+0.1%) to 77.248% when pulling f8bea2d401a0518586e5c6c2cc840b0fd23a742b on Eric89GXL:fix-travis into 7832ad8d94adaed6c26685e1aa3b9cc0d28fe327 on nipy:master.

Looks like we're green! I'll merge so that other PRs can actually get feedback, but if people feel like looking and commenting feel free and I can fix anything in a follow-up PR


adjustments to real_ time test for PyTorch models.

Workstream completed -- pytorch too slow for inference. Closing PR.


Pool composition chart

Except for LQ (with the long symbol names) the chart looks pretty nice I think. Otherwise the first 2 commits can be cherrypicked and someone else can have a go :)

@danielmkm Guess we can close this one now?


Fixing Sustain Notes When The Direction is Changed

Fixing some stuff, I like changing direction for notes!

maybe u could show some video so people can see what it does

This is a really good fix, I need this to force the opponent to remain on upscroll and the sustains are buggy with the new note system. Thanks :)

The sustain arrows are not reducing, I'm trying to fix it.

would really love this pulled since I'm making this
https://user-images.githubusercontent.com/35108759/151361652-f3e1b63e-7a35-4120-955c-f919a99b4ca0.mp4

the sus clip isnt on the center anymore if you didnt notice it yet


Exception raised if the water content KWs are not loaded!

  File "/data/work/amiguel/sBART_private/SBART/template_creation/telluric_templates/Telluric_Template.py", line 242, in _search_reference_frame
    warnings.warn(
    │        └ <built-in function warn>
    └ <module 'warnings' from '/data/work/amiguel/env/lib/python3.8/warnings.py'>

TypeError: category must be a Warning subclass, not 'str'

Fixed on github. To appear on v0.1.7


⚠ Bofrost.at has degraded performance

In b015b6e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1473 ms

Resolved: Bofrost.at performance has improved in 8102a7a after 6 minutes.


Laravel 6 compatibility

@themsaid any plans for new release?

One more developer waiting for Laravel 6 compatibility :)

One more. Six months. What do we do here?

#100 implements support for Laravel 7, but the changes should work for 6 as well I believe


ENH:  Add adaptive denoising module.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[x] Added test (or behavior not changed)
[x] Updated API documentation (or API not changed)
[x] Added license to new files (if any)
[x] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Still a couple issues:

This test is commented out because it fails here and I don't know why.

I thought I saw somewhere where specifying the image dimension in a class no longer follows this style  but I can't remember where I saw this or what the alternative syntax should be.

A lingering issue:

I thought I saw somewhere where specifying the image dimension in a class no longer follows this style  but I can't remember where I saw this or what the alternative syntax should be.

That macro was modified with ITKv5, but I think it is still a good choice.
It looks like you fixed the superclass test failure?

Thanks @dzenanz .  I have no idea as to what I need to do next but I'll ask over at the conversation on discourse.


Configurable language type for number fields?

Hi,
first thanks for this project!
As BigDecimal is heavy weight, could it be an idea to make this configurable? So it's possible to use Int or Long.
Regards.

Hi Michel, I know what you mean, but the generator has to choose a class that will hold the range of values possible according to the schema.  For a numeric field, the generator will choose the narrowest form it can to hold the value, based on what it knows about the constraints on the value.
If the number is an integer ("type": "integer") it will use Long, or if it has further information (minimum and maximum values in the 32-bit range, or enum values that are all 32-bit) constraining the values to 32 bits, it will use Int.
Is it possible for you to add integer type or the relevant validations to your schema to limit the range of values?
I realise that in some cases you may be working with an externally-provided schema so modification is not possible, but I would prefer to use the information in the schema where possible.
Regards,
Peter

Hi Peter,
sorry my bad. I created this issue based on the README - phrase "fields of type number are implemented as BigDecimal (there is insufficient information in the schema in this case to allow the field to be considered an Int or Long)"
Therefore i did expect BigDecimal, but now on my tests Long type was generated, all fine.
Sorry for your wasted time ;)
Regards
Michel

No worries, thanks Michel.  I've made a note to myself to clarify that section of the README.

@pwall567 Can I maybe reopen this ticket? I understand that BigDecimal is indeed the only "safe" general mapping for "number" types in JSON Schema, but java.math.BigDecimal is Java-specific and therefore available in Kotlin/JVM only, and thus doesn't work in Kotlin Multiplatform projects (or single-platform Kotlin/Native and Kotlin/JS projects for that matter).
I did some searching for a Multiplatform replacement library for java.math.BigDecimal, and I found this one: https://github.com/ionspin/kotlin-multiplatform-bignum
As a temporary workaround in my current project, I wrote a Gradle task that replaces each occurrence of java.math.BigDecimal with com.ionspin.kotlin.bignum.decimal.BigDecimal right after the json-kotlin-gradle finishes generating the source. Of course I also had to had to add this common library dependency in my Gradle project. But this solution does seem to work for me so far.
So it would indeed be nice if the default mapping for number types in JSON Schemas could be overridden, even if just for the Multiplatform use case. Of course with the caveat in the documentation that it may be dangerous when people use this functionality to map these types to less precise types in Kotlin, such as Int, double, etc.
Unfortunately, Kotlin does not define an "official" equivalent for BigDecimal in its standard library. So unless you'd want to add a library like kotlin-multiplatform-bignum as a dependency to json-kotlin-schema-codegen, it's probably not a good idea to use com.ionspin.kotlin.bignum.decimal.BigDecimal for everyone by default. I think just offering the option to override the default mapping for the number type would be the simplest solution here.
Thanks for considering this!


Rewrite convert_png_tiles to use PIL instead of PyPNG

Using a more familiar library may facilitate the palette conversion process, requiring less preparation from the user.

Fixed in eda66adbb020bcb2c6f5ca14ad717fc9448c010c.


[NavigatorIOS] Component Cannot be Push Into NavigatorIOS When it was required in different JS files

I have a react component ItemListScreen in ItemListScreen.js.
If I do require("./ItemListScreen.js") both in index.ios.js and example.js, then push ItemListScreen into a NavigatorIOS in second file, the error occurs: Invariant Violation: Expected a component class, got[object Object].
If I only require it in example.js, it works perfectly.
Any Help?

Do you have any dependency cycles?

I had this issue in the past with the NavigatorIOS.
How I solve this is that you can require the component inside the function. Let me know if this works for you. I haven't tested this since v0.6.0.
For example:

var MyView = React.createClass({
   render: function(){
       <View>
           <TouchableHighlight onPress={this.openList}>
              <Text>Open List</Text>
           </TouchableHighlight>
       </View>
   },
   openList: function(){
        var ListScreen = require("./ItemListScreen.js");
        this.props.navigator.push({title: 'ListScreen', component: ListScreen});
   }
});

stackoverflow answer here as well
https://stackoverflow.com/questions/30242154/react-native-navigator-recursive-children-crashes/30282297#30282297

@ide Yes, I found a dependency cycle in my files.  @yamill @cyprusglobe , It works if I require it in the function. Thanks.


How to get current stage name in task?

How to get current stage name in task?

Closing because I’m not sure this is an issue, if you are convinced that this is really a bug, please feel free to re-open the issue and add more information (your versions (Ruby, Cap, etc), your Capfile, your logs, and relevant sections out of your Gemfile)
Otherwise support is done via the mailing list (https://groups.google.com/forum/#!forum/capistrano) or at StackOverflow (http://stackoverflow.com/questions/tagged/capistrano) with questions tagged capistrano.

For what it's worth, it's very very simple...
fetch(:stage)

Here's a trivial example:

Thank you very much. I know how to fetch variable. But I googled before posting this issue how to find variable name, but to no avail. Later I began to look source code, reached optionparser line and stuck there. And you posted answer.

I try to discourage posting "help requests" on the Github (Issues) tool since we have two other support forums which we maintain (IRC and the Google Group), and the community maintains stack-overflow itself.

Ok, my bad. I have to used post such requests with other repos. So I didn't knew it's not be encouraged.


False Positive Vulnerability for CVE-2016-7037 against datawire/ambassador:1.7.2

Is this a request for help?:
Yes
Is this a BUG REPORT or a FEATURE REQUEST? (choose one):
BUG REPORT

Version of Anchore Engine and Anchore CLI if applicable:
anchore-cli version: 0.8.1
anchore engine version: 0.8.1
What happened:
Viewing the results of "anchore-cli --u admin --p foobar image vuln docker.io/datawire/ambassador:1.7.2 all" lists vulnerability CVE-2016-7037 for package jwt-1.0.0. This vulnerability is about php, and speaking to the ambassador folks php isn't even part of ambassador, so this vulnerability appears to be a false positive. I also get this same result when using the inline scanner.
What did you expect to happen:
I did not expect to see this vulnerability be listed against datawire/ambassador:1.7.2

Any relevant log output from /var/log/anchore:
No
What docker images are you using:
datawire/ambassador:1.7.2
How to reproduce the issue:
Add datawire/ambassador:1.7.2 image and view vuln report
Anything else we need to know:
Whitelisting this vulnerability is an option, but whitelisting would require that every few months I would have to file paperwork explaining why there's a false positive vulnerability against our project and hope that management will allow this project to continue.

I think this is similar to the issue I've reported a few weeks ago. Maybe you will find @zhill answer helpful. Basically, ambassador is using some other jwt package (not the php one) that anchore-engine detects, however the NVD matches the one in the CVE.


Implement format

Coverage remained the same at 100.0% when pulling 8f012c81a626a28c963a13027a9a87f1a0a9d477 on vishaldeepak:implement-format into 3099688dc9e8c91784177e43dc624bca6a3e037e on mathewdgardner:master.


Rename loan-transactions to loans-overview and move to correct section

Description
Rename loan-transactions to loans-overview and move to correct section
Type of change
Please delete options that are not relevant.

[X] New document(s)/updating existing
[X] Fixes
[ ] Styling
[ ] Bug fix (non-breaking change which fixes an issue)

Hi @iangurney,
Thank you for addressing the comments. As you are aware, we are currently in the docs freeze, and unfortunately, the changes you are planning to make will result in a conflict for us.
You have two options:

Closing this PR and opening another one after the freeze is done to make these changes. This means you will contribute to our main branch after it has been overhauled.
Closing this PR and opening another one to contribute to the fix-typos branch instead of the main branch. This means you will contribute to the overhaul branch, and your changes will go live together with the overhaul itself.

If you need any guidance on either action, give me a shout.
Thanks,
Polina


ImportError: cannot import name 'Queue'

Latest merge into #memory (Feb 5th), looks like a Queue class was removed but still trying to import:
/home/lefnire/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:34: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Traceback (most recent call last):
  File "hypersearch.py", line 29, in <module>
    from tensorforce.agents import agents as agents_dict
  File "/home/lefnire/tensorforce/tensorforce/agents/__init__.py", line 17, in <module>
    from tensorforce.agents.constant_agent import ConstantAgent
  File "/home/lefnire/tensorforce/tensorforce/agents/constant_agent.py", line 27, in <module>
    from tensorforce.models.constant_model import ConstantModel
  File "/home/lefnire/tensorforce/tensorforce/models/__init__.py", line 17, in <module>
    from tensorforce.models.memory_model import MemoryModel
  File "/home/lefnire/tensorforce/tensorforce/models/memory_model.py", line 23, in <module>
    from tensorforce.core.memories import Memory
  File "/home/lefnire/tensorforce/tensorforce/core/memories/__init__.py", line 18, in <module>
    from tensorforce.core.memories.prioritized_replay import PrioritizedReplay
  File "/home/lefnire/tensorforce/tensorforce/core/memories/prioritized_replay.py", line 22, in <module>
    from tensorforce.core.memories import Queue
ImportError: cannot import name 'Queue'

How do you mean, removed?
https://github.com/reinforceio/tensorforce/blob/memory/tensorforce/core/memories/queue.py
Might be an error with import order in the init, pushed a potential fix if you could try again

@michaelschaarschmidt that fixed it!

ok great


Integration build a small memory image

Modify one of the integration builds so that that the OPENSSL_SMALL_MEMORY option is compiled.  There doesn't appear to be an automatic build with this option set.
I think the options in the modified build are covered elsewhere (without the small memory) but a new job might still be preferable.

I guess I should also add that as one of the alternative options for the fuzzing.

I'm unclear on how configs multiple in travis, so i'd like @dot-asm to review this.

ping?

Having a fuzz test with this option set sounds like a decent idea.

it isn't clear to me as to which fuzzing test should be updated.
I'm not aware of the difference between TESTS="-test_fuzz" and -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION and which would be more suitable for small memory as well.

Just update fuzz/README.md. It has a list of various different
configurations I fuzz for, so the corpus would get updated to
also have coverage for that.
If you have TESTS=-test_fuzz it just means that during "make
test" it doesn't run the fuzz/*-test program with the corpus
as test inputs. I don't think it's that important to run it.
-DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION enables some things
to make the results reproducible. I think it currently only
makes the random numbers predictable, but then even only in the
fuzz/* binaries that set a variable.
Kurt

Thanks for this.  I'll move the small memory option onto one of the fuzzing builds.

Is there a second reviewer for this?

done, thanks!

This is now one of reasons why master https://travis-ci.org/openssl/openssl/branches is all red.
[I don't quite follow. "Files changed" says that it asan config that was modified, while in reality ubsan is.

Sure.

For reference. Originally ARIA_u128 was 'typedef unsigned char ARIA_u128[16]'. New code redefined it as union, but used it only for references to key schedule, never to data. And original code was modified to accommodate new definition. Correct solution to the problem at hand is to define two types, one to reference key schedule and one to reference data in original code free of implicit alignment requirement. There are two way:. a) revert modifications to original part that were triggered by the switch to union; b) define "data access" type as struct with c[16] alone. I'm leaning toward b)...

reverted.  will have to come back to this :)

Errr....all this is doing is doing an integration build of an OPENSSL_SMALL_MEMORY build. By reverting this we are just hiding the issue. I assume we are going to reapply this PR when the underlying issue is fixed? And is @dot-asm working on fixing the underlying problem?

By reverting this we are just hiding the issue.

The major reason for why I replied positively to suggestion to revert it, because I haven't got any reply to question about how come "files changed" doesn't match observed changed in repository. I'd still love to hear answer...

As for "files changed" it now properly shows just one file.  So cosmic rays in the github computers I guess.
configure -DOPENSSL_SMALL_FOOTPRINT with clang and all tests pass.
Configure -DOPENSSL_SMALL_FOOTPRINT with gcc and all tests pass.
So what's broke?  @pauli-oracle can you push a no-op commit so we can see travis builds again?

I rebased to the current master and committed (merge conflicts).
The tests will tell.

One of the tests failures looks to be unrelated (external tests in a case that isn't modified).
The other is a small memory problem with whirlpool.  I've created #3533 which I think addresses this, although I could easily have missed something.

Once again, "files changed" indicated [and still do] that it was enable-asan line that was modified, while what one could observe in the repository was modified enable-ubsan line. Closer look suggests that it looks like only first commit of the suggested two was applied.  Yes, there is an upside to it, since we did catch an asan bug in Whirlpool (as per #3533) and ubsan warning in Aria [and OCB] (as per #3526), but it doesn't change the fact this request was not handled appropriately. It does call for question what is [more] appropriate to modify, asan or ubsan. Well, formally neither, as we don't want to exclude tests of the mainstream code. But if one had to choose, asan would be less appropriate choice, because there is only one, while there two ubsans. But that would still be thing that is less inappropriate to do. Right thing to do is to add tests, not modify existing, but additional ones do take resources. Compromise solution should be to once in a while run whole thing with additional -DOPENSSL_SMALL_FOOTPRINT...

Is there a policy about adding builds to Travis?
Ideally both asan and ubsan would be built and run using -DOPENSSL_SMALL_FOOTPRINT.
The once in a while running would work, so long as someone remembers to do it.

No, there's no policy.  We add stuff until it gets too backlogged, then we take things out.  The Travis folks have increased our quota a couple of times.  On our own servers we do run various build options (testing all the no-xxx flags), so we could also do that here.  Ping @levitte to see about setting that up :)

Leaving this to your internal tests sounds reasonable.

@levitte could you set up a small memory bulid on the OpenSSL servers please?  To catch any future problems.
I'll close this PR since changing the Travis builds seems unnecessary.

I can certainly do that.  What I wonder, though, is if I should do these builds:

asan
ubsan
asan + -DOPENSSL_SMALL_FOOTPRINT
ubsan + -DOPENSSL_SMALL_FOOTPRINT

or just the last two...

The first two are covered by the Travis builds, so they'd be optional.  If the builds don't take too long already, more testing is better than less.


Segmentation fault on Ubuntu

Log:
[    real,      cpu,   maxRSS]
[0.000000, 0.007320,  5468 KB][DEBUG]: This is tofi.
[0.000039, 0.007359,  5468 KB][DEBUG]: Config done
[0.000048, 0.007367,  5468 KB][DEBUG]: Connecting to Wayland display.
[0.000070, 0.007389,  5468 KB][DEBUG]: Creating xkb context.
[0.000086, 0.007405,  5468 KB][DEBUG]: First roundtrip start.
[0.000315, 0.007434,  5468 KB][DEBUG]:     Bound to shm 1.
[0.000324, 0.007443,  5468 KB][DEBUG]:     Bound to compositor 4.
[0.000328, 0.007447,  5468 KB][DEBUG]:     Bound to data device manager  6.
[WARNING]: Using an outdated compositor, screen anchoring may not work.
[0.000333, 0.007452,  5468 KB][DEBUG]:     Bound to zwlr_layer_shell_v1 12.
[0.000338, 0.007457,  5468 KB][DEBUG]:     Bound to seat 28.
[WARNING]: Using an outdated compositor, output selection will not work.
[0.000344, 0.007463,  5468 KB][DEBUG]:     Bound to output 30.
[0.000346, 0.007465,  5468 KB][DEBUG]: First roundtrip done.
[0.000348, 0.007467,  5468 KB][DEBUG]: Second roundtrip start.
[0.000377, 0.007478,  5468 KB][DEBUG]:     Got keyboard from seat.
[0.000380, 0.007481,  5468 KB][DEBUG]:     Got pointer from seat.
[0.000383, 0.007484,  5468 KB][DEBUG]:     Output configuration done.
[0.000386, 0.007487,  5468 KB][DEBUG]: Second roundtrip done.
[0.000387, 0.007489,  5468 KB][DEBUG]: Determining output.
[0.000391, 0.007492,  5468 KB][DEBUG]:     First dummy roundtrip start.
[0.000467, 0.007503,  5468 KB][DEBUG]:         Configuring keyboard.
[0.001318, 0.008355,  7948 KB][DEBUG]:         Keyboard configured.
[0.001325, 0.008361,  7948 KB][DEBUG]:         Key repeat every 40 ms after 600 ms.
[0.001330, 0.008366,  7948 KB][DEBUG]:     First dummy roundtrip done.
[0.001332, 0.008368,  7948 KB][DEBUG]:     Initialising dummy surface.
[0.001344, 0.008380,  7948 KB][DEBUG]:         Created shm file with size 0 KiB.
[0.001348, 0.008384,  7948 KB][DEBUG]:     Dummy surface initialised.
[0.001350, 0.008386,  7948 KB][DEBUG]:     Second dummy roundtrip start.
[0.001546, 0.008402,  7948 KB][DEBUG]:     Second dummy roundtrip done.
[0.001559, 0.008415,  7948 KB][DEBUG]: Selected output .
[0.001562, 0.008418,  7948 KB][DEBUG]: Generating command list.
[0.001564, 0.008419,  7948 KB][DEBUG]:     Retrieving PATH.
[0.001566, 0.008422,  7948 KB][DEBUG]:     Retrieving cache location.
[0.001583, 0.008439,  7948 KB][DEBUG]:     Cache up to date, loading.
[0.001677, 0.008532,  7948 KB][DEBUG]:     Moving already known programs to the front.
[0.001696, 0.008552,  7948 KB][DEBUG]: Command list generated.
[0.001706, 0.008561,  7948 KB][DEBUG]: Creating main window surface.
zsh: segmentation fault (core dumped)  tofi-run

Installation:
sudo apt install libfreetype-dev libcairo2-dev libpango1.0-dev libwayland-dev wayland-protocols libxkbcommon-dev scdoc
 CC=clang-15 meson build --prefix ~/.local; ninja -C build install
tofi-run

lldb:
* thread #1, name = 'tofi-run', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x00007ffff77934aa libwayland-client.so.0`wl_proxy_marshal_constructor + 138
libwayland-client.so.0`wl_proxy_marshal_constructor:
->  0x7ffff77934aa <+138>: movq   (%rbp), %rdx
    0x7ffff77934ae <+142>: leaq   0x20(%rsp), %r14
    0x7ffff77934b3 <+147>: leaq   0x8(%rsp), %rcx
    0x7ffff77934b8 <+152>: leaq   0x1b0(%rsp), %rax

System: Ubuntu 20.04
Sway: 1.4

Meson build log
The Meson build system
Version: 1.0.1
Source dir: /home/myrrc/tofi
Build dir: /home/myrrc/tofi/build
Build type: native build
Project name: tofi
Project version: 0.8.1
C compiler for the host machine: clang-15 (clang 15.0.7 "Ubuntu clang version 15.0.7")
C linker for the host machine: clang-15 ld.bfd 2.34
Host machine cpu family: x86_64
Host machine cpu: x86_64
Library rt found: YES
Library m found: YES
Checking for function "fts_read" : YES
Library fts found: NO
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency freetype2 found: YES 23.1.17
Run-time dependency harfbuzz found: YES 2.6.4
Run-time dependency cairo found: YES 1.16.0
Run-time dependency pangocairo found: YES 1.44.7
Run-time dependency wayland-client found: YES 1.18.0
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Build-time dependency wayland-protocols found: YES 1.20
Build-time dependency wayland-scanner found: YES 1.18.0
Run-time dependency xkbcommon found: YES 0.10.0
Run-time dependency glib-2.0 found: YES 2.64.6
Run-time dependency gio-unix-2.0 found: YES 2.64.6
Program /usr/bin/wayland-scanner found: YES (/usr/bin/wayland-scanner)
Program scdoc found: YES (/usr/bin/scdoc)
Program sed found: YES (/usr/bin/sed)
Program sh found: YES (/usr/bin/sh)
Build targets in project: 14

tofi 0.8.1

  User defined options
    prefix: /home/myrrc/.local

Found ninja-1.10.0 at /usr/bin/ninja

According to the log
[WARNING]: Using an outdated compositor, screen anchoring may not work.
[0.000295, 0.007042,  5484 KB][DEBUG]:     Bound to zwlr_layer_shell_v1 12.
[0.000301, 0.007048,  5484 KB][DEBUG]:     Bound to seat 28.

branch at https://github.com/philj56/tofi/blob/e6b9b576b96e87a29047a3951ab2a6838e1df781/src/main.c#L692
is taken, wp_vieporter is not set, but then
https://github.com/philj56/tofi/blob/e6b9b576b96e87a29047a3951ab2a6838e1df781/src/main.c#L1584
is invoked with null wp_viewporter

git bisect rm -fr build; CC=clang-15 meson build -Dbuildtype=debug --prefix ~/.local; ninja -C build install; tofi-run showed that the bad commit is
8287

Hey, thanks for the detailed report! I had assumed viewporter would be available on Ubuntu 20.04, as the protocol was made stable in 2016, but apparently Sway didn't implement it until 2020. Should be a quick fix.

Alright, should be fixed in c6f539e065ca1a6f9a9048ce211132891afbbe6b.


Android Chrome - Error: socket hang up / No http response

I am encountering a different but similar problem to #332 when trying connect to a Android Chrome 85 from http or node (Win 10).

adb forward tcp:9222 localabstract:chrome_devtools_remote : 9222 (ie success)
chrome-remote-interface inspect --host localhost --port 9222 : Cannot connect to remote endpoint: Error: socket hang up
chrome-remote-interface inspect -l --port 9222 : Cannot connect to remote endpoint: Error: socket hang up
chrome-remote-interface inspect -l : Cannot connect to remote endpoint: Error: socket hang up
GET http://localhost:9222/json/protocol : localhost didn’t send any data. ERR_EMPTY_RESPONSE

I am able to connect manually via desktop Chrome chrome://inspect/#devices  :

Ports seem to be open and forwarding:

I feel like I might be potentially misunderstanding something in relation to #332 but was hoping to see if you had any ideas?
Thanks!

Component
Version

Operating system
Android / Windows 10

Node.js
12.18.2

Chrome/Chromium/...
85.0.4183.81

chrome-remote-interface
0.28.2

Is Chrome running in a container? No

If you are unable to get the list of targets with:
curl http://localhost:<PORT>/json/list

And connect to one of those with:
wscat -c ws://localhost:9222/devtools/page/<ID>

Then I'm afraid this is a bug in Chrome and I cannot do anything about it except assisting you in the debug process; you should file a new issue in this case.

PS I see you commented that old issue, you might have more luck in filing a new one.

What happens if you try:
curl http://localhost:9222/json/list

Remember that /json/protocol is not implemented in Chrome for Android.

No worries, thanks for the quick reply - I was thinking more along the lines as to finding out if anyone else currently had it working as described to figure out if it was a local/device-related issue on my end or a global issue affecting everyone etc.
For reference, no I wasn't able to get any response to /json/list either  :(

What I found most frustrating was that Desktop Chrome is clearly connecting "somehow" but I can't figure out a way to monitor "how" it's connecting...

You can use a packet sniffer like Wireshark and see if there's something different in the requests issued by Desktop Chrome.

I just tested:

Connect Android device over USB
adb forward tcp:9222 localabstract:chrome_devtools_remote
chrome-remote-interface list: works fine, I see the tab open
chrome-remote-interface inspect: hangs with the same error as reported (Error: socket hang up)

Some more observations after watching Wireshark:

CRI list call works fine (http://<IP_ADDRESS>:9222/json/list)
CRI protocol call hangs (http://<IP_ADDRESS>:9222/json/protocol)
Chrome skips the a protocol call, instead it goes straight to the version call (http://<IP_ADDRESS>:9222/json/version) and continues

It would be nice if we can skip the protocol call if it's not supported by the remote browser.

That's what the --local option is about.

It would be nice if we can skip the protocol call if it's not supported by the remote browser.

That's what the --local option is about.

I see I didn't do my research :) chrome-remote-interface inspect -l works fine :)

chrome-remote-interface inspect -l --port 9222 : Cannot connect to remote endpoint: Error: socket hang up

I thought you've already tried that?

chrome-remote-interface inspect -l --port 9222 : Cannot connect to remote endpoint: Error: socket hang up

I thought you've already tried that?

@prescience-data is a different guy, was just trying to repro and add my comments 😄

Oh lol OK :)

Now that @Niek has confirmed working, I believe it must be some sort of tcp conflict on my environment - thanks for the help guys!

 Feel free to add details if you need / come up with a solution.


explicitly named loaders

to fix this issues: http://stackoverflow.com/questions/29883534/webpack-node-modules-css-index-js-didnt-return-a-function

Also https://webpack.js.org/guides/migrating/#automatic-loader-module-name-extension-removed

Hi @faisalhakim47
Thatnks for the PR, but I will close this in favor of #457, which includes this change amongst others necessary for webpack 2.2


fix and simplify how io_handler works

Previously io_handler would queue Requests and Responses until the bytes fed to it would happen to get consumed completely with no bytes left over. Sometimes it also parsed the same Requests or Response multiple times.
This pull request is not backwards compatible because it deletes IncompleteResponseError. Instead of this...
try:
    lsp_events = client_object.recv(bytes_from_langserver)
except IncompleteResponseError:
    pass
else:
    for event in lsp_events:
        do_something_with(event)

...you now need to do this:
lsp_events = client_object.recv(bytes_from_langserver)
for event in lsp_events:
    do_something_with(event)

I'd still like to tell the user how much more they need to read, that's a feature regression with this PR. Could we maybe introduce a third event which is Incomplete(missing: int)?

We could return the amount of missing data and an iterator, or some variation of that.
The main ways to handle IO I know of are:

Reading to queue in thread and feeding everything from queue to sansio_lsp_client in another thread
select()ing and then feeding all data read to sansio_lsp_client
some kind of callback that triggers when data arrives

None of these seems like it would benefit from knowing how much more data to read. Do you have an example use case?

Alrighty. Could you bump the version before I merge such that it is uploaded to pypi? This should be a MAJOR version bump.

Bumping version in a pull request might not be a great idea because there seems to be no way to associate git tags with a pull request.

Do you want me to try bumping the version anyway? You'll likely need to run git tag if we do that.

i've invited you to become a collaborator :)

did you mean major as in 1.0.0 or minor as in 0.7.0?

In theory, semver says that since we're still before 1.0.0 we can go to 0.6.1 -> 0.7.0 while breaking stuff
That's fine with me, but I do like to keep compatibility between 0.X.Y and 0.X.(Y + 1), so keep that in mind for future releases


Improved Particle Shader performance by discarding transparent pixels

On my machine the impact was a 50% fps boost on the bunnymark with 50,000 bunnies:
-Before: 30fps
-After: 45fps

unsubscribe me from this mailinglist please
On Wed, Jun 3, 2015 at 4:23 AM bchevalier<EMAIL_ADDRESS>wrote:

On my machine the impact was a 50% fps boost on the bunnymark with 50,000
bunnies:
-Before: 30fps
-After: 45fps
You can view, comment on, or merge this pull request online at:
https://github.com/GoodBoyDigital/pixi.js/pull/1860
Commit Summary

Improved Particle Shader performance by discarding transparent pixels

File Changes

M src/core/particles/webgl/ParticleShader.js
https://github.com/GoodBoyDigital/pixi.js/pull/1860/files#diff-0 (4)

Patch Links:

https://github.com/GoodBoyDigital/pixi.js/pull/1860.patch
https://github.com/GoodBoyDigital/pixi.js/pull/1860.diff

—
Reply to this email directly or view it on GitHub
https://github.com/GoodBoyDigital/pixi.js/pull/1860.

Now that is interesting! Which device / browser is this tested on?
Cheers!

Chrome, last version on a macbook pro

Good call, this is a great improvement. Needs to be a PR against dev though XD

Roger that. Making a PR on dev.


Add _postMeasure method to GUI Control

Adding _postMeasure method to GUI.Control to allow derived classes take some post-measurement actions. This is necessary if we want to change a property such top, after the _measure() action but before the _computeAlignment() call.
Same should be obtained by overriding _measure() or _computeAlignment() into the derived class
 public _measure(): void {
      super._measure();
      this.top = this._i * this._currentMeasure.height ;
 }

but this will not prevent regression later (as it is defined as prefixed _ private method) while the intend of _postMeasure is clear and should be maintened to serve child purposes
so the above code may be replaced with
protected _postMeasure(parentMeasure: Measure, context: ICanvasRenderingContext): void {
     this.top = this._i * this._currentMeasure.height ;
}

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14412/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14412/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14412/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14412/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14412/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14412/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14412/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14412/merge#BCU1XR#0

LGTM but let's just check with @RaananW 🙂


Arena Copies not working

Expected behavior
When clicking  on the amount of copies I want it should create the amount of arenas desired.
Observed/Actual behavior
When copying the arenas there is an error in the console, and then the config of that entire arena deletes itself, sometimes even deleting the whole contents of the "arena.yml" file.
How to Recreate (if known)
Just make a copy of an arena.
Stack trace
java.lang.NullPointerException         at me.elb1to.practice.util.cuboid.Cuboid.<init>(Cuboid.java:47) ~[?:?]         at me.elb1to.practice.managers.chunk.restoration.impl.FrostChunkRestoration.copy(FrostChunkRestoration.java:27) ~[?:?]         at me.elb1to.practice.managers.ArenaManager.lambda$null$0(ArenaManager.java:75) ~[?:?]         at java.base/java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]         at me.elb1to.practice.managers.ArenaManager.lambda$loadArenas$1(ArenaManager.java:63) ~[?:?]         at java.base/java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]         at me.elb1to.practice.managers.ArenaManager.loadArenas(ArenaManager.java:44) ~[?:?]         at me.elb1to.practice.managers.ArenaManager.reloadArenas(ArenaManager.java:91) ~[?:?]         at me.elb1to.practice.runnable.ArenaCommandRunnable$1.onComplete(ArenaCommandRunnable.java:68) ~[?:?]         at me.elb1to.practice.runnable.DuplicateArenaRunnable$1.finish(DuplicateArenaRunnable.java:75) ~[?:?]         at me.elb1to.practice.runnable.BlockPlaceRunnable.run(BlockPlaceRunnable.java:41) ~[?:?]         at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java:64) ~[FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:411) [FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:876) [FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:382) [FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:806) [FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:708) [FoxSpigot.jar:1.8.8-R0.1-SNAPSHOT]         at java.base/java.lang.Thread.run(Thread.java:829) [?:?]
Plugin list

Frost version
Version:  v12.3
Confirmations

[X] I have searched for and ensured there isn't already an open issue regarding this.

Other
No response

Are you sure that followed every step to create an arena before making copies of it?

Yep, I set the icon, the a location, the b location, the min corner, the max corner, the buildmax, the deadzone. I didn't set the portalprot cause it's not necessary.
The message says that All the copies were pasted successfully but they weren't.

Issue solved.
The cause was a misconfiguration problem.


New sample: Delete all Office 365 groups

Docs |
-- | --
Author | Laura Kokkarinen
Original Post | https://laurakokkarinen.com/does-it-spark-joy-powershell-scripts-for-keeping-your-development-environment-tidy-and-spotless/#delete-all-office-365-groups
Description | There are so many different ways to create Office 365 groups. Teams, Planner, SharePoint team sites, etc. — you can accumulate a lot of them very fast. Use this script below to delete the ones you no longer need.
Keywords | SharePoint Online Office 365 Groups

Hi @garrytrinder, @waldekmastykarz I would like to take this up.

Thank you @aakashbhardwaj619 👏🏻
It’s all yours 👍🏻


Removing Attachment Button

Is there a convenient way to remove the button that allows you to attach media, next to the input text view?
Thanks!

Solution:
self.inputToolbar.contentView.leftBarButtonItem = nil;


please merge this color for c/c++ marco

dimmed-monokai-color-theme.json
please add this color  for c/c++ in order to identity macro and processor in c/c++ ;
3q
`{
"name": "Function name",
"scope": "entity.name.function",
"settings": {
"fontStyle": "",
"foreground": "#CE6700"
}
},
	{
        "name": "Macro Preprocessor of c/c++",
        "scope": "entity.name.function.preprocessor, meta.preprocessor.macro",
        "settings": {
            "fontStyle": "",
            "foreground": "#c70095"
        }
    },

`
otherwise macros and processors will display as same as functions. thx a lot

That foreground color isn't used in this theme currently. To match how the dark and light themes work, it should use the same color as Storage (#9872A2).
@aeschli what do you want to do here? We only do meta.preprocessor in the dark and light themes.

@heartacker You can do that by putting this in your settings:
"editor.tokenColorCustomizations": {
	"[Monokai Dimmed]": {
		"textMateRules": [
			{
				"scope": [
					"entity.name.function.preprocessor",
					"meta.preprocessor.macro"
				],
				"settings": {
					"foreground": "#c70095",
					"fontStyle": ""
				}
			}
		]
	}
},

How did you come to this chaneg request? Is it personal preference or is it how  'dimmed monokai' is supposed to do it?
Given that also the regular Monokai also doesn't distinguish between preprocessor and regular functions, I think we should rather not do the change.
If you feel that other users think the same you can also come up with your own variant of the dimmed Monokai theme and make it available in the Marketplace.


Update path to the sqlpackage on agents

Sqlpackage was recently updated on the hosted agents and the path has changed. Related PR in VE repo — https://github.com/actions/virtual-environments/pull/4966

@dzsquared could you take a look, please?

#label:"aq-pr-triaged"

thanks @miketimofeev!
#sign-off


Point System

Users are awarded a point every time they do something

Sending messages
Getting reactions? Like Reddit karma

A Plugin that a user can play with the gamble their points

ie: a coinflip to double or lose betted amount

Leaderboard to see who has the most points

Similar to the C4 and TTT leaderboards

Would be nice to have some kind of PvP for point wagers

This sounds like something people would farm just to get to the top of the leaderboard.

We can just not allow points through messages

Could also award points for winning in C4 or TTT

You could have points decay over time


Chris: Fix health checks on services:

[x] synapse
[x] mastodon
[x] bitcoind
[x] ride-the-lightning
[x] thunderhub
[x] c-lightning

Added healthcks for synapse, mastodon, and bitcoind. Health checks for RTL, TH, and c-lightning not tested; waiting for dependencies to become more stable before testing


TextLayoutResult.getWordBoundary() doesn't break on expected characters

When we use TextLayoutResult.getWordBoundary(offset: Int) to get the boundaries of work from a given offset, it seems to be skipping boundaries we expect it to break at. For example, take the following string:
private fun mayScrollToCoordinate(x: Int, y:asdf Int, padding: Int = 0) { }

In Chrome and Intellij, the word boundaries that the cursor will stop for (before/after), include ,, (, ), :, =, {, and }. However, all these characters seem to be ignored (not considered as boundaries) by TextLayoutResult.getWordBoundary(offset: Int).
Can we get the TextLayoutResult.getWordBoundary(offset: Int) to adhere to the same behaviour as Intellij?

Does it work the same way on Android?

@akurasov I have no idea. We don't work on any Android platforms.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Handle Spiget api errors, use best-practice, disable incompatible code

Changes
install_requirements.py

Use python3 -m pip instead of pip when installing on posix operating systems, as documented here.
If an exception occurs, display the exception detail to the user alongside the troubleshooting suggestion.

src/plugin/plugin_updatechecker.py

Handle Spiget api request errors, instead of crashing due to erroneously handling the unexpected data structure: {'error': '', 'msg': ''}. Further detail can be found in the commit description.

src/utils/console_output.py

Don't attempt to change the console title on non-Windows systems to prevent an unexpected command error message from being displayed.

Hey @smcclennon,
thank you so much for your PR! 😃
Your changes will be included in Version 1.7.2!
Have a good day! 👋


W-8530908 - Mapping new fields to Payment for ACH and other tweaks

Created three fields on the Payment Object to receive status, declined reason, and ACH code.
Created three new field mappings to populated those fields from the DataImport object
Modified two field labels on the DataImport object to better reflect their content.
Cleaned up the order of fields and some white space in the Data import object file to match the SFDC version.

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

@sam-knox If that field has already been included in release, the API cannot be changed.


Tweak login styles

This makes a few adjustments to the login and root routes.

I've set a min-height on the html and body so they always fill 100% of the available hight
I've centred the login components vertically in the screen, so it works at all sizes
I've darkened the gray we use, and repeated it for the secondary text

Here's what it looks like, but you really need to try in a window you can resize:

@Ririio Great feedback.  I've added en-CA and made it responsive:
Mobile

Desktop

@Ririio I can't merge this until you accept the invite to the new team and get write access.


Handling GCP network flakes

The Toolsmiths have seen an issue with about 2% (2 out of 100) of our deploys related to network flakes on GCP. The terraform commands run on a GCP Concourse worker, so we're in the same region.
We issue a command to create an object, then we get 'read: connection reset by peer'. Terraform fails, and then we do a terraform refresh before we try again. The subsequent terraform does not work, as there's a collision in names with the object that already exists. I can provide the full logs for the most recent occurrence.
Currently, we've found that doing a terraform destroy, and then a terraform apply will correctly delete & recreate the objects. We're planning to automate this in our app, with retries in the concourse pipeline, but it would be great if this functionality could get pushed into this repo so that everyone could get higher success rates on terraforming, even with IaaS instability.

I guess I wonder where you think we could apply a fix? I am not aware of a feature to add retry logic in terraform, but certainly the provider plugin opens a connection to the GCP api, perhaps it could do better to keep that active or come with embedded awareness of the published limits of connection re-use from GCP's api docs.

Is it possible to tell any trends about which object fails? Perhaps that could scope our fix to attempting to normalize how we generate those objects or to the
what version of terraform / the gcp provider do you have? I think it can be found in terraforming-gcp/.terraform/providers/gcp/provider-lock.json or something similar.

Going to close this out due to inactivity.


Requirement to mount Solr directory is not mentioned in distributed setup

Description:
WSO2 APIM needs to have a requirement to mount Solr directory in distributed setup, specially when customer has high number of APIs. This is not mentioned in distributed setup guide [1].
https://apim.docs.wso2.com/en/latest/install-and-setup/setup/distributed-deployment/deploying-wso2-api-m-in-a-distributed-setup/
Affected Product Version:
4.1.0, 4.0.0

Even the migration guide doesn't specifically mention this.
https://apim.docs.wso2.com/en/latest/install-and-setup/upgrading-wso2-api-manager/400-to-410/upgrading-from-400-to-410/#step-4-re-index-the-api-manager-artifacts

Gentle reminder.


Amazon Complaining about Missing Date Header When Creating/Fetching S3 Repository

I'm currently using v2.5.1 of this plugin successfully on one of my servers (running inside the official ES Docker image) to create and snapshot to an S3 repository. I recently started a new instance of ES in a new Docker container on the same server with the same exact configuration with the intention of restoring a snapshot, but noticed I could not create repositories or fetch listings of snapshots that exist in those repositories from the new instance. On the original instance, everything still works as expected, but now I'm scared to shut down that Docker container since it is working correctly at the moment. As a side note, I did this exact same process just a couple days ago with success, so I'm not sure what has changed since Wednesday.
This is the error I'm getting:
{
   "error": "RemoteTransportException[[server][inet[/<IP_ADDRESS>:9300]][cluster:admin/repository/put]]; nested: RepositoryVerificationException[[my_s3_repository] path [my_s3_path] is not accessible on master node]; nested: IOException[Unable to upload object my_s3_path/tests-ooBzS8deRtWxFeS6OuG9SQ-master]; nested: AmazonS3Exception[AWS authentication requires a valid Date or x-amz-date header (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: C810733A376C4D79)]; ",
   "status": 500
}

Any idea what would be causing this? Thanks in advance!

I'm also experiencing this issue using Docker+Elasticsearch 1.4 container and 2.4.1 of the elasticsearch-cloud-aws plugin.
curl -XPUT 'http://<IP_ADDRESS>:9200/_snapshot/backups' -d '{
    "type":"s3",
    "settings": {
        "bucket":"mybackups",
        "region":"eu-west-1",
        "protocol":"https"
    }
}'

{
  "status": 500,
  "error": "RepositoryVerificationException[[backups] path  is not accessible on master node]; nested: IOException[Unable to upload object tests-LL5FIlrPS86_InDfnNEzvw-master]; nested: AmazonS3Exception[AWS authentication requires a valid Date or x-amz-date header (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: 622050F6EEA5C8C2)]; "
}

Seems to be related to some change in the Docker base images: https://github.com/aws/aws-sdk-java/issues/484

It seems the required change is to use Amazon SDK v1.10.11 for any version of Java 1.8u60 and above (in the case of the base Docker images, 1.8u66 is the new base version used for 1.8).
I'm not exactly sure how to go about testing this or if there is something else that needs to be done to get this change into all of the versions, but I tried modifying the pom.xml file in v1.5 branch and run a "mvn clean install", but get the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project elasticsearch-cloud-aws: Compilation failure
[ERROR] /Users/marcmelvin/Development/SmartProcure/elasticsearch-cloud-aws/src/test/java/org/elasticsearch/cloud/aws/AmazonS3Wrapper.java:[41,7] error: AmazonS3Wrapper is not abstract and does not override abstract method getBucketReplicationConfiguration(GetBucketReplicationConfigurationRequest) in AmazonS3

@lusid Thats because that class no longer implements all the methods present in the AmazonS3.
I've actually implemented them, packaged a new version with the latest Amazon SDK dependency but it still gives the same error.
Upon inspecting the generated zip, I saw that it still includes joda-time 1.7.0. This comes from elasticsearch-parent project [pom].
Forcing to use the latest joda-time will issue an runtime error on ES:
1) Error injecting constructor, java.lang.NoClassDefFoundError: org/joda/time/ReadableInstant
  at org.elasticsearch.repositories.s3.S3Repository.<init>(Unknown Source)
  while locating org.elasticsearch.repositories.s3.S3Repository
  while locating org.elasticsearch.repositories.Repository

1 error
	at org.elasticsearch.common.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:344)
	at org.elasticsearch.common.inject.InjectorBuilder.injectDynamically(InjectorBuilder.java:178)
	at org.elasticsearch.common.inject.InjectorBuilder.build(InjectorBuilder.java:110)
	at org.elasticsearch.common.inject.InjectorImpl.createChildInjector(InjectorImpl.java:131)
	at org.elasticsearch.common.inject.ModulesBuilder.createChildInjector(ModulesBuilder.java:69)
	at org.elasticsearch.repositories.RepositoriesService.createRepositoryHolder(RepositoriesService.java:407)
	at org.elasticsearch.repositories.RepositoriesService.clusterChanged(RepositoriesService.java:302)
	at org.elasticsearch.cluster.service.InternalClusterService$UpdateTask.run(InternalClusterService.java:480)
	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:196)
	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:162)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NoClassDefFoundError: org/joda/time/ReadableInstant
	at com.amazonaws.services.s3.internal.ServiceUtils.<clinit>(ServiceUtils.java:67)
	at com.amazonaws.services.s3.internal.S3Signer.sign(S3Signer.java:168)
(...)

I think Elasticsearch is not loading the joda-time present in the plugin, so I think Elasticsearch's joda-time needs to be updated to use the latest version.

dadoonet linked here on my pull request where they updated the aws-sdk in ES 5 days ago to 1.10.10: https://github.com/elastic/elasticsearch/pull/12859
I guess we are just waiting then at this point.

Seeing this too.
I'd say this is pretty urgent given people wanting to recover into a new cluster can't because they can't create the repository to recover from.

Requests to recover shards from S3 are also failing:
[2015-08-21 12:20:04,337][WARN ][cluster.action.shard     ] [Carter Ghazikhanian] [anon-67827][2] received shard failed for [anon-67827][2], node[BjiX6YqASgqqLeOOhRCMwA], [P], restoring[s3-hourly:2015-08-21-09-32-51-0000], s[INITIALIZING], unassigned_info[[reason=ALLOCATION_FAILED], at[2015-08-21T12:20:03.832Z], details[shard failure [failed recovery][IndexShardGatewayRecoveryException[[anon-67827][2] failed recovery]; nested: IndexShardRestoreFailedException[[anon-67827][2] restore failed]; nested: IndexShardRestoreFailedException[[anon-67827][2] failed to restore snapshot [2015-08-21-09-32-51-0000]]; nested: AmazonS3Exception[AWS authentication requires a valid Date or x-amz-date header (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: E26]0A722C546D490)]; ]], indexUUID [I7ndH_d9RWiymLlZou3cTQ], reason [master [Carter Ghazikhanian][l6dioplgRjaOrL3tr8-6aw][elasticsearch-1-12][inet[/<IP_ADDRESS>:9300]] marked shard as initializing, but shard is marked as failed, resend shard failure]

Our workaround for this was to downgrade to a JVM version before 1.8u60. In our case we went back to 1.7.0_80.

My workaround was similar. Downgrading to 1.8u45 solves it as well.

Any chance this fix will be applied to java version "1.8.0_73" ?

@rodriguezsergio 2.4.3 won't be released so you have two options IMO:

Upgrade elasticsearch to 1.7 and aws plugin to 2.7.1 (best option IMO)
build yourself branch es-1.4 and install the plugin from target dir

Also, you could think of upgrading to 2.x which is even better but requires more work probably on your end.

@dadoonet Yeah, we're trying to play catch-up with the Elastic guys. Will upgrade to 1.7. Thanks.


ExceptionDialog closes instantly when it is open after hitting "Enter" key on TextInput that throws an error

Noticed in a client app that when this sequence happens:
1 Hit "Enter" on a formless TextInput to commit a value
2 A reaction to the value change makes an ajax call that returns with an error
3 And opens an ExceptionDialog via .catchDefault()
The ExceptionDialog opens with the "Close" button autofocused, and the "Enter" key event is bubbling up/propagating
and activates the Close button so that the dialog closes instantly.
To the user/developer, this may look like the dialog:

never opens
or flashes open and closes in an instant

I looked into solutions involving ev.preventDefault(), ev.stopPropagation(), ev.nativeEvent.preventDefault(), ev.nativeEvent.stopPropagation(), ev.nativeEvent.stopImmediatePropagation() on onKeyDown and onKeyPress on the InputText component - in hoist-react  and in the app.    Nothing stopped the event bubbling in time to let the dialog render AFTER the bubbling had been stopped.
I ended up fixing this by delaying the ajax call with wait(500).  Could optimize that fix further by delaying the promise resolution only if an error is returned.
But, of course this is something that would be better addressed with event management on textInput (doesn't seem possible)  or maybe delaying the autofocus on the dialog close button.

I think another possible fix that I prefer over the others is to add a check in the ExceptionDialog's close btn onClick handler to see if the ev.target value is the close button.  If it is not, ignore the event and do not close the dialog.   That seems like a clean solution if it works.

The ev.target idea did not work.  By the time the event triggers the close button click, the target is always the close button, whether the event started at the textInput, or at the close button.

Potential good news!  It sounds to me like this might be fixed by react-17
https://reactjs.org/blog/2020/08/10/react-v17-rc.html#changes-to-event-delegation

Before I forget, want to say that I saw this error in a client app with a hotkey that brings up a dialog, being input right in to that dialog's default text.  A slight delay fixed the issue, but it remains very surprising and ugly for app developers to have to work around in this way

@lbwexler I tested this toolbox branch: https://github.com/xh/toolbox/compare/exceptionDialogFocusDelay against Hoist-React with React v17 and I do not see that this issue is resolved.  (the branch name is a bit of a misnomer now, the branch doesn't do any delaying, it just sets up the bug)
React's moving of the native listener from document node to react root node doesn't seem like it changes the setup for this issue's situation: 2 enter/click listeners within the same listening parent node.

yea, thanks for testing Colin.
Sorry for the false hopes there.
On Fri, Nov 27, 2020 at 5:09 PM Colin Rudd<EMAIL_ADDRESS>wrote:

@lbwexler https://github.com/lbwexler I tested this toolbox branch:
https://github.com/xh/toolbox/compare/exceptionDialogFocusDelay against
Hoist-React with React v17 and I do not see that this issue is resolved.
(the branch name is a bit of a misnomer now, the branch doesn't do any
delaying, it just sets up the bug)
React's moving of the native listener from document node to react root
node doesn't seem like it changes the setup for this issue's situation: 2
enter/click listeners within the same listening parent node.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/issues/2096#issuecomment-735000025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2L42UVGWVNMPIG2DCLSSAPQLANCNFSM4R2UVBWQ
.


[RKE1] Update process for rancher/kubernetes tags

Simplify the current process so it can then be automated to run whenever a new tag is pushed upstream (https://github.com/kubernetes/kubernetes/releases/tag)
This is possible if we modify how the branches are created, new process will be:

create a new branch every time for every k8s version (directly from the tag of the format release-vX.Y.Z)
apply rancher specific changes via the cherry-pick patch (could be PR or cherry-pick, but I think directly applying cherry-pick is OK cuz there's no need to review if upstream changes are all present)
push tag (tag comes directly from the release branch name)

Note:
There's one thing we need to verify - the vendor commit update. Is go build and go mod vendor sufficient or would we need to manage this manually? cc @chiukapoor @mitulshah-suse

The automation run was completed successfully.
Automation GHA run: https://github.com/rancher/kubernetes/actions/runs/11046387668
Release branches:

v1.28.14: https://github.com/rancher/kubernetes/tree/release-v1.28.14
v1.29.9: https://github.com/rancher/kubernetes/tree/release-v1.29.9
v1.30.5: https://github.com/rancher/kubernetes/tree/release-v1.30.5
v1.31.0: https://github.com/rancher/kubernetes/tree/release-v1.31.0
v1.31.1: https://github.com/rancher/kubernetes/tree/release-v1.31.1

Tags:

v1.28.14: https://github.com/rancher/kubernetes/releases/tag/v1.28.14
v1.29.9: https://github.com/rancher/kubernetes/releases/tag/v1.29.9
v1.30.5: https://github.com/rancher/kubernetes/releases/tag/v1.30.5
v1.31.0: https://github.com/rancher/kubernetes/releases/tag/v1.31.0
v1.31.1: https://github.com/rancher/kubernetes/releases/tag/v1.31.1

September patch run: https://github.com/rancher/kubernetes/actions/runs/11046387668


Change structure so there is a components folder inside src

it is better if there is a folder for components inside src, cause if your app grows it will be huge. Also remove components folder inside each component folder.

We are discussing the directory structure in the Angular 2 Style Guide repo.
When we reach a consensus there we'll implement the directory structure we've agreed on here.

Please don't change structure of this seed.. It's just perfect.

sorry, @londonoaa , I wasn't aware of already existing changes in structure. Agree, currently it looks awful. And proposals in linked thread are even worse.


Click event on React ColumnChart

I have successfully created a column chart in React with 4 columns.  I need to be able to click each column and execute a specific function for each one.  Is this possible?

Hey @tkserver, please check out the Contributing Guide.


Separate Read Progress for Each User

Describe the solution you'd like
Multi-user reader progress. The way that it works now (at least, in my default configuration), if another non-admin user is reading a manga I haven't read yet, their read progress appears on my admin user account's "Continue Reading" section. To prevent either of us from losing our place, each user (admin or not) should have their own reading histories individually tracked.
Describe a small use-case for this feature request
More than one user reading the same series at different paces.

We do store the progress of each user separately. If you open the info.json file in the folder of the manga and you will see that the progress field has one entry for each user.

I do see what you're saying, but the progress I'm seeing in info.json doesn't represent reality. The manga was a new, recent download I hadn't touched, but the other user's progress was appearing (and does appear in the info.json) on my user.
I'm currently running the latest version of the Mango docker image.


Adds an API endpoint to scrape a URL and return metadata.

WIP, please don't merge.
Would love some feedback from smart Python folks on a few items I'll specifically comment on. I wouldn't turn down any other feedback, as well.
r? @robhudson @ngokevin @diox

IMHO this should be a task fired asynchronously, not a view. Something working like FileUpload does: the API would return an id for a model instance that the task would then fill in, and clients can poll the API with that id till it returns something

@diox You're not wrong, that's the right way to approach it. Submission tools are supposed to be an MVP, so I went with the simpler, "good enough for a few users" approach.
I could be convinced otherwise if you have strong feelings about it.

Would appreciate another look, with a major refactor. @mstriemer?

Ready for a full review, pending Travis passing.

r?  @mstriemer @diox @ngokevin

r+ from me, let's try it out.

where's this at

bump

@ngokevin I'm working with Jason right now to get the DB schema on dev worked out for bug 1175691, then I'm going to try to get #3140 re-merged. If you want to merge this and run with it, feel free.

That's not related so I'll merge to try it out since there's little else to do on the frontend.


Error: unable to find usable node.js executable

Env:

node: 6.12.2
npm: 3.10.10

My kibana and plugin directories are siblings.
$ ls: kibana/  stabHavana/
Kibana and ES run correctly. I only have this problem when I try to run Kibana with my plugin included.
Kibana is forked for the repository so I'm currently working with the latest relase (7.0.0-alpha1). My plugin was generated running sao kibana plugin without any params and I generated everything except for hack and transation files.
Hope this is useful!

The way plugin development is done changed recently in master, and the template hasn't yet been updated to accommodate.
If you're on a the latest Kibana master, you'll need to put your plugin in a kibana-extra path, which lives next to kibana. You'll then need to upgrade the version of @elastic/kibana-plugin-helpers you are using. You'll probably also need to change the eslint setup, and link to the version in kibana instead, and use the kbn tool to install everything. You plugin's package.json will include:
"@elastic/eslint-config-kibana": "link:../../kibana/packages/eslint-config-kibana",
"@elastic/eslint-import-resolver-kibana": "2.0.0",
"@elastic/plugin-helpers": "^9.0.2",

Check out the contributing docs for information on setting things up.
I'll leave this open though, as a reminder to upgrade the template.

Closing this issue since the generator was forked into the Kibana repo, and works with the new dev setup. See https://github.com/elastic/kibana/tree/master/packages/kbn-plugin-generator.


add some features to table

select columns to display, multidelete, etc.   Please add in comment some proposals

multidelete seems like an overkill so let's not do it, at least for now
selecting columns based on buttons? hide/unhide column

now it's dropdown with checkboxes to display columns

it's ok, however are these settings saved somewhere?

no

it will be save in cookie https://github.com/wenzhixin/bootstrap-table-examples/blob/master/extensions/cookie.html

close issue if it's done


Make Envoy's per connection buffer limit configurable

This is a followup from #13719. As @robertpanzer shown there, Envoy allows to set per_connection_buffer_limit_bytes per listener as given in below example:
static_resources:
  listeners:
  - name: main
    per_connection_buffer_limit_bytes: 2097152
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 8888
    filter_chains:
    - filters:

This limit appears to be 1MB and it cause Envoy to generate an HTTP 500 when an EnvoyFilter is added to the chain and the Filter has to make a buffered read due to its business requirements. When the HTTP response is bigger than 1MB, Envoy emits HTTP 500.
It would be great if this limit is made configurable over Istio.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

/assign

We have a use case where we'd like to control the HTTP2 window size as the default 256 MB are way too big. Envoy offers several knobs to control the buffers: https://www.envoyproxy.io/docs/envoy/latest/faq/configure_flow_control. It'd be nice to expose them in istio.

The current resolution is to use envoyfilter, reopen if you feel this is a must feature

@hzxuzhonghu how can I achieve this with envoyfilter, can you please share an example.

@ethicalaakash
You can find examples here: https://github.com/istio/istio/wiki/EnvoyFilter-Samples
The full reference documentation is here: https://istio.io/docs/reference/config/networking/envoy-filter/

Thanks @vergnes
following envoyfilter can be used to update the per_connection_buffer_limit_bytes in Istio.
The listeners generated by Pilot are typically named as IP_PORT, for me port was 8080, change this accordingly.
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: connection
spec:
  configPatches:
  - applyTo: LISTENER
    ListenerMatch: <IP_ADDRESS>_8080
    patch:
      operation: MERGE
      value:
        per_connection_buffer_limit_bytes: 100000000 #100MB

We still need this.


[WIP] Add Mac OS X platform and compilers

https://commons.wikimedia.org/wiki/File:Tiger-like-x.svg
This is the logo's page. It's in the public domain.

I should probably add it to the credits page though, yeah.

Right, sorry, I didn't realize you asked for a screenshot of the decomp.me site. I thought you meant to link to the source of the svg. I'm dumb :P

np :). and hmmm I wonder why we're getting 3, 4, 2 platforms per row. without dummy I wonder what it'll look like..

Without dummy it looks like this.

I'd also add a unit test that confirms a compilation works (like you did for the os 9 PR) if you don't mind


Python 3 support?

Hey there,
Does OligoMiner work with python3 too? If so could the main README also mention this perhaps?
Background: with new python3 releases coming about, I think the number of python2 uses may
slowly shrink, and I am wondering about using software that may be "stuck" on python2. It would
be quite helpful if we could know beforehand about the support possibilities for different python
versions, to lessen frustration to those that may only use python 3.x these days (as opposed to
those who use only python 2.x, or those who actually use both versions fine).

Hello, OligoMiner does not work with Python 3 and as of now there are no imminent plans to change this. We recommend making a dedicated conda env with Python 2.7.x as described in the README. You can also access a web-based, dockerized version of OligoMiner at http://oligominerapp.org/home


Support for Update and delete operation from sqlite-hustle and simple TATP bench driver

Summary

Support for update operation and delete operation- simple implementation
Used a global index table for mapping row id to block id and block offset and also a local index table per block to identify the corresponding row id for the record in the block so that the index table can be updated when the block offset of the record gets changed on deletion.

Right now, the naive implementation of the update operation is combining delete and insert operation.
For the delete operation, a new block is created by omitting the records that are needed to be deleted in the old block.

Simple fixes and improved the resolver.
First version of simple TATP driver to run simple TATP format queries.
Simple unit tests for the update and delete query support feature.

In the next pull request, will be handling the optimization in the arrow table update like in-place updates and batch update/insert/delete. Also, will integrate txbench for the hustle to run the multithreaded TATP benchmark (actual).

Nice holiday gift for the group. Thanks @srsuryadev!


Allow the token swap contract to execute a message on completion

In the case of native tokens being swapped, the cw-token-swap contract should be able to execute a message on completion with those funds sent in the funds field. in the case of cw20 tokens, the same concept should apply but via a cw20 ExecuteMsg::Send.
this would allow the token swap contract to compose with the vesting contract and allow tokens to be swapped into vested ones.

Wow, this is sick. Love it.


frameWidth & frameHeight not reflecting

Description
I have set frameWidth and frameHeight to 360x480 yet the recording area is not reflecting the set values. Instead I get a black bar on top and the bottom of the video.
Steps to reproduce
Here are the options that I have
           options: {
                    controls: true,
                    autoplay: false,
                    fluid: false,
                    loop: false,
                    width: 360,
                    height: 480,
                    controlBar: {
                        // hide fullscreen and volume controls
                        fullscreenToggle: false,
                        volumePanel: false,
                    },
                    plugins: {
                        // configure videojs-record plugin
                        record: {
                            audio: true,
                            video: true,
                            debug: true,
                            fluid: true,
                            maxLength: 60,
                            frameWidth: 360,
                            frameHeight: 480
                        }
                    }
            }

Results
Expected
Was expecting the entire width and heigh specified on frameWidth & frameHeight to reflect as recording dimensions.
Actual
Attaching image here
https://i.imgur.com/DH4uMQ1.jpg
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
Using video.js 7.6.6 with videojs-record 3.8.0 and recordrtc 5.5.8
browsers
Latest Chrome
OSes
Ubuntu 18.04

@nzee make sure your camera supports the resolution you're asking for. I tested the config below with a camera that supports 640x480:
var options = {
    controls: true,
    width: 640,
    height: 480,
    fluid: false,
    controlBar: {
        fullscreenToggle: false,
        volumePanel: false
    },
    plugins: {
        record: {
            audio: true,
            video: {
                // video constraints: set resolution of camera
                minWidth: 640,
                minHeight: 480
            },
            // dimensions of captured video frames
            frameWidth: 640,
            frameHeight: 480,
            maxLength: 10,
            debug: true
        }
    }
};

And result has no bars:


Incompatible with XPILOT

Describe the bug
A clear and concise description of what the bug is.
While on ground the xpilot does not disconnect, no matter how many minutes i stay , because the autoortho is not downloading new images , as soon as i get on the air , 5 minutes flying and autoortho is starting to load new images and downloading it creates a conflic and it disconnects. Tried xpilot without autortho and no problem at all , Thanks
To Reproduce
Steps to reproduce the behavior:

Go to '...' whataver airport you want , and fly
Click on '....' xpilot open
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
No discconection or interfere with it
Screenshots
If applicable, add screenshots to help explain your problem.
(please complete the following information):

OS: [e.g. Windows 11]
XPlane Version: [e.g. XP12 beta 4]
AutoOrtho Version [e.g. 0.4.3]
Filesystem type (NTFS, exFAT, etc)

Additional context
Add any other context about the problem here.
Thanks

more answers for my topic in another page abuout autoortho:  I also had disconnects with AutoOrtho, but not because of the bandwidth but because X-Plane might shortly be stalled for a while when it is waiting for too many textures to be generated by AutoOrtho.
Anyways, if it's really only the internet it is on your router or ISP. AutoOrtho just does http:// requests (but very very many of them). A weak router or wary ISP might get in the way there (but actually I doubt it).
Both problems can be worked around by filling the AutoOrtho cache before going online to VATSIM.

I'm not terribly familiar with XPilot.  Does this connect to Xplane over the UDP port by chance?

I'm not terribly familiar with XPilot. Does this connect to Xplane over the UDP port by chance?

after days of testing , the only map that disconects xpilot is bing maps , firefly works perfect , any ideas ? Thanks

Map type shouldn't matter.  Could be maybe you have firefly images cached
already?
On Fri, Aug 25, 2023, 9:56 PM mikecbr @.***> wrote:

I'm not terribly familiar with XPilot. Does this connect to Xplane over
the UDP port by chance?
after days of testing , the only map that disconects xpilot is bing maps ,
firefly works perfect , any ideas ? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/kubilus1/autoortho/issues/318#issuecomment-1694112802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVEDLETF4FJUZ4JZ6MGBRDXXFJVZANCNFSM6AAAAAA3UBHUOU
.
You are receiving this because you commented.Message ID:
@.***>

Map type shouldn't matter. Could be maybe you have firefly images cached already?
…
On Fri, Aug 25, 2023, 9:56 PM mikecbr @.> wrote: I'm not terribly familiar with XPilot. Does this connect to Xplane over the UDP port by chance? after days of testing , the only map that disconects xpilot is bing maps , firefly works perfect , any ideas ? Thanks — Reply to this email directly, view it on GitHub <#318 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVEDLETF4FJUZ4JZ6MGBRDXXFJVZANCNFSM6AAAAAA3UBHUOU . You are receiving this because you commented.Message ID: @.>

You can try by yourself with temp folder completly empty , so the textures has to download again , with firefly xpilot does not disconnect , have done a 6 hour flight , with bing maps , same test , after take off , as the map keeps downloading xpilot disconect.... have done 14 test..... there is something making some kind of conflict


Add GPLv3 in the choice of licences

When choosing a licence, we are provided with the following choices:
Select open_source_license:
1 - MIT
2 - BSD
3 - Apache Software License 2.0
4 - Not open source

It would be nice to be able to select a GPLv3 licence too.

We accept pull requests. Why not submit one and get contributor status?


useAsyncList errors out on reload() when paired with ListView

Provide a general summary of the issue here
When using useAsyncList with ListView, we get a virtualizer error when you try to do list.reload().
🤔 Expected Behavior?
List should reload without errors
😯 Current Behavior
List throws Cannot read properties of undefined (reading 'rect'). I've tracked it down to Virtualizer.ts in RSP
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
Recreated in a sandbox

Load sandbox
Press the 'Press me' button
App should error out

Version
3.29.0 (& tried on 3.30.0 as well)
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
DXUE Quarry
🕷 Tracking Issue
No response

Reproduced, note that this is due to the data being instantly returned via useAsyncList's load function. If a delay is added  to the useAsyncList's load function then it works fine. We can investigate how to perhaps debounce/delay updates to the items provided to our virtualizer components.
@tiffany-sy-lin Is Quarry running into an issue where the load call is returning too quickly?

@LFDanLu Maybe? The sandbox I provided, is a parred down version of how we're using useAsyncList in inventory. The original reporter said they experienced it with large datasets though (unsure how large is 'large'), but the story example they provided only had 10 items.

This bug seems to be fixed now (tested on version 3.36.3):
sandbox

Thanks for trying that out. I verified it appears to be fixed.


Changed to read db identifier prefix from system functions ib_env var

Can you take a look at the failed tests?


@celo/utils needs to include country data file

There’s a problem with the latest published @celo/utils package since the use of country-data was changed to reduce the size.
The countries.ts file imports the country.json file from ../data but the data folder isn’t included in what gets published to npm (see files section of package.json)
So when something tries to bundle utils package the bundler (e.g. webpack) will throw an error.
Also the dependencies are mixed up. The @types should be in the devDependencies section and country-data should be removed since we only use its types now.

@jmrossy A temporary workaround if you are using yarn:
Add this to your package.json
  "resolutions": {
    "@celo/utils": "1.2.1"
  }

@jmrossy I don't recall, was this resolved?

@aslawson I don't know if it was resolved, I haven't tested new contract kit versions since I opened this. But it's definitely high pri if it hasn't