Black fill color disappears - Needed for react-native

🐛 Bug Report
SVG tranform removes the fill prop if the color is black
To Reproduce
Use the playground and paste this:
<svg viewBox="0 0 180 135" id="za">
  <g id="South-African-Rand">
    <polygon fill="#002395" points="0.6 0.9 0.6 135.9 180.6 136 180.6 0.999277156" />
    <polygon fill="#DE3831" points="0.6 0.9 0.6 68.4 180.6 68.4 180.6 0.999277156" />
    <polygon fill="#000000" points="0.6 25.875 0.6 110.475 63.15 110.475 63.15 25.875" />
    <path d="M61.2875482,68.4 L0.639039756,27.9676611 L0.6,0.9 L41.2503758,0.9 L142.412452,68.4 L41.2503758,135.9 L0.6,135.9 L0.6,108.886816 L61.2875482,68.4 Z M101.85,90.9 L101.85,45.9 L180.6,45.9 L180.6,90.9 L101.85,90.9 Z" fill="#FFFFFF" fillRule="nonzero" />
    <polygon fill="#FFB612" fillRule="nonzero" points="61.2875482 68.4 0.6 28.5425781 0.6 0.9 101.85 68.5 0.6 135.9 0.6 107.5485" />
    <path d="M77.5125289,68.4 L0.566362555,17.1025558 L0.518719952,1.02192007 L25.0863868,0.999277156 L126.187471,68.4 L25.0272297,135.840161 L0.631850962,135.947776 L0.602532928,119.673331 L77.5125289,68.4 Z M101.85,81.9 L101.85,54.9 L180.6,54.9 L180.6,81.9 L101.85,81.9 Z" fill="#007A4D" fillRule="nonzero" />
  </g>
</svg>

Expected behavior
Black color should stay. It doesn't:
import React from "react"
import Svg, { Path } from "react-native-svg"

function SvgComponent(props) {
  return (
    <Svg viewBox="0 0 180 135" {...props}>
      <Path fill="#002395" d="M.6.9v135l180 .1V1z" />
      <Path fill="#DE3831" d="M.6.9v67.5h180V1z" />
      <Path d="M.6 25.875v84.6h62.55v-84.6z" /> <---------------- BLACK MISSING HERE
      <Path
        d="M61.288 68.4L.639 27.968.6.9h40.65l101.162 67.5L41.25 135.9H.6v-27.013L61.288 68.4zm40.562 22.5v-45h78.75v45h-78.75z"
        fill="#FFF"
      />
      <Path
        fill="#FFB612"
        d="M61.288 68.4L.6 28.543V.9l101.25 67.6L.6 135.9v-28.352z"
      />
      <Path
        d="M77.513 68.4L.566 17.103.52 1.022 25.086.999 126.187 68.4l-101.16 67.44-24.395.108-.03-16.275L77.513 68.4zm24.337 13.5v-27h78.75v27h-78.75z"
        fill="#007A4D"
      />
    </Svg>
  )
}

export default SvgComponent

Render in react-native

Render on the web (without --native flag)
That works fine because svg fill on the web default to black
https://www.w3.org/TR/SVG/painting.html#FillProperty
## System:
 - OS: macOS Mojave 10.14.4
 - CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
 - Memory: 75.28 MB / 16.00 GB
 - Shell: 5.3 - /bin/zsh
## Binaries:
 - Node: 12.5.0 - ~/.nvm/versions/node/v12.5.0/bin/node
 - Yarn: 1.17.3 - ~/.nvm/versions/node/v12.5.0/bin/yarn
 - npm: 6.10.3 - ~/.nvm/versions/node/v12.5.0/bin/npm
 - Watchman: 4.7.0 - /usr/local/bin/watchman

Hello looks like it is a bug in SVGO, but I have to check it. The SVGO disable toggle does not work in playground, another bug 🙄

Thanks. For now we'll use a workaround and do fill="#000001" :P

#000 is the default.
https://github.com/svg/svgo/issues/917#issuecomment-370162654
And it's being removed by removeUnknownsAndDefaults svgo plugin. So, just disable it.
`yml
#.svgo.yml
plugins:

removeUnknownsAndDefaults: false
`

Seems solved!


Kimai v2 support

Hello there! Are there any plan to support Kimai v2?

Hi, I have it on the radar, but think it might only come in Q4. Due to other priorities, I expect we switch to v2 somewhen next year.

Would love to use it with Kimai2!

Dear all,
we have decided not to switch to Kimai 2, and for this I do not plan any updates in the near future.
I created a new branch, so if someone has resources to update to Kimai version 2, I am happy to accept pull requests. You can also feel free to clone this repository and do updates elsewhere. I can include a link then.

What are the main difference between Kimai2 v1.x and v2 that prevent this plugin to be updated ?
I might have time later this year to look at this.

Hi, the updates requires according the block quite some changes: https://www.kimai.org/documentation/migration-v2.html
As my core customer has decided not to change to kimaiV2, I did not plan for the update myself, but would be happy if you could support.
One of the changes is the license with changed from MIT to GPLv3 which makes it different when code for a plugin is copied from the core tool.

Thanks, I'll look at that send pull requests if it works, but from what I understand you won't update your plugin if you keep using Kimai2 v1.x ?

I will test whether it runs on both and I will maintain a second branch for v2.

Work is ongoing. Many thanks to Vitor. The branch is kimai_v2_update.

Thanks also to @sammaclennan for working on this issue as well. It's still buggy, but gets better and better.

Hi @KatjaGlassConsulting
Could you list the pending points to finish this issue? Maybe will help to receive contributions from other developers.

Hi @vitormattos, Kevin did directly a new PR to support the new kimai version. This PR will likely be merged soon. Can you probably already test that? Unluckily he didn't see the kimai_v2_update branch. Maybe I will also switch the main to Kimai v2 support and a new kimai_v1 branch.
Thanks to your support already and have great vacation days!

A best way to prevent this is to create a new branch from main called: stable1
Because stable1?

Will be the version of this app that will maintain compatible with Kimai v1 and only will receive cherry picks from main branchi

And maintain the branch main compatible to newest version of Kimai.
Every when launch a new big version of Kimai that break the Approval, we will need to create the next stable branch from main.

Thanks to all the supporter - version 2 support is now available on the main branch with the current Release as version 2.0.0. The version 1 support is available on the bundle_for_kimai_v1 branch with the current Release as version 1.0.0.


Migrate to PMD 7

Relese notes https://docs.pmd-code.org/pmd-doc-7.0.0/pmd_release_notes.html
Migration guide https://docs.pmd-code.org/pmd-doc-7.0.0/pmd_userdocs_migrating_to_pmd7.html

See https://github.com/pmd/pmd/issues/4707


Detect appliance class more accurately

Better detects appliance class (AC vs de-humidifier) by making an additional call to the appliance_details endpoint when calling get_appliances
This resolves https://github.com/bm1549/home-assistant-frigidaire/issues/11 and any similar issues people are having
This PR also updates test.py to allow the usage of a config.ini file to make it harder to accidentally commit credentials 😄

@gazpachoking let me know if you can test this on your dehumidifier

Yep, looks like it's working on my dehumidifier, seems like a good plan!


Fail to reproduce the results

Thanks for this excellent work!
Unfortunately, I encountered some difficulties while attempting to replicate the results from your paper. Would you be able to provide additional details regarding the methodology and experimental setup to help me better understand and reproduce your research findings?

Here is my hyperparameters, I tried to make the mask more controllable by increasing the value of w^s and w^c, however, none of them are useful.

can I ask which version of SD are you using?

sd v1.5

we recommend using the default values.
generally, results are not good if values after the modulation deviate too much from the original ones.
please refer to paragraph "Value-range Adaptive Attention Modulation" of section 3.2 in the paper of this work.

Default setting cannot provide satisfying results though :(, not so sure why this happen

it works okay on my device with the layout condition similar to yours ...

could you try with a refined full text in (3), and if it is still not working,
please share your gradio_app.py file with me so that I can check the problem.

Still not working, I tried refined full text in (3), here is the results:

I merely changed two lines in gradio_app.py:
line 18: os.environ["GRADIO_TEMP_DIR"] = 'my dir'
line 69: use_auth_token='my token'

I updated gradio_app.py file with some examples.
if you keep failing and if it is not a burden for you, could you try with redownloaded SD v1.5?

I might have figured out why.
Also I encodered this issue #4 , my diffusers version is 0.19.3, and tried 0.20.1 too, still this error.
To make it work I did:
In pipline_stable_diffusion.py, change:

to

Seems this modification will essentially bypass the NSFW filter, maybe that's the reason I failed to produce the results.
Then I downgraded the diffusers to 0.12.1, redownloaded the sd v1.5.
Here is my results :), the results look fine:

By the way, I cannot use refined prompt in this example, the mask label number seems have set to be aligned with the number of comma.

Thanks again for helping me out, I'll close this issue then.


az upgrade ends with error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az upgrade
Errors:
cannot import name 'status_tag_messages'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    out_file = sys.stdout
cli/core/commands/__init__.py, ln 659, in execute
    ex, id_arg = exceptions[0]
cli/core/commands/__init__.py, ln 722, in _run_jobs_serially
    try:
cli/core/commands/__init__.py, ln 715, in _run_job
    return cmd_copy.exception_handler(ex)
...
<frozen importlib._bootstrap>, ln 618, in _exec
<frozen importlib._bootstrap_external>, ln 678, in exec_module
<frozen importlib._bootstrap>, ln 219, in _call_with_frames_removed
azure/cli/core/__init__.py, ln 57, in <module>
    _configure_knack()
azure/cli/core/__init__.py, ln 45, in _configure_knack
    from knack.util import status_tag_messages
ImportError: cannot import name 'status_tag_messages'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az upgrade

Expected Behavior
Environment Summary
Linux-5.4.0-1036-azure-x86_64-with-debian-buster-sid
Python 3.6.10
Installer: DEB

azure-cli 2.20.0

Additional Context

Duplicate of #16952


Add http GET api

http_get_async("https://mossranking.com/api/getwr.php?cat=201", function(res, err)
    if res then
        local wr = json.decode(res)
        prinspect(wr)
    elseif err then
        prinspect(err)
    end
end)

{ "S̼̼ͪh͚͚ͯa͔͔ͩd̶̵ow", "81250", "1:21.250", "2023-08-05" }

Time flies, I wrote this last year it seems. It was just missing the safe_cb wrapper, which it now has. Probably wasn't anything else wrong with it.


frontend: Add special handling for HTTP errors when trying to begin a streaming chat

While there was some handling for HTTP errors already, the default onOpen handler we were using with the fetch-event-source ended up swallowing HTTP errors and throwing its own that hid the underlying problem. In addition, a big try/catch wrapper around the streamConverse call was further masking error messages and potentially replacing some detailed error messages with more generic messages.
AI Description

This pull request introduces changes to the CohereClient class and the useChat function, along with a minor adjustment to the MessageContent component.
CohereClient Class:

The onopen property now features an asynchronous function that handles the response. If the response status is not 200 and the content type includes 'application/json', the function awaits the JSON response, catches any errors, and throws a CohereNetworkError with the error message and status.

useChat Function:

The try-catch block surrounding the streamConverse call has been removed, simplifying error handling.
The streamConverse call now includes an onError callback, which handles errors and updates the conversation state accordingly.
The onError callback distinguishes between CohereNetworkError and StreamError, setting error messages and updating the conversation accordingly.
The setConversation function is called with the final message when the stream ends, and the setStreamingMessage function is set to null.

MessageContent Component:

The button element's class has been updated from underline to ml-2 underline.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.11%. Comparing base (76e9270) to head (e9cf61a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   78.96%   78.11%   -0.86%
==========================================
  Files         258      259       +1
  Lines       10984    11114     +130
==========================================
+ Hits         8674     8682       +8
- Misses       2310     2432     +122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This is amazing. Would it be complex to add this behaviour to coral_web as well?

Yup - added now


question

Congratulations on getting your paper published. May I ask under which path the pre-training Vit-B is placed

已解决

Thanks for your attention!
Here is the path:

You should place it to "your/path/to/pretrain...", where you can find in the config files!
If you have any questions,  just ask me!


cell cycle reg MMS PMID:10588638

abnormal mitotic cell cycle regulation during cellular response to methyl methanesulfonate

abnormal mitotic cell cycle regulation during cellular response to methyl methanesulfonate FYPO:0005268

edit file: 9027d261a94b01dbb01ff548fd1013c275ce8dfa
release: 223def626685c49cf956fe0665de08de5fb8dc50


Workspace "created" files

I would suggest to display rather the "date modified" then the date a file or folder was "created". It would help find recent  additions faster and this is usually what you are working on.

Technically you can't modify files in your workspace, so the modification date and the creation date should always be the same.  We could update the label though.

@vvons suggested that we at least update the folder's modification date as things are added.  I'm not sure if currently have a modification date field for any of this.  Passing to @olsonanl to evaluate.

I agree this would be pretty useful.  Duplicate of #668


brush machine offline

How to do it @ZZLinvec ? I'm on a linux host!

We currently have no intention of developing a Linux version of the tool.Now I say my code running process, you can follow my code, some windos libraries into Linux on the OK.
Flash the firmware dialog code in Dialog_text.py》class RootDialog.
First, get the IP address and port number of the PC.
Second, set up an HTTP server,
Third, send unlock information and server information to the device.
In the case of these steps, the substitution that should be required is step one.
The corresponding code is located near 618 of the file dialog_text.py

I asked in another issue - what's the procedure to update firmware to latest version?  Do I need to download bin file and do all these steps manually?

I'm writing a C# app to replace the Python tool which should work on Linux (using mono)

And how does it work offline @ZZLinvec ? I don't want contact to cloud!

Flash firmware here refers to downloading third-party firmware to the device.Note that this would mean breaking the firmware of our device.We will no longer guarantee it.

What does offline mean?
Devices downloading firmware in DIY mode must be reported to the server, so the unlocking step cannot be skipped

downloading third-party firmware to the device

Why anybody will need to bother with DIY version to "downloading third-party firmware to the device"?
The whole idea of DYI devices is to use them without flashing the FW.
The only need to flash new FW- is to upgrade FW to latest Sonoff DIY version without going back to "non-DIY" mode and using ewelink app to update FW.  Then going through all the pain of changing back to DIY mode.

@alexbk66  No, do it yourself. This firmware is not just a way to use DIY, it's more important to develop FW yourself. This is no longer just DIY control under the LAN.

@alexbk66 No, do it yourself. This firmware is not just a way to use DIY, it's more important to develop FW yourself. This is no longer just DIY control under the LAN.

What do you mean "do it yourself"?  So you suggest switching to eWeLink mode to update the firmware and then go through all the pain of changing to DIY mode again?
Seriously @ZZLinvec - you have to start thinking more about your (potential) customers!
If you don't - I will tell all my users (HomeSeer) to forget about Sonoff and choose Shelly devices - they are very professionally implemented.
And I will make sure your management is also informed. It's really getting onto my nerves, I wasted so much time.

This is a misunderstanding, I mean we have more DIY space, not to ignore your opinion

Yeah?  I asked many times - how to upgrade Sonoff firmware?
You agree that manually upgrading 20 Sonoff devices in my house is simply not feasible.

This is a misunderstanding, I mean we have more DIY space, not to ignore your opinion

Most enthusiasts who want to flash third party firmware don't mind initially wiring the device to the computer.  The best advantage of DIY devices is local control - that's all most users need, so third party firmware is not really needed anymore.

@ZZLinvec did you look at Shelly devices? They support without any jumpers/flashing:

WiFi Access Point (AP mode) or
Client Mode (STA)
MQQT
REST
CoIoT commands
Cloud control
HTTP Webserver

https://www.youtube.com/watch?v=zFIPrJybt94

I asked in another issue - what's the procedure to update firmware to latest version? Do I need to download bin file and do all these steps manually?

To update offical firmware to device it needs to do it through ewilink app

To update offical firmware to device it needs to do it through ewilink app

I guess so. But that's where the problem is - I have to switch to eWiLink mode, update FW, then go through the pain of changing back to DIY mode again?  And that's for my 20 devices?

@alexbk66 Ok, I understand your needs. I want to know more about your needs. Are there any other ways of instant messaging?It is more convenient for us to communicate and improve our efficiency.

@alexbk66 Ok, I understand your needs. I want to know more about your needs. Are there any other ways of instant messaging?It is more convenient for us to communicate and improve our efficiency.

Sure - Skype, Viber, Whatsapp

Hello @ZZLinvec

@ZZLinvec :grey_question:

@rradar   (I don't work for Itead)
Have you used the ewilink app to update to the latest firmware? This is the only way supported by itead
After that you can use a program like postman to send the json request to flash your bin file.

@alexbk66 Ok, I understand your needs. I want to know more about your needs. Are there any other ways of instant messaging?It is more convenient for us to communicate and improve our efficiency.

So, @ZZLinvec - Skype, Viber, Whatsapp?

I see itead is not taking things seriously. I thought I could deploy the sonoff mini's directly in new constructions (talking about 100/1000+ devices) but if the software support is so miserable I better switch to a serious vendor like using the shelly.
Nice try @iteadsw @ZZLinvec but good hardware alone isn't worth it! If you don't let the users decide if they want to use your sh!tty cloud/apps etc. you are out of business...

I see itead is not taking things seriously. I thought I could deploy the sonoff mini's directly in new constructions (talking about 100/1000+ devices) but if the software support is so miserable I better switch to a serious vendor like using the shelly.
Nice try @iteadsw @ZZLinvec but good hardware alone isn't worth it! If you don't let the users decide if they want to use your sh!tty cloud/apps etc. you are out of business...

Well put!
Shelly actually released a dimmer device!


Add document discussing how to use test snapshots

What
Add document discussing how to use test snapshots.
Why
Close #480
cc @kalepail

Preview is available here:http://developers-pr824.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr824.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr824.previews.kube001.services.stellar-ops.com


MAPPING.CONFIG doesn't support same name mapping with multiple key

For instance,
name: Component
component: Component

will cause error.

Following is the cause of the problem:
mappings[user_key] = about_key

and we use the mapping key as the user_key which replace the first mapping expression


Error when installed into an app running v2.14.1 of Ember

STEPS TO REPLICATE

Install<EMAIL_ADDRESS>Run ember new testApp
Run ember install ember-frost-core
Run ember s and receive this error:

The Broccoli Plugin: [BroccoliMergeTrees] failed with:
TypeError: The plugin [null,{}] didn't export a Plugin instance
    at PluginManager.validate (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/plugin-manager.js:164:13)
    at PluginManager.add (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/plugin-manager.js:213:10)
    at File.buildTransformers (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/index.js:237:21)
    at new File (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/index.js:139:10)
    at Pipeline.transform (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/pipeline.js:164:16)
    at my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/lib/parallel-api.js:102:26
    at initializePromise (my-project/node_modules/rsvp/dist/rsvp.js:567:5)
    at new Promise (my-project/node_modules/rsvp/dist/rsvp.js:1033:31)
    at Object.transformString (my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/lib/parallel-api.js:101:12)
    at Babel.transform (my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/index.js:110:22)

The broccoli plugin was instantiated at:
    at BroccoliMergeTrees.Plugin (my-project/node_modules/broccoli-plugin/index.js:7:31)
    at new BroccoliMergeTrees (my-project/node_modules/broccoli-merge-trees/index.js:42:10)
    at BroccoliMergeTrees (my-project/node_modules/broccoli-merge-trees/index.js:36:53)
    at Class.treeForAddon (my-project/node_modules/ember-frost-core/index.js:190:12)
    at Class.superWrapper [as treeForAddon] (my-project/node_modules/core-object/lib/assign-properties.js:34:20)
    at Class._treeFor (my-project/node_modules/ember-cli/lib/models/addon.js:551:33)
    at Class.treeFor (my-project/node_modules/ember-cli/lib/models/addon.js:511:21)
    at project.addons.map.addon (my-project/node_modules/ember-cli/lib/broccoli/ember-app.js:557:22)
    at Array.map (native)
    at EmberApp.addonTreesFor (my-project/node_modules/ember-cli/lib/broccoli/ember-app.js:555:32)

This seems like a possible lead, especially with the fix that was implemented - https://github.com/ember-cli/ember-cli-mocha/issues/182
Specifically that it may not be an "obvious" reason.

The problem is due to a mismatch in the versions of ember-cli-babel.  If the version of ember-cli-babel is changed from ^6.3.0 to ^5.1.7 and the version of ember-cli-htmlbars-inline-precompile is changed from ^0.4.3 to ^0.3.0 then the application will build/serve without encountering this error.

Just killed 3hrs to find out why Ember project halts with "redux" not installed.

Build failed.
The Broccoli Plugin: [BroccoliMergeTrees] failed with:
Error: Cannot find module 'redux' from '/Users/machine-user/Work/My_Projects/some-project/tmp/plugin-output_path-cbzrUuiG.tmp'
    at /Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:49:14
    at process (/Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:177:43)
    at ondir (/Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:192:17)
    at load (/Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:73:43)
    at onex (/Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:96:31)
    at /Users/machine-user/Work/My_Projects/some-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:111:15)

The broccoli plugin was instantiated at:
    at BroccoliMergeTrees.Plugin (/Users/machine-user/Work/My_Projects/some-project/node_modules/broccoli-plugin/index.js:8:31)
    at new BroccoliMergeTrees (/Users/machine-user/Work/My_Projects/some-project/node_modules/broccoli-merge-trees/index.js:42:10)
    at Class.postprocessTree (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-browserify/lib/index.js:66:14)
    at projectOrAddon.addons.reduce (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/utilities/addon-process-tree.js:7:25)
    at Array.reduce (native)
    at addonProcessTree (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)
    at Class._addonPostprocessTree (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/models/addon.js:413:12)
    at Class.processedAddonJsFiles (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/models/addon.js:1172:37)
    at Class.compileAddon (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/models/addon.js:1080:24)
    at Class.treeForAddon (/Users/machine-user/Work/My_Projects/some-project/node_modules/ember-cli/lib/models/addon.js:738:26)

Your fix isn't helping
BLOCKER....

Is this fixed? I'm trying to update ember-cli to 2.18.0 and since ember-frost-core needs these old versions, I just can't upgrade without encountering multiple errors.

@dguayrobotiq This has not yet been fixed.  https://github.com/ciena-blueplanet/ember-prop-types/issues/158#issuecomment-370573212 provides more insight into the reason it has not been and when we are planning to do so.

@notmessenger If I understand it correctly, If I want to upgrade to ember-cli 2.13+, all of my dependencies need to use ember-cli 2.13+?

According to https://emberjs.com/blog/2017/04/29/ember-2-13-released.html

Babel 6 support has been added to Ember CLI internally and is now used by default for newly generated projects (both applications and addons). Due to the way that Ember CLI handles transpilation this transition can be done gradually by updating each addon to utilize newer versions of ember-cli-babel.

Which reads to me as if the transition from Babel 5 to Babel 6 should have never caused an issue (other than needing to change the version of ember-cli-babel being used) yet this change is specifically causing us issues and we have not been able to work in a mixed Babel environment.
We have not been able to determine whether others are experiencing similar issues (with apps and other addons (not ours) or if enough projects moved forward around the time this switch over occurred that it didn't really manifest itself.   We have not seen any conversation in the community about the difficulties we have been experiencing so it is possible that this is a problem of our own making but we have not been able to determine what the issue is which would then allow us to do so piecemeal rather than having to do all at once (we have around 75 addons and dozens of apps).  To say that this is impacting us, and by extension others such as yourself, is an understatement.  We began having meetings this past week to figure out our game plan and we are going to dedicate some time to specifically digging into this problem and re-creating it as a smaller scale so we can involve the community at large in discovering a solution (besides just upgrading everything which is our ultimate desired end goal).


[Bug]: global is not defined with walletconnect

Current Behavior
When clicking the WalletConnect option, an error appears: global is not defined
Expected Behavior
The WalletConnect QR code should appear
Steps To Reproduce

Clone this repo: https://github.com/beeb/lp-rescue-frontend
pnpm run build
pnpm run preview
Open preview URL in browser
Click Connect button in top right
Click WalletConnect

What package is effected by this issue?
@web3-onboard/walletconnect
Is this a build or a runtime issue?
Runtime
Package Version
@web3-onboard/walletconnect: 2.2.2
Node Version
16.19
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?

Here is where the walletconnect module is defined
https://github.com/beeb/lp-rescue-frontend/blob/c1acad87df54292b622e6c2f2e634f423b89e64a/src/lib/constants.ts#L72-L94
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Hey @beeb! It looks like your svelte/vite config is missing some configurations - docs around this can be found here - https://onboard.blocknative.com/docs/modules/core#sveltekit
Let me know if the issue still persists after updating your config

Hi @Adamj1232 . I think the documentation is outdated, since there is no vite item in the svelte config anymore. Nowadays this would probably go into the vite.config.ts file. Likewise, detection of the dev environment should probably happen with import { dev } from '$app/environment'. The problem is that this bug appears in production too, so the polyfill probably wouldn't help here.
And then for the rollupOptions the following is not a valid argument according to typescript: nodePolyfills({ crypto: true, http: true }):
export interface NodePolyfillsOptions {
    baseDir?: string;
    sourceMap?: RollupInjectOptions['sourceMap'];
    include?: Array<string | RegExp> | string | RegExp | null;
    exclude?: Array<string | RegExp> | string | RegExp | null;
}

I went forward anyway with the config and I get the following build error:
[commonjs--resolver] Could not load crypto-browserify: ENOENT: no such file or directory, open 'crypto-browserify'
file: /home/.../lp-rescue-frontend/node_modules/.pnpm/@unstoppabledomains+resolution<EMAIL_ADDRESS>error during build:
Error: Could not load crypto-browserify: ENOENT: no such file or directory, open 'crypto-browserify'
 ELIFECYCLE  Command failed with exit code 1.

The build was happening fine before I made the changes described in the docs.

I found this resource: https://github.com/blocknative/web3-onboard/blob/main/examples/with-sveltekit/vite.config.ts
That way I can compile successfully.
But even with those changes I still get the same error.

Ok I took the official example linked above, updated all the dependencies to latest (using pnpm), and then tried to run pnpm run build.
First few times it complained because @web3-onboard/injected-wallets and @web3-onboard/core were missing from the dependencies, so I had to add them (pnpm add -D ...). After that it compiled but the bug I'm describing is also happening in the official example (global is not defined).

For your convenience I published the reproduction here, based on the official example:
https://github.com/beeb/repro-walletconnect

@beeb I can confirm this is an issue with walletconnect v1, v2 seems to be working as expected. Will have a v1 fix shortly.

@beeb the vite.config.js I was able to get working within the example project looks like:
import { sveltekit } from '@sveltejs/kit/vite'
import inject from '@rollup/plugin-inject'

import type { UserConfig } from 'vite'
import nodePolyfills from 'rollup-plugin-polyfill-node'

const MODE = process.env.NODE_ENV
const development = MODE === 'development'

/** @type {import('@sveltejs/kit').Config} */

const config: UserConfig = {
  plugins: [
    sveltekit(),
    development &&
      nodePolyfills({
        include: ['node_modules/**/*.js', new RegExp('node_modules/.vite/.*js'), 'http', 'crypto']
      })
  ],
  resolve: {
    alias: {
      crypto: 'crypto-browserify',
      stream: 'stream-browserify',
      assert: 'assert'
    }
  },
  build: {
    rollupOptions: {
      external: ['@web3-onboard/*'],
      plugins: [nodePolyfills({ include: ['crypto', 'http'] }), inject({ Buffer: ['Buffer', 'Buffer'] })]
    },
    commonjsOptions: {
      transformMixedEsModules: true
    }
  },
  optimizeDeps: {
    exclude: ['@ethersproject/hash', 'wrtc', 'http'],
    include: [
      '@web3-onboard/core',
      '@web3-onboard/sequence',
      'js-sha3',
      '@ethersproject/bignumber'
    ],
    esbuildOptions: {
      // Node.js global to browser globalThis
      define: {
        global: 'globalThis'
      },
    }
  },
  define: {
    global: 'window'
  }
}

export default config

Can you test on your end and see if this fixes WalletConnect v1(v2 works as well with this)

I have a branch working from the https://github.com/beeb/repro-walletconnect repo but cannot push because of privileges...if you want to give me access I can push up this example.
I used the config above, removed the define.global and added updates the package.json to be
{
	"name": "lp-rescue-frontend",
	"version": "0.3.0",
	"private": true,
	"scripts": {
		"dev": "vite dev",
		"build": "vite build",
		"preview": "vite preview",
		"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
		"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
		"lint": "prettier --plugin-search-dir . --check . && eslint .",
		"format": "prettier --plugin-search-dir . --write ."
	},
	"devDependencies": {
		"@esbuild-plugins/node-globals-polyfill": "^0.2.3",
		"@iconify-json/ri": "^1.1.4",
		"@poppanator/sveltekit-svg": "^2.1.2",
		"@sveltejs/adapter-auto": "^1.0.2",
		"@sveltejs/kit": "^1.3.7",
		"@tailwindcss/typography": "^0.5.9",
		"@typescript-eslint/eslint-plugin": "^5.50.0",
		"@typescript-eslint/parser": "^5.50.0",
		"@web3-onboard/core": "^2.14.1",
		"@web3-onboard/injected-wallets": "^2.6.2",
		"@web3-onboard/walletconnect": "^2.2.2",
		"autoprefixer": "^10.4.13",
		"daisyui": "^2.50.0",
		"eslint": "^8.33.0",
		"eslint-config-prettier": "^8.6.0",
		"eslint-plugin-svelte3": "^4.0.0",
		"ethers": "^5.7.2",
		"postcss": "^8.4.21",
		"prettier": "^2.8.3",
		"prettier-plugin-svelte": "^2.9.0",
		"prettier-plugin-tailwindcss": "^0.2.2",
		"rollup-plugin-polyfill-node": "^0.12.0",
		"svelte": "^3.55.1",
		"svelte-check": "^2.10.3",
		"svelte-ethers-store": "^2.5.9",
		"svelte-notifications": "^0.9.98",
		"svelte-preprocess": "^4.10.7",
		"tailwindcss": "^3.2.4",
		"theme-change": "^2.3.0",
		"tslib": "^2.5.0",
		"typescript": "^4.9.5",
		"unplugin-icons": "^0.14.15",
		"vest": "^4.6.8",
		"vite": "^4.0.4"
	},
  "dependencies": {
    "@web3-onboard/core": "^2.15.4",
    "@web3-onboard/injected-wallets": "^2.8.1",
    "@web3-onboard/walletconnect": "^2.3.1",
    "buffer": "^6.0.3"
  },
	"type": "module"
}

I also added this:
	<script>
		/**
		 * this is a hack for error: global is not defined
		 */
		var global = global || window
	</script>

to app.html

I created a PR to get the the Web3-Onboard local working that you can see here: https://github.com/blocknative/web3-onboard/pull/1569
I havent had time to dig into why in your projects case that script needed to be added to the html. Could be that our example is use next versions of sveltekit. If you happen to find out please post it here.

if you want to give me access I can push up this example.

Done! Thanks for looking into this. I will try to see what are the minimal changes I need to make so that it works with v1. I'm pretty sure some of the configuration items should not be needed.

I used the config above, removed the define.global and added updates the package.json to be

Did you try with pnpm? Because I'm trying to reproduce your changes but I hit so many errors...
I'll wait until you publish your branch and then test again.

@Adamj1232 I also noticed in my repro example that the pnpm run dev command doesn't work at all (some error with RxJS).

@beeb ah you granted access to the repro-walletconnect project and I have a fix working on the lp-rescue-frontend project...for my testing I was using either npm(your project) or yarn (web3onboard local) I am not familiar with pnpm and dont really have the cycles to spend on it at this moment

I'm sorry @Adamj1232 but your branch in the repro repo doesn't work for me, even with regular npm.
Also, why did you switch to walletconnect v2? The goal was to fix v1.
Dev mode is broken with pnpm. But regardless, npm run build and pnpm run build both fail completely.
[vite]: Rollup failed to resolve import "Buffer" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

There are for some reason 2 polyfill libraries loaded, I'm pretty sure some of the stuff that was added doesn't contribute to solving the problem.

Ok, so I had a deeper look and approached the problem methodically. The workaround is now available in main here https://github.com/beeb/repro-walletconnect
PNPM
First observation: pnpm is not supported.
The dev server (pnpm run dev) throws an error related to rxjs on SSR:
Internal server error: exports is not defined
      at eval (/node_modules/.pnpm/rxjs@7.8.0/node_modules/rxjs/dist/cjs/operators/index.js:4:23)
      at instantiateModule (file:///home/valentin/temp/repro-walletconnect/node_modules/.pnpm/vite@4.1.4/node_modules/vite/dist/node/chunks/dep-ca21228b.js:52420:15)
ReferenceError: exports is not defined
    at eval (/node_modules/.pnpm/rxjs@7.8.0/node_modules/rxjs/dist/cjs/operators/index.js:4:23)
    at instantiateModule (file:///home/valentin/temp/repro-walletconnect/node_modules/.pnpm/vite@4.1.4/node_modules/vite/dist/node/chunks/dep-ca21228b.js:52420:15)

When the dependencies are installed with npm the dev server works fine.
Buffer polyfill
It seems some component or dependency requires Node's Buffer. To polyfill this, the simplest way I could find was to install the buffer package and include the following in web3-onboard.ts:
import { Buffer } from 'buffer'
globalThis.Buffer = Buffer

Global is not defined
Finally, since global is not defined, I added the following to the app.html, according to your suggestion:
<script>
      var global = global || window
</script>

That's it
Nothing more, nothing less is needed. I didn't change the vite.config.ts file at all.
It's very annoying that this library is not compatible with pnpm, since it's much much faster and space-efficient than npm and has grown in popularity a lot.

@beeb Im glad you were able to resolve your issue which seems to be a problem with pnpm.
You could consider digging into what is happening on their end as Web3-onboard works with npm and yarn without problem.
I will make sure this is noted in our docs, thanks.

@Adamj1232 the main difference with pnpm is that it symlinks the dependencies into node_modules, so you avoid to have duplicate packages stored on disk everywhere. Some packages use the node_modules folder in weird ways which conflicts with how pnpm does it. That's my best guess, but I don't have the resources to go dig deeper.
Although I've been using pnpm for a year now and this is the only time I had to switch npm, so something is definitely not perfect in web3-onboard or one of its dependencies.

@beeb interesting, thanks for sharing. It is challenging supporting many downstream deps along with newer projects like pnpm and the huge number of front end frameworks, bundlers and compilers as everything evolves. We are an open source project and we are free to use and contribute to so we rely on community members such as yourself to help with edge cases.

@Adamj1232 I'm very thankful for the contributors to this project that allowed me to kickstart my dApp. Open-source is wonderful but can be challenging sometimes, especially when you find yourself in dependency hell. I agree that the current landscape of web frontend is extremely challenging.
I really just wish there was a nice clean solution for connecting wallets that doesn't have thousands of dependencies and that is "more" framework agnostic.
Thanks for your help!


Mobile Client

Mobile client for IOS and Android soon please. If you're not able to get in on App Store then look at being able to get users to download it through a different medium.

Rejected https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features


i want to add a customised readme.md file.

Hello @Swapnanilmanna1701
kindly assigned me for this task.

Hie @supritimondal1102 you are assigned.


Gitpod Docker Build and Container Version

Changes Made:

Added the docker image tag in gitpod yml file instead of referencing to gitpod.Dockerfile

PR for issue number : #167

Looks good to me


Objective-c: secure connection & retry mechanism

While trying gRPC connexion over poor network conditions , it seemed that GRPCCalls made over tls were not retried (i kept having "Handshake read failed" errors immediatley followed by a code 14 error).
Is there any retry mechanism in place over secure connections ?

Craig and Muxi recently landed a fix for this. I don't know when it's planned to be released though.

Thanks a lot !
Have any idea what the ETA could be (min / max) ? i've built a custom retry mechanism on top of the lib, and wonder if i should keep it or just wait for you guys to release the fix.

This fix should have already been merged into master branch. The upcoming v1.0.1 should also include this fix; the release process is kicking off on Monday. Feel free to choose any one of them. :)

Great to hear that.

Great news, thanks. Did anyone had the chance to look at my other question regarding grpc streams ? ( https://github.com/grpc/grpc/issues/8272 )
I'm asking, because it is related in a way. Basically the question was if gRPC streams were supposed to be auto-reconnecting after a network disconnection, or not.


Make neighbour helpers public

The helpers include several functions to retrieve all neighbours to a given tile. In my move system, however, I only want to know a specific neighbouring tile. Helpers like square_north(), etc are perfect for this, but are not public. This means I have to essentially duplicate the functionality in my own code.
I would submit a PR, but I see that #268 is already in.

Closed by #268


Undesirable behaviour when bad JSON entered into TypedInput

Current Behavior
When I paste JSON with duplicate key, then expand the editor, my JSON is unexpectantly changed (sanitised)
demo

JSON I used
{     "info": "hello",     "abc": "123",     "fff": "www",     "info": "xxxxx" }

Expected Behavior

JSON entered in text field should be faithfully presented in the editor warts n all
2.  This allows me to "see my error" and "fix it up" the way I want to (not take the first key)
TypedInput validator should highlight this as an issue

Steps To Reproduce

Add an inject --> debug
set payload to {     "info": "hello",     "abc": "123",     "fff": "www",     "info": "xxxxx" }
deploy and inject
debug outputs { "info": "xxxxx",     "abc": "123",     "fff": "www" }

Example flow
[{"id":"df3b6e629014dda8","type":"inject","z":"06a2836c9f2ae124","name":"{     \"info\": \"hello\",     \"abc\": \"123\",     \"fff\": \"www\",     \"info\": \"xxxxx\" }","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"{     \"info\": \"hello\",     \"abc\": \"123\",     \"fff\": \"www\",     \"info\": \"xxxxx\" }","payloadType":"json","x":1680,"y":60,"wires":[["9f6565a5dce8016d"]]},{"id":"9f6565a5dce8016d","type":"debug","z":"06a2836c9f2ae124","name":"debug 13","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":1810,"y":100,"wires":[]}]

Environment

Node-RED version: 4.0.0-beta.4
Node.js version: 18
npm version:
Platform/OS: windows
Browser: chrome

https://esdiscuss.org/topic/json-duplicate-keys
This behaves as I expect

I (respectfully) kinda disagree (from a low-code POV)
It tripped my up 😉
I was scratching my head longer than I care to admit as to why the debug output was different to what i seen in the nodes text entry.
stoopid loose terms in the RFC causing confusion! "If a key is duplicated, a parser SHOULD reject." I read that as the parser "should reject". Hey ho.
I'm not entirely sure if we should (or how we would) do anything about it but it just doesnt feel right 🤷
Happy to be told its a "won't fix" item but maybe lets sit on it a while and see if any good ideas crop up?

Mind you, i still think the editor should respect what is entered in the text box.
I was completely tripped by what the expanded editor was showing me matched the debug output - i think there is something to handle there. So I stand by the "JSON entered in text field should be faithfully presented in the editor warts n all"

Does the expanded JSON editor flag it as a syntax exception?

We use JSON.stringfy/parse to roundtrip between the single line input and the multiline editor. Duplicate keys, whilst not flagged as an error, will not survive that round trip. Any fix for this will require a custom json parser/formatter.

Does the expanded JSON editor flag it as a syntax exception of you try and add duplicate keys

It does.

We use JSON.stringfy/parse to roundtrip between the single line input and the multiline editor. Duplicate keys, whilst not flagged as an error, will not survive that round trip. Any fix for this will require a custom json parser/formatter.

It might not require a custom formatter.
If we pass whatever is in the text field directly into the editor it will be shown as "problematic" and the editor itself has a formatter built in that correctly preserves the original data.

We can call the formatter function programmatically too like this:
function formatDocument() {
  editor.getAction('editor.action.formatDocument').run();
}

// on first initialisation
editor.onDidChangeModelLanguageConfiguration(formatDocument);

// on every initialisation
editor.onDidLayoutChange(formatDocument);

// manually
function setValue (v) {
    editor.setValue(v)
    formatDocument()
}

Here is a demo I knocked up: Monaco Playground Programmatically call formatDocument

Regardless of what monaco could do here, if you want the TypedInput to flag an error, it will require a custom JSON parser to spot it and flag it. Not sure how much effort it's worth putting into this in the big scheme of things.

if you want the TypedInput to flag an error, it will require a custom JSON parser to spot it and flag it.

Or just use jsonlint.
const jsonlint = require("@prantlf/jsonlint");
let jsonParsed
try {
    jsonParsed = jsonlint.parse(
      '{     "info": "hello",     "abc": "123",     "fff": "www",     "info": "xxxxx" }',
      { allowDuplicateObjectKeys: false })
    console.log(jsonParsed)
} catch (e) {
    console.error(e);
}

Working demo:
<EMAIL_ADDRESS>

Interesting, it would allow TypedInput to flag an error and at the same time to highlight the spot by changing the color (because the location is available). There is probably a way to use the autoComplete logic (label) for this.


Can't load TypeScript definitions

OS:

[ ]  Windows
[X]  MacOS
[ ]  Linux

Platform:

[X]  iOS
[X]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
v8.9.0
5.5.1

Config:
<EMAIL_ADDRESS>{}).install()

I have following issue:
Typescript definitions won't load
Steps to reproduce:

yarn add react-native-sentry
import Sentry from 'react-native-sentry'

Actual result:

Could not find a declaration file for module 'react-native-sentry'. '/node_modules/react-native-sentry/index.js' implicitly has an 'any' type. Try npm install @types/react-native-sentryif it exists or add a new declaration (.d.ts) file containingdeclare module 'react-native-sentry';``

Expected result:

Be able to use the bundled typescript definitions

Version 0.32.0 has been released which should fix this issue.


"dotnet build" is not cooperating with Microsoft.Build.Utilities.v4.0

"dotnet build" (.NET Core and Standard) will fail with this error:
C:\Users\VssAdministrator.nuget\packages\unmanagedexports.repack.upgrade\1.1.0\build\UnmanagedExports.Repack.Upgrade.targets(57,3): error MSB4062: The "RGiesecke.DllExport.MSBuild.DllExportAppDomainIsolatedTask" task could not be loaded from the assembly C:\Users\VssAdministrator.nuget\packages\unmanagedexports.repack.upgrade\1.1.0\build..\tasks\RGiesecke.DllExport.MSBuild.dll. Could not load file or assembly 'Microsoft.Build.Utilities.v4.0, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

Also since changing to nuget reference (d89ebe66c50d322f2b079c1971de5469536c9965) this error remains. When building in Azure Pipelines as a workaround one can use the plain old msbuild task instead of the dotnet build task.


Validation -- F1 Score, penalization

I have been experimenting with a dataset and a few different classifiers with pulearn. I noticed that all classifiers I had trained had nice f1 scores but upon further inspection of one particular classifier (adaboost) I noticed that it predicted all samples as the positive class. Since the validation is done on the heldout positive samples, the F1 score can still remain high when in fact this classifier is not working. This made me think of a few questions:

What are the standard methodologies used to evaluate a pulearner? Is it holding out a set of positives and computing f1, etc? Or is there any alternative standard methods?

Is there any standard for penalizing a pulclassifier that predicts all samples as one class. What are some strategies to make sure we do not simple predict one class?

Hey. Short on time right now.
Just popped to say that these are VERY good questions, and I stumbled upon them myself when using this approach in a couple of projects.
I found at least one paper which detailed its evaluation schema, and I also remember a place where it was formalized which metrics can be computed and which not. If I remember correctly (and this also makes sense intuitively), in classic PU learning you can compute recall but not precision, because you have no Negative labels, so any predicted positive might be true. Put otherwise, you can never measure the amount of False Positive, and as a result, you can't compute F1 score and anything else that depends on FPs.
BUT, I did find a paper that outlined how to compute a metric that IIRC is correlated with F1 (or it might be a lower bound). Which is cool.
I'm leaving this unread in my mailbox and I'll get back to this in the near future.
Thank you for asking! :)

hey @shaypal5 wondering if you have had time to work in this question?
I am also struggling in finding the "correct" way to try and generalise a metric in a PU learning scenario.

Not really, but slides 33 to 37 in a presentation I once prepared for an intro to PU Learning discusses metrics:
https://docs.google.com/presentation/d/1reAifZKvSy0FlxuOYiAksjYeAoLzn1wdI2d21LQ-COk/edit?usp=sharing
Also, slide 71 has references, and I believe the formalization I referenced can be found in one of the two articles referenced there.
Let me know what you find out!

I've since added slide 38, with specific references to papers dealing with metrics for PU Learning. This includes both Li & Liu 2003, which formalized the F1-like metric for PU, and a couple of much later papers (2015, 2019) on estimating standard metrics for the case of PU (with upper and lower bounds and such):
https://docs.google.com/presentation/d/1reAifZKvSy0FlxuOYiAksjYeAoLzn1wdI2d21LQ-COk/edit?usp=sharing

This was partly addressed in PR #19 !


Create delay topics based on backoff config

Description
Create delay topics based on backoff config, and retry count.

Changed create and update subscription to create delay topics based on sub config.
Try to modify all existing delay topics on partition scaling.

Fixes https://razorpay.atlassian.net/browse/METRO-164
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[ ] Tested on local

Is it a breaking change?
No
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added unit tests that prove my fix is effective or that my feature works (if applicable)
[ ] I have added integration tests for the new feature (if applicable)
[x] I have manually tested my code to the best of my abilities.

Removed @sumitkrzp as he is moving out of the team today, I have added @subintp.


Query Editor: Can't execute saved query with changes

When you load a saved query in the query editor, make some changes to it and submit it, the original saved query is executed and your changes are lost.
When you make any changes in the query editor, either (1) the query_hash parameter should be cleared, or (2) when a bql parameter is present, that should be used as the query instead.
Option (2) might allow for a Reset button, which could be useful.

I don't see any point in keeping the query_hash in the URL. If a user presses the "Submit Query" button, the query was changed (why else would you want run the query) so the query_hash will not be consistent with the query string and should be ignored anyway.

It's there to highlight the correct query in the sidebar and select box, though I see your point. I'd be okay with loosing the highlight after submitting a query.
Alternatively, maybe we could execute the query asynchronously? That would improve responsiveness, and at least ensure we don't loose the highlight of the select box.

It's there to highlight the correct query in the sidebar and select box, though I see your point.

The problem is that it's unclear if we can even determine the "correct" query. We would have to check if the text changed, which too much hassle IMHO. I'll submit a PR removing the query_hash.

Alternatively, maybe we could execute the query asynchronously? That would improve responsiveness, and at least ensure we don't loose the highlight of the select box.

:+1: that would be the right way to bring back the highlight!


Cannot auto focus on the input box

After opening the prompt (with commands like "Compute Normal Form"), the input box won't be automatically focused somehow

Likely to be a vscode broblem

The problem seems to have disappeared


Branch dg remove from class command

Codecov Report

Merging #338 (e0a81b6) into master (523295f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #338   +/-   ##
=========================================
  Coverage     71.30%   71.30%
  Complexity      805      805
=========================================
  Files           129      129
  Lines          2617     2617
  Branches        324      324
=========================================
  Hits           1866     1866
  Misses          665      665
  Partials         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523295f...e0a81b6. Read the comment docs.


UnTar password protected tarball

As of now, I don't see any support for untarring password protected archives. Do you plan to add this support ?

Trying the PGP way.


[GLUTEN-6882][CORE] Move Spark / columnar rule list to backend code

Issue #6882, part of #6853.
The patch removes planner rule customization APIs from SparkPlanExecApi, and adds a new API RuleApi to allow backends inject their own rule list through a given RuleInjector. After the change, backends will maintain their own complete rule lists so more flexibilities will be gained to developers.
Change list:

Remove following APIs in SparkPlanExecApi:

genExtendedDataSourceV2Strategies
genExtendedQueryStagePrepRules
genExtendedAnalyzers
genExtendedOptimizers
genExtendedStrategies
genExtendedColumnarValidationRules
genExtendedColumnarTransformRules
genExtendedColumnarPostRules
genInjectPostHocResolutionRules
genInjectExtendedParser
genInjectedFunctions

Add API trait RuleApi.
Add RuleInjector which is passed to backends through RuleApi from Gluten core. By which backends could inject their own rule lists to Spark and Gluten.

cc @zhanglistar @baibaichen

Run Gluten Clickhouse CI


OAuth Consent Page Redirect

I added functionality to the LoginServlet creates a redirect URL to the OAuth consent page. If the user isn't logged in, the user gets redirected to this URL The user is able to give their consent and have that information be redirected to the OAuthCallbackServlet. Don't worry about the OAuthCallbackServlet at this point. I just added it to confirm that the LoginServlets endpoints work.

Please don't worry about CallBackServlet contents on this PR. I just added it to confirm that the LoginServlets endpoints work.


Font awesome

Font Awesome 4.2.0 is loaded but old Font Awesome 3.x syntax is used for icons.
See here: https://github.com/clearsightstudio/thesis/blob/master/app/assets/stylesheets/thesis/base/_fonts.sass#L6
And here: https://github.com/clearsightstudio/thesis/blob/master/app/assets/javascripts/thesis/thesis.coffee#L206
Assuming I'm not missing something obvious, should these icon classes be updated to use new 4.x syntax?
Also, considering that many apps load Font Awesome already, perhaps it should just be listed as a requirement in the documentation instead of being included in '_fonts.sass'? my app is loading it twice at the moment. Better yet, we create a custom icon-set (font or SVGs) and use it instead of Font Awesome.
Thoughts? I'm happy to help if there is work to do here, just wanted to talk it through first.

@benjaminwood Good point. @yulianglukhenko Do you have any thoughts on this?

Yea, Thesis was started a long time ago - FA 3 was used. I came on board and upgraded FA but didn't bother updating the syntax. The idea was to go with a custom font (like you have mentioned) using icomoon (or something similar) down the road after the big chunk of development was done. This is being designed in-browser so having a range of icons available helps if something needs to be swapped out quickly. However, right now may be a good time to switch. Are you up for working on this? @benjaminwood

@benjaminwood I didn't realize that the icons aren't getting loaded at all right now. I'll push a quick fix with the updated markup for now.

Cool, thanks for the response guys. I can work on the custom font sometime, though there are some other things I'd like to do first if I have the time. I'll create a new issue for the transition to a custom font.
I see @yulianglukhenko fixed the syntax with 62904d746055d26d7b818ccf419dc029f10d9fa9, so I'll close this out now.


'navbar' request failed with error

TypeScript Version:  Version 2.1.0-dev.20160919
[Info  - 1:49:06 PM] Using tsserver from location: /Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js
[Error - 1:49:09 PM] 'navbar' request failed with error.
Error processing request. Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
    at addChildrenRecursively (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:54261:77)
    at rootNavigationBarNode (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:54124:17)
    at Object.getNavigationBarItems (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:54096:47)
    at Object.getNavigationBarItems (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:59788:37)
    at IOSession.Session.getNavigationBarItems (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:61009:61)
    at Session.handlers.ts.createMap._a.(anonymous function) (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:60305:50)
    at IOSession.Session.executeCommand (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:61137:28)
    at IOSession.Session.onMessage (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:61154:35)
    at Interface.<anonymous> (/Users/.../.nvm/versions/node/v4.2.2/lib/node_modules/typescript/lib/tsserver.js:63343:27)
    at emitOne (events.js:96:13)

Works with Version 2.1.0-dev.20160915 stopped working in Version 2.1.0-dev.20160916

Repro seems to be as easy as:
/**
 * Test
 */
export const Test = {

}

@andy-ms can you take a look.

@wallverb can you give typescript@next a try later tonight.

@mhegazy What time are new next versions published to npm usually ? I am still at Version 2.1.0-dev.20160919

looks like the publish task had issues today. it should be published at midnight tonight under 2.0.1-dev20160921. sorry for the delay.

Thanks, got 20160920 - and all is good - fixed


Missing Components not addressed in the documentation

Nice documentation. However, when I try to specify a MySQL source in Power BI, I get an error: "This connector requires one or more additional components to be installed before it can be used." and there is a link for "Learn more"
I follow the link, install the required components, but still get this error.
There are obviously prerequisites that you don't address.
WHAT 'components' are missing? Nobody seems to be able to tell me.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 545a929c-1c6a-29b9-5e59-31f3823946da
Version Independent ID: a7da33e7-7535-1dac-b36a-57f3ded22586
Content: Power Query MySQL database connector - Power Query
Content Source: powerquery-docs/connectors/mysql-database.md
Service: powerquery
GitHub Login: @bezhan-msft
Microsoft Alias: bezhan

@ToddChitt sometimes software installs require a service to be stopped/started or a reboot (kind of the same thing). Could be exiting the app (Excel / PowerBI / PowerQuery processes) and starting again would detect the new assemblies that are installed on your box.

Hi @ToddChitt
This issue has been closed due to lack of any new information for several months. If you have more information to provide, please reopen this issue.


Consider creating an NPM package

Hello, I guess a common use case for this tool is to minify WebGL shaders to allow WebGL web applications to load faster. I would like to use it in the production build step for a game I'm working on. Right now that requires downloading a specific version from the releases page, setting up mono and running the tool with mono. All of this is certainly possible but integrating this into the project makes the CI and the initial setup for other contributors more complicated than it needs to be. Given that you already seem to have a wasm build for the web interface it seems that it shouldn't be that hard to create a simple NPM package based on that. There are other packages providing features like minification but they don't seem to as actively maintained as this project.

Thanks for the feedback! I have no experience with NPM, but I can see how it would be useful.
Contributions would be welcome.

I have some experience with NPM but none with F# and web assembly. Also at a quick glance I could not find how you build the web assembly artifact. I'm happy to help with this but I would need some guidance to how this projects build stuff works.

Open Shader Minifier.sln in Visual Studio (I use the free Visual Studio Community 2022)
Right-Click on SMBolero.Client in the solution explorer
Select Publish...

 You can see the files here: https://ctrl-alt-test.fr/minifier/_framework/. I've zipped all the output if you want to start from there: https://ctrl-alt-test.fr/minifier/wwwroot.zip
In the Javascript console, I can run Shader Minifier using:
DotNet.invokeMethod('SMBolero.Client', 'minify', ['--format', 'text'], 'void main(){ return 1+1; }');

Thanks, I'll see what I can do. I'm on Linux so I don't know if I can get Visual Studio to run. Perhaps it works with MonoDevelop? But I could start to create a basic package just on the files you've provided. If I manage to do that I will get back to you here. I might be able to give it a shot tomorrow evening, if not then only in like 2 weeks. So it might take a while for me to respond.
How is your process when you release a new version? Is it manually or do you have some kind of CI pipeline (does not appear that way)? Would you be fine with me publishing that NPM package or would you like to do that yourself? Its not very hard, I can provide you with instructions and all the code required or do it myself.

VS shouldn't be required, but I don't know the command-line (maybe dotnet publish with some arguments).
The release process is currently manual (it's a single file, so I don't mind).
Once you get a package, we can discuss how to proceed. If it can be automated somehow (with GitHub actions?), that would be ideal. I don't mind if you publish the package yourself.

A potential problem with the current wasm build is that it is intended for the browser as this blazor thing seems to be for UI stuff. I don't fully understand how the web client works but if I understand correctly its written in F# and somehow compiled to JS/WASM. I tried to dotnet-wasi-sdk which creates a standalone wasm file which can be executed with wasmtime. That actually worked, meaning I got the CLI tool to run with wasmtime. Which means I could very easily run this from within a nodejs script. I don't know how to get files into and out of that though, I only got to the help screen.
For later reference, these are the commands I have used:
cp shader-minifier-linux.fsproj shader-minifier-wasm.fsproj
dotnet add shader-minifier-wasm.fsproj package Wasi.Sdk --prerelease
dotnet build shader-minifier-wasm.fsproj
wasmtime obj/Debug/net48/dotnet-wasi-sdk/shader-minifier-wasm.wasm

So I still have to figure out how get data in and out, maybe I can find some examples. Another option would perhaps be this: https://devblogs.microsoft.com/dotnet/use-net-7-from-any-javascript-app-in-net-7/

If it can be automated somehow (with GitHub actions?), that would be ideal. I don't mind if you publish the package yourself.

I would like to automate it as much as possible. The publishing of the package on NPM has to be manual though (I think) as you need two factor auth stuff. But lets worry about that once we have a working package.


bump amqp-common version to preview .5

Since we had to unpublish amqp-common preview.4 => Bumping version for amqp-common to preview .5 to prepare for next release

👍 LGTM
A bunch of formatting fixes got added in to this PR, do you think thats okay? I don't have a strong opinion either way.


douyin.com extractor broken, Fresh cookies are needed

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2021.12.27. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
global
Description
The douyin extractor is asking for cookies. I've only used this extractor once several months ago, and back then it didn't require cookies.
yt-dlp --cookies-from-browser firefox also results in error.
Tested without logging in, because I don't have an account.
Verbose log
yt-dlp -Uv https://www.douyin.com/video/7049695447815818504
[debug] Command-line config: ['-Uv', 'https://www.douyin.com/video/7049695447815818504']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2021.12.27 [6223f67a8] (zip)
[debug] Python version 3.9.5 (CPython 64bit) - Linux-5.11.0-44-generic-x86_64-with-glibc2.33
[debug] exe versions: ffmpeg 4.3.2-0, ffprobe 4.3.2-0, rtmpdump 2.4
[debug] Optional libraries: secretstorage, sqlite
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [Douyin] Extracting URL: https://www.douyin.com/video/7049695447815818504
[Douyin]<PHONE_NUMBER>815818504: Downloading video details
WARNING: [Douyin]<PHONE_NUMBER>815818504: Failed to parse JSON  (caused by JSONDecodeError('Expecting value: line 1 column 1 (char 0)')); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.; Retrying with webpage
[Douyin]<PHONE_NUMBER>815818504: Downloading webpage
ERROR: [Douyin]<PHONE_NUMBER>815818504: Fresh cookies (not necessarily logged in) are needed; please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.; please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 599, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/tiktok.py", line 680, in _real_extract
    raise ExtractorError('Fresh cookies (not necessarily logged in) are needed')

I believe this has been fixed along with tiktok. Right, @MinePlayersPE

Sorry I don't really use Github that much, I see this is marked resolved but I don't see a fix? Did you find out what's wrong?

you need to solve the puzzle piece captcha on the site and then pass your browser cookies to yt-dlp

Still unable to download, even with the attached cookies of being logged in (or not logged in).

Still unable to download, even with the attached cookies of being logged in (or not logged in).

Make sure the link is compatible and create a new issue

@jidasheng @gohoski it's already being tracked in #9667


Support vanilla-extract

Is your feature request related to a problem? Please describe.
vanilla-extract just got nominated in "The most exciting use of technology" category in Javascript Open Source Awards (similar to Jest Preview). It would be super cool to have Jest Preview support vanilla-extract out of the box
Describe the solution you'd like
Support out of the box
Describe how should jest-preview implements this feature
Not sure yet

Hi, relaunching this subject, did someone managed to make it work with Vanilla Extract ?


Fix mpi macos

disable MPI installation

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


what is the detail of limitations of second "dataset's distribution"

what is the actual limitation?

Hi,
The limitation is that our model cannot generate out-of-distribution results, even if such input is given. Fig 16 in our arXiv paper is an example.

thanks. If there is no 'green cat' in dataset, than your model can't make '3d green cat?'. Or, your model trains about one class in one time?(ex: if your model trains about AFHQ, your model cannot generate about all the class in AFHQ in once?)
Also, the reason why your model cannot generate is because of EG3D?
Thank you for your comment

If there is no 'green cat' in the training set, our model won't be able to generate it. Yes, I think it is a limitation for most of the GAN-based methods.


False "Code is unreachable" warning on else of isinstance()

Environment data

Pylance version: Pylance v2024.7.104 (pre-release) and non-pre-release version
OS and version: Windows 11 Pro 23H2
Python version (& distribution if applicable, e.g. Anaconda): Python 3.12.4
Visual Studio Code: Version 1.90.0

Code Snippet

def f(v: str|int|bool = None) -> str | None:
    if v == True:
        print("v is True")
    elif isinstance(v, (str, int)):
        print("v is a str or int")
    else:
        print("v is False")

f(False)

Repro Steps

Warning / lowlighting for the line: print("v is False")

Pylance is behaving correctly here. bool is a subclass of int and therefore all bool values are also int values, so isinstance(v, (str, int)) returns True for bool values.
If you run the sample code that you provided above, the output of f for the f(False) call is "v is a str or int", confirming this.
 If you set python.analysis.typeCheckingMode to something other than "off" (ex. "basic"), you'll see an error reported with your code. The default value None of the parameter v is not assignable to the v as it is annotated becuase None is not str | int | bool. You may want to change the annotation to str | int | bool | None.

Thanks. I could have sworn I was getting the output "v is False". I'll have
to find the problem code again and see what's different.
Meanwhile, do appreciate your time.
Thanks,
Leon
On Wed, Aug 7, 2024 at 11:56 AM Erik De Bonte @.***>
wrote:

Closed #6239 https://github.com/microsoft/pylance-release/issues/6239
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/pylance-release/issues/6239#event-13794657296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJBNRALOYPFUYSFCPM7RNTZQI7RXAVCNFSM6AAAAABMD2BCKWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG44TINRVG4ZDSNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Best regards,
Leon Stankowski
610-909-6140


Flickering while switching  between dark mode theme.

I'm having 2 versions of dark mode theme and when I switch between them, the screen flickers.
Do we have any fixes so far?
https://user-images.githubusercontent.com/56602090/119228634-7d01e580-bb31-11eb-97e4-33e2c3241a2c.mov

Thanks to @elis we have a fix on this issue. I have published version 0.3.0. Check it out!


Fix mesh expansion, add the v2 ports

Fixes https://github.com/istio/istio/issues/5271
15011 is MTLS only - similar with the v1 config.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
Assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
Assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
616c3581351a3bae4be059987648a3391d7c5c83
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Config changes to ILB - tests are broken in post-submit and not related, force-merge.


New HydroShare account request with pre-existing user name needs more descriptive error message

When going to main HydroShare landing page to sign-up for new account, if details are entered such that new user requests a user name that is already taken, the error message is simply: Account cannot be created.
This error message should be more descriptive additionally stating that the user name is already taken.

Fix pushed to github and a pull request has been created to have it merged into release-candidate-1.4.0 branch.

It is working and ready for testing on alpha.

The fix to this issue is already included in release 1.4, and ready for testing on beta.

Tested in alpha.


Question about joint training

I'm trying to implement joint training of PaperEdge. Although PaperEdge's Supplementary Material mentions joint training did get further improvement, in my opinion, end-to-end training is more practical from a practical application point of view.
I would appreciate it if the author could share more about joint training(e.g., advantages/disadvantages/changes to the training process).
One disadvantages I can think of(still implementing code to verify my idea) is: In the joint training netG has not yet converged and the prediction(dg) is incorrect, resulting in a complete failure of netL to converge
x, y = doc3d_aug(im, fm, bm, bg)
dg = netG(x) # netG is training mode
dg = warpUtil.global_post_warp(dg, 64)
gs = F.interpolate(dg, 256, mode='bilinear', align_corners=True)
xg = F.grid_sample(x, gs.permute(0, 2, 3, 1), align_corners=True)
xd = netL(xg)
loss, _ = spvLoss.lloss(xd, y, dg)

Good question. I did not thoroughly investigate the join training as it violates the basic modeling of the proposed method.
One reason I used a two step method here is to divide a challenging task (estimate the full deformation field) into two simpler tasks (predict the boundary deformation and predict the texture deformation). This is a divide and conquer methodology (tho not recursive).
The case you mentioned is one possible reason. Think about another scenario that ENet works perfectly estimating the edge deformation and Tnet is still under training, if we train Enet and Tnet jointly, the loss from Tnet will propagate to Enet and force Enet to update its parameters. It does not make sense to penalize Enet due to the error in Tnet in the current setting.
I agreed you might get better results with jointly training after some tweaks...but you need to investigate what really happened.
One of the reasons I did not get obvious improvement is these lines:
https://github.com/cvlab-stonybrook/PaperEdge/blob/main/networks/paperedge.py#L219-L222
That is, the deformation field boundaries won't propagate grad back to Enet (tho Enet still got some grad from the interpolated field). If you want to investigate more, you may want to disable this part.


#16433 Split server output based on its severity

Acceptance criteria:

[x] Server output has different severities in PostgreSQL only, as of now
[x] Find/Replace works in the current output viewer
[x] SQL Terminal works as before

Sample query:
do $$
begin
	RAISE debug 'debug';
	RAISE log 'log';
	RAISE info 'info';
	RAISE notice 'notice';
	RAISE warning 'warning';
end $$;

verified

The output panel doesn't work if it is shown in  result tab
https://user-images.githubusercontent.com/31996417/213215836-6ff1e2a0-bdb1-4f13-b5b5-694c81679de2.mp4


Text expressions can't have the dash charachter (-) in their name or value returns NaN

I don't know if this is intended behaviour or not, but I thought I'd let you know.
I created this project using create-nue with node.
This code Returns ( Text: NaN ) in the button element:
components.nue:
<!-- test-button -->
<button @name="test-button">
  text: {button-text}
</button>

layout.nue:
<html>
  <meta charset="utf-8">
  <test-button button-text="it worked" />
  <script type="module" src="setup.js"></script>
</html>

While this code returns ( text: it worked ) as expected:
components.nue:
<!-- test-button -->
<button @name="test-button">
  text: {buttontext}
</button>

layout.nue:
<html>
  <meta charset="utf-8">
  <test-button buttontext="it worked" />
  <script type="module" src="setup.js"></script>
</html>

The usage of {button-text} makes it impossible to tell if it is an expression button minus text or a variable button-text.
Is there a good way to tell the difference? @Korab-Doroci @tipiirai

This is expected behaviour. Think expressions like function bodies that must return a value. ´{button-text}` translates to:
function(self) {
  return self.button - self.text
}

Where self is the component instance. buttontext is a variable name and works in your case.

Thank you for clarifying!


Why did you chose the Zarr format?

Hi,
I'm writing data loader for loading GRIB weather data and found this project while browsing github. I'm currently considering what format to use in the dataloader. I hope you have time to explain some of your design choices? I need to download data in GRIB format from either ECMWF, GFS or HRRR and store it in a format that ca be used for ML.
For the dataloader I experimented with storing the data as:

uncompressed npy arrays  ( very fast to load, but very big. 10x the size of GRIB)
compressed npy arrays  (~4x bigger than GRIB but faster to load)
Zarr format (Very big files )
GRIB files split into a single file per field. (highly compressed but requires a lot of cpu's to decompress)

Zarr is easy to load and compatible with Xarray but was also way bigger than the original grib files?
Currently I'm leaning towards storing the data as an individual GRIB files for each field because it requires the least amount of diskspace. Maybe you could shed some light on why you choose the Zarr format?
Is it because it's fast to load or is it to stay compatible with WeatherBench2?

Because that format fits our need to run 100 epochs over multi-terabytes datasets for training a weather forecasting model. Each chunk is on date/time will all the variables. Our datasets range between 7TB and 70TB.


How can I find System.Windows.Documents.dll ?

Idea Title
Be as descriptive as you can with your idea/bug report/question/suggestion.
Issue Details
Add a detailed explanation of what is wrong or what you want implemented. If reporting a bug on an existing page, make sure to include a link.

I have installed Framework 4.7.2. but I cannot find the reference System.Windows.Documents in reference Manager.

@jesus10005 Can you try this page: https://docs.microsoft.com/en-us/dotnet/api/system.windows.documents?view=netframework-4.7.2


Remove additional -U for apk in Dockerfile

There is no need to use -U with --no-cache when using apk on Alpine Linux, as using --no-cache will fetch the index every time and leave no local cache, so the index will always be the latest, without temporary files remain in the image.

Sent to the wrong repo.


TLS support in client

I have a server (implemented in golang) that requires clients to connect with TLS.
So I've tried to implement TLS support in grpc-rust, which, in theory, should be relatively easy: grpc works over standard HTTP2 + tls. For now, I don't need any cert validation, I just want some security over the wire.
However, I got stuck and I think I need some help/explaining.
I was hoping I could just propagate different value of http_scheme to solicit and it will do everything for me. So far I've managed to add http_scheme param to GrpcClient::new and propagate it to HttpClientConnectionAsync. But then it looks like you are doing handshake manually in solicit_async.rs and it's just static string, and you are doing most of the http-related stuff semi-manually.
Can you give me some advice here? Should I try to replace client_handshake with something provided by solicit? Or, maybe I should look at tokio_tls and pass it instead of TcpStream?

Should I try to replace client_handshake with something provided by solicit?

No, because solicit only supports synchronous API.

Or, maybe I should look at tokio_tls and pass it instead of TcpStream?

Yes, I think that would work (although it will require significant amount of changes in grpc-rust).
Or you can wait till I implement it myself (I'm planning to do it, but currently I'm busy implementing better protobuf 3 support in rust-protobuf).

Added client code: 12e1059c98872c97c62fb062357195534bd70e71, but haven't tested it. It won't work likely.
See also https://github.com/tokio-rs/tokio-tls/issues/6

Should work now.


Update README.md

Thanks for the PR! Can you add a bit more information so we can document in this PR our source. Are you on a team that is using Bazel with scale at IBM? Can you describe the project? Is there are more specific URL for the project we can add than ibm.com?
Thanks again!

Any update here? I'd love to merge this, but would like to have a bit more information and better link.

My Squad lead is not commenting on this PR, You can close it.

If anything changes and you have more details to share later please feel free to open another PR!


Enhancement: Support dependency definitions in css

In stylesheet files, define which stylesheets need to load before the current stylesheet.
//view.css
@require "../button.css"; // states that button.css needs to load before view.css. This is a no-op, CSS is not modified.

.button {
    background: red;
}

This is inspired by a feature in closure stylesheets. I'm not sure if this is a style-loader feature or css-loader feature, or both.
Thanks for your consideration (and all the awesome work you do and have done).
This is a related to issue #17, which suggests adding a "priority" option.

Upon further evaluation, I don't know why this would be necessary except perhaps for dynamically loaded modules. I'm not sure this would be sufficient in this case.


CSGO Update Sep 08 - Bypass Error

2020-09-08 20:21:52,908 - pymem - DEBUG - Process 2028 is being debugged
Traceback (most recent call last):
File "OneByteLdr.py", line 12, in
AttributeError: 'NoneType' object has no attribute 'start'
[11032] Failed to execute script OneByteLdr
Regards

This is happening because of the latest game update. You'll have to wait for Daniel to release updated patterns,

just change the first byte 1A to 1B in line 12

just change the first byte 1A to 1B in line 12

Love you, man!
Thanks!
How can I know what data to change for a future update?
I don't like to bother and I would like to learn

Updated

https://github.com/batininhani/RevokeAlldr/ Have a look! :)


Support of v3.0

:)
We should create different branches for 2.6 and v3.0 nebula graph

#16  Before merging 3.0, we need a 2.0 tag @shyboylpf

I've taged for 2.6.0 & 3.0.0.
Please let me know if any question.


Added callChangeListener() missing from SpectrumPreference class

The call to callChangeListener() was missing from the non-compat version of SpectrumPreference. This code change adds it in.

@nwalters512
This is minor-ish, but I personally require it. So imagine others will too.

Thanks for the PR, sorry it took so long to review it. LGTM!


mount,dev: add support for /dev/kvm

This device is safe for unprivileged access, and is almost a must-have for running virtual machines with any reasonable performance.

Looks good.


Optimize tomcat-embed-core footprint

tomcat-embed-programmatic is an experimental Tomcat dependency designed to lower the memory footprint, but it seems possible to reach similar or even lower footprint with the default tomcat-embed-core with a refined native configuration and an additional substitution.
My analysis tends to show that unused protocols are the main source of inefficiency, and more generally optional features should probably be removed from default Tomcat native configuration. As a consequence, I propose to modify tomcat-reflection.json as following:

Move DefaultServlet entry to a new tomcat-reflection-default-servlet.json file
Move Http11Nio2Protocol entry to a new tomcat-reflection-nio2.json file
Move Http11AprProtocol & AprEndpoint entries to a new tomcat-reflection-apr.json file
Move OpenSSLImplementation, SSLHostConfig, SSLHostConfigCertificate, OpenSSLConf, AbstractJsseEndpoint entries to a new tomcat-reflection-ssl.json file
Add a { "name":"org.apache.coyote.AbstractProtocol", "methods" : [{"name": "setPort","parameterTypes":["int"] }] } entry (mandatory and previously covered as a side effect by Http11AprProtocol entry)

Those optional feature could then be enabled by users on demand with Args = -H:ReflectionConfigurationResources=/META-INF/native-image/org.apache.tomcat.embed/tomcat-embed-core/tomcat-reflection-nio2.json for example in a /META-INF/native-image/native-image.properties file. This principle is already use for tomcat-jni.json which is not included by default.
This will require on Spring side the following substitution because Tomcat ProtocolHandler completly defeats GraalVM static analysis:
@TargetClass(className = "org.apache.coyote.ProtocolHandler", onlyWith = { OnlyIfPresent.class })
final class Target_ProtocolHandler {

	@Substitute
	public static ProtocolHandler create(String protocol, boolean apr)
			throws ClassNotFoundException, InstantiationException, IllegalAccessException,
			IllegalArgumentException, InvocationTargetException, NoSuchMethodException, SecurityException {
		return new org.apache.coyote.http11.Http11NioProtocol();
	}
}

Notice that we can't move forward without a Tomcat update because --exclude-config in native-image.properties is likely broken, see also this NBT issue.
Unrelated, but likely worth to fix, org.apache.tomcat.util.threads.res.LocalStrings should probably be removed from tomcat-resource.json since there is an error message saying it does not exists.
@fhanik Could you please provide your feedback on the proposed changes, and if it is possible to perform them on Tomcat 9 branch or if we will have to wait Tomcat 10.1?

@sdeleuze I've spent some time on this, and I agree with the general direction. I think it's important to capture what has taken place. Here is a review (all using the same tomcat binaries built with Java 8 sha 338d05d
Graal 19.2 / Java 8
Jar File | RSS Memory | Image Size | Build Time | Build Memory
progr:   | 17.9M     | 16.8M       | 24s        | ???G
core :   | 20.8M     | 21.8M       | 30s        | ???G

GraalVM Version 19.2.1 CE
OpenJDK 64-Bit GraalVM CE 19.2.1 (build 25.232-b07-jvmci-19.2-b03, mixed mode)

Graal 19.3 / Java 8
Jar File | RSS Memory | Image Size | Build Time | Build Memory
progr:   | 18.0M     | 17.6M       | 26s        | ???G
core :   | 21.0M     | 23.0M       | 33s        | ???G

GraalVM Version 19.3.1 CE
OpenJDK 64-Bit GraalVM CE 19.3.1 (build 25.242-b06-jvmci-19.3-b07, mixed mode)

Graal 19.3 / Java 11
Jar File | RSS Memory | Image Size | Build Time | Build Memory
progr:   | 20.6M     | 21.6M       | 32s        | ???G
core :   | 23.8M     | 27.2M       | 36s        | ???G

GraalVM Version 19.3.1 CE
OpenJDK 64-Bit Server VM GraalVM CE 19.3.1 (build 11.0.6+9-jvmci-19.3-b07, mixed mode, sharing)

Graal 20.2 / Java 11
Jar File | RSS Memory | Image Size | Build Time | Build Memory
progr:   | 24.4M     | 31.3M       | 38s        | 5.5G
core :   | 27.0M     | 36.6M       | 44s        | 5.8G

GraalVM Version 20.2.0 (Java Version 11.0.8)
OpenJDK 64-Bit Server VM GraalVM CE 20.2.0 (build 11.0.8+10-jvmci-20.2-b03, mixed mode, sharing)

Graal 21.3 / Java 11
Jar File | RSS Memory | Image Size | Build Time | Build Memory
progr:   | 30.2M     | 25.0M       | 25s        | 4.4G
core :   | 36.2M     | 40.3M       | 38s        | 6.4G

GraalVM 21.3.0 Java 11 CE (Java Version 11.0.13+7-jvmci-21.3-b05)
OpenJDK 64-Bit Server VM GraalVM CE 21.3.0 (build 11.0.13+7-jvmci-21.3-b05, mixed mode, sharing)

The path forward that I believe can start on is

Remove tomcat-embed-programmatic, it seems we can achieve this with graal precompiler solutions
Clean up tomcat-embed-xxx graal json files
Start working on @Substitute optimization (these should then be contributed to a JAR file called tomcat-embed-graal for Tomcat 10.1 while we can develop them inside of Spring native for Tomcat 9)

How can we move forward on it, could you work on Tomcat fork with the JSON refinements I proposed in the issue description?
Are JSON refinements ok to be pushed on Tomcat 9 (this will likely break some native users) or should that be 10.1 only?
About the figures, Java 8 to Java 11 RSS memory increase is well know, but I am surprised by the RSS increase on latest versions. Maybe something we want to analyze more closely.

For protocols, we may be able to use conditional configuration and just rely on the framework level subtitution to trigger or not the config.
Something like:
{
   "condition" : { "typeReachable" : "org.apache.coyote.http11.Http11Nio2Protocol" },
   "name":"org.apache.coyote.http11.Http11Nio2Protocol",
   "methods" : [{"name": "<init>","parameterTypes":[]}]
},

Not sure, but something to test (I don't remember why those reflection entries are needed if ProtocolHandler create the instances programmatically).

Ok so after a meeting with @fhanik and GraalVM team, we agreed on the following path:

Introduce an utility class in Tomcat designed like Spring Framework NativeDetector (source code) to provide system properties based boolean methods, for example:

public abstract class TomcatFeatureDetector {

	private static final boolean HTTP_11_NIO_PROTOCOL = (System.getProperty("tomcat.http11.nio.protocol") != null);

	private static final boolean HTTP_11_APR_PROTOCOL = (System.getProperty("tomcat.http11.apr.protocol") != null);

	public static boolean isHttp11NioProtocolEnabled() {
		return HTTP_11_NIO_PROTOCOL;
	}

	public static boolean isHttp11AprProtocolEnabled() {
		return HTTP_11_APR_PROTOCOL;
	}

}

Initialize this class at build time by shipping a /META-INF/native-image/{groupId}/{artifactId}/native-image.properties file with something like:

Args = --initialize-at-build-time=my.tomcat.package.TomcatFeatureDetector

Modify ProtocolHandler#create (and other use cases) to something like:

public static ProtocolHandler create(String protocol, boolean apr)
            throws ClassNotFoundException, InstantiationException, IllegalAccessException,
            IllegalArgumentException, InvocationTargetException, NoSuchMethodException, SecurityException {
        if (protocol == null || "HTTP/1.1".equals(protocol)
                || (!apr && org.apache.coyote.http11.Http11NioProtocol.class.getName().equals(protocol))
                || (apr && org.apache.coyote.http11.Http11AprProtocol.class.getName().equals(protocol))) {
            if (apr && TomcatFeatureDetector.isHttp11AprProtocolEnabled()) {
                return new org.apache.coyote.http11.Http11AprProtocol();
            } else if (TomcatFeatureDetector.isHttp11NioProtocolEnabled()) {
                return new org.apache.coyote.http11.Http11NioProtocol();
            }
        ...
        } else {
            // Instantiate protocol handler
            Class<?> clazz = Class.forName(protocol);
            return (ProtocolHandler) clazz.getConstructor().newInstance();
        }
    }

Tomcat documentaton is updated to mention the system properties to use to control the removal of features at build time (and Spring Boot uses that).

@gradinac provides a documentation to explain how to use GraalVM 22.1 nightlies to generate automatically the reflection configuration automatically based on running the unit tests, and @fhanik create locally a modified Tomcat that uses Gradle or Maven to run the unit tests on native via https://github.com/graalvm/native-build-tools. The generated configuration with conditional configuration could then be shipped with Tomcat.

@fhanik Any update?

tomcat-embed-programmatic
Packaging webmvc-tomcat with Maven (native)
SUCCESS
Testing webmvc-tomcat
SUCCESS
Build memory: 7.07GB
Image build time: 49.3s
RSS memory: 67.3M
Image size: 54.1M
Startup time: 0.029 (JVM running for 0.03)
Lines of reflective config: 2487

tomcat-embed-core
=== Building webmvc-tomcat sample ===
Packaging webmvc-tomcat with Maven (native)
SUCCESS
Testing webmvc-tomcat
SUCCESS
Build memory: 7.80GB
Image build time: 49.0s
RSS memory: 69.4M
Image size: 58.9M
Startup time: 0.027 (JVM running for 0.028)
Lines of reflective config: 2487

There is a diminishing rate of return here.
I'm currently working on the reflection files, but I won't go into separation and optimization if it truly doesn't yield more than 2.1MB in a Spring MVC application. Strangely, the difference between the two JAR files is 6MB in a Hello World style Apache Tomcat application.

How far is this in context for spring boot and spring-boot-starter-web when using profile native? Will i get out of the box a smart decision?
What is about this number crunching when i use the dep spring-cloud-function-web?

When you use Spring Boot 3 and starter-web, you'll not get the tomcat-embed-core. It uses the default Tomcat. But you can switch to tomcat-embed-core if you want, it's documented in the wiki.

Notice Tomcat 8.0.3 will ship 1.5M less resources after this optimization I contirbuted. I plan to send other PRs to the Tomcat project to make tomcat-embed-programmatic non experimental anymore since it will probably be the best way to implement more aggressive optimizations.