Added specifying ordinal hash tag positions

if the start hash tag character is the same as the end hash tag character, only the first hash tag will be used
hash_tag: __
1_2_3_4 -> 2

Applying ordinal hash tag positions, you can get the nth hash tag if multiple hash tags exist, reverts to whole key if nth hash tag is not found
hash_tag: __
hash_tag_pos: 2
1_2_3_4 -> 3

hash_tag:__
hash_tag_pos: 2
1_2_3 -> 1_2_3

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding base

#1

Sample report
Test report

Run start date: 6.07.2021, 19:23:52

Duration: 32s

Tests run stats

📚 total tests: 7
✔ passed: 3
❌ failed: 3
🔜 skipped: 1
⚠ skipped by Cypress: 0
❇ other: 0

Failed tests

Click to reveal

💢 Path: cypress/integration/[T02] Local Tests/removeFixture.spec.js, test: One
💢 Path: cypress/integration/[T01] Outside Tests/removeFixture.spec.js, test: Four
💢 Path: cypress/integration/[T01] Outside Tests/removeFixture.spec.js, test: Five

Skipped tests

Click to reveal

🔜 Path: cypress/integration/[T01] Outside Tests/removeFixture.spec.js, test: Six

Skipped tests by Cypress

Click to reveal


Can't see the icon in the panel and even in the Alt + Tab on Linux Mint.

Hi again! I encountered this issue. It is not that important but still, some people might get annoyed with this on Linux.

On the right side, Mechvibes is open but the icon isn't visible
OS => Linux Mint 19.3 Cinnamon

Never seen this problem before because I only use Windows for daily work. I will install some Linux distros to test it and let you know soon

Hi,
Encountered this issue recently while trying out the app.
Here's the solution that I found (works on GNOME, idk about Cinnamon)
Mechvibes puts it icons into the wrong directory (0x0 instead of 48x48) .
The correct directory is /usr/share/icons/hicolor/48x48/apps.
So, just copy the icon into the correct directory
sudo cp /usr/share/icons/hicolor/0x0/apps/mechvibes.png /usr/share/icons/hicolor/48x48/apps/mechvibes.png
Then, update your icon-caches using :
sudo update-icon-caches /usr/share/icons/*
The icon should be visible now.
P.S.
The app icon is of size 512*512 .
You may resize it if you want but it works either way.


Add a wrapper for utimes(2)

PR #944 added wrappers for the more-modern futimens(2) and utimesat(2),
but unfortunately these APIs are not available on old-ish systems.
In particular, macOS Sierra and below don't implement them, making the
new APIs unusable.  Whether we should care about such "old" systems is
debatable, but the problem is that, at the moment, this is the only
macOS version usable on Travis to test kexts and, thus, to test FUSE
file systems.

ping!

pong!
bors r+


fix(reduce/scan): both scan/reduce operators now accepts undefined itself as a valid seed

Array#reduce supports undefined as a valid seed value, so we should too.
of(1, 2, 3).reduce((acc, x) => acc + ' ' + x, undefined);
// "undefined 1 2 3"

of(1, 2, 3).scan((acc, x) => acc + ' ' + x, undefined);
// "undefined 1"
// "undefined 1 2"
// "undefined 1 2 3"

fixes #2047
Cc/ @blesh

Coverage remained the same at 97.041% when pulling 12a2701ca31358e508f086367474425e7216ecd5 on jayphelps:scan-seed into 5460e7773d18f3e8c61ec09498121d837be3c2f5 on ReactiveX:master.

Coverage increased (+0.0009%) to 97.041% when pulling a34a76d568294c75036db5b8dc7973e086115148 on jayphelps:scan-seed into 5460e7773d18f3e8c61ec09498121d837be3c2f5 on ReactiveX:master.

Implementation side it looks fine, just need to clarify if this is expected behavior. (for me it seems legit to align with native)

@jayphelps @kwonoj I've always wondered, why do we use a getter/setter for the seed value? Is it faster?

I'm betting there is no reason other than that's what the person who wrote it used.

I'm betting there is no reason other than that's what the person who wrote it used.

: Pretty much this case. Using getter / setter in this codebase is mostly depends on preference / chocies of writer. At least it does not gives any perf or so.

LGTM, we need to be careful as undefined is as valid a value as null in terms of initial values, such as startWith etc.  And Function.prototype.bind doesn't change the number of parameters in the end going to the function, so we're fine with checking the param count.

Coverage increased (+0.0009%) to 97.041% when pulling 34e2e4fa16956a23fabd85470a718fb2cd9db011 on jayphelps:scan-seed into 8ebee66e00156b3bc933370518526a2ecaa4f6c9 on ReactiveX:master.

Coverage increased (+0.0009%) to 97.041% when pulling<PHONE_NUMBER>fce38d4c743b620e824e9dd97becad on jayphelps:scan-seed into ece1b89f1b2e067d3ff9faec192ff5fd5a5681e6 on ReactiveX:master.

Coverage increased (+0.0008%) to 97.217% when pulling 0df3dc994146c72be0656576b33488ce5375b510 on jayphelps:scan-seed into fea08e965dd4ad82dfe1eab2865eb48908fc564c on ReactiveX:master.

Approved during our core meeting. I don't like to self-merge, but I was tasked to merge all the approved PRs so #YOLO


reddit proof not working

My reddit proof is not working. I have re-posted it several times and every time it fails.
https://www.reddit.com/r/KeybaseProofs/comments/9crvvh/my_keybase_proof_redditmjhutchinson_keybasemhutch/

Did you tried the solution suggested in #12584 ? It helped me fix the issue.

Tried it and the Reddit submission form was blank

This is still failing no matter what you do.

WAF ... how did he do it?
On Fri, May 6, 4 Reiwa at 2:30 PM Duane King @.***>
wrote:

This is still failing no matter what you do.
—
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/13675#issuecomment-1120090355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APXLM3LEUWRJ2D32LVBUKZ3VIW2TDANCNFSM4FUITH7Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Dari

No idea.  On Windows it always fails to validate and is red, but on my iPhone the app shows the same item as validated and good in green.

App issues


Added sshkeys for chirag

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


unmatched in NDS query78

Parameters:
scala_factor=5
parallel=10
transcode with iceberg(parquet)
power run with iceberg
Detail message:
=== Comparing Query: query78 ===
Collected 100 rows in 0.19057893753051758 seconds
Row 7:
[255, 2.03, 81, Decimal('58.95'), Decimal('4.66'), 40, Decimal('63.34'), Decimal('1.36')]
[255, 2.02, 81, Decimal('58.95'), Decimal('4.66'), 40, Decimal('63.34'), Decimal('1.36')]
Processed 100 rows
There were 1 errors
Collected 100 rows in 0.1670541763305664 seconds
Processed 100 rows
Results match
=== Unmatch Queries: ['query78'] ===
Query 78 in stream:
-- start query 26 in stream 1 using template query78.tpl
with ws as
(select d_year AS ws_sold_year, ws_item_sk,
ws_bill_customer_sk ws_customer_sk,
sum(ws_quantity) ws_qty,
sum(ws_wholesale_cost) ws_wc,
sum(ws_sales_price) ws_sp
from web_sales
left join web_returns on wr_order_number=ws_order_number and ws_item_sk=wr_item_sk
join date_dim on ws_sold_date_sk = d_date_sk
where wr_order_number is null
group by d_year, ws_item_sk, ws_bill_customer_sk
),
cs as
(select d_year AS cs_sold_year, cs_item_sk,
cs_bill_customer_sk cs_customer_sk,
sum(cs_quantity) cs_qty,
sum(cs_wholesale_cost) cs_wc,
sum(cs_sales_price) cs_sp
from catalog_sales
left join catalog_returns on cr_order_number=cs_order_number and cs_item_sk=cr_item_sk
join date_dim on cs_sold_date_sk = d_date_sk
where cr_order_number is null
group by d_year, cs_item_sk, cs_bill_customer_sk
),
ss as
(select d_year AS ss_sold_year, ss_item_sk,
ss_customer_sk,
sum(ss_quantity) ss_qty,
sum(ss_wholesale_cost) ss_wc,
sum(ss_sales_price) ss_sp
from store_sales
left join store_returns on sr_ticket_number=ss_ticket_number and ss_item_sk=sr_item_sk
join date_dim on ss_sold_date_sk = d_date_sk
where sr_ticket_number is null
group by d_year, ss_item_sk, ss_customer_sk
)
select
ss_item_sk,
round(ss_qty/(coalesce(ws_qty,0)+coalesce(cs_qty,0)),2) ratio,
ss_qty store_qty, ss_wc store_wholesale_cost, ss_sp store_sales_price,
coalesce(ws_qty,0)+coalesce(cs_qty,0) other_chan_qty,
coalesce(ws_wc,0)+coalesce(cs_wc,0) other_chan_wholesale_cost,
coalesce(ws_sp,0)+coalesce(cs_sp,0) other_chan_sales_price
from ss
left join ws on (ws_sold_year=ss_sold_year and ws_item_sk=ss_item_sk and ws_customer_sk=ss_customer_sk)
left join cs on (cs_sold_year=ss_sold_year and cs_item_sk=ss_item_sk and cs_customer_sk=ss_customer_sk)
where (coalesce(ws_qty,0)>0 or coalesce(cs_qty, 0)>0) and ss_sold_year=2001
order by
ss_item_sk,
ss_qty desc, ss_wc desc, ss_sp desc,
other_chan_qty,
other_chan_wholesale_cost,
other_chan_sales_price,
ratio
LIMIT 100;
-- end query 26 in stream 1 using template query78.tpl

It is possible that q78 will select inconsistent column, see
./query_0.sql-    sum(ss_wholesale_cost) ss_wc,
./query_0.sql-    sum(ss_sales_price) ss_sp
./query_0.sql-   from store_sales
./query_0.sql-   left join store_returns on sr_ticket_number=ss_ticket_number and ss_item_sk=sr_item_sk
./query_0.sql-   join date_dim on ss_sold_date_sk = d_date_sk
./query_0.sql-   where sr_ticket_number is null
./query_0.sql-   group by d_year, ss_item_sk, ss_customer_sk
./query_0.sql-   )
./query_0.sql- select
./query_0.sql-ss_customer_sk,
./query_0.sql:round(ss_qty/(coalesce(ws_qty,0)+coalesce(cs_qty,0)),2) ratio,
./query_0.sql-ss_qty store_qty, ss_wc store_wholesale_cost, ss_sp store_sales_price,
./query_0.sql-coalesce(ws_qty,0)+coalesce(cs_qty,0) other_chan_qty,
./query_0.sql-coalesce(ws_wc,0)+coalesce(cs_wc,0) other_chan_wholesale_cost,
./query_0.sql-coalesce(ws_sp,0)+coalesce(cs_sp,0) other_chan_sales_price
./query_0.sql-from ss
./query_0.sql-left join ws on (ws_sold_year=ss_sold_year and ws_item_sk=ss_item_sk and ws_customer_sk=ss_customer_sk)
./query_0.sql-left join cs on (cs_sold_year=ss_sold_year and cs_item_sk=ss_item_sk and cs_customer_sk=ss_customer_sk)
./query_0.sql-where (coalesce(ws_qty,0)>0 or coalesce(cs_qty, 0)>0) and ss_sold_year=2001
./query_0.sql-order by
./query_0.sql-  ss_customer_sk,
--
./query_2.sql-    sum(ss_sales_price) ss_sp
./query_2.sql-   from store_sales
./query_2.sql-   left join store_returns on sr_ticket_number=ss_ticket_number and ss_item_sk=sr_item_sk
./query_2.sql-   join date_dim on ss_sold_date_sk = d_date_sk
./query_2.sql-   where sr_ticket_number is null
./query_2.sql-   group by d_year, ss_item_sk, ss_customer_sk
./query_2.sql-   )
./query_2.sql- select
./query_2.sql-ss_sold_year, ss_item_sk, ss_customer_sk,
./query_2.sql-ss_qty/(coalesce(ws_qty,0)+coalesce(cs_qty,0)) before_round,
./query_2.sql:round(ss_qty/(coalesce(ws_qty,0)+coalesce(cs_qty,0)),2) ratio,
./query_2.sql-ss_qty store_qty, ss_wc store_wholesale_cost, ss_sp store_sales_price,
./query_2.sql-coalesce(ws_qty,0)+coalesce(cs_qty,0) other_chan_qty,
./query_2.sql-coalesce(ws_wc,0)+coalesce(cs_wc,0) other_chan_wholesale_cost,
./query_2.sql-coalesce(ws_sp,0)+coalesce(cs_sp,0) other_chan_sales_price
./query_2.sql-from ss
./query_2.sql-left join ws on (ws_sold_year=ss_sold_year and ws_item_sk=ss_item_sk and ws_customer_sk=ss_customer_sk)
./query_2.sql-left join cs on (cs_sold_year=ss_sold_year and cs_item_sk=ss_item_sk and cs_customer_sk=ss_customer_sk)
./query_2.sql-where (coalesce(ws_qty,0)>0 or coalesce(cs_qty, 0)>0) and ss_sold_year=2000
./query_2.sql-order by
./query_2.sql-  ss_sold_year, ss_item_sk, ss_customer_sk,

both 2nd and 4th column are possible for the round problematic column.

I will post a PR to fix this issue soon.


Possibility to save list of charts to bitmap file.

resolves #177

This might be related to Issue #1
https://github.com/timmolter/XChart/issues/1
I'll take a closer look soon.

Yes indeed, thank you for taking look for this :)

Thanks! Really nice!


MdTooltip broke the app after beta.11

Bug, feature request, or proposal:
Bug: MdTooltip broke my app after upgrade to beta.11
What is the expected behavior?
Before beta.11 the usage of MdTooltip was working as expected.
What is the current behavior?
Do not display my cards and broke the app.
What are the steps to reproduce?
Just create a simple button with a tooltip like this:
<button md-button md-tooltip="just a test" >
  <md-icon>play_arrow</md-icon>
</button>

What is the use-case or motivation for changing an existing behavior?
Avoid this error.
Which versions of Angular, Material, OS, browsers are affected?
angular-cli: 1.0.0-beta.22-1
@angular: 2.2.3
@angular/material: 2.0.0-alpha.11-3
node: 6.5.0
os: darwin x64
Is there anything else we should know?
Here it goes a print screen of the error on Chrome console.

I have no idea what this error means, but if I remove the tooltip from the button everything works as expected.
Thank you.

@paulogr
<button md-button md-tooltip="just a test" >
  <md-icon>play_arrow</md-icon>
</button>

That code is working fine here. Are you sure your issue is based on md-tooltip? I don't think so.
Please provide a plunker example or nobody can ever reproduce your issue.
Your problem seems to be in PlaylistComponent at a different position.

The problem is, with the same template and component, when I remove the tooltip everything works fine again.
Do you have a configured plunker with angular2 + material2?
So I can try to reproduce the error.

@paulogr Before we do that, have you tried to remove @angular/material from node_modules and reinstall it new?

Yeah, I did that 3 times, remove the node_modules/@angular/material and reinstall again.
Same error.
The playlist component is very simple, just receive a list of playlists and display it.
`

{{playlist.title}}
{{playlist.description}}

play_arrow

playlist_add

favorite

`

@paulogr Can you copy your complete inline template of your PlaylistComponent? Maybe we can find an issue there.

I tried to do that but GH parse my HTML...
Again
`

{{playlist.title}}
{{playlist.description}}

play_arrow

playlist_add

favorite

`

{{playlist.title}}

{{playlist.description}}

          <button md-button>
            <md-icon>play_arrow</md-icon>
          </button>
          <button md-button (click)="schedule($event, playlist)">
            <md-icon>playlist_add</md-icon>
          </button>
          <button md-button (click)="schedule($event, playlist)">
            <md-icon>favorite</md-icon>
          </button>

    `

```

@paulogr I can't find any problem in your template.
Tooltips are working fine in my project and also on dev demo page:
https://material2-dev.firebaseapp.com/tooltip
But maybe there is a real problem I am not able to see, but I am not sure how to debug it without a reproducing plunker.

I don't see anything in Material that could be throwing this. @paulogr can you try changing this expression in your template [class.active]="isPlayingPlaylist[i] && isPlaying()" into this [class.active]="isPlayingPlaylist && isPlayingPlaylist[i] && isPlaying()"?

Thank you @dahaupt and @crisbeto for you help.
After some debugging and testing the md-tooltip in other section of my app finally I got an error message the shows me the I miss to include the hammerJS on my app.
Just included HammerJS on my app and don't get this error anymore.
That sai, now my question is...
Is this mandatory to use hammerJS now? Before beta.11 I never needed to include HammerJS and the docs said to include only if you are using md-slide-toggle or md-slider https://github.com/angular/material2/blob/master/GETTING_STARTED.md#additional-setup-for-md-slide-toggle-and-md-slider

I don't think it should. While it does use touch events, it just binds to the native ones and it also doesn't import Hammer. The only components that depend on it should be the slider and slide toggle.

Well, I'll close this issue now, and try to make a test with a plunker without hammerJS to see if the problem happens.
And @crisbeto do you have a plunker with angular + material configured? Do you know when I can find one?
Thank you.

Yes, there is one in the template when you're creating an issue. Here's the link  http://plnkr.co/edit/o077B6uEiiIgkC0S06dd

I also had the same issue with md-tooltip and Hammer.js being required for its usage.

@QuentinFchx is right, the longpress event depends on hammerJS. This is to match the spec of material design where longpress will trigger the tooltip for mobile and then hide the tooltip after some delay.
The docs should be updated to reflect that tooltip now requires hammerJS.


unknown tls.Config field 'Renegotiation' in struct literal

My code is the following:
package main

import (

    "github.com/Azure/azure-sdk-for-go/management"
)

func main() {
    client, err := management.ClientFromPublishSettingsFile("mysettings.publishsettings", "")
    if err != nil {
        panic(err)
    }
}

When I run go install, i get the following error message:
../Azure/azure-sdk-for-go/management/http.go:91: unknown tls.Config field 'Renegotiation' in struct literal

I am using go version go1.6.3 darwin/amd64
Am i doing something wrong?

upgrade to 1.7 fixed my issue.


导出json内容全部都是object

Describe the bug
社区版

To Reproduce
Steps to reproduce the behavior:
1.

pull the latest image to get the fixed version


Convert ICMP types selector from dropdown to checkbox list in fw_rule…

(See also PR #3139: dropdown boxes used for ICMP type selection, with this to go in a separate PR)
This converts the UI for firewall rules icmp types to checkboxes. It has a few benefits:

The dropdown list only showed up to about 4 items. Therefore when IP protocol was changed, it wasn't immediately obvious which (if any) items in the list were still set and which weren't, without manually scrolling the list, as ICMP types vary according to the selected IP Protocol.  With checkboxes it's immediately clear.

After changing IP protocol the dropdown box also often appeared scrolled/jumped to an apparently-arbitrary position (or changed appearance) because its contents had changed. Checkboxes don't cause this minor UI confusion.

Dropdown boxes used extra javascript to handle any/none and changes to selected items in the list. With the UI in this PR the code is much simplified.  For example we can skip repopulating the valid ICMP types on IP protocol change, and we don't need any on_change events related to ICMP type selection when a user selects or deselects a specific ICMP type vs. "any".

Code notes for this PR:

The form fields are a list of checkboxes, returned as an array $_POST['icmptype_selection']. This needs a small amount of conversion to and from string format (in $config) but that's trivial and the original code needed it too.

There is no need for an "any" option any more.  If you want a rule on ICMP it has to be on some or all ICMP types, so an empty icmptype selection is disallowed, and "select/deselect all" buttons are provided for ease instead of "any".  Probably more intuitive?

When IP protocol changes, the visibility of the various icmptype checkboxes is changed but the checkboxes remain otherwise unchanged. In all, this seems to work better and smoother. It also makes it easier to visually check that as the IP protocol is changed or when incorrect input is provided, the GUI handles it roughly as a user might expect without surprises.

Logically as ICMP types change according to the selected IP protocol, one can either (1) insert/delete so that the HTML contains those (and only those) icmp types valid for the selected IP protocol, or (2) show/hide the icmptype inputs depending on theiur validity, then filter the form data to exclude data from checkboxes we know would have been hidden due to the choice of IP protocol.In this PR I switched to the second approach instead. It gives much simpler code and a better result on the UI. For example, upon more than one change to the selected IP protocol, especially after select/deselect all, the UI still displays the intuitively expected result.  It also means that we don't need to trap all the on_change() events to handle a special "any" item or changes to icmptype selection, or to recreate/repopulate the input fields.

It needs something to reload the user selections of ICMP types after input_errors.
e.g. start with a rule like the attached - ICMP with a couple of type selected in the checkboxes. Edit the rule, change the IP address "<IP_ADDRESS>" to some invalid string and press Save. An input error is shown about the invalid IP address (good), but the ICMP types come back all checked.

I guess it will need similar to https://github.com/pfsense/pfsense/pull/3334 which sets the necessary format of ICMP types after "$pconfig = $_POST"

PR #3334 fixed it for me.   I've merged the few lines of code from there into this PR.  The variable needed renaming to $icmptype_selection otherwise it's the same added code and should fix the issue mentioned above.
As there were conflicts due to other PRs, it's worth a quick check to ensure that nothing went in (or got removed) other than the few lines intended.

@sbeaver-netgate - high praise indeed, which you might want to know, meant a lot to receive unexpectedly. The feedback both means a lot, and helps as I gradually move towards working on substantial chunks and functionality.

That giant wall of checkboxes is a huge step backward, IMO. Even formatted it takes up way too much space. How about using the control that @sbeaver-netgate came up with for the NCP list on OpenVPN clients and servers? It would move the selected types to a separate box to make it more obvious which ones are selected.

That's a nice idea. The "selectable/selected" style of lists? Hadn't thought of that. It would also solve the UI issues of a single multi select dropdown, too. I'll knock up a PR for that in  the next few days to compare and see what reviewers think

As an aside, maybe @sbeaver-netgate (or anyone else) could convert that ad-hoc code into a bootstrap class that creates a "choose from list A and add/remove from list B" form element, as this is probably something the GUI could use fairly widely with benefit if done?

Now done the control as suggested by @jim-p, see PR #3479.
It does indeed look better, good call!

Close in favor of #3479


 attribute height: A negative value is not valid

Likely related to the graph chart, because there are too many items/nodes to draw.
Example: #3b
 attribute height: A negative value is not valid
jsapi_compiled_ui_module.js:81
Error:  attribute height: A negative value is not valid. ("-0.000021779614504552077")

merged to #121


How to use the angular google maps in the feature module rather than inserting them at root

Issue description
Steps to reproduce and a minimal demo of the problem
_Use stackblitz.com or similar -- try this template as a starting point: https://stackblitz.com/edit/angular-google-maps-demo
What steps should we try in your demo to see the problem?
Current behavior
Expected/desired behavior
angular-google-maps, Angular, & any other relevant dependency versions
Other information

first of all, this is a question, not an issue, so it belongs in StackOverflow.
Secondly, unfortunately, you cannot and you must use it in a root module


Midland, Michigan

http://gis6.midland-mi.org/ArcGIS/rest/services/Property/MapServer/1

Property layer no longer available.
Address data available for a fee http://www.cityofmidlandmi.gov/647/Purchasing-GIS-Data

$1500 for address points or $3000 for parcels. I don't see any agreement that prevents us from distributing it after buying it, either.

@migurski This is a good example for the writeup for county that we could pay something that's not crazy expensive and have redistribution rights to.
Breakdown of paid sources seem to be in the:

Less than 500 range ($20 and $200 are common)
Up to $5,000 (this one is $1,500)
More than $5,000 (I've seen $20,000)

shes locked up


Option to get rid of Chrome window

Chrome doesn't seem to provide any nice option for launching with minimized or hidden windows. However, it has window-positioning options which allow to at least move the window off-screen. This little trick doesn't stop Karma from relaunching Chrome browser and does not stop the window from hiding and popping out constantly, but at least "hides" the window from user's perpective. It seems that this doesn't even steal mouse/keyboard focus from code editors. Tested on Windows only, I don't have any graphical Linux workstation at hand.

I've just found out that someone's already suggested that trick elsewhere, but the discussion has died https://github.com/karma-runner/karma-chrome-launcher/issues/27

So, can we just use --window-position=-9999,0 or does the window size matter to you?

Actually, I sensed that it sometimes can matter to someone. Since the Karma window stays open, it may be beneficial for someone to i.e. move it back into visible space and press "DEBUG" button that Karma provides, or to see the list of Browsers connected to Karma. I have not used it much yet, I don;t know how about others.
On Windows it's achievable by alt-tabbing and pressing alt-space + move + moving the window into sight. With -99999 or something similar, the user will have a long way home.
But that's just my feeling. Most often developers will probably just want the window off screen, so large offset is fime for me. I'm not sure about the importance of possibility of movig-it-back to sight. One can always switch back to visible-chrome instead of hidden-chrome.


Bluetooth: Allow to configure LE Create Connection timeout

Depending on perhiperal advertising interval 3 seconds might not be
enough and would result in cancelling pending connection. Make this
Kconfig configurable and let application to decide.
Signed-off-by: Szymon Janc<EMAIL_ADDRESS>

Codecov Report

Merging #10278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10278   +/-   ##
=======================================
  Coverage   53.05%   53.05%
=======================================
  Files         214      214
  Lines       26201    26201
  Branches     5645     5645
=======================================
  Hits        13901    13901
  Misses      10028    10028
  Partials     2272     2272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c6a0c...8cb311d. Read the comment docs.


Support different datacenters

Currently there is a hardcoded datacenter url. That should be configurable. Same for the other SDK's

Fixed in v1.15.0


silence() not working

I do not want logs of my migration SQL statements.  Has this been resolved?
this does not work:
dbmigrate.silence(true);
What can we do to get this to actually work.  Is this a bug?
I would not expect to go and manually modify every migration.  I run migrations during tests and I also do not want console logs everywhere when those run migrations every time.  It slows down my tests.
I don't know why this issue is being ignored when I see several issues out there on this.
We should be able to rely on silence() and not have to manually remove that console log in every migration file.
Please update the docs and take silence out if it's not working...why is it in the docs if silence doesn't even work?

@dschinkel do you also create your migrations with --sql-file, i.e.:
db-migrate create <name> --sql-file

I have the same issue, and this is how I create my migrations. And the .js file that is outputted by the db-migrate create command includes these lines:
exports.up = function(db) {
  var filePath = path.join(__dirname, 'sqls', '<MIGRATION NAME>.sql');
  return new Promise( function( resolve, reject ) {
    fs.readFile(filePath, {encoding: 'utf-8'}, function(err,data){
      if (err) return reject(err);
      console.log('received data: ' + data);

(and the same for the exports.down script)
Where the large output comes from is all the console.log('received data: ' + data); lines.
In order for .silence(true), to properly work, this line would need to look something like:
      if (!silenceMode) { console.log('received data: ' + data); }

Where silenceMode is input into the script somehow. Maybe db.silenceMode?

It looks like @wzrdtales proposed a solution here: https://github.com/db-migrate/node-db-migrate/issues/453#issuecomment-278749154. @wzrdtales , would you be happy for me to help with its implementation? (no idea how complicated it might end up being)

just one warning ahead. silencing logs is usually a terrible idea. We used that for integration testing, so we could hide unimportant logs. In production in doubt you wont know what happened, which is bad.
Actually there shouldn't be a need to do anything though. https://github.com/db-migrate/node-db-migrate/blob/50b34a8dd2224e21c5f28843d49511a08d1dbe1b/api.js#L98 This is passed over the internal safeOptions param. In v1 it comes in the setup method:
https://github.com/db-migrate/node-db-migrate/blob/50b34a8dd2224e21c5f28843d49511a08d1dbe1b/lib/executors/versioned/v1.js#L14
In v2, just in the config object.
https://github.com/db-migrate/node-db-migrate/blob/50b34a8dd2224e21c5f28843d49511a08d1dbe1b/lib/executors/versioned/v2.js#L48


[Feature Request] Contextual Help menu

In jupyter lab you can add a tab next to your editor which shows the function signature of the function you're currently writing / the one you clicked on latest. Pycharm has similar feature as well. I would love to be able to use it in vscode.
Example:

Dupe of #1307. Currently implemented in the Jupyter PowerToys extension.


Update .tachikoma.yml

Coverage remained the same at 67.647% when pulling 83794239e5b3f5a4035651774fdfb6058f76abff on peacedata0:patch-1 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.


\Lists within  elements don’t render correctly

Describe the bug
Ordered or unordered lists within a <Card> element are rendered flush against the left edge of the card, instead of indented slightly like the rest of the card’s text.
To reproduce
In a .mdx file include this:
The quick brown fox jumps over the lazy dog.

<Card>
Hello world!

* Foo
* Bar
</Card>

Expected behavior
The bullets should be to the right of where they are now. They should be under the “H” of “Hello” instead of pushing up against the left edge of the card’s border.


add file validation rules

added two file validation rules to validate max file size and file extensions

Also add new rules to readme (and example of usage as well)


Web Interface Updates

List of interface updates before next run through:

[x] Don't show map by default
[ ] Make columns with applied filters and groups more visible
[ ] Fix table hotkeys so you can navigate the table with keyboard
[ ] Fix buttons running over the side of the cell
[ ] Better indication of the fields that need to be populated ( Indicate a valid value and changed values )
[ ] Flip between the inline editor and long text editor as the character length updates
[ ] Be able to copy over from an excel window
[ ] For the Filter change use the short form only
[ ] Allow editing over multiple cells with the popup editor
[ ] Indicate values that have changed but are not submitted
[ ] Change group by in menu to show [ Group by  ]

A lot of these are "nice to have" rather than essential but it really depends on the full end-to-end workflow. I'd rather see something that allows the task to be stumbled through with some caveats, and then tighten up aspects as we go. That's why I think the "step-by-step instructions" on how to use the interface are important.
Grouping and other things that allow real work to be accomplished quickly are the priority. Right now, we can't really make changes effectively using the UI, so it's hard to discover what the "right" ordering should be.

OK I've lightly gone through and adjusted the ranks here by priority. I'd emphasize that this list (broadly, "usability") runs in parallel to two equally large tasks:

getting new maps in the system to try the approach
writing documentation of the expected workflow for USGS users

Completed # 2 in 283614d3f47dea0385c8de79e3b057cfe059749e


Unexpected behavior for Staples table and a custom LogicalConfig

About You:
Name: Cassidy Mountjoy
Company: Blockpoint Systems
Your question:
When configuring my logical config I was having an issue with converting column names to lower case. I found myself needing to create a custom one, which I defined as
[LogicalConfig]
Name = bsql_logical_query
fieldnameLower_underscore = True
tablename = $dsName
tablePrefix = [testv1].

This worked beautifully for the calcs table and I'm passing the majority of the tests... As far as the staples table, not so much. I can't get past the smoke tests because of a column name mismatch, due to upper case columns not matching my lower case in the database. It seems like my logical config is only being applied to calcs?
I only say this because I fixed this issue in calcs by adding the logical config but it didn't fix the issue in staples.
Here's my current smoke test error in staples, an upper/lowercase mismatch:

My tds file has lower case names as well:

Any help or insight into this would be greatly appreciated, thanks!

Hi, @CassidyMountjoy, this is a known issue; I'll create a story to fix it.

Gotcha, @lukewrites, any temporary fix I can do to workaround this issue?

@CassidyMountjoy I don't think there is, unfortunately, but I took the story in the current sprint so I'm hoping to have a fix pushed soon.

@CassidyMountjoy Sorry I completely forgot to say in the above that you could just skip the smoke tests for now and look at how logical tests against Staples do.

Internal tracking id: 1348597

Hey @CassidyMountjoy would you mind pulling down master and checking out to the make-staples-smoke-logical branch (I named it in a hurry 😬) to see if that will fix things?
I'd recommend trying:
$ python -m tdvt.tdvt action --generate
$ python -m tdvt.tdvt run <your_ds> --verify

Thanks.

Thanks @lukewrites , after pulling and navigating to the make-staples-smoke-logical and running python -m tdvt.tdvt --generate I'm getting unexpected behavior. Looks like my .ini file is no longer valid, my console is relentlessly printing like some of the parameters in my logical config (I'm using the logical config I specified above) are no longer optional. I tried this on master as well and got the same response. Is this an update to the sdk that isn't in the docs yet?

After further investigation, I had updated TDVT to version 2.4. After switching back to 2.3.1 and I was able to generate the tests, without the failing logical config.

That's a bug that has a PR (#893) that will merge today.
It's actually lying to you - configs are fine, and tests should run after it's done console logging a million lines of fake news. Apologies for the mess on the command line.

@CassidyMountjoy #893 merged and I pulled master into my branch, if you'd like to give it a try. Should no longer see that logging mess.

Thanks @lukewrites I just pulled from your branch got the updated changes, moved back on tdvt 2.4.0, but still having the same logging issue as before.

I merged commits to master (2.5.0) that I think will fix this for you. If they don't fix this please re-open.

Started using v2.5.0, also changed branches to the make-staples-smoke-logical. The logging issue was solved. As far as the smoke tests, I did have to add the following to my ini file to get the smoke tests to work tablenameLower = True but I was able to pass the smoke tests, thanks for the help.

Glad to hear it!


Actually use the persisted position with centerOnLaunch:true

Fixes an issue when using both:
    "centerOnLaunch": true,
    "firstWindowPreference": "persistedWindowLayout",

In this case, the Terminal would ignore the persisted location and still just center on launch. This has been really annoying while testing tear-out, as we keep re-opening all my debug windows as a stack on top of each other.

Eh? Oh. A new system for auto-merges suddenly appears. 🥲


Drawing

Allows the user to add drawings to the program

[ ] Setting for switching to drawing mode
[ ] Drawings overlayed
[ ] Drawings saved to file
[ ] Drawing position updated as text, newlines, and formatting is added above

Marks in Tkinter may be useful for keeping drawing position within the text
https://tkdocs.com/tutorial/text.html#tags:~:text=Marks indicate a,e.%2C "a|bc."


[plugin][camera] Crash due to race condition in _dispatchQueue

This crash is found when I was playing around with camera plugin
Crash
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVCaptureAudioDataOutput setSampleBufferDelegate:queue:] NULL queue passed'
terminating with uncaught exception of type NSException

Reproduce
(1) In sample app, start video recording then stop it.
(2) Swipe home bar just a bit on iPhone X, so the app becomes inactive and immediately regain active.
(3) Tap the video button again and observe this crash.
Root Cause
_dispatchQueue is checked in main thread, but set to nil in background thread, which is open to race condition:
  // main thread:
  if (_dispatchQueue == nil) {
    _dispatchQueue = dispatch_queue_create("io.flutter.camera.dispatchqueue", NULL);
  }

  // background thread
 _dispatchQueue = nil

Explain
In the above reproduce step, (1) is to assign a new _dispatchQueue, (2) is to trigger "dispose" and "create" method calls consecutively, resulting in a race condition, and (3) will pass in the _dispatchQueue which has been nil'ed out asynchronously.
Solution
(1) It looks like the camera plugin has pretty complicated threading logic and it's getting hard to maintain. There have been multiple related issues. If we get time I am interested in refactoring the threading model in the future.
(2) For now an easy fix to this race condition is not to nil out this _dispatchQueue. DispatchQueues are quite lightweight as they are not actual threads.
(3) Or we can dispatch to main thread again before setting nil, which should fix _dispatchQueue race for this particular case, but may still open for other unknown cases

This looks like a duplicate of https://github.com/flutter/flutter/issues/59124, but @hellohuanlin I see you commented in that one.  Do you have reason to believe this is a different issue?

@jmagman the original issue does not have a repro step so it's hard for me to tell without more info.

Let's close this one in favor of that one.  You can add all the details and your repro steps there!

@jmagman sounds good!


Add docs to clarify SwitchListTile onChanged behavior

Steps to Reproduce

Add the following code to a flutter app (flutter create project will do the trick)

SwitchListTile(
  value: false,
  onChanged: (bool value) => print(value ? 'Switch is on': 'Switch is OFF'),
  title: new Text('Toggle'),
)

Build the app and drag the switch to the "on" state. The log shows the "Switch is on" message.
Now, drag the switch to the "off" state. The log shows nothing.
Drag the switch to the "on" state and you can see the "Switch is on" message.

This works the other way around: if the value was initially true, it will only onChaned when it's being set to off.
Also, if you tap the label itself, the onChanged event will get triggered every time, that's okay. But the value in the event will be the opposite of the initial value.
Logs
Nothing special with, flutter run --verbose, nor flutter analyze.
λ flutter doctor -v
[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 10.0.17763.437], locale en-US)
    • Flutter version 1.2.1 at c:\dev\flutter
    • Framework revision 8661d8aecd (3 months ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\___\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 35.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 191.6014.8
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[√] VS Code (version 1.33.1)
    • VS Code at C:\Users\ONet\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.26.0

[√] Connected device (1 available)
    • ELE L29

I've only done preliminary research into this so far, but it seems that this does not pose a problem if you do the following:
bool _value = false; // or true
...
SwitchListTile(
  value: _value,
  onChanged: (bool value) {
    print('updating value to $value');
    setState((){ _value = value; });
  },
  title: new Text('Toggle'),
)

I believe this is caused by value passed into SwitchListTile mismatching with the internally managed state. Is there a reason you're passing a constant boolean into the switch instead of updating it with setState?

In the meantime, I'll update the documentation with clearer instructions and a more fleshed out sample to highlight proper usage with setState

This is absolutely horrible. onChanged should fire NO MATTER the default value / new value. If it changes. onChanged should fire. Period. That's just basic  good design. Otherwise it's a useless one-way switch, and we have to find some other way to call setState()...

I'm not entirely sure if I'm interpreting you correctly, but based on the context, I think you're saying that even if state isn't passed into the Switch correctly, it should still fire onChanged when dragging the switch, regardless of whether its mismatched. I will describe my thought process based on that assumption.
I do believe that in a reactive framework, state passed into the Switch should have final say in what actually happens. Therefore, in this case, since the Switch's passed in state is mismatched, it's going to behave erratically. In my opinion, I think that the Switch should not move at all if dragged and state is not updated appropriately. Meaning, I agree with you that there could be safeguards against getting into this situation, but I don't think having onChanged fire regardless is the solution.
Also, I understand the frustration you are feeling, but please remember to adhere to the Code of conduct and be mindful of how you're conveying yourthoughts.

Ok, let’s get this part out of the way first... you’re saying that I’m violating code of conduct for pointing out what is clearly a poor design?
Back to the meat of the situation: forget about initial state, for a moment. Just set that aside, because that is NOT the issue - in EVERY other platform, in EVERY other UI library, in EVERY other language, when a user changes an on-screen object, its changed delegate fires. Pick any single one. Check box in C#, fires. In HTML, fires. In java, fires. That’s what I’m saying. Regardless of the control’s previous value, its delegate fires and the current value of the control comes along.
My questions remain: how did anyone think this was the right way to go, and how did this not fail a design peer review? It’s bad design. Just because every other platform works a certain way, doesn’t mean it’s the wrong way. Every other one works that way because it’s logical design.
If you take that as my breaking rules of conduct, then yes, I guess I am, and happy to do it.
This is bad design. The delete should ALWAYS fire, regardless of previous state.
This is... just... it’s NOTHING but obvious.

@chornbe Our code of conduct (please review it) requires actively pleasant behaviour. Your comments are not actively friendly, and therefore, yes, it is a code of conduct violation.
https://github.com/flutter/flutter/blob/master/CODE_OF_CONDUCT.md
If that is unacceptable to you, or if you do not understand why what you wrote is not friendly, then I ask that you please not participate in this community. Thanks.

I also think that the onChanged  should fire every time. I'm in a StatelessWidget and I am unable to use the Switch/SwitchListTitle Widget at all because of the really really weird behaviour. There is no chance to react correctly on switching on/off. Or am I missing something?

Hi @shihaohong , @Hixie
if I understood correctly from https://github.com/flutter/flutter/issues/31984#issuecomment-488790378 , this implies that SwitchListTile be used cannot use with Flutter Bloc.
What would be the recommended approach to achieve the right functionality following the next snippet of code?
BlocBuilder(     bloc: BlocProvider.of<PreferencesBloc>(context),     builder: (context, state) {     return SwitchListTile(         title: Text('Change Preference Value'),         value: state.preferenceName,         onChanged: (bool newValue) {         preferencesBloc.add(FlagChanged(             preferenceName: newValue));         },     );     }, )
Thank you advance,
Roman

@Roomka I'm not familiar enough with Flutter Bloc to comment, but could you file a new issue to describe the problem that SwitchListTile has when used with Flutter Bloc? That way, it's easier to track since it's particular to the situation you're dealing with. Thank you!


chore: automate releases with Release-plz

Releasing the console crates has been a bit of a hassle. It requires
manual work run locally and as such, we have gone long periods without
releases, despite having changes which would be worth releasing.
Release-plz provides release automation based on GitHub actions. It
will create, and then update a PR for the next release.
Release-plz depends on conventional commits (which the console
project is already following) to determine the next version number for
each crate and then uses cargo-semver-checks to check that the version
bump is correct.
For the changelogs, git-cliff is used. Since we already started using
in #416, so we can reuse our existing cliff.toml config file. A small
change has been made to remove the footer, as it was getting included
multiple times in a single changelog file due to the delta updates.
Caution: In order to use Release-plz, a crates.io token first needs
to be added to the GitHub project. This means that anyone with PR merge
rights will be able to run a release by merging the Release PR.
Additionally, GitHub actions need to be given permission to create PRs.
The previous scripts used to release have been removed.
Review Notes (DO NOT INCLUDE IN COMMIT MESSAGE)
To test the functionality of Release-plz, I copied console into a separate
project hds_console and played around with it there first.
The series of test PRs can be seen at: https://github.com/hds/hds_console/pulls?q=is%3Apr+is%3Aclosed
This released a series of test crates. The version history for each is:

https://crates.io/crates/hds_console-api/versions
https://crates.io/crates/hds_console-subscriber/versions
https://crates.io/crates/hds_tokio-console/versions

The first release of each of the test crates was performed with the
existing release script. The subsequent releases were performed
by Release-Plz.

@hawkw What do you think about this workflow for releases? As mentioned, we will need to add a crates.io token to the action secrets on GitHub, but it would then allow releases entirely from here, no command line shenanigans needed (mostly).

This is the exact workflow (aside from the multiple package config) that I use for a bunch of tui related crates . It's fairly robust and works great. Being able to publish a release just by hitting merge on the release PR and trusting that everything is just handled correctly is an excellent workflow.


'type' is undefined

Describe the bug
'type' is undefined when running Quorum deployment
TASK [Checking for the carrier-quo-role-tokenreview-binding] *******************
TASK [../../shared/configuration/roles/check/k8_component : Check ClusterRoleBinding carrier-quo-role-tokenreview-binding is created] ***
fatal: [localhost]: FAILED! => {"msg": "The conditional check '(component_type == "Namespace" and type == "no_retry") or ( component_type == "StorageClass" and type == "no_retry" ) or (component_type == "ClusterRoleBinding" and type == "no_retry")' failed. The error was: error while evaluating conditional ((component_type == "Namespace" and type == "no_retry") or ( component_type == "StorageClass" and type == "no_retry" ) or (component_type == "ClusterRoleBinding" and type == "no_retry")): 'type' is undefined\n\nThe error appears to be in '/jenkins/workspace/BAF_Demo_multi_quorum-GNPANTIXFAVEYAQB6ZDJIEMQ5GAEN2YJXF6UPSXDSZK7S6PPOAGQ/platforms/shared/configuration/roles/check/k8_component/tasks/main.yaml': line 7, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# Check if component created without retry\n- name: Check {{ component_type }} {{ component_name }} is created\n  ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n    with_items:\n      - {{ foo }}\n\nShould be written as:\n\n    with_items:\n      - "{{ foo }}"\n"}
To Reproduce
Steps to reproduce the behavior:

Edit network yaml as per instructions
Deploy Quorum network using BAF
See error

Expected behavior
Task should not fail

have fixed this with the PR #682


Roll engine 015c0246aebc..39fea550209f (3 commits)

https://github.com/flutter/engine/compare/015c0246aebc...39fea550209f
git log 015c0246aebc6fc23f30004e3319b6d1e85a885a..39fea550209f34a74e4f00b813d5ef098e2c4507 --no-merges --oneline
39fea5502 Roll src/third_party/skia f34d0c79dc6c..3d42a0521d12 (1 commits) (flutter/engine#8187)
926e65531 Roll src/third_party/skia d3cfbcae10eb..f34d0c79dc6c (2 commits) (flutter/engine#8186)
575d61f49 Roll src/third_party/skia 49ea3194535c..d3cfbcae10eb (9 commits) (flutter/engine#8184)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6571097213370368

Commit queue failed; closing this roll.


Invalid get index 'normal Range and additional Errors when using SS2D Material Edge

Using Godot 3.5.1 Stable Edition. When ever I go to add the edge to a closed shape I get the following error in my output log.

Every time I move a point in the shape, also the textures disappear as soon as I do this, the new edge material doesn't show and the fill texture disappears as well

I'm sorry nobody ever replied to this issue.
Unfortunately, we do no longer maintain the 3.x branch since the project was ported to 4.x.
I'm pretty sure the issue has been fixed in the current version.


[Snyk] Security upgrade grunt-eslint from 22.0.0 to 25.0.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

⚠ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

631/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 6.2
Missing Release of Resource after Effective Lifetime SNYK-JS-INFLIGHT-6095116
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: grunt-eslint
    The new version differs by 20 commits.

82c984f 25.0.0
5d282f8 Meta tweaks
81834b4 Update to ESLint 9, support flat config, and require Node.js 18 (#175)
0704be0 v24.3.0
495118b Update dependencies
fac0aff 24.2.0
826ca5f Update dependencies
88cbcac 24.1.0
89eb056 Support async formatters (#174)
63a9fe7 24.0.1
1322e30 Fix the plugin not finishing in some cases
259ce5c Meta tweaks
5e086f7 24.0.0
7bb705b Cleanup
dbaf9d5 Upgrade to ESLint 8 and require Node.js 12 (#171)
3de5e21 Move to GitHub Actions (#170)
61e98a9 23.0.0
2ba9e26 Meta tweaks
a8f45f6 Upgrade to ESLint 7 and require Node.js 10 (#167)
274625a Update link to built-in formatter (#164)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

This didn't update the package-lock.json file

Getting a new reviewer because I have commits on this now.


Unable to connect to network

Description
Unable to connect to network.
Correct behavior
Local node should be connected to Ultranet network.
Steps to reproduce

Launch FUI app.
Open Peers.
Observe table.
Local node not connected to any remote node.

Screenshots

Software settings and version
Version: <IP_ADDRESS>
Network: Test0

Unable to reproduce, check firewall settings


Errors of F200 on Raspberry Pi 4.

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
F200

Firmware Version
<IP_ADDRESS>

Operating System & Version
Raspbian Buster

Kernel Version (Linux Only)
4.19.75-v7l+

Platform
Raspberry Pi

SDK Version
legacy

Language
{C/python }

Issue Description
I have a problem when start a streaming camera of F200 on Raspberry Pi 4.
The device has been recognized and I can obtain RGB using Cheese on Raspbian Buster.
But when I started to stream frames through pyrealsense package, this error occurred:  UVCIOC_CTRL_QUERY:UVC_SET_CUR error 2, No such file or directory
Output here:
The left was from COLOR Stream and the right was from DEPTH Stream

did anybody face this problem? Please me some advices.

Are you using the correct Pyrealsense for the legacy 1.12 SDK, please?  Pyrealsense2 is for the current RealSense SDK 2.0.  The similarly named but different Pyrealsense 2.x (e.g Pyrealsense 2.2) should be used with the legacy SDK.
The link below has a recently published guide to using an R200 (same generation as the F200) with the legacy SDK and the older Pyrealsense 2.2.  It may be adaptable for your F200.
https://idorobotics.com/2020/01/02/running-the-realsense-r200-camera-with-librealsense-and-pyrealsense-legacy-libraries/

Hi @MartyG-RealSense I've already installed and used legacy 1.12 SDK with pyrealsense (for legacy).
I think the problem here is I haven't patched uvc module in raspbian buster (kernel 4.19) which causes errors.
I have no idea how to patch it. I found some available scripts in the repo but all for other kernels/ubuntu version.
Any suggestions for me? Thanks in advance!

The link below has a guide to patching uvcvideo on Raspian Buster.
https://eleccelerator.com/wiki/index.php?title=Raspbian_Buster_ROS_RealSense#Patching_uvcvideo

Hi @MartyG-RealSense, It works like a charm.
But in some examples in cpp source and when using pyrealsense, I have a error: rs.error: TemperatureControlLoop: opcodes do not match.

Apparently it may be a kernel compatibility issue between modern kernels and the legacy Librealsense.  A possible fix is provided in this link:
https://github.com/IntelRealSense/librealsense/pull/3929

Hi @MartyG-RealSense
Wow. It's amazing! I've made F200 work on Raspberry Pi 4.

Solution #3929 works for me.
To build appropriate legacy SDK for ARM (Raspberry Pi 4 - Kernel 4.19), I used the combination: https://github.com/Maghoumi/librealsense and pyrealsense with some modifications in file rs.h.

Thank you so much!

Hi @MartyG-RealSense
There are some problems with configuration.
Solution #3929 doesn't work :D

I'll have to let @dorodnic advise on this one, as I do not have any experience with the legacy SDK, unfortunately.
In the meantime, it is possible that you may be able to configure via ROS using the old realsense_camera package that is compatible with the old-generation cameras such as F200.
http://wiki.ros.org/realsense_camera
That would open up the possibility to do dynamic reconfiguring of a stream once it activates.
http://wiki.ros.org/realsense_camera#F200_Dynamically_Reconfigurable_Parameters

hi @MartyG-RealSense,
After few days trying to fix those bug, I found the way to overcome those problems.
https://github.com/vocong25/librealsense_for_arm
This is the step-by-step guideline which works on my Raspbian Buster - Kernel 4.19.97-v7l+ with Realsense F200.
Finally, thank you very much for your help!

Great work!  Thanks so much for developing your solution and sharing it.    :)

@vocong25 Glad to hear the issue resolve. Thanks for sharing!


Feature: support var(--variables) with fallback for runtime change

We have in :root a map of variables with can be use by default in all elements/components with proper fallback.
Can we add another $support-css4 to generate additional fallback styles?
This feature can be added later in roadmap if docs aren't stable right now.
Example:
.swatch-blue {
    color: #fff;
    background-color: #007bff;
}

to:
.swatch-blue {
    color: #fff;
    background-color: #007bff;
    background-color: var(--blue);
}

Benefits:

works same as before
new way to change color in runtime!
can be change by js in one place to enable fast change of parameters
can be enabled by setting

$support-runtime-variable or $support-css4

(or something like that)

this feature expand to not only colors but breakpoints and other properties

Need to:

check if some browser incorrect implement that feature
invert colors can be tricky

How to do that in clever way and I added benefit of this approach:
https://codepen.io/anon/pen/XVLvLQ
Better idea:

create some tool like autoprefixer to enable it by default without bloat code. But add documentation about that solution on site so no new issue will be generated.

Documentation and credits for amazing work:
https://getbootstrap.com/docs/4.0/getting-started/theming/#color
https://css-tricks.com/difference-between-types-of-css-variables/

Being able to easily change the theme colors at runtime would be a very neat feature.
Let me know if I can help write a PR to add support.

I was able to successfully use CSS variables to support runtime theming for things like $body-color:
$body-color: var(--body-color);

So now you can alter the value of --body-color on the root element with JS (or by settting a theme CSS class that applies them).
But when trying to use that approach with e.g. buttons it doesn't work because they use functions like darken on the values:
$secondary: var(--secondary);

      background-color: darken($color, 10%) !important;
                       ^
      Argument `$color` of `darken($color, $amount)` must be a color
Backtrace:
   node_modules/bootstrap/scss/mixins/_background-variant.scss:12, in function `darken`
   node_modules/bootstrap/scss/mixins/_background-variant.scss:12, in mixin `@content`
   node_modules/bootstrap/scss/mixins/_hover.scss:21, in mixin `hover-focus`
   node_modules/bootstrap/scss/mixins/_background-variant.scss:11, in mixin `bg-variant`
   node_modules/bootstrap/scss/utilities/_background.scss:4
      in node_modules/bootstrap/scss/mixins/_background-variant.scss (line 12, column 25)

I looked into doing it for all of Bootstrap. I got tripped up because a lot of the colors used in hover states, linear-gradients, etc. are a percentage off the base colors. Since Sass is used to calculate the % differences from the base colors for these ones I didn't see an immediate path forward for this feature.
It would require a thoughtful refactoring to support. Open to any suggestions from a Bootstrap / Sass expert.
When / if blend lands in CSS this would be a easier change: https://www.w3.org/TR/css-color-4/#blend-adjuster

Thanks for sharing that spec, this will be incredibly useful!
But in the meantime, is there a solution where Bootstrap allows to customize the hover colors through variables/maps and only defaults them to the darkened values? Or somehow checks if they are a custom property?

I found out that these components can be themed with CSS vars (because they don't use compile-time color manipulation):

Links ($link-color, $link-hover-color)
Forms ($input-, $input-btn-)

While these cannot:

Buttons
Alerts
Tables

@felixfbecker are many colors associated with Buttons, Alerts, and Tables respectively? Could the compile time manipulation be extracted into variables that are passed into the mixins?
btn-background
btn-hover-background
etc...
Would this make runtime color manipulation more feasible?

Yeah that would work perfectly for me. From what I saw the compile time color manipulation is mostly just darkening one step for hover effects. And alerts could also easily be configured with Sass variables instead of color manipulation. It is probably even possible to still default these variables to the color manipulation.

I think that won’t work because you can’t detect at compile time whether a (runtime) CSS var is set, and it doesn’t have to be set on :root.
But it should be possible to simply introduce the extra Sass variables for hover etc. and let the user set them to a CSS var.

Closing out as not a bug and not a feature request we can take on right now. I think we're better served in v4's lifespan by focusing first on Sass variables and then CSS as a first class come v5 or so.


Add ability to upload your own image for preview backgrounds

Summary by CodeRabbit
Release Notes

New Features

Enhanced file upload experience with improved visibility for the drop area.
Customizable background image upload feature based on user preferences.
New image upload API with constraints and user authentication.
Introduction of a dedicated upload button for image uploads.
Added tooltip functionality with new TooltipPortal component.

Bug Fixes

Maintained existing error handling for file uploads.

Documentation

Updated environment variable configurations for development and deployment.

Dependencies

Added new libraries to enhance functionality, including UploadThing and image processing utilities.

@coderabbitai pause

https://github.com/coderabbitai resume

@coderabbitai resume


Adds Korean localization

Added Korean localization.

Please follow the similar requirement in #424 before we can start to review the request.


refactor: Replace Starscream w/ WebSocketKit

Reading through some of the discussions it looks like dropping Starscream has been at least talked about.
I really love this library and want/need to get it working on Linux for my use case.
Removing Starscream brings the package a step closer to being able to work on linux.
I have a few other PRs out for the remaining steps.

While I always appreciate contributions, and I can see you've been busy, I think you've missed some of the conversations and the Discussions.
We opted to leave v5 more or less as-is for the moment, and focus on removing Starscream in v6.
We have done some testing in this area already and found some behavioural differences reported, so to minimise impact on existing clients we decided not to prioritise this in v5.
There have also been several other PRs for this that have already been closed as a result of the same discussions.


Error when splitting without closing reference tag

I wanted to push Mountain to breaking point, because I'm a jerk, sorry.
I feel like the syntax for splitting a screenplay should allow the writer not to need closing tags, e.g. the following throws an error:
# ACT I

= Meet the **Hero**.

[[#reference intro.fountain]]

FADE IN:

# ACT II

# ACT III

## Finale

[[#reference the-end.fountain]]

> FADE OUT.

>THE END<

[[/reference]]

Ideally, I'd like the writer to be able to think "I'll just split this monster into smaller chunks" and go through pasting a stupidly simple tag. Even something like...
# ACT I

= Meet the **Hero**.

[[ split ]]

FADE IN:

# ACT II

# ACT III

## Finale

[[ split: the-end.fountain ]]

> FADE OUT.

>THE END<

And Mountain would chug on through, splitting into three *.fountain files, automatically numbered:

screenplay-ref1.fountain:

# ACT I

= Meet the **Hero**.

screenplay-ref2.fountain:

FADE IN:

# ACT II

# ACT III

## Finale

the-end.fountain:

> FADE OUT.

>THE END<

(Where split is an alias for reference.)
I have some ideas about how to make the above syntax compatible with the rather genius way that Mountain can run  join and split back and forth over the same files, but I figure my above ideas are annoying enough already!

Sorry to dust off something from the distant past; I actually use Makefiles for joining projects these days, so for the sake of housekeeping you can close this if you like.


Terminal blank on windows 10

Issue Type: Bug
on my acer nitro 5, vs code terminal is showing blank(folder path is not visible), i have tried uninstalling and installing also. but it hasn't worked.
Can i know why is it happening?
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz (8 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.85GB (3.07GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

See https://code.visualstudio.com/docs/supporting/troubleshoot-terminal-launch#_additional-troubleshooting-steps

If you're on Windows 10 1809 (build 17763) or below, the issue is related to the legacy "winpty" backend. Upgrading to Windows 1903 (build 18362) will move you onto the new "conpty" backend that is built by Microsoft and could fix your problem.

Terminal implementation on Windows 1803 is known to be buggy and Code team doesn't want to fix those issues anymore.

Is there an alternative option for people in a large corporate environment that have zero say in when Windows gets upgraded?
We recently started seeing this issue -- terminal is rendered completely useless.  Also, task output is invisible (tasks still run though)
Currently on Windows 10 1809

Does changing the terminal.integrated.rendererType setting help?

No - it’s definitely permission related as running as admin fixes the issue on Windows 10 build 1809.
What permissions does VSC need to render the terminal properly?

@cmeyertons whatever winpty needs. If permissions are indeed the reason you will have to wait until the Windows update gets rolled out.


refactor: update casing

TL;DR - Update field name from photoUrl to photoURL.
Following the pattern of how the fields are assigned, all of the fields are using the same case rules except for photo URL field which was photoUrl instead of photoURL.

Hi @jofftiquez,
thank you for this PR.
In this project I use the camelCase notation for the fields.
So it is rather a coincidence that the other fields have the same notation. 😄
For example, in the Firebase Android SDK it is called getPhotoUrl.
In the end, of course, it is a matter of choice and I don't think there is a right or wrong here.
For this reason, I am closing the PR.
Best regards,
Robin

Hi @jofftiquez, thank you for this PR. In this project I use the camelCase notation for the fields. So it is rather a coincidence that the other fields have the same notation. smile For example, in the Firebase Android SDK it is called getPhotoUrl. In the end, of course, it is a matter of choice and I don't think there is a right or wrong here. For this reason, I am closing the PR.
Best regards, Robin

Totally understand @robingenz 😸 no problem at all. Cheers!


Add "googleplus" sidebar parameter

I'm using the Geo theme for my blog (http://www.piware.de/), thanks for this, it's slick and nice! You can see there how the G+ button looks like.

Looks good, thanks!


Safari 11.1.2 support and fix

Please be reminded by
At the html page , add this at the header to make your whole project compatible with Safari 11 and Safari 10

When i open your project using chrome browser, works fine.
Safari, the party list cannot be displayed. When i check my javascript
console through safari, it tells unsafe-inline and other tags not included
due to Content Security Policy. I resolve it by adding the headers
Aaron Gong<EMAIL_ADDRESS>於 2018年8月8日 週三 上午11:20寫道：

I will look up, but can you elaborate?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ais-one/vue-crud-x/issues/24#issuecomment-411271592,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFcfL0MSaUVJ6jlHF62hMNnpz_LmLT2Zks5uOlkTgaJpZM4Vx6A8
.

--
Yours sincerely,
*Larry Lo *

browser specific issue


Security issue with xmlhttprequest-ssl (Karma update required)

Remediation
Upgrade xmlhttprequest-ssl to version 1.6.2 or later. For example:
<EMAIL_ADDRESS>version "1.6.2"
CVE-2021-31597
Vulnerable versions: < 1.6.1
Patched version: 1.6.1
The xmlhttprequest-ssl package before 1.6.1 for Node.js disables SSL certificate validation by default, because rejectUnauthorized (when the property exists but is undefined) is considered to be false within the https.request function of Node.js. In other words, no certificate is ever rejected.
Dependency tree:
karma -> socket.io -> socket.io-client -> engine.io-client > xmlhttprequest-ssl

Version 6 already supported


🐛 Bug: Unexpected Menu behaviors

The melt-ui context menu currently has a few different behaviors from the default browser context menu:

Pointer events (hover, mousedown, click, etc) still register for elements outside of the context menu
Clicking outside of the context menu both closes the menu and registers the click event to the clicked element
Pressing tab closes the menu

These differences make the melt context menu feel unintuitive in our application.  It'd be great if we had options to configure these behaviors to feel closer to the native context menu.  Potentially a  modal: boolean would be good enough?

We should be able to apply similar logic to the menus as we did with #883 to the menus as well to get this behavior more consistent with the expected.

I reclassified this as a bug, because click events shouldn't be passing through

Pointer events (hover, mousedown, click, etc) still register for elements outside of the context menu

This does happen in chrome and ff though 🤔

2/3 of these will be addressed by #1035.
As far as tab closing the menu, you can prevent this behavior using the m-keydown event on the menu.

However I do like the modal option.


Router is failing (403)

Description
Your Router example (in samples_mapzen-android-sdk-sample)  is constantly throwing 403.
Steps to Reproduce

Clone the solution
Follow the necessary steps to get your project running
Run samples_mapzen-android-sdk-sample
Click on Router
Set two points
Press Get Route

-> Forbidden
Mapzen SDK & Android Version

Mapzen: Latest
Android: 4.4

Hi @Nikituh one possibility is that the API key is not getting properly added to the request. Did you register for a Mapzen API key? Did you add it to the sample application as either a string resource or set it in code?
https://github.com/mapzen/android/blob/master/docs/getting-started.md

You're right, my bad. I was under the impression that the sample app would be able to work without any additional configuration.
Closing.

Glad that did the trick.
We used to publish an "demo" API key with the sample app but it was getting used so much that everyone was getting rate limited so it's been working better to have everyone grab their own.
Let us know if you have any suggestions on how to improve the experience for getting up and running the first time :)


Expand Issue attributes to consider status and ID.

For remote issue trackers we are currently concerned with 3 things only namely,
title, description and status. Opening this PR individually before the code changes are made for the larger issue of mapping remote issues with work item.
As part of this PR:
The Issue will have

ID
title
description
status

dependency  #131
Signed-off-by: Shoubhik<EMAIL_ADDRESS>

This change is

LGTM
@tsmaeder any objections against merging?

Updated the commit message to reference to #139 which is a subtask of #131.

 , however, does this really belong into the "models" package?

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Replaced by #111?

Can one of the admins verify this patch?

Yes @aslakknutsen .


check if additional_description exists

Questions
Answers

Description?
category.additional_description is only available since PrestaShop/PrestaShop/pull/27292 (for PS 8.0.0), so PrestaShop/classic-theme/pull/18 need this tweak to make the theme compatible with PS 1.7.8.x

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/PrestaShop/issues/30595.

How to test?
Please check the fixed ticket.

Possible impacts?
Please indicate what parts of the software we need to check to make sure everything is alright.

Maybe you could use !empty instead? This way we won't show the block for no reason

@kpodemski Good suggestion, applied :thumbsup:

@leemyongpakvn One last change pls 🥹 We can do only !empty, isset is not needed.
Like here:
https://github.com/PrestaShop/hummingbird/blob/develop/templates/catalog/_partials/category-footer.tpl
We can merge it then. 👍

@Hlavtox I already changed my own isset by !empty following kpodemski's suggestion. The rest isset in the same line came from PrestaEdit at pull 84

Sorry dude I am blind, it's isset($category) 🤣

@PrestaShop/qa-team Can we merge without QA? It's the same code as on hummingbird. 👍

@Hlavtox no we should test it 😉

@leemyongpakvn, as discussed in the issue, I'm closing this PR, thanks for the contribution anyway!

The slower the safer ;) @Hlavtox I think we need write something down about version compatibility in this repo's About page.


Trying to download dataset, it says "Dataset is malformed"

I'm trying to download the dataset in the README,
but when I click the link I get "Dataset is malformed"
Thanks!

I'm sorry. We just double-checked the link, and it's fine. Maybe you can try logging out of your Google account and clicking the link. If that fails, can you provide more details so that I can help you download the dataset?

Oh now I can download it! probably it was temporary problem on my side.
Thanks!!


Add GLSL hextiling node implementation

This PR adds GLSL implementation for hextiling nodes proposed by #2093.
Nodes to add:

<hextiledimage> (color3 and color4)
<hextilednormalmap> (vector3)

We had some of our folks take a look internally the implementation looks great. Thank you @msuzuki-nvidia!
Are there any outstanding issues, or is this ready enough to consider for 1.39.2 perhaps?

@crydalch Thank you for your review!
I would leave the timing of the merge and release to @jstone-lucasfilm


Stop storing the locale in the session

@jollopre and I had a conversation about the way we are storing the locale in the session. The conversation started because we were having difficulty building a test to make sure that FastGettext was reporting the correct locale after changing the language setting for an Org or User.
The Devise test helpers do not create a session, so FastGettext always returns the default locale. Rails also warns against storing this information in the session object in its I18n documentation.
We should consider updating the ApplicationController so that it no longer relies on session[:locale]  and instead simply checks the current_user.language, then current_user.org.language and finally uses the default if those other 2 are not set.
We can accomplish this by replacing:
 # Sets FastGettext locale for every request made
  def set_gettext_locale
    FastGettext.locale = session[:locale] || FastGettext.default_locale
  end

  # PATCH /locale/:locale REST method
  def set_locale_session
    if FastGettext.default_available_locales.include?(params[:locale])
      session[:locale] = params[:locale]
    end
    redirect_to root_path
  end

with something like
  def set_gettext_locale
    # FastGettext.locale = default OR the Org's language OR the User's language if set
    FastGettext.locale = FastGettext.default_locale
    FastGettext.locale = current_user.org.language unless current_user.org.language.nil?
    FastGettext.locale = current_user.language unless current_user.language.nil?
  end

We would then need to remove the calls to the old set_locale_session and remove the session[:locale] lines from the sessions_controller.rb

Or maybe?
def set_gettext_locale
  # FastGettext.locale = default OR the Org's language OR the User's language if set
  if current_user.language.nil?
    if current_user.org.language.nil?
      FastGettext.locale = FastGettext.default_locale
    else
      FastGettext.locale = current_user.org.language
    end
  else
    FastGettext.locale = current_user.language
  end
end

If we want to get rid of the session. It is needed to have the state in the URL:

either URL parameter for the locale selected (e.g. http://example.com/en_GB/foo/bar)
or query parameter (e.g. http://example.com/foo/bar?locale=en_GB)

since we allow the registered/anonymous users to change the language for the session. I would be personally inclined to choose query parameter since it is something not mandatory in URLs.
The function at application_controller.rb could be something like:
def set_gettext_locale 	if !params[:locale].nil? 		FastGettext.locale = FastGettext.default_available_locales.include?(params[:locale]) ? params[:locale] : FastGettext.default_locale 	elsif !current_user.nil? 		FastGettext.locale = !current_user.get_locale.nil? current_user.get_locale : FastGettext.default_locale 	else 		FastGettext.locale = FastGettext.default_locale 	end end
The method get_locale (e.g. https://github.com/DigitalCurationCentre/roadmap/blob/development/app/models/user.rb#L74) already takes care of choosing either user default language or his/her org default’s language. Bear in mind that this will hit the database anytime a logged in used changes page and the locale state in the URL is absent.

I'm strongly against including the locale in the URL. A parameter is fine, but let's only use it for anonymous browsing and if a language choice has been made.


No such file or directory

After processing all the images I do get this one error:
Writing image 1 of 90.Traceback (most recent call last):
  File "add_images.py", line 66, in <module>
    os.stat(f"image_{i+1}.{images[i][-3]}").st_size < 200000
FileNotFoundError: [Errno 2] No such file or directory: 'image_1.p'

and the scripts stops with only one image in the directory.

@gbakes Please look at the previous issue. I missed writing a semicolon in the code, that has been updated now and it works.
Essentially, either redownload the repo or edit your add_images.py file so that it has images[i][-3:] in both instances. Thank you.

Please confirm that this is working for you once you have changed it.

Sorry didn't see the previous issue comment before submitting this ^^ didn't think you'd be that fast! Nice work 💯

No problem. @gbakes Is it all good now? Sorry about the inconvenience, I had changed the code via web browser and not via IDE and so hadn't double-checked before committing. It's good that it was caught so quickly, this could have discouraged other people - thanks!

Works like a charm!


Exception when debugging code with multiprocessing module

Environment data

VS Code version: 1.33.1
Extension version (available under the Extensions sidebar): 2019.3.6558
OS and version: Arch Linux (x64 4.19.34-1-lts)
Python version (& distribution if applicable, e.g. Anaconda): 3.6.2 (Anaconda 3-.5.0.0)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pyenv
Relevant/affected Python packages and their versions:

Expected behaviour
Complete debugging without exceptions
Actual behaviour
An exception occurs during debugging python script with multiprocessing (see below). The code runs fine with "Code Runner". I've tried with different python interpreters and also without any virtual environment with the same result. I'm using the default debug configuration (launch.json):
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File (Integrated Terminal)",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal"
        },

Steps to reproduce:

Debug any python script with multiprocessing package imported. E.g. :

from multiprocessing import Pool

def f(x):
    return x*x

if __name__ == '__main__':
    with Pool(5) as p:
        print(p.map(f, [1, 2, 3]))

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

[Info  - 4:26:35 PM] GetCurrentSearchPaths /home/user/.pyenv/versions/anaconda3-5.0.0/bin/python
[Info  - 4:26:35 PM] Python search paths:
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/lib-dynload
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/site-packages
[Info  - 4:26:35 PM] Configuration search paths:
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python36.zip
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/lib-dynload
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/site-packages
[Info  - 4:26:35 PM]     /home/user/.pyenv/versions/anaconda3-5.0.0/bin
[Info  - 4:26:37 PM] Microsoft Python Language Server version <IP_ADDRESS>
[Info  - 4:26:37 PM] Initializing for /home/user/.pyenv/versions/anaconda3-5.0.0/bin/python
##########Linting Output - pylint##########

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
(I couldn't find it...)

Output from terminal:
cd /home/user/workspace/python/pythonv3/Multiprocessing ; env PYTHONIOENCODING=UTF-8 PYTHONUNBUFFERED=1 /home/user/.pyenv/versions/anaconda3-5.0.0/bin/python /home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/ptvsd_launcher.py --default --client --host localhost --port 45251 /home/user/workspace/python/pythonv3/Multiprocessing/mp06.py
E00000.272: Exception escaped from start_client

            Traceback (most recent call last):
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/log.py", line 110, in g
                return f(*args, **kwargs)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/pydevd_hooks.py", line 74, in start_client
                sock, start_session = daemon.start_client((host, port))
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 214, in start_client
                with self.started():
              File "/home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/contextlib.py", line 81, in __enter__
                return next(self.gen)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 110, in started
                self.start()
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 145, in start
                raise RuntimeError('already started')
            RuntimeError: already started

Traceback (most recent call last):

E00000.300: Exception escaped from start_client

            Traceback (most recent call last):
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/log.py", line 110, in g
                return f(*args, **kwargs)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/pydevd_hooks.py", line 74, in start_client
                sock, start_session = daemon.start_client((host, port))
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 214, in start_client
                with self.started():
              File "/home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/contextlib.py", line 81, in __enter__
                return next(self.gen)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 110, in started
                self.start()
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 145, in start
                raise RuntimeError('already started')
            RuntimeError: already started

Traceback (most recent call last):

E00000.301: Exception escaped from start_client

            Traceback (most recent call last):
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/log.py", line 110, in g
                return f(*args, **kwargs)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/pydevd_hooks.py", line 74, in start_client
                sock, start_session = daemon.start_client((host, port))
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 214, in start_client
                with self.started():
              File "/home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/contextlib.py", line 81, in __enter__
                return next(self.gen)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 110, in started
                self.start()
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 145, in start
                raise RuntimeError('already started')
            RuntimeError: already started

Traceback (most recent call last):

Error in atexit._run_exitfuncs:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):

Error in atexit._run_exitfuncs:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):

E00000.334: Exception escaped from start_client

            Traceback (most recent call last):
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/log.py", line 110, in g
                return f(*args, **kwargs)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/pydevd_hooks.py", line 74, in start_client
                sock, start_session = daemon.start_client((host, port))
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 214, in start_client
                with self.started():
              File "/home/user/.pyenv/versions/anaconda3-5.0.0/lib/python3.6/contextlib.py", line 81, in __enter__
                return next(self.gen)
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 110, in started
                self.start()
              File "/home/user/.vscode/extensions/ms-python.python-2019.3.6558/pythonFiles/lib/python/ptvsd/daemon.py", line 145, in start
                raise RuntimeError('already started')
            RuntimeError: already started

Traceback (most recent call last):

Error in atexit._run_exitfuncs:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):

[1]    12744 terminated  env PYTHONIOENCODING=UTF-8 PYTHONUNBUFFERED=1   --default --client --host

I've the same exception

Same problem here with Python 3.5.6.

Closing this downstream issue as the issue is being tracked upstream https://github.com/microsoft/ptvsd/issues/943


CLI causing unclean termination during migrations

I'm seeing the blow error with increasing frequency when running make e2e in FireFly Core.
I believe the problem is the CLI is terminating the FireFly core process while it's competing the automigrations.
Few potential enhancements I can see that might resolve this:

Move to the new admin.preinit feature, so the restart is not necessary
Implement a healthcheck on the FireFly core such that it only reports "up" once it's ready
Don't start FireFly core at all during the Ethconnect initialization step - leave it out of docker-compose.yml until later

Symptom in CLI (after long delay)
...
registering org_0 and node_0
Error: Post "http://localhost:5000/api/v1/network/register/node/organization": dial tcp [::1]:5000: connect: connection refused
Usage:
  ff start <stack_name> [flags]

Flags:
  -h, --help      help for start
  -n, --no-pull   Do not pull latest images when starting

Global Flags:
      --ansi string   control when to print ANSI control characters ("never"|"always"|"auto") (default "auto") (default "auto")
  -v, --verbose       verbose log output

Error: Post "http://localhost:5000/api/v1/network/register/node/organization": dial tcp [::1]:5000: connect: connection refused
make: *** [e2e] Error 1

Underlying logs in core:
 docker compose logs -f firefly_core_0
firefly_core_0_1  | [2021-06-21T02:52:37.294Z] DEBUG Log level: debug pid=1
firefly_core_0_1  | [2021-06-21T02:52:37.295Z]  INFO Project Firefly pid=1
firefly_core_0_1  | [2021-06-21T02:52:37.295Z]  INFO © Copyright 2021 Kaleido, Inc. pid=1
firefly_core_0_1  | [2021-06-21T02:52:37.295Z] DEBUG Debug HTTP endpoint listening on localhost:6060 pid=1
firefly_core_0_1  | [2021-06-21T02:52:39.525Z]  INFO Shutting down due to terminated pid=1
firefly_core_0_1  | [2021-06-21T02:52:44.156Z] DEBUG Log level: debug pid=1
firefly_core_0_1  | [2021-06-21T02:52:44.156Z]  INFO Project Firefly pid=1
firefly_core_0_1  | [2021-06-21T02:52:44.156Z]  INFO © Copyright 2021 Kaleido, Inc. pid=1
firefly_core_0_1  | [2021-06-21T02:52:44.157Z] DEBUG Debug HTTP endpoint listening on localhost:6060 pid=1
firefly_core_0_1  | Error: FF10163: Database migration failed: FF10163: Database migration failed: Dirty database version 19. Fix and force version.
firefly_core_0_1  | Usage:
firefly_core_0_1  |   firefly [flags]
firefly_core_0_1  |   firefly [command]
firefly_core_0_1  |
firefly_core_0_1  | Available Commands:
firefly_core_0_1  |   help        Help about any command
firefly_core_0_1  |   showconfig  List out the configuration options
firefly_core_0_1  |
firefly_core_0_1  | Flags:
firefly_core_0_1  |   -f, --config string   config file
firefly_core_0_1  |   -h, --help            help for firefly
firefly_core_0_1  |
firefly_core_0_1  | Use "firefly [command] --help" for more information about a command.
firefly_core_0_1  |
firefly_core_0_1  | FF10163: Database migration failed: FF10163: Database migration failed: Dirty database version 19. Fix and force version.

Thanks for reporting this. I am working on a PR that also includes implementing your suggestion 1. I think these changes should fix this issue too. Hope to have that PR up soon.


Fail prerendering if page attempts to access session in load - fixes #3722

It doesn't make sense to prerender a page that tries to access session, as it can never be populated by the server. Similarly to how we throw if we try to prerender a page that has a mutative shadow endpoint, we now throw if a page tries to access session during prerendering. This exception can be skipped by setting continueOnError to true, but it will still warn users by logging the error to the console. Fixes #3722.
As is, this will fail on server-side requests while in dev as well (so that developers don't have to wait until they try to build for prod to get slapped in the face with it).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Hmm. Strange. I linted/checked locally...
I'll run again and push if necessary.

excellent, thank you!