"paths" & "base-paths" ignored in defaults.yaml

{
  "base-paths": "src/*/py"
  "paths": "src/*/py"
  "": {
    "base-paths": "src/*/py"
    "paths": "src/*/py"
  }
  "build": {
    "paths": "src/*/py"
    "symlink-install": true
    "cmake-args": "-DCMAKE_BUILD_TYPE=Debug"
  }
  "list": {
    "base-paths": "src/*/py"
    "paths": "src/*/py"
  }
}

None of the "paths" or "base-paths" verbs are respected by Colcon.
colcon list --paths-only --paths src/* src/*/py shows expected output
colcon list --paths-only does not

What about this?
{
  "build": {
    "paths": ["src/*/py"]
  }
}

https://colcon.readthedocs.io/en/released/user/configuration.html#values-for-command-line-arguments

Good find, but this is not it.
{
  "build": {
    "symlink-install": true
    "cmake-args": "-DCMAKE_BUILD_TYPE=Debug"
    "paths": ["src/*/py", "src/*"]
  }
}

Doesn't work.
It's parsed as YAML, so there is no need for commas.

Figured it out. colcon doesn't currently expand shell wildcards unless it's Windows: https://github.com/colcon/colcon-core/blob/a3a94b72a4d250ab1b05c379d64fe52936e11c04/colcon_core/package_discovery/path.py#L49-L50
So with:
$ colcon build --paths src/*/py src/*

colcon receives actual, expanded paths, but with:
{
  "build": {
    "paths": ["src/*/py", "src/*"]
  }
}

it literally receives a list with ["src/*/py", "src/*"].
Seems like we should consider expanding wildcards on all platforms, or at least expand them if the value was provided through a defaults.yaml file (if that's possible).
Note that the defaults.yaml logic/code is here: https://github.com/colcon/colcon-defaults

This says that wildcard expansion is only necessary on Windows: https://github.com/colcon/colcon-core/blob/a3a94b72a4d250ab1b05c379d64fe52936e11c04/colcon_core/package_discovery/path.py#L77
but given the stuff above it's necessary on all platforms. I wonder if there are any downsides to expanding on all platforms.
I've opened this PR: https://github.com/colcon/colcon-core/pull/439

As for --base-paths, it's the same problem here: https://github.com/colcon/colcon-recursive-crawl/blob/5915463cfffb600422d10d1750c93b9e896d7f67/colcon_recursive_crawl/package_discovery/recursive_crawl.py

I've merged your PR @christophebedard  to my installation, but the
{
  "build": {
    "paths": ["src/*/py", "src/*"]
  }
}

Still isn't respected by colcon

It seems to work fine for me. Can you provide all the commands you ran to install & use the branch from my PR?
Something like:
$ git clone https://github.com/christophebedard/colcon-core.git -b expand-shell-wildcards-in-paths-on-all-platforms
$ cd colcon-core
$ pip3 install .
$ pip3 list -v | grep colcon
...
colcon-core                   0.6.1                /home/USER/.local/lib/python3.8/site-packages pip
...

I opened a PR for --base-paths https://github.com/colcon/colcon-recursive-crawl/pull/22

@christophebedard Forgive my delayed reply. Personal issues.
I've now tried to do the installation like you've proposed and the output of pip3 list -v | grep colcon-core is:
colcon-core   0.6.1   /home/user/.local/lib/python3.8/site-packages  pip

it might not actually be installing the local version since it has the same version number. Maybe try pip3 install -e . instead? That's what I usually do.

@christophebedard
Output of pip3 list -v has changed, but the mentioned line in defaults.yaml still isn't respected. I've tried sourcing again the ros binaries, restarting the machine, reloading terminal session, nothing does the job. Still adding --paths to colcon build is the only way.


validate public key on merge

When we merge, let's make sure the public key matches.

Job #87 is now in scope, role is DEV

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

@yegor256/z everybody who has role DEV is banned at #87; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@rultor release, tag is 0.10.6

@yegor256 Done! FYI, the full log is here (took me 6min)

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@24b34ee2-112b-48ac-b25b-4b5b5639b958, thread: pool-320-thread-1
java.lang.Thread[-2] java.lang.OutOfMemoryError: unable to create new native thread

1.0-SNAPSHOT: Issue: yegor256/zold#87, Action: closed


feat(devtools): update react query logo to close devtools

Description
Added button wrapper on react query logo which onClick closes devtools window
Verification Process
Tested locally
Applicable Issue
Closes #3067

@TkDodo We can also add padding to the query list to allow scrolling past overlapping queries if needed.

We can also add padding to the query list to allow scrolling past overlapping queries if needed.

I think its fine as-is. you can always hide the close button via props if you want to.

:tada: This PR is included in version 3.39.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0-beta.14 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

This is my favorite change in recent versions.  Thank you!


Enhance redirect plugin to allow for trusted hosts

We're using the gentleman client to make calls to 1st party services that can result in redirects. Initially, we were using the 'Trusted' field of the plugin to ensure that any headers were forwarded. For security purposes, we wanted to add a capability and limit header forwarding to only our 1st party services so any potential redirection to a 3rd party service wouldn't end up exposing sensitive information. In order to accomplish this, we created a fork of the redirect plugin that includes a field for a list of trusted host suffixes before doing the header copying.
It would be great to have that feature as part of the upstream gentleman, and I'd be happy to put together a PR for it if there is interest. But I wanted to open an issue and check on feasibility before just dropping a PR on your doorstep.
Thanks!

PR are welcome!

It looks like this issue can be closed due to #56 being merged.

Closing!


Cron job exited after undefined amount of time

Hey there,
Thanks for your great work!
I'd like to ask whether anyone runs into the same problem. I built a cron job that checks my gmail inbox every 10 seconds using Gmail API.
The code runs fine but it quits running after a while.
By monitoring, I can see sometimes it quits after 3 hours, 8 hours or sometimes just around 15 20 minutes. I monitored the memory of the process but it looks like there is no memory leak issue since it take stably around 12MB when running for 1 minute.
Please comment if you ran into this problem or you have some clue about it.
Thank you,
Vu

It may have to do with the following: https://github.com/jasonlvhit/gocron/blob/master/gocron.go#L38

@jasonlvhit if you have a slice of a predefined size and simply don't want to append, when an overflow happens perhaps you can just flush and wrap back to the beginning?

Thanks @alexanderbez but I don't get it yet. Isn't that constant the number of jobs? I only have one job.

Ahhh good catch @LeeU1911, I'll keep poking around. It could something on the system level killing it like oom.

I am seeing this same issue. Job runs for sometimes one hour, sometimes four hours, then stops. No errors, app doesn't restart, but job just seems to stop running.
@preslavrachev @Streppel

@JohnRoesler strange... I have a job running for weeks with no problem. I'll investigate

I've been debugging on my end as well. It's running in docker. Tried increasing mem/cpu, still seeing it stop.

It's not that the job is actually stopping my case. There are no errors, it just takes long breaks on job that's scheduled to run every 5 minutes.
Here is a screen shot of logs over a 12 hour period:

Pretty sure it's not a resource issue as the docker container running the cron as an excessive amount of mem/cpu and usage is about 2% of resources.

Hi, currently I have this issue..
I have a simple job to run every  5s. But the job seems suddenly stop after a random amount of time
I run the service using systemd. With this configuration:
Description=Devops Redis Agent
After=network.target

[Service]
Type=simple
ExecStart=/usr/bin/devops-redis-agent
User=devops-agent
Group=devops-agent

[Install]
WantedBy=multi-user.target

for now, I add auto restart every hour in the systemd configuration.
PS, the CPU and memory load seems OK

@truztee this repo is no longer maintained sadly. Come checkout our fork that is very well maintained and updated! https://github.com/go-co-op/gocron

@truztee this repo is no longer maintained sadly. Come checkout our fork that is very well maintained and updated! https://github.com/go-co-op/gocron

ic... thank you for the information


SpringBoot executeable flag for AxonServer

Hello,
wouldn't it be useful to build the axonserver.jar with spring boot executeable flag on so we could set it up as a linux service directly?
More information here: https://docs.spring.io/spring-boot/docs/current/reference/html/deployment-install.html
What do you think?
Greetings

This issue escaped our attention, but if I'm not mistaken, the AxonServer executables delivered at the moment are executable.
If that doesn't work for you, somehow, feel free to comment on/reopen this issue.


Standardising x-trestle header fields for yaml

Issue description / feature objectives
Currently across our markdown documents yaml headers are used without any processing that will make much sense to an end user (excluding PRs in flight).
The current proposal is to use x-trestle- as a prefix for any headers that are used.
Currently in progress
x-trestle-ignore Yaml header fields to ignore
x-trestle-template-version: key-value pair fir
Proposed headers:
x-trestle-props: key, value namespaces for github properties to be inserted in the appropriate context.
e.g.
x-trestle-props:
- name
   ns
   value
- name
   ns
   value

x-trestle-responsible-role: Responsible role to be inserted into SSP.
x-trestle-set-param: set param in the current context by an assumed key-value lookup e.g
x-trestle-set-param:
    param_id_1: param_value
    param_id_2: param_value

Caveats / Assumptions
Completion Criteria

Central definition document used to outline the purpose of all x-trestle headers which is included and released in the docs site.
Issues generated for all of the trestle functionality.

Most of this is handled. If there is anything remaining a new issue would be created.


Add vld

Please add https://github.com/derickr/vld.

Added in https://github.com/shivammathur/homebrew-extensions/pull/3828


Cleanup quickstart role tasks

The tasks are no longer needed as we are using workloads framework
and clusterloader is part of the scale-ci-workload image.

Fixes https://github.com/openshift-scale/scale-ci-deploy/issues/14

@akrzos removed the additional commented out task. PTAL.


Add entrypoints to speaker and controller containers

As we may need to switch to one single image for both speaker and controller.

LGTM


iota.go TX and VM changes to reference Commitment and BIC

Solved by https://github.com/iotaledger/iota.go/commit/c094a3f788286940cbc66f4dca7165078c373fee


Cannot perform 2D DataArray assignment

Hi,
I might be missing something here, but I think it's a bug. This is my test code:
deye = @data(eye(10))
deye[1,1] = NA
# ERROR: MethodError: no method matching unsafe_getindex(::Int64, ::Int64)
# Closest candidates are:
# unsafe_getindex(::AbstractArray{T,N}, ::Any...)
# unsafe_getindex(::Colon, ::Any)
# [inlined code] from ./cartesian.jl:60
# in setindex!(::DataArrays.DataArray{Float64,2}, ::DataArrays.NAtype, ::Int64, ::Int64) at
# /home/hoangnt/.julia/v0.5/Compat/src/ngenerate.jl:56
# in eval(::Module, ::Any) at ./boot.jl:243

Confirmed on 0.5, but it works on 0.4. This is a DataArrays issue, not a DataFrames one.

Note that deye[1,1] = 1.0 also fails. The bug does not happen in the 1D case.
The problematic code (missing from the stacktrace) is here: https://github.com/JuliaStats/DataArrays.jl/blob/44192cf6261d6eed476018fb2770c5ca8dc4e9f2/src/indexing.jl#L190
Looks like simply adding this definition is enough to fix the problem:
Base.unsafe_getindex(x::Int, i::Int) = x[i]

@mbauman Any reason why this method isn't present in 0.5? Base.unsafe_getindex(1, 1) works in 0.4.5.

It's just no longer needed, replaced by @inbounds 42[1].  I knew it was frequently used, though, so I did keep a fallback for AbstractArray… but of course that doesn't cover numbers.

Thank you for the answer. Sorry, I should put this in DataArrays.

@malmaud But will it be fast on 0.4 too?
Also, if a fallback is present for some types, it should probably be added for all of them, or removed altogether.

Yeah, I didn't mean to break unsafe_getindex since it's pretty widely used (even if not exported or documented).  And, no, @inbounds won't remove that branch on 0.4.  That method can get restored.

Closing now that we no longer use DataArrays.


Fix makefile

Removed unused Makefile
Fixed Makefile for GNU environment

@uemoto1 san, thank you for your comments! Now I understand these makefiles in /makefiles/ are provided by the script.
I'm not sure whether mpifc is so common. For example, in my gnu environment, mpifc is not available. Thus, I'm afraid that many users face the same problem, and changed to mpif90, which would be rather common.

Okay, I understood. Presently, I will employ mpif90 to execute the compiler and continue to investigate the adequate command which used in the other project. Thank you!


Add test for non-404 error

Codecov Report

Merging #47 (04c82ac) into main (f4dbe39) will increase coverage by 4.76%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #47      +/-   ##
===========================================
+ Coverage   95.23%   100.00%   +4.76%
===========================================
  Files           1         1
  Lines          42        42
  Branches        7         7
===========================================
+ Hits           40        42       +2
+ Misses          2         0       -2

Impacted Files
Coverage Δ

src/new-issue-or-comment-for-label.js
100.00% <0.00%> (+4.76%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Quagga.onDetected not called on multiple==true

I really don't know why, but... when I set args.decoder.multiple: true to detect multiple barcodes at once, the Quagga.onDetected event is not called on successful scans.
In function publishResult() in quagga.js, hasCodeResult(result) is true on successful scans and _commonEvents2['default'].publish("detected", resultToPublish); is executed, but my onDetected callback is not hit. It seems that _commonEvents2['default'].publish isn't handling the callback, but it's a strange behavior...
If I set args.decoder.multiple: false, everything works fine and the onDetected callback is executed. The onProcessed callback is hit in both cases correctly...

Thanks for reporting this error. Are you experiencing this issue using a LiveStream or do you try to decode a static image?

I'm using the live stream.

I've fixed the issue. Could you please try again?

Yes, works. Thanks for the fast help!

Can either of you clarify if multiple property when set to true works with all barcodes in view. In my case i am trying to capture atleast 5 barcodes with multiple=true but i am seeing only one barcode in the resultCollector. Can someone help with this. I am trying to use quagga to scan code-128 and code-39.
Its urgent . Please reply.

To add to the above comment, i am using quagga.min.js


With syntex feature

I was running into this issue in the context of an iron web project, and tracked it back to textnonce. syntex can be optional with the optional inclusion of serde_macros. I mostly tried to match the manner of setting this up with your formdata crate.
I bumped the patch version number, but I don't know what best practices are for a minor change like this.

thanks


Working With JavaScript Timers

Proposed title of article
Working With Javascript Timers
Introduction paragraph (2-3 paragraphs):
A timer is a function that enables execition of a function in a particular time.Using timers you can delay the execution of code so that it does not get done at the exact moment an event is triggered or the page is loaded.
For example, you can use timers to change the advertisement banners on your website at regular intervals, or display a real-time clock, etc. There are two timer functions in JavaScript:.setTimeout() and setInterval().
Key takeaways:
1.importance of javascript timers
2.setTimeout() function
3.setInterval() function
4.Application of Javascript Timers
References:
N/A

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it. @fabulousDesigns

@fabulousDesigns, you are only allowed one topic suggestion at a time to be considered. Closing in favour of #2951.
You can reopen this once that topic suggestion has been written and published.


impl(pubsub): add modack span for lease management

https://github.com/googleapis/google-cloud-cpp/issues/13726
We will need to handle the exactly once modack's in a different way.
In our TracingBatch callback, we store a map from ack id to subscribe span. The modack span is unique because it is a bulk operation (multiple ack ids) and could have multiple outstanding modacks with the same request. To work around this, I assign each outstanding request a nonce and track it that way.

This change is

Reviewable status: 0 of 9 files reviewed, 3 unresolved discussions (waiting on @alevenberg)

google/cloud/pubsub/internal/streaming_subscription_batch_source.cc line 239 at r2 (raw file):

  lk.unlock();
  for (auto& r : split) {
    std::unique_lock<std::mutex> lk(mu_);

Could you reuse the existing lk and just lk.lock() here instead of creating a new std::unique_lock?

Sure done.

google/cloud/pubsub/internal/tracing_batch_callback.cc line 200 at r2 (raw file):

        std::vector<std::pair<opentelemetry::trace::SpanContext, Attributes>>;

    if (request.ack_ids().empty()) {

Just make this a single line if (request.ack_ids().empty()) return;

Done

google/cloud/pubsub/internal/tracing_batch_callback.cc line 234 at r2 (raw file):

    }
    lease_span_by_nonce_[nonce] = span;
    lk.unlock();

nit: lk gets unlocked as it goes out of scope.

Done

Removed the mac + cmake from required. I'll see if I need to remove the other GHA builds.


update the npm package with latest from master

Hey guys, I've been using your tool and found the latest published version npm is missing the devHost option in the configuration.
Expected Behavior

The current package published in npm doesn't support the option devHost, but it's already implemented here.
Possible Solution

Publish the latest from master to npm.

@rrivem  ill get this pushed soon


Fix for filteredItems in async loading data

When loading data in async mode into the directive, if ngModel had already preloaded data, the filter was not applied correctly. This issue was due to behaviour of Array.indexOf prototype method. When comparing arrays of objects, the comparison is made by object reference and always fails.
Switched to angular.isEqual for in depth comparison of objects (this also aids to get rid of $ prefixed variables that angular adds to objects)

This issue has been resolved and merged with PR #1473


Implement new feature

Objective
I need to add the new feature that is a way to decode basic auth plus the standard one.
I mean, first the credentials should be encrypted using cryptography library first to encode the credentials and the result to be send in basic auth, so after decoding in base64 then the new feature do the work to decode the result with the cryptography decodification.

This feature is not necessary, you can manage the decodification by yourself in the decorator of verify_bauth_credentials in the momento youre validating the credentials received from basic auth, so there you can do the extra decodification in the function that has the verify_bauth_credentials decorator.


Setter from the TestNG class should not fail with exit

Expected behavior
TestNG#set* should not fail with exit but throw an exception or warn + using default value.
At the opposite, CLI must display the appropriate message.
For example, TestNG#setThreadCount(int) should throw an IllegalArgumentException or use 1 as default value if the passed value is <1.
Actual behavior
TestNG exits and displays the CLI usage (even if TestNG wasn't run by CLI).
From https://github.com/easymock/easymock/pull/186#discussion_r85662260

@cbeust What do you prefer? IllegalArgumentException or warn + default value?

@juherr - In a typical use case, I think throwing a exception makes sense. A user is intending to override the threadcount by trying to pass in a value due to some specific need. But if there is a problem (as in this case, wherein the JVM argument was intended to be used to pass the thread count, but its not being done so, due to some oversight), then we should be explicitly throwing an exception and letting the user know. Sometimes, the warnings that we throw at people can be lost and the users may not pay attention to them. At-least this is my opinion.

As pointed by @Tibor17, the documentation says It will only take effect if the parallel mode has been selected (for example, with the -parallel option). Maybe we can ignore the value in that case.
https://issues.apache.org/jira/browse/SUREFIRE-1300?focusedCommentId=15659321&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15659321


Make TagImpl public to allow constructing tags manually

This improves integration into other crates / interoperability. Specifically, I want to fuse osm-xml and osmpbfreader-rs. Making the TagImpl public would really help because I can create key-value pairs without iterating / inserting (possible performance gain).

Thanks for the contribution. Waiting for travis to finish before merging. Will publish on crates.io just after.
If you have any idea to improve the interface/performances/interoperability, I'm open to any improvement!

Crates.io updated.

Yes, there are things I noticed, however I'll make a seperate issue for those.


MISSING_ARGUMENTS: api_key

I receive that API response when I try to run the following :
var searchImageResponse = client.Face_Detect(null, image_url:"https://miro.medium.com/max/578/1*Db5cCH72jLsV5lrgdAs78Q.jpeg", return_attributes: "eyegaze", return_landmark:1);
Are you sure we are suppose to be using multipartFormDataContent when posting?

I have this problem too.
I will start an intensive debug session to find out what the hell is happening here. With a manually fabricated HTTP POST request, (using curl) I was able to communicate with the server. Somwhere is something weird happening. Maybe I will trace down the request body using wireshark, to see what has been sent out, since the request generation is pretty complex on the SDK.

BTW if you have found the solution since then, notify me :D I need this SDK hardly for my thesis, and I lack the time to implement my own from scratch.

According to the Face++ API Documentation:

Parameter
You need to pass the parameters according to the requirements of each API. Please turn to the API Reference for more details. Each API request must be POST request. You can add the parameters in the form of Query String, and use multipart/form-data to upload image files.

Source: https://console.faceplusplus.com/documents/7078057
So yeah, multi-part form data is totally inappropriate for communicating with the API, except images.
I think I have to rewrite the request generation totally, to be able to use this API. It's a pity. My guess is that the API accepted the parameters in multi-part form data in the past, but that has been changed since then.
If I make any progress with the rewrite, I'll make a PR.


Update to 1.20.1/1.20.2

Can we get update for this mod?

agreed, its needed

yes please

guys what if they died


Implement isort add_imports option

It would be handy if we could have isort's add_imports configuration option.
This is quite often used to add from __future__ import annotations:
[tool.ruff.isort]
add_imports = ["from __future__ import annotations"]

It's probably relatively straightforward to also implement remove_imports at the same time.
There are also --add-import and --remove-import command line options, but not sure how widely used they are.

We support this! It’s just under a different name: https://github.com/charliermarsh/ruff#required-imports
Hopefully that helps, but just LMK if I need to reopen.

Huh. How did I keep overlooking that? 🤦♂
And I see #1749 will cover converting configuration.
Thanks 😄


Guppy fails to run on combine-3.8.1

When trying to run guppy on an older version of combine, combine 3.8.1,  guppy fails with below error:

CommandError(CargoMetadata { stderr: "    Updating crates.io index\nerror: failed to select a version for the requirement partial-io = \"=0.3.0\"\ncandidate versions found which didn't match: 0.5.0, 0.4.0, 0.3.1\nlocation searched: crates.io index\nrequired by package combine v3.8.1 (/private/var/folders/0d/58w3rsls6sjfrwhfrfyxhtym0000gn/T/.tmpPUg1q7/combine-source)\n" })

The Cargo.toml file in this case declares partial-io = { version = "0.3", features = ["tokio", "quickcheck"] }. However, crates.io does not host any version below 1.0.0-beta2 which may be a reason for failure.

Yeah, the older versions of partial-io were removed. Please upgrade to a newer version.


virtualenvwrapper: realpath not available on Mac OS X

Hi
If you're activating the virtualenvwrapper in OS X, you'll get an endless loop of errors:
...
workon_cwd:6: command not found: realpath
workon_cwd:6: command not found: realpath
workon_cwd:6: command not found: realpath
workon_cwd:6: command not found: realpath
workon_cwd:6: command not found: realpath
...

It will be used in the workon_cwd function in plugins/virtualenvwrapper/virtualenvwrapper.plugin.zsh:
  function workon_cwd {
    if [ ! $WORKON_CWD ]; then
      WORKON_CWD=1
      # Check if this is a Git repo
      PROJECT_ROOT=`pwd`
      while [[ "$PROJECT_ROOT" != "/" && ! -e "$PROJECT_ROOT/.venv" ]]; do
        PROJECT_ROOT=`realpath $PROJECT_ROOT/..`
      done

There's a workaround on OS X by disabling the feature:
export DISABLE_VENV_CD=1

https://github.com/robbyrussell/oh-my-zsh/pull/4025 should fix the problem.

duplicate of #4030

fixed by #4106

Could you update your OMZ, and close this issue if #4106 fixed it for you?

yay it works again :+1:
awesome work mates, awesome! thanks!


Pulsar PubSub: allow TLS configuration for hostname and insecure connections

Description
When connecting to pulsar with TLS enabled set the prefix to be pulsar+ssl:// if a prefix was not set when defining the host. Allow setting the TLSAllowInsecureConnection and TLSValidateHostname options when connecting to pulsar. They default to the pulsar client's default.
Issue reference
Please reference the issue this PR will close: #1860
Please reference the issue this PR will close: #3269
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[X] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#3903

@berndverst Integration tests have been added for pulsar

@toneill818 the Pulsar certification test is failing - see the build check

@toneill-newinnov the pulsar certification test is still failing

@yaron2 I'll keep looking into this. It isn't timing out while I run the tests locally.

@toneill818 v the certification tests are all failing, please take a look


module.exports = function(options={}) {

Hi )
What is it?
module.exports = function(options={}) {
And this...
let {outfile, acssConfig, cssOptions, addRules} = options

Looks like you already got your answer, but it's ES2015 default parameters and destructuring.
module.exports = function(options={}) { Makes options have a default value of {} rather than undefined.
let {outfile, acssConfig, cssOptions, addRules} = options is equivalent to the following:
let outfile         = options.outfile
let acssConfig = options.acssConfig
let cssOptions = options.cssOptions
let addRules     = options.addRules

This article will explain more: https://ponyfoo.com/articles/es6-destructuring-in-depth
I wouldn't have used these "new-fangled" features for a browser-based module without a transpiler.  But these language features are already supported in the current LTS release of node so I have no problem using them there.


add/revamp "Topic and lessons you're comfortable teaching"

A number of LC, DC and Spanish lessons are missing from the "Topic and lessons you're comfortable teaching" section of the instructor profile. For instance:

Missing LC lessons including: Data intro for librarians, Data intro for archivist, Unix Shell, OpenRefine, Webscraping, Python, SQL
Currently a number of Data Carpentry Lessons are listed  by topic (R, Python, spreadsheets) but it isn't clear how they related to specific workshops (ecology, genomics, social science).
There is no mention of the Spanish versions of Unix, Git, R, (all SWC) or Python (DC). In theory, someone's ability to teach these could be obtained by looking at what languages a instructor is fluent in, but fluency != comfortable teaching.

Here's a screen shot to view the current list of offerings. I'm not sure what is the best way to go about updating these, but I think a priority would be to add LC and then possible considering how the DC and spanish lessons are presented.

@raynamharris I'm open for suggestions on how this should look.
Maybe instead of "lessons" we should have "topics/technologies" (Python, R, OpenRefine, SQL, R-visualization, Shell, etc.), and additionally ask people for curricula they feel comfortable teaching (see screenshot below for list of curricula in AMY).

Thanks @pbanaszkiewicz! I like this a lot! My only concern is that instructors can no longer check that they are comfortable teaching, for instance, only shell but not git, r, or python. I like your suggested groupings, but it might be an issue for others. Perhaps @maneesha can weigh in on what would be most useful for helping find and place instructors in workshops.
(Also, I didn't realize I mentioned this back in May. Thanks for finding and linking the related issues.)

Thanks for adding the issue @raynamharris! It's a great idea to update that list. In our current workflow, we don't use this part of the Instructor profile for anything, but we have talked about in the future being able to use it for Instructor teaching assignments (to make it easier to identify candidates to teach a workshop).
Since the Workshop Administration team would be the ones making use of this information in this use case, I want to make sure that their needs for this information are considered before making any changes. @maneesha @sheraaron - could you please weigh in on this revamp? What would be the most useful way to organize this information? Please also give a sense of urgency - how much of a priority is this? Should it be included in this release? Or is a later release ok? @libcce should also be asked about what should be listed in terms of LC curriculum.

Our core curriculum should be listed which you can find here:
https://librarycarpentry.org/lessons/
The core lessons are:
Intro to Data
Unix Shell
OpenRefine
Git

Library Carpentry options are expanded in issue #1419.
As far as expanding this to allow instructors to choose lesson modules rather than entire curricula, I'll discuss this more with our workshop admin team and will follow up... likely not until January though!

Hello everyone, thanks for your input. Issue #1419 mentioned by @Maneesha is going to be merged in this release. Please remember it only affects "Curricula" in AMY; this current issue, though, is about "Lesson" objects. They're only used to indicate what person feels comfortable teaching, and nowhere else.

@pbanaszkiewicz Can we make the workshops_lesson table modifiable from the Django admin panel?

@maneesha actually it is. If you go to AMY, click top-right menu, follow with "Django Admin" link, then look for "Lessons" under "WORKSHOPS" label you'll be able to add/edit/remove the lessons.

@maneesha does that solve this issue?

Yes, thanks @pbanaszkiewicz
I'm going to keep this open for myself but there's nothing else we need from you.

Closing this here as it's being discussed in #1513


Mounts using builder pattern rather than constructor

Instead of constructing mounts using a singular path + optional filter function, this lets the user add path's to mounts iteratively:
mount = modal.Mount()\
    .add_local_dir("/home/my/project")\
    .add_local_file("/home/my/logo.png", remote_path="/project/logo.png")

Besides allowing more complex mount structures, this also makes the old remote_dir argument optional.
TODO:

[x] More test cases
[x] Fix broken stuff
[ ] Add deprecation warning when using old constructor?

@freider do you intend to merge this? I'm supportive!

@freider do you intend to merge this? I'm supportive!

Yes! I kinda forgot about it over christmas but now remembered it when I saw your other mount PR :)
I realized there is one outstanding tricky thing with the builder pattern - how to handle the repr needing to be created in the constructor? Since we don't know anything about the contents of the Mount at that point, the repr wouldn't really be able to say much?

Oh, a windows test is failing... Investigating

@freider wdyt about removing the constructor and having static methods local_file and local_dir? Something like
mount = modal.Mount
    .local_dir("/home/my/project")\
    .add_local_file("/home/my/logo.png", remote_path="/project/logo.png")

That way the syntax is slightly more consistent with "simple" mounts: modal.Mount.local_dir("/home/my/project") etc


Convert build commands to new pattern

Are we comfortable that existing tests will cover all of this refactoring?


Allow to export specific row

From what i see there is no option to export specific row but all the table . I think its nice to add an option like --id=14

@aristain7 Currently, I'm a bit busy with other tasks and cannot find time for these kinds of features, maybe I'll try to do it in next coming months. But if you want, you can do it!
Thank you!


sessionAuthenticationSucceeded event.

I want to overwrite sessionAuthenticationSucceeded event to extend the behaviour after transition.
Like this:
import Ember from 'ember';
import ApplicationRouteMixin from 'simple-auth/mixins/application-route-mixin';

export default Ember.Route.extend(ApplicationRouteMixin, {
  actions: {
    sessionAuthenticationSucceeded: function() {
      this._super().promise.then(function() {
        // Do something great after transition to Configuration.routeAfterAuthentication.
      }
    }
  }
});

But I'm getting a problem because of sessionAuthenticationSucceeded event is not returning the transition.
The problem is here:
https://github.com/simplabs/ember-simple-auth/blob/master/packages/ember-simple-auth/lib/simple-auth/mixins/application-route-mixin.js#L155
I think it should be:
return this.transitionTo(Configuration.routeAfterAuthentication);

What do you think. Am I missing something?

When you want to do sth. after the transition you should probably do that in the route you're transitioning to.

I want to do something only when the transition goes from login to index route. If I do that thing in the route I'm transitioning to I'll get that thing every time I reload the page, right?
I want to set an alert message with a text like ''Signed in successfully". I do this in the route I'm transitioning to I'll get the message even when I reload the page.
Am I missing something?

Sure, you're right. In that case though it's probably better to do that where you call the session's authenticate method, e.g.
this.get('session').authenticate(…).then(() => {
  // show the flash message here
})

If I do this:
this.get('session').authenticate(…).then(() => {
  // show the flash message here
})

The callback is getting executed before the route I'm transitioning to has executed its route hooks (beforeModel, setupController, renderTemplate, etc). I think that it is not a good place to put that functionality.

The most obvious place to add it's after transition has finished.
Why isn't this a good solution?
return this.transitionTo(Configuration.routeAfterAuthentication);

You can simply override the application route's sessionAuthenticationSucceeded event (or not use the mixin at all and handle the session events manually - ApplicationRouteMixin is actually just an optional convenience mixin). Be aware thought that transitionTo doesn't return a promise that resolves after the transition completes but a transition object.


On Android regionCode: null, but currencyCode is recognized

Flutter Version Details
Flutter 3.10.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 796c8ef792 (3 months ago) • 2023-06-13 15:51:02 -0700
Engine • revision 45f6e00911
Tools • Dart 3.0.5 • DevTools 2.23.1
Adapty SDK Details
adapty_flutter: ^2.6.2
Issue Details
I am successfully retrieving paywall products in my iOS and Android app, but I'm getting a different value for "localizedTtitle" for both platforms. I think it might have something to do with regionCode being null on Android.
On iOS, both the local currency AND the region code are recognized and they match, as expected.
However on Android, Adapty is recognizing the correct local currency, but the regionCode is null.
Please see the product data that I'm retrieving from Adapty on iOS vs. the product data that I'm retrieving from Adapty on Android:
iOS (recognizes region code and currency)
(
	vendorProductId: adapty.1year_sub,
	localizedDescription: Billed Once Per Year,
	localizedTitle: Annual,
	regionCode: NZ,
	isFamilyShareable: false,
	paywallVariationId: ----------------------------------,
	paywallABTestName: Mobile App Paywall,
	paywallName: Mobile App Paywall,
	price: (
		amount: 49.99,
		currencyCode: NZD,
		currencySymbol: $,
		localizedString: $49.99
	),
	subscriptionDetails: (
		subscriptionGroupIdentifier: -------,
		subscriptionPeriod: (
			unit: AdaptyPeriodUnit.year,
			numberOfUnits: 1
		),
		localizedSubscriptionPeriod: 1 year,
		introductoryOffer: [],
		promotionalOffer: null,
		androidOfferId: null,
		androidBasePlanId: null,
		androidOfferTags: [],
		renewalType: AdaptyRenewalType.autorenewable,
		_androidIntroductoryOfferEligibility: null
	)
)

Android (currency is recognized as NZ, but region code is null)
(
	vendorProductId: adapty.yearly.premium,
	localizedDescription: ,
	localizedTitle: Annual Subscription (<PRODUCT_NAME>),
	regionCode: null,
	isFamilyShareable: false,
	paywallVariationId: -------------------,
	paywallABTestName: Mobile App Paywall,
	paywallName: Mobile App Paywall,
	price: (
		amount: 59.99,
		currencyCode: NZD,
		currencySymbol: $,
		localizedString: $59.99
	),
	subscriptionDetails: (
		subscriptionGroupIdentifier: null,
		subscriptionPeriod: (
			unit: AdaptyPeriodUnit.year,
			numberOfUnits: 1
		),
		localizedSubscriptionPeriod: 1 year,
		introductoryOffer: [],
		promotionalOffer: null,
		androidOfferId: null,
		androidBasePlanId: adapty-yearly-base-plan-test,
		androidOfferTags: [],
		renewalType: AdaptyRenewalType.autorenewable,
		_androidIntroductoryOfferEligibility: AdaptyEligibility.ineligible
	)
)

Ultimately, I should be able to set the localizedTitle in the Play Store, but I haven't found where I can set it. However even if I do set it, shouldn't the regionCode match the price currencyCode?

Okay, for anyone else having trouble with this, I mostly figured out where localizedTitle is coming from when using Adapty in conjunction with the Google Play Store. If you go to the Play Console and go to your app, then go to "Monetize -> Products -> Subscriptions" then click on the subscription you want to change the localizedTitle for, then hit "Edit Subscription Details" and change the "Name" field.
HOWEVER, Adapty will not be aware of this update (as it is probably cached) and simply re-loading the paywall did not reflect those changes (for me, at the time of this writing).
In order to refresh this name when showing the paywall to have it accurately reflect what you set in the Google Play Store, you'll have to go into the Adapty console, head to "Paywalls & Products" then click "Products", then edit a product, click "Google Play" and remove the information about the product like Google Play Product ID, Base Plan ID, and Legacy fallback product, then hit save. Go back into the product and then add the information back as it once was, hit "Save" and then Adapty will pull down the new name.
For me, this also included pricing changes that I made in the Google Play Store not being reflected in the Adapty paywall.

hi @tiyberius
you are right, localizedTitle comes from App Store and Google Play as is, from the correspondent fields, we don't modify them in any way


[TDX-1630] OIDC: share email as Admin and Dev

Summary

add Authenticate Dev Portal with OIDC section

Reason
Closes TDX-1630
Testing
https://deploy-preview-3388--kongdocs.netlify.app/hub/kong-inc/openid-connect/#authenticate-dev-portal-with-oidc

Sorry for the late comment. It is possible that this doc will no longer be needed with some work that @jeffyongtaotang is doing to the admin OIDC flow. His work will change how Admins usernames are generated, which will prevent the unique conflict with developers. I will confirm with @thao2021, but for now we may want to hold off on merging this.

@falondarville The new copy looks good to me.
@nateslo Please let me know which ticket I can look at for the changes to admin OIDC flow by Jeff that you mentioned.

@falondarville We can close (without merging) this PR since it is no longer needed based on changes in https://github.com/Kong/kong-ee/pull/2744


Issue in downloading file

For downlaoding i use DownlaodFile, i get the download location at data/data/"my app id"/files/.... but the problem is i get diffenent file,
I try to upload a file by using UploadFile and get their fileId and use same fileId to download file either I get "invalid file Identifier" error or different file, sometimes file locations is same after i change to different file id.

In UploadFile i get object fileid same as I get in DownlaodFile object fileid, both are same but file are changed

UploadFile must never be used by the apps, unless they want to upload a file without actually creating a message. In apps this is usually needed only for being recorded voice/video notes. If you want to send a message, you need to use sendMessage directly.

so the question is how i able to get that voice/video notes, I use downlaodFile with id i get from updatefiles from uploadfile, but i get different file

how the file id look like as  in number(234 or 322 or 234) found in the local section  or like "AQADBQADCq8xG6IhqVYACAMAA6aSUywBAAMXVd6cnYpRoCME" string found in the remote section, I'm using fileId in the local section

tdlib uses local database to store information.

thank you for quick response, am i using right file id? I got difficulty in downlaod file uploaded in telegram, firstly i use uploadfile but later @levlam  suggest me to use sendMessage rather than uploadfile, so i did but i didn't file, i get wrong file identifier error or sometimes wrong file
file = File {         id = 661  ----------------------------------------> this is my fileid?         size = 633861         expectedSize = 633861         local = LocalFile {           path = "/storage/emulated/0/Download/EAadhaar_0648177110118420220614141806_2106202216456.pdf"           canBeDownloaded = true           canBeDeleted = false           isDownloadingActive = false           isDownloadingCompleted = true           downloadOffset = 0           downloadedPrefixSize = 633861           downloadedSize = 633861         }         remote = RemoteFile {           id = "BQACAgUAAx0EWdQL3AADA2K3070k_3wH4Y5-bGM9Eqhe2DIpAAK4BgAC2TfAVe2g9Yu8K1Q5IwQ"           uniqueId = "AgADuAYAAtk3wFU"           isUploadingActive = false           isUploadingCompleted = true           uploadedSize = 633861         }       }     }

for downloading above file as their file id is 661 i use code as
`TdApi.DownloadFile downloadFile = new TdApi.DownloadFile(661, 1, 0,0,true);
            client.send(downloadFile, new Client.ResultHandler() {
                @Override
                public void onResult(TdApi.Object object) throws IllegalAccessException {
                    switch (object.getConstructor()) {
                        case TdApi.Error.CONSTRUCTOR:
                            System.err.println("Receive an errori:" + newLine + object);
                            break;
                        case TdApi.Ok.CONSTRUCTOR:
                            break;
                        case TdApi.File.CONSTRUCTOR:
                            Log.i("notthisone", object.toString());

                    }
                }
            });`

I get log of
I/notthisone: File {       id = 661       size = 59309       expectedSize = 59309       local = LocalFile {         path = "/data/data/com.promiseek.cloudo/files/profile_photos/4212067018824853417_1.jpg"         canBeDownloaded = true         canBeDeleted = true         isDownloadingActive = false         isDownloadingCompleted = true         downloadOffset = 0         downloadedPrefixSize = 59309         downloadedSize = 59309       }       remote = RemoteFile {         id = "AQADBQADqacxG6NEdDoACAMAA6NEdDoABHL9ZO19O4yzIwQ"         uniqueId = "AQADqacxG6NEdDoB"         isUploadingActive = false         isUploadingCompleted = true         uploadedSize = 59309       }     }
look they both have smae fileid but file is change from pdf to jpg and when i when to the file location, i get completely differnet image, that i didn't know in my life here is the image

Am I doing something wrong in my coding please help me,

Make sure you are trying to download file from the same tdlib instance local file id received from.

yes, that I do above code, i get same file id from uplaoding to downloading but file are change, I share the code of uploading
`client.send(new TdApi.SendMessage(l,
0, 0, null, null, messageContent),
new Client.ResultHandler() {
@Override
public void onResult(TdApi.Object object) throws IllegalAccessException {
switch (object.getConstructor()) {
case TdApi.Error.CONSTRUCTOR:
System.err.println("Receive an error:uploading section" + newLine + object);
break;
case TdApi.Ok.CONSTRUCTOR:
                                                    break;
                                                case TdApi.Message.CONSTRUCTOR:
                                                    Log.i("objectss", object.toString());

                                                    TdApi.Message message = (TdApi.Message) object;

//                                                UploadingIndicator uploadingIndicator = new UploadingIndicator();
//                                                uploadingIndicator.execute((int) message.id);
long totalMessageSend;
                                                    TdApi.MessageContent content = message.content;
                                                    if(content.getConstructor() == TdApi.MessagePhoto.CONSTRUCTOR){
                                                        TdApi.MessagePhoto messagePhoto = (TdApi.MessagePhoto) content;
                                                        TdApi.Photo photo = messagePhoto.photo;
                                                        TdApi.PhotoSize[] photoSize = photo.sizes;
                                                        TdApi.File file1 = photoSize[0].photo;
                                                        TdApi.LocalFile localFile = file1.local;

                                                        Log.i("fileIddd1", String.valueOf(file1.id));
                                                        FilePogo uploadingPogo = new FilePogo();

                                                        //set name
                                                        uploadingPogo.setName(localFile.path.substring(localFile.path.lastIndexOf("/")+1));

                                                        //set size
                                                        uploadingPogo.setSize(String.valueOf(file1.size));

                                                        //set fileId
                                                        uploadingPogo.setFileId(String.valueOf(file1.id));

                                                        //set Date
                                                        uploadingPogo.setDate(String.valueOf(message.date));

                                                        totalMessageSend= snapshot.getChildrenCount()-1;
                                                        firebaseDatabase.child(phoneNumberFromSp).child("upload").
                                                                child(String.valueOf(totalMessageSend)).setValue(uploadingPogo);

                                                    }else if(content.getConstructor() == TdApi.MessageVideo.CONSTRUCTOR){
                                                        TdApi.MessageVideo messageVideo = (TdApi.MessageVideo) content;
                                                        TdApi.Video video = messageVideo.video;
                                                        //here you get filename |^

                                                        TdApi.File file1 = video.video;
                                                        //here you get size and file id

                                                        FilePogo uploadingPogo = new FilePogo();

                                                        //set name
                                                        uploadingPogo.setName(video.fileName);

                                                        //set size
                                                        uploadingPogo.setSize(String.valueOf(file1.size));

                                                        //set fileId
                                                        uploadingPogo.setFileId(String.valueOf(file1.id));

                                                        //set Date
                                                        uploadingPogo.setDate(String.valueOf(message.date));

                                                        totalMessageSend= snapshot.getChildrenCount()-1;
                                                        firebaseDatabase.child(phoneNumberFromSp).child("upload").child(String.valueOf(totalMessageSend)).setValue(uploadingPogo);

                                                    }else if(content.getConstructor() == TdApi.MessageAudio.CONSTRUCTOR){
                                                        TdApi.MessageAudio messageAudio = (TdApi.MessageAudio) content;
                                                        TdApi.Audio audio = messageAudio.audio;
                                                        //here you get filename |^

                                                        TdApi.File file1 = audio.audio;
                                                        //here you get size and file id

                                                        FilePogo uploadingPogo = new FilePogo();

                                                        //set name
                                                        uploadingPogo.setName(audio.fileName);

                                                        //set size
                                                        uploadingPogo.setSize(String.valueOf(file1.size));

                                                        //set fileId
                                                        uploadingPogo.setFileId(String.valueOf(file1.id));

                                                        //set Date
                                                        uploadingPogo.setDate(String.valueOf(message.date));

                                                        totalMessageSend= snapshot.getChildrenCount()-1;
                                                        firebaseDatabase.child(phoneNumberFromSp).child("upload").child(String.valueOf(totalMessageSend)).setValue(uploadingPogo);

                                                    }else if(content.getConstructor() == TdApi.MessageDocument.CONSTRUCTOR){
                                                        TdApi.MessageDocument messageDocument = (TdApi.MessageDocument) content;
                                                        TdApi.Document document = messageDocument.document;
                                                        //here you get filename |^

                                                        TdApi.File file1 = document.document;
                                                        //here you get size and file id

                                                        FilePogo uploadingPogo = new FilePogo();

                                                        //set name
                                                        uploadingPogo.setName(document.fileName);

                                                        //set size
                                                        uploadingPogo.setSize(String.valueOf(file1.size));

                                                        //set fileId
                                                        uploadingPogo.setFileId(String.valueOf(file1.id));

                                                        //set Date
                                                        uploadingPogo.setDate(String.valueOf(message.date));

                                                        totalMessageSend= snapshot.getChildrenCount()-1;
                                                        firebaseDatabase.child(phoneNumberFromSp).child("upload").child(String.valueOf(totalMessageSend)).setValue(uploadingPogo);

                                                    }
                                                default:
                                            }
                                        }

                                    });

                        }`

can i get some code where downloading and uplaoding are done


Price values are wrong in the PDF invoice

The tax in my shop is configured to be included in the price and I'm programmatically creating the product by providing the price (that includes the tax). However, in the PDF generated, the values regarding the price don't make sense:

TTC = price including tax
HT = price without
As you can see, "Prix HT" is higher than "Prix TTC unitaire" which is not normal. Same for "Total TTC" that should be "80 €".
While in the backoffice, the values are correct:

My temporary fix was to override the pdf.html.twig template and copy/paste the html from @SyliusAdmin/Order/Show/_summary.html.twig (with some adjustments regarding the css classes, etc.) and now the data in the PDF is correct:

Invoice is merely represents all taxes as excluded from price, which doesn't make price values incorrect.
If there is some legal case, where invoice must contain taxes included in price, please present it.

Having a configuration option to include taxes in unit prices would be a nice feature.
Here in Switzerland it's very common to include taxes in all listed Prices.
Maybe having the option to display both a unit net price excluding taxes, and a unit price including taxes would be a good compromise.

Should be fixed by #307


Documentation has lot of errors

Hi, the documentation has errors and typos whereby the code is not workable.
In config missing a comma, no end on some defs, etc.
Also it returns the following error:
Lapin.Worker is not loaded and could not be found
Am trying this in latest Elixir in Phoenix 1.4

Hi @AppyCat, I'm sorry you are experiencing trouble. Which version of Lapin are you running?
Also, feel free to open a PR to fix outstanding documentation issues or point them out so that I can fix those.


Use OSSALifetimeCompletion in PredictableMemOpt

The current algorithm to complete lifetimes is incorrect in a few cases. Use OSSALifetimeCompletion instead.
Fixes rdar://119204768

@swift-ci smoke test

@swift-ci smoke test

https://forums.swift.org/t/non-deterministic-5-10-compiler-failures-from-predictablememoryaccessoptimizations-and-swift-5-10/72630
@meg-gupta By any chance was this a fix for what looks like some non-deterministic crashes from 5.10?

@vanvoorden This PR fixed an issue that would have been raised by ownership verification. It looks like your crash is somewhere in the type system. Will be helpful if you can provide a reproducer for the issue you are seeing.

It looks like your crash is somewhere in the type system.

@meg-gupta Hmm… looks like https://github.com/apple/swift/pull/71241 and https://github.com/apple/swift/pull/71730 landed in 6.0… would that look related to what I am seeing in 5.10?

Will be helpful if you can provide a reproducer for the issue you are seeing.

I don't have a clean repro yet… sorry about that. I can keep trying to see if I can find something that crashes consistently in a new package.

@meg-gupta I think I might have found a repro. https://github.com/swiftlang/swift/issues/74609. Thanks!


Reply webmention doesn't contain proper author h-card

I received a reply: https://writing.exchange/@matt/101066523112656548 this came through as a reply webmention. The author h-card has an empty photo and the name is equal to the url rather than being the username.
I know the ActivityPub to webmention isn't using the mf2 from mastodon, but looking at the mf2 on the reply page, it does contain an accurate author h-card: http://pin13.net/mf2/?url=https%3A%2F%2Fwriting.exchange%2F%40matt%2F101066523112656548

hey, thanks for the report, and sorry for the trouble! looks like a straightforward bug, will fix.

No worries 🙂 glad it seems like a straightforward bug!


VRTK Gizmos All Black

I get black gizmos on vrtk objects in scenes.
Github VRTK c56e207
Unity 5.4
In editor only
Disabling them in the drop down will remove the black circle from the objects.

Fixed with https://github.com/thestonefox/VRTK/commit/420d8445107e60a54f4311274430354fba5a9a77


Port some types to GNOME 46

See #21

I've started to go through my extensions; this is from the simpler ones.  The more complex ones are still to come, and I expect that this PR will take a few days to complete.  Opened a draft anyway to collect feedback as I go.
I've added a GNOME 46 comment to every type I've check to help me keep track of things.  I can remove those comments are this is finished again, but perhaps it's helpful to track which types are GNOME 46 already?  Perhaps it could be formalized to some degree?

@swsnr If you change the GNOME 46 comments to /** @version 46 */, you are welcome to leave them in 👍
Preferably with further information if you know it.

@JumpLink I've changed the annotations to your style.
Not sure though, what you mean with "further" information… my idea was just to mark every type which has been scrutinized for GNOME 46, to keep track of things, and inform other people looking at this that they perhaps don't need to look at these types again.  What further information should I provide?

Wrt to https://github.com/gjsify/gnome-shell/pull/23#issuecomment-2023430895 I've marked this as ready, because what's been corrected here can essentially already be merged as is 🙂
I'll try to make separate MRs for more complex changes.

@JumpLink I've changed the annotations to your style.
Not sure though, what you mean with "further" information… my idea was just to mark every type which has been scrutinized for GNOME 46, to keep track of things, and inform other people looking at this that they perhaps don't need to look at these types again. What further information should I provide?

For example if there are comments in the original javascript source file then these can be adopted.


Cannot change current user data

Request: PUT /users/current
I am trying to edit current user by sending the following payload to the endpoint above:
{
  "firstName": "KarelX",
  "lastName": "KlimaX"
}

The server responds with 403 and following message:
User User{Karel Klíma<EMAIL_ADDRESS>attempted to update a different user's account.
I am getting the same result in Mission Control as well as in Swagger.
The authorization token seems to be in order at the first glance, this is the decoded information:
{
 sub<EMAIL_ADDRESS> jti: "http://onto.fel.cvut.cz/ontologies/slovnik/agendovy/popis-dat/uživatel/karel-klima",
 iat:<PHONE_NUMBER>,
 exp:<PHONE_NUMBER>,
 role: "ROLE_USER-ROLE_ADMIN"
}

There is a fair chance that I am doing something wrong with the endpoint as the documentation is limited at this point. Please advice :-)

I have updated the Swagger docs for the endpoint. Also, as a by-product, fixed that the update put the data into the wrong context.
Please check.

I believe the problem is elsewhere - updates in TermIt (and thus in the Control Panel user management) are not PATCHes. That is, you have to provide the whole object for update, with both updated and original fields. The exception you are seeing is likely due to missing identifier in the provided update object.
The object for update should look as follows:
{
  "uri": "http://example.org/your+uri",
  "firstName": "KarelX",
  "lastName": "KlimaX",
  "username": "your@username"
}

This behavior is a bit weird, isn't it? The same endpoint is used for updating user password. In that case the request should contain also originalPassword and passwordFields. Which effectively means that some of the fields are mandatory, but it's definitely not like "you have to provide the whole object for update", as the endpoint clearly works without password data (which is good).
Ideally we should only send what data should be changed to the endpoint, and if that's necessary include also the URI, although that's redundant, since the username is already part of the authentication token. But why would we need to send both username and uri, that's a mystery to me.

Password is not sent, because it does not get to the client. Only in case of password update should it be a part of the request.
As I said, patch updates are not currently implemented, because they would require determining the  changed attributes for every request.

Alright, good to know that the passwords are the only exception. I'll adjust the code accordingly. Thanks!

I still cannot get this to work. I'm now getting 500.
Payload:
{
  "uri":"http://onto.fel.cvut.cz/ontologies/slovnik/agendovy/popis-dat/uživatel/karel-klima",
<EMAIL_ADDRESS>  "firstName":"Karel",
  "lastName":"Klíma"
}

The edit call worked once. The payload for that call that worked was exactly what GET /users/current sends, with firstName and lastName properties changed. I noticed only afterwards that the GET data contain also admin, password and persistenceContext field as well. So I sent all of those as PUT and now it seems like the endpoint is broken.
This is what I receive now when trying to update my profile using the payload above:
{
  "message": null,
  "messageId": null,
  "requestUri": "/sgov-server/users/current"
}

Fixed.

I confirm it works.


[bugfix] ignore unknown attributes

With newer kernels, new attributes may be added. This would break
existing programs. It is expected new attributes can be ignored,
thanks to Linux' backward-compatibility guarantee.
For example, since 3.10, all types are also returning
IPSET_ATTR_BUCKETSIZE.

I think this is not the best way to slove this problem.  If new  attributes are added to the newer kernels, it is a better way to support it, not to delete the default value. (If receive new attributes that cannot be parsed, we don't know what happened)

If a user upgrades its kernel, a tool using this module will just break.


Add support for cross compiling from linux for windows (only header-only libraries supported)

Fixes #14 . Fixes the problem for header-only libraries only.

Thanks for your work, cross compiling was in the roadmap since the very beginning, but I had no time enough to check it out. I will merge this even if the ci tests are not passing. The current travis setup bootstraps builds for the examples by committing and pushing to their repos, so you need credentials (Git user, email, and github password) in order to run the builds. I should update the docs, sending PRs to a develop branch would allow me to run tests prior merging to master.
Also note merging does not push changes to biicode cloud. I will be much more conservative here since  changing the Boost scripts may break a lot of user code. OTOH your changes are simple and shouldn't break anything.

Only one question: What means it works for header only libs only? In that cases you don't actually build anything from Boost, so what's the point of cross-compiling?

Only one question: What means it works for header only libs only? In that cases you don't actually build anything from Boost, so what's the point of cross-compiling?

When you cross compile a application, but you only use a header-only boost library (e.x. signals2), this pull request is needed to compile. The reason is that bootstrapping is also done when no boost library must be compiled. I added #17, but its a more complicated pull request so I separated it in two pull requests.


feat(tutorial): complete step 5

http://carbon-tutorial-slaytanic.mybluemix.net/

Per instructions in the tutorial step 5, please include your mybluemix.net URL for your deployed app in your pull request description.

Sorry about that! I edited the PR with the URL

👍  Looks good!
Feel free to stop this running application on IBM Cloud to avoid the possibility of incurring any charges 💵


Fix broken pom and remove findbugs config

addressed pr comment https://github.com/apache/commons-validator/pull/86#discussion_r987294149
if this is merge I'll simply close PR https://github.com/apache/commons-validator/pull/86

Codecov Report

Merging #87 (387ba80) into master (e03b76d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     71.90%   71.90%
  Complexity     1137     1137
=========================================
  Files            63       63
  Lines          3157     3157
  Branches        542      542
=========================================
  Hits           2270     2270
  Misses          693      693
  Partials        194      194

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Very rough prototype (with some bits that rely on a feature that hasn't landed yet stubbed out) of an alternate design for JSONWriter that could be faster. Untested, mostly just for discussion.

This could, in theory at least, recover some static dispatch optimizations through liberal use of @_specialize. I have no idea if it's better or not since a bunch of stuff it uses isn't in the compiler yet, but it's kinda interesting.

Parameterized extensions is in https://github.com/apple/swift/pull/25263

Just noticed this (apologies @Catfish-Man) I'll take a closer review.

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.
More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412


Indicator light no wallet

Adds a third state to the indicator light: no wallet.
Only shows when no wallet (metamask, or nifty) is detected

On hover, a message is shown, using existing language, and when clicked, takes you to the setup page

Hold off on merging this one. I need the reducer value from PR #124 and then I will add an additional commit to show if the user's wallet is locked.

This is ready for review and merge. One thing to note with Nifty and locked wallet. After the user unlocks their wallet, the light does not automatically update to connect. With Firefox and Metamask it does because a promise is returned. Other than running a timer in the background to check, I'm not sure how to fix this issue.

Let's leave this issue open until we create a user story for 'unlocking and reolaoding'.


Update watchman (and create all the packages it now depends on)

Description of changes
Updates watchman to the most recent release (closes #156177). Also brings in all of its dependencies.
Lots of help from https://github.com/NixOS/nixpkgs/pull/63097 (thanks @pierreis -- let me know if you don't want to be listed as a maintainer). Had to update most of the packages since that PR.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

edencommon does not seem to get tags for releases - please let me know if there's a preferred versioning method here rather than using the commit SHA.

Updated all versions from 2<IP_ADDRESS> to 2<IP_ADDRESS>.

@matthewbauer @LnL7 looks like you both have committed to watchman most recently -- can I get a review please?

Rebased onto latest master

Any news on this? I'm very interested and I'm considering whether it makes sense to package this for myself until it gets merged.

Rebased onto master and updated rsocket-cpp to use fmt_9. Confirmed watchman builds and runs properly.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/687

@kylesferrazza happy new year! Do you plan to pick this back up? If not, @SuperSandro2000's feedback seems relatively straightforward, so I wouldn't mind picking this up.

@andrewhamon happy new year to you as well!! I would appreciate if you had the time to implement the feedback, thanks. I can give you write access to my fork.

Trying to get this building on my arm mac, I had to update the platforms on several of these packages, and now bumping into this error building fbthrift
error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer

I see you tried to address this with this line: https://github.com/NixOS/nixpkgs/pull/181787/files#diff-2b78e1719b2b799aa459d40ebb853e1eca68a96078d25eb4be51bac9c895e152R23
Seems a bit off that 10.13 was working for you, given the error explicitly says 10.14.

But if I change "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.13" to 10.14 I can build on arm! Nice! No to address this feedback.

Okay, merged master, as expected builds were broken. I'm upgrading everything to latest.

rsocket-cpp was broken, but I don't think its a dependency in newer versions of these packages. Solution: d
newer versions of these packages were broken when building against folly. I upgraded folly to latest as well - if this ends up breaking downstream packages I might try going the other direction and pinning everything in this PR to versions contemporary with the current version of folly in nixpkgs.

At this point, I have everything building except watchman itself, which feels like decent progress.

Alright, I have watchman building again on latest, I just had to update the cargo.lock.
My final quest will be to get to the bottom of why we need both Cargo.lock as well at the cargo-lock.patch

@kylesferrazza in order to adhere to the contributor guidelines, I think I'm going to have to rewrite history to clean things up. My plan for that is to keep you as author, and add myself as a co-contributor in the footer of the commit according to this guide..
Let me know if that works for you, and also let me know if you'd prefer I open a new PR instead of force push to your branch.

My plan for that is to keep you as author, and add myself as a co-contributor in the footer of the commit
Let me know if that works for you,

Go for it -- thanks for all your work here!

Alright, last hurdle passed - no more need for the redundant cargo-lock.patch. I grepped the codebase for instances of cargoRoot =  and found some good examples to reference.

Result of nixpkgs-review pr 181787 run on x86_64-linux 1

12 packages built:

buck
edencommon
fb303
fbthrift
fizz
folly
python310Packages.pywatchman
python311Packages.pywatchman
rs-git-fsmonitor
wangle
watchman
wdt

@andrewhamon should we rebase the last three commits in as fixups?

Yep, just did that :)

It seems like just about everything needs the "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.14" fix

I added it to watchman pre-emptively since it too depends on folly (which seems to be the source of the errors - deps that compile against folly headers). Hoping for all green this build 🤞

Building locally, testing, then will push rebased branch

So after doing some manual testing, I've learned two things:

patchShebangs . doesn't seem to be necessary anymore.

-DWATCHMAN_STATE_DIR=/run/watchman results in a broken-by-defualt experience, since /run isn't writable by non-root. The --disable-statedir option we were using before doesn't seem to work anymore, but it is functionally equivalent to using /tmp on NixOS (since that is what watchman ultimately falls back to). It is functionally different on macOS, though, since macOS populates $TMPDIR with a private-per-user path on each boot.
I propose -DWATCHMAN_STATE_DIR=/tmp as the least-bad option. Watchman deliberately avoids the use of /tmp for security concerns on multi-user systems, since another malicious user could make the watchman tmpdir a symlink. But the last version was effectively usign /tmp anyways by setting --disable-statedir (here are the seemingly not-up-to-date docs on the matter)  I wish they would just use something under $HOME to mitigate that instead of a hardcoded-at-compile-time path :/

It also might be a decent idea to make WATCHMAN_STATE_DIR more easily overridable.

Re: scoping down patchShebangs, it seems the relevant files are pretty scattered. A list I arrived at that scoped things down somewhat, while trying to avoid being hyper-specific, is this:
autogen.sh
build/fbcode_builder
install-system-packages.sh
run-tests.sh
watchman/build
watchman/integration
watchman/node
watchman/python
watchman/runtests.py
watchman/test
website/publish.sh

I think this still touches a significant fraction of files (several hundred at least, out of a total of ~500 files in the watchman repo).
So I'm not sure its worth trying to scope it down unless the size of the watchman repo grows significantly. The more we try to cherry pick things, the more maintenance will be required when upgrading.

An alternative way to scope things would be as follows:
**/*.py
**/*.sh
watchman/python/bin

but thats still >100 files

@kylesferrazza is there a particular reason you updated watchman to fmt_9? It looks like watchman still depends on fmt 8 and I think this is the cause of the remaining build failures.

It's been so long I can't remember.. feel free to change it back, thanks.

@SuperSandro2000 I think its all ready now. A few follow ups on your prior feedback:

I changed WATCHMAN_STATE_DIR back to /tmp.

This is functionally equivalent to the prior version (--disable-statedir didn't actually disable the statedir, it forced it to use /tmp).
This is the only solution I could find that doens't result in a broken-by-default package.

If we use /run/watchman, the package isn't usable without the help of sudo to first create /run/watchman

 I opened an issue upstream about this..

patchShebangs does not seem easy to limit in scope without producing a long and brittle list of paths. The number of files in watchman doesn't seem that large (a few hundred) so I think the most maintainable thing is to leave it scoped as .

Aside from that, I believe all your feedback has been taken into account!

Hi folks! I've been eagerly watching the recent progress on this PR and was really hoping to see it get merged soon. Is there anything I can do to help get it across the line?

Hi folks! I've been eagerly watching the recent progress on this PR and was really hoping to see it get merged soon. Is there anything I can do to help get it across the line?

Would like to +1 this and also offer support

rebased to resolve conflicts
updated everything to v2<IP_ADDRESS> (to match folly, which was recently upgraded and was the source of the conflicts)
cleaned up some more cruft (configureFlags aren't used anymore since the project moved to CMake)
made stateDir overridable, for any folks not okay with the default
updated license to mit (watchman was relicensed)

@robstolarz @gsornsen testing the package on your platform of choice would be a nice help! I've only tested on m1 macos.
Otherwise, if you know any nixpkgs committers......
@SuperSandro2000 a final review would be much appreciated 🥲

@wegank with your merge of https://github.com/NixOS/nixpkgs/pull/204718 folly is now broken on aarch64-linux. This PR includes a fix 😄

@andrewhamon That package's broken on aarch64-linux before my merge.

Oh my bad, i assumed the previous version was in a working state (since it was breaking the build in this PR which touched it before your upgrade).
Either way, fixed here.

Result of nixpkgs-review pr 181787 run on aarch64-darwin 1

1 package marked as broken and skipped:

buck

10 packages built:

edencommon
fb303
fbthrift
fizz
folly
python310Packages.pywatchman
python311Packages.pywatchman
rs-git-fsmonitor
wangle
watchman

Thank you to everyone involved!


Use atomic crossbeam structure to add interior mutability to common::Errors

This allows fetching Errors without limiting concurrency.

cc @Xaeroxe @omni-viral @ebkalderon This should also improve performance for Amethyst in the future, and is the same strategy we should use for events in case we want to implement them as described in https://github.com/amethyst/amethyst/issues/229

@torkleyy I believe that crossbeam will add more overhead than collecting errors that Systems return.

@omni-viral I don't think so, but the bigger problem I have with Systems returning Result is that it is a breaking change that forces all users to change all of their system implementations and that you have to add Ok(()) everywhere, even though most systems don't need results. To improve ergonomics, I planned to add a method Errors::execute:
fn run(..) {
    let x = errors.execute(|| {
        let val = do_something_that_can_fail()?;

        val + 5
    });

    ints.insert(entity, x);
}

Just look at these systems used in an actual game built with Specs: https://github.com/agmcleod/ld39/tree/master/src/systems
None of them needs Results and their (performance-wise and syntactical) overhead.

The difference here is also that the crossbeam structure only does something if errors get pushed, but the collecting of Results happens every frame. This means the best-case performance (no error), which is the common one, is better with this solution.

This means the best-case performance (no error), which is the common one, is better with this solution.

The good reason I often forget about 😄

@omni-viral So can I take this as an approval?

@omni-viral Done.

Merging this now, as this is blocking me atm.
bors r+

Great!


Scale and Autorotate in UI dont work

i think that for some reason the program doesn't receive the arguments. I tried without the UI, no luck.

are you sure you're replacing and reloading the output afterwards correctly?
all the data are encoded in the texture, so if you change scale/autorotate you will have to replace the texture in your resourcepack with the newly generated one.

got it to work. offset doesn't though

i found the problem, should be fixed

thanks! 👍


#2 Upgrade Apache, PHP and OpenSSL

Apache 2.4.54
PHP 7.4.30, 8.0.23 and 8.1.10
OpenSSL 1.1.q (Linux)

XAMPP for Windows 8.1.10, 8.0.23 and 7.4.30 are available for testing here. Any feedback will be welcome.


viewRectangle y2 same as y1 which makes no sence for abstact rectangle

Sigma.js version : 3.0.0-alpha3

https://github.com/jacomyal/sigma.js/blob/7b3a5ead355f7c54449002e6909a9af2eecae6db/src/sigma.ts#L1627-L1649
y1 and y2 data in the abstarct rectangle of a node are basically the same, is it intended? If yes, what's the difference between y1 and y2?
Expected behavior
I think it makes more sense to define y2 as y: 0 - marginY + this.height
And then height becomes p1.y - h.y
Actual behavior
y2 = y1 which makes no sence

@DenchPokepon I don't remember the specifics but the rectangle does not have to be axis-aligned, typically when rotating the camera, hence this specification of the rectangle.


Add css class to modal dialog which denotes if cancel button is displayed.

Trivial issue:

We have a layouts that uses sweet alert for confirm dialogs (only CONFIRM button) and question dialogs (both CONFIRM and CANCEL button)
Our designer wants to have 100% width button - if it is a single button, or 50% width if there are two buttons.

It would be convenient for customization if div.swal2-buttonswrapper has additional class if both buttons are visible - that would ease up our development and maintenance since we  can use Swal in our project with minimal configuration.
THX!

It's doable with flexbox (basic jsfiddle example), if that's an option for you. SweetAlert2 supports IE11 at best, which has partial support of the flexbox model. But as having two buttons filling an horizontal space is a simple, basic use case of flexbox, I think it could work in IE (can't test it easily as I'm on Linux) :)

@toverux Nice fiddle! I think the display property for the buttonswrapper should be changed from block to flex  in the next major release, what do you think?

btw, @TheCelavi there's a handy swal.getButtonsWrapper() which will allow you to depend on our API instead of internal class-names. It was undocumented until now, I just added the missing documentaion https://github.com/limonte/sweetalert2/commit/be80a18fe23ec3eb46a77dbdfd74327245fcd31a

@limonte Absolutely no objection on embracing flexbox! - as long as IE compat is preserved (until that day we'll happily drop it)

You make me love open source even more:-)
Thanks guys!


Enforcement of base64 in attachments

Why is base64 encoding enforced in attachments no matter the content type?
https://github.com/zbateson/mail-mime-parser/blob/05e7579f3f37a4fd67933f1d059fefd78db88835/src/Message/Helper/MultipartHelper.php#L351-L353
I added a text/plain attachment but it will only be available as base64 encoded data.

That's a good question... my off-the-top of my head reasons are:

Not wanting to decide what mime types are in fact "text" (e.g. text/plain vs. text/rtf, or application/javascript)
Not wanting to write code that tries to determine if no encoding is needed, or if quoted printable makes sense vs. base64
Besides slightly larger emails, not seeing much benefit in spending time making those determinations

Having said that, it's not that I'm against doing it.  What if we added an additional parameter to the method to allow the default 'base64' to be overridden, so at least it's a user-decision?

What if we added an additional parameter to the method to allow the default 'base64' to be overridden, so at least it's a user-decision?

At least I would be very happy about it. ;)

Released in 1.2.0.

Thanks, working flawlessly!


triggers keyword lost in IL domain export

before IL:
intents:
  - greet
  - goodbye
  - affirm
  - deny
  - mood_great:
      use_entities: false
  - mood_unhappy
  - random:
      triggers: utter_random

after IL:
intents:
- greet
- random
- affirm
- mood_unhappy
- goodbye
- deny
- mood_great:
    use_entities: false

haven't figured out what causes this yet but will hopefully do so on friday
btw, use_entites: true also gets lost

Did you actually spell entities correctly? 😉

I found the problem and largely fixed it, tests are not working right now so the PR will come next week. There is one cosmetic issue though: The cleaned_domain method basically filters out the property use_entities: True because this is the default setting and if it was not filtered out the exported domain would contain this even if the user did not specify it. However the information of whether the user entered it is lost, so if a user should ever manually specify this value it will not show in the cleaned domain unless there is some big change in how we treat this. (Maybe in locations where it is used we could assume True if the property is not set.)

Thank you @imLew! 😍
I think we should just not filter out the keywords use_entities or triggers and their values. We do already assume it's true if not set, however, it would be good if the user defined it that it would stay in the export.

@erohmensing Yes, the problem was that you would get a domain full of "use_entities: true" even if you had not specified it, but its fixed now


fix: add fallback for non-required fields on submit

Problem
Removing a relationship for update forms does not actually remove the relationship.
Solution
Provide null as a fallback for non-required fields so GraphQL will remove relationships.
Additional Notes

Links
Ticket

GitHub issue:
Other links
Verification
Manual tests

Automated tests

[x] Unit tests added/updated
[ ] E2E tests added/updated
[ ] N/A - (provide a reason)
[ ] deferred - (provide GitHub issue for tracking)

Housekeeping

[x] No non-essential console logs
[x] All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #1082 (720a674) into main (3674ebd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   93.90%   93.90%
=======================================
  Files         124      124
  Lines        5853     5862    +9
  Branches     1780     1786    +6
=======================================
+ Hits         5496     5505    +9
  Misses        339      339
  Partials       18       18

Files Changed
Coverage Δ

.../codegen-ui-react/lib/amplify-ui-renderers/form.ts
95.45% <100.00%> (+0.06%)
:arrow_up:

...act/lib/forms/form-renderer-helper/model-fields.ts
96.00% <100.00%> (+0.76%)
:arrow_up:

...act/lib/forms/form-renderer-helper/parse-fields.ts
100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3674ebd...720a674. Read the comment docs.


Version 0.3.7 does not work with node 0.10.x

I am seeing the following running with node versions 0.10.40 and 0.10.48:
.../lib/node_modules/whitesource/bin/ws_node_report_builder.js:96
			if ((uri.endsWith("/dev/package.json") && !uri.endsWith("node_modules/dev/p
			         ^
TypeError: Object name/package.json has no method 'endsWith'

The build works find with 0.3.6.

Thanks Kevin,
It is working now.


Error while setting up platform remote_rpi_gpio

Home Assistant release with the issue:
0.96.5

Operating environment (HassOS/Generic):
HassOS 3.3 VMDK on ESXi 6.7

Description of problem:
Hass.io configuration.yaml is very simple, essentially identical to the example entry in the Home Assistant components database, using the remote IP address of my raspberry pi with a running instance of pigpiod. The configured sensors and switches never show up in the Home Assistant GUI, and Developer Tools -> Info -> reveals the following error:
Error while setting up platform remote_rpi_gpio

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 126, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/remote_rpi_gpio/binary_sensor.py", line 52, in setup_platform
    bouncetime)
  File "/usr/src/homeassistant/homeassistant/components/remote_rpi_gpio/__init__.py", line 36, in setup_input
    from gpiozero import Button
  File "/usr/local/lib/python3.7/site-packages/gpiozero/__init__.py", line 22, in <module>
    from .devices import (
  File "/usr/local/lib/python3.7/site-packages/gpiozero/devices.py", line 486, in <module>
    Device.pin_factory = _default_pin_factory()
  File "/usr/local/lib/python3.7/site-packages/gpiozero/devices.py", line 453, in _default_pin_factory
    raise BadPinFactory('Unable to load any default pin factory!')
gpiozero.exc.BadPinFactory: Unable to load any default pin factory!

is there already another way to change it to mock ?

@rjroch  is there no other way todo that? i dont feel comfortable changing docker containers

@pergolafabio I have no idea if there's another way. I'm not a Docker expert, or a HASS.IO developer. I was just reporting the bug. I attempted to integrate the fix @Kdemontf noted in an earlier reply, and felt it was worth documenting my success. There have now been around 8 updates to HASS released with no fix, so I've been breaking into the docker container and modifying it after every update. The fix also works as simply export GPIOZERO_PIN_FACTORY="mock", without the portion specifying the remote Pi address.

Ok, thnx for update... although it's strange, some users are reporting no issues, for them it works without that workaround... How can that be?

@jgriff2
hi, are you owner of this new integration? can you have a look at our issue here ?
thnx in advance

issue : gpiozero.exc.BadPinFactory: Unable to load any default pin factory!
owke, i think i created a good workaround now , just loaded this component as a custom component
downloaded from here :
https://github.com/home-assistant/home-assistant/tree/master/homeassistant/components/remote_rpi_gpio
then i changed in the manifest.json the requirements, from 1.4.1 to 1.5.1 , like code below
so it downloads a new version for gpiozero
according to this fix; if no pin_factory is defined , it will fallback to mock...
so it should be an easy fix :)
https://github.com/gpiozero/gpiozero/issues/600
https://github.com/gpiozero/gpiozero/pull/727
{
"domain": "remote_rpi_gpio",
"name": "remote_rpi_gpio",
"documentation": "https://www.home-assistant.io/components/remote_rpi_gpio",
"requirements": [
"gpiozero==1.5.1"
],
"dependencies": [],
"codeowners": []
}


feat(Tactic/SolveByElim): minimal implementation

This is far from feature-parity with mathlib3's SolveByElim, but has the basic functionality.
I'll add more later.

There are quite a few unrelated changes in the diff here.

There are quite a few unrelated changes in the diff here.

Sorry, fixed.

bors r+


Safari browser on ios is frozen when call detedSingleFace

In my web app, i use tinyFaceDetector and faceExpressionNet to detect and catch expression of person from camera, it work fine on pc, mac and android phone but have trouble with Safari on Iphone, everything ok util bellow function is called:
detections = await faceapi.detectSingleFace(video, this.faceApiObject).withFaceExpressions()
Safari is frozen
Please help me!

Did you find a solution for your question?

The same problem.

same issue here


Can't create host.v1 config

all the other configs seem to work - but not host.v1

Fix in latest Commit e203660


Support multiple accounts connected to the same dApp

Proposed changes
Task link
Types of changes

[ ] Bugfix
[x] New feature
[ ] Refactor
[ ] Breaking change
[ ] UI fix

Steps to reproduce
Connect multiple accounts to the same dApp.
Screenshots - after
https://github.com/trilitech/umami-v2/assets/150050388/c1430da1-2541-49c2-844c-bf683b13a91e
Checklist

[x] Tests that prove my fix is effective or that my feature works have been added
[x] Documentation has been added (if appropriate)
[x] Screenshots are added (if any UI changes have been made)
[x] All TODOs have a corresponding task created (and the link is attached to it)

@serjonya-trili thanks for the migration changes!
Please check the screen recording.
With objkt.com it looks like on deleting one dApp connection, all other connections to the same dApp should also be removed from the slice - as we're not getting this dApp from peers query anymore (which makes sense as peer sonnections identified based on dApp's details).
Should we still have this update & if so, should we delete all dApp connections on removing a peer?

@serjonya-trili all existing comments seems to me to be resolved - please approve PR or let me know if I missed something (or if there are any other comments 🙂)

@serjonya-trili all existing comments seems to me to be resolved - please approve PR or let me know if I missed something (or if there are any other comments 🙂)

taking into account this I think we should use the previous version because it's impossible, at least for now, to connect from a dapp to another account without logging out from the first one.
with this implementation, we can have just 1 active connection whilst showing more (depending on the amount of login-logout cycles you've done)

as it is on main, it's possible to connect to the same dapp from different accounts if you use different browsers/ingognito window because beacon instances there would have different publicKeys and removal will work just fine too.
does it make sense or I am missing something? 🤔

@serjonya-trili I agree, the old version seems to work better with the current beacon implementation.
The only thing that I'd change is using {peerInfo.name} as a key there. Switching to {peerInfo.senderId} should be fine, same as here.
Should I close the current PR completely, or just put it on hold for now?

Let's close it. We can always reopen if needs be