QueryExecutionOptions Fix

This is a breaking change to the extensibility endpoints. However, this extensibility point seems to be broken without this change anyway... so I'm not sure if anyone is actually using it.
Maybe keeping this as a deprecated method would be ideal, but I'm not sure what the protocol here is.

For anyone testing this, I tested this method with the MaxXmlCharsToStore option defined here:
https://github.com/microsoft/sqltoolsservice/blob/master/src/Microsoft.SqlTools.ServiceLayer/SqlContext/QueryExecutionSettings.cs#L33

Hey @aaomidi, I ran into this recently, not sure if you ran into same thing but wanted to share in case.
This is actually getting used by SQLCMD (in PR - https://github.com/microsoft/azuredatastudio/pull/6555) and it works with some restriction.
The restriction is that when you add values to map, use lower case i.e. "maxXmlCharsToStore" and not upper case for index. This casing should be ignored ideally which is a fix recently checked in - https://github.com/microsoft/sqltoolsservice/blob/516c54c87af3e3156b3cd77ba6fa9698514f312e/src/Microsoft.SqlTools.Hosting/Utility/GeneralRequestDetails.cs#L17
Also if you decide to make the change in this PR anyways, please validate once that the above example and/or following sample continues to work
https://github.com/kburtram/azuredatastudio-snippets/blob/eaaf002cf6af1dc1713fee519183b2abe5fac9b1/samples/queryplan/src/main.ts#L19


Motion detectors work on dead, dragged xenos

yessir

can confirm.
they also still work after the xeno has stopped being dragged for about 2-3 more pings on average before the motion detector cuts out again

This is parity, its intentional.

i mean I get why but it's also clunky

Motion detectors detect movement, not life

fair nuff


ARROW-3878: [Rust] Improve primitive types

@kszucs @paddyhoran @andygrove could you review this? Thanks.

@sunchao I think this needs a re-base after merging ARROW-3855
@andygrove does the merge script automatically rebase before merging?


Snippets should have custom transforms

Snippets currently have a facility to transform input in predefined ways.
But those predefined ways are very limited.

upcase
downcase
capitalize

What I would like to achieve is something more custom.
This is portion of a bigger snippet code that I am trying to work as smoothly as possible.
.ofType<GetLogicalSwitchesSearchAction>(GET_LOGICAL_SWITCHES_SEARCH_ACTION)

Right now I have to type the text twice. But if there is a way one could throw in custom logic, then I could simply type GetLogicalSwitchesSearchAction once and the 2nd part should intelligently fill up GET_LOGICAL_SWITCHES_SEARCH_ACTION.
Hence creating this issue to track this request for custom logic in snippets.

duplicate of #34683


Deprecate nuget package

The nuget package should be deprecated in Nuget.org so it is clear what the project status is & described in #163

Thanks @thompson-tomo - you're correct and I've marked all OpenTracing packages on nuget as deprecated.


apt::source: Make location required.

In what universe does it make sense to create a sources.list.d entry for a repository without specifying where this repository is? :confounded:
:disappointed: :weary: :anguished: :scream:
Only when removing the resource should a location not be required.

@daenney sorrrry I made this need a rebase :(

Done!

Thanks @daenney !


Extension doesn't work with UNC paths (Samba directory)

Not sure if it's a problem of Brackets or of Brackets-git but if I open a repository stored in a Samba directory, the .git folder is not shown in the file-tree and brackets-git is loaded like my folder is not a git-root.
Using command line everything works fine.

Not sure what is up, but I never experienced this issue until today. I did update the extension last week which may have broken it. Any chance this had been working but was broken again in the latest version?
Also, one way to accomplish this would be with #1072

I have no knowledge of what would break it with the update. Can you try getting back to old version? You can browse any commit on github and download a zip to install with drag & drop to extension manager.

I reverted to 0.16.0 and it works again.

Does 0.16.5 work too?

Yes it does. I checked all commits between 0.16.5 and 0.16.6, and I found one commit that looked interesting: 6ac083f4efffb7c727187d993fb064931189fecb
Not sure what cross spawn is, but this is the only thing I found that does anything related to command handling.


Change license

We need to change the license to CC if we want to use material licensed under CC, right?

not really, we just need to designate what is under CC license, but our code can go under any license we like


DP-1.4: QoS Interface Output Queue Counters - removing fixed deviation

DP-1.4: QoS Interface Output Queue Counters - removing fixed deviation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.88%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1236

Relevant Lines:
2173

💛  - Coveralls

Please update the description, otherwise LGTM

/gcbrun

/gcbrun

/gcbrun


sarif report without results

Hi @owenrumney!
It seems that I already bore you, sorry!
githbub can't accept a report without vulnerabilities / misconfigurations, because:
"results": null

should trivy handle this case itself?
thanks a lot again!

Hey @afdesk  - no problem at all - I'm grateful to you for helping to shake out the issues
I"m guessing you're doing
run := sarif.NewRun(tool)

rather than
run := sarif.NewRunWithInformationURI("trivy", "https://aquasecurity.github.io/trivy")

which is fine - there was a bug in NewRun which is fixed in v2.0.13 - please try that and let me know if there is still an issue

I"m guessing you're doing
run := sarif.NewRun(tool)

rather than
run := sarif.NewRunWithInformationURI("trivy", "https://aquasecurity.github.io/trivy")

oh, thanks!
yes, i did so, because I want to set a version via tool.
now, I'm doing:
sw.run = sarif.NewRunWithInformationURI("Trivy", "https://github.com/aquasecurity/trivy")
sw.run.Tool.Driver.WithVersion(sw.Version)

@owenrumney sorry, I have a problem again.
ToolComponent.Rules is nil for report without results.
could you fix it, please? thanks a lot!

Hey @afdesk  - take v2.0.16 and it has the default empty rules rather than null

thanks a lot, will try a new version!


Clean up constants

I mostly did this as a pipecleaner for the new workflow, but it scratches an itch I think we've all expressed once or twice.
There's now a single constant node with a payload of enum type "Constant".
This should stop the proliferation of constant nodes for every type that needs a slightly different payload encoding to be type safe (and not just rely on casts of the binary data).

Looks good to me, exactly the changes I would expect.  Looks like I'll need to fix up the assembly a bit, just as a note.


Ability to make derived dimension from multiple dimensions

Right now extraction functions only work on one input.
I would like to express something like:
SELECT CONCAT(`country`, "->", `city`) AS "place", COUNT(*) AS "count"
FROM wikipedia
GROUP BY CONCAT(`country`, "->", `city`)
ORDER BY count DESC LIMIT 5

Or
SELECT CONCAT(LOOKUP(`id`, "my-lookup"), " [", `id`, "]") AS "blah", COUNT(*) AS "count"
FROM wikipedia
GROUP BY CONCAT(LOOKUP(`id`, "my-lookup), " [", `id`, "]")
ORDER BY count DESC LIMIT 5

As topNs.
Maybe it could look like this:
{
  "queryType": "topN",
  "dataSource": "wikipedia",
  "granularity": "all",
  "intervals": "2000/3000",
  "dimension": {
    "outputName": "place",
    "type": "multi",
    "fn": "sprintf",
    "string": "%s->%s",
    "args": [
      "country",
      "city"
    ]
  },
  "aggregations": [
    {
      "name": "Count",
      "type": "count"
    }
  ],
  "metric": "Count",
  "threshold": 5
}

and
{
  "queryType": "topN",
  "dataSource": "wikipedia",
  "granularity": "all",
  "intervals": "2000/3000",
  "dimension": {
    "outputName": "place",
    "type": "multi",
    "fn": "sprintf",
    "string": "%s [%s]",
    "args": [
      "id",
      {
        "type": "extraction",
        "dimension": "id",
        "extractionFn": {
          "lookup": {
            "namespace": "my-lookup",
            "type": "namespace"
          },
          "type": "lookup"
        }
      }
    ]
  },
  "aggregations": [
    {
      "name": "Count",
      "type": "count"
    }
  ],
  "metric": "Count",
  "threshold": 5
}

This is directly related to some discussions I've had with people internally about if this is appropriate to do in Druid, or is better handled at a layer above Druid.
If the data mapping / concat has a direct manipulation of the results of the data (like how QTL can merge multiple IDs together) then it is an obvious candidate for a feature in druid.
But just like Druid isn't really an ETL engine for data coming in, I'm not convinced it is always a good candidate for ETL going out.
I CAN  see where maintaining access to lookups might be cumbersome if it has to be maintained in both Druid and an external system though. Especially if the lookup isn't a simple "query some DB and get a value for some ID". So I think having some kind of ease-of-use and operational-sanity capacity to have some form of "dimension explosion via lookups" at the query level for druid makes sense.

IMO something like this makes sense in Druid, it's always possible for functions to map things to a smaller output space, and pushing that down as far as possible will help performance and memory use.

Functionally, how does
  "dimension": {
    "outputName": "place",
    "type": "multi",
    "fn": "sprintf",
    "string": "%s->%s",
    "args": [
      "country",
      "city"
    ]
  },

Differ from a groupBy? (other than adding a sprintf on top of the results?)

One difference is that if Druid can treat that as a single column then we can do topNs on it.
Another difference is that we can filter on it. Even for simple stuff like "concat" it's annoying to write a filter without this functionality. You have to translate WHERE CONCAT(a, b) = "foo" to WHERE (a = "" AND b = "foo") OR (a = "f" AND b = "oo") OR (a = "fo" AND b = "o") OR (a = "foo" AND b = ""). For more complex functions it's not in general feasible to translate them to boolean filters.
IMO this feature is not super useful if it doesn't work with stuff like topNs and filters, but it really should.

@drcrallen I actually started implementing this in Plywood where plywood would issue a groupBy and then do the post processing it became hard to make all the possible queries that should work function with that workaround.
for example let's say the user sorts lexicographically on the derived dimension
Also I know I just named CONCAT() but another interesting function to implement would be coalesce so you could do a group by on COALESCE(city, region, country) AS "location"

Obviously (you know me) I would love to have a JS function that I can prototype / gap fill with that takes multiple inputs:
"dimension": {
  "outputName": "place",
  "type": "multi-javasctipt",
  "args": [
    "city",
    "region",
    "country"
  ],
  "fn": "function(a,b,c) { return a || b || c; }"
}

in fact the JS functionality alone would make me happier than a pup with two tails.

So right now we have the following capabilities regarding dimensionality of the data:

Project a single dimension onto another dimension basis (single-dimension lookups which are many-to-one or one-to-one).
Use combinations of dimension values. (group-by)

This ask, if I'm reading the discussion correctly, is to allow more flexibility along the lines of 1 by allowing a lookup (or some other dimension-function kind of feature) function's domain to have more than one dimension as input.
What this is NOT asking is to contain multiple values (one-to-many or many-to-many) in the range.
Is that accurate?
If so I think that's a reasonable ask so long as the use cases are reducing (or maintaining) overall datasource dimension value cardinality (ex: you can't get more rows out than are in the datasource)

we are using combination of string-math-expr(
https://github.com/druid-io/druid/pull/2836) and virtual column (
https://github.com/druid-io/druid/pull/2511) to address this kind of issue.
It looks something like "virtualColumns": [{"type": "expr", "expression":
"datediff(start, end)", "output": "time_diff"}], for example.
2016년 5월 20일 금요일, Charles<EMAIL_ADDRESS>작성한 메시지:

So right now we have the following capabilities regarding dimensionality
of the data:

Project a single dimension onto another dimension basis
(single-dimension lookups which are many-to-one or one-to-one).
Use combinations of dimension values. (group-by)

This ask, if I'm reading the discussion correctly, is to allow more
flexibility along the lines of 1 by allowing a lookup (or some other
dimension-function kind of feature) function's domain to have more than one
dimension as input.
What this is NOT asking is to contain multiple values (one-to-many or
many-to-many) in the range.
Is that accurate?
If so I think that's a reasonable ask so long as the use cases are
reducing (or maintaining) overall datasource dimension value cardinality
(ex: you can't get more rows out than are in the datasource)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/druid-io/druid/issues/3000#issuecomment-220624924

This is possible now via http://druid.io/docs/latest/misc/math-expr.html


Saving GPU memory during pre-loading

Problem:
loading all training images into pytorch tensor is not necessary, which may lead to OOM error when training data is with a large scale.
Solution:
This PR makes it possible to further lower img_downscale ratio at least twice then the initial limit by loading all images into numpy array before batched training for COLMAP data format.
By replacing COLMAP dataloader from loading images into tensors to numpy array, the GPU memory could be saved a lot, especially when your training dataset is with a high resolution, i.e. 2000 x 2000, or with a large amount, i.e. > 1000 images.
Such changed dataloader can perform a high resolution training with certain data (1000 images - 2000 x 2000 pixels), which is not doable in the original codes.
The training speed is not influenced from my opinion and the accuracy is the same from mipnerf360 data.

[x] test for mipnerf360
[x] nerf backend
[x] neus backend
[x] speed/psnr test - differs less than 5%
[x] feedback from host @bennyguo

Hi @wangyida ! It makes sense as loading all images to gpu will consume large memory, but it'll also bring additional data transfer budget. I think it's better to add a load_data_on_gpu option to the dataset and let the user choose whether to transfer data on the fly or not. Could you add this option to the dataset and the corresponding config files? Besides, I would prefer to load them as torch CPU tensors instead of numpy arrays to keep a consistent style between the two options. Would you please modify this too? Thanks for your contribution!

Sure I can modify it accordingly as you have suggested, thanks for sharing your nice work by the way.

Hi @wangyida ! It makes sense as loading all images to gpu will consume large memory, but it'll also bring additional data transfer budget. I think it's better to add a load_data_on_gpu option to the dataset and let the user choose whether to transfer data on the fly or not. Could you add this option to the dataset and the corresponding config files? Besides, I would prefer to load them as torch CPU tensors instead of numpy arrays to keep a consistent style between the two options. Would you please modify this too? Thanks for your contribution!

Can you review the changes again @bennyguo , the system structures are kept unchanged now, just few lines changes in the dataloader

Done thanks

Great! Thanks:)


Migrate extension library to null-safety

Title says it all.

@graknol thanks for you contribution!

@graknol thanks for you contribution!

published 0.2.0-nullsafety.0

published 0.2.0-nullsafety.0


Version compiled for 2.12

Hello,
I am attempting to use ND4S with Scala version 2.12.
My first attempt failed because I have not found the binaries for 2.12.
I then saw issue #82 and proceeded to clone, compile and test ND4S.
This however failed with the following unresolved dependencies:
org.nd4j#nd4j-api;0.6.1-SNAPSHOT: not found
org.nd4j#nd4j-native-platform;0.6.1-SNAPSHOT: not found

Is their any way I can generate the binary for 2.12 and
the latest ND4J repository libraries (0.6.0)?
Just in case I am wrong,  could anyone confirm that
no ND4S binaries for 2.12 exists in the repositories?
TIA.

Try to make your modifications on the source code here:
https://github.com/deeplearning4j/nd4s/tree/nd4s-0.6.0
AFAIU, it should work just fine. You could then send a pull request! Thanks

@hmf we will be doing a release tomorrow. We can do a brief update on nd4s for scala 2.12 then.

@agibsonccc I would appreciate it. I tried to do this with the  0.6.0 branch. I change my local repo to the 0.6.0 branch and set the Scala version to 2.12. However this still failed. I now have the following missing dependencies.
com.nativelibs4java#scalaxy-loops_2.12;0.3.4: not found
org.scalatest#scalatest_2.12;2.2.6: not found
org.scalacheck#scalacheck_2.12;1.12.5: not found
org.scalanlp#breeze_2.12;0.12: not found
com.github.julien-truffaut#monocle-core_2.12;1.2.0: not found

I will wait for your update.
Thank you.

Hello,
I have tried to use Scala version 2.12.1 and failed again. According to the Maven repo the latest version should be 0.7.2. However, it no 2.12.x version seems to be available. I get:
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.nd4j#nd4s_2.12;0.7.0: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.nd4j:nd4s_2.12:0.7.0 (/home/hmf/git/dl4jtest/build.sbt#L68-69)
[warn] 		  +- default:dl4jtest_2.12:0.1

I have tried several versions to no avail. Any way I can get around this?
TIA

@hmf Please try to build from source. When all dependencies of nd4s also become available for 2.12, then we will be able to release nd4s for 2.12 as well.

https://github.com/deeplearning4j/nd4s/pull/103


Deleting digests by timestamp example script no longer works

The instructions around deleting digests by timestamp no longer seems to be accurate. I've written a script from the example bash script in the documentation:
#!/bin/bash

REGISTRY=*******
REPOSITORY=***********
TIMESTAMP=2020-01-01

az acr repository show-manifests --name $REGISTRY --repository $REPOSITORY \
    --orderby time_asc --query "[?timestamp < '$TIMESTAMP'].digest" -o tsv \
    | xargs -I% az acr repository delete --name $REGISTRY --image $REPOSITORY@% --yes

When I run this, I get the following output:

If I manually use the az acr repository delete command with a hardcoded digest, it works fine, but following the bulk example just constantly yields ERROR: The requested data does not exist.. My goal is to clean up old images we no longer need to reduce the size of the container registry, but the bulk documentation doesn't work anymore. I'm using azure-cli version 2.18.0.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb1b3438-58e2-cd26-3b5e-1a1717fe182f
Version Independent ID: ad41d0b4-39b1-7e24-836e-ff12d5016623
Content: Delete image resources - Azure Container Registry
Content Source: articles/container-registry/container-registry-delete.md
Service: container-registry
GitHub Login: @dlepow
Microsoft Alias: danlep

Quick followup, if I adjust my script to just echo each thing it should delete:
az acr repository show-manifests --name $REGISTRY --repository $REPOSITORY \
--orderby time_asc --query "[?timestamp < '$TIMESTAMP'].digest" -o tsv \
| xargs -I% echo %

It does return a list of things I would expect. If I copy one of its outputted lines and hardcode that to delete once from CLI, it works fine.

Hello @chrisdusyk-iq,
Thank you for your feedback! We will review and update as appropriate.

@chrisdusyk-iq - Thanks for raising the issue. May I ask what operating system you are running the script on? I don't repro the problem on macOS Catalina or Ubuntu 18.04.

@chrisdusyk-iq - Thanks for raising the issue. May I ask what operating system you are running the script on? I don't repro the problem on macOS Catalina or Ubuntu 18.04.

I'm on Windows 10 2004. I suspect it's whitespace or newline issues honestly. I gave up on doing this with Bash and just wrote it in PowerShell instead, which worked much better. It's not pretty but it at least let me automate cleaning up our ACR.
$Registry = "*********"
$Repository = "***************"
$Timestamp = "2020-01-01"

az acr repository show-manifests --name $Registry --repository $Repository --orderby time_asc --query "[?timestamp < '$Timestamp'].digest" -o tsv |
ForEach-Object {
    return $Repository + "@" + $PSItem
} |
ForEach-Object {
    az acr repository delete --name $Registry --image $PSItem --yes
}

I'm on Windows 10 2004. I suspect it's whitespace or newline issues honestly.

That seems likely to me as well. There might be xargs options that work around this. In any case, glad you got this to work with PowerShell.


Update index.js

In order to uses JSON inside of the options, encoding of the arg is needed.
This leads to valid requests and environments.
See also: https://github.com/Kong/insomnia/issues/2567

Nice, didn't know about the encoding option
With that maybe I could change the args text to be just a regular JSON, so instead of needing to pass it like min: 1, max: 2, you could use { "min": 1, "max": 2 }. But that will come in another release
Thanks for the help!

@chaosben Version 1.3.1 released :tada:

Thank you very much! 👍


Memory leak!

I have a 2GB Linode with 4GB of swap and I kept getting exceptions so when I checked and zend was using a massive amount of memory (RAM & Swap) whilst it was just sitting there idle.

I restarted zend but when it came back up it was using the same amount of memory.  I then stopped both zend and the tracker then started them in the same order and now the memory useage is back to an acceptable level

latest with swap

So when the next challenge was run the Memory usage jumped back up as expected but stayed there when the challenge finished.

The tracking app has no control over how zen works.
Please move this to https://github.com/ZencashOfficial/zen/issues.


Add store with dledger

What is the purpose of the change
Implement a raft-based broker
Brief changelog
Import dledger to implement a raft-based commitlog, named DLedgerCommitlog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.4%) to 49.472% when pulling 1bc1f22ce3e6b7621abab5e9946ca84281d20aa5 on store_with_dledger into 4f8d96c4a753d24dc2c2e8933d5d2908821f922f on develop.

Can broker elect new leader after a Master failure for now?

Can broker elect new leader after a Master failure for now?

DLedger is based on raft protocol, there is a class DLedgerLeaderElector which is used to select leader.And will notice broker role changed.
But i have a question which rocketmq version can support leader priority selection. @dongeforever


AbstractProvider class missing?

hello,
am currently using the Google.php file together with my PHPMailer script, and there seems to be an error in line 11 (screenshot attached).
Anyone able to assist?

Install this package with composer, so that it pulls in the necessary dependencies. The AbstractProvider class comes from https://github.com/thephpleague/oauth2-client


Generic Pull query with filters

Hi,
I have a use case where I need to reuse a pull query for multiple topics with different types of columns to be filtered by. My requirement is that the same call to Kafka is generic and reused for different types of data.
For example I have a materialized view for Sports ("view_sports") which contains records with values
[
    { "SportId": 1, "SportName": "Soccer" },
    { "SportId": 2, "SportName": "Basketball" }
]

And another materialized view for Categories ("view_categories"):
[
    { "SportId": 1, "CategoryId": "1", "CategoryName": "England" },
    { "SportId": 1, "CategoryId": "2", "CategoryName": "Spain" },
    { "SportId": 2, "CategoryId": "3", "CategoryName": "USA" }
]

I am trying to have a pull query which should be a single generic call to kafka, which can query data from both (or more) of these materialized views, and also be able to take corresponding filters for their respective column names.
For example, to be able to query all data when needed like the following
SELECT * FROM view_categories;

as well as add different column name parameters as filters (for different topics):
SELECT * FROM view_categories WHERE CategoryId = '1';

or
SELECT * FROM view_sports WHERE Sport = '2';

So basically I would need to be able to return a List from multiple topics and be able to filter the different topics dynamically.
I have tried something like declaring different KSqlDbStatement and hardcoding them, while adding SessionVariables and using a switch to change the statements, like the following:
string categoryId = "1";
string sportId = "1";
KSqlDbStatement statementCategories = new("SELECT * FROM view_categories WHERE CategoryId = ${categoryId};")
{
    SessionVariables = new Dictionary<string, object> { { "categoryId", categoryId } }
};

KSqlDbStatement statementSports = new("SELECT * FROM view_sports WHERE SportId = ${sportId};")
{
    SessionVariables = new Dictionary<string, object> { { "sportId", sportId} }
};

var response = await kSqlDbRestApiClient.ExecuteStatementAsync(statementCategories);

var content = await response.Content.ReadAsStringAsync();

var list = System.Text.Json.JsonSerializer.Deserialize<IEnumerable<JsonElement>>(content);

The following piece of code returns a BadRequest in the response object. Am I maybe sending the variable wrong?
Alternatively, going with the KSqlDbContext object instead of KSqlDbRestApiClient, I saw some examples that show this is possible, however because they are strongly typed this does not fit my use case. Is there a way to define multiple column names which would be hardcoded, but ultimately return a List<object> instead of a strongly typed object?
string sportId = null; // for ex would be null if we do not wanna filter by this column
string categoryId = "1";
string materializedView = "view_categories";

List<object> list = await context.CreatePullQuery<object>(materializedView)
    .Where(sportId == null || "SportId" == sportId) // does not compile, just for clarity what I am trying to achieve
    .Where(categoryId == null || "CategoryId" == categoryId) // does not compile, just for clarity what I am trying to achieve
    .GetManyAsync()
    .ToListAsync();

Any help is appreciated, thanks in advance!

Hello @fsimonovskiii,
Why isn’t it feasible for you to switch between different type-safe queries?
context.CreatePullQuery<Category>
context.CreatePullQuery<Sport>

Here’s a workaround you can try in the meantime, but you will need to handle the raw data in the response:
PropertyInfo? propertyInfo = typeof(KSqlDbStatement).GetProperty("EndpointType", BindingFlags.NonPublic | BindingFlags.Instance);

propertyInfo?.SetValue(statementCategories, EndpointType.Query);

Hello @tomasfabian
Thank you for the quick reply. I like the CreatePullQuery option better too, however due to the nature of this endpoint needing to be dynamic, I would need to define the different models per topic, and then create different contexts' depending on the filters needed. I was thinking of a wat where I could go with just a single definition of the context that would generate a dynamic object.
I was just wondering if there is some easy way to achieve this that I was not seeing clearly.

Another option would be to expose a new function for the KSqlDbRestApiClient:
  Task<HttpResponseMessage> ExecuteQueryAsync(
        KSqlDbQuery ksqlDbQuery,
        CancellationToken cancellationToken = default (CancellationToken));

Or something like this (just a prototype):
    public class QueryResult ExecuteQueryAsync(KSqlDbQuery ksqlDbQuery, CancellationToken cancellationToken = default(CancellationToken));

    public class QueryResult : HttpResponseMessage
    {
      public IEnumerable<Row> Rows { get; }
    }

    public record Row : String
    {
    }

It would be great if you could share both your insights and your approach as well.

Or perhaps it would be better to extend the KSqldDbContext, as the KSqlDbRestApiClient is already quite large:
    public class QueryResult ExecutePullQueryAsync(KSqlDbQuery ksqlDbQuery, CancellationToken cancellationToken = default(CancellationToken));


v4 docs Update Table Responsive to include `.table-responsive{-sm|-md…

…|-lg|-xl}`

@Johann-S I think this one should be labeled under docs.

Oups my bad thanks @pat270 👍


show unpublished content on next js

We have a page based on a content type, that needs to be visible on next js side, because the user can publish and unpublish it from the front end.
is this possible to activate preview mode on the client by using a specific user even if the we have a static page generated with getStaticProps?
the preview mode in Drupal via iframe is working, I need it on the front end site.

Do you have user authentication on the Next.js site?

Do you have user authentication on the Next.js site?

Yes I do.
I was able to solve it by switching to getServerSideProps and passing the user that create the content, but I wonder if there is a solution using getStaticProps and preview.

I think you could solve this with Preview URLs or using a custom page and getServerSideProps.

When you view a page in Drupal, there's a View button on top of the iframe. You can click to open the preview on the Next.js site. This URL is generated by a preview url generator. You could use these URLs to share with the front-end team for content review. The preview URLs have an expiration date which you can configure.

The other solution that could work is a custom page on your Next.js site which is behind authentication. It can use getServerSideProps to pull in unpublished content.

Something like this:
// pages/preview.tsx
export default function PreviewPage({ node }) {
  // render preview content type here
}

export async function getServerSideProps(context) {
  // Check for auth.
  if (!notAuth) {
    return {
      redirect: ...
    }
  }

  // Load node from ?path query.
  const path = context.query.path
  const node = await drupal.getResourceFromContext(path, context)

 return {
   props: {
     node,
   }
 }
}

Then visiting https://nextjs-site.com/preview?path=/foo/bar will allow the logged in user to view /foo/bar on Next.js

Thank you very much, always very helpfull


License

I noticed that this project lacks a license. Is this intentional?

I didn't bother because the code shouldn't be used in any final product; it's just a tool. I went ahead and added one in 6d4f5337214f85b36bb2eee920ec546f69067669 if it benefits anyone though.

By default, all rights are reserved until you say otherwise - including use of the software. I just wanted to feel safe with the rights clearly explained :sweat_smile:
Thanks for adding a license!


don't pass the solver tautological monomial constraints?

per #601

Closed by the commit referenced above.


Android AAR built with MEDIAPIPE_DISABLE_OPENCV ON running failed

Please make sure that this is a build/installation issue and also refer to the troubleshooting documentation before raising any issues.
System information (Please provide as much relevant information as possible)

OS Platform and Distribution (e.g. Linux Ubuntu 16.04, Android 11, iOS 14.4):
Compiler version (e.g. gcc/g++ 8 /Apple clang version 12.0.0):
Programming Language and version ( e.g. C++ 14, Python 3.6, Java ):
Installed using virtualenv? pip? Conda? (if python):
MediaPipe version:
Bazel version:
XCode and Tulsi versions (if iOS):
Android SDK and NDK versions (if android):
Android AAR ( if android):
OpenCV version (if running on desktop):

Describe the problem:
I use this cmd to build face mesh android AAR:
bazel build -c opt --define MEDIAPIPE_DISABLE_OPENCV=1 --strip=ALWAYS --host_crosstool_top=@bazel_tools//tools/cpp:toolchain --fat_apk_cpu=arm64-v8a,armeabi-v7a --linkopt="-s" //mediapipe/examples/android/src/java/com/google/mediapipe/apps/aar:mediapipe_face_mesh.aar
The compile process succeed and there is no opencv3 library inside the AAR. Then I use the AAR in an example project but it report libopencv3.so not found when I dlopen the libmediapipe_jni.so.

Hi @junnikokuki, Could you please provide the logs to understand the issue much better. Thanks!

Hi @junnikokuki, Could you please provide the logs to understand the issue much better. Thanks!

There is no log, sorry, but this is because the libmediapipe_jni.so is still linking with libopencv3.so even though MEDIAPIPE_DISABLE_OPENCV is set to 1. Maybe the MEDIAPIPE_DISABLE_OPENCV is not fully support the face mesh, lacking document.

Hi @junnikokuki, Could you please point us the documentation of the command you are trying and let us know your use case with disabling the opencv?

This is for a new flag for reducing the package size when only gpu graphs are needed. We don't document this because it's currently for internal use.

This is for a new flag for reducing the package size when only gpu graphs are needed. We don't document this because it's currently for internal use.

OKey, when will this flag go public? Or any flag that can link the opencv static?

This is for a new flag for reducing the package size when only gpu graphs are needed. We don't document this because it's currently for internal use.

OKey, when will this flag go public? Or any flag that can link the opencv static?

We plan to remove the opencv dependency. So, optimizing the way to link opencv is not on the roadmap.


Add scalr_enable_ssh_root_login .kitchen.yml setting

Thanks for the contribution @daxgames !
I merged this to a temporary branch here, and I'll merge to master after a few cosmetic changes.

@AloysAugustin - No problem, I can't take all the credit.  A guy I work with figured out how to do it, I just made it configurable.


HSEARCH-1828 Clarify documentation about ways to disable Hibernate Search

https://hibernate.atlassian.net/browse/HSEARCH-1828

@Sanne Merged, thanks. Nice to see you here ;)


Role label is not being set on all master nodes in HA setups

Thanks for helping us to improve k3s! We welcome all bug reports. Please fill out each area of the template so we can better help you.  You can delete this message portion of the bug report.
Version:
v0.10.0-alpha1
Describe the bug
role label is not being set on master nodes in HA setups, after debugging it looks likes controller informers are only started on the leader nodes, so cache is not working in the setMasterRoleLabel() function
To Reproduce
Start k3s in HA mode with multiple masters
Expected behavior
All master nodes should have role "master"
Actual behavior
Only the first node gets the role master

Verified using v0.10.0-rc1


v0.5.1 Documentation

Update to documentation!
https://gme5078.github.io/data-profiler/

What specifically are the changes here? Hard to figure out when all of it is new.


Mongoengine

I did a bit of cleanup on auth and projects but didn't make any changes otherwise - feel free to discard my changes to those!

Ok, since this is closed I'll just edit the code inline rather than doing a code review here.
In the future, please leave PRs open so that they can be reviewed.

Right, sorry! I'll leave them open in the future - it's mostly changes to database-connection-mongoengine, importing stuff into src_init_.py and importing more stuff into src\resources\person.py, if that helps...


[AIRFLOW-6112] [AIP-21] Rename GCP SQL operators and hooks

PR contains changes regarding AIP-21 (renaming GCP operators and hooks)

renamed GCP SQL operators and hooks
added deprecation warnings in contrib modules
updated UPDATING.md file
fixed tests

[ ] Description above provides context of the change
[ ] Commit message contains [AIRFLOW-XXXX] or [AIRFLOW-XXXX] for document-only changes
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@be812bd). Click here to learn what that means.
The diff coverage is 56.56%.

@@            Coverage Diff            @@
##             master     #563   +/-   ##
=========================================
  Coverage          ?   84.48%
=========================================
  Files             ?      679
  Lines             ?    38584
  Branches          ?        0
=========================================
  Hits              ?    32596
  Misses            ?     5988
  Partials          ?        0

Impacted Files
Coverage Δ

airflow/models/connection.py
68.78% <0%> (ø)

airflow/contrib/operators/gcp_sql_operator.py
0% <0%> (ø)

...irflow/gcp/example_dags/example_cloud_sql_query.py
98.33% <100%> (ø)

airflow/gcp/hooks/cloud_sql.py
65.94% <100%> (ø)

airflow/gcp/operators/cloud_sql.py
84.61% <100%> (ø)

airflow/gcp/example_dags/example_cloud_sql.py
100% <100%> (ø)

airflow/contrib/hooks/gcp_sql_hook.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be812bd...1a51cbe. Read the comment docs.


Quick Start cards should be keyboard accessible

When a user is tabbing through the page, the user should be able to focus on a quick starts card, select it by pressing Enter, and then focus should shift to the Quick Start. (Doing this for keyboard users should likewise translate over to screen reader interaction.)
We show an example of something like this in PF cards here for example.

https://www.patternfly.org/v4/components/card#selectable Might fix if catalog view cards use this variant. Might also be fixed by the dark theme bug: https://github.com/patternfly/patternfly-quickstarts/issues/155


Is still maintained?

@shishirmk :+1:

I could use some of the code that's been merged since the last release. So a minor version release would help 👍

@shishirmk Thanks for the great work you've put into this gem. It would be great to see some PRs getting merged. Can Netflix spare any additional resource? Or perhaps an additional community maintainer could be found to help?

With 0 activity for months from a big company, I assume this is now an abandoned project.  This gem is indispensable to my company's workflow across many projects.  We, this community, may have to create an official/unofficial fork for now :(
Considering the backlog of requests we should start with this -> https://github.com/Netflix/fast_jsonapi/pull/411
I'd say it's a good days work for one person to go through everything.  We just need to make sure all the PR's have good test coverage.  All the PR's I looked through are for valid use cases and do not affect performance.
The hard part will be getting everyone onboard.
How

Looks like @jopotts has gotten the ball rolling.  https://github.com/fast-jsonapi/fast_jsonapi
Is it possible to copy a PR to a downstream project?  Let's move the discussion there for now -> https://github.com/fast-jsonapi/fast_jsonapi/issues/1

@sriniwasgr Ping! 😄
If this is maintained it would be great if the readme could be updated, pointing to the new repo.


Having an error that I don't know how to read

Describe the bug
Tried to use this and ran into the error below:
python -m dankcli flower.jpg "When I make a function"
Traceback (most recent call last):
  File "/usr/local/anaconda3/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/anaconda3/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/anaconda3/lib/python3.7/site-packages/dankcli/__main__.py", line 31, in <module>
    font = ImageFont.truetype('fonts/arial.ttf', size=getFontSize(img))
  File "/usr/local/anaconda3/lib/python3.7/site-packages/PIL/ImageFont.py", line 280, in truetype
    return FreeTypeFont(font, size, index, encoding, layout_engine)
  File "/usr/local/anaconda3/lib/python3.7/site-packages/PIL/ImageFont.py", line 145, in __init__
    layout_engine=layout_engine)
OSError: cannot open resource

To Reproduce
Exact stuff you did:
I'm in the Downloads folder where the image is stored (flower.jpg)
2. Exact command typed
python -m dankcli flower.jpg "When I make a function"
python -m dankcli "~/Downloads/flower.jpg" "When I make a function"
Expected behavior
I expected to get an image with text on top
Setup in which bug happened:

OS newest MacOS
Which command line/ terminal used(sometimes cmd on windows can be problematic)
python -m dankcli flower.jpg "When I make a function"

Clearly it can't open the font .ttf but why its happening is the question.
I can't really test on macOS so its gonna be a pickle solving this.

Well mac os fonts are .TFIL, .OTF, .TTC and for general use they are
located in /System/Library/Fonts
I'm happy to help test this with a little direction from you.  I have a
font in my fonts folder that is named ArialHB.TTC
How can I help troubleshoot this for you?  I'm also happy to help with the
python to help detect the OS of the user.
On Mon, Mar 18, 2019 at 9:22 AM Shreyas Gupta<EMAIL_ADDRESS>wrote:

Clearly it can't open the font .ttf but why its happening is the question.
I can't really test on macOS so its gonna be a pickle solving this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sggts04/dankcli/issues/4#issuecomment-473930253, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACuXLkL5nStkUMwKgogxbKwW9Oi3RDu8ks5vX6EqgaJpZM4b5y37
.

So after some digging, it seems the issue isn't a Mac issue, but rather that it fails in such a way that it passes on Windows and not Mac. Looking at the docs for ImageFont.truetype, you can see that it has a fail condition specifically for Windows.
The relevant line in the code was using relative pathing, meaning that it was trying to look for a fonts/arial.ttf file where it was called from. You can check this by putting a print(os.path.abspath('')) in the code and it will print the directory you are calling the module from, not the directory the module is installed in. This coupled with the Windows specific fail safety means that it fails silently on Windows, but fails loudly on Mac. In order to fix this it should use absolute pathing based on the install location of the module, that should fix it.
I will setup a PR in a moment, please test it on your local installs and OS.

@orionwills @dhdavvie should be fixed in v0.5.3
Please do pip install --upgrade dankcli and check again so I could close this.

That fixed it on my end!  Thanks

Great, talked @dhdavvie on discord, and its fixed on his side aswell.
Thanks a lot for the Issue :)


Release the DB connection after it's not needed in WebsocketServer

https://bugzilla.redhat.com/show_bug.cgi?id=1327625

@kbrock SPICE uses multiple sockets for data transmission which can deplete the database connection pool. That was our issue...

@Fryguy : can you, please, review this?

@jrafanie Please review... Is the the right way to release the connection?

@jrafanie @skateman  I'm asking because I'm not sure if there is more to closing a connection given a connection pool might have multiple open connections.

AFAIK the DB connection is lazy-loaded, so even if you close it (return it back to the pool), the next DB query will reopen (fetch a connection from the threadpool).
[1] pry(main)> User.all.length
  User Load (0.7ms)  SELECT "users".* FROM "users"
  User Inst Including Associations (27.2ms - 30rows)
=> 30
[2] pry(main)> ActiveRecord::Base.connection.close
=> #<Thread::ConditionVariable:0x0056143e204cb8>
[3] pry(main)> User.all.length
  User Load (0.7ms)  SELECT "users".* FROM "users"
  User Inst Including Associations (1.1ms - 30rows)
=> 30

AFAIK the DB connection is lazy-loaded, so even if you close it (return it back to the pool), the next DB query will reopen it (fetch a connection from the threadpool).

Are you trying to release the connection and return it to the connection pool or do you want to truly disconnect the connections used by all threads in the current process?

@jrafanie returning the connection should be enough, am i doing it in the wrong way? It solved my problems :)

👍


Kanban Board - Setup - Module 3 - Group Capstone Project

🤝 Team Members:

@ITurres => Missions
@ahmedeid6842 => Rockets

Hi there! I hope all is well.
Here is the link to our Project Kanban: spaceX-travelers-hub / Kanban
In this case, we are a group of two people.
Thank you very much for your review ✨

If you require additional information or have any questions, please feel free to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres or my partner Ahmed Eid. We'll be happy to assist you. 🎯

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights 💯

Descriptive info ✔
Tasks distributed equally ✔

Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi, @gemmen29 George! Thank you for reviewing this issue! Cheers, and happy coding! 🎯

Hi, @gemmen29 George! Thank you for reviewing this issue! Cheers, and happy coding! 🎯


Adds support for multiple versions of an API in the same declaration file.

It is currently not possible to define multiple versions of an API in a single file.
This PR adds support for this, so we can do things like:
# Multiple versions of an API defined in a single file.
---
  system:
    gateways:
      - name: "test-gw"
        description: "Test Gateway"
        type: "REST"
        config:
          endpoint: "http://localhost:8080/apiman-gateway-api"
          username: "apimanager"
          password: "apiman123!"
  org:
    name: "test"
    description: "Test organisation"
    apis:
      - name: "multi-version-example"
        description: "Multi-version example API V1"
        version: "1.0"
        published: true
        config:
          endpoint: "http://example.com/v1"
          endpointType: "rest"
          public: true
          gateway: "test-gw"
        policies:
          - name: "CachingPolicy"
            config:
              ttl: 60
      - name: "multi-version-example"
        description: "Multi-version example API V2"
        version: "2.0"
        published: true
        config:
          endpoint: "http://example.com/v2"
          endpointType: "rest"
          public: true
          gateway: "test-gw"
        policies:
          - name: "CachingPolicy"
            config:
              ttl: 60

FYI @msavy @EricWittmann


selfhost/main: Create build dir before writing into it

If you do not have a build directory, the selfhost compiler gets an error if it tries to write into that directory.
➜ jakt_selfhost -b -R ~/projects/jakt/runtime hello_world.jakt
Runtime error: Error(code=2)

the signature of mkdir on Windows is different :sweat:

@miller-time - still seems it's not quite finding the right mkdir

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@ADKaster thanks so much for all the corrections!
rebased the branch, squashed all the messy commits...
It still says Call to unknown function: ‘mkdir’ but that's happening during this step:
[3/5] Building jakt file selfhost/main.jakt with jakt_stage0

Does that mean jakt_stage0 compiled with my changes, but for some reason jakt_stage1 doesn't work?

Actually it means that you need to copy your runtime changes over onto bootstrap/stage0/runtime, including the prelude changes.
The stage0 compiler uses its own copy of the prelude to compile things when using the CMake build, which is distinct from the top level runtime directory used by the stage 1/2 compiler. Since we are using stage0 to compile stage1, the updated prelude functionality needs duplicated.

@ADKaster yeah I just noticed that there's another runtime there (right after posting that message).
I tried copying in my runtime changes, but the error persists. Did I miss something?

You need to do this in stages, apparently.

Add new methods to prelude
build compiler
copy generated stage1.cpp over stage0/jakt.cpp
now you can use the new methods in the compiler itself.

I don't think this is how this was intended to work, but that's the only way I could add a method to the prelude locally.

We could read it at runtime I guess, if we assume its location relative to the runtime dir.

@ADKaster thanks, I think that got me a little closer...
jakt/build/jakt_stage1_main.cpp:55053:6: error: no matching function for call to 'mkdir'

/usr/include/x86_64-linux-gnu/sys/stat.h:389:12: note: candidate function not viable: requires 2 arguments, but 1 was provided
extern int mkdir (const char *__path, __mode_t __mode)


Error status to A-1 note 1 reported as Warn instead of fail

Error status to A-1 note 1 reported as Warn instead of fail
Note 1 says supported data that is received in the error or not available should fail.
PGN 64501 with Supported SPNs 8160, 8162
13:07:31.6569 18FBF53D [8] FF FF 00 00 FF FE 00 00
Found: AFT 1 Diesel Oxidation Catalyst 2 from Exhaust Emission Controller (61):
SPN  8160, AFT 1 Diesel Oxidation Catalyst Intake Pressure: Not Available
SPN  8161, AFT 1 Diesel Oxidation Catalyst Outlet Pressure: 0.000 kPa
SPN  8162, AFT 1 DOC Intake to DPF Outlet Delta Pressure: Error
FAIL: <IP_ADDRESS>.a - N.1 SPN 8160 was received as NOT AVAILABLE from Exhaust Emission Controller (61)
WARN: <IP_ADDRESS>.c - N.1 Exhaust Emission Controller (61) reported value for SPN 8162 (ERROR) is implausible

Add W for warranty to 3.1.20 release issues … here and elsewhere.

Same reporting was used for N.1 and N.8.  I separated them making N.1 a FAIL and leaving N.8 a WARN.


NBT tag support

Hey !
That would be cool to support NBT tags, like unbreakable, costom model data etc...
That way, we could create better GUIS ! :)

Thank you for your idea!

Hey ! :)
Any update on that ? ^^

Working currently on my WarpSystem update, maybe I'll find some time for this on this weekend.
Sorry for this delay!

Okay ! :)
Also, not related to this suggestion, but a in-range radius would be cool (so players need to be like 5 blocs from each other to be able to /trade)

Just take a look into the config.yml ;)

Oh, my bad then :P

Unbreakable tag and custom model data implemented

Thanks ! :D


fix double call chain

AdaptCachedBodyGlobalFilter causes DefaultGatewayFilterChain to get called twice when posted with non-zero body size.
Mono is always empty.
Mono defer = Mono.defer(() -> {
System.out.println("defer");
return Mono.empty();
});
Mono voidMono = defer.switchIfEmpty(Mono.defer(() -> {
//always print
System.out.println("defer-2");
return Mono.empty();
}));
In AdaptCachedBodyGlobalFilter, switchIfEmpty will always get called when the return statement is
reached.
	return ServerWebExchangeUtils
			.cacheRequestBody(exchange,
					(serverHttpRequest) -> chain.filter(
							exchange.mutate().request(serverHttpRequest).build()))
			.switchIfEmpty(chain.filter(exchange));

If any filter modifies the response headers without checking the response status, the following exception will throw, the example is from RequestRateLimiter
java.lang.UnsupportedOperationException: null
at org.springframework.http.ReadOnlyHttpHeaders.add(ReadOnlyHttpHeaders.java:84) ~[spring-web-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.cloud.gateway.filter.factory.RequestRateLimiterGatewayFilterFactory.lambda$null$0(RequestRateLimiterGatewayFilterFactory.java:113)

@wiki1024 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@wiki1024 Thank you for signing the Contributor License Agreement!

Can you provide a test case the demonstrates the problem?

Define a route, make sure it's the only route in the application.

@Bean
public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
		return builder.routes()
			.route("test-double", r -> r.path("/test-double")
					.filters(f -> f.addResponseHeader("X-TestHeader", "from-double")
								.retry(3)
					).uri("http://httpbin.org:80")
			).build();
}

Step up breakpoints inside DefaultGatewayFilterChain#filter method, line 118 and line 121 of FilteringWebHandler.java file

@Override
             public Mono<Void> filter(ServerWebExchange exchange) {
                        return Mono.defer(() -> {
                                         if (this.index < filters.size()) {
                              GatewayFilter filter = filters.get(this.index);
                                     DefaultGatewayFilterChain chain = new DefaultGatewayFilterChain(this,
							this.index + 1);
return filter.filter(exchange, chain); //break point 1 here
				}
				else {
return Mono.empty(); // complete break point 2 here
				}
			});
		}

Run the application in debug mode.
do a post with a hello-world body

curl -X POST "http://localhost:8080/test-double" -H  "accept: application/json" -H "content-type:application/json" -d '{"hello":"world"}'

In the debug window, the break point 1 will get hit first (multiple times), then break point 2 , then break point one again(starting with the index 2) , then UnsupportedOperationException will be thrown.

Superseded by 856a2417b6535d54d8f07625dfb48bc5080e87fe


Product Details Cards

Description
Product Details Cards
This project is containing some cards with the details of Products from different websites which may change dynamic updates of a product .
Will be using pure CSS & HTMl with JavaScript
Impportance
One could trace the product details or use it in as an advertisement product to hyperlink in any other web pager.

please assign this project to me @TusharKesarwani

Can you attach any screenshot of what you wish to create? @Imsachin010

Sorry for late reply My CTS are going on I was little bit busy.....Please check.... @zugzwang03
ScreenShort

Please assign me the same


Update license link in README.md

Objective
The LICENSE file in the root directory was removed in #4966. This breaks the license shield link in the README.
Solution
I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.

That is the best link I could come up with, too :+1:

bors r+


[rstmgr_cnsty] Do not hold child handshake under reset

See https://github.com/lowRISC/opentitan/issues/9314#issuecomment-1319471823 for full explanation and rationale.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

@matutem I haven't run all regressions for this just yet.
Which tests would be good to run to test this?

I would run the test at https://cs.opensource.google/opentitan/opentitan/+/master:hw/ip/rstmgr/dv/rstmgr_cnsty_chk/rstmgr_cnsty_chk_sim_cfg.hjson
So
./util/dvsim/dvsim.py hw/ip/rstmgr/dv/rstmgr_cnsty_chk/rstmgr_cnsty_chk_sim_cfg.hjson -i all -r 64 --cov
And look at the FSM coverage with verdi. This change may invalidate any *excl.el file.

@msfschaffner, I had forgotten to configure the exclusion files. You may want to run your test with https://github.com/lowRISC/opentitan/pull/16485.

|  Stage  |      Name      | Tests                 |  Max Job Runtime  |  Simulated Time  |  Passing  |  Total  |  Pass Rate  |
|:-------:|:--------------:|:----------------------|:-----------------:|:----------------:|:---------:|:-------:|:-----------:|
|         | Unmapped tests | rstmgr_cnsty_chk_test |      6.680s       |     10.770ms     |    100    |   100   |  100.00 %   |
|         |                | **TOTAL**             |                   |                  |    100    |   100   |  100.00 %   |

|  SCORE  |  LINE   |  COND   |  TOGGLE  |   FSM   |  BRANCH  |  ASSERT  |
|:-------:|:-------:|:-------:|:--------:|:-------:|:--------:|:--------:|
| 96.80 % | 98.41 % | 91.67 % | 100.00 % | 92.31 % | 98.44 %  | 100.00 % |


Add option to remove all Amplitude cookies for current domain + sub domains

It would be handy to have a function built-in that deletes all Amplitude cookies.
It's become necessary to delete cookies upon end-user consent revokation (GDPR), and since Amplitude generates cookies with dynamic names, they're a bit hard to delete the traditional way.

Any update on this ? Can't the setOptOut method be updated to also clear cookies ? maybe add a flag

@kelvin-lu Hello i think i can work on this enhancement, can you assign this to me?

Any update on this?


[GOBBLIN-282] Azkaban templates

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-282

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@htran1 can you review?


page not available when you click on Back link on new field group form

The Back link on the form displays 'The page you were looking for doesn't exist.
You may have mistyped the address or the page may have moved'. However, you are able to go back using the back button in the browser.

You should be able to fix this one Marwan. Check the link that is generated for the button.


Documentation on specific options for avoidOptionals

I've been looking into the docs on the avoidOptionals config option and have found it difficult to understand the exact meaning of each of the sub-options when providing a AvoidOptionalsConfig object (defined here) as the value.
Here's how I understand the options:

field: Field of a type (using the GraphQL type declaration).
inputValue: Fields on a GraphQL input type. Though I did have to double check that this did not refer to variable inputs for queries/mutations.
object: No idea.
defaultValue: I think this would be when setting a default value for a query/mutation. Not sure, but also I haven't used a default value on a query/mutation in my codebase.
resolvers: (Not listed in docs) I think referring to client-side resolvers. Really not sure, but haven't used those in my codebase either.

Can someone who knows add docs about what each of these fields do? Thank you!

Hi @henrywoody,
You are right, there is some documentation missing on some specific sub-options of avoidOptionals.
Here is some information on the undocumented parts:

object: applies to object type in a conditional context (ex: when using @skip that results in an optional union of objects)
defaultValue: subset of inputValue option, applies to input object arguments (to add or not ? to argument with default value)
resolvers: applies to the fields of the Resolvers type generated by typescript-resolvers

Let me know if you need further information!

it would be better to have more descriptive names for these.

it would be better to have more descriptive names for these.

@pvinis what do you recommend?


Source code for route file getting modified by the CLI

Describe the bug
In my app I'm using double quote by default. Running tsr watch/tsr generate will update the code to use single quote. Is there a way to work around this?
export const Route = new FileRoute("/")

becomes
export const Route = new FileRoute('/')

Your Example Website or App
any of the file-base routing examples
Steps to Reproduce the Bug or Issue
NA
Expected behavior
NA
Screenshots or Videos
No response
Platform
NA
Additional context
No response

Currently it's hardcoded:
https://github.com/TanStack/router/blob/beta/packages/router-cli/src/generator.ts#L186-L189
But could be made configurable...

A very easy solution for this use-case would be to use prettier and configure a script to run prettier immediately following tsr generate in package.json:
"scripts": {
  "generate-and-format": "tsr generate && prettier --write 'src/[yourRoutesDirectory]/*.{js,jsx,ts,tsx}'"
}

Then any time you'd run tsr generate you can instead run npm run generate-and-format to achieve the desired formatting.

why is it necessary to pass path to FileRoute when path is computed from the file path?

TypeScript has no idea what file you’re in, or at least doesn’t expose it for use as a type.

oh I was under the impression that the type inference would come from the generated routeTree file, rather than the path that gets passed to FileRoute.

It needs both. The path in the type is the key to getting the routes parent types.

#894 (released in v1.0.6) adds a configuration option for the quote style.

appreciate your fast response on this


Allow Id value to only include export name?

Hi,
Nice library. I would like to configure the options so that the generated id value only includes the exportName, resulting in much shorted id values. I'm happy to do the work if you'll accept such a feature as a PR?
I was thinking that this could easily by achieved by allowing the removePrefix option to also allow a value of true when includeExportName is also true. Example .babelrc:
{
  "plugins": [
    ["react-intl-auto", {
      "removePrefix": true,
      "includeExportName": true
    }]
  ]
}

Using the example from the readme, this would result in:
// before
export const test = defineMessages({
  hello: 'hello {name}',
})

// after
export const test = defineMessages({
  hello: {
    id: 'test.hello',
    defaultMessage: 'hello {name}',
  },
})

You might have an preferred alternative, or prefer to add a new property to allow this? Let me know what you think.
Cheers, Adam.

Thanks for reporting the issue 👍
Good point.
I agree with you.
I am looking forward to your PR 😀


Bug: The response format is inconsistent for the API endpoints

The /pages/api/modifyuser.js expects a JSON object, whereas the other api endpoints expect a string.  Can we make all of the api endpoints consistent?
Check out components/updateUserForm.js as a good place to start investigating.

I am working on this issue.


Respect fomlyConfig.errorExistsAndShouldBeVisibleExpression

Here is my global app config function where I specify under what conditions validation should appear
function config($locationProvider, formlyConfigProvider) {
        $locationProvider.html5Mode(true).hashPrefix('!');

        formlyConfigProvider.extras.errorExistsAndShouldBeVisibleExpression = function($viewValue, $modelValue, scope) {
            return (scope.fc.$touched && scope.form.$submitted);
        };
    }

When using ng-messages directly I can set the display expression as
<ng-messages for="form.$submitted && form.myField.$error"> or <ng-messages for="searchForm.$submitted && searchForm.myField.$touched">.
Should formlyConfigProvider.extras.errorExistsAndShouldBeVisibleExpression give me a way to interact with that for attribute on ng-messages?
Or in the case of the messages wrapper for these templates I want to be able to modify ng-messages="fc.$error" with errorExistsAndShouldBeVisibleExpression

Look at this: https://github.com/formly-js/angular-formly-templates-material/commit/7d3c9b9ace04987938ddbe26268a4bcea4ac6d41

It's a shortcut for options.validation.errorExistsAndShouldBeVisible (docs)
It returns boolean value basing on this rule field invalid && (field touched || validation.show).
So if you want to force showing validation messages on some field you can set validation.show: true.

About errorExistsAndShouldBeVisibleExpression. You can use it now.

If you're able to test it, I would be grateful. Please let me know if it works and this is what you wanted to achieve.

@kamilkisiela This looks like it is working correctly now. I am able to globally set the conditions for showing error messages through `formlyConfigProvider.extras.errorExistsAndShouldBeVisibleExpression
Thanks!`


Simplify dispatching to annotation handlers

This is mostly a cleanup PR for #5403 simplifying the selection conditions for the various with_annotation tag_dispatch overloads.

retest

I've only rebased this (squashed two commits together). This should be ready to go otherwise. Thanks @hkaiser again for looking into this.


Make required work

Because of required can't run together with readonly. So I try to remove the readonly and apply javascript way to restrict user to type.

Coverage remained the same at 96.401% when pulling 41455c3a1a01fbf6638d56de7b4659a86a671e8c on isatrio:master into 0a0cc7e9f16f36f5cc47457eebe546ca4b96bbb8 on charliekassel:master.

This is not needed anymore as the datepicker is now typeable


generalException when uploading files with specific name to OneDrive for Business

Category

[ ] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
The problem is with a file named 2016_06_01_000002_create_oauth_access_tokens_table.php. OneDrive for Business should have no problem with this file.
Observed Behavior
Uploading data into the file named 2016_06_01_000002_create_oauth_access_tokens_table.php via the uploadUrl returned by createUploadSession causes HTTP/1.1 401 Unauthorized with body {"error":{"code":"generalException","message":"General exception while processing"}}.
Some headers returned with the 401:
Date: Sat, 22 Dec 2018 18:16:18 GMT
Sprequestguid: eb94ae9e-4011-7000-725f-e1fa9d297fd5
Request-Id: eb94ae9e-4011-7000-725f-e1fa9d297fd5

Steps to Reproduce

POST /v1.0/drives/b!<REDACTED>/root:/2016_06_01_000002_create_oauth_access_tokens_table.php:/createUploadSession to create an upload session for the file
PUT any data into the file via the uploadUrl returned by the previous query

This is a summary of an issue for rclone; the original post can be found here: https://github.com/ncw/rclone/issues/2859
Thank you.

This issue should now be resolved - please let us know if you're still seeing issues.

No problem now. Thank you!


(This isn't relevant for VM and container-based builders, since the VM or container kill everything when they exit)
But on OS X and other weirder builders where we run the buildlet in reverse-dialing mode, I sometimes see stray processes. Like this:
Notice testgo spinning:

(I think @ianlancetaylor fixed that bug, but still.... we should be tolerant of such bugs in the future)
This is a tracking bug to make the buildlet smarter: enumerate processes at start and end, and kill new things which didn't go away on their own, especially if they're owned or parented by us. Maybe scan the process list often during builds to learn parents, so we know if they were ours or not.
/cc @zombiezen @adg

/cc @dmitshur


lots of console log

On version 3.2.4-17, lots of console logs are generated by each key press.
I see it may be from line 440 of inputmask.js

@afattahi54 ,
Yes, I know.  I will remove it with the next commit.

Thanks !


Implement Shortest Route

Figure out the shortest route between two points in the universe. Optionally routing through a number of required intermediaries.
Variant of travelling salesman.

Closing, now tracking on gitlab all open issues from github.


Use LIGHTSPARK_EXAMPLE_BASE_URL for consistency.

#44  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zhenlu and the rest of your teammates on  Graphite

Merge activity

May 6, 2:57 PM EDT: @zhenlu merged this pull request with Graphite.


runClient task fails

As stated in the title, when trying to execute the "loom>runClient" task everything compiles successfully and is successfully assembled into a jar, but upon launching the task fails with the following error:

Task :runClient FAILED
4 actionable tasks: 3 executed, 1 up-to-date
Exception in thread "main" java.lang.ClassCastException: class jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and java.net.URLClassLoader are in module java.base of loader 'bootstrap')
at net.minecraft.launchwrapper.Launch.(Launch.java:34)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':runClient'.

Process 'command 'C:\Program Files\Java\jdk-<IP_ADDRESS>\bin\java.exe'' finished with non-zero exit value 1

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 13s
3:37:30 PM: Execution finished 'runClient'.
I am using IntelliJ and have set the Gradle jdk to 17 and the project jdk to 1.8 as stated in the readme.
It seems, that the task tries to open Minecraft using the jdk 17 despite requiring jdk 1.8 to run. That is what I have found out, based on the Exception.
Running the mod with a fresh forge installation via the Minecraft launcher works fine. It's only the "runClient" task having issues.
I've attached the gradle config and build files as .txt here, in case that is important.
settings.gradle.kts.txt
gradle.properties.txt
build.gradle.kts.txt

The runClient task currently does not work with loom in general in older versions. Please use the genIntellijRuns task to generate a run configuration and run this configuration.

Thanks for the clarification.
Works like a charm!


refactor: addon switched to operator

build: bump version to 0.1.0
refactor: rewrite the addon as an operator
refactor: updated Container file for new build
refactor: updated kustomize files for the new build
refactor: refactor Makefile for the new build
docs: refator docs for the new build
ci: refactor ci for the new build

Deployed and tested with tag [0.1.0])(https://quay.io/repository/ecosystem-appeng/regional-dr-trigger-operator?tab=settings).


Use additional C++ include directories

I have a simple question, is it possible to use additional C++ include directories and to write include statements like
#include <mylib/file.hpp>

Hi,
You want include line "#include <mylib/file.hpp>" into djinni generated header files?
Or you want add a prefix into djinni generated header files?
Ty.

Not sure what you mean by additional include directories precisely.
There are command-line arguments which can let you add a configurable prefix to includes of various types of files.  For instance cpp-include-prefix defined here: https://github.com/dropbox/djinni/blob/master/src/source/Main.scala#L130
Djinni always writes includes in quotes like "foo.hpp" not angle-brackets like <foo.hpp> so if that's a distinction you were trying to make it's not something Djinni can do out of the box.

You dont have problems about include it in your implementation. In your .cpp file (implementation file) include your files:
#include "MyDjinniClass.hpp"
#include <grpcpp/grpcpp.h>

void MyDjinniClass::method() {
    // example
}


Feature Request: Allow users to search local library

Hi there!
Excalidraw (within VS Code) is my Go-To drawing & sketching tool for various IT projects I'm working on. IMO, excalidraw has a wonderful, fresh and neat look that's great - esp. for the non-techie crowd - to comprehend.
I often use libraries and have imported quite some into my local stash. One thing I'm missing though is a search function - just like on the excalidraw library website. Am I missing something or would this be an enhancement?
Thank you so much for you work!

Thanks for the hint! I found an open issue #6802.
I'm closing this issue then. Keep up the good work, excalidraw devs! 💪🖤

closed


Update docs

[x] Add solve out file
[x] Add Messages after solve
[x] Display model tree
[x]  Add image for boundary conditions
[x] Remove enums which are already imported
[x] Add assert statements to check solve is completed


fix(windows): Fix Windows System User build failures by using the current directory for bundling tools (fix: 9895)

Closes #9895 with details on the issue there.
As a summary: Tauri uses Wix/NSIS toolsets for bundling .msi and .exe files respectively. Currently, it installs/retrieves these toolchains from the user app directory. However, this approach fails if the current user is a System user, since their app directory (the system directory) is restricted, which results in the bundling failing due to unusable Wix/NSIS executables.
This PR solves the problem by instead installing/retrieving the Wix/NSIS toolset from the current project directory, in target/tools. For example, Wix would be at target/tools/Wix. This would:

Be a known location that should be accessible, since it is the current project's workspace.
Enable deterministic builds across different Windows Users, since the tools are in the project's workspace rather than being user-specific
Enable controlled builds for the same Windows User across different Tauri projects, in case support comes later to use a specific version of these tools for a specific project.
Better support as-is offline builds wherein these tools can be configured in the project's workspace ahead-of-time (rather than configuring them on-the-fly).

Tested this code change locally:

cargo test
cargo clippy
Using it on my Windows machine with Tauri Quickstart guide example, to generate .msi and .exe (tests Wix and NSIS flows, respectively). They both built successfully. Also confirmed both of them work for app installation

Agreed with Amr, just wanted to mention that this would need a proper target dir detection (similar to how the bundle/ folder gets placed) because <cwd>/target/ is simply incorrect tbh.

Great callout, thank you folks. I like the suggestion to keep the existing behavior as default given it is more optimal for most use cases. I've put the feature behind a feature flag in the Tauri config json with schema validation.  I believe this approach accomplishes the best of both worlds: gating the feature, but also minimizing risk of build errors associated with CLI usage and flags, by leveraging the feature via schema validation. After all, someone who needs this feature needs this all the time, so setting it once in the config and being safe would be preferred (at least speaking from the voice of one such person who wants to consume this fix).
Tested that the new json config property is fully optional. If not provided at all, defaults to false (aka existing behavior). Also tested if false is explicitly provided (again, existing behavior). Finally, when true is provided (new behavior, working).
As for the callout on getting to target directory more correctly, good callout. I updated it to traverse up one from the available project_out_directory. Do let me know if you are aware of a better way to get to the target directory. I also considered just putting these tools directly in project_out_directory but it name conflicts with existing folders there wix and nsis which are holding intermediate artifacts.

As per offline discussion in Discord, moved the feature from bundle.windows up to bundle directly as it could apply to other platforms (though this CR just implements for Windows). Updated docs accordingly and renamed tool folder from tools -> .tauri-tools

I also considered just putting these tools directly in project_out_directory but it name conflicts with existing folders there wix and nsis which are holding intermediate artifacts.

Hmm, maybe something like this (copy pasted from somewhere else in the cli)
  let mut path = get_cargo_metadata()
    .with_context(|| "failed to get cargo metadata")?
    .target_directory;

Using the parent dir of project_out_directory is probably a bit awkward because it will be different if the user uses the --target flag, duplicating the tools at which point you may as well use project_out_directory directly (with the extra .tauri-tools folder) just to be safe.

I just tested this PR and didn't make any changes to tauri.conf.json, I got permissions error on GitHub Actions:

Well, unrelated, I found out that #9902 caused the problem.


Storybook

This PR adds storybook with minimal custom config.
Storybook docs are here
To run storybook: yarn run storybook
Notes

Added tailwind dark mode addon which adds a moon icon in the toolbar that toggles the dark mode class for components. Currently haven't worked out how to change the background behind the components though so this will need some additional work - for now you can change the background  with the background button two to the left of the dark mode one. (PS - for the button story I've implemented, only the neutral intent button is affected by dark mode).
I've added a story for Button just to show how they're written, but you may need to reference docs for more complex stories. Note the JSDoc comments on prop types are pulled into the "Docs" section in storybook, so documenting props will be good practice
When specifying component titles, if you use a folder structure (title: "components/Button",) the components are listed in that structure. For now I suggest we just reflect the file system structure.
Down the line we can also add documentation for non-components - check out mdx stories in the docs.

Reason for resolve in package.json: https://github.com/storybookjs/storybook/issues/13183


scaling pixel offset by distance for billboards from KML files

Great, thanks @theOgrable!  Can you please send us a CLA?  See the Contributing Guide for information on how to do this.

We now have a CLA from @theOgrable, thanks!

I can confirm this fixes the problem.  @bagnell, does this change look good to you?

Looks good, thanks @theOgrable!

@hpinkos update CHANGES.md in master if it is warranted.


New build warnings since switching to Picolibc

Describe the bug
Hi, bumped into few new warnings in the weekly run related to the picolibc switch:
1 - west build -p -b s32z270dc2_rtu0_r52 -T samples/net/sockets/can/sample.net.sockets.can.two_sockets
zephyrproject/zephyr/drivers/can/can_nxp_s32_canxl.c:757:9: warning: '__builtin___memcpy_chk' forming offset [16, 71] is out of the bounds [0, 16] of object 'frame' with type 'struct can_frame' [-Warray-bounds]

can_dlc_to_bytes can potentially return up to 64 bytes, the receiving structure holds either 8 or 64 depending on the configuration, opened https://github.com/zephyrproject-rtos/zephyr/pull/62611 for it
2 - west build -p -b mg100 -T samples/net/telnet/sample.net.telnet
zephyrproject/zephyr/drivers/modem/hl7800.c:1786:74: warning: '%s' directive output may be truncated writing up to 53 bytes into a region of size 21 [-Wformat-truncation=]

This is more interesting, the snprintk return code is handled, and if I understand the warning, it only triggers if the compiler detects that the return value is not used. That said, the handling is a LOG_WRN, which becomes a noop and I guess causes the return value to not being used and the warning to fire if logging is off.
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/modem/hl7800.c#L1786-L1789
I could not figure out a workaround for this, so it may need a #pragma GCC diagnostic ignored "-Warray-bounds". Open to ideas.
3 -west build -p -b cc3220sf_launchxl -T tests/net/lib/mqtt_publisher/net.mqtt
zephyrproject/zephyr/include/zephyr/net/socket_select.h:111:16: error: redefinition of 'struct zsock_fd_set'

and
/opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/picolibc/include/sys/select.h:109:5: error: conflicting types for 'select'; have 'int(int,  zsock_fd_set *, zsock_fd_set *, zsock_fd_set *, struct timeval *)'
...
/usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/include/zephyr/net/socket_select.h:114:19: note: previous definition of 'select' with type 'int(int,  zsock_fd_set *, zsock_fd_set *, zsock_fd_set *, struct timeval *)'

This one seems to trigger because there's an fd_set and select defined in /opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/picolibc/include/sys/select.h, the Zephyr specific select code is then defining its own.
Not too sure how to handle that either, maybe we should use the picolibc definitions when enabled? Tried to hack together a change to do that but it did not work, this may need more than a oneline hotfifx. :-)
@keith-packard do you have any idea of how we could handle the ones above?
To Reproduce
See the commands above.
Expected behavior
No warnings.
Impact
Weekly CI breakage, no super urgent but should be fixed soon, ideally before rc1.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK 16.1
a6756c36e9

Describe the bug Hi, bumped into few new warnings in the weekly run related to the picolibc switch:
1 - west build -p -b s32z270dc2_rtu0_r52 -T samples/net/sockets/can/sample.net.sockets.can.two_sockets
zephyrproject/zephyr/drivers/can/can_nxp_s32_canxl.c:757:9: warning: '__builtin___memcpy_chk' forming offset [16, 71] is out of the bounds [0, 16] of object 'frame' with type 'struct can_frame' [-Warray-bounds]

can_dlc_to_bytes can potentially return up to 64 bytes, the receiving structure holds either 8 or 64 depending on the configuration, opened #62611 for it
2 - west build -p -b mg100 -T samples/net/telnet/sample.net.telnet
zephyrproject/zephyr/drivers/modem/hl7800.c:1786:74: warning: '%s' directive output may be truncated writing up to 53 bytes into a region of size 21 [-Wformat-truncation=]

This is more interesting, the snprintk return code is handled, and if I understand the warning, it only triggers if the compiler detects that the return value is not used. That said, the handling is a LOG_WRN, which becomes a noop and I guess causes the return value to not being used and the warning to fire if logging is off.
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/modem/hl7800.c#L1786-L1789
I could not figure out a workaround for this, so it may need a #pragma GCC diagnostic ignored "-Warray-bounds". Open to ideas.

Maybe just switch to strncpy (yeah, it's hard to use correctly) instead of using snprintk to copy a string?

This one seems to trigger because there's an fd_set and select defined in /opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/picolibc/include/sys/select.h, the Zephyr specific select code is then defining its own.

Yeah, we pretty clearly want to use the zephyr definition instead of the picolibc one -- the zephyr version provides a static inline implementation on top of zsock_select.

Not too sure how to handle that either, maybe we should use the picolibc definitions when enabled? Tried to hack together a change to do that but it did not work, this may need more than a oneline hotfifx. :-)

How is your code managing to include both versions of sys/select.h ? I would have though the one in include/zephyr/posix would have replaced the picolibc one?

How is your code managing to include both versions of sys/select.h ? I would have though the one in include/zephyr/posix would have replaced the picolibc one?

Good question, looks like the include chain is something like:
zephyrproject/zephyr/drivers/wifi/simplelink/simplelink_support.c
zephyrproject/modules/hal/ti/simplelink/source/ti/net/slnetif.h
zephyrproject/modules/hal/ti/simplelink/source/ti/net/slnetsock.h
/opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/picolibc/include/sys/time.h
/opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/picolibc/include/sys/select.h

There's no sys/select.h in the Zephyr include, there's include/zephyr/posix/sys/select.h and then include/zephyr/net/socket_select.h.
Should the posix file there take priority? (cc @cfriedt)
Dropping https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/source/ti/net/slnetsock.h#L201 fixes it as well.

Should the posix file there take priority over the library one? (cc @cfriedt)

I think so -- the library one is just providing a declaration of a function which might exist in the underlying OS -- the Zephyr one is what the underlying OS actually provides.

Dropping https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/source/ti/net/slnetsock.h#L201 fixes it as well.

Hrm. I wonder how sys/time.h ends up pulling in sys/select.h. Twisty include files.

Should probably just remove this from that header.

Dropping https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/source/ti/net/slnetsock.h#L201 fixes it as well.

I think there are a couple of instances around the codebase that have a similar fix.
Might more more of an if / else situation rather than just if.
I'll take a peak in about an hour

@cfriedt I realize only now that that chunk of code in simplelink/source/ti/net/slnetsock.h was meant to prevent exactly this --- is this right? https://github.com/zephyrproject-rtos/hal_ti/pull/32/files#diff-321a64fa87bae1847e9c0db1783858b4c704a99de9b8e7a9f3d591a533ad1922 feels like it unintentionally inverted the condition.

All fixed, thanks for the help!


Sentence Auto Completion added

Pull Request for DL-Simplified 💡
Issue Title : Sentence Auto Completion using Deep learning Algorithm

Info about the related issue (Aim of the project) : The main goal of this project is to develop a deep learning-based auto-complete system that can predict the next word or phrase in a sentence. The purpose of this system is to enhance user typing experience by providing contextually relevant suggestions as the user types.
Name: Ashish Kumar Patel
GitHub ID: <!-- Mention your GitHub ID -->
Email ID<EMAIL_ADDRESS>Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant)  Gssoc'24 contributor

Closes: #840
Describe the add-ons or changes you've made 📃
The LSTM and GRU models both achieved the highest accuracy of 87.41%, making them the best-performing models for the auto-complete sentence task. The BiLSTM model did not perform as well, with a final accuracy of 8.33%. The choice of LSTM and GRU is justified by their high accuracy in predicting the next word in a sentence, making them suitable for this auto-complete application.
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[☑ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[☑ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@abhisheks008 pls check it


[rcore] Fix IsKeyPressedRepeat() for PLATFORM_DESKTOP_SDL

Changes

Fixes IsKeyPressedRepeat() for PLATFORM_DESKTOP_SDL by adding the missing CORE.Input.Keyboard.keyRepeatInFrame handling to PollInputEvents() (R1097).

Removes a duplicated reset loop (L972-L973) that's already present a few lines ahead (R1003-R1006).

Code example
#include "raylib.h"

int main(void) {
    InitWindow(800, 450, "test");
    SetTargetFPS(60);
    while (!WindowShouldClose()) {
        BeginDrawing();
        ClearBackground(RAYWHITE);

        if (IsKeyPressedRepeat(KEY_ONE)) {
            DrawText("1 is repeat", 20, 20, 20, BLACK);
            TraceLog(LOG_INFO, "1 is repeat");
        }
        if (IsKeyPressedRepeat(KEY_TWO)) {
            DrawText("2 is repeat", 20, 40, 20, BLACK);
            TraceLog(LOG_INFO, "2 is repeat");
        }

        EndDrawing();
    }
    CloseWindow();
    return 0;
}

Environment

Tested successfully on Linux (Mint 21.1 64-bit) with SDL2 (2.28.4).

Edits

1: added line marks.
2: correction.

@ubkp thanks for the review and excuse the late response, I'm working on the land picking up olives this week and I'm a bit disconnected from the computer...


Clean Validation Environment workflow fails

Running Clean Validation Environment workflow from templated AzureTRE-Deployment, experiencing the following error:
Clean
Az CLI Login failed. Please check the credentials and make sure az is installed on the runner. For more information refer https://aka.ms/create-secrets-for-GitHub-workflows

This doesn't include much details to help us understand the issue and since we don't own Azure Login action I'm not sure what to do...
Some things you might want to try:

Use the credentials to login in a dev machine to validate they are working
Build a simple workflow to use the credentials and see what happens

If the workflow is supplied with a github secret that is undefined
from clean_validation_envs.yml
  - name: Azure Login
    uses: azure/login@v1
    with:
      creds: ${{ secrets.AZURE_CREDENTIALS }}

What should we set the secret Azure Credential to?  In theory I could use the sptrecore identity for rbac with the following setup below, but we have no guidance on this.
{
"clientId": "",
"clientSecret": "",
"subscriptionId": "",
"tenantId": "",
}

You got this type of an object in one of the initial setup steps that later you've used for the ARM_* secrets (e.g. ARM_CLIENT_ID).
Can you rebuild the object with those secrets and try again?

I am using the ARM secrets as part of the github actions - below are in my Env secrets at this time.
ARM_CLIENT_ID
ARM_CLIENT_SECRET
ARM_SUBSCRIPTION_ID
ARM_TENANT_ID
However, the workflow is looking for AZURE_CREDENTIALS, so my question is, should we add that using JSON as above or is another approach preferred?

Add another secret per the json example you sent.

Doing so will allow login to work, unfortunately the clean ci validation script is not part of the Deployment Repository.
Log output
Run devops/scripts/clean_ci_validation_envs.sh
devops/scripts/clean_ci_validation_envs.sh
shell: /usr/bin/bash -e 0
env:
AZURE_HTTP_USER_AGENT:
AZUREPS_HOST_ENVIRONMENT:
GITHUB_TOKEN: ***
MAIN_TRE_ID: ***
BRANCH_LAST_ACTIVITY_IN_HOURS_FOR_STOP: 2
BRANCH_LAST_ACTIVITY_IN_HOURS_FOR_DESTROY: 48
/home/runner/work/_temp/40f733cb-9622-4df1-bec1-589c79a43466.sh: line 1: devops/scripts/clean_ci_validation_envs.sh: No such file or directory
Error: Process completed with exit code 127.

Tested after latest PR update - same result
Run devops/scripts/clean_ci_validation_envs.sh
devops/scripts/clean_ci_validation_envs.sh
shell: /usr/bin/bash -e 0
env:
AZURE_HTTP_USER_AGENT:
AZUREPS_HOST_ENVIRONMENT:
GITHUB_TOKEN: ***
MAIN_TRE_ID: ***
BRANCH_LAST_ACTIVITY_IN_HOURS_FOR_STOP: 2
BRANCH_LAST_ACTIVITY_IN_HOURS_FOR_DESTROY: 48
/home/runner/work/_temp/61d7a695-3fa3-4778-a6ae-091a7412e7ea.sh: line 1: devops/scripts/clean_ci_validation_envs.sh: No such file or directory
Error: Process completed with exit code 127.


Prism.partial uses a PartialFunction rather than Option.

A helper for construction of Prisms that shortens their definitions
slightly. Very helpful when you have dozens of them strewn across your
codebase.
We use this a lot at @slamdata. Here’s a recently-added batch: https://github.com/sellout/quasar/blob/modernize-sql-expr/core/src/main/scala/quasar/sql/package.scala#L31

I am off for a week, I can review your code next week or another maintainer
can do it in the meantime.
Thanks for your PR :)
On Saturday, 30 April 2016, Greg Pfeil<EMAIL_ADDRESS>wrote:

A helper for construction of Prisms that shortens their definitions
slightly. Very helpful when you have dozens of them strewn across your
codebase.
We use this a lot at @slamdata https://github.com/slamdata. Here’s a
recently-added batch:
https://github.com/sellout/quasar/blob/modernize-sql-expr/core/src/main/scala/quasar/sql/package.scala#L31
You can view, comment on, or merge this pull request online at:
https://github.com/julien-truffaut/Monocle/pull/355
Commit Summary

Prism.partial uses a PartialFunction rather than Option.

File Changes

M core/shared/src/main/scala/monocle/Prism.scala
https://github.com/julien-truffaut/Monocle/pull/355/files#diff-0 (5)

Patch Links:

https://github.com/julien-truffaut/Monocle/pull/355.patch
https://github.com/julien-truffaut/Monocle/pull/355.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/julien-truffaut/Monocle/pull/355

--
Julien Truffaut
Tel : +44 7743 449664

Would you mind to add a test in PrismSpec using partial

It seems that there is a merge conflict, when it is resolved 👍

I thought I had been careful to avoid that, but it looks like my editor adding final newlines caused it.
Should be good now, assuming tests pass.

Awesome, thank you very much @sellout


Update Grafana to 7.5.9

Signed-off-by: Anish Asthana<EMAIL_ADDRESS>
[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
[x] JIRA link(s): https://issues.redhat.com/browse/RHODS-2526
[x] The Jira story is acked
[ ] An entry has been added to the latest build document in Build Announcements Folder.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

This should not be merged until the 1.7 build is in the works

/unhold

Creating a live build image to test this change

lgtm
Tested with image quay.io/modh/rhods-operator-live-catalog:1.7.0-rhods-2526
$ curl ${grafana_url}/api/health
{
  "commit": "NA",
  "database": "ok",
  "version": "7.5.9"
}


feat: report capacity limits in GET Kafka endpoint

Description
Report capacity limits get endpoint - taken over from this PR: https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/853
Verification Steps

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has created for changes required on the client side

:eyes:


Unsupported event type

EventType can be one of Normal and Warning (reference). Error is not a thing and every instance of it needs to change to Warning.
https://github.com/dana-team/rcs-ocm-deployer/blob/2fc8e6d0607faa4587a1c5bca42a389777b90689/internals/controllers/cappPlacement_controller.go#L39
/kind bug

We also need to use corev1.EventTypeNormal and corev1.EventTypeWarning instead of our own constants


Enable observability flag when crating project using template

Purpose

$title

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Lets modify the test cases to assert the build options

The PR is opened to master. Please open it to stage-slbeta6 branch