Error when changing workspace config

I've fot this output when changing some workspace settings.
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
    at validateTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:101:25)
    at documents.onDidOpen (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:46:5)
    at CallbackList.invoke (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:114:39)
    at Emitter.fire (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:178:36)
    at connection.onDidOpenTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/lib/main.js:151:29)
    at handleNotification (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:460:43)
    at processMessageQueue (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:232:17)
    at Immediate.<anonymous> (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:219:13)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
    at validateTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:101:25)
    at documents.onDidChangeContent (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:43:5)
    at CallbackList.invoke (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:114:39)
    at Emitter.fire (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:178:36)
    at connection.onDidOpenTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/lib/main.js:152:38)
    at handleNotification (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:460:43)
    at processMessageQueue (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:232:17)
    at Immediate.<anonymous> (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:219:13)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
[Error - 9:33:24 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined
[Error - 9:34:42 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined
[Error - 9:34:57 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined

This is Mac OS Sierra, vscode 1.13.0

Thanks @ferhtgoldaraz
I'll poke around and see if I can figure out what is up

Hi @ferhtgoldaraz  - I think I have the bug fixed.  Would you be willing to do a quick test for me to make sure what I was seeing was also what you were.  If you uninstall DevSkim, download the vsix install for the bugfix version, and then click on the "..." menu on the extension pane and click "install from VSIX" you should be able to get my bugfix version and check to see if the issue is replicated

Replicated the error exactly as the static trace shows a couple different ways, and the fix seems to address all of the them (and is sort of obvious in retrospect).  Went ahead and pushed a new version to the marketplace.  Please let me know if you still see this error after updating.  If not, I'll close out the issue.  Thanks again - the feedback is super helpful

Ok, I'll test it when I get home. Thx!

I haven't heard more reports of issue so I believe this is taken care of


Blob storage using AppendBlob

Currently logging to blob storage is done via adding a separate xml file to the specified blob container.  However, Azure storage now supports AppendBlobs, which are optimized for logging scenarios.
http://blogs.msdn.com/b/windowsazurestorage/archive/2015/04/13/introducing-azure-storage-append-blob.aspx
Is there any interest in accepting a PR that implements this functionality?

I had the same requirement and have modified the code with a new Appender 'AzureApendBlobAppender'. I am testing this on our environments at the moment though would be happy to share the code (simple cut and paste with very minor code changes) so the this gets added to this core solution.

Would love to add your code to the solution, feel free to create a push request when you feel it is ready

Handled with 12101ef


feat(elements/ino-snackbar): add warning variant

Closes #1130
Proposed Changes

adds a warning variant to ino-snackbar
changes icons for all variants

https://github.com/inovex/elements/assets/103122411/64bc1d5d-0151-4091-80ab-90dcb461d166

@MariaLStefan can you resolve the conflicts?


Fixes bug with inputs in modal and keyboard

Fixes #4 by wrapping dialog around KeyboardAvoidingView

Nah it doesn't work. KeyboardAvoidView needs an encapsulated view. That's how it gets its dimensions


Show comments on statements (frontend)

Maybe make it so it is in the syntax
Alice->Bob: msg; ? $This is a message$

Knowledge should also have the ability to have an comment


[Feature Request] substitute/exchange operator provides 2 motion calls.

For example, if the cursor is on props and press gs<motion1><motion2>, motion1 will replace motion2.
({ props }) -- press gsiwa{ on props

becomes:

(props)

This may seem useless on its own, but when combined with plugins like flash.nvim remote mode, operation can be performed even when the cursor is not on that text.
For example, exchange import and Homepage even cursor is not on them.
https://github.com/gbprod/substitute.nvim/assets/4456413/991a1faa-439b-4695-9eac-fe6c1180c86a
substitute<motion1><motion2> and exchange<motion1><motion2> will make it faster like this.

That's a great idea!
I'll try to do something soon.


Multiline/multi-paragraph descriptions only have the first paragraph wrapped in a block quote

Describe the bug
When a description of a type/input/argument/field includes multiple markdown paragraphs, only the first paragraph is wrapped with a block quote.
To Reproduce
Include \n\n in a field description:
type Foo {
  """
  Paragraph 1.

  Paragraph 2.

  Paragraph 3.
  """
  bar: String
}

Expected behavior

Paragraph 1.
Paragraph 2.
Paragraph 3.

Actual behavior

Paragraph 1.

Paragraph 2.
Paragraph 3.

Thank you @patrys for the report.
Great catch! Hopefully, an easy fix 😊

The fix will be released with the next patch version end of this week.
Example https://graphql-markdown.github.io/group-by/common/directives/doc

Amazing! ✨

@patrys - This is now live in 1.17.0


update tolerance

Related to issue https://github.com/pfnet-research/chainer-chemistry/issues/36
Before PR, test_schnet failes once in three times.
After this PR, test_schnet did not fail with 30 times test in my environment.
Since this is blocking issue to merge another PR, I would like it to be merged.

LGTM


Weird newline in string literal

     fn cxx(&self, target: &str) -> &Path {
         match self.cxx.get(target) {
             Some(p) => p.path(),
-            None => panic!("\n\ntarget `{}` is not configured as a host,
-                            only as a target\n\n", target),
+            None => {
+                panic!("\n\ntarget `{}` is not configured as a host,
+                            \
+                        only as a target\n\n",
+                       target)
+            }
         }
     }

In 0.8.3 (), rustfmt formarts
impl Foo {
    fn cxx(&self, target: &str) -> &Path {
        match self.cxx.get(target) {
            Some(p) => p.path(),
            None => panic!("\n\ntarget `{}` is not configured as a host,
                            only as a target\n\n", target),
        }
    }
}

to
impl Foo {
    fn cxx(&self, target: &str) -> &Path {
        match self.cxx.get(target) {
            Some(p) => p.path(),
            None => {
                panic!("\n\ntarget `{}` is not configured as a host,
                            only as a target\n\n",
                       target)
            }
        }
    }
}

so the weird newline is gone.

This only reproduces with the format_strings option set.

Just setting format_strings does not reproduce the above bug anymore.
However, when the max_width is set to smaller value, the bug gets reproduced.
rustfmt.toml:
format_strings = true
max_width = 50

Output:
impl Foo {
    fn cxx(&self, target: &str) -> &Path {
        match self.cxx.get(target) {
            Some(p) => p.path(),
            None => {
                panic!("\n\ntarget `{}` is not \
                        configured as a host,
                        \
                        only as a target\n\n",
                       target)
            }
        }
    }
}

@nrc @topecongiro I am having a look at this issue and I was wondering if you could clarify the signature of rewrite_string which takes in addition to a format specification an optional max_width: https://github.com/rust-lang-nursery/rustfmt/blob/f711078126f95bd580c69c39af9fc16e3f83c859/src/string.rs#L47-L51
However, it seems that the fmt.width property is enough:

None is passed as argument: https://github.com/rust-lang-nursery/rustfmt/blob/cc2afeca9eda9d85c088479335c3c664d449a7f4/src/expr.rs#L1394-L1398

the max_chars value is actually assigned to fmt.width too: https://github.com/rust-lang-nursery/rustfmt/blob/604764abe15c2742af85c1461e6f8055083e3c0b/src/comment.rs#L441-L452

Could it be that argument is a left-over of a previous refactoring ? Could it be removed ?


fix: ReDoS of postcss

fix: ReDoS of postcss

Codecov Report

Merging #976 (a2a633b) into release-next (168b4ae) will increase coverage by 1.18%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-next     #976      +/-   ##
================================================
+ Coverage         48.93%   50.11%   +1.18%
================================================
  Files                46       47       +1
  Lines              1175     1289     +114
  Branches            284      302      +18
================================================
+ Hits                575      646      +71
- Misses              600      643      +43

Impacted Files
Coverage Δ

packages/postcss-plugin-rpx2vw/src/index.js
0.00% <0.00%> (-92.00%)
:arrow_down:

packages/plugin-rax-kraken/src/index.js
92.64% <0.00%> (-7.36%)
:arrow_down:

packages/plugin-rax-kraken/src/generator.js
77.94% <0.00%> (ø)


ci: Add integration test for HDFS

The new integration test writes a file to HDFS, reads it back,
and makes sure that the result is the same as the original file.

Thanks for the quick review @kklin!


DM-27844: exposurelog: add summit deployment and updated NFS deployment

I really appreciate the corrected secrets values. Updated as per your suggestion.


restructure tasks and classes

@x-tabdeveloping suggest:

We could also potentially fix the task situation by making all Encoder-s have a task attribute.
Then instead of EmbeddingModel we would have an ModelLoader:
class Encoder(Protocol):
     task: Task

     def encode(self, sentences: list[str], **kwargs):
          pass
    # And then optionally the other two methods

@dataclass
class ModelLoader:
    meta: ModelMeta
    loader: Callable[[Task], Encoder]

class Task(Protocol):
     def evaluate(self, loader: ModelLoader) -> TaskResult:
          model = loader(self)
          ...

I agree with there being something here that is not right.
I don't believe the model should be loaded in the task though, this leads to a few issue:

The task conceptually shouldn't change the state of the model (except for the task of course)
It is inefficient to load the model many times (especially for larger models, where it takes a while)

An alternative might be to do:
model.set_task(task)
and the unset the task at the end. This could be done in the run_task or in task.evaluate function.
I also totally agree that we should make sure the differentiate the "loader + metadata" from the encoder in a meaningful way.

The run_task could also be the one that actually loads the model and hands it the task information.

 I would prefer to avoid state changes in code everywhere when possible. Could we not do some closure/currying kinda thing to make this work?

Hmm something like:
def run_task(loader, task):
  mdl = loader.load_model(task=task)

class Loader():
  def load_model(task):
    if self.model_is_loaded:
      self.model.task = task
      return self.model
   else:
        return self._load_model(task)

Hmm actually a structure somewhat like this seems meaningful:

class Encoder():
   "the encoder - the object in charge of all the encoding needs"

   # ideally it shouldn't have a state for task, but only be informed of it here (as well as other encode methods:
   def encode(... task: Task):
      ...

class ModelLoader():
   "dynamic loading of models"
   ...

def SebModel():  # not sure I like the name - especially as it would be seb.SebModel
   "the object that gets passed around"
   loader: ModelLoader
   meta: ModelMeta

Since we can't change the code in MTEB, we need to have some way of passing the task to the encode methods. This is the reason for the MTEBTaskModel. Which worked like a partial but for the class. It might be smarter to "overwrite" the encode method.
A smarter way in the MTEBTask might be to do:
original_encode = model.encode()

model.encode = partial(original_encode, task=task)
mteb_task.evaluate(model)
model.encode = original_encode

We discussed in meeting, something like this:
SebModel:
model: Encoder
meta: ModelMeta
LazyLoadEncoder(Encoder)
…
def encode():

@KennethEnevoldsen Pydantic fucks us over a bit.
  File "/home/au689890/Documents/Github/scandinavian-embedding-benchmark/src/seb/interfaces/mteb_task.py", line 73, in evaluate
    model.encode = partial(model.encode, task=self)
  File "/home/au689890/anaconda3/envs/seb/lib/python3.9/site-packages/pydantic/main.py", line 789, in __setattr__
    raise ValueError(f'"{self.__class__.__name__}" object has no field "{name}"')
ValueError: "EmbeddingModel" object has no field "encode"

convert it to a python dataclass instead

@KennethEnevoldsen I'm thinking it would actually not be stupid to do a shallow copy of the model object and override the encode method. That way we wouldn't have to do all this gymnastics with the try-catch blocks and all

So do you suggest an MTEBTaskModel?

No, because MTEBTaskModel would not by default have the same attributes (encode_query, encode_documents) so it is not the same. What I mean is a new object that has the same attributes but we overwrite encode with the partial

My concerns have been addressed by the merged pull request, I'm closing the issue.


Impossible to return to previous application

Test case:

Click torrent file attachment in telegram (probably same behavior in any other app)
Torrent file will be opened in transmissionic
Now try to go back (with button or swipe) - it's impossiple to return to telegram. You have to press home button and open telegram from scratch.

As I see it, tranmissionic does not handle back action, like chrome browser for example.

Thank you for reporting this issue, I've encountered this bug before but I wasn't sure where it came from.
I was planning to rework the back button handling in the next version, so I will try to fix this bug at the same time.

This is fixed in v1.1.8, and the back button should work better in browsers now.


Support for other GPUs (Intel Arc, AMD)

Hiya, I used to use your software initially through github then through steam on my GTX 1060, but I've since updated to an Intel Arc A770 and now when loading any model on your application it goes directly to CPU inference.
Is it possible you could make it compatible for usage with other GPUs? I noticed the barracuda model that's build in runs on my GPU but everything else does not.

The NN framework it uses (other than Unity.Barracuda) is OnnxRuntime, and it uses CUDA (and cuDNN) when the GPU toggle is on (code here). OnnxRuntime supports other ones other than CUDA (see here, the factory methods starting with MakeSessionOptionWith), I can add an option to use these, but there're some problems:

The official OnnxRuntime build does not include providers other than CUDA and TensorRT, so probably it has be built from the source to use them.
Intel GPUs don't seem to support either CUDA or ROCM, maybe TVM would work?

By the way, can you send me the error message on the console (backtick `) it prints when it fails to load the model?

There isn't an error upon failing to load the model. It loads the model and runs inference on the CPU instead of the GPU I use, which is an Arc A770 LE.
I was mainly hoping for this software to support AMD and Intel arc universally.

It appears that in your previous Nvidia environment OnnxRuntime would load CUDA when it is detected. It's weird, since in my I have to explicitly declare CUDA to be used. If you turn on the use cuda toggle it would throw an exception, right?
On the other hand, I'll test some GPU execution providers other than CUDA such as DirectML (seems promising for the Intel GPUs), OpenVINO, TVM and ROCm.

I never tested that, and I probably should have. However, due to specific other issues regarding drivers from my old hardware setup I have since reset Windows 11. Either way, I'm greatly appreciative that you intend on trying to implement the other GPU exec providers as it opens up availability for this software on other hardware.

Using the same method this program is using CUDA for OnnxRuntime, I used onnxruntime.dll from Microsoft.ML.OnnxRuntime.DirectML v1.14.1 and the matching version of the managed Microsoft.ML.OnnxRuntime.dll, and tried to load it, only to be met by
Microsoft.ML.OnnxRuntime.OnnxRuntimeException: [ErrorCode:RuntimeException]
  at Microsoft.ML.OnnxRuntime.NativeApiStatus.VerifySuccess (System.IntPtr nativeStatus) [0x0002c] in <1f49930870034b16a79abbd8ce8f4b49>:0
  at Microsoft.ML.OnnxRuntime.SessionOptions.AppendExecutionProvider_DML (System.Int32 deviceId) [0x0000d] in <1f49930870034b16a79abbd8ce8f4b49>:0

Using DirectML.dll and DirectML.Debug.dll from Microsoft.AI.MachineLearning gave me the same result.
Using the DLLs I built from the source:

DirectML
Same error message as above.

OpenVINO

Microsoft.ML.OnnxRuntime.OnnxRuntimeException: [ErrorCode:RuntimeException] D:\codes\onnxruntime\new\onnxruntime\onnxruntime\core\session\provider_bridge_ort.cc:1106 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\codes\DepthViewer\DEPTH\Assets\Plugins\OnnxRuntimeDlls\win-x64\onnxruntime_providers_openvino.dll"

  at Microsoft.ML.OnnxRuntime.NativeApiStatus.VerifySuccess (System.IntPtr nativeStatus) [0x0002c] in <56cc2af98561469babdd24bc23371de1>:0
  at Microsoft.ML.OnnxRuntime.SessionOptions.AppendExecutionProvider_OpenVINO (System.String deviceId) [0x00027] in <56cc2af98561469babdd24bc23371de1>:0

DLL fails to load, maybe because there's no hint to locate the OpenVINO directory in my environment

TVM

OnnxRuntimeException, provider: TVM, gpuid: 0. Microsoft.ML.OnnxRuntime.OnnxRuntimeException: [ErrorCode:RuntimeException] Exception during initialization: D:\codes\onnxruntime\new\onnxruntime\onnxruntime\core\providers\tvm\tvm_api.cc:50 onnxruntime::tvm::TVMCompile compile != nullptr was false. Unable to retrieve 'tvm_onnx_import_and_compile'.

  at Microsoft.ML.OnnxRuntime.NativeApiStatus.VerifySuccess (System.IntPtr nativeStatus) [0x0002c] in <56cc2af98561469babdd24bc23371de1>:0
  at Microsoft.ML.OnnxRuntime.InferenceSession.Init (System.String modelPath, Microsoft.ML.OnnxRuntime.SessionOptions options, Microsoft.ML.OnnxRuntime.PrePackedWeightsContainer prepackedWeightsContainer) [0x0002f] in <56cc2af98561469babdd24bc23371de1>:0
  at Microsoft.ML.OnnxRuntime.InferenceSession..ctor (System.String modelPath, Microsoft.ML.OnnxRuntime.SessionOptions options) [0x0002c] in <56cc2af98561469babdd24bc23371de1>:0

Problem with the build?

CUDA & CPU
Works without error.

I'll keep trying the other ways.

Any updates on this would be greatly appreciated. I'm still here in the background,

I'll try it again when the exam is over. Also I'm thinking about using the message queue communication with python using this, which would be much faster and robust than the currently implemented HTTP/Flask method (especially it's not bound to the Unity3D coroutine restriction).

I'll try it again when the exam is over. Also I'm thinking about using the message queue communication with python using this, which would be much faster and robust than the currently implemented HTTP/Flask method (especially it's not bound to the Unity3D coroutine restriction).

Thank you.

This is a little workaround using communication with Python, which is not as convenient as using on the Unity side but it is devoid of headaches caused by library linking. Instead of inferencing the model on the Unity/C# side it would ask the Python script using ZeroMQ, which I felt no overhead.
Unfortunately the PyTorch seems not to support non-CUDA GPU accelerators, so I added the OnnxRuntime version for the python script. I believe the DirectML version of OnnxRuntime supports the Intel GPUs well.
Also see here

Get the dependencies for the python scripts

pip install numpy opencv-python torch torchvision timm pyzmq
pip install onnxruntime-directml

Run the depthpy/depthmq.py. It's included in the build since v0.8.11-beta.1

python depthmq.py --ort --ort_ep dml

Open the main program, open the console (`), and enter

zmq 5555

It's not refined right now, any bug reports will be appreciated.

This is a little workaround using communication with Python, which is not as convenient as using on the Unity side but it is devoid of headaches caused by library linking. Instead of inferencing the model on the Unity/C# side it would ask the Python script using ZeroMQ, which I felt no overhead. Unfortunately the PyTorch seems not to support non-CUDA GPU accelerators, so I added the OnnxRuntime version for the python script. I believe the DirectML version of OnnxRuntime supports the Intel GPUs well.
Also see here

Get the dependencies for the python scripts

pip install numpy opencv-python torch torchvision timm pyzmq
pip install onnxruntime-directml

Run the depthpy/depthmq.py. It's included in the build since v0.8.11-beta.1

python depthmq.py --ort --ort_ep dml

Open the main program, open the console (`), and enter

zmq 5555

It's not refined right now, any bug reports will be appreciated.

https://imgur.com/a/FJ0Wk6c
It currently does not seem to give any proper depth output using DML on Intel Arc. No clue why.

I've noticed that dpt_beit_large_512 does not generate proper output with DML. Do the other models (say dpt_hybrid_384) work?

I tested dpt_hybrid_384 and that gives a garbled depth output.

I modified the entry in midas's model loader script to change openvino's loader from CPU to GPU and openvino_midas_v21_small_256 to a custom "openvino_dpt_beit_large_512" model I converted using the beit large onnx model and openvino's model convertor. That actually works and gives out a proper depth output.

Line 190:
model = ie.compile_model(uncompiled_model, "GPU")

Glad that it works. I don't understand why ORT + DML +dpt_hybrid_384 does not work in your environment though. I'll test the OpenVINO optimization myself.

Oh great, it works. I've updated the python scripts for loading v3/v3.1 OpenVINO formats (commit 4f67e1a). I don't know why dpt_hybrid_384 can't be converted though. (conversion script)


Recognition of the nothogenus ×Abacopterella (Thelypteridaceae) [PASSED]

Name of taxon
Recognition of the nothogenus ×Abacopterella (Thelypteridaceae)
Rank of taxon
Genus
Approximate number of species affected
1
Description of change
Recognition of the nothogenus  × Abacopterella T.E.Almeida & A.R.Field, a taxon of hybrid origin with parentage originating from species of Abacopteris Fée and Christella H.Lév.
Reason for change
Since nothogenera are to be recognized in PPG II, we propose the inclusion of the nothogenus × Abacopterella T.E.Almeida & A.R.Field, which includes the nothospecies × Abacopterella altifrons T.E.Almeida & A.R.Field (Abacopteris aspera (C.Presl) Ching × Christella queenslandica (Holttum) A.R.Field & Z.Bloesch).
Both nothotaxa were described based on robust phylogenomic evidence (Bloesch et al. 2022, Almeida et al. 2023), and both Abacopteris and Christella are recognized in the current Thelypteridaceae classification (Fawcett and Smith 2021, Fawcett et al. 2021).
Reference(s) for publication of the name
Almeida TE, Smith AR, Bostock PD, Bloesch Z, Field AR. 2023. × Abacopterella altifrons (Thelypteridaceae), a new intergeneric fern hybrid from Australia. Austrobaileya 13: 41–50.
Bloesch Z, Nauheimer L, Almeida TE, Crayn D, Field AR. 2022. HybPhaser identifies hybrid evolution in Australian thelypterid ferns. Molecular Phylogenetics and Evolution 173: 107526. DOI: 10.1016/j.ympev.2022.107526
Fawcett S, Smith AR, Sundue M, Burleigh JG, Sessa EB, Kuo L-Y, Chen C-W, Testo WL, Kessler M, GoFlag Consortium, Barrington DS. 2021. A global phylogenomic study of the Thelypteridaceae. Systematic Botany 46: 891–915. DOI: 10.1600/ 036364421X16370109698650
Fawcett S, Smith AR. 2021). A Generic Classification of the Thelypteridaceae. Sida, Botanical Miscellany 59. BRIT Press, Botanic Garden | Botanical Research Institute of Texas, U.S.A.: Fort Worth
List the numbers of any related issues
No response
Code of Conduct

[X] I agree to follow the PPG Code of Conduct

This proposal was voted on during PPG Ballot 2 (voting period August 2023). A total of 56 votes were cast. There were 51 'Yes' votes (91.1%) and 5 'No' votes (8.9%). The proposal passes.


cjxl incorrectly displays VarDCT as default for lossy (JPEG/GIF) input

Describe the bug
When using a GIF or Jpeg with transcoding disabled, the default behaviour of lossless encoding is shown as lossy instead.
To Reproduce
cjxl dancing-banana.gif dancing-banana.jxl
JPEG XL encoder v0.9.0 c51cffd [AVX2,SSE4,SSSE3,SSE2]
Encoding [VarDCT, d1.000, effort: 7]
Compressed to 6614 bytes (0.006 bpp/frame).
990 x 1050, 0.260 MP/s [0.26, 0.26], 1 reps, 16 threads.

cjxl dancing-banana.gif dancing-banana.jxl -d 1
JPEG XL encoder v0.9.0 c51cffd [AVX2,SSE4,SSSE3,SSE2]
Encoding [VarDCT, d1.000, effort: 7]
Compressed to 119.0 kB (0.114 bpp/frame).
990 x 1050, 0.097 MP/s [0.10, 0.10], 1 reps, 16 threads.

cjxl Test.jpg Test.jxl -j 0
JPEG XL encoder v0.9.0 c51cffd [AVX2,SSE4,SSSE3,SSE2]
Encoding [VarDCT, d1.000, effort: 7]
Compressed to 123.1 kB (2.347 bpp).
910 x 461, 0.796 MP/s [0.80, 0.80], 1 reps, 16 threads.

cjxl Test.jpg Test.jxl -j 0 -d 1
JPEG XL encoder v0.9.0 c51cffd [AVX2,SSE4,SSSE3,SSE2]
Encoding [VarDCT, d1.000, effort: 7]
Compressed to 28565 bytes (0.545 bpp).
910 x 461, 0.931 MP/s [0.93, 0.93], 1 reps, 16 threads.

Expected behavior
Default lossless encoding should display as Lossless Modular in the cjxl output.
The GIF used when I discovered the issue (Taken from Google's WebP example ironically).

Thanks for catching this. It seems that the bug was introduced by #2948 and fixed by #3013.
@mo271 Let’s merge #3013 in v0.9.1?

cherry picking the fix for this for v0.9.1 in #3114


⚠ Fortnite has degraded performance

In 206ca49, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1567 ms

Resolved: Fortnite performance has improved in e883b97.


Add ability to specify wait time to QueueInputStream

Revert the change that adds PollingQueueInputStream and TakingQueueInputStream
Add ability to specify wait time to QueueInputStream

I think this will keep the API simple yet offer the roughly the same (or even more) functionality the reverted change.
- PollingQueueInputStream is same as new QueueInputStream() which has timeout=0
- TakingQueueInputStream is same as new QueueInputStream(..., Duration.ofMillis(Long.MAX_VALUE))
and users can also specify arbitrary queue read timeout between 0 and LONG_MAX
see also https://github.com/apache/commons-io/pull/447

@maxxedev
TY for the PR.
I merged it and updated the code to use a builder instead of adding yet another constructor (see the rest of the code base).
What feels odd is that LinkedBlockingQueue polls using nanoseconds and we now use milliseconds as the internal timeout, so we cannot use the most precise polling. Any thoughts on changing milliseconds to nanoseconds?

Thanks for quick review and merge.
Good suggestion about nanos. I did not notice that LinkedBlockingQueue polls using nanoseconds. Here is the PR: https://github.com/apache/commons-io/pull/453

Is a changes.xml entry needed?


Add YARD doc template

Supports the new yard-gcloud template gem for building static HTML site with
the same structure as the gcloud-rdoc template for RDoc.
When the YARD conversion is complete the yard-gcloud template will be the default.
Older releases will have their documentation built using the existing gcloud-rdoc
template, but newer releases will use the yard-gcloud template.
[refs #466]

Awesome progress!


Add feedback tool

This PR adds a survey that collects user feedback and adds it to a Goggle Sheet.
It uses Google Scripts to manager to fetch the data and add it to the Google Sheet.
The survey itself is a React component. I used swizzle to edit the footer and make this component built in at the end of every doc's page.

It works like this:

Thumbs up -> Adds a plus one to the thumbs up count
Thumbs down -> A text feedback input opens up, the user can leave it empty or add some text -> Submit Feedback -> Adds plus one to the thumbs down count, and the feedback text, if added

Video showcasing how it works:
https://www.loom.com/share/32573a0c4a2543fea94928f5fc48c3ff

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

It's the same doc, it just adds a different URL to the doc.

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

It's the same doc, it just adds a different URL to the doc.

I see. Is that too much work to use different sheet on the same google sheet doc for different URL?

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

It's the same doc, it just adds a different URL to the doc.

I see. Is that too much work to use different sheet on the same google sheet doc for different URL?

I think it's possible, and have thought of that myself, but there are some issues with this approach. It will be harder to have an overall look, as each page will be on a different sheet. More prone to errors, as Google Scripts has to handle multiple sheets. I was thinking to reset this sheet monthly, and create a sheet where we store data for each month.

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

It's the same doc, it just adds a different URL to the doc.

I see. Is that too much work to use different sheet on the same google sheet doc for different URL?

I think it's possible, and have thought of that myself, but there are some issues with this approach. It will be harder to have an overall look, as each page will be on a different sheet. More prone to errors, as Google Scripts has to handle multiple sheets. I was thinking to reset this sheet monthly, and create a sheet where we store data for each month.

What I meant is that to organize Google sheet based on https://7ef747cc.avalanche-docs.pages.dev/, https://feedback.avalanche-docs.pages.dev/ or https://docs.avax.network/, not the each dev doc itself.

Is the feedback sent to the same doc or different doc from this branch build https://feedback.avalanche-docs.pages.dev/ vs https://docs.avax.network/ after deployment?

It's the same doc, it just adds a different URL to the doc.

I see. Is that too much work to use different sheet on the same google sheet doc for different URL?

I think it's possible, and have thought of that myself, but there are some issues with this approach. It will be harder to have an overall look, as each page will be on a different sheet. More prone to errors, as Google Scripts has to handle multiple sheets. I was thinking to reset this sheet monthly, and create a sheet where we store data for each month.

What I meant is that to organize Google sheet based on https://7ef747cc.avalanche-docs.pages.dev/, https://feedback.avalanche-docs.pages.dev/ or https://docs.avax.network/, not the each dev doc itself.

Oh, got it. Well, when we launch this live, I'll delete all those test links.


NameError: name 'DEBUG_APPS' is not defined

Hey Kevin, any idea what's causing this?
Including stack trace and my local_settings...
Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/ccf/tools/anaconda2/lib/python2.7/site-packages/django/core/management/__init__.py", line 338, in execute_from_command_line
    utility.execute()
  File "/home/ccf/tools/anaconda2/lib/python2.7/site-packages/django/core/management/__init__.py", line 303, in execute
    settings.INSTALLED_APPS
  File "/home/ccf/tools/anaconda2/lib/python2.7/site-packages/django/conf/__init__.py", line 48, in __getattr__
    self._setup(name)
  File "/home/ccf/tools/anaconda2/lib/python2.7/site-packages/django/conf/__init__.py", line 44, in _setup
    self._wrapped = Settings(settings_module)
  File "/home/ccf/tools/anaconda2/lib/python2.7/site-packages/django/conf/__init__.py", line 92, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/home/ccf/tools/anaconda2/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/ccf/projects/pytrader/pypolo/settings.py", line 124, in <module>
    INSTALLED_APPS += DEBUG_APPS
NameError: name 'DEBUG_APPS' is not defined

[ccf@li286-238 pytrader]$ cat pypolo/local_settings.py
import os

BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

MAKE_TRADES=False

API_KEY="foo"
API_SECRET="bar"

#sqllite

_DATABASES = {
	'default': {
		'ENGINE': 'django.db.backends.sqlite3',
		'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
	}
}

On this line there is an inclusion from the local_settings.py file for a setting called DEBUG_APPS. Presumably this would be for things like Django Debug Toolbar or other such Django 'apps' that are specifically for development purposes.
Simply put DEBUG_APPS = [] in your local_settings.py somewhere.

hey @ccf i've merged @richardpetithory 's fix into master.  pull & try now.

closing due to merged PR, feel free to re-open if you continue to have issues @ccf


Update incoming webhook for github apps

If GithubApp is installed on the cluster then no need to provide git_provider spec because for GithubApps we detect the secret and use it
Signed-off-by: Savita Ashture<EMAIL_ADDRESS>
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

/retest

/retes

/retest

/retest

some reviews, and we really need e2e test to cover this, a gitlab and a github app one

@chmouel we have e2e test for Gitlab here https://github.com/openshift-pipelines/pipelines-as-code/blob/main/test/gitlab_incoming_webhook_test.go
So added e2e test for GithubApp now for Incoming

Codecov Report

Merging #1090 (70db476) into main (1d39fbd) will decrease coverage by 0.09%.
The diff coverage is 57.74%.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   62.97%   62.88%   -0.10%
==========================================
  Files         106      106
  Lines        6358     6471     +113
==========================================
+ Hits         4004     4069      +65
- Misses       1970     2010      +40
- Partials      384      392       +8

Impacted Files
Coverage Δ

pkg/kubeinteraction/labels.go
65.62% <ø> (ø)

pkg/provider/bitbucketcloud/bitbucket.go
74.84% <0.00%> (-0.96%)
:arrow_down:

pkg/provider/bitbucketserver/bitbucketserver.go
81.33% <0.00%> (-1.10%)
:arrow_down:

pkg/provider/gitea/gitea.go
7.45% <0.00%> (-0.10%)
:arrow_down:

pkg/provider/github/github.go
68.32% <0.00%> (-3.58%)
:arrow_down:

pkg/provider/gitlab/gitlab.go
70.23% <0.00%> (-0.85%)
:arrow_down:

pkg/reconciler/reconciler.go
20.72% <12.50%> (+0.35%)
:arrow_up:

pkg/adapter/incoming.go
75.00% <63.82%> (-18.75%)
:arrow_down:

pkg/pipelineascode/secret.go
74.54% <100.00%> (ø)

pkg/provider/github/parse_payload.go
90.95% <100.00%> (+0.24%)
:arrow_up:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lmk when you finish added the e2e and i'll do a new review

lmk when you finish added the e2e and i'll do a new review

https://github.com/openshift-pipelines/pipelines-as-code/pull/1090#issuecomment-1377404192 I have added e2e already

The e2e test not failing locally :thinking:

/retest

/test

/retest

glad we have pac running :-p  unitlint is broken...

you are right @jkandasa about t.Setenv, i think we will then need a refactoring of all our test using gotest.tools env to move to t.Setenv

/retest


assign domain error in proteins tutorials

Thanks for providing such great tools! I was able to follow the "main_usage" tutorial without issue. However, I encountered an error when following the "proteins" tutorial.
Following the instructions, I was able to setup the model and trained it with 4 epochs using GPU.
model.fit(max_epochs=4, accelerator = "gpu",num_workers = 5)
This part ran smoothly without error and I can use it to do model.compute_representations() without problem.
However, it gave the following error when I did model.assign_domains(). How should I resolve this?
I did not find any cell with all zeros for all features in X.
>>> model.assign_domains()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\novae\model.py", line 468, in assign_domains
    adata.obs[key_added] = self.swav_head.map_leaves_domains(adata.obs[Keys.LEAVES], level)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\novae\module\swav.py", line 250, in map_leaves_domains
    return series.map(lambda x: f"D{self.clusters_levels[-level, int(x[1:])]}" if isinstance(x, str) else x)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\pandas\core\series.py", line 4700, in map
    new_values = self._map_values(arg, na_action=na_action)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\pandas\core\base.py", line 921, in _map_values
    return algorithms.map_array(arr, mapper, na_action=na_action, convert=convert)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\pandas\core\algorithms.py", line 1743, in map_array
    return lib.map_infer(values, mapper, convert=convert)
  File "lib.pyx", line 2972, in pandas._libs.lib.map_infer
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\novae\module\swav.py", line 250, in <lambda>
    return series.map(lambda x: f"D{self.clusters_levels[-level, int(x[1:])]}" if isinstance(x, str) else x)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\novae\module\swav.py", line 202, in clusters_levels
    self.hierarchical_clustering()
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\novae\module\swav.py", line 228, in hierarchical_clustering
    _clustering.fit(X)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\sklearn\base.py", line 1389, in wrapper
    return fit_method(estimator, *args, **kwargs)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\sklearn\cluster\_agglomerative.py", line 989, in fit
    return self._fit(X)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\sklearn\cluster\_agglomerative.py", line 1061, in _fit
    out = memory.cache(tree_builder)(
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\joblib\memory.py", line 312, in __call__
    return self.func(*args, **kwargs)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\sklearn\cluster\_agglomerative.py", line 714, in _average_linkage
    return linkage_tree(*args, **kwargs)
  File "C:\Users\project\venvDB\envNames\py310_novae\lib\site-packages\sklearn\cluster\_agglomerative.py", line 532, in linkage_tree
    raise ValueError("Cosine affinity cannot be used when X contains zero vectors")
ValueError: Cosine affinity cannot be used when X contains zero vectors

Hi @lidanwu, thanks for reporting!
Here, the issue happened when creating the hierarchies of prototypes. Can you look at the prototypes themselves, i.e. model.swav_head.prototypes.data, to see if there is any prototype with only zeroes?
I would be surprised if one prototype only has zeroes because we normalize them after each step, so it's an interesting issue.
Last question: did you use the public data from the tutorial or your own data?

NB: I'll answer in January

Hi @quentinblampey, thanks for the tips. You are right that all prototypes.data has zero values.
I managed to make the model training works after some diving into the code and data structure. Below is the details that may help to fix the code (or manual) for future usage.
I used the public data from the tutorial and noticed that it came with a counts layer which contains only nan value.
Running the normalization per instructions from tutorial (as shown below) did not change the values in counts layer (which makes sense since it overwrites the adata.X.
novae.settings.auto_preprocessing = False # prevent Novae from running normalize_total / log1p
novae.utils.quantile_scaling(adatas)

I checked the code used inside model.fit(). There is a step to standardize the adata list. And that function would use adata.layers['counts'] directly if auto_preprocessing is False. Since the tutorial said one should disable auto preprocessing, so the current code actually passes the nan value for training.
To fix this, I manually copied the adata.Xto adata.layers['counts'] after the quantile_scaling() step before the model declaration.

But the prototypes.data is still all zeros after training model.fit(max_epochs=4, accelerator = "gpu",num_workers = 5).

Further investigation reveals that the input adata.obsm['X_pca'] and adata.obsm['X_umap']  has all nan values too! The model initialization did trigger a message saying

[INFO] (novae.module.embed) Running PCA embedding initialization

The code seems to indicate that it's using adata.X directly instead of the saved pca embedding, so the nan issue with layers["counts"] and obsm["X_pca"] should NOT matter for model embedding initialization.
But I do see non-zero model embedding after the initialization in model.cell_embedder.embedding.weight AND finally non-zero value in model.swav_head.prototypes.data after training this time! The subsequent model.assign_domains() also works  now. So it seems the nan values in adata.obsm['X_pca'] affect the model training in ways independent of the embedding initialization.


Arma 3 - Small Bug Fix

Fixed RemoveDuplicates function adding an extra trailing semicolon if the input string is empty.
Added Aussie Server Hosts as a credited contributor for help and ideas on the project.

Tested on my personal prod server btw.

Damn, stand by... There may be an issue with Headless Clients causing an odd issue for clients loading into the server. Currently trying to isolate this issue to either the image or my personal server.

Nevermind, issue seems to be totally isolated to my personal server. Image should be fine as is.


Fix batch date edit timezone issues

The batch date editor has some timezone related issues.

Over to @Coenego for review.

Coverage remained the same at 100.0% when pulling 6b1c7d3abd1f4aa2f6898a1819c72c17fc0ae09d on bp323:issue-450 into 4a8451c46aebd1fdb1b22298b73dfe8d148bbf07 on CUL-DigitalServices:master.


Controlled Modal Opening/Closing

Description

Propose manual control for modal opening/closing in Credenza.
It would be good to have an isOpen or onClose function to play with the Drawer and Dialog

Benefits

Increased flexibility and control over the interface for users.
Improved accessibility for users with disabilities.

You can actually do that.
This component uses Radix UI under the hood so anything you can do in the Radix UI Dialog Primitive, you can do here as well. Check out the Dialog documentation here

So open={} onOpenChange={} are available in ? my bad didnt know that.
Ty so much!


Allow the configuration of failureThreshold and successThreshold on readiness and liveness probes

Description
Currently there isn't a way to configure the  failureThreshold and successThreshold on readiness and liveness probes using the spring-boot-health-check enricher
Info

f-m-p version : 3.5.41

Maven version (mvn -v) : Apache Maven 3.5.2

Kubernetes / OpenShift setup and version : K8s 1.10.x

If it's a feature request, what is your use case : a default failureThreshold of 3 is configured. I would like to increase that value.

I think this would be a valuable addition, not only for the spring boot healthcheck enricher, but for all enrichers. Shouldn't be that hard to implement.


Added grocery store search terms

@TheAdventurer64 Thanks, welcome to open source development!
One tip, you can run npm run build to check for errors and generate the derived data for your changes.

How exactly do you run commands?

How exactly do you run commands?

From a command line tool like Terminal on macOS or cmd.exe on Windows. If you haven't used one before, there are lots of tutorials. The command line is an important part of developing most software, including NodeJS apps like iD.


CRL shift of the center

Compound refractive lenses calculation present an image that is not centered at (0,0) as expected, but shifted vertically. This is more evident with a high number of lenses.

see https://github.com/srio/shadow3/issues/20


Update Pages “auction-management”

Automatically generated by Netlify CMS

👷 Deploy Preview for docbracing processing.

Name
Link

🔨 Latest commit
cc4cc2650451636a2bd005e4f73e8f63647b8ac2

🔍 Latest deploy log
https://app.netlify.com/sites/docbracing/deploys/6510d2e4038e1700089ad064


Add antlr error listener.

Add an antlr4 error listener. Display syntax error information in a client.
IoTDB> insert into root.ln.wf02.wt02(timestamp,status) value(1,true)
insert into root.ln.wf02.wt02(timestamp,status) value(1,true)
Msg: line 1:48 mismatched input 'value' expecting VALUES
It costs 0.445s

Hello, could you help me check whether the server can return the normal prompt when I type the abnormal character abc? @Genius-pig

Hello, could you help me check whether the server can return the normal prompt when I type the abnormal character abc? @Genius-pig

I can't understand. Can you give me an example?

Hello, could you help me check whether the server can return the normal prompt when I type the abnormal character abc? @Genius-pig

I can't understand. Can you give me an example?

IoTDB> abc
abc
Msg: Fail to execute abc after reconnecting. please check server status
It costs 3.271s

Hello, could you help me check whether the server can return the normal prompt when I type the abnormal character abc? @Genius-pig

I can't understand. Can you give me an example?

IoTDB> abc
abc
Msg: Fail to execute abc after reconnecting. please check server status
It costs 3.271s

IoTDB> abc
abc
Msg: line 1:0 mismatched input 'abc' expecting {CREATE, INSERT, UPDATE, DELETE, SELECT, SHOW, GRANT, SET, DESCRIBE, UNLINK, ADD, LINK, DROP, MERGE, LIST, ALTER, REVOKE, LOAD, UNSET, REMOVE, MOVE}
It costs 0.302s

@liutaohua
please be cautious, if you input two many wrong SQL, the parse speed will be slower.


Speed up CI

Takes forever, mostly the cross-plat docker build for ARM
Now we no longer need sqlite, we can cross-compile on the host and just copy the bin in to the container, which should be way faster. Or we could just consider if the arm build is even worth it in the first place.

I think I confused this with wwi lol


Update zkp.md

Preamble
For Pull Request initiator, please read the following steps carefully. 请合并请求的发起人仔细阅读下列步骤。

If you are creating a Pull Request about listed topic below, please go the the Preview tab and click the relative link:
如果您要创建一个有关下列内容的的合并请求，请切换到 Preview 面板并点击下方相关的链接:

Select Awesome-PETs for files under docs/awesome-pets

Select a proper Pull Request template can accelarate the review process, thanks for your cooperation.
选择一个正确的合并请求模版可以加速审查流程，谢谢您的配合
If your Pull Request topic is not amoung the list above, please just delete all prepopulated template content.
如果您的合并请求内容不在上述的列表里，请删除提前填入的模版内容。

Thanks for your contribution to SecretFlow project
感谢您对于 SecretFlow 项目的贡献

I have read the CLA Document and I hereby sign the CLA

Hello, please re-check your PR ,in which we could not easily find out where is the modifications. Thanks for making it more clear for which part is modified.

Sorry, I re-uploaded my edits in zkp.md

I added several papers in the Lattice-based ZKP category

@xwxlll hello, thanks for your modifications, but the PR still looks weird, see
We suggest you fork the most recent secretflow, and then modify the zkp.md file, and finally, use git to commit your changes.
==To avoid Markdown formatting issues, we suggest you just use Github's editor to edit the file.==
==Another tip, please add two more spaces at the end of each line(you added) for markdown's rendering(as a new line start).==
Besides, in this zkp.md file, we prefer to list the practical one. But now, we think lattice-based ZKP systems are far away from practical efficiency, so the lattice-based ZKP should not be a top classification. If you confirm any lattice-based system dose have excellent performance, we suggest you just add the papers under current classifications:

In the future, if lattice-based ZKP systems develop well enough, then we may consider listing them as a separate category.

@xwxlll Hi, cause long-time couldn't receive your reply, we would close this PR after 24 hours. If you have time for this PR, we welcome you to update it according to our request or create a new PR after. Thanks for your contribution effort!


Repository links are greyed out in Workbench after creation

RDF4J Workbench 2.0M1
Chrome 50
After I create the repository, I see the following screen:

Note grey links on the left. If I reload the page, now the links are active:

Note that if I just navigate to the "Repositories" and back without a full page refresh, the links still remain inactive.

Confirmed, I can reproduce this. It appears to be specific to Chrome. I tested Firefox (46.0.1) and Safari (9.1) and there the problem does not occur.

For what it's worth, I've seen this problem with new repositories as well.  I too use Chrome.  However, I find that eventually without any specific action on my part the links all become active and I can proceed as normal.  My work-around is to create repositories as the last thing in the work day and start using them the next day.  I'd be curious as to whether @berezovskyi sees this eventual active links behavior as well.  Just thought this might be a clue in helping to track down the bug...


Add training behaviors

Adds some packages used in training courses:

translate_pose_solution: Solution to the training exercise to create a Behavior to translate a pose given x,y,z. Not build by default (COLCON_IGNORE).
service_interface: A package with a .srv file defining a basic ROS 2 Service.
service_example: A package defining the actual ROS 2 Service, using service_interface. Python code.
call_my_service_solution: Solution to the training exercise to create a Behavior to call a ROS 2 Service. COLCON_IGNORE'd.

How do you feel about putting all of these in an "Example behaviors" folder? It seems a little out of place with the rest of the configs

How do you feel about putting all of these in an "Example behaviors" folder? It seems a little out of place with the rest of the configs

Makes sense. I did that and updated the package.xml files a bit too.
I also removed the COLCON_IGNORE files to make sure those Behaviors are built in CI and therefore kept up to date.

The CI failure should be fixed after https://github.com/PickNikRobotics/moveit_pro_ci/pull/5

All of the behaviors run as expected, I will add my registration behaviors along with some objectives that use these and some usage examples in a separate PR


[nrf5] Enable enhancement features of OpenThread

Enable jam detection
Enable child supervisoin

Codecov Report

Merging #481 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   54.04%   54.03%   -0.01%
==========================================
  Files         344      344
  Lines       59054    59054
==========================================
- Hits        31916    31912       -4
- Misses      27138    27142       +4

Impacted Files
Coverage Δ

src/lib/support/ASN1Writer.cpp
86.52% <0%> (-0.87%)
:arrow_down:

src/lib/profiles/security/WeaveToX509.cpp
87.91% <0%> (-0.26%)
:arrow_down:

src/lib/profiles/security/WeaveCASEEngine.cpp
93.09% <0%> (-0.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627fe1...bcd109d. Read the comment docs.

Why do we want these on for all projects that use OpenWeave?  Are these features necessary/appropriate for all use cases?  What if a project doesn't want these features enabled?

@jaylogue I think these features are appropriate for the lock and border router. Since the current makefile assumes an old OpenThread commit, it doesn’t support enable/disable all features in OpenThreadConfig.h. So it seems we have to enable it here for now before we move to new OpenThread.

@bukepo This makefile is potentially used by any product that uses OpenWeave on the nRF52840.  So the default OpenThread options we select should be the right ones for all such products, not just locks.
I'm fine with this change if we think it should apply universally.  However, if we don't, then I think individual products should enable them as needed in their product makefiles by overriding OPENTHREAD_CONFIGURE_OPTIONS.
For example, you can enable jam detection and child supervision in the openweave-nrf52840-lock-example by adding the following lines to the top-level Makefile:
OPENTHREAD_CONFIGURE_OPTIONS += \
    --enable-child-supervision \
    --enable-jam-detection

(Insert these lines after the include statements and before the call to GenerateBuildRules).
This would also be a quick way for our device partners to test this feature without waiting for an OpenWeave change.

Moved into lock example.


issue containerizing app with docker

I am trying to containerize this application using docker, but have been running into a few issues with the first step: running mvn clean install on the root to generate the dependancies.
I have been getting the issue
gpg: directory '/root/.gnupg' created gpg: keybox '/root/.gnupg/pubring.kbx' created gpg: no default secret key: No secret key gpg: signing failed: No secret key
so I am assuming it is missing a gpg key in the container, but I am not exactly sure what this is even needed for or how to generate one within the container. Any help would be appreciated here.
Thanks,
Michael

Shouldn't be getting that off the master branch - I put that into a profile as the gpg is only relevant for releasing the jar's to maven sonatype repo.

so you're suggesting I might be on the wrong branch? Not sure how that might have happened but I will try on master.


'gemini update' not working to update to v0.19.1

Hey guys,
I'm getting this error when running 'gemini update':
Collecting gemini==0.19.1 (from -r https://raw.github.com/arq5x/gemini/master/requirements.txt (line 24))
Could not find a version that satisfies the requirement gemini==0.19.1 (from -r https://raw.github.com/arq5x/gemini/master/requirements.txt (line 24)) (from versions: 0.6.2, <IP_ADDRESS>, <IP_ADDRESS>, 0.6.3, <IP_ADDRESS>, <IP_ADDRESS>, 0.6.4, 0.6.5, 0.7.0, 0.7.1, 0.8.0, 0.9.0, 0.9.1, 0.10.0, 0.10.1, 0.11.0, 0.12.1, 0.12.2, 0.13.0, 0.13.1, 0.14.0, 0.15.0, 0.15.1, 0.16.0, 0.16.1, 0.16.2, 0.16.3, 0.17.0, 0.17.1, 0.17.2, 0.18.0, 0.18.1, 0.18.2, 0.18.3)
No matching distribution found for gemini==0.19.1 (from -r https://raw.github.com/arq5x/gemini/master/requirements.txt (line 24))
Traceback (most recent call last):
File "/usr/local/bin/gemini", line 6, in
gemini.gemini_main.main()
File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_main.py", line 1117, in main
args.func(parser, args)
File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_main.py", line 992, in update_fn
gemini_update.release(parser, args)
File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_update.py", line 54, in release
subprocess.check_call([pip_bin, "install"] + pip_compat + ["-r", url])
File "/usr/local/share/gemini/anaconda/lib/python2.7/subprocess.py", line 541, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/local/share/gemini/anaconda/bin/pip', 'install', '--allow-external', 'python-graph-core', '--allow-unverified', 'python-graph-core', '--allow-external', 'python-graph-dot', '--allow-unverified', 'python-graph-dot', '-r', 'https://raw.github.com/arq5x/gemini/master/requirements.txt']' returned non-zero exit status 1
Looks like v0.19.1 isn't listed as an official release that's available for updating?
Cheers,
Vel

Vel;
Sorry about the issues. What version of gemini are you upgrading from? We substantially improved the install process as of 0.18 but this requires an initial step to fix the install to be compatible with the new versions:
http://gemini.readthedocs.io/en/latest/#new-installation
Hope this helps get GEMINI updated for you.

Hey @chapmanb, thanks for that. I was updating from 0.15 and installing fresh using the script fixed the problem.


Acronyms overused thought documentation

When writing technical documentation it is considered a best practice to avoid acronyms.  The Open Artificial Pancreas System (OpenAPS) documentation is littered with acronyms making it hard to understand especially for people who are just getting started who conversely are the ones who need the documentation the most.  Ideally all acronyms should be expanded.  At a minimum any term used on a page should be fully defined the first time it is used (like I did for OpenAPS above)
Note: I would happy to help with this but honestly I am not always sure I know what they all mean.
Recommended first step: Define a glossary

Thanks, @joeyede - would you take a look at the existing glossary, and maybe make a PR with some recommendations where to link to the glossary? https://openaps.readthedocs.io/en/latest/docs/Resources/glossary.html
Or, if you can identify the acronyms that are not defined where you saw them, we can define & add them.

Happy to do both once we get back from our first vacation while looping.
The existing glossary is good but I guess not discoverable enough given I
looked and missed it...
On Thu, 20 Dec 2018, 3:17 pm Dana Lewis<EMAIL_ADDRESS>wrote:

Thanks, @joeyede https://github.com/joeyede - would you take a look at
the existing glossary, and maybe make a PR with some recommendations where
to link to the glossary?
https://openaps.readthedocs.io/en/latest/docs/Resources/glossary.html
Or, if you can identify the acronyms that are not defined where you saw
them, we can define & add them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openaps/oref0/issues/1173#issuecomment-449032015, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdgZMXCnhcUygLCZOsJQkPXdGXpfTWIks5u66nvgaJpZM4ZcYAv
.

Lots of acronyms removed and addressed after this posting, and subsequently since then. Closing, but please do open PRs to the documentation directly with any edits and suggestions and acronym clarification if needed!


:boom: refactor(note): rewrite semitones starting from 0 instead of 1

Partially fixes #111

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
811

Relevant Lines:
811

💛  - Coveralls


improve allocation on some tests

Reduces the allocation of some tests, so it's easier to spot where the remaining allocations are.
No functional changes
Changes:

use ValueTuple instead of Tuple
Reuse Lists
Set Capacity on some large proto model

much appreciated.
Thanks


Restore pre-1.7.0 escaping behavior for fenced code blocks

In a project I have created a custom extension of the Parsedown class that overrides the Parsedown::blockFencedCodeComplete() method to add "compile time" syntax highlighting to fenced code blocks. This worked pretty well in 1.6.4 and earlier releases.
Since the element text that is created contains HTML (to apply the classes for the syntax highlighting), I intentionally left out the call to htmlspecialchars() in my overridden method. This is the resulting markup for an example fenced code block:

// baz.php

<?php

$foo = "bar";

With the 1.7.0 release though this broke because now the call to htmlspecialchars() doesn't seem to happen in the single element methods but rather in Parsedown::element() where every element is passed through. This is the markup I get now:

<span class="hljs-comment">// baz.php</span>

<span class="hljs-meta">&lt;?php</span>

$foo = <span class="hljs-string">"bar"</span>;

My question is: with the latest changes, is there a way to restore the previous behavior? Don't get me wrong, I know sanitation is a serious topic and I think the changes are the right way to go. I just want to disable them for fenced code block in a project where I have complete control over the markdown passed through Parsedown.

You should be able to create HTML using the same method that Parsedown does, i.e. by modifying $Block that your function receives as an argument.
The escaping changes only ensure that the intended HTML structure is preserved when outputting (i.e. context borders aren't crossed). For example, if your write something into an attribute, it shouldn't leak out into the DOM because it contains quotes.
This shouldn't prevent you doing anything however, if you want a different HTML structure then simply write a different one to $Block and return it :) the changes only ensure that you represent your HTML as an array, rather than directly outputting it into a string.

There would have been one restriction with using the array structure compared to HTML-as-a-string representation, in that in the current release elements would not be permitted to lie adjacent to text (it looks like you would want to use this based on your example).
I've just merged #511 which removes this restriction :)

My current code looks like this (simplified, there's additional checks and error handling in place):
protected function blockFencedCodeComplete($block)
{
    $language = array_get($block, 'element.text.attributes.class', '');
    $code = array_get($block, 'element.text.text', '');

    $code = $this->highlighter->highlight($language, $code)->value;

    array_set($block, 'element.text.text', $code);
}

Where $this->highlighter->highlight($language, $code)->value takes the code blocks content as a string and returns the finished markup as a string.
Now, instead of just setting block.element.text.text I would need to inject the finished markup in the same array structure that Parsedoen uses?

Does your highlighter give you any representation of the highlighted text other than as a string value?

The highlighter is highlight.php a port of highlight.js.
Unfortunately, it just returns the result as a single string value.

@aidantwoods: I don't think that it would be desirable to create a Parsedown AST representation of the highlighter's result. I guess the only solution here is to introduce a separate trustedText key that isn't escaped, and putting the extension's developer in charge to make the contents safe.

Yeah, I was thinking the same thing too – I hadn't previously considered that extensions might use external parsers (and thus not really have a good way of knowing the structure of what was produced). I'll put together a PR, brb :)

Check out #569 for the changes.
As kind of intended for this sort of thing – if a user of your extension enables safe mode then the unsafe behaviour goes away (which kind of acts to enforce that the user of the extension and the author agree on the trustworthiness of input).

@JonasDoebertin you can take a look at https://github.com/erusev/parsedown/pull/569/files#diff-02ec1fcc68993c0203f25e1b4ae8af44 for the test examples. Essentially what you want to do is:

copy the value of and unset the 'text' key from the element
put the output of your highlighter into a new key 'rawHtml' instead.
if you're confident that the highlighter you're using is capable of handling user input safely, then additionally set the  'allowRawHtmlInSafeMode' key to true. Though if you're not going to be using safe mode then leaving it as is would also work (if safe mode is ever enabled the rawHtml will be escaped unless it's explicitly marked as safe via setting that key).

Thanks for your quick solution!
Do you know when you'll tag a release with this changes?

Planning to release this as part of 1.8, in-which I'd like to include the handler changes from #576. So once that's done I'll tag a new feature release with this as part of it :)


Kucoin streaming exchange implementation

Implemented streaming market data and trading services

@eschava are you changing or adding to the code? If not, @earce could you merge the PR? Thanks

@timmolter could you please review this PR?


Error building with cblox

catkin build panoptic_mapping_ros

tarting  >>> voxblox
Finished  <<< voxblox                              [ 13.6 seconds ]
Starting  >>> cblox
Starting  >>> voxblox_rviz_plugin
Finished  <<< cblox                                [ 6.9 seconds ]
Starting  >>> panoptic_mapping
_______________________________________________________________________________________________________________________________________
Errors     << panoptic_mapping:make /opt/data/catkin_ws2/logs/panoptic_mapping/build.make.000.log
cblox/QuatTransformation.proto: File not found.
panoptic_mapping/Submap.proto: Import "cblox/QuatTransformation.proto" was not found or had errors.
panoptic_mapping/Submap.proto:26:12: "cblox.QuatTransformationProto" is not defined.
make[2]: *** [compiled_proto/panoptic_mapping/Submap.pb.cc] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/panoptic_mapping_proto.dir/all] Error 2
make: *** [all] Error 2
cd /opt/data/catkin_ws2/build/panoptic_mapping; catkin build --get-env panoptic_mapping | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
.......................................................................................................................................
Failed     << panoptic_mapping:make                [ Exited with code 2 ]
Failed    <<< panoptic_mapping                     [ 1.9 seconds ]
Abandoned <<< voxblox_ros                          [ Unrelated job failed ]
Abandoned <<< panoptic_mapping_ros                 [ Unrelated job failed ]
Finished  <<< voxblox_rviz_plugin                  [ 12.0 seconds ]
[build] Summary: 15 of 18 packages succeeded.
[build]   Ignored:   7 packages were skipped or are blacklisted.
[build]   Warnings:  4 packages succeeded with warnings.
[build]   Abandoned: 2 packages were abandoned.
[build]   Failed:    1 packages failed.
[build] Runtime: 3 minutes and 38.9 seconds total.
[build] Note: Workspace packages have changed, please re-source setup files to use them.
root@995b491f20de:/opt/data/catkin_ws2# catkin build panoptic_mapping_ros

Hi,
thanks for the interest in the project. Without additional information it is hard to help.
I would suggest the following steps:

Check the installation instructions in the original repo and follow them. Maybe it would make sense to clean your catkin workspace first
Check this issue which looks very similar to yours
If you still have problems, please report here all the commands you have run before encountering in the issue (e.g. catkin config, build commands, ...)

I hope this helps.


refactor: display-single-post

I hope I'm not stepping on any toes by opening this but I've been looking into this for a little while and wanted to see if my changes would be worth PRing or if I should just fork.

Merged, thank you. I will probably make some further edits (using master). I guess we need a dev branch.

@ferg1e if you want to setup a dev branch I'd be happy to open more PRs.

Okay, I will make another branch soon. @OmgImAlexis


Skip calling Compute in RemoveSafeDeltaCounterCell if value exists

This is a minor optimization for incrementing the new PerWorkerCounters.
The benefits of this PR are detailed below:

Some quick load tests show that this makes incrementing counter metrics 25% faster.

Compute blocks a portion of the ConcurrentHashMap while executing src.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Run Java PreCommit

R: @m-trieu

R: @m-trieu


android:allowBackup should not be used in library

Error:Execution failed for task ':app:processInternalConfigDebugManifest'.

Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:36:9-36
is also present at [io.paperdb:paperdb:1.1] AndroidManifest.xml:11:18-44 value=(true).
Suggestion: add 'tools:replace="android:allowBackup"' to  element at AndroidManifest.xml:34:5-101:19 to override.

even lint suggestion will not help.

+1

+1


Disabling Comments in the CSS File

I can not for the life of me figure out how to disable the comments. I don't want:
/* line 14, C:/Users/r/Desktop/Brackets SASS/scss/style.scss */
in my css file for every single line. There has to be a way to disable this I hope??
"sourceComments": "false", seems to do nothing. It really seems that none of the settings I put in this file really change or do anything. However I know its reading it. If I remove my theme from the top and save it, my theme changes immediately. Here is my full file.
{
"themes.theme": "dark-theme",
"path": {
"scss/style.scss": {
"sass.enabled": true,
"sass.options": {
"outputDir": "../css/",
"imagePath": null,
"sourceComments": "true",
"outputStyle": "compressed"
},
"linting.collapsed": false
}
},
"linting.collapsed": false,
"fonts.fontSize": "13px"
}
Even when outputStyle is compressed it still created nested in the .css file. Maybe I am just missing something? But I can live with nested but I can't live with those comments all over my css file. Can you please help me figure out how to disable those?

I can not for the life of me figure out how to disable the comments. I don't want:
/* line 14, C:/Users/r/Desktop/Brackets SASS/scss/style.scss */

in my css file for every single line. There has to be a way to disable this I hope??
"sourceComments": "false", seems to do nothing.

false must be written without quotes: "sourceComments": false

Does the outputDir option work? Maybe brackets-sass doesn't read correctly sass.options.

I also face this problem and can not solve it..

I had the same problem and finally it's solve. The missing string was "includePaths": []"
Now my .brackets.json looks like:
{
"path": {
"scss/*.scss": {
"sass.enabled": true ,
"sass.options": {
"outputDir": "../css",
"includePaths": [],
"sourceComments": false,
"outputStyle": "compressed"
}
}
}
}

Place the .brackets.json to the project directory and correct paths at file content ("outputDir").
{
    "path": {
        "*.scss": {
            "sass.enabled": true,
            "sass.options": {
                "outputDir": "../css",
                "includePaths": [],
                "sourceComments": false,
                "outputStyle": "compressed"
            }
        }
    }
}


Upgrade to ton v13 and sandbox

Looks good, but I think we're missing deploy scripts for blueprint (example)

@hrmon CI fails - can you make sure that npm run build triggers npx blueprint build for all contracts


Missing repo

github.com: https://github.com/eu-digital-identity-wallet/eudi-lib-ios-openid4vci-swift.git: The remote repository could not be accessed. Make sure a valid repository exists at the specified location and that the correct credentials have been supplied.

Repos are verified to be public. The issue existed during the process of publication.


feat(local-nav)!: local nav redesign

Summary
Redesign/rework of the local nav component.
Figma Link
https://www.figma.com/design/AIX4LLzoDHnFCXzQCiPHJk/Vienna?node-id=4018-504&node-type=canvas&m=dev
ADO Story Link
https://dev.azure.com/Kyndryl/Shidoka - Bridge Design System/_workitems/edit/1935789
Notes

[x] Flyouts changed to expand/collapse
[x] Support for 4 levels instead of 3
[x] Add a Divider sub-component with an optional prop for heading/category.
[x] Add a slot for search

Search functionality must be provided at the application level

[x] Add a helper function for filtering a nested array of links if possible.

[x] Create a Story showing a functional search filter

lgtm

Hi Brian,

I see that the alignment is missing when the options are without and with next level
The Figma shows solid O icon for the one in expanded state and collapsed one as O, is this expected?
In Figma, there are other icons included but storybook shows only O. Do we have any code level option to modify these as per business requirement?
Is there an option to change the Divider with heading in the code level? Since I do not see any attribute in Controls.

Hi Brian,
1. I see that the alignment is missing when the options are without and with next level
2. The Figma shows solid O icon for the one in expanded state and collapsed one as O, is this expected?
3. In Figma, there are other icons included but storybook shows only O. Do we have any code level option to modify these as per business requirement?
4. Is there an option to change the Divider with heading in the code level? Since I do not see any attribute in Controls.

I believe this is the correct alignment, +/- aligns with icon if no sub-menu items are present.
The circle icon is just a placeholder. Icons are only required for top level menu items.
Same answer as 2.
Since the Divider is a sub-component, I did not set up Controls for it, and just added one hard-coded example Story.

:tada: This PR is included in version 2.0.0-next.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Memory leak

Hello, I have a suspicion of a memory leak.
I am working on a real estate service, and for the maps, I use MapTiler SDK JS along with custom markers to denote property locations.
While navigating to the offer page and then returning to the map, I've noticed that the memory is not being released. The more I navigate this way, memory usage grows exponentially by about 10 - 15mb for each return to the map, reaching over 300mb after just a few minutes of using the map.
For the purpose of testing and possibly identifying where the issue lies, I replaced MapTiler SDK JS with MapLibre GL JS. To my surprise, by conducting the same scenario as above, the memory leak issue does not occur - it is released almost back to the initial values, in my case to about 70mb, which is a substantial difference.
For the test, the map style has been disabled.
Unfortunately, I cannot change the mapping tool because I need the custom map coloring provided by MapTiler.
I am attaching screenshots.

MapTiler SDK JS - 2.0.0
MapLibre GL JS - 4.1.2

Test environment

MacBook Air M2 / 16GB

MacOS: 14.3.1 (23D60)

Chrome: 123.0.6312.59

Lib
Version

@maptiler/sdk
2.0.0

maplibre-gl
4.1.2

I have also conducted tests on other devices and browsers, and the results were the same. Mobile devices fared the worst in this case, where after some time it was noticeable that the browser was struggling with such high memory

Hello @zarskilukasz , thanks for raising this issue, i will looking it!
Are you adding anything else specific than the markers?

Hi @jonathanlurie, thank you for the quick response. I add only the markers (built with HTML using JS), which open a Popup when clicked. I don't know if this will help... but I also conducted a different test where, instead of generating a Marker, I added a Source and Layer (based on the example from https://docs.maptiler.com/sdk-js/examples/popup-on-click/), and here as well the outcome was.

Thanks for the details @zarskilukasz , this should help narrow down the issue.

Hello @zarskilukasz , apologies for the very long delays but I could finally take some time to perform some benchmarking. Here is how I went:
To test this issue, I have created a 3-page website:

one Home page without map, just links to navigate to the two others
a map page with 1000 markers, powered by MapTiler SDK v2.0.3, with a link to Home page
a map page with 1000 markers, powered by MapLibre GL JS v4.3.2 with a link to Home page

Scenario 1: with MapTiler SDK v2.0.3
On Chrome Version 124.0.6367.203 (Official Build) (arm64) - Macbook Air M2 (16GB RAM)

In a fresh tab, go to with-none.html --> RAM: ~30MB
then click the link to go to with-sdk.html --> RAM: ~550MB
then click link to go back to with-none.html --> RAM: ~450MB, and after 15sec drops to ~140MB and stays stable
then click the link to go to with-sdk.html again --> RAM: ~550MB then drops to 380MB and stays stable
then click link to go back to with-none.html --> RAM: ~320MB, and after 15sec drops to ~115MB and stays stable

Scenario 2: with MapLibre GL JS v4.3.2
On Chrome Version 124.0.6367.203 (Official Build) (arm64) - Macbook Air M2 (16GB RAM)

In a fresh tab, go to with-none.html --> RAM: ~30MB
then click the link to go to with-ml.html --> RAM: ~485MB
then click link to go back to with-none.html --> RAM: ~370MB, and after 15sec drops to ~100MB and stays stable
then click the link to go to with-ml.html again --> RAM: ~730MB then drops to 385MB and stays stable
then click link to go back to with-none.html --> RAM: ~310MB, and after 15sec drops to ~125MB and stays stable

Conclusion
No significant difference in memory management between MapLibre GL JS and MapTiler SDK. Feel free to let me know if my testing scenario is missing a relevant bit, making it too different from your real-world case.
Here are the sources of the three pages:
with-none.html:
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>>>>>>>>> Memory Leak SDK vs ML</title>

Go to SDK page

Go to ML page

with-ml.html:
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>>>>>>>>> Memory Leak ML</title>

with-sdk.html:
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>>>>>>>>> Memory Leak SDK</title>

<link href="https://cdn.maptiler.com/maptiler-sdk-js/v2.0.3/maptiler-sdk.css" rel="stylesheet" />

Go to ML page

Go to Home


Add no prompt version of install

This is a suggestion on how we can implement a no prompt version of install_server without breaking the interface to solve #83. I am not a Lua novice, so help to test it would be appreciated.

https://github.com/kabouzeid/nvim-lspinstall/commit/05ee7ca615887adabd0283e6ea6fb693240c99b3


Mistake in alphabetical order of the list

Just so you know, and following the alphabetical order of the list, DongDong Chen is way down.
Thanks for taking the time to make this list

Thanks for reporting!


feat: implement from for priority queue

This change is

Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 38.98%. Comparing base (54f8f91) to head (f818dbc).

Files
Patch %
Lines

crates/mempool/src/priority_queue.rs
0.00%
7 Missing :warning:

Additional details and impacted files
@@                             Coverage Diff                             @@
##           ayelet/mempool/implement-mempool-struct      #57      +/-   ##
===========================================================================
- Coverage                                    40.70%   38.98%   -1.73%
===========================================================================
  Files                                            7        7
  Lines                                          113      118       +5
  Branches                                       113      118       +5
===========================================================================
  Hits                                            46       46
- Misses                                          66       71       +5
  Partials                                         1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Question: Setting Objects?

The examples show setting objects. What are all the kinds of values that this projects supports?

Any serializable value. I guess I can make that more explicit.

Thanks!


List on json-schema.org

Hello! My name is Benjamin from the JSON Schema Community. I came across this cool JSON Schema implementation, and I wanted to congratulate you for the great work! KUDOS!
I noticed that it's not listed on our tooling page, but we'd love it to be.
If you'd like to add this implementation to that page, please feel free to open an issue to get it added using this link.
I'd like to use this opportunity to invite you to join the JSON Schema Community in Slack, where we have some interesting channels like #implementers where you could connect with other relevant maintainers in the ecosystem.
Thanks for enhancing the JSON Schema ecosystem!

I've also listed the Slack community link in our wiki.
Closing this issue for now. Thanks again, for reaching out @benjagm


Prevent two tabs from opening when engagement tile is clicked

-Prevent event bubbling in engagement tile
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1951 (e6b7f63) into main (bb6990d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1951   +/-   ##
=======================================
  Coverage   69.75%   69.75%
=======================================
  Files         440      440
  Lines       13362    13362
  Branches      989      989
=======================================
  Hits         9320     9320
  Misses       3864     3864
  Partials      178      178

Flag
Coverage Δ

metweb
62.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Variable does not exist: TDF_Utility

TDF_Utility is not included in the classes. When trying to compile TDF.cls, an error is encountered:
[OPERATION FAILED]: classes/TDF.cls: Variable does not exist: TDF_Utility (Line: 228, Column: 31)
classes/TDF.cls: Variable does not exist: TDF_Utility (Line: 231, Column: 36)
classes/TDF.cls: Variable does not exist: TDF_Utility (Line: 231, Column: 103)
classes/TDF.cls: Variable does not exist: TDF_Utility (Line: 233, Column: 49)
classes/TDF.cls: Variable does not exist: TDF_Utility (Line: 240, Column: 108).....

Hi @antnoley  thanks for logging the issue
I updated the TDF class it should compile now...

It compiles now. Thanks benahm.


Menu is not closing for one-page site

What happened?
Hello,
my website www.datanalyze.be is a one-page site in the sense that links in the menu redirects to a section of the home page.
I noticed that when I click on a link in the menu, it correctly redirects to the section but the menu stays open (and we have to click on the cross to close it).
See in practice:
https://user-images.githubusercontent.com/17910063/215342929-5b8ce2e9-cbf0-4525-88e5-160316f08399.MOV
Would it be possible to implement the fact that the menu closes automatically after clicking on a link?
In case it helps, the repo is available at:
https://github.com/AntoineSoetewey/datanalyze
Thanks in advance!
Theme version
v2.5.2
Hugo version
v0.101.0
What browsers are you seeing the problem on?
Chrome, Safari
Relevant Hugo log output
No response

Thanks for raising this issue. I suppose this is an unusual one as this is kind of an edge case in the way the menu would normally be used. I agree that the UX for the way this works now is really not great, but I'm also not sure how best to address it.
If I were to make the menu close whenever a link is clicked, it will lead to the behaviour where the user will always see the menu dismiss even when navigating to another page and there'll be this delay where you see the original page content flash up before the browser navigates to the new link. And that seems like a worse outcome given that's how the majority of menu links would be used.
I have to do some thinking on how best to address this without adding a bunch of extra JavaScript that makes the site less performant.


Add docs for a part of the project

Add docs for several parts of the compiler plugin:

common utils
scripting
entry points of the plugin

Make small code refactoring

Thank you! I can fix it a little bit later


update swanctl params "start_action"

According to https://docs.strongswan.org/docs/latest/swanctl/swanctlConf.html#_connections_conn_children, the param start_action can use start|trap since strongswan 5.9.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The commit message should be nixos/strongswan: update start_action option, otherwise LGTM.

Commit message updated.


Add stubs for requested common methods

PFNs
spin testing
Haufe transforms
opNMF
NeuroMaps
PLS
Ridge Regression

@joellebagautdinova I don't want to introduce conflicts with what you're working on. Have you created pages for any of these methods?


Update comment for testing purposes

Codecov Report

Merging #147 (84c9085) into master (2074697) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   86.33%   86.33%
=======================================
  Files          42       42
  Lines        1822     1822
=======================================
  Hits         1573     1573
  Misses        174      174
  Partials       75       75

Impacted Files
Coverage Δ

alerting/provider/custom/custom.go
67.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2074697...84c9085. Read the comment docs.


1 21 2 update

small update for beet datapacking

I've updated the pack formats to match 1.21.4 in #449, so this PR can probably be closed


Innersource project description is not pulled from GitHub

In https://landscape.finos.org/?selected=inner-source-special-interest-group the description is not taken from the About section on https://github.com/finos/InnerSource (as expected).
We already deployed 2 changes, but the description is not pulled; is there any way to force loading project descriptions?
/CC @jordinl83 @mcleo-d

@maoo I think it shows the right description now. Could you check?

@maoo I think it shows the right description now. Could you check?

Yes, thank you @jordinl83  ! Out of curiosity, how often are descriptions pulled?

@maoo Repo and crunchbase data are pulled the first time an item is added to the landscape. After that the data is refreshed daily. I think you might have updated the repo description but the daily job hadn't run yet.

@maoo Repo and crunchbase data are pulled the first time an item is added to the landscape. After that the data is refreshed daily. I think you might have updated the repo description but the daily job hadn't run yet.

Gotcha... and I think that only applies to master content, which is what I think I didn't consider. TY!


Handle icons and background images for 7xx weather codes

We don't handle 7xx category weather codes at the moment.
We need to show relevant icons and backgrounds to handle all 7xx cases.
Grouping:
Mist, Fog, Haze, Smoke
Sand, Dust
Volcanic Ash,
Squall,
Tornado

@iamplugged can this be closed out?

Yes this has been taken care of.
On Tue, 13 Sep 2022 at 11:56 PM, Viktor Petersson @.***>
wrote:

@iamplugged https://github.com/iamplugged can this be closed out?
—
Reply to this email directly, view it on GitHub
https://github.com/Screenly/weather-app/issues/13#issuecomment-1245798541,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVDE5OCRWCIDSOIJNVUXU3V6DBN3ANCNFSM6AAAAAAQITDTDQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Bug]: M365 copilot plugin is not reading adaptive card as a response from message extension

Sample
msgext-multiparam-ts
Description
We've all the pre-requisites to do the copilot plugin development.

Earlier we got started with sample solutions placed here which were working fine when tried as vanilla and as is.
The same solution for plugin is now not working and though the valid adaptive card JSON is passed from code( which we could see from console log) from vs-code while the same works as message extension when tried separately outside the m365 copilot app.
Besides, we've searched ppl are facing similar kinda issue which are raised in diff. forums as ex ref below
https://techcommunity.microsoft.com/t5/copilot-for-microsoft-365/copilot-m365-not-showing-results-from-message-extension-plugin/m-p/4120042?lightbox-message-images-4133309=578372i01B70989D420AE33
4.I also have a doubt in the function execution details of co-pilot plugin - Why 2 calls are being made to my plugin as 1 gets fails and second gets success. Also, from message extension this is not happening.

Steps to reproduce

Run the same sample as selected above.

Expected results
M365 co-pilot should respond as expected from the plugin which is enabled by the user when proper prompt is triggered and respond as adaptive card for the stock price asked.

Actual results
Observations

After enabling developer mode on
Copilot invokes  plugin multiple time even on a single request

Additional Info
Wanted  why two attempts are being made as attached in screenshot

first being unsuccessful and second being a successful one ( even though co-pilot is not evaluating the response). ref. screenshot below.

When default sample plugin which was working 5/6

and same plugin is not working from next day 5/7.

Hey @ShujaathKhan 👋
Response status 0 generally means that your plugin did not respond within the timeout window which is 10 seconds. See https://learn.microsoft.com/microsoft-365-copilot/extensibility/debugging-copilot-plugin for more information.
If the plugin response is returned within 10 seconds, then I would suggest raising a support ticket via the Microsoft 365 admin portal (if you have a support arrangement) or raising a new question of Microsoft Q&A to get further support. See https://learn.microsoft.com/microsoft-365-copilot/extensibility/feedback for more information.

Hey @ShujaathKhan ,
I faced this issue and was able to resolve it, though I am still investigating the root cause. It appears to be related to the adaptive card and its creation in the backend.
To resolve it, you can generate a sample message extension bot project using the Teams Toolkit. Then, copy the adaptive card TypeScript(or JavaScript, if your project is in JavaScript ) code from the sample project and paste it into your solution. Keep the outer adaptive card code the same, and make the necessary changes. This approach should work, as the sample project code will always work.


Level 20 bug

On level 20, the third coin keeps passing right through all the chips. While I realize ACC and MEM chips have no effect on them (only mentioned on the next level), I also had 1-2 each SHR and SUB chips placed that it passed through. It would rotate as it passed through them but not be destroyed/collected, allowing it to reach the core, causing damage and failure to collect the coin.
Happened on level 23 also, especially frustrating given how many tries this level took. Also levels 24, 26, and 27.

If it rotates, then it has been affected. Probably not sufficiently to be removed (coins have up to 50%  higher value than normal attackers). Just throw in one or two more levels of SHR next time.


Add GitHub API requests logging

This information is very useful on GitHub API rate limit exhaustion investigation.

@bozaro
This is looks reasonable.  Need some tests for it.  Maybe you can try out the mocking framework, I've added and create some tests the verify the logging output?