Reverb not connectable locally via WebSocket (404)

Reverb Version
v1.0.0-beta10
Laravel Version
11.7.0
PHP Version
8.3.7
Description
I tried creating a fresh laravel project to reproduce and upon starting reverb with the defaults (<IP_ADDRESS>:8080) it gives a 404 GET on Chrome/Firefox even overriding the host with <IP_ADDRESS> or such. Alternatively tried node with ipv4/ipv6 and those both reliably work and return a 101.
Even with the --debug flag to start reverb there's nothing in laravel logs. Artisan successfully starts and I can see the "Welcome" page on port 8000 (web port) so Laravel seems to work at a base level, just not reverb.
When reverb is not running, I get NS_ERROR_CONNECTION_REFUSED. With a bogus host, I get NS_ERROR_UNKNOWN_HOST
When reverb is running I get a 404, so it means it's still hitting Laravel.

Just to sanity check, .env has these values by default (cleared out app id, app key, app secret):
BROADCAST_CONNECTION=reverb
REVERB_APP_ID=
REVERB_APP_KEY=
REVERB_APP_SECRET=
REVERB_HOST="localhost"
REVERB_PORT=8080
REVERB_SCHEME=http

broadcasting.php:
<?php

return [

    /*
    |--------------------------------------------------------------------------
    | Default Broadcaster
    |--------------------------------------------------------------------------
    |
    | This option controls the default broadcaster that will be used by the
    | framework when an event needs to be broadcast. You may set this to
    | any of the connections defined in the "connections" array below.
    |
    | Supported: "reverb", "pusher", "ably", "redis", "log", "null"
    |
    */

    'default' => env('BROADCAST_CONNECTION', 'null'),

    /*
    |--------------------------------------------------------------------------
    | Broadcast Connections
    |--------------------------------------------------------------------------
    |
    | Here you may define all of the broadcast connections that will be used
    | to broadcast events to other systems or over WebSockets. Samples of
    | each available type of connection are provided inside this array.
    |
    */

    'connections' => [

        'reverb' => [
            'driver' => 'reverb',
            'key' => env('REVERB_APP_KEY'),
            'secret' => env('REVERB_APP_SECRET'),
            'app_id' => env('REVERB_APP_ID'),
            'options' => [
                'host' => env('REVERB_HOST'),
                'port' => env('REVERB_PORT', 443),
                'scheme' => env('REVERB_SCHEME', 'https'),
                'useTLS' => env('REVERB_SCHEME', 'https') === 'https',
            ],
            'client_options' => [
                // Guzzle client options: https://docs.guzzlephp.org/en/stable/request-options.html
            ],
        ],

        'pusher' => [
            'driver' => 'pusher',
            'key' => env('PUSHER_APP_KEY'),
            'secret' => env('PUSHER_APP_SECRET'),
            'app_id' => env('PUSHER_APP_ID'),
            'options' => [
                'cluster' => env('PUSHER_APP_CLUSTER'),
                'host' => env('PUSHER_HOST') ?: 'api-'.env('PUSHER_APP_CLUSTER', 'mt1').'.pusher.com',
                'port' => env('PUSHER_PORT', 443),
                'scheme' => env('PUSHER_SCHEME', 'https'),
                'encrypted' => true,
                'useTLS' => env('PUSHER_SCHEME', 'https') === 'https',
            ],
            'client_options' => [
                // Guzzle client options: https://docs.guzzlephp.org/en/stable/request-options.html
            ],
        ],

        'ably' => [
            'driver' => 'ably',
            'key' => env('ABLY_KEY'),
        ],

        'log' => [
            'driver' => 'log',
        ],

        'null' => [
            'driver' => 'null',
        ],

    ],

];

And reverb.php has allowed origins set to *:
<?php

return [

    /*
    |--------------------------------------------------------------------------
    | Default Reverb Server
    |--------------------------------------------------------------------------
    |
    | This option controls the default server used by Reverb to handle
    | incoming messages as well as broadcasting message to all your
    | connected clients. At this time only "reverb" is supported.
    |
    */

    'default' => env('REVERB_SERVER', 'reverb'),

    /*
    |--------------------------------------------------------------------------
    | Reverb Servers
    |--------------------------------------------------------------------------
    |
    | Here you may define details for each of the supported Reverb servers.
    | Each server has its own configuration options that are defined in
    | the array below. You should ensure all the options are present.
    |
    */

    'servers' => [

        'reverb' => [
            'host' => env('REVERB_SERVER_HOST', '<IP_ADDRESS>'),
            'port' => env('REVERB_SERVER_PORT', 8080),
            'hostname' => env('REVERB_HOST'),
            'options' => [
                'tls' => [],
            ],
            'max_request_size' => env('REVERB_MAX_REQUEST_SIZE', 10_000),
            'scaling' => [
                'enabled' => env('REVERB_SCALING_ENABLED', false),
                'channel' => env('REVERB_SCALING_CHANNEL', 'reverb'),
                'server' => [
                    'url' => env('REDIS_URL'),
                    'host' => env('REDIS_HOST', '<IP_ADDRESS>'),
                    'port' => env('REDIS_PORT', '6379'),
                    'username' => env('REDIS_USERNAME'),
                    'password' => env('REDIS_PASSWORD'),
                    'database' => env('REDIS_DB', '0'),
                ],
            ],
            'pulse_ingest_interval' => env('REVERB_PULSE_INGEST_INTERVAL', 15),
            'telescope_ingest_interval' => env('REVERB_TELESCOPE_INGEST_INTERVAL', 15),
        ],

    ],

    /*
    |--------------------------------------------------------------------------
    | Reverb Applications
    |--------------------------------------------------------------------------
    |
    | Here you may define how Reverb applications are managed. If you choose
    | to use the "config" provider, you may define an array of apps which
    | your server will support, including their connection credentials.
    |
    */

    'apps' => [

        'provider' => 'config',

        'apps' => [
            [
                'key' => env('REVERB_APP_KEY'),
                'secret' => env('REVERB_APP_SECRET'),
                'app_id' => env('REVERB_APP_ID'),
                'options' => [
                    'host' => env('REVERB_HOST'),
                    'port' => env('REVERB_PORT', 443),
                    'scheme' => env('REVERB_SCHEME', 'https'),
                    'useTLS' => env('REVERB_SCHEME', 'https') === 'https',
                ],
                'allowed_origins' => ['*'],
                'ping_interval' => env('REVERB_APP_PING_INTERVAL', 60),
                'max_message_size' => env('REVERB_APP_MAX_MESSAGE_SIZE', 10_000),
            ],
        ],

    ],

];

System details:

Mac M1
composer 2.7.2
PHP installed via brew
No docker, no vagrant for this setup locally (no proxy/server config)
No SSL setup locally, just running artisan serve and reverb:start

Steps To Reproduce
Laravel steps to reproduce:

composer create-project laravel/laravel test-websocket ^11.0
cd test-websocket
php artisan install:broadcasting

Would you like to install Laravel Reverb? [Yes]
Would you like to install and build the Node dependencies required for broadcasting? [Yes]

Before I run reverb:start, I check that 8080 isn't in use with lsof -i :8080

php artisan reverb:start --debug
INFO  Starting server on <IP_ADDRESS>:8080 (localhost).

Now, lsof -i :8080 reports that php is listening on a TCP 8080 port:

php     **PID** meder    **FDVALUE**  IPv4 **DEVICEID**      0t0  TCP *:http-alt (LISTEN)
In Chrome and Firefox:
I get:

In Firefox's network tab:

Working node alternative with ipv6 and ipv4:
// server.js
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 8080 });

console.log('WebSocket server is running on ws://<IP_ADDRESS>:8080');

Which lsof -i :8080 confirms node is listening on the 8080 TCP port:
node    **PID** meder   **FDVALUE**  IPv6 **DEVICEID**      0t0  TCP *:http-alt (LISTEN)
I get a 101 response:

Shortly after seeing the lsof output I saw ipv4 php used and ipv6 node used, to which I matched node and it still works, via:
const WebSocket = require('ws');

const server = new WebSocket.Server({ host: '<IP_ADDRESS>', port: 8080 }, () => {
  console.log('WebSocket server is listening on ws://<IP_ADDRESS>:8080');
});

node    **PID** meder   **FDVALUE**  IPv4 **DEVICEID**      0t0  TCP localhost:http-alt (LISTEN)
Screenshot:

Attempt specifying php artisan reverb:start --host=<IP_ADDRESS> didn't work either
Creating a test controller for a 200 OK/green path worked
php artisan make:controller WebSocketTestController

class WebSocketTestController extends Controller
{
    public function test()
    {
        return response()->json(['message' => 'WebSocket test endpoint']);
    }
}

To rule out application wide 404 issues:
curl http://localhost:8000/websocket-test

{"message":"WebSocket test endpoint"}

To confirm, have you cleared out the following REVERB_ prefixed enviroment variables just for the purposes of not wanting to give away any sensitive information in the issue, or are they also empty in your app?
REVERB_APP_ID=
REVERB_APP_KEY=
REVERB_APP_SECRET=

Correct. Actually, I think I found the issue in that it's hitting the 404 in vendor/laravel/reverb/src/Servers/Reverb/Http/Router.php:53:
    /**
     * Dispatch the request to the appropriate controller.
     */
    public function dispatch(RequestInterface $request, Connection $connection): mixed
    {
        $uri = $request->getUri();
        $context = $this->matcher->getContext();

        $context->setMethod($request->getMethod());
        $context->setHost($uri->getHost());

        try {
            $route = $this->matcher->match($uri->getPath());
        } catch (MethodNotAllowedException $e) {
            return $this->close($connection, 405, 'Method not allowed.', ['Allow' => $e->getAllowedMethods()]);
        } catch (ResourceNotFoundException $e) {
                    Log::error('Resource not found for URI: ' . $uri->getPath(), [
                        'uri' => $uri->getPath(),
                        'host' => $uri->getHost(),
                        'method' => $request->getMethod(),
                    ]);
            return $this->close($connection, 500, 'Not found!!!!!.');
        }

I added the above Log::error and this is the log:
[2024-05-21 09:25:27] local.ERROR: Resource not found for URI: / {"uri":"/","host":"localhost","method":"GET"}
Is this because it binds to specific routes that I'm missing beyond the base setup, or?

Ah, I have to do an app specific call, eg new WebSocket('localhost:8080/app/[app_id]')

Hey @medero that's right. You need to tell the Reverb server which app you wish to connect to.

https://beyondco.de/docs/laravel-websockets/advanced-usage/custom-websocket-handlers
I'm also looking for a way to set up a similar classic access point. and I don’t understand how to connect an external frontend to a channel without ws:// wss:/// and how to test it in postman

'{"event": "pusher:subscribe", "data": {"channel": "test-c"}}'
@POMXARK use this to subscribe first and then set broadcasts


value returned by GetValue for multiline includes ENDTAG

Platform: Windows
Compiler: VS 2008, 32-bit
When getting a multi-line value for a key, GetValue() returns string that has the ENDTAG included. I get the same result when walking through TKeyVal of a section.
It happens only when ENDTAG is followed by white-space.
Regards,
Michal.

This behaviour was actually by design, however I have changed it now so that trailing whitespace after the ENDTAG is ignored. This has been fixed in the current file.


Library not filtering JsonNode

I have a JsonNode that looks like this {"codeA":"L736","codeB":"027042","boolVal":false,"uuid":"00000000-0000-0001-0000-000000000001"}
My filter is a String like this: "codeA,boolVal".
I'm feeding these inputs to this function:
public String filter(JsonNode jsonNode, String filters) {
    ObjectMapper objectMapper = Squiggly.init(new ObjectMapper(), filters);
    return SquigglyUtils.stringify(objectMapper, jsonNode);
}

I'm expecting this result:
{"codeA":"L736"," "boolVal":false}
But I keep getting the starting unfiltered jsonNode input .
Could someone help me and point out what is that I'm doing wrong?

@LeonardoChirivi You can use any Bean/POJO (with getters) or a Map. You can also use collections of beans/maps as well.
I have released version 1.3.18, which adds a new context provider: ThreadLocalContextProvider.  Now, you can use this to apply a filter without incurring the cost of creating an object mapper.
Here's an example of how to use it.
import com.fasterxml.jackson.databind.ObjectMapper;
import com.github.bohnman.squiggly.Squiggly;
import com.github.bohnman.squiggly.context.provider.SquigglyFilterHolder;
import com.github.bohnman.squiggly.context.provider.ThreadLocalContextProvider;
import com.github.bohnman.squiggly.util.SquigglyUtils;

public class Example {

    public static void main(String[] args) {
        ObjectMapper mapper = Squiggly.init(new ObjectMapper(), new ThreadLocalContextProvider());
        Person person = new Person("Joe", "Smith");
        System.out.println(filter(mapper, person, "lastName"));
    }

    private static String filter(ObjectMapper mapper, Object value, String filter) {
        try {
            SquigglyFilterHolder.setFilter(filter);
            return SquigglyUtils.stringify(mapper, value);
        } finally {
            SquigglyFilterHolder.removeFilter();
        }
    }

    private static class Person {
        private final String firstName;
        private final String lastName;

        public Person(String firstName, String lastName) {
            this.firstName = firstName;
            this.lastName = lastName;
        }

        public String getFirstName() {
            return firstName;
        }

        public String getLastName() {
            return lastName;
        }
    }
}

That's great. However I don't have the possibility to use POJOs in my case.
The JSON coming in has a fixed structure, but the filters nedd to be dynamically set by the users. Therefore I can't code all the POJOS  to cover all cases!
I think I'll be looking forward for version 2!

@LeonardoChirivi  I'm not sure I understand your use case.
If you expect the JSON to be filtered as you are reading it and you want a filtered representation of the JSON to work with, I can kind of see where you're coming from.
However, If you are just reading in JSON and then serializing it to a String like you provided in your example, why can't you use a POJO (if it's a fixed structure) or a Map, which is unstructured?
As far as user supplying filters dynamically, that was the original intent of Squiggly.  There are sample applications in the examples directly where you can run squiggly in a web server and specify filters in the query string of a browser.
I wanted to pose this because I'd hate for you have to wait months for a new release, if there's a fix right now.
~Ryan


Site design

Hmm... seems like you can only assign one person, but @wallpind and I will tackle this. Let's use this thread for posting design inspiration.

I like this. It feels pretty clean and I like the dark theme.
Source: https://dribbble.com/shots/2271087-Team/attachments/426476

Some logo explorations. Not in love with them but I like the glitch/pixelation feel.


Fix target detection on Windows

For whatever reason "concrete" targets don't work properly on Windows. We should figure out why...

Fixed on 21ff9c1a010a2be75e8de8fb3d780701433e3fe7


Signature not being rendered

Describe the bug
Use the wasm version, the signature in the page not rendered. any way to render the signature?
To Reproduce
Steps to reproduce the behavior:

Go to 'https://pdfviewer.github.io/'

open the pdf document attached here
in_pdfbox_2.0.3.pdf

See error, the signature is not rendered

Screenshots

System (please complete the following information):

OS: Mac sonoma
Version pdfium-lib 6183
Target wasm

Strange, because i open in a PDF editor and it don't show too:

I tried on canva.com and the problem is the same:

I tried on an online pdf editor too, and the problem is the same:

Maybe the problem is how you put your signature in PDF.

Hi,
It appear be a more general problem with PDFium and is not related to this project in particular.
I open in Apple Preview app and in Chrome app, and the Chrome that use PDFium, the problem still happen.

I post a issue on Google Groups of PDFium and we can see if anyone help us:
https://groups.google.com/g/pdfium/c/o23SlFQJn6o
Thanks.

If you think this is a bug in pdfium, you should probably use the bugtracker:
https://issues.chromium.org/issues?q=componentid:1586257%2B is:open
I don't think they keep track of issues posted on the mailing list.

This is the Freddy Ferkel (from pdfium group) answer:
what are you rendering? the page? if yes and it is a signature field, you should also render the corresponding form (form->annot->widget->signature with FPDF_FFLDraw).
see also the documentation, for example, FPDF_RenderPageBitmap. which says: With the FPDF_ANNOT flag, it renders all annotations that do not require user-interaction, which are all annotations except widget and popup annotations.

and:
I looked at the file. It does contain a signature and a widget, but it looks to me that the file is not structured correctly. I'm not a PDF expert but search for "17 0 obj", there are two objects with the number 17. Maybe this could be the problem?

The PDF can be generated wrong?

He make a test removing the problem and it render:


Pdf export of the dashboard

Is your feature request related to a problem? Please describe.
I'd like to know if it is possible to export the dashboards to pdfs or to access the graphs from a notebook in order to then export the visualizations.
Thank you (and good job btw)

I think your question is two things, right?
First, we manage the dashboard screen as an image when presenting the dashboard list. From our point of view, there is not much difference in exporting images or pdf. Could you tell us why you need export to pdf?
Secondly, we are discussing how to export the graph(chart) in the dashboard to a notebook like zeppelin. I think there will be good news soon.

Don't worry @kyungtaak , I see you're very active on this project.
Yes, these are potentially two different questions. I'd like to export the whole dashboard in presentation view as a single image or pdf. Right now I can only export the single chart.
The ability to export charts to a notebook would be another great feature to have.
Thank you for your attention!

@danigamba I'm going to discuss with the design team for The function of exporting the dashboard screen as an image. Thank you again for your interest :)


Avoid conflict between index dropdown and collection dropdown

Codecov Report

Merging #256 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #256   +/-   ##
=======================================
  Coverage   76.86%   76.86%
=======================================
  Files          39       39
  Lines         752      752
=======================================
  Hits          578      578
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b8590...d6094d1. Read the comment docs.


Which is YouTubeVOS refered to?

Hi, in Datasets Required for Training, what is YouTubeVOS refered to? Video Object Segmentation or Video Instance Segmentation?

It refers to Youtube Video Object Segmentation dataset.


Add ability to uninstall plugins

This is a reworked #5473

@fatkodima Thanks for all the fixes, including this one! :)
Before I have a look, if you used the code in the original #5473 PR as a starting point, would you mind adding coauthorship information to the commit, so that @Shekharrajak is properly credited?
Thanks!

Added Co-authored-by.

You can also cherry-pick the commit (or use the same branch after the rebase)and do the changed top of that.


Jmf cd implementation failed

Update CD workflow file.
Certificate name Revised
Distribution URL Revised
MSIX publisher ID revised to match the CN displayed in the crt file

ok

ok


Make ”View MD Source” buttons less conspicuous

They are rarely-used and relatively unimportant, so they shouldn’t look that eye-catching or take up so much screen real estate.
A test page
Before

After

Awesome, thanks.


yaml variables that can set using a flag

Hello there,
I wanted to send in a contribution cause i find this project very cool.
I  started working on the new todo as a contribution  towards the project.
Problem is  i seem to have a little confusion on what it means exactly.
Does it mean you want a feature where users can set various variables  as key pair values using a flag eg --flags name:john, age:45 ? and where exactly is the variable supposed  to be parsed and used?
See i started working on it thinking you just wanted a way to replace file or directory names with a set yaml variable  using a flag like the example above(and i seem to have that working) but now i'm not so sure . Would be helpful if you help clarify what you mean exactly. Thanks

A variable in Yaml should be declared like this;
$TEST: teat
to use it,

hello:
   hello.txt: |
        {TEST}
The variable can be set using flags, just like you said. {TEST} should be parsed to value of TEST variable

P.S The YAML file itself shouldn't be updated with actual variable replacing {TEST}; When you parse the YAML, you replace any reference of the variable with its corresponding variable in Go that can be allocated using make. Feel free to think of your own implementation though

@cemister  i made some code modifications following your first reply and now all references  of a variable are  replaced with its corresponding value in the generated output not the yaml file containing the scaffold.  i should send a PR in any minute .
eg setting some variables by flag like this --values name:john, age:44
hello:
hello.go: |
fmt.Println("{name}")
output => fmt.Println("john")

Great! You may as well update the README and then I'll merge.

sure thing!


Fix Yarn v3 @lavamoat/allow-scripts plugin build

Seems that the Yarn v3 @lavamoat/allow-scripts plugin had typo in the build. Fixed this by re-running the build command.

For those who look at the diff and get confused initially
the typo fix

not the typo fix

Yeah, the re-naming of the prototype functions must not be deterministic, because I didn't touch those 😅


Add a lock command

This PR adds a new lock command which, as in other library managers, "locks" the current state of the libraries in the project. This is useful for reproducing the exact state of dependencies in a project (on a new machine or in Docker), especially when working with libraries installed from git.
The output is in HXML (-L lib:version ...) and it is dumped to stdout instead of a file.
The intended workflow is following:

do package management operations
lock the dependencies: haxelib lock > haxelib-lock.hxml
apply the lockfile in another environment: haxelib install --skip-dependencies --always haxelib-lock.hxml

I've created this for my personal usage and providing this patch hoping it could be useful to more developers. If inappropriate, feel free to add notes/close the PR.
Before merging, support for locking versions of Mercurial libs (installed using haxelib hg ...) should be added. I am not a Mercurial user myself, so help would be greatly appreciated.

Thanks!
I think this can be merged once the above points have been handled

Hopefully I will finish this till the end of the week.

This PR is now ready as far as I'm concerned.
Will wait a bit before merging in case someone has some argument against it.

Thanks for all the work :) Just sat down to work on this and saw you'd already finished it (much better than I would have).

Hope it still matches your workflow! Changed into a file arg so that windows people don't freak out :sweat_smile:

@Simn is it ok to merge this?
Documentation will wait a bit (for a new haxelib release), and can be done on a separate PR.


Add set syntax command

Opening a feature request issue for the :set syntax command that we all know and love :)
So for example, typing the following:
:set syntax=html

would automatically set the current file's syntax highlight to html.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


[FEATURE] Container Support

Description

As a
Developer
I want to
Deploy this app in a container
So that I can
Use my preferred hosting
Languages
This feature is now implemented in:

[ ] Python
[ ] Node.js
[ ] Java

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

We should rebuild the container every merge to main with GitHub actions


KYUUBI-149 support yarn-cluster mode for kyuubi

Codecov Report

Merging #1 into master will decrease coverage by 42.67%.
The diff coverage is 1.46%.

@@              Coverage Diff              @@
##             master       #1       +/-   ##
=============================================
- Coverage     73.62%   30.95%   -42.68%
- Complexity      569      577        +8
=============================================
  Files            77      164       +87
  Lines          3394     8079     +4685
  Branches        492     1180      +688
=============================================
+ Hits           2499     2501        +2
- Misses          632     5315     +4683
  Partials        263      263

Impacted Files
Coverage Δ
Complexity Δ

...rver/src/main/scala/org/apache/livy/EOLUtils.scala
0% <0%> (ø)
0 <0> (?)

...la/yaooqinn/kyuubi/spark/SessionCacheManager.scala
0% <0%> (ø)
0 <0> (?)

...c/main/java/org/apache/livy/rsc/JobHandleImpl.java
0% <0%> (ø)
0 <0> (?)

...ava/org/apache/livy/client/common/BufferUtils.java
0% <0%> (ø)
0 <0> (?)

...e/livy/server/interactive/InteractiveSession.scala
0% <0%> (ø)
0 <0> (?)

...he/livy/server/recovery/FileSystemStateStore.scala
0% <0%> (ø)
0 <0> (?)

...main/java/org/apache/livy/rsc/ContextLauncher.java
0% <0%> (ø)
0 <0> (?)

...rc/main/java/org/apache/livy/rsc/BaseProtocol.java
0% <0%> (ø)
0 <0> (?)

...in/scala/org/apache/livy/server/AccessFilter.scala
0% <0%> (ø)
0 <0> (?)

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
0% <0%> (ø)
0 <0> (?)

... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c606c1...222fd6c. Read the comment docs.


Update prelaunch-live-email-templates.md

Replaced below with following.

@sarahberg
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@Sarahberg
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


REDIS Issues..

I suspect this is more of a docker issue, but when using the redis docker image with the latest tag, I'm now getting failures with it.. Basically its failing with a "Can't initialize background jobs" fatal error.  This was working perfectly fine for a while and then died without warning.  The only way to get around this issue was to move Redis outside of docker to native Linux install..
I tried a re-installation of the server and dumped the data back in the system and it worked again, and then after a few days died.. so there is something that's getting put into the system that causes Redis to die.. (so far, it seems to be better as a native service than as a docker container (running on the same server).

After working through these issues (had the same "break" with the Millei backend, I think the issue is docker will periodically NOT resolve the names to these resources and then it breaks things.. So the only way to get this fixed is to assign ports to these elements (per your docker instructions) and then in the configurations,  follow the steps in the documentation (found here: https://bar-assistant.github.io/docs/setup/) but then make it look like:
meilisearch:
image: getmeili/meilisearch:v1.1
container_name: meilisearch
environment:
- MEILI_MASTER_KEY=$MEILI_MASTER_KEY
- MEILI_ENV=production
- REDIS_HOST=<IP_ADDRESS>
restart: unless-stopped
ports:
- 7700:7700
volumes:
- /home/duser/docker/mybar/meilisearch_data:/meili_data
redis:
image: redis:6.2.12
container_name: redis
environment:
- ALLOW_EMPTY_PASSWORD=yes
restart: unless-stopped
ports:
- 6379:6379
volumes:
- /home/duser/docker/mybar/redis_data:/data
bar-assistant:
image: barassistant/server:latest
container_name: bar-assistant
depends_on:
- meilisearch
environment:
- APP_URL=$API_URL
- LOG_CHANNEL=stderr
- MEILISEARCH_KEY=$MEILI_MASTER_KEY
- MEILISEARCH_HOST=http://<IP_ADDRESS>:7700
- REDIS_HOST=<IP_ADDRESS>
- ALLOW_REGISTRATION=false
restart: unless-stopped
volumes:
- /home/duser/docker/mybar/bar-assistant:/var/www/cocktails/storage/bar-assistant
Once this is done, then things seem to work more stable..  Essentially this looks like it could be a docker issue..


Very low full node sync

Walet synced, full node takes weeks.

Please update your program to the latest version


message.content is undefined, "that file might've been a virus"

i was starting my ddrive and i kept noticing that it kept crashing during launch. i've dug into this and found that discord, apparently, detected one of the uploading files as a virus and in result did not upload it. solved by deleting the messages, but i'd suggest adding a failsave for that
// my own code i added to find the exact messages
// src/discordFS/index.js, just before messagesGroupByType
tempMessageCache.forEach(message => {
    if (!message.content) {
        debug('>>> INVALID MESSAGE CONTENT')
        debug(message)
    }
})

Thanks for bringing this up. Will patch it.

Fixed in version 3.7.1 #56


Write a Scala program to find gcd of two numbers

Description
Write a Scala program to find gcd of two numbers
GCD (Greatest Common Divisor) of two numbers is the largest number that divides both of them. A simple way to find GCD is to factorize both numbers and multiply common factors.
Input  : 12 18
Output : 6

How to contribute

Save the solution in program/findGcdOfTwoNumbers.scala file
Add findGcdOfTwoNumbers.scala file in find-gcd-of-two-numbers folder

!assign


Is it possible to add a colorbar?

Is there a build-in way in dash-vtk to add a colorbar, e.g. to a PointCloudRepresentation?
I could not find anything anything about this, except this workaround where a colorbar is added using an empty `plotly go.Figure()' and someone asking for it in the Plotly forum.

Ideally PointCloudRepresentation should expose the same properties as the default GeometryRepresentation.
That seems to be the case in react-vtk-js but dash-vtk was not updated to reflect it.
Otherwise someone with the current version could do what we do inside PointCloudRepresentation but using dash-vtk directly.

I just saw that someone already opened a PR for this feature.
https://github.com/plotly/dash-vtk/pull/61

But the PR does that, right?

No, the PR, just expose those props in GeometryRepresentation not in PointCloudRepresentation


Autoplay Plugin Import issue

Hi there,
I'm using the  component for reference.
When I import autoplay plugin using the recommended format per README.md,
e.g. import autoplay from "solid-slider/plugins/autoplay";
I get IDE error:
"Cannot find module 'solid-slider/plugins/autoplay' or its corresponding type declarations."
The webpage does not load and web-dev console error is as follows:
"Uncaught SyntaxError: The requested module '/node_modules/solid-slider/dist/autoplay/autoplay.jsx' does not provide an export named 'default'"
When I change the import to:
e.g. import { autoplay } from "solid-slider/plugins/autoplay";
I get the same IDE error, however, the webpage loads and autoslide works.
Just bringing this to dev attention so it gets cleaned up to work without any error messages. Thanks!

I updated the NPM imports a while back, but @davedbase may need to republish the package on NPM for those changes to be implemented on the public repo.

@joeygrable94 hmmm I did publish at the time I believe. Either way I just published a new version with the latest Solid dependency bump.
So sorry for the delay on this!

Appreciate the follow up @davedbase and @joeygrable94!
I uninstalled the package and reinstalled latest version 1.3.15 and I still see the same problem as what I described in my first post. I saw the pushed import changes on package.json, but could it be an issue with the exports from autoplay.jsx not having a default export?

can confirm types are still broken

Yep types are still broken


[GsoC][BanyanDB] Self-Observability: Create Measure Schema

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.
[ ] Update the documentation to include this new feature.
[ ] Tests(including UT, IT, E2E) are added to verify the new feature.
[x] If it's UI related, attach the screenshots below.
[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#10634.
[ ] Update the CHANGES log.

Create measures for metrics in when running in native observability mode

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.65%. Comparing base (18a138f) to head (622da33).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #462       +/-   ##
===========================================
+ Coverage   40.53%   51.65%   +11.12%
===========================================
  Files         156      156
  Lines       18909    18898       -11
===========================================
+ Hits         7664     9761     +2097
+ Misses      10613     8332     -2281
- Partials      632      805      +173

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Halloluise has degraded performance

In 9d7ea30, Halloluise (https://halloluise.de) experienced degraded performance:

HTTP code: 200
Response time: 2160 ms

Resolved: Halloluise performance has improved in 256b50c.


Label force replace when name is edited

Describe the bug
Hello, if i try to edit a label ( the name or the color of this one ) the label is force replaced and as so change of ID in harbor
To Reproduce
Change the name of the ressurce
Expected behavior
I can't see why the name can be just replace
Additional context
# module.app_deployer["app_7"].harbor_label.template[0] must be replaced
-/+ resource "harbor_label" "template" {
      ~ id    = "/labels/431" -> (known after apply)
      ~ name  = "POC-FR-EXO-TEST-MAILLERIE-FULL-WORKING8" -> "POC-FR-EXO-TEST-MAILLERIE-FULL-WORKING89" # forces replacement
      ~ scope = "g" -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Provider Version : harbor v3.10.12
Terraform v1.6.5
Harbor Version : dunno

hi @Nabatsar ,
Thank you for the bug report
This will be fixed in the next version


Property 'Shorcutkeys' caused context menu to not show up

Version of SharpShell used: 2.7.2
Related type(s) of SharpShell-Server: : ShellContextMenu
Greetings.
Followed the Count Line project tutorial with a few tweaking and successfully built a dll as .net framework 4.0 class library using VS2019 on a win7 x64 PC.
Loaded it into ServerManager 2.7.2 and have all the info shown in the right panel. Then when I put it to the test in the test shell, the context menu failed to show up.
Eventually I found out that it is the 'Shortcutkeys' property of ToolStripMenuItem causing the issue.
Does any one have any ideas how this happened?
Here is the Sharpshell log roughly translated from Traditional Chinese:
2020-05-24 05:38:00.278Z - ServerManager - error: CopyFilesPath_UTF8: An exception occured building the context menu.
2020-05-24 05:38:00.280Z - ServerManager - error: System.ComponentModel.InvalidEnumArgumentException: Attribute 'value' (88) of Enum type 'Keys' is not valid.
Attribute name: value
   at System.Windows.Forms.ToolStripMenuItem.set_ShortcutKeys(Keys value)
   at CopyFilesPath_UTF8.CopyFilesPath_UTF8.CreateMenu() at K:\Repos\CopyFilesPath_UTF8\CopyFilesPath_UTF8\CopyFilesPath_UTF8.cs: 行 27
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at SharpShell.SharpContextMenu.SharpContextMenu.SharpShell.Interop.IContextMenu.QueryContextMenu(IntPtr hMenu, UInt32 indexMenu, Int32 idCmdFirst, Int32 idCmdLast, CMF uFlags) at C:\projects\sharpshell\SharpShell\SharpShell\SharpContextMenu\SharpContextMenu.cs: line 76

My CreateMenu() method code snippet as follows:
        protected override ContextMenuStrip CreateMenu()
        {
            //throw new NotImplementedException();
            var menu = new ContextMenuStrip();
            var item_CopyPath = new ToolStripMenuItem
            {
                Text = "SharpShell copy path (X)",
                //ShowShortcutKeys = true,
                ShortcutKeys = Keys.X,
                //ShortcutKeyDisplayString = "lkjsdflksjdfl"
            };
            item_CopyPath.Click += (sender, args) => MainProcess();
            return menu;
        }

Yes I also find out that ShortcutKeyDisplayString and ShowShortcutKeys cause the same problem as well but the reason seems different. The log shows that after querying Context Menu for items it just stoped right there.

Argghghghg save my from poorly written code! The issue is the Systems.Windows.Forms code, specifically here:
https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/WinForms/ToolStripManager.cs,869a29ff62a2cace
Basically, when you set a shortcut key via the ShortcutKeys property, it makes a call to IsValidShortcut. And if it is not a valid shortcut, it throws an exception.
It turns out you cannot set the shortcut to something like Keys.Z, because there is no modifier so it has to be something like Keys.Alt | Keys.Z and then it won't crash.
This is terrible code here I've got to say; setting a property value should not call logic like this because it is totally unclear to the caller that there is actually a lot more going on (one would assume setting a property just sets a value, not go through a complex logic chain).
The fact that this isn't even documented is worse!
Anyway, I've noted this in the SharpShell docs here:
https://github.com/dwmkerr/sharpshell/blob/master/docs/context-menu.md#shortcut-keys
So hopefully others won't have this issue in the future!
Thanks for all of the details you added when raising the issue, it made it much easier for me to debug what was going on!

Got it. Thanks Dave!
Thankfully we still have backup plan, which is adding a & symbol before the character one wants to assign to, directly in the string of Text property.
For example:
var item_CopyPath = new ToolStripMenuItem
            {
                Text = "SharpShell copy path (&X)"
            };

In the context menu it will be shown as:
SharpShell copy path (X)
And Keys.X become the desired hotkey.

Great, glad it's working @galvn, I'll link the docs to this issue in case anyone else has the same challenge in the future.


PNC Condition closure

IMPORTANT: Where possible all PRs must be linked to a Github issue
Partial fix for [Quest/eCHIS] - Event Management/PNC
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
[ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

We can merge this in and track the TD under #2488 cc @Rkareko


The layout applied to each monitor has been initialized.

Microsoft PowerToys version
0.68.0
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
Hello, developer.
I'm using Power Toy's Fancy Zone very well.
But there's one problem.
I'm a triple monitor user.
I applied a layout editor to each monitor and was in use.
However, when you reboot the computer, all of the applied layouts are initialized.
Is there a way to fix this bug?
✔ Expected Behavior
Reboot the layout to each monitor and it should be applied without initialization
❌ Actual Behavior
The layout applied to each monitor has been initialized.
Other Software
I don't know.

/dup #16370


acl: remove acl pkg

we have changed to role based access control. remove the old acl pkg in favor of the new security pkg.

/cc @barakmich

lgtm


Integration tests for createObservableStream() and observeChanges()

@nikitin-da can you write integration tests for that?
I hope you'll like RxJava :)

Yep!

@nikitin-da any estimation on this? RxJava is waiting for you :)

Sorry, I hope 2 days.

No problems, just asking :)
сб, 25 апр. 2015, 20:58, Dmitrii Nikitin<EMAIL_ADDRESS>
Sorry, I hope 2 days.
—
Reply to this email directly or view it on GitHub
https://github.com/pushtorefresh/storio/issues/295#issuecomment-96246433
.

Done!


Add author annotation for logic

I add author annotation for the logic part. I have indicated the classes/methods in the logic part that I created and coded to be my code.

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #154   +/-   ##
=========================================
  Coverage     67.47%   67.47%
  Complexity      663      663
=========================================
  Files           112      112
  Lines          2435     2435
  Branches        266      266
=========================================
  Hits           1643     1643
  Misses          691      691
  Partials        101      101

Impacted Files
Coverage Δ
Complexity Δ

...eedu/address/logic/commands/AddContactCommand.java
100.00% <ø> (ø)
8.00 <0.00> (ø)

...address/logic/commands/AddJournalEntryCommand.java
63.33% <ø> (ø)
8.00 <0.00> (ø)

...ddress/logic/commands/ClearAddressBookCommand.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...du/address/logic/commands/ClearJournalCommand.java
25.00% <ø> (ø)
1.00 <0.00> (ø)

...u/address/logic/commands/DeleteContactCommand.java
75.00% <ø> (ø)
7.00 <0.00> (ø)

...ress/logic/commands/DeleteJournalEntryCommand.java
21.42% <ø> (ø)
2.00 <0.00> (ø)

...java/seedu/address/logic/commands/FindCommand.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...edu/address/logic/commands/FindContactCommand.java
83.33% <ø> (ø)
7.00 <0.00> (ø)

...ddress/logic/commands/FindJournalEntryCommand.java
100.00% <ø> (ø)
6.00 <0.00> (ø)

...edu/address/logic/commands/ListContactCommand.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93f90e...2846ffa. Read the comment docs.


Split representation of semantic and syntactic nodes

Goal
Implements: https://github.com/libp2p/go-smart-record/issues/14
Fixes: https://github.com/libp2p/go-smart-record/issues/17

@petar, I think this is ready for review. Thanks!


[INLONG-7720][Manager] Creating schema of StreamSource by Excel

#7720

I think it's better to divide this PR to two individual ones, one for excel tool, one for schema of StreamSource.

Implemented by #7720 sub-tasks, so close it.


How to add custom js like adding custom css

How to add custom js like adding custom css

you cannot add custom js.

ok thank you


Fix uns/obs typo

I found an important typo to fix! This should have said .obs, not .uns.
Once this goes in, I'll cherry-pick into the 2 release draft PRs.

noting commits were cherry-picked ✅


Create a new release with #43

I want to fix #42 first (allowing to have an empty config) and I'll tag a new release.

Done!

Thanks!


Character backgrounds only have 2 options

You can only choose from "Acolyte" or "Shelter of the Faithful"
See here:
https://github.com/foundryvtt/dnd5e/blob/master/packs/backgrounds.db

Acolyte is the only background in the SRD, we cannot include any more.


terraform_docs: unable to specify relative PATH to config file

Describe the bug
I looked over the below block on how tf docs pick the config file.
https://github.com/terraform-docs/terraform-docs/blob/3d84cad448378bc36dfef856a319ff6a43d7752f/internal/cli/run.go#L133
v.AddConfigPath(r.rootDir)              // first look at module root
	v.AddConfigPath(r.rootDir + "/.config") // then .config/ folder at module root
	v.AddConfigPath(".")                    // then current directory
	v.AddConfigPath(".config")              // then .config/ folder at current directory
	v.AddConfigPath("$HOME/.tfdocs.d")      // and finally $HOME/.tfdocs.d/

	if err := v.ReadInConfig(); err != nil {
		var perr *os.PathError
		if errors.As(err, &perr) {
			return fmt.Errorf("config file %s not found", config.File)
		}

I have my configuration files under precommit dir as below
user: Github/terraform-mod-ecs-service
└─ $ ls -la precommit/
 .
 ..
 .pre-commit-config.yaml
 .terraform-docs.yml
 Dockerfile
 docker-compose-multibranch.yml
 entrypoint.sh
 gitleaks-config.toml

my precommit config is:
#  pre-commit run --all-files --verbose
repos:
  - repo: https://github.com/antonbabenko/pre-commit-terraform
    rev: v1.50.0
    hooks:
      - id: terraform_docs
        args: [
          '--args=--sort-by required',
          '--args=--config=.terraform-docs.yml'
          #'--args=--config=precommit/.terraform-docs.yml'
        ]
        exclude: >
          (?x)^(
              examples/.*$
          )$

user: Github/terraform-mod-ecs-service
└─ $ pre-commit run -c ./precommit/.pre-commit-config.yaml --all-files --verbose
Terraform docs...........................................................Failed
- hook id: terraform_docs
- duration: 1.75s
- exit code: 1

Error: config file .terraform-docs.yml not found

user: terraform-mod-ecs-service/precommit
└─ $ pre-commit run -c .pre-commit-config.yaml --all-files --verbose
Terraform docs...........................................................Failed
- hook id: terraform_docs
- duration: 1.67s
- exit code: 1

Error: config file .terraform-docs.yml not found

Please let us know what behaviour you expected and how terraform-docs diverged from that behaviour.
.terraform-docs.yml should be picked as config for tf-docs or someone can suggest if there is other way.
Adding yml file to each directory where I have readme with tf-docs hooks works. But I would like to have only one yml file to the precommit dir if possible.
Thank you in advance.
How can we reproduce it?
with above steps.

Environment information
└─ $ pre-commit autoupdate
Updating https://github.com/antonbabenko/pre-commit-terraform ... already up to date.
└─ $ pre-commit --v
pre-commit 2.11.1

- terraform-docs version (use `terraform-docs --version`):  terraform-docs version v0.14.1 darwin/amd64
- Go version (if you manually built. use `go version`): go version go1.16.2 darwin/amd64
- OS (e.g. Windows, MacOS): Darwin 20.6.0 Darwin Kernel Version 20.6.0

Hi, @7adityaraj .
I think it can be fixed by #155. You can try clone repo, checkout to PR branch, and use pre-commit try-repo (more details) to check is it works for you.
After, check, please describe is it help you.

Hi @MaxymVlasov,
Thank you for the suggestions.
I tried with commit ID as below, but it didn't work. May be I am still missing something
repos:
    - repo : https://github.com/jans-forks/pre-commit-terraform
      rev  : 39d811f
      hooks:
       - id: terraform_docs
         files: (\.tf)$
         exclude: >
          (?x)^(
              examples/.*$|
              modules/alb/.*$|
              modules/nlb/.*$|
              modules/elb/.*$|
              modules/elb-tcp/.*$|
              modules/simple/.*$|
              modules/alb-wi/.*$
          )$
         args:
          - --config=precommit/.terraform-docs.yml
          - md

>> running precommit from ./precommit/.pre-commit-config.yaml
Terraform docs...........................................................Failed
- hook id: terraform_docs
- duration: 1.47s
- exit code: 1

WORKING with: "--config=precommit/.terraform-docs.yml"
Adding arg
WORKING with: "md"
Adding arg
WORKING with: "modules/core/ecr.tf"
WORKING with: "config.tf"
WORKING with: "modules/core/locals.tf"
WORKING with: "main.tf"
WORKING with: "modules/core/task.tf"
WORKING with: "outputs.tf"
WORKING with: "modules/core/autoscaling.tf"
WORKING with: "modules/core/ecs_lb.tf"
WORKING with: "modules/core/data.tf"
WORKING with: "variables.tf"
WORKING with: "modules/core/outputs.tf"
WORKING with: "modules/core/variables.tf"
Error: config file precommit/.terraform-docs.yml not found

Good, at least now it show right path to config file in error.
@7adityaraj , using this fork, try change first arg to
- --config=__GIT_WORKING_DIR__/precommit/.terraform-docs.yml

Many thanks @MaxymVlasov,
It works when I pass the full path of the yml file. Also, I figure out with your help, it does work with the previous release tag 1.50.0 when I provide the full path of yml file. Is this expected or do we need to fill a bug for it.

This is exepted behavior.
I will clarify docs about that.

And __GIT_WORKING_DIR__ - is not full path, it argument that should be passead as is
@7adityaraj

Like this one

@MaxymVlasov,
It didn't work that way.
Terraform docs...........................................................Failed
- hook id: terraform_docs
- duration: 1.55s
- exit code: 1

WORKING with: "--config=__GIT_WORKING_DIR__/precommit/.terraform-docs.yml"
Adding arg
WORKING with: "md"
Adding arg
WORKING with: "modules/core/ecr.tf"
WORKING with: "config.tf"
WORKING with: "modules/core/locals.tf"
WORKING with: "main.tf"
WORKING with: "modules/core/task.tf"
WORKING with: "outputs.tf"
WORKING with: "modules/core/autoscaling.tf"
WORKING with: "modules/core/ecs_lb.tf"
WORKING with: "modules/core/data.tf"
WORKING with: "variables.tf"
WORKING with: "modules/core/outputs.tf"
WORKING with: "modules/core/variables.tf"
Error: config file __GIT_WORKING_DIR__/precommit/.terraform-docs.yml not found

Terraform docs...........................................................Passed
- hook id: terraform_docs
- duration: 2.75s

WORKING with: "--config=/Users/user1/Documents/GitHub/terraform-mod-ecs-service/precommit/.terraform-docs.yml"
Adding arg
WORKING with: "md"
Adding arg
WORKING with: "modules/core/ecr.tf"
WORKING with: "config.tf"
WORKING with: "modules/core/locals.tf"
WORKING with: "main.tf"
WORKING with: "modules/core/task.tf"
WORKING with: "outputs.tf"
WORKING with: "modules/core/autoscaling.tf"
WORKING with: "modules/core/ecs_lb.tf"
WORKING with: "modules/core/data.tf"
WORKING with: "variables.tf"
WORKING with: "modules/core/outputs.tf"
WORKING with: "modules/core/variables.tf"

Is it work if use tag 1.50 from this repo?
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.50.0
  hooks:
  - id: terraform_docs
    args:
    - --config=__GIT_WORKING_DIR__/precommit/.terraform-docs.yml
    - md

no luck.
 - repo: https://github.com/antonbabenko/pre-commit-terraform
      rev: v1.50.0
      hooks:
       - id: terraform_docs
         args:
          - --config=__GIT_WORKING_DIR__/precommit/.terraform-docs.yml
          - md
         exclude: >
          (?x)^(
              examples/.*$|
              modules/alb/.*$|
              modules/nlb/.*$|
              modules/elb/.*$|
              modules/elb-tcp/.*$|
              modules/alb-wi/.*$|
              modules/alb/.*$|
              modules/simple/.*$
          )$

Terraform docs...........................................................Failed
- hook id: terraform_docs
- duration: 0.02s
- exit code: 1

getopt: unrecognized option '--config'

That really looks like a bug.
Depends on #155 merge.

reminder: Need to document TFlint relative path usage

Thank you, @7adityaraj !
I will fix this in ~3-4 weeks. If it too long - you can try prepare fix based on #155 and send PR (don't forget mention here if you'll start contibuting)

thank you @MaxymVlasov  and will wait for the next release. I am using a workaround as have a copy of yml file in each readme directory with tag 1.50.0

reminder: Need to document TFlint relative path usage

Already done

Why is this function doing such convolute stuff for functionality that is built-in to terraform-docs?
It basically does
terraform-docs markdown --config .tfdocs-markdown.yaml ${terraform_module_folder}

where the config file looks like:
formatter: markdown

output:
  file: README.md
  mode: inject
  template: |-
    <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
    {{ .Content }}
    <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

@tpdownes In short, the terraform_docs hook in pre-commit-terraform used to handle a variety of versions of Terraform starting from versions before 0.12 (yes, it was a few years ago) and terraform-docs has been evolving.
We are improving it all the time.

@7adityaraj you missing that it will be in 1.53.0 :)
You can you latest commit SHA from master branch, for tests proposes


APIX Update for Moodles (Still needs signature fix)

Will output errors when attempting to use UI due to missing sig, but everything else has been updated for API-X

Omg I had no idea you submitted this PR because I switched off all Github emails before I came to Ukraine. @Limiana can you check this out and maybe it'll save you some time with the update?
Thank you so much! ❤

Thank you!
I was sure I merged it before, but apparently not


Feature/555 taker flow

Would appreciate some eyes on this.
Done

Have set up to pull FullOrder data from URL and pass down to component + children
Altered stringToSigDecimals function slightly to encompass an edge case

Issues:

SettingsPopover calls AppRouteParams, which only returns "order", not the full URL on language change.

Questions:

Majority of component relies on tokenLists from a connected wallet. I'm thinking a loading spinner + "Please connect wallet" overlay to cover these cases?
does OrderStatus persist in store? Is there a way to know whether an order has been cancelled or taken?
what function will give me a correct txHash for etherscan url?

Branched from 544/maker-flow. Final PR will rebase etc.

Would appreciate some eyes on this.
Done

Have set up to pull FullOrder data from URL and pass down to component + children
Altered stringToSigDecimals function slightly to encompass an edge case

Issues:

SettingsPopover calls AppRouteParams, which only returns "order", not the full URL on language change.

Questions:

Majority of component relies on tokenLists from a connected wallet. I'm thinking a loading spinner + "Please connect wallet" overlay to cover these cases?
does OrderStatus persist in store? Is there a way to know whether an order has been cancelled or taken?
what function will give me a correct txHash for etherscan url?

Branched from 544/maker-flow. Final PR will rebase etc.

SettingsPopover calls AppRouteParams, which only returns "order", not the full URL on language change.

AppRouteParams is only for the SwapWidget, should definitely rename that to avoid confusion.
You should just use useParams from react-dom. I will add changes to the make branch to make it work. Then you should just use this to OrderDetailWidget:
To const params = useParams<{ compressedOrder: 'string' }>();

Majority of component relies on tokenLists from a connected wallet. I'm thinking a loading spinner + "Please connect wallet" overlay to cover these cases?

Refer to the Make and Swap widget how to do this.

does OrderStatus persist in store? Is there a way to know whether an order has been cancelled or taken?

Good question. Please ask Don or on the dev meeting tuesday.

what function will give me a correct txHash for etherscan url?

Same! Not sure how to know an order is taken and what the txHash is.
You can still prepare for the canceled / taken scenario's though. So just hardcode it for now for testing.

And some warnings in console:
src/components/OrderDetailWidget/OrderDetailWidget.tsx
  Line 85:6:  React Hook useMemo has a missing dependency: 'signerAmount'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  Line 91:6:  React Hook useMemo has a missing dependency: 'senderAmount'. Either include it or remove the dependency array  react-hooks/exhaustive-deps


Add linesOf variants for a Path content

Check List:

Fixes #2617
Unit tests : YES
Javadoc with a code example (on API only) : NA
PR meets the contributing guidelines

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

Thanks for the fast turnaround, @StefanBratanov!

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

We're now focusing on finalizing 3.23.0, let's see if we can squeeze this in. Please use 3.23.0.

Thanks for the fast turnaround, @StefanBratanov!

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

We're now focusing on finalizing 3.23.0, let's see if we can squeeze this PR in the release. Please use 3.23.0.

Thank you. :) Done.

Thanks for your first contribution, @StefanBratanov!

Thanks for your first contribution, @StefanBratanov!

No worries :) I have been using AssertJ for a long time and it's great to have a chance to look at the underlying code and make changes. Thank you for making it easy to contribute.


fix(share_plus): #3322 Image preview on iOS downscale to avoid issues

Description
On iPhone 13, when sharing an image and the image is very large, the sharing box may occasionally fail to be awakened.
Related Issues

fix: #3322

Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I titled the PR using Conventional Commits.
[ ] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

Hello, thanks for the contribution.
I'd please ask you to follow the PR template: https://github.com/fluttercommunity/plus_plugins/blob/main/.github/PULL_REQUEST_TEMPLATE.md and fix the title.
As well, try to provide more context about this fix, ideally creating a bug report showcasing the issue, or showing before and after images, etc. otherwise it is very hard to understand what the purpose of the fix is.

Thanks for providing a ticket with a video recording! Can you show a recording of how it looks with the fix?

https://github.com/user-attachments/assets/568a816f-f2f3-49c1-b46e-2c26810fa1e4


InvalidByronCbor issue

I have a problem while running oura: with the recent version I see quite frequently the following warning:
2023-02-07T02:17:36.417671Z  WARN oura::utils: error crawling byron block for events: InvalidByronCbor

The processing still goes on, but it's weird behavior though, it wasn't like that before. Error is reproducible while syncing byron era blocks

hi @gostkin, have you tried version 1.8.1?
The error you described sounds like the exact issue we fixed on that patch.

was fixed in newer versions


Problem: CUDA out of memory

Hello, I get a problem when try to train the model. My GPU device is 3x2080Ti, but it still tell me "out of memory". How to modify the batch size or other measures that help me to solve this problem? Thanks a lot.
By the way, the samples_per_gpu is set to 1. Is it mean that that the batch size is 1?

batch size = samples_per_gpu * gpu number.
samples_per_gpu=1 means per gpu can process one image.
Sorry, we use V100 GPU for training, 2080Ti may not be enough. But you can modify the [config files(https://github.com/MengyangPu/EDTER/tree/main/configs/bsds) to reduce the parameters of the model.

Thank you for your reply. I will try to modify the model to make it fit to my gpus.
A great job. Hope you have a breakthrough in edge detection field~

Thanks~


Add validation tests for Private Registries and SSL LB

Add validation tests for private registries
Add validation tests for SSL LB

PR for this issue - https://github.com/rancher/validation-tests/pull/123


Adding boost-experimental te

te is a new type erasure library. It's header only.
https://github.com/boost-experimental/te
Could you add it to wandbox include path?

Added: https://wandbox.org/permlink/YmwJ1aGLCAklRHQz

Thank you!


Add all MAVLink STATUSTEXT severity enum values to StatusTextType

Closes #1025.

Now that it is auto-generated, it should be done here :wink:

@JonasVautherin sorry this completely slipped my mind, but here you go: https://github.com/mavlink/MAVSDK-Proto/pull/174. Once that's merged, I can update the implementation here if needed.

That's merged :wink:

@JonasVautherin just updated the telemetry_impl here. There was a bit of "collateral damage," since I just rebased the proto submodule to master (there was a commit in offboard.proto as well) and also generate_from_protos.sh changed a bit of formatting in the telemetry plugin directory. If you'd rather not have these in the merge, I'm happy to go cherry pick more carefully :smiley:

@JonasVautherin oh, that's what I was missing! Should be good now, I think :wink:

The example failing is because we updated MAVLink, so you can ignore that. However, the "proto check" is failing. Are you sure you committed all the changes coming from generate_from_protos.sh? :thinking:

@JonasVautherin I forgot to commit the changes to the offboard API, which isn't part of this PR but changed when I updated the proto submodule :smile: Fingers crossed it works this time!


Work on ConceptSet Class

add TimeWindows class
add class methods to grab elements
some minor folder restructuring
some minor function reorg

From this PR the following will work on a ConceptSetDefinition Line Item:
library(Capr)
cs1 <- list(
  't2d' = cs(descendants(201826), name = "t2d"),
  'ckd' = cs(descendants(46271022), name = "ckd")
)

hh <- createConceptSetLineItem(
  name = "Baseline Conditions",
  ordinal = 1,
  statistic = createPresence(),
  timeWindows = createTimeWindows(
    timeInterval(lb = -365, rb = -1),
    timeInterval(lb = 0, rb = 90)
  ),
  conceptSets = cs1,
  domain = "condition_occurrence"
)

hh$getTimeWindows()
hh$getConceptSets()
hh$getDomain()
hh$getDefinitionType()
hh$getStatisticType()

Additional Updates:

Convert ConceptSetDefinitionLineItem to singleton class. only accepts one ConceptSet and one TimeInterval
Update ConceptSet batch add to work with purrr
Update class methods with modifications to CS class
Start adding code for Demographics (Age, Concept, Year).....added class, ui, and sql


Update Cardiff Christmas visit slots

Unbookable - 2nd Dec, 14th Dec, 21st Dec, Christmas Day, Boxing Day, 6th Jan
Additional - 28th Dec 0945 and 1330, 1st Jan 1330

Unable to test on preprod - too far ahead.

Tested locally


SUBMARINE-446. Submarine server does not reconnect automatically to MySQL

What is this PR for?
Hi @jojochuang
This PR is going to solve the submarine server does not reconnect automatically to MySQL, I would appreciate that if you can help to review/manage it, thanks.
What type of PR is it?
[Bug Fix ]
Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-446
How should this be tested?
https://travis-ci.org/github/cchung100m/submarine/builds/666269006?utm_medium=notification&utm_source=github_status
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@liuxunorg can you help review?

LGTM


Drop vendor folder and enhance workflows

Drop vendor folder as its not really needed
Change some workflow names for easy identification
Signed-off-by: Itxaka<EMAIL_ADDRESS>

Unfortunately some changes are required to the tests in order to account that now the grub binaries have the full path.


Feat: Completed Implementation of role_store contract.

Summary
Implemented role_store and added corresponding tests.
Labels

[x] Feature

Issue Resolved
Resolves: #432
New Behavior
The new implementation mimics the behavior of the Solidity version but avoids using arrays in storage. Instead, role_members_count and roles_count track the total number of writes rather than the actual instance count. This is because deleting a <key, value> pair sets the value to zero() rather than removing it. To manage storage efficiently, the algorithm checks existing keys from 0 to the current storage count during insertion. If a zero() value is found, that key is reused; otherwise, a new key-value pair is created and the key count is incremented.
Breaking Changes
None.
Additional Info
N/A

Nice, could you just rename some test to follow our test naming rules
Like in the first test -> given_normal_conditions_when_revoke_role_then_works

renamed tests

Sorry I wasn't clear but the test you renamed was the one with good naming :)
Rename other tests following the same pattern (given_...)

Sorry I wasn't clear but the test you renamed was the one with good naming :)
Rename other tests following the same pattern (given_...)

done


i want to stream on multiple server through multiple URL. I need some Sample code. any one can help me

https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/549


[HOLD for payment 2024-04-05] App crashes trying to render QAB

Introduced in https://github.com/Expensify/App/pull/38669
cc @Gonals @marcaaron
Version Number: Tested on main@1b0fe6d2ee
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: me
Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1711407644753289 (Expensify internal)
Action Performed:
Break down in numbered steps

Create a new chat from one new user to another new user
App crashes

Expected Result:
App doesn't crash
Actual Result:
App crashes due to empty string being passed to translate()

There's also a proptypes warning which is likely due to the wrong type being passed from the API

Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

Hi @paultsimura, I'm new to working with contributors, so asked in Slack here (internal) to confirm the process. Thanks for your patience.

Assigned! Added @Christinadobrzyn yo handle payment

Payouts due:

[ ] Contributor+: $500 @paultsimura (Upwork offer - https://www.upwork.com/nx/wm/offer/101740503)

Upwork job is here
@paultsimura can you accept the upwork offer? Thanks!

Awesome! I paid this out based on this payment summary.
Closing this our since there's no regression test.


crypto/tls Config.VerifyPeerCertificate

I have a question about VerifyPeerCertificate func in tls.Config, which can be used for custom server certificate validation. As far as I can see, there is a lack of context to do so, because there is no way for this function to find out the DNS name of the host to verifiy it by certificate chain. During "standard" implementation this is done by using c.config.ServerName field as value for x509.VerifyOptions.DNSName, but there is now way to do the same in the custom VerifyPeerCertificate function. Of course, this function can be used as additional verification step, but as far as I understand, it should be possible to use it as the only verification one (by specifying InsecureSkipVerify: true).
It seems to me that there must be an additional parameter in this function.
What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
linux amd64

What you would usually do here is define a closure that accesses context from the scope where you are defining the Config.
That is, you would define an anonymous function inline where you create the Config, and use variables that are available there.

If you have more questions, please see https://golang.org/wiki/Questions

Thank you for reply and for link.
But client config can't always know what server will be used, consider http.Transport f.e. You can specify tls.Config for it without knowing, what servers will be used in http transactions later.

It's not possible to change the function signature due to the compatibility promise.
For a client, you'd want to provide a function in the DialTLS field of the http.Transport struct.

It's actually sad such a PR was accepted in the first place @VerifyPeerCertificate. But I understand the compatibility promise.
The following snippet is a sample implementation of DialTLS which then uses a closure for VerifyPeerCertificate as you suggested. @titanous
It could have been easier if Transport would break up its dialConn method into smaller chunks that are publicly callable so that you don't find yourself re-implementing most of the code.
It gets even worse if you need proxies (this code is also in dialConn)
func verifyPeerCerts(serverName string, rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error {
	// some dummy code to check all certs available (not very useful and indeed a security issue if
	// InsecureSkipVerify is set to true and the server supplies arbitrary certs)
	for i := 0; i < len(rawCerts); i++ {
		cert, err := x509.ParseCertificate(rawCerts[i])

		if err != nil {
			fmt.Println("Error: ", err)
			continue
		}

		hash := sha1.Sum(rawCerts[i])
		fmt.Printf("Fingerprint: %x\n\n", hash)

		fmt.Println(hash, cert.DNSNames, cert.Subject, cert.VerifyHostname(serverName))
	}
	return nil
}

func tlsHost(targetAddr string) string {
	if strings.LastIndex(targetAddr, ":") > strings.LastIndex(targetAddr, "]") {
		targetAddr = targetAddr[:strings.LastIndex(targetAddr, ":")]
	}
	return targetAddr
}

func main() {
	link := "https://<IP_ADDRESS>:443/"

	tr := &http.Transport{
		DialTLS: func(network, addr string) (net.Conn, error) {
			dialer := &net.Dialer{
				Timeout:   30 * time.Second,
				KeepAlive: 30 * time.Second,
				DualStack: true,
			}

			conn, err := tls.DialWithDialer(dialer, network, addr, &tls.Config{
				InsecureSkipVerify: true,
				ServerName: addr,
				VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error {
					return verifyPeerCerts(tlsHost(addr), rawCerts, verifiedChains)
				},
			})
			if err != nil {
				return conn, err
			}
			return conn, nil
		},

	}
	client := &http.Client{Transport: tr}
	response, err := client.Get(link)

	if err != nil {
		panic(err)
	}

	defer response.Body.Close()
}


PDCL-5747: Fix broken pathways for mobile scaffold files

Description
Fixes the ability to use the scaffold tool to make mobile extensions. Resolves #17 .
Related Issue
https://jira.corp.adobe.com/browse/PDCL-5747
Motivation and Context
#15 introduced separated module files for web and edge, but didn't provide those renamed files for mobile.
How Has This Been Tested?
manual verification of mobile portion.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@dompuiu Mobile doesn't ask for view prompts? . It's been that way for a while, but I figured I would ask.


[Bug Report] Table fixed column misalignment when column changed

Element UI version
2.15.6
OS/Browsers version
chrome
Vue version
2.6.14
Reproduction Link
https://codepen.io/litozheng/pen/powZXRY
Steps to reproduce
1 set column fixed
2 change column
3 column misalignment
What is Expected?
1
What is actually happening?
column misalignment

this.$nextTick(() => this.$refs.table.doLayout()) can temporary solve this issue.

doLayout() works sometimes, but this issue is still there in element-ui v2.15.14. Is there any other fix?


4 json and json ld documentation

Fixes issue #4: Added JSON, JSON-LD, and JSON-LD @context handle documentation to JSON documentation READ ME file.

Added

Thank you for working on this @haydenkarl22. The documentation you have generated is really good. You made it very clear and easy to understand. Great idea to include more resources at the end.
Here are few suggestions that could help us :

A website called json-ld playground that helps users understand how they work by comparing with the expanded form. If you think new users can benefit from that feel free to include it along with other resources.
Also I think it would be easier for users to navigate to pages if you could make the actual external resource links as hyperlinks.

I've considered the suggestions, and I agree they are good ideas, so I added them to the markdown document. The JSON-LD playground webpage is a link in the documentation, and all the links are now hyperlinks. I've also added padding to the text to make it easier to digest. This issue is ready for final review.


Set-CsTenantDialplan with pre created Regular Expressions for New normaliazion rules fails

Hi there,
hopefully someone can shed some light into this. We are using a Script to prepare a new Teams Phone system location. All of this script has been working prior the Teams Powershell module update to version 4.0.0 and later. Before the update, we were using version 2.0.0. Currently we`re using the latest 4.5.0 version. After spending hours of investigation so far, I was able to narrow it down to the regular expressions which are created before we use them in the New-CsVoiceNormalizationRule CMDlet, but was not able to solve the issue.
Here are the lines that have been working before the update of the Teams PS module:

$Dialplan="DE-Test-621789"
$DialplanSimpleName="DE-Test"
$regexInternational = New-CsVoiceRegex -StartsWith '00' -AtLeastLength 6 -DigitsToStrip 2 -DigitsToPrepend '+'
$NR2=New-CsVoiceNormalizationRule -Parent $Dialplan -Name "$DialplanSimpleName-International" -Pattern $regexInternational.Pattern -Translation $regexInternational.Translation -InMemory
Set-CsTenantDialPlan -Identity $Dialplan -NormalizationRules @{Add=$NR2}

There is no error when creating the RegEx or the Voice Normalization Rule. Even when reviewing the content of the variables $regexInternational and $NR2, it looks good.
The error which is given is this:
Set-CsTenantDialPlan : NormalizationRules has data of type Microsoft.Rtc.Management.WritableConfig.Policy.Voice.NormalizationRule that is not supported
Parameter name: NormalizationRules
On the other side, if I replace the Pattern and the Translation variables in the New-CsVoiceNormalizationRule command with the actual values which are configured in the New-CsVoiceRegex, it`s working.
The syntax of the above mentioned commands is in accordance to https://docs.microsoft.com/en-us/powershell/module/skype/new-csvoiceregex?view=skype-ps and https://docs.microsoft.com/en-us/powershell/module/skype/new-csvoicenormalizationrule?view=skype-ps
Any help is highly appreciated.
Thanks and regards
Thomas

I never used New-CsVoiceRegex.
It looks like New-CsVoiceRegex is from on-premises SkypeForBusiness powershell module, and it is not present in MicrosoftTeams powershell module. On the other hand, New-CsVoiceNormalizationRule is present in both modules.
I guess when you try using these commands together in a single session, it is using the wrong version of the commandlet.
Due to such issues caused by overlapping commands, for Teams configuration purposes I prefer to use a separate PC where only Teams module is installed. That's the most straightforward and guaranteed way not to get confused.
In your case, you should be able to fix the issue by explicitly specify the module, e.g.:
$NR2=MicrosoftTeams\New-CsVoiceNormalizationRule -Parent $Dialplan -Name "$DialplanSimpleName-International" -Pattern $regexInternational.Pattern -Translation $regexInternational.Translation -InMemory (notice MicrosoftTeams\ prefix).
Alternatively, you can try to explicitly convert params to text in a hope that it will help:
$NR2=New-CsVoiceNormalizationRule -Parent $Dialplan -Name "$DialplanSimpleName-International" -Pattern $regexInternational.Pattern.ToString() -Translation $regexInternational.Translation.ToString() -InMemory

Thanks for your answer @shivtorov
Adding "MicrosoftTeams" in front of the New-CsVoiceNormalizationRule doesn`t work, as the CMDlet itself is already for Teams/SfBO, because you can "tab" the command which will bring up a "SkypeForBusiness\New-CsVoiceNormalizationRule".
As in my posted link to the NewCsVoiceRegex CMDlet was also the category "Skype for Business Online" I was quite sure, that this also is valid for Teams Powershell. And as mentioned, the whole script has been working with Teams Powershell module v.2.0.0 and has stopped working with v. 4.0.0 and above.
BUT...you maybe brought me into the right direction. After doing a little more research, I saw, that there is a CMDlet "New-CsTeamsTranslationRule" https://docs.microsoft.com/en-us/powershell/module/skype/new-csteamstranslationrule?view=skype-ps which basically does the same as the New-CsVoiceRegEx. You have to provide the already created Regular Expression to this command instead of providing information like "-StartsWith" or "-AtLeastLength"with the New-CsVoiceRegex.
I will look deeper into this tomorrow.
Regards
Thomas

@ThomHauff New-CsTeamsTranslationRule is used for trunk normalization rules for SBC's (OnlinePstnGateway). My recommendation is that you use New-CsVoiceNormalizationRule. I normally use one of the RegEx tester sites on the Internet to generate & validate the RegEx.

@ThomHauff
You are overcomplicating things by trying to use a helper function New-CsVoiceRegex from SkypeForBusiness module in your script written for MicrosoftTeams module. Thus, you hit this compatibility issue.
Run the following to see same-name cmdlets that are likely the cause of the error you descripted:
Import-Module -Name SkypeForBusiness,MicrosoftTeams
Get-Command -Name New-CsVoiceRegex,New-CsVoiceNormalizationRule,New-CsTenantDialPlan -Module SkypeForBusiness,MicrosoftTeams | sort Source,Name

So, when you use New-CsVoiceRegex it implicitly imports SkypeForBusiness module.
But if drop this cmdlet from your script, then it will not load SkypeForBusiness module, thus only use MicrosoftTeams module.
You already have a fix for the issue - you described it in the initial post.
Are you simply interested in why your script was working with MicrosoftTeams module v.2.x.x, but fails with MicrosoftTeams module v.4.x.x? Well, when a module changes its major version, it is likely due to breaking changes in its implementation. It is expected that some scripts might be broken after such module upgrade.

@JensTrier Thanks for your answer.
We already use the New-CsVoiceNormalizationRule. But as you say, you`re using a Regex tester to generate and test your rules. Our script is designed to automate the creation process of a new voice location and to automatically generate all the RegEx expressions based on the provided input information at the beginning of the script from the user who executes it. For this purpose the New-CsRegEx was perfect for us and has been working until the Teams Powershell module was updated.
For each of our dialplans we use 5 different normalization rules, so generating the RegEx manually everytime with external tools is not an option for us.
I did a quick test with the New-CsTeamsTranslationRule and added it the same way to the New-CsVoiceNormalizationRule like I did in the past with the New-CsVoiceRegEx. That worked.

@shivtorov
I understand what you mean. The fix I mentioned in the initial post was only by adding the plain regular expression to the New-CsVoiceNormalizationRule command, but as stated in my comment to @JensTrier that is not an option.
Im totally aware that commands may change with major upgrades of the Teams module. Im reviewing the changes to the module on a regular basis in this article https://docs.microsoft.com/en-us/microsoftteams/teams-powershell-release-notes?WT.mc_id=M365-MVP-9501
Now that I know, that the New-CsRegEx is explicitly for SfB, the simple question is if I can replace the New-CsRegEx with New-CsTeamsTranslationRule in our script, as it`s working with this :)

@ThomHauff My strong recommendation is not to mix these two cmdlets. VoiceNormalizationRule is intended to be used with TenantDialPlan.

@JensTrier which 2 CMDlet would you not mix?
I also have opened a ticket with MS and will get a call back at 10AM. Will provide feedback afterwards.

@ThomHauff What I mean was only use VoiceNormalizationRule with TenantDialPlan and use TeamsTranslationRule with OnlinePstnGateway. I'll update the docs to make this clear.

@JensTrier I just had the call with the MS engineer and she doublechecked with her technical team lead and confirmed afterwards, that the New-CsTeamsTranslationRule can be used as the replacement for the New-CsVoiceRegEx.

I modified the script now with using the -NewCsTeamsTranslationRule instead of New-CsVoiceRegEx, tested and everything is working again as expected.
Thanks everybody for answering and sharing thoughts


rofi-blezz: Init Package and Maintainer

Description of changes
Adds rofi-blezz
Things done
Tested on sway and i3

Built on platform(s)

[ X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ X] Fits CONTRIBUTING.md.

What's missing for this to get merged? Just the squash?

The title should be changed to rofi-blezz: init at unstable-2022-09-07. The all the commits except the maintainers: add johnjohnstoneshould also be squashed into a commit titledrofi-blezz: init at unstable-2022-09-07`. The package should also be moved into the by-name standard, https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md.

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

To squash your commits you can type git rebase -i 2903f85, this will open up your editor with a collection of your last serval commits. Leave the commit titled rofi-blezz: Init at unstable-2022-09-07 as pick rofi-blezz: Init at unstable-2022-09-07 whilst changing the other commits to say s commit-name. Then you will have to force push to this branch git push -f.

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

To squash your commits you can type git rebase -i 2903f85, this will open up your editor with a collection of your last serval commits. Leave the commit titled rofi-blezz: Init at unstable-2022-09-07 as pick rofi-blezz: Init at unstable-2022-09-07 whilst changing the other commits to say s commit-name. Then you will have to force push to this branch git push -f.

Thank You, Commit History should be fixed now.


Add authorisation policy to mapped APIs

Follow up of #86: add the policy name.

It's done, not sure why I didn't close the issue.


Midas open

Resolves ob_date vs ob_end_date issue in https://github.com/opencdms/opencdms-test-data/pull/17#issuecomment-929784662