Improve file type checking

Currently we employ a combination of file suffix checking and metadata analysis to determine whether we can or cannot redact an image. We do this while building redaction plans for images, and throw exceptions when we come across files we cannot redact. This leads to defensive exception handling that is starting to get unwieldy.
Perhaps a better solution would be to check all of the files prior to redaction, and keep track of which files we can and can't redact.
We could use magic numbers  instead of file suffixes, in conjunction with checking for certain metadata tags/values to determing Aperio/Philips/ImageJ files.

If we are only handling tiff files, checking the first four bytes for any of four variations (more than in the linked article since it has to include the bigtiff variants) is sufficient.
I'd advocate for the python-magic library, but I don't think it has a binary wheel, so we'd have to pull in libmagic ourselves, which is a pain in windows.

Closing this particular instance of this issue. We've started to check file signatures to differentiate between tiff and dicom images.


Utility to Confirm fhir-server-config.json and other configuration elements

Is your feature request related to a problem? Please describe.
Utility to Confirm fhir-server-config.json and other configuration elements
This utility should also verify the bulkdata configuration and datasource configuration.
Describe the solution you'd like
Having a utility to verify can deflect many must gather and error situations.
Describe alternatives you've considered
n/a
Acceptance Criteria
At least one acceptance criteria is included.

GIVEN a fhir-server-config.json correct
WHEN execute the tool
THEN the configuration tool passes

GIVEN a fhir-server-config.json invalid
WHEN execute the tool
THEN the configuration tool passes
Additional context
We don't think it needs to validate EVERY config, but this task should result in a framework for verifying config properties and an implementation for "the most egregioius" areas of the config.

Consider allowing the configuration to be made static and provided by dependency injection at startup. Also, just after it has been read, the configuration could be validated to make sure that:

datasources are not shared by multiple tenants
when offloading, each tenant/datasource must have its own target blob account/container.
etc...


update mui

issues
https://github.com/unitedhubs/material-ui-form/issues/52

Codecov Report

Merging #54 into dev will increase coverage by 1.59%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##              dev      #54      +/-   ##
==========================================
+ Coverage   62.68%   64.28%   +1.59%
==========================================
  Files          16       16
  Lines         335      336       +1
  Branches       96       96
==========================================
+ Hits          210      216       +6
+ Misses         91       88       -3
+ Partials       34       32       -2

Impacted Files
Coverage Δ

src/components/FormControlLabelClone.js
100% <ø> (ø)
:arrow_up:

src/components/CheckableFieldClone.js
100% <ø> (ø)
:arrow_up:

src/components/FormControlClone.js
62.22% <ø> (ø)
:arrow_up:

src/components/FieldClone.js
97.67% <75%> (+6.97%)
:arrow_up:

src/components/Form.js
35% <80%> (+1.9%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae6cd0...b14c7d1. Read the comment docs.


Include CodeReview Room as possible  Feedback area

Right now the only "official" way to get feedback on a project is to tweet it out.  This won't scale.  We should encourage campers too use the CodeReview Room.
Should be included in the Zipline into and getting set sections.  Elsewhere?

I agree there should totally be something like that even if it just a 'Hey we're here to help too' kind of thing.


Serialize xpubs using the user-provided version bytes

Due to the way ypubs/zpubs are handled to make them compatible with rust-bitcoin, their original version bytes information is lost, making them always serialize with BIP32's original version bytes and not with SLIP132's (i.e. as xpub... rather than ypub... or zpub...).
This effects the way xpubs are shown on console and in the hd wallets api, but works apart from that.
This could be fixed either by adding ypub/zpub support to rust-bitcoin (not sure if that's likely to happen), or by writing some custom serialization code to inject the original version bytes back in.

No longer relevant with the recently implemented descriptor-based tracking. bwt now only returns xpubs contained in descriptors, which must be encoded as standard BIP 32 xpubs.


Wrong "Ninja" generator selected when I select "Visual Studio Community 2019 Release - amd64"

Brief Issue Summary
When I select "Visual Studio Community 2019 Release - amd64" as Kit, vscode-cmake-tools switch to the "Ninja" CMake generator instead of "Visual Studio 16 2019" with platform "x64".
Expected:

F1 -> CMake: Select a Kit -> Visual Studio Community 2019 Release - amd64
Output should display:

Switching to kit: Visual Studio Community 2019 Release - amd64
Configuring using the "Visual Studio 16 2019" CMake generator with platform "x64" and toolset {}

F1 -> CMake: Configure
Build solution should be a visual studio solution for VS 2019

Apparent Behavior:

F1 -> CMake: Select a Kit -> Visual Studio Community 2019 Release - amd64
Output displays:

Switching to kit: Visual Studio Community 2019 Release - amd64
Configuring using the "Ninja" CMake generator

F1 -> CMake: Configure
Build solution is a ninja solution targetting VS2019 compiler

CMake Tools Log

When selecting kit:
[driver] Switching to kit: Visual Studio Community 2019 Release - amd64
[cms-client] Configuring using the "Ninja" CMake generator

When configuring:
[main] Configuring folder: LightPathExpressions-git
[cms-client] Configuring using the "Ninja" CMake generator
[cmake] The C compiler identification is MSVC 19.23.28106.4
[cmake] The CXX compiler identification is MSVC 19.23.28106.4
[cmake] Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe
[cmake] Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe -- works
[cmake] Detecting C compiler ABI info
[cmake] Detecting C compiler ABI info - done
[cmake] Detecting C compile features
[cmake] Detecting C compile features - done
[cmake] Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe
[cmake] Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe -- works
[cmake] Detecting CXX compiler ABI info
[cmake] Detecting CXX compiler ABI info - done
[cmake] Detecting CXX compile features
[cmake] Detecting CXX compile features - done
[cmake] Configuring done
[cmake] CMake Deprecation Warning:
[cmake]   The 'cmake-server(7)' is deprecated.  Please port clients to use the
[cmake]   'cmake-file-api(7)' instead.
[cmake]
[cmake]
[cmake] Generating done

Platform and Versions

Operating System: Windows 10 1903 64bits
CMake Version: 3.16.5
VSCode Version: 1.43.0
CMake Tools Extension Version: 1.3.1
Compiler/Toolchain: Visual C++ 2019

Other Notes/Information

As a side note: everything is fine with Visual Studio 2017, the solution generated is correct. What is strange is that my cmake-tools-kits.json seems correct, VS 2017 and VS 2019 entries are similar:
{
    "name": "Visual Studio Community 2017 Release - amd64",
    "visualStudio": "05246a08",
    "visualStudioArchitecture": "amd64",
    "preferredGenerator": {
      "name": "Visual Studio 15 2017",
      "platform": "x64"
    }
 }

{
    "name": "Visual Studio Community 2019 Release - amd64",
    "visualStudio": "da769ae6",
    "visualStudioArchitecture": "amd64",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "x64"
    }
}

So I don't understand what vscode-cmake-tools is doing on top of the configuration of kits that could lead it to generate a Ninja solution instead of a VS2019 one.

Thank you for reporting this issue.  It is currently being tracked by #1084.

Gosh, I was the one reporting the previous issue #1084 Totally forgotten -_-' I probably need some sleep.
Sorry for my own duplicate and thank you for your work.


No constructor found with matching signature.

appendClasspath(CTILL_SCALE_JAR_PATH);

const guard = stdout.enableRedirect(
  (_, data) => {
    console.log('Stdout:', data);
  },
  (_, data) => {
    console.error('Stderr:', data);
  }
);

const System = importClass('java.lang.System');
System.out.println('|Hello world');
const JLong = importClass('java.lang.Long');
const JString = importClass('java.lang.String');
const JCTillScale = importClass('cz.prins.scale.CTillScale');
const liveSleep = new JLong(12000);
System.out.println(liveSleep.getClassSync());
this.scale = new JCTillScale(liveSleep);

Hello,
I have a code that calls my Java library (cz.prins.scale.CTillScale), that has a constructor that has signature cz.prins.scale.CTillScale(java.lang.Long), but when I pass a java.lang.Long argument it throws Unhandled Exception Error: No constructor found with matching signature. . I attached code example and console log with errors. I'm using openjdk <IP_ADDRESS>, node.js 16 and the latest version of your library. Could you please help me?
Thank you

This may be related to node.js truncating some arguments for some reason, I'll look into it, but as I don't have a lot of time right now, this may take a while so just be patient :)

Didn't quite find the issue you described, but found something which should be close enough...
This test case should represent your code somewhat
Anyways, will create a new beta release for you to test the fix in the next days, I'll inform you once this is the case

Thank you!

Should be fixed in the latest beta release v2.1.6-beta.1.
Please provide feedback if this is working, so I can create a proper release

Unfortunately I still get the same error on v2.1.6-beta.1 release as before. I have tried different Node versions (16, 18 and 19), but it still doesn't work.

Ok, so the thing actually not working is passing java objects for (somewhat) primitives to any method. Ill fix this in the following days, in the meanwhile, you can just pass primitive javascript types, those will be converted automatically to java types, no need to specify the java class required:
appendClasspath(CTILL_SCALE_JAR_PATH);

const guard = stdout.enableRedirect(
  (_, data) => {
    console.log('Stdout:', data);
  },
  (_, data) => {
    console.error('Stderr:', data);
  }
);

const System = importClass('java.lang.System');
System.out.println('|Hello world');
const JCTillScale = importClass('cz.prins.scale.CTillScale');

// 'BigInt' is converted to any long type.
// 'number' can be converted to int, float, double and long though
const liveSleep = 12000n;
this.scale = new JCTillScale(liveSleep);

The newest beta release v2.1.6-beta.2 should fix your problem

Thank you! Seems like it's finally working.


Backends not connected to Load balancer

Hi.
I created an OCI native ingress controller following the example in the documentation. The load balancer is created (I can see it in the OCI console) ,but the backend does not connect: error critical-connection failed.

HI @Loobosh, Are the backend sets created as per your ingress declaration? Are the backend status reported healthy? Have you set the required network policies between LB and worker subnets?


Remove task from internal stores

Irmin's store interface requires passing a task to every store. However, most stores don't need this for anything. This branch removes them from most places. The BC interface is unchanged, so users of the public interface should be unaffected.
Backend providers no longer deal with tasks at all.
Apart from simplifying the code, this change is necessary for adding a separate repository type. This will allow connecting to a database once and then reusing that state for multiple branches. This isn't possible if the backend stores must be recreated for each new commit message.
Notes:

We might still want to change the BC interface, but I think this branch can be merged without that, as it is useful on its own.

It is now explicit which operations create commits. In particular, the API now makes it clear that lcas doesn't change anything, while lca requires a task because it may create commits.

HISTORY.Store was previously a Contents.STORE. Now, contents can be merged without a task, but merging commits needs one, so they cannot share the same interface. I have made a new one to hold the new HISTORY.Store.merge function. However, this function appears to be unused.

View.task is gone (it never did anything).

View.create is gone (it ignored both its arguments and called View.empty).

There were plans for an auditing API using the tasks. I think this can be achieved in other ways; for the discussion, see http://lists.xenproject.org/archives/html/mirageos-devel/2015-10/msg00006.html

Thanks!


the training code

Hi, thanks for your excellent jobs of restoration of multiple distortions .Have you finished the training code ? Thank you very much

Hello, thank you for your interest in our work, and sorry for the late reply.
I have been fully occupied for my PhD thesis and its defense in the last few months...
I will prepare the training code and upload it soon.


too many pipe and eventpoll files

Bug Report
What did you do?
Just run lsof and find too many pipe and eventpoll files.
What did you expect to see?
Few pipe or eventpoll files.
What did you see instead?
snap-send<PHONE_NUMBER>84       qupeng  112w     FIFO                0,9       0t0  128610450 pipe
snap-send<PHONE_NUMBER>84       qupeng  113u  a_inode               0,10         0       8838 [eventpoll]
snap-send<PHONE_NUMBER>84       qupeng  114r     FIFO                0,9       0t0  128610451 pipe
snap-send<PHONE_NUMBER>84       qupeng  115w     FIFO                0,9       0t0  128610451 pipe
snap-send<PHONE_NUMBER>84       qupeng  116u  a_inode               0,10         0       8838 [eventpoll]
snap-send<PHONE_NUMBER>84       qupeng  117r     FIFO                0,9       0t0  128610452 pipe
snap-send<PHONE_NUMBER>84       qupeng  118w     FIFO                0,9       0t0  128610452 pipe
snap-send<PHONE_NUMBER>84       qupeng  119u  a_inode               0,10         0       8838 [eventpoll]
snap-send<PHONE_NUMBER>84       qupeng  120r     FIFO                0,9       0t0  128610453 pipe
snap-send<PHONE_NUMBER>84       qupeng  121w     FIFO                0,9       0t0  128610453 pipe
snap-send<PHONE_NUMBER>84       qupeng  122u  a_inode               0,10         0       8838 [eventpoll]
snap-send<PHONE_NUMBER>84       qupeng  123r     FIFO                0,9       0t0  128610454 pipe
snap-send<PHONE_NUMBER>84       qupeng  124w     FIFO                0,9       0t0  128610454 pipe
snap-send<PHONE_NUMBER>84       qupeng  125u  a_inode               0,10         0       8838 [eventpoll]

➜  [30.31] /data2 sudo lsof | grep 109112 | grep eventpoll | wc -l
9680
➜  [30.31] /data2 sudo lsof | grep 109112 | grep pipe | wc -l
15488

I guess there must be something wrong for these open files, we should investigate which parts open so many files.

Btw, seem master and 2.1 both have this problem. A user gave me his result for 2.1 version.
lsof | grep pipe | wc -l
5527

This is related to #4219. The problem exists after a854feee9f4a503d127fe5db95ae7c40cea93c74 and make local tests fail with too many open files error. I believe it has something to do with resource reclaim in gRPC service, but not have time to investigate further yet.

Although the commit doesn't appears in v2.1. I'm not sure whether 5527 is a reasonable number, but a854feee9f4a503d127fe5db95ae7c40cea93c74 makes it worse definitely.

I use systemtap to trace pipe open
sudo stap -d /data3/tangliu/tikv/bin/tikv-server -d /usr/lib64/libc-2.17.so -e 'probe syscall.pipe {printf("%s %d\n",  execname(), tid()); print_usyms(ubacktrace()); }'

The result is below:
 0x7f835cbb3737 : pipe2+0x7/0x30 [/usr/lib64/libc-2.17.so]
 0x561115b0303b : _ZN13tokio_reactor7Reactor3new17he6f6bc748cc1e5d5E+0x30b/0x1250 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115af5cfd : _ZN5tokio7runtime10threadpool7builder7Builder5build17hd0a793b87067dea0E+0x9d/0x10f0 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115af8ef7 : _ZN5tokio7runtime10threadpool7Runtime3new17hf9c2b64f37c4f6abE+0x27/0x100 [/data3/tangliu/tikv/bin/tikv-server]
 0x5611150cfe96 : _ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17hd1f862cfcb6cde7cE+0x666/0x6840 [/data3/tangliu/tikv/bin/tikv-server]
 0x5611151f60d9 : _ZN50_$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$8call_box17h32c8d89b0de8d146E+0x89/0x250 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115bbb26e : _ZN3std3sys4unix6thread6Thread3new12thread_start17h809dab03f76374f4E+0x8e/0x120 [/data3/tangliu/tikv/bin/tikv-server]
 0x7f835d7c1dd5 : 0x7f835d7c1dd5 [/usr/lib64/libpthread-2.17.so+0x7dd5/0x21c000]
pd-worker 29167
 0x7f835cbb3737 : pipe2+0x7/0x30 [/usr/lib64/libc-2.17.so]
 0x561115b0303b : _ZN13tokio_reactor7Reactor3new17he6f6bc748cc1e5d5E+0x30b/0x1250 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115af5cfd : _ZN5tokio7runtime10threadpool7builder7Builder5build17hd0a793b87067dea0E+0x9d/0x10f0 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115af8ef7 : _ZN5tokio7runtime10threadpool7Runtime3new17hf9c2b64f37c4f6abE+0x27/0x100 [/data3/tangliu/tikv/bin/tikv-server]
 0x5611150cfe96 : _ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17hd1f862cfcb6cde7cE+0x666/0x6840 [/data3/tangliu/tikv/bin/tikv-server]
 0x5611151f60d9 : _ZN50_$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$8call_box17h32c8d89b0de8d146E+0x89/0x250 [/data3/tangliu/tikv/bin/tikv-server]
 0x561115bbb26e : _ZN3std3sys4unix6thread6Thread3new12thread_start17h809dab03f76374f4E+0x8e/0x120 [/data3/tangliu/tikv/bin/tikv-server]
 0x7f835d7c1dd5 : 0x7f835d7c1dd5 [/usr/lib64/libpthread-2.17.so+0x7dd5/0x21c000]

Seem that all the pipes are created in tokio, so I have to assume that the this problem is caused by tokio. Seem we need to check whether others have the same problem or the tokio has already fixed it.
/cc @brson @nrc

Seems lsof | grep <pid> will print one fd multi times, depends on how many tasks in the process. Here is a part of my result:
tikv-serv 130642              qupeng  cwd       DIR                8,2     69632    4594797 /home/qupeng/var-lib/local
slogger<PHONE_NUMBER>43       qupeng  cwd       DIR                8,2     69632    4594797 /home/qupeng/var-lib/local
default-e<PHONE_NUMBER>45       qupeng  cwd       DIR                8,2     69632    4594797 /home/qupeng/var-lib/local
grpc_glob<PHONE_NUMBER>47       qupeng  cwd       DIR                8,2     69632    4594797 /home/qupeng/var-lib/local

As you can see, the work dir appears many times in the output, and their task-ids are different. And the whole result has 35378 lines.
However lsof -p <pid> only prints 202 lines. And after grep pipe it has 88 lines, and 53 lines for eventpoll.

And I guess pipes opened in tokio threads is for Timers, because mio also implement timer with pipes.

I investigate this problem and may make progress. All the threads share the same file descriptor table, using strace we can see that the thread created with CLONE_FILES flag, see http://man7.org/linux/man-pages/man2/clone.2.html
So even lsof shows too many pipe files but in fact, we only open a little.
But another problem is that, I use sudo stap -d /data3/tangliu/tikv/bin/tikv-server -d /usr/lib64/libc-2.17.so -e 'probe syscall.pipe {printf("%s %d\n",  execname(), tid()); }',  start TiKV then find pd-worker still opens many pipes, we must investigate why  @BusyJay @hicqu
tikv-server 68964
tikv-server 68964
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
tikv-server 68964
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120
pd-worker 69120

I write a simple example to verify my thought:
# include <unistd.h>
# include <stdlib.h>
# include <stdio.h>
# include <pthread.h>

static void* thread_start(void *arg) {
    printf("input a word in thread\n");
    getchar();
    return 0;
}

int main(int argc, char **argv)
{
  int filefd[2];
  char buf[7];
  int i;

  if(pipe(filefd)==-1)
    {
      perror("Error creating a pipe: ");
      exit(1);
    }

  printf("input a word\n");
  getchar();

  pthread_t thread_id;
  pthread_create(&thread_id, NULL, thread_start, NULL);
  pthread_join(thread_id, NULL);

  return 0;
}

The output is
➜  [30.35] tools lsof | grep 69241 | grep pipe
a.out      69241        pingcap    3r     FIFO                0,9       0t0 246988346 pipe
a.out      69241        pingcap    4w     FIFO                0,9       0t0 246988346 pipe
➜  [30.35] tools lsof | grep 69241 | grep pipe
a.out      69241        pingcap    3r     FIFO                0,9       0t0 246988346 pipe
a.out      69241        pingcap    4w     FIFO                0,9       0t0 246988346 pipe
a.out      69241  69269 pingcap    3r     FIFO                0,9       0t0 246988346 pipe
a.out      69241  69269 pingcap    4w     FIFO                0,9       0t0 246988346 pipe

So I think lsof sometimes may confuse us. :sob:

another thing I find is that there are two pd-worker threads:
➜  [30.35] ~ ps -T -p 72353 | grep 72509
 72353  72509 pts/2    00:00:00 pd-worker
➜  [30.35] ~ ps -T -p 72353 | grep pd-worker
 72353  72509 pts/2    00:00:00 pd-worker
 72353  72526 pts/2    00:00:00 pd-worker

And through systemtap, I find all the pipe are created by the thread 72509
tikv-server 72353
tikv-server 72353
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
pd-worker 72509
tikv-server 72353

I guess the first thread is real the pd-worker, but the second one may be created from pd-worker. We should investigate too.
@hicqu


iOS release mode issue

Hi Team.
I am facing 1 issue while integrating the did kit library in flutter.
When I am running on device locally by connecting cable with my mac in debug mode, I am able to get the did key generated. However, when I am archiving it and uploading on the Testflight, did key is not getting generated.
Can you please let me know where could be the issue? Is there any issue already reported.
Thank you
Rohit

@prorohit this appears to be a duplicate of #276. Is there a different issue you are facing?


ObjectHandler: compare generation instead of resource version

Please provide a description of this PR:
Generation increases only when spec is updated, while resource version changes whenever the object is updated, including status/label/annotation updates
Now the FilteredObjectSpecHandler is only used for configmaps and namespaces, but I think it could/would be used in more places

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

integ-ambient_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-ambient

integ-telemetry_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

integ-ambient_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-ambient

integ-telemetry_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

integ-ambient_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-ambient

integ-telemetry_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

integ-ambient_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-ambient

integ-telemetry_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry-mc

integ-security_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests-arm64

unit-tests_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test unit-tests

integ-ambient_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-ambient

integ-telemetry_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-telemetry-mc

integ-security_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-security

integ-security-multicluster_istio
5b61b159104ebf1785c9c669a2554e7e14bbf2c6
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is the only place using the "global" informer for config maps
There are 2 other places watching config maps, where they use seperate informers. So this PR does not impact them
https://github.com/istio/istio/blob/659eab911e9f507367b9e6aee24011dd244c21dc/pilot/pkg/status/distribution/state.go#L104
https://github.com/istio/istio/blob/659eab911e9f507367b9e6aee24011dd244c21dc/pkg/kube/watcher/configmapwatcher/configmapwatcher.go#L62

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
de15d592b2c0bd823ea30eb82e78f2684a63ce08
link
unknown
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add support for Python 3.12

Blocked on: https://github.com/MagicStack/uvloop/issues/567.
vmklib is ready: https://github.com/vkottler/vmklib/pull/80.

WIP on this PR: https://github.com/vkottler/vcorelib/pull/129.

we could also add an interpreter version constraint to this potentially

New issue now: https://github.com/MagicStack/uvloop/issues/575, can work around it though.

This is merged.


remove tarball and dependent code.

Issues:
Fixes #40
Problem: The tar file in this repo had to be manually generated.
Analysis: Changing a few bits of the patch script removes the
need for this tar ball.
Tests: I tested by listing the contents of a mounted bigip 12.1.x
image during the patch process and verifying that the expected/
necessary files were indeed present in the image.
I then launched the image with tlc, in openstack.  The image booted, licensed and provided a GUI.

@zancas: I'd like to get this change in, could you address the code review comments when you have a chance?


[CodeComplete] Fix issue with completion in string literal as last token in case stmt

The last token in a case stmt can be a string literal token, which can contain its interpolation segments. If one of these interpolation segments is the reference point, we'd return false from isReferencePointInRange because the string literal token's start location is before the interpolation token. To fix this, adjust the range we are checking to range until the end of the string interpolation token.
I chose to adjust the range for the brace statements only if the statement is implicit to avoid setting up the lexer to retrieve the token’s end location unless necessary.
Fixes rdar://76330416 [SR-14455]

@swift-ci Please test


Let Administrate figure out the associations

Following https://github.com/thoughtbot/administrate/pull/1633, this PR would bring this plugin to take advantage of Administrate's own association detection, doing away with the :class_name option.
Notes:

The Gemfile has been altered for now, so that this runs against Administrate master. This can be removed when the relevant changes have been published as a gem.
If accepted as is (minus the Gemfile change), this won't work with earlier versions of Administrate. Is this an acceptable tradeoff or should I try make it more broadly compatible?

Uh, CircleCI doesn't appear to be using Administrate master? Hm, not a big issue for now I guess.

Is the CI problem because of Appraisal? A thought here: we could point an Appraisal set to master, and just let the rest fail until it's updated upstream.
As for breaking changes: I think we're okay there, we'll just need to make a note in the CHANGELOG when we release.

Oh, I forgot about Appraisal. You are right, it works after removing the appraisals for old versions. So either this is merged without back compatibility, or I spend a bit more time to make it work with older versions.
By the way, we already have some code to do back compatibility. If we are merging as is, we probably should also remove that:
https://github.com/nickcharlton/administrate-field-nested_has_many/blob/bc1c881c968f716d5435d3f594f25abf4c1c281d/app/views/fields/nested_has_many/_show.html.erb#L1-L9
Perhaps we can wait for the next version of Administrate and I'll do two PRs: one to remove compatibility with older versions, and another would be this PR.

As mentioned I have opened PR https://github.com/nickcharlton/administrate-field-nested_has_many/pull/46, which will remove the compatibility with Administrate prior to v0.10

Took this PR out of draft mode. I think this can be considered for merge now.


Problem Solving (Basic) Active Trader.py

An institutional broker wants to review their book of customers to see which are most active. Given a list of trades by customer name, determine which customers account for at least 5% of the total number of trades. Order the list alphabetically ascending by name.

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-everyone


[Bug] Deserialize using bincode fails for eip-2930 transactions

Component
consensus, eips, genesis
What version of Alloy are you on?
alloy v0.1.4
Operating System
Linux
Describe the bug
Please refer to this context: https://github.com/paradigmxyz/reth/issues/9433
The issue is introduced in https://github.com/alloy-rs/alloy/commit/194f266fae46c1214004d04d4606010c3807b534 and is present from v0.1.3 onwards. It's probably a quirk of bincode, so not sure what the course of action should be or if it should be fixed.

this has been fixed


[CHALLENGE SUBMISSION] Challenge 04: PowerShell

Please provide the following information for your submission:
What is your name? (First, Last)
Barbara Forbes
Where is your GitHub Repo ?(Link to your challenge solution)
https://github.com/Ba4bes/SeasonsOfServerless/tree/main/C04-A_Big_Barbecue
What Challenge is this for? (Challenge number between 1 and 7)
4
(Optional) Anything else we should know? e.g., language used, location, blog post, tell us how you solved this solution, including any challenges you faced solving it.
I got to use CosmosDB again ❤.
Please read the Readme, I made an explanation of everything I did and the different options in the function 😀

thank you for this submission!

thank you for this submission!


TAS: fix panic in e2e test when parallelism < completions

What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3620
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

/assign @mbobrovskyi

cc @PBundyra

/test pull-kueue-test-integration-main
unrelated, opened issue: https://github.com/kubernetes-sigs/kueue/issues/3633

/lgtm
Thanks!

/retest
Due to know issue.


In App Message Not Appearing

Version(s) of SDK bug appears:
implementation 'io.customer.android:tracking:3.0.0-beta.2'
implementation 'io.customer.android:messaging-push-fcm:3.0.0-beta.2'
implementation 'io.customer.android:messaging-in-app:3.0.0-beta.2'

Current Behavior
In App Message doesn't appear. However I can see following logs:
 I/Gist: Current gist route set to: Home
 I/Gist: Messages timer started
 I/Gist: Fetching user messages
 I/Gist: No messages found for user
 I/Gist: Fetching user messages
 I/Gist: No messages found for user
 I/Gist: Fetching user messages
 I/Gist: No messages found for user

SDK Initialisation Steps:
Following is in Application class:
CustomerIO.Builder(
        siteId = "xxxxx",
        apiKey = "xxxxx",
        appContext = this
    )
        .addCustomerIOModule(ModuleMessagingPushFCM())
        .addCustomerIOModule(ModuleMessagingInApp("xxxxxxxxx"))
        .autoTrackScreenViews(true)
        .setRequestTimeout(8000L)
        .build()

Following code is called on App Launch (HomeViewModel):
CustomerIO.instance().identify(
        identifier = profile.userId?.toString()!!,
        attributes = mapOf("email" to (profile.email ?: ""), "firstName" to profile.firstName!!)
    )

HomeActivity has label "Home" in manifest
Expected Behavior
In App Message Should Appear On Home Screen

@TimidLupus thank you for writing to us, can you please let me know how did you trigger this message? via campaign or anything else, and whats the status over there?

Campaign was used to send the message.
status is: Sent

Apologies for the late reply, we have rolled out some more fixed to the backend, please can you confirm if its still happening?

Closing this, until I hear back that this issue is still happening.


fix(window-state)!: saving minimized state

#1702 didn't actually work, we save the state on move event, and it fires on minimize so...
Also updated the API example to include window state plugin

I wonder if we need to update the size on size change event, since we can't get it if we're existing from minimized state

Went with the basic approach, just checking the maximize and minimize state on resize event


MM-15400 Added some protections to /installed link

Now require the sysadmin to enter the Jira URL for cloud
Match the incoming /installed with the JiraURL
Only allow /installed to be invoked once, with a 15 min expiration

https://mattermost.atlassian.net/browse/MM-15400

...work with the system console configuration...
@crspeller this is now between @jasonblais and @cpoile, they've been talking about having a /jira instructions command that would display the proper steps, with dynamically generated contents.


overrun durations

wget https://github.com/tsenart/vegeta/releases/download/v6.3.0/vegeta-v6.3.0-linux-amd64.tar.gz
in /usr/local/bin and made Vegeta executable. Limiting connections to 10 through iptables.
$ sudo iptables -F
$ sudo iptables -A OUTPUT -p tcp --syn --dport 80 -m connlimit --connlimit-above 10 -j REJECT

$ echo "GET http://open.stage.bbc.co.uk/loadtest/2kb" | vegeta attack -duration=5m -rate=5000 | tee results.bin | vegeta report
Disabled ipv4 and only using Ipv6
Though duration goes over 5 minutes (probably because of slow response times).
 But isn't that a timeout of the request and not the total timeout duration?

Yes, timeout is per request. It looks like you're running out of resources somewhere.

Running top and it doesn't look like it.
/etc/sysctl.conf
net.ipv4.tcp_max_syn_backlog = 40000
net.core.somaxconn = 40000
net.core.wmem_default = 8388608
net.core.rmem_default = 8388608
net.ipv4.tcp_sack = 1
net.ipv4.tcp_window_scaling = 1
net.ipv4.tcp_fin_timeout = 15
net.ipv4.tcp_keepalive_intvl = 30
net.ipv4.tcp_tw_reuse = 1
net.ipv4.tcp_moderate_rcvbuf = 1
net.core.rmem_max = 134217728
net.core.wmem_max = 134217728
net.ipv4.tcp_mem  = 134217728 134217728 134217728
net.ipv4.tcp_rmem = 4096<PHONE_NUMBER>17728
net.ipv4.tcp_wmem = 4096<PHONE_NUMBER>17728
net.core.netdev_max_backlog = 300000
net.ipv4.ip_local_port_range="1025 65535"

/etc/security/limits.conf
ec2-user         hard    nofile      1000000
ec2-user         soft    nofile      1000000

But I am limiting connections.

14m this time.  Here's IPv4 persistence: https://github.com/bbc/misc/blob/master/ipv6/ipv6.md#ipv4ms-1.

ulimit shouldn't matter - the connections will be reused with the same domain.
https://github.com/bbc/misc/blob/master/ipv6/ipv6.md
I have limited ip(6)tables to 10 conns - so all good.
BTW:  Made some changes are you OK with them?
https://github.com/bbc/FOSS-Load-Tools/blob/master/vegeta/vegeta.md


Multi login

So I have 2 py files and 1 is where I have my account so I made my wife an account and when I go to the api and setup a py for her since its in the same laptop it is saying that
{"code":null,"message":"Invalid credentials."}
Traceback (most recent call last):
File "C:\Users\thesy\Documents\Python\Public\public2.py", line 4, in
public.login(
File "C:\Users\thesy\AppData\Local\Programs\Python\Python312\Lib\site-packages\public_invest_api\public.py", line 80, in login
raise Exception("Login failed, check credentials")
Exception: Login failed, check credentials
This is my code right now ( i took off the login info)
import sys
import yfinance as yf
from public_invest_api import Public
Function to get the current price of a stock using yfinance
def get_current_price(stock_symbol):
stock_data = yf.Ticker(stock_symbol)
current_price = stock_data.history(period="1d")["Close"].iloc[-1]
return current_price
public = Public()
public.login(
<EMAIL_ADDRESS>password='',
wait_for_2fa=True  # When logging in for the first time, you need to wait for the SMS code
)
Ask whether to buy or sell
while True:
action = input("Enter '1' to BUY or '2' to SELL: ")
if action == '1':
action = 'BUY'
break
elif action == '2':
action = 'SELL'
break
else:
print("Invalid input. Please enter '1' to BUY or '2' to SELL.")
Assuming you have user input for symbol and quantity
stock_symbol = input("Enter the stock ticker: ")
quantity = int(input("Enter the quantity: "))
Get the current price of the stock
current_price = get_current_price(stock_symbol)
Adjust price by rounding up and adding 1 cent
current_price += 0.001
current_price = round(current_price, 2)
Place order
order = public.place_order(
symbol=stock_symbol,
quantity=quantity,
side=action,
order_type='LIMIT',
limit_price=current_price,
time_in_force='DAY',  # 'GTC' or 'IOC' or 'FOK'
is_dry_run=False,  # If True, it will not actually place the order
tip=0  # The amount to tip Public.com
)
print(order)

Hello, I believe I know what the issue is. When you logged into your account, it saved a pkl file with your login cookies using the default filename. When you then tried to log in to your wife's account, it then tried to use your saved cookies, which resulted in the error because it was for your account and not hers. To fix this, specify a different filename when creating the Public() object, like public = Public(filename="public1.pkl") for your account, then public = Public(filename="public2.pkl" for her account for example. That way it will use the correct saved cookies for each of your accounts.

so do I need to remove the "public = Public()" and then add "public = Public(filename="public1.pkl")" and "public = Public(filename="public2.pkl")"

and I had a simlar issue with robinhood also do you think that this method would even fix that?

I'm not sure, but there's no hurt in trying!

what about this?
so do I need to remove the "public = Public()" and then add "public = Public(filename="public1.pkl")" and "public = Public(filename="public2.pkl")"

yes.


fix: skip building podman binary on release

What problem does this PR solve?:
The release job was failing here. I suspect its due the recent changes in .goreleaser.yaml and its overriding the same konvoy-image binary. Since this new build spec is only needed in a specific e2e test I moved it out to a different (non-default) config file and reverted .goreleaser.yaml to what it was before.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-NUMBER

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Running e2e test in https://github.com/mesosphere/konvoy-image-builder/actions/runs/6553913028/job/17800032651


ENH: add Flat and HalfFlat Distributions

Addresses #44.
Summary of my changes:

Add Flat distribution
Add HalfFlat distribution

Question
Do these need tests?

@tirthasheshpatel, thanks again. Contrary to what it may look like, these two distributions will need more tests than the rest for two big reasons:

They are improper distributions, so we can't draw forward samples from them (Flat.sample). I'm my opinion, if someone tries to call their sample method, a TypeError should be raised. However, we should be able to do inference in models that have flat or half flat priors (pm.sample), and given their posterior samples, we should be able to call sample posterior predictive on them. So they must behave a bit different from the rest of our distributions.
There is no tfp equivalent, so we must test that the returned log_prob values are correct. That sounds simple because the log_prob should always be zero. The difficulty here is the shape handling. If the value passed to log_prob has a rank that is lower than the distribution's event shape, we should raise an error, if the value has a shape that doesn't broadcast with the distribution's batch+event shape, we should raise an error. Actually, I think it's even more stringent than that, the rightmost axis of the passed values should exactly match the distribution's event shape, not just broadcast with it, or an error should be raised. Furthermore, the log prob should sum reduce over the event shape axis, in order to only get back a batch of zeroes.

Point 1, cannot be done until we fix #167, and point 2 is a pit in shape hell, so for now I think that we should leave this PR open and when we fix up #167 we can come back to it.

@lucianopaz Sorry for the late reply and thanks for such a detailed review! I will think more about the "shape hell" and try to raise relevant errors. Meanwhile, I will also try to catch up with #167 and try to resolve it!

@tirthasheshpatel, for now don't worry about #167. I'm working on it in this branch, but it requires #193 to be finished first. My recomendation is to do one of the following:

Continue to implement regular distributions like what you did with the BetaBinomial, and at a later time we can come back to this PR and finish it up.
Write the tests for the Flat and HalfFlat distributions, make sure that the log_prob outputs the correct shape, and then mark the tests for predictive sampling and pm.sample as expected failures on pytest. Once we finish with #167, we'll remove the expected failure mark and ensure that these tests pass.

Some distributions in #44 don't have a tfp equivalent. So, do we have to wait for it to be implemented or is there a way around? (I was thinking about implementing classes inheriting from tfp's Distribution class)

Pinging @tirthasheshpatel, just to let you know that I've opened #227. Once that gets merged in, you should merge it into your branch and you'll be able to run all of the tests required by the Flat and HalfFlat distributions.

@lucianopaz sorry for getting back to you late. I will complete this by today.

want to finish this up @lucianopaz?

Sorry @tirthasheshpatel for not being able to finish this up sooner. Covid quarantine and all, I can't put almost any time to review pymc stuff. I'll merge this PR because it seems ready to go. Great job!


[$500] Chat's received in DM above chat I already sent

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.35-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706840985963419
Action Performed:

Send chat in DM
Have other person reply promptly

Expected Result:
Chat that's received to show below the chat you already sent
Actual Result:
Chat that's received after the one you posted shows above the chat you sent
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/781fc9f2-4f4c-4d9a-997f-a856b382c7e1

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0163764ffee80f71ee
Upwork Job ID:<PHONE_NUMBER>807683584
Last Price Increase: 2024-02-02

It could be expected behaviour, I find it a bit annoying though cuz I can't trust that the last message showing is the most recent
At end of vid you can see it between 4 and 5 being displayed
https://github.com/Expensify/App/assets/22508304/a111eac5-e63c-4cef-8e4f-fc29e2763a04

Yes, I too think this is expected behaviour. Timestamps are based on the time a user sends a message. So even though the server response is late, the report actions are sorted based on these timestamps.

Cool, sounds like we can close this one.


Problems enabling SSL with NextJS dev server

Are you accessing the CLI from the default port :4280 ?

[X] No, I am using a different port number (--port) and accessing the CLI from that port
[X] Yes, I am accessing the CLI from port :4280

Describe the bug
I try to run NextJS development server with SWA emulator. After enabling SSL, emulator crashes after first request.  If I do static export of the NextJS site and use that folder with emulator, everything works correctly.
Configs and outputs at the end...
To Reproduce

Create new vanilla NextJS app with 'nxp create-next-app@latest new-swa-test'
Run ´swa init´ and accept default settings
Update package.json to run NextJS dev server with different port (3001 required for my case, but same problem with default port)
Update swa-cli.config.json with dev server port (3001) and SSL settings
Run ´swa start´
Wait for a sec or make request directly and the emulator crashes

Expected behavior
Emulator would nicely serve my pages from the NextJS server.
Desktop (please complete the following information):

OS: Windows 11
Versions
SWA CLI 1.1.4
NodeJS 18.14.0 (through NVM 1.1.9)
NextJS 13.4.19

Additional context
swa-cli.config.json
{
  "$schema": "https://aka.ms/azure/static-web-apps-cli/schema",
  "configurations": {
    "new-swa-test": {
      "appLocation": ".",
      "outputLocation": ".next",
      "appBuildCommand": "npm run build",
      "run": "npm run dev",
      "appDevserverUrl": "http://localhost:3001",
      "ssl": true,
      "verbose": "silly"
    }
  }
}

package.json scripts
"scripts": {
    "dev": "next dev -p 3001",
    "build": "next build",
    "start": "next start",
    "lint": "next lint"
  },

Output after 'swa start' (certification details snipped away)
Welcome to Azure Static Web Apps CLI (1.1.4)

Using configuration "new-swa-test" from file:
  C:\code\swa-test\new-swa-test\swa-cli.config.json

***********************************************************************
* WARNING: This emulator may not match the cloud environment exactly. *
* Always deploy and test your app in Azure.                           *
***********************************************************************

Checking if localhost:3000 is accepting TCP connections...
Port 3000 is available. Use it.
Resolved port number: 3000
appDevserverUrl provided, we will try connect to dev server at .next
Trying to read workflow config with values:
 - appLocation: C:\code\swa-test\new-swa-test
 - outputLocation: http://localhost:3001
 - apiLocation: <undefined>
No workflow config folder found at C:\code\swa-test\new-swa-test\.github\workflows
Validating user workflow config (BEFORE):
 - appLocation: C:\code\swa-test\new-swa-test
 - outputLocation: http://localhost:3001
 - apiLocation: <undefined>
Validating user workflow config (AFTER):
 - appLocation: C:\code\swa-test\new-swa-test
 - apiLocation: <undefined>
 - outputLocation: http://localhost:3001
 - dataApiLocation: <undefined>
User workflow config:
 - appLocation: C:\code\swa-test\new-swa-test
 - apiLocation: <undefined>
 - outputLocation: http://localhost:3001
 - dataApiLocation: <undefined>
Running echo 'No Data API found'. Skipping
WARNING: Using built-in UNSIGNED certificate. DO NOT USE IN PRODUCTION!
Checking for cached certificate at C:\Users\heinonenjj\.swa\certificates\ssl\swa-cli-UNSIGNED.pem
Certificate is valid, using it.
Starting the SWA emulator with the following configuration:
- ssl:
  - 0: true
  - 1: -----BEGIN CERTIFICATE REQUEST-----
[[.... SNIP .... ]]
-----END CERTIFICATE REQUEST-----
-----BEGIN RSA PRIVATE KEY-----
[[.... SNIP .... ]]
-----END RSA PRIVATE KEY-----
-----BEGIN CERTIFICATE-----
[[.... SNIP .... ]]
-----END CERTIFICATE-----
  - 2: -----BEGIN CERTIFICATE REQUEST-----
[[.... SNIP .... ]]
-----END CERTIFICATE REQUEST-----
-----BEGIN RSA PRIVATE KEY-----
[[.... SNIP .... ]]
-----END RSA PRIVATE KEY-----
-----BEGIN CERTIFICATE-----
[[.... SNIP .... ]]
-----END CERTIFICATE-----
- env:
  - SWA_RUNTIME_CONFIG_LOCATION: C:\code\swa-test\new-swa-test
  - SWA_RUNTIME_WORKFLOW_LOCATION: <undefined>
  - SWA_CLI_DEBUG: silly
  - SWA_CLI_API_PORT: 7071
  - SWA_CLI_APP_LOCATION: C:\code\swa-test\new-swa-test
  - SWA_CLI_OUTPUT_LOCATION: http://localhost:3001
  - SWA_CLI_API_LOCATION: <undefined>
  - SWA_CLI_DATA_API_LOCATION: <undefined>
  - SWA_CLI_DATA_API_PORT: undefined
  - SWA_CLI_HOST: localhost
  - SWA_CLI_PORT: 3000
  - SWA_CLI_APP_SSL: true
  - SWA_CLI_APP_SSL_CERT: -----BEGIN CERTIFICATE REQUEST-----
[[.... SNIP .... ]]
-----END CERTIFICATE REQUEST-----
-----BEGIN RSA PRIVATE KEY-----
[[.... SNIP .... ]]
-----END RSA PRIVATE KEY-----
-----BEGIN CERTIFICATE-----
[[.... SNIP .... ]]
-----END CERTIFICATE-----
  - SWA_CLI_APP_SSL_KEY: -----BEGIN CERTIFICATE REQUEST-----
[[.... SNIP .... ]]
-----END CERTIFICATE REQUEST-----
-----BEGIN RSA PRIVATE KEY-----
[[.... SNIP .... ]]
-----END RSA PRIVATE KEY-----
-----BEGIN CERTIFICATE-----
[[.... SNIP .... ]]
-----END CERTIFICATE-----
  - SWA_CLI_STARTUP_COMMAND: npm run dev
  - SWA_CLI_VERSION: 1.1.4
  - SWA_CLI_SERVER_TIMEOUT: 60
  - SWA_CLI_OPEN_BROWSER: false
- commands:
  - swa: node<EMAIL_ADDRESS>  - api: <undefined>
  - dataApi: <undefined>
  - run: cd "C:\code\swa-test\new-swa-test" && npm run dev
[swa] Please make sure you want to hit the http proxy server.
[run]
[run] ><EMAIL_ADDRESS>dev
[run] > next dev -p 3001
[run]
[swa] No staticwebapp.config.json found in current project
[swa] Validating dev server config:
[swa]  - url: http://localhost:3001
[swa]  - timeout: 60
[swa] Checking if localhost:3001 is accepting TCP connections...
[swa] - Waiting for http://localhost:3001 to be ready
[run] - ready started server on [::]:3001, url: http://localhost:3001
[run] 2023-08-21T07:54:40.313Z next:router-server:filesystem nextDataRoutes Set(0) {}
[run] 2023-08-21T07:54:40.314Z next:router-server:filesystem dynamicRoutes []
[run] 2023-08-21T07:54:40.314Z next:router-server:filesystem pageFiles Set(0) {}
[run] 2023-08-21T07:54:40.314Z next:router-server:filesystem appFiles Set(0) {}
[swa] Connected to tcp:<IP_ADDRESS>:3001 successfully
[swa] ✔ http://localhost:3001 validated successfully
[swa]
[swa] Using dev server for static content:
[swa]   http://localhost:3001
[swa]
[swa] Azure Static Web Apps emulator started at https://localhost:3000. Press CTRL+C to exit.
[swa]
[swa]
[swa] Connected to tcp:localhost:3001 successfully
[run] 2023-08-21T07:54:44.011Z next:jsconfig-paths-plugin tsconfig.json or jsconfig.json paths: { '@/*': [ './src/*' ] }
[run] 2023-08-21T07:54:44.011Z next:jsconfig-paths-plugin resolved baseUrl: C:\code\swa-test\new-swa-test
[run] 2023-08-21T07:54:44.028Z next:jsconfig-paths-plugin tsconfig.json or jsconfig.json paths: { '@/*': [ './src/*' ] }
[run] 2023-08-21T07:54:44.028Z next:jsconfig-paths-plugin resolved baseUrl: C:\code\swa-test\new-swa-test
[run] 2023-08-21T07:54:44.051Z next:jsconfig-paths-plugin tsconfig.json or jsconfig.json paths: { '@/*': [ './src/*' ] }
[run] 2023-08-21T07:54:44.051Z next:jsconfig-paths-plugin resolved baseUrl: C:\code\swa-test\new-swa-test
[run] - event compiled client and server successfully in 170 ms (20 modules)
[run] - wait compiling...
[run] - event compiled client and server successfully in 135 ms (20 modules)
[swa] GET ws://localhost:3000/_next/webpack-hmr (proxy)
[swa] killing SWA CLI
[swa] node<EMAIL_ADDRESS>exited with code 0
--> Sending SIGTERM to other processes..
[run] cd "C:\code\swa-test\new-swa-test" && npm run dev exited with code 1
✖ SWA emulator stoped because the --run command exited with code 1.

Thanks for reporting. Will investigate Nextjs with ssl later.

Any update?

Any update?

Any update?

Any update yet?


Proposal: Rename repo to payload-pipeline

"payload" is internal name, lets use "rebuild-pipeline"? It also highlights the fact that its not the pipeline we use to build official OKD but a way to build your own. WDYT?

I don't really like the rebuild in there TBH, and payload seems pretty self-explanatory to me?
Maybe okd-payload-tekton-pipeline or okd-release-tekton-pipeline? (Diane noted we should definitely have okd in there)
Also cc'ing @dmueller2001 @lmzuccarelli @aleskandro for additional input

Do we mandatory need to specify it's a tekton pipeline?
Wrt payload vs release, I agree that release could be more meaningful for external guys or people approaching the community.
However, calling it payload could bring the community to stay on the same page and call it as we do internally, with a few beneficial side-effects eventually (e.g., when "communicating", support, debugging, raising issues/bugs). I mean, it's "just" the name of a repo, but if we define what a "payload" is, I'd say everybody should use it consistently, and "alias" should be avoided.

IMO its fair to add tekton here. This implementation uses it, but there might be others - i.e. Jenkins pipeline.
On the other hand okd-release-tekton-pipeline may be interpreted as "OKD Tekton operator pipeline". Maybe build-okd-with-tekton?

The renaming has been discussed during today's OKD working group meeting. The proposed name is okd-payload-pipeline.

Done


sharp is not a function: Error when using next/image in a yarn workspace that has sharp as a dependency in one of its packages

Describe the bug
Having the package sharp in a package of yarn workspaces makes the next_image function crash. The problem has something to do with yarn hosting behavior because the function also uses sharp. The nohoist parameter does not solves it.

the common package has the sharp dependency
the next-website uses the next_image function which uses sharp

The error:

{
  "errorType": "TypeError",
  "errorMessage": "sharp(...).rotate(...).jpeg(...).png(...).webp(...).avif is not a function",
  "trace": [
    "TypeError: sharp(...).rotate(...).jpeg(...).png(...).webp(...).avif is not a function",
    "    at handler (/var/task/packages/next-website/netlify/functions/next_image.js:122:6)",
    "    at processTicksAndRejections (internal/process/task_queues.js:97:5)"
  ]
}

To Reproduce
Steps to reproduce the behavior
Github repository

master branch has errors (deployed here)
no-errors branch works fine (deployed here)

Clone the repository above, or

Add sharp in one yarn workspace package (as i did in packages/common)
Have another package that is a Next.js project using next/image
Deploy to netlify with Next Essentials plugin

Expected behavior
The fact that i'm using sharp in one of my packages should not break the next/image function.
Versions

Next.js: 10.2.3
plugin (if installed at fixed version): 3.6.3 from Netlify UI

Hey. The issue is that your other version of sharp doesn't support avif, which was added in 0.27. I'm not sure why it's resolving the wrong version, but are you able to upgrade the other package to use sharp 0.27 or later?

Hey. The issue is that your other version of sharp doesn't support avif, which was added in 0.27. I'm not sure why it's resolving the wrong version, but are you able to upgrade the other package to use sharp 0.27 or later?

Yes, i'm able to upgrade it. In fact, i just did and the issue is gone.
Thank you, i'll mark this as closed.


New endpoint for BATCH requests (translation api)

Need to fix endpoint for translation API. I have received this message to my email:
Our records indicate that your team haas occasionally used the the HTTP batch mode to request Translation API service by making a POST request to https://www.googleapis.com/batch (details here). We have a pending change in February that will discard batch requests to translation service using the above method. We have an alternative way for you to continue to use the batch functionality: instead of using the https://www.googleapis.com/batch endpoint to make batch requests, please use the endpoint https://translation.googleapis.com/batch/translate to get the same functionality. We request you to make this change as soon as you can. Please reach out to use in case you have any questions.
Google Cloud Support

Did you get migrated to the new API okay?

Thank you for filing this issue. We asked some clarifying questions a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to re-open this issue with more information.


Implement wizard interface

Now is possible to create processes.

I deleted because I pull to the wrong branch, my intention was to pull to my own master fork


Use a single Redis URL instead of two variables

Also fix the default value to give hints as what the final
URL should look like in case of an IP change.

:+1:

:+1:


String types in mock driver / unit tests.

I noticed today when comparing output from a real call to the EOSDriver for a new method I was writing to output from the mock driver in napalm base, that the data returned by the mock driver may not be type unicode, when the data returned by the real driver is.
It has been posited in slack that this may be due to how the strings are read from disk by the mock driver, versus returned from other underlying libraries in the real drivers.
May wish to investigate changing how we read data for test cases in order to more accurately write unit tests, and avoid additional calls to py23_compat.text_type.
Test case and additional discussion needed.

I remember you already posted a suggested solution on slack, is this something you can PR?


Good I idea, but not very good practically ..   Better to use MOA

Have you used it, I've achieved fascinating results


Change rdb proctype for different segments

Changed RDB proctypes within fsp
Function in gateway to add processes specified in JSON to list of connections
Add getaccess function to tailreader

No longer needed - updated branch already merged


[WIP] try recovering from an upgrade after downgrading

What's being changed:
Review checklist

[ ] Documentation has been updated, if necessary. Link to changed documentation:
[ ] Chaos pipeline run or not necessary. Link to pipeline:
[ ] All new code is covered by tests where it is reasonable.
[ ] Performance tests have been run or not necessary.

This is not complete, but it may fix an issue when a user downgraded from v1.17 to v1.16 and back up to v1.17 again. @antas-marcin and @byronvoorbach have context in case you want to continue on this while I'm off.
What would need to happen to make this complete IMHO:

Validate that this does not have a negative influence on the regular upgrade journey
Add tests for the change


fix(doc-core): fix darkmode that don't work

Description
When i set darkmode false, it don't work in @modern-js/plugin-module-doc, and i found a doc error about darkmode, i fix it too.

Related Issue

Types of changes

[ ] Docs change / Dependency upgrade
[x] Bug fix
[ ] New feature / Improvement
[ ] Refactoring
[ ] Breaking change

Checklist

[x] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

Fix https://github.com/web-infra-dev/modern.js/issues/3280


createReport - Bump from #34

Whats the ETA on support for createReport via this package?

i'm waiting for the same

createReport is now supported via powerbi-client-react package. Upgrade your package version "powerbi-client-react": "^1.4.0". embedConfig  will be of type IReportCreateConfiguration.
Feel free to reach out for any other queries.


Trims margin on workflow nav items

Trims the horizontal margin on workflow nav items by half (20px -> 10px)
Prevents wrapping of workflow nav item names above 1080px screen size

Bug ("Transaction" wrapping to new line):

Fix:

One thing to bear in mind is this will almost definitely go onto two lines in a lot of languages.
Question: how much value is there in knowing that there will be a summary in 3 steps time when you're on generate keys? Perhaps we could transition to a design that states like Step 3/7 and maybe it just displays the current step name and the next step name. There could be an option for the user to expand to see all steps.

@ryancreatescopy I kinda like the simplicity of that suggestion. Would instantly solve issues with some languages being larger than others

One thing to bear in mind is this will almost definitely go onto two lines in a lot of languages.

@wackerow @ryancreatescopy do we want to move forward with this PR? Or close given this fact?

@ryancreatescopy Any opposition to just merging this to help at least the English headers? Or do you feel the margins are too tight now?

Merging in... seems to at least be a win for English. @ryancreatescopy LMK what you think. We can revert if we don't want this.


BUG: usrlog.sh: \t Linux

Output to $_USRLOG and from ut is not consistent with the behavior on BSD.
Possible causes:

tab handling (\t) differences between GNU and BSD programs
Bash HISTTIMEFORMAT

Possible remedies:

$'\t' ?

There should be a test case for this. (see #20)


Allow to Close the Application

Allow to Close Application from custom command.
Minimize Application on regular Close button click.

Added naive implementation in v0.0.11


Creating subsets from a loop, always crashes after the first one

so im trying to create subsets based on a loop of models that i have, unfortunately it always creates the first one then it crashes, with error :
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'mesh')
const createSubsetsFromArray = async () => {
    await Promise.all(
        props.models.map(async (model) => {
            const { ifcApi } = props;
            ifcApi.IFC.selector.unpickIfcItems();
            ifcApi.IFC.selector.unHighlightIfcItems();
            try {
                const subset = ifcApi.IFC.loader.ifcManager.createSubset({
                    modelID: model.modelID,
                    ids: Array.from(new Set(model.geometry.attributes.expressID.array)),
                    applyBVH: true,
                    scene: model.parent,
                    removePrevious: true,
                    customID: 'full-model-subset' + model.modelID,
                });
                return subset; // Add a return statement here to return the subset
            } catch (error) {
                console.error(`Error creating subset for model ${model.modelID}: ${error}`);
                return null; // Return null if an error occurs
            }
        })
    );
};

I'm not very experimented with promises, but: What if you try to set an "await" in the const subset?
const subset = await ifcApi.IFC.loader.ifcManager.createSubset

I also suspect that you are you are skipping the await of a promise. Have you tried something simpler?
const subsets = [];
for(const model of models) {
   const subset = await  ifcApi.IFC.loader.ifcManager.createSubset({ ... });
   subsets.push(subset);
}

Alternatively, you can also use the dev tools and, if it fails, see where it fails. Cheers!


scrape-it 4.1.0

Add support for selecting text nodes. Thanks, @ComFreek! :cake: /cc #45 76

Thanks for merging!


Small typo with text on the source of an example text file

Small typo with text on the source of an example text file

Looks like you'll also have to remove a trailing space character from one of the lines.


Update state-getters.ts

Issue #: None
Description of changes:

Temp fix (until certify component is implemented) to allow File and Pay when other components are valid.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Looks good. Is the detail.valid check also ready to go?

I think. Its value is true so it's not blocking the File button.

Looks good. Is the detail.valid check also ready to go?

I think. Its value is true so it's not blocking the File button.

Copy that, lets get it in then!


Right click menu gets in the way when right clicking a message to delete it or see its timestamp

The menu should not be displayed if you're right clicking on a message.

When you right click on the message you can just scroll the mouse a bit and the menu should disappear, leaving only the timestamp and the delete option

No, that doesn't work. Maybe Mac menus disappear or something, but Windows menus don't work that way...

I deleted this ugly right click menu in the beta.
Please see: https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458


How do I access the email settings api?

There doesn't seem to be an access method here...

That API is based on an older protocol not supported by this client.


addressees in To: field not visible

Happy I stumbled upon this great app!
After using it a few days, I only discovered 1 minor issue:
When composing a new email or replying to an email the addresses in the To: field are not visible
They are there however; I am able to send the email

@bvdlingen if I remember correct, this issue is reported by another user with deepin Linux.
Could you let me know which distribution are you using and maybe a screenshot of the issue is helping.
I really couldn't reproduce it. I reckon it's something wrong with the UI CSS

Thanks for the follow up,
I am running Solus Linux, with Budgie desktop (based on GTK3)
The issue occurs on both work and private notebooks and desktops.
See this screenshot to illustrate the behaviour:
https://i.postimg.cc/434B7br3/Screenshot-from-2020-01-09-15-55-32.png
Making the screenshot I noticed the following:
The problem does not occur when opening a reply to message or new message in a new window.
I didn't test on other linux desktop environments, I can do this is this is helpful

I did some additional testing:

office 365 theme settings don't make a difference
office 365 display density settings don't make a difference
behaviour occurs with both prebuild appimage and self build appimage

@bvdlingen thanks for the feedback.
Could you run the app by using yarn start or npm start, and check if the issue still occur? then check if the terminal throw any error or the build in developer tools (contrl + shift + i) throw any error in the console? another testing is using Chrome with the web version, see if that also have this issue.
I am working wit the GNOME 3 and KDE plasma every day. Seems fine by me.

I reckon you will have the same issue in yarn start, but the chrome web all good.
That's what's been feedback by another user long times ago.

Wow that's interesting!
I didn't try that before, but when using  yarn start the issue does not occur.
Hence no error in the terminal.

That's strange. I used to work on the Ubuntu + Gnome and it was all good. Now I am switching to Fedora + Gnome 3, still couldn't reproduce the issue.
If yarn start doesn't have the issue, then the problem might caused by the Election builder when build the AppImage (some magics).
Another try is using the .deb package if you are on the Debian. Not familiar with Solus, see what package can supported by Solus in the Election builder. Then you can tweak the package.json a little bit to build your executable.
Another try can be upgrade the Electrion builder to the latest (22.2.0), currently it's on 20.x.x

Hi!
Awesome tool, came here to report that this issue also happens on Manjaro 18.1.5 with Cinnamon.

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.
I reckon this issue is caused by javascript or css issues in chromium on particular platform.

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.
I reckon this issue is caused by javascript or css issues in chromium on particular platform.

Just tried on a vm with Manjaro 18.1.5 with Cinnamon I have at home, reproduced the issue running directly from the source but no error in console 😕

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.
I reckon this issue is caused by javascript or css issues in chromium on particular platform.

Just tried on a vm with Manjaro 18.1.5 with Cinnamon I have at home, reproduced the issue running directly from source but no error in console

according the feedback, the email can be still send to the correct contact. So I reckon it's just a UI rendering issue. The contact is not visible in the right place.
If you familiar with the HTML and CSS, probably can find out why it's not visible from the follow source code.

I didn't customize that part of logic though. One possibility is due to the app hide the ads on the right side. This might change the layout a little bit and may cause that contact div shift to somewhere else.
Really need to drill into the root cause, so can be a fix.

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.
You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.
You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

Ah!, I see, you may be on to something, I just set another class name for all ads and the issue no longer reproduces, both on the latest AppImage and from source.
I'm at an enterprise office365 subscription so no ads. Maybe that's why you can't reproduce it?

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.
You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

Ah!, I see, you may be on to something, I just set another class name for all ads and the issue no longer reproduces, both on the latest AppImage and from source.
I'm at an enterprise office365 subscription so no ads. Maybe that's why you can't reproduce it?

Thanks for trying out. I reckon we make some progress onto this. I'll change the way handling the ads blocker in the next few days.

Hi all,
any update on this? Just a confirmation that it also happens for me and I'm using a corporate Outlook subscription. So must have something to do with the logic to hide the ads. It is a little bit frustrating and can lead to e-mails being sent to unintended recipients.
Best regards,
Dominic.

Hi all,
any update on this? Just a confirmation that it also happens for me and I'm using a corporate Outlook subscription. So must have something to do with the logic to hide the ads. It is a little bit frustrating and can lead to e-mails being sent to unintended recipients.
Best regards,
Dominic.

Hi @dcioccarelli, thank you to support the app.
There is a workaround for this issue. If you are using corporate outlook subscription, there shouldn't be any vertical ADs unit on the right side. What you can do is adding a invalid class name into the setting. The VERTICAL ADS CLASS is the one you looking for. Just type some random number inthere will do :)

Please leave some feedback see if this will fix your problem :)

I can confirm that the workaround works for corporate outlook subscription. maybe add a note to the readme?
also add a note that to access the settings window right click on the system tray icon, (took me a good hour to find)
OS: ubuntu 18.04 LTS

Hi @eNkru ! It worked. At first I just added random text in the vertical ads class and it didn't work. Only when I had added it to all three classes did it work.
Maybe add a checkbox to the UI for corporate users which automatically adds random text and disables the text entry boxes?

I can confirm that the workaround works for corporate outlook subscription. maybe add a note to the readme?
also add a note that to access the settings window right click on the system tray icon, (took me a good hour to find)
OS: ubuntu 18.04 LTS

Thank you for the confirmation. I'll update the README

Hi @eNkru ! It worked. At first I just added random text in the vertical ads class and it didn't work. Only when I had added it to all three classes did it work.
Maybe add a checkbox to the UI for corporate users which automatically adds random text and disables the text entry boxes?

I'll re-arrange the setting panel layout for easy use :)

Finally this issue should be fixed. I couldn't reproduce the error anymore. Feel free to re-open this ticket if you still having the issue.

Same fix for non-corporate outlook (hotmail.com) on Ubuntu 18.04. Cheers folks

Adding invalid class to first field only doesn't do it for non-corporate accounts (hotmail.com) on ubuntu 18.04, but I added in all 4 fields  and it seems to do the trick!

Adding invalid class to first field only doesn't do it for non-corporate accounts (hotmail.com) on ubuntu 18.04, but I added in all 4 fields and it seems to do the trick!

could you try my last commit. It should fix the issue and you don't need to do this workaround anymore.

Confirmed last commit fixes with 0 such field change, cheers!


Merge with quickgui

@ymauray and I have decided to combine forces by merging quickemu_gui into quickgui.
The "Manager" screen will be added to quickgui, while quickgui's existing download interface will replace quickemu_gui's.
I will refactor the code so it's easier to include. Once the merge is complete, I will close this project. Future issues can be raised against quickgui.

... or could be if issues were turned on in that repo :smiling_imp: :point_up:

Merge complete, the new project can be found at https://github.com/quickgui/quickgui/


Message Signing is broken

Steps to reproduce:

Create a wallet
"Sign" a message.
"Verify" produces Error in your input. Copying message and manually verifying will give a verification error.

"Verify" seems to work when using the first wallet created on my installation, but any new ones have this issue. Copying the message and trying to manually verify fails regardless of wallet selected. Is the signer defaulting to the first wallet's public key?

I've been able to reproduce it on MainNet.
Apart from that, other problem that I've found is that trying to verify an empty message doesn't trigger any visible error.

@n4ru Could you confirm that those new addresses don't have any ARK or transfer?
That could be the problem: they aren't found on the blockchain because they haven't been stored yet.

I've added a message that would be displayed when the address isn't on the blockchain.


Bundling JS with ESBuild

Issue
In Better Lighthouse Scores Discussion, I agreed to bundle JS and CSS. This PR accomplishes the JS part. A follow up PR will be created to address CSS bundling.
@hossainemruz, I had the goal of changing as little as possible while accomplishing the conversion, however, due to es6 module not allowing to write to globals, I had to refactor quite a bit of code. So, sorry if there are a lot of changes.
Testing
I created this PR incrementally.

First, I layed the foundations for the new paradim.
Then I migrated each JS file or feature separately in each commit.

As I work on each aspect or feature, I tested and made sure that feature worked.
But given the amount of changes, I won't be surprised if there are bugs / regressions.
If you find anything funny, just tag me on this PR, and I'll make sure to get it fixed.
Also, the config.yml file format has changed a bit. Specifically, I added a lot of switches to enable / disable certain features to allow treeshaking of unused js code. Please see comments in layouts/partials/helpers/get-esbuild-options.html file for a more detailed explanation.
Example config.yml
baseURL: https://hugo-toha.github.io

languageCode: en-us
title: "John's Blog"
theme: "toha"

# Manage languages
# For any more details, you can check the official documentation: https://gohugo.io/content-management/multilingual/
languages:
  en:
    languageName: English
    weight: 1
  bn:
    languageName: বাংলা
    weight: 3

# Force a locale to be use, really useful to develop the application ! Should be commented in production, the "weight" should rocks.
# DefaultContentLanguage: bn

# Allow raw html in markdown file
markup:
  goldmark:
    renderer:
      unsafe: true
  tableOfContents:
    startLevel: 2
    endLevel: 6
    ordered: false

# At least HTML and JSON are required for the main HTML content and
# client-side JavaScript search
outputs:
  home:
    - HTML
    - RSS
    - JSON

# Enable global emoji support
enableEmoji: true

# Site parameters
params:
  # Background image of the landing page
  background: /images/site/background.jpg

  # Provide logos for your site. The inverted logo will be used in the initial
  # transparent navbar and the main logo will be used in the non-transparent navbar.
  logo:
    main: /images/site/main-logo.png
    inverted: /images/site/inverted-logo.png
    favicon: /images/site/favicon.png

  # GitHub repo of your site
  gitRepo: https://github.com/hugo-toha/hugo-toha.github.io
  # Default branch of your Git repo
  gitBranch: main

  # Configure the number of section title visible in the top navbar
  topNavbar:
    maxVisibleSections: 5

  # Configure various features of this theme
  features:

    # Enable dark theme
    darkMode:
      enable: false
      services:
        darkreader:
          defaultColorScheme: system # options are 'system', 'dark', 'light'
          fixes:
            invert: ['img[src$=".svg"]'] # inverts svg colors.
          theme:
            brightness: 100
            contrast: 100
            sepia: 0

    # Enable and configure portfolio
    portfolio:
      enable: false

    # Enable and configure blog posts
    blog:
      enable: true
      # Share post on different social media
      shareButtons:
        facebook: true
        twitter: true
        linkedin: true
        reddit: true
        whatsapp: true
        email: true
        # tumblr: true
        # pocket: true
        # diaspora: true
        # mastodon: true

    # Enable & configure "Notes" features
    notes:
      enable: true

    # Enable comment feature. There, should be only one of them.
    comment:
      enable: false
      services:
        disqus:
          shortName: toha-example-site
        # valine:
        #   appId: HTV6askWxVo3vOxlqjjaq2hd-MsYXbMMI
        #   appKey: pVrT3C85KGIuk27t07eh6bUC
        #   avatar: retro
        #   placeholder: Share your thought.
        #   lang: en
        #   recordIP: true
        #   enableQQ: true
        # utteranc:
        #   repo: github.com/hugo-toha/hugo-toha.github.io
        #   issueTerm: title
        #   theme: github-light
        # giscus:
        #   repo: your-repo/name
        #   repoID: your-repo-id
        #   category: your-category
        #   categoryID: your-category-id
          # theme: light
          # map: url
          # reaction: 1
          # metadata: 0
          # inputPosition: bottom
          # crossOrigin: anonymous
        # commento:
        #   serverURL: cdn.commento.io
        #   autoInit: true
        #   hideDeleted: false

    # Enable Analytics
    analytics:
      enabled: false
      services:
        # Google Analytics
        google:
          id: G-H4LBG7NDFZ
        # # CounterDev
        # counterDev:
        #   id: <your counterdev id>
        # # GoatCounter
        # goatCounter:
        #   code: <your goat counter code>
        # # Matomo / Piwik
        # matomo:
        #   instance: matomo.example.com
        #   siteId: 1 # Or any other number

    # Enable Support
    support:
      enable: false
      services:
        kofi:
          user: hossainemruz
          text: Tip Me
          textColor: '#f9fafc'
          backgroundColor: '#248aaa'

    # specify whether you want to show Table of Contents in reading page
    toc:
      enable: true

    # Show tags under the post title
    tags:
      enable: true

    # Specify whether to show flag in the language selector. Default is true.
    flags:
      enable: true
      # # If you want to use different country flag for a language, specify them here.
      # flagOverwrites:
      #   - languageCode: en
      #     countryCode: us

    # Enable this to use `embed-pdf` shortcode.
    embedpdf:
      enable: false

    # Enable this to create flowcharts using shortcodes.
    flowchart:
      enable: false
      services:
        # Uncomment for `mermaid` shortcode.
        mermaid:
          # For config options, see: https://mermaid-js.github.io/mermaid/#/Setup?id=configuration
          # theme: dark

    # Enable this to create mathematic expressions using `$$` blocks
    math:
      enable: false
      services:
        # https://katex.org/docs/autorender.html#api for more configurations
        katex:
          delimiters:
            - left: $$
              right: $$
              display: true
            - left: \\[
              right: \\]
              display: true
            - left: $
              right: $
              display: false
            - left: \\(
              right: \\)
              display: false

    # Enable to use custom syntax highlight
    # Please note, Hugo comes with it's own html based syntax highlighter.
    # Your code block will still be syntax highlighted by hugo.
    # For more details: https://gohugo.io/content-management/syntax-highlighting/
    # To disable Hugo's builtin syntax highlight,
    # see: https://gohugo.io/getting-started/configuration-markup#highlight
    # ```
    # # config.yaml
    # markup:
    #   # this disables hugo's syntax highlighting.
    #   codeFences: false
    # ```
    syntaxHighlight:
      enable: true
      services:
        hljs:
          # see: https://highlightjs.readthedocs.io/en/latest/api.html#configure
          noHighlightRe: /^no-highlight$/i

    # Enable to use `video-player` shortcode
    videoPlayer:
      enable: false
      services:
        # convert .js-player class into video player via https://plyr.io/
        # Can play HTML5 Video, Audio, Youtube, Vimeo.
        # For more info on setup: https://github.com/sampotts/plyr#quick-setup
        plyr:
          # options doc: https://github.com/sampotts/plyr#options
          # fullscreen: true

  # Provide footer configuration.
  footer:
    enable: true
    # You can provide your custom footer template using this option.
    # Put your template in "layouts/partials" folder of your repo.
    template: footer.html
    # Show/hide navigation in the footer. Default is "true".
    navigation:
      enable: true
      # show custom menus in the footer
      customMenus: true
    # Show/hide "Contact Me" section in the footer. Default is "true".
    contactMe:
      enable: true
    # Show/hide credentials section in the footer. Default is "true".
    credentials:
      enable: true

    # Show/hide newsletter section in the footer. Default is "true".
    # Currently, it supports "mailchimp".
    newsletter:
      enable: true
      provider: mailchimp
      mailchimpURL: https://github.us1.list-manage.com/subscribe/post?u=19de52a4603135aae97163fd8&id=094a24c76e

    # Show/hide disclaimer notice in the footer. Default is "false".
    disclaimer:
      enable: true

Hi @aq1018, Thank you for your hard work in this PR. Look like lot of changes. I might take some time to finish reviewing. Feel free to work on CSS PR based on this branch. Once, this PR get merged, we can rebase the CSS PR against main branch.

That's the plan! 😄

Hi @hossainemruz I realized that I made a few mistakes on achievements and some other feature toggle related conditionals, I added two more small commits to fix those issues.
P.s. I added  an exampleconfig.yml to reflect updated settings. When testing, you should use that one as a basis.

Okay. This is major change. It may break backward compatibility for existing users. I think we should bump a major version with this change. Feel free to make your changes. Do whatever best for the theme.

Found video-player shortcode wasn't working. fixed.

@hossainemruz p.s. I updated the config.yaml file in top comment. I missed a few flags.

@hossainemruz This PR is ready for review. As well as the CSS bundle #705
Let me know if you need me to change anything. Thanks!

Thank you @aq1018. I have released a new version of the theme with latest changes. This paves the way to merge these PRs. I have started reviewing. It may take few days though.

Hi @aq1018 Can you give me permission to push in this PR?

@hossainemruz thanks for the review. I'll work on it later today.

@ hossainemruz sorry for the long wait. I ended up doing the following:

installed eslint and configured it to use the standard + prettier + no-jquery config.
use that to find errors in code ( had a few missing consts, and some minor issues )
migrated away from jquery with the eslint-config-no-jquery's help.
formatted code with eslint to have a consistent js code style.
rebased to latest main.

I hope you don't mind me adding the standard style guide. If you don't like standard, there is also other popular style guides such as airbnb, google or other standards. For more details please see this article: https://betterprogramming.pub/comparing-the-top-three-style-guides-and-setting-them-up-with-eslint-98ea0d2fc5b7
Lastly, I still haven't had the chance to test it against the example site yet. I will do more testing tomorrow.


Images located with blog posts

I have a problem with my setup. I'm trying to store images alongside my blog posts. Here is my blog config:
activate :blog do |blog|
  # set options on blog
  blog.name = "blog"
  blog.prefix = "blog"
  blog.sources =  "{year}/{month}/{day}/{title}"
  blog.permalink = "{year}/{month}/{day}/{title}"
  blog.layout = "blog_post_layout"
  blog.tag_template = "tag.html"
  blog.summary_separator = /READMORE/
  blog.paginate = true
end

I'm using pretty URLs too.
My permalinks look like this:
/blog/2015/04/07/microservices-for-greenfield/

With a directory structure like this:
/blog/2015/04/07/microservices-for-greenfield.markdown.erb
/blog/2015/04/07/microservices-for-greenfield.markdown/image.jpg

The image displays fine in the blog post. The issue is that the methods to pull back lists of blog posts incorrectly try and pull in images (image.jpg in the above directory example) and process them as text, looking for things like title, date, tag etc.
From digging through the source code it seems that it just blindly pulls back resources from the sitemap, but doesn't do anything to filter out non-textual resources. I can't spot the exact place to make the change, but I think a filter either needs to be applied inside the sitemap or in the appropriate places in blog_data.rb to only select textual resources. I'd take a stab at patching in a fix but before I do that I want to check that I'm not doing something correctly or see if I'm trying to do something that isn't supported right now.

OK, so I just found this issue as I was about to give up in trying to find a fix for the same issue on a site I'm working on. @snewman, did you ever work it out? I really don't want to resort to going to .md.erb just to try to write a custom helper to work around this.
Side note: this completely breaks building a static site for me, because the renders happen in the index pages first, which don't work, and get cached. If I comment out the caching code in the render_individual_file method in core extensions, I get a working blog article page, but of course the index pages are still broken.

I should probably add that I am following the recommendation at https://middlemanapp.com/basics/blogging/#article-subdirectory for Markdown image format.

It's pulling back anything that matches:
blog.sources =  "{year}/{month}/{day}/{title}"

You should make that more specific, for HTML only:
blog.sources =  "{year}/{month}/{day}/{title}.html"

@tdreyno that might be the case for @snewman but it isn't the case with me: My blog.sources has the .html extension already.

@tdreyno A thought: in my case, I am using blog.prefix = 'blog' -- is it possible that when it comes to (for instance) blog/index.html.erb Middleman is using some other means that is broken, which is treating images, etc as sources?
Or is my issue unrelated to @snewman's after all?

So, one last follow-up. It appears that an absolute reference to the source path is properly converted to the destination path no matter where the access occurs from. Doing something like:
/blog/articles/2015/2015-08-13-article-title/image.png
behaves as expected, converting to /blog/2015/08/13/article-title/image.png. It's only when I use 2015-08-13-article-title/image.png from the article itself that it breaks rendering from any page but the article page itself.
This lends some credence to my initial suspicion, which was that the relative path from source was being interpreted based on the location of the file currently being rendered, in the case of rendering a collection from an index page. So I did another test, and that appears to be the case. Modifying the image source to:
articles/2015/2015-08-13-article-title/image.png
causes the render of source/blog/index.html.erb to reference the image correctly, but breaks the article page.
At this point, I'm going to just work around this by using the absolute source path, but this still seems like a bug -- is there no way to ensure that image references be interpreted from the location of the template they're actually written in, and not from a template that is rendering other templates on a collection?
@tdreyno, I'm sorry if this is less than helpful, but I'm afraid that's all the time I have to troubleshoot this for now. :(

fwiw we use a completely different approach @dojo4 : https://gist.github.com/ahoward/fc5b9bd1fea380b91c71

Oh, I see your actual issue, @ernie
Blog "moves" the image assets along to the new article path, but images references in markdown don't point to that new location. I think that's a separate issue. Mind opening a new ticket?

Sure thing!