[1.12] Aluminum/Iridum/NoMansLib-Mithril/AA-Black-Quartz compatibility

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
I setup two Elite Factories, a Enrichment Chamber and a Smelter, the one feeds into the other for basic ore doubling. So the Enrichment Chamber has no issues turning TD Aluminum and Iridum ore into two dust but it chokes at smelting it, the Elite Smelter refuses to accept it to turn them into ingots. The Elite Enrichment Chamber, on the other hand, refuses to take NoManLib's Mithril and Actually Additions Black Quartz Ore. I had to build a Pulverizer / Redstone Furnace setup just for those 4.
Steps to reproduce:

Build an Enrichment Chamber and Smelter
Set them up so the Chamber auto ejects into the Smelter
Put TD Aluminum Ore or Iridum Ore into the Chamber
Watch the Chamber turn them into Pulverized Aluminum or Iridium but then choke as it can't empty into the Smelter.

Version (make sure you are on the latest version before reporting):
Forge: 1.12-<IP_ADDRESS>3
Mekanism: 1.12.1-9.4.318
Other relevant version:
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
[gist/pastebin/etc link here]

Aluminium & Iridium is a COFH issue. They removed the smelting recipe. https://github.com/CoFH/ThermalFoundation/commit/fadde125a175c72e46bbb1ae1ec677f87537d538
Mithril & BQuarts we can probably add to the minor compat list.

Really. How odd. I have TE installed and have been processing TE aluminum and iridium with the pulverizer / redstone furnace for a while now. I upgraded to the Factories as they're faster once I put in all the speed an energy upgrades into them and bump up energy production. Well, nothing you can do about it, I'll go over to their Github and make a posting.

Smelting is apparently Work As Intended (https://github.com/CoFH/Feedback/issues/474).
Mithril and BlackQuarts could be added as @thiakil mentioned.

Yeap, so I posted that to the FTB team, hopefully in a future update of
Unstable 1.12 they will either disable them in favor of other mod aluminum
and iridium or Craft Tweak in smelting recipes. I'd do it myself but I've
never used Craft Tweaker before.
On Aug 14, 2017 11:02 AM, "Tom E"<EMAIL_ADDRESS>wrote:

Smelting is apparently Work As Intended (CoFH/Feedback#474
https://github.com/CoFH/Feedback/issues/474).
Mithril and BlackQuarts could be added as @thiakil
https://github.com/thiakil mentioned.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322263242,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3t8zPz_UGNRX6v8P17A1_x53L2xsks5sYIvDgaJpZM4O14qn
.

Mini crafttweaker tutorial adding smelting recipes:
furnace.addRecipe(output, input, xp);
Example:
furnace.addRecipe(minecraft:speckled_melon, minecraft:melon, 1500);
More info at https://crafttweaker.readthedocs.io/en/latest/Vanilla/Recipes/Recipes_Furnace/

Cool! When I get home I will poke at it. Thanks. :D
On Aug 14, 2017 11:50 AM, "Tom E"<EMAIL_ADDRESS>wrote:

Mini crafttweaker tutorial adding smelting recipes:
furnace.addRecipe(output, input, xp);
Example:
furnace.addRecipe(minecraft:speckled_melon, minecraft:melon, 1500);
More info at https://crafttweaker.readthedocs.io/en/latest/
Vanilla/Recipes/Recipes_Furnace/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322276040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3v8gBWjFF_0n76ZRVt7kf20O9APwks5sYJblgaJpZM4O14qn
.

@thommy101 Do I want to use the Meta's Unlocalized Name? So...
furnace.addRecipe{item.thermalfoundation.material.ingotaluminum, item.thermalfoundation.material.dustAluminum,0.3);
?

You can define the meta data, I know it's defined somewhere on the linked read the docs above ;)

@thommy101 I could, in theory, even add the enrichment chamber recipes, hmm... peers
mods.mekanism:machineblock:0.addrecipe
by the looks of it?

You could, if you're using 1.7 ;) Any version higher than that doesn't support craft/modtweaker yet

Minecraft 1.7? O.o
On Aug 15, 2017 10:49 AM, "Tom E"<EMAIL_ADDRESS>wrote:

You could, if you're using 1.7 ;) Any version higher than that doesn't
support craft/modtweaker yet
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322538733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3p5a5_dbQC3uZtNYkAoGkxG9ODB8ks5sYdo4gaJpZM4O14qn
.

Yea, that old version which isn't supported by us anymore ;) newer versions do not have that support yet..

Oy. Beginning to see why no one includes this in their mod packs. :(
On Aug 15, 2017 11:35 AM, "Tom E"<EMAIL_ADDRESS>wrote:

Yea, that old version which isn't supported by us anymore ;) newer
versions do not have that support yet..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322551030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3rTbv7XbwO4xayMu515TKEo5OSwUks5sYeTwgaJpZM4O14qn
.

Includes what in their packs? External mod support for Craft/MineTweaker has always been done by ModTweaker.
Your best bet for adding smelting recipes would be to use the oredict entries. I think it would be <ore:dustAluminum> for example.

Well, that would not break existing dust to aluminum recipes?
On Aug 15, 2017 5:49 PM, "Xander"<EMAIL_ADDRESS>wrote:

Includes what in their packs? External mod support for Craft/MineTweaker
has always been done by ModTweaker.
Your best bet for adding smelting recipes would be to use the oredict
entries. I think it would be ore:dustAluminum for example.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322628598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3gJKeqHVGtrwH1aigNZSOk-k-ycGks5sYjycgaJpZM4O14qn
.

Wasn't your problem that you didnt have any to begin with?

For TE aluminum since that is what spawned in world. If the FTB team fixes
the spawn settings then it will be some other mod's aluminum.
On Aug 15, 2017 6:08 PM, "Xander"<EMAIL_ADDRESS>wrote:
Wasn't your problem that you didnt have any to begin with?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322632393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3nec3mss_KxybBJrg2JWZqy8pDsrks5sYkEIgaJpZM4O14qn
.

and using oredict in CT will mean it won't matter whose blocks you have

Ok, so
Furnace.addrecipe:(ore:aluminum, ore:dust,.0.3)
?
On Aug 15, 2017 6:13 PM, "Xander"<EMAIL_ADDRESS>wrote:
and using oredict in CT will mean it won't matter whose blocks you have
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322633452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3gu9qEq632EmzFxLQxSfCDMPsb9Yks5sYkJTgaJpZM4O14qn
.

I would suggest reading the wiki, and using the /ct hand command

CT hand? Ok...
On Aug 15, 2017 8:07 PM, "Xander"<EMAIL_ADDRESS>wrote:

I would suggest reading the wiki, and using the /ct hand command
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/4625#issuecomment-322654178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5x3lIgob6wcf56gtfYWR7S8bRAXn2Tks5sYlz6gaJpZM4O14qn
.


Handle tee_stdout.TimeoutExpired with warn() and terminate()

When I run several Sacred jobs in parallel using Ray I run into an error where the experiment first prints that it finished complete successfully, and then crashes with a unhandled subprocess.TimeoutExpired while waiting for tee_stdout to finish.
I don't know why this happens, but it seems like a pretty harmless solution to handle the exception, warn the user, and then terminate the tee subproc forcibly.
Closing the tee forcibly here could lead to some of the captured stdout not making it into Observers, but this is still better than the current behavior for TimeoutExpired, which is to simply exit on error and not terminate.
If it is helpful, then I can try to come up a minimal reproducible example of this error.

The flake8 error is unrelated to these changes. Maybe it's a new error due to a flake8 upgrade, as if we ran flake8 on master right now we would get this error:
flake8 run-test: commands[0] | flake8 sacred
sacred/config/config_scope.py:189:48: E741 ambiguous variable name 'l'
sacred/config/config_scope.py:190:35: E741 ambiguous variable name 'l'

Anyways, I ended renaming l something longer in #737 to avoid this flake8 error.

This seems related to https://github.com/IDSIA/sacred/issues/289
I'd rather get to the bottom of this but given the bug has been open for over a year a workaround like this is not crazy.

Interestingly in my case this is a deterministic fail

I also submitted a PR for this issue here: https://github.com/IDSIA/sacred/pull/718. Also related: https://github.com/IDSIA/sacred/issues/705

@shwang I think you forgot to push the flake8 fix since that test is still failing?
@EspenHa thanks for the link! seems like a similar approach.

Is there a more elegant way to fix this than just taking a shotgun to the tee children? I've run into this problem running multiprocessing with forkserver. It seems like the problem is that forkserver subprocess doesn't shut down until the parent process exits. Hence, tee keeps waiting on output from the forkserver (not the main process) indefinitely, and we get a timeout. There is a hack that will let you shut down the forkserver at the end of your script, thereby allowing Sacred to close the file descriptor used to capture stdout (in Python 3.7+):
def stop_forkserver():
    from multiprocessing.forkserver import _forkserver as _fs
    if hasattr(_fs, '_stop'):
        _fs._stop()  # Python 3.8+
    else:
        # this next bit is copied from Python 3.8's ForkServer._stop()
        # (should work in 3.7, at least on Linux)
        if _fs._forkserver_pid is not None:
            os.close(_fs._forkserver_alive_fd)  # child now dies of its own accord
            os.waitpid(_fs._forkserver_pid, 0)  # reap the child
            os.unlink(_fs._forkserver_address)  # remove IPC channel
            _fs._forkserver_alive_fd = _fs._forkserver_pid = _fs._forkserver_address = None

Of course, the most elegant solution would be one that allows Sacred to stop before all subprocesses exit. Unfortunately I'm not enough of a Unix wizard to say whether that exists. At the very least, I don't see a way to do it while still retaining the current method of redirecting output with tee.

Flake8 is fixed now. This should be passing soon.

Nice! @thequilo could you review?
Not the most elegant solution as @qxcv points out but seems a significant improvement on the current behavior (Sacred failing spuriously on certain systems).

I would prefer a solution to the problem and not killing the processes, but as long as we don't have a good solution, this workaround is fine I think.


Custom transaction validator example

@AlexBrandes @IPadawans Marcin has released 2.6.0 including that change so I think it is mergable.
ation-Labs/tessellation/releases/tag/v2.6.0


[DiffDriveController] Optional tf namespace prefixes instead of using node namespace

Added an additional parameter called tf_frame_prefix that will be appended to the TF frame ID's when set.
It uses underscores instead of '/' to separate the prefix from the ID as discussed in #482.
This allows for other the TF topic itself to be namespaced which is how some other ROS2 packages such as Nav2 do it.

@bobbleballs some form of testing would be nice
also please run pre-commit run --all and commit the changes to fix the format stage

Also please don't remove the auto-assigned reviewers. They are there for a reason. I'll add them back

Codecov Report

Merging #533 (2f473e4) into master (e7f9962) will decrease coverage by 3.50%.
The diff coverage is 26.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   35.78%   32.28%   -3.50%
==========================================
  Files         189        7     -182
  Lines       17570      669   -16901
  Branches    11592      361   -11231
==========================================
- Hits         6287      216    -6071
+ Misses        994      158     -836
+ Partials    10289      295    -9994

Flag
Coverage Δ

unittests
32.28% <26.28%> (-3.50%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ontroller/test/test_load_diff_drive_controller.cpp
12.50% <0.00%> (ø)

diff_drive_controller/src/odometry.cpp
42.16% <11.11%> (ø)

diff_drive_controller/src/speed_limiter.cpp
46.55% <11.11%> (ø)

...ive_controller/test/test_diff_drive_controller.cpp
17.62% <12.08%> (ø)

...troller/include/diff_drive_controller/odometry.hpp
20.00% <20.00%> (ø)

...iff_drive_controller/src/diff_drive_controller.cpp
38.67% <34.80%> (ø)

...de/diff_drive_controller/diff_drive_controller.hpp
100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@bobbleballs some form of testing would be nice
also please run pre-commit run --all and commit the changes to fix the format stage

Cool, I've run pre-commit.
Sorry about the reviewers wasn't sure if they were auto added or I'd done something wrong.
I'll look into adding a test.

Hello, I've been struggling with frame id in TF when I add namespace.
Is there any plan to merge this fix into humble branch? (or backport merging?)

Yeah I think this could be an easy addition to humble. We are waiting for tests.

@destogl @bmagyar Any update on this one?

Thanks for pinging! I'll check this out tomorrow morning


[NOREF] Dev Data refactor + Cypress test updates

No Ticket
Changes and Description

Refactoring dev data to use a pg_dump file.
Introduce scripts/dev db:dump which dumps the database to the file that scripts/dev db:seed restores from.
Fixing cypress tests to not use hard-coded IDs

Cypress tests now also automatically seed the DB

How to test this change
Testing Cypress

scripts/dev up
yarn cypress run

Testing DB Seeding

scripts/dev up
scripts/dev db:seed
Assert that data got seeded correctly

Testing DB Dumping

scripts/dev up
scripts/dev db:seed
Make some modifications to an entry
scripts/dev db:dump
Assert that scripts/data/local-db.sql got modified appropriately

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

I think this is a really great approach and will open up a lot of new opportunities by seeding data in this manner!


using multiple rootCA

Traefik version : 2.2.11
I want to use two separate rootCA for separate IngressRoute
I have created two secrets, web-cert-tls and internal-cert-tls which have tls.crt and tls.key genertaed from two different selfsigned rootCAs
Expectation:
https://  <--- use web-cert-tls
https://internal <-- use internal-cert-tls
Observed:
https://  <--- use internal-cert-tls
https://internal <-- use internal-cert-tls
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: internal-tls
spec:
  entrypoints:
    - websecure
  routes:
  - kind: Rule
    match: PathPrefix(`/internal`)
    middlewares:
    - name: internal-middleware
    services:
    - kind: Service
      name: internal-service
      port: 8000
  tls:
    options:
      name: common-tlsoption
    passthrough: true
    secretName: internal-cert-tls
---
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: internal-middleware
spec:
  stripPrefix:
    prefixes:
    - /internal
 ---
 apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: web-tls
spec:
  entrypoints:
    - websecure
  routes:
  - kind: Rule
    match: PathPrefix(`/`)
    middlewares:
    - name: web-middleware
    services:
    - kind: Service
      name: web-service
      port: 8000
  tls:
    options:
      name: common-tlsoption
    passthrough: true
    secretName: web-cert-tls
---
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: web-middleware
spec:
  stripPrefix:
    prefixes:
    - /
 ---
apiVersion: traefik.containo.us/v1alpha1
kind: TLSOption
metadata:
  name: common-tlsoption
spec:
  clientAuth:
    clientAuthType: NoClientCert
  minVersion: VersionTLS13
  sniStrict: false

I'm not sure this is directly related to Traefik Helm Charts.
You probably should ask over there: https://github.com/traefik/traefik/issues
As a general observation, using passthrough routes, Traefik is not in charge of terminating the TLS connection: your backend is. I'm not sure your tls.secretName is even used.
Have you tried changing those passthrough to false?
Any reason not to re-encrypt the connection? An annotation such as traefik.ingress.kubernetes.io/service.serversscheme: https could do ( https://doc.traefik.io/traefik/routing/providers/kubernetes-ingress/ ), or setting the service scheme in your IngressRoute (https://doc.traefik.io/traefik/routing/providers/kubernetes-crd/#kind-ingressroute ).
Also, I'm wondering how could Traefik rewrite URLs without terminating the TLS connection.
AFAIU, using HTTPS, the TLS handshake results in some common secret being negotiated with the backend serving your connection. In passthrough, Traefik only knows of the SNI that was sent by client when initiating its connection, the rest is between the client and whichever backend was identified. Once TLS handshake is completed, HTTP goes into that encrypted channel: URLs would be encrypted.
Am I missing something? How would that work? Can Traefik read/rewrite URLs without breaking encryption?
Traefik docs doesn't say much about passthrough limitations, though I suspect Middlewares capabilities would be quite limited when used with passthrough.
Better ask to the main Traefik repository, you're more likely to get responses from devs that know about that aspect of Traefik.


Use a threshold for prediction for pairs

A pairs predictor should be able to predict a binary result when given a pair, like a classifier, when we would call the predict function. This could be done by using a threshold and comparing the score of similarity for the pair to this threshold.
TODO:
Also:

[ ] replace score_pairs by a better name like compute_distances (see comment https://github.com/metric-learn/metric-learn/pull/152#issuecomment-453554793)

This threshold could be tuned (e.g. on the training set) so as to achieve a given level of precision

I just raised an issue in scikit-learn for using the CalibratedClassifierCV, see: https://github.com/scikit-learn/scikit-learn/issues/13077


Tag new version with compat bumps

Also add a few github action tweaks.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1b195a2) 98.63% compared to head (e401c58) 98.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   98.63%   98.64%   +0.01%
==========================================
  Files           1        1
  Lines          73       74       +1
==========================================
+ Hits           72       73       +1
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IsUTFDigit accepting some Strings it (IMO) shouldn't

The IsUTFDigit accepts strings which contains non valid Digit character or aren't even valid numbers.
IsUTFDigit accepts:
"-1"
"1-1"
"-"
"--------1"
"1---"
IsUTFDigits rejects:
"+1"
"1+1"
"+"
"+++++++1"
"1+++"
The question here is, what is the intended reaction of the IsUTFDigit function.

I wrote to the author of these functions (Pull Request #21)

Thank you. It seems also that every Is-Function that works on numbers allows "-" but not "+". Like IsFloat("+1.0") return FALSE while IsFloat("1.0") and IsFloat("-1.0") returns TRUE. Same behavior can be found in IsFloat, IsInt, IsUTFNumeric, IsAlphanumeric and IsNumeric.

Thanks again :+1: , it's also mistake on regexps from parent project, I opened new issue here https://github.com/chriso/validator.js/issues/346

Thank you. It seems also that every Is-Function that works on numbers allows "-" but not "+".
Like IsFloat("+1.0") returns FALSE while IsFloat("1.0") and IsFloat("-1.0") return TRUE.
Same behavior can be found in IsFloat, IsInt, IsUTFNumeric, IsAlphanumeric and IsNumeric.

Fixed :smile:

First of all, thanks ^^ IsInt and IsFloat seems to work now just fine. IsInt("+1") returns TRUE as does IsFloat("+1.0").
But now IsNumeric("+1") returns TRUE while IsAlphanumeric("+1"), IsUTFNumeric("+1") and IsUTFDigit("+1") return FALSE
The question is, should every function here return TRUE on "+1" and "-1" or should only IsFloat and  IsInt return TRUE (as '+' and '-' isn't a digit, alpha or numeric character).

If these functions returns true on '-1', I think, that they should return similar answer on '+1'. Plus sign has similar sense as minus sign, IMO. So, if any function works with numbers and returns 'true' in cases with minus sign,  they should return 'true' also in case with plus sign. I made this behaviour just for 'IsInt, IsNumeric and IsFloat', so I agree with you and these functions should be fixed.

Just submitted a pull request correcting the behaviour of UTFDigit and UTFNumeric. Both return true only for -1, 1, +1.

I hope that I can close this issue.


x/tools/gopls: show type errors in other files when the package contains syntax errors

What version of Go are you using (go version)?

$ go version
go version go1.12.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
N/A

What did you do?
I've several times working with govim ran into the fact that an introduced syntax error in one of a package's go files stops diagnostics to be received for other go files inside the same package. Most recently my confusion resulted in an issue in the govim tracker, https://github.com/myitcv/govim/issues/297.
As Paul pointed out in that issue, it might be a good idea for gopls to ignore the files that contains syntax errors and still process other files in the same packages.
What did you expect to see?
Diagnostics for all go files, in the same package, that doesn't contain a syntax error
What did you see instead?
Just the syntax error

Thanks for reporting. You're right - we only show syntax errors when a package contains them, but that can lead to confusing behavior. The solution to this would be to report only syntax errors in the file that contains them, while showing type errors in the other files.

I can see the benefit of this change, but it also seems a bit weird. Since the package is the unit of type checking, you can't really trust the type checker results if there is a syntax error. You can get arbitrary false positive and false negative type checker errors in the package's other files due to the syntax error. For comparison, the compiler doesn't give any type errors if there are syntax errors.
Out of curiosity, why can't we also send type checker errors for the file with the syntax error as well? I assume most of the time the file mostly parses and mostly type checks just fine.

Can you give examples of how a syntax error in one file could trigger false pos/neg type check errors in another?
I use vim, and if I for example have type check errors in several files in a package, they all show up in the error list. As vim gets diagnostics from gopls as I type, the list will be cleared of all errors if I start to declare a new func, and then be populated again when the syntax is complete.
That’s how it works from the user perspective, but I also understand if the package is the unit of type check.

A syntax error often renders all the following code un-type checkable, so false positives would be very common. For example, code in another file calls function foo(), but that function cannot be type checked because of the syntax error (so you get potentially confusing undeclared name: foo error in the other file). False negatives can happen for example if you have a duplicate method that doesn't get type checked due to the syntax error. You should get foo redeclared in this block in the other file, but you won't because of the syntax error.
I imagine this change will be useful on the whole, but I just wanted to point out it could lead to some confusing errors.

@muirrn, you're definitely right that this will lead to some issues. When you don't filter type errors if there is a syntax error, you get a huge amount of "fake" type errors. Maybe we can introduce this setting through an opt-in configuration first, just to make sure it doesn't cause problems?


Problem with access to records via ftp

Hello,
My settings:
disable cloud: true
Recording without cloud: true
Save video when a motion is detected: off
Data is not available via ftp but exist on sd card.
Filesystem           1024-blocks    Used Available Use% Mounted on
/dev/root                 1536      1536         0 100% /
devtmpfs                 30528      1824     28704   6% /dev
/dev/mtdblock3           11776     10404      1372  88% /home
tmpfs                    32768        84     32684   0% /tmp
/dev/mmcblk0p1        31246752   5418656  25828096  17% /tmp/sd
root@yi-d8fc:/tmp/sd/record# ls
2020Y04M17D20H  2020Y10M26D21H  2020Y10M27D02H  2020Y10M27D07H  2020Y10M27D12H
2020Y04M17D22H  2020Y10M26D22H  2020Y10M27D03H  2020Y10M27D08H  2020Y10M27D13H
2020Y10M26D18H  2020Y10M26D23H  2020Y10M27D04H  2020Y10M27D09H  2020Y10M27D14H
2020Y10M26D19H  2020Y10M27D00H  2020Y10M27D05H  2020Y10M27D10H  2020Y10M27D15H
2020Y10M26D20H  2020Y10M27D01H  2020Y10M27D06H  2020Y10M27D11H  tmp.mp4.tmp
It is normal behavior? What I should do to share sd via ftp?

If you want the other ftp clients be able to access videos, you can enable FTP server in configurations -> Advanced

Yes, ftp is enabled and seems to work fine, but share contains only empty 'topfile'. Probably this is /mnt and not contains any other files/folders

You can find the files in /tmp/sd/record

Thank you guys for support. Path was available after setting password and using root user. I used anonymous user earlier and don't have access to dir /tmp/sd/record


Archives - Digital 🙅♀ Born-digital archives 👍

Update the material type from Archives - Digital to Born-digital archives
PR https://github.com/wellcomecollection/catalogue-pipeline/pull/2743
https://github.com/wellcomecollection/catalogue-pipeline/blob/30d43caf86f1cdaf3f8155523b35801a609bfebc/common/internal_model/src/main/scala/weco/catalogue/internal_model/work/Format.scala#L109
https://github.com/wellcomecollection/catalogue-pipeline/blob/30d43caf86f1cdaf3f8155523b35801a609bfebc/pipeline/transformer/transformer_calm/src/main/scala/weco/pipeline/transformer/calm/transformers/CalmFormat.scala#L10

This is unblocked by https://github.com/wellcomecollection/catalogue-pipeline/pull/2745


kill: adds support for numeric signals

With this commit kill command is able to handle numeric
signals as argument
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

@jodh-intel @sboeuf  @dlespiau  Fixed
Thanks

Coverage increased (+1.5%) to 37.192% when pulling 468bebeda740c516dbf1c36897d56bff3f152622 on devimc:topic/fix_kill into 6c019a5c7321311bd85ad3f4627f37595f02984d on clearcontainers:master.

Coverage increased (+1.5%) to 37.192% when pulling 468bebeda740c516dbf1c36897d56bff3f152622 on devimc:topic/fix_kill into 6c019a5c7321311bd85ad3f4627f37595f02984d on clearcontainers:master.

Coverage increased (+1.5%) to 37.192% when pulling 468bebeda740c516dbf1c36897d56bff3f152622 on devimc:topic/fix_kill into 6c019a5c7321311bd85ad3f4627f37595f02984d on clearcontainers:master.

with the list of test cases input in a struct this is:
lgtm

Oh BTW @devimc could you please rebase recent changes from github.com/clearcontainers/runtime:origin/master so that Semaphore CI build can pass.

Coverage increased (+1.5%) to 37.192% when pulling 317828df3d28e703c3ab58dd35c86b84d88848c7 on devimc:topic/fix_kill into 6c019a5c7321311bd85ad3f4627f37595f02984d on clearcontainers:master.

Coverage increased (+1.5%) to 37.192% when pulling 6f51ef2e2fa8c5e4742517b0efa61fa04fd617d7 on devimc:topic/fix_kill into 6c019a5c7321311bd85ad3f4627f37595f02984d on clearcontainers:master.

@dlespiau  @sboeuf  fixed

\o/

Coverage increased (+1.5%) to 37.192% when pulling 08db9ff469e90b4cf7005b299cb7465be2cc04d0 on devimc:topic/fix_kill into 79541cd77a0b886dee30a487f0a9147d32982245 on clearcontainers:master.


Add a package.json to load the project with NPM

Great!
npm publish, please!

I've added this to the new 2.0 version. Thanks.


Fix a broken link in docs

Fixes
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

Short description of what this PR does:

Improves the documentation

If you have questions, please send an email to SendGrid, or file a Github Issue in this repository.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @salah3x,
Do you mind re-opening this one so that I may merge it? Thanks!

Hi @thinkingserious
Couldn't reopen because I've accidentally deleted the fork so I created another PR #923


UI (almost) endlessly reloads, when running containerized from Kubernetes cluster of several pods

Description of the bug
Despite one of the Quarkus advantages is to deploy and run natively in cloud applications packaged as containerized Docker image, it appears that the Vaadin integration of Quarkus and/or this starter sample is not ready for this purpose.
Indeed, whereas there is no issue when running it packaged as Docker image deployed to a single-pod/replica Kubernetes cluster, if it's deployed to a multi-pods/replicas one, the UI (almost) endlessly reloads so that it's obviously not usable at all.
"almost" means that, sometimes, the reload loop stopped and the last load completes fine.
Expected behavior
UI should be usable and loads fine, without such endlessly reloading, whatever the number of pods/replicas of the Kubernetes cluster, like it's the case for just 1:
Deploy directly and quickly on Okteto 🟢 working Dockerized sample (1-dockerized-pod branch of my fork):
Minimal reproducible example
Deploy directly and quickly on Okteto 🔴 failing Dockerized sample (2-dockerized-pods branch of my fork):
Versions

Vaadin / Flow version: 22+
Quarkus version: Quarkus 2+

My quick guess is that the ingress/loadbalancer in your K8s clusters needs to be configured for session affinity aka sticky sessions. This is what start.vaadin.com generates for Spring Boot apps, something similar might work in your setup (I have never used Okteto).
apiVersion: v1
kind: Service
metadata:
  name: myapp-balancer
spec:
  selector:
    app: myapp
  ports:
    - protocol: TCP
      port: 8000 # The port to expose to the outside
      targetPort: 8080 # The port the application is running on in the pods
  type: LoadBalancer
  sessionAffinity: ClientIP

Unfortunately, the change you suggested seems to not fix the issue.
I initially didn't think, indeed, of the Docker/Kubernetes files provided by SpringBoot-based skeletons created on start.vaadin.com.
As they are generated from vaadin/skeleton-starter-flow-spring template, I forked it and just adapted the Docker/Kubernetes files for a deployment to Okteto (like I did here for the Vaadin-Quarkus)
So that, at the end, the issue root cause seems more general and not only related to Quarkus or Spring Boot support.
By the way, do you think I should then open issue on the main Vaadin Flow repository?
Here below are URLs serving UIs showing this wrong behaviour, and whether it's within:

vaadin-quarkus sample: https://vaadin-quarkus-cernier.cloud.okteto.net, which has been loaded with my 2-dockerized-pods branch of my fork of vaadin/base-starter-flow-quarkus (you can deploy to your own Okteto namespace from it)
vaadin-spring sample: https://vaadin-spring-cernier.cloud.okteto.net, which has been loaded with my [2-dockerized-pods branch of my fork of vaadin/skeleton-starter-flow-spring (you can deploy to your own Okteto namespace from it)

Okteto is just a platform allowing to deploy easily to a Kubernetes cluster in the cloud, especially for basic testing purpose with a free pricing.
If you prefer a reproducer on another platform(s), feel free to tell me, I will adapt also to it (them).

No need to create a separate issue, the team can move the issue to Flow repository if they find some issue to work with from here.
I still believe this is an issue in cluster configuration. I quickly used browser inspector and curl against your deployments and it looks like the session cookie changes on every request, even if you provided the session cookie that the server provides in previous request. So either the request goes to a different node on each request (round robin instead of session affinity) or the cookie is dropped by the front proxy.

Here is the output with curl. With properly working setup, the second request shouldn't set the cookie anymore:
mstahv@MatinPikkuRakkine ~ % curl --head https://vaadin-quarkus-cernier.cloud.okteto.net
HTTP/2 200
date: Fri, 18 Feb 2022 08:49:31 GMT
content-type: text/html;charset=utf-8
content-length: 821
set-cookie: JSESSIONID=ngNZQD8kQeravD89N05muhOn0YweOEbROj5dvDPB; path=/
set-cookie: csrfToken=ce5a9570-742e-4679-b285-aa31d292197e; path=/
strict-transport-security: max-age=15724800; includeSubDomains

mstahv@MatinPikkuRakkine ~ % curl --cookie "JSESSIONID=ngNZQD8kQeravD89N05muhOn0YweOEbROj5dvDPB; path=/" --head https://vaadin-quarkus-cernier.cloud.okteto.net
HTTP/2 200
date: Fri, 18 Feb 2022 08:50:02 GMT
content-type: text/html;charset=utf-8
content-length: 821
set-cookie: JSESSIONID=RRUsHVyMzKk2g-sVmbtGpdJRWaizTxYR4nAPUJlA; path=/
set-cookie: csrfToken=36aaa8fd-ad07-458a-ae38-d436373da211; path=/
strict-transport-security: max-age=15724800; includeSubDomains

Yeah, it is round robin. If you make a third request with the initially returned cookie, then it works, but naturally browser then thinks that the session is expired and reloads.

My K8s skills are not at top level, I'll ask if some of our experts could some time to build a working setup for Okteto.


[Bug report] : Prevent page reload when navigating from "empty favourites page"

Describe the bug
When a user goes to their favourites and finds no favourite items, they have the option to click on the "Find your favourite restaurants now" arrow, which should take them to the home page. However, the problem is that clicking on this arrow triggers a page reload. This page reload is unnecessary and can be a suboptimal user experience.
Expected behaviour
When the user clicks on the "Find your favourite restaurants now" arrow from the empty favorites page, the application should navigate to the home page without triggering a full page reload.
Screenshots

Additional context
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct

i am working on this issue @Anandsg


As a user, I would like the recipient selected when I click Edit in the Error Notifications settings area to be the same one that I see in View mode

Included in production release version 3.30


Add team/lifecycle label to all PRs

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
none

/assign @mrIncompetent

/lgtm
/approve

/retest


NRDB attribute limit check can fill the disk with logs if the values are too big (even when verbose is disabled) | Expose sensitive data

We are logging the attribute truncate messages with warnings which can cause the log file to grow a lot when the values truncated are big.
I propose to evaluate if the log level should be changed or if we should log them just one time.
https://newrelic.atlassian.net/jira/software/c/projects/GTSE/boards/1186?modal=detail&selectedIssue=GTSE-12808
	if truncated {
		aclog.
			WithField("entity_key", entityKey.String()).
			WithField("length", metric.NRDBLimit).
			WithField("original", origValue).
			WithField("truncated", fmt.Sprintf("+%v", event)).
			Warn("event truncated to NRDB limit")
	}

Also, this can leak sensitive data.

This is still logged as warning, should probably be moved to debug.


[Bug]:  Tailwind breaks completely  after adding shadcn

Describe the bug
My whole app was working fine till i wanted to add this library which broke the Tailwind of the application.

Affected component/components
Button
How to reproduce
...
Codesandbox/StackBlitz link
.
Logs
.

System Info
Vite app

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Can you try making the rsc to false in components.json file as it only works in Next.js application. Then remove the previous components and add them again. Not really sure it will solve the problem but that configuration is wrong.

didn't helped

Hi, @ImamJanjua So you can resolve this by importing [import 'tailwindcss/tailwind.css'] in your main.jsx I am not sure about in vite but in nextjs you can import in layout.ts or layout.js.

It would be helpful to get a repo or sandbox link if the issue is still not resolved.

Hi, @ImamJanjua So you can resolve this by importing [import 'tailwindcss/tailwind.css'] in your main.jsx I am not sure about in vite but in nextjs you can import in layout.ts or layout.js.

It works, but than tailwind config don't work correctly since its than not using the the dependent styles from index.css


Correction for raw affiliation Glass Mechanics Department, IPR, UMR 6251, University of Rennes 1 , Campus de Beaulieu, 35042 Rennes Cedex, France

Correction needed for raw affiliation Glass Mechanics Department, IPR, UMR 6251, University of Rennes 1 , Campus de Beaulieu, 35042 Rennes Cedex, France
raw_affiliation_name: Glass Mechanics Department, IPR, UMR 6251, University of Rennes 1 , Campus de Beaulieu, 35042 Rennes Cedex, France
new_rors: 015m7wh34;022b0h879
previous_rors: 015m7wh34
works_examples: W4383342772
contact: 560293fb361a34ff7ae6803cbb54a747:d632cf8a489d55c49e88b31a43968dbd @ univ-rennes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Cypress/E2E: Fixed some guest account specs TM4J keys

Summary

Added keys and separated some tests to match TM4J

Ticket Link
NA

I won't have time to make further enhancements this week so I just reverted the problem ones for now.

I won't have time to make further enhancements this week so I just reverted the problem ones for now.

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.


fix: Updated build and build:linux to specify -t for 22.2.0

Follow up from #54

i will get a release out by monday.

@bmacnaughton I see the 4.2.0 tag failed, was that something I did? let me know how i can help

if you have an m1 mac, you can try to debug it. i don't. when one of the guys here that has an m1 mac has a chance to get to it, we'll hopefully make some progress.
it looks like a problem with the version of the c++ compiler version. i'm guessing it changed when github actions starting using m1 images for macos-latest.

I have a mac m1. I'll put it on my list to look into over the next few weeks

I have a mac m1. I'll put it on my list to look into over the next few weeks

Finally got a chance to dig in and fix the mac build--this is finally deployed!

I have a mac m1. I'll put it on my list to look into over the next few weeks

Finally got a chance to dig in and fix the mac build--this is finally deployed!

Thanks Griff 🤜🏻


[WIP] Extension system for antigen

Provides an extension load mechanism for loading custom code that extends antigen.
This is different than plugins or themes in a way that it actually interacts with
antigen as it can hook into different antigen commands and internal/private functions.
It provides pre- and post- hooks for any function (currently even outside antigen). Effectively
executing the pre-function, the function itself and a post-function.
It doesn't short-circuit (meaning it will always call all hooks and the actual command/function).
Usage:
  antigen ext ext-name # loads (ie, sources) the given extension from $ADOTDIR/ext/

These are only meant to be run inside extension definitions:
  # overwrites 'any-antigen-function' (ex, antigen-bundle) with 'extension-hook-function'
  # which could be any function already defined.
  # it can hook into pre- or post- events. defaults to pre-.
  -ext-hook "any-antigen-function" "extension-hook-function" ["pre"|"post"]

  # defined a new autocompletion for the antigen command (ex, antigen logger)
  -ext-compadd "extension-auto-completion"

The hooks functions receives the same arguments the original function receives.
Also added ext/antigen-logger.zsh and ext/antigen-stats.zsh which are only sample extensions that provides a logging for bundles (antigen-logger) and kind-of stats as described here. These extensions are not meant to be shipped in the code base just samples for anyone who want's to try this PR out.
Example .zshrc configuration:
export ADOTDIR=$HOME/.antigen                # path to antigen
export _EXT_LOGGING_ENABLED=false
source $ADOTDIR/antigen.zsh
source $HOME/.antigenrc

Example .antigenrc configuration:
antigen ext antigen-logger
antigen ext antigen-stats
antigen bundle zsh-users/zsh-syntax-highlighting
antigen apply

All feedback is welcomed.
TODO

[ ] Use antigen-bundle to load extensions (if ext is not built-in)
[ ] Move antigen-logger and antigen-stats to it's own repos
[ ] Add tests

It seems there is no tracking for this feature so I'm going to close this PR for now.


Kotlin 1.8.10 and friends

Zipline is compatible. Molecule 0.8.0 is out with Kotlin 1.8.10 support. I'll leave this to you to decide when to merge and upgrade all the internal things.

I think we were thinking of waiting until 1.8.20 to update, though I'm not opposed to updating to 1.8.10 as part of the next internal Treehouse release. 1.8.10 does seems like a minor jump from 1.8.0. @swankjesse what do you think - should we just wait for 1.8.20?

Yeah there's little reason to wait. It'll take weeks for a 1.8.20-compatible JB Compose just as it did for this one. By then there will probably be a 1.9.0 beta and the cycle will continue.

Agreed - waiting for 1.8.20 could take a while.


feature: set kafka multiaz attribute depending on instance type

Description
Related to https://issues.redhat.com/browse/MGDSTRM-8264.
When registering a Kafka instance, set the MultiAZ attribute for that instance depending on the instance type.
The explained reason found on the related issue on why we need to do this is:
It has been found that incoming requests to control plane are set to multi-AZ by default regardless of instance types. UI plan to not send AZ value. Control plane needs to assign the correct AZ value based on instance type.

There were two possible places on where to implement this logic:

In the RegisterKafkaJob method, which is where this PR has implemented it
In the Kafka create handler

The first place has been chosen due to in the case of the kafka create CLI subcommand the RegisterKafkaJob method is called without going through the Kafka create handler.
The reason on why to do this
Verification Steps

Create a kafka standard instance and verify that multiaz is set to true
Create a kafka eval instance and verify that multiaz is set to false
Try to create a kafka standard instance with multiaz set to false and verify that an error is returned
Try to create a kafka eval instance with multiaz set to true and verify that an error is returned

Go to XX >> YY >> SS
Create a new item N with the info X
Try to edit this item
Check if in the left menu the feature X is not so long present.

If manual verifications required, please provide an environment where the reviewers can easily validate the changes if possible to speed up the review process.
-->
Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has created for changes required on the client side

This PR has been implemented based on the original request and the original justification on why this needs to be done.
However I think we should discuss how do we want to go forward with this, as implementing this leads to some implications that create some inconsistencies:
With this changes we now set the MultiAZ value based on the instance type. However, multi_az attribute is a field that we have at OpenAPI level for the kafka_request. Why having that field at all if it is totally ignored now?
Why can't the UI set the MultiAZ field from their side?
Do we really want to tie the MultiAZ value to the instance type? This means that an instance type will only support either MultiAZ or non MultiAZ but not both at the same time.

With this changes we now set the MultiAZ value based on the instance type. However, multi_az attribute is a field that we have at OpenAPI level for the kafka_request. Why having that field at all if it is totally ignored now?

+1. Furthermore I think with what we have here, the check https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/e0da31b2ffe016dd6d677af0d05fdaa43afe1f77/pkg/handlers/validation.go#L78 will also go away.

Do we really want to tie the MultiAZ value to the instance type? This means that an instance type will only support either MultiAZ or non MultiAZ but not both at the same time.

+1. Better to get clarification on this. Maybe @pb82 might have some additional context.

@machi1990 @miguelsorianod at present it's Ok and confirmed by BU to tie the value of multi-az to the instance type. There are currently no plans to allow multi-az dev instances (or other combinations). This might get re-evaluated in the future, but likely not soon. And then we have a few options, like adding multi-az to the plan definition (or re-introducing the field).
As for deprecating instead of removing: I think that's just following the deprecation policy. After some time (3 months?) we can also remove it.

@machi1990 @miguelsorianod at present it's Ok and confirmed by BU to tie the value of multi-az to the instance type. There are currently no plans to allow multi-az dev instances (or other combinations). This might get re-evaluated in the future, but likely not soon. And then we have a few options, like adding multi-az to the plan definition (or re-introducing the field).
As for deprecating instead of removing: I think that's just following the deprecation policy. After some time (3 months?) we can also remove it.

Thanks @pb82
Then +1 on deprecating the multi_az from the Kafka Request payload during creation.
This field should still be returned on response body and shouldn't be deprecated there. We also do not need to validate for it in https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/e0da31b2ffe016dd6d677af0d05fdaa43afe1f77/pkg/handlers/validation.go#L78

yes agree @machi1990

We also do not need to validate for it in

Are you sure we don't need to? even if it is deprecated users might still be setting it so I think it is a good safeguard

We also do not need to validate for it in

Are you sure we don't need to?

Yes

even if it is deprecated users might still be setting it

Setting shouldn't have any effect as the value passed in the payload shouldn't be used at all

...so I think it is a good safeguard

I do not think it is a safeguard worth keeeping if the value is not used anymore going forward.
Also imagine a user setting it for a developer plan:

they first try to set multi_az to false, the check fails saying that multi_az is not supported
the change their request this time setting mutli_az to true, we validate against it (at this point the user expects that the multi_az to be true) but when their kafka request has been accepted, the multi_az is returned as false due to https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/953/files#diff-f876d2c0a69be46c37a7a608a4d1847036dfe692b7648b4cfef180936dcdbc18R356. At this point as a user I'll be lost.

Thus why I think it is best, to deprecate the field in the Kafka Request creation payload. And add a description saying that "...field deprecated and if passed it won't be considered. The API automatically determines this value from the plan attribute"

Also imagine a user setting it for a developer plan:
* they first try to set multi_az to false, the check fails saying that multi_az is not supported

* the change their request this time setting mutli_az to true, we validate against it (at this point the user expects that the multi_az to be `true`) but when their kafka request has been accepted, the `multi_az` is returned as false due to https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/953/files#diff-f876d2c0a69be46c37a7a608a4d1847036dfe692b7648b4cfef180936dcdbc18R356. At this point as a user I'll be lost.

The first point is not correct though right? If a user tries to create a kafka with developer plan and multi_az set to false that will not fail, as developer instances are non multi-az.
And in the second case the request would fail, as we would want

@pb82 @machi1990 ready for review


[BUG] UE5.4-1.1.2(.tar.gz/.zip) contain wrong content

UE Version:
UE 5.4
Frontend Version:
UE5.4-1.1.2
Problem component
Whole source code
Description
Using Engine/Plugins/Media/PixelStreaming/Resources/WebServers/get_ps_servers.(bat|sh) reconfigured to EpicGamesExt/PixelStreamingInfrastructure in UE5.4.x tags leads to the archives UE5.4-1.1.2.tar.gz and UE5.4-1.1.2.zip in Releases/UE5.4-1.1.2, which contain outdated code, most probably UE5.4-1.0.0. The 'Source code' archives are fine.
Steps to Reproduce:

Clone UE 5.4.x

cd Engine/Plugins/Media/PixelStreaming/Resources/WebServers/
#./get_ps_servers.bat # Windows
./get_ps_servers.sh # Linux

or download UE5.4-1.1.2.tar.gz or UE5.4-1.1.2.zip directly and compare with UE5.4-1.1.2 and UE5.4-1.0.0...1.0.1.

Missing folders: i.e. Common, SS_Test, Signalling.
Outdated CHANGELOG.md

Expected behavior

I'd expect UE5.4-1.1.2.tar.gz and UE5.4-1.1.2.zip to be build versions of tags/UE5.4-1.1.2.tar.gz and tags/UE5.4-1.1.2.zip.

Screenshots

Platform:

OS: all
Browser: independent
Version: all

Hi @PhDittmann,
Good catch!
This was actually impacting all our releases and tags it turns out.
The fix to our workflow is here: https://github.com/EpicGamesExt/PixelStreamingInfrastructure/commit/96980c2225b1b4bc612a7d28c1aefffc59eec118#diff-370235e4175e2c8cac03f0508bf0803c83cd736ec8e2e22eab4ef486c8139bf7R85
Basically, our Github Action was using the latest commit from master branch always, even if we were making a release for another branch, say UE5.4.
I have gone through this repo and corrected all the old tags and releases to match their proper commit and have the proper source code in them. I can't do this for the old PSInfra repo though as it is archived.
One thing I will correct (that you will now see in the releases too), if you are using a 5.4 release you won't see the directories

Missing folders: i.e. Common, SS_Test, Signalling.

As these were only added in the 5.5 branch and master is tracking 5.5 now that 5.4 has shipped. If you want to work using those new components you will need to use the 5.5 releases.

Hi @lukehb,
thanks for the quick fix! I don't use the new components, but for identifying, that the build archives differ the source archives.


Updated paths in snakefile and added config file from main

I believe that I do not have "write access" to this repository, which makes me unable to merge this pull request.

@EmiFej - I've give you write access to this and the other OSeMBE repos


ErrorException: Trying to get property 'id' of non-object

Hello there,
going to http://localhost:8000/admin before login I get:
ErrorException
Trying to get property 'id' of non-object
at line 13 in file \vendor\rezaamini-ir\laravel-easypanel\src\Http\Middleware\isAdmin.php
Thank you

It's because you need to login as an user and you have not!

It's because you need to login as an user and you have not!

Hello,
let me explain better.
If you try to go directly to http://localhost:8000/admin before login, you get an ErrorException.
To get a better answer from server what do you think to modify \vendor\rezaamini-ir\laravel-easypanel\src\Http\Middleware\isAdmin.php
from
public function handle($request, Closure $next)
{
if(!AuthFacade::checkIsAdmin(auth()->user()->id)){
return redirect(config('easy_panel.redirect_unauthorized'));
}
return $next($request);
}
to
public function handle($request, Closure $next)
{
if(!Auth::check()) {
return redirect('login');
}else{
if(!AuthFacade::checkIsAdmin(auth()->user()->id)){
return redirect(config('easy_panel.redirect_unauthorized'));
}
}
return $next($request);
}


Can you publish a new version to npm so that i can use it with eslint-define-config

And maybe we also need something like changelogithub with bumpp

ok.

Ok, I will publish 0.5.4 to NPM.

And maybe we also need something like changelogithub with bumpp

I'll do some research and see what I can use.

Continue in #42.


Fixes for current pip

I'll be using blueyed/fixes-for-pip now and if I don't report any problems here, then the branch works fine for me and it's a +1 to merge :)

Thanks!


Fkm nonlinear

PR to trigger CI

Document classes and/or modules with sphinx

@maierbn Can you please reissue the PR and assign me as a reviewer?
Thanks


ImagePicker not working on iOS 11

Hello,
I have been successfully developing with the ImagePicker plugin up until recently, with what I believe to be the iOS11 update. Android is still working fine.
From what I can gather the .getPictures() function is not firing and no errors are shown in the console. The native iOS image picker is not launched at all nor is the request for access.
I am happy to explain further, I just wanted to initially check if this was an iOS11 issue or if others are not experiencing this, its probably something in my code.

I guess no one is maintaining this plugin any longer, I encountered an issue with iOS11 too (not same as yours)

I managed to fix it at the moment by removing the ios platform and reinstalling. Also added the permissions as described in the iOS quirks section of Camera plugin: https://github.com/apache/cordova-plugin-camera.
Hope this helps!

@lcoppinger I suddently have to update my ionic1 app, an on iOS 11 imagepicker didnt work.
I already have the iOS quirks added in info.plist:
<key>NSPhotoLibraryUsageDescription</key>
<string>Please allow to save to photo album.</string>
<key>NSCameraUsageDescription</key>
<string>Please allow to access the device camera.</string>

The funny thing is that if i go homescreen and go back to the app the request permission for photo album appears and then it works.
Thats quite serious. How did you make sure the permission pops up immediately (ontop) and not in the background ?
This is how I call imagepicker on ionic1
$cordovaImagePicker.getPictures(options)
.then(function (results) {


Add support for all caps boolean values

Builds fail When running in XCode CI because the environment has CI=TRUE

Updated @ctavan

Is it possible to merge this and release a new version?

@ctavan Want to merge and cut a new release?

@ctavan Want to merge and cut a new release?

@ctavan , @stephenlacy maybe please do not merge this pull request yet.
The change is very good. And it still won't work for the stack trace as demonstrated by @fdstevex in the following link:
https://github.com/expo/expo/issues/33486
Notice how the current fix is on the bool: function(value) function, when the stack trace shown here suggests it is (also) required in the boolish: function(value) method:
Error: GetEnv.NoBoolean: TRUE is not a boolean.
at Object.boolish (/Users/stevex/src/cloudmd/kiimobile/node_modules/getenv/index.js:70:15)
at /Users/stevex/src/cloudmd/kiimobile/node_modules/getenv/index.js:84:27
at Env.CI (/Users/stevex/src/cloudmd/kiimobile/node_modules/@expo/cli/src/utils/env.ts:40:19)

I too was running into this same issue.
I was able to get the build to Xcode Cloud to work only after patching the getenv module with an additional (and very similar) fix that @stephenlacy used - but in the boolish function.
Notice that the env.ts file indicated in the stack trace above calls boolish at that line number for 'CI', not bool.
I verified that the following fix, where I commented-out two lines and added the revised lines right after them, worked in the Xcode cloud:
  boolish: function(value) {
    try {
      return convert.bool(value);
    } catch (err) {

      // REPLACED: const isBool = value === '1' || value === '0';
      const isBool = (value || '').toLowerCase() === 'true' || (value || '').toLowerCase() === 'false' || value === '1' || value === '0';

      if (!isBool) {
        throw new Error('GetEnv.NoBoolean: ' + value + ' is not a boolean.');
      }

      // REPLACED: return value === '1';
      return (value || '').toLowerCase() === 'true' || value === '1';

    }

@nkat2112 boolish calls bool first, if that fails it continues with the numeral character check. https://github.com/ctavan/node-getenv/blob/5b02feebde5d8edd56fff7d81c4b43403a20aff8/index.js#L65
Can you confirm that your first patch actually was applied before adding the second patch? If the first fails for a different reason it would throw at boolish

@stephenlacy , I thought I did, but upon review, I messed up! Please ignore my comment and proceed with the pull request! I'm so sorry. Well done, by the way!
CC: @ctavan


Add multiplex transport

This transport allows you to listen to as many transports as you want simultaneously.
Use it like this:

isn't this more like a fallback-transport?
this is not for websockets and regular sockets at the same time, correct? it would only use webgl if available and websockets otherwise?

this transport does not care what it is multiplexing.   It could be tcp and steam,   it could be websocket, ignorance and tcp,   it could be any other transport combination

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Elixir error

Kata: https://www.codewars.com/kata/is-my-friend-cheating/elixir.
@hencethus published a post on CW this morning about this kata:
................................
=INFO REPORT==== 1-Jul-2016::02:07:26 ===
application: logger
exited: {{shutdown,{failed_to_start_child,'Elixir.GenEvent',undef}},
{'Elixir.Logger.App',start,[normal,[]]}}
type: temporary
RemovenbTest
remov_nb
Test Passed
random
Finished!
Test Passed
fixture:44: warning: random:uniform/1: the 'random' module is deprecated; use the 'rand' module instead
fixture:70: warning: random:seed/1: the 'random' module is deprecated; use the 'rand' module instead
2 Passed
0 Failed
0 Errors
Process took 1191ms to complete

Tests pass, but still fails.
................................
I replaced "random" by "rand" but now when trying the kata I get:
=INFO REPORT==== 1-Jul-2016::06:52:32 ===
application: logger
exited: {{shutdown,{failed_to_start_child,'Elixir.GenEvent',undef}},
{'Elixir.Logger.App',start,[normal,[]]}}
type: temporary

Did you make changes at Elixir or at OTP? On CW Elixir is '1.2.4'. Elixir is now 1.2.5 and even 1.3.1. Are you using OTP 18 or 19?

It seems that all Elixir katas are concerned by:
=INFO REPORT==== 1-Jul-2016::06:52:32 ===
application: logger
exited: {{shutdown,{failed_to_start_child,'Elixir.GenEvent',undef}},
{'Elixir.Logger.App',start,[normal,[]]}}
type: temporary

Yeah it looks like OTP 19 got set since a specific version was not specified in the Docker file. I'm working on a new image and will have it deployed soon.

Might it be better to keep OTP 19 and to avoid - if possible - the warnings since they prevent the users to pass their katas despite a working code.

I would love to keep OTP 19 (especially since I'm having problems getting a properly installed OTP 18 installed and working correctly). However I'm not experienced with either Elixir or Erlang and have so far failed at figuring out how to suppress the warnings. Any ideas?

I'm reverting to an older image that does not have these changes. It doesn't look like there is a relevant code change since then that should affect Elixir. Obviously until the image on the CLI project can get fixed, any additional updates to the runner will not propagate to elixir since the image is now frozen (along with the Haskell image for the same reasons)

Yes might be good to revert to an older image but now that I have made (minor) changes for some Elixir katas (rand module instead of randommodule which is now deprecated with (I think?) OTP 19 , hence suppression of random:seed which was not anymore needed) what about these changes? I would like to help you but I am not an expert in the depth of Elixir or Erlang and I don't know how to suppress the warnings:-(

I just deployed so you can go ahead and check your kata if they need to be reverted. Ideally the current OTP 18 & Elixir 1.2.4 image will get updated to work with those versions, so that we can continue to support older kata, and then newer versions are supported either on the same image or a separate one - so that both versions can be supported within CW at the same time.
Hopefully some additional OS contributions will be made by someone to the CLI project to help get us there, in the meantime this should hold us over.

Thanks a lot for your wonderfull work!


⚠ Processors has degraded performance

In fa6d176, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 94 ms

Resolved: Processors performance has improved in 35f0681.


Gitter outage causing failure on PowerShell-CI-static-analysis

A Gitter outage on 2019-12-26 is causing a test on the PowerShell-CI-static-analysis pipeline to fail:

2019-12-27T00:53:00.2202932Z [-] https://gitter.im/PowerShell/PowerShell?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge should work 269.56s
2019-12-27T00:53:00.2787888Z RuntimeException: retry of URL failed with error: Response status code does not indicate success: 504 (GATEWAY_TIMEOUT).
2019-12-27T00:53:00.2790901Z at , /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 117

Opened #11438 to aid diagnosis in future.

To fix this, we should add error 504 (Gateway Timeout) to allowedFailures.

It is common issue with gitter PowerShell room.


A* disable crossing via diagonal corners

Is it possible? Title says all.

Yes, see for example https://github.com/Sahnvour/PathFinder/blob/master/examples/image.cpp#L138 .
In these loops, for each pixel we look at its (up to) 9 neighbours and add them as children, ie. accessible nodes.
If you don't want to allow moving in diagonal, just add the up/down and left/right neighbours.


[HyperNova] Rework the API to be NIMFS-centric

This can be 1/N tasks about API improvement. In particular, the idea is to fix the foundations of the library to a Nimfs object which will contain:

The MLE(CCS.M) (and we'll see if the CCS.Matrixes are even needed).
An LCCCS instance which references the MLE's of the parent object that holds it.
A set of functions that allows the NIMFS to perform the folding as well as to prepare new inputs for the folding process.

Aside from that, the idea is to get ridd of the Shape, Instance, and witness objects and istead work with arrays directly or, even, SparsePolynomial/SparseVec primitives as suggested in #21.
There's also a bunch of API suggestions in the current hypernova branch marked with XXX across the repo.

Closed via #41


build(webpack): support browsers and node

Summary
Update webpack config to support umd build for both browsers and node
Related Issues or PRs
closes #380
How To Test
Create the file ssr.js in the root of the react-uswds project
const react = require('react')
const domServer = require('react-dom/server')
const uswds = require('./lib')

const TagFactory = react.createFactory(uswds.Tag)
const app = domServer.renderToString(TagFactory())
console.log(app)

yarn build
NODE_ENV=production node ssr.js

Screenshots (optional)

LGTM - following testing instructions. @ahobson you also checked it against the scenario described in #380 correct?

I did.  I'll update that ticket with instructions after I merge


fix: version break line

remove empty break line.
client          version :v0.5.1

server release  version :v1.22.9
default bundle  version :0.10.0

Currently, there are two break lines, as the VERSION file has two '\n'.

/lgtm,
could you please take a look? @qiujian16

/lgtm
could you please take a look? @qiujian16

/approve


Respect auto commit settings while consuming batches

The following code reads all messages on topic role and commits them, despite the disabled auto commit option.
const consumer = new NConsumer(null, {
  logger: {
    debug: msg => console.log(msg),
    info: msg => console.log(msg),
    warn: msg => console.log(msg),
    error: msg => console.log(msg)
  },
  noptions: {
    'metadata.broker.list': config.get('kafka.connectionString'),
    'group.id': `${config.get('kafka.groupIdPrefix')}-test-consumer`,
    'enable.auto.commit': false
  },
  tconf: {
    'auto.offset.reset': 'earliest'
  }
})

consumer.connect(false)
  .then(() => consumer.addSubscriptions(['role']))
  .then(() => {
    consumer.consume((message, cb) => {
      console.log(message)
      cb()
    })
  })

This PR fixes this, committing only if auto commit is enabled! With this PR, the code above does not commit any messages, as expected!

Committing in "1:n" mode is actually aimed for, even if "enable.auto.commit" is disabled.
As batch mode is actually build for enable exactly once delivery and seen as a different mode, compared to: manual commit and auto commit.
When using (or not using) auto.commit we currently expect to use the non batch mode via:
consumer.consume(); //<- no cb here
consumer.on("message" => {});

I am not 100% sure yet if its a good idea to move manual committing into batch mode.
Alternatively we could throw an error if batch mode is used with "enable.auto.commit": false

Alright, I'm gonna give the none batch mode a try and see if it fullfills
our requirements. In any case an exception, a warning or at least a comment
in the method's description to show the developer's intent would be nice to
my opinion. :)
On Thu, 23 Nov 2017, 15:49 Christian Fröhlingsdorf, <
<EMAIL_ADDRESS>wrote:

Committing in "1:n" mode is actually aimed for, even if
"enable.auto.commit" is disabled.
As batch mode is actually build for enable exactly once delivery and seen
as a different mode, compared to: manual commit and auto commit.
When using (or not using) auto.commit we currently expect to use the non
batch mode via:
consumer.consume(); //<- no cb here
consumer.on("message" => {});
I am not 100% sure yet if its a good idea to move manual committing into
batch mode.
Alternatively we could throw an error if batch mode is used with
"enable.auto.commit": false
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nodefluent/node-sinek/pull/38#issuecomment-346637216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFqCyR24HP_kgE1M2Iwmqn3CWu7I80LSks5s5YYAgaJpZM4Qntg6
.

Added this PR to log a warning message.

I'd like to re-open the discussion on this topic. I am a co-worker of vuza, working on the same topic.
The proposed solution seemed to work at first, but we tested it with small amounts of messages only.
When having a topic with several millions of messages, this mode results in a completely overwhelmed node-js application, dying with "Out of memory". Sinek emitted new message events faster than we processed them.
So, using the non-batch-mode seems unsuitable for us in many ways:
First of all, we need a strict processing order per TopicPartition (TP). Our experiment seemed to push several messages for the same TP without waiting for the old ones being processed. Way more than we have partitions. I can imagine (not prove) that several messages of the same TP can overtake each other during processing this way.
Second, without any means of backpressure, our application just dies quickly in non-batch-mode due to the described observations.
Closing the loop to the batch-mode: even if not designed for manual commit in the first place -- why not support manual commit? We need this manual commit, because processing of a message can fail due to failures in another external system. In such a case, we need a possibility to shut down / pause our processor and later resume exactly at (or before -- but not after) the last message that failed. With autocommit, this is not possible.
I don't really see a reason for forbidding manual commit, and the original PR seems to have a simple solution. Am I missing something? Or is there a possibility to change your opinion to accept this PR on second thought?

@easimon I will have a short discussion with my colleagues on next Monday regarding this to check if it breaks any of their stuff. I see your pain-point - if it doesn't cause any trouble for us, I will create a new PR that enables manual commits in batch mode.

@easimon @vuza please checkout<EMAIL_ADDRESS>there is now an additional option called noBatchCommits that you can pass to nconsumer.consume(.., {noBatchCommits: true}), it will disable any commits during batch mode and should fulfill your wishes, without breaking any existing behaviour.


Don't add empty cregs to circuits

This PR prevents qpd._decompose_qpd_measurements from adding empty QPD registers. This came up while creating unit tests for #153 . Removing the empty registers makes it more clear what is happening under the hood and makes it more straightforward to test against.

This PR makes less sense outside the context of the cutting tests. I'm just going to roll this change into #153


mepo: 0.4.2 -> 1.0

Description of changes

Changelog: https://git.sr.ht/~mil/mepo/refs/1.0
(please note that this is skipping some versions in betwen 0.4.2 and 1.0)
Please review this carefully, as this is my first nixpkgs contribution. Here is a list of things I'm especially not sure about/not 100% happy with but don't know how to do better:

mepo ships with some helper shellscripts, some of these scripts depend on jq being in $PATH, one of these scripts depends on gpspipe (provided py package gpsd) being in $PATH.
This is solved here by putting both jq and gpsd in the $PATH of all scripts containing jq. I'm not sure whether this is considered "unclean", as it also puts gpsd into the path of the scripts depending only on jq.

I haven't been able to add support for the geoclue location source, as this seems to require some black magic dbus fuckery which is beyond my knowledge. If sombody knows how to do this, either go ahead or point me to a ressoucce. currently the corresponding script detects that geoclue is not available and uses the alternatives gpsd and mozilla location services.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Yes, sorry I'm just a little bit confused with my git, give me a couple
of mins.

Fixed it, once again, sorry for the noise created.
@FRidh @jonringer, I didn't intend to request your review, can i "un-request" it? In any case, feel free to ignore this.

@McSinyx I got your Patch to work with geoclue. The mepo binary doesn't directly call geoclue, it uses the provided where-am-i binary for this. Thus, you need to set the corresponding appConfig settings for where-am-i, not mepo. isSystem can be false.

I see, could you please note that in the long description?
It's not trivial to figure out.

However, I'm currently still figuring out the handling of some weird
behaviour when a menuprogram other than menuChoice.
Maybe the deps of the script shouldn't be appended to $PATH, but instead
$PATH should be set to the deps?

$PATH can be explicitly set for mepo_ui_helper_menu.sh now, however for scripts that depend on one another we have to preserve the original $PATH to allow users to override.

Also, your patch is missing the bc dep for mepo_ui_helper_pref_pan.sh

Nice catch!

Is overriding Mepos default script really a usecase many users have? In
that case, should we maybe provide an additional env variable for
overriding, something like MEPO_PATH or MEPO_SCRIPTS? maybe we could
even ask upstream to support this kind of setup.

Overriding scripts is an intended use case AFAICT.  I've yet to use mepo
extensively enough to need it, but it's immensely useful in Sxmo.
IIUC the problem here is with menu fallback, which is to be deprecated
in favor of defaulting to zenity: https://todo.sr.ht/~mil/mepo-tickets/46

I'm currently going through all the scripts and figuring out their
dependencies (coreutils is needed but missing almost everywhere. It's
likely that it's in $PATH anyway, but i still consider it cleaner that
way.)
@McSinyx Why have you added the kbd package to the deps of framebuffer menu? For
openvt and chvt the script is explicitly using busybox, or is there
another occasion where it's needed that I'm missing?
Also, the more I'm thinking about it, the less I like the Idea of
including $PATH. It simply goes against the nature of stateless
packaging and introduces side effects (which, admittedly, can be desired
for overriding, it's really a two-sided sword and I have yet to come up
with a good solution).
I'm pretty new to nixpkgs, so I might be wrong, but another thing I'm
not 100% happy with, is the handling of the menuChoice. The system you
introduced is definetely a cool concept, but I see two minor flaws:

I don't like the fact that menuChoice is being passed in as a string,
is there a "safer" way of doing this, such as, speaking in terms of
traditional programming "defining an enum" which contains all possible
options?
I'm not sure about that one, but i don't like the fact that
apparently menuChoice is mutually exclusive. We don't provide proper
support for use cases where i.e. the user want's to use both dmenu and
bemenu. I'd like it if the user could do something like this in his
environent.systemPackages:
(mepo.override { menuChoice = [ dmenu bemenu ]; }).
Also, with the current situation, I'm not sure what would happen if
someone installs both mepo-zenity and mepo-dmenu.
On the other hand, with the incoming upstream deprecation of multiple
menu systems, I'm not sure whether it's justified to put too much effort
into this problem.

I just wanted to share what I've achieved in the meantime. You can have a look at it, comment on it and test it. I didn't test all permutations (menu systems, withgeoclue, withgpsd (can't properly test that either bc of lack of sensor), etc) yet, before i do that I'll need some sleep. When you test it, make sure you don't have an older version of mepo installed in your PATH, else the scripts from the previous version will override those from this package. (That's exactly what I don't like about the approach of including $PATH into the scripts.) Cheers!

Why have you added the kbd package to the deps of framebuffer menu? For
openvt and chvt the script is explicitly using busybox, or is there
another occasion where it's needed that I'm missing?

I wasn't aware of busybox dependency and picked up kbd for them following Alpine.  With busybox added I assume kbd can be removed.

I don't like the fact that menuChoice is being passed in as a string,
is there a "safer" way of doing this, such as, speaking in terms of
traditional programming "defining an enum" which contains all possible
options?

I don't think there exist an enumeration type, though I am not nix expert.  The map however does limit all possible choices, and nix even provide suggestions upon typos.

i don't like the fact that apparently menuChoice is mutually exclusive. We don't provide proper support for use cases where i.e. the user want's to use both dmenu and
bemenu.

People wanting that, if any, can drop into nix shells, which is not convenient, but I suggest not letting perfect be the enemy of good and solve that when someone with such use case actually asks for it.

I had a conversation with SuperSandro and he told me that:

the postInstall hook is messy and i should just loop over all shell scripts and add the deps to all of them
for the different backends I should write a nixos module instead of telling users to configure it manually in longDescription.

I am going to rewrite this.


[FRONTEND] Support else if in @cond

Context: Supporting multiple branches with an else-if-like construct requires nesting @cond decorators with the user, which hurts readability.
Description of the Change: Add an else_if function directly to the front end.
Benefits: It is more ergonomic and readable to express programs with the desired branching functionality.
Possible Drawbacks: If the text formats of the JAXPRs are important, the use of a list to store the branch_jaxprs appears to mess with the variable naming with the inner branch functions. See how the function parameters in frontend/test/pytest/test_conditionals.py name their parameters "a" and "b" instead of continuing to use subsequent letters from the outside scope.
It's also possible, given my relative inexperience with JAX, that the variable name here is due to some misconfiguration.
Related GitHub Issues: #95

Hi @pengmai, thank you for submitting your pull request!

Can anyone shed insight on why CodeFactor is highlighting issues around redefining functions and missing docstrings in the unit test file? It seems to me that the existing tests have those same "issues".

Indeed the test suite does not yet satisfy CodeFactor requirements (which was introduced later), and it is slowly being updated to match those standards. However, all new contributions must match the coding standards recommended by CodeFactor. Hope this answers your question :)

Possible Drawbacks: If the text formats of the JAXPRs are important, the use of a list to store the branch_jaxprs appears to mess with the variable naming with the inner branch functions. See how the function parameters in frontend/test/pytest/test_conditionals.py name their parameters "a" and "b" instead of continuing to use subsequent letters from the outside scope.

This is an interesting observation, but likely just a quirk of the printer. I've noticed before that printing operations of the same jaxpr one at a time for example will restart the lettering at a for each of them.
Additionally, values from an outside scope accessed in the inner scope are present as arguments of the nested jaxpr, which to me would indicate that each jaxpr can be treated independently and does not rely on outside context, so I wouldn't be too worried about it.

The "function redefined" issue on CodeFactor feels a little strange in the context of PennyLane programs in case a user wanted to name the different branch functions the same thing to conceptually group them (and indeed, one of the existing @cond unit tests explicitly tests this). I've nonetheless chosen different names within my new tests to pass CodeFactor for now.

Ah, I fully agree with you here, in fact this is also the style we show in the documentation :)
We can just keep your version that you already have, but I would also be happy to add a Pylint exception for those test cases.

If you wouldn't mind adding your name and a short description of you changes to the changelog, under New features, and with a link back to this PR, that would great!


No Start Menu Shortcuts

When using this cookbook it appears to have installed the product, but no shortcuts are made to the start menu for visual studio or other tools.
My config:
config.vm.provision :chef_solo do |chef|
chef.add_recipe 'visualstudio::default'
chef.add_recipe 'visualstudio::install_update'
chef.add_recipe 'minitest-handler'
chef.file_cache_path = 'c:/var/chef/cache' # Need leading drive letter
chef.json = {
  'visualstudio' => {
    'version' => '2015',
    'edition' => 'enterprise',
    'source' => ENV['VS_SOURCE_URL'],
    'preserve_extracted_files' => false
  }
}

end
Run against a windows 10 box with the latest updates.  I am able to launch vs.net 2015 by navigating to the devenv.exe file.

How are you running the cookbook? Are you executing Chef under the same user as you're starting VS as?

Sorry, I forgot to mention I'm using Vagrant to do this.  I took this code almost directly from the Vagrantfile included in the cookbook.
I'm unsure what user it is attempting to run as, I haven't specified anything.  I'll have to dig deeper to see if I can find any information about that.

Seems I was mistaken, or maybe it needed a reboot.  The shortcuts appear as expected now.


sourceMap configuration in tsconfig

Hi Andreas @akudev ,
in this example the sourceMap configuration is set to false.
We would expect this value to be true in order to see the source map also in the browser.
Would that be the recommended setting for production? If we develop would we need to set it to true?
Thank you :)

Hi @Evotionce ,
With the current settings of the project, source maps ARE generated (inline; changed today, see below). This is configured in the build scripts in `package.json:
"build:ts": "babel src --out-dir webapp --source-maps inline --extensions \".ts,.js\" --copy-files",
"watch:ts": "babel src --out-dir webapp --source-maps inline --extensions \".ts,.js\" --copy-files --watch",

These settings are for the  @babel/preset-typescript Babel plugin which actually does the transpilation.
When you just run the pure TypeScript transpiler by executing "npx tsc", then the compilation result will go straight to the "dist" directory (as specified in tsconfig) and indeed NOT contain any sourceMaps. Changing the setting to "true" in tsconfig will cause sourcemaps to be created in separate files.
In general, describing all TypeScript settings is beyond the scope of what we can do in this sample project, so whatever is not described, should be read in the respective documentation of the used tools and used "as appropriate".
But I have used the opportunity to change the sourcemap handling to let them go to separate files (soure-maps: true) and to describe them better in the documentation (all in https://github.com/SAP-samples/ui5-typescript-helloworld/commit/9a045820fd41d65a70191c8a986e9380785077a2).
Thanks and regards
Andreas


[FLINK-22627][runtime] Remove SlotManagerImpl

What is the purpose of the change
Remove SlotManagerImpl and its related classes. This PR base on the #15812 .
I do not remove the SlotRequest because I think it should belong to #15812 as discussed. But I also open to do it in this PR. If the plan changes, pls ping me @tillrohrmann @lqjack .
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Rebase on #16485

I've merged the PR #16485 @KarmaGYZ. Could you rebase your PR onto the latest master. Then I can merge this PR very soon.

Thanks for the review and the awesome clean up in #16485, @tillrohrmann ! PR rebased onto the latest master.

Great, thanks @KarmaGYZ. Merging this PR now.


Set image from Blob

I have a use case where I'm loading images from a remote server and I need to display some additional metadata about the image.  Currently, this requires performing two requests--one to load the image and another to fetch the metadata.  Since I control the remote host, I'd like to send additional HTTP headers with the image that contain the metadata.  With the fetch API, I can get the image data as a blob and retrieve the custom headers as text.  From there, it would be great to be able to set the ImageView's source to that blob data and (for example) a TextView with the value of the custom header.
Alternatively, if there was a way I could access the okhttp response object (and its equivalent on other platforms), that would work too.

@cookieguru With Tabris.js 2.x we will support the XHR/fetch response to be of type arraybuffer. Therby you can get the binary data of your image (still compressed as jpg/png) and the headers.
On iOS the ImageView also supports to set the image as a base64 encoded string: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADIA.... This could be something we could also add on Android.

Support for data uris has landed on Android (Tabris.js 2.x) with the closing of https://github.com/eclipsesource/tabris-js/issues/884. See https://en.wikipedia.org/wiki/Data_URI_scheme for more details.

That will work nicely.  Thanks for the quick turnaround @mpost!

arraybuffer responseType is merged on Android. You could try the turnaround with a nightly build. iOS support coming in the next few days.

I cannot find a code snippet to understand your solution.
How to get a xhr.resonse into the required base64data for a imageView source?
fetch data with
var xhr = new tabris.XMLHttpRequest();
xhr.responseType = "arraybuffer";

xhr.response has to be converted into variable "base64data"
image: {src: "data:image/png;base64," + base64data}

Why don't you just set the image's source to the URL that you request with XMLHttpRequest?

your so speedy ;-)
cause I have to login with user and password


bazel-watcher: use apple sdk11

Description of changes
To fix errors like
In file included from __main__/external/com_github_fsnotify_fsevents/go_1_10_after.go:6:
In file included from /nix/store/pn8g2iyc0ynlvrkhi7yzbrdyixx29ay0-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:39:
In file included from /nix/store/pn8g2iyc0ynlvrkhi7yzbrdyixx29ay0-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/LaunchServices.h:23:
In file included from /nix/store/pn8g2iyc0ynlvrkhi7yzbrdyixx29ay0-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/IconsCore.h:23:
In file included from /nix/store/pn8g2iyc0ynlvrkhi7yzbrdyixx29ay0-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OSServices.h:29:
In file included from /nix/store/pn8g2iyc0ynlvrkhi7yzbrdyixx29ay0-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/CSIdentity.h:43:
In file included from /nix/store/i3wylk33iamimjdsqdhfz4rdc0r5gnyz-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/Security.h:87:
/nix/store/i3wylk33iamimjdsqdhfz4rdc0r5gnyz-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/SecCode.h:35:10: fatal error: 'xpc/xpc.h' file not found
         ^~~~~~~~~~~

bazel-watcher is used in bazel_{3,4,5,6} tests and some of them fail on darwin due to sdk version mismatch.
Extracted out from https://github.com/NixOS/nixpkgs/pull/200033 After noticing darwin failues in https://github.com/NixOS/nixpkgs/pull/203465
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I have this same issue on x86_64-darwin, but this change doesn't appear to resolve it.
[193 / 269] Compiling src/google/protobuf/compiler/js/js_generator.cc; 12s processwrapper-sandbox ... (8 actions, 7 running)
ERROR: /private/tmp/nix-build-bazel-watcher-0.17.0.drv-0/output/external/com_github_fsnotify_fsevents/BUILD.bazel:3:11: GoCompilePkg external/com_github_fsnotify_fsevents/fsevents.a failed: (Exit 1): builder failed: error executing command bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/go_sdk/builder '-param=bazel-out/darwin-fastbuild/bin/external/com_github_fsnotify_fsevents/fsevents.a-0.params'

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from __main__/external/com_github_fsnotify_fsevents/go_1_10_after.go:6:
In file included from /nix/store/2k3mdkl9jvwwzpbfaqhchfiqjq64046b-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:39:
In file included from /nix/store/2k3mdkl9jvwwzpbfaqhchfiqjq64046b-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/LaunchServices.h:23:
In file included from /nix/store/2k3mdkl9jvwwzpbfaqhchfiqjq64046b-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/IconsCore.h:23:
In file included from /nix/store/2k3mdkl9jvwwzpbfaqhchfiqjq64046b-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OSServices.h:29:
In file included from /nix/store/2k3mdkl9jvwwzpbfaqhchfiqjq64046b-apple-framework-CoreServices-11.0.0/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/CSIdentity.h:43:
In file included from /nix/store/dg51rm1bapffbqvn46bh43km4dhcsy9p-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/Security.h:87:
/nix/store/dg51rm1bapffbqvn46bh43km4dhcsy9p-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/SecCode.h:35:10: fatal error: 'xpc/xpc.h' file not found
#include <xpc/xpc.h>
         ^~~~~~~~~~~
1 error generated.
compilepkg: error running subcommand external/go_sdk/pkg/tool/darwin_amd64/cgo: exit status 2
Target //ibazel:ibazel failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 123.360s, Critical Path: 29.12s

I tried performing a bit of a hack by adding xpc directly to buildInputs, but that also fails (though in a different way).

Curious, fail for me the same way on recent nixpkgs, can try to bisect it, I think it was helping before

yes, already in as part of the other PR


Auto-update dependencies

The linter depends on the active-developing protobuf v2 and other packages. We need to find a way to auto update those dependencies so that we can avoid issue #96. For example, Renovate may be a good solution.

Not very interested.


Build scripts seems to be outdated

Hello! I am trying to get into Zig language and I was trying to use your project as dependency. Unfortunately, I am encountering lots of error in SDL.zig's build.zig. I fixed issue related to @fieldParentPtr("step", step); but other issues coming out. I am not qualified to fix your build systems so sorry... no PRs. However, I am willing to help reproducing the issues.
I am on Windows 11, installed latest Zig which is at the moment 0.11.0.
Let me know if I can provide anything else.

Yes, please provide a diff of your changes, easiest way via PR. Enable contributor access, so others can continue with the work

I've noticed the same thing. I made a PR that changes the build script in README.md that solves it for me on Zig 0.13. https://github.com/ikskuh/SDL.zig/pull/192


SCMProvider.resources naming

VSCode Version: Code - Insiders 1.11.0-insider (6ae8c1506669fd579da1da92108b7db86d019bc6, 2017-03-29T08:21:59.122Z)
OS Version: Linux x64 3.13.0-108-generic
Extensions: none

Testing #23311
Since this is an array of resource groups, would it make sense to name it resourceGroups? resources reads like it is of type SCMResource.

API changing: #23645


How to get the output when agents kicks

I'm thinking about how to reward and want to get the output when the agent kicks. How can I get the output when the agent kicks?

It's about soccer.

I don't really understand your question. What sort of output are you looking for?

Sorry, I was able to solve this problem. Thank you for your answer.


unexpected behavior, picosha2 cuts off leading/trailing spaces

picosha2 seems to hash " one" and "one"  and "one " as the same.
as well as "on e" and "on  ( any number of more spaces here)    e"
These should be different though, especially when hashing. How does one "make spaces count," for your implementation of SHA256?

compiling using clang++ and c++14
#include
#include "picosha2.h"
using namespace std;
int main()
{
string test;
string hash;
cin >> test;
cout << endl;
picosha2::hash256_hex_string(test, hash);
cout << hash << endl;
}
When I enter "one" hash returns: 7692c3ad3540bb803c020b3aee66cd8887123234ea0c6e7143c0add73ff431ed
When I enter " one" hash returns:
7692c3ad3540bb803c020b3aee66cd8887123234ea0c6e7143c0add73ff431ed
This doesn't seem to be a quirk of terminal input, because I originally detected this when referencing text files and hashing them.
What am I doing wrong?

OK. It is not a problem of PicoSHA2 but of std::cin: it ignores white spaces.
Please try below code ;)
#include <string>
#include "../picosha2.h"

int main()
{
    std::string test, hash;
    std::cin >> test;

    std::cout << "test string is \"" << test << "\"" << std::endl;

    picosha2::hash256_hex_string(test, hash);
    std::cout << hash << std::endl;
}

Learn more,
https://stackoverflow.com/questions/805403/what-are-the-rules-of-the-stdcin-object-in-c

Yep, sorry about that. I thought I had observed it in strings but I had not, or it was a quirk of compiling with the wrong compiler!