lapack/{gonum,testlapack}: clean up Dgetc2 and Dgesc2 and rework their tests

Please take a look.
cc @soypat

Codecov Report

Merging #1674 (f207f36) into master (c0f40d7) will decrease coverage by 0.14%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   73.25%   73.11%   -0.15%
==========================================
  Files         507      491      -16
  Lines       60006    59481     -525
==========================================
- Hits        43958    43489     -469
+ Misses      13562    13530      -32
+ Partials     2486     2462      -24

Impacted Files
Coverage Δ

lapack/gonum/dgetc2.go
75.00% <75.00%> (+11.53%)
:arrow_up:

lapack/gonum/dgesc2.go
61.29% <100.00%> (+21.89%)
:arrow_up:

internal/asm/c64/conj.go
0.00% <0.00%> (-100.00%)
:arrow_down:

mat/offset_appengine.go

internal/asm/f64/dot.go

internal/asm/f64/l2norm_noasm.go

internal/asm/f64/stubs_noasm.go

internal/asm/f64/scal.go

...fourier/internal/fftpack/array_no_bounds_checks.go

internal/asm/f64/axpy.go

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f40d7...f207f36. Read the comment docs.

LGTM. All around great improvements save a couple things I might not be used to yet.


create subfolders for named volumes within the shared location

Right now, all the data for a named volume is written to the base directory of the share. Taking nfs for example. I do have an NFS share /export on my nfshost. Then running this:
docker volume create -d nfs --name data1 -o share=nfshost:/export
docker volume create -d nfs --name data2 -o share=nfshost:/export

will create two different named volumes (data1, data2). The data for both volumes will be stored in the same shared folder though (/export). The result is, that changes in one named volume can overwrite the data for the other too. To resolve such possible name clashes with the current version, I would need to define two different NFS shares /export1 and /export2. With many named volumes, this leads to many shares and greater administrative effort.
Proposal:
I propose to change the meaning of the share folder to be the root of a volume set (as suggested by @eesprit here: https://github.com/ContainX/docker-volume-netshare/issues/52). This would mean, that for each named volume a subdirectory with the same name as the volume is created and all data stored there. For my example, this would lead to the following folder structure:
/export

/data1
/data2

Thus, the files for both named volumes are separated and I only have to create one NFS share. The same logic should be applied for cifs and probably efs.
It would be useful to define a new option to enable / disable this feature. If the option was named create, than the subfolders will only be created when -o create=yes is set. With -o create=no, the current behaviour remains and all files are stored within the root folder of the share. To be backward compatible, the default value for the create option could be no.

I like this and feel it adds more smarts to the driver and flexibility.  I'm going to do some refactoring to support this and will make the next major upcoming release 1.0 to introduce this change.

strange, I think this would also work, as long as the directory data1 exists in the proper location:
docker volume create -d nfs --name data1 -o share=nfshost:/export/data1

@manast @ender74 This feature has been created (only for NFS mounts).  See example in latest release.  It uses the create=true option as proposed.
https://github.com/ContainX/docker-volume-netshare/releases/tag/v0.30

Is this possible to do with a docker compose file?
I tried doing this, but doesn't seem to work:
volumes:   nextcloud:     driver: nfs     driver_opts:       share: <IP_ADDRESS>:/data       create: "true" nextcloud:     image: nextcloud     volumes:       - nextcloud:/var/www/html/data:nocopy     volume_driver: nfs     depends_on:       - mariadb

Is this working for EFS volumes?

@cardinalfan1 I'd really like this ability in compose as well. Has anyone got that working or is this a current limitation?


Reintroduce support for Webpack 4 in Vue Apollo Composable

Description
@vue/apollo-composable 4.0.0-alpha.13 broke support for webpack 4 by using a nullish coalescing operator.
As discussed in issue #1217, webpack 4 uses acorn 6, while support for the nullish coalescing operator was only added in acorn 7.
Users of webpack 4 will now get the error: Module parse failed: Unexpected token (19:103).
Reintroducing support for webpack 4 would be especially useful for users who have abstracted away webpack.
Proposed solution
On issue #1217, @Akryum commented that he would probably lower the esbuild target to what acorn 6 understands.
Alternatives
Alternatives are upgrading to webpack 5 or freezing @vue/apollo-composable at 4.0.0-alpha.12.
I see that @tobiasdiez from issue #1217 has resorted to transpiling @vue/apollo-composable with babel.
Updating to webpack 5 is hard for those who use @vue/cli-service to abstract away webpack. Manually transpiling @vue/apollo-composable is also not ideal.
Since I believe the intention is to reintroduce support for webpack 4 within @vue/apollo-composable, I'm currently holding at 4.0.0-alpha.12.

Per the webpack team, transpiling dependencies is not a bad idea. Insteaad of going with the lower common denominator (IE) leading to shipping older and heavier code, it would probably better that the ecosystem goes towards the opposite = let the final 'user' decide what to transpile to which target.

@Akryum, I completely agree. But am I correct in observing that in this case the lowest common denominator is acorn 6, used by webpack 4, installed by the Vue CLI for projects in Vue 2, which is still the current version of Vue?
Rather than using old and heavy code, I was under the impression that I was on the bleeding edge by using @vue/apollo-composable in my Vue 2 project. 😐

Yes, that's why I said I'll change the target accordingly.

Cool. I probably mistakenly interpreted your comment as considering not going back.
Thanks for your work and quick responses!


Add 'hash_length' key for services

Bayesian (@msrb) is using 7 characters from hash to tag images. Other services use 6 characters. To allow both work correctly without a pile of PRs, hash_length is introduced and will be used while shortening the commit hash for template processing.

Thanks 😉
7 is obviously better than 6.
/me hides


request: lx-select choices dropdown to match width of lx-select

lumX version 1.0.5
I would like to be able to style the lx-select choices to horizontally expand to match the width of the lx-select itself. This is not possible in CSS as the choices are attached directly to the body, rather than embedded within the lx-select parent DOM.

lumX v1.7.23
lx-select choices now match the width of the lx-select itself, did this using CSS.
.lx-select {
  padding: 0.4em 1.4em 0; /*or width: 80% */
}

Thanks @akinjide for answering this old issue (that wasn't on our radar anymore, sorry for that @aotearoan)

Thanks for that @akinjide


Searching files (lqf) works, but searching content (lqs) apparently not

Hi,
I did installations per the instructions, and "lqf" finds and opens files, but "lqs" does not find anything. Any ideas? Is it supposed to search from within all files with any keyword, similarly than to Logseq cmnd+K function? Hope to get this work if so.
My best,
Oskari

I have the same problem. In my case, Alfred did not find the Python2 executable after macOS 12.3 which removed it.
And my workaround is using External Script to point to Python3 instead of /usr/bin/python.
The steps of this can be found here: Calling non-standard runtimes from Alfred.

When configuring a Run Script or Script Filter, Alfred provides a Language dropdown listing the runtimes which have historically been included with macOS. But what if you want to run a script from another language which you have installed on your system? Be it Node.js, Lua, or something else, it’s dead-simple to call them. Either:

Save your script with a proper shebang (examples: #!/usr/bin/env node; #!/usr/bin/env lua) and use External Script as the Language, pointing to your script.
Use /bin/zsh (or /bin/bash) as the Language and tell the runtime to call your script (examples: node MY_SCRIPT.js; lua MY_SCRIPT.lua).


[master] Add macOS brew image/env workaround

Based on https://github.com/actions/virtual-environments/issues/1811.
I'm also porting this to release/3.1.

Aaand there are general AzDO degradations showing up now. https://status.dev.azure.com


GPU Panic Fix Fails

I have the following machine:
MacBook Pro mid 2010 v6.2 2.53 Ghz Intel Core i5
The first procedure I followed was:

Boot to Recovery Partition and use Terminal to turn off SIP
Restart and run MBPMid2010-GPU-Fix-0.6.1.app from my normal Mac user (NOT the Administrator account) ->see app trace below. The version run was the latest as of 10/30/2018.
Restart and boot to Recovery Partition.  Use Terminal to Enable SIP.
Restart and log on as normal Mac user
Mac ran for about 5 minutes and then crashed when using a greeting card application that exercises GPU.  Upon restart dialog was displayed showing GPU panic.

The log for MBPMid2010-GPU-Fix-0.6.1.app showed Success.  The trace is pasted below:
| Checking compatibility
MBPModelVersion :  MacBookPro6,2 ➔ Compatibility : OK ✓
| macOS version :
macOS 10.12
| Checking SIP Status
SIP Disabled
| Searching for AppleGraphicsPowerManagement.kext
AppleGraphicsPowerManagement.kext found
********** Starting MBP GPU Fix **********
Disabling Kext Signing verification :  ✓
Copying Info.plist file
Patching Info.plist

FindChild  - key|MacBookPro6,2
NextSibling  - dict
FindChild  - key|LogControl
ModifyIntValue  - integer|1
FindSibling  - key|Vendor10deDevice0a29
FindSibling  - key|BoostPState
FindSibling  - key|BoostTime
FindSibling  - key|Heuristic
FindSibling  - key|IdleInterval
ModifyIntValue  - integer|10
RemoveSiblingLabel  - key|P3HistoryLength
RemoveSiblingValue  - integer|2
FindSibling  - key|SensorSampleRate
ModifyIntValue  - integer|10
FindSibling  - key|Threshold_High
FindSibling  - key|Threshold_High_v
FindSibling  - key|Threshold_Low
FindSibling  - key|Threshold_Low_v
Info.plist successfully patched
| Loading Kernel Extension
Removing existing kext in tmp :  ✓
Copying actuel kext into tmp :  ✓
Copying patched Info.plist into kext :  ✓
Changing permission of kext :  ✓ /tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature/CodeResources
/tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature
/tmp/AppleGraphicsPowerManagement.kext/Contents/Info.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS/AppleGraphicsPowerManagement
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS
/tmp/AppleGraphicsPowerManagement.kext/Contents/version.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents
/tmp/AppleGraphicsPowerManagement.kext

Removing existing kext :  ✓
Copying patched kext into Extension :  ✓
Loading modified kext :  ✓
********************* MBP GPU Fixed Successfully *********************
############################################################
I reviewed the Issues posted for this patch.  I elected to try the procedure shown for one failure that recommends resetting the SMC and then re-applying the patch.

Followed Reset SMC procedure for this Mac
Followed same procedure listed above.  Application trace is pasted below.
Rebooted Mac and logged on as normal user.  Less than 5 minutes after starting greeting card app the Mac crashed with a GPU panic.

The log for MBPMid2010-GPU-Fix-0.6.1.app showed Success.  The trace is pasted below:
| Checking compatibility
MBPModelVersion :  MacBookPro6,2 ➔ Compatibility : OK ✓
| macOS version :
macOS 10.12
| Checking SIP Status
SIP Disabled
| Searching for AppleGraphicsPowerManagement.kext
AppleGraphicsPowerManagement.kext found
********** Starting MBP GPU Fix **********
Disabling Kext Signing verification :  ✓
Copying Info.plist file
Patching Info.plist

FindChild  - key|MacBookPro6,2
NextSibling  - dict
FindChild  - key|LogControl
ModifyIntValue  - integer|1
FindSibling  - key|Vendor10deDevice0a29
FindSibling  - key|BoostPState
FindSibling  - key|BoostTime
FindSibling  - key|Heuristic
FindSibling  - key|IdleInterval
ModifyIntValue  - integer|10
RemoveSiblingLabel - P3HistoryLength Not found
FindSibling  - key|SensorSampleRate
ModifyIntValue  - integer|10
FindSibling  - key|Threshold_High
FindSibling  - key|Threshold_High_v
FindSibling  - key|Threshold_Low
FindSibling  - key|Threshold_Low_v
Info.plist successfully patched
| Loading Kernel Extension
Removing existing kext in tmp :  ✓
Copying actuel kext into tmp :  ✓
Copying patched Info.plist into kext :  ✓
Changing permission of kext :  ✓ /tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature/CodeResources
/tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature
/tmp/AppleGraphicsPowerManagement.kext/Contents/Info.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS/AppleGraphicsPowerManagement
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS
/tmp/AppleGraphicsPowerManagement.kext/Contents/version.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents
/tmp/AppleGraphicsPowerManagement.kext

Removing existing kext :  ✓
Copying patched kext into Extension :  ✓
Loading modified kext :  ✓
********************* MBP GPU Fixed Successfully *********************
##########################################################
==> Any suggestions would be much appreciated!

Hello ! Please try to reapply the patch a second time.
Sometimes it does require two launch to work.

I have followed the patch install procedure 4 times now and the results have not changed.  I did not include any GPU panic traces for the sake of brevity, but I have 2 available.

I received a suggestion from Amordicus.  He stated that the patch program must be run when logged on as the Mac administrator.  At the time I used his recommendation I had run the patch program 8 times as my normal Mac user.  All such attempts had failed.  Here is what worked for me:

Log on as machine Administrator
Restart into Recovery Mode (restart holding Cmd-R)
Turn off SIP - csrutil disable
Restart and log on as Mac Administrator
Remove all files from /tmp
Run program MBPMid2010-GPU-Fix-0.6.1.app
Restart into Recovery Mode
Turn on SIP -> csrutil enable
Restart and log on as normal Mac user.
Run CINEBENCH OSX.app (R15.038) and execute an OpenGL test.

I repeated the procedure 3 times.  On the first 2 times when the OpenGL test was executed I immediately suffered a GPU panic and the Mac crashed.  On the 3rd time the Mac successfully completed the Cinebench OpenGL test!  The frame rate is low (about 9 fps) but at least the Mac is now very usable.
Thank you for your efforts to offer a solution to those of us who love our vintage Macs and are not able to purchase a new one.  Your work is a great benefit to many!


Add yahoo as a data provider

Since I can string a new data provider without affecting existing providers, I should be able to add the yahoo backend without destroying existing providers.
From early investigation, all a user needs is an app ID.  These are free, but I’m not sure what the parameters are around that.  This work will be well in experimental phase, since I’ve never tested against the yahoo backend.
https://developer.yahoo.com/apps/create/

This looks more precarious than I first thought, and I’m having troubles justifying the time I would need to spend on the oauth aspect, especially when climacell and openweather seem to be stable.
https://developer.yahoo.com/weather/documentation.html#oauth-nodejs
Bailing on this now unless there is a need for it.


Prevent using environment variables that don't match AWS' rules

Currently, we accept variables that start with _, for example. In https://github.com/zeit/api/issues/862, the API will be fixed so that now automatically throws an error for those, as AWS doesn't allow them.
However, we still need to ensure that now dev prints a validation error and exits immediately if it notices a environment variable in now.json that does NOT comply with the AWS rules.

I don't think we want now dev to exit immediately in this case. For other validation errors (i.e. no matching builds, syntax error in now.json, etc.) we print a warning to now dev and ignore the change, so that the user doesn't need to constantly be restarting the server.
In this case I think it's reasonable to warn that the env var name is invalid and will be ignored.


fix ocean symbol on Polygon

Fixes #456 .
Changes proposed in this PR:
Switch ocean symbol depending on network in the following places:

Price component
everything within pool & trade tab
pool shares on History page

Hardcoded the user address and subgraph2 url to get the new changes from the subgraph and pool shares on Polygon so I can test the symbol. These should be changed after testing and before merge.

yeah, not sure about which subgraph exactly to use. Feels like we should solve this properly as was prepared with https://github.com/oceanprotocol/market/pull/457 but was waiting for some new graph deployment

I think we can merge this and #457 together before merging into main. Sorry but not sure what you mean by proper way, should we get every ocean symbol from the graph?

Not sure if we can actually solve it "properly" here. Don't think this needs more attention, it's good enough for now. The subgraph was not released on main so we have to wait for that.
In the future with multi pools and other base tokens we will have a different mindset for handling pools so no need to handle it here.

ok cool, then let's move forward with this. We should remove all the hardcoded URL changes, not use subgraph2, and no hardcoded accounts in this PR

well, this needs a live subgraph update after all because in this PR we use changes from https://github.com/oceanprotocol/ocean-subgraph/pull/61 for the pool shares https://github.com/oceanprotocol/market/pull/487/files#diff-7b725b7c0d9d14eaa89b27b537b53a12ec596ce0984a1f3cde57a9c75d31ca1e

Than this will only fix the price component and trade tab or should fix the other ones too by using config.oceanTokenSymbol?

this fix is needed as well https://github.com/oceanprotocol/ocean-subgraph/issues/200

Before merging we need to remove the changes from apollo.config.js and ocean.ts . This merge need to be done in sync with the subgraph change since there are some minor changes in the subgraph that will break some pool functionalities.
I moved BestPrice from ocean.js to market since it has no use there at this point.

do not merge, found some issues after merging main


Why dose the cam_extr look like this?

Hi,hassony.
Thanks for this work.
I start leaning th code recently, and now I got confused bout the "get_hand_verts3d" function in ho3dv2.py.
In such function, you use cam_extr and  it has been defined as np.array([[1, 0, 0, 0], [0, -1, 0, 0], [0, 0, -1, 0], [0, 0, 0, 1]]).
I cannot know the reason.
Hope do some little work in such field ,welcome for any generous suggestion.

Hi @MengHao666 ,
Thank you for your interest in our work  !
Typically this comes from different xyz conventions. So here it means that the y and z axis are flipped :)
All the best,
Yana


Base resource support

FHIR resources use an inheritance model to inherit properties from base resources.  Each resource extends DomainResource, which itself extends Resource.
Previously, our FHIR models ignored these base resources (except that they defined an Id property, which is technically inherited from Resource).  This Pull Request contains definitions for the base resources, and each resource inherits their properties via composition.  This allows support for useful fields like meta.lastUpdated, meta.tags, and contained.  It also removes the id field from the resource struct since it should really be inherited from Resource (which does mean that creating struct literals of the resources is a little different now).

This PR should be merged at the same time as:

ie PR #37
hdsfhir PR #8
fhir-golang-generator PR #12


Issue 6854 - Update the link locations to point to the Internet Archive for tests: html5checker, hudsonsurvey, ichiji, issue1010, issue1015

Re: #6854.

/botio test

/botio test

Nice work!


bn/bn_exp.c: harmonize BN_mod_exp_mont_consttime with negative input.

All exponentiation subroutines but BN_mod_exp_mont_consttime produce
non-negative result for negative input, which is confusing for fuzzer.

Since this is called the consttime version, does this change anything in this being consttime?

Since this is called the consttime version, does this change anything in this being consttime?

No. Well, it's a trick question. I can't see that BN_mod or BN_nnmod are constant-time, but in real life applications such as RSA inputs are reduced [and positive], so that they are not called.


Add articleId check to Variant Api Resource

Description
Allow the mainDetail->number to be changed within the pool of variant ordernumbers of that specific article that already exists over the API

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
none

How to test?
Change mainDetail->number to another ordernumber of a variant already exists within this article over API.

Hi @Gugiman & thanks for your PR.
Can you describe a little bit further, what your change should fix? Can you provide some example code or request and tell what's wrong with the current implementation?

I think it is better to close this PR for now because maybe I was a bit too fast opening it ;)

@janbuecker : Maybe i can describe:
Imagine you like to update an variant-article and like to change the main-variant to a existing variant.
You would pass the new data (only the new main-variant is set) to the update-method in engine/Shopware/Components/Api/Resource/Article.php.
This method does load the old "mainDetail" via DQL-Command. Later the prepareMainVariantData in  engine/Shopware/Components/Api/Resource/Variant.php is called - This method is actually only a wrapper for prepareData().
You will end up in the "A variant with the given order number "XYZ" already exists."-Exception, because the method does get the id from old mainVariant and the new main variant is already an "normal" variant of the article.
I'm not sure, if it must be fixed in prepareData() or if it is required to implement a different logic in prepareMainVariantData() instead.
Can you follow my description?
Regards,
Rafael


Add match binding pattern support for xml Functional constructors

Description:
Refer: https://github.com/ballerina-platform/ballerina-spec/commit/7ffe36128182add34d1e2fcd82514adf5acc9c1b#diff-a9b79438f2c8a8890efc4088543d5a35R6429
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Closing as spec has removed support for functional constructors


Verify improvements

This PR implements read-decimal and enforce-one.
This also makes verify strictly stronger than typecheck -- it now typechecks everything (now including constants) and additionally does property checking.
But the biggest enhancement is better messaging for unsupported features. Rather than a wall of text, we respond with the following in the cp example:
examples/accounts/accounts.pact:204:60:Warning: Analysis of pacts is not yet supported
Load successful

I'd like to be able to keep working on top of the current work on analyze without making the divergence between these two branches any worse, so I am currently rebasing this onto analyze, and then we can merge analyze into master right after that.

This PR should not be merged. We should merge #176 instead, which contains this work.


Panic when extracting from a partial function

The following program panics:
(function f (i64) i64 :merge (min old new))

(set (f 1) 4)

(extract (f 2))

What should the intended behavior here be? (f 2) is not defined.

Is panicking currently interpreted as error? If so then it's fine.

@clyben It would be great if you can take a look!

I think this is fixed now.


Release/2.0.0

v2.0.0
New features and APIs

Callbacks have been removed and instead we are returning Promises which enables users to use Async/Await features of JS. (PR#162)
Added 'response_timeout' parameter which enables user to specify the timeout for a particular API call.
Removed Async.js file and the required methods have been migrated to Utils.js following the Promise structure.

Minor changes

Update doc generation logic in GitHub ci (PR#167)
Updated minimist library versions (PR#166)
Added feature that allows to update ACL properties of an entity (PR#170)
Support for updated SDK examples (PR#171)

@ashah-splunk Can we add a section in the Readme, describing the Promise pattern with a snippet the way we did here: https://github.com/splunk/splunk-sdk-javascript/issues/155. Thanks.

@ashah-splunk Can we please add a section in the Readme, describing the Promise pattern with a snippet the way we did here: #155. Thanks.

Hi @ncanumalla-splunk , we have updated REAMDE.md file as per the discussion. Please review it and let us know if any other changes are required.

Looks good to me. Thanks!


karpenter_nodes_total_pod_requests metric shows wrong data

Description
Observed Behavior:
karpenter_nodes_total_pod_requests metric shows wrong data that doesn't match from describe node output's cpu and mem requests
Expected Behavior:
correct metric should be returned
Reproduction Steps (Please include YAML):
check karpenter_nodes_total_pod_requests{resource_type="memory"} and karpenter_nodes_total_pod_requests{resource_type="cpu"} metric, compare it with cpu and memory Requests under "Allocated resources" section
describe output in my case:
$ k describe no ip-xxx.us-west-2.compute.internal ip-yyy.us-west-2.compute.internal | grep -A20 "Allocated resources" |grep -E 'cpu|memory'
  cpu                1735m (89%)   4350m (225%)
  memory             3254Mi (98%)  8320Mi (251%)
  cpu                3635m (92%)   7950m (202%)
  memory             8852Mi (59%)  13824Mi (93%)

karpenter_nodes_total_pod_requests output:
cpu: 1.15 and 3.05
memory: 2412Mi and 8010Mi
Versions:

Chart Version: v0.30.0
Kubernetes Version (kubectl version): v1.27.4-eks-2d98532

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Did you add daemonset? That metric doesn't include daemonsets

@garvinp-stripe thanks for the reply, adding karpenter_nodes_total_daemon_requests shows accurate cpu and mem numbers now
cluster cpu and memory reservation panel in https://grafana.com/grafana/dashboards/18862-karpenter/ dashboard wasnt showing the data correctly, hence i was checking these queries
closing this issue now


2 Questions from Python / Panda Noob

Hi,
Apologies if the formatting is wrong - I'm new to GitHub but have tried to follow the guidelines
2 potentially stupid questions from a Python noob who's also trying to get to grips with Panda.
Question 1:  Getting the floorplan from the tree uses the following:
xp_floorplan_url = """//*[@id="floorplanTabs"]/div[2]/div[2]/img/@src"""
floorplan_url = tree.xpath(xp_floorplan_url)

However, in the page source for a sample search (4 results to keep it small) and then the individual property page for one of the results there is no "floorplanTabs".
When I inspect the page in Chrome I can't find "floorplanTabs" either.
Can you explain how this works?
Question 2:  What does this mean /div[2]/div[2] in the line below?
xp_floorplan_url = """//*[@id="floorplanTabs"]/div[2]/div[2]/img/@src"""

Many thanks for your help.

I think maybe Rightmove have changed the structure of their website since the script was written. You can find the current XPath of the floorplan image element using your web browser. The XPath expression: '/div[2]/div[2]' selects the second div child of its parent div, which also happens to be the second div child of its own parent.

Duplicate


Fix bug in migration for GPUS

closes: https://github.com/opendatahub-io/odh-dashboard/issues/1678
Description

This PR is to remove auto migration for notebook containers and add a solution for containers that are using gpus but not profiles
How Has This Been Tested?

start up main branch on a GOU cluster and create a workbench with a GPU
stop backend
switch to accelerator-support branch and start backend
console should say migration was successful
Workbench should have the keep what i have option selected

Test Impact

bug fix
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@andrewballantyne This is ready for a re-review

@andrewballantyne should be good to go

I have not found any bugs since testing it


bump dbus package

Change-type: patch
Signed-off-by: Ryan Cooke<EMAIL_ADDRESS>

based on this https://github.com/dbusjs/node-dbus-next/issues/39, updating this package may help with the dbus issue multiple devices are showing: https://github.com/balena-io/testbot/issues/49

Looking good @rcooke-warwick not sure how you weren't prompted with that commit error I was seeing maybe the linters judge you change if you make it to source code not package.json. I will merge it tomorrow.

@rcooke-warwick I just realised you also need to npm install with this to update the package-lock.json --> before we merge this.

Closing in favor of #368


Keyboard is completely locked when player is active

You cannot type in any React-controlled input.
Even F12 in Chrome is not working.

Yeah second this. I'm using material-ui and all my inputs are made readonly. Unsure if there is a work around for this?

fixed.

Thanks for fixing it so quickly!


QPP conversion tool configure locally

#Configuration of this tool issue:
Cannot create a WAR file of this project. So how to configure this and deploy in apache tomcat to use the API locally?
How to use with Docker?
Information

OS & version:
Java version: (Run $ java -version.)
Docker version if using: (Run $ docker -v.)

Expected behavior
(Please be more descriptive than "This file should have created valid QPP."
Also, if you can attach a sample QRDA3 file without Personally Identifiable Information, that will make triage easier.)
Actual behavior
(Please be more descriptive than "This file didn't create valid QPP.")
Steps to reproduce

(Please include detailed steps.)

Other details
(Tell us any other details you think are pertinent to this issue.)

The easiest way to deploy this locally would be with docker, or by first building the whole project with "mvn clean install", then running "mvn spring-boot:run" from within the rest-api directory


Added 'alterChangeState' handler

For manipulating the state objects for history.pushState and history.replaceState.
Changes:

Added the alterChangeState to the options object and is used before pushState and replaceState;
The history entry's state object is cached with the document fragment;
The onPopState event now compares the state object along with the URI.

This allows navigating to the same URI with different states.

@mcaskill great work! Please update the readme with the new feature.

I've updated the branch: f1583c5
How does this work with you already having merged this PR?

Submit a new PR with just the readme change.


fix test_client.py tests

Got one set of tests working with a simple import change. Still haven't gotten the integration tests working.

Doesn't work in python 3.5 as yield isn't allowed in async functions.
Possible workaround is to use: https://github.com/python-trio/async_generator

I recommend removing testing on python3.5 and adding python3.7 instead. The tests will then work without any further changes

I believe we can close it in favor of #38 and #39
@AtomsForPeace thanks for the contribution!

@cecton I've filed #40

So I removed the unrelated stuff from this pull request. For example the tests fail at the moment because there's no support for jena. We can add that in the jena branch. I also removed testing on py35 because I saw that @cecton added that in the jena branch. I suggest we get the jena branch done and merge it into this branch. Or am I missing something? Thanks for the help

Or is everything already covered in #38? I see the conftest isn't there and a few other things

jena branch is merged into master.
Please feel free to update the PR

Or is everything already covered in #38? I see the conftest isn't there and a few other things

@AtomsForPeace  Yes! As I mentioned here, I have merged your changes on 8c9014acc27974c5b1a1b64e890e682d433e1342 mostly unchanged but we lost the author of the commit sorry.

(The build on master is red but I think it's a false negative)

Ok, thanks for merging. I'll close it now


Update scala-collection-compat to 2.8.1

Updates org.scala-lang.modules:scala-collection-compat from 2.8.0 to 2.8.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #666 (2f7e012) into master (b99ee39) will increase coverage by 1.49%.
The diff coverage is 71.18%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   86.45%   87.95%   +1.49%
==========================================
  Files         137      141       +4
  Lines        1491     1494       +3
  Branches       31       33       +2
==========================================
+ Hits         1289     1314      +25
+ Misses        202      180      -22

Impacted Files
Coverage Δ

src/main/scala/com/sksamuel/scapegoat/Level.scala
0.00% <ø> (ø)

...la/com/sksamuel/scapegoat/inspections/AnyUse.scala
100.00% <ø> (ø)

...ksamuel/scapegoat/inspections/DoubleNegation.scala
100.00% <ø> (ø)

...muel/scapegoat/inspections/LonelySealedTrait.scala
100.00% <ø> (ø)

...sksamuel/scapegoat/inspections/MaxParameters.scala
100.00% <ø> (ø)

.../sksamuel/scapegoat/inspections/NoOpOverride.scala
90.00% <ø> (ø)

...samuel/scapegoat/inspections/PublicFinalizer.scala
100.00% <ø> (ø)

...sksamuel/scapegoat/inspections/TypeShadowing.scala
100.00% <ø> (ø)

...om/sksamuel/scapegoat/inspections/VarClosure.scala
100.00% <ø> (ø)

...capegoat/inspections/collections/ArrayEquals.scala
100.00% <ø> (ø)

... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddf082...2f7e012. Read the comment docs.


The ADVANCED Pandemonium - Incorrect Line endings

https://github.com/Roll20/roll20-character-sheets/pull/11047

Fix: https://github.com/Roll20/roll20-character-sheets/pull/11051


Feature request: custom chat context

Really cool project, thank you so much !
Could the chat context be customized by the user ?
Each conversation could have its own context configuration and be tuned from the settings

Hey @juliendargelos, yep, this is planned!
Duplicate of #13

Hi, I just noticed the last release including hyperparameters, thanks ! It did not include the change I was hoping for though: what I meant in my first message was being able to change the initial prompt of a conversation, is this also planned ?

Ahh gotcha, yep, that's a good suggestion, will see if I can fit this into v1.3


feat: add initial EIP-7547 engine types

Motivation
Inclusion lists are being implemented by clients for a poc:
https://github.com/ethereum/go-ethereum/commit/3fd819994b654e7dd11000bb8eee7d3f3a3b9ad4
To do this for reth, we'll need to get the proper rpc types, so we can implement the calls in reth.
Solution
Implemented the types defined in https://github.com/michaelneuder/execution-apis/pull/1
PR Checklist

[x] Added Tests
[x] Added Documentation
[ ] Breaking changes

procedural question, should in-progress EIPs be homed in alloy-eips to minimize intrusion in other parts of the codebase?

procedural question, should in-progress EIPs be homed in alloy-eips to minimize intrusion in other parts of the codebase?

For this one it could be, since it would not cause any circular deps. But if an in progress eip needed a transaction type for example, it would cause problems. IMO despite this one not causing circular issues, it seems best to just have it as a draft PR to the place where it will eventually live (rpc-engine-types).

another option would be to have a specific crate alloy-eipXXXX for these while they're in progress and not accepted

another option would be to have a specific crate alloy-eipXXXX for these while they're in progress and not accepted

that makes sense!

another option would be to have a specific crate alloy-eipXXXX for these while they're in progress and not accepted

that makes sense!

This is now in the eip7547 crate


remove rouge + from sass source

A plus sign has sneaked into the sass source, this PR just removes that, so the sass source works again.

That whole line doesn't appear to work in Chrome v51. I had to do this:
border: solid transparent;
border-width: 0 0 7px 7px;

@Eonasdan any chance you could merge this in?

@Eonasdan Is anything wrong with this PR?


don't set BEARER_TOKEN in wrappers

Setting BEARER_TOKEN in the job environment is a potential security leak, exposing tokens in log files, etc. by the common practice to print the jobs environment for debugging. It's now set internally by ifdh v2_6_3 when a token file is discovered. Eventually gfal2 will support token discovery: https://its.cern.ch/jira/browse/DMC-1226.
Fixes #33

This looks fine, but is ifdh 2_6_3 out yet?   I believe Ken has a few tests where he sets up a specific ifdh release (rather than pulling the latest), so we'll have to let him know.

It's "released" in that it's in common products and declared "test". It's not in scisoft or larsoft yet, which is probably where Ken needs it.


Add multithreaded generation of measurements file with Gaussian distribution (M2 AIR took 24 seconds for 1B items)

No changes to the art of generation for the 1st version with nextGaussian function, but now just using all the available threads

Nice, thx!


Replays from newer patch uses older protocol

Replays from patch 15.6 (build 40087) and 15.7 (build 40322) both use the patch 15.5 (build 39951) protocol even though protocols for those two patches have been released.
Patch build is found in header#m_dataBuildNumand protocol used in header#m_version.m_baseBuild.
Need to figure out how to use that information sensibly.

Going through the lib/protocols, there are a number of patches that did not touch replays at all and are completely the same.
I believe it's just a courtesy update since the game engine changed variables (balance patch) but there was no need to change the underlying replay structure.
The header.m_dataBuildNum gives it a game engine version, while header.m_version.m_baseBuild tells you the structure to use.


Add AnyShow type for testing types without Show instance

@fsoikin Any objections? I think we can merge this.

Yep, looks good to me.

Published in v7.1.0


Compilation error on macOS (issue with boringssl)

Compile error both using CPython 3.6 and PyPy 6.0.0 (3.5.3) from MacPorts
Python 3.5.3 (fdd60ed87e941677e8ea11acf9f1819466521bf2, Jul 30 2018, 08:59:51)
[PyPy 6.0.0 with GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-9<IP_ADDRESS>)]

Python 3.6.6

Log:
b"In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:115:
/opt/local/include/openssl/e_os2.h:276:11: error: 'OPENSSL_EXPORT' macro redefined [-Werror,-Wmacro-redefined]
#  define OPENSSL_EXPORT extern
          ^
third_party/boringssl/include/openssl/base.h:182:9: note: previous definition is here
#define OPENSSL_EXPORT
        ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:83:31: error: redefinition of typedef 'ASN1_INTEGER' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_INTEGER;
                              ^
third_party/boringssl/include/openssl/base.h:244:31: note: previous definition is here
typedef struct asn1_string_st ASN1_INTEGER;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:84:31: error: redefinition of typedef 'ASN1_ENUMERATED' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_ENUMERATED;
                              ^
third_party/boringssl/include/openssl/base.h:240:31: note: previous definition is here
typedef struct asn1_string_st ASN1_ENUMERATED;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:85:31: error: redefinition of typedef 'ASN1_BIT_STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_BIT_STRING;
                              ^
third_party/boringssl/include/openssl/base.h:238:31: note: previous definition is here
typedef struct asn1_string_st ASN1_BIT_STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:86:31: error: redefinition of typedef 'ASN1_OCTET_STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_OCTET_STRING;
                              ^
third_party/boringssl/include/openssl/base.h:245:31: note: previous definition is here
typedef struct asn1_string_st ASN1_OCTET_STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:87:31: error: redefinition of typedef 'ASN1_PRINTABLESTRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_PRINTABLESTRING;
                              ^
third_party/boringssl/include/openssl/base.h:246:31: note: previous definition is here
typedef struct asn1_string_st ASN1_PRINTABLESTRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:88:31: error: redefinition of typedef 'ASN1_T61STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_T61STRING;
                              ^
third_party/boringssl/include/openssl/base.h:248:31: note: previous definition is here
typedef struct asn1_string_st ASN1_T61STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:89:31: error: redefinition of typedef 'ASN1_IA5STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_IA5STRING;
                              ^
third_party/boringssl/include/openssl/base.h:243:31: note: previous definition is here
typedef struct asn1_string_st ASN1_IA5STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:90:31: error: redefinition of typedef 'ASN1_GENERALSTRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_GENERALSTRING;
                              ^
third_party/boringssl/include/openssl/base.h:242:31: note: previous definition is here
typedef struct asn1_string_st ASN1_GENERALSTRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:91:31: error: redefinition of typedef 'ASN1_UNIVERSALSTRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_UNIVERSALSTRING;
                              ^
third_party/boringssl/include/openssl/base.h:250:31: note: previous definition is here
typedef struct asn1_string_st ASN1_UNIVERSALSTRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:92:31: error: redefinition of typedef 'ASN1_BMPSTRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_BMPSTRING;
                              ^
third_party/boringssl/include/openssl/base.h:239:31: note: previous definition is here
typedef struct asn1_string_st ASN1_BMPSTRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:93:31: error: redefinition of typedef 'ASN1_UTCTIME' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_UTCTIME;
                              ^
third_party/boringssl/include/openssl/base.h:251:31: note: previous definition is here
typedef struct asn1_string_st ASN1_UTCTIME;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:94:31: error: redefinition of typedef 'ASN1_TIME' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_TIME;
                              ^
third_party/boringssl/include/openssl/base.h:249:31: note: previous definition is here
typedef struct asn1_string_st ASN1_TIME;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:95:31: error: redefinition of typedef 'ASN1_GENERALIZEDTIME' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_GENERALIZEDTIME;
                              ^
third_party/boringssl/include/openssl/base.h:241:31: note: previous definition is here
typedef struct asn1_string_st ASN1_GENERALIZEDTIME;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:96:31: error: redefinition of typedef 'ASN1_VISIBLESTRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_VISIBLESTRING;
                              ^
third_party/boringssl/include/openssl/base.h:253:31: note: previous definition is here
typedef struct asn1_string_st ASN1_VISIBLESTRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:97:31: error: redefinition of typedef 'ASN1_UTF8STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_UTF8STRING;
                              ^
third_party/boringssl/include/openssl/base.h:252:31: note: previous definition is here
typedef struct asn1_string_st ASN1_UTF8STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:98:31: error: redefinition of typedef 'ASN1_STRING' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct asn1_string_st ASN1_STRING;
                              ^
third_party/boringssl/include/openssl/base.h:247:31: note: previous definition is here
typedef struct asn1_string_st ASN1_STRING;
                              ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:99:13: error: redefinition of typedef 'ASN1_BOOLEAN' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef int ASN1_BOOLEAN;
            ^
third_party/boringssl/include/openssl/base.h:233:13: note: previous definition is here
typedef int ASN1_BOOLEAN;
            ^
In file included from src/boringssl/err_data.c:18:
In file included from /opt/local/include/openssl/err.h:122:
/opt/local/include/openssl/ossl_typ.h:100:13: error: redefinition of typedef 'ASN1_NULL' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef int ASN1_NULL;
            ^
third_party/boringssl/include/openssl/base.h:234:13: note: previous definition is here
typedef int ASN1_NULL;
            ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [../pip-install-so7ktzhu/grpcio/objs/opt/src/boringssl/err_data.o] Error 1
"

What version of gRPC and what language are you using?
the last commit on the master branch
What operating system (Linux, Windows, …) and version?
macOS, 17.7.0 Darwin Kernel
What runtime / compiler are you using (e.g. python version or version of gcc)
Apple LLVM version 9.1.0 (clang-9<IP_ADDRESS>)
What did you do?
python3 setup.py build or pypy3 setup.py build
Standalone boringssl from the master branch can be compiled as expected with no errors:
mkdir build
cd build
cmake ..
make

same issue. OSX El Captain 10.11.6,  Python 2.7.11 pyenv
log of pip install -vvv grpcio:
ps://gist.github.com/erickertz/6b04284778bc267b2c1bc38b1755b5d4

So, let's go a bit over this. I'll start with the last mention first.

same issue. OSX El Captain 10.11.6, Python 2.7.11 pyenv
log of pip install -vvv grpcio:
gist.github.com/erickertz/6b04284778bc267b2c1bc38b1755b5d4

I'm guessing you're saying you've installed python through pyenv. I'm also going to assume you have pyenv installed through brew.
So on a clean mac, (unfortunately on High Sierra, I can't rollback to El Captain), I am doing the following:
Install brew following the instructions at https://brew.sh/
Install pyenv using brew install pyenv and modifying my ~/.bash_profile file according to the installation instructions.
Install python 2.7.11 using pyenv install 2.7.11 and activate it using pyenv global 2.7.11. Confirming I am using the pyenv 2.7.11 version by doing pip --version which shows it's running from my local pyenv folder.
Install grpcio using pip install -vvv grpcio.
--> This works properly.
So either this is an El Captain problem since that'd be the only difference, or there are other things about your environment you haven't specified. I had to do a few assumptions in how you got things installed to get there, but following the reproduction steps I just mentioned, grpcio installs fine.

Could you try the same using MacPorts?
sudo port install openssl pypy3
sudo /opt/local/lib/pypy3/bin/pypy3 -m ensurepip
/opt/local/lib/pypy3/bin/pip3 install grpcio --user

And the same for CPython:
git clone git@github.com:grpc/grpc.git
cd grpc
python setup.py build

Yes, I'm currently re-installing XCode to get a fresh Mac installation, this takes some time :-)

I appreciate the assistance.

Tried in High Sierra 10.13.6, Python 2.7.11 (by pyenv) Python 3.4 (compiled) Python 3.7 (package), failed to reproduce this error...
@Mottl
Have you compiled or installed OpenSSL or BoringSSL manually before? Did you update the submodules by git submodule update --init --resursive?

@Mottl Also, can you use command printenv to print the value of environment variables?

I can confirm the problem installing python with macport with an out of the box installation (without pyenv). I wasn't able to reproduce using brew and/or pyenv.
Digging very quickly, this seems to be a macports issue where it will inject OpenSSL's headers into the compilation line, which interferes with our own headers. I'm not sure what we could do right now about it, as it's Bad Practice (tm) from ports... I'll talk with @lidizheng about digging this further.

I think openssl was installed as binary via macports.
This is the info from python36 macports package:
Variants:             optimizations, universal

Description:          Python is an interpreted, interactive, object-oriented programming language.
Homepage:             https://www.python.org/

Extract Dependencies: xz
Build Dependencies:   pkgconfig
Library Dependencies: bzip2, expat, gettext, libedit, libffi, ncurses, openssl, sqlite3, xz, zlib
Runtime Dependencies: python_select, python3_select
Platforms:            darwin
License:              PSF
Maintainers:          Email<EMAIL_ADDRESS>GitHub: jmroot
                      Policy: openmaintainer

openssl is listed is a requirement for python36

Have you managed to run grpc with PyPy_ v6.0.0 (3.5.3)? If so, could you just upload pypy3 setup bdist_wheel?

/opt/local/include is the default installation path for headers for MacPorts and
-I /opt/local/include appended to all cc commands for sure.
Conflicting OpenSSL headers live in /opt/local/include/openssl/*

Here is the line that causes the problem:
cc -Ithird_party/protobuf/src -Ithird_party/googletest/googletest/include -Ithird_party/googletest/googlemock/include -I/opt/local/include -Ithird_party/cares -Ithird_party/cares/cares -Ithird_party/address_sorting/include -g -Wall -Wextra -Werror -Wno-long-long -Wno-unused-parameter -DOSATOMIC_USE_INLINED=1 -Wno-deprecated-declarations -Ithird_party/nanopb -DPB_FIELD_32BIT -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude -I/Users/user/grpc/gens -I/opt/local/include -I/usr/local/include -DNDEBUG -DINSTALL_PREFIX=\"/usr/local\" -DGRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK=1   -I/opt/local/include -Ithird_party/boringssl/include -fvisibility=hidden -DOPENSSL_NO_ASM -D_GNU_SOURCE -DWIN32_LEAN_AND_MEAN -D_HAS_EXCEPTIONS=0 -DNOMINMAX -std=c99 -Wsign-conversion -Wconversion -Wshadow -Wextra-semi   -Wno-sign-conversion -Wno-conversion -Wno-unused-value -Wno-unknown-pragmas -Wno-implicit-function-declaration -Wno-unused-variable -Wno-sign-compare -Wno-implicit-fallthrough -Wno-extra-semi -MMD -MF /Users/user/grpc/objs/opt/src/boringssl/err_data.dep -c -o /Users/user/grpc/objs/opt/src/boringssl/err_data.o src/boringssl/err_data.c
if I strip -I/opt/local/include it compiles. Commenting lines around 375 in Makefile doesn't make an effect...

Rawr. I was against putting these in the Makefile in the first place for reasons like these.

Still can't figure out from where else it takes -I/opt/local/include. Any suggestions?

@Mottl It maybe in https://github.com/grpc/grpc/blob/master/setup.py#L183

I still can't reproduce the error locally... I'm using the MacPorts to install openssl and Python3.6.
Can you try to run this setup.py and give me the print out variables?
https://gist.github.com/lidizheng/13c0cc9b09ac1f52a59c85a52ea4c3fd#file-setup-py-L187
It just add couple lines of printing to master's setup.py.

Please keep in mind I'm using python 3...
('src/python/grpcio', 'include', '.', 'third_party/boringssl/include', 'third_party/zlib', 'third_party/nanopb', 'third_party/cares', 'third_party/cares/cares', 'third_party/cares/config_darwin', 'third_party/address_sorting/include')
CORE_INCLUDE : ('include', '.')
SSL_INCLUDE : ('third_party/boringssl/include',)
ZLIB_INCLUDE : ('third_party/zlib',)
NANOPB_INCLUDE : ('third_party/nanopb',)
CARES_INCLUDE : ('third_party/cares', 'third_party/cares/cares', 'third_party/cares/config_darwin')
ADDRESS_SORTING_INCLUDE : ('third_party/address_sorting/include',)
EXTENSION_INCLUDE_DIRECTORIES : ('src/python/grpcio', 'include', '.', 'third_party/boringssl/include', 'third_party/zlib', 'third_party/nanopb', 'third_party/cares', 'third_party/cares/cares', 'third_party/cares/config_darwin', 'third_party/address_sorting/include')```

Just a few updates: I was able to reproduce the problem with pypy3, and I didn't attempt first using your python36 instructions. @lidizheng is going to look at pypy3 now after seeing it repro on my machine.
I just looked at the python36 stuff, and several things to note:

you can't git clone grpc like this. You need to close recursively (add --recursive to the clone command line).
your instructions don't get to a point where you can even run python setup.py build:

# python setup.py build
Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

Just a few updates: I was able to reproduce the problem with pypy3, and I didn't attempt first using your python36 instructions. @lidizheng is going to look at pypy3 now after seeing it repro on my machine.
I just looked at the python36 stuff, and several things to note:

you can't git clone grpc like this. You need to close recursively (add --recursive to the clone command line).

Ok, thanks, will do it...

your instructions don't get to a point where you can even run python setup.py build:

# python setup.py build
Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

pip install setuptools

I ended up doing python -m ensurepip.
The problem reproduces there too in all cases. @lidizheng is going to try reinstalling his work environment to get to the same state as mine :-)

@nicolasnoble, @lidizheng
Multiple -I/opt/local/include are generated by pkg-config --cflags ...
for example
pkg-config --cflags zlib
-I/opt/local/include

Look at Makefile:
CPPFLAGS += $(shell $(PKG_CONFIG) --cflags zlib)

So, let's go a bit over this. I'll start with the last mention first.

same issue. OSX El Captain 10.11.6, Python 2.7.11 pyenv
log of pip install -vvv grpcio:
gist.github.com/erickertz/6b04284778bc267b2c1bc38b1755b5d4

I'm guessing you're saying you've installed python through pyenv. I'm also going to assume you have pyenv installed through brew.
So on a clean mac, (unfortunately on High Sierra, I can't rollback to El Captain), I am doing the following:

Install brew following the instructions at https://brew.sh/
Install pyenv using brew install pyenv and modifying my ~/.bash_profile file according to the installation instructions.
Install python 2.7.11 using pyenv install 2.7.11 and activate it using pyenv global 2.7.11. Confirming I am using the pyenv 2.7.11 version by doing pip --version which shows it's running from my local pyenv folder.
Install grpcio using pip install -vvv grpcio.
--> This works properly.

So either this is an El Captain problem since that'd be the only difference, or there are other things about your environment you haven't specified. I had to do a few assumptions in how you got things installed to get there, but following the reproduction steps I just mentioned, grpcio installs fine.

OK, thanks for testing and trying to reproduce. All of your assumptions seem about right. If there is anything else about my environment you would like to know, just ask. I'm only trying to help.

Hi, @nicolasnoble
are there any news regarding this problem?

@lidizheng, thanks a lot!
Have you tried installing both zlib and openssl using MacPorts? Is that not enough to reproduce the error? Do you need some help from me? The root of the problem is pkg-config --cflags zlib. If you provide me with the updated Makefile with a separate CPPFLAGS for boringssl I will definitely can test it (and improve it to a ready-state if needed).

@Mottl I tried install both zlib and openssl using MacPorts. And then pypy3 and ensurepip, it will indeed trigger building grpcio from source distribution. But in my Mac, the output of pkg-config --cflags zlib is empty... So it compiled successfully.

@lidizheng, here is the contents of zlib package:
port contents zlib
Port zlib contains:
  /opt/local/include/zconf.h
  /opt/local/include/zlib.h
  /opt/local/lib/libz.1.2.11.dylib
  /opt/local/lib/libz.1.dylib
  /opt/local/lib/libz.a
  /opt/local/lib/libz.dylib
  /opt/local/lib/pkgconfig/zlib.pc
  /opt/local/share/doc/zlib/ChangeLog
  /opt/local/share/doc/zlib/FAQ
  /opt/local/share/doc/zlib/README
  /opt/local/share/doc/zlib/zlib.3.pdf
  /opt/local/share/examples/zlib/README.examples
  /opt/local/share/examples/zlib/enough.c
  /opt/local/share/examples/zlib/fitblk.c
  /opt/local/share/examples/zlib/gun.c
  /opt/local/share/examples/zlib/gzappend.c
  /opt/local/share/examples/zlib/gzjoin.c
  /opt/local/share/examples/zlib/gzlog.c
  /opt/local/share/examples/zlib/gzlog.h
  /opt/local/share/examples/zlib/zlib_how.html
  /opt/local/share/examples/zlib/zpipe.c
  /opt/local/share/examples/zlib/zran.c
  /opt/local/share/man/man3/zlib.3.gz

please notice /opt/local/lib/pkgconfig/zlib.pc
The contents of /opt/local/lib/pkgconfig/zlib.pc:
prefix=/opt/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
sharedlibdir=${libdir}
includedir=${prefix}/include

Name: zlib
Description: zlib compression library
Version: 1.2.11

Requires:
Libs: -L${libdir} -L${sharedlibdir} -lz
Cflags: -I${includedir}

May be you just put this /opt/local/lib/pkgconfig/zlib.pc to your system if for some reason it doesn't exists?

The same for openssl:
prefix=/opt/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: OpenSSL
Description: Secure Sockets Layer and cryptography libraries and tools
Version: 1.0.2p
Requires: libssl libcrypto

Makefile uses $(PKG_CONFIG) for these libraries:
CPPFLAGS += $(shell $(PKG_CONFIG) --cflags zlib)
CPPFLAGS += $(shell $(PKG_CONFIG) --cflags libcares)
CPPFLAGS := $(shell $(PKG_CONFIG) --cflags openssl) $(CPPFLAGS)
CPPFLAGS := $(shell $(PKG_CONFIG) --cflags protobuf) $(CPPFLAGS)

@Mottl Thanks for listing the pkg-config files, I have them installed using MacPorts. I guess I installed all of them once before while compiling Python manually.

I don't think there it does matters... Makefile is static (not generated by python) and it just invokes pkg-config --cflags zlib. Do you have zlib.pc, protobuf.pc and openssl.pc in /opt/local/lib/pkgconfig/?

Yes, that could be related. Please, keep in mind that Makefile has also these lines:
ifeq ($(SYSTEM),Darwin)
ifneq ($(wildcard /usr/local/ssl/include),)
INCLUDES += /usr/local/ssl/include
endif
ifneq ($(wildcard /opt/local/include),)
INCLUDES += /opt/local/include
endif
ifneq ($(wildcard /usr/local/include),)
INCLUDES += /usr/local/include
endif
LIBS = m z
ifneq ($(wildcard /usr/local/ssl/lib),)
LDFLAGS += -L/usr/local/ssl/lib
endif
ifneq ($(wildcard /opt/local/lib),)
LDFLAGS += -L/opt/local/lib
endif
ifneq ($(wildcard /usr/local/lib),)
LDFLAGS += -L/usr/local/lib
endif
endif

So /opt/local/include will be added toINCLUDES anyway.

But the Makefile isn't used by setup.py now, is it?

You are right. It is not... The setup.py will use Python setuptools to build the extensions.

Indeed, src/python/grpcio/commands.py line 277:
make_process = subprocess.Popen(
    ['make'] + extra_defines + targets,
    stdout=subprocess.PIPE,
    stderr=subprocess.PIPE)
make_out, make_err = make_process.communicate()

@Mottl I managed to reproduce the error (finally) by specify the PKG_CONFIG_PATH=/opt/local/lib/pkgconfig/. I guess if pkg-config is installed by MacPorts, this problem will occur.

Could you clarify, why do you think this is a problem of pkg-config? Setting CPPFLAGS and other flags is the purpose of pkg-config, or not?..

@Mottl There is a conflict between custom libraries and system libraries... If you force the Makefile to compile with the custom libraries (boringSSL etc.), it will work. Can you try this?
REQUIRE_CUSTOM_LIBRARIES_opt=1 /opt/local/bin/pypy3 setup.py build

Great! One second...

The root cause here is a mismatch between Makefile and commands.py. In currently logic, the Makefile will use system libraries as default (https://github.com/grpc/grpc/issues/11655), but in commands.py is forcing to compile libboringssl.a at here.
So, my solution will be:

Making Python build process aware of  REQUIRE_CUSTOM_LIBRARIES_$(CONFIG) variables, and adjust build target accordingly.
While building libboringssl.a detect whether HAS_SYSTEM_OPENSSL_ALPN is true or not, if it is true, log and exit to prevent future problems.

Great, thanks a lot! Are you planning to make a commit/PR?

@Mottl Yep, but it could take some time to ensure it is stable and doesn't break any thing.

Seems like there is a fix in the works here, but just wanted to add that I just updated to Mojave and am still having the same issue.

@erickertz Can you confirm it is the same issue with same error? Can you show the error log by adding -vvv flag?

@lidizheng sure thing:
https://gist.github.com/erickertz/0be9a44a42d2334174156303b72c6ef1

@erickertz The PR just got merged, can you try to install from the master branch, and see if the problem still exists or not? This fix will be included in next release, which will be weeks from now.

@lidizheng
Installed with PyPy 6.0.0 (3.5.3) just fine. Thanks a lot!

@Mottl Thank you for following the issue and providing suggestions ;)

Following build from source instructions from https://github.com/grpc/grpc/tree/master/src/python/grpcio below, which generate a 1.17.0 version still have the make failure on OS X Mojave 10.14.2 with eithe py27 or py36.
I also tried REQUIRE_CUSTOM_LIBRARIES_opt=1 GRPC_PYTHON_BUILD_WITH_CYTHON=1 pip install . too but does not work.
What is the right command to build from source now?
From Source
Building from source requires that you have the Python headers (usually a package named python-dev).

$ export REPO_ROOT=grpc  # REPO_ROOT can be any directory of your choice
$ git clone -b $(curl -L https://grpc.io/release) https://github.com/grpc/grpc $REPO_ROOT
$ cd $REPO_ROOT
$ git submodule update --init

# For the next two commands do `sudo pip install` if you get permission-denied errors
$ pip install -rrequirements.txt
$ GRPC_PYTHON_BUILD_WITH_CYTHON=1 pip install .

Error:
    [AR]      Creating /private/tmp/pip-req-build-AmG3JZ/libs/opt/libaddress_sorting.a
    [C]       Compiling src/boringssl/err_data.c

    src/boringssl/err_data.c:17:10: fatal error: 'openssl/base.h' file not found
    #include <openssl/base.h>
             ^~~~~~~~~~~~~~~~
    1 error generated.
    make: *** [/private/tmp/pip-req-build-AmG3JZ/objs/opt/src/boringssl/err_data.o] Error 1


a (link) tag added

My first pull request.
Help!

This is just a test message: it's horrible!

This is just a test message: it's horrible!


title:Node.js User Authentication Guide

description:This is a blog about you can authenticate users in Nodejs

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

[x] You created a branch from dev branch.
[x] You PR is raised on dev branch and not onmaster.
[x] Blog follows Blog Guidelines.
[x] You have read the Contribution Guidelines before creating this PR.
[x] Checked for any duplicate blog entry.
[x] Checked for all grammatical errors in the blog.
[x] You have not published the blog content anywhere else on the internet on platforms like medium, dev.to etc.
[x] The content is not copy-pasted from anywhere else on the Internet.

Description of change

Duplicated by #950


nimble-table data doesn't render in Safari

🐛 Bug Report
When you open a demo page that contains a nimble-table in Safari, the table shows empty cells and there are errors in the dev tools console.
💻 Repro or Code Sample
Visit https://nimble.ni.dev/storybook/example-client-app/#/customapp in Safari and scroll to the table example
🤔 Expected Behavior
Table renders data like it does in other browsers.
😯 Current Behavior

Repeated console errors:
[Error] TypeError: undefined is not an object (evaluating 'n.appendChild')
	runGuarded (polyfills.54ab400a48eba0a6.js:1:2165)
	appendChild
	appendTo (main.a4d212b3f0e17485.js:1:264961)
	render (main.a4d212b3f0e17485.js:1:268254)
	renderTemplate (main.a4d212b3f0e17485.js:1:244195)
	finishInitialization (main.a4d212b3f0e17485.js:1:243793)
	onConnectedCallback (main.a4d212b3f0e17485.js:1:242794)
	connectedCallback (main.a4d212b3f0e17485.js:1:244616)
	connectedCallback (main.a4d212b3f0e17485.js:1:257647)
	runGuarded (polyfills.54ab400a48eba0a6.js:1:2092)
	insertBefore
	insertBefore (main.a4d212b3f0e17485.js:1:265051)
	d$ (main.a4d212b3f0e17485.js:1:261462)
	handleChange (main.a4d212b3f0e17485.js:1:263178)
	notify (main.a4d212b3f0e17485.js:1:231601)
	call (main.a4d212b3f0e17485.js:1:233925)
	i (main.a4d212b3f0e17485.js:1:229445)
	o (main.a4d212b3f0e17485.js:1:229526)
	(anonymous function) (polyfills.54ab400a48eba0a6.js:1:28207)
	runTask (polyfills.54ab400a48eba0a6.js:1:2590)
	invokeTask (polyfills.54ab400a48eba0a6.js:1:8243)

💁 Possible Solution
Not a solution, but some initial debugging showed:

In Firefox, cellTemplateChanged() (in cell/index.ts) is called many times but this.isConnected is false so it exits early.
In Safari, cellTemplateChanged() is being called many times but this.isConnected is true. However this.cellContentContainer is undefined. This results in a call within FAST code to view.appendTo(undefined) and thus undefined.appendChild().

🔦 Context
First noticed when testing virtualization in different browsers: https://github.com/ni/nimble/pull/966#discussion_r1080531857
When this is fixed we should re-validate that scrolling performance is good in Safari (no flickering).
🌍 Your Environment

OS & Device: macOS 13.1
Browser: Safari
Version: 16.2 (186<IP_ADDRESS>.5)

@msmithNI also reproduced in the Windows WebKit build from Playwright: https://playwright.azureedge.net/builds/webkit/1751/webkit-win64.zip

Possibly related FAST bug: https://github.com/microsoft/fast/issues/6537
It links to a webkit bug which is closed as "expected behavior" due to a recent web components spec change and discussion about whether the spec change is a good idea.

@rajsite noticed that the table cell has an isConnected call that should be $fastController.isConnected. I tried that locally and it fixed the issue in the Playwright Webkit at least. Can you try it out in the real Webkit / on your Mac?

Sweet! It fixes it for me!


[discuss] Consider a new 8.3 release if vim 9 is still not ready ?

Consider a new 8.3 release if vim 9 is still not ready ?
Enough new features and vim9 script can also be marked as "RC" status.
The "RC" status is good to encourage people switch to the new script and collect feedbacks.
And the final vim9 can be released after it becomes more stable or more powerful (support class or something).

I think we can close this, as it seems we are coming closer to an actual Vim 9 release: https://groups.google.com/g/vim_dev/c/E37hUdqPBQw/m/bSau2ZfyAQAJ


Support octal literals

As title, this PR basically implement support for octal literals in numeric constants and function parameters.

You should extend the test suite for octal literals.

I just added some test cases for octal literals, but I found that the current testing method has significant limitations. It seems like it can only test values between 0 and 255. Additionally, testing for negative numbers requires handling through printf. Should we consider improving our testing process to handle a broader range of cases more efficiently? What are your thoughts on this?

I just added some test cases for octal literals, but I found that the current testing method has significant limitations. It seems like it can only test values where the final result is between 0 and 255 (a byte) . Additionally, testing for negative numbers requires handling through printf. Should we consider improving our testing process to handle a broader range of cases more efficiently? What are your thoughts on this?

You can create a new issue to track the improvements of the test suite.

Thank @fennecJ for contributing!


 Everything works now despite these errors, but how can I fix them? Thanks for you help!

I have no idea of your setup, but try giving this a try. Change the *.svg?component-typing to this:
declare module '*.svg?component' {
  const content: ConstructorOfATypedSvelteComponent
  export default content
}

Let me know if that helps?

I've made a new release where I think this issue may be solved.
Feel free to re-open this issue if the problem persists.

Hello,
I am having a similar issue to this. I have added
declare module '*.svg?component' {
	const content: ConstructorOfATypedSvelteComponent
	export default content
}

but I am still getting an error with it

I am not sure what I am missing?

Hi @tcherokee. Perhaps you'r on an old version of SvelteKit? Either upgrade or change the type to any.
Hope that helps.

I'm not sure why, but putting the declare module '*.svg?component' section in app.d.ts isn't working for me as I still get Cannot find module with an import like $lib/images/dev.svg?component. I have other things in the app.d.ts that DO work as expected - for example a session added to App.Locals.
Experimenting a little, I found putting it in a .d.ts beside the .svelte file works. In my case this is my global +layout.svelte and the declaration works if it lives in +layout.d.ts.
Of course this is unlikely to be caused by an issue in this library, but does anyone know the cause, and do the docs here need to be updated?

Tanks for the message @coldino, very much appreciated.
In my personal opinion there are too many moving parts when it comes to a project and how TS and type-resolution etc is setup, that it feels more or less like a guessing-game getting all these things to work 😂
Now, if anyone makes a PR with more sensible defaults, I'll be the first to merge it ☺

Also looking for solutions. @coldino your workaround does work, indeed.

i created the ./src/ambient.d.ts file then added the declare stuff inside and it worked without any issues. Having it in the app.d.ts doesn't work, I confirm.

i installed with bun and got this issue
i think maybe bun doesn't add the typing ?
I just added the type to app.d.ts
declare module '*.svg?component' {   const content: ConstructorOfATypedSvelteComponent   export default content }

i installed with bun add --dev @poppanator/sveltekit-svg and got this issue. I think maybe bun doesn't add the typing (idk). I just added the type to app.d.tsand that worked for me
declare module '*.svg?component' {
  const content: ConstructorOfATypedSvelteComponent
  export default content
}

@Porter-smith Did you try this? https://github.com/poppa/sveltekit-svg/#typescript

Oh I see ! I didn't realize it had that thank you !


Support category selection

Mainly UI work.

Probably easier after #2362 is done.

Closing and keeping the other one to track both.


Set AppArmor profile to unconfined

We don't want to use AppArmor for the machine pod, independent of
whether it's enabled in the host environment or not.
/invite @timebertt

/hold


756 swag sync 3

Adds support for aliasing spinnaker names and custom fields s3_name and canonical_id.
Also modifies the behavior of _update_custom_fields such that, fields are not implicitly set to null. _update_custom_fields will only update fields that are passed.
In order to clear a custom field you must explicitly pass field_name=None.

Coverage decreased (-0.07%) to 68.757% when pulling c63827b3cee1fff39f04614305627d86f0abaf3a on kevgliss:756-swag-sync-3 into 1a2312e89172279bcaf4fba283cf88ee3eff097d on Netflix:develop.

Coverage decreased (-0.07%) to 68.755% when pulling 89658c23c4e92812b6571443d27c4a100abb64d7 on kevgliss:756-swag-sync-3 into 1a2312e89172279bcaf4fba283cf88ee3eff097d on Netflix:develop.


[FIX] Minor change to spin sample generation

Pre-generates kdtrees for computational efficiency. Also reverse matching of rotated --> original to original --> rotated for ease of use.

Codecov Report

Merging #77 into master will increase coverage by 0.19%.
The diff coverage is 81.25%.

@@            Coverage Diff            @@
##           master     #77      +/-   ##
=========================================
+ Coverage    63.5%   63.7%   +0.19%
=========================================
  Files          22      22
  Lines        1488    1507      +19
=========================================
+ Hits          945     960      +15
- Misses        543     547       +4

Impacted Files
Coverage Δ

netneurotools/tests/test_stats.py
100% <100%> (ø)
:arrow_up:

netneurotools/stats.py
80.64% <76%> (+2.03%)
:arrow_up:

netneurotools/plotting.py
7.1% <0%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e02a5c...cfed352. Read the comment docs.


usage of --currency switch on prices and excel sheet

Hello,
I use kicost 1.1.4 with the switch currency set to EUR.
I have two remarks.

for a specific part, if i look at the distributor web site, the price given on the xls is slightly different. Is that a currency conversion is made within kicost itself?
for each distributor part number, there is a comment made showing the Qty/price break. The price are still in USD and not in EUR. More over, is it possible to enlarge the comment area? most of the time, there is not enough space to show the entire information.

Thanks for your excellent work!!

Yes, the conversion was introduced by me, it prioritize the values passed by the distributors and made conversion by CurrencyConverter python module, when not present. Usually, by the API, the distributors just provide USD or USD+EUR (but not always).
You can update CurrencyConverter, that have a static conversion database. Also, the spreadsheet have the currency rate listed bellow all your parts (edit them to update the values).
Because of this behavior: the currency rate may not be up-to-date and to use a online server to do that was necessary an API and user login and, the comments-balloons are static (doesn't change with the update of the cell with the current rate). I kept them as original distributor currency, it is not the best but it was what I though at the moment.

Hi @hildogjr,
Is it possible to retrieve the data in EUR instead of USD? I mean without converting the price within the python? If look at mouser for instance, the prices migth be significantly different when I look at the website... The available quantity as well...

Hi @hildogjr,
Is it possible to retrieve the data in EUR instead of USD? I mean without converting the price within the python? If look at mouser for instance, the prices migth be significantly different when I look at the website... The available quantity as well...

Yes, just not use --currency on call.
Some distributor have native USD and EUR and KiCost prioritize USD, but I didn't remember if EUR get deleted in this case on api_partinfo_kitspace.py functions.
The difference in qty is because we use KitSpace API, that update it database time-by-time on demand. The ffinal solution to this is have suport for all distributors APIs, but it demands some code https://github.com/xesscorp/KiCost/issues/386.

Yes, just not use --currency on call.
Some distributor have native USD and EUR and KiCost prioritize USD, but I didn't remember if EUR get deleted in this case on api_partinfo_kitspace.py functions.
The difference in qty is because we use KitSpace API, that update it database time-by-time on demand. The ffinal solution to this is have suport for all distributors APIs, but it demands some code https://github.com/xesscorp/KiCost/issues/386.

Now I'm confused. I removed the switch --currency and I have the same results. I thought everything would be in USD in this case...

Now I'm confused. I removed the switch --currency and I have the same results. I thought everything would be in USD in this case...

No sorry. I talked too fast sorry. USD by default without the switch.
I've been looking at the code but I can't find a way to retrieve the data in EUR form Mouser (as an example).
Moreother, I see a py file for octopart. Does the tool support octopart queries instead of kitspace?

No sorry. I talked too fast sorry. USD by default without the switch.
I've been looking at the code but I can't find a way to retrieve the data in EUR form Mouser (as an example).
Moreother, I see a py file for octopart. Does the tool support octopart queries instead of kitspace?

I think, specific Mouser (I am not sure) just have EUR in the KitSpace API, so USD is internally generated.

I think, specific Mouser (I am not sure) just have EUR in the KitSpace API, so USD is internally generated.

For Mouser, I don't know. it seems to me everything out of the call to KitSpace API is in USD or GBP.
I tried to switch to Octopart as you suggested:
api_octopart.query_part_info(parts, distributor_dict, currency).
It crashes so far.

For Mouser, I don't know. it seems to me everything out of the call to KitSpace API is in USD or GBP.
I tried to switch to Octopart as you suggested:
api_octopart.query_part_info(parts, distributor_dict, currency).
It crashes so far.

You need you on KEY / license / registration to run Octopart.
GBP is the base currency for RS, if I remember...

You need you on KEY / license / registration to run Octopart.
GBP is the base currency for RS, if I remember...

yes indeed, there is a key required along with a registration.
So, what's the current status for kicost? do you have a roadmap for future improvement of the tool?

yes indeed, there is a key required along with a registration.
So, what's the current status for kicost? do you have a roadmap for future improvement of the tool?

I have a personal roadmap
https://github.com/xesscorp/KiCost/milestones
but not time to develop all by my self.

I have a personal roadmap
https://github.com/xesscorp/KiCost/milestones
but not time to develop all by my self.

There was some changes @set-soft  of how the prices currencies are converted. @sebo83910, could you check the last code on this repository?

Now we update the currency conversion. So differences should be (now) some distributor detail.
Now Octopart can be enabled from command line and/or environment. Seems to be working.
I verified that using --currency EUR we are selecting the values in EUR (when available of course)

For the above reasons, and the lack of reply, I'm closing this issue


Update dependencies

Updates dependencies.

It'd be good to have this update, but since the monitoring has problems, I don't know if we should update it anything.

nevermind started over


NODE|12-lts i snot valid

the valid list is here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4cdb7930-0ada-090c-7f95-eafcabf3ad66
Version Independent ID: 850011e6-6f39-0574-6438-8811373f6846
Content: Quickstart: Create a web app on Azure Arc - Azure App Service
Content Source: articles/app-service/quickstart-arc.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@munir94 Thank you for your feedback! We will review and update as appropriate


Fix bug: crashing when there is no lived server in heartbeat branch

I found one important bug. and fixed it. Thank you.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Dont send pylance telemetry when skipping it for notebooks

For https://github.com/microsoft/vscode-jupyter/issues/7943
Don't send pylance telemetry when the middleware skips it.

Talked with Jake. Going to try something different.


toJSON() not working with AnimationMaterials

As far as I can tell using builtin toJSON() is not working.
I have a mesh using a BAS.StandardAnimationMaterial() and get the following error if I try to mesh.toJSON():
Uncaught TypeError: Cannot read property 'isTexture' of null

actually I just want to parse the toJSON() Object as a string to compare two instances and debug another error I am currently dealing with. Maybe the error might be related to this.
I am trying to clone the mesh to place it multiple times in my scene at different positions. But if I clone the mesh using the StandardAnimationMaterial(), somehow the shadows break. I also tried to add a new customDepthMaterial to the cloned Mesh, but without success.
Further debugging lead me to the point where I wanted to clone only a BasicAnimationMaterial and here it says:
Uncaught TypeError: Cannot read property 'uniformValues' of undefined

I'm not used to the cloning workflow, so I've never tested it, and I'm not sure what kind of things might break because I don't implement the clone/copy methods on any of the BAS geometries and materials (they just use the method from the THREE.js class they're extending). I can look into adding clone/copy methods, but that may take some time.
If you want to create several meshes, you might be better off either creating a mesh subclass with the geometry and material (like Animation here, and creating instances of that, or working with a factory function.

I can look into adding clone/copy methods, but that may take some time.

Don't worry, thanks for all your work on this anyway, very helpful to inject built-in THREE Shaders :).

If you want to create several meshes, you might be better off either creating a mesh subclass with the geometry and material (like Animation here, and creating instances of that, or working with a factory function.

The Subclass thing might be an option and actually is kind of close to the way I work around the problem at the moment. I simply create a new THREE.Mesh() Instance each time I used to clone instead. What do you mean by factory function?


Proposal: abstract layer ID and image(json) ID

spec for abstracting layer ID (created by tarsum to have a deterministic ID) and the image ID (which is the json metadata, which references a particular layer ID)
Initially, a deterministic image ID will not be directly possible, as the usual TarSum calculation includes the contents of the image's json metadata, which itself includes the image's ID.
Once the file system layer has a deterministic ID, generated with a fixed-time hash (the TarSum), but not including that json metadata, then it will be possible to deduplicate layers that are exactly the same. This may happen often, as the primary differences will be in the json metadata (this could happen in a RUN, but also for MAINTAINER, ENV, PORT, ENTRYPOINT, CMD and VOLUMES).
Therefore multiple images(json) could reference the same layer IDs.
The next step of the image(json) ID, for it to be deterministic, the ID must not be inside the json itself. Perhaps since it is already in a directory path of .//json, then the ID is inferred from its path, and verifiable by checksuming the json with the layer ID that it references.

@vbatts Is this still relevant? We still need to decouple image ID from the layer ID, but I am not sure if this proposal is still on the happy path.

fair. this is really about content addressability. I'm fine with closing this issue as we're on the path already

@vbatts The separation is still an open issue in the engine and one of the blockers for proper v2 support. The specific problem is github.com/docker/docker/graph.(*Graph).Register:
func (graph *Graph) Register(img *image.Image, layerData archive.ArchiveReader) (err error)

Effectively, this means we have to write layers and some image at the same time. This is fairly uncomfortable. Ideally, we'd like to be able write the layer data at a separate time and then merge or link them when both are resolved.
We'll file another PR/proposal along these lines when the timing is right. I'll probably reference this at that time but let's leave closed for now, since it doesn't go into the proper detail.

sounds good.
On Tue, Jul 7, 2015 at 11:33 AM, Stephen Day<EMAIL_ADDRESS>wrote:

@vbatts https://github.com/vbatts The separation is still an open issue
in the engine and one of the blockers for proper v2 support. The specific
problem is github.com/docker/docker/graph.(*Graph).Register
http://godoc.org/github.com/docker/docker/graph#Graph.Register:
func (graph *Graph) Register(img *image.Image, layerData archive.ArchiveReader) (err error)
Effectively, this means we have to write layers and some image at the same
time. This is fairly uncomfortable. Ideally, we'd like to be able write the
layer data at a separate time and then merge or link them when both are
resolved.
We'll file another PR/proposal along these lines when the timing is right.
I'll probably reference this at that time but let's leave closed for now,
since it doesn't go into the proper detail.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/6959#issuecomment-119240756.


Add support for encrypted key files, with a passphrase, to Client::key_file=()

Hi. I didn't see any info for submitting PRs to the main project, but when I realized how simple a change this was, sending the request seemed to be the best option.
I ran into this need because the app I'm building, which uses MQTT, needs to have the cert files added to the repo. Even though the repo is private, having an un-encrypted private key file is still a non-starter for us, security-wise.
This solution allows for the optional addition of a passphrase, along with the path to the private key file, as an Array tuple. This array is then deconstructed down into the original path argument, and a passphrase argument, if present.
When these two arguments, the second of which might be nil, are passed to OpenSSL::PKey::RSA.new(), it basically just works.
I've added two additional RSpec examples, specific to the private key file:

The first verifies the successful decryption, with the correct passphrase.
The second verifies the OpenSSL::PKey::RSAError exception is raised, when an encrypted private key is accessed, with an incorrect passphrase.

I've also generated an encrypted version of spec/fixtures/client.key, named client.pass.key, which has been AES256 encrypted, using a passphrase of mqtt.

Hm... Not sure what the cause of those travis bundle errors are. I'm not a travis-ci user, nor have I used this form of the bundle command:
bundle install --jobs=3 --retry=3

But, if this is something you want me to try and track down, I'm certainly willing to do so. Just point me in the right direction.
I'm guessing I might need to install all of the ruby versions you're testing against, and then run those builds locally to ensure they all work? But, that wouldn't replicate the travis-ci environment, so I'm not sure how useful that would ultimately be...

Thanks for this pull request Brian. There shouldn't be anything different/special about the the Travis environment.
I suspect that the problems aren't related to your change but have something to do with a new version of the Gem gem. I will try re-running the tests on Master.

Hm, build just succeeded:
https://travis-ci.org/njh/ruby-mqtt/builds/87757971

Unable to re-produce the Travis errors. I checked out your branch and it works fine on my own machine:
$ rbenv version
1.9.3-p551 (set by /Users/humfrn01/Projects/ruby-mqtt/.ruby-version)
$ ruby --version
ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-darwin14.5.0]
$ bundle --version
Bundler version 1.11.2
$ gem --version
2.5.2
$ bundle install --jobs=3 --retry=3
Resolving dependencies...
Using rake 10.4.2
Using diff-lcs 1.2.5
Using docile 1.1.5
Using mqtt 0.4.0 from source at `.`
Using multi_json 1.11.1
Using rspec-support 3.0.4
Using simplecov-html 0.9.0
Using yard <IP_ADDRESS>
Using bundler 1.11.2
Using rspec-core 3.0.4
Using rspec-expectations 3.0.4
Using rspec-mocks 3.0.4
Using simplecov 0.9.2
Using rspec 3.0.0
Bundle complete! 6 Gemfile dependencies, 14 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
$ bundle exec rake
/Users/humfrn01/.rbenv/versions/1.9.3-p551/bin/ruby -I/Users/humfrn01/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/rspec-core-3.0.4/lib:/Users/humfrn01/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/rspec-support-3.0.4/lib -S /Users/humfrn01/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/rspec-core-3.0.4/exe/rspec ./spec/mqtt_client_spec.rb ./spec/mqtt_packet_spec.rb ./spec/mqtt_proxy_spec.rb ./spec/mqtt_sn_packet_spec.rb ./spec/mqtt_version_spec.rb ./spec/zz_client_integration_spec.rb
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 11.13 seconds (files took 0.27677 seconds to load)
692 examples, 0 failures
Coverage report generated for RSpec to /Users/humfrn01/Projects/ruby-mqtt/coverage. 2999 / 3052 LOC (98.26%) covered.

Thanks for submitting the PR!

Problem with with a dodgy version of Bundler on Travis.
Fixed with 7e7a7de3c196aeb4ccb8368792e507dd32c38f97

You're welcome. Thanks for the quick merge turnaround!


(Fixes issue 18) Add AMO documentation

Opening on behalf of @peiying2

@flodolo This doc is very hard to write, :). There is a great chance you will say "I am lost".
Two things that I am considering:

extracted strings and localized strings - when they will be available where (dev, staging, and product) - should we create a table for easier visual reference vs. description?
the configuration for testing to test the three components and maybe more, should I take screenshots?

To get into the details with testing, it is quite complicated.

I'm going to do another round of checks later today, and I'll try to rebase.
 History changes when you rebase (see last night…), so you need to do:
git pull
git reset --hard origin/issue18

Ignore warnings or messages that appear when you do git pull.

I'll remove the last section, because it simply doesn't seem to work. Also, the instructions don't make a lot of sense on the Certificate part, you don't add exceptions from there.
For reference, the text at this point was:
## Advanced Configuration for testing strings from addons-frontend

The above instruction is sufficient for basic localization testing. If you need to test strings related to the install buttons, you will need to enable preferences to allow add-on installation to work on the development and stage servers.

To fully configure Firefox to install add-ons on either dev or stage server, you will need to do the following:

* Use Firefox Nightly or Firefox Developer Edition.
* A new profile is recommended since changing the dev certs will mark existing add-on installs as invalid (this change is not immediate).
* Go to `about:config` and set `extensions.webapi.testing` as a Boolean to `true`.
* To install an add-on, you will need to be able to install a signed add-on from dev or stage. Create the `xpinstall.signatures.dev-root` pref in `about:config` as a Boolean and set it to `true`.
* For Disco Pane: go to `about:config` and change the host in `extensions.webservice.discoverURL` to `https://discovery.addons-dev.allizom.org/` for Dev server or `https://discovery.addons.allizom.org/` for Staging server.
* If you see warnings when trying to install a theme or theme previews don’t work, go to the `Privacy & Security` panel in Preferences and add an exception for dev or stage. You can do so by clicking the `Exceptions` button after selecting  on left panel.
* Restart the browser.

Please check the changes
https://github.com/mozilla-l10n/localizer-documentation/pull/52/commits/5a27db0effa645aab8285fe69743292be102306f
Also remember to always add testing docs to l10n_testing.md
Note that you need to review this PR, since I'm the one who opened it.

Updated https://github.com/mozilla-l10n/localizer-documentation/pull/52/commits/2f8fe5bb90e70e549c9b9e06a5ba1b52dbc95aed


Android manifest deleted

This plugin deletes my android manifest, not cool. its been 2 years since the first time you said you'll fix this, why do you have such a dangerous command in public

@ShinigamE95, sorry to hear about that, but you can get your android manifest files back by running
flutter create .
I will spear sometime this weekend to improve this package, sorry once again, I have been on other packages

I will keep this open until I update the pacakge

I also faced to such problem. Until visit this issue site I did not know that it is so dangerious. I fixed it by creating a new flutter project and copying my project files and reconfiguration.