Gearbox Docsy theme integration

@zacharysarah
In order to base the Kubernetes Hugo site upon the Docsy theme, this site was originally built upon a fresh Hugo project with Docsy installed. This was necessary in order to achieve iterative successful Hugo builds. This PR represents the end result of those changes, applied off of the current master.
Staging site @ https://kubernetes-docsy-staging.netlify.app/

@aidanranney 👋 Thanks for opening a pull request! In order for us to accept the PR, you'll need to sign the contributor license agreement.

Netlify is throwing a build error:

12:37:15 PM: ERROR 2020/05/10 19:37:15 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

That's the error Hugo throws for a site version pre-0.60.0. We'll need to merge #19907 before this PR's preview builds successfully.
@jimangel @kbarnard10 @sftim @kbhawkey @onlydole

We'll need to merge #19907 before this PR's preview builds successfully.

I think we can tackle the couple obvious defects and maybe @bep could help with a conversation script.
If we get it passable along with majority of content legible, maybe we merge and open issues on top?
Would be a good convo for the weekly meeting.

Thanks @zacharysarah! I've passed the license agreement along to Troy to sign up the organization.

@aidanranney 👋 Please rebase when you have a chance. We merged the dependencies blocking this PR from building on its own merits.

After some experimentation, I'm able to run the build locally. 🎉 Here's how I did it:
In my local repo, I ran:
git remote add gearbox-built git@github.com:gearbox-built/website.git
git fetch --all
git checkout -b kubernetes-docsy gearbox-built/kubernetes-docsy

Because it's my first time adding the submodule, I had to run:
git submodule update --init --recursive

Subsequent updates can omit the --init flag.
The usual make serve works fine to instantiate a server locally.
We need to figure out how to get some version of git submodule update <--flags> into the build command for this PR.

I notice that Prow sees this as: cncf-cla: no

@zacharysarah after reviewing the deploys for the Gearbox staging and this one, it appears that all deploys at kubernetes-docsy-staging are passing. Comparing the deploy logs highlights this error:
4:24:10 PM: Error: Error building site: POSTCSS: failed to transform "scss/main.css" (text/css): /opt/build/repo/node_modules/fs-extra/lib/mkdirs/make-dir.js:86

Following backwards to:
4:22:51 PM: notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})

I can confirm locally after rolling back Node version 8.17.0 that the same error occurs on build as here. The Node version on the staging Netlify is 10.20.1.

I cleared the cache and kicked off the build again and saw
6:50:43 PM: Attempting ruby version 2.3.6, read from environment
6:50:44 PM:
6:50:44 PM: ** WARNING **
6:50:44 PM: Using custom ruby version 2.3.6, this will slow down the build.
6:50:44 PM: To ensure fast builds, set the RUBY_VERSION environment variable, or .ruby-version file, to an included ruby version.
6:50:44 PM: Included versions: 2.6.2
6:50:44 PM:
6:50:44 PM: Required ruby-2.3.6 is not installed - installing.

@aidanranney Thanks for diagnosing that it's the Node version. If we're setting it artificially low, it's not immediately visible how. Time to go digging in the netlify docs...

@aidanranney I think we figured it out. When #20963 merges, please rebase this PR on master.

Success! 🎉 We have a preview build available for testing:
https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/

Testing for bugs in the preview
Hi, folks! 👋 We have a working preview for the Docsy theme on the website:
https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/
Testing goals
Our goal is to find issues specific to Gearbox's implementation of Docsy for Gearbox to fix.
Specific examples include:

Line breaks between icons and text on the blog page

Links for "smoke test" and "search results" shouldn't appear in the left rail

Non-goals
Out of scope for this PR:

Fixing things that are broken in Docsy, or that we wish were different about Docsy.
File Docsy bugs upstream in the Docsy repo.

Fixing broken Markdown.
One example of this is the API Priority & Fairness page:

How the preview looked when I fixed it
How that fix looks in production
How it looks in the Docsy preview

The page needs repairs, but it's not Docsy-related, and therefore out of scope for this PR.
Limit the scope of feedback
Limit feedback on this PR to bugs that are specific to this PR's implementation.
If you see bugs for things that are already broken in production, open a separate issue.
If there's a formatting issue particular to Docsy (for example, you'd rather something be blue than orange), open a separate issue in this repo and consider opening an issue upstream in the Docsy repo.

Text “Edit this page” is not localized
For example: https://deploy-preview-20964--kubernetes-io-master-staging.netlify.app/fr/docs/home/supported-doc-versions/ has text “Edit This Page” whereas the same French page without Docsy has equivalent text “Editez cette page” (correctly localized).

Page footer not localized
The footer text of https://kubernetes.io/uk/docs/home/ (HTML <footer /> element) is localized to Ukrainian.
The footer text of https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/uk/docs/home/ is in English.

Docsy site lacks fallback links to English content
Have a look at https://kubernetes.io/id/docs/concepts/configuration/secret/
This is in bahasa Indonsia. At the time of writing the ConfigMap concept is not localized into bahasa Indonesia, so this is how the page renders the fallback link:

The Docsy version is missing that fallback link.

Thanks for feedback submitted shown even before feedback submitted
Near the end of the content for https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/docs/setup/release/version-skew-policy/ is the text “ Thanks for the feedback. If you have a specific, answerable question about how to use Kubernetes, ask it on Stack Overflow. Open an issue in the GitHub repo if you want to report a problem or suggest an improvement.”
On https://kubernetes.io/docs/setup/release/version-skew-policy/ that text is only revealed when I click “Yes”.

Search box needs padding-top upon scroll

I'm not sure what the ideal solution for this is, because adding padding-top directly to ..td-sidebar__search causes it to be misaligned when not scrolling.
Search box is unusable upon scroll due to overly tall .navbar-brand element
This screenshot probably illustrates it best:

The Kubernetes logo in the header overflows its containing div. This prevents anyone from actually clicking on the search box.

Neither of these issues are present when scrolled to the top of the page. Issues are present on https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/docs/home/ and any page that uses the same layout file (presumably `single.html).

Feedback buttons are unstyled

This theme uses bootstrap, so I expect that these would have the btn btn-default classes.

** some<pre> elements are missing a border**
Best seen on this page:

fwiw, it seems to be consistent – when the underlying codeblock does not have a language specified, no border is rendered.
May be more of a docsy theme thing rather than a gearbox implementation thing.

Nit/not a blocker: Notes/blockquotes probably need a little more padding
This is very subjective feedback and can be ignored if required. I mention it only because I see that we've modified Docsy's original implementation of blockquotes to fit our exsiting design:
Current: (with padding: 0 0 0 1rem)

Personally, I'd go with a little more padding. This is what padding: 0.4rem 0.4rem 0.4rem 1rem looks like:

On the whole I like the slightly more condensed look for notes, however :)

Nit/not a regression: tooltip text on headers is too big

From here.
The tooltip text is taking the scale/size of the header text it is attached to.
This is fairly simple to fix by specifying a font size and weight in .glossary-tooltip:hover .tooltip-text:
font-size: 1rem;
font-weight: 400

Note that this happens on our existing site too. It's not a regression, but I think it'll be easier if I mention it here rather than correct it myself – it's not urgent and will save us a potential merge conflict.

At smaller breakpoints, the hamburger close button is not styled
This is the top menu – specifically .push-menu-close-button:

On mobile, search box text isn't visible
Not sure if this was intentional or not, feel free to ignore.

** Mobile top navbar does not display navbar-brand, but li still takes up room, link is still display: inline-block and has clickable link ***

I'm not sure if the intention was to show the logo or to hide the logo on mobile?
** mobile navbar ul probably needs padding-left: 0px **
Current:

With padding-left: 0px (removing default ul padding):

It's difficult to tell what the intention was here, but it looked a little off to me so I figured I'd comment.

The rendering of embedded yaml (the shadowing and extra padding) looks problematic to me: https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/docs/concepts/scheduling-eviction/taint-and-toleration/

Homepage's Watch Video button is unstyled
It's hard to see against the blue bg, but alas! a bevel!

Blog posts display auto-generated submenus in the right hand nav

(Note: maybe this is useful and we want to keep it? It's awkwardly placed if so.)
Blog post Previous/next buttons use gradiated Docsy style instead of flat k8s style

Expectation would be that they either use same style as buttons on the old blog or they use bootstrap defaults, which are flat colors.

Left-hand nav cuts off oddly high/above the bottom of its container

Compare to Docsy's default:

UI fixes
Page - https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/partners/#kcsp

@Arhell, can you add a text description of the defect you're reporting?

@Arhell, can you add a text description of the defect you're reporting?

done

@aidanranney 👋 We've found some issues that appear to be specific to Gearbox's implementation. I've listed them in this comment, "Actionable bugs for Gearbox".

@zacharysarah 👋🏻Excellent - thanks to the reviewers and for organizing those. I'll relay the items to Troy and we'll get to addressing them ASAP.

Hello, I found two issues. These same problems seem to happen in the pages including images or embedded Katakoda lab like these:

Learn Kubernetes Basics | Kubernetes
Using kubectl to Create a Deployment | Kubernetes
Interactive Tutorial - Deploying an App | Kubernetes

Sorry, I don't know how to determine whether these problems are related to Gearbox or not.
1. #main.content covers the <header> block
Blocks before and after #main.content doesn't cover the <header>.

2. Right block forced to be moved below the left sidebar
This happens when I make the window narrow less than 1200px using Safari (both in macOS and iPad OS) or Google Chrome on iPadOS.
wider than 1200px

narrower than 1200px

Hi @aidanranney .
I just read through several pages. Here are some things to check out:

The page "pencil" icon no longer becomes hidden when you scroll down the page
The Yes/No feedback buttons are an odd shape/color
The Note shortcode does not have any padding so that if there is only one line of text the
left border is rather short. Also the border color for the Note and feature state shortcode text is yellow. This is the default color?
I have not checked, but is the site using the Note shortcode provided by the k8s layout or the docsy theme? Some of the Warning shortcodes are not displaying correctly (due to capture statements).
The right hand TOC (from in-page links) should not display a single heading. The docsy default setting checks for the number of headings?
Feature gates tables use the "table" shortcode. The tables are not displaying to the fill the area.
See the tables on this page, https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/
What do you think about adding a margin-right: 15px to pre.code when overflow is activated?
The reader has this margin on the left, but the text on the right side of the code block is at the end of the box (Note: The lack of right hand margin is evident in the current docs)
The docsy theme repeats the toc/sub-directory structure for an _index page item.
For example,
https://deploy-preview-20874--kubernetes-io-master-staging.netlify.app/docs/concepts/
The concepts sub-sections are listed after the What's next section. For pages that do not have content, you see the list of sub-sections. Is there a way to hide this list of sub-sections, especially if the _index page has no content?
Is it possible to override or add a border to an activated list item. The docsy theme
emphasizes the activated item text in the left hand TOC, but this is rather subtle.
Also, the item text section headings "stacks up". Could the site be configured to permit a greater length of characters to display the section text?

@zacharysarah I've put up some fixes to those last footer issues listed [i.e. consistently display git-info/"edit this page/create an issue"], although may need confirmation that the localization is working, as I didn't see a difference from production when I just went in [may have addressed already after your comment].
Also addressed some issues that surfaced with announcements [now that there is a BLM announcement] after performing a rebase. Thanks again for the organization around issue tracking and scoping!

@aidanranney Thanks, it looks good! ✨ After investigating a few pages, the footer looks like it's behaving as it should. 👍
And...that wraps up our list of issues to complete. 🎉  To merge, please:

Squash your commits
Sign the CLA

On the CLA specifically--are you having any difficulties there? I know sometimes it can be a thorny process, especially if you're signing organizationally. Let me know, I can put you in touch with CNCF support.

Not a merge blocker: on my screen the word-spacing in the footer is very sparse.

@aidanranney would you like any help with the contributor license agreement?

The images ("suitcase", "scalable", "blocks") on the home page are not displaying for "desktop".
Images display on smaller screens/mobile.

@aidanranney this is showing with some conflicts (CSS and Hugo HTML partials)

@zacharysarah Rebased - commits have been squashed and reworded. Some changes had to be made to get a successful build again after the removal of partials/templates and the use of capture statements. The apparent necessary changes were very minor/few, with the exception of removing custom ToC templates. They are no longer necessary as html doesn't need to be parsed from a Hugo scratch variable - Docsy can be leaned on for that partial now.

I'm going to edit the PR description to remove a contributor's GitHub name, it's probably OK to cut that out now.

/retitle Revise the Kubernetes website to use Docsy

/lgtm
@kbhawkey @onlydole please also take a look if you can spare the cycles

:eyes:

nit: Home page header text = Documentation
https://5ee53f7c45ef190007f3d0f7--kubernetes-io-master-staging.netlify.app/docs/home/
Other headers = Kubernetes Blog, Kubernetes Partners Community
No text in Current header, https://kubernetes.io/docs/home/

I don't see any link icons by the headings. For example:
https://5ee53f7c45ef190007f3d0f7--kubernetes-io-master-staging.netlify.app/docs/tasks/tools/install-kubectl/#install-kubectl-on-macos
nit: This page has a list of the links (toc) at the top of the page,
https://5ee53f7c45ef190007f3d0f7--kubernetes-io-master-staging.netlify.app/docs/tasks/
Note: The {{< toc >}} should be removed from the top of the page (separate PR).

This page has several places where the code block is not displaying to full width,
https://5ee53f7c45ef190007f3d0f7--kubernetes-io-master-staging.netlify.app/docs/tasks/manage-kubernetes-objects/declarative-config/#alternative-kubectl-apply-f-directory-prune-l-your-label

@kbhawkey that's a good spot about the icons for linking back to headings. I wonder if it's feasible to put those back. Maybe an issue to track after merge - what do you think?

May be related to anchors/icons:
https://github.com/google/docsy/issues/254

@aidanranney I updated the PR description again; I hope that's OK.

/lgtm
https://github.com/kubernetes/website/pull/20874#pullrequestreview-430162940 seems relevant and worth addressing at some point.

Hi @aidanranney . Here is what I found regarding the anchors on the page:
The anchors.js script (in theme) is looking for the headings under main:
var article = document.getElementsByTagName('main')[0];

However, /website/layouts/partials/announcement.html also has a main element.
I renamed the main tag in announcements.html to main_stuff.
The anchors script then creates the links.
I also fiddled a bit with /website/layouts/partials/head.html (updated jquery version).
Also, does the themes/docsy directory get created as part of this PR.
I worked with this branch, but the docsy dir was empty.

@kbhawkey

Also, does the themes/docsy directory get created as part of this PR. I worked with this branch, but the docsy dir was empty.

Makefile contains the git clone --init --recursive <whatever syntax> command to import the theme files.

Let's aim to merge this at 12pm Pacific on Monday, 15 June. (aka tomorrow)

/lgtm
/approve

Good work @aidanranney !


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for frolicking-faloodeh-5fb180 processing.

Name
Link

🔨 Latest commit
09f65ec64aad3bd8f56ecb2770f5e78191a74510

🔍 Latest deploy log
https://app.netlify.com/sites/frolicking-faloodeh-5fb180/deploys/6291d2143c29f4000ab05527


Training

As I customed ssd for relatively log time.
I found it pretty hard to train by means of hyper parameter setting and sensitivity of architecture.
If your have environment to train then Upload your weights is very welcome let's make it better.

Hi,
may I recomment the users uploading their weights in folder "YourFineTunedWeights" to communicate also the dataset used doing training ? It should be beneficial for the other users doing Transfer learning with those.

hi,i just train my model SSD300shufflnetV2  by following your strategy in SSD_train.ipynb ,but it seems hard to converge to a low loss (loss=4) .
is there something wrong?
thanks for your help


Experimental feature to taint worker nodes with user-provided key=value:effect

ref #112
TODOs

[ ] Validate Effects (Only NoSchedule and PreferNoSchedule are currently supported in Kubernetes)
[ ] Add integration tests to test/integration/aws_test.go
[ ] Add unit tests to config/config_test.go
[ ] Add unit tests to nodepool/config/config_test.go

Current coverage is 65.96% (diff: 33.33%)

Merging #132 into master will decrease coverage by 0.09%

@@             master       #132   diff @@
==========================================
  Files             5          5
  Lines           993        996     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            656        657     +1
- Misses          255        257     +2
  Partials         82         82

Powered by Codecov. Last update 31c612e...8f8a9e2

With:
experimental:
  taints:
    - key: dedicated
       value: search
       effect: NoSchedule

A node is tainted like this:
$ KUBECONFIG=kubeawstest3/kubeconfig kubectl describe node ip-10-0-0-107.ap-northeast-1.compute.internal
Name:  			ip-10-0-0-107.ap-northeast-1.compute.internal
Labels:			beta.kubernetes.io/arch=amd64
       			beta.kubernetes.io/instance-type=m3.medium
       			beta.kubernetes.io/os=linux
       			failure-domain.beta.kubernetes.io/region=ap-northeast-1
       			failure-domain.beta.kubernetes.io/zone=ap-northeast-1a
       			kube-aws.coreos.com/autoscalinggroup=kubeawstest3-AutoScaleWorker-MG55WG9QVM42
       			kube-aws.coreos.com/launchconfiguration=kubeawstest3-LaunchConfigurationWorker-1RERU8HQHT9RL
       			kubernetes.io/hostname=ip-10-0-0-107.ap-northeast-1.compute.internal
Taints:			dedicated=search:NoSchedule
CreationTimestamp:     	Tue, 06 Dec 2016 21:00:43 +0900
Phase:
Conditions:
  Type 			Status 	LastHeartbeatTime      			LastTransitionTime     			Reason 				Message
  ---- 			------ 	-----------------      			------------------     			------ 				-------
  OutOfDisk    		False  	Tue, 06 Dec 2016 21:09:02 +0900        	Tue, 06 Dec 2016 21:00:43 +0900        	KubeletHasSufficientDisk       	kubelet has sufficient disk space available
  MemoryPressure       	False  	Tue, 06 Dec 2016 21:09:02 +0900        	Tue, 06 Dec 2016 21:00:43 +0900        	KubeletHasSufficientMemory     	kubelet has sufficient memory available
  DiskPressure 		False  	Tue, 06 Dec 2016 21:09:02 +0900        	Tue, 06 Dec 2016 21:00:43 +0900        	KubeletHasNoDiskPressure       	kubelet has no disk pressure
  Ready        		True   	Tue, 06 Dec 2016 21:09:02 +0900        	Tue, 06 Dec 2016 21:00:43 +0900        	KubeletReady   			kubelet is posting ready status
Addresses:     		<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>
Capacity:
 alpha.kubernetes.io/nvidia-gpu:       	0
 cpu:  					1
 memory:       				3857668Ki
 pods: 					110
Allocatable:
 alpha.kubernetes.io/nvidia-gpu:       	0
 cpu:  					1
 memory:       				3857668Ki
 pods: 					110
System Info:
 Machine ID:   			cf742c5b2ef64b18a93d3785f5444d22
 System UUID:  			EC2B0A5C-4E50-7865-9E76-D9EE2BAA886F
 Boot ID:      			f7e097bf-750c-42ae-a266-82b604aa32db
 Kernel Version:       		4.7.3-coreos-r2
 OS Image:     			CoreOS 1185.3.0 (MoreOS)
 Operating System:     		linux
 Architecture: 			amd64
 Container Runtime Version:    	docker://1.11.2
 Kubelet Version:      		v1.4.6+coreos.0
 Kube-Proxy Version:   		v1.4.6+coreos.0
ExternalID:    			i-4baa7ed5
Non-terminated Pods:   		(1 in total)
  Namespace    			Name   									CPU Requests   	CPU Limits     	Memory Requests	Memory Limits
  ---------    			----   									------------   	----------     	---------------	-------------
  kube-system  			kube-proxy-ip-10-0-0-107.ap-northeast-1.compute.internal       		0 (0%) 		0 (0%) 		0 (0%) 		0 (0%)
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.
  CPU Requests 	CPU Limits     	Memory Requests	Memory Limits
  ------------ 	----------     	---------------	-------------
  0 (0%)       	0 (0%) 		0 (0%) 		0 (0%)
Events:
  FirstSeen    	LastSeen       	Count  	From   								SubobjectPath  	Type   		Reason 			Message
  ---------    	--------       	-----  	----   								-------------  	--------       	------ 			-------
  8m   		8m     		1      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		Starting       		Starting kubelet.
  8m   		8m     		1      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		NodeNotSchedulable     	Node ip-10-0-0-107.ap-northeast-1.compute.internal status is now: NodeNotSchedulable
  8m   		8m     		2      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		NodeHasSufficientDisk  	Node ip-10-0-0-107.ap-northeast-1.compute.internal status is now: NodeHasSufficientDisk
  8m   		8m     		2      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		NodeHasSufficientMemory	Node ip-10-0-0-107.ap-northeast-1.compute.internal status is now: NodeHasSufficientMemory
  8m   		8m     		2      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		NodeHasNoDiskPressure  	Node ip-10-0-0-107.ap-northeast-1.compute.internal status is now: NodeHasNoDiskPressure
  7m   		7m     		1      	{kubelet ip-10-0-0-107.ap-northeast-1.compute.internal}				Normal 		NodeSchedulable		Node ip-10-0-0-107.ap-northeast-1.compute.internal status is now: NodeSchedulable
  6m   		6m     		1      	{kube-proxy ip-10-0-0-107.ap-northeast-1.compute.internal}     			Normal 		Starting       		Starting kube-proxy.

Full log from kube-node-taint-and-uncordon.service can be seen at my gist
https://gist.github.com/mumoshu/4c5cab6cd1ce95801d8914cb830d58cf
Basically, it just run a bash script to run kubectl taint node as many as taints provided in cluster.yaml and then kubectl uncordon the node.
The node become Schedulable only after the node is successfully tainted hence no race between kubelet startup and taint, no undesired pods scheduled to the node.

Addressed all the TODOs.


Possible parser regression in ExportAllDeclaration since v0.171.0

Flow version: v0.171.0 and later, including the latest release (v0.183.1)
Expected behavior
A file containing the following line should parse:
export * as Error from './errors.js'

Actual behavior
As of 4b9ccbaa (@mroch), the parser raises Parse_error.Error (_, errors) where errors is a list of 4 Loc.t * Parse_error.t:
{ Loc.source = None; start = { Loc.line = 1; column = 12 };
  _end = { Loc.line = 1; column = 17 } }
Unexpected identifier, expected the identifier `from`
{ Loc.source = None; start = { Loc.line = 1; column = 18 };
  _end = { Loc.line = 1; column = 22 } }
Unexpected identifier, expected a string
{ Loc.source = None; start = { Loc.line = 1; column = 18 };
  _end = { Loc.line = 1; column = 22 } }
Unexpected identifier, expected the token `;`
{ Loc.source = None; start = { Loc.line = 1; column = 23 };
  _end = { Loc.line = 1; column = 36 } }
Unexpected string, expected the end of an expression statement (`;`)

I was unable to reproduce it on flow.org/try but I can confirm that Parser_flow.program "export * as Error from './errors.js'" raises a Parse_error exception in v0.183.1 and v0.171.0, and that it does NOT raise in v0.170.0
Thank you!

thanks for the report!
do you know if it's 4b9ccbaa specifically? or that just looks the most suspicious in 0.171.0?
export * as support is still gated by the esproposal_export_star_as parser option. I suspect it's not parsing because you have to enable that option. buuut, this proposal (https://github.com/tc39/proposal-export-ns-from) became standard in 2018! we should definitely remove the option.
I do wonder why the behavior changed in 0.171.0. I wonder if there was a different bug "fixed" in 171 that made it correctly obey the esproposal_export_star_as option instead -- thereby making it error by default.

Thank you for the great response.

do you know if it's https://github.com/facebook/flow/commit/4b9ccbaa7d9db48b19b686ce7c1668f1f19b76ef specifically? or that just looks the most suspicious in 0.171.0?

Oops, I phrased it as a fact but having just tested it, it turned out I was wrong!
The previous commit (bb82b352b) fails as well, so the issue is not specifically due to 4b9ccba

export * as support is still gated by the esproposal_export_star_as parser option. I suspect it's not parsing because you have to enable that option

Yes! Awesome, it worked. Thank you

buuut, this proposal (https://github.com/tc39/proposal-export-ns-from) became standard in 2018! we should definitely remove the option (T127807668 internally).

I'm not a contributor, but as a user this definitely seems like the right answer.

I do wonder why the behavior changed in 0.171.0. I wonder if there was a different bug "fixed" in 171 that made it correctly obey the esproposal_export_star_as option instead -- thereby making it error by default.

Yup, that's what my sixth sense is telling me, too. Maybe someone could write a git bisect script...

f360297ed2112e2828d4fe3dc9d75ec2d347ab98 removes the flag


mba6x_bl: init at 2016-02-12

Things done:

[x] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
[x] Built on platform(s): NixOS
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This driver fixes backlight after suspend/resume on Macbook Air 6,1
and 6,2.
Added a workaround for https://github.com/patjak/mba6x_bl/issues/43 in
form of a systemd service.
Has been working great on my machine for at least a month now.

 Let med restore this..

@joachifm : I changed the description based on your feedback.

Great. I'd like to get some feedback from others before merging this, though. Feel free to ping me if it ends up lingering for too long.

Adding a whole module for a temporary workaround feels kinda wrong. Does this bug also occur when the module isn't auto loaded (by blacklisting it) but loaded manually or does it always need to be loaded twice to work?

@hrdinka Thanks for your feedback. I will add fixes soon.
I don't know if it can be justified to make it a module. The driver can be loaded by users by setting boot.extraModulePackages = [ kernel.mba6x_bl ]; in their config file. I feel it is nicer for a module to do this. The workaround was easily added as a systemd unit to the module, making it work as expected without exposing this to the user.

Ok I see. So it's not only for the workaround. Then it might fit better as an extra option below programs.light (@puffnfresh) something like programs.light.mba6xSupport. @joachifm what's your opinion on that?

It seems weird to relate the mba6x driver to the light utility. How do they relate other than being in the domain of background light?

Hm, what about the hardware. option namespace?

@joachifm that was my second idea. This option shouldn't be placed in services.
@simonvandel yes you are right. This was a fast fire. Technically it does not refer to the light program at all. I just like the idea of having it somewhere where it belongs instead of adding another top level option for a specific device that might be unnecessary in future. Something like:
hardware.backlight.enable # enable generic backlight control
hardware.backlight.macbookAir6xSupport # enables specific device drivers
hardware.backlight.samsungWhateverSupport # or workarounds
...
programs.light seemed natural to me because it is our only backlight control related option in nixos and might be the right backend for a more general backlight option.

Hm, what about the hardware. option namespace?

This seems more appropriate.

Something like:
hardware.backlight.enable # enable generic backlight control
hardware.backlight.macbookAir6xSupport # enables specific device drivers
hardware.backlight.samsungWhateverSupport # or workarounds

It would be nice to have a general framework for these kind of hardware specific packages. Another alternative is to leave the actual driver be in nixpkgs, but drop the module support. The use of the driver could then be documented in something like https://github.com/ehmry/nixos-hardware.

Or a more general hardware support and fixing scheme:
hardware.support.macbookAir6x # enables macbook air 6,x related drivers/fixs
hardware.support.dellXY
hardware.support.hpXY

@simonvandel thank's for the link, didn't know that. That's actually what my last propose would do under the hood.

My previous idea is a bad one. An entry for every device out there isn't practical and is absolutely impossible to maintain. I guess for your cause your last post shows the best solution. Just keep the package and add some documentation about its existence and the workaround. The bug itself is hopefully fixed soon upstream.

Suggestion: if the driver is useful on its own, submit a separate PR for it, then we can figure out how to best expose it to users later.

I updated this PR to only include the packaging of the driver, and implemented the feedback received. Is this merge-able?
I will add some documentation to https://github.com/ehmry/nixos-hardware when I get the time.

It looks to be in keeping with similar packages already in the tree.  Thank you for your efforts.

Hello
May I ask how to use this package ? I have the exact problem it is supposed to fix (I am running nixos 15.09 on a macbook air 6.2), but can't manage to find out how to include it in my configuration...
Thank you for the work!

@huacayacauh did you try https://github.com/NixOS/nixpkgs/pull/13688#issuecomment-192967310

@joachifm thanks. Yes, in this case nixos-rebuild tells me that kernel variable is undefined. I don't know what I should substitute kernel for, my tries gave "attribute mba6x_bl missing".

I think you'd need to refer to boot.kernelPackages.mba6x_bl (untested)

@joachifm
boot.kernelPackages.mba6x_bl gives undefined variable ‘boot’
config.boot.kernelPackages.mba6x_bl gives attribute ‘mba6x_bl’ missing

Oh, I see you're running 15.09; this is not available there.

It won't be in a release channel for a while. The earliest you'll get it is when the nixos-unstable channel becomes unstuck. Alternatively, you can clone NixOS/nixpkgs-channels at the release branch you want and cherry-pick the commit onto it. I won't go into details here, see the manual.

@joachifm Ok, thank you very much for the quick answer.


Explore what it takes to ship VS Code as a UWP application

Goals:

what does it take to convert VS Code to UWP
what are issues we see when running Code from the store

/cc @kieferrm @egamma @seanmcbreen @chrisdias

Needs a proper done criteria. Also no longer seems to be on the January plan.

Do something for your company, you are Microsoft, right?
Just like Nintendo should release its latest Mario on Switch.

@bpasero Yo, check out electron-windows-store - even if you don't end up using it, I'd love to hear why it wouldn't work for y'all!
https://github.com/felixrieseberg/electron-windows-store

@felixrieseberg I was just going to refer them to that project after I read your blog post. 😛

Investigation is done. Closing (and duplicates https://github.com/Microsoft/vscode/issues/10759)

Any decision or observations based on the investigation?

For those interested in the results of the investigation…  We used the desktop app converter to convert VS Code to a UWP app that uses the Desktop Bridge (aka a “Centennial” application) that provides a Windows Store setup experience and access to a subset of the full UWP API. The conversion worked quite well and we were able to side load VS Code as a Windows Store application with no loss of functionality.
So, this closes the investigation for the product itself. The next investigation we would need to do is understand how to adapt our internal build systems to produce daily/monthly builds that can be published through the Store. Once that is understood, we will decide if and when it makes sense to move forward with this effort and actually put it on the backlog.

Awesome! 👍 😄 😺 ❤
The UWP App, works even on Windows 10 Mobile and continuum?

@OrbintSoft no, it is still a win32 application that runs node and spawns non-UWP processes.  The desktop conversion does not mean it automatically runs on mobile/continuum.

@bpasero Will we be able to follow this investigation/see more updates on this in the future?
Best Regards,
Roger Sachan

Any updates here? Would love to be able to ensure VS Code gets into the store...


Adding access to noSubMatches and noOverlappingMatches

…CompoundWordTokenFilter

Description
This change adds support for / exposes two new settings (noSubMatches and noOverlappingMatches) that were added to Lucene's HyphenationCompoundWordTokenFilter class.
Related Issues
Resolves #8796
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

Thanks @evankielley!
Can you please also click the link in the PR checklist to create a documentation issue? It looks like we have a list of analyzers with links to the Lucene 8.7 JavaDocs: https://opensearch.org/docs/latest/analyzers/token-filters/index/. We should probably update those links to point to whatever version of Lucene was used for a given release.

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

Thanks @evankielley!
Can you please also click the link in the PR checklist to create a documentation issue? It looks like we have a list of analyzers with links to the Lucene 8.7 JavaDocs: https://opensearch.org/docs/latest/analyzers/token-filters/index/. We should probably update those links to point to whatever version of Lucene was used for a given release.

No problem! Issue created here: https://github.com/opensearch-project/documentation-website/issues/5389

Let's add some test coverage for this change.

Let's add some test coverage for this change.

It looks like there's no existing unit tests for this class. Should I create a new file for unit tests in modules/analysis-common/src/test/java/org/opensearch/analysis/ or is there some reason why unit tests were skipped for this class in the first place?

Let's add some test coverage for this change.

It looks like there's no existing unit tests for this class. Should I create a new file for unit tests in modules/analysis-common/src/test/java/org/opensearch/analysis/ or is there some reason why unit tests were skipped for this class in the first place?

One likely reason is that unit testing around the lucene library itself does not add much value, hence it is non-blocking for this PR.
Let's rebase to fix the gradle check failure https://build.ci.opensearch.org/job/gradle-check/28931/console
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':qa:mixed-cluster:v2.12.0#mixedClusterTest'.
> There were failing tests. See the report at: file:///var/jenkins/workspace/gradle-check/search/qa/mixed-cluster/build/reports/tests/v2.12.0%23mixedClusterTest/index.html

Hi @evankielley, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

Closing stalled PR due to inactivity for over 6 months. Please re-open a new PR if you would still like to submit this change. Thanks!


runkappaplot demo scripts

Once things like roadmap and bcgs_pip_suite are finalized, add them and some further description to the README.

Don't remember what I had in mind; too vague


dead/incorrect link

'DAX Basic in Power BI Desktop' has incorrect link.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db43c478-6301-7b69-131a-c4289797c49d
Version Independent ID: 5f991bdb-919e-f712-1fe0-050eba25ebaf
Content: Power BI tutorial for Azure Cosmos DB connector
Content Source: articles/cosmos-db/powerbi-visualize.md
Service: cosmos-db
GitHub Login: @SnehaGunda
Microsoft Alias: sngun

@danny8002 Thank you for your feedback . We will have this investigated and update the thread accordingly .

@danny8002 thanks for pointing out the issue and @Potapy4 thanks for the fix.
We will now close this issue if there aren't any further questions.
#please-close


upgrade_through_versions_test "latest tag" version discovery is wrong in some cases

e.g. when comparing 2.2.0 tag to 2.2.0-rc2 it should know that 2.2.0 is actually the "latest", and it seems to be doing the opposite at this point.

This is in reference to old logic which is no longer present. closing.


Credential Window without submit button

After installing correctly the extension
it is impossible to validate the creation of a credential due to the fact that there is no button to do it.

Debug info
core

n8nVersion: 1.64.3
platform: docker (self-hosted)
nodeJsVersion: 20.18.0
database: postgres
executionMode: regular
concurrency: -1
license: community
consumerId: unknown

storage

success: all
error: all
progress: false
manual: true
binaryMode: memory

pruning

enabled: true
maxAge: 336 hours
maxCount: 10000 executions

Generated at: 2024-10-30T22:06:36.975Z

I just had this. It's the UI expecting you to change something before you can save. The problem is that the configuration already worked for you without needing to change anything. This should be an issue for n8n to remove that requirement before saving.
To bypass it, just delete a character from the socket path and retype it.


Add gatsby v5 and graphql 16

Description
Updates dependencies for gatsby v5, which includes:

Graphql 16
Gatsby v5 and plugin updates where available
React 18
Node 18 (required for v5)

The code changes were actually minimal, but obviously the dependency increases are big, so probably a major version change.
Checklist

[x] Read the contributing guidelines.
[x] Each commit follows the Conventional Commit spec format.
[x] Update the readme (if applicable).
[x] Update or add any necessary API documentation (if applicable)
[x] All existing unit tests are still passing (if applicable).

This is a great start! Thank you for tackling this.
I've just taken a quick look, but I'll need more time to smoke-test these deps changes. I'll circle back around in a few days time.

All looks good on my end. I'm going to change the target branch to next for some smoke testing. Once that RC looks good, we can get these changes merged into main.
Thanks so much @finematterdave for opening this issue and PR ❤ . Awesome work!


Regeneration Qiskit v0.28 API docs

Part of https://github.com/Qiskit/documentation/issues/542.
Regeneration of the Qiskit API docs (historical versions) with the methods inlined and the GitHub source links. Given the number of files modified, the regeneration is split into different PRs. This one only updates the version 0.28.
All the GitHub source links work!

Link checker failures are flakes.


KAFKA-3832: Kafka Connect's JSON Converter never outputs a null value

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Context
https://issues.apache.org/jira/browse/KAFKA-3832
When using the Connect JsonConverter it's impossible to produce tombstone messages, thus impacting the compaction of the topic.
Solution
Allow the converter with and without schemas to output a NULL byte value in order to have a proper tombstone message
When it's regarding to get this data into a connect record, the approach is the same as when the payload looks like "{ "schema": null, "payload": null }", this way the sink connectors can maintain their functionality and reduces the BCC
Tests
The first commit only introduces the fix and shows that possibly no BC break is introduced; Please help me confirm that's the case
The second commit introduce tests for the fix
Notes
The fix could also be done at fromConnectData, but I felt like since the last path within the change is convertToJsonWithEnvelope this could avoid future internal calls to be also be faulty

hey @gunnarmorling

Some typo fixes inline. Not sure whether that PID file should be in there?

Yes that happened by mistake! All fixed now, thanks so much for the early review!

@renatomefi, thanks for trying to address this long standing issue.
Even though I agree returning a null key or value is more desirable than returning an envelope with null schema and value, we need to be careful about backward compatibility and unnecessarily changing behavior that people might be relying upon. Previous to this, the JsonConverter always returned a non-null envelope, while now it's possible that the key/value is null. One might argue that the converters may always return a null key/value, and that this change doesn't stray from that. But it is possible that some people have set up pipelines that are defined with the current behavior in mind, and that introducing these changes might break such pipelines.
Have you thought about this? If so, why would we think it's safe to change the behavior? Would it be more appropriate to introduce this behavior via a new config property? The latter will of course require a KIP, but the purpose of a KIP is to make sure that changes are intentional and that all compatibility concerns have been addressed or at least properly considered.

But it is possible that some people have set up pipelines that are defined with the current behavior in mind, and that introducing these changes might break such pipelines.

That's a good point, but OTOH I don't think this should stop us from fixing bugs (and hindering topic compaction is quite troublesome IMO). Esp. it seems quite simple to restore the old behavior using an (sink side) SMT that converts a null value into the previously emitted empty envelope structure, unless I miss anything? So I'd conclude that it's acceptable to do this change, accompanied by a note on how to restore the old behavior using an SMT in the migration notes.

via a new config property?

Yes, that'd be a tad simpler than implementing a custom SMT. I'd only suggest to have it default to the new, correct behavior, while sticking to the old one through opt-in. I.e. the emitted messages should be "correct" by default while enabling the "compatible" behavior through opt-in.

Hello @rhauch, thanks so much for your considerations!

Have you thought about this? If so, why would we think it's safe to change the behavior? Would it be more appropriate to introduce this behavior via a new config property? The latter will of course require a KIP, but the purpose of a KIP is to make sure that changes are intentional and that all compatibility concerns have been addressed or at least properly considered.

Indeed your points are really good, I did take it in consideration, I can't really argue that people might be doing custom things, but on the line of the source and sink connectors the compatibility is kept since the ConnectRecord instance stays the same after this change, the problem would be for traditional consumers which might indeed, be relying on the current empty schema/value.
As @gunnarmorling said, the lack tombstone is a big deal, thus if we can't fix that I think the documentation should be aligned since so far it seems like it should just work.
In that case I'd suggest this change to be introduced in a new minor or even major, r if it's too dangerous indeed we could make it an option.
I've shipped an extended JsonConverter with this behavior so we can move one at my company (for future issue surfers): https://github.com/usabilla/kafka-connect-json-JsonConverter
Please let me know where should I go from here, if creating a KIP or waiting to merge this another bigger release.

@renatomefi By the way, I've added you as a contributor on the project JIRA. This allows you to assign tasks to yourself in the future. Thanks for the contribution!


Recommended settings for subject training

I know this is a topic that has been discussed several times but I have found contradictory information. What are the recommended settings to train the model with images of a subject from Colab?

What is the optimal number of images? How many of these should be from the face only?
How many training steps should I start with, on both the unit and text encoder? And with what learning rates?
Which model version works best for these cases? 1.5? 2.1-512? 2.1-768?
If the session name is "mikeasdasd", what should be the name of the instance images? "mikeasdasd (1)"?
Should I edit the "instance_prompt" text or leave it as is? If I have to edit it should I put for example "a photo of a mikeasdasd young man"?
I don't have to use captions or concept images, right?

Thank you so much.

if a person, try below.  I've had great success with this but i am doing img2img to get the best results.
-minimum 15 pics, lighting and angle are important so get a variation (mine have always been just the face).
-unet training steps x200 so 20 pics 4000 steps.  I always use 350 for the text encoder steps.
-Version 2.1-512 has been the best so far
-correct on the instance images ie naming "mikeasdad, mikeasdad(1), mikeasdad(2)
-leave as is, your prompts will get you what you want.  One tip, once running automatic1111, I have better results if I increase the trained model.  Meaning it would look like "a photo of (mikeasdad: 1.2) etc.  Just highlight mikeasdad and hold control then press the up arrow.
-don't have to use.
Good luck!

Could you explain this a bit further:

""a photo of (mikeasdad: 1.2) etc. Just highlight mikeasdad and hold control then press the up arrow."

I was able to do it with the Ctrl+Up, but I'm not entirely sure what this means or what its doing? Any info link or further explanation would help.
Also thanks for your other tips, they helped improve my results quite a bit!

I've always found it puts more emphasis on the trained model, with more detail I guess.  Other prompts will do that too but I only use a few prompts and use more negative prompts.

if a person, try below. I've had great success with this but i am doing img2img to get the best results. -minimum 15 pics, lighting and angle are important so get a variation (mine have always been just the face). -unet training steps x200 so 20 pics 4000 steps. I always use 350 for the text encoder steps. -Version 2.1-512 has been the best so far -correct on the instance images ie naming "mikeasdad, mikeasdad(1), mikeasdad(2) -leave as is, your prompts will get you what you want. One tip, once running automatic1111, I have better results if I increase the trained model. Meaning it would look like "a photo of (mikeasdad: 1.2) etc. Just highlight mikeasdad and hold control then press the up arrow. -don't have to use. edit: use 2e-6 for both learning rates.
Good luck!

To add to this, I've been using the same formula except one huge improvement I found is 450 text encode at 1e-6. Less mutations, more likeness, and better styling. unet remains img*200 2e-6

To add to this, I've been using the same formula except one huge improvement I found is 450 text encode at 1e-6. Less mutations, more likeness, and better styling. unet remains img*200 2e-6

For 1.5 or 2.1?

To add to this, I've been using the same formula except one huge improvement I found is 450 text encode at 1e-6. Less mutations, more likeness, and better styling. unet remains img*200 2e-6

For 1.5 or 2.1?

2.1

Thank you very much for the answers, they helped me a lot.
Do you think this configuration gives better results than the one discussed in #1127 ? (IMAGES: 10 / UNIT: 600-800 2e-5 / TEXT: 350 1e-6). In any case, why are the configuration values so different?
And about the resolution, does the training work just as well for 2.1-512 as it does for 2.1-678? If so, do I need to modify any of the settings?
Thank you so much.


how to swipeBack to a specific activity

how to swipeBack to a specific activity??
tnx in advance!

SwipeBackLayout operates almost as a onBackPressed(). Meaning it goes back in the stack. I don't think this is possible unless you somehow redirect it manually.

There is a API that may be helpful, check it out:
getSwipeBackLayout().scrollToFinishActivity()


Issues with the HS login

I have issues with logging in using the following code:
>>> from selenium import webdriver
>>> driver = webdriver.Firefox()
>>> import src.finnish_media_scrapers.fetch as fetch
>>> fetch.prepare_session_hs(driver, "sensuroitu", "sensuroitu")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/iikka/Projektit/finnish-media-scraper/src/finnish_media_scrapers/fetch.py", line 19, in prepare_session_hs
    user = driver.find_element_by_id("username")
  File "/home/iikka/Projektit/finnish-media-scraper/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 360, in find_element_by_id
    return self.find_element(by=By.ID, value=id_)
  File "/home/iikka/Projektit/finnish-media-scraper/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 976, in find_element
    return self.execute(Command.FIND_ELEMENT, {
  File "/home/iikka/Projektit/finnish-media-scraper/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/home/iikka/Projektit/finnish-media-scraper/venv/lib/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchElementException: Message: Unable to locate element: [id="username"]

I use Firefox 89.0. The code above opens a graphical Firefox window and I see that it doesn't even open the login form.
My computer is very slow and it takes time for the browser to even load the main page of HS. Maybe this slowness is related to the error?
If I manually login to the browser, the actual process of fetching an article seems to work. However, it randomly fails on my computer sometimes. I will make a new issue after making more research on the conditions when it fails (if these fails are related to this library at all).

There may be two different issues here. One is that you are using the Firefox driver, which, unlike the Chrome driver, seems to not like clicking on elements that are behind other elements. In this case, this means we need to click on the link to accept cookies first before logging in. Second, you may indeed have problems due to slowness, as the login code did not include wait guards in trying to obtain the login form. I've now added both of these in b67c577fa93b48e00d5865b2cfe28394c76a9d9e, and would appreciate you retrying.
(the maximum waits are 30 seconds, which are also the same for the actual fetching of the articles. I would hope these are enough, and that the problems you are seeing in the article fetching are not TimeoutExpections?)

The HS login appears to be working now.
The fetching errors I were getting were indeed TimeoutExceptions from one of the find_element_by_xpath calls, but I haven't been able to reproduce them since then, they appear to be random.
Perhaps you could add an option to adjust the timeouts?

Option to alter maximum waiting time added. I'm closing this issue now, but feel free to reopen or file additional issues if problems persist.


collection-repeat: use $animate

Use the $animate service to trigger animations on enter, move, and leave, just like ng-repeat.

hi @Hendrixer  can you please add some tips  on how to define an enter/leave animation on a collection-repeat ?
or even better, add a jsFiddle or CodePen ? ;)


[Bug] Undead Fortitude Damage Clamping

Undead Fortitude save DCs are currently being calculated using only the damage done to reduce the target to 0 hp, i.e. a zombie with 1 hp is always rolling a DC 6 save (with a +3 bonus lol)

Both methods as far as I can tell. Tested this with minimal mods loaded in before reporting, although one of them was midi-qol

Without midi:

Quick Saves:
Zombie has 12 health, takes 13 damage

DC is thus 5 + 13:

Zombie has 12 health, takes 25 damage

DC is 5 + 25:

Advanced Saves
Zombie has 12 health, takes 13 damage
Damage to target is auto populated with 13, but you can put anything there:

DC is thus 5 + 13

Zombie has 12 health, takes 13 damage, damage is autopopulated:

But it's overwritten to 27:

DC is thus 5 + 27

Will make a separate post for with midi, to see what happens (don't have midi installed on my development version, so give me a few minutes to set everything up)


[Bug]:

Forge Version
<IP_ADDRESS>59
Galacticraft Version
4.0.5
Log or Crash Report
Unable to launch to, or /dimensiontp to Asteroids, Moon, or Mars
I believe it can be relate to this issue: https://github.com/TeamGalacticraft/Galacticraft-Legacy/issues/92
My text is green tho, instead of red.
Reproduction steps

Do this
Do that
Crash/Bug
...

Log: https://mclo.gs/lhVXHBw

I will send a screenshot later

create a proper issue using the template provided and also provide a proper log and any other information needed.


[release-v2.8] Bump dependencies to support k8s v1.27

Issue: https://github.com/rancher/aks-operator/issues/269

Note: This is ready for reviews, but let's not merge this manually for now until we make sure Rancher also bumps these dependencies.


M.2 Coral TPU inside USB Enclosure

I have an M.2 to USB enclosure/adapter. Is it possible to use this for the the Coral M.2? Anyone else that tried this?
The OS recognize the adapter. Not sure how to see the TPU.
lspci
0b:00.0 USB controller: Renesas Technology Corp. uPD720201 USB 3.0 Host Controller (rev 03)
lsusb
Bus 001 Device 004: ID 0bda:9210 Realtek Semiconductor Corp. RTL9210 M.2 NVME Adapter

Cross-reference to frigate: https://github.com/blakeblackshear/frigate/issues/2348

Hi,
Unfortunately it does not work.
I tested an A+E key TPU + an passive adapter to M key in two USB-PCIe adapter. One with RTL9210B and another with JMS953 controller. Neither Windows or Debian recognized the Coral TPU in any of the cases.
I suspect that the issue is with their firmware. Because even without anything install in them both show up as storage devices.
Out of curiosity I even tried to add an m.2 pcie to sata controller and connect an SSD to that. Windows recognized a drive but it id not have capacity and could not be initialized.
So even if both chip described as USB to PCIe, without firmware modification it won't going to work if it is possible at all.


lib development

Is angular-seed also usable for lib development?

Sure, you can use it for lib development. You can add a custom task for transformation of package.json before publishing the library. This task can drop devDependencies, scripts, etc.


ipad: Clicking off text box

Clicking off the text box to register, or finish text box edit doesn't work.
both chrome and safari on Ipad.

sometimes it works, sometimes it doesn't.


8UC1 provided need mono8

Hello I am trying to use this driver for the ensenso camera, the package that i intend to use it with accepts mono8 encoding, however, the camera provides 8UC1. Is this something that can be altered? I have been looking for conversion methods but that does not seem to be possible as 8UC1 is not a color format. I am subscribing to the /rectified/left/image topic. Would I need to use a different one? Or do you perhaps know of a method to convert the data?
Thanks in advance!

The two formats are equivalent and contain the same data. It seems like mono8 is more popular in ROS, though (see e.g. intel-ros/realsense#253), so I changed it.


Update the infra/core modules to AVM modules

Update the infra/core modules to AVM modules.
1. Modules not replaced by AVM

Monitoring (applicationinsights-dashboard) : Missing the feature Microsoft.Portal/dashboards.
AVM issue link: https://github.com/Azure/bicep-registry-modules/issues/1130
AVM PR: https://github.com/Azure/bicep-registry-modules/pull/1974.

APIM: Missing features Microsoft.ApiManagement/service/loggers and Microsoft.ApiManagement/service/apis/diagnostics.
AVM issue link: https://github.com/Azure/bicep-registry-modules/issues/1124
AVM PR: https://github.com/Azure/bicep-registry-modules/pull/2067

2. Modules replaced by AVM

App Service
Key Vault
App Service Plan
SqlService
Cosmos mongo
Container registry
Container app
Container environment
Managed Cluster
Static web app
Storage
Azure loganalytics
Azure applicationInsights

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3975

View Changes | Compare Changes

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3975

View Changes | Compare Changes

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/3975

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3975
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3975

View Changes | Compare Changes


Request support for Sankakucomplex

Would it be possible for you to add support for chan.sankakucomplex.com?

If it isn't too much work, sure. I'll look into it when i have some time.

I added support for sankaku where it simply iterates through the pages and downloads the posts which i'm guessing is what you meant?
However, the server has a request limit so i also added a -s parameter that will sleep for X amount of seconds in between requests. Setting this parameter to 5 seemed to work for me.


Mossy iron bars do not connect to normal iron bars as they should

This picture shows the issue

Fixed with version 1.3.1


feat(v2): new ui progress bar

Motivation
I don't want to maintain https://github.com/endiliey/webpack-nicelog#readme anymore. Its also based on webpackbar v2, now webpackbar is on v4 which is more stable and have new UI.
Our current progress bar also has some weird problem due to webpack-dev-server showing additional info on startup (can't be disabled) which causes some UI glitch

See https://github.com/webpack/webpack-dev-server/pull/2235/files#r334830565 for more context
I think its better to move it to this repo so contributor can easily modify it.
In the future, we should try to use react-error-overlay for the error reporting like CRA
It also consumes less memory and is more accurate according to https://github.com/nuxt/webpackbar/releases/tag/v3.0.0
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
New UI
Dev

Build

As there is a showstopper bug on alpha-28 and this is just moving webpack-nicelog to this repo and upgrading major dependency (webpackbar v2-> v4). Gonna merge it out and release as alpha.29 along with #1867


freebayes: init at 1.1.0

Motivation for this change
I wanted to make this variant calling package available for Nix users (recently including myself).
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Merged as 59ca5d213f99d10f9cc187763876b5c4008bac7d in master. I fixed the reference to use the version


workbench.action.terminal.focusNextPane  and workbench.action.terminal.focusPreviousPane not working on Mac OS X Mojave

VSCode Version: 1.28.0-insider
OS Version: Mac OS X 10.14

Steps to Reproduce:

Open the integrated terminal
Create a new terminal pane
Attempt to use the focusNextPane keyboard shortcut
Change the focusNextPane and focusPreviousPane bindings to something new/unique
Attempt to focus between panes again
Panes should not switch in either case

Does this issue occur when all extensions are disabled?: Yes/No
Yes

Cannot repro on High Sierra or Mojave, maybe another app is conflicting with the keybindings like Spectacle?


LND repeatedly fetching channels and getting hung

Background
The last time I played with it was three weeks ago and regularly checking my balance with Zap wallet in the meantime to make sure it was still there. Turns out, Zap includes the balance of offline channels in you total balance so I had no idea when it broke. It seems I can't connect to any peers because the "server has not yet finished starting up" according to RTL. On Chain seems functional. Noticed the Watchtower Client repeatedly searching for candidates and failing so I disabled that and rebooted the app to no avail. Turned Watchtower back on for the sake of maintaining defaults. I'm not sure where to go from here.
** I should mention that EmbassyOS has root blocked off and I have yet to figure out how to make SSH keys that it will accept so that I can access it via terminal. I have been unable to verify that the channel.bak file is in the correct folder or exists at all. I do however, have a copy of the channel.bak on my PC that I downloaded via RTL for safe keeping.
Your environment

LND Version: 0.13.0~4
EmbassyOS by Start9Labs
Bitcoin Core 0.21.1~1 (the Embassy listing doesn't say bitcoind or btcd so not sure)
Bitcoin Proxy 0.3.2
All services have "internal" and "system defined" selected for RPC stuff.

Steps to reproduce

Expected behaviour
LND usually boots and after a moment the channels appear in RTL.
Actual behaviour
Upon boot, LND shows that I am synced to chain but not graph. After a while, it attempts to fetch channels and then repeats endlessly as shown in picture.

Is the bitcoind node pruned? Do you have routing.assumechanvalid=true in your config?
The RPC calls you see for fetching the channels is one of your tools (RTL or Zap) that's querying lnd. That's probably not the main issue. What does lncli getinfo say? We'll need some more infos (including logs) to say more.

The node is pruned and compensating with Bitcoin Proxy. I can't even type those into the terminal for reasons stated above. But, the issue seems to have resolved.  I guess I was expecting to see more in the debug log showing me what block height lnd had caught up to so far. Guess that's a function of not using terminal to run it. Anyways, sorry for bothering yall

Okay, thanks for the update. Closing as the issue seems to be fixed.


Delete user flow

Describe the feature
Deleting the user's profile, messages and all related data.
Describe the solution you'd like
Still needs to be refined:

Do we just delete all the messages sent by the user and leave holes in the discussions they participated in?
Do we change their messages to say  and hide their name?
Should something else be considered?

Additional context

It could be done like how Discord does, the username changes to "Deleted User" and the messages are retained.


Match service tests use mocks

Acceptance Criteria

Match service tests uses mocked api requester and crud

Won't do. This being an integration test will suffice. Don't need to convert or add unit test for it.


Iroha client returning success with transaction been written to postgres

Signed-off-by: Ashwin Balasubramanian<EMAIL_ADDRESS>

Description of the Change
Added return type bool to GRPC handler. On success returns true, false otherwise. If true the transaction is complete. Fix for the issue #724 .

Benefits

Possible Drawbacks
Error codes not handled properly. User will find it difficult to find why the transaction has been cancelled.

Usage Examples or Tests [optional]
Can be tested by execution of a transaction on iroha-cli.

Alternate Designs [optional]
Need to handle the error more elaborately.

Please use clang-format

Will be updated this weekend
Thank you
Ashwin Balasubramanian

On Jun 12, 2018, at 4:25 PM, Kitsu<EMAIL_ADDRESS>wrote:
Any updates on that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/hyperledger/iroha/pull/1318#issuecomment-396739522, or mute the thread https://github.com/notifications/unsubscribe-auth/AHArdBf9JWNODo0Ki3AGeu1MdDvUc8jlks5t8DHhgaJpZM4T3pX1.

Almost done, great job! Please, rebase and resolve conflicts.

Please, rebase and resolve conflicts.

It seems there's no action for 10 days already. Are you planning to continue?

Hey,
I’m sorry for the delay. I was busy with my course work in my college.
I need to admit that I don’t know how to rebase and resolve the conflicts.
I would be happy if you send me the steps or resources to read about it. It will be of a great help to me.
Sorry for the delay.
Thank you
Sent from my iPhone

On Jul 2, 2018, at 5:38 AM, Kitsu<EMAIL_ADDRESS>wrote:
It seems there's no action for 10 days already. Are you planning to continue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This is my first project I’am  contributing to. I don’t know git in depth but would like to learn while contributing to the project.
Thank you
Sent from my iPhone

On Jul 2, 2018, at 5:38 AM, Kitsu<EMAIL_ADDRESS>wrote:
It seems there's no action for 10 days already. Are you planning to continue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You basically need to update you branch know. It's possible either to use "Resolve conflicts" on the github, or merge actual develop branch (git fetch; git merge origin/develop --signoff) and resolve exactly same conflicts

Hi @sjashwin ! Any updates on the pull request?


[WFRP4e System] AP doubled on Apply Damage

When hitting "Apply Damage" after a hit, the damage calculation seems wrong when actor is wearing armor.
TB is inserted correctly, but AP is doubled.
As example:
If hit is Body and Damage is 8, and actor wears "Mail Shirt" it shows:
Damage Applied: 2 (2 TB + 4 AP)
A "Mail Shirt" however has AP 2 Body, but it shows as AP 4 in the calculation instead of 2.
A "Leather Jerkin" on Body shows AP 2 instead of 1.
In Trappings list and Character Sheet/Combat the numbers for the armor and the covered body parts do show correctly.From<EMAIL_ADDRESS>3.4.1wfrp4e-core: 1.3.1wfrp4e-starter-set: 1.4.1

See attached image as example.

This is because your weapon is undamaging


Request Feature From Indonesia

Request Feature

Add Custome shortcut for Window Walker
Windows Walker Spotlight Is To Big

all coming to launcher in 0.18


azd login on github actions stopped working today

[ ] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
github actions
Describe the bug
github action to login to azd..
Run $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
Not logged in, run azd auth login to login to Azure.
To Reproduce
create a github action with the following step
jobs:
build:
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/azure-dev-cli-apps:latest
env:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
steps:
- name: Checkout
uses: actions/checkout@v3
  - name: Log in with Azure (Client Credentials)
    run: |
      $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
      Write-Host "::add-mask::$($info.clientSecret)"
      azd auth login `
        --client-id "$($info.clientId)" `
        --client-secret "$($info.clientSecret)" `
        --tenant-id "$($info.tenantId)"
    shell: pwsh
    env:
      AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS **}}**

Expected behavior
Expected to be login in with azd clie
Environment
Github actions
Additional context

@varndellwagglebee Can you post the output logs from the step that failed? Do make sure to sanitize any data that may be sensitive for you.

@varndellwagglebee azd supports Client Credentials or Federated Credentials
Based on the issue description, it looks like you are using Client Credentials.
For Client Credentials, the common issues why login would start to fail in pipelines are:

The ServicePrincipal was deleted from Azure Active Directory.
The secret for the Service principal was updates/rotated, so the value in GitHub no longer match.

This could happen, for example, when using the same Service principal for two repositories.

The secret for the Service principal had an expiration date and it became expired.

For Federated Credential, the common issues are:

Changed the repository or branch name (fed credential is configured to match repo and branch name)
Service principal deleted
Fed Credential removed

I ran azd pipeline config and it updated github withe the principle data.  Ran the workflow again and still not logging in..
I checked and the ServicePrinicipal is in AAD.

I manually replaced all the secrets:
2s
##[debug]Evaluating: secrets.AZURE_CREDENTIALS
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'AZURE_CREDENTIALS'
##[debug]=> null
##[debug]Result: null
##[debug]Evaluating condition for step: 'Log in with Azure (Client Credentials)'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Log in with Azure (Client Credentials)
##[debug]Loading inputs
##[debug]Loading env
Run $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
##[debug]pwsh -command ". '/__w/_temp/fd54a3e7-1a05-48f6-a7c0-53962ad6fdd3.ps1'"
Warning: Can't add secret mask for empty string in ##[add-mask] command.
Error: flag needs an argument: --tenant-id
Error: Process completed with exit code 1.
##[debug]Finishing: Log in with Azure (Client Credentials)

@varndellwagglebee
just noticed in the issue description you have
env:
  AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS **}}**

is the **}}** a typo for when you created the issue?  or is this also in your code?

@varndellwagglebee can you also share how you ran azd pipeline config ?  what arguments did you use?

I ran the config from vs code menu.  the env is just from when the issue was created.  here are my env items
APPLICATIONINSIGHTS_CONNECTION_STRING="InstrumentationKey=5f41d059-2bc7-462e-a9af-fbf701868282;IngestionEndpoint=https://eastus-8.in.applicationinsights.azure.com/;LiveEndpoint=https://eastus.livediagnostics.monitor.azure.com/"
APPLICATIONINSIGHTS_NAME="appi-3hmn6weg7opbk"
AZD_PIPELINE_PROVIDER="github"
AZURE_CONTAINER_ENVIRONMENT_NAME="cae-3hmn6weg7opbk"
AZURE_CONTAINER_REGISTRY_ENDPOINT="cr3hmn6weg7opbk.azurecr.io"
AZURE_CONTAINER_REGISTRY_NAME="cr3hmn6weg7opbk"
AZURE_DATABASE_NAME="glypheditor"
AZURE_DATABASE_SERVER_HOST="psql-db-3hmn6weg7opbk.postgres.database.azure.com"
AZURE_DATABASE_SERVER_NAME="db-glypheditor"
AZURE_ENV_NAME="staging"
AZURE_KEY_VAULT_NAME="GlyphEditor-Staging"
AZURE_LOCATION="eastus"
AZURE_SUBSCRIPTION_ID=""
AZURE_TENANT_ID="****"
REACT_APP_WEB_BASE_URL="https://ca-web-3hmn6weg7opbk.wittystone-5f08ad6e.eastus.azurecontainerapps.io"
SERVICE_API_NAME="app-api-3hmn6weg7opbk"
SERVICE_WEB_NAME="ca-web-3hmn6weg7opbk"

@varndellwagglebee , when you run azd pipeline config from vscode menu, you mean like:

In that case azd pipeline config is invoked with default values, and the default for authentication is to use federated credential.
This means your pipeline definition should use the fed-credential step for logging.
In your initial logs, you mentioned you are using client-secret auth like
Log in with Azure (Client Credentials)

Try switching to:
      - name: Log in with Azure (Federated Credentials)
        if: ${{ env.AZURE_CLIENT_ID != '' }}
        run: |
          azd auth login `
            --client-id "$Env:AZURE_CLIENT_ID" `
            --federated-credential-provider "github" `
            --tenant-id "$Env:AZURE_TENANT_ID"
        shell: pwsh

Can you tell what you mean by azure developer profile config ?
The fed-credential is to be used when azd is running within the GitHub action.  It can't be used for running locally.
I was referring to .github/workflows/azure-dev.yml  Can you share the content of that file?

I right-clicked on the azure.yaml file and selected

here is my azure.yaml file:
yaml-language-server: $schema=https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json
name: azure-remix-stack
services:
web:
language: ts
project: "./src/web/GlyphEditor"
module: app/web
host: containerapp
api:
Language: csharp
project: "./src/api/GlyphEditor/src/GlyphEditor"
module: app/web
host: appservice
Here is my github workflow file:
on:
workflow_dispatch:
push:
branches:
- main
- master
https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure?tabs=azure-portal%2Clinux#set-up-azure-login-with-openid-connect-authentication
permissions:
id-token: write
contents: read
jobs:
build:
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/azure-dev-cli-apps:latest
env:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
steps:
- name: Checkout
uses: actions/checkout@v3
  - name: Log in with Azure (Federated Credentials)
    if: ${{ env.AZURE_CLIENT_ID != '' }}
    run: |
        azd auth login `
          --client-id "$Env:AZURE_CLIENT_ID" `
          --federated-credential-provider "github" `
          --tenant-id "$Env:AZURE_TENANT_ID"
    shell: pwsh

  - name: Azure Dev Provision
    run: azd provision --no-prompt
    env:
      AZURE_ENV_NAME: ${{ secrets.AZURE_ENV_NAME }}
      AZURE_LOCATION: ${{ secrets.AZURE_LOCATION }}
      AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

  - name: Azure Dev Deploy
    run: azd deploy --no-prompt
    env:
      AZURE_ENV_NAME: ${{ secrets.AZURE_ENV_NAME }}
      AZURE_LOCATION: ${{ secrets.AZURE_LOCATION }}
      AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

thank you @varndellwagglebee
When you select pipeline config from the menu, a new command line is opened in VSCode with the log and progress
something like:

Can you share that log output please?

Found the problem.  The federated account was pointing to the wrong branch in GitHub.  It seems when you run azd profile config, it assumes you want a branch named main.  We have Master.  Thank you for all your help.
Anyone else having this issue, go into Azure Portal, app registrations, and make sure your service principal for GitHub is pointing to the correct branch.


Round ImageView with Glide

Since you are already using Glide you could add a round ImageView parameter for it.
Examples at:

http://stackoverflow.com/a/32390715/5193915
http://stackoverflow.com/a/25806229/5193915

that would be great (y)

This will be present in the next release, thank you for you feedback and suggestion!


Correcting Comments

I noticed they gave a warning in my IDE (netbeans).
So I fixed them

Thanks @matthiaz!


Cleanup pass through workflow files.

Format files
Pin dependencies (runner images, actions hashes)
Reorder job steps (start with actions/checkout)
Delete test_shark_studio.yml (this has been disabled for some time and it does not use any iree-turbine code)
Add copyright/license header comments

Why do we want to pin GH actions hashes instead of exact versions like v1.2.3?

Why do we want to pin GH actions hashes instead of exact versions like v1.2.3?

Rationale is at https://opensource.google/documentation/reference/github/services#actions
Tags can be moved easily while commit hashes can't. Pinning to a hash makes it so someone (e.g. a malicious actor) can't change the version that we use (e.g. to run malicious code). If someone does attack an action like that, we'd be insulated and could hopefully see complaints from other users before we would be affected.

More rationale for pinning actions versions: https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies


Ability to turn on autocommit would be nice

In issue #383, there was a clamor for autocommit.  But I think that issue was only addressed by cleanup and bell-adjustment, not by adding this feature.
I also would like autocommit and I don't find an existing request.  So: please add an autocommit option.

I'm going to call this fixed, since it's there, although there are many details that are under discussion, those will be filed as separate bugs.


Fix fastembed requirement, sed mandatory argument on macOS

48b5ce8 needs to be reverted and pushed with signed commit. Changes look fine.


crypto/tls: slow server-side handshake performance for RSA certificates without client session cache

Both go 1.8 and go tip provides too slow server-side handshake performance for RSA certificates if the client doesn't use TLS session cache:
$ go get -u github.com/valyala/fasthttp/fasthttputil
$ GOMAXPROCS=1 go test github.com/valyala/fasthttp/fasthttputil -bench=TLSHandshake
goos: linux
goarch: amd64
pkg: github.com/valyala/fasthttp/fasthttputil
BenchmarkPlainHandshake                                  	  300000	      3953 ns/op
BenchmarkTLSHandshakeWithClientSessionCache              	   20000	     81960 ns/op
BenchmarkTLSHandshakeWithoutClientSessionCache           	     500	   3493016 ns/op
BenchmarkTLSHandshakeWithCurvesWithClientSessionCache    	   20000	     80307 ns/op
BenchmarkTLSHandshakeWithCurvesWithoutClientSessionCache 	     500	   3518508 ns/op
PASS
ok  	github.com/valyala/fasthttp/fasthttputil	11.683s

The results show that a single amd64 core may perform only 300 handshakes per second from new clients without session tickets. This is very discouraging performance comparing to openssl as described on https://istlsfastyet.com/ :
$ openssl version
OpenSSL 1.0.2g  1 Mar 2016
$ openssl speed ecdh
...
                              op      op/s
 256 bit ecdh (nistp256)   0.0001s  12797.0
 384 bit ecdh (nistp384)   0.0007s   1416.8
 521 bit ecdh (nistp521)   0.0005s   1968.0

Note that openssl performs 12797 256-bit ecdh operations per second on a single CPU core. This is 40x higher than the results from the comparable BenchmarkTLSHandshakeWithCurvesWithoutClientSessionCache above.  RSA is not very optimized in go.

@vkrasnov , then probably ECDSA must go before RSA at initDefaultCipherSuites?

@valyala , you need an ECDSA certificate, you can try it and see if it helps:
go run `go env GOROOT`/src/crypto/tls/generate_cert.go --host=localhost --ecdsa-curve=P256

@vkrasnov , thanks - this raised the performance from 300 handshakes per second to 2000 handshakes per second on a single CPU core:
$ GOMAXPROCS=1 go test -run=111 -bench=Handshake -cpuprofile=cpu.pprof -benchtime=1s
goos: linux
goarch: amd64
pkg: github.com/valyala/fasthttp/fasthttputil
BenchmarkPlainHandshake                                  	  300000	      3968 ns/op
BenchmarkTLSHandshakeWithClientSessionCache              	   20000	     89539 ns/op
BenchmarkTLSHandshakeWithoutClientSessionCache           	    3000	    554257 ns/op
BenchmarkTLSHandshakeWithCurvesWithClientSessionCache    	   20000	     90366 ns/op
BenchmarkTLSHandshakeWithCurvesWithoutClientSessionCache 	    3000	    570461 ns/op
PASS
ok  	github.com/valyala/fasthttp/fasthttputil	10.383s

Are there plans to improve handshake performance for RSA certificates?

Are there plans to improve handshake performance for RSA certificates?

I personally have no such immediate plans. RSA is past its prime, and its usage is constantly dropping.

Added some benchmarks https://golang.org/cl/44730/

Judging by the Issue links, this looks like it has caused performance issues across a wide range of software. Is there anything that can be done to better inform Go users (and users of Go-based software) about the potential performance risks of using RSA certificates, or mitigate the issue?

Maybe a link to this issue in here ?  (didn't see an "Edit" link on the doc page, but "Report a website issue" in the footer points back to this repo, so looks like this is the right place)

@andig I don't think that CL fixes it. Seems like it was merged in 2018? In our issue https://github.com/fleetdm/fleet/issues/655, the flame graphs were recorded with Go 1.16.2.


502 Bad Gateway caused by: EOF

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I'm running Traefik in my home lab with more than 100 services and everything is perfect but one service. I have spent some time debugging the issue without success. I think there is an issue in Traefik.
The service not working is Gerbera => https://github.com/gerbera/gerbera
You can deploy it with Docker-compose:
  gerbera:
    image: gerbera/gerbera:1.9.2
    container_name: gerbera
    # port 49494/tcp (HTTP) and 1900/udp (SSDP Multicast)
    network_mode: host
    # enable debug traces
    # command: ["gerbera","--port", "49494", "--config", "/var/run/gerbera/config.xml", "--debug"]

This service has a Web UI in the port 49494. I can reach the UI with the web browser and with cURL.
curl -vvv http://<IP_ADDRESS>:49494/
*   Trying <IP_ADDRESS>:49494...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 49494 (#0)
> GET / HTTP/1.1
> Host: <IP_ADDRESS>:49494
> User-Agent: curl/7.74.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< CONTENT-LENGTH: 25834
< Accept-Ranges: bytes
< CONTENT-TYPE: text/html
< DATE: Mon, 06 Dec 2021 15:44:23 GMT
< LAST-MODIFIED: Sat, 13 Nov 2021 13:07:40 GMT
< SERVER: Linux/5.10.63-v7l+, UPnP/1.0, Portable SDK for UPnP devices/17.7.0
< X-User-Agent: redsonic
< CONNECTION: close
<
<!DOCTYPE html>
....

I can reach the service from inside Traefik container too:
wget http://<IP_ADDRESS>:49494/
Connecting to <IP_ADDRESS>:49494 (<IP_ADDRESS>:49494)
saving to 'index.html'
index.html           100% |*************************************************************************************************************| 25834  0:00:00 ETA
'index.html' saved

What did you see instead?
Traefik is returning 502 Bad Gateway caused by: EOF in all requests to this service. I let you the configuration and the debug traces.
What version of Traefik are you using?
Traefik v2.5.4 (running in official Docker container)
What is your environment & configuration?
http:
  routers:
    gerbera:
      entryPoints:
      - web
      service: k-gerbera
      rule: Host(`gerbera.home`)

  services:

    k-gerbera:
      loadBalancer:
        servers:
        - url: http://<IP_ADDRESS>:49494/

If applicable, please paste the log output in DEBUG level
time="2021-12-06T15:32:46Z" level=debug msg="Accept <IP_ADDRESS>: &{Method:GET URL:/UI/Dashboard Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8] Accept-Encoding:[gzip, deflate] Accept-Language:[en-US,en;q=0.5] Cache-Control:[max-age=0] Connection:[keep-alive] Dnt:[1] Upgrade-Insecure-Requests:[1] User-Agent:[Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0] X-Forwarded-Host:[gerbera.home] X-Forwarded-Port:[80] X-Forwarded-Proto:[http] X-Forwarded-Server:[43fc58680a17] X-Real-Ip:[<IP_ADDRESS>]] Body:0xc000b35830 GetBody:<nil> ContentLength:0 TransferEncoding:[] Close:false Host:gerbera.home Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr:<IP_ADDRESS>:50472 RequestURI:/UI/Dashboard TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc0004fe780}" middlewareType=IPWhiteLister middlewareName=ipwhitelist@file
time="2021-12-06T15:32:46Z" level=debug msg="vulcand/oxy/roundrobin/rr: begin ServeHttp on request" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/UI/Dashboard\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Accept-Language\":[\"en-US,en;q=0.5\"],\"Cache-Control\":[\"max-age=0\"],\"Connection\":[\"keep-alive\"],\"Dnt\":[\"1\"],\"Upgrade-Insecure-Requests\":[\"1\"],\"User-Agent\":[\"Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0\"],\"X-Forwarded-Host\":[\"gerbera.home\"],\"X-Forwarded-Port\":[\"80\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"43fc58680a17\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"gerbera.home\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:50472\",\"RequestURI\":\"/UI/Dashboard\",\"TLS\":null}"
time="2021-12-06T15:32:46Z" level=debug msg="vulcand/oxy/roundrobin/rr: Forwarding this request to URL" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/UI/Dashboard\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Accept-Language\":[\"en-US,en;q=0.5\"],\"Cache-Control\":[\"max-age=0\"],\"Connection\":[\"keep-alive\"],\"Dnt\":[\"1\"],\"Upgrade-Insecure-Requests\":[\"1\"],\"User-Agent\":[\"Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0\"],\"X-Forwarded-Host\":[\"gerbera.home\"],\"X-Forwarded-Port\":[\"80\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"43fc58680a17\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"gerbera.home\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:50472\",\"RequestURI\":\"/UI/Dashboard\",\"TLS\":null}" ForwardURL="http://<IP_ADDRESS>:49494/"
time="2021-12-06T15:32:46Z" level=debug msg="'502 Bad Gateway' caused by: EOF"
time="2021-12-06T15:32:46Z" level=debug msg="vulcand/oxy/roundrobin/rr: completed ServeHttp on request" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/UI/Dashboard\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Accept-Language\":[\"en-US,en;q=0.5\"],\"Cache-Control\":[\"max-age=0\"],\"Connection\":[\"keep-alive\"],\"Dnt\":[\"1\"],\"Upgrade-Insecure-Requests\":[\"1\"],\"User-Agent\":[\"Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0\"],\"X-Forwarded-Host\":[\"gerbera.home\"],\"X-Forwarded-Port\":[\"80\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"43fc58680a17\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"gerbera.home\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:50472\",\"RequestURI\":\"/UI/Dashboard\",\"TLS\":null}"
<IP_ADDRESS> - - [06/Dec/2021:15:32:46 +0000] "GET /UI/Dashboard HTTP/1.1" 502 11 "-" "-" 48 "gerbera@file" "http://<IP_ADDRESS>:49494/" 4ms

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

Please reopen. This is not a question. I have spend some time grabbing debug traces.