Average delay on mortality report day

It would be useful to see whether statistics on how the average delay in reporting changes over time.

The average delay in reporting for a day
Maybe the gradient for a linear(?) fit between (x, y) = (delayed days, number of reported cases) for the different days.  The gradient could tell us how things change over time.

Thats a really nice idea, but maybe for a separate graph. If I have time I'll make something like that during the weekend!

I took a look at this this weekend, but am not sure how to properly calculate the average lag. I ended up multiplying n_diff with days_since_publication for each row. Then adding these numbers for each date and dividing by the total number of rows per day ending up with:

Not sure how useful it is or how wrong my approach is.

Hey! Thanks, thats an interesting approach. I've been working on one here: https://raw.githubusercontent.com/adamaltmejd/covid/lag_plot/docs/lag_trend_sweden_latest.png
Would love to hear your thoughts. Still want to add some more information though.

Your approach on using reported date instead of death date on the x-axis is much better. I'm not sure on using delay on the y-axis though, but I might just need some time to adjust.
An alternative approach might be to use cases on the x-axis:

I started with exactly that layout, but thought it took to much focus from the delay itself. Its really hard cause one wants to separate the trend in delay from the trend in actual deaths. (and in absolute terms, depending on how you measure it, delay will increase mechanically with actual number of deaths).

Agreed, the trend is really difficult to get right. I tried displaying delay as a histogram instead. It kinda works to get an idea on delay in reporting, but not for trend analysis of course.

When you look at it faceted by day of week you might gain some more insights.

This plots the average lag for each publication day as before but by publication date instead of actual death date. The size indicates number of reported deaths that day. Finally a line with a 4 day rolling mean.

Thanks for your ideas! Added the WIP to the website now with a 90% percentile line inspired by what you did above @morberg. Gonna work some more on it tonight i think.

Clever to use a percentile for the trendline. It gives a good idea on how the lag is evolving and excludes outliers. Nice job on both this and your original graph.


[Question] Useable as a mod and more options than lua?

Hi :)
thank you for your work, it looks interesting.
Unfortunately I'm no programmer, so understanding anything from your work by looking at the code is not possible for me :D
But I'm currently "fighting" with lua scripts from Anno 1800 and every day hating the devs that they only exposed so incomplete stuff to lua ( 1) there is setPosition, but no getPosition. 2) I see no way to add/read out ObjectLabels that could be used to mark objects for usage in xml triggers Objectfilter, 3) there is no way to change owner of any object, just of selected, 4) no clue if it is possible to spawn an object in lua, there is a debugspawnobject, but no clue what arguments it expects ... and many many more missing important features).
So I wondered if there really is no better way to write nice scripts for Anno, than to struggle with this incomplete mess of lua :D
But it should be properly usable as a mod. So asking the user to install a separate program and to run it next to Anno is no option.
..
How does your project work? Would the things I listed above be possible with your scripting api in theory?
Would it somehow be possible to install it as a mod, at best with mod.io subscribe feature? Or at least with asking the users to put a custom dll into the games folder, like we did in the past with the modloader?
Btw. Taube lately found out how to calculate AreaIDs and OIDs from the SessionID,AreaIndex,IslandID,ObjectID. Not sure if you also needs such things in your scripting API or if you already knew how to do this.

thank you for the fast response :)
would be great if one could pack the api into a dll :) Since I'm no programmer I have no clue how, but I think it was done eg here: https://github.com/ChrisAnd1998/Anno1800ModMenu (installs a mod menu by just putting/replaces dlls into the game directory)
If this is done I could try to help to find out more. I'm good at finding workarounds and test around, made huge progress in Anno lua to loop through all objects, but I have no clue unfortunately about reverse engineering or hex addresses of whatever this includes :D


REORG: Modified conf.py and file location to build minimal example.

 Thanks for all the hard work.
I was interested in trying out the new .md parser + sphinx pipeline and was planning on using one of the chapters from the Elegant Scipy to test some features for scientific publishing. As far as I can tell, you had similar intentions with this repo, so I decided to start here instead - again, thanks for putting this together.
It seems like things are moving very fast so I'm not sure I have the organization of everything straight, but it seems like the "new .md" parser is now mostly wrapped up in the myst_parser repo, so I modified the install instructions for the sphinx project in doc/.
The remainder of the changes are related to updating the conf.py and moving some files around to get the absolute minimum example (i.e. a sphinx page with content from example.md only) building. I am using this as a starting point for testing with the more full-featured example in wealth_dynamics.md.
Please feel free to close this PR if this is too much of a distraction at this point with all of the rapid development happening. I will keep working in my fork and potentially make future PR's, but if you don't have the bandwidth to review them at the moment please let me know so I'm not spamming.

Hey! Thanks for chiming in :-) I am happy you think it's looking good!
Wanna add this as a PR to the myst_parser instead? We moved the sample pages from this repository to the docs in that repo so it's quicker to compare and iterate. I think the only thing to make sure is that the PRs adhere to the pre-commit checks (flake8 and black). WDYT?

No problem! I will look at the docs folder in myst_parser and make sure the changes are still relevant. In the meantime I've been getting the more full-featured (i.e. with the wealth_distributions.md file) working so I will see if I can't move those changes over to myst_parser/doc as well.

Turns out the changes I made here are no longer relevant :)

lol...well thanks for making them anyway :-)


Code Review: 2024-08-31

So first and foremost: it looks good! You used a good breadth of go features and the project itself is pretty complex, definitely above-average overall. I was able to run it locally and it's pretty fuckin cool.
I treated this more or less like I would if I was at work, so now you know whether or not you'd ever want to work with me :P I left comments around in places where I thought maybe something could be improved, but I think most of it is nitpicky so please feel free to ignore any of it. If you wanna start a discussion about something just leave a GH comment :)
You mentioned wanting to get rid of some code duplication in vis, but I really don't see much. Maybe you tackled that after you messaged about it?
Regarding a sync bug with beep I really have no idea, the FFT/sound stuff went completely over my head, I can only judge the overall structure and flow of data in the project.

So the sync bug and the duplication I already fixed, looking now :)


adding Ali Ok as maintainer for cncf/mentoring as a GSoC admin

Opening this PR to help work through https://github.com/cncf/mentoring/pull/855


Resolve FIXME

func (bw *BitWriter) Write(data, numBits uint) {
//for i := (numBits-1); i >= 0; i-- {
//FIXME: the above commented line will cause infinite loop, why???
for i := numBits; i > 0; i-- {
Because I becomes uint, lets check iteration when i == 0, at the end of loop, i-- takes place but as I is uint, it leans to 2^32-1 instead of -1, loop condition is still true...

Thank you!!! Now I understand!!!


feat: add ai ollama workflows

Description:
This pull request updates the n8n workflow configuration with
three new sticky notes, a custom tool to retrieve Hacker News
data, and updated connections between nodes. The changes aim to
improve the AI agent's functionality and user experience.
Changes:
• Added three new sticky notes:
• "Sticky Note2" with custom content and position.
• "Sticky Note3" with brief introduction to try out the AI
agent.
• Third sticky note (no specific content or position yet).
• Created a custom tool, "hn_tool", to call another workflow and
retrieve Hacker News data in JSON format.
• Updated connections between nodes:
• "Hacker News" node now connects to "Clean up data" node.
• "OpenAI Chat Model" node now connects to "AI Agent" node.
• "Execute Workflow Trigger" node now connects to "Hacker
News" node.

wip

need to also back up current

merged


feat: JS Wrapper Around The Polywrap CLI

As discussed here: https://github.com/polywrap/toolchain/pull/1343

Hey @dOrgJelli would it be possible to fix LGTM alerts before merging this?

Hey @Niraj-Kamdar, the reasons for having the JS SDK spawning the CLI as a child process are as follows:

Makes it easy to run multiple tasks in parallel.
Forms a clear dividing line between parent & child process, so you can better control things like system-level restrictions.
The CLI already assumes it is running in a separate process, 1 command = 1 process life-time, so changing this assumption could cause some code to not run well (maintain bad state between runs, etc).
Allows us to recreate the CLI in another language that isn't JS.

Also the point of this package is to allow users to easily script against the CLI in JS, while maintaining type safety with the CLI's commands & their arguments + options. We've written it in a way that the types flow easily from the command's source files, into the wrapper SDK, see here:
https://github.com/polywrap/toolchain/blob/ece1d33f7af4b9f22b7405fc15ac4d3435667a2c/packages/cli/src/commands/index.ts#L29-L66
And here:
https://github.com/polywrap/toolchain/blob/ece1d33f7af4b9f22b7405fc15ac4d3435667a2c/packages/js/cli/src/commands/index.ts#L30-L54
This gives us an easy to use (typed) interface like so:
await Commands.build({
  manifestFile: "...",
  outputDir: "...",
  codegen: true
}, {
  cwd: "/path/to/project",
  env: {
    CUSTOM_ENV_VAR: "..."
  }
});

Given all of this, would you agree this package is useful and implemented well?

@pileks description updated! Thanks for the req.


Python 3.7 Contains an Unresolved Reference to libpython3.7m.so.1.0

Describe the bug
The _codecs_iso2022.cpython-37m-x86_64-linux-gnu.so library needs libpython3.7m.so.1.0 but doesn't know it's in ../../lib/.
Deploying dependencies for ELF file /app/appimage/asdf/asdf.AppDir/usr/lib/python3.7/lib-dynload/_codecs_iso2022.cpython-37m-x86_64-linux-gnu.so        subprocess.py:408
Deploying shared library /usr/lib/x86_64-linux-gnu/libpython3.7m.so.1.0

❯ ldd ~/tmp/beeware/asdf/linux/appimage/asdf/asdf.AppDir/usr/lib/python3.7/lib-dynload/_codecs_iso2022.cpython-37m-x86_64-linux-gnu.so
	linux-vdso.so.1 (0x00007ffe0cbcb000)
	libpython3.7m.so.1.0 => not found
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f055e800000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f055ef28000)

To Reproduce
Run briefcase run linux appimage with Python 3.7.
Expected behavior
This codecs library should reference the libpython3.so created as part of this build process.
Additional context
Honestly, I'm fine if this is closed as "will not be fixed":

this works if users use Docker
simple workarounds using LD_LIBRARY_PATH or installing python3.7-dev
the other Python versions aren't affected

As you note, I think this will be a wontfix; Python 3.7 is no longer supported by Briefcase, and AFAICT, this was entirely an issue with the 3.7m version of the Python library.


[MoveOnlyAddressChecker] Fix representation for reinit'd fields.

The move-only address checker records instructions that reinit fields in its reinitInsts map.  Previously, that map mapped from an instruction to a range of fields of the value.  But an instruction can use multiple discontiguous fields of a single value.  (Indeed an attempt to add a second range that was reinit'd by an already reinit'ing instruction--even if it were overlapping or adjacent--would have no effect and the map wouldn't be updated.)  Here, this is fixed by fixing the representation and updating the storage whenver a new range is seen to be reinit'd by the instruction.  As in https://github.com/apple/swift/pull/66728 , a SmallBitVector is the representation chosen.
rdar://111356251

@swift-ci please test

CC: @kavon @gottesmm @jckarter

@swift-ci please test macos platform

@swift-ci please test

Rebased and force-pushed in order to prefix the new use of Optional with llvm:: which is now required on main.

@swift-ci please test and merge

@swift-ci please smoke test macos platform


print a debug message when the server is started

Codecov Report

Merging #806 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   91.61%   91.61%   +<.01%
==========================================
  Files          81       81
  Lines        5861     5862       +1
==========================================
+ Hits         5369     5370       +1
  Misses        306      306
  Partials      186      186

Impacted Files
Coverage Δ

server.go
90.86% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6719bf...7ec09d2. Read the comment docs.


[Dropdown] Support for search in-menu selection

Dropdown with a search input inside the menu is perfect from UX point of view for my use case but it seems that it cannot be used when a dropdown has selection class on it:

I guess it is only supported when dropdown is a button?
I'd be willing to try to develop this but please let me know if this even makes sense and is in-line with your roadmap / design vision of the dropdown component.

Selection menu are a special type of dropdown that only support item.  (Think of it as a reskin of a <select>
Only normal dropdowns support header, divider, or input


Fix/bolt character ie 11

Jira
https://app.asana.com/0/1126340469288208/1147761775577724/f
Summary
Make refactored bolt-character and bolt-two-character-layout work on IE 11.
Details
Everything looks good on IE 11. I had to set some fixed widths, as you can see, because IE 11 really didn't want to use calcs and allow things to have their own widths no matter what I tried, but I made some classes that give more space to bolt-character given whether or not one or both sides have content, so it's looking pretty good.
How to test
On IE 11 and a non-IE 11 machine, see:
pattern-lab/patterns/06-experiments-micro-journeys-15-character-kitchen-sink/06-experiments-micro-journeys-15-character-kitchen-sink.html
and
pattern-lab/patterns/06-experiments-micro-journeys-90-micro-journeys/06-experiments-micro-journeys-90-micro-journeys.html

I'm integrating these changes now, thanks all.

PR was released with v2.11.0


fix initialization bug for kwargs in function

Generator.function does not define self.kwargs when we don't pass that argument progamatically in function.Single.
To reproduce this error, invoke garak's cli like below
from garak.cli import main as garak_main
from typing import List

def generate_text(
) -> List[str]:
    return "empty str"

def main():
    args = [
        "-m",
        "function.Single",
        "-n",
        f"{__name__}#generate_text",
        "-p",
        "test.Blank"
    ]
    garak_main(args)

if __name__ == "__main__":
    main()

Offered fix resolves this issue.

I have read the DCO Document and I hereby sign the DCO

recheck

thank you! will take a look

This is a confirmed issue introduced by #711, when attempting to account for restricted parameter names.

Looks like the commit messages are missing the sign-off please adjust to ensure the branch is compliant with the DCO.


[Bug] darmuhsTerminalStuff dependency appears to break the terminal

using suitsTerminal 1.5.11 without darmuhsTerminalStuff
certain actions in the "suits" submenu will yield a darmuhsTerminalStuff error that doesn't prevent use of the terminal (first error block).  Exiting out of the suits submenu back to the main section of the terminal will break the terminal and no inputs will be entered or responded to.  Computer terminal must be force exited and reused to become unbroken (second error block)

edit: also occurs when rolling back to 1.5.9.  Rolling back to 1.5.8 fixes it.

yeah sorry, 1.5.11 was zipped with the wrong .dll file
Was too quick to upload yesterday. Should be fixed in 1.5.12


[release/8.0] Update OTEL HTTP instrumentation packages to 1.8.1

Microsoft Reviewers: Open in CodeFlow

/backport to release/8.0-preview6

@JamesNK  - did you happen to see https://github.com/dotnet/aspire/pull/3676#discussion_r1566223568?


added rules for Loki

This PR adds alerts for Loki
Ops-recipes: https://github.com/giantswarm/giantswarm/pull/22375
Towards https://github.com/giantswarm/roadmap/issues/718
No dashboards created yet. I hope to use loki-mixins in the future, but we should have some working loki instances first!
Checklist

[x] Update changelog in CHANGELOG.md.
[x] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
[x] Alerting rules must have a comment documenting why it needs to exist.
[ ] Consider creating a dashboard (if it does not exist already) to help oncallers monitor the status of the issue.

What do you think about adding up alerts for hte loki components as well ? Unless we want to start on a loose SLO ?

@QuentinBisson :

What do you think about adding up alerts for the loki components as well ? Unless we want to start on a loose SLO ?

The only missing component there is the compactor (the only one that does not manage actual requests), and the official mixins use data from a rewriterule for that. So I propose to add it later, when we have rewriterules in place.
If you are talking about checking an instance of Loki, with all its components, is currently running, that has to be optional for the moment.
I'm not sure I see what you have in mind, maybe you could give more details?
Anyway, I feel like today we lack knowledge to create meaningful alerts.
@TheoBrigitte :

I feel like those alerts are quite sensitive. Could you please increase the time windows? To hours maybe?

for error percentage, why not; done :heavy_check_mark:
for panic messages though, I think if they set it this way it means only 1 panic message means there is a critical problem, and there may be no more messages after that. I'd prefer we wait and have some real-life feedback before we change this one.


fix: Pass through env vars for services

This PR passes through env vars specific to certain services to the Helm chart used to install W&B.

This PR is included in version 3.0.4 :tada:


Fixing nested types in a map

Related to #7

Codecov Report

Merging #11 (9286907) into main (1d8d980) will increase coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   82.66%   83.33%   +0.66%
==========================================
  Files           2        2
  Lines         150      156       +6
==========================================
+ Hits          124      130       +6
  Misses         26       26

Impacted Files
Coverage Δ

src/pydantic_avro/avro_to_pydantic.py
70.37% <100.00%> (ø)

src/pydantic_avro/base.py
97.33% <100.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8d980...9286907. Read the comment docs.


migrate presets to ES6 modules for #3118

The only change I had to make to namespaces was that iD.presets itself used to be a function; I moved it to iD.presets.presets.

👏  Awesome work, thanks @beaugunderson !


some medias are not downloadable

https://vector.im/beta/#/room/!GnEEPYXUhoaHbkFBNX:matrix.org/%241469168680290660TTMro:matrix.org

This issue was triggered because the file has no mimetype.
By now, the default mimetype is application/octet-stream.

https://github.com/matrix-org/matrix-android-sdk/commit/1652834aeb3771104c0b4c45058d9e59375a282f
https://github.com/vector-im/vector-android/commit/89945f22e58de41bc5efed573d0c7feb94cba9b9


chore: remove unnecessary autoprefixer from postcss config

parcel complained constantly about autoprefixer being redundant and slowing things down. lets give it a try without.

Coverage remained the same at 81.973% when pulling 6bb34e4be58b9ddea9f1614a1feb82c3cc6556ce on boredland:chore/remove-autoprefixer into 4e6eed4401a93f820fec0667bfa31879bbc2e19a on quirrel-dev:main.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 2d552be...5c8cc3c:
  > 5c8cc3c Ignore migration of CRDs that aren't installed (# 2493)
bumping knative.dev/serving 5128270...f6cb424:
  > f6cb424 Add support for `dnsConfig` and `dnsPolicy` in pod spec (# 12897)
  > 89be0fd modify checksum so its not a float64 (# 12900)
  > 078e0b9 upgrade to latest dependencies (# 12899)
  > 0d76bb7 Update net-certmanager nightly (# 12879)
  > 95cfa70 ServerlessService's initial operation mode is now Proxy (# 12842)
bumping knative.dev/eventing 2219e14...01f5612:
  > 01f5612 fix pingsource-mt-adapter crash when initial replica is more than 0 (# 6359)
  > 11dd387 Update support rotation (# 6351)
  > 98de1d7 upgrade to latest dependencies (# 6350)

/lgtm
/approve


Execution TIme is not displayed

I am completely new in python.
I have installed the extention via pip as well as conda. But the execution time is not displayed.
There is a tab "Execute Time" under Advance Settings and it is also activated, but I don't get any information about the execution time if i run a cell.
I am using juypterLab version 3.5.3.
I can't find the place where to enter {"recordTiming": true}.
For me it looks like this under setting:

Can you search for record?

Thanks for your reply.
here how it looks

I got the same problem. My jupyter lab version is 3.6.4. I have installed this extension succesfully. And for my installation., the parameter recordTiming default is false. So I modified to true and saved the configuration as well. No matter I refreshed the jupyter lab in browser or restarted the jupyter lab, the cell executing time was still not showing below the cell.

Same issue. Work around is to revert back to 3.6.3.

Thanks ianalis, it works after downgraded jupyterlab_execute_time to version 2.3.1.

Same here,  version 2.3.1 works while 3.0.0 not

Per the changelogs, 3.0.0 only supports<EMAIL_ADDRESS>- https://github.com/deshaw/jupyterlab-execute-time/blob/master/CHANGELOG.md#300-2023-05-19

i revert back to v2.3.1, but it still can't display time in cell.

i already setting user preference {"recordTiming":true}, but it still can't display execute time in cell.  how can i solve this problem

Same issue here, cannot display the cell execution time after setting the recordTiming field to true.
Using jupyterlab version 4.0.2 with mamba. How do I resolve this

i revert back to v2.3.1, but it still can't display time in cell.

@gasdaf you have a pretty outdated JupyterLab installation. Since other users report 2.3.1 works with Lab 3.x, maybe they are using a newer version of Lab 3.x, e.g. 3.6.x?

Pinning version of JupyterLab in:
https://github.com/deshaw/jupyterlab-execute-time/blob/d9be07175d00a204452777cea6e45f4a41f41505/setup.py#L44
and yanking 3.0.0 from PyPI is the simplest solution.
Another approach would be to release a 3.0.1 as cross-compatible with both Lab 3.x and 4.0. This should be feasible but a bit more involved on the maintenance and testing end.

Mine also worked when I downgraded to 2.3.1


fse.rmSync is not a function when using Serverless CI/CD

Hi,
Thanks for the nice package.
Running this as serverless deploy ... from my machine is fine.
But Serverless CI/CD is failing me:
CI output:
...
Serverless: Copy prisma schema for AuthorizerFunction...
Serverless: Generate prisma client for AuthorizerFunction...
Serverless: Remove unused prisma engine:
Serverless: -<EMAIL_ADDRESS>
 Type Error ----------------------------------------------
  TypeError: fse.rmSync is not a function
      at /api/node_modules/serverless-webpack-prisma/src/index.js:54:13
      at Array.forEach (<anonymous>)
      at ServerlessWebpackPrisma.onBeforeWebpackPackage (/api/node_modules/serverless-webpack-prisma/src/index.js:51:21)
      at PluginManager.runHooks (/api/node_modules/serverless/lib/classes/PluginManager.js:573:41)
      at PluginManager.invoke (/api/node_modules/serverless/lib/classes/PluginManager.js:612:20)
      at async PluginManager.spawn (/api/node_modules/serverless/lib/classes/PluginManager.js:635:5)

serverless.yml
...
webpack:
    webpackConfig: "webpack.config.js"
    packager: "npm"
    includeModules: true

package:
   individually: true

webpack.config.js
const path = require("path");
const slsw = require("serverless-webpack");
const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin");
const nodeExternals = require("webpack-node-externals");

const { isLocal } = slsw.lib.webpack;

module.exports = {
  entry: slsw.lib.entries,
  mode: isLocal ? "development" : "production",
  devtool: "source-map",
  externals: [nodeExternals()],
  resolve: {
    extensions: [".ts", ".tsx"],
    alias: {
      lib: path.resolve(__dirname, "lib"),
      core: path.resolve(__dirname, "core"),
    },
  },
  output: {
    libraryTarget: "commonjs2",
    path: path.join(__dirname, ".webpack"),
    filename: "[name].js",
  },
  target: "node",
  optimization: {
    minimize: false,
  },
  module: {
    rules: [
      {
        test: /\.ts(x?)$/,
        loader: "ts-loader",
        exclude: [
          path.resolve(__dirname, "node_modules"),
          path.resolve(__dirname, ".serverless"),
          path.resolve(__dirname, ".webpack"),
        ],
        options: {
          transpileOnly: true,
          experimentalWatchApi: true,
        },
      },
    ],
  },
  plugins: [new ForkTsCheckerWebpackPlugin()],
};

Would you have any idea? Any help is appreciated!

Hello.
Thank you for your interest in the package and for leaving an issue.
We are currently in the process of removing unnecessary engines with the fs-extra library. Perhaps there was an error in the process.
The fs.rmSync function has been added to the 14.14.0+ version, but perhaps the serverless CI is using the version below.
Moving on to 1.0.4, changed to removeSync instead of rmSync so that it can be used in lower versions as well. It would be good to update the version to version 1.0.4 and proceed with the distribution.
thank you. :)

Let's close the issue for now. If there is a problem after checking, please open the issue again.
Thank you :)


the link for script run_sharedtask_eval.sh is corrupted

Hi, I can't access the run_sharedtask_eval.sh . It gives 404 error. Could you please check.
Thanks

So sorry about it! Fixed in that README. It should be here.
Thanks,
Song


Complicated text

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[ ] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository -> don't know
[x] Bug is not already reported in another issue

Technical details

Device name:
Android version:
App version: 2.17.2

Describe the bug
German text is quite complicated, "diesbezüglich " , "in Bezug auf "

Steps to reproduce the issue

Go to RAT Testcenter
Click on 'kein EU-Testzertifikat anfordern"
See the info text shown above

Expected behaviour
The first 'diesbezüglich' is not necessary.
Possible Fix
Remove the word.
Additional context
May be it's the same text in the iOS App, so it should be changed there as well.

@dsarkar Will this issue be mirrored to JIRA soon?

Thanks for your report @DerVogel2020. We have created an internal ticket for it and will raise this topic internally.
Internal Tracking ID: EXPOSUREAPP-12855

Corona-Warn-App Open Source Team


Dynamically changing log level at Application level

Storm has the feature of Dynamic Log Level Settings, which enables users to change log level of Loggers in specific package (and sub package/classes).
We would like to provide the same feature as well, but allowing only Application level cause the runtime class of SAM component may be not unique across components in Application.

#1016

thanks @HeartSaVioR , merged #1016 to master.


ChromaCam

Package Requested

[x] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information if you can:
Publisher:
Publisher Url:
Package Name:
Package Url:
Description:
Package Version:
Installer URL:
For new versions:
Current Package Identifier:

Supporting custom hardware in validation is "Not Planned".

https://github.com/microsoft/winget-pkgs/issues/199504


Replace closures with view::from_fn

Hey love this project! 🤙
Is it possible to remove the closures from views to reduce the syntax noise? I'm assuming it's sometimes useful to use a closure, like for nested state,  but I think those cases could use view::from_fn where we could impl View for some FromFn type

Thanks for your interest.
I'm not familiar with FromFn. Any simple example to show how it works?

Something like https://doc.rust-lang.org/std/iter/fn.from_fn.html
Basically it would just exist to handle cases where you do want your view inside a closure. Then we could write v_stack(text("Hello world!"))  and v_stack(view::from_fn(|| text("Hello world!")))

Got it thanks for clarifying.
The view has to be always inside a closure though because the child's id needs to be created based on the parent's id.

Oh interesting sorry I didn't know. In that case couldn't views get their context from the View trait? If they're already being returned I feel like IDs can be created in one of those methods, similar to xilem.

I think I know how I can lose the closure now. Thank you so much for bringing this up!

Awesome! Looking forward to checking it out

It's done in main now. I've also added text(). The couter example looks much better!

For sure I think it looks great! Can't wait to try it out 👍


changes

fix filtering for mccc
change to using a boolean instead of math for setting crop.inactive
fix loading screen for explorer
remove unneeded logic for local variable in Filters
more error handling for returning No Data in data extractor

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


fix,chore,refactor(egen): Changed CLUSTER_REGION variable name to CLUSTER_LOCATION, added gcloud command to enable dataproc api, modified bigquery dataset name by replacing hyphens to underscores, removed uuid code generation and replaced uuid with unique, refactored code according to template guidelines and perfomed linter test.

This PR includes the following updates:

Adds Colab Enterprise link and other structural changes from the new template.
Changes CLUSTER_REGION variable name to CLUSTER_LOCATION.
Adds gcloud command to enable dataproc api.
Modifies bigquery dataset name by replacing hyphens to underscores.
Removes uuid code generation and replaced uuid with unique.
Adds comments for cells needed.
Contracts words like is not, do not, You are, etc.

REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

/gcbrun


Avoid hydration mismatch error in tutorial

Our Greeting.jsx component in the tutorial randomises its initially displayed greeting opening the door to a hydration mismatch on the client. We should avoid this by making the initially displayed greeting predictable, e.g.
-  const [greeting, setGreeting] = useState(randomMessage());
+  const [greeting, setGreeting] = useState(messages[0]);

Discord report: https://discord.com/channels/830184174198718474/830184175176122389/1086023239723130971

Fixed by @BryceRussell ! Not the first time I've written that today! :partying_face:


Hi, I use the component ExportImage but it come to an error says "filePath.split is not a function", how do i fix it?

Hi, I use the component ExportImage but it come to an error says "filePath.split is not a function", how do i fix it?
Originally posted by @milkeddy1 in https://github.com/Niels-IO/next-image-export-optimizer/issues/24#issuecomment-1200419408

Hi @milkeddy1 ,
The error means that you probably imported an image like this:
import logo from '../public/images/logo.png'
<ExportedImage src={logo} />

Unfortunately, this is not supported. Please specify the src like this:
<ExportedImage src='images/logo.jpg' />

You're right! Thanks.

Would it be possible to support this?
Doing it this way sets the width property without having to specifiy it manually, with a string path src it wants to have an explicit width set: Error: Image with src ... must use "width" and "height" properties or "layout='fill'" property.
https://nextjs.org/docs/basic-features/image-optimization#local-images

Hi @phiresky,
I looked into it, and I think it is impossible, as far as I know.
When you import an image like this:
import image from "../public/images/chris-zhang-Jq8-3Bmh1pQ-unsplash.jpg";    <ExportedImage             src={image}             layout="fill"             id="test_image"             objectFit="cover"             priority={true}             alt={"test_image"}     />
the src property becomes
{ blurDataURL: "/_next/image?url=%2F_next%2Fstatic%2Fmedia%2Fchris-zhang-Jq8-3Bmh1pQ-unsplash.921260e0.jpg&w=8&q=70" height: 4000 src: "/_next/static/media/chris-zhang-Jq8-3Bmh1pQ-unsplash.921260e0.jpg" width: 6000 }
It obfuscates the correct image location in the public folder, so I cannot work with the image in the ExportedImage component.

thank you for the response. i think it's possible with restrictions. My workaround currently looks as follows:

I wrap ExportedImage to set width and height and src as ExportedImage expects them (this could be done within the library)

export default function ExportedImageCompatible(_props: ImageProps) {
  const { src: _src, ...props } = _props;
  let src = _src;
  console.log(src);
  if (typeof src !== "string") {
    if ("default" in src) {
      src = src.default;
    }
    if (!props.width) props.width = src.width;
    if (!props.height) props.height = src.height;
    src = src.src;
  }
  return <ExportedImage {...props} src={src} />;
}

I set the following configuration:

    nextImageExportOptimizer_imageFolderPath: "out/_next/static/media",
    nextImageExportOptimizer_exportFolderPath: "out",

next.js copies the images to the out/_next/static/media directory during the build step. Then next-image-export-optimizer loads those images and transformes them from there
This seems to work ok so far

If the static import of image - and thus omitting the width/height props - is not supported, then it should be removed from the example mentioned in README.md
// Or with static import
import ExportedImage from "next-image-export-optimizer";
import testPictureStatic from "PATH_TO_IMAGE/test_static.jpg";

<ExportedImage
  src={testPictureStatic}
  alt="Static Image"
  layout="responsive"
/>;

Hey @jdolinski1, this is actually a very recent functionality that I implemented. So the library works now with statically imported images as well 🙂

Ah, sorry! Thanks.


opensearchpy.exceptions.RequestError: Illegal character ((CTRL-CHAR, code 31)): only regular white space (\r, \n, \t) is allowed between tokens

Hi,
On v 2.11.0 I am getting this error when upserting to latest using opensearch.py... When I downgrade to version 2.9.0 it works fine.
 traceback (most recent call last):
  File "/app/manage.py", line 22, in <module>
    main()
  File "/app/manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.11/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.11/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.11/site-packages/django/core/management/base.py", line 412, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.11/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/richlist/management/commands/get_sgb_explorer_data.py", line 47, in handle
    obj.save()
  File "/app/richlist/models.py", line 65, in save
    super(SongBirdAccount, self).save(*args, **kwargs)
  File "/app/richlist/models.py", line 20, in save
    super(AccountAbstract, self).save(*args, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 814, in save
    self.save_base(
  File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 892, in save_base
    post_save.send(
  File "/usr/local/lib/python3.11/site-packages/django/dispatch/dispatcher.py", line 176, in send
    return [
           ^
  File "/usr/local/lib/python3.11/site-packages/django/dispatch/dispatcher.py", line 177, in <listcomp>
    (receiver, receiver(signal=self, sender=sender, **named))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/richlist/signals.py", line 9, in save_document_sgb_accounts
    instance.to_elastic(instance.address)
  File "/app/richlist/models.py", line 53, in to_elastic
    client.update(
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/client/utils.py", line 179, in _wrapped
    return func(*args, params=params, headers=headers, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/client/__init__.py", line 1769, in update
    return self.transport.perform_request(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/transport.py", line 409, in perform_request
    raise e
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/transport.py", line 370, in perform_request
    status, headers_response, data = connection.perform_request(
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/connection/http_urllib3.py", line 266, in perform_request
    self._raise_error(
  File "/usr/local/lib/python3.11/site-packages/opensearchpy/connection/base.py", line 301, in _raise_error
    raise HTTP_EXCEPTIONS.get(status_code, TransportError)(
opensearchpy.exceptions.RequestError: RequestError(400, 'json_parse_exception', 'Illegal character ((CTRL-CHAR, code 31)): only regular white space (\\r, \\n, \\t) is allowed between tokens\n at [Source: (org.opensearch.core.common.io.stream.InputStreamStreamInput); line: 1, column: 2]')

@mmansour do you have a step-by-step repro, please?

Sorry I don't. It would be hard to create one in this case.
It kept happening on every rerun of a script that pulls data from external
resources.
The upserted JSON looked valid on the offending records.
Not sure what was happening. But in my scenario it made sense to just
downgrade to the version of opensearch that was working last month.
On Tue, Oct 24, 2023 at 9:38 AM Daniel (dB.) Doubrovkine <
@.***> wrote:

@mmansour https://github.com/mmansour do you have a step-by-step repro,
please?
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/OpenSearch/issues/10747#issuecomment-1777616159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRODQU5QCEPT4HSWWX2ZLYA7VITAVCNFSM6AAAAAA6HLP7ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGYYTMMJVHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I think https://github.com/opensearch-project/OpenSearch/issues/10802 is the same thing and has a lot of detail. I'm going to close this one. Can you please confirm they are the same problem @mmansour?

Yeah that looks like the one.
Thank you!
On Tue, Oct 24, 2023 at 9:52 AM Daniel (dB.) Doubrovkine <
@.***> wrote:

I think #10802
https://github.com/opensearch-project/OpenSearch/issues/10802 is the
same thing and has a lot of detail. I'm going to close this one. Can you
please confirm they are the same problem @mmansour
https://github.com/mmansour?
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/OpenSearch/issues/10747#issuecomment-1777643893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRODVTYXZTQJ5VG2ZGIA3YA7W5PAVCNFSM6AAAAAA6HLP7ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGY2DGOBZGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


customfields configuration error/ignored?

Documentation example, produce com.fasterxml.jackson.core.JsonParseException:
<customFields>{"appname":"myWebservice","roles":["customerorder","auth"],"buildinfo":{"version":"Version 0.1.0-SNAPSHOT","lastcommit":"75473700d5befa953c45f630c6d9105413c16fe1"}}</customFields>
the following josn will be excepted but will not appear in output:
"appname":"myWebservice","roles":["customerorder","auth"],"buildinfo":{"version":"Version 0.1.0-SNAPSHOT","lastcommit":"75473700d5befa953c45f630c6d9105413c16fe1"
setting the customfields programmatically is working fine.

Hi @Khinsu,
This is caused by a bug in logback.... LOGBACK-1101
Please vote for that issue on logback's jira site if you'd like to see it fixed.

The logback bug seems to be for nested fields in my reading. I am simply trying to do the following without any nested fields:
<customFields>{"appname":"myWebservice"}</customFields>
I have added it as a child of the appender and as a child of the encoder with no luck.
Is there a need for a separate bug in logback or is this possibley a bug in the encoder?

Correct.  The logback bug only applies to nested JSON objects.
I just tested the following configuration
<appender class="ch.qos.logback.core.ConsoleAppender">
    <encoder class="net.logstash.logback.encoder.LogstashEncoder">
        <customFields>{"appname":"myWebservice"}</customFields>
    </encoder>
</appender>

with this Main class...
public class Main {
    private static final Logger LOGGER = LoggerFactory.getLogger(Main.class);

    public static void main(String[] args) throws InterruptedException, IOException {
        LOGGER.info("Some message");
        ((LoggerContext) LoggerFactory.getILoggerFactory()).stop();
    }
}

and received this output:
{"@timestamp":"2016-07-20T22:18:53.255-07:00","@version":1,"message":"Some message","logger_name":"net.logstash.logback.Main","thread_name":"main","level":"INFO","level_value":20000,"appname":"myWebservice"}

So, this appears to be working for me.
Can you provide the exact configuration you are using?
Can you try outputting to the console appender as I have done to examine the encoder output directly?

Note that LOGBACK-1101 has been marked as fixed in logback 1.3.0-alpha3

{"appname":"myWebservice"}

Is there any way to restrict data type for custom fields to a data type?

@Khinsu Are you still experiencing problems with this?

hi, think I'm running into the same issue
I have the following in logback.xml
    <appender name="console" class="ch.qos.logback.core.ConsoleAppender">
        <encoder class="net.logstash.logback.encoder.LogstashEncoder">
            <customFields>
                {"serviceContext":{"service":"foo"}}
            </customFields>
        </encoder>
    </appender>

When using logstash-logback-encoder 7.0.1, I'm getting the follow error
02:17:46,889 |-INFO in ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default type [net.logstash.logback.fieldnames.LogstashFieldNames] for [fieldNames] property
02:17:47,133 |-ERROR in net.logstash.logback.composite.GlobalCustomFieldsJsonProvider@4d5b181d - [customFields] is not a valid JSON object com.fasterxml.jackson.core.io.JsonEOFException: Unexpected end-of-input: expected close marker for Object (start marker at [Source: (String)"{"serviceContext":{"service":"leonardo"}"; line: 1, column: 1])
 at [Source: (String)"{"serviceContext":{"service":"leonardo"}"; line: 1, column: 41]
        at com.fasterxml.jackson.core.io.JsonEOFException: Unexpected end-of-input: expected close marker for Object (start marker at [Source: (String)"{"serviceContext":{"service":"leonardo"}"; line: 1, column: 1])
 at [Source: (String)"{"serviceContext":{"service":"leonardo"}"; line: 1, column: 41]
        at      at com.fasterxml.jackson.core.base.ParserMinimalBase._reportInvalidEOF(ParserMinimalBase.java:682)
        at      at com.fasterxml.jackson.core.base.ParserBase._handleEOF(ParserBase.java:494)
        at      at com.fasterxml.jackson.core.base.ParserBase._eofAsNextChar(ParserBase.java

If I change customFields to  {"serviceContext": "foo"}, things work as expected.
I tried upgrading logback-classic to 1.3.0-alpha10, but no log was generated

Hi @Qi77Qi ,
Sorry to hear you have a problem.
As mentioned by @philsttr, this unfortunate behaviour is caused by a Logback bug (LOGBACK-1101 which appears to be solved in Logback 1.2.0-alpha3.
I did a test with your configuration after upgrading to Logback 1.3.0-alpha10 and could not reproduce what you experience. The pattern string is now properly passed to the LogstashEncoder and not corrupted by Logstash's property substitution mechanism anymore. No exception is thrown anymore and the "serviceContext" custom field is properly added as last field of the generated JSON.
Could you please double check your setup and make sure your application is actually using the latest Logback? Do not hesitate to attach a fully working Maven project to demonstrate the issue if needed...


Check and resolve all todo items originating from the feature/subform branch

Description
Before merge to main, resolve all outstanding todo items. Most are trivial, others probably require a bit more consideration.

👍


Create decision point Model

This model should include information about decision points such as what the accept button, decline button, etc look like.  This would allow easier modification later and I want practice setting this up to pull info from the backend programmatically

handled and merged here: https://github.com/anthony-devarti/sl-db/pull/1


Update stripped extended spec

It has missing the constant for 'no-route' code 312. This constant is
present in the extended non-stripped version and it is supported by
RabbitMQ.

Do we need to backport this PR to stable and/or main ?

@Zerpet yes, to keep the delta to the minimum. I will do that. We merge live into stable and stable into main every so often anyway.


[1841] Sort function for autocompletes

Context
https://trello.com/c/yVBgFUSO/1841-l-productionize-the-sorted-autocomplete-code
Changes proposed in this pull request
Adds a client-side sort function to all our standard autocompletes - not schools (where the results are determined on the backend) and not countries (external lib).
Guidance to review

Review all autocompletes, except the schools and countries autocomplete (this are unchanged)
Check that they returned 'nicely' sorted results
Pay particular attention to the degree type autocomplete which should display synonyms bolded in brackets and searches 'intelligently' on the synonyms too.

 [L] Productionize the sorted autocomplete code

All good


Investigate if making fixKind return a list of types is feasible and worth it

Currently fixKind returns only one type. Meaning the shrinker always chooses, say, a single particular type variable when fixing the kind of another type variable. It would be nice if it could look at all suitable type variables. This ticket is for investigating if it’s hard to arrange that and if its' beneficial to do so.
Extricated from https://input-output.atlassian.net/browse/PLT-874

Closing in favor of https://github.com/IntersectMBO/plutus/issues/6531.


Error when adding factor variables in baseline section

Contributing to FB NextGen MMM R script
Issue
Hello, I am having problem with the inclusion of factor/qualitative variables in the model.
At the moment, the inclusion of factor variables in the baseline section throws an error when running the models.
Am I doing something wrong? Could you provide guidance as to the inclusion of factor/qualitative variables in models?
Thx!
Steps to Reproduce
The following steps have been followed:

include one factor variables in baseline. Each factor variable is coded as a 0/1 binary variable
declare factor variables in "set_factorVarName"
dt_mod <- f.inputWrangling() runs smoothly and generates a (seemingly) correct dt_mod dataset. The factor variable has been stored as a "factor with 2 levels" variable.
run the model: model_output_collect <- f.robyn(...

Expected Behavior
Models are run smoothly
Actual Results
An error is displayed as: " Error in { : task 1 failed - "column(s) not found: Promo "
Estimation stops.
Environment
R version (R --version)

Hey, I assume Promo is your factor variable or how many factor vars do you have? can you share a screenshot of how the dt_mod looks like and the whole baseline/media/factor specification part in the execution script?

Hi. For the sake of privacy I would rather not show the names of the media variables, nor their values as they are real life values. I have, however, reproduced the same error by adding two factor variables to the demo data (de_simulated_data.csv).
Promo_1 and Promo_2 are two binary variables capturing periods in which each type of Promo was enabled (Value=1). Note that they could both be active at the same time.
Plese find below the baseline/media/factor specification part
activate_baseline <- T
set_baseVarName <- c("Promo_1", "Promo_2")
set_baseVarSign <- c("default", "default")
set_mediaVarName <- c("tv_S"	,"ooh_S",	"print_S"	,"facebook_I"	,"search_clicks_P")
set_mediaVarSign <- c("positive", "positive", "positive", "positive", "positive")
set_mediaSpendName <- c("tv_S"	,"ooh_S",	"print_S"	,"facebook_S"	,"search_S")
set_factorVarName <- c("Promo_1", "Promo_2")
And a screenshot of the dt_mod (along with the error message I get once I run the models)

Hey, thank you very much for pointing this out. Indeed there's a bug in the f.decomp function that causes failures when using factorial variables. I'll fix this in the next release. Sorry for the inconvenience!
Until then, there's a work-around by using the "holiday" variable in prophet. When you look at the holidays.csv, you'll see all holidays for given countries included. You can see that this data.table includes all holidays from 1995 -2044. You can manually add your promotions as holidays into this table for your country, then run the script using the prophet holiday variable (and remove promo1 & 2 from baseline). This way, both promo effects will be included into/ treated as holiday. I know it's maybe not ideal because you might want to have them separated. But for now it helps you get initial results.

let me know if you have other issues


[To do] Network - Show the total number of projects and organizations displayed

As a user landing on the Network module, I'd like to quickly see the total number of projects and organizations existing on the Network.
Acceptance criteria:

the total number of projects and organizations existing on the Network is shown
if a filter is selected, then the total number of filtered  projects and/or organizations is shown

JIRA #ORC-415


receive: memoize exemplar/TSDB clients

We call this on each Series() so memoize the creation of this slice.

this pr introduced a bug when multiple tenants are created at the same time, only partially would be memorized due to atomicity issue, fyi @GiedriusS we plan to revert this pr internally but worth taking a look, it prevents new tenants to be queriable but luckily no data loss


General: revisit back arrow functionality

I often hit the back button because I want to go to the last screen i looked at (ie, go from viz tab to subset tab). i know i don't need to do this, but using the back button in this way seems more intuitive than bouncing me entirely out of the analysis
Edit (Connor):
Per conversation with Danica, the following should be "backable" (pressing the back button should undo your last navigation)

[x] Changing analysis tabs (study details, subsetting, visualize, notes)
[x] Changing entities via the entity diagram
[x] Changing variables via the variable tree
[x] Going into/out of an existing visualization
[x] Going into/out of the new viz selector screen

@danicahelb I tested this, and it seems undoing analysis tab navigation is an easy fix; undoing navigation into and out of visualizations is not so easy. What are the specific reqs for this ticket?

Hey @chowington i'm not sure what you mean by "analysis tab navigation". did you mean undoing (pressing back on) browse & subset tab (not analysis tab?) navigation?
If I am in the browse & subset tab, I'd want the back arrow to either remove filters I just applied to the current variable or, if i hadn't applied filters but navigated between variables I would want it to take me to the last variable I looked at. It is very annoying that the back arrow currently completely bounces me out of my current analysis.
If I am clicking through tabs, I'd like the back arrow to bring me to the place i last visited in the tab. For example, if I am looking at "Study timepoint" on the browse & subset tab and then I clicked onto the notes tab, I'd want the back arrow to bring me back to the "study timepoint" variable on the browse & subset tab (I'm not sure if this is one of the things you indicated was difficult).
I guess in general, I don't want the back arrow to bounce me out of my analysis unless the last thing I was doing was looking at something else on the site (outside of my current analysis)
Maybe we should find a time to chat?

I've been testing Connor's branch.
And now reading this thread.
@danicahelb wrote

If I am in the browse & subset tab, I'd want the back arrow to either remove filters I just applied to the current variable

This is a major feature request that we can't just add to this ticket lightly (short version: filters have never been in the URL so it will not be trivial to implement this requested behaviour, because back/forward button browser history uses the URL)
What Connor has done already seems to avoid "backing out of the analysis entirely" which I think is a good step forward :-)

@bobular Thanks for looking over this issue! Danica and I had an earlier conversation about the ticket and we agreed with what you say here. The back button shouldn't have anything to do with adding or removing filters, only with navigation. 👍

Can someone add a succinct summary of how navigation should work? It's not clear to me, from reading the comments. For example, is the back/forward button only going to impact which tab is active?

To QA, check

All 5 back button cases in this ticket's first comment
In each of the 5 cases, the page does NOT jump all the way back up to the top when you use the back button to undo your last navigation
Using the browser back button should not make you lose any changes to the analysis you've made, like added filters, starred variables, or added visualizations

I was able to confirm that using the back button in the below cases allows for the page to change and yet not loose any data.


cluster setup: error logging podman into harbor

I've been seeing cluster setup fail sometimes when it logs podman into harbor:
START-BUNDLE: ./script.sh
*** START TEXT FILE: script.sh
echo 'Vzfj0ZbevxVWlICRNbvV' | podman login registry.neon.local --username root --password-stdin
*** END TEXT FILE
*** START TEXT FILE: __run.sh
#!/bin/sh

chmod 700 "script.sh"
./script.sh
*** END TEXT FILE
*** Uploading: /home/sysadmin/.neon/exec/1dd780d7-e083-4337-9b92-d574f9c0a265/__bundle.zip
START: sudo bash -c 'if [ -f "/home/sysadmin/.neon/upload/__bundle.zip-30df4e23-d68a-45ae-bacc-0ace1a92b38e" ] ; then rm "/home/sysadmin/.neon/upload/__bundle.zip-30df4e23-d68a-45ae-bacc-0ace1a92b38e" ; fi'
END [OK]
STDERR
    Error: authenticating creds for "registry.neon.local": pinging container registry registry.neon.local: invalid status code from registry 503 (Service Unavailable)
END [ERROR=125]
END-BUNDLE

I saw this once or twice a week or so ago but am seeing it more often now, but not for every cluster setup.
I see that the code retries for up to 10 minutes in the setup step and then we retry the entire cluster setup operation for two more times, so we're giving harbor 30 minutes or more to stabilize, without success.
I'm seeing a couple of distressed pods:

Here are the logs for the neon-sso-oauth2proxy pod:*
λ kubectl logs -n neon-system neon-sso-oauth2-proxy-68cc4844cc-k5wwx
[2023/05/11 16:53:30] [main.go:75] WARNING: You are using alpha configuration. The structure in this configuration file may change without notice. You MUST remove conflicting options from your existing configuration.
[2023/05/11 16:53:30] [provider.go:55] Performing OIDC Discovery...
[2023/05/11 16:53:30] [main.go:60] ERROR: Failed to initialise OAuth2 Proxy: error intiailising provider: could not create provider data: error building OIDC ProviderVerifier: could not get verifier builder: error while discovery OIDC configuration: failed to discover OIDC configuration: error performing request: Get "https://neon-sso.e4cd-a747-528e-1b11.neoncluster.io/.well-known/openid-configuration": EOF

The registry-harbor-harbor-core pod never has the chance to start:
λ kubectl logs -n neon-system registry-harbor-harbor-core-748745798b-4s7l9
Error from server (BadRequest): container "core" in pod "registry-harbor-harbor-core-748745798b-4s7l9" is waiting to start: ContainerCreating

...and here is the description for the registry-harbor-harbor-core pod:
λ kubectl describe pod -n neon-system registry-harbor-harbor-core-748745798b-4s7l9
Name:                 registry-harbor-harbor-core-748745798b-4s7l9
Namespace:            neon-system
Priority:             900006000
Priority Class Name:  neon-storage
Service Account:      default
Node:                 node/<IP_ADDRESS>
Start Time:           Thu, 11 May 2023 08:38:15 -0700
Labels:               core.goharbor.io/name=registry-harbor-harbor-core
                      core.goharbor.io/namespace=neon-system
                      goharbor.io/operator-controller=core
                      goharbor.io/operator-version=v1.3.0
                      pod-template-hash=748745798b
Annotations:          goharbor.io/warning: ⚠ This Resource is managed by *core* ⚠
                      registry-harbor-harbor-core.neon-system.configmap.core.goharbor.io/uuid: 6457da05-9e92-4f73-b796-803dfa20e96f
                      registry-harbor-harbor-core.neon-system.configmap.core.goharbor.io/version: 5000
                      registry-harbor-harbor-core.neon-system.secret.core.goharbor.io/uuid: 11e5eaa4-5c8a-4215-bac7-e339f0f8d995
                      registry-harbor-harbor-core.neon-system.secret.core.goharbor.io/version: 4999
                      sidecar.istio.io/inject: false
Status:               Pending
IP:
IPs:                  <none>
Controlled By:        ReplicaSet/registry-harbor-harbor-core-748745798b
Containers:
  core:
    Container ID:
    Image:          registry.neon.local/neonkube/harbor-core:v2.5.2
    Image ID:
    Port:           8080/TCP
    Host Port:      0/TCP
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Liveness:       http-get http://:http/api/v2.0/ping delay=0s timeout=1s period=90s #success=1 #failure=3
    Readiness:      http-get http://:http/api/v2.0/ping delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      WITH_CHARTMUSEUM:                          false
      AUTH_MODE:                                 db_auth
      DATABASE_TYPE:                             postgresql
      CORE_URL:                                  http://registry-harbor-harbor-core:80
      JOBSERVICE_URL:                            http://registry-harbor-harbor-jobservice
      WITH_TRIVY:                                false
      EXT_ENDPOINT:                              https://neon-registry.e4cd-a747-528e-1b11.neoncluster.io
      POSTGRESQL_PASSWORD:                       <set to the key 'postgresql-password' in secret 'registry'>  Optional: false
      POSTGRESQL_USERNAME:                       neon_service
      POSTGRESQL_DATABASE:                       harbor_core
      CORE_LOCAL_URL:                            http://registry-harbor-harbor-core:80
      REGISTRY_CONTROLLER_URL:                   http://registry-harbor-harbor-registryctl
      POSTGRESQL_HOST:                           neon-system-db.neon-system
      POSTGRESQL_PORT:                           5432
      HARBOR_ADMIN_PASSWORD:                     <set to the key 'secret' in secret 'registry'>  Optional: false
      WITH_NOTARY:                               false
      REGISTRY_URL:                              http://registry-harbor-harbor-registry
      TOKEN_SERVICE_URL:                         http://registry-harbor-harbor-core/service/token
      METRIC_ENABLE:                             false
      TRACE_ENABLED:                             true
      TRACE_SERVICE_NAME:                        harbor-core
      TRACE_OTEL_TIMEOUT:                        10
      TRACE_OTEL_COMPRESSION:                    false
      TRACE_OTEL_INSECURE:                       true
      TRACE_SAMPLE_RATE:                         1
      TRACE_NAMESPACE:
      TRACE_OTEL_ENDPOINT:                       grafana-agent-node.neon-monitor.svc.cluster.local:4318
      TRACE_OTEL_URL_PATH:                       /v1/traces
      LOG_LEVEL:                                 info
      CORE_SECRET:                               <set to the key 'secret' in secret 'registry-harbor-harbor-core-secret'>    Optional: false
      _REDIS_URL_CORE:                           <set to the key '_REDIS_URL_CORE' in secret 'registry-harbor-harbor-core'>  Optional: false
      PORTAL_URL:                                http://registry-harbor-harbor-portal
      REGISTRY_CREDENTIAL_USERNAME:              harbor_registry_user
      REGISTRY_CREDENTIAL_PASSWORD:              <set to the key 'secret' in secret 'registry-harbor-harbor-registry-basicauth'>  Optional: false
      JOBSERVICE_SECRET:                         <set to the key 'secret' in secret 'registry-harbor-harbor-jobservice-secret'>   Optional: false
      CSRF_KEY:                                  <set to the key 'key' in secret 'registry-harbor-harbor-core-csrf'>              Optional: false
      CONFIG_PATH:                               /etc/core/app.conf
      CFG_EXPIRATION:                            5
      RELOAD_KEY:                                true
      SYNC_QUOTA:                                true
      SYNC_REGISTRY:                             false
      INTERNAL_TLS_ENABLED:                      false
      PERMITTED_REGISTRY_TYPES_FOR_PROXY_CACHE:  docker-hub,harbor,azure-acr,aws-ecr,google-gcr,quay,docker-registry
      POSTGRESQL_MAX_IDLE_CONNS:                 50
      POSTGRESQL_MAX_OPEN_CONNS:                 1000
      POSTGRESQL_SSLMODE:                        disable
      _REDIS_URL_REG:                            <set to the key '_REDIS_URL_REG' in secret 'registry-harbor-harbor-core'>  Optional: false
    Mounts:
      /etc/core/app.conf from configuration (ro,path="app.conf")
      /etc/core/ca from ca-download (rw)
      /etc/core/key from encryption (ro,path="key")
      /etc/core/private_key.pem from token-service-private-key (ro,path="tls.key")
      /etc/core/token from psc (rw)
      /harbor_cust_cert from internal-certificates (rw)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  configuration:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      registry-harbor-harbor-core
    Optional:  false
  encryption:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  registry-harbor-harbor-core-encryptionkey
    Optional:    false
  psc:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  token-service-private-key:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  registry-harbor-harbor-core-tokencert
    Optional:    false
  ca-download:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  neon-cluster-certificate
    Optional:    false
  internal-certificates:
    Type:        EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:   <unset>
QoS Class:       BestEffort
Node-Selectors:  neonkube.io/neon-system.registry=true
Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 30s
                 node.kubernetes.io/unreachable:NoExecute op=Exists for 30s
Events:
  Type     Reason       Age                   From     Message
  ----     ------       ----                  ----     -------
  Warning  FailedMount  40m (x4 over 79m)     kubelet  Unable to attach or mount volumes: unmounted volumes=[ca-download], unattached volumes=[psc token-service-private-key ca-download internal-certificates configuration encryption]: timed out waiting for the condition
  Warning  FailedMount  10m (x7 over 60m)     kubelet  Unable to attach or mount volumes: unmounted volumes=[ca-download], unattached volumes=[token-service-private-key ca-download internal-certificates configuration encryption psc]: timed out waiting for the condition
  Warning  FailedMount  5m42s (x45 over 81m)  kubelet  MountVolume.SetUp failed for volume "ca-download" : secret "neon-cluster-certificate" not found

@marcusbooyah: I think you'll need to have a look at this.

never mind: I F5'd to complete the unit test and forgot that the test deletes the cluster when it's done, so this cluster isn't present any more.
I'm using the build machine right now to rebuild the node and desktop images and then I'll try recreating the problem.

I wonder if the underlying secret volume mount issue is happening because the secrets are being created in parallel with starting the Harbor deployments.
Could it be possible that sometimes the secrets don't exist when pods are started resulting in the secret mount failures (which apparently, the pod/deployment can't recover from)?

I think this may be due to a change I made to  KubernetesRetryHandler* a few weeks ago where I dramatically reduced the retry timeout.  I've  since changed that to be more configurable and restored the default time out to be much longer that what I changed it to but not as long as it was original (60min if I remember correctly).
I'm going to do a few hundred cluster deployments to torture test this.


Add custom type map

Added custom type map by passing in opts as second param to schema (i.e. {:custom-type-map {"DateTime" 'DateTime}} )

Hey @p14n ... this seems to be a feature that is clearly missing.
What do you think of something similar to the approach that was taken on the Datomic interface? See https://github.com/hodur-org/hodur-datomic-schema#scalar-types-and-finer-grained-control

Hey @luchiniatwork !
I also need custom scalar support. I could work on this feature if we can agree on the interface.
How about this?
  (deftest test-custom-scalars
           (let [s (schema->lacinia '[^{:lacinia/tag true}
                                      default

                                      ^{:lacinia/scalar true
                                        :lacinia/parse :date-time-parser
                                        :lacinia/serialize :date-time-serializer}
                                      DateTime

                                      Person
                                      [^ID id
                                       ^DateTime dob]])]

             (is (= '{:scalars
                      {:DateTime
                       {:parse :date-time-parser
                        :serialize :date-time-serializer}}
                      :objects
                      {:Person
                       {:fields
                        {:id {:type (non-null ID)}
                         :dob {:type (non-null :DateTime)}}}
                       }
                      }
                    s))))


Bugs

Why don't check your code carefully, there so many bugs............

Can you show me what kind of bugs you get?

okok

in cvcore/tools/vaild_tools.py about 31-th row, best_metric always is None, so it can't directly print.
in cvcore/tools/multi_rib_dataset.py about 72-nd row, it's better add num_workers=cfg.SYSTEM.NUM_WORKERS for accelerate.
Directly put downloaded data into data cannot run in my computer, so i use absolute address(chinese, may not be accurate).
It's dump in second epoch, i'm trying to fix it.

It's the fourth problem as mentiond above

for 3, I think that there is some confuse in our document, the data should be outside cvcore, the cvcore/data is for dataloader and I put data outside cvcore for dataset itself (the link in my config is data/train/etc)
For 1, I will check why it dont print the best_metric and for 4 I will check the code again, it seems like the bug in 4 is not happend in every run since you can complete 1 epochs without any error

okok, better github work can get more cite.

One more, the file name of downloaded data is different from default name in yaml file.

One more, there is a bug in 27-th row of cvcore/tools/vaild_tool.py. I have refine it by myself.


implementing free plan functionality

What's the best way to have a free plan included alongside paid-for plans?
I tried:
a) Having two paid-for plans in cashier_plans.php and only if the user selected one of those I would switch the user from the independent, self-managed free "plan" to those managed by the package and eventually mollie. The issue with this approach was that when the user subscribed to a paid subscription and paid for it, but then cancel that subscription to go back to the free plan, the credit function did not show that the user had any credit left. (when I would have expected that the prorated remaining amount should be avaiable for implementing refund logic). Is this expected behavior or a bug? Or maybe there is a step I may have missed out?
b) (to circumvent the above) I added an additional plan in cashier_plans.php that costs 0.0 and now the credit problem went away. I can comfortably swap plans and then cancel and the remaining credit is available for the user. The issue here though is that the user has to first subscribe to the Free plan AND make the first-payment to mollie, which is an undesirable constraint to impose. Is that correct behavior? Looking at the Billable Trait, it seems that unless there is a mollie_mandate_id the user has to make a firstpayment.
I guess this is such a common matter that I probably must have missed the crucial details.
I'd appreciate it if anyone had any suggestions or pointers on the best way to go about this.

You should go with option a).
Did you use $subscription->cancel()? If so, the subscription will be active until the end of the current billing cycle (what was paid for). So that's by design.

Alternatively, using $subscription->cancelAt(now()) will reimburse for the time left on the subscription.

Thanks for your response.
I tried cancel() and it behaves as you designed it, it correctly goes into the grace period, although that implies the current subscription is not really cancelled. It is the renewal for the next cycle that is cancelled. I have not found a way to obtain the amount I would owe to the user if I was to refund the remaining of the current cycle.
Indeed, I also tried cancelAt(now()) with same result, expect there is no grace period being entered.
To reproduce the issue described I do the following simple steps:

subscribe to a plan that costs XX euro.
complete successfully first payment
cancel the subscription
invoking $user->hasCredit('EUR') is false

I was expecting that the user will be allocated a prorated credit of XX euro (in my tests since I cancelled immediately the whole amount should be the credit), which my plan was to enable the user to then request a refund for, in a subsequent step.
I'm not sure if it's just me experiencing this or this is also normal behavior.

Ok, so the customer has paid for the subscription but decides he wants out immediately, right? Usually he then cancels the subscription. Then sees that it is canceled, but he is getting what he paid for: the rest of the current billing cycle.
In some cases customers like these reach out to support, asking for 1) a refund and 2) canceling the subscription immediately.

refunds are not supported in Cashier yet. You can perform a refund via the Laravel Mollie client (comes with Cashier) or via Mollie's dashboard.
as discussed. Use cancelAt(now()).

Regarding point 2, I could think of a third parameter ($reimburse = false) to credit for unused time. But if I understand the/your scenario correctly, this would only be a intermediate step towards a refund.

The problem is not the refund logic (this scenario above is just one use case, which I mention so you know the context).
Lets say that a user cancels the subscription at any point during the cycle, not just immediately. I was hopding $user->credit() returns me the amount I would have to pay the user if I wanted to refund him, calculated proportionally to the amount of time left in the cycle. Currently that function does not tell me anything, because it returns false.
Maybe I am doing it all wrong? :)
btw: thanks immensely for your responses and the work you put into this and helping us here.

Hi @sigmoidal,
Thanks for the ❤ , really appreciated. And always good to learn about real life use cases :).
Perhaps this is helpful to you?
https://github.com/laravel/cashier-mollie/blob/899d661ea1d730fd1f15a5551cc27ddb1b338901/src/Subscription.php#L148:L187

So you could use
$reimburse_amount = $subscription->cycle_left * $plan_costs;

that's really helpful, thanks for pointing me at it!!

No problem. Enjoy! 🎉

This was really helpful. I believe that would be good having explanation on how to use a free plan in the documentation. Also, I wish there was a documentation on Vuetify or something similar, rather than a plain Git Readme that is a bit hard to read and not complete. People could contribute to it as well.
I believe this is one of the main reason people are chosing Stripe and Paddle over Mollie (for Cashier), which is a shame because Mollie is definitely better IMO!


Pages V1: Static UI  (Done)

Static UI: Landing, Register, Login, Forget Password, Items, Private Items (Done)

Here's the localhost screen recording: https://www.loom.com/share/dfab7c1449c04e698057a828f717132b?sid=c282f548-a329-482e-aeff-f5a64e41581d


Remove open responses

Since 5cf680f4, all* prisons have used only canned responses. Open responses are not used, and can be removed.
* Well, almost. They were supposed to, but Foston Hall was omitted from that commit. So this also fixes that problem.

:boom: :+1:

:sunglasses: :rocket:


Mobile App: Add support for async remove and unload events

Fixes #22044

@balloob What were you thinking would happen during async_unload_entry?

unload_entry needs to undo all the work that load does, so things like:

unregister webhook
forward unload to (binary) sensor so the entities get removed
disconnect from dispatcher signals

@balloob I didn't unregister webhooks in async_unload_entry because of the whole deleted IDs thing. We don't want mobile apps to think that the webhook is dead forever, which we would be doing if we returned a 410 to them.

Unload should unload, make it return a 404. Otherwise you can't reload for example.
Also missing tests

Status?

Going to have to rewrite this when #23033 gets merged, so will close for now.


normal logic

so im in ggm and with bk moves random all and normal logic its saying i can get the notes on the green hill but i dont know what the trick i need to do is to get up without talon trot was wondering if you knew

Hi rainbowkinggleeock,
This isn't the best place to post logic issues. Logic issues is better posted at the Archipelago Discord -> Future-game-design -> Banjo-Tooie where more people can assist you with logic stuff sooner.
You mean the green pile? You can use the Speed Shoes to access them right now as you are in Talon Trot mode while wearing the shoes.
Again, any further logic questions, head to the discord.
jjjj12212

ah okay thanks and ill make sure to post any more questions in the discord also yeah i actually forgot the shoes were there even though i had used them a couple days later lol


Add updatable attribute to @KomapperColumn

Add new updatable flag to the @KomapperColumn annotation. Columns are updatable by default; if updatable is set to false, the column is excluded from generated update statements similar to idProperties() and createdAtProperty().
Background. The primary intended use case is the implementation of auditing fields, specifically the "created by" field that should behave similarly to the "created at" field already supported by Komapper.
Additional context: https://github.com/komapper/komapper/discussions/1396.
TODOs:

[x] KDocs
[x] Tests

Thank you very much.
This is an excellent improvement!

@nakamura-to Thank you for merging this change! If you want to, I can also add a note about this feature in the komapper-docs repo (although I can only cover English language).

@GreyTeardrop Thank you for the offer! Yes, we would appreciate it if you could add a note about this feature in the Komapper docs. Your help with the English documentation is invaluable.
Please refer to the following page for guidance on writing documentation: https://github.com/komapper/komapper-docs/blob/main/CONTRIBUTING.md

I've added a small note about this feature in https://github.com/komapper/komapper-docs/pull/32; can later work on adding a few usages to komapper-examples repo.


Update Composer dependencies (2022-03-25-00-06)

Visual regression test passed!
View the visual regression test report


[Bug] Slow long strip manga

Device information

Tachiyomi version: ?
Android phone & version: OnePlus 5T 6GB RAM, Oxygen OS 10.0.0 / Android 10

Steps to reproduce

Download any manga that is read in long strip format and has long individual images
Read it and scroll

Expected behavior
There should be no lag.
Actual behavior
The longer the individual images, the more it lags. (Sometimes the entire chapter is one long image)
Proposal
I propose that images with a width-height ratio larger than (arbitrary) 1:4 get automatically split into several images (at storage or at loading). This way the reader only needs to load and draw the current and surrounding parts, not the whole chapter.
Maybe an additional side effect of the proposal: added break points I can return to when exiting and reentering the reader.

I don't know if i plan to auto split images as thats not trivial.  An intermediate fix would be to report the chapter to MangaDex and ask them to  split the image into more than one.
As for breakpoints that gets even more into the weeds of the image processing and i would rather auto split the image lol.    I'll leave this open if someone or I want to look at it in the eventual 3.x release

Splitting the images itself is easy.
I didn't manage to decouple the number of images from the number of pages, when I tried splitting pages in the WebtoonAdapter.
To know the total number of images in a chapter, I need to load a whole chapter.
The alternative would be splitting earlier, but then we would not know wether we are using the Webtoon view. Splitting in any other view would be bad.
I don't think this can be done safely and efficiently without a major overhaul of eu.kanade.tachiyomi.ui.reader and related packages.

check on 2.1.5 this might be fixed some

check on 2.1.5 this might be fixed some

I have long stopped having this issue.


Separate auth entirely from Laravel's Auth scaffolding

Make auth process separate from Laravel's Auth

do not change the default views and controllers, just extend them

Rephrased: we should let the programmer make:auth and have a different auth entirely, that he can use for the front-end, if need be. This is not possible right now, because we overwrite the default Laravel auth views.
Changes that need to happen:

views: instead of overwriting the Laravel views, we should publish them in views/vendor/backpack/base;
controllers: instead of using the default laravel views, we should use the views above;
controllers: instead of overwriting the AuthController and PasswordController functions just for changing the views, we should use Laravel's $loginView variables (and others like it);

That way, they will be completely separate.

Fixed in ed080e0151555eecadc40efbaf439ebdead70d1b (v0.6.0).


[CI][Java] Add Spark integration tests to "java" group in Crossbow tasks

Describe the enhancement requested
GH-40462 broke Spark integration tests. (See also:
Component(s)
Continuous Integration, Java

Issue resolved by pull request 41086
https://github.com/apache/arrow/pull/41086


Type analysis of sum branches

For example r1 / r2 in a typed context cannot be typed because we don't have name for the sum type. However r1 > make_r1 / r2 > make_r2 can be typed but the return types of make_r1 and make_r2 must be the same.

This is clearly harder than I first thought because we need to compare two syntax::ast::Ty which is not easy at all.

We completely removed this analysis due to #80 but it leads to awful errors. I want to re-introduce it, but contrarily to what is said in #73, we take the approach of considering any Rust type as equals and thus, only comparing Oak types.

How about letting the Rust compiler compare types like this
fn _unused_fn_() {
    let mut same_type = make_r1(unreachable!());
    same_type = make_r2(unreachable!());
}

I suppose getting unclear error messages from the compiler will be bad, but the right solution is adding custom error messages to the compiler.

It's not a bad idea. However, how can you ensure that the Rust compiler will try this first, and if it fails, won't try the other rules and generate even more errors? It is an interesting hack and I need to think it over but for now, let's suppose two Rust types are equals and let the Rust compiler generate messages if they are not!

and if it fails, won't try the other rules and generate even more errors?

Is that necessarily a bad things? Assuming it is bad, we can add the right attributes to the compiler that would ask it to produce truly fatal errors, in addition to setting custom error messages.
There's a problem with my exact example. Functions such as make_r1 can be generic, which means they can return ! given an argument of type !*. We would need to generate an expression with r1's type, which is fed to make_r1.
* The type of unreachable!() is !.


Flow Docs Updates

Problem
Update needed on Verification Storage recommendations and Execution
Steps to Reproduce

Change candidate 8 under Step 0 to candidate 9

Upload your Public Keys

Can we adjust the wording to say, "(you can pick any name, but please make sure to do so as it helps us immensely to keep track of the most recent keys you've sent and would like us to include in the bootstrapping process)"

Start your Flow Node

Add end parenthesis "(via Discord you will need to fetch the genesis info), updated..."

verification nodes and they have gone slightly over 2GB. So, if our docs still stay 2GB for verification, we should revise it to 4GB at least → this requirement needs to be changed:
-> https://onflow.readme.io/docs/setting-up-a-node#hardware-requirements

we are also missing instructions w.r.t execution node. The PULL token for the execution node is different than other nodes and operators running an execution node should be pulling using that token ->  it is candidate-9-execution
cc @vishalchangrani for 👀

Acceptance Criteria
NA
Context
<what are you currently working on that this is blocking?>

@caseyturnerarrington Stale?

Yeah I don't think this is valid anymore. Closing.

(I actually can't close. @10thfloor can you close please?)


Added support for 'cut' and 'delete' via contextmenu

Hi Stephen,
it's me again. I have yet another pull request for 'Add-Clear'.
Today our tester discovered that the clear button in input fields of our application does not disappear when he clears an input fields by selecting 'cut' or 'delete' in the context menu of said field:

Since we are using your plugin to add the clear button, I have added support for this particular use case.
This is primarily done by utilizing the 'input' event which of course is not support by the gold old Internet Explorer 8. To ensure that the plugin is still working in browsers which do not support 'input', I have kept the old 'keyup' method which is removed in modern browsers when the 'input' callback is called the first time. I also added a callback for the 'cut' event which is also removed in the 'input' callback. So clearing the input field via 'cut' also works in older browers. Unfortunately I'm not able to support the 'delete' action without the 'input' event.
Please consider merging my commits. Thanks in advance.
Best regards,
Christian

Thanks for your contribution. I'll create a new version later today.

By the way, I did not update the addclear.min.js file because I do not know what your preferred minifier is.


programmatic control over certificate validation

I'm trying to use native-tls in a non-HTTP scenario with self-signed certificates building a mutually authenticated peer to peer connection. All I want is essentially a Diffie-Hellman key exchange and an encrypted channel. During the handshake I'd like to avoid the usual PKI trust chain and let peers decide programatically if they trust the certificate of the other party.
To achieve this, the usual way is to provide a hook for a callback function where certificate of the peer can be validated. In Java you can set a custom TrustManager while initializing your SslContext. Also, crate rustls nicely supports with ServerCertVerifier::verify_server_cert(). I'd like to have the same programatic control over certificate validation using native-tls + tokio-tls without blocking, but unfortunately this library doesn't seem to support this so far.
Would it be hard to add such a callback feature also to native-tls?

I think our use case is different from pinning, we'd like to allow any IP/host for any certificate.
In our P2P use case we initiate a connection with an expected public key and we'd like to make sure we're handshaking with that specific public key regardless of network details of the peer.

That's what certificate pinning is - you pin to a single (or set of) specific identity.

Sorry, seems I'm not too familiar with this terminology yet. Thank you for clarifying, pinning is what we'd need then.
Note: we don't know the certificate in advance, only the public key, I hope this is not limiting a possible solution.
Ok, would pinning also be technically hard to be included?

In many cases we do not even know the public key itself, just its hash (github.com/multiformats/multihash) in a p2p network connection. So I can imagine a callback which we parametrise with a hash before the handshake and then below the hood the handshake checks if the public key is hashed to that value.

Yeah that's definitely implementable.

Example:
fn callback(cert) -> Result<(), Error> {
    match default_verifier(&cert) {
        Ok(()) => Ok(()),
        Err(InvalidCert) => Err(InvalidCert),
        Err(NotTrusted) => {
            let fingerprint = hash(&cert);

            let keys = read("~/.ssh/known_hosts");
            if keys.contain(&fingerprint)  { return Ok(()); }

            println!("Do you trust this entity? [Y/n]");
            println!("Fingerprint: {}", &fingerprint);
            let response = prompt_yn();
            if response { Ok(()) } else { Err(NotTrusted) }
        }
    }
}

If exposing an entire cert is difficult, can you provide a hash of cert to callbacks as a starter?

I'd also find this useful. My users want to configure the fingerprint of a trusted certificate, and I'd want to validate if a remote certificate matches the fingerprint or not.


Cannot install alpha005

I can install alpha004 into my class library just fine. But updating to alpha005, or installing it fresh, always yields this error:

update-package : Missing dependency information for package: StyleCop.Analyzers
At line:1 char:1

update-package StyleCop.Analyzers -version 1.0.0-alpha005

  + CategoryInfo          : NotSpecified: (:) [Update-Package], Exception
  + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.UpdatePackageCommand

I'm using a prerelease of VS2015. Is anyone else seeing this? Is there perhaps a flaw in the StyleCop.Analyzers nuspec file?

What package source are you using? I'm using nuget.org, and not api.nuget.org.

I'm using api.nuget.org

Interestingly, it started working after I manually removed alpha004 by removing all traces of it from the project file and packages.config file myself. Hmm.. not sure what to make of it.

Weird. Should we assume it's a bug in NuGet that will work itself out?
Also you still have a message from me in Gitter. :wink:

Quite possibly. I'll file a bug over at http://github.com/nuget/home
I'll visit gitter.

Can this issue be closed @AArnott?

I'm going to assume it's been fixed since this is the only report, and all relevant components (NuGet, Visual Studio, and this project) have received numerous improvements since.


Update manifests/e/Eugeny/Tabby/1.0.165/Eugeny.Tabby.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels


Call persistedQueryLoader even when query was passed

Closes #1370.
This partially reverses #790. That PR was supposed to fix the support of Automatic persisted queries, but it has only partially done so. By adding the $query === null condition, it contradicts the flow proposed by Apollo and @cwdt in their original PR:
3. If the backend doesn't recognize the hash, it will ask the client to send the hash and the query text so it can store them mapped together for future lookups. During this request, the backend will also fulfill the data request.

The important part here is so it can store them mapped together for future lookups - this is currently not possible because persistedQueryLoader is not called when both queryId and query were passed in a request.
Since webonyx/graphql-php parses Apollo-style automatic persisted query IDs (see https://github.com/webonyx/graphql-php/blob/master/src/Server/OperationParams.php#L123), it makes sense to allow them to be implemented in userland.
Although this is technically a fix of the previous PR, I've marked it as a "change" in the changelog because it might be a breaking change for some.

Makes sense, thanks for the fix. I am releasing this as a bug fix, as the previous logic never really worked.


Failure running the Benchmark Experiment "python benchmarks/run.py -e ycb_experiments"

Describe the bug
Gets "ModuleNotFoundError: No module named 'tbp'"
The other from statements also fail

Hi @rollynoel,
Because you are observing No module named 'tbp', to me that means that the project is not setup on your machine.
Are you running this command with tbp.monty conda environment active (conda activate tbp.monty)?

Another issue (which doesn't look like the first problem, given the error message) is that you need to specify the name of an experiment config, not the name of the file containing all the configs. So you should do something like -e base_config_10distinctobj_dist_agent. All the config names in ycb_experiments.py are listed at the bottom of that file. You can also go to our benchmark results tables and copy the experiment names from the first column. If you want to run multiple experiments in succession you can list them out after the -e argument.


[feat] Add favicon support

Maybe we can use it -> https://github.com/jantimon/favicons-webpack-plugin

maybe we can use "this"


allow changing of tag

I have a need to convert some html from one tag to another (in my case, a <div> to a <p>). I've added the functionality here, as well as a test.

I've needed this more than once and would love to see this feature merged in.


Angular 2 integration with rxjs/observables

Hi Feathers team,
Is it possible to add an Angular 2 (final) integration guide where Obserables/rxjs is used?
Keep up the good work!
Best regards
Patrick

This is unfortunately not anything the core team can take on at the moment since nobody is using Angular 2. I know @harangue has done some work with Angular 2 (and also wrote the original Angular guide). For RxJS integration definitely have a look at feathers-reactive.

@patrickpereira Hey Patrick, if there are any specific questions you have, I'd be happy to help out. For the most part, I think if you understand Angular 2 service architecture well Feathers should hopefully fit in quite naturally.

I wrote a blog post about that some time ago: https://berndsgn.ch/angular2-and-feathersjs/
Hope it helps.

@mastertinner Cool!  I added a link to your blog post to the tutorials and examples section of the Built with Feathers page.  Thank you!

I also added a note with a link to the blog post to the Angular2 Frameworks tutorial.  I'm going to close this, now.  Please reopen if you feel it's needed, @patrickpereira.

Awesome! Thanks, @marshallswain!


Cannot parse http://www.sportculture.be/php-bounce/eml/hotmailbounce.txt

 ***warning: Strange date format [Wed, 30 Jun 10 10:38:06 -0700] at lib/Sisimai/Time.pm line 412.
Use of uninitialized value $datestring in pattern match (m//) at lib/Sisimai/Data.pm line 222.

and https://github.com/romley/xebura/blob/master/application/bounce/eml/fbl-hotmail.txt

Fixed at commit 263f9c306505793d3ea45971f2322f5739ca193f