DFPlayer with no sound if compiled under Arduino IDE 1.6.10

Somehow the same sketches which worked all right before fail to play sounds if compiled with the 1.6.10 version, although compilation passes. I checked, not a hardware problem. With 1.6.4 it still works fine,

The first thing I'd suggest to narrow down the cause is to downgrade to Arduino AVR Boards 1.6.11:

Tools > Board > Boards Manager
Click on Arduino AVR Boards
Select 1.6.11 from the "Select version" menu.
Click "Install"
Click "Close"
Upload LightSaberOS to your saber and check if the sound works

Arduino AVR Boards 1.6.12 upgraded to a new compiler version so there's a possibility that was the cause of the issue. By downgrading to Arduino AVR Boards 1.6.11 you will go back to the previous compiler version, which is the version included with Arduino IDE 1.6.4. You can easily reinstall 1.6.12 by repeating the steps I listed above except select 1.6.12 instead of 1.6.11.

Hi per1234,
Thanks for the suggestion. I'm not sure if we talk about the same thing, I experienced the problems with the Arduino IDE version 1.6.10. So according to what your write the compiler used in this version should be still the same as in the 1.6.4. Or do I misunderstand something?

Ever since the introduction of Boards Manager in Arduino IDE 1.6.2 there are two different version numbers you have to take into consideration when you encounter a bug that occurs in one IDE installation but not another. The Ardino IDE version and the platform version. These are two different, unrelated numbers. I'm talking about platform version, you're thinking IDE version. The platform used for LightSaberOS is Arduino AVR Boards. Each Arduino IDE version includes the latest version of Arduino AVR Boards at the time of release. It's theoretically possible for you to install Arduino AVR Boards 1.6.12 on Arduino IDE 1.6.4, though the Arduino developers aren't very good at considering backwards compatibility so this might not work in practice. Arduino IDE 1.6.10 installs with Arduino AVR Boards 1.6.12 so I'm assuming that's the version that you experienced the problem with. As for which Arduino AVR Boards version is running on your Arduino IDE 1.6.4, I'm not sure, you'd have to open Tools > Board > Boards Manager to check. To further complicate things, when you install a different version of Arduino AVR Boards in one Arduino IDE version it will usually cause the Arduino AVR Boards version for any other Arduino IDE version to also be updated because the Boards Manager updates are installed to a folder, Arduino15 that all Arduino IDE versions share. However, the location of the Arduino15 folder on Windows changed in Arduino IDE 1.6.6 so if you're using Windows installing a different Arduino AVR Boards version will not affect Arduino IDE 1.6.4. The other exception is if you are running an Arduino IDE version in portable mode(by creating a folder named portable inside the installation folder). In portable mode the Boards Manager updates will be installed to the portable folder and will only affect that Arduino IDE installation.
The key to making this issue easier to look into is to narrow down the possible differences between the two IDE versions is that could cause LightSaberOS to work in one but not in another. These include:

LightSaberOS code: If you are using the identical version of LightSaberOS in both version then we know that a change in the LightSaberOS code is not the cause.
LightSaverOS bundled libraries: If you're using the identical versions of the libraries bundled with LightSaberOS then we know a change in one of those libraries is not the cause.
Arduino IDE bundled libraries
Arduino AVR Boards bundled libraries
Arduino AVR Boards core
Arduino IDE/arduino-builder
avr-gcc compiler: The same version of avr-gcc(4.8.1-arduino5) has been included with all versions of Arduino AVR Boards from 1.6.7(included with Arduino IDE 1.6.4) to Arduino AVR Boards 1.6.11(included with Arduino IDE 1.6.9) but in Arduino AVR Boards 1.6.12(included with Arduino IDE 1.6.10) the avr-gcc compiler was updated to 4.9.2-atmel3.5.3-arduino2.

That's a pretty long list of potential causes of the issue and it makes the job of fixing it seem very large but the key is to just systematically eliminate each possibility. If the issue goes away when you use Arduino IDE 1.6.10 with Arduino AVR Boards 1.6.11 then we know that changes in the Arduino IDE did not cause the issue and that it was most likely caused by the new compiler version, changes in the core, or in an Arduino AVR Boards bundled library that LightSaberOS uses, the cause will still not be known but the list of possibilities just got way shorter.

Wow, I learned from you a lot sir! I really feel indebted, not least because your suggestion really solved the issue. This we need to warn users about in the readme.

Glad I was able to help! It's a confusion a lot of people have right now. They think that Arduino IDE 1.6.10 was a bad release when actually there are no new bugs in 1.6.10, the problems are all caused by Arduino AVR Boards 1.6.12, which can affect any IDE version it's installed in.
What was the solution you found?

Like you described I installed the other AVR boards version 1.6.11 and then my sketches worked as before. I.e. I had a general issue with the DFPlayer lib not recognised by the 1.6.12.
I think it is confusing because the versioning scheme is very similar. At least they could have selected a slightly different versioning.
BTW, does this version have to do something with the boards.txt file in the IDE installation? I have an issue with editing this file (just filed a question on the Arduino Forum).

I.e. I had a general issue with the DFPlayer lib not recognised by the 1.6.12.

Not recognised or just not working correctly?

the versioning scheme is very similar.

The reason the versions are close is because before the Boards Manager feature was added there was no separate version so the first version of Arduino AVR Boards released had the same version as the IDE it was split off from. They've drifted apart because Boards Manager allows Arduino to release new versions of Arduino AVR Boards separately from the IDE releases if they fix bugs or add features. It's certainly confusing though.

BTW, does this version have to do something with the boards.txt file in the IDE installation?

That's more likely to be an IDE issue than an Arduino AVR Boards issue. I've responded to your post on the forum.


Overhaul of GPIO module & adjusted Serial module accordingly.

Renamed GPIO and RTC_IO register field to strip common prefix.
Fixed bugs in GPIO
Simplified GPIO code

TODO:

Add support for routing
Add support for additional configuration (e.g. pullup/down, drive strength, etc.)

This depends on https://github.com/esp-rs/esp32/pull/34 and it builds on #34.
Addresses issue #35 and #19

Changed this to WIP so I can include more changes in one go.

@MabezDev and @chocol4te I think this is in pretty good shape now. Your review and feedback is most welcome. (Todo's are intterrupt handling and perhaps some more functionality on the RTC_MUX.)

Just some really small comment/formatting changes suggested, looks really solid and can't think of anything to change in the implementation!

Thanks, always nice to put the dots on the i's and cross the t's. :-)

In principle, I think this is ready for merge: https://github.com/esp-rs/esp32/pull/34 has been merged as well as #34. Also the problems @chocol4te was having are solved (https://github.com/esp-rs/esp32-hal/pull/26#issuecomment-648833861).
However, I could still add interrupt support and more extensive support for the RTC IO mux. I will be working on this over the next day/weekend; I can merge it in this PR or can make a new one.

@arjanmels imho it might be slightly easier to merge this and have separate PRs for the additional functionality, but I’m also happy to just rebase against this branch when I finish up the I2C work :)


Change return type of Receiver::recv and from_* to Box

May require some unsafe shenanigans in the implementation, but it would probably be worth it.

References:

std::mem
std::ptr
Rustnomicon

If I can't make this work, I could change Payload to be a typedef instead of a newtype.

Actually, returning anything but a Vec requires re-allocating anyway (e.g. Vec::to_boxed_slice(self)).

I decided to return opaque structs (BoxPayload, BoxEncoded) instead, with a Deref implementation for each.


Update pt-BR➡pt in a couple of other places

Sorry if I got the wrong end of the stick, but I noticed a few other places where I think pt-BR should be changed to pt.

Thanks, good catch!


Copy file permissions

The Copy function now copies permissions from the source file to the destination file.
Addresses #1

Codecov Report

Merging #4 into master will decrease coverage by 33.33%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
- Coverage     100%   66.66%   -33.34%
===========================================
  Files           1        1
  Lines           8       12        +4
===========================================
  Hits            8        8
- Misses          0        2        +2
- Partials        0        2        +2

Impacted Files
Coverage Δ

decent_copy.go
66.66% <33.33%> (-33.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1e2ae...f20e255. Read the comment docs.

Nice @djaglowski !!
thank u

@djaglowski merged!
thanksss @djaglowski


Initialize checked checkbox on selectMode:'multi'

How can I initialize checked row on my component?

In HTML
(userRowSelect)="handleGridSelected($event)"
inside the ng2-table tag and
Component
gridSelected: any;
handleGridSelected(event) {
this.gridSelected = event.selected;
console.log(this.gridSelected);
}
This will show all the information about the currently selected grid.

@riyan10dec Did you ever find out a solution?


secrets "mlpipeline-minio-artifact" not found

Checks

[X] I have searched the existing issues.
[X] This issue is NOT security related. (Please disclose responsibly)
[X] This issue is NOT specific to the CLI. (Please open a CLI issue)

deployKF Version
0.1.5
Kubernetes Distribution
v1.26.6+k3s1
Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", Go
Version:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.6+k3s1", GitCommit:"3b1919b0d55811707bd1168f0abf11cccc656c26", GitTreeState:"clean", BuildDate:"2023-06-26T17:51:14Z
", GoVersion:"go1.19.10", Compiler:"gc", Platform:"linux/amd64"}

Description
My kfpv2 pipeline failed with this log:
I0808 09:34:29.856606      69 cache.go:116] Connecting to cache endpoint ml-pipeline.kubeflow.svc.cluster.local:8887
I0808 09:34:30.213371      69 launcher_v2.go:151] publish success.
F0808 09:34:30.213465      69 main.go:49] failed to execute component: failed to fetch non default buckets: failed to open bucket for output artifact "train_path" with uri "minio://kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder": Failed to open bucket "kubeflow-pipelines": Failed to get minio credential: Failed to get MinIO credential from secret name="mlpipeline-minio-artifact" namespace="team-1-prod": secrets "mlpipeline-minio-artifact" not found
time="2024-08-08T09:34:30.824Z" level=info msg="sub-process exited" argo=true error="<nil>"
Error: exit status 1
time="2024-08-08T09:34:31.765Z" level=info msg="sub-process exited" argo=true error="<nil>"
Error: exit status 1

And I saw this config in version 0.1.3:
      ## apply fixes to make MinIO work with KFP v2
      ##  - these fixes are needed because KFP v2 uses hard-coded configs for MinIO
      ##    https://github.com/kubeflow/pipelines/issues/9689
      ##  - if true:
      ##     - the name of all cloned object store auth secrets in profiles becomes "mlpipeline-minio-artifact"
      ##     - the key names used in generated minio auth secrets becomes "accesskey" and "secretkey"
      ##     - the 'kfp-launcher' containers in workflow pods are patched at runtime to set:
      ##        - `MINIO_SERVICE_SERVICE_HOST` and `MINIO_SERVICE_SERVICE_PORT`
      ##        - `ML_PIPELINE_SERVICE_HOST` and `ML_PIPELINE_SERVICE_PORT_GRPC`
      ##     - the value of `kubeflow_tools.pipelines.objectStore.useExternal` must be false
      ##
      minioFix: false

The issue referenced is still opened but the config to fix it no longer exists in version 0.1.5. It looks like the issue was not fixed, but the config is gone. Did deployKF fixed it by itself ? If so how did you fixed it and can you give a guess why I am still facing this issue ? Thank you in advance for your support.
Relevant Logs
The downstream component is failed to authenticate to Minio but the upstream that produced the dataset still successfully uploaded the artifacts to the same Minio:
I0808 09:25:14.221036      55 cache.go:116] Connecting to cache endpoint ml-pipeline.kubeflow.svc.cluster.local:8887
Added `minio-local` successfully.
`minio-local/dev/labels/NEW_1153_0567.txt` -> `/minio/kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder/dev/labels/NEW_1153_0567.txt`
`minio-local/dev/images/NEW_1153_0567.jpg` -> `/minio/kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder/dev/images/NEW_1153_0567.jpg`
Total: 218.04 KiB, Transferred: 218.04 KiB, Speed: 331.10 KiB/s
I0808 09:25:20.038687      55 launcher_v2.go:680] output metadata file does not exist in /tmp/kfp_outputs/output_metadata.json
I0808 09:25:20.376641      55 object_store.go:258] uploadFile(localFilePath="/minio/kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder/dev/images/NEW_1153_0567.jpg", blobFilePath="get-data/dataset_folder/dev/images/NEW_1153_0567.jpg")
I0808 09:25:20.385197      55 object_store.go:258] uploadFile(localFilePath="/minio/kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder/dev/labels/NEW_1153_0567.txt", blobFilePath="get-data/dataset_folder/dev/labels/NEW_1153_0567.txt")
I0808 09:25:21.391699      55 launcher_v2.go:151] publish success.

When I tried to workaround by creating the missing secret, I get this error:
I0809 01:38:26.139478      68 cache.go:116] Connecting to cache endpoint ml-pipeline.kubeflow.svc.cluster.local:8887
I0809 01:38:27.305366      68 object_store.go:314] Cannot detect minio-service in the same namespace, default to minio-service.kubeflow:9000 as MinIO endpoint.
I0809 01:38:28.345807      68 launcher_v2.go:151] publish success.
F0809 01:38:28.345921      68 main.go:49] failed to execute component: failed to download input artifact "train_path" from remote storage URI "minio://kubeflow-pipelines/v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder": failed to list objects in remote storage "v2/artifacts/team-1-prod/trainingadspipeline/667d6ccb-5da0-45c8-b0e0-a0ae76b2b563/get-data/dataset_folder": blob (code=Unknown): NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
time="2024-08-09T01:38:29.114Z" level=info msg="sub-process exited" argo=true error="<nil>"
Error: exit status 1
time="2024-08-09T01:38:30.057Z" level=info msg="sub-process exited" argo=true error="<nil>"
Error: exit status 1

@haiminh2001 can you confirm if this affects all pipelines or only some?
If only some, can you please share a simple one that causes it?
Also, if you upgraded from an earlier version, make sure you followed the steps in the upgrade guide (and removed some of the sample values which conflict with 0.1.5).

We have also encountered this issue with all our V2 pipelines when components are sending Input of any type into another component. V1 pipelines are however still working correctly

Can @AnteWall or someone else, please share a basic pipeline example that does not work?

So we got it to work yesterday after some deep diving into the code.
There were 2 things caused by the same thing. We have a S3 trough CephFS, which is a url like s3://s3.customdomain.com but we always got "minio://..." instead. This was due to a check for s3.*amazonaws.com regex check to see if it's a S3. Both in the deployKF chart and in Kubeflow Pipelines code. So we changed our custom url to be s3.amazonaws.com.customdomain.com and now it works!
However it only works if we disable cache. If it's using cache it's still sending a minio:// url to the argo job and then it can't download the file(s) from cache. So we are still trying to figure out how/if we can change that to a s3:// prefix instead of a minio becuase then we believe we can get that to work also

There were 2 things caused by the same thing. We have a S3 trough CephFS, which is a url like s3://s3.customdomain.com but we always got "minio://..." instead. This was due to a check for s3.*amazonaws.com regex check to see if it's a S3. Both in the deployKF chart and in Kubeflow Pipelines code. So we changed our custom url to be s3.amazonaws.com.customdomain.com and now it works!

@AnteWall that's good to hear, but I think for users who are actually using MinIO, there might still be a problem when a Dataset type input is passed to a pipeline step.
I think the issue will be that the query-string ?region={bucket_region}&endpoint={endpoint}... is not being picked up in that specific case.
The problem is that deployKF 0.1.5 relies on the behavior of the gcloud.dev library which is to use the AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY env-vars when &endpoint= is set (read more in https://github.com/deployKF/deployKF/pull/122), rather than falling back to the mlpipeline-minio-artifact Secret.
There was an upstream PR to preserve the query strings for for the pipeline root https://github.com/kubeflow/pipelines/pull/10319, but I think the case of Dataset input types were forgotten, so it's just seeing minio://xxxxx (with no ?endpoint=xxxx query), and so is falling back to the mlpipeline-minio-artifact secret.
We probably need to do something similar to https://github.com/kubeflow/pipelines/pull/10319, we just need to find where the Dataset input code lives, and patch it in the deployKF fork of Kubeflow Pipelines.

However it only works if we disable cache. If it's using cache it's still sending a minio:// url to the argo job and then it can't download the file(s) from cache. So we are still trying to figure out how/if we can change that to a s3:// prefix instead of a minio becuase then we believe we can get that to work also

You can turn off caching for a specific V2 step, or you could go nuclear and delete the cache information from the KFP MySQL database.

There were 2 things caused by the same thing. We have a S3 trough CephFS, which is a url like s3://s3.customdomain.com but we always got "minio://..." instead. This was due to a check for s3.*amazonaws.com regex check to see if it's a S3. Both in the deployKF chart and in Kubeflow Pipelines code. So we changed our custom url to be s3.amazonaws.com.customdomain.com and now it works!

@AnteWall that's good to hear, but I think for users who are actually using MinIO, there might still be a problem when a Dataset type input is passed to a pipeline step.
I think the issue will be that the query-string ?region={bucket_region}&endpoint={endpoint}... is not being picked up in that specific case.
The problem is that deployKF 0.1.5 relies on the behavior of the gcloud.dev library which is to use the AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY env-vars when &endpoint= is set (read more in #122), rather than falling back to the mlpipeline-minio-artifact Secret.
There was an upstream PR to preserve the query strings for for the pipeline root kubeflow/pipelines#10319, but I think the case of Dataset input types were forgotten, so it's just seeing minio://xxxxx (with no ?endpoint=xxxx query), and so is falling back to the mlpipeline-minio-artifact secret.
We probably need to do something similar to kubeflow/pipelines#10319, we just need to find where the Dataset input code lives, and patch it in the deployKF fork of Kubeflow Pipelines.

However it only works if we disable cache. If it's using cache it's still sending a minio:// url to the argo job and then it can't download the file(s) from cache. So we are still trying to figure out how/if we can change that to a s3:// prefix instead of a minio becuase then we believe we can get that to work also

You can turn off caching for a specific V2 step, or you could go nuclear and delete the cache information from the KFP MySQL database.

Thank you @thesuperzapper for your clear explanation, so that means at the moment there is no way to use Dataset input types using Minio storage ?

@haiminh2001 I'm still yet to find an actual example which doesn't work in my test clusters.
Do you have a pipeline which I can try that doesn't work?

@haiminh2001 I'm still yet to find an actual example which doesn't work in my test clusters.
Do you have a pipeline which I can try that doesn't work?

This is my pipeline.yaml
# PIPELINE DEFINITION
# Name: trainingadspipeline
# Inputs:
#    train_path: str
#    val_path: str
components:
  comp-get-data:
    executorLabel: exec-get-data
    inputDefinitions:
      parameters:
        data_uri:
          parameterType: STRING
    outputDefinitions:
      artifacts:
        dataset_folder:
          artifactType:
            schemaTitle: system.Dataset
            schemaVersion: 0.0.1
  comp-train:
    executorLabel: exec-train
    inputDefinitions:
      artifacts:
        train_path:
          artifactType:
            schemaTitle: system.Dataset
            schemaVersion: 0.0.1
    outputDefinitions:
      artifacts:
        model:
          artifactType:
            schemaTitle: system.Model
            schemaVersion: 0.0.1
deploymentSpec:
  executors:
    exec-get-data:
      container:
        args:
        - -c
        - mc config host add minio-local http://minio-mlops.deploykf-minio.svc.cluster.local:80
          admin admin123 && mc cp --recursive minio-local/{{$.inputs.parameters['data_uri']}}
          {{$.outputs.artifacts['dataset_folder'].path}}
        command:
        - sh
        env:
        - name: test
          value: hehe
        image: minio/mc
    exec-train:
      container:
        args:
        - --train-path
        - '{{$.inputs.artifacts[''train_path''].path}}'
        - --val-path
        - '{{$.inputs.artifacts[''train_path''].path}}'
        - --model
        - yolov8l
        - --cfg
        - ultralytics/cfg/ads.yaml
        - --devices=0
        command:
        - python
        - train.py
        image: my-registry/myclip:dev
        resources:
          accelerator:
            count: '2'
            type: nvidia.com/gpu
pipelineInfo:
  name: trainingadspipeline
root:
  dag:
    tasks:
      get-data:
        cachingOptions:
          enableCache: true
        componentRef:
          name: comp-get-data
        inputs:
          parameters:
            data_uri:
              componentInputParameter: train_path
        taskInfo:
          name: get-data
      train:
        cachingOptions:
          enableCache: true
        componentRef:
          name: comp-train
        dependentTasks:
        - get-data
        inputs:
          artifacts:
            train_path:
              taskOutputArtifact:
                outputArtifactKey: dataset_folder
                producerTask: get-data
        taskInfo:
          name: train
  inputDefinitions:
    parameters:
      train_path:
        parameterType: STRING
      val_path:
        parameterType: STRING
schemaVersion: 2.1.0
sdkVersion: kfp-2.8.0

There was an upstream PR to preserve the query strings for for the pipeline root https://github.com/kubeflow/pipelines/pull/10319, but I think the case of Dataset input types were forgotten, so it's just seeing minio://xxxxx (with no ?endpoint=xxxx query), and so is falling back to the mlpipeline-minio-artifact secret

You mentioned that input of type Dataset is falling back to the mlpipeline-minio-artifact secret which does not exists. If I understand it correctly, you should be able to reproduce the issue with any pipeline that has a step having an input of type Dataset and is stored in a Minio storage.  Is there anything I misunderstood ?

@haiminh2001 can you share the python code of a simple pipeline example that will cause the error on any cluster?

@haiminh2001 can you share the python code of a simple pipeline example that will cause the error on any cluster?

Hi, this is the python code that generated the pipeline:
from kfp import dsl, compiler

@dsl.container_component
def get_data(data_uri: str, dataset_folder: dsl.Output[dsl.Dataset]):

    return dsl.ContainerSpec(image='minio/mc',
                             command=["sh"],
                             args=['-c',
                                   f"mc config host add minio-local http://minio-mlops.deploykf-minio.svc.cluster.local:80 admin admin123 $
                                   ])

@dsl.container_component
def train(train_path: dsl.Input[dsl.Dataset],
          model: dsl.Output[dsl.Model]):
    return dsl.ContainerSpec(image='my-registry/myclip:dev',
                             command=["python", "train.py"],
                             args=['--train-path',
                                   train_path.path,
                                    '--val-path',
                                   train_path.path,
                                   '--model',
                                   'yolov8l',
                                   '--cfg',
                                   'ultralytics/cfg/ads.yaml',
                                   '--devices=0'])

The image within the train step is my custom image but should be able to be replaced by any other image since it failed to copy data and the image has not ever been started.

So we got it to work yesterday after some deep diving into the code.
There were 2 things caused by the same thing. We have a S3 trough CephFS, which is a url like s3://s3.customdomain.com but we always got "minio://..." instead. This was due to a check for s3.*amazonaws.com regex check to see if it's a S3. Both in the deployKF chart and in Kubeflow Pipelines code. So we changed our custom url to be s3.amazonaws.com.customdomain.com and now it works!
However it only works if we disable cache. If it's using cache it's still sending a minio:// url to the argo job and then it can't download the file(s) from cache. So we are still trying to figure out how/if we can change that to a s3:// prefix instead of a minio becuase then we believe we can get that to work also

I just tested, my pipeline works fine when disabling cache too. The pipeline uses a Minio as the Artifact Registry.

I have had a a similar issue.
I'm able to run pipelines successfully, but one thing I've not been able to do is import an artifact from another pipeline (as same user&namespace). All my object store options are the defaults. Using code like this:
from typing import NamedTuple
from kfp.v2.dsl import component, pipeline, importer, Dataset, Model, Input

@component
def train_model(dataset: Dataset) -> NamedTuple('Outputs', progress=List[float], model=Model):
	outputs = namedtuple('Outputs', ['progress', 'model'])
	return outputs(list(range(100)), None)

@pipeline
def pipeline_func(url: str) -> None:
    import kfp
    print(kfp.__version__)
    importer1 = importer(
        artifact_uri='minio://kubeflow-pipelines/v2/artifacts/ml-editor/pipeline-func/1b008faa-5747-44c3-ad6d-737c4bbf0053/download-data/dataset',
        artifact_class=Dataset,
        reimport=True
    )

    train = train_model(dataset=importer1.output)from typing import NamedTuple
from kfp.v2.dsl import component, pipeline, importer, Dataset, Model, Input

@component
def train_model(dataset: Dataset) -> NamedTuple('Outputs', progress=List[float], model=Model):
	outputs = namedtuple('Outputs', ['progress', 'model'])
	return outputs(list(range(100)), None)

@pipeline
def pipeline_func(url: str) -> None:
    import kfp
    print(kfp.__version__)
    importer1 = importer(
        artifact_uri='minio://kubeflow-pipelines/v2/artifacts/namespace-name/pipeline-func/1b008faa-5747-44c3-ad6d-737c4bbf0053/download-data/dataset',
        artifact_class=Dataset,
        reimport=True
    )

    train = train_model(dataset=importer1.output)

Error I'm getting:
Failed to get minio credential: Failed to get MinIO credential from secret name="mlpipeline-minio-artifact"

When I run with a s3:// url I am getting this error:
failed to download input artifact "dataset" from remote storage URI "s3://...": failed to list objects in remote storage "v2/artifacts/group-name/pipeline-func/93dfc1ce-77fa-4b39-8a03-d49ac7b52287/download-data/dataset": blob (code=Unknown): MissingRegion: could not find region configuration
Does this look more familiar to something y'all have seen?


Support Schema Extensions in subscriptions

Subscriptions are now executed like queries and mutations, and extension hooks are called.
Result extension hooks are called for each result yielded by the subscription

NOTE: #2825 is an updated version of this, with a less intrusive change to the schema API.
Description
the Schema.subscribe() is turned into an AsyncGenerator yielding ExecutionResult objects.
In case the validation of the requests results in a single result instead of a subscription,  e.g. when the inner
graphql-core.subscribe() does not return an iterator, a special exception is thrown, SubscribeSingleResult which' value
attribute contains the single ExecutionResult.
This pattern, always being a AsyncGenerator which aborts under certain circumstances, makes for a cleaner interface
and allows for much simpler use of context managers.  Following the pattern of graphql-core which either returns
an iterator or an object, makes it unnecessarily tricky to implement with the Extensions context managers.
The payload part of the returned messages in both protocols is augmented with an extensions member if added by the corresponding hooks.
Tests are added to tests for result extensions.
A side effect of this change is that initial validation now happens on a worker task.  This feature was a part of a separate PR in progress, so corresponding tests are also added to verify that functionality.

Types of Changes

[x] Core
[ ] Bugfix
[x] New feature
[x] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR

#2097

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Subscriptions now support Schema Extensions.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @kristjanvalur for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

Current unit test flakiness is addressed by #2785

Now, this is an internally breaking change in that the results from schema.subscribe() have changed.  but is this a documented interface?
We could change the interface but it would impact the possibilities of what kind of context it is possible to maintain during the evaluation of a subscription.

Now, this is an internally breaking change in that the results from schema.subscribe() have changed. but is this a documented interface?
We could change the interface but it would impact the possibilities of what kind of context it is possible to maintain during the evaluation of a subscription.

I think breaking it is fine, as long as we write it down :)

Right, so please advise, if you like the approach I'm suggesting in this PR, then should I add the breakage to the RELEASE.md, similar to what was done with the recent channels PR?

Right, so please advise, if you like the approach I'm suggesting in this PR, then should I add the breakage to the RELEASE.md, similar to what was done with the recent channels PR?

we have a folder for breaking changes now: https://github.com/strawberry-graphql/strawberry/tree/main/docs/breaking-changes
I'll update the version number before merging 😊

Probably want to add ruff as dev-dependency and pin it to a version

By the way, I offer a different kind of resolving the "either return an ExecutionResult or an Iterator" thing, to more
closely match what graphql-core does.  Basically, it involves an outer helper around an inner generator.
The code looks like this:
import asyncio
import contextlib
import inspect
from typing import AsyncGenerator, Optional, Union, cast

incontext = False

@contextlib.asynccontextmanager
async def mycontext() -> AsyncGenerator[None, None]:
    global incontext
    incontext = True
    try:
        yield
    finally:
        incontext = False

async def inner_gen(dofail: bool) -> AsyncGenerator[Optional[str], None]:
    async with mycontext():

        # yield an initial value, which will be the single result value,
        # or None if we're going to yield more values
        if dofail:
            yield "failure"
            return  # typically not reached
        else:
            yield None

        # yield more values
        yield "success"
        yield "success2"

async def outer(dofail: bool) -> Union[str, AsyncGenerator[str, None]]:
    # check the first value, and if it's not None, return it,
    # aborting the generator
    gen = inner_gen(dofail)
    first = await gen.__anext__()
    if first is not None:
        await gen.aclose()
        return first
    else:
        return cast(AsyncGenerator[str, None], gen)

async def main() -> None:
    assert not incontext
    v = await outer(True)
    assert not incontext
    assert v == "failure"

    v = await outer(False)
    assert inspect.isasyncgen(v)
    assert incontext
    async for val in v:
        assert "success" in val
        assert incontext
    assert not incontext

if __name__ == "__main__":
    asyncio.run(main())

Using this pattern, we could avoid the SubscribeSingleResult exception, but we would then, again, have to check the
type of schema.subscribe() result to determine if it is a ExecutionResult or an iterator.
Both work.  Which one is peferred by the maintainers?  I'm happy to convert.

Important, before mergint this, please consider #2825, which is a less intrusive change

@kristjanvalur can you rebase this? I'll make a pre-release so @Speedy1991 can test it :D

@kristjanvalur can you rebase this? I'll make a pre-release so @Speedy1991 can test it :D

Sure, although you may want to look at #2825 instead, it maintains essentially the same API as before (returning either a GraphQLResult or an iterator.   I think it has a smaller "footprint.".  I'll rebase both.
There is also still some flakiness in one of the unittests (testing the order of the hooks bein called), it appears that despite my efforts, some straggling tests may be interfering with it...  I'll figure out a way to fix it.

/pre-release

Pre-release
:wave:
Releasing commit [abfd60e6968a9cdc5632a78536eefc3acf67a070] to PyPi as pre-release! :package:

Pre-release
:wave:
Pre-release 0.196.0.dev.1689676990 [abfd60e6968a9cdc5632a78536eefc3acf67a070] has been released on PyPi! :rocket:
You can try it by doing:
poetry add strawberry-graphql==0.196.0.dev.1689676990

from @Speedy1991 on discord:

btw. from a programmer perspective the https://github.com/strawberry-graphql/strawberry/pull/2784 is much cleaner to implement in a ws view 🙂

from @Speedy1991 on discord:

btw. from a programmer perspective the #2784 is much cleaner to implement in a ws view 🙂

Interesting.
So, this deviates a bit from the api which graphql-core has, which is trying hard to stay consistent with the original js implementation, returning either a "graphql-result" or an iterator.  That approach is a bit un-pythonic.
Strawberry-graphql generally sticks to an identical api in schema.py
This pr changes that approach to raise an Exception in the exceptional case.  I originally did this because it was easier for me to  support the context managers for the extensions.  But it resulted in a semantic change in schema.subscribe, more than just the returned types changing from graphql-core ExecutionResult to strawberry ExecutionResult.
I later figured out how to keep the old api, while only changing the type.  That was #2825.  Code which calls schema.subscribe now does not need to be re-structured, only expect different types.
Everything else is the same difference between these two prs.  I guess it comes down to which api style is considered cleaner.

@kristjanvalur sorry for my lazyness, could you show me the two different APIs here? (or even another issue)

here we go.  2784 style:
try:
    async for result in self.schema.subscribe(...):
        await self.send_result(operation, result, False)
except SubscribeSingleResult as single_result:
    await self.send_result(operation, single_result.value, True)
finally:
        await result_source.aclose()

2825  style (and the current style in code, inherited from graphql-core)
result_source = self.schema.subscribe(...)
if isinstance(result_source, ExecutionResult):
    await self.send_result(operation, result_source, True)
    return
try:
    async for result in result_source:
        await self.send_result(operation, result, False)
finally:
        await result_source.aclose()

Basically, switching on the result value type, or treating a single result (usually validation error) as an "exceptional" case.

@patrick91 Can we merge this?

let me see if I can bring this up to date

Still some minor fixes needed.
Please consider also if you think pr #2825 is a better api, see discussion above.

There have recently been made some changes to extension error handling.
It is unclear to me how to translate that to this PR.
Note that errors during evaluation of the request need to be raised as SingleValueException with an ExecutionResult.
After that, ExecutionResults are not fatal.
But unexpected exceptions, such as should indeed be fatal during iteration.

@kristjanvalur thank you so much for keeping this PR up to date, @nrbnlulu made a new PR recently and we merged that, hope that's ok!

@kristjanvalur probably, there's been a lot of refactoring recently, I'll check with @DoctorJohn soon :)


Script for auto-creating MCU workspace

This should basically automate what's currently in the build docs at https://github.com/micro-ROS/micro-ROS-doc/blob/master/docs/install_and_run.md#linux

See #2


SSD to tensorflowjs convertor

Hey Vincent,
Can you enlighten me on how you converted the weights provided in https://github.com/yeephycho/tensorflow-face-detection to tfjs. I tried this but hit unsupported ops issue.
tensorflowjs_converter --input_format=tf_frozen_model  --output_node_names='concat,concat_1' frozen_inference_graph_face.pb output
Unsupported Ops in the model
Where, TopKV2, Assert, NonMaxSuppression

Hi,
I didn't use the tensorflow.js converter, because at that time way more ops where not supported than the ones you mentioned. I extracted them with some own scripts.

 Being able to get SSD to work when there are certain ops that aren't supported. It would be great if you can share them with the bigger community.  I am not sure how comfortable you would be to share the scripts. Can totally understand if you couldn't

Thanks, but it might actually be easier than you think. You could simply load your graphdef with tf + python and then save the weight values to binary files with numpy and get their names and shape from the graph, to construct the manifest.json file.
I already commented on the tfjs ssd_mobilenet issue, with how you could approach converting an ssd model to tfjs.

Thank you for your response

Can you share your scripts? I have the same questions that tfjs ops not supported,very thanks


ShadowBox inset attribute? Inner shadow

I didn't find any trace of inner shadow for box.
Like in CSS using box-shadow: inset there is a option to achieve the same effect?

cc @HansMuller

The Material widget has an elevation (and a shape!). It's rendered with a shadow that's based on the elevation.

@HansMuller I think he is looking for an inside shadow like https://css-tricks.com/snippets/css/css-box-shadow/#article-header-id-2

@zoechi provided example what I want achieve

@zoechi I see. We don't have explicit support for "inward" shadows however that seems like a reasonable thing to add.

You can add paralax to an image, lets say a header image for a listing, but then also adding an inner shadow so it looks set back would give a great 3d effect people would want to be able to do.

I'm looking for this feature in order to add inner shadow to the background widget of dismissible widgets. That way it would appear as though my list tiles are elevated above it.

Its important to add that this should be transparent, or support transparency.  The same effect can be created with no transparency by stacking boxShadow's but you are left with the top boxShadow's color.  What would be nice is to be able to put this "over" another item, in a stack and this shadow effect shows through to the stack below.

I wanted to use this feature to add an inset shadow on my map widget, making it look embedded in the page. Unfortunately I can't find a workaround for this.

Any update on inner shadows? Thanks!

Any further work on this?

Do we have an update on this feature?

Also looking for this feature

To add on to this, a lot of people are looking for this to work on "neumorphism UI" elements to their applications

Hey guys how is your day?

May be this can help >> https://www.youtube.com/watch?v=oTYDD3nZ-ZA

I found this approach.  and it is what I am using.
took some fiddling, but it works really well :) .
it is not just a linear . gradient like moist other workarounds I have tried
https://twitter.com/luigirosso/status/1208286460610113541

If you are here because you wish to make a neumorphic button, you really don't need a inner shadow, try the following code for a circular container over a Color.fromRGBO(190,192,195,1.0) background
 boxShadow: _selected
              ? [
                  BoxShadow(
                    color: Colors.black26,
                    blurRadius: 20,
                    spreadRadius: 2,
                    offset: Offset(12, 12),
                  ),
                  BoxShadow(
                    color: Colors.white70,
                    blurRadius: 20,
                    spreadRadius: 2,
                    offset: Offset(-12, -12),
                  ),
                ]
              : [
                  BoxShadow(
                    color: Colors.black26,
                    blurRadius: 30,
                    spreadRadius: 2,
                    offset: Offset(-12, -12),
                  ),
                  BoxShadow(
                    color: Colors.white60,
                    blurRadius: 20,
                    spreadRadius: 2,
                    offset: Offset(12, 12),
                  ),
                ]

Play with this and you have the desired effect..
P.S. Lighter color has to be after the darker one when defining boxShadows.
The full code for the same is here- https://gist.github.com/bhaskar-nair2/88bdb05f3d776b6a94c430fbd048e67f

It's kind of embarrassing that in a framework that says it's great for graphics, you need to do a giant work around to get an simple inner shadow

And (as far as I've seen) there seems to be no good hacked together solution for text anyways

Where is this? I can't believe a modern framework doesn't have such a basic UI element.

I think what most of us are looking for is an Inner Box Bevel with similar parameters as Photoshop Blending Options, but the way to hack that in CSS is using an inset shadow. It would be nice if BoxShadow has an option to make inset: true, or to allow blurRadius & spreadRadius be a negative value.  It would also be amazing to have a boxDecoration component like boxBevel: BoxBevel(depth: 22, size: 7, soften: 2, angle: -39, altitude: 26, highlightColor: Colors.white54, shadowColor: Colors.black54, highlightBlendMode: BlendMode.screen, shadowBlendMode: BlendMode.multiply, style: BoxBevelStyle.smooth), and to do the same for TextBevel..
While I'm dreaming as a designer/programmer is to have Emboss, Chisel Hard, Chisel Soft, Contour, Inner Glow, Satin, Stroke, Pattern Overlay, and all that good stuff built into the Flutter framework.  There are some nice addons out there that come close at least, along with some complex CustomPainter tricks.  We just have to do it in Adobe software exported as png to get the look we wanted to do in the code, but I don't want to sound ungrateful..  I think UI in our apps would evolve nicely with those extra design tools in our arsenal, as long as we don't abuse them...

I vote for this too, been hacking at this for days now.

I want to make something like this. I don't see any workaround for it. It feels like flutter hates neumorphism.

Inner Shadow property would be very useful for (rounded) TextFields. Maybe the trend is already outdated when this is introduced ;)

This source was useful for me. Base on this source I built a circle with transparent background and the same time the circle has an inner shadows. In short, need to use RadialGradient in an Container's BoxDecoration.
`Container(
                      decoration: BoxDecoration(
                        shape: BoxShape.circle,
                        gradient: RadialGradient(
                          colors: [
                            Colors.black.withOpacity(0.0),
                            Colors.black.withOpacity(0.2),
                          ],
                          center: AlignmentDirectional(0.0, 0.0),
                          focal: AlignmentDirectional(0.0, 0.0),
                          radius: 0.60,
                          focalRadius: 0.001,
                          stops: [0.75, 1.0],
                        ),
                      ),
                    ),`

any hope this will ever be added?
now that web is officially supported I would expect that such a basic task would be easy to achieve, specially if flutter wants to conquer developers that are already used to how easy things like this are in CSS

I vote for this implementation.

I had an idea about inner shadow implementation and creating neumorphism effect in Flutter. How about creating the parent container (with Clip.hardEdge), which has drop shadows (regular ones), and a child container with other two shadows, which, after clipping, looks like inner ones.

(Preview of the result)
Have a look at code here  :)
I hope i have helped at least someone :smile:

Please refer to https://github.com/flutter/flutter/pull/88697

any update on this?

It's been 4 years, and it's still open. Is there any easy way to achieve the same behavior CSS has?

found a simple solution for now that you can use Stack and LinearGradient together so you can mimic the inset shadow similar to CSS... example :
`
Stack(
children: [
Container(
width: MediaQuery.of(context).size.width,
height: 210,
decoration: BoxDecoration(
image: DecorationImage(
image: NetworkImage(
'https://images.unsplash.com/photo-1559305616-3f99cd43e353?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=735&q=80'),
fit: BoxFit.cover)
),
                  ),
                  Container(
                    height: 210,
                    decoration: BoxDecoration(
                      gradient: LinearGradient(
                          begin: Alignment.bottomCenter,
                          end: Alignment.topCenter,
                          colors:[
                            Colors.black,
                            Colors.transparent,
                            Colors.transparent,
                          ]
                      ),
                    ),
                  ),
                ],
              ),

`

@flar - this request has been simmering for a long (long) time. Do you think it would be possible to add support for inner shadows like this example https://github.com/flutter/flutter/issues/18636#issuecomment-870449092 ?

Hi, I found a workaround solution in https://github.com/happyharis/neumorphic
I haven't used BlurStyle.inner. It didn't work.

Container(
  decoration: BoxDecoration(
    boxShadow: [
      // inset 0px 4px 6px rgba(8, 56, 73, 0.5)
      BoxShadow(
        color: const Color.fromRGBO(8, 56, 73, 0.5), // shadow color
      ),
      const BoxShadow(
        offset: Offset(0, 4),
        blurRadius: 6,
        color: Color(0xFFF9F8F9), // background color
      ),
    ],
    borderRadius: BorderRadius.circular(25),
  ),
  child: TextField(...),
),

I hope this helps someone.

React Native developer here 🙋🏼♂
We implemented inner shadows using the following combination of Skia image filters:
const f1 = ImageFilter.MakeColorFilter(
  ColorFilter.MakeBlend(cl, BlendMode.SrcOut),
  null
);
const f2 = ImageFilter.MakeOffset(dx, dy, f1);
const f3 = ImageFilter.MakeBlur(blur, blur, TileMode.Decal, f2);
const f4 = ImageFilter.MakeBlend(BlendMode.SrcIn, sourceAlpha, f3);
if (shadowOnly) {
  return f4;
}
return ImageFilter.MakeCompose(
  input,
  ImageFilter.MakeBlend(BlendMode.SrcOver, sourceGraphic, f4)
);

Does the recipe look correct? As far as we tested it, it seems to work nicely. I'm curious why this is not an available part of Skia (drop shadow is) and why this is not part of Flutter either. Are there some challenges with this implementation that we may be overlooking?

Hello everyone! :smile:
We have just published this package: https://pub.dev/packages/flutter_inset_box_shadow.
It adds an inset property to BoxShadow, and provides an alternative to BoxDecoration capable of painting these shadows.
The algorithm used is the same as the one used by Blink, the Chromium renderer: we draw a rectangle hollowed by another rounded rectangle, then we blur this hollowed rectangle.
It is possible that there are still bugs in some cases, do not hesitate to inform us by creating an issue.
I hope it will be useful to some!

@johynpapin congrats! I wanted to check blink's source code for this but struggled to find the relevant file, you could point it to me?

This is the most efficient implementation I've seen so far. I tried a few cases with Figma and it looks the same to naked eye.
I had resorted to a work around which was also based on a similar approach but we had to use saveLayer with a srcOut blend mode to diff between the two rectangles.
TIL drawDRRect which calls the native Canvas_drawDRRect and will surely be efficient compared to saveLayer.
Thanks for sharing, looking forward for this to be implemented along with BoxDecoration.

@johynpapin Thank you for sharing your implementation 🙌🏼 We will use it for boxes as well since it is much faster. For anything else like path or text inner shadows, the implementation in my last comment is the way to go.

Maybe we could apply some shaders to reach the desired effects without performance drop (in https://pub.dev/packages/flutter_inset_box_shadow package)?

any update on this?

Any update on this 6 year old feature request?
I came here, because I want to have top and bottom inner shadow for a SingleChildScrollView, but the solution given in https://github.com/flutter/flutter/issues/24567 does not work at all.
It is hard to believe that flutter does not support such a common feature.

Any update? I'm working on a Figma design with inner shadows. I'm surprised that Flutter still doesn't have it. :/

@AlexanderFarkas

It's relatively easy to implement yourself

How? I searched stackoverflow, github etc. but did not find a single code example that works as expected. Maybe you can share a link to your solution?
Actually, flutter_inset_box_shadow has not been updated in the past two years and I'm not happy at all to include several small extra packages for simple and well known features that are not supported out of the box by flutter. It will eventually pollute my pubspec.yaml and it also poses maintenance and security risks as some of those packages are not actively maintained any more.
Frankly, flutter is killing development speed as I have to spend a lot of extra time to figure out again and again if something as simple as this is supported out of the box or how I can quickly implement it myself or if there is a trustworthy and actively maintained package that works as expected.

@goerlitz I used the code from the ghost's link
It involved copy-pasting Flutter's BoxDecoration and tweaking its paint method, but once it was done, it was working as expected.

Would be nice if flutter support this out of the box, inner shadow are common in many designs. This kind of things slows down Flutter adoption, imo.


Highlight Legal Moves for pawn

Please check the pawn legal moves after crossing the river.

What's wrong? Please paste the picture.
I checked again and there is no wrong for sure.

What's wrong? Please paste the picture.
I checked again and there is no wrong for sure.

😅Sorry,  I was wrong.
I tested on your Highlight Legal Moves example https://lengyanyu258.github.io/xiangqiboardjs/examples.html#5003
Maybe I place ONLY a pawn in between k and K 將帥不可照面. so it does not highlight the pawn moves(left/right).

😅Sorry,  I was wrong.
I tested on your Highlight Legal Moves example https://lengyanyu258.github.io/xiangqiboardjs/examples.html#5003
Maybe I place ONLY a pawn in between k and K 將帥不可照面. so it does not highlight the pawn moves(left/right).


added comment about CS1024

Added comment from PR #199 to the source code.
The #load directive, valid for script files (mentioned here https://github.com/dotnet/roslyn/issues/122) is currently not recognized by Roslyn so CS1024 need to be suppressed

cheers @filipw!


Update scala-library to 2.13.8

Updates org.scala-lang:scala-library from 2.12.15 to 2.13.8.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.12.15).
You might want to review and update them manually.
indigo-plugin/build.sc

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains

Scala steward fail. Trying to upgrade a plugin to use 2.13...


fix(ngMock): clear out $providerInjector after each test

Closes #13397

@shahata - since you made the original change. Can you quickly cast your eye over this one? Thanks.

LGTM!


fix: allow creating custom theme

CommonTheme and others need to be accessible for customizing colors. This now works:
#[component]
fn TheProvider(children: Children) -> impl IntoView {
    let base_theme = Theme::light();
    let custom_theme = Theme {
        common: thaw::CommonTheme {
            color_primary: "var(--variable-set-in-style-css-file)".to_string(),
            ..base_theme.common
        },
        ..base_theme
    };
    let theme = create_rw_signal(custom_theme);
    view! {
        <ThemeProvider theme>
            {children()}
        </ThemeProvider>
    }
}

Thank you!


Add error-handling exercise

Shameless copy/inspiration from the F# version.
This leaves on three exercises to be implemented in the C# track.

Looking good! Thanks a lot. :tada:


Error is shown in the Account creation dialog for empty Role

http://cs-ui-ci.z1.netpoint-dc.com:8080/bwsw/master/accounts/create
User: develop
Steps:

Login by develop
Go to Account creation
Input all mandatories, Role is empty
Click Create

Actual result: Error message appears (on pic)
Expected result: Role is mandatory, the validation occurs for empty Role

Connected Feature ID: account_create

test on: http://cs-ui-ci.z1.netpoint-dc.com:8080/ksendart/951-account-creation
to test: account_create

Tested on ksendart/951-account-creation


Vampyre Cloake can be used for +2 col res for mouthwash

Mist form should be cast during a free fight during early levelling.
The combat macro for all free fights should be adjusted to cast the skill if available.
The outfit for all free fight tasks should force cloake via a helper function if its available, casts remain and the effect is not active.

https://kol.coldfront.net/thekolwiki/index.php/Become_a_Cloud_of_Mist

This is a little annoying to route, since we are not really doing any free fights before leveling with embers anymore. And it's hard to tell apriori if it is worth it to use one just to get this. For low shiny it is probably worth it.


"flutter run" prints warning multiple times after switching Flutter SDK's

When running a flutter app within IntelliJ just after switching Flutter SDK's, a rather verbose warning is printed twice. Also, it's often printed again the next time you stop and restart the Flutter app. (It eventually goes away, but I haven't seen a pattern to when that happens.)
Here's the console output:
Warning! The 'flutter' tool you are currently running is from a different Flutter
repository than the one last used by this package. The repository from which the
'flutter' tool is currently executing will be used instead.
  running Flutter tool: /Users/skybrian/software/flutter
  previous reference  : /Users/skybrian/dart/work/flutter
This can happen when you have multiple copies of flutter installed. Please check
your system path to verify that you are running the expected version (run
'flutter --version' to see which flutter is on your path).

Launching lib/main.dart on Android SDK built for x86 64 in debug mode...
Running 'gradle assembleDebug'...
Warning! The 'flutter' tool you are currently running is from a different Flutter
repository than the one last used by this package. The repository from which the
'flutter' tool is currently executing will be used instead.
  running Flutter tool: /Users/skybrian/software/flutter
  previous reference  : /Users/skybrian/dart/work/flutter
This can happen when you have multiple copies of flutter installed. Please check
your system path to verify that you are running the expected version (run
'flutter --version' to see which flutter is on your path).

Built build/app/outputs/apk/app-debug.apk (21.7MB).
Installing build/app/outputs/apk/app.apk...
Syncing files to device Android SDK built for x86 64...

This is using:
skybrian-macbookpro2:flutter skybrian$ flutter --version
Flutter • channel master • https://github.com/flutter/flutter.git
Framework • revision d6ec71d2c0 (18 minutes ago) • 2017-06-15 19:03:24 -0700
Engine • revision 18fdfb86bb
Tools • Dart 1.24.0-dev.6.7

Same for me.
There are two developers on a local Ubunti machine. Each has a flutter installation in his home dir. Seems like there is a conflict or smth.

I believe flutter packages upgrade should fix it?
Regardless we should offer "how to fix this" instructions as part of that error message.

The reason we see it twice is that gradle is for some reason recursively calling into flutter, which seems likely to cause other issues (we're not generally set up for flutter to be run recursively).
Having two developers edit the same directory with different flutter installations is a strange setup, I'm not sure there's any way for us to identify that that is what is going on. The fix differs based on how you end up in this situation; the common reason is that you have multiple copies of flutter installed, and the wrong one on your path, which the error message already tells you how to deal with.

I've seen this in the IDE when switching from one Flutter SDK to another in the project's settings. (For example, I had two flutter clones to test alpha versus master.) In that case, it's not clear that there is anything to fix or why there should be an error message at all, since the user is intentionally switching SDK's.
Maybe the IDE needs to automatically run flutter packages upgrade after the user changes the SDK?

It seems like there just need to be some more details in the error message.
Where is he getting the running Flutter tool and what is the previous reference

Trying to publish with pub.
In pubsec.yaml replaced
dependencies:
  flutter:
    sdk: flutter

with the
  flutter: "^0.0.20"

Unable to compile the project due to the missing import 'package:flutter/services.dart';
Says
Warning! The 'flutter' tool you are currently running is from a different Flutter
repository than the one last used by this package. The repository from which the
'flutter' tool is currently executing will be used instead.
  running Flutter tool: D:\AndroidDev\flutter
  previous reference  : D:\PUB_CACHE\hosted
This can happen when you have multiple copies of flutter installed. Please check
your system path to verify that you are running the expected version (run
'flutter --version' to see which flutter is on your path).

In my case the issue tracked down to the fact that I should have been using a repo with git ignore set up properly. I had to go back and manually delete every build folder, lockfile for pubspec.yaml and all local files.
My project ties multiple projects into a larger folder, so it was a bit messier than most. In short, make sure that files local to one machine or the other aren't being checked into the repo. That may be your issue too.
Good luck

This issue can be fixed by running "flutter packages get" in the root directory of the project on the system. It worked for me.

Do "flutter packages get" whenever you switch from PC to macOS as this was the case with my project.

This and https://github.com/flutter/flutter/issues/21510 are duplicates of each other; this bug has more unrelated comments so I'm closing it as a dupe of the other.

I ran into a similar issue when I moved my SDK to a different directory.
Running flutter --version as suggested is not really helpful. As it also prints the same warning and shows versions not really path.
Flutter 1.5.4-hotfix.2 • channel stable • https://github.com/flutter/flutter.git Framework • revision 7a4c33425d (4 weeks ago) • 2019-04-29 11:05:24 -0700 Engine • revision 52c7a1e849 Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
Also running flutter packages get will throw following error.
`Could not find a command named "package".
Run 'flutter -h' (or 'flutter  -h') for available flutter commands and options.`
In order to fix the issue when you have moved your SDK folder is to go under your application folder and move or delete .packages file and then run flutter packages get. This will ensure that right packages are fetched under new location and paths are updated.

This issue can be fixed by running "flutter packages get" in the root directory of the project on the system. It worked for me.

Do "flutter packages get" whenever you switch from PC to macOS as this was the case with my project.

Nice ! Thanks a lot

This issue can be fixed by running "flutter packages get" in the root directory of the project on the system. It worked for me.

Thanks

This issue can be fixed by running "flutter packages get" in the root directory of the project on the system. It worked for me.

it works

In my case, it worked when I deleted the .packages file and the build folder.

there are two settings in AS's preferences, search keyword "flutter" and "dart" point the dart-sdk and flutter tool to be same as your environment variable.


Fix for ASCII GPG Keys Not Being Recognized by APT in s1-agent-install-repo.sh Script

https://github.com/s1community/install-tools/blob/c9c05f6176e1c4bf915dc1833c4cbc4b02215432/linux/s1-agent-install-repo.sh#L173
Hello @s1-howie
The curl option -s disables standard output, resulting in no data in the pipe and empty files are created in /etc/apt/trusted.gpg.d/.  Also, the published key is in ASCII while APT expects binary format with this extension.
The curl option -O cannot be used, it redirects the output to a file in the current dir. Also, both apt-key.gpg and repo-signing-key.gpg are ASCII and will be ignored by apt unless converted to binary:
curl -sL https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/sentinelone-apt-key.gpg
curl -sL https://us-apt.pkg.dev/doc/repo-signing-key.gpg | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/sentinelone-repo-signing-key.gpg

@maorteg @s1-howie
Updates to the curl flags and gpg --dearmor command have been committed to the main branch.
I also reorganized the user prompts when arguments or s1.config is not provided to follow the same order as arguments.
I'll keep this issue open through the end of the week for feedback.

https://github.com/s1community/install-tools/commit/fdd61526ad341203a3750a255704fe9cb22fd2d4

New commit with dedicated branch: c8ee69c.

Thank you @maorteg
Changes have been merged to main, closing issue.


fix: postgrest-js 1.15.6

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.948%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
90

Relevant Lines:
117

💛  - Coveralls


refactor zk tree cache

What is the purpose of the pull request
in ZookeeperCachedOperator class, the current implementation is to use a map to store all the treecache, which may be problematic. The correct method is to use a treecache to monitor
zk /${~ scheduler}  All events under the root path, which is responsible for forwarding to the subclass, and the subclass uses the path to get the events it cares about

Codecov Report

Merging #1577 into dev will increase coverage by <.01%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             dev   #1577      +/-   ##
========================================
+ Coverage   7.58%   7.59%   +<.01%
========================================
  Files        277     276       -1
  Lines      13743   13739       -4
  Branches    2194    2197       +3
========================================
  Hits        1043    1043
+ Misses     12631   12627       -4
  Partials      69      69

Impacted Files
Coverage Δ

.../dolphinscheduler/common/zk/ZookeeperOperator.java
0% <0%> (ø)
:arrow_up:

...che/dolphinscheduler/server/zk/ZKWorkerClient.java
0% <0%> (ø)
:arrow_up:

...inscheduler/common/zk/ZookeeperCachedOperator.java
0% <0%> (ø)
:arrow_up:

...che/dolphinscheduler/server/zk/ZKMasterClient.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026fdd9...cc1a5ff. Read the comment docs.


【Problem】can not download for huawei‘s browser  and   uc browser .

file name is not true，download failed after clicking the download button.

They're all Android platforms.


Add section to template README "Nomad ACL handling"

In template_example we use nomad_acl_test.tf to generically work with both acl enabled and disabled in nomad. This needs to be documented for new users creating a terraform module (remember to remind them to include variables.tf).

Yes.... maybe we should have this file as default in the actual template?

Yeah, that might be just as well, together with #290 and a dir called vagrant-box or something to signalise this is how it's used together with the vagrant-box that might be fairly intuitive


Fix for OpenSSLTest.testNodeClientSSL failure

Issue #, if available:
Description of changes:

Initialize "path.data", "path.logs" and "path.home" for every ES Node started during tests
Change "path.data", "path.logs" and "path.home" to use "target/data"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

OpenSSLTest.testNodeClientSSL test was failing with MasterNotFound exception. How did changing the path.data, path.logs and path.home resolve the test issue?

MasterNotDiscoveredException was caused by the Node being rejected from joining the cluster as its UUID would not match the cluster UUID that it tried to join. To avoid it, it is necessary to start the Node with no UUID assigned. It is usually the case during the tests unless "path.data" points to an existing directory that was previously used by another Node. Note that ClusterHelper sets those properties for Nodes it creates and uses unique clusterName to avoid the issue. The fix sets "path.data" ("path.logs" and "path.home") for other Nodes created during the tests.
I also changed "path.data", "path.logs" and "path.home" to root at "target/data", so that "mvn clean" will delete any leftover directories that were not deleted during tests (due to exceptions).

MasterNotDiscoveredException was caused by the Node being rejected from joining the cluster as its UUID would not match the cluster UUID that it tried to join. To avoid it, it is necessary to start the Node with no UUID assigned. It is usually the case during the tests unless "path.data" points to an existing directory that was previously used by another Node. Note that ClusterHelper sets those properties for Nodes it creates and uses unique clusterName to avoid the issue. The fix sets "path.data" ("path.logs" and "path.home") for other Nodes created during the tests.
I also changed "path.data", "path.logs" and "path.home" to root at "target/data", so that "mvn clean" will delete any leftover directories that were not deleted during tests (due to exceptions).

Thanks for the detailed explanation.


Scanning for the DFU Bootloader ...

I used DFU in IOS-nRF-Toolbox and prompted "Scanning for the DFU Bootloader ...", it didn't respond.

@philips77
I found the same problem.
Just like this one:

The program stays there any times,and peripheral always connented .Disconnect only when power is cut off。
The DFU Library verstion is 4.1.1
iOS 12.3   - iPhone 7
xcode 10.1 (10B61)
Can you help me ？ or give me some suggests, thank you!

Hello, sorry for replying so late.
This issue is related to DFU Library, and an older version of it. It has been fixed with https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/pull/367 and released in version 4.7.1. Please use most current version of the DFU library (which right now is 4.10.1, released today).


dll x64 architecture error

when i just click play, the console show this error :
Failed to load 'Assets/Plugins/x86_64/taichi_c_api.dll', expected x64 architecture, but was Unknown architecture. You must recompile your plugin for x64 architecture.
but i've checked dll inspector , which is x64 architecture.
I wonder how to deal with this problem？ thx

I wonder what's your platform? Are you using Windows?

I wonder what's your platform? Are you using Windows?
Yes, Does it not support windows?

It actually supports windows in the first place and it's tested by our CI server... That's an issue. Thanks for the report. Will look into this.

Thanks a lot, it's very strange that my friend's windows works. I'm looking for the difference, I'll report back here if I make progress

@PENGUINLIONG I solved this problem, the dll of git clone can run normally, but this error will be reported when downloading the zip package.
BTW，I noticed that some local binary files (edges, c2e, etc.) are loaded in the fem demo. What do these binary files represent? Why do I write it like this? If I want to port the taichi fem algorithm to my model (FBX) ,What should I do?

e same problem with Failed to load 'Assets/Plugins/x86_64/taichi_unity.dll', expected x64 architecture, but was Unknown architecture. You must recompile your plugin for x64 architecture.
My system is window.
The version of unity is 2021.3.41.
Do I need to recompile taichi_unity.dll and taichi_c_api.dll according to the error message?

I have a same problem with Failed to load Assets/Plugins/x86_64/taichi_unity.dll, expected x64 architecture, but was Unknown architecture. You must recompile your plugin for x64 architecture. and Failed to load 'Assets/Plugins/x86_64/taichi_c_api.dll', expected x64 architecture, but was Unknown architecture. You must recompile your plugin for x64 architecture.
My system is window.
The version of unity is 2021.3.41.
Do I need to recompile taichi_unity.dll and taichi_c_api.dll according to the error message?


Call create_db before run

UPDATE:
I've just seen on your website that you did recommend this CLI call to be used before registering a user, apologies!

docker-compose run users python manage.py create_db

Hi Michael,
Firstly, big thanks for this repo, using boto to send my emails is way easier than setting up a sendmail/postfix scenario.
Secondly, tiny suggestion, not even worth forking for it. This repo failed straight out of the box because the user table doesn't exist. Altering docker-compose.yml line:11 to
command: ash -c 'python manage.py create_db ; python manage.py run -h <IP_ADDRESS>'
fixes that.
KR,
Eoin

Apologies for the delay. I just updated the blog post, code, and README. Cheers!


[ATIP-android] add new step to enable or disable location service

-add new step to enable or disable location service
BUG=https://crosswalk-project.org/jira/browse/XWALK-4890

adapt for nexus and ZTE, verified on nexus.  @Honry please review it.

LGTM


Social_Media_Sidebar #issue68

Added Social Media Sidebar. And also centred the text.
Before:
After:

Done.

Done.


CropArea has NaN value, so the CropArea does not appear.

Describe the bug
when I open the modal the handleCropComplete calls and after multiple times that I open the modal I get {x: NaN, y: NaN, width:NaN, height: NaN } so the cropArea does not apears. and I should close the modal then open it again for appearing the cropArea.
To Reproduce
Steps to reproduce the behavior:

Go to 'Sandbox'

Expected behavior
CropArea should appear anytime I open the modal.

Hi Again
the problem was with animation of modal.


Support continued text content on attacks

Would be nice to recognize text in an attack description that starts with the , character to be a continuation of the default attack string that is created. An example would be as follows, where after the normal damage, there is an , and that follows the default text.
Bite. Melee Weapon Attack: +5 to hit, reach 5 ft., one target. Hit: 7 (1d8 + 3) piercing damage plus	9 (2d8) poison	damage, and target must make a DC 11 Constitution saving throw, taking 9 ( 2d8) poison damage on a failed save, or half as much damage on a successful one. If the poison damage reduces the target to 0 hit points, the target is stable but poisoned for 1 hour, even after regaining hit points, and is paralyzed while poisoned in this way.

Hmm, that's not a bad way of handling that case. I'll probably add this, I don't think it should be overly complicated, and I don't foresee any situation where someone would lead their description with a comma and want it to be preceded by a period. So it should be fine.

Hmm, that's not a bad way of handling that case. I'll probably add this, I don't think it should be overly complicated, and I don't foresee any situation where someone would lead their description with a comma and want it to be preceded by a period. So it should be fine.

I've verified that this works with your latest changes.

I think this feature is working as intended now?


App: sky shader

It should have a day/night cycle with a sun, stars, and possibly clouds (though we could use the clouds we already have, which workd great and are cheap to render as planes.
Here are some good starting shaders:
Horizon glow:
https://www.shadertoy.com/view/NsXyDN
Space clouds:
https://www.shadertoy.com/view/fdXyDN

The links above do not load

Are we happy with https://github.com/webaverse/skybox-anime? Seems nice, and could be extended it to have day/night + stars

Are we happy with https://github.com/webaverse/skybox-anime? Seems nice, and could be extended it to have day/night + stars

Yeah, I'm extending this one with a full day/night cycle. I think with the lighting being properly reflected the effect will be good and generally usable.

The links above do not load

The links were unpublished; I published them now.

Done.


New DMWM up-to-date workflow json templates

Fixes #8915

That's a good start. I might add a few more templates in the coming couple of months though.


Implement Firestore array operations

Fixes #2417
It's possible that we may want to be able to specify the same field twice in an Update call, but that's still TBD.
I've split this into separate logical commits - each should be relatively easy to review.

Thanks - nits fixed, rebased and force pushed. Will merge on green.


all: test Examples on wasm?

In #25913 we disabled testing of Example for js/wasm because it required os.Pipe, which js/wasm doesn't implement.
But disabling all those tests is slightly overkill.
This bug tracks restoring as many of those tests as possible.
/cc @neelance

Do you have any initial idea on how we could do this?

Options:

modify the testing package in js/wasm mode to use something besides os.Pipe
decide to implement some fd mapping anyway, enough for os.Pipe to work, at least in testing mode, even if it's not available and/or compiled in regular mode
implement os.Pipe in the node.js host (so it'll be available for tests, but not in browsers)

For reference, I added this support to GopherJS some time ago (See https://github.com/gopherjs/gopherjs/pull/590), by having the tests write to the filesystem, rather than to a Pipe. So was basically an implementation of @bradfitz's first suggestion.

I read the code that runs examples, and it just treats the two parts of the os.Pipe as ReadCloser and WriteCloser, and it doesn't leverage the fact that those are actual files.
The problem here is that it then replaces os.Stdout, and that must be an *os.File.
I think we could provide a dummy implementation of os.Pipe for wasm that creates two *os.File by just wrapping a call to io.Pipe() and returning a couple of partially functioning files.
Any invocation to methods that are not Write, Read or Close would just return an error and zero values, but that would still make most (if not all) examples work.
I did a quick grep around sources looking for examples that might break but it looks like this might work.
If this makes any sense I could try it out locally to see how many examples leverage the fact that os.Stdout is indeed an *os.File and report back or submit a CL if nothing breaks.

Alright, so since we've merged CL https://go-review.googlesource.com/c/go/+/165357 which uses os.File for js/wasm, I think the party can now start, with enabling example tests to run on js/wasm.


Feature/pass session attributes

This PR aims to enhance the functionality of our Lambda invocation process by including session details (sessionId and sessionAttributes) in the invocation payload. These changes allow downstream Lambda functions to access session-specific information.

Added sessionId and sessionAttributes as parameters to the invoke_lambda function.
Modified the payload in invoke_lambda to include sessionId and sessionAttributes.
Adjusted generate_query_lambda to extract and pass sessionId and sessionAttributes from the request to invoke_lambda.

One possible issue is that this change breaks backwards compatibility b/c it changes a method signature.  It would require changes to all the existing lambda functions in the plugins directory and break any plugins out in the wild.  Can we think of another way to do this?


let hash changes be handled by the router

Allow router to handle hash only changes in order to make browser (back) navigation to hash routes work.
Fixes https://github.com/sveltejs/kit/issues/821

Hmm. I'm not quite sure I understand the issue. If I go to https://kit.svelte.dev/docs, click a section in the lefthand side menu, click the github link at the top of the page, then click back, it still goes to the section I clicked on and has # in the URL
It's also interesting that it was explicitly disallowed before. I'd kind of want to know the reason for that. It might be helpful to find the change in Sapper that introduced that line

The issue only manifests itself if the second link (after clicking on the hash link) is also a route within the SvelteKit project. You can check the reproduction repository in #821 to confirm or alternatively run the tests that I added in 31e0e87 on the current implementation to confirm.

I still need to review this, but in the meantime can you add a changeset by running pnpx changeset?

maybe the right way to go about this, would be to choose to history.replaceState for hash only navigation? Not entirely sure what the desired behaviour should be.

Thanks for your patience on this PR. I finally got a chance to test it and I think it looks good as is. Can you rebase it? Then I think we can merge

thanks @benmccann for reviewing and rebasing!


OSx - Before executing any SuiteCloud command, SuiteCloud SDK dependencies need to be validated. Try again in a few seconds.

Hello guys!
I'm trying to use the VSCode Extension with OSX, but I'm not able to it:
The warning "Before executing any SuiteCloud command, SuiteCloud SDK dependencies need to be validated. Try again in a few seconds."
We have another closed thread related to it, but without solution.
Please, could you help with that?

Which OSX version do you have?
Version of VSCode?

@ekloneleuterio Can we have a quick screen sharing session to determine what's causing this?

I'm having the same issue

@ekloneleuterio Are you behind any proxy? Which OSX version do you have? Version of VSCode?

Hi @alii-gator !
No, I'm not behind any proxy.
I'm using MacOs Ventura 13.1
VsCode Version: 1.74.2 (Universal).
And yes, we also can have a screen sharing  . Thanks!

Unfortunately I am in the same boat! No proxy, Ventura 13.4, VSC 1.81.1 (universal)

Hello guys,
Please, double-check if your node is globally installed.
I had to reinstall it and set it as global
npm config set prefix '~/.npm-global'

Possible problem source
If your ~/.sutiecloud-sdk is owned by the root user, instead of your user, SuiteCloud Extension for Visual Studio Code won't be capable of storing the SutieCloud SDK dependencies properly, leading to original problem.
If that's the case, one possible solution is to change the ownership of the ~/.suitecloud-sdk folder to your user.
Possible problem origin
If at some point you have installed our SuiteCloud CLI for Node.js using sudo , there will be some permission problems later with the installation process of SuiteCloud Extension for Visual Studio Code.
The source reason is that your ~/.suitecloud-sdk folder will be owned by the root user if you did run sudo npm install -g @oracle/suitecloud-cli.
In order to avoid using sudo to install SuiteCloud CLI for Node.js, you can use @eklonsousa suggestion before performing the global npm installation.
So you could do:

npm config set prefix '~/.npm-global'
npm install -g @oracle/suitecloud-cli


Create shorter redirect link format for vulnerabilities

e.g. https://osv.dev/v/PYSEC-foo should redirect to the full https://osv.dev/vulnerability/PYSEC-foo.
This can help with osv-scanner's human readable output, where horizontal space is a premium.

The number of times I've tried and failed to use just osv.dev/id, could we support that for maximum URL brevity? Feels more intuitive.

Yeah that's certainly another possibility, just wonder if it creates any complexities in the future since it introduces potential routing clashes with other top level OSV.dev pages.

One observation: this doesn't work for aliases, and I wonder whether it could/should? In my opinion it would be much more delightful for our users if it did...
e.g. I can go the long way around to search for CVE-2013-5823, which turns out to be an alias for GHSA-8gwc-x7mg-7p7p, but I can't go to osv.dev/CVE-2013-5823 successfully.


Are read operations auditable or not

This page clearly states that READ operations CANNOT be audited in Dataverse.
This statement contradicts other documentation which states that READ operations CAN be audited.
https://docs.microsoft.com/en-us/power-platform/admin/audit-data-user-activity
https://docs.microsoft.com/en-us/power-platform/admin/enable-use-comprehensive-auditing
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 615ca336-51a5-7e55-a27a-cbfe38eaa2c6
Version Independent ID: 3b722c4a-a28c-c6a3-74b6-e16e49f66e14
Content: Auditing overview (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/auditing-overview.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @Bluebear73
Microsoft Alias: munzinge

@Customery I am doing some research now. Most likely, reads are supported. The developer docs were written when auditing of reads was not supported. I expect that has changed and the admin docs are correct.


feat: add deno bundle

Maybe. Probably.

Closing as "not planned" since the library can be used via Skypack or esm.run (see the docs).


Focus terminal before closing it

When using the toggle key it will check if the terminal is focused before closing it.
It is useful when you leave the terminal open and want to quickly go back to the terminal.
I actually check if the terminal is focused by looking at the cursor which is not the best way to check it, but I have not found another way to check if a terminal is focused

See also PR #218, where the focus triggering shortcut (ctrl + alt + F) is used to achieve the same effect.


Focused window is not retained among aux windows on restore

Testing #202923

Have a workspace with aux windows opened, and the main window focused
Close VS Code
Reopen the workspace
Notice that focus is given to the last opened aux window rather the main window

This is more noticeable when you have multiple windows that are overlaying each other

Yes, this is using text editors on Ubuntu
https://github.com/microsoft/vscode/assets/2230985/47fd0401-1ecc-4cf1-bd21-0e4403fb7c3e

Does this reproduce OSS?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


FileNotFoundError: [WinError 3] The system cannot find the path specified: 'c:\users\sex\desktop\env2\lib\site-packages\pvporcupine\resources\util\python\../../../resources/keyword_files\windows'

https://github.com/Picovoice/porcupine/tree/master/demo/python
porcupine_demo_mic.py --keywords picovoice


Noble for Yosemite

Verified every XPC message IDs, except the one for broadcast.

@DomiR Seems to have changed in El Capitan, are you running the beta by any chance / do you know where to look for the changes?


invoice creation with transports fails

Trying to create an invoice containing transport endpoints I get the following error:
InvalidInvoice { details: "invalid query parameter invalid transport .." }

The invoice string looks like:
rgb:RMLihGM-c1rQxBy5n-pkobrwMkL-4yXH6nGR9-HFHQKkqnw-mGbtez/RGB25/69+bcrt:utxob:2WdCeAu-MSNxt4ivz-H9BXHkGcv-fw1phiJ2v-JTHCdW9m1-5xJ8aqp?expiry=1705411284&endpoints=,rpc://<IP_ADDRESS>:3000/json-rpc

I guess that endpoints=,rpc://<IP_ADDRESS>:3000/json-rpc cannot be parsed because of the empty value before the comma and that this happens because RgbInvoiceBuilder::new() creates the RgbInvoice with transports set to vec![RgbTransport::UnspecifiedMeans], which is then rendered to an empty string.
The add_transport and add_transports methods just add the provided transport(s) to the vector, leaving the initial RgbTransport::UnspecifiedMeans in place.
I am not sure what the proper fix should be (i.e. removing the existing UnspecifiedMeans before adding new transports?).
@dr-orlovsky what's your idea about it?
Once we agree on a fix I can take care of the implementation and open a PR.

I think you are right about why this does happen.
Removing the existing UnspecifiedMeans before adding new transports should be the correct fix


Change java client MIN_BUFFER_SIZE to 1MB

I propose to reduce min buffer size to 1MB for java client.

Context:
In the java client, I noticed in the ByteBufferPool
object that there is a minimum buffer size of 8MB, why it's not possible to reduce size of th buffer ?
I'm working with a lot of smalls files (about 10 KB) in parallel, It makes my application "Out Of Memory" with 4G RAM allocated in xmx with G1GC.


Profile Tabs/Views

Add list view as an alternative to grid view in profiles in addition to the photo map (#59) and tagged photos.

Thanks for contributing to Ramme. I'll close this for now and focus on more requested features for now.


Also - The job type is remote for the "MB Solutions Key Account Manager" position

ENVIRONMENT: production
URL: https://peviitor.ro
Browser: Safari
Device: Laptop
OS: macOS 14 Sonoma
STEPS TO REPRODUCE:

Open URL in browser
Type "Also" in the search bar
Click on "Cauta"
Right-click and select "Inspect"
Copy the Request cURL: https://api.peviitor.ro/v3/search/?company=also&country=România&page=1
Open Postman and create a new entry with GET request
Click on "Send"

EXPECTED RESULT:
The GET request should return a response with a status of 200 OK and information related to job openings retrieved from the API response should match the information related to job openings listed on the official website of Also and on the peviitor.ro website.
ACTUAL RESULT:
The job type from the API response doesn't reflect the job type from the Also website: the job type is remote.

Fixed

fixed


Pushed entities get caught on items on the ground

You cannot push a locker over a bullet casing, for example.
Also- they get caught on light fixtures.

Looking at this

This is fixed

Fixed by #785


Change the fix-up for dispatch_apply() to refer to the correct replacement.

Also change from "renamed" to "message" because concurrentPerform(iterations:execute:) has different arguments than dispatch_apply(), so Xcode does not handle the conversion properly.
Radar: rdar://problem/34162804.

Seems fine to me.

@swift-ci Please smoke test


Error: $interpolate:interr

When I .field() in createView() or editView() I get this error:
Error: [$interpolate:interr] Can't interpolate: row-{{ field.name() }}
TypeError: v2.name is not a function
http://errors.angularjs.org/1.4.1/$interpolate/interr?p0=row-%7B%7B%20field.name()%20%7D%7D&p1=TypeError%3A%20v2.name%20is%20not%20a%20function
    at angular.js:68
    at Function.$interpolateMinErr.interr (angular.js:10579)
    at interpolationFn (angular.js:10854)
    at attrInterpolatePreLinkFn (angular.js:8525)
    at invokeLinkFn (angular.js:8642)
    at nodeLinkFn (angular.js:8121)
    at compositeLinkFn (angular.js:7534)
    at nodeLinkFn (angular.js:8137)
    at compositeLinkFn (angular.js:7534)
    at compositeLinkFn (angular.js:7538)

and this error:
Error: [$interpolate:interr] Can't interpolate: {{ field.name() }}
TypeError: v2.name is not a function
http://errors.angularjs.org/1.4.1/$interpolate/interr?p0=%7B%7B%20field.name()%20%7D%7D&p1=TypeError%3A%20v2.name%20is%20not%20a%20function
    at angular.js:68
    at Function.$interpolateMinErr.interr (angular.js:10579)
    at interpolationFn (angular.js:10854)
    at attrInterpolatePreLinkFn (angular.js:8525)
    at invokeLinkFn (angular.js:8642)
    at nodeLinkFn (angular.js:8121)
    at compositeLinkFn (angular.js:7534)
    at nodeLinkFn (angular.js:8137)
    at compositeLinkFn (angular.js:7534)
    at nodeLinkFn (angular.js:8137)

for every field I add. However this doesn't happen when I use my own template fields (via my directives).
Everything works fine and it doesn't break any code (as far as I know) but it still bothers me...

Could you share your config?

https://www.dropbox.com/s/wgbeu4rt9qvt2yf/admin.js?dl=0

I can't see anything wrong in your configuration. However, what is your v2 mentionned in your error message?

I didn't use v2 variable in any of my code. I think this is angular's variable...
Anyway here is my bower.json if it helps (probably not...)
{
  "name": "assets",
  "version": "0.0.0",
  "dependencies": {
    "angular": "^1.3.0",
    "bootstrap": "^3.2.0",
    "angular-animate": "^1.3.0",
    "angular-cookies": "^1.3.0",
    "angular-resource": "^1.3.0",
    "angular-route": "^1.3.0",
    "angular-sanitize": "^1.3.0",
    "angular-touch": "^1.3.0",
    "ng-admin": "~0.7.0",
    "underscore": "~1.8.3",
    "angular-underscore": "~0.5.0",
    "notifyjs": "~0.3.2",
    "angular-ui-router": "~0.2.15",
    "ladda": "~0.9.8",
    "angular-ladda": "~0.2.2"
  },
  "devDependencies": {
    "angular-mocks": "^1.3.0"
  },
  "appPath": "app",
  "moduleName": "assetsApp"
}

Can you try with the latest version of ng-admin, using dev-master version? You are indeed using dashboard configuration, which is not available in 0.7. I think you based on master documentation using an older version of our lib. :)

I'm getting this same error with version 0.7.0

Hey @jpetitcolas any update on this? The error is happening on 0.7.0

I have just created a pull request for this. Replacing calls to field.name() to field.label() in  src/javascripts/ng-admin/Crud/field/maField.js resolved the issue

I finally succeeded in getting this error. It is indeed an issue with Angular version. To reproduce it, you have to embed Angular.js before the ng-admin one:
<script src="bower_components/angularjs/angular.min.js"></script>
<script src="bower_components/ng-admin/build/ng-admin.min.js"></script>

Looking at it.

As this is an Angular 1.4 related issue, I am closing this ticket and opening a new one dedicated to 1.4 migration. We are going to make the 1.4 the default supported version in 0.8.


Allow Access from Azure Portal checkbox

When using powershell to add Virtual Networks to Cosmos DB.
checkbox "Allow access from Azure Portal" gets disabled. Is  there a way to enable it as part of added virtual networks.
Powershell command i am using to add networks
Update-AzCosmosDBAccount    -ResourceGroupName $resourceGroupName
-Name $accountName    -EnableVirtualNetwork $true
-VirtualNetworkRuleObject @($vnetRule)

@RavulaChetan Thank you for your feedback! Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.
The best place for specific answers about implementations are going to be the Microsoft Q&A and Stack Overflow forums. We actively look through posts in the forums, and will do our best to get you going in the right direction!

Just checking in. Could you please provide the relevant documentation so we can route this question appropriately?

Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


NameError: name 'ip' is not defined

Can someone suggest a fix for this?
Traceback (most recent call last):
File "cloudflare-origin-ip.py", line 559, in
grabber_securitytrails( domain )
File "cloudflare-origin-ip.py", line 275, in grabber_securitytrails
if not ip in t_ips:
NameError: name 'ip' is not defined

Same on Python 3.8

same

I have the simple fix here: https://github.com/gwen001/cloudflare-origin-ip/pull/16


add installation instructions for ubuntu

Installing libgtk-3-dev avoids the following error:
error: failed to run custom build command for `pango-sys v0.3.3`
process didn't exit successfully: `/home/nmaris/my/unversioned/systemd-manager/target/release/build/pango-sys-39580209d38ba701/build-script-build` (exit code: 1)
--- stderr
`"pkg-config" "--libs" "--cflags" "pango >= 1.34"` did not exit successfully: exit code: 1
--- stderr
Package pango was not found in the pkg-config search path.
Perhaps you should add the directory containing `pango.pc'
to the PKG_CONFIG_PATH environment variable
No package 'pango' found

warning: build failed, waiting for other jobs to finish...
error: build failed
Makefile:6: recipe for target 'all' failed
make: *** [all] Error 101

According to the error message, it seems sufficient to install libpango1.0-dev.


Replace useless(?) Function constructor

https://github.com/nknorg/nkn-client-js/blob/fd88803667b1f93532a7a6eb945a695375ab4683/lib/protocol/payloads_pb.js#L12
Please replace that line with.. say, var global = window;, as it is the same thing. It causes Firefox to go crazy over CSP. That would save me, and probably others, some headache with browserify and whatnot.
same thing https://github.com/nknorg/nkn-client-js/blob/master/lib/protocol/messages_pb.js#L12

This is autogenerated code by protobuf: https://developers.google.com/protocol-buffers/docs/reference/javascript-generated

should replace it anyways, if you ask me. Or maybe they have a method of generating it without function eval

What problem are you getting into exactly? Typically modifying generated pb code is not a good way...

Run this lib through browserify and you'll get a CSP error on Firefox, because of those 2 lines.

#44 should solve this issue

Works, and I have an improvement.
doing the transformation in Gruntfile.js, move it into package.json, so that when I do require('nkn-client'), my browserify will know what to do, too. (So I won't need to explicitly use the dist files which makes life a bit easier).
like this:
"browserify": {
  	"transform": [
  		["browserify-replace",
			{
				"replace": [{
					"from": "var global = Function\\('return this'\\)\\(\\);",
					"to": "var global = (function(){ return this  }).call(null);"
				}]
			}
		]
  	]
  },

Thanks! Merged your PR.


Unable to create florasAndFaunas

Fails to save florasAndFaunas while some or all fields are filled.
Error Message
Invalid input data, please verify unique constraints

@lespaceman Checking

This issue is fixed please check now.


Not all subscriptions appear on VSCode Resources. Why?

Does this occur consistently?
Repro steps:

Version: 0.6.1
OS: win32
OS Release: 10.0.19045
Product: Visual Studio Code
Product Version: 1.76.1
Language: en

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!