Supporting typescript decorators

It seems like the library missing a quicker &  safe way to register providers, which is using Typescript Decorators;
The code below should register a service class to an Array of providers
import { Provider } from "react-service-container";

export const RootServices: Provider<any>[] = [];

export function RootService(target: Provider<any>) {
  RootServices.push(target);
}

@RootService
class Greeter{
  greet() {
    return 'Greeting';
  }
}

In the index.tsx file the services should be provided in this way so you can define all your service classes without the need to directly add them in the index.tsx file
import { RootServices } from './root-service';

ReactDOM.render(
  <React.StrictMode>
      <ServiceContainer providers={[...RootServices]}>
        <App />
      </ServiceContainer>
  </React.StrictMode>,
  document.getElementById('root')
);

But by doing that you will get a message error saying Could not find provider for token class xxx. Think of this as a "missing variable" error. Ensure that in one of your parent service containers, you have configured your providers array to provide a value for this type.
The only way to fix this issue is by importing the actual service class even if not inside the providers array but that takes the power of using decorators, just like this:
import { RootServices } from './root-service';
import { Greeter} from './services/greeter';
const whatever = [
  Greeter,
];
ReactDOM.render(
  <React.StrictMode>
      <ServiceContainer providers={[...RootServices]}>
        <App />
      </ServiceContainer>
  </React.StrictMode>,
  document.getElementById('root')
);

Thanks for opening this discussion!

In the index.tsx file the services should be provided in this way so you can define all your service classes without the need to directly add them in the index.tsx file

I'm not sure how the library could support what you want it to support given that typescripts decorators are evaluated at runtime, vs. at compile-time.
Consider this example, which is similar to your code above:
const services: any[] = [];

function Register(value: any) {
    console.log(value);
    services.push(value);
    return value;
}

function fakeImport(): any {
    @Register
    class Foo {}

    return Foo;
}

// Comment out the next line and see what happens
const Foo = fakeImport();
console.log('services:', services);

Notice how if I take out fakeImport(), the @Register function is never called, and the services array is never populated. I believe that's what's happening in your example. It seems like you are trying to use the RootServices array without first importing the Greeter code (I wonder if this is part of the reason why Angular makes you declare your service and component exports up-front when defining a module?).
To be honest I considered a decorator approach, but I opted to go without it because:

They're inherently more complex / opaque than plain old functions
They don't seem to be used as often in the react community
For non-TS environments, it would preclude their use.

WDYT?

closing due to no activity/follow up


Keep Flutter.framework binaries writable so they can be code signed

Description
Flutter.framework files were made read-only to "Provide a strong hint to developers that editing Flutter framework headers isn't supported" (https://github.com/flutter/flutter/commit/cb2b89c389e06c2cceb1a3361d520eaccb4cec8c)  However this is making the Flutter binary readonly, which is being copied into the final embedded Frameworks directories, then can't be codesigned.
Only make headers, modulemaps, and plists readonly.
$ find Flutter/Flutter.framework -type f \( -name '*.h' -o -name '*.modulemap' -o -name '*.plist' \)
Flutter/Flutter.framework/Headers/FlutterEngine.h
Flutter/Flutter.framework/Headers/FlutterChannels.h
Flutter/Flutter.framework/Headers/FlutterPlugin.h
Flutter/Flutter.framework/Headers/FlutterAppDelegate.h
Flutter/Flutter.framework/Headers/FlutterTexture.h
Flutter/Flutter.framework/Headers/FlutterPlatformViews.h
Flutter/Flutter.framework/Headers/FlutterHeadlessDartRunner.h
Flutter/Flutter.framework/Headers/FlutterCodecs.h
Flutter/Flutter.framework/Headers/Flutter.h
Flutter/Flutter.framework/Headers/FlutterViewController.h
Flutter/Flutter.framework/Headers/FlutterMacros.h
Flutter/Flutter.framework/Headers/FlutterDartProject.h
Flutter/Flutter.framework/Headers/FlutterPluginAppLifeCycleDelegate.h
Flutter/Flutter.framework/Headers/FlutterBinaryMessenger.h
Flutter/Flutter.framework/Headers/FlutterCallbackCache.h
Flutter/Flutter.framework/Modules/module.modulemap
Flutter/Flutter.framework/Info.plist

Related Issues
Fixes https://github.com/flutter/flutter/issues/39507.
Another attempt at https://github.com/flutter/flutter/pull/39539.
Tests
add2app gets past codesigning for me, but it's still flaky so I didn't turn it back on.  See https://github.com/flutter/flutter/issues/40173.
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

[ ] Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

hi @jmagman , I think the stable branch need this PR too, related issue #40146

hi @jmagman , I think the stable branch need this PR too, related issue #40146

Hi @yrom! You must be on the master channel to use Flutter modules since they are still an experimental feature. If you could flutter update and test this change, it would be greatly appreciated!

hi @jmagman , I think the stable branch need this PR too, related issue #40146

Hi @yrom! You must be on the master channel to use Flutter modules since they are still an experimental feature. If you could flutter update and test this change, it would be greatly appreciated!

Means that the stable version under the existing app mixture is unable to use? My god！

hi @jmagman , I think the stable branch need this PR too, related issue #40146

Hi @yrom! You must be on the master channel to use Flutter modules since they are still an experimental feature. If you could flutter update and test this change, it would be greatly appreciated!

Means that the stable version under the existing app mixture is unable to use? My god！

You can see the caveats here: https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps#intro

The "add-to-app" support is in preview, and is so far only available on the master channel.

Since Flutter's "Add-to-App" functionality is in preview, the associated APIs and tooling are not stable and are subject to change.

hi @jmagman , I think the stable branch need this PR too, related issue #40146

Hi @yrom! You must be on the master channel to use Flutter modules since they are still an experimental feature. If you could flutter update and test this change, it would be greatly appreciated!

Means that the stable version under the existing app mixture is unable to use? My god！

You can see the caveats here: https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps#intro

The "add-to-app" support is in preview, and is so far only available on the master channel.

Since Flutter's "Add-to-App" functionality is in preview, the associated APIs and tooling are not stable and are subject to change.

but  run  flutter build ios, the same error!

hi @jmagman , I think the stable branch need this PR too, related issue #40146

Hi @yrom! You must be on the master channel to use Flutter modules since they are still an experimental feature. If you could flutter update and test this change, it would be greatly appreciated!

Means that the stable version under the existing app mixture is unable to use? My god！

You can see the caveats here: https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps#intro

The "add-to-app" support is in preview, and is so far only available on the master channel.

Since Flutter's "Add-to-App" functionality is in preview, the associated APIs and tooling are not stable and are subject to change.

but run flutter build ios, the same error!

$ flutter build ios

Building com.mtd.iosFlutterModule for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: BB535CKPZQ
Running Xcode build...

Xcode build done.                                           11.2s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    /Users/oheroj/Desktop/TN/flutter_module/build/ios/Release-iphoneos/Runner.app/Frameworks/Flutter.framework: replacing existing
    signature
    /Users/oheroj/Desktop/TN/flutter_module/build/ios/Release-iphoneos/Runner.app/Frameworks/Flutter.framework: Permission denied
    Command CodeSign failed with a nonzero exit code
    note: Using new build systemnote: Planning buildnote: Constructing build description

@jmagman yep, our team were working with this 'experimental feature' in the stable branch and bring it to our online app on previous stable version (v1.7.8). 😂And we will apply this PR  to our inner fork version. thx.

@jmagman yep, our team were working with this 'experimental feature' in the stable branch and bring it to our online app on previous stable version (v1.7.8). 😂And we will apply this PR to our inner fork version. thx.

hello，If 1.9 stable continue to have a hotfix, the inner fork verion merge this hotfix branch?


[FEATURE] IRC channel / Gitter channel / Slack channel

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I just thought that it would be lovely if we had some access to a chatting platform like an IRC channel or gitter, and a link to said platform in the documentation

+1
Le mar. 26 mars 2019 à 10:38 AM, Carlos Gomez<EMAIL_ADDRESS>a
écrit :

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I just thought that it would be lovely if we had some access to a chatting
platform like an IRC channel or gitter, and a link to said platform in the
documentation
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/111, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDZPpjsoBSBNS8Z06NyKBTxV9pbkckXks5vaeqWgaJpZM4cK-_6
.

+1

Hey guys! Interesting idea. I didn't think there would be enough interactions to justify it, but I'm pleased to say you proved me wrong :)
I'm thinking about setting up an official channel there linked to this repo.
But fastapi is taken. What do you think would be a good name?

python-fastapi
tiangolo-fastapi
something else?

tiangolo-and-fastapi-rock

On Wed, Mar 27, 2019 at 6:36 PM Sebastián Ramírez<EMAIL_ADDRESS>wrote:

Hey guys! Interesting idea. I didn't think there would be enough
interactions to justify it, but I'm pleased to say you proved me wrong :)
I'm thinking about setting up an official channel there linked to this
repo.
But fastapi is taken. What do you think would be a good name?

python-fastapi
tiangolo-fastapi
something else?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/111#issuecomment-477271729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDZPtQesw5fVbpnix1sZp2v6Wl59r5zks5va6wtgaJpZM4cK-_6
.

--
benoit barthelet
http://pgp.mit.edu/pks/lookup?op=get&search=0xF150E01A72F6D2EE

Maybe
async-fastapi
fastapi-io
On Wed, Mar 27, 2019 at 1:38 PM euri10<EMAIL_ADDRESS>wrote:

tiangolo-and-fastapi-rock

On Wed, Mar 27, 2019 at 6:36 PM Sebastián Ramírez <
<EMAIL_ADDRESS>wrote:

Hey guys! Interesting idea. I didn't think there would be enough
interactions to justify it, but I'm pleased to say you proved me wrong :)
I'm thinking about setting up an official channel there linked to this
repo.
But fastapi is taken. What do you think would be a good name?

python-fastapi
tiangolo-fastapi
something else?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/111#issuecomment-477271729,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABDZPtQesw5fVbpnix1sZp2v6Wl59r5zks5va6wtgaJpZM4cK-_6
.

--
benoit barthelet
http://pgp.mit.edu/pks/lookup?op=get&search=0xF150E01A72F6D2EE
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/111#issuecomment-477272539,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEa15yqrZ5mnOotA-EMqw1qvEE-CFsQGks5va6yXgaJpZM4cK-_6
.

--
Kyle Hamlin

:joy: hehehe thanks @euri10 !
Also, as of now, you get the badge of most active FastAPI community member :muscle: :star2: :medal_military:

Thanks for the ideas @Mokubyow !

python-fastapi

python-fastapi agree with @wshayes

Done! :tada:

I discovered it is possible to have the same URL path as in GitHub, and it's also quite common (e.g. hug, isort, gunicorn, etc). So I used that one.

Thanks for the idea @Kurolox ! It clearly was a great idea, there's a very helpful and healthy community growing every day, and the chat has proven to be very useful, making the communications easier and fluid. :tada: :cake:
I'll then close this issue now. But feel free to add more comments or create new issues.

Hey guys, so you finally didn't create an IRC channel at freenode? I've just tried #fastapi and #python-fastapi and nobody was there... Well, actually... at #fastapi there was 1 guy :)

use gitter
https://gitter.im/tiangolo/fastapi


RobiniaDocs API Explorer

Maybe You will be interested in hosting API Explorer online:

https://www.robiniadocs.com/d/fluentseri/api/FluentSerializer.Json.Converting.Converters.html

Hi, these kinds of tools are very useful for proprietary SDKs and APIs.
However, for this library we've chosen to keep the documentation close to the code by providing readme's and markdown files in the repo itself
We appreciate the suggestion. But, at this point in time we have no intention to host any kind of documentation elsewhere.
Thanks for suggesting though.


Make max versioned_list length configurable

In cleanup.yml there is a task named Remove extra files from app directroy which removes app versions when the number is greater than 10.  Currently, 10 is hard coded.  We need to make this configurable.

Maybe also fix the typo on directroy

This issue affected the Reveal-frontend deployment last week where the server ran out of space and we had to manually delete some of the old app versioned directories

closed #14


Introduction to the content in the README

Add a very brief introduction in the README.

[x] What is OMERO, ARC, REMBI, Neuroglancer?
[x] Also align with description for submission.

fixed in #40


Funny modchart

What is your question?
im tryna do some funny modchart heres a screenshot:

stop posting useless issues

imma just wait until shadowmario closes this


Tray tooltip uses incorrect scaling on HDPI screen

Environment

Item
Value

OS, Version / Build
Microsoft Windows [version 10.0.19042.804]

Processor Architecture
x64

Processor Type & Model
core i5

Memory
8Gb

Storage Type, free / capacity (e.g. C: SSD 128GB / 512GB)
SSD 256Gb

Relevant apps installed
___

Description

The tooltip of tray icons is way to small and appears to use incorrect scaling on HDPI screens.
Steps to reproduce

I have a Surface Book (which has a HDPI screen). I plugged it into a Surface Dock with an external Full HD monitor. I then disabled the external monitor.
Expected behavior

Tray tooltip should use the correct scaling.
Actual behavior

After re-starting the explorer.exe process from the Task Manager, the correct scaling is used again:

Feedback hub link: https://aka.ms/AAb7iso

PS: you can also notice how the Surface Book's attach icon (the one right to the sound icon) is also blurry on the first screenshot. But I already created an issue for that a long time ago.

I see it every time when switching to another user without attaching extra monitor.

@warpdesign Thanks for filling! Unfortunately, this is not a performance related issue and so it will be closed with the reason "out of scope". I have reached out to the Taskbar team so they're now aware of the issue and will be exploring. I've also gone ahead and upvoted the issue on Feedback Hub.


Open RobotJS in seperate environment

Sorry this is a very specific problem, I want to run RobotJS on my (Linux) desktop without seeing it or having my mouse move. Basically running it in a separate environment... I tried with xvfb where the instance is hidden but the mouse is trying to click on things that are not there.
Any ideas or suggestions? :bulb:

Check #267


Global configure on notifier() call not working.

Second, specify it during the notifier() call or in configure():
notifier.success("The number of meetings you have next week:  ", {
  position: "top-right",
  autoClose: 10000
});

The above code doesn't override the global configure object. Toaster still closes after 3 seconds.

Hello @sushmitg ,
As Alex seem busy and not responding anything, i have checked your issue and it is no longer valid in latest version.
Futhermore
i have created a fork of this repo and maintaining it with name "simple-react-notifications2"
https://github.com/rizwan-ishtiaq/simple-react-notifications2
you can use this to get latest version from npm and report any bugs if you find something in future


'UILayoutPriorityDefaultLow' has been renamed to 'UILayoutPriority.defaultLow'

In Swift 4.
After pod install, appear this error:
'UILayoutPriorityDefaultLow' has been renamed to 'UILayoutPriority.defaultLow'
CircularProgressView.swift

configureImageView()
height.priority = UILayoutPriorityDefaultLow

Thanks @haroldogtf. I'll update this pod for Swift 4

Release 1.0.2 supports Swift 4


Add TableLayout to explain plans

Can you add an example of what the output looks like to the commit message?
Looks good.


Update FAQ answer

Resolves https://github.com/h2oai/h2o-llmstudio/issues/340

@pascal-pfeiffer Sorry, that was unintentional. I have added it back.
Also added in the link to the LLM Data Studio blogpost and removed a broken tooltip reference to a tooltip that had been removed with this PR.


Feature Request: Cache for IQuery and ICommand results

Would be nice to have the results from IQuery<T> and ICommand<T> cached automatically.
Caching Providers: In-Memory, Redis and Memcached

I understand why do you want to cache a query result but I'm not totally sure this is a feature I want to add to silverback out of the box.
For the commands, I don't see the point. A command represents an action that must be executed in order to produce a side effect, you cannot just skip it and return its cached result. Do you see what I mean?

Yes, I don't have any use case to cache an ICommand at the moment, just thought it would be useful to someone, as the implementantion would match the IQuery interface and should be trivial. I could elaborate some use cases for cached ICommand, but I don't think it's really necessary too.

Could you elaborate a bit more on the concrete use cases where do you see this feature as useful?

I have to cache queries from some services for a determined amount of time, those queries are high cpu bound and some high time consuming.

As a side note, Silverback is extensible in many ways and you can implement such cross-cutting concerns via a behavior.

Thanks for your sample, I already implemented something like yours using Behaviours, it solves my demand, but I think cache for queries are a use common, and would be nice to have a default implementation. Maybe a new ICachedQuery, with some properties to define the cache key and cache time.
If you don't want this feature out of the box on Silverback, keeping it lightweight, totally understandable, it's already flexible and a great library.
Thanks!


Adaptive log range

Resolves #776. If we start getting this error even when requesting logs for a single block, we should re-evaluate in a new issue.
The first thing this does is have ETHEREUM_FAST_SCAN_END affect the block stream as a whole, we now multiply ETHEREUM_BLOCK_RANGE_SIZE by 10 if doing a fast scan. The one-size-fits-all nature of these values can be an issue, I also added a special case to go one block at a time if there are unconditional block triggers. We should at some point change the way we control the amount of triggers processed at a time.
The adaptive logic for log ranges first tries requesting the entire given range, if that doesn't work the step is reduced on each failure until we no longer get the 1000 logs error.
And then there are some refactors along the way.

@yanivtal Yes, it's specific to Infura.

Review addressed. This will help with slow syncs, but I've seen subgraphs quickly drop to a range of 10 blocks. Bringing parallel log requests back will probably be worth it.

Are we not doing parallel log requests anymore?
Another thought: How soon do we go back to the configured block range size? If we have a block range size of 10,000 and we have to reduce the range size to 5 to get past the first block in this range, does that mean we stick to a range size of 5 for the remaining 9,999 blocks?

Are we not doing parallel log requests anymore?

No, we dropped it in the block triggers PR. I was ok with that since it could complicate making this change which we need quickly, but we should bring it back with adaptive ranges in mind.
Yes, that's right. We can try to increase the range more often, but there is a tradeoff where in one extreme we keep the low range forever and in the other extreme we start from the large range every time.


[Feature Request] Command Prefix → Support for Repeated Letters

Hello @tadashi-aikawa !!!!
I am struggling to implement a workflow related to the feature Command Prefix that I would like to share with you.

I am gonna try to explain in my own words, please let me know if something is not clear 🙏
MY WORKFLOW
I am gonna use a simple example to explain this...
My worklfow is to navigate between some AQS modal using Recent Search as a starting point and then going to others AQS Modals using the feature Command Prefix as a hotkey.
AQS Modals
1⃣ Recent Search
⦿  Hotkey CMD+]
⦿  Command Prefix EMPTY
2⃣ File name search
⦿  Hotkey EMPTY
⦿  Command Prefix ]
3⃣ Landmark search
⦿  Hotkey EMPTY
⦿  Command Prefix ]]
4⃣ Star search
⦿  Hotkey EMPTY
⦿  Command Prefix ]]]
Hotkey Navigation
⚙ Starting Point → CMD+]
⚙ Next Modal 1 → Hit ]
⚙ Next Modal 2→ Hit ]]
⚙ Next Modal 3→ Hit ]]]
💡This navigation in important because after I hit CMD+] to open the first AQS Modal, my right hand is already placed in the key ] .
💡This way, I just have to hit ] again, again and again to be able to open different AQS Modals
💡 It's fast  and let me create groups of AQS modals to blue able to fast switch between notes.
THE PROBLEM
When I tried to implement this workflow, I face an issue with the Command Prefix text field.
Command Prefix text field does not recognize AQS Modals that has repeated letters. this way, I couldn't complete my navigation routine:
✅1⃣ Recent Search
⦿  Hotkey CMD+]
⦿  Command Prefix EMPTY
✅2⃣ File name search
⦿  Hotkey EMPTY
⦿  Command Prefix ]
❌3⃣ Landmark search
⦿  Hotkey EMPTY
⦿  Command Prefix ]]
❌4⃣ Star search
⦿  Hotkey EMPTY
⦿  Command Prefix ]]]
After hitting Command Prefix ] I was not able to get the next AQS Modal when hitting Command Prefix ]]
MY FR
All said, my FR is about changing the behavior of the Command Prefix to be able to recognize repeat letters 🙏🙏🙏

Thank for reading this !!!!
I hope it is an feasible change 🙏
I really hope you like my FR this is an important piece if my workflow I have a set of 5 groups of AQS modals that will be triggered from different starting points hotkeys 🙏🙏🙏
Thanks for reading this @tadashi-aikawa I wish you a fantastic day ☀

Hi, @FelipeRearden :)
It would work as you expected if you sort commands as followings.

4⃣ Star search
3⃣ Landmark search
2⃣ File name search
1⃣ Recent Search

Could you please give it a try?

Hi, @FelipeRearden :)
It would work as you expected if you sort commands as followings.

4⃣ Star search
3⃣ Landmark search
2⃣ File name search
1⃣ Recent Search

Could you please give it a try?

Hello @tadashi-aikawa !!!!
Let me explain more about this .... to make sure we are on the same page...
I use the standard AQS Modals (Star search, Landmark search, File name search, Recent Search) as an EXAMPLE to explain my FR. It is easier to explain this way :)
My real workflow for this are CUSTOM AQS Modals created by me to navigate inside my Folder structure :)
If you create new AQS Modals and apply the command prefix criteria that I described above, you will see that we cant use  repeated letters as Command Prefix.
Does it happens on your end as well ?
Thanks for the reply, this is an important FR for me  🙏🙏🙏

⚠ UPDATE  ⚠
@tadashi-aikawa I applied the rule described from you in TWO Groups of my Custom AQS Modals and it worked perfect !!!!!
The Rule of Thumb here is to let the first letter in the end .... for example:
AQS Modals ORDER...
4⃣ Custom Modal 4
⦿ Hotkey EMPTY
⦿ Command Prefix ]]]
3⃣ Custom Modal 3
⦿ Hotkey EMPTY
⦿ Command Prefix ]]
2⃣ Custom Modal 2
⦿ Hotkey EMPTY
⦿ Command Prefix ]
1⃣ Custom Modal 1 (starting point)
⦿ Hotkey CMD+]
⦿ Command Prefix EMPTY

In other words ... applying these rule solved the issue related to this FR. Feel absolutely free to close this issue.
Thank you very much for the help, I am very very very happy to be able to implement this workflow.
I wish you a fantastic day ☀

@FelipeRearden
I’m glad to hear that!
This issue is not about 'the same characters repeating', but 'which condition gets the highest priority when there are multiple matching prefixes'. The one that appears first gets the highest priority."

@FelipeRearden
I’m glad to hear that!

💙

This issue is not about 'the same characters repeating', but 'which condition gets the highest priority when there are multiple matching prefixes'. The one that appears first gets the highest priority."

Thanks for the info @tadashi-aikawa . 100% understood I am gonna follow this rule when creating my AQS Modals
Have a great day ☀


Modal widget

[x] Modal::class
[ ] ModalCard::class ?
[ ] ModalPluginAsset::class ?

This modal component has two visual interfaces, does it make sense to divide it into two classes? I think yes. What do you think?

By the looks of it, yes. It makes sense,

@samdark https://github.com/yiisoft/yii-bulma/pull/20#discussion_r531239012


Inf 1816 directional pools

this is more than just directional pools=(

it would be nice to have a link in the README.md to the generated doc at https://godoc.org/github.com/Ensighten/udnssdk

this branch has been merged with what's in #4


[SPARK-49485] Fix speculative task hang bug due to remaining executor…

… lay on same host

What changes were proposed in this pull request?

Modify ExecutorAllocationManager calculates maxNeeded logic.If remaining executors on a same host and pending speculativeTasks exists and will not execute addExecutor later, exclude current host, makes maxNeeded equal numExecutorsTarget + 1 to ensure addExecutor will execute later.Then the speculative task will launch and start.
Just run the follow job on a yarn cluster with one host and the bug will report.
`object SpecHangJob {
def main(args: Array[String]): Unit = {
val spark = SparkSession.builder.appName("rss_test").enableHiveSupport().getOrCreate
val sc = spark.sparkContext
val conf = sc.getConf
val taskNum = conf.getInt("spark.test.parallelism", 3)
val seq = (0 until taskNum).toList
sc.parallelize(seq, taskNum).map(
  i => {
    if (i == 0) {
      try {
        Thread.sleep(1000 * 60 * 30)
      } catch {
        case exception: Exception => println(exception.getMessage)
      }
    } else {
      try {
        Thread.sleep(1000 * 30)
      } catch {
        case e: Exception => println(e.getMessage)
      }
    }
    "haha"
  }
).collect()}}

`
Why are the changes needed?

Because if the host has problem and tasks on it keep not finished, in this case speculative task will not start any more, make job run time longer than expect.
Does this PR introduce any user-facing change?

No
How was this patch tested?

By adding a unit test mocking remaining executors lay on same host.And feature makes speculative task start
Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang hello, would you please take a look at this pr?thanks

I think @mridulm and/or @tgravescs might have some context.

I find that sometimes a job cannot schedule a speculative task and if i exclude the only remaining host, the job will fail because resource pending and all existing executors are blacklisted.So i commit
https://github.com/apache/spark/pull/47949/commits/d45eed7a371d7806a06aeeb50982ede3d7479746 to fix it.If no pending speculative left(maybe stage finish or regular task finish), revive the host and let new tasks can launch on it when it‘s difficult to ask for new executors due to resource pending.
Hope your attention thanks cc @HyukjinKwon @mridulm @tgravescs


Correct behaviour of chrome on "Relaunch" after version upgrade

I gave a spin to Carlo on mac (with latest chrome version 70+) and it worked perfectly.
I also built the binary systeminfo-app-win.exe for windows and tried running the same.  Turned out my windows chrome version wasn't upgraded to 70+ so I went to chrome://settings/help and could see the newer version being upgraded... Now after the completion, I was provided with the "Relaunch" button.
Now I click this relaunch button (while systeminfo-app-win.exe running in the background), chrome restarts but the version is not yet changed as there is a running instance of the chrome through the carlo app systeminfo-app-win.exe.
Question: How should this be handled and should the carlo apps be informed about the relaunch is being triggered?

System update problem


sanity check for node_id

if node_id contains invalid characters then the script stop working

Not generating for "strange" node_ids is obviously suboptimal. What exactly causes what to stop? Can we fix it by replacing "strange" characters?

Characters like : stops working the script. You can inject code with the node_id therefore replacing characters are not needed because this should only prevent errors.

Please don't use non-alphanumeric characters in your node id (I have changed my mind about this, in case you're reading older issues about this topic). This is a won't fix.

You wont fix a possible secuity issue? Everyone can break this script by send bad node_ids.
Maybe i blog a warning about this problem so we dont need to fix this if everyone knows about it?

Well, I may accept a PR that simply rejects nodes with invalid data. This PR, however, introduces some strange undocumented behaviour that may cause more trouble than harm.
This would be the right place to implement it:
https://github.com/ffnord/ffmap-backend/blob/master/lib/validate.py

Thanks, i just push another PR with proper implementation :)


Side navbar enhancement

Is your feature request related to a problem? Please describe.
Some font size and family has to be changed for the side navbar
Describe the solution you'd like
Current Behaviour

Expected Behaviour

Note: After Hello, the user's name should be dynamic
Describe alternatives you've considered
No response
Additional context
No response

Hey @Kanika637. Can I work on this issue?

Hey ,please assign this issue to me

Hey @Shivam-Katare, since you are already working on a current issue. So assigning the issue to you @Jasleen-001 🚀

Hey @Shivam-Katare, since you are already working on a current issue. So assigning the issue to you @Jasleen-001 🚀

Okay. Sure.

Any updates @Jasleen-001 ?

can you assign this to me

hey @Kanika637, i can work on it

Go ahead @prnvtripathi 🚀

Hi can you assign this to me ? @Kanika637

Go ahead @prnvtripathi 🚀

Any updates @prnvtripathi ?

Yeah, i did the font updates but, can't get the hold of user name thing 🥲


Simplify installation instructions with custom_updater

Adds installation instructions with custom_updater
Demo installing tracker-card this way:

Thanks for this!


More patterns and the renames

This PR adds some more patterns and implements the renames discussed in https://github.com/platelminto/parse-torrent-title/issues/34 and https://github.com/platelminto/parse-torrent-title/pull/35.

My account got flagged and got shadow banned for a couple of days, which hid my PRs, too. Everything is back to normal and this PR is ready for review.

Hey, I've decided to leave a big 3.0 release for now - I've merged your new patterns, but don't know when I'll include the renames. The major reason for wanting breaking changes was to change field types, but I feel like keeping it behind the coherent_types flag is fine for now.
Thanks again for the PR!


Please update this!!!

Please please you are the best

See issue #162 for an update.

MCDSaveEdit <IP_ADDRESS> is released


Install/Setup Instructions for Multisite installs

There are two kinds of WordPress multisite installs, domain mapped installs and sub-directory mapped installs.
While I understand that supporting domain mapped installs (either sub-domains or primary domains) is challenging, effort should be made to do that IMHO.
Until then. Supporting sub-directory mapped installs should be fairly easy and ought to both be properly supported by the plugin (ie. network aware activation) and outlined in the install instructions somewhere.

We do not plan to support WordPress multisite officially. Feel free to open a PR to satisfy your needs and the broader audience.
Installation documentation is here.
Let me know if you have questions.
Thanks

Closing issue due to inactivity


Error 'name 'serialization' is not defined'

As I have changed 'from jax.experimental.gda_serialization import get_tensorstore_spec'to 'from 'jax.experimental.array_serialization.serialization import get_tensorstore_spec'
Another error appeared. Please help, thank you.
NameError                                 Traceback (most recent call last)
[<ipython-input-18-152851d66c54>](https://localhost:8080/#) in <cell line: 16>()
     14 import seqio
     15 import t5
---> 16 import t5x
     17
     18 from mt3 import metrics_utils

6 frames
[/usr/local/lib/python3.10/dist-packages/orbax/checkpoint/type_handlers.py](https://localhost:8080/#) in ParamInfo()
    119   path: Optional[epath.Path] = None
    120   aggregate: Optional[bool] = None
--> 121   byte_limiter: Optional[serialization._LimitInFlightBytes] = None  # pylint: disable=protected-access
    122   is_ocdbt_checkpoint: Optional[bool] = None
    123

NameError: name 'serialization' is not defined

update jax and t5x，(may need to uninstall package [jestimator] first)


Modelscope makes loading stable fast 3D into an infinite recursion

Describe the bug
See https://github.com/MrForExample/ComfyUI-3D-Pack/issues/273 . As soon as modelscope is installed Load SD3F model just recurses infinitely
 File "/comfyui/custom_nodes/ComfyUI-3D-Pack/nodes.py", line 1983, in load_SF3D
    sf3d_model = SF3D.from_pretrained(
                 ^^^^^^^^^^^^^^^^^^^^^

  File "/comfyui/custom_nodes/ComfyUI-3D-Pack/Gen_3D_Modules/StableFast3D/sf3d/system.py", line 79, in from_pretrained
    load_model(model, weight_path)

  File "/opt/conda/lib/python3.11/site-packages/safetensors/torch.py", line 203, in load_model
    model_state_dict = model.state_dict()
                       ^^^^^^^^^^^^^^^^^^

  File "/opt/conda/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1939, in state_dict
    module.state_dict(destination=destination, prefix=prefix + name + '.', keep_vars=keep_vars)

  File "/opt/conda/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1939, in state_dict
    module.state_dict(destination=destination, prefix=prefix + name + '.', keep_vars=keep_vars)

  File "/opt/conda/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1939, in state_dict
    module.state_dict(destination=destination, prefix=prefix + name + '.', keep_vars=keep_vars)

  [Previous line repeated 2981 more times]

  File "/opt/conda/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1936, in state_dict
    self._save_to_state_dict(destination, prefix, keep_vars)

  File "/opt/conda/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1841, in _save_to_state_dict
    for name, param in self._parameters.items():
                       ^^^^^^^^^^^^^^^^^^^^^^^^

To Reproduce

What command or script did you run?

Run ComfyUI with the 3D Pack, but I suspect trying to use StableFast3D would yield the same issue. It's basically loading the safetensors model in torch.

The moment I uninstall modelscope and retry it works just fine
Your Environments (required)

OS:  Linux in a docker container
Pytorch 2.4.0

The running script please?

I'm unfortunately not knowledgeable about python and the pytorch ecosystem to create a small repro. At least not without assistance.
Does modelscope alter the way safetensors are loaded with pytorch? Or might this be some kind of import conflict when modelscope is loaded it changes the execution flow.?
The only thing I know is if I install modelscope (or it gets installed through a ComfyUI plugin) it breaks the loading function https://github.com/Stability-AI/stable-fast-3d/blob/8a1fb7156df24644c850391049c4af7afcdb2ab7/sf3d/system.py#L83C9-L83C24

which version of modelscope installed

modelscope                  1.18.1


MGDOBR-421 Convert integration tests into unit tests where applicable

Signed-off-by: Karel Suta<EMAIL_ADDRESS>MGDOBR-421
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Please be aware of https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/480/
At the moment when you request a Bridge or Processor the are provisioned immediately.
However with the referenced PR they get provisioned by the next iteration of the WorkManager execution.
In tests this is scheduled every 1s by use of this.
It is therefore recommended to wait for a Bridge (or Processor) to become available before tests proceed.
See here in the referenced PR.

@manstis Thanks for notification. The changes should be safe as they check validation without dependencies on other deployments (in case of dependency there is used shared creation method which is covered in your changes).


Finch error

Describe the bug
Finch returns an error as if the named domain did not exist.
The cosmos db address is correct.
To Reproduce
container |> CosmosDbEx.get_documents()

Error log
iex(4)> container |> CosmosDbEx.get_documents()
** (FunctionClauseError) no function clause matching in CosmosDbEx.Documents.parse_response/1

    The following arguments were given to CosmosDbEx.Documents.parse_response/1:

        # 1
        {:error, %Mint.TransportError{reason: :nxdomain}}

    Attempted function clauses (showing 8 out of 8):

        defp parse_response({:ok, %Finch.Response{body: body, headers: headers, status: 200}})
        defp parse_response({:ok, %Finch.Response{body: body, headers: headers, status: 201}})
        defp parse_response({:ok, %Finch.Response{status: 400, headers: headers, body: body}})
        defp parse_response({:ok, %Finch.Response{status: 401, headers: headers, body: body}})
        defp parse_response({:ok, %Finch.Response{status: 403, headers: headers, body: body}})
        defp parse_response({:ok, %Finch.Response{status: 404, headers: headers, body: body}})
        defp parse_response({:ok, %Finch.Response{status: 409, headers: headers, body: body}})
        defp parse_response({:ok, %Finch.Response{status: 413, headers: headers, body: body}})

    (cosmos_db_ex 0.1.1) lib/cosmos_db_ex/documents.ex:183: CosmosDbEx.Documents.parse_response/1

Desktop (please complete the following information):

OS: macOS Catalina
Elixir : 1.14.0
Erlang : 25.1

I do need to add another clause to handle the :nxdomain error.  As for Finch not being able to find the domain name, can you confirm real quick that you can connect to the database via Azure Data Studio, or something like that from the same machine?

Yes, confirmed. With  Azure Studio data I'm able to connect.
More, tested db downloading Microsoft  cosmos db 'connect' sample python app and it works.
I'm able to create and read items  in cosmos db  'ToDoList' container (as for Microsoft python example).
So, I can say that cosmos db is up and running and available for python sample app.
Thx.


📚 Epic: TPI hot instance or pool of instances for a single user

The same as https://github.com/iterative/terraform-provider-iterative/issues/208 but a single instance is instantiating in the beginning and reusable in multiple runs.
New steps:

a user run instances (or a single one) before submitting a training job
when the user kicks off a train it runs on one of free instances

Details:

user is responsible for creating and terminating instances
consider using k8s or Nomad as an orchestrator while keeping the experience dead simple for users
this scenario does not include multiple users use cease

Very interesting use case! This reminds me of course a CI runner.
Just curiosity, has been this feature requested by the companies that you talk to? I think that this feature is useful for very fast experimenting.

Sounds like Kubernetes ☸

Sounds like Kubernetes ☸

To me sounds more like a task orchestrator


Feature/nullable causer

As discussed in issue #567 this PR contains a possible "null object" oriented solution to allow anonymous causers. I am open to make changes to this PR.
There are a couple of things I would like to discuss:

First of all: is this approach viable anyway?

What about the name of this null object? For now, I used AnonymousCauser, but I don't know if this is OK.

Do we need more properties on this null object? For now, I only added 'name'.

I don't like the inconsistency in config keys 'table_name' and 'anonymous_causers_table_name'. How would you like to tackle this naming?

I see that I have included all commits from a previous PR, so I will close this one. My mistake

Hey,
thanks for your PR. But I believe that you tried to solve a different problem. It could be that it's a problem that should be solved but it's not what was requested in #567 so far I understood it.
For me your solution is also out of scope of this package. But your approach placed a new idea in my head.
The problem to solve is that it should be possible to use null as ...

During typing I had some more thoughts but I wanted to keep my first words

You solved the issue one way but I would like to use a simpler approach. Adding a new model is a bit oversized for me. Every user can use all models as causer because the relationship is polymorphic. So I would like to use the simple nullable approach and add an anonymous() method that sets the causer to null.
But to keep your work for a possible later need feel free to open a new branch/PR.


Random crashes when running multiple server instances in parallel

Sometimes the server crashes in GPU related methods when several instances are running in parallel or a very big number of cameras (6 or more) are attached to the vehicle.

Is this issue still active?

AFAIK this still happens, but it is going to be very difficult to spot the bug. It could be anywhere, nvidia drivers, Unreal Engine, or the GPU running out of memory.

Issue #1 finally closed, this is an important milestone :smile:


defaultdict for matches, format output, summary option, simpler Python2 compatibility

Changed matches to be in a defaultdict with files and line numbers as keys
Added a summary option that only prints files and line numbers
Simplified Python2 compatibility check, removes need for sys

Verified works on Python 2.7.16

Formatted output to be leveled file --> line number --> match
Simplified argparse requirement for an input

After your changes, the output look like this :

If you don't have e.g. the filename in each line, greping the output of hundreds of systems can be tricky.

The DEOBFUSCATED_STRING now contains a list of the log line and the deobfuscated string.

If you don't have e.g. the filename in each line, greping the output of hundreds of systems can be tricky.

Ah, yeah, I used this in a homelab on a handful of VMs.

The DEOBFUSCATED_STRING now contains a list of the log line and the deobfuscated string.

Whoops, missed that.


OAuth2Request should access grant_type through data

The grant_type property of the OAuth2Request class should refer to the data collection (consistent with the other properties response_type, client_id, etc. and not through the base form. Without this change the following grant setting will not function:
TOKEN_ENDPOINT_HTTP_METHODS = ["GET"]

What kind of change does this PR introduce? (check at least one)

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

[X] You consent that the copyright of your pull request source code belongs to Authlib's author.

I don't think that should be the case, as explained here: https://github.com/lepture/authlib/issues/658 .

I don't so, as explained here: https://github.com/lepture/authlib/issues/658 .

RFC frowns upon GET requests for token endpoint.
https://datatracker.ietf.org/doc/html/rfc6749#section-3.2


Teal

Splits os2 into ros-installer, golang code is gone
Base image switched to sle micro for rancher + elemental binaries included
framework files are now tracked individually and statically (we could go with git submodules, but wanted to keep it simple for now)
Adds a CI workflow which keeps the framework static files in sync with cos-toolkit, opening up PRs
Should be ready to go to be built with obs/ibs @kkaempf - it also replaces the os2-framework package, with a unique Dockerfile that can be built directly from obs
Drop temporarly selinux as SLE Micro for Rancher has supports for it, but as we don't have profiles for it, fails booting
Might need a follow-up, the PR pipeline should work, but yeah :)

Draft as gotta test this locally still and trying to wire up the CI
Supersedes #115
Part of https://github.com/rancher-sandbox/os2/issues/94

What packer version? I see 1.7.4 in https://github.com/rancher-sandbox/os2/blob/master/ros-image-build#L32 but I only tested properly up to 1.7.3...weird that it worked before...

Does this works locally? I mean, its only failing on CI? currently cloning....

yeap indeed it's weird, locally running with qemu or vbox just works, it is only with the packer (networking setting I guess?) that it fails.. it reminded me your issue when it was not getting the IP (as it looks likes the same here)
gotta check, for sure it has to do with the base image, as master it's green and tests passed just today.. so the image somehow isn't playing well with packer settings

weird, also fails locally with packer 1.7.3 and 1.7.4 ......
Also if you vnc into the machine and manually add the address (ip address add <IP_ADDRESS>/<IP_ADDRESS> dev eth0) then packer can connect correctly.
I would have a look at the slirp package which provides the user networking for qemu (libslirp0) as the versions between the package in sle micro and opensuse are different

rancher-822:~ # rpm -qa | grep libslirp
rancher-822:~ #

:O

libslirp for 15.4 received a dhcp fix patch a few days ago: https://build.opensuse.org/package/show/openSUSE:Leap:15.4/libslirp
The same lib doesnt have any patches on 15.3 :/
I found out that if you downgrade libslirp to libslirp0-4.3.1-1503<IP_ADDRESS> instead of libslirp0-4.3.1-1503<IP_ADDRESS> then packer works, at least locally :/
diff --git a/ros-image-build b/ros-image-build
index 3e0d51f..6222e8c 100755
--- a/ros-image-build
+++ b/ros-image-build
@@ -24,6 +24,7 @@ RUN sed -i -s 's/^# rpm.install.excludedocs/rpm.install.excludedocs/' /etc/zypp/
 RUN zypper ref
 ENV LUET_NOLOCK=true
 # Copy luet from the official images
+RUN zypper in -y libslirp0-4.3.1-1503<IP_ADDRESS>
 RUN zypper in -y squashfs xorriso curl unzip git qemu-arm qemu-x86 qemu-tools tar pigz go1.16 qemu-uefi-aarch64 mtools rsync
 RUN cd /usr/sbin && \
     rm packer && \

Im talking about make ci here btw, but I dont see what has really changed in your PR that could affect that part? meanwhile master seems to be passing :/

libslirp for 15.4 received a dhcp fix patch a few days ago: https://build.opensuse.org/package/show/openSUSE:Leap:15.4/libslirp
The same lib doesnt have any patches on 15.3 :/
I found out that if you downgrade libslirp to libslirp0-4.3.1-1503<IP_ADDRESS> instead of libslirp0-4.3.1-1503<IP_ADDRESS> then packer works, at least locally :/
diff --git a/ros-image-build b/ros-image-build
index 3e0d51f..6222e8c 100755
--- a/ros-image-build
+++ b/ros-image-build
@@ -24,6 +24,7 @@ RUN sed -i -s 's/^# rpm.install.excludedocs/rpm.install.excludedocs/' /etc/zypp/
 RUN zypper ref
 ENV LUET_NOLOCK=true
 # Copy luet from the official images
+RUN zypper in -y libslirp0-4.3.1-1503<IP_ADDRESS>
 RUN zypper in -y squashfs xorriso curl unzip git qemu-arm qemu-x86 qemu-tools tar pigz go1.16 qemu-uefi-aarch64 mtools rsync
 RUN cd /usr/sbin && \
     rm packer && \

Thanks for the inputs! blargh. that's so... weird that doesn't fail with an openSUSE based image.. it's all pinned to leap 15.3 on master..  maybe that's the reason, old packages..

Im talking about make ci here btw, but I dont see what has really changed in your PR that could affect that part? meanwhile master seems to be passing :/

yep yep make ci only fails now. the PR mostly changes the base image, for the rest it keeps everything still the same (settings, config, etc). It just drops the go code part
ISO boots fine, everything seems to work.. it's just packer which is failing on setting up network properly

very weird becuase I can see it installing the proper version of libslirp on the ci build on master: https://github.com/rancher-sandbox/os2/runs/6405828614?check_suite_focus=true#step:4:2854
So on this patch the base image has changed somehow. In my tests the base image which run packer was based of opensuse 15.4, while on master seems to be 15.3? Is this because now we use the elemental image as TOOLS and that may be based on opensuse 15.4?

very weird becuase I can see it installing the proper version of libslirp on the ci build on master: https://github.com/rancher-sandbox/os2/runs/6405828614?check_suite_focus=true#step:4:2854
So on this patch the base image has changed somehow. In my tests the base image which run packer was based of opensuse 15.4, while on master seems to be 15.3? Is this because now we use the elemental image as TOOLS and that may be based on opensuse 15.4?

yup most likely so, I'm using the elemental image here as tools to keep it tight and simply bump it if we ever need to change tooling (at the end, this makes sense just for CI runs and local development, so..)

mmm packer still time outs here, but I've bumped it.. maybe I was too optimistic...

yep, even with a fixed libslirp, the qemu plugin on 1.8.0 seems to be broken for user networking.
Also I just noticed..the zypper in stanza in the elemental Dockerfile is cached....so we dont get any system updates on the docker image build...so we may have a broken libslirp in there, while the newest version has a fix for dhcp but we are not bundling it. ARGH.

yep, even with a fixed libslirp, the qemu plugin on 1.8.0 seems to be broken for user networking.
Also I just noticed..the zypper in stanza in the elemental Dockerfile is cached....so we dont get any system updates on the docker image build...so we may have a broken libslirp in there, while the newest version has a fix for dhcp but we are not bundling it. ARGH.

I'll just stick with leap 15.3 now, at the end this could be done in so many ways... :man_shrugging:

Basing on leap 15.3 seems to work, thanks @Itxaka !

The same lib doesnt have any patches on 15.3 :/
I found out that if you downgrade libslirp to libslirp0-4.3.1-1503<IP_ADDRESS> instead of libslirp0-4.3.1-1503<IP_ADDRESS> then packer works, at least locally :/

That should be raised via bugzilla.opensuse.org

Looks good here, good for review @mjura @Itxaka @davidcassany

framework files are now tracked individually and statically (we could go with git submodules, but wanted to keep it simple for now) allowing sandboxed builds

Shouldn't it be enough to consume the latest luet packages in the Dockerfile instead? Is all this to avoid luet install in the Dockerfile so it can be built in OBS?

yes exactly, note this is not strictly required here, we could have used OBS services or other means. I actually wanted to do a separate repo with the static files as I'm a fan of git submodules, but I do understand it might be a stopper so I prefered to vendor them here and treat them as a static asset
Note there is a mechanism to sync back to cOS so there is no need to do anything on our side besides merging PRs afterwards

See https://github.com/rancher-sandbox/os2/pull/125 for an example of sync-up PR


riscv: remove riscvport.json

It's no longer needed
Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

Could someone take a look at this? It's blocking all the rest of the riscv upstreaming.


OpenTracing collector exporter throws ReferenceError after trace export in Web application

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
0.12.0
What version of Node are you using?
v12.18.3
Please provide the code you used to setup the OpenTelemetry SDK
opentelemetry.js
import { ConsoleSpanExporter, SimpleSpanProcessor } from '@opentelemetry/tracing';
import { WebTracerProvider } from '@opentelemetry/web';
import { XMLHttpRequestPlugin } from '@opentelemetry/plugin-xml-http-request';
import { CollectorTraceExporter } from '@opentelemetry/exporter-collector';

const provider = new WebTracerProvider({
  plugins: [
    new XMLHttpRequestPlugin({
      ignoreUrls: [/localhost:8080\/sockjs-node/],
      propagateTraceHeaderCorsUrls: [],
    }),
  ],
});

provider.addSpanProcessor(new SimpleSpanProcessor(new CollectorTraceExporter({
  serviceName: 'user-management',
  url: 'http://localhost:30681/v1/trace',
})));
provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter()));
provider.register();

const tracer = provider.getTracer('User-management');

export { tracer };

docker-compose.yaml
version: '3.4'

services:
  jaeger:
    image: jaegertracing/all-in-one:latest
    restart: always
    ports:
      - 5775:5775/udp
      - 6831:6831/udp
      - 6832:6832/udp
      - 5778:5778
      - 9411:9411
      - 14250:14250
      - 14268:14268
      - 16686:16686
    environment:
      COLLECTOR_ZIPKIN_HTTP_PORT: 9411

  collector:
    image: otel/opentelemetry-collector:0.12.0
    command: ["--config=/etc/collector-config.yaml", "--log-level=DEBUG"]
    restart: always
    ports:
      - "9464:9464"
      - "30680:55680"
      - "30681:55681"
    volumes:
      - ./collector-config.yaml:/etc/collector-config.yaml

collector-config.yaml
receivers:
  otlp:
    protocols:
      grpc:
      http:
        cors_allowed_origins:
          - http://*
          - https://*

exporters:
  jaeger:
    endpoint: jaeger:14250
    insecure: true

processors:
  batch:
  queued_retry:

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [jaeger]
      processors: [batch, queued_retry]

What did you do?
I'm using the XHR plugin, each reported span after the reporting throws the error: "Uncaught (in promise) ReferenceError: can't access lexical declaration 'promise' before initialization". Console exporter works without any issue.
What did you expect to see?
No error is thrown.
What did you see instead?
Unhandled error in dev. console.
Additional context
Firefox 81.0.2.
Here is a stack trace.
Uncaught (in promise) ReferenceError: can't access lexical declaration 'promise' before initialization
    _onFinish CollectorExporterBrowserBase.js:64
    _onSuccess CollectorExporterBrowserBase.js:57
    sendWithBeacon util.js:29
    promise CollectorExporterBrowserBase.js:72
    send CollectorExporterBrowserBase.js:54
    _export CollectorExporterBase.js:70
    _export CollectorExporterBase.js:67
    export CollectorExporterBase.js:52
    onEnd SimpleSpanProcessor.js:44
    with StackContextManager.js:103
    with context.js:60
    onEnd SimpleSpanProcessor.js:43
    onEnd MultiSpanProcessor.js:51
    end Span.js:134
    endSpanTimeout xhr.js:253
    endSpan xhr.js:271

I think this is the same bug than #1601


Why Remove Content-Length in Gateway MVC？

Describe the bug
I communicate with downstream server , At beginning I send request with okhttp manutally and everything is ok , when i integrate spring gateway mvc，i got 500 error like form encode escape % etc. after i dive into deep code , i found an odd Request Filter RemoveContentLengthRequestHeadersFilter
why we need remove content-lengh ,i can't understand the  meaning of the comment on top.
// jdk http clients seem to not like having this copied from the initial request. // urlconnection fails with form url encoded

The jdk http client will fail with an error if not removed.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

The jdk http client will fail with an error if not removed.

What error will occur, maybe I can invstigate a bit if I know the error? I think it is a big problem if (in case of mvc) the ´Content-Lengthis just removed. For my project, after migrating to mvc, I set the remove-content-length-request-headers-filter.enabled to false with having only one issue with a 3rd party service which raises a strange exception, all my other downstream services are working fine (and one of them really needsContent-Length`).


Fixing typo in class doc

Edits suggested related to: https://github.com/google/seq2seq/blob/master/seq2seq/decoders/attention.py#L78 .
There is probably other issues in this doc i.e. there is no cell, helper nor initial_state defined in __init__().

Thanks! Yeah, the pydoc comments are a bit outdated. Originally these things were passed in the constructor, but now most of these have moved into the params configuration or another function.


Add hasSite and isSiteOf relationships

The new properties can be used to capture relationships between individuals in a graph and sites associated with them.
Closes #177

I was looking through the SHACL generation script and the subproperty handling is pretty clunky. I don't think it needs to be this complex for what we're doing. A simple recursive approach to handling subproperties is probably sufficient. The following seems to work ok:
def addPropertyShapes(propertyName, defn):
    for pred, obj in defn.items():
        # We are only concerned with properties that have RDFS.domain or .range
        # predicate.  The temporary replacements for those predicates are
        # brick:expectedDomain and :expectedRange.  See properties.py for
        # explanation.

        if pred == RDFS.domain:
            addDomainShape(propertyName, obj)

        if pred == RDFS.range:
            addRangeShape(propertyName, obj)

        # subproperties are considered after "domain" and "range" are counted for
        if pred == "subproperties":
            for subprop, desc in obj.items():
                addPropertyShapes(subprop, desc)

for name, defn in property_definitions.items():
    addPropertyShapes(name, defn)

This won't handle everything that results from the feedsAir subproperty but should be sufficient for the site relationships

@shreyasnagare how is this going? Anything I can help with in terms of getting the modeling to work?

It also looks like it is targeting subjects of both hasSite and isSiteOf, which is incorrect

I looked at the version of BrickShape.ttl in the master branch and it looks like this had always been the case even for the other property shapes. This PR should fix that.

I am not a fan of isSiteOf/hasSite. I would prefer that we just treat it as any other location class, and use hasPart for location composition and hasLocation to put assets into whatever nested location makes sense.

I would agree with Eric - it basically gets away from what was a core design concept in my opinion of Brick

Cool cool -- this matches what we discussed in the dev meeting today.
@shreyasnagare can you remove the isSiteOf/hasSite implementation, but keep the rest of the changes to the SHACL generation (anything agnostic to the isSiteOf/hasSite implementation)? Let me know if you're too busy  and I can make those changes


Add user_email QuickReply

@simalexan did you mean if quickReply arg is null or undefined? added tests for this case.

@otemnov perfect. Thank you!


UI: login with importer role freezes login page

login to UI with importer user hangs
message: Maybe backend (API or database) is unreachable. Please contact administrator
can we catch this before error occurs?
should ideally just return "Invalid credentials" (same as with wrong password

Importer role misses db user table access => Leads to failing on login trying to fetch user infos

fixed


Support miniflare mount to dev multiple workers

💡 Feature request
Basically the same as https://miniflare.dev/core/mount, starting dev for multiple workers with a single command.
Describe the feature
I find myself developing multiple workers (to replace my API). Being able to spin them all up during dev is very handy.
Describe the alternatives
Spinning up all one by one or using miniflare.

Duplicate of #273


feat(tutorial): complete step 5

carbon-tutorial-hammoudij.au-syd.mybluemix.net

Thanks, I have included the mybluemix.net URL.
carbon-tutorial-hammoudij.au-syd.mybluemix.net


Fixes #3363.

Can we maybe first bump to the new wasm version, and then ocaml and nixpkgs separately? Or is that too tricky?

Just doing some repo cleanup for better focussing on active work:
Closing PR as it seems inactive for a longer time. Please re-open if it is still relevant and after it has been updated with latest master changes.


Changes to clearFilters function

Fixes #10
Changed alignment and sort variables to equal null when clearing the filters.

Whoops, silly me overlooking this. Thanks!


Add: Magnety

Hello there, I would like to add my Dapp Magnety to the zkr-app-directory :)

Hi, looks like your website is not live yet and I cannot find any detailed docs.
Please let us know when your product is up and running or when the source code is made available.
Thanks!

Hello, I just saw your mail, deeply sorry for it. Docs are already published and the website will be live in few days, I'll keep you updated.Best,SachaLe 12 mars 2022 à 18:22, Jason Garland @.> a écrit :Hi, looks like your website is not live yet and I cannot find any detailed docs.Please let us know when your product is up and running or when the source code is made available.Thanks!—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.>

Hello @0xSacha
Magnety has been live in the directory for some time now - https://www.zkrollups.xyz/Magnety
If you want to make any updates to the listing please fill in this form and I'll get it sorted asap - https://forms.gle/dmAZYHDPcpbp6wto7
Cheers, Joel


impl server side rendering (SSR)

should be doable to impl this in greco so it can be used with starlight and quickjs
see also:
https://github.com/Starlight-JS/starlight/issues/27

works already


How to deal with missing values with createBatch?

Hi, thanks for creating this very useful library!
In the following example:
import type { CacheEntry } from 'cachified';
import LRUCache from 'lru-cache';
import { cachified, createBatch } from 'cachified';

type Entry = any;
const lru = new LRUCache<string, CacheEntry<string>>({ max: 1000 });

function getEntries(ids: number[]): Promise<Entry[]> {
  const batch = createBatch(getFreshValues);

  return Promise.all(
    ids.map((id) =>
      cachified({
        key: `entry-${id}`,
        cache: lru,
        getFreshValue: batch.add(id),
      }),
    ),
  );
}

async function getFreshValues(idsThatAreNotInCache: number[]): Entry[] {
  const res = await fetch(
    `https://example.org/api?ids=${idsThatAreNotInCache.join(',')}`,
  );
  const data = await res.json();

  return data as Entry[];
}

Imagine a scenario where some of the IDs that were requested in the fetch request do not return any result and are therefore missing from the data array. How should we deal with these missing values? Should we add null to the array or perhaps undefined?
Thanks!

That's an interesting question! And I would like to take some time for discussion and to think about this before presenting a possible "goto" solution.
Adding null or undefined as option for the Entry is definitely the way to go. But currently that would also store these values in cache and only revalidate them once their TTL is over. If that's what you intend you're good to go 👍
A scenario that is not possible right now (I think) would be when you want to NOT store the missing null in cache and have getFreshValues try to get them again asap.
I'll check this out in the coming days.

I've added/updated two sections about this to the readme (and added the functionality to fine-tune cache-metadata in batch requests.
see Fine-tuning cache metadata based on fresh values (This was already possible but not well documented, though this does not use createBatch the concept will also apply there)
I've also updated Batch requesting values to show the new onValue callback.

With this in mind here's what I'd do.

First and foremost, yes you want to add null, undefined or similar to the array you're expecting from the Promise.all
If you want to cache the information that you received an empty values exactly the same as the non-empty values, you don't need anything else.

If you want to not cache empty values or cache them for a much shorter time do something like this:
const batch = createBatch((ids): Promise<(string | null)[]> => {
  /* ... */
});

const values: (string | null)[] = await Promise.all(
  ids.map((id) =>
    cachified({
      /* cache and other options... */
      key: `entry-${id}`,
      ttl: 60_000,
      getFreshValue: batch.add(id, ({ value, metadata }) => {
        if (value === null) {
          /* -1 disables caching, you could also just set to a shorter time */
          metadata.ttl = -1;
        }
      }),
    })
  )
);


[hive] HiveMigrator support set parallelism for procedures

Purpose

Linked issue: close #xxx
Currently migrate table/file/database cannot set thread parallelism, user can not overclock cpu to improve migrate speed or reduce cpu cost for avoid impacting other process in machine , this pr is support parallelism change.

Tests

API and Format

Documentation

Hi @xuzifu666 , parallelism should be a int.

Hi @xuzifu666 , parallelism should be a int.

Thanks, had change parameter parallelism from String to Integer. @JingsongLi


caller appears to report wrong line when block passed and brackets omitted

Dear mruby developers,
I've recently started working with mruby and am busy porting my codebase from cruby to mruby in such a way that the code executes the same. Its been throwing up a lot of issues (mostly due to occasional missing methods), which I am managing to get past. However,  some of my tests are failing due to the following issue. The following code demonstrates the problem. I heavily use the second form (without the function call brackets) so this issue is important to me. I also heavily rely on Kernel#caller. This issue only shows up if a block is passed aswell as not using brackets. Is this a bug? It definitely behaves different to cruby which does what I expect.
Thanks for mruby!
def a(id) = puts caller[0]
a(1) do # caller reports this line
end
a 1 do
end     # without brackets caller reports this line

I should say I'm using mruby 3.2 on windows.

Thank you so much Matz. Really appreciate it :)


Earliest Date Not Aligned with Project var start_date

Hi! Hoping this is the right place to submit this issue.
I have recently implemented this package to handle much of the GA4 heavy-lifting in our org and so far it has proven infinitely more valuable than I thought possible.
That said, while populating my initial data set (the cutoff is 2023-07-01), the incremental tables created (base_ga4__events) only go back as far as 08-21 which is an odd date, though I have verified that the source data in GA4 goes back to 07-01 (analytics_296372144.events_20230701).
Confirmed date in the dbt log for base_ga4__events as well
from `bigquery-dealeron-reporting`.`analytics_296372144`.`events_*`
where cast( replace(_table_suffix, 'intraday_', '') as int64) >= `20230701`

Didn't run into any timeout issues, but am at a loss.
Thanks.

Can you confirm what your start_date variable is set to in your dbt_project.yml file?

From project YML
vars:
  ga4:
    project: "bigquery-dealeron-reporting"
    dataset: "analytics_296372144"
    start_date: "20230701" # Earliest date to load

Yea that's odd. This doesn't sound like a dbt or package issue if the compiled query is correct.
You said that directly querying the data provides results, but dbt does not. Can you paste both queries here? The working query and the non-working query.

To clarify - the initial GA4 data set (sharded tables) contain data all the way back to 0701, when querying the base_events table or stg_ga4__events after a dbt full refresh, the earliest date returned was 08-21

Sorry, by comparing queries I mean compare the query compiled by dbt:
select *
from `bigquery-dealeron-reporting`.`analytics_296372144`.`events_*`
where cast( replace(_table_suffix, 'intraday_', '') as int64) >= `20230701`
order by event_date_dt asc

to an equivalent query that is working:
select * from
from `bigquery-dealeron-reporting`.`analytics_296372144`.`events_20230701`

What is the output of both of those?

(opted to select event_date to minimize load)

In DBT:

As an aside, is there any sort of limitation in BQ or DBT that would prevent the creation of the tables prior to 08-21?

Resolved this issue, needed to set the partition expiration date in the BQ options in the config block of the partition table generating scripts in order to accommodate the reporting history we needed to backfill.
Thanks for all the help!


Selenium cross-browser & cloud testing

Hi, one more topic. Didn't find information in docs about cloud configuration and WEB testing on multiple browsers, so could you please clarify what is the best way of implementing this kind of checks?
We are using BrowserStack cloud and I have a long list of browser/os pairs I need to run tests against. I can't block resource in the cloud for the actor as I'll have fare more actors then concurrent sessions in BrowserStack. Also, there are some other users, CI pipeline test, and so on.
1 SESSION: How to configure actor to use a cloud browser?
2 ACTOR: Should be created a separate actor for each browser/os like WEB-Chrome52-Win10?
3 TEST: Should be saved a copy of each test in a separate file for every actor needed (eg. Test1_WEB-Chrome52-Win10.YAML, Test2_WEB-Chrome52-Win10.YAML, Test1_WEB-Chrome56-Win7.YAML...), then 'Test session' with all required tests could be created using test session template?
4 DATA DRIVEN: maybe there is a more elegant data-driven way of configuring this?.. like iterating single test using different actors?
Thanks!

To run tests across multiple browsers, you have to create one (or more) actors for each browser and OS combination, as required by your parallelization needs, and tag the actors with the corresponding tags in actor.yaml, by changing the actorTags property (e.g. actorTags: [ chrome, macos ], actorTags: [ firefox, win10 ], etc.). Then, you can specify what actors you want when you start a test session, by filling-in the "Actor tags" textbox accordingly (e.g. chrome,macos, firefox, win10, etc.). This way, you can write one single test and not have to maintain one extra test file per each browser/OS combination. One thing to be careful of: due to a bug, when you put the list of actor tags in the UI, make sure to not use any spaces between the tags and the comma(s) meaning chrome,macos is correct, but chrome, macos will not work, and the session will wait forever for the right actors to arrive.
When you run tests against BrowserStack, you'll also have to configure the appropriate desired capabilities in the actor.yaml file(s), as specified in their documentation (e.g. os, os_version, browserstack.selenium_version, etc.).
Also, make absolutely sure that you're not setting the selenium.reuseDriver property in actor.yaml to true. If you do, the actors will never release their WebDriver instance and you might end up with a big BrowserStack bill.
Let me know when you managed to have things up and working and whether you found anything in my explanation confusing (it's helpful for when we document the actor tags feature).

I'll give it a try, thanks

@adrianth
Hi Adrian,
Nice test automation tool. Started playing with it today. However, I will be more interested to find out on how i can configure actor.yaml to run test against browserstack? Although I can work my way around it - i feel it will be easier to incorporate with an example.
It will be great if you could provide an example config may be in the documentation. To start with lets use this config and see how we can accommodate it in actor.yaml
"url": "http://hub-cloud.browserstack.com/wd/hub",
"browser": "chrome",
"user": "username",
"key": "key",
"capabilities": {
"os": "Windows",
"os_version": "10",
"browserName": "Chrome",
"browser_version": "71.0",
"project": "opentest-bs-config",
"build": "Build1.0",
"browserstack.local": true,
"browserstack.debug": true

Running Web tests against a cloud provider typically requires only two changes:

Put the URL of your provider's Selenium endpoint into the seleniumServerUrl parameter in the selenium section of actor.yaml (for BrowserStack you need to include the authentication details in the URL, like this: https://username:key@hub-cloud.browserstack.com/wd/hub). By default, this parameter is commented-out, so make sure to uncomment it by removing the # in front of it.
Configure the desiredCapabilities parameter as required by your cloud provider.

So the selenium section of your actor.yaml should look like this:
selenium:
    seleniumServerUrl<EMAIL_ADDRESS>    desiredCapabilities:
        os: Windows
        os_version: "10"
        browserName: Chrome
        browser_version: "71.0"
        project: opentest-bs-config
        build: Build1.0
        browserstack.local: true
        browserstack.debug: true

    maximizeWindow: true
    fullScreen: false
    scriptTimeout: 20
    reuseDriver: false

Let me know if this worked. As you might know already, you can configure multiple test actors as needed so you can start multiple test session in parallel.


Work Package wp-gr.csv

Results of Phase 1
wp-gr-results.csv

wp-gr-results.csv
Results of Phase 1

Results of Phase 2: wp-gr-results.csv

Results of Phase
wp-gr-results.csv
2


misc: Optimize the code

Signed-off-by: Ce Gao<EMAIL_ADDRESS>
What this PR does / why we need it:

Avoid init before nirvana
Make build by default in Makefile

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @simon-cj

Release note:

NONE

/lgtm


Front matter data in documents without content parsed as content

For a document that contains only a front matter block but no content, FrontMatterParser returns the front matter data as content:
FrontMatterParser::Parser.new(:md).call("---\ntest: 1\n---")
 => #<FrontMatterParser::Parsed:0x0000000128c1d008 @front_matter={}, @content="---\ntest: 1\n---">

(Adding just a single newline after the block makes it parse correctly)

Thanks for reporting, @ralfebert. Does it happen with any syntax?
I won't be able to look into it for a month at least, so feel free to submit a PR if it's something urgent for you. Otherwise, I'll happily look into it once I'm back.


drag-drop: invoke renderRows() method to refresh mat-table, but cdkDropList has not been updated

What is the expected behavior?
update cdkDropList after invoking mat-table.renderRows() method
What is the current behavior?
cdkDropList has not been updated after invoking mat-table.renderRows() method
What are the steps to reproduce?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular:7.0.4
OS:window 10
TypeScript:3.1.6
browsers:Google Chrome 67.0.3396.87
Is there anything else we should know?

Please re-open with steps to reproduce, preferably in StackBlitz, so we can diagnose your issue and create a fix if necessary. Thanks!


Module manager periodic jobs unchecks.

I have my main router set to reboot every night at 3:00AM.
this is the second day in a row I have woken up and found my overlay information on the live screen not updating.  Both times I have found the RUN CUSTOM SCRIPT un-checked.
Both times I have had the live vew open in the WEBUI, although my computer was asleep.
My Allsky is POE powered so it is hard wired to my home network.   Both the POE switch and the router the POE is hooked up to DO NOT reboot.

Will try again tonight, but close the WEBUI before I go to bed

OK, last night I closed the active WEBUI window.   This morning I opened the WEBUI and the it was happlily imaging away overlays and all.  Something with keeping the WEBUI window open while the router reboots causes it to uncheck???

I suspect the custom script is taking too long to run, what watchdog timeout do you have set in the module settings?
Paste the contents of the periodic flow here as that has some debug info in it that may help

just incase, here is the script it runs:  remove the .txt
getweather.sh.txt

just incase, here is the script it runs: remove the .txt getweather.sh.txt

Thanks. I need the json file when its been disabled, in the one you posted its enabled. Sorry my fault I should have explained that

OK.. will do that next time it fails.   Left it running last night and it stayed enabled.   I haver also power cycled my laptop, not sure if that didn't have an infulence on it as well.

PLEASE CLOSE
Believe the issue was caused by leaving the live view active at night.  The reboot of the main router causing issues.
The Allsky is plugged into a hard wired 2nd router that does NOT reboot at night, only my main router does.
Been having issues with the main router dropping or not assigning IP addresses.

Closing per user request.


manager: watchdog restart is blocking

If ui dies while the onroad/offroad transition is occurring, it can block it until ui has been restarted, causing CAN errors to be logged for quite a considerable amount of time after the car goes offroad.

UI is now killed with SIGKILL, so the restart is much faster.


Replace explicit model checks with S3 dispatching

One hitch I've identified with this project that I need to followup on is the best way to dispatch methods like simulateCells(), where you provide a string to emphasize what model (e.g. "celda_C"), as well as some additional parameters.
Most of our generic methods dispatch on the class of the object being passed as the first argument, but this function dispatches on a string. The way I make this work is by appending the class string to the class vector for that string, and then dispatching on that.  I'm not sure if this is violates best practices, so I plan on following up with some people more familiar with S3.

@joshua-d-campbell I'll be pushing a branch with my progress on it soon, and I'll keep track of any issues that arise here.

Another complexity is how to document multiplexed functions, for example simulateCells(). We can annotate all possible options on the documentation for the generic, but then the documentation for that function will get really long, especially if we add additional models.


where is poses file?

Thanks for your work! I want to know where are these poses files（.npy）, and there are just  groundtruth.csv on official website.Thank you!
gen_training_index:
poses file of database
poses_database: "/media/mjy/Samsung_T5/NCLT_dataset/velodyne_poses/T_w_r_gt_velo_2012-01-08.npy"
poses file of query
poses_query: "/media/mjy/Samsung_T5/NCLT_dataset/velodyne_poses/T_w_r_gt_velo_2012-02-05.npy"
path of reference .bin of database
scan_database_root: "/media/mjy/Samsung_T5/NCLT_dataset/velodyne_data/2012-01-08_vel/velodyne_sync/"

Thanks for using our code!
We will release all the necessary files upon the acceptance of our paper.


delay for the search feature

Hi,
I think there should be a "searchDelay" property (500ms for default) for the search feature so that not each new "key down" triggers a search.
This will improve the search feature performance.
Of course this delay could be overwritten.
What do you think?

@dana2208, agree, it's a good suggestion, but I think the default is zero is better for the user who has been use search functionality.

@dana2208, we've support a delay on search, I thinks it a workaround for this issue. Check example


[Request] Angular 5 support

Hey, are there any plans for support for Angular 5.0.0? I was actually able to update to 5 and use angular2-materialize without major problems (just the warning when i ran npm install about the unmet dependencies)

Please refer to #386


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

@bryant1410,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks -- much appreciated!

why is it closed?


[stable/kuberos] add support for custom annotations in service

What this PR does / why we need it:
Adds optional annotations to the service created by the stable/kuberos chart.
Special notes for your reviewer:
cc @timothyclarke
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test
/assign

/lgtm

/lgtm


Integrating minimally and without -fnon-call-exceptions

We have our own toolchain and flags for an old ARMv5 processor, and we have our own signal handler that doesn't expect C++ exceptions to be thrown for synchronous signals. We want to compile with different flags than the ones in your Makefile, and we really only want to get ::backtrace() to see frames before glibc's internal signal handler.
So my question is, what changes would we have to make to build/use your code, and which flags in your Makefile are 100% necessary?
Also, is there a version of GCC/glibc that fixes this issue?

I've not tested it on older cpus but I guess it should work on any arm-gnueabi-linux system. Instead of using my makefile you can just embed the source files (excluding test.cc) into your project. While the fix itself does not depend on any particular compiler flags (I think), the problem is that while my fix would allow for unwinding the signal handler stack frame, the next stack frame (the code interrupted by the signal) will usually be non-unwindable, even for synchronous signals unless that code has been compiled with -fnon-call-exceptions. Whether it's for a backtrace or throwing a C++ exception is unimportant, the unwinding mechanism used is the same. Additionally I'm using the -rdynamic linker flag to improve the output of backtrace().
To my knowledge the bug has never been fixed. There's been posts about it a few times, I've posted my code on the glibc mailing list to be used as guide on how to fix it in glibc itself (it's not a copy-paste patch), it would just require a small bit of effort and more importantly a willingness to jump through legal paperwork hoops (copyright assignment) to have the privilege of being allowed to submit a bugfix to a GNU project.

Thanks for your response. I'll give it a shot. Would you mind briefly explaining what the actual bug is that you have fixed?

I did some testing and you're right it does seem like backtrace() manages to work even without my fix... interesting, I don't think that was always the case? Perhaps I'm wrong about that, I don't remember for sure.
It's definitely puzzling why backtrace() would work while exceptions still don't, since they both rely on the same unwinding infrastructure... unless they hacked a special-case workaround into backtrace() to deal with signal stack frames instead of just actually fixing their unwinding?  That would be incredibly dumb but I'm not sure how else to explain this.  I guess it's possible it's using some kind of stack-scanning as a fallback, in which case using my fix would still be recommended since stack-scanning is inherently unreliable.
I suppose a more detailed explanation of the glibc bug and my fix would be a nice addition to the README... I'll see if can find the time to add one.

Keep in mind, with our other compiler flags, but without non-call-exceptions, backtrace would work much of the time but sometimes fail and return the same address over-and-over again (which might have been fixed by this, not sure). Now that I have added that flag, my test case is fixed, but then again, moving the crashing code around slightly has broken the backtrace in the past, so it could be possible you are seeing sporadic successes and your patch really is important.

I'm no longer puzzled why backtrace() works without my fix. I took another look at glibc's __default_sa_restorer which I mistakenly remembered as being just entirely non-unwindable, but it turned out to actually have enough information to support "virtual unwinding" which is all that's needed for backtraces.
My fix is therefore only needed if you want to throw C++ exceptions from signal handlers (whcih requires real unwinding, not merely virtual unwinding).
It sounds like the issue you were having has two parts:

your signal handler interrupted non-unwindable code, thus causing backtrace() to hit a non-unwindable frame below the signal handler frame, and
backtrace() failed to terminate when it hit the non-unwindable frame and instead ended up in an infinite loop, which is the libgcc bug you linked to.

Compiling with -fnon-call-exceptions should suffice to ensure code that may cause synchronous signals (e.g. memory accesses) is unwindable, thus hopefully this suffices to reliably fix the problem you were having. (An even stronger option would have been -fasynchronous-unwind-tables to allow unwinding literally anywhere, even from asynchronous signals, but unfortunately this option is not implemented on 32-bit ARM.)
Of course it's still always possible to encounter an unwindable stack frame somewhere in the call chain, e.g. C code that has been compiled with -fno-exceptions (though note that -fexceptions is the default on 32-bit ARM even for C code) or assembly code that hasn't been manually annotated with unwinding information. It is therefore still a good idea to ensure you're using a sufficiently recent libgcc that includes this bugfix.

Thank you so much! Two final questions, when you say "it is therefore still a good idea to ensure you're using a sufficiently recent libgcc that includes this bugfix," are you referring to the bug I linked? Because I thought that was a bug in libstdc++ (libsupc++). Second, I noticed that omitting either -mapcs-frame or -fno-omit-frame-pointer (while including -fnon-call-exceptions) both broke traces again. Is this b/c of an old version of libraries, or are both of these required?

Ah I saw the bug was tagged with "Component: libgcc" which makes sense since libgcc is where the unwinder code lives, but you're right I see the actual patch was done in libstdc++.
-fno-omit-frame-pointer ? -mapcs-frame ??  Wait are you still using OABI (the legacy ARM ABI) or something?  Those options are definitely not relevant for unwinding on ARM EABI.

I bet. My work is still building for ARMv5 of all things. Those flags definitely change the output enough to cause traces to fail for crashes in the same function. If they shouldn't be relevant, then I can only imagine that it's an issue with the installed versions of libc/libstdc++, etc. I have upgraded our toolchains, but I haven't been able to update the installed libraries on the remote machines. Those were built back in 2015. Interestingly, building statically usually causes the traces to be worse, but maybe that's b/c when I built gcc from source I didn't build it with -fnon-call-exceptions? At any rate, I will have a chance to rebuild our toolchain and installed libraries soon.

ARMv5 doesn't imply OABI, e.g. Debian 5 (Lenny) introduced an ARM EABI port for v4T/v5T/v6 and the old OABI port was discontinued in the next release since the new EABI is just better. The debian wiki lists a few ways to tell which ABI a binary has been compiled for, e.g. on armhf I get:
$ objdump -x /bin/true | grep 'private flags'
private flags = 5000400: [Version5 EABI] [hard-float ABI]
$ readelf -h /bin/true | grep Flags
  Flags:                             0x5000400, Version5 EABI, hard-float ABI

Anyway... if you are using OABI then I can't really help you, I've never worked with it and I have no idea how unwinding worked in those prehistoric times. Everything I've said in this thread is applicable to ARM EABI, but I have no idea whether any of it applies to OABI.

Oh yeah, sorry. I edited my post. It's EABI.

Then what you're saying makes no sense... -mapcs-frame is some obsolete option and frame pointers are not relevant for unwinding on ARM EABI.
And only the code that contains the actual cpu instruction that crashes (and thus gets interrupted by the signal) needs to be compiled with -fnon-call-exceptions, remaining code only needs -fexceptions which should be enabled by default on ARM EABI.

Haha. Well, I'm just reporting what's happening. If I remove one of those, flags, I can get a bad/repeating stack trace for the same crash location. -fno-omit-frame-pointer kept the trace from breaking with -O2, and the other kept the trace from breaking just in general. But as I said before, I accepted the possibility that those were just sporadic failures due to changes in the compiled code, with the actual problem being more fundamental.
So, the idea is that I shouldn't need either of those flags, and therefore the unwind implementation I am linking with is buggy, and linking with your implementation could fix it in the meantime?

My fix is not an unwind implementation, it just assists libgcc's unwind implementation with unwinding the signal stack frame (the stack frame created by the kernel for signal delivery) and, like I've already explained a few comments ago, is only needed if you want to throw an exception out of a signal handler. Since you only want to backtrace, this repository is not useful for you.
The stack trace going into an infinite loop is presumably the bug you mentioned hence should be fixable by updating libstdc++ (if you don't want to update the library on the target you could statically link to a newer version). But I don't really know what might be the cause of your problems, I am however inclined with your hypothesis that changing compiler flags is probably just affecting the outcome by randomly perturbing the generated code.
If you were using a newer core I'd be inclined to question whether your signals are actually synchronous, but I don't think ARM9EJ-S has any asynchronous exceptions whatsoever. So I guess it's possible you've got a buggy unwinder or a buggy compiler?  I really don't know.

Ah well. I've learned a lot nonetheless. I'll close this for now. If I ever find out what is wrong, I'll come add another comment here in case someone else finds this thread. Thanks a lot.


owner(ticdc): fix changefeed backoff

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/test verify

Well done! After the addition of the pending and warning states, there's no longer a need for a stateWindow to check if the changefeed is in an error-retrying state. This PR makes the error retry logic more concise and reduces the complexity of the code.

/retest


Crash if node id malformed

If a connecting client sends a malformed id/port message, server will throw an uncaught exception.
In run(), I threw a try/except around the split to catch the error, but maybe there are better solutions?
                   if ":" in connected_node_id:
                        print("Got connected node id", connected_node_id)
                        try:
                                (connected_node_id, connected_node_port) = connected_node_id.split(':') # When a node is connected, it sends it id!
                        except Exception as e:
                                print(e)
                                connection.close()
                                continue

Sorry -- wrong project. Please delete!


add support for external data sources

Hello,
This PR triggers the following events when items are dropped from an external source:

@node-drop-ext
@node-over-ext
@node-dragenter-ext
@node-dragleave-ext

Would it be possible to create a new npm version once this PR is merged?
Thx!

Hey this is cool idea, I think it could be more consistent if there is no "ext" in event name and everything goes in same event. The "external" nature could be handled by sending an object like:
{  external: boolean,  dataTransfer,  node }
Also in your PR, events seems to be fired twice (drop can emit "drop" and "dropext")
What do you think ?

Hey this is cool idea, I think it could be more consistent if there is no "ext" in event name and everything goes in same event. The "external" nature could be handled by sending an object like:
{ external: boolean, dataTransfer, node }
Also in your PR, events seems to be fired twice (drop can emit "drop" and "dropext")
What do you think ?

Excellent idea, I didn't know if I could alter the standard events.
I made the changes, I let you check if it fits your idea :)

Looks really good ! Can you update documentation ?

Done! I also always added the "evt, external & dataTransfer" data to be more consistent

Seems that tests are broken can you repair it ? ^^

Sorry about that, fixed


dcl deploy: Connect to Builder API to upload assets for curation (Portable experiences)

The PR https://github.com/decentraland/cli/pull/647 got old, maybe redefine the scope in the new sdk-commands library.


modify photon ks file to put swap partition as the last item

fix https://rackhd.atlassian.net/browse/RAC-4324, which complains inproper UI display after installing Photon OS using full payload in https://github.com/RackHD/RackHD/blob/master/example/samples/install_photon_os_payload_full.json
From KS file sample provided by Photon, the swap partition is the last item in the "partition" field. This PR modify the rendering rule in ks template to align with it and pass the test.

comments added in code


M44 Filter on CPSC manufacturer name, then search products

Not needed anyone due to Nadia's epiphany.