Add a timeout to usb_64drive_waitidle

This change allows the application on N64 not to block even if UNFLoader is stopped.
Since usb.c is being vendored into libdragon, this change is important to open up for different tools that have a different approach compared to UNFLoader. While UNFLoader is a all-in-one tool to upload + debug N64 application, one can imagine some simpler tool that simply connects to the USB streams to monitor logs sent with the same protocol (a log viewer). Such an application might be started and stopped at any time during the N64 application lifetime, and we don't want the application to break whenever the tool Is stopped.

Tested your changes and they seem to not cause problems with the samples. Thanks a lot! :smiley:


White trails got generated when user made changes in the size and indicators

SEVERITY:  Major
MODULE: Bubble Chart
PLATFORM:

Windows 7 / Chrome 49.0
Windows 7 / Firefox 44.0

STEPS TO REPRODUCE:

Navigate to the URL: http://tools-stage.gapminderdev.org
Drag back the slider
Click on color and choose Child mortality rate
Click on option -> size
Increase the size
Observe white bubbles appear
Click the bubbles and click play to generate trails

ACTUAL RESULTS:
White trails got generated when user made changes in the size
EXPECTED RESULTS:
All bubbles should have proper  color
SCREENSHOT:

this is expected: data is missing, so the color is white. we will add explanation for it later into the color legend


g-exam:0.4.1

I am submitting

[ ] a new package

[x] an update for a package

Fix student data.

Fix Indenting subquestion.

Thank you.


Implement flake8-pyi

flake8-pyi
Error codes

[x] Y001 Names of TypeVars, ParamSpecs and TypeVarTuples in stubs should usually start with _. This makes sure you don't accidentally expose names internal to the stub.
[x] Y002 If test must be a simple comparison against sys.platform or sys.version_info. Stub files support simple conditionals to indicate differences between Python versions or platforms, but type checkers only understand a limited subset of Python syntax, and this warning triggers on conditionals that type checkers will probably not understand.
[x] Y003 Unrecognized sys.version_info check. Similar, but triggers on some comparisons involving version checks.
[x] Y004 Version comparison must use only major and minor version. Type checkers like mypy don't know about patch versions of Python (e.g. 3.4.3 versus 3.4.4), only major and minor versions (3.3 versus 3.4). Therefore, version checks in stubs should only use the major and minor versions. If new functionality was introduced in a patch version, pretend that it was there all along.
[x] Y005 Version comparison must be against a length-n tuple.
[x] Y006 Use only < and >= for version comparisons. Comparisons involving > and <= may produce unintuitive results when tools do use the full sys.version_info tuple.
[x] Y007 Unrecognized sys.platform check. Platform checks should be simple string comparisons.
[x] Y008 Unrecognized platform. To prevent you from typos, we warn if you use a platform name outside a small set of known platforms (e.g. "linux" and "win32").
[x] Y009 Empty body should contain ..., not pass. This is just a stylistic choice, but it's the one typeshed made.
[x] Y010 Function body must contain only .... Stub files should not contain code, so function bodies should be empty.
[x] Y011 All default values for typed function arguments must be .... Type checkers ignore the default value, so the default value is not useful information in a stub file.
[x] Y012 Class body must not contain pass.
[x] Y013 Non-empty class body must not contain ....
[x] Y014 All default values for arguments must be .... A stronger version of Y011 that includes arguments without type annotations.
[x] Y015 Attribute must not have a default value other than ....
[x] Y016 Unions shouldn't contain duplicates, e.g. str | str is not allowed.
[ ] Y017 Stubs should not contain assignments with multiple targets or non-name targets.
[ ] Y018 A private TypeVar should be used at least once in the file in which it is defined.
[ ] Y019 Certain kinds of methods should use _typeshed.Self instead of defining custom TypeVars for their return annotation. This check currently applies for instance methods that return self, class methods that return an instance of cls, and __new__ methods.
[x] Y020 Quoted annotations should never be used in stubs.
[x] Y021 Docstrings should not be included in stubs.
[x] Y022 Imports linting: use typing-module aliases to stdlib objects as little as possible (e.g. builtins.list over typing.List, collections.Counter over typing.Counter, etc.). (UP035)
[ ] Y023 Where there is no detriment to backwards compatibility, import objects such as ClassVar and NoReturn from typing rather than typing_extensions.
[ ] Y024 Use typing.NamedTuple instead of collections.namedtuple, as it allows for more precise type inference.
[x] Y025 Always alias collections.abc.Set when importing it, so as to avoid confusion with builtins.set.
[ ] Y026 Type aliases should be explicitly demarcated with typing.TypeAlias.
[ ] Y027 Same as Y022. Unlike Y022, however, the imports disallowed with this error code are required if you wish to write Python 2-compatible stubs. Switch this error code off in your config file if you support Python 2.
[x] Y028 Always use class-based syntax for typing.NamedTuple, instead of assignment-based syntax. (UP014)
[x] Y029 It is almost always redundant to define __str__ or __repr__ in a stub file, as the signatures are almost always identical to object.__str__ and object.__repr__.
[ ] Y030 Union expressions should never have more than one Literal member, as Literal[1] | Literal[2] is semantically identical to Literal[1, 2].
[x] Y031 TypedDicts should use class-based syntax instead of assignment-based syntax wherever possible. (In situations where this is not possible, such as if a field is a Python keyword or an invalid identifier, this error will not be raised.) (UP013)
[x] Y032 The second argument of an __eq__ or __ne__ method should usually be annotated with object rather than Any.
[x] Y033 Do not use type comments (e.g. x = ... # type: int) in stubs, even if the stub supports Python 2. Always use annotations instead (e.g. x: int).
[x] Y034 Y034 detects common errors where certain methods are annotated as having a fixed return type, despite returning self at runtime. Such methods should be annotated with _typeshed.Self. This check looks for:

1.  Any in-place BinOp dunder methods (__iadd__, __ior__, etc.) that do not return Self.
  2.  __new__, __enter__ and __aenter__ methods that return the class's name unparameterised.
  3.  __iter__ methods that return Iterator, even if the class inherits directly from Iterator.
  4.  __aiter__ methods that return AsyncIterator, even if the class inherits directly from AsyncIterator.
This check excludes methods decorated with @overload or @abstractmethod.

[x] Y035 __all__ and __match_args__ in a stub file should always have values, as these special variables in a .pyi file have identical semantics to __all__ and __match_args__ in a .py file. E.g. write __all__ = ["foo", "bar"] instead of __all__: list[str].
[ ] Y036 Y036 detects common errors in __exit__ and __aexit__ methods. For example, the first argument in an __exit__ method should either be annotated with object or type[BaseException] | None.
[x] Y037 Use PEP 604 syntax instead of typing.Union and typing.Optional. E.g. use str | int instead of Union[str, int], and use str | None instead of Optional[str]. (UP007)
[x] Y038 Use from collections.abc import Set as AbstractSet instead of from typing import AbstractSet. Like Y027, this error code should be switched off in your config file if your stubs support Python 2. (UP035)
[x] Y039 Use str instead of typing.Text. This error code is incompatible with stubs supporting Python 2. (Implemented as UP019.)
[x] Y040 Never explicitly inherit from object, as all classes implicitly inherit from object in Python 3. This error code is incompatible with stubs supporting Python 2. (Implemented as UP004.)
[ ] Y041 Y041 detects redundant numeric unions. For example, PEP 484 specifies that type checkers should treat int as an implicit subtype of float, so int is redundant in the union int | float. In the same way, int is redundant in the union int | complex, and float is redundant in the union float | complex.
[x] Y042 Type alias names should use CamelCase rather than snake_case
[x] Y043 Do not use names ending in "T" for private type aliases. (The "T" suffix implies that an object is a TypeVar.)
[x] Y044 from __future__ import annotations has no effect in stub files, since type checkers automatically treat stubs as having those semantics.
[x] Y045 __iter__ methods should never return Iterable[T], as they should always return some kind of iterator.
[ ] Y046 A private Protocol should be used at least once in the file in which it is defined.
[ ] Y047 A private TypeAlias should be used at least once in the file in which it is defined.
[x] Y048 Function bodies should contain exactly one statement. (Note that if a function body includes a docstring, the docstring counts as a "statement".)
[ ] Y049 A private TypedDict should be used at least once in the file in which it is defined.
[x] Y050 Prefer typing_extensions.Never over typing.NoReturn for argument annotations. This is a purely stylistic choice in the name of readability.
[ ] Y051 Y051 detect redundant unions between Literal types and builtin supertypes. For example, Literal[5] is redundant in the union int | Literal[5], and Literal[True] is redundant in the union Literal[True] | bool.
[x] Y052 Y052 disallows assignments to constant values where the assignment does not have a type annotation. For example, x = 0 in the global namespace is ambiguous in a stub, as there are four different types that could be inferred for the variable x: int, Final[int], Literal[0], or Final[Literal[0]]. Enum members are excluded from this check, as are various special assignments such as __all__ and __match_args__.
[x] Y053 Only string and bytes literals <=50 characters long are permitted.
[x] Y054 Only numeric literals with a string representation <=10 characters long are permitted.
[ ] Y055 Unions of the form type[X] \| type[Y] can be simplified to type[X \| Y]. Similarly, Union[type[X], type[Y]] can be simplified to type[Union[X, Y]].
[ ] Y056 Do not call methods such as .append(), .extend() or .remove() on __all__. Different type checkers have varying levels of support for calling these methods on __all__. Use += instead, which is known to be supported by all major type checkers.

Flake8-pyi currently only works with .pyi files (https://github.com/PyCQA/flake8-pyi/issues/118), it would be great if Ruff could support .py files.
Flake8-pyi author list some rules in https://github.com/qutebrowser/qutebrowser/issues/7098#issuecomment-1109959035 that can be easily apply to .py files
In addition, there are some rules that overlap with pyupgrade, such as Y037 and U007.

These are being implemented under the PYI prefix (we tend to avoid single-letter prefixes like Y, since they lead to conflicts).

Since opening Y014 and Y011 have changed behavior to allow some defaults, do you think we should mirror the new behavior?
https://github.com/PyCQA/flake8-pyi/pull/326
https://github.com/PyCQA/flake8-pyi/issues/316

@sbdchd - Yeah I'd vote to mirror their behavior.

I second @SigureMo, it would be great if some rules like Y006 would apply to *.py files as well.

I'm implementing PYI030

I am implementing PYI036

I'm implementing PYI041

I'm implementing PYI026

I'm implementing PYI017

I'm implementing PYI024

I'm implementing PYI056

I'm implementing PYI018 and PYI046, PYI047, PYI049 (which are similar to PYI018)

I'm implementing PYI051

I'm implementing PYI019

I'm implementing PYI055

I'm implementing PYI023

Done! Thanks everyone!


Add EnableDeliveryReports to KafkaAttribute

Being able to set EnableDeliveryReports is quite valuable, since the collector uses ProduceAsync behind the scenes. In high volume scenarios, the difference is huge (and the delivery reports are never exposed anyway).
Also, the MaxMessageBytes value was never properly copied.

Trying to fix commits. Have no idea what happened.

Hi @gliljas
It looks awesome. Thank you for your contributions!
One last request is, could you update the documentation? I mean Readme.md of this repo.

"Documentation" added

Rebased

@shrohilla

@gliljas I would recommend to wait for PR. Post that we will look into this.
1 quick question, do you have any metric how this change will impact in huge volume scenario ??


Document review and corrections for Getting Started

Document review and corrections for Getting Started
Complete review of the Getting Started section, making the following changes:
Consistent titles and sidebar_labels
Consistent headers and header spacing
Remove trailing spaces
Consistent package naming
Consistent punctuation
Correct typos
Americanize spelling to cater for a wider audience

You're more than welcome @FilledStacks - and I'm not sure that I've got anything in my IDE that you haven't... That said, I've recently added the following extension to VSCode which I'm finding quite useful:
https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker


Significant Discrepancy in Natural Period Calculation Between OpenFAST and AQWA for Floating Platform

Hello everyone,
I have some questions I’d like to ask. When calculating the natural period of a novel floating platform through free decay analysis in OpenFAST, I noticed a significant difference compared to the results from AQWA for the same platform. I have already followed Professor Jonkman’s suggestions and adjusted the relevant parameters to ensure consistency, but there are still some discrepancies. As shown in the figure below, could you please advise if I might have missed any parameters or made any incorrect settings?
Thank you in advance for your help!

Dear @cx330-xxr,
You haven't shared any information on your model set up in OpenFAST or AQWA to really comment.  Overall, it looks like the surge free-decay response is similar between OpenFAST and AQWA, with quite similar damping levels, but with a small difference in natural period.  This suggests a small difference in the body mass, added mass, or mooring stiffness in the surge direction
Best regards,

Thanks for responding,Professor Jonkman
This is my .fst file setting

this is elastodyn.dat

this is hydrodyn.dat

Here are the details of how I was involved in the calculation.

Here are the details of how I was involved in the calculation.

Here are the details of how I was involved in the calculation.

Dear @cx330-xxr,
Does the full-system mass as reported in the ElastoDyn summary (*.ED.sum) file match total mass from your table, which presumably is the mass you entered in AQWA?
Does the added-mass in surge from WAMIT that you are using in HydroDyn (marin_semi.1) match that of AQWA?
Is your mooring model set up similar in AQWA as it is in MoorDyn?
Best regards

Thank you very much. I will check them one by one.


Add config for dimming inactive windows

Summary
This adds a (bool) configuration option dim_inactive (default false) to allow users to dim inactive windows/buffers/splits.
Related Issue(s)
https://github.com/catppuccin/nvim/issues/89
Notes
I tested the colors locally and they seem to indicate pretty clearly which window is active and which is inactive. I basically used hex tool and picked the next dimmer color from base.

Hey! nice feat. I ended up reworking it a little and adding the ability to choose which shade to put over inactive windows.

Hey! nice feat. I ended up reworking it a little and adding the ability to choose which shade to put over inactive windows.

Oh neat, thanks for landing it!

Check out the dev branch, it's working there :)


Disable enable_spectator_access setting in UI when server-level setting is set to False.

First commit just removes unused variable and a class.
Second commit removes the render_only argument which was originally added to hide the setting according to server-level setting but was incorrect.
Third commit is for disabling the setting in Ui according to sever-level setting.

Fixes #20417.
GIFs or screenshots:
Enabled

Disabled

For now, I have kept the help link even when setting is enabled as per the current code of settings_checkbox. I think it is fine as this is a new feature. Is it fine or we should only show when setting is disabled?

Merged, thanks @sahil839!


[WIP] Loc loco: Fix behavior of MatchWithoutCurrentValue when stars aren't present in path.

This PR closes #1669 as it resolves the issue whereby given a menu declared like so:
    lazy val product = Menu.param[ProductInfo]("product", "Product Detail Page",
      id   => lookup(id),
      info => info.id.toString
      ) / "product" >> MatchWithoutCurrentValue >> FallbackToSearchPage

The MatchWithoutCurrentValue would not behave as expected because we hit a different processing pipeline due the absence of the star. Turns out that when we're working with Menu's that lack a star they create a RewriteResponse internally. However, the code that creates that RewriteResponse is explicitly running the lookup function and failing to issue the rewrite if the function returns anything other than Full.
With these changes, we've resolved that issue. Now, LocRewrites can be issued even when T can't be resolved, meaning the above code will work as expected.
Hat tip to @d6y for finding the original bug.
Some TODOs:

[x] Figure out a way to test this thing.
[x] Figure out what (if anything) we want to do for Lift 2.6. (though I suppose that doesn't block this getting merged into master)

Per the ML thread we're punting on backporting this to 2.6.

Alright, unfortunately I had to touch a few things in lift-proto to make everything happy – but now everything compiles. Let's see what TravisCI says, but I'm removing the "[WIP]" prefix from this branch.

So in this new code path, if MatchWithoutCurrentValue isn't included, do we properly 404? Particularly thinking about the lift-proto stuff since it seems like it may be using it to set up default CRUD pages.

Yes. We should properly 404 in the event that isn't tacked on.

Tests appear to be capable of passing in spite of what the build status indicates. I'm going to leave this up for another day or so and then turbo merge it.


Invalid literal for int()

Wanna show me how to debug and fix?
[chandler:~/source/cloud-compare] master* ± pip list 2> /dev/null | grep jang
Django (1.9)
pep8 (1.7.0)
[chandler:~/source/cloud-compare] master* ± python -V
Python 2.7.13
[chandler:~/source/cloud-compare] master* 1 ± sqlite3 -version
<IP_ADDRESS> 2013-09-03 17:11:13 7dd4968f235d6e1ca9547cda9cf3bd570e1609ef
======================================================================
ERROR: test_aws (tests.test_scrape.ScrapeTest)
Traceback (most recent call last):
File "/Users/chandler/source/cloud-compare/tests/test_scrape.py", line 32, in test_aws
call_command('ingest', self.tmpdir)
File "/usr/local/lib/python2.7/site-packages/django/core/management/init.py", line 119, in call_command
return command.execute(*args, **defaults)
File "/usr/local/lib/python2.7/site-packages/django/core/management/base.py", line 399, in execute
output = self.handle(*args, **options)
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 319, in handle
ingestAmazon(directory, path2name(mjs['path']))
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 172, in ingestAmazon
ingest_AWS_offer(ojs, opath)
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 135, in ingest_AWS_offer
AWS.objects.bulk_create(updates)
File "/usr/local/lib/python2.7/site-packages/django/db/models/manager.py", line 122, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 450, in bulk_create
self._batched_insert(objs_without_pk, fields, batch_size)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 1056, in _batched_insert
using=self.db)
File "/usr/local/lib/python2.7/site-packages/django/db/models/manager.py", line 122, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 1039, in _insert
return query.get_compiler(using=using).execute_sql(return_id)
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1063, in execute_sql
for sql, params in self.as_sql():
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1023, in as_sql
for obj in self.query.objs
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 962, in prepare_value
value = field.get_db_prep_save(value, connection=self.connection)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 728, in get_db_prep_save
prepared=False)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 720, in get_db_prep_value
value = self.get_prep_value(value)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 1853, in get_prep_value
return int(value)
ValueError: invalid literal for int() with base 10: '0.645000000000000017763568394002504646778106689453125'

Ran 5 tests in 739.898s
FAILED (errors=1)
Destroying test database for alias 'default'...

======================================================================
ERROR: test_aws (tests.test_scrape.ScrapeTest)
Traceback (most recent call last):
File "/Users/chandler/source/cloud-compare/tests/test_scrape.py", line 32, in test_aws
call_command('ingest', self.tmpdir)
File "/usr/local/lib/python2.7/site-packages/django/core/management/init.py", line 119, in call_command
return command.execute(*args, **defaults)
File "/usr/local/lib/python2.7/site-packages/django/core/management/base.py", line 399, in execute
output = self.handle(*args, **options)
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 319, in handle
ingestAmazon(directory, path2name(mjs['path']))
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 172, in ingestAmazon
ingest_AWS_offer(ojs, opath)
File "/Users/chandler/source/cloud-compare/pricing/management/commands/ingest.py", line 135, in ingest_AWS_offer
AWS.objects.bulk_create(updates)
File "/usr/local/lib/python2.7/site-packages/django/db/models/manager.py", line 122, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 450, in bulk_create
self._batched_insert(objs_without_pk, fields, batch_size)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 1056, in _batched_insert
using=self.db)
File "/usr/local/lib/python2.7/site-packages/django/db/models/manager.py", line 122, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/usr/local/lib/python2.7/site-packages/django/db/models/query.py", line 1039, in _insert
return query.get_compiler(using=using).execute_sql(return_id)
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1063, in execute_sql
for sql, params in self.as_sql():
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1023, in as_sql
for obj in self.query.objs
File "/usr/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 962, in prepare_value
value = field.get_db_prep_save(value, connection=self.connection)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 728, in get_db_prep_save
prepared=False)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 720, in get_db_prep_value
value = self.get_prep_value(value)
File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/init.py", line 1789, in get_prep_value
return float(value)
ValueError: could not convert string to float:

Ran 5 tests in 865.018s
FAILED (errors=1)
Destroying test database for alias 'default'...

It looks like the Amazon field formats have changed a bit.

beginRange isn't aways an integer, although that may be a mistake on Amazon's end.
There are new entries where 'memory' is encoded as xx.xx GB instead of xx.xx Gib. Our  current translation messes this up.


Fix gpt engineer

The pdm module had a recent change to remove the .pythonInterpreter attribute, which this package used.

Thanks


Incremental task execution cross-compilation doesn't work

Running the the build task subsequently without changing the configuration or code does not make the cross-compilation tasks up-to-date. Each cross-compilation task should be marked up-to-date if the binary file already exists.
Build execution 1:
$ gradle build --console=plain
Parallel execution is an incubating feature.
Found go 1.8.3 in /usr/local/go/bin/go, use it.
:prepare
Found global GOPATH: /Users/bmuschko/.gopath.
:resolveBuildDependencies
Resolving github.com/mvdan/xurls: commit='d315b61cf6727664f310fa87b3197e9faf2a8513', urls=[https://github.com/mvdan/xurls.git, git@github.com:mvdan/xurls.git]
:installDependencies
:buildDarwinAmd64
:buildNetbsd386
:buildNetbsdAmd64

Build execution 2:
$ gradle build --console=plain
Parallel execution is an incubating feature.
Found go 1.8.3 in /usr/local/go/bin/go, use it.
:prepare
Found global GOPATH: /Users/bmuschko/.gopath.
:resolveBuildDependencies UP-TO-DATE
:installDependencies
:buildDarwinAmd64
:buildNetbsd386
:buildNetbsdAmd64
:build

Closed by 0.9. Thanks for reporting.


ECCVM receives/hashes transcript commitments

@Rumata888 pointed out that the ECCVM should receive and hash the four aggregate transcript column commitments $[T_j], j = 0,1,2,3$. These are output as part of the proof of the final merge protocol. Need to determine the correct way to do this. Public inputs?

Closed by https://github.com/AztecProtocol/aztec-packages/pull/3433


Puzzle x16415

URL

[ ] Image
[ ] Type
[ ] Defaults
[ ] Connections
[ ] Description
[ ] Verify

https://www.youtube.com/watch?v=3DkzQ_apHpQ 4:12


SODA-A config

Branch
master branch  https://mmdetection.readthedocs.io/en/latest/
📚 The doc issue
I wonder if it is possible to upload the config file of obb task based on SODA-A. Cus there is only hbb config. Thank you so much for sharing.
Suggest a potential alternative/fix
No response

Sry, this is not in ou plan.
The code structure of mmrot is highly similar to that of mmdet, and RotatedRPN outputs hbb proposals and the operation about region features in feature_imitation_roi_head.py has nothing to do with hbb or obb, which means just transfering the codes in crpn_head.py and feature_imitation_roi_head.py to rotated_rpn.py and rotate_standard_roi_head.py will work

According to what you mean, I only need to modify your improved codes in crpn_head.py and feature_imitation_roi_head.py in mmdet, and modify them in the corresponding places of rotated_rpn.py and rotate_standard_roi_head.py in mmrotate? Then do I use the mmrotate module when training? Based on this modification, I can copy your configs/cfinet/faster_rcnn_r50_fpn_cfinet_1x.py file to SODA-mmrotate
/configs/, and then use SODA-mmrotate’s train.py for training, or should you stay in the original CFINet file and use train.py for training? Looking forward to your reply. @shaunyuan22

OKay, thanks for your replying.

This is just my idea. I have just started in this direction. If you try it successfully, can you share how to modify it? Thank you！！！

According to what you mean, I only need to modify your improved codes in crpn_head.py and feature_imitation_roi_head.py in mmdet, and modify them in the corresponding places of rotated_rpn.py and rotate_standard_roi_head.py in mmrotate? Then do I use the mmrotate module when training? Based on this modification, I can copy your configs/cfinet/faster_rcnn_r50_fpn_cfinet_1x.py file to SODA-mmrotate /configs/, and then use SODA-mmrotate’s train.py for training, or should you stay in the original CFINet file and use train.py for training? Looking forward to your reply. @shaunyuan22

exactly right, maybe it takes a few modifications when copying the config


Empty window when opening or creating Notebook

Issue Type: Bug

Double click on an existing Notebook or select "Python: Create New Blank Jupyter Notebook" from the pallet.
About half the time you are greeted with a nice empty window (see below) that I cannot do anything with. Closing the window and trying again usually resolves the problem. Sometimes it doesn't. Third time is usually the charm.

Actual behavior:

Expected behavior:

Extension version: 2020.5.80290
VS Code version: Code - OSS 1.46.0 (3984852b33bd6897dd83108ac305c567d49e8fda, 2020-05-15T14:46:12.527Z)
OS version: Linux x64 5.4.0-29-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1627)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
15.23GB (2.57GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Same issue is also present in the current official release of vscode.

@dimitry-ishenko Thanks for reporting this. And I've seen this issue cropping up a few times as well. The next time this happens could you run the following command from vscode?
"Developer: Open Webview Developer Tools"
Then see if there is anything in the console window there? There seem to be some general webview activation issues that are happening and that log should help show what's going on. Note that this is different from the normal Help->Toggle Developer Tools option in VSCode that shows the console for the whole of VSCode, but the webview developer tools are just for the opened webviews.

@IanMatthewHuff not sure if this helps, but here you go:

And for completeness this is what I get when it successfully opens the Notebook:

@dimitry-ishenko Thanks. That is helpful. We've seen more customer reports of this recently. Seems to be a general issue with starting up a web view in VSCode. I've seen that same ERR_UNKNOWN_URL_SCHEME message myself, so I know that it's the same issue that you are seeing as well.

@IanMatthewHuff thanks for looking into it and holler if you need anything else

@dimitry-ishenko We did some looking around on our team. Seems like this was a general VSCode issue with webviews. Per this issue here:
https://github.com/microsoft/vscode/issues/89038
Looks like a fix might be in VSCode-insiders right now if you wanted to try that out.
https://code.visualstudio.com/insiders/

@IanMatthewHuff initial results look good! I've gotten 10 for 10 opening on the first trial. Thank you!

@IanMatthewHuff sadly, I am still seeing this issue:

@dimitry-ishenko I'm actually going to close this issue down. Not because it's not a problem, but because we already have this issue here:
https://github.com/microsoft/vscode-python/issues/11865
Tracking it. I believe that updating VSCode insiders did fix the ERR_UNKNOWN_URL_SCHEME issue, but now you are hitting the 401 unauthorized coming from font-awesome. The issue for #11865 is what we're going to use to track the 401 issue.


read and write compressed file

we can use :

zlib
bz2
gzstream
boost::iostreams

Allowing to read/write from stdin/stdout is another lightweight and versatile option.

Solve by rewritting in rust.


Put single chars in single quotes

"\n" makes an extra call to strlen.
I either put it in single quotes or used Debug::println.

Thanks for your contribution!


Change usage steps in README

Signed-off-by: Alex Humphreys<EMAIL_ADDRESS>

The repository was missing the .vscode/launch.json file. The instructions should work now. Could you try again and report, @alexhumphreys?

Those extra files solved it, this shouldn't be needed anymore.


Switch to relative file paths

Instead of absolute file paths in the code, convert them to relative file paths so that users at other sites can more easily reuse and contribute to the code.

Switched to relative file paths in both the viewer https://github.com/amedwards/NICUHDF5Viewer/commit/ea952122688640aec1a41e75bb26b3c3fec24c4b and in the Batch Algorithm Processor https://github.com/amedwards/BatchAlgorithmProcessor/commit/0ce1120df3e2110879421145a8c8711cd02d2624


tui: Use half-block characters for memory graph

This is easier to read than our previous braille version, and looks nicer when rendered in a browser or VS Code. It's less granular, unfortunately. The braille version added a new dot for each ~6%, and this implementation adds a new half block for each ~11%.
This also fixes a longstanding bug: the graph was only showing half of the data points it should have been showing. Each data point would become the right braille column of one cell as well as the left braille column of the next cell, so we only had half the horizontal granularity we should have had.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1cce4cb) 92.30% compared to head (bc029c3) 92.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   92.30%   92.27%   -0.03%
==========================================
  Files          91       91
  Lines       11033    11030       -3
  Branches     1524     1526       +2
==========================================
- Hits        10184    10178       -6
- Misses        844      847       +3
  Partials        5        5

Flag
Coverage Δ

cpp
85.83% <ø> (-0.09%)
:arrow_down:

python_and_cython
95.47% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: basic linting and building in ci

Thanks! Automatic builds are great. However, I cannot merge this with all the linting in place, as discussed before. Looking throug this it also changes boomer style for-loops to iterator based loops using auto. I discourage the use of auto because it is easy to write but harder to read. Also, I would prefer to stay away from iterators if a boomer style for loop can provide the same functionality. Sometimes, iterators make sense when you deal with STL's <algorithm>s . I use it once in polysoup because it initally was an offline tool from a previous project. Offline tools can be more bloated imo, the game itself should be as tight as possible.
Many files have been changed and I want to look at each carefully. Atm, I don't have the time to make a new mental map about the codebase. I suggest we take a step back after Oct. 31st, when the game is running, and carefully take on linting as its own task. I really don't  want to do deal with this right now.

i would really like to have linting in place before the end of october and i see no problem with it. the rule that changed the auto can be removed as fast as it was added :)
could you explain a bit further why you discourage auto that much? i find it quite handy for example when casting right afterwards. eg: auto x = (superLongTypeWhateverItIs *)y;
i see it could be irritating in the for loop, but i come from a place where i want to let the compiler handle as much typing as possible. being to strict about the typings let's you introduce another set of bugs that could be handled automatically by the tooling.

i reverted the iterator stuff :)
if you disable the whitespace highlighting in github or your editor while reviewing it makes this much easier to parse :)

i find it quite handy for example when casting right afterwards. eg: auto x = (superLongTypeWhateverItIs *)y;

This seems reasonable. I rarely come into this situation, though, where I have superLongTypeWhateverItIs apart from when I use "modern C++" (which I don't) or a library such as Eigen that has everything::scoped::to::the::tiniest::instance<andOnTop::isA::template::makeHell<this::is::dumb>(hell)> . You get the idea ;)
There are more changes the linter did I am also not fond of and I am not going to discuss them right now.

i would really like to have linting in place before the end of october and i see no problem with it.

I do get why linting can be useful but I also don't want to see a wall of changes that do not contribute anything meaningful after I spent a day of programming. As I said, we can all get together after Oct. 31st and discuss the linter's settings so that it works in favor of all of us. If you're not comfortable with that decision or willing to accept it I am sorry, I am not going to change my mind about it.
I am getting strong Uncle Bob 'Clean Code' vibes here. Getting lost in 'the beauty of code'.
And I have not spent a lot of time - way longer before this course started - programming in Quake(2) and thinking about game related code just to now argue with someone about this. At this point I'd rather not have you to touch
any code and focus on game design - something we already have changed because we all agree that working
on something one doesn't 'feel' is not motivating.
I have fought very long for this project to happen as part of a course and I am not willing
to get this derailed.


Fix filepath to app.conf

Fix wrong path to app.conf

Coverage remained the same at 50.704% when pulling c9601ef169e10c088b42433e640347567906eb14 on senk:fix-docs into 811b472af44c720b82191a7886e47b7f6eb0d5b3 on vmware:master.

Thanks!


devlib: strip space for adb pull source dir

There may be space at the end of the string line.
This will cause adb pull failed.

Please help to verify and merge the patch.


Ignore Commands In Certain Scenarios

In certain cases, commands should be ignored and not actually executed by beatz-bot. The main example would be in the case of a command being surrounded by back ticks (rtd 6d2), as that may generally be used when showing other users how commands work, or speculating on new syntax/commands.
It may also be desired that beatz-bot also ignores commands that are not at the start of a message ("... rtd should sum the values. Might look into that when I have a moment. (e.g. rtd 2d6 = You rolled 3, 2 (5))"), since it is likely that those commands are meant to be the subject of discussion, and not meant to be actually executed.

@grantjbutler See #29 for another take on fixing this.

I think there's merit to only wanting to care about the rtd message if it starts with it.


Building a Cross-Platform PerfView

There has been some renewed interest in building a cross-platform version of PerfView.  Historically, PerfViewJS was an attempt at this, however, it had one big issue that ultimately caused us to archive the repo.  Whenever a new feature was added to PerfView, it did not automatically get added to PerfViewJS.  This is because PerfViewJS isn't PerfView - It is a TraceEvent-based viewer with a web-based front-end.  While valuable, there wasn't sufficient interest in adding features to PerfViewJS after they were added to PerfView.
Going forward, if we're going to bring PerfView to non-Windows platforms, I want us to do the work directly in PerfView so that any improvements to PerfView automatically accrue to all platforms.  I think that at a minimum, a cross-platform PerfView should support Windows, Linux, and OSX.  In this issue, I'll describe the steps that I know of that will be required to do this.  Not all of the steps are clear yet, and so we'll need to dig into those as we get closer.  But in the meantime, if folks are interested in helping to bring PerfView to non-Windows platforms, let's do it.
### Extremely Rough High-Level Plan
- [ ] Port PerfView to run on .NET 7 (or 8) on Windows.
- [ ] Implement non-UI-based functionality for Linux and/or EventPipe-based traces (e.g. GC/JIT stats).
- [ ] Investigate cross-platform UI frameworks.
- [ ] Implement PerfView's UI in a new cross-platform framework.

I acknowledge that there are lots of tasks built into this plan that aren't listed here.  For example, just porting to .NET Core likely means re-designing how PerfView is packaged - right now it is a single-file that unpacks itself.  This won't be possible on .NET Core, so we likely will need to investigate options.  One option would be to look at what's possible with .NET Core single-file deployments.  Another would be to build a native wrapper and have it extract PerfView and the runtime and run it.
Let's use this issue as a jumping off point to discuss options and to track this work.

I think the first step here should be to start with PerfViewCollect and see if you can expand it to handle more and more PerfView code.  Right now, it's just a command line collector that runs on .NET Core, so perhaps the first two steps there are:

Move PerfViewCollect to .NET 7 (it's currently running on .NET Core 3.1)
Try to make the UI run on .NET Core.  Note that we don't necessarily want to get rid of PerfViewCollect, as we still use it in containers that don't have UI libraries installed on them (e.g. nanoserver), but this is a good way to expand outwards from a starting point.

Where I'd like us to end up is that we have two builds of PerfView side-by-side - one that runs on .NET Framework and one that runs on .NET Core.  This allows us to do this work in relative isolation.

cc: @birojnayak, @smhmhmd

To make it cross platform, migrate from WPF to Avalonia UI. Someone wrote an guide

To make it cross platform, migrate from WPF to Avalonia UI. Someone wrote an guide

Absolutely a reasonable option to consider.


Update stable version in repo from 0.0.7 to 0.1.0

Think about update stable version to 0.1.0
Version: stable=0.0.7 (114 days old) => latest=0.1.0 (20 days old)
Installs: stable=98 (56.98%), latest=14 (8.14%), total=172
Click to edit

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.1.0 but in the meantime an update to version 0.1.1 is suggested.
So this issue will be closed and replaced by an updated one.


Enhancing UI/UX of E-commerce landing webpage

Is your feature request related to a problem? Please describe.
Site does not have good user interface and required some styling and impressive designs in it.
Describe the solution you'd like
I will enhance the UI of this site, I will some gradient colors, many more styles and animations to make it quite responsive with HTML, CSS & JavaScript.
@TusharKesarwani
Please assign this issue to me for competing in SSOC'2023.

Create a fresh issue after 1st June


Distinguish testing decoration labels

Fixes #146965
This PR distinguishes test items with the same label on display. Implementation is based on this suggestion https://github.com/microsoft/vscode/issues/146965#issuecomment-1106894014
Here are some screenshots using the examples from the associated issue:

Thanks for the PR!


add DCO 1.1; remove reference to CLA

We're able to ditch the CLA (yay!) for a DCO, which (IMO) is a lot less painful for developers to deal with.
I've already configured probot/dco to handle the checks; once this is ready, it will be a requirement to merge any PR across the org.
The most straightforward way I've found to signoff automatically is just to create an alias, e.g., git config alias.ci 'commit -s', then use git ci to commit.
Often you can configure GUIs such as SourceTree to do this automatically, as well.

cc @mochajs/core since this is kind of Important

This should affect new PRs going forward.  If the CLA is already signed, I don't want to require the DCO as well.  Contributors of existing PRs are welcome to sign off on their commits, of course, but we should not require this.

Coverage remained the same at 90.6% when pulling 763a689a8aa7f64a639968592130af421ddcf9b1 on dco into f187d6d73b9fe99999e706c3c8998cb3b79116a7 on master.

Mind if i ask why you think its less painful?
From trust perspective it seems the better choice, but from ease-of-use isn't it more work that first time with a DCO?
Just trying to understand the reason behind this.

Should we remove CLA check when we merge this PR?

@outsideris 	that's the idea, yeah.
still would appreciate more input esp. from @plroebuck 	and @munter.

So if someone commits something that would have been illegal, under CLA they'd have been responsible. Under DCO, who is? Can both of them be used without conflict?
I prefer CLA scheme we already have myself, but don't care excessively either way.
Also seems easier to press a website button once than have to sign every git commit.

So if someone commits something that would have been illegal, under CLA they'd have been responsible. Under DCO, who is? Can both of them be used without conflict?

Who is ultimately responsible is an open question, as there's no legal precedent yet (to my knowledge).

I prefer CLA scheme we already have myself, but don't care excessively either way.
Also seems easier to press a website button once than have to sign every git commit.

Let's keep in mind that the people who would find CLAs to be an impediment to contributing are likely not seeing this PR.
I do see the benefits of a CLA if you've already signed it.
That said, I don't want to flip-flop back and forth.  Maybe it'd be workable to allow for both?  I'll follow up on that with JSF legal.

Closing to keep our review queue small. The current CLA system works and nobody from OpenJS has yelled at us to change it. 🙂


feat(curriculum): add permutation generator lab

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Original prototype https://github.com/freeCodeCamp/CurriculumExpansion/pull/616/
I have modified the original code to remove redundant values from the final array.

Reopening this PR as recursion is now part of the curriculum we'll ship.

@moT01
I have added this test to check for recursion.

You should use recursion in your `permuteString` function.

```js
assert.match(permuteString.toString(), /permuteString\s*\(/);
```

Let me know what you think.


v6.6.0

context management simplification + bindings 6.4.0
handle more boolean environment variable variations.
propagate FilePath KV value correctly in edge case
add log setting 'event:create', cassandra-driver now always uses 'patching'

this PR has been superseded by 6.6.0 (an interactive rebase on top of master). i will keep it around until 6.6.0 has been merged.


Remove tech doc annotation in catalog-info.yaml

https://issues.redhat.com/browse/FLPATH-1112
https://issues.redhat.com/browse/FLPATH-1144
Remove tech doc annotation in catalog-info.yaml

@dmartinol PTAL

@gabriel-farache
IMHO would be nice to actually have a skeleton documentation folder following the backstage methodology to encourage users to use it and have a nice documentation tab...
This can be a follow up issue with lower priority

@batzionb Agree, I plan to create an issue (story this time, not a bug :) ) to had the doc but right now, I want to get rid of the error :)


Ability to hide classes defined using curly braces

Sometimes we have to define classes using curly braces instead of just quotes when we have to merge some classes that are conditionally rendered. For example:

className={`some class here ${some condition based class here}`}
OR
className={cn(
               "some class here",
               some condition based class here
            )}

The first one works randomly. I think if there are lots of classes and the prettier has moved the ending bracket to next line, the extension fails to fold.
example:

+1
it would be nice if they could make it fold into something like this:
className={...}

i think this would fix it:
/(class|className)=(['"`]|{)(.*?)(\2|})/g


Fds 1273 node update

Remove node installation since this will be deprecated and is also redundant with shiny server.

Reviewed in FECR last week.


NoUselessSprintfFixer - Fix test on PHP5.6

I do this PR like the previous ones; fix as much as possible issues and implement PHP8 support as much as possible, than I look at the CI, if OK than I apply on it on the lowest branch, make a PR out of that, check CI, if green merge that PR and merge it upstream, than go back to this PR, rebase, check  CI, merge.
That way I spent as much time as possible fixing as much as possible on as many branches as possible without the overhead of creating a PR out of each issue just to see nobody actually caring about these PR before it is merged

Thanks for details. I was looking into master failing on 5.6 and I spot fix here, but together with all other changes. actually i had to pick up few lines only to make master green again.

@SpacePossum , I rebased to 2.17


acs: get-credentials accepts --output-file

Addresses #1446.
cc: @brendandburns

Hi @colemickens, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (colemick). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Renamed flag to --file/-f as suggested. Put the default value in _params.py.
This is rebased on top of #1451, hence the extra commit.

rebased to fix conflicts, thanks


Please don't panic on DecodeString

I was surprised to see all of the implementations of NewSharedKeyCredential panic when decoding the account key.
https://github.com/Azure/azure-storage-blob-go/blob/197d1c0aea1b9eedbbaee0a1a32bf81e879bde80/2018-03-28/azblob/zc_credential_shared_key.go#L23
I would expect the error to be returned, rather than a panic.
@JeffreyRichter, there are over 100 panic calls in this library. Is this intended? I haven't found an instance of a panic call which wouldn't be better handled by returning an error. Thoughts?

Please see the discussion here.

@JeffreyRichter is there a rough timeline to remove the panic's from this provider and instead return errors from methods? We can send a PR for this if needed - as this issue is unfortunately blocking our adoption of this SDK

I'd love to see a timeline too.
I'd most like to see errors returned because the compiler and standard static analysis tools will make sure I handle the errors.

👋 I've noticed #63 which fixes the specific issue the API call raised above (and have reviewed it / commented on the potential crashes as I saw them).
Cloning the repository locally I notice there's 477 panic's across 66 files in this repository (and that's just grepping for panic( / excluding the less obvious items like nil-pointers; presumably the scope of this issue is to remove all of those panic's (e.g. at a minimum the panic() calls) - rather than just the one in this PR - or should I open a separate issue to track that?
Thanks!

Hi @tombuildsstuff, thanks for the review! I'll make the changes soon.
There's actually 186 panics in the 2018-03-28 version. I do not think that we should blindly remove all of them, since there are many valid scenarios to use panic to help the user detect their programming errors.
Is there other panic that you think is not valid?

@zezha-msft

Hi @tombuildsstuff, thanks for the review! I'll make the changes soon.

No problem - thanks for working through them :)

Is there other panic that you think is not valid?

All of them, within all SDK/API versions (at least, for the user-facing parts of the code, within tests is up to you).

I do not think that we should blindly remove all of them, since there are many valid scenarios to use panic to help the user detect their programming errors.

Libraries in Go use the convention of returning errors rather than panicking so that the callers can decide how to respond to errors (which also makes it obvious which functions could return errors based on the return types - which becomes part of the libraries Public API). By contrast - Libraries which panic make it extremely challenging to handle errors correctly, since it means we need to know about the internal workings of each method and /when/ a panic could occur - rather than it being explicit and being caught at compile time.
FWIW I can find this relevant blog post from the Go site on the topic, which states: It's worth stressing that whatever the design, it's critical that the program check the errors however they are exposed. The discussion here is not about how to avoid checking errors, it's about using the language to handle errors with grace..
As such I believe all of the uses of panic need to be removed from (at least the user-facing) this library and replaced with errors - else unfortunately I don't see how we could migrate from the current Azure SDK for Go Storage SDK to this one.
Thanks!

@JeffreyRichter is there any update here? I'm wondering if we should be forking this SDK to remove the panic's (described above) - or if we should hold off if they're going to be fixed? Thanks!

Yes, I have an update. I have been really, really struggling with this. There is truly a lack of official guidance on the use of errors versus panics. For example, the Go Language Specification only explains how these mechanisms work and gives no guidance for when to favor one over the other. The official Go blog has a few articles published in 2010 and 2011 that discuss panics. Only the 2010 blog post offers any kind of guidance at all about panics; it says:

The convention in the Go libraries is that even when a package uses panic internally, its external API still presents explicit error return values.

All other articles, videos, and books that I could find related to panic/error guidance seem to have extrapolated guidance from this one sentence and have taken it to an extreme. The reality is that Go packages panic all the time. For example, if you pass nil for an interface, slice, or func parameter to a method defined in a Go package, the Go runtime panics on that package's behalf when it tries to use the nil value. If you look at the package's source code, you just don't see an explicit call to panic. Also, many, many Go packages explicitly call panic: look at the reflect package documentation and search for the word panic; it appears more than 80 times! Look at the documentation for Go's bytes package and search for panic; again you'll see several methods that panic. This is just the tip of the iceberg, there are many Go packages that panic. Amazon's S3 Go SDK (which is very similar to this repo's blob SDK) also panics.
Due to the lack of official panic guidance, I took it upon myself to write an article that talks about Embracing Panics in Go Packages. I've not published the article because I know it will be very controversial in the Go community. But, I am making it available here so that you and others can read it just to hear an alternate perspective.
About 2 weeks ago, I went to Google in Seattle and met with Brad Fitzpatrick (a member of the Go team). I shared my article with him and he said he'd share it with other Go team members; I haven't gotten any feedback yet. However, as Brad & I spoke and researched many existing packages, we very quickly realized that the current messaging in the community of when to use panics and what packages were really doing were not lining up. This proved that the official guidance is lacking and that the Go team should improve it.
At the same meeting, Brad and I also took a stab at coming up with some official error/panic guidance that could be shared with the Go community at large. Here is what we came up with (so far):

A function should always document what it panics unless the panic is due to an implicit Go runtime panic such as nil interface/function/*T.
It is OK to panic (and not return an error) if a sanity check fails. (A sanity check is something you really, really don’t expect to fail in a specific scenario).
If you want to avoid returning an error to allow greater composability of code, then it is OK to panic. This needs more guidance in general as to when to determine the severity making error better/worse than panic and also some guidance about versioning: what if you don’t return an error today but decide to return an error tomorrow?
Validate all inputs being passed to a standard library function such that it won’t panic – I feel that this is untenable in real life. That is, no one will actually do this.
If the code would panic implicitly anyway, it is OK to validate an argument and explicitly panic. For example, instead of letting the runtime panic due to nil or array access out of bounds, the function can check for nil/bounds and explicitly panic giving a better error message.

The list above is from my notes and should NOT be taken as official guidance as of today. If this guidance were to become official, then this repo's blob SDK is currently following best panic/error guidance. Except that we are missing some documentation for methods that do panic; we will correct this.
I'm hoping to continue my involvement with Google's Go team to drive the creation of better official error/panic guidance. With their new error proposals for Go, now is a great time to get all of this sorted out and improved for the whole Go community.

This is fixed in 0.3.0.


我在Linux上安装dotnet，一直报错

我在Linux上安装dotnet，一直报错

The translation of this is I install dotnet on Linux and keep getting an error but there is not enough information to help investigating this.


Compatibility with bevy main branch as of 5/10/21

Changed cargo.toml to use the bevy main branch.
Fixed name changes and added derives for Components.
Fixes #5

I will not accept the change to Cargo.toml. It would make it more difficult to use the plugin for many people.
See this page for more info: https://bevy-cheatbook.github.io/setup/bevy-git.html#how-to-use-bleeding-edge-bevy
You may add a cargo patch instead, as advised by that page.


HBASE-24223 The -Phadoop-3.0 option does not work on branch-2 and bra…

…nch-2.3 with JDK11

A bit tricky, when hadoop-3.0 profile is activated, declare the hadoop.profile as 3.0...
Tried locally this could pass the enforcer rule check...

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  0s
Docker mode activated.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

27m 48s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1558

Optional Tests
dupname asflicense hadoopcheck xml

uname
Linux 77059cf8f992 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a7aa89506

Max. process+thread count
62 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 51s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 38s
branch-2 passed

+1 :green_heart:
compile
2m 56s
branch-2 passed

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
root in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 11s
the patch passed

+1 :green_heart:
compile
2m 51s
the patch passed

+1 :green_heart:
javac
2m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
231m 39s
root in the patch passed.

268m  6s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1558

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fd320a6ad3f8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a7aa89506

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/testReport/

Max. process+thread count
4323 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 52s
branch-2 passed

+1 :green_heart:
compile
2m 44s
branch-2 passed

+1 :green_heart:
shadedjars
5m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 43s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
2m 47s
the patch passed

+1 :green_heart:
javac
2m 47s
the patch passed

+1 :green_heart:
shadedjars
5m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
279m 35s
root in the patch passed.

314m 22s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1558

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 73881b975eb6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a7aa89506

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/testReport/

Max. process+thread count
5401 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1558/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Benchmarks over 9x slower against Rapier3D

Hey Daniel,
Thanks for your work on this library. I tried comparing the performance of ReactPhysics3D against Rapier3D, a physics engine written in Rust. My results show that Rapier3D is over 9x faster:
Benchmark: 1000 ticks, 1/60 time step, 512 spheres
ReactPhysics3D: mean 1528.6 ms, stddev 77.3 ms
Rapier3D w/ SIMD: mean 163.6 ms, stddev 2.5 ms
Rapier3D w/o SIMD: mean 207.4 ms, stddev 12.4 ms

I'd like to figure out the reason behind this large discrepancy. Both tests initialize the world with the same objects in the same positions, run the same number of physics steps, and use the same solver iteration counts. I even tried using a custom allocator to discount the possibility of pathological allocation patterns, but that didn't change the results much. Perhaps you could take a look and tell me whether I am configuring something erroneously in the C++ code?
Here is the C++ code I am using to benchmark ReactPhysics3D:
#include <stdint.h>

#include <array>
#include <iostream>
#include <chrono>

#include <reactphysics3d/reactphysics3d.h>

static rp3d::DefaultAllocator allocator;
static rp3d::PoolAllocator pool_allocator{allocator};
static rp3d::PhysicsCommon common{&pool_allocator};

uint64_t benchmark(uint64_t cbrt_num_objs) {
    auto world = common.createPhysicsWorld();
    world->setNbIterationsVelocitySolver(15);
    world->setNbIterationsPositionSolver(8);
    world->setGravity(rp3d::Vector3{0, -9.81f, 0});

    auto ground = world->createCollisionBody(rp3d::Transform::identity());
    ground->addCollider(common.createBoxShape(rp3d::Vector3{200, 0.2f, 200}), rp3d::Transform::identity());
    auto sphere_shape = common.createSphereShape(0.5f);

    rp3d::RigidBody* body;
    for(uint64_t x = 0; x < cbrt_num_objs; ++x) {
        for(uint64_t y = 0; y < cbrt_num_objs; ++y) {
            for(uint64_t z = 0; z < cbrt_num_objs; ++z) {
                auto center = cbrt_num_objs / 2.0f;
                auto pos = rp3d::Vector3{
                    (x - center) * 1.05f,
                    1.0f + y * 1.05f,
                    (z - center) * 1.05f
                };
                auto rigid_body = world->createRigidBody(rp3d::Transform{pos, rp3d::Quaternion::identity()});
                auto collider = rigid_body->addCollider(sphere_shape, rp3d::Transform::identity());
                collider->getMaterial().setBounciness(0.7f);
                body = rigid_body;
            }
        }
    }

    auto start_time = std::chrono::steady_clock::now();
    for(uint64_t i = 0; i < 1000; ++i) {
        world->update(1.0f / 60);
    }
    auto end_time = std::chrono::steady_clock::now();

    // Do not let compiler optimize away whole simulation!
    if(body->getTransform().getPosition().x == -100.0f) {
        std::cout << "IUEGFOEIYUFGE " << body->getTransform().getPosition().x << std::endl;
    }

    auto elapsed = std::chrono::duration_cast<std::chrono::microseconds>(end_time - start_time).count();

    return static_cast<uint64_t>(elapsed);
}

int main(int argc, char** argv) {
    for(size_t i = 0; i < 8; ++i) {
        auto result = benchmark(8);
        std::cout << result << std::endl;
    }
    return 0;
}

And here is the flame graph from a perf run of the above code:

For comparison, here is the Rust code for the Rapier3D benchmark:
use rapier3d::prelude::*;

fn benchmark(cbrt_num_objs: u64) -> u64 {
    let mut rigid_body_set = RigidBodySet::new();
    let mut collider_set = ColliderSet::new();

    /* Create the ground. */
    let collider = ColliderBuilder::cuboid(100.0, 0.1, 100.0).build();
    collider_set.insert(collider);

    let mut handle = None;
    for x in 0..cbrt_num_objs {
        for y in 0..cbrt_num_objs {
            for z in 0..cbrt_num_objs {
                let center = (cbrt_num_objs as f32) / 2.0;
                let rigid_body = RigidBodyBuilder::new_dynamic()
                    .translation(vector![
                        ((x as f32) - center) * 1.05,
                        1.0 + (y as f32) * 1.05,
                        ((z as f32) - center) * 1.05
                    ]).build();
                let collider = ColliderBuilder::ball(0.5).restitution(0.7).build();
                let rigid_body_handle = rigid_body_set.insert(rigid_body);
                collider_set.insert_with_parent(collider, rigid_body_handle, &mut rigid_body_set);
                handle = Some(rigid_body_handle);
            }
        }
    }

    /* Create other structures necessary for the simulation. */
    let gravity = vector![0.0, -9.81, 0.0];
    let integration_parameters = IntegrationParameters {
        dt: 1.0 / 60.0,
        max_velocity_iterations: 15,
        max_position_iterations: 8,
        ..Default::default()
    };
    let mut physics_pipeline = PhysicsPipeline::new();
    let mut island_manager = IslandManager::new();
    let mut broad_phase = BroadPhase::new();
    let mut narrow_phase = NarrowPhase::new();
    let mut joint_set = JointSet::new();
    let mut ccd_solver = CCDSolver::new();
    let physics_hooks = ();
    let event_handler = ();

    let start_time = std::time::Instant::now();

    /* Run the game loop, stepping the simulation once per frame. */
    for _ in 0..1000 {
        physics_pipeline.step(
            &gravity,
            &integration_parameters,
            &mut island_manager,
            &mut broad_phase,
            &mut narrow_phase,
            &mut rigid_body_set,
            &mut collider_set,
            &mut joint_set,
            &mut ccd_solver,
            &physics_hooks,
            &event_handler,
        );
    }

    let end_time = std::time::Instant::now();

    {
        // Do not let compiler optimize away the whole simulation!
        let body = &rigid_body_set[handle.unwrap()];
        if body.translation().x == -100.0f32 {
            println!("IUEGFOEIYUFGE {}", body.translation().x);
        }
    }
    (end_time - start_time).as_micros() as u64
}

fn main() {
    for _ in 0..8 {
        let result = benchmark(8);
        println!("{}", result);
    }
}

And here is the Cargo.toml for the Rapier3D test (Non-SIMD omits the features = [ "simd-stable"] entry):
[dependencies]
rapier3d = { version = "0.11.1", features = [ "simd-stable" ] }

[profile.release]
lto = false

The ReactPhysics3D benchmark was compiled with g++ v9.4.0 and -O3. The Rapier3D benchmark was built with rustc v1.59.0 and cargo build --release.

Hello. Thanks for your feedback.
I don't see anything wrong with your code using ReactPhysics3D. I don't really know Rapier3D but I see that in IntegrationParameters, the two iterations parameters are named max_velocity_iterations and max_position_iterations. In the documentation here, it's written that those values are maximum number of iterations. Does it mean that during some update steps the number of iterations used by Rapier3D is smaller than those maximum values ? If so, it would be difficult to compare because in ReactPhysics3D those are not maximum values but those are the exact number of iterations that are taken at each step. Moreover, the values you have chosen for ReactPhysics3D (nb velocity iterations=15 and nb position iterations=8) are quite high. For instance by default in ReactPhysics3D, those values are nb velocity iterations=6 and nb position iterations=3.
I guess that the 9x speedup comes from the difference between those iterations steps (maybe they are not used the exact same way in both libraries) but I am not sure. Maybe, instead, you should try to tweak those values in the two libraries in order to have a 'similar' visual result of the simulation or the result that you consider good enough for your use with the smallest number of iterations in both libraries and then choose the library with the better performance.

Just wanted to update, it turns out that I didn't set up the collisions properly in my simulations. Explicitly adding a static rigidbody to the ground in each simulation fixed the large discrepancy in run time. Both physics engines run fast now, but I haven't benchmarked them to get precise numbers.

Thanks a lot for your feedback.


add new dir deploy/k8/ for kubernetes yml files for building a go project

@GNRain  get that second k8 file for the win and can close issue

still need

Required both
deployment.yml
service.yml
Within deploy/k8


Add yuidoc

... using ember-cli-yuidoc with https://github.com/adfinis-sygroup/yuidoc-adsy-theme

Closing since hand-written Docs seem fine for now.


Make --host-addr optional

By making host-addr optional we make it possible to run a node with both IPv4 and IPv6 addresses.

bors r+


Your website is down

https://kubernetes-sigs.github.io/service-apis/
Just getting 404

Per slack, renamed to https://kubernetes-sigs.github.io/gateway-api/ looks like the docs are being worked on.

Thanks for letting us know! This was actually how I found out that the repo rename had happened :). Closing now since links have been updated.
/close


Investigate time tracker apps 0* - 9*, A* - C*

0* - 9*, A* - C* (roughly 42 apps)

Please edit the various columns in https://github.com/federatedbookkeeping/timesheets/blob/main/apps-list.md and add the import/export formats you find in https://github.com/federatedbookkeeping/timesheets/tree/main/data-formats. Let me know in https://gitter.im/federatedbookkeeping/timesheets if you run into any questions!

We have enough apps now, so closing this as stale. See #43 for the wrap up of milestone 4.


Moving Frontend definition to optional part of the Load Balancer definition flow

Porting Java SDK PR: https://github.com/Azure/azure-sdk-for-java/pull/1870

@martinsawicki,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Can one of the admins verify this patch?

@azuresdkci retest this please


stream info: support listener info

With ECDS, a single filter can handle requests from multiple listeners. Therefore, we need to support lookup of listener info, just like cluster info, from stream-specific info.

/reopen
recall the discussion about listenser info


[HOLD for payment 2023-01-09] iOS - No green border for date picker field when the field is selected

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Go to any page that has DatePicker (ie Connect Bank Account Manually)
Focus on any field then focus to the DatePicker
Notice that DatePicker doesn't have the border when it's being selected

Expected Result:
Date Picker should have the green border
Actual Result :
DatePicker doesn't have the border when it's being selected
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] iOS / native

Version Number: 1.2.43-1
Reproducible in staging?: Y
Reproducible in production?: Could not check
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/209567981-54c0f677-0b92-4b0e-a853-c5c1e4df16ba.MP4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671803870095339
View all open jobs on GitHub
https://user-images.githubusercontent.com/43996225/209568003-66b221cc-b2ef-49c8-8b61-32ba094adc04.MP4
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01040bf570bfa437b1
Upwork Job ID:<PHONE_NUMBER>628589056
Last Price Increase: 2022-12-27

Taking a look!

Also happening on Android. Not iOS-exclusive

Reporting bonus paid out. I believe we're all done here so I'll close this out


can not connect peer

WARN [10-21|23:36:34.774] Snapshot extension registration failed   peer=05180ebe err="peer connected on snap without compatible eth support"
INFO [10-21|23:36:43.015] Looking for peers                        peercount=1 tried=149 static=0
INFO [10-21|23:37:03.053] Looking for peers                        peercount=1 tried=99  static=0
WARN [10-21|23:37:13.620] Snapshot extension registration failed   peer=182c008a err="peer connected on snap without compatible eth support"
INFO [10-21|23:37:43.344] Looking for peers                        peercount=0 tried=89  static=0
INFO [10-21|23:37:53.347] Looking for peers                        peercount=2 tried=74  static=0
INFO [10-21|23:38:13.358] Looking for peers                        peercount=2 tried=110 static=0
INFO [10-21|23:38:23.727] Looking for peers                        peercount=2 tried=63  static=0
WARN [10-21|23:38:30.809] Snapshot extension registration failed   peer=05180ebe err="peer connected on snap without compatible eth support"
INFO [10-21|23:38:33.840] Looking for peers                        peercount=2 tried=90  static=0
WARN [10-21|23:38:42.886] Post-merge network, but no beacon client seen. Please launch one to follow the chain!
INFO [10-21|23:38:43.900] Looking for peers                        peercount=1 tried=123 static=0
INFO [10-21|23:39:03.914] Looking for peers                        peercount=2 tried=158 static=0
INFO [10-21|23:39:23.985] Looking for peers                        peercount=1 tried=37  static=0
INFO [10-21|23:39:34.024] Looking for peers                        peercount=2 tried=44  static=0
INFO [10-21|23:39:44.030] Looking for peers                        peercount=1 tried=70  static=0
INFO [10-21|23:39:54.036] Looking for peers                        peercount=2 tried=111 static=0
/usr/local/bin/geth --mxc --networkid=18686 --syncmode=full --gcmode=archive --datadir=/data/mxc-geth --metrics --metrics.expensive --metrics.addr=<IP_ADDRESS> --authrpc.addr=<IP_ADDRESS> --authrpc.vhosts=* --http --http.api=debug,eth,net,web3,txpool,mxc --http.addr=<IP_ADDRESS> --http.vhosts=* --http.corsdomain=* --ws --ws.api=debug,eth,net,web3,txpool,mxc --ws.addr=<IP_ADDRESS> --ws.origins=* --rpc.txfeecap=0 --bootnodes=enode://d226b47b9c1199a21d9d11d664269261717b1c67fa67062d3eecc84285537fe161cbac3804ea036ed516d257f95215f49400952f03c43174d3a3af415ff47d75@<IP_ADDRESS>:30303,enode://1f5e524a11f5dc02f03113faa4090cafa0d692e9decff1199a1dc304d2d1f6fba07a7e7016026e0356b3e6c35e873a95a295c0326e888554224a1ec3fded330a@<IP_ADDRESS>:30303

you will need to provide error logs from geth, thanks!

you will need to provide error logs from geth, thanks!

There is no more detailed information, geth process does not synchronize data, does not need genesis.json initialization data, but I do not find it in the documentation

docker compose restart
This will start to sync the data, if you have more questions let me know!


how to get progress while stream rtmp from file

thank for such good library
how to get progress while stream rtmp from mp4 file
and also how can i add the  water marks over the video file while streaming.

For now both features was no added. Anyway I have plan to add both.
I'm developing watermark and filter in file and display mode. Also I want add move to a file second
Add progress should be easy, you can get it with mediaextractor class in decoders using getsampletime like:
extractor.getSampleTime();

Loop mode, progress, duration and moveto implemented. moveTo is too slow for now (I don't know the reason but mediaextractor need few seconds to work).
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/commit/2c4820a78593c9a2c1e3be438921106c31d0d0d8

Watermarks and effects is now available in stream file mode: https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/commit/e48a40e11694f2413bb79c3b873254b628b34803
You only need set context to the constructor if you want use it. Also remember that if you use loop mode when file restart all watermarks or effects will be cleaned.
The method to use is like with OpenGlView mode.


BAU - alter some of the Strings used in the tests to take advantage o…

…f some existing test constants.

You can blame @Wynndow and his ruthless efficiency for the pie-purge.


Implement calculated-expression extension

Fixes #971 #1173
Description
Implemented the calculated expression extension. The feature also calculated cyclic dependency, and prevents the infinite calls of callback
Type
Choose one: Feature
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@RaaziaTarique kindly take a 1st pass review

Assigning to @aditya-07 for review.

@jingtang10 @aditya-07 Please review the changes

@aditya-07 @jingtang10 could you please review the changes?

@joiskash can you please leave a review? thanks!

Can you attach a screenshot please?
@shelaghm not sure if we want to show case this in the layout screen of the catalog app... i kind feel like this is better off in the components page... that is if we want to showcase this at all.

I agree that it's likely more useful to show in components page, not layout page. Having a screenshot that I can look at of this components will he helpful for me to provide more specific guidance.

@maimoonak could you please advise an ETA by when these changes can be ready for review?

@Tarun-Bhardwaj I have resolved all conflicts with main, synced the code with new changes as well just now.
The issue https://github.com/google/android-fhir/issues/1498 needs to be resolved to run the catalog (without extra needless edit-text). But this PR and functionality does not depend on this issue and is working as expected. (Below is a working example)

@maimoonak , could you please advise the status of these changes? Is there an ETA by when we can merge this PR?

@Tarun-Bhardwaj @jingtang10 kindly review the PR.

can you please make sure to reply to the review comments and mark the conversations as resolved if the comment is addressed in the code. once that's done please reassign back to me. thanks

@maimoonak please reassign to me once all comments are addressed

@jingtang10 I have found few libraries for graph generation. I am still exploring these and if its possible to use any for our expression dependency graph
https://github.com/systek/dataflow
https://github.com/jgrapht/jgrapht/
https://github.com/google/guava/wiki/GraphsExplained
https://github.com/nidi3/graphviz-java#user-content-api


Bug report - Auto refresh !

What happened?
When I open daily note!
Then the plugin will auto refresh.

DQL
No response
JS
const {DvTasks} = customJS
const {MarkTask} = customJS

DvTasks.dailyLog({app, dv, moment, luxon, that:this, markComplete:MarkTask.complete})

Dataview Version
0.4.26
Obsidian Version
0.13.33
OS
Windows

Can you give us instructions to reproduce this?

I don't understand "the instructions"

dvTasks.txt
The file is dvTasks.js file.
I describe what I come up against the problem.

open obsidian
Wait time about 3mins
open my daily notes
the problem come

Note:
I can't open daily note first, when I open the daily note first, the problem won't occur.
It look so odd.

Can you show us the js file? Can you also disable all other plugins and confirm that this is a problem with dataview?

On second thought, this seems like an issue with CustomJS and not dataview. Essentially, we need more information and an example from you to recreate the error on our end.

I just try to close plugin in obsidian one by one.
When I close dataview, and the error stop to happen.

I'm not sure I follow. Where is the file dvTasks?

Whatever I am very grateful you reply.
dvTasks.txt
If the problem can't solve, I just try to reload my obsidian. It looks the better way what I try to these work.

Unfortunately, this is somewhat difficult for me to debug. I'll return to this over the weekend.

All Dataviews refresh whenever you edit the underlying file (or underlying code block in live preview), as well as when you change other files in your vault. As long as your views are idempotent, this is no issue - what is DvTasks doing?

Unfortunately, this is somewhat difficult for me to debug. I'll return to this over the weekend.

Thank you again for you helpful and patient.

@blacksmithgu Hi, I am not coding master. If you are interested in konw how it happened. And I alreadly have provided the  DvTasks file.

Ah, I see - looks like this uses a fair amount of direct HTML generation code.
What is your desired behavior? Would you like the ability to turn off all Dataview refreshing (something like dv.disableRefreshing() or similar)?

@blacksmithgu  It cause the obsidian boom! It stop I use obsidian normally when they refreshing. So I have to reopen obsidian to adviod the matter.


How to open Attribute table from Sublayer menu of dynamic layers

I added this in LayerControl widgets options
subLayerMenu: {
                        dynamic: [{
                            label: 'Open Attribute Table',
                            topic: 'openTable',
                            iconClass: 'fa fa-table fa-fw'
                        }]
                    }

I am getting Open Attribute Table menu option but, by clicking on that menu Attribute Table doesn't display. What are the additional steps are required to open the Attribute Table from sub layer menu.
I seen the related issue here tmcgee/cmv-widgets#21.
I added code in viewer.js file
Now here is the OpenAttributeTable Code after topic.subscribe('layerControl/goodbye', function (event) {...
topic.subscribe('LayerControl/openAttributeTable', function (r) {
        var data_list = [
            {
                title: 'AttributesTable',
                topicID: 'AttributesTable',
                queryOptions: {
                    queryParameters: {
                        url: r.layer.url + '/' + r.subLayer.id,
                        maxAllowableOffset: 100,
                        where: '1=1'
                    },
                    idProperty: 'ObjectID'
                }
            }
        ];
        console.log(data_list);
        //this.addTables(data_list);
        //this.tables = data_list;
        topic.publish('attributesContainer/addTables', data_list);
    });

Attributetable is not opening with above code

@mayur9785 In your first code snippet, you are using openTable. In the second code snipper, you are using openAttributeTable. Those 2 need to be the same. You can set break-points in your code within Chrome DevTools to ensure that each snippet is executing.

@tmcgee many thanks. I changed and it is executing 👍


Upgrade deps for node v18

I forgot to enable commit signing. Here's the new PR: https://github.com/stellar/typescript-wallet-sdk/pull/9


Recursive function calls no longer work

It seems commit 6419f4524a1a5217e5d29fdc9ff0b6d4ca13b1a7 broke the ability to make recursive function calls.
Simple test to reproduce:
fn fact [n]{ if (== $n 0) { put 1 } else { put (* $n (fact (- $n 1))) } }

As of the commit above:
> fact 3
> fact 3
Exception: exec: "fact": executable file not found in $PATH

Before:
> fact 3
▶ (float64 6)

Thanks!

Thanks!


TaskRuns may be orphaned by a PipelineRun

Expected Behavior
The PipelineRun controller should always be aware of TaskRuns owned by a PipelineRun even when the PipelineRun status is stale (because of API issues).
Before using the PipelineRun status as a source of truth, we should check it against the list ot TaskRuns owned by the PipelineRun.
Actual Behavior
When TaskRuns are created during the reconcile cycle of a PipelineRun, they are added to the PipelineRun status which is then sync'ed back to etcd. The sync may fail whatever error condition - if that happens, the TaskRuns are partially "orphaned": the PipelineRun will be queued for reconcile when they change and they will be deleted when the PipelineRun is deleted, however the PipelineRun controller will not be aware that they exist at all, and it will create new duplicate TaskRuns.
This happens because ResolvePipelineRun relies on the PipelineRun status alone, via the getTaskRunName function.
Steps to Reproduce the Problem

I would like to be able to reproduce this. It might be worth building a test case to reproduce this situation but it might be difficult. If we can disable specific API calls from functioning we could allow creating a taskrun while prevent updating a pipelinerun.

Additional Info

Tekton Pipeline version:

v0.12.0

/kind bug

my advice would be to not use the trackers for this but use a informer for TaskRuns inside of PipelineRuns. We do this all over Knative, here is an example: https://github.com/knative/eventing/blob/master/pkg/reconciler/parallel/controller.go#L62-L65
The Parallel resource makes Subscriptions and manages their lifecycles.
The issue you are going to run into is that the generate name on the TaskRun is random.
I think you should setup the watch on TaskRuns and propagate the real name of the TaskRun as they are generated and use that list to be able to reconcile their existence. You might want to link this up some how with the generation of the Pipeline or PipelineRun

my advice would be to not use the trackers for this but use a informer for TaskRuns inside of PipelineRuns. We do this all over Knative, here is an example: https://github.com/knative/eventing/blob/master/pkg/reconciler/parallel/controller.go#L62-L65

Today we do both, not sure why:

use the informer: https://github.com/tektoncd/pipeline/blob/fe5981e4e75ffec7f50a4aaab5eb6899742dd0f2/pkg/reconciler/pipelinerun/controller.go#L99-L101
setup a tracker: https://github.com/tektoncd/pipeline/blob/d5a91fdddc520d407e53324569b5af2d95e612b3/pkg/reconciler/pipelinerun/pipelinerun.go#L185-L186

So we do run the reconciler whenever a TaskRun is updated.

The Parallel resource makes Subscriptions and manages their lifecycles.
The issue you are going to run into is that the generate name on the TaskRun is random.
I think you should setup the watch on TaskRuns and propagate the real name of the TaskRun as they are generated and use that list to be able to reconcile their existence. You might want to link this up some how with the generation of the Pipeline or PipelineRun

When we generate the name for a TaskRun we store it in the PipelineRun status.
However if sync back to etcd fails during the reconcile cycle where the name was generated, we lose any track of that name. I've not seen happening in the wild tbh, but it seems to be a possibility - which is what this issue is about.


godot_4: 4.2.2-stable -> 4.3-stable

godot_4: 4.2.2-stable -> 4.3-stable

migrate to pkgs/by-name
refactor
nixfmt
order by phases order, alphabetical order
fix cross compilation

Courtesy of @AndersonTorres

Fixes #334942

v4.3 was released today. Can you include that as well?

Goal was to do the refactor before the upgrade.

@Haskellered Please review.

LGTM


[SPARK-42441][CONNECT] Scala Client add Column APIs

What changes were proposed in this pull request?
This PR adds most Column APIs for the Spark Connect Scala Client.
Why are the changes needed?
We want the Scala Client to have API parity with the existing SparkSession/Dataset APIs.
How was this patch tested?
Golden files, and I added a test for local behavior.

merging.

FYI, bunch of Scala 2.13 tests fail (https://github.com/apache/spark/actions/runs/4187249065/jobs/7256849374#step:9:19944) should be fixed before cutting RC cc @xinrong-meng

Hi, @hvanhovell .
Since we are close to RC1 cut, could you test Scala 2.13 before merging, please?


Set request status to dismissed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


 I am new.
I am trying to follow entgo versioned migration : https://entgo.io/docs/versioned-migrations/#use-a-custom-formatter
However, it is looking for ariga.io/atlas/sql/sqltool for sqltool.GolangMigrateFormatter
My code is unable to find this sqltool as it is not available in the recent.
Am I doing something wrong?

I am able to use it somehow with go get ariga.io/atlas@master that fetched 0.3.8 version but funny I do not see it on github :(

Hey @aleyrizvi, thanks for your question, they are not stupid!
Atlas (and Ent) can always be used from master branch. If you do go get <pkg>@master in Go, it will generate a version number for master from the commit hash, that is why you see v0.3.8 even though we haven't released it yet.
Also, 0.3.7 was released before there was sqltool package. You did everything right by fetching master.


69 gisruk submission

Add starter on gisruk
Add small abstract

Bios please @anisotropi4 and @JosiahParry (see the end of gisruk.qmd)!


[WIP][Test] Test reorganisation

Start reorganising the tests into more directories. The major divisions introduced are:

unit for tests which at most require a Mock model
model_integration for tests which require a 'real' model, but should work with any model
model_specific for isolating issues we've found with particular LLMs
need_credentials .... exactly what it says. Mainly remote-endpoint tests
notebooks again, exactly what it says

This is just a beginning; I've not started redoing the workflow files yet.

Also note that some files (e.g. test_model.py and test_grammar.py have been split into two between unit and model_integration according to whether each test needs a real model or not.

@riedgar-ms thanks for the work on this. I think the logical separation between types of tests makes sense, and upon thinking about it a bit more, I totally agree with the decision to use folders rather than pytest.mark. And I'm digging the fast unit tests :)


Fix RNG interrupt priority

Fix RNG interrupt priority
Description
Prior to this PR, the RNG module's interrupt priority was 1, which is a higher priority than configMAX_SYSCALL_INTERRUPT_PRIORITY.  After this PR, the RNG module's interrupt priority is 15, which is the lowest priority.
Since the RNG interrupt handler makes FreeRTOS API calls, it must use a priority lower than configMAX_SYSCALL_INTERRUPT_PRIORITY.
Found this issue while using the latest CM33 port code (10.6.0) with this project.  The latest port code includes validation of interrupt priorities.
Also:

Updated FreeRTOSConfig.h to reflect that there are 4 priority bits implemented for interrupt priority.
Changed the definition of configLIBRARY_LOWEST_INTERRUPT_PRIORITY from 7 to 15 (Note that configLIBRARY_LOWEST_INTERRUPT_PRIORITY is not actually used in this repo, so no impact from this change.)

Test Steps
Adopt kernel 10.6.0 into this repo.  Prior to this PR, the application asserts due to the interrupt priority.  After this PR, no assertion.
Checklist:

[X] I have tested my changes. No regression in existing tests.
~[X] I have modified and/or added unit-tests to cover the code changes in this Pull Request.~ N/A
Related Issue

(none)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

As a side note, I was using this repo to test port-optimised task selection on CM33 (https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/703).  It does work with only the minor change of setting configMAX_PRIORITIES to 31 (or 32) instead of 56.  Just an FYI.


First version of the pure wallet

This introduces module Wallet.Spec, which is a fairly direct translation of
Duncan's pure wallet specification. The idea is that we should be able to use
this to unit test the "real" wallet later.
This also makes a few minor additional changes:

The 'isBootstrapTransaction' now just checks if the set of inputs is empty
(that's what it should have done in the first place..)
Few additional operations on the UTxO in the DSL, including a definition
of equality.
A 'PreChain' now gets the actual boot transaction rather than its hash,
so that we inspect it to generate arbitrary valid ledgers. (We may have
to add a monad parameter to 'PreChain' though.)

Spec is not yet available online as far as I know, still very much in flux.

Sorry guys, this is broken. Don't merge yet.

Ok, I believe it's correct now. Detailed comments in the code.

Just for the record, I'd just to whine once more about the fee calculation model :) It's causing all sorts of trouble.


reset current outcome trades whenever a field is cleared

Coverage decreased (-0.08%) to 70.509% when pulling 31f034c05f1ef4b717b1d9593e848d0973eb310d on 302-clear-trade into c03069cc227c776dfd974cdb12e5f944dd7bff65 on master.

Coverage decreased (-0.08%) to 70.509% when pulling 31f034c05f1ef4b717b1d9593e848d0973eb310d on 302-clear-trade into c03069cc227c776dfd974cdb12e5f944dd7bff65 on master.

Looks good!  Merging.


Recipe uses wrong ca-files according to conda documentation

According to conda documentation if REQUESTS_CA_BUNDLE is set should be used as default store.
In the configuration the default conda ca-files are used and REQUESTS_CA_BUNDLE  is not considered.
https://github.com/conda-forge/git-feedstock/blob/14c0381b07d008a73e88ee8ca64631d499340b48/recipe/build.sh#L36

PRs welcome

Hello, I hope this PR is fine like that. If I did something wrong or there is still something missing, please say so :-)

The fix is not working, because the correct certificate path is set during build time and not during installation. I created a new PR #84 .


add "main" key to package.json

In package.json the field main is missing. This means that you cannot use require('fast-simplex-noise') in your scripts.
By adding "main": "fast-simplex-noise.js" to package.json this can be fixed.
more info here.

Could you please also tag this as a new (patch) version so the changes show up in the npm registery?

Just bumped to 0.5.1

thank you.


[OPTEE-OS 2/5] pkg: cross-compilers: Add armhf toolchain

Add armhf toolchain to cross-compilers package in order to be used by OPTEE-OS, that requires aarch32 and aarch64 compilers.

This looks good to me.


In global routed mode agent_manager fails to start.

@pjbreaux @jlongstaf
What issues does this address?
Fixes #356
What's this change do?
Guards vcmp initialization with a check on the existence of network_builder.
Where should the reviewer start?
icontrol_driver code.
Any background context?
Issues:
Fixes #356
Problem:
vCMP initialization is performed when the network_builder is non-
existent.  The vCMP initialization should only be performed for
under-cloud deployments.
Analysis:
Check that the network builder exists before using it to initialize
vCMP.
Tests:
Undercloud startup.

Is that all that is necessary to check for undercloud?

@pjbreaux: network_builder is only initialized for undercloud and set to None for overcloud.