[WIP][HELP NEEDED] If .go-version is missing, fallback on go.mod

Context #121
Hello, this addresses a long standing request that I think it would make many people happy about goenv. The ability to fallback from .go-version to go.mod.
I think this PR isn't ready, as I was only able to figure out how to interject through the "discovery" of the .go-version file, and read the version instead from go.mod if the former is missing.
Now, I think I might need some help to figure out the rest, and also to decide on the approach.
How do we handle the version from go.mod?
One option could be that we rely on the fact that, whatever is the current installed version of goenv, it knows locally what is the latest minor version of Go. So, for example, if in my go.mod I have:
go 1.17

goenv could look into it's list of known versions and:

use if already present
suggest to install it if not

This is just a suggestion: I'm completely open to better, more "implementable" ideas.
Issues running tests
I have read through the CONTRIBUTING.md doc, and I was unable to run tests. I keep getting this error:
↳ make test
set -e
/bin/sh: -c: line 1: syntax error: unexpected end of file
if [ -d "/Users/idemarino/Workspaces/opensource/goenv/bats-core" ]; then
make: *** [bats] Error 2

I tried a few things but none seemed to help.
For context, I'm on:

macOS 12.4 "Monterey"
Apple M1 Pro (ARM64)
$BASH_VERSION=5.1.16(1)-release

Hey @syndbg - Is this project still active and you are just busy, or should I consider a fork?
I'd really like to stick to contribution for now: I totally understand that maintaining stuff is sometimes super busy and hard to keep up.
Let me know.
I have an idea on how to implement the whole thing, by using the version in go.mod and picking the latest known patch version that matches the minor version.
But testing is still broken for me, and I can't figure out what am I missing.

Hey @syndbg - Is this project still active and you are just busy, or should I consider a fork?
I'd really like to stick to contribution for now: I totally understand that maintaining stuff is sometimes super busy and hard to keep up.

Let me know.
I have an idea on how to implement the whole thing, by using the version in go.mod and picking the latest known patch version that matches the minor version.

But testing is still broken for me, and I can't figure out what am I missing.

Thank you

I see it as mostly feature complete and don't do much to extend it features-wise. If something breaks, I'd fix it.
I'm also open to adding people with Write permissions as contributors/maintainers. If you want, I can add you. ^^
Other than that I'm looking at PRs. This month I'm taking a sabbatical break  and I won't be actively looking at anything.
Issues running tests
I have read through the [CONTRIBUTING.md](https://github.com/syndbg/goenv/blob/master/CONTRIBUTING.md) doc, and I was unable to run tests. I keep getting this error:

↳ make test
set -e
/bin/sh: -c: line 1: syntax error: unexpected end of file
if [ -d "/Users/idemarino/Workspaces/opensource/goenv/bats-core" ]; then
make: *** [bats] Error 2
I tried a few things but none seemed to help.

For context, I'm on:

macOS 12.4 "Monterey"
Apple M1 Pro (ARM64)
$BASH_VERSION=5.1.16(1)-release

Hmm, that's strange. Just ran it on my machine.
272 tests, 0 failures
-------
$ uname -a
Linux DESKTOP-AKE17NH 5.4.91-microsoft-standard-WSL2+ #4 SMP Fri Mar 12 12:47:57 EET 2021 x86_64 x86_64 x86_64 GNU/Linux
---------
$ bash --version
bash: GNU bash, version 5.1.8(1)-release (x86_64-pc-linux-gnu)

What is failing tho is the goenv-go-build tests. But those aren't really important for what you're trying to do.
41 tests, 4 failures
make: *** [Makefile:26: run-goenv-go-build-tests] Error 1

I can only speculate it might be something ARM-specific, but I don't really use ARM hardware myself to be able to test it out. :/

Any traction on this PR? It seems like a good idea

Hey @EfChouTR - I'd love to make some progress, but I need help with that issue I describe above.
Since I opened the PR I haven't had time to dig deeper, but if you have suggestions on what might be causing the tests to fail, I'd give it a go soon.

@detro I made a PR for your branch; all the unit tests are fixed, and I merged the latest master changes into my branch, which will bring your PR up to date.

As long as tests pass, I can see this being merged.
One thing I'd suggest before merging it is to introduce it behind a feature flag, so that we can test it out in "isolation". E.g GOENV_GOMOD_VERSION_ENABLE=1/0, default = 0 (off). That we can  make sure it's not a major change for existing users. It'll eventually be changed to 1 (on) by default as we gain "confidence".

As long as tests pass, I can see this being merged.
One thing I'd suggest before merging it is to introduce it behind a feature flag, so that we can test it out in "isolation". E.g GOENV_GOMOD_VERSION_ENABLE=1/0, default = 0 (off). That we can make sure it's not a major change for existing users. It'll eventually be changed to 1 (on) by default as we gain "confidence".

@syndbg
The following PR into @detro's fork should resolve all failing tests and add new tests for new feature + feature flag
detro/goenv#1
Once this is merged we should  re-run the tests

I just merged @ChronosMasterOfAllTime PR into my branch, so it contains the additional "default off" ENV VAR, but also some formatting/spacing fixes too. I don't know if this is ok or not @syndbg , but they looked nice improvements.
@ChronosMasterOfAllTime went the extra mile and even provided tests for the new feature, awesomesauce!
I unfortunately haven't had time to actually check out the branch and try to run the tests locally again: that will have to wait for Monday, when I might have more free time.
Very excited for this progress, and I can't thank @ChronosMasterOfAllTime enough (nice username btw :D)

I just merged @ChronosMasterOfAllTime PR into my branch, so it contains the additional "default off" ENV VAR, but also some formatting/spacing fixes too. I don't know if this is ok or not @syndbg , but they looked nice improvements.
@ChronosMasterOfAllTime went the extra mile and even provided tests for the new feature, awesomesauce!
I unfortunately haven't had time to actually check out the branch and try to run the tests locally again: that will have to wait for Monday, when I might have more free time.
Very excited for this progress, and I can't thank @ChronosMasterOfAllTime enough (nice username btw :D)

Thanks! Don't forget to remove the WIP and HELP NEEDED from the PR title 😁


TypeError: img2img() missing 1 required positional argument: 'image'

 in
1462                     raise SystemExit('\33[33mExecution interrupted by user.\33[0m')
1463                 except Exception as e:
-> 1464                     raise e
1465                 finally:
1466                     clean_env()
2 frames
 in diffuse_run()
558                     image = pipeout.images[0]
559                 else:
--> 560                     pipeout = pipe.img2img(prompt=PROMPT, negative_prompt=NEG_PROMPT, num_inference_steps=STEPS, init_image=init, strength=INIT_SCALE, guidance_scale=SCALE, generator=gen_seed)
561                     image = pipeout.images[0]
562             else:
TypeError: img2img() missing 1 required positional argument: 'image'

Recursive Hybrid evo fails when loading during it's first iteration.

Yeah, likely due to diffusers changing "init_image" to just "image". I'll
patch here soon.
On Wed, Dec 21, 2022, 3:50 AM malroth @.***> wrote:

Recursive Hybrid evo fails when loading during it's first iteration.
—
Reply to this email directly, view it on GitHub
https://github.com/WASasquatch/easydiffusion/issues/11#issuecomment-1361217677,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIZEZOASOOLLGFDWQ4MJYDWOLVHZANCNFSM6AAAAAASVAOSWE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Development branch is patched for this.


Route-based IPsec / SNAT / packets are not entering the tunnel

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
After switching from a policy base IPSec to route-based IPSec the SNATed packets are not entering the tunnel. In the firewall log I can see the transformation of the packets with activated and deactivated rules. I have tried the 1to1 NAT like before and the outbound NAT. Both have the same impact on the addresses in the firewall log, but the packets are not reaching the other end of the tunnel.
To Reproduce
Steps to reproduce the behavior:
Configure an route-based IPSec connection with <IP_ADDRESS> <> <IP_ADDRESS> "policy". Try to SNAT one of networks from side A and look at the end on side B.
Expected behavior
A clear and concise description of what you expected to happen.
Environment
OPNsense 19.1.10-amd64
FreeBSD 11.2-RELEASE-p10-HBSD
OpenSSL 1.0.2s 28 May 2019

just to be sure, you configured the rule on the VTI device? (not on ipsec in general)

I have tried both. The old configuration IPSec and the new vti device.

In the firewall log I can see the packet two times. First on the vti and then on the IPSec device.

you should configure your nat rule on the vti device, more details might help by the way (your ticket doesn't contain a lot of it, exact rule, expected result, etc).
I'm quite sure I've tested a source nat entry quite recently.

I have a closed network at several remote locations all with network <IP_ADDRESS>/24. The devices in this network can only comunicate with the gateway .201. They are very old and it is not possible to reconfigure them.
With DNAT the destination is changed to the communication server IP in the local network <IP_ADDRESS>. This is working because I see the packets in the local OPNsense with a source address of the remote location, e.g. <IP_ADDRESS>.
Now I must change the source address to an address which belongs to the location. Before I have used 1to1 NAT with this configuration:
Schnittstelle | Externe IP | Interne IP | Ziel IP | Beschreibung
IPSec | <IP_ADDRESS>/32 | <IP_ADDRESS>/24 | <IP_ADDRESS>/24
Now it is the same but with "vti_test" as "Schnittstelle".
I also tried the outbound NAT with this configuration:
Schnittstelle | Quelle | Quellport | Ziel | Zielport | NAT Adresse | NAT Port | Statischer Port | Beschreibung |
vti_test | INFO Netzwerk | * | <IP_ADDRESS>/24 | * | LAN Adresse | * | NEIN |

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


Evaluate ContentLength as int

If Content-Length is not shown on the header, res.ContentLength would be -1 (https://golang.org/pkg/net/http/#Response)
If we cast it to uint, it become a max value of uint, so we have to evaluate it as int64

Coverage decreased (-0.4%) to 75.092% when pulling 542320b3cf2a44e1d28fd2590a9d203316e70f38 on Rompei:fix-content-length-evaluation into 7bace10b201ad40c4d9a37f0155d479f369bb918 on Code-Hex:master.

@Rompei Thanks!! Nice PR.


[Feature?] Seing more played songs and ability to star them.

This is a pretty specific use-case, but I usually listen to the radio when I am driving.
And that means I usually can't favourite/star a song (unless I'm at a red light or smt)
Also, only the last 2 played songs can be seen making this even worse ;...;
Yes, technically I can manually search the song and favorite it BUT, yet again I can only see 2 last songs, and most of the time the name will be in kana not in romaji/english, so entering is quite difficult  😱
Doing (expandable?) list of 5~ and having an ability to star them would be 👌
Thanks : )

This should probably be discussed here: https://github.com/LISTEN-moe/feedback
Arkon could theoretically expand it himself by saving the last played songs and extending them himself, but if you want to be able to have this across all devices and services you should definitely post that there to open a discussion about it.

Can favourite from the last played dialog in v3.0.0-alpha.12.


Syslog: remove legacy remote logging

With the new options available in 19.7 we should begin to schedule removal of the old remote logging options in diag_logs_settings.php
Setting up new remote loggers is quite easy with the new grid in /ui/syslog/ and has more options than the old version. I would like to suggest to just ditch "Remote Logging Options" in 20.1 and skip migration code to avoid spending quite some time on this area.

Indeed, good approach. 👍


fix method findAndRemove

There is currently a method called findAndRemove that lives in /lib/findAndRemove.js.
It is incomplete and needs to be fixed!
It finds and removes all occurrences of the given second argument number if present in the array and returns the modified array else returns false if no such element was found in the array.
Acceptance Criteria:

Running yarn test <methodName> results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!
Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

Assuming request #653 is merged.

I'd like to try this one, if that's ok.

Yeah man. Absolutely


Is it possible to run raw sql queries to mock the database?

I'm thinking in running a raw sql query to mock my database instead of creating a struct schema.
Example:
I run this query and it creates the table address in-memory
CREATE TABLE address (id INT PRIMARY KEY);
Is it possible or I need to define the schema?

Yes it is possible. You can work backwards from our testing setup starting here.
Essentially, you will have to define query engine, which we have some default initializations of in our testing environment. Please feel free to follow up if you have any additional questions.


Blackjack command improvements

It works just fine but we could clean it up a bit.
For example, the embed can be made to display the current player's avatar so it's easier to tell whose game is which

I already did this apparently??


Add packages to $PackageExclusions which do not build properly in Docs CI

@danieljurek ignore the failures or requeue the builds. The conda failures are unrelated to this PR and they've been disabled temporarily in main.

/check-enforcer override


Error=INVALID_PARAMETERS'. It is missing 'token' field

I'm having an issue where APNS token returns null after uninstalling and installing the app again, thus not being able to receive push notifications
after enabling permission, I sometimes get this error:
2020-06-04 13:07:25.563801+0800 Trienekens[353:9277] 6.25.0 - [Firebase/Messaging][I-FCM004001] Failed to subscribe to topic Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INVALID_PARAMETERS'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INVALID_PARAMETERS'. It is missing 'token' field.}
2020-06-04 13:07:25.565650+0800 Trienekens[353:9341] 6.25.0 - [Firebase/Messaging][I-FCM004001] Failed to subscribe to topic Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INVALID_PARAMETERS'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INVALID_PARAMETERS'. It is missing 'token' field.}

Originally posted by @almiraputrisandy in https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated/issues/75#issuecomment-638600950

This warning does not seem to make any impact at the moment.


Update client.py

When making a client, now you can do Client("key here") for a key or Client() for no key.

Seems a bit unnecessary...
Plus it's only viable in python3 not python2, so it would not work for people who use the lib with python2.
A blank param really isn't a horrible thing.


feat: add reason to BlockResponse messages

Description
add reason of rejection to block response
Related issue(s)
If this Pull Request is related to an issue, mention it here.

Fixes #526

The main idea behind this PR is to provide a message to peers once their request is rejected. There are several reasons why a request might be rejected. For example, the peer is not known (here), or they request a block that we don't have (here), etc.
In my opinion, we should not consider a rejected request as a failure(or byzantine). It might be, but we can't consider it as such. Consequently, our current practice of increasing the failure counter is incorrect. In this context, we could merge the Busy and Rejected codes. I'm sorry, I didn't notice earlier that we were adding to the failure counter.
Please note that a reason could be added as a new parameter for the NewBlocksResponseMessage function.

The main idea behind this PR is to provide a message to peers once their request is rejected. There are several reasons why a request might be rejected. For example, the peer is not known (here), or they request a block that we don't have (here), etc.
In my opinion, we should not consider a rejected request as a failure(or byzantine). It might be, but we can't consider it as such. Consequently, our current practice of increasing the failure counter is incorrect. In this context, we could merge the Busy and Rejected codes. I'm sorry, I didn't notice earlier that we were adding to the failure counter.
Please note that a reason could be added as a new parameter for the NewBlocksResponseMessage function.

request changes resolved, please review.


add option to skip local storage for autoscaler addon

What this PR does / why we need it:
The cluster-autoscaler addon often does not scale down the nodepool if there are pods running which have an emptyDir volume, e.g. The default behaviour of keeping these nodes is perfectly OK, but there are also many reasons why someone wouldn't want that. In order to enable KubeOne users to choose the option they prefer, I added another parameter to the addon.
Which issue(s) this PR fixes:
None, its a new feature
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Add `CLUSTER_AUTOSCALER_SKIP_LOCAL_STORAGE` parameter for cluster-autoscaler addon used to skip local storage when downscaling nodes (see https://github.com/kubermatic/kubeone/tree/main/addons/cluster-autoscaler for more details)

Documentation:
TBD

I already updated the addons/cluster-autoscaler/README.md in my commit :slightly_smiling_face:

/retest

/lgtm
/approve

@kron4eg I just realised I set the wrong default (normally its true), so this might be a breaking change if you release it like this in v1.7.
Should I open another PR or could you switch the default value for this option to true (Also in the readme)? :man_facepalming:

@kron4eg I just realised I set the wrong default (normally its true), so this might be a breaking change if you release it like this in v1.7.
Should I open another PR or could you switch the default value for this option to true (Also in the readme)? 🤦♂

please open a new PR


what's the difference between net_G_last.pth and net_G.pth?

net_G_last.pth is the checkpoint in the last epoch and net_G.pth is another. You can use net_G_last as our baseline.


Remove MSDN zip xref config from existing .NET repos

Remove MSDN zip xref config from existing .NET repos

Docs Build status updates of commit 839f0b8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 136: [Error] Restore nuget package W:\pj25-s\.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\pj25-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.222' of package 'Microsoft.OpenPublishing.CommonPlugins'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.222' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.222' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.
Line 136: [Error] Restore nuget package W:\pj25-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\pj25-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.669' of package 'Microsoft.DocAsCode.ECMA2Yaml'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.669' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.669' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 839f0b8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:x:Error

Details

.openpublishing.publish.config.json

[Error-ECMA2Yaml_SDP_MigrationNeeded] This repo/docset is not SDP-enabled. Please contact<EMAIL_ADDRESS>to enable SDP on this repo.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 714d46a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.TextEncodingType.yml
:x:Error

Details

:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SelectStringCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.RemoveServiceCommand.ProcessRecord.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportPSSessionCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.FormatHex.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SetServiceCommand.ProcessRecord.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportClixmlCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ImportCsvCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.NewServiceCommand.BeginProcessing.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportCsvCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SendMailMessage.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.OutFileCommand.Encoding.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostUserInterface.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Language.FunctionMemberAst.Parameters.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Language.FunctionMemberAst.Body.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostRawUserInterface.CursorPosition.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostUserInterface.WriteProgress.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.FunctionInfo.ScriptBlock.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.CommandInfo.Visibility.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Runspaces.RunspaceFactory.CreateRunspace.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.PSVariable.Visibility.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.ArgumentTransformationAttribute.yml
:warning:Warning

Details

pscore-docs-dotnet/api/System.Management.Automation.Runspaces.RunspaceFactory.yml
:warning:Warning

Details

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.TextEncodingType.yml

[Error-ViolateSchema]

Schema validation failed. Please validate the file and make sure it conforms to schema 'NetEnum' (https://static.docs.com/ui/latest/schemas/NetEnum.schema.json):
Property 'obsoleteMessagesWithMoniker' has not been defined and the schema does not allow additional properties. Path 'obsoleteMessagesWithMoniker'.

[Warning-ECMA2Yaml_Moniker_EmptyAssembly] W:\1sxa-s\pscore-docs-dotnet\xml\FrameworksIndex\pscore-6.0.0.xml have empty assembly.

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SelectStringCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.RemoveServiceCommand.ProcessRecord.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.Internal.ArchitectureSensitiveAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportPSSessionCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.FormatHex.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SetServiceCommand.ProcessRecord.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.Internal.ArchitectureSensitiveAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportClixmlCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ImportCsvCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.NewServiceCommand.BeginProcessing.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.Internal.ArchitectureSensitiveAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.ExportCsvCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.SendMailMessage.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/Microsoft.PowerShell.Commands.OutFileCommand.Encoding.yml

[Warning-UidNotFound] Unable to find uid "System.Management.Automation.ArgumentToEncodingTransformationAttribute".

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostUserInterface.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.Cmdlet.WriteProgress(System.Int64,System.Management.Automation.ProgressRecord)".

pscore-docs-dotnet/api/System.Management.Automation.Language.FunctionMemberAst.Parameters.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.Language.IParameterMetadataProvider.Parameters".

pscore-docs-dotnet/api/System.Management.Automation.Language.FunctionMemberAst.Body.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.Language.IParameterMetadataProvider.Body".

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostRawUserInterface.CursorPosition.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.Host.PSHostRawUserInterface.SetBufferContents(System.Management.Automation.Host.Coordinates,System.Management.Automation.Host.BufferCell[0:,0:])".

pscore-docs-dotnet/api/System.Management.Automation.Host.PSHostUserInterface.WriteProgress.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.Cmdlet.WriteProgress(System.Int64,System.Management.Automation.ProgressRecord)".

pscore-docs-dotnet/api/System.Management.Automation.FunctionInfo.ScriptBlock.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.IScriptCommandInfo.ScriptBlock".

pscore-docs-dotnet/api/System.Management.Automation.CommandInfo.Visibility.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.IHasSessionStateEntryVisibility.Visibility".

pscore-docs-dotnet/api/System.Management.Automation.Runspaces.RunspaceFactory.CreateRunspace.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "Microsoft.PowerShell.DefaultHost".

pscore-docs-dotnet/api/System.Management.Automation.PSVariable.Visibility.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "System.Management.Automation.IHasSessionStateEntryVisibility.Visibility".

pscore-docs-dotnet/api/System.Management.Automation.ArgumentTransformationAttribute.yml

[Warning-UidNotFound] 2 invalid cross reference(s) "System.Management.Automation.ArgumentTypeConverterAttribute", "<xref:System.Management.Automation.ArgumentTypeConverterAttribute>".

pscore-docs-dotnet/api/System.Management.Automation.Runspaces.RunspaceFactory.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "Microsoft.PowerShell.DefaultHost".

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


restore previous session

Description of the new feature/enhancement

Proposed technical implementation details (optional)

I usually have about a dozen tabs open in Windows Terminal (each with a different profile, name, tab color, directory, etc.).  When I have to reboot (e.g., to install a Windows update) I have to re-open each of these all over again.  I would be great if there was a "restore previous session" option (similar to History -> Restore Previous Session for Firefox or Ctrl+H for Edge or Ctrl+Shift+T for Chrome).

This is a popular request we already have on our backlog. 🙂
/dup #961

My feature request (#10598) would (I expect) be a LOT simpler to
implement than what the alleged duplicate (#961) describes.  The latter
talks about restoring the complete state of a previously closed session
(with possibly several layers of CMD and Powershell processes).  I don't
particularly care about a tab's state -- all I'd like is to be able to
easily restore all previously open tabs to their normal initial states.
10598 would of course be necessary as a prerequisite for implementing 961,
but perhaps it could be a first step, and released earlier than the full
961.
On Fri, Jul 9, 2021 at 10:53 AM msftbot[bot] @.***>
wrote:

Closed #10598 https://github.com/microsoft/terminal/issues/10598.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/10598#event-5000821548, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUZGAQYP7V5BUR5SP7P3E6LTW4EPHANCNFSM5ACWRRUQ
.

I should've maybe marked it as a duplicate of https://github.com/microsoft/terminal/issues/766. 🙂
In either case, what you suggest is exactly what we intend to do: In an initial version we'll only restore the state of the window and its tabs in their initial states, without restoring the exact state in particular. Later on we'll add features like persisting the buffer.

Excellent!!  Thank you.
On Fri, Jul 9, 2021 at 3:55 PM Leonard Hecker @.***>
wrote:

I should've maybe marked it as a duplicate of #766
https://github.com/microsoft/terminal/issues/766. 🙂
In either case, what you suggest is exactly what we intend to do: In an
initial version we'll only restore the state of the window and its tabs in
their initial states, without restoring the exact state in particular.
Later on we'll add features like persisting the buffer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/10598#issuecomment-877422085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUZGAQYSLTG3VL2SAKMWSPDTW5HZNANCNFSM5ACWRRUQ
.


Flutter wake up

fixes https://github.com/Picovoice/picovoice/issues/106
If the analysis rules are unwanted, I can make a new PR only containing this change.

@AlexHartford, thanks for this. Can you put the wake word change in a PR for us?


feat: configure - manage Armada via a configuration file

As our settings grow we want to make user that we manage these via a armada.conf file.
Things to manage:

[ ] ssh key path
[ ] logs
[ ] kubernetes config path

which files are currently using these settings?
and also are these the names of the settings we want to use?


How to use PlayJongo from static context?

Hi! i'm new using jongo on Play Framework 2.5 and i was trying to use it like in Play Framework 2.4, but PlayJongo class can't be used from a static method.
Cheers, Jorge

To use play-jongo with Play 2.5.x I create a folder named repositories at the same level of controllers and models to obtain a structure like:
|-controllers
|- models
|- repositories
In models I've the collection structure, like:
public class Users {

    @JsonProperty("_id")
    private ObjectId _id;
    private String firstname;
    private String lastname;
    private String email;

In the repositories I've a class for each model containing the play-jongo injection, the MongoCollection and all operations I want to do with the collection:
public class UsersRepository {

    @Inject
    private PlayJongo jongo;

    private MongoCollection users() {
        return jongo.getCollection("DB.users");
    }

    public Users findByEmail(String email) {
        return users().findOne("{email: #}", email).as(Users.class);
    }

In the controller  I've to inject UsersRepository to obtain access to the collection methods:
import views.html.modifyUserView

public class User extends Controller {

    @Inject private UsersRepository users;

   @Security.Authenticated(Secured.class)
    public Result modifyUser(String email) {
        Users u = users.findByEmail(email);
        return ok(modifyUserView.render(u));
    }

I hope this help you.


chore: add nodejs as a builder key

The https://github.com/knative-sandbox/func-tastic repo uses "nodejs" instead of "node" as the language runtime. This change makes it possible for templates in the func-tastic language pack to work out of the box.
Signed-off-by: Lance Ball<EMAIL_ADDRESS>/kind chore
adds support for "nodejs" as a runtime designation in addition to the default "node"

/lgtm


fix(angular): Allow widgets to be styled in IE8 and below

Closes #584

Made all changes as above. Added issue-584.html to this pull request.

Btw, why did you decided not to add unit test for this ? Any problems with the approach we discussed ?

As per our conversation, added the check for "@" in the element name. Also, fixed typo (issue-352.html -> issue-584.html).

one small issue. otherwise LGTM. I'll fix it and squash it.

landed as 163c799effd5cfadc57990f4d4127651bae3fbdb
thanks!


ADGroup: Not restoring deleted object

Details of the scenario you tried and the problem that is occurring
When removing a group and then trying to restore the deleted group it fails and instead a new group is created.
Verbose logs showing the problem
    Context When using configuration MSFT_ADGroup_RemoveGroup1_Config
WARNING: It is not recommended to use domain credential for node 'localhost'. In order to suppress the warning, you can add a property named 'PSDscAllowDomainUser' with a value of $true to your DSC configuration data
for node 'localhost'.
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' =
root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADGroup\MSFT_ADGroup.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Importing the module MSFT_ADGroup in force mode.
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Retrieving group membership based on 'SamAccountName' property. (ADG0001)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] AD Group 'Ensure' is not correct. Expected 'Absent', actual 'Present'. (ADG0011)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADGroup]Integration_Test]  in 0.4530 seconds.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Importing the module MSFT_ADGroup in force mode.
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Retrieving group membership based on 'SamAccountName' property. (ADG0001)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Removing AD Group 'DscGroup1'. (ADG0007)
VERBOSE: [DC01]: LCM:  [ End    Set      ]  [[ADGroup]Integration_Test]  in 0.8750 seconds.
VERBOSE: [DC01]: LCM:  [ End    Resource ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]: LCM:  [ End    Set      ]
VERBOSE: [DC01]: LCM:  [ End    Set      ]    in  1.8590 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 2.234 seconds

    Context When using configuration MSFT_ADGroup_RestoreGroup1_Config
WARNING: It is not recommended to use domain credential for node 'localhost'. In order to suppress the warning, you can add a property named 'PSDscAllowDomainUser' with a value of $true to your DSC configuration data
for node 'localhost'.
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' =
root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADGroup\MSFT_ADGroup.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Importing the module MSFT_ADGroup in force mode.
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] AD Group 'DscGroup1' was not found. (ADG00010)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] AD Group 'Ensure' is not correct. Expected 'Present', actual 'Absent'. (ADG0011)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADGroup]Integration_Test]  in 0.3290 seconds.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Importing the module MSFT_ADGroup in force mode.
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] AD Group 'DscGroup1' was not found. (ADG00010)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Attempting to restore the group DscGroup1 from recycle bin. (ADG0009)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Finding objects in the recycle bin matching the filter msDS-LastKnownRDN -eq "DscGroup1" -and objectClass -eq "Group" -and isDeleted -eq $true.
(ADCOMMON0027)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Did not find a restorable object in the recycle bin. (ADCOMMON0055)
VERBOSE: [DC01]:                            [[ADGroup]Integration_Test] Adding AD Group 'DscGroup1'. (ADG0005)
VERBOSE: [DC01]: LCM:  [ End    Set      ]  [[ADGroup]Integration_Test]  in 0.9370 seconds.
VERBOSE: [DC01]: LCM:  [ End    Resource ]  [[ADGroup]Integration_Test]
VERBOSE: [DC01]: LCM:  [ End    Set      ]
VERBOSE: [DC01]: LCM:  [ End    Set      ]    in  1.7350 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 2.239 seconds

Suggested solution to the issue
None.
The DSC configuration that is used to reproduce the issue (as detailed as possible)
<#
    .SYNOPSIS
        Remove a group.
#>
Configuration MSFT_ADGroup_RemoveGroup1_Config
{
    Import-DscResource -ModuleName 'ActiveDirectoryDsc'

    node $AllNodes.NodeName
    {
        ADGroup 'Integration_Test'
        {
            Ensure     = 'Absent'
            GroupName  = $Node.Group1_Name

            Credential = New-Object `
                -TypeName System.Management.Automation.PSCredential `
                -ArgumentList @(
                $Node.AdministratorUserName,
                (ConvertTo-SecureString -String $Node.AdministratorPassword -AsPlainText -Force)
            )
        }
    }
}

<#
    .SYNOPSIS
        Restore a group from recycle bin.
#>
Configuration MSFT_ADGroup_RestoreGroup1_Config
{
    Import-DscResource -ModuleName 'ActiveDirectoryDsc'

    node $AllNodes.NodeName
    {
        ADGroup 'Integration_Test'
        {
            Ensure                = 'Present'
            GroupName             = $Node.Group1_Name
            RestoreFromRecycleBin = $true

            Credential            = New-Object `
                -TypeName System.Management.Automation.PSCredential `
                -ArgumentList @(
                $Node.AdministratorUserName,
                (ConvertTo-SecureString -String $Node.AdministratorPassword -AsPlainText -Force)
            )
        }
    }
}

The operating system the target node is running
n/a
Version and build of PowerShell the target node is running
n/a
Version of the DSC module that was used ('dev' if using current dev branch)
dev

So this did not work because I did not enable the Recycle Bin in the lab environment. I honestly thought the Recycle Bin was enabled by default.  🙂
But I will send in a PR that adds a bit of documentation around this.


Refactor Fixed Point Representation to Use Native Signed Integers

Currently, fixed points in Orion are represented by a struct defined as follows:
FP {
  mag: usize,
  sign: bool
}

The mag field represents the magnitude, and the sign field indicates the sign of the number, with false being positive and true being negative. This structure was initially chosen because Cairo did not natively support signed integers at the time. Presently, we support four fixed point types: FP16x16, FP8x23, FP32x32, and FP64x64. The latter two types were adopted from the Cubit library.
Given that Cairo now natively supports signed integers, we should update our fixed point implementation to use native signed integers instead of the current struct-based approach.
Given the extensive changes required, an initial PR could focus on the FP16x16 implementation. Since the Tensor and NN libraries heavily rely on FP16x16, we can start by introducing a new implementation in the fixed point directory named f16x16. This will allow us to refactor without removing the existing FP16x16 implementation and plan further updates in the Tensor and NN libraries in subsequent PRs.

Hi @raphaelDkhn I would like to work on this

Hi @raphaelDkhn I would like to work on this


Copyright

Updates the copyright notices.

@KayEss The diff looks a bit weird but I think it's OK.


[release-v3.15] cherry-pick: Duplicate entry for FELIX_WIREGUARDMTU

Description

Original PR: #3725 (cherry picked from commit 9120bc8ded49e68a23dfc0165b360985ff5d93fe)
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

CC: @fasaxc

/sem-approve

CI doesn't seem to be running against this PR.  I'm digging into that...

If you want I can close / reopen to see if it fixes itself.

I've raised a support ticket, probably best to wait until they get back to me.

ACK

@hakman I'm sorry, I didn't see this PR!
I just merged a pick for this here: https://github.com/projectcalico/calico/pull/3755

I don't mind. Thanks for taking care of it. :)


[OSB] Mypets command missing count

The new /tools user mypets command doesn't show current count (X/49) anymore. Can we get that added back in?

Done


Php client for send push and encrypt it.

Does anyone have a plane to make a complete PHP LIB? If someone have a project, I love to help. Or if someone have the same idea do begin with, NEW, Im here. Just make in touch!
I know that the new PHP 7.1 will come with great improvements in the cryptography algorithms! Will be great!

yo tuve que ocupar node :S

It looks like there's a library here which would work for you - https://github.com/Minishlink/web-push


[openssl-windows[core]:x86-windows-static] build failure

Host Environment

OS: [Windows.]
Compiler: Visual Studio 2019 community

To Reproduce
Steps to reproduce the behavior:
.\vcpkg upgrade --no-dry-run
Failure logs
Starting package 12/22: openssl-windows:x86-windows-static
Building package openssl-windows[core]:x86-windows-static...
Error: Triplet file x86-windows-static.cmake not found
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

Did you recompile vcpkg.exe?

No error for me 1be75a28bfce2084bb0b59ec92a6853f13d7be66

vcpkg install openssl-windows:x86-windows-static
No error for me 1be75a2

I do a git pull, then I update --no-dry-run to update all used packages.
please instruct on how to update|recompile vcpkg

found the command [.\bootstrap-vcpkg.bat]

SSL failing
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/hiredis/portfile.cmake:27 (vcpkg_install_cmake)
scripts/ports.cmake:94 (include)

@RameshKandukuriB what command did you enter?

@gdiObjects, from your logs, it seems that you need recompile vcpkg by executing ".\bootstrap-vcpkg.bat".
Currenty x86-windows-static move to triplets/community.

Thanks! I figured it out earlier and was successful.

Great!

@RameshKandukuriB what command did you enter?

.\bootstrap-vcpkg.bat
vcpkg install hiredis[ssl]:x64-windows --recurse


add support for converting compiled model to hf

To address https://github.com/foundation-model-stack/fms-fsdp/issues/59
To convert compiled model, we can run
python fms_to_hf.py --model_variant 7b --compiled --load_path /fsx/lchu/...

To convert non-compiled model, we can run
python fms_to_hf.py --model_variant 7b --nocompiled --load_path /fsx/lchu/...

@JRosenkranz I wonder if this is something that should be included in fms adapters? I didn't realize compiled models may be saved in a different way?
@lchu-ibm alternatively, would it be possible to just change the way we save FSDP checkpoints for compiled models? it seems we really only want the _orig_mod , so we could just save that as 'models' when writing them out?

@JRosenkranz I wonder if this is something that should be included in fms adapters? I didn't realize compiled models may be saved in a different way?

Yes, I didn't realize this either. If the compiled models are saved in a different way, it might make sense to include an adapter for it provided through the source in get_model. I do agree though, it may make sense to just save the models in a different way. Another option is we can implicitly determine this and run the adapter that way?

@nairbv If we save it with dropping the intermediate key, then loading back would become another problem.
it is "cross join" scenario:
if we save compiled and load as compile, then no issue, as both expect that intermediate key.
if we save non-compiled and load as non-compile, then no issue.
if we save and load in different mode, then we need to massage the ckpt. (add or drop that intermediate key)
torch already has some PRs on automatically massage the ckpt by identifying this extra intermediate thing and add/remove it as needed.  sort of as @JRosenkranz mentioned about the "implicit" way.

Does this code handle the cross-loading cases? I see that with a compiled model, the script generates a compile-version state dict, then calls the usual torch.distributed._shard.checkpoint.load_state_dict() to update it. Does this function handle checkpoints in either format?

@daviswer for this PR, we aim at providing compile FSDP -> single cpu and non-compile FSDP -> single gpu.
The compiled one is done by overloading (add intermediate key when loading) and offloading (drop intermediate key when offloading).
Of course, there are many other scenarios. For the full scope, it might be handled by FMS or somewhere else.


Insert code to terminal problem with ^[

[ ] I have reset Atom to defaults prior to submitting report.
[ ] I have not reset Atom to defaults prior to submitting report.

Description

Have problems in text-editor and the Insert-text editor.
Steps to reproduce

1.keymap bind
'atom-text-editor':
'ctrl-enter': 'platformio-ide-terminal:insert-selected-text'
2.write code  'a=5'
3.send it to the terminal
Expected behavior:
a=5
Actual behavior:
a=5
^[
Reproduces how often:
1000% percent

Versions

> atom --version
2.1.3

> apm --version
1.36.0

OS name and version: Windows 10
Platformio-ide-terminal version: 2.9.1
Additional Information

All I send with ‘^[" whatever I send.

[ ]  I have reset Atom to defaults prior to submitting report.
[ ]  I have not reset Atom to defaults prior to submitting report.

Description
Steps to reproduce
1.keymap bind
'atom-text-editor':
'ctrl-enter': 'platformio-ide-terminal:insert-selected-text'
2.write code 'a=5'
3.send it to the terminal
Expected behavior:
a=5
Actual behavior:
a=5
^[
Reproduces how often:
1000% percent

Versions
> atom --version

> apm --version

OS name and version:Windows 10
Platformio-ide-terminal version:2.9.1
Additional Information

Thank you for reaching out with this bug report.
You are getting this reply because the issue template was not filled in its entirety, overwritten,  or some portions were partially left out.
This issue template contains important information to be able to provide any kind of support, and will help us triage or reproduce the issue. Without reproduction no workaround or fix can normally be derived...
Copy and paste the template located at https://raw.githubusercontent.com/platformio/platformio-atom-ide-terminal/master/.github/ISSUE_TEMPLATE.md and fill in all fields. Logs / Errors / other information should be added at the bottom in the Notes portion of the issue template.
Tickets without this information may be closed and labeled invalid at our discretion.
Thank you for your understanding.

[ ]  I have reset Atom to defaults prior to submitting report.
[ ]  I have not reset Atom to defaults prior to submitting report.

Description
Steps to reproduce
1.keymap bind
'atom-text-editor':
'ctrl-enter': 'platformio-ide-terminal:insert-selected-text'
2.write code 'a=5'
3.send it to the terminal
Expected behavior:
a=5
Actual behavior:
a=5
^[
Reproduces how often:
1000% percent

Versions
> atom --version

> apm --version

OS name and version:
Platformio-ide-terminal version:
Additional Information

Youre clearly having trouble here, re-posting the same info is not OK., please edit your post like so

Then complete all sections and full steps including screenshots and what files youre editing etc.
Thank you for your understanding.

Also works fine here.

Nope! it has the same problems here!
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年4月17日(星期三) 下午5:44
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [platformio/platformio-atom-ide-terminal] Insert code to terminalproblem with ^[ (#682)
Also works fine here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

my shelloveride is "E:\Software\Anaconda3\Scripts\ipython.exe"

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

My problem just act like this.

Also works fine here.

when I

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

When I select code and want to run it by “ctrl-enter”, it doesn't run and shows the code with "^[" at the end. I just add
'atom-text-editor':
'ctrl-enter': 'platformio-ide-terminal:insert-selected-text'
in the key map.

Hello again, Ive no idea what exactly you are doing, thereis not enough information provided in order for me to try to duplicate the issue exactly, Ive tried, it works here, and without knowing specifics which you omitted doesn't help me to help you.
Fell free to edit your main post and add more information, and at that time, Ill have another look. But at this time, there's nothing further I can contribute.
Thank you for your understanding.

I find is my shell problem.
When I use Ipython3.exe, it has the problem like this.
But When I use python.exe, it works fine. I use ipython-7.4.0

Thats the sort of information you could have provided, we dont read minds, but given that you found the issue, then its OK to better things.
So now we know the issue is external,the only thing I can suggest is use what works.
Further reading, #543, #426
Have a good day.

Also, if you Have Windows 1809, That breaks many terminals, best thing is to stick at best with Windows 10 - 1803 for the foreseeable future until MS fixes the issue causing the problems.


save_scene() limitation

get_tree().change_scene(scene_path) will discard anything a mod does on the scene that is changed to.

change_scene() creates a new instance from the path.
ModLoader.save_scene() uses packed_scene.take_over_path(original_scene_path) to override an existing scene.
ModLoader.save_scene() stores the packed_scene in ModLoader._saved_objects - maybe this can be used?
Why does this not work in the first place if the original resource is overridden with the changed one?

ModLoader.save_scene()
func save_scene(modified_scene: Node, scene_path: String) -> void:
	var packed_scene := PackedScene.new()
	var _pack_error := packed_scene.pack(modified_scene)
	ModLoaderUtils.log_debug("packing scene -> %s" % packed_scene, LOG_NAME)
	packed_scene.take_over_path(scene_path)
	ModLoaderUtils.log_debug("save_scene - taking over path - new path -> %s" % packed_scene.resource_path, LOG_NAME)
	_saved_objects.append(packed_scene)

After running the game in debug for 5 to 6 times it seems to work now? 👀


Enhancement: Only generate example once when Parameter(examples=[...]) is specified for path arg and its schema

Description
Explained below.
MCVE
import json

from litestar import Litestar, post
from litestar.openapi.spec import Example
from litestar.params import Parameter

@post("/{path_arg:str}")
def endpoint(
    path_arg: str = Parameter(examples=[Example(value="EXAMPLE_VALUE")]),
) -> None:
    pass

app = Litestar(route_handlers=[endpoint])

print(json.dumps(app.openapi_schema.to_schema(), indent=4))

The generated schema contains:
                    {
                        "name": "path_arg",
                        "in": "path",
                        "schema": {
                            "type": "string",
                            "examples": {  <------- HERE
                                "path_arg-example-1": {
                                    "value": "EXAMPLE_VALUE"
                                }
                            }
                        },
                        "required": true,
                        "deprecated": false,
                        "allowEmptyValue": false,
                        "allowReserved": false,
                        "examples": { <------- HERE
                            "path_arg-example-1": {
                                "value": "EXAMPLE_VALUE"
                            }
                        }
                    }

I would expect one occurrence is sufficient. The example was given for/as OpenAPI path parameter (via Parameter) so the latter is correct, and the JSON schema example (former one) can be dropped.
Steps to reproduce
1. `python app.py`
2. See the generated schema

Screenshots
No response
Logs
No response
Litestar Version
2.5.1
Platform

[X] Linux
[ ] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

This perhaps-too-eager-example-generation also applies to the response examples created via OpenAPIConfig(..., create_examples=True) as well, e.g.:
  "components": {
    "schemas": {
      "Response": {
        "properties": {
          "text": {
            "type": "string",
            "examples": {
              "text-example-1": {  <---- example per field, unnecessary?
                "description": "Example text value",
                "value": "DwEkQQHiBrmXZcSFtoJx"
              }
            }
          },
          "num": {
            "type": "integer",
            "examples": {
              "num-example-1": {  <---- example per field, unnecessary?
                "description": "Example num value",
                "value": 4966
              }
            }
          }
        },
        "type": "object",
        "required": [
          "num",
          "text"
        ],
        "title": "Response",
        "examples": {
          "response-example-1": {  <---- example per model, this is ok
            "description": "Example  value",
            "value": {
              "text": "IgNZYFcagWptUqCwdERi",
              "num": 3674
            }
          }
        }
      }
    }
  }

I don't know if the GUIs actually need or benefit from field-specific examples, but perhaps the model level one would suffice.

I don't know if the GUIs actually need or benefit from field-specific examples, but perhaps the model level one would suffice.

IMO as long as we don't have more granular settings for turning example generation on/off, generating them everywhere it's supported is the more reasonable approach since it covers more use cases. Say we don't generate examples for the fields but a user wanted examples generated for that, they would have no way of turning this on. This way, we might make the schema a bit more verbose, but it actually doesn't do any harm to have these examples in there.

That's a fair statement. All off by default, all enabled with create_examples=True.
However, currently errors do get examples by default, e.g.:
                  "examples": {
                    "NotAuthorized": {
                      "value": {
                        "status_code": 401,
                        "detail": "Missing or invalid credentials",
                        "extra": {}
                      }
                    }
                  }
                }

That's an exception to the rule.

I guess there are roughly 4 modes here:

JSON schema only
OpenAPI schema only
Both JSON + OpenAPI
None

There could be a toggle, but I agree that global on/off should be sufficient, as the OpenAPI schema is really intended as machine-readable and not really for humans.
(The other issue https://github.com/litestar-org/litestar/issues/3058 confused me a bit here.)


Darkmode added (CSI)

#8 enhancement/darkmode(CSI)

"Find CSI" text should be in Black colour in the light moe

I have made an update to the code. Please check. Thankyou.

Just remove the text shadow (in light mode) and we're good to go

Done!

Amazing :)


Further improvements

Exception handling improved
Tests improved

Sorry, this is a bit of a mess now, with the changes just merged in. I had started to rebase, but after growing even more gray hair, I gave up and just merged. Better to add this as a squash commit.

Looks great again - thanks @ml31415 !
No problem on the merge - apologies for jumping the gun on #8, totally missed the WIP tag.


Add Integration of Azure Media Services with AudioGraph and MediaComposition

I would like to input and output to Azure Media Services.

Oh and here is the url of Azure Media Services.
http://azure.microsoft.com/en-us/services/media-services/


Partial FreeBSD support

Add some support for FreeBSD:

Determine the number of processors on FreeBSD
GNU make is named gmake on *BSD

"Partial" because there are other necessary changes.

A few grinders to verify other platforms unaffected:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/382
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/384
If we had BSD machines at the project ATM, I would also run a few grinders on them, but this change is benign, and will merge.
It is partial as there will need to be a few other changes to enable all the testing available from this project (systemtest update to use gmake to compile native tests, and separate jenkins file which can be added when/if we get test machines at the project).

Thanks Shelley!
Yes, partial because there are other changes needed.  I don't have the system test suite working yet, but I can run the openjdk and functional test suites with some other changes I have locally.  I'll push those for review as well, but wanted to separate these out since I hoped they wouldn't be controversial at all.


s3 performance is slow

Bug Report
s3 performance is slow
Description
Ticket is based on topic in discord (“need-help” channel).
The problem is that I tried to use DVC with miniO (s3 compatible storage) and noticed that its performance is very slow.
My env:

miniO storage location is on SSD (Intel Optane, high performance)
MiniO server <------ 1000Mbit/sec --------> DVC (s3 client)
Bucket 40Gb - 410k files (each file <= 400KB)

DVC version: 2.0.17 (deb)
---------------------------------
Platform: Python 3.8.8 on Linux-5.4.0-70-generic-x86_64-with-glibc2.4
Supports: All remotes
Cache types: hardlink, symlink
Cache directory: ext4 on /dev/sda
Caches: local
Remotes: s3
Workspace directory: ext4 on /dev/sda
Repo: dvc, git

When I did dvc pull -j 20 maximum speed was 80 mbit/sec but average was about 40. I download the bucket for 220 minutes.
What I tried else:
dvc pull -j 80 - no improvements.
awscli - aws tool can maximum 160 Mbit/sec downloading speed. I tried different settings, but I couldn't exceed the limit.
s4cmd - maximum I got is about 130 Mbit/sec, 64minutes to get the bucket.
s5cmd - maximum 960 Mbit/sec and less than 10 minutes to download the whole bucket (GoLang)
So you can see that storage performance is okay but the download speed of tools written on python can not  reach maximum.
Reproduce
Profiler stat: https://disk.yandex.ru/d/XNajwHgWYlPSHA

FYI I'm seeing very slow transfer speeds to S3 when doing a dvc push. In comparison, when doing a aws s3 cp, I'm seeing throughput that is about 10-100x faster from the same machine.
Here's the output from dvc doctor on my machine.
DVC version: 2.45.0 (brew)
--------------------------
Platform: Python 3.11.2 on macOS-12.6.3-x86_64-i386-64bit
Subprojects:
	dvc_data = 0.40.1
	dvc_objects = 0.19.3
	dvc_render = 0.1.2
	dvc_task = 0.1.11
	dvclive = 2.0.2
	scmrepo = 0.1.9
Supports:
	azure (adlfs = 2023.1.0, knack = 0.10.1, azure-identity = 1.12.0),
	gdrive (pydrive2 = 1.15.0),
	gs (gcsfs = 2023.1.0),
	http (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
	https (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
	oss (ossfs = 2021.8.0),
	s3 (s3fs = 2023.1.0, boto3 = 1.24.59),
	ssh (sshfs = 2023.1.0),
	webdav (webdav4 = 0.9.8),
	webdavs (webdav4 = 0.9.8),
	webhdfs (fsspec = 2023.1.0)
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk3s1s1
Caches: local
Remotes: s3
Workspace directory: apfs on /dev/disk3s1s1
Repo: dvc, git

@diehl Are you also using minio?

@efiop I'm not. I don't know what minio is.

@diehl So real aws s3 then, right?

@efiop that is correct. using the AWS CLI.

Chatted with @diehl privately. For the record, there are two directories, one 5G total with 224 files and the other is 14G total with 63 files. Inside there are misc files, with 5G being the biggest one in the second dataset. So likely we need to look at a scenario of transferring individual large files.
Need to reproduce locally and see if there is anything on the surface.

This is probably an s3fs issue similar to the adlfs one we had recently.
s3fs _put_file()/_get_file() do support chunked (multipart) upload/downloads, but chunks within a single file are always done in sequence rather than in parallel. s3fs should probably be using asyncio.gather() or fsspecs run_coros_in_chunks() to batch the chunk transfers, and then reassemble them at the end as needed. I'm guessing this hasn't been addressed because doing the chunk transfers in parallel requires balancing those batched tasks with the file-level batching.

@pmrowla Do you think we should prioritize it and solve it? What would be your estimation there?

Handling it the same way we did with adlfs (where we only optimize the worst-case single large file upload/download scenario) should be relatively quick to do in s3fs, but I should note that it looks like they have tried to do concurrent multipart uploads before in some of the s3fs calls but ran into problems that made them revert to only sequential operations: https://github.com/fsspec/s3fs/blob/b1d98806952485be86379f0f4574ee4de24568a1/s3fs/core.py#L1768C31-L1769

It looks like it multipart upload requires a minimum size of 5 MiB for all but the last part: https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html
Also, to set expectations, the azure approach currently will only help when doing dvc push on a single file right @pmrowla?

Also, to set expectations, the azure approach currently will only help when doing dvc push on a single file right @pmrowla?

Yes that's correct

Should be resolved by https://github.com/fsspec/s3fs/pull/848

This is merged upstream and will be available in the next s3fs release

@pmrowla do you have an ETA for the next s3fs release by chance?

I don't have an ETA but generally the fsspec/s3fs maintainers are fairly quick about doing releases for work we've contributed upstream
cc @efiop

Roger that - thanks @pmrowla


feat: better getCount()

Changes:

Fixed wrong variable declaration error.
Used better APIs for Minecraft and Discord info.
Changed variables names to be better

Unrelated

Updated undici to 6.11.1
Fixed license link

pika-api


Button "run jon" for admin users at View

I've added a "run jon" button for admin users at View. This might facilitate the job dispatch

Hi @thiagoh and thanks for your contribution :-)
Looking at the changed files it looks like the change is mostly around formatting; caused probably by different editor settings?
Would you mind submitting this pull request with only the changes necessary to get the functionality you need in place?
Thanks!
Jan

sure! =) sorry about that.


Yarn

Please make support for yarn.

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

I'm not sure if @OlshaMB means yarn as the package manager. Anyway, let me know if you need any help on the Java port!

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

I'm not sure if @OlshaMB means yarn as the package manager. Anyway, let me know if you need any help on the Java port!

Ah, ok. Also, thanks for bringing that up as I do need some quick help with that. What classes as well in what spots in those classes would I need to edit in order to add LSP support for Java. I’m having trouble locating them so if you could tell me that would be greatly appreciated.

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.
Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.
Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.
Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.
Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

I didn’t, but there is a port out there already for iOS that I’m going to use.

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.
Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

I didn’t, but there is a port out there already for iOS that I’m going to use.

Great! Let me know if you make it work. I will work on the interface for adding LSP.
It will probably look something like this:
App.registerLanguageService(lang: .java, command: "command-to-launch-LSP")

Yarn blocker: fs.copyFile always fail. Investigation in node source code needed.

Ref: https://github.com/libuv/libuv/issues/3187
We need to modify libuv and rebuild nodejs to fix this.


Status of FixedPointVC (cleanup)

Boogie has a VC generation algorithm called FixedpointVC. It implements the interpolation-based duality algorithm. Is anyone using or experimenting with it? There are no associated tests. I fear that if no one is using it, then its probably in a broken state already. We should remove it and clean up the code, unless someone wishes to maintain it.
This option is exposed via Corral as well, so I will ask Corral users the same question.

The status of FixedPointVC is similar to StratifiedVC, i.e., it is a library that is consumed by Corral.  From Boogie's point of view, it is ok to not have tests for it in Boogie if Corral devs agree to maintain the library and have appropriate tests in Corral for it.  If support for interpolation is dropped in Corral itself, then there is little point keeping the library around in Boogie.

The discussion has shifted here:  https://github.com/boogie-org/corral/issues/136.  So I  am closing this issue.


refactor: use aegir

Fixes https://github.com/ipfs/js-ipfs/issues/119
Ref https://github.com/dignifiedquire/aegir/issues/1

Changes Unknown when pulling 773913d1ee7d91e26f7a4bf9652302a8b116002a on aegir into ** on master**.

wooooo ! :D This makes me super happy :D  Thank you!


[SP-4418] - Backport of PDI-16614 - Data service in CSV File Input do…

…es not work with Lazy conversion active (8.1 Suite)

Backport of PDI-16614 - Data service in CSV File Input does not work with Lazy conversion active (8.1 Suite)

@pentaho-lmartins , @ricardosilva88

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/row/value/ValueMetaBase.java
  core/src/test/java/org/pentaho/di/core/row/value/ValueMetaBaseTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.row.value.ValueMetaBase

Complexity Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Branch Change: -1.9% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:


Setting Up URLs

Define URLs for the views in "returns_exchanges/urls.py".
# In returns_exchange/urls.py
from django.urls import path
from . import views

urlpatterns = [
    path('signup/', views.signup, name='signup'),
    path('login/', views.user_login, name='login'),
    path('logout/', views.user_logout, name='logout'),
    path('', views.dashboard, name='dashboard'),
    path('return_exchange_request/<int:item_id>/', views.return_exchange_request, name='return_exchange_request'),
]

Include the app URLs in the main project urls.py.
# In ecommerce_project/urls.py
from django.contrib import admin
from django.urls import path, include

urlpatterns = [
    path('admin/', admin.site.urls),
    path('', include('returns_exchange.urls')),
]

Successfully set up URLs at the app and project level.


Assimp vendor package doesn’t forward assimp::assimp target properly

When assimp is found on the system and is new enough to expose the assimp::assimp new style cmake target, the logic to transform that into an absolute path fails.
Maybe it would be better to either leave it as is or check if there are colons in the name?

I'm pretty sure that this was fixed in #817, so I'm going to close this out.  If not, please feel free to reopen.


More generic exception while creating a Plan

I'd go with this more generic solution - we will catch any other possible problem if creation of the Plan fails.

How do you know it failed because of tag or another field? You removed the tag check.

I don't know exactly because of what field it failed. Now it is more universal, it will catch any exception (even if there was for example a database connection error). Just creation of the new record failed and then we raise "our" Exception. Because of whatever reason.

Yep, but the exception is explicit about a duplicate.

Yes, actually I think you can skip this pull release. I will give a test to beta.1 on Monday, the latest on Tuesday.


Add fuzzing harness

As I mentioned on the Reddit announcement thread, seeing 23 uses of the unsafe keyword in the GitHub repo search for a web app component that isn't being fuzzed makes me uneasy.
It'd probably be a good idea to get some fuzzing set up using something like cargo-fuzz, afl.rs, or honggfuzz-rs.
I'm having enough trouble just giving proper maintenance time to my own projects right now, so I can't be the one to do it but, if anyone else is interested, the Rust Fuzz Book has an introduction to cargo-fuzz and the beginnings of one for afl.rs.

@ssokolow Thanks for the tips! Fuzzing is known as one of the method to improve test coverage. Currently sailfish repository has 32 unsafe blocks or functions in total, so it seems to be good to add fuzzing tests.
I want to work on this. Please wait for a while because It requires for sailfish-compiler to export some APIs.

Thanks for the tips!
Glad I could help.

Fuzzing is known as one of the method to improve test coverage.
A way to discover new things to test, maybe, but I'm not sure I'd consider it a way to improve test coverage, given that fuzzing isn't the kind of thing you'd run as part of your CI runs.

That's more what property testing is for.

I want to work on this. Please wait for a while because It requires for sailfish-compiler to export some APIs.

No problem. I'm far too familiar with "I want to do this, but it'll take a while".


[ci skip] [cf admin skip] NO_CI Update dependencies using grayskull

Automate the dependency pin updates using grayskull. See https://conda-forge.org/docs/maintainer/conda_forge_yml.html#bot
Helps to prevent situations like #17 and #18 when PR is merged without dependencies being updated.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


Atom does not behave like a Windows application

Atom feels like a very alien program when running on Windows. Its behaviour does not match users' expectations.
Installation problems:

Not present in Start menu at all (can't press start, type "atom" to run)
Shortcut installed only on user's desktop (no option given to not clutter the desktop)
No proper way to launch if the desktop shortcut pointing to atom\update.exe --processStart atom.exe is removed
No proper way to find the application for Explorer's Open with... functionality

navigation to %LOCALAPPDATA%/Atom difficult to figure out and perform
impossible to know what to select once there -> Can't be set as a default text editor
related: #7205

Behaviour:

Pinning to taskbar does not work like Windows applications work

a new icon is produced when Atom is launched from taskbar (related: #7374)
update check probably not run in this case either?

Does not use OS mouse wheel scroll configuration (lines scrolled per wheel turn)

Windows 10 Pro x64 insider preview build 10130

Not present in Start menu at all (can't press start, type "atom" to run)

This sounds like there was a bug, it should definitely be in the start menu.

Pinning to taskbar does not work like Windows applications work

This is a Win10-only bug. We'll fix it if it's still there on RTM

Curiously, the Start menu shortcut seems to be in its correct place, %APPDATA%\Microsoft\Windows\Start Menu\Programs\GitHub, Inc, but the folder or the Atom shortcut do not show in the start menu. Something Windows 10 specific maybe?

I'm on Windows 7 and I don't see any start menu items either

@kevinsawicki Can we get Atom up to the current version of Squirrel so that we can verify if these are current bugs? Atom is way behind where Squirrel is now

Can we get Atom up to the current version of Squirrel so that we can verify if these are current bugs?

Yeah, sounds good.

I also met this problem. I can't find any shortcut on desk and start menu after first installed. So I uninstalled it from Control Panel. Curiously, I re-installed it. It works. It's showed under GitHub folder.
win 7 professional 64 bit

@paulcbetts: re pinning: There are also issues with pinning in windows 8.1. I've described it in a comment on the linked issue.

On Windows 7 the update.exe file (C:\Users\PC11\AppData\Local\atom\update.exe) is being removed sometime after the install. Still occurs on last version.

Windows 7 (32bit unfortunately), Atom 1.0.2 - same issue for me. No launch icons anywhere. Only saw the editor once, when first installing, and that locked up after ten minutes and have not been able to find out how to get back into it since. Have not tried reinstalling yet, as that eats up 2Gbytes of memory and locks up my PC for half an hour.

You can set Atom as default for certain file types on Windows, you just have to do it manually, pointing it to the exe. Something that should be changed is that Atom is not included in the suggestions of programs to open this file type with when you click them. I guess Atom just does not register itself for them?

I am using Windows 8 and atom appears in start menu just like all other applications. Although you have to manually set it as the default text editor.

I meant the "Open with.." menu, which shows all installed applications that registered to be able to handle this filetype.

@Stanzilla: Yes, you can do that, but Atom changes the directory every update and you have to manually change the path to the atom.exe again... so that's really bad for user experience, see #7205

I am aware that you can do that, my original point still stands though that Atom does not register itself for the file types..

Gonna close this out, please file bugs for these issues individually

This is the shortcut I found! C:\Users(Administrator Account)\AppData\Local\atom\app-1.13.0\atom.exe
I hope it helps!

The application is inside "local" folder of app_data and app_data is hidden, so you have unhide this folder first.

Same here.

atom just vanished

I can't set defaults to Atom since it doesn't show up in the list of apps to set defaults for.

I had to tick "Register as file handler". All three were unticked


Feature nomination tool for visualization

some way to narrow it down.  needs some kind of separability measure. order by variance?

minimize the number of crossovers for parallel coordinates visualization?

See #35

@bbengfort this is something we need for yellowbrick too - let's make sure we don't implement twice


No server verification option set in esp_tls_cfg_t structure

I generated a project with esp-idf-template.
I copied the code from here.
And tried to make a simple HTTP GET request:

fn get_request(client: &mut HttpClient<EspHttpConnection>) -> anyhow::Result<()> {
    let url = "https://httpbin.org/get";
    let request = client.get(url)?;
    info!("-> GET {}", url);
    let response = request.submit()?;
    info!("<- {}", response.status());
    std::thread::sleep(core::time::Duration::from_secs(5));
    Ok(())
}

I got this error:
E (4918) esp-tls-mbedtls: No server verification option set in esp_tls_cfg_t structure. Check esp_tls API reference
E (4918) esp-tls-mbedtls: Failed to set client configurations, returned [0x8017] (ESP_ERR_MBEDTLS_SSL_SETUP_FAILED)
E (4928) esp-tls: create_ssl_handle failed
E (4928) esp-tls: Failed to open new connection
E (4938) transport_base: Failed to open a new connection
E (4948) HTTP_CLIENT: Connection failed, sock < 0

In this repository (esp-idf-svc), there is mention of "esp_tls" in the following files: src/tls.rs, ws.rs, src/mqtt/client.rs
What am I supposed to add to my project to stop getting that error?
Note: this is what my entire file looks like.

This. The example is for mqtt, but https client wqorks the same.

I guess it should be something like this, but what should I put in ???
    let config = ?? {
        crt_bundle_attach: Some(esp_idf_svc::sys::esp_crt_bundle_attach),
        ..Default::default()
    };

    let mut client = HttpClient::wrap(EspHttpConnection::new(&config)?);

Thanks a lot! This worked.
use esp_idf_svc::http::client::{Configuration as HttpConfiguration, EspHttpConnection};

let config = &HttpConfiguration {
    crt_bundle_attach: Some(esp_idf_svc::sys::esp_crt_bundle_attach),
    ..Default::default()
};

let mut client = HttpClient::wrap(EspHttpConnection::new(&config)?);

get_request(&mut client)?;

I think this should be in the official examples? I was stuck for days.

I think this should be in the official examples? I was stuck for days.

Feel free to open a PR for a new / improved HTTP client example. I can only dedicate so much of my free time to this project in general, and writing examples for folks in particular. :)

You're right. You're already doing a great job. Okay, I'll open a PR soon.
Before I open the PR, one question: how come the http_client.rs example runs without crt_bundle_attach: Some(esp_idf_svc::sys::esp_crt_bundle_attach)? Or it hasn't been tested yet?

Because it is using HTTP, not HTTPS.

Oh, got it. Thanks for the clarification.


Deploy

**What does this PR do?
This a pull request for configuring eslint, removing an if statement from code block and for changing the name of a variable.
Description of Task to be completed?
Have the following

have a proper indentation on test files(question.spec.js & answer.spec.js)
have the if statement removed from GET /api/v1/questions controller function.

What are the relevant pivotal tracker stories?
#159951517

Pull Request Test Coverage Report for Build 46

17 of 17 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 93.269%

Totals

Change from base Build 34:
-0.4%

Covered Lines:
80

Relevant Lines:
84

💛  - Coveralls


experiments extended

I extended the experiments in the following ways

new models (KNN, LDA)
new metrics (precision for recall=90%, recall for precision=90%)
model visualization with plots for all the features

@mayagos please review and merge if it looks good to you

I like what you've done with precision and recall, but I'd tweak the descriptions in that table for readability.
I'd change "ap" to "average precision" and use something like "max precision for recall > 90%".
Since "lda" looks like the name "Ida", I'd also add caps to the row names (KNN, LDA, etc.)

I like what you've done with precision and recall, but I'd tweak the descriptions in that table for readability. I'd change "ap" to "average precision" and use something like "max precision for recall > 90%". Since "lda" looks like the name "Ida", I'd also add caps to the row names (KNN, LDA, etc.)

ok, done


Add development process to README

LGTM, we can always slow things down later if needed :)

Review, @jeremyrsmith ?

:+1: The process sounds good to me.


Team Peer Review

Name of the app: weather-dash
Link to the repo: https://github.com/snesunil/weather-dash
Link to the app: https://weather-dashboard-b052.onrender.com/
Link to the proposal.md file: https://github.com/UBC-MDS/citytemp/blob/main/docs/proposal.md

Hey Sneha! Great job, I enjoyed reading your README and the comparison of two cities' weather distribution with a line graph is such a great idea.
I also really liked the violin plots displaying every city in the selected state. I did find the hover text a little bit difficult to understand as there were many metrics that I couldn't make complete sense of.
Good work!

The layout and color uses are very clean and eye catching, nice job!

You could add the state name to the title to make the plot even more understandable , for example : "Avg Temperature in the NY state by month"
It seems like this app will need to take some time to display the plots, it might be a good idea to add spinner to let users know.

This app looks amazing! I like the idea of making a comparison of two cities.

For the "Avg Temperature in the state by month", I recommend not having the legend labelled as "month" but "temperature low to high". It fits people's intuition of understanding the plot.
For the "Distribution of temperature in Cities" maybe change it to "Temperature Distribution of cities in {state}" which treats the {state} as an updating input. It will be more clear to understand.


Failed to import - many-keys-weakmap | Dropped support for .js vs mjs extension

Failing module

npm: https://www.npmjs.com/package/many-keys-weakmap/v/1.0.0

import ManyKeysWeakMap from<EMAIL_ADDRESS>
Error message
After onload I got this:
404
Additional info

esm.sh version: 64
Browser version: Chrome 115 (latest)

So I think the problem is that at some point, support for the .js extension was dropped. The above link works with .mjs. This causes a few issues at the Pluto community where people have deployed versions of this without the m :(

the path structure has been changed, please use below urls:
import ManyKeysWeakMap from "https://esm.sh/v64/many-keys-weakmap@1.0.0?target=es2021"
// or
import ManyKeysWeakMap from<EMAIL_ADDRESS>

Thanks for your time looking into this! We will use the new in any future work, but users of old versions of Pluto have static HTML that point to the .js version on version /v64. These HTML files are deployed already and are not controlled by us - updating these will require user action. Is it possible for version 64 to respond to the .js endpoints as it used to?

We're using this style: https://github.com/fonsp/Pluto.jl/commit/8d63bde64771b4014b11034716c78c574b27c879 and https://github.com/fonsp/Pluto.jl/pull/2514 with the pin argument. Does it look ok?

i am adding a workaround to redirect the old url the new url.

will deploy the patch after testing

Thank you!

should works now

should works now

Thanks a ton! I can see the response in cURL from a US server (my browser has a Greek/EU IP so is still getting the old value from cloudflare 😅, but I have faith in cache invalidation!!)

done, would you like to try again 🙏

yes! works like a charm, thanks!!


[WFLY-4686] Missing list-delivering-messages operation

add list-delivering-messages (and -json variant) to jms-queue resources
add list-scheduled-messages (and -json variant) to jms-queue resources

JIRA: https://issues.jboss.org/browse/WFLY-4686

This feature was added to the messaging subsystem (in 12f374e)  after I forked the new messaging-activemq subsystem. This PR add its back to the new messaging-activemq subsystem.

Linux with security manager Build 1674 is now running using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f

Windows Build 1851 is now running using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f

Linux Build 6776 is now running using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f

Linux with security manager Build 1674 outcome was SUCCESS using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f
Summary: Tests passed: 856, ignored: 322 Build time: 0:06:28

Windows Build 1851 outcome was SUCCESS using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f
Summary: Tests passed: 2880, ignored: 395 Build time: 0:48:38

Linux Build 6776 outcome was FAILURE using a merge of 250bc333f024d8a21a576a7d423f05fdaa7d3b2f
Summary: Tests failed: 2 (2 new), passed: 2877, ignored: 395, muted: 1 Build time: 0:50:18
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

org.jboss.as.test.clustering.cluster.web.authentication.FormAuthenticationWebFailoverTestCase(SYNC-tcp).test: <no details avaliable>


Customizing of vote view

thanks for this!
do you think it'd be possible to add a test for this behavior?
On Wed, Jul 1, 2015 at 3:33 AM, eugena<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/jamesturk/django-secretballot/pull/23
Commit Summary

Customizing of vote view

File Changes

M secretballot/views.py
https://github.com/jamesturk/django-secretballot/pull/23/files#diff-0
(33)

Patch Links:

https://github.com/jamesturk/django-secretballot/pull/23.patch
https://github.com/jamesturk/django-secretballot/pull/23.diff

—
Reply to this email directly or view it on GitHub
https://github.com/jamesturk/django-secretballot/pull/23.

sure )