Build a histogram of log counts.

It would be very convenient to be able to build a time histogram to navigate through the logs.
But a grafana shows:
victorialogs-datasource. This datasource does not support full-range histograms. The graph below is based on the logs seen in the response
So it shows something, but not a full count of logs.

Think I'm hitting the same issue. Trying to use LogsQL to do a query for count() of logs lines grouped by time but limited by "Maximum lines" set in datasource.  I'm a Grafana + Loki user and have many alerts built on graphs using aggregations and range functions.

I thin #22 would help you too (and latest version of victorialogs).

Now, let's get back here.
I have tried to generate some Time series based on logs:
severity:info | stats by (_time:1m) count() res | sort by (_time)
It results data in the form:
Time (stamp), Line(string), labels (dict)
2024-06-28 07:46:00, {"res":"5"}, { "res": "5" }
2024-06-28 07:47:00, {"res":"25"}, { "res": "25" }

but grafana would really like stamp+numeric result in a form of:
2024-06-28 07:46:00, 5, { "res": "5" }
instead.
There would be nice to have some example (provided it actually works) how to get time series data from VL.

I also tried unsuccessfully to use Time series based on logs.
It might be interesting to create a new pipe to reformat the results returned to grafana depending on what you are trying to do.

There is not too much reaction on this subject. Is this a feature we can hope for in a future release?
Or will it never be possible to generate time series from victorialogs datasource?

Hi @crocchietta, we plan to add this feature in the future, but the exact timelines are not yet determined.

Thank you for taking the time to respond.
Very happy with victoriametrics, I chose to continue with victorialogs rather than using Loki. But this feature is missing and seems important to me.
Victorialogs has already evolved a lot. So I'll wait.
A roadmap specific to victorialogs-datasource would be interesting.
Thank you to the team for the work done.

I have a workaround for visualizations you can use the extract fields and convert field type to work around this issue for now, but it doesn't  work for explore and it requires extra steps for each panel which is not ideal.

@tiny-pangolin : thanks. I had already tried with extract fields but I missed the convert field type transformation at the grafana level.
Even though this adds steps in building a panel and requires a bit more computing power for the browser, it will allow me to wait for this feature to be added.

Starting from v0.8.0, victorialogs-datasource supports /select/logsql/stats_query and /select/logsql/stats_query_range endpoints, enabling Time series and other panel types.
We also plan to add support for /select/logsql/hits, which will allow displaying accurate histograms of log counts.

Hi! The feature was added in the new release. Please check it. If you find any issue, please reopen the issue.


Nav swipe back is transitioning the navbar to white

Short description of the problem:
My app has black header which I do by adding dark to the navbar and overriding the hex value in app.variables.scss.
All is good until I push from list page to detail page and swipe from the left to go back. The navbar transitions to white as the swipe back transition happens.
What behavior are you expecting?
The nav bar should not change colour at all during the swipe back.
Steps to reproduce:

Use an example project that has list/detail pages.
Set the navbar to be dark
navigate to the detail page and then swipe from the left to go back to the list page

Which Ionic Version? 1.x or 2.x
2.x beta 11
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 5.4.1
Gulp version:  CLI version 3.8.11
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.6
ios-sim version: 5.0.4
OS: Mac OS X El Capitan
Node Version: v5.11.1
Xcode version: Xcode 7.3.1 Build version 7D1014

This also happens when the detail page is being pushed on, so not something specific to swiping.

Hello @martinjbaker ! I can happily report that this should be fixed and the fix will be in the beta.12 release. Thanks for using Ionic!

Remove me from this mail conversation please.
On Aug 12, 2016 9:17 PM, "Justin Willis"<EMAIL_ADDRESS>wrote:

Hello @martinjbaker https://github.com/martinjbaker ! I can happily
report that this should be fixed and the fix will be in the beta.12
release. Thanks for using Ionic!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/driftyco/ionic/issues/7685#issuecomment-239520943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH3Uix7Zt5oQ5B9NEyFFl8xHZdFp-X83ks5qfLiYgaJpZM4JjCRS
.

@TomasKatz This is actually a problem with your github notifications settings and not anything that we have control over. Sorry!


failed to get 'zk_evm'

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
Linux
Describe the bug
Updating crates.io index
Updating git repository https://github.com/mm-zk/ethers-rs
Updating git repository https://github.com/matter-labs/zksync-era.git
Updating git submodule https://github.com/matter-labs/era-contracts.git
Updating git submodule https://github.com/matter-labs/era-openzeppelin.git
Updating git submodule https://github.com/a16z/erc4626-tests.git
Updating git submodule https://github.com/foundry-rs/forge-std
Updating git submodule https://github.com/dapphub/ds-test
Updating git submodule https://github.com/matter-labs/era-system-contracts.git
Updating git repository https://github.com/matter-labs/solidity_plonk_verifier.git
Updating git repository https://github.com/matter-labs/era-zk_evm.git
error: failed to get zk_evm as a dependency of package zksync_types v1.0.0 (https://github.com/matter-labs/zksync-era.git#44b265bd)
... which satisfies git dependency zksync_types (locked to 1.0.0) of package foundry-cli v0.2.0 (/home/k/work/era/fzksync/foundry-zksync/cli)
Caused by:
failed to load source for dependency zk_evm
Caused by:
Unable to update https://github.com/matter-labs/era-zk_evm.git?branch=main#ca203a25
Caused by:
object not found - no match for id (ca203a25cbff50ad623630e393dd041aca58038d); class=Odb (9); code=NotFound (-3)

I also have this questions:
Any update for the team?
error: failed to get zk_evm as a dependency of package zksync_types v1.0.0 (https://github.com/matter-labs/zksync-era.git#44b265bd)
... which satisfies git dependency zksync_types (locked to 1.0.0) of package foundry-cli v0.2.0 Caused by:   failed to load source for dependency zk_evm`
Caused by:
Unable to update https://github.com/matter-labs/era-zk_evm.git?branch=main#ca203a25
Caused by:
object not found - no match for id (ca203a25cbff50ad623630e393dd041aca58038d); class=Odb (9); code=NotFound (-3)

Thanks for the report. #101 should fix it.


Added ingress.class now required by Nginx Ingress Controller

Since v1.0.0 Nginx Ingress Controller, it now requires ingress.class to be specified on Ingresses definitions.
This PR adds this notation to all ingress definitions for the different Sitecore versions & Topologies.
More details here: https://robearlam.com/blog/nginx-ingress-breaking-change-ingress.class-now-required

@robearlam We are able to close this PR. I have confirmed that this issue has been resolved by the following release.
https://github.com/Sitecore/container-deployment/releases/tag/sxp%2F<IP_ADDRESS>577.652


Error when submitting test form

See https://www.opentech.fund/about/jobs/test-form/
Tested with both logged in and unlogged in account.
Forbidden (403)
CSRF verification failed. Request aborted.
You are seeing this message because this site requires a CSRF cookie when submitting forms. This cookie is required for security reasons, to ensure that your browser is not being hijacked by third parties.
If you have configured your browser to disable cookies, please re-enable them, at least for this site, or for 'same-origin' requests.
More information is available with DEBUG=True.

This was due to Cloudflare cache everything rule.


Use tempconfig for every scene render

Overview: What does this pull request change?

Fixes #2470 and Fixes #2307

Motivation and Explanation: Why and how do your changes improve the library?

Rendering the last frame changes the config.save_last_frame to True globally. And this gets propagatted when rendering other classes within the same script. Using a tempconfig for each scene render solves the problem.
Changes cloup.command to click.command:
both are same but cloup has support for @constraint which we don't use anyway. It also stops pyright from complaining that command is not exported from cloup.
See janluke's review comment below.
Extends the -a flag test to accomodate classes which contain both images and videos
Further Information and Comments
The tests will fail because of how file logging is setup (directly from _config.utils).
I have tested this on #2546 and the tests pass there. So, this PR needs to be merged after that one.

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Converted to draft, feel free to unconvert once tests pass.

Well, I already mentioned why the tests would fail

Well, I already mentioned why the tests would fail

We could unconvert after that PR is merged then

Changes cloup.command to click.command:
both are same but cloup has support for @constraint which we don't use anyway. It also stops pyright from complaining that command is not exported from cloup.

Cloup provides support to option groups, which is the reason it was used in the first place. click.command won't fail, but you won't have separate help sections for different groups.
I see Manim is still using Cloup v0.7.1 when latest version is v0.13.0. Consider upgrading and making use of new features.

Converted to draft, feel free to unconvert once tests pass.

@Darylgolden All tests pass now ^^

Just undraft it when it's ready for review again


complew eigen tridiag.jl +int32 friendly

Codecov Report

Merging #58 (7792643) into main (1413db2) will increase coverage by 0.80%.
The diff coverage is 73.43%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   74.60%   75.41%   +0.80%
==========================================
  Files           8        8
  Lines        1024     1021       -3
==========================================
+ Hits          764      770       +6
+ Misses        260      251       -9

Impacted Files
Coverage Δ

src/cholesky.jl
95.00% <ø> (-0.46%)
:arrow_down:

src/tridiag.jl
67.37% <71.18%> (+2.96%)
:arrow_up:

src/skewhermitian.jl
80.83% <100.00%> (+0.03%)
:arrow_up:

src/pfaffian.jl
85.71% <0.00%> (-3.18%)
:arrow_down:

src/skewsymmetricmv.jl
0.00% <0.00%> (ø)

src/exp.jl
80.12% <0.00%> (+0.23%)
:arrow_up:

src/eigen.jl
88.70% <0.00%> (+2.45%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ft-csv.txt - corrected spelling log which should be lot

ft-csv.txt under 4.13 contains the sentenc:
This should make loading huge csv files a log faster.
This pull request changes "log" to "lot".
Thank you.

thanks. Can you please check, if this also applies to the README.md?

Ok, I added a second commit to this pull request which adds the correction to the README.md file as well.

thank you!


Upgrade createrepo_c to 1.0.3

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Upgrade createrepo_c to 1.0.3
Change Log

NA

Does this affect the toolchain?

YES
Associated issues

NA

Links to CVEs

NA

Test Methodology

Full toolchain build results are here

LGTM

Thanks for the review.

I have once again ran the full toolchain build. Still looking good. Here are the results.


RxJava Sample

Hello, I made a little but pretty neat wrapper around FeatureSpec that allows to test rxjava Observable (and as such networking or pretty much everything).
Would you be interesting if I contribute it as a sample project?

Very nice!
I'm just thinking about how we could handle such contributions. What do you think about adding a section to the documentation where we can collect links and descriptions of such sample projects?

I was thinking about a simple samples/rxjava directory inside the repository :)


[AMBARI-23035] HDFS Balancer via Ambari fails when FIPS mode is activated on the OS

What changes were proposed in this pull request?
This is similar issue as reported on AMBARI-22417, but for service checks.
ValueError: error:060800A3:digital envelope routines:EVP_DigestInit_ex:disabled for fips

The original issue of ambari check is resolved. But the same issue is seen when running the HDFS balancer via Ambari.
Solution
MD5 is disabled on the OS, Code needs to be updated to use SHA
This is required when FIPS mode is enabled on the RHEL OS
How was this patch tested?
Manually tested in cluster, ran unit tests:
Total run:1051
Total errors:0
Total failures:0
OK

Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/714/
Test PASSed.


Feature request: Add EventHandler for triggering asynchronous execution

Use case
I would like to use monolithic Lambda as a mechanism to build asynchronous execution Lambda Functions.
Python Runtime's SnapStart charges a cache fee for each version of the Lambda Function.
I believe that reducing the number of Lambda Functions created by Monolithic Lambda would be a useful cost saving measure.
While it is easy to build monolithic Lambda with API Gateway's backend Lambda because of EventHandler, it is not easy to build monolithic Lambda for asynchronous Lambda execution.
I would like to create a new EventHandler to facilitate this.
Solution/User Experience
app = AsynchronousTriggerResolver()

@app.sns("<String to identify>")
def process_sns_01():
    pass

@app.sns("<String to identify>")
def process_sns_02():
    pass

@app.event_bridge("<String to identify>")
def process_event_bridge():
    pass

@app.cloudwatch_logs("<String to identify>")
def process_cloudwatch_logs():
    pass

def lambda_handler(event, context):
    return app.resolve(event, context)

I am thinking that it would be good if we could use it like an EventHandler for API Gateway.
Alternative solutions

Acknowledgment

[x] This feature request meets Powertools for AWS Lambda (Python) Tenets
[ ] Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

Hi @sinofseven Sorry for the super super late reply, but things are a bit slower at the end of the year because we are presenting at re:Invent, we need to deal with some internal stuff and most people are going on annual leave.
Regarding this issue, I can say that I really like the idea and we are discussing it in our roadmap for 2025. This could be a generic event handler for many services: S3, StepFunctions, EventBridge, SQS, SNS and we can decide which part of the event we can use as a route, regular expressions, part of the string, many possibilities. This will make life easier for people who are dealing with EventBridge for example and want to use a single Lambda for some events. I see a lot of benefits in this new utility and it would be cool to release it in 2025.
Do you want to create an RFC for this? Ideas? Prototyping?

@leandrodamascena
Thank you, your reply.

Do you want to create an RFC for this? Ideas? Prototyping?
Currently, I have only ideas.

I was waiting for it to be triaged according to “Contributing via Pull Requests” in CONTRIBUTION.md.
Now that it has been triaged, I am thinking of implementing a prototype.
My idea is to create an EventHandler for asynchronous Lambda triggers.
Since the current EventHandler is divided into one for REST API, one for HTTP API, and one for AppSync, I think it would be better to create an EventHandler for each type of Lambda execution (synchronous, asynchronous, event source mapping). I think it would be a good idea.
(For synchronous execution, I think it would be better to create one for each service such as API Gateway, AppSync, StepFunctions, Cognito, etc.)
(For event source mapping, I am wondering if it is better to use EventHandler for Lambda for asynchronous execution, or if I should create a separate EventHandler.)

In addition, the prototype implementation assumes asynchronous Lambda event sources whose types are defined in data_classes.

I have not yet been able to verify the operation or create a test, but I have implemented it and created a PR.


afterInit fires for every item in an array when one item is added

Another issue, could just be with models without a collection:
const Comment = Class.create({
  [...]
  events: {
    afterInit({ currentTarget: doc }) {
      console.log('are we looping through all comments?!', doc.content);
      if (!doc._id) doc._id = Random.id();
      if (!doc.createdAt) doc.createdAt = new Date();
      doc.likeCount = doc.likedBy.length;
    },
  },

When I push comments into an attachment and save it, I can see the afterInit is firing for items that were already initialized and saved.

Hmm.. never mind! I think I have a misunderstanding of afterInit. It's probably invoked every time an Astronomy model is populated, even if it's existing data.


Update README.markdown

Sorry to nitpick, but should we specify that this is only necessary if using the PivotalCoreKit+Foundation project?


[STORM-2677] consider all sampled tuples which took greater than 0 ms processing time

Set delta to -1 , so that time delay for tuples that aren't sampled will not be added in BoltExecutorStats.
This is a followup PR of  https://github.com/apache/storm/pull/2185 to fix in  1.x version

retest this

The failure looks unrelated.
+1

Btw it is clearly a bug, but in opposite to STORM-2613, because both nil and 0 are logically false. So it doesn't include tuples which are not sampled, but it also doesn't include tuples which are done in 0 ms. Less harmful but still affects the overall latency.
@vinodkc
I guess we need to file different issue for this, since the bug is affecting differently. Could you please follow up? Thanks in advance!

@HeartSaVioR
Sure, filed a new issue STORM-2677.
Can you please change the status of STORM-2613.

@vinodkc
OK. Please squash commits into one with changing commit title corresponding to STORM-2677. Please also change PR title as well.

@vinodkc Thanks for changing the PR title. Could you change commit title as well?

@HeartSaVioR , Thanks for the review comments.
I've changed commit title

@vinodkc I merged this with some modification (commit title) but auto-close didn't work because it is pointing to non master branch. Could you close this? Thanks again for contribution!

Thanks.


Add an option of 'Always select Default directory'

Add an option for user to always select default saving directory and not choosing a custom one everytime.

If you specify a default save path in settings, you can simply select that instead of choosing a custom directory.

Yeah i know that. I just don't want to select that default path each time so it can work like Scrambled Exif.

Scrambled Exif is a fundamentally different app. I don't think the time saved is worth the cost of development at this point.

Ok but you can atleast reopen this issue so that you can address it later if you want.


Membership trait changes to support PoS

Reference meeting notes

[ ] HotShot clones the Membership object when receiving it, wrapping it in Arc<RwLock<>>
[ ] Remove requirement for Membership to implement Clone
[ ] Add sync_l1 and add_epoch_root functions, which return an Option<FnOnce(&mut Membership)> or similar. Functions should be called with a read lock held, then upgrade to write lock if a callback is returned. Default implementations should return None. A static helper function can be used to indicate if each function should be called at all.
[ ] Convert the existing Membership methods to async
[ ] Audit existing code to avoid Membership calls while holding other locks

Convert the existing Membership methods to async

@pls148 I think this is not needed anymore.


Instructions incomplete

Under "Add a reference" on this page, you say "In Solution Explorer, right-click on the References or Dependencies node ...".
Where do I find the 'References or Dependencies node'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 55284369-f16f-2748-2a55-8cd24a06b940
Version Independent ID: f7b0c577-b584-98dc-90a2-4efcf095b35d
Content: Add references in the Reference Manager - Visual Studio
Content Source: docs/ide/how-to-add-or-remove-references-by-using-the-reference-manager.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@JN-LT -- thank you for your question.  The sentence is referring to two distinct nodes, one named References and one named Dependencies.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

@WilliamAntonRohm Since neither References nor Dependencies appears anywhere in the Solution Explorer panel, I don't see how this answers my question.

@JN-LT -- thank you for clarifying.  Please try these resources:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

As well, you might also consider using the Report a Problem tool to report the issue.


Caching framework? [discussion, v3]

To prevent recalculating the Linenumbering / Diff with each iteration, we need a cache. In Angular 2, we used https://docs.angularjs.org/api/ng/type/$cacheFactory.Cache .
Is the linenumbering / diff the only component in need of this? If so, a simple hash object stored in memory should be enough. If we need a more general and flexible solution, we might want to use a module like https://github.com/fulls1z3/ngx-cache or https://github.com/jmdobry/angular-cache .

Currently we use https://www.npmjs.com/package/@ngx-pwa/local-storage. It's asynchron but uses indexed db. Also we have a cache service wrapping this API (it has an internal queue, because if you set an item too fast, that the previous set-operation is not finished, you get an error). Currently used to cache the whole data store.

I don't think caching will be needed. Virtual scrolling should be fast enough :tm: to handle the list of amendments. I was planing to alter the concept of amendments a little to store the linenumbers and diff-lines, that should prevent unnecessary recalculation.


Delete media in media library not cascade delete the folder

when MEDIA_LIBRARY_CASCADE_DELETE=true
Delete the media from media library will delete the file itself, but not the folder containing it.
Testing it locally with Glide.

Hi @yanhaoli, thanks for reporting this. The problem here is that the folder might not necessarily be empty after the file itself is deleted because there might be multiple files in the same uuid folder if multiple files were uploaded at the same time. We need to add a check for emptiness of the uuid folder when deleting the file and if empty we can then delete it. I think this might cause issues with S3 though so would need some testing there because S3 doesn't actually store folders being block storage. Hopefully this is something Flysystem already deals with.

It seems like we would need to make sure to include a trailing slash with the uuid for S3 to delete it, which would work as long as it is empty.
See https://github.com/aws/aws-sdk-php/issues/1553#issuecomment-390264492

Fixed in https://github.com/area17/twill/pull/1579


attempt to fix unstable test

Scope & Purpose
Attempt to fix the following unstable integration test:
=== server_parameters ===
* Test "server_parameters" [FAILED]  tests/js/client/server_parameters/auto-refill-index-caches-on-modify-noncluster-on.js

      "testUpdateEdgeDisbled" failed: Error: at assertion #5003: {
  "writesExecuted" : 0, "writesIgnored" : 0, "scannedFull" : 0, "scannedIndex" : 5000, "cursorsCreated" : 1, "cursorsRearmed" : 4999, "cacheHits" : 1147, "cacheMisses" : 3853, "filtered" : 0, "httpRequests" : 0, "executionTime" : 0.02600592700036941, "peakMemoryUsage" : 98304 }: (1147) is not equal to (0)
(Error
    at assertEqual (/work/ArangoDB/js/common/modules/jsunity/jsunity.js:108:19)
    at runCheck (tests/js/client/server_parameters/auto-refill-index-caches-on-modify-noncluster-on.js:64:7)
    at Object.testUpdateEdgeDisbled (tests/js/client/server_parameters/auto-refill-index-caches-on-modify-noncluster-on.js:151:7)
    at Object.run (/work/ArangoDB/js/common/modules/jsunity/jsunity.js:552:27)

Test-only bugfix. Intentionally no CHANGELOG entry written for it.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.10: https://github.com/arangodb/arangodb/pull/17931
[ ] Backport for 3.9: -
[ ] Backport for 3.8: -

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

It looks like waitForMetrics() needs after every query here.
For an example
    testUpdateEdgeEnabled: function() {
      db._query(`FOR i IN 0..${n - 1} INSERT {_from: CONCAT('v/test', i), _to: CONCAT('v/test', (i % 25))} INTO ${cn}`);
      waitForMetrics();

      const oldValue = getMetric("rocksdb_cache_auto_refill_loaded_total");
      db._query(`FOR doc IN ${cn} UPDATE doc WITH {value: doc.value + 1} INTO ${cn}`);
      const newValue = getMetric("rocksdb_cache_auto_refill_loaded_total");
      assertTrue(newValue - oldValue >= 2 * n, { oldValue, newValue });
      waitForMetrics();
      runCheck(true);
    }

looks incorrect, probably should be
    testUpdateEdgeEnabled: function() {
      db._query(`FOR i IN 0..${n - 1} INSERT {_from: CONCAT('v/test', i), _to: CONCAT('v/test', (i % 25))} INTO ${cn}`);
      waitForMetrics();
      const oldValue = getMetric("rocksdb_cache_auto_refill_loaded_total");

      db._query(`FOR doc IN ${cn} UPDATE doc WITH {value: doc.value + 1} INTO ${cn}`);
      waitForMetrics();
      const newValue = getMetric("rocksdb_cache_auto_refill_loaded_total");

      assertTrue(newValue - oldValue >= 2 * n, { oldValue, newValue });
      runCheck(true);
    }

I don't get the example here. In the original code you used as an example, there is already a waitForMetrics() call after the UPDATE query. It does not follow the db._query() directly, but follows the getMetric() call, however, it is there already.

it is there already
@jsteemann
Yes, my claim it's is strange to call waitForMetrics after call get metrics

it is there already

@jsteemann
Yes, my claim it's is strange to call waitForMetrics after call get metrics

Despite the function names, the two shouldn't depend on each other, so their order should not matter.

Despite the function names, the two shouldn't depend on each other, so their order should not matter.

Ok but maybe it will be more clear?
Anyway is true for all tests with same issue?
Btw I still don't understand why do you need call waitForMetrics before first get metrics, and don't need for second

Despite the function names, the two shouldn't depend on each other, so their order should not matter.

Ok but maybe it will be more clear? Anyway is true for all tests with same issue?
Btw I still don't understand why do you need call waitForMetrics before first get metrics, and don't need for second

I will add some comments to the tests now...


Prepare documentation for translation

We should look into setting up https://www.sphinx-doc.org/en/master/usage/advanced/intl.html and document the steps required for adding translations.

Since I'm in Software Internationalization class in my university, I would like to help with this. Could help me with studies :)

I am assigning you @JPTIZ

I also want to help with this issue. I can manage servers and software things if you want (even though you may be more qualified to do this than me). I've looked around and found Pootle software that made possible community translation (without spending a penny). What do you think of this ? Do you have other plans ?

I don't think we have decided upon what tools or frameworks we will use.
Could you please write a short blurb of why we should use Pootle instead of any other tools?
I suggest @MysaaJava and @JPTIZ work in tandem over discord :)

Thanks a lot for the assign (and the help wish)!
@leotrs Okay :) Just joined the discord server.

Pootle is only an interface for the translation. It is not part of the source code. It is sphynx that will manage the translated docs, pootle will only be a web UI for translating .pot files (untranslated) to .po files (translated in one language).
Why pootle ? Because it is free unlike many translation interfaces, and it is the one that sphynx proposes on its Documentation about translation.
The workflow is described on the page, through this drawing
Again, there is no need for choosing another framework as sphinx already supports internationalization. We only need to setup a web UI in order to make the translating process easier for community translators.
(JPITZ what is your discord name ?)

(JPITZ what is your discord name ?)

Just renamed myself to jptiz there to make things easier :)

Yeah, if this is what is supported and recommended by sphinx then we should use this.

Any updates on this? Eager to see the translation move forward :)

Well, i'm experimenting with the pootle server. The docs build fine with multiple languages and pootle seems to be usable.
I understood how to make translations on readTheDocs, see My clone of the docs, you can change the languages between english and french (i only translated the first paragraph into french). You can look at the internationalization branch of my personnal fork if you want to check.
The last think i have to do is to link pootle with github, so pootle will be aware of github pushes, and github aware of pootle new translations. I also need to find a host for the pootle server (i can do it, but i don't have a very stable internet connection), but i will address this issue on Discord.
Also feel free do DM or ping mi if you want updates, or have questions

Thanks a ton @MysaaJava, all your efforts do not go unnoticed. Please let us know if there's anything we need to setup on the GitHub side to keep moving this forward.
Also, the hosting for the pootle server sounds like a devops task to me #622. Cc @cobordism does the www.manim.community domain come with hosting? Or could we use github pages somehow?

Updates, we may be able to use transifex, which is a paid service, but is free for open-source projects.
I made a copy (not a fork) of manim community on which i will try to setup transifex. I also need to se if people can do anonymous translations.

Updates, we may be able to use transifex, which is a paid service, but is free for open-source projects.
I made a copy (not a fork) of manim community on which i will try to setup transifex. I also need to see if people can do anonymous translations.
I'll also write something in the docs, on the contribute page, to explain how to help with translating.

Hello ©ManimCommunity ! I'm making an update on the progress on the internationalization (i18n) thing. Please tell us what you think about how we planned to setup things. I will give you links to the dummy clones I made so you can check how it renders. If you read everything and you agree, please react with :thumbs_up: .
We are planning to use Transifex (https://www.transifex.com) to have a nice UI to make the job easier for translators. Transifex is a paid service, which offers free subscription to open-source projects (like manim). We can setup it so the translated documentation is automatically built and sent to readthedocs and github.
The website have a «reviewing» system, on which translated texts need to be validated by at least one trusted reviewer.
To submit translations, you need to create an account. This prevent anonymous users from translating, but it allows to manage roles for the team (Translator, Reviewer, Language Coordinator, Project Maintainer ,…). Furthermore, you can connect directly with you GitHub account.
How does the translation process work ?
You can call make gettext on sphinx documentation, which create .pot files, which are «ready for translation» text files. Those .pot files are sent to Transifex interface, which convert them to .po files, one for each language and .pot file. Then, you can build the docs with sphinx specifying the language and sphinx will automatically search for filled .po files.
Two questions for you
First, Transifex offers two way of sending the translated po files to github: The first one is by making PRs, the second is by commiting directly.
The problem with PRs, is that it creates a loooooot of PRs (one for each translated files). Commiting directly seems great but it is still a lot of updates on the main branch. So I present three solutions.
1 -> A lot of PRs to master, you have to accept them all
2 -> Commiting directly to master
3 -> Commiting directly to another branch (i18n), this branch can be on my personnal fork if you don't want to pollute the main repository. And every n days (for example one week before each release), i will make a PR for merging everything that has been translated so far.
Another problem is that, when you modify the docs, you have to update the .pot files, so Transifex knows about the new translations. I will make a make i18n command to do it more quickly. I think i will make a test (like black) that blocks merging if the command has not been run. I can also setup git hooks, like EulerTour proposed in #589, so it is run automatically. And finally, I think that make html should also build the .pot files, (it doesn't make the build process longer).
4 -> Another solution would be that no one runs the make i18n command (so transifex is not synchronized with github), and I will manually update the .pot files every month. What do you think ?
We will also write a section under «Contributing» in the docs, showing how to help with translating the docs. We will also check that all the text in the docs is actually exported and translatable.
We will also try to make the docs build process as fast as possible (for now, exporting PO files renders every manim video, which is useless).
The transifex organisation: https://www.transifex.com/manim-community/
My github fork's branch: https://github.com/MysaaJava/manim/tree/i18n
The documentation:
en -> https://manimdummyforintl.readthedocs.io/en/latest/
fr -> https://manimdummyforintl.readthedocs.io/fr/latest/
Thanks for reading !
This post will be send on both Github and Discord, feel free to answer with the one you prefer, and don't bother pinging me !

Just a quick update from the Discord discussion: I believe we should have some kind of procedure that allowed us to mark certain documents as "ready for translation". Since the codebase is undergoing major changes continuously, we don't want to have the translators do some work that will have to be scrapped if a major change occurs. This raises the question of priorities. I believe we should try to have the installation and basic tutorials always up to date, and start translating those. The docstrings and reference manual can wait until the library reaches a more stable state.
@MysaaJava is there a way to "mark" certain documents as "ready"? Perhaps we may go as far as generating .po files only for those documents marked as ready?
Thanks @MysaaJava @JPTIZ for all the hard work here.

Well, the simplest way i found to avoid everyone from having to update .po files by hand is to generate them every month by hand (of course, i will make script to automate the process).
How will my script work: it will first use sphinx to generate all the po files. Then, i will filter out strings that are not translatable (for example Class names). I'll do a script with sed/awk/regexes. Then in this process, i can easily filter parts that are not ready. I suggest three ways of doing that:

adding a WIP text in every paragraph when the text is not ready for translation.
Have a ready_for_intl.list file that lists the files that are ready, and we can mark files to be ready here.
Put a special character sequence in ready paragraphs, So the script detects when the text is ready. But i don't know if it is possible.

Which is better ? Also, if you have other ideas, feel free to propose.

I like the second one, maintaining a curated list of documents/paragraphs that are ready.


Fixed bug where 'Segment doesn't have any more events exception' was …

…throw when attempting to resume from a cusor pointed at a segment that had no more events, and newer segments exist in the Change Feed.
Resolves https://github.com/Azure/azure-sdk-for-net/issues/15831

@gapra-msft @xiafu-msft, can you see if Java and Python have this bug?

@gapra-msft @xiafu-msft, can you see if Java and Python have this bug?

Java shouldn't have this bug since everything is reactive. The segment with no events would just return Flux.empty() in this situation.


[SPARK-28421][ML] SparseVector.apply performance optimization

What changes were proposed in this pull request?
optimize the SparseVector.apply by avoiding internal conversion
Since the speed up is significant (2.5X ~ 5X), and this method is widely used in ml, I suggest back porting.

size
nnz
apply(old)
apply2(new impl)
apply3(new impl with extra range check)

10000000
100
75294
12208
18682

10000000
10000
75616
23132
32932

10000000
1000000
92949
42529
48821

How was this patch tested?
existing tests
using following code to test performance (here the new impl is named apply2, and another impl with extra range check is named apply3):
import scala.util.Random
import org.apache.spark.ml.linalg._

val size = 10000000
for (nnz <- Seq(100, 10000, 1000000)) {
	val rng = new Random(123)
	val indices = Array.fill(nnz + nnz)(rng.nextInt.abs % size).distinct.take(nnz).sorted
	val values = Array.fill(nnz)(rng.nextDouble)
	val vec = Vectors.sparse(size, indices, values).toSparse

	val tic1 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec(i); i+=1} };
	val toc1 = System.currentTimeMillis;

	val tic2 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec.apply2(i); i+=1} };
	val toc2 = System.currentTimeMillis;

	val tic3 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec.apply3(i); i+=1} };
	val toc3 = System.currentTimeMillis;

	println((size, nnz, toc1 - tic1, toc2 - tic2, toc3 - tic3))
}

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12903/
Test PASSed.

Test build #107784 has started for PR 25178 at commit 1484602.

Test build #107784 has finished for PR 25178 at commit 1484602.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107784/
Test PASSed.

Retest this please.

Test build #108024 has started for PR 25178 at commit 1484602.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13132/
Test PASSed.

Test build #108024 has finished for PR 25178 at commit 1484602.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108024/
Test PASSed.

I added the extra range check just because in breeze.collection.mutable.SparseArray, the findOffset function does this and comments special case for end of list - this is a big win for growing sparse arrays
@srowen @dongjoon-hyun  @kiszk  I will do anothe simple test to find whether the extra range chek helps.

I test the perf among current impl (apply) , direct binary-search (apply2), binary-seach with extra range check (apply3)
  def apply2(i: Int): Double = {
    if (i < 0 || i >= size) {
      throw new IndexOutOfBoundsException(s"Index $i out of bounds [0, $size)")
    }

    val j = util.Arrays.binarySearch(indices, i)
    if (j < 0) 0.0 else values(j)
  }

  def apply3(i: Int): Double = {
    if (i < 0 || i >= size) {
      throw new IndexOutOfBoundsException(s"Index $i out of bounds [0, $size)")
    }

    if (indices.isEmpty || i < indices(0) || i > indices(indices.length - 1)) {
      0.0
    } else {
      val j = util.Arrays.binarySearch(indices, i)
      if (j < 0) 0.0 else values(j)
    }
  }

the test suite is similar with the above one
import scala.util.Random
import org.apache.spark.ml.linalg._

val size = 10000000
for (nnz <- Seq(100, 10000, 1000000)) {
	val rng = new Random(123)
	val indices = Array.fill(nnz + nnz)(rng.nextInt.abs % size).distinct.sorted.take(nnz)
	val values = Array.fill(nnz)(rng.nextDouble)
	val vec = Vectors.sparse(size, indices, values).toSparse

	val tic1 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec(i); i+=1} };
	val toc1 = System.currentTimeMillis;

	val tic2 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec.apply2(i); i+=1} };
	val toc2 = System.currentTimeMillis;

	val tic3 = System.currentTimeMillis;
	(0 until 100).foreach{ round => var i = 0; var sum = 0.0; while(i < size) {sum+=vec.apply3(i); i+=1} };
	val toc3 = System.currentTimeMillis;

	println((size, nnz, toc1 - tic1, toc2 - tic2, toc3 - tic3))
}

size
nnz
apply(old)
apply2
apply3

10000000
100
75294
13744
15318

10000000
10000
75616
33543
21112

10000000
1000000
92949
52483
34215

The apply2 here is faster only if nnz is 100 in the suite, I guess that that is because the seach complexity is realy small and the cost of extra two range check  can not be ignored.
But when nnz is relative a greater number (however still small), apply3 is faster than apply2. I guess that is due to avoid calling Arrays.binarySearch, Arrays.binarySearch do not check the range internally and still perferm log(nnz) check even if the input key is out of range.
In sum, I tend to keep current pr with extra range check.

The expected cost without range check is E(cost(apply2)) = log(NNZ);
while the one with range check is E(cost(apply3)) = 2 + P(key in range)*log(NNZ);
The diff is E(cost(apply3) - cost(apply2)) = 2 - P(key out of range) * log(NNZ), so the optimization is high related to the key distribution and the NNZ.
The above suite suppose the input key is from an uniform distribution. And show that, if the NNZ is small, range check will cost extra 10% cost; otherwise, the range check will save about 50% cost.

Test build #108034 has started for PR 25178 at commit 99dfe7e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13142/
Test PASSed.

Test build #108034 has finished for PR 25178 at commit 99dfe7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108034/
Test PASSed.

LGTM

Merged to master

@srowen  How about backporting it to 2.X?

I'm OK with it. It should be a pretty safe optimization.

Hm, I can't seem to back-port a merged PR with the merge script right now. I've seen this before. @dongjoon-hyun are you seeing problems like "not mergeable in its current form" if you try the merge script on this one again to backport it?

Yes, @srowen . I thought it's the current behavior of our script.
For later backporting, I did manual cherry-picking always.

OK, also manually merged to 2.4 in https://github.com/apache/spark/commit/a285c0d4fe071ceed05d8ea693febfbac5962d64

Thank you, @srowen !


Layout animation + MapView

Is it possible to use Layout Animation with MapView? For example to animate height of map, but using native animations.

@rahmanmarija if you use MapView.Animated, then I guess yes.

@kytwb No one answers a question better or faster than a collaborator. I stumbled on this right now while looking for a way to disable the animation in MapView. Any help?

@jerryheir The question is not related to react-native-maps. It's related to React Native's own Animated usage. I invited the person to open a thread on StackOverflow not to pollute the repository issues with questions unrelated to the module.

disable the animation in MapView

This is different from what the original poster asked and I'm not sure what animation you are making reference to. Looking at the MapView documentation and doing a quick CTRL+F on animation, I found setCamera:

Like animateCamera, but sets the new view instantly, without an animation.

Hope that helps.


Documentation required for Pulsar Proxy and TLS changes

Need to add documentation for the flags added during Pulsar Proxy changes and TLS changes:-
https://github.com/apache/incubator-pulsar/pull/1225
#1208
#1169
#1168
#1002

@jai1 are you working on this?

Broke this down into more digestible issues:
#1225 -> #2402
#1208 -> #2403
#1169 -> #2404
#1168 -> Already there in http://pulsar.apache.org/docs/en/security-authorization/#proxy-roles
#1002 -> #2405


BUG TUF invalid key when running Scorecard Github Action

Description
Version: 2.0.3
The action crashes with the error 2022/10/28 13:59:29 error signing scorecard json results: error signing payload: getting key from Fulcio: verifying SCT: updating local metadata and targets: error updating to TUF remote mirror: tuf: invalid key
I've tested in one repo to upgrade the scorecard-action to 2.0.6 and the error didn't happened anymore. Don't know if the error is just random or if it was really solved on the latest release.
It seems to be related to the error https://github.com/sigstore/cosign/issues/2390.
Examples
https://github.com/dmlc/xgboost/pull/8263#issuecomment-1294613038
https://github.com/cert-manager/cert-manager/actions/runs/3345975741

+1
This went away when I changed to publish_results: false even though the comment says the value is ignored for private repos (seems like it isn't).

Described and fixed in https://github.com/ossf/scorecard-action/issues/997 (release 2.0.6)

Described and fixed in https://github.com/ossf/scorecard-action/issues/997 (release 2.0.6)


Env Doesn't Override Pipeline Variables

Agent Version and Platform
Version of your agent? 2.173.0
OS of the machine running the agent? Hosted Ubuntu16
Azure DevOps Type and Version
dev.azure.com
What's not working?
For the following pipeline:
variables:
  foo: bar

steps:
- script: echo $FOO
- script: echo $FOO
  env:
    FOO: baz

I expect to see bar then baz, but I actually see bar twice. How can I "overwrite" a variable for a particular step?

@jabberwik you can overwrite globally defined variable on stage on job level, but it seems to be impossible at the moment to overwrite it using env.
Does ovewriting it at stage on job level work for you?

@jabberwik do you have any updates?

Imagine several steps in a row that need the same environment variable, and then one of them needs a different value. I can work around it with different variable names; it just makes the pipeline more verbose. It seems like unexpected behavior because the "closest" definition does not win.

@jabberwik looks like it's more related to how yaml is being proceed - since this repo is for pipeline tasks, could you please create a ticket on https://developercommunity.visualstudio.com/ to get right eyes on it?

@jabberwik let me close this since this issue doesn't seem to be related to agent itself - please feel free to ping if you have any questions.


Fixinc

Fix NoPrimary.fcl  Update scripts for generating NoPrimary and NoPrimaryPBISequence.  replace brownd with mu2e when generating scripts.

Hi @brownd1978,
You have proposed changes to files in these packages:

Scripts
JobConfig

which require these tests: build.
@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.
:hourglass: The following tests have been triggered for 72feb51c4ef3cd853ca1f6ef3c926ec8ae42e943: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The build tests passed at 72feb51c4ef3cd853ca1f6ef3c926ec8ae42e943.

Test
Result
Details

test with
:white_check_mark:
Command did not list any other PRs to include

merge
:white_check_mark:
Merged 72feb51c4ef3cd853ca1f6ef3c926ec8ae42e943 at 496bf9c5626b1dd72ddc66a0fe1768e761d3265f

build (prof)
:white_check_mark:
Log file. Build time: 11 min 01 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 72feb51c4ef3cd853ca1f6ef3c926ec8ae42e943 after being merged into the base branch at 496bf9c5626b1dd72ddc66a0fe1768e761d3265f.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.


Unmarshaller StAX API clarification

The new StAX APIs on javax.xml.bind.Unmarshaller need to specify that
START_DOCUMENT is a legal state for the XMLStreamReader or XMLEventReader
passed into the unmarshal() method.
The javadoc currently says that the methods throw IllegalStateException
for anything other than START_ELEMENT.
Environment
Operating System: All
Platform: All
URL: https://jsr222.dev.java.net/nonav/api/javax/xml/bind/Unmarshaller.html
Affected Versions
[2.0 v0.4]

javadoc contains:

This method assumes that the parser is on a START_DOCUMENT or START_ELEMENT event.


Bug 1907329: Update /manifests with default cluster profile annotation

Add option to yq to modify all documents in a single file
Updated with make release

/ok-to-test

/retest

/lgtm
/approve

/retest

/bugzilla refresh

/retest

GH actions are green, thanks! Now, we need the openshift CI 🙏

pods/openshift-cluster-version_cluster-version-operator-54bb4c667c-kncbw_cluster-version-operator.log.gz:E1214 22:16:36.916095       1 runtime.go:78] Observed a panic: &errors.errorString{s:"v1.ClusterOperator.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects \" or n, but found t, error found in #10 byte of ...|ability\":true},\"name|..., bigger context ...|ase.openshift.io/self-managed-high-availability\":true},\"name\":\"operator-lifecycle-manager\"},\"status\"|..."} (v1.ClusterOperator.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects " or n, but found t, error found in #10 byte of ...|ability":true},"name|..., bigger context ...|ase.openshift.io/self-managed-high-availability":true},"name":"operator-lifecycle-manager"},"status"|...)

It is because you are trying to set true instead of "true" so it's being treated as a boolean, not as a string, and it can't parse correctly?

/hold
no need to keep wasting CI cycles trying to parse a bool as a strong. feel free to unhold when you get CI fixed

I added the double quote. Let's see how it goes now. Thanks @eparis for spotting the error!

/retest

/retest

/test e2e-aws-olm

/lgtm
/hold cancel

/retest

/hold
CI is in trouble right now.

/retest

/retest

@guillaumerose There are a few e2e test cases that are failing consistently. Can you run those test locally to see they are passing or not?

@dinhxuanvu these failures are the same I observed in others PRs. For example, https://github.com/operator-framework/operator-lifecycle-manager/pull/1913

/retest

/retest

All green! Thanks @awgreene for fixing the CI.

/hold cancel

/hold cancel

/lgtm

/lgtm

/test e2e-aws-console-olm

/test e2e-aws-console-olm


Bootstrap 4 validation

There are a few changes to how validation feedback in forms is structured in Bootstrap 4. Any plans to support that?

None that have been discussed to my knowledge, but it’s a good discussion to have for v3.


xkbvalidate doesn't really validate model/layout very well

Describe the bug
It seems that xkbvalidate doesn't really validate the model/layout/variant/options parameters very carefully:
$ xkbvalidate dvorak dvorak dvorak dvorak ; echo $?
0

if this had validated more carefully, I would have caught this problem much sooner:
- services.xserver.layout = "dvorak";
+ services.xserver.layout = "us";
+ services.xserver.xkbVariant = "dvorak";

Expected behavior
I'd expect xkbvalidate to complain about bogus layouts.
Notify maintainers
cc @aszlig

xkbvalidate uses xkb_keymap_new_from_names to check whether the passed values are correct. It does this by checking each value one by one, so that could be a theory why it succeeds in your case.
@grahamc: I can't check this right now, but what error are you getting in your X log?

@aszlig I don't seem to be getting any error in my X log. I think I'm only running X when using GDM.


Handling of the mnt namespace seems to be done a lot nicer in oci-systemd-hook.

static int prestart(const char *rootfs,
const char *id,
int pid,
const char *mount_label,
const char **config_mounts,
unsigned config_mounts_len)
{
cleanup_close  int fd = -1;
cleanup_free   char *options = NULL;
int rc = -1;
char process_mnt_ns_fd[PATH_MAX];
snprintf(process_mnt_ns_fd, PATH_MAX, "/proc/%d/ns/mnt", pid);

fd = open(process_mnt_ns_fd, O_RDONLY);
if (fd < 0) {
	pr_perror("Failed to open mnt namespace fd %s", process_mnt_ns_fd);
	return -1;
}

/* Join the mount namespace of the target process */
if (setns(fd, 0) == -1) {
	pr_perror("Failed to setns to %s", process_mnt_ns_fd);
	return -1;
}
close(fd);
fd = -1;

/* Switch to the root directory */
if (chdir("/") == -1) {
	pr_perror("Failed to chdir");
	return -1;
}

...

made clean w/ #8 ... ok to close?


Feature Extend a property backgroundViewColor for UIStackView to set its background color

In versions below iOS 14, UIStackView is a non-rendering component, that is, the background color cannot be set through the backgroundColor property. Extend a property backgroundViewColor for UIStackView to set its background color.

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 5.0.
[x] New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger


[4.4.dev 2] ufbx importer does not find Synty textures

Tested versions
4.4.dev 2
System information
Windows 11 Vulkan Forward +
Issue description
I saw a similar report/post somewhere, but could not find it so I apologize if this is repeated somewhere.
The Synty assets that are released as their "Sources Files" contain .FBX files that reference links to Dropbox or the .psd image textures rather then the same file name with the .png extension that is actually contained in the files.
  Resource file not found: res:// (expected type: Texture2D)
  Can't open file from path 'res://Dropbox/SyntyStudios/PolygonHorrorMansion/_Working/_Textures/PolygonHorror_Texture_01.psd'.
  modules/fbx/fbx_document.cpp:1088 - FBX: Image index '1' couldn't be loaded from path: res://Dropbox/SyntyStudios/PolygonHorrorMansion/_Working/_Textures/PolygonHorror_Texture_01.psd because there was no data to load. Skipping it.
  Resource file not found: res:// (expected type: Texture2D)
  Can't open file from path 'res://_Textures/PolygonHorror_Texture_01.psd'.
  modules/fbx/fbx_document.cpp:1088 - FBX: Image index '0' couldn't be loaded from path: res://_Textures/PolygonHorror_Texture_01.psd because there was no data to load. Skipping it.
  Resource file not found: res:// (expected type: Texture2D)
  Can't open file from path 'res://PolygonShops/_Working/_Textures/PolygonShops_Walls_Texture_01.psd'.
  modules/fbx/fbx_document.cpp:1088 - FBX: Image index '1' couldn't be loaded from path: res://PolygonShops/_Working/_Textures/PolygonShops_Walls_Texture_01.psd because there was no data to load. Skipping it.
  Resource file not found: res:// (expected type: Texture2D)
  Can't open file from path 'res://_Textures/Glass.psd'.

the ufbx importer does not appear, as a fallback, to look through the filesystem and find the matching filename with other extension types that can be used in place of the ones referenced that it is unable to find.
Additionally there appears to be no way to disable the ufbx importer so that the FBXState and FBXDocument classes can be used to override and "handle" the .fbx files.
Steps to reproduce
I was importing .fbx files from their PolygonHorrorMansion Pack sourcefiles.
Minimal reproduction project (MRP)
NA

Without an MRP this isn't going to be easy to test, please upload a minimal project that replicates this problem

MRP

Due to various reasons Godot Engine does not have a psd importer.
PolygonHorror_Texture_01.psd
I personally think we should but there's not clear agreement on that so it's in limbo.
https://github.com/godotengine/godot/pull/73417

The fbx importer falls back to the engine list of texture importers so maybe if there's a psd importer at some point even as gdextension it'll work.

Hi @fire thank you for taking a look. Oddly the texture that Synty references, the PolygonHorror_Texture_01.psd file is not even included in the source files. What is included is the PolygonHorror_Texture_01.png file, which is the one that I want anyway, so there is no need to import the .psd. I’m just trying to figure out a way to “handle” the .fbx import before the ufbx does or for the ufbx importer to effectively grab the filename without the extension and find that within the file system.

I forgot the details but we store the original image path internally

At first I was using the post import script to try and get the files myself, but that of course runs after all the warning and error messages get printed, so then I attempted to create a new FBXDocument and FBXState   And run those before the ufbx imported did so that I could somehow grab the path reference that the errors were spitting out and convert them to the actual.png file that was in the project. Is there some way to accomplish this?

Back when we were doing the texture resolving code, I think I was suggesting doing automatic search by extension as well, as the code is already searching multiple folders for the right texture, so I thought attempting "file.png", "file.jpg", "file.jpeg", ... etc. to find the texture wouldn't be that bad in comparison.
I think the consensus back then was that this behavior would be too magical in comparison to searching the files from other paths, but it might be worth it to revisit the choice.

Could something like the contains() function be used?
If performance is a consideration a recursive search can be started at the folder that the mesh is contained in and work it's way up to the res:// root directory No? I was not even considering including the extension but rather just contains("PolygonHorror_Texture_01")?
If the concern is mistakenly applying an incorrect texture with the same filename (which I do think would be a rare case, and also considering this is a fallback if it can not find it using the current method) a warning can be emitted.  With this we would get a texture applied, that is more then likely the correct one and a warning letting us know. Currently however the ufbx imported emits what I think was 2 errors and a warning and no texture applied.
  Resource file not found: res:// (expected type: Texture2D)
  Can't open file from path 'res://Dropbox/SyntyStudios/PolygonHorrorMansion/_Working/_Textures/PolygonHorror_Texture_01.psd'.
  modules/fbx/fbx_document.cpp:1088 - FBX: Image index '1' couldn't be loaded from path: res://Dropbox/SyntyStudios/PolygonHorrorMansion/_Working/_Textures/PolygonHorror_Texture_01.psd because there was no data to load. Skipping it.

I'm not familiar with the creation and export process that most studios use, but I would image there are a lot of Godot users, like myself, that have quite a few Synty assets piled up from the HumbleBundles :) I also contacted Synty and asked that they would consider using gltf, which they responded that they are looking into using it for this exact reason and that the goal would be to embed the materials into the models.

If the concern is mistakenly applying an incorrect texture with the same filename (which I do think would be a rare case, and also considering this is a fallback if it can not find it using the current method) a warning can be emitted. With this we would get a texture applied

I think this was my concern, but I prefer solving real problems like yours rather than hypotheticals.


Multiple domain test from only one config

Hello,
i have 4 domains with exact same theme (ex. foo.com, foo.co.uk, foo.es, foo.de).
My Feature File Like:
@book @happy-path @foo
Feature: Search a flight
  As a customer From Istanbul To Ankara (Domestic)
  then I will see search results

  Scenario: search for a flight on foo.co.uk !!( domain should be here )!!
    Given I search from "Paris" to "Berlin" flight for "1 adult" at "next week"
    When I click on search button
    Then I should be navigated to search results

My Step Defination File:

Given(/^I search from "(.*?)" to "(.*?)" flight for "(.*?)" at "(.*?)"$/, (from, to, passengers, departureDate) => {
  I.fillSearchForm(from, to, departureDate, passengers)
})

When(/^I click on search button$/, () => {
  I.click('.search-button', '.search-form')
})

Then(/^I should be navigated to search results$/, () => {
  I.see('tanesi gösteriliyor.')
})

My Config File:
exports.config = {
  output: "./output",
  helpers: {
    Puppeteer: {
      url: "https://www.foo.co.uk",
      show: process.env.NODE_ENV === 'dev' || process.env.NODE_ENV === 'development',
      restart: false,
      windowSize: "1280x1280",
      defaultViewport: "1280x1280",
      waitForNavigation: "networkidle0",
      waitForAction: 400,
      disableScreenshots: true,
      devtools: true
    }
  },
  include: {
    I: "./steps_file.js"
  },
  mocha: {},
  bootstrap: false,
  teardown: null,
  hooks: [],
  gherkin: {
    features: "./features/*.feature",
    steps: [
      "./features/step_definitions/happy-path.js"
    ]
  },
  tests: "./features/step_definitions/*.js",
  timeout: 10000,
  name: "uat"
}

I would like to create only one config which will be run for all 4 domains. However, I need to create 4 different configs for our domains. Is there any way for me to run the same config for our 4 domains at the same time.
Thank you for your help.
Excuse my for bad english :)

You can achieve this by
codeceptjs run -o '{ "helpers": {"Puppeteer": {"url": "https://www.foo.co.uk"}}}'
codeceptjs run -o '{ "helpers": {"Puppeteer": {"url": "https://www.foo.de"}}}'

But my all domains has different language.

@PeterNgTr Thanks for helping.


Git should fully adopt new file system watcher API

Instead of doing isDescendant checks on its own.
https://github.com/microsoft/vscode/blob/c047af40b27be89e456b8703526adc1a138d563d/extensions/git/src/repository.ts#L864
//cc @joaomoreno

@joaomoreno rewrite:
What this means is that we should continue where https://github.com/microsoft/vscode/pull/140695 left off, adopt the new file watching API to scope watching to arbitrary folders. Doing that means that we have to use RelativePattern and we can afford to drop isDescendant.

This whole issue title and description confused me. This is about https://github.com/microsoft/vscode/pull/140695 not being 100% complete. There are a total of 3 calls to createFileSystemWatcher in extensions/git and that PR only touched one of them. This issue is about the other two supposedly.

I think there are in total 2 work areas:

drop any fs.watch (I think that one is done)
review every use of createFileSystemWatcher to see whether RelativePattern to scope watcher to a specific path

Thanks!
Plan of action:

Nothing to do for Model
Adopt RelativePattern in Repository, @eamodio started that in https://github.com/microsoft/vscode/pull/140792/files

Propagate that watcher to DotGitWatcher, so we can remove both watch calls
Delete the watch util

Ping. With https://github.com/microsoft/vscode/issues/146066 being fixed now, there should really be no need for node.js watching anymore nor not using relative patterns.
Can we move on here?

Updated plan based on this morning's conversation:

Merge https://github.com/microsoft/vscode/pull/140792
Reducing number of watchers used by the git extension is blocked by work that has to happen for the Parcel watcher (support glob based exclusion) as well as VS Code extension API changes to support setting up a watcher using an include/exclude list

Related watcher issues:

https://github.com/microsoft/vscode/issues/137872
https://github.com/parcel-bundler/watcher/issues/64

I can see whether watchers can become isolate, at least when created from the extension host so that the watcher created by one extension would not trigger events everywhere.

Pushed aa0cc063771f3f5ba4878f844e94b6b386f29b87 that adopts RelativePattern for the repository watcher.


Pass system-probe test packages through read-only directory

What does this PR do?
This PR shares the system-probe test packages through a read-only filesystem mounted in each KMT micro-vm.

Motivation
NPM reported an issue with the TestConntrackCompile test. The test has a high degree of flakiness in KMT.

The problem happened due to high disk usage during KMT setup, which led to high IO wait times stemming from the large number of requests the underlying host had to service. From observing IO statistics we were able to correlate the problematic operations to be the copying of system-probe test packages to the VM's filesystem.
This is illustrated in the graph below. It graphs transactions per second (tps), % cpu spent waiting on IO (iowait) and kilobytes written per second (kB_wrtn/s). We have sharp spikes in all three metrics between 450 seconds - 600 seconds.
The thick black vertical lines represent the start time for the tests which had TestConntrackCompile failures. As can be seen the failures happen when the tests start times align with the spike in IO activity, which corresponds to copying the test packages.

When we eliminate the copy of system-probe tests to the VMs by sharing these via a read-only mounted filesystem with each VM, IO activity is significantly reduced following the initial environment setup. As we can see in the graph below, the previous spike in the various metrics disappears.

Additional Notes
https://datadoghq.atlassian.net/browse/NPM-3107
https://datadoghq.atlassian.net/browse/EBPF-355

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Bug: TypeError: webpack_require.e is not a function (for target node?)

Bug: I'm using webpack to build the server using target node, but the output claims requireEnsure as undefined!
TypeError: __webpack_require__.e is not a function
The function is related to webpack requireEnsure. It makes totally sense that we don't have requireEnsure (which appends html to the DOM) on the server, but why it's requiring it?
The webpack configuration for the server is down to the following:
[2] { devtool: 'source-map',
[2]   context: '/opt/app',
[2]   resolve:
[2]    { modules: [ 'node_modules' ],
[2]      extensions: [ '.json', '.js', '.jsx', '.css', '.scss' ] },
[2]   module:
[2]    { rules:
[2]       [ { test: /\.css$/,
[2]           include: /(flexboxgrid|normalize\.css)/,
[2]           use:
[2]            [ { loader: 'css-loader/locals',
[2]                options: { modules: true, importLoaders: 2, localIdentName: '[local]' } },
[2]              { loader: 'autoprefixer-loader',
[2]                options: { browsers: 'last 2 version' } } ] },
[2]         { test: /\.jsx?$/,
[2]           exclude: /node_modules/,
[2]           use:
[2]            [ { loader: 'babel-loader',
[2]                options:
[2]                 { plugins:
[2]                    [ 'transform-runtime',
[2]                      'add-module-exports',
[2]                      'transform-decorators-legacy',
[2]                      'transform-react-display-name',
[2]                      'transform-class-properties',
[2]                      [ 'react-intl',
[2]                        { messagesDir: './build/messages/', enforceDescriptions: true } ],
[2]                      [ 'root-import',
[2]                        [ { rootPathPrefix: '~', rootPathSuffix: 'src' },
[2]                          { rootPathPrefix: '@', rootPathSuffix: 'rest' },
[2]                          { rootPathPrefix: '#', rootPathSuffix: 'src/modules' } ] ],
[2]                      'syntax-dynamic-import' ],
[2]                   presets: [ 'react', 'es2015', 'stage-0' ],
[2]                   ignore: [ 'node_modules' ] } } ] },
[2]         { test: /\.less$/,
[2]           use:
[2]            [ { loader: 'css-loader/locals',
[2]                options:
[2]                 { modules: true,
[2]                   importLoaders: 2,
[2]                   sourceMap: true,
[2]                   localIdentName: '[local]___[hash:base64:5]' } },
[2]              { loader: 'autoprefixer-loader',
[2]                options: { browsers: 'last 2 version' } },
[2]              { loader: 'less-loader',
[2]                options: { outputStyle: 'expanded', sourceMap: true } } ] },
[2]         { test: /\.scss$/,
[2]           use:
[2]            [ { loader: 'css-loader/locals',
[2]                options:
[2]                 { modules: true,
[2]                   importLoaders: 2,
[2]                   sourceMap: true,
[2]                   localIdentName: '[local]___[hash:base64:5]' } },
[2]              { loader: 'autoprefixer-loader',
[2]                options: { browsers: 'last 2 version' } },
[2]              { loader: 'sass-loader',
[2]                options: { outputStyle: 'expanded', sourceMap: true } } ] },
[2]         { test: /\.woff(\?v=\d+\.\d+\.\d+)?$/,
[2]           use:
[2]            [ { loader: 'url-loader',
[2]                options:
[2]                 { limit: 10000,
[2]                   mimetype: 'application/font-woff',
[2]                   emitFile: false } } ] },
[2]         { test: /\.woff2(\?v=\d+\.\d+\.\d+)?$/,
[2]           use:
[2]            [ { loader: 'url-loader',
[2]                options:
[2]                 { limit: 10000,
[2]                   mimetype: 'application/font-woff',
[2]                   emitFile: false } } ] },
[2]         { test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/,
[2]           use:
[2]            [ { loader: 'url-loader',
[2]                options:
[2]                 { limit: 10000,
[2]                   mimetype: 'application/octet-stream',
[2]                   emitFile: false } } ] },
[2]         { test: /\.eot(\?v=\d+\.\d+\.\d+)?$/,
[2]           use: [ { loader: 'file-loader', options: { emitFile: false } } ] },
[2]         { test: /\.svg(\?v=\d+\.\d+\.\d+)?$/,
[2]           use:
[2]            [ { loader: 'url-loader',
[2]                options:
[2]                 { limit: 10000,
[2]                   mimetype: 'application/octet-stream',
[2]                   emitFile: false } } ] },
[2]         { test: /\.(jpg|png|jpeg|gif|svg)$/,
[2]           use:
[2]            [ { loader: 'url-loader',
[2]                options: { limit: 10240, emitFile: false } } ] } ] },
[2]   plugins:
[2]    [ DefinePlugin {
[2]        definitions:
[2]         { __CLIENT__: false,
[2]           __SERVER__: true,
[2]           __DEVELOPMENT__: true,
[2]           __DEVTOOLS__: true } },
[2]      LimitChunkCountPlugin { options: { maxChunks: 1 } } ],
[2]   name: 'server',
[2]   output:
[2]    { path: '/opt/app/build/server',
[2]      libraryTarget: 'commonjs2',
[2]      filename: '[name].js',
[2]      chunkFilename: '[name].js',
[2]      pathinfo: true },
[2]   entry: { server: [ './src/server.js' ] },
[2]   target: 'node',
[2]   node: { __dirname: false, __filename: false },
[2]   externals: [ [Function] ] }

The undefined function is only mentioned once in the outputted code, but the webpackAsyncContext apparently is executed for every module.
function webpackAsyncContext(req) {
        var ids = map[req];
        if(!ids)
                return Promise.reject(new Error("Cannot find module '" + req + "'."));
        return __webpack_require__.e(ids[1]).then(function() {
                return __webpack_require__(ids[0]);
        });
};

The expected behavior
I believe that the build with target node shouldn't be trying to use requireEnsure, or maybe it is missing the libraryTarget for commonjs2. The problem is that the webpack outputted file is trying to execute __webpack_require__.e but it doesn't defined the method anywhere on the output, so it shouldn't be executing it.
My configuration is
node v.7.7.2
npm 4.1.2
webpack 2.2.0
babel-core 6.24.1
babel-loader 7.0.0

The problem seems to be related with dynamic import.
The __webpack_require__.e that doesn't exist is only been called on the modules I'm importing dynamically.
like...
async (language) => {
   // ...
   const localeData = await import('react-intl/locale-data/' + language);
   // ...
}

I'm not the only one, found a duplicated issue....
https://github.com/webpack/webpack/issues/3496

@ezsper any solution to this problem? I'm facing the same issue... (dynamic route import in react router)

Yes, I solved by cloning https://github.com/airbnb/babel-plugin-dynamic-import-node and updating the file src/index.js
Where you have
SOURCE: (t.isStringLiteral(importArgument) || t.isTemplateLiteral(importArgument))
            ? path.node.arguments
            : t.templateLiteral([t.templateElement({ raw: '', cooked: '' }), t.templateElement({ raw: '', cooked: '' }, true)], path.node.arguments),

I replaced by only
SOURCE: path.node.arguments,

That fixed the issue of the SyntaxError: Unexpected token )

If an entry point contains a dynamic import it includes the require.ensure function in the runtime chunk. If not, it doesn’t.
So if you load a chunk with an import via a link, it cannot find the require.ensure function.
https://github.com/webpack/webpack/lib/MainTemplate.js:138 <- this is where the require.ensure template is added to entry chunks.

I meet this problem again, just now...

I found this is caused by the other module imported the target module directly.
How about throw a warning about this?

I found this is caused by the other module imported the target module directly.
How about throw a warning about this?

in my case problem was that module i tried to import dynamically
 import('bpmn-js').then(m => { ... })

was also bundled in "vendors" chunk (see below), i removed vendor bundle from webpack config and it became ok.
  optimization: {
    splitChunks: {
      cacheGroups: {
        commons: {
          test: /[\\/]node_modules[\\/]/,
          name: 'vendors',
          chunks: 'all'
        }
      }
    }
  },

I encountered this error when I was adding React.lazy() to lazy load a component. Simply restarting the dev server fixed the issue for me. I believe that since I started the dev server before I added any lazy loading webpack didn't include this function it as part of the bundle.

If an entry point contains a dynamic import it includes the require.ensure function in the runtime chunk. If not, it doesn’t.
So if you load a chunk with an import via a link, it cannot find the require.ensure function.
https://github.com/webpack/webpack/lib/MainTemplate.js:138 <- this is where the require.ensure template is added to entry chunks.

@vjpr So how did you resolve it? I don't want to force a refresh the first time I navigate to page that has a dynamic import.


 This feature will be at end of service on October 17, 2023.

After that date, your builds will continue to work but we won't minify or bundle the CSS and JS, and we won't optimize images.
To remove this warning, disable asset optimization in your site configuration:
https://app.netlify.com/sites/kubernetes-io-main-staging/configuration/deploys#asset-optimization

For more details, read our forum announcement:
https://answers.netlify.com/t/please-read-deprecation-of-post-processing-asset-optimization/96657

Forum announcement link
Proposed Solution:

Implement custom optimization
Turn off asset optimization in Netlify

Additional Information:
/area web-development

/area web-development

@sftim would you like to explain a bit more so that I can start work on

assign me

/lifecycle frozen

@shivam-sharma7 you've asked to be assigned to this issue

we [SIG Docs] have a “no cookie licking” policy. I hardly ever assign people to issues because I don't think it helps. You can comment to explain the progress you plan to make.

you might need to liaise with a Netlify administrator for the site to test a fix (very few contributors have the admin access to Netlify needed to try it out). This is not a good first issue.

can I also recommend switching to a more empathic way to offer help?

The [Kubernetes] Community is open, inclusive and respectful. Every member of our community has the right to have their identity respected.
Examples of behavior that contributes to a positive environment include but are not limited to:

Demonstrating empathy and kindness toward other people
Being respectful of differing opinions, viewpoints, and experiences
Giving and gracefully accepting constructive feedback
Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
Focusing on what is best not just for us as individuals, but for the overall community
Using welcoming and inclusive language

/triage accepted

/priority important-soon

@sftim
Thank you for raising the issue. From the above discussion, it isn't clear what is the custom optimization we want to enable.
FWIW, I'm happy to tag team & help disable asset optimization on the Netlify side of things.

The flag date has passed and the sky has not fallen.
/close


Auto-gift box script

This script requires OCR (digits only).
I've found a Xamarin tesseract wrapper: https://github.com/halkar/Tesseract.Xamarin
Also, digits only trained data for tesseract is available here: https://github.com/Shreeshrii/tessdata_shreetest/blob/master/digits.traineddata
I won't be doing this anytime soon though. Doesn't feel like it is worth the effort required.

Tracking in #397

Sad research 😢


JoseUtil._validateJwt not found when minified in 1.2.2

Works in 1.2.0. (Using create-react-app build.)

I'll look into it when I can.

I also had this at one time, but it was fixed after I upgraded my webpack version. Can't remember from-to versions, but it was one of the webpack 2 betas.

I just ran into this myself... i think it has something to do with tree shaking :(
webpack 2.1.0-beta.21

@PeterHageus  Was this sorted out with an upgrade of webpack?

Others reported similar issues and upgrading webpack revolved it. I'll close for now -- if you still have the issue, feel free to reopen.


1733 make sure every plugin sort data source records by created date to avoid data lost during collection

Summary
Modified feishu and github to make sure they collect data from the earliest one.
Gitlab collect data from the earliest one by default
Does this close any open issues?
closes #1733
Current Behavior
Describe the current behaviour of this issue, if relevant.
New Behavior
Describe the new behaviour updated in this issue, if relevant.
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.

As we discussed, this is unnecessary, close it for now, feel free to reopen


[HIPIFY][perl] hipify-perl guard

Let me preface this by acknowledging that most development effort is behind hipify-clang, so I accept an answer of: "You have to use hipify-clang." 😄
I have been a happy hipify-perl user for quite a long time, as installing the CUDA SDK on my AMD targets is something I'd like to avoid. A minor issue I have is that I can have a CUDA source file that branches with something like,
#ifdef __HIP__

But if, in the #else of such a conditional , I mention a CUDA API that hipify-perl does not support, then I get a warning. Is it possible to have a guard around some code such that hipify-perl will just let it through unchanged?
I'm imagining something like clang-format's // clang-format off toggle.
Thank you for your work on hipify!

Am I right that you want to suppress warnings on the particular unsupported CUDA entities?

Yes, exactly. They are in a guarded region that switches based on if the compiler is hip or nvcc, so I am sort of manually hipify-ing that code.

So you need a preprocessing, and not for a transformation but for a suppressing of warnings. Hmm. You want more than too much from a perl script, don't you?
Preprocessing is not implemented in hipify-perl as long as macros expansion, so, yes, you need hipify-clang.


Unable to connect to Tenant

I'm try to simulate a cloud environment in my sandbox with the BC insider builds.  I am able to do so with the artifacts from the minor builds but not the next major one.
The error that pops up after logging in, is "You cannot sign in due to a technical issue. Contact your system.administrator."
It works fine, if I use a minor release
From the container event log I see the following error and the warning just before it:
Application: Microsoft.Dynamics.Nav.Server.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException
Server stack trace:
   at Microsoft.Dynamics.Nav.Cloud.Statistics.TenantStatisticsTracker.Dispose()
   at Microsoft.Dynamics.Nav.Runtime.NavEnvironment.Dispose(Boolean disposing)
   at Microsoft.Dynamics.Nav.Runtime.NavEnvironment.DisposeIfInitialized()
   at Microsoft.Dynamics.Nav.WindowsServices.NavServerWindowsService.DisposeNavEnvironment()
   at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs)
   at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink)
   at System.Runtime.Remoting.Proxies.RealProxy.EndInvokeHelper(System.Runtime.Remoting.Messaging.Message, Boolean)
   at System.Runtime.Remoting.Proxies.RemotingProxy.Invoke(System.Object, System.Runtime.Remoting.Proxies.MessageData ByRef)
   at Microsoft.Dynamics.Nav.WindowsServices.NavServerWindowsService+DisposeDelegate.EndInvoke(System.IAsyncResult)
   at System.Runtime.Remoting.Messaging.AsyncResult.SyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage)
   at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage, System.Runtime.Remoting.Messaging.IMessageSink)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
Here is the warning:
The operating system cannot run Server instance: BC
Tenant:
Environment Name:
Environment Type:
The service could not remove service principal names because the service account could not be found in Active Directory.
Account: NT AUTHORITY\SYSTEM
Service principal names:
DynamicsNAV/mycompany-cd:7045
DynamicsNAV/mycompany-cd:7045
To avoid this warning, make sure the server account is provisioned correctly (see https://go.microsoft.com/fwlink/?linkid=874634 )..
Scripts used to create container and cause the issue
attached
CreateContainer-SR365-Maj (CD) (3).txt
Full output of scripts
attached
output.txt
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

does it happen all the time? Only for major release (minor release is fine)
did it use to work? No.  This is new.

Is this problem new?
Since when did this happen?

Yes. We have been using username/Password for years and have no issues with that. But here, we are trying out AAD connection in our sandbox.

It looks like a bug in the platform / client.
For now, you will have to not use AAD for insiders until fixed


Unable to add Orderers in Consenter set

Description
I have set up a network where the configtx.yaml had initial set of 3 orderers running RAFT and 2 Peers from 1 Organization. I have CA and TLS CA setup for the organization(Peers and Orderers separately).
I wanted to simulate the addition of new organizations(Peers and Orderers) and have been successful in adding Orderers (in follower) and Peers (in Anchor Peer).
Now I am run the above for 2 organizations, i.e. 4 Orderers( 2 per Organization) and all of them are in follower mode. Now I want to upgrade the Orderers to Consenter mode and this is where I am facing the problem.
I am using the below version:
Peer: 2.4.4
Orderer: 2.4.4
CA:1.5.0
TLS_CA: 1.5.0
Steps to reproduce
I have pulled the config from an existing Consentor Orderer and updated the:
.channel_group.groups.Orderer.values.ConsensusType.value.metadata.consenters
with the $PWD/organizations/ordererOrganizations/neworderer.com/orderers/orderer0.neworderer.com/tls/server.crt
And
.channel_group.values.OrdererAddresses.value.addresses
with orderer0.neworderer.com:7050
I am signing the above with the Orderer MSP and CA_FILE and trying to update the channel and getting the below error:
Error: got unexpected status: BAD_REQUEST -- error applying config update to existing channel 'testchannel': consensus metadata update for channel config update is invalid: invalid new config metadata: consenter orderer0.neworderer.com:7050 has invalid certificate: verifying tls client cert with serial number<PHONE_NUMBER>9318936164241407242142916109441824374: x509: certificate signed by unknown authority
Please help me here.
I have also tried to sign the same pb file with all the existing 3 Consenter Orderers in the channel and still the issue is the same.

Also, I observed the logs from the Orderer container from the Orderer where the command is hit:
2023-06-13 15:12:42.254 UTC 01c8 WARN [policies] SignatureSetToValidIdentities -> De-duplicating identity [OldOrdererMSP45983616e10611fec89ad7ba5f5e72fcb7b823017667911543f9ca2202889a67] at index 1 in signature set
2023-06-13 15:12:42.254 UTC 01c9 WARN [policies] SignatureSetToValidIdentities -> De-duplicating identity [OldOrdererMSP45983616e10611fec89ad7ba5f5e72fcb7b823017667911543f9ca2202889a67] at index 2 in signature set
2023-06-13 15:12:42.254 UTC 01ca WARN [policies] SignatureSetToValidIdentities -> De-duplicating identity [OldOrdererMSP45983616e10611fec89ad7ba5f5e72fcb7b823017667911543f9ca2202889a67] at index 1 in signature set
2023-06-13 15:12:42.254 UTC 01cb WARN [policies] SignatureSetToValidIdentities -> De-duplicating identity [OldOrdererMSP45983616e10611fec89ad7ba5f5e72fcb7b823017667911543f9ca2202889a67] at index 2 in signature set
2023-06-13 15:12:42.258 UTC 01cc WARN [orderer.common.broadcast] ProcessMessage -> [channel: testchannel] Rejecting broadcast of config message from <IP_ADDRESS>:51486 because of error: error applying config update to existing channel 'testchannel': consensus metadata update for channel config update is invalid: invalid new config metadata: consenter orderer0.neworderer.com:7050 has invalid certificate: verifying tls client cert with serial number<PHONE_NUMBER>9318936164241407242142916109441824374: x509: certificate signed by unknown authority

It seems that the certificate you are trying to add is not signed by the CA that the ordering service trusts (is configured with).
In any event, this is not a bug but a user error. We reserve issues for actual bugs and development tracking, not as a help channel. Please seek help in the fabric help chat channels, email list etc... thanks for understanding.


JBPM-5010: Swimlane lose it's documentation and tests refactoring

Hi @jlindop, can you check Bpmn2JsonMarshaller refactorization? It is not using Bpmn2JsonUnmarshaller any more. If current implementation is OK I will cherry pick it to 6.4.x and then I will extend code coverage.

Thanks @hasys   This looks great, with one minor issue - in the calls to assertEquals, the 2nd & 3rd parameters are the wrong way round (the declaration is assertEquals(String message, Object expected, Object actual))

@jlindop thank you for your review. Fix sent.

Thanks
+1

master: 18276115f8fc7170eabfa4bf370af64bd45bbae3 92f916af0f277597fb194a7864410fcc3c9e1f0b


🔧 MAINT: Update path function for static asset

closes https://github.com/executablebooks/sphinx-copybutton/issues/121

closing as this first pass didn't fix it, I put some explanation here: https://github.com/executablebooks/sphinx-copybutton/issues/121#issuecomment-855441347


Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain

This PR fixes an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain, which makes the following syntax error occur:
$ cat example.rb
obj.map { |i| foo(i) }.to_h
   .bar

$ bundle exec rubocop -A example.rb --only Style/MapToHash,Layout/SingleLineBlockChain
Inspecting 1 file
F

Offenses:

example.rb:1:5: C: [Corrected] Style/MapToHash: Pass a block to to_h instead of calling map.to_h.
obj.map { |i| foo(i) }.to_h
    ^^^
example.rb:1:23: C: [Corrected] Layout/SingleLineBlockChain: Put method call on a separate line if chained to a single line block.
obj.map { |i| foo(i) }.to_h
                      ^^^^^
example.rb:3:4: F: Lint/Syntax: unexpected token tDOT
(Using Ruby 3.3 parser; configure using TargetRubyVersion parameter, under AllCops)
   .bar
   ^

1 file inspected, 3 offenses detected, 2 offenses corrected

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Another example for the false-negative of the Style/MapToHash:
hsh = [['a', '1'], ['b', '2']]
# hsh = nil

# bad
hsh&.map { |k, v| [k, v] }&.to_h

# good
hsh&.to_h { |k,v| [k, v] }

That issue is different from the intended fix of this PR, so I've opened a separate PR #12408. Thank you.


Proposal: Testing conventions

All packages should have internal testing that brings the coverage to 100% (except intentionally unreachable code).
All testing should be done using exported functions only. Furthermore, these functions should only be exported if they are intended to be used by other packages, meaning we plan to maintain support for the function calls.

Sounds good, but won't it be difficult to reach 100% only using exported functions?

hopefully not. If you can't reach certain codepaths using exported functions, then why are the codepaths there?
I'm hoping that this approach to testing encourages more critical thinking about the layout of the package and the flow of the logic. It'll be easier to know once we've given it a try.

true, I'm just guessing it will be harder to trigger certain code paths because you'll have to, e.g., line up a bunch of functions in just the right sequence. And if you want to trigger the other code path, they have to be in a slightly different sequence, so you need to start over from scratch.
I actually like this approach though. As you say, it should give us a good deal of feedback about the package design.

I'm having a hard time with this. It's not the reaching codepaths that's the problem, it's the verifying that everything changed correctly. Perhaps that's because right now the consensus package is a bit opaque to the external world.

TODO: Watch a bunch of videos about TDD to learn more, and then check back.


Train for bone

Hello!
I run this command for bone's training
 python main.py --config config/sign/train/train_bone.yaml
and it gives me this error
Traceback (most recent call last):   File "main.py", line 588, in <module>     processor = Processor(arg)   File "main.py", line 215, in __init__     self.load_data()   File "main.py", line 224, in load_data     dataset=Feeder(**self.arg.train_feeder_args),   File "/home/smilelab_slr/cvpr2021_allcode/GCN/feeders/feeder.py", line 40, in __init__     self.load_data()   File "/home/smilelab_slr/cvpr2021_allcode/GCN/feeders/feeder.py", line 59, in load_data     self.data = np.load(self.data_path, mmap_mode='r')   File "/home/smilelab_slr/SLR_pytorch/env/lib/python3.8/site-packages/numpy/lib/npyio.py", line 417, in load     fid = stack.enter_context(open(os_fspath(file), "rb")) FileNotFoundError: [Errno 2] No such file or directory: './data/sign/27_2/train_data_bone.npy'
Any help?
Many thanks
<img width="1077" alt="Screen Shot 1443-08-14 at 3 52 19 PM" src="https://user-images.githubusercontent.com/85832533/158812428-5ccdefa0-2ea3-40e4-9bde-56dca

4f507db.png">

Did you run "python gen_bone_data.py" in "data_gen/"? (SL-GCN)
If you did it, maybe the file is in other folder and you have to manually move it into ./data/sign/27_2/ folder.

thank you so much, after running python gen_bone_data.py in data_gen/, immediately the issue was solved.


logcatd bugfix + tests

If we add the ANDROID_LOG_NONBLOCK flag, subsequent reads after the first always return empty. Without the flag, the blocking read can make logcatd not exit cleanly if no messages come in. @deanlee interested in looking into this?

I'm working on it : https://github.com/commaai/openpilot/pull/19994


[devops:bot] update deps in nix/sources.json (from: rhino-core@cfb03f1

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/cfb03f1666b4a90c5398dc54ad2d03797e9418a2/nix/sources.json (branch: dev)

superseded by #129


Use the supplied contact name in SesEmailComposer

Possible fix for https://github.com/micronaut-projects/micronaut-email/issues/117

Please, the base branch of this PR should be 1.4.x. Can you change it?

@sdelamo changed the base branch and addressed your comments. Let me know if these look right