The changes to match FinCAD library results

Thanks for the proposed patch.
When submitting pull requests, it is good practice to avoid formatting changes. Right now, the PR appears to consist primarily of formatting changes, which makes it very hard to review. It would probably be best to push an additional commit (or new PR) reversing the formatting changes, so we can see the "meat" of the proposed change.

I've just pushed a new commit with the right format. This commit is a "rewrite history" type of commit, are you able to see it?

Can you please provide a comprehensive description of the changes (a bit more than the PR title) + push some unit tests ?

Closing due to inactivity.


Copying and pasting into a text element yields a new text element

Steps to reproduce:

Add text element to page
Copy text from anywhere and paste into text field
A new textfield element will be added to the page with the pasted text

Duplicate of #1953


Binding a key to multiple commands is not working

Hi Everyone,
Problem:
I configured my tmux such that when I press <prefix> + g, a new window is opened and a command is executed in the new window.
I put this into my .tmux.conf.local:
bind g new-window \; send-keys -t "$pane" 'ls -l' Enter

However, when I press <prefix> + g, tmux only opens a new window but does not execute the ls -l command.
This shortcut works without oh-my-tmux.
What I tried:

Comment out the settings set -sg repeat-time 600 and set -s escape-time 10 from .tmux/.tmux.conf
Use different keys other than g

Infos:

Ubuntu 18.04.5 LTS
Tmux 2.6
Gnome-Terminal

Has anyone gotten this to work?
Thanks!

Hello @matthias-wright 👋
Does it work with stock tmux?

Hello @matthias-wright 👋
I added it verbatim to my ~/.tmux.conf.local copy
bind g new-window \; send-keys -t "$pane" 'ls -l' Enter

and it works for me, as in "it creates a new window and executes ls -l".
However, I find the command dubious. What do you think $pane will expand to?

Asking the obvious, did you reload the configuration with prefix + r after changing your ~/.tmux.conf.local copy?

Hey @gpakosz,
Thanks for the response.
If I leave off the "$pane", the command does not work (even in my old setting without oh-my-tmux).
Yes, I tried reloading and also to create a new session altogether.
Which tmux version do you have?

I'm running tmux HEAD.
bind g new-window \; send-keys 'ls -l' Enter

works for me

I updated my tmux to version 3.1b and now it works. Thanks @gpakosz !

Great.
I let you close the issue then. Happy tmuxing


Support AWS OpenSearch Serverless

Hi, I have been trying to use the OpenSearch Vector Store together with AWS OpenSearch Serverless, however I have run into a couple of issues there. The refresh call when creating the Vector Store and adding vectors is not supported by AWS OpenSearch Serverless.

It therefore throws a 404 Error when called. I spoke with someone from AWS OpenSearch Serverless, and they told me that for AOSS the refresh call was not supported, but also not needed and could simply be removed.
Querying for Data did also not work, since the body of the request is different in AOSS:

And AOSI (AWS OpenSearch Ingestion):

I saw that AOSS is already supported in langchain python: https://github.com/langchain-ai/langchain/pull/8256
It would be a great help if you could also add AOSS support for langchain js.
Thank you in advance for any help here.

Any updates on this?


🚀 - Sharable presets

Which @codeimage/* package(s) are relevant/releated to the feature request?
codeimage, ui
Description
It would be nice to have a share presets functionality. Preferably via a url.

I have used this for school projects, to make the code much more presentable.
It is however a bit difficult get a consistent look across all code snippets when working in a group, as all group members needs to have the same preset.

It would be very nice if presets could be shared via a link. Maybe could the preset settings be embedded into the link as parameters. This avoids server side storage, and could provide a means to easily import presets between different hosted instances.

Keep up the amazing work! This is the sleekest and overall best code image generator out there.

Not sure if I have selected the most appropriate packages

Hi, thanks for reaching me 😄 This shouldn't be a problem to add this feature, I just don't have a lot of time time :/
Hope I can work on this the next days

@MidnightRocket available with 1.7.0 update

Awesome🤩 That was quick😁


AppBar size can be lost after a Navigator.pop()

Make it possible to provide an explicit PageStorage identifier.
Scaffold uses an explicit identifier to record the flexible appbar's dimensions.

Fixes #4591

LGTM but could use a test.

Doesn't have to be a test of the full gallery app.  Just a unit test that shows the problem with a parent widget that changes global keys.


Add stop event to scroller

We need a reliable method to get information about the end of deceleration process.
I added this info to the callback function so the render calback gets a 4th parameter that can either be undefined, "stop" or "stop_deceleration".

I think it would be better to pass the current velocity to the callback

BTW: Are you talking about hiding and showing indicators? In iOS this is dependend on the current velocity. If that's under a specific values indicators are hidden automatically.


re implement success message

What
Re add success message that I accidentally removed.
How to review
Sanity check
Who can review
Anyone

done elsewhere


conflict with atom-beautify plugin

unfortunately there is a styling conflict between linter-cpplin and atom-beautify. when I use them together cpplint warns me:
At least two spaces is best between code and comments [whitspace/comments]
also a screenshot

it would be great if two teams could resolve this issue!
link to the same issue reported for atom-beautify plugin

You should file this over on cpplint, then, this package is simply a wrapper around that that parses it's output.
On a personal note I've found atom-beautify to be mildly useful as a starting point for working on messy code, but I rarely agree with it's final output. In this case cpplint is designed to follow a certain style, so you are far more likely to have better luck getting atom-beautify to add an option to configure that then to get Google to change their company wide style 😛.


Import adventure loses token's Image path

After the importing of the adventure all tokens that I made lose Image path

Build 315, Version 11
Legend in the Mist ver 20

Hi! This system no longer supports v11 of Foundry. I would recommend moving to v12.
I will check one hook that deals with creation of actors and assigns token images if they do not have a predefined image however.

Afraid I cannot reproduce this. I did this:

Create a new world.
Create a character, assign it a portrait and prototype token image.
Import the Tinderbox Adventure.
Verify that the Token Image did not change.


A way to test a method that uses filemtime() providing a custom time.

I'm testing this peace of code:
/**
* Returns the last source modification time.
*
* @return int
*/
public function lastSourceModTime()
{
    return filemtime($this->source);
}

and i really need to provide a custom modification time to test functions behaviors.
Is there a way to provide a custom modification time instead of the current time() setted by vfsStream on create a virtual file???

Sure, you can do that when creating the file, e.g. with vfsStream::newFile(‘foo.txt’)->lastModified(100). Works the same way with directories. See vfsStreamWrapperFileTimesTestCase for other examples.


WIP: Refactor Heatmap to add more conditions and server side queries.

Description

Server side querying for categories, metric and advanced metrics
Add new query fields: background model and number of taxons per sample
[TODO] Adapt download and share buttons

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix a feature that knowingly causes existing functionality to not work as expected)

Test and Reproduce
Outline the steps to test or reproduce the PR here.

Impacted Areas in Application
List general components of the application that this PR will affect:
Which pages?

[ ] Login Screen
[ ] Single Upload Page
[ ] Batch Upload Page
[ ] All Projects Page
[ ] Sample Details Page
[ ] Report Page

Specific components

Testing Script:
###Login Page

Successfully login to the application and get taken to the project page

###Single Upload

Using an AWS path that doesn't exist throws an error
Succesfully uploaded files from a folder (use test host)
Uploading a duplicate file throws an error
Pipeline gets initiated successfully

###Batch Upload

Using an AWS path that doesn't exist throws an error
Succesfully uploaded files from a folder (use test host)
Navigate to batch upload settings page after upload
Host selection from previous page still selected
Uploading a duplicate file throws a warning
Pipeline gets initiated successfully

###All Project Page

Switch between projects
Search for a sample
Navigate through different pages of samples
Select Upload new sample button
Select sample to see generated report

###Sample Details Page

Information is consistent from Project Page
Notes are editable and save successfully
Can navigate to report page

###Report Page

Data loads succesfully
Collapse and Uncollapse button works
Clicking on the taxonomy name gives you total reads for that taxon
Category filter works
Genus Search works
Filters work as expected
Disabling Filters works
Filtering by column works

Checklist:

[ ] I have run through the testing script to make sure current functionality is unchanged
[ ] I have done relevant tests that prove my fix is effective or that my feature works
[ ] I have spent time testing out edge cases for my feature
[ ] I have updated the test script or pull request template if necessary
[ ] New and existing unit tests pass locally with my changes

seems reasonable so far!


revise collection save signal #82

Minor (extremely) pull request to resolve an issue in #82

Connection save signal was connected to pre-save, which caused the old name to be used in indexing related works
Revised to connect to post_save, which retains ability to determine if the name changed, and to reindex appropriately.

Codecov Report

Merging #119 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #119   +/-   ##
========================================
  Coverage    98.87%   98.87%
========================================
  Files           52       52
  Lines         2840     2840
========================================
  Hits          2808     2808
  Misses          32       32

Impacted Files
Coverage Δ

ppa/archive/tests/test_signals.py
100% <100%> (ø)
:arrow_up:

ppa/archive/signals.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a209b8...999302d. Read the comment docs.


Powershell Not Working Same As Terminal Powershell

I am trying to compile C# using the terminal in VS Code, where the terminal is set to Powershell. However, I get an error. Opening up Window's Powershell, I use the same command, and it works over there. Why is it not working here, even though it is the same command?

My VS Code is up to date.
Visual C# compiler is: 4.7.3190.0
Please let me know what I can do to fix it.

VS Code fixed itself somehow. An extension was somehow getting in the way, had to apply that fix.
Thank you for your time!


Traefik forward traffic to backends which are down

Bug Description
Traefik does not seem to do an aliveness check on the backends it is forwarding traffic to. This causes client requests to fail if a backend is down.
Perhaps charms.traefik_k8s.v2.ingress should support the requirer passing a health check url ?
To Reproduce

Deploy this bundle: https://opendev.org/openstack/charm-keystone-k8s/src/branch/main/tests/bundles/smoke.yaml
Add a keystone unit: juju add-unit keystone
Wait for unit to be ready
URL=$(juju run  keystone/leader get-admin-account | awk 'BEGIN {FS="="} /OS_AUTH_URL/ {print $NF}')
curl $URL   (repeat multiple times to check both backends are alive as traefik will round-robin the backends)
juju ssh --container keystone keystone/1 "pebble stop wsgi-keystone"
Repeat step 5 and every other request will be a bad gateway

Example output: https://paste.ubuntu.com/p/zHrmjFrQ7g/
Environment
juju 3.2.3-genericlinux-amd64
Controller in microk8s
Traefick charm: 1.0/candidate  r148
Relevant log output
2023-10-04T09:04:43.426Z [traefik] time="2023-10-04T09:04:43Z" level=debug msg="'502 Bad Gateway' caused by: dial tcp <IP_ADDRESS>:5000: connect: connection refused"
2023-10-04T09:04:44.446Z [traefik] time="2023-10-04T09:04:44Z" level=debug msg="'502 Bad Gateway' caused by: dial tcp <IP_ADDRESS>:5000: connect: connection refused"

Additional context
No response

could definitely wrap around https://doc.traefik.io/traefik/routing/services/#health-check
we'll discuss prioritization in the next backlog refinement

Path to a health check seems like a reasonable addition to the reldata schema.

@PietroPasotti We are still hitting this issue, is there any news?


Added packman user files to the .gitignore file

Packman's documentation states:

User files are created to override settings in project files in conjunction with the pull command and the import element in project file. This is useful for local experimentation, for instance when using packages built from source instead of those pulled from a packman remote.

Turns out these are super useful when testing different versions of kit other than what we currently are targeting. I'm adding the extension to the .gitignore file so we don't have to remove these when dealing with prerelease versions of packages between branches.

@weegeekps awesome, this is super useful since I'm constantly switching between kit versions.
Could you add some instructions to the developer setup guide for how to use .user files?

Where to put the .user file
An example .user file that uses a different Kit version

The example works nicely


Added TrainSetMaskTask

Codecov Report

Merging #117 into develop will increase coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
+ Coverage    75.71%   75.87%   +0.15%
===========================================
  Files           38       39       +1
  Lines         3962     3988      +26
===========================================
+ Hits          3000     3026      +26
  Misses         962      962

Impacted Files
Coverage Δ

ml_tools/eolearn/ml_tools/train_split.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1de9ff...1d05754. Read the comment docs.


 pressColor  not working

is it right?
<TabBar
  tabStyle={{backgroundColor: '#f7941e', height: 35}}
  pressColor="#000"
  labelStyle={{color: '#000', fontSize: 12}}
  {...props}
/>

when i press, the pressed color isn't black is blue.
Is my code wrong?

Hi @leoaccorsi! Your code is ok, no worries. I think you're facing this issue on iOS only if I'm not mistaken. This is because RNTB use 2 different RN touchables in <TabBar /> (as you can see here):

TouchableNativeFeedback on Android (which accepts a pressColor prop)
TouchableOpacity on iOS (which doesn't)

Thus, you just need to add pressOpcity={1} to your <TabBar /> so that you won't see the blue background on iOS. Here is a working example, feel free to re-opened this issue if needed: https://sketch.expo.io/SymWdeBhl.


cannot disable notification when app is closed

OK let me see.
Working on it..

@awukuernest483
I couldn't understand what exactly the problem is.
if you set :
.setNotificationCancelable(false)
then hiding notification is permitted until the app gets closed (Notification will be gone automatically).
please explain more detailed: OS ver , Device info ,


IotexShiba Metadata Request

Project official website: https://www.iotexshiba.io/

Project official social: https://https://t.me/iotexshiba | https://twitter.com/IoTexShiba

@zimne1 thanks for approval. This account don't have write access. Could someone from dev team complete the merge? Thanks in regards

change with 9 decimals

@zimne1 please look into this, approve and complete the merge as we don't have write access. thanks in advance.


Create a user story map for external portal

Describe the task
As we dive deeper into the work done for the user portal, creating an User Story mapping artefact can help the team stay on the same page when it comes to the bigger picture of the features we plan to have in the app.

may make sense to create a Product Roadmap as well

Acceptance Criteria

[x] Review current Miro 'Slices' board
[x] Replicate the current slices work in the User Story Mapping format
[x] Add future features to the map
[x] Review with team

Additional context

Add any other context about the task here.
Or here

@LindsayMacfarlane this ticket is ready to be closed!

Current design work has been mapped out in the user story mapping in Miro, along with some TBD features mentioned as draft
Shared with the team in Dev/Design Sync Session
Will keep updating it as we move further along in our progress of the app

Thank you for this @suhafa! It is great to see the steps that a user could take through the application.


Search via Plebnames, lookup npub in Bitcoin OP_RETURN

Summary
When I implement searching npubs via Plebnames like showcased at http://plebnames.org/?url=test would this pull request be merged?
Plebnames would provide completely decentralized, uncensorable and unique aliases for npubs. Only normal Bitcoin explorers like mempool.space or blockstream.info need to be accessed.
Basic example
When you search for a name in the top right search bar a lookup in the Bitcoin chain is made (via cors request to arbitrary Bitcoin explorers) to check if there is a Plebname with an attached Nostr npub. If there is one it appears in the search results.
Motivation
Other naming schemes are in some degree centralized and could be corrupted or attacked. Plebnames are as uncorruptible and uncensorable as Bitcoin, because they are stored in the Bitcoin chain and read via normal Bitcoin explorers. How it works is also described in the README.md of https://github.com/MichiSpebach/plebnames, it is a really simple protocol.

Also I would help with the implementation.


Add Support for Inventory Archive

I'm adding this as support for Inventory Archives (IAR files) is something that will be requested, and it is something that would be useful for open grids, where users may wish to transfer their inventory.  One of the stated goals for Halcyon was that people running desktop sandboxes would be able to sync builds to and from InWorldz (or other grids), and IAR could provide a useful medium.
Though, obviously there would need to be some checks in order to cull objects based on creator and perms (export perms in particular).  That, and perhaps it could be implemented in a way that does NOT require users to give out their plaintext password.

For Discussion: The IAR process is only one that the grid owner can use as it is a server side access only for all the stuff I have worked with. I am not sure that I would be all that interested in having people able to use that to export and import content in my world. Alternatively, FireStorm has the item backup and upload of any content which you are the creator. For my purposes I limit that by placing a price on the options to upload and create groups. Students and guests are not given any money and thus may not upload any content, group membership blocks rezzing anything or allows it if that is the intended actions granted to them. Thus while I do not have any sales or economy, I can use the money controls to manage who has access to options that would otherwise distract from the purpose of my world for school and educational development.

Although Firestorm's export is a huge leap above XML export, it is still highly limited, for example: it does not support mesh export at all.  For mesh, you have to manually re-upload it, retexture it, and reconfigure its scripts, animations, other contents, etc.

The firestorm backup can store content using the Save as, Collada which is supposed to work for mesh content you created. Though it seems a bit strange to me that if you had the source files to begin with why you would need to back them up this way. I have seen it used to export prim structures for editing into mesh objects to be imported again. One Question: Does the IAR export only contain the contents of the person making the export for which they are the sole creator? I thought it would take all that was in the region.

I have import/export tools in progress that will meet this requirement. See https://github.com/InWorldz/halcyon-import-export

See the above linked external tool for import/export functionality - and possibly help write documentation for it! :D

Issues I've seen with IAR support for future reference:

In order to create a full IAR without losing who the creator is the file has to store the creator's identity.  Since avatar IDs change from grid to grid, and not everyone with the same name is the same person there's a quagmire for grid-to-grid IAR transfer. See https://justincc.wordpress.com/2009/09/25/preserving-content-creator-credit-in-opensim-iar-transfers/ for details.  Yes, I know OARs have the same problem, hence the best use is in such rare circumstances as when InWorldz was shut down and things had to be rescued.  But even then even if IARs had been working they likely wouldn't have been taken because of the load as noted below.
It's REALLY had to make a consistent IAR. You have to recursively handle the inventories of each item in the inventory as the prim inventory is just a reference to another asset in the asset server.  This will take a lot of time and produce so much load on the asset server that it'll likely degrade people's experience on the grid.  Yes, even OARs have this problem, hence when InWorldz went down and OARs were taken people had to rez what they wanted to keep using the heuristic of "if it can rez, rez it; if not, put it in a rezzed object."
Support for backup of user inventory really doesn't belong as part of a region/simulator's processing.  It should be an external tool accessed by a management website.

IIRC there are more issues with the subject.


Upgrade to Kotlin V2

Ignore broken compile messages for now

coverage: 100.0%. remained the same
when pulling d39a2a4cf63cf1282eb3ce82fe005f15c528a99a on jeffgbutler:kotlin-v2-upgrade
into 0e08e1a7eb188a2232f2009fd6b43b1d9ae3bbd1 on mybatis:master.


BlazorDemos/ServerAppDemo can leave a process behind when window closed via Window.Close()

Discovered while setting up a frameless application, an orphaned process can result when WindowController.Close() is called. The leftover process is the blazorTask spawned in Program.Main.
https://github.com/chromelyapps/demo-projects/blob/master/blazor/ServerAppDemo/Program.cs
I'm able to avoid the issue by setting up a couple static fields on Program (Task/CancellationTokenSource)
private static Task BlazorTask;
private static CancellationTokenSource BlazorTaskTokenSource;

creating the task with the CancellationTokenSource token
// start the kestrel server in a background thread
BlazorTaskTokenSource = new CancellationTokenSource();
BlazorTask = new Task(() =>
{
    CreateHostBuilder(args, port).Build().Run();
}, BlazorTaskTokenSource.Token, TaskCreationOptions.LongRunning);
BlazorTask.Start();

and adding an event handler for ProcessExit
AppDomain.CurrentDomain.ProcessExit += ProcessExit;
private static void ProcessExit(object sender, EventArgs e)
{
    Task.Run(() =>
    {
        WaitHandle.WaitAny(new[] { BlazorTaskTokenSource.Token.WaitHandle });
        BlazorTask?.Dispose();
    });
    BlazorTaskTokenSource.Cancel();
}

I'm not 100% certain this is the right solution, however. If the above is something better done with a pull request, I'm happy submit one--just let me know.

@pragmar looks like a useful feature to me. Issues like these are expected with multiple processes - Chromely, Asp.Net Core + blazor.

@pragmar looks like a useful feature to me. Issues like these are expected with multiple processes - Chromely, Asp.Net Core + blazor.


Signature Help is not provided

Description:
Consider the following source snippet.
public listener http:Listener ll = new http:Listener(<cursor>)
public listener http:Listener ll = new(<cursor>)
The signature help feature is not working for the given cursor position

Fixed in latest master. Hence closing the issue.


How to drag and drop when add new row in table

Hi all!
I have a table list, and i set ng2-dnd is run good!
But i have 1 button when click auto add new row to table, after add row done i can not drag and drop this row.
pls help me, thanks a lot

Source code and mockups please.

Did you sorted out you problem?


How to capture registration token value?

In the section titled "Register the virtual machines to the Windows Virtual Desktop host pool," there is this instruction: "When the installer asks you for the registration token, enter the value you got from the Get-AzWvdRegistrationInfo cmdlet." The token is very long and gets truncated in a standard PowerShell window. How can you get the full value of that token to appear so that you can copy and paste it into the WVD Agent installation prompt?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bfcfbec-b7ca-57e2-67cc-e5891fdbefd7
Version Independent ID: 16b54c4d-07de-9d14-2a74-38e321361069
Content: Create Windows Virtual Desktop host pool PowerShell - Azure
Content Source: articles/virtual-desktop/create-host-pools-powershell.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Send out the claim {Policy:PolicyId}
Into RelyingParty tag
`
<DefaultUserJourney ReferenceId="SignUpOrSignIn" />
<TechnicalProfile Id="PolicyProfile">
  <DisplayName>PolicyProfile</DisplayName>
  <Protocol Name="OpenIdConnect" />
  <OutputClaims>
    <OutputClaim ClaimTypeReferenceId="displayName" />
    <OutputClaim ClaimTypeReferenceId="objectId" PartnerClaimType="sub"/>
    <OutputClaim ClaimTypeReferenceId="identityProvider" />
    <OutputClaim ClaimTypeReferenceId="policyId" AlwaysUseDefaultValue="true" DefaultValue="{Policy:PolicyId}" />
  </OutputClaims>
  <SubjectNamingInfo ClaimType="sub" />
</TechnicalProfile>

`
see the Policy section and relying-party-policy section
Docs

@DavidSchrag Thank you for your feedback . We will investigate and update the thread further.

@DavidSchrag You can get this token from the UI portal as well from the host pool blade if that helps. You can extract the specific property and expand it in PowerShell.
Thanks

@DavidSchrag
Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


[BEAM-774] Implement Metrics support for Spark runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @amitsela @bjchambers
CC: @kennknowles @staslev

I'll review after your additional changes.
I will add here what I told you in person:
Spark Accumulators (which is what you use to implement distributed Metrics) do not guarantee exactly-once or a commit, unless running in an "action" (explained here) which we currently don't use in the runner for various reasons.
Currently, the guarantee (or it's drawback) is that Accumulators (hence Metrics in the Spark runner) may over count.

@amitsela @bjchambers @staslev
I went ahead and split the PR into 2 commits, one for the metrics support, the other for exposing the metrics via Spark's metrics sink.
I also took care of several of the issues you've raised in comments.
@bjchambers PTAL especially at the changes made in the SDK test classes: MetricsTest and MetricsMatcher as I've leveraged this RunnableOnService test for testing the implementation in spark, as discussed, and in the course of doing so added to the existing test.

@amitsela @bjchambers
Regarding the issue of committed versus attempted metrics in the results:
As mentioned by @amitsela Spark accumulators may overcount. These are used for implementing the distributed metrics accumulation in this solution.
Taking this and @bjchambers comments regarding the semantics  committed vs attempted metrics into account, do we want to have SparkMetricResults return the accumulated metrics in attempted() only and throw an UnsupportedOperationException in committed()?

As for committed()/attempted() support - since querying the metrics results is not a part of the model and is mostly a 1 time setup relevant to the runner, it is OK to throw Unsupported... in committed() (for the Spark runner).

Following my previous comments and the correspondence here, it seems like there are three classes we had to wrap in Serializable for the implementation in the Spark runner:
MetricsKey, DistributionData, MetricName.
I think there's no reason to not make them Serializable, and I think it could benefit other runners as well (actually even if it was just for the Spark runner, I don't see a justification not to do that and avoid redundant wrapper code).
@bjchambers WDYT ?

@aviemzur Jenkins seems to be misbehaving in general, saw this in other PRs too.

@aviemzur looks good. I'll summarize here the issues that are still open:

Throwing UnsupportedOperationException for committed().
Possible over-count in case of same-name steps.
Avoid duplication of API classes by making them Serializable.

Did I miss anything ?

I think it may be worth starting a quick thread on the dev list about the attempted() vs. committed() thing. I believe we added it to add clarity and make provide parity with Aggregators, where we can get the exactly-right answer out of Pipeline Results. Given that Metrics don't provide the same consistency guarantees, another option would be relaxing (or even removing) the requirement that reported Metrics are queryable via PipelineResult. This would make the tests a bit trickier, since each runner would need to configure how to do testing, but it would simplify the runner implementation.

Retest this please.

@amitsela @bjchambers
Removed the duplicate Serializable classes and marked the relevant sdk classes as Serializable instead.
+46 −313 lines. Great success! :1st_place_medal:

Changes Unknown when pulling 0d5ab78ff9c466e42199be7ff0ce9f080afb2376 on aviemzur:spark-runner-metrics-support into ** on apache:master**.

Coverage remained the same at 69.937% when pulling 735216287ce2e3ffd21b90abef5fb38e24f99c0d on aviemzur:spark-runner-metrics-support into 603f4fb0493435f4eb451f52fc5c10aa12001486 on apache:master.

@bjchambers
Since we decided to throw an exception in committed this requires splitting up the existing RunnableOnService test in MetricsTest into two tests - one which asserts the committed and one which asserts the attempted.
Changing current category annotation UsesMetrics and adding another one (One for committed and one for attempted) will require a change to every runner's pom (which could introduce annoying git merges).
Thoughts?

It seems like we'll need to make that change though -- maybe we can do that in a separate PR and merge in prior to continuing with this review. Basically, it seems like we'll need to have different tests based on what level of guarantees the runner supports. If it can provide a committed metric vs. not. Does that agree with your thoughts? Maybe
UsesCommittedMetrics and UsesAttemptedMetrics?

@bjchambers
Sounds good. Made those changes in a separate PR: PR-1865
Also, rebased on top of that PR so I can continue with the changes we discussed in this branch.

Coverage decreased (-0.009%) to 69.729% when pulling a1cbcec41f3b65954e3f7d2acc58520c594075e3 on aviemzur:spark-runner-metrics-support into 34b4a6d9dc2cf5e8da43346077a36b460501afe2 on apache:master.

Coverage decreased (-0.009%) to 69.729% when pulling c465a22ee3f3f2204629ca79c31eb8d7bf680448 on aviemzur:spark-runner-metrics-support into 34b4a6d9dc2cf5e8da43346077a36b460501afe2 on apache:master.

Added support for MultiDo and tests.

Coverage increased (+0.001%) to 69.739% when pulling 0575b34666a06ceca7a889de86e640a59b9c27e8 on aviemzur:spark-runner-metrics-support into 34b4a6d9dc2cf5e8da43346077a36b460501afe2 on apache:master.

Looks good, I'll wait for Ben's comments and perquisite PR. Once that's done please rebase and ping me.

Rebased changes from master.
Will add fault tolerance for metrics, to be in line with the aggregators.

Added recovery of metrics from checkpoint.

Coverage increased (+0.02%) to 69.645% when pulling 50434b75b286752a76003d7a1679adadaccaa545 on aviemzur:spark-runner-metrics-support into 7a235f9d9de24ca37748f30d04af94a39ac262f6 on apache:master.

Coverage decreased (-0.006%) to 69.615% when pulling d3cdcb699118d14c044bcb5f6cb1e7ac8e95c914 on aviemzur:spark-runner-metrics-support into 7a235f9d9de24ca37748f30d04af94a39ac262f6 on apache:master.

Coverage increased (+0.02%) to 69.698% when pulling 78b7ecf163a7d257ce18091fb5322e587fd72753 on aviemzur:spark-runner-metrics-support into 08e58e1dfd4cc21a24755d21b8241ca4488b0e83 on apache:master.

@amitsela @bjchambers All rebased and ready to go.

LGTM, @bjchambers ?

Sorry - I've been swamped. I'll try to take a look tonight or tomorrow
morning.
On Sat, Feb 4, 2017, 8:50 AM Amit Sela<EMAIL_ADDRESS>wrote:

LGTM, @bjchambers https://github.com/bjchambers ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/1750#issuecomment-277458676, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACMeKuyfWwj9ZIzk82UhLiULS0k5dcKks5rZKw5gaJpZM4Ldtm9
.

@bjchambers
After the discussion in the dev list I went ahead and opened https://issues.apache.org/jira/browse/BEAM-1344
Are there any other differences that require a ticket to address them?

@bjchambers is there anything else you think needs to be done here ? does it LGTY ?

Looks good to me.

Merging.


add /examples level README, rename Phrase List doc to README.md

@stevengum97,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[launcher] - Clean project should see if process is running then kill versus just throw error

Cleaned project and got
38>ERROR: The process "PowerLauncher.exe" not found.
From @ryanbodrug-microsoft
@crutkas Just to be clear that output is from the taskkill process. It's not an error or warning in visual studio. The fix for the above log would be to suppress the stdoutput for the task. I'm happy to fix it... its probably low priority unless you think it's going to confuse everyone that something is wrong.

is it possible to only have the error be thrown once? :)

is it possible to only have the error be thrown once? :)

I have it once per project in the launcher directory because each of these assemblies gets used in the powerlauncher.dll.  I can't assume what project they are building, as I'm trying to support the 'edit code - hit F5' scenario.  I don't know which project they will be editing code.   There may be a more complicated way of solving this, but I think I'd prefer to just suppress the taskkill output.


Cleanup Kubernetes resources when odo dev exits

What type of PR is this:
/kind feature
What does this PR do / why we need it:
Cleans up the Kubernetes Deployment when user hits Ctrl+C. Since we have ownerRerences set for resources created by odo in the inner loop, deleting a Deployment will delete everything else that belongs to the component.
Which issue(s) this PR fixes:

Fixes #5485
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

Closing this. Will open a separate PR once we have #5484 addressed.


Load transformation from JSON

Loading transformation from JSON would be useful in some cases, like when you perform an alignment without using landmarks (yes, the tool is good enough to be usable without landmarks in some cases :-)

close


When branch flash-layer was run as a docker, all nodes were slashed.

I conducted the test locally using Agora's Branch flash-layer and its compatible Stoa and SDK.
I could make it up to block height 2. The contents of the block delivered by Agora are as follows.
And no more blocks were made.
missing_validators is [0, 1, 2, 3, 4, 5].
Here's what Block Height 2 is about.
{
"header": {
"signature": "0x04abf545f0b23204854fc6768f08184c56f0f67d74251361582239e3a81f469631474465a8ffc5741a06464b6edb46e9318be61cacf6105215e0adbb6d51c1fb",
"prev_block": "0x25c3618a72db3622450d7b30a1d033c970b80e16777db837b2810d6a96d74ffa54e37cc2f2610964c7ab6ab6ec33a4326793a2c3f6ade76177405d47727e4663",
"random_seed": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"height": "2",
"timestamp":<PHONE_NUMBER>,
"validators": "[248]",
"missing_validators": [
0,
1,
2,
3,
4,
5
],
"enrollments": [],
"merkle_root": "0x804566367f6e7dd4450026e550ae5ad8e8057c6bee49cc9a4be4f9947608897cd1cff5836fa5097b0b8087717c7f9d6ecc66f61a3fa52615cebfeebdc8b628c4"
},
"txs": [
{
"type": 0,
"payload": "",
"outputs": [
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "wa12JhcM4VQSkBkXSsmRmuzfSDPvk3dEkOSoW1VvqJI="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "w61BPGncd7jWybWOoLdVvDEEhb+g0MfNkKfifFinvIE="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "xa0IpVB5lsc0f4jIoNXMoEfJp9CCyy6dMsyib8zar9w="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "x60fkzRNLpGt2M4TMYKWSLU6KiZnyWVTUfJJTrBjmxI="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "ya0HKXvYRYIUyGEfmmhbTslQ8up0GrFU35b7blJUKf0="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "y60S2hZtpVYyWVpkwdOYz9vZyvsWhuX2d3XrWulg700="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "za0HpZvuTszwYKZh0FxZdN4Mpecea+loKblm0zkE+L8="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "z61JXrlX7JJxMU+Doxc74yLHUbT5HOKdw3CC+Cg4oqc="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "0a0v+omtjYSFVqtA2Ylks07KDRQW3pRF578Sow3qmY0="
}
},
{
"value": "61000000000000",
"lock": {
"type": 0,
"bytes": "061+mPcpyq3W//akT9yJzxyqOSg/iX2FYlXbUGSAiEI="
}
}
],
"lock_height": "0",
"inputs": [
{
"utxo": "0x470785849bbb6fe3f88fb416a9b79702512b4a37b091cbf1650c637a61fd9d0e4f65a79dcc03f0d3dbd93bf2a2da34caeb7a9e95cbb5847f1e99ee67db19bcc9",
"unlock_age": 0,
"unlock": {
"bytes": "yk2UN+u1nt1xfMsYc4Cw8sOVIQAQTNGQbOf9ZBWWkuabf0qgDPcdvIAni7uAQR5d3poCx1cOjz3SlkCR49SgAA=="
}
}
]
}
],
"merkle_tree": [
"0x804566367f6e7dd4450026e550ae5ad8e8057c6bee49cc9a4be4f9947608897cd1cff5836fa5097b0b8087717c7f9d6ecc66f61a3fa52615cebfeebdc8b628c4"
]
}

Thanks. It looks to me that there is something wrong with slashing. I'll run a test locally.

Thanks. It looks to me that there is something wrong with slashing. I'll run a test locally.

It's possible v0.x.x is broken as well.

It's possible v0.x.x is broken as well.

With faucet I can create many blocks with the flash-layer without issues.
So this is strictly a slashing problem in a specific scenario. Please provide the exact command you used to run the nodes.
@linked0 since slashing is mostly your code I think you should take a look at this.

With faucet I can create many blocks with the flash-layer without issues.
So this is strictly a slashing problem in a specific scenario. Please provide the exact command you used to run the nodes.
@linked0 since slashing is mostly your code I think you should take a look at this.

I took a look at this with the docker environment and found the log as follows.
node-3_1  | 2021-01-25 04:37:34,713 Info [agora.consensus.state.ValidatorSet] - Invalid pre-image data: The pre-image has a invalid hash value. Pre-image: { enroll_key: 0xc0abcbff07879bfdb1495b8fdb9a9e5d2b07a689c7b9b3c583459082259be35687c125a1ddd6bd28b4fe8533ff794d3dba466b5f91117bbf557c3f1b6ff50e5f, hash: 0x01034d7769efe3dc76033d5c29f64438ea7657f2c80f4441307f079028e2de6e8b608dd3df15cbe7488202d55d5a5185ff0e5d7810dadf6d5ec9a0caa457d81c, distance: 7 }
node-7_1  | 2021-01-25 04:37:34,521 Info [agora.network.NetworkManager] - Retrieving blocks [1..1] from http://node-7:7826..
node-7_1  | 2021-01-25 04:37:34,522 Info [agora.network.NetworkManager] - Received blocks [1..1]
node-7_1  | 2021-01-25 04:37:34,670 Info [agora.consensus.state.ValidatorSet] - Invalid pre-image data: The pre-image has a invalid hash value. Pre-image: { enroll_key: 0xc0abcbff07879bfdb1495b8fdb9a9e5d2b07a689c7b9b3c583459082259be35687c125a1ddd6bd28b4fe8533ff794d3dba466b5f91117bbf557c3f1b6ff50e5f, hash: 0x01034d7769efe3dc76033d5c29f64438ea7657f2c80f4441307f079028e2de6e8b608dd3df15cbe7488202d55d5a5185ff0e5d7810dadf6d5ec9a0caa457d81c, distance: 7 }

I think there are some issues in publishing pre-images. I will analyze it more.

I took a look at this with the docker environment and found the log as follows.
node-3_1  | 2021-01-25 04:37:34,713 Info [agora.consensus.state.ValidatorSet] - Invalid pre-image data: The pre-image has a invalid hash value. Pre-image: { enroll_key: 0xc0abcbff07879bfdb1495b8fdb9a9e5d2b07a689c7b9b3c583459082259be35687c125a1ddd6bd28b4fe8533ff794d3dba466b5f91117bbf557c3f1b6ff50e5f, hash: 0x01034d7769efe3dc76033d5c29f64438ea7657f2c80f4441307f079028e2de6e8b608dd3df15cbe7488202d55d5a5185ff0e5d7810dadf6d5ec9a0caa457d81c, distance: 7 }
node-7_1  | 2021-01-25 04:37:34,521 Info [agora.network.NetworkManager] - Retrieving blocks [1..1] from http://node-7:7826..
node-7_1  | 2021-01-25 04:37:34,522 Info [agora.network.NetworkManager] - Received blocks [1..1]
node-7_1  | 2021-01-25 04:37:34,670 Info [agora.consensus.state.ValidatorSet] - Invalid pre-image data: The pre-image has a invalid hash value. Pre-image: { enroll_key: 0xc0abcbff07879bfdb1495b8fdb9a9e5d2b07a689c7b9b3c583459082259be35687c125a1ddd6bd28b4fe8533ff794d3dba466b5f91117bbf557c3f1b6ff50e5f, hash: 0x01034d7769efe3dc76033d5c29f64438ea7657f2c80f4441307f079028e2de6e8b608dd3df15cbe7488202d55d5a5185ff0e5d7810dadf6d5ec9a0caa457d81c, distance: 7 }

I think there are some issues in publishing pre-images. I will analyze it more.

I will do a test about this with the latest source of agora, stoa, and stoa-sdk-ts repositories again.

I will do a test about this with the latest source of agora, stoa, and stoa-sdk-ts repositories again.

I'm updating the flash-layer branch now. There are some breaking changes due to hashing changes. I will fix this soon so you can test it.

I'm updating the flash-layer branch now. There are some breaking changes due to hashing changes. I will fix this soon so you can test it.

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file.   @MichaelKim20 is now testing it again with the latest Config files.

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file.   @MichaelKim20 is now testing it again with the latest Config files.

I'm updating the flash-layer branch now. There are some breaking changes due to hashing changes. I will fix this soon so you can test it.

I pushed a fix and now flash-layer should be up to date with v0.x.x. This should fix the build.

I'm updating the flash-layer branch now. There are some breaking changes due to hashing changes. I will fix this soon so you can test it.

I pushed a fix and now flash-layer should be up to date with v0.x.x. This should fix the build.

I used the newly changed config.yaml.
The nodes were not slashed.
However, the block height could not be larger than 2. This will create another issue
{"txs":[{"type":0,"payload":"","outputs":[{"value":"61000000000000","lock":{"type":0,"bytes":"1a1uSoi1AeylReWUxX6SoI4xaW1SHhSb75xEVqaxggs="}},{"value":"61000000000000","lock":{"type":0,"bytes":"160Zt1CN2C86sb5qX6H674qWgOQp1A1D6SRwsNm5aJM="}},{"value":"61000000000000","lock":{"type":0,"bytes":"2a14wgdHe85aw3cmho4tACn83fstQ3C9+cvujHDg5xY="}},{"value":"61000000000000","lock":{"type":0,"bytes":"260GWfJEsiycAlKY8HiSDK/qG/xWAl9AP8RaLNx1IB8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"3a08uLMpvBVqHh+n1Zx676HwK06RGDEHsk5ZbnnyJpY="}},{"value":"61000000000000","lock":{"type":0,"bytes":"3601ecRvqYXBtM3PYEcP7V/5PfTYPLuzHSD0L+0TOQ8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"4a1f310lZ3Jt8Pqj3DAYbc28Z0d19E1YVuHp7P3JriA="}},{"value":"61000000000000","lock":{"type":0,"bytes":"461a3VaFQXl5KQYvtgNv4YUnSuydWuzq6lSRRnYtJwA="}},{"value":"61000000000000","lock":{"type":0,"bytes":"5a0vgb7VEL/ZyQu0T70y2aMZmrHSEVnMXWJklpJdPD8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"561BZqizZsMmWLklng8S3j+xqwFoNbI34zC6DxNSElA="}}],"lock_height":"0","inputs":[{"utxo":"0x470785849bbb6fe3f88fb416a9b79702512b4a37b091cbf1650c637a61fd9d0e4f65a79dcc03f0d3dbd93bf2a2da34caeb7a9e95cbb5847f1e99ee67db19bcc9","unlock_age":0,"unlock":{"bytes":"AzWY7WI71Dh43ZgGELb8cdvrRjnt188Qp6vycV7/K+sb3bAFddmTa31lnHfr+5vbcppQdmi0fC8JQjtLtDc6BQ=="}}]}],"merkle_tree":["0x972be5714857f8e53190b4f8f155eeb85ab516da45286627056862e74966c45a32cd961bc6ca15fadd1dde8a7c9ef18d09bb9e0919417c9061b5e600e3596b12"],"header":{"signature":"0x06b1037df01dd70bc46592742b576cb063d22231654d190e995d61bb3b67fe529d7103759504a73d46ef105a5fec9a239f32d5dffb67848baa87c81d63beeb07","prev_block":"0x9d7fb1426a12ff1d3d33bed3a0c3ff83dff6e183b4e8ca24dab53e69996bfe90f854478889f2e6f19c36f1e4a970d622bdab29da18ad3b09553da2a4ae0fb83f","random_seed":"0x6554be8541f56ca9819f5cc316c43e30f1afe48bd5c81f9bd78e7bbae21aa22cd51ddc324808a8e5f5d51dba3d0942de8b173c1e89404b768e7fafa5bcab653c","height":"2","timestamp":1611562832,"validators":"[220]","missing_validators":[],"enrollments":[],"merkle_root":"0x972be5714857f8e53190b4f8f155eeb85ab516da45286627056862e74966c45a32cd961bc6ca15fadd1dde8a7c9ef18d09bb9e0919417c9061b5e600e3596b12"}}

I used the newly changed config.yaml.
The nodes were not slashed.
However, the block height could not be larger than 2. This will create another issue
{"txs":[{"type":0,"payload":"","outputs":[{"value":"61000000000000","lock":{"type":0,"bytes":"1a1uSoi1AeylReWUxX6SoI4xaW1SHhSb75xEVqaxggs="}},{"value":"61000000000000","lock":{"type":0,"bytes":"160Zt1CN2C86sb5qX6H674qWgOQp1A1D6SRwsNm5aJM="}},{"value":"61000000000000","lock":{"type":0,"bytes":"2a14wgdHe85aw3cmho4tACn83fstQ3C9+cvujHDg5xY="}},{"value":"61000000000000","lock":{"type":0,"bytes":"260GWfJEsiycAlKY8HiSDK/qG/xWAl9AP8RaLNx1IB8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"3a08uLMpvBVqHh+n1Zx676HwK06RGDEHsk5ZbnnyJpY="}},{"value":"61000000000000","lock":{"type":0,"bytes":"3601ecRvqYXBtM3PYEcP7V/5PfTYPLuzHSD0L+0TOQ8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"4a1f310lZ3Jt8Pqj3DAYbc28Z0d19E1YVuHp7P3JriA="}},{"value":"61000000000000","lock":{"type":0,"bytes":"461a3VaFQXl5KQYvtgNv4YUnSuydWuzq6lSRRnYtJwA="}},{"value":"61000000000000","lock":{"type":0,"bytes":"5a0vgb7VEL/ZyQu0T70y2aMZmrHSEVnMXWJklpJdPD8="}},{"value":"61000000000000","lock":{"type":0,"bytes":"561BZqizZsMmWLklng8S3j+xqwFoNbI34zC6DxNSElA="}}],"lock_height":"0","inputs":[{"utxo":"0x470785849bbb6fe3f88fb416a9b79702512b4a37b091cbf1650c637a61fd9d0e4f65a79dcc03f0d3dbd93bf2a2da34caeb7a9e95cbb5847f1e99ee67db19bcc9","unlock_age":0,"unlock":{"bytes":"AzWY7WI71Dh43ZgGELb8cdvrRjnt188Qp6vycV7/K+sb3bAFddmTa31lnHfr+5vbcppQdmi0fC8JQjtLtDc6BQ=="}}]}],"merkle_tree":["0x972be5714857f8e53190b4f8f155eeb85ab516da45286627056862e74966c45a32cd961bc6ca15fadd1dde8a7c9ef18d09bb9e0919417c9061b5e600e3596b12"],"header":{"signature":"0x06b1037df01dd70bc46592742b576cb063d22231654d190e995d61bb3b67fe529d7103759504a73d46ef105a5fec9a239f32d5dffb67848baa87c81d63beeb07","prev_block":"0x9d7fb1426a12ff1d3d33bed3a0c3ff83dff6e183b4e8ca24dab53e69996bfe90f854478889f2e6f19c36f1e4a970d622bdab29da18ad3b09553da2a4ae0fb83f","random_seed":"0x6554be8541f56ca9819f5cc316c43e30f1afe48bd5c81f9bd78e7bbae21aa22cd51ddc324808a8e5f5d51dba3d0942de8b173c1e89404b768e7fafa5bcab653c","height":"2","timestamp":1611562832,"validators":"[220]","missing_validators":[],"enrollments":[],"merkle_root":"0x972be5714857f8e53190b4f8f155eeb85ab516da45286627056862e74966c45a32cd961bc6ca15fadd1dde8a7c9ef18d09bb9e0919417c9061b5e600e3596b12"}}

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file. @MichaelKim20 is now testing it again with the latest Config files.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file. @MichaelKim20 is now testing it again with the latest Config files.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

OK, I reopen it and assign it to me.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

OK, I reopen it and assign it to me.

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file. @MichaelKim20 is now testing it again with the latest Config files.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

I'm assuming it was because all the nodes were revealing invalid preimages.
To what extent does the protocol allow invalid preimages?

After analyzing the issue with @kchulj, the latest structure of Config is not applied to the config.yaml files in the test environment. Last Friday, the consensus section is added in the Config file. @MichaelKim20 is now testing it again with the latest Config files.

Ok, but how come all the nodes got slashed? That shouldn't be possible in the protocol. It would lead to the blockchain becoming completely unusable. This bug needs to be fixed.

I'm assuming it was because all the nodes were revealing invalid preimages.
To what extent does the protocol allow invalid preimages?

Well it should not externalize a block. It should wait until a valid preimage is revealed. Maybe that would happen after the node is restarted with the appropriate config.

Actually the current block validation routines will fail if there are no active validators in a block. So how come the block got accepted?

Well it should not externalize a block. It should wait until a valid preimage is revealed. Maybe that would happen after the node is restarted with the appropriate config.

Actually the current block validation routines will fail if there are no active validators in a block. So how come the block got accepted?

I'm assuming it was because all the nodes were revealing invalid preimages.
To what extent does the protocol allow invalid preimages?

I think we must not create a new block in case all the validators are slashed.

I'm assuming it was because all the nodes were revealing invalid preimages.
To what extent does the protocol allow invalid preimages?

I think we must not create a new block in case all the validators are slashed.

Well it should not externalize a block. It should wait until a valid preimage is revealed.

Or if new enrollments arrive, we can make a new block.

Well it should not externalize a block. It should wait until a valid preimage is revealed.

Or if new enrollments arrive, we can make a new block.


[sndy] add emberfied.com

Emberfied- UI studio built using ember.js

Thanks, but we'll pass for now <3. This looks like a personal site and work in progress.

Alrighty (


[Bug][tcgc]: Does not honor encodedName correctly

Describe the bug
I try to migrate Search service to use tsp.
Here are the converted tsps: https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search
You can see in https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search/models-service.tsp#L6446 I have
@pagedResult
model ListIndexesResult {
    /**
     * The indexes in the Search service.
     */
    @visibility("read")
    @items
    @encodedName("application/json", "value")
    indexes: SearchIndex[];
}

I expected that in the generated code, it should attempt to parse "value". But unfortunately it generated deserialized["indexes"]
https://github.com/Azure/azure-sdk-for-python/blob/search_11.5.0_tsp/sdk/search/azure-search-documents/azure/search/documents/_generated/operations/_operations.py#L3730
Reproduction
Try to generate Python code using https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search
Checklist

[x] Follow our Code of Conduct
[x] Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
[x] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[x] The provided reproduction is a minimal reproducible example of the bug.

But another related issue is TCGC does not take renaming for the path. Will fix it.


Thunder Bowl

Your checklist for this pull request
Author name
Shreya Maurya

mauryashreya
About your game
What is your game about?
we need to push all  the footballs in their respective goals .
How do you play your game?
press WASD for movement of the player , can press j to reset and k to get hints  .

Code
Check off the items that are true.

[x ] The game was made using the Sprig editor.
[x ] The game is placed in the in the /games directory.
[x ] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[ x] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x ] The game name is not the same as the others from gallery

Image (If an image is used)

[x ] The image is in the /games/img directory.
[ x] The name of the image matches the name of your file.

Thanks for your PR!

hi ! sorry for replying this late . I didn't use any specific games but i
did check out a lot of games that were in sprig gallery to see how sprig
works .
On Sat, Jul 29, 2023 at 5:00 AM Lucas @.***> wrote:

@.**** requested changes on this pull request.
Sorry for the delay! Did you use any games for inspiration?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1100#pullrequestreview-1553092728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEFB2RBUDCB6DMJR7G65O3XSRDQDANCNFSM6AAAAAA2ZBYBLU
.
You are receiving this because you were mentioned.Message ID:
@.***>

no worries:) do you have experience with js?

Yeah ! I have some . i learned game development during lockdown in my
freshman year of high school .
On Tue, Aug 1, 2023 at 10:27 PM Lucas @.***> wrote:

no worries:) do you have experience with js?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1100#issuecomment-1660740998, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEFB2S5ZGZCE4EENZB4M2TXTEYPRANCNFSM6AAAAAA2ZBYBLU
.
You are receiving this because you were mentioned.Message ID:
@.***>

yeah, its by hackclub- thunder ball . I don't have access to my laptop for few days so i won't be able to do it. sorry for the inconvenience
…
On Wed, Aug 2, 2023 at 2:42 AM Lucas @.> wrote: @.* requested changes on this pull request. Nice! Could you change the name of the image to the name of your game? — Reply to this email directly, view it on GitHub <#1100 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASEFB2VXKKZ5Q7JCJZSFI5TXTFWKDANCNFSM6AAAAAA2ZBYBLU . You are receiving this because you were mentioned.Message ID: @.***>

no worries, take your time

yeah , i think it's done now . could u please check it once and tell me . I
am kinda new to this .
On Thu, Aug 3, 2023 at 9:40 PM vercel[bot] @.***> wrote:

The latest updates on your projects. Learn more about Vercel for Git ↗
https://vercel.link/github-learn-more
Name Status Preview Comments Updated (UTC)
sprig 🔄 Building (Inspect
https://vercel.com/gamer/sprig/A4G7F8qKdwftvRUeHHjR2m2Uhbps) Visit
Preview
https://vercel.live/open-feedback/sprig-git-fork-mauryashreya-main-gamer.vercel.app?via=pr-comment-visit-preview-link&passThrough=1
💬 Add feedback
https://vercel.live/open-feedback/sprig-git-fork-mauryashreya-main-gamer.vercel.app?via=pr-comment-feedback-link Aug
3, 2023 4:10pm
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1100#issuecomment-1664260754, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEFB2XL426B7YQYQCQ4R6TXTPEP3ANCNFSM6AAAAAA2ZBYBLU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

On Fri, 4 Aug 2023 at 3:19 AM, Lucas @.***> wrote:

Merged #1100 https://github.com/hackclub/sprig/pull/1100 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1100#event-10003461421, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEFB2WJMGBDTTXJFWJCJTLXTQMFDANCNFSM6AAAAAA2ZBYBLU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Great! Thankyou so much


Use github.com/spf13/cobra CLI library?

Coming from coreos/rkt#1028 starting with a CLI library like it should be useful (see https://github.com/coreos/rkt/issues/632#issuecomment-108904070 for a list of features/requirementd) and avoid additional work now and in the future.

+1, sgtm

Implementation that was just merged uses cobra.


Make key enabled only with runtime feature

Key is not needed when runtime feature is not enabled

Closed in favour of #34


[Bug] Lets get started button is not showing properly on instruction page

Description
The lets get started button is not shown properly and it is not clear from the view of the screen shot.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

please assign this issue to me under iwoc2024 @Rakesh9100 .

@Rakesh9100 please reply fast

Will you make every instruction box responsive @shivam101203

Okkk

I will made it responsive as well

Okay proceed @shivam101203

Thanks sir

Hey @Rakesh9100 , I would like to contribute to this issue. Please assign this to me

You want to work for which open source program, pls make the proper comment @Lavanya-Sathya

@Rakesh9100 , Assign it under JWOC

Go ahead @Lavanya-Sathya


Small fix for parsing type parameter declarations

When you eat a token, it looks like Babylon automatically lexes the next token. Setting this.state.inType changes the behavior of the lexer, so it needs to be set before eating the type. This was causing trouble, since
type Foo<T = void> = T;

wouldn't parse, since we would eat the = token before setting this.state.inType = true, which meant void was lexed as an expression instead as a type.
However, the whole type parameter declaration should be parsed with this.state.inType = true anyway. Sometimes it was, like for functions and arrow functions, but often it was not. This change makes all type parameter declarations be parsed with this.state.inType = true.

Current coverage is 96.91% (diff: 100%)

Merging #83 into master will decrease coverage by <.01%

@@             master        #83   diff @@
==========================================
  Files            19         19
  Lines          2923       2920     -3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           2833       2830     -3
  Misses           90         90
  Partials          0          0

Powered by Codecov. Last update 4811d61...3f9265b


Remove continue point from Garbage Collector

Updated Garbage Collection code to no longer use a continue point when processing deletion candidates. The GC  now uses an iterator that lasts during the lifetime of a GC cycle.
The GarbageCollectionTest was updated to work with the update, as was the GC integration test.
Closes #1351

Thanks for taking a look @milleruntime. Looking more closely is a good idea since we definitely want the GC to work as expected. I've run the unit and IT tests as well as the sunny profile. Additionally, I ran the GC test in the accumulo-testing repo, although I'd like to run it for a longer period of time. I may wait and see if @keith-turner would like to take a look before merging since he had created the initial ticket.

@jmark99 I just took an initial look at this.  I plan to take a more in-depth look later this afternoon.

@mjwall might have additional insight if this overlaps with the issue that he has been tracking down.

@milleruntime , @keith-turner I did some re-factoring based upon @keith-turner suggestion concerning the getCandidates method. It now returns an interator. With that change the flow now more closely resembles the original flow of the code but without the continue point.

I can look at this tonight if it is still open

@mjwall I will wait until tomorrow to merge if you wish to ltake a look tonight.

This looks good to me @jmark99 .  It is unrelated to what I am tracking in #1916.  First I have looked at Ample, cool abstraction.  Hope it is enough <pun intended>


Name

The name and description could lead to associations like:

hammering the rules into peoples head
beating people to behave

that could be considered offputting to some people. i suggest using a not so violent theme
could this be considered a nixpkgs lint? could it be a nix plugin that is used with nix lint ...? (does Nix support plugins now?) then the name does not matter that much. it could be included in a nixFull package

This was meant as using hammer for working a rough piece of metal into a nice shape (I had a copper pot like this one in mind). But I can see that in today’s world of fast news cycles people will associate ordinary tools with violence before their intended use cases.
Maybe a chisel might be more neutral and also more precise since this tool is used to sharpen up details of mostly ready expressions, like one adds details to already mostly shaped pieces of stone or wood. Unlike a hammer, which is often associated with rougher work like sword making.
The main reason I went with unorthodox name is because I could never find Synthetica9’s tool in search results. But looks like these days the results return it.

This was meant as using hammer for working a rough piece of metal into a nice shape (I had a copper pot like this one in mind). But I can see that in today’s world of fast news cycles people will associate ordinary tools with violence before their intended use cases.
Maybe a chisel might be more neutral and also more precise since this tool is used to sharpen up details of mostly ready expressions, like one adds details to already mostly shaped pieces of stone or wood. Unlike a hammer, which is often associated with rougher work like sword making.
The main reason I went with unorthodox name is because I could never find Synthetica9’s tool in search results. But looks like these days the results return it.

Also I wanted to avoid situation where we have multiple linters with almost the same name, like we have with formatters.

Also I wanted to avoid situation where we have multiple linters with almost the same name, like we have with formatters.

could this be considered a nixpkgs lint?

This is intended as very opinionated set of rules, so individual maintainers can choose to adopt this but I would not want to force it on anyone. Certainly not on everyone in Nixpkgs without a policy change.

could it be a nix plugin that is used with nix lint ...? (does Nix support plugins now?) then the name does not matter that much. it could be included in a nixFull package

This might be interesting but Nix and Nixpkgs are two different things (a good thing IMO). It might be acceptable to integrate this with nix flake check, which is already opinionated, if we get policy accepted.
But flakes are not ready yet for a mainstream use and I am not sure if the Nix plug-ins can affect CLI rather than just Nix language.

could this be considered a nixpkgs lint?

This is intended as very opinionated set of rules, so individual maintainers can choose to adopt this but I would not want to force it on anyone. Certainly not on everyone in Nixpkgs without a policy change.

could it be a nix plugin that is used with nix lint ...? (does Nix support plugins now?) then the name does not matter that much. it could be included in a nixFull package

This might be interesting but Nix and Nixpkgs are two different things (a good thing IMO). It might be acceptable to integrate this with nix flake check, which is already opinionated, if we get policy accepted.
But flakes are not ready yet for a mainstream use and I am not sure if the Nix plug-ins can affect CLI rather than just Nix language.


"import rdkit" ends with failure (missing DLLs) on Windows, even after installation of VC++ advised in tutorial

Hello.
I have windows 7.
I have installed anaconda 32 bit for python 2.7.
I have installed boost.
I have installed vc++ as advised in tutorial.
I have installed rdkit with anaconda, using:
conda create -c rdkit -n my-rdkit-env rdkit
I have activated the environment, using:
activate my-rdkit-env
I have started console python.
The command:
import rdkit
fails with prompt about missing dlls, but with no specification what dlls are missing exactly.
When I start PyCharm from opened envelope, I can see syntax hints of the rdkit library, but when I try to execute any script, it fails on import of rdkit.
I have googled for similar problems. For someone, the paths were missing but for me
os.environ["PATH"] contains what was missing for that person:
C:\ANACONDA\envs\my-rdkit-env
C:\ANACONDA\envs\my-rdkit-env\Library\mingw-w64\bin
C:\ANACONDA\envs\my-rdkit-env\Library\usr\bin
C:\ANACONDA\envs\my-rdkit-env\Library\bin
C:\ANACONDA\envs\my-rdkit-env\Scripts
Advice that would help me identify what dlls are missing would be very appreciated.
Traceback (most recent call last):   File "C:/Users/M260280/PycharmProjects/ExcerciseProject/main.py", line 5, in <module>     import rdkit   File "C:\ANACONDA\envs\my-rdkit-env\lib\site-packages\rdkit\__init__.py", line 2, in <module>     from .rdBase import rdkitVersion as __version__ ImportError: DLL load failed: The specified module could not be found.
Thank you very much in advance for your advice/help/guidance.

Please check your Rdkit package in which environment of python in Anaconda. Then change your system PATH about python in your windows PC. For example,  1) C:\Anaconda3\envs\py35; 2) C:\Anaconda3\envs\py35\Library\bin; 3) C:\Anaconda3\envs\py35\Scripts. It can solve  the issue of "ImportError: DLL load failed: The specified module could not be found.".

It seems like remove the period . before .rdBase in init.py solved the problem for me. My init.py is now as below.
try:
  from rdBase import rdkitVersion as __version__
except ImportError:
  __version__ = 'Unknown'
  raise

as @ClinuxMDL mentioned the order of the conda directory which you put in your path environment is important. I had the same issue and followed @ClinuxMDL suggestion and now the problem is solved. Edit you path manually and change the order of the directory like this:
C:\Miniconda3;C:\Miniconda3\Library\bin;C:\Miniconda3\Scripts
first C:\Miniconda3 then C:\Miniconda3\Library\bin and finally C:\Miniconda3\Scripts.
Thanks you @ClinuxMDL!

Hello.
I'm having the same problem and couldn't solve it. I have installed rdkit version2022.03.5 and Python 3.9.12.
Is anyone else experiencing the same having the versions informed above?

@vini-guimaraes : which operating system are you using? are you using conda? how did you install the rdkit (exactly which commands did you execute)?

@greglandrum thanks for the quick answer. I'm using Win10 but I know what I was doing wrong. I was activating the redkit environment but instead of initiating a Jupyter notebook from this environment I was going directly to Jupyter which wasn't giving me the option to create a new notebook already in that environment.
For those who are struggling I'll leave the steps that worked for me:
$ conda install -n my-rdkit-env nb_conda_kernels
$conda activate my-rdkit-env
Now with the environment activated just enter: $jupyter notebook
Then Jupyter will start and It will show the option " Python [conda env:my-rdkit-env]* " when you select the "New" dropdown menu.
This solved my problem.

Yes, I'm having the same issue. Python 3.7 (as per instructions found in a tutorial in the my-rdkit-env) (although otherwise I have also 3.9 installed).


Automated Community Sentiment Analysis

placeholder for @brandenespinoza  or @kj4ezj  to fill in more information for

Prelim reqs gathering discussion scheduled for 9/30/2023

Bumped @brandenespinoza via IM.


Revert "Allow variance annotations on generic references (#56418)"

fixes https://github.com/microsoft/TypeScript/issues/59790
see the comment here, cc @JoshuaKGoldberg @gabritto

@typescript-bot test it

Will this reopen #56390?

If @RyanCavanaugh keeps the opinion that this is a bug then yes, it should be reopened.
I could alternatively try to fix the assignability issue but it wasn’t clear to me if that should be fixed. So as the first step I decided that it’s better to have the checker rules in a cohesive state by reverting this PR and then hash out the desired behavior for this

@typescript-bot test top800

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>


71 Capacity Planning. pCPU thread vs core fix

VMware recommends using pCPU cores for ratio calculations, not vCPU threads. (https://communities.vmware.com/thread/572025)
I changed the calculation to include both and edited the descriptions to match.

Fix for issue #677


Replace aiosqlite with sqlite-anyio

Can you justify this change a little bit more? Were there specific things in aiosqlite that blocked you enough to create a new package?
I haven't spent enough time using anyio to understand why, in this particular case, it would prompt a switch away from aiosqlite (which is heavily "battle-tested").
I can see that sqlite-anyio is essentially a package around a gist that the main developer of anyio wrote—but do you have a sense for how reliable it is?

Ah, I now see this issue: https://github.com/jupyterlab/jupyter-collaboration/issues/252

I haven't spent enough time using anyio to understand why, in this particular case, it would prompt a switch away from aiosqlite (which is heavily "battle-tested").

In general, there is value in adopting structured concurrency. We just made the switch to AnyIO in ipykernel.
aiosqlite is asyncio-only. With sqlite-anyio, pycrdt-websocket could work on top of asyncio or Trio.

I can see that sqlite-anyio is essentially a package around a gist that the main developer of anyio wrote—but do you have a sense for how reliable it is?

I contacted the author of the gist, who is fine with the package I created around it. It is a thin layer on top of sqlite, basically wrapping the blocking methods with AnyIO's to_thread(). I created tests and there is 100% coverage, so I think it is reliable.


Provide the option to --skip a migration that was already executed

When your logs are cleared, or when you switched branches and you know that the migration fails because e.g. an alter table that was already executed, allow the option to --skip a migration so that the following migrations can be executed.
This should probably add a log with a separate type.

closed by b3dcf1c0b4f88019b315a577b488ff9363a270b6

closed by b3dcf1c0b4f88019b315a577b488ff9363a270b6


Remove the css rule that makes images with width: 100%

Github, npm don't set the width of their images to 100%. With width: 100% images like the "shields"  will be displayed in full width which is not similar to the final expected result for .md files when displayed on github or npm.

Looks good. I remember adding that because images were being resized contrary to how GitHub does it in one specific case a while back, but I can't remember it now. Merging :+1:

Thanks for merging :+1:

No problem, thanks for the pull request! Released on NPM as 0.1.1.


cURL error: [60] Peer certificate cannot be authenticated with known CA certificates

It's a couple of days that it returns this error:
cURL error: [60] Peer certificate cannot be authenticated with known CA certificates
i noticed that everything goes fine through sandbox...
does anyone experienced this error?
thanks in advance

Yep, see #39

Thanks u so much!

@metalgigio Yes when I tried to connect my host system with virtual box (vagrant system), getting above error, I am able to access from web-bowers, but not able to connect while using Curl in php script.


Add support for Ruby 3.0

Use CGI.escape instead of deprecated URI.escape (#333)
Add more rubies to test matrix

Coverage remained the same at 97.971% when pulling be9459cf057f9b75e4f6672685e998773fb890f6 on stefanahman:ruby-3 into 41990aafa80a0f458e988733189fbf4b07e0894a on moove-it:master.

Anything we can do to help get this merged?

Hi @melvrickgoh,
Would love if you can merge this PR or telling us what blocks you to do it so we can give you help :)
Thanks a lot!

@snmgian is there anything this needs to be merged? Thanks!

I think this is a duplicate of https://github.com/moove-it/sidekiq-scheduler/pull/316.

@stefanahman,
Hi, what is the prediction of the merge of this correction?

@stefanahman,
Hi, what is the prediction of the merge of this correction?

🤷🏻♂ idk, who's maintaining this?

@snmgian Would you please review this and deploy an update?

@gian-zas or @snmgian can you please  review this and deploy an update?

Thanks @stefanahman 🎉

@marcelolx now that Ruby 3 is supported doesn't this warrant a new release, too?

@marcelolx now that Ruby 3 is supported doesn't this warrant a new release, too?

@haffla Yes, we're just running sidekiq-scheduler with master branch in our applications to ensure nothing has been broken. Next week probably we will ship a new release.

@haffla v3.1.0 released!


Continuous open new tab when Configure Internet Explorer integration is set to 1 or 2

[Enter feedback here]
I am getting continuous open new tab when Configure Internet Explorer integration is set to 1 or 2.
I have configure the Enterprise Mode List and save XML and point to it in a share location.
When I click on the link that specify in the XML file. The link will continuous open new tab with the URL non stop.
The only way to stop that is log out and log in again..
This seem like a bug.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e59013ef-aae3-ee84-8bc3-8d2ad0c52e36
Version Independent ID: f4e73402-3baf-a72b-96c5-cee4f04b8298
Content: Configure IE mode Policies
Content Source: edgeenterprise/edge-ie-mode-policies.md
Product: microsoft-edge
GitHub Login: @cjacks
Microsoft Alias: cjacks

https://docs.microsoft.com/en-us/deployedge/edge-ie-mode-policies#configure-internet-explorer-integration
Configure the Enterprise Mode Site List (Microsoft Edge, version 78 or later)
This policy lets you create a separate Enterprise Mode Site list for Microsoft Edge. Enabling this policy overrides the settings in the "Use the Enterprise Mode IE website list" policy, if "Configure Internet Explorer integration" is enabled. Disabling or not configuring this policy doesn't affect the default behavior of the "Configure Internet Explorer integration" policy.

Clean up of old issues.
If you are still having a problem with IE mode, you can get detailed guidance on how to set up Internet Explorer mode through our Getting Started guide or by visiting our IE mode documentation.  Also, you can contact App Assure at https://aka.ms/AppAssure for assistance.


[Bug Fix] New Migration Experience display UI bug

This PR fixes the bug for TDE dialog. Earlier we were opening TDE dialog whenever MI as target was selected. But the experience was discussed to be changed, now TDE dialog will open up only on user click.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 41.574%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePathPage.ts
1
57.02%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
30787

Relevant Lines:
69356

💛  - Coveralls


Ability to add custom socket options

I was looking to do the following code except using nix instead of libc:
use libc::{c_ushort, c_int, c_void, socklen_t, SOL_SOCKET, setsockopt};

const SO_ATTACH_FILTER: c_int = 26;

pub fn attach_filter(fd: RawFd, prog: Prog) -> Result<(), Error> {
    match unsafe {
              setsockopt(fd as c_int,
                         SOL_SOCKET,
                         SO_ATTACH_FILTER,
                         &prog as *const _ as *const c_void,
                         size_of_val(&prog) as socklen_t)
          } {
        0 => Ok(()),
        _ => Err(Error::last_os_error()),
    }
}

However nix currently doesn't support this, which is fine. However, nix doesn't expose an easy way to use it's internal macros to construct the SO_ATTACH_FILTER command. I wanted to file an issue to suggest exposing this. I'll also look into contributing my use case to nix so it's added t the library for future users.
Code source: https://github.com/jedisct1/rust-bpf/blob/0122d0a95e6012abab0475b14cef20dbfa481704/src/bpf_linux.rs#L58

I don't quite understand the issue here as I'm not familiar with setsockopt. Do you have a proposal for how we might integrate this code example that would fit in with the rest of nix? Would exposing sockopt_impl! be enough for you?


[LESSON]

[ ] quiz 1
[ ] written content
[ ] quiz 2
[ ] challenge
[ ] extra reading
[ ] assignment

Perhaps appropriate for discussion boards?


Is it possible to decorate find_each Enumerator object

Hi,
Is there a way to decorate Model.find_each collection? Currently i have to do the decoration in the view.
Cheers.

you can do it here.
https://github.com/drapergem/draper#decorating-individual-elements
if you are doing queries in your view, you are wrong.

@lucianosousa i think you misunderstood what i am trying to do.
def index
  @places = PlaceDecorator.decorate_collection(Place.find_each(batch_size: 10))
end

This doesn't work :disappointed: It loads all places ignoring batch_size in for_each and then decorates them.
More info on for_each here: http://apidock.com/rails/ActiveRecord/Batches/ClassMethods/find_each

I just ran here this find_each method with batch size and it returns all items on my DB, ignoring the batch_size.
It's not a draper problem, seems your query is not right.

That's what i'm saying. It ignores the batch_size. My question was if there was a way to decorate find_each collection in controller while keeping the find_each functionality. Apparently there is no way to do it.


[Actionable Whispers] Missing currency categorizing an expense without updating it

During the investigation of https://github.com/Expensify/App/issues/40266, I noticed that the flows for Categorize/Share also had some of the same issues fetching the modified currency if it wasn't updated. Update the flow and add more tests to verify it doesn't happen to categorized expenses as well

This got un-deployed in the fire fix, but should be deployed next week

Done!


Fix mistakes

Removed duplicated build tag
Removed 'golint' config (replaced by 'revive' linter) https://github.com/mgechev/revive
Changed 'disable-all' option to leave only enabled linters

@denisandreenko Looks like Peter asked an important question about this change that hasn't been answered. I'm trying to clean up stale PRs my getting them merged or closing them. Is this still needed? If not, or if there's no more on this PR. I'm going to close it after some time. Thanks!

@nguyer let's close it. Thanks


build errors related to cmath

After generating a build directory by running this command:
cmake -DTARGET_ARCH=ANDROID -DNDK_RELEASE=r13b -DANDROID_NATIVE_API_LEVEL=21 -DBUILD_ONLY="cognito-identity;access-management;iam" -DANDROID_ABI=mips64 -Wno-dev ../deps/aws-sdk-cpp/

I run "make" and get these errors:
[ 22%] Building CXX object aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/external/json-cpp/jsoncpp.cpp.o
In file included from /Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3073:
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:313:9: error: no member named 'signbit' in the global namespace
using ::signbit;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:314:9: error: no member named 'fpclassify' in the global namespace
using ::fpclassify;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:315:9: error: no member named 'isfinite' in the global namespace
using ::isfinite;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:318:9: error: no member named 'isnormal' in the global namespace; did you mean '__isnormal'?
using ::isnormal;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/sysroot/usr/include/math.h:186:5: note: '__isnormal' declared here
int     __isnormal(double)  __pure2;
        ^
In file included from /Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3073:
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:319:7: error: no member named 'isgreater' in the global namespace; did you mean '::std::greater'?
using ::isgreater;
      ^~
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/functional:709:30: note: '::std::greater' declared here
struct _LIBCPP_TYPE_VIS_ONLY greater : binary_function<_Tp, _Tp, bool>
                             ^
In file included from /Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3073:
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:320:7: error: no member named 'isgreaterequal' in the global namespace; did you mean '::std::greater_equal'?
using ::isgreaterequal;
      ^~
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/functional:738:30: note: '::std::greater_equal' declared here
struct _LIBCPP_TYPE_VIS_ONLY greater_equal : binary_function<_Tp, _Tp, bool>
                             ^
In file included from /Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3073:
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:321:9: error: no member named 'isless' in the global namespace
using ::isless;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:322:9: error: no member named 'islessequal' in the global namespace
using ::islessequal;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:323:9: error: no member named 'islessgreater' in the global namespace
using ::islessgreater;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:324:9: error: no member named 'isunordered' in the global namespace
using ::isunordered;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/bin/../lib/gcc/mips64el-linux-android/4.9.x/../../../../include/c++/4.9.x/cmath:325:9: error: no member named 'isunordered' in the global namespace
using ::isunordered;
      ~~^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3175:7: error: expected unqualified-id
  if (IS_FINITE(value)) {
      ^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/aws-cpp-sdk-core/source/external/json-cpp/jsoncpp.cpp:3101:24: note: expanded from macro 'IS_FINITE'
#define IS_FINITE std::isfinite
                       ^
/Users/christophersimmons/Documents/repos/DoclilyAndroid/deps/aws-sdk-cpp/toolchains/android/mips64l-standalone-clang-21-libc++_shared-13002/sysroot/usr/include/math.h:91:5: note: expanded from macro 'isfinite'
    ((sizeof (x) == sizeof (float)) ? __isfinitef(x)    \
    ^
12 errors generated.
make[2]: *** [aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/external/json-cpp/jsoncpp.cpp.o] Error 1
make[1]: *** [aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/all] Error 2
make: *** [all] Error 2

I did some googling, and I think that these errors may be the result of not linking to the cmath library, which, I believe, is done by passing "-lm" as a CXXFLAG; however, I would expect CMake to handle this problem when it generated the makefiles. I'm on OS X and trying to build the SDK so that I can link to it from the CMakeLists.txt in an Android Studio project. Any help would be appreciated.

That doesn't appear to be a linking issue.  The Android build is currently broken although not in a way that matches what you have here.  I will try and resolve these problems over the next few days.

I've looked into this a bit further.  This problem doesn't happen prior to NDK 13, so if you're able to use an earlier NDK, that at least represents a temporary workaround.  In the meantime, I will see what I can do with NDK13 to make things happy.

This should be fixed with yesterday's release

Thanks; the errors are gone on my end.


Coloring issue in .Less file

VSCode Version:
OS Version:

Steps to Reproduce:

Copying from:
https://github.com/Microsoft/TypeScript-TmLanguage/issues/492#issuecomment-329407436

I've only noticed this happening today, so I'm not sure if the latest VSCode update has introduced this bug (I'm running 1.14.0).

@sheetalkamat I'm able to reproduce this anywhere the cursor property is defined.

Create a file with the .less extension or change the language to LESS.
Use the following CSS:

div {
  cursor: pointer;
  color: tomato;
}

This is the result I'm seeing (I'm now using 1.16.0):

This does not apply to files marked as using the CSS language, only LESS.

Reproduces without extensions: Yes/No

This issue was moved to atom/language-less#79


SSO connection reset

Few times a day, when trying to access github.com/Seagate, I am getting

Following the link gets me to

which after some time results in

The only known way to fix this is by following a little dance of clearing all browser cookies for ssologin.seagate.com.
I have Seagate VPN active, all other services work fine.

Now that we are open source if we remove you from the Seagate org then you won't need SSO anymore. FWIW I also see this issue

[...] if we remove you from the Seagate org then you won't need SSO anymore.

@justinzw What are the side effects of being removed from Seagate GitHub org?


Added description of sample JSON message format for Android and iOS to PAYLOAD.md

Description

I'm quite new to cordova and push notifications and it took me quite some time to figure out how the message / payload formats should be for the different platforms. So I started adding some sample json to the PAYLOAD.md as I think this is the place I would have looked for this.
I started writing in my fork, see https://github.com/teambits/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#message-format-overview
Related Issue

https://github.com/phonegap/phonegap-plugin-push/issues/2305
Motivation and Context

Well, I think it's easier to get started using PN :smile:
How Has This Been Tested?

Well, I pasted some of the sample JSON to the SNS web UI to see if it's really working.
But I didn't do any other kind of test yet such as having someone else read all this.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks for this! We've been needing such a section for a while now.

I also think we could use a section dedicated to FCM on iOS, as the data structure is certainly at odds with the APNS one.

@fredgalvao WRT FCM, I have no experience with this myself (yet), so I can't contribute here.

@ptandler I'm going to merge this then make one quick change as even though some of your examples should be json the comments in it show up in red as they are not valid json. I'll just switch the code blocks to javascript to make the syntax highlighting nicer.

@macdonst thanks for merging and fixing the syntax highlighting


Using zero3 on multiple nodes is slow

I have multiple nodes, each with 8 40G A100, and I want to train a 72B model
When using zero3, the 72B model is distributed to all GPUs of all nodes. Even with nvlink, the communication delay is still very high, resulting in slow training speed, much slower than using zero3+offloading for a single node. The problem is that the more nodes there are, the slower the training speed. It is better to use only a single node
Is there a way to control zero3 to only allocate model parameters to the same node, where each node stores a complete model and only uses synchronous gradients between nodes to speed up training

@HelloWorld506, you can try the hpz feature of ZeRO++ if it fits your scenario.

it works, thank you!


How do I use this?

How do I use this? Can you provide titles, navigation, etc by default? I found a modified version that works well out of the box, except for the poor zoom on the small screen. Can you improve it in this direction? Much appreciated!

hank you


Update documentation for static files around recursive nature

fix #795
Type of Issue

[ ] :bug: (bug)
[x] :book: (Documentation)
[ ] :arrow_up: (Update)
[ ] :dizzy: (New Feature)
[ ] :radioactive: (Deprecation)
[ ] :no_entry_sign: (Removal)
[ ] :hammer_and_wrench: (Refactor)

Changes have been Documented (If Applicable)

[x] YES - Changes have been documented

Changes have been Tested

[x] YES - Changes have been tested

Next Steps

@john0isaac what do you think? I don't see a need for the word change on this?

@kjaymiller I agree with you the change is just more words that conveys the same meaning. Which is not needed.


No two times . For the 10 time already.

Charging

I fear to don't understand 😬

One time is one time . No two times . No three times. ect.


”Lupuiești , ”Păsărei”, ”Pertești”, ”Pleșești” are listed in the drop-down menu

Description:
When user writes ”Lupuiești , ”Păsărei”, ”Pertești”, ”Pleșești” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Lupuiești "

Expected results
The location appears in the drop-down menu as "Sat Lupuiești , VÂLCEA (Roșiile)".

Step 3
Write in the search bar "Păsărei"

Expected results
The location appears in the drop-down menu as "Sat Păsărei, VÂLCEA (Roșiile)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Pertești"

Expected results
The location appears in the drop-down menu as "Sat Pertești, VÂLCEA (Roșiile)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Pleșești"

Expected results
The location appears in the drop-down menu as "Sat Pleșești, VÂLCEA (Roșiile)".


Add promises improved example

This PR needs to be rebased before merging. Changes are good, though.


[Python] Add authentication links to Getting Started instructions

What:
Add more authentication links to http://pythonhosted.org/gax-google-pubsub-v1/starting.html#authentication:

Application Default Credentials
Also gcloud-python has excellent auth documentation

Why:
So that users can understand how authentication works.
How:
This is controlled by  templates/gax/python/docs/starting.rst.mustache.

Note: in link  http://pythonhosted.org/gax-google-pubsub-v1/starting.html#authentication, the third code block (to gcloud beta auth application-default login) is broken


Marked material_components for deprecation.

Description
See #504.

Adds deprecation doc strings
Started a migration page to describe the deprecation and the need for it.
Raised deprecation warnings with Material.material_components is accessed.

Fixes #506
Checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation (if applicable)
[x] I have added tests that prove my fix is effective or that my feature works (if applicable)

Should we switch from the term: Isotope to Nuclide? This is the terminology used by MCNP, and is meant to be all encompassing or isotopes, metastable isomers, and atomic data. For once I think I agree with their terminology.

Yes. Nuclide is better for every reason.


Inexplicable Error: (XAMPP) Composer Error [ERR_DOWNLOAD]: Composer was not downloaded

I just downloaded and tried to install, and this is the only message I got.  I can't what the issue is because I don't really know what the problem is.  If there could be more specificity in the error message as to what the real problem is, that would help solve the issue.  I wish I didn't have to request a fix here, but this isn't quite my area of expertise. Running windows 8.1

This has been fixed in v4.1.0, which recognizes common PHP config errors and displays all output.


npm package is out of date by 4 years

Hi,
The NPM package from here https://www.npmjs.com/package/summernote-cleaner is out of date by 4 years now.
When we follow the github link from npmjs it ends up to this repository even if the link itself is different on npmjs (https://github.com/StudioJunkyard/summernote-cleaner)

Thanks for bringing this to my attention. I didn't create or maintain NPM stuff for the plugin, whoever created that for that support would have to update information there to reflect current information.

@DiemenDesign how about adding a github action and create an official version then?

@DiemenDesign how about adding a github action and create an official version then?

In the meanwhile you can use:
npm install https://github.com/DiemenDesign/summernote-cleaner

In the meanwhile you can use:
npm install https://github.com/DiemenDesign/summernote-cleaner

I don't use NPM, probably too old skool, lol. I'm open to adding to the repo any PR's to facilitate this, as I don't know much about NPM and how to add projects too it.

I don't use NPM, probably too old skool, lol. I'm open to adding to the repo any PR's to facilitate this, as I don't know much about NPM and how to add projects too it.