remove duplicate procedures

In a Quick Start guide, it goes against technical writing best practices to implement duplicate procedures without a known benefit. (Please correct me if there is one.) These add to its maintenance and the likelihood of becoming out-of-sync. @ankedia advised me that copy & paste is easier for users, so I removed the procedural duplicate curl commands to download the files in two instances. From discussions with @tbarnes-us, I know he doesn't agree. NOTE: I kept the curl command to download the sample domain YAML file because there was no other way for users to view or modify it, if needed.

Yes, you are correct about my thoughts. In my opinion, the procedures are not duplicate and instead are convenient alternates for those that may want to edit the files.  Also, in the 'summary' edit, note that cutting and pasting is error prone and can be fairly tedious/problematic on some terminal setups.


Add name and message to DOMException

Follow up to https://github.com/google/closure-compiler/issues/3266

Created Google internal issue b/128707092. Imported for internal review and testing.

Thanks!


Regex email validation passing a invalid email ended with dot

[x] I have looked at the documentation here first?
[x] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
latest (10.6.1) v10
Issue, Question or Enhancement:
Regex e-mail validation passing with e-mail finishing with . (dot)
email like<EMAIL_ADDRESS>should be invalid, but is considered valid.
Code sample, to showcase or reproduce:
https://play.golang.org/p/_i5b90oTmpp

I think that a trailing . may well be allowed in a hostname - please see the hostname man page https://man7.org/linux/man-pages/man7/hostname.7.html

If the input name ends with a trailing dot, the trailing dot is removed, and the remaining name is looked up with no further processing.

I think that a trailing . may well be allowed in a hostname - please see the hostname man page https://man7.org/linux/man-pages/man7/hostname.7.html

The referenced manual use the RFC1123, in cap. 5 the RFC2822 as the standford for e-mail validation. For references, the regex validation for e-mail in Perl (https://github.com/basecamp/mail)) uses the RFC2822 (http://www.ex-parrot.com/pdw/Mail-RFC822-Address.html) who defined a e-mail like<EMAIL_ADDRESS>as a invalid e-mail address (https://sphinx.mythic-beasts.com/~pdw/cgi-bin/emailvalidate)

For reference, mail.ParseAddress currently fails to parse address ending with a dot.
Another difference between validator and mail.ParseAddress is for addresses containing two dots in the hostname like<EMAIL_ADDRESS>See https://go.dev/play/p/L5e2v9mE7Xg
IMO, validated email addresses should work with mail.Address().

You can override the default email validator until this is fixed.
func init() {
        err := v.RegisterValidation("email", validateEmail)
        if err != nil {
                panic("unable to register " + name)
        }
}

// use a custom email validator to reject email address not parsable by mail.ParseAddress
// https://github.com/go-playground/validator/issues/784
func validateEmail(fl validator.FieldLevel) bool {
        val := fl.Field().String()
        res, err := mail.ParseAddress(val)
        if err != nil {
                return false
        }
        // we don't want to accept email address with Name
        // e.g. "Barry Gibbs<EMAIL_ADDRESS>        if res.Name != "" {
                return false
        }
        return res.Address != ""
}

I currently using referenced perl regex at email validation, but I will follow this to update validator when fixed. Thanks for the override example, much more readable them perl regex haha

I currently using referenced perl regex at email validation, but I will follow this to update validator when fixed. Thanks for the override example, much more readable them perl regex haha

Is this issue still being followed up?


Allow nested object to be nil

See https://github.com/fstech/crm/pull/220 for a use case

You're right @dawidpawliszko I've chagned the behaviour to return nil


Website marked as dangerous

I don't know why but this appears each time that I use the webpage

website: https://minhaskamal.github.io/DownGit/#/home

Seems Google falsely marked DownGit as harmful again #31
@ZurMaD Thanks for reporting this issue. Please use the mirror site for now- https://downgit.github.io

BTW, this is still happening. The link on the main DownGit page has this problem. Anyway, thanks for the mirror site!

BTW, this is still happening. The link on the main DownGit page has this problem. Anyway, thanks for the mirror site!

using this https://minhaskamal.github.io/DownGit/#/home
and windows defender found a trojan


remove src/, depend on Octave >= 4.2.0

I thought I'd filed an issue for this, but don't see it.
At some point, we should drop src/ because Octave 4.2.0 has built-in evalc.

Good for me.


App crashes on trying to upload a media directly from camera.

Summary:
On selecting a image clicked from the camera for upload, the app crashes.
Steps to reproduce:
• Click on the + (floating action button) icon in contributions tab.
• Select camera from there.
• Click a photo and select that photo.
• App will crash there.
System logs:
2021-02-17 15:44:31.801 16499-16499/fr.free.nrw.commons.beta E/AndroidRuntime: FATAL EXCEPTION: main
    Process: fr.free.nrw.commons.beta, PID: 16499
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String fr.free.nrw.commons.contributions.MainActivity$ActiveFragment.name()' on a null object reference
        at fr.free.nrw.commons.contributions.MainActivity.onSaveInstanceState(MainActivity.java:238)
        at android.app.Activity.performSaveInstanceState(Activity.java:2088)
        at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1486)
        at android.app.ActivityThread.callActivityOnSaveInstanceState(ActivityThread.java:5419)

Device and Android version:
Redmi Note 7S (Android 10)
Commons app version:
betaDebug master (3.0.0-debug-master~7cb5ff916)
Screenshots
https://user-images.githubusercontent.com/65870389/108192667-8f3b4480-713a-11eb-9e13-d450de27d5a1.mp4
Would you like to work on the issue?
Yes, I want to work on this issue.

I can't reproduce on latest master... is this still happening for you on latest master?

@nicolas-raoul Yes, I am facing it on latest master. Tested just now for confirmation and getting the same exception °-°

Anyone who feel interested with this issue please make sure you followed the discussions at #4239

Closing as this can't be reproduced on the current master.
If there is a specific procedure to reproduce this on the current master
Please feel free to reopen this @mrudultora.


Typo with the RecyclerView usage Readme

You currently have the documentation on the Usage Read.me incorrect for the RecyclerView.
It is currently :
final SwipeToDismissTouchListener touchListener =
new SwipeToDismissTouchListener
It should be :
final SwipeToDismissTouchListener touchListener =
new SwipeToDismissTouchListener<>
Otherwise this is fantastic man! great job.

This is what you have in the sample and it works just need to alter the Read.me file
    final SwipeToDismissTouchListener<RecyclerViewAdapter> touchListener =
            new SwipeToDismissTouchListener<>(
                    new RecyclerViewAdapter(recyclerView),
                    new SwipeToDismissTouchListener.DismissCallbacks<RecyclerViewAdapter>() {
                        @Override
                        public boolean canDismiss(int position) {
                            return true;
                        }

                        @Override
                        public void onDismiss(RecyclerViewAdapter recyclerViewAdapter, int position) {
                            mAdapter.remove(items.get(position);
                        }

                    });

Thanks a lot, the markdown preview was doing something wrong. It's fixed now!


Option to disable animations

At the moment the way to make the charts responsive is to redraw them. That happens also when there's some change.
The problem is that each time the whole chart gets a "loading" animation that draws it and it might be useless after the initial creation.
Expected Behavior
Have a way to redraw the chart without extra distractions, show the chart ASAP.
Current Behavior
Each time that the chart is created it always use a "loading" animation starting from 0 to max

HI @AlfonsoML , thanks for the issue!
That's a totally legit request, not the first time I think about it!
It should be pretty straightforward to add an accessor to stop the animation, so that when we redraw the chart, we set to not animate and get the desired outcome.
Thanks a lot!

Fixed on #257


cuckoo_cam is a dcp built on xcvu9p-flga2104-2L-e

What is cuckoo_cam?
It is a checkpoint built on xcvu9p-flga2104-2L-e now. Is it possible to build it to other cards?
If it can also be generated by tcl or source RTLs that makes things more easier.
Thanks.

CuckooCAM is a Content Addressable Memory based on the cuckoo hashing and other few improvements. It is used to convert an incoming three tuples to a unique ID. Maybe Figure 1 here gives a better understanding.
What board are you interested in? I could provide a dcp for that particular FPGA.

Oh, xcvu37p-fsvh2892-2-e
I just realized that this dcp still passed the synthesis even the fpga_part has been changed to vu37p.
Maybe because it is just a synthesized netlist?
Please hold on and really appreciated.

The current dcp should implement in any VirtexUltrascale+ except on VirtexUltrascale+ HBM.
Yes, it is a synthesized netlist for a family of devices.
The plan is to release the code, but there are some improvements to be done and more experiments.

Thanks Mario

Is there any plan to relase the code?
I realized although the bitstream was written,  there were  some bad timing paths around cuckoo_cam. I don't know whether this is the cause that I still didn't get rx_aligned.

Hi @luyong6,
There is no plan to release the code at the moment.
This should not cause problems with the alignment, but I can be related.
Where are you connecting the FPGA to test link?

Oh,
According to UG203 (Version 3.1,  June24 2020)

I modified the FSM sequence in submodules/cmac/src/cmac_sync/cmac_0_axi4_lite_user_if.v
189                 STATE_INIT_RX_ALIGNED    : begin
190                      rx_busy_led_r           <= 1'b1;
191                      init_rx_aligned         <= 1'b1;
192
193                     case (rd_wr_cntr)
194                         'd0     : begin
195                             $display( "           AXI4 Lite Write Started to Config the Core CTL_* Ports ..." );
196                             axi_wr_data             <= 32'h00000001;           //// ctl_rx_enable
197                             axi_wr_addr             <= ADDR_CONFIG_RX_REG1 + SLAVE_CMAC_BASEADDR;    //// CONFIGURATION_RX_REG1
198                             axi_wr_addr_valid       <= 1'b1;
199                             axi_wr_data_valid       <= 1'b1;
200                             axi_wr_strobe           <= 4'hF;
201                             axi_rd_req              <= 1'b0;
202                             axi_wr_req              <= 1'b1;
203                         end
204                         'd1     : begin
205                             axi_wr_data             <= 32'h00000010;          //// ctl_tx_send_rfi, according to pg203, Version June 24, 2020
206 //                            if (ULTRASCALE_PLUS==0)
207 //                                axi_wr_data             <= 32'h00000010;          //// ctl_tx_send_rfi
208 //                            else
209 //                                axi_wr_data             <= 32'h00000018;          //// ctl_tx_send_lfi, ctl_tx_send_rfi
210                             axi_wr_addr             <= ADDR_CONFIG_TX_REG1 + SLAVE_CMAC_BASEADDR;   //// CONFIGURATION_TX_REG1
211                             axi_wr_addr_valid       <= 1'b1;
212                             axi_wr_data_valid       <= 1'b1;
213                             axi_wr_strobe           <= 4'hF;
214                             axi_rd_req              <= 1'b0;
215                             axi_wr_req              <= 1'b1;
216                         end

However, the rx_aligned seemed not get assigned. So I think this FSM was stuck in waiting for it.
I was using Vivado 2020.1, on a device with vu37p device.
The xdma driver was successfully loaded. Some information:
 sudo ./bin/reg_rw  /dev/xdma0_user 0x24
...
Read 32-bit value at address 0x00000024 (0x7f275c71c024): 0x00000301   CMAC subsystem version is correct: 3.1

sudo ./bin/reg_rw  /dev/xdma0_user 0xC
...
Read 32-bit value at address 0x0000000c (0x7f430b82200c): 0x00000010  (This means ctl_tx_send_rfi)
sudo ./bin/reg_rw  /dev/xdma0_user 0x14
Read 32-bit value at address 0x00000014 (0x7fde06d05014): 0x00000001 (This means ctl_rx_enable)
sudo ./bin/reg_rw  /dev/xdma0_user 0x204
Read 32-bit value at address 0x00000204 (0x7f651d54a204): 0x000000c0 (stat_rx_local_fault, stat_rx_internal_local_fault)

The same card, if I don't use AXI4Lite interface to configure the CMAC but directly assign ctl_tx_enable/ctl_rx_enable,
with a 100G cable connecting to a Mellanox CX4 card, it had rx_aligned, and CX4 card also said "Link UP".

@luyong6 the bring up sequence change slightly. But, I am using the same code with Vivado 2020.1 and it is working. The fact that you can link up writing the registers from the host means that something is not working properly in the interconnection between the cmac_synq and cmac.
How is lbus_tx_rx_restart_in connected?
My block design is exactly this one
Maybe you can generate the example design for the CMAC with AXI4-Lite and check the code.

Hi,
I want to port the design to a kintex device any chance you release de code ? or provide a .dcp for the kintex ?
Thx

Hi,
We are not planning to release the code in the short-term.
Kintex 7 or Kintex US(+), if the latter it should work. If the former, you should check ETH implementation, they have support for series 7. https://github.com/fpgasystems/fpga-network-stack
At this point I will be difficult to provide the dcp. I will try though.
Mario

Hello. I can't add the cuckoo_cam.dcp into the project vcu118_fns_single_toe_iperf. The error message is: '../cuckooCam/cuckoo_cam.dcp' is not a valid design checkpoint. Could you upload the correct file again?
Thanks.

does the cuckoo_cam.dcp file exist? what it is its size?
The file is staged with git lfs, and maybe you did not pull it from the repo.


Organization Roles Settings

This implements the new roles management UX. It is very unstyled, but is tested and the interactions are correct.

Followup tickets after this is merged:

Test error reporting on the organization/roles page (#248)
Style this page (#249)

:+1:  Awesome work guys

@mixonic Good to merge?

@sandersonet so good :-)


OTel Q&A with Dan Ravenstone - Create promo image for socials

[ ] create a promo image for socials

Dan's LinkedIn profile: https://www.linkedin.com/in/daniel-ravenstone-170b78/
Related: #61, #62, #63, #64, #65

From @reese-lee:


How to combine the following two together

How to combine the following two together？
$(".ui.dropdown").dropdown('set selected', 5);
$(".ui.dropdown").dropdown({
    onChange: function(value) {
      var name = $(this).eq(0).attr('name');
      srcuritySetting(name, value, 'on');
    }
  });

Hi @yangjianyi, if I understood you correctly:
$('.ui.dropdown')
  .dropdown({
    onChange: function(value) {
      var name = $(this).eq(0).attr('name')
      srcuritySetting(name, value, 'on')
    }
  })
  .dropdown('set selected', 5)

If I didn’t, please elaborate on your question, what’s the problem exactly?
In any case, thank you for posting, but although it’s a valid usage question, we’ve limited GitHub Issues to bug reports and feature requests, keeping the board more manageable for maintainers; see the contributing guidelines for more information on what kind of posts should find themselves into the GitHub Issues board.
To get answers or feedback that might allow you to repost this issue, please use one of our other support resources:

Gitter chatroom
Official forums
StackOverflow


Yatin: Watch heenaescortservice.com

Yatin requests the watch of the watch_keyword heenaescortservice\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

heenaescortservice\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Re-organaize namespace for each Masakari process

All 4 processes use different namespace for a directory and these process name. All process should be under masakari/* namespace to easy to maintenance and to operate.

closed by #9


add init from seed to uninitialized wallet screen

This PR adds the ability for users to initialize their wallet from a seed, on the uninitialized wallet screen

If you init from seed, do you need a password, or are you setting a password?

You can optionally provide a password (I tried to show that behavior in the screenshots) using the checkbox

Ah. Text should be 'Desired Password'

/init/seed can take a long time, this needs longer timeouts and some status feedback. Working on that now

Should be ready now

Looks good but perhaps could use some more description. Users should understand that init-from-seed has to scan the whole blockchain, so it's slow and requires you to be synced.

updated with some text:


"Make error" on centos 6

Describe the bug
make
...
 /bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I.  -std=c++11 -I.. -g -I../others -fPIC -O3 -I../headers -DWITH_CURL -DWITH_GEOIP -I/usr/include     -I/usr/include  -DWITH_SSDEEP -I/usr/include  -DWITH_LUA -DWITH_LUA_5_1 -I/usr/include -I/usr/include/libxml2 -DWITH_LIBXML2   -g -O2 -MT utils/libmodsecurity_la-regex.lo -MD -MP -MF utils/.deps/libmodsecurity_la-regex.Tpo -c -o utils/libmodsecurity_la-regex.lo `test -f 'utils/regex.cc' || echo './'`utils/regex.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -std=c++11 -I.. -g -I../others -fPIC -O3 -I../headers -DWITH_CURL -DWITH_GEOIP -I/usr/include -I/usr/include -DWITH_SSDEEP -I/usr/include -DWITH_LUA -DWITH_LUA_5_1 -I/usr/include -I/usr/include/libxml2 -DWITH_LIBXML2 -g -O2 -MT utils/libmodsecurity_la-regex.lo -MD -MP -MF utils/.deps/libmodsecurity_la-regex.Tpo -c utils/regex.cc  -fPIC -DPIC -o utils/.libs/libmodsecurity_la-regex.o
utils/regex.cc: In member function ‘bool modsecurity::Utils::Regex::searchGlobal(const string&, std::vector<modsecurity::Utils::SMatchCapture>&) const’:
utils/regex.cc:150:28: error: ‘PCRE_NOTEMPTY_ATSTART’ was not declared in this scope
             **pcre_options = PCRE_NOTEMPTY_ATSTART | PCRE_ANCHORED;
                            ^~~~~~~~~~~~~~~~~~~~~
utils/regex.cc:150:28: note: suggested alternative: ‘PCRE_NOTEMPTY’
             pcre_options = PCRE_NOTEMPTY_ATSTART | PCRE_ANCHORED;
                            ^~~~~~~~~~~~~~~~~~~~~
                            PCRE_NOTEMPTY**
make[3]: *** [Makefile:3221: utils/libmodsecurity_la-regex.lo] Error 1
make[3]: Leaving directory '/home/ModSecurity/src'
make[2]: *** [Makefile:3473: all-recursive] Error 1
make[2]: Leaving directory '/home/ModSecurity/src'
make[1]: *** [Makefile:1218: all] Error 2
make[1]: Leaving directory '/home/ModSecurity/src'
make: *** [Makefile:1029: all-recursive] Error 1

utils/regex.cc:150:28: error: ‘PCRE_NOTEMPTY_ATSTART’ was not declared in this scope
             **pcre_options = PCRE_NOTEMPTY_ATSTART | PCRE_ANCHORED;
                            ^~~~~~~~~~~~~~~~~~~~~
utils/regex.cc:150:28: note: suggested alternative: ‘PCRE_NOTEMPTY’
             pcre_options = PCRE_NOTEMPTY_ATSTART | PCRE_ANCHORED;
                            ^~~~~~~~~~~~~~~~~~~~~
                            PCRE_NOTEMPTY**

Info
gcc version 8.3.1 20190311 (Red Hat 8.3.1-3) (GCC)
OS - Centos 6.8
scl enable devtoolset-8 bash
git clone --branch v3/master
On ubuntu assembled without problems. On centos 6 - problems

fix : scl enable devtoolset-2 bash
and new error
Centos 6
utils/geo_lookup.cc: In member function ‘bool modsecurity::Utils::GeoLookup::lookup(const string&, modsecurity::Transaction*, std::function<bool(int, const std::basic_string<char>&)>) const’:
utils/geo_lookup.cc:131:78: error: invalid conversion from ‘const MMDB_s*’ to ‘MMDB_s*’ [-fpermissive]
         r = MMDB_lookup_string(&mmdb, target.c_str(), &gai_error, &mmdb_error);
                                                                              ^
In file included from ../src/utils/geo_lookup.h:22:0,
                 from utils/geo_lookup.cc:25:
/usr/include/maxminddb.h:186:33: error:   initializing argument 1 of ‘MMDB_lookup_result_s MMDB_lookup_string(MMDB_s*, const char*, int*, int*)’ [-fpermissive]
     extern MMDB_lookup_result_s MMDB_lookup_string(MMDB_s *const mmdb,
                                 ^
make[3]: *** [Makefile:3179: utils/libmodsecurity_la-geo_lookup.lo] Error 1

Hi @065191 ,
For the first of the two issues that you report, my guess is that your version of pcre is sufficiently out of date that that constant is not defined.  I believe the relevant package for CentOS is pcre-devel.

pcre-devel

Package pcre-devel-7.8-7.el6.x86_64 already installed and latest version

Hi @065191 ,
From this source: https://www.pcre.org/original/changelog.txt ...
PCRE_NOTEMPTY_ATSTART
... was added to pcre in version 8, which is later than yours.  Version 8.00 itself is already very old.  If the 7.8 version of pcre that you have is the most recent available via repo, that may be because CentOS 6.8 itself is past end-of-life.
I would suggest upgrading to a supported version of the OS.  If for some reason you need to stick with that, you could try upgrading your pcre version manually.

cd /opt
wget https://ftp.pcre.org/pub/pcre/pcre-8.44.tar.gz
tar -xvzf pcre-8.44.tar.gz
cd pcre-8.44
./configure
make
make install

PCRE_NOTEMPTY_ATSTART
@martinhsv It seems this would be used only for rxGlobal, introduced in 2672db103e511cbf0866efc62dc7a3b4f43a8657.
Could you give a reference / documentation for rxGlobal?

Just found.
https://www.trustwave.com/en-us/resources/blogs/spiderlabs-blog/modsecurity-regular-expressions-and-disputed-cve-2020-15598/
and https://github.com/SpiderLabs/ModSecurity/pull/2396

How about this error: "geo_lookup.cc:131:78: error: invalid conversion from ‘const MMDB_s*’ to ‘MMDB_s*’"?
I have the same issue and can't find the cause.
@065191  were you able to solve it?

@rtomaf I encountered the error too while compiling on a CentOS7. Upon further digging I found the problem being tracked in #2254.
Solution is either disable maxminddb for versions of maxmind < 1.4.2 and modsecurity > 3.0.4 or upgrade/downgrade accordingly.


Remove unused member from DateAddFunction class

The SubDayStringList field is not used anywhere, can be removed.

✅ No public API change.


filter out literal wildcard when deploying an unrelated domain. closes #1185

Filtering out the literal strings that start with *. seemed to be the simplest fix here.
@lmars @josegonzalez @vincentfretin

Seems legit to me. Does this work for you @lmars ?

LGTM


Pub/Sub Message#published_at

This PR adds Message#published_at, which was missing. It is also setting this value on messages when they are published. Messages pulled from the API will have this attribute populated.

It looks to me that publish_time is being set to Time.now by the publisher.

It is, but it is set after the message has been published.

Currently this PR has a second commit that will set the published_at value on messages to the current time after the messages have been published. This is because the PublishResponse value returned from the API does not have this value. The only API that returns messages with this value is Pull.
I don't know for sure this is wise. I can see it being helpful, but I can also see it being confusing. Thoughts?

Also, is it possible to add an assertion demonstrating the presence of a non-nil publish_time in an existing acceptance test?

I've updated the acceptance tests to check for the presence of published_at.

I think it is a bit misleading since the real value is the one set by the server…

Okay, removing the commit from the PR...


Attribute routing for REST APIs vs UseEndpoints

In the Attribute routing for REST APIs section (https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/routing?view=aspnetcore-6.0#attribute-routing-for-rest-apis) there is a sentence "In the preceding code, MapControllers is called inside UseEndpoints to map attribute routed controllers.".  This sentence makes no sense in relation to the example as there is no call to UseEndpoints.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ee6ad2f-1667-8d5c-1f36-9d0511e3720f
Version Independent ID: 7838ccec-c8e8-9baa-2b3e-220b2af5fc58
Content: Routing to controller actions in ASP.NET Core
Content Source: aspnetcore/mvc/controllers/routing.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hi @demvin. Thanks for reporting this. It looks like the text wasn't updated with the 6.0 code changes.


Clean up unused dependencies

Used depcheck to flag unused dependencies in hub, wallet.
Manually removed dependencies that are not used. There are some dependencies that might be false positives (flagged as unused by depcheck by actually used by the package). For wallet, I skipped those.
Abandoned removing @types dependencies as those are hopefully lightweight and will probably be added back by typesync anyways.

3. Abandoned removing @types dependencies as those are hopefully lightweight and will probably be added back by typesync anyways.

Unused @types packages got removed anyway!


Remove flores notebook from the automatically checked notebook.

Reason: it seems that torchdata is not maintained anymore (source) and it fails with torch versions in [2.1, 2.2, 2.3].
@mkuchnik FYI, we excluded the notebook from the GitHub Actions because it has been failing in the last >2 weeks. We unsuccessfully tried to fix the versions, probably you'll know better. Thanks!

(Failing non hermetic tests due to OpenML API)


Verification and Signing Keys Bug

Greetings!
I'm trying to sign a transaction with keys I got from an HDWallet. I need to sign it with stake and spend (payment) keys. So I get vkeys like (wallet is HDWallet object):
Stake:
hdwallet_stake = wallet.derive_from_path("m/1852'/1815'/0'/2/0")
stake_public_key = hdwallet_stake.public_key
stake_vk = StakeVerificationKey.from_primitive(stake_public_key)
Spend:
hdwallet_spend = wallet.derive_from_path("m/1852'/1815'/0'/0/0")
spend_public_key = hdwallet_spend.public_key
spend_vk = PaymentVerificationKey.from_primitive(spend_public_key)
The vkeys I got above are exactly the ones I need (their hashes are the same hashes that can be found in the RequiredSigners of a transaction)
After that I get signing keys:
spend_sk = SigningKey.from_primitive(spend_public_key)
stake_sk = SigningKey.from_primitive(stake_public_key)
Signing transaction with this set of keys results in InvalidWitnessUTXOW error on submit.
I tried to get back vkeys from skeys to compare it:
spend_vk_2 = PaymentVerificationKey.from_signing_key(spend_sk)
stake_vk_2 = StakeVerificationKey.from_signing_key(stake_sk)
spend_vk and spend_vk_2 as well as stake_vk and stake_vk_2 hashes are completely different.
I've tried to change Signing key to extended version or to StakeSigningKey/PaymentSigningKey and to me it didn't make any changes.
I would also like to get in touch with Jerry, if it's possible, to ask a few questions about cardano and this library as well as kindly ask for a helping hand with one of my projects.
I can give all the needed information.
Thanks in advance!

Hi @bluekapo , have you tried creating your vkeys from ExtendedVkey classes?
spend_vk_2 = PaymentExtendedVerificationKey.from_signing_key(spend_sk)
stake_vk_2 = StakeExtendedVerificationKey.from_signing_key(stake_sk)

If a signing key is extended, its vkey has to been created from extended vkey class.

Thanks for help and sorry for the late response, I was a bit busy. @cffls I tried this before posting the bug, but it didn't help. Just had to restart the whole system. I have no clue what that was. For everyone that will happen to have the same bug: just use extended keys.

Thanks for the update @bluekapo. Extended keys are supposed to work. Will try to create a test case for it.


Added logLevel to programmatic access

This is an extended version of https://github.com/webdriverio-community/wdio-electron-service/pull/852 that also adds the logLevel.
I added it as PR to illustrate my comment on https://github.com/webdriverio-community/wdio-electron-service/issues/856.

You can use WDIO_LOG_LEVEL to change the log level for WDIO logs.  The service also uses debug for its own (very verbose) debug logging: https://github.com/webdriverio-community/wdio-electron-service/blob/main/docs/common-issues-debugging.md


Threads setting typing

The changes to collectfast.settings merged in #173 state that the COLLECTFAST_THREADS setting should be of type bool, while the readme gives an example in which they are of type int, which is also what multiprocesses.Pool() expects in https://github.com/antonagestam/collectfast/blob/fc3ebab9e11e857d0068696d9781f167ec911766/collectfast/management/commands/collectstatic.py#L73

Good find, settings.threads should indeed be int and its default should be 0 instead of False. I should have probably added a few test cases with valid settings as well. If you'd feel like fixing this I'd be happy to review PRs, otherwise I'll try to get to it sometime this week.

2.0.1 is now released with the fix. Thanks for contributing! 🍰

Happy to help :)


[SPARK-47845][SQL][PYTHON][CONNECT] Support Column type in split function for scala and python

What changes were proposed in this pull request?
https://issues.apache.org/jira/projects/SPARK/issues/SPARK-47845
Support column type in split function for scala and python. SQL already supports this, but scala / python functions currently don't.
A hypothetical example to illustrate:
import org.apache.spark.sql.functions.{col, split}

val example = spark.createDataFrame(
    Seq(
      ("Doe, John", ", ", 2),
      ("Smith,Jane", ",", 2),
      ("Johnson", ",", 1)
    )
  )
  .toDF("name", "delim", "expected_parts_count")

example.createOrReplaceTempView("test_data")

// works for SQL
spark.sql("SELECT split(name, delim, expected_parts_count) AS name_parts FROM test_data").show()

// currently doesn't compile for scala, but will be supported after this PR
example.withColumn("name_parts", split(col("name"), col("delim"), col("expected_parts_count"))).show()

Why are the changes needed?
I have a use case to split a String typed column with different delimiters defined in other columns of the Dataframe.
But also following this guidance:
https://github.com/apache/spark/blob/85c4f053f25a7f20546600e179a7303a4409834f/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L59-L61
We might want to do this to a bunch of other functions as well. But I will start with this one and maybe do more if I get time / people generally think it's useful to do so.
Does this PR introduce any user-facing change?
Yes, new feature (via function overloading in scala, and more type handling in python).
How was this patch tested?
Existing pyspark test + Added unit tests with column input type to scala functions.
local spark-shell test.
Was this patch authored or co-authored using generative AI tooling?
No.
Others
The contribution is my original work and I license the work to the project under the project’s open source license.

Actually my first PR here :)
@zhengruifeng based on git blame you did something very similar before. Do you want to take a look? Thanks in advance!

also cc @HyukjinKwon and @LuciferYang

I am fine with this change

thank you @CTCC1
merged to master


fix translation for my note

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/27592
PROPOSAL: https://github.com/Expensify/App/issues/27592#issuecomment-1722289762
Tests

Go to Settings > Preferences >Language
Change Language to Spanish
Create workspace if not created
Go to #admins
Click on header
Go to Private notes, and verify that "My note" translated to  Spanish

[x] Verify that no errors appear in the JS console

Offline tests
The same test

QA Steps
The same test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/39086067/6d0f4e00-61f0-4c7e-96e5-5eebe9e6960f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/39086067/975d6219-01f8-44d8-ac29-6dff60b4b6db

Mobile Web - Safari
https://github.com/Expensify/App/assets/39086067/e1b8c9c1-ce6a-4482-8e50-66d9a3030ec0

Desktop
https://github.com/Expensify/App/assets/39086067/f0660096-68c6-49db-9efb-80effbe48685

iOS
https://github.com/Expensify/App/assets/39086067/5c52f66d-030b-4776-b9d1-7bc4717154d5

Android
https://github.com/Expensify/App/assets/39086067/8a169c04-a16d-4f78-a2aa-d6fd51ebd212

@allroundexperts @tgolen PR already for review.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


An error occurred during the fetch of repository 'local_execution_config_python':

OS Platform and Distribution (e.g. Linux Ubuntu 16.04, Android 11, iOS 14.4):
Windows and WSL(Ubuntu)

Bazel version:
Bazelisk version: development
Build label: 3.7.2
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Dec 17 16:57:23 2020<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Describe the problem:
I ran the following command in Windows WSL.
bazel build -c opt --config=android_arm64 --define 3D=true mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu
Then I got the following error message.
emoto@DESKTOP-O3JDT6Q:~/mediapipe$ bazel build -c opt --config=android_arm64 --define 3D=true mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_absl' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_protobuf' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_googletest' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_github_gflags_gflags' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_rules_apple' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_rules_swift' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_apple_support' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'bazel_skylib' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'pybind11' because it already exists.
INFO: Build option --action_env has changed, discarding analysis cache.
INFO: Repository local_execution_config_python instantiated at:
  /home/emoto/mediapipe/WORKSPACE:409:14: in <toplevel>
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/tensorflow/workspace2.bzl:1085:19: in workspace
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/tensorflow/workspace2.bzl:85:27: in _tf_toolchains
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/tf_toolchains/toolchains/remote_config/configs.bzl:6:28: in initialize_rbe_configs
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/tf_toolchains/toolchains/remote_config/rbe_config.bzl:158:27: in _tensorflow_local_config
Repository rule local_python_configure defined at:
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl:275:41: in <toplevel>
ERROR: An error occurred during the fetch of repository 'local_execution_config_python':
   Traceback (most recent call last):
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl", line 213, column 39, in _create_local_python_repository
                numpy_include = _get_numpy_include(repository_ctx, python_bin) + "/numpy"
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl", line 187, column 19, in _get_numpy_include
                return execute(
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/remote_config/common.bzl", line 230, column 13, in execute
                fail(
Error in fail: Problem getting numpy include path.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'numpy'
Is numpy installed?
ERROR: Analysis of target '//mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu:facemeshgpu' failed; build aborted: Problem getting numpy include path.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'numpy'
Is numpy installed?
INFO: Elapsed time: 1.558s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (17 packages loaded, 12 targets configured)

I have set up a Python action_env, referring to the troubleshooting section.
https://google.github.io/mediapipe/getting_started/troubleshooting.html
The code I ran looks like this, but I get the exact same error.
bazel build -c opt --config=android_arm64 --define 3D=true --action_env PYTHON_BIN_PATH="C:/Users/emoto/AppData/Local/Microsoft/WindowsApps/python.exe" mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu
The error message looks something like this
oto@DESKTOP-O3JDT6Q:~/mediapipe$ bazel build -c opt --config=android_arm64 --define 3D=true --action_env PYTHON_BIN_PATH="C:/Users/emoto/AppData/Local/Microsoft/WindowsApps/python.exe" mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_absl' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_protobuf' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_google_googletest' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'com_github_gflags_gflags' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_rules_apple' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_rules_swift' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'build_bazel_apple_support' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'bazel_skylib' because it already exists.
DEBUG: /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/repo.bzl:109:14:
Warning: skipping import of repository 'pybind11' because it already exists.
INFO: Build option --action_env has changed, discarding analysis cache.
INFO: Repository local_execution_config_python instantiated at:
  /home/emoto/mediapipe/WORKSPACE:409:14: in <toplevel>
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/tensorflow/workspace2.bzl:1085:19: in workspace
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/tensorflow/workspace2.bzl:85:27: in _tf_toolchains
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/tf_toolchains/toolchains/remote_config/configs.bzl:6:28: in initialize_rbe_configs
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/tf_toolchains/toolchains/remote_config/rbe_config.bzl:158:27: in _tensorflow_local_config
Repository rule local_python_configure defined at:
  /home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl:275:41: in <toplevel>
ERROR: An error occurred during the fetch of repository 'local_execution_config_python':
   Traceback (most recent call last):
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl", line 209, column 22, in _create_local_python_repository
                _check_python_bin(repository_ctx, python_bin)
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/py/python_configure.bzl", line 145, column 25, in _check_python_bin
                auto_config_fail("--define %s='%s' is not executable. Is it the python binary?" % (
        File "/home/emoto/.cache/bazel/_bazel_emoto/f422d987460e9e43f8ecbef2688bd1f7/external/org_tensorflow/third_party/remote_config/common.bzl", line 12, column 9, in auto_config_fail
                fail("%sConfiguration Error:%s %s\n" % (red, no_color, msg))
Error in fail: Configuration Error: --define PYTHON_BIN_PATH='C:/Users/emoto/AppData/Local/Microsoft/WindowsApps/python.exe' is not executable. Is it the python binary?
ERROR: Analysis of target '//mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu:facemeshgpu' failed; build aborted: Configuration Error: --define PYTHON_BIN_PATH='C:/Users/emoto/AppData/Local/Microsoft/WindowsApps/python.exe' is not executable. Is it the python binary?
INFO: Elapsed time: 0.642s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (17 packages loaded, 12 targets configured)

Is there any way to fix this error?

Doing this solved the problem.
echo $PYTHON_BIN_PATH
export PYTHON_BIN_PATH=/usr/bin/python3
pip3 install numpy
$PYTHON_BIN_PATH -c 'import numpy'


Use full URL for documentation links

Less room for misinterpretation.

The main motivation for using short names was that they were less likely to exceed line length limits + they were easier to type manually.

JSYK, I've already updated the URL in the "About" for the repo.


Can't interact with custom controls

When I try to make a subclass of a UI control:
import Foundation
import SwiftGodot

@Godot
public class TestButton: Button { }

I can add it to the scene and it will render as normal like other controls, but mouse events will no longer trigger. This seems to happen for any control type (I tried inheriting from Button, Tree and List).
If I put the custom control inside a ScrollContainer, the scroll bar won't work, but if I put it into a Split or H/VBox container, the other controls in that container do still work.

Hey can you check the mouse control setting for your node in the editor. They are under Control > Mouse > Filter They look like this

If it isn't a problem with input filtering it could be the binding

Confirmed that this is definitely an issue — as soon as you subclass any Button, it won't call _pressed or emit any signals.
I did some investigating and determined that this generated proxy method is always returning false:
func _Control_proxy_has_point (instance: UnsafeMutableRawPointer?, args: UnsafePointer<UnsafeRawPointer?>?, retPtr: UnsafeMutableRawPointer?) {
    guard let instance else { return }
    guard let args else { return }
    let swiftObject = Unmanaged<Control>.fromOpaque(instance).takeUnretainedValue()
    let ret = swiftObject._hasPoint (args [0]!.assumingMemoryBound (to: Vector2.self).pointee)
    retPtr!.storeBytes (of: ret, as: Bool.self)
}

I think it is returning false because it is calling _hasPoint on our subclassed object. That just calls a default implementation in Control.swift which returns false, so the text to see if a click is inside the buttons area always fails, and thus the button press is never registered.
As evidence for this theory, adding this override to our Button subclass fixes the issue:
override func _hasPoint(_ point: Vector2) -> Bool {
   Rect2(position: .zero, size: getSize()).hasPoint(point: point)
}

I'm not sure what the solution is. I think either some needed code is not being generated, or some Godot code should be called in Control.swift instead of defaulting to false?

Thank you for this detective work!
So the issue is that we register every method in a subclass as being implemented and dispatch from there.  The reason being that I don’t have a way of detecting if something was overwritten In a subclass without some sort of reflection.
The solution might be to introduce an @override macro that would both override the method and flag the method as implemented (currently, if you look at Godot generated code we generate a big table for each class that always reports “yes, I implement this”).   So we would remove this big chunk of generated code (which is actually suboptimal) with a generated table based on the @override macros.
Sadly, I am traveling this weekend and won’t be back until Tuesday.   But this investigation pointed at the source of the problem (we do have a bug filed here about this, will link later)

Additional comments from Slack, before they get deleted:
The issue is that Godot calls us to find out about our overwritten methods, and because we have no way of knowing this, SwiftGodot currently ships a jumbo "We handle it all", here is what this looks like for Control:
    override class func getVirtualDispatcher (name: StringName) -> GDExtensionClassCallVirtual? {
        switch name.description {
            case "_can_drop_data":
                return _Control_proxy_can_drop_data
            case "_drop_data":
                return _Control_proxy_drop_data
            case "_get_drag_data":
                return _Control_proxy_get_drag_data
            case "_get_minimum_size":
                return _Control_proxy_get_minimum_size
            case "_get_tooltip":
                return _Control_proxy_get_tooltip
            case "_gui_input":
                return _Control_proxy_gui_input
            case "_has_point":
                return _Control_proxy_has_point
            case "_make_custom_tooltip":
                return _Control_proxy_make_custom_tooltip
            case "_structured_text_parser":
                return _Control_proxy_structured_text_parser
            default:
                return super.getVirtualDispatcher (name: name)
        }

    }

And that ends up calling our default implementation for each method, that returns a default value.   In this particular case, we have a case where Godot is asking us for information "Hey does this looks good to you", and we have told Godot "Yeah, we will handle this", but in reality, we provide a canned answer.
Ideally, we could find at compile time, if a method is being overwritten, or at runtime, if a method is overwritten.   The latter has been done extensively in other frameworks, but comes at a memory and startup cost that always end up having to be moved into some two-stage compilation process anyways (In .NET this was moved to source generators, which is a bit like macros, before it was standardized, every system had to roll their own precompilers).
Lacking this, we are going to have to generate the above method based on the inclusion of the @override macro, which would generate the above.
While this is a usability step back, it will reduce the size of SwiftGodot, with 176 fewer dispatcher methods and fewer 2372 proxy methods - we would generate those on demand for each type.

Here's one proposal where we could use the existing @Godot macro:
https://gist.github.com/PadraigK/995be44922778aa5298f60b4ac551fa2

On the channel we are exploring a few options:

Extending the @Godot macro
Leveraging the "Runtime" library to determine if a method is overwritten
Using dlsym to lookup a known function name and figure out if we have an overwritten version

I will integrate the ideas that were put together on the channel into the Godot macro:
https://github.com/migueldeicaza/SwiftGodot/issues/217

A proper fix has been committed now.


feat: upload file to asset mamnager

Description
This PR uses the management API to upload the selected file to AM. It
first reads the file, transforms it into a base64 encoded buffer, and
then makes a POST request with that buffer.
The request is sent to whatever sourceId, destinationPath, and fileName
the user sets for the file.

🖼  Screenshots
https://user-images.githubusercontent.com/16711614/198867184-9c8a128d-62bb-4003-994b-b6f5459e9121.mov
Checklist

[ ] Read the contributing guidelines.
[ ] Each commit follows the Conventional Commit spec format.
[ ] Update the readme (if applicable).
[ ] Update or add any necessary API documentation (if applicable)
[ ] All existing unit tests are still passing (if applicable).

[ ] Add some steps so we can test your bug fix or feature (if applicable).
[ ] Add new passing unit tests to cover the code introduced by your PR (if applicable).
[ ] Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
[ ] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

Current dependencies on/for this PR:

next

PR #140

PR #139

PR #141

PR #142

PR #143

PR #144

PR #145

PR #146

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: yGgqIySrcaAmVh8uxOCg


Snackbar should be animate upwards

According to the Google's Material Design specifications  snackbar should be animate upwards.
Maybe you can use slideDown() / slideUp() instead of fadeIn

Hi, I've also noticed this. I do like the fade in animation style but would it be possible to state options?

I just released v1.3.0 with fade in and slide up animations

@255kb beautiful, thanks for this and creating the project!

you are welcome, glad you are using it :)

@255kb thanks you!


Broken with atom 1.9.3

flushed, cleared, wiped and committed all kinds of deep inside genocide action on my atom install.
Plugin still broken. stuck on  "Discovering projects" regardless of the command i use.

@airtonix Can you try again with 1.9.4?

@airtonix I'll close this for now. If it's still happening on the latest Atom (now 1.9.8), please re-open.


libtbb undefined reference on Fedora

When working with shared memory and targetting CPU, the linker throws an error

/usr/bin/ld: /lib/../lib64/libtbb.so: undefined reference to<EMAIL_ADDRESS>

This issue does not affect compiling for AMD or Nvidia.
tbb in Fedora is version 2021.11.0 release 5.fc40
I suspect newer versions would work, wonder what version ubuntu and other distros have

NAME="Fedora Linux"
VERSION="40 (Workstation Edition)"

CI is using a newer version and does not reproduce the issue. that's good at least
https://github.com/monofuel/hippo/actions/runs/10031958848/job/27723012980#step:5:101


Different feeds from same base URL not allowed

When subscribing to a new feed, from the same base URL, it indicates an error:
"Already Subscribed" - Can't add this feed because you've already subscribed to it.
This even though the actual full URL is different.  Use case: NPR has different feeds based on what you want to subscribe to. Right now, I can only subscribe to one NPR feed.
Great software.  Thanks.

I think I understand what’s meant here — when adding a feed by supplying the URL of a web page, NetNewsWire tries to figure out the best feed to use, and tries to add that one. If you’re already subscribed to that feed, then you get the error.
The rare — but real — case of where a web page has multiple feeds is not dealt with.
In other words, the bug is not that a person can’t subscribe to multiple feeds from NPR (or wherever). You totally can, if you use the specific feed URLs rather than a web page URL.

What’s needed here would be some UI to list all the feeds in a web page and let the user choose which ones to add.


Support for SRT v1.5 with Connection Bonding?

Hello, do you plan to support SRT v1.5? This version has the connection bonding feature, which would be great for stream reliability.

We're working on it, could you please desribe your use scenario?


[Bug]: Question about vocoder tts-hifigan-libritts-16kHz

Describe the bug
Hi, thanks for sharing this repo.
I am using this vocoder to reconstruct the melspectrogram. I have a wav of sample rate 16k, and the length of wav is 65280. I first extract the melspectrogram of hopsize=256 and windowsize=1024, and I get a melspec of dimension [80,245]. I turn it back to wav by using this vocoder, but the reconstructed wav has length 62720 (does not match the input)! The difference is always 2560
I checked the config of vocoder, including hopsize and window size, and they are the same as the mel extraction process. Although there is no significant difference when human listening, the objective evaluation, like stoi and snr and sdr are very very bad (stoi is only 0.15 and sisnr, sdr are negative! ). I think it is because the misalignment between input and the output, but how to fix this problem?

Expected behaviour
I want the input wav and the reconstructed wav to have the same shape. And the snr should be high
To Reproduce
No response
Versions
No response
Relevant log output
No response
Additional context
No response

Yes, I am the same way. By using sr=22050 and len=8192, all the parameters set in the paper resulted in mel sizes of 32, 80, and 32. Even with a vocoder, the same duration cannot be obtained.

Hi @BenoitWang could you please have a look?

Hi, I used exactly the same mel extractor, and all the parameters(hop size, win size) are the same. This problem still exits. It is strange that the difference between gt and reconstructed wav is 256*10 = 2560, instead of 256. I think the padding will not cause such a big mismatch?

I ran the extraction code above and I got a mel-spec of dimension [80,256], do you still get [80,245] with the code above? I used torch==1.13.1 torchaudio==0.13.1


Error Connection On Ubuntu 16.10

SQL Operations Studio Version:0.23.6

Steps to Reproduce:
System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 40 - Could not open a connection to SQL Server)
at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, Object providerInfo, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling)
at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
at System.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(DbConnection owningConnection, DbConnectionPoolGroup poolGroup, DbConnectionOptions userOptions)
at System.Data.ProviderBase.DbConnectionFactory.<>c__DisplayClass22_0.b__0(Task1 _)    at System.Threading.Tasks.ContinuationResultTaskFromResultTask2.InnerInvoke()
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection.ReliableSqlConnection.<>c__DisplayClass28_0.<b__0>d.MoveNext() in C:\J\jobs\sqltoolsservice_master_win\workspace\src\Microsoft.SqlTools.ServiceLayer\Connection\ReliableConnection\ReliableSqlConnection.cs:line 298
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.SqlTools.ServiceLayer.Connection.ConnectionService.d__46.MoveNext() in C:\J\jobs\sqltoolsservice_master_win\workspace\src\Microsoft.SqlTools.ServiceLayer\Connection\ConnectionService.cs:line 542
ClientConnectionId:00000000-0000-0000-0000-000000000000

Closing as duplicate of #324. These are all connectivity issues - for example this one means the server name was wrong / couldn't be found.


Get last known state of data if there is no fn

In the case, we want to share data between components.
For example, there is an app config needs to be got from network when app is starting.
// in component App
const { data: appConfig } = useSWRV('/app/config', configFetcher);
....
// in component B
const { data: appConfig } = useSWRV('/app/config');

useSWRV is purposefully aggressive on revalidation. So if you are trying to only fetch from cache then you can build your own composable.
// useConfig.js
let config= null

function useConfig (fromCache = false) {
  if (fromCache && config) return { appConfig: config }
  const { data: appConfig } = useSWRV('/app/config', configFetcher);

  watch(appConfig, (newVal) => {
    config = newVal
  }, { immediate: true })

  return { appConfig }
}

// in component App
const { appConfig } = useConfig();

// in component B
const { appConfig } = useConfig(true);

The swr library won't do revalidate and will return the last known state of data when you call useSWRV('/app/config').
https://github.com/vercel/swr/blob/master/src/use-swr.ts#L249
I'm just wondering that swrv can also do the same behavior if it is possible.

@NeoLSN thanks for bringing this to my attention! Sounds like a good addition.


Fix .ruby-version to a string that exists in 'rbenv install --list'

This also puts .ruby-version in sync with Gemfile.lock

Coverage: 87.585%. Remained the same when pulling b70aac357f20fd92175c08d60497c34927566627 on kheraops:fix-ruby-version into 641bb0af2d65ca9ef200d0e3ea73c1170e3d38fb on CentauriSolutions:main.


SpMV fix

There was an issue with SparseLogisticRegression when the data matrix had an all-zero row

LGTM!


Add new route for /activity in order to accommodate robust token lists on /index

Problem
In the current implementation of the display of fungible token balances, the user's NEAR balance, fungible token balances, and account activity are all co-located in the same view in the wallet dashboard. While this is not an issue when the user has little to no fungible token balances, there are a couple flaws:

The current design doesn't do a great job of accommodating longer lists of fungible tokens. As the list grows beyond 3-4, we currently don't have any sort of pagination or a dedicated route to display a more robust list of tokens. This would primarily effect DeFi and Bridge users who may have a larger quantity of fungible tokens displayed in the wallet.

The current design superficially imposes a limitation on the number of items we display in the activity feed. Because of limited real-estate on the wallet dashboard view, we cut off the feed and force the user to navigate to the explorer rather than allowing the user to scroll or navigate to view more of their transaction history. This is suboptimal as it encourages the user to leave the wallet.

Intended Outcome
Users should be able to view the entirety of their fungible token balance list, whether on the primary wallet view or from within a new route. Since displaying a long list of fungible tokens would compete for real estate with the activity feed on the dashboard, and since the activity feed is already superficially restricted due to limited real estate, it makes sense to create a new route to accommodate longer lists for both.
What are we doing about it?
The two most sensical options for solving for this problem are as follows:

Create a new route for the complete fungible token list for users that have more robust lists.
Create a new route for /activity to accommodate a more robust activity feed, and to allow the full fungible tokens list to be displayed on the wallet dashboard.

My proposal is for Option 2. Since we will likely be adding a new route regardless, it makes sense to create a separation of concerns and to relocate the activity feed to its own route. This way, the function of the wallet view is asset management, while the function of the activity view would be to stay informed about transaction state and history.
Additionally, this change sets the stage for us to accommodate non-fungible tokens in 2021. Displaying NFTs in the wallet will require even more real estate than fungible tokens, and it makes sense for asset management to be inclusive of both fungible and non-fungible tokens.
The proposed design changes are represented in the mockups below:

This change would represent the final change to the information architecture of the wallet before we are ready to implement the redesign of the wallet navigation as proposed in Q4 of 2020
@Patrick1904 the Figma link for this is the same as fungible token balances.

I have few concerns:

I don't think it is "Priority 0", at most this is P1 as nobody has this problem in prod yet. Even when we switch to show all the tokens you interacted with (I plan to do this one ASAP) most users not gonna have a lot of non-zero balances right now.
We need to make sure that this page is discoverable (e.g. user needs to get there after sending transaction, etc). Maybe Receive screen should also show recent activity as well so that you immediately can see what you received. Clicking on main token balance / custom token balances should probably redirect to the activity list as well
Seems like for desktop / iPad formats there might be enough space to show both tokens and activity side to side, so i think we should use this.

Looks like we currently show success screen after sending a payment which requires another confirmation from user. Seems like redirecting right to /activity would be a better option.

I don't think it is "Priority 0", at most this is P1 as nobody has this problem in prod yet. Even when we switch to show all the tokens you interacted with (I plan to do this one ASAP) most users not gonna have a lot of non-zero balances right now.

Yeah no problem to switch to P1. It was made out to sound semi-urgent but I realize I've been too liberal with this.

We need to make sure that this page is discoverable (e.g. user needs to get there after sending transaction, etc). Maybe Receive screen should also show recent activity as well so that you immediately can see what you received. Clicking on main token balance / custom token balances should probably redirect to the activity list as well

Seems like for desktop / iPad formats there might be enough space to show both tokens and activity side to side, so i think we should use this.

Yeah I'm not in opposition to this and have actually explored this. @Patrick1904 how would you feel about keeping a small "Recent Transactions" list on the dashboard (most recent 5 / two columns on desktop), but still adding a full / complete feed as a separate route that the "Recent transactions" can link to (via "View More"), in addition to being added as a primary nav item? This way we solve for both discoverability and scalability. @vgrichina I'll think about UX following transactions like send/receive.

Yeah I'm not in opposition to this and have actually explored this. @Patrick1904 how would you feel about keeping a small "Recent Transactions" list on the dashboard (most recent 5 / two columns on desktop), but still adding a full / complete feed as a separate route that the "Recent transactions" can link to (via "View More"), in addition to being added as a primary nav item? This way we solve for both discoverability and scalability. @vgrichina I'll think about UX following transactions like send/receive.

Yep I'm all for keeping 'recent transactions' on the dashboard with 'view all' to separate route. @corwinharrell how do you envision the two column layout to look?

From my recent bridge marketing notes, we will have a list of tokens that can be sorted by "liquidity": similarly to the size of validators, certain tokens will have more tokens than others - and may offer valuable returns to users who lend their near (via AMM and yield farming).
In my opinion, makes sense to prioritize as follows:

all non-zero balance tokens
if less than 4, fill up with the top tokens by market cap*
add the possibility via + button to track manually any additional zero-balance token

Use case for 1 is obvious
Use case for 2 is to invite the user to explore the other "stars" in the ecosystem
Use case for 3 is enable users to follow early on other tokens
Overall, these users may want to see the balance to check if and how much is growing, e.g. via AMM fees or other things that fungible tokens offer to them (e.g. farming bananas)

I'm wondering if we want to put a smaller number that shows the user the total balance of the contract he's looking at

@jimmy3dita there is no need for 3 except for airdroped tokens. We know which tokens you are interacting with and are surfacing them in https://github.com/near/near-wallet/pull/1579
There is also whitelist but the logic is slightly different from 4 (whitelisted tokens always show up).

*I'm wondering if we want to put a smaller number that shows the user the total balance of the contract they're looking at

do you mean like total supply? Probably worth to have this info in explorer

NOTE: Revising this work slightly to take into account feedback and a more iterative implementation.
While there is still be a need to introduce a separate route for a more robust activity feed in order to allow users to track their history of transactions without having to leave the wallet, I want to tweak our approach to implementing this to be a bit more iterative.
Ultimately, the activity feed on the dashboard and the feed on its own route will be serving two different functions:

"Recent Activity" will remain on the dashboard and will be limited to a small set of your most recent transactions. This will generally be used to verify the state and success of your most recently executed transactions.
The dedicated activity view will include a longer history of your account activity, and will serve to enable users to review their history without having to leave the wallet to navigate to the explorer.

Since adding a new route and addressing optimizations to accommodate a more robust activity feed would increase scope, I'm proposing the following:

Retain the "Recent Activity" list on the dashboard, and adopt a multicolumn layout to accommodate a longer list of fungible tokens (the original goal of this issue) (as per @vgrichina's suggestion.)
Create a separate issue for adding a new route for a full activity feed, so we can address the needs of the fungible tokens list first and create a separation of concerns.

@Patrick1904 has already completed the necessary changes for the dashboard layout here: https://github.com/near/near-wallet/pull/1582


Change re-provisioning logic

Some service calls (i.e. unifi_wifi.enable_lan) need to force a re-provisioning of access points for changes to be fully applied. Before, the YAML config needed to include force_provision: true. The immediate downside is even simple password changes would cause a re-provision to occur. This PR allows individual service calls the ability to force a re-provision while allowing the user to maintain force_provision: false in YAML. This option is not accessible through the UI, only in services.py

moved some debug messaging to out of EXTRA_DEBUG


Add Phi-3 small on CPU in model builder

Description
This PR adds support for building Phi-3 small ONNX models for CPU in the model builder.
Motivation and Context
Previously, the SparseAttention operator was only supported on CUDA in ONNX Runtime. With the recent support for SparseAttention on CPU, Phi-3 small ONNX models can now run on CPU. This PR also helps this issue.
To use these changes, both ONNX Runtime and ONNX Runtime GenAI need to be built from source. Because the official PyTorch repo does not have a tokenizer.json file, the tokenizer.json file needed for Phi-3 small in ONNX Runtime GenAI can be downloaded from the Hugging Face repos. Please see here for Phi-3 small 8K and here for Phi-3 small 128K.

Description
This PR adds support for building Phi-3 small ONNX models for CPU in the model builder.
Motivation and Context
Previously, the SparseAttention operator was only supported on CUDA in ONNX Runtime. With the recent support for SparseAttention on CPU, Phi-3 small ONNX models can now run on CPU. This PR also helps this issue.
To use these changes, both ONNX Runtime and ONNX Runtime GenAI need to be built from source. Because the official PyTorch repo does not have a tokenizer.json file, the tokenizer.json file needed for Phi-3 small in ONNX Runtime GenAI can be downloaded from the Hugging Face repos. Please see here for Phi-3 small 8K and here for Phi-3 small 128K.

How does the PyTorch tokenizer work without tokenizer.json?

How does the PyTorch tokenizer work without tokenizer.json?

There's a custom Python tokenizer file that is used.

Export Microsoft/Phi-3-small-8k-instruct ONNX model on CPU (Ubuntu 22.04.4 LTS)
As per suggestion, I referred to ONNX Runtime Build Documentation and followed the steps below:
git clone https://github.com/microsoft/onnxruntime-genai
cd onnxruntime-genai
curl -L https://github.com/microsoft/onnxruntime/releases/download/v1.19.2/onnxruntime-linux-x64-1.19.2.tgz -o onnxruntime-linux-x64-1.19.2.tgz && \
tar xvzf onnxruntime-linux-x64-1.19.2.tgz && \
mv onnxruntime-linux-x64-1.19.2 ort
python build.py --config Release
python3 builder.py -m microsoft/Phi-3-small-8k-instruct -o phi3_small8k -e cpu -p fp16

However, I encountered the following error:
AssertionError: Flash Attention is not available, but is needed for dense attention.
Detailed Trace:
Valid precision + execution provider combinations are: FP32 CPU, FP32 CUDA, FP16 CUDA, FP16 DML, INT4 CPU, INT4 CUDA, INT4 DML
Extra options: {}
/proj_sw/user_dev/kkannan/sep20_phi3_setup/kamal_3_10_12/lib/python3.10/site-packages/transformers/models/auto/configuration_auto.py:961: FutureWarning: The `use_auth_token` argument is deprecated and will be removed in v5 of Transformers. Please use `token` instead.
 warnings.warn(
/proj_sw/user_dev/kkannan/sep20_phi3_setup/kamal_3_10_12/lib/python3.10/site-packages/transformers/tokenization_utils_base.py:1601: FutureWarning: `clean_up_tokenization_spaces` was not set. It will be set to `True` by default. This behavior will be depracted in transformers v4.45, and will be then set to `False` by default. For more details check this issue: https://github.com/huggingface/transformers/issues/31884
 warnings.warn(
/proj_sw/user_dev/kkannan/sep20_phi3_setup/onnxruntime-genai/builder.py:2509: UserWarning: Sparse CSR tensor support is in beta state. If you miss a functionality in the sparse tensor support, please submit a feature request to https://github.com/pytorch/pytorch/issues. (Triggered internally at ../aten/src/ATen/SparseCsrTensorImpl.cpp:53.)
 block_mask_dense_output = [xi.to_sparse_csr() for xi in block_mask_dense_output]
/proj_sw/user_dev/kkannan/sep20_phi3_setup/kamal_3_10_12/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py:469: FutureWarning: The `use_auth_token` argument is deprecated and will be removed in v5 of Transformers. Please use `token` instead.
 warnings.warn(
2024-09-20 08:54:16,513 transformers_modules.microsoft.Phi-3-small-8k-instruct.1535ae26fb4faada95c6950e8bc6e867cdad6b00.modeling_phi3_small [INFO] - Layer 2 is using dense attention since it is divisible by 2
Traceback (most recent call last):
 File "/proj_sw/user_dev/kkannan/sep20_phi3_setup/onnxruntime-genai/builder.py", line 2872, in <module>
  create_model(args.model_name, args.input, args.output, args.precision, args.execution_provider, args.cache_dir, **extra_options)
 File "/proj_sw/user_dev/kkannan/sep20_phi3_setup/onnxruntime-genai/builder.py", line 2764, in create_model
  onnx_model.make_model(input_path)
 File "/proj_sw/user_dev/kkannan/sep20_phi3_setup/onnxruntime-genai/builder.py", line 1762, in make_model
  model = AutoModelForCausalLM.from_pretrained(self.model_name_or_path, cache_dir=self.cache_dir, use_auth_token=True, trust_remote_code=True, **extra_kwargs)
 File "/proj_sw/user_dev/kkannan/sep20_phi3_setup/kamal_3_10_12/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 559, in from_pretrained
  return model_class.from_pretrained(
 File "/proj_sw/user_dev/kkannan/sep20_phi3_setup/kamal_3_10_12/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3832, in from_pretrained
  model = cls(config, *model_args, **model_kwargs)
 File "/home/kkannan/.cache/huggingface/modules/transformers_modules/microsoft/Phi-3-small-8k-instruct/1535ae26fb4faada95c6950e8bc6e867cdad6b00/modeling_phi3_small.py", line 903, in __init__
  self.model = Phi3SmallModel(config)
 File "/home/kkannan/.cache/huggingface/modules/transformers_modules/microsoft/Phi-3-small-8k-instruct/1535ae26fb4faada95c6950e8bc6e867cdad6b00/modeling_phi3_small.py", line 745, in __init__
  self.layers = nn.ModuleList([Phi3SmallDecoderLayer(config, layer_idx) for layer_idx in range(config.num_hidden_layers)])
 File "/home/kkannan/.cache/huggingface/modules/transformers_modules/microsoft/Phi-3-small-8k-instruct/1535ae26fb4faada95c6950e8bc6e867cdad6b00/modeling_phi3_small.py", line 745, in <listcomp>
  self.layers = nn.ModuleList([Phi3SmallDecoderLayer(config, layer_idx) for layer_idx in range(config.num_hidden_layers)])
 File "/home/kkannan/.cache/huggingface/modules/transformers_modules/microsoft/Phi-3-small-8k-instruct/1535ae26fb4faada95c6950e8bc6e867cdad6b00/modeling_phi3_small.py", line 651, in __init__
  self.self_attn = Phi3SmallSelfAttention(config, layer_idx)
 File "/home/kkannan/.cache/huggingface/modules/transformers_modules/microsoft/Phi-3-small-8k-instruct/1535ae26fb4faada95c6950e8bc6e867cdad6b00/modeling_phi3_small.py", line 218, in __init__
  assert is_flash_attention_available, "Flash Attention is not available, but is needed for dense attention"
AssertionError: Flash Attention is not available, but is needed for dense attention

Note: I verified my build by exporting the Phi-3-min-4k-instruct model successfully.
Additionally, I want to export the model with input_ids and attention_mask as inputs (without position_ids, present, and past key values) and obtain logits as the output. is there any way to achieve it?
Any help from members of the official repository would be greatly appreciated!


coping jaeger jar

OP-13947
https://devopsmx.atlassian.net/browse/OP-13947
coping jaeger jar

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G03SSBAA2SFYBYSQWPY751BS

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G03SSKFDX4XVTMF5191BJN35

SUCCESSFUL RunTestJar RESULT: Total tests run: 196, Failures: 0, Skips: 0 Reviewers ,  this PR did not cause the failures in  https://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-2423.html


python test case and other event handlers added

@StrongMonkey Please rename all go files to use underscores instaed of camel case. I mean tha actual file names should be like docker_utils.go not dockerUtils.go.

added 40 test cases which are related to instance activate and rename all the incorrect file names


Help Command dont work

When i try to use the n!help command this error is coming

This bot currently only supports Discord.JS v12, so error will occur when you are using version 11 or 13.
Discord.js v13 compatible release will be formed this month.


Add Nikita Strygin, our Rust developer

GitHub ID to add: @DCNick3
Project to be added to:

hyperledger/iroha
hyperledger/iroha-java
hyperledger/iroha-python

Teams to be added to:

github.com/orgs/hyperledger/teams/iroha-maintainers
github.com/orgs/hyperledger/teams/iroha-python
github.com/orgs/hyperledger/teams/iroha-java
github.com/orgs/hyperledger/teams/iroha-javascript

Invite extended. Please update the MAINTAINERS.md file

Thanks, we will.


Has this happened to anyone?

I've been training a modelo with llama 3.2 1b and this happened at this time, I was training 4 hours ago and this didn't happen.
I tried to stop it and run again but then it doesn't work because I get this Error: wandb.init() before wandb.log()

I was traning this early morning and it doesn't show, but now do.
Is this a bug or what?

I do more feedback when I train and cancel and then do it again

==((====))==  Unsloth - 2x faster free finetuning | Num GPUs = 1
   \\   /|    Num examples = 36,946 | Num Epochs = 1
O^O/ \_/ \    Batch size per device = 2 | Gradient Accumulation steps = 8
\        /    Total batch size = 16 | Total steps = 1,500
 "-____-"     Number of trainable parameters = 11,272,192
**** Unsloth: Please use our fixed gradient_accumulation_steps by updating transformers and Unsloth!
 [ 26/1500 06:30 < 6:39:44, 0.06 it/s, Epoch 0.01/1]
Step | Training Loss
-- | --
---------------------------------------------------------------------------
Error                                     Traceback (most recent call last)
<ipython-input-13-3d62c575fcfd> in <cell line: 1>()
----> 1 trainer_stats = trainer.train()

7 frames/usr/local/lib/python3.10/dist-packages/wandb/sdk/lib/preinit.py in preinit_wrapper(*args, **kwargs)
     34 ) -> Callable:
     35     def preinit_wrapper(*args: Any, **kwargs: Any) -> Any:
---> 36         raise wandb.Error(f"You must call wandb.init() before {name}()")
     37
     38     preinit_wrapper.__name__ = str(name)

Error: You must call wandb.init() before wandb.log()

==((====))==  Unsloth - 2x faster free finetuning | Num GPUs = 1
   \\   /|    Num examples = 36,946 | Num Epochs = 1
O^O/ \_/ \    Batch size per device = 2 | Gradient Accumulation steps = 8
\        /    Total batch size = 16 | Total steps = 1,500
 "-____-"     Number of trainable parameters = 11,272,192
**** Unsloth: Please use our fixed gradient_accumulation_steps by updating transformers and Unsloth!
 [ 26/1500 06:30 < 6:39:44, 0.06 it/s, Epoch 0.01/1]
Step	Training Loss
---------------------------------------------------------------------------
Error                                     Traceback (most recent call last)
[](https://localhost:8080/#) in ()
----> 1 trainer_stats = trainer.train()
7 frames
/usr/local/lib/python3.10/dist-packages/wandb/sdk/lib/preinit.py in preinit_wrapper(*args, **kwargs)
34 ) -> Callable:
35     def preinit_wrapper(*args: Any, **kwargs: Any) -> Any:
---> 36         raise wandb.Error(f"You must call wandb.init() before {name}()")
37
38     preinit_wrapper.name = str(name)
Error: You must call wandb.init() before wandb.log()

@jhangmez Coincidentally I just fixed it :)
I updated all training notebooks - please edit the TrainingArguments part by adding report_to = "none". For example:

    args = TrainingArguments(
        per_device_train_batch_size = 2,
        gradient_accumulation_steps = 4,
        ...
    ),

should be edited to:

    args = TrainingArguments(
        per_device_train_batch_size = 2,
        gradient_accumulation_steps = 4,
        ...
        report_to = "none", # Use this for WandB etc
    ),


request: bun compat

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
it'd be nice if /pieces would run on bun, seems to be the only part that is having trouble
Desired solution
haven't looked alto much into it but it's probably somewhat related to the module resolution within pieces, since it complains about all paths being undefined/thing/module.js
Alternatives considered
nop
Additional context
https://adriancastro.dev/wujc8lds16bo.png

Duplicate of https://github.com/sapphiredev/framework/issues/671
TL;DR Unfortunately its on bun to fix their node apis

ah I see, those bun people need to get their buns bunning smh


TPM plugins and status-right/status-left?

I've been using your standard config with catppuccin tmux. They've recently rewritten the plugin in a way where it seems that it matters the order in which the plugins are loaded and that status-left and status-right are set. Is there a way to handle this? I'm a bit new to tmux config, I will admit.

Hello @davidfmatheson 👋
I'm sorry I don't know catpuccin tmux.
My expectations, in terms of ordering is that

Oh my tmux sets status-left and status-right tmux options
Then each TPM plugin can rewrite status-left and status-right on their own

I don't believe TPM defines in which order plugins are loaded

Does that help?

Oh my tmux! scans its .local customization file for set -g @plugin directives, and fills the @tpm_plugins variable that TPM consumes.
The order of which plugin names appear in @tpm_plugins is the order in which they are listed in the .local customization file.


Initialize LLM validator + basic QA example

This change ports over basic llm_validator functionality.
Try it out with:
bun examples/validator/index.ts

[ ] can you add a test
[ ] add small readme so we can carry that over to docs when its ready
[ ] merge main


Fix support for sourcemaps in transforms

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
In #5117, #3458 was partially reverted. This is a tracking issue for its reactivation.
If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.
N/A
What is the expected behavior?
Make the skipped test in #5117 pass.
Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.
N/A

I don't understand properly what's going on here.
The reason we attempt to read from disk, is that the test file is added to sourMapInfo here: https://github.com/facebook/jest/blob/d1845116ebe818e6d945d50ad4857752758970ee/packages/jest-runtime/src/index.js#L440-L447
But when we try to read the file, it's not there:
https://github.com/facebook/jest/blob/d1845116ebe818e6d945d50ad4857752758970ee/packages/jest-cli/src/reporters/coverage_reporter.js#L63
It might be that we just have to add the source map information we write to disk to the _sourceMapStore instance.

Make sure to test that we support #5151 as well when this is fixed.

I'd like to contribute if possible.

PR very much welcome! I won't personally work on this for some time, but happy to review code :)

Cool! I'll give it a shot!

Here is what I have found so far
TLDR

Suspect an incorrect usage of mapCoverage boolean at this line

Longer version

Here in the getSourceMapInfo() function, It is taking sourceMaps written into jest's cache folder.
Here's a sample of what the object this._sourceMapRegistry looks like, all the values end with .map looking for a sourcemap file

{
  '/home/aftab/work/code/eoc-ui/src/components/reusable-components/feedback/FeedBack.phnx': '/tmp/jest_rs/jest-transform-cache-f634946ae80171f59c1ddb40b765ffcb-c8daf9fb18de3edbc88a4eda9bec586e/d4/FeedBack_d4992420ed5d74d7f3a0cddeea3ba313.map',
  '/home/aftab/work/code/eoc-ui/src/components/reusable-components/feedback/TextToMarkdown.phnx': '/tmp/jest_rs/jest-transform-cache-f634946ae80171f59c1ddb40b765ffcb-c8daf9fb18de3edbc88a4eda9bec586e/12/TextToMarkdown_12d9a7499ca565056659ef0951ca7515.map'
}

From there I went to script_transformer.js transformSource function where the caches are written.

.
.
.
let sourceMapPath = cacheFilePath + '.map'; //The path created here
.
.
.
if (mapCoverage) { //defaults to false
  //It will never enter this if block where the inlineSourceMaps are read.
  if (!transformed.map) {
    const inlineSourceMap = convertSourceMap.fromSource(transformed.code);
    if (inlineSourceMap) {
      transformed.map = inlineSourceMap.toJSON();
    }
  }
}
.
.
.
if (instrument && mapCoverage && transformed.map) {
  const sourceMapContent =
    typeof transformed.map === 'string'
      ? transformed.map
      : JSON.stringify(transformed.map);
  writeCacheFile(sourceMapPath, sourceMapContent);
} else {
  sourceMapPath = null;
}

In the snippet that I posted above, the inlineSourceMaps are never read, since mapCoverage defaults to false.

The if block where the .map file is supposed to be written, the transformed.map won't be defined. Hence the .map file won't be written into cache.

I see that in #5117 you have added mapCoverage to the if block where the .map is supposed to be written.

So when the getSourceMapInfo() function is called, it returns an empty object.

So my guess is we shouldn't have the mapCoverage boolean in the place where we read the inlineSourceMaps

I have very little context, I would appreciate if you can clear it up.

Should be fixed in #5177

@SimenB This is still broken, should be reopened


There should be a way for docker to clear its cache

Shouldn't there be a way for me to easily empty docker's cache in order to save disk space?
Something like docker clear-cache

This one is kind of interesting.  I don't think we have any "docker daemon management" type of tools or commands.  Although, one could argue that things like "docker pull" does, sort of, do that. So, if we did want to do something like this some options might be:

add a new docker command (docker clear-cache as being suggested)
extend https://github.com/docker/docker/pull/10535 to support something like docker daemon --clear-cache which won't start the daemon but instead just performs some admin action.

I can see the number of admin tasks growing over time so we may want to think about a long term solution to this type of request.  I'm leaning more towards the 2nd option - even if its under docker admin instead of docker daemon.

@thecodethinker The thing with the cache is it's all just images layered on top of each other. And the cache layers are used for the final product (which is why it works).
That said, today you can clear out essentially unreachable images (images without tags) with docker rmi $(docker images --filter dangling=true)
Proper GC of images, volumes, etc has been much discussed but never implemented.

From what I've seen by looking around some of the issues, an admin tool like what @duglin suggested seems really wanted.
Would there be any way to implement something like this with the daemon's API? Or would there need to be a good amount of work done within the daemon?

@cpuguy83 I'm not sure if this is a separate issue but when I run docker images --filter dangling=true it gives me containers that are being used by other containers.
What is docker's definition of dangling?

@thecodethinker dangling means the image ID is not part of a tagged image.
A container can be using a non-tagged image (for instance if you've pulled a new version of ubuntu, the container's ubuntu is now untagged). These images won't be deleted with the above command since the image is in use.
You can force the removal of these in use images if and only if the container using it is stopped by using the -f option:  docker rmi --f $(docker images --filter dangling=true -q)

Would that cause any damage to the final image? Or are those just the cache
for if I update or change the image?
On Wed, Feb 11, 2015 at 2:54 PM, Brian Goff<EMAIL_ADDRESS>wrote:

@thecodethinker https://github.com/thecodethinker dangling means the
image ID is not part of a tagged image.
A container can be using a non-tagged image (for instance if you've pulled
a new version of ubuntu, the container's ubuntu is now untagged). These
images won't be deleted with the above command since the image is in use.
You can force the removal of these in use images if and only if the
container using it is stopped by using the -f option: docker rmi --f
$(docker images --filter dangling=true -q)
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/10709#issuecomment-73951916.

@thecodethinker That's why they are dangling, the layers are not in use by an image that is actually reachable, so in that sense there is no 'final' image for these dangling layers.

This is documented here : http://docs.master.dockerproject.org/reference/commandline/cli/#images
So I guess this issue can be closed


[DO NOT MERGE] Update same sex outcome France

Added info about applying online for certificate of custom
Added link to new service for applying online for certificate of custom
Before merge
Waiting for service that this page links to goes live.
Do not merge until linked service is live.

Superseded by https://github.com/alphagov/smart-answers/pull/4803