Proper "ignore test depending on env" handling

Abstract
We want to skip tests if certain environment variables are NOT set (e.g. SOCKS_PROXY) so that developers do not need to provide a full-blown integration test infrastructure if they only work on a subset of the features.
ACs

tests are skipped when environment variables are NOT set
tests are skipped at runtime, NOT at compile time
skipped tests are marked as "ignored"
tests skipping requires little code (ideally a single line in form of a decorator, a function call, a macro call)

Current Situation
We currently use macros like this:
https://github.com/influxdata/rskafka/blob/6510b230896cd1447c2ca001fb5aa9762d049b2a/tests/test_helpers.rs#L75-L93
This fulfills all ACs except for skipped tests are marked as "ignored".
References

https://github.com/influxdata/rskafka/pull/132#discussion_r864939648
https://github.com/rust-lang/rust/issues/68007

@mario-s volunteered to work on this :tada:


StackOverflowException 4.0

Process is terminated due to StackOverflowException.
Mod.log is just full of "Reading modules" entries. This is on cosmic, new install of the game. Happens with or without mods in the mod folder.
Appreciate your time.

What OS are you using?
Could you post Mod_Log.txt file, clean just with one execution of the injector? Also the console output if it is different.

After running Injector.exe from version 4.0 Mod_Log.txt is filled with 10,595 identical lines of "Reading modules: " with the error message "Process is terminated due to StackOverflowException." displayed in the console window. (Not the log.)
Running v0.1 injector after overwriting the old one and executing it didn't crash and it said it patched, there was no Mod_Log.txt and the game wouldn't work. The problem with 4.0 is it won't even patch, the first thing it says is the StackOverflowException. All previous versions worked fine.
Thanks.

System Information
     Operating System: Windows 10 Enterprise 2016 LTSB 64-bit (10.0, Build 14393) (14393.rs1_release_1.180427-1811)
             Language: English (Regional Setting: English)
            Processor: AMD Phenom(tm) II X4 830 Processor (4 CPUs), ~2.8GHz
               Memory: 8192MB RAM
  Available OS Memory: 8192MB RAM

|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||

Sorry, but I cannot replicate the bug. I've added more logs to the injector to try to pinpoint the issue.
Try this new version and paste the Mod_Log.txt file:
https://github.com/javisar/ONI-Modloader/blob/master/Managed/Injector.exe

I reinstalled ONI comet preview, I put the 4.0 files in the managed folder, then I overwrote injector.exe with the newest version, it still fails with the same message. It did actually close the console window when I closed the windows error reporting dialogue.
The log is the same as last time 10613 repeating lines of "Reading modules:
Reading modules: "
The older 3.0 version works on the regular build, not beta comet build. In fact, if I just separate the file on its own and launch it (secluded unrelated folder structure) 4.0 throws the exact same error.
Thanks

I really don't know what's the problem :(
Some ideas:
Check if you have read only folders/files, you are running it as Administrator or there is something like Windows UAC active.
Check if you have in the same folder 'Mono.Cecil.dll'
Check if you have .NET 3.5 installed.
It's really weird that you get "Reading modules" so many times because there is no loop in the source code.
Maybe someone able to debug with VStudio has the same problem and can fix it.

I have .NET 3.5 installed, UAC is enabled but it has always been enabled. The file is present as it has been with every one of your installation packages. All of the prior versions wouldn't have worked and continue to at least open rather than open and immediately say "Process is terminated due to StackOverflowException." in the window.
I have tried building it from the source, I don't know how to point it to the .dll resources from the game, do you mean build debug versions under batch build? I have VS Community 2017. :sob:

@javisar @Killface1980
It looks like someone missed a dependency when they were building from source, I can't recall which one, but one of the ones had a blank path, the others I just copied the files and dropped in. Some rather than pointing to their own source folders as well went to another folder. (Not that important.) All I know is the debug build ran, despite "C:\Users\User\Downloads\ONI-Modloader-0.4.0\Source\Injector\Program.cs(11,31,11,49): warning CS0169: The field 'Program._managedFolderPath' is never used
Injector -> C:\Users\User\Downloads\ONI-Modloader-0.4.0\Managed\Injector.exe
Invalid drive specification"
Mod_Log.txt:
"Reading modules:
\Assembly-CSharp.dll
\Assembly-CSharp-firstpass.dll
Done! Patch Sucessful.
OSVersion: Microsoft Windows NT 6.2.9200.0
Creating mods folder is: C:\Program Files (x86)\Steam\steamapps\common\OxygenNotIncluded\Mods
Press any key to continue . . ."
This is built from the 4.0 source in the releases, not with your most recent change. I can see about building from that, but I don't see the point. If I had to guess (I'm no programmer) the one with the entirely blank dependency entry is to blame as it wouldn't have mattered if the file was even in the folder. :disappointed:
Do you think perh

Nevermind, seems like only debug build works for me, hmm. New update broke some mods as well, not sure which.

I did some checking, apparently the problem is related to a registry setting for some sort of debug to force dotnet applications to use the newest version.
Not sure why it was on, maybe when I installed VS I checked something in the installer, dunno. Mystery solved.
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft.NETFramework]
"OnlyUseLatestCLR"=dword:00000001 <- change 1 to 0.
Now if we could fix whatever mods are causing problems with the most recent update. Anyway thanks for your time and hard work.

Thank you @L-a-n-g-o-l-i-e-r-s for finding the problem. I've been able to replicate the bug 100%. Registry entry (I didn't have it) and also that debug .exe works fine.
I'm going to keep open this issue because at some point we could find a solution that does not imply to mess with windows registry.

@javisar
This registry entry doesn't exist by default, When the registry entry does not exist, the system reads it the same as it would if it existed and was toggled off with "dword:00000000" setting.
When "dword:00000001" it forces .net applications to use the newest version of .net. (For whatever reason 0.4.0 of the injector is no longer compatible when forced to run with say .net 4.7.2. by this setting (unintentionally/unknown to me) meaning that it is now 100% dependent on .net 3.5 or whatever is listed in the requirements on the read me, previous versions ran fine, this is why I didn't notice the issue.)
Not a big deal, very unlikely anyone else will have this problem, if they do, they can simply put the following in a text file and rename the file extension to .reg and execute it:
"Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft.NETFramework]
"OnlyUseLatestCLR"=dword:00000000"
(The 0 setting is the same as the registry entry having never existed in the first place, so making the entry in the first place isn't necessary if you aren't experiencing the problem, nothing wrong with the injector.)

I think I've found a way to solve it.
I've deactivated "Optimize Code" in the file Injector.csproj in Visual Studio.
This seems to make the trick.


dev-cmd/test: set RUST_BACKTRACE when retrying

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Occasionally, a new version of Rust will cause failures in dependents.
See, for example, Homebrew/homebrew-core#107818.
This change will allow us to get a fuller backtrace in CI, which will
also make it easier to submit bug reports upstream.
Without this change, recovering a full backtrace requires installing the
new version of Rust and rebuilding the failing formula from source. Both
these steps can be skipped if we set RUST_BACKTRACE when retrying a
failing test.
I'm not sure if this is the right place to put this. However, it's much
nicer to only do this when retrying the test, so I've put it here.

Review period will end on 2022-08-16 at 10:33:31 UTC.

Review period ended.


Execution failed due to configuration error: Lambda was not able to access EC2's API using the Lambda Execution Role to set up the Lambda function

I'm not sure if this is a bug or just a lack of 'complete' examples to template from in the docs. I am seeing the above error with AWS SAM CLI when deploying lambdas through cloud formation. The following yaml works:
Globals:
  Function:
    Timeout: 750
    VpcConfig:
      SecurityGroupIds:
        - sg-xxxx
      SubnetIds:
       - subnet-1
       - subnet-2
Resources:
   MyFunction:
     Type: AWS::Serverless::Function
     Properties:
        CodeUri: src/
        Handler: MyFunction.lambda_handler
        Policies:
        - Statement:
            Sid: "ec2resources"
            Effect: Allow
            Action:
              - "ec2:CreateNetworkInterface"
              - "ec2:AttachNetworkInterface"
              - "ec2:DeleteNetworkInterface"
              - "ec2:DescribeNetworkInterfaces"
              - "ec2:DetachNetworkInterface"
              - "ec2:DescribeSecurityGroups"
              - "ec2:DescribeSubnets"
              - "ec2:DescribeVpcs"
            Resource:
              - "*"

The following throws the error even through the subnets and security groups are identical to those in the globals configuration:
        .......
        - Statement:
            Sid: "ec2resources"
            Effect: Allow
            Action:
              - "ec2:CreateNetworkInterface"
              - "ec2:AttachNetworkInterface"
              - "ec2:DeleteNetworkInterface"
              - "ec2:DescribeNetworkInterfaces"
              - "ec2:DetachNetworkInterface"
              - "ec2:DescribeSecurityGroups"
              - "ec2:DescribeSubnets"
              - "ec2:DescribeVpcs"
            Resource:
              - "arn:aws:ec2:eu-west-1:acc:security-group/sg-xxxx"
              - "arn:aws:ec2:eu-west-1:acc:subnet/subnet-1"
              - "arn:aws:ec2:eu-west-1:acc:subnet/subnet-2"
              - "arn:aws:ec2:eu-west-1:acc:network-interface/*"
              - "arn:aws:ec2:eu-west-1:acc:vpc/vpc-xyz"

Is it possible I am missing a permission? Or a resource from the policy?

Hi @wes3985, unfortunately what you are trying to do is not currently possible. Looking at the Actions, Resources, and Condition Keys for Amazon EC2 documentation none of those actions support specifying a specific resource.
Out of curiosity, what was the exact error you were seeing?

Hi Rory,
Thanks for getting back to me. Ah I see, I've redeployed it with '*' as the
resource, and that explains why it now works.
We were advised from a security perspective to only allow specific
resources as part of policies so that the lambda is limited in what it can
access. For instance the S3 policy for this lambda can only access a
specific bucket. We wanted the ec2 to only be within our vpc and subnets.
Are there plans to allow this functionality in the future? Or have I
misunderstood aspects of how/why the yaml is laid out like this?
This error was thrown on the AWS console when I was testing the lambda. The
lambda itself didn't actually run due to this error so there is no
cloudwatch log, only this message on the console.
Let me know if there is anything else I can provide.
Many thanks,
Wes
On Tue, 13 Aug 2019, 22:32 Rory Jacob<EMAIL_ADDRESS>wrote:

Hi @wes3985 https://github.com/wes3985, unfortunately what you are
trying to do is not currently possible. Looking at the Actions,
Resources, and Condition Keys for Amazon EC2
https://docs.aws.amazon.com/IAM/latest/UserGuide/list_amazonec2.html
documentation none of those actions support specifying a specific resource.
Out of curiosity, what was the exact error you were seeing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/serverless-application-model/issues/1074?email_source=notifications&email_token=ACNWY6CMOAKCQCCJU47RQCDQEMR6RA5CNFSM4IKLDDTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HBP7Y#issuecomment-521017343,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACNWY6CISE2TPHP5DUP44WTQEMR6RANCNFSM4IKLDDTA
.

The thing here is that IAM is typically a resource-based authentication system.
Let's look at the permission ec2:CreateNetworkInterface. What resource would it be associated with? The network interface it hasn't yet created. So permissions like those are associated with the resource *. Similarly, the permission ec2:AttachNetworkInterface. What resource? The one which will be created after launch, for which there's no accessible identifier at deployment time.
The SAM team has created a Policy Template which wraps all this up, though. It's called "VPCAccessPolicy". It takes the meaningful policies you specified above and turns them into this:
Policies:
- VPCAccessPolicy: {}

You can find its expansion here in the repo, to check for yourself.

We wanted the lambda to only run within our vpc and subnets.

The way to do this is exactly as you already have, the VpcConfig. This is a problem solved by configuration, not permission.

@chrisoverzero's explanation is spot on. Closing this issue since SAM and Lambda are working as intended.


assert StringMap value type in MutableBag ToProto

I am keep getting the following errors when running perf test from ToProto(). Type of value of string map attributes is obscured.
2018-08-31T19:34:33.019890Z	error	attributes	Cannot convert value:map[version:555] of type:map[string]interface {}
2018-08-31T19:34:33.019920Z	error	attributes	Cannot convert value:map[date:Tue, 08 May 2018 19:31:54 GMT server:envoy status:200 x-envoy-upstream-service-time:2 content-length:178 content-type:application/json] of type:map[string]interface {}
2018-08-31T19:34:33.019953Z	error	attributes	Cannot convert value:map[:method:GET accept-encoding:gzip, deflate x-b3-parentspanid:e3afaeba60c58aaa x-b3-traceid:e3afaeba60c58aaa x-forwarded-proto:http :path:/details/0 accept:*/* x-b3-sampled:1 authority:details:9080 content-length:0 user-agent:python-requests/2.18.4 x-b3-spanid:e9ab222e0b5608f3 x-request-id:716f54f9-2f0f-93ad-b671-911fc9c57431] of type:map[string]interface {}
2018-08-31T19:34:33.019984Z	error	attributes	Cannot convert value:map[app:details version:555] of type:map[string]interface {}

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e58473c53f075178a1bc02917484ebc10c192834
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b568c608850c04c1588a5ab4f1f00c0dc07d72fb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6379d03705002ae860918a0876dea9ed2c6fe850
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e725dbb345a36458417ce8e34fce8260c4bfcefd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


rubysrc2cpg: add require tests

Ignored for now. Will update when regression is fixed

Closing this. Superceded by import node tests and fixes at #3035


global: state initialization fix

Sets state to extension instance also when __init__ and init_app
are called separately.  (closes #12)

Signed-off-by: Jiri Kuncar<EMAIL_ADDRESS>

@nharraud it should be ready for merging.


Predicted release dates from the release notes seem incorrect

The 3.9.0 release notes say 3.9.1 was to be released on June 8, 2022. 3.9.1 was released on July 13, 2022.
The 3.9.1 release notes say 3.9.2 should be expected on August 10, 2022. It was released early on July 21, 2022.
The 3.9.2 release notes say we can expect 3.9.3 on August 10, 2022.
Should these predictions just be dropped from the release notes, to avoid confusion?

I don't have an answer to whether they should or not, but release dates are governed by https://github.com/helm/community/blob/main/hips/hip-0002.md


Geometry fails to load in main cadview after viewing in preview pane sometimes

Not sure exactly what causes this but it happened after spending a bunch of time in the preview/properties pane

This has to do with the way preview shells are loaded and will be fixed when changes for #398 are pulled it


No named parameter with the name 'expandedColumn'.

Steps to reproduce:

flutter create myapp
cd myapp
cp ../examples/pluto_grid/example/pubspec.yaml .
cp ../examples/pluto_grid/example/lib/main.dart lib/main.dart
update pubspec.yml by deleting the path to pluto_grid
flutter pub add pluto_grid
flutter run -d chrome

Note: if I change the pubspec.yml, it works
  pluto_grid:
    path: ../examples/pluto_grid/

Here is compile error
lib/main.dart:106:51: Error: No named parameter with the name 'expandedColumn'.
    PlutoColumnGroup(title: 'Id', fields: ['id'], expandedColumn: true),
                                                  ^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/pluto_grid-2.8.0/lib/src/model/pluto
_column_group.dart:33:3: Context: Found this candidate, but the arguments don't
match.
  PlutoColumnGroup({
  ^^^^^^^^^^^^^^^^
lib/main.dart:109:54: Error: No named parameter with the name 'expandedColumn'.
      PlutoColumnGroup(title: 'A', fields: ['role'], expandedColumn: true),
                                                     ^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/pluto_grid-2.8.0/lib/src/model/pluto
_column_group.dart:33:3: Context: Found this candidate, but the arguments don't
match.
  PlutoColumnGroup({
  ^^^^^^^^^^^^^^^^
lib/main.dart:133:32: Error: Cannot invoke a non-'const' constructor where a
const expression is expected.
Try using a constructor or factory that is 'const'.
          configuration: const PlutoGridConfiguration(
                               ^^^^^^^^^^^^^^^^^^^^^^
lib/main.dart:128:34: Error: A value of type 'PlutoGridStateManager?' can't be
assigned to a variable of type 'PlutoGridStateManager' because
'PlutoGridStateManager?' is nullable and 'PlutoGridStateManager' isn't.
 - 'PlutoGridStateManager' is from
 'package:pluto_grid/src/manager/pluto_grid_state_manager.dart'
 ('../../../.pub-cache/hosted/pub.dartlang.org/pluto_grid-2.8.0/lib/src/manager/
 pluto_grid_state_manager.dart').
            stateManager = event.stateManager;
                                 ^
Waiting for connection from debug service on Chrome...             20.4s
Failed to compile application.

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.8.1 at /Users/bartonhammond/tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/bartonhammond/Library/Android/sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.10.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.60.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.26.0
[✓] Connected device (1 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 96.0.4664.110
• No issues found!

expandedColumn is a property for the next version and is included in the demo.
I will release the next version soon.
sorry.

Version 2.9.0 has been released.
https://github.com/bosskmk/pluto_grid/releases/tag/2.9.0


Houdini: Add geometry check for pointcache family

Changelog Description
When sop_path  on ABC ROP node points to a  non SopNode, these validators validate_abc_primitive_to_detail.py, validate_primitive_hierarchy_paths.py will error and crash when this line is executed
geo = output_node.geometryAtFrame(frame)

Are there other validators in place to ensure the publishing still gets invalidated?

yes, I faced this bug when testing wrong inputs on ROP sop_path
ROP sop_path is validated by Validate Output Node

I'm afraid validate_vdb_output_node needs the same check!
going to add it to this PR.

I'm afraid validate_vdb_output_node needs the same check! going to add it to this PR.

Isn't that only happened to vdbcache families?

Isn't that only happened to vdbcache family

you are right.
I thought about adding it to this PR as it's the same bug but happening in a different family

Thanks @mustafa-zarkash


Ignored files found that are tracked (ignoring folder except a single file)

Prerequisites

[X] Plugin is in the latest version
[X] Issue was not reported yet
[ ] Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description
Getting the message "Ignored files found that are tracked - .ignore plugin found some files that are tracked with Git which are also listed in .gitignore file".
The file it finds is "/application/uploads/16.pdf" and my .gitignore looks like this
/application/uploads !/application/uploads/16.pdf
So you can clearly se that the whole uploads-folder should be ignored except that one file so I shouldn't get this message.
Stack trace if available.

Steps to Reproduce

Ignore one folder in .gitignore
Exclude ignore for one single file in that folder in .gitignore
Restart PHPStorm. Maybe need to have checked in the .gitignore file, not sure.

Expected behavior: I expect .ignore-plugin not to complain about this
Actual behavior: .ignore-plugin complains about this
Reproduces how often: 100% (showing after restarting PHPStorm)
Versions
Plugin: 2.6.2
Can be found in Settings > Plugins > .ignore

IDE: 2018-1
Can be found in Help > About. Click on the copy icon on the left.

OS: Mac OS High Sierra 10.13.4
Information about operation system - type, version.

Additional Information

This feature will be disabled with v3.1.0


Security: ACS user access to all databases

ISSUE TYPE

Bug Report
Improvement Request
Enhancement Request

COMPONENT NAME

Core, MySQL

CLOUDSTACK VERSION

<IP_ADDRESS>-snapshot.20231113

CONFIGURATION

OS / ENVIRONMENT

Ubuntu 22.04
SUMMARY

ACS requires access to all MySQL databases, which creates a huge security hole for a shared MySQL instance.
Trying to limit the scope of ACS access yields in the access denied error (see below).
STEPS TO REPRODUCE

> `sudo cloudstack-setup-databases cloud:cloud@mysql --deploy-as=root`

/usr/share/cloudstack-management/setup/create-database.sql
lines: 64-65
GRANT process ON *.* TO cloud@`localhost`;
GRANT process ON *.* TO cloud@`%`;

// This works with the full access
GRANT ALL ON *.* TO 'root'@'hyp0' WITH GRANT OPTION

// This yields in an error:
- GRANT ALL ON mysql.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON billing.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON cloud.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON cloud_usage.* TO 'root'@'hyp0' WITH GRANT OPTION

EXPECTED RESULTS

ACS configs own databases only without an error

ACTUAL RESULTS

ACS wants a full access and gives an error when a limited db access is provided

We apologize for below error:
table:
/usr/share/cloudstack-management/setup/create-database.sql

Error:
b"ERROR 1045 (28000) at line 64: Access denied for user 'root'@'hyp0' (using password: NO)\n"

@tampler , does it say to what 'root'@'hyp0' tries to get access?
in a simulator env:
mysql> show databases;
+--------------------+
| Database           |
+--------------------+
| cloud              |
| cloud_usage        |
| information_schema |
| mysql              |
| performance_schema |
| simulator          |
| sys                |
+--------------------+

I am not sure but I think root needs access to all to install cloud. Though I am not rreally sure about infomation_schema and performance_schema. Can you try to add at least mysql and sys?

Hi @DaanHoogland
This is my setup
My command: mysql -h mysql -u root -p
mysql> show databases;
+--------------------+
| Database           |
+--------------------+
| cloud              |
| cloud_usage        |
| information_schema |
| mysql              |
| performance_schema |
| sys                |
+--------------------+
6 rows in set (0.03 sec)

mysql> select user, host from mysql.user;
+------------------+-----------+
| user             | host      |
+------------------+-----------+
| cloud            | %         |
| cloud            | hyp0      |
| root             | hyp0      |
| cloud            | localhost |
| debian-sys-maint | localhost |
| mysql.infoschema | localhost |
| mysql.session    | localhost |
| mysql.sys        | localhost |
| root             | localhost |
+------------------+-----------+
9 rows in set (0.00 sec)
mysql> show databases;
+--------------------+
| Database           |
+--------------------+
| cloud              |
| cloud_usage        |
| information_schema |
| mysql              |
| performance_schema |
| sys                |
+--------------------+
6 rows in set (0.03 sec)

mysql> select user, host from mysql.user;
+------------------+-----------+
| user             | host      |
+------------------+-----------+
| cloud            | %         |
| cloud            | hyp0      |
| root             | hyp0      |
| cloud            | localhost |
| debian-sys-maint | localhost |
| mysql.infoschema | localhost |
| mysql.session    | localhost |
| mysql.sys        | localhost |
| root             | localhost |
+------------------+-----------+
9 rows in set (0.00 sec)

@tampler , does it say to what 'root'@'hyp0' tries to get access?
It actually says that it wants a GRANT ALL ON *.* TO 'root'@'hyp0' WITH GRANT OPTION  access for my MySQL instance instead of a more limited subset:
- GRANT ALL ON mysql.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON billing.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON cloud.* TO 'root'@'hyp0' WITH GRANT OPTION
- GRANT ALL ON cloud_usage.* TO 'root'@'hyp0' WITH GRANT OPTION

So I had to fallback to the *.* notation just to have setup done. However, this is a security hole and ACS shouldn't anyhow access databases beyond its own scope.

So I had to fallback to the *.* notation just to have setup done. However, this is a security hole and ACS shouldn't anyhow access databases beyond its own scope.

I think it should only need to allow from localhost. And user root is only used during setup so I don't think it is a big issue. Did you try to remove rmote access to root after setup, and did it work?
We can try to find the limits of what should work, but root for sure needs to do (part of) the setup.

Hi @DaanHoogland
Okay let's get deeper into this. I'll dig deeper after solving #8218

From mysql documentation:

https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_process
The PROCESS privilege controls access to information about threads executing within the server (that is, information about statements being executed by sessions).
The PROCESS privilege also enables use of the SHOW ENGINE statement, access to the INFORMATION_SCHEMA InnoDB tables (tables with names that begin with INNODB_), and access to the INFORMATION_SCHEMA table.

In ACS, access to information_schema is required during upgrades. There could be other use-cases also where information_schema access is required. PROCESS is an administrative privilege and cannot be granted to specific database. It is global.

Administrative privileges enable users to manage operation of the MySQL server. These privileges are global because they are not specific to a particular database.

So, user cloud  requires PROCESS  privilege and it has to be *.* (global)

To be clear,

The script cloudstack-setup-databases use root user to create cloudstack database
ACS uses cloud user to access and modify the databases cloud and cloud_usage

I do not think the privileges of cloud user is a problem.
The root user should have higher privileges, for example, create databases, create procedures in mysql database. However, the script needs to be executed only once during the whole ACS setup (you do not need to execute it on extra management servers and database servers).
Do you mean the privileges of root user is a security issue ?

@tampler is this issue answered to our satisfaction?


Some formatting issues on Identify

Some formatting issues on Identify that I noticed when I was trying out different languages:
Quality Grade buttons neither center nor left-aligned:

Buttons squished together when translation is "long":

Ranks and sort by irregularly capitalized in filters:

Ranks irregularly capitalized on cards:

"Show" filters irregularly capitalized:

(yes German nouns, but if Deine is capitalized, shouldn't mit and hat be?)
Example slug is cut off. Possible to show full text on hover?

Iconic taxa not evenly spaced (not related to language):

(Sorry if some of these like the capitalization are known issues that should be resolved via TranslateWiki.)

Regarding capitalization, this is a "damned if we do, damned if we don't" situation, so unless you're seeing something where things are consistently but inappropriately uppercase or lowercase, the solution is to update the translations on Crowdin, e.g. https://crowdin.com/translate/inaturalistweb/38/en-de#17178 and https://crowdin.com/translate/inaturalistweb/38/en-de#25488


CircleCI fails the uploading test results step

Example job
This doesn't actually break the builds, though, so low priority.
This is happening now in both chiubaka/eslint and contentful-importer.

Here is another example failing job.


chore: refactor doh

@ohaiibuzzle  Refactored doh part little bit. Please check.

@ohaiibuzzle  All fine now?


demo is not updated and not working properly

I think demo is not working properly, it asks to read very unusual phrases. Is it outdated?

The demo is working fine, the actual phrases are temporary, there is a blocking task here https://github.com/720kb/butler/issues/12
If you want to contribute feel free we'll be glad!


Allow creating new Projects (from OddBird).

NOTE: This should be reviewed and merged after https://github.com/SFDO-Tooling/Metecho/pull/2018 is already merged.

Features:

Allow creating new Projects/Repos (https://github.com/oddbird/Metecho/pull/1376)

@davidmreed Is this ready to be merged?


Create gitter chat

@t3chnoboy would be great for creating a gitter.im chat for this project. That would help resolve a lot of issues about how to use the module. IMO, its better than making issues for each question about usage

https://gitter.im/thepiratebay-node/Lobby
Done 🎉


High number of queries UI

This is the mockup:

Please use this template to implement:

Tooltip for 'Typical' - Typical number of queries for endpoints in this service.

relates to backend issue https://github.com/digma-ai/digma-collector-backend/issues/1433

@doppleware I see you added few properties to the insight

Median Time - what should it be? we measure the queries count...
"% of entire time" - not sure I understand.
for both 1 and 2, do you have some formula in mind?

Defined in the original ticket:

How much of the endpoint duration is the duration of the queries.

@doppleware ,

the Median described in the ticket relates to median of queries count and not to duration
we have that number in the duration breakdown, can we take it from there?
and if not so need to have some formula for it.


Enable offboard attitude for coaxial airframes

Fills offboard attitude thrust setpoints with a coaxial airframe.
The thrust setpoint was silently ignored. We should either cast _mavlink->get_system_type() to the enum type to make sure all cases are covered, or add a default case that rejects the offboard mode.

CI failure seems unrelated, Timeout of 10.0 mins reached, stopping...


examples/cassandra - create the service before any pod is started

Fixes #10016

This is a low risk doc-only change. LGTM.


Add updated CU SRL Information

Hello! Here to request CU SRL get added to the list. We just launched crowdfunding. Best, Zoe

Thank you for your contribution!
I see the fundraiser is scheduled to end on April 28th. Is it possible to make a donation afterwards?

Hello,
The crowdfunding link will expire after April 28th and we currently don't
have an ongoing donation link available. I will let you know if that
changes!
Best,
Zoe Roy
On Sat, Mar 26, 2022 at 8:56 PM Lars Osborne @.***>
wrote:

Thank you for your contribution!
I see the fundraiser is scheduled to end on April 28th. Is it possible to
make a donation afterwards?
—
Reply to this email directly, view it on GitHub
https://github.com/Lars-0/StudentRocketProjects/pull/15#issuecomment-1079824951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJY5WCB2Y5YFGXNZH2XXTVLVB7E5LANCNFSM5RSFTRNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


new: document grpc flags

Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind content
Any specific area of the project related to this PR?

/area blog

/area documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Change visible here: https://5e4bbadf3787df0009b91aa9--falcosecurity.netlify.com/docs/configuration/

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 8ce137e7860a610c0ac368bb2c2dd246cb93b628


Make 3.0.0 snapshots installable via git

Currently it's hard to use an unpublished snapshot from the 3.0.0 branch inside inside a npm project. Installing fp-ts as git dependency does not work.
The reason for this is that the build is run only from the release script. When installing an npm dependency via git (npm install github:<project>/<repo>#<ref>) a prepare script can be used to build the package on the user's side.
This PR adds a prepare script that mimics the publishing process.
Here are the steps to try it out:
mkdir my-project
cd my-project
npm init -y
npm install github:no-day/fp-ts#feature/3.0.0-git-installable

in a source file you can now use new features like:
import * as J from "fp-ts/Json"

It's hard to test, but I'm quite sure that it does not interfere with other tasks.
Note, reasons unknown to me, this does not work with yarn yet. They seem to ignore the prepare script. Maybe I'll find out later or someone else knows.
If you mind that the script is not cross platform, we can chat. But I'll wait until the overall propose is discussed.

Ohhh, now I see that we can use fp-ts@next.
Well, then I think we don't need this PR.


Add ping test before slot swap

Context
As per the ticket it is noted that sometimes a slot swap from staging to production can take up an nondeterministic time period (1-7 mins) with the risk of the downtime during that period.
To give us more confidence on the swap process, this step tests if the deployed container image on the staging slot is healthy by pinging the /check endpoint and waiting for a 200 status before proceeding with the swap operation.
Changes proposed in this pull request
Manually ping the /check endpoint on staging slot of the app service and check for 200 status to test if the staging slot is warmed up and ready to be swapped to production.
Guidance to review
Check power shell script.
Link to Trello card
https://trello.com/c/Clapqcem/1645-investigate-swap-slots-duration-variability
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[-] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Ah, one thing I forgot to mention, can you please squash the commits together and make sure to include a meaningful commit message?


Build error os OSX: JmxUtils.java:[23,21] error: cannot find symbol

Java amateur alert!
raarts$ mvn clean package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building kafdrop 2.2.0
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ kafdrop ---
[INFO]
[INFO] --- maven-resources-plugin:2.7:copy-resources (prepare-dockerfile) @ kafdrop ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 2 resources
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ kafdrop ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 11 resources
[INFO] Copying 13 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ kafdrop ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Compiling 37 source files to /Users/raarts/work/nv/rapi-elixir/Kafdrop/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/raarts/work/nv/rapi-elixir/Kafdrop/src/main/java/com/homeadvisor/kafdrop/util/JmxUtils.java:[23,21] error: cannot find symbol
[ERROR]  package sun.management
/Users/raarts/work/nv/rapi-elixir/Kafdrop/src/main/java/com/homeadvisor/kafdrop/util/JmxUtils.java:[36,46] error: cannot find symbol
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.757 s
[INFO] Finished at: 2017-11-28T14:31:00+01:00
[INFO] Final Memory: 27M/91M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project kafdrop: Compilation failure: Compilation failure:
[ERROR] /Users/raarts/work/nv/rapi-elixir/Kafdrop/src/main/java/com/homeadvisor/kafdrop/util/JmxUtils.java:[23,21] error: cannot find symbol
[ERROR]  package sun.management
[ERROR] /Users/raarts/work/nv/rapi-elixir/Kafdrop/src/main/java/com/homeadvisor/kafdrop/util/JmxUtils.java:[36,46] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

What version of Java are you using?

$ java --version
java 9.0.1
Java(TM) SE Runtime Environment (build 9.0.1+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

java version "11.0.1" 2018-10-16 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.1+13-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.1+13-LTS, mixed mode)

The sun.management package has gone away with Java 9 and above.  I haven't (yet) found an appropriate replacement to using he sun.management.Agent class to get the fully resolved JMX properties.

I would have an look into https://jolokia.org/
https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-jmx.html#production-ready-jolokia

Any update on this.

Hello, Any update on this, I am getting the same error on my window 10 machine
JAVA version:-
java -version
java version "1.8.0_161"
Java(TM) SE Runtime Environment (build 1.8.0_161-b12)
Java HotSpot(TM) Client VM (build 25.161-b12, mixed mode)
Error:-
$ mvn clean package
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project kafdrop: Compilation failure: Compilation failure:
[ERROR] \Users\AlokAdhao\Desktop\IBM\kafdrop\Kafdrop\src\main\java\com\homeadvisor\kafdrop\util\JmxUtils.java:[23,21] error: cannot find symbol
[ERROR] \Users\AlokAdhao\Desktop\IBM\kafdrop\Kafdrop\src\main\java\com\homeadvisor\kafdrop\util\JmxUtils.java:[36,46] error: cannot find symbol

You won't be able to utilise sun.management unless you permit it explicitly using the --add-exports JVM option.
This is unlikely going to get fixed in Kafdrop 2.x, as there is no real development taking place. Consider updating to the next major version – Kafdrop 3.


Create .gitignore

Reasons for making this change:

TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

fdsf

dsfsdf

xZVsd


Slow Performance on search when serverSide is true

The datatable is working properly with server side data, but i am facing a performance issue when i am trying to search for an item, where a single key is taking up to 500ms for a number of rows equal to 10.
Expected Behavior
fast performance
Current Behavior
very slow performance
Steps to Reproduce (for bugs)
    const options = {
      selectableRows: false,
      count: totalCount,
      serverSide: true,
      page,
      rowsPerPage,
      filter: false,
      searchText,
      onSearchChange: (data) => {
        this.setState({searchText: data || ''}, ()=>{
            this.load();
        });
      },
      onSearchClose: () => {
        this.setState({searchText: ''});
      }
    };

try to search with serverSide: true

Your Environment

Tech
Version

Material-UI
^3.9.2

MUI-datatables
^2.0.0-beta.58

React
^16.5.2

browser
chrome :Version 88.0.4324.50 (Official Build) beta (x86_64)

Tech
Version

MUI-datatables
^2.0.0-beta.58

Would you like to upload the version?
ref : https://github.com/gregnb/mui-datatables#plug-ins

Tech
Version

MUI-datatables
^2.0.0-beta.58

Would you like to upload the version?
ref : https://github.com/gregnb/mui-datatables#plug-ins

Thank you @wdh2100 for your reply,
sorry, i didn't get well what should i upload?
do you mean upload MUI-datatables from node_modules ?
Thank you

Thank you @wdh2100 for your reply,
sorry, i didn't get well what should i upload?
do you mean upload MUI-datatables from node_modules ?
Thank you

@Moussawi7
sorry, Update version 3.x.x And use debounceSearchRender

@Moussawi7
sorry, Update version 3.x.x And use debounceSearchRender

Thank you @wdh2100 , everything is working fine.

Thank you @wdh2100 , everything is working fine.


Fix clearing read push notifications on Android

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.14-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @arosiclair
Slack conversation: N/A
Action Performed:

Log into NewDot
Send yourself a few messages
Verify push notifications display for those messages
Open the chat

Expected Result:
The chat's notifications are cleared
Actual Result:
The notifications are NOT cleared
Workaround:
Clear notifications manually
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
N/A

View all open jobs on GitHub

@anmurali no need to triage this. I'm going to get an expert contributor to work on this issue since it requires a bit of a refactor in native code.

Problem
We implemented functionality to clear notifications for a chat when opening in https://github.com/Expensify/App/pull/31762.
However, this didn't work well on Android because clearing notifications using Airship's JS APIs like we do here, does not run our native onNotificationDismissed callback which means our NotificationCache doesn't get updated. We use the cache to build threaded notifications, so subsequent notifications incorrectly display old cached messages.
To fix this we temporarily disabled the clearing functionality on Android in this PR.
Solution
Let's get rid of the cache and use native APIs to query active notifications instead. Specifically, we can use getActiveNotifications(). Any extra data we need to store on the notification like the reportID can be stored in extras. This should allow us to continue using JS APIs to clear notifications without having to worry maintaining a cache in native code.

Just shared this with a few agencies. Looking to get somebody to work on it pretty soon.

Most people are out until the new year. I'll revisit this next week.

Hi, I'll be working on that issue

FYI for contributors: you need to replace development appKey and appSecret in airshipconfig.properties with the production ones

@mateuuszzzzz can you just post an update of your progress here?

@mateuuszzzzz can you just post an update of your progress here?

Hi, sorry for the delay.
Probably the problem is in ReactAutopilot.kt which handles adding ReactNotificationProvider and later by creating an extender it adds our custom provider. I will investigate it more and maybe we will be able to fix this autopilot instead of doing a fallback to the official Android notifications API.

We had some conversation about this here

@mateuuszzzzz any more progress? This has been open for a while so we should start prioritizing fixing it. I saw you're also working on the ideal nav for wave8. if you don't have the bandwidth, maybe someone else at SWM can pick this up?

@mateuuszzzzz - can you respond to Andrew here? (https://github.com/Expensify/App/issues/33568#issuecomment-1900586221)

Hi @arosiclair 👋🏼 In order to prioritize this issue, I'll be taking care of it from this point. Before diving in, I've familiarized myself with the context and connected with @mateuuszzzzz to gather more information about it. From what I've seen, the preferred solution is to eliminate the NotificationCache entirely, and I've successfully done that today. If time permits, my next steps involve rewriting a part of the solution to pass Parcelable objects to extras instead of more primitive information about the user. After that, I'll proceed with re-enabling the clearing functionality.

Thanks for the update! Assigning you

@robertKozik has just been assigned and is working on this.

Hi! The PR is ready to review!
cc. @arosiclair

This is not a regression (the feature was just not implemented for Android yet), but we should add regression steps now that it is implemented on all platforms.

Maybe I was responsible for BZ Checklist. Please assign me here

Regression Test Proposal

Log in
Accept prompt for notification permission
Open concierge chat
Send 3 messages to yourself
Verify notifications display for the messages
Switch to the chat
Verify those notifications are cleared
Switch away from the app

On web/desktop, switch tabs or minimize the window
On native, go to the home screen

Send another 3 messages to yourself
Switch back to the app
Verify those notifications are cleared
Switch to the concierge chat
Send another 3 messages to yourself
Switch to other chats (not the one with the messages)
Verify those notifications are NOT cleared

Do we agree 👍 or 👎

So far as I can tell, no one needs to be paid out manually. But confirming here, and assigning a backup in case he does need to be paid as I am OOO

Payouts due:
Contributor+: $250 @robertKozik (is with SWM so no Expensify payment needed)
Eligible for 50% #urgency bonus? NA
Upwork job is = NA
Regression test submitted here - https://github.com/Expensify/Expensify/issues/370314
We'll keep this open since it's still in a regression period

hi! Sorry I'm ooo sick today - I'll follow up on this tomorrow

Paid out based on the payment summary here - https://github.com/Expensify/App/issues/33568#issuecomment-1954422479
Closing as complete


Is there a way to run the e2e test on firebase test lab

Description

Is there a way to run the e2e test on firebase test lab , so that i can test my UI test on multiple devices .
Environment

Detox: latest
React Native: latest
Node:latest
Device:
OS:
Test-runner (select one): mocha

This issue is related: #2830.
I don't think there's a point in trying to run Detox on firebase test lab, because it runs native tests and in a Detox environment all JS tests are run under that same test, dispatched over and over again.


Support for cucumber 4.0.0

Hello,
Last version was relased. Upgrading wdio-cucumber-framework to cucumber 4.0.0 is good to everyone.

@espekkaya I agree, feel free to propose a PR


fix(docker): install bash on alpine - required by crontab

@sweng66 let me know if the pubmed search script worked - I'll make this PR final if everything passed


Fix the path under windows for dockerimages.md

Fix the path under windows for dockerimages.md

@GordonTheTurtle I can't find the fail reason, how about you?


A question about the features.

Thank you for your contribution. I noticed that you used four audio features in the calculation of audio features. can you tell me why you used these four features?

MFCC
Spectral Centroid
Chroma
Spectral Contrast
There is nothing magical about these features, but let me give some intuition or motivation.

First of all, they are easily computed, available in librosa and well understood (MFCC for speech, Chroma for musical pitch, Spectral Centroid & Contrast for Timbre) If we think about speech, pitch & timbre, these roughly correlate to features we may think about when comparing  musical styles. Like vocals or instrumentation in rock and roll versus classical. Or pitch sequences in Jazz vs Pop.

They are not too highly correlated, I did experiments with a much bigger set of lower-level spectral descriptors (link) and I found these to contribute some "classification power" without being too redundant.

Along those lines, I didn't want too many features because that increases training time and honestly, this is supposed to be a lightweight audio task, that can run on a laptop and get results quickly.

If you're interested, you can explore more features, or maybe try to learn a better representation!

Closing due to inactivity, I guess I must have answered all questions.


fix(tabletoolbar): batch actions are missing icon description

Summary

fix(table): batch actions are not sending the icon description through

Change List (commits, features, bugs, etc)

pass through all batch action props to the BatchAction

Acceptance Test (how to verify the PR)

Verify if we mouseover the batch action icons in the Table Toolbar with batch actions story that the correct alt tag shows on hover

:tada: This PR is included in version 1.40.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.40.1 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Mapping conflict

I got following error, any suggesion to fix problem?

Thanks for the feedback. In this case, please reindex to resolve conflict.
https://discuss.elastic.co/t/kibana-conflict-type-field/270667


Footer About Us Section

Remove text in red square

@brittneypostma Assign this to me.

@brittneypostma I would like to contribute to this

can i please work on this, do assign this to me. I'm enthusiastic to work on it


[bug] tauri-cli fails to build

Describe the bug
tauri cli fails to build. Affect both latest v2.0.0-beta.6 and 1.5.10
Probable cause: https://github.com/rust-lang/log/pull/592
part of log v0.4.21 released 2 days ago. Timing does coincide with my latest successful build of tauri-cli v2.0.0-beta.5 as well as corroborate the compiler error.
Reproduction
run: cargo install tauri-cli
from a clean cache (deleted my .cargo/registry)
Expected behavior
No response
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 122.0.2365.59
    ✔ MSVC:
        - Visual Studio Build Tools 2019
        - Visual Studio Community 2022
    ✔ rustc: 1.77.0-beta.5 (f2043422f 2024-02-17)
    ✔ cargo: 1.77.0-beta.5 (837c09f04 2024-02-16)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: beta-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
    - node: 20.11.1
    - npm: 10.2.4

[-] Packages
    - tauri-cli [RUST]: 2.0.0-beta.5
    - @tauri-apps/api : not installed!
    - @tauri-apps/cli [NPM]: 2.0.0-beta.6

[-] App

Stack trace
Compiler error:

error[E0599]: no method named `to_str` found for struct `log::kv::Value` in the current scope
   --> C:\Users\Wyti\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tauri-cli-1.5.10\src\lib.rs:132:29
    |
132 |         let action = action.to_str().unwrap();
    |                             ^^^^^^ help: there is a method with a similar name: `to_cow_str`

Additional context
No response

fixed in https://github.com/tauri-apps/tauri/pull/9034 and will be released soon, for now install using --locked command


refactor: Index datetime fields as int64

Codecov Report

Merging #429 (d2c32b2) into main (3675e39) will increase coverage by 0.09%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   29.83%   29.92%   +0.09%
==========================================
  Files          77       78       +1
  Lines        8065     8114      +49
==========================================
+ Hits         2406     2428      +22
- Misses       5418     5445      +27
  Partials      241      241

Impacted Files
Coverage Δ

query/filter/selector.go
27.08% <0.00%> (-3.15%)
:arrow_down:

server/services/v1/search_indexer.go
13.19% <0.00%> (-1.84%)
:arrow_down:

schema/fields.go
81.15% <75.00%> (+1.15%)
:arrow_up:

lib/date/converter.go
100.00% <100.00%> (ø)

schema/collection.go
67.15% <100.00%> (+2.58%)
:arrow_up:

schema/reserved.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Randoop coverage

Modifications and additions to calculate randoop coverage of the defects4j test suite.
(I believe Michael will review on return from holiday.)

This fell through the cracks, perhaps because of Mark's comment that I would review it.
It looks OK to me.
@rjust , can you take a look and either request changes or merge the pull request?  Thanks!


This Copy-PnPFile command doesn't copy version history

This Copy-PnPFile command doesn't copy version history but the documentation page states the following:
-IgnoreVersionHistory
If provided, only the latest version of the document will be copied and its history will be discared. If not provided, all historical versions will be copied along.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85cba281-56e9-dfba-0ed8-df9a22029eaa
Version Independent ID: 47c94158-6136-04ee-5fc0-712abcb1827a
Content: Copy-PnPFile (SharePointPnPPowerShell)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Copy-PnPFile.md
GitHub Login: @Techwriter40
Microsoft Alias: kirks

Hello @thiagottss
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues here, in that repository, where a member of the PnP community will be able to correct the article with your feedback.
The documentation for PnP cmdlets is then sync from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @thiagottss Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[Oracle] Added fix for inspector returning internal SYS columns

DBA_TAB_COLS can contain internal system columns which shouldn't be returned. We can filter these by HIDDEN_COLUMN = 'YES'. Issue described more here:
https://stackoverflow.com/questions/45756882/why-does-oracle-add-a-hidden-column-here/45907226

Released in 1.6.1


limelib(1.11.2) help needed for compat reading of block(causing game lock up)

limelib: limelib-1.11.2-1.4.1
Forge: 1.11.2-2253
hammer core: HammerCore_1.11.2-1.2.9
blackhole storage: Black Hole Storage 1.11.2-4b
fml client latest:
fml-client-latest (2).txt

that's a problem with black hole storage.
it's up to @MrDimkasStudio

okay i will let him know :D


[BUG] PHP Fatal: DashboardBundle/Model/WidgetConfigs.php

Found a bug related to the dashboard bundle.
The DashBoardController:widgetAction checks for dashboard.yml config but doesn't check for the Bundle param.
Example
URL: http://crm-dev.dev/dashboard/widget/my_leads/XXXBundle/myLeads?_wid=dashboard-widget-623280200-94&_widgetContainer=dashboard-item&_widgetId=94

PHP message: PHP Fatal error:  Call to a member function getName() on null in /var/www/vhosts/orocrm/current/vendor/oro/platform/src/Oro/Bundle/DashboardBundle/Model/WidgetConfigs.php on line 231

The XXXBundle doesn't exist and leads to an error.
EDIT: the error comes from the wrong _widgetId

If the web server shows fatals, this could be seen as a Full Path Disclosure for a logged in attacker.

The PR with the fix was merged so I'm closing this.


Add time to the date in events

Add time to display along with the date in events view for each event.

Fixed by #30


Inline MyDateUtil into exercise 29 and clarify wording

Hi, I thought the wording in exercise 29 could be slightly more explicit in explaining that the user doesn't have to implement addTimeIntervals themselves. As the definition is in a separate file, it's easy to miss (at least I managed to).
Since no other koans currently use addTimeIntervals, I also thought it might be more clear to put the definitions directly into the exercise (as in exercise 35).

@jarmar Thanks! I just used your commit that changes the wording, I hope that's enough to prevent confusion. This function is also mentioned in "references".


Update lametric to 3.1.2

Please update my adapter ioBroker.lametric to version 3.1.2.
This pull request was created by https://www.iobroker.dev c0726ff.

3.1.2 created 27.12.2023
36 user
OK


Avoid false positives applying Google3 specific functionality to non-google3 specific bazel workspaces

Related issue: https://github.com/dart-lang/sdk/issues/49544
The cherry pick was fine to unblock but I think the right solution to this is to stop treating non-g3 BAZEL workspaces as BAZEL workspaces as we don't really support that case anyway.
To detect g3 bazel workspaces we should check for the magic
dart/config/ide/flutter.json
file like the Flutter IntellIJ support does.
See
https://github.com/flutter/flutter-intellij/blob/e6bb872cca41d5bcdaebc073c6c6882f3fc22633/flutter-idea/src/io/flutter/bazel/Workspace.java#L34
That should avoid false positives like this and keep our different tools consistent.

Fyi @scheglov

Start https://dart-review.googlesource.com/c/sdk/+/254343

Replacing the marker file: https://dart-review.googlesource.com/c/sdk/+/254480

https://dart-review.googlesource.com/c/sdk/+/255141


tar: Error opening archive: Failed to open

brew config output
~/source/dabai/frontend/be-illidan-frontend on  master! ⌚ 17:20:12
$ brew config                                                                                ‹ruby-2.7.2›
HOMEBREW_VERSION: 3.2.2
ORIGIN: https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/brew.git
HEAD: 7d37d09709b6fbd5b89b468eb0b4438ffa0fb81c
Last commit: 3 days ago
Core tap ORIGIN: https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/homebrew-core.git
Core tap HEAD: aa1e42b79651749128ca925ab515b32e288054c5
Core tap last commit: 5 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BOTTLE_DOMAIN: https://mirrors.aliyun.com/homebrew/homebrew-bottles
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.brvutoMVTc/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_NO_AUTO_UPDATE: set
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 12.0.5 build 1205
Git: 2.31.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.2.3-x86_64
CLT: <IP_ADDRESS>.1
Xcode: 12.5
XQuartz: 2.7.11 => /opt/X11
(base)

brew doctor output
~/source/dabai/frontend/be-illidan-frontend on  master! ⌚ 17:20:17
$ brew doctor                                                                                ‹ruby-2.7.2›
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Suspicious https://github.com/Homebrew/brew git origin remote found.
The current git origin is:
  https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/brew.git

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
  git -C "/usr/local/Homebrew" remote set-url origin https://github.com/Homebrew/brew

Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or run:
  softwareupdate --all --install --force

If that doesn't show you any updates, run:
  sudo rm -rf /Library/Developer/CommandLineTools
  sudo xcode-select --install

Alternatively, manually download them from:
  https://developer.apple.com/download/more/.
You should download the Command Line Tools for Xcode 12.5.

Warning: Suspicious https://github.com/Homebrew/homebrew-core git origin remote found.
The current git origin is:
  https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/homebrew-core.git

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
  git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/homebrew-core

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed with `brew diy`.
You should find replacements for the following formulae:
  python@2
  pygtk
  unrar
  pygobject

Warning: You have the following deprecated, cask taps tapped:
  caskroom/cask
Untap them with `brew untap`.

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  archey
  ilmbase
<EMAIL_ADDRESS>  pandoc-citeproc
  py2cairo
  sshfs

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and which additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew-provided
script of the same name. We found the following "config" scripts:
  /usr/local/anaconda3/bin/icu-config
  /usr/local/anaconda3/bin/krb5-config
  /usr/local/anaconda3/bin/freetype-config
  /usr/local/anaconda3/bin/xslt-config
  /usr/local/anaconda3/bin/libpng16-config
  /usr/local/anaconda3/bin/python3.7-config
  /usr/local/anaconda3/bin/libpng-config
  /usr/local/anaconda3/bin/xml2-config
  /usr/local/anaconda3/bin/python3.7m-config
  /usr/local/anaconda3/bin/python3-config
  /usr/local/anaconda3/bin/curl-config
  /usr/local/anaconda3/bin/ncursesw6-config
  /usr/local/anaconda3/bin/pcre-config

Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected header files:
  /usr/local/include/node/v8-inspector-protocol.h
  /usr/local/include/node/v8-inspector.h

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  python@2
  ghostscript
  mono
  youtube-dl
  nmap

Warning: Homebrew's "sbin" was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting your PATH for example like so:
  echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.zshrc
(base)

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
brew upgrade
What happened (include all command output)?
==> Installing dependencies for node: libuv
==> Installing node dependency: libuv
==> Pouring libuv-1.41.1.big_sur.bottle.tar.gz
tar: Error opening archive: Failed to open '/Users/dolphin/Library/Caches/Homebrew/downloads/36c64f938332041e83f85455cd56f65b28c74cb0b5909bc8e785cab1e088c343--libuv-1.41.1.big_sur.bottle.tar.gz'
Error: Failure while executing; tar --extract --no-same-owner --file /Users/dolphin/Library/Caches/Homebrew/downloads/36c64f938332041e83f85455cd56f65b28c74cb0b5909bc8e785cab1e088c343--libuv-1.41.1.big_sur.bottle.tar.gz --directory /private/tmp/d20210715-83539-1qre677 exited with 1. Here's the output:
tar: Error opening archive: Failed to open '/Users/dolphin/Library/Caches/Homebrew/downloads/36c64f938332041e83f85455cd56f65b28c74cb0b5909bc8e785cab1e088c343--libuv-1.41.1.big_sur.bottle.tar.gz'
What did you expect to happen?
upgrade success
Step-by-step reproduction instructions (by running brew commands)
brew upgrade

https://apple.stackexchange.com/questions/424091/tar-error-opening-archive-failed-to-open-when-upgrade-using-brew

This is most likely caused by the mirrors you're using. Please do
unset HOMEBREW_BOTTLE_DOMAIN

along with the two commands suggested by brew doctor:
git -C "/usr/local/Homebrew" remote set-url origin https://github.com/Homebrew/brew
git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/homebrew-core

Then, do brew update and try again.


shared/storage: refactor storage to work with pointers

to x509.Certificate not values
Signed-off-by: Nagy Károly Gábriel<EMAIL_ADDRESS>

@karasz can you squash the commits in the pr branch so it can be merged without taking ownership please?


CNN parameters not being updated for ACs

The weights of the CNN layers dont get updated in the CNN AC classes. Formally, this is what I mean -
The CNN actor critic class -
class CNNActorCritic(BaseActorCritic):
    def __init__(args)
        super(CNNActorCritic, self).__init__()
        self.feature, output_size = cnn((framestack, 16, 32))
        self.actor = MlpPolicy(
            output_size, action_dim, policy_layers, discrete, **kwargs
        )
        self.critic = MlpValue(output_size, action_dim, val_type, value_layers)

    def get_action(
        self, state: torch.Tensor, deterministic: bool = False
    ) -> torch.Tensor:
        state = self.feature(state)
        state = state.view(state.size(0), -1)

        action_probs = self.actor(state)
        action_probs = nn.Softmax(dim=-1)(action_probs)
        # Som lines deleted
        return action, distribution

    def get_value(self, inp: torch.Tensor) -> torch.Tensor:
        inp = self.feature(inp)
        inp = inp.view(inp.size(0), -1)

        value = self.critic(inp).squeeze(-1)
        return value

Above, self.feature is the nn.Sequential object to be used (The CNN)
But the optimizers in the agents -
self.optimizer_policy = opt.Adam(self.ac.actor.parameters(), lr=self.lr_policy)
self.optimizer_value = opt.Adam(self.ac.critic.parameters(), lr=self.lr_value)

The self.ac.actor.parameters() and self.ac.critic.parameters()   are just the params of the actor head and the critic head. So what about self.ac.feature.parameters()? That does not seem to be updated anywhere

I think feature params should be added to both. Not sure though

Yeah, checked by printing out the weights. I'll add this too in my current PR.
I'll close this for now?

Raise a separate PR, if possible.

On 03-Sep-2020, at 8:00 PM, hades-rp2010<EMAIL_ADDRESS>wrote:
Yeah, checked by printing out the weights. I'll add this too in my current PR.
I'll close this for now?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/315#issuecomment-686531686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ66OIR6D7F2TQ7QTFLSD6R6RANCNFSM4QS3A3RQ.

#307 Takes care of this
Closing this for now


Accepted Revision - SDL-0293 Enable OEM exclusive apps support

Added revision for discussed comment from review.

@vladmu please review this PR

@LitvinenkoIra looks good to me

Move PR to open


HHH-12752 - @OneToMany on non primary key cause additional select for…

https://hibernate.atlassian.net/browse/HHH-12752

Superseded by https://github.com/hibernate/hibernate-orm/pull/3869


Page gives incorrect instructions

[Enter feedback here]
Clicking on the Domains link to go to the domains tab takes me to a page where I can select the domain. After that, nothing matches
"On the Domains page, select your domain, then select Start setup. You'll go back to the domains setup wizard to see the specific value you need to add."
There is no Start setup shown for the domain. After that, none of the steps apply

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 854cbadf-a802-0782-5a3a-b839995ff7fd
Version Independent ID: b511466a-2505-4e90-548c-3fa5b6f2aedc
Content: Gather the information you need to create DNS records - Microsoft 365 admin
Content Source: microsoft-365/admin/get-help-with-domains/information-for-dns-records.md
Service: microsoft-365-business
GitHub Login: @nataliekagole
Microsoft Alias: nkagole

@pvolve Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/11023
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @pvolve Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Merge Release/6.0.1 to dev

Can you please also add that note to our release onenote. Thanks

done


BufMut does not include safety invariants in trait documentation

BufMut is unsafe to implement, but there are no safety requirements telling users what they need to ensure for their implementations to be sound. It looks like https://github.com/tokio-rs/bytes/issues/329 lists out the requirements, so they may just need to be translated into documentation.

Yes, it looks like you are correct.


Add Lighttpd in supported server

LIghttpd is also a lightweight server where boxbilling can be installed.

finally got those rewrite rule working. Should I add an example like nginx one in /data folder? In this same patch.

That sounds like a good idea to me.

I would like an example config linked to by the readme.

Does that need to be from the readme? I think it's much more important that it is in docs. But if there is an example config file added to the /data file, then maybe the readme can point people to look at that (or the nginx one for nginx) when installing?

We can create a page for Lighttpd once we get our documentation up-to-date.

@BenNottelling Does that need to be from the readme? I think it's much more important that it is in docs. But if there is an example config file added to the /data file, then maybe the readme can point people to look at that (or the nginx one for nginx) when installing?

I just meant making the text a hyperlink to the BB docs for LIghttpd so people can easily find it. Apache and nginx both require less setup so I think it's less of a priority to do so.


Round the icon corners for Big Sur style

the app icon is ugly please round the corners

@angelolloqui I'm currently learning design in my spare time. I can update app icon if you want.

@angelolloqui I'm currently learning design in my spare time. I can update app icon if you want.

Please do it and do a pull request


Modify Test_edit_complete_very_long_name

It enables Test_edit_complete_very_long_name on win, mac, and (maybe) other environments.

set path_max to environment-specific value and make longfilename based on it.

----
Ozaki Kiichi

Codecov Report

Merging #1616 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1616      +/-   ##
==========================================
- Coverage   74.68%   74.68%   -0.01%
==========================================
  Files          76       76
  Lines      124849   124888      +39
==========================================
+ Hits        93241    93270      +29
- Misses      31608    31618      +10

Impacted Files
Coverage Δ

src/version.c
79.29% <0%> (-1.02%)
:arrow_down:

src/gui_beval.c
43.82% <0%> (-0.93%)
:arrow_down:

src/gui_gtk_x11.c
47.2% <0%> (-0.16%)
:arrow_down:

src/os_unix.c
58.33% <0%> (-0.15%)
:arrow_down:

src/channel.c
83.61% <0%> (-0.14%)
:arrow_down:

src/message.c
68.44% <0%> (-0.06%)
:arrow_down:

src/window.c
81.08% <0%> (+0.03%)
:arrow_up:

src/if_py_both.h
76.02% <0%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6ec18...b472e5b. Read the comment docs.

ichizok wrote:

call assert_equal(2000, &columns)

if has('unix')
" On windows (Appveyor) '&columns' would be limited to up to 123.
call assert_equal(2000, &columns)
endif

This makes the whole test pointless, at least 1050 columns are required
to trigger the problem that was fixed.
--
hundred-and-one symptoms of being an internet addict:
271. You collect hilarious signatures from all 250 mailing lists you
are subscribed to.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

A discussion about PATH_MAX was already done at https://groups.google.com/forum/#!topic/vim_dev/nHMRy5P5K6M

Sorry, I hadn't read its discussion.
But I think it doesn't enable to make path whose length more than 1050 on some unix environments other than linux.
Actually, for example, on FreeBSD this test fails.
How does this look? Linux distributions should have getconf so can check PATH_MAX.
--- a/src/testdir/test_edit.vim
+++ b/src/testdir/test_edit.vim
@@ -1324,10 +1324,14 @@ func! Test_edit_rightleft()
 endfunc

 func Test_edit_complete_very_long_name()
-  if !has('unix') || has('mac')
+  if !has('unix')
     " Long directory names only work on Unix.
     return
   endif
+  let path_max = str2nr(system('getconf PATH_MAX /'))
+  if path_max < 1050
+    return
+  endif
   " Try to get the Vim window position before setting 'columns'.
   let winposx = getwinposx()
   let winposy = getwinposy()

There's also NAME_MAX for the individual path elements.  And the path passed to getconf should probably be ., since that might be a different filesystem than /.
But none of that matters as long as you're still creating the directory by repeating the NAME_MAX-length element a hard-coded four times.  That logic needs to change.


Capybara Returns Full Page Body, Not Page Text

Consider the following logic:
page = TestPage.new(browser)
puts page.text
Currently the calls to @platform.text with both Selenium and Watir return just the textual elements that are present on the page. When doing this with Capybara, this appears to return the full body of the page, including the markup.

The issue is that in platform_object.rb (for Capybara), I'm doing this:
@browser.body
What I need to be doing is something like this:
@browser.find("body").text
A quick test shows that this seems to work. I expect to implement this fix in the next release.

The above fix would have worked but due to a design choice, I'm no longer going to be supporting Capybara at this time.


How to download all available subtitles and two auto generated subtitles

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
--sub-lang "en.*,ja" works globally so its ignore native other  language subtitles
Is there any way to use --all-subs  and --write-auto-subs (en,ja) for two specific languages at the same time?
Thanks
Verbose log
No response

Not currently possible https://github.com/yt-dlp/yt-dlp/issues/2262


Updates to the transaction API, and a few tidy-ups

The fact that the partition ID is required on DatastoreTransaction.RunQuery is annoying;
we will investigate whether cross-partition transactions are common, and act accordingly.
The changes to DatastoreDb are actually just a reordering to be more consistent.

LGTM


Link needs updating: https://ethereum.github.io/ is deprecated (Desktop Wallet / Smart Contracts)

Describe the issue
Technically :p ...
... the link labelled, Solidity compiler, as found on the desktop wallet's, Smart Contracts / Create page is out of date.
The Solidity Remix IDE has moved from https://ethereum.github.io/ to https://remix.ethereum.org/
The current github version link shows a warning dialog, as attached.
Screenshots.

What version of HTMLCOIN are you using?
HTMLCOIN CORE version <IP_ADDRESS> (64-bit) RELEASE
Machine specs:

OS: Ubuntu Desktop 16.04

Link has been updated in the following commit.
https://github.com/HTMLCOIN/HTMLCOIN/commit/6ebd5feba25cc4bd7b1992840680a718a92b3088


Use swift-atomics from v1.0.0

Now swift-atomics has hit v1.0.0 we should use it

@swift-server-bot add to allowlist

welp, look like atomics now requires 5.3?


Should be added

Date range picker must be added in the filtering

onRowDoubeClick also

I see, but about Date range picker did you have plan to add this in your data grid?


Atom.Object.defineProperty.get is deprecated.

Generated by Atom's Deprecation Cop:

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
Object.activate (/Users/jackmaney/.atom/packages/less-than-slash/lib/less-than-slash.coffee:19:9)

Thanks, I plan to get to this this weekend!


Updated plugin update and install to handle plugin versioning

Signed-off-by: Mihael Rodek<EMAIL_ADDRESS>closes #10929
What this PR does / why we need it: Fixes the plugin update and plugin install commands using better version handling
e.g.
helm plugin install [options] <path|url>... now installs the latest version and not one fetched from cache
```helm plugin update plugin:version...`` now allows user to specify to which version should plugin be updated to
Special notes for your reviewer: Plugin now prioritizes latest version over the cached

+1


(feat) : added issue template

Fixes #17
This PR adds a issue template when ever an contributor raises an issue.
it consists of the following :

Bug
Feature
Documentation
Other (issues)

Summary by CodeRabbit

New Features

Introduced templates for reporting bugs, documentation issues, feature requests, and other miscellaneous issues to streamline the issue-reporting process.

thank you much needed


[Feature request] Add support for the new --clear-queue and --auto-start-queue linux startup flags

Idea
Handbrake 1.8.0 added support to auto start or clear linux queues on application start, which was a previously requested feature here.  Having support for these flags via environmental variables would be helpful, especially the --auto-start-queue flag in combination with the KEEP_APP_RUNNING variable

Thanks! I updated to the most recent :latest tag, created a new queue, restarted the container and it immediately started the queue on startup!  I then restarted the container in the middle of the encode and it restarted the encode correctly, so I think we're good!


add Index to comment for migrations and mirroring

See original merge request from Loïc Dachary @ forgefriends

Comments have an id (see Gitea[0], GitLab[1] or GitHub[2], etc.), and the
comment migration format must represent it during migrations so that
it can be used during mirroring or incremental migrations.
[0] https://try.gitea.io/api/swagger#/issue/issueGetComment
[1] https://docs.gitlab.com/ee/api/discussions.html#get-single-issue-discussion-item
[2] https://docs.github.com/en/rest/reference/issues#get-an-issue-comment

What's the definition of comment index?

What's the definition of comment index?

It is the unique identifier of the comment.

The CI failure is unrelated to this PR, could someone please restart it?
+ make lint-backend

golangci-lint run --timeout 10m

level=error msg="[linters context] typechecking error: pattern ./...: open /drone/src/node_modules/esbuild-android-arm64: no such file or directory"

make: *** [Makefile:782: golangci-lint] Error 7

It would be too complicated to add the comment identifier in the database. This pull request was simplified to only add the information in the migration files. It can later be used to set the information in the ForeignReference table when this pull request is merged.

The Index is per repository or per issue? Since there is no id or index from Github, what should be stored?

The Index is per repository or per issue?

It depends. The index for Gitea is absolute even though the API endpoint is relative to the repository. The API endpoint for GitHub is also relative to the repository but the documentation does not specify if the id field is relative to the repository or not. However, since the API endpoint is not relatve to the issue, I think the id is not per issue.

Since there is no id or index from Github, what should be stored?

There is an idfor comments from GitHub. And for GitLab too and every other forge supported by Gitea at the moment.
Maybe I misunderstood your question?

Codecov Report

Merging #18806 (f012992) into main (5184c83) will increase coverage by 0.02%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##             main   #18806      +/-   ##
==========================================
+ Coverage   46.58%   46.61%   +0.02%
==========================================
  Files         854      854
  Lines      122830   122844      +14
==========================================
+ Hits        57225    57264      +39
+ Misses      58687    58657      -30
- Partials     6918     6923       +5

Impacted Files
Coverage Δ

modules/migration/comment.go
100.00% <ø> (ø)

services/migrations/codebase.go
0.78% <0.00%> (-0.01%)
:arrow_down:

services/migrations/gitlab.go
5.21% <0.00%> (-0.03%)
:arrow_down:

services/migrations/gogs.go
2.02% <0.00%> (-0.02%)
:arrow_down:

services/migrations/onedev.go
0.82% <0.00%> (-0.01%)
:arrow_down:

services/migrations/github.go
66.30% <50.00%> (-0.06%)
:arrow_down:

services/migrations/gitea_downloader.go
67.11% <100.00%> (+0.06%)
:arrow_up:

modules/charset/charset.go
69.74% <0.00%> (-4.21%)
:arrow_down:

modules/queue/queue_channel.go
78.30% <0.00%> (-2.84%)
:arrow_down:

services/pull/pull.go
39.62% <0.00%> (-0.63%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5184c83...f012992. Read the comment docs.

In simple words this PR provide a value for the GetForeignIndex() for the comment structs?

make l-g-t-m work

make l-g-t-m work


GUVNOR-2415: Boundary events lose it’s documentation after save and r…

…eopen Business Process

@hasys thanks for this. may i just ask why all these changes are needed just for the 1 liner
be.getDocumentation().addAll(beEntry.getDocumentation());
?

Hi, @tsurdilo . We need two times
be.getDocumentation().addAll(beEntry.getDocumentation());
because for first time we have to copy documentation during IntermediateEvent->BoundaryEvent migration and the second time while it looking for BoundaryEvent container. Also there are another minor fix for EventDefinitions (it was checked is BoundaryEvent instance of EventDefinition, but it never true).
Another 7 lines just changed "\t"->"    " and diamond notice introduced (master branch is prepared for JDK8+ so we can do this.
All remaining lines is a try to merge Event copying in one method but it is not so easy because for first time it is CatchEvent->BoundaryEvent migration and for the second time it is BoundaryEvent->BoundaryEvent cloning. But I started migration with small step. After this and https://github.com/droolsjbpm/jbpm-designer/pull/157 will be merged I will continue this effort. But for now this minor refactoring at least will speed up unmarshalling for a little.

@hasys could you please rebase this on top of the current master and fix the merge conflicts (they arose after merging your other PR)?

@psiroky done.

@hasys thanks! I'll merge this once the build succeeds.


Skip adding extend lines to hidden.rbi

@jez suggested that we should update srb to skip adding those extend lines, such as with the Parlour gem,

extend ::T::Private::Abstract::Hooks
extend ::T::InterfaceWrapper::Helpers

to hidden.rbi" to solve sorbet/rbi/todo.rbi lines sugest as:

module T::InterfaceWrapper::Helpers; end
module T::Private::Abstract::Hooks; end
module T::Private::Methods::MethodHooks; end
module T::Private::Methods::SingletonMethodHooks; end

More background at canceled PR#116 and ISS#1488.

Still "unconfirmed" (can you reproduce my issue?) since August 26, 2019 so closing.


Mutations Sync: Refactor and filter on current user

Two small bits of cleanup in the LocalMutationSyncWorker:

Move fetching of mutations eligible for retry into the mutations repository
Only sync mutations associated with the current authenticated user.

Also adds a new test to validate (2.). Progress toward issue #2235.
@gino-m

Looks like there are detekt errors to correct.

@scolsen Gentle ping.. could you please resolve failing checks? @jcqli for visibility.

@gino-m FYI should be good to go, holding off on merging just to be sure we manage these correctly before cutting a release

@gino-m FYI — since this is pretty stale, I'm going to close it for now. We can reopen if needed!


Use a regular put for ntp settings changes

There is no need to modify the queue inline for these changes.
Yes, it will update this resource twice in a row on each server, but
not the end of the world

@jrafanie Please review.

@kbrock LGTM.  Can you remove this test if we're going to enqueue this message without checking for an existing one?
  1) MiqServer instance #ntp_reload_queue when on an appliance will not requeue if one exists
     Failure/Error: expect(MiqQueue.where(queue_cond).count).to eq(1)

       expected: 1
            got: 2

       (compared using ==)
     # ./spec/models/miq_server_spec.rb:140:in `block (5 levels) in <top (required)>'

Also, can you rebase, it looks like it failed on quadicon changes that I believe Martin fixed already?  Maybe check with him before we lose the error.  Thanks!

@kbrock next time, please ping when it's ready.  thanks!


See what happens if we ignore libprotobuf's runtime exports

Exploring alternatives to https://github.com/conda-forge/dask-sql-feedstock/pull/74
cc @bdice @jakirkham

Codecov Report

Merging #1242 (39f7deb) into main (1552348) will decrease coverage by 0.60%.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
- Coverage   81.58%   80.99%   -0.60%
==========================================
  Files          78       78
  Lines        4611     4609       -2
  Branches      854      847       -7
==========================================
- Hits         3762     3733      -29
- Misses        660      683      +23
- Partials      189      193       +4

see 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fMRIPrep settings

I'm working on the fMRIPrep processing job and I just wanted to check about the settings. Here are some initial thoughts:

--fs-no-reconall: I'm running fMRIPrep on ~800 participants, so processing with recon-all will add a lot of time. The analyses don't use surface space, so I don't think it's that important. EDIT: I actually included masks that are only available from fMRIPrep in my analysis plan, so I have to use Freesurfer :(
--output-spaces MNI152NLin6Asym:res-native anat:res-native func:res-native: I'll be analyzing the echo-wise files grabbed from the working directory, but I think these are the target spaces. Does anyone have a concern about analyzing everything in native resolution?
Any other settings worth adding/amending? A number of things (CompCor, FD outliers) will be calculated as part of the analyses, rather than taken from fMRIPrep, but there could be other options worth using. Here are the current version's arguments.

EDIT: Tagging @62442katieb @mriedel56 @emdupre @handwerkerd

I've started submitting the jobs, so I'm closing now.


fix: fix no chart found errors when adding charts from a helm repository

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr
ed5faddb0bc3d59b91edf26110e0a97377eaeaac
link
/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rawlingsj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


issue: fails to parse this valid file

https://github.com/pjcj/Gedcom.pm/blob/master/royal.ged
Undefined array key 1 at vendor/mrkrstphr/php-gedcom/library/PhpGedcom/Parser/Head.php:45

Have you tried with our fork


Update pre-commit hooks

To align with the other scverse packages/code style, we need to update the code style and pre-commit hooks. This is partially related to #979.

closed via #1046


storage.buckets.setIamPolicy has no preconditions implemented in .NET and hence will retry successfully

Please follow this comment thread for more details.
Should we fix this in production code? Maybe create an issue so that we don't forget?
Originally posted by @amanda-tarafa in https://github.com/googleapis/google-cloud-dotnet/pull/9361#discussion_r1031654079

Should this be triaged as a FR (to add precondition support to this method) or as a bug (to fix something that's currently broken)?

@tritone: I think it's fine to be triaged as a FR.


fix(nx-plugin): added missing import for 'join' in tailwind template

PR Checklist

Closes #1404
What is the new behavior?
Styles work out of the box when tailwind is configured on project generated using nx-plugin.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
[optional] What gif best describes this PR or how it makes you feel?

Thanks! @allcontributors add @Rockerturner for code


How can I tell pylance that this short circuit expression is ok?

    merged: Dict[float, bool] = {}
    # merged is filled with stuff

    final = []
    lf = False
    last = None
    for k, v in merged.items():
        if v == lf:
            # note: the 1st time this block is executed, v must be False
            # because lf is initialized to False and hasn't had any chance to change
            lf = not lf
            # so at this point, either v is False, or last is float
            if (v == True) and (k - last >= 7):
                final.append((last, k))
            last = k  # last is changed from None to float, and has no chance to go back to None

pylance thinks I'm trying to subtract None from float, but I'm not because short circuit prevents evaluation of that.
How can I tell pylance that this short circuit expression is ok?

A type checker doesn't reason about relationships between different symbols (e.g. k must be of type int since v evaluated to True).
The easiest way I see to address this particular case is to initialize last with the value 0 rather than None. That way, its type will be inferred as int rather than int | None.

That doesn't work if I was planning to use the None value later to find out whether any v was False.
But I can figure something out if I need to. That's not my concern here.
My question was about how to tell pylance that the expression is ok.
I guess you could consider this as a feature request for something like TypeScript's @ts-ignore.

There is, you could use # type: ignore, but that wouldn't change the way that the analyzer looks at this code in terms of the code flow (and not being able to prove this specific condition).
You could also do:
from typing import cast

if (v == True) and (k - cast(float, last) >= 7): ...

@beauxq Did the above suggestion work for you?

This issue has been opened for > 30 days with a waiting for information label so I'm going to close this. If this is still an issue, feel free to ping us and we can reopen.