memory issues

I am trying to assemble a PacBio dataset containing 52Gb of data (my genome is 620Mb). ABruijn has been stuck for two days at 0% below:
(myenv) stelo@H4:~/ABruijn$ ./abruijn.py -t 40 reads.fa out_dir 70
[09:10:42] INFO: Running ABruijn
[09:10:42] INFO: Assembling reads
[09:34:00] INFO: Counting kmers (1/2):
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[12:41:12] INFO: Counting kmers (2/2):
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[15:02:27] WARNING: Unable to choose minimum kmer count cutoff. Check if the coverage parameter is correct. Running with the default parameter t = 2
[15:02:27] INFO: Building kmer index
0%

It is currently using 483GB (resident) of the 512GB RAM I have on my server, but also quite a bit of swap (virtual 719GB). I think ABruijn is not making much progress because of a lot of swapping. Is there any way I can reduce the amount of RAM needed? Maybe changing params? Or perhaps I can filter out reads that ABruijn would not use (i.e., shorter than a threshold)? Thanks.

Hello,
We haven't tested ABruijn on that large genomes yet (but it is definitely a direction we want to  improve).
There is a warning that basically means that ABruijn could not find enough solid kmers to represent the genome - and the default threshold t = 2 is too low, which slowing everything down.
Currently I might think about two reasons for that: first, it might be that some fraction of input reads does not come from genome, but rather a contamination, symbiotic bacteria, etc. If the fraction of such reads is high, it might confuse the selection of solid kmers. Do you think it might be the case?
Secondly, your genome is 620Mb, so it already contain a significant part of all possible 15-mers (1Gb), which also might trigger some effects that we did not observe previously.
So, I would consider to try the following: (i) increase kmer size to 17 (-k parameter), (ii) Filter out short reads (say, shorter than 14k) (iii) check if there is a contamination in the sample.
Also, check if you are using the latest version from master (we have pushed an update about a week ago).

Thanks for the quick answer. The organism is a legume. Now I filtered my reads at 14K and I've got about 27Gb of data. I am re-running ABruijn with -k 17. Regarding the contamination, I cannot be 100% we are contaminant free, but I removed mito DNA and chloroplast DNA. I will post here progress.

I have been able to run ABruijn on my dataset on CANU corrected pacbio data (16Gb) until this point
[09:01:17] INFO: Running ABruijn
[09:01:17] INFO: Assembling reads
[09:06:41] INFO: Counting kmers (1/2):
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[09:27:43] INFO: Counting kmers (2/2):
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[09:36:44] INFO: Building kmer index
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[09:59:39] INFO: Finding overlaps:
0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
[17:07:59] INFO: Extending reads
[17:17:17] INFO: Assembled 741 contigs
[17:17:17] INFO: Generating contig sequences
[17:33:37] INFO: Polishing genome (1/2)
[17:33:47] INFO: Running BLASR

It has been running BLASR now for two days on 32 cores - any idea how long it will take?
Can I instead polish the draft assembly with Quiver?

Hmm, this looks strange, how big the genome? Maybe it depend on BLASR version, but it usually finishes in a reasonable time event for human alignments.
You can roughly estimate the completion by checking the size of .m5 file in the output directory. At the end it should be roughly 3x reads file size.
If the reads are already corrected, you can definitely try to apply Quiver right away - the draft assembly is in "draft_assembly.fasta" file. I am not sure how it performs on non-corrected reads though.

The genome expected size is 620Mb. Here is what I have in the out directory
-rw-rw-r--  1 stelo stelo  203785934 Aug 27 17:33 abruijn.log
-rw-rw-r--  1 stelo stelo         62 Aug 27 17:33 abruijn.save
-rw-rw-r--  1 stelo stelo<PHONE_NUMBER> Aug 29 11:35 blasr_1.m5
-rw-rw-r--  1 stelo stelo  480953800 Aug 27 17:33 blasr_ref_1.fasta
-rw-rw-r--  1 stelo stelo  480750468 Aug 27 17:33 draft_assembly.fasta
-rw-rw-r--  1 stelo stelo  486778112 Aug 27 17:32 reads_order.fasta

It seems that that blasr_1.m5 is about 10x the size of draft_assembly.fasta. I have the lastest version of BLASR from github

Hm, it seems that BLASR alignment goes really slow. I'll try to check if there is a significant difference in running time between BLASR versions on the datasets we have.

A bit late follow-up..
It seems that there is no significant difference between different BLASR versions for the datasets we currently have. But there is at least 2x slowdown when running on error-corrected reads comparing to raw reads (ABruijn does not require prior error correction).
We also checked different BLASR parameters and found a combination which gives about 1.5-2x speedup without affecting the result quality. The new version is in master branch, the speed gain could be even bigger for your dataset, since it contains more complicated repeat structures.
Hope this helps. Let us know, if you have any other questions.

Mikhail: many thanks for the follow-up. I know that ABruijn does not require prior error correction, but I was unable to run it on my whole dataset (see my very first post). Running it on CANU corrected data seems a way to remove some of the low-quality data in the dataset without compromising the ability of assembling the genome. I will definitely try again ABruijn (and compare with CANU, FALCON, and HINGE). We are still struggling to get contaminants out of the reads.


Text field as password field?

My apologies in advance if I'm heading down the incorrect path with this question. Does the current Text Field web component not allow for type to be password?
I'm creating a login form and would prefer to have the password field be type password.

Please see example

@moog16 Thank you for your quick response. Should the docs be updated to include the type prop on the input? Or is it just assumed?
Thanks.

I think it is assumed, but if it was not clear to you then it may not be clear to others. Please feel free to open a PR :)


vehicle is listed as a restriction item in foot routing

In com.graphhopper.routing.util.FootFlagEncoder.FootFlagEncoder(int, double), vehicle is listed as a restriction. This is wrong. On foot means not using a vehicle.

Do you have an example where this is a problem?

On Sunday 20 November 2016 04:40:43 Peter wrote:

Do you have an example where this is a problem?

sorry, it seems this is a duplicate of #752 and I forgot to upgrade my server.
Sent from KMail

Thanks, no problem


Add else if Conditional Statements to the DirectX backend

To add else if support to CrossGL, modify the following files in the crosstl/src/backend/DirectX directory:

[ ] DirectxLexer.py : Add token recognition for else if.
[ ] DirectxParser.py : Update grammar and AST to handle else if.
[ ] DirectxCrossGLCodeGen.py : Implement else if for Crossgl output.

 Feel free to reach out on our Discord Server  if you have any query.

Hi @samthakur587 , I'd like to work on this issue.

Hi @samthakur587 Can I work on this issue?


Select non standard kernel

This PR is based on #351
It allows the user to start any kernel, regardless of the editor grammar. Therefor a select-non-standard-kernel command was added to the KernelPicker and SignalListView.

Hi,
This is really interesting. Can I use any kernel ?
Can you please elaborate how to use with a kernel ?
I am really using it with django. It will be wonderful, if I can use it with the django-extension's notebook option. If you can, please tell me about using it with http://django-extensions.readthedocs.io/en/latest/shell_plus.html
I am really interested in this PR. Thanks for the PR.

Please, Never mind about My shell_plus request. It is working fine with running a notebook with port 8888.

@lgeiger  I'm not done with the review yet.
The description of commit 	6ddc1f1 should say languageMappings.

@n-riesco Thanks for taking a look at the PR. I didn't mean to include 6ddc1f1. There went something wrong with the rebase. I think we should keep the languageMapping setting.

@ajeebkp23 Hydrogen works in principle with every jupyter kernel. Hydrogen detects your installed kernels automatically if you have jupyter or a recent version of ipython installed. If not have al look at the Kernel Spec setting.
Hydrogen uses atoms grammar to determine which kernel to start. Some languages like scala use different kernel names. Therefor we provide the Language Mappings setting. This PR just allows you to start any kernel without editing the Language Mappings setting.

Just some thoughts on my own PR:
In my workflow I don't really have the need to start a non standard kernel. Thus I'm fine if this doesn't get merged. At this point I'm not sure if we should have this feature or if it just clutters the menu.


Specify license on gemspec

Hey there,
We're using an automated tool called License Finder (https://github.com/pivotal/LicenseFinder) and your gem comes up as "Unknown". By adding the license to the gemspec file you would help immensely users of this and other automated tools to figure out whether a gem can be used inside another project.
Thanks!

ping @foxycoder

Thanks, I'll roll an update with this!


[MINOR][DNM] Full test runtime 2

Change Logs
As above.  This reverts #9260 to fix CI.
Impact
Testing only.
Risk level (write none, low medium or high below)
none
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

This is for testing only and is no longer needed.


Implement user OAuth with gmail [Login & Register]

Is your feature request related to a problem? Please describe.
Provide user with easier means of authentication using social auth.
Describe how to intend to go about adding this feature
Use passport module or its equivalent
Additional context
None

Kindly assign to @HopeKodi
Thank you.

is this taken?

Yes am on it


Add fix for handling Jest fake timers

Fixes #4
@lgandecki I'll leave the test to you. Lemme know if you need anything else

Thanks! released as 0.5.0


Require explanation regarding eval-only mode

I am not able to understand why same thing is happening twice in this part of code? https://github.com/IDEA-Research/MaskDINO/blob/main/train_net.py#L348-L354

Oh, it is a typo. Thanks for this comment, and you only need to load once.

@FengLi-ust Thanks. please update the script accordingly.


fix: set timeout for append_flush

https://www.erlang.org/doc/man/gen_server.html#call-3

We are NOT going to merge this for now, just an attempt to avoid the timeout error by do_append_sync


Pin coverage version for Python 3.8

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
1172

Relevant Lines:
1172

💛  - Coveralls


remove duplicate keywords

before adding the keywords to the sidecar or the image, sort and remove possible duplicate keywords. Duplicate keywords might have originated from pre-existing keywords in the original, --album-keyword and --person-keyword.
(issue is minor)

Good catch -- thanks.  Easy fix.
something like keyword_list = list(set(keyword_list)) after this line should do the trick:
https://github.com/RhetTbull/osxphotos/blob/3c14ace8264abd6dbada326bf4ec4caff948b1da/osxphotos/photoinfo/_photoinfo_export.py#L1266

While you are at it, it could also be a good idea to move the sort from
https://github.com/RhetTbull/osxphotos/blob/3c14ace8264abd6dbada326bf4ec4caff948b1da/osxphotos/photoinfo/_photoinfo_export.py#L1231
to the new line (or remove it altogether)

Yes, the sorted there is completely unnecessary as person_list is already sorted earlier in the code.  But if I eliminate duplicates (using set()) there's no preservation of order so I don't need any of the sorts that occur in this method.


Unterscore in DNS entries

Is your feature request related to a problem? Please describe.
Hi Togehter!
I know it is litte issue, nevertheless it would help me quite a lot if we can enable "_" (underscore) for DNS Entries, as far as I know it is already allowed by RFC for some usecases (https://datatracker.ietf.org/doc/html/rfc2782)
Describe the solution you'd like
That I can add underscores in DNS Entries
Describe alternatives you've considered
maybe also with an "" before it.
Additional context
Thanks :)

You can do this right now.
Out of the box, NetBox DNS supports underscores where the underlying RFCs allow them, for example in SRV and TXT records.
If you need to, you can also enable them whereever a dash is supported by using the allow_underscores_in_hostnames setting in the PLUGINS_CONFIGdictionary inconfiguration.py`.
See also the Validation Options section in the documentation) for more information.

Did my answer solve your problem or is there anything else I can do for you?

Hi!I haven‘t tried it for now, nevertheless i think it will solve my problem. Thanks a lot Mario Sent from my iPhoneOn 04.07.2023, at 9:39 AM, Peter Eckel @.***> wrote:
Did my answer solve your problem or is there anything else I can do for you?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

This didn't appear to have the desired affect.
Adding the below config into configuration.py
PLUGINS_CONFIG = {
     'netbox_dns': {
         'allow_underscores_in_hostnames': 'True'
     }
 }

And restarting netdot
systemctl daemon-reload
systemctl restart netbox netbox-rq

Resulted in the same error in trying to create a hostname with an "_" in the name.


Re-generate dangling_indices namespace

Description
Re-generate the dangling_indices namespace from the OpenAPI specs.
Using this a relatively small surface area to validate generation from the OpenAPI specs.
Will be done in a piece-meal fashion to re-generate all operations, and also generate new/missing operations.
Issues Resolved
Part of #193
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

All CI failed

All CI failed

Rebase conflicts caused me to inadvertently re-add the old deleted file


Track crates.io version of noodles

As @CastilloDel and I spoke about, we should have a more stable version of noodles than the master branch, so that our code doesn't break as often.

This makes a ton o sense, thanks Marko.
On a side note, you and @CastilloDel Noodles' bug hunting so far has been stellar, but I totally get that it can get annoying if it gets on the way of developing the specific feature(s) you might be working on ;)


Fixed Error message for Version Mismatch in Config

Describe changes
I got the following error message while working locally:
RuntimeError: ('The ZenML global configuration version (%s) is higher than the version of ZenML currently being used (%s). Please update ZenML to at least match the global configuration version to avoid loss of information.',
VersionInfo(major=0, minor=7, patch=3, prerelease=None, build=None), VersionInfo(major=0, minor=7, patch=2, prerelease=None, build=None))

I replaced the %s with .format formatting and tested in a separate python process:
from semver import VersionInfo  # type: ignore[import]

config_version = VersionInfo.parse('0.9.0')
curr_version = VersionInfo.parse('0.9.1')
raise RuntimeError("The ZenML global configuration version {} is
higher "
                    "than the version of ZenML currently being used {}. "
                    "Please update ZenML to at least match the global "
                    "configuration version to avoid loss of "
                    "information.".format(config_version, curr_version))

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table.
[ ] I have added tests to cover my changes.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Closing in favor of https://github.com/zenml-io/zenml/pull/561 :)


Ly disables display-manager-init on Gentoo

I don't know if this is intentional, but a disclaimer in the README would be appreciated.

It's happened to me as well, ly can't be started through display-manager-init on Gentoo. You have to disable it first, and then enable ly to start in the default runlevel (rc-update add ly).
I also think it'd be great to mention it in the README.

I didn't know that only some DMs could be used with display-manager-init, thanks for clarifying it. Display-manager not starting automatically should definitely be mentioned in the readme.


Trigger full page reload when hmr fails

Fixes https://github.com/mxstbr/react-boilerplate/issues/1353

Coverage remained the same at 98.592% when pulling 2ba6bb0ab7f3dc38917f9d9c574b634603fc43a6 on kachkaev:patch-1 into 0d34f5d11ac11b7cd7ae9a7e0fee4b94bbbd7be6 on mxstbr:dev.

Yep, LGTM, much improved UX ✨

Coverage remained the same at 98.592% when pulling 2202d701cd060b311debea60820fa874d3ac75ef on kachkaev:patch-1 into 2c7e5566ee54e981105ff40c7c137cc5db2b990c on mxstbr:dev.


chore(deps): update yarn to v4.3.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

yarn (source)
4.2.2 -> 4.3.0

Release Notes

yarnpkg/berry (yarn)
v4.3.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: yarn.lock
➤ YN0000: · Yarn 4.3.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0s 876ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ @types/react is listed by your project with version 19.0.0-rc.0 (p540a0), which doesn't satisfy what @apollo/client-react-streaming and other dependencies request (^18.0.0).
➤ YN0060: │ @types/react is listed by your project with version 19.0.0-rc.0 (p8736b), which doesn't satisfy what @apollo/client and other dependencies request (^18.0.0).
➤ YN0060: │ @types/react is listed by your project with version 19.0.0-rc.0 (p8f0dd), which doesn't satisfy what @apollo/client and other dependencies request (^18.0.0).
➤ YN0060: │ @types/react is listed by your project with version 19.0.0-rc.0 (peddff), which doesn't satisfy what @apollo/client and other dependencies request (^18.0.0).
➤ YN0060: │ @types/react is listed by your project with version 19.0.0-rc.0 (pfc89c), which doesn't satisfy what @apollo/client and other dependencies request (^18.0.0).
➤ YN0060: │ next is listed by your project with version 15.0.0-rc.0 (p27d9f), which doesn't satisfy what @apollo/experimental-nextjs-app-support and other dependencies request (^13.4.1 || ^14.0.0).
➤ YN0060: │ react is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (p0fe94), which doesn't satisfy what @apollo/client-react-streaming and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (p404c8), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (pb2cb7), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (pcfd8a), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (pd410a), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (p21a4c), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (p303a1), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.0.0-rc-935180c7e0-20240524 (pb5453), which doesn't satisfy what @apollo/client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [a7905] doesn't provide react-dom (pfe7e9), requested by @testing-library/react and other dependencies.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [a7905] doesn't provide webpack (p1d09f), requested by react-server-dom-webpack.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [ff90e] doesn't provide react-dom (p79f9e), requested by @testing-library/react and other dependencies.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [ff90e] doesn't provide webpack (pb94ec), requested by react-server-dom-webpack.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming doesn't provide react-dom (pb3e0d), requested by @apollo/client and other dependencies.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming doesn't provide webpack (p5ca41), requested by react-server-dom-webpack.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support [57d1f] doesn't provide react-dom (p50fa0), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support doesn't provide react-dom (p12d27), requested by @apollo/client and other dependencies.
➤ YN0002: │ monorepo@workspace:. doesn't provide webpack (p5bc50), requested by @size-limit/webpack-why.
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 770ms
➤ YN0000: ┌ Link step


Coordinate conversion fixed

Address #348

Can you get the tests pass?

Can you get the tests pass?

@shreyasbapat tests pass on my system, after the second change.

Give it a rebase once?

YESSS! This is sympy issue! Rebase and the tests will pass!

These issues are fixed in https://github.com/einsteinpy/einsteinpy/commit/e0c7385f72ec22dda3a91c5a92b9333300ec964a

Done :smiley:

A little bad rebase :/

No changes here?

No changes here?

Meaning ?

@shreyasbapat seems good enough!
BTW, that was quite a creative fix @Manvi07

Thanks @ritzvik for the kind words :p
https://github.com/einsteinpy/einsteinpy/issues/348#issuecomment-565123914

And this goes into the codebase :D


modify the python filename extraction

Why are these changes needed?
modify from
code[11 : code.find("\n")].strip()
to
code[11 : code.find(".py")].strip() + '.py'
otherwise, invalid python file name would cause issue in committing current docker
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Please use https://microsoft.github.io/FLAML/docs/Contribute#pre-commit to pass code format check.


"Bâsca Rozilei", "Chirlești" and "Curmătura" are listed in the drop-down menu

Description:
"Bâsca Rozilei", "Chirlești" and "Curmătura" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Bâsca Rozilei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Bâsca Rozilei, Buzău(Nehoiu)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Chirlești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Chirlești, Buzău(Nehoiu)".

Step 5
Type "Curmătura" in the search bar.

Expected results
The location is listed in the drop-down menu as "Curmătura, Buzău(Nehoiu)".


Problem with loading data scenes with sub-resources referencing other sub-resources

Godot version:
Godot 3.1 RC1
OS/device including version:
Mac OSX Mojave
Issue description:
When I have a scene containing a sub-resource and that sub-resource references other sub-resources, the scene data gets saved but gives problem while loading. This is the saved scene:
[gd_scene load_steps=9 format=2]

[ext_resource path="res://Behaviors.gd" type="Script" id=1]
[ext_resource path="res://stats.gd" type="Script" id=2]
[ext_resource path="res://breath.gd" type="Script" id=3]
[ext_resource path="res://resources/behavior.gd" type="Script" id=4]
[ext_resource path="res://resources/resource_collections/resource_set.gd" type="Script" id=5]

[sub_resource type="Resource" id=2]
script = ExtResource( 2 )

[sub_resource type="Resource" id=3]
script = ExtResource( 3 )

[sub_resource type="Resource" id=1]
resource_name = "[ Set ]"
script = ExtResource( 5 )
_data = {
"Breath": SubResource( 3 ),
"Stats": SubResource( 2 )
}
base_type = ExtResource( 4 )

[node name="Behaviors" type="Node"]
script = ExtResource( 1 )
_elements = SubResource( 1 )

you can see that this is saved but when I try to load it... this is the export using _get_property_list() and setter/getter _set and _get:
func _get_property_list():
         return [ { "name": "data", "type": TYPE_DICTIONARY, "usage": PROPERTY_USAGE_DEFAULT } ]

func _get(p_property: String):
	print("get: " + p_property)
	if p_property == "data":
		return _data
	return null

func _set(p_property: String, p_value) -> bool:
	print("set: " + p_property)
	if p_property == "data":
		print(p_value)
		_data = p_value
		return true
        return false

this way I'm able to see when I open the file... when I load the file posted above I get this output to the terminal:
set: data
{Breath:[Resource:205365], Stats:[Resource:205364]}
set: base_type
get: base_type

so the data is being initialized correctly and the dictionary values are there...
but when I select the node in the inspector, the dictionary is empty!!
I tried to recreate the same thing using a Dictionary<String, int> and it seems to work fine,
so it must a problem with the use of sub-resources!

@akien-mga I was able to replicate my problem in a small project and it worked... so it's not a bug but a problem with my implementation... this issue can be closed :) sorry for the trouble!


add_resource does not preserve api function docstring

I'm trying to auto generate API help using this piece of code:
@app.route('/api/help', methods=['GET'])
def api_help():
    """Returns all registered APIs available in this application."""
    func_list = {}
    for rule in app.url_map.iter_rules():
        if rule.endpoint != 'static':
            func_list[rule.rule] = app.view_functions[rule.endpoint].__doc__
    return jsonify(func_list)

It relies on __doc__ of a function and works fine for APIs defined with a route decorator:
@app.route('/someapi'...
However, when a route is registered with add_resource the docstring is lost.
The help api returns data in this format:
{
  "/api/help": "Returns all registered APIs available in this application.",
  "someapi": null
}

tried on latest versions:

Name: Werkzeug
Version: 0.11.11
Name: Flask
Version: 0.11.1
python --version
Python 3.5.1 :: Anaconda 4.0.0 (64-bit)

add_resource is not a Flask method.

Oh yes, my bad. It's from Flask-RESTful extension:
http://flask-restful-cn.readthedocs.io/en/0.3.4/api.html

Sorry to keep the discussion going here, but have you found a solution to that problem with Flask-RESTful?

Just opened an issue here: https://github.com/flask-restful/flask-restful/issues/643. It was low priority for me so I forgot to open it right away.


Could you please share the pictures of the cloud you used?

Of course, the download address of these pictures will be updated to this repository in the near future.


Prevent htex logs from becoming huge when sending blobs as arguments.

Truncate long arguments in logs for htex, this was causing logs to explode in size and also become useless.

There's a non-deterministic problem with one of the components of parsl that we recently started test - that problem shows up in anything based on recent master.


Adds CLI version check to each command

Adds a version check to each CLI command. If version does not match latest npm release, a warning message is displayed to the end user. Delivers Issue #68
This PR is branched out of develop
Workflow / Process:

Runs after each CLI command has finished
If the version does not match the latest npm release, displays a warning to the end user

Current caveats:

If we start supporting backwards versions (e.g. a legacy version is re-published to npm) the message would appear for users on newer versions, since the legacy version is now the most recently published version
The warning message will appear during development and for bleeding edge users (e.g. users that installed development versions from GitHub, that are not yet published to npm)

@santanaluiz done 👌


Missing support for PMatrixProducts

Looking at the source, I was unable to find an implementation of the PMatrixProducts protocol for inner/outer products. The results of the default implementation for outer-product are incorrect:
(def vv (m/matrix :clatrix [1 2 3 4]))
=> #'user/vv
(m/outer-product vv vv)
=> (1.0 2.0 3.0 4.0 2.0 4.0 6.0 8.0 3.0 6.0 9.0 12.0 4.0 8.0 12.0 16.0)
(type (m/outer-product vv vv))
=> clatrix.core.Vector

while for :persistent-vector it works as expected (i.e. outer-product produces a matrix):
(def vv (m/matrix :persistent-vector [1 2 3 4]))
=> #'user/vv
(m/outer-product vv vv)
=> [[1 2 3 4] [2 4 6 8] [3 6 9 12] [4 8 12 16]]

I have added a candidate pull request at #70.


Remove the lint about non nullable binding instances

Fixes https://github.com/creativecreatorormaybenot/performance/issues/18
I used the fix recommended by the flutter team: https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0#your-code
I also run flutter pub get, tell me if you want me to remove those changes

I can not use _ambiguate if you want but it will be a breaking change. A project that didn't upgrade to flutter 3 won't be able to use the new version of this package. Is that fine ?

@ValentinVignal It is not a breaking change since we expect everyone using the package to be on the stable channel of Flutter (this is also what the Pub analysis tool uses).

@creativecreatorormaybenot fair enough, I removed _ambiguate in https://github.com/creativecreatorormaybenot/performance/pull/19/commits/c57bbd97379bad6cfdc93c8a92a030e766c89a5b

@creativecreatorormaybenot That is fine, I can do it in this PR. I pushed the changes, tell me if something else needs to be changed.

@ValentinVignal Thank you so much for your contribution!

@creativecreatorormaybenot Is there something else I need to do for it to be merged and released?

@ValentinVignal your commits were not signed. But I removed this requirement now as I am going to squash anyway (in which case GitHub will sign the squash commit).


any plan to support more llms?

Is your feature request related to a problem? Please describe.
I uses other llm modes, like azuer chatgpt, not supported now. so any plan to support other llms>
Describe the solution you'd like
use litellm https://github.com/BerriAI/litellm to support multiple llm？
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @cuikexi, we definitely are interested in supporting more LLMs but they would need to have X, Y segmentation abilities. As more models come online that have this capability, we will be looking to incorporate them.

Hi @theredsix ,Thank you for considering the support for more LLMs. I'll keep an eye out for models that meet these criteria, looking forward to future enhancements!


error in Data_loader.py

It is from the arrows and HEAD, from line 118 to line 128, most probably coming from git push.


[consensus][easy] simplify proposal generator logic to match spec

why this is better?

it's closer to the spec
it's less lines of code
it makes the difference between a reconfig block and a normal block clearer

@bors-libra r=zekun000

:pushpin: Commit 66f9086 has been approved by zekun000

:hourglass: Testing commit 66f908678855157a99370aed8501c1cfba1c9b0a with merge 4ff8b13e64cbafdd350f517f58241d26b8840d4d...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: zekun000
Pushing 4ff8b13e64cbafdd350f517f58241d26b8840d4d to master...


remove internal macro and todo from readme

Description & motivation
This PR addresses two separate issues:

https://github.com/dbt-labs/dbt-audit-helper/issues/64
The compare_column_values_verbose part of https://github.com/dbt-labs/dbt-audit-helper/issues/61

Note that I explained the context of compare_column_values_verbose in this comment.
tl;dr is that I'm hoping we can keep it as an internal macro to make the code easier to understand; but regardless, it should be removed from the readme to reduce readme overwhelm. compare_column_values_verbose is an internal macro used by another macro in the package itself, and doesn't really need to be exposed to the user (and certainly not in the readme).
Checklist

[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable) (definitely applicable!)
[x] I have added tests & descriptions to my models (and macros if applicable)

@graciegoheen I'm not sure if I'm able to officially request a review, but I thought you might want to see this one and avoid any duplicate efforts 🙏


Blocking svgs produces a ton of errors in the console

Because we are now blocking svgs in the extensions viewlet we are producing a bunch of errors in the console
Could we fail more gracefully so it does not look like the world is going to end

I investigated this but there is no easy way to suppress these errors. They seem to be coming from the electron  webview  contents rather than anywhere electron specific.


open() bug

This PR introduced a bug that is making us unable to run the LAMP stack. When we try to initialize postgres we now get these errors:
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/2674
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation global/2694
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/2675
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 2 of relation base/1/2690
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 3 of relation base/1/2691
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation global/2695
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/2692
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/2693
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/2703
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/2704
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/2838
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 2 of relation base/1/2838_fsm
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/2839
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/3085
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/3164
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 1 of relation base/1/3455
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry
2024-08-15 00:25:40.654 EDT [21] CONTEXT:  writing block 0 of relation base/1/3456
2024-08-15 00:25:40.654 EDT [21] LOG:  out of file descriptors: Too many open files in system; release and retry

Can we add a test to make sure that file fd's are closed appropriately, and then try to track down this bug?

This is the commit that broke it: 546acc5b3f64f391b8d3e385c8bbdcddb4324cd3


Linux capabilities

I'd like to know if there's any existing work on providing a wrapper for linux capabilities? I was about to start work on a patch if there isn't.

Is https://docs.rs/caps/0.3.4/caps/ what you're looking for?

Yes, that's exactly it. Thanks.


Write then Lookup returns ErrNotFound

Am I doing something wrong?
package main
import(
  DB "github.com/gholt/store"
  //"context" <- no change with a non-nil context
  "fmt"
)
func main(){
  db, _ := DB.NewValueStore(nil) // no change with a non-nil *ValueStoreConfig
  db.Write(nil, 3, 932220, 0, nil) // no change with a non-nil []byte
  t, m, e := db.Lookup(nil, 3, 932220)
  fmt.Println(t, m, DB.IsNotFound(e)) // 0, 0, true
}

Hi, just back from a week of vacation...
There are a couple of things here:
The Write call was returning an error indicating that the timestamp given (0 in this case) was less than 256, so the write was never happening. There is a lot of documentation so it takes a while to absorb it all. :) Relevant section for why 256 is the minimum:

Internally, each modification is stored with a uint64 timestamp that is equivalent to (brimtime.TimeToUnixMicro(time.Now())<<8) with the lowest 8 bits used to indicate deletions and other bookkeeping items. This means that the allowable time range is 1970-01-01 00:00:00 +0000 UTC (+1 microsecond because all zeroes indicates a missing item) to 4253-05-31 22:20:37.927935 +0000 UTC. There are constants TIMESTAMPMICRO_MIN and TIMESTAMPMICRO_MAX available for bounding usage.

So, if we change that timestampmicro to 256, we'll then get a new issue, which is a divide by zero panic. Granted, this could be much improved to return a proper error about what is wrong, but this is all fairly raw code. :) The issue here is that the ValueStore was created but never started (by calling Startup).
So, the example should end up as:
package main

import (
    DB "github.com/gholt/store"
    //"context" <- no change with a non-nil context
    "fmt"
)

func main() {
    db, _ := DB.NewValueStore(nil) // no change with a non-nil *ValueStoreConfig
    e := db.Startup(nil)
    if e != nil {
        panic(e)
    }
    _, e = db.Write(nil, 3, 932220, 256, nil) // no change with a non-nil []byte
    if e != nil {
        panic(e)
    }
    t, m, e := db.Lookup(nil, 3, 932220)
    fmt.Println(t, m, DB.IsNotFound(e)) // 0, 0, true
}

And you'll get the output of:
256 0 false

Dang, I missed Startup in the docs. Thanks!


inconsistent use of active class #9657

Change '.active' to '.is-active' for menu component.

The issue number from git was #9657
Hope this is done correct. This is my first contribution. Looking for advice.
Thanks

Thanks for putting this together! Heads down testing 6.3.1-rc1 but will dig into this as soon as we ship.

Sorry it took me a while to get back to this. It's looking good... Can we update the visual tests for magellan with this as well? https://github.com/zurb/foundation-sites/blob/develop/test/visual/magellan/active-item.html and https://github.com/zurb/foundation-sites/blob/develop/test/visual/magellan/unordered-links.html still contain references to .active

@jmp1548 will you have time to do the update mentioned above? Would love to get this in for 6.4, targeted for middle of next month

@kball yeah, I will look into it this weekend. been traveling a bit. Thanks for the update

Just for references, we need to update this below pen once we get this to merge and release!

[ ] https://codepen.io/IamManchanda/pen/XRYrKp?editors=1000

All right! Going to merge this. Adding that this requires migration so we include a migration note.


fix: add "ɵ" prefix to definition properties

Closes #39
@NetanelBasal FYI
What I've done:

updated dependencies
renamed definition properties
updated peer dependency to support only this  >=9.0.0-next.10 version and higher

prolly need to update the package version to 7.0.0 as it's a breaking change I guess

Do you think it could be better to move the ɵdir to some constant like:
export const DIRECTIVE_DEFINITION = 'ɵdir';

Do you think it could be better to move the ɵdir to some constant like:

I don't believe they are going to change it again :)


Fix tutorials to work with Qiskit 1.0

Summary
Qiskit 1,0 removed the deprecated qiskit.tools which included some .jupyter from which the magics that did the version and copyright were imported. This PR adds a local file in the tutorials folder that contains just these magics and changes the import to use this.
Similar fix to qiskit-community/qiskit-algorithms#156
Details and comments

This is now failing due to it using Optimization which is failing dues to DiagonalEstimator for which a fix is in qiskit algorithms but as yet unreleased.

Qiskit Algorithms 0.3.0 was released so all passes - well its failing in testing the stable set of tutorials that are there against main here. Since this is intended to be backported to fix them too that will have to be ignored.


feat(storage): support reverse scan

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
support reverse scan for range cache expand.
Maybe in some batch query just like select a from table order by b desc limit 1, we can also use reverse-scan to optimize time complex
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

The reverse-scan performs much worse than normal scan


Crash on load in 1.8.9

Loading Ears alone does not result in any crashes, but with the other mods I have for 1.8.9, something results in a game crash. I will attempt to find which of my mods is causing it, as the crash report does not seem to mention anything but Ears,
[crash-2021-11-22_23.19.05-client.txt](https://github.com/unascribed/Ears/files/7585835/crash-2021-11-22_23.19.05-client.txt
fml-client-3.log
)

Some other mod you have installed has ASM patched the vanilla skin system in a way that Ears no longer recognizes it. My first suggestion for something to remove would be MorePlayerModels.

Wait, you have OptiFine, and MorePlayerModels doesn't show up in the coremod list at the top. Much more likely cause.
I cannot do anything for OptiFine compatibility as it is an invasive closed-source mod.

It was indeed Optifine


Markers of the toolbox are not shown as annotationg

Since using the new login (one-login), the markers overtaken from the existing markers are not shown on annotating on the side of the user. They are shown in the Auswertungs-Screen. This is not the case for new markers that have been created in the existing session; there you can see the annotations. (The pre-existing markers were created inside the new login, but in a different session)

@TaSpatzHfM we could not replicate this behavior. Please reopen if situation happens again and you have a concrete session in which we can have a closer look.


Get table counts when the DB is mounted

Rn, the fn in pages/api/v1/main/dtajax/index.ts repeats the total row count for the table each DataTables ajax call. It should be set once when the DB is first mounted (lib/api/attach-db)

I did something even better


Prevent array to string conversion

Fix for array to string conversion that throws an exception in PHP 8

Thank you @Blitheness. I have to add PHP 8 for unit testing first.

Thank you @Blitheness. Its tagged => https://github.com/nadar/quill-delta-parser/releases/tag/2.6.0


should staged-director-config remove the guids

We understand why om returns guids in the output of this command (OpsManager relies on guids for internal purposes in the API).
However, as a user of om who doesn't care about the internals of the OpsManager API, we feel like giving the guid when we use this command needlessly complicates our payload. For example, when using staged-director-config for vsphere, we get back the following:
    az-configuration:
    - guid: caf56be890aab8471cfc
      name: us-central1-a
    - guid: 294ed5d30add4ba0bb1d
      name: us-central1-b
    - guid: 264c554f584074e4b40e
      name: us-central1-c

As a user of OpsManager, I want to operate in the UI as little as possible while mimicking the behavior/view of the UI as much as possible. Therefore, what would mirror this experience the closest would be to return:
    az-configuration:
    - name: us-central1-a
    - name: us-central1-b
    - name: us-central1-c

Which is just as informative, but with less clutter.
We are willing to create a PR to create this behavior, but are willing to discuss further if there is a higher need to include the guids in the response.
As an additional thought: configure-director will already handle a PUT to OpsManager without the user having to include the guids in the payload. Implementing similar behavior for staged-director-config will help unify the experience.

@kcboyle,
We don't think there is any need to get the guid with staged-director-config. It seems that the use case here is just to pass in in to configure-director which does not require the guild.
Please go ahead and make a pull request.
cc: @heycait

Merged in https://github.com/pivotal-cf/om/commit/3dd94a63dadeccad1294665405f037d6f51c0919


useSchemaOrg(undefined)

Describe the bug
ERROR  [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading '_resolver')
  at tag:normalise (./node_modules/@unhead/schema-org/dist/shared/schema-org.2da2cd3d.mjs:2089:51)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async Object.resolveTags (./node_modules/unhead/dist/index.mjs:314:13)
  at async renderSSRHead (./node_modules/@unhead/ssr/dist/index.mjs:77:23)
  at <anonymous> (./node_modules/nuxt/dist/core/runtime/nitro/renderer.js:288:70)
  at Object.handler (./node_modules/nitropack/dist/runtime/renderer.mjs:21:22)
  at async ./node_modules/h3/dist/index.mjs:1975:19
  at async Object.callAsync (./node_modules/unctx/dist/index.mjs:72:16)
  at async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:2266:7)

Reproduction
https://stackblitz.com/edit/nuxt-starter-tm45cr?file=app.vue
System / Nuxt Info
No response

You must provide a value if you're using useSchemaOrg.

this aligns to the typescript definitions.

No.

Vue: Argument of type undefined is not assignable to parameter of type UseSchemaOrgInput

I cannot replicate the ts not working :thinking:


Regression introduced by switch to native promises

As part of https://github.com/CesiumGS/cesium/pull/10149, when was removed in favor of native promises. In some places, this now introduces a race condition. One place where this is obvious is Cesium3DTileStyle:
https://github.com/CesiumGS/cesium/blob/d2495353101d99965e5e042aa88db2e2daf79c52/Source/Scene/Cesium3DTileStyle.js#L85-L97
In the else branch (line 90) we use Promise.resolve to create a fulfilled promise. when and native promises do not behave the same in this situation. when.resolve creates a fulfilled promise, calling then on this value will actually behave synchronously. See the when.js source code for version 1.7.1 which was the last used version. Native promises will always run .then asynchronously.
This introduces a small gap where the then is waiting to be run. For previous code that assumed this constructor was sync, this introduces a window where the style is defined but not ready. The sandcastle below illustrates this by forcing the style to be set right before a scene.pick call.
It may make sense to break out the async behavior from the constructor and move it to a fromString static method so that the caller can decide which path they want to take.
While this is the only example I have come across, I imagine anywhere that when.resolve was replaced with Promise.resolve is a potential candidate for this bug.

Sandcastle example: Mouse over viewer and error will be logged
Browser: Chromium 101.0.4951.54 Arch Linux
Operating System: Linux cesium 5.17.5-arch1-1 x86_64 GNU/Linux

I ran into this exact problem when helping my old team upgrade Cesium, and implemented a fix:
https://github.com/TerriaJS/cesium/commit/1fd27c5d7c9e542abf83bf9e9fd900b9468d9b69#diff-1517c5b6881be5d0d9d1e7537153137ca8ea476adf92ec450ec165bfac53718b
I suspect a solution like this could be used more widely, and abstracted better. Checking if something is already a Promise by checking typeof foo.then === "function" is pretty legit too IMO.
Feel free to grab this and make it into a PR if it helps.

Example of checking for .then in that same commit:
https://github.com/TerriaJS/cesium/commit/1fd27c5d7c9e542abf83bf9e9fd900b9468d9b69#diff-0f3818eddd95010bfc4edeff10249d3f9e6e11f9aae308611d198a062a8fcd89R726

At least in this case,  I think we could get a lot of milage out of removing the string and Resource options from the constructor and having a fromUrl or similar static function which resolves the url before constructing the Cesium3DTileStyle. That would remove any need to have a readyPromise at all, let us treat a style as always synchronous, and would make a lot of our specs cleaner.


Proto

updated the photo-files. The Rating in Rating is now boxed, because ratings of 0 should be allowed.

don't merge, we have to wait for the ws for this one

We don't need boxing to allow 0 values. We just need it where we have to update another value to a value being 0.

well, it will fix #178

Removing the assertion here: https://github.com/coolcrowd/object-service/blob/proto/src/main/java/edu/kit/ipd/crowdcontrol/objectservice/database/operations/AnswerRatingOperations.java#L267 also fixes it without any BC impact.

ok, maybe i had not put enough thought in it ;)


'applicants' cannot be None, when 'other_applicants' is False

This is a bit of a weird bug. Not a huge deal, but not ideal. So when you remove all users from applicants and then set other_applicants to False, which is kind off intuitive, if you want to set other_applicants to False, you cause a bug. You cannot continue with the proposal by clicking save & continue. It won´t show an error message to indicate what is going on, because that is hidden. Normally, applicants will always contain at least the user, as that is provided as an initial value in ProposalCreate.get_initial(). If you try to navigate with the stepper, when this occurs, you also crash the form´s clean().

The actual bug here is the creator not being forcibly added to applicants. (Or, that happening only after validation).
The creator MUST AND SHALL always be listed in applicants. The portal will break in weird ways if that's not the case.
The form is, mostly, doing what it should to enforce that.
(Hell, I'd even say we should patch Proposal.save() to enforce this constraint, seeing how important it is).


Revisiting report and fitted_params for composite models

Currently fitted_params returns a named tuple (machines=..., fitted_params=...) for any composite model. If FP = fitted_params(model, fitresult) then FP.fitted_params[i] is the fitted params for FP.machines[i] for each i.
The report method for composites follows the same pattern.
This has been confusing to users in at least two cases, lately here. Perhaps it would be better to return (fitted_params_given_machine=d) where d is a dictionary of fitted parameters keyed on the machines. Or just return d.
Thoughts anyone?

@ablaom. I prefer the dictionary representation.

Okay, sounds like a plan. I will keep the machines key to save user doing machines = collect(keys(FP.fitted_params_given_machine)) to get the keys of the dictionary, which are otherwise not accessible.

I could also add fitted_params key, but think this will just lead to original confusion.

Here's the proposed doc-string for fitted_params:

fitted_params(mach)

Return the learned parameters for a machine mach that has been
fit!, for example the coefficients in a linear model.
This is a named tuple and human readable if possible.
If mach is a machine for a composite model, then the returned value
has keys machines and fitted_params_given_machine, whose
corresponding values are a vector of (nodal) machines appearing in the
underlying learning network, and a dictionary of reports keyed on
those machines.
using MLJ
X, y = @load_crabs;
pipe = @pipeline MyPipe(
    std = Standardizer(),
    clf = @load LinearBinaryClassifier pkg=GLM
)
mach = machine(MyPipe(), X, y) |> fit!
fp = fitted_params(mach)
2-element Array{Any,1}:
 NodalMachine{LinearBinaryClassifier{LogitLink}} @ 1…57
 NodalMachine{Standardizer} @ 7…33

machs = fp.machines
fp.fitted_params_given_machine[machs[1]]
(coef = [121.05433477939319, 1.5863921128182814,
         61.0770377473622, -233.42699281787324, 72.74253591435117],
 intercept = 10.384459260848505,)


bug: iOS app closes suddenly

Bug Report
Ionic version:

[x] 5.x
Current behavior:

the happens only with iOS and works fine with Android. When launching the app after launch I try to show an array of objects (in this instance an array of messages) the App locks up when trying to show or render any array. An array of users, it freezes and closes completely, an array of messages (that only contain one object) freezes and closes.
edit it happens after the app has been open for more than 5 seconds... I have tried to log the issue but there is a silent crash nd provides me no more information
Expected behavior:

for it not to close or at least throw an error
Steps to reproduce:

try and render an array of objects
Related code:
I can't really show as this issue is ONLY with iOS

insert short code snippets here

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 6.4.0 (/Users/christianfrancia/.config/yarn/global/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.7
   @angular-devkit/build-angular : 0.801.2
   @angular-devkit/schematics    : 8.3.26
   @angular/cli                  : 8.3.26
   @ionic/angular-toolkit        : 2.2.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.1.0, ios 5.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 17 other plugins)

Utility:

   cordova-res (update available: 0.11.0) : 0.9.0
   native-run                             : 0.3.0

System:

   Android SDK Tools : 26.1.1 (/Users/christianfrancia/Library/Android/sdk)
   ios-deploy        : 1.10.0
   ios-sim           : 8.0.2
   NodeJS            : v13.11.0 (/usr/local/Cellar/node/13.11.0/bin/node)
   npm               : 6.13.7
   OS                : macOS Mojave
   Xcode             : Xcode 11.3.1 Build version 11C504

Thanks for the issue. Can you provide a repo with the code required to reproduce this issue?

so there isn't anything that appears to be ionic's fault? The issue was solved after deleting the app and re-installing... Which shouldn't be the solution in real life. I tried getting the crash logs bug nothing was generated. I just don't see why when people are asking me why the app is crashing I need to steel them to delete the app and re install it.

Without seeing your application and without knowing if this is caused by Ionic Framework or not, it is hard to say for certain. I am going to close this as the issue sounds more application-specific, but if you find something that suggests this is a bug in Ionic Framework please feel free to open a new issue. Thanks!


Empty v-html in dynamic component

Vue version
3.2.47
Link to minimal reproduction
https://stackblitz.com/edit/github-bd1lay?file=src/pages/Home.vue
Steps to reproduce

Create an dynamic Component with an tag and a v-html content as props of the component
Try to fill the component

What is expected?
v-html in filled on site load
What is actually happening?
v-html is on first site load empty (not undefined) and will be hydrated and filled only after a change. This behaviour is also contained in a static export (via Nuxt) and not only in dev mode.
System Info
System:
    OS: macOS 12.3.1
    CPU: (8) arm64 Apple M1
    Memory: 247.64 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Firefox: 109.0.1
    Safari: 15.4

Any additional comments?
Interesting: As soon as I replace the tag prop with a fixed string, everything works as it should. Can it be related to Vue SSR?
In the normal SFC Playground ists working:
https://sfc.vuejs.org/#eNp9ksFugzAMhl/FyqWbVODO0k57gx16zIWBKanAiRKXTqp49znAJrpJQwglv60P+7fv6s37fLyiKpWOdbCeISJf/dGQYTt4FxjuELCFCdrgBthJ8s4QwBo8YWSRlqBRebEKCWrUiyFdLNxEJM04+L5ilBtAtjzpqL85XJ0PRjV2NAoYP1ku2h9PnY0gryPoXdUAOamzczehS6kKikeeLn7+o/ZqqTQbKp9foiNp9Z6yzRqIRpUwK0mbyy7l0DH7WBZFbOvUyyXmLpyL1Fm4kliDOcYh+wjuFjEI2Kj9hlGIOGLIAlKDAcN/zF+pf7gJOxmapJWNuWliD27q2kk/hMRQ2ii+iZVizZh1PPTpKm6uVm38maeynTz0FaURJF8kaokxtFWN8B6cj4tRQn4tIXKwdJYRiyDsrSLlGqodxbQ9kg0H2MlMd/s5U3bpAA22lnCG6vl7fHp+XBc1fQHhGuYu

I see thats a duplicate of 6435
@edison1105 A ETA for this would be nice. Annoying bug :/


AttributeError: module 'numpy' has no attribute 'float'.

This small example retrurns an error
import numpy as np
import matplotlib.pyplot as plt
from mpl_toolkits.basemap import Basemap

fig = plt.figure(figsize=(8, 6), edgecolor="w")
m = Basemap(projection="moll", resolution=None, lat_0=0, lon_0=0)
m.drawmapboundary()
m.shadedrelief(scale=0.2)

The error message:
AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

I belive, the wrong attribute is used in packages/basemap/src/mpl_toolkits/basemap/__init__.py, master branch, line 4186.
This small patch works for me:
4186c4186
<                     x1 = np.array(ny*[0.5*(self.xmax + self.xmin)],np.float)
---
>                     x1 = np.array(ny*[0.5*(self.xmax + self.xmin)],np.float32)

Thanks for the great package!

Thanks for pointing the bug! Just out of curiosity, which numpy version are you using?

I'm using the following versions:

matplotlib                3.7.3
numpy                     1.25.2
basemap                   1.3.8

@quickbrett thanks for raising this issue and proposing the fix and @molinav thanks for maintaining this still great package. I actually got the same error, I think it is related to the latest numpy versions.

It seems that numpy.float was removed with its release 1.24.0 (https://numpy.org/devdocs/release/1.24.0-notes.html). I will replace it with the Python builtin float as suggested in the link.
Hopefully I can get some time soon to start a basic unit test collection, because these issues would be identified immediately with the automatic tests.

@quickbrett I just added the patch in a hotfix branch (1.3.9), your small example now works after the correction. I took this moment to correct all the references to numpy.float that I found in the whole library, mostly replaced with numpy.float64.
I am not sure when I will release 1.3.9, maybe I will do a couple of bugfixes more that are still around before tagging.

@molinav I installes the hotfix branch
pip install<EMAIL_ADDRESS>
Hence I'm using the following package versions (pip list):

basemap                   1.3.9
numpy                     1.25.2
matplotlib                3.7.3

I tested the new version with a few simple examples and it worked for me.
Thanks!

@quickbrett I have just added a couple of unit tests for Basemap.shadedrelief based on your snippet, so I am finally closing this issue. The bugfix will come with basemap 1.3.9 (hopefully soon).


Can't pickle <class 'builtins.RustClass'>: attribute lookup RustClass on builtins failed

When attempting to pickle a PyO3 class, I am getting an error:
Can't pickle <class 'builtins.RustClass'>: attribute lookup RustClass on builtins failed
I have copied everything from this example here:
https://gist.github.com/ethanhs/fd4123487974c91c7e5960acc9aa2a77
Is pickle a supported feature or is this simply unavailable?

Hi @jafioti, while we don't have an official solution or documentation, what you're doing is mostly correct. Looking at the error, you need to make sure RustClass has the module set to the name of your extension module (otherwise it defaults to builtins).
You can do this with #[pyclass(module = "mymodule")].

Thanks for the response, now I have a new error:
_pickle.PicklingError: Can't pickle <class 'RustModule.RustSubmodule.RustClass'>: import of module 'RustModule.RustSubmodule' failed
Since this class is in a submodule, should I set the module to "RustModule.RustSubmodule" or just "RustModule"? It fails either way, but when I use "RustModule" it gives a different error:
_pickle.PicklingError: Can't pickle <class 'RustModule.RustClass'>: attribute lookup RustClass on RustModule failed

I found out that when I try to directly do import RustModule.RustSubmodule python does not find it, however when I do from RustModule import RustSubmodule it gets properly imported. I would assume I am missing something from my submodule or my main module, because as far as I know, those imports should be interchangable.
Here is my top-level module implementation:
#[pymodule]
fn RustModule(py: Python, module: &PyModule) -> PyResult<()> {
    let submodule = PyModule::new(py, "RustSubmodule")?;
    submodule::init_tokenization(submodule)?;
    module.add_submodule(submodule)?;

    Ok(())
}

The reason it works for from X import Y is that there, Y can be any object in the module's dict, while for import X.Y X must be a package and Y must be a module.
That would indicate that the RustModule is not properly set up as a package (i.e. a module that contains submodules).  I don't quite remember what is needed for that - probably __path__.

So - some experimentation results: on Python 3.7, the error message for your case is
No module named 'RustModule.RustSubmodule'; 'RustModule' is not a package
Adding a __path__ = [] attribute changes it to just
No module named 'RustModule.RustSubmodule'
so it does make Python regard the top module as a package, but still doesn't find the submodule.  This is probably because it does not care that the submodule is already present in the module's namespace and rather wants to look for some file on the filesystem.
It seems that what you need to do in addition is to pretend the module has already been imported, by placing it in sys.modules (with the correct name of RustModule.RustSubmodule).  So this snippet worked for me:
#[pymodule]
fn RustModule(py: Python, module: &PyModule) -> PyResult<()> {
    let submodule = PyModule::new(py, "RustModule.RustSubmodule")?;
    // py_run! is quick-and-dirty; should be replaced by PyO3 API calls in actual code
    py_run!(py, submodule, "import sys; sys.modules['RustModule.RustSubmodule'] = submodule");
    // this is actually not needed now that we don't trigger the import mechanism...
    // module.setattr("__path__", PyList::empty(py))?;
    module.add_submodule(submodule)?;

    Ok(())
}

@davidhewitt if this use case is to be supported properly, I think there should be a helper API to do this easily, maybe even in add_submodule (which currently does nothing more than add).

@birkenfeld nice find - I'd looked at the submodule import problem before but hadn't managed to find that placing it in sys.modules is the correct solution!
Agreed we should implement first-class support for this case. It would be nice if the module path was computed automatically rather than having to provide the full path to PyModule::new. This might require a little redesign of the module syntax.

Well, I can't promise it's the correct solution, but it works because it bypasses the import machinery.
I didn't remember an example of such a module hierarchy entirely implemented in C to look up how others are doing it.

@birkenfeld @davidhewitt Thanks for the solution, although hacky it works!


Fix AddExprCallback a:maker.bufnr/buffer_output

AddExprCallback a:maker doesn't have bufnr, it has buffer_output. Fixes endless error readouts when errors are returned from the maker. This would print a heap of times:
Error detected while processing function neomake#MakeHandler[33]..<SNR>147_RegisterJobOutput[31]..<SNR>147_ProcessJobOutpu
t[13]..<SNR>147_AddExprCallback:
line   82:
E716: Key not present in Dictionary: bufnr})
Press ENTER or type command to continue
Error detected while processing function neomake#MakeHandler[33]..<SNR>147_RegisterJobOutput[31]..<SNR>147_ProcessJobOutpu
t[13]..<SNR>147_AddExprCallback:
line   82:
E116: Invalid arguments for function <SNR>147_neomake_hook

It has bufnr for file_mode: https://github.com/neomake/neomake/blob/16f59087967621694ffa6ca595f99770d93e24a2/autoload/neomake.vim#L560
What are your steps to produce this error?  Using NeomakeProject as with https://github.com/neomake/neomake/pull/494/commits/7d74259d1c825bbefba9529c6e6c6f27e9155167#r70347454?

Hm, no I was using Neomake! cargo. Was that wrong?
If the changed line is only meant to run in file_mode, then there should be a guard there like everywhere else in the function.
I shouldn't have PR'd with such little knowledge of how the plugin works, sorry.

On 13 Jul 2016, at 9:33 PM, Daniel Hahler<EMAIL_ADDRESS>wrote:
It has bufnr for file_mode: https://github.com/neomake/neomake/blob/16f59087967621694ffa6ca595f99770d93e24a2/autoload/neomake.vim#L560
What are your steps to produce this error? Using NeomakeProject as with 7d74259#r70347454?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Check out https://github.com/neomake/neomake/pull/494

Well if it's the wrong way, I'm closing.


TokenStake Optimizations

Changes:

Update struct Staker

uint256 conditionIdOflastUpdate => uint64 conditionIdOflastUpdate
uint256 timeOfLastUpdate => uint128 timeOfLastUpdate`
Other associated changes to facilitate use of updated struct

Update struct StakingCondition

uint256 timeUnit => uint80 timeUnit
uint256 startTimestamp => uint80 startTimestamp
uint256 endTimestamp => uint80 endTimestamp
Other associated changes to facilitate use of updated struct

Remove stakerArray
Reduce size of stakingTokenDecimals and rewardTokenDecimals to allow for efficient variable packing
Reorder variables in Staking20.sol and Staking20Upgradeable.sol
Mark stakingTokenDecimals, rewardTokenDecimals, and stakingToken as immutable in Staking20.sol

These changes result in:

27% reduction in gas consumption in the stake function, 15% reduction in gas consumption in the withdraw function, and a 10% reduction i gas consumption in the claimRewards function.

Potential issues:

Contracts will not be usable in a 3.8309334e16 years.

Hey @WhiteOakKong love the PR, we're onto reviewing it. If you can get the code to pass the PR checks (and pending our internal review, which we'd communicate here), we can then merge it 🚢

Thanks @nkrishang. I just ran it through the linting, so hopefully that fixes the check.

Amazing, thanks! We're developing our gas optimization bounty program and would love to kickstart it with this PR.
Could you run forge build and then yarn gas, and commit the changes? This will populate the gasreport.txt (based on the benchmark tests in src/test/benchmark) and reflect the relevant changes in gas we want to measure.

All set.
For future reference, is this the style of PR you prefer? I opened a couple (#417 #416) right before this that were split a bit smaller in scope (IE both were optimizations on the same base contract but were different fundamental changes), but I think the scope of this PR is probably more ergonomic. If you agree, I'll combine those two.


Receipt Scanning Feature Documentation

Deliver comprehensive documentation for the receipt scanning feature to facilitate understanding and compliance, catering to both legal and engineering perspectives. This milestone encompasses the creation of a concise overview, a high-level system overview, and detailed data flow documentation with accompanying block diagrams. The documentation will be presented clearly with relevant non-technical and technical documentation, ensuring it meets the requirements for client review, legal scrutiny, and adherence to bank compliance standards.
Overview Page
As a client, I want a 1-page overview of the receipt scanning feature so that I can quickly understand its value without delving into technical details.

[x] https://github.com/tiki/apps-receipt-capacitor/issues/440

High-Level System Overview
As a client, I want a high-level system overview document to comprehend the components and deliverables involved in the receipt scanning feature.

[x] https://github.com/tiki/apps/issues/60
[x] https://github.com/tiki/apps/issues/61
[x] https://github.com/tiki/apps-receipt-capacitor/issues/442
[x] https://github.com/tiki/apps-receipt-capacitor/issues/443

Data Flow Documentation and Block Diagrams
As a client, I want detailed documentation on the data flow and block diagrams of the receipt scanning feature, including privacy and security considerations.

[x] https://github.com/tiki/capture/issues/6
[x] https://github.com/tiki/apps-receipt-capacitor/issues/445

https://www.dropbox.com/scl/fo/4ywfe06kd826wsau1mbzx/h?rlkey=jf09tt5f0h5z1jcwrd2v5jml9&dl=0


Support destroyCloudConfigVdiAfterBoot on the xenorchestra_vm resource

This is with regards to a discussion that happened in Discord.

The link does not seem to work for me, would you mind summarizing what this is supposed to do in a few sentences?

destoyCloudConfigVdiAfterBoot should remove the cloud config drive after the VM is booted (ie when XO got all the tools information)

Olivier beat me to it, but I'll add summaries to any linked discord conversations in the future 👍

How to use this function?

@TerAnYu this is a feature request so the functionality has not existed yet.
This was implemented in #255 and will be released in v0.25.0 coming later this week.

@TerAnYu this is a feature request so the functionality has not existed yet.
This was implemented in #255 and will be released in v0.25.0 coming later this week.

@ddelnano hi, any news?

Sorry for the late follow up on this. I will be making a release once #260 is merged. I'm hoping to merge that by the middle of this upcoming week.

@online01993 the v0.25.0 release will be ready in the next 30 mins or so.


CSUB-362-improve-address-reregistration-errors

for same account
for different account

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #1041 (d191825) into dev (017450b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1041      +/-   ##
==========================================
+ Coverage   77.56%   77.67%   +0.10%
==========================================
  Files          74       74
  Lines       10395    10446      +51
==========================================
+ Hits         8063     8114      +51
  Misses       2332     2332

Impacted Files
Coverage Δ

pallets/creditcoin/src/lib.rs
83.71% <100.00%> (+0.10%)
:arrow_up:

pallets/creditcoin/src/tests.rs
99.84% <100.00%> (+<0.01%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Overall looks good but CI jobs need attention.
I have questions around the newly added helper functions as I don't understand why we can't use the existing old function.

I don't know what's going on with the Build WASM Runtime job. It says rust nightly isn't installed.

Needs a rebase to pick up #1063


Add Options object to createStarryNight function

To allow users to provide a URL to a locally hosted oniguruma WASM binary, this commit allows users to provide a function that returns a URL object to a different WASM oniguruma binary, it should .
The options object can receive a getOnigurumaUrlFetch and a getOnigurumaUrlFs property for browser and node.
Closes #8

Thank you for working on this!!!

My pleasure, looking forward to using it on my own.

The ## Types section in the readme should include Options and GetOnigurumaUrl too.

Have listed them inline with the Grammar and Root

These changes need to be tested. I think it’s fine to only test the *Fs version. I think it’s fine to return a bogus URL there and catch the error.

Added to the test.js file, as you explained

Optionally, you can add an example. It can be quite short likely. To show your use case: self-hosting onig.wasm on your own website.

Added in e922348

One gnarly part is still that for this project, updating vscode-oniguruma, is likely unrelated to semver versioning, as it is internal, which means that people that use these features, will be broken at a point in the future: #8 (comment). I’d like to discuss this further. Do you have ideas on how to handle that? Even if we would cut a major on a vscode-oniguruma, and explain it to users, vscode-oniguruma might also change internals in patches/minors, which we pull in, but if people have a static file on a server, there will be people that forget to update, whose websites will break.

Yeah I thought about that, but I'm not sure I have a good answer, I think for now we should probably have a bigger Disclaimer in the readme and maybe in the jsdoc comments, so people know they can shoot themselves in the foot by using it..
Maybe if it shows that more people use it, and start have issues with it we can revert this PR.

@sebastinez Btw, if you go to the “Files changed” tab, you can click each suggestion and add them to a batch, and then commit them in one go, for the ones you agree with!

@sebastinez Btw, if you go to the “Files changed” tab, you can click each suggestion and add them to a batch, and then commit them in one go, for the ones you agree with!

Thanks @wooorm I prefer to handle it locally in my working copy and then push the final version.

It seems that the tests run now fine, and the linter doesn't comply.
I also added a Disclaimer that talks about eventual breaking if the used static WASM differs from the one pulled in from the CDN
If you are ok with it, please lmk and I will squash the commits down to one

Hmm ok nevermind CI says otherwise 😓 will look into them

Thanks for your terrific work, released in 1.5.0!

Thanks @wooorm for your help and support in merging this PR! Really appreciate your work 💪🙏


Set argument for redshift connection/cursor in order to fetch float instances?

Driver version
2.0.905
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.36224��
Client Operating System
Darwin Nativs-MacBook-Pro.local 21.4.0 Darwin Kernel Version 21.4.0: Mon Feb 21 20:34:37 PST 2022; root:xnu-8020.101.4~2/RELEASE_X86_64 x86_64
Python version
3.8.7
Problem description
I was wondering if there is some kind of a flag / setting I can set in order to tell the connector return a numeric result as float / np.float instead of decimal.Decimal instance?
I was using the following raw sql on a cursor instance:
cursor.execute("SELECT 1.0 / 7 AS foo")
df = cursor.fetch_dataframe()
output = df.squeeze()
assert not isinstance(output, decimal.Decimal)

Thanks in advance!

Hey @ni-todo-spot ,
Thanks for reaching out, this is a good question. At this time, all NUMERIC values are mapped to decimal.Decimal. decimal.Decimal is used for NUMERIC values as it offer a higher level of precision than float.
I will chat with the Redshift driver team to see if our Redshift JDBC driver offers such an option, and see if this is something we could support. Thank you for your patience :)

Hi @ni-todo-spot ,
Small update -- I've scoped work required for this feature and it looks minimal. I'm working on implementation/testing and anticipate we can include this feature in our next release (scheduled for mid-April). At this time, I think supporting an option for returning a numeric as float would be most straight forward.

Hi @ni-todo-spot ,
Small update -- I've scoped work required for this feature and it looks minimal. I'm working on implementation/testing and anticipate we can include this feature in our next release (scheduled for mid-April). At this time, I think supporting an option for returning a numeric as float would be most straight forward.

Great news! Thank you very much :)

Hi @ni-todo-spot ,
We've just released v2.0.906 of redshift_connector which includes this feature. Please be sure to read the disclaimer about this flag, numeric_to_float located in the project README before using. I've copied it below for your convenience. This disclaimer is just warning of the precision differences between decimal.Decimal and float, to ensure user is aware of this before use :).

Specifies if NUMERIC datatype values will be converted from decimal.Decimal to float. By default NUMERIC values are received as decimal.Decimal. Enabling this option is not recommended for use cases which prefer the most precision as results may be rounded. Please reference the Python docs on decimal.Decimal to see the tradeoffs between decimal.Decimal and float before enabling this option.

Please let me know if you have any questions by opening a new issue. Have a nice weekend! :)

@Brooke-white Wow! 👏
This is what I've been waiting for :)
Thank you very much 😄


All of the IE11 bugs

Describe the bug
This library doesn't work with IE11 at all. This is due to the right polyfills not existing.
To Reproduce

Create a new project with data-mocks included
Attempt to load up a page that uses data-mocks in IE11
Observe a million console errors

Expected behavior
That this library works as intended with IE11
Additional context
There will need to be a fair few polyfills added for this :(

it would still be nice if we could use this library in IE11...

@Dinosys I'll see if I can give this a look today!

I've got this working in a clean create-react-app project. I had to add the following polyfills to the project to get it working on ie11:
import "react-app-polyfill/ie11";
import "react-app-polyfill/stable";

However the only error I could attribute to data-mocks was Proxy is undefined which was caused by the fetch-mock library using Proxy which is unsupported by ie11.
This can be solved by a rollback to fetch-mock 6.5.2
https://github.com/wheresrhys/fetch-mock/issues/415#issuecomment-531505601
Definitely not seeing loads of console errors though.

I've looked into IE11 and gotten this working and the main things that are needed are proxy-polyfill and the fetch-polyfill. [736] fixed the fetch-mock compatibility problems so IE 11 support should work out of the box. I've also created a repo that has the minimum changes needed for a CRA repo.


[BUG] (short issue description)Codegen for mocks fails on filename case mismatch.

Describe the bug
Using the PDK shopping list demo , the generated code breaks during the build process with the following error;
File "/home/ec2-user/environment/tpdk/packages/api/generated/infrastructure/python/orgapi_python_infra/mock_integrations.py", line 23, in delete_shopping_list_200
infra:     with open(path.join(MOCK_DATA_PATH, "DELETE{}-200.json".format("/shopping-list/{shoppingListId}".replace("/", "-")).lower()), "r") as f:
infra:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra: FileNotFoundError: [Errno 2] No such file or directory: '/home/ec2-user/environment/tpdk/packages/api/generated/infrastructure/python/orgapi_python_infra/../mocks/delete-shopping-list-{shoppinglistid}-200.json'
The code performs a .lower() on the whole path rather than just the verb. The name of the generated json file is  delete-shopping-list-{shoppingListId}-200.json. This may also catch upstream directories with caps in their name.
The smithy definition is;
@http(method: "DELETE", uri: "/shopping-list/{shoppingListId}")
@handler(language: "python")
operation DeleteShoppingList {
input := {
@required
@httpLabel
shoppingListId: ShoppingListId
}
output := with [ShoppingListIdMixin] {}
errors: [NotFoundError]
}
Expected Behavior
Respect actual path/filenames.
Current Behavior
performs a .lower() on path and filename.
Reproduction Steps
Using the PDK shopping list demo
The smithy definition is;
@http(method: "DELETE", uri: "/shopping-list/{shoppingListId}")
@handler(language: "python")
operation DeleteShoppingList {
input := {
@required
@httpLabel
shoppingListId: ShoppingListId
}
output := with [ShoppingListIdMixin] {}
errors: [NotFoundError]
}
Possible Solution
No response
Additional Information/Context
No response
PDK version used
current
What languages are you seeing this issue on?
Python
Environment details (OS name and version, etc.)
AL2023

Hi @agdimech I also encounter this same issue when working with monorepo-py

So ignore it and it will go away?

Hi @vaneek,
Sorry this was auto-closed - I'm just back from leave!
Reopening this as it's definitely an issue! This could also possibly be related to #793
Cheers,
Jack

Hey @vaneek! I've just fixed this so it should be addressed when 0.23.62 is released :) Please let me know if you have any issues. Cheers!


middleware: Do not trust X-Forwarded-For; use X-Real-Ip, set from nginx.

The X-Forwarded-For header is a list of proxies' IP addresses; each
proxy appends the remote address of the host it received its request
from to the list, as it passes the request down.  A naïve parsing, as
SetRemoteAddrFromForwardedFor did, would thus interpret the first
address in the list as the client's IP.
However, clients can pass in arbitrary X-Forwarded-For headers,
which would allow them to spoof their IP address.  nginx's behavior
is to treat the addresses as untrusted unless they match an allowlist
of known proxies.  By setting real_ip_recursive on, it also allows
this behavior to be applied repeatedly, moving from right to left down
the X-Forwarded-For list, stopping at the right-most that is
untrusted.
Rather than re-implement this logic in Django, pass the first
untrusted value that nginx computer down into Django via X-Real-Ip
header.  This allows consistent IP addresses in logs between nginx
and Django.
Calls into Tornado already passed this header, as Tornado logging
respects it.
Testing plan: Deployed to test prod, made requests from an IP that was marked "trusted" as well as not.  Tested lists of IPs, with some trusted and not.  Passed in X-Real-IP headers from client and ensured they were ignored.

A local tornado directory threw isort for a loop.

This lgtm but I'd like @andersk to give a review as well, since I did not read the nginx documentation to confirm my understanding of what these settings do.

Ping @andersk, when you get a chance.


Reintegrate Bootstrap_controller Unit Tests

Some Bootstrap_controller tests were disabled in order to land the transition frontier persistence branch before it bitrot. These should be added back in ASAP to prevent new Bootstrap_controller bugs from being introduced.

Currently I am blocked by a weird behavior in the fake_network layer.
After tinkering around, I got to a state that the test was able to compile but failed to succeed. It seemed like get_ancestry RPC is failing. So I added a logger to the get_ancestry RPC handler in fake_network.ml ~line 103. I did see the log being printed but the log in Sync_handler.Root.prove is lost somehow. I tried to use printf instead, but it still didn't show up.

By @ghost-not-in-the-shell : merged, with the exception of 1 test in bootstrap_controller.ml


Added replicaSet handling

Intended to support replica settings as mentioned in #251
This will require users to modify their mongdb settings to look like:
    "mongodb": {
        "hosts" : ["<IP_ADDRESS>:27017","<IP_ADDRESS>:27019","<IP_ADDRESS>:27018"],
        "replicaSet":
        {
            "name": "clusterName",
            "readPreference" : "nearest"
        },
        "db" : "test",
        "username" : "jimi",
        "password" : "******"
    }

The additional config is only required if you want to use a replica set?


When connect argentx fails, modal keeps loading forever

When connect agentx fails the window keeps loading forever
Steps to reproduce the behavior:

Connect Metamask
Click to connect ArgentX (but dont actually connect)
Close AgentX window without signing
Error: The "connect argentX modal keeps loading forever instead of showing an error and ask for re-connection"

screenshot

OS: macOs Monterrey (12.4)
Browser Brave
Version 1.41.96 Chromium: 103.0.5060.114

I'm expecting Starknet's performance to be fully released.


Error - History Insert

Hello, I really liked your project, more to test the example shown in git an error occurs. iOS5
[self.historyTableView insertRowsAtIndexPaths: [NSArray arrayWithObject: newHistoryMessageIndexPath] withRowAnimation: UITableViewRowAnimationFade];
Assertion failure in -[_UITableViewUpdateSupport _computeRowUpdates], /SourceCache/UIKit_Sim/UIKit-
1912.3/UITableViewSupport.m:386
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid table view update.  The application has requested an update to the table view that is inconsistent with the state provided by the data source.
Thank you.

Can you provide sample code what you did to get this error?
Are you on the latest commit?

cheers Matthias
Am 24.12.2011 um 13:27 schrieb Lucas Correa:

Hello, I really liked your project, more to test the example shown in git an error occurs. iOS5
[self.historyTableView insertRowsAtIndexPaths: [NSArray arrayWithObject: newHistoryMessageIndexPath] withRowAnimation: UITableViewRowAnimationFade];
Assertion failure in -[_UITableViewUpdateSupport _computeRowUpdates], /SourceCache/UIKit_Sim/UIKit-
1912.3/UITableViewSupport.m:386
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid table view update.  The application has requested an update to the table view that is inconsistent with the state provided by the data source.
Thank you.

Reply to this email directly or view it on GitHub:
https://github.com/myell0w/MTStatusBarOverlay/issues/41

Same here

// same issue when use UIStatusBarStyleDefault , not issue when use UIStatusBarStyleBlackOpaque
[UIApplication sharedApplication].statusBarStyle = UIStatusBarStyleDefault;
MTStatusBarOverlay *statusBar = [MTStatusBarOverlay sharedInstance];

[statusBar postMessage:@"11111111111111" animated:YES];
[statusBar postMessage:@"22222222222222" animated:YES];
[statusBar postMessage:@"33333333333333" animated:YES];
[statusBar postMessage:@"44444444444444" animated:YES];
[statusBar postMessage:@"55555555555555" animated:YES];

I have disabled history tableview to avoid the crash and it workded.

I think this crash by the  messageHistory count error.
I changed the code as following:

(void)addMessageToHistory:(NSString *)message {
//....
  if (self.historyEnabled) {
      NSIndexPath *newHistoryMessageIndexPath =
              [NSIndexPath indexPathForRow: (self.messageHistory.count - 1) //Here sub 1~~~
                                 inSection:0];
 [self setDetailViewHidden:self.detailViewHidden animated:YES];

//....
}
@myell0w do you mine that?


Plasma 6.2 HEIC/HEIF image support broken

HEIF/HEIC image support is gone

HEIF/HEIC image support is missing from  plasma 6.2, my desktop now crashes as I had a HEIC image set for each of them.
Gwenview is no longer able to open HEIC images

Expected behavior
HEIF/HEIC images should load like they did in plasma 6.1.5
Notify maintainers
@K900

Known issue with Qt 6.8, will be fixed in the next staging cycle.


feat: add opening methods to responsiveAccordionTabs #10953

Changes:

make ResponsiveAccordionTabs using its options
add open/close/toggle methods to responsiveAccordionTabs

Closes #10953
Note: open/toggle methods are not supported in tabs mode.

Will test tomorrow.

Seems fine so far. But what about historyHandled and firstTime?

I still need to work on this. At least to improve the API for tabs. It is a bit difficult to understand what you need to pass to open between the tab and accordion markum.
So I'll take a look at historyHandled and firstTime too.

Do we also need some unit tests then?

Yes, there's never enough unit tests ;)

So I'll take a look at historyHandled and firstTime too.

Any news on this?

No, just need some time to work on this.

Is data-active-collapse="true" also relevant here?

Bump =)

I seen your message but as you can see this is new features planned for v6.6.0 so I'll not spend more time on this for now. There's enough work with getting v6.5.0 released.
Thx for the bump anyway =)

Ah ok, was not quite clear from the changes in the comment section, only on the right side.

doot. Would be cool to have this merged soon!

@DanielRuf it looks like you reviewed and tested this, is it good to merge?

Not sure but a few things are missing but I think it can be merged as it implements most of the currently missing things.
https://github.com/zurb/foundation-sites/pull/10961#issuecomment-367491518

OK based on prior comment going to merge this

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:
https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1


Cleanup lite

my fault was only for local use

Ah ok, saw this while on vacation and was somewhat shocked, fst will be cleaned up in 3.0, but I have to keep kson, json and structs fully functional as those are used in many projects :)


Add request.clone()

Fixes #623, although I’m pretty sure I missed something.

How do you debug superagent when a test fails on Android 5 on Linux and IE whatever on Windows 2012?

Not sure this is all that useful. Seems like a separate function can easily be created with the plugin system (based on your original use case description).

Wishing this small, useful PR was in superagent right now.
If the modifier functions (.query(), .set(), etc) don't return new immutable request objects and .clone() doesn't exist, then there's no built-in way to construct a request from an existing request.


Prevent push state configuration in route definition

Is it possible to prevent a route from being added to the window's history when visited? I know FlowRouter.withReplaceState works, but it makes it hard to simply click an a and go to the next route.
I mostly want this to be true with pages that are forms, so they don't go back to them.

Sorry. This is the only option we have.


username vs us

I attempted to use thing plugin to publish to an artifactory rubygem repository and ran into a problem with specifying username and password. I wasn't able to successfully upload using those two parameters.
The problem seems to be between the username parameter and the underlying call to dpl.
specifically: 'username' vs 'user'
https://github.com/drone-plugins/drone-rubygems/blob/master/main.go#L69
https://github.com/travis-ci/dpl/blob/master/lib/dpl/provider/rubygems.rb#L8
I was able to reproduce my failure directly, using the dlp gem on my local machine.
--user=brian works while --username=brian failed.
If you don't think changing main.go to append --user instead of --username, let me know.

@BrianBerzins thanks for reporting this, the issue will be fixed with https://github.com/drone-plugins/drone-rubygems/pull/5


docs: Use Debian and Ubuntu version numbers over development codenames

lgtm.  It's possible this could break some links to direct upgrade instructions, but I think our practice has been to link to https://zulip.readthedocs.io/en/latest/production/upgrade-or-modify.html#upgrading-the-operating-system and not specific releases, and I couldn't find any, so merged without any changes to links on the blog etc.  So merged, thanks @andersk!


👷 Add test for redistributing sdist, refactor CI to use requirements.txt files instead of Poetry

👷 Add test for redistributing sdist, refactor CI to use requirements.txt files instead of Poetry

This was handled in https://github.com/tiangolo/sqlmodel/pull/912 :fire:


The loss during training is 0

The following problem occurs when training instance segmentation with one's own dataset, with a loss of 0

@thangvubk Could you please answer? Thank you


Update to react 15.3.1

Coverage increased (+2.3%) to 95.833% when pulling 860afb1e4ccca0f39639d4a1a7a846e8d49eaf46 on qingweibinary:qingwei/remove_workaround into 290d39eccf5cde983ecdacd21dbe0d7e72eacfd5 on binary-com:master.