ref: Normalize user options

This PR adds normalization of user options that should make it easier to work with them down the line.

At some point, I'd like to see us having tests for the options normalization but it doesn't have to be right now. Let's talk about how we want to deal with tests for now and go with that strategy.

Jokes aside: Probably yes. Here it doesn't matter too much imo because TS pretty much asserts that stuff is correct but at some point, we should probably do some high-level integration tests.


z-index issue with Midnight

When you're going to upload, or opening an image from chat, the opacity makes it too dark to see clearly, and unable to click the "upload" button.
 before
 after.
Edit: It's any kind of popup,  like sending photos, opening photos, opening profiles turning the screen dark and unable to be read/interacted with like clicking send/cancel etc

Found the culprit. .backdrop-1wrmKB, .modal-1UGdnR { z-index: 1500 !important;} if you change that to 1000 or less it fixes it, but when you go to 1001 or above it breaks.

Fixed.


Bubble legends not correctly styled in Firefox

STR:

Create a map
Style the fill size by value
Create legend by size

In Firefox, the bubble legend is not correctly aligned at the center.
Please cc me in the PR, as we also may need to do some changes to legend migration.

Hey, this is kind of important @piensaenpixel, if there is no possibility to take a look, @nobuti, please, check it in any of your legends PR please.

Closed by #1457


currentMap ignored when using rome upload <current_framework_repo_name>

Bug Report
The rome upload command does not appear to use the currentMap when the current framework's repository name is passed in as a parameter.
Reproduction Steps:

have a Romefile with a currentMap entry that does not follow the "Organization/FrameworkName" convention. ie.

currentMap:
- better-dog-names:
  - name: DogFramework

run the rome upload command with current framework ie. rome upload better-dog-names

Expected behavior:

The S3 bucket is populated with an artifact file structure something like:

better-dog-names
  → iOS
    → DogFramework.framework.1.0.0.zip

Observed behavior:

The S3 bucket is populated with an artifact file structure something like:

DogFramework
  → iOS
    → DogFramework.framework.1.0.0.zip

note the top level directory is created with the framework name instead of the repository name.

Why would the enhancement be useful to most users

It would allow the currentMap feature to work in the intended way without forcing the unnecessary upload of the current project's dependencies (see additional information).
Ultimately we want to be able to run rome list --missing --no-skip-current (which works as expected right now) and then pipe the results into our call to rome upload

Rome version::

<IP_ADDRESS>

OS and version::

MacOS High Sierra 10.13.6

Additional information:

This came about because we are uploading to rome with the --no-skip-current flag when there are only changes in the current repo (ie. we don't want to push all the dependencies of the current framework as well).

Not specifying any specific frameworks with the rome upload command does properly create the folder structure on S3 but re-uploads all the dependencies of the framework as well (which IS the correct behavior for this command, but not ideal for our workflow).

Thought we might be able to work around this by duplicating the currentMap entry into the repositoryMap, but there is no entry in the Cartfile.resolved so this didn't work.

@ScottBuchanan there is a bug in this version where current + ignore doesn't work properly and results in exactly there same weird cache path. I have corrected it and will issue another pre-release.

Released here: https://github.com/blender/Rome/releases/tag/v<IP_ADDRESS>


Emote sorting, what I type, is not what I get

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Emote sorting, do sort, but with all these emotes, they don't sort casesensitive

I can't type the emote that I want, and get the emote that I want.
"That what I type, is not what I get" Sadge, definitely not a CS2 reference.

As example, when I type this. It suggests me rime, while there is an emote named Rime

It's a bit of a question. But definitely the emote that you type and matches an emote should atleast display on the emote suggestion.

whether emotes should be sorted by casesensitivity, or display by casesensitivity, might be a thing of preference and could be implemented but toggled in the settings

Screenshots
No response
OS and Chatterino Version
Chatterino Nightly 2.4.5 (commit 8fe3af35) built on 2023-09-16 with Qt 5.15.2, MSVC 193532217 Running on Windows 10 Version 2009, kernel: 10.0.19045

It works.
But there's something questionable that I don't know.
By default, the original version does this:

while the smarter completion one does this:

otherwise, the feature seems to work

happy smiley gets turned into the sad one Hmmmmmmmm


Undo redo feature not working as expected

There are some bugs where values are ported to another item or storage

It seems the undo stack is being messed during tracking the changes
It also seems this issue only occurs when changing the selected property
when editing the same property it seems to work fine

It seems the redo stack is messed up and the creation of a new undo command when switching to another property is redundant and results in duplicate undo-commands

Undo redo is fixed now for trivial input fields and properties


Cut Release 0.12

Description
This PR prepares for cutting release 0.12:

Updated changelog
Updated compatibility matrix
Pinned dependencies

Once this PR is merged, the next steps are:

create a branch release-0.12.
create a follow-up PR to restore branch settings in jsonnetfile.json.

Type of change
What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

[ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
[ ] FEATURE (non-breaking change which adds functionality)
[ ] BUGFIX (non-breaking change which fixes an issue)
[ ] ENHANCEMENT (non-breaking change which improves existing functionality)
[x] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

PR to fix the broken document link: https://github.com/prometheus-operator/kube-prometheus/pull/1920

@raptorsun sorry for the delay on this. Do you mind rebasing and getting this in shape?

@raptorsun sorry for the delay on this. Do you mind rebasing and getting this in shape?

no problem, I will update the PR soon :)

PR has been rebased and new changes are put into the change log.
The branch for kubernetes-mixin is still master. When we have created release branch on kubernetes-mixin, I will update again the PR to pin that repo to release-0.12 branch.
@PhilipGough 👋

All pre-requisites are ok. This PR is ready to review.

@PhilipGough couldn't we create the release-0.12 branch in advance and have this PR target the new branch? It would avoid the need of unpinning the dependencies in a subsequent PR.

@PhilipGough couldn't we create the release-0.12 branch in advance and have this PR target the new branch? It would avoid the need of unpinning the dependencies in a subsequent PR.

That's more simple, I wondered if we can merge this PR directly into a new release branch, too :)

@simonpasquier yes, thats the process that should be followed according to the release notes so let me create a release branch and we can target that with this PR

Hello guys, the PR is ready to review and merge.
The branch https://github.com/prometheus-operator/kube-prometheus/tree/release-0.12 has been created, so the test Check Documentation formatting and links (pull_request) should pass if we run it again.

Thanks @raptorsun


[SC-225223] Add blank state for samples.

Summary:

What: Add blank state when the use does not have any samples for a given pathogen
Ticket: sc225223
Env: none

Demos:

Notes:
This is only implemented on the new table and won't show until we swap over.
Checklist:

[x] I merged latest <base branch>
[x] I manually verified the change
[x] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

You forgot to include the code for the new component

You forgot to include the code for the new component

Thanks! Added now


Can we test this code on our own input videos?

Hi,
Yes.
You would need to input the videos frame by frame into the model and resize each frame to 384x288 (width x height ).
Best.


Fix AndroidJavaCompile not detecting incremental changes

The method fun getSources(): FileTree does not override the method
protected FileCollection getSources(), since the AGP plugin 3.5.1 has
not been compiled against Gradle 6.0, and therefore the necessary bridge
method is not generated.
Fixes #11330.

@lptr Please take a look!

Can we update one of the Android smoke tests to do an incremental compile too?

@big-guy We can and we should.

I'll do the smoke test(s) on master, given we changed quite a bit in those test already.


[SPARKTA-420][WEB]: Fix policy outputs when user is creating or editing a policy

LGTM

Only one commit. Please squash them.

:shipit:

Comment accepted. Will treat it ASAP

Squashing and checks in progress.


FIX: Temporary Fix for Issue #27

This fixes https://github.com/hwchase17/chat-langchain/issues/44 by monkey patching the VectorStoreRetriever class.
Also included in this PR is https://github.com/hwchase17/chat-langchain/pull/43/commits/3947f88f9f83732e345f28fe19f9ad0e20b49f2d to use ConversationalRetrievalChain instead of ChatVectorDBChain
Once the underlying issue is addressed: https://github.com/hwchase17/langchain/issues/2268 then my commit could just be reverted, but at least this gets the example up and running.

Thanks very much mate. Working for me now

+1, this solved my problem as well.


Fixed some small bootstrap issues

Thanks! I would love to merge more styling improvements. I really don't know what I'm doing when it comes to css/bootstrap.

I'm not very familiar with node but I am familiar with bootstrap and bootswatch so I'll try to help out there. I actually made a scouting web app in PHP last year for Aerial Assist.


coqPackages: etc

Motivation for this change
Many backward compatible changes

additional format owner/repo:branch to fetch sources in meta-fetcher
new argument origin to coq and mkCoqDerivation in order to
replace the current input version attribute, so that ultimately
the input and output version coincide. To preserve backward compatibility
we still allow to use version instead of origin but we send a warning
if the input and output versions differ. (This might be turned into an
error in the future).

Refactored coqPackages to pass it to every derivation,

mkCoqDerivation can now take a function instead of an attribute set,
the argument is a previous iteration of the arguments that mkCoqDerivation
pass to mkDerivation, mostly to get the computed version.

simplified derivation of mathcomp-analysis thanks to this.

All changes are duely documented
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

origin is not a very informative name. version sounded better, but I do understand the problem. Can we think of a better name?

That's the best name I could come with: src or any already used attribute name is excluded, and variations that are too close (like source for example) would be clumsy IMO. I'm open to suggestions though.

What about sourceOverride? Not very simple but at least the purpose is clear.

origin is not a very informative name. version sounded better, but I do understand the problem. Can we think of a better name?

That's the best name I could come with: src or any already used attribute name is excluded, and variations that are too close (like source for example) would be clumsy IMO. I'm open to suggestions though.

What about sourceOverride? Not very simple but at least the purpose is clear.

I don't like it... (too verbose, and not clear to me).
I'm thinking about shortSrc or fixSrc...

OK, well, let's keep origin if we cannot find anything better.

Result of nixpkgs-review pr 116690 run on x86_64-linux 1

IMHO it's too bad that this PR has waited for so long. I think only the version number change dev -> 999 needs more thinking so should be removed from this PR and discussed separately. The rest is almost ready, I've already reviewed it (see comments above) and only minor changes (mostly in the doc) are needed.

@CohenCyril As I said above, I think we should defer the version number change to a later PR and merge the rest. With respect to the version number, we should probably use what comes out of the discussion at https://github.com/NixOS/rfcs/pull/107. I like the idea of starting from an existing version number and adding a suffix (+unstable...) as it maps well with the possibility of taking a dev version for another branch. We could even chime in the RFC discussion if that's useful.

@CohenCyril As I said above, I think we should defer the version number change to a later PR and merge the rest. With respect to the version number, we should probably use what comes out of the discussion at NixOS/rfcs#107. I like the idea of starting from an existing version number and adding a suffix (+unstable...) as it maps well with the possibility of taking a dev version for another branch. We could even chime in the RFC discussion if that's useful.

I agree, I just did not have the time to deal with this yet.


fix: fix tooltip behavior on mobile device

Closes https://github.com/yamada-ui/yamada-ui/issues/1138
Description
Fix error , tooltip not showing on mobile device.
Current behavior (updates)
When using Yamada UI's tooltip on  mobile device . It doesn't show tooltip content.
New behavior
When you touch the trigger element on mobile , the tooltip will show . If you touch the trigger element or touch outside trigger element it will close tooltip.
Is this a breaking change (Yes/No):

Additional Information
Behavior description on mobile :
https://github.com/yamada-ui/yamada-ui/assets/78476413/3133120b-8ace-4ff6-a277-a47b9803489a

Thanks!


"odo create nodejs --downloadSource" creating one extra file on windows

/kind bug

What versions of software are you using?

Ran make test-cmd-devfile-create on windows. Also Ran the steps manually.

created new context dir with experimental mode enable
odo project create testd then cd
odo create nodejs --downloadSource or odo create nodejs --downloadSource nodejs-web-app

Actual behavior
On Windows
> mkdir -p testano

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        6/17/2020   8:05 AM                testano
> odo project create testanother
 V  Project 'testanother' is ready for use
 V  New project created and now using project: testanother

> cd .\testano\

> odo create nodejs --downloadSource
Experimental mode is enabled, use at your own risk

Validation
 V  Checking devfile compatibility [0ns]
 V  Creating a devfile component from registry: DefaultDevfileRegistry [4ms]
 V  Validating devfile component [584800ns]

Please use `odo push` command to create the component with source deployed

> ls

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo\testano

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        6/17/2020   8:10 AM                .odo
d-----        6/17/2020   8:10 AM                odo-devfiles-nodejs-ex-39b5ec7
-a----        6/17/2020   8:10 AM            731 devfile.yaml

> ls .\odo-devfiles-nodejs-ex-39b5ec7\

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo\testano\odo-devfiles-nodejs-ex-39b5ec7

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        6/17/2020   8:10 AM                app
-a----        6/17/2020   8:10 AM             14 .gitignore
-a----        6/17/2020   8:10 AM          14197 LICENSE
-a----        6/17/2020   8:10 AM          14289 package-lock.json
-a----        6/17/2020   8:10 AM            265 package.json
-a----        6/17/2020   8:10 AM            449 README.md

Extra file created here is odo-devfiles-nodejs-ex-39b5ec7 which leads --downloadSource and --downloadSource=nodejs-web-app to fail. All those expected files which are supposed to be under current directory is actually found under ./odo-devfiles-nodejs-ex-39b5ec7 on windows. Really a weird behavior but somehow it is happening.
Expected behavior
odo create nodejs --downloadSource or --downloadSource=nodejs-web-app should not create one extra file odo-devfiles-nodejs-ex-39b5ec7 on windows.
Any logs, error output, etc?
👀

Extra file created here is odo-devfiles-nodejs-ex-39b5ec7 which leads --downloadSource and --downloadSource=nodejs-web-app to fail.

Where is it failing ? is the push failing ? if yes paste the verbose output log.
PS > odo push -v 4

@prietyc123 Where is it failing ? is the push failing ? if yes paste the verbose output log.
PS > odo push -v 4

@amitkrout No, odo push is not failing. Its something weird behaviour on windows. Usually, what happens is odo create nodejs --downloadSource create the component in the current directory and package.json and all the other files will resides under the current directory itself. Whereas on windows somehow package.json, app etc.. falls under one random directory ./odo-devfiles-nodejs-ex-39b5ec7. Due to which whatever the files we are expecting in the current directory is not available there and this leads to the failure.
Does it answer your question?

Got it, test script is failing due to this weird behavior on windows platform. ping @EnriqueL8 https://github.com/openshift/odo/issues/3367#issuecomment-645305025

Same issue I am facing with --starter while creating the component on windows. Including --starter in the issue heading.
Steps to reproduce:
> mkdir -p testcreate

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo

Mode                LastWriteTime         Length Name
----                -------------         ------ ----

> cd .\testcreate\

> odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
PushTimeout
Experimental          true
PushTarget

> ls

> odo create nodejs --starter
Experimental mode is enabled, use at your own risk

Validation
 V  Checking devfile existence [88ms]
 V  Checking devfile compatibility [1ms]
 V  Creating a devfile component from registry: DefaultDevfileRegistry [96ms]
 V  Validating devfile component [964700ns]

Please use `odo push` command to create the component with source deployed

> ls

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo\testcreate

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        7/10/2020   7:07 AM                .odo
d-----        7/10/2020   7:07 AM                odo-devfiles-nodejs-ex-e832173
-a----        7/10/2020   7:07 AM              9 .gitignore
-a----        7/10/2020   7:07 AM           1277 devfile.yaml

> cd .\odo-devfiles-nodejs-ex-e832173\

> ls

    Directory: C:\Users\Admin\go\src\github.com\openshift\odo\testcreate\odo-devfiles-nodejs-ex-e832173

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        7/10/2020   7:07 AM                test
-a----        7/10/2020   7:07 AM           1635 .gitignore
-a----        7/10/2020   7:07 AM          14197 LICENSE
-a----        7/10/2020   7:07 AM          18290 package-lock.json
-a----        7/10/2020   7:07 AM            395 package.json
-a----        7/10/2020   7:07 AM           1189 README.md
-a----        7/10/2020   7:07 AM           1903 server.js

We have already set up our periodic job on PSI for fedora, windows and macOS. However the platform specific issues are acting as hindrance for the test run, so IMO its high time we fix these bugs or test script issues. But here good point is we have refractor sprint and I assume we can fix such small issue in that too 🙂

I cannot reproduce this with the latest master on a windows machine
PS C:\Users\User\Desktop> mkdir -p testano

    Directory: C:\Users\User\Desktop

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/21/2020  11:11 PM                testano

PS C:\Users\User\Desktop> cd .\testano\
PS C:\Users\User\Desktop\testano> C:\Users\User\Desktop\odo.exe create nodejs --starter
Validation
 V  Checking devfile existence [0ns]
 V  Creating a devfile component from registry: DefaultDevfileRegistry [3ms]
 V  Validating devfile component [1ms]

Starter Project
 V  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [2s]

Please use `odo push` command to create the component with source deployed
PS C:\Users\User\Desktop\testano> ls

    Directory: C:\Users\User\Desktop\testano

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/21/2020  11:12 PM                .odo
d-----       10/21/2020  11:12 PM                test
-a----       10/21/2020  11:12 PM           1644 .gitignore
-a----       10/21/2020  11:12 PM           1374 devfile.yaml
-a----       10/21/2020  11:12 PM          14197 LICENSE
-a----       10/21/2020  11:12 PM          18290 package-lock.json
-a----       10/21/2020  11:12 PM            395 package.json
-a----       10/21/2020  11:12 PM           1189 README.md
-a----       10/21/2020  11:12 PM           1903 server.js

Tried on both powershell and cmd. @prietyc123 Please share the devfile.yaml data created during the test.

I have tried on both powershell and cmd. @prietyc123 Please share the devfile.yaml data created during the test.

@anandrkskd Could you please look into this and confirm once as you are currently working on windows VM.

I was also not able to reproduce with latest master,
odo create nodejs --starter
Validation
 V  Checking devfile existence [0ns]
 V  Checking devfile compatibility [1ms]
 V  Creating a devfile component from registry: DefaultDevfileRegistry [15ms]
 V  Validating devfile component [996700ns]

Starter Project
 V  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [425ms]

Please use `odo push` command to create the component with source deployed
PS C:\Users\Admin\ctests> ls

    Directory: C:\Users\Admin\ctests

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/22/2020   7:41 AM                .odo
d-----       10/22/2020   7:41 AM                test
-a----       10/22/2020   7:41 AM           1644 .gitignore
-a----       10/22/2020   7:41 AM           1374 devfile.yaml
-a----       10/22/2020   7:41 AM          14197 LICENSE
-a----       10/22/2020   7:41 AM          18290 package-lock.json
-a----       10/22/2020   7:41 AM            395 package.json
-a----       10/22/2020   7:41 AM           1189 README.md
-a----       10/22/2020   7:41 AM           1903 server.js

and here is the devfile.yaml content for any reference
schemaVersion: 2.0.0
metadata:
  name: nodejs
  version: 1.0.0
  alpha.build-dockerfile: "https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/build/Dockerfile"
  alpha.deployment-manifest: "https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/deploy/deployment-manifest.yaml"
starterProjects:
  - name: nodejs-starter
    git:
      remotes:
        origin: "https://github.com/odo-devfiles/nodejs-ex.git"
components:
  - name: runtime
    container:
      image: registry.access.redhat.com/ubi8/nodejs-12:1-45
      memoryLimit: 1024Mi
      mountSources: true
      sourceMapping: /project
      endpoints:
        - name: http-3000
          targetPort: 3000
commands:
  - id: install
    exec:
      component: runtime
      commandLine: npm install
      workingDir: /project
      group:
        kind: build
        isDefault: true
  - id: run
    exec:
      component: runtime
      commandLine: npm start
      workingDir: /project
      group:
        kind: run
        isDefault: true
  - id: debug
    exec:
      component: runtime
      commandLine: npm run debug
      workingDir: /project
      group:
        kind: debug
        isDefault: true
  - id: test
    exec:
      component: runtime
      commandLine: npm test
      workingDir: /project
      group:
        kind: test
        isDefault: true

I think it has been fixed, so closing this issue
/close


The app cannot be opened safely

**macOS version: 11.0.1
**Kap version: 3.3.2
Steps to reproduce

I'll package and use this package.json
run command line - "yarn run dist"
The generated DMG files need to be placed on OSS，and then download it locally
The Mac's security and privacy preferences are set to allow the installation of apps from the App Store and approved developers

Current behaviour
The system told me that I couldn't develop the APP because I couldn't verify the developer.Buttons only move to the wastebasket and cancel
Expected behaviour
We're hoping for the following:
Prior to macOS Catalina, opening an app that hasn't been notarized shows a yellow warning icon and asks if you're sure you want to open it:
Other file or link
1、Safely open apps on your Mac
2、package.json
{
   ......
  "build": {
    "appId": "***",
    "productName": "***",
    "copyright": "***",
    "buildDependenciesFromSource": true,
    "generateUpdatesFilesForAllChannels": true,
    "directories": {
      "buildResources": "build",
      "output": "mac"
    },
    "protocols": {
      "name": "***",
      "schemes": [
        "***"
      ]
    },
    "files": [
      "**/*",
      "!renderer",
      "renderer/out"
    ],
    "mac": {
      "target": [
        "dmg"
      ],
      "icon": "./build/china-icon.icns",
      "electronUpdaterCompatibility": ">=2.16",
      "category": "public.app-category.productivity",
      "minimumSystemVersion": "10.12.0",
      "darkModeSupport": true,
      "hardenedRuntime": true,
      "gatekeeperAssess": false,
      "identity": "***",
      "entitlements": "./build/entitlements.mac.plist",
      "entitlementsInherit": "./build/entitlements.mac.inherit.plist",
      "cscLink": "./build/mac.p12",
      "extendInfo": {
        "NSMicrophoneUsageDescription": "CaptureScreenRecorder needs access to the microphone to be able to record audio for screen recordings.",
        "NSCameraUsageDescription": "A CaptureScreenRecorder plugin wants to use the camera.",
        "NSUserNotificationAlertStyle": "alert",
        "CFBundleDocumentTypes": [
          {
            "CFBundleTypeName": "Video",
            "CFBundleTypeRole": "Viewer",
            "LSHandlerRank": "Alternate",
            "LSItemContentTypes": [
              "public.mpeg-4",
              "***"
            ]
          }
        ]
      }
    },
    "dmg": {
      "background": "./build/background.png",
      "icon": "./build/china-icon.icns",
      "iconSize": 70,
      "iconTextSize": 12,
      "sign": false,
      "format": "UDBZ",
      "contents": [
        {
          "x": 180,
          "y": 170
        },
        {
          "x": 480,
          "y": 170,
          "type": "link",
          "path": "/Applications"
        }
      ]
    },
    "afterSign": "./build/notarization.js"
  }
}

3、notarization.js
const fs = require('fs');
const path = require('path');
const electron_notarize = require('electron-notarize');

module.exports = async function (params) {
    if (process.platform !== 'darwin') {
        return;
    }
    let appId = '***'
    let appPath = path.join(params.appOutDir, `${params.packager.appInfo.productFilename}.app`);

    if (!fs.existsSync(appPath)) {
        throw new Error(`Cannot find application at: ${appPath}`);
    }

    try {
        await electron_notarize.notarize({
            appBundleId: appId,
            appPath: appPath,
            appleId: "***",
            appleIdPassword: "***",
        });
    } catch (error) {
        console.error(error);
    }
    console.log(`Done notarizing ${appId}`);
};

Why are you packaging Kap yourself? We already provide a packaged version of the app.

Why are you packaging Kap yourself? We already provide a packaged version of the app.
I know , I just wanted to give it a try

We cannot really provide general Electron support here. Packaging works for us, so it must be something with your system.
You could try https://discuss.atom.io/c/electron/11


GDPR critical features

Is your feature request related to a problem? Please describe.

Add a possibility to download your own data
Add a way to delete your account.
Add a cookie consent banner (there are no tracking cookies, only the auth cookie, but the user needs to be informed about it)
Add a privacy policy

[+] Download data
[+] Delete Account


Pluralize correctly

Fixed plural issues for report

Start Time shown on report will be always based on viewer's timezone. Changed to 24hr format and timezone will be displayed.

Retry mechanism for verbose mode

[x] I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code

[x] I've requested reviews from 1 reviewer

[x] I've tested existing features (website scan, sitemap, custom flow) in both node index and cli

[x] I've synced this fork with GovTechSG repo

[ ] I've added/updated unit tests

[ ] I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

Open a new PR without Retry mechanism for verbose mode


data-bs-target doesn't support complex css selector

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
The data-bs-target css selector doesn't works with complex selector like "#myDiv:not(.show)".
I have checked it with the dropdown and collapse components.
It works in version 5.2, but not 5.3.3
This is useful if you want a button to open a collapse, without being able to close it when you click again.
Reduced test cases
<button class="btn btn-primary" type="button" data-bs-toggle="collapse" data-bs-target="#myDiv:not(.show)">Open</button>

Hidden message

If you rename the div id to

 (what is a wrong thing to do), it toggle the collapse again.
bootstrap_example.txt
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.3.3

Edit: It works using class, but not id, for example:
<button class="btn btn-primary" type="button" data-bs-toggle="collapse" data-bs-target=".myDiv:not(.show)">Open</button>

Hidden message


EnvViz: improving display of global environment

Currently we have:

I appreciate that this rendering "pre-declared names" uses a fake binding of a variable that has the name "pre-declared names". Sticking with this hack, here is how to get it to look nice:

assign the "unassigned" value to the variable: that way there will be nothing, instead of ...
use "::: pre-declared names ::" as the name of the variable

Then the frame will show:
::: pre-declared names :::

Here is why I think this is a good move:

In this picture,
predeclared names
looks like a variable name


update-github-issue-and-pull-request action shouldn't fail when issues are disabled (OSOE-689)

When the Issues feature is disabled on the repository, update-github-issue-and-pull-request fails instead of skipping the issue check.

the 'Lombiq/XYZ' repository has disabled issues
No issue was found with the query 'ASDF-123 in:title' in the repository 'Lombiq/XYZ'

Jira issue

@BenedekFarkas Could you give me an example of a repository where the issues feature is disabled?

@BenedekFarkas Do I see it correctly that the action is not directly failing so it does not produce a complete action fail but just returns this error message ? I checked repos where this is the case and the action and the job was kind of passing eventhough this error message No issue was found with the query 'ASDF-123 in:title' in the repository 'Lombiq/XYZ' was present. If there was a completely failing job that you noticed, could you maybe send a link of that run?

Nope, the job failed due to this error. I'll follow-up in Jira about it, because it's a private project.

The implementation under https://github.com/Lombiq/GitHub-Actions/pull/258/ prevents the update of the PR with the Jira issue key too when GitHub issues are disabled. This is not suitable, since we definitely use Jira issues when not using GitHub issues.

Indeed. The relevant part of Update-GitHubIssueAndPullRequest:
$issueQuery = "$issueKey in:title"
$output = gh issue list --search $issueQuery --repo $GitHubRepository
$issueItem = ($output | Select-Object -First 1)

if ($issueItem)
{
    // Logic to update the issue.
}

So the check against having issues happens too high in the code hierarchy now, instead it should be something like:
$issueQuery = "$issueKey in:title"
$issueItem = $null
if ((gh api repos/$GitHubRepository | ConvertFrom-Json).has_issues)
{
    $output = gh issue list --search $issueQuery --repo $GitHubRepository
    $issueItem = ($output | Select-Object -First 1)
}

This is more to the point (slightly more code, but only fetches the information we need):
(gh repo view $GitHubRepository --json hasIssuesEnabled | ConvertFrom-Json).hasIssuesEnabled

What's more, the if: github.event_name == 'pull_request' && github.event.action == 'opened' && steps.check-issues-are-enabled.outputs.issues-enabled == 'false' condition in validate-submodule-pull-request also disables the "Update GitHub issue and Pull Request" step when issues are actually enabled.
I'm reverting the https://github.com/Lombiq/GitHub-Actions/pull/258 PR in dev.


projects: include link to Music Speed Changer

Hey, thank you for contributing to wavesurfer.js!
To review/merge open PRs it is very helpful to know as much as possible about the changes which are being introduced. Reviewing PRs is very time consuming, please be patient, it can take some time to do properly.
Title: Please make sure the name of your PR is as descriptive as possible (Describe the feature that is introduced or the bug that is being fixed).
Please make sure you provide the information below:
Short description of changes:
Breaking in the external API:
Breaking changes in the internal API:
Todos/Notes:
Related Issues and other PRs:

cool!

Thanks!


Repeated definition found when attaching to module.exports

VSCode Version: 1.38.0
OS Version: macOS Mojave 10.14.6

Steps to Reproduce:

Create a new file with the following code

module.exports.test = async () => {
    return 123;
}

module.exports.test();

Cmd + Click on the usage of function
Panel shows up with 2 definitions, although the references to the definitions are for the same file at the same line

Does this issue occur when all extensions are disabled?: Yes

Thanks for the example. Opened https://github.com/microsoft/TypeScript/issues/33520 to track this upstream


Question: Log handling

Could we log all HTTP requests? @georgepadayatti
Now, the logs seem to show only the security log providing login info and its pretty empty.

Yes will take a note.
On Sat, 4 Nov 2023 at 10:18 PM, Lal Chandran @.***>
wrote:

Assigned #451
https://github.com/decentralised-dataexchange/bb-consent-api/issues/451
to @georgepadayatti https://github.com/georgepadayatti.
—
Reply to this email directly, view it on GitHub
https://github.com/decentralised-dataexchange/bb-consent-api/issues/451#event-10863205148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5DNCBGR2JI7ZWP3YPG5ADYCZWXPAVCNFSM6AAAAAA65WCUV2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA3DGMRQGUYTIOA
.
You are receiving this because you were assigned.Message ID:
<decentralised-dataexchange/bb-consent-api/issue/451/issue_event/10863205148
@github.com>

l HTTP requests? @georgepadayatti

Should we log all the API calls (onboard, config, service and audit) or just those of organisation admin ?

Do you know if all calls could be logged? What do you suggest? Is it possible to switch ON and OFF? E.g. userlogs are something we need to enable. But all admin actions shall be.

All calls could be logged. What do you suggest? Is it possible to switch ON and OFF? E.g. userlogs are something we need to enable. But all admin actions shall be.

Maybe add configuration field for it ?

Sounds good


The sprint bind sometimes act like a toogle

Describe the bug
When using a controller, with "Toggle Sprint on Controller" set to off, the sprint action will be sometimes toggled when pressing multiple time
To Reproduce
Steps to reproduce the behavior:

Set any bind to "Sprint"
Start moving forward
Press multiple time the Sprint bind on the controller and start and stop moving (go on an ocean for more obvious result)
when not moving, press the Sprint bind on the controller or the keyboard

Expected behavior
Not toggling the sprint
Desktop (please complete the following information):

OS: Windows 11
Minecraft 1.19.4
Fabric 0.14.18
Version 1.8.0

Same here, I hope the issue is fixed soon cause I've been dealing with it since 1.19.2 and even on 1.19.4 it's still there...


updated aquaskk (4.3.5)

Thank you for the contribution. It was merged directly as 9f92a33bf0933bfa813e9a7808913806e35e4fd3 to keep commit history cleaner. Your contribution is still credited to you.


Initial quick support for pydantic 2 (>=1.10.17)

Changing the try-error imports and just using pydantic.v1 API point for now. This should be supporting pydantic>=1.10.17 as per the migration guide in https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features
Solves #14

pydantic 2 seems to be picked up when creating the environment https://github.com/choderalab/feflow/actions/runs/10258575412/job/28381617669?pr=58#step:6:409
This seems to be working fine, ready for review.

You might consider, if you don't mind the larger matrix, testing both v1 and v2 at install time, just to catch when one doesn't work. Right now it looks like either should work at install time

@mattwthompson that's a good suggestion. Thanks!

Should be working correctly:

pydantic 1: https://github.com/choderalab/feflow/actions/runs/10290852560/job/28481794543?pr=58#step:6:408
pydantic 2: https://github.com/choderalab/feflow/actions/runs/10290852560/job/28481795076?pr=58#step:6:411


Gitea as service not starting after reboot

Gitea version (or commit ref): 1.13.0
Git version: git version 2.25.1
Operating system: Linux nuc-mini-server 5.4.0-58-generic #64-Ubuntu SMP Wed Dec 9 08:16:25 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist:

After reboot my system, gitea is not starting automaticaly. I didn't chage the configuration. Some days ago I updated to 1.13.0.
$ sudo systemctl status gitea
gitea.service - Gitea
     Loaded: loaded (/etc/systemd/system/gitea.service; enabled; vendor preset: enabled)
     Active: inactive (dead)

And this my gitea.sercice configuration
$ more /etc/systemd/system/gitea.service
[Unit]
Description=Gitea
After=syslog.target
After=network.target
After=docker.service
After=postgresql.service
#After=mariadb.service mysqld.service postgresql.service memcached.service redis.service

[Service]
# Modify these two values and uncomment them if you have
# repos with lots of files and get an HTTP error 500 because
# of that
###
#LimitMEMLOCK=infinity
#LimitNOFILE=65535
RestartSec=2s
Type=simple
User=git
Group=git
WorkingDirectory=/var/lib/gitea
ExecStart=/home/git/bin/gitea web -c /etc/gitea/app.ini
Restart=always
Environment=USER=git HOME=/home/git GITEA_WORK_DIR=/var/lib/gitea
# If you want to bind Gitea to a port below 1024 uncomment
# the two values below
###
#CapabilityBoundingSet=CAP_NET_BIND_SERVICE
#AmbientCapabilities=CAP_NET_BIND_SERVICE

[Install]
WantedBy=multi-user.target

I can't see any problems in logs. Looks like the service will be not started. Manual start is working.
Has anyone any idea?

Maybe check journalctl for any errors?

@TsakiDev there was no error.
After I removed
After=docker.service
looks like it started. This is strange, cause I didn't change the config for months.


Is there a way to retrieve a view with at least one of the specified components?

I am looking through the crash course, and the one thing I found closest to what I need is a view pack. Would this work?
Also curious about how EnTT works with components with inheritance. Would registry.view<base>(); yield all entities containing base/derived components?

Is there a way to retrieve a view with at least one of the specified components?

What does it mean a view with at least one of the specified components? As if it were an or rather than an and?

Would registry.view(); yield all entities containing base/derived components?

Definitely no. Stop thinking in terms of hierarchies when it comes to using an ECS model.

As if it were an or rather than an and?
Yes exactly that!

Then no, I'm sorry. Views return only the entities that have all the elements.
If you want those that have at least one of components and you want them only once, probably the best is to iterate multiple views separately and put the entities in a set.
However, this really, really, really smells of an XY-problem. Something like I have states idle and jump and I want to find the entities that have a state, no matter what. Just rethink your design. You don't need an or-like view here. You just need to refactor your component types and probably a more ECS-y thinking. 👍

Hmm, ok! I'll try to rethink my approach. Thanks so much!


Graph attribute importance scores along with top 5

In the Jupyter notebook, we currently display the 5 attributes that have the highest importance scores in a table, like below. Let's have a graph with all the attributes and their scores.

A histogram of attribute importance scores should be interesting to see as well. Ex:


Not working out of the box with Cocoapods 0.36.4 and use_frameworks

I have to use a project that's mixed with Swift (such as Alamofire) and Objective C libraries (such as this). But Xcode can't find EstimoteIndoorSDK files after installing with Cocoapods 0.36.4 with use_frameworks.  Supposedly we don't need the bridging header files now with the use_frameworks setting. I did end up getting it to work but had to do some finagling to do so.  I had to use import EstimoteIndoorSDK at the tops of my ViewControllers and then had to change
#import "ESTBeacon.h"
#import "ESTDefinitions.h"

in ESTPositionedBeacon.h (https://github.com/Estimote/iOS-Indoor-SDK/blob/master/EstimoteIndoorLocationSDK/Headers/ESTPositionedBeacon.h#L4-L5) to
#import <EstimoteSDK/ESTBeacon.h>
#import <EstimoteSDK/ESTDefinitions.h>

That allowed me to at least build and use the example files.

I have the same problem, but don't get fixed. I would like to use EstimoteSDK, but Xcode can't find it.
My Podfile:
platform :ios, '8.4'
# Look for target to link with in an Xcode project called
# `beaconTest.xcodeproj`.
xcodeproj 'beaconTest'

# use only frameworks - actual beacuse prgramming in swift
use_frameworks!

# use this pods
pod 'EstimoteSDK', '2.4.0'
pod 'XCGLogger', '~> 2.1'

link_with 'beaconTest', 'beaconTestTests'

# for specific things
target 'beaconTest' do

end

target 'beaconTestTests' do

end

My first try was to use a bridging-header. That doesn't work. My second try was to import it like alanhartless (or like http://www.innerexception.com/2015/05/cocoapods-useframeworks-means-bridging.html). XCGLogger can be used, but not EstimoteSDK. Any ideas?
My System:
Xcode 6
Cocoa Pods 0.37.2

+1
not working for me either
Xcode 7.2.1
Cocoapods 1.0.0

This issue should be fixed in the newest Indoor Location SDK. If you encounter similar problems please re-open or post a new issue! :)

Im seeing this issue with the latest

@mdramos Could you describe the steps to reproduce the behaviour you are experiencing?
Did it occur on second attempt as well?


refactor: Improve readability of Schema Details section

Codecov Report

Merging #107 (e25fa50) into main (d7ff5e8) will not change coverage.
 Consider uploading reports for the commit feb382d to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   38.43%   38.43%
=======================================
  Files         102      102
  Lines        1535     1535
=======================================
  Hits          590      590
  Misses        945      945

Impacted Files
Coverage Δ

...atures/Dashboard/UI/Components/SchemaDetails.razor
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[GSSoC'23] World Clock Front-end Project

Describe the project you want to add with tech stack

Title - World clock
Tech using - HTML, CSS and JS
Expected behavior

Showing the real date & time of different places of the world in just one click.
Moving Clock front-end clock
Best layout of more than one clocks.
Responsive website.

Screenshots (optional)

Additional context (optional )

@pranjay-poddar @MohitGupta121 @Saurabh-kumar09 sirs, please assign this project to me


Windows 10 - No pGina login screen

I've just installed pGina fork instead of the original one and I can't get it to work. I configured LDAP and there's just no pGina in login screen.
Also, it's a pity there's no simulator anymore. On original pGina I had a problem with SSL connection that's why I switched to pGina fork hoping it was some kind of bug but now I have no way to test it.

https://github.com/MutonUfoAI/pgina/issues/62
and the rest is very helpful.
What version of windows 10 are you using
Is the service running
What have you configured
Have you set a provider filter ....
http://mutonufoai.github.io/pgina/documentation/user.html#credential_provider_filter

Version is Windows 10 Pro 1809 compilation 17763.316

Turns out service is set to start automatically but it doesn't start on reboot.
Here's log from pGina.Service.ServiceHost_log after rebooting

2019-03-04 08:54:28,521 [8156|7|INFO ] pGina.Service.Impl: SessionChange:1 6
2019-03-04 08:54:28,597 [8156|42|INFO ] pGina.Service.Impl: SessionChange: 1 -> SessionLogoff
2019-03-04 08:54:28,613 [8156|42|INFO ] pGina.Service.Impl: Logoff in progress 1
2019-03-04 08:54:28,661 [8156|42|INFO ] pGina.Service.Impl: CREDUIhelper:(1)
2019-03-04 08:54:28,722 [8156|42|INFO ] pGina.Service.Impl: User:? in session:1 is unknown to pGina
2019-03-04 08:54:28,862 [8156|42|INFO ] pGina.Service.Impl: Logoff completed 1
2019-03-04 08:54:29,613 [8156|45|INFO ] Pgina Service: Preshutdown Event received
2019-03-04 08:54:29,628 [8156|45|INFO ] Pgina Service: RequestAdditionalTime finished
2019-03-04 08:54:29,801 [8156|45|INFO ] pGina.Service.Impl: Stopping service
2019-03-04 08:54:29,801 [8156|45|DEBUG] SessionLimitPlugin: Stopping timer

I configured LDAP to Authenticate, Authorize and as Gateway. No filters in Authorization (default Allow),
in Gateway Users should be always added to Users group.
Local machine is checked for Authentication and Gateway.

I didn't set that before but when I set it today it didn't changed anything.

I guess the problem is with the service not starting but I don't unterstand why it's not starting. I will try to set it to start automatically (delayed) before you respond me. If I won't edit my post in like 10 minuted then it means that it didn't help either.

I noticed there is no pGinaCredentialProvider.dll in x64 directory (there is one in Win32 though). Not sure if that matters but I reinstalled pGina and the file appeared and now I get the pGina login screen.

FYI, for some reason this file keeps disappearing


Fix video play control broken after coming back from thread

Details

The video player control is broken because the video ref becomes null when coming back from thread. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/37722
PROPOSAL: https://github.com/Expensify/App/issues/37722#issuecomment-2000049459
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Send a video to any chat
Open the thread of the video message
Play the video and enable the sound
Press the thread message to go back to the parent message
Verify the thread video is stopped (no sound heard)
Verify the parent message video isn't played yet
Play the parent message video
Verify the video player control works normally (volume, playback speed, etc.)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/531d8fdf-24d7-42f6-abd3-e2ac0f8d9d6b

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/91c474f1-c5d6-427b-9ab6-e4b40293757d

iOS: Native

https://github.com/Expensify/App/assets/50919443/22251cdb-fce5-44fd-8e73-95b76183b162

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/6c3512f0-7394-4891-907b-fcdbf150902f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/ee723b78-8c98-45ef-8764-f29e73baa831

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/92bddc8e-1954-4092-aacf-39a6fe209b38

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


RHIROS-1163 RHIROS-1222 add suggested instance types table

Why do we need this change? :thought_balloon:
RHIROS-1163
Documentation requires update? :memo:

[ ] Yes
[X] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[X] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Codecov Report
Patch coverage: 11.53% and project coverage change: -0.20 :warning:

Comparison is base (e0fc432) 17.84% compared to head (29c6144) 17.65%.

:exclamation: Current head 29c6144 differs from pull request most recent head ee5c5e9. Consider uploading reports for the commit ee5c5e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   17.84%   17.65%   -0.20%
==========================================
  Files          39       42       +3
  Lines         818      861      +43
  Branches      148      156       +8
==========================================
+ Hits          146      152       +6
- Misses        621      658      +37
  Partials       51       51

Impacted Files
Coverage Δ

src/App.js
0.00% <0.00%> (ø)

...s/SuggestedInstanceTable/SuggestedInstanceTable.js
0.00% <0.00%> (ø)

...c/Components/SystemDetail/SystemRecommendations.js
0.00% <0.00%> (ø)

src/Routes.js
0.00% <0.00%> (ø)

src/Routes/RosPage/RosPage.js
0.00% <0.00%> (ø)

...outes/RosSuggestedInstance/RosSuggestedInstance.js
0.00% <0.00%> (ø)

src/Routes/RosSystemDetail/RosSystemDetail.js
0.00% <0.00%> (ø)

src/store/isConfigured.js
0.00% <ø> (ø)

src/Components/NoEntitiesFound/NoEntitiesFound.js
100.00% <100.00%> (ø)

src/constants.js
74.19% <100.00%> (+3.82%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@r14chandra can you also please fix the conflicts 🙌🏻

Thanks for the review @kgaikwad @PreetiW !


Cleaned up Clu's generate functions

Re-factored functions and removed repeated codes.
Removed verbose Boolean logic

I like the boolean simplification, not sure about adding the bool to the
kernel interface call. I do agree that the function name is vague though.
I lately I was thinking that enum would be a better choice.  Would that be
okay in the case?
There are a couple of functions that have almost same signature except
minor difference knd if there to add the minor difference in their
signature. But changing it to enum and using match is an option I would
want to explore.
As per the name, I just tweaked already  chosen name to avoid something
different.
I would change the fn name, but do you have anything in mind?
On Tue, May 1, 2018, 8:23 PM Justin Kilpatrick<EMAIL_ADDRESS>wrote:

@jkilpatr commented on this pull request.
I like the boolean simplification, not sure about adding the bool to the
kernel interface call. I do agree that the function name is vague though.
In clu/src/lib.rs
https://github.com/althea-mesh/althea_rs/pull/68#discussion_r185309479:

@@ -34,7 +34,7 @@ pub enum CluError {
RuntimeError(String),
}

-fn linux_generate_wg_keys(SETTINGS: Arc<RwLocksettings::RitaSettings>) -> Result<(), Error> {
+fn generate_wg_keys_and_set_wg_keys(SETTINGS: Arc<RwLocksettings::RitaSettings>, knd: bool) -> Result<(), Error> {
what exactly is knd for here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/althea-mesh/althea_rs/pull/68#pullrequestreview-116671855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAaRlQ9EL11urQVbPPk4t87xKfGobvYks5tuLYsgaJpZM4Tk5Vm
.


Implement optional OxoG filtering (resolves #184)

resolves #184

Jenkins, test this please.

Jenkins, test this please.

Jenkins, test this please.


Refactor to reuse java.util.regex.Pattern

String.replaceAll () compiles the regular expression each time it is called.
   public String replaceAll(String regex, String replacement) {
        return Pattern.compile(regex).matcher(this).replaceAll(replacement);
    }

It is suggested in javadoc that it is efficient to reuse the pattern, so I modified it accordingly.

If a pattern is to be used multiple times, compiling it once and reusing it will be more efficient than invoking this method each time.

You are right.


Deprecated warning with nan v2.7.0 and Node.js 9.0.0

When a native module using nan v2.7.0 is installed with Node.js 9.0.0 there is a deprecated warning. For example, here's the warning shown when installing the epoll module:
pi@raspberrypi:~/epoll $ npm i epoll

><EMAIL_ADDRESS>install /home/pi/epoll/node_modules/epoll
> node-gyp rebuild

make: Entering directory '/home/pi/epoll/node_modules/epoll/build'
  CXX(target) Release/obj.target/epoll/src/epoll.o
In file included from ../../nan/nan.h:192:0,
                 from ../src/epoll.cc:15:
../../nan/nan_maybe_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’:
../../nan/nan_maybe_43_inl.h:112:73: warning: ‘v8::Maybe<bool> v8::Object::ForceSet(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated: Use CreateDataProperty / DefineOwnProperty [-Wdeprecated-declarations]
   return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
                                                                         ^
In file included from /home/pi/.node-gyp/9.0.0/include/node/v8.h:26:0,
                 from ../src/epoll.cc:11:
/home/pi/.node-gyp/9.0.0/include/node/v8.h:3115:29: note: declared here
                 Maybe<bool> ForceSet(Local<Context> context, Local<Value> key,
                             ^
/home/pi/.node-gyp/9.0.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
  SOLINK_MODULE(target) Release/obj.target/epoll.node
  COPY Release/epoll.node
make: Leaving directory '/home/pi/epoll/node_modules/epoll/build'
npm WARN saveError ENOENT: no such file or directory, open '/home/pi/epoll/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/home/pi/epoll/package.json'
npm WARN epoll No description
npm WARN epoll No repository field.
npm WARN epoll No README data
npm WARN epoll No license field.

+<EMAIL_ADDRESS>added 3 packages in 10.643s
pi@raspberrypi:~/epoll $

That is unfortunate. It was only a question of time. ForceSet has been on its way out in V8 for a long time, but if I remember correctly there is no proper alternative, so the fix is not straightforward, if at all possible. Neither CreateDataProperty not DefineOwnProperty offer the same semantics.

If I understand PR https://github.com/nodejs/nan/pull/708 correctly, the plan is leave Nan::ForceSet as it is, mark it as deprecated and introduce Nan::DefineOwnProperty.
V8 already has v8::Object::ForceSet marked as deprecated. This results in the deprecation warning shown in the above post irrespective of whether Nan::ForceSet is used by an addon or not.
So if I want to suppress the V8 deprecation warning for v8::Object::ForceSet I'll have to suppress it in my addon because NAN will not be suppressing it, is this correct?

@fivdi Yes, correct.

Still accounting for versions. Nan::ForceSet would be marked as deprecated regardless of Node version, but for Node 9 onwards, Nan::ForceSet would be an alias for Nan::DefineOwnProperty. That should not cause any undue warnings.
On November 4, 2017 8:31:17 AM GMT+02:00, Brian Cooke<EMAIL_ADDRESS>wrote:

If I understand PR https://github.com/nodejs/nan/pull/708 correctly,
the plan is leave Nan::ForceSet as it is, mark it as deprecated and
introduce Nan::DefineOwnProperty.
V8 already has v8::Object::ForceSet marked as deprecated. This results
in the deprecation warning shown in the above post irrespective of
whether Nan::ForceSet is used by an addon or not.
So if I want to suppress the V8 deprecation warning for
v8::Object::ForceSet I'll have to suppress it in my addon because NAN
will not be suppressing it, is this correct?

Fixed in master. New release coming soon.


corelib: int.modPow can produce wrong results for divisor greater than half-word

The inner loop of int.modPow contains the statements r = (r * b) % m; and b = (b * b) % m;.
The problem is truncation in the product. 0 ≤ b < m and likewise r, so the intermediate product requires twice as many bits as m. This means that the wrong result may be computed for 64-bit integers on the VM when m has > 31 bits. Compiled to JavaScript the wrong results can appear if m has more than 26 bits.
dart2js/ddc currently fail corelib_2/int_modulo_arith_test/modPow since some test values for m have more than 26 bits. (The VM passes because the test values have 31 or fewer bits.)
The implementation could be changed to make use of a special product-modulo operation, but it might be simpler to use the BigInt implementation when the divisor is larger than the 'half-word', or perhaps always.
The ddc/dart2js implementation should probably error on inputs outside the 'safe integer' range - such inputs have already been subject to rounding and the exponentiation will propagate the rounding errors and produce a meaningless result.
If we have the opportunity we should probably deprecate and remove int.modPow. The main use case is RSA with large values that require BigInts.

Example.  (M-1)**E mod M is either 1 (E even) or M-1 (E odd).
main() {
  demo(30000000001, 2,<PHONE_NUMBER>2);
  demo(30000000001, 3,<PHONE_NUMBER>2);
  demo(30000000001, 1000000,<PHONE_NUMBER>2);
}

demo(int a, int e, int m) {
  print('$a.modPow($e, $m)  =  ${a.modPow(e, m)}'
      '  vs  ${BigInt.from(a).modPow(BigInt.from(e), BigInt.from(m))}');
}

VM:
30000000001.modPow(2,<PHONE_NUMBER>2)  =<PHONE_NUMBER>9  vs  1
30000000001.modPow(3,<PHONE_NUMBER>2)  =<PHONE_NUMBER>  vs<PHONE_NUMBER>1
30000000001.modPow(1000000,<PHONE_NUMBER>2)  =  779511127  vs  1

dart2js:
30000000001.modPow(2,<PHONE_NUMBER>2)  =  43008  vs  1
30000000001.modPow(3,<PHONE_NUMBER>2)  =<PHONE_NUMBER>4  vs<PHONE_NUMBER>1
30000000001.modPow(1000000,<PHONE_NUMBER>2)  =<PHONE_NUMBER>4  vs  1

Fixed via 41d3971e833e3d70c18cebee033ee80f347cebbe


requests recording: don't dump all the headers

we don't really need all of them, how about just dumping these:

content-encoding - so that requests know how to decode the content
content-type - 'duh
date - so we know when did we get it and pygithub/requests may need it
last-modified - can be useful
server - for sake of being sure
status - 'duhhhhh

In case of Pagure, we are not saving any header -- we are using RequestResponse object which does not contain any header.
So we need to:

add headers to RequestResponse and filter the headers
filter the headers for Github


Make diff.sh executable

The file already has a shebang, this change makes it usable.

Fixed with https://github.com/yannbertrand/macos-defaults/commit/0a72105c7a2e03e7c2880c9e4cf55ab2956e104f. Thanks!


build: bump image-spec to v1.1.0-rc.3 and oras-go to v2.1.0

Closes #305

Codecov Report

Merging #306 (affc103) into main (06d04cc) will not change coverage.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   74.39%   74.39%
=======================================
  Files          23       23
  Lines        2175     2175
=======================================
  Hits         1618     1618
  Misses        439      439
  Partials      118      118

Impacted Files
Coverage Δ

registry/repository.go
49.35% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

Also, under "internal/" so external imports don't work yet.

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

Agree with  @sajayantony. This change is also supposed to be considered in Notation CLI.

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

This is partially addressed by #308. We might need more discussions on the warning and it can be done in another PR.


modal-workflow - block additional opens & add trigger focus management

Overview

ensure that when the modal opens it keeps track of the element that triggered it
disable that element so that it cannot accidentally be clicked twice
re-enable the element when closing modal and then move focus back to the trigger when closed

Notes

added code to remove the modal from DOM when closed (existing behaviour was to just call the modal's hide function and it would still be in DOM, however it seems better to remove it fully unless I am missing something)
a reminder that there is still a short delay between pressing the button and the modal showing (as discussed on #5338 ), this PR does not address this but does consider this scenario, focus can remain on a disabled button and the focus will be allowed as the button will be re-enabled in the step before the actual modal is fully removed from DOM so that there should not be a visible delay to re-enabling it.
fixes #4006 + partial work towards #5338

Recording

See recording, on Slow 3G network throttling.

https://user-images.githubusercontent.com/1396140/135741248-80475d2f-beb7-4fbd-933d-9899428b1f86.mp4
Checks

Do the tests still pass? 👍
Does the code comply with the style guide? 👍
For front-end changes, checked Firefox 92, Chrome 94, Safari 14 on MacOS Big Sur
Tested keyboard control using the above browsers, tabbing through to multiple modal chooser activations (draftail, workflow chooser, snippet chooser, page chooser) then pressing enter or space or 'esc' while in the modal to confirm the focus moves back to the trigger button.
For new features: Has the documentation been updated accordingly? N/A

Rebased on main


bosh vms --dns return two dns name for a vm

I am using bosh-init,bosh-257.9.tgz and cf-233 .Stemcell 3262.2
DNS host name is not resolving while deploying cloud foundry.On exploring I get two entry for cloud controller and other vm in powerdns db postgres.
95a07d80-3fb8-40db-8a13-3c295755b066.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh
0.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh
In horizone
95a07d80-3fb8-40db-8a13-3c295755b066 is not VM instance ID ,but it is present in metdata section of
of the VM
NAME cloud_controller/95a07d80-3fb8-40db-8a13-3c295755b066
DEPLOYMENT cf-installer-team-test
ID 95a07d80-3fb8-40db-8a13-3c295755b066

These two host name is not pingable in director and in respective VM as well.
0.consul.ccc-bosh-net.cf-installer-team-test.microbosh
0.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh
bosh vms --dns
| cloud_controller/0              | starting | large                             | <IP_ADDRESS> | 95a07d80-3fb8-40db-8a13-3c295755b066.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh |
|                                 |          |                                   |             | 0.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh                                    |
| consul/0                        | running  | small                             | <IP_ADDRESS> | 48d2b0a4-8533-4b7d-a3c5-b11ab463e910.consul.ccc-bosh-net.cf-installer-team-test.microbosh           |
|                                 |          |                                   |             | 0.consul.ccc-bosh-net.cf-installer-team-test.microbosh
powerdns entry in postgres DB.
4 | 0.consul.ccc-bosh-net.cf-installer-team-test.microbosh                                              | A    | <IP_ADDRESS>
5 | 0.20.10.in-addr.arpa                                                                                | SOA  | localhost hostmaster@localhost 0 10800 604800 30
6 | 0.20.10.in-addr.arpa                                                                                | NS   | ns.microbosh
7 | <IP_ADDRESS>.in-addr.arpa                                                                            | PTR  | 0.consul.ccc-bosh-net.cf-installer-team-test.microbosh
8 | 48d2b0a4-8533-4b7d-a3c5-b11ab463e910.consul.ccc-bosh-net.cf-installer-team-test.microbosh           | A    | <IP_ADDRESS>
9 | <IP_ADDRESS>.in-addr.arpa                                                                            | PTR  | 48d2b0a4-8533-4b7d-a3c5-b11ab463e910.consul.ccc-bosh-net.cf-installer-team-test.mi
crobosh
**10 | 0.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh                                    | A    | <IP_ADDRESS>
11 | <IP_ADDRESS>.in-addr.arpa                                                                            | PTR  | 0.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh
12 | 95a07d80-3fb8-40db-8a13-3c295755b066.cloud-controller.ccc-bosh-net.cf-installer-team-test.microbosh | A    | <IP_ADDRESS>
13 | <IP_ADDRESS>.in-addr.arpa                                                                            | PTR  | 95a07d80-3fb8-40db-8a13-3c295755b066.cloud-controller.ccc-bosh-net.cf-installer-te**
am-test.microbosh
1 | microbosh                                                                                | SOA  | localhost hostmaster@localhost 0 10800 604800 30
2 | microbosh                                                                                | NS   | ns.microbosh
3 | ns.microbosh                                                                                | A    |

bosh-init.yml
`<%
load 'bosh-init/bosh-init.rb'
%>
name: <%= $os_tenant %>
releases:

name: bosh
url: '<%= $bosh_director_release_url %>'
sha1: <%= $bosh_director_sha %>
name: bosh-openstack-cpi
url: <%= $bosh_openstack_cpi %>
sha1: <%= $bosh_openstack_cpi_sha %>

resource_pools:

name: vms
network: private
stemcell:
url: <%= $stemcell_path %>
sha1: <%= $stemcell_sha1 %>
cloud_properties:
instance_type: <%= $bosh_flavor %>
#availability_zone: soltes2

disk_pools:

name: disks
disk_size: 20_000

networks:

name: private
type: manual
subnets:

range: <%= $cidr %> # <--- Replace with a private subnet CIDR
gateway: <%= $gateway_ip %> # <--- Replace with a private subnet's gateway
dns: [<IP_ADDRESS>] # <--- Replace with your DNS
cloud_properties: {net_id: <%= $net_id %>} # <--- # Replace with private network UUID

name: public
type: vip

jobs:

name: bosh
instances: 1
templates:

{name: powerdns, release: bosh}
{name: nats, release: bosh}
{name: postgres, release: bosh}
{name: blobstore, release: bosh}
{name: director, release: bosh}
{name: health_monitor, release: bosh}
{name: registry, release: bosh}
{name: openstack_cpi, release: bosh-openstack-cpi}

resource_pool: vms
persistent_disk_pool: disks
networks:

name: private
static_ips: [<%= $bosh_director_ip %>] # <--- Replace with a private IP
default: [dns, gateway]

properties:
nats:
address: <IP_ADDRESS>
user: nats
password: nats-password
postgres: &db
listen_address: <IP_ADDRESS>
host: <IP_ADDRESS>
user: postgres
password: postgres-password
database: bosh
adapter: postgres
registry:
address: <%= $bosh_director_ip %> # <--- Replace with a private IP
host: <%= $bosh_director_ip %> # <--- Replace with a private IP
db: *db
http: {user: admin, password: admin, port: 25777}
username: admin
password: admin
port: 25777
blobstore:
address: <%= $bosh_director_ip %> # <--- Replace with a private IP
port: 25250
provider: dav
director: {user: director, password: director-password}
agent: {user: agent, password: agent-password}
director:
address: <IP_ADDRESS>
name: my-bosh
db: *db
cpi_job: openstack_cpi
max_threads: 3
user_management:
provider: local
local:
users:
- {name: <%= $bosh_username %>, password: <%= $bosh_password %>}
- {name: hm, password: hm-password}
hm:
director_account: {user: hm, password: hm-password}
resurrector_enabled: true
dns:
address: "<IP_ADDRESS>"
domain_name: "microbosh"
db: *db
openstack: &openstack
auth_url: "<%= $os_auth_url%>" # <--- Replace with OpenStack Identity API endpoint
project: iwan-soltest # <--- Replace with OpenStack project name
domain: VMS # <--- Replace with OpenStack domain name
username: "<%= $os_username %>" # <--- Replace with OpenStack username
api_key: "<%= $os_password %>" # <--- Replace with OpenStack password
tenant:  "<%= $os_tenant%>"
default_key_name: <%= $key_name %>
default_security_groups: [vms-security-group]
ignore_server_availability_zone: true
agent: {mbus: "nats://nats:nats-password@<%=$bosh_director_ip %>:4222"} # <--- Replace with a private IP
ntp: &ntp [0.pool.ntp.org, 1.pool.ntp.org]

cloud_provider:
template: {name: openstack_cpi, release: bosh-openstack-cpi}
ssh_tunnel:
host: <%=$bosh_director_ip %> # <--- Replace with a floating IP
port: 22
user: vcap
private_key: <%= $key_file %> # Path relative to this manifest file
mbus: "https://mbus:mbus-password@<%=$bosh_director_ip %>:6868" # <--- Replace with a floating IP
properties:
openstack: *openstack
agent: {mbus: "https://mbus:mbus-password@<IP_ADDRESS>:6868"}
blobstore: {provider: local, path: /var/vcap/micro_bosh/data/cache}
ntp: *ntp
`

Closing in favor of https://github.com/cloudfoundry/bosh/issues/1439 - bosh-init is used to start the director running, so this seems like a bosh or configuration issue instead.


fix JSONPath inconsistencies

@JyotinderSingh.
Sorry for the delay. I was busy with something urgent at work and couldn't give enough time.
Have a look at this PR. It's not completed yet but good portion of it is completed. Unfortunately, I am unable to find how to enable the resp3 protocol.
Also, in the Data Link shared the multi path examples seems incorrect in the array example.
Currently, I am testing it on my end but since certain parts such as RESP3 and custom formats are pending I am not asking for a merge yet.
I wanted to also open up a discussion on certain outputs that Redis returns such as for example "accessing negative index on out of bounds for an arrray example", etc.
Should we be following that as I believe we should instead return error for such cases instead of nil or the way redis handles.
Fixes #1002

We're not looking to support RESP3 at this stage. Let's stick with RESP2.
Is RESP3 support a blocker in any way?

Nope, definitely not a blocker.

Nope, definitely not a blocker.

In that case we can remove the related code and limit this PR to just the jsonpath changes.

Looks like the tests and linter are failing, could you please take a look? Also, is this PR ready for review?

Looks like the tests and linter are failing, could you please take a look? Also, is this PR ready for review?

Hi Yes,
Apologies, I was traveling the entire week so couldn't push.
I have pushed the latest changes. Test cases required changes in output structure mainly. I ran linter on my local before pushing it through some warnings and error at other parts of the code. I am not sure why it didn't caught attention earlier. Currently, GitHub actions is seeking approval

Looks like the tests and linter are failing, could you please take a look? Also, is this PR ready for review?

Hi Yes,
Apologies, I was traveling the entire week so couldn't push.
I have pushed the latest changes. Test cases required changes in output structure mainly. I ran linter on my local before pushing it through some warnings and error at other parts of the code. I am not sure why it didn't caught attention earlier. Currently, GitHub actions is seeking approval

Thanks for the update!
I've started the CI for this change.

Looks like there are some test failure, could you please take a look.

Looks like there are some test failure, could you please take a look.

There are two test cases failing:

JSON.MGET in resp: This issue likely stems from a mismatch in the output interface, which occurred during migration. Since my code doesn't directly impact the MGET test cases, I believe the failure is related to the migration process rather than any recent changes in the code.

JSON.GET for UnsupportedJSONPathOperations (including regex): Previously, regex was not supported in the JSONPath operations, but now it is. I have updated the test cases to reflect this change. However, another issue arises from the parsing logic in the ParseCommand function, which is located in the parsecommand.go file. The function currently only considers double quotes to determine if subsequent characters belong to the same path. In earlier test cases, single quotes were used, causing the parser to incorrectly treat them as separate paths. I have updated the test cases to use double quotes, but we need to improve the handling of quotes in the ParseCommand function to avoid similar issues in the future.

@N3XT14 any updates on this? Please let us know if any help required on this.


Integration tests are not working

Win10
Unity 2018.2.0f2
Zenject 7.1.0
Doing it by guide

you can add an integration test for it by right clicking somewhere in the Project tab and then selecting Create -> Zenject -> Integration Test and then naming it SpaceShipTests.cs. This will create the following template code with everything you need to start writing your test:

Creating UntitledIntegrationTest.cs in Assets/Scripts leads to

Assets/Scripts/UntitledIntegrationTest.cs(5,40): error CS0246: The type or namespace name `ZenjectIntegrationTestFixture' could not be found. Are you missing an assembly reference?

Assets/Scripts/UntitledIntegrationTest.cs(3,19): error CS0234: The type or namespace name TestTools' does not exist in the namespace UnityEngine'. Are you missing an assembly reference?

Putting it under Assets/Scripts/Editor does not help(nor should it as far as I understand, since it's an integration test)
Copying TestFramework from Plugins into the Scripts helped to move a little forward, but opened yet another can of worms so I felt like this is not intended way in the first place.
Am I missing something?
Just for the record, had no problems with unit tests.

I think this is happening for you because in 2018 Unity added asmdef files and the new version of zenject includes these.  So what you can do is, in the directory where you have your integration tests, add an asmdef file and add Zenject-TestFramework as a dependency.  I'll add more documentation for this as well since you're right that the way the docs are written suggests that it should be easier

Thanks for the tip, I went into reading about asmdef files to update my knowledge, then tried proposed solution. I created an Assembly Definition, added Zenject-TestFramework in references. That allows integration test to find a ZenjectIntegrationTestFixture dependency, but it looses "UnityEngine.TestTools" namespace. Also tried:

Assembly Definition + references Zenject-TestFramework and Zenject-TestFramework-Editor(any platform)
Assembly Definition 1 + reference Zenject-TestFramework(any platform exluding editor), Assembly Definition 2 + reference Zenject-TestFramework-Editor(editor platform only)

Also, from what I understand about asmdef files they are meant to get rid of special folders, yet it still feels kind of clunky. I may be misunderstanding something, but having a step-by-step guide in documentation would be awesome.

  Since you are using nunit.  You could also just delete all the asmdef files in the zenject folder and then execute 'enable playmode tests for all assemblies' from test runner.
I agree, they still feel pretty clunky, so maybe it was a bit premature to enable them in zenject in retrospect.  Since now everyone has to use them if they are also using Zenject

I'll add some information about it to the docs

Thanks, tried first test assemblies proposal and it worked! A small Unity 2018 step-by-step from me for anyone who gets lost on this one

Create -> Assembly Definition, for ex. under /Scripts/Tests/ (no need to have a special folder)
"References": Zenject-TestFramework
"Test Assemblies": Checked
Create -> Zenject -> Integration Test, should be under the same folder as asmdef file
Window -> General -> Test Runner -> PlayMode tab
Created test from step 2 should be visible under created asmdef from step 1, happy testing

No problem, glad you got it working.  I'll leave this open to add documentation for it

Celebration did not last long. As soon as I've tried to bring back my real world tests, things fell apart.
Adding
using Assert = ModestTree.Assert;
was enough to see that ModestTree is not getting found. When I've tried my own namespaces they were not getting found too. Shooting in the dark, I feel like folder with asmdef file gets pulled into an early build, like Assets/Plugins folder, and that makes it impossible to reference anything from Assets/Scripts

Yeah, maybe you should just delete all the asmdef files in Zenject and then "enable playmode tests" from the test runner?  Then it should work just like before.
When you change to use asmdef files I think you have to really commit to doing it everywhere

Or if you wanted to keep using asmdef files, you'd have to add a reference to the Zenject asmdef in addition to the test framework asmdef

When you change to use asmdef files I think you have to really commit to doing it everywhere

Exactly, I have to wrap all my code into assemblies and be ready to commit myself to a new approach.
I believe Unity meant good with it, but I'm yet to see any significant merits to this. Maybe next time.

Yeah, maybe you should just delete all the asmdef files in Zenject and then "enable playmode tests" from the test runner? Then it should work just like before.

This is good enough for my current situation

Hmm. I had to move both ZenjectIntegrationTestFixture and ZenjectSceneTestFixture from Zenject/OptionalExtras/TestFramework to Zenject/OptionalExtras/TestFramework/Editor to be next to ZenjectUnitTestFixture.cs (to remove those above mentioned errors). This has now allowed the other error I was seeing with the asmdef files:
'SubContainerCreatorByInstaller' does not contain a constructor that takes 2 arguments being thrown in SubContainerInstallerBindingFinalizer.cs on line 38

I feel I must have done some part of the installation incorrectly. No one else seems to have had issues with where files were located for example. Though I can't think what that could be. I installed Zenject from the asset store. I then wanted to unzip the automocking. So I've unzipped that directly into Zenject/OptionalExtras/TestFramework/Editor as mentioned in the Readme. This includes the contents of the Moq zip also. Is that correct?

What version of zenject / unity?
I just tried doing this and it worked:

Installed zenject version 7.2.0 with Unity 2018.2.4f1
Opened test runner
Clicked PlayMode
Clicked Create PlayMode Test Folder
Inside the folder, click on Tests.amsdef
Add Zenject-TestFramework to references
Inside that folder, right click -> Create -> Zenject -> Integration Test

Run playmode tests without issue

I think it's possible I had parts of two versions (7.1 and 7.2)
I just tried deleting Zenject completely
I checked that the import showed everything as new to be sure I hadn't missed anything.
Re-imported. Re-unzipped automock zip and moq lib.
Added the references to test.asmdef
no errors. I'm not sure exactly what I did wrong, but I appreciate your patience. I look forward to writing some tests now!

Np.  I added more explanation of these steps in the docs page now to avoid more confusion for others.


Is it possible to disable the right sidebar, on a per-org basis?

Is there a way to disable the sidebar so we don't get info about who is online or not?
My research group is interested in moving away from Basecamp to a chat solution that's less oriented around project management, but a big thing that we're squeamish about is any expectation of real-time answers. I've found related issues for optionally hiding it (https://github.com/zulip/zulip/issues/558) and restricting visibility (https://github.com/zulip/zulip/issues/16808), but neither of those is quite what I'm looking for.
Alternatively, is there a way to set yourself to "invisible" in a way that it identical to as if you were offline? (It seems like setting yourself to "unavailable" still has a different icon from "offline")

Answering my own "alternate" question, I just found that this is possible in "Settings -> Notifications -> Presence", rather than being available in the pop up where I'd go to set a status message.

@lauralindzey thanks for the thoughtful question!  To some extent that is a social expectation, but Zulip's core design goal is to make asynchronous conversation work great, and to reduce the inherit pressure for immediate replies that comes with chat tools that are a bad experience unless you talk synchronously.  I think if you talk to folks who use Zulip, they absolutely don't expect real-time answers.  E.g. I personally love to hide Zulip and focus on something for hours or days and then reply to all the conversations when I'm back.
I'd expect the experience to be slightly worse with presence disabled, just because it is handy to know if which other folks are around and possibly open to having an interactive conversation, but you can certainly do it.
The setting you identified is what we had in mind for folks who want to hide their presence state, though it seems worth including it in the status dialog, perhaps as an "invisible" option to make this privacy setting more discoverable (though we're also moving it to be no longer weirdly hidden in "notification settings").  @alya FYI for that thought.

Ah, yeah, good idea! I'll write up an issue for adding a control for that privacy setting to the profile menu.
Separately, we have heard from an org that chooses to turn off the buddy list for guest users (they run Zulip on-premise, so they just added a small patch to hide it). If we were going to implement this, we should allow orgs to control the setting by user type.

If you're working on improving this functionality, one thing that just threw me for a loop is that even after I've disabled sharing my presence status, in my view of the users menu, my circle is still green (I've confirmed with a colleague that for them, I show up as offline). I can guess why it would work like this from an implementation level, but from the user experience side I had expected the status I saw to reflect what others would see, as it does when you set yourself to unavailable.

Thanks for the report @lauralindzey ! What you describe is definitely a bug -- I filed #18846 to track it separately.

I am also exploring adopting zulip for communication with consulting clients. I would be interested in being able to toggle off users seeing those who don't share a stream with them.
For self patching it seems like it would be a very simple css addition. .right-sidebar-container{display:none;}. This could just be added to a css file in the static/styles/ directory issuing some command to rebuild?

All the features suggested in this issue have been implemented via the linked issues, closing.


feature: update for Godot 3.3-stable

Update to support changes in Godot 3.3. Mostly, this involves updating Thread (modernized to use start instead of create) and atomic_increment (now SafeNumeric<T>). Also removed c++11 flag from SCsub, as Godot now uses features from newer editions of C++ (std::shared_timed_mutex).
While in the code, I fixed a few typos that I found:
partern/parttern => pattern
applay => apply
DECLAR_ => DECLARE_
DECLEARATION => DECLARATION

Thanks!


Fix Netlify managed redirects

The _redirects file needs to be built for both the standard and managed
docs. I think.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3649a981eaa0162d81d8fbc45d112ef9dff3366a/

LGTM, at least in the TeamCity build on s3, though I don't understand this change.
@mjibson, can you chime in? The problem is that, on the live site, the docs at /docs/managed/ are only available when you use the explicit v2.1 in the url (/docs/managed/v2.1/). The stable alias doesn't work (/docs/managed/stable). Here are examples:
https://www.cockroachlabs.com/docs/managed/stable/
https://www.cockroachlabs.com/docs/managed/v2.1/

Ok, so here's the explanation. Version aliases are kinda tricky, because you want to totally duplicate the content under a different name. Jekyll is slow enough that generating every page twice is prohibitively slow. So when I initially set up versioning, I used symlinks. "stable" is a symlink for v2.0, "dev" is a symlink for v2.1, and so on. No copies necessary; Jekyll literally runs e.g. ln -s v2.1 dev when it generates the site.
This worked out really nicely, because jekyll serve does the right thing with symlinks, as does GitHub pages. Netlify, sadly, doesn't handle symlinks. Luckily, it supports a _redirects file, which can accomplish the same thing. In addition to writing the symlink, to support local servers, we teach Netlfiy about the symlink by adding a line to the _redirects file that looks like this:
/docs/stable /docs/v2.1 200

The standard build needs to output a _redirects file like the above, while the managed build needs to output a redirects file with a /managed prefix:
/docs/managed/stable /docs/managed/v2.1 200

Naturally, when I converted the Python scripts to Jekyll plugins, I overlooked this, and since the _redirects file didn't specify build_for it wasn't getting built for the managed docs, and so Netlify didn't know about the redirects.

Thanks for the write-up, @benesch.

LGTM


Fix indents in Viva Connections app bar in Teams

It looks really uncomfortable and too heap to use. Give more space.

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


docs: Add GitHub Desktop Contribution Instructions

what's wrong with the documentation?
I am interested in contributing to the project by adding detailed instructions on how to contribute using GitHub Desktop.
I believe that by providing clear and comprehensive guidance, we can encourage more contributors to participate in the project, especially those who prefer using GitHub Desktop for their contributions.
Could you please assign me the issue related to adding GitHub Desktop contribution instructions under gssoc24? I am excited about the opportunity to contribute to the project and help streamline the contribution process for others.
Add screenshots

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

I am willing to work on this issue, kindly assign this issue to me under GSSOC'24

I want to work on this issue under GSSOC'24
please assign me this issue


Copyediting of documentation

Enhancement proposal
As I look through the docs, I'll make a list here of pages that could do with some copyediting. Most of these pages are relatively well-written and only need some minor corrections. I think it'll be a good task for new contributors who are proficient with English.

[ ] installation/win
[ ] installation/troubleshooting
[ ] installation/for_dev Last section seems incomplete
[ ] installation/plugins Some commas can be semicolons
[ ] tutorials/building_blocks "Mobjects are the basic building blocks; probably other minor issues as well
[ ] tutorials/configuration Some awkward phrasing
[ ] contributing/development One flake8 word isn't formatted correctly
[ ] contributing/internationalization I copyedited this once as part of my review, but it could still do with another pass.

This is by no means an exhaustive list. Hopefully this helps new contributors with a keen eye for grammar and style find some ideas for ways to contribute.
Additional comments
I was going to make a more exhaustive list, but I realized that almost every page in the documentation would be listed here if I were nitpicky enough.

I can spend some time working on this.

Reopening because it was far too broad to have been solved by that single PR. Besides, there are many new files that need some checking.

Numberline docs

size (font) – The size of the label mobjects. Defaults to 36.
Replace size (font) with font_size. Numberline doesn't have size attribute.

Hey, im new to open source and think this would be a good starting place for me. I noticed some simple errors within "tutorials/configuration" that I should be able to help fix.