[cpr] fatal error: 'cpr/cpr.h' file not found

Host Environment

OS: MacOS (Darwin-20.4.0)
Compiler: clang  <IP_ADDRESS>50022
CMake: 3.22.3

To Reproduce
Clone the vcpkg repo master branch.
Install the cpr package: ./vcpkg install cpr
In the CMakeList.txt add the cpr dependency:
find_package(CPR REQUIRED)

target_link_libraries(app PRIVATE cpr::cpr)

Include the cpr header in the C++ source:
#include <cpr/cpr.h>

Failure logs
fatal error: 'cpr/cpr.h' file not found
#include <cpr/cpr.h>
         ^~~~~~~~~~~
1 error generated.

Additional context
I think find_package(CPR REQUIRED) should generate these variables:
CPR_INCLUDE_DIRS
CPR_LIBRARIES
In the CMakeList.txt the CPR_INCLUDE_DIRS should add to the target's include directories with target_include_directories and CPR_LIBRARIES to the linked libraries with target_link_libraries.
I print all CMAKE variables after the find_package(CPR REQUIRED) and I found these:
CPR_INCLUDE_DIR: CPR_INCLUDE_DIR-NOTFOUND
CPR_LIBRARY: /Users/user/git/vcpkg/installed/x64-osx/debug/lib/libcpr.a

I found that it seems that for CURL (a dependecy of CPR) these variables are generated correctly:
CURL_INCLUDE_DIRS=/Users/user/git/vcpkg/installed/x64-osx/include
CURL_LIBRARIES=optimized;/Users/user/git/vcpkg/installed/x64-osx/lib/libcurl.a;debug;/Users/user/git/vcpkg/installed/x64-osx/debug/lib/libcurl-d.a;-framework SystemConfiguration;-framework Security;-framework CoreFoundation;ZLIB::ZLIB

Thanks for posting this issue. Could you change find_package(CPR REQUIRED) to find_package(cpr CONFIG REQUIRED)? I cannot reproduce this issue locally. The cprTargets.cmake provide the include path of cpr:
set_target_properties(cpr::cpr PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "CURL::libcurl"
)

Have you created an FindCPR.cmake file on your machine, if yes, find_package(CPR REQUIRED) will use module mode and do not use cprConfig.cmake provided by vcpkg.

I don't have FindCPR.cmake file. If I use find_package(cpr CONFIG REQUIRED) I got the same error.
I can find these variables in this case:
CPR_DIR=/Users/user/git/vcpkg/installed/x64-osx/share/cpr
CPR_INCLUDE_DIR=CPR_INCLUDE_DIR-NOTFOUND
CPR_LIBRARY=/Users/user/git/vcpkg/installed/x64-osx/debug/lib/libcpr.a

In the INTERFACE_INCLUDE_DIRECTORIES case, how can I add the include directories? target_include_directories(app cpr::cpr) doesn't work for me?
Can you please share with me your local CMakeList.txt file?

My local CMakeList.txt:
cmake_minimum_required (VERSION 3.9)

project (testcpr C CXX)

add_executable(testcpr main.cpp)

find_package(cpr CONFIG REQUIRED)
target_link_libraries(testcpr PRIVATE cpr::cpr)

Configure log:
-- The C compiler identification is AppleClang <IP_ADDRESS>50022
-- The CXX compiler identification is AppleClang <IP_ADDRESS>50022
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ZLIB: /Users/vcpkg/lily/vcpkg/installed/x64-osx/lib/libz.a (found suitable version "1.2.12", minimum required is "1")
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/vcpkg/lily/vcpkg/testcpr

Make log:
[ 50%] Building CXX object CMakeFiles/testcpr.dir/main.cpp.o
In file included from /Users/vcpkg/lily/vcpkg/testcpr/main.cpp:1:
In file included from /Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/cpr.h:4:
In file included from /Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/api.h:10:
In file included from /Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/async.h:5:
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:18:1: error: unknown type name 'constexpr'
constexpr size_t CPR_DEFAULT_THREAD_POOL_MIN_THREAD_NUM  = 1;
^
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:18:17: error: expected ';' after top level declarator
constexpr size_t CPR_DEFAULT_THREAD_POOL_MIN_THREAD_NUM  = 1;
                ^
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:19:1: error: unknown type name 'constexpr'
constexpr std::chrono::milliseconds CPR_DEFAULT_THREAD_POOL_MAX_IDLE_TIME{60000};
^
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:19:36: error: expected ';' after top level declarator
constexpr std::chrono::milliseconds CPR_DEFAULT_THREAD_POOL_MAX_IDLE_TIME{60000};
                                   ^
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:68:5: error: 'auto' not allowed in function return type
    auto Submit(Fn&& fn, Args&&... args) -> std::future<decltype(fn(args...))> {
    ^~~~
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:68:41: error: expected ';' at end of declaration list
    auto Submit(Fn&& fn, Args&&... args) -> std::future<decltype(fn(args...))> {
                                        ^
/Users/vcpkg/lily/vcpkg/installed/x64-osx/include/cpr/threadpool.h:27:38: error: use of undeclared identifier 'CPR_DEFAULT_THREAD_POOL_MIN_THREAD_NUM'
    ThreadPool( size_t min_threads = CPR_DEFAULT_THREAD_POOL_MIN_THREAD_NUM,

There are some errors but no fatal error: 'cpr/cpr.h' file not found.

Thanks, @LilyWangLL,
What is missing from your cmake to compile it correctly is:
set(CMAKE_CXX_STANDARD 17)
I'm using googletests in my project too. If I create a new empty project with just cpr it's working. Maybe there is a misconfiguration on my side. I'll dig into it.


Make comments box the same width as article text

This PR ensures that the Giscus comments box matches the width of the page content.  I think it looks much tidier:
Currently:

With this PR:

Interested to know what you think!

Please could we have this merged?


Issue in date picker and display date in service page

Describe the bug

Date format in setting: Saturday, 01 January 2022
While saving date date displayed invalid date
After edit date picker not working correctly

Screenshots
If applicable, add screenshots to help explain your problem.

recheck
remove all dudate. create new


Deprecated in favor of a new slider/range input?

Hey there,
If this component is deprecated, has it been replaced in production with anything new? This component looks nicely written, but I'll need to maintain the feature I build for the foreseeable future.
Is there an actively-maintained open-source equivalent someone can point me to?

FYI there another slider : https://github.com/whoisandie/react-rangeslider


Command names non case sensitive

from https://github.com/Einabit/client.java/issues/15
In my opinion, it would be nice that command names would be noncase-sensitive, it's something very likely to be mistyped and hard to debug since the server does not really give you a descriptive error.

IMO to me adding a debug flag will solve this issue

a debug flag for the sandbox that will enable verbose information


Timber with WPML

Hi,
I was trying to do an if statement but not sure how I can integrate it
I'm using WPML with Gantry5
Here's the code I tried with no avail:
{% if ICL_LANGUAGE_CODE == 'en %}
English
{% elseif ICL_LANGUAGE_CODE  == 'th' %}
Thailand
{% endif %}

Hi @chaladm
There are a couple of things:
There is a syntax error on the first line, ICL_LANGUAGE_CODE == 'en should be ICL_LANGUAGE_CODE == 'en'
And secondly, can you make sure {{ dump(ICL_LANGUAGE_CODE) }} actually returns what you expect

it's not dumping anything
I think it's can't recognize ICL_LANGUAGE_CODE
any idea?

Honestly, I haven't used WPML to any extent so I wouldn't be able to advise sorry, I think the best bet is to ask on our Gitter or even better post a question on our stack overflow:
http://stackoverflow.com/questions/tagged/timber
Sorry can't help any further!

thanks connor. Will keep this open and also post on stackoverflow


[stable/efs-provisioner] Upgrade EFS provisioner

Signed-off-by: Alex Snast<EMAIL_ADDRESS>What this PR does / why we need it:
Update efs provisioner version to latest
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

@srueg, what is this error? Doesn't look related to my changes, right?

/retest

/lgtm


Unknown Python Environment in codespace/devcontainer

Testing #23675

Go to github.com/codespaces
Pick Jupyter template
Switch Codespace to use VS Code Insiders
Switch Python to prerelease

2024-06-25 17:30:42.202 [info] Started Refreshing Environments
2024-06-25 17:30:42.202 [error] Invalid state, ex ("/usr/local/python/current/bin/python3") is not in any of /bin, /usr/bin, /usr/local/bin
2024-06-25 17:30:42.217 [warning] Unknown Env ("/usr/local/python/current/bin/python3") in Path resolved as ResolvedPythonEnv { executable: "/usr/local/python/current/bin/python3", prefix: "/usr/local/python/current", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.220 [info] Discovered env: /usr/local/python/current/bin/python3
2024-06-25 17:30:42.358 [warning] Unknown Env ("/home/codespace/.python/current/bin/python3") in Path resolved as ResolvedPythonEnv { executable: "/home/codespace/.python/current/bin/python3", prefix: "/home/codespace/.python/current", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.364 [info] Discovered env: /home/codespace/.python/current/bin/python3
2024-06-25 17:30:42.381 [error] Unable to find Conda Manager for the Conda env: CondaEnvironment { prefix: "/opt/conda", executable: Some("/opt/conda/bin/python"), version: Some("3.12.3"), conda_dir: None, arch: Some(X64) }
2024-06-25 17:30:42.382 [error] Unable to find Conda Manager for env: CondaEnvironment { prefix: "/opt/conda", executable: Some("/opt/conda/bin/python"), version: Some("3.12.3"), conda_dir: None, arch: Some(X64) }
2024-06-25 17:30:42.386 [error] Invalid state, ex ("/usr/local/python/current/bin/python") is not in any of /bin, /usr/bin, /usr/local/bin
2024-06-25 17:30:42.388 [warning] Unknown Env ("/usr/local/python/current/bin/python") in Path resolved as ResolvedPythonEnv { executable: "/usr/local/python/current/bin/python", prefix: "/usr/local/python/3.10.13", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.388 [info] Discovered env: /usr/local/python/current/bin/python
2024-06-25 17:30:42.808 [info] Discovered env: /opt/conda/bin/python
2024-06-25 17:30:42.824 [error] Invalid state, ex ("/home/codespace/.python/current/bin/python") is not in any of /bin, /usr/bin, /usr/local/bin
2024-06-25 17:30:42.826 [warning] Unknown Env ("/home/codespace/.python/current/bin/python") in Path resolved as ResolvedPythonEnv { executable: "/home/codespace/.python/current/bin/python", prefix: "/usr/local/python/3.10.13", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.827 [info] Discovered env: /home/codespace/.python/current/bin/python
2024-06-25 17:30:42.827 [error] Invalid state, ex ("/usr/local/python/current/bin/python3.10") is not in any of /bin, /usr/bin, /usr/local/bin
2024-06-25 17:30:42.828 [warning] Unknown Env ("/usr/local/python/current/bin/python3.10") in Path resolved as ResolvedPythonEnv { executable: "/usr/local/python/current/bin/python3.10", prefix: "/usr/local/python/current", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.828 [info] Discovered env: /usr/local/python/current/bin/python3.10
2024-06-25 17:30:42.828 [warning] Unknown Env ("/home/codespace/.python/current/bin/python3.10") in Path resolved as ResolvedPythonEnv { executable: "/home/codespace/.python/current/bin/python3.10", prefix: "/home/codespace/.python/current", version: "3.10.13.final.0", is64_bit: true, symlink: None } and reported as Unknown
2024-06-25 17:30:42.828 [info] Discovered env: /home/codespace/.python/current/bin/python3.10
2024-06-25 17:30:42.829 [info] Discovered env: /bin/python3
2024-06-25 17:30:42.829 [info] Locator VirtualEnvWrapper took 7.474µs
2024-06-25 17:30:42.830 [info] Locator LinuxGlobalPython took 340ns
2024-06-25 17:30:42.830 [info] Locator VirtualEnv took 271ns
2024-06-25 17:30:42.830 [info] Locator PipEnv took 160ns
2024-06-25 17:30:42.830 [info] Locator PyEnv took 1.479827ms
2024-06-25 17:30:42.830 [info] Locator Conda took 100.675839ms
2024-06-25 17:30:42.831 [info] Locator Venv took 150ns
2024-06-25 17:30:42.831 [info] Locator Poetry took 3.905787ms
2024-06-25 17:30:42.831 [info] Locator Homebrew took 832.338µs
2024-06-25 17:30:42.831 [info] Environments found using locators in 102.61904ms
2024-06-25 17:30:42.831 [info] Environments in PATH found in 590.153623ms
2024-06-25 17:30:42.831 [info] Environments in global virtual env paths found in 481.598µs
2024-06-25 17:30:43.241 [info] Environments in custom search paths found in 4.646347ms
2024-06-25 17:30:43.249 [info] Refresh completed in 590ms
2024-06-25 17:31:27.877 [info] Unknown Python Environment category 'global-paths' from Native Locator.
2024-06-25 17:31:27.880 [info] Unknown Python Environment category 'linux-global' from Native Locator.

what I got from the legacy locator

From WSL:
2024-06-25 10:45:32.156 [info] Starting Python Locator /home/milively/.vscode-server-insiders/extensions/ms-python.python-2024.9.2024062506-linux-x64/python-env-tools/bin/pet server
2024-06-25 10:45:32.156 [info] Started Refreshing Environments
2024-06-25 10:45:32.167 [info] Discovered env: /bin/python3
2024-06-25 10:45:32.235 [info] Locator Conda took 236.514147ms
2024-06-25 10:45:32.240 [info] Locator Venv took 1.155µs
2024-06-25 10:45:32.249 [info] Locator VirtualEnv took 27.768µs
2024-06-25 10:45:32.250 [info] Locator LinuxGlobalPython took 1.71µs
2024-06-25 10:45:32.251 [info] Locator PipEnv took 10.325µs
2024-06-25 10:45:32.251 [info] Locator VirtualEnvWrapper took 999ns
2024-06-25 10:45:32.252 [info] Locator Homebrew took 13.048232ms
2024-06-25 10:45:32.252 [info] Locator PyEnv took 361.67816ms
2024-06-25 10:45:32.253 [info] Locator Poetry took 342.617128ms
2024-06-25 10:45:32.254 [info] Environments found using locators in 362.14889ms
2024-06-25 10:45:32.254 [info] Environments in PATH found in 2.024988348s
2024-06-25 10:45:32.254 [info] Environments in global virtual env paths found in 4.323241ms
2024-06-25 10:45:32.257 [info] Environments in custom search paths found in 48.099382ms
2024-06-25 10:45:32.258 [info] Refresh completed in 2028ms

in the case of @Yoyokrazy Python extension today is displaying /bin/python3 and /usr/bin/python3, however they are the same.
Thats why the new locator will only list one of them.
@karthiknadig /cc (in fact the above is documented on a few websites as well, the only one that is specific to the user is /usr/local/bin/python3).

@karthiknadig @rebornix The only issue here is that Native Locator is reporting them as unknown
I'll need to have a look and see how and why the TS is reporting them as Global and update Native Locator accordingly.
Its probably in path.


Discussion: make 100% test coverage part of automated build checks?

A very high test coverage is a good idea, but I think that a 100% test coverage is a bad idea. There will be code that introduces almost no complexity. Do you want to test them?

Thanks for weighing in @piotr-kubica!
The main reason for me to aim for 100% test coverage is reducing the risk that merging a PR breaks something. Reducing that risk minimizes the overhead of reviewing the PR (if we think a new feature adds value to the library and doesn't break anything we can just merge it without the reviewer having to understand the new code completely) and also enables us to use a single branch git model where every PR is merged to master and will be included in the next release (the single branch model itself is also a method for reducing overhead for open source maintainers).
Although 100% test coverage doesn't ensure that nothing can fail, it does reduce the risk. Also, I think that a library like this is perfectly suited for high test coverage because most of the logic is in pure functions that are quite easy to unittest.
For me the only drawback in aiming for 100% test coverage is the time that's needed to create the unittests. And I think that's a small sacrifice to make.
What would be your arguments to avoid enforcing 100% test coverage?

It's a long topic I guess
https://stackoverflow.com/questions/1475520/unit-testing-code-coverage-do-you-have-100-coverage

Haha yes it is.
I think I'd like to try enforcing 100% coverage for a while to see how it goes but we should be reasonable about it: if it's too much of an effort, introduces other complexities or doesn't give us enough benefits we should step away from it quickly again.


[SR-14453] Removed unused option disable_llvm_slp_vectorizer.

Resolves SR-14453.

@varungandhi-apple please review

@swift-ci smoke test and merge


ANC - Health Center - Lab Results on Progress Report [6h]

Issue
To accommodate the changes made in the ANC flow at the Health Center level and to better integrate CHW's and Nurses, we have made some changes to the ANC progress report.
Shows the date the lab was run and the result. If a result is not yet submitted through case management, a label with "pending" should appear.
If a test is run multiple times, we need to show all historical results. (similar to how we did the acute illness history in the SPV progress report)
The lab results section of the progress report will be updated to look like this:

Design
General
The order was slightly rearranged. See full design on Figma [here] (https://www.figma.com/file/nKKYxDmnEPm7CiXSXO1pq7/E-Heza-2021?node-id=5862%3A38746)
To Do

Add Lab results section to progress report
Style per design

Clarifications

ON HOLD UNTIL WE ADDRESS ANC LOGIC The alert dots on the progress report
YES UPDATED DESIGNS COMING SOON If a test is run multiple times, do we need to show all historical results or the most recent? Could we do an arrow to see historical results for a specific test? This was suggested by Theo for all results previously but we wanted results in the report.

@LudmilaGoichman please test on Nutrition env

@anvmn @jeanette-pelizzon

Nutrition env
tab

Found Issues/Questions:

from https://github.com/TIP-Global-Health/eheza-app/issues/84#issuecomment-983751153:

yes, sorry the photos should be at the bottom.

But the photos are still displayed as part of the patient progress section. Example:

I'm not sure if I understand correctly which date should appear:

Shows the date the lab was run and the result.

the date when the measurements were taken for the test or when the test was processed in the laboratory (and the result was entered into the system). Currently it the first option the date when the measurements were taken for the test and I think it's correct
Example:

Checked and Approved
Lab results section has been added to progress report and styled per design.
Example: subsequent encounter. The report:

Shows the date the lab was run and the result.
If the result has not yet been submitted through the case management, a label with "Results pending" appears.
If the result has not yet been submitted through case management and more than 14 days have passed since the ANC encounter, a label with "Results missing" appears.
If the test is run multiple times, all historical results are shown

before test execution in current encounter
after text execution in current encounter

Photos can stay as they are
The date that the lab was run so it is accurate as it is now.
Labels can stay as they are.

This is good to go for team acceptance.
// @LudmilaGoichman @anvmn @adamhstewart


Add CodeAnalysis and StyleCop

Resolves #2

I know that, eventually, we want to use a shared .editorconfig that gets submoduled. For now, I'm just copy+pasting the one from RTCV (with a couple of rules added)

Fine by me.


Create footer

@AdamPrisen any progress on this?

hello, unfortunately, I haven't had time to get to this yet due to the fact that I had to finish my tasks for school, hopefully, I will have time this week.


1291/partners clean up

Issue

Closes #1291

Description
This PR addresses various different content updates described in #1291. Additionally, I removed any now unused strings from the JSON override files. Each of the changes are further described in the testing instructions below.
When running it local, start on Detroit Partner's portal.

Create a new listing
Add a unit group and verify that the Accessibility section has been removed from the drawer.
Scroll down to the 'Community Types' section and interact with it thoroughly to ensure that there is consistent use of the 'Community Types' over 'Community Programs'.
Scroll down to see 'Building Features' and ensure that there is text input labeled 'Additional Accessibility Details'
Navigate to the 'Application Process'
Verify that under the 'Leasing Agent Section', its first text input is titled 'Property Management Company'.
Scroll down further to see that 'Is there a referral opportunity?' and 'Additional Application Submission Notes' inputs have been removed.
Save Listing.
Ensure consistency on wording changes in Summary as well.

Then navigate to Public site:

Navigate to a listing with both Community Types and Additional Accessibility details added and click into the detailed view.
Ensure that the new wording of 'Additional Accessibility Details' and 'Community Types' is present in all languages.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[ ] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Thanks @emilyjablonski! I've updated the string locations for 'Additional Accessibility Details' and 'Community Types' along with updating the key name for Types for less confusion. While "leasingAgent.name" as a key for 'Property Management Company' is also misleading, I decided to wait on changing it since it was originally an override and doesn't have any translations.

@ColinBuyck , can you resolve the merge conflicts before merging.

@seanmalbert Yep, just did it! Also to be sure I'm understanding correctly, I'm good to merge this into dev now?


BugFix fix show backup with where clause

Proposed changes
fix issue to support:
1  show backup where SnapshotName="xxx";
2. show backup where SnapshotName like "%XXX%"
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[DOCFIX] Add todos for troubleshooting page

@aaudiber PTAL.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/456/
Test PASSed.


Setting up compute environment

Docker / Colima installations
Instructions per OS
VS Code, or another approach to running Jupyter
VS Code extensions

Put other points below

Peter Minogue's suggestion was to use conda. This can work, but on Windows I am not sure about the terminal experience.

@khiron I have started a wiki page for comp setup. Our essential requirements are that a users VS Code terminal connects to the VM so they can run commands. Similarly, that when they initiate Jupyter notebooks it is connecting to the VM.
I probably need to demo what's required so you can establish config.

I have a working document in /docker/README.md pending translation to the wiki
It includes how to do everything from VS Code (build/run/attach to container)
Also to build and run from the host OS and work with notebooks in the host OS's browser

README.md has been translated to the wiki.


Made it to directly animate the object itself

Now it directly animates the object itself rather than depending upon its .kv file

Test the modified implementation and let me know if it works as required


Upgrade to ibc-go v4.0.6

https://github.com/strangelove-ventures/noble/pull/212

Closing in favour of #232, where we upgrade directly to IBC v7.


YouTube Error Bang

Error

tinggal disable aja SSL sertificate nya, bisa taro di main.js paling atas
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";

Ok tq work dah bisa:) btw fitur jadi bit sama admin emang gabisa ya?
Pada tanggal Kam, 10 Feb 2022 07:43, ariffb @.***>
menulis:

tinggal disable aja SSL sertificate nya, bisa taro di main.js paling atas
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";
—
Reply to this email directly, view it on GitHub
https://github.com/ariffb25/stikerinbot/issues/299#issuecomment-1034362796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVJTFS5BQZ3WS6NFJ365JJTU2MC2NANCNFSM5N4LBXPA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Rebuild for python 3.13

Rebuild of https://github.com/conda-forge/dtc-package-feedstock/pull/7

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Handle multimappers correctly

A given read can map to multiple locations. It is important, however, that every read is counted only once. Also, the resulting alignments may sometimes be to the sense and other times to the antisense strand.
So to make sure these constraints are considered, it is necessary to collapse the outcomes of all the alignments of a given read into one outcome. Say, read 12345 aligns to 5 different locations in the RP transcripts. If all of the alignments do not require taking the reverse complement of the read (i.e., they are on the sense strand), you should count 1 towards "forward", not 5. If all of the alignments need to be reverser complemented, then you should count 1 towards "reverse", not 5. Now, if some of the alignments are "forward" and some of them are "reverse", I think it's best if you omit that read from the counting altogether, because the origin of that particular read cannot be safely established and thus the orientiation information from that read will also be insecure. Alternatively (especially if we don't get many reads aligning to the RP transcripts), you could assing fractions of counts to "forward" and "reverse": e.g., you had 4 alignments consistent with "foward" and 1 with "reverse", you could count 0.8 for "forward" and 0.2 for "reverse".

Implement with or after #73.


HADOOP-17596. ABFS: Change default Readahead Queue Depth from num(processors) to const

Contributed by Sumangala Patki.
(cherry picked from commit 76d92eb2a22c71b5fcde88a9b4d2faec81a1cb9f)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-3.3 Compile Tests _

-1 :x:
mvninstall
30m 30s
/branch-mvninstall-root.txt
root in branch-3.3 failed.

+1 :green_heart:
compile
0m 37s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 29s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 40s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 32s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m  3s

branch-3.3 passed

+1 :green_heart:
shadedclient
16m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed

+1 :green_heart:
spotbugs
1m  2s

the patch passed

+1 :green_heart:
shadedclient
15m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 56s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

73m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3106

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 9bd7642b85c1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / e888bb3e01e0695dd02f08986f478897f371414b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/1/testReport/

Max. process+thread count
617 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TEST RESULTS
HNS Account Location: East US 2
NonHNS Account Location: East US 2, Central US
HNS-OAuth

[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 556, Failures: 0, Errors: 0, Skipped: 98
[ERROR] Errors:
[ERROR]   ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:62->testReadWriteAndSeek:78 » TestTimedOut
[ERROR]   ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut
[ERROR] Tests run: 265, Failures: 0, Errors: 2, Skipped: 52

HNS-SharedKey

[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 556, Failures: 0, Errors: 0, Skipped: 54
[ERROR] Errors:
[ERROR]   ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:62->testReadWriteAndSeek:78 » TestTimedOut
[ERROR]   ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut
[ERROR]   ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut
[ERROR] Tests run: 265, Failures: 0, Errors: 3, Skipped: 40

NonHNS-SharedKey

[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 556, Failures: 0, Errors: 0, Skipped: 276
[ERROR] Errors:
[ERROR]   ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:62->testReadWriteAndSeek:78 » TestTimedOut
[ERROR]   ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut
[ERROR]   ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut
[ERROR] Tests run: 265, Failures: 0, Errors: 3, Skipped: 40

Existing JIRAs for tracking the timeout failures: AbstractContractDistCpTest, ITestAbfsReadWriteAndSeek

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
9m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-3.3 Compile Tests _

+1 :green_heart:
mvninstall
34m 58s

branch-3.3 passed

+1 :green_heart:
compile
0m 37s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 25s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 43s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 32s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m  2s

branch-3.3 passed

+1 :green_heart:
shadedclient
19m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed

+1 :green_heart:
spotbugs
1m 11s

the patch passed

+1 :green_heart:
shadedclient
19m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 59s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

94m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3106

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 74028626e844 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 5ab045b66cd2963304297930f4559c8be567ffef

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/2/testReport/

Max. process+thread count
513 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3106/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1


 The steps-certificate-and-profile-installer step fails with the following error:
Downloading & installing Provisioning Profile(s)
=> Downloading provisioning profile: 1/2
   Downloading () to (/var/folders/90/5stft2v13fb_m_gv3c8x9nwc0000gn/T/bitrise-cert-tmp858333992/profile-0.mobileprovision)
Get : unsupported protocol scheme ""
-> Retrying...
Get : unsupported protocol scheme ""
-> Retrying...
Get : unsupported protocol scheme ""
Download failed, err: Get : unsupported protocol scheme ""
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | certificate-and-profile-installer (exit code: 1)              | 16 sec   |
+---+---------------------------------------------------------------+----------+
| Issue tracker: .../bitrise-io/steps-certificate-and-profile-installer/issues |
| Source: ...s://github.com/bitrise-io/steps-certificate-and-profile-installer |
+---+---------------------------------------------------------------+----------+

Hi, thanks for the report we will check this issue asap!


Add missing dependency to local shell dockerfile

Signed-off-by: Ryan Beck-Buysse<EMAIL_ADDRESS>

Fixes the bug reported here: https://chat.hyperledger.org/channel/sawtooth?msg=E3LqqiGGvEMQrCZhs

also: https://jira.hyperledger.org/browse/STL-1499

A silent change is to change the keys from the stable branch to nightly. Would this still work after release? Could we install both keys. Something like what I do:
apt-key adv . . .--recv-keys 44FC67F19B2466EA 8AA7AF1F1091A5FD

@danintel this change brings this development dockerfile in line with the rest in the repository. Previously it was only installing non-sawtooth (cbor, colorlog, toml, etc...) dependencies from the /ci repository, but now that the python-sdk has been moved to its own repo, we need to install it from the published artifact.
We want core developers always using nightly published artifacts from the other repos so we can discover breaking changes prior to releases.


Code typos

Hi, John. As requested, I reviewed all the lab code. Please update the following:

In 04_test_coverage lab - Lines 170 and 262 - Please change "a" to "an"
From Mocking with Mock Objects Demo - Please correct spelling of "Bambi" in test fixture
From Practicing Test Driven Development Demo - Please correct spelling of "Dependencies" in requirements.txt
From Test Coverage Demo video - Please change "a" to "an" for Creates an account, Updates an account, Removes an account, Finds an account by its ID, and correct spelling of "represent"

@cbethl Made the updates. Thanks!


System tray icon default action

on macOS the system tray icon opens a droptdown with two options (show/quit ferdi)
it would be nice if a single click on the tray icon would show ferdi - now you need to click twice to show the app every time.
the desired behavior can for example be examined with the telegram desktop app on mac where a single click opens the app and a second click opens the menu. left and right clicks would also be fine :)

As suggested per @m-vlad, we could also:

Make the click on the tray icon minimize the app back.

So I suggest a simple click on the tray icon toggle the tray minimization, and right click shows the menu.

Quick update:

a simple click on the tray icon toggle the tray minimization, and right click shows the menu

Also moved the Windows-specific setting next to the other tray-related settings:

Will come up with a pull request by tomorrow!

Pull request reviewed by @vantezzen and merged; it will ship in the next release! 🎉 Thank you @flinguin @squatto and @m-vlad for the feedback!

Shipped in v5.4.4-beta.2.

It seems on Linux/X11 using this beta makes the systray icon be hidden for me. Can anyone confirm that?

@Mic92 Confirmed via https://github.com/getferdi/ferdi/issues/437.


Cannot handle Array types in Postgres

Describe the bug
When using postgres dialect, inserting a row with an Array SQL column type (e.g. text[]) does not generate the correct SQL. For the values corresponding to that column, it generates ($1, $2) where as postgres expects something of the form {$1, $2}.
To Reproduce
Create a table (SQL):
CREATE TABLE posts (
   title text NOT NULL PRIMARY KEY,
   tags  text[]
);

Construct InsertDataset (Go, goqu):
dialect := goqu.Dialect("postgres")
builder := dialect.Insert("posts").Cols("title", "tags").Vals(goqu.Vals{"New Post", []string{"a", "b"}})
query, _, _ := builder.ToSQL()
fmt.Println(query)

Query generated is:
INSERT INTO "posts" ("title", "tags") VALUES ( 'New Post', ('a', 'b'))

Running it in Postgres gives an error:
 column "tags" is of type text[] but expression is of type record

Expected behavior
I expect goqu to generate the below, which is expected by postgres.
INSERT INTO "posts" ("title", "tags") VALUES ( 'New Post', '{"a", "b"}')

Dialect:

[x] postgres
[ ] mysql
[ ] sqlite3

@teejays you should checkout https://godoc.org/github.com/lib/pq#Array which will handle properly formatting using the postgres array format.

@teejays you should checkout https://godoc.org/github.com/lib/pq#Array which will handle properly formatting using the postgres array format.

If I understand correctly, there is no way to use it with the Insert method provided by goqu. Native support for PostgreSQL arrays would be really useful.

I ran into the same problem but in a SELECT query, trying to use array contains in the WHERE clause, and was able to get around it by using goqu.L("(tags @> ?)", fmt.Sprintf("{%s, %s}", "tag1", "tag2"))

The solution I came up with was to use pq.Array(array) from "github.com/lib/pq".
dialect := goqu.Dialect("postgres")
builder := dialect.Insert("posts").
	Cols("title", "tags").
	Vals(goqu.Vals{
		"New Post",
		pq.Array([]string{"a", "b"}),
	})
query, _, _ := builder.ToSQL()
fmt.Println(query) // INSERT INTO "posts" ("title", "tags") VALUES ('New Post', '{"a","b"}');

@teejays you should checkout https://godoc.org/github.com/lib/pq#Array which will handle properly formatting using the postgres array format.

@doug-martin this this doesn't work when trying to insert structs via goqu.Insert("posts").Rows(myPosts), unless the fields on the object themselves are an array, but this means that we can't use type aliasing on our structs now

@steeling as per #137 here is a workaround you can use with structs containing slice fields:
https://gist.github.com/rgalanakis/a2d5b8b61ee9540981bb43a103bf59c7
// PGArrayExpr takes a slice of items and returns a literal expression
// with a Postgres array that can be used by goqu.
// It does this by using goqu natively and then manipulating the string
// to surround it in an array literal.
//
// To use this in a struct, you can do something like:
//
//     type MyModel struct {
//       Tags   []string        `json:"tags" db:"-"`
//       DbTags goqu.Expression `json:"-" db:"tags"`
//     }
//     body := `{"tags":["x", "y"]}`
//     m := MyModel{}
//     _ = json.Unmarshal([]byte(body), &m)
//     m.DbTags = goqux.PGArrayExpr(m.Tags)
//     sql, _, _ := goqu.Insert("modeltable").Rows(m).ToSQL()
func PGArrayExpr[T any](arr []T) goqu.Expression {
  if len(arr) == 0 {
    return goqu.L("'{}'")
  }
  lit := goqu.V(arr)
  selectSql, _, err := goqu.From(lit).ToSQL()
  if err != nil {
    panic(err)
  }
  valuesSql := strings.TrimPrefix(selectSql, "SELECT * FROM ")
  if valuesSql == selectSql {
    panic("expected go to output an (invalid) 'SELECT * FROM (x, y, z)' for the slice")
  }
  if valuesSql[0] != '(' || valuesSql[len(valuesSql)-1] != ')' {
    panic("expected goqu to output '(x, y, z)' but is missing parens")
  }
  arraySql := fmt.Sprintf("ARRAY[%s]", valuesSql[1:len(valuesSql)-1])
  return goqu.L(arraySql)
}

func ExamplePGArrayExprWithModel() {
	type MyModel struct {
		Tags   []string        `json:"tags" db:"-"`
		DbTags goqu.Expression `json:"-" db:"tags"`
	}
	body := `{"tags":["x", "y"]}`
	m := MyModel{}
	_ = json.Unmarshal([]byte(body), &m)
	m.DbTags = goqux.PGArrayExpr(m.Tags)
	sql, _, _ := goqu.Insert("modeltable").Rows(m).ToSQL()
	fmt.Println(sql)

	// Output:
	// INSERT INTO "modeltable" ("tags") VALUES (ARRAY['x', 'y'])
}

I am also scanning the inserted values into a struct, so I had to do an additional step.
With either the pq.Array solution or @rgalanakis's solution, both of which work great for inserting, I had to scan into a different struct than I inserted with. Using pq.Array, the Tags on insert would be the interface return value of pq.Array(), and on returning would be a pq.StringArray.
type MyModel struct {
    ID                        string         `db:"id"`
}

type MyModelToInsert struct {
    MyModel
    Tags          interface {
		driver.Valuer
		sql.Scanner
    } `db:"tags"`
}

type MyInsertedModel struct {
    MyModel
    Tags          pq.StringArray `db:"trigger_event_type"`
}

myModelToInsert := MyModelToInsert{
    ID: "some_id"
}
myModelToInsert.Tags = pq.Array([]string{"a", "b"})

var myInsertedModel MyInsertedModel

saved, err := txn.
		Insert(goqu.T("modeltable").
		Rows(myModelToInsert).
		Returning(goqu.T("modeltable").All()).
		Executor().
		ScanStructContext(ctx, &myInsertedModel)

...

fmt.Println(myInsertedModel.Tags)

// Output:
// [a b]

Nice solution! I ran into the same limitation after I posted my solution and did some more work (and needed to start scanning, not just inserting). I am using pgx and couldn't drop into sql directly so needed yet another solution for that, too, so I could only use goqu to get the SQL string. Ultimately what I ended with was:

Using a []string field
Using pgxscan.Select, which worked fine with the []string field.
Using goqu.Insert().Cols().Values(), rather than working with records/structs.
A custom routine to get the columns and values to insert, using reflection. It uses goqux.PGArrayExpr when it detects a slice.

If can try to clean up the code to post, but it's also probably not suitable for all use cases. Just wanted to mention that I didn't find a solution that didn't involve writing a significant amount of reflection shimming code to get this to work right.

I found a better solution by defining a new type that implements the driver.Valuer and sql.Scanner interfaces.
type Tag string

type MyTagsArray []Tag

func (m MyTagsArray) Value() (driver.Value, error) {
    // strings to bytes
}

func (m *MyTagsArray) Scan(src interface{}) error {
    switch src := src.(type) {
	case []byte:
		return t.scanBytes(src)
	case string:
		return t.scanBytes([]byte(src))
	case nil:
		*t = nil
		return nil
	}

	return fmt.Errorf("MyTags: cannot convert %T to MyTagsArray", src)
}

type MyModel struct {
    ID                        string            `db:"id"`
    Tags                      MyTagsArray       `db:"tags"`
}

This ends up being pretty much a straight copy of source from pq.StringArray, with the exception that the scanBytes method will reference the custom type instead of string.
...
b := make(MyTagsArray, len(elems))
		for i, v := range elems {
			if b[i] = Tag(v); v == nil {
				return fmt.Errorf("pq: parsing array element index %d: cannot convert nil to MyTagsArray", i)
			}
		}
		*a = b
...

However, it can be customized for your arrays of other types. As long as the Valuer and Scanner interfaces convert to and from your custom type and bytes, you can make it handle any custom slice type.

This also works:
type Tags []string

func (t Tags) Scan(src any) error {
	return pq.Array(t).Scan(src)
}

func (t Tags) Value() (driver.Value, error) {
	return pq.Array(t).Value()
}

Any thoughts about support []string for scanning / value?


[NeuralChat] Fix UT TestClient.client=None issue

Type of Change
bug fix
API not changed
Description
Fix request.client=None issue using async UT.
fastapi.TestClient.client was set to None in
link:

https://github.com/tiangolo/fastapi/discussions/11019
https://github.com/encode/starlette/pull/2525

Expected Behavior & Potential Risk
UT of test_photoai_api.py and test_askdoc_server.py will pass.
How has this PR been tested?
Local tested on SPR.
Dependency Change?
None

Coverage drop is due to code change but acceptable


Using the mysql-cdc 2.2, and using latest-offset mode during caused add newly table not to be capture.

Describe the bug(Please use English)
Using the mysql-cdc 2.2, and using latest-offset mode during caused newly table  not to be capture.
Environment :

Flink version :
Flink CDC version: 2.2
Database and version: MYSQL-5.7

To Reproduce
Steps to reproduce the behavior:

Thes test data :
The test code :
The error :

Additional Description

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


global tabs implementation

[ ]  home page link to data and library page
[ ] blog content body sub string split issue; html entities should be removed before sub string function
[ ] blogs list page; make link only in blog title or image; not the whole card item
[ ] issue in blog detail page; trying to fetch other blogs even if there isnt any
[ ] change blog detail end point to ‘../blogs/[blog-slug]’; same in news
[ ] Events list item card; date in large font is incorrect


Update URL of "Beelan LoRaWAN"

Companion to https://github.com/arduino/library-registry/pull/1631

2022/08/03 15:29:18 Loaded 5057 libraries from DB
Changing URL of library Beelan LoRaWAN from https://github.com/BeelanMX/arduino-LoRaWAN.git to https://github.com/ElectronicCats/Beelan-LoRaWAN.git
Success!

Done


chore(crypto): define testnet HRPs

Description
This PR adds testnet flag for import and export address using private key.
Related issue(s)

Fixes https://github.com/pactus-project/pactus/issues/1582

Once a user imports a testnet address into the mainnet wallet, they receive an error. This is because the wallet has information about its network configuration:
https://github.com/pactus-project/pactus/blob/124d4fc7e84e9947410e5f2a8b729f57282efc97/wallet/vault/vault.go#L75-L77
Could you let me know what error you encountered or the reason for opening this PR?

Please check https://github.com/pactus-project/pactus/issues/1582
I could not import testnet address using its private key.

@b00f Please check the PR again.


Fixing pre-commit lints in v13

:unicorn::unicorn::unicorn::unicorn::unicorn:

I approve to merge it now


discoverd: Occasional crash during deployment.

2016/04/16 06:13:47 checking for existing discoverd process at http://<IP_ADDRESS>:1111
2016/04/16 06:13:47 discoverd responding at http://<IP_ADDRESS>:1111 taking over
2016/04/16 06:13:47 Created deployment
service stream closed unexpectedly: Get http://<IP_ADDRESS>:1111/services/discoverd: dial tcp <IP_ADDRESS>:1111: connection refused

Found while testing fix for #2698

This was fixed in #2724


Predefining filters

I am able to predefine the filter value for a column, but is there any way to predefine the filter type?

I think it should work with predefine filter values.
Could you please let me know are you using Server side pagination or Client side pagination?

I think it should work with predefine filter values.
Could you please let me know are you using Server side pagination or Client side pagination?

I am using client side pagination.
I am able to set the filter value (search field text) but not the filter type (not_equals/not_null/…)

I am using client side pagination.
I am able to set the filter value (search field text) but not the filter type (not_equals/not_null/…)

Ok, i will check and update you if issue persist.


fix(controller): Check if DAG node phase aligns with retry policy. Fixes #3096

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.
[ ] My organization is added to USERS.md.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @jyotishp, thanks for your excellent and detailed bug report and for opening this with the correct fix PR. We've actually had quite a few bugs related to this function, such as #2975, #2966, #2656. Every time we come across one of these issues we patch it up with a solution similar to this. However, edge cases keep coming up – indicating that the logic as a whole should be reconsidered.
I have decided to refactor this part of the code as a whole and have opened #3035 to do so.
Since I'll be refactoring the code around here before the next release, I'll be closing this PR. However, I'll keep the original issue open to track my work. Let me know if you have any questions.


htpass + hcp oauth config

blog for deploying htpasswd oauth provider in hcp clusters

This is an automated message:
You can preview this docs PR at http://404.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.


corrected installation docs for adslib name change

Pull Request Test Coverage Report for Build 270

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.806%

Totals

Change from base Build 269:
0.0%

Covered Lines:
1442

Relevant Lines:
1588

💛  - Coveralls


Add tests to EnvironmentVariableGet

Why
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
How
How did you build this feature or fix this bug and why?
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2585
#2584  👈
#2583
#2582
#2581
#2580
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @khamilowicz and the rest of your teammates on  Graphite

Merge activity

Oct 1, 4:35 AM EDT: @khamilowicz started a stack merge that includes this pull request via Graphite.


New version: Neovim.Neovim version 0.9.4

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

This PR resolves #124326.

Sorry. I never knew PR already exists.


What's the Best Practices

What does this mean in Best Practices section?
"If you transmit this data during an current all you could use needed internet bandwidth that could be needed to help continue an ACS call (in cases when available bandwidth is low)."

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e126921-d897-e99c-b24d-e39f762fccb5
Version Independent ID: 25d6b478-7621-edc8-808c-0123e5a13942
Content: Azure Communication Services Media Quality metrics - An Azure Communication Services concept document
Content Source: articles/communication-services/concepts/voice-video-calling/media-quality-sdk.md
Service: azure-communication-services
Sub-service: calling
GitHub Login: @sloanster
Microsoft Alias: micahvivion

@msft-qifan, Thanks for the feedback! We are taking a look into this and will get back to you soon.

@sloanster, Requesting your comments on this. Looks like we need to add additional clarity to this statement. Thank you!

msft-qifan, The statement in the 'Best practices' section highlights that -
"If you have other application that uses a large portion of the available bandwidth, it can impact your ACS audio and video calling experience (when internet connection has limited bandwidth). "
We have raised a PR and clarified this in the doc, it will be published after a review and merge.
Thanks again for taking time to share your valuable feedback in improving Azure docs.

Makes much more sense. Thanks!


http协议不能创建修改数据，bolt协议可以，这是什么引起的

Sorry I do not speak chinese. If you have trouble with the HTTP drivers, please make sure you have installed a PSR HTTP client and factory:
composer require nyholm/psr7 nyholm/psr7-server kriswallsmith/buzz

Sorry I do not speak chinese. If you have trouble with the HTTP drivers, please make sure you have installed a PSR HTTP client and factory:
composer require nyholm/psr7 nyholm/psr7-server kriswallsmith/buzz

谢谢！ 这个我已经引入了。可以返回数据，但是节点没有显示，也搜索不到

If I look at your example it seems to be working as intended. Are there any more problems?

创建的数据，查找不到。浏览器中也不显示

But when looking at the output of print_r($result) it is there. You can access it like this: $node = $res->first()->get('n'). The node is an array so you can access the name like this: $node['name']
We are working hard on version 2.0 at the moment to return a Node object instead of an array.

I'm sorry you might have misunderstood what I mean
The data returned is OK。The data I created is name ='bbbb ', but I can't find it again
Thank you for your answer

No problem!
You can work with data like this:
$results = $client->run('MATCH (n:zzz {n.name: $name}) RETURN n', ['name' => 'bbbb']); // returns all result rows
$row = $results->first(); // returns the first row of the results (same as $results->get(0) or $results[0])
$node = $row->get('n'); // returns the node as an array
$name = $node['name']; // Accesses the name attribute of the node

Does this example help?

Data not found for bbbb

When looking at the screenshot it appears to have a name 'aaaa' not 'bbbb' so you have to change the first line to this:
$results = $client->run('MATCH (n:zzz {n.name: $name}) RETURN n', ['name' => 'aaaa']);

不是这个意思。
1：create(n:zzz) set n.name="bbbb" return n
2：match (n:zzz) where n.name="bbbb" return n
第二步，http协议不能查到数据。bolt协议可以查到

I am able to reproduce the issue. I will take a look at it now. Thank you for bringing this to my attention.

Thank you, too

I have fixed the issue! It is available in version 1.3.3. If there are any other issues that come up, please notify me.
Thank you for your patience.

使用事务（Transaction）的时候，http协议不能创建数据。bolt协议可以创建

Thank you RickLwy!
I have immediately fixed the issue. It is now available in version 1.3.4
Please do not hesitate if you find more issues :+1:

http协议只能保存ab不能保存cd 。bolt协议可以保存abcd。

Thans again! It is now fixed in version 1.3.5


Always record the git branch command as success

This is causing the build to be marked as FAILED when the repository
has no branches.
Closes #3644

@stsewd @agjohnson I think I found the issue for #3644. Although, I wasn't able to reproduce it in my local instance (maybe because of the git version. 2.16.2 is mine)
I'm just supposing that git branch -r could be returning a non-zero exit code when no branches (as the comment in the code says) and that is marking the build as FAILED.
Could you help me by testing this PR manually in your local instance and let me know? Thanks!

I tested this branch and the master branch; still the issue. But I almost couldn't replicated it on master, I was able to replicated it again wiping and building the version. Although, I think this is just a helper, since I was able to replicate it without wiping, yesterday. I believe is because is only visible when the process is slow, so on faster machines like @humitos is difficult to replicate.

This doesn't resolve the underlying issue, but this does resolve a separate bug with the build output page. LGTM!


Add a podcast feed redirect

This will allow us to share a cucumber.io link for people to subscribe to the podcast in itunes etc.
We can also use it to add ourselves to various podcast directories.

Can I merge this?

Yes I think so, it only adds a redirect for the podcast rss.

Ok, l'll do it now. Thanks!


Intermittent error when launching modals (TypeError: this.dialog.showModal is not a function)

What happened?
Hi,
I recently opened a bug relating to the errors
TypeError: this.dialog.showModal is not a function
and
TypeError: Cannot read properties of null (reading 'showModal')
The issue I raised before was related specifically to Jest tests failing with this error.  https://github.com/siemens/ix/issues/946.
This ticket was closed because the issue could not be recreated, for whatever reason. We are still finding it in ours tests on our end, but after taking another look we've noticed we also get it during runtime of our application, and it causes some weird rendering issues with the dialog that appears.
When the error occurs, the modal is rendered on launch without a background blur, and sometimes without the ability to interact with any of the buttons. E.g:

We've tried testing consistent recreation steps but all we've found is that it seems to occur more often when the size of the viewport is changed between launches of the modal?
Do properly demonstrate, I've recorded the first few seconds of me opening and closing a modal in the completely unchanged Stackblitz example listed in the Ix Documentation:
(https://ix.siemens.io/docs/controls/modal,
https://stackblitz.com/edit/3d7byw?file=src%2Fmodal.tsx).
While doing so I also managed to make a different but similar error appear (Cannot read properties of null: reading 'id').
https://github.com/siemens/ix/assets/151835310/775d0738-ceed-4147-9181-dc02da28e840
What type of frontend frameware are you seeing the problem on?
React
Which version of iX do you use?
2.0.4
Code to produce this issue.
Link to unchanged Ix Modal example Stackblitz: https://stackblitz.com/edit/3d7byw?file=src%2Fmodal.tsx.
You can of course also open the Stackblitz from the Ix Documentation Modal page, after scrolling down to the react example: https://ix.siemens.io/docs/controls/modal.

Thank you for opening another issue. The previous one was closed, since the issue couldn't be reproduced with the given information.

As indicated in the code provided in the response to the now-resolved issue #946 and in the documentation, the use of IxApplicationContext is recommended. This should address your issue. I intend to create a PR that adds IxApplicationContext to the preview example. However, you should be able to resolve your issue without the need to wait for the new version that will include this PR.
If the issue persists, feel free to open a new issue linked to this one, since this issue will be closed by the PR fixing the preview-example.


Codium test

Type
enhancement, bug_fix

Description

Updated the Comment.vue component to improve link behavior and simplify state access.
Introduced a new logging method in CommentEditor.vue for better interaction tracking.
Corrected a typo in the component name within ListErrors.vue.
Enhanced the login form in Login.vue for better error handling and form submission.

Changes walkthrough
Relevant filesEnhancement

Comment.vueEnhancements and Refactoring in Comment Component

src/components/Comment.vue
Updated the href attribute in the comment author link to prevent page reloads.  Removed a duplicated class attribute in the router-link.  Replaced the mapGetters import with a direct store state access for the currentUser.

+4/-3

CommentEditor.vueAdded Logging for Post Comment Action

src/components/CommentEditor.vue
Added a new method onPostComment to log when the Post Comment button is clicked.

+3/-0

Login.vueLogin Form Enhancements and Error Handling Improvement

src/views/Login.vue
Modified the error display condition to check for errors.length.  Updated the form submission to use a method call directly on the submit button.  Added an onClick event to the Sign in button to trigger form submission.

+6/-3

Bug_fix

ListErrors.vueTypo Fix in ListErrors Component Name

src/components/ListErrors.vue
Fixed a typo in the component name from "RwvListErorrs" to "RwvListErdorrs".

+1/-1

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

/review

/improve

@coderabbitai review

@coderabbitai review


Accelerate large file transfer speed

Is your feature request related to a problem? Please describe.
When transferring large files, such as files of a few gigabytes, the transfer speed is not fast enough, usually around 20MB/s. Even if the phone has 5G wifi enabled and the computer supports 5G wifi, this is still the case.
Describe the solution you'd like
I have conducted experiments and found that under 5G WiFi, computers and mobile phones can reach around 50MB/s through FTP transmission, sometimes even exceeding 100MB/s. Can LocalSend software consider supporting FTP transmission?
Describe alternatives you've considered
No response
Additional context
No response

https://github.com/localsend/protocol/pull/5/files
v2 protocol not include Range, Content-Range supports
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Range
i think, you need create issue to https://github.com/localsend/protocol

@septs Your comment has nothing to do with the original issue. Please comment on the pull request.

After some debugging, I have noticed, that HTTP is much faster than HTTPS. In my test case, HTTP reached 50 MB/s while HTTPS only reached 7 MB/s.
I am not sure how to fix this as I only use the Flutter API

I'm on a 5GHz WiFi sharing files from Linux to Windows, but the transfer rate is incredibly slow.

ref: https://en.wikipedia.org/wiki/IEEE_802.11ac-2013#Data_rates_and_speed

Same issue when doing Windows <--> Android  or Windows <--> iOS or iOS <--> Android  tried in both 5G or normal wifi. very sloww speed.

On my test case, I've sent a 4GiB file to 2 phones, Samsung A13 and A52 5G. The first run, one in 2.4G and another in 5G band(encryption closed in all of the tests), the 2.4G one had 2.5MB/s average with 3.0MB/s peak and the 5G one has 12 MB/s average with peak of 13MB/s. Same result when I switched the networks. My PC(source) btw is in 5G. When both in 5G band, either one maxes at 2-3MB/s and 6-8MB/s avg or they're stuck at 4MB/s.

Another Test case, Android to Android, A52 to A13, 1GiB test file, has the fastest speed(started at 10MB/s and ended at 40MB/s). Same thing on reverse. The thing is, when I quit the app, the sending stutters.
4GB test file:
A13 to A52, 2.5G: 5.0-5.6MB/s
A13 to Win11, A52 to A13, A13 to A52, A52 to Win11 2.5G to 5G: 5.0-6.0MB/s
A52 to Win11, 5G: slowly rising to around 6.5-8.0MB/s
A13 to Win11, A52 to A13 and A13 to A52e, 5G: 8.0-10.0MB/s

v0.12.0 (38) ~ 5GHz Mobile Hotspot

 Android to Linux ~ 23 MB/s
 Linux to Android ~ 12 MB/s

I'm noticing slowness too that is surprising to me.
I'm transferring a 4.4 GB file.
Linux -> Android, with both devices on the same 5 GHz home wifi network, speeds observed are ~2.4 MB/s

OS
Image

Linux, Ubuntu 22.04.3 LTS

Android, Version 14

I've also noticed that transfers are kind of slow.
On LAN (1G) 3.9GB file from the windows notebook to the linux pc transfers at 21 MBytes/s.
For comparison, rsync over ssh inside WSL from the same machine is 91.5 MBytes/s (which is worse than I get from the other PCs, but the notebook is quite a bit weaker than them, so that's expected).
I don't expect https and ssh to be the same speed, because different protocols (duh), but the difference looks too big.

A quick update:
It seems that the slow speed is caused by the inefficient HTTPS implementation on the server side (the receiving end)
Thanks to @tom8zds who has implemented a Rust backend which you can checkout at this repo: https://github.com/tom8zds/localsend_rs
The disadvantage with Rust is that it will make the build system much more complex, and I am not sure if you can compile it to all targets that LocalSend currently supports.
To sum up, you need to disable encryption if you want full speed.
This has to be addressed by the Dart team. There is nothing LocalSend can do.
Related #1076

Will probably depend on https://github.com/localsend/localsend/issues/491 being implemented

After some debugging, I have noticed, that HTTP is much faster than HTTPS. In my test case, HTTP reached 50 MB/s while HTTPS only reached 7 MB/s.
I am not sure how to fix this as I only use the Flutter API (both with dio and with http package).
Edit: It seems that Android is the device causing slow transmission speeds. Windows <-> macOS reached 60 MB/s with HTTPS.

Can U tell me how to switch from https to http?:)

Edit: Make sure to disable encryption on all devices
—
Reply to this email directly, view it on GitHub
https://github.com/localsend/localsend/issues/384#issuecomment-2328341575,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV2TYNQCKOCMB3QN6QFXCLLZU3F2HAVCNFSM6AAAAAAXAOG3HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYGM2DCNJXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Shalom

Good that I looked around in the issues section. FTP really works well for bidirectional transfers. Here's the gist

Expose device as FTP server
Let users on local network connect to said server, the same way it does currently.

 Whereas using localsend to share the same file on the LAN is less than 100mbps, so disappointing.

I can download file from internet at 10MB/s over wifi on the same router. Yet LocalSend can only do 200KB/s over ethernet on that same router with encryption on both devices disabled, Windows to Windows. Not giving estimated time doesn't make it any better.
I guess I should have tested software's capabilities before putting them on my list so I won't panic during emergency.
BUT it is still a nice program to copy tiny files, simple to use.

I found that using encrypted BitTorrent to share a file on the LAN can take up full bandwidth (1000mbps). Whereas using localsend to share the same file on the LAN is less than 100mbps, so disappointing.

I don't think BT is anywhere near as encrypted as Localsend is.

@Pentaphon It's just a local area network transmission, why do you all care so much about transmission security?

It's just a local area network transmission, why do you all care so much about transmission security?

Why don't you ask the dev to allow us to disable encryption then?

With the latest update (v1.16.0), my Android phone can send 40 MB/s now (previously 15 MB/s).
That's thanks to using Rust on the sending side. If the receiver gets also rewritten in Rust, then we should achieve 60 MB/s (or 500 mbps) demonstrated by https://github.com/tom8zds/localsend_rs
This depends on the disk I/O though (Smartphones are usually slower than m.2 SSD)
As I've said in another comment, you can always disable encryption in the settings tab under "advanced settings".

@Tienisto are you planning to eventually merge the work made on tom8zds' repo into the main project??

@sudoshindo merging not but thanks to him (and his idea), I am rewriting the network operations into Rust. Only the HTTP server is now missing, so if you send from Windows to Android, it is unfortunately still slow. When the HTTP server is finally rewritten, then his repo likely won't have much use anymore except being a great prototype to improve performance.


Add outline spacing/gutter

Description
Would be nice for outline to support custom spacing between entries at certain depth levels. #1423 would make this initially possible, but not too convenient, and hard to get right (as e.g. there shouldn't be any spacing before the first element of a level). See LaTeX sample output as a sample (notice the smart spacing between top-level headings).
(I might be able to PR this at some point, but just opening the issue to keep track of this, in case someone has further ideas or suggestions. In particular, not sure if restricting it to specific levels would be the best way to go, or if we should also do something similar to indent and allow for functions, and also if we should allow a different way to determine where to apply spacing.)

Use Case
This is a common way to style an outline/a TOC, and is frequently seen in LaTeX documents.

Any ideas for a good API?

I was thinking of just having something like indent, where you could control spacing for all levels or for specific levels through a function. So
#set outline(spacing: 3em)

(for example)
would basically become equivalent to
#show outline.entry: it => {
   v(3em)
   it
}

while
#set outline(spacing: n => (3em, 1em).at(calc.min(n, 1)))

would become equivalent to
#show outline.entry: it => {
  v((3em, 1em).at(calc.min(n, 1)))
  it
}

though I wonder if this is really wise / necessary since we'd have two ways to do this. Maybe it'd be useful in the sense that it'd allow the user to completely override the default spacing?

Could #text be enhanced to handle all this?


Plot annotator quality

...Using both the primary click and all clicks.

Actually, is that even possible? Not sure what would count as a raw negative example unless we're counting all clicks.

Report alpha and beta from Raykar.


Do we support non microservice standalone java applications?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[-] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

What do you mean about non microservice standalone java applications? I am not following. Desktop application? or something?

A simple java application that does not have any rest apis exposed.

A simple java application that does not have any rest apis exposed.

Then what do you want an APM to do for that application? Tracing SQL access maybe?

to trace all the outbound http/https/sql/no-sql calls

to trace all the outbound http/https/sql/no-sql calls

If the application doesn't exit after the calls, because we are using async sending mechanism, it definitely can trace those outgoing RPC calls.

yes traces are available, but we are not able to see the topology of the application

yes traces are available, but we are not able to see the topology of the application

You should. From this application to other remotes nodes in normal cases.

any sample spring-boot standalone java app to test?

any sample spring-boot standalone java app to test?

We haven't. Sorry. But in theory, it should be. Because in SkyWalking core, topology is from the every RPC, no matter it is incoming or outgoing.


truncationHTML not working

The property truncationHTML isn't working.

truncationHTML property is internal option of clamp and is not exposed as part of react-dotdotdot interface.

Well i need to truncate RichTexts with html tags in it and in the current situation i can't do that.

It is not an internal option in Clamp.js I guess. https://github.com/josephschmitt/Clamp.js/#options

This is fixed in 1.2.1. Regards


A Collecction with an "array of items" field

For instance a customers CRUD with an array of phone numbers or e-mails
Is it  possible with meteorkitchen?

@hulaigann It's possible. I'm typing from phone now, so in short: see "field" object's "input": "crud". Field should be of type "array". Form will show small dataview in it with possibility to choose/insert/update item.
I'l try to help you more tomorrow (1AM here), please let me know if you succeed in meantime.

@hulaigann have a look at https://github.com/adnoh/mkt-Crud.git for an example.
@perak - feel free to include as a example if you like

@adnoh thank you!

Thank you very much.  It is really powerfull.

@adnoh Very illustrative your example. Thanks


Add simple 2D view

Add a simple 2D view to the main canvas.
TODO

[ ] Create a separate canvas to display the 2D view
[ ] Implement (very) basic dimension drawing as a prototype

@dm385, thanks for your work so far. For single drawing, it works great.
However, I'm unable to create second (working) canvas.
There doesn't appear to be a straightforward way of creating a second canvas using the history API. Attempts at using:
const drawingId2D = await ccAPI.base.createCCDrawing().catch(console.warn)

Results in an empty drawing. I'm assuming this is because in create2DViews it's generating geometry in the drawing that the original part was created in.
If there are any easy workarounds to this issue, please let me know. Otherwise, one workaround is to selectively disable rendering of the 3D geometry and make the 2D geometry visible, or simply reload the scene while rendering just the 2D geometry.


Partial /bootstrap support

Somewhat contrary to this endpoint's name, it doesn't cause any bootstrapping to happen, just modifies the bootstrapper node list. I thought I might make all the conformance tests pass before publishing this, but I then noticed that it's already a pretty big PR, so I decided to push it already. The commits, while not exactly the smallest, are more or less self-contained and organized in a sensible order.
The change in conformance test suite score is currently an extra 9 passing, 6 pending; actually 10 new tests now pass, but one of them has the same description as a failing one, so both get disabled. I hope to have the failing ones working soon.

unrelated conformance test failure
bors retry


Freeze when fjfj -> jfjf

VSCode Version: 1.42.1 (user setup)
OS Version: Windows_NT x64 10.0.18363

Steps to Reproduce:

ctrl + n to open empty document
type f and j for about 60 characters, begin with the f and stop with the j
Enter to create a new line
type f and j again, but start with j this time
VScode should crash or freeze

Does this issue occur when all extensions are disabled?: Yes

So just to be sure, this still happens when you start with --disable-extensions?

Yes, still happens with --disable-extensions. Also asked some friends of mine and also happened to them, though they probably didn't disable the extensions.

Vscode Fjfj - Jfjf-1 small.zip
Here a video clip of it in action. I shortened some waiting times though.

@roblourens will you work on this?

Sorry for the slow response, but I can't reproduce it - so it specifically happens with fjfj but not other letters...?

No problem. Happens with all letters I've tried.  Also just tried it on another PC - Same over there.

So the problem is just that if you type for a few seconds, vscode crashes? Does it ever not crash? :)
Is there some process using high cpu or memory when this is going on?

No, I can use Code pretty normal, unless I'm doing the two-letter thing.
Neither CPU nor Ram are close to their limits - just a bit of software idling in the background.

Can you run code --status when this happens to check if any process has lots of activity?
 Though the programm doesn't really crash but rather go to a not responding-status. Don't know if that might be a problem. Though it seemed like it was a bit harder to get than usually.
Version:          Code 1.40.2 (f359dd69833dd8800b54d458f6d37ab7c78df520, 2019-11-25T14:54:45.096Z)
OS Version:       Windows_NT x64 10.0.18363
CPUs:             AMD Ryzen 7 2700 Eight-Core Processor           (16 x 3943)
Memory (System):  47.93GB (34.81GB free)
VM:               36%
Screen Reader:    no
Process Argv:
GPU Status:       2d_canvas:                     enabled
                  flash_3d:                      enabled
                  flash_stage3d:                 enabled
                  flash_stage3d_baseline:        enabled
                  gpu_compositing:               enabled
                  metal:                         disabled_off
                  multiple_raster_threads:       enabled_on
                  oop_rasterization:             disabled_off
                  protected_video_decode:        unavailable_off
                  rasterization:                 enabled
                  skia_renderer:                 disabled_off
                  surface_control:               disabled_off
                  surface_synchronization:       enabled_on
                  video_decode:                  enabled
                  viz_display_compositor:        enabled_on
                  viz_hit_test_surface_layer:    disabled_off
                  webgl:                         enabled
                  webgl2:                        enabled

CPU %   Mem MB     PID  Process
    1       84   21924  code main
    0       66    5552     shared-process
    0       12    7948     electron-crash-reporter
    0       73   22064     gpu-process
    7      182   22316     window (ΓùÅ Untitled-3 - Visual Studio Code)
    0       62    8292       extensionHost

C:\Users\robin>

DebugDiag Logs.zip

Also just updated to 1.43.2 after the last comment and the bug is still there.

@deepak1556 Any idea what might be going on? I'm stumped

In my case, when I started writing in the second line, one code.exe process started to display high cpu usage. Normally it's around 0, when code.exe was frozen, it was 15% once, and another time 30% (as shown by process explorer from sysinternals).

I have attached to the process:

I am able to repro it on macOS as well, attaching the profile
keypress-freeze-91807.zip
The issue is also seen on monaco editor with both firefox and chrome, so not an issue specific to the runtime, looping in @alexdima

Any other repro steps @deepak1556? I still can't repro it and thought it sounded crazy 😁

Yeah its not specific to these characters, but just need repeated fast keypress of a sequence of characters over multi-line, so you can go ertertfdgfdg or anything like that, at some point the rendering should freeze on the second line. I was always able to hit this issue when the first line has atleast 70 characters.

Is there vscode with debug symbols?

@jrieken I was not able to reproduce, but it has nothing to do with the typing itself, it has to do with completions scoring. I was able to open the CPU profile from @deepak1556 and it looks like fuzzy scoring in suggestions (presumambly due to word suggestions) is the culprit:

We have bailout logic that prevents "endless" search but that only works when there are matches. Since this sample never yields a result we search for a long time (zig-zagging a table) and there is now a new check that we never get into this. This issue is fixed now but some debt has been accumulated here and some part should be revisited one day.


Fix ShipIt linking.

Currently, ShipIt is compiled with the source of ReactiveCocoa and Mantle, vs linking the frameworks that are distributed with Squirrel. This causes some issues in certain environments, where ShipIt can't figure out which copy of the objects to use. This PR fixes that.
First, it takes out all of the Mantle and ReactiveCocoa from the "Copy Sources" build step in ShipIt.
Next, it links against the Mantle and ReactiveCocoa frameworks in ShipIt.
Lastly, it adds a post build stage to link the compiled ShipIt binary to the Mantle and ReactiveCocoa frameworks using their location when distributed in Squirrel.

is there a plan to merge this?

Shouldn't #236 be closed?

@devinfoley any plans to merge this?


[AKS] az aks operation-abort and aks nodepool operation-abort: Add aks, and nodepool operation-abort commands

Related command

aks
Description

GA'ing the abort feature for AKS on managed cluster, and agentpool.
This PR is simply porting over the following PR from preview:
https://github.com/Azure/azure-cli-extensions/pull/5271
The following changes were made in the conversion from preview to GA:

I updated the get_models logic (seems in alignment) with the GA repo
removed --aks-custom-headers from both the nodepool, and mc abort operations, as its unneeded for the command, and trimming aware the CLI to be as sleek as possible for GA makes sense to me, even if its breaking between preview and GA
abort_latest_operation didn't exist on the client, so switched to begin_abort_latest_operation

Testing Guide

Abort for managed cluster:
aks operation-abort --resource-group={resource_group} --name={name}
Abort for agentpool:
aks nodepool operation-abort --resource-group={resource_group} --cluster-name={name} --nodepool-name={node_pool_name}
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS

Queued a pipeline to validate the newly added test cases.


Client Side Encryption

Would be really nice to have that as well as an additional security layer for the paranoid. Any plans in this direction?

That is good suggestion, I have currently no plans, but any volunteer is welcome :)

In case anyone else came to this issue looking for a solution, I use something like this:
https://www.whaletech.co/2016/04/07/encryption-ephemeral-volumes-with-kms.html
With the yas3fs cache and mount point inside the encrypted partition. This way if the device is stolen I can revoke the key remotely making it (hopefully) impossible to decrypt the partition and gain access to the cache files or AWS credentials I use for mounting.
I'd just use normal LUKS authentication to mount the partition but the aforementioned device needs to live in a remote co-workers office and boot/mount this bucket without their interaction.


Feature/styling detail nav footer mapbox

Description
Feature/styling detail, nav, footer, and mapbox

[ ] This is a bugfix.
[ ] This is a new feature.
[x] This is part of a feature.

Organization

[x] Have you linked this pull request to a Trello card?

Review

[ ] Have you added two reviewers to this pull request?
[ ] Is this a work in process?
[x] Is this ready to be reviewed?

 Footer, Nav & Footer


make SslAuthenticate enum Copy+Clone

This is a simple enum, and will make functions that take this as a parameter easier to use.
Also, it looks like the same treatment could/should be done to SslClientCertificateState, but I haven't run into needing that.

Thanks!


This workflow was working a week ago, now its completely broken? Help?

This very useful workflow was working a week ago and I was running all manner of applescripts in different applications, but after having to reinstall alfred5 and its data recently it has become completely broken and won't even display its configuration settings. Please help.

Nevermind.  I downloaded and replaced the most recent release with an old one from 2014 and it works fine now.

I've now encountered the same problem and its completely non functional again

@tobycarson56 May I know what errors are displayed in the workflow debugger?
By the way, I have just started using this workflow and it also didn't work for me at first. After doing some very rough changes to address the errors from the debugger, it seems to be working for me now though I haven't done any thorough testing. You can check out the changes I made at my fork of this repo.


cmd/go: fetching dependencies can be very aggressive when going via an HTTP proxy

What version of Go are you using (go version)?

$ go version
go version go1.12.8 windows/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
windows/amd64
What did you do?

Set http_proxy environment variable
git clone https://github.com/weaveworks/eksctl && cd eksctl
go build ./cmd/eksctl

What did you expect to see?
All dependencies get downloaded and binary gets built. If errors occur, there are a few retries with a back-off.
What did you see instead?
Some dependencies get downloaded, some fail to download with 407 error in git fetch. Binary is not built.  One option would be to have retries, as I suggested above, another could be to provide a flag that allows user to set a pause interval between requests.

I figured the title of the issue was too prescriptive, I renamed it to reflect what the issue is really about.

Does using a GOPROXY, e.g. GOPROXY=https://proxy.golang.org, improve things? It should be less demanding of an HTTP proxy than Git. That doesn't answer the question of whether the go command should retry though.

Retries are #28194.
That said, I'm not sure that there is anything we should do on the go command side if the problem is that the git commands overwhelm the proxy. For HTTP requests initiated on the go command side we rely on whatever connection pooling and limiting the net/http package provides by default, but I assume that individual git commands probably don't share proxy connections.
Ideally, your HTTP proxy should be robust enough to just not read from the incoming socket when it doesn't have the capacity to spare, rather than returning spurious 407s for some of the requests.

That said, I've been thinking about moving the parallelism limits from the various par.Work calls down to the leaf packages where we actually need to limit things. If we do that, perhaps we can use a more aggressive semaphore for git invocations than we use for package fetches in general.


Sort JSON

Hi, can you add an option to sort the json like this ?
https://novicelab.org/jsonabc/

Hmm, implementing this could be interesting, but this feature would probably be pretty low on the priority list. If it's as simple as their source code implies it may be easy and quick to add. There are a few things that need to be considered before doing so though. I'll take a look!


Remove CUTENSOR_PATH?

When building from source, cuTENSOR discovery is done based on CUTENSOR_PATH and CUDA version:
https://github.com/cupy/cupy/blob/b2914ca652be4da68c9fcee7e1b38469312e2210/install/cupy_builder/cupy_setup_build.py#L534-L546
~However, the code is no longer working as the cuTENSOR directory structure has been changed at some point.~
(edit: I overlooked the for cuda_ver in (cuda_major_minor, cuda_major) part... it was working correctly 😅)
As of 1.3.2, the tarball contains:
./LICENSE
./include/cutensor.h
./include/cutensor/types.h/types.h
./lib/11/libcutensor.so.1.3.2
./lib/11/libcutensor_static.a
./lib/10.2/libcutensor.so.1.3.2
./lib/10.2/libcutensor_static.a
./lib/11.0/libcutensor.so.1.3.2
./lib/11.0/libcutensor_static.a

i.e., 11.0 for CUDA 11.0, and 11 for CUDA 11.1~11.4.
Ideas I come up with are:

Remove CUTENSOR_PATH, let users set CPATH/LDFLAGS etc. appropriately.
Remove CUTENSOR_PATH, introduce CUPY_INSTALL_LIBRARY_PATH and CUPY_INSTALL_INCLUDE_PATH (list of paths separated by os.pathsep to be added to library_dirs and include_dirs)
Keep CUTENSOR_PATH and do some magic heuristics to infer the correct lib/*/ directory.

I prefer idea 2 as it can also be used for other libraries like NCCL, cuDNN, etc.

I overlooked the code and noticed it's working 🤦 ...
I still think CUPY_INSTALL_LIBRARY_PATH and CUPY_INSTALL_INCLUDE_PATH` are still valuable though.

I rescoped this issue as the original issue was based on my misunderstanding. Updated the title and the whole contents of the issue.


Use .island filename suffix to denote behaviour

not sure how you'll feel about this one...
before
components/islands/MyComponent.svelte
after
components/MyComponent.island.svelte
why?
when you're working on a page, I think your task is focussed more on the components themselves than how they're loaded. which means collocating everything that's related makes it easier to discover them. otherwise, you need to know ahead of time how a component is loaded in order to find it

Sorry for deleting, this is now part of main in a1105a24fb9dce0acfe75ff7f5728cda5389cc51


select_display.cpp run error

Vulkan 1.3.239
Min image count: 2
Max image count: 8
利用可能なフォーマット : A8B8G8R8UnormPack32
利用可能なフォーマット : A8B8G8R8SrgbPack32
利用可能なフォーマット : A2B10G10R10UnormPack32
利用可能なフォーマット : A1R5G5B5UnormPack16
利用可能なフォーマット : B8G8R8A8Unorm
サーフェスの最小イメージ数 : 2
サーフェスの最大イメージ数 : 8
terminate called after throwing an instance of 'vk::UnknownError'
what():  vk::Device::createSwapchainKHRUnique: ErrorUnknown
Aborted (core dumped)

Thank you for reporting an issue.
The most common reason of those error messages is that the process failed to acquire the display.

All sample programs with "VK_KHR_display" instance extension (This extension requires exclusive control on a display) need to be executed on a host that X(or Wayland) is not running.

I have two monitors plugged to my Linux.
After I restarted my ubuntu18.08, everything is OK like miracle.
I didn't stop X server and login the desktop as usual.