Add type hints to codebase

Context
I really like Python's new type hints. Let's add them!
https://docs.python.org/3/library/typing.html

This is a really big lift and I don't think the payoff is worth it. Closing for now.


Disable Scroll on Header section touch

I want to disable scroll when touched on header area because there is a list in and a view pager

Hi! Sorry, that it took me so long. You can call setSelfUpdateScroll(boolean) and Scrollable won't process touch events if passed true.


Schema Level Resolver can't be async

This is unexpected, because every other resolver in the graph accepts a Promise being returned.
I made a PR to address this in #199

Thanks! shipped in 0.8.2.


refactor!: remove useless fields in BlockHeader

What this PR does / why we need it?
This PR remove these three fields in Header:

difficulty
nonce
mixed_hash

They are all mining related and useless to Axon. The rpc will return the default value.
What is the impact of this PR?
⚠This is a breaking change.

CI Settings

CI Usage
Tip: Check the CI you want to run below, and then comment /run-ci.
CI Switch

[x] Cargo Clippy
[ ] Coverage Test
[x] E2E Tests
[x] Code Format
[x] Unit Tests
[x] Web3 Compatible Tests
[x] OCT 1-5 And 12-15
[x] OCT 6-10
[x] OCT 11
[x] OCT 16-19
[x] v3 Core Tests

CI Description

CI Name
Description

Chaos CI
Test the liveness and robustness of Axon under terrible network condition

Cargo Clippy
Run cargo clippy --all --all-targets --all-features

Coverage Test
Get the unit test coverage report

E2E Test
Run end-to-end test to check interfaces

Code Format
Run cargo +nightly fmt --all -- --check and cargo sort -gwc

Web3 Compatible Test
Test the Web3 compatibility of Axon

v3 Core Test
Run the compatibility tests provided by Uniswap V3

OCT 1-5 | 6-10 | 11 | 12-15 | 16-19
Run the compatibility tests provided by OpenZeppelin

/run-ci

/run-ci

/run-ci


fix(debug): set default log level

What does this PR do?
makes --dev-debug to set SF_LOG_LEVEL=trace if it's not set.
before:
to get debug logs from oclif and logging output we need to set --dev-debug and SF_LOG_LEVEL env var
after:
only --dev-debug is required. The default log level is trace so that all logger output is included.
What issues does this PR fix or reference?
@W-14375066@

QA NOTES

🟢 Seeing trace logs with --dev-debug
🟢 You can override it if you want SF_LOG_LEVEL=info bin/run.js org list --dev-debug

No trace logs shown

Looks good!


[web] Change url will lead to push to the same page. Duplicate GlobalKey exception will be raised.

Change url will lead to push to the same page. When the page has a widget which has a GlobalKey, Duplicate GlobalKey exception will be raised.
Steps to Reproduce
Context
I use named routes in a Flutter web app. There's 2 pages in the app. We call them P1 and P2. P1 has a widget which has a GlobalKey.
The steps

Visit P1
Push to P2 from P1
Change the url of browser to http://xxx/#/P1, so the app will push to P1
Now the app will output an exception Duplicate GlobalKey detected in widget tree. Because the first P1 and the last P1 are both in the route stack.

Exception detail

Here's the detail of the exception:
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown while finalizing the widget tree:
Duplicate GlobalKey detected in widget tree.
The following GlobalKey was specified multiple times in the widget tree. This will lead to parts of
the widget tree being truncated unexpectedly, because the second time a key is seen, the previous
instance is moved to the new location. The key was:
- [GlobalKey#d6fca]
This was determined by noticing that after the widget with the above global key was moved out of its
previous parent, that previous parent never updated during this frame, meaning that it either did
not update at all or updated before the widget was moved, in either case implying that it still
thinks that it should have a child with that global key.
The specific parent that did not update after having one or more children forcibly removed due to
GlobalKey reparenting is:
- Stack(alignment: AlignmentDirectional.topStart, fit: loose, dependencies: [Directionality],
renderObject: RenderStack#34653 NEEDS-PAINT)
A GlobalKey can only be specified on one widget at a time in the widget tree.

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49  throw_
packages/flutter/src/widgets/framework.dart 2939:15                           <fn>
packages/flutter/src/widgets/framework.dart 2963:16                           finalizeTree
packages/flutter/src/widgets/binding.dart 884:7                               drawFrame
packages/flutter/src/rendering/binding.dart 319:5                             [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1143:15                           [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1080:9                            handleDrawFrame
packages/flutter/src/scheduler/binding.dart 996:5                             [_handleDrawFrame]
lib/_engine/engine/platform_dispatcher.dart 1003:13                           invoke
lib/_engine/engine/platform_dispatcher.dart 157:5                             invokeOnDrawFrame
lib/_engine/engine.dart 440:45                                                <fn>
════════════════════════════════════════════════════════════════════════════════════════════════════

flutter doctor -v

(base) ➜  ume_playground git:(master) ✗ flutter doctor -v
[✓] Flutter (Channel unknown, 2.5.1, on macOS 11.4 20F71 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.5.1 at /Users/talisk/Library/Ugo/dist/2.5.1
    • Upstream repository unknown
    • Framework revision ffb2ecea52 (10 weeks ago), 2021-09-17 15:26:33 -0400
    • Engine revision b3af521a05
    • Dart version 2.14.2
    • Pub download mirror https://pub.dartlang.org
    • Flutter download mirror https://storage.flutter-io.cn
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/talisk/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/talisk/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.0
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0
[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 96.0.4664.55
• No issues found!

Hi @talisk, thanks for filing the issue.
Please provide a complete minimal reproducible code sample.
Thank you


Add an info after kamel promote

As discussed in https://github.com/apache/camel-k/pull/3674 we should include a short information when promoting an Integration to let the user know the integration was created/updated on the target namespace.

cc @tadayosi


test: remove skip to test flakiness [LIVE-9616]

📝 Description
PR to test flakiness of tests on CI
❓ Context

Impacted projects: ``
Linked resource(s): LIVE-9616

✅ Checklist

[x] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

beware that to test flakiness, you also need to remove the retries mecanism OR go into each job and make sure there were no "retries" on the test 👍

@gre yes from my testing the flakiness was present before the autoplay fix for animations https://github.com/LedgerHQ/ledger-live/commit/1c8739a69d82659f8f9068e66a94cf4bb1b03ae5
The mac screenshot is the only one not updated but looks fine now

@gre 0 retries in the logs looks good to go with your fix, we might want to look at the disabled tests too at the end


How to deal with the data alignment between annotation and predictions

Hi,
I'm new of caffe. And I think data annotation is very common among all the detection training applications.
I'd like to know how to deal with the data alignment between annotation and predictions during forward computation in the loss function such as  smoothL1LossLayer function?
Concretely, suppose there are n*n  output cells and each cell can predict m bboxs from pervious conv layer, then  if there are p annotations per image.
How to make the annotataion dimensions map the predictions?

Maybe you can read the Fast RCNN paper and its code https://github.com/rbgirshick/fast-rcnn. This can help you to understand better.


Added a Real-World Example Project to Quiz App

for [1-Beginner, Quiz App] I Added My Trivia App for android only, it's on the PlayStore.

Tech Stack: Android Studio, Kotlin, Jetpack, Retrofit2 & more...

I hope that this will help others developers.

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐


Frontend_with_Framework: React 8.1 -> REST API Calls

Description
Contributors are required to create Documentation and explain about the REST API Calls in React which should cover the question like :

What is REST API calls ?
Where we use this REST API calls ?
Benefits of the REST API calls.
also give some theory explanation with code.
also any add-ons in depth about these topic from your side.

Note :

Plagiarism is strictly prohibited.
Changes should be made inside the Frontend_Web_Development_React_Angular_Vue/ dir inside Frontend_Web_Development_React_Angular_Vue branch.
Files need to be added into the Week 8 folder only.

Domain
Frontend Dev React/Angular/Vue
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Create support-info.md and show it in all error messages

Acceptance criteria:

support-info.md file is a free-form file where it is possible to add support contacts to inform users who they can address their problems to.
The block "Support Information" ("Информация о тех. поддержке") should appear in all error messages as an expansion panel (see the mockup). Hidden by default.
This text should be localizable.
This is a custom feature, please add it to local file "Custom features".

Connected feature ID: supportinfo
Mockup

Todo:

[ ] tests


App isolation isn't working in Node

Hey all -- didn't see a template for issues so just going to provide a bit of info, let me know if you all need more.
Running this node example on a Windows 2022 server and RainwayStreamType.FullDesktop works great, but once I modify the stream type to RainwayStreamType.AppIsolation and provide a PID (verified via task manager that I'm providing the correct PID), the stream doesn't show anything. I've also verified that the stream connection is established because the message data is echoed back.
Any help would be great!

Hi @kdzapp I've just confirmed this is a bug - thanks for helping us find it! 😅
We're already planning to ship a new 0.4.0-beta.2 build in the next few days, and will include a fix for this in that release. In the meantime, it's possible to manually patch our sdk to resolve this issue, i've included the steps to do so below. After applying the change, isolateProcessIds should be properly marshalled to the native Rainway SDK component, that does the actual isolation. Hope that helps!

Clone this project
npm install
In node_modules\rainway-sdk-native\dist\index.js make the following change

Note: Running npm install again may overwrite this change

Change line 406 from:
isolateProcessIds: isolateArr.ref(),

to:
isolateProcessIds: isolateArr.buffer,

In case line numbers don't line up for some reason (they should) this is part of the following definition:
const rawConfig = new librainway_1.RainwayStreamConfigDef({
                streamType: config.streamType,
                inputLevel: config.inputLevel,
                incomingInputFilter: inputFilterCallback,
                isolateProcessIds: isolateArr.ref(),
                isolateProcessIdsCount: (_e = (_d = config.isolateProcessIds) === null || _d === void 0 ? void 0 : _d.length) !== null && _e !== void 0 ? _e : 0,
            });

Great! Thank you for the fix -- confirming this worked for me.


python3Packages.hwi: 1.2.1 -> 2.0.0

Motivation for this change
new major release
supersedes https://github.com/NixOS/nixpkgs/pull/116592
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116598 at 76df5842 run on x86_64-linux 1

2 packages failed to build (new failures):

hwi (python38Packages.hwi)
python39Packages.hwi

@GrahamcOfBorg build python3Packages.hwi

Result of nixpkgs-review pr 116598 run on x86_64-linux 1

2 packages built:

hwi (python38Packages.hwi)
python39Packages.hwi


Ubuntu 20.04 GEMFILE Missing

Hello everybody,
I've been trying to install onetimesecret on my Ubuntu 20.04 for hours now. Unfortunately unsuccessful.
I followed the instructions step by step, I only used the latest versions of ruby (2.7.1) and redis (6.0.6).
So far everything seems to have worked, but when I try to run the command, bundle install --frozen --deployment --without=dev I get the following error.

I have already adjusted the bundle version -> it was version 1.12.5 before. What can be the problem?
The rest of the installation, I did with another user, but I gave Sudo rights ots.
All packages are in the sources folder.
I would really be grateful for your help, since I've been trying to install a corresponding system for weeks now.

I guess this is a dead project?

I think so. I have put together my own solution.


Disabling blender file importing doesn't invalidate scenes that use already imported models, but the models are not available in exported game.

Tested versions
v4.2.2.stable.mono.official [15073afe3]
System information
Godot v4.2.2.stable.mono - Windows 10.0.22631 - Vulkan (Mobile) - dedicated AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.24033.1003) - 12th Gen Intel(R) Core(TM) i5-12600KF (16 Threads)
Issue description
After disabling importing blender files (I wanted to create .glb files manually) the scenes that used .blend files still worked on the development machine, but didn't work properly after exporting the project to an Android phone, as the models could not be loaded.
Steps to reproduce

Add .blend file to the project
Use the file in the scene
Disable Blender import
Export the project

Minimal reproduction project (MRP)
Example.zip

This is because disabling Blender import doesn't remove already-imported scenes from the .godot/ folder. Doing so would prevent you from opening scenes that instance these Blender-imported scenes, so I'm not sure it's a good idea.
Instead, we should have something that runs during the export process and aborts with an error if a dependency that can't be satisfied anymore due to differing project settings is detected during export.


fix the langchain and langchain_community version for deployment

latest versions are: langchain 0.2.0 langchain_community: 0.2.0
@abhishekkumar-27 please verify that these versions are working with your integration test

All the sources are working fine while executed integration test with latest langchain and langchain_community Version: 0.2.1

Done


adding django mptt

Added requirements for work on ActivityPage model
Additions

Added django-mptt-0.9.0 and django-js-asset-1.1.0 to support nested topic checkboxes in ActivityPage model.

Removals

N/A

Changes

Updated settings/base.py to import 'mptt' alongside 'teachers_digital_platform'

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

If these packages are specific to the teachers-digital-platform repo, can they be added to install_requires in that repo's setup.py file, instead of adding them globally here? Ideally satellite/third-party packages should bring in/specify their own dependencies.

Thanks @chosak  I'll do that instead.

This looks good but will break until the version of TDP in the requirements has MPTT in its setup.py install_requires. Otherwise the settings will be trying to import an app that hasn't been installed.
Please don't merge this until that MPTT release has been made, and the version upgraded in requirements/optional-public.txt.

closing this pull request in favor of pull request #4359


Bugfix - Typos in ./docs

Fixes few small typos in ./docs folder.

@facebook-github-bot shipit

@skevy We need to directly merge the doc changes :)

@satya164 Oh crap. I don't know what I was thinking. I'll do it on the other ones.


[editorial] Fix path base in Hugo front matter

Contributes to https://github.com/open-telemetry/opentelemetry.io/issues/3922

/cc @theletterf @svrnm

Hi all: can we get this editorial change merged soon?


use _print_proc

everywhere, but esp qmmap.py line 115

reproducible using docker-compose. Error does not appear with test_entrypoint
debugfilter=z


Update Sysupdater version for 10.4+

Flagrama releases weekly builds of the 10.4+ version of Sysupdater at http://larbob.com/build/sysupdater/ every Wednesday. Today, he released a new version that adds better compatibility for 10.7 downgrading (direct download can be found at http://larbob.com/build/sysupdater/working/sysupdater-10-7-3152016442.zip. This version should probably be in the guide for downgrading, perhaps alongside the older March 8 build you already have included, for the sake of 10.7 users.

Done


Allow cancel shutdown from BeforeShutdown()

Can be used for example for starting new instance and controlling successful start, canceling shutdown in case of failing with new instance start

Coverage decreased (-0.6%) to 53.36% when pulling 3a41128b6a38c2581d40e8eb93a6a07c544db232 on kanocz:master into ecde8c8f16df93a994dda8936c8f60f0c26c28ab on tylerb:master.

I like this idea a lot. Thanks for submitting the PR!
Before I merge, I'd like to see a test case covering the return false to cancel the shutdown, with a subsequent return true to successfully shut down. Thanks!

Make sense... I'll add tests in few days

Coverage increased (+9.8%) to 63.793% when pulling 3242f7b901edc2020983a52e94c5be2631e2a1c7 on kanocz:master into ecde8c8f16df93a994dda8936c8f60f0c26c28ab on tylerb:master.

Added test for returning false (TestBeforeShutdownCanceled). Returning true is just covered by TestBeforeShutdownAndShutdownInitiatedCallbacks

LGTM thanks!


CUDA version conflicts

I followed the steps to create and activate the virtual environment according to environment.yml, but the cuda version always conflicts: First, the nnpops package in the yml file relies on cudatoolkit 11.2.2, but the official gpu only has 10.2, 11.3, and 11.6 versions
Secondly, pytorch only supports 1.11.0 and 1.12.0. CUDA only supports cpu, cu102, cu113 and cu115. What are the correct versions of CUDA, pytorch, torchvision and torchaudio?
I have been stuck in this problem for five days. I hope to share with anyone who has successfully established the environment. Thank you very much！

First of all, all the packages have to come from conda-forge channel, otherwise it guaranteed not to work.
The installation instructions are here: https://github.com/torchmd/torchmd-net#installation. It seems, you are doing something else.


[WIP] Add RleDecoder::next() using fast bit unpacking

Do not review yet

Curious, how much of the total query CPU time is spent in this function? How much faster we expect the query to become after the optimization?

Curious, how much of the total query CPU time is spent in this function? How much faster we expect the query to become after the optimization?

@mbasmanova This function will be used to decode Parquet repetition and definition levels. It will eventually replace the legacy ones used else where too, but the gain needs to be measured and will be done later after the ParquetReaderBenchmark is finished. Since Parquet file would be dictionary encoded whenever possible, improving the dictionary id decoding(which is Rle/Bit packed) should be beneficial to overall scan heavy queries. I can update you after the code switching is done. ALso this is not the only optimizations for dictionaries. The RleBpDecoder will be extended to support filters on encoded data in the future.

closing in favor of https://github.com/facebookincubator/velox/pull/3000


Rules application and Chain weights

Refering to the rewrite of the Rules module in #1113, we now need to streamline determinating the appropriate weight version of the dataframe the sorted index will be based on. This process is no longer straightforward (by inspecting the incoming view name) since various use cases allow different weights on grouped cell items (for example: unweighted counts vs. weighted percents).
Our idea is as follows:

Rules meta uses an 'auto' tag by default
ChainManager.get() will need to use a sort_weight parameter identical to the cell items weight
_concat_views() calls the Rules object with a parameter use_weight = sort_weight
Look into Rules meta
3.1. 'auto': use cell items weight from sort_weight/use_weight
3.2. weight name or None: use that instead

This process will require to spec exceptions from the 'auto'-default per Batch, i.e. adjusting for differences in desired Batch weights vs. the actual weight (for example None) to sort on for different cell items.
Adding @nitsrek

that's merged.


Zuul default behaviour

Lets say I have zuul, eureka and two instances of same microservice.
zuul.routes.my-microservice.path=/my-microservice/**
zuul.routes.my-microservice.serviceId=my-microservice
zuul.routes.my-microservice.stripPrefix=true

Zuul will be using Ribbon for routing.
Default configuration contains following values for hystrix and ribbon:
hystrix.command.default.execution.isolation.thread.timeoutInMilliseconds=1000
ribbon.ReadTimeout=5000
ribbon.MaxAutoRetriesNextServer=1

This may cause following behaviour:
Lets say first call to my-microservice is failed by read timeout. Ribbon uses second instance of my-microservice and call is returned in 100ms. But hystrix throws timeout exception, because total time that was spent is 5100ms (5 seconds for first call plus 100 milliseconds for second call).
This is confusing.
I think, Zuul should not do another call, if there is no time for it and it will be failed in any case.

@rterentiev seems similar to #1772.  Can we perhaps close this issue and work the problem through #1772?

@ryanjbaxter yes. thanks!


no UP031 fix for "%d" % 1

Ruff 0.8.0
Minimal example:
"%d" % 1

https://play.ruff.rs/2acb42ef-d5d7-4dc0-a649-2b7ff4e174f2
ruff check up031.py --select UP031 --fix --unsafe-fixes
up031.py:1:1: UP031 Use format specifiers instead of percent format
  |
1 | "%d" % 1
  | ^^^^ UP031
  |
  = help: Replace with format specifiers

Found 1 error.

There is no fix, even no unsafe fix. But there is a fix if %d is replaced by %f. Isn't the logic similar here?
In a real project, there are hundreds of errors like this.

There is no fix, even no unsafe fix. But there is a fix if %d is replaced by %f. Isn't the logic similar here?

The logic is similar but what's different to %s is that all parameters need to be wrapped in int(parameter) to avoid changing behavior.
>>> "a %d" % 2.34
'a 2'
>>> f"a {2.34}"
'a 2.34'

>>> "a %d" % "test"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: %d format: a real number is required, not str
>>> f"a {'test'}"
'a test'

We would get the same behavior when wrapping the parameter with int
>>> f"a {int(2.34)}"
'a 2'
>>> f"a {int('test')}"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: 'test'

Unfortunately, Ruff doesn't understand today whether the parameter is an int literal or not, which is why the fix would have to wrap all parameters with int, which may or may not be what users want.

Wouldn't just "a {int(2.34):d}" be equivalent?


05/10/2018 18:46 : Create Pull Request for branch master -> prTesting1_2018051018

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update CONTAINER_REGISTRY_SUBSCRIPTION_ID in continuous integration w…

This pull request updates several GitHub Actions workflow files to provide a fallback for the CONTAINER_REGISTRY_SUBSCRIPTION_ID secret. If the CONTAINER_REGISTRY_SUBSCRIPTION_ID secret is not set, it will use the ACA_SUBSCRIPTION_ID secret instead.
Changes to GitHub Actions workflows:

.github/workflows/72-continuous-integration-pets-config-srv.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/73-continuous-integration-pets-admin-srv.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/74-continuous-integration-pets-disco-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/75-continuous-integration-pets-api-gw.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/76-continuous-integration-pets-custs-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/77-continuous-integration-pets-vets-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/78-continuous-integration-pets-visits-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/79-continuous-integration-utils-01-zipkin.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/79-continuous-integration-utils-02-prometheus.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/79-continuous-integration-utils-03-grafana.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/92-continuous-delivery-pets-config-srv.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/93-continuous-delivery-pets-admin-srv.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/94-continuous-delivery-pets-disco-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/95-continuous-delivery-pets-api-gw.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/96-continuous-delivery-custs-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/97-continuous-delivery-vets-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/98-continuous-delivery-visits-svc.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/99-continuous-delivery-utils-01-zipkin.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/99-continuous-delivery-utils-02-prometheus.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.
.github/workflows/99-continuous-delivery-utils-03-grafana.yml: Updated CONTAINER_REGISTRY_SUBSCRIPTION_ID to use ACA_SUBSCRIPTION_ID as a fallback.…orkflows

Thank you for the fix, awesome :-)


Templated perf monitor and benchmark

Perf events can be opened to be enabled, disabled, and read out as a single sys call respectively. However, you can only do that if you don't want to count children threads in the parent thread that instantiates the perf counters. Since it looks like we're only using the false inherit flag right now, I templated the class for a performance speedup when we want to use perf counters without inheriting counters.

For reference, here are numbers on my NUC for the new benchmark:
--------------------------------------------------------------------
Benchmark                             Time           CPU Iterations
--------------------------------------------------------------------
PerfMonitorBenchmark/Basic        11731 ns      11731 ns      64216    83.249k items/s
PerfMonitorBenchmark/Inherit      15895 ns      15894 ns      45351    61.441k items/s

Still need to revise documentation a bit then it'll be ready for review.


GetvideoTag() not working.

AppComponent_Host.ngfactory.js? [sm]:1 ERROR TypeError: Cannot read property '__zone_symbol__addEventListener' of null

Same error!!!

I had this problem and I solved it using ngAfterViewInit like this :
@ViewChild('lessonVideo')
private matVideo: { getVideoTag: () => HTMLVideoElement };

[...]

ngAfterViewInit(): void {
  this.matVideo.getVideoTag().addEventListener('ended', () => this.store.dispatch(new ReadNextVideo()));
}

I can't import MatVideoComponent 😢 :
import { MatVideoComponent } from 'mat-video'; // <= Module '"node_modules/mat-video/mat-video"' has no exported member 'MatVideoComponent'.

so I describe it's interface :
{ getVideoTag: () => HTMLVideoElement }

And it's work ! 😄

Thanks for your reply, i will try it definitely.


Is there a way to read the magnitude files from s3 ?

Is there a way to read the magnitude files from s3

Yes, it is documented here: https://github.com/plasticityai/magnitude#remote-streaming-over-http
You can see an example Python notebook here: https://colab.research.google.com/drive/1zkPhoNM1NvbTmEk9gr0Jnt8hONrca1Fv
Keep in mind this is still an alpha feature, if you really need performance and speed download the ".magnitude" file instead of streaming it over an internet connection.

Thanks ... i will try it out


Fix windows support.

This got broken after a few days.
If not obvious, the #[cfg(not(windows))] block is only for things that are absolutely not supported on Windows, like the concept of UNIX modes, for which there is no equivalent. Windows uses ACLs exclusively, and the current user defaults to full control (including execute) for files it creates.
No such limitations on HashSet that I'm aware of.

No such limitations on HashSet that I'm aware of.

My apologies, that must have been an IDE auto-import. Thanks for the PR!

This has been published as version 0.5.0.


Fix & standardize Validation tests across all countries

This problem was found thanks to #57:
public function test_validation_behaviour(): void
{
    foreach ($this->validIds as $id) {
        $this->assertTrue(
            Socrates::validateId($id, 'PT')
        );
    }

    // Here be dragons...
    $this->expectException(InvalidLengthException::class);

    Socrates::validateId('11084129 8 ZX', 'PT');

    // Everything here passes...
    $this->assertFalse(
        Socrates::validateId('14897475 4 ZY5', 'PT')
    );
}

Not only some countries test for a single invalid ID - which isn't ideal - but even those that test with multiple of those have that same problem.
The correct order of assertions should be:
public function test_validation_behaviour(): void
{
    foreach ($this->validIds as $id) {
        $this->assertTrue(
            Socrates::validateId($id, 'PT')
        );
    }

    foreach ($this->invalidIds as $invalidId) {
        $this->assertFalse(
            Socrates::validateId($invalidId, 'PT')
        );
    }

    $this->expectException(InvalidLengthException::class);

    Socrates::validateId('11084129 8 ZX', 'PT');
}

So we need to ahead and fix these tests for all countries.

As an addendum, it is slightly odd that we didn't find this problem before....
Validators were mostly implemented following the TDD logic, and with invalid IDs being tested against the algorithm as it was being developed.
I guess that as we try to tackle this, we will find out if there was something wrong with the test itself, or if it is a more insidious problem related to the environment...


Update readme's about "ping"

See #144 and #131 which added "ping" capability for easy testing.

The proxy.php file is working correctly for me, but I can't get the ?ping to work.
https://github.com/Esri/resource-proxy/blob/master/PHP/README.md says "Test that the proxy is installed and available: http://[yourmachine]/PHP/proxy.php?ping" but this just returns 403:
"The proxy tried to resolve a URL that was not found in the configuration file....."
I also can't see "ping" anywhere inside proxy.php. Thanks for any advice.

@slead - The ping capability was added on November 26, 2014 - see the commit history https://github.com/Esri/resource-proxy/commits/master/PHP/proxy.php

@bsvensson thanks. it's a bit confusing because https://github.com/Esri/resource-proxy recommends the released version, but this doesn't include the ping
"Instructions: Download and unzip the .zip file or clone the repository. You can download a released version (recommended) or the most recent daily build."

i agree.  we should probably either tag a new release or remove the instructions from the documentation.

FWIW I think the ping is a good way to verify that it's working. Thanks guys


Upload lodash version from 4.17.13 to 4.17.21

Q
A

Bug fix?
[x]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Increase the version of Lodash dependence from 4.17.13 to 4.17.21 to fix vulnerabilities that exist in version 4.17.13.
https://snyk.io/test/npm/lodash/4.17.13

@dependabot close


Handle unrecognized entry-point values with an exception

Hello, I am trying to upgrade solution with many projects, starting from specific project (entry point). I tried to use --entry-point options with many arguments: full path to csproj file, relative path to csproj file, project name, project number (from selection step), but all of them was ignored.
For example: create solution with 2 console applications. Typing upgrade-assistant upgrade ConsoleApplication1.sln -e C:\src\ConsoleApplication1\ConsoleApplication1\ConsoleApplication1.csproj does not select ConsoleApplication1 project as entry point.

Specifying csproj filename worked (ConsoleApplication1.csproj)
upgrade-assistant upgrade ConsoleApplication1.sln -e ConsoleApplication1.csproj
I think throwing an exception when the entry point is not recognized would be better than ignoring argument.

I think throwing an exception when the entry point is not recognized would be better than ignoring argument.

@Nadare2012 Thanks, this is a good suggestion to incorporate.

I can't get it to work. Specifying the project filename (or other variations) hasn't helped. Always this same exception:

upgrade-assistant upgrade SomeSolution.sln -e SomeProject.csproj
Unhandled exception. System.ArgumentException: Type System.Collections.Generic.IReadOnlyCollection1[System.String] cannot be created without a custom binder.    at System.CommandLine.Binding.ArgumentConverter.CreateEnumerable(Type type, Type itemType, Int32 capacity)    at System.CommandLine.Binding.ArgumentConverter.ConvertTokens(Argument argument, Type type, IReadOnlyList1 tokens, LocalizationResources localizationResources, ArgumentResult argumentResult)
at System.CommandLine.Binding.ArgumentConverter.TryConvertArgument(ArgumentResult argumentResult, Object& value)
at System.CommandLine.Parsing.ArgumentResult.Convert(Argument argument)
at System.CommandLine.Parsing.ArgumentResult.GetArgumentConversionResult()
at System.CommandLine.Parsing.ParseResultVisitor.ValidateAndConvertArgumentResult(ArgumentResult argumentResult)
at System.CommandLine.Parsing.ParseResultVisitor.ValidateAndConvertOptionResult(OptionResult optionResult)
at System.CommandLine.Parsing.ParseResultVisitor.Stop()
at System.CommandLine.Parsing.ParseResultVisitor.Visit(SyntaxNode node)
at System.CommandLine.Parsing.Parser.Parse(IReadOnlyList`1 arguments, String rawInput)
at System.CommandLine.Parsing.ParserExtensions.InvokeAsync(Parser parser, String[] args, IConsole console)
at Microsoft.DotNet.UpgradeAssistant.Cli.Program.(String[] args)


feat(tutorial): complete step 5

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@alisonjoseph oh sorry, sure! http://carbon-tutorial-fabianklonsdorf.eu-de.mybluemix.net/#/


fix(help): update opening hours

:tada: This PR is included in version 4.38.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SendGrid integration

I am unable to send mails in production, how can I integrate djoser with SendGrid?
I am using heroku for hosting.
Thanks!

It's rather a Django or Sendgrid question, not Djoser.
We are using Django configuration for sending emails.
There's also a guide for integrating these two.
SENDGRID_API_KEY = os.getenv('SENDGRID_API_KEY')

EMAIL_HOST = 'smtp.sendgrid.net'
EMAIL_HOST_USER = 'apikey' # this is exactly the value 'apikey'
EMAIL_HOST_PASSWORD = SENDGRID_API_KEY
EMAIL_PORT = 587
EMAIL_USE_TLS = True

After that everything should work out of the box.


Add HARP as a Manufacturer

@jsiegle I assume HARP is the Manufacturer of HARP devices?

No, we currently get these devices from OEPS, which is set as the default manufacturer. In the future these may be built in-house or purchased elsewhere.

ah, I see that. I think there might be a glitch with the web UI then. I'll track that down.
Can you tell me what OEPS stands for?

Open Ephys Production Site

@mekhlakapoor when I use the web app to make a ephys rig json, when I add a HarpDevice I see the full list of manufacturers, while in the schema it is actually hardcoded as being OEPS. Is this something we can fix? (And maybe check some other places where we limit our list of manufacturers in the schema to see how they show up in the app?

It looks to only be an issue for HarpDevice (other device types will automatically have the correct defaulted manufacturer). I think it might be because Harp Device. Also found that if I select OEPS in the enum, it changes the device to "DAQ Device" ?

@mekhlakapoor Can you take a look into whether this is still an issue or not?


PipelineFinder.list should always return empty list

Recent change of PipelineFinder breaks static collection with PIPELINE_ENABLED = False which is preferred for development.
PipelineFinder.list should still return empty list as it was in previous versions.
With standard list of finders:
STATICFILES_FINDERS = (
    'django.contrib.staticfiles.finders.FileSystemFinder',
    'django.contrib.staticfiles.finders.AppDirectoriesFinder',
    'pipeline.finders.PipelineFinder',
    'pipeline.finders.CachedFileFinder',
)

and empty list from PipelineFinder everything works ok for both PIPELINE_ENABLED True and False.
Otherwise return super(PipelineFinder, self).list(ignore_patterns) leads to extra static file copies after each collectstatic invocation if current storage is "cached" (e.g. STATICFILES_STORAGE = 'pipeline.storage.PipelineCachedStorage').
At first iteration you got files:
css/common.css
css/common.e9dea09215fe.css

Then:
css/common.css
css/common.e9dea09215fe.css
css/common.e9dea09215fe.e9dea09215fe.css

and so on.

Thanks!


include jquery and bootstrap datetimepicker in jsdom

Hi, guys please help me,
I use Jsdom for testing with mocha. requiring bootstrap-datetimepicker will raise an error as follows:
TypeError: Cannot set property 'datetimepicker' of undefined
      at app/assets/javascripts/vendor/eonasdan-bootstrap-datetimepicker/bootstrap-datetimepicker.js:2395:5
      at picker (app/assets/javascripts/vendor/eonasdan-bootstrap-datetimepicker/bootstrap-datetimepicker.js:42:26)
      at Object.<anonymous> (app/assets/javascripts/vendor/eonasdan-bootstrap-datetimepicker/bootstrap-datetimepicker.js:36:2)
      at loader (node_modules/babel-register/lib/node.js:146:5)
      at Object.require.extensions.(anonymous function) [as .js] (node_modules/babel-register/lib/node.js:156:7)
      at require (internal/module.js:20:19)
      at Object.<anonymous> (app/assets/javascripts/components/formsy/formsy_date_time.js:5:1)
      at loader (node_modules/babel-register/lib/node.js:146:5)
      at Object.require.extensions.(anonymous function) [as .js] (node_modules/babel-register/lib/node.js:156:7)
      at require (internal/module.js:20:19)
      at Object.<anonymous> (app/assets/javascripts/components/rule_form/rule_inputs.js:4:1)
      at loader (node_modules/babel-register/lib/node.js:146:5)
      at Object.require.extensions.(anonymous function) [as .js] (node_modules/babel-register/lib/node.js:156:7)
      at require (internal/module.js:20:19)
      at Context.<anonymous> (test/ruleFom/ruleInputs.spec.js:7:25)

here is my jsdom node script:
import {jsdom} from 'jsdom';
var $ = require('jquery');
global.document = jsdom('');
const win = document.defaultView;
win.jQuery = win.$ = $(win);

global.window = win;
global.jQuery = global.$ = win.jQuery;

Object.keys(document.defaultView).forEach((property) => {
  if (typeof global[property] === 'undefined') {
    global[property] = document.defaultView[property];
  }
});

global.navigator = {
  userAgent: 'node.js'
};

After further investigation, I found out the reason. This is code inside bootstrap-datetimepicker:
(function (factory) {
    'use strict';
    if (typeof define === 'function' && define.amd) {
        // AMD is used - Register as an anonymous module.
        define(['jquery', 'moment'], factory);
    } else if (typeof exports === 'object') {
        module.exports = factory(require('jquery'), require('moment'));
    } else {
        // Neither AMD nor CommonJS used. Use global variables.
        if (typeof jQuery === 'undefined') {
            throw 'bootstrap-datetimepicker requires jQuery to be loaded first';
        }
        if (typeof moment === 'undefined') {
            throw 'bootstrap-datetimepicker requires Moment.js to be loaded first';
        }
        factory(jQuery, moment);
    }

since I run jsdom in node environment, it'll go into block:
else if (typeof exports === 'object') {
        module.exports = factory(require('jquery'), require('moment'));
}

As stated in the jquery readme. at node environment, when requiring jquery it need to add window as argument. However in this code it doesn't( only require(jquery)). can someone help me?
thank you

See https://github.com/tmpvar/jsdom/wiki/Don't-stuff-jsdom-globals-onto-the-Node-global

@domenic thanks for the fast response, however I still get same errors, I update my code as follows:
import React from 'react';
import { mount } from 'enzyme';
import Formsy from 'formsy-react';
import jsdom from 'jsdom';
Inputs = require('../javascripts/components/example/inputs.js');

let options = {value: 'test', description: 'bar'},
jsdom.env({
        html: "",
        scripts: [myLibrary],
        done(err, window) {
          Inputs = require('../../app/assets/javascripts/components/rule_form/rule_inputs.js');
          const wrapper = mount(
            <Formsy.Form>
              <Inputs options={options} />
            </Formsy.Form>
          );
          console.log(wrapper.find("[name='paymentType']").props())
          done()
        }
     });

I need to get Inputs(this is where bootstrap datetimepicker imported) that's why I put inputs insed done block

Right, but as shown in that page, you can't use require to require such things. You need to insert them with a script element (like the myLibrary variable, which is undefined in your example).
Another issue is that you're using JSX syntax, which is not supported in jsdom or Node.js.


Test against pre-release versions

Of particular note is TensorFlow 2.3.0-rc0, which includes the fix for #1251.

Failures:

#1743
#1749
The Conda step still uses TF 2.2.0, and so fails because the xfails for #1251 are removed


ENH: Make _pick_to_idx public

@drammock other than mne.io.constants.FIFF (which is pretty painless to keep) this is the list of what we have to keep around to make sibling packages happy. Do you think we should make some variant of _picks_to_idx public?

Originally posted by @larsoner in https://github.com/mne-tools/mne-python/pull/11903#discussion_r1301869325
We'll have to think about the right API and we might not want to expose all options but it should be doable

I would like to rework the channel selection/pick API with the following goal in mind:

Reduce code duplication
Reduce the number of functions/methods in the public API
Harmonize the function names/arguments
Propose a public API for _pick_to_idx
Propose an API with input validation and a faster version skipping the validation

After going through mne._fiff.pick, I propose:

Keep the functions returning a channel type as is, get_channel_type_constants, channel_type, channel_indices_by_type. IMO, the naming schema is not consistent but those functions are not the priority.
Transform functions which operates on an object and return the same object into methods.

pick_channels_cov: move to mne.Covariance.pick
pick_channels_forward and pick_types_forward moved to mne.Forward.pick
pick_info moved to mne.Info.pick: this one is debatable as we need to prevent picking on an Info object attached to another object, e.g. Raw. IMO, we have 2 options:

(1) Keep pick_info as is and don't add a channel selection method to an Info object
(2) Remove pick_info, add mne.Info._pick (private) which modifies the instance in place and mne.Info.pick (public) which always returns a copy, prevent assignment to object.info, e.g. prevent raw.info = "foo" (which might already be the case?)

Merge _picks_str_to_idx, _picks_to_idx, pick_channels, pick_channels_regexp, pick_types into:

Functions selecting on a list-like of channel names
Functions selecting on an Info
Private functions with additional with_ref_meg: bool and return_kind: bool argument, if needed.

def pick_ch_names_to_idx(
    ch_names: list[str] | tuple[str] | set[str] | NDArray[str],
    picks: list[str | int], tuple[str, int], set[str | int], NDArray[str], NDArray[int], str, int,
    exclude: list[str | int], tuple[str, int], set[str | int], NDArray[str], NDArray[int], str, int,
) -> NDArray[np.int32]:
    pass

def pick_info_to_idx(  # or pick_to_idx?
    info: Info,
    picks: list[str | int], tuple[str, int], set[str | int], NDArray[str], NDArray[int], str, int,
    exclude: list[str | int], tuple[str, int], set[str | int], NDArray[str], NDArray[int], str, int,
) -> NDArray[np.int32]:
    pass

Both picks or exclude support the same types, with str being either:

a channel name
a channel type
'all' or 'data'
a regex

I'm not sure if allow_empty: bool should be part of the public API. IMO, this argument is linked to a second one validation: bool which controls the presence or absence of validation of the input, to e.g. speed-up the selection if you know your inputs are valid and/or if you don't 'care'. IMO, 2 options:

(1): include 2 arguments, allow_empty: bool = False and validation: bool = True, to the public API. Thus, you can now chose to skip input-validation and/or have some control on it.
(2) Keep the signature of the public API as above (pros: very simple) and add private functions _pick_ch_names_to_idx and _pick_info_to_idx which skip input validation. allow_empty: bool = False should likely be kept in those private functions.

Simultaneously, I would also deprecate for good the legacy pick_channels methods to tend towards a simpler and intuitive API. I believe those changes cover the majority of use-cases both in mne API and in external code. Those changes can be implemented piece by piece:

the current mne._fiff.pick module can become private e.g. mne._fiff._pick. Exisitng imports are fixed to keep using the existing function.
the new mne._fiff.pick module is implemented and MNE code-base can be gradually updated, one module at a time, to transition from mne._fiff._pick to mne._fiff.pick

The removal of the existing public pick methods in mne._fiff.pick is backward incompatible. The impact can be mitigated by either (1) a long deprecation cycle or (2) keeping those methods as legacy for now (especially as the documentation of those methods is at the mne-level, e.g. mne.pick_info, mne.pick_types).

I believe I have the time to work on this change before 1.7 is out, but let's take the time to think about the API first ;)

Without getting into too much detail, I would add to the priority list above:

@deprecateding as few things as possible in favor of @legacying them

In theory any new functionality like cov.pick should just extend existing functionality, so hopefully that function becomes a one-line wrapper like return cov.copy().pick(...), in which case keeping pick_channels_cov in the namespace carries minimal maintenance burden. We could even probably remove it from the API page to help with your point (2) above. I like the idea of modernizing the interfaces but leaving the (decade-?)old functions around for backward compat when the cost is minimal like this.
Beyond that I would suggest breaking this up as much as possible, otherwise the diff and review will be unmanageable. Hardest starting point (but maybe most satisfying?) might be to try to simplify the internal code to be more DRY. Simplest might be with something like implementing a cov.pick. A sort of in between would probably be to add the two new public functions you propose that directly address the _pick_to_idx-to-public issue in the title. But maybe you have some other plan...
There are a lot of details to work out with the above proposal, so I suggest @drammock and others who are interested first comment as well on the general idea, then @mscheltienne you propose what a first PR could include, then once we converge on that you can open it. That way we don't have to discuss everything all at once but can make incremental progress with a shared vision.
For me I'm overall +1 on these ideas subject to my suggestion to prefer @legacy over @deprecated.

I'll take a deeper look at the proposal soon, but meanwhile I'm adding a crossref to https://github.com/mne-tools/mne-python/issues/11531 and especially https://github.com/mne-tools/mne-python/issues/11531#issuecomment-1464442314

With the proposed approach, we can keep most, if nit all functions with the legacy decorator.
I agree we should break things apart. I propose to get a first PR with some minor changes and the structure of the new functions, i. e. function names, arguments and type-hints for the arguments and returns. We can iterate on the structure before coding the logic.

regarding pick_info

pick_info moved to mne.Info.pick: this one is debatable as we need to prevent picking on an Info object attached to another object, e.g. Raw.

another possibility that occurs to me here is that raw.pick() and raw.info.pick() could do the same thing (i.e. both could modify raw inplace).  On its face that seems like a good API to me, but it opens up the possibility of
my_info = raw.info
# ...many lines later:
my_info.pick()  # modifies `raw` (possibly unwittingly)

So I think we should avoid that.  And obviously we can't modify an attached info without modifying the instance it's attached to, so a public raw.info.pick() must return a copy, which is at odds with how .pick() works on all the instances; so I feel like it's an unintuitive API in that sense.  To my mind that leaves only two possibilities: your option (1):

Keep pick_info as is and don't add a channel selection method to an Info object

or an option where info becomes aware of whether it's attached to an instance, and if so, refuses to execute its .pick() method. That feels a bit overengineered and possibly fragile, so I'm voting for your option(1).
regarding functions selecting on a list-like of channel names
You'll see in https://github.com/mne-tools/mne-python/issues/11531#issuecomment-1464442314 that I advocated for @legacying pick_channels and pick_channels_regexp, but that idea was not popular with @agramfort and @jasmainak at least. Now, you're at least proposing to keep the functionality in a new, more flexible function, so maybe the idea will be more popular, but I worry a little bit about a single function being "too magic" in deciding when to interpret its input as a regexp and when to treat it like a plain channel name.  Perhaps we take inspiration from Pandas here? https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.filter.html#pandas.DataFrame.filter has items, like, and regex params which are mutually exclusive.
regarding pick and exclude
Maybe I'm misunderstanding but you seem to suggest that it will be possible to pass exclude="all" or exclude="data"; to me this seems pointless to support. Are there use cases you're imagining/encountering here?

For pick_info, I agree, let's keep the existing function as it would be counter-intuitive to have a method not modify the instance in-place.

For pick_channels and pick_channels_regexp, you wrote:

hey should also be marked @legacy or even deprecated/removed

I believe @jasmainak and @agramfort were not advocating against @legacy, but against deprecation. I would prefer to mark them as @legacy as well along the rest of the functions mentioned. IMO, @legacy functions should also be removed from the documentation build.

I worry a little bit about a single function being "too magic"

I usually agree and prefer to split functionalities, but here it doesn't seem that difficult. If a string is provided, is it a channel name? is it a channel type? is it a valid regex? We could even drop this last point by supporting re.Pattern directly for regex.

For pick and exclude, they should accept the same arguments.. beside those 2 non-sense cases :sweat_smile:


Remove the "m-dash-ui" class namespace from buttons so it works independently

https://github.com/Mudano/m-dash-ui/blob/6b7651a0469a5f26f8cbec785a33106acf29ab01/components/buttons/Button.scss#L1

Fixed here https://github.com/Mudano/m-dash-ui/commit/97b5b29bf6b3f69653cd758d28b834e90887a2ba


Create a sign up page

Create an html form, for creating users.
Fields needed are also specified in #8
They are:
Fullname: String,
email: String,
password: String
POST the form to /users

@thielpis referencing 2db40736fa083a2fb026a1fe5e09df0fc167d549 .
Issues regarding semantics:

[ ] Form method needs to be POST
[ ] Form Action needs to be /users
[ ] Fix identation


Error on Deploying to heroku

I am trying to deploy the app on heroku following https://devcenter.heroku.com/articles/getting-started-with-nodejs#introduction but it is not working, ( it works completely fine on now.sh )
when I ran heroku logs --tail
the error is rimraf: not found
I tried to fix it by globally installing rimraf on heroku
heroku run npm install rimraf -g
but that doesn't seem to work either.
are there any additional steps to following while deploying it to heroku?

@webgururobin make sure you install your dev dependencies on Heroku, by default it's disabled
see https://devcenter.heroku.com/articles/nodejs-support#devdependencies

can you check first https://github.com/vuejs/vue-hackernews-2.0/issues/224


feat: Remove app specific files

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Always use source maps

Source maps increase the first build time by 300ms, but a rebuild only takes 300ms in watch mode (which I hope you're using when checking out PRs and working on the extension)
Seeing the real source code makes sense when debugging stuff. No one wants to read webpack's output.
The only issue is that it doubles the extension's zip since currently the .js.map files are included — but perhaps seeing the source in production is good and it doesn't affect the JS files' loading time.

Debugging > Build perf


author information passed by the --author parameter is overwritten by DependencyTrack tool

Hi,
Thanks for implementing the feature of adding custom author information. using which i was able to create SBOMs with custom author information

However when we push the SBOM into DependencyTracker, the authors information is completely removed and replaced by Dependency tracker
i ran the following command to generate SBOM and upload into my dependency tracker instance
cdxgen -r -p --validate --deep --server-url https://depcheck-1-api.na.xys.com --api-key BjuZtssdsictq4e7uaBOKamRDKtiEHNzBc --project-id 637ce8cf-d1da-4b0d-a93b-d922dba984ea --author ABCD --author Visagan -o sbom.json
However when I download the SBOM from the project using "Download BOM" option, the metadata is completely overwritten

Not sure if its a bug on pushing the SBOM to DependencyTrack tool or the a bug in the DependencyTrack tool to retain the authors information

@visagansanthanam-unisys This is a known limitation of the Dependency track. Can you file a bug there?


Swift use in an iOS App

Hi there,
I'm looking for an algorithm witch give the sun position (Azimuth & Altitude) for a specific position at a specific date & hour. Your code looks very cool :) May be it can to the job ? Can you take a part of your time to help me found the right functions to use for my goal ?
Regards

Hi. Yes it does, you are in the right place.
Simply instantiate a Sun class with your date as JulianDay (there are easy constructors of JulianDay for that), then call the apparentEquatorialCoordinates() method, which gives you a EquatorialCoordinates instance.
Note that pesky little detail that you have to provide again the same JulianDay value. I will have to add a HorizontalCoordinates method right into the Sun class soon.

Hi, thank you :]
My problem is to integrate your lib in an existing project.

? whats wrong ?

Wrong? Nothing. I thought I answered your question. As to integrate a lib in your project, it is a very classical problem, and I'm sure you can find a lot of help online already, no?


Raspberry pi camera streaming feature

First, what you've done here is awesome. I am definitely trying this next weekend.
I would suggest the possibility to add as a feature to stream video from the raspberry pi camera hooked up to its port. That would be really handy.
Thanks for your dedication!

Hey! I think this is a good idea, but I'd rather not have it as part of the core package - since not everyone has a camera.
I've been considering building a plugin system, which would allow people to build plugins and install them for features like this one.
What do you think?

Hey! I think this is a good idea, but I'd rather not have it as part of the core package - since not everyone has a camera.
I've been considering building a plugin system, which would allow people to build plugins and install them for features like this one.
What do you think?

I would also be very interested in being able to use a pi camera.  Would be really nice to be able to quickly check and make sure everything is still attached to the build plate.
Also thank you so much for making this program!  I just got it running on my Creality LD-002H (you should also be able to add the LD-002R to the list of compatible printers because the motherboards appear to be identical.)

I would also be very interested in being able to use a pi camera.  Would be really nice to be able to quickly check and make sure everything is still attached to the build plate.
Also thank you so much for making this program!  I just got it running on my Creality LD-002H (you should also be able to add the LD-002R to the list of compatible printers because the motherboards appear to be identical.)

I think a camera is a great idea as well. I've actually installed MJPG-streamer and view the camera in an iframe with mariner. I'd be great to have a bit more polish though. :)
However I have to say, as a side note; its very hard to get a good shot with the cover on my printer, and I just can't print with it off. ;)

I think a camera is a great idea as well. I've actually installed MJPG-streamer and view the camera in an iframe with mariner. I'd be great to have a bit more polish though. :)
However I have to say, as a side note; its very hard to get a good shot with the cover on my printer, and I just can't print with it off. ;)

I think a camera is a great idea as well. I've actually installed MJPG-streamer and view the camera in an iframe with mariner. I'd be great to have a bit more polish though. :)
However I have to say, as a side note; its very hard to get a good shot with the cover on my printer, and I just can't print with it off. ;)

i'm basically doing the same but with https://github.com/pikvm/ustreamer which is better suited for a rpi.  also will soon have x264 support.

I think a camera is a great idea as well. I've actually installed MJPG-streamer and view the camera in an iframe with mariner. I'd be great to have a bit more polish though. :)
However I have to say, as a side note; its very hard to get a good shot with the cover on my printer, and I just can't print with it off. ;)

i'm basically doing the same but with https://github.com/pikvm/ustreamer which is better suited for a rpi.  also will soon have x264 support.

Waiting for this features, I put the Pi inside, have not tested what the camera see... but hopefully it will works
Soldering directly to make it smaller:

and mounting inside the cover:

Waiting for this features, I put the Pi inside, have not tested what the camera see... but hopefully it will works

I have been on a bit of a journey with the camera: https://imgur.com/a/iKbDWnW

@Hypertoken Can you make a small tutorial how you implemented a camera stream into the webUI?

@Hypertoken Can you make a small tutorial how you implemented a camera stream into the webUI?

@DivineJimmi. I wouldn't call it "Implemented" but this is what I did.

Install Mariner; You probably already did this ;)
Install MJPG-streamer ( or ustreamer as @dogmachine suggests); there are plenty of tutorials out there for these.
Once the camera is working, I just wrote a simple HTML to display it, with Mariner in an iframe.

Tbh i have absolute no idea how to write a html file. Maybe you can provide me with a step by step guideline?

@DivineJimmi LOL, this really isn't the place for it, but... You can just use notepad to write the file. The screenshot I included above is the entire file.

https://pastebin.com/pdfQLQig
You just need to change the ip to your raspberry pi ip or hostname. Save the file with the html extension. Then open it in your browser.  You might need to adjust the top:500px tag to get the camera frame where you want it.

@DivineJimmi LOL, this really isn't the place for it, but... You can just use notepad to write the file. The screenshot I included above is the entire file.

https://pastebin.com/pdfQLQig
You just need to change the ip to your raspberry pi ip or hostname. Save the file with the html extension. Then open it in your browser. You might need to adjust the top:500px tag to get the camera frame where you want it.

I'd need a little more guidance on this one. I've installed ustreamer and it nows streams to ip:8080/stream.
I created a camera.html file in the same directory that mariner store it's index.html. I open it with http://ip:5000/#/camera.html but it doesn't have the usual printer status nor it has the stream embedded but everything else of the mariner dashboard is there

All of this and more can be done with Node-RED which comes pre-installed on Raspberry Pi OS (including Light). I am actually in the process of building a platform to do all of this and more.
Definitely check out Node-RED, it's free, awesome and the community is very nice and helpful.
All the best!
Dax.

This looks really good. So for my understanding in the future this is easy to implement? I have absolutely no idea how to do this with nodenred.

@DivineJimmi, I didn't know anything about Node-RED until 2 months ago. :)
Though I am an engineer and can think logically, I'm definitely not a programmer, so I'm sure you can learn NR, too.
Once I've got my system all figured out, I'm going to post the entire flow to import directly into NR. Then you just need to select which sensors and output relays you have chosen to connect.

@daxliniere So you are connecting your sensors to the GPIO pins and choose them in your setup? Is this working with a camera too?

@DivineJimmi, yes exactly. NR interfaces with all manner of things using modules, such as the Pi modules that come preinstalled.
I have not got this particular setup working with a camera, but I have another Pi which takes a feed from a network (IP) camera and emails it to me upon a specific set of conditions, and the Pi-Zero has a camera connector on-board so I'm sure it would be a piece of cake to get the camera working, too.

@DivineJimmi, just find the Node-RED Youtube channel and watch their tutorials playlist. That'll give you an idea of how simple, but powerful it is.

I think a camera is a great idea as well. I've actually installed MJPG-streamer and view the camera in an iframe with mariner. I'd be great to have a bit more polish though. :)
However I have to say, as a side note; its very hard to get a good shot with the cover on my printer, and I just can't print with it off. ;)

How did you do an iframe on the web page? Did you just edit the underlying html?


test: add e2e provider tests

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds end-to-end (E2E) testing for the project, ensuring that the system works as expected through various scenarios.
Which issue(s) this PR fixes:
Fixes #2
Special notes for your reviewer:
Please review the added BATS tests and ensure they cover the intended scenarios correctly.
TODOs:

[x] squashed commits
[x] includes documentation
[x] adds unit tests

/ok-to-test

All the review comments from https://github.com/kubernetes-sigs/secrets-store-sync-controller/pull/31 have been addressed in the version of the PR.

Drop chore: updates kubebuilder config commit. You have pulled my commit as well into this PR.
Could also add e2e tests for VAP policies we have? We want to make sure controller is not trying to do things which are restricted using VAP.

Drop chore: updates kubebuilder config commit. You have pulled my commit as well into this PR.
Could also add e2e tests for VAP policies we have? We want to make sure controller is not trying to do things which are restricted using VAP.

VAP e2e tests will be covered by https://github.com/kubernetes-sigs/secrets-store-sync-controller/issues/47

@AlexanderStocks Changes looks good. Could you squash commits into single one?

/lgtm
/cc @aramase for approval

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@2a7ce23). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage        ?   56.32%
=======================================
  Files           ?       12
  Lines           ?     1051
  Branches        ?        0
=======================================
  Hits            ?      592
  Misses          ?      415
  Partials        ?       44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


General code fix 1

This pull request is focused on resolving occurrences of Sonar rules:
squid:S2275 - Printf-style format strings should not lead to unexpected behavior at runtime.
squid:S1481 - Unused local variables should be removed.
squid:S2095 - Fixed rule 'Resources should be closed.
You can find more information about the issues here:
https://dev.eclipse.org/sonar/rules/show/squid:S2275
https://dev.eclipse.org/sonar/rules/show/squid:S1481
https://dev.eclipse.org/sonar/rules/show/squid:S2095
Please let me know if you have any questions.
Soso Tughushi

Hi, thanks for the PR, but some specific comments that need to be fixed before I can merge.

@SosoTughushi - I made a few inline comments on this PR. I'd be happy to merge it, but only once they are addressed.

In light of the lack of reply on these issues I'm closing this PR.


Localisation: New Transaction Dialog

A click on new transaction whilst a language other than English is selected results in the dialog containing several items that are not localised, all enumerated below and emphasized in red inside the attached screencap:

dialog title which contains what I presume are identifiers for missing translation strings
"Type an address or a name"
"QR CODE"
"REMAINING BALANCE"
"LOAD TX FROM FILE"

mm likely a bug, i can see translations files are complete. Maybe some issues with character encoding.

So it looks like for the nl, ko, pt-PT the translation for the top is {{'Send'|translate}} {{ul.network.token}} {{'from'|translate}}. So that's only broken for a few languages.
QR Code doesn't have a translation, but QR Scanner does.
Remaining Balance and Load TX From File also don't have translations I believe!
So it just looks like the translations don't exist.

@luciorubeens spotted the issue: https://github.com/ArkEcosystem/ark-desktop/blob/master/client/app/src/accounts/view/sendArk.html#L5
translate should be removed from the span

Fixed in c664149de27aba6580c0d3ba33e19c9b33171501


create movie sets/collections based on my own criteria

What TMM version are you using?
TMM 2.9.16 release
What is the actual behaviour?
No way to group the movies in "movie sets" except by getting already defined sets from TMDB.
What is the expected behaviour?
I want to be able to create movie sets/collections based on my own criteria (ie - children movies or martial arts movies).
Additional
Manjaro Linux latest.

Oo the MovieSet page, click the "+" icon to manually create a MovieSet.
Once done, you can edit it, to add the (sparse) metadata, and to assign it now to movies...

Is there a way to do sequential numbering for moviesets?

movie sets are sorted (inside tmm) by their name; you could put the numbering into the movie set name if you want to
01. Movieset 1
02. Movieset 2
...
12. Movieset 12


Make dependence on web assembly optional

iOS in lockdown mode and graphene OS prevent wasm, so we shouldn't depend on loading it especially where not necessary.
https://stacker.news/items/595139/r/k00b?commentId=595602

Mhh, culprits that I can think of:

lnc-web

I think it's wasm only (not sure if that's even a thing) / has a hard dependency on it?
I couldn't even get to run lnc-web in #1243 again (it worked once but then it randomly broke afaik) so maybe we should just drop LNC?

nostr-tools

I think it can use wasm but it's not a hard dependency. You mentioned in #1243 we should replace nostr-tools with simpler code.
WASM is kind of weird: When one installs a package, it seems to mean that one could now depend on wasm or not but it's not really transparent. Or I am misunderstanding something terribly.

We can keep lnc, but we need to not avoid loading it if wasm isn't permitted.

fixed in e0f91ace41bc2077761bd6708e46ea344ef023ac


Fix compilation errors while trying to run instrumentation tests

Description (required)
Fixes Instrumentations Tests unable to run in device/emulator because the project fails to compile. Some classes changed names without updating the tests. Additionally there were some compat issues when calling Kotlin code from Java.
Some instrumentation tests are not passing. They need to be fixed but that is out of scope of what this PR is trying to fix.
Tests performed (required)
Tested betaDebug on Samsung S9 with API level 29.

Thanks for fixing the build @mikehc. :)
Also, it would be great if you could take a look at #3298. We are trying to run UI tests on Travis but are running into some issues.


[Task] End-to-end session-based recommendations example? (TF only)

Duplicate of https://github.com/NVIDIA-Merlin/models/issues/734 ?


Public/protected access to items from MessagesListAdapter

Hi,
First, thank you for your library. Very nice work ! :)
I need to access to items from MessagesListAdapter in order to implement Glide RecyclerView Preloader and optimize medias loading.
Is there any problem about that ? Or do you have a best practice for that case ?
Thanks !

Hi @16arm ! I will do items field in MessagesListAdapter and DialogsListAdapter in next release.

Is there any update on this or a suggested work around?
I am trying to implement a message sent/delivered indicator and will need to access the messages by ID to be able to update the label to reflect the delivery report for the message.


UNAUTHENTICATED error writing to BigTable with GOOGLE_APPLICATION_CREDENTIALS

in pom.xml, if I specify the following version, running Dataflow DirectRunner with GOOGLE_APPLICATION_CREDENTIALS that has BigTable admin role would result in UNAUTHENTICATED error
  <dependency>
			<groupId>com.google.cloud.bigtable</groupId>
			<artifactId>bigtable-hbase-beam</artifactId>
			<version>1.10.0</version>
		</dependency>

The output contains many retry errors of com.google.bigtable.repackaged.io.grpc.StatusRuntimeException: UNAUTHENTICATED: Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential
The fix is to change the pom.xml section to
<dependency>
			<groupId>com.google.cloud.bigtable</groupId>
			<artifactId>bigtable-hbase-beam</artifactId>
			<version>1.5.0</version>
		</dependency>

The output does not contain retry errors writing to BigTable
Please update your README.md to use the 1.5.0 version as an example so developers don't have to dig around to find the official doc to add the 1.5.0 version. Is 1.10.0 broken by nature?

@hilliao,
I just ran few dataflow runner jobs with bigtable-hbase-beam-1.10.0 version, those all worked fine for me. I am unable to re-create this issue at my end.
I also saw that you were using beam version 2.11.0. Could you please try again with the combination of bigtable version 1.10.0 and beam version 2.9.0.

I modified pom.xml per your request. The console output is after the pom.xml's content HERE. No luck. I am running locally with DirectRunner that reads from pub sub and writes to BigTable. My environment variable GOOGLE_APPLICATION_CREDENTIALS is set properly for pub sub to read events. In debugger, DataflowPipelineOptions.getGcpCredential() returns clientEmail="local-runner@[my project ID].iam.gserviceaccount.com" which is the correct service account I set. Are you running with DirectRunner>

@rahulKQL, I don't think that the Beam version is the problem.  This is likely something that relates to the client itself.
As of bigtable-client-1.7.0 we started using JWT instead of using service accounts directly.  That might be the problem.
@hilliao, I'm confused by why you've mentioned the Cloud Bigtable admin role.  Beam integration usually only use data permissions, and not admin.

I used that BigTable admin role for a different purpose. I could use BigTable user role that has the read,write data permission. The  BigTable admin role has more permissions and should not be the related to the issue here. The service account used here have the following roles:

Bigtable Administrator
Dataflow Admin
Dataflow Worker
Pub/Sub Publisher
Pub/Sub Subscriber
Pub/Sub Viewer
Viewer

I tried with 1.6.0 and 1.7.0 and reproduced the same UNAUTHENTICATED error. I have the full code zip files in issue #2151. Please follow the steps there for local runner, set GOOGLE_APPLICATION_CREDENTIALS, and execute

export GOOGLE_APPLICATION_CREDENTIALS=path/to/your/service-account-secret.json
mvn exec:java -Dexec.mainClass=com.finack.app.FinackPipeline -Dexec.args=" --project=mwpfin --runner=DirectRunner --mode=debug "

Only --mode=debug  will give you multiple UNAUTHENTICATED error in the console output after publishing at least 2 messages. With or without  --mode=debug, the results are the same: fail to process further pub/sub messages. Are you able to reproduce it running my code?

I tried to reproduce this problem in Cloud Dataflow and found this bug may not happen. I follow the workaound @sduskis  to change pom.xml so Cloud dataflow worker can start properly.

mvn   exec:java       -Dexec.mainClass=com.finack.app.FinackPipeline        -Dexec.args="--project=mwpfin       --stagingLocation=gs://mwpfin-tmp/github2151/       --runner=DataflowRunner       --mode=dataflow<EMAIL_ADDRESS>--jobName=bt-1-10-0"

Per Controller service account, the following image shows my job's worker is running as<EMAIL_ADDRESS>
it's able to read from pub/sub and write to BigTable. If you agree my testing was accurate, I will close this issue. it's not blocking our progress locally since we can use user credentials. @sduskis  said it's likely the local client causing the issue. Where can I look to configure or upgrade my client?

I think I encountered the same issue here... 🤔

@sduskis would you mind help take a look at my issue above? Thank you :)

Looks like if I change Apache Beam SDK for Java 2.13.0 to 2.11.0, then I don't get this bigtable read permission denied errors... wondering why that helps? 🤔

@liufuyang can you please open up a new issue?

I will give a try :)

For future reference, version >= 1.11.1-SNAPSHOT of the bigtable client have a workaround. I will release version 1.12.0 next week


Cannot retrieve group members in pg

[30] pry(main)> g.members.count
(0.7ms)  SELECT DISTINCT COUNT(DISTINCT "users"."id") FROM "users" INNER JOIN "group_memberships" ON "users"."id" = "group_memberships"."member_id" WHERE "group_memberships"."group_id" = $1 AND "group_memberships"."group_type" = $2 AND "group_memberships"."member_type" = $3  [["group_id", 4], ["group_type", "Group"], ["member_type", "User"]]
=> 1
so far so good.
[31] pry(main)> g.members.first
ActiveRecord::StatementInvalid: PG::UndefinedFunction: ERROR:  could not identify an equality operator for type json
LINE 1: SELECT  DISTINCT "users".* FROM "users" INNER JOIN "group_me...
^
: SELECT  DISTINCT "users".* FROM "users" INNER JOIN "group_memberships" ON "users"."id" = "group_memberships"."member_id" WHERE "group_memberships"."group_id" = $1 AND "group_memberships"."group_type" = $2 AND "group_memberships"."member_type" = $3 ORDER BY "users"."id" ASC LIMIT $4
from /Users/.../.gem/ruby/2.3.0/gems/activerecord-5.0.6/lib/active_record/connection_adapters/postgresql_adapter.rb:657:in `prepare'
\

Same here.

Seems to be a side-effect of how distinct works in ActiveRecord. See https://github.com/rails/rails/issues/17706
SELECT DISTINCT users.* won't work if there is a json column. The solution would be to switch to using SELECT DISTINCT ON (users.id) users.*

@NanoMeko were you ever able to resolve this?

Yeap, I decided to build my own group relationships with ActiveRecord
🤷🏽♂
On Fri, 12 Jul 2019 at 08:56, Kevin Collignon<EMAIL_ADDRESS>wrote:

@NanoMeko https://github.com/NanoMeko were you ever able to resolve
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dwbutler/groupify/issues/74?email_source=notifications&email_token=AAYESWKOULAHZ6UQ4RU24TDP7AMJZA5CNFSM4FQ3SXW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZYYPNI#issuecomment-510756789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYESWL3PLOUQ6WO5E7UQX3P7AMJZANCNFSM4FQ3SXWQ
.


[CT-3547] [Bug] setting source schema to empty string in sources.yaml has no effect on manifest.json

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When setting the schema property of a source in sources.yaml to an empty string dbt will still use the source name as schema name instead of empty string for generating manifest.json
Given:
version: 2
sources:
  - name: ingestion
    database: "test"
    schema: ""

will render manifest.json as:
{
 (...)
 "sources": [
  "database": "test",
  "schema": "ingestion"
 ]
}

This is relevant as tools such as Datahub will parse the information from manifest.json and construct identifiers for resources in the lineage. Databases such as Clickhouse do not have/use the schema-concept and in this case Datahub won't be able to correlate the lineage correctly. Manually editing the manifest.json and setting the schema property to an empty string yields the correct behaviour in that regards.
Expected Behavior
manifest.json is rendered as:
{
 (...)
 "sources": [
  "database": "test",
  "schema": ""
 ]
}

Steps To Reproduce

set schema to an empty string for any source in sources.yaml
run dbt compile
check target/manifest.json still contains the schema derived from source name.

Relevant log output
No response
Environment
- OS: Linux
- Python: 3.11.6
- dbt: 1.7.4

Which database adapter are you using with dbt?
other (mention it in "Additional Context")
Additional Context
Used database: clickhouse / clickhouse-dbt integration

@pulsar256 based on the docs here, it looks like dbt-clickhouse uses schema rather then database.
So what if you do this instead?
version: 2
sources:
  - name: ingestion
    database: ""
    schema: "test"

@genzgd is the workaround here related to what is reported within this issue?

It's probably related, yes.  We definitely use schema as the clickhouse database in most contexts and normally expect database to be an empty string.

@pulsar256 based on the docs here, it looks like dbt-clickhouse uses schema rather then database.
So what if you do this instead?
version: 2
sources:
  - name: ingestion
    database: ""
    schema: "test"

This solves the Datahub ingestion issue we were facing. Thank you!
From the documentation and principle of least astonishment perspective, I would not have expected that one creates a database in ClickHouse and later refers to it in configurations usually as database (connection strings, grants) and sometimes as schema.

This solves the Datahub ingestion issue we were facing. Thank you!

Awesome @pulsar256 !
In agreement with @genzgd's request, I'm going to close this in favor of open an issue in dbt-clickhouse regarding the schema/database distinction.


Use absolute path to Rails root for default options

This PR updates the default options paths from relative paths (config/image_optim.yml) to absolute paths based on the Rails root (/[path/to/rails]/config/image_optim.yml).
With this PR, the default path to the image_optim.yml config file will stay consistent regardless of the current working directory when the Rails environment is loaded.

@wjordan ping

@toy please take a look

Looks good, thanks for contribution!


chore(main): release 0.4.1

:robot: I have created a release beep boop
0.4.1 (2024-03-21)
Features

Add DateCoercer (ef8c1db)
Add inline serializer to fields (dd8042d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/maxveldink/sorbet-schema/releases/tag/v0.4.1 :sunflower:


Missing Languages

There are several language grammars available for tree-sitter. Checked items have SPM already implemented.

* Some of them don't yet have a highlights.scm file included and thus syntax highlighting will not work.

[ ] Agda*
[x] Bash
[x] C
[x] C++
[x] C#
[x] CSS
[ ] ERB, EJS
[x] Go
[ ] Haskell
[x] HTML
[x] Java
[x] JavaScript/JSX
[ ] JSDoc
[x] JSON
[ ] Julia*
[ ] OCaml
[ ] Markdown*
[x] Plain Text
[ ] Perl*
[x] PHP
[x] Python
[ ] Regex
[x] Ruby
[x] Rust
[ ] Scala
[ ] Sql
[x] Swift
[ ] TOML
[ ] TypeScript/TSX
[ ] Verilog*
[x] YAML*

Important to know is that some language grammars depend on another grammar to function properly (e.g.: C++ depends on the C grammar). Therefore the highlights.scm files need to be concatenated when run.
This can also happen when there are different flavors available (e.g: JavaScript & JSX). In this case there is an additional highlights-jsx.scm file located in the JavaScript's grammar queries folder.

Add new Languages
In order to make it a little easier to add SPM support to grammars, I wrote an article in the documentation: Add languages

test

@lukepistrol, Are we planning to add kotlin? I'm willing to contribute to it

@ahmed3elshaer We should be including kotlin. We would love the contribution! Feel free to reach out to @lukepistrol in the #editor channel in our Discord server to coordinate.

@ahmed3elshaer the Kotlin grammar is still in development and does not have a highlights.scm file yet for syntax highlighting. Feel free to contribute on their repo

@austincondiff thanks for the clarification 👍

@ahmed3elshaer the Kotlin grammar is still in development and does not have a highlights.scm file yet for syntax highlighting. Feel free to contribute on their repo.

I already started planning this, thanks for the referral 👌🏻

Is TypeScript and TSX coming soon?

@hamzaplojovic if it is not yet on the list, it definitely should be. Here is the tree-sitter repo for it...
https://github.com/tree-sitter/tree-sitter-typescript.

I will try, but I just wanted to remind you of one of the most popular ones 😊

Just a tip that Elixir is probably good to get on this list: https://github.com/elixir-lang/tree-sitter-elixir

Typescript and TSX are complicated. I have tried it already but I think it depends on javascript and for some reason adding it as a parentLanguage in CodeLanguage breaks the highlighting for TS & TSX.
The link to my spm branch on tree-sitter-typescript: https://github.com/lukepistrol/tree-sitter-typescript/tree/feature/spm

It would be amazing to see Terraform/HCL here too 😃

is it possible to fix the doc link?
This package is fully documented here.
and that link:
I wrote an article in the documentation: Add languages
Thanks

@MikePendo this might very much be related to this:

https://github.com/CodeEditApp/CodeEditLanguages/issues/1

We're not the only ones having this issue as there is already a ticket on the official swift-docc-plugin repo:

https://github.com/apple/swift-docc-plugin/issues/29

@MikePendo the links should now be working again! Fixed the issues for now!


Why only display one application, no user access information

##Why only display one application, no user access information? V0.2.0
Request http://localhost:80/ through your browser
log info
``
==> collector.agent.log <==
[2019-08-19 19:37:35,984] [WARNING] [run.py:47] collector agent exit with SIGNAL
[2019-08-19 20:30:25,587] [INFO] [StreamClientLayer.py:124] try to connect:('<IP_ADDRESS>', 9994) with timeout:5
[2019-08-19 20:30:25,588] [INFO] [StreamClientLayer.py:71] connect peer: [<IP_ADDRESS>:9994] success
==> php.agent.log <==
The PinPoint dashboard displays no data

hi, you should check below points

Did the pinpoint_php.so included?
Did the vendor/autoload.php had replaced with the auto_pinpointed.php?

For 2, you can find a our Guide PHP project under https://github.com/naver/pinpoint-c-agent/tree/master/PHP/pinpoint_php_example.
Hope to help you

1.[work@phpsit2 ~]$ php -m | grep pinpoint
pinpoint_php
2.pinpoint_php_example/index.php  Already introduced file “auto_pinpointed.php”
define('AUTOLOAD_FILE_ALIAS',__DIR__."/../vendor/autoload.php"); define('AOP_CACHE_DIR',__DIR__.'/../Cache/'); define('PLUGINS_DIR',__DIR__.'/../Plugins/'); require_once __DIR__. '/../vendor/eeliu/php_simple_aop/auto_pinpointed.php'; require_once __DIR__.'/Args.php';
3.Plugins/PreRequestPlugin.php
This file has been executed.
I'm trying to print  var_dump(pinpoint_add_clues(HTTP_STATUS_CODE,http_response_code())); return NULL
==> php.agent.log <==   Still no log information is output
4.My other configuration information
1）php.ini

extension=pinpoint_php.so
pinpoint_php.CollectorHost=unix:/tmp/collector-agent.sock
pinpoint_php.SendSpanTimeOutMs=0 # 0 is recommanded
pinpoint_php.TraceLimit=-1

2)collector.conf

[Collector]
AgentID=dev
ApplicationName=dev-app
CollectorSpanIp=<IP_ADDRESS>
CollectorSpanPort=9996
CollectorStatIp=<IP_ADDRESS>
CollectorStatPort=9995
CollectorTcpIp=<IP_ADDRESS>
CollectorTcpPort=9994
[Common]
Web_Port=80
Log_Level=INFO
LOG_DIR=/tmp/
[Agent]
Address=/tmp/collector-agent.sock

3)php version

[work@phpsit2 conf]$ php -v
PHP 7.2.0 (cli) (built: Dec 27 2017 09:04:38) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.2.0, Copyright (c) 1999-2017, by Zend Technologies

I really don't know what the problem is. I need your help ！
If you have WeChat or QQ, you can contact me to help me check, I will thank you very much

1.[work@phpsit2 ~]$ php -m | grep pinpoint
pinpoint_php
2.pinpoint_php_example/index.php Already introduced file “auto_pinpointed.php”
define('AUTOLOAD_FILE_ALIAS',__DIR__."/../vendor/autoload.php"); define('AOP_CACHE_DIR',__DIR__.'/../Cache/'); define('PLUGINS_DIR',__DIR__.'/../Plugins/'); require_once __DIR__. '/../vendor/eeliu/php_simple_aop/auto_pinpointed.php'; require_once __DIR__.'/Args.php';
3.Plugins/PreRequestPlugin.php
This file has been executed.
I'm trying to print var_dump(pinpoint_add_clues(HTTP_STATUS_CODE,http_response_code())); return NULL
==> php.agent.log <== Still no log information is output
4.My other configuration information
1）php.ini

extension=pinpoint_php.so
pinpoint_php.CollectorHost=unix:/tmp/collector-agent.sock
pinpoint_php.SendSpanTimeOutMs=0 # 0 is recommanded
pinpoint_php.TraceLimit=-1

2)collector.conf

[Collector]
AgentID=dev
ApplicationName=dev-app
CollectorSpanIp=<IP_ADDRESS>
CollectorSpanPort=9996
CollectorStatIp=<IP_ADDRESS>
CollectorStatPort=9995
CollectorTcpIp=<IP_ADDRESS>
CollectorTcpPort=9994
[Common]
Web_Port=80
Log_Level=DEBUG
LOG_DIR=/tmp/
[Agent]
Address=/tmp/collector-agent.sock

3)php version

[work@phpsit2 conf]$ php -v
PHP 7.2.0 (cli) (built: Dec 27 2017 09:04:38) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.2.0, Copyright (c) 1999-2017, by Zend Technologies

I really don't know what the problem is. I need your help ！
If you have WeChat or QQ, you can contact me to help me check, I will thank you very much

From the configuration your provide, every things is OK.
While, your " http://localhost:80/ ", did this will call a php script ?

The pinpoint-php-agent, only hooks the php script file !
You should check the auto_load.php (vendor/auto_load.php) is disable.  Some example


no remap  when not necessary

This PR address issue #52

PR was tested for these cases:
If same atm res,   same lev ,    diff ocean , same land        =>    we will link upper restarts
If same atm res,   same lev,  same ocean,     diff land        =>    we will remap upper restarts
If same atm res,    diff lev,     same ocean, same land        =>    we will remap upper restarts
Let me know if any other cases need to be tested.
@gmao-rreichle

PR was tested for these cases: If same atm res, same lev , diff ocean , same land => we will link upper restarts If same atm res, same lev, same ocean, diff land => we will remap upper restarts If same atm res, diff lev, same ocean, same land => we will remap upper restarts Let me know if any other cases need to be tested. @gmao-rreichle

"diff land" here is diff topo

@sdrabenh, @biljanaorescanin, @weiyuan-jiang: It looks like this PR is meant to address a situation when upper air restart files do not need to be remapped and can just be linked.  But why not apply the same checks to  the land restarts?  If the atm grid and bcs version (excl the topo files) are the same, land restarts don't need to be remapped.  Any differences in the number of atm levels, the ocean grid, or the topo files shouldn't matter to the land restarts.   I don't know how long it takes to remap high-res land restarts, but I imagine some savings could be realized by avoiding the unnecessary remapping of land restarts.  Just a thought.

@sdrabenh, @biljanaorescanin, @weiyuan-jiang: It looks like this PR is meant to address a situation when upper air restart files do not need to be remapped and can just be linked. But why not apply the same checks to the land restarts? If the atm grid and bcs version (excl the topo files) are the same, land restarts don't need to be remapped. Any differences in the number of atm levels, the ocean grid, or the topo files shouldn't matter to the land restarts. I don't know how long it takes to remap high-res land restarts, but I imagine some savings could be realized by avoiding the unnecessary remapping of land restarts. Just a thought.

If everything is the same, then why do remap ?

@weiyuan-jiang:

If "topo" and "agrid" and "levels" are the same, we don't need to remap the upper air restarts.  The "bcs version" could still be different (in something other than the "topo" files), which would mean that we have to remap the land restarts.  I think that's what you implemented in this PR.
If "agrid" and "bcs_version" are the same, we don't need to remap the land restarts.  The "levels" could still be different, which would mean that we would have to remap the upper air restarts.

These are just two quick example situations.  I didn't include the "ogrid" or the stretch factors in the example.  The stretch factors should probably be considered in a bundle with "agrid".  The full specs of the horizontal grid consist of the resolution ("agrid") and the stretch factors.
There are probably other combinations for which some (groups of) restarts may need to be remapped but not others.
My (admittedly vague) memory is that remapping land restarts can take a long time for high resolution bcs.

@weiyuan-jiang:

If "topo" and "agrid" and "levels" are the same, we don't need to remap the upper air restarts.  The "bcs version" could still be different (in something other than the "topo" files), which would mean that we have to remap the land restarts.  I think that's what you implemented in this PR.
If "agrid" and "bcs_version" are the same, we don't need to remap the land restarts.  The "levels" could still be different, which would mean that we would have to remap the upper air restarts.

These are just two quick example situations. I didn't include the "ogrid" or the stretch factors in the example. The stretch factors should probably be considered in a bundle with "agrid". The full specs of the horizontal grid consist of the resolution ("agrid") and the stretch factors.
There are probably other combinations for which some (groups of) restarts may need to be remapped but not others.
My (admittedly vague) memory is that remapping land restarts can take a long time for high resolution bcs.

Indeed, there are some cases that land restarts don't need to remap. I will make some changes

The latest commit will not do the remapping if it is not necessary for all restarts

I changed link to copy. I prefer the output folder has all the restart files.

Testing summary:
a) Automated tests passed
b) In red is what is diff to starting restart set

@gmao-rreichle