3DPW experimental result without training with 3dpw training data

Hi, in some HMR papers, they released their 3dpw eval results without 3dpw training data. For a fair comparison, I tried your released checkpoint [FastMETRO-S-R50_h36m_state_dict.bin], evaluated it on 3dpw test, and got a MPVPE ~129. This result is actually worse than some papers that didn't train with 3dpw (3DCrowdnet, PyMAF...).
And then I finetune this on 3dpw training data, and got an MPVPE ~93. I found the result surprisingly got a larger gain compared to other papers after fine-tuning on 3dpw (ex. PyMAF).
Do you know the reason why your paper didn't get a quite well performance before fine-tuning on 3dpw but  got a SOTA performance after fine-tuning?
Thank you!

Hello,
As described in METRO(Section: H. Limitations), our FastMETRO also might not perform well if the target domain distribution is significantly different from the source domain distribution. The non-parametric methods (FastMETRO, METRO, Mesh Graphormer), which directly regress the 3D coordinates of mesh vertices by leveraging transformer architectures, might suffer more from the distribution shift issue compared with other parametric methods.
This might be the reason why our method (also METRO & Mesh Graphormer) significantly improves the accuracy after fine-tuning on the 3DPW dataset.
To alleviate this issue, one may leverage domain generalization methods which improve the robustness to the distribution shift.
Thanks for your interest in our work!!

Please reopen this issue if you need more help regarding this.

Hello @mimiliaogo,
We recently investigated the large performance gap before and after fine-tuning the model on the 3DPW dataset. Using the model before the fine-tuning on 3DPW FastMETRO-S-R50_h36m_state_dict.bin, we visualized our estimation results on 3DPW and compared them with ground-truth meshes.

As shown in the above figure, we were surprised that most estimation results were quite accurate even before the fine-tuning on 3DPW. From this observation, we wondered why quantitative results showed the large performance gap. To figure out the reason, we visualized all estimation results on 3DPW and qualitatively evaluated them.

As shown in the above figure, we observed an unusual model bias for outdoor images of a person’s back, when the model had not been fine-tuned on 3DPW. It seems that the weird model bias significantly affects quantitative results, although most estimation results are quite reasonable.

As shown in the above figure, the model bias results in largely inaccurate human pose and camera estimations for outdoor images of a person’s back. It seems that the weird 3D human mesh outputs are produced for the compensation of inaccurately estimated cameras. The fine-tuning on 3DPW helps the model to estimate more accurate cameras and 3D human mesh outputs accordingly. In other words, the fine-tuning significantly alleviates the unusual model bias for outdoor images of a person’s back, and it might be the reason for the large performance gap.
We suspect that this unusual model bias might be attributed to training the model with 2D annotation datasets (e.g., COCO), where the model was supervised only using the 2D joint reprojection loss. In this case, the supervision lacks the structure of 3D human body. Despite wrong 3D joints, their projected 2D joints could be accurate compared with GT.
Since the mixed training dataset (e.g., Human3.6M, UP3D) contains only a few outdoor images of a person’s back (compared with the number of images of a person’s front), the model seems to be wrongly biased due to the 2D joint reprojection loss. Most non-parametric approaches might suffer from the same issue if they do not fully utilize human pose and shape priors.
We hope our observations will facilitate future research! To alleviate this issue, non-parametric methods need to fully leverage 3D human body priors while being trained on 2D annotation datasets.


RimuTec.Faker.Name.LastName() throws an YamlDotNet.Core.YamlException when locale is set to "pl"

Describe the bug
Using RimuTec.Faker.Name.LastName() with locale "pl" throws an exception with the following message:
"(Line: 48, Col: 5, Idx: 29115) - (Line: 48, Col: 9, Idx: 29119): Duplicate key"
To Reproduce

Create a project that targets .NET Framework 4.6.2 or use the test case with name ""
Set Config.Locale = "pl";
Call RimuTec.Faker.Name.LastName();

Expected behavior
A last name will be generated instead of the thrown exception.
Additional context
Add any other context about the problem here.

Thank you for submitting this great but report. I can reproduce this, too.

I have a fix for this and am working towards a new release that will include the fix.

This issue has been resolved in version 1.6.0 available at https://www.nuget.org/packages/RimuTec.Faker/
I'll keep the issue open for about a week. I'll close it then unless I hear that it has not been resolved.

Thanks for the quick fix. I just wanted to say, that I cannot wait to get my hands on, but it's a little bit hard to find the time right now. But as soon as I tried it, I will let you know.
(And I have full trust, that this is fixed ;-) )

I can confirm, that the issue was fixed, thank you 👍 :-)


_1password-gui: 0.8.2-1 -> 0.8.3-1

Motivation for this change
Changes:
https://discussions.agilebits.com/discussion/115413/
Also add an update script.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Is there any chance to get this backported to 20.03?

Is there any chance to get this backported to 20.03?

Not sure if it is worth it. 20.09 is branched soon and the release is probably in 1-2 months.

True, but it would grant the ability to easily use it to all those who are using the stable branch for few more months

True, but it would grant the ability to easily use it to all those who are using the stable branch for few more months

I looked into it, but we do not have Electron 9 in 20.03.


Workflows support waiting on multiple futures

Currently Cadence/Temporal workflows can only wait on one future at a time, for example a child workflow, an activity or perhaps dequeuing signal data.  It is not currently possible to wait for all or any of multiple things like that to complete.
This makes it pretty hard to write complex workflows.  For example you may need a workflow to start a child workflow that may run for a while and then also be able to react to one or more signals.  The current workaround is to multiplex different signals in a common queue potentially combined with polling.  Both of these solutions suck.
The solution is to add some kind of Workflow.WaitAllAsync(params IFuture[] futures) and WaitAnyAsync(params IFuture[] futures) methods that wait for the future(s) to complete, recording the result to the workflow history.  These methods will also need some kind of mechanism to return or throw errors and for WaitAsyncAsync(), a way to indicate which of the potential futures completed.  We'll also proabably need a way to have the wait timeout.
The actually waiting will need to be done by temporal-proxy.  We'll need to implement a way to identify different types of futures between the .NET client and temporal-proxy and the proxy will need to use channels and the Temporal GOLANG client channel extensions to implement the waiting.
We'll have to do some design work.

We're currently tracking this in #1105 and perhaps we can drop the whole thing after we bring the proxy in-process.

We're currently tracking this in #1105 and perhaps we can drop the whole thing after we bring the proxy in-process.


[File uploader] Regular file uploader isnt displayed in code on website

For some reason the regular File uploader is displayed in code on our website. We need to include this as our default before introducing the drag and drop file uploader.
Our usage and style guidance has this in examples so there should also be a code example. It is in Vanilla.

Upvote. Causing confusing for our ELM design and dev. team since it seem to imply there is "only" a drag-and-drop control when first reading the page.
Related to #493 where the Usage tab provides no guidance for the drag-and-drop variant.

Look like with the new component demos this has been resolved. The website is showing both now.
https://carbondesignsystem.com/components/file-uploader/code

yay!

Thanks for the code demos, but the "Usage" page doesn't describe how or when to use the drag-and-drop control and the "Style" page doesn't provide any specs for the drag-and-drop control.

yep we are going to work on getting that in next!


Add integration tests for Streamlet Java API

Integration Test is also useful for end2end coverage.
Currently, the following streamlet ITs exist:
Python: word_count_streamlet
Scala: ScalaStreamletWithFilterAndTransform and ScalaStreamletWithMapAndFlatMapAndFilterAndClone
Java Streamlet API does not have any IT yet.

Here is the PR:
https://github.com/apache/incubator-heron/pull/3105

PR Merged


Add OPEN_FULLMUTEX flag when opening mbtiles

On Android without this flag showing maps from mbtiles works properly as somewhere I read that on Android SQLite is opened with thread-safety, but unfortunately on iOS without this flag showing maps from mbtiles crashes, so this adds thread-safety for iOS devices.

Hey @rwrx, thanks for your patience with this PR! The change to update SQLiteCpp and apply the OPEN_FULLMUTEX flag looks good. I tried reverting the CMake changes because the iOS build was working on my machine without those flags. I think there may be a bug in CMake 3.17 related to iOS builds because it works fine using CMake 3.18.

@matteblair ok, I understand, thank you.


redis doesn't get configured on server install

I had to do this myself, not sure if the README or package.json file is missing a step?

Yes, you have to install Redis Server manually, I'll add that in readme.
Thanks.
If you still have issues you can reopen the issue.


update: candle to latest & pin version

Updates just the versions of all libraries, there were minor changes required but they shouldn't affect anything significant.
cc: @Anindyadeep

Ok Merging, Thanks for the PR :)


Upgrade to 2.3.3

Begins adding new binaries from @stillonearth
Build is currently failing with a series of strange linking errors...
According to StackOverflow, these would suggest that the binaries weren't all built together...
Or perhaps my headers are mismatched with the binaries??
Were these binaries built based on the 2.3.3 tag at https://github.com/deepmind/mujoco/commit/dfd463cdb5cd315e9fb20b518f0fbbf4ac018de2 ?   Or was it the head of main?

I believe this is due to dated headers on upstream. I'm doing 2.3.5 build now with this issue fixed.

Cool! Is there any way to preserve some form of lodepng?   There are a few examples that use custom models and PNGs...

Closed for #13


Feature request: template as Buffer, output as Buffer

It wold be nice if template support node Buffer and also output as node Buffer
something like this
let template = fs.readFileSync('./template.docx')
let report = await createReport({
    template,
    data: {id: 1},
    nodeBuffer: true, // or something else
  })
console.log('Is buffer?', report instanceof Buffer)

I try to make PR, but my laptop is Windows, some build tools are not working

I would also like to have this. I will create a PR.
The problem is having a neat API, without breaking existing ones.
@guigrpa : maybe we could check the type of given template param, and use buffer if it is not a File ?

@saknarak
Until this is implemeted/published, this might help you:
const { default: createReport } = require('docx-templates/lib/mainBrowser')
const { readFile } = require('fs')
const { promisify } = require('util')

const readFileAsync = promisify(readFile)

async function generateDocx(data) {
    const template = await readFileAsync('./template.docx')
    return createReport({ template, data })
}

module.exports = {
    generateDocx,
}

It returns Uint8Array, but you can convert it easily to node buffer with Buffer.from() (but it shouldn't really be a problem since Buffer instances are also Uint8Array instances).
@guigrpa @vdechef
I'm also interested in having this feature, so if you need any help I'm available.
I like the idea of outputting buffer if no output path is specified, but that would be a breaking change. Determining output type from template type doesn't cover the case where we would have file path as input and buffer as output.
Maybe using output: 'buffer' could be a better option?

It looks fairly simple to implement.
In this file instead of this:
  await fs.ensureDir(path.dirname(output));
  await fs.writeFile(output, report);
  return null;

Have this:
  return Buffer.from(report);

It just requires some tests and README update. Anyone keen to do it?


Fix entities falling through tall blocks

Previously, entities could fall through tall blocks instead of standing on them, if their gravitational velocity was sufficiently close to zero. This was because the collision algorithm only sampled blocks in the range traversed by an entity as it's moving. Since fences and walls extend past a 1x1x1 cube, they would not be sampled unless the velocity had a magnitude greater than 0.5 (but even then, still could fail to be picked up on depending on entity positioning and velocity!)
The solution is to sometimes collision check against the bounds of the block beneath the one intersecting the moving bounding box, if the lower block has a height greater than 1.
Caveat: The solution assumes there are no collision shapes greater than 1.5 blocks in height.
Should fix #990, and a related problem with horizontal movement where the tall part of the fence would not be taken into account.
Also includes relevant integration tests.

Could you add another check similar to entityPhysicsCheckFallCarpetFence, where the entity hits both the fence and the carpet?
        entity.setInstance(instance, new Pos(0.5, 54.0625, 0.5)).join();
        assertEquals(instance, entity.getInstance());

        PhysicsResult res = CollisionUtils.handlePhysics(entity, new Vec(0, -11.03, 0));
        assertEqualsPoint(new Pos(0.5, 43.5, 0.5), res.newPosition());```

I made the suggested changes, and also took the opportunity to add in an optimization + a few extra unit tests.

Your optimization causes this test to fail
    public void entityPhysicsCheckFallHitFenceLongMove(Env env) {
        var instance = env.createFlatInstance();
        instance.setBlock(0, 42, 0, Block.OAK_FENCE);
        instance.setBlock(0, 43, 0, Block.BROWN_CARPET);

        var entity = new Entity(EntityType.ZOMBIE);
        entity.setInstance(instance, new Pos(0.5, 54.0625, 0.5)).join();
        assertEquals(instance, entity.getInstance());

        PhysicsResult res = CollisionUtils.handlePhysics(entity, new Vec(0, -21.03, 0));
        assertEqualsPoint(new Pos(0.5, 43.5, 0.5), res.newPosition());
    }

From what I can understand, your optimization relies on the entity either moving a small amount or ending at the block with the fence, and these cases are not guaranteed.

It looks like the collider is hitting the carpet first, and then breaking out of the loop in RayUtils#raycastCollision. If there were no collision it'd eventually hit the fence.
I think I've got a relatively simple fix for this

Your test passes now, and I realized I could optimize the algorithm further (before, it would sometimes check blocks it didn't need to check).

I don't know if it's related, but falling sand blocks can fall through a solid block completely. I think it happens when the falling sand is 2 blocks above a solid block

I don't know if it's related, but falling sand blocks can fall through a solid block completely. I think it happens when the falling sand is 2 blocks above a solid block

Probably unrelated unless it only happens with tall blocks. I tried spawning a bunch of falling blocks at different heights and was unable to get any to fall through (on a build with my fence collision fix). On an older build, the fence issue does impact falling blocks too.


Update codecov integration

Codecov Report

Merging #6 (8582022) into master (538d74b) will increase coverage by 20.64%.
The diff coverage is 90.43%.

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   72.82%   93.47%   +20.64%
===========================================
  Files          14        9        -5
  Lines         622      613        -9
===========================================
+ Hits          453      573      +120
+ Misses        143       27      -116
+ Partials       26       13       -13

Flag
Coverage Δ

unittests
93.47% <90.43%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

atomic.go
57.14% <ø> (+0.62%)
:arrow_up:

exist.go
100.00% <ø> (ø)

func.go
100.00% <ø> (ø)

pkg/popen/cmd.go
100.00% <ø> (ø)

touch.go
84.61% <ø> (+4.61%)
:arrow_up:

filename.go
83.33% <72.72%> (+2.08%)
:arrow_up:

walk.go
78.20% <78.20%> (ø)

filepath.go
100.00% <100.00%> (ø)

pkg/dir/glob.go
100.00% <100.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b7882...8582022. Read the comment docs.


Using  with slots produces hydration missmatch only in nuxt3 (vue+vite works fine)

Environment

Operating System: Windows_NT
Node Version:     v18.7.0
Nuxt Version:     3.7.3
CLI Version:      3.9.0
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
Here is a reporduction version of this issue: https://stackblitz.com/edit/nuxt-starter-nufrzf?file=components%2FDynamicStyle.vue,app.vue
Please note that issues like this don't visually show in Stackblitz. You need to run it locally.
Here is an example from Vue with vite where it doesnt happen: https://stackblitz.com/edit/vitejs-vite-zcf5i1?file=src%2Fcomponents%2FDynamicStyle.vue,src%2FApp.vue&terminal=dev
Describe the bug
When using <component :is="'style'" type="text/css"> with named slots, a "Hydration text mismatch" happens. This seems to not happen when running vue with vite, but I am not 100% sure that this isn't something downstream.
Additional context
I have a solution for my specific use-case: https://gist.github.com/SebbeJohansson/c76ecfcc019c11cda6e3abfa2e946efa
Kinda nasty, but it works.
 That might be a better solution than fixing what ever hydration issue is cause by this.

@SebbeJohansson you should not use

This is likely a Vue 3 SSR behaviour. Try with https://stackblitz.com/github/nuxt-contrib/vue3-ssr-starter to see.

@MrEraxd maybe you are misunderstanding. The style tag I'm using in the last example isn't a normal style tag. It's one of the meta tags. Perfectly fine to use them in templates (since that's where they belong).
Your example isn't applicable for me since I need to add custom styling that are decided particular parts or fully coming from our cms. I understand that there are workarounds and such, but this issue is more to figure out if we can get something better that works. Mainly because a perfectly fine solution exists in nuxt2.
@danielroe I will check in vue-ssr when I have the chance. Sorry for not checking with that right away. It being in ssr is of course logical.

For what it's worth, I would recommend using useHead instead of the Style component.

For what it's worth, I would recommend using useHead instead of the Style component.
But using component :is="style" will not resolve the <Style> component - it will resolve the normal style tag, IIRC.

@danielroe is there a reason to use useHead instead of the Style component or is it just a preference?
And yes, <component :is="style"> does produce a normal style tag, which is what I would want.

@danielroe is there a reason to use one over the other, other than preference?
And yes, it does produce a normal style tag, which is what I would want.

Yes i can reproduce with vue + ssr.
https://stackblitz.com/edit/github-tzgxfc?file=src%2Fpages%2FHome.vue
I will make an issue there.


Suggestion: defaults property for yii\rest\UrlRule

Please add a defaults property to yii\rest\UrlRule same with yii\web\UrlRule. The property should allow to set up default $_GET parameters which automatically injected to the path always and independently. In yii\rest\UrlRule context it would be add the parameters to all generated rules.

What's the use case for these?

Different behavior of the same controller depending on additional parameters. For example we have shops table which related with standard user table by one (user) to many (shops) relationship. And purpose is to create two different paths to shops:

/shops - all shops in the system
/user/shops - shops of current user
Both path would be processed by the same controller. For implementing this, it needs to pass some additional parameter in the second case, for example "userId=current".

@yiisoft/core-developers thoughts?


⚠ Bofrost.fr has degraded performance

In 9a6b971, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 882 ms

Resolved: Bofrost.fr performance has improved in 9e26d65 after 1 hour, 43 minutes.


Add working PieCharts

PieCharts are not working in the statistic branch.

Pie charts are working now

Pie charts are working now


Adds payout module for safe interaction

@0xcodercrane is this approval needed because @3commascapital is technically part of the Ubiquity organization? I don't recall seeing this with brand new bounty hunters.

I also don't like approve and run, please check out protection policy of this branch

@0xcodercrane you should also be able to access the repo settings but unfortunately its not clear to me what is misconfigured.

Hmm, I guess its only needed for first time contributors so it should go without any approval/confirmation because we're approved @3commascapital 's first contribution. Looks ok!

Hmm, I guess its only needed for first time contributors so it should go without any approval/confirmation because we're approved @3commascapital 's first contribution. Looks ok!

Obviously this shouldn't be an issue because the other repo doesn't have this problem.

I couldn't see settings tab. I guess its related to permission setting for my account. Can you recheck my permission? @pavlovcik

Can you try testing his code and merging if its ok? @0xcodercrane

Can you try testing his code and merging if its ok? @0xcodercrane

I didn't get a chance to take a deep look on this PR. but my quick overview is that there are some stuff which need to be fixed/updated.  I will kick off reviewing soon if this PR is ready for review @3commascapital

Yeah, please do @0xcodercrane

hey @pavlovcik  @3commascapital . I am gonna keep the PR for a while. because a lot of checks are needed for safe interaction.

Hey, this PR will be closed due to inactivity during a long time - about 5 months.


Enable users to select preferences

Autocomplete now returns placeId along with address and coordinates
travelObjects now store placeId
Trip stores a default coordinate for main destination
Form component for adding user preferences
Add user preference form to trip setting form
Everything saves and retrieves properly with firebase

Please PR against where you branched off of (looks like SuggestionTests or QueryRankingFixes) rather than master to make the diff easier to read.


Arc enables SQL Server - missing --scopes from az ad sp create-for-rbac

Disclaimer: The intent of this "Bug report" templates is to address issues related to the Azure Arc Jumpstart scenarios, ArcBox and all other project ares. The Azure Arc Jumpstart team does not handle Azure Arc core product issues, bugs and feature requests and will try to assist on a best effort basis. For a core product issue or feature request/feedback, please create an official Azure support ticket or general feedback request

Scenario which you are working on
Arc enables SQL Server
Describe the bug
Missing --scopes from az ad sp create-for-rbac
To Reproduce
Steps to reproduce the behavior:

In one step, one should execute  az ad sp create-for-rbac -n "ArcSQLSP" --role contributor
With current az (2.35) this leads to an error about the missing --scopes option

Expected behavior
In the documentation, the command should be
az ad sp create-for-rbac -n "ArcSQLSP" --role contributor --scopes /subscriptions/

Thank you @sk-bln. This is something we will correct in the README guides for scenarios across the Jumpstart.


aio/rest_session.py crashing on 400 errors with a UnboundLocalError

Issue with SDK version 1.36.0 when, I am calling the createOrganizationAdmin, expecting back a 400 bad request error, but script is crashing with below trace.  reverting to SDK version 1.34.0 and error is handled properly.
...
add_result = await dashboard.organizations.createOrganizationAdmin(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/xxxxxxxxx/py/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 512, in post
async with await self.request(metadata, "POST", url, json=json) as response:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/xxxxxxxxxxx/py/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 137, in request
return await self._request(
^^^^^^^^^^^^^^^^^^^^
File "/home/xxxxxxxxxxx/py/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 275, in _request
message_is_dict
Specifically testing API call in postman and the response back I am getting is:
{
"errors": [
"Email<EMAIL_ADDRESS>is already registered with a Cisco Meraki Dashboard account. For security purposes, that user must verify their email address before administrator permissions can be granted here."
]
}
Python version installed
3.11.4
Meraki library version installed
1.36.0 (works properly in 1.34.0 and earlier))
Have you reproduced the issue with the latest version of this library? And with the latest version of Python?
yes
OS Platform
Linux
How can we replicate the problem you're reporting?
Add user to 1 org that does not currently exist, then add user to a second org before they validate and create account, should get back a 400 bad request error as described

@TKIPisalegacycipher, seems that this was caused by this commit: https://github.com/meraki/dashboard-api-python/commit/6d9ada0df4ad74a4c3f447982c4aa39c9db57433
message_is_dict is used in aio/rest_session but it is never set. In sync code (rest_session) this variable is set as follows but this code block is missing from aio/rest_session:
try:
    message = response.json()
    message_is_dict = True
except ValueError:
    message = response.content[:100]
    message_is_dict = False

Hi @dpnetca are you still running into this issue? I've added debug logging here, so if so can you please provide the full debug log on the latest version of the library? Feel free to redact IDs and serial numbers.

yes, tested with 1.36.0, 1.37.1 and 1.37.2 and I still get errors, though it looks like it may be slightly different with 3.17.x from 3.16.x
$ pip list | grep meraki
meraki             1.37.2

traceback:
$ python main.py admin.add

Traceback (most recent call last):
  File "/home/xxxxxx/code/py/work/momapy_cli/main.py", line 22, in <module>
    asyncio.run(admin_add())
  File "/home/xxxxxx/.pyenv/versions/3.11.4/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/.pyenv/versions/3.11.4/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/.pyenv/versions/3.11.4/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/admin/add.py", line 91, in admin_add
    results = [await task async for task in tqdm_tasks]
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/admin/add.py", line 91, in <listcomp>
    results = [await task async for task in tqdm_tasks]
               ^^^^^^^^^^
  File "/home/xxxxxx/.pyenv/versions/3.11.4/lib/python3.11/asyncio/tasks.py", line 605, in _wait_for_one
    return f.result()  # May raise f.exception().
           ^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/admin/add.py", line 29, in add_org_admin
    add_result = await dashboard.organizations.createOrganizationAdmin(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 505, in post
    async with await self.request(metadata, "POST", url, json=json) as response:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 134, in request
    return await self._request(
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/xxxxxx/code/py/work/momapy_cli/.venv/lib/python3.11/site-packages/meraki/aio/rest_session.py", line 273, in _request
    if message_is_dict and 'errors' in message.keys() \
       ^^^^^^^^^^^^^^^
NameError: name 'message_is_dict' is not defined

@TKIPisalegacycipher
Difference seems to be here, in the sync rest_session code for 4xx errors the message_is_dict is being initialized to either true or false
https://github.com/meraki/dashboard-api-python/blob/86a565890b1ed3e7fd8b8a50e5c4f5df4decda40/meraki/rest_session.py#L270
                    try:
                        message = response.json()
                        message_is_dict = True
                    except ValueError:
                        message = response.content[:100]
                        message_is_dict = False

However, in the equivalent section in the aio library the message_is_dict is not initialized
https://github.com/meraki/dashboard-api-python/blob/86a565890b1ed3e7fd8b8a50e5c4f5df4decda40/meraki/aio/rest_session.py#L253
                    try:
                        message = await response.json(content_type = None)
                    except aiohttp.client_exceptions.ContentTypeError:
                        logging.debug(f"message is {message}")
                        logging.debug(f"message is dict? {isinstance(message, dict)}")
                        try:
                            message = (await response.text())[:100]
                            logging.debug(f"message is {message}")
                            logging.debug(f"message is dict? {isinstance(message, dict)}")
                        except:
                            message = None

Sorry for the multiple messages, but one more thing of note.  looking back at at the 1.36.0 code before the debug was added I can see message_is_dict was initiated here partially, but missing a few things ( see my added comments):
                # 4XX errors
                else:
                    try:
                        message = await response.json(content_type = None)
                        # message_is_dict = True should be set here
                    except aiohttp.client_exceptions.ContentTypeError:
                        try:
                            message = (await response.text())[:100]
                            message_is_dict = True   # this should be False not True
                        except:
                            message = None
                            message_is_dict = False

quick test and it looks like the issue is resolved with 1.37.3.  thank you!!


v1.2.0 not found from jcenter

Tried to fetch the v1.2.0 from jcenter but doesn't work. Last version available is 1.1.2 from jcenter.

Hey @chrissom, looks like jCenter requires a Sonatype username to continue deploying (which seems like a new requirement since we last updated jCenter). I've submitted a request to them and will let you know once we're able to move forward :-)

Good 👍 Keep me in touch when v1.2.0 gets available.

I don't suppose you know how to create a Sonatype username do you?! It's not something we've done before and it's not clear how you supposed to...

Agreed, it's not obvious. Here's the how to start.
Basically, you have to create a JIRA account and submit a ticket. After that, ping Sonatype by email or Twitter, to validate your ticket faster.
@blackleg your image link is broken.

Yep, thanks @chrissom. Already on it :-) And have updated Bintray but Sonatype saying it's not working correctly. Anyway, we're working it - sorry for the delay!

@chrissom we're getting a "Invalid pom path mangopay2-java-sdk-1.2.0.pom" error when syncing from Bintray to Sonatype. The POM file is here - I can't see anything wrong (and nor can Sonatype) but if you've done this before and see something incorrect, do let us know :-)

I guess we should add the developers section but that doesn't seem to particularly tally with the error...

@hobailey hard to help at this step without getting access to all details. Looks like it's not a big issue.

@hobailey Check developer email start tag:
<developers>
	    <developer>
	      <name>Hugo Bailey</name>
	      <id>mangopay</email>
	    </developer>
	  </developers>

I already fixed that, but no luck :-( Could I have one of your Bintray usernames to add you for you to take a look do you think?

@hobailey Did you get some help from your Sonatype issue?

They're not too helpful unfortunately (here's the ticket) but the say the POM file "looks fine". Will try and take another look at this today.

I have this library: Java Utilities published in sonatype.
Probably you need add the javadoc and sign the library before deploy it in Bintray.
I think it is better that you deploy it directly to Sonatype.

Hey quick update - we're still working on this, and it hasn't been forgotten, I promise :-)
(There's just been quite a few changes to jCentral since our last version release so it's taking a while to get in line on our side)

Any news @hobailey?
Btw, I tried to build the code (tag v1.2.0) and got 1 error during tests:
Failed tests:   Test_Reports_All(com.mangopay.core.ApiReportsTest): expected:<1785265[7]> but was:<1785265[5]>

Is it critical? I would like to use this local jar meanwhile you are fixing this issue?

Hey @chrissom, it should now be deployed, yes. We're going to update the readme and a few bits in this repo tomorrow.
As for that failing test, it's nothing serious (and a problem with the test implementation, rather than the API).

Nice 👍  I close the issue.

Great, thanks for the feedback, and sorry again that it took a while to get there.


Closing for now.


Render data hash with string keys, take 2

Reverts joeldrapper/phlex#419, which reverted #418 which I accidentally merged. I’m copying below the original description from #418, since this PR is a replacement for that:
from @djfpaagman
I was building a component with some Stimulus data- attributes and noticed you can't use string keys for the data hash, for example:
def template
	div data: { "name_first_name" => "Joel" }
end

will give:
describe Phlex::HTML with string keyed hash attributes it dasherizes the attributes test/phlex/view/attributes.rb:25
        ⚠ NoMethodError: undefined method `name' for "name_first_name":String
                /Users/dennis/Code/phlex/lib/phlex/html.rb:357 block (2 levels) in _build_attributes

I'm opening this PR as a starting point. I think using to_s has some downsides as it makes a copy of the string/symbol every time so memory wise it's not a great solution. But i'm also not sure if a class check is worth it either, probably most of the times a hash with symbol keys will be used.
What do you think?

@djfpaagman I think Phlex should support nested string keys, but this implementation isn't quite right. We shouldn't dasherize keys when they are already strings that way string keys provide a way to use real underscores. If you want dasherization, but need to use other characters like : (for Alpine), you can alway use a special symbol literal, e.g. :"my_very:special_key".

Great point, I just opened an issue for that here. https://github.com/joeldrapper/phlex.fun/issues/11


Max: Tweaks on ValidateMaxContents

Changelog Description
This PR provides enhancements on ValidateMaxContent as follow:

Rename ValidateMaxContents to ValidateContainers
Add related families which are required to pass the validation(All families except Render as the render instance is the one which only allows empty container)

Additional info
n/a
Testing notes:

Create all instances except render
Publish
If the OP data of the container inside the instance is empty, it wont pass the validation

Would ValidateInstanceHasMembers be better?
Also, note that "container" is usually used for loaded content and here we are talking about publish instances.

however not working for Pointcloud Instance and gives following error in that particular case (it probably validates well the content if not empty tho)

This is the bug from the point cloud extractor, not related to this PR.


Delta smoothing - fix overflow for long frames

Extremely long frames caused by suspending and resuming the machine could result in an overflow in the delta smoothing because it uses 32 bit math on delta values measured in nanoseconds.
This PR puts a cap of a second as the maximum frame delta that will be processed by the smoothing, otherwise it returns the frame delta 64 bit value unaltered.
I've also converted all internal math to use 64 bit explicitly (except counters). This is probably overkill but it might help avoid any future bugs, and it's not a bottleneck area so there's no real downside.
Fixes #51482 (untested, but looks like the source of the bug)
Notes

There are a number of ways of fixing this, we could for instance just cap the maximum delta, however that could make programs that depend on 'real time' go out of sync with long frames.
Not processing long frames in the delta smoothing is equivalent to turning it off for one frame. As it is based on deltas, it should recover perfectly on the next frame, as if the long frame had never happened.
We could alternatively use 64 bit math throughout the smoothing, but this is not necessary, smoothing is going to turn off anyway with such long frame times.
Rather confusingly the bug occurs even when smoothing is off. This is because the smooth function is called before it checks for the off condition, and the conversion to int32_t occurs in the function call.

Thanks!


Remove commented code to make codeql happy

Seems pretty reasonable, although I'm confused as to why codeql isn't respecting the syntactic value of comments--it obviously needs to parse various C and C++ standards in order to get this far, right? Is this a known behavior of codeql?

Codeql flags commented out code as an issue, for example: https://github.com/DataDog/ddprof/security/code-scanning/52


Plan id is not updating after billing

I have setup a fresh app and using billing feature, the app works fine and also perform the billing successfully, but after payment, the plan_id is not updating in the user table
Also i tried to manually edit it using $user->plan_id = 1; $user->save() which returns me true, still it is not updating

Duplicate of #1002


"handler is not defined".

Hello, I have another problem: "handler is not defined".
ReferenceError: handlers is not defined
at eval (eval at getRouteExports (webpack-internal:///(rsc)/./node_modules/@omer-x/next-openapi-json-generator/dist/index.js),
<anonymous>:9:15)
at getRouteExports (webpack-internal:///(rsc)/./node_modules/@omer-x/next-openapi-json-generator/dist/index.js:1:2756)
at async t.default (webpack-internal:///(rsc)/./node_modules/@omer-x/next-openapi-json-generator/dist/index.js:1:5643)
at async GET (webpack-internal:///(rsc)/./src/app/api/swagger/route.ts:12:22)

can you help me? please
I've uploaded a screenshot to show you the tree-like nature of my routes.

Hello again, I think you put something other than route handler in one of your routes. I pushed an update that will help you to determine what is the source of the error.
please update and let me see the source of error
npm i<EMAIL_ADDRESS>

the error comes from this export, but this one I can't modify, it's managed by next-auth
An error occured while evaluating the route exports from "C:\Users\nordi\Desktop\newproj\batisi\src\app\api\auth[...nextauth]\route.ts"

Oh I see...
They manipulate the route handler as the same way i do
import NextAuth from "next-auth"

const handler = NextAuth({
  ...
})

export { handler as GET, handler as POST }

I could fix this problem simply ignoring next-auth routes. But I assume you want them to appear in OpenAPI .json & UI
I don't know how to make them play together in harmony since I'm not familiar with next-auth.
I'll look into this when I have more free time. Thanks for the heads up!

export const { auth, handlers, signIn, signOut } = NextAuth({
    adapter: PrismaAdapter(prisma) as Adapter,
    session: { strategy: "jwt" },

    ...authConfig,

    callbacks: {
        /* @ts-ignore */
        async session({ session, user, token }) {
            if (!session) return;
            try {
                const searchUser = await prisma.user.findFirst({
                    where: {
                        id: token.sub
                    }
                })

                /* @ts-ignore */
                session.user = {
                    ...session.user,
                    ...searchUser
                }

                return session
            } catch (error) {
                console.error(error)
            }
        },
    },
    pages: {
        signIn: "/",
    },
    secret: env.NEXTAUTH_SECRET
})

import { handlers } from "@/auth"
export const { GET, POST } = handlers

OK, because v5 te next auth is used like this

It should be possible to do something like this
import { handlers } from "@/auth"

export const { POST } = createRoute({
  operationId: "...",
  method: "POST",
  summary: "...",
  description: "...",
  tags: ["..."],
  action: async ({ body }) => {
    const request = new Request("...", {
      method: "POST",
      body,
    });
    return handlers.GET(request)
  },
  responses: {
    200: {
      description: "...",
      content: z.object({
        success: z.boolean()
      })
    },
    404: { description: "..." },
  },
});

Then json-generator will not complain about handlers since they're part of action But you need to figure out how to pass the correct url with search and query params

If I leave api/auth, I can create an api/v1/ folder...
so it will retrieve only those inside? or is it set to retrieve all in /api?

I'm not sure what is your question about. But let me explain what json-generator and route-handler do
route-handler injects some metadata into your next.js route handler function (GET, POST etc.) and json-generator converts that metadata into openapi.json
Also route-handler parses request body, query & path params with zod and provides them as typed object for the action

export async function findAppFolderPath() {
  const inSrc = path.resolve(process.cwd(), "src", "app");
  if (await directoryExists(inSrc)) {
    return inSrc;
  }
  const inRoot = path.resolve(process.cwd(), "app");
  if (await directoryExists(inRoot)) {
    return inRoot;
  }
  return null;
}

is it possible to define the api/v1 application route so that it only takes into account the routes in a specific file?

Yes, it is possible. I'll see what i can do about it later today.

    const spec = await generateOpenApiSpec({}, {
        routesPath: "src/app/api/test"
    });
    ```

    https://github.com/antonind72/next-openapi-json-generator/tree/dev

 I've modified it so that we can have the option of defining a specific path, but by default it stays on src or src/app.
on the other hand, if you make changes to the route, save and refresh the page, you get this error:

otherwise, if you restart the project, there's nothing to worry about, it just works.

⨯ TypeError: _omer_x_next_openapi_json_generator__WEBPACK_IMPORTED_MODULE_2___default(...) is not a function
at DocsApi (admin/docs/api/page.tsx:19:98)
at stringify ()
digest: "1678211790"
9 |
10 | export default async function DocsApi() {

11 |     const spec = await generateOpenApiSpec({}, {
|                                            ^
12 |         routesPath: "src/app/api/test"
13 |     });
14 |     return (
GET /admin/docs/api 500 in 1399ms

I released an update
npm i<EMAIL_ADDRESS>
now you can use it like this
const spec = await generateOpenApiSpec({}, {
    include: "**/route.ts"
    exclude: "excluded-path/route.ts"
});

i have already error this :
const spec = await generateOpenApiSpec({}, {
            include: ["**/route.ts"],
            exclude: ["auth/route.ts"]
        });```

An error occured while evaluating the route exports from "C:\Users\nordi\Desktop\newproj\batisi\src\app\api\auth[...nextauth]\route.ts"
⨯ ReferenceError: handlers is not defined
at async DocsApi (admin/docs/api/page.tsx:19:18)

should be like this
exclude: ["auth/*/route.ts"]

or
exclude: ["auth/**/route.ts"]

I always get the error whether it is for one or the other
⨯ ReferenceError: handlers is not defined
at async DocsApi (admin/docs/api/page.tsx:19:18)
digest: "3626192051"
GET /admin/docs/api 500 in 561ms

you need to add the same rule to generateOpenApiSpec in src/app/page.tsx

Is it really like that?
const spec = await generateOpenApiSpec({}, {
    exclude: ["auth/**/route.ts", "admin/docs/api/page.tsx"]
});

no. only route.ts file paths should be defined in include/exclude lists

May I see this file src/app/(pages)/admin/docs/api/page.tsx

import ReactSwagger from "@/components/docs/api/ReactSwaggerComponents";
import { Metadata } from "next";
import generateOpenApiSpec from "@omer-x/next-openapi-json-generator";

export const metadata: Metadata = {
    title: "API Docs",
    description: "API Documentation with Swagger for Nextjs",
};

export default async function DocsApi() {
    const spec = await generateOpenApiSpec({}, {
        exclude: ["auth/**/route.ts", "/(pages)/admin/docs/api/page.tsx"]
    });
    return (
        <section className="container w-full flex flex-col gap-4 justify-between max-w-6xl p-4 z-10 bg-slate-400 h-full">
            <ReactSwagger spec={spec} />
        </section>
    );
}

I checked your screenshot again. I think it should be
exclude: ["api/auth/**/route.ts"]

is work thanks you !

I forgot to ask, with the basic api with nextjs 14 and next-auth v5
we have to go through req.auth, can we still access the request?

I was thinking about adding request to action as second parameter for some rare cases like this one.
You're welcome to make a PR to next-openapi-route-handler for that or you need to wait for tomorrow.


chore(main): release 0.4.35

:robot: I have created a release beep boop
0.4.35 (2024-04-09)
Continuous Integration

build: Test bin-leading-dir and leading-dir options (5b18005)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/linrongbin16/cargo-ci-template.rs/releases/tag/v0.4.35 :sunflower:


Multiple simultaneous connections cause reset after many PHY updates

This was found using blestress app on nrf52840 DK. When test 7 (PHY updates from tx device - central) is executed it will cause silent restart during test 9 (connect and keep as many active connections as possible). Test 8 (PHY updates from rx device - peripheral) has no such influence. There is no visible sign of crash: no events captured by debugger, HCI activity just stops - this is most likely just sign of broken RTT connection on port. App is restarted just like after regular crash or reboot.

Hej, I was running in similar issues when running a node with many multiple connections. I got it to work, by increasing NimBLE's buffer space -> as I was running on RIOT, i increased MSYS_1_BLOCK_COUNT as much as my RAM would allow me to. But I guess this could be easily done somehow on Mynewt as well, right? With this I was successfully running node with 14 simultaneous connections...
However, I could never figure out, where and why NimBLE crashes once it runs out of buffers, nor if it is the controller or the host part causing the trouble. But I think on the long term it would be good to locate this issue and fix it, so maybe someone else has some more luck in finding it?!

this will fix it https://github.com/apache/mynewt-nimble/pull/1081
rx side was reset due to watchdog timeout caused by broken callouts queue in test 7. there was callout enqueued which was then wiped out and it expired somewhere during test 9, and it could not be removed from queue so it "expired" over and over again causing watchdog reset.


Sample Documentation for Android Sample

@sherenewso2 @gomathyk will help on reviewing final content.

Refer
Quick-start quide docs:
https://github.com/wso2/docs-is/blob/new_restructure/en/docs/quick-starts/java-sample.md
Side-panel docs:
https://github.com/wso2/docs-is/blob/new_restructure/en/docs/quick-starts/java-sample.md


 Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check compose contract convention. It must follow conventions described here.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on a phone device/emulator.
[x] I have tested on a tablet device/emulator.
[x] I have tested on a large screen device/emulator.
[x] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Delivery seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/3c35dbc8-298b-403a-a0e7-31a0c3ed14ca/artifact/b5d459e3379b5885/p/717600fe429eb2e0df9d87b1333587d3

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/c1043e67-b8f7-4c11-a337-b6db265d9b2c/artifact/6f595da3a6ed29a4/p/6c940d5c318d794424a0e25427770b7f

👍

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/314333ed-50db-49a6-b7b2-68f0ce0ce356/artifact/9a0096369bfcf2e9/p/bf220ff579a6469e009bdaa5648d47e2


Feature645: Batch processing ( insert, update, and delete)

This PR is a remake of PR#663
it was required due to some trouble while signing CLA

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: sviezypan:x: B.MadyB.Mady seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Unicode error

Dear Support Team,
Currently our customer is facing this unicode error when launching our Picoscan launch file, sincerely seek for your assistance to advise on this enquiry.
![

Thanks!

Thanks for your feedback. The error message "encoding with idna codec failed" means that a DNS query can not be resolved. Most likely the IP address given by parameter udp_receiver_ip:=<IP_ADDRESS> is incorrect.
Parameter udp_receiver_ip must be the ip address of the computer running sick_scan_xd, see https://github.com/SICKAG/sick_scan_xd/blob/develop/doc/sick_scan_segment_xd.md for details. This parameter has to be configured specifically for each system. Use e.g. ipconfig -a to find the ip address.
Parameter udp_receiver_ip:=<IP_ADDRESS> is used in some examples, but is most likely not the correct ip address of your customers computer. If the picoScan lidar has ip address <IP_ADDRESS>, make sure that the lidar and the computer running sick_scan_xd use the same subnet.
Please check the ip addresses of the lidar and the customers computer. Do not hesitate to reply in case the problem remains.

Dear Support,
Thanks for the prompt response and explanations.
Appreciated =)


WIP - Respecting resource limits and requests during build.

This patch restores the functionality of restricting how much resources
a build can consume. Some extra test cases got added to validate the
functionality. To fix the problem function ConvertJSON() had to be
adapted to support maps also.
Tests added for ConvertJSON() function were designed with the old
behavior in mind as this function used to work only for slices fail
with anything else.

/retest

/assign @adambkaplan

/cherrypick release-4.1

/lgtm


Add coc error/warning highlight

fixes issue where there is no indicator where in the line the warning/error is (only indicated in the gutter)
this is synonymous with the Ale warning/error highlights and adds the undercurl to them

closing for now- after updating I see underlines for these warnings/errors

oh ok, reopened :)


Remove alpha-feature flag for Namespaced Brokers

Is this ready all the way through? Can the feature flag be removed?
@eriknelson thoughts?

@jberkhahn I'd consider it feature complete, and we've had a few people experimenting with success. I don't have any concrete reason to keep it behind the gate, except that it simply hasn't had a ton of usage in the wild yet.

an alternative is to change the default to enabled for a few releases.
not sure what happens if you try and flag a a flag that doesn't exist. might cause problems for those not using the helm charts.

not sure what happens if you try and flag a a flag that doesn't exist. might cause problems for those not using the helm charts.

I'm pretty certain the server will bomb out with unrecognized flag error.   I think we just toggle it to default to true for now.  This was done with Originating Identity:  https://github.com/kubernetes-incubator/service-catalog/blob/f6f0e41fae6c4f1bdc5c507942ee7f1719555a19/pkg/features/features.go#L83-L90

Sounds reasonable to me.
On Tue, Jul 31, 2018 at 1:16 PM Jay Boyd<EMAIL_ADDRESS>wrote:

not sure what happens if you try and flag a a flag that doesn't exist.
might cause problems for those not using the helm charts.
I'm pretty certain the server will bomb out with unrecognized flag error.
I think we just toggle it to default to true for now. This was done with
Originating Identity:
https://github.com/kubernetes-incubator/service-catalog/blob/f6f0e41fae6c4f1bdc5c507942ee7f1719555a19/pkg/features/features.go#L83-L90
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/issues/2244#issuecomment-409298634,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZFNZF3jNBJTYxyGOWovj8LKsMkRr2wks5uMJC7gaJpZM4VnGkV
.


Getting PDKPin.link

#44
The url property on PDKPin returns the internal Pinterest url of the pin, my question is I want to access the Pin's source URL, which the documentation describes as a link property.  It is writable via pinWithImageURL (see below) but not readable currently :
+ (void)pinWithImageURL:(NSURL *)imageURL
                   link:(NSURL *)sourceURL
     suggestedBoardName:(NSString *)suggestedBoardName
                   note:(NSString *)pinDescription
            withSuccess:(PDKUnauthPinCreationSuccess)pinSuccessBlock
             andFailure:(PDKUnauthPinCreationFailure)pinFailureBlock

If anyone has the chance can you please help me with this?  Until I can access the source URL, I'm forced to get the redirect myself which is really affecting performance of my app.
Thank you!

@gesabo Unfortunately this SDK is inconsistent with our API docs (see #61). pin.url is the destination URL of the Pin; pin.pinURL is the pinterest.com URL of the pin. I think you are looking for pin.url with this SDK.
Does that answer your question?

Thanks @connor for responding so quickly!  I'm calling pin.url here and this is what I'm getting:
https://www.pinterest.com/r/pin/186195765822444484/4801566892554728205/532bb0b6e449fd7997efc1394c5f134906aaead1f04e44bfc722771d0ecd6671
https://www.pinterest.com/r/pin/186195765821108374/4801566892554728205/4b84455795601739d9a8cd52bbe6e6f9b257cfb32544c4a9f4cbc04fe6a232c4
https://www.pinterest.com/r/pin/186195765819695584/4801566892554728205/45e575fad22f149dae190d552c77e78ae1596fff8b8becdff111021b7fd1574c
https://www.pinterest.com/r/pin/186195765818872419/4801566892554728205/ab797a434824fdb80e22712a0cce102fa938fc27c1f9c5f0fd11e1f9362515cb

On line 38 in the SDK
 _url = [NSURL URLWithString:dictionary[@"link"]];
and I don't see anything that would pulldown the "url" ?

@gesabo Apologies for the confusion. While those do link to pinterest.com, it's just a proxy to the destination URL that we have implemented for logging purposes.

@connor ah, thank you.  Just so I'm clear then there's no way to get the pin's source url from the SDK currently?

Correct – right now this is all that is publicly exposed. I'm talking w/ our dev-platform team to see if we'd be able to expose the underlying link but there are some logging implications, etc that we'd need to sort out before doing so. I'll post back here if I learn anything new!

I'd really appreciate it!  Thanks again!


Apply cargo fmt.

What it says on the tin. No code changes.
This builds on #94, but obviously it's no problem to re-do this independently if that isn't accepted.

Thanks for this, I think this is a good idea. I've rebased, added a rustfmt.toml with
wrap_comments = true
error_on_line_overflow = false
use_field_init_shorthand = true
condense_wildcard_suffixes = true
reorder_imported_names = true
reorder_imports = true

and re-applied rustfmt.

That all looks great! Do you need unstable_features = true in the rustfmt.toml?
The only thing I wonder about is the wrap_comments bit. That's something the rustfmt docs seem a bit hesitant to recommend. I think the ideal would be for rustfmt to complain about long comment lines, but leave the actual fix to a human. I experimented a little bit but wasn't able to get cargo fmt or rustfmt to reformat comments or complain about them...

I'm using rustfmt nightly via rls. The comment wrapping is currently fairly unaggressive sometimes to get it to work you need to put all the comments on one line again. So it seems harmless for now, I guess we can disable it again if we find issues.


Getting recent events at mid-night returns an empty array

What were you trying to achieve?
Accessing the recent events of every devices at the start of the day (i.e. between mid-night and about 2am) returns an empty array.
What are the expected results?
Getting recent events should not return an empty array (should not depend on the day) unless there are completely no records in the events collection
What are the received results?
If applicable, add screenshots to help explain your problem.
What are the steps to reproduce the issue?
Query this GET endpoint http://localhost:3000/api/v1/devices/events?tenant=kcca&recent=true&startTime={}&endTime={}&limit=100 at mid-night. Remember to replace the startTime and endTime with the right date corresponding to the mid-night date.
In what environment did you encounter the issue?

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Any other information you would like to share?

This was resolved. cc: @ja-odur


Enhances exception handling across functions: Replace printStackTrace() with logging using java.util.logging for improved error management and traceability.

In this update, I have improved exception handling across various functions in the codebase. The previous usage of printStackTrace() has been replaced with a more robust logging approach using java.util.logging. This enhancement not only provides better error management but also enhances traceability in case of exceptions, making the codebase more maintainable and production-ready.

Great implementation, thank you improving error handling @AhmadHassan71 👍

Thank you, @FarazRashid! 🚀 I'm glad you liked the implementation and appreciate the focus on improving error handling. If you have any more feedback or ideas, feel free to share. Your encouragement means a lot! 👍😊


[BUG] Wrong category size of Bar with min ,max options.

Hi! thank you for provide excellent chart library.
I would like to report some issue.
Current Behavior
With min (or max) option, Category size probably calculated from the total number of labels, not the number of labels displayed.
Then, the size of bar will be smaller and shift ,even though categoryPercentage and barPercentage is 1.
(also Issues #3506 plugin added)

Steps to Reproduce (for bugs)
jsfiddle

Chart type is "bar"
Set min or max, both also.
When executed, the bar position will be smaller and shift left. (You can see easily when categoryPercentage and barPercentage is 1 )
line is work.

Environment
Chart.js version : 2.4.0
Browser name and version : Microsoft Edge 38.14393.0.0
Link to my project : https://jsfiddle.net/d29yoL8u/5
Added Issues #3506 duplicate of #3491 and #2870

@etimberg, I can fix this one.
I have a question in regards to ticks.min option, in the documentation it only shows to allow Number. Will we be changing that to allow string datatypes (ex. 'March') ?

@Jareechang feel free to work on this :smile: Please include test(s) with your fix.
I think ticks.min can be 'March' for the category axis (the one in question here)

ok, sounds good! i'll do that 👍

Probably, I think this problem can be solved with this correction.
Possible Solution
Delete the following two codes.
https://github.com/chartjs/Chart.js/blob/master/src/controllers/controller.bar.js#L142-L145
https://github.com/chartjs/Chart.js/blob/master/src/controllers/controller.bar.js#L469-L472
With this fix, it becomes as follows.

jsfiddle
Environment
Chart.js version : 2.4.0
Browser name and version : Microsoft Edge 38.14393.0.0
Link to my project : https://jsfiddle.net/2eq6jxL7/
(I have poor English. so I am sorry if I am rude.)

@KoyoSE that's a great fix. Could you PR it and add some tests?

nice solution @KoyoSE.
I was playing around with the code as well. I came up with this solution code section, we can just add if min or max defined then it'll center the bars. You can maybe try this one if it starts breaking the api.
Another issue
I found another bug while playing with the jsfiddle. The tooltip label is incorrect when min  is defined.
Should I open another issue for this ?

@Jareechang please open another issue for the tooltip issue

Hi @etimberg
I will try adding PR and Test. However, I am still a beginner in JavaScript development. And I recently started using Github. Please give me some time. :)
Hi @Jareechang
Oh I also checked the code section.
but.If min or max defined in that section,
Probably it have to write processing to recalculate the mistaken fullBarWidth in getRuler function.


chore(WIP): Support plugin block in Beta infobox

Overview
What I've done
adding plugins query

What I haven't done
graphql mutation error

How I tested
Which point I want you to review particularly
Memo
According to the error message, the addNLSInfoboxBlock mutation is designed to accept only extensions of type PluginExtensionType.Block. Therefore, attempting to add an InfoboxBlock type will result in an error. fixing Backend is needed to resolve this issue.

We have already support beta's infobox plugin block with extension type infoboxBlock.


The email address<EMAIL_ADDRESS>is unreachable

The email address<EMAIL_ADDRESS>is unreachable (it's provided at the top of the page):

If you have and specific issues, questions or find any bugs, drop us a line at<EMAIL_ADDRESS>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 714093b2-eb5f-8cb2-a32c-7a8be2b4603f
Version Independent ID: 9d5faf12-46ae-713a-5ea2-5dba7cbeb63d
Content: Azure Media Player Overview - Azure Media Player
Content Source: articles/media-services/azure-media-player/azure-media-player-overview.md
Service: media-services
Sub-service: media-player
GitHub Login: @IngridAtMicrosoft
Microsoft Alias: inhenkel

@ogliznutsa Thank you for your query . We will investigate and update the thread.

@ogliznutsa Thanks for raising this, this is now changed as " If you have and specific issues, questions or find any bugs, please file a support ticket  using the Client Playback category. "  Thanks again.


Update evaluate_bots.py

bot.step(state) is assumed to return an Action here

Thanks. I have merged it manually (i.e. I did the change) internally, and will be available at the next release.


Update to Kubernetes 1.16.2

Dependent on https://github.com/kinvolk/terraform-render-bootkube/pull/23
Update etcd to v3.4.2
Update the provider versions
Update the terraform ct provider to 0.4.0
Update Kubernetes to 1.16.2
Update Calico to 3.9.2
Remove labels node-role.kubernetes.io, kubelet cannot set these labels using the flag --node-labels. This is enforced as a security feature. But this can be set manually by cluster-admin.

Dependent on https://github.com/kinvolk/terraform-render-bootkube/pull/23

@rata

I want to emphazize we should not merge this until we are absolutely sure that it doesn't break other things using the deprecated stuff. We do not want to have a master we can't use. I'd like to really check that everything works with this before approval :-D

What do you mean by other things? I have tested all the components and made necessary upgrades to them.

@rata
What do you mean by other things? I have tested all the components and made necessary upgrades to them.

Perfect! This is what I meant! Just make sure all runs fine before merging (don't want to have a broken master). That is all :)


Cache clearing problem

Hi.
I have this run with cache config:
angular
    .module('app.main')
    .run(restangularRuns);

function restangularRuns ($cacheFactory, Restangular, apiConfig) {
    var cache = $cacheFactory('http');

    Restangular.setBaseUrl(apiConfig.BASE);

    Restangular.setDefaultHttpFields({ cache: true });

    Restangular.addResponseInterceptor(function (data, operation, what, url, response) {
        if (operation === 'put' || operation === 'post' || operation === 'delete') {
            cache.removeAll();
        }

        var extractedData = data.data;
        // var extractedData = response.data;

        return extractedData;
    });
}

Unfortunately I think that GET cache isn't cleared properly, as after e.g. POST request I don't see any changes (after going to a specific state) until I refresh the page.

I've done something similar, and I'm using
$cacheFactory.get('$http')

Does that work for you?

Works @bostrom ! Thank you very much.. :)

@archasek good 👍
Are you able to close this issue?

I don't think so :(


fix/SPRFRML-131: increasing the font of the stories

The purpose of this pull request is to increase the font size for the stories on the Stories tab.
Notes
This PR doesn't fully close SPRFRML-131 since there are also some other things to do in iris_storybook on the other repo
Screenshot

Ticket
SPRFRML-131

You will need to make a PR in Storybook and update the pubspec to consume this.

@russell-sf I have to open a PR to update the WIP statuses, I'll include this change there. I'll just use the following setup:
# https://pub.dev/packages/dashbook
dashbook:
  git:
    url: https://github.com/Alkami/dashbook.git
    ref: master


Initial Channels not showing up for new user

"createdAt":"2020-03-09T14:47:28.181Z","updatedAt":"2020-03-09T14:48:26.627Z" are not the same after checking heroku logs... I wonder if updatedAt changes in the beforeSave hook?
2020-03-09T14:48:26.649374+00:00 app[web.1]: info: afterSave triggered for _User for user DTGchymSSS:
2020-03-09T14:48:26.649378+00:00 app[web.1]:   Input: {"username":"615692a7-06fc-44b2-9315-d3d8c8eaad3a","phoneNumber":"12063539874","language":"en","createdAt":"2020-03-09T14:47:28.181Z","updatedAt":"2020-03-09T14:48:26.627Z","familyName":"Bensta","givenName":"Benny","ACL":{"*":{"read":true},"DTGchymSSS":{"read":true,"write":true}},"smallImage":{"__type":"File","name":"cef71ae7b967613a9bab44f78dcf03a5_small_image.png","url":"http://benji-backend.herokuapp.com/parse/files/BenjiApp/cef71ae7b967613a9bab44f78dcf03a5_small_image.png"},"objectId":"DTGchymSSS"} {"className":"_User","triggerType":"afterSave","user":"DTGchymSSS"}

Cannot use beforeSave hook to create the channels as the user identity is not determined yet (and could still fail)
TBH --- Parse-Server is way too limited/opinionated and will not scale with this project. Seems better for a quick sandbox project but not a production application.


Add "How do I pick?" Page

We should have a simple how do I pick page with at least the content from the slides, that is:

The tables about data type --> data format
The table about data format --> adoption
Hard limitations of each (for example, kerchunk is limited to the chunk shape of it's underlying data files)
Considering the user - how will they use the data? Can you ask users to use a new format?

here are some other formats that are not really cloud formats

geopkg
...

@wildintellect mentioned geopkg has many layers which makes it harder to understand and use than flatgeobuf

The text at the bottom of the welcome page should be moved to this or elaborated on https://guide.cloudnativegeo.org/#questions-to-ask-when-generating-cloud-optimized-geospatial-data-in-any-format

Discussed more the content with
@kylebarron @abarciauskas-bgse
This NEW page should include the How and Why of choosing a format based on use case (general questions to ask oneself)

What is the structure of the data?
How are users expected to use/interact with the data?
What are the most obvious trade-offs between 2 similar formats one might choose between.


[testing-helpers] fixture does not wait for updateComplete and componentOnReady()

For now asynchronous fixture does not wait for updateComplete and componentOnReady() despite it is described in the documentation.
After some investigation I found an issue: it happens because fixture and fixtureSync use synchronous variants of nested fixtures, litFixtureSync and stringFixtureSync.
I'm going to create a PR that will fix this issue.

fixed in latest release 💪


Installing conda will bypass corporate proxy leading to build failure

Hi, using the anaconda feature has the following line, which looks like it spawns a new shell that the docker env http_proxy settings are not being used any more. As a result the build fails with timeout getting the package. I have to resort to manual installation for this feature.
https://github.com/devcontainers/features/blob/4697d25cc57cb79fd37845147d6f9adb6044b8c4/src/anaconda/install.sh#L100

Hi 👋
Thanks for reporting!
I believe the following change should fix this 👇
su --login -c "export http_proxy=$http_proxy; export https_proxy=$https_proxy; wget -q https://repo.anaconda.com/archive/Anaconda3-${CONDA_VERSION}-Linux-x86_64.sh -O /tmp/anaconda-install.sh"

@Superskyyy Let me know what you think, will shortly open a PR with these changes.

Hi 👋
Thanks for reporting!
I believe the following change should fix this 👇
su --login -c "export http_proxy=$http_proxy && export https_proxy=$https_proxy && wget -q https://repo.anaconda.com/archive/Anaconda3-${CONDA_VERSION}-Linux-x86_64.sh -O /tmp/anaconda-install.sh"

@Superskyyy Let me know what you think, will shortly open a PR with these changes.

Sounds great!

Hi, using the anaconda feature has the following line, which looks like it spawns a new shell that the docker env http_proxy settings are not being used any more. As a result the build fails with timeout getting the package. I have to resort to manual installation for this feature.
https://github.com/devcontainers/features/blob/4697d25cc57cb79fd37845147d6f9adb6044b8c4/src/anaconda/install.sh#L100

@samruddhikhandale


[DR-3228] Specify which cloud to resolve from

When a user requests an access_url for a DRS URI, DRSHub goes through the access methods defined in the provider configuration and returns the first match. For example, in the configuration for TDR the first access method that's listed is "gs", so if a DRS URI has an access url for both "gs" and "https" (azure) it will always return the access url for "gs".
This updates the behavior so that if a user specifies the resolveFrom parameter (either azure, gs or s3), DRSHub will return the access_url for that cloud if it exists, otherwise it will return null. If the field is not specified, the behavior of the endpoint stays the same.

@nmalfroy brought up a good point that if there is no access_url for the cloud that the user wants to resolve from, DRSHub should return another one if it exists. So if a user wants to resolve from "gs" but there is only an azure access_url, return the azure one.

I'm going to merge.  I've added some unit tests but it keeps squawking and I think we're in good shape


Fix type of initialIndex

Codecov Report

:exclamation: No coverage uploaded for pull request base (v4@b98720c).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98720c...f1a84e8. Read the comment docs.

Thanks!


Remove "useFallback" feature (backport of 7567)

see https://github.com/apache/druid/pull/7567

also https://github.com/apache/druid/pull/9294


Allow deletion of failed pods

Is your feature request related to a problem? Please describe.

When pods are in status Failed the only mechanism to clean up these pods is the kubernetes garbage collector which is currently defaulted to 12500 which means that for most people this is useless.
There's been a few recent issues where the reason for the pod failures has been related to a kubernetes bug. One particular example is the recent nodeAffinity issue where the Kubelet rejects pod scheduled based on newly added node labels which have not been observed by the kubelet yet #93338
Status:               Failed
Reason:               NodeAffinity
Message:              Pod Predicate NodeAffinity failed

This can be particularly problematic to certain custom controllers which haven't implemented recreation of failed pod, or deletion of failed pods.
Describe the solution you'd like

Allow deletion of failed pods, possibly based on some reason exclusions (you may want to keep evicted pods around, for example)
Describe alternatives you've considered

The default garbage collection value in kubernetes could be made configurable, and/or given a better default than 12500, however, it seems more appropriate for a project like this to allow more configuration on which reason should be inclusive/exclusive of the automatic deletion.
What version of descheduler are you using?
descheduler version: N/A
Additional context

See more details here for a related the feature request made to kubernetes. https://github.com/kubernetes/kubernetes/issues/99986
This feels like a potential good fit for the descheduler.

This is a hardcoded filter the descheduler uses when listing pods on a node: https://github.com/kubernetes-sigs/descheduler/blob/84b174e8417edbb13e51a3207191c3449a4ce309/pkg/descheduler/pod/pods.go#L83
So it's not just that it won't evict them, but it doesn't even see them at all. This makes sense because if it listed Failed pods, it would consider them in each strategy when calculating pods to evict, which could produce odd behavior (for example, evicting a pod for antiaffinity with a failed pod on the same node doesn't really make sense)
However, I see some of the use cases you have pointed out as valid. So we could add some (non-default) option to evict, or at least consider, Failed pods, but we should think of the best way to do that.
What about if we add a new strategy specifically for this kind of garbage collection? Something like RemoveFailedPods. Simple enough and doesn't interfere with core code that would affect the other strategies which don't really need failed pods in their logic

What about if we add a new strategy specifically for this kind of garbage collection? Something like RemoveFailedPods. Simple enough and doesn't interfere with core code that would affect the other strategies which don't really need failed pods in their logic

This makes a lot of sense to me and is effectively the approach I had to take with a custom controller to overcome the NodeAffinity failed pod issue. In my use-case I'm happy to remove all pods in failed state, but I could imagine it might be nice to specify the Reason either as an allow list or deny list for some people so that not all failed pods are automatically deleted.

I could imagine it might be nice to specify the Reason either as an allow list or deny list for some people so that not all failed pods are automatically deleted.

This could be added as a parameter later on, if there is demand for it

I'd be happy to try implement something in the next few weeks if you'd like? If you're okay with that, any pointers would be great.

/assign

@jaymebrd @damemi  I took a stab at this in PR #610
Look forward to your feedback!
As far as the reasons, minPodLifeTimeSeconds, excludeOwnerKinds params, we are planning on moving off an in-house remediator tool to Descheduler and need these filters.

minPodLifeTimeSeconds - Leave Pods around for n seconds to allow debugging
excludeOwnerKinds - Exclude Jobs

Will this policy also handle Pods which errored out due to Topology Manager not being involved in scheduling decisions? See Known Limitations chapter under https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/
AFAIK "Topology Affinity Error" is a distinct status on its own (i.e. not a "reason" of a "PodFailed" status), but it would be great if this strategy could be used for these Pods too!

@Levovar Would you be able to share a YAML/JSON showing the status of the Pod? More than happy to implement this if you can provide that.

@a7i I was just looking at related issues where the error appeared in the "Status" column such as in https://github.com/kubernetes/kubernetes/issues/84597#issue-515432349 and https://github.com/kubernetes/kubernetes/issues/84869#issue-518618378
code-wise it also seems this error is returned directly to Kubelet in the Admit interface call result: https://github.com/kubernetes/kubernetes/blob/617064d7327bf455955cb785d57330c425d48b51/pkg/kubelet/cm/topologymanager/scope_pod.go#L55
Note I'm not a K8s dev so this still might be just a "Reason" field being display, just wanted to make sure if this use-case is covered :) I will try and re-create this scenario when I can to get a full JSON output of the Pod's status fields

maybe @swatisehgal could help us out
will "Topology Affinity Error"ed Pods picked up by the following filter:
fieldSelectorString := status.phase=" + string(v1.PodFailed)
aka are these Pods "Failed", or their phase will be "TopologyAffinityError"?

I believe we can close this now that #610 is merged.
@Levovar please feel free to open a separate enhancement issue if the initial new strategy implementation does not work with your Topology Manager use case. Thanks!
This new strategy will be shipped with the descheduler v0.22.0 release.
/close


notary server with token auth

Hi there,
I've enabled token auth on the notary endpoint. But i'm not sure how to use it, the api now shows authorization required which is great, but docker pull shows:
you are not authorized to perform this operation: server returned 401.
I'm logged into a private registry that uses the same token auth service. What have I missed?
Update1
From docs
Notary server optionally supports authentication from clients using JWT tokens. This requires an authorization server that manages access controls, and a cert bundle from this authorization server containing the public key it uses to sign tokens.
Apparently what I missed was step 1 -_________-. I had the wrong cert bundle in there.
Update2
A more interesting question might be if my config looks like this
  "repositories": {
    "gun_prefixes": ["docker.io/", "registry.domain.com/"]
  }

and my private notary server is using
      "rootcertbundle": "/oauth/server.pem"

When I push and pull from my private registry everything works great but when I try to use docker.io
docker pull alpine:latest
Error: error contacting notary server: unauthorized: authentication required

I was hoping I could configure gun_prefix for certain trusts like alpine while keeping the rest internal.

The notary server is not doing any proxying. The gun_prefixes are the prefixes that can be serviced by that notary server. You could host you own notary data for the official alpine image but it doesn't sound like that's what you're trying to do.
To use the docker hosted notary servers that contain trust data for repositories like alpine you will want to unset the DOCKER_CONTENT_TRUST_SERVER environment variable, or alternatively, set it to https://notary.docker.io (this URL is the default in the docker binary).

It'd be nice to say I trust image x y and z from docker.io/library or some other internal registry like dev.reg.domain  but have the env vars are still set to my local Reg and local Notary, basically white listing images from certain registries to the Norary.

There is work going on in containerd to help separate name from location and I think this would fit in well there. We're already considering how to integrate the trust pinning logic with those changes and it would make sense to also include a mapping of image name -> notary server as part of that configuration.

Also, because it might work for you, notary is design to work in tandem with a registry, so if you put a reverse proxy (i.e. nginx) in front, you can do path based routing between the registry and notary servers. This means you don't need to configure the DOCKER_CONTENT_TRUST_SERVER at all, as docker will always attempt to use the hostname from an image name as the location of a notary server (just as it does for a registry). With the env var left unconfigured, docker will still go to the official notary server for any docker hub/cloud images.


Reg\Register an Operation\Operation Information - Back button function to  operation information returns "Not found"

Describe the Bug:
After completing Reg\Register an Operation\Operation Information, click "Back" from Facility Information returns "Not Found"
Reproduction steps:

Sign in as an industry user with access to an operator (example: 'bc-cas-dev' user)
Navigate to "Register an Operation"
In Operation Information, complete required fields
Click 'Save and Continue'
In Facility Information, click 'Back'

Results:

Probability (how likely the bug is to happen, scored from 1-5):
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Effect (how bad the bug is when it does happen, scored from 1-5):
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")
Steps to reproduce the behaviour:
Screenshots:
Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional context

The back button clears the data. Please review if this requires another bug ticket @Sepehr-Sobhani

Accepting the ticket as this bug fix passed testing. Reviewing why the back button clears the data on the form.

The back button clears the data. Please review if this requires another bug ticket @Sepehr-Sobhani

@vesselak This is related to a broader discussion that has been on our radar for a while, and we haven't figured out how to fully resolve it. Here is the ticket: https://github.com/orgs/bcgov/projects/123/views/15?pane=issue&itemId=80445750&issue=bcgov|cas-registration|2169


Can't install this tool

Thank you for the reporting! I mistekenly removed this module from npm repository while testing.
Currently, you can install it on your flow editor.


Can't change attenuation for I2S ADC. (IDFGH-3358)

I need to attenuate the signal read by i2s_read.
When shorting the DAC output to the ADC input all I see is noise. I ran a test by gradually moving up the voltage and notice the average voltage repeats every few hundred mV.
I hoped it was as easy as running: adc1_config_channel_atten(I2S_ADC_CHANNEL,ADC_ATTEN_DB_11)
But that did not work nor did setting other attenuations .
I do not see anything in the documentation however searching through esp idf files, I found this:
 // enable adc sampling, ADC_WIDTH_BIT_12, ADC_ATTEN_DB_11 hard-coded in adc_i2s_mode_init
How do I attenuate the i2s adc channel so I can spread the 12 bits across 0 to 3v3 range?

Please make that configurable. It's a pain, that there's not even a simple #ifndef DIG_ADC_ATTEN_DEFUALT
[sic!]

Hi,
I have a similar problem, I want to read ADC with 0dB attenuation but when I read from I2S , values are attenuated 11dB.
I tried to change adc attenuation (adc1_config_channel_atten) after calling i2s_set_adc_mode, but that doesn't work for me. Maybe you can try.

i2s_set_adc_mode actually uses adc dma patterns, and you can change these by copying implementation of adc_ll_digi_set_pattern_table function into your code or just by adjusting ADC register manually, like
extern "C" {
    #include "soc/syscon_reg.h"
    #include "soc/syscon_struct.h"
}
// channel 6 at 12bits with 0db attenuation
WRITE_PERI_REG(SYSCON_SARADC_SAR1_PATT_TAB1_REG, 0x6C000000);
// you can also use more than one pattern to scan sequentially by using more bytes in register
SYSCON.saradc_ctrl.sar1_patt_len = PatternsCount-1;

Also in current esp idf used by arduino framework i2s_adc_enable is restoring adc registers with _i2s_adc_mode_recover call, so it is better to adjust pattern registers after i2s_adc_enable, not before.


Extendable Subscribe component & locale

What was done:

New Subscribe component from which SubscribeButton extends.
Updated dependencies (fontawesome)
Updated nova-i18n-en-us package with locale for Subscribe component
Fixed Subscribe onClick event propagation
Moved  subscribers notification from nova-comments as a new SubscribedCommentsNotifications callback function.

@schabluk this is a nice component. Could you provide an example of usage with it?

@MHerszak sure. The best way is to put it into your CustomPostsItem. You can use Subscribe, which is a simple link, or fancier SubscribeButton.
import { Subscribe, SubscribeButton } from "meteor/subscribe-to-posts";

class CustomPostsItem extends Telescope.components.PostsItem {
  render() {
    // ...
    return (
      // ...
        {this.renderCommenters()}

        <SubscribeButton post={post} />
      </div>
    )
  }
};

Looks like this:

@schabluk: Thanks! I will check it once in a while.

Nice work as always! A few remarks:

Do we really need both Subscribe and SubscribeButton? Why not just Subscribe?
I'd rather not have a dependency on fontawesome here. Plug-ins should provide additional back-end features, but if possible they should avoid overloading you with dependencies you might not need.

 Removing SubscribeButton and 3rd party deps.
What about UI component for user_subscribed_posts template? Shall it be obsolete?

Maybe we can still have the list of a user's subscribed posts as an exported component? I don't think that would add too many dependencies?

Finally I had time to make it work :) The SubscribedPosts is based on PostsHome component, and the userSubscribedPosts view is as it was in the old package, only with small modification.
PS. Accidentally, I pushed bootstrap.css update (to 4.0.0-alpha.3)...

Nice! So is this ready for merging?

Yes!

@schabluk I've looked through the code and cleaned up/reformatted a couple things. Do you think you could check out the commit and make sure everything still works/makes sense?
Also I've started fleshing out the Readme, if you have time maybe you could add more details?
(for some reason a weird .build.telescope-blank folder got commited too, sorry if it makes things a bit messy. Not sure what that's about…)

@SachaG I did small changes and it works like charm :) Pull request will follow.
I will update the Readme in a days. Don't know what the .build.telescope-blank, I think it's not needed.


Support array[newIndex] = xyz

This will fill in any intervening values with NSNull().
It essentially becomes a sparse array this way

Codecov Report

Merging #8 into version-2.0 will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           version-2.0       #8      +/-   ##
===============================================
+ Coverage        94.81%   94.82%   +<.01%
===============================================
  Files               30       30
  Lines             5499     5502       +3
===============================================
+ Hits              5214     5217       +3
  Misses             285      285

Impacted Files
Coverage Δ

FetchRequests/Sources/CWJSON.swift
93.6% <ø> (ø)
:arrow_up:

FetchRequestsTests/Models/CWJSONTestCase.swift
97.89% <100%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fa8cb...cbbb3ab. Read the comment docs.


Add type checking in async functions

http://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540output_file_name%2520default.js%250A%252F%252F%2520%2540language%2520ECMASCRIPT8%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250Afunction%2520hello()%2520%257B%250A%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520let%2520s%2520%253D%25201%253B%2520%252F%252F%2520WARNING%250A%257D%250A%250Aasync%2520function%2520hello_async()%2520%257B%250A%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520let%2520s%2520%253D%25201%253B%2520%252F%252F%2520IGNORE%250A%257D%250A%250A%250A

@ikabirov thanks for the bug report.
@dimvar it's not clear to me why this code would fail to give a warning. Any immediate thoughts?
async function hello_async() {
  /** @type {string} */
  let s = 1; // IGNORED type error
}

I think this is a bug related to generators transpilation.
I notice that the type information on s is getting lost. The relevant transpiled code looks like this.
function hello_async() {
  /**
 @suppress {uselessCode}
 */
function $jscomp$async$generator() {
    function $jscomp$generator$impl($jscomp$generator$next$arg, $jscomp$generator$throw$arg) {
      for (;1;) {
        switch($jscomp$generator$state) {
          case 0:
            s = 1;
            $jscomp$generator$state = -1;
          default:
            return {value:undefined, done:true};
        }
      }
    }
    var $jscomp$generator$state = 0;
    var s;
    var iterator = {next:function(arg) {
      return $jscomp$generator$impl(arg, undefined);
    }, throw:function(arg) {
      return $jscomp$generator$impl(undefined, arg);
    }, return:function(arg) {
      throw Error("Not yet implemented");
    }};
    $jscomp.initSymbolIterator();
    /**
 @this {!Generator<?>}
 */
iterator[Symbol.iterator] = function() {
      return this;
    };
    return iterator;
  }
  return $jscomp.executeAsyncGenerator($jscomp$async$generator());
}

https://closure-compiler-debugger.appspot.com/#input0%3Dasync%2520function%2520hello_async()%2520%257B%250A%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520let%2520s%2520%253D%25201%253B%2520%252F%252F%2520IGNORE%250A%257D%250A%250A%250Afunction%2520hello()%2520%257B%250A%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520let%2520s%2520%253D%25201%253B%2520%252F%252F%2520WARNING%250A%257D%250A%250A%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

Yep, this code also fails to get a warning.
function *hello() {
  /** @type {string} */
  let s = 1;
}

Probably we're just failing to copy over the JSDocInfo at a couple of spots.

Any news on this ?

Looks like this was fixed by the recent rewrite of the generators transpilation pass.
I confirmed that our current internal release issues warnings for both functions in the original example.
The next opensource release will include the fix.

awesome! thanks


Helpful admin routes for maintainance

Referring https://groups.google.com/forum/#!topic/seaweedfs/v-i5VtlTf_U:
Volume Management
Unfortunately it is not possible to delete or move a volume online. I think this would be very easy to implement with a few routes:
http://vol_server/admin/volume/delete: Does what it says. I had many stale volumes around after master split-brain.
http://vol_server/admin/volume/detach: Unregisters the volume at the master, so that the volume becomes unwritable on purpose
http://vol_server/admin/volume/attach: Registers a volume so that it becomes available without vol_server restart
This would make it possible to transfer volumes across servers e.g. for node-rebalancing.
Volume-Server Management
Taking a volume server administratively offline directly would be helpful. So there is no gap between volserver shutdown and when the master marks the volumes as readonly (see #419). This is for example helpful if a volume server is undergoing scheduled maintainance.
Routes could look like:
POST http://master_server/admin/:volumeServer/offline Marks a volume server as offline
POST http://master_server/admin/:volumeServer/online Marks a volume server as online
Or alternatively
PUT http://master_server/admin/:volumeServer with body admin_state=online|offline

Fixed by #443
I think it is not necessary any more to mark a volserver as offline. Heartbeat has improved a lot with 0.73, correct?


Tree Table

When implement tree table?

What do you mean? Tree inside a data table?
Currently there's no plan to implement this.

Perhaps @sante85 means something like JXTreeTable?

Can this be achieved using custom templates?
I am looking to use this on a filestructure which would look pretty if data is organised in columns.

I have done something similar :  https://angular-9u9ml1.stackblitz.io/
https://stackblitz.com/edit/angular-9u9ml1?file=app%2Fapp.component.ts
Currently I am in a situation to implement all features [drag and drop, lazy laod ] of angular-tree-component.
What can be the solution with existing library. @adamkleingit
Thanks for library.

same problem. i want to implement tree table

I recommend using grid solutions that offer tree inside grid.
Usually that comes with many other grid features like sorting, filtering, pagination, etc.


No path by default in set_cookie()

The new behavior of set_cookie() is not documented and not mentioned in the Changes log.
set_cookie() does not set path to '/' by default anymore and "per default it will span the whole domain" in the documentation is not correct.
The commit: https://github.com/pallets/werkzeug/commit/eb363e4fad9ebc333cb69fc83ae45b3a46fe82ce
Environment:

Python version: 3.10.10
Flask version: 2.3.1

There exists the commit "cookie sets Path=/ by default again": https://github.com/pallets/werkzeug/commit/447d4a8046c787a641c34aa9cdeedabc21b180e2
It does not revert the changed file and doesn't bring the old behavior back.


Created a pull request template for the repository

Fixes issue: #67
Please review it and suggest any changes if needed.
@sarthology

Let's discuss more on it.


Add Fedora 22 Install Directions To README

Fedora 22 uses dnf
yum command will not work

I wasnt sure if this should be a sub-direction under the Red Hat section or if it should be its own section. I can change it if needed.

Awesome, thanks so much :ship:


Setting: Shuffle Freestanding Rupees and Hearts

Title is self-explanatory. Shuffle the freestanding rupees and hearts (the ones you can actually see and aren't hidden/invisible) for both games.

[x] OOT Freestanding Rupees and Hearts Shuffle
[x] MM Freestanding Rupees and Hearts Shuffle

Done in

OOT: 86b242
MM: 62d747


Fix Style/SpaceAfterNot reporting on the not keyword

See #3155

I didn't notice this PR until just now and I've been giving some feedback to the similar https://github.com/bbatsov/rubocop/pull/3174 instead. Sorry about this.

Oh, nevermind...
I'll just apply your comment about the ordering here anyway and let you choose the PR to merge.
I won't be mad at you, if it is not mine :wink:

edit: I totally missed the comment about double unpacking at first... still not sure if I would personally prefer DRYness or performance... unsure about the performance impact, though...

Well, if you go the node method route I can argue that there should be a bang_keyword method then. :-) Our codebase is kind of messy, because from time to time we'd start applying some new pattern, but wouldn't apply it consistently across the entire codebase. In general I agree that readability is more important than performance, but for a tool like RuboCop performance is critical (especially when dealing with bigger codebases).

I actually like the idea about the bang_keyword method... Only counter argument I see here, is that it might bloat the node object. But at least it should combine the performance and readability benefits...

Hey, didn't noticed this one myself. I'll close mine.

Except that I still need to unpack the node to check whether the spacing is correct -.-

There's no perfect scenario. Still, it seems to me it'd be better to have a focused bang keyword check, compared to what we have right now.

Still, it seems to me it'd be better to have a focused bang keyword check, compared to what we have right now.

Then that is the path I will go.