[00:14] <jcole> can someone tell me where the system bookmarks file is on natty? it's always been located at /etc/*/profile/bookmarks.html but apparently it's gone now
[00:16] <jcole> i was just asking in irc://irc.mozilla.org#firefox and they told me to come here
[00:18] <xjjk> mm, I didn't think there was a system bookmarks file
[00:18] <xjjk> anymore*
[00:19] <jcole> xjjk: there has always been one
[00:19] <jcole> hardy-lucid
[00:19] <jcole> $ ls /etc/*/profile/bookmarks.html
[00:19] <jcole> /etc/firefox-3.0/profile/bookmarks.html
[00:19] <jcole> ^^ thats on hardy
[00:19] <jcole> lucid is 3.6
[00:20] <xjjk> does editing that work?
[00:20] <jcole> yes
[00:20] <xjjk> I thought post firefox 3 bookmarks.html was deprecated
[00:20] <xjjk> for the places db
[00:20] <xjjk> and afaik I didn't think that was a "system" bookmarks file
[00:20] <kbrosnan> xjjk: if the user does not have a profile that file is used to create the default bookmarks
[00:20] <xjjk> as much it was a template for new profiles
[00:20] <xjjk> ala /etc/profile
[00:20] <jcole> xjjk: it is, but editing the system bookmarks.hml file puts them in laces.db
[00:20] <xjjk> right
[00:21] <xjjk> sorry, ala /etc/skel
[01:06] <Omega> http://www.vupen.com/demos/VUPEN_Pwning_Chrome.php
[01:06] <Omega> fta: eeek ^
[08:05] <m_conley> jcastro: ping
[10:42] <chrisccoulson_> micahg, around?
[10:43] <micahg> chrisccoulson_: yeah
[10:43] <chrisccoulson_> micahg, are you in a session atm? i'm downstairs in the lobby/bar area
[10:43] <micahg> chrisccoulson_: sort of, I can come meet you though if it's important
[10:44] <chrisccoulson_> micahg, we could do with fixing bug 777619
[10:44] <ubot2> Launchpad bug 777619 in globalmenu-extension/1.0 "Unused empty menu bar" [Critical,Fix committed] https://launchpad.net/bugs/777619
[10:45] <micahg> chrisccoulson_: ah, yes
[10:46] <micahg> chrisccoulson_: looks innocuous enough, I think it can wait for the next security update though unless you think it needs to be in sooner
[10:47] <chrisccoulson_> micahg, i think we need to fix it before then, especially now users are discussing workarounds that are likely to break their install
[10:47] <chrisccoulson_> and it's a pretty obvious regression with the empty menubar remaining in the window
[10:47] <micahg> chrisccoulson_: it's just cosmetic though isn't it?  just the empty bar on top?
[10:48] <chrisccoulson_> yeah, but it's pretty annoying, and looks fairly bad
[10:48] <micahg> chrisccoulson_: k, so check with pitti, I can SRU verify it, I'm experiencing the issue
[10:49] <chrisccoulson_> micahg, do we need to check with pitti? it regressed in the last security update (because of bug 767966)
[10:49] <ubot2> Launchpad bug 767966 in globalmenu-extension/trunk "globalmenu extension pollutes main window javascript scope" [Medium,Fix committed] https://launchpad.net/bugs/767966
[10:50] <micahg> chrisccoulson_: oh, ugh, that's my fault for not paying enough attention after the update then, yeah, let me check with jdstrand, we should probably push it though -security
[10:50] <chrisccoulson_> micahg, heh. i should have spotted it too though. i did test it, but i didn't see it because i'd already manually moved the spinner on my install ;)
[10:52] <micahg> chrisccoulson_: k, do you want to prepare the update in bzr as UNRELEASED and I'll take care of it later
[10:52] <chrisccoulson_> micahg, sure, can do
[10:52] <micahg> chrisccoulson_: thanks
[11:16] <micahg> chrisccoulson_: we still can't build for oneiric, right?
[16:29] <chrisccoulson> hi m_conley_away, all set for UDS? ;)
[19:37] <fta> jcastro, ping


[00:56] <jam> mgz: ** Bug watch added: SourceForge.net Tracker #2581469    http://sourceforge.net/support/tracker.php?aid=2581469
[00:56] <jam> I think it worked
[00:58] <jam> ubot5: the bug is 1.5years old, surely you can find it
[01:11] <jam> mgz: well, in Vim I have !M<enter> as a macro to fill out all of the def main() import Optparse sort of stuff
[01:11] <jam> so it is pretty trivial
[01:11] <jam> I really don't like top-level scripting
[01:12] <lifeless> why not use bzr's command infrastructure?
[01:12] <lifeless> I do, or the stuff I put into testrepository
[01:12] <jam> lifeless: I certainly could, and just write a plugin, I just started as a script here
[01:12] <jam> both work
[01:12] <jam> main is pretty trivial to get up and running
[01:12] <jam> and I don't always depend on bzrlib
[01:13] <jam> lifeless, mgz: http://paste.ubuntu.com/458547/
[01:13] <jam> I set that up before bzr existed I believe
[01:14] <jam> anyway, back to family time
[02:55] <lifeless> vila: are you around perchance?
[15:35] <mgz> not had to read pascal for a long time
[15:36] <mgz> seems the right fix for installer bug is easy though, once I actually er... got the right bit of software
[20:01] <GaryvdM> Hi mgz
[20:01] <mgz> good timing.
[20:02] <GaryvdM> I'll do a build with your patch now.
[20:02] <mgz> can I twist your arm to try...
[20:02] <mgz> right, that.
[20:02] <mgz> thanks!
[20:05] <GaryvdM> Bla - I have all sorts of uncommited channges - need to deal with them before I merge your branch...
[20:05] <mgz> shelve!
[20:06] <GaryvdM> Shelving some of it, commiting some of it.
[20:07] <mgz> bad habit forming that, I have too much stuff stashed in pseudo-diffs in a hidden folder rather than getting finished
[20:07] <mgz> I did only use it with hg, but have started using with with bzr as well.
[20:15] <GaryvdM> I'm not sure how well the build script handles changes, so I'm doing a full build, rather than a incremental, just to be sure.
[20:15] <GaryvdM> So it will take about 10min
[20:28] <GaryvdM> mgz:http://dl.dropbox.com/u/4494367/bzr-2.2~bzr.dev~3-setup.exe
[20:28] <mgz> getting.
[20:30]  * GaryvdM tests using wine...
[20:32] <GaryvdM> Bla fix for tbzr not working...
[20:34] <mgz> meh, and seems timestamps ar still messed up
[20:36] <GaryvdM> mgz: my branch that I am building with: lp:~garyvdm/bzr-windows-installers/maybe
[20:36] <mgz> oddly, it's an hour *and a minute* out...
[20:36] <mgz> >>> time.gmtime(struct.unpack("<2i", file(r"C:\Program Files\BazaarBeta\plugins\bzrtools\__init__.pyo", "rb").read(8))[1])
[20:36] <mgz> (2010, 7, 3, 19, 17, 43, 5, 184, 0)
[20:36] <mgz> >>> time.gmtime(os.stat(r"C:\Program Files\BazaarBeta\plugins\bzrtools\__init__.py").st_mtime)
[20:36] <mgz> (2010, 7, 3, 18, 17, 42, 5, 184, 0)
[20:37] <mgz> *second
[20:37] <GaryvdM> mgz: maybe useful for debugging: http://innounp.sourceforge.net/
[20:38] <mgz> will check, but I looked at their source and it seemed like the flag would do the right thing
[20:39] <mgz> oaaaa... I have a bad feeling
[20:39] <mgz> I'm going to try running the setup again, but this time setting TMP to my main NTFS drive first
[20:42] <mgz> nope, still a second out.
[20:43] <mgz> back to the pascal...
[20:44] <GaryvdM> mgz: I thing you have made the change in the wrong place.
[20:44] <mgz> this is possible, I hate build stuff.
[20:44] <GaryvdM> mgz: templates/inno/bzr.iss
[20:44] <mgz> it's not even clear to me if that was the input of a script or the output
[20:45] <GaryvdM> Don't worry - I'm just as confused....
[20:45] <mgz> the one-second problem won't be helped though... is the build slave on FAT rather than NTFS?
[20:45] <GaryvdM> I'll check
[20:46] <mgz> no... that wouldn't explain it either I don't think... grrr
[20:46] <GaryvdM> NTFS, on both drives
[20:48] <mgz> C:\>innounp -v bzr-2.2~bzr.dev~3-setup.exe | grep bzrtools.__init__
[20:48] <mgz>       3689  2010.07.03 19:17  {app}\plugins\bzrtools\__init__.py
[20:48] <mgz>       3249  2010.07.03 19:24  {app}\plugins\bzrtools\__init__.pyo
[20:48] <mgz> so, it's stored as the right hour, but doesn't give me the seconds to check
[20:50] <GaryvdM> mgz: let me know If I can run things on the build host to debug.
[20:50] <mgz> well, did that cog thing get overwritten by the build process?
[20:50] <mgz> should I try moving the change to the templates dir?
[20:51] <mgz> that would at least fix the hours-out problem
[20:51] <GaryvdM> I don't think that the cog file gets used at all.
[20:51] <mgz> uuuu.
[20:51] <mgz> okay, I'll move it, push, and if you could try again...
[20:52] <GaryvdM> See Ian's comment here: https://bugs.edge.launchpad.net/bzr-windows-installers/+bug/569077
[20:52] <mgz> actually, I'm going to uncommit, I've made enough recored dumb mistakes on this bug already
[20:52] <GaryvdM> https://bugs.edge.launchpad.net/bzr-windows-installers/+bug/569077/comments/7
[20:53] <mgz> can we not just... delete things that aren't used any more... why else do we use version control...
[20:53] <GaryvdM> mgz: I've just stated doing the builds...
[20:53] <mgz> I'm not blaming you
[20:54] <GaryvdM> mgz: yes - I agree..
[20:54] <mgz> but, speaking of blame, there's blame in that cog file from Ian,
[20:54] <mgz> Date:
[20:54] <mgz> 07/03/2010 11:54:07
[20:54] <mgz> which is ... dammit!
[20:54] <mgz> not a US date.
[20:54] <mgz> so, it's not today ;)
[20:55] <GaryvdM> lol ...
[20:57] <mgz> okay, pushed the move, if you could pull and try that...
[20:57] <GaryvdM> mgz: ok
[20:58] <GaryvdM> I also want to try a different fix for the tbzr issue.
[21:01] <mgz> if we have to add code to do % 2 on every py file mtime, I'm going to be annoyed
[21:07] <mgz> http://www.jrsoftware.org/ishelp/topic_setup_timestamprounding.htm
[21:07] <mgz> okay, that's to blame for the rounding
[21:08] <mgz> just changing that would fix the issue fully for nearly everyone, but potentially screw fat people
[21:08] <mgz> seems like and improvement though so I'll add it to my existing branch
[21:13] <mgz> pushed that as well if you've not started the new build yet
[21:13] <GaryvdM> mgz: http://dl.dropbox.com/u/4494367/bzr-2.2~bzr.dev~4-setup.exe (without time stamp rounding)
[21:13] <mgz> will test that, thanks.
[21:14] <mgz> don't worry about the new change yet.
[21:14] <GaryvdM> mgz: I'll kick off a another build
[21:16] <GaryvdM> mgz: that was an incremental build. Let me know if you don't see any change.
[21:16] <mgz> will do, nearly downloaded
[21:18] <GaryvdM> Maybe later we can look at trying to make the install smaller. I think there are some pyqt .pyd files we don't need.
[21:19] <mgz> excluding stuff like that script you mentioned yesterday and seeing if that helps sounds worthwhile
[21:19] <mgz> okay, that build has the right hour.
[21:20] <mgz> so incremental seems to be fine, as does my FAT tmp drive
[21:20] <mgz> just need to see if my last push also sorts out the second
[21:20] <GaryvdM> \o/ TortoiseOverlays bug fixed.
[21:21] <mgz> go gary.
[21:27] <GaryvdM> mgz: http://dl.dropbox.com/u/4494367/bzr-2.2~bzr.dev~5-setup.exe
[21:28] <mgz> wgetting
[21:31] <GaryvdM> We can remove 6mb (uncompressed) unneeded pyqt files
[21:32] <GaryvdM> But other things first.
[21:32] <mgz> works.
[21:32] <mgz> timestamp matches, qbzr help displays
[21:33] <mgz> pipeline-launchpadlib issue still needs fixing
[21:34] <mgz> was sure Aaron had another crack at making that lazy-loaded, is there not a pending rev to pull or something?
[21:34] <GaryvdM> mgz: But what functionality do we lose buy not having the lib?
[21:35] <GaryvdM> mgz: I thing better to just add the lib.
[21:35] <mgz> lp-propose and some other bits I think
[21:35] <mgz> the problem is it's not just the lib
[21:36] <mgz> it's a maze of setuptools dependencies and related mess spanning eight or so packages
[21:36] <mgz> it doesn't even *let* you install it by the normal methods
[21:37] <mgz>   File "C:/Program Files/BazaarBeta/plugins\pipeline\__init__.py", line 161, in <module>
[21:37] <mgz>   File "C:/Program Files/BazaarBeta/plugins\launchpad\lp_api.py", line 43, in <module>
[21:37] <mgz> DependencyNotPresent: Unable to import library "launchpadlib": No module named launchpadlib
[21:37] <mgz> (with -Derror so pipeline has an indirect need via launchpad plugin apparently)
[21:39] <GaryvdM> mgz: Bug  569717
[21:39] <mgz> okay, that's trivial, he's catching the wrong error
[21:39] <mgz> it's in an except ImportError wrapper, but launchpad plugin is reraising as bzrlib.errors.DependencyNotPresent
[21:41] <mgz> I can fix that in pipeline and defer the should-and-how over launchpadlib
[21:41] <GaryvdM> mgz: I think better to put effort in adding launchpadlib to the installer.
[21:41] <mgz> bzrlib.errors isn't something we try and load lazily is it? comes under huge-but-essential.
[21:42] <mgz> by all means have a look at it, but... I bet it won't be fun.
[21:42] <GaryvdM> mgz: Making it lazy import is tricky.
[21:43] <GaryvdM> mgz: I have a branch which dose it. I did not submit - to hackey.
[21:43] <mgz> right, so I can just import and not worry.
[21:47] <GaryvdM> mgz: lp:~garyvdm/bzr/more_lazy
[21:48] <mgz> ...think I should file a new bug against bzr-pipeline or add the project to the existing bug/
[21:48] <mgz> don't know launchpad ettiquette here
[21:48] <mgz> /=?
[21:49] <GaryvdM> First check for existing bugs in pipeline...
[21:49] <mgz> didn't find anything searching for "launchpadlib"
[21:50] <GaryvdM> mgz: I would say they are 2 different bugs.
[21:50] <GaryvdM> installer does not have launchpadlib
[21:51] <GaryvdM> pipeline does not lazy import launchpadlib
[21:51] <GaryvdM> So IMO log a new pipeline bug.
[21:51] <mgz> k, will file new bug against pipeline.
[21:59] <mgz> can you try an installer build with a bzr-pipeline from my branch rather than trunk, or is that hard to do?
[22:01] <GaryvdM> I can do that. Branch lp url?
[22:02] <GaryvdM> mgz ^
[22:02] <mgz> lp:~gz/bzr-pipeline/no_launchpadlib_needed_601466
[22:23] <GaryvdM> mgz: http://dl.dropbox.com/u/4494367/bzr-2.2~bzr.dev~4-setup.exe
[22:23] <GaryvdM> mgz: http://dl.dropbox.com/u/4494367/bzr-2.2~bzr.dev~5-setup.exe
[22:23] <GaryvdM> 5 not 4
[22:24] <mgz> the last one was also ~5?
[22:24] <mgz> that is, I have a ~5 on disk already
[22:24] <GaryvdM> Oh - opps - sorry
[22:25] <GaryvdM> Here I am, building a version control system , and I can't count...
[22:26] <mgz> it's a different size so I'm guessing it is actually a new build :)
[22:27] <GaryvdM> Yes
[22:27] <GaryvdM> Drop box did not warn me that I was overwriting :-(
[22:31] <mgz> that seems to have worked
[22:32] <mgz> no more pipeline complaints.
[22:32] <GaryvdM> Cool - I'm going home shortly. I'll be around tomorrow morning.
[22:34] <mgz> I'm out of problems to make you test.
[22:34] <GaryvdM> :-)
[22:35] <mgz> I'll throw up a branch with a bzr setup.py change that's easy but ugly, but doesn't need experimenting with.
[22:38] <GaryvdM> mgz: I need to make the new scripts accept a taged revision, try bundle launchpad lib, remove unneeded pyqt revisions, find a better solution to the PyQt.uic.port_v3 problem, create a test build with bzrw.exe, try removing unused build code (such as the cog files).....
[22:38] <GaryvdM> *unneeded pyqt files
[22:38] <GaryvdM> :-)
[22:41] <mgz> lp:~gz/bzr/installer_plugin_script_timestamp_rounding <- the change
[22:41] <mgz> not sure it's really a good idea, and that py2exe stuff all needs to live in bzr-windows-installers rather than core, but hey
[22:41] <GaryvdM> Yes Yes Yes
[22:42] <GaryvdM> Or in plugin setup.py
[22:42] <mgz> simple enough to write that having thought of it earlier as an option may as well just propose and let others decide
[22:43] <GaryvdM> You rock.
[22:49] <GaryvdM> Cheers mgz.
[22:49] <mgz> evenin'


[07:29] <ricotz> hello :), the rustc 1.70 backports for focal/jammy/lunar were just published, but they are missing riscv64 builds
[16:05] <ebarretto> ricotz, thanks for the heads up, I will pass the info forward
[16:17] <ebarretto> ricotz, thanks again, we will be re-spinning those
[16:19] <ricotz> ebarretto, thanks!


[00:00] <karni> CardinalFang: Hi! Thanks for the review. You've double-approved ubuntuone-files-java-client - was one of the approvals for u1f progressbar branch?
[00:00] <CardinalFang> karni, no, I don't think so.
[00:00] <karni> CardinalFang: ok
[00:01] <karni> :)
[06:41] <mthaddon> U1 down for DB maintenance
[07:11] <mthaddon> and service should be back now
[07:49] <Agravain> hi guys :)
[07:49] <Agravain> is there a client for Mac OS or any other way to download the entire contents from Ubuntu One directly to my Mac?
[08:19] <fagan> Agravain: nope we havent got one yet
[08:56] <Agravain> fagan: ok, thank you for replying
[09:07] <karni> Good morning!
[11:06] <nessita> good rmoning everyone!
[11:13] <gatox> nessita, good morning
[11:14] <nessita> hi gatox, how is it going today?
[11:14] <gatox> nessita, nice! :P
[11:21] <nessita> ralsina: ping
[11:38] <gatox> ralsina, ping
[11:50] <nessita> gatox: if you need anything, you can ask me, I may be able to help you. Also, can I have a trivial\isima review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/dislexia-no-more ?
[11:50] <gatox> nessita, ok..... reviewing... i was looking for ralsina because i have some question about one of his branches that need review
[11:50] <nessita> gatox: ah, I can't answer that :-D
[11:51] <gatox> :P
[12:14] <ralsina> good morning!
[12:14] <nessita> hi ralsina
[12:14] <ralsina> hi nessita
[12:14] <ralsina> gatox: good morning amd feel free to ask :-)
[12:14] <nessita> ralsina: were you able to review my "inherited" branch? :-)
[12:14] <ralsina> and pongs
[12:15] <ralsina> nessita: almost done, only need to run tests on linux
[12:15] <nessita> great!
[12:19] <gatox> ralsina, i left a comment in your branch
[12:20] <ralsina> gatox: ok!
[12:22] <ralsina> nessita: +1
[12:23] <gatox> nessita, ahhhhhh +1 to your branch..... i forgot to tell you
[12:24] <nessita> :-)
[12:27] <ralsina> gatox: answered your comment
[12:27]  * gatox reading...
[12:30] <gatox> ralsina, just an idea... maybe i'm terribly wrong :P..... but couldn't this be done with a qthread... where the process is executed inside the thread and when the thread finish (emit: finished) execute that function?? so in this way it's not going to be an arbitrary number
[12:31] <ralsina> gatox: I am fairly sure we are using python threads elsewhere, and you can't mix those and QThread if I remember right
[12:32] <gatox> ralsina, ok..... was just an idea :P
[12:33] <gatox> ralsina, i'm having some problems with the installer.... the one in trunk
[12:34] <gatox> ralsina, i delete my local copy and rebranch it..... and it stills continue...... when i open the installer...... it shows me the license page....... with a finish button.... i can't go to the next page :S
[12:35] <gatox> ralsina, and i have everything up to date
[12:37] <ralsina> gatox: yes, the brach that fixes that is merging right now
[12:37] <ralsina> gatox: the problem was: if it couldn't start sso-client, it failed that way
[12:38] <gatox> ralsina, ahhhhhhhh okok
[12:41] <nessita> dobey: ping
[12:42] <gatox> ralsina, i'm looking at Bug: #823414... should i launch the uninstall when the user click Disagree or not? Was this defined?
[12:42] <ralsina> Yes, we should
[12:43] <ralsina> We should ask the user if he's sure (with our own dialog), then launch uninstall, then show a "it's uninstalled" message.
[12:43] <gatox> ralsina, ok
[12:44] <ralsina> bad side is, currently the uninstaller is invisible, not sure why :-)
[12:47] <gatox> ralsina, ok... i'll take a look at that
[12:48] <ralsina> gatox: ok, ask lisette for words and stuff ;-)
[12:48] <gatox> ralsina, ok
[12:51] <lisette> words? :)
[12:52] <fagan> lisette: http://www.youtube.com/watch?v=w_Rut4qm33g :D
[12:52] <nessita> lisette: give us words!!! :-P
[12:53] <lisette> aargh, i am blind now!
[12:53] <fagan> lisette: they are one of the greatest Irish bands ever
[12:53] <fagan> they were our backstreet boys
[12:54] <nessita> lisette: you mean deaf? :-D
[12:54] <lisette> nessita: and deaf!
[12:54] <fagan> The lack of musical taste in this team is terrible
[12:55] <nessita> fagan: dude, you actually like avril lavigne! :-)
[12:55] <nessita> so, you may wanna consider the musical taste issue is the other way around :-P
[12:55] <fagan> nessita: hah yeah but I was in the generation that that was acceptable
[12:56] <nessita> fagan: you, calling me, old?
[12:56]  * nessita prepares the counterstrike
[12:56] <fagan> *cough* *cough*
[12:56] <nessita> I'm old but with honor! and prefect musical taste ;-)
[12:56]  * nessita runs
[12:57] <fagan> nessita: na your not that old but you were in the good old generation that had power metal and nirvana
[12:57] <nessita> :-)
[13:00] <fagan> me
[13:00] <nessita> me
[13:00] <fagan> ralsina nessita dobey alecu gatox standup
[13:00] <gatox> fagan, ack
[13:00] <gatox> me
[13:00] <ralsina> me
[13:01] <nessita> alecu, dobey?
[13:01] <fagan> Ill go they can catch up
[13:01] <fagan> DONE
[13:01] <fagan> * Finished off the redirects
[13:01] <fagan> CURRENT
[13:01] <fagan> * Reading some books waiting for another assignment
[13:01] <fagan> BLOCKED
[13:01] <fagan> * Nope
[13:01] <fagan> nessita: go
[13:02] <nessita> DONE: finished dont-shutil-move branch (waiting for alecu's review), tried and failed miserably to propose a clean solution for bug #827343
[13:02] <nessita> TODO: propose some solution for bug #827343
[13:02] <nessita> BLOCKED: nopes
[13:02] <nessita> NOTES: I'm leaving at noon today to go to university
[13:02] <nessita> NEXT: gatox
[13:02] <ubot4> Launchpad bug 827343 in ubuntuone-client "Send platform details when pinging for credentials (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/827343
[13:02] <gatox> DONE:
[13:02] <gatox> Fixed: Bug #819965, Bug #820872, Bug #820874
[13:02] <gatox> TODO:
[13:02] <gatox> Add Tests. Bug #823203, Bug #823414
[13:02] <gatox> BLOCKED:
[13:02] <gatox> No
[13:02] <ubot4> Launchpad bug 819965 in ubuntuone-windows-installer "Congratulations typos (affects: 1) (heat: 17)" [Undecided,New] https://launchpad.net/bugs/819965
[13:02] <gatox> ralsina, go
[13:02] <ubot4> gatox: Bug 820872 on http://launchpad.net/bugs/820872 is private
[13:02] <ubot4> gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private
[13:02] <ralsina> DONE: closed bug #825473, merging fix for bug #825491, worked on bug #825513, small fixes on the installer-builder-branch
[13:02] <ubot4> gatox: Bug 823203 on http://launchpad.net/bugs/823203 is private
[13:02] <ralsina> TODO: close those two bugs, autostart/credentials testing
[13:02] <ralsina> BLOCKED: no
[13:02] <ubot4> gatox: Bug 823414 on http://launchpad.net/bugs/823414 is private
[13:02] <ubot4> Launchpad bug 825473 in ubuntuone-windows-installer "License page may show a "Finish" button (affects: 1) (heat: 36)" [Critical,Fix committed] https://launchpad.net/bugs/825473
[13:02] <ubot4> Launchpad bug 825491 in ubuntuone-windows-installer "The "Local Folders" page tries to do things without credentials (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/825491
[13:02] <ubot4> Launchpad bug 825513 in ubuntuone-windows-installer "The local folders page is not up to spec (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/825513
[13:03] <dobey> me
[13:04] <dobey> λ DONE: bug #824666, bug #824669, bug #826772
[13:04] <dobey> λ TODO: more installer fixes, deal with tech board
[13:04] <dobey> λ BLCK: None.
[13:04] <ubot4> Launchpad bug 824666 in couchdb-glib (Ubuntu Oneiric) (and 1 other project) "ftbfs on all archs (affects: 1) (heat: 6)" [High,Fix released] https://launchpad.net/bugs/824666
[13:04] <ubot4> Launchpad bug 824669 in evolution-couchdb (Ubuntu Oneiric) (and 1 other project) "ftbfs on all archs (affects: 1) (heat: 6)" [High,Fix released] https://launchpad.net/bugs/824669
[13:04] <ubot4> Launchpad bug 826772 in ubuntuone-installer "Installer currently hardcodes 'natty' as series (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/826772
[13:04] <dobey> alecu
[13:05] <ralsina> dobey: I need to talk to you about bug #820345
[13:05] <ubot4> Launchpad bug 820345 in ubuntuone-client (Ubuntu) (and 1 other project) "Please remove UbuntuOne from MessagingMenu (affects: 2) (heat: 14)" [Undecided,Confirmed] https://launchpad.net/bugs/820345
[13:06] <alecu> DONE: worked on bug #824819, started re-review of nessita's branch
[13:06] <alecu> BLOCKED: by a few more broken things I found on windows while fixing tests, like http://pastebin.ubuntu.com/666883/
[13:06] <alecu> TODO: see if the above only happens to me, work on #824003
[13:06] <ubot4> Launchpad bug 824819 in ubuntuone-client "SD and tests need to wait until a watch is removed (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/824819
[13:06] <alecu> nessita, ralsina, gatox: can you guys try the above pastebin?
[13:06] <nessita> alecu: sure
[13:06] <nessita> alecu: linux or windows?
[13:06] <dobey> ralsina: ok
[13:06] <alecu> nessita, windows
[13:06] <gatox> alecu, ok
[13:07] <alecu> gatox, make sure to do "from ubuntuone.syncdaemon import tritcask" first.
[13:07] <nessita> alecu: I have 100 all the tiem
[13:07] <gatox> alecu, ok
[13:07] <nessita> time*
[13:08] <nessita> alecu: but it's been ages since I rebooted this VM
[13:08] <ralsina> alecu: I get 100 all the time too
[13:08] <nessita> alecu: we had an issue with this, but verterok fixed it
[13:09] <alecu> nessita, ralsina: 100 is perfect
[13:09] <nessita> alecu: you 100% up to date?
[13:09] <alecu> nessita, this happens after I merged trunk.
[13:09] <alecu> nessita, I should try on trunk
[13:09] <gatox> alecu, http://paste.ubuntu.com/667280/
[13:09] <gatox> alecu, i don't get 100 all the time
[13:09] <nessita> wow
[13:09] <nessita> gatox: you booted this machine today?
[13:09] <ralsina> alecu:   len(set(len(set([tritcask.DataFile._get_next_file_id() for n in range(100)])) for i in range(1000))) == 1
[13:09] <gatox> nessita, no..... should i do that?
[13:10] <nessita> gatox: nopes
[13:13] <alecu> nessita, gatox: virtualbox on 32bits or 64?
[13:13] <nessita> alecu: 32 for me
[13:13] <nessita> alecu: ah, sorry, I misunderstood
[13:14] <nessita> alecu: host is 64, guest is 32
[13:14] <alecu> nessita, the same on my case.
[13:14] <gatox> alecu, 32
[13:14] <gatox> alecu, same as nessita
[13:14] <gatox> alecu, the vm is 32... host 64
[13:16] <alecu> anyway: this shows that time.clock is not being reliable (at least under vbox): it's returning the same value for calls near in time
[13:16] <alecu> this broke a few of the tests, and it's been hell to debug
[13:17] <nessita> alecu: you sure you're running latest trunk? we added a fix for this recently (bah, verterok did)
[13:17]  * verterok looks around
[13:17] <ralsina> alecu: hmmm... check if you have virtualbox's "fix client's clock" set
[13:17] <ralsina> and/or windows's NTP equivalent (in control panel, date/time)
[13:17] <nessita> verterok: hey there! alecu is having bad-bad issues with tritcask file generation, id's gets duplicated
[13:18] <verterok> nessita: yes, reading the backlog
[13:18] <alecu> ralsina, windows' ntp updates the time *just* once every day
[13:18] <ralsina> alecu: ok, so that's not it
[13:18] <verterok> alecu: tritcask is now using time.time() + time.clock() it has more resultion/accuracy than time.time on linux :p
[13:18] <alecu> ralsina, also, I've tried setting the vbox time update flag, and the result is the same. Let me fetch the article that explains it...
[13:19] <nessita> alecu: do you have a WindowsTimer inside ubuntuone/syncdaemon/tritcask.py?
[13:19] <verterok> nessita: I was about to ask that :)
[13:19] <verterok> maybe it's using a installed tritcask?
[13:19] <nessita> alecu: maybe your syncdaemon is loading an "old" pyc for tritcask, from an old install, for example?
[13:19] <nessita> right
[13:20] <ralsina> "print tritcask" should clear that
[13:20] <alecu> nessita, verterok: let me check that.
[13:21] <alecu> btw, I tried with: vboxmanage setextradata <vmname> "VBoxInternal/Devices/VMMDev/0/Config/GetHostTimeDisabled" "1"
[13:21] <alecu> as explained here: http://the-starport.net/freelancer/forum/viewtopic.php?topic_id=4100
[13:21] <alecu> but it seems to fix a different issue.
[13:29] <alecu> nessita, verterok: I added a "print '*'," inside WindowsTimer.time, in trunk, and I just made sure I'm using the latest version, and I still get the same behaviour.
[13:30] <alecu> it seems that time.clock is not moving forwards :P
[13:30] <verterok> alecu: that's weird :(
[13:31] <alecu> verterok, I even tried adding three zeroes to the multiplier in _get_next_file_id
[13:32] <verterok> alecu: could you try this: python -c "import time; time.clock(); print [time.clock() for i in range(10)]"
[13:33] <alecu> verterok, !!!!
[13:34] <alecu> verterok, on the second run it was all zeroes!!! :P
[13:34] <alecu> verterok, http://pastebin.ubuntu.com/667307/
[13:34] <alecu> verterok, on the first run they were sensible values
[13:34] <verterok> your clock is broken(?!?)
[13:35] <verterok> this is a big WTF
[13:35] <alecu> verterok, and it happens 50%: http://pastebin.ubuntu.com/667310/
[13:36] <verterok> alecu: is this a win 7 vm, right?
[13:36] <alecu> verterok, win 7 32bits, on the latest virtualbox on a natty 64bits
[13:36] <verterok> ok, I don't have the same env :(
[13:37] <alecu> verterok, gatox managed to reproduce this, but neither nessita nor ralsina were able to reproduce it.
[13:37] <verterok> maybe virtualbox is broken?
[13:37] <alecu> verterok, yeah, it looks like it.
[13:37] <verterok> alecu: all are using the same virtualbox version?
[13:37] <ralsina> we can switch to the timeit module, I suppose :-(
[13:37] <nessita> ralsina: your windows is not a vm but a real install, right?
[13:38] <ralsina> nessita: yes, a real one
[13:38] <verterok> ralsina: no we cant :(
[13:38] <verterok> ralsina: timeit uses time.clock in windows :p
[13:38] <ralsina> he
[13:39] <nessita> ralsina: can you run the "test" several times with a clean reboot to see if we can reproduce this outside VB?
[13:39] <gatox> ralsina, nessita trivial branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/congratulations-typos/+merge/71690
[13:39] <nessita> gatox: looking!
[13:39] <ralsina> no, I can't reboot because I am in the management call :-(
[13:40] <Milos_SD> Hi
[13:40] <nessita> ralsina: maybe later? :-/
[13:40] <Milos_SD> I have a little problem uploading 1.4 GB zip file on ubuntu one free account...
[13:40] <ralsina> in about one hour, yes
[13:41] <alecu> nessita, ralsina: I need to be afk for an hour or so.
[13:41] <Milos_SD> upload was done, but "please wait" was still there, and would never go away... :S
[13:41] <nessita> alecu: were you able to finish my review?
[13:41] <Milos_SD> is it possible to upload such a big file?
[13:41] <alecu> nessita, not yet
[13:41] <verterok> Milos_SD: hi, is this using the web or the desktop client?
[13:41] <nessita> alecu: ok, I'll share some comments with you when you get back
[13:42] <Milos_SD> verterok, web
[13:42] <alecu> nessita, some comments on that branch?
[13:42] <verterok> rye: around?
[13:42] <rye> verterok, around
[13:42] <verterok> rye: hi! Milos_SD is having some problems uploading via the web...do you know something about that? :)
[13:42] <nessita> alecu: yeap -> confirmed that dont-shutil-move does not fail when committting a partila file that is failing in trunk. maybeBadNews is this: http://pastebin.ubuntu.com/667286/ (watch warnings over files)
[13:43] <rye> Milos_SD, could you please try going to https://one.ubuntu.com/files/ and see whether the file has been uploaded indeed, w/o closing the first tab
[13:43] <Milos_SD> verterok, I don't even know if I can upload specific file from desktop client
[13:43] <nessita> alecu: but if you need to go, we can talk later (but before 12ART please)
[13:43] <Milos_SD> nessita, I closed that tab a long time ago :)
[13:43] <Milos_SD> rye, I closed that tab a long time ago*
[13:44] <alecu> nessita, ack.
[13:44] <gatox> nessita, i'm changing something in my branch... let you know in a while
[13:44] <Milos_SD> there was no network activity at my side... but "please wait" was still there :S
[13:44] <nessita> gatox: ack
[13:46] <rye> Milos_SD, ah, and the file is not there, I supposed?
[13:46] <Milos_SD> rye, yes... there is no file there :(
[13:52] <Milos_SD> rye, maybe there is some problem with time spent uploading? I have only 512 Kbps upload, so it would take up to 7 hours to upload 1.4 GB file...
[13:53] <rye> Milos_SD, is your IP address static? Could you please PM me your current IP address?
[13:53] <Milos_SD> rye, it is not static... but I have cable internet, so lease is very high
[13:54] <rye> Milos_SD, well, "static enough" - I want to see whether we have reports of your upload failing
[13:56] <gatox> nessita, branch updated
[13:57] <nessita> gatox: ack
[14:06] <nessita> gatox: this does not look right:
[14:07] <nessita> "launch the dashboard to get more information about the sync in progress". I think it should be "sync progress" and not "in progress"
[14:07] <nessita> gatox: another question, you added 2 checkboxes but the logic for those is not added?
[14:08] <ralsina> nessita "the sync in progress" is grammatically correct. So is "the sync progress", of course :-)
[14:08] <nessita> ralsina: both are gramatically correct in isolation, but in the context used I don't think "in progress" is correct
[14:09] <nessita> ah, I just read it with a different "accent" and I see the other possibility
[14:09] <gatox> nessita, i've created another bug to add the logic of those checkboxes, because the bug says that the Congratulations page only have some typos... in order to submit that and don't delay the branch for other issue...
[14:09] <ralsina> hehe
[14:09] <nessita> "launch the dashboard to get more information about the sync that is in progress"
[14:09] <ralsina> exactly
[14:09] <gatox> nessita, should i close the new bug and do it all together?
[14:09] <nessita> gatox: then don't add the checkboxes in that branch...
[14:09] <nessita> gatox: just submit the typo in this branch
[14:09] <nessita> so you can fix that bug
[14:10] <ralsina> also, unless the width change is actually necessary, there is no point changing that line
[14:10] <gatox> nessita, ok... and about the text... i copy the text from the wireframe
[14:10] <gatox> that was updated
[14:10] <nessita> gatox: ok then
[14:12] <gatox> nessita, ok..... branch updated..... in the next one (later) i will add the checkboxes with the logic
[14:13] <nessita> great
[14:21] <nessita> gatox: approved and globally approved
[14:33] <ralsina> nessita, verterok: is it still useful if I reboot and try the tritcask thing?
[14:33] <nessita> ralsina: afaik, yes, we have no new ideas in that front
[14:34] <ralsina> ok, this is going to take a while...
[14:46] <highvoltage> hi! will there ever be an Ubuntu One appliance? I have a school district that's using iFolder and Ubuntu One would make a great replacement if they could store data locally
[14:52] <ralsina> nessita, verterok: rebooted twice, windows 7 64 bits, I always get good results
[14:52] <nessita> alecu: just in time! see what ralsina says
[14:52] <alecu> nessita, are you still available to tell me about that issue?
[14:52] <nessita> alecu: yes sir
[14:52] <verterok> ralsina: great news for tritcask, bad news for virtualbox(?)
[14:52] <nessita> alecu: did you get any chance to look at the paste?
[14:52] <ralsina_> I will now try a VM see what happens there
[14:53] <alecu> nessita, I'm looking at the paste, but I don't understand what's broken in it
[14:54] <nessita> alecu: I'm not sure if something is broken, I saw this: 2011-08-16 10:08:59,510 - ubuntuone.SyncDaemon.filesystem_notifications.GeneralProcessor - WARNING - Ignoring path as we don't have enough permissions to track it: 'C:\\Users\\Test\\Ubuntu One\\fideos: dos?.png'
[14:54] <nessita> alecu: and that "looks" buggy
[14:54] <alecu> verterok, I remember that you told me that tritcask cannot use an incremental numbering because of something..... what was it?
[14:54] <nessita> alecu: the path is not readonly, but is not  dir. So I see that log warning and makes me think that maybe we have a bug in the add watcher code?
[14:55] <verterok> alecu: tritcask needs the timestamp in the data file name as it's a way to easily sort the files
[14:56] <ralsina_> verterok: on a XP vm I get much *smaller* values, but not 0: https://pastebin.canonical.com/51293/
[14:56] <alecu> verterok, what if we add a dot-numbering to the filenames?
[14:56] <verterok>  we can change that, but it means a metadata migration in linux
[14:56] <alecu> verterok, as in timestamp-sequence.cask ?
[14:56] <alecu> verterok, oh, right.
[14:57] <alecu> ralsina_, small is nice. Zero is plain wrong.
[14:58] <verterok> ralsina_: those values looks good
[14:58] <verterok> alecu: do you have the same python version? any weird import from __future__ (like, from __future__ import round :p)?
[14:59] <ralsina_> version of virtualbox?
[14:59] <alecu> verterok, I'll take a look
[14:59] <verterok> alecu: I understand what you'r trying to solve with the sequence...but I think the problem is something outside sd implementation
[14:59] <alecu> verterok, it surely looks like it. And I'm willing to concede it's a virtualbox bug
[15:00] <alecu> verterok, but this means we will not be able to run any kind of tests in virtualbox
[15:00] <alecu> nessita, I think I found it: "os.access(path, os.R_OK)"
[15:00] <verterok> alecu: also the sequence workaround might not be enough, we need to think on a more broad change
[15:01] <alecu> nessita, it's using path as a byte sequence
[15:01] <verterok> alecu: use kvm? :)
[15:01] <nessita> alecu: ack, I'll file a bug
[15:01] <alecu> nessita, in is_ignored() in ubuntuone/syncdaemon/filesystem_notifications.py
[15:01] <verterok> alecu: I did the change using virtualbox, so it's working there
[15:02] <alecu> verterok, it's working for ralsina and nessita on virtualbox too... but it fails for gatox too
[15:02] <alecu> verterok, but if I was nessita or ralsina_, I would not trust it either...
[15:02] <alecu> hmmm
[15:02] <ralsina_> alecu, gatox, nessita: what is your VBox version?
[15:02] <alecu> gatox, what's you cpu? amd?
[15:03] <verterok> alecu: so, 3 - 2...we win!
[15:03] <alecu> verterok, hahahaha
[15:03] <nessita> alecu: model name	: Intel(R) Core(TM) i5 CPU         750  @ 2.67GHz
[15:03] <alecu> I'm sure nessita and ralsina and verterok are on intel
[15:03] <alecu> I'm on an amd
[15:03] <alecu> gatox?
[15:03] <ralsina_> yes, i5 here
[15:03] <nessita> alecu: VB is a 4.1.0
[15:04] <ralsina_> I am in 4.0.4 so it's probably not the version
[15:04] <gatox> alecu, ralsina_ vbox version: 4.0.10_ubuntu r72426
[15:04] <gatox> alecu, sorry for the delay...... about window don't let copy the version and it closes everytime it lose the focus :P
[15:04] <gatox> alecu, my host is intel core2duo
[15:05] <alecu> 4.0.12 r72916
[15:05] <alecu> gatox, :-)
[15:05] <ralsina_> hmmm... here's an idea. Alecu: on one terminal, start a "dir /s c:\"
[15:05] <ralsina_> and on another try the clock thing
[15:06] <alecu> ralsina_, good point
[15:06] <ralsina_> There are some old bug reports about the clock being stuck if the VM is idle
[15:06] <alecu> also, please everybody: let's paste the version of the "virtualbox guest additions"; mine: 4.0.10 r72479
[15:07] <alecu> I should probably update them to the latest version too.
[15:07] <ralsina_> How about let's try updating everything to the latest and it may fix itself?
[15:08] <alecu> ralsina_, the thing is that my vbga do not match my vbox
[15:08] <alecu> ralsina_, running dir/s did not help
[15:08] <ralsina_> alecu: interesting
[15:09] <nessita> alecu: where can I see that version?
[15:09] <nessita> alecu: I installed VB from the website .deb, not from our repos
[15:09] <alecu> nessita, me too
[15:09] <alecu> nessita, in the tray bar, hover over the vbox icon
[15:09] <alecu> nessita, open the traybar with the up arrow if needed.
[15:10] <alecu> nessita, 4.1.0 ?
[15:10] <nessita> 4.1.0r73009
[15:10] <alecu> hmmm... then my vbox must be from the repos instead.
[15:11] <nessita> alecu: returning to the watch issue, I also noticed in http://pastebin.ubuntu.com/667286/ that the WARNING appears twice, which sounds suspicious (specially since we have threads involved)
[15:11] <nessita> gatox: where did you install VB from?
[15:11] <rodrigo_> CardinalFang, thisfred_: I have a bug for you -> https://bugs.launchpad.net/ubuntu/+source/desktopcouch/+bug/780972 <- do you have any idea what's causing it?
[15:12] <ubot4> Launchpad bug 780972 in desktopcouch (Ubuntu) "desktopcouch-service crashed with Unauthorized in request(): ('unauthorized', 'Authentication required.') (affects: 144) (dups: 9) (heat: 698)" [High,Confirmed]
[15:12] <gatox> nessita, from repository
[15:12] <rodrigo_> CardinalFang, thisfred_: because of that, dc doesn't work at all for me on oneiric
[15:12] <nessita> gatox: ah!
[15:13] <alecu> nessita, "deb http://download.virtualbox.org/virtualbox/debian maverick contrib"
[15:13] <nessita> maverick? hum
[15:13] <nessita> alecu: no natty?
[15:14] <alecu> nessita, so mine's from upstream
[15:14] <nessita> alecu: can you try this one? http://download.virtualbox.org/virtualbox/4.1.0/virtualbox-4.1_4.1.0-73009~Ubuntu~natty_amd64.deb
[15:14] <alecu> nessita, I very likely installed it when natty was being developed
[15:14] <alecu> nessita, sure!
[15:14] <nessita> alecu: or choose the best for you: http://download.virtualbox.org/virtualbox/4.1.0/
[15:18] <thisfred_> rodrigo, I'll have a quick look
[15:18] <rodrigo_> thisfred_, thanks!
[15:21] <alecu> nessita, the duplicated logs seem to come from the loop in freeze_commit
[15:21] <nessita> looking
[15:22] <alecu> nessita, it seems to me that there are a pair of events coming from the same path, and being ignored there
[15:26] <nessita> alecu: I followed the code and I'm not sure what 2 pair of events are being ignored
[15:27] <dobey> lunch time, bbiab :)
[15:27] <alecu> nessita, do you have more context for this log?
[15:27] <alecu> nessita, more lines above the ones you pasted?
[15:28] <nessita> alecu: the whole run is: http://pastebin.ubuntu.com/667282
[15:33] <alecu> nessita, ubuntuone/platform/windows/filesystem_notifications.py, process_IN_MOVED_TO()
[15:34] <nessita> alecu: without checking, this code looks duplicated from linux.... is that soe?
[15:34] <alecu> nessita, there are the two calls to is_ignored
[15:34] <nessita> right
[15:34] <alecu> nessita, I've no idea if this is duplicated
[15:35] <thechef> Can I buy music using the phone?
[15:36] <nessita> alecu: how did you end up checking process_IN_MOVED_TO? I don't see the "move" in the log
[15:39] <alecu> nessita, I looked at what was calling is_ignored()
[15:39] <alecu> nessita, and that place looks likely, because there are two calls in a row
[15:40] <nessita> alecu: if we're having a move event in this case, we're in problems (ie we're getting events that we should not be getting)
[15:41] <nessita> which brings me back to the fact that we need to fix the eq_inotify tests...
[15:41] <nessita> alecu, ralsina_, gatox, Chipaca (if available): can we have the mumble?
[15:41] <ralsina_> nessita: fine by me
[15:43] <gatox> nessita, ack
[15:44] <nessita> alecu: can you join mumble please?
[15:53] <thisfred> dobey: rodrigo_: https://bugs.launchpad.net/ubuntu/+source/desktopcouch/+bug/780972 confirmed, I have no idea why though. Could be new couchdb with missing /broken patches, could be broken js in new couchdb again, could be something changed in the way we store the oauth keys. I really have no time to debug this right now.
[15:53] <ubot4> Launchpad bug 780972 in desktopcouch (Ubuntu) "desktopcouch-service crashed with Unauthorized in request(): ('unauthorized', 'Authentication required.') (affects: 144) (dups: 9) (heat: 698)" [High,Confirmed]
[15:57] <thisfred> dobey: rodrigo: no errors in the couchdb logs though (just 401s), so it may not be couchdb itself at all, and we're just not sending the right tokens, or not storing them in couchdb in the first place.
[16:12] <alecu> nessita, http://webchat.freenode.net/
[16:14]  * nessita -> teaching duties
[16:14] <nessita> bye all!
[16:23] <gatox> ralsina_, it seems that it's going to be an easy fix change the messagebox for the label in all the pages
[16:28] <dobey> thisfred: pensive panda
[16:28] <thisfred> pessimistic pony
[16:29] <dobey> ponderous plato
[16:41] <dobey> not sure why, but for some reason i am wary of products with "super quality" in their name
[16:45] <gatox> ralsina_, ping
[17:10] <gatox> ralsina_, let me know when you are back... i've a branch almost ready for revision.... but there is something i'm not quite convince
[18:31] <ralsina_> gatox: I'm back sorry, family things
[19:07] <gatox> ralsina_, actually when critical it's called from controller, it is called with 4 params: self.view, self.view.wizard().app_name, CAPTCHA_LOAD_ERROR
[19:08] <ralsina_> yes...
[19:08] <gatox> ralsina_, is it of if i modified that calls to just pass the string?? the other params now that it's just a simple label are no longer necessary
[19:08] <gatox> *of = ok
[19:08] <gatox> is it ok....?
[19:08] <ralsina_> I don't really remember that code
[19:09] <ralsina_> is critical() defined on the wizard or in the page?
[19:09] <gatox> wizard
[19:09] <ralsina_> or is it gettig a real QMessageBox?
[19:09] <gatox> critical creates a qmessagebox on the wizard and show it
[19:10] <gatox> and in controllers if the param message_box is None, it creates a QMessageBox
[19:10] <ralsina_> ok, cool then it's ok :-)
[19:11] <gatox> ralsina_, ok.... i'll keep working on that... i'm having problems with some tests, but the code seems to be ready
[19:12] <ralsina_> what tests?
[19:17] <gatox> ralsina_, they are some tests actually testing "critical", but now i changed the behavior of that function... just that
[19:17] <ralsina_> oh, ok
[20:16] <ralsina_> I am stopping for a while. Will work some more late tonight, so please email review requests etc.
[20:24] <gatox> ralsina_, ok, i'm finishing the tests for my branch
[20:24] <gatox> so i'll let you know
[20:24] <ralsina_> cool
[20:25] <gatox> ralsina_, i was more time writing fixing tests than code :P
[20:25] <ralsina_> gatox: he, that's standard ;-)
[20:41] <gatox> Ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/71773
[20:41] <gatox> https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/bug-820872/+merge/71774
[20:54] <dobey> have a good evening all
[20:55] <gatox> dobey, bye
[22:01] <nessita> hello everyone!
[22:01] <nessita> alecu: ping
[22:05] <nessita> ralsina_: you around?
[22:06] <ralsina_> nessita: hi
[22:07] <nessita> ralsina_: hi there. Would you know if alecu finished the review of my inherited branch? LP shows no review from him
[22:07] <ralsina_> nessita: didn't hear from him after you left
[22:07] <nessita> oh
[22:08] <alecu> nessita, hi
[22:08] <nessita> alecu: hi there!
[22:08] <alecu> nessita, I left the test running...
[22:08] <ralsina_> and here he is :-)
[22:08] <alecu> let me approve it
[22:08] <nessita> alecu: thanks! :-)
[22:09] <ralsina_> if noone needs anything right now, I'll go  back to playing "Battle beavers" with Tato :-)
[22:09] <ralsina_> I will do reviews late tonight though
[22:10] <alecu> ralsina_, what's "Battle beavers"?
[22:10] <ralsina_> alecu: http://www.abcjuegos.net/juego/battle-beavers
[22:10] <ralsina_> not as interesting as it sounds ;-)
[22:10] <alecu> :-)
[22:11] <ralsina_> nessita, alecu: if I could get a review for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/too-soon/+merge/71426 it would be great
[22:13] <nessita> ralsina_: in that branch, question:
[22:13] <ralsina_> shoot!
[22:13] <nessita> ralsina_: when do you stop the timer? I mean, I would expect the timer to be turned on only when "entering" the folders page, and stopping it when leaving it
[22:14] <ralsina_> it is started when entering, but forgot to stop it, right
[22:14] <nessita> otherwise looks like it wastes resources when is not needed...
[22:14] <ralsina_> I will add a stop when switching to the next page
[22:14] <nessita> ralsina_: also, please add tests! :-) (faking the timer, I would advice)
[22:14] <ralsina_> nessita: the function that the timer calls has tests
[22:15] <nessita> ralsina_: I hate having this conversation!!! :-)
[22:15] <ralsina_> ok, let's not have it then. I will figure out more tests, I suppose.
[22:15] <nessita> you need to test every single line of code you add. This is new functionality, we want tests for it...
[22:15] <ralsina_> The timer is not new functionality
[22:16] <ralsina_> it has been there for a month
[22:16] <ralsina_> but sure, I will add it
[22:16] <nessita> thanks
[22:16] <nessita> ralsina_: also, we should have a test for the self.ui.add_folder_button.backend.account_info failing, to ensure we;'re no having errors like before
[22:16] <ralsina_> Since I already I test what the timer triggers, I could add a test that the timer is startted, I suppose. But don't worry, I will add 10 or 12 more tests.
[22:17] <ralsina_> bye, see you all tomorrow.
[22:34] <gatox> nessita, i send you a branch for review
[22:34] <gatox> sent*
[22:35] <gatox> 2 branches :P
[22:35] <nessita> gatox: have the links handy please?
[22:36] <gatox> nessita, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/71773
[22:36] <gatox> nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/bug-820872/+merge/71774
[22:36] <gatox> nessita, they are related
[22:39] <nessita> gatox: so, one question...
[22:39] <nessita> gatox: is the sso code calling the critical method that is defined in windows installer?
[22:40] <nessita> that is puzzling my head, shouldn't that be the other way around?
[22:40] <nessita> gatox: or critical is also defined in sso?
[22:44] <gatox> nessita, no, it's calling the critical method in the installer, because the controller receive an instance of the wizard
[22:45] <gatox> nessita, sorry, of the pages
[22:45] <gatox> but with the pages you can access the wizard
[22:45] <nessita> gatox: what if someone uses a wizard that does not have the critical method defined?
[22:46] <nessita> gatox: should the sso side send a siganl, and the other side should connect to the signal and do something in that case?
[22:46] <gatox> nessita, sorry.... not following...... there is only one wizard.....
[22:46] <nessita> gatox: what I mean is:
[22:46] <nessita> gatox: the sso client is a generic project that can be used from any app, not only from the installer, so
[22:46] <gatox> nessita, wait wait.... i know where is the confusino
[22:46] <nessita> you do?
[22:46] <nessita> I read then
[22:47] <nessita> gatox: where is the confusion?
[22:48] <gatox> the sso controller.... receive a message_box... this message_box is really an instance of wizard, but can also be a QMessageBox.... the critical method in the wizard works as a wrapper for create a QMessageBox and call the critical method (before)... now this method show a form error label... but the critical method, belongs to the message_box object that you give to the sso
[22:48] <gatox> from the installer when you create a controller you establish what this message_box object would be..... in this case is self, because the installer wizard implement "critical"
[22:49] <ralsina> The message_box object is anything that has a "critical" method. By default it's a QMessageBox.
[22:50] <gatox> nessita, yes, if you don't pass a references for something at the message_box param... it will create a QMessageBox
[22:51] <nessita> gatox: understood now!
[22:51] <gatox> nessita, nice
[22:51] <nessita> ralsina: you're back! I was writting an email to you
[22:51] <ralsina> nessita: I thought I had to run, but it turns out I did not
[22:51] <ralsina> so I have a little more time
[22:52] <ralsina> therefore, pushed the branch with the test for when there is an exception on account_info()
[22:52] <ralsina> the only "new" code is moving those lines inside the try/except so that test should cover them.
[22:52] <ralsina> There is no way to stop the timer yet because there is no "next page" method, that's on the next branch
[23:10] <nessita> ok, I gotta make some dinner, I'm starting to starve
[23:11] <nessita> see ya all tomorrow
[23:11] <nessita> bye!
[23:11] <gatox> nessita, bye