[00:00] <EdwinGrubbs> wgrant: thanks. I guess it can go away if bug 315358 is ever completed.
[00:00] <mup> Bug #315358: Expose the storeblob service in API <api> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/315358>
[00:01] <wgrant> EdwinGrubbs: Mmmmm, possibly.
[00:01] <wgrant> EdwinGrubbs: But the API is awkward right now.
[00:03] <wgrant> EdwinGrubbs: apport has broken once or twice in the past when field names changed on that page. I think there's a test for that now, but best to just check that manually..
[00:04] <EdwinGrubbs> wgrant: we're just changing the template which defines the header. So it would be hard to imagine how it could break.
[00:05] <wgrant> EdwinGrubbs: That sounds safe, yes.
[04:05] <thumper> jml: you on call?
[04:06] <jml> thumper, yes.
[04:06] <thumper> jml: bug 407643
[04:06] <mup> Bug #407643: CodeImportNewView confusing after form changes <Launchpad Bazaar Integration:In Progress by thumper> <https://launchpad.net/bugs/407643>
[04:06] <thumper> jml: take a look at the attached image
[04:06] <thumper> jml: the fix is all in the page template
[04:06] <thumper> branch is pushed
[04:06] <thumper> I'm awaiting the scan
[04:07] <thumper> I'd be tempted to rs it myself
[04:07] <thumper> it is very simple
[04:07] <thumper> no test changes needed
[04:07] <thumper> it just indents the fields
[04:08] <jml> thumper, the screenshot looks fine to me.
[04:08] <jml> thumper, I'd still like to have a poke at the code
[04:08] <thumper> jml: it is closer to what it used to be
[04:08] <thumper> jml: I've proposed for merging with you as reviewer
[04:10] <jml> thumper, thansk.
[06:07] <jml> mwhudson, I've replied to your review
[06:12] <mwhudson> jml: woo
[06:24] <jml> sinzui, you too.
[06:36] <mwhudson> jml: replied
[06:38] <jml> mwhudson, thanks.
[09:29] <noodles775> I'm guessing jml has finished reviewing for the day :)
[09:30] <jml> I has.
[09:36] <allenap> noodles775: Fancy a incredibly trivial one-line review?
[09:36] <allenap> https://code.edge.launchpad.net/~allenap/launchpad/rocketfuel-get-overwrite/+merge/12038
[09:36] <noodles775> allenap: sure - I'd ask for a swap but mine's 500 lines :/
[09:36] <allenap> noodles775: Heh :)
[09:37] <allenap> noodles775: The diff is going to take a while, so here's one I prepared earlier: http://pastebin.ubuntu.com/273315/
[09:37] <noodles775> Cool.
[09:38]  * noodles775 reads the emails.
[09:42] <noodles775> allenap: so your branch will result in *all* branches updated including the overwrite flag right? Are there any side-effects or dangers in doing this?
[09:42] <allenap> noodles775: If someone has edited one of their sourcecode branches it will be clobbered.
[09:43] <allenap> noodles775: But people - including me - shouldn't really be making a habit of that, because if I forget to revert I might get strange behaviour in other branches.
[09:44] <noodles775> allenap: ah, so update_branches() is only ever called in update_sourcecode() - right.
[09:44] <noodles775> Yep.
[09:44] <allenap> noodles775: Yep, I think so.
[09:44] <noodles775> Yep, it is (currently).
[09:45] <noodles775> allenap: r=me sent.
[09:45] <allenap> noodles775: Thanks!
[09:45] <noodles775> np.
[10:03] <wgrant> jml: Did you get around to the update-sourcecode fixes, or should I do it now I've time?
[12:55] <noodles775> adeuring: are you available for reviews today?
[12:56] <adeuring> noodles775: i'm afraid that i would produce quite some nonsense today: have th fl
[12:56] <adeuring> thre flu
[12:56] <noodles775> adeuring: np! Hope you get better soon!
[12:56] <adeuring> noodles775: thanks!
[13:53] <jml> wgrant, I didn't get around to it.
[13:53] <wgrant> jml: OK, thanks. I'll do it tomorrow.
[14:05] <barry> looks like it might be noodles for breakfast?!
[14:06] <noodles775> heh, barry, could you pls look at this one first:
[14:06] <noodles775> https://code.launchpad.net/~michael.nelson/launchpad/432416-binary-pkg-index-oops/+merge/12051
[14:06] <noodles775> it's the most urgent of my three (and related to one you ui-reviewed for me yesterday).
[14:07] <barry> noodles775: sure thing
[14:07] <noodles775> Thanks!
[14:07] <noodles775> barry: I'm just going to take a break for 20 mins.
[14:07] <barry> noodles775: no worries
[14:13] <BjornT> barry: i have a branch that needs reviewing as well. it's non-urgent, but also really simple (all it does is to add a test)
[14:13] <barry> BjornT: cool.  salgado should be joining me here today, but i think abel is still out
[14:16] <salgado> barry, I don't think I'll be able to join you, sorry.  I've got 171 tests failing on my breadcrumbs branch
[14:17] <barry> salgado: double :(
[14:18] <barry> salgado: good luck!
[14:32] <noodles775> I'm back barry if you have any questions etc.
[14:32] <barry> k
[14:33] <gmb> noodles775: Do you have the time to give me a UI review?
[14:34] <noodles775> gmb: yep, add me as a ui-reviewer - I'll try to look at it in the next hour.
[14:35] <gmb> noodles775: Awesome, thanks.
[14:40] <noodles775> henninge: it's looking great! I've just merged so I can take a quick look at the issues you identified.
[14:40] <henninge> noodles775: thanks. I am currently adding icons to the "What's Launchpad" list.
[14:42] <abentley> barry: I can has review? https://code.edge.launchpad.net/~abentley/launchpad/restyle-subscriptions/+merge/12008
[14:42] <noodles775> henninge: so you can left-align the stats simply by removing the text-align: center from #homepage-stats in style.css.
[14:43] <henninge> noodles775: it is meant to left-align with the left edge of the search field.
[14:44] <henninge> at least that's what the mock-up looks like but I am not sure Martin did that on purpose.
[14:44] <noodles775> henninge: and it does doesn't it? (I'm juts disabling the rule and it seems to do exactly that?)
[14:44] <noodles775> or did I misunderstand?
[14:44] <henninge> I am trying now .. ;)
[14:45] <henninge> wow, it (almost) works!
[14:45] <henninge> still have to adjust the width.
[14:46] <henninge> noodles775: I tried a few things this morning but this must be a combination I missed ... ;-)
[14:46] <noodles775> henninge: aha. Also the 'Take the tour' is pointing to +newteam for some reason.
[14:47] <henninge> oops, copy-and-paste ...
[14:47] <barry> abentley: put it on the list!
[14:47] <henninge> noodles775: wait, which one?
[14:47] <abentley> barry: Okay.  I always ask first.  Should I not do that?
[14:47] <henninge> there are two, one left, one right.
[14:48] <henninge> ah, got it, noodles775
[14:48] <barry> abentley: as the day wears on, it's gets better to ask :)
[14:49] <barry> (or as the queue grows)
[14:51] <EdwinGrubbs> barry: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/featured-projects-ui-3/+merge/12053
[14:51] <barry> EdwinGrubbs: you can put it on the queue, but it's going to be a while.
[14:55] <noodles775> henninge: and the un-clickable login/logout/user is because the #locationbar seems to have a calculated height of 0px... still trying to find out why. Explicitly setting it to 1em gets around it, but better to find the real cause.
[14:56] <henninge> noodles775: oh, wgrant pointed me to a bug about it!
[14:56] <henninge> noodles775: Bug #429247
[14:56] <mup> Bug #429247: Locationless <h1>s block login/out widgets <story-ui-3> <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/429247>
[14:57] <noodles775> henninge: great, I just updated it with that info.
[14:57] <noodles775> Thanks!
[14:58] <jtv> Who broke our front page?
[14:58] <jtv> noodles775?
[14:59] <noodles775> jtv: probably - if it's looking for isBetaUser then yes :/...
[14:59]  * noodles775 looks
[14:59] <noodles775> jtv: huh? what's the problem that you're seeing?
[14:59] <jtv> noodles775: something it uses obviously tries isBetaUser, yes
[15:00] <noodles775> jtv: barry is reviewing a fix for that now... but I don't see it on the front page... ah, the translations front page.
[15:00] <jtv> I guess that page got the application tabs through means other than the way your check expected
[15:00] <jtv> Yes.
[15:00] <noodles775> jtv: More likely your view does not inherit from LPView... checking now.
[15:01] <jtv> It's more than just our front page, actually.  :/
[15:01] <noodles775> jtv: it's any view that does not inherit from LPView...
[15:02] <noodles775> jtv: I wrongly assumed that all non-locationless pages in LP inherit from LPView - but there are *heaps* of old views that don't. I should have checked... sorry.
[15:02] <jtv> I figured.  And the pages apparently get their application tabs through means other than what the check expected
[15:02] <noodles775> jtv: the fix is simple, hopefully I can land it soon.
[15:03] <jtv> Maybe worth updating those views as well, sometime after release.
[15:03] <jtv> Should I file bugs?
[15:04] <noodles775> jtv: no, the fix is a general one...
[15:04] <jtv> I meant about making views inherit from LaunchpadView.  But that too may be best done automatically and centrally.
[15:05] <noodles775> jtv: oh, perhaps. But yes, as a general bug, I've got a list here: http://pastebin.ubuntu.com/273421/
[15:06] <jtv> noodles775: cool...  if/when we really want to do something about it, I guess we could correlate that list of class names to stuff we find in zcml.
[15:09] <rockstar> barry, if your queue still looks like this after I get these two branches landed, I'd be happy to help out.
[15:11] <barry> rockstar: awesome, thanks
[15:12] <barry> noodles775: first review sent
[15:12] <noodles775> Thanks barry.
[15:12] <barry> noodles775: see what you think of my proposed alternative
[15:13] <noodles775> barry: I'll give it a try... one tic.
[15:14] <henninge> noodles775: I quite like setting locationbar to 1.5em...
[15:15] <noodles775> henninge: great, it fixes the issue, so might be a good solution in and of itself.
[15:15] <henninge> noodles775: it looks good on all pages, I always thought they had too little space at the top.
[15:18] <henninge> 1em is enough, though.
[15:25] <intellectronica> barry: can i bother you for a quick ui review? martin has already given a thumbs up for a previous version, so this is just a last check before i can land
[15:26] <intellectronica> barry: https://devpad.canonical.com/~tom/bugs-homepage-redesign-final.png
[15:26] <noodles775> gmb: sorry, I'm not going to be able to get to that ui review before I run... you might be best adding barry and popping it on the queue (retrospectively) ;D
[15:26] <gmb> noodles775: Righto, thanks anyway.
[15:26] <gmb> barry: Is that okay with you ^^?
[15:27] <henninge> noodles775: I pushed a new version.
[15:27] <intellectronica> gmb: i can ui review
[15:27] <gmb> intellectronica: Good point. I was going to swap with your for code review anyway.
[15:27] <intellectronica> gmb: yes indeed :)
[15:27] <henninge> noodles775: if you are fine with it, I'll leave it as it is now (except for upodating the blog posts).
[15:28] <gmb> intellectronica: https://code.edge.launchpad.net/~gmb/launchpad/bugtask-index-conversion/+merge/12054, if you would. I still need to fix some tests before you review the code changes; I'll let you know when I'm done.
[15:28] <barry> i'm happy to do quick ui reviews between code reviews if there are screenshots
[15:28] <intellectronica> gmb: ditto (still doing tests before i can submit for code reviews)
[15:28] <gmb> intellectronica: RIght.
[15:29] <gmb> intellectronica: Oh, one point: I know I still need an icon for the Convert to question action; that's my next job.
[15:29] <intellectronica> gmb: and ditto, if you have a screenshot i can ui review now quickly
[15:29] <gmb> intellectronica: https://devpad.canonical.com/~gbinns/screenshot.png
[15:29] <intellectronica> gmb: a smiley will do ;)
[15:29] <barry> gmb: i can do a ui review.  paste the screenshot url
[15:29] <gmb> Now now, no fighting please...
[15:29] <barry> intellectronica: what am i looking for?  the design of the whole page or specific parts of it?
[15:30] <intellectronica> barry: both. the general concept martin already reviewed, but i just want a last check that everything looks sane
[15:31] <intellectronica> gmb: looks very nice. it will be _very_ cool if we could get the description/comments/postbox aligned. is it unrealistic given the time, though?
[15:31] <barry> intellectronica: i love certain this about it.  the fact taht you can change the supervisor and contact right there (are they inline edits?) and the wonderful human friendly breadcrumbs
[15:32] <intellectronica> gmb: the remove cve link should be on the next line
[15:32] <gmb> intellectronica: I've played with it and so far have had no joy. Unless you can think of something off the top of your head that might work...
[15:32] <gmb> intellectronica: Argh. Missed that. Thanks.
[15:32] <barry> intellectronica: the only thing that looks weird to me is the tag cloud.  i vaguely feel like it should be left-aligned or justified, but if that's difficult it needn't hold up the branch
[15:32] <intellectronica> barry: they're not inline, and you could change them from that page in 2.0 (but i guess if you noticed now it means that my plan to make the links more discoverable worked)
[15:33] <barry> intellectronica: definitely
[15:33] <intellectronica> barry: i like the idea of justifying! do you happen to know the css for doing that?
[15:34] <intellectronica> gmb: b.t.w if you can't come up with an icon for converting to question i think you can use (+)
[15:34] <gmb> intellectronica: Right, that was my fallback plan.
[15:34] <barry> intellectronica: i think: style="text-align: justify;"
[15:35] <gmb> intellectronica: I'm filing a lot of small tweaks under "fix it later"
[15:35] <noodles775> barry: your idea works well and is much cleaner... doing an incremental now.
[15:35] <barry> noodles775: rawk
[15:35] <deryck> intellectronica, gmb -- for description to stretch out and line up to the side bar on a bug page requires a bug fix from me to the widget, which I can't get today.  But comments could line up to side bar like the table, I would think.
[15:36] <barry> intellectronica: if that looks good, ui=me* (but i'm also happy to look at it again if you're not sure)
[15:36] <intellectronica> gmb: the alignment of the main area, especially now that the cves are there, is pretty ugly. but i guess it's quite a lot of work to fix that now
[15:36] <barry> gmb: did you have a ui you wanted me to look at?
[15:36] <gmb> deryck: But that then goes against all the other pages' layouts (where commetns are quite compact)
[15:36] <gmb> barry: An extra set of eyes is always helpful; feel free.
[15:37] <deryck> gmb, ah, ok.  I didn't realize we had a rule/pattern for that.  If comments are fixed, I could make the widget adjust to the comments pretty easily.
[15:37] <deryck> fixed is easy, fluid, not so much
[15:37] <barry> gmb: did you have to fill the heading slot to get the editable h1?
[15:38] <intellectronica> barry: that was such a good idea. refresh and see
[15:38] <gmb> deryck: Right. So, under main_side, the boardComments isn't fixed width... I think it just has a big right margin.
[15:38] <barry> intellectronica: beautiful, thanks!
[15:38] <gmb> barry: Yes.
[15:38] <intellectronica> barry: thank you
[15:39] <deryck> gmb, hmmm, ok, so that may be hard then, too, if that comments are fluid.
[15:39] <intellectronica> barry: b.t.w i'm going to interpret your ui* and martin's review from yesterday as ui-approved
[15:40] <gmb> intellectronica, deryck, barry: I just have to step out for a minute (*must* post some documents today and I've forgotten)... I'll address any comments when I return.
[15:40] <noodles775> jtv: mthaddon updated the configs temporarily on edge so that your pages won't oops.
[15:40] <deryck> gmb, cool
[15:40] <jtv> noodles775: acknowledged with thanks
[15:42] <mrevell> henninge: ping
[15:42] <henninge> mrevell: here
[15:42] <mrevell> Hi henninge, I'm just looking at your mock-up.
[15:42] <henninge> mrevell: its not a mock-up
[15:42] <henninge> it's a screenshot of my page.
[15:43] <henninge> s/page/branch/
[15:43] <mrevell> sorry, yes
[15:43] <henninge> mrevell: just saying, the design work (Martin) and the coding (Me) is mostly done, I am just wondering about content and wording now.
[15:44] <henninge> mrevell: and I need the blogposts that will ve released next week ;-)
[15:44] <henninge> be
[15:45] <mrevell> henninge: It may be too late to change but I think this design gives far too much prominence to the "latest blog posts" and not enough to getting started. If I take a look at, say, GitHub's home page I fe
[15:45] <mrevell> henninge: You need next week's blog posts? Surely it's taking a live feed, isn't it?
[15:46] <henninge> mrevell: no, it's not ...
[15:46] <henninge> mrevell: these are just copied from the current page which were hard-coded, too.
[15:47] <barry> gmb: could you do me a favor?
[15:47] <barry> gmb: file a bug on the fact that you had to override the heading slot to do that?  i'd like to fix that post-3.0
[15:47] <henninge> mrevell: If I had a function I could call to get the blogposts, I could easily put them on the page
[15:47] <mrevell> henninge: That's a damn shame: we're just giving "what's new" a fancy new, and inaccurate, name. I think it really must not be "Latest blog posts" as that will very quickly become inaccurate. We'll continue to make blog posts between releases.
[15:47] <henninge> but coding the polling now seems work
[15:48] <barry> gmb: other comments: the "link to CVE/Remove CVE links.  why are both visible?  and if they need to be, why aren't they on separate lines?
[15:48] <henninge> mrevell: yes, I was wondering about that. So we stick with "What's new" for now until we get the polling coded.
[15:48] <mrevell> henninge: If that's how it has to be, I guess so.
[15:48] <barry> gmb: shouldn't "Convert to question" have an icon of some sort?  it stands out as odd without it
[15:49] <mrevell> henninge: And I'll get that list of blog posts to you, in that case.
[15:49] <henninge> mrevell: please
[15:49] <barry> gmb: i wonder if the elements in the left-ish portlet under the bug summaries shouldn't be as wide as the bug summaries?
[15:49] <barry> gmb: EOT
[15:50] <barry> noodles775: which branch of yours am i reviewing next?
[15:52] <mrevell> henninge: So, wrt to the design, I'm not sure what to suggest. I liked the initial mock-up but now I see actually coded up I think it lacks the punch we need for our home page. Perhaps the problem is that each section seems to have equal emphasis because the headlines and body text in each segment has the same font size. On the "not logged in" version I'd suggest that the "Launchpad is a..." section should probably have a subtle
[15:52] <mrevell> background and larger headline
[15:52] <henninge> mrevell: ok, kfogel suggested something like that, too.
[15:53]  * barry will just pick one
[15:54] <mrevell> henninge: For the logged in version, I feel like we should give more prominence to "Getting started" than to "What's new". perhaps swap them?
[15:55] <henninge> mrevell: It would be easiest to swap the columns.
[15:55] <henninge> not just one portlet.
[15:55] <noodles775> barry: either is fine, if you want an easy one, the sprint templates (they're probably more urgent I'd guess).
[15:56] <barry> noodles775: i'll take sprint-index-and-attend
[15:56] <mrevell> henninge: I think that would work well.
[15:56] <mrevell> henninge: henninge: And this is perhaps for another time but I like the fact that GitHub has a "Recently updated repositories" section on its home page. I wonder if we could do something similar.
[15:56] <noodles775> barry: I have to run now, so feel free to prioritise the last one as you see fit :)
[15:56] <barry> noodles775: gotcha
[15:56] <noodles775> barry: btw, did you see the diff I just sent for the first one?
[15:57] <henninge> mrevell: I am sure the code guys could give us that data.
[15:57]  * noodles775 is about to run ec2test, and will do so to land if you're happy with it.
[15:57] <henninge> mrevell: I mean, live, through some function call.
[15:57] <mrevell> henninge: Well, I was thinking not so much just code but maybe something more universal. I'll add that as a comment on the bug, as it's probably not possible to do right now :)
[15:58] <barry> noodles775: looks fine.  i'll update the mp.  my comment about those closing braces is that we're /not/ consistent so either way is probably fine for your branch ;)
[15:58] <noodles775> barry: great, thanks!
[15:59] <henninge> mrevell: oh, latest bug, branch, question, etc ... ?
[15:59] <henninge> mrevell: yes, but not now. ;)
[15:59] <mrevell> henninge: Yeah, too much work for right now :)
[16:01] <mrevell> henninge: So, as for text...
[16:02] <mrevell> henninge: minor quibble: I think "Read the user guide" works better than "Read the manual", but I'm easy if it doesn't fit.
[16:02] <henninge> should
[16:04] <mrevell> henninge: Going back to the design, I wonder if we should better emphasise the search box. Take a look at github.com and sourceforge.net and you'll see that the eye's immediately drawn there, whereas I find it easy to skip over ours.
[16:05] <henninge> mrevell: yes, both have them graphically enhanced and placed top-left.
[16:05] <henninge> mrevell: maybe the centering is a bad idea.
[16:06] <barry> noodles775: ping
[16:06] <mrevell> henninge: I don't mind the centering, but I think the graphical enhancement works. At the moment, our home page looks a bit like the poor cousin of our two main rivals.
[16:06] <noodles775> barry: yep?
[16:06] <barry> noodles775: this page doesn't look quite right: http://people.canonical.com/~michaeln/tmp/sprint-index-after.png
[16:06] <barry> noodles775: you've got an h1 above the app tabs and no heading above the breadcrumbs
[16:07] <mrevell> henninge: Our home page is quite text heavy, which is fine, but I think we need to throw in some more clues to show people where to look.
[16:07] <noodles775> barry: yes, I meant to mention that in the MP, sorry...
[16:07] <mrevell> henninge: I'm not sure, though, that we'll get all that fixed in time for 3.0
[16:07] <noodles775> barry: afaics, the breadcrumbs should not be appearing according to the heading rules?
[16:07]  * bigjools sees the queue and cries
[16:08] <henninge> mrevell: we won't.
[16:08] <barry> sigh
[16:08] <noodles775> barry: not sure what you got, but:
 barry: yes, I meant to mention that in the MP, sorry...
[16:08] <henninge> mrevell: even adding a background takes some work to look good and not cheap.
 barry: afaics, the breadcrumbs should not be appearing according to the heading rules?
[16:08] <mrevell> henninge: Right
[16:08] <henninge> i just tried and ...
[16:09] <barry> noodles775: this should be a root context index view, so i think that's right.  there should be no breadcrumbs
[16:09] <mrevell> henninge: I think we should probably spend some more time looking at the design of the page and maybe involve our friends in the User Experience and Design team at Canonical.
[16:09] <henninge> reminded me of earlier years of the web
[16:09] <mrevell> henninge: but that's for another day, obviously
[16:09] <henninge> mrevell: so the question is: go with this now or leave the old home page in place (minus old navigation).
[16:10] <noodles775> barry: yep. Any other questions before I run out the door? :)
[16:10] <barry> noodles775: that's it for the ui.  everything else looks great.  i'll mention this in my comments
[16:10] <noodles775> barry: btw, I'm assuming that's a bug in the heading stuff, or is there something I can do about it?
[16:10] <noodles775> barry: ok, great, thanks!
[16:11] <mrevell> henninge: Hmm, big question! I like the direction of beuno's mock-up but actually seeing it in screenshots I prefer what we have now. I am not, though, in any position to make that decision alone haha
[16:11] <barry> noodles775: that's an interesting question!  this hasn't come up before.  you might ping salgado about that (it's a +hierarchy adapter issue).  if he doesn't have an ideas off the top of his let, i'll try to think about it
[16:11] <henninge> mrevell: well, who is?
[16:12] <mrevell> henninge: At a guess, flacoste
[16:12] <henninge> mrevell: he just saw it and said it was fine ... ;-)
[16:12] <mrevell> henninge: In which case, I'll shut up
[16:12] <mrevell> :)
[16:12] <henninge> ;)
[16:12] <mrevell> henninge: I think, though, that after the release we should revisit the home page. I'll post to the list with some idea of what I'm thinking about.
[16:13] <henninge> mrevell: but please remember that blog post list. When do you think I can have it?
[16:13] <mrevell> henninge: I'll send something over now.
[16:14] <henninge> cool
[16:14] <gmb> barry: So, in order: 1) Yes, I'll file that now; 2) They both have to be visible because you can both add and remove CVEs (if there's no CVE linked the 'Remove' link disappears. The separate lines thing is now fixed; 3) Yes, Convert to question needs an icon - that's my next job after fixing test failures; 4) Er... I don't think I understand what you mean by "left-ish portlet"
[16:17] <barry> gmb: 1-3) cool; 4) "left-ish portal" means the bug description and everything below that.  see how there's a lot of vertical whitespace below the summaries and in between the description/comments and the right portal?  that's what i think should be collapsed
[16:18] <gmb> barry: I agree; that looks ugly. I haven't (yet) found a way to fix it though. I'll keep trying, but in the interests of getting at least *something* landed before PQM closes, would you be okay with me filing a bug and fixing it later (assuming there isn't a cheap fix to be had now).
[16:19] <intellectronica> gmb: guess what, i also just realised that i need to override the page title. how?
[16:19] <barry> gmb: yes.  ask sinzui though.  he did something related (added some css to stretch things the full page width).  if he can't help come up with something simple, file the bug and land it
[16:20] <barry> gmb: er, well, by land it i mean ui=me* :)
[16:20] <sinzui> barry: gmb and I have talked. My tricks did not help with his real problems
[16:20] <barry> sinzui: k.  gmb file that bug
[16:21] <barry> gmb: is this bugtask-index-conversion?
[16:23] <intellectronica> gmb: did you find out how to override the page title?
[16:23] <intellectronica> barry: maybe you know? ^^^
[16:23] <gmb> intellectronica: Yes
[16:23] <gmb> intellectronica: Add a page_title property to your view
[16:23] <henninge> mrevell: the column swapping is not as easy as I thouhgt it was so I am sorry but we'll have to postpone that, too...
[16:24] <gmb> Remove the pagetitles entry
[16:24] <mrevell> henninge: okay
[16:24] <intellectronica> gmb: lovely, thanks
[16:24] <sinzui> gmb: barry: I think the problem requires a very invasive redesign of the base-layout. If we can remove the heading-slot. Then we can make a simple slot that is for content before the sidebar.
[16:24] <gmb> intellectronica: And then add     override_title_breadcrumbs = True to your view class.
[16:24] <intellectronica> oh ok
[16:24] <gmb> intellectronica: That last bit stumped me :)
[16:25] <barry> sinzui: i would love to remove the heading slot.  but yeah, post-30 :)
[16:25] <barry> intellectronica: i hope you don't need to override the whole <title> though
[16:25] <gmb> barry: Thanks.
[16:25] <barry> intellectronica: do you just need to make it human readable?
[16:26] <intellectronica> barry: i'm not sure what you mean by human readable. it changed from what it used to be to 'something : something'
[16:27] <barry> intellectronica: right.  human readable means, no +foo thingies
[16:27] <intellectronica> the override_title_breadcrumbs = True trick worked, so i'm satisfied
[16:27] <barry> intellectronica: isn't the reverse breadcrumbs what you want?
[16:28] <intellectronica> barry: no, because the title is a bit more verbose than the breadcrumbs
[16:28] <barry> intellectronica: hmm.  screenshot?
[16:29] <abentley> rockstar: why aren't edit_whiteboard and edit_import @enabled_with_permission?
[16:29] <intellectronica> barry: breadcrumbs is 'Bugs in firefox'. page title should be (and is now) 'Bugs in Mozilla Firefox'
[16:29] <rockstar> abentley, ah, they probably should be as well.
[16:30] <rockstar> abentley, edit_whiteboard doesn't need to be, since, if it's an import branch, anyone can write on the whiteboard (thus the problem with whiteboards)
[16:30] <bac> barry: can i add a 35 line branch to your queue?
[16:31] <abentley> rockstar: Do you really want to put lolspeak in lib/lp/code/browser/configure.zcml ?
[16:31] <rockstar> abentley, where?
[16:31] <barry> intellectronica: is that the full title or just the last component?  because salgado's branch is/will make it so you only need to specify page_title w/o the override.  but if the <title> is now what you want, then go for it.  we might need to re-address this later
[16:31] <bac> sinzui: you have two minutes to do the review for bug 432163?
[16:31] <mup> Bug #432163: Team page Join link thinks it is a download button <trivial> <ui> <Launchpad Registry:In Progress by bac> <https://launchpad.net/bugs/432163>
[16:31] <sinzui> bac: yes
[16:31] <barry> bac: you can add it, but we'll see ;)
[16:32] <bac> sinzui: https://code.edge.launchpad.net/~bac/launchpad/bug-432163-join-link/+merge/12064
[16:32] <abentley> rockstar: "<!-- NEW STUFFS GOES HERES -->" near line 369
[16:32] <bac> barry: nm, sinzui is going to take it.
[16:32] <rockstar> abentley, ah, yea, I need to remove that now.
[16:32] <rockstar> abentley, and the LOLSPEAK was unintentional.  :)
[16:32] <intellectronica> barry: yeah, the <title> is now what i want, so i won't worry about it until salgado lands his branch
[16:33] <barry> bac, intellectronica: coolio
[16:33] <sinzui> bac: r=me
[16:34] <bac> sinzui: thanks
[16:34] <barry> okay, i'm going back to code review now, so no ui reviews for a bit :)
[16:34] <rockstar> Is PQM closing today or Monday?
[16:36] <abentley> rockstar: It it current behaviour to hide merges for import branches?
[16:36] <rockstar> abentley, no.
[16:37] <abentley> rockstar: Were you aware that some projects are deliberately using merges on vcs-import branches to do code review of the upstream branches?
[16:37] <henninge> mrevell: #homepage-whatslaunchpad ul
[16:38] <henninge> mrevell: I increased the font sizes on the headings and for the "What's Launchpad" section.
[16:38] <rockstar> abentley, oh wait.  The behavior is that you can propose merges into vcs-imports, but you can't propose vcs-imports for merging.
[16:38] <rockstar> Er, it's supposed to be.  I got a little overzealous.
[16:38] <henninge> mrevell: http://people.canonical.com/~henninge/screenshots/launchpad-homepage-3.png
[16:39] <abentley> rockstar: Okay, please fix.
[16:39] <rockstar> abentley, okay.  Please note that on the review.
[16:42] <bac> sinzui: i'm going to piggyback bug 432427 with the other.  it was a one line change
[16:42] <mup> Bug #432427: Person's Code participation arrow is blueprint-coloured <trivial> <Launchpad Registry:Triaged by bac> <https://launchpad.net/bugs/432427>
[16:42] <abentley> rockstar: What would you think about moving registrant below review team?  It seems like rarely-used information.
[16:43] <rockstar> abentley, well, technically, it should go away.
[16:43] <sinzui> bac: +1
[16:43] <abentley> rockstar: Onto a "wow, you're nitpicky" page?
[16:44] <rockstar> abentley, no, there was supposed to be a slot to put that info i.n
[16:44] <abentley> rockstar: I don't understand.
[16:45] <rockstar> abentley, well, "registered by" is SUPPOSED to go up in the right floating next to the title.  However, I don't think the slot exists.
[16:46] <abentley> rockstar: I see.
[16:47] <abentley> rockstar: Should the import URL of an import branch be displayed similarly to the mirror url of a mirror branch?
[16:47] <rockstar> abentley, I thought about it, but I decided against it because import branches don't have just urls (like in the case of CVS).
[16:49] <abentley> rockstar: Okay.  Maybe in the future we can display import data in the same place, whether it's a URL or a URL + branchname combo.
[16:50] <rockstar> abentley, yeah.
[16:50] <mrevell> henninge: Looks good. I'm just trying to come up with summaries for these blog posts for you
[16:51] <henninge> mrevell: yeah, make'm good. They don't have to be that short and concise anymore, remember? ;-)
[16:51] <abentley> rockstar: in branch-management.pt, why do you have this nested tal:condition at the top?
[16:54] <abentley> rockstar: Isn't there a way to render a Link as HTML directly?
[16:54] <rockstar> abentley, what do you mean?
[16:55] <abentley> I mean not <a id="codebrowse-link" class="sprite info" tal:attributes="href link/url" tal:content="link/text" >Browse this branch</a>
[16:56] <abentley> rockstar: Maybe <a tal:replace=link/fmt:link> or something?
[16:59] <rockstar> abentley, ah, well, I would normally do that, but I need them rendered the way they are now when I attach javascript to them.
[16:59] <abentley> rockstar: In order to customize the id?
[16:59] <rockstar> abentley, basically, we don't have an API to give the link an id.  *groan*
[17:00] <abentley> rockstar: This is a DRY violation, so we should fix it.
[17:00] <abentley> rockstar: Not necessarily in this branch, though.
[17:00] <barry> noodles775: i think i fixed sprint-index.  i'll include the diff in my review
[17:02] <rockstar> abentley, yeah, the problem is known.
[17:04] <abentley> rockstar: in branch-management.pt, why do you have this nested tal:condition at the top?
[17:04]  * rockstar looks
[17:06] <rockstar> abentley, I think that was a result of moving stuff around.  I'll remove the first condition.
[17:06] <rockstar> abentley, please note that in the review.
[17:06] <abentley> rockstar: Cool
[17:12]  * barry -> lunch, then more reviews
[17:15] <abentley> rockstar: r=me, subject to the changes we agreed on.
[17:16] <rockstar> abentley, great.  Thanks a lot.  The next Sunday we're in Dunedin, dinner's on me.
[17:23] <gmb> intellectronica: How are your test fixes looking? I've got a few more to go, but most of them are just little changes due to bits of the page being moved or restyled, so you can pretty much take a look whenever you like.
[17:25] <intellectronica> gmb: exactly the same. how about we both create MPs and exchange reviews at 1800?
[17:25] <gmb> intellectronica: Works for me.
[17:53] <gmb> intellectronica: I'm going to go grab some food before I review your branch; ping me with the MP link and I'll take a look in half an hour or so. Mine's at https://code.edge.launchpad.net/~gmb/launchpad/bugtask-index-conversion/+merge/12075.
[17:55] <intellectronica> gmb: i also have to go away for a bit, to eat and call my family (it's the evening of the jewish new year and they'll take me off the will if i don't call). on the positive side i am in the middle of fixing the last broken test, so i should have the complete fing for you when you come back
[18:15] <barry> actually: noodles775, BjornT, abentley, EdwinGrubbs, sinzui, bigjools because there are so many reviews on the queue, i'll prioritize to those for folks who are around.  in that order, who's waiting on a review?
[18:15] <abentley> barry: I'm around.
[18:16] <barry> abentley: cool.  let's give a minute or so to noodles775 and BjornT and if they don't respond i'll start on yours
[18:17] <BjornT> barry: i'm kind of around, but the review is non-urgent
[18:18] <barry> BjornT: thanks
[18:18] <sinzui> barry: Mine is not important today
[18:19] <barry> sinzui: cool
[18:19] <abentley> BjornT: Thanks.
[18:19] <barry> abentley: just to be sure, we're talking your restyle-subscriptions branch?
[18:19] <abentley> barry: Yes.
[18:19] <barry> cool
[18:19] <EdwinGrubbs> barry: I'm around
[18:24] <barry> EdwinGrubbs: okay, i'll do yours after i finish abentley's
[18:29] <barry> abentley: are there mp's in sample data?
[18:29] <abentley> barry: I don't think so.
[18:29] <barry> abentley: ok
[18:34] <barry> abentley: ui-wise i have one minor quibble, but i don't think it's introduced by your branch (it shows up in the branch subscribers too)
[18:34] <abentley> barry: oh?
[18:35] <barry> abentley: [mail-icon] to all changes: doesn't sit right for me
[18:35] <barry> i think i'd like to see the word 'email' in addition to the mail-icon
[18:35] <barry> abentley: but if you didn't introduce that, i won't push it
[18:35] <barry> (and you might disagree anyway :)
[18:35] <abentley> barry: Not introduced by me.
[18:36] <barry> abentley: cool.  i'll mention it but leave it at that.  it's a beuno question anyway
[18:36] <abentley> barry: I figured the icon was meant to represent "email subscribers"
[18:36] <barry> abentley: other than that, you have two headings, so that'll need to be fixed
[18:37] <barry> abentley: well, actually that's not in your change either
[18:38] <abentley> barry: rockstar is working on a general overhaul of that page.
[18:38] <barry> abentley: r=me, ui=me for your branch.  bonus points if you can get rid of that double header on branch merge proposal pages
[18:38] <barry> abentley: fab
[18:38] <barry> nm then! :)
[18:41] <barry> EdwinGrubbs: which one do you want me to take first?
[18:42] <EdwinGrubbs> barry: it doesn't matter.
[18:43] <barry> EdwinGrubbs: cool.  rdf-index-ui-3?
[18:43] <EdwinGrubbs> sure
[18:45] <barry> salgado: yay! you fixed the test failures?
[18:46] <salgado> barry, yep, they were all mechanical, so it didn't take thaaat long
[18:46] <barry> salgado: been there :)
[18:47] <salgado> barry, I'll take noodles775's; that ok with you?
[18:49] <barry> salgado: yep, thanks
[18:58] <barry> EdwinGrubbs: rdf branch r=me
[18:58] <EdwinGrubbs> barry: thanks, btw, I added another mp to the list
[18:59] <barry> EdwinGrubbs: cool.  i'll do bug 430663 now
[18:59] <mup> Bug #430663: convert  sprint-register.pt to 3.0 layout <Launchpad Blueprints:In Progress by adeuring> <https://launchpad.net/bugs/430663>
[19:16] <barry> EdwinGrubbs: minor comments on bug 430663 branch.  should be easy to
[19:16] <barry>         fix.  review sent
[19:16] <mup> Bug #430663: convert  sprint-register.pt to 3.0 layout <Launchpad Blueprints:In Progress by edwin-grubbs> <https://launchpad.net/bugs/430663>
[19:20] <henninge> barry, salgado: I appended my branch with the new LP home page. It's just shy of 800 lines, sorry ;-). I am currently running late for my own birthday party so I hope you are able to approve without asking many questions (in email). ;)
[19:20] <henninge> I will be back during the (my) night to land it.
[19:23] <henninge> barry, salgado: Please? (I think I forgot that.:)
[19:23] <barry> henninge: happy birthday!
[19:23] <henninge> Thank you very very much!
[19:23] <salgado> henninge, I'll try hard to get to it, but all branches today seem to be rather long.
[19:23] <barry> henninge: rs=me if you blow out all the candles with one puff :)
[19:23] <salgado> henninge, and happy birthday, btw! :)
[19:23] <bigjools> barry: I iz here, belatedly
[19:24] <henninge> barry:  actually, I almost did that yesterday (it was yesterday)
[19:24] <barry> henninge: :)
[19:24] <henninge> but they weren't 40 candles .. ;)
[19:24] <barry> bigjools: cool.  we're getting to 'em
[19:25] <bigjools> rockin
[19:39] <barry> EdwinGrubbs: another review sent
[19:57] <salgado> bigjools, do you need a UI review of your trivial-ui branch?
[19:58] <bac> sinzui: would you have time to look at https://code.edge.launchpad.net/~bac/launchpad/bug-422334-contact-team/+merge/12089
[19:58] <bigjools> salgado: probably, it has some stuff other than rs= heading changes
[19:58] <sinzui> ye
[19:59] <bigjools> albeit trivial
[20:00] <EdwinGrubbs> barry: I can't figure out why the SprintAttendanceRegisterView doesn't have an error when I remove the page_title, but FeaturedProjectsView needs it. Your review comments seemed to anticipate this.
[20:00] <sinzui> bac: r=me
[20:00] <bac> sinzui: thanks
[20:00] <sinzui> bac I had forgotten there was a macro. That was nice clean work
[20:01] <bac> thx
[20:01] <barry> EdwinGrubbs: it's because FPV is a "top level" view that doesn't have a +hierarchy (i.e. breadcrumb) adapter, so it can't find a default <title>.  SARV has a +hierarchy adapter, thus breadcrumbs, thus default <title>
[20:02] <EdwinGrubbs> aha
[20:03] <barry> EdwinGrubbs: one more down
[20:04] <salgado> barry, would you mind doing UI reviews for bigjools and henninge and I review the code?
[20:04] <barry> salgado: it's a deal!
[20:18] <bigjools> thanks barry
[20:41] <deryck> barry, salgado -- I've got a branch for review.  Can I get in line? :)
[20:41] <barry> deryck: yep, and i can do it after i do bigjools ui review.
[20:41] <salgado> deryck, sure!
[20:42] <deryck> cool, thanks, guys.
[20:42] <deryck> it's here when one of you is available -- https://code.edge.launchpad.net/~deryck/launchpad/milestone-portlet-links-385719/+merge/12092
[20:51] <rockstar> abentley, ping
[20:52] <abentley> rockstar: pong
[20:52] <EdwinGrubbs> barry, salgado: I have another mp but I'll be afk for about 30 mins. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-430590-specificationgoal-setgoals.pt-3.0-layout/+merge/12095
[20:52] <barry> k
[20:53] <rockstar> abentley, can you do one more review for me today?  It's not very big, and very mechanical.
[20:53] <barry> bigjools, salgado am i ui-reviewing trivial-ui branch?
[20:53] <abentley> rockstar: okay
[20:54] <bigjools> barry: please
[20:54] <barry> bigjools: do you have screenshots by any chance?
[20:54] <bigjools> just make sure I got the heading stuff right!
[20:54] <bigjools> barry: I don't put I put URLs in the MP for you
[20:54] <barry> bigjools: k
[20:55] <bigjools> s/put I/but I/
[20:55] <bigjools> it's late, I need some beer
[20:57] <bigjools> barry: there's no major changes, just a few small things lumped into one branch
[20:58] <barry> bigjools: cool
[21:02] <barry> bigjools: the demo urls say dogfood, but i figured them out
[21:02] <bigjools> oops
[21:02] <barry> bigjools: one of the pages has busted headings, the rest look fine
[21:02] <barry> bigjools: https://launchpad.dev/~cprov/+archive/ppa/+packages
[21:02] <barry> bigjools: do you need a screen shot?
[21:02] <bigjools> ah I didn't fix that one
[21:03] <bigjools> I can check here, one mo
[21:03] <barry> k
[21:04] <bigjools> barry: ok what's bustifuct? :)
[21:04] <barry> bigjools: the Packages in "PPA for Celso Providelo" heading shoudl be above the breadcrumbs, not below it
[21:05] <bigjools> okay
[21:05] <bigjools> easy
[21:05] <barry> bigjools: should be, yeah.  i'll ui approve it with that caveat
[21:05] <bigjools> barry: splendid, thanks
[21:08] <abentley> rockstar: Could you give me a ui review of https://code.edge.launchpad.net/~abentley/launchpad/restyle-subscriptions/+merge/12008 please?
[21:10] <bigjools> barry: I can't remember how to fix the ugly +blah breadcrumb ...
[21:11] <rockstar> abentley, done.
[21:11] <abentley> rockstar: Thanks.
[21:12] <rockstar> abentley, got a review coming your way.
[21:27] <barry> bigjools: i don't remember if salgado's branch has landed yet or not.  i think you set page_title to the last path component and do /not/ set title_override_breadcrumbs.  salgado can you confirm?
[21:27] <barry> deryck: review sent
[21:27] <deryck> barry, cool, thanks
[21:27] <bigjools> barry: yeah I have page_title implemented but no change to the crumbs.  I guess I'll wait
[21:28] <salgado> barry, bigjools, there's no need to do anything to have that fixed.  it will be fixed once my branch lands.  it's on PQM now
[21:28] <barry> salgado: fantastic
[21:28] <barry> okay, i need a detox :)  back in a bit.
[21:28] <bigjools> ossum
[21:28] <deryck> barry, serieses was there before me ;)  I was being lazy. :)
[21:29] <bigjools> oh and thanks for the code review salgado
[21:30] <salgado> bigjools, np. do you have another branch for review or can I remove yours from the queue?
[21:30] <bigjools> salgado: I only had one, it's not been taken out of the queue
[21:31] <bigjools> now it has :)
[21:33] <abentley> rockstar: it looks like the diff includes salgado's work.  Is that right?
[21:34] <rockstar> abentley, yeah, because I merged in the middle of it.  I think salgado's work has probably landed in devel by now.
[21:34] <salgado> it hasn't because there's a shipit branch playing on PQM now
[21:35] <rockstar> abentley, I tried to go into the future where prerequisite branches are supported in Launchpad, but I got to the 3.0 release and decided it's a future I'd rather not see coming.  :)
[21:35] <abentley> rockstar: It would be nice to diff against salgado's branch, then.
[21:36] <rockstar> abentley, coming up.
[21:39] <abentley> rockstar: Your diff also seems to include *my* work-- adding SELECT, INSERT on public.previewdiff
[21:39] <rockstar> salgado, was your branch against db-devel?
[21:40] <salgado> rockstar, yep
[21:40] <rockstar> abentley, alright, I'm going to re-propose against db-devel.  *groan*
[21:42] <rockstar> abentley, re-proposed against db-devel, attached a diff of just my work.
[21:42] <abentley> rockstar: You mean, in addition to the bzr send diff?
[21:43] <rockstar> abentley, no, I didn't send this time.  I just created it through the web ui.
[21:48] <abentley> rockstar: What's with pageheading in lib/lp/answers/browser/questiontarget.py ?
[21:48] <rockstar> abentley, what do you mean?
[21:48] <rockstar> The original var was name pageheading.  I don't believe it's used anymore.  I'll rip it out and see what breaks.
[21:49] <abentley> rockstar: I'm surprised it's not deleted.
[21:49] <abentley> rockstar: You're frequently doing pageheading = page_title
[21:49] <rockstar> abentley, yeah, like I said, I'll delete them, see what breaks.
[21:51] <gary_poster> EdwinGrubbs: OK, if you are still willing, MP is up: https://code.edge.launchpad.net/~gary/launchpad/launchpad-templates-3/+merge/12101 .
[21:51] <abentley> rockstar: The i18n Message class is why it says "FAQs for $displayname" ?
[21:52] <rockstar> abentley, yeah, because the title is actually a Message, and apparently whatever is generating the title and breadcrumbs doesn't understand that.
[21:52] <rockstar> So it's not making the substitutions correctly.
[21:54] <abentley> What are the high-bit characters in lib/lp/answers/stories/question-answers-vhost.txt?  Culy quotes?
[21:56] <salgado> barry, my head is hurting quite a bit, so I'll stop doing reviews.  I'll do them on Monday (or during the weekend if nobody beats me to them)
[21:59] <abentley> rockstar: ^^
[21:59] <rockstar> abentley, I'm not entirely sure, but the original test had the actual characters where I changed them to reprs where I could.
[22:02] <barry> salgado: looks like there's just to more on the queue.  hope you feel better and have a good weekend
[22:04] <abentley> rockstar: Could you please make the imports in lib/lp/registry/browser/person.py that you changed alphabetical?
[22:04] <rockstar> abentley, sure.
[22:04] <rockstar> abentley, also, it seems that there is no permission check currently on "Edit import or review source"  WTF?
[22:05] <abentley> rockstar: Didn't I point that out in the last review?
[22:05] <rockstar> abentley, no, I mean that the current code in devel has no checks either.  Like, no check to make sure you're vcs-imports or anything.
[22:05] <rockstar> Odd.
[22:06] <abentley> rockstar: Yeah, I certainly observed that in the last review.
[22:07] <abentley> rockstar: So, do you think pageheading can die?
[22:07] <rockstar> abentley, does that mean anyone can review imports now?
[22:07] <rockstar> abentley, I think it can.
[22:07] <kfogel> Anyone can review a quick and easy one?
[22:07] <kfogel> barry or EdwinGrubbs: easy one: https://code.edge.launchpad.net/~kfogel/launchpad/cc-script-update-reference/+merge/12102
[22:08] <abentley> rockstar: I don't think so.  I think it means that people who can't review imports are still given the link, and then it dies when they actually perform the review.
[22:08] <barry> kfogel: if EdwinGrubbs can't do it, but it on the list.  i might have a few more in me today
[22:08] <kfogel> barry, EdwinGrubbs: somewhat urgent, as the community-contributions cron update is broken without this (filing a bug on the larger issue now, but this change contains something that happens to work around the bug coincidentally)
[22:08] <rockstar> abentley, eep.
[22:09] <barry> kfogel: i'll do it when i'm done with this one
[22:09] <kfogel> barry: thank you
[22:09] <abentley> rockstar: Anyhow, I was serious about adding enabled_with_permission, and when you've done that, it'll be good.
[22:10] <rockstar> abentley, and edit_whiteboard does need launchpad.AnyPerson as well.  I can't believe we haven't gotten more spam through whiteboards.
[22:10] <rockstar> abentley, that was an acknowledgement that I was making the change to edit_import as well.
[22:11] <abentley> rockstar: okay, r=me with the pageheading removed and the imports resorted.
[22:12] <rockstar> abentley, great, thanks so much!
[22:12] <rockstar> abentley, shall we have our standup so you can have your weekend?
[22:13] <abentley> rockstar: you bet
[22:34] <rockstar> barry, can I have a UI review for https://code.edge.launchpad.net/~rockstar/launchpad/branch-index-redesign/+merge/12061
[22:34] <rockstar> There's pictureses and everything.
[22:34] <EdwinGrubbs> barry: I've added another branch to the queue if you have time.
[22:34] <EdwinGrubbs> gary_poster: I'm starting on your review now.
[22:34] <gary_poster> Thank you EdwinGrubbs
[22:37] <rockstar> EdwinGrubbs, if you have time, you might be able to do the UI review as well for me, please?
[22:37] <rockstar> ...or sinzui?
[22:38] <EdwinGrubbs> rockstar: I can do it after gary's
[22:38] <rockstar> EdwinGrubbs, cool, thanks.
[22:39] <barry> EdwinGrubbs: don't do kfogel 's; i just approved it
[22:39] <EdwinGrubbs> ok
[22:40] <barry> actually, i'll do rockstar's ui review and then EdwinGrubbs's code review
[22:40] <rockstar> barry, fank you.
[22:41] <barry> rockstar: when you say "into unittests" another successful strategy we've taken in registry is to move lots of tests into view tests, which can still be doctests
[22:42] <barry> rockstar: then actual pagetests are used just for workflow/navigation
[22:42] <rockstar> barry, yeah, that's actually what I'm planning on doing.
[22:42] <barry> rockstar: awesome
[22:42] <rockstar> barry, and the vigor to do such a thing is still in me.  We'll see what happens this weekend.
[22:42] <barry> :)
[22:43] <barry> rockstar: the second screenshot is funky.  is there any way not to wrap that h1 heading with the branch url?
[22:44] <rockstar> barry, not with that extra slot, although I expect that extra slot is in the wrong place.
[22:44] <rockstar> (but I don't think that's an issue to be addressed in this branch)
[22:45] <barry> rockstar: agreed. can you please file a bug on that?  i'd like to fix that post 3.0.  other than that, your two screenshots like good
[22:45] <rockstar> barry, yay!  Thanks.  I'll file that bug before it lands.
[22:46] <barry> rockstar: thanks!
[22:54] <EdwinGrubbs> gary_poster: What url is HWDBFingerprintSetView used for?
[22:56] <barry> folks, that's it for me.  i can't eat any more no matter how wafer-thin
[22:56] <gary_poster> I'm not sure--as I said, I was unable to test that.  It is selected in a navigation class.  I'll find it for you
[22:57] <gary_poster> EdwinGrubbs: look in lib/canonical/launchpad/browser/hwdb.py .  Look at the HWDBApplicationNavigation class.  Look at the traverse_hwdb_fingerprint method
[22:58] <gary_poster> EdwinGrubbs: That's kinda te extent of my knowledge. :-/
[22:58] <gary_poster> the
[23:08] <gary_poster> EdwinGrubbs: will be afk for dinner but will check back
[23:08] <EdwinGrubbs> that's fine
[23:29] <EdwinGrubbs> sinzui: if a page is just used as a macro, it doesn't need a page_title, right? I'm wondering why some exist in pagetitles.py to begin with.
[23:30] <sinzui> EdwinGrubbs: I am sure you have found a mistake
[23:31] <sinzui> EdwinGrubbs: The page must have a @@main_template/master by accident, which means it needs a pagetitle, but if it is never used as a page, that can be removed
[23:58] <EdwinGrubbs> rockstar: I'm starting on the ui review of your branch-index-redesign branch.
[23:58] <rockstar> EdwinGrubbs, great, thanks.


[01:25] <KGB-X> libcanberra Jeremy Bicha 484713 * commented merge request !8 * https://salsa.debian.org/gnome-team/libcanberra/-/merge_requests/8#note_484713
[01:25] -ubottu:#ubuntu-desktop- Merge 8 in gnome-team/libcanberra "Revert time_t related changes" [Closed]
[04:54] <thisisjaymehta> Is it possible to switch from Beta release to Stable release of 24.04 without reinstalling?
[05:05] <enyc> thisisjaymehta: well you can just update as usual; yes.  Potentially some leftover from some bug in beta.  This would be a better question in #ubuntu support channel.
[06:15] <thisisjaymehta> Oh okay thanks
[11:01] <KGB-X> libcanberra Michael Biebl 484831 * commented merge request !8 * https://salsa.debian.org/gnome-team/libcanberra/-/merge_requests/8#note_484831
[11:01] -ubottu:#ubuntu-desktop- Merge 8 in gnome-team/libcanberra "Revert time_t related changes" [Closed]