[00:11] <meek_geek> my archive manager do not show an option to encrypt my archive and put password or encrypt the names of files in list .. both these options are gone
[01:05] <UndercooL> hi everyone
[01:06] <UndercooL> installing 14.04 but it is not showing my monitor's max resolution.  Any help?
[01:07] <Unit193> Perhaps try either getting the closed driver if you can, or https://wiki.ubuntu.com/X/Config/Resolution
[01:08] <UndercooL> I would need it in a .deb format though?
[01:09] <UndercooL> No idea how to compile yet
[01:09] <Unit193> Check in Settings Manager -> Additional Drivers, if it's not there check the link.
[01:09] <UndercooL> ok thanks!
[01:10] <Unit193> Sure thing.
[10:13] <xubuntu929> Any chance on using hibernation mode on 14.04? Changed my netbook from XP to xubuntu I really need hibernation mode for conventient use of my netbook!
[10:18] <brainwash> xubuntu929: see http://ubuntuforums.org/showthread.php?t=2219403
[10:20] <brainwash> you can test with "sudo pm-hibernate" beforehand if it is supported and works properly
[10:22] <gry> xubuntu929: just use suspend I think. It's enough in most cases.
[10:23] <gry> It doesn't drain battery much. But if you need to, do what brainwash said.
[10:51] <starrats> good morning everyone!
[11:01] <olbi> hi :-)
[11:31] <xubuntu929> Thanks!
[12:47] <xubuntu033> Hi, can anybody give me a hint how to restore the nm-plugin, which I deleted accidentally
[12:51] <xubuntu033> Where can I find corresponding instructions?
[13:02] <bix_nood> Hey i need some help, anyone running stock-stock xubuntu?
[13:03] <bix_nood> I bamboozzled my lightdm settings, could anyone send me defaults?
[13:05] <bix_nood> Anone?
[13:06] <brainwash> lightdm settings?
[13:07] <bix_nood> Yep.
[13:07] <brainwash> where are these settings stored?
[13:07] <bix_nood> /etc/lightdm
[13:08] <bix_nood> If you could upload the entire folder, it's barely 2KBs
[13:08] <brainwash> you could reinstall the lightdm package
[13:09] <brainwash> I cannot upload it, because this machine does not run xubuntu
[13:09] <bix_nood> Ah okay.
[13:53] <snuggyfoo> Is anyone here?
[14:04] <starrats> no
[17:15]  * woof-woof says hi.
[18:12] <WLM|druk> Multitasking on Xubuntu! https://i.imgur.com/hPlQn9u.png
[18:16] <MIke11123> Howdy, I'm having a strange error.  I can't get Bluetooth or networking to start, its telling me that Name: com.unintuitive.Upstart does not exist.  DBus version 1.6.x
[18:17] <MIke11123> Wow phone.... unintuitive = ubuntu
[19:12] <OneKorea> Hi. After I install Disconnect firefox extensions and try to restart firefox - getting hard lock up (need hard reset). Then I tried chromium, and same thing happens when I install pepper-flash.
[19:12] <OneKorea> Can anything be concluded from this?
[19:35] <houli> hey there. anyone else seeing really weird GUI on Chrome 35?
[19:36] <elfy> I've seen reports of it
[19:36] <WLM|weg> Not me. But I'm using beta. Maybe it's fixed
[19:36] <houli> I've heard that they switched to a new UI rendering engine so that probably explains the ugliness
[19:38] <Unit193> houli: That's correct.
[19:38] <starrats> on the xubuntu page on FB they're talking about it.
[19:44] <starrats> is still using version 34 in Chromium!
[21:31] <Aergan> Hi, is there a way to do application window snapping using cmd/winkey + arrows ? (in XFCE)
[21:32] <Aergan> It works using the mouse if I drag an application at a workspace edge, but I would prefer a keyboard based solution
[21:33] <brainwash> Arceye: did you already check settings manager > window manager > keyboard?
[21:33] <brainwash> woops
[21:33] <brainwash> Aergan: ^
[21:34] <Aergan> Thanks, I've had a look in there but I'm not sure what the action would be called to bind a key too
[21:34] <brainwash> tile_left_key, tile_right_key,..
[21:35] <Aergan> Brilliant, many thanks
[21:35] <brainwash> :)
[21:36] <Aergan> Been staring at that list for a while, never occurred to me the action is named "tile"
[21:36] <z4nD4R> OT: Have someone experience with Xiomi Redmi 1s Phone? :)
[21:37] <brainwash> !ot
[21:38] <z4nD4R> brainwash: don't be bad .. :P .. :)
[23:32] <designbybeck> We've been having video issues/login issues with a Lenovo y410p dualbooting Win8 and Xubuntu
[23:32] <designbybeck> that we then install ubuntu-desktop.... that worked for a while, but now it doesnt
[23:32] <designbybeck> But Xubuntu does pull up, but we get an OpenGL GLX extension not supported by display when trying to run Steam
[23:33] <ochosi> depends on what graphics card you have and what driver you use i'd guess
[23:33] <designbybeck> NVIDIA
[23:34] <designbybeck> ...doesn't Xubuntu support OpenGL out of the box?
[23:34] <Aergan> Do you have optimus? e.g. Intel and NVIDIA
[23:34] <ochosi> this is less about xubuntu, but about nvidia supporting this or that
[23:35] <ochosi> by default, the open source "nouveau" drivers are installed with nvidia hardware
[23:35] <ochosi> you can install proprietary nvidia drivers too though
[23:35] <ochosi> settings manager > additional drivers
[23:38] <designbybeck> Aergan, this is a Nvidia 750m
[23:38] <designbybeck> ochosi, we have done that a number of times
[23:38] <designbybeck> purged a number of times
[23:42] <Aergan> Google for Lenovo y410p suggests that it does have NVIDA Optiums enabled, meaning it will have an Intel iGPU and a discrete GPU (NVIDA)
[23:43] <Aergan> If it does, you're in for a potentially rough time getting things to work correctly.


[01:38] <holy> hello
[01:38] <holy> hello
[12:49] <jarnos> Why can't I switch user in Action buttons?
[12:49] <jarnos> Is there a guest session?
[13:14] <paer76_> Hey  Ubuntu Studio ROCKS !!
[14:20] <jarnos> Oh, there is Guest session available, but I can not start it using "Switch User". Why?
[14:21] <jarnos> The item is grayed out.
[21:21] <Guest99143> hello
[21:23] <Guest99143> some body can help me, but dont play youtubes videos
[21:25] <Guest99143> i cant download flahs player from my software center ubutu
[21:26] <zequence> Guest99143: Hi
[21:26] <zequence> To get all restricted useful codecs, including flash player, install the package ubuntu-restricted-extras
[21:27] <zequence> Sometimes ubuntu software center will not work due to it not updating local package cache. To do that, open a terminal, and type: sudo apt-get update
[21:27] <zequence> To install the package I mentioned, in a terminal do: sudo apt-get install ubuntu-restricted-extras
[22:35] <holstein> Guest99143: or, use the chrome browser, or the chrome browsers flash player in chromium
[22:35] <holstein> but, if you
[22:35] <holstein> "cant install falsh player from software center" you may have some other issue
[22:36] <holstein> flash*
[22:36] <holstein> maybe you are finished communictating about it..


[02:47] <babbageclunk> wallyworld: should we fallback to release anytime we'd use devel - even if the user has specified devel explicitly?
[02:48] <wallyworld> babbageclunk: yeah, IMO. develop just indicates level of risk the user wants.
[02:48] <babbageclunk> ok
[02:48] <wallyworld> we need to behave linke snaps
[02:48] <wallyworld> *like
[02:53] <babbageclunk> wallyworld: I'm not sure how snaps work in this case
[02:56] <wallyworld> babbageclunk: you need to read up on them then :-)
[02:57] <babbageclunk> wallyworld: trying - any pointers? The closest I can find is that you can publish to multiple channels when publishing - but that's not the case here is it?
[02:58] <wallyworld> no, this isn't about publishing but the user specifying the level of risk they are willing to accept
[02:58] <wallyworld> i can try and find some snappy docs
[02:59] <babbageclunk> Right, but it seems like you could publish to beta without publishing to edge, and then someone who was on edge wouldn't see that version?
[02:59] <babbageclunk> I'm reading the docs on snapcraft.io
[03:00] <wallyworld> babbageclunk: they would see a higher version in beta
[03:00] <wallyworld> if published there
[03:01] <babbageclunk> whoa, there are channel branches?
[03:01] <wallyworld> babbageclunk: you always get the highest version - the channel determines how far down you look to see what's available
[03:01] <wallyworld> yeah
[03:01] <wallyworld> you can create a short lived snap (30 days default) from a branch
[03:01] <wallyworld> a feature branch
[03:02] <wallyworld> if you want longer you need to pay
[03:03] <babbageclunk> https://forum.snapcraft.io/t/channel-terminology-and-policy/551
[03:09] <babbageclunk> Ok, I think I get the fallback between risk levels (modulo the talk about closing which I guess doesn't matter here).
[03:10] <wallyworld> babbageclunk: correct, closing is not relevant here
[03:10] <babbageclunk> wallyworld: what about the other stream levels (proposed, testing)
[03:11] <wallyworld> ignore testing. we don't really use proposed in practice i don't think, but we could sp probably should support it
[03:11] <babbageclunk> I think it makes sense for all of them to fallback to released, right?
[03:11] <wallyworld> it's almost like testing < develop < proposed < released
[03:12] <babbageclunk> But if they all had released after them that would be right? Or should I only have the fallback for develop?
[03:14] <babbageclunk> wallyworld: ^
[03:14] <wallyworld> babbageclunk: sorry, on call, so distracted
[03:14] <wallyworld> the above order would be analogous to snap channels
[03:20] <babbageclunk> wallyworld: okthanks!
[04:24] <wallyworld> babbageclunk: sorry, out of meeting now if you still had questions
[04:26] <babbageclunk> wallyworld: no, I think I understand - I've made everything follow that fallback, just going through the places that call PreferredStream now to make them do the fallback if they need to. Thanks!
[04:29] <wallyworld> babbageclunk: ok, sgtm
[04:57] <axw> wallyworld: still at the guessing phase, but I have a suspicion that it's nothing to do with skews now. the logs say that the leadership worker is failing with "not found" and "state changing too quickly; try again soon"
[04:57] <axw> wallyworld: from looking at the code, that doesn't make sense... unless there's 2 leadership workers
[04:57] <wallyworld> interesting
[04:57] <axw> wallyworld: we run a leadership worker *per state*
[04:58] <axw> wallyworld: so one might be expiring stuff while the other is extending
[04:58] <wallyworld> oh dear
[04:58] <axw> wallyworld: I think the best thing to do would be to make it so we run one per model
[05:01] <wallyworld> axw: that sounds logical, one per state sounds crazy
[05:03] <wallyworld> axw: although i think there's an aspect where maybe there's a controller level doc, rather than per model
[05:03] <wallyworld> the clock#singular-controller lease doc
[05:03] <axw> wallyworld: I'm just talking about the applications one atm
[05:03] <wallyworld> ah ok
[05:04] <wallyworld> in that case sounds good to do
[05:04] <axw> wallyworld: I think we'd want a per-machine one for singular
[05:04] <axw> but I'll leave that for now
[05:06] <wallyworld> per controller i think?
[05:13] <axw> wallyworld: each controller machine needs to run the worker for failover, that's how the singular workers are implemented
[05:13] <axw> they'll each try to claim, but only one will succeed
[05:14]  * axw bbs
[05:21] <thumper> wallyworld: https://github.com/juju/names/pull/84
[05:26] <wallyworld> thumper: looking
[05:28] <wallyworld> thumper: lgtm
[09:47] <axw> wallyworld: I was wrong, when we expire the lease, the other manager will refresh its cache when the txn fails. so :/
[09:47] <axw> still shit, but probably not shit enough to continue trying to untangle everything
[09:50] <axw> not sure why it's getting "state changing too quickly errors" though... that refresh should fix it
[16:42] <redir> curl https://s3.amazonaws.com//aws-cloudwatch/downloads/latest/awslogs-agent-setup.py -O
[16:42] <redir> chmod +x ./awslogs-agent-setup.py
[16:43] <redir> jmeta-u./awslogs-agent-setup.py -n -r us-east-1 -c awslogs.confw
[16:43] <redir> w
[17:01] <redir> whoops
[17:01] <redir> somehow I found the shortcut to tell terminator to broadcast to all terminal windows
[17:01] <redir> :)
[17:02] <redir> glad it wasn't a secret
[21:20] <thumper> wallyworld: I think we should skip the release call again
[21:20] <thumper> we know what we are doing
[21:32] <wallyworld> ok
[21:36] <thumper> wallyworld: https://github.com/juju/juju/pull/7943
[21:36] <wallyworld> ok
[21:38] <thumper> wallyworld: I'm confused, got a minute?
[21:38] <wallyworld> sure
[21:38] <thumper> 1:1 HO
[21:52] <wallyworld> thumper: the hamster died, but we had finished
[21:52] <thumper> yeah
[22:41] <babbageclunk> wallyworld: I've just clicked that environs.Tools.Tools already does fallback between custom source and public source.
[22:41] <babbageclunk> wallyworld: implementation wise it's simpler for me if the fallback goes:
[22:42] <babbageclunk> custom/devel, public/devel, custom/released, public/released. Is that crazy or alright?
[22:44] <wallyworld> babbageclunk: i'd have to re-read the code - i didn't think custom came into it for agent binaries, just image metadata
[22:45] <wallyworld> for agent binaries, i thought we just had agent-stream to tweak things
[22:46] <babbageclunk> sorry, thinko'd the function name: environs/tools.FindTools
[22:47] <babbageclunk> It uses GetMetadataSources which adds one for agent-metadata-url and one for the default public source.
[22:47] <wallyworld> we may use custom if agent binaries are sourced from metadata supplies at bootstrap
[22:48] <wallyworld> but then it becomes custom > testing > develop > proposed > released
[22:49] <babbageclunk> No, custom has streams in it.
[22:50] <babbageclunk> So custom/public (and also cloud sources) are orthogonal to stream.
[23:35] <hml> babbageclunk: joining us?  we miss you
[23:35] <hml> :-)


[00:29] <LLStarks> yo.
[00:44] <LLStarks> yo. i need help with a patch.
[05:54] <pwnguin> heh, should i be concerned that 2.6.29 doubles rsa performance?
[10:36] <apw> sounds like you shoud be happy
[11:26] <mdz> apw: any luck quashing the false positive suspend/resume failure reports?
[11:27] <apw> no luck in finding the source, i have a  branch for apprt which i am about to test to paper over it
[11:28] <IntuitiveNipple> apw: is that unrelated to TEST_SUSPEND_SECONDS?
[11:29] <dandel> i got a suspend/resume failure on my laptop which is triggered each time ( but first i need the acpi to stop ignoring irq 9 (
[11:29] <apw> IntuitiveNipple, my answer is about completely false failures which are being reported by apport, not your 5 second timeout thingy
[11:30] <IntuitiveNipple> apw: OK, sounds harder to fix :)
[11:30] <apw> heh, not really
[11:40] <Kamping_Kaiser> sigh.
[13:00] <IntuitiveNipple> apw: smb_tp: Could one of you guys clue me in on how you build the ~lpXXXX test kernels so I can use it on my build servers to create test kernel packages too?
[13:01] <apw> IntuitiveNipple, as in how we add that
[13:01] <apw> literally just before the build you edit the debian/changelog
[13:01] <apw> if its UNRELEASED you can add ~lpNNNtj1
[13:01] <apw> it its like jaunty you should leave out the ~
[13:01] <IntuitiveNipple> Is that it? so it is just a plain fakeroot debian/rules binary-generic  (or whatever) ?
[13:02] <apw> yep
[13:02] <smb_tp> too easy :)
[13:02] <IntuitiveNipple> doh! and there was me thinking it was something clever!
[13:02] <IntuitiveNipple> yeah, far too easy. these things are supposed to be brain-strainers :)
[13:02] <IntuitiveNipple> OK, that means I don't need to ask you guys to build/publish the kernels.. I can punt them into my PPA I guess, too.
[13:03] <smb_tp> The only special thing would be for me, that I usually base the checkout on the last updates version
[13:03] <IntuitiveNipple> The only thing I can think - for non-PPA builds - is my lack of a kernel.ubuntu.com address (would people be concerned at pulling test kernels from my own domain?)
[13:04] <smb_tp> The thing for me against ppa builds is, that it only has one version there
[13:04] <IntuitiveNipple> Yeah. I've got several builds in the queue for testing core kernel bug-fixes which I have high hopes for
[13:06] <smb_tp> btw apw I installed the test kernel for the i915 performance issue on the aa1 and it still works the same as before
[13:06] <apw> oh nice
[13:07] <smb_tp> which was meant as a positive "no side effects" here, but  I realize it could be interpreted as nag, which it isn't :)
[13:08] <apw> smb_tp, i interpreted it as a helpful test on real hardware
[13:08] <smb_tp> good, such it should be
[13:10] <apw> mdz you will be pleased to hear i just found a way in which you can get a normal looking suspend/resume in concert with it reporting a failure at next reboot.  in concert with my symptom of not wanting to suspend any more
[13:11] <mdz> apw: nice! bug#?
[13:11] <apw> it seems that there is a window after we wake up enough to see working, before the offial wakeup is complete and if we get stuck here (and video post has done that in the past for me) then we seem up to the user
[13:11] <apw> but really really the suspend/resume is broken
[13:11] <apw> i'll put the details in your bug as i am working the issue there
[13:12] <apw> it really is broken, it just seems ok to the user.   we need to tell those two appart so we can inform the user better and get more information when it occurs
[13:16] <mdz> apw: ok, please update the title of the bug to something more meaningful if you would
[13:16] <apw> mdz will do
[15:52] <zilleplus_> hey anny one know a lot of ubuntu server??
[15:52] <zilleplus_> can't get internet on myn
[15:52] <zilleplus_> my dhcp server on route does not shows anny connection from my server
[15:58] <manjo> zilleplus_, #ubuntu-server
[16:02] <zilleplus_> can't get internet on new ubuntu server 8.10 can aanyone help (sudo route -nee shows not IP ore gateway)
[16:05] <manjo> zilleplus_, your interface is up ?
[16:09] <zilleplus_> manjo are you still there??
[16:09] <manjo> yes
[16:10] <zilleplus_> okey this is my problem
[16:10] <zilleplus_> i installed my server angain
[16:10] <zilleplus_> ubuntu 8.10
[16:10] <zilleplus_> and cant get inthernet on it
[16:11] <zilleplus_> but config -a gives tath my eth divice is there
[16:11] <zilleplus_> wath do i do
[16:11] <mjg59> zilleplus_: This is the kernel development channel. Support is best found in #ubuntu.
[16:12] <zilleplus_> ooh sorry
[16:12] <mjg59> no problem
[17:08] <IntuitiveNipple> apw: That 'easy' kernel build failed with "Previous or current ABI file missing!" - looks like the changelog version caused debian/abi/2.6.28-11.38lp284377v1 instead of the expected "debian/abi/2.6.28-11.38/". Does that mean I *do* need ~ in the version or do I create an ABI?
[17:10] <apw> was the top of the thing 'jaunty' ?
[17:10] <apw> IntuitiveNipple,
[17:10] <apw> if so its possible the upload has not yet had the abi files pulled down into it
[17:10] <apw> so it really will fail for all of us
[17:10] <apw> which abi files _do_ you have
[17:10] <IntuitiveNipple> you mean head? yeah, I did a git fetch; git rebase --hard origin/master then checked out the wip branch, applied the patch, and built
[17:11] <IntuitiveNipple> apw: 2.6.28-11.37  2.6.28-11.38lp284377v1
[17:11] <apw> and what are the first two versions in your changelog
[17:11] <apw> fdr printenv will show you what versions its really using
[17:11] <IntuitiveNipple> apw: 2.6.28-11.38lp284377v1 2.6.28-11.38
[17:12] <apw> ok what did you do
[17:12] <apw> did you add a whole new version in the top
[17:12] <apw> i was trying to suggest you simply _edit_ the existing top most version
[17:13] <IntuitiveNipple> apw: Yes, added a new changelog entry with the details of the change... as always :)
[17:13] <IntuitiveNipple> apw: ahhh!
[17:13] <apw> heh no no no don't do that for the kernel
[17:13] <apw> the changelog gets made by the automation on relase
[17:13] <IntuitiveNipple> If I don't I'll forget what the changes are :D
[17:13] <apw> then commit them using git
[17:13] <apw> and put the changelog on there
[17:13] <apw> thats where it should be
[17:14] <IntuitiveNipple> oh, as in the commit message flag? I included my new changelog entry in the patch commit as I do with other packages
[17:14] <apw> the kernel is odd as we cherry pick a lot
[17:15] <apw> so you never update debian/changelog, it just makes life hard when you rebase
[17:15] <apw> (as i just found rebaseing just three commits in bzr)
[17:15] <IntuitiveNipple> I knew that for 'regular' kernels but didn't realise it'd be so drastic for a test build :)
[17:15] <apw> when the release is done we do a fdr insertchanges which makes a debian changelog for us
[17:15] <apw> well the abi checks are very strict
[17:15] <IntuitiveNipple> yeah... I've done that myself in the past
[17:16] <IntuitiveNipple> I guess I'm too used to doing skipabi on out-of-tree builds
[17:23] <IntuitiveNipple> apw: thanks for that... trying again now
[17:24] <apw> luck
[17:28] <manjo> lieb, why does rmmod crasher just hang ?
[17:29] <lieb> hang?  I tested and it unloaded fine.
[17:29] <lieb> it did hang w/ an earlier version
[17:29] <manjo> after an oops
[17:30] <lieb> ok, you did an oops and then unloading hung?
[17:30] <manjo> the one that is on your people page is the lastest ?
[17:30] <manjo> yes I did an oops and then the unload hangs
[17:31] <lieb> hmm.  l'll look at it.  yes, the people page one is the latest (or should be)
[17:32] <manjo> also, if I wanted to make the oops appear at a function XXXXX() do I just move the *page0 = tmp; to a function XXXXX() and call it in its place ?
[17:33] <lieb> I'm not sure what you mean
[17:33] <manjo> instead of EIP: [<f7f60271>] oops_store+0x61/0x70
[17:34] <manjo> I wouild like to see EIP: [< .....>] XXXX+0x../0x..
[17:34] <lieb> just a sec, let me pull up the code...
[17:35] <manjo> so if I call a function in oops_store() to do the same thing it should appear that the eip is now in that new function correct ?
[17:36] <lieb> yes it would.
[17:36] <manjo> k
[17:37] <manjo> but after  *page0 = tmp; I need to have another instruction like return X;
[17:37] <lieb> also note the extra bit there w/ tmp.  I had to add that to fool the optimizer into doing the store at *page0 = tmp
[17:38] <lieb> and looking at it, I can see why the unload might hang
[17:38] <manjo> we can compile it unoptimized ?
[17:38] <lieb> this is the sysfs write callback so that chunk of sysfs is left hanging.  I'll have to figure out a way to
[17:39] <lieb> delay the actual oops...
[17:39] <lieb> optimize, yes.  I forget exactly but it gets optimized out.  actually, if I remember, I wanted the DEADBEEF
[17:40] <lieb> to be in a register so we could recognize it.  the optimizer turned the store into a store immediate which
[17:40] <lieb> would not show up in the reg dump
[17:41] <lieb> do you really need this to be unloadable here?  the other opts (panic etc.) whack the kernel so there is nothing to unload from.
[17:43] <manjo> yeah not in the case of panic ... but unload after bug and oops will be nice but not critical I think
[17:44] <lieb> I'd have to look but I think there are some locks held when we get down here in sysfs.  since we never
[17:45] <lieb> return via the normal path, they would not get released.  If that is true, the unload wouldn't work because
[17:45] <lieb> the module exit would hang on the sysfs attr destructor(s)
[17:45] <manjo> right agree
[17:46] <lieb> that might be hard to do
[17:46] <lieb> some other poor sot of a task would have to take the sharp stick in the eye in order to let this task ret to userland
[17:47] <lieb> we can't use a tasklet/workq cuz that would kill a kernel thread and really bring it down.
[17:48] <lieb> yup, the source is the latest.
[17:51] <lieb> I have an idea.  as soon as my jaunty beta downloads complete, I'll try it out.
[19:06] <calc> mjg59: loving your posts to lkml :-)
[19:35] <lool> Hi folks
[19:35] <lool> CONFIG_BLK_DEV_RAM_SIZE was bumped for imx51 from 4MB to 8MB
[19:35] <lool> It turns out this is the uncompressed size, and we didn't bump it enough
[19:35] <lool>     gunzip -c </boot/initrd.img-2.6.28-11-imx51 | wc -c
[19:35] <lool>     8460800
[19:36] <lool> This results in ENOSPC:
[19:36] <lool> [42949379.640000] RAMDISK: Compressed image found at block 0
[19:36] <lool> [42949380.210000] RAMDISK: incomplete write (-28 != 32768) 8388608
[19:36] <lool> Could someone please bump it again to the same value as amd64/i386: 65535?
[19:40] <lool> Bug #349842
[19:40] <ubot3> Malone bug 349842 in linux "Please bump CONFIG_BLK_DEV_RAM_SIZE to 64MB" [Undecided,New] https://launchpad.net/bugs/349842
[19:46] <vadi2> hi, in regards to the suspend/resume testing, are you interested in machines with nvidia cards and the proprietary driver?
[20:00] <IntuitiveNipple> vadi2: Yes, any. I've got nvidia here (7600) and suspend/resume has been fine... so far :)
[20:00] <vadi2> ok. I haven't had any issues on mt 8600 either before but might as well test to be sure
[20:01] <vadi2> (if someone is willing to look at results and not say "oh, proprietary, your reports are useless")
[20:22] <manjo> lieb, note submitted patch to kernel-crasher
[20:24] <lieb> where?
[20:24] <manjo> ukml
[20:24] <lieb> ????
[20:25] <manjo> :)
[20:25] <manjo> ubuntu -kernel -mailing list
[20:26] <manjo> if someone has apport setup to report to kerneloops they will get a lot of false positives from this module... this patch takes care of that
[20:27] <lieb> manjo, you realize that this is boardering on loony, right?
[20:28] <manjo> the reporting part ?
[20:29] <lieb> What was a testing tool is turning into a metastisizing code cancer.  I do not want to be responsible for the next re-incarnation of emacs! ;)
[20:30] <lieb> or gnome
[20:30] <lieb> or perl
[20:30] <manjo> heh
[20:31] <lieb> not a bad idea though... the function signature as a filter...
[20:31] <lieb> next thing I suppose is a .deb or whatever
[20:31] <manjo> haha
[20:31] <manjo> yeah I am sure there will be a request foir that soon
[20:32] <manjo> atually we can also add another case for loops ... for(;;);
[20:32] <lieb> I'll take the patch and update what I have.  We can talk next week on where to put this thing. right now it is on my local server
[20:32] <manjo> i know its on ur ppl page
[20:32] <manjo> that might have to move if this is going to be useful
[20:33] <lieb> and that is only a tarball
[20:33] <manjo> probably should be builnt in as a test module under misc or something
[20:33] <manjo> with config options
[20:33] <lieb> yea.  to be discussed, probably in the kerneloops session.
[20:34] <manjo> its pretty cool tool ... was very useful in my kerneloops testing
[20:35] <manjo> I think the arm part can be omitted ... who care if someone wants to shoot themselfs in the foot ?
[20:36] <manjo> just have /sys/kernel/crash/test and have it take oops, bug, warn, etc as values
[20:37] <lieb> that part is quesionable.  what I thought of doing is spawning a kernel thread to take the bullet.
[20:37] <manjo> so if you cat /sys/kernel/crash/test it will show all the values that you can echo to it
[20:37] <lieb> the arm part should remain for that reason.  that is why I was questioning the propagation of this beyond a small testing group
[20:38] <manjo> heh its beyond that now
[20:38] <manjo> something to talk abt the next time we have this discussion with team
[20:39] <lieb> given that kerneloops+kexec/kdump has turned into "something else" it should probably be part of the test infrastructure
[20:39] <manjo> that is a good idea too
[20:40] <manjo> btw kerneloops on 32bit is still broken I think coz of kexec tools
[20:40] <manjo> kdump I mean
[20:40]  * manjo breaks for coffee
[20:40] <lieb> one of the things that I fell into with this pre-in-post berlin was discovering all these disjoint packages
[20:41] <lieb> that, in reality, are really bits of one single "package" intimately tied to the kernel.  Imagine my surprise ;)
[20:56] <cody-somerville> When I attempt to mount a squashfs, I get: mount: mounting /dev/loop0 on /mnt failed: No such device
[20:58] <IntuitiveNipple> cody-somerville: what's the command you're using?
[20:58] <cody-somerville> mount -t squashfs -oloop /cdrom/casper/filesystem.squashfs /mnt/
[20:59] <IntuitiveNipple> not sure about this, but shouldn't there be a space between -o and loop ?
[20:59] <IntuitiveNipple> I know I use that form and I've not had a problem
[21:01] <IntuitiveNipple> I've just used this: sudo mount -t squashfs -o loop casper/filesystem.squashfs /mnt/usb
[21:01] <IntuitiveNipple> And without the space... and it works... so not a missing space issue
[21:02] <IntuitiveNipple> Is the loop device operational?
[21:03] <cody-somerville> How can I tell?
[21:03] <IntuitiveNipple> which kernel version are you using?
[21:04] <IntuitiveNipple> obvious thing first is to look for the loop devices: ls /dev/loop*
[21:04] <cody-somerville> 2.6.28-11-generic
[21:04] <cody-somerville> they're all there
[21:04] <IntuitiveNipple> okay, module is built-in
[21:04] <IntuitiveNipple> does losetup report anything? sudo losetup -a
[21:04] <cody-somerville> losetup -a doesn't work
[21:04] <cody-somerville> I'm using busybox version
[21:05] <IntuitiveNipple> ahhhh
[21:06] <IntuitiveNipple> I don't believe busybox supports -t auto or -t squashfs
[21:07] <cody-somerville> It must
[21:07] <cody-somerville> how would d-i mount a squashfs?
[21:10] <cody-somerville> Maybe I should try doing this two step?
[21:11] <IntuitiveNipple> check what file-systems are available.
[21:12] <IntuitiveNipple> I'll boot a PXE image here and break into init and see if it is the same
[21:13] <cody-somerville> Maybe I need to use unionfs?
[21:14] <IntuitiveNipple> no there's no squashfs: grep squash /proc/filesystems
[21:15] <cody-somerville> How do I get that?
[21:15] <cody-somerville> squashfs-modules doesn't seem to exist in ubuntu
[21:16] <IntuitiveNipple> The module isn't loaded at that point, presumably not in the initrd. (CONFIG_SQUASHFS=m)
[21:17] <cody-somerville> If I try to load the module, it says the module doesn't exist
[21:18] <IntuitiveNipple> from busybox/initrd? that might be correct. The module is ubuntu/squashfs/
[21:18] <cody-somerville> So do I need to get cjwatson to recompile d-i's initrd to include the squashfs module?
[21:19] <ogasawara> smb_tp: https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/349655
[21:19] <ubot3> Malone bug 349655 in linux "[hardy][sparc]: new kernel in security doesn't boot" [High,Triaged]
[21:19] <IntuitiveNipple> No
[21:20] <IntuitiveNipple> cody-somerville: the module is in /lib/modules/`uname -r`/kernel/ubuntu/squashfs/
[21:21] <cody-somerville> It isn't there
[21:22] <cody-somerville> /lib/modules/2.6.8-11-generic/kernel/ubuntu/ only has dm-loop, dm-raid4-5 and misc
[21:24] <IntuitiveNipple> I got it here ... let me check which version of the CD this is
[21:25] <IntuitiveNipple> 2.6.28-9-generic... let me try 2.6.28-11
[21:29] <IntuitiveNipple> cody-somerville: 2.6.28-11-generic live-CD i386 ISO does have squashfs here
[21:30] <IntuitiveNipple> cody-somerville: (in the initrd) I modprobed it and it shows in /proc/filesystems
[21:30] <cody-somerville> I wonder why it isn't showing up in my custom build for OEM Services
[21:31] <IntuitiveNipple> different config for the initrd possibly?
[21:32] <cody-somerville> I use the same initrd from archive.ubuntu.com
[21:32] <IntuitiveNipple> is that the casper initrd?
[21:33] <cody-somerville> no, d-i's
[21:34] <IntuitiveNipple> what's the path to the one you use?
[21:34] <cody-somerville> http://archive.ubuntu.com/ubuntu/dists/jaunty/main/installer-i386/current/images/
[21:36] <IntuitiveNipple> which do you use? the cdrom/ ?
[21:37] <cody-somerville> yup
[21:39] <IntuitiveNipple> The initrd from there  doesn't have the ubuntu/ modules path in it
[21:39] <cody-somerville> So what do I have to do to fix that?
[21:43] <IntuitiveNipple> I'm not sure. I've not touched those before.
[21:43] <cody-somerville> Does the kernel provide subsets of modules in udebs or anything like that?
[21:44] <IntuitiveNipple> yes, in http://archive.ubuntu.com/ubuntu/pool/main/l/linux/
[21:44] <cody-somerville> Whats the name of the udeb I need for squashfs support?
[21:45] <IntuitiveNipple> fs-secondary-modules....
[21:45] <cody-somerville> I figured as much...
[21:45] <cody-somerville> I have that in the pool
[21:46] <IntuitiveNipple> But, that doesn't contain squashfs... need to dig deeper :)
[21:48] <cody-somerville> yea, I was just going to say
[21:55] <cody-somerville> IntuitiveNipple, could any of these be it? http://pastebin.ubuntu.com/139208/
[21:55] <IntuitiveNipple> I've opened several to find it but not seen it so far
[21:58] <cody-somerville> squashfs-source claims to have the source for the kernel modules
[22:00] <smb_tp> ogasawara, thanks
[22:08] <cody-somerville> IntuitiveNipple, is there no lum for 2.6.28?
[22:15] <IntuitiveNipple> cody-somerville: that's correct. L-U-M was dropped for Intrepid and merged into the main kernel source, in the ubuntu/ directory


[01:31] <cjohnston> svwilliams: https://lists.ubuntu.com/mailman/listinfo/community-web-projects
[20:11] <cjohnston> mhall119: email
[20:58] <cjohnston> mhall119: nigelb why would a db field be clearing out every 24 hours? its a char field
[20:59] <mhall119> cjohnston: in summit?
[20:59] <cjohnston> ltp
[20:59] <cjohnston> our override name
[20:59] <mhall119> btw, the local_settings in the email looks okay to me, do we know what linaro is using?
[20:59] <nigelb> what db field?
[20:59] <mhall119> cjohnston: is the lpupdate process resetting it?
[20:59] <cjohnston> no i dont
[21:00] <nigelb> mhall119: hey, did you see the upgrade thing for django 1.3 for authentication modules?
[21:00] <cjohnston> mhall119: the override name should only be set manually.. lpupdate shouldnt be touching it
[21:00] <nigelb> (openid_auth in particular)
[21:00] <cjohnston>     override_name = models.CharField(_("Override Imported Team Name"), max_length=80, null=True, blank=True)
[21:01] <nigelb> Oh, this is LTP.
[21:01] <cjohnston> ya
[21:01]  * nigelb gets back to what he was doign.
[21:01] <nigelb> :P
[21:01] <cjohnston> nigelb: do some summit work ;-)
[21:01] <nigelb> cjohnston: ya, 'm looking at the upgrade
[21:02] <nigelb> mhall119: do you have some time to help me?
[21:02] <cjohnston> cool
[21:02] <nigelb> after the upgrade all our tests break. WIIN.
[21:02] <cjohnston> nice
[21:04] <nigelb> mhall119: http://paste.ubuntu.com/730405/
[21:04] <nigelb> It still works, but you guys should probably know.
[21:05] <mhall119> james_w: happy birthday!
[21:05] <nigelb> oooh
[21:05] <cjohnston> happy birthday james_w !
[21:06] <nigelb>  _   _    _    ____  ______   __  ____ ___ ____ _____ _   _ ____    _ __   __
[21:06] <nigelb> | | | |  / \  |  _ \|  _ \ \ / / | __ )_ _|  _ \_   _| | | |  _ \  / \\ \ / /
[21:06] <nigelb> | |_| | / _ \ | |_) | |_) \ V /  |  _ \| || |_) || | | |_| | | | |/ _ \\ V /
[21:06] <nigelb> |  _  |/ ___ \|  __/|  __/ | |   | |_) | ||  _ < | | |  _  | |_| / ___ \| |
[21:06] <nigelb> |_| |_/_/   \_\_|   |_|    |_|   |____/___|_| \_\|_| |_| |_|____/_/   \_\_|
[21:06] <cjohnston> troll!
[21:06] <nigelb>
[21:06] <nigelb> :D
[21:06] <nigelb> haha
[21:07] <cjohnston> mhall119: twice last week I WATCHED hauts add the override name of Ubuntu France to his team.. and twice I checked and it was back to ubuntu-fr
[21:07] <cjohnston> I just changed it in the admin area...
[21:07] <nigelb> mhall119: Thoughts on this error I see when running tests? http://paste.ubuntu.com/730414/
[21:08] <cjohnston> http://paste.ubuntu.com/730415/  why does it add the field and then delete the field
[21:13] <mhall119> nigelb: eating lunch,  I'll check it in a few
[21:13] <nigelb> mhall119: cool, thanks. I'm digging as well.
[21:14] <mhall119> cjohnston: it's gotta be something in the lpupdate then
[21:16] <mhall119> nigelb: I recall encountering that wsgi.input error in ISD, I think we just added it into the env dict as an empty string or something
[21:22] <mhall119> nigelb: on line 79 of schedule/tests.py, add wsgi.input as an empty string
[21:22] <mhall119> should allow the tests to proceed
[21:22] <mhall119> nigelb: http://paste.ubuntu.com/730425/ is what is in our test that had the same problem
[21:23] <cjohnston> mhall119: power went out for nigelb.. he says he will look in the morning
[21:23] <mhall119> ok
[21:23] <cjohnston> mhall119: could you take a look at mine as well please?
[21:24] <mhall119> sure
[21:24] <mhall119> cjohnston: it's a migration file, it has a forward() and backward() function
[21:24] <mhall119> forward() adds the field
[21:25] <mhall119> backward() removed it (for rollbacks, etc)
[21:33] <mhall119> I don't see anything in the code that might be re-setting it
[21:33] <mhall119> did you verify that it was being saved?
[21:37] <nigelb> back!
[21:37] <nigelb> yay power
[21:39] <nigelb> mhall119: \o/ down to 2 errors
[21:39] <nigelb> Both something to do with SSL handshake.
[21:39] <mhall119> nigelb: was lack of power one of the errors?
[21:39] <nigelb> heh
[21:39] <mhall119> nigelb: bah, I had that before too, something failing trying to connect to Launchpad
[21:40] <mhall119> nigelb: is this running lpupdate, or running tests?
[21:40] <nigelb> mhall119: just tests
[21:40] <nigelb> http://paste.ubuntu.com/730435/
[21:40] <mhall119> that probably means we should be mocking something outthen
[21:40] <nigelb> Yeah
[21:40] <nigelb> I'm thinking oof creating a launchpad app
[21:41] <mhall119> nigelb: might be a useful separation
[21:41] <nigelb> I'll do a quick test and propose the move to 1.3
[21:41] <nigelb> and then work on that
[21:41] <mhall119> and yeah, that was a quick test I added for a fix for jcastro during sponsorship applications, it should be mocked out properly
[21:42] <nigelb> Shall I ignore this for now and instead fix it after the move?
[21:42] <mhall119> yeah
[21:42] <nigelb> cool
[21:42] <mhall119> for now, if "manage.py test schedule" all pass, I'm happy
[21:42] <nigelb> I'm so glad we have tests :)
[21:42] <nigelb> This migration would have been painful otherwise :)
[21:42] <mhall119> yeah
[21:43] <mhall119> it may still be painful, we didn't have 100% test coverage
[21:43] <nigelb> ./manage.py test schedule works perfectly.
[21:43] <mhall119> any code we didn't touch in the past 6 months doesn't have tests
[21:43] <mhall119> ok, tests on the sponsor app can be fixed later then
[21:43] <mhall119> file a bug for the failing test and you can assign it to me
[21:44] <nigelb> cool, ok
[21:44] <nigelb> I'll file a bug for the launchpad separation as well.
[21:44] <mhall119> ok
[21:44] <nigelb> cjohnston: Get people to stop playing with that stupid bug.
[21:44] <mhall119> well, we were going to make a common app, would it make more sense to just put the launchpad code in there rather than it's own app?
[21:45] <nigelb> launchpad on its own will let us do things like run against staging or local dev
[21:45] <nigelb> we could use a django setting for production, staging, qastaging, and dev.
[21:45] <mhall119> we can't do that now with a local_settings.py variable?
[21:45] <nigelb> Not easily.
[21:45] <mhall119> ok
[21:45] <nigelb> We also use launchpadlib in certain places
[21:46] <mhall119> yeah, but I don't think that alone needs a separate app
[21:46] <mhall119> LTP has ./common/launchpad.py
[21:46] <nigelb> Oh.
[21:46] <nigelb> That might work :)
[21:47] <mhall119> cjohnston: nigelb: so which of you is going to be project manager this cycle?
[21:47] <nigelb> I can do it. Hopefully more effectively than last cycle.
[21:47] <mhall119> or should I flip a coin? loser gets the job?
[21:48] <nigelb> haha
[21:48] <mhall119> as long as it isn't me, I'll be happy
[21:48] <nigelb> heh
[21:51] <nigelb> mhall119: So, I've been thinking about this render.py clean up more.
[21:51] <nigelb> I wonder, should we render the plenary like we do currently?
[21:52] <nigelb> Can the plenary room be one room?
[21:52] <nigelb> and used like any other room
[21:53] <mhall119> nigelb: it's rendered the way it is so that nothing get's scheduled in any other rooms during the plenary time slot
[21:53] <nigelb> Ahh.
[21:53] <nigelb> fuuuu.
[21:53] <mhall119> besides, we're going to get a new UI for desktop users
[21:53] <nigelb> I realized now that we have to handle that as well.
[21:53] <nigelb> when is this UI going to be ready?
[21:53] <mhall119> so render.py can be relegated to just doing the screens at UDS
[21:53] <mhall119> nigelb: I have no idea
[21:54] <nigelb> Ideally, I want render.py out.
[21:54] <nigelb> We should be rendering everything using the same code.
[21:54] <mhall119> yes, I agree
[21:54] <nigelb> Also, have you used django's sites module?
[21:54] <mhall119> but it'll be easier to replace the functionality in separate, clean code, rather than trying to fix the mess that is render.py
[21:55] <nigelb> Maybe that's our solution to the linaro hard-coding.
[21:55] <mhall119> nigelb: only for testing
[21:55] <nigelb> Okay, so I tend to agree with you there.
[21:55] <mhall119> nigelb: sites framework would work, yes
[21:55] <nigelb> Maybe I'll work on a new class called display.py with new code.
[21:56] <nigelb> So they can coexist while I code.
[21:58] <mhall119> that sounds good to me
[21:59] <mhall119> I'd like to see a clean separation between the data model that calculates the schedule, and the code that produces the view of it
[21:59] <nigelb> I think I'll do it like you suggested.
[22:00] <nigelb> Get everything loaded into a class
[22:00] <nigelb> and then do the looping and stuff in the template
[22:00] <nigelb> possibly using helpers
[22:05] <nigelb> mhall119: I've made summit incompatible with Django 1.1
[22:05] <nigelb> Well, there was no other way :)
[22:06] <cjohnston> mhall119: re: verify if its being saved, we went to /teams and it showed up with the override name
[22:09] <cjohnston> nigelb: for mobile we want the screen to look like guidebook
[22:09] <nigelb> cjohnston: dream on.
[22:09] <cjohnston> mhall119: i dont think we really decided too much on a desktop view did we?
[22:09] <cjohnston> dream on for the mobile view?
[22:10] <nigelb> dream on for making it look like guidebook.
[22:10] <cjohnston> why
[22:11] <mhall119> nigelb: johnoxton is going to develop the mobile UI for us
[22:11] <mhall119> using HTML/CSS
[22:11] <mhall119> weren't you on skype for that session?
[22:11] <nigelb> Yeah
[22:11] <nigelb> I think its a better idea to *not* make it look like guidebook.
[22:12] <mhall119> oh, ok
[22:12] <cjohnston> not color and all, but similar layout
[22:12] <cjohnston> http://guidebookapp.com/static/corp/img/screenshots/phoneshot-schedule-3.png
[22:12] <mhall119> I think it's just going to be a fall-back option, I think we'll still use guidebook next UDS anyway
[22:12] <nigelb> That's easy.
[22:12] <nigelb> I can do that
[22:12] <cjohnston> thats what we want
[22:12] <nigelb> We don't eeven need to muck up with render.py for that.
[22:13] <mhall119> we're not going to muck up with render.py at all
[22:13] <nigelb> cjohnston: can you send me more screenshots from your phone?
[22:13] <mhall119> treat render.py as read-only and just write new code
[22:13] <nigelb> +1
[22:13] <cjohnston> mhall119: i think if we get mobile summit looking better than guidebook, we dont need guidebook... i wonder if we could talk them into giving us 15 minutes after the keynote for a "new summit how-to"
[22:13] <cjohnston> nigelb: itll be a few days
[22:13] <cjohnston> http://guidebookapp.com/features/
[22:13] <nigelb> cjohnston: sure
[22:14] <mhall119> then when we don't need render.py anymore  we'll throw a party with cake and fireworks and play rock-paper-scissors for who gets the honor of running "bzr remove render.py"
[22:14] <nigelb> cjohnston: We could a youtube video instead
[22:14] <cjohnston> send out the video the week before or something?
[22:14] <mhall119> +1 for a video, we could link to it on summit.u.c too
[22:15] <nigelb> cjohnston: Yeah, we could announce it on uds-announce as soon as its up.
[22:15] <mhall119> cjohnston: the benefit of guidebook is that it runs offline with a copy of the schedule, much less network usage
[22:15] <cjohnston> mhall119: but everyone cries about it all week
[22:15] <mhall119> and I don't think Canonical paid more than a couple hundred dollars for it
[22:15] <cjohnston> ya
[22:15] <cjohnston> i dont like this city search bug
[22:16] <mhall119> for LTP?
[22:16] <cjohnston> ya
[22:16] <cjohnston> where are the cities supposed to come from
[22:16] <mhall119> I don't know how we'd go about implementing it without going to an outside source
[22:16] <cjohnston> or make the admins list big cities or something
[22:16] <cjohnston> but that sounds like a ton of work
[22:16] <mhall119> yeah, I'm going to -1 that one
[22:16] <cjohnston> im ok with that
[22:17] <mhall119> simplest solution, add a TextField called "keywords" or "search terms" for the admin to fill out
[22:17] <cjohnston> ya
[22:17] <nigelb> Is that the one where we show venues but no teams?
[22:17] <cjohnston> ya
[22:17] <cjohnston> and venues arent linked to teams
[22:17] <cjohnston> mhall119: bug 886938
[22:17] <mhall119> I thought the problem was they wanted to enter a city name in the search field, and get the state-wide team in the results
[22:18] <mhall119> nothing to do with venues
[22:18] <cjohnston> mhall119: bug #886938
[22:18] <cjohnston> thats what they want
[22:18] <cjohnston> but they get venues
[22:18] <mhall119> oh, ok
[22:18] <cjohnston> mhall119: http://loco.ubuntu.com/teams/ ctrl f "france"
[22:18] <cjohnston> then tomorrow do the same
[22:18] <cjohnston> where is the stupid bug bot
[22:18] <nigelb> I don't know what cjohnston has against the French Team :P
[22:19] <nigelb> Maybe we'll never know.
[22:19]  * cjohnston slapps nigelb
[22:19] <nigelb> Bad vacation there or something? :P
[22:19] <cjohnston> nigelb: if you look right now, its using the override name.. tomorrow, it wont be
[22:19] <cjohnston> hauts went ahead and applied the override name before the blog post and all
[22:20] <mhall119> cjohnston: is there any chance that this is just another admin unsetting it?
[22:21] <cjohnston> mhall119: its only a LC field
[22:21] <cjohnston> or atleast is supposed to be only an LC field
[22:21] <mhall119> oh yeah, you're right
[22:22]  * cjohnston wants ask a favor and see if we can get loco-directory renamed to loco-team-portal on LP
[22:22] <cjohnston> https://blueprints.launchpad.net/loco-directory/+spec/locale-team-support  mhall119
[22:22] <mhall119> I'm not sure what that would require
[22:22] <cjohnston> i dont know.. but i figure id ask a favor to a few of our friends in private to see if we could work it out
[22:22] <cjohnston> would you be against renaming it?
[22:23] <mhall119> no
[22:23] <cjohnston> i dont know that i want to do it if we have to create a new project
[22:23] <mhall119> I don't think it's a big deal though, since the project name in LP doesn't matter to users
[22:23] <cjohnston> i know..
[22:27] <nigelb> mhall119: https://code.launchpad.net/~nigelbabu/summit/django-upgrade/+merge/81422
[22:28] <nigelb> cjohnston: https://code.launchpad.net/~nigelbabu/summit/crew-fix/+merge/81153
[22:28] <nigelb> There, work for both of you.
[22:28] <cjohnston> did yall see that i renamed summit in lp
[22:28] <nigelb> Yeah
[22:34]  * cjohnston is off.. company.. have a good night
[22:34] <nigelb> cjohnston: REVIEW THAT CODE!
[23:47]  * mhall119 dinner, no code review