remove bad comparison
* cannot compare with result generated directly for output cell
type, because going via the input type is allowed to cause
precision loss
@@ -48,12 +48,11 @@ void test_generic_cell_cast_with(const ValueBuilderFactory &factory) {
for (CellType in_type: CellTypeUtils::list_types()) {
for (CellType out_type: CellTypeUtils::list_types()) {
auto lhs = layout.cpy().cells(in_type);
- auto gen_expect = layout.cpy().cells(out_type);
- if (lhs.bad_scalar() || gen_expect.bad_scalar()) continue;
+ auto res_check = layout.cpy().cells(out_type);
+ if (lhs.bad_scalar() || res_check.bad_scalar()) continue;
SCOPED_TRACE(fmt("\n===\nLHS: %s\n===\n", lhs.gen().to_string().c_str()));
auto expect = ReferenceOperations::cell_cast(lhs, out_type);
auto actual = perform_generic_cell_cast(lhs, out_type, factory);
- EXPECT_EQ(expect, gen_expect);
EXPECT_EQ(actual, expect);
}
}
