Remove unused dep from android_integration_test and clarify comment about this mess that we have gotten ourselves into.
MOS_MIGRATED_REVID=147097283
@@ -10,12 +10,18 @@ sh_test(
srcs = ["android_integration_test.sh"],
data = [
"//src/test/shell/bazel:test-deps",
- # These targets should point to a filegroup with one single item: the
- # root directory of the NDK and the SDK. Note that this is incorrect,
- # but since they contain files with names that are not legal Bazel
- # labels, there isn't really a better option.
+ # These targets should point to filegroups containing the contents of
+ # the Android SDK and NDK. They *must not* contain any BUILD files that
+ # are generated by Android{S,N}dkRepositoryFunction, or else the
+ # integration will attempt to overwrite those files and fail. Note that
+ # this is incorrect because the filegroups should contain all of the
+ # files needed, but since they contain files with names that are not
+ # legal Bazel labels, there isn't really a better option.
+ #
+ # The definitions of these filegroups are in
+ # tools/android/android_sdk_repository_template.bzl and
+ # src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_build_file_template.txt
"//external:android_ndk_for_testing",
"//external:android_sdk_for_testing",
- "//src/tools/android/java/com/google/devtools/build/android:ResourceProcessorBusyBox_deploy.jar",
],
)
