Make --sandbox_base and --sandbox_default_allow_network non-experimental
It seems likely that we'll keep these flags, and we don't want users to rely on experimental flags (as much as possible) for their production builds.
Progress on
@@ -102,16 +102,16 @@ public class SandboxOptions extends OptionsBase {
public boolean sandboxDebug;
@Option(
- name = "experimental_sandbox_base",
+ name = "sandbox_base",
+ oldName = "experimental_sandbox_base",
defaultValue = "",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.UNKNOWN},
help =
- "Lets the sandbox create its sandbox directories underneath this path. Specify a path "
- + "on tmpfs (like /run/shm) to possibly improve performance a lot when your build / "
- + "tests have many input files. Note: You need enough RAM and free space on the tmpfs "
- + "to hold output and intermediate files generated by running actions."
- )
+ "Lets the sandbox create its sandbox directories underneath this path. Specify a path on"
+ + " tmpfs (like /run/shm) to possibly improve performance a lot when your build /"
+ + " tests have many input files. Note: You need enough RAM and free space on the"
+ + " tmpfs to hold output and intermediate files generated by running actions.")
public String sandboxBase;
@Option(
@@ -318,11 +318,14 @@ public class SandboxOptions extends OptionsBase {
public boolean dockerPrivileged;
@Option(
- name = "experimental_sandbox_default_allow_network",
+ name = "sandbox_default_allow_network",
+ oldName = "experimental_sandbox_default_allow_network",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.UNKNOWN},
- help = "Allow network access by default for actions.")
+ help =
+ "Allow network access by default for actions; this may not work with all sandboxing "
+ + "implementations.")
public boolean defaultSandboxAllowNetwork;
@Option(
