Explain timeout
@@ -522,7 +522,13 @@ public class InternalStepRunner implements StepRunner {
return controller.applications().require(id);
}
- /** Returns whether the time elapsed since the last real deployment in the given zone is more than the given timeout. */
+ /**
+ * Returns whether the time since deployment is more than the zone deployment expiry, or the given timeout.
+ *
+ * We time out the job before the deployment expires, for zone where deployments are not persistent,
+ * to be able to collect the Vespa log from the deployment. Thus, the lower of the zone's deployment expiry,
+ * and the given default installation timeout, minus one minute, is used as a timeout threshold.
+ */
private boolean timedOut(Deployment deployment, Duration defaultTimeout) {
Duration timeout = controller.zoneRegistry().getDeploymentTimeToLive(deployment.zone())
.filter(zoneTimeout -> zoneTimeout.compareTo(defaultTimeout) < 0)
