Meaningfully name a local variable in addReverseDepAndCheckIfDone
Also flips the meaning of the boolean variable for more positivity.
RELNOTES: None.
@@ -387,11 +387,11 @@ public class InMemoryNodeEntry implements NodeEntry {
if (dirtyBuildingState == null) {
dirtyBuildingState = DirtyBuildingState.createNew();
}
- boolean result = !dirtyBuildingState.isEvaluating();
- if (result) {
+ boolean wasEvaluating = dirtyBuildingState.isEvaluating();
+ if (!wasEvaluating) {
dirtyBuildingState.startEvaluating();
}
- return result ? DependencyState.NEEDS_SCHEDULING : DependencyState.ALREADY_EVALUATING;
+ return wasEvaluating ? DependencyState.ALREADY_EVALUATING : DependencyState.NEEDS_SCHEDULING;
}
/** Sets {@link #reverseDeps}. Does not alter {@link #reverseDepsDataToConsolidate}. */
