Make --verbose_failures imply --materialize_param_files
the verbose failure message may include command lines with param
files.
@@ -127,7 +127,7 @@ public class ExecutionOptions extends OptionsBase {
help =
"Writes intermediate parameter files to output tree even when using "
+ "remote action execution. Useful when debugging actions. "
- + "This is implied by --subcommands.")
+ + "This is implied by --subcommands and --verbose_failures.")
public boolean materializeParamFiles;
@Option(
@@ -139,8 +139,10 @@ public class ExecutionOptions extends OptionsBase {
public boolean materializeParamFilesDirectly;
public boolean shouldMaterializeParamFiles() {
- // Implied by --subcommands
- return materializeParamFiles || showSubcommands != ActionExecutionContext.ShowSubcommands.FALSE;
+ // Implied by --subcommands and --verbose_failures
+ return materializeParamFiles
+ || showSubcommands != ActionExecutionContext.ShowSubcommands.FALSE
+ || verboseFailures;
}
@Option(
