Make default value of flavour in java_proto_common.create_java_lite_p?
?roto_compile_action a string
The default value for flavour was a global object called `java` instead of a string with the value `java`, resulting in a crash if this function was used.
Closes
@@ -41,42 +41,33 @@ public interface JavaProtoCommonApi<FileT extends FileApi,
positional = true,
named = false,
type = SkylarkRuleContextApi.class,
- doc = "The rule context."
- ),
+ doc = "The rule context."),
@Param(
name = "target",
positional = true,
named = false,
type = TransitiveInfoCollectionApi.class,
- doc = "The target."
- ),
- @Param(
- name = "src_jar",
- positional = false,
- named = true,
- type = FileApi.class
- ),
+ doc = "The target."),
+ @Param(name = "src_jar", positional = false, named = true, type = FileApi.class),
@Param(
name = "proto_toolchain_attr",
positional = false,
named = true,
- type = String.class
- ),
+ type = String.class),
@Param(
name = "flavour",
positional = false,
named = true,
type = String.class,
- defaultValue = "java"
- )
- }
- )
+ defaultValue = "'java'")
+ })
public void createProtoCompileAction(
SkylarkRuleContextT skylarkRuleContext,
TransitiveInfoCollectionT target,
FileT sourceJar,
String protoToolchainAttr,
- String flavour) throws EvalException;
+ String flavour)
+ throws EvalException;
@SkylarkCallable(
name = "has_proto_sources",
