Update download servlet to try-with-resources block.
@@ -4,7 +4,6 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
-import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
@@ -15,12 +14,12 @@ public class DownloadServlet extends HttpServlet {
private final int ARBITARY_SIZE = 1048;
@Override
- protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
+ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
resp.setContentType("text/plain");
resp.setHeader("Content-disposition", "attachment; filename=sample.txt");
- OutputStream out = resp.getOutputStream();
- InputStream in = req.getServletContext().getResourceAsStream("/WEB-INF/sample.txt");
+ try (InputStream in = req.getServletContext().getResourceAsStream("/WEB-INF/sample.txt");
+ OutputStream out = resp.getOutputStream()) {
byte[] buffer = new byte[ARBITARY_SIZE];
@@ -28,8 +27,6 @@ public class DownloadServlet extends HttpServlet {
while ((numBytesRead = in.read(buffer)) > 0) {
out.write(buffer, 0, numBytesRead);
}
-
- in.close();
- out.flush();
+ }
}
}
