fix: Add logic check to allow visible water under other blocks
@@ -142,6 +142,13 @@ private boolean isSideVisibleForBlockTypes(Block blockToCheck, Block currentBloc
return false;
}
+ //TODO: This only fixes the "water under block" issue of the top side not being rendered. (see bug #3889)
+ //Note: originally tried .isLiquid() instead of isWater for both checks, but IntelliJ was warning that
+ // !blockToCheck.isWater() is always true, may need further investigation
+ if (currentBlock.isWater() && (side == Side.TOP) && !blockToCheck.isWater()){
+ return true;
+ }
+
return currentBlock.isWaving() != blockToCheck.isWaving() || blockToCheck.getMeshGenerator() == null
|| !blockToCheck.isFullSide(side.reverse()) || (!currentBlock.isTranslucent() && blockToCheck.isTranslucent());
