Fix closure tests by not stripping data attribute
@@ -63,13 +63,16 @@ def selenium_test(name, test_class, size = "medium", browsers = None, **kwargs):
tests = []
test_name = test_class.rpartition(".")[2]
+ data = kwargs["data"] if "data" in kwargs else []
jvm_flags = kwargs["jvm_flags"] if "jvm_flags" in kwargs else []
tags = kwargs["tags"] if "tags" in kwargs else []
stripped_args = dict(**kwargs)
+ stripped_args.pop("data", None)
stripped_args.pop("jvm_flags", None)
stripped_args.pop("tags", None)
+
for browser in browsers:
if not browser in _BROWSERS:
fail("Unrecognized browser: " + browser)
@@ -82,14 +85,12 @@ def selenium_test(name, test_class, size = "medium", browsers = None, **kwargs):
size = size,
jvm_flags = _BROWSERS[browser]["jvm_flags"] + jvm_flags,
tags = _BROWSERS[browser]["tags"] + tags,
+ data = data,
**stripped_args
)
tests.append(test)
if not "no-remote" in tags:
- data = kwargs["data"] if "data" in kwargs else []
- stripped_args.pop("data", None)
-
native.java_test(
name = "%s-remote" % test,
test_class = test_class,
