Added TODO for the process runner
@@ -23,7 +23,9 @@ class DefaultReleaseDateProvider implements ReleaseDateProvider {
for (String version: versions) {
String tag = tagPrefix + version;
String date = runner.run("git", "log", "--pretty=%ad", "--date=iso", tag, "-n", "1");
- //example output returned by running git command: 2017-01-29 08:14:09 -0800
+ //TODO process runner needs to fail on error here.
+ // Otherwise the 'date' variable holds some error message and not really any date.
+ //Example output returned by running git command: 2017-01-29 08:14:09 -0800
Date d = parseDate(date.trim());
out.put(version, d);
}
