entitlement: Fix merge issue
Test behavior had changed because of [this](https://github.com/killbill/killbill/commit/4b32961271d7553d25f4db27e48fa94e7729235d#diff-c4b5e59c2cde4f93acd9024a1dc86b895e246cdd8140752ced39ad6ae39d6450R361), so we need to remove the test assertions accordingly.
@@ -674,12 +674,6 @@ public class TestDefaultEntitlementApi extends EntitlementTestSuiteWithEmbeddedD
final PlanPhaseSpecifier spec2 = new PlanPhaseSpecifier("Pistol", BillingPeriod.MONTHLY, PriceListSet.DEFAULT_PRICELIST_NAME, null);
- try {
- entitlement.changePlanWithDate(new DefaultEntitlementSpecifier(spec2), entitlementDate, Collections.emptyList(), callContext);
- Assert.fail("Change plan prior billingStartDate should fail");
- } catch (EntitlementApiException e) {
- Assert.assertEquals(e.getCode(), ErrorCode.SUB_INVALID_REQUESTED_DATE.getCode());
- }
// effectiveDate is null (same as first case above), but **did** reach the billing startDate (and entitlement startDate) so will succeed
clock.addDeltaFromReality(1000); // Add one sec to make sure CHANGE event does not coincide with CREATE (realistic scenario), and therefore we do expect a CHANGE event
