Clean up `ath.sh`
@@ -3,19 +3,19 @@ set -o errexit
set -o nounset
set -o pipefail
set -o xtrace
-cd $(dirname $0)
+cd "$(dirname "$0")"
# https://github.com/jenkinsci/acceptance-test-harness/releases
export ATH_VERSION=5478.vb_b_cd04943676
# TODO use Artifactory proxy?
-[ -f war/target/jenkins.war ] || mvn -B -ntp -Pquick-build -am -pl war package
+[[ -f war/target/jenkins.war ]] || mvn -B -ntp -Pquick-build -am -pl war package
mkdir -p target/ath-reports
chmod a+rwx target/ath-reports
-docker run --rm \
+exec docker run --rm \
--env ATH_VERSION \
--shm-size 2g `# avoid selenium.WebDriverException exceptions like 'Failed to decode response from marionette' and webdriver closed` \
--volume "$(pwd)"/war/target/jenkins.war:/jenkins.war:ro \
@@ -23,14 +23,14 @@ docker run --rm \
--volume "$(pwd)"/target/ath-reports:/reports:rw \
--interactive \
jenkins/ath:"$ATH_VERSION" \
- bash <<'INSIDE'
+ bash <<-'INSIDE'
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace
cd
# Start the VNC system provided by the image from the default user home directory
-eval $(vnc.sh)
+ eval "$(vnc.sh)"
env | sort
git clone --branch "$ATH_VERSION" --depth 1 https://github.com/jenkinsci/acceptance-test-harness
cd acceptance-test-harness
