Fixed text in CONTRIBUTING.md
@@ -66,7 +66,7 @@ This document will guide you through the contribution process.
Fork the project [on Github](https://github.com/seleniumhq/selenium)
and check out your copy locally.
-```text
+```shell
% git clone git@github.com:username/selenium.git
% cd selenium
% git remote add upstream git://github.com/seleniumhq/selenium.git
@@ -75,14 +75,15 @@ and check out your copy locally.
#### Dependencies
We bundle dependencies in the _third-party/_ directory that is not
-part of the project proper. Any changes to files in this directory or
+part of the proper project. Any changes to files in this directory or
its subdirectories should be sent upstream to the respective projects.
Please don't send your patch to us as we cannot accept it.
We do accept help in upgrading our existing dependencies or removing
superfluous dependencies. If you need to add a new dependency it's
-often a good idea to reach out to the committers on the IRC channel or
-the mailing list to check that your approach aligns with the project's
+often a good idea to reach out to the committers on the
+[IRC channel or the mailing list](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#communication)
+to check that your approach aligns with the project's
ideas. Nothing is more frustrating than seeing your hard work go to
waste because your vision doesn't align with the project's.
@@ -119,7 +120,7 @@ file found in the top-level directory.
Create a feature branch and start hacking:
-```text
+```shell
% git checkout -b my-feature-branch
```
@@ -130,7 +131,7 @@ directly on top of master.
First make sure git knows your name and email address:
-```text
+```shell
% git config --global user.name 'Santa Claus'
% git config --global user.email 'santa@example.com'
```
@@ -170,7 +171,7 @@ run `git shortlog` or `git log --oneline`.
Use `git rebase` (not `git merge`) to sync your work from time to time.
-```text
+```shell
% git fetch upstream
% git rebase upstream/master
```
@@ -182,7 +183,7 @@ see how they should be structured.
Before you submit your pull request make sure you pass all the tests:
-```text
+```shell
% ./go clean test
```
@@ -199,13 +200,13 @@ it.
### Step 7: Push
-```text
+```shell
% git push origin my-feature-branch
```
Go to https://github.com/yourusername/selenium.git and press the _Pull
Request_ and fill out the form. **Please indicate that you've signed
-the CLA** (see step 6).
+the CLA** (see Step 6).
Pull requests are usually reviewed within a few days. If there are
comments to address, apply your changes in new commits (preferably
@@ -244,7 +245,7 @@ The review labels (**R**) are:
Issues are labelled to make them easier to categorise and find by:
-* which **component** they relate to (java, cpp, dotnet, py, rb)
+* which **component** they relate to (java, cpp, dotnet, py, rb, nodejs)
* which **driver** is affected
* their presumed **difficulty** (easy, less easy, hard)
* what **type** of issue they are (defect, race condition, cleanup)
