The test should be explicit, removed lowercase handling
When reading the test, it's best if I can immediately figure out what the code does. If 'toLowerCase()' is used, I don't know what exactly the code does.
@@ -6,12 +6,12 @@ class PluginValidatorTest extends Specification {
def "class candidates"(pluginId, candidates) {
expect:
- PluginValidator.getClassCandidates(pluginId)*.toLowerCase() == candidates*.toLowerCase()
+ PluginValidator.getClassCandidates(pluginId)*.toString() == candidates*.toString()
where:
pluginId | candidates
'org.shipkit.bintray' | ['BintrayPlugin', 'ShipkitBintrayPlugin', 'OrgShipkitBintrayPlugin']
- 'org.shipkit.github-pom-contributors' | ['GitHubPomContributorsPlugin', 'ShipkitGitHubPomcontributorsPlugin', 'OrgShipkitGithubPomContributorsPlugin']
+ 'org.shipkit.github-pom-contributors' | ['GithubPomContributorsPlugin', 'ShipkitGithubPomContributorsPlugin', 'OrgShipkitGithubPomContributorsPlugin']
'org.shipkit.gradle-plugin' | ['GradlePlugin', 'ShipkitGradlePlugin', 'OrgShipkitGradlePlugin']
}
}
