test(ChunkMeshWorker): remove some difficult to implement tests about optimizations we probably don't need
@@ -118,14 +118,6 @@ void testChunkIsRegeneratedIfDirty() {
.verifyTimeout(Duration.ofSeconds(5));
}
- @Test
- @Disabled("TODO: How to do scenarios with mid-pipeline actions?")
- void testChunksDirtiedBetweenGenerationAndUploadAreUploadedAnyway() {
- // maybe redundant with testChunkIsRegeneratedIfDirty?
- // I guess the assertion is that the upload function did a thing
- // instead of skipping a thing.
- }
-
@Test
void testChunkCanBeRemovedBeforeMeshGeneration() {
var chunk = newDirtyChunk(position0);
@@ -154,17 +146,6 @@ void testDoubleRemoveIsNoProblem() {
.verifyTimeout(Duration.ofSeconds(5));
}
- @Test
- @Disabled("TODO: How to do scenarios with mid-pipeline actions?")
- void testChunkCanBeRemovedBeforeUpload() {
- var chunk = newDirtyChunk(position0);
- worker.add(chunk);
- // tick so generation is finished, but not upload
- worker.remove(chunk);
- // drain
- fail("assert upload did not happen for chunk");
- }
-
@Test
void testChunkCanBeRemovedByPosition() {
var chunk = newDirtyChunk(position0);
@@ -202,6 +183,4 @@ void testWorkIsPrioritized() {
void testWorkerStopsWhenShutDown() {
fail("TODO: add shutdown method");
}
-
- // What else? More parallelization tests?
}
