MINOR: Change the order that Connect calls `config()` and `validate()` to avoid validating if the required ConfigDef is null
Author: Randall Hauch
Reviewer: Konstantine Karantasis
@@ -341,20 +341,20 @@ public abstract class AbstractHerder implements Herder, TaskStatus.Listener, Con
Set<String> allGroups = new LinkedHashSet<>(enrichedConfigDef.groups());
// do custom connector-specific validation
- Config config = connector.validate(connectorProps);
- if (null == config) {
+ ConfigDef configDef = connector.config();
+ if (null == configDef) {
throw new BadRequestException(
String.format(
- "%s.validate() must return a Config that is not null.",
+ "%s.config() must return a ConfigDef that is not null.",
connector.getClass().getName()
)
);
}
- ConfigDef configDef = connector.config();
- if (null == configDef) {
+ Config config = connector.validate(connectorProps);
+ if (null == config) {
throw new BadRequestException(
String.format(
- "%s.config() must return a ConfigDef that is not null.",
+ "%s.validate() must return a Config that is not null.",
connector.getClass().getName()
)
);
