Documented:  MacroFormRenderer refactoring
Adds a FIXME about: SpotBugs reporting:
Argument 1 is definitely null but must not be null
*******************************************************************************/
package org.apache.ofbiz.widget.renderer.macro;
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableMap;
-import freemarker.core.Environment;
-import freemarker.template.Template;
-import mockit.Expectations;
-import mockit.Injectable;
-import mockit.Mock;
-import mockit.MockUp;
-import mockit.Mocked;
-import mockit.Tested;
-import mockit.Verifications;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.empty;
+import static org.hamcrest.Matchers.not;
+import static org.hamcrest.Matchers.startsWith;
+
+import java.io.IOException;
+import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
import org.apache.ofbiz.base.util.UtilCodec.SimpleEncoder;
import org.apache.ofbiz.base.util.UtilHttp;
import org.apache.ofbiz.base.util.UtilProperties;
@@ -48,23 +56,18 @@ import org.hamcrest.Matchers;
import org.junit.Before;
import org.junit.Test;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
-import java.io.IOException;
-import java.io.StringWriter;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
-import java.util.stream.Collectors;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.containsString;
-import static org.hamcrest.Matchers.empty;
-import static org.hamcrest.Matchers.not;
-import static org.hamcrest.Matchers.startsWith;
+import freemarker.core.Environment;
+import freemarker.template.Template;
+import mockit.Expectations;
+import mockit.Injectable;
+import mockit.Mock;
+import mockit.MockUp;
+import mockit.Mocked;
+import mockit.Tested;
+import mockit.Verifications;
public class MacroFormRendererTest {
@@ -841,7 +844,7 @@ public class MacroFormRendererTest {
{
modelForm.getPaginateTarget(withNotNull());
result = targetService;
-
+ // FIXME SpotBugs reports: Argument 1 is definitely null but must not be null
requestHandler.makeLink(null, null, withSubstring(qbeString));
result = linkFromQbeString;
}
@@ -868,7 +871,7 @@ public class MacroFormRendererTest {
modelForm.getPaginateTarget(withNotNull());
result = paginateTarget;
-
+ // FIXME SpotBugs reports: Argument 1 is definitely null but must not be null
requestHandler.makeLink(null, null, withSubstring(qbeString));
result = linkFromQbeString;
